date:20161230

New Defects reported by Coverity Scan for LibreOffice

2016-12-30 Thread scan-admin


Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

5 new defect(s) introduced to LibreOffice found with Coverity Scan.
12 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1398233:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/gdi/bitmapex.cxx: 93 in BitmapEx::BitmapEx(const rtl::OUString &)()



*** CID 1398233:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/gdi/bitmapex.cxx: 93 in BitmapEx::BitmapEx(const rtl::OUString &)()
87 CopyPixel( aDestRect, aSrcRect, &rBitmapEx );
88 }
89 
90 BitmapEx::BitmapEx( const OUString& rIconName )
91 {
92 loadFromIconTheme( rIconName );
>>> CID 1398233:  Uninitialized members  (UNINIT_CTOR)
>>> Non-static class member "bAlpha" is not initialized in this constructor 
>>> nor in any functions that it calls.
93 }
94 
95 BitmapEx::BitmapEx( const ResId& rResId ) :
96 eTransparent( TransparentType::NONE ),
97 bAlpha  ( false )
98 {

** CID 1398232:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/window/window.cxx: 825 in ImplFrameData::ImplFrameData(vcl::Window 
*)()



*** CID 1398232:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/window/window.cxx: 825 in ImplFrameData::ImplFrameData(vcl::Window 
*)()
819 maPaintIdle.SetDebugName( "vcl::Window maPaintIdle" );
820 maResizeIdle.SetPriority( SchedulerPriority::RESIZE );
821 maResizeIdle.SetIdleHdl( LINK( pWindow, vcl::Window, 
ImplHandleResizeTimerHdl ) );
822 maResizeIdle.SetDebugName( "vcl::Window maResizeIdle" );
823 mbInternalDragGestureRecognizer = false;
824 mbInBufferedPaint = false;
>>> CID 1398232:  Uninitialized members  (UNINIT_CTOR)
>>> Non-static class member field "maMapUnitRes.mfScaleY" is not 
>>> initialized in this constructor nor in any functions that it calls.
825 }
826 
827 namespace vcl {
828 
829 bool Window::AcquireGraphics() const
830 {

** CID 1398231:  Uninitialized variables  (UNINIT)
/vcl/workben/vcldemo.cxx: 853 in 
DemoRenderer::DrawBitmap::SimulateBorderStretch(OutputDevice &, const Rectangle 
&)()



*** CID 1398231:  Uninitialized variables  (UNINIT)
/vcl/workben/vcldemo.cxx: 853 in 
DemoRenderer::DrawBitmap::SimulateBorderStretch(OutputDevice &, const Rectangle 
&)()
847 RENDER_DETAILS(bitmap,KEY_B,10)
848 
849 // Simulate Page Borders rendering - which ultimately should
850 // be done with a shader / gradient
851 static void SimulateBorderStretch(OutputDevice &rDev, const 
Rectangle& r)
852 {
>>> CID 1398231:  Uninitialized variables  (UNINIT)
>>> Declaring variable "aPageShadowMask".
853 BitmapEx aPageShadowMask("sw/res/page-shadow-mask.png");
854 
855 BitmapEx aRight(aPageShadowMask);
856 sal_Int32 nSlice = (aPageShadowMask.GetSizePixel().Width() 
- 3) / 4;
857 // a width x 1 slice
858 aRight.Crop(Rectangle(Point((nSlice * 3) + 3, (nSlice * 2) 
+ 1),

** CID 1398230:  Incorrect expression  (IDENTICAL_BRANCHES)
/workdir/CustomTarget/vcl/unx/kde4/tst_exclude_posted_events.moc: 76 in 
TestExcludePostedEvents::qt_metacall(QMetaObject::Call, int, void **)()



*** CID 1398230:  Incorrect expression  (IDENTICAL_BRANCHES)
/workdir/CustomTarget/vcl/unx/kde4/tst_exclude_posted_events.moc: 76 in 
TestExcludePostedEvents::qt_metacall(QMetaObject::Call, int, void **)()
70 return QObject::qt_metacast(_clname);
71 }
72 
73 int TestExcludePostedEvents::qt_metacall(QMetaObject::Call _c, int _id, 
void **_a)
74 {
75 _id = QObject::qt_metacall(_c, _id, _a);
>>> CID 1398230:  Incorrect expression  (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "_id < 0" is true or 
>>> false, because the code in the if-then branch and after the if statement is 
>>> identical. Should the if statement be removed?
76 if (_id < 0)
77 return _id;
78 return _id;
79 }

** CID 1398229:  Control flow issues  (DEADCODE)
/svtools/source/misc/imagemgr.cxx: 547 in GetImageFromList_Impl(unsigned short, 
bool)()



*** CID 1398229:  Control flow issues  (DEADCODE)
/svtools/source/misc/imagemgr.cxx: 547 in GetImageFromLi

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - framework/Library_fwk.mk framework/source

2016-12-30 Thread Markus Mohrhard

 framework/Library_fwk.mk  |2 ++
 framework/source/services/desktop.cxx |2 ++
 2 files changed, 4 insertions(+)

New commits:
commit f5695bf6a868e14e28f06697b2803ff7d325e7cb
Author: Markus Mohrhard 
Date:   Wed Dec 28 23:57:36 2016 +0100

add a crashreporter entry when we start the shutdown

This will help us identify shutdown related crashes.

Reviewed-on: https://gerrit.libreoffice.org/32485
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

Conflicts:
framework/source/services/desktop.cxx

Change-Id: Id09c3dfdc94c430d5dcb2aebb017f17db80f17e5
Reviewed-on: https://gerrit.libreoffice.org/32487
Reviewed-by: Michael Meeks 
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/framework/Library_fwk.mk b/framework/Library_fwk.mk
index e6d0ae2..2246286 100644
--- a/framework/Library_fwk.mk
+++ b/framework/Library_fwk.mk
@@ -41,6 +41,8 @@ $(eval $(call gb_Library_use_libraries,fwk,\
 comphelper \
 cppu \
 cppuhelper \
+$(call gb_Helper_optional,BREAKPAD, \
+   crashreport) \
 fwe \
 fwi \
 i18nlangtag \
diff --git a/framework/source/services/desktop.cxx 
b/framework/source/services/desktop.cxx
index c8bf51f..e069905 100644
--- a/framework/source/services/desktop.cxx
+++ b/framework/source/services/desktop.cxx
@@ -62,6 +62,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -317,6 +318,7 @@ sal_Bool SAL_CALL Desktop::terminate()
 // see dispose() for further information.
 /* SAFE AREA 
---
 */
 SolarMutexClearableGuard aWriteLock;
+CrashReporter::AddKeyValue("ShutDown", OUString::boolean(true));
 m_bIsTerminated = true;
 aWriteLock.clear();
 /* UNSAFE AREA 
-
 */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

2016-12-30 Thread kerem

 sc/source/ui/formdlg/dwfunctr.cxx |   36 ++--
 1 file changed, 18 insertions(+), 18 deletions(-)

New commits:
commit ea860d52ade14b4a16289c81a0f8586799c6617f
Author: kerem 
Date:   Fri Dec 30 12:43:28 2016 +0200

fdo#39674 Rename klasse and funktion in dwfunctr.cxx

Change-Id: I4137b66eb76ebb7d2172e5c417fcb845cea55b47
Reviewed-on: https://gerrit.libreoffice.org/32507
Reviewed-by: TamÃ¡s Zolnai 
Tested-by: TamÃ¡s Zolnai 

diff --git a/sc/source/ui/formdlg/dwfunctr.cxx 
b/sc/source/ui/formdlg/dwfunctr.cxx
index 51ddbff..020fd44 100644
--- a/sc/source/ui/formdlg/dwfunctr.cxx
+++ b/sc/source/ui/formdlg/dwfunctr.cxx
@@ -42,9 +42,9 @@
 #*  Member: ScFunctionWin
 #*
 #*
-#*  Klasse: ScFunctionWin
+#*  Class:  ScFunctionWin
 #*
-#*  Funktion:   Konstruktor der Klasse ScFunctionWin
+#*  Function:   Constructor of ScFunctionWin Class
 #*
 #*  Input:  Sfx- Verknuepfungen, Fenster, Resource
 #*
@@ -88,9 +88,9 @@ ScFunctionWin::ScFunctionWin(vcl::Window* pParent, const 
css::uno::Reference___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: external/harfbuzz

2016-12-30 Thread Jochen Nitschke

 external/harfbuzz/ubsan.patch |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 83a9c8e046dfcaccdb1114ec5a386a11fcca3a02
Author: Jochen Nitschke 
Date:   Fri Dec 30 22:23:40 2016 +

build fix

apparently harfbuzz is not build with std=c++11 everywhere

Change-Id: Ie105706212d9dd32f33bc67c8a878ce8a55e60ef
Reviewed-on: https://gerrit.libreoffice.org/32521
Tested-by: Jenkins 
Reviewed-by: Jochen Nitschke 

diff --git a/external/harfbuzz/ubsan.patch b/external/harfbuzz/ubsan.patch
index 36b5a45..fde85cf 100644
--- a/external/harfbuzz/ubsan.patch
+++ b/external/harfbuzz/ubsan.patch
@@ -58,7 +58,7 @@
template 
inline const Type *bsearch (T *key) const
{
-+if (len == 0) return nullptr;
++if (len == 0) return NULL;
  return (const Type *) ::bsearch (key, array, len, sizeof (Type), 
(hb_compare_func_t) Type::cmp);
}
  
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

2016-12-30 Thread Gabor Kelemen

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7ed40deee74a9869b7da073ad473241187420ff8
Author: Gabor Kelemen 
Date:   Sat Dec 31 00:13:00 2016 +0100

Updated core
Project: help  add5f832ca414295b09ab8ef05aa73fb0d903705

tdf#105004 Remove some leftover mentions of spadmin

Also the Print direct behavior seems to be changed
at least on Linux, so drop that paragraph entirely

Change-Id: Iad9ba7209b083e40acf8453920e78469459f7a91
Reviewed-on: https://gerrit.libreoffice.org/32522
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/helpcontent2 b/helpcontent2
index fa16e1b..add5f83 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit fa16e1bbf6540d59e4c8890939e66be82ad1af0d
+Subproject commit add5f832ca414295b09ab8ef05aa73fb0d903705
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

2016-12-30 Thread Gabor Kelemen

 source/text/shared/02/0111.xhp   |3 ---
 source/text/shared/02/0202.xhp   |4 ++--
 source/text/shared/guide/spadmin.xhp |2 +-
 3 files changed, 3 insertions(+), 6 deletions(-)

New commits:
commit add5f832ca414295b09ab8ef05aa73fb0d903705
Author: Gabor Kelemen 
Date:   Sat Dec 31 00:13:00 2016 +0100

tdf#105004 Remove some leftover mentions of spadmin

Also the Print direct behavior seems to be changed
at least on Linux, so drop that paragraph entirely

Change-Id: Iad9ba7209b083e40acf8453920e78469459f7a91
Reviewed-on: https://gerrit.libreoffice.org/32522
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/source/text/shared/02/0111.xhp 
b/source/text/shared/02/0111.xhp
index 444a5b2..88fe640 100644
--- a/source/text/shared/02/0111.xhp
+++ b/source/text/shared/02/0111.xhp
@@ -45,9 +45,6 @@
 
 If the 
current document uses a printer that is not the default printer for your 
operating system, the Print File Direct icon opens the Print dialog.
 
-
-If the 
current document uses a printer that is not the default printer that was 
specified in the spadmin, 
printer administration program, the Print File Direct icon opens 
the Print 
dialog.
-
 
 
 
diff --git a/source/text/shared/02/0202.xhp 
b/source/text/shared/02/0202.xhp
index 27e9de2..696c786 100644
--- a/source/text/shared/02/0202.xhp
+++ b/source/text/shared/02/0202.xhp
@@ -54,7 +54,7 @@
 
  
   
-  In $[officename] you see the available fonts only if a printer is 
installed as the default printer in your system. With the spadmin program you 
can define a printer as the default printer. In 
order to install a printer as the default printer please refer to your 
operating system documentation.
+  In $[officename] you see the available fonts only if a printer is 
installed as the default printer in your system. In order to install a printer 
as the default printer please refer to your operating system 
documentation.
 You can see the name of the fonts 
formatted in their respective font if you mark the Preview in fonts 
lists field in $[officename] - View in the Options dialog 
box.
 
 
@@ -62,4 +62,4 @@
 
 
 
-
\ No newline at end of file
+
diff --git a/source/text/shared/guide/spadmin.xhp 
b/source/text/shared/guide/spadmin.xhp
index 1a5a726..cc80ef9 100644
--- a/source/text/shared/guide/spadmin.xhp
+++ b/source/text/shared/guide/spadmin.xhp
@@ -28,7 +28,7 @@
 
 
 
-spadmin
+
 printers; adding, UNIX
 default printer; UNIX
 standard printer under UNIX
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: getting error for building the libre office source code...

2016-12-30 Thread Vinodkumar Pache

changes in the argument in command line parameter for hindi as 'hi' in
autogen.sh
as —with-lang=hi

On December 27, 2016 at 3:14 PM Vinodkumar Pache  wrote:

> 
>  Dear Sir,
> 
> I am trying to build the Libre office 5.2.3.3 source code for Hindi .
>  It was successfully built for en but after changing the for 'hi' in
> autogen.sh for Hindi gives  below error after make command execution.
> 
> 
> 
> 
>  assertion failed
>  - Expression: nNonWhiteCount>100
>  - Tdf93124: vertical alignment of text is incorrect!
> 
>  E:/sources/libreoffice-5.2.3.3/sd/qa/unit/import-tests.cxx(1311) : error :
> Assertion
>  Test name: SdImportTest::testTdf93124
>  assertion failed
>  - Expression: nNonWhiteCount>100
>  - Tdf93124: vertical alignment of text is incorrect!
> 
>  Failures !!!
>  Run: 45   Failure total: 1   Failures: 1   Errors: 0
> 
>  Error: a unit test failed, please do one of:
>  make CppunitTest_sd_import_tests CPPUNITTRACE=TRUE # which is a shortcut for
> the following line
>  make CppunitTest_sd_import_tests
> CPPUNITTRACE="'C:/PROGRA~1/MICROS~3.0/VC//../Common7/IDE/devenv.exe'
> /debugexe" # for interactive debugging in Visual Studio
>  make CppunitTest_sd_import_tests CPPUNITTRACE="drmemory -free_max_frames 20"
> # for memory checking (install Dr.Memory first, and put it to your PATH)
> 
>  E:/sources/libreoffice-5.2.3.3/solenv/gbuild/CppunitTest.mk:99: recipe for
> target 'E:/Libre_Build/workdir/CppunitTest/sd_import_tests.test' failed
>  make[1]: *** [E:/Libre_Build/workdir/CppunitTest/sd_import_tests.test] Error
> 1
>  make[1]: *** Waiting for unfinished jobs
> Creating library E:/Libre_Build/workdir/LinkTarget/Library/isw.lib and
> object E:/Libre_Build/workdir/LinkTarget/Library/isw.exp
>  Makefile:259: recipe for target 'build' failed
>  make: *** [build] Error 2
> 
> 
> 
>  Regards
>  Vinodkumar Pache
> 
> 

---
[ C-DAC is on Social-Media too. Kindly follow us at:
Facebook: https://www.facebook.com/CDACINDIA & Twitter: @cdacindia ]

This e-mail is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. If you are not the
intended recipient, please contact the sender by reply e-mail and destroy
all copies and the original message. Any unauthorized review, use,
disclosure, dissemination, forwarding, printing or copying of this email
is strictly prohibited and appropriate legal action will be taken.
---

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] help.git: source/text

2016-12-30 Thread Gabor Kelemen

 source/text/scalc/01/04060184.xhp |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit fa16e1bbf6540d59e4c8890939e66be82ad1af0d
Author: Gabor Kelemen 
Date:   Fri Dec 30 22:49:28 2016 +0100

tdf#104975 Document Significance parameter of PERCENTRANK

Change-Id: If4d20ca70642bd08c1b7506d411767931e6a9d3e
Reviewed-on: https://gerrit.libreoffice.org/32520
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/source/text/scalc/01/04060184.xhp 
b/source/text/scalc/01/04060184.xhp
index e5cc06d..09d6b62 100644
--- a/source/text/scalc/01/04060184.xhp
+++ b/source/text/scalc/01/04060184.xhp
@@ -462,9 +462,10 @@ oldref="121">PERCENTRANK
 Returns the percentage rank of 
a value in a sample.
 Syntax
-PERCENTRANK(Data; Value)
+PERCENTRANK(Data; Value; Significance)
 Data represents the array of data in the 
sample.
 Value represents the value whose percentile rank must 
be determined.
+Significance An optional argument that specifies 
the number of significant digits that the returned percentage value is rounded 
to. If omitted, a value of 3 is used.
 Example
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

2016-12-30 Thread Gabor Kelemen

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1c5da0b41a1a36a51b0e5eb92a74ae7449cf7d57
Author: Gabor Kelemen 
Date:   Fri Dec 30 22:49:28 2016 +0100

Updated core
Project: help  fa16e1bbf6540d59e4c8890939e66be82ad1af0d

tdf#104975 Document Significance parameter of PERCENTRANK

Change-Id: If4d20ca70642bd08c1b7506d411767931e6a9d3e
Reviewed-on: https://gerrit.libreoffice.org/32520
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/helpcontent2 b/helpcontent2
index 040bead..fa16e1b 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 040bead66ab62f65b75471ba7752bb0a3c29c7e5
+Subproject commit fa16e1bbf6540d59e4c8890939e66be82ad1af0d
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: external/harfbuzz

2016-12-30 Thread Stephan Bergmann

 external/harfbuzz/ubsan.patch |   10 ++
 1 file changed, 10 insertions(+)

New commits:
commit ca9a08bbf7d42727a93b5f725784308a3590c0fe
Author: Stephan Bergmann 
Date:   Fri Dec 30 21:10:44 2016 +0100

external/harfbuzz: Silence -fsanitize=nonnull-attribute

...as reported during CppunitTest_sw_odfimport

Change-Id: I3c8542d46cf1106c9910a04ed1f953459c7c7ea5

diff --git a/external/harfbuzz/ubsan.patch b/external/harfbuzz/ubsan.patch
index 5f8f008..36b5a45 100644
--- a/external/harfbuzz/ubsan.patch
+++ b/external/harfbuzz/ubsan.patch
@@ -52,3 +52,13 @@
unsigned int da, db;
const char *p;
  
+--- src/hb-private.hh
 src/hb-private.hh
+@@ -466,6 +466,7 @@
+   template 
+   inline const Type *bsearch (T *key) const
+   {
++if (len == 0) return nullptr;
+ return (const Type *) ::bsearch (key, array, len, sizeof (Type), 
(hb_compare_func_t) Type::cmp);
+   }
+ 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/mar-updater' - onlineupdate/Executable_updater.mk onlineupdate/Module_onlineupdate.mk onlineupdate/WinResTarget_updater.mk

2016-12-30 Thread Markus Mohrhard

 onlineupdate/Executable_updater.mk   |2 ++
 onlineupdate/Module_onlineupdate.mk  |1 +
 onlineupdate/WinResTarget_updater.mk |   15 +++
 3 files changed, 18 insertions(+)

New commits:
commit 211f7dd2babb097b44f49766bb837b71a65ee999
Author: Markus Mohrhard 
Date:   Wed Dec 28 02:07:04 2016 +0100

add the resource to the updater

Change-Id: I80e80708346aa2850b2964c566ebc6423837a9cd

diff --git a/onlineupdate/Executable_updater.mk 
b/onlineupdate/Executable_updater.mk
index 75d97a3..8d1b9be 100644
--- a/onlineupdate/Executable_updater.mk
+++ b/onlineupdate/Executable_updater.mk
@@ -68,4 +68,6 @@ $(eval $(call gb_Executable_add_exception_objects,updater,\
onlineupdate/source/update/updater/win_dirent )\
 ))
 
+$(eval $(call gb_Executable_add_nativeres,updater,updaterres))
+
 # vim:set shiftwidth=4 tabstop=4 noexpandtab: */
diff --git a/onlineupdate/Module_onlineupdate.mk 
b/onlineupdate/Module_onlineupdate.mk
index 9672d9c..e84a208 100644
--- a/onlineupdate/Module_onlineupdate.mk
+++ b/onlineupdate/Module_onlineupdate.mk
@@ -16,6 +16,7 @@ $(eval $(call gb_Module_add_targets,onlineupdate,\
StaticLibrary_updatehelper \
$(if $(filter WNT,$(OS)),\
Executable_update_service \
+   WinResTarget_updater \
StaticLibrary_winhelper )\
Executable_mar \
Executable_updater \
diff --git a/onlineupdate/WinResTarget_updater.mk 
b/onlineupdate/WinResTarget_updater.mk
new file mode 100644
index 000..f01b3ff
--- /dev/null
+++ b/onlineupdate/WinResTarget_updater.mk
@@ -0,0 +1,15 @@
+$(eval $(call gb_WinResTarget_WinResTarget,updaterres))
+
+$(eval $(call gb_WinResTarget_set_include,updaterres,\
+   $$(INCLUDE) \
+   -I$(SRCDIR)/onlineupdate/source/update/common \
+   -I$(SRCDIR)/onlineupdate/source/update/updater \
+))
+
+$(eval $(call gb_WinResTarget_add_dependencies,updaterres, \
+   onlineupdate/source/update/updater/updater.ico \
+))
+
+$(eval $(call gb_WinResTarget_set_rcfile,updaterres, \
+   onlineupdate/source/update/updater/updater \
+))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/mar-updater' - 2 commits - bin/update

2016-12-30 Thread Markus Mohrhard

 bin/update/config.py  |   25 +
 bin/update/create_full_mar.py |6 +-
 2 files changed, 30 insertions(+), 1 deletion(-)

New commits:
commit f07f605a8edfa332bdd4d0e750f45500702671d1
Author: Markus Mohrhard 
Date:   Fri Dec 30 20:25:12 2016 +0100

handle signing errors much better

Change-Id: I94be7b3626b9ac3389cba0bee640923adda0f118

diff --git a/bin/update/create_full_mar.py b/bin/update/create_full_mar.py
index e657e12..25e654c 100755
--- a/bin/update/create_full_mar.py
+++ b/bin/update/create_full_mar.py
@@ -47,7 +47,7 @@ def main():
 subprocess.call([os.path.join(current_dir_path, 'make_full_update.sh'), 
mar_file, uncompress_dir])
 
 signed_mar_file = make_mar_name(target_dir, filename_prefix + '_signed')
-subprocess.call([mar_executable, '-C', target_dir, '-d', 
config.certificate_path, '-n', config.certificate_name, '-s', mar_file, 
signed_mar_file])
+subprocess.check_call([mar_executable, '-C', target_dir, '-d', 
config.certificate_path, '-n', config.certificate_name, '-s', mar_file, 
signed_mar_file])
 
 os.rename(signed_mar_file, mar_file)
 
commit a168ff5043274c18f96a67e7aceafed7fa9c76ab
Author: Markus Mohrhard 
Date:   Fri Dec 30 20:24:49 2016 +0100

error out if the path to the updater config is empty

Change-Id: Ic199b15222836e096e32203d3458487fead6e3e1

diff --git a/bin/update/config.py b/bin/update/config.py
new file mode 100644
index 000..2af895b
--- /dev/null
+++ b/bin/update/config.py
@@ -0,0 +1,25 @@
+
+import configparser
+
+class Config(object):
+
+def __init__(self):
+self.certificate_path = None
+self.certificate_name = None
+self.channel = None
+self.base_url = None
+self.upload_url = None
+
+def parse_config(config_file):
+config = configparser.ConfigParser()
+config.read(config_file)
+
+data = Config()
+updater_data = config['Updater']
+data.base_url = updater_data['base-url']
+data.certificate_name = updater_data['certificate-name']
+data.certificate_path = updater_data['certificate-path']
+data.channel = updater_data['channel']
+data.upload_url = updater_data['upload-url']
+
+return data
diff --git a/bin/update/create_full_mar.py b/bin/update/create_full_mar.py
index 2362f2c..e657e12 100755
--- a/bin/update/create_full_mar.py
+++ b/bin/update/create_full_mar.py
@@ -27,6 +27,10 @@ def main():
 workdir = sys.argv[2]
 product_name = sys.argv[1]
 
+if len(update_config) == 0:
+print("missing update config")
+sys.exit(1)
+
 config = parse_config(update_config)
 
 tar_dir = os.path.join(workdir, "installation", product_name, "archive", 
"install", "en-US")
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/mar-updater' - 5 commits - onlineupdate/source

2016-12-30 Thread Markus Mohrhard

 onlineupdate/source/service/workmonitor.cxx|8 +--
 onlineupdate/source/update/updater/updater.cxx |   56 -
 2 files changed, 33 insertions(+), 31 deletions(-)

New commits:
commit 6560991fc089a836c61934856c3f2127757473e9
Author: Markus Mohrhard 
Date:   Fri Dec 30 20:12:50 2016 +0100

add TODO comments for the places that need further inspection

This is just from a quick scroll through the code.

Change-Id: I72132ba9244d7aa559befe63412f7a5ef2005ad1

diff --git a/onlineupdate/source/update/updater/updater.cxx 
b/onlineupdate/source/update/updater/updater.cxx
index b3a36f9..7b337e2 100644
--- a/onlineupdate/source/update/updater/updater.cxx
+++ b/onlineupdate/source/update/updater/updater.cxx
@@ -1843,6 +1843,9 @@ LaunchWinPostProcess(const WCHAR *installationDir,
 WCHAR workingDirectory[MAX_PATH + 1] = { L'\0' };
 wcsncpy(workingDirectory, installationDir, MAX_PATH);
 
+// TODO: moggi: needs adaption for LibreOffice
+// Most likely we don't have the helper method yet. Check if we really 
need it.
+
 // Launch helper.exe to perform post processing (e.g. registry and log file
 // modifications) for the update.
 WCHAR inifile[MAX_PATH + 1] = { L'\0' };
@@ -2312,6 +2315,8 @@ WaitForServiceFinishThread(void* /*param*/)
 static int
 ReadMARChannelIDs(const NS_tchar *path, MARChannelStringTable *results)
 {
+// TODO: moggi: needs adaption for LibreOffice
+// Check where this function gets its parameters from
 const unsigned int kNumStrings = 1;
 const char *kUpdaterKeys = "ACCEPTED_MAR_CHANNEL_IDS\0";
 char updater_strings[kNumStrings][MAX_TEXT_LEN];
@@ -2329,6 +2334,8 @@ ReadMARChannelIDs(const NS_tchar *path, 
MARChannelStringTable *results)
 static int
 GetUpdateFileName(NS_tchar *fileName, int maxChars)
 {
+// TODO: moggi: needs adaption for LibreOffice
+// We would like to store the name inside of an ini file
 NS_tsnprintf(fileName, maxChars,
 NS_T("%s/update.mar"), gPatchDirPath);
 return OK;
@@ -2391,6 +2398,9 @@ UpdateThreadFunc(void * /*param*/)
 if (rv == OK) {
 if (rv == OK) {
 NS_tchar updateSettingsPath[MAX_TEXT_LEN];
+
+// TODO: moggi: needs adaption for LibreOffice
+// These paths need to be adapted for us.
 NS_tsnprintf(updateSettingsPath,
 sizeof(updateSettingsPath) / 
sizeof(updateSettingsPath[0]),
 #ifdef MACOSX
@@ -2563,6 +2573,7 @@ int NS_main(int argc, NS_tchar **argv)
 const int callbackIndex = 6;
 
 #ifdef MACOSX
+// TODO: moggi: needs adaption for LibreOffice
 bool isElevated =
 strstr(argv[0], "/Library/PrivilegedHelperTools/org.mozilla.updater") 
!= 0;
 if (isElevated) {
@@ -2651,6 +2662,7 @@ int NS_main(int argc, NS_tchar **argv)
 
 // Remove everything except close window from the context menu
 {
+// TODO: moggi: needs adaption for LibreOffice
 HKEY hkApp = nullptr;
 RegCreateKeyExW(HKEY_CURRENT_USER, L"Software\\Classes\\Applications",
 0, nullptr, REG_OPTION_NON_VOLATILE, KEY_SET_VALUE, nullptr,
@@ -2937,6 +2949,8 @@ int NS_main(int argc, NS_tchar **argv)
 // are available.  If not don't use the service.
 if (useService) {
 WCHAR maintenanceServiceKey[MAX_PATH + 1];
+// TODO: moggi: needs adaption for LibreOffice
+// Most likely the registry part is not correct yet
 if (CalculateRegistryPathFromFilePath(gInstallDirPath,
 maintenanceServiceKey)) {
 HKEY baseKey = nullptr;
@@ -3957,6 +3971,8 @@ int DoUpdate()
 ensure_parent_dir(manifest);
 
 // extract the manifest
+// TODO: moggi: needs adaption for LibreOffice
+// Why would we need the manifest? Even if we need it why would we need 2?
 int rv = gArchiveReader.ExtractFile("updatev3.manifest", manifest);
 if (rv) {
 rv = gArchiveReader.ExtractFile("updatev2.manifest", manifest);
commit 635745f555287cfc6f7b767158e85f4375030359
Author: Markus Mohrhard 
Date:   Fri Dec 30 19:00:54 2016 +0100

hide the function behind the correct define checks

Change-Id: Ifef59d40975b6061a40b58d80817b6c15b856713

diff --git a/onlineupdate/source/update/updater/updater.cxx 
b/onlineupdate/source/update/updater/updater.cxx
index 7c060f1..b3a36f9 100644
--- a/onlineupdate/source/update/updater/updater.cxx
+++ b/onlineupdate/source/update/updater/updater.cxx
@@ -277,12 +277,14 @@ mstrtok(const NS_tchar *delims, NS_tchar **str)
 return ret;
 }
 
+#if defined(_WIN32) && defined(MAINTENANCE_SERVICE)
 static bool
 EnvHasValue(const char *name)
 {
 const char *val = getenv(name);
 return (val && *val);
 }
+#endif
 
 /**
  * Coverts a relative update path to a full path.
commit 11640418c1526ba2dc073a99f50bee7a698def0f
Author: Markus Mohrhard 
Date:   Fri Dec 30 18:57:18 20

[Libreoffice-commits] help.git: source/text

2016-12-30 Thread Gabor Kelemen

 source/text/shared/01/05040300.xhp |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 040bead66ab62f65b75471ba7752bb0a3c29c7e5
Author: Gabor Kelemen 
Date:   Thu Dec 29 19:44:17 2016 +0100

Don't link UI from the Footer tabpage to the Header help page

We have a separate help page for that.

Change-Id: I34d6136c8f1dc7263b2a9937d08d8aca7629133a
Reviewed-on: https://gerrit.libreoffice.org/32500
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/source/text/shared/01/05040300.xhp 
b/source/text/shared/01/05040300.xhp
index cd123af..4181acd 100644
--- a/source/text/shared/01/05040300.xhp
+++ b/source/text/shared/01/05040300.xhp
@@ -52,9 +52,8 @@
 Header
   Set the properties of the header.
 
-
 Header on
-  Adds a header 
to the current page style.
+  Adds a header 
to the current page style.
 
 Same content 
left/righti80087
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

2016-12-30 Thread Gabor Kelemen

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c48362288d2ca96967b4c40f0e6191ee9918b636
Author: Gabor Kelemen 
Date:   Thu Dec 29 19:44:17 2016 +0100

Updated core
Project: help  040bead66ab62f65b75471ba7752bb0a3c29c7e5

Don't link UI from the Footer tabpage to the Header help page

We have a separate help page for that.

Change-Id: I34d6136c8f1dc7263b2a9937d08d8aca7629133a
Reviewed-on: https://gerrit.libreoffice.org/32500
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 716c3d6..040bead 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 716c3d6f852f76806b09c7b53d5358d9b3a2849e
+Subproject commit 040bead66ab62f65b75471ba7752bb0a3c29c7e5
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: accessibility/source chart2/source cli_ure/source connectivity/source dbaccess/source dtrans/source editeng/source fpicker/source i18npool/inc include/onlineupdate incl

2016-12-30 Thread Jochen Nitschke

 accessibility/source/extended/accessiblelistboxentry.cxx|2 
 chart2/source/controller/chartapiwrapper/GridWrapper.cxx|2 
 chart2/source/controller/itemsetwrapper/SchWhichPairs.hxx   |4 -
 cli_ure/source/climaker/climaker_emit.cxx   |2 
 connectivity/source/drivers/ado/AResultSet.cxx  |2 
 connectivity/source/drivers/evoab2/NResultSet.cxx   |2 
 connectivity/source/drivers/mork/MResultSet.cxx |2 
 dbaccess/source/ui/browser/sbamultiplex.cxx |2 
 dtrans/source/generic/generic_clipboard.cxx |2 
 dtrans/source/win32/clipb/MtaOleClipb.cxx   |8 +--
 editeng/source/uno/unotext.cxx  |4 -
 fpicker/source/win32/folderpicker/MtaFop.hxx|4 -
 i18npool/inc/indexentrysupplier_ja_phonetic.hxx |   22 

 include/onlineupdate/mar_private.h  |2 
 include/svx/msdffdef.hxx|2 
 odk/examples/DevelopersGuide/Database/DriverSkeleton/SResultSet.cxx |2 
 onlineupdate/source/update/updater/progressui_win.cxx   |4 -
 sal/osl/unx/file_misc.cxx   |2 
 sal/osl/unx/file_path_helper.cxx|2 
 sal/osl/w32/path_helper.cxx |2 
 sal/osl/w32/procimpl.cxx|4 -
 sc/inc/address.hxx  |2 
 sc/source/core/opencl/op_math.cxx   |4 -
 sc/source/filter/orcus/interface.cxx|8 +--
 sd/source/core/stlsheet.cxx |8 +--
 sd/source/ui/slidesorter/view/SlsFramePainter.cxx   |2 
 sfx2/source/appl/newhelp.cxx|8 +--
 sfx2/source/doc/sfxbasemodel.cxx|2 
 sfx2/source/view/frmload.cxx|2 
 svx/source/table/cell.cxx   |   26 
+-
 svx/source/unodraw/unoshape.cxx |4 -
 sw/source/core/access/accselectionhelper.cxx|2 
 sw/source/core/text/txttab.cxx  |4 -
 sw/source/uibase/ribbar/inputwin.cxx|2 
 ucb/source/core/provprox.cxx|2 
 35 files changed, 77 insertions(+), 77 deletions(-)

New commits:
commit a29bd2dabb194c57be28d48ccc08c909831e7e67
Author: Jochen Nitschke 
Date:   Wed Dec 28 12:43:31 2016 +0100

cleanup tailing backslashes

Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2
Reviewed-on: https://gerrit.libreoffice.org/32491
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/accessibility/source/extended/accessiblelistboxentry.cxx 
b/accessibility/source/extended/accessiblelistboxentry.cxx
index ab9b216..e2706d9 100644
--- a/accessibility/source/extended/accessiblelistboxentry.cxx
+++ b/accessibility/source/extended/accessiblelistboxentry.cxx
@@ -823,7 +823,7 @@ namespace accessibility
 }else if( (nIndex == 1 && (treeFlag & SvTreeFlags::CHKBTN)) || nIndex 
== 0 )
 {
 if( pEntry->HasChildren() || pEntry->HasChildrenOnDemand() )
-return getListBox()->IsExpanded( pEntry ) ? \
+return getListBox()->IsExpanded( pEntry ) ?
 OUString(TK_RES_STRING(STR_SVT_ACC_ACTION_COLLAPSE)) :
 OUString(TK_RES_STRING(STR_SVT_ACC_ACTION_EXPAND));
 return OUString();
diff --git a/chart2/source/controller/chartapiwrapper/GridWrapper.cxx 
b/chart2/source/controller/chartapiwrapper/GridWrapper.cxx
index 6ad675d..a1ee70d 100644
--- a/chart2/source/controller/chartapiwrapper/GridWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/GridWrapper.cxx
@@ -188,7 +188,7 @@ css::uno::Sequence< OUString > SAL_CALL 
GridWrapper::getSupportedServiceNames()
 "com.sun.star.chart.ChartGrid",
 "com.sun.star.xml.UserDefinedAttributesSupplier",
 "com.sun.star.drawing.LineProperties",
-"com.sun.star.beans.PropertySet"\
+"com.sun.star.beans.PropertySet"
 };
 }
 
diff --git a/chart2/source/controller/itemsetwrapper/SchWhichPairs.hxx 
b/chart2/source/controller/itemsetwrapper/SchWhichPairs.hxx
index 0879fbf..eb7cdde 100644
--- a/chart2/source/controller/itemsetwrapper/SchWhichPairs.hxx
+++ b/chart2/source/controller/itemsetwrapper/SchWhichPairs.hxx
@@ -79,8 +79,8 @@ const sal_uInt16 nLegendWhichPairs[] =
 const sal_uInt16 nDataLabelWhichPairs[] =
 {
 SCHATTR_DATADESCR_START, SCHATTR_DATADESCR_END,
-

[Libreoffice-commits] core.git: sc/qa

2016-12-30 Thread Zdeněk Crhonek

 sc/qa/unit/data/functions/statistical/fods/percentile.exc.fods | 4620 +
 sc/qa/unit/data/functions/statistical/fods/percentile.fods | 4604 +
 sc/qa/unit/data/functions/statistical/fods/percentile.inc.fods | 4622 
++
 3 files changed, 13846 insertions(+)

New commits:
commit 97d24068021265e5f159211c90839622f7c87cb2
Author: ZdenÄk Crhonek 
Date:   Fri Dec 30 16:53:46 2016 +0100

add PERCENTILE test case

Change-Id: I70cfe56c948035b0e853bbabd273ad9464ec6204
Reviewed-on: https://gerrit.libreoffice.org/32516
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/qa/unit/data/functions/statistical/fods/percentile.exc.fods 
b/sc/qa/unit/data/functions/statistical/fods/percentile.exc.fods
new file mode 100644
index 000..4e5d9e0
--- /dev/null
+++ b/sc/qa/unit/data/functions/statistical/fods/percentile.exc.fods
@@ -0,0 +1,4620 @@
+
+
+http://www.w3.org/1999/xlink"; 
xmlns:dc="http://purl.org/dc/elements/1.1/"; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML"; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office"; 
xmlns:ooow="http://openoffice.org/2004/writer"; 
xmlns:oooc="http://openoffice.org/2004/calc"; 
xmlns:dom="http://www.w3.org/2001/xml-events"; 
xmlns:xforms="http://www.w3.org/2002/xforms"; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xmlns:rpt="http://openoffice.org/2005/report"; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml"; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#"; 
xmlns:tableooo="http://openoffice.org/2009/table"; 
xmlns:drawooo="http://openoffice.org/2010/draw"; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/"; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+ 
2016-12-30T16:51:25.719929539P0D1LibreOfficeDev/5.3.0.0.alpha1$Linux_X86_64
 
LibreOffice_project/883024d657fb45c7da459017d2f936aac5644bfb
+ 
+  
+   0
+   0
+   43850
+   34184
+   
+
+ view1
+ 
+  
+   2
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   100
+   60
+   true
+   false
+  
+  
+   2
+   18
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   100
+   60
+   true
+   false
+  
+ 
+ Sheet2
+ 1241
+ 0
+ 100
+ 60
+ false
+ true
+ true
+ true
+ 12632256
+ true
+ true
+ true
+ true
+ true
+ false
+ false
+ 1270
+ 1270
+ 1
+ 1
+ true
+ false
+
+   
+  
+  
+   7
+   false
+   false
+   true
+   true
+   false
+   false
+   false
+   1270
+   1270
+   true
+   true
+   true
+   true
+   true
+   false
+   12632256
+   false
+   Lexmark-E352dn
+   
+
+ cs
+ CZ
+ 
+ 
+ 
+
+
+ de
+ DE
+ 
+ 
+ 
+
+
+ en
+ US
+ 
+ 
+ 
+
+
+ nl
+ NL
+ 
+ 
+ 
+
+   
+   true
+   true
+   3
+   1
+   true
+   1
+   true
+   lgH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMAtwAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhClBhZ2VTaXplOkxldHRlcgAAEgBDT01QQVRfRFVQTEVYX01PREUPAER1cGxleE1vZGU6Ok9mZg==
+   false
+   0
+  
+ 
+ 
+  
+   http://openoffice.org/2004/office"; 
xmlns:xlink="http://www.w3.org/1999/xlink";>
+
+   
+  
+ 
+ 
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+ 
+ 
+  
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+
+   KÄ
+  
+  
+   
+   -
+   
+
+   KÄ
+   
+  
+  
+
+   
+
+  
+  
+
+   (
+   
+   )
+  
+  
+
+   -

[Libreoffice-commits] core.git: sc/qa

2016-12-30 Thread Zdeněk Crhonek

 sc/qa/unit/data/functions/statistical/fods/pearson.fods | 5273 
 1 file changed, 5273 insertions(+)

New commits:
commit c286a125cb86a9ecdf9b21e0e9d7cf864b0605fe
Author: ZdenÄk Crhonek 
Date:   Fri Dec 30 16:36:27 2016 +0100

add PEARSON test case

Change-Id: Ice0d45a8c44d1773997da091df272f35c1e37388
Reviewed-on: https://gerrit.libreoffice.org/32515
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/qa/unit/data/functions/statistical/fods/pearson.fods 
b/sc/qa/unit/data/functions/statistical/fods/pearson.fods
new file mode 100644
index 000..f36446c
--- /dev/null
+++ b/sc/qa/unit/data/functions/statistical/fods/pearson.fods
@@ -0,0 +1,5273 @@
+
+
+http://www.w3.org/1999/xlink"; 
xmlns:dc="http://purl.org/dc/elements/1.1/"; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML"; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office"; 
xmlns:ooow="http://openoffice.org/2004/writer"; 
xmlns:oooc="http://openoffice.org/2004/calc"; 
xmlns:dom="http://www.w3.org/2001/xml-events"; 
xmlns:xforms="http://www.w3.org/2002/xforms"; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xmlns:rpt="http://openoffice.org/2005/report"; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml"; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#"; 
xmlns:tableooo="http://openoffice.org/2009/table"; 
xmlns:drawooo="http://openoffice.org/2010/draw"; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/"; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+ 
2016-12-30T16:35:40.174400414P0D1LibreOfficeDev/5.3.0.0.alpha1$Linux_X86_64
 
LibreOffice_project/883024d657fb45c7da459017d2f936aac5644bfb
+ 
+  
+   0
+   0
+   57546
+   61425
+   
+
+ view1
+ 
+  
+   2
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   100
+   60
+   true
+   false
+  
+  
+   4
+   5
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   100
+   60
+   true
+   false
+  
+ 
+ Sheet2
+ 1241
+ 0
+ 100
+ 60
+ false
+ true
+ true
+ true
+ 12632256
+ true
+ true
+ true
+ true
+ true
+ false
+ false
+ 1270
+ 1270
+ 1
+ 1
+ true
+ false
+
+   
+  
+  
+   7
+   false
+   false
+   true
+   true
+   false
+   false
+   false
+   1270
+   1270
+   true
+   true
+   true
+   true
+   true
+   false
+   12632256
+   false
+   Lexmark-E352dn
+   
+
+ cs
+ CZ
+ 
+ 
+ 
+
+
+ de
+ DE
+ 
+ 
+ 
+
+
+ en
+ US
+ 
+ 
+ 
+
+
+ nl
+ NL
+ 
+ 
+ 
+
+   
+   true
+   true
+   3
+   1
+   true
+   1
+   true
+   lgH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMAtwAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhClBhZ2VTaXplOkxldHRlcgAAEgBDT01QQVRfRFVQTEVYX01PREUPAER1cGxleE1vZGU6Ok9mZg==
+   false
+   0
+  
+ 
+ 
+  
+   http://openoffice.org/2004/office"; 
xmlns:xlink="http://www.w3.org/1999/xlink";>
+
+   
+  
+ 
+ 
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+ 
+ 
+  
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+
+   KÄ
+  
+  
+   
+   -
+   
+
+   KÄ
+   
+  
+  
+
+   
+
+  
+  
+
+   (
+   
+   )
+  
+  
+
+   -
+   
+
+  
+  
+   
+
+   
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+
+   KÄ
+  
+  
+   -
+   
+
+   KÄ
+   
+  
+  
+   
+
+   KÄ
+  
+  
+   -
+   
+
+

[Libreoffice-commits] core.git: 2 commits - include/tools rsc/inc rsc/source

2016-12-30 Thread Caolán McNamara

 include/tools/rcid.h  |2 
 rsc/inc/rscdb.hxx |2 
 rsc/source/parser/rscibas.cxx |  116 --
 rsc/source/parser/rscicpx.cxx |   90 
 rsc/source/parser/rscinit.cxx |7 --
 5 files changed, 217 deletions(-)

New commits:
commit 394f65f2127e41ad0fb43c7164aa5e4518c335a9
Author: CaolÃ¡n McNamara 
Date:   Fri Dec 30 16:43:13 2016 +

RSC_ACCEL isn't in use anymore

Change-Id: I581d55adfbae078c154eaf41cf98c2be0f5dfd5d

diff --git a/include/tools/rcid.h b/include/tools/rcid.h
index ccbbd22..d30dde8 100644
--- a/include/tools/rcid.h
+++ b/include/tools/rcid.h
@@ -36,7 +36,6 @@
 #define RSC_RESOURCE(RSC_NOTYPE + 0x10)
 #define RSC_STRING  (RSC_NOTYPE + 0x11)
 #define RSC_BITMAP  (RSC_NOTYPE + 0x13)
-#define RSC_ACCEL   (RSC_NOTYPE + 0x1a)
 #define RSC_MENU(RSC_NOTYPE + 0x1c)
 #define RSC_MENUITEM(RSC_NOTYPE + 0x1d) // only used internally
 #define RSC_IMAGE   (RSC_NOTYPE + 0x23)
commit 1fec83409ced6f6421e2dccc0fcae59a04f5ffa7
Author: CaolÃ¡n McNamara 
Date:   Fri Dec 30 16:40:29 2016 +

no use of RSC_KEYCODE appears to remain

Change-Id: I968093ef9a9a5647f410432918a60dbc2331192a

diff --git a/include/tools/rcid.h b/include/tools/rcid.h
index 708a0e1..ccbbd22 100644
--- a/include/tools/rcid.h
+++ b/include/tools/rcid.h
@@ -39,7 +39,6 @@
 #define RSC_ACCEL   (RSC_NOTYPE + 0x1a)
 #define RSC_MENU(RSC_NOTYPE + 0x1c)
 #define RSC_MENUITEM(RSC_NOTYPE + 0x1d) // only used internally
-#define RSC_KEYCODE (RSC_NOTYPE + 0x1f)
 #define RSC_IMAGE   (RSC_NOTYPE + 0x23)
 
 #define RSC_STRINGARRAY (RSC_NOTYPE + 0x79)
diff --git a/rsc/inc/rscdb.hxx b/rsc/inc/rscdb.hxx
index 133b7a8..1d74003 100644
--- a/rsc/inc/rscdb.hxx
+++ b/rsc/inc/rscdb.hxx
@@ -84,7 +84,6 @@ class RscTypCont
 inline void SETCONST( RscConst *p1, const char * p2, KeyFuncType p3 ) { 
SETCONST(p1, p2, static_cast(p3)); }
 inline void SETCONST( RscConst *p1, Atom p2, MenuItemBits p3 ) { 
SETCONST(p1, p2, static_cast(p3)); }
 RscEnum *   InitFieldUnitsType();
-RscEnum *   InitKey();
 RscTupel *  InitStringLongTupel();
 static RscCont  *  InitStringLongTupelList( RscTupel * pStringLongTupel );
 RscArray *  InitLangStringLongTupelList( RscCont * pStrLongTupelLst );
@@ -93,7 +92,6 @@ class RscTypCont
 RscTop *InitClassString( RscTop * pSuper );
 RscTop *InitClassBitmap( RscTop * pSuper );
 RscTop *InitClassImage( RscTop * pSuper, RscTop *pClassBitmap );
-RscTop *InitClassKeyCode( RscTop * pSuper, RscEnum * pKey );
 RscTop *InitClassMenuItem( RscTop * pSuper );
 RscTop *InitClassMenu( RscTop * pSuper, RscTop * pMenuItem );
 
diff --git a/rsc/source/parser/rscibas.cxx b/rsc/source/parser/rscibas.cxx
index c21b852..7b58d68 100644
--- a/rsc/source/parser/rscibas.cxx
+++ b/rsc/source/parser/rscibas.cxx
@@ -193,122 +193,6 @@ RscEnum * RscTypCont::InitFieldUnitsType()
 return pFieldUnits;
 }
 
-RscEnum * RscTypCont::InitKey()
-{
-RscEnum * pKey;
-pKey = new RscEnum( pHS->getID( "EnumKey" ), RSC_NOTYPE );
-
-SETCONST( pKey, "KEY_0",com::sun::star::awt::Key::NUM0 
);
-SETCONST( pKey, "KEY_1",com::sun::star::awt::Key::NUM1 
);
-SETCONST( pKey, "KEY_2",com::sun::star::awt::Key::NUM2 
);
-SETCONST( pKey, "KEY_3",com::sun::star::awt::Key::NUM3 
);
-SETCONST( pKey, "KEY_4",com::sun::star::awt::Key::NUM4 
);
-SETCONST( pKey, "KEY_5",com::sun::star::awt::Key::NUM5 
);
-SETCONST( pKey, "KEY_6",com::sun::star::awt::Key::NUM6 
);
-SETCONST( pKey, "KEY_7",com::sun::star::awt::Key::NUM7 
);
-SETCONST( pKey, "KEY_8",com::sun::star::awt::Key::NUM8 
);
-SETCONST( pKey, "KEY_9",com::sun::star::awt::Key::NUM9 
);
-
-SETCONST( pKey, "KEY_A",com::sun::star::awt::Key::A );
-SETCONST( pKey, "KEY_B",com::sun::star::awt::Key::B );
-SETCONST( pKey, "KEY_C",com::sun::star::awt::Key::C );
-SETCONST( pKey, "KEY_D",com::sun::star::awt::Key::D );
-SETCONST( pKey, "KEY_E",com::sun::star::awt::Key::E );
-SETCONST( pKey, "KEY_F",com::sun::star::awt::Key::F );
-SETCONST( pKey, "KEY_G",com::sun::star::awt::Key::G );
-SETCONST( pKey, "KEY_H",com::sun::star::awt::Key::H );
-SETCONST( pKey, "KEY_I",com::sun::star::awt::Key::I );
-SETCONST( pKey, "KEY_J",com::sun::star::awt::Key::J );
-SETCONST( pKey, "KEY_K",com::sun::star::awt::Key::K );
-SETC

[Libreoffice-commits] core.git: 4 commits - framework/source include/tools include/vcl rsc/inc rsc/source svtools/source vcl/source

2016-12-30 Thread Caolán McNamara

 framework/source/uielement/controlmenucontroller.cxx |   73 ---
 include/tools/rc.h   |9 --
 include/tools/rcid.h |1 
 include/vcl/image.hxx|1 
 rsc/inc/rscdb.hxx|2 
 rsc/source/parser/rscdb.cxx  |2 
 rsc/source/parser/rscicpx.cxx|   30 ---
 rsc/source/parser/rscinit.cxx|6 -
 svtools/source/graphic/provider.cxx  |   20 -
 vcl/source/image/ImageList.cxx   |   37 -
 10 files changed, 32 insertions(+), 149 deletions(-)

New commits:
commit 73545e2efae49af7bdf1e7fd43ae0d68f3bb3225
Author: CaolÃ¡n McNamara 
Date:   Fri Dec 30 14:37:42 2016 +

RscImageListFlags is newly unused

Change-Id: Ic6ed613496ce1903f752ae3b6258121870f99558

diff --git a/include/tools/rc.h b/include/tools/rc.h
index c1da806..9ca1e8f 100644
--- a/include/tools/rc.h
+++ b/include/tools/rc.h
@@ -58,15 +58,6 @@ namespace o3tl {
 template<> struct typed_flags : 
is_typed_flags {};
 }
 
-// For "ImageList":
-enum class RscImageListFlags {
-IdList= 0x08,
-IdCount   = 0x10
-};
-namespace o3tl {
-template<> struct typed_flags : 
is_typed_flags {};
-}
-
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
commit 70fb9e0f48d38d7fb01cb54dab7d5ed775f65d9c
Author: CaolÃ¡n McNamara 
Date:   Fri Dec 30 14:36:46 2016 +

aIdUShort is now unused

Change-Id: I44c2748be879f083bc6ebb6c17e3a3a7038f8ad8

diff --git a/rsc/inc/rscdb.hxx b/rsc/inc/rscdb.hxx
index d9654b0..133b7a8 100644
--- a/rsc/inc/rscdb.hxx
+++ b/rsc/inc/rscdb.hxx
@@ -102,7 +102,6 @@ public:
 RscRangeaShort;
 RscRangeaUShort;
 RscLongEnumRangeaEnumLong;
-RscIdRange  aIdUShort;
 RscIdRange  aIdNoZeroUShort;
 RscString   aString;
 RscString   aStringLiteral;
diff --git a/rsc/source/parser/rscdb.cxx b/rsc/source/parser/rscdb.cxx
index f9a7afa..bb0fecf 100644
--- a/rsc/source/parser/rscdb.cxx
+++ b/rsc/source/parser/rscdb.cxx
@@ -49,7 +49,6 @@ RscTypCont::RscTypCont( RscError * pErrHdl,
 , aShort( pHS->getID( "short" ), RSC_NOTYPE )
 , aUShort( pHS->getID( "sal_uInt16" ), RSC_NOTYPE )
 , aEnumLong( pHS->getID( "enum_long" ), RSC_NOTYPE )
-, aIdUShort( pHS->getID( "IDUSHORT" ), RSC_NOTYPE )
 , aIdNoZeroUShort( pHS->getID( "IDUSHORT" ), RSC_NOTYPE )
 , aString( pHS->getID( "Chars" ), RSC_NOTYPE )
 , aStringLiteral( pHS->getID( "Chars" ), RSC_NOTYPE )
@@ -176,7 +175,6 @@ RscTypCont::~RscTypCont()
 aBool.Pre_dtor();
 aShort.Pre_dtor();
 aUShort.Pre_dtor();
-aIdUShort.Pre_dtor();
 aIdNoZeroUShort.Pre_dtor();
 aString.Pre_dtor();
 aVersion.pClass->Pre_dtor();
diff --git a/rsc/source/parser/rscinit.cxx b/rsc/source/parser/rscinit.cxx
index 60ade77..85023b8 100644
--- a/rsc/source/parser/rscinit.cxx
+++ b/rsc/source/parser/rscinit.cxx
@@ -76,8 +76,6 @@ void RscTypCont::Init()
 
 aEnumLong.SetRange( SAL_MIN_INT32, SAL_MAX_INT32 );
 
-aIdUShort.SetRange( 0, 0x );
-
 aIdNoZeroUShort.SetRange( 1, 0x );
 }
 {
commit 21f934a7c54e6a62aac046b99e05bbcf394c4de4
Author: CaolÃ¡n McNamara 
Date:   Fri Dec 30 14:35:24 2016 +

ImageLists no longer loaded from resource files

Change-Id: I5bf1c75dce7bc9af6aaa92447fab7239dff4b676

diff --git a/include/tools/rcid.h b/include/tools/rcid.h
index 924b3d2..708a0e1 100644
--- a/include/tools/rcid.h
+++ b/include/tools/rcid.h
@@ -41,7 +41,6 @@
 #define RSC_MENUITEM(RSC_NOTYPE + 0x1d) // only used internally
 #define RSC_KEYCODE (RSC_NOTYPE + 0x1f)
 #define RSC_IMAGE   (RSC_NOTYPE + 0x23)
-#define RSC_IMAGELIST   (RSC_NOTYPE + 0x24)
 
 #define RSC_STRINGARRAY (RSC_NOTYPE + 0x79)
 
diff --git a/include/vcl/image.hxx b/include/vcl/image.hxx
index a571fab..f6ed44a 100644
--- a/include/vcl/image.hxx
+++ b/include/vcl/image.hxx
@@ -75,7 +75,6 @@ class VCL_DLLPUBLIC ImageList
 {
 public:
 explicit ImageList();
-explicit ImageList( const ResId& rResId );
 ImageList( const std::vector& rNameVector,
const OUString& rPrefix);
 
diff --git a/rsc/inc/rscdb.hxx b/rsc/inc/rscdb.hxx
index 695c9c3..d9654b0 100644
--- a/rsc/inc/rscdb.hxx
+++ b/rsc/inc/rscdb.hxx
@@ -93,7 +93,6 @@ class RscTypCont
 RscTop *InitClassString( RscTop * pSuper );
 RscTop *InitClassBitmap( RscTop * pSuper );
 RscTop *InitClassImage( RscTop * pSuper, RscTop *pClassBitmap );
-RscTop *InitClassImageList( RscTop * pSuper, RscCont * pStrLst );
 RscTop *InitClassKeyCode( RscTop * pSuper, RscEnum * pKey );
 RscTop *InitClassMenuItem( RscTop * pSuper );
 RscTop *InitClassMenu( RscTop * pSuper

[Libreoffice-commits] core.git: framework/source

2016-12-30 Thread Caolán McNamara

 framework/source/uielement/controlmenucontroller.cxx |   46 ---
 1 file changed, 2 insertions(+), 44 deletions(-)

New commits:
commit faff6829952a49187c917db2a3c478969b997ccf
Author: CaolÃ¡n McNamara 
Date:   Fri Dec 30 14:04:49 2016 +

include header instead of duplicating defines

Change-Id: Iee47a90071cb988d5b9fc434569bf91035d52007
Reviewed-on: https://gerrit.libreoffice.org/32510
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/framework/source/uielement/controlmenucontroller.cxx 
b/framework/source/uielement/controlmenucontroller.cxx
index e4947ed..8035f20 100644
--- a/framework/source/uielement/controlmenucontroller.cxx
+++ b/framework/source/uielement/controlmenucontroller.cxx
@@ -44,55 +44,13 @@
 #include 
 #include 
 
+#include "svx/svxids.hrc"
+
 // Copied from svx
 // Function-Id's
 #define RID_FMSHELL_CONVERSIONMENU (RID_FORMS_START + 4)
 #define RID_SVXIMGLIST_FMEXPL  (RID_FORMS_START + 0)
 
-// Forms - Ids, used to address images from image list
-#define SID_FMSLOTS_START   (SID_SVX_START + 592)
-#define SID_MORE_FMSLOTS_START  (SID_SVX_START + 702)
-
-#define SID_FM_CONVERTTO_EDIT   (SID_MORE_FMSLOTS_START +  32)
-#define SID_FM_CONVERTTO_BUTTON (SID_MORE_FMSLOTS_START +  33)
-#define SID_FM_CONVERTTO_FIXEDTEXT  (SID_MORE_FMSLOTS_START +  34)
-#define SID_FM_CONVERTTO_LISTBOX(SID_MORE_FMSLOTS_START +  35)
-#define SID_FM_CONVERTTO_CHECKBOX   (SID_MORE_FMSLOTS_START +  36)
-#define SID_FM_CONVERTTO_RADIOBUTTON(SID_MORE_FMSLOTS_START +  37)
-#define SID_FM_CONVERTTO_GROUPBOX   (SID_MORE_FMSLOTS_START +  38)
-#define SID_FM_CONVERTTO_COMBOBOX   (SID_MORE_FMSLOTS_START +  39)
-#define SID_FM_CONVERTTO_IMAGEBUTTON(SID_MORE_FMSLOTS_START +  41)
-#define SID_FM_CONVERTTO_FILECONTROL(SID_MORE_FMSLOTS_START +  42)
-#define SID_FM_CONVERTTO_DATE   (SID_MORE_FMSLOTS_START +  43)
-#define SID_FM_CONVERTTO_TIME   (SID_MORE_FMSLOTS_START +  44)
-#define SID_FM_CONVERTTO_NUMERIC(SID_MORE_FMSLOTS_START +  45)
-#define SID_FM_CONVERTTO_CURRENCY   (SID_MORE_FMSLOTS_START +  46)
-#define SID_FM_CONVERTTO_PATTERN(SID_MORE_FMSLOTS_START +  47)
-#define SID_FM_CONVERTTO_IMAGECONTROL   (SID_MORE_FMSLOTS_START +  48)
-#define SID_FM_CONVERTTO_FORMATTED  (SID_MORE_FMSLOTS_START +  49)
-#define SID_FM_CONVERTTO_SCROLLBAR  (SID_MORE_FMSLOTS_START +  68)
-#define SID_FM_CONVERTTO_SPINBUTTON (SID_MORE_FMSLOTS_START +  69)
-
-#define SID_FM_DATEFIELD(SID_MORE_FMSLOTS_START +   2)
-#define SID_FM_TIMEFIELD(SID_MORE_FMSLOTS_START +   3)
-#define SID_FM_NUMERICFIELD (SID_MORE_FMSLOTS_START +   4)
-#define SID_FM_CURRENCYFIELD(SID_MORE_FMSLOTS_START +   5)
-#define SID_FM_PATTERNFIELD (SID_MORE_FMSLOTS_START +   6)
-#define SID_FM_IMAGECONTROL (SID_MORE_FMSLOTS_START +   8)
-#define SID_FM_FORMATTEDFIELD   (SID_MORE_FMSLOTS_START +  26)
-#define SID_FM_SCROLLBAR(SID_MORE_FMSLOTS_START +  66)
-#define SID_FM_SPINBUTTON   (SID_MORE_FMSLOTS_START +  67)
-#define SID_FM_PUSHBUTTON   (SID_FMSLOTS_START + 2)
-#define SID_FM_RADIOBUTTON  (SID_FMSLOTS_START + 3)
-#define SID_FM_CHECKBOX (SID_FMSLOTS_START + 4)
-#define SID_FM_FIXEDTEXT(SID_FMSLOTS_START + 5)
-#define SID_FM_GROUPBOX (SID_FMSLOTS_START + 6)
-#define SID_FM_EDIT (SID_FMSLOTS_START + 7)
-#define SID_FM_LISTBOX  (SID_FMSLOTS_START + 8)
-#define SID_FM_COMBOBOX (SID_FMSLOTS_START + 9)
-#define SID_FM_IMAGEBUTTON  (SID_FMSLOTS_START + 12)
-#define SID_FM_FILECONTROL  (SID_FMSLOTS_START + 13)
-
 static const sal_Int16 nConvertSlots[] =
 {
 SID_FM_CONVERTTO_EDIT,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Justin Lavoie license statement

2016-12-30 Thread Jan Iversen

WELCOME
Thanks for your license statement.

We suggest you add yourself to our wiki (remark this is not a demand)
https://wiki.documentfoundation.org/Development/Developers

If you want help to get started or have any questions, then please contact me. 
I am here to help you (and others) in getting their first patch submitted.

LibreOffice is a very big program and getting it built, setting up gerrit, and 
getting the first patch right can be a bit challenging, therefore do not 
hesitate to email me if you want help.

We have made a step by step guide to help you get started:
https://wiki.documentfoundation.org/Development/GetInvolved

rgds
Jan Iversen.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: ucb/source

2016-12-30 Thread Caolán McNamara

 ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx |4 +---
 ucb/source/ucp/webdav-neon/DAVResourceAccess.hxx |2 +-
 2 files changed, 2 insertions(+), 4 deletions(-)

New commits:
commit a9a30dbe8fa4d4b8693d11df072626f6cbc8631c
Author: CaolÃ¡n McNamara 
Date:   Fri Dec 30 15:10:35 2016 +

unexpected exception seen in tinderbox

  #1  0x2b464842f53a in __GI_abort () at abort.c:89
  save_stage = 2
  act = {__sigaction_handler = {sa_handler = 0x2b4648169a60 
, sa_sigaction = 
0x2b4648169a60 }, 
sa_mask = {__val = {47580863731936, 47582668825824, 47580850742064, 
47580863731456, 2, 47580871027780, 0, 47582668825824, 47580863731456, 
47580873315224, 47580863731936, 47582791173728, 47582791173728, 1, 33350960, 
47582668313696}}, sa_flags = -1151509448, sa_restorer = 0x1fce530}
  sigs = {__val = {32, 0 }}
  #2  0x2b4648e3efdd in __gnu_cxx::__verbose_terminate_handler() () at 
../../../../libstdc++-v3/libsupc++/vterminate.cc:95
  terminating = true
  t = 
  #3  0x2b4648e3ce56 in __cxxabiv1::__terminate(void (*)()) 
(handler=) at 
../../../../libstdc++-v3/libsupc++/eh_terminate.cc:47
  #4  0x2b4648e3cea1 in std::terminate() () at 
../../../../libstdc++-v3/libsupc++/eh_terminate.cc:57
  #5  0x2b4648e3ceb6 in __cxxabiv1::__unexpected(void (*)()) 
(handler=) at 
../../../../libstdc++-v3/libsupc++/eh_terminate.cc:63
  #6  0x2b4648e3cae2 in __cxxabiv1::__cxa_call_unexpected(void*) 
(exc_obj_in=0x2b46b40ad4b0) at 
../../../../libstdc++-v3/libsupc++/eh_personality.cc:759
  info = {Start = 47582791163104, LPStart = 47582996646024, 
ttype_base = 0, TType = 0x2b46bb5d5e30 "", action_table = 0x , ttype_encoding = 1 Â´\001Â´, 
call_site_encoding = 0 Â´\000Â´}
  xh_lsda = 0x2b46c7aab0d4 "\377\233\261\201\200\200"
  xh_switch_value = -1
  exc_obj = 0x2b46b40ad4b0
  xh_terminate_handler = 0x2b4648e3ee70 
<__gnu_cxx::__verbose_terminate_handler()>
  #7  0x2b46c79c6af9 in 
webdav_ucp::DAVResourceAccess::GET(std::__debug::vector > const&, webdav_ucp::DAVResource&, 
com::sun::star::uno::Reference 
const&) (this=0x2b46b410ceb0, rHeaderNames=std::__debug::vector of length 0, 
capacity 0, rResource=..., xEnv=uno::Reference to ((anonymous 
namespace)::UpdateInformationProvider *) 0x2b46bb153918) at 
/home/tinderbox/master/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx:497
  errorCount = 0
  bRetry = false
  xStream = empty uno::Reference

Change-Id: Iaa3ec435af6bed267235a9025fc9334058f20475

diff --git a/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx 
b/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx
index db488b0..ea15233 100644
--- a/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx
+++ b/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx
@@ -451,12 +451,11 @@ void DAVResourceAccess::GET(
 while ( bRetry );
 }
 
-
 uno::Reference< io::XInputStream > DAVResourceAccess::GET(
 const std::vector< OUString > & rHeaderNames,
 DAVResource & rResource,
 const uno::Reference< ucb::XCommandEnvironment > & xEnv )
-  throw( DAVException )
+  throw (css::uno::RuntimeException, DAVException)
 {
 initialize();
 
@@ -496,7 +495,6 @@ uno::Reference< io::XInputStream > DAVResourceAccess::GET(
 return xStream;
 }
 
-
 // used as HEAD substitute when HEAD is not implemented on server
 void DAVResourceAccess::GET0(
 DAVRequestHeaders &rRequestHeaders,
diff --git a/ucb/source/ucp/webdav-neon/DAVResourceAccess.hxx 
b/ucb/source/ucp/webdav-neon/DAVResourceAccess.hxx
index 47f0bd0..8bc9997 100644
--- a/ucb/source/ucp/webdav-neon/DAVResourceAccess.hxx
+++ b/ucb/source/ucp/webdav-neon/DAVResourceAccess.hxx
@@ -132,7 +132,7 @@ public:
 GET( const std::vector< OUString > & rHeaderNames, // empty == 'all'
  DAVResource & rResource,
  const css::uno::Reference< css::ucb::XCommandEnvironment > & xEnv )
-throw ( DAVException );
+throw (css::uno::RuntimeException, DAVException);
 
 // used as HEAD substitute when HEAD is not implemented on server
 void
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/svtools svtools/source

2016-12-30 Thread Caolán McNamara

 include/svtools/svtools.hrc  |  103 ++-
 svtools/source/misc/imagemgr.cxx |  126 ++--
 svtools/source/misc/imagemgr.src |  569 +--
 3 files changed, 682 insertions(+), 116 deletions(-)

New commits:
commit b8e27d5da6b14241e80526d67d68dfd1132a288e
Author: CaolÃ¡n McNamara 
Date:   Tue Dec 27 16:00:56 2016 +

unwind this ImageList

after discovering one of the referenced images was missing

Change-Id: I25321ee436976415313fb004e798fad897673ee5
Reviewed-on: https://gerrit.libreoffice.org/32511
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/include/svtools/svtools.hrc b/include/svtools/svtools.hrc
index 44b14c4..10b8942 100644
--- a/include/svtools/svtools.hrc
+++ b/include/svtools/svtools.hrc
@@ -255,11 +255,104 @@
 #define BMP_CURRENT_PRIMARYKEY  (RID_SVTOOLS_BITMAP_START +  11)
 #define BMP_FILTER  (RID_SVTOOLS_BITMAP_START +  12)
 #define BMP_HEADERFOOTER(RID_SVTOOLS_BITMAP_START +  13)
-
-// image lists
-
-#define RID_SVTOOLS_IMAGELIST_BIG   
(RID_SVTOOLS_IMAGELIST_START +  1)
-#define RID_SVTOOLS_IMAGELIST_SMALL 
(RID_SVTOOLS_IMAGELIST_START +  2)
+#define BMP_IMPRESS_SC  (RID_SVTOOLS_BITMAP_START +  14)
+#define BMP_BITMAP_SC   (RID_SVTOOLS_BITMAP_START +  15)
+#define BMP_CALC_SC (RID_SVTOOLS_BITMAP_START +  16)
+#define BMP_CALCTEMPLATE_SC (RID_SVTOOLS_BITMAP_START +  17)
+#define BMP_DATABASE_SC (RID_SVTOOLS_BITMAP_START +  18)
+#define BMP_IMPRESSTEMPLATE_SC  (RID_SVTOOLS_BITMAP_START +  19)
+#define BMP_GIF_SC  (RID_SVTOOLS_BITMAP_START +  20)
+#define BMP_HTML_SC (RID_SVTOOLS_BITMAP_START +  21)
+#define BMP_JPG_SC  (RID_SVTOOLS_BITMAP_START +  22)
+#define BMP_MATH_SC (RID_SVTOOLS_BITMAP_START +  23)
+#define BMP_MATHTEMPLATE_SC (RID_SVTOOLS_BITMAP_START +  24)
+#define BMP_FILE_SC (RID_SVTOOLS_BITMAP_START +  25)
+#define BMP_PCD_SC  (RID_SVTOOLS_BITMAP_START +  26)
+#define BMP_PCT_SC  (RID_SVTOOLS_BITMAP_START +  27)
+#define BMP_PCX_SC  (RID_SVTOOLS_BITMAP_START +  28)
+#define BMP_SIM_SC  (RID_SVTOOLS_BITMAP_START +  29)
+#define BMP_TEXTFILE_SC (RID_SVTOOLS_BITMAP_START +  30)
+#define BMP_TIFF_SC (RID_SVTOOLS_BITMAP_START +  31)
+#define BMP_WMF_SC  (RID_SVTOOLS_BITMAP_START +  32)
+#define BMP_WRITER_SC   (RID_SVTOOLS_BITMAP_START +  33)
+#define BMP_WRITERTEMPLATE_SC   (RID_SVTOOLS_BITMAP_START +  34)
+#define BMP_FIXEDDEV_SC (RID_SVTOOLS_BITMAP_START +  35)
+#define BMP_REMOVABLEDEV_SC (RID_SVTOOLS_BITMAP_START +  36)
+#define BMP_CDROMDEV_SC (RID_SVTOOLS_BITMAP_START +  37)
+#define BMP_NETWORKDEV_SC   (RID_SVTOOLS_BITMAP_START +  38)
+#define BMP_TABLE_SC(RID_SVTOOLS_BITMAP_START +  39)
+#define BMP_FOLDER_SC   (RID_SVTOOLS_BITMAP_START +  40)
+#define BMP_DXF_SC  (RID_SVTOOLS_BITMAP_START +  41)
+#define BMP_MET_SC  (RID_SVTOOLS_BITMAP_START +  42)
+#define BMP_PNG_SC  (RID_SVTOOLS_BITMAP_START +  43)
+#define BMP_SGF_SC  (RID_SVTOOLS_BITMAP_START +  44)
+#define BMP_SGV_SC  (RID_SVTOOLS_BITMAP_START +  45)
+#define BMP_SVM_SC  (RID_SVTOOLS_BITMAP_START +  46)
+#define BMP_GLOBAL_DOC_SC   (RID_SVTOOLS_BITMAP_START +  47)
+#define BMP_DRAW_SC (RID_SVTOOLS_BITMAP_START +  48)
+#define BMP_DRAWTEMPLATE_SC (RID_SVTOOLS_BITMAP_START +  49)
+#define BMP_TEMPLATE_SC (RID_SVTOOLS_BITMAP_START +  50)
+#define BMP_OO_DATABASE_DOC_SC  (RID_SVTOOLS_BITMAP_START +  51)
+#define BMP_OO_DRAW_DOC_SC  (RID_SVTOOLS_BITMAP_START +  52)
+#define BMP_OO_MATH_DOC_SC  (RID_SVTOOLS_BITMAP_START +  53)
+#define BMP_OO_GLOBAL_DOC_SC(RID_SVTOOLS_BITMAP_START +  54)
+#define BMP_OO_IMPRESS_DOC_SC   (RID_SVTOOLS_BITMAP_START +  55)
+#define BMP_OO_CALC_DOC_SC  (RID_SVTOOLS_BITMAP_START +  56)
+#define BMP_OO_WRITER_DOC_SC(RID_SVTOOLS_BITMAP_START +  57)
+#define BMP_OO_DRAW_TEMPLATE_SC (RID_SVTOOLS_BITMAP_START +  58)
+#define BMP_OO_IMPRESS_TEMPLATE_SC  (RID_SVTOOLS_BITMAP_START +  59)
+#define BMP_OO_CALC_TEMPLATE_SC (RID_SVTOOLS_BITMAP_START +  60)
+#define BMP_OO_WRITER_TEMPLATE_SC   (RID_SVTOOLS_BITMAP_START +  61)
+#define BMP_EXTENSION_SC(RID_SVTOOLS_BITMAP_START +  62)
+#define BMP_IMPRESS_LC  (RID_SVTOOLS_BITMAP_START +  63)
+#define BMP_BITMAP_LC   (RID_

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 6f/0655181db64bdcb70d2c3a4b655f1fef315fcb

2016-12-30 Thread Caolán McNamara

 6f/0655181db64bdcb70d2c3a4b655f1fef315fcb |1 +
 1 file changed, 1 insertion(+)

New commits:
commit e1aed616128b5a83b2664c92dc3db9286ce60e95
Author: CaolÃ¡n McNamara 
Date:   Fri Dec 30 14:07:40 2016 +

Notes added by 'git notes add'

diff --git a/6f/0655181db64bdcb70d2c3a4b655f1fef315fcb 
b/6f/0655181db64bdcb70d2c3a4b655f1fef315fcb
new file mode 100644
index 000..8ebbe55
--- /dev/null
+++ b/6f/0655181db64bdcb70d2c3a4b655f1fef315fcb
@@ -0,0 +1 @@
+ignore: obsolete
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - icon-themes/galaxy icon-themes/hicontrast icon-themes/tango offapi/com

2016-12-30 Thread Caolán McNamara

 icon-themes/galaxy/res/lx03252.png  |binary
 icon-themes/galaxy/res/sx03252.png  |binary
 icon-themes/hicontrast/res/lx03252.png  |binary
 icon-themes/hicontrast/res/sx03252.png  |binary
 icon-themes/tango/res/lx03252.png   |binary
 icon-themes/tango/res/sx03252.png   |binary
 offapi/com/sun/star/graphic/MediaProperties.idl |2 --
 7 files changed, 2 deletions(-)

New commits:
commit 0b21f2964a057412304cf06da4c78fda07647011
Author: CaolÃ¡n McNamara 
Date:   Fri Dec 30 13:54:17 2016 +

drop imagelist example from idl comments

Change-Id: Ib5aede052caa5f6bb7540091aff0f8c6ef2dbfa8

diff --git a/offapi/com/sun/star/graphic/MediaProperties.idl 
b/offapi/com/sun/star/graphic/MediaProperties.idl
index 1a1651f..585b834 100644
--- a/offapi/com/sun/star/graphic/MediaProperties.idl
+++ b/offapi/com/sun/star/graphic/MediaProperties.idl
@@ -47,8 +47,6 @@ published service MediaProperties
 private:resource/projectshortname/bitmap/12345
 private:resource/projectshortname/bitmapex/12345
 private:resource/projectshortname/image/12345
-private:resource/projectshortname/imagelist/12345
-private:resource/projectshortname/imagelist/12345/12
 
 And additionally, GraphicObject scheme URLs like
  
vnd.sun.star.GraphicObject:1194012FB99807BD 
commit 77dea7494b30864736f37816c7e0e58623ec7e95
Author: CaolÃ¡n McNamara 
Date:   Fri Dec 30 13:47:19 2016 +

restore missing images

since...

commit e0e7c5dc46ac8fd0c7f6fdc0ceb62d15cafd3754
Date:   Mon Nov 14 07:23:08 2011 -0800

FDO#42454 - EasyHack: remove code associated with unused icons

Removed the icons and code associated with:
SV_ICON_ID_CHART
SV_ICON_ID_DRAWING_TEMPLATE

Change-Id: I49f98416717183b2767a71d98c4e9ef384654de0

diff --git a/icon-themes/galaxy/res/lx03252.png 
b/icon-themes/galaxy/res/lx03252.png
new file mode 100644
index 000..e742adc
Binary files /dev/null and b/icon-themes/galaxy/res/lx03252.png differ
diff --git a/icon-themes/galaxy/res/sx03252.png 
b/icon-themes/galaxy/res/sx03252.png
new file mode 100644
index 000..94f4ac9
Binary files /dev/null and b/icon-themes/galaxy/res/sx03252.png differ
diff --git a/icon-themes/hicontrast/res/lx03252.png 
b/icon-themes/hicontrast/res/lx03252.png
new file mode 100644
index 000..dca0e84
Binary files /dev/null and b/icon-themes/hicontrast/res/lx03252.png differ
diff --git a/icon-themes/hicontrast/res/sx03252.png 
b/icon-themes/hicontrast/res/sx03252.png
new file mode 100644
index 000..0683f07
Binary files /dev/null and b/icon-themes/hicontrast/res/sx03252.png differ
diff --git a/icon-themes/tango/res/lx03252.png 
b/icon-themes/tango/res/lx03252.png
new file mode 100644
index 000..8824d12
Binary files /dev/null and b/icon-themes/tango/res/lx03252.png differ
diff --git a/icon-themes/tango/res/sx03252.png 
b/icon-themes/tango/res/sx03252.png
new file mode 100644
index 000..50d1d89
Binary files /dev/null and b/icon-themes/tango/res/sx03252.png differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

2016-12-30 Thread Caolán McNamara

 vcl/source/gdi/CommonSalLayout.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit d19c05bbf0073033573ef428b63f37e7caa12337
Author: CaolÃ¡n McNamara 
Date:   Fri Dec 30 11:54:38 2016 +

ofz#355: lsan detected leak

Direct leak of 1296 byte(s) in 6 object(s) allocated from:
#0 0x5de7a0 in __interceptor_calloc 
/src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:72
#1 0xe0f2132 in hb_shape_plan_t* hb_object_create() 
/work/workdir/UnpackedTarball/harfbuzz/src/./hb-object-private.hh:129:24
#2 0xe0f2132 in hb_shape_plan_create 
/work/workdir/UnpackedTarball/harfbuzz/src/hb-shape-plan.cc:133
#3 0x85a3488 in CommonSalLayout::LayoutText(ImplLayoutArgs&) 
/src/libreoffice/vcl/source/gdi/CommonSalLayout.cxx:555:40
#4 0x3d97cf2 in OutputDevice::ImplLayout(rtl::OUString const&, int, 
int, Point const&, long, long const*, SalLayoutFlags, vcl::TextLayoutCache 
const*) const /src/libreoffice/vcl/source/outdev/text.cxx:1318:36
#5 0x3d990e1 in OutputDevice::GetTextArray(rtl::OUString const&, long*, 
int, int, vcl::TextLayoutCache const*) const 
/src/libreoffice/vcl/source/outdev/text.cxx:966:35
#6 0x3d98d2d in OutputDevice::GetTextWidth(rtl::OUString const&, int, 
int, vcl::TextLayoutCache const*) const 
/src/libreoffice/vcl/source/outdev/text.cxx:893:19
#7 0x485f630 in ImplFontMetricData::ImplInitTextLineSize(OutputDevice 
const*) /src/libreoffice/vcl/source/font/fontmetric.cxx:338:30
#8 0x3d6801e in OutputDevice::ImplNewFont() const 
/src/libreoffice/vcl/source/outdev/font.cxx:1095:42
#9 0x3d64d92 in OutputDevice::GetFontMetric() const 
/src/libreoffice/vcl/source/outdev/font.cxx:171:23
#10 0x8695053 in WinMtfFontStyle::WinMtfFontStyle(LOGFONTW&) 
/src/libreoffice/vcl/source/filter/wmf/winmtf.cxx:265:36
#11 0x8686b9b in std::__1::unique_ptr > o3tl::make_unique(LOGFONTW&) /src/libreoffice/include/o3tl/make_unique.hxx:27:35
#12 0x86eb23c in WMFReader::ReadRecordParams(unsigned short) 
/src/libreoffice/vcl/source/filter/wmf/winwmf.cxx:937:32
#13 0x86fb901 in WMFReader::ReadWMF() 
/src/libreoffice/vcl/source/filter/wmf/winwmf.cxx:1371:25
#14 0x47c5949 in ReadWindowMetafile(SvStream&, GDIMetaFile&) 
/src/libreoffice/vcl/source/filter/wmf/wmf.cxx:78:45
#15 0x61c7ac in LLVMFuzzerTestOneInput 
/src/libreoffice/vcl/workben/wmffuzzer.cxx:98:11
#16 0x1011f7e8 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, 
unsigned long) /src/libfuzzer/FuzzerLoop.cpp:541:13
#17 0x10120544 in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned 
long) /src/libfuzzer/FuzzerLoop.cpp:492:3
#18 0x1013ecca in fuzzer::Fuzzer::RunOne(std::__1::vector > const&) 
/src/libfuzzer/FuzzerInternal.h:118:41
#19 0x1011ee3d in 
fuzzer::Fuzzer::ShuffleAndMinimize(std::__1::vector >, 
std::__1::allocator > > >*) /src/libfuzzer/FuzzerLoop.cpp:471:30
#20 0x100d0aea in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned 
char const*, unsigned long)) /src/libfuzzer/FuzzerDriver.cpp:533:6
#21 0x100c38c8 in main /src/libfuzzer/FuzzerMain.cpp:20:10
#22 0x7fef8459582f in __libc_start_main 
(/lib/x86_64-linux-gnu/libc.so.6+0x2082f)

Change-Id: Iaa23f8282a45b7c584410b5e8c7b6e9774a34aaf
Reviewed-on: https://gerrit.libreoffice.org/32508
Reviewed-by: Khaled Hosny 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index 75b0280..2dd9925 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -558,6 +558,7 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs)
 (void) ok;
 hb_buffer_set_content_type(pHbBuffer, 
HB_BUFFER_CONTENT_TYPE_GLYPHS);
 SAL_INFO("vcl.harfbuzz", hb_shape_plan_get_shaper(pHbPlan) << " 
shaper used for " << mrFontSelData.GetFamilyName());
+hb_shape_plan_destroy(pHbPlan);
 
 int nRunGlyphCount = hb_buffer_get_length(pHbBuffer);
 hb_glyph_info_t *pHbGlyphInfos = 
hb_buffer_get_glyph_infos(pHbBuffer, nullptr);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: ScInterpreter::ScGCD and ScInterpreter::ScLCM

2016-12-30 Thread Markus Mohrhard

Hey,

On Fri, Dec 30, 2016 at 12:56 PM, Filippo giacchè  wrote:

> Hi to everyone,
> I m trying to optimize ScInterpreter::ScGCD and ScInterpreter::ScLCM (in /
> core /sc
> /source
> /core
> /tool
> /
> interpr5.cxx
> )
> as mentioned in bug tdf#89387..
> From what I understood , these function are not optimal in the matrix case
> (evenif the algorithms look good in my opinion) and need to be changed. So
> my question is how can I do it? If I create function in
> /core/sc/source/core/tool/ScMatrix.cxx that take as input a matrix and
> retuns the GCD(or LCM) I'll do ok?or is not the right way to proceed?
> thanks ,I welcome any advice that you can give me.
>
>
>
The task is not about changing the algorithm. The new matrix backend does
not have O(1) index based access any more so stuff like:

for (int i = 0; i < n; ++i)
{
matrix.set(i, y, value);
}

is not a O(n) algorithm anymore.

However the new matrix backend provides some alternatives that allow to
write more efficient implementations (that are even faster -- by a constant
factor) than the old one. For that we need to use some of the constructs
written as part of this bug by . As an example for such a change look at
https://cgit.freedesktop.org/libreoffice/core/commit/?id=9a7959cd63be7b2f36da8af25e7673a525c4d66c
and try to understand how ApplyOperation and the operator play together.
All of this should make sense if you realize that we have no O(n) index
access but that iterator access is in O(1).

If you need a bit more details after looking at some of the commits in the
bug report you can ping me again.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ScInterpreter::ScGCD and ScInterpreter::ScLCM

2016-12-30 Thread Kaganski Mike

Hi,

On 12/30/2016 2:56 PM, Filippo giacchè wrote:
I m trying to optimize ScInterpreter::ScGCD and ScInterpreter::ScLCM (in 
/core/sc/source/core/tool/interpr5.cxx)
 as mentioned in bug tdf#89387..
From what I understood , these function are not optimal in the matrix case 
(evenif the algorithms look good in my opinion) and need to be changed. So my 
question is how can I do it? If I create function in 
/core/sc/source/core/tool/ScMatrix.cxx that take as input a matrix and retuns 
the GCD(or LCM) I'll do ok?or is not the right way to proceed? thanks ,I 
welcome any advice that you can give me.

I would suggest you to suggest your vision as a change posted to gerrit for 
review, and let others to discuss the implementation: that could be much more 
productive IMO.
If I'm wrong, I hope others will correct me.

--
Best regards,
Mike Kaganski
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

ScInterpreter::ScGCD and ScInterpreter::ScLCM

2016-12-30 Thread Filippo giacchè

Hi to everyone,
I m trying to optimize ScInterpreter::ScGCD and ScInterpreter::ScLCM (in /
core /sc
/source
/core
/tool
/interpr5.cxx
)
as mentioned in bug tdf#89387..
>From what I understood , these function are not optimal in the matrix case
(evenif the algorithms look good in my opinion) and need to be changed. So
my question is how can I do it? If I create function in
/core/sc/source/core/tool/ScMatrix.cxx that take as input a matrix and
retuns the GCD(or LCM) I'll do ok?or is not the right way to proceed?
thanks ,I welcome any advice that you can give me.

Kind regards,
filippo giacchè
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: vcl/inc vcl/unx

2016-12-30 Thread Khaled Hosny

 vcl/inc/unx/glyphcache.hxx |   29 +++--
 vcl/unx/generic/gdi/cairotextrender.cxx|3 --
 vcl/unx/generic/glyphs/freetype_glyphcache.cxx |   14 
 vcl/unx/generic/glyphs/glyphcache.cxx  |6 ++---
 vcl/unx/generic/print/genpspgraphics.cxx   |3 --
 5 files changed, 10 insertions(+), 45 deletions(-)

New commits:
commit f2a5e6dc8f9c79b31ca1044fac8caa0130205e3c
Author: Khaled Hosny 
Date:   Fri Dec 30 11:02:18 2016 +0200

Get rid of GlyphMetric class

All we need is Rectangle, so lets keep things simple.

Change-Id: I8c47a9159696b52d22c327f257d5e4aa8898d871
Reviewed-on: https://gerrit.libreoffice.org/32506
Tested-by: Jenkins 
Reviewed-by: Khaled Hosny 

diff --git a/vcl/inc/unx/glyphcache.hxx b/vcl/inc/unx/glyphcache.hxx
index c86dbac..935837d 100644
--- a/vcl/inc/unx/glyphcache.hxx
+++ b/vcl/inc/unx/glyphcache.hxx
@@ -94,39 +94,19 @@ private:
 FreetypeManager*mpFtManager;
 };
 
-class GlyphMetric
-{
-public:
-GlyphMetric() {}
-
-const Point&GetOffset() const   { return maOffset; }
-const Size& GetSize() const { return maSize; }
-
-protected:
-friend class GlyphData;
-voidSetOffset( int nX, int nY ) { maOffset = Point( 
nX, nY); }
-voidSetSize( const Size& s ){ maSize = s; }
-
-private:
-Point   maOffset;
-SizemaSize;
-};
-
 class GlyphData
 {
 public:
 GlyphData() : mnLruValue(0) {}
 
-const GlyphMetric&  GetMetric() const   { return 
maGlyphMetric; }
-
-voidSetSize( const Size& s) { 
maGlyphMetric.SetSize( s ); }
-voidSetOffset( int nX, int nY ) { 
maGlyphMetric.SetOffset( nX, nY ); }
+const Rectangle&GetBoundRect() const{ return maBoundRect; }
+voidSetBoundRect(Rectangle r)   { maBoundRect = r; }
 
 voidSetLruValue( int n ) const  { mnLruValue = n; }
 longGetLruValue() const { return mnLruValue;}
 
 private:
-GlyphMetric maGlyphMetric;
+Rectangle   maBoundRect;
 
 // used by GlyphCache for cache LRU algorithm
 mutable longmnLruValue;
@@ -154,8 +134,7 @@ public:
 const FontCharMapRefGetFontCharMap() const;
 boolGetFontCapabilities(vcl::FontCapabilities &) const;
 
-const GlyphMetric&  GetGlyphMetric(const GlyphItem& rGlyph);
-
+const Rectangle&GetGlyphBoundRect(const GlyphItem& rGlyph);
 boolGetGlyphOutline(const GlyphItem& rGlyph, 
basegfx::B2DPolyPolygon&) const;
 boolGetAntialiasAdvice() const;
 hb_font_t*  GetHbFont() { return mpHbFont; }
diff --git a/vcl/unx/generic/gdi/cairotextrender.cxx 
b/vcl/unx/generic/gdi/cairotextrender.cxx
index b3f6165..842a6b6 100644
--- a/vcl/unx/generic/gdi/cairotextrender.cxx
+++ b/vcl/unx/generic/gdi/cairotextrender.cxx
@@ -435,8 +435,7 @@ bool CairoTextRender::GetGlyphBoundRect(const GlyphItem& 
rGlyph, Rectangle& rRec
 if( !pSF )
 return false;
 
-const GlyphMetric& rGM = pSF->GetGlyphMetric(rGlyph);
-Rectangle aRect( rGM.GetOffset(), rGM.GetSize() );
+Rectangle aRect = pSF->GetGlyphBoundRect(rGlyph);
 
 if ( pSF->mnCos != 0x1 && pSF->mnSin != 0 )
 {
diff --git a/vcl/unx/generic/glyphs/freetype_glyphcache.cxx 
b/vcl/unx/generic/glyphs/freetype_glyphcache.cxx
index ca84009..50c5eba 100644
--- a/vcl/unx/generic/glyphs/freetype_glyphcache.cxx
+++ b/vcl/unx/generic/glyphs/freetype_glyphcache.cxx
@@ -635,12 +635,7 @@ void FreetypeFont::InitGlyphData(const GlyphItem& rGlyph, 
GlyphData& rGD ) const
 FT_Error rc = FT_Load_Glyph(maFaceFT, rGlyph.maGlyphId, mnLoadFlags);
 
 if( rc != FT_Err_Ok )
-{
-// we get here e.g. when a PS font lacks the default glyph
-rGD.SetOffset( 0, 0 );
-rGD.SetSize( Size( 0, 0 ) );
 return;
-}
 
 if (mbArtBold)
 FT_GlyphSlot_Embolden(maFaceFT->glyph);
@@ -652,15 +647,8 @@ void FreetypeFont::InitGlyphData(const GlyphItem& rGlyph, 
GlyphData& rGD ) const
 
 FT_BBox aBbox;
 FT_Glyph_Get_CBox( pGlyphFT, FT_GLYPH_BBOX_PIXELS, &aBbox );
-if( aBbox.yMin > aBbox.yMax )   // circumvent freetype bug
-{
-int t=aBbox.yMin;
-aBbox.yMin=aBbox.yMax;
-aBbox.yMax=t;
-}
 
-rGD.SetOffset( aBbox.xMin, -aBbox.yMax );
-rGD.SetSize( Size( (aBbox.xMax-aBbox.xMin+1), (aBbox.yMax-aBbox.yMin) ) );
+rGD.SetBoundRect(Rectangle(aBbox.xMin, -aBbox.yMax, aBbox.xMax, 
-aBbox.yMin));
 
 FT_Done_Glyph( pGlyphFT );
 }
diff --git a/vcl/unx/generic/glyphs/glyphcache.cxx 
b/vcl/unx/generic/glyphs/glyphcache.cxx
index 103fc54..1a49c52 100644
--- a/vcl/unx/generic/glyphs/glyphcache.cxx
+++ b/vcl/un

[Libreoffice-commits] core.git: vcl/source

2016-12-30 Thread Khaled Hosny

 vcl/source/helper/canvastools.cxx |8 ++--
 1 file changed, 2 insertions(+), 6 deletions(-)

New commits:
commit f28d9aaea39f9a2b50c6b9ae36c466771ab72a92
Author: Khaled Hosny 
Date:   Fri Dec 30 02:04:47 2016 +0200

Use existing basegfx::fround()

Change-Id: Id3d47212a5efd9367a08b428a39f014819cedf71
Reviewed-on: https://gerrit.libreoffice.org/32505
Tested-by: Jenkins 
Reviewed-by: Khaled Hosny 

diff --git a/vcl/source/helper/canvastools.cxx 
b/vcl/source/helper/canvastools.cxx
index a81ec6b..b66ec69 100644
--- a/vcl/source/helper/canvastools.cxx
+++ b/vcl/source/helper/canvastools.cxx
@@ -344,16 +344,12 @@ namespace vcl
 
 ::Point pointFromB2DPoint( const basegfx::B2DPoint& rPoint )
 {
-return ::Point( FRound( rPoint.getX() ),
-FRound( rPoint.getY() ) );
+return pointFromB2IPoint(basegfx::fround(rPoint));
 }
 
 ::Rectangle rectangleFromB2DRectangle( const basegfx::B2DRange& rRect )
 {
-return ::Rectangle( FRound( rRect.getMinX() ),
-FRound( rRect.getMinY() ),
-FRound( rRect.getMaxX() ),
-FRound( rRect.getMaxY() ) );
+return rectangleFromB2IRectangle(basegfx::fround(rRect));
 }
 
 Point pointFromB2IPoint( const basegfx::B2IPoint& rPoint )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Bug TDF#99097 - Call for reflection

2016-12-30 Thread Pierre Lepage


Hi Jan, Eike and Markus,

OK. So I write to Eike and Markus.

I reviewed the case analysis and corrected some misinterpretation. So 
here it is.


Currently, the codes "NN", "NNN" and "" are represented respectively 
by the keys NF_KEY_NN, NF_KEY_NNN and NF_KEY_ and serve in LO for 
the short name of the day (Mon, Tue, Wen ...), the long name of the day 
without separator and the long name of the day with separator. The keys 
NF_KEY_DDD and NF_KEY_ already fulfill the need for the abbreviation 
format of the short name of the day and format of the long name of the 
day (without separator). In addition, StarBasic encodes "N" and "NN" as 
formats different from those of LO, but similar to VBA, ie "N" for 
minutes without 0 in prefix and "NN" for minutes With 0 in prefix. But 
this code is for a very special situation and not too useful! There is a 
blatant inconsistency and confusion in the use of N, NN, NNN, , DDD 
and  codes.


The first solution appears as a crutch. Coding for an exception will not 
resolve the source of confusion. Nevertheless, if this solution were to 
be implemented, the algorithm would have to distinguish between two 
situations of the codes: a) the codes are embedded in a time format 
string only in which case the interpretation of the N and NN codes would 
be in conformity To VBA, that is to say that N would code for minutes 
without 0 in prefix and NN would code for minutes with 0 in prefix; B) 
otherwise the codes would be interpreted as they are now, ie NN would 
code for the abbreviation of the name of the day and N would be ignored.


The second solution appears more robust. The confusion would be 
definitively eliminated. It remains that the historical reason behind 
the choice of the letters NN and NNN rather than exclusively DDD and 
 to codify an abbreviated and long day format is unknown to me. It 
is therefore possible that old files based on the current interpretation 
of the NN, NNN and  codes will require corrections to rely solely on 
the DDD and  codes.


I included a Calc file summarizing the format codes for dates and time. 
The first tab is the current situation. The second tab is for the 
situation once the second solution is implemented.


So, before going any further, I need to know the desired orientation for 
LibreOffice.


Regards,

Pierre Lepage


Le 2016-12-24 à 03:09, Jan Iversen a écrit :

Hi

It is vacation time, so please be prepared to wait a bit longer for 
answers :-)



So, my question is: what do you think?
Personally I think we should try to have a consistent behaviour in our 
code base, however Eike and Markus are the specialist in Calc, and 
they might have some reasons to do things in a special way.


rgds
jan I.



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice




Format_Code
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

New Defects reported by Coverity Scan for LibreOffice

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - framework/Library_fwk.mk framework/source

[Libreoffice-commits] core.git: sc/source

[Libreoffice-commits] core.git: external/harfbuzz

[Libreoffice-commits] core.git: helpcontent2

[Libreoffice-commits] help.git: source/text

Re: getting error for building the libre office source code...

[Libreoffice-commits] help.git: source/text

[Libreoffice-commits] core.git: helpcontent2

[Libreoffice-commits] core.git: external/harfbuzz

[Libreoffice-commits] core.git: Branch 'feature/mar-updater' - onlineupdate/Executable_updater.mk onlineupdate/Module_onlineupdate.mk onlineupdate/WinResTarget_updater.mk

[Libreoffice-commits] core.git: Branch 'feature/mar-updater' - 2 commits - bin/update

[Libreoffice-commits] core.git: Branch 'feature/mar-updater' - 5 commits - onlineupdate/source

[Libreoffice-commits] help.git: source/text

[Libreoffice-commits] core.git: helpcontent2

[Libreoffice-commits] core.git: accessibility/source chart2/source cli_ure/source connectivity/source dbaccess/source dtrans/source editeng/source fpicker/source i18npool/inc include/onlineupdate incl

[Libreoffice-commits] core.git: sc/qa

[Libreoffice-commits] core.git: sc/qa

[Libreoffice-commits] core.git: 2 commits - include/tools rsc/inc rsc/source

[Libreoffice-commits] core.git: 4 commits - framework/source include/tools include/vcl rsc/inc rsc/source svtools/source vcl/source

[Libreoffice-commits] core.git: framework/source

Re: Justin Lavoie license statement

[Libreoffice-commits] core.git: ucb/source

[Libreoffice-commits] core.git: include/svtools svtools/source

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 6f/0655181db64bdcb70d2c3a4b655f1fef315fcb

[Libreoffice-commits] core.git: 2 commits - icon-themes/galaxy icon-themes/hicontrast icon-themes/tango offapi/com

[Libreoffice-commits] core.git: vcl/source

Re: ScInterpreter::ScGCD and ScInterpreter::ScLCM

Re: ScInterpreter::ScGCD and ScInterpreter::ScLCM

ScInterpreter::ScGCD and ScInterpreter::ScLCM

[Libreoffice-commits] core.git: vcl/inc vcl/unx

[Libreoffice-commits] core.git: vcl/source

Re: Bug TDF#99097 - Call for reflection

33 matches

Site Navigation

Mail list logo

Footer information