[Libreoffice-bugs] [Bug 105154] FILESAVE: DOCX: Extra page displayed in MSO Word after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=105154 --- Comment #3 from Justin L--- This one is funny. Before the "regression" LO incorrectly imported the single page document as two-pages. On a round-trip, both Word and LO see it as one page. After the regression, LO correctly imported the single page document as one-page. On a round trip, Word sees it as two pages (because of an extra carriage return I believe). Since the "regression" patch is an import patch, and this is an export bug, this is really just exposing a different bug elsewhere. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105230] Can not type text with multiple slashes; /foo/ become foo in italic
https://bugs.documentfoundation.org/show_bug.cgi?id=105230 Jim Averachanged: What|Removed |Added Version|5.0.4.2 release |5.4.0.0.alpha0+ Master --- Comment #1 from Jim Avera --- I'm sorry, I must have been confused. The problem only appears in master (not 5.3 or before) Version: 5.4.0.0.alpha0+ Build ID: 6bd7451ecd66417a4e8b8dff3874c15ba4d1536e CPU Threads: 8; OS Version: Linux 4.4; UI Render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-01-05_23:29:43 Locale: en-US (en_US.UTF-8); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105230] New: Can not type text with multiple slashes; /foo/ become foo in italic
https://bugs.documentfoundation.org/show_bug.cgi?id=105230 Bug ID: 105230 Summary: Can not type text with multiple slashes; /foo/ become foo in italic Product: LibreOffice Version: 5.0.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jim.av...@gmail.com /text between slashes/ is auto-converted to italic and the slashes disappear. This occurs in Writer and Calc (at least). I'm guessing it is an Accessibility feature to help people who can not easily hold down the CONTROL key and so can't use the usual Control-I to enter italic mode. However it is extremely annoying and makes it almost impossible to enter /linux/style/path/names/with/forward/slashes (you have to go back and "correct" the text to put the slashes back and un-italicize the text). I couldn't find any documentation about this, or anything relevant under Tools->Options->LibreOffice->Accessibilty. I tried turning off everything in Tools->Options->Writing Aids but the behaviour persisted. I also tried a new blank profile (Help->Restart in Safe mode >Reset to Factory Settings >Reset User Profile). This did not stop the behavior. This is a bug, either altogether or the fact that it is enabled by default (and IMO not documented sufficiently to allow users to turn it off). NOTE: I see this problem in 5.0.4.0.0 but NOT 5.2, 5.2, or 5.3, and then it re-appears in the latest master (5.4.0.0.alpha0+). STEPS TO REPRODUCE: 1. Start libreoffice -- --writer (version 5.0 OR 5.4/master) 2. Type /foo/bar RESULTS: The text changes to "foobar" with "foo" italicized EXPECTED RESULTS: Text is not molested or slashes removed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97080] FILEOPEN: Need broader filter for delimited text files (" Text CSV" only includes *.csv)
https://bugs.documentfoundation.org/show_bug.cgi?id=97080 tvalloischanged: What|Removed |Added Assignee|libreoffice-b...@lists.free |thibault2...@hotmail.fr |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70597] URL corrupted when right click in the formula bar
https://bugs.documentfoundation.org/show_bug.cgi?id=70597 --- Comment #10 from tommy27--- still present in LibO 5.2.4.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 4 new defect(s) introduced to LibreOffice found with Coverity Scan. 17 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 4 of 4 defect(s) ** CID 1398527: Error handling issues (UNCAUGHT_EXCEPT) /scripting/source/dlgprov/dlgprov.cxx: 615 in dlgprov::DialogProviderImpl::createDialogImpl(const rtl::OUString &, const com::sun::star::uno::Reference &, const com::sun::star::uno::Reference &, bool)() *** CID 1398527: Error handling issues (UNCAUGHT_EXCEPT) /scripting/source/dlgprov/dlgprov.cxx: 615 in dlgprov::DialogProviderImpl::createDialogImpl(const rtl::OUString &, const com::sun::star::uno::Reference &, const com::sun::star::uno::Reference &, bool)() 609 610 // XDialogProvider 611 612 613 static const char aDecorationPropName[] = "Decoration"; 614 >>> CID 1398527: Error handling issues (UNCAUGHT_EXCEPT) >>> An exception of type "std::length_error" is thrown but the throw list >>> "throw(com::sun::star::uno::RuntimeException, >>> com::sun::star::lang::IllegalArgumentException)" doesn't allow it to be >>> thrown. This will cause a call to unexpected() which usually calls >>> terminate(). 615 Reference < XControl > DialogProviderImpl::createDialogImpl( 616 const OUString& URL, const Reference< XInterface >& xHandler, 617 const Reference< XWindowPeer >& xParent, bool bDialogProviderMode ) 618 throw (IllegalArgumentException, RuntimeException) 619 { 620 // if the dialog is located in a document, the document must already be open! ** CID 1398526: Error handling issues (UNCAUGHT_EXCEPT) /i18npool/source/localedata/localedata.cxx: 602 in com::sun::star::i18n::LocaleDataImpl::getCalendarItemByName(const rtl::OUString &, const com::sun::star::lang::Locale &, const com::sun::star::uno::Sequence &, short)() *** CID 1398526: Error handling issues (UNCAUGHT_EXCEPT) /i18npool/source/localedata/localedata.cxx: 602 in com::sun::star::i18n::LocaleDataImpl::getCalendarItemByName(const rtl::OUString &, const com::sun::star::lang::Locale &, const com::sun::star::uno::Sequence &, short)() 596 #define REF_MONTHS 1 597 #define REF_GMONTHS 2 598 #define REF_PMONTHS 3 599 #define REF_ERAS 4 600 #define REF_OFFSET_COUNT 5 601 >>> CID 1398526: Error handling issues (UNCAUGHT_EXCEPT) >>> An exception of type "std::length_error" is thrown but the throw list >>> "throw(com::sun::star::uno::RuntimeException)" doesn't allow it to be >>> thrown. This will cause a call to unexpected() which usually calls >>> terminate(). 602 Sequence< CalendarItem2 > ::getCalendarItemByName(const OUString& name, 603 const Locale& rLocale, const Sequence< Calendar2 >& calendarsSeq, sal_Int16 item) 604 throw(RuntimeException) 605 { 606 if (!ref_name.equals(name)) { 607 OUString aLocStr, id; ** CID 1398525: Error handling issues (UNCAUGHT_EXCEPT) /filter/source/config/cache/filtercache.cxx: 1516 in filter::config::FilterCache::impl_readPatchUINames(const com::sun::star::uno::Reference &, filter::config::CacheItem &)() *** CID 1398525: Error handling issues (UNCAUGHT_EXCEPT) /filter/source/config/cache/filtercache.cxx: 1516 in filter::config::FilterCache::impl_readPatchUINames(const com::sun::star::uno::Reference &, filter::config::CacheItem &)() 1510 default: break; 1511 } 1512 } 1513 } 1514 1515 >>> CID 1398525: Error handling issues (UNCAUGHT_EXCEPT) >>> An exception of type "std::length_error" is thrown but the throw list >>> "throw(com::sun::star::uno::Exception)" doesn't allow it to be thrown. This >>> will cause a call to unexpected() which usually calls terminate(). 1516 void FilterCache::impl_readPatchUINames(const css::uno::Reference< css::container::XNameAccess >& xNode, 1517 CacheItem& rItem) 1518 throw(css::uno::Exception) 1519 { 1520 1521 // SAFE -> -- ** CID 1398524: Error handling issues (UNCAUGHT_EXCEPT) /linguistic/source/lngsvcmgr.cxx: 2019 in LngSvcMgr_CreateInstance(const com::sun::star::uno::Reference &)() *** CID 1398524:
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/data/functions/financial/fods/tbilleq.fods | 3125 ++ 1 file changed, 3125 insertions(+) New commits: commit ea56ac812f254a62c1ad4d2fe4651c07269b40ba Author: ZdenÄk CrhonekDate: Sat Jan 7 12:21:10 2017 +0100 add TBILLEQ test case Change-Id: I2a58b90f050007347489299073bc4eef339af678 Reviewed-on: https://gerrit.libreoffice.org/32815 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/sc/qa/unit/data/functions/financial/fods/tbilleq.fods b/sc/qa/unit/data/functions/financial/fods/tbilleq.fods new file mode 100644 index 000..9057f93 --- /dev/null +++ b/sc/qa/unit/data/functions/financial/fods/tbilleq.fods @@ -0,0 +1,3125 @@ + + +http://www.w3.org/1999/xlink; xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" xmlns:math="http://www.w3.org/1998/Math/MathML; xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" xmlns:ooo="http://openoffice.org/2004/office; xmlns:ooow="http://openoffice.org/2004/writer; xmlns:oooc="http://openoffice.org/2004/calc; xmlns:dom="http://www.w3.org/2001/xml-events; xmlns:xforms="http://www.w3.org/2002/xforms; xmlns:xsd="http://www.w3.org/2001/XMLSchema; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xmlns:rpt="http://openoffice.org/2005/report; xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" xmlns:xhtml="http://www.w3.org/1999/xhtml; xmlns:grddl="http://www.w3.org/2003/g/data-view#; xmlns:tableooo="http://openoffice.org/2009/table; xmlns:drawooo="http://openoffice.org/2010/draw; xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0" xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0" xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" xmlns:form x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" office:mimetype="application/vnd.oasis.opendocument.spreadsheet"> + 2016-07-19T11:56:05.71800P0D1LibreOfficeDev/5.4.0.0.alpha0$Linux_X86_64 LibreOffice_project/92a1ad1f36b6d3cc13135a8c0805508933011577 + + + 0 + 0 + 53793 + 12387 + + + view1 + + + 2 + 8 + 0 + 0 + 0 + 0 + 2 + 0 + 0 + 0 + 0 + 0 + 75 + 60 + true + false + + + 1 + 26 + 0 + 0 + 0 + 0 + 2 + 0 + 0 + 0 + 0 + 0 + 75 + 60 + true + false + + + Sheet2 + 1241 + 0 + 75 + 60 + false + true + true + true + 12632256 + true + true + true + true + false + false + false + 1270 + 1270 + 1 + 1 + true + false + + + + + 7 + false + false + true + true + false + false + false + 1270 + 1270 + true + true + true + true + true + false + 12632256 + false + Lexmark-E352dn + + + cs + CZ + + + + + + en + US + + + + + + nl + NL + + + + + + true + true + 3 + 1 + true + 1 + true + lgH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMAtwAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhClBhZ2VTaXplOkxldHRlcgAAEgBDT01QQVRfRFVQTEVYX01PREUPAER1cGxleE1vZGU6Ok9mZg== + false + 0 + + + + + http://openoffice.org/2004/office; xmlns:xlink="http://www.w3.org/1999/xlink;> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + KÄ + + + + - + + + KÄ + + + + + + + + + + ( + + ) + + + + - + + + + + + + + + + + + + + KÄ + + + - + + + KÄ + + + + + + KÄ + + + - + + + KÄ + + + + + + KÄ + +
[Libreoffice-commits] core.git: 27 commits - basegfx/test compilerplugins/clang connectivity/source desktop/source filter/source helpcompiler/source i18nlangtag/source i18npool/source linguistic/sourc
basegfx/test/basegfx2d.cxx | 26 - basegfx/test/boxclipper.cxx | 36 +- basegfx/test/clipstate.cxx | 15 - basegfx/test/genericclipper.cxx |8 compilerplugins/clang/conststringvar.cxx| 136 ++ compilerplugins/clang/stringconstant.cxx| 14 + connectivity/source/drivers/calc/CConnection.cxx|4 connectivity/source/drivers/evoab2/NConnection.cxx |4 connectivity/source/drivers/jdbc/Array.cxx | 16 - connectivity/source/drivers/jdbc/Blob.cxx | 12 connectivity/source/drivers/jdbc/CallableStatement.cxx | 14 - connectivity/source/drivers/jdbc/Clob.cxx | 12 connectivity/source/drivers/jdbc/DatabaseMetaData.cxx | 24 - connectivity/source/drivers/jdbc/InputStream.cxx|4 connectivity/source/drivers/jdbc/JBigDecimal.cxx|4 connectivity/source/drivers/jdbc/JConnection.cxx|8 connectivity/source/drivers/jdbc/JStatement.cxx | 14 - connectivity/source/drivers/jdbc/PreparedStatement.cxx | 30 +- connectivity/source/drivers/jdbc/Reader.cxx |8 connectivity/source/drivers/jdbc/ResultSet.cxx | 24 - connectivity/source/drivers/jdbc/Timestamp.cxx |6 connectivity/source/drivers/jdbc/tools.cxx | 10 connectivity/source/drivers/mozab/bootstrap/MNSFolders.cxx |4 connectivity/source/drivers/postgresql/pq_preparedstatement.cxx |2 desktop/source/migration/services/wordbookmigration.cxx |2 filter/source/msfilter/escherex.cxx |2 filter/source/msfilter/msdffimp.cxx |2 helpcompiler/source/HelpLinker.cxx |2 i18nlangtag/source/isolang/inunx.cxx|4 i18npool/source/nativenumber/nativenumbersupplier.cxx |6 linguistic/source/dicimp.cxx|6 oox/source/export/chartexport.cxx |4 oox/source/export/drawingml.cxx |8 opencl/source/openclwrapper.cxx |2 sal/osl/unx/profile.cxx |2 sal/qa/rtl/strings/test_oustring_compare.cxx|6 sax/source/tools/converter.cxx | 10 sc/qa/unit/tiledrendering/tiledrendering.cxx|2 sc/qa/unit/ucalc_sharedformula.cxx |6 sc/source/core/opencl/formulagroupcl.cxx|2 sc/source/filter/dif/difexp.cxx | 32 +- sc/source/ui/unoobj/dispuno.cxx | 16 - scaddins/source/analysis/analysishelper.cxx |2 sd/qa/unit/tiledrendering/tiledrendering.cxx|2 sd/source/filter/html/htmlex.cxx| 16 - sd/source/ui/remotecontrol/BluetoothServer.cxx |2 sd/source/ui/remotecontrol/BluetoothServiceRecord.hxx |2 sdext/source/pdfimport/test/tests.cxx | 12 sfx2/source/appl/sfxhelp.cxx|8 sfx2/source/doc/SfxDocumentMetaData.cxx | 37 +- sfx2/source/sidebar/Deck.cxx|2 shell/source/unix/sysshell/recently_used_file_handler.cxx | 10 starmath/qa/cppunit/test_nodetotextvisitors.cxx |4 svx/source/dialog/hexcolorcontrol.cxx |2 svx/source/form/fmsrccfg.cxx|2 sw/qa/extras/tiledrendering/tiledrendering.cxx |2 sw/qa/extras/uiwriter/uiwriter.cxx |2 sw/source/core/text/xmldump.cxx |2 sw/source/filter/html/css1atr.cxx |2 sw/source/filter/html/wrthtml.cxx |2 sw/source/uibase/uno/unodispatch.cxx| 34 +- unodevtools/source/skeletonmaker/javacompskeleton.cxx |2 unodevtools/source/skeletonmaker/skeletonmaker.cxx |4 unoxml/source/rdf/librdf_repository.cxx |2 vcl/source/font/font.cxx| 10 vcl/source/fontsubset/sft.cxx | 42 +-- vcl/source/opengl/OpenGLHelper.cxx |2 vcl/unx/generic/fontmanager/fontmanager.cxx |2
[Libreoffice-bugs] [Bug 105192] FILEOPEN: DOCX: Header is gone and left section is in all pages
https://bugs.documentfoundation.org/show_bug.cgi?id=105192 Justin Lchanged: What|Removed |Added Priority|medium |low --- Comment #2 from Justin L --- 385.docx is a demonstration of a document that will be very difficult for LO to emulate. Before the "regression" the cover page took up 3 pages. Now it properly takes only one page. This displays the typical problem with continuous section breaks (which LO cannot fully emulate) where headers are set at "random" places and not associated with any page break. In this case, the header used on page2 is from section 4 (probably first defined in section2). In this particular document, the continuous break is followed by a page-break. In that specific case, the import ought to be able to convert this into a section-page-break and thus solve at least one part of the header problem. (I looked into doing this once, and had difficulties.) I will not be treating this one as a regression (reducing severity to low - perhaps it should instead be changed to enhancement). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: accessibility/source
accessibility/source/extended/AccessibleBrowseBoxHeaderCell.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 841f48fcb5431b241eca406209cd67df9dccd9ec Author: Arnaud VersiniDate: Sun Dec 18 15:48:45 2016 +0100 accessibility: prevent possible deadlock Change-Id: I1dc409644ed2e2bdd0cd38c8343c4ada1af7127b Reviewed-on: https://gerrit.libreoffice.org/32137 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/accessibility/source/extended/AccessibleBrowseBoxHeaderCell.cxx b/accessibility/source/extended/AccessibleBrowseBoxHeaderCell.cxx index e9fc495..2f70633 100644 --- a/accessibility/source/extended/AccessibleBrowseBoxHeaderCell.cxx +++ b/accessibility/source/extended/AccessibleBrowseBoxHeaderCell.cxx @@ -50,7 +50,8 @@ AccessibleBrowseBoxHeaderCell::AccessibleBrowseBoxHeaderCell(sal_Int32 _nColumnR */ ::utl::AccessibleStateSetHelper* AccessibleBrowseBoxHeaderCell::implCreateStateSetHelper() { -::osl::MutexGuard aGuard( getMutex() ); +SolarMethodGuard aGuard( getMutex() ); + ::utl::AccessibleStateSetHelper* pStateSetHelper = new ::utl::AccessibleStateSetHelper; @@ -60,7 +61,6 @@ AccessibleBrowseBoxHeaderCell::AccessibleBrowseBoxHeaderCell(sal_Int32 _nColumnR if( implIsShowing() ) pStateSetHelper->AddState( AccessibleStateType::SHOWING ); -SolarMutexGuard aSolarGuard; mpBrowseBox->FillAccessibleStateSet( *pStateSetHelper, getType() ); pStateSetHelper->AddState( AccessibleStateType::VISIBLE ); pStateSetHelper->AddState( AccessibleStateType::FOCUSABLE ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sw/qa sw/source
sw/qa/extras/uiwriter/data/tdf104814.docx |binary sw/qa/extras/uiwriter/uiwriter.cxx| 14 ++ sw/source/core/doc/DocumentRedlineManager.cxx |4 3 files changed, 18 insertions(+) New commits: commit 5b5f351785670e7310e0c074d8b96f2538cf0f2f Author: Noel GrandinDate: Tue Dec 20 15:57:43 2016 +0200 tdf#104814 Writer: accepting change tracking changes get stuck Reviewed-on: https://gerrit.libreoffice.org/32273 Tested-by: Jenkins Reviewed-by: Noel Grandin (cherry picked from commit b7b5c23e6979205a662d857bc1c83270fb4a43ec) Reviewed-on: https://gerrit.libreoffice.org/32276 Change-Id: Ie8e0919b53c0b21f480b62eec7c394554757a061 Reviewed-on: https://gerrit.libreoffice.org/32887 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sw/qa/extras/uiwriter/data/tdf104814.docx b/sw/qa/extras/uiwriter/data/tdf104814.docx new file mode 100644 index 000..1f1c524 Binary files /dev/null and b/sw/qa/extras/uiwriter/data/tdf104814.docx differ diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx b/sw/qa/extras/uiwriter/uiwriter.cxx index 5dcb81e..bbd1670 100644 --- a/sw/qa/extras/uiwriter/uiwriter.cxx +++ b/sw/qa/extras/uiwriter/uiwriter.cxx @@ -200,6 +200,7 @@ public: void testTdf84695(); void testTdf84695NormalChar(); void testTdf78727(); +void testTdf104814(); CPPUNIT_TEST_SUITE(SwUiWriterTest); CPPUNIT_TEST(testReplaceForward); @@ -302,6 +303,7 @@ public: CPPUNIT_TEST(testTdf84695); CPPUNIT_TEST(testTdf84695NormalChar); CPPUNIT_TEST(testTdf78727); +CPPUNIT_TEST(testTdf104814); CPPUNIT_TEST_SUITE_END(); private: @@ -3716,6 +3718,18 @@ void SwUiWriterTest::testTdf78727() CPPUNIT_ASSERT(SwTextBoxHelper::getCount(pPage, aSet) > 1); } +// accepting change tracking gets stuck on change +void SwUiWriterTest::testTdf104814() +{ +SwDoc* const pDoc1(createDoc("tdf104814.docx")); + +SwEditShell* const pEditShell(pDoc1->GetEditShell()); + +// accept all redlines +while(pEditShell->GetRedlineCount()) +pEditShell->AcceptRedline(0); +} + CPPUNIT_TEST_SUITE_REGISTRATION(SwUiWriterTest); CPPUNIT_PLUGIN_IMPLEMENT(); diff --git a/sw/source/core/doc/DocumentRedlineManager.cxx b/sw/source/core/doc/DocumentRedlineManager.cxx index 99e9fcb..3841491 100644 --- a/sw/source/core/doc/DocumentRedlineManager.cxx +++ b/sw/source/core/doc/DocumentRedlineManager.cxx @@ -274,6 +274,10 @@ namespace rArr.DeleteAndDestroy( rPos-- ); break; +case nsRedlineType_t::REDLINE_PARAGRAPH_FORMAT: +rArr.DeleteAndDestroy( rPos-- ); +break; + default: bRet = false; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 105201] Crash When Click "Insert Snap Point / Line -> Cancel"
https://bugs.documentfoundation.org/show_bug.cgi?id=105201 Kevin Suochanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Kevin Suo --- Do not reproduce with the version I build from source commit 4434b0029009d6d0327eaca1ff22a0c39711291d. Mark as WORKSFORME. There must be something wrong with the bibisect repo. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105200] LibO 5.2.4 installation aborted and can' t even uninstall LibO 4.4.7
https://bugs.documentfoundation.org/show_bug.cgi?id=105200 --- Comment #9 from tommy27--- nothing, I was just trying to asnwer to the issue about the missing items you cited in your previos post. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105101] Firebird: Division of Decimal and Integer gives wrong values
https://bugs.documentfoundation.org/show_bug.cgi?id=105101 Tamas Bunthchanged: What|Removed |Added Assignee|libreoffice-b...@lists.free |btom...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/sal sal/inc sal/osl sal/util
include/sal/detail/log.h |1 - include/sal/log.hxx | 24 +--- sal/inc/misc.hxx |2 +- sal/osl/all/log.cxx | 29 - sal/osl/unx/backtraceapi.cxx |2 +- sal/osl/w32/backtrace.cxx|6 +++--- sal/util/sal.map |5 + 7 files changed, 51 insertions(+), 18 deletions(-) New commits: commit 56d071c10ca8016848f1f059aa3eb197fe928844 Author: Noel GrandinDate: Thu Dec 8 11:22:37 2016 +0200 rename SAL_DEBUG_TRACE to SAL_DEBUG_BACKTRACE since "trace" is such a generic term, this makes it easier to actually find the feature when you need it. And add feature to limit stack depth of the reported backtrace. Change-Id: Iab3e4ceb2e8480e7b5e2b920eb6c5d7631e21c43 Reviewed-on: https://gerrit.libreoffice.org/31752 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/include/sal/detail/log.h b/include/sal/detail/log.h index ab97185..11ece36 100644 --- a/include/sal/detail/log.h +++ b/include/sal/detail/log.h @@ -52,7 +52,6 @@ extern "C" { enum sal_detail_LogLevel { SAL_DETAIL_LOG_LEVEL_INFO, SAL_DETAIL_LOG_LEVEL_WARN, -SAL_DETAIL_LOG_LEVEL_DEBUG_TRACE = SAL_MAX_ENUM - 1, SAL_DETAIL_LOG_LEVEL_DEBUG = SAL_MAX_ENUM }; diff --git a/include/sal/log.hxx b/include/sal/log.hxx index 8b4ef0a..4438ec5 100644 --- a/include/sal/log.hxx +++ b/include/sal/log.hxx @@ -30,6 +30,10 @@ extern "C" SAL_DLLPUBLIC void SAL_CALL sal_detail_log( enum sal_detail_LogLevel level, char const * area, char const * where, char const * message); +extern "C" SAL_DLLPUBLIC void SAL_CALL sal_detail_log_backtrace( +enum sal_detail_LogLevel level, char const * area, char const * where, +char const * message, int maxNoStackFramesToDisplay); + namespace sal { namespace detail { inline void SAL_CALL log( @@ -343,9 +347,23 @@ inline char const * unwrapStream(SAL_UNUSED_PARAMETER StreamIgnore const &) { See @ref sal_log "basic logging functionality" for details. */ -#define SAL_DEBUG_TRACE(stream) \ -SAL_DETAIL_LOG_STREAM( \ -SAL_LOG_TRUE, ::SAL_DETAIL_LOG_LEVEL_DEBUG_TRACE, NULL, NULL, stream) +#define SAL_DEBUG_BACKTRACE(stream, maxNoStackFramesToDisplay) \ +do { \ +if (sizeof ::sal::detail::getResult(::sal::detail::StreamStart() << stream) == 1) \ +{ \ +::sal_detail_log_backtrace( \ +::SAL_DETAIL_LOG_LEVEL_DEBUG, NULL, NULL, \ +::sal::detail::unwrapStream( \ +::sal::detail::StreamStart() << stream)); \ +} else { \ +::std::ostringstream sal_detail_stream; \ +sal_detail_stream << stream; \ +::sal::detail::log( \ +::SAL_DETAIL_LOG_LEVEL_DEBUG, NULL, NULL, sal_detail_stream); \ +} \ +} while (false) + + #endif diff --git a/sal/inc/misc.hxx b/sal/inc/misc.hxx index b93868e..440c00c 100644 --- a/sal/inc/misc.hxx +++ b/sal/inc/misc.hxx @@ -12,7 +12,7 @@ #include /// Build a debugging backtrace from current PC location. -rtl_uString *osl_backtraceAsString(void); +rtl_uString *osl_backtraceAsString(int maxNoStackFramesToDisplay); #endif // INCLUDED_SAL_INC_INTERNAL_MISC_H diff --git a/sal/osl/all/log.cxx b/sal/osl/all/log.cxx index 23f45cd..7245a51 100644 --- a/sal/osl/all/log.cxx +++ b/sal/osl/all/log.cxx @@ -68,7 +68,6 @@ char const * toString(sal_detail_LogLevel level) { case SAL_DETAIL_LOG_LEVEL_WARN: return "warn"; case SAL_DETAIL_LOG_LEVEL_DEBUG: -case SAL_DETAIL_LOG_LEVEL_DEBUG_TRACE: return "debug"; default: assert(false); // this cannot happen @@ -188,8 +187,7 @@ void maybeOutputTimestamp(std::ostringstream ) { #endif bool isDebug(sal_detail_LogLevel level) { -return level == SAL_DETAIL_LOG_LEVEL_DEBUG || -level == SAL_DETAIL_LOG_LEVEL_DEBUG_TRACE; +return level == SAL_DETAIL_LOG_LEVEL_DEBUG; } bool report(sal_detail_LogLevel level, char const * area) { @@ -298,10 +296,6 @@ void log( } s << message; -if (level == SAL_DETAIL_LOG_LEVEL_DEBUG_TRACE) { -s << " at:\n"; -s << OUString(osl_backtraceAsString(), SAL_NO_ACQUIRE); -} s << '\n'; #if defined ANDROID @@ -314,7 +308,6 @@ void log( android_log_level = ANDROID_LOG_WARN; break; case SAL_DETAIL_LOG_LEVEL_DEBUG: -case SAL_DETAIL_LOG_LEVEL_DEBUG_TRACE: android_log_level = ANDROID_LOG_DEBUG; break; default: @@ -336,7 +329,6 @@ void log( prio = LOG_WARNING; break; case SAL_DETAIL_LOG_LEVEL_DEBUG: -case SAL_DETAIL_LOG_LEVEL_DEBUG_TRACE: prio = LOG_DEBUG; break; default: @@ -359,6 +351,16 @@ void log( #endif } +void log_backtrace( +sal_detail_LogLevel level, char const * area,
[Libreoffice-commits] core.git: framework/source include/svl sc/source svl/source vcl/inc vcl/source vcl/unx
framework/source/uiconfiguration/ImageList.cxx | 24 --- framework/source/uiconfiguration/ImageList.hxx |2 include/svl/languageoptions.hxx|1 sc/source/filter/inc/biffcodec.hxx | 21 -- sc/source/filter/oox/biffcodec.cxx | 47 -- svl/source/config/languageoptions.cxx |6 - vcl/inc/unx/fc_fontoptions.hxx |4 - vcl/source/gdi/impvect.cxx | 83 - vcl/source/gdi/impvect.hxx |1 vcl/unx/generic/print/psputil.cxx | 42 vcl/unx/generic/print/psputil.hxx | 13 --- 11 files changed, 244 deletions(-) New commits: commit 014b9ac2e4ec22a1eed2fde806edd7a840035a45 Author: Noel GrandinDate: Mon Jan 9 10:35:25 2017 +0200 loplugin:unusedmethods Change-Id: Ibe11923601760ded53a277c48631e4893606b2d6 Reviewed-on: https://gerrit.libreoffice.org/32875 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/framework/source/uiconfiguration/ImageList.cxx b/framework/source/uiconfiguration/ImageList.cxx index 389c016..cdceb4b 100644 --- a/framework/source/uiconfiguration/ImageList.cxx +++ b/framework/source/uiconfiguration/ImageList.cxx @@ -229,11 +229,6 @@ sal_uInt16 ImageList::GetImagePos( sal_uInt16 nId ) const return IMAGELIST_IMAGE_NOTFOUND; } -bool ImageList::HasImageForId( sal_uInt16 nId ) const -{ -return GetImagePos( nId ) != IMAGELIST_IMAGE_NOTFOUND; -} - sal_uInt16 ImageList::GetImagePos( const OUString& rImageName ) const { if( mpImplData && !rImageName.isEmpty() ) @@ -281,25 +276,6 @@ void ImageList::GetImageNames( std::vector< OUString >& rNames ) const } } -Size ImageList::GetImageSize() const -{ -Size aRet; - -if( mpImplData ) -{ -aRet = mpImplData->maImageSize; - -// force load of 1st image to see - uncommon case. -if( aRet.Width() == 0 && aRet.Height() == 0 && -!mpImplData->maImages.empty() ) -{ -Image aTmp = GetImage( mpImplData->maImages[ 0 ]->mnId ); -aRet = mpImplData->maImageSize = aTmp.GetSizePixel(); -} -} -return aRet; -} - bool ImageList::operator==( const ImageList& rImageList ) const { bool bRet = false; diff --git a/framework/source/uiconfiguration/ImageList.hxx b/framework/source/uiconfiguration/ImageList.hxx index 426a626..d6db88c 100644 --- a/framework/source/uiconfiguration/ImageList.hxx +++ b/framework/source/uiconfiguration/ImageList.hxx @@ -31,7 +31,6 @@ public: const std::vector< OUString > ); BitmapExGetAsHorizontalStrip() const; sal_uInt16 GetImageCount() const; -SizeGetImageSize() const; voidAddImage( const OUString& rImageName, const Image& rImage ); @@ -43,7 +42,6 @@ public: Image GetImage( const OUString& rImageName ) const; sal_uInt16 GetImagePos( sal_uInt16 nId ) const; -boolHasImageForId( sal_uInt16 nId ) const; sal_uInt16 GetImagePos( const OUString& rImageName ) const; sal_uInt16 GetImageId( sal_uInt16 nPos ) const; diff --git a/include/svl/languageoptions.hxx b/include/svl/languageoptions.hxx index f223904..9967080 100644 --- a/include/svl/languageoptions.hxx +++ b/include/svl/languageoptions.hxx @@ -128,7 +128,6 @@ public: LanguageTypeGetWin16SystemLanguage() const; -boolisCTLKeyboardLayoutInstalled() const; boolisCJKKeyboardLayoutInstalled() const; }; diff --git a/sc/source/filter/inc/biffcodec.hxx b/sc/source/filter/inc/biffcodec.hxx index 959fed5..fed33b8 100644 --- a/sc/source/filter/inc/biffcodec.hxx +++ b/sc/source/filter/inc/biffcodec.hxx @@ -50,13 +50,6 @@ private: virtual css::uno::Sequence< css::beans::NamedValue > implVerifyPassword( const OUString& rPassword ) = 0; virtual bool implVerifyEncryptionData( const css::uno::Sequence< css::beans::NamedValue >& rEncryptionData ) = 0; -/** Implementation of decryption of a memory block. */ -virtual voidimplDecode( -sal_uInt8* pnDestData, -const sal_uInt8* pnSrcData, -sal_Int64 nStreamPos, -sal_uInt16 nBytes ) = 0; - private: boolmbValid;/// True = decoder is correctly initialized. }; @@ -74,13 +67,6 @@ private: virtual css::uno::Sequence< css::beans::NamedValue > implVerifyPassword( const OUString& rPassword ) override; virtual bool implVerifyEncryptionData( const css::uno::Sequence< css::beans::NamedValue >& rEncryptionData ) override; -/** Implementation of decryption of a memory block. */ -virtual voidimplDecode( -
[Libreoffice-commits] core.git: chart2/source sw/inc sw/source vcl/inc vcl/source vcl/unx xmlsecurity/inc xmlsecurity/source
chart2/source/model/template/BubbleChartTypeTemplate.cxx |2 - chart2/source/model/template/BubbleDataInterpreter.cxx |5 +--- chart2/source/model/template/BubbleDataInterpreter.hxx |3 -- chart2/source/model/template/ChartTypeTemplate.cxx |2 - chart2/source/model/template/ColumnLineChartTypeTemplate.cxx |2 - chart2/source/model/template/ColumnLineDataInterpreter.cxx |5 +--- chart2/source/model/template/ColumnLineDataInterpreter.hxx |3 -- chart2/source/model/template/DataInterpreter.cxx |4 --- chart2/source/model/template/DataInterpreter.hxx |5 chart2/source/model/template/ScatterChartTypeTemplate.cxx|2 - chart2/source/model/template/StockChartTypeTemplate.cxx |2 - chart2/source/model/template/StockDataInterpreter.cxx|5 +--- chart2/source/model/template/StockDataInterpreter.hxx|3 -- chart2/source/model/template/XYDataInterpreter.cxx |5 +--- chart2/source/model/template/XYDataInterpreter.hxx |2 - sw/inc/unocrsr.hxx | 10 +++-- sw/source/core/unocore/unoobj.cxx|2 - vcl/inc/unx/fontmanager.hxx |1 vcl/inc/unx/glyphcache.hxx |6 - vcl/source/gdi/pdfwriter_impl.hxx| 12 --- vcl/unx/generic/fontmanager/fontmanager.cxx |1 vcl/unx/generic/glyphs/freetype_glyphcache.cxx |1 xmlsecurity/inc/framework/signaturecreatorimpl.hxx |2 - xmlsecurity/inc/framework/signatureengine.hxx|5 xmlsecurity/inc/framework/signatureverifierimpl.hxx |3 -- xmlsecurity/inc/pdfsignaturehelper.hxx |3 -- xmlsecurity/inc/xsecctl.hxx |6 - xmlsecurity/source/framework/signaturecreatorimpl.cxx|8 +++ xmlsecurity/source/framework/signatureengine.cxx |4 +-- xmlsecurity/source/framework/signatureverifierimpl.cxx |8 +++ xmlsecurity/source/helper/documentsignaturemanager.cxx |2 - xmlsecurity/source/helper/pdfsignaturehelper.cxx |3 -- xmlsecurity/source/helper/xsecctl.cxx|1 xmlsecurity/source/helper/xsecsign.cxx |2 - xmlsecurity/source/helper/xsecverify.cxx |2 - 35 files changed, 43 insertions(+), 89 deletions(-) New commits: commit b0229855057ed4d73e73ecd8c501a4564f2237ce Author: Noel GrandinDate: Mon Jan 9 09:22:34 2017 +0200 loplugin:unusedfields Change-Id: I9611511cb3480734dea3c3cbaf0d659071366ad1 Reviewed-on: https://gerrit.libreoffice.org/32873 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/chart2/source/model/template/BubbleChartTypeTemplate.cxx b/chart2/source/model/template/BubbleChartTypeTemplate.cxx index 1d03e50..dfda9be 100644 --- a/chart2/source/model/template/BubbleChartTypeTemplate.cxx +++ b/chart2/source/model/template/BubbleChartTypeTemplate.cxx @@ -206,7 +206,7 @@ Reference< chart2::XDataInterpreter > SAL_CALL BubbleChartTypeTemplate::getDataI throw (uno::RuntimeException, std::exception) { if( ! m_xDataInterpreter.is()) -m_xDataInterpreter.set( new BubbleDataInterpreter( GetComponentContext()) ); +m_xDataInterpreter.set( new BubbleDataInterpreter ); return m_xDataInterpreter; } diff --git a/chart2/source/model/template/BubbleDataInterpreter.cxx b/chart2/source/model/template/BubbleDataInterpreter.cxx index ac29630..76b2028 100644 --- a/chart2/source/model/template/BubbleDataInterpreter.cxx +++ b/chart2/source/model/template/BubbleDataInterpreter.cxx @@ -36,9 +36,8 @@ using ::com::sun::star::uno::Sequence; namespace chart { -BubbleDataInterpreter::BubbleDataInterpreter( -const uno::Reference< uno::XComponentContext > & xContext ) : -DataInterpreter( xContext ) +BubbleDataInterpreter::BubbleDataInterpreter() : +DataInterpreter() { } diff --git a/chart2/source/model/template/BubbleDataInterpreter.hxx b/chart2/source/model/template/BubbleDataInterpreter.hxx index 4f08d05..59ad9a8 100644 --- a/chart2/source/model/template/BubbleDataInterpreter.hxx +++ b/chart2/source/model/template/BubbleDataInterpreter.hxx @@ -27,8 +27,7 @@ namespace chart class BubbleDataInterpreter : public DataInterpreter { public: -explicit BubbleDataInterpreter( -const css::uno::Reference< css::uno::XComponentContext > & xContext ); +explicit BubbleDataInterpreter(); virtual ~BubbleDataInterpreter() override; protected: diff --git a/chart2/source/model/template/ChartTypeTemplate.cxx b/chart2/source/model/template/ChartTypeTemplate.cxx index
[Libreoffice-bugs] [Bug 105205] Page break line in Writer not displayed after adding more then one page break
https://bugs.documentfoundation.org/show_bug.cgi?id=105205 --- Comment #3 from grofaty--- Also tested on LibreOffice 5.2.3.2 on Ubuntu 16.04 steps from Description. It looks like on Windows (and now on Ubuntu) I have also clicked on bottom-right (at the zoom ruler) the "Multi-page view" icon to display pages one next to another. So this should be like (2a) step. LibreOffice installed from "LibreOffice Fresh PPA": https://launchpad.net/~libreoffice == Version: 5.2.3.2 Build ID: 1:5.2.3~rc2-0ubuntu1~xenial1 CPU Threads: 1; OS Version: Linux 4.4; UI Render: default; Locale: sl-SI (en_AU.UTF-8); Calc: group == -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100151] Crash at the end of slideshow or previews in Impress ( in remote desktop session..)
https://bugs.documentfoundation.org/show_bug.cgi?id=100151 --- Comment #37 from Julien Nabet--- Raal: would it be possible you give it a try with a daily build which includes http://cgit.freedesktop.org/libreoffice/core/commit/?id=bce35b8e13b0d82ba54bf3d380f448dad0ee13bb ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100151] Crash at the end of slideshow or previews in Impress ( in remote desktop session..)
https://bugs.documentfoundation.org/show_bug.cgi?id=100151 Commit Notificationchanged: What|Removed |Added Whiteboard||target:5.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100151] Crash at the end of slideshow or previews in Impress ( in remote desktop session..)
https://bugs.documentfoundation.org/show_bug.cgi?id=100151 --- Comment #36 from Commit Notification--- Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bce35b8e13b0d82ba54bf3d380f448dad0ee13bb Related tdf#100151: use disposeAndClear for mpShowWindow (sd) It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/ui/slideshow/slideshowimpl.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit bce35b8e13b0d82ba54bf3d380f448dad0ee13bb Author: Julien NabetDate: Mon Jan 9 18:24:35 2017 +0100 Related tdf#100151: use disposeAndClear for mpShowWindow (sd) See https://bugs.documentfoundation.org/show_bug.cgi?id=100151#c33 Change-Id: I81e483189eacee086b680367148f8dd3ca2d3493 Reviewed-on: https://gerrit.libreoffice.org/32904 Reviewed-by: Julien Nabet Tested-by: Julien Nabet diff --git a/sd/source/ui/slideshow/slideshowimpl.cxx b/sd/source/ui/slideshow/slideshowimpl.cxx index f7402f5..350ca3e 100644 --- a/sd/source/ui/slideshow/slideshowimpl.cxx +++ b/sd/source/ui/slideshow/slideshowimpl.cxx @@ -716,7 +716,7 @@ void SAL_CALL SlideshowImpl::disposing() if( mpShowWindow ) { -mpShowWindow.clear(); +mpShowWindow.disposeAndClear(); } setActiveXToolbarsVisible( true ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: common/MessageQueue.cpp common/MessageQueue.hpp
common/MessageQueue.cpp | 70 - common/MessageQueue.hpp | 90 +--- 2 files changed, 72 insertions(+), 88 deletions(-) New commits: commit 09fe0b689a28b50b5652fda0be46c7e478babdf4 Author: Ashod NakashianDate: Mon Jan 9 13:38:07 2017 -0500 wsd: templatized MessageQueue Change-Id: Ieb6b6c289d8348cafc82041e6e719409cc329edd Reviewed-on: https://gerrit.libreoffice.org/32919 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/common/MessageQueue.cpp b/common/MessageQueue.cpp index d6e1eed..4d26a5a 100644 --- a/common/MessageQueue.cpp +++ b/common/MessageQueue.cpp @@ -19,74 +19,6 @@ using Poco::StringTokenizer; -MessageQueue::~MessageQueue() -{ -clear(); -} - -void MessageQueue::put(const Payload& value) -{ -std::unique_lock lock(_mutex); -put_impl(value); -lock.unlock(); -_cv.notify_one(); -} - -MessageQueue::Payload MessageQueue::get(const unsigned timeoutMs) -{ -std::unique_lock lock(_mutex); - -if (timeoutMs > 0) -{ -if (!_cv.wait_for(lock, std::chrono::milliseconds(timeoutMs), - [this] { return wait_impl(); })) -{ -throw std::runtime_error("Timed out waiting to get queue item."); -} -} -else -{ -_cv.wait(lock, [this] { return wait_impl(); }); -} - -return get_impl(); -} - -void MessageQueue::clear() -{ -std::unique_lock lock(_mutex); -clear_impl(); -} - -void MessageQueue::remove_if(const std::function & pred) -{ -std::unique_lock lock(_mutex); -std::remove_if(_queue.begin(), _queue.end(), pred); -} - -void MessageQueue::put_impl(const Payload& value) -{ -const auto msg = std::string(value.data(), value.size()); -_queue.push_back(value); -} - -bool MessageQueue::wait_impl() const -{ -return _queue.size() > 0; -} - -MessageQueue::Payload MessageQueue::get_impl() -{ -Payload result = _queue.front(); -_queue.erase(_queue.begin()); -return result; -} - -void MessageQueue::clear_impl() -{ -_queue.clear(); -} - void TileQueue::put_impl(const Payload& value) { const auto msg = std::string(value.data(), value.size()); @@ -302,7 +234,7 @@ bool TileQueue::shouldPreferTiles() const return false; } -MessageQueue::Payload TileQueue::get_impl() +TileQueue::Payload TileQueue::get_impl() { LOG_TRC("MessageQueue depth: " << _queue.size()); diff --git a/common/MessageQueue.hpp b/common/MessageQueue.hpp index 6eb07c0..0ae4658 100644 --- a/common/MessageQueue.hpp +++ b/common/MessageQueue.hpp @@ -17,25 +17,34 @@ #include #include -/** Thread-safe message queue (FIFO). -*/ -class MessageQueue +/// Thread-safe message queue (FIFO). +template +class MessageQueueBase { public: +typedef T Payload; -typedef std::vector Payload; - -MessageQueue() +MessageQueueBase() { } -virtual ~MessageQueue(); +virtual ~MessageQueueBase() +{ +clear(); +} -MessageQueue(const MessageQueue&) = delete; -MessageQueue& operator=(const MessageQueue&) = delete; +MessageQueueBase(const MessageQueueBase&) = delete; +MessageQueueBase& operator=(const MessageQueueBase&) = delete; /// Thread safe insert the message. -void put(const Payload& value); +void put(const Payload& value) +{ +std::unique_lock lock(_mutex); +put_impl(value); +lock.unlock(); +_cv.notify_one(); +} + void put(const std::string& value) { put(Payload(value.data(), value.data() + value.size())); @@ -43,22 +52,64 @@ public: /// Thread safe obtaining of the message. /// timeoutMs can be 0 to signify infinity. -Payload get(const unsigned timeoutMs = 0); +Payload get(const unsigned timeoutMs = 0) +{ +std::unique_lock lock(_mutex); + +if (timeoutMs > 0) +{ +if (!_cv.wait_for(lock, std::chrono::milliseconds(timeoutMs), +[this] { return wait_impl(); })) +{ +throw std::runtime_error("Timed out waiting to get queue item."); +} +} +else +{ +_cv.wait(lock, [this] { return wait_impl(); }); +} + +return get_impl(); +} + /// Thread safe removal of all the pending messages. -void clear(); +void clear() +{ +std::unique_lock lock(_mutex); +clear_impl(); +} /// Thread safe remove_if. -void remove_if(const std::function & pred); +void remove_if(const std::function & pred) +{ +std::unique_lock lock(_mutex); +std::remove_if(_queue.begin(), _queue.end(), pred); +} protected: -virtual void put_impl(const Payload& value); +virtual void
[Libreoffice-commits] online.git: common/Log.cpp
common/Log.cpp | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) New commits: commit 89bd85fbba9855a607619bbda279c14da3d9cc5f Author: Ashod NakashianDate: Mon Jan 9 12:33:01 2017 -0500 wsd: put_time is not supported by gcc4.8 Change-Id: Ib3b6a115ba669051474e327944cb4677575d15f3 Reviewed-on: https://gerrit.libreoffice.org/32917 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/common/Log.cpp b/common/Log.cpp index 3141abd..380b0ed 100644 --- a/common/Log.cpp +++ b/common/Log.cpp @@ -158,9 +158,22 @@ namespace Log const std::time_t t = std::time(nullptr); oss.str(""); oss.clear(); -oss << "Initializing " << name << ". Local time: " << std::put_time(std::localtime(), "%c %Z") -<< ". UTC: " << std::put_time(std::gmtime(), "%c %Z") -<< ". Log level is [" << logger.getLevel() << "]."; + +oss << "Initializing " << name << "."; + +// TODO: replace with std::put_time when we move to gcc 5+. +char buf[32]; +if (strftime(buf, sizeof(buf), "%a %F %T%z", std::localtime()) > 0) +{ +oss << " Local time: " << buf << "."; +} + +if (strftime(buf, sizeof(buf), "%a %F %T%z", std::gmtime()) > 0) +{ +oss << " UTC time: " << buf << "."; +} + +oss << " Log level is [" << logger.getLevel() << "]."; info(oss.str()); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/layer/tile/CalcTileLayer.js|2 +- loleaflet/src/layer/tile/ImpressTileLayer.js |2 +- loleaflet/src/layer/tile/WriterTileLayer.js |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) New commits: commit f41c4c6e83764027aae83cf5ab77a722279c Author: Ashod NakashianDate: Mon Jan 9 13:06:13 2017 -0500 loleaflet: on invalidation check the part before intersection Shortcircuiting when the part doesn't match is much faster than intersecting rects first. Change-Id: I9038eb5cafd141e75e8b18a5308b30216e4c9653 Reviewed-on: https://gerrit.libreoffice.org/32918 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loleaflet/src/layer/tile/CalcTileLayer.js b/loleaflet/src/layer/tile/CalcTileLayer.js index 5d6e6e4..cd4ed60 100644 --- a/loleaflet/src/layer/tile/CalcTileLayer.js +++ b/loleaflet/src/layer/tile/CalcTileLayer.js @@ -50,7 +50,7 @@ L.CalcTileLayer = L.TileLayer.extend({ var tileTopLeft = this._coordsToTwips(coords); var tileBottomRight = new L.Point(this._tileWidthTwips, this._tileHeightTwips); var bounds = new L.Bounds(tileTopLeft, tileTopLeft.add(tileBottomRight)); - if (invalidBounds.intersects(bounds) && coords.part === command.part) { + if (coords.part === command.part && invalidBounds.intersects(bounds)) { if (this._tiles[key]._invalidCount) { this._tiles[key]._invalidCount += 1; } diff --git a/loleaflet/src/layer/tile/ImpressTileLayer.js b/loleaflet/src/layer/tile/ImpressTileLayer.js index da0166c..3326fa2 100644 --- a/loleaflet/src/layer/tile/ImpressTileLayer.js +++ b/loleaflet/src/layer/tile/ImpressTileLayer.js @@ -34,7 +34,7 @@ L.ImpressTileLayer = L.TileLayer.extend({ var tileTopLeft = this._coordsToTwips(coords); var tileBottomRight = new L.Point(this._tileWidthTwips, this._tileHeightTwips); var bounds = new L.Bounds(tileTopLeft, tileTopLeft.add(tileBottomRight)); - if (invalidBounds.intersects(bounds) && coords.part === command.part) { + if (coords.part === command.part && invalidBounds.intersects(bounds)) { if (this._tiles[key]._invalidCount) { this._tiles[key]._invalidCount += 1; } diff --git a/loleaflet/src/layer/tile/WriterTileLayer.js b/loleaflet/src/layer/tile/WriterTileLayer.js index 9402f6c..0e546d0 100644 --- a/loleaflet/src/layer/tile/WriterTileLayer.js +++ b/loleaflet/src/layer/tile/WriterTileLayer.js @@ -33,7 +33,7 @@ L.WriterTileLayer = L.TileLayer.extend({ var tileTopLeft = this._coordsToTwips(coords); var tileBottomRight = new L.Point(this._tileWidthTwips, this._tileHeightTwips); var bounds = new L.Bounds(tileTopLeft, tileTopLeft.add(tileBottomRight)); - if (invalidBounds.intersects(bounds) && coords.part === command.part) { + if (coords.part === command.part && invalidBounds.intersects(bounds)) { if (this._tiles[key]._invalidCount) { this._tiles[key]._invalidCount += 1; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 105229] Crash when hitting Quit in Safe Mode dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=105229 Aron Budeachanged: What|Removed |Added Summary|Crash when hitting Quit |Crash when hitting Quit in ||Safe Mode dialog -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105229] Crash when hitting Quit
https://bugs.documentfoundation.org/show_bug.cgi?id=105229 Aron Budeachanged: What|Removed |Added CC||armin.le.gr...@me.com, ||s.mehrbr...@gmail.com Crash report or||["ToolBox::GetDefaultImageS crash signature||ize(ToolBoxButtonSize)"] -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105229] New: Crash when hitting Quit
https://bugs.documentfoundation.org/show_bug.cgi?id=105229 Bug ID: 105229 Summary: Crash when hitting Quit Product: LibreOffice Version: 5.3.0.1 rc Hardware: All OS: All Status: UNCONFIRMED Severity: major Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu 1. Restart LibreOffice in Safe Mode. 2. In the Safe Mode dialog, hit Quit. => Crash. Reproduced with 5.3.0.1 and 5.4 daily build / Windows 7. Crash report in 5.3.0.1: http://crashreport.libreoffice.org/stats/crash_details/c491752e-bb7e-463f-a283-1b1deb0b2283 Version: 5.4.0.0.alpha0+ Build ID: 215cbfb460326010737433c2020638e9388a88a4 CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-01-02_23:58:32 Locale: hu-HU (hu_HU); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104992] Unintended information disclosure via Safe Mode
https://bugs.documentfoundation.org/show_bug.cgi?id=104992 Aron Budeachanged: What|Removed |Added Keywords||security CC||armin.le.gr...@me.com, ||s.mehrbr...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105228] Tools Options check box can not be displyed in Chinese ( traditional) UI
https://bugs.documentfoundation.org/show_bug.cgi?id=105228 odinatlaschanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96672] Outgoing mail server password in clear text inside the registrymodifications.xcu file
https://bugs.documentfoundation.org/show_bug.cgi?id=96672 Aron Budeachanged: What|Removed |Added Keywords||security -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105200] LibO 5.2.4 installation aborted and can' t even uninstall LibO 4.4.7
https://bugs.documentfoundation.org/show_bug.cgi?id=105200 --- Comment #8 from Gregor--- (In reply to tommy27 from comment #7) > some dialogs and menu item position have been changed in recent LibO > versions. > probably those items are not in the same place as before but should be still > available elsewhere in the GUI. So what does that have to do with the inability to install 5.2.4.2? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96000] [META] Spell Checking bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=96000 Aron Budeachanged: What|Removed |Added Depends on||94184 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=94184 [Bug 94184] Automatic spell checking makes Writer unresponsive for ~2min -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94184] Automatic spell checking makes Writer unresponsive for ~2min
https://bugs.documentfoundation.org/show_bug.cgi?id=94184 Aron Budeachanged: What|Removed |Added CC||ba...@caesar.elte.hu Blocks||96000 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=96000 [Bug 96000] [META] Spell Checking bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84367] OLE Object: "Show as Icon" showing garbled charactors
https://bugs.documentfoundation.org/show_bug.cgi?id=84367 Kevin Suochanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Kevin Suo --- Marking as RESOLEVD WORKSFORME per feedback in http://www.libreofficechina.org/thread-378-1-1.html -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - cui/source
cui/source/tabpages/tparea.cxx |3 --- 1 file changed, 3 deletions(-) New commits: commit 5dbeccbe96f1cace62665523e49b5e693839d265 Author: Tomaž VajngerlDate: Mon Jan 9 22:59:29 2017 +0100 tdf#103225 revert setting of a fixed size for the dialog Setting fixed size of a dialog causes a mess with HiDPI and could also cause problems with certain languages because the translated strings could streach the dialog size. It is better to let the dialog calculate its ideal size depending on the content, which in some cases is not ideal but at least it shouldn't create a mess. The decision to revert this was done in design hangout on 2016-12-22. Change-Id: I0ad1e38e1625cdbbf65b846118995bd5d3ebb47e Reviewed-on: https://gerrit.libreoffice.org/32912 Reviewed-by: Tomaž Vajngerl Tested-by: Tomaž Vajngerl (cherry picked from commit 62a94dcf0c750e335d6ce272d8a5df9813910d5a) Reviewed-on: https://gerrit.libreoffice.org/32913 Reviewed-by: Adolfo Jayme Barrientos Tested-by: Adolfo Jayme Barrientos diff --git a/cui/source/tabpages/tparea.cxx b/cui/source/tabpages/tparea.cxx index 22bb3c9..9972ca5 100644 --- a/cui/source/tabpages/tparea.cxx +++ b/cui/source/tabpages/tparea.cxx @@ -125,9 +125,6 @@ SvxAreaTabPage::SvxAreaTabPage( vcl::Window* pParent, const SfxItemSet& rInAttrs m_pBtnPattern->SetClickHdl(aLink); SetExchangeSupport(); - -m_pFillTab->set_width_request(750); -m_pFillTab->set_height_request(550); } SvxAreaTabPage::~SvxAreaTabPage() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 103225] Area dialog is too large
https://bugs.documentfoundation.org/show_bug.cgi?id=103225 Commit Notificationchanged: What|Removed |Added Whiteboard|target:5.4.0|target:5.4.0 target:5.3.0.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103225] Area dialog is too large
https://bugs.documentfoundation.org/show_bug.cgi?id=103225 --- Comment #12 from Commit Notification--- Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5dbeccbe96f1cace62665523e49b5e693839d265=libreoffice-5-3 tdf#103225 revert setting of a fixed size for the dialog It will be available in 5.3.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77711] FILESAVE: reopening saved rtf returns file format error dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=77711 Aron Budeachanged: What|Removed |Added Status|NEW |RESOLVED CC||ba...@caesar.elte.hu Resolution|--- |WORKSFORME --- Comment #6 from Aron Budea --- No error dialog upon opening resaved RTF in 5.2.4.2 and 5.3.0.1 / Windows 7, closing as WFM. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81234] [META] RTF filter issues
https://bugs.documentfoundation.org/show_bug.cgi?id=81234 Bug 81234 depends on bug 77711, which changed state. Bug 77711 Summary: FILESAVE: reopening saved rtf returns file format error dialog https://bugs.documentfoundation.org/show_bug.cgi?id=77711 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103690] macOS: libreoffice crash on startup, VCL thread mutex condition
https://bugs.documentfoundation.org/show_bug.cgi?id=103690 --- Comment #39 from bikerman...@gmail.com --- Alex How can this be a duplicate? I can reproduce the problem and the solution every time. I'm running MACOS X 10.12.2 and LibreOffice 5.2.4 (Newly Released). These are the steps I go through every time and if I bring it up this way it works. Closing the Terminal.app, under the Utilities folder, will terminate the entire "LIbreOffice" program, but The Terminal Window remains open. I don't know if I'm explaining this so anyone can understand it, because I'm not (by profession), a programmer. However, I can see somewhere in the compiled version of "soffice" Exec file, the script is telling the Terminal.app to exec first, THEN to execute LIbreOffice. Here's how I now have to use this application: 1. I execute "soffice" from the MacOS folder in the Contents folder 2. I Wait for the Terminal.app to execute and bring up the Terminal Window 3. I keep the Terminal.app running paying attention to the messages printed in the window. 4. After a short time Maybe 5 second) LibreOffice comes up "Normally" 5. Using the "Quit LIbreOffice" on the menu file, I can see the Terminal.app being told to exit and LibreOffice ends. If the Terminal.app is not running, LibreOffice will crash every time. Also, if you try and execute LibreOffice in the Applications Folder, it will crash every time. ADDITIONAL INFORMATION: Below is what I saw on the "Terminal" Window as LibreOffice executes from the MAC OS directory using the soffice Exec file. "Last login: Sat Jan 7 13:12:59 on console -bash: PATH: command not found -bash: PATH: command not found /Applications/LibreOffice.app/Contents/MacOS/soffice ; exit; Macintosh:~ millersranch$ /Applications/LibreOffice.app/Contents/MacOS/soffice ; exit;" Below are the results returned and printed to the Terminal window screen after you've pressed "Quit LibreOffice" in the application. logout Saving session... ...copying shared history... ...saving history...truncating history files... ...completed. Deleting expired sessions...none found. [Process completed] Please NOTE: After the [Process completed] statement, the Terminal App stays open. You have to close it manually. This Bug reports something about the "User Profile" and something about a "Switch" being set to "ON". I don't know where this switch is and I have deleted previous User profiles from the LibreOffice/4/user directory. If there is a "Patch" for this, I don't know where to find it. Seeing how this Bug is also happening under MacOS 10.12.2 and continues under LibreOffice 5.2.4.1, tells me this can't be the same problem as reported here. I don't need to change a "Switch" or my "User Profile" to use the application as described above. This problem appears to be a PATH statement problem as indicated by the Terminal Results: -bash: PATH: command not found -bash: PATH: command not found I can use the application this way without changing any of the things mentioned in this Bug report. I don't have any stack trace/backtrace software to print out the errors or how the program is executing. I just know it works every time when I apply the procedure above. I will continue to use it this way, until someone figures out why the "LibreOffice.app doesn't work from the Applications directory. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105228] Tools Options check box can not be displyed in Chinese ( traditional) UI
https://bugs.documentfoundation.org/show_bug.cgi?id=105228 --- Comment #1 from odinatlas--- Created attachment 130295 --> https://bugs.documentfoundation.org/attachment.cgi?id=130295=edit Tools Options check box can not be displyed in Chinese (traditional) UI -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105228] New: Tools Options check box can not be displyed in Chinese ( traditional) UI
https://bugs.documentfoundation.org/show_bug.cgi?id=105228 Bug ID: 105228 Summary: Tools Options check box can not be displyed in Chinese (traditional) UI Product: LibreOffice Version: 5.4.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: odinat...@gmail.com Description: Tools Options check box can not be displyed in Chinese (traditional) UI Steps to Reproduce: 1.Set UI to Chinese (traditional) 2.Tools /Options 3.Check box can not be displyed.(View OpenCL etc.) Actual Results: Check box can not be displyed.(View OpenCL etc.) Expected Results: Check box should not be displyed well. Reproducible: Always User Profile Reset: No Additional Info: Thank you very much. User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67829] Misplaced open Drop-down boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=67829 --- Comment #8 from tommy27--- still no repro under Win8.1 x64 using LibO 5.2.4.2 confirmations about this issue only came from Mac and Linux users. I wonder if they still can confirm it with latest LibO releases. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105200] LibO 5.2.4 installation aborted and can' t even uninstall LibO 4.4.7
https://bugs.documentfoundation.org/show_bug.cgi?id=105200 --- Comment #7 from tommy27--- some dialogs and menu item position have been changed in recent LibO versions. probably those items are not in the same place as before but should be still available elsewhere in the GUI. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105225] Color palette cannot be chosen in various places
https://bugs.documentfoundation.org/show_bug.cgi?id=105225 Regina Henschelchanged: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #1 from Regina Henschel --- And another one: Tools > Options > Charts > Default Colors -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98707] Calc crashes when attempting to reformat a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=98707 Aron Budeachanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #10 from Aron Budea --- Michael, does this error still occur in a current debug master build? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104742] [META] Bugs that involve networks
https://bugs.documentfoundation.org/show_bug.cgi?id=104742 Aron Budeachanged: What|Removed |Added Depends on||94749 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=94749 [Bug 94749] Opening the file in the local network -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94749] Opening the file in the local network
https://bugs.documentfoundation.org/show_bug.cgi?id=94749 Aron Budeachanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||ba...@caesar.elte.hu Blocks||104742 Ever confirmed|0 |1 --- Comment #5 from Aron Budea --- Could you try if this issue still occurs with a current version? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104742 [Bug 104742] [META] Bugs that involve networks -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/graph.hxx|1 - vcl/source/gdi/graph.cxx |4 2 files changed, 5 deletions(-) New commits: commit 4434b0029009d6d0327eaca1ff22a0c39711291d Author: Caolán McNamaraDate: Mon Jan 9 13:10:37 2017 + defaults are good enough Change-Id: I4520e00b8c48938a4ff1ed89e3c61948d886972c Reviewed-on: https://gerrit.libreoffice.org/32889 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/include/vcl/graph.hxx b/include/vcl/graph.hxx index 8191405..3869db5 100644 --- a/include/vcl/graph.hxx +++ b/include/vcl/graph.hxx @@ -121,7 +121,6 @@ public: Graphic( const Animation& rAnimation ); Graphic( const GDIMetaFile& rMtf ); Graphic( const css::uno::Reference< css::graphic::XGraphic >& rxGraphic ); - ~Graphic(); Graphic&operator=( const Graphic& rGraphic ); Graphic&operator=( Graphic&& rGraphic ); diff --git a/vcl/source/gdi/graph.cxx b/vcl/source/gdi/graph.cxx index 1583212f..cd10764 100644 --- a/vcl/source/gdi/graph.cxx +++ b/vcl/source/gdi/graph.cxx @@ -244,10 +244,6 @@ Graphic::Graphic( const css::uno::Reference< css::graphic::XGraphic >& rxGraphic mxImpGraphic.reset(new ImpGraphic); } -Graphic::~Graphic() -{ -} - void Graphic::ImplTestRefCount() { if (!mxImpGraphic.unique()) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 105199] Inserting images into Photo Gallery crashes when image file name contains hash (#)
https://bugs.documentfoundation.org/show_bug.cgi?id=105199 Aron Budeachanged: What|Removed |Added CC||sberg...@redhat.com --- Comment #4 from Aron Budea --- This issue started at the commit referenced below. Adding Cc: to Stephan Bergmann, please take a look. https://cgit.freedesktop.org/libreoffice/core/commit/?id=d3248d1fd83cca67a11dd593c124694382bf5f34 author Stephan Bergmann 2015-11-04 07:39:35 (GMT) committer Stephan Bergmann 2015-11-04 09:19:59 (GMT) "Handle URLs with query or fragment (or containing NUL chars)" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105199] Inserting images into Photo Gallery crashes when image file name contains hash (#)
https://bugs.documentfoundation.org/show_bug.cgi?id=105199 Aron Budeachanged: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected Version|5.2.3.2 rc |5.1.0.3 release --- Comment #3 from Aron Budea --- 5e8294b0ca5f96b0d65ba416a20547e15d14f38e is the first bad commit commit 5e8294b0ca5f96b0d65ba416a20547e15d14f38e Author: Norbert Thiebaud Date: Wed Nov 4 12:30:39 2015 -0800 source sha:d3248d1fd83cca67a11dd593c124694382bf5f34 # bad: [05d11632892a322664fb52bac90b2598b7fb7544] source sha:5616d22b57a9a5e57d545e912e029162a230829b # good: [c1efd324c6ad448ac9edb030dc9738b9e6899e4d] source sha:ab465b90f6c6da5595393a0ba73f33a1e71a2b65 git bisect start '05d11632892a322664fb52bac90b2598b7fb7544' 'oldest' # good: [97526ab777da7e58ce283c05498262ecdd4d6f7f] source sha:4ea70f87f7a2b61eda6e5ab1f48debf6fcfadc1f git bisect good 97526ab777da7e58ce283c05498262ecdd4d6f7f # good: [86fee7ded76d9c2756ccab6aef160a2d7fab0ab6] source sha:1b62841b1859ae3443e2bf1ebe99ec3d6afb6cc2 git bisect good 86fee7ded76d9c2756ccab6aef160a2d7fab0ab6 # bad: [11864a7db429a57aeea021e0b3f1fb1412282d32] source sha:e5b721a14c1c8e5261a70588b30353cbb5bd55c6 git bisect bad 11864a7db429a57aeea021e0b3f1fb1412282d32 # good: [cec39174971f789b01d212afe8b5ffdd1ba466ca] source sha:76e75d2dd6dafe55fd1740693529640652ed6455 git bisect good cec39174971f789b01d212afe8b5ffdd1ba466ca # bad: [a3f07b2197c8ba6b4614fd06d2793099d78fae17] source sha:401483271ffca557a922d6d1ca271a46084867dc git bisect bad a3f07b2197c8ba6b4614fd06d2793099d78fae17 # bad: [2290510d84871b8f7f33a7f03f7b07bde43b6588] source sha:f927cf4d23432341921c55e6983edf9c8ebe7ff7 git bisect bad 2290510d84871b8f7f33a7f03f7b07bde43b6588 # good: [76818fe95bdebbb58306825b97f7f72cc7de1b80] source sha:ae78051c22d5a9bc7b5728482d59720fed7e6146 git bisect good 76818fe95bdebbb58306825b97f7f72cc7de1b80 # good: [44df3b1b50b2557200878b7ab70442c98a024774] source sha:75303695eb4bfe6c8fdea2cad0d3ed3f912f95c9 git bisect good 44df3b1b50b2557200878b7ab70442c98a024774 # good: [03b92a5d2b797a42dbcb3ad3d55de94fe140770e] source sha:c93db89a8f025a44ede88d16f01d11f41a818bbb git bisect good 03b92a5d2b797a42dbcb3ad3d55de94fe140770e # bad: [3b0d682bf09ba22097f076e2a4939b5d538f2247] source sha:67b4adc473c14f6ab72c27b52e77a76ed387dccc git bisect bad 3b0d682bf09ba22097f076e2a4939b5d538f2247 # good: [7ef4caeb1fa5a60e31bb16b707e7810b445125b8] source sha:16e4bbf44c4b2a95e26c331804940181c0fa1d86 git bisect good 7ef4caeb1fa5a60e31bb16b707e7810b445125b8 # good: [e6b57969a1666869561045a48c6a4c65beba7053] source sha:e8a5e8023d8c3adcd0d91160a82f093e76b85030 git bisect good e6b57969a1666869561045a48c6a4c65beba7053 # bad: [5d732ddf91434fdf18e91e1f9691ff52eab60f0e] source sha:32bc8ddbf335dd26019edcf12758643b4cff9913 git bisect bad 5d732ddf91434fdf18e91e1f9691ff52eab60f0e # bad: [5e8294b0ca5f96b0d65ba416a20547e15d14f38e] source sha:d3248d1fd83cca67a11dd593c124694382bf5f34 git bisect bad 5e8294b0ca5f96b0d65ba416a20547e15d14f38e # first bad commit: [5e8294b0ca5f96b0d65ba416a20547e15d14f38e] source sha:d3248d1fd83cca67a11dd593c124694382bf5f34 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svtools/source svx/source vcl/source
svtools/source/graphic/grfmgr2.cxx |6 +++--- svtools/source/misc/transfer.cxx|2 +- svx/source/xml/xmlgrhlp.cxx |6 +++--- vcl/source/filter/graphicfilter.cxx |2 +- vcl/source/gdi/print2.cxx |4 ++-- vcl/source/outdev/transparent.cxx | 24 6 files changed, 22 insertions(+), 22 deletions(-) New commits: commit 5adab0927483d039037b0f93894627e41a2c72f2 Author: Jochen NitschkeDate: Mon Jan 2 21:57:23 2017 +0100 replace C-style casts with const_cast Change-Id: Ica6522b4bfe2aa4517469e89cabe5d4d057cb6b7 Reviewed-on: https://gerrit.libreoffice.org/32657 Tested-by: Jenkins Reviewed-by: Jochen Nitschke diff --git a/svtools/source/graphic/grfmgr2.cxx b/svtools/source/graphic/grfmgr2.cxx index 408bee5..e2608bb 100644 --- a/svtools/source/graphic/grfmgr2.cxx +++ b/svtools/source/graphic/grfmgr2.cxx @@ -1622,9 +1622,9 @@ void GraphicManager::ImplDraw( OutputDevice* pOut, const Point& rPt, const Size& pOut->Push( PushFlags::CLIPREGION ); pOut->IntersectClipRegion( Rectangle( aOutPt, aOutSz ) ); -( (GDIMetaFile&) rMtf ).WindStart(); -( (GDIMetaFile&) rMtf ).Play( pOut, aOutPt, aOutSz ); -( (GDIMetaFile&) rMtf ).WindStart(); +const_cast (rMtf).WindStart(); +const_cast (rMtf).Play( pOut, aOutPt, aOutSz ); +const_cast (rMtf).WindStart(); pOut->Pop(); } diff --git a/svtools/source/misc/transfer.cxx b/svtools/source/misc/transfer.cxx index ade1bc0..08195e6 100644 --- a/svtools/source/misc/transfer.cxx +++ b/svtools/source/misc/transfer.cxx @@ -690,7 +690,7 @@ bool TransferableHelper::SetGDIMetaFile( const GDIMetaFile& rMtf, const DataFlav { SvMemoryStream aMemStm( 65535, 65535 ); -( (GDIMetaFile&) rMtf ).Write( aMemStm ); +const_cast (rMtf).Write( aMemStm ); maAny <<= Sequence< sal_Int8 >( static_cast< const sal_Int8* >( aMemStm.GetData() ), aMemStm.Seek( STREAM_SEEK_TO_END ) ); } diff --git a/svx/source/xml/xmlgrhlp.cxx b/svx/source/xml/xmlgrhlp.cxx index e9271fb..0212dc9 100644 --- a/svx/source/xml/xmlgrhlp.cxx +++ b/svx/source/xml/xmlgrhlp.cxx @@ -134,7 +134,7 @@ SvXMLGraphicInputStream::SvXMLGraphicInputStream( const OUString& rGraphicId ) { pStm->SetVersion( SOFFICE_FILEFORMAT_8 ); pStm->SetCompressMode( SvStreamCompressFlags::ZBITMAP ); -( (GDIMetaFile&) aGraphic.GetGDIMetaFile() ).Write( *pStm ); +const_cast ( aGraphic.GetGDIMetaFile() ).Write( *pStm ); bRet = ( pStm->GetError() == 0 ); } } @@ -581,7 +581,7 @@ bool SvXMLGraphicHelper::ImplWriteGraphic( const OUString& rPictureStorageName, pStream->SetCompressMode( SvStreamCompressFlags::ZBITMAP ); // SJ: first check if this metafile is just a eps file, then we will store the eps instead of svm -GDIMetaFile& rMtf( (GDIMetaFile&)aGraphic.GetGDIMetaFile() ); +GDIMetaFile& rMtf(const_cast ( aGraphic.GetGDIMetaFile() )); const MetaCommentAction* pComment = ImplCheckForEPS( rMtf ); if ( pComment ) { @@ -706,7 +706,7 @@ void SvXMLGraphicHelper::ImplInsertGraphicURL( const OUString& rURLStr, sal_uInt else if( aGrfObject.GetType() == GraphicType::GdiMetafile ) { // SJ: first check if this metafile is just a eps file, then we will store the eps instead of svm -GDIMetaFile& rMtf( (GDIMetaFile&)aGraphic.GetGDIMetaFile() ); +GDIMetaFile& rMtf(const_cast ( aGraphic.GetGDIMetaFile() )); if ( ImplCheckForEPS( rMtf ) ) aExtension = ".eps"; else diff --git a/vcl/source/filter/graphicfilter.cxx b/vcl/source/filter/graphicfilter.cxx index 40c0e1c..50506fe 100644 --- a/vcl/source/filter/graphicfilter.cxx +++ b/vcl/source/filter/graphicfilter.cxx @@ -2058,7 +2058,7 @@ sal_uInt16 GraphicFilter::ExportGraphic( const Graphic& rGraphic, const OUString SvMemoryStream aMemStm( 65535, 65535 ); // #i119735# just use GetGDIMetaFile, it will create a buffered version of contained bitmap now automatically -( (GDIMetaFile&) aGraphic.GetGDIMetaFile() ).Write( aMemStm ); +const_cast ( aGraphic.GetGDIMetaFile() ).Write( aMemStm ); xActiveDataSource->setOutputStream( css::uno::Reference< css::io::XOutputStream >( xStmIf,
[Libreoffice-bugs] [Bug 105227] Sumproduct function in LO 5 breaks compatibility from LO 4
https://bugs.documentfoundation.org/show_bug.cgi?id=105227 --- Comment #2 from Eddy--- Thanks a lot ! Sorry I didn't find bug 91453 before reporting this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105227] Sumproduct function in LO 5 breaks compatibility from LO 4
https://bugs.documentfoundation.org/show_bug.cgi?id=105227 Mike Kaganskichanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Mike Kaganski --- *** This bug has been marked as a duplicate of bug 91453 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103225] Area dialog is too large
https://bugs.documentfoundation.org/show_bug.cgi?id=103225 --- Comment #11 from Commit Notification--- Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=62a94dcf0c750e335d6ce272d8a5df9813910d5a tdf#103225 revert setting of a fixed size for the dialog It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103225] Area dialog is too large
https://bugs.documentfoundation.org/show_bug.cgi?id=103225 Commit Notificationchanged: What|Removed |Added Whiteboard||target:5.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source
cui/source/tabpages/tparea.cxx |3 --- 1 file changed, 3 deletions(-) New commits: commit 62a94dcf0c750e335d6ce272d8a5df9813910d5a Author: Tomaž VajngerlDate: Mon Jan 9 22:59:29 2017 +0100 tdf#103225 revert setting of a fixed size for the dialog Setting fixed size of a dialog causes a mess with HiDPI and could also cause problems with certain languages because the translated strings could streach the dialog size. It is better to let the dialog calculate its ideal size depending on the content, which in some cases is not ideal but at least it shouldn't create a mess. The decision to revert this was done in design hangout on 2016-12-22. Change-Id: I0ad1e38e1625cdbbf65b846118995bd5d3ebb47e Reviewed-on: https://gerrit.libreoffice.org/32912 Reviewed-by: Tomaž Vajngerl Tested-by: Tomaž Vajngerl diff --git a/cui/source/tabpages/tparea.cxx b/cui/source/tabpages/tparea.cxx index 0032e28..fbe4600 100644 --- a/cui/source/tabpages/tparea.cxx +++ b/cui/source/tabpages/tparea.cxx @@ -125,9 +125,6 @@ SvxAreaTabPage::SvxAreaTabPage( vcl::Window* pParent, const SfxItemSet& rInAttrs m_pBtnPattern->SetClickHdl(aLink); SetExchangeSupport(); - -m_pFillTab->set_width_request(750); -m_pFillTab->set_height_request(550); } SvxAreaTabPage::~SvxAreaTabPage() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 105227] New: Sumproduct function in LO 5 breaks compatibility from LO 4
https://bugs.documentfoundation.org/show_bug.cgi?id=105227 Bug ID: 105227 Summary: Sumproduct function in LO 5 breaks compatibility from LO 4 Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vive.li...@belgacom.net Created attachment 130294 --> https://bugs.documentfoundation.org/attachment.cgi?id=130294=edit Example of sumproduct formula producing error on text cell In LibreOffice 4, when a cell used in sumproduct contained text, it was ignored and the sum was done with the values of other cells. The same file in LibreOffice5 produces an error. See attached file : cell A1 contains 5 cell B1 contains 8 Cell A2 contains 4 cell B2 contains 2 cell A4 contains formula =SOMMEPROD(A1:B1*A2:B2) (using French local) This returns value 36 as expected. If I replace B2 by somme text, for example "-" then cell A4 returns value 20 in LibreOffice 4 (ignoring completely cells B1 and B2) and #VALEUR ! in LibreOffice 5. Of course there is logic in both behaviours and I can even understand why some might find LO 5 's handling of the situation to be better. But alas this change renders lots of files (in my case anyway) and make them totally useless. IMO formulas should not be version dependant. Compatibility matters ! Thanks any way for the excellent work and a great office suit. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104955] Check boxes in Base forms replaced by a small picture
https://bugs.documentfoundation.org/show_bug.cgi?id=104955 --- Comment #20 from ribotb--- (In reply to ribotb from comment #18) > The problem occurs when using style: 'flat' in check box control. It's Ok > with style: '3D'. > With style: 'flat' > - with new profile, check boxes are not displayed. > - with my old profile, checkboxes are displayed with a small picture. Not reproduced with version: 5.4.0.0.alpha0+ !? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101828] RTF paste no longer available in 5.2+
https://bugs.documentfoundation.org/show_bug.cgi?id=101828 --- Comment #33 from Aron Budea--- Mike, this is how bug fixing works, first the fix is pushed into the current development branch, and later it's backported to release branches. This ensures the fix can be tested first before it potentially causes more serious issues than it fixed. Additionally, not all fixes get backported, but let's not get into that, I'm sure this qualifies. Please be patient. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105121] Crash after editing query and closing query window
https://bugs.documentfoundation.org/show_bug.cgi?id=105121 Maxim Monastirskychanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |momonas...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82504] EDITING: Background color button should fill cell background and not paragraph color when in a cell (proposed solution in comment #10)
https://bugs.documentfoundation.org/show_bug.cgi?id=82504 Maxim Monastirskychanged: What|Removed |Added CC||shunesbur...@yahoo.fr --- Comment #22 from Maxim Monastirsky --- *** Bug 101090 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101090] Color Background not fill the cell from the table toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101090 Maxim Monastirskychanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Maxim Monastirsky --- *** This bug has been marked as a duplicate of bug 82504 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-0' - configure.ac debian/changelog loleaflet/Makefile
configure.ac |2 +- debian/changelog |6 ++ loleaflet/Makefile |2 +- 3 files changed, 8 insertions(+), 2 deletions(-) New commits: commit 14a576dff642f5888bf2e3b432d87d0cc4b8a6e5 Author: Andras TimarDate: Mon Jan 9 22:40:09 2017 +0100 Bump version to 2.0.2 Change-Id: Iabc2514893542b0817d9d066749074e84f4f0d59 diff --git a/configure.ac b/configure.ac index af85b90..444929c 100644 --- a/configure.ac +++ b/configure.ac @@ -3,7 +3,7 @@ AC_PREREQ([2.69]) -AC_INIT([loolwsd], [2.0.1], [libreoffice@lists.freedesktop.org]) +AC_INIT([loolwsd], [2.0.2], [libreoffice@lists.freedesktop.org]) LT_INIT([shared, disable-static, dlopen]) AM_INIT_AUTOMAKE([1.11 silent-rules subdir-objects]) diff --git a/debian/changelog b/debian/changelog index babec6c..49d769d 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +loolwsd (2.0.2-1) unstable; urgency=medium + + * see the git log: http://col.la/cool20 + + -- Andras Timar Wed, 11 Jan 2017 11:40:00 +0100 + loolwsd (2.0.1-1) unstable; urgency=medium * see the git log: http://col.la/cool20 diff --git a/loleaflet/Makefile b/loleaflet/Makefile index 7615e05..430d24c 100644 --- a/loleaflet/Makefile +++ b/loleaflet/Makefile @@ -3,7 +3,7 @@ # ("micro") part: Between releases odd, even for releases (no other # changes inbetween). -VERSION=2.0.1 +VERSION=2.0.2 # Version number of the bundled 'draw' thing DRAW_VERSION=0.2.4 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 105226] TIME (ORARIO in IT) Calc function
https://bugs.documentfoundation.org/show_bug.cgi?id=105226 gmarcochanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=96 ||140 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96140] TIMEVALUE Calc function described incorrectly in the Italian documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=96140 gmarcochanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||5226 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: fpicker/source
fpicker/source/aqua/resourceprovider.mm |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 20c16740b19a028624388a0d4961659a2a9d8b55 Author: Stephan BergmannDate: Mon Jan 9 22:36:52 2017 +0100 loplugin:externvar Change-Id: I6cf0b0c6b3a6a214fd0c1b835be491901deb2495 diff --git a/fpicker/source/aqua/resourceprovider.mm b/fpicker/source/aqua/resourceprovider.mm index f7531cc..ab406b3 100644 --- a/fpicker/source/aqua/resourceprovider.mm +++ b/fpicker/source/aqua/resourceprovider.mm @@ -46,7 +46,7 @@ struct Entry sal_Int16 resId; }; -Entry CtrlIdToResIdTable[] = { +Entry const CtrlIdToResIdTable[] = { { CHECKBOX_AUTOEXTENSION, STR_SVT_FILEPICKER_AUTO_EXTENSION }, { CHECKBOX_PASSWORD,STR_SVT_FILEPICKER_PASSWORD }, { CHECKBOX_FILTEROPTIONS, STR_SVT_FILEPICKER_FILTER_OPTIONS }, @@ -64,7 +64,7 @@ Entry CtrlIdToResIdTable[] = { { LISTBOX_FILTER_LABEL, STR_SVT_FILEPICKER_FILTER_TITLE} }; -Entry OtherCtrlIdToResIdTable[] = { +Entry const OtherCtrlIdToResIdTable[] = { { FILE_PICKER_TITLE_OPEN, STR_FILEDLG_OPEN }, { FILE_PICKER_TITLE_SAVE, STR_FILEDLG_SAVE }, { FILE_PICKER_FILE_TYPE,STR_FILEDLG_TYPE } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 96140] TIMEVALUE Calc function described incorrectly in the Italian documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=96140 gmarcochanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||5222 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105221] TIME (ORARIO in IT) Calc function incorrect help documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=105221 gmarcochanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=96 ||140 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96140] TIMEVALUE Calc function described incorrectly in the Italian documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=96140 gmarcochanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||5224 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105224] TIMEVALUE (ORARIO.VALORE in IT) Calc function
https://bugs.documentfoundation.org/show_bug.cgi?id=105224 gmarcochanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=96 ||140 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105222] TIMEVALUE (ORARIO.VALORE in IT) Calc function incorrect/ lack of help documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=105222 gmarcochanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=96 ||140 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96140] TIMEVALUE Calc function described incorrectly in the Italian documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=96140 gmarcochanged: What|Removed |Added Status|NEW |RESOLVED See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||5221 Resolution|--- |MOVED --- Comment #15 from gmarco --- As required, being the question a mixture of incorrect documentation and probable bugs affecting two different functions in Calc, I divided this one in 4 distinct bugs: 105221, 105222, 105224, 105226 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105226] New: TIME (ORARIO in IT) Calc function
https://bugs.documentfoundation.org/show_bug.cgi?id=105226 Bug ID: 105226 Summary: TIME (ORARIO in IT) Calc function Product: LibreOffice Version: 5.2.3.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gmmell...@inwind.it Created attachment 130293 --> https://bugs.documentfoundation.org/attachment.cgi?id=130293=edit sample test ods In the attached "Calc time odssample" you can see and verify my tests: =ORARIO(0;0;0) cannot anyway display as result "12.00.00m." (cell format "H.MM.SS AM/PM" or "HH.MM.SS AM/PM") where "m." stays for antimeridian. =ORARIO(0;35;15) cannot anyway display as result "12.35.15m." (cell format "H.MM.SS AM/PM" or "HH.MM.SS AM/PM") where "m." stays for antimeridian. =ORARIO(24;0;0) cannot anyway display as result "12.00.00m." (cell format "H.MM.SS AM/PM" or "HH.MM.SS AM/PM") where "m." stays for antimeridian. =ORARIO(24;35;15) cannot anyway display as result "12.35.15m." (cell format "H.MM.SS AM/PM" or "HH.MM.SS AM/PM") where "m." stays for antimeridian. Further I note that anti and post meridian espress in Calc with the letters "m." and "p." are unusual symbols (in IT we generally use “a.m. or am" and "p.m. or pm" lower or uppercase): I translate what you can read about at the link http://tp.linux.it/data_ora_valuta.html TIMEVALUE. The conventional notation to indicate a time in Italian language is "o:mm:ss" with the hour expressed in 24-hour format without leading zero. Expressed in the syntax of the GNU program date(1) becomes: %k:%M:%S Examples: 13:00:56 4:12 The presence of leading zeros (obtained with dates(1) by replacing the %k with %H) is allowed in case you have the need for alignment issues or ordering. It should be noted, that only for the alignment motivation, the agreement for date(1) provides for the possibility to use the "_" and "-" modifiers to hide some digit. Consult the man page for more information. In case you must use the 12-hour format, morning and afternoon should be rendered as "a.m." and "p.m.". Any other expression (AM/PM or A.M./P.M and so on) is to be avoided. Also in case you must use the 12-hour format, the issue date(1) to use for the hour is %-I -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105225] New: Color palette cannot be chosen in various places
https://bugs.documentfoundation.org/show_bug.cgi?id=105225 Bug ID: 105225 Summary: Color palette cannot be chosen in various places Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: c...@nouenoff.nl Writer: Table > Properties > Background Format > Color > Highlighting Insert > Section > Background Calc: Format > Cells > Background Format > Page > Background On the positive side (apart from the nice palette (handling) improvements in 5.3): in these cases the palette can be selected in the properties panel in the side bar. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105224] TIMEVALUE (ORARIO.VALORE in IT) Calc function
https://bugs.documentfoundation.org/show_bug.cgi?id=105224 --- Comment #1 from gmarco--- Created attachment 130292 --> https://bugs.documentfoundation.org/attachment.cgi?id=130292=edit sample test ods -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105224] New: TIMEVALUE (ORARIO.VALORE in IT) Calc function
https://bugs.documentfoundation.org/show_bug.cgi?id=105224 Bug ID: 105224 Summary: TIMEVALUE (ORARIO.VALORE in IT) Calc function Product: LibreOffice Version: 5.2.3.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gmmell...@inwind.it In the attached "Calc timevalue odssample" you can see and verify my tests: =ORARIO.VALORE("00.00") cannot anyway display as result "12.00.00m." (cell format "H.MM.SS AM/PM" or "HH.MM.SS AM/PM") where "m." stays for antimeridian. =ORARIO.VALORE("24.00”) cannot anyway display as result "12.00.00m." (cell format "H.MM.SS AM/PM" or "HH.MM.SS AM/PM") where "m." stays for antimeridian. Further I note that anti and post meridian espress in Calc with the letters "m." and "p." are unusual symbols (in IT we generally use “a.m. or am" and "p.m. or pm" lower or uppercase): I translate what you can read about at the link http://tp.linux.it/data_ora_valuta.html TIMEVALUE. The conventional notation to indicate a time in Italian language is "o:mm:ss" with the hour expressed in 24-hour format without leading zero. Expressed in the syntax of the GNU program date(1) becomes: %k:%M:%S Examples: 13:00:56 4:12 The presence of leading zeros (obtained with dates(1) by replacing the %k with %H) is allowed in case you have the need for alignment issues or ordering. It should be noted, that only for the alignment motivation, the agreement for date(1) provides for the possibility to use the "_" and "-" modifiers to hide some digit. Consult the man page for more information. In case you must use the 12-hour format, morning and afternoon should be rendered as "a.m." and "p.m.". Any other expression (AM/PM or A.M./P.M and so on) is to be avoided. Also in case you must use the 12-hour format, the issue date(1) to use for the hour is %-I -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99711] Sidebar Position and Size displays incorrect width and height when units in mm
https://bugs.documentfoundation.org/show_bug.cgi?id=99711 Xisco Faulíchanged: What|Removed |Added CC||armin.le.gr...@me.com, ||xiscofa...@libreoffice.org --- Comment #7 from Xisco Faulí --- Commit hash: 36be3d94c2e142d01c026a93fa88454cb5316bff Adding Cc: to Armin Le Grand -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105130] Sum of times not correct
https://bugs.documentfoundation.org/show_bug.cgi?id=105130 --- Comment #7 from Aron Budea--- Are you sure the result field is formatted [HH]:MM:SS? That's what matters. If I open the attached file, and change B13's format to [HH]:MM:SS, it displays the expected 43:10:00 value. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105223] New: TIMEVALUE (ORARIO.VALORE in IT) Calc function
https://bugs.documentfoundation.org/show_bug.cgi?id=105223 Bug ID: 105223 Summary: TIMEVALUE (ORARIO.VALORE in IT) Calc function Product: LibreOffice Version: 5.2.3.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gmmell...@inwind.it Created attachment 130291 --> https://bugs.documentfoundation.org/attachment.cgi?id=130291=edit sample test ods In the attached "Calc timevalue odssample" you can see and verify my tests: =ORARIO.VALORE("00.00") cannot anyway display as result "12.00.00m." (cell format "H.MM.SS AM/PM" or "HH.MM.SS AM/PM") where "m." stays for antimeridian. =ORARIO.VALORE("24.00”) cannot anyway display as result "12.00.00m." (cell format "H.MM.SS AM/PM" or "HH.MM.SS AM/PM") where "m." stays for antimeridian. Further I note that anti and post meridian espress in Calc with the letters "m." and "p." are unusual symbols (in IT we generally use “a.m. or am" and "p.m. or pm" lower or uppercase): I translate what you can read about at the link http://tp.linux.it/data_ora_valuta.html TIMEVALUE. The conventional notation to indicate a time in Italian language is "o:mm:ss" with the hour expressed in 24-hour format without leading zero. Expressed in the syntax of the GNU program date(1) becomes: %k:%M:%S Examples: 13:00:56 4:12 The presence of leading zeros (obtained with dates(1) by replacing the %k with %H) is allowed in case you have the need for alignment issues or ordering. It should be noted, that only for the alignment motivation, the agreement for date(1) provides for the possibility to use the "_" and "-" modifiers to hide some digit. Consult the man page for more information. In case you must use the 12-hour format, morning and afternoon should be rendered as "a.m." and "p.m.". Any other expression (AM/PM or A.M./P.M and so on) is to be avoided. Also in case you must use the 12-hour format, the issue date(1) to use for the hour is %-I -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105222] New: TIMEVALUE (ORARIO.VALORE in IT) Calc function incorrect/ lack of help documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=105222 Bug ID: 105222 Summary: TIMEVALUE (ORARIO.VALORE in IT) Calc function incorrect/lack of help documentation Product: LibreOffice Version: 5.2.3.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gmmell...@inwind.it Created attachment 130290 --> https://bugs.documentfoundation.org/attachment.cgi?id=130290=edit sample test ods Both local and online, both EN and IT helps have very poor documentation about offered examples and those displayed are incorrect and get an "Err:502" result. In the attached "Calc timevalue odssample" you can see and verify my tests: "4PM" has to be "4P." or "4p." (a space is also ok between the hour number and the letter), "24:00" has to be "24.00". No other example is offered. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105221] New: TIME (ORARIO in IT) Calc function incorrect help documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=105221 Bug ID: 105221 Summary: TIME (ORARIO in IT) Calc function incorrect help documentation Product: LibreOffice Version: 5.2.3.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gmmell...@inwind.it Created attachment 130289 --> https://bugs.documentfoundation.org/attachment.cgi?id=130289=edit sample test ods Both local and online, both EN and IT helps examples are incorrect. In the attached "Calc time odssample" you can see and verify my tests: the two examples display “returns 00:00:00” and “returns 04:20:04” with colons instead of dots. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93756] Highlight color is not shown in character style list
https://bugs.documentfoundation.org/show_bug.cgi?id=93756 Cor Nouwschanged: What|Removed |Added Keywords|difficultyBeginner | CC||c...@nouenoff.nl Version|5.0.1.2 release |unspecified Summary|Background color is not |Highlight color is not |shown in character style|shown in character style |list|list Severity|normal |enhancement --- Comment #2 from Cor Nouws --- (In reply to tomaskeb from comment #0) > If a background color is set for a paragraph style, it does show in the > style list. If the same is done for a character style, the background (or > highlight) is not shown in the list. Background != Highlight. So not a bug. You could argue for enhancement: show character highlighting for character style in preview. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/qa
sd/qa/unit/data/ppt/FillPatterns.ppt |binary sd/qa/unit/import-tests.cxx | 339 +++ 2 files changed, 339 insertions(+) New commits: commit 0b87e17a4e122d53a765a9db2ae54908e0803b65 Author: Tomaž VajngerlDate: Sun Jan 8 23:32:05 2017 +0100 Test that patterns are correctly imported for MS binary format Change-Id: I8335ee35bae11c8014d6591744199e55bc3ec41b Reviewed-on: https://gerrit.libreoffice.org/32854 Reviewed-by: Tomaž Vajngerl Tested-by: Tomaž Vajngerl diff --git a/sd/qa/unit/data/ppt/FillPatterns.ppt b/sd/qa/unit/data/ppt/FillPatterns.ppt new file mode 100644 index 000..bbd353b Binary files /dev/null and b/sd/qa/unit/data/ppt/FillPatterns.ppt differ diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx index dd5f2e0..f0f523c 100644 --- a/sd/qa/unit/import-tests.cxx +++ b/sd/qa/unit/import-tests.cxx @@ -69,6 +69,7 @@ #include #include #include +#include #include #include #include @@ -137,6 +138,9 @@ public: void testTdf105150(); void testTdf105150PPT(); +bool checkPattern(sd::DrawDocShellRef& rDocRef, int nShapeNumber, std::vector& rExpected); +void testPatternImport(); + CPPUNIT_TEST_SUITE(SdImportTest); CPPUNIT_TEST(testDocumentLayout); @@ -196,6 +200,7 @@ public: CPPUNIT_TEST(testTdf104445); CPPUNIT_TEST(testTdf105150); CPPUNIT_TEST(testTdf105150PPT); +CPPUNIT_TEST(testPatternImport); CPPUNIT_TEST_SUITE_END(); }; @@ -1719,6 +1724,340 @@ void SdImportTest::testTdf104445() xDocShRef->DoClose(); } +namespace +{ + +bool checkPatternValues(std::vector& rExpected, Bitmap& rBitmap) +{ +bool bResult = true; + +Color aFGColor(0xFF); +Color aBGColor(0xFF); + +Bitmap::ScopedReadAccess pAccess(rBitmap); +for (long y = 0; y < pAccess->Height(); ++y) +{ +for (long x = 0; x < pAccess->Width(); ++x) +{ +Color aColor = pAccess->GetPixel(y, x); +sal_uInt8 aValue = rExpected[y*8+x]; + +if (aValue == 1 && aColor != aFGColor) +bResult = false; +else if (aValue == 0 && aColor != aBGColor) +bResult = false; +} +} + +return bResult; +} + +} // end anonymous namespace + +bool SdImportTest::checkPattern(sd::DrawDocShellRef& rDocRef, int nShapeNumber, std::vector& rExpected) +{ +uno::Reference xShape(getShapeFromPage(nShapeNumber, 0, rDocRef)); +CPPUNIT_ASSERT_MESSAGE("Not a shape", xShape.is()); + +Bitmap aBitmap; +if (xShape.is()) +{ +uno::Any aBitmapAny = xShape->getPropertyValue("FillBitmap"); +uno::Reference xBitmap; +if (aBitmapAny >>= xBitmap) +{ +uno::Sequence aBitmapSequence(xBitmap->getDIB()); +SvMemoryStream aBitmapStream(aBitmapSequence.getArray(), + aBitmapSequence.getLength(), + StreamMode::READ); +ReadDIB(aBitmap, aBitmapStream, true); +} +} +CPPUNIT_ASSERT_EQUAL(8L, aBitmap.GetSizePixel().Width()); +CPPUNIT_ASSERT_EQUAL(8L, aBitmap.GetSizePixel().Height()); +return checkPatternValues(rExpected, aBitmap); +} + +/* Test checks that importing a PPT file with all supported fill patterns is + * correctly imported as a tiled fill bitmap with the expected pattern. + */ +void SdImportTest::testPatternImport() +{ +sd::DrawDocShellRef xDocRef = loadURL(m_directories.getURLFromSrc("sd/qa/unit/data/ppt/FillPatterns.ppt"), PPT); + +std::vector aExpectedPattern1 = { +1,0,0,0,0,0,0,0, +0,0,0,0,0,0,0,0, +0,0,0,0,0,0,0,0, +0,0,0,0,0,0,0,0, +0,0,0,0,1,0,0,0, +0,0,0,0,0,0,0,0, +0,0,0,0,0,0,0,0, +0,0,0,0,0,0,0,0, +}; +std::vector aExpectedPattern2 = { +1,0,0,0,0,0,0,0, +0,0,0,0,0,0,0,0, +0,0,0,0,1,0,0,0, +0,0,0,0,0,0,0,0, +1,0,0,0,0,0,0,0, +0,0,0,0,0,0,0,0, +0,0,0,0,1,0,0,0, +0,0,0,0,0,0,0,0, +}; +std::vector aExpectedPattern3 = { +1,0,0,0,1,0,0,0, +0,0,0,0,0,0,0,0, +0,0,1,0,0,0,1,0, +0,0,0,0,0,0,0,0, +1,0,0,0,1,0,0,0, +0,0,0,0,0,0,0,0, +0,0,1,0,0,0,1,0, +0,0,0,0,0,0,0,0, +}; +std::vector aExpectedPattern4 = { +1,0,0,0,1,0,0,0, +0,0,1,0,0,0,1,0, +1,0,0,0,1,0,0,0, +0,0,1,0,0,0,1,0, +1,0,0,0,1,0,0,0, +0,0,1,0,0,0,1,0, +1,0,0,0,1,0,0,0, +0,0,1,0,0,0,1,0, +}; +std::vector aExpectedPattern5 = { +1,0,1,0,1,0,1,0, +0,1,0,0,0,1,0,0, +1,0,1,0,1,0,1,0, +0,0,0,1,0,0,0,1, +1,0,1,0,1,0,1,0, +0,1,0,0,0,1,0,0, +1,0,1,0,1,0,1,0, +0,0,0,1,0,0,0,1, +}; +std::vector aExpectedPattern6 = { +
[Libreoffice-commits] core.git: filter/source
filter/source/msfilter/msdffimp.cxx | 38 1 file changed, 22 insertions(+), 16 deletions(-) New commits: commit 735941713c81ec8ca9ac796b832d776f6ef633ef Author: Tomaž VajngerlDate: Sun Jan 8 23:35:44 2017 +0100 Fix import of patterns for MS binary formats Don't use XOBitmap, which in some cases doesn't import the pattern correctly (on Linux and with a different issue on Windows too) - it doesn't seem to be necessary to use it, just convert the pattern bitmap to a bitmap that has the expected colors applied. Change-Id: Ide7d5ce0115b63e882b3544b10fd00d5582cf7d3 Reviewed-on: https://gerrit.libreoffice.org/32855 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/filter/source/msfilter/msdffimp.cxx b/filter/source/msfilter/msdffimp.cxx index 841c546..651e94b 100644 --- a/filter/source/msfilter/msdffimp.cxx +++ b/filter/source/msfilter/msdffimp.cxx @@ -1369,24 +1369,30 @@ void DffPropertyReader::ApplyFillAttributes( SvStream& rIn, SfxItemSet& rSet, co if ( IsProperty( DFF_Prop_fillBackColor ) ) aCol2 = rManager.MSO_CLR_ToColor( GetPropertyValue( DFF_Prop_fillBackColor, 0 ), DFF_Prop_fillBackColor ); -XOBitmap aXOBitmap( aBmp ); -aXOBitmap.Bitmap2Array(); -aXOBitmap.SetBitmapType( XBitmapType::N8x8 ); -aXOBitmap.SetPixelSize( aBmp.GetSizePixel() ); - -if( aXOBitmap.GetBackgroundColor() == COL_BLACK ) +// Create a bitmap for the pattern with expected colors +Bitmap aResult(Size(8, 8), 24); { -aXOBitmap.SetPixelColor( aCol1 ); -aXOBitmap.SetBackgroundColor( aCol2 ); -} -else -{ -aXOBitmap.SetPixelColor( aCol2 ); -aXOBitmap.SetBackgroundColor( aCol1 ); -} +Bitmap::ScopedReadAccess pRead(aBmp); +Bitmap::ScopedWriteAccess pWrite(aResult); -aXOBitmap.Array2Bitmap(); -aGraf = Graphic( aXOBitmap.GetBitmap() ); +for (long y = 0; y < pWrite->Height(); ++y) +{ +for (long x = 0; x < pWrite->Width(); ++x) +{ +Color aReadColor; +if (pRead->HasPalette()) +aReadColor = pRead->GetPaletteColor(pRead->GetPixelIndex(y, x)); +else +aReadColor = pRead->GetPixel(y, x); + +if (aReadColor.GetColor() == 0) +pWrite->SetPixel(y, x, aCol2); +else +pWrite->SetPixel(y, x, aCol1); +} +} +} +aGraf = Graphic(aResult); } rSet.Put(XFillBitmapItem(OUString(), aGraf)); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 101090] Color Background not fill the cell from the table toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=101090 Cor Nouwschanged: What|Removed |Added Status|NEW |NEEDINFO CC||c...@nouenoff.nl --- Comment #6 from Cor Nouws --- (In reply to shunesburg69 from comment #0) > When you use the color background from the table toolbar, the color > background doesn't fill completely the cell, The button is to set background color for the paragraph. By design. We've seen more reports of this in the past. Maybe the tool tip should be adapted to "Paragraph back ground" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95357] TRACK CHANGES: Change tracking movement/ action are inconsistent for replacements
https://bugs.documentfoundation.org/show_bug.cgi?id=95357 --- Comment #14 from Andrew Sinclair--- (In reply to Heiko Tietze from comment #13) > (In reply to Andrew Sinclair from comment #12) > > ...Workshare does has a third category beyond additions and > > deletions: "moves". I don't find it particularly useful though. > > Why not? You don't delete a full paragraph but _move_ it to some other > chapter. Wouldn't be obvious unless the state is correctly set. I'm rather > afraid of the correct implementation. Is copy/paste + delete (or vice versa) > the same as cut & paste? Not when we follow my suggestion in comment 11, > which would be, however, strange for the user. "Moves" in Workshare seem to be based solely on text similarities. My use case is legal documents. Those tend to use similar wording in multiple places, which leads to false positives (something being shown as a "move" that's really just a common phrase added in one place and deleted from another). Another limitation to their implementation is that text cannot be both moved and edited, so compare results show some part of the text moved and other parts edited. It's generally messy enough not to be useful to me. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/osx
vcl/osx/HtmlFmtFlt.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit a0a42ade2137348a83c05f01fe25ebadab69a9e2 Author: Stephan BergmannDate: Mon Jan 9 22:08:52 2017 +0100 loplugin:externvar Change-Id: Ie6834e7cb1e65a2e24c6250126c24463e6e49354 diff --git a/vcl/osx/HtmlFmtFlt.cxx b/vcl/osx/HtmlFmtFlt.cxx index 9804dbd..e068a45 100644 --- a/vcl/osx/HtmlFmtFlt.cxx +++ b/vcl/osx/HtmlFmtFlt.cxx @@ -115,7 +115,7 @@ Sequence SAL_CALL TextHtmlToHTMLFormat(Sequence& aTextHtml) return byteSequence; } -const char* HtmlStartTag = "
[Libreoffice-ux-advise] [Bug 95357] TRACK CHANGES: Change tracking movement/ action are inconsistent for replacements
https://bugs.documentfoundation.org/show_bug.cgi?id=95357 --- Comment #14 from Andrew Sinclair--- (In reply to Heiko Tietze from comment #13) > (In reply to Andrew Sinclair from comment #12) > > ...Workshare does has a third category beyond additions and > > deletions: "moves". I don't find it particularly useful though. > > Why not? You don't delete a full paragraph but _move_ it to some other > chapter. Wouldn't be obvious unless the state is correctly set. I'm rather > afraid of the correct implementation. Is copy/paste + delete (or vice versa) > the same as cut & paste? Not when we follow my suggestion in comment 11, > which would be, however, strange for the user. "Moves" in Workshare seem to be based solely on text similarities. My use case is legal documents. Those tend to use similar wording in multiple places, which leads to false positives (something being shown as a "move" that's really just a common phrase added in one place and deleted from another). Another limitation to their implementation is that text cannot be both moved and edited, so compare results show some part of the text moved and other parts edited. It's generally messy enough not to be useful to me. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 105220] New: Firebird: Insert with direct SQL - RETURNING without values
https://bugs.documentfoundation.org/show_bug.cgi?id=105220 Bug ID: 105220 Summary: Firebird: Insert with direct SQL - RETURNING without values Product: LibreOffice Version: 5.4.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rob...@familiegrosskopf.de Created attachment 130288 --> https://bugs.documentfoundation.org/attachment.cgi?id=130288=edit Open the database and try the code as described for get the last inserted AutoValue Open the attached Firebird 3 database. Open Tools > SQL... Mark "Show output of "select" statements. Copy the following code: INSERT INTO "Table" ("Name", "Town") VALUES ('Mike', 'Alexandria') RETURNING "ID", "Name", "Town"; There is no value shown as output. The status shows only "1." Expected is in "output": 4;Mike;Alexandria There is a function in HSQLDB named "CALL IDENTITY()" This gives you the last inserted AutoValue. I hope to find this in Firebird. There it should run with RETURNING, but doesn't run in Tools > SQL... Will test this later with macros to see, if it's a problem of internal Firebird or a problem of the SQL-dialog. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: hwpfilter/source
hwpfilter/source/fontmap.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4f36a2fbe6287281122aff2e781b9b7de9a41b88 Author: Stephan BergmannDate: Mon Jan 9 21:57:02 2017 +0100 loplugin:externvar Change-Id: Iedb9b26dbe33d447de309a763eaeeeb57d1fcdd1 diff --git a/hwpfilter/source/fontmap.cxx b/hwpfilter/source/fontmap.cxx index 7207e75..6ef93e7 100644 --- a/hwpfilter/source/fontmap.cxx +++ b/hwpfilter/source/fontmap.cxx @@ -134,7 +134,7 @@ const char* const RepFontTab[] = "\xb9\xe9\xb9\xac \xc7\xec\xb5\xe5\xb6\xf3\xc0\xce" /* 3 */ }; #else -const char* RepFontTab[] = +const char* const RepFontTab[] = { "Batang", /* 0 */ "Dotum", /* 1 */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 48140] Remove uno calls from xlsx import
https://bugs.documentfoundation.org/show_bug.cgi?id=48140 Bartoszchanged: What|Removed |Added Status|RESOLVED|NEW Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105200] LibO 5.2.4 installation aborted and can' t even uninstall LibO 4.4.7
https://bugs.documentfoundation.org/show_bug.cgi?id=105200 --- Comment #6 from Gregor--- I can run the portable version but it does not offer the items I need to do custom animations of objects (I reported bugs 53993, 85788, 85798 which I have been asked to retest in the latest version). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Makefile.in Repository.mk vcl/Executable_pcdfuzzer.mk vcl/Module_vcl.mk vcl/workben
Makefile.in |2 - Repository.mk |1 vcl/Executable_pcdfuzzer.mk | 47 vcl/Module_vcl.mk |1 vcl/workben/pcdfuzzer.cxx | 24 ++ 5 files changed, 74 insertions(+), 1 deletion(-) New commits: commit 4fcf17f89bc45e5e850f48efe274e6ea24ff8a86 Author: Caolán McNamaraDate: Mon Jan 9 17:04:27 2017 + add pcd fuzzer Change-Id: Id21659687952ec5e868733fbca12353dd71b8153 Reviewed-on: https://gerrit.libreoffice.org/32902 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/Makefile.in b/Makefile.in index 6aa00d0..38c2742 100644 --- a/Makefile.in +++ b/Makefile.in @@ -424,7 +424,7 @@ $(foreach ide,\ eclipsecdt,\ $(eval $(call gb_Top_GbuildToIdeIntegration,$(ide -fuzzers: Library_sal Library_salhelper Library_reg Library_store Library_unoidl codemaker Library_cppu Library_i18nlangtag Library_cppuhelper Library_comphelper StaticLibrary_ulingu StaticLibrary_jpeg StaticLibrary_findsofficepath Library_tl Rdb_services udkapi offapi Library_clew Library_gie Library_reflection Library_invocadapt Library_bootstrap Library_introspection Library_stocservices Library_xmlreader Library_gcc3_uno instsetoo_native more_fonts StaticLibrary_fuzzer Executable_wmffuzzer Executable_jpgfuzzer Executable_giffuzzer Executable_xbmfuzzer Executable_xpmfuzzer Executable_pngfuzzer Executable_bmpfuzzer Executable_svmfuzzer +fuzzers: Library_sal Library_salhelper Library_reg Library_store Library_unoidl codemaker Library_cppu Library_i18nlangtag Library_cppuhelper Library_comphelper StaticLibrary_ulingu StaticLibrary_jpeg StaticLibrary_findsofficepath Library_tl Rdb_services udkapi offapi Library_clew Library_gie Library_reflection Library_invocadapt Library_bootstrap Library_introspection Library_stocservices Library_xmlreader Library_gcc3_uno instsetoo_native more_fonts StaticLibrary_fuzzer Executable_wmffuzzer Executable_jpgfuzzer Executable_giffuzzer Executable_xbmfuzzer Executable_xpmfuzzer Executable_pngfuzzer Executable_bmpfuzzer Executable_svmfuzzer Executable_pcdfuzzer endif # MAKE_RESTARTS diff --git a/Repository.mk b/Repository.mk index f891da0..3b3491f 100644 --- a/Repository.mk +++ b/Repository.mk @@ -101,6 +101,7 @@ $(eval $(call gb_Helper_register_executables_for_install,OOO,brand, \ $(call gb_Helper_optional,FUZZERS,pngfuzzer) \ $(call gb_Helper_optional,FUZZERS,bmpfuzzer) \ $(call gb_Helper_optional,FUZZERS,svmfuzzer) \ + $(call gb_Helper_optional,FUZZERS,pcdfuzzer) \ $(if $(filter-out ANDROID IOS MACOSX WNT,$(OS)),oosplash) \ soffice_bin \ $(if $(filter DESKTOP,$(BUILD_TYPE)),unopkg_bin) \ diff --git a/vcl/Executable_pcdfuzzer.mk b/vcl/Executable_pcdfuzzer.mk new file mode 100644 index 000..0df86dd --- /dev/null +++ b/vcl/Executable_pcdfuzzer.mk @@ -0,0 +1,47 @@ +# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- +# +# +# This file is part of the LibreOffice project. +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# + +include $(SRCDIR)/vcl/commonfuzzer.mk + +$(eval $(call gb_Executable_Executable,pcdfuzzer)) + +$(eval $(call gb_Executable_use_api,pcdfuzzer,\ +offapi \ +udkapi \ +)) + +$(eval $(call gb_Executable_use_externals,pcdfuzzer,\ + $(fuzzer_externals) \ +)) + +$(eval $(call gb_Executable_set_include,pcdfuzzer,\ +$$(INCLUDE) \ +-I$(SRCDIR)/vcl/inc \ +)) + +$(eval $(call gb_Executable_use_libraries,pcdfuzzer,\ + $(fuzzer_libraries) \ +)) + +$(eval $(call gb_Executable_use_static_libraries,pcdfuzzer,\ +findsofficepath \ +ulingu \ +fuzzer \ +)) + +$(eval $(call gb_Executable_add_exception_objects,pcdfuzzer,\ + vcl/workben/pcdfuzzer \ +)) + +$(eval $(call gb_Executable_add_libs,pcdfuzzer,\ + -lFuzzingEngine \ +)) + +# vim: set noet sw=4 ts=4: diff --git a/vcl/Module_vcl.mk b/vcl/Module_vcl.mk index 571c046..4afb842 100644 --- a/vcl/Module_vcl.mk +++ b/vcl/Module_vcl.mk @@ -114,6 +114,7 @@ $(eval $(call gb_Module_add_targets,vcl,\ Executable_pngfuzzer \ Executable_bmpfuzzer \ Executable_svmfuzzer \ +Executable_pcdfuzzer \ )) endif diff --git a/vcl/workben/pcdfuzzer.cxx b/vcl/workben/pcdfuzzer.cxx new file mode 100644 index 000..bcfe48b --- /dev/null +++ b/vcl/workben/pcdfuzzer.cxx @@ -0,0 +1,24 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include
[Libreoffice-commits] core.git: include/svtools svtools/qa svtools/source
include/svtools/grfmgr.hxx|2 +- svtools/qa/unit/GraphicObjectTest.cxx |2 +- svtools/source/graphic/grfmgr.cxx |4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) New commits: commit 855fbe4edccf5c8299373087eb2cee5342ba4097 Author: Caolán McNamaraDate: Mon Jan 9 15:22:36 2017 + second arg of deformed copy ctor isn't used except in the qa test Change-Id: I84d1a06194e4c11b218c417663f12195c9f76526 Reviewed-on: https://gerrit.libreoffice.org/32890 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/include/svtools/grfmgr.hxx b/include/svtools/grfmgr.hxx index 0c01023..929fe89 100644 --- a/include/svtools/grfmgr.hxx +++ b/include/svtools/grfmgr.hxx @@ -323,7 +323,7 @@ protected: public: GraphicObject(); GraphicObject( const Graphic& rGraphic ); -GraphicObject( const GraphicObject& rCacheObj, const GraphicManager* pMgr = nullptr ); +GraphicObject( const GraphicObject& rCacheObj ); explicit GraphicObject( const OString& rUniqueID ); ~GraphicObject(); diff --git a/svtools/qa/unit/GraphicObjectTest.cxx b/svtools/qa/unit/GraphicObjectTest.cxx index 43cf3b7..7d93874 100644 --- a/svtools/qa/unit/GraphicObjectTest.cxx +++ b/svtools/qa/unit/GraphicObjectTest.cxx @@ -293,7 +293,7 @@ void GraphicObjectTest::testTdf88935() // Create and remove some copy of the first image for( int i = 0; i < 50; ++i ) { -GraphicObject aGraphObj3(*pGraphObj1, >GetGraphicManager()); +GraphicObject aGraphObj3(*pGraphObj1); CPPUNIT_ASSERT(aGraphObj3.SwapOut()); CPPUNIT_ASSERT(aGraphObj3.SwapIn()); } diff --git a/svtools/source/graphic/grfmgr.cxx b/svtools/source/graphic/grfmgr.cxx index 2fde691..0b04656 100644 --- a/svtools/source/graphic/grfmgr.cxx +++ b/svtools/source/graphic/grfmgr.cxx @@ -90,7 +90,7 @@ GraphicObject::GraphicObject( const Graphic& rGraphic ) : ImplSetGraphicManager( nullptr ); } -GraphicObject::GraphicObject( const GraphicObject& rGraphicObj, const GraphicManager* pMgr ) : +GraphicObject::GraphicObject( const GraphicObject& rGraphicObj ) : maGraphic ( rGraphicObj.GetGraphic() ), maAttr ( rGraphicObj.maAttr ), maLink ( rGraphicObj.maLink ), @@ -98,7 +98,7 @@ GraphicObject::GraphicObject( const GraphicObject& rGraphicObj, const GraphicMan { ImplConstruct(); ImplAssignGraphicData(); -ImplSetGraphicManager( pMgr, nullptr, ); +ImplSetGraphicManager( nullptr, nullptr, ); if( rGraphicObj.HasUserData() && rGraphicObj.IsSwappedOut() ) SetSwapState(); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 86163] use form control states as condition for conditional text
https://bugs.documentfoundation.org/show_bug.cgi?id=86163 Jérômechanged: What|Removed |Added CC||jerome.bo...@wanadoo.fr --- Comment #3 from Jérôme --- Created attachment 130287 --> https://bugs.documentfoundation.org/attachment.cgi?id=130287=edit an example This bug still occur on 5.2.4.2 from Debian binary packages (GNU/Linux x86_64) that I downloaded from http://www.libreoffice.org/download/libreoffice-fresh/ . I attached an example. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-0' - loleaflet/src
loleaflet/src/map/handler/Map.Keyboard.js | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) New commits: commit af53438aeda514c74b17cebcc9a879a64f49d9df Author: Pranav KantDate: Thu Jan 5 13:13:20 2017 +0530 loleaflet: Don't forward shift+insert/delete key events This are converted to 'cut', 'paste' events which are automatically handled by us using uno commands, so avoid double-handling them. Change-Id: If97e9f4efabbb929e7a5dd87c1228ee6a0df9e61 (cherry picked from commit 5374b6c6ff440b4016f393557b8e8846481a1355) Reviewed-on: https://gerrit.libreoffice.org/32883 Reviewed-by: Andras Timar Tested-by: Andras Timar diff --git a/loleaflet/src/map/handler/Map.Keyboard.js b/loleaflet/src/map/handler/Map.Keyboard.js index 9422a9b..0da5e09 100644 --- a/loleaflet/src/map/handler/Map.Keyboard.js +++ b/loleaflet/src/map/handler/Map.Keyboard.js @@ -119,7 +119,7 @@ L.Map.Keyboard = L.Handler.extend({ 222 : null // single quote : UNKOWN }, - handleOnKeyDown: { + handleOnKeyDownKeys: { // these keys need to be handled on keydown in order for them // to work on chrome 8 : true, // backspace @@ -180,6 +180,19 @@ L.Map.Keyboard = L.Handler.extend({ this._map.off('compositionstart compositionupdate compositionend textInput', this._onKeyDown, this); }, + _handleOnKeyDown: function (keyCode, modifier) { + if (modifier & this.keyModifier.shift) { + // don't handle shift+insert, shift+delete + // These are converted to 'cut', 'paste' events which are + // automatically handled by us, so avoid double-handling + if (keyCode === 45 || keyCode === 46) { + return false; + } + } + + return this.handleOnKeyDownKeys[keyCode]; + }, + _setPanOffset: function (pan) { var keys = this._panKeys = {}, codes = this.navigationKeyCodes, @@ -295,12 +308,12 @@ L.Map.Keyboard = L.Handler.extend({ this._keyHandled = false; this._bufferedTextInputEvent = null; - if (this.handleOnKeyDown[keyCode] && charCode === 0) { + if (this._handleOnKeyDown(keyCode, this.modifier) && charCode === 0) { docLayer._postKeyboardEvent('input', charCode, unoKeyCode); } } else if ((e.type === 'keypress' || e.type === 'compositionend') && - (!this.handleOnKeyDown[keyCode] || charCode !== 0)) { +(!this._handleOnKeyDown(keyCode, this.modifier) || charCode !== 0)) { if (charCode === keyCode && charCode !== 13) { // Chrome sets keyCode = charCode for printable keys // while LO requires it to be 0 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f25f434be3c4a4f873b00b800f64934c3ab6cf9c Author: Andras TimarDate: Mon Jan 9 21:17:25 2017 +0100 change version to 'master' Change-Id: Ic842f811e86d3d910226fcd07ec44981917b8303 diff --git a/configure.ac b/configure.ac index 386fe3a..b029d53 100644 --- a/configure.ac +++ b/configure.ac @@ -3,7 +3,7 @@ AC_PREREQ([2.69]) -AC_INIT([loolwsd], [2.0.1+], [libreoffice@lists.freedesktop.org]) +AC_INIT([loolwsd], [master], [libreoffice@lists.freedesktop.org]) LT_INIT([shared, disable-static, dlopen]) AM_INIT_AUTOMAKE([1.11 silent-rules subdir-objects tar-pax]) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: rsc/source
rsc/source/rscpp/cpp1.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit aecd984ad1c0dc29e15891bca227a96aedbde154 Author: Stephan BergmannDate: Mon Jan 9 21:14:57 2017 +0100 loplugin:externvar Change-Id: Icaa7d1f10aafbb1b143252eca565f332eb040e82 diff --git a/rsc/source/rscpp/cpp1.c b/rsc/source/rscpp/cpp1.c index f277b6b..4724b53 100644 --- a/rsc/source/rscpp/cpp1.c +++ b/rsc/source/rscpp/cpp1.c @@ -25,7 +25,7 @@ #include "cpp.h" FILE* pCppOut = NULL; -FILE* pCppIn = NULL; +static FILE* pCppIn = NULL; #if OSL_DEBUG_LEVEL > 1 FILE* pDefOut = NULL; /* ER evtl. #define's dump */ @@ -187,7 +187,7 @@ char* magic[] = static char* sharpfilename = NULL; -int nRunde = 0; +static int nRunde = 0; void InitCpp1() { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits