[Libreoffice-bugs] [Bug 105433] UI - Tooltip flickers annoyingly in Basic Macro Organizer dialog when overlaid over the Basic Macros dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=105433 Alex Thurgoodchanged: What|Removed |Added OS|All |Mac OS X (All) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105433] UI - Tooltip flickers annoyingly in Basic Macro Organizer dialog when overlaid over the Basic Macros dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=105433 Alex Thurgoodchanged: What|Removed |Added Summary|Tooltip flickers annoyingly |UI - Tooltip flickers |in Basic Macro Organizer|annoyingly in Basic Macro |dialog when overlaid over |Organizer dialog when |the Basic Macros dialog |overlaid over the Basic ||Macros dialog -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105433] New: Tooltip flickers annoyingly in Basic Macro Organizer dialog when overlaid over the Basic Macros dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=105433 Bug ID: 105433 Summary: Tooltip flickers annoyingly in Basic Macro Organizer dialog when overlaid over the Basic Macros dialog Product: LibreOffice Version: 5.4.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ipla...@tuta.io Description: The tooltip "List the existing macros and dialogs" flickers rapidly and annoyingly (my guess is at the refresh rate of the screen) when the Basic Macro Organizer dialog is overlaid over the Basic Macros dialog. As this is the default when the dialog is opened, it is particularly distracting and annoying. Steps to Reproduce: 1. Start LibreOffice, open a Writer document. 2. Tools > Macros > Organize Macros > LibreOffice Basic 3. Click on the Organizer button Actual Results: As the mouse cursor moves over any of the libraries, the tooltip is displayed and it flickers annoyingly. The flicker disappears if the dialog window is moved outside of the Basic Macros dialog window Expected Results: The tooltip should not flicker. Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:50.0) Gecko/20100101 Firefox/50.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105386] Libre Office Basic Macro Organizer crashing
https://bugs.documentfoundation.org/show_bug.cgi?id=105386 --- Comment #3 from peter--- Create new empty Calc document Go To Tools->Macros->Organize Macros->LibreOffice Basic Click on "Organizer" With "New" create new module "Module1" in current spreadsheet (Writer the same) Module stays empty. Grab the new "Module1" and start (!!!) to move it: Crash Same with Writer, same with existing documents with real basic code. Same with organizing dialogs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] help.git: 2 commits - source/text
source/text/shared/01/02100300.xhp | 10 +++--- source/text/shared/autopi/01040200.xhp | 13 +++-- 2 files changed, 10 insertions(+), 13 deletions(-) New commits: commit aab4216ec1ca25cc74e70f5cacb2294cbcfc3143 Author: Gabor KelemenDate: Wed Jan 18 23:58:40 2017 +0100 Fix ahelps on Agenda Wizards second page Change-Id: I42b1cd1af416d1a046c3ebdd5aa1c883a9773667 Reviewed-on: https://gerrit.libreoffice.org/33290 Reviewed-by: Gabor Kelemen Tested-by: Gabor Kelemen diff --git a/source/text/shared/autopi/01040200.xhp b/source/text/shared/autopi/01040200.xhp index abb48d3..90884a0 100644 --- a/source/text/shared/autopi/01040200.xhp +++ b/source/text/shared/autopi/01040200.xhp @@ -36,17 +36,18 @@ - + Date -Specifies the date of the meeting. - +Specifies the date of the meeting. + Time -Specifies the time of the meeting. +Specifies the time of the meeting. + Title Specifies the title of the meeting. - + Location -Specifies the location of the meeting. +Specifies the location of the meeting. Go to Agenda Wizard - Headings to include commit 996d21944854229aea03609e69302bfb08ca1701 Author: Gabor Kelemen Date: Wed Jan 18 23:24:46 2017 +0100 Fix Text Format (Search) page Correct bookmarks and ahelps Remove duplicate content and old comments Remove unnecessary switch from around the whole content Change-Id: I57a1ce99ea6509e321a8364c6d3dd1dd9c2cbc4d Reviewed-on: https://gerrit.libreoffice.org/33288 Reviewed-by: Gabor Kelemen Tested-by: Gabor Kelemen diff --git a/source/text/shared/01/02100300.xhp b/source/text/shared/01/02100300.xhp index 092718c..f5065e3 100644 --- a/source/text/shared/01/02100300.xhp +++ b/source/text/shared/01/02100300.xhp @@ -29,9 +29,9 @@ - -UFI: why is this switched? would look very poor for other contextsmw transferred all 6 index entries to Writer guide "finding.xhp"Text Format (Search) -Finds specific text formatting features, such as font types, font effects, and text flow characteristics. + +Text Format (Search) +Finds specific text formatting features, such as font types, font effects, and text flow characteristics. @@ -50,10 +50,6 @@ - -had to copy extended help to outside of switch construct - see issue 72448 - -Finds specific text formatting features, such as font types, font effects, and text flow characteristics. Attributes ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 41ef8d6df116c72f81bfa19c8e067a412c7f46db Author: Gabor KelemenDate: Wed Jan 18 23:58:40 2017 +0100 Updated core Project: help aab4216ec1ca25cc74e70f5cacb2294cbcfc3143 Fix ahelps on Agenda Wizards second page Change-Id: I42b1cd1af416d1a046c3ebdd5aa1c883a9773667 Reviewed-on: https://gerrit.libreoffice.org/33290 Reviewed-by: Gabor Kelemen Tested-by: Gabor Kelemen diff --git a/helpcontent2 b/helpcontent2 index 996d219..aab4216 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 996d21944854229aea03609e69302bfb08ca1701 +Subproject commit aab4216ec1ca25cc74e70f5cacb2294cbcfc3143 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 06c64259e6bcdc802c78d65435ce6aa1530f7ecd Author: Gabor KelemenDate: Wed Jan 18 23:24:46 2017 +0100 Updated core Project: help 996d21944854229aea03609e69302bfb08ca1701 Fix Text Format (Search) page Correct bookmarks and ahelps Remove duplicate content and old comments Remove unnecessary switch from around the whole content Change-Id: I57a1ce99ea6509e321a8364c6d3dd1dd9c2cbc4d Reviewed-on: https://gerrit.libreoffice.org/33288 Reviewed-by: Gabor Kelemen Tested-by: Gabor Kelemen diff --git a/helpcontent2 b/helpcontent2 index b37cd46..996d219 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit b37cd461191a0a5912383081989d834852ade6c2 +Subproject commit 996d21944854229aea03609e69302bfb08ca1701 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 105427] : trendline formula wrong for second degree polynomial approximation
https://bugs.documentfoundation.org/show_bug.cgi?id=105427 --- Comment #3 from andi--- one of the later Libre Office calc versions (5.1.6.2) shows the same bug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105386] Libre Office Basic Macro Organizer crashing
https://bugs.documentfoundation.org/show_bug.cgi?id=105386 --- Comment #2 from Alex Thurgood--- Please also provide step by step instructions on how to reproduce this behaviour. I have tried opening the Macro manager and can't seem to drag any macro, let alone a module, from one library to another under MyMacros. Version: 5.4.0.0.alpha0+ Build ID: f42a049f1235cc3fab3e441fc977c553e3e10e31 CPU Threads: 2; OS Version: Mac OS X 10.12.2; UI Render: default; Locale: fr-FR (fr_FR.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105386] Libre Office Basic Macro Organizer crashing
https://bugs.documentfoundation.org/show_bug.cgi?id=105386 Alex Thurgoodchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Alex Thurgood --- Peter : please provide a more detailed explanation with reproducible behaviour. Which module are you dragging from which library to where ? Is this your own macro or are you seeing the problem with macros (LO system macros) already provided ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105393] Enhancement request: Inserting protected spaces by autocorrect without additional spaces
https://bugs.documentfoundation.org/show_bug.cgi?id=105393 Alex Thurgoodchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 OS|All |Mac OS X (All) --- Comment #1 from Alex Thurgood --- @Georg : please indicate which version of LibreOffice you are using. Also please indicate which locale/language you have on your system, and which language you are using in LibreOffice when you type. I am assuming that you are using German, but would be nice to have confirmation. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42346] FILESAVE: Cross-references to certain numbered items (object, graphic, table) turn to plain text on export to .doc or .docx ( works OK for headings and bookmarks)
https://bugs.documentfoundation.org/show_bug.cgi?id=42346 --- Comment #73 from andis.lazd...@gmail.com --- "Celebrating" another anniversary of this "forever new" bug I would like to ask if somebody has found any applicable workaround for maintaining cross-references when exporting to doc and docx? I don't know how time consuming is elaboration of the solution or at least workaround, which can be used with existing and new documents, but if it is reasonable I can support financially development of the solution, if there are any volunteers. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105393] Enhancement request: Inserting protected spaces by autocorrect without additional spaces
https://bugs.documentfoundation.org/show_bug.cgi?id=105393 Alex Thurgoodchanged: What|Removed |Added OS|Mac OS X (All) |All -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105393] Enhancement request: Inserting protected spaces by autocorrect without additional spaces
https://bugs.documentfoundation.org/show_bug.cgi?id=105393 Alex Thurgoodchanged: What|Removed |Added Summary|Enhancement request:|Enhancement request: |Inserting protected spaces |Inserting protected spaces |by autocorrect without |by autocorrect without |editional spaces|additional spaces -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93073] Add the ability to bookmark or comment spelling/ grammar mistakes in text from spellcheck dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=93073 --- Comment #8 from shelagh.man...@gmail.com --- Comments for spelling for grammar points seem to me to be most useful in a long document where might not be able to see the context of the fragment and lose its place in the document. Would you have a spreadsheet where you would lose the context and I wonder if a presentation is long enough to lose your context for spelling it is probably too long for a presentation. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sax/source
sax/source/fastparser/fastparser.cxx |4 1 file changed, 4 insertions(+) New commits: commit 18ae77a065cb8ae6940d4067f6ab7e99a3f74047 Author: Mike KaganskiDate: Wed Jan 18 10:16:14 2017 +0300 Also consider saved exceptions when mbEnableThreads is true Previously, saved exceptions are only checked in FastSaxParserImpl::parse(), which is used in case mbEnableThreads is false (when data in input stream is no more than 1). This patch also enables the same check for the other case. Change-Id: Ie718556b7c01322e30698515ecd331b7ebad4105 Reviewed-on: https://gerrit.libreoffice.org/33249 Reviewed-by: Mike Kaganski Tested-by: Mike Kaganski diff --git a/sax/source/fastparser/fastparser.cxx b/sax/source/fastparser/fastparser.cxx index 03ea471..420f8c7 100644 --- a/sax/source/fastparser/fastparser.cxx +++ b/sax/source/fastparser/fastparser.cxx @@ -811,6 +811,10 @@ void FastSaxParserImpl::parseStream(const InputSource& maStructSource) } while (!done); xParser->join(); deleteUsedEvents(); + +// callbacks used inside XML_Parse may have caught an exception +if( rEntity.maSavedException.hasValue() ) +rEntity.throwException( mxDocumentLocator, true ); } else { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/sfx2 sfx2/inc sfx2/source writerfilter/source
include/sfx2/objsh.hxx |6 ++ sfx2/inc/doc.hrc|6 +- sfx2/source/doc/doc.src | 15 +++ sfx2/source/doc/objmisc.cxx | 20 writerfilter/source/ooxml/OOXMLDocumentImpl.cxx | 10 +++--- 5 files changed, 53 insertions(+), 4 deletions(-) New commits: commit a2ad27a2be429c6d17ef28c28ac5aee66ad8545d Author: Mike KaganskiDate: Mon Jan 16 21:25:25 2017 +0300 tdf#104718: Prompt user to continue on SAXException Change-Id: Ib0f9a89c670f8d513ebee206a6a1487802f901ff Reviewed-on: https://gerrit.libreoffice.org/33181 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/include/sfx2/objsh.hxx b/include/sfx2/objsh.hxx index bf69c21..7a2e133 100644 --- a/include/sfx2/objsh.hxx +++ b/include/sfx2/objsh.hxx @@ -213,6 +213,9 @@ private: boolbIsInGenerateThumbnail; //optimize thumbnail generate and store procedure to improve odt saving performance, i120030 boolmbAvoidRecentDocs; ///< Avoid adding to the recent documents list, if not necessary. +enum TriState {undefined, yes, no}; +TriStatembContinueImportOnFilterExceptions = undefined; // try to import as much as possible + boolCloseInternal(); SAL_DLLPRIVATE void UpdateTime_Impl(const css::uno::Reference< @@ -458,6 +461,9 @@ public: /// Don't add to the recent documents - it's an expensive operation, sometimes it is not wanted. voidAvoidRecentDocs(bool bAvoid) { mbAvoidRecentDocs = bAvoid; } +/// On first error ask user if import should continue; return saved answer. +boolIsContinueImportOnFilterExceptions(const OUString& aErrMessage); + // Transfer IFace boolIsAbortingImport() const; voidFinishedLoading( SfxLoadedFlags nWhich = SfxLoadedFlags::ALL ); diff --git a/sfx2/inc/doc.hrc b/sfx2/inc/doc.hrc index 388cdf6..29e4f66 100644 --- a/sfx2/inc/doc.hrc +++ b/sfx2/inc/doc.hrc @@ -127,8 +127,12 @@ #define STR_MSG_EXPORT_SUCCESS (RID_SFX_DOC_START+170) #define STR_MSG_QUERY_COPY (RID_SFX_DOC_START+171) +#define STR_QMSG_ERROR_OPENING_FILE (RID_SFX_DOC_START+180) +#define STR_QMSG_ERROR_OPENING_FILE_DETAILS (RID_SFX_DOC_START+181) +#define STR_QMSG_ERROR_OPENING_FILE_CONTINUE (RID_SFX_DOC_START+182) + // please update to the last id -#define ACT_SFX_DOC_END STR_MSG_QUERY_COPY +#define ACT_SFX_DOC_END STR_QMSG_ERROR_OPENING_FILE_CONTINUE #if ACT_SFX_DOC_END > RID_SFX_DOC_END #error resource overflow in #line, #file #endif diff --git a/sfx2/source/doc/doc.src b/sfx2/source/doc/doc.src index 978f5e3..d607087 100644 --- a/sfx2/source/doc/doc.src +++ b/sfx2/source/doc/doc.src @@ -353,6 +353,21 @@ String STR_QMSG_SEL_TEMPLATE_DELETE Text [ en-US ] = "Do you want to delete the selected templates?"; }; +String STR_QMSG_ERROR_OPENING_FILE +{ +Text [ en-US ] = "An error occured during opening the file. This may be caused by incorrect file contents.\n"; +}; + +String STR_QMSG_ERROR_OPENING_FILE_DETAILS +{ +Text [ en-US ] = "The error details are:\n"; +}; + +String STR_QMSG_ERROR_OPENING_FILE_CONTINUE +{ +Text [ en-US ] = "\nProceeding with import may cause data loss or corruption, and application may become unstable or crash.\n\nDo you want to ignore the error and attempt to continue loading the file?"; +}; + Image IMG_ACTION_SORT { ImageBitmap = Bitmap diff --git a/sfx2/source/doc/objmisc.cxx b/sfx2/source/doc/objmisc.cxx index 806228e..36d8fac 100644 --- a/sfx2/source/doc/objmisc.cxx +++ b/sfx2/source/doc/objmisc.cxx @@ -1944,4 +1944,24 @@ void SfxObjectShell::StoreLog() } } +bool SfxObjectShell::IsContinueImportOnFilterExceptions(const OUString& aErrMessage) +{ +if (mbContinueImportOnFilterExceptions == undefined) +{ +if (Application::GetDialogCancelMode() == Application::DialogCancelMode::Off) +{ +// Ask the user to try to continue or abort loading +OUString aMessage = SfxResId(STR_QMSG_ERROR_OPENING_FILE).toString(); +if (!aErrMessage.isEmpty()) +aMessage += SfxResId(STR_QMSG_ERROR_OPENING_FILE_DETAILS).toString() + aErrMessage; +aMessage += SfxResId(STR_QMSG_ERROR_OPENING_FILE_CONTINUE).toString(); +ScopedVclPtrInstance< MessageDialog > aBox(nullptr, aMessage, VclMessageType::Question, VclButtonsType::YesNo); +mbContinueImportOnFilterExceptions = (aBox->Execute() == RET_YES) ? yes : no; +} +else +mbContinueImportOnFilterExceptions = no; +} +return mbContinueImportOnFilterExceptions == yes; +} + /*
[Libreoffice-bugs] [Bug 105154] FILESAVE: DOCX: Extra page displayed in MSO Word after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=105154 Justin Lchanged: What|Removed |Added Keywords|bibisected, bisected, | |regression | Version|5.3.0.0.alpha1+ |3.5.0 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 3 commits - include/sfx2 linguistic/source sfx2/source
include/sfx2/tbxctrl.hxx| 12 ++-- linguistic/source/dlistimp.cxx | 38 ++ linguistic/source/dlistimp.hxx | 14 +- sfx2/source/toolbox/tbxitem.cxx | 10 ++ sfx2/source/view/viewsh.cxx | 19 --- 5 files changed, 39 insertions(+), 54 deletions(-) New commits: commit 70b05273c91cfec0cd7a9a54ff993c5b7f808d4f Author: Noel GrandinDate: Wed Jan 18 15:38:59 2017 +0200 use rtl::Reference in AsyncExecuteInfo instead of storing both a raw pointer and an uno::Reference Change-Id: Ia52aae8b3894813c4169772eb4cf89ae7df0003a diff --git a/sfx2/source/view/viewsh.cxx b/sfx2/source/view/viewsh.cxx index 91e1c28..04e600f 100644 --- a/sfx2/source/view/viewsh.cxx +++ b/sfx2/source/view/viewsh.cxx @@ -124,12 +124,11 @@ public: struct AsyncExecuteInfo { -AsyncExecuteInfo( AsyncExecuteCmd eCmd, uno::Reference< datatransfer::clipboard::XClipboardListener > const & xThis, SfxClipboardChangeListener* pListener ) : -m_eCmd( eCmd ), m_xThis( xThis ), m_pListener( pListener ) {} +AsyncExecuteInfo( AsyncExecuteCmd eCmd, SfxClipboardChangeListener* pListener ) : +m_eCmd( eCmd ), m_xListener( pListener ) {} AsyncExecuteCmd m_eCmd; -uno::Reference< datatransfer::clipboard::XClipboardListener > m_xThis; -SfxClipboardChangeListener* m_pListener; +rtl::Reference m_xListener; }; private: @@ -173,13 +172,12 @@ IMPL_STATIC_LINK( SfxClipboardChangeListener, AsyncExecuteHdl_Impl, void*, p, vo AsyncExecuteInfo* pAsyncExecuteInfo = static_cast (p); if ( pAsyncExecuteInfo ) { -uno::Reference< datatransfer::clipboard::XClipboardListener > xThis( pAsyncExecuteInfo->m_xThis ); -if ( pAsyncExecuteInfo->m_pListener ) +if ( pAsyncExecuteInfo->m_xListener.is() ) { if ( pAsyncExecuteInfo->m_eCmd == ASYNCEXECUTE_CMD_DISPOSING ) -pAsyncExecuteInfo->m_pListener->DisconnectViewShell(); +pAsyncExecuteInfo->m_xListener->DisconnectViewShell(); else if ( pAsyncExecuteInfo->m_eCmd == ASYNCEXECUTE_CMD_CHANGEDCONTENTS ) -pAsyncExecuteInfo->m_pListener->ChangedContents(); +pAsyncExecuteInfo->m_xListener->ChangedContents(); } } delete pAsyncExecuteInfo; @@ -201,7 +199,7 @@ void SAL_CALL SfxClipboardChangeListener::disposing( const lang::EventObject& /* // Make asynchronous call to avoid locking SolarMutex which is the // root for many deadlocks, especially in conjunction with the "Windows" // based single thread apartment clipboard code! -AsyncExecuteInfo* pInfo = new AsyncExecuteInfo( ASYNCEXECUTE_CMD_DISPOSING, xThis, this ); +AsyncExecuteInfo* pInfo = new AsyncExecuteInfo( ASYNCEXECUTE_CMD_DISPOSING, this ); Application::PostUserEvent( LINK( nullptr, SfxClipboardChangeListener, AsyncExecuteHdl_Impl ), pInfo ); } @@ -211,8 +209,7 @@ void SAL_CALL SfxClipboardChangeListener::changedContents( const datatransfer::c // Make asynchronous call to avoid locking SolarMutex which is the // root for many deadlocks, especially in conjunction with the "Windows" // based single thread apartment clipboard code! -uno::Reference< datatransfer::clipboard::XClipboardListener > xThis( static_cast< datatransfer::clipboard::XClipboardListener* >( this )); -AsyncExecuteInfo* pInfo = new AsyncExecuteInfo( ASYNCEXECUTE_CMD_CHANGEDCONTENTS, xThis, this ); +AsyncExecuteInfo* pInfo = new AsyncExecuteInfo( ASYNCEXECUTE_CMD_CHANGEDCONTENTS, this ); Application::PostUserEvent( LINK( nullptr, SfxClipboardChangeListener, AsyncExecuteHdl_Impl ), pInfo ); } commit 5288ae5912d6c76cfb80a68025b3af4ba6045c6b Author: Noel Grandin Date: Wed Jan 18 15:16:02 2017 +0200 use rtl::Reference in DicList instead of storing both a raw pointer and a uno::Reference Change-Id: I34bce1c6b3875fbb0dc56fefb79eb6b16f9818dd diff --git a/linguistic/source/dlistimp.cxx b/linguistic/source/dlistimp.cxx index f869630..19caeb9 100644 --- a/linguistic/source/dlistimp.cxx +++ b/linguistic/source/dlistimp.cxx @@ -269,19 +269,17 @@ void DicList::MyAppExitListener::AtExit() DicList::DicList() : aEvtListeners ( GetLinguMutex() ) { -pDicEvtLstnrHelper = new DicEvtListenerHelper( this ); -xDicEvtLstnrHelper = pDicEvtLstnrHelper; +mxDicEvtLstnrHelper = new DicEvtListenerHelper( this ); bDisposing = false; bInCreation = false; -pExitListener = new MyAppExitListener( *this ); -xExitListener = pExitListener; -pExitListener->Activate(); +mxExitListener = new MyAppExitListener( *this ); +mxExitListener->Activate(); } DicList::~DicList() { -pExitListener->Deactivate(); +mxExitListener->Deactivate(); } @@ -434,7
[Libreoffice-bugs] [Bug 105373] FILEOPEN: Broken view of docx
https://bugs.documentfoundation.org/show_bug.cgi?id=105373 Justin Lchanged: What|Removed |Added Attachment #130481|0 |1 is obsolete|| --- Comment #7 from Justin L --- Created attachment 130545 --> https://bugs.documentfoundation.org/attachment.cgi?id=130545=edit bug2.pdf: pdf from word2007 showing the expected output OP was given this PDF by his colleague along with the .docx. P.S. The "roughly expected output" in comment 1 has the picture order reversed. The mouse should be on the left, and the church on the right. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105373] FILEOPEN: Broken view of docx
https://bugs.documentfoundation.org/show_bug.cgi?id=105373 Justin Lchanged: What|Removed |Added Attachment #130480|0 |1 is obsolete|| --- Comment #6 from Justin L --- Created attachment 130544 --> https://bugs.documentfoundation.org/attachment.cgi?id=130544=edit bug.docx: word 2007 generated file. Replaces original because we have a PDF and it looks good in Word. OP is receiving .docx files from a colleague, so those are the true source documents. Since he doesn't have Word, he needs to open them with LO. The top portion of the document is what the complaint is about, and this version of the document contains the same complicated mess of table, textbox, picture anchors, paragraph indents as the original submission. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: chart2/source filter/source include/svl sd/source svl/source sw/source
chart2/source/controller/main/ShapeController.cxx |2 -- filter/source/msfilter/svdfppt.cxx|2 -- include/svl/itemset.hxx |2 +- sd/source/core/drawdoc.cxx|1 - sd/source/ui/func/futempl.cxx |1 - svl/source/items/itemprop.cxx |5 - sw/source/uibase/shells/annotsh.cxx |4 7 files changed, 1 insertion(+), 16 deletions(-) New commits: commit afaa10da25729f2aa5ca7df86d6bbea83d45cccf Author: Noel GrandinDate: Wed Jan 18 16:04:17 2017 +0200 make SfxItemSet with SAL_WARN_UNUSED Change-Id: Ia74ca329d8438f614169031acfbe0406faf7c281 Reviewed-on: https://gerrit.libreoffice.org/33268 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/chart2/source/controller/main/ShapeController.cxx b/chart2/source/controller/main/ShapeController.cxx index 8c68892..58b70e6bf 100644 --- a/chart2/source/controller/main/ShapeController.cxx +++ b/chart2/source/controller/main/ShapeController.cxx @@ -303,8 +303,6 @@ void ShapeController::executeDispatch_FormatArea() pFact->CreateSvxAreaTabDialog( pParent, , >getSdrModel(), true ) ); if ( pDlg.get() ) { -SfxItemPool& rItemPool = pDrawViewWrapper->GetModel()->GetItemPool(); -SfxItemSet aSet( rItemPool, rItemPool.GetFirstWhich(), rItemPool.GetLastWhich() ); if ( pDlg->Execute() == RET_OK ) { const SfxItemSet* pOutAttr = pDlg->GetOutputItemSet(); diff --git a/filter/source/msfilter/svdfppt.cxx b/filter/source/msfilter/svdfppt.cxx index aa5f8d4..af09b9d 100644 --- a/filter/source/msfilter/svdfppt.cxx +++ b/filter/source/msfilter/svdfppt.cxx @@ -7423,7 +7423,6 @@ void ApplyCellAttributes( const SdrObject* pObj, Reference< XCell >& xCell ) {//vertical writing xPropSet->setPropertyValue( "TextWritingMode" , Any( css::text::WritingMode_TB_RL ) ); } -SfxItemSet aSet( pObj->GetMergedItemSet() ); drawing::FillStyle eFillStyle(static_cast(pObj->GetMergedItem( XATTR_FILLSTYLE )).GetValue()); css::drawing::FillStyle eFS( css::drawing::FillStyle_NONE ); switch( eFillStyle ) @@ -7503,7 +7502,6 @@ void ApplyCellLineAttributes( const SdrObject* pLine, Reference< XTable >& xTabl { try { -SfxItemSet aSet( pLine->GetMergedItemSet() ); drawing::LineStyle eLineStyle(static_cast(pLine->GetMergedItem( XATTR_LINESTYLE )).GetValue()); css::table::BorderLine2 aBorderLine; switch( eLineStyle ) diff --git a/include/svl/itemset.hxx b/include/svl/itemset.hxx index 502c0eb..8c1ebd5 100644 --- a/include/svl/itemset.hxx +++ b/include/svl/itemset.hxx @@ -31,7 +31,7 @@ class SvStream; typedef std::map SfxItemMap; -class SVL_DLLPUBLIC SfxItemSet +class SAL_WARN_UNUSED SVL_DLLPUBLIC SfxItemSet { friend class SfxItemIter; diff --git a/sd/source/core/drawdoc.cxx b/sd/source/core/drawdoc.cxx index df8afd1..3868bd8 100644 --- a/sd/source/core/drawdoc.cxx +++ b/sd/source/core/drawdoc.cxx @@ -301,7 +301,6 @@ SdDrawDocument::SdDrawDocument(DocumentType eType, SfxObjectShell* pDrDocSh) // Set the StyleSheetPool for HitTestOutliner. // The link to the StyleRequest handler of the document is set later, in // NewOrLoadCompleted, because only then do all the templates exist. -SfxItemSet aSet2( pHitTestOutliner->GetEmptyItemSet() ); pHitTestOutliner->SetStyleSheetPool( static_cast (GetStyleSheetPool()) ); SetCalcFieldValueHdl( pHitTestOutliner ); diff --git a/sd/source/ui/func/futempl.cxx b/sd/source/ui/func/futempl.cxx index 33d8a0e..bd97800 100644 --- a/sd/source/ui/func/futempl.cxx +++ b/sd/source/ui/func/futempl.cxx @@ -299,7 +299,6 @@ void FuTemplate::DoExecute( SfxRequest& rReq ) ScopedVclPtr pPresDlg; SdAbstractDialogFactory* pFact = SdAbstractDialogFactory::Create(); bool bOldDocInOtherLanguage = false; -SfxItemSet aOriSet( pStyleSheet->GetItemSet() ); SfxStyleFamily eFamily = pStyleSheet->GetFamily(); diff --git a/svl/source/items/itemprop.cxx b/svl/source/items/itemprop.cxx index e6ac2ed..7066996 100644 --- a/svl/source/items/itemprop.cxx +++ b/svl/source/items/itemprop.cxx @@ -234,11 +234,6 @@ void SfxItemPropertySet::setPropertyValue( const SfxItemPropertySimpleEntry& rEn SfxItemState eState = rSet.GetItemState( rEntry.nWID, true, ); if (SfxItemState::SET != eState && SfxItemPool::IsWhich(rEntry.nWID)) pItem = ()->GetDefaultItem(rEntry.nWID); -//maybe there's another way to find an Item -if(eState < SfxItemState::DEFAULT) -{ -SfxItemSet
[Libreoffice-commits] core.git: svgio/inc svgio/source
svgio/inc/svganode.hxx |7 --- svgio/inc/svgcirclenode.hxx|7 --- svgio/inc/svgclippathnode.hxx |7 --- svgio/inc/svgellipsenode.hxx |7 --- svgio/inc/svggnode.hxx |7 --- svgio/inc/svggradientnode.hxx |3 ++- svgio/inc/svgimagenode.hxx |8 +--- svgio/inc/svglinenode.hxx |7 --- svgio/inc/svgmarkernode.hxx|8 +--- svgio/inc/svgmasknode.hxx |8 +--- svgio/inc/svgrectnode.hxx |7 --- svgio/inc/svgsvgnode.hxx |8 +--- svgio/inc/svgsymbolnode.hxx|6 -- svgio/inc/svgtextnode.hxx |8 +--- svgio/inc/svgusenode.hxx |8 +--- svgio/source/svgreader/svganode.cxx|1 - svgio/source/svgreader/svgcirclenode.cxx |1 - svgio/source/svgreader/svgclippathnode.cxx |1 - svgio/source/svgreader/svgellipsenode.cxx |1 - svgio/source/svgreader/svggnode.cxx|1 - svgio/source/svgreader/svggradientnode.cxx | 11 +++ svgio/source/svgreader/svgimagenode.cxx|1 - svgio/source/svgreader/svglinenode.cxx |1 - svgio/source/svgreader/svgmarkernode.cxx |1 - svgio/source/svgreader/svgmasknode.cxx |1 - svgio/source/svgreader/svgrectnode.cxx |1 - svgio/source/svgreader/svgsvgnode.cxx |1 - svgio/source/svgreader/svgsymbolnode.cxx |1 - svgio/source/svgreader/svgtextnode.cxx |1 - svgio/source/svgreader/svgusenode.cxx |1 - 30 files changed, 67 insertions(+), 64 deletions(-) New commits: commit 2da34e265db6ca56e43d9b2ab8cee04b1cc4fb29 Author: Noel GrandinDate: Wed Jan 18 09:48:47 2017 +0200 new loplugin: useuniqueptr: svgio Change-Id: I645ac954ac519fe713f4347cdf69780b0f8070e4 Reviewed-on: https://gerrit.libreoffice.org/33252 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/svgio/inc/svganode.hxx b/svgio/inc/svganode.hxx index 1f5774a..b7660a0 100644 --- a/svgio/inc/svganode.hxx +++ b/svgio/inc/svganode.hxx @@ -22,6 +22,7 @@ #include #include +#include namespace svgio { @@ -34,7 +35,7 @@ namespace svgio SvgStyleAttributes maSvgStyleAttributes; /// variable scan values, dependent of given XAttributeList -basegfx::B2DHomMatrix* mpaTransform; +std::unique_ptr mpaTransform; public: SvgANode( @@ -47,8 +48,8 @@ namespace svgio virtual void decomposeSvgNode(drawinglayer::primitive2d::Primitive2DContainer& rTarget, bool bReferenced) const override; /// transform content -const basegfx::B2DHomMatrix* getTransform() const { return mpaTransform; } -void setTransform(const basegfx::B2DHomMatrix* pMatrix) { if(mpaTransform) delete mpaTransform; mpaTransform = nullptr; if(pMatrix) mpaTransform = new basegfx::B2DHomMatrix(*pMatrix); } +const basegfx::B2DHomMatrix* getTransform() const { return mpaTransform.get(); } +void setTransform(const basegfx::B2DHomMatrix* pMatrix) { mpaTransform.reset(); if(pMatrix) mpaTransform.reset( new basegfx::B2DHomMatrix(*pMatrix) ); } }; } // end of namespace svgreader } // end of namespace svgio diff --git a/svgio/inc/svgcirclenode.hxx b/svgio/inc/svgcirclenode.hxx index cd19de4..68fc3e9 100644 --- a/svgio/inc/svgcirclenode.hxx +++ b/svgio/inc/svgcirclenode.hxx @@ -22,6 +22,7 @@ #include #include +#include namespace svgio { @@ -37,7 +38,7 @@ namespace svgio SvgNumber maCx; SvgNumber maCy; SvgNumber maR; -basegfx::B2DHomMatrix* mpaTransform; +std::unique_ptr mpaTransform; public: SvgCircleNode( @@ -59,8 +60,8 @@ namespace svgio const SvgNumber& getR() const { return maR; } /// transform content, set if found in current context -const basegfx::B2DHomMatrix* getTransform() const { return mpaTransform; } -void setTransform(const basegfx::B2DHomMatrix* pMatrix) { if(mpaTransform) delete mpaTransform; mpaTransform = nullptr; if(pMatrix) mpaTransform = new basegfx::B2DHomMatrix(*pMatrix); } +const basegfx::B2DHomMatrix* getTransform() const { return mpaTransform.get(); } +void setTransform(const basegfx::B2DHomMatrix* pMatrix) { mpaTransform.reset(); if(pMatrix) mpaTransform.reset( new basegfx::B2DHomMatrix(*pMatrix) ); } }; } // end of namespace svgreader } // end of namespace svgio diff --git a/svgio/inc/svgclippathnode.hxx b/svgio/inc/svgclippathnode.hxx index a273932..202fc2c
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/dapiuno.hxx |2 sc/inc/editsrc.hxx |2 sc/inc/fielduno.hxx|2 sc/inc/srchuno.hxx |5 +- sc/inc/undorangename.hxx |2 sc/source/filter/excel/excdoc.cxx |1 sc/source/filter/excel/excrecds.cxx|7 --- sc/source/filter/excel/expop2.cxx |3 - sc/source/filter/excel/frmbase.cxx |3 - sc/source/filter/excel/tokstack.cxx|3 - sc/source/filter/excel/xilink.cxx |3 - sc/source/filter/html/htmlimp.cxx |4 - sc/source/filter/html/htmlpars.cxx |2 sc/source/filter/inc/XclExpChangeTrack.hxx | 12 +++-- sc/source/filter/inc/eeimport.hxx |3 - sc/source/filter/inc/eeparser.hxx |8 +-- sc/source/filter/inc/excdoc.hxx|6 +- sc/source/filter/inc/excrecds.hxx |3 - sc/source/filter/inc/exp_op.hxx|3 - sc/source/filter/inc/expbase.hxx |3 - sc/source/filter/inc/formel.hxx|3 - sc/source/filter/inc/lotattr.hxx |8 +-- sc/source/filter/inc/namebuff.hxx |3 - sc/source/filter/inc/rtfexp.hxx|2 sc/source/filter/inc/scflt.hxx |6 -- sc/source/filter/inc/tokstack.hxx |2 sc/source/filter/inc/xilink.hxx| 12 ++--- sc/source/filter/lotus/lotattr.cxx |1 sc/source/filter/lotus/tool.cxx|3 - sc/source/filter/rtf/eeimpars.cxx |3 - sc/source/filter/rtf/expbase.cxx |3 - sc/source/filter/rtf/rtfexp.cxx|1 sc/source/filter/rtf/rtfimp.cxx|2 sc/source/filter/starcalc/scflt.cxx| 12 ++--- sc/source/filter/xcl97/XclExpChangeTrack.cxx | 24 -- sc/source/filter/xml/XMLChangeTrackingExportHelper.cxx |3 - sc/source/filter/xml/XMLChangeTrackingExportHelper.hxx |3 - sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx | 13 + sc/source/filter/xml/XMLChangeTrackingImportHelper.hxx | 10 ++-- sc/source/filter/xml/XMLStylesImportHelper.cxx |3 - sc/source/filter/xml/XMLStylesImportHelper.hxx | 16 +++--- sc/source/filter/xml/XMLTrackedChangesContext.cxx | 14 +- sc/source/filter/xml/xmlcelli.cxx |1 sc/source/filter/xml/xmlcelli.hxx |2 sc/source/filter/xml/xmldpimp.cxx |7 +-- sc/source/filter/xml/xmldpimp.hxx |4 - sc/source/ui/app/inputhdl.cxx |7 --- sc/source/ui/app/uiitems.cxx | 16 ++ sc/source/ui/docshell/dataprovider.cxx |2 sc/source/ui/docshell/pagedata.cxx |5 -- sc/source/ui/inc/dataprovider.hxx |4 - sc/source/ui/inc/inputhdl.hxx |4 - sc/source/ui/inc/pagedata.hxx |2 sc/source/ui/inc/printfun.hxx | 11 ++-- sc/source/ui/inc/uiitems.hxx | 14 +++--- sc/source/ui/inc/undobase.hxx |9 ++- sc/source/ui/inc/undoblk.hxx | 39 ++--- sc/source/ui/inc/undodat.hxx |6 +- sc/source/ui/inc/undodraw.hxx |6 +- sc/source/ui/undo/undobase.cxx |6 -- sc/source/ui/undo/undoblk.cxx | 14 +- sc/source/ui/undo/undoblk3.cxx |8 --- sc/source/ui/undo/undodat.cxx |4 - sc/source/ui/undo/undodraw.cxx |6 -- sc/source/ui/undo/undorangename.cxx|1 sc/source/ui/unoobj/dapiuno.cxx|8 +-- sc/source/ui/unoobj/editsrc.cxx|1 sc/source/ui/unoobj/fielduno.cxx | 24 +++--- sc/source/ui/unoobj/srchuno.cxx|5 -- sc/source/ui/view/printfun.cxx | 21 +++-- 70 files changed, 198 insertions(+), 263 deletions(-) New commits: commit 9767537e22e178eb23872de138ea70e57c1a6725 Author: Noel GrandinDate: Tue Jan 17 10:11:31 2017 +0200 new loplugin: useuniqueptr: sc part 2 Change-Id: I37936a297027313e2a8ae18f355567462955739e Reviewed-on:
[Libreoffice-bugs] [Bug 105432] New: libvisio: cannot define default language for imported document
https://bugs.documentfoundation.org/show_bug.cgi?id=105432 Bug ID: 105432 Summary: libvisio: cannot define default language for imported document Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Keywords: filter:visio Severity: enhancement Priority: medium Component: filters and storage Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com CC: dtar...@redhat.com, fridrich.st...@bluewin.ch Created attachment 130543 --> https://bugs.documentfoundation.org/attachment.cgi?id=130543=edit Visio doc where Russian text is imported as garbage Currently there's no way to define default language used in libvisio on importing files when an object does not define a codepage in file. Then in libvisio::VSDContentCollector::appendCharacters(), default clause sets hardcoded value "windows-1252". Can a way be added to libvisio (ant maybe other DLPs) to specify default language on init (e.g. in writerperfect::detail::ImportFilterImpl::filter() as an (optional?) argument? Then it would be possible to use LO's default document language for that purpose (and thus it would be user-controllable), like is currently done for e.g. DXF. The attachment is an VSD document which contents is in Russian, but isn't detected as such, and is imported as garbage. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98291] libvisio imports dates in USA format - does not follow preference settings
https://bugs.documentfoundation.org/show_bug.cgi?id=98291 Mike Kaganskichanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||5432 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96000] [META] Spell Checking bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=96000 Bug 96000 depends on bug 103061, which changed state. Bug 103061 Summary: Assertion failed when right-clicking an incorrectly spelled word in Writer in debug build https://bugs.documentfoundation.org/show_bug.cgi?id=103061 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103061] Assertion failed when right-clicking an incorrectly spelled word in Writer in debug build
https://bugs.documentfoundation.org/show_bug.cgi?id=103061 Aron Budeachanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Aron Budea --- Not reproduced with a few weeks old self-built dbgutil build (87fce022c65c1d2aed1ca59967137d77d936043c, 16-12-29). Setting WFM. Probably got fixed by hunspell update: https://cgit.freedesktop.org/libreoffice/core/commit/?id=d423121dba0ad19d307fe8aebfcf566a8b44dc1a 2016-12-14 update to latest hunspell 1-5 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/text/itrpaint.cxx | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) New commits: commit 7c817d73402583f1b077d31a695c565a53468887 Author: Justin LuthDate: Wed Jan 18 22:29:08 2017 +0300 tdf#35021 TAB_OVER_MARGIN pdf support for left/center/dec also related to tdf#93637 which first raised the issue of pdf support for right-tabovermargin. Change-Id: Icabe2d0ac2dfe9181edde9dadfb0ab85f9ed4402 Reviewed-on: https://gerrit.libreoffice.org/33279 Tested-by: Jenkins Reviewed-by: Justin Luth diff --git a/sw/source/core/text/itrpaint.cxx b/sw/source/core/text/itrpaint.cxx index be1b63a..76987a3 100644 --- a/sw/source/core/text/itrpaint.cxx +++ b/sw/source/core/text/itrpaint.cxx @@ -170,12 +170,15 @@ void SwTextPainter::DrawTextLine( const SwRect , SwSaveClip , SwLinePortion* pPorIter = pPor; while( pPorIter ) { -if( pPorIter->IsTabRightPortion() ) +if( pPorIter->InTabGrp() ) { - const SwTabRightPortion *pRightTabPor = static_cast (pPorIter); - const SwTwips nTabPos = nTmpLeft + pRightTabPor->GetTabPos(); + const SwTabPortion* pTabPor = static_cast (pPorIter); + const SwTwips nTabPos = nTmpLeft + pTabPor->GetTabPos(); if( nMaxRight < nTabPos ) -nMaxRight = std::min( rPaint.Right(), nTabPos ); +{ +nMaxRight = rPaint.Right(); +break; +} } pPorIter = pPorIter->GetPortion(); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 104781] FILEOPEN DOCX: Time to open file has increased compared to LibO4463
https://bugs.documentfoundation.org/show_bug.cgi?id=104781 Aron Budeachanged: What|Removed |Added Keywords|bibisectRequest |notBibisectable CC||ba...@caesar.elte.hu Version|5.4.0.0.alpha0+ Master |5.0.6.3 release --- Comment #4 from Aron Budea --- Already slow in 5.0.6.3 and 5.1.0.3 / Windows 7. Giver errors on import in 5.0.0.5. I'll go with notBibisectable. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105431] Font selection crash
https://bugs.documentfoundation.org/show_bug.cgi?id=105431 RichardBchanged: What|Removed |Added OS|All |Windows (All) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105431] New: Font selection crash
https://bugs.documentfoundation.org/show_bug.cgi?id=105431 Bug ID: 105431 Summary: Font selection crash Product: LibreOffice Version: 5.2.3.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rhbud...@dodo.com.au when font(to change font type) is selected programme crashes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103927] filter:xlsx LibreOffice crashes when importing XLSX file
https://bugs.documentfoundation.org/show_bug.cgi?id=103927 --- Comment #7 from Kohei Yoshida--- The two stacks that are not related to the DC errors. Maybe they can point us in the right direction? --- Error #70: INVALID HEAP ARGUMENT: allocated with Windows API layer, freed with C library layer # 0 replace_free [d:\drmemory_package\common\alloc_replace.c:2706] # 1 MSVCP120.dll!Cnd_destroy +0x1e (0x6361eaf9 ) # 2 comphelper.dll!std::_Ref_count_obj<>::_Destroy [c:\program files (x86)\microsoft visual studio 12.0\vc\include\memory:944] # 3 scfiltlo.dll!oox::xls::`anonymous namespace'::importSheetFragments [j:\libo\my-master\sc\source\filter\oox\workbookfragment.cxx:346] # 4 scfiltlo.dll!oox::xls::WorkbookFragment::finalizeImport [j:\libo\my-master\sc\source\filter\oox\workbookfragment.cxx:477] # 5 expwraplo.dll!sax_fastparser::FastSaxParserImpl::parseStream [j:\libo\my-master\sax\source\fastparser\fastparser.cxx:823] # 6 expwraplo.dll!sax_fastparser::FastSaxParser::parseStream [j:\libo\my-master\sax\source\fastparser\fastparser.cxx:1378] # 7 ooxlo.dll!oox::core::FastParser::parseStream [j:\libo\my-master\oox\source\core\fastparser.cxx:118] # 8 ooxlo.dll!oox::core::FastParser::parseStream [j:\libo\my-master\oox\source\core\fastparser.cxx:126] # 9 ooxlo.dll!oox::core::XmlFilterBase::importFragment [j:\libo\my-master\oox\source\core\xmlfilterbase.cxx:367] #10 ooxlo.dll!oox::core::XmlFilterBase::importFragment [j:\libo\my-master\oox\source\core\xmlfilterbase.cxx:309] #11 scfiltlo.dll!oox::xls::ExcelFilter::importDocument [j:\libo\my-master\sc\source\filter\oox\excelfilter.cxx:101] #12 ooxlo.dll!oox::core::FilterBase::filter [j:\libo\my-master\oox\source\core\filterbase.cxx:486] #13 scfiltlo.dll!oox::xls::ExcelFilter::filter [j:\libo\my-master\sc\source\filter\oox\excelfilter.cxx:155] #14 sfxlo.dll!SfxObjectShell::ImportFrom [j:\libo\my-master\sfx2\source\doc\objstor.cxx:2263] #15 sfxlo.dll!SfxObjectShell::DoLoad [j:\libo\my-master\sfx2\source\doc\objstor.cxx:764] #16 sfxlo.dll!SfxBaseModel::load [j:\libo\my-master\sfx2\source\doc\sfxbasemodel.cxx:1831] #17 sfxlo.dll!`anonymous namespace'::SfxFrameLoader_Impl::load [j:\libo\my-master\sfx2\source\view\frmload.cxx:698] #18 fwklo.dll!framework::LoadEnv::impl_loadContent [j:\libo\my-master\framework\source\loadenv\loadenv.cxx:1095] #19 fwklo.dll!framework::LoadEnv::startLoading [j:\libo\my-master\framework\source\loadenv\loadenv.cxx:377] Note: @0:03:19.666 in thread 9860 Note: memory was allocated here: Note: # 0 replace_RtlAllocateHeap [d:\drmemory_package\common\alloc_replace.c:3770] Note: # 1 MSVCR120.dll!memcmp +0x34c(0x65fa11f9 ) Note: # 2 MSVCR120.dll!calloc_crt +0x13 (0x65fa121c ) Note: # 3 MSVCP120.dll!Cnd_init +0x14 (0x6361eb12 ) Note: # 4 comphelper.dll!std::_Ref_count_obj<>::_Ref_count_obj<><> [c:\program files (x86)\microsoft visual studio 12.0\vc\include\memory:932] Note: # 5 comphelper.dll!std::make_shared<> [c:\program files (x86)\microsoft visual studio 12.0\vc\include\memory:1003] Note: # 6 comphelper.dll!comphelper::ThreadPool::createThreadTaskTag [j:\libo\my-master\comphelper\source\misc\threadpool.cxx:224] Note: # 7 scfiltlo.dll!oox::xls::`anonymous namespace'::importSheetFragments [j:\libo\my-master\sc\source\filter\oox\workbookfragment.cxx:318] Note: # 8 scfiltlo.dll!oox::xls::WorkbookFragment::finalizeImport [j:\libo\my-master\sc\source\filter\oox\workbookfragment.cxx:477] Note: # 9 expwraplo.dll!sax_fastparser::FastSaxParserImpl::parseStream [j:\libo\my-master\sax\source\fastparser\fastparser.cxx:823] Note: #10 expwraplo.dll!sax_fastparser::FastSaxParser::parseStream [j:\libo\my-master\sax\source\fastparser\fastparser.cxx:1378] Note: #11 ooxlo.dll!oox::core::FastParser::parseStream [j:\libo\my-master\oox\source\core\fastparser.cxx:118] Error #71: INVALID HEAP ARGUMENT: allocated with Windows API layer, freed with C library layer # 0 replace_free [d:\drmemory_package\common\alloc_replace.c:2706] # 1 MSVCP120.dll!Mtx_destroy +0x21 (0x6361efc8 ) # 2
[Libreoffice-bugs] [Bug 103927] filter:xlsx LibreOffice crashes when importing XLSX file
https://bugs.documentfoundation.org/show_bug.cgi?id=103927 --- Comment #6 from Kohei Yoshida--- Created attachment 130541 --> https://bugs.documentfoundation.org/attachment.cgi?id=130541=edit Dr. Memory log I ran it with Dr. Memory to see if there are any sort of invalid memory access issues during the load. This is the log. No idea how to interpret this and/or this is of any use just yet. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 2 commits - set_soenv.in sw/qa
set_soenv.in |2 +- sw/qa/complex/checkColor/CheckChangeColor.java |3 --- 2 files changed, 1 insertion(+), 4 deletions(-) New commits: commit 5cf449daa11726dc29f20f23f1e74b2564dc0551 Author: Damjan JovanovicDate: Wed Jan 18 20:59:35 2017 + Fix a main/sw subsequent test. The BackColor of a page style is irrelevant since we only want to test changing it, and it only seems to have meaning when the FillStyle is color, which it isn't. Patch by: me diff --git a/sw/qa/complex/checkColor/CheckChangeColor.java b/sw/qa/complex/checkColor/CheckChangeColor.java index 949e420..07b59bd 100644 --- a/sw/qa/complex/checkColor/CheckChangeColor.java +++ b/sw/qa/complex/checkColor/CheckChangeColor.java @@ -63,9 +63,6 @@ public class CheckChangeColor { XPropertySet xPropertySet = (XPropertySet) UnoRuntime.queryInterface(XPropertySet.class, xPageStyleCollection.getByName("Standard") ); assertEquals( -"BackColor", new Any(Type.LONG, 0x), -Any.complete(xPropertySet.getPropertyValue("BackColor"))); -assertEquals( "IsLandscape", new Any(Type.BOOLEAN, false), Any.complete(xPropertySet.getPropertyValue("IsLandscape"))); assertEquals( commit 70af00b96ab2d5914dbe06e74630fc1ffabdd4ae Author: Damjan Jovanovic Date: Wed Jan 18 20:58:11 2017 + Add a ./configure option for Hamcrest once again, this time optional, so that newer versions of JUnit can work. Patch by: me diff --git a/set_soenv.in b/set_soenv.in index 7db8d39..c79671b 100644 --- a/set_soenv.in +++ b/set_soenv.in @@ -1641,7 +1641,7 @@ ToFile( "ENABLE_PDFIMPORT", "@ENABLE_PDFIMPORT@", "e" ); ToFile( "ENABLE_REPORTBUILDER","@ENABLE_REPORTBUILDER@","e" ); ToFile( "SYSTEM_JFREEREPORT","@SYSTEM_JFREEREPORT@","e" ); ToFile( "OOO_JUNIT_JAR", "@OOO_JUNIT_JAR@","e" ); -# ToFile( "HAMCREST_CORE_JAR", "@HAMCREST_CORE_JAR@","e" ); +ToFile( "HAMCREST_CORE_JAR", "@HAMCREST_CORE_JAR@","e" ); ToFile( "SAC_JAR", "@SAC_JAR@", "e" ); ToFile( "LIBXML_JAR","@LIBXML_JAR@", "e" ); ToFile( "FLUTE_JAR", "@FLUTE_JAR@","e" ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-commits] core.git: tdf#97597: attempt to add test for multithreaded input stream buffering.
Ok. I've reverted the API part of my change. https://cgit.freedesktop.org/libreoffice/core/commit/?id=bbf40e3b5d06bd1437b097ed2703179026d1e871 Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: offapi/com package/qa
offapi/com/sun/star/packages/zip/ZipFileAccess.idl |8 --- package/qa/cppunit/test_package.cxx| 23 ++--- 2 files changed, 17 insertions(+), 14 deletions(-) New commits: commit bbf40e3b5d06bd1437b097ed2703179026d1e871 Author: Kohei YoshidaDate: Wed Jan 18 20:05:40 2017 -0500 Use the old-fashion way to instantiate a UNO service. Change-Id: Ibc5c55dbe9c4c5101ebb292696f79e4e8c8a35c5 Reviewed-on: https://gerrit.libreoffice.org/33293 Tested-by: Jenkins Reviewed-by: Kohei Yoshida diff --git a/offapi/com/sun/star/packages/zip/ZipFileAccess.idl b/offapi/com/sun/star/packages/zip/ZipFileAccess.idl index 7677c94..6d54509 100644 --- a/offapi/com/sun/star/packages/zip/ZipFileAccess.idl +++ b/offapi/com/sun/star/packages/zip/ZipFileAccess.idl @@ -23,7 +23,7 @@ #include #include #include -#include + module com { module sun { module star { module packages { module zip { @@ -38,12 +38,6 @@ service ZipFileAccess : XZipFileAccess2 com::sun::star::ucb::ContentCreationException, com::sun::star::ucb::InteractiveIOException, com::sun::star::packages::zip::ZipException ); - -createWithArguments( [in] sequence args ) -raises ( com::sun::star::io::IOException, - com::sun::star::ucb::ContentCreationException, - com::sun::star::ucb::InteractiveIOException, - com::sun::star::packages::zip::ZipException ); }; diff --git a/package/qa/cppunit/test_package.cxx b/package/qa/cppunit/test_package.cxx index 80f02d8e..335f490 100644 --- a/package/qa/cppunit/test_package.cxx +++ b/package/qa/cppunit/test_package.cxx @@ -11,7 +11,8 @@ #include #include #include -#include "com/sun/star/packages/zip/ZipFileAccess.hpp" +#include +#include #include @@ -96,14 +97,22 @@ namespace OUString aURL = m_directories.getURLFromSrc("/package/qa/cppunit/data/a2z.zip"); -uno::Sequence aArgs(2); -aArgs[0].Name = "URL"; -aArgs[0].Value <<= aURL; -aArgs[1].Name = "UseBufferedStream"; -aArgs[1].Value <<= true; +uno::Sequence aNVs(2); +aNVs[0].Name = "URL"; +aNVs[0].Value <<= aURL; +aNVs[1].Name = "UseBufferedStream"; +aNVs[1].Value <<= true; + +uno::Sequence aArgs(1); +aArgs[0] <<= aNVs; + +uno::Reference xCxt = comphelper::getProcessComponentContext(); +uno::Reference xSvcMgr = xCxt->getServiceManager(); uno::Reference xZip( - packages::zip::ZipFileAccess::createWithArguments(comphelper::getProcessComponentContext(), aArgs)); +xSvcMgr->createInstanceWithArgumentsAndContext( +"com.sun.star.packages.zip.ZipFileAccess", aArgs, xCxt), +uno::UNO_QUERY); CPPUNIT_ASSERT(xZip.is()); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 105410] Crash in: ScCondFormatDlg::OkPressed()
https://bugs.documentfoundation.org/show_bug.cgi?id=105410 --- Comment #15 from MM--- And with v5.2.4.2 under winodws 10 x64. crashreport.libreoffice.org/stats/crash_details/29f04c40-ccb6-454d-bbac-6eabfd2636b3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105408] LibreOffice Writer have no way to select a text encoding when open a TXT file
https://bugs.documentfoundation.org/show_bug.cgi?id=105408 Maxim Monastirskychanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Maxim Monastirsky --- OK, there is some confusion here. U+FEFF is the UTF-16 BOM, but the attached file is UTF-8, and even has UTF-8 BOM. And still, this file shows real bug. It's correctly detected as UTF-8 under Linux but not under Windows. Most likely the reason is that SwIoSystem::IsDetectableText returns false if the detected line end differs from the system one, which is the case here since the file has LF, but Windows default is CRLF. There is similar case in Bug 63673 but with UTF-16 with CRLF under Linux. I'm closing this bug as WORKSFORME, since the original request was for a way to choose encoding, and there is already. And improving the auto detection is handled already in Bug 63673. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 104050] Add Breeze palette
https://bugs.documentfoundation.org/show_bug.cgi?id=104050 --- Comment #9 from Commit Notification--- heiko tietze committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=99c4b9effe38917eb2063d15aed0d879508c110e=libreoffice-5-3 tdf#104050 - Add Breeze palette It will be available in 5.3.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 104050] Add Breeze palette
https://bugs.documentfoundation.org/show_bug.cgi?id=104050 Commit Notificationchanged: What|Removed |Added Whiteboard|target:5.3.0 target:5.4.0 |target:5.3.0 target:5.4.0 ||target:5.3.1 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - extras/Package_palettes.mk
extras/Package_palettes.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 99c4b9effe38917eb2063d15aed0d879508c110e Author: heiko tietzeDate: Thu Dec 1 12:43:26 2016 +0100 tdf#104050 - Add Breeze palette Amendment to gerrit 31012; makefile adjusted Change-Id: I89b339e49e190f4269a2950799436e94f0aee665 Reviewed-on: https://gerrit.libreoffice.org/31481 Reviewed-by: jan iversen Tested-by: jan iversen (cherry picked from commit 841ef7154ba7b287666767bfa6b48f4d0bb63c10) Reviewed-on: https://gerrit.libreoffice.org/33280 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/extras/Package_palettes.mk b/extras/Package_palettes.mk index 9c3e3e9..a4031d7 100644 --- a/extras/Package_palettes.mk +++ b/extras/Package_palettes.mk @@ -11,6 +11,7 @@ $(eval $(call gb_Package_Package,extras_palettes,$(SRCDIR)/extras/source/palette $(eval $(call gb_Package_add_files,extras_palettes,$(LIBO_SHARE_FOLDER)/palette,\ arrowhd.soe \ + breeze.soc \ classic.sog \ freecolour-hlc.soc \ hatching.soh \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 105416] Window is almost empty with GTK 3 and RTL UI
https://bugs.documentfoundation.org/show_bug.cgi?id=105416 --- Comment #4 from Khaled Hosny--- My wild guess is that we are drawing starting from the right edge of the window/surface instead of the left one and all the drawings is now happening outside the window, or something like that. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105410] Crash in: ScCondFormatDlg::OkPressed()
https://bugs.documentfoundation.org/show_bug.cgi?id=105410 --- Comment #14 from MM--- (In reply to Xisco Faulí from comment #13) > (In reply to MM from comment #12) > > Unconfirmed with v5.1.6.2 under ubuntu 16.04 x64. > > Confirmed with v5.2.4.2 under ubuntu 16.04 x64. > > Confirmed (under ubuntu 16.04 x64) with Version: 5.4.0.0.alpha0+ > > Build ID: ec1afa55e8ed79dc290caff74aaca304a77c3b4f > > CPU Threads: 2; OS Version: Linux 4.4; UI Render: default; VCL: gtk2; > > TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: > > 2017-01-14_01:33:36 > > Locale: en-US (en_US.UTF-8); Calc: single > > Hi MM, > it's interesting you can reproduce it in 5.2.4.2 on Ubuntu... > Can you give me more details about it? any further step you did ? Not really. I just followed the steps from comment 6. The only thing I didn't do, is step 4, didn't press any 'yes' as there was no question. Just do: format > conditional formatting > manage > edit > delete > OK. Also reproduced under ubuntu 16.10 x64 with Version: 5.2.5.0.0+ Build ID: 69954cc174f10fbf511a1aa14cf784e54259861c CPU Threads: 2; OS Version: Linux 4.8; UI Render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:libreoffice-5-2, Time: 2017-01-06_00:32:30 Locale: en-US (en_US.UTF-8); Calc: single -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 93073] Add the ability to bookmark or comment spelling/ grammar mistakes in text from spellcheck dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=93073 --- Comment #7 from Cor Nouws--- (In reply to Heiko Tietze from comment #4) > Removing needsUX, and the ticket may be better located at component Writer. Then what about spell check in Calc/Impress> -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 93073] Add the ability to bookmark or comment spelling/ grammar mistakes in text from spellcheck dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=93073 --- Comment #7 from Cor Nouws--- (In reply to Heiko Tietze from comment #4) > Removing needsUX, and the ticket may be better located at component Writer. Then what about spell check in Calc/Impress> -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105414] Blank cells formatted as numbers not treated as ZERO when pulled via VLOOKUP to external file
https://bugs.documentfoundation.org/show_bug.cgi?id=105414 m.a.riosvchanged: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #4 from m.a.riosv --- Works fine for me, changing the name of the source file to A.ods Version: 5.2.5.1 (x64) Build ID: 0312e1a284a7d50ca85a365c316c7abbf20a4d22 CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; Locale: es-ES (es_ES); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105409] Crash when right-click on spelling error or grammar error when contextual menu is modified via API
https://bugs.documentfoundation.org/show_bug.cgi?id=105409 --- Comment #16 from Xisco Faulí--- (In reply to Maxim Monastirsky from comment #15) > With that patch it doesn't crash anymore under Linux, but I got different > backtrace, so it still needs to be tested with Windows builds. > > To reproduce this under Linux you must use SAL_USE_VCLPLUGIN=gen. gtk/gtk3 > have different lifecycle for menus, probably because GtkSalMenu holds a hard > reference on the parent menu. wow, that was fast. thanks for fixing this. @Olivier, tomorrow a new build containing the fix will be available at http://dev-builds.libreoffice.org/daily/master/Win-x86@42/. Could you please download it and test it to see if it's fixed on Windows as well? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105422] Dual install of LO 32-bit and 64-bit to same system. Yet only one uninstall option in "Programs and Features"
https://bugs.documentfoundation.org/show_bug.cgi?id=105422 m.a.riosvchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||miguelangelrv@libreoffice.o ||rg Resolution|--- |NOTABUG --- Comment #2 from m.a.riosv --- It's no possible to have installed both version in the usual way. So only the last installed it's the installation. There is chance to install in parallel so many version like you want. https://wiki.documentfoundation.org/Installing_in_parallel/Windows I have about twenty five. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/column4.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit acbcec11940d245aabed93ca756ef9462e06f192 Author: Eike RathkeDate: Wed Jan 18 23:08:37 2017 +0100 bail out early if there are no notes ... which usually is the case, so don't unnecessarily create iterators and dive into an empty mdds tree. Change-Id: Iba345cd231d5911adefabc0584290834678a68f1 diff --git a/sc/source/core/data/column4.cxx b/sc/source/core/data/column4.cxx index b19f330..3e08a7f 100644 --- a/sc/source/core/data/column4.cxx +++ b/sc/source/core/data/column4.cxx @@ -620,6 +620,9 @@ void ScColumn::CreateAllNoteCaptions() void ScColumn::ForgetNoteCaptions( SCROW nRow1, SCROW nRow2, bool bPreserveData ) { +if (maCellNotes.empty()) +return; + if (!ValidRow(nRow1) || !ValidRow(nRow2)) return; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 105422] Dual install of LO 32-bit and 64-bit to same system. Yet only one uninstall option in "Programs and Features"
https://bugs.documentfoundation.org/show_bug.cgi?id=105422 --- Comment #1 from Radish--- I would like to add to the above that some users might want to experiment with having LO 32-bit and 64-bit installed to the same Windows system. And on that basis it might be a good idea to have them install as completely discrete (separate) installs i.e. not sharing any of the same user data. (As things stand I have a suspicion that if both are installed to the same system then they might be sharing the same user data - which might not be what the user wants. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105409] Crash when right-click on spelling error or grammar error when contextual menu is modified via API
https://bugs.documentfoundation.org/show_bug.cgi?id=105409 Maxim Monastirskychanged: What|Removed |Added CC||momonas...@gmail.com --- Comment #15 from Maxim Monastirsky --- With that patch it doesn't crash anymore under Linux, but I got different backtrace, so it still needs to be tested with Windows builds. To reproduce this under Linux you must use SAL_USE_VCLPLUGIN=gen. gtk/gtk3 have different lifecycle for menus, probably because GtkSalMenu holds a hard reference on the parent menu. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105416] Window is almost empty with GTK 3 and RTL UI
https://bugs.documentfoundation.org/show_bug.cgi?id=105416 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105430] Bootstrap exception ' component context fails to supply service com.sun.star.ucb.UniversalContentBroker of type com.sun.star.ucb.XUniversalContentBroker '
https://bugs.documentfoundation.org/show_bug.cgi?id=105430 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||xiscofa...@libreoffice.org Resolution|--- |NOTABUG --- Comment #1 from Xisco Faulí --- Hi Artem, I'd recommend you to do: git pull -r make clean make build-nocheck Then, if you still get the same problem, please throw the question to libreoff...@lists.freedesktop.org. Closing as RESOLVED NOTABUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/column.hxx|2 - sc/inc/document.hxx |2 - sc/inc/postit.hxx| 10 +++-- sc/inc/table.hxx |2 - sc/source/core/data/column4.cxx | 12 +++ sc/source/core/data/documen2.cxx |8 ++- sc/source/core/data/document.cxx |4 +-- sc/source/core/data/postit.cxx | 40 --- sc/source/core/data/table2.cxx |4 +-- sc/source/ui/undo/undoblk.cxx|2 - 10 files changed, 60 insertions(+), 26 deletions(-) New commits: commit b8b657123cc508c906622d20669507628c93e104 Author: Eike RathkeDate: Wed Jan 18 22:49:08 2017 +0100 tdf#104967 preserve isolated notes data in clipboard when closing document Change-Id: I0e263583e27c5103c0bb90e8fe00562e46a52d98 diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx index 0568aa9..ae911e6 100644 --- a/sc/inc/column.hxx +++ b/sc/inc/column.hxx @@ -598,7 +598,7 @@ public: ScPostIt* ReleaseNote( SCROW nRow ); size_t GetNoteCount() const; void CreateAllNoteCaptions(); -void ForgetNoteCaptions( SCROW nRow1, SCROW nRow2 ); +void ForgetNoteCaptions( SCROW nRow1, SCROW nRow2, bool bPreserveData ); SCROW GetNotePosition( size_t nIndex ) const; void GetAllNoteEntries( std::vector& rNotes ) const; void GetNotesInRange( SCROW nStartRow, SCROW nEndRow, std::vector& rNotes ) const; diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx index 2603cd6..7ceb121 100644 --- a/sc/inc/document.hxx +++ b/sc/inc/document.hxx @@ -1110,7 +1110,7 @@ public: * code uses sdr objects to export note data. */ void CreateAllNoteCaptions(); -void ForgetNoteCaptions( const ScRangeList& rRanges ); +void ForgetNoteCaptions( const ScRangeList& rRanges, bool bPreserveData ); ScAddress GetNotePosition( size_t nIndex ) const; ScAddress GetNotePosition( size_t nIndex, SCTAB nTab ) const; diff --git a/sc/inc/postit.hxx b/sc/inc/postit.hxx index 8835dea..87553f3 100644 --- a/sc/inc/postit.hxx +++ b/sc/inc/postit.hxx @@ -129,8 +129,14 @@ public: /** Returns the caption object of this note. Creates the caption object, if the note contains initial caption data instead of the caption. */ SdrCaptionObj* GetOrCreateCaption( const ScAddress& rPos ) const; -/** Forgets the pointer to the note caption object. */ -voidForgetCaption(); + +/** Forgets the pointer to the note caption object. + +@param bPreserveData +If true then the note text is remembered in maNoteData to be able +to later reconstruct a caption from it. + */ +voidForgetCaption( bool bPreserveData = false ); /** Shows or hides the note caption object. */ voidShowCaption( const ScAddress& rPos, bool bShow ); diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx index da69ea9..34f6e3f 100644 --- a/sc/inc/table.hxx +++ b/sc/inc/table.hxx @@ -400,7 +400,7 @@ public: size_t GetNoteCount( SCCOL nCol ) const; SCROW GetNotePosition( SCCOL nCol, size_t nIndex ) const; void CreateAllNoteCaptions(); -void ForgetNoteCaptions( SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2 ); +void ForgetNoteCaptions( SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2, bool bPreserveData ); void GetAllNoteEntries( std::vector& rNotes ) const; void GetNotesInRange( const ScRange& rRange, std::vector& rNotes ) const; diff --git a/sc/source/core/data/column4.cxx b/sc/source/core/data/column4.cxx index ddf18d6..b19f330 100644 --- a/sc/source/core/data/column4.cxx +++ b/sc/source/core/data/column4.cxx @@ -598,11 +598,15 @@ public: } }; -struct NoteCaptionCleaner +class NoteCaptionCleaner { +bool mbPreserveData; +public: +explicit NoteCaptionCleaner( bool bPreserveData ) : mbPreserveData(bPreserveData) {} + void operator() ( size_t /*nRow*/, ScPostIt* p ) { -p->ForgetCaption(); +p->ForgetCaption(mbPreserveData); } }; @@ -614,12 +618,12 @@ void ScColumn::CreateAllNoteCaptions() sc::ProcessNote(maCellNotes, aFunc); } -void ScColumn::ForgetNoteCaptions( SCROW nRow1, SCROW nRow2 ) +void ScColumn::ForgetNoteCaptions( SCROW nRow1, SCROW nRow2, bool bPreserveData ) { if (!ValidRow(nRow1) || !ValidRow(nRow2)) return; -NoteCaptionCleaner aFunc; +NoteCaptionCleaner aFunc(bPreserveData); sc::CellNoteStoreType::iterator it = maCellNotes.begin(); sc::ProcessNote(it, maCellNotes, nRow1, nRow2, aFunc); } diff --git a/sc/source/core/data/documen2.cxx b/sc/source/core/data/documen2.cxx index cd3f2d7..a5bf840 100644 --- a/sc/source/core/data/documen2.cxx +++ b/sc/source/core/data/documen2.cxx @@ -379,13 +379,11 @@ ScDocument::~ScDocument() // copied from this document, forget it as it references this // document's drawing layer pages and what not, which otherwise when
[Libreoffice-bugs] [Bug 105416] Window is almost empty with GTK 3 and RTL UI
https://bugs.documentfoundation.org/show_bug.cgi?id=105416 --- Comment #3 from Khaled Hosny--- Still no idea what is going on, but creating a surface half the size will draw the left half just fine: diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx index d3a0310245f7..55cbdea37158 100644 --- a/vcl/unx/gtk3/gtk3gtkframe.cxx +++ b/vcl/unx/gtk3/gtk3gtkframe.cxx @@ -1585,7 +1585,7 @@ void GtkSalFrame::AllocateFrame() #endif m_pSurface = gdk_window_create_similar_image_surface(widget_get_window(m_pWindow), CAIRO_FORMAT_ARGB32, - aFrameSize.getX() * scale, + (aFrameSize.getX()/2) * scale, aFrameSize.getY() * scale, scale); #if CAIRO_VERSION >= CAIRO_VERSION_ENCODE(1, 14, 0) But two thirds with draw only the left 1/3 in the middle of the screen! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105409] Crash when right-click on spelling error or grammar error when contextual menu is modified via API
https://bugs.documentfoundation.org/show_bug.cgi?id=105409 --- Comment #14 from Commit Notification--- Maxim Monastirsky committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6884550c20f95a635357ad848799a1aae555968a tdf#105409 Use ScopedVclPtr It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105409] Crash when right-click on spelling error or grammar error when contextual menu is modified via API
https://bugs.documentfoundation.org/show_bug.cgi?id=105409 Commit Notificationchanged: What|Removed |Added Whiteboard||target:5.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 3 commits - sw/source
sw/source/uibase/docvw/edtwin.cxx|6 -- sw/source/uibase/shells/textsh1.cxx | 74 +++ sw/source/uibase/uiview/viewling.cxx |2 3 files changed, 18 insertions(+), 64 deletions(-) New commits: commit 6884550c20f95a635357ad848799a1aae555968a Author: Maxim MonastirskyDate: Wed Jan 18 23:28:16 2017 +0200 tdf#105409 Use ScopedVclPtr so disposeAndClear is called. Change-Id: I40da317ac03f815c8664e8a4648870c2066f9650 diff --git a/sw/source/uibase/uiview/viewling.cxx b/sw/source/uibase/uiview/viewling.cxx index 2152477..0e74a3d 100644 --- a/sw/source/uibase/uiview/viewling.cxx +++ b/sw/source/uibase/uiview/viewling.cxx @@ -717,7 +717,7 @@ bool SwView::ExecSpellPopup(const Point& rPt) aEvent.SourceWindow = VCLUnoHelper::GetInterface( m_pEditWin ); aEvent.ExecutePosition.X = aPixPos.X(); aEvent.ExecutePosition.Y = aPixPos.Y(); -VclPtr pMenu; +ScopedVclPtr pMenu; OUString sMenuName = bUseGrammarContext ? OUString("private:resource/GrammarContextMenu") : OUString("private:resource/SpellContextMenu"); commit ba19b9fd5763c305569ce6ae4120c9e17de6afd4 Author: Maxim Monastirsky Date: Wed Jan 18 00:13:27 2017 +0200 sw: Unify char highlight handlers SID_ATTR_CHAR_COLOR_BACKGROUND code was mostly a copy-paste of SID_ATTR_CHAR_COLOR_BACKGROUND_EXT. Change-Id: I713bfd72a2f51f2d0ff10b36e9e0a9150b13a640 diff --git a/sw/source/uibase/docvw/edtwin.cxx b/sw/source/uibase/docvw/edtwin.cxx index 60ab000..eac6d39 100644 --- a/sw/source/uibase/docvw/edtwin.cxx +++ b/sw/source/uibase/docvw/edtwin.cxx @@ -4823,11 +4823,9 @@ void SwEditWin::MouseButtonUp(const MouseEvent& rMEvt) switch( m_pApplyTempl->nColor ) { case SID_ATTR_CHAR_COLOR_EXT: -case SID_ATTR_CHAR_COLOR2: nId = RES_CHRATR_COLOR; break; case SID_ATTR_CHAR_COLOR_BACKGROUND_EXT: -case SID_ATTR_CHAR_COLOR_BACKGROUND: nId = RES_CHRATR_BACKGROUND; break; } diff --git a/sw/source/uibase/shells/textsh1.cxx b/sw/source/uibase/shells/textsh1.cxx index 081b3c3..350a7f1 100644 --- a/sw/source/uibase/shells/textsh1.cxx +++ b/sw/source/uibase/shells/textsh1.cxx @@ -1192,73 +1192,21 @@ void SwTextShell::Execute(SfxRequest ) } break; case SID_ATTR_CHAR_COLOR_BACKGROUND: -{ -Color aSet; -if(pItem) -aSet = static_cast(pItem)->GetValue(); -else -aSet = COL_TRANSPARENT; - -SwEditWin& rEdtWin = GetView().GetEditWin(); -rEdtWin.SetWaterCanTextBackColor(aSet); -SwApplyTemplate* pApply = rEdtWin.GetApplyTemplate(); - -if(!pApply && (rWrtSh.HasSelection() || rReq.IsAPI())) -{ -rWrtSh.StartUndo( UNDO_INSATTR ); -SvxBrushItem aBrushItem(RES_CHRATR_BACKGROUND); -aBrushItem.SetColor(aSet); -rWrtSh.SetAttrItem( aBrushItem ); - -// Remove MS specific highlight when background is set -rWrtSh.SetAttrItem( SvxBrushItem(RES_CHRATR_HIGHLIGHT) ); - -// Remove shading marker -SfxItemSet aCoreSet( rWrtSh.GetView().GetPool(), RES_CHRATR_GRABBAG, RES_CHRATR_GRABBAG ); -rWrtSh.GetCurAttr( aCoreSet ); - -const SfxPoolItem *pTmpItem; -if( SfxItemState::SET == aCoreSet.GetItemState( RES_CHRATR_GRABBAG, false, ) ) -{ -SfxGrabBagItem aGrabBag(*static_cast(pTmpItem)); -std::map & rMap = aGrabBag.GetGrabBag(); -auto aIterator = rMap.find("CharShadingMarker"); -if( aIterator != rMap.end() ) -{ -aIterator->second = uno::makeAny(false); -} -rWrtSh.SetAttrItem( aGrabBag ); -} -rWrtSh.EndUndo( UNDO_INSATTR ); -} -else if(!pApply || pApply->nColor != SID_ATTR_CHAR_COLOR_BACKGROUND_EXT) -{ - GetView().GetViewFrame()->GetDispatcher()->Execute(SID_ATTR_CHAR_COLOR_BACKGROUND_EXT); -} - -rReq.Done(); -} -break; case SID_ATTR_CHAR_COLOR_BACKGROUND_EXT: case SID_ATTR_CHAR_COLOR_EXT: { +Color aSet = pItem ? static_cast(pItem)->GetValue() : COL_TRANSPARENT; SwEditWin& rEdtWin = GetView().GetEditWin(); -if (pItem) -{ -// The reason we need this argument here is that when a toolbar is closed -// and reopened, its
[Libreoffice-bugs] [Bug 105427] : trendline formula wrong for second degree polynomial approximation
https://bugs.documentfoundation.org/show_bug.cgi?id=105427 andichanged: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Version|5.0.3.2 release |5.1.6.2 release Ever confirmed|1 |0 --- Comment #2 from andi --- problem description in brief: error in approximation formula formula is derived from trendline trendline looks o.k. error applies to approximation with second degree polynom -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105430] New: Bootstrap exception ' component context fails to supply service com.sun.star.ucb.UniversalContentBroker of type com.sun.star.ucb.XUniversalContentBroker '
https://bugs.documentfoundation.org/show_bug.cgi?id=105430 Bug ID: 105430 Summary: Bootstrap exception 'component context fails to supply service com.sun.star.ucb.UniversalContentBroker of type com.sun.star.ucb.XUniversalContentBroker' Product: LibreOffice Version: 5.3.0.1 rc Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: saahri...@bk.ru I have bumped into this error: # make build-nocheck mkdir -p /tmp/SBo/libreoffice-5.3.0.1/instdir /tmp/SBo/libreoffice-5.3.0.1/solenv/bin/install-gdb-printers -a /tmp/SBo/libreoffice-5.3.0.1/instdir -c make -j 8 -rs -f /tmp/SBo/libreoffice-5.3.0.1/Makefile.gbuild build [PRL] CustomTarget/postprocess/images/sorted.lst [PRL] CustomTarget/postprocess/images/commandimagelist.ilst [ECH] CustomTarget/instsetoo_native/setup/versionrc fatal: Not a git repository (or any of the parent directories): .git [LOC] top level modules: libreoffice [PRL] CustomTarget/postprocess/images/images_breeze.zip [PRL] CustomTarget/postprocess/images/images_breeze_dark.zip [PRL] CustomTarget/postprocess/images/images_galaxy.zip [PRL] CustomTarget/postprocess/images/images_hicontrast.zip [PRL] CustomTarget/postprocess/images/images_oxygen.zip [PRL] CustomTarget/postprocess/images/images_sifr.zip [PRL] CustomTarget/postprocess/images/images_tango.zip [CUS] instsetoo_native/setup [PKG] instsetoo_native_setup [BIN] instsetoo_native [MOD] instsetoo_native [GAL] arrows [GAL] computers [GAL] diagrams [GAL] education [GAL] environment [GAL] finance [GAL] people Bootstrap exception 'component context fails to supply service com.sun.star.ucb.UniversalContentBroker of type com.sun.star.ucb.XUniversalContentBroker' /tmp/SBo/libreoffice-5.3.0.1/solenv/gbuild/Gallery.mk:58: recipe for target '/tmp/SBo/libreoffice-5.3.0.1/workdir/Gallery/arrows.done' failed make[1]: *** [/tmp/SBo/libreoffice-5.3.0.1/workdir/Gallery/arrows.done] Error 1 make[1]: *** Waiting for unfinished jobs Bootstrap exception 'component context fails to supply service com.sun.star.ucb.UniversalContentBroker of type com.sun.star.ucb.XUniversalContentBroker' /tmp/SBo/libreoffice-5.3.0.1/solenv/gbuild/Gallery.mk:58: recipe for target '/tmp/SBo/libreoffice-5.3.0.1/workdir/Gallery/computers.done' failed make[1]: *** [/tmp/SBo/libreoffice-5.3.0.1/workdir/Gallery/computers.done] Error 1 Bootstrap exception 'component context fails to supply service com.sun.star.ucb.UniversalContentBroker of type com.sun.star.ucb.XUniversalContentBroker' /tmp/SBo/libreoffice-5.3.0.1/solenv/gbuild/Gallery.mk:58: recipe for target '/tmp/SBo/libreoffice-5.3.0.1/workdir/Gallery/education.done' failed make[1]: *** [/tmp/SBo/libreoffice-5.3.0.1/workdir/Gallery/education.done] Error 1 Bootstrap exception 'component context fails to supply service com.sun.star.ucb.UniversalContentBroker of type com.sun.star.ucb.XUniversalContentBroker' /tmp/SBo/libreoffice-5.3.0.1/solenv/gbuild/Gallery.mk:58: recipe for target '/tmp/SBo/libreoffice-5.3.0.1/workdir/Gallery/diagrams.done' failed make[1]: *** [/tmp/SBo/libreoffice-5.3.0.1/workdir/Gallery/diagrams.done] Error 1 Bootstrap exception 'component context fails to supply service com.sun.star.ucb.UniversalContentBroker of type com.sun.star.ucb.XUniversalContentBroker' /tmp/SBo/libreoffice-5.3.0.1/solenv/gbuild/Gallery.mk:58: recipe for target '/tmp/SBo/libreoffice-5.3.0.1/workdir/Gallery/environment.done' failed make[1]: *** [/tmp/SBo/libreoffice-5.3.0.1/workdir/Gallery/environment.done] Error 1 Bootstrap exception 'component context fails to supply service com.sun.star.ucb.UniversalContentBroker of type com.sun.star.ucb.XUniversalContentBroker' /tmp/SBo/libreoffice-5.3.0.1/solenv/gbuild/Gallery.mk:58: recipe for target '/tmp/SBo/libreoffice-5.3.0.1/workdir/Gallery/finance.done' failed make[1]: *** [/tmp/SBo/libreoffice-5.3.0.1/workdir/Gallery/finance.done] Error 1 make[1]: *** wait: No child processes. Stop. Makefile:263: recipe for target 'build' failed make: *** [build] Error 2 Single-process building fails in the same way: # PARALLELISM="0" make build-nocheck mkdir -p /tmp/SBo/libreoffice-5.3.0.1/instdir /tmp/SBo/libreoffice-5.3.0.1/solenv/bin/install-gdb-printers -a /tmp/SBo/libreoffice-5.3.0.1/instdir -c make -rs -f /tmp/SBo/libreoffice-5.3.0.1/Makefile.gbuild build [PRL] CustomTarget/postprocess/images/sorted.lst [PRL] CustomTarget/postprocess/images/commandimagelist.ilst [PRL] CustomTarget/postprocess/images/images_breeze.zip [PRL] CustomTarget/postprocess/images/images_breeze_dark.zip [PRL] CustomTarget/postprocess/images/images_galaxy.zip [PRL] CustomTarget/postprocess/images/images_hicontrast.zip [PRL] CustomTarget/postprocess/images/images_oxygen.zip [PRL] CustomTarget/postprocess/images/images_sifr.zip [PRL]
[Libreoffice-commits] core.git: xmlsecurity/source
xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.cxx |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) New commits: commit 16c9933666a9328a8bc59175248a440d26b3242a Author: Caolán McNamaraDate: Wed Jan 18 21:33:47 2017 + convert to std::vector Change-Id: I77ac7701ccb35aa32152d85a20fc59ed0bd942cf diff --git a/xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.cxx b/xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.cxx index a4ca2a6..5e61463 100644 --- a/xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.cxx +++ b/xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.cxx @@ -80,7 +80,7 @@ css::uno::Sequence< css::security::CertAltNameEntry > SAL_CALL SanExtensionImpl: CERTGeneralName* current = nameList; int size = GetNamesLength(nameList); -CertAltNameEntry* arrCertAltNameEntry = new CertAltNameEntry[size]; +std::vector arrCertAltNameEntry(size); for(int i = 0; i < size ; i++){ switch (current->type) { case certOtherName: { @@ -146,13 +146,9 @@ css::uno::Sequence< css::security::CertAltNameEntry > SAL_CALL SanExtensionImpl: current = CERT_GetNextGeneralName(current); } -m_Entries = ::comphelper::arrayToSequence< css::security::CertAltNameEntry >(arrCertAltNameEntry, size); - -delete [] arrCertAltNameEntry; +m_Entries = ::comphelper::containerToSequence(arrCertAltNameEntry); PORT_FreeArena(arena, PR_FALSE); - - } return m_Entries; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 104952] Crash printed file with input on printer HP LaserJet 1020 ( Printed in pdf normal, empty file printed normal)
https://bugs.documentfoundation.org/show_bug.cgi?id=104952 --- Comment #26 from Kiss-Kálmán Dániel--- hi all, just installed 5.3.0.2. Error disappeared, can print to all my HPLJs. thanks -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/appl/app.hrc | 44 +++--- sfx2/source/appl/newhelp.cxx | 44 +++--- sfx2/source/appl/newhelp.src | 84 +-- 3 files changed, 86 insertions(+), 86 deletions(-) New commits: commit 86255f68719dce3f2ff07c54270d3e08fbd852c9 Author: Caolán McNamaraDate: Wed Jan 18 21:21:39 2017 + sfx2: load BitmapEx resources instead of Image ones Change-Id: I0ec89e022cac47b4a761da1715b39a7fb86ffdb0 diff --git a/sfx2/source/appl/app.hrc b/sfx2/source/appl/app.hrc index abd8ab2..2510c46 100644 --- a/sfx2/source/appl/app.hrc +++ b/sfx2/source/appl/app.hrc @@ -41,19 +41,19 @@ #define STR_INFO_NOSEARCHRESULTS(RID_SFX_APP_START+106) #define STR_INFO_NOSEARCHTEXTFOUND (RID_SFX_APP_START+107) -#define IMG_HELP_TOOLBOX_INDEX_ON (RID_SFX_APP_START+110) -#define IMG_HELP_TOOLBOX_INDEX_OFF (RID_SFX_APP_START+111) -#define IMG_HELP_TOOLBOX_START (RID_SFX_APP_START+112) -#define IMG_HELP_TOOLBOX_PREV (RID_SFX_APP_START+113) -#define IMG_HELP_TOOLBOX_NEXT (RID_SFX_APP_START+114) -#define IMG_HELP_TOOLBOX_PRINT (RID_SFX_APP_START+115) -#define IMG_HELP_TOOLBOX_BOOKMARKS (RID_SFX_APP_START+116) -#define IMG_HELP_TOOLBOX_SEARCHDIALOG (RID_SFX_APP_START+117) -#define IMG_HELP_TOOLBOX_COPY (RID_SFX_APP_START+118) - -#define IMG_HELP_CONTENT_BOOK_OPEN (RID_SFX_APP_START+120) -#define IMG_HELP_CONTENT_BOOK_CLOSED(RID_SFX_APP_START+122) -#define IMG_HELP_CONTENT_DOC(RID_SFX_APP_START+124) +#define BMP_HELP_TOOLBOX_INDEX_ON (RID_SFX_APP_START+110) +#define BMP_HELP_TOOLBOX_INDEX_OFF (RID_SFX_APP_START+111) +#define BMP_HELP_TOOLBOX_START (RID_SFX_APP_START+112) +#define BMP_HELP_TOOLBOX_PREV (RID_SFX_APP_START+113) +#define BMP_HELP_TOOLBOX_NEXT (RID_SFX_APP_START+114) +#define BMP_HELP_TOOLBOX_PRINT (RID_SFX_APP_START+115) +#define BMP_HELP_TOOLBOX_BOOKMARKS (RID_SFX_APP_START+116) +#define BMP_HELP_TOOLBOX_SEARCHDIALOG (RID_SFX_APP_START+117) +#define BMP_HELP_TOOLBOX_COPY (RID_SFX_APP_START+118) + +#define BMP_HELP_CONTENT_BOOK_OPEN (RID_SFX_APP_START+120) +#define BMP_HELP_CONTENT_BOOK_CLOSED(RID_SFX_APP_START+122) +#define BMP_HELP_CONTENT_DOC(RID_SFX_APP_START+124) #define STR_HELP_WINDOW_TITLE (RID_SFX_APP_START+125) // string @@ -84,15 +84,15 @@ #define RID_HELP_ONSTARTUP_TEXT (RID_SFX_APP_START+145) -#define IMG_HELP_TOOLBOX_L_INDEX_ON (RID_SFX_APP_START+160) -#define IMG_HELP_TOOLBOX_L_INDEX_OFF(RID_SFX_APP_START+161) -#define IMG_HELP_TOOLBOX_L_START(RID_SFX_APP_START+162) -#define IMG_HELP_TOOLBOX_L_PREV (RID_SFX_APP_START+163) -#define IMG_HELP_TOOLBOX_L_NEXT (RID_SFX_APP_START+164) -#define IMG_HELP_TOOLBOX_L_PRINT(RID_SFX_APP_START+165) -#define IMG_HELP_TOOLBOX_L_BOOKMARKS(RID_SFX_APP_START+166) -#define IMG_HELP_TOOLBOX_L_SEARCHDIALOG (RID_SFX_APP_START+167) -#define IMG_HELP_TOOLBOX_L_COPY (RID_SFX_APP_START+168) +#define BMP_HELP_TOOLBOX_L_INDEX_ON (RID_SFX_APP_START+160) +#define BMP_HELP_TOOLBOX_L_INDEX_OFF(RID_SFX_APP_START+161) +#define BMP_HELP_TOOLBOX_L_START(RID_SFX_APP_START+162) +#define BMP_HELP_TOOLBOX_L_PREV (RID_SFX_APP_START+163) +#define BMP_HELP_TOOLBOX_L_NEXT (RID_SFX_APP_START+164) +#define BMP_HELP_TOOLBOX_L_PRINT(RID_SFX_APP_START+165) +#define BMP_HELP_TOOLBOX_L_BOOKMARKS(RID_SFX_APP_START+166) +#define BMP_HELP_TOOLBOX_L_SEARCHDIALOG (RID_SFX_APP_START+167) +#define BMP_HELP_TOOLBOX_L_COPY (RID_SFX_APP_START+168) #define RID_SECURITY_WARNING_TITLE (RID_SFX_APP_START + 181) diff --git a/sfx2/source/appl/newhelp.cxx b/sfx2/source/appl/newhelp.cxx index 46eb4ab..cb46469 100644 --- a/sfx2/source/appl/newhelp.cxx +++ b/sfx2/source/appl/newhelp.cxx @@ -267,9 +267,9 @@ struct ContentEntry_Impl ContentListBox_Impl::ContentListBox_Impl(vcl::Window* pParent, WinBits nStyle) : SvTreeListBox(pParent, nStyle) -, aOpenBookImage(SfxResId(IMG_HELP_CONTENT_BOOK_OPEN)) -, aClosedBookImage(SfxResId(IMG_HELP_CONTENT_BOOK_CLOSED)) -, aDocumentImage(SfxResId(IMG_HELP_CONTENT_DOC)) +, aOpenBookImage(SfxResId(BMP_HELP_CONTENT_BOOK_OPEN)) +, aClosedBookImage(SfxResId(BMP_HELP_CONTENT_BOOK_CLOSED)) +, aDocumentImage(SfxResId(BMP_HELP_CONTENT_DOC)) { SetStyle( GetStyle() | WB_HIDESELECTION | WB_HSCROLL ); @@ -1854,8 +1854,8 @@
[Libreoffice-commits] core.git: sw/source
sw/source/ui/shells/shells.src| 29 +--- sw/source/ui/utlui/utlui.src | 53 ++ sw/source/uibase/docvw/PageBreakWin.cxx |6 +-- sw/source/uibase/inc/shells.hrc | 12 +++--- sw/source/uibase/inc/utlui.hrc| 14 +++ sw/source/uibase/lingu/olmenu.cxx |2 - sw/source/uibase/lingu/olmenu.hrc |2 - sw/source/uibase/lingu/olmenu.src |5 +- sw/source/uibase/misc/redlndlg.cxx| 10 ++--- sw/source/uibase/utlui/viewlayoutctrl.cxx | 12 +++--- 10 files changed, 67 insertions(+), 78 deletions(-) New commits: commit 783a107ee705528275e0e3e25931cd4fe8a98258 Author: Caolán McNamaraDate: Wed Jan 18 21:11:04 2017 + sw: load BitmapEx resources instead of Image ones Change-Id: I77b5a892478d048decc2f5a018dbaf5a11b0194d diff --git a/sw/source/ui/shells/shells.src b/sw/source/ui/shells/shells.src index d8ac163..7814bdd 100644 --- a/sw/source/ui/shells/shells.src +++ b/sw/source/ui/shells/shells.src @@ -71,33 +71,38 @@ String STR_REDLINE_AUTOFMT Text [ en-US ] = "AutoCorrect"; }; -Image IMG_REDLINE_INSERTED +Bitmap BMP_REDLINE_INSERTED { -ImageBitmap = Bitmap{File = "redline_inserted.png";}; +File = "redline_inserted.png"; }; -Image IMG_REDLINE_DELETED + +Bitmap BMP_REDLINE_DELETED { -ImageBitmap = Bitmap{File = "redline_deleted.png";}; +File = "redline_deleted.png"; }; -Image IMG_REDLINE_FORMATED + +Bitmap BMP_REDLINE_FORMATED { // FIXME -ImageBitmap = Bitmap{File = "redline_inserted.png";}; +File = "redline_inserted.png"; }; -Image IMG_REDLINE_TABLECHG + +Bitmap BMP_REDLINE_TABLECHG { // FIXME -ImageBitmap = Bitmap{File = "redline_inserted.png";}; +File = "redline_inserted.png"; }; -Image IMG_REDLINE_FMTCOLLSET + +Bitmap BMP_REDLINE_FMTCOLLSET { // FIXME -ImageBitmap = Bitmap{File = "redline_inserted.png";}; +File = "redline_inserted.png"; }; -Image IMG_REDLINE_AUTOFMT + +Bitmap BMP_REDLINE_AUTOFMT { // FIXME -ImageBitmap = Bitmap{File = "redline_inserted.png";}; +File = "redline_inserted.png"; }; String STR_REDLINE_FORMATED diff --git a/sw/source/ui/utlui/utlui.src b/sw/source/ui/utlui/utlui.src index d471dc1..61f4653 100644 --- a/sw/source/ui/utlui/utlui.src +++ b/sw/source/ui/utlui/utlui.src @@ -349,56 +349,39 @@ Bitmap RID_BMP_DBQUERY File = "sx03.png"; }; -Image IMG_VIEWLAYOUT_AUTOMATIC +Bitmap RID_BMP_VIEWLAYOUT_AUTOMATIC { -ImageBitmap = Bitmap -{ -File = "twopages_10x24.png" ; -}; +File = "twopages_10x24.png" ; }; -Image IMG_VIEWLAYOUT_AUTOMATIC_ACTIVE + +Bitmap RID_BMP_VIEWLAYOUT_AUTOMATIC_ACTIVE { -ImageBitmap = Bitmap -{ -File = "twopages_a_10x24.png" ; -}; +File = "twopages_a_10x24.png" ; }; -Image IMG_VIEWLAYOUT_BOOKMODE +Bitmap RID_BMP_VIEWLAYOUT_BOOKMODE { -ImageBitmap = Bitmap -{ -File = "doublepage_10x22.png" ; -}; +File = "doublepage_10x22.png" ; }; -Image IMG_VIEWLAYOUT_BOOKMODE_ACTIVE + +Bitmap RID_BMP_VIEWLAYOUT_BOOKMODE_ACTIVE { -ImageBitmap = Bitmap -{ -File = "doublepage_a_10x22.png" ; -}; +File = "doublepage_a_10x22.png" ; }; -Image IMG_VIEWLAYOUT_SINGLECOLUMN +Bitmap RID_BMP_VIEWLAYOUT_SINGLECOLUMN { -ImageBitmap = Bitmap -{ -File = "emptypage_10x14.png" ; -}; +File = "emptypage_10x14.png" ; }; -Image IMG_VIEWLAYOUT_SINGLECOLUMN_ACTIVE + +Bitmap RID_BMP_VIEWLAYOUT_SINGLECOLUMN_ACTIVE { -ImageBitmap = Bitmap -{ -File = "emptypage_a_10x14.png" ; -}; +File = "emptypage_a_10x14.png" ; }; -Image IMG_PAGE_BREAK + +Bitmap RID_BMP_PAGE_BREAK { -ImageBitmap = Bitmap -{ -File = "page_break.png" ; -}; +File = "page_break.png" ; }; String STR_HYPERCTRL_SEL diff --git a/sw/source/uibase/docvw/PageBreakWin.cxx b/sw/source/uibase/docvw/PageBreakWin.cxx index 03fcc6b..b4056c2 100644 --- a/sw/source/uibase/docvw/PageBreakWin.cxx +++ b/sw/source/uibase/docvw/PageBreakWin.cxx @@ -170,12 +170,12 @@ void SwPageBreakWin::Paint(vcl::RenderContext& rRenderContext, const Rectangle&) aPolygon, aColor)); // Create the primitive for the image -Image aImg(SW_RES(IMG_PAGE_BREAK)); +BitmapEx aBmpEx(SW_RES(RID_BMP_PAGE_BREAK)); double nImgOfstX = 3.0; if (bRtl) -nImgOfstX = aRect.Right() - aImg.GetSizePixel().Width() - 3.0; +nImgOfstX = aRect.Right() - aBmpEx.GetSizePixel().Width() - 3.0; aSeq[2].set(new drawinglayer::primitive2d::DiscreteBitmapPrimitive2D( -aImg.GetBitmapEx(), B2DPoint(nImgOfstX, 1.0))); +aBmpEx, B2DPoint(nImgOfstX, 1.0))); double nTop = double(aRect.getHeight()) / 2.0; double nBottom = nTop + 4.0; diff --git a/sw/source/uibase/inc/shells.hrc
[Libreoffice-commits] core.git: 2 commits - sw/qa sw/source writerfilter/source
sw/qa/extras/ooxmlimport/ooxmlimport.cxx | 10 +--- sw/source/uibase/uiview/view.cxx | 20 +++- sw/source/uibase/uno/SwXDocumentSettings.cxx | 16 - writerfilter/source/dmapper/DomainMapper_Impl.cxx | 27 +++--- 4 files changed, 30 insertions(+), 43 deletions(-) New commits: commit 2dce8dd41c208ecda40c054635f3736147ec8914 Author: Michael StahlDate: Wed Jan 18 18:25:46 2017 +0100 tdf#99074 sw: remove duplicate property "IsBrowseMode" again Commit e0f9bb795251d950b5dd960fcd030170c8eb67aa added the property "IsBrowseMode" to SwXDocumentSettings, but it is already available in the API as SwXViewSettings property "ShowOnlineLayout". The problem is that both of these properties get exported in ODF into settings.xml, so it contains "IsBrowseMode" twice. Unfortunately the SwXViewSettings are not available in writerfilter, because the XModel::getCurrentController() is null, the view is created after the import. But there is already a way to store ViewData in the SfxBaseModel, which is then used by SfxBaseController::ConnectSfxFrame_Impl() when creating the view. This applies the property at just the right time. Change-Id: I842845d09a7b3fe81e27a1ed8ac8a8594da7f4e8 diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx index 97a0991..786c686 100644 --- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx +++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx @@ -46,6 +46,7 @@ #include #include #include +#include #include #include #include @@ -1321,10 +1322,13 @@ DECLARE_OOXMLIMPORT_TEST(testTdf98882, "tdf98882.docx") DECLARE_OOXMLIMPORT_TEST(testTdf99074, "tdf99074.docx") { -uno::Reference xFactory(mxComponent, uno::UNO_QUERY); -uno::Reference xSettings = xFactory->createInstance("com.sun.star.document.Settings"); +uno::Reference xModel(mxComponent, uno::UNO_QUERY); +uno::Reference const xController( +xModel->getCurrentController(), uno::UNO_QUERY); +uno::Reference const xViewSettings( +xController->getViewSettings()); // This was false, Web Layout was ignored on import. -CPPUNIT_ASSERT(getProperty(xSettings, "InBrowseMode")); +CPPUNIT_ASSERT(getProperty(xViewSettings, "ShowOnlineLayout")); } DECLARE_OOXMLIMPORT_TEST(testTdf100830, "tdf100830.docx") diff --git a/sw/source/uibase/uiview/view.cxx b/sw/source/uibase/uiview/view.cxx index 53baef3..f01a65f 100644 --- a/sw/source/uibase/uiview/view.cxx +++ b/sw/source/uibase/uiview/view.cxx @@ -1264,7 +1264,8 @@ void SwView::ReadUserDataSequence ( const uno::Sequence < beans::PropertyValue > bGotVisibleTop = false, bGotVisibleRight = false, bGotVisibleBottom = false, bGotZoomType = false, bGotZoomFactor = false, bGotIsSelectedFrame = false, - bGotViewLayoutColumns = false, bGotViewLayoutBookMode = false; + bGotViewLayoutColumns = false, bGotViewLayoutBookMode = false, + bBrowseMode = false, bGotBrowseMode = false; for (sal_Int32 i = 0 ; i < nLength; i++) { @@ -1327,10 +1328,20 @@ void SwView::ReadUserDataSequence ( const uno::Sequence < beans::PropertyValue > pValue->Value >>= bSelectedFrame; bGotIsSelectedFrame = true; } +else if (pValue->Name == "ShowOnlineLayout") +{ + pValue->Value >>= bBrowseMode; + bGotBrowseMode = true; +} // Fallback to common SdrModel processing else GetDocShell()->GetDoc()->getIDocumentDrawModelAccess().GetDrawModel()->ReadUserDataSequenceValue(pValue); pValue++; } +if (bGotBrowseMode) +{ +// delegate further + GetViewImpl()->GetUNOObject_Impl()->getViewSettings()->setPropertyValue("ShowOnlineLayout", uno::Any(bBrowseMode)); +} if (bGotVisibleBottom) { Point aCursorPos( nX, nY ); diff --git a/sw/source/uibase/uno/SwXDocumentSettings.cxx b/sw/source/uibase/uno/SwXDocumentSettings.cxx index f11fae73c..b369e98 100644 --- a/sw/source/uibase/uno/SwXDocumentSettings.cxx +++ b/sw/source/uibase/uno/SwXDocumentSettings.cxx @@ -136,7 +136,6 @@ enum SwDocumentSettingsPropertyHandles HANDLE_APPLY_PARAGRAPH_MARK_FORMAT_TO_NUMBERING, HANDLE_PROP_LINE_SPACING_SHRINKS_FIRST_LINE, HANDLE_SUBTRACT_FLYS, -HANDLE_BROWSE_MODE, }; static MasterPropertySetInfo * lcl_createSettingsInfo() @@ -213,7 +212,6 @@ static MasterPropertySetInfo * lcl_createSettingsInfo() { OUString("ApplyParagraphMarkFormatToNumbering"), HANDLE_APPLY_PARAGRAPH_MARK_FORMAT_TO_NUMBERING, cppu::UnoType::get(), 0}, { OUString("PropLineSpacingShrinksFirstLine"), HANDLE_PROP_LINE_SPACING_SHRINKS_FIRST_LINE,
[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sc/source
sc/source/core/data/documen2.cxx | 15 +++ 1 file changed, 15 insertions(+) New commits: commit 4d3b4a8ad12767c846b48c3a424e6bb0fa7af924 Author: Eike RathkeDate: Wed Jan 18 16:18:38 2017 +0100 tdf#104967 prevent crash when pasting notes originating from a closed document This is only a workaround to prevent a crash, the actual note content is lost when pasting, only a standard empty note caption will be pasted. Change-Id: Ifaef5d30cc2024f3d03d6b2b4f56c5ccfbb67142 (cherry picked from commit cb566c056b0e8f9f73dac3cbaf497e102a247cb9) Reviewed-on: https://gerrit.libreoffice.org/33274 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/sc/source/core/data/documen2.cxx b/sc/source/core/data/documen2.cxx index e5f4ffc..28e2468 100644 --- a/sc/source/core/data/documen2.cxx +++ b/sc/source/core/data/documen2.cxx @@ -371,6 +371,21 @@ ScDocument::~ScDocument() pRefreshTimerControl = nullptr; } +if (IsClipboardSource()) +{ +// Notes copied to the clipboard have a raw SdrCaptionObj pointer +// copied from this document, forget it as it references this +// document's drawing layer pages and what not, which otherwise when +// pasting to another document after this document was destructed would +// attempt to access non-existing data. +/* XXX this is only a workaround to prevent a crash, the actual note + * content is lost, only a standard empty note caption will be pasted. + * TODO: come up with a solution. */ +ScDocument* pClipDoc = ScModule::GetClipDoc(); +if (pClipDoc) +pClipDoc->ForgetNoteCaptions( ScRangeList( ScRange( 0,0,0, MAXCOL, MAXROW, pClipDoc->GetTableCount()-1))); +} + mxFormulaParserPool.reset(); // Destroy the external ref mgr instance here because it has a timer // which needs to be stopped before the app closes. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 105423] problem with cut and past of table from writer to impress
https://bugs.documentfoundation.org/show_bug.cgi?id=105423 Telestochanged: What|Removed |Added Attachment #130535|text/plain |application/vnd.oasis.opend mime type||ocument.text -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/inc/olmenu.hxx |2 -- sw/source/uibase/lingu/olmenu.cxx | 17 - 2 files changed, 8 insertions(+), 11 deletions(-) New commits: commit ba49d03a60b340dfb217d334cd342e1090a7af71 Author: Caolán McNamaraDate: Wed Jan 18 20:52:58 2017 + we only need this image once, don't need to keep it Change-Id: I4ab3fc515bb1484d00f3a690b9fe8ae9c9dca9fe diff --git a/sw/source/uibase/inc/olmenu.hxx b/sw/source/uibase/inc/olmenu.hxx index 0ebdfed..21e731b 100644 --- a/sw/source/uibase/inc/olmenu.hxx +++ b/sw/source/uibase/inc/olmenu.hxx @@ -56,8 +56,6 @@ class SW_DLLPUBLIC SwSpellPopup : public PopupMenu OUString m_aDicNameSingle; bool m_bGrammarResults;// show grammar results? Or show spellcheck results? -Image m_aInfo16; - static void fillLangPopupMenu( PopupMenu *pPopupMenu, sal_uInt16 nLangStart, const css::uno::Sequence< OUString >& aSeq, SwWrtShell* pWrtSh, std::map< sal_Int16, OUString > ); diff --git a/sw/source/uibase/lingu/olmenu.cxx b/sw/source/uibase/lingu/olmenu.cxx index f4007a3..a5fe2b6 100644 --- a/sw/source/uibase/lingu/olmenu.cxx +++ b/sw/source/uibase/lingu/olmenu.cxx @@ -450,14 +450,13 @@ SwSpellPopup::SwSpellPopup( const linguistic2::ProofreadingResult , sal_Int32 nErrorInResult, const uno::Sequence< OUString > , -const OUString ) : -PopupMenu( SW_RES(MN_SPELL_POPUP) ), -m_pSh( pWrtSh ), -m_xGrammarResult( rResult ), -m_aSuggestions( rSuggestions ), -m_sExplanationLink( ), -m_bGrammarResults( true ), -m_aInfo16( SW_RES(IMG_INFO_16) ) +const OUString ) +: PopupMenu(SW_RES(MN_SPELL_POPUP)) +, m_pSh(pWrtSh) +, m_xGrammarResult(rResult) +, m_aSuggestions(rSuggestions) +, m_sExplanationLink() +, m_bGrammarResults(true) { m_nCheckedLanguage = LanguageTag::convertToLanguageType( rResult.aLocale ); m_nGrammarError = nErrorInResult; @@ -468,7 +467,7 @@ m_aInfo16( SW_RES(IMG_INFO_16) ) InsertSeparator(OString(), nPos++); InsertItem(MN_SHORT_COMMENT, aMessageText, MenuItemBits::NOSELECT, OString(), nPos++); if (bUseImagesInMenus) -SetItemImage( MN_SHORT_COMMENT, m_aInfo16 ); +SetItemImage(MN_SHORT_COMMENT, Image(SW_RES(IMG_INFO_16))); // Add an item to show detailed infos if the FullCommentURL property is defined beans::PropertyValues aProperties = rResult.aErrors[ nErrorInResult ].aProperties; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 105372] PDF Export: Extreme slow PDF export of slides with Focus template
https://bugs.documentfoundation.org/show_bug.cgi?id=105372 Aron Budeachanged: What|Removed |Added Keywords||perf CC||ba...@caesar.elte.hu -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/source
include/vcl/ctrl.hxx |9 +-- vcl/inc/textlayout.hxx|5 +++ vcl/source/control/button.cxx |5 ++- vcl/source/control/ctrl.cxx | 33 -- vcl/source/gdi/textlayout.cxx | 53 ++ 5 files changed, 94 insertions(+), 11 deletions(-) New commits: commit db9ef688edd86b31606e0dd6df6a77732faca49b Author: Caolán McNamaraDate: Wed Jan 18 17:17:09 2017 + Resolves: tdf#98593 buttons in writer show different text at different zooms The DrawControlText always renders with a reference device positions but we pass in a rectangle which is derived a different way. So, add a GetControlTextRect which operates on the same reference device as DrawControlText so the rectangles match The rectangle is mapped from pixels to logic and back from logic to pixel, so add an argument to store the logic size from GetControlTextRect and re-use it without conversion on the cases where we pass back the original rectangle zooming in/out on the button in writer is now stable wrt text shown at all zoom levels Change-Id: Ic581eca67d0ff265e2753ab8b6c40e8fca7e6ae4 Reviewed-on: https://gerrit.libreoffice.org/33277 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/include/vcl/ctrl.hxx b/include/vcl/ctrl.hxx index 2f93f64..c6b60ef 100644 --- a/include/vcl/ctrl.hxx +++ b/include/vcl/ctrl.hxx @@ -85,8 +85,13 @@ protected: returning. */ Rectangle DrawControlText( OutputDevice& _rTargetDevice, const Rectangle& _rRect, - const OUString& _rStr, DrawTextFlags _nStyle, - MetricVector* _pVector, OUString* _pDisplayText ) const; + const OUString& _rStr, DrawTextFlags _nStyle, + MetricVector* _pVector, OUString* _pDisplayText, + const Size* i_pDeviceSize = nullptr ) const; + +Rectangle GetControlTextRect( OutputDevice& _rTargetDevice, const Rectangle & rRect, + const OUString& _rStr, DrawTextFlags _nStyle, + Size* o_pDeviceSize = nullptr ) const; virtual const vcl::Font& GetCanonicalFont( const StyleSettings& _rStyle ) const; diff --git a/vcl/inc/textlayout.hxx b/vcl/inc/textlayout.hxx index 97350c0..a8a4124 100644 --- a/vcl/inc/textlayout.hxx +++ b/vcl/inc/textlayout.hxx @@ -92,7 +92,10 @@ namespace vcl Rectangle DrawText( const Rectangle& _rRect, const OUString& _rText, DrawTextFlags _nStyle, - MetricVector* _pVector, OUString* _pDisplayText ); + MetricVector* _pVector, OUString* _pDisplayText, const Size* i_pDeviceSize ); + +Rectangle GetTextRect( const Rectangle& _rRect, + const OUString& _rText, DrawTextFlags _nStyle, Size* o_pDeviceSize ); private: ControlTextRenderer( const ControlTextRenderer& ) = delete; diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx index 91cc0dd..c928010 100644 --- a/vcl/source/control/button.cxx +++ b/vcl/source/control/button.cxx @@ -300,6 +300,7 @@ void Button::ImplDrawAlignedImage(OutputDevice* pDev, Point& rPos, Size aTextSize; Size aSymbolSize; +Size aDeviceTextSize; Size aMax; Point aImagePos = rPos; Point aTextPos = rPos; @@ -359,7 +360,7 @@ void Button::ImplDrawAlignedImage(OutputDevice* pDev, Point& rPos, aRect.Bottom() -= (aImageSize.Height() + nImageSep); } -aRect = pDev->GetTextRect(aRect, aText, nTextStyle); +aRect = GetControlTextRect(*pDev, aRect, aText, nTextStyle, ); aTextSize = aRect.GetSize(); aTSSize.Width() += aTextSize.Width(); @@ -513,7 +514,7 @@ void Button::ImplDrawAlignedImage(OutputDevice* pDev, Point& rPos, { const Rectangle aTOutRect(aTextPos, aTextSize); ImplSetFocusRect(aTOutRect); -DrawControlText(*pDev, aTOutRect, aText, nTextStyle, nullptr, nullptr); +DrawControlText(*pDev, aTOutRect, aText, nTextStyle, nullptr, nullptr, ); } else { diff --git a/vcl/source/control/ctrl.cxx b/vcl/source/control/ctrl.cxx index f75e54f..78b9295 100644 --- a/vcl/source/control/ctrl.cxx +++ b/vcl/source/control/ctrl.cxx @@ -413,7 +413,7 @@ void Control::ImplInitSettings(const bool, const bool) } Rectangle Control::DrawControlText( OutputDevice& _rTargetDevice, const Rectangle& rRect, const OUString& _rStr, -DrawTextFlags _nStyle, MetricVector* _pVector, OUString* _pDisplayText ) const +DrawTextFlags _nStyle, MetricVector* _pVector, OUString* _pDisplayText, const
[Libreoffice-bugs] [Bug 105426] Performance regression in hunspell 1.4.0 vs 1.3.4 vs 1.3.3
https://bugs.documentfoundation.org/show_bug.cgi?id=105426 Aron Budeachanged: What|Removed |Added Summary|Performance regression in |Performance regression in |hunspell 1.3.4 vs 1.3.3 |hunspell 1.4.0 vs 1.3.4 vs ||1.3.3 --- Comment #6 from Aron Budea --- Sure enough, this is the source of the second slowdown: https://cgit.freedesktop.org/libreoffice/core/commit/?id=1098921996c81a4d6dc917bbc16d5f834ebf6728 "test pre 1.4.0 hunspell" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105426] Performance regression in hunspell 1.3.4 vs 1.3.3
https://bugs.documentfoundation.org/show_bug.cgi?id=105426 Aron Budeachanged: What|Removed |Added Keywords|bibisectRequest | --- Comment #5 from Aron Budea --- d2e19f851cbbaf05cf39a651c3b645b82ac975ca is the first bad commit commit d2e19f851cbbaf05cf39a651c3b645b82ac975ca Author: Norbert Thiebaud Date: Sat Apr 23 02:17:34 2016 -0700 source sha:1098921996c81a4d6dc917bbc16d5f834ebf6728 # bad: [c1d414d7a844a3f5e10a7ad9519ebfaa1b402f01] source sha:ceaa06bc7153387238eead0a69d874ed35241793 # good: [1540320dd5f15974767df02970e9f3338042069f] source sha:3a09d852db28245633d06d0c79744a7780b19f1a git bisect start 'c1d414d7a844a3f5e10a7ad9519ebfaa1b402f01' '1540320dd5f15974767df02970e9f3338042069f' # bad: [848590900633c602c307eabaa13bf98d5be79932] source sha:376c337d46acf8819bf032251bfc7d5eb31db198 git bisect bad 848590900633c602c307eabaa13bf98d5be79932 # bad: [68bb5e2e704bcf40d4886f523a81957e4e18ef87] source sha:b24cc067695d7986f231303218e7b853d827b316 git bisect bad 68bb5e2e704bcf40d4886f523a81957e4e18ef87 # good: [efe2f539e2cf53613435ca6e49c2146f377a92fb] source sha:577fbba417454da8cd461da71fee8b97896d2497 git bisect good efe2f539e2cf53613435ca6e49c2146f377a92fb # bad: [95bd680b85109da1d4e9ad76213a27220c2c9fa4] source sha:0154776f2d0bc13e44411e67f6b02bd5032b18a0 git bisect bad 95bd680b85109da1d4e9ad76213a27220c2c9fa4 # bad: [4d0c764b0d3b3e6af20fc737dd75b0b7bf9b307f] source sha:555c9add26e06030402c73f885de98f4b96826f0 git bisect bad 4d0c764b0d3b3e6af20fc737dd75b0b7bf9b307f # good: [69eaf9f321844b0a0a7a1c8870a284690c020fd4] source sha:766280b8ebbb61d4c06828322575911839adb7ce git bisect good 69eaf9f321844b0a0a7a1c8870a284690c020fd4 # good: [6d587a996a619e721c643c8fbc6591a0cc099522] source sha:43faf91ee36646af5c13cfc5af649c3ff2f3297b git bisect good 6d587a996a619e721c643c8fbc6591a0cc099522 # good: [4269c9ba5cb439fdeff5e1aa8f74910f972a9ce6] source sha:2e6a05d6da0ae33a456b1ca40677df56611e779c git bisect good 4269c9ba5cb439fdeff5e1aa8f74910f972a9ce6 # bad: [a0ec67382970a20072ad3293e5efb1ead9e7d5b6] source sha:304f50684d3ac08e973fd27e6acf3e821394d164 git bisect bad a0ec67382970a20072ad3293e5efb1ead9e7d5b6 # bad: [d2e19f851cbbaf05cf39a651c3b645b82ac975ca] source sha:1098921996c81a4d6dc917bbc16d5f834ebf6728 git bisect bad d2e19f851cbbaf05cf39a651c3b645b82ac975ca # good: [f92fe348f4984da5de1f3a358f095cd4f668733a] source sha:1ee570a4e625719f8bf270d372926c0d829ae6f0 git bisect good f92fe348f4984da5de1f3a358f095cd4f668733a # first bad commit: [d2e19f851cbbaf05cf39a651c3b645b82ac975ca] source sha:1098921996c81a4d6dc917bbc16d5f834ebf6728 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105424] textbox and rectangle fill transparency altered when file is loaded.
https://bugs.documentfoundation.org/show_bug.cgi?id=105424 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #6 from Xisco Faulí --- Hello Bill, I can't reproduce it in Version: 5.4.0.0.alpha0+ Build ID: 4b3e8de6b3cb971b02aa0cb90aceb9e104071d3b CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk2; Locale: ca-ES (ca_ES.UTF-8); Calc: group it seems you're using an old version of LibreOffice. Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105424] textbox and rectangle fill transparency altered when file is loaded.
https://bugs.documentfoundation.org/show_bug.cgi?id=105424 Billchanged: What|Removed |Added Status|NEEDINFO|UNCONFIRMED CC||mattison.compu...@yahoo.com Ever confirmed|1 |0 --- Comment #5 from Bill --- requested file attached. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105424] textbox and rectangle fill transparency altered when file is loaded.
https://bugs.documentfoundation.org/show_bug.cgi?id=105424 --- Comment #4 from Bill--- Created attachment 130540 --> https://bugs.documentfoundation.org/attachment.cgi?id=130540=edit Impress file corresponding to the other 2 attachments. This is the Impress file that was screen-captured in the other two attachments. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 105371] Labels "Find:" and "Replace:" need more width
https://bugs.documentfoundation.org/show_bug.cgi?id=105371 --- Comment #13 from poma--- $ libreoffice --version LibreOffice 5.3.0.2 30(Build:2) -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 105371] Labels "Find:" and "Replace:" need more width
https://bugs.documentfoundation.org/show_bug.cgi?id=105371 --- Comment #13 from poma--- $ libreoffice --version LibreOffice 5.3.0.2 30(Build:2) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105426] Performance regression in hunspell 1.3.4 vs 1.3.3
https://bugs.documentfoundation.org/show_bug.cgi?id=105426 Xisco Faulíchanged: What|Removed |Added CC||caol...@redhat.com, ||xiscofa...@libreoffice.org --- Comment #4 from Xisco Faulí --- Current hunspell version in LibreOffice is 1.5.4 and the latest hunspell version is 1.6.0 which fixes some performance problems. Perhaps, upgrading to 1.6.0 fixes this problem... @Caolan, any thought on this? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105371] Labels "Find:" and "Replace:" need more width
https://bugs.documentfoundation.org/show_bug.cgi?id=105371 --- Comment #12 from poma--- Created attachment 130539 --> https://bugs.documentfoundation.org/attachment.cgi?id=130539=edit Similarities button destiny -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 105371] Labels "Find:" and "Replace:" need more width
https://bugs.documentfoundation.org/show_bug.cgi?id=105371 --- Comment #11 from poma--- Created attachment 130538 --> https://bugs.documentfoundation.org/attachment.cgi?id=130538=edit Find & Replace: Make room for the longest translated labels and Similarities button -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 105371] Labels "Find:" and "Replace:" need more width
https://bugs.documentfoundation.org/show_bug.cgi?id=105371 --- Comment #12 from poma--- Created attachment 130539 --> https://bugs.documentfoundation.org/attachment.cgi?id=130539=edit Similarities button destiny -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 105371] Labels "Find:" and "Replace:" need more width
https://bugs.documentfoundation.org/show_bug.cgi?id=105371 --- Comment #11 from poma--- Created attachment 130538 --> https://bugs.documentfoundation.org/attachment.cgi?id=130538=edit Find & Replace: Make room for the longest translated labels and Similarities button -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105409] Crash when right-click on spelling error or grammar error when contextual menu is modified via API
https://bugs.documentfoundation.org/show_bug.cgi?id=105409 --- Comment #13 from Olivier R.--- With the daily build: Version: 5.3.1.0.0+ Build ID: 832856e058477dd0edabbe1448f41fbc969d4f7e CPU Threads: 8; OS Version: Windows 6.1; UI Render: default; Layout Engine: new; TinderBox: Win-x86@62-merge-TDF, Branch:libreoffice-5-3, Time: 2017-01-18_07:05:46 Locale: fr-FR (fr_FR); Calc: CL LO also freezes and I have to kill the process manually. The crash reporter also failed to send reports. Error message: “Error.” -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42029] Can't access toolbar split/ group button dropdowns from chevron button on smaller window size
https://bugs.documentfoundation.org/show_bug.cgi?id=42029 Maxim Monastirskychanged: What|Removed |Added CC||xtrajo...@gmail.com --- Comment #39 from Maxim Monastirsky --- *** Bug 105425 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 42029] Can't access toolbar split/ group button dropdowns from chevron button on smaller window size
https://bugs.documentfoundation.org/show_bug.cgi?id=42029 Maxim Monastirskychanged: What|Removed |Added CC||xtrajo...@gmail.com --- Comment #39 from Maxim Monastirsky --- *** Bug 105425 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 105425] no colour picker when accessing font color menu inside a popup-toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=105425 Maxim Monastirskychanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Maxim Monastirsky --- *** This bug has been marked as a duplicate of bug 42029 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105429] New: Names of cell style in Calc not localized
https://bugs.documentfoundation.org/show_bug.cgi?id=105429 Bug ID: 105429 Summary: Names of cell style in Calc not localized Product: LibreOffice Version: 5.3.0.1 rc Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: leiflod...@gmail.com Description: Ubuntu Linux 64 bit. LibreOffice 5.3.0.2 Danish language pack (da-DK) In Calc the names of cell styles are in English (Standard, Accent, Heading, Status, Text etc.) These strings have been translated for months now. Actual Results: Style names are in English Expected Results: Style names should be in Danish Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 93073] Add the ability to bookmark or comment spelling/ grammar mistakes in text from spellcheck dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=93073 --- Comment #6 from shelagh.man...@gmail.com --- Would it be hard to add a comment at a particular point through the spellcheck dialog? I think that would be a useful thing as well. You don't always know how people will use tools for their own benefit. But the bookmark button looks good in the mockup picture. I read through the article on navigator but am not sure how it relates to using navigator for spellcheck bookmarks. Are you suggesting that the bookmarks can somehow be made into collections related to whether they are general, spelling or grammar bookmarks and so make it easier to find them? Cheers Shelagh -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 93073] Add the ability to bookmark or comment spelling/ grammar mistakes in text from spellcheck dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=93073 --- Comment #6 from shelagh.man...@gmail.com --- Would it be hard to add a comment at a particular point through the spellcheck dialog? I think that would be a useful thing as well. You don't always know how people will use tools for their own benefit. But the bookmark button looks good in the mockup picture. I read through the article on navigator but am not sure how it relates to using navigator for spellcheck bookmarks. Are you suggesting that the bookmarks can somehow be made into collections related to whether they are general, spelling or grammar bookmarks and so make it easier to find them? Cheers Shelagh -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 93073] Add the ability to bookmark or comment spelling/ grammar mistakes in text from spellcheck dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=93073 --- Comment #5 from shelagh.man...@gmail.com --- Would it be hard to add a comment at a particular point through the spellcheck dialog? I think that would be a useful thing as well. You don't always know how people will use tools for their own benefit. But the bookmark button looks good in the mockup picture. I read through the article on navigator but am not sure how it relates to using navigator for spellcheck bookmarks. Are you suggesting that the bookmarks can somehow be made into collections related to whether they are general, spelling or grammar bookmarks and so make it easier to find them? Cheers Shelagh -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 93073] Add the ability to bookmark or comment spelling/ grammar mistakes in text from spellcheck dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=93073 --- Comment #5 from shelagh.man...@gmail.com --- Would it be hard to add a comment at a particular point through the spellcheck dialog? I think that would be a useful thing as well. You don't always know how people will use tools for their own benefit. But the bookmark button looks good in the mockup picture. I read through the article on navigator but am not sure how it relates to using navigator for spellcheck bookmarks. Are you suggesting that the bookmarks can somehow be made into collections related to whether they are general, spelling or grammar bookmarks and so make it easier to find them? Cheers Shelagh -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 104050] Add Breeze palette
https://bugs.documentfoundation.org/show_bug.cgi?id=104050 --- Comment #8 from Heiko Tietze--- (In reply to Jean-Baptiste Faure from comment #7) > May I suggest you to check? Please do so ;-). Missed the soc file in my local configuration. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 100813] Writer crashes immediately after opening this .docx or on scroll ( Linux fixed here, Windows in other bug)
https://bugs.documentfoundation.org/show_bug.cgi?id=100813 Xisco Faulíchanged: What|Removed |Added Priority|medium |highest Severity|normal |critical --- Comment #54 from Xisco Faulí --- following Stuart's steps I can reproduce it in Version: 5.4.0.0.alpha0+ Build ID: db4badfc971b9cc60809c3408f579bae04a77c34 CPU Threads: 1; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-01-10_23:25:07 Locale: es-ES (es_ES); Calc: group but not in Version: 5.4.0.0.alpha0+ Build ID: 4b3e8de6b3cb971b02aa0cb90aceb9e104071d3b CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk2; Locale: ca-ES (ca_ES.UTF-8); Calc: group Raising severity and priority -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105410] Crash in: ScCondFormatDlg::OkPressed()
https://bugs.documentfoundation.org/show_bug.cgi?id=105410 --- Comment #13 from Xisco Faulí--- (In reply to MM from comment #12) > Unconfirmed with v5.1.6.2 under ubuntu 16.04 x64. > Confirmed with v5.2.4.2 under ubuntu 16.04 x64. > Confirmed (under ubuntu 16.04 x64) with Version: 5.4.0.0.alpha0+ > Build ID: ec1afa55e8ed79dc290caff74aaca304a77c3b4f > CPU Threads: 2; OS Version: Linux 4.4; UI Render: default; VCL: gtk2; > TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: > 2017-01-14_01:33:36 > Locale: en-US (en_US.UTF-8); Calc: single Hi MM, it's interesting you can reproduce it in 5.2.4.2 on Ubuntu... Can you give me more details about it? any further step you did ? Regarding the crash in 5.4.0.0.alpha0+ it should be fixed in tomorrow's build... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105424] textbox and rectangle fill transparency altered when file is loaded.
https://bugs.documentfoundation.org/show_bug.cgi?id=105424 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #3 from Xisco Faulí --- Hello Bill, Thank you for reporting the bug. Please attach a sample document, as this makes it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided. (Please note that the attachment will be public, remove any sensitive information before attaching it. See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105427] : trendline formula wrong for second degree polynomial approximation
https://bugs.documentfoundation.org/show_bug.cgi?id=105427 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #1 from Xisco Faulí --- it seems you're using an old version of LibreOffice. Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105402] Resize from any corner but bottom right causes freeze
https://bugs.documentfoundation.org/show_bug.cgi?id=105402 Xisco Faulíchanged: What|Removed |Added Resolution|FIXED |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105428] Delay when re-opening the edit style menu
https://bugs.documentfoundation.org/show_bug.cgi?id=105428 Telestochanged: What|Removed |Added Keywords||bibisectRequest, regression Status|UNCONFIRMED |NEW CC||ba...@caesar.elte.hu Summary|Delay when re-opening the |Delay when re-opening the |edit style menu for a |edit style menu |second time after launch| Ever confirmed|0 |1 --- Comment #1 from Telesto --- Setting to NEW. Confirmed on IRC: [20:12] Telesto: i agree, please do the same thing :) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105428] New: Delay when re-opening the edit style menu for a second time after launch
https://bugs.documentfoundation.org/show_bug.cgi?id=105428 Bug ID: 105428 Summary: Delay when re-opening the edit style menu for a second time after launch Product: LibreOffice Version: 5.3.0.1 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: There is a delay when reopening the Edit style menu for a second time after launch, one which wasn't there before Steps to Reproduce: 1.Open a Writer document. 2. Right Click it and select "Edit Style" (will take a few sec). 3. Close it. 4. Open it again; There is a small delay (2 sec) in 5.3.0.2 Actual Results: There is a small delay for reopening the "Edit Style" menu, which wasn't there before Expected Results: Instantaneous opening Reproducible: Always User Profile Reset: No Additional Info: Found in: Version: 5.4.0.0.alpha0+ Build ID: 99eed8293d9a9689788a4134dd05d5c20c5a CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-01-14_23:37:40 Locale: nl-NL (nl_NL); Calc: CL and in: Versie: 5.3.0.2 Build ID: 5ad7b2889021c491af62f7930a4b1cb631392f16 CPU Threads: 4; Versie besturingssysteem:Windows 6.2; UI Render: standaard; Layout-Engine: nieuw; Locale: nl-NL (nl_NL); Calc: CL but not in Versie: 5.3.0.0.alpha1 Build ID: f4ca1573fcf445164c068c1046ab5d084e1b005f CPU Threads: 4; Versie besturingssysteem:Windows 6.2; UI Render: standaard; Locale: nl-NL (nl_NL); Calc: CL User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs