[Libreoffice-bugs] [Bug 105461] Highlighting text in textbox is lost when exporting in pdf

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105461

--- Comment #2 from Jean-Baptiste Faure  ---
Reproducible with LO 5.3.1.0+ and current master:
Version: 5.4.0.0.alpha0+
Build ID: 8fa02e0b6ad67c34c23e99140c236153eb7e3faf
Threads CPU : 4; Version de l'OS :Linux 4.4; UI Render : par défaut; VCL :
gtk3; 
Ubuntu_16.04_x86-64
Locale : fr-FR (fr_FR.UTF-8); Calc: group

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105461] Highlighting text in textbox is lost when exporting in pdf

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105461

--- Comment #1 from Jean-Baptiste Faure  ---
Created attachment 130592
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130592=edit
document example with a textbox containing an highlighted text

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105461] New: Highlighting text in textbox is lost when exporting in pdf

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105461

Bug ID: 105461
   Summary: Highlighting text in textbox is lost when exporting in
pdf
   Product: LibreOffice
   Version: 5.2.4.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jbfa...@libreoffice.org

Description:
Highlighting text in textbox inserted in a text document is lost when exporting
in pdf format and printing to file.






Steps to Reproduce:
1/ open a new empty text document
2/ insert a textbox
3/ in this textbox type some text
4/ select the text in the textbox and apply an highlight color
5/ export the document as pdf or print to file


Actual Results:  
Current behavior : the pdf shows the text without highlight color
Note: if you apply some font effects like color or overlining, they are
correctly exported in the pdf.

Expected Results:
Expected: the pdf shows the text highlighted


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:50.0) Gecko/20100101
Firefox/50.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93529

Aron Budea  changed:

   What|Removed |Added

 Depends on||105277


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105277
[Bug 105277] Icon of Chemistry extension cannot seeing clearly when OpenGL is
enabled
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94691] [META] OpenGL bugs

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94691

Aron Budea  changed:

   What|Removed |Added

 Depends on|105277  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105277
[Bug 105277] Icon of Chemistry extension cannot seeing clearly when OpenGL is
enabled
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105277] Icon of Chemistry extension cannot seeing clearly when OpenGL is enabled

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105277

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@caesar.elte.hu
  Component|UI  |graphics stack
 Blocks|94691   |93529
 Ever confirmed|0   |1

--- Comment #2 from Aron Budea  ---
Confirmed. Looks exactly like the screenshots in the attached document.

Version: 5.3.0.2
Build ID: 5ad7b2889021c491af62f7930a4b1cb631392f16
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; Layout Engine:
new; 
Locale: hu-HU (hu_HU); Calc: CL


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=93529
[Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+
https://bugs.documentfoundation.org/show_bug.cgi?id=94691
[Bug 94691] [META] OpenGL bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 100151] Crash at the end of slideshow or previews in Impress ( in remote desktop session, for workaround see comment 25)

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100151

--- Comment #41 from Aron Budea  ---
Some findings. Debug build throws this info (error) message:
"Window( sd::ShowWindow()) with live children destroyed: class
SystemChildWindow()"

So what is the difference between the two executions?

We're in: ::sd::Window::dispose().
Then in vcl::Window::dispose() we get to this line:
xCanvasComponent->dispose();
http://opengrok.libreoffice.org/xref/core/vcl/source/window/window.cxx#162


1) In a local instance, this goes into:
directx9canvaslo.dll!dxcanvas::SpriteCanvas::dispose() Line 118 C++


2) In a remote desktop instance this goes into:
vclcanvaslo.dll!vclcanvas::SpriteCanvas::dispose() Line 125 C++

After 2), only later, a couple of levels into the following call we get into
dxcanvas::SpriteCanvas::dispose():
pWrapper->WindowDestroyed( this );
http://opengrok.libreoffice.org/xref/core/vcl/source/window/window.cxx#227

At this point mpRenderModule is empty in the remote desktop connection:
http://opengrok.libreoffice.org/xref/core/canvas/source/directx/dx_spritecanvashelper.cxx#99

Thus DXRenderModule::disposing() is not called where it should be (I assume).
In a local session this is called inside of 1)'s
dxcanvas::SpriteCanvas::dispose().

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 104154] Add list view to template manager

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104154

--- Comment #3 from abhilash300si...@gmail.com ---
Hi Samuel, Akshay. 

mpLocalView(http://opengrok.libreoffice.org/xref/core/sfx2/source/doc/templatedlg.cxx#162)
seems to be handling the thumbnails and mpSearchView seems to handle the same
for the searched results. As is done in the icon/list view patch Samuel
mentions above, I'll have to replace mpLocalView with "mpCurView" and set it
dynamically to either the listview or thumbnailview. 

I can't figure out what the type of "mpCurView" should be. In the reference
patch, both list/icon views derive from a parent class SvTreeListBox (
https://docs.libreoffice.org/svtools/html/classSvTreeListBox.html ). I also
need some help in figuring out code organization into different files and
breaking this task into smaller parts that I can build upon. As of now, I've
only made necessary changes in .ui file and defined click handlers. The WIP
patch is here - https://gerrit.libreoffice.org/#/c/33356/

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 90189] Error saving the document Nonexistent object. Path to the file does not exist

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90189

tommy27  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||ba...@quipo.it
 Ever confirmed|0   |1

--- Comment #1 from tommy27  ---
LibO 5.2.4.2 is out.
please give an update of the bug status.
revert it to UNCONFIRMED if bug is still present
or change it to RESOLVED WORKSFORME if bug is gone

status NEEDINFO until then

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104332] Opening Tools menu is slow for the first time (Writer only)

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104332

tommy27  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||5439

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105439] Around 2-5 second delay when right clicking when launching for the first time after a system reboot

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105439

tommy27  changed:

   What|Removed |Added

 CC||ba...@quipo.it
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4332

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 92276] Installed LibO 5.0 crashes if started when Portable LibO is running ( WinXP x86 specific?)

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92276

--- Comment #19 from tommy27  ---
@Pedro
is the issue still present with LibO 5.2.4.2?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105460] .PPTX text color changed after opening in LibO Impress

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105460

tommy27  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@quipo.it
Version|unspecified |3.5.0 release
Summary|pptx text color changed |.PPTX text color changed
   |after opening in|after opening in LibO
   |LibreOffice Impress |Impress
 Ever confirmed|0   |1

--- Comment #1 from tommy27  ---
I confirm it in LibO 5.2.4.2 and a recent 5.4.0.0 alpha build under Win8.1 x64
not a new issue anyway... it's already present in 3.5.0 too
did not test earlier versions

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105447] "About LibreOffice" keyboard shortcut in "Help" menu

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105447

tommy27  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@quipo.it
 Ever confirmed|0   |1

--- Comment #4 from tommy27  ---
I agree with Ovari
when possible, shortcuts should be assigned to first letters.
status NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 50299] MOD shows not existing, inconsistent, small remainder with calculated Dividend

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=50299

--- Comment #37 from Aron Budea  ---
(In reply to klsu from comment #36)
> Using the above test file dated 2014-12-21 19:00 CET in Version 5.1.4.2,
> Build ID: 1:5.1.4-Oubuntu1, the spreadsheet is still showing 143 of 1000
> results not equal to zero, 72 of which are significant; so the problem still
> exists.

5.1.4.2 is quite old, if you check the bug report mentioned by Eike, the fix is
in 5.3. Testing with 5.3.0.2 and doing a hard recalc on the fields shows no
errors.

> The problem that lead me to the discovery of this one also still occurs in
> Version 5.1.4.2, Build ID: 1:5.1.4-Oubuntu1. That involved converting months
> and displayed as decimals (i.e., European format) to U.S. format in a
> spreadsheet in which everything else is in U.S. format. I've added an
> example of that.

This is quite interesting, the main issue is:
=MOD(24.09;1)*100 is 8.999,
while:
1) 0.09*100 is 9,
2) =MOD(24.09;1) is 0.09.

There's probably a reasonable explanation for it in the handling of floating
point numbers, hopefully someone else can shed some light on that.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105444] extra lines inserted at end of Comments

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105444

--- Comment #6 from pcun...@msn.com ---
@ Telesto: thanks for confirming that this is still an issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105136] TextCursor gotoNextWord method fails when paragraph does not end in period

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105136

vic.orgos+bugslibreoff...@gmail.com changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105136] TextCursor gotoNextWord method fails when paragraph does not end in period

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105136

--- Comment #2 from vic.orgos+bugslibreoff...@gmail.com ---
Created attachment 130591
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130591=edit
Test file containing macro.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/source

2017-01-20 Thread Khaled Hosny
 vcl/source/gdi/sallayout.cxx |6 --
 1 file changed, 6 deletions(-)

New commits:
commit efd58dee26a534ba89d41efff44821b2d8967928
Author: Khaled Hosny 
Date:   Sat Jan 21 03:27:12 2017 +0200

This does not seem to be needed

Change-Id: I3f9a447478062ad4cfbf7bfadfd3fe73523de847

diff --git a/vcl/source/gdi/sallayout.cxx b/vcl/source/gdi/sallayout.cxx
index a3b54e2..6a970f9 100644
--- a/vcl/source/gdi/sallayout.cxx
+++ b/vcl/source/gdi/sallayout.cxx
@@ -39,14 +39,8 @@
 
 #include 
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #include 
 #include 
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 #include 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/inc vcl/source

2017-01-20 Thread Khaled Hosny
 vcl/inc/salglyphid.hxx   |5 -
 vcl/source/gdi/sallayout.cxx |6 ++
 2 files changed, 6 insertions(+), 5 deletions(-)

New commits:
commit ae0a317c20110ade8b9eaef3ecbd2c5781303649
Author: Khaled Hosny 
Date:   Sat Jan 21 03:00:19 2017 +0200

Move these defines to the only file using them

Change-Id: Ic3a32f6b420c3822ba96f57292f67f0327b16581

diff --git a/vcl/inc/salglyphid.hxx b/vcl/inc/salglyphid.hxx
index 8047d50..6f9550e 100644
--- a/vcl/inc/salglyphid.hxx
+++ b/vcl/inc/salglyphid.hxx
@@ -21,11 +21,6 @@
 
 typedef sal_uInt32 sal_GlyphId;
 
-// Glyph Flags
-#define GF_FONTMASK 0xF000
-#define GF_FONTSHIFT 28
-
-#define GF_DROPPED  0x
 
 #endif // INCLUDED_VCL_INC_SALGLYPHID_HXX
 
diff --git a/vcl/source/gdi/sallayout.cxx b/vcl/source/gdi/sallayout.cxx
index 3f77bbc..a3b54e2 100644
--- a/vcl/source/gdi/sallayout.cxx
+++ b/vcl/source/gdi/sallayout.cxx
@@ -51,6 +51,12 @@
 #include 
 #include 
 
+// Glyph Flags
+#define GF_FONTMASK  0xF000
+#define GF_FONTSHIFT 28
+#define GF_DROPPED   0x
+
+
 std::ostream  <<(std::ostream& s, ImplLayoutArgs )
 {
 #ifndef SAL_LOG_INFO
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


New Defects reported by Coverity Scan for LibreOffice

2017-01-20 Thread scan-admin

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

300 new defect(s) introduced to LibreOffice found with Coverity Scan.
21 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 20 of 300 defect(s)


** CID 1399404:  Error handling issues  (UNCAUGHT_EXCEPT)
/sw/source/core/text/redlnitr.cxx: 185 in SwRedlineItr::~SwRedlineItr()()



*** CID 1399404:  Error handling issues  (UNCAUGHT_EXCEPT)
/sw/source/core/text/redlnitr.cxx: 185 in SwRedlineItr::~SwRedlineItr()()
179 pExt = new SwExtend( *pArr, nExtStart );
180 else
181 pExt = nullptr;
182 Seek (rFnt, 0, COMPLETE_STRING);
183 }
184 
>>> CID 1399404:  Error handling issues  (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown 
>>> but the throw list "throw()" doesn't allow it to be thrown. This will cause 
>>> a call to unexpected() which usually calls terminate().
185 SwRedlineItr::~SwRedlineItr()
186 {
187 Clear( nullptr );
188 delete pSet;
189 delete pExt;
190 }

** CID 1399403:  Error handling issues  (UNCAUGHT_EXCEPT)
/sw/source/core/bastyp/calc.cxx: 364 in SwCalc::~SwCalc()()



*** CID 1399403:  Error handling issues  (UNCAUGHT_EXCEPT)
/sw/source/core/bastyp/calc.cxx: 364 in SwCalc::~SwCalc()()
358 nVal.PutString( rUserOptions.GetToken( aAdrToken[ 11 ] ));
359 sTmpStr = OUString::createFromAscii(sNTypeTab[25]);
360 m_aVarTable[ aHashValue[ 25 ] ]->pNext.reset( new SwCalcExp( 
sTmpStr, nVal, nullptr ) );
361 
362 } // SwCalc::SwCalc
363 
>>> CID 1399403:  Error handling issues  (UNCAUGHT_EXCEPT)
>>> An exception of type "std::length_error" is thrown but the throw list 
>>> "throw()" doesn't allow it to be thrown. This will cause a call to 
>>> unexpected() which usually calls terminate().
364 SwCalc::~SwCalc()
365 {
366 for(SwHash* p : m_aVarTable)
367 delete p;
368 
369 if( m_pLocaleDataWrapper != m_aSysLocale.GetLocaleDataPtr() )

** CID 1399402:  Error handling issues  (UNCAUGHT_EXCEPT)
/sw/source/uibase/app/docstyle.cxx: 115 in 
SwImplShellAction::~SwImplShellAction()()



*** CID 1399402:  Error handling issues  (UNCAUGHT_EXCEPT)
/sw/source/uibase/app/docstyle.cxx: 115 in 
SwImplShellAction::~SwImplShellAction()()
109 {
110 pCurrSh = new CurrShell( pSh );
111 pSh->StartAllAction();
112 }
113 }
114 
>>> CID 1399402:  Error handling issues  (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown 
>>> but the throw list "throw()" doesn't allow it to be thrown. This will cause 
>>> a call to unexpected() which usually calls terminate().
115 SwImplShellAction::~SwImplShellAction()
116 {
117 if( pCurrSh )
118 {
119 pSh->EndAllAction();
120 delete pCurrSh;

** CID 1399401:(UNCAUGHT_EXCEPT)
/extensions/source/propctrlr/browserline.cxx: 70 in 
pcr::OBrowserLine::~OBrowserLine()()
/extensions/source/propctrlr/browserline.cxx: 70 in 
pcr::OBrowserLine::~OBrowserLine()()



*** CID 1399401:(UNCAUGHT_EXCEPT)
/extensions/source/propctrlr/browserline.cxx: 70 in 
pcr::OBrowserLine::~OBrowserLine()()
64 ,m_bIndentTitle( false )
65 ,m_bReadOnly( false )
66 {
67 m_aFtTitle->Show();
68 }
69 
>>> CID 1399401:(UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown 
>>> but the throw list "throw()" doesn't allow it to be thrown. This will cause 
>>> a call to unexpected() which usually calls terminate().
70 OBrowserLine::~OBrowserLine()
71 {
72 implHideBrowseButton( true, false );
73 implHideBrowseButton( false, false );
74 m_aFtTitle.disposeAndClear();
75 }
/extensions/source/propctrlr/browserline.cxx: 70 in 
pcr::OBrowserLine::~OBrowserLine()()
64 ,m_bIndentTitle( false )
65 ,m_bReadOnly( false )
66 {
67 m_aFtTitle->Show();
68 }
69 
>>> CID 1399401:(UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown 
>>> but the throw list "throw()" doesn't allow it to be thrown. This will cause 
>>> a call to unexpected() which usually calls terminate().
70 

[Libreoffice-bugs] [Bug 105460] New: pptx text color changed after opening in LibreOffice Impress

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105460

Bug ID: 105460
   Summary: pptx text color changed after opening in LibreOffice
Impress
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: h.alemas...@gmail.com

Created attachment 130590
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130590=edit
original slide + bug image

- open the attached pptx in Impress
- text color is changed after opening in Impress

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 70433] EDITING: Embedded Firebird - List doesn't work in queries, works in external Firebird

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=70433

--- Comment #18 from Tamas Bunth  ---
(In reply to robert from comment #17) 
> Could it be also included to LO 5.3.0?

I think so. But I'm not familiar with the aspects of including code to previous
versions.
It doesn't depend on code created after LO 5.3.0.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105459] New: broken PDF generated

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105459

Bug ID: 105459
   Summary: broken PDF generated
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: h.alemas...@gmail.com

Created attachment 130589
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130589=edit
original slide and generated broken pdf

LibreOffice 4.4 (and 5.1) generates a broken PDF for the attached pptx file. 
Opening the PDF in Acrobat results in "There was an error processing a page.
There was a problem reading this document (109)."

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 50299] MOD shows not existing, inconsistent, small remainder with calculated Dividend

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=50299

--- Comment #36 from k...@cox.net ---
Using the above test file dated 2014-12-21 19:00 CET in Version 5.1.4.2, Build
ID: 1:5.1.4-Oubuntu1, the spreadsheet is still showing 143 of 1000 results not
equal to zero, 72 of which are significant; so the problem still exists.

The problem that lead me to the discovery of this one also still occurs in
Version 5.1.4.2, Build ID: 1:5.1.4-Oubuntu1. That involved converting months
and displayed as decimals (i.e., European format) to U.S. format in a
spreadsheet in which everything else is in U.S. format. I've added an example
of that.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 50299] MOD shows not existing, inconsistent, small remainder with calculated Dividend

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=50299

--- Comment #35 from k...@cox.net ---
Created attachment 130588
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130588=edit
Conversion to DATE using MOD to get month from 2 decimal places.

Example showing equalities that are not and date conversions that are incorrect
when MOD is used in certain ways.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105447] "About LibreOffice" keyboard shortcut in "Help" menu

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105447

Óvári  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|WONTFIX |---

--- Comment #3 from Óvári  ---
(In reply to V Stuart Foote from comment #2)
> Why?
Hopefully this will provide some clear purpose why the change…

Cleaning the LibreOffice code was criticised by some as a waste of time as it
did not provide any extra functionality; however, long term it was the right
decision…

Helping people over the phone, you can ask them to press Alt+H then the letter
‘A’; same as other creditable programs…

LibreOffice will be consistent with other programs with ‘A’ as the keyboard
shortcut for “About...”. Examples of the these programs:
Audacity http://www.audacityteam.org/
FileZillahttps://filezilla-project.org/
Firefox  https://www.mozilla.org/firefox/
GIMP https://www.gimp.org/
Microsoft Office 
Nemo Linux Mint file manager
Thunderbird  https://www.mozilla.org/thunderbird/
VLC  https://www.videolan.org/
I’m sure you can find programs that do not have “A” as the keyboard shortcut;
however, it seems that creditable programs do use “A”…

Perhaps it is in the Human Interface Guidelines (HIG)…

Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105458] ROUNDTRIP DOCX: Text within a comment isn't saved into DOCX

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105458

--- Comment #2 from Telesto  ---
Looks like a dupe of bug 90763, but this one has proper steps to reproduce

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105458] ROUNDTRIP DOCX: Text within a comment isn't saved into a DOCX

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105458

Telesto  changed:

   What|Removed |Added

   Keywords||dataLoss

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105458] ROUNDTRIP DOCX: Text within a comment isn't saved into DOCX

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105458

Telesto  changed:

   What|Removed |Added

Summary|ROUNDTRIP DOCX: Text within |ROUNDTRIP DOCX: Text within
   |a comment isn't saved into  |a comment isn't saved into
   |a DOCX  |DOCX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105458] ROUNDTRIP DOCX: Text within a comment isn't saved into a DOCX

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105458

--- Comment #1 from Telesto  ---
Created attachment 130587
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130587=edit
Example file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105458] New: ROUNDTRIP DOCX: Text within a comment isn' t saved into a DOCX

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105458

Bug ID: 105458
   Summary: ROUNDTRIP DOCX: Text within a comment isn't saved into
a DOCX
   Product: LibreOffice
   Version: 4.0.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: critical
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Text within a comment isn't saved (all the time)

Steps to Reproduce:
1.Open attached file
2.Add after AAA: 'BBB' (without quotes)
3.Save (CTRL+S)
4. Add after 'BBB': 'CCC' (without quotes)
5. Save again.
6. Close the document reopen it (text will be gone). Alternatively: Click File
- Reload (A warning will popup that not everything is saved; save again and
everything will be OK) 

Actual Results:  
Text withing comments isn't saved into docx

Expected Results:
Comments should be correctly saved


Reproducible: Always

User Profile Reset: No

Additional Info:
Found in:
Version: 5.4.0.0.alpha0+
Build ID: 99eed8293d9a9689788a4134dd05d5c20c5a
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-01-14_23:37:40
Locale: nl-NL (nl_NL); Calc: CL

and in
Versie 4.0.0.3 (Bouw-id: 7545bee9c2a0782548772a21bc84a9dcc583b89)


User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:45.0) Gecko/20100101
Firefox/45.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/source

2017-01-20 Thread Eike Rathke
 sc/source/core/tool/interpr2.cxx |4 
 sc/source/core/tool/interpr4.cxx |   29 -
 2 files changed, 28 insertions(+), 5 deletions(-)

New commits:
commit b85ee27d9f8039a6442429587598426e73aeb1ba
Author: Eike Rathke 
Date:   Fri Jan 20 23:21:47 2017 +0100

Resolves: tdf#105158 set date or time return type for DATEVALUE TIMEVALUE

... so adding/subtracting another date produces number of days instead of 
date,
and adding/subtracting a number produces date. But if used as the final
formula result force number type.

Change-Id: I046f5cc53d1fe8c9f6f71876787f2f19d24fe146

diff --git a/sc/source/core/tool/interpr2.cxx b/sc/source/core/tool/interpr2.cxx
index 0e4245c..59e87b7 100644
--- a/sc/source/core/tool/interpr2.cxx
+++ b/sc/source/core/tool/interpr2.cxx
@@ -177,7 +177,10 @@ void ScInterpreter::ScGetDateValue()
 {
 short eType = pFormatter->GetType(nFIndex);
 if (eType == css::util::NumberFormat::DATE || eType == 
css::util::NumberFormat::DATETIME)
+{
+nFuncFmtType = css::util::NumberFormat::DATE;
 PushDouble(::rtl::math::approxFloor(fVal));
+}
 else
 PushIllegalArgument();
 }
@@ -937,6 +940,7 @@ void ScInterpreter::ScGetTimeValue()
 short eType = pFormatter->GetType(nFIndex);
 if (eType == css::util::NumberFormat::TIME || eType == 
css::util::NumberFormat::DATETIME)
 {
+nFuncFmtType = css::util::NumberFormat::TIME;
 double fDateVal = rtl::math::approxFloor(fVal);
 double fTimeVal = fVal - fDateVal;
 PushDouble(fTimeVal);
diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index 94d04ac..f32099e 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -3879,11 +3879,12 @@ StackVar ScInterpreter::Interpret()
 // so reassure exceptions are really off.
 SAL_MATH_FPEXCEPTIONS_OFF();
 
+OpCode eOp = ocNone;
 aCode.Reset();
 while( ( pCur = aCode.Next() ) != nullptr
 && (nGlobalError == FormulaError::NONE || nErrorFunction <= 
nErrorFunctionCount) )
 {
-OpCode eOp = pCur->GetOpCode();
+eOp = pCur->GetOpCode();
 cPar = pCur->GetByte();
 if ( eOp == ocPush )
 {
@@ -4454,6 +4455,21 @@ StackVar ScInterpreter::Interpret()
 
 // End: obtain result
 
+bool bForcedResultType;
+switch (eOp)
+{
+case ocGetDateValue:
+case ocGetTimeValue:
+// Force final result of DATEVALUE and TIMEVALUE to number type,
+// which so far was date or time for calculations.
+nRetTypeExpr = nFuncFmtType = css::util::NumberFormat::NUMBER;
+nRetIndexExpr = nFuncFmtIndex = 0;
+bForcedResultType = true;
+break;
+default:
+bForcedResultType = false;
+}
+
 if( sp )
 {
 pCur = pStack[ sp-1 ];
@@ -4476,9 +4492,12 @@ StackVar ScInterpreter::Interpret()
 if (pCur->GetDoubleType())
 {
 const double fVal = PopDouble();
-if (nCurFmtType != nFuncFmtType)
-nRetIndexExpr = 0;  // carry format index only 
for matching type
-nRetTypeExpr = nFuncFmtType = nCurFmtType;
+if (!bForcedResultType)
+{
+if (nCurFmtType != nFuncFmtType)
+nRetIndexExpr = 0;  // carry format index 
only for matching type
+nRetTypeExpr = nFuncFmtType = nCurFmtType;
+}
 PushTempToken( new FormulaDoubleToken( fVal));
 }
 if ( nFuncFmtType == 
css::util::NumberFormat::UNDEFINED )
@@ -4573,7 +4592,7 @@ StackVar ScInterpreter::Interpret()
 else
 SetError( FormulaError::NoCode);
 
-if( nRetTypeExpr != css::util::NumberFormat::UNDEFINED )
+if (bForcedResultType || nRetTypeExpr != 
css::util::NumberFormat::UNDEFINED)
 {
 nRetFmtType = nRetTypeExpr;
 nRetFmtIndex = nRetIndexExpr;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sd/source

2017-01-20 Thread Stephan Bergmann
 sd/source/ui/slidesorter/cache/SlsRequestQueue.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 7a38fa97e0423ac601848c701944aa3f81a17c5c
Author: Stephan Bergmann 
Date:   Fri Jan 20 23:30:34 2017 +0100

Missing 'const'

Change-Id: I203ada1b4c527311ded56e6af0de7a7eb711f3f8

diff --git a/sd/source/ui/slidesorter/cache/SlsRequestQueue.cxx 
b/sd/source/ui/slidesorter/cache/SlsRequestQueue.cxx
index 993aece..c5a7ab4 100644
--- a/sd/source/ui/slidesorter/cache/SlsRequestQueue.cxx
+++ b/sd/source/ui/slidesorter/cache/SlsRequestQueue.cxx
@@ -37,6 +37,7 @@ public:
 */
 class Comparator { public:
 bool operator() (const Request& rRequest1, const Request& rRequest2)
+const
 {
 if (rRequest1.meClass == rRequest2.meClass)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 105444] extra lines inserted at end of Comments

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105444

Telesto  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
Version|5.2.4.2 release |4.2.0.4 release

--- Comment #5 from Telesto  ---
Also found in:
Versie: 4.2.0.4 
Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71

but not in
Versie: 4.1.0.4 
Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28

Steps to reproduce
1. Insert a Comment (Ctrl + Alt + C)
2. Type text
3. Save as MS Word XML
4. File -> Reload 
5. A a letter to the comment
6. Save again
7. File -> Reload

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 93073] Add the ability to bookmark or comment spelling/ grammar mistakes in text from spellcheck dialog

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93073

--- Comment #11 from shelagh.man...@gmail.com ---
I have read through again what you have said about bookmarks and comments. I am
not a person who generally uses bookmarks and didn't realise that you can name
and add text to a bookmark. If this is so, even if only to name a bookmark, I
agree that comments would probably be overkill.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 93073] Add the ability to bookmark or comment spelling/ grammar mistakes in text from spellcheck dialog

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93073

--- Comment #11 from shelagh.man...@gmail.com ---
I have read through again what you have said about bookmarks and comments. I am
not a person who generally uses bookmarks and didn't realise that you can name
and add text to a bookmark. If this is so, even if only to name a bookmark, I
agree that comments would probably be overkill.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104334] FILEOPEN: DOC: Incorrect StyleRef

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104334

Miklos Vajna  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105444] extra lines inserted at end of Comments

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105444

Telesto  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from Telesto  ---
Repro with:
Version: 5.4.0.0.alpha0+
Build ID: 99eed8293d9a9689788a4134dd05d5c20c5a
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-01-14_23:37:40
Locale: nl-NL (nl_NL); Calc: CL

A new line gets added with every save to docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/source

2017-01-20 Thread Stephan Bergmann
 sw/source/core/unocore/unoportenum.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 64543ae92883438e3b7ec28f421269ff850b2e09
Author: Stephan Bergmann 
Date:   Fri Jan 20 23:14:37 2017 +0100

Missing 'const'

Change-Id: I2110b932f5e27141f137fecf5c2ff8a7f9665bf6

diff --git a/sw/source/core/unocore/unoportenum.cxx 
b/sw/source/core/unocore/unoportenum.cxx
index ff156d2..dad7aae 100644
--- a/sw/source/core/unocore/unoportenum.cxx
+++ b/sw/source/core/unocore/unoportenum.cxx
@@ -253,6 +253,7 @@ namespace
 {
 bool operator () ( const SwAnnotationStartPortion_ImplSharedPtr ,
const SwAnnotationStartPortion_ImplSharedPtr  )
+const
 {
 return r1->maPosition < r2->maPosition;
 }
@@ -696,7 +697,7 @@ struct RedlineCompareStruct
 }
 
 bool operator () ( const SwXRedlinePortion_ImplSharedPtr ,
-   const SwXRedlinePortion_ImplSharedPtr  )
+   const SwXRedlinePortion_ImplSharedPtr  ) const
 {
 return getPosition ( r1 ) < getPosition ( r2 );
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'aoo/trunk' - desktop/source sd/source

2017-01-20 Thread Pedro Giffuni
 desktop/source/deployment/misc/dp_misc.cxx |2 +-
 sd/source/ui/view/viewshe3.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 22bae4d4a630509ddbf026bf8a79d1c43af55442
Author: Pedro Giffuni 
Date:   Fri Jan 20 20:16:27 2017 +

Fix mismatches found by Clang-4.0.

Reported on FreeBSD's bugzilla [1].
Unfortunately it is likely more issues remain.

[1]
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216206

diff --git a/desktop/source/deployment/misc/dp_misc.cxx 
b/desktop/source/deployment/misc/dp_misc.cxx
index b31c4f3..9903eab 100644
--- a/desktop/source/deployment/misc/dp_misc.cxx
+++ b/desktop/source/deployment/misc/dp_misc.cxx
@@ -103,7 +103,7 @@ const OUString OfficePipeId::operator () ()
 }
 
 rtlDigest digest = rtl_digest_create( rtl_Digest_AlgorithmMD5 );
-if (digest <= 0) {
+if (digest == nullptr) {
 throw RuntimeException(
 OUSTR("cannot get digest rtl_Digest_AlgorithmMD5!"), 0 );
 }
diff --git a/sd/source/ui/view/viewshe3.cxx b/sd/source/ui/view/viewshe3.cxx
index 0ae7145..e196261 100644
--- a/sd/source/ui/view/viewshe3.cxx
+++ b/sd/source/ui/view/viewshe3.cxx
@@ -226,7 +226,7 @@ SdPage* ViewShell::CreateOrDuplicatePage (
 // When the given page is NULL then use the first page of the document.
 SdPage* pTemplatePage = pPage;
 if (pTemplatePage == NULL)
-if (pDocument->GetSdPage(0, ePageKind) > 0)
+if (pDocument->GetSdPage(0, ePageKind) != nullptr)
 pTemplatePage = pDocument->GetSdPage(0, ePageKind);
 if (pTemplatePage != NULL && pTemplatePage->TRG_HasMasterPage())
 aVisibleLayers = pTemplatePage->TRG_GetMasterPageVisibleLayers();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sd/source

2017-01-20 Thread Stephan Bergmann
 sd/source/ui/sidebar/AllMasterPagesSelector.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8fa02e0b6ad67c34c23e99140c236153eb7e3faf
Author: Stephan Bergmann 
Date:   Fri Jan 20 22:58:55 2017 +0100

Missing 'const'

Change-Id: Ia1cced46dc8c76a252952129fb93be9d5a281057

diff --git a/sd/source/ui/sidebar/AllMasterPagesSelector.cxx 
b/sd/source/ui/sidebar/AllMasterPagesSelector.cxx
index 9654c7b..596d1870 100644
--- a/sd/source/ui/sidebar/AllMasterPagesSelector.cxx
+++ b/sd/source/ui/sidebar/AllMasterPagesSelector.cxx
@@ -53,7 +53,7 @@ class MasterPageDescriptorOrder
 public:
 bool operator() (
 const SharedMasterPageDescriptor& rp1,
-const SharedMasterPageDescriptor& rp2)
+const SharedMasterPageDescriptor& rp2) const
 {
 if (rp1->meOrigin == MasterPageContainer::DEFAULT)
 return true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 105445] PDF Export ignores "Export comments" checkbox

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105445

--- Comment #3 from Zineta  ---
Anyway,you can hide all comments with one mouse click selecting  all sheet and
than go to menu Sheet->Cell comment->Hide comment  before export ods document 
to PDF.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105448] Making more language specific features available

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105448

--- Comment #5 from Khaled Hosny  ---
(In reply to Volga from comment #4)
> (In reply to Khaled Hosny from comment #3)
> > (In reply to Volga from comment #2)
> > > (In reply to Khaled Hosny from comment #1)
> > > > You can already use any BCP47 language tag in LibreOffice.
> > > 
> > > Oh, how can I use them for Manchu and Sibe?
> > 
> > Where do you want to use them?
> 
> Well, they are already has their own language tag in the specification, but
> they seems not found in Writer, at least in Character dialog.

You can just type the language code in the Language field.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 46738] FILESAVE Cell background and border color formatting information of empty cells lost after export to xls or xlsx

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=46738

Bartosz  changed:

   What|Removed |Added

   Assignee|gan...@poczta.onet.pl   |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93529

Aron Budea  changed:

   What|Removed |Added

 Depends on||105453


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105453
[Bug 105453] LibO 5.3.0.2 crashes on start with opengl enabled, 5.3.0.1 was OK
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105453] LibO 5.3.0.2 crashes on start with opengl enabled, 5.3.0.1 was OK

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105453

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
Version|unspecified |5.3.0.2 rc
 Blocks||93529


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=93529
[Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105453] LibO 5.3.0.2 crashes on start with opengl enabled, 5.3.0.1 was OK

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105453

sergio.calleg...@gmail.com changed:

   What|Removed |Added

Summary|LibO 5.3.0.2 crashes on |LibO 5.3.0.2 crashes on
   |start in Kubuntu 16.10  |start with opengl enabled,
   ||5.3.0.1 was OK

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105453] LibO 5.3.0.2 crashes on start in Kubuntu 16.10

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105453

--- Comment #4 from sergio.calleg...@gmail.com ---
glxinfo, for completeness

name of display: :0
display: :0  screen: 0
direct rendering: Yes
server glx vendor string: SGI
server glx version string: 1.4
server glx extensions:
GLX_ARB_create_context, GLX_ARB_create_context_profile, 
GLX_ARB_create_context_robustness, GLX_ARB_fbconfig_float, 
GLX_ARB_framebuffer_sRGB, GLX_ARB_multisample, 
GLX_EXT_create_context_es2_profile, GLX_EXT_create_context_es_profile, 
GLX_EXT_fbconfig_packed_float, GLX_EXT_framebuffer_sRGB, 
GLX_EXT_import_context, GLX_EXT_texture_from_pixmap, GLX_EXT_visual_info, 
GLX_EXT_visual_rating, GLX_INTEL_swap_event, GLX_MESA_copy_sub_buffer, 
GLX_OML_swap_method, GLX_SGIS_multisample, GLX_SGIX_fbconfig, 
GLX_SGIX_pbuffer, GLX_SGIX_visual_select_group, GLX_SGI_swap_control
client glx vendor string: Mesa Project and SGI
client glx version string: 1.4
client glx extensions:
GLX_ARB_create_context, GLX_ARB_create_context_profile, 
GLX_ARB_create_context_robustness, GLX_ARB_fbconfig_float, 
GLX_ARB_framebuffer_sRGB, GLX_ARB_get_proc_address, GLX_ARB_multisample, 
GLX_EXT_buffer_age, GLX_EXT_create_context_es2_profile, 
GLX_EXT_create_context_es_profile, GLX_EXT_fbconfig_packed_float, 
GLX_EXT_framebuffer_sRGB, GLX_EXT_import_context, 
GLX_EXT_texture_from_pixmap, GLX_EXT_visual_info, GLX_EXT_visual_rating, 
GLX_INTEL_swap_event, GLX_MESA_copy_sub_buffer, 
GLX_MESA_multithread_makecurrent, GLX_MESA_query_renderer, 
GLX_MESA_swap_control, GLX_OML_swap_method, GLX_OML_sync_control, 
GLX_SGIS_multisample, GLX_SGIX_fbconfig, GLX_SGIX_pbuffer, 
GLX_SGIX_visual_select_group, GLX_SGI_make_current_read, 
GLX_SGI_swap_control, GLX_SGI_video_sync
GLX version: 1.4
GLX extensions:
GLX_ARB_create_context, GLX_ARB_create_context_profile, 
GLX_ARB_create_context_robustness, GLX_ARB_fbconfig_float, 
GLX_ARB_framebuffer_sRGB, GLX_ARB_get_proc_address, GLX_ARB_multisample, 
GLX_EXT_buffer_age, GLX_EXT_create_context_es2_profile, 
GLX_EXT_create_context_es_profile, GLX_EXT_fbconfig_packed_float, 
GLX_EXT_framebuffer_sRGB, GLX_EXT_import_context, 
GLX_EXT_texture_from_pixmap, GLX_EXT_visual_info, GLX_EXT_visual_rating, 
GLX_INTEL_swap_event, GLX_MESA_copy_sub_buffer, 
GLX_MESA_multithread_makecurrent, GLX_MESA_query_renderer, 
GLX_MESA_swap_control, GLX_OML_swap_method, GLX_OML_sync_control, 
GLX_SGIS_multisample, GLX_SGIX_fbconfig, GLX_SGIX_pbuffer, 
GLX_SGIX_visual_select_group, GLX_SGI_make_current_read, 
GLX_SGI_swap_control, GLX_SGI_video_sync
Extended renderer info (GLX_MESA_query_renderer):
Vendor: Intel Open Source Technology Center (0x8086)
Device: Mesa DRI Intel(R) Haswell Mobile  (0xd26)
Version: 17.1.0
Accelerated: yes
Video memory: 1536MB
Unified memory: yes
Preferred profile: core (0x1)
Max core profile version: 4.5
Max compat profile version: 3.0
Max GLES1 profile version: 1.1
Max GLES[23] profile version: 3.1
OpenGL vendor string: Intel Open Source Technology Center
OpenGL renderer string: Mesa DRI Intel(R) Haswell Mobile 
OpenGL core profile version string: 4.5 (Core Profile) Mesa 17.1.0-devel
OpenGL core profile shading language version string: 4.50
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile
OpenGL core profile extensions:
GL_3DFX_texture_compression_FXT1, GL_AMD_conservative_depth, 
GL_AMD_draw_buffers_blend, GL_AMD_seamless_cubemap_per_texture, 
GL_AMD_shader_trinary_minmax, GL_AMD_vertex_shader_layer, 
GL_AMD_vertex_shader_viewport_index, GL_ANGLE_texture_compression_dxt3, 
GL_ANGLE_texture_compression_dxt5, GL_APPLE_object_purgeable, 
GL_ARB_ES2_compatibility, GL_ARB_ES3_1_compatibility, 
GL_ARB_ES3_compatibility, GL_ARB_arrays_of_arrays, GL_ARB_base_instance, 
GL_ARB_blend_func_extended, GL_ARB_buffer_storage, 
GL_ARB_clear_buffer_object, GL_ARB_clear_texture, GL_ARB_clip_control, 
GL_ARB_compressed_texture_pixel_storage, GL_ARB_compute_shader, 
GL_ARB_conditional_render_inverted, GL_ARB_conservative_depth, 
GL_ARB_copy_buffer, GL_ARB_copy_image, GL_ARB_cull_distance, 
GL_ARB_debug_output, GL_ARB_depth_buffer_float, GL_ARB_depth_clamp, 
GL_ARB_derivative_control, GL_ARB_direct_state_access, 
GL_ARB_draw_buffers, GL_ARB_draw_buffers_blend, 
GL_ARB_draw_elements_base_vertex, GL_ARB_draw_indirect, 
GL_ARB_draw_instanced, GL_ARB_enhanced_layouts, 
GL_ARB_explicit_attrib_location, GL_ARB_explicit_uniform_location, 
GL_ARB_fragment_coord_conventions, GL_ARB_fragment_layer_viewport, 
GL_ARB_fragment_shader, GL_ARB_framebuffer_no_attachments, 
GL_ARB_framebuffer_object, GL_ARB_framebuffer_sRGB, 
GL_ARB_get_program_binary, GL_ARB_get_texture_sub_image, 
GL_ARB_gpu_shader5, GL_ARB_gpu_shader_fp64, GL_ARB_half_float_pixel, 
   

[Libreoffice-bugs] [Bug 105447] "About LibreOffice" keyboard shortcut in "Help" menu

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105447

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
Version|5.3.0.1 rc  |Inherited From OOo
 Resolution|--- |WONTFIX

--- Comment #2 from V Stuart Foote  ---
Why?

No conflict with the accelerator selected. It has been set to this accelerator
for duration, not clear a change would serve any purpose.

=-ref-=

http://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu#5375

and its unit test

http://opengrok.libreoffice.org/xref/core/configmgr/qa/unit/data.xcd#4552

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105444] extra lines inserted at end of Comments

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105444

--- Comment #3 from pcun...@msn.com ---
(In reply to Timur from comment #2)
> Which version did you test with and on which OS?
> There was Bug 85523 but it was fixed.

See above. Version 5.2.4.2 (release) for Windows (I'm using 7).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105444] extra lines inserted at end of Comments

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105444

pcun...@msn.com changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105456] Date Format MM/DD/YY not accepting 17 in YY position

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105456

Ray  changed:

   What|Removed |Added

 Resolution|INVALID |FIXED

--- Comment #5 from Ray  ---
(In reply to Eike Rathke from comment #4)
> Whatever, "Date Invalid" is not a Calc message during cell input. More
> likely a validation or macro in your document bound to some input cells.
> Furthermore, the two digits year range quite certainly was not "1936 to
> 2020" because the range is always 100 years. Either 1936 to 2035, or 1921 to
> 2020, or something completely different. Maybe it was set to 1917 to 2016,
> which could explain why a validation macro said "Date invalid", because
> input of 17 lead to 1917 and the validation doesn't accept values before
> 19xx something.

I may have gotten the start date wrong but the ending was 2020. And there was a
problem and is now fixed. Probably because I also removed the direct formatting
and reformatted the cells. Funny how the problem just started with the change
in year date. Sorry for taking up everybody's time. The first response was more
help by suggesting an area to correct instead of telling me my problem was
invalid. I think this will be the first and last bug report. Sorry again for
the inconvenience.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105427] : trendline formula wrong for second degree polynomial approximation

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105427

andi  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from andi  ---
o.k., I got the concept now and had a wrong understanding of how the trandline
is calculated. It is not calculated with the given points (x1/y1) ...(xn/yn)
but with (1/y1) ..(n/yn)

Thanks for this clarification! 

I set the status to "resolved". Thanks again!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105055] Crash in: ScPostIt::CreateCaption(ScAddress const &, SdrCaptionObj const *)

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105055

--- Comment #12 from stefan_lange...@t-online.de  
---
For me this is OK, because the patch to solve the problem of bug 104967 also
solves the problem of bug 105055.

Tested with
Version: 5.4.0.0.alpha0+
Build ID: cef8ebe925bde6fc1889085e3ccb1be236791e99
CPU Threads: 1; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-01-20_02:26:12
Locale: de-DE (de_DE); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sw/source

2017-01-20 Thread Mike Kaganski
 sw/source/core/layout/flowfrm.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 8098cdaca08abaf12a32bbebcd058a98c2af03bd
Author: Mike Kaganski 
Date:   Wed Jan 18 09:25:55 2017 +0300

tdf#104181 related: don't throw on this document

Related to: 
http://crashreport.libreoffice.org/stats/signature/SwContentFrame::MoveFootnoteCntFwd(bool,SwFootnoteBossFrame%20*)

Change-Id: I53abf3267e1a75e944de8c6ea80a72de0e7e
Reviewed-on: https://gerrit.libreoffice.org/33245
Reviewed-by: Mike Kaganski 
Tested-by: Mike Kaganski 
(cherry picked from commit 1281bd5d87361fa516cdf247b055aeb4bb5e13fb)
Reviewed-on: https://gerrit.libreoffice.org/6
Tested-by: Jenkins 

diff --git a/sw/source/core/layout/flowfrm.cxx 
b/sw/source/core/layout/flowfrm.cxx
index d517103..f9faba4 100644
--- a/sw/source/core/layout/flowfrm.cxx
+++ b/sw/source/core/layout/flowfrm.cxx
@@ -1800,6 +1800,9 @@ bool SwFlowFrame::MoveFwd( bool bMakePage, bool 
bPageBreak, bool bMoveAlways )
 {
 //MoveFootnoteCntFwd might need to be updated as well.
 SwFootnoteBossFrame *pOldBoss = m_rThis.FindFootnoteBossFrame();
+assert(pOldBoss);
+if (!pOldBoss)
+return false;
 if (m_rThis.IsInFootnote())
 {
 if (!m_rThis.IsContentFrame())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 105158] When copying sheets, cells which use TODAY() inappropriately have Date number format forced

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105158

Eike Rathke  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |

--- Comment #6 from Eike Rathke  ---
Per description not reproducible. Loading the sample document the cell already
is formatted to date. Removing that (context menu Clear Direct Formatting) the
cell has value -233 (today), copying that to the clipboard, adding a new sheet
and pasting the cell to the new sheet the value is still -233.

However, that the cell after load is formatted to date is wrong, the document
doesn't say it's a date. Also entering that formula in a new cell without
formatting it results in date.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: ODF TC issue 2049 custom shape enhancement

2017-01-20 Thread Mark Hung
Hi Regina,

Sorry that being late to reply about this topic. I've spend some time in
oox last year. I try to make built-in shapes export to ooxml as much as
possible. It might be a little wired, but my major concern about blending
to another color value is how reset of the filters can emulate the effect.
Currently users can group different shapes with different transparency.
That might be an alternative although there are still differences.

Best Regards.

2017-01-14 23:34 GMT+08:00 Regina Henschel :

> Hi all,
>
> the ODF TC is going to discuss
> https://issues.oasis-open.org/browse/OFFICE-2049.
> The MS Office preset shapes have subpaths, which are lighten or darken,
> e.g. the shape type “Borders”, which is “quad-bevel” in LibreOffice. The
> issue is about adding a way to store such subpath information in the file.
> In ODF 1.2 it is not possible.
>
> Apache OpenOffice does not store the information, but renders the shape
> depending on its type name. That works only for the preset shapes of OOXML.
> In LibreOffice this subpath information is stored as new path commands.
> LibreOffice uses an own namespace “drawooo” for that. This has been added
> by commits by Radek Doulik at 2012-01-11.
>
> But the implementation is faulty, see
> https://bugs.documentfoundation.org/show_bug.cgi?id=105266.
> On the other hand there is the request for multiple colors for the
> enhanced-geometry, see
> https://bugs.documentfoundation.org/show_bug.cgi?id=103298
>
> I can imagine this solution: Add a new attribute to the
>  element which carries a list of value pairs. Such
> pair has a factor from [0;1] for the degree of blending and a color value
> for the blending color. Such attribute would be able to carry the
> information needed for “lighten” and “darken”, but give the additional
> opportunity to implement color change in subpath.
>
> My question, should ODF 1.3 follow the current LO way and add new path
> commands? Or do you like my other idea, or do you have a different idea?
>
> Kind regards
> Regina
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>



-- 
Mark Hung
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 105055] Crash in: ScPostIt::CreateCaption(ScAddress const &, SdrCaptionObj const *)

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105055

Eike Rathke  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #11 from Eike Rathke  ---
This most likely is a duplicate of bug 104967 as the backtrace and crashreports
indicate, CreateCaption() happens under CopyFromClip(), presumably also here if
the originating document was closed before.

*** This bug has been marked as a duplicate of bug 104967 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105456] Date Format MM/DD/YY not accepting 17 in YY position

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105456

Eike Rathke  changed:

   What|Removed |Added

 Resolution|FIXED   |INVALID

--- Comment #4 from Eike Rathke  ---
Whatever, "Date Invalid" is not a Calc message during cell input. More likely a
validation or macro in your document bound to some input cells. Furthermore,
the two digits year range quite certainly was not "1936 to 2020" because the
range is always 100 years. Either 1936 to 2035, or 1921 to 2020, or something
completely different. Maybe it was set to 1917 to 2016, which could explain why
a validation macro said "Date invalid", because input of 17 lead to 1917 and
the validation doesn't accept values before 19xx something.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: build breaks in embeddedobj/source/msole/olemisc.cxx

2017-01-20 Thread Regina Henschel

Hi Khaled,

Khaled Hosny schrieb:

On Fri, Jan 20, 2017 at 04:55:56PM +0100, Regina Henschel wrote:

Hi,

Khaled Hosny schrieb:


Hmm, interesting. They don’t fail for me or in the CI builds, I wonder
what is different on your system that would cause most of the tests to
fail?



Can you tell me, what is relevant for the tests? Then I can post information
about my system.


I’m still to get to the bottom of these tests, but my hunch is that they
are very sensitive to fonts, since the file used seem to use all sorts
of fonts that might or might not always be installed. So have you done
anything unusual with the fonts on your system?


"ClearType" is activated on my system.

I've got about 350 fonts, a lot of them with the common four font faces. 
These include the fonts, which you get from Windows to support Asian 
languages.


The text size in Windows for the screen is set to 125%.

I've got a "ATI Radeon HD 3200 Graphics" on board graphics card and use 
it in 1920 x 1080.


I don't know, whether this is "unusual".

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 105444] extra lines inserted at end of Comments

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105444

Timur  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from Timur  ---
Which version did you test with and on which OS?
There was Bug 85523 but it was fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105457] New: [RFE] Investigate supporting Plotinus

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105457

Bug ID: 105457
   Summary: [RFE] Investigate supporting Plotinus
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vha...@gmail.com

Hi,

For anyone used to atom/sublime/vscode and other rocking editors, one of the
core features is what's referred to as a "command palette". In all the
aforementioned, it's accessed by the Ctrl-Shift-P shortcut (C-S-p). In GIMP,
it's accessed by default - at least on Linux - with /.

An awesome individual has now made a generic library that enables this in "all"
GTK3 applications, and it is amazingly excellent.

Except, it doesn't work in LibreOffice. Here's a quote from the developer
himself, in the relevant issue on github[1]:

"Yeah, not quite sure what to do here. The problem is that Plotinus needs to
register a global shortcut within the host application. I do not know of any
reliable way to do that other than using a GtkApplication.

Besides that, everything is already in place, and LibreOffice has been using
native GTK menus for a year or so. Therefore, if the shortcut problem were
solved, the menu entries should appear immediately."

I can hack, but I'm not familiar with either the OOo or GTK codebases, so it
seems like a lot to learn for something that I assume is either a very quick
fix or a deeper issue with the toolkit couplings that would take immense
efforts.

But if anyone wants to point me in the right direction (as opposed to fixing it
themselves), I could take a whack at it.

1: https://github.com/p-e-w/plotinus/issues/7

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: cui/source include/vcl svx/source vcl/source vcl/workben

2017-01-20 Thread Caolán McNamara
 cui/source/customize/cfg.cxx|3 ---
 include/vcl/image.hxx   |2 +-
 svx/source/engine3d/float3d.cxx |3 +--
 vcl/source/window/toolbox2.cxx  |2 --
 vcl/workben/outdevgrind.cxx |2 ++
 5 files changed, 4 insertions(+), 8 deletions(-)

New commits:
commit 370613e5917366698d4d9ec078f79f9a48ce8b02
Author: Caolán McNamara 
Date:   Fri Jan 20 11:42:31 2017 +

warn about unused Images

Change-Id: I5502b28411282354019af51a09c860099c652006
Reviewed-on: https://gerrit.libreoffice.org/33348
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx
index d411fa8..4a77f42 100644
--- a/cui/source/customize/cfg.cxx
+++ b/cui/source/customize/cfg.cxx
@@ -3539,8 +3539,6 @@ IMPL_LINK( SvxToolbarConfigPage, EntrySelectHdl, 
MenuButton *, pButton, void )
 GetSaveInData()->GetImageManager()->replaceImages(
 GetImageType(), aURLSeq, aGraphicSeq );
 
-Image aImage( newgraphic );
-
 m_pContentsListBox->GetModel()->Remove( pActEntry );
 SvTreeListEntry* pNewLBEntry =
 InsertEntryIntoUI( pEntry, nSelectionPos );
@@ -3595,7 +3593,6 @@ IMPL_LINK( SvxToolbarConfigPage, EntrySelectHdl, 
MenuButton *, pButton, void )
 GetSaveInData()->GetImageManager()->replaceImages(
 GetImageType(), aURLSeq, aGraphicSeq );
 
-Image aImage( backup );
 m_pContentsListBox->GetModel()->Remove( pActEntry );
 
 SvTreeListEntry* pNewLBEntry =
diff --git a/include/vcl/image.hxx b/include/vcl/image.hxx
index 88a0c04..752b900 100644
--- a/include/vcl/image.hxx
+++ b/include/vcl/image.hxx
@@ -50,7 +50,7 @@ namespace vcl
 
 #define IMAGELIST_IMAGE_NOTFOUND((sal_uInt16)0x)
 
-class VCL_DLLPUBLIC Image
+class SAL_WARN_UNUSED VCL_DLLPUBLIC Image
 {
 friend class ::OutputDevice;
 
diff --git a/svx/source/engine3d/float3d.cxx b/svx/source/engine3d/float3d.cxx
index b20b711..6791a73 100644
--- a/svx/source/engine3d/float3d.cxx
+++ b/svx/source/engine3d/float3d.cxx
@@ -1847,8 +1847,7 @@ void Svx3DWin::GetAttr( SfxItemSet& rAttrs )
 else
 rAttrs.InvalidateItem(SDRATTR_3DSCENE_FOCAL_LENGTH);
 
-// Lighting
-Image aImg;
+// Lighting
 basegfx::B3DVector aVector;
 Color aColor;
 const SfxItemSet 
aLightItemSet(m_pCtlLightPreview->GetSvx3DLightControl().Get3DAttributes());
diff --git a/vcl/source/window/toolbox2.cxx b/vcl/source/window/toolbox2.cxx
index 037d228..10cede7 100644
--- a/vcl/source/window/toolbox2.cxx
+++ b/vcl/source/window/toolbox2.cxx
@@ -972,7 +972,6 @@ void ToolBox::SetItemImage( sal_uInt16 nItemId, const 
Image& rImage )
 
 static Image ImplRotImage( const Image& rImage, long nAngle10 )
 {
-Image   aRet;
 BitmapExaRotBitmapEx( rImage.GetBitmapEx() );
 
 aRotBitmapEx.Rotate( nAngle10, Color( COL_WHITE ) );
@@ -1011,7 +1010,6 @@ void ToolBox::SetItemImageAngle( sal_uInt16 nItemId, long 
nAngle10 )
 
 static Image ImplMirrorImage( const Image& rImage )
 {
-Image   aRet;
 BitmapExaMirrBitmapEx( rImage.GetBitmapEx() );
 
 aMirrBitmapEx.Mirror( BmpMirrorFlags::Horizontal );
diff --git a/vcl/workben/outdevgrind.cxx b/vcl/workben/outdevgrind.cxx
index 0e0e19d..f4c8c7d 100644
--- a/vcl/workben/outdevgrind.cxx
+++ b/vcl/workben/outdevgrind.cxx
@@ -138,7 +138,9 @@ void setupMethodStubs( functor_vector_type& res )
 const BitmapExaBitmapExAlpha( aBitmap, aBitmapAlien );
 const BitmapExaBitmapExAlphaAlien( aBitmapAlien, aBitmapAlien );
 
+#ifdef NEEDS_QUALIY_PARAMTER
 const Image   aImage( aBitmapEx );
+#endif
 const Gradient
aGradient(GradientStyle::Elliptical,aBlackColor,aWhiteColor);
 const Hatch   aHatch(HatchStyle::Triple,aBlackColor,4,450);
 const Wallpaper   aWallpaper( aWhiteColor );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 105453] LibO 5.3.0.2 crashes on start in Kubuntu 16.10

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105453

--- Comment #3 from sergio.calleg...@gmail.com ---
Version is in the title, as I cannot find it in the dropdown yet.

I have narrowed down the source of the issue to openGL implementation.

In 5.3.0.1 I had both UseOpenGL and ForceOpenGL set to true in my LibO user
registry. With this LibO was working just fine, indicating OpenGL as active.

With 5.3.0.2 LibO crashes with this setup during the display of its splash
screen.

To have 5.3.0.2 work on my system, I need to set /both/ UseOpenGL and
ForceOpenGL to false.

My system has Intel Haswell graphics on linux, with a very recent Mesa.

The issue has one particularly nasty aspect. All those users coming from 5.2.x
or 5.3.0.1 with UseOpenGL and ForceOpenGL set to true might get the crash in
5.3.0.2 before the application gets a some point where the OpenGL setting can
be changed. This leaves them with only two options:

- erasing their profile and restarting with a default profile (which means
loosing a lot of tuning, configuration and extensions); or
- manually editing the registrymodifications.xcu file with an external editor
(which might go beyond the experience of many users).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: build breaks in embeddedobj/source/msole/olemisc.cxx

2017-01-20 Thread Khaled Hosny
On Fri, Jan 20, 2017 at 04:55:56PM +0100, Regina Henschel wrote:
> Hi,
> 
> Khaled Hosny schrieb:
> 
> > Hmm, interesting. They don’t fail for me or in the CI builds, I wonder
> > what is different on your system that would cause most of the tests to
> > fail?
> > 
> 
> Can you tell me, what is relevant for the tests? Then I can post information
> about my system.

I’m still to get to the bottom of these tests, but my hunch is that they
are very sensitive to fonts, since the file used seem to use all sorts
of fonts that might or might not always be installed. So have you done
anything unusual with the fonts on your system?

Regards,
Khaled
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 105456] Date Format MM/DD/YY not accepting 17 in YY position

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105456

Ray  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Ray  ---
I did two things. First,I removed the direct formatting and reformatted the
column I was using for dates; then I went to Options - LibreOffice - General -
and changed the 'Year (two digit' range from "1936 to 2020" to "1946 to "2046".
With these two changes I went back to the spreadsheet and enter the date for
the entry as usual (01/19/17)and the year entry was accepted as typed. Weird. I
also checked the "Accept date Format" under languages and made no changes, it
did show 'm/d/y; m/d'.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105448] Making more language specific features available

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105448

--- Comment #4 from Volga  ---
(In reply to Khaled Hosny from comment #3)
> (In reply to Volga from comment #2)
> > (In reply to Khaled Hosny from comment #1)
> > > You can already use any BCP47 language tag in LibreOffice.
> > 
> > Oh, how can I use them for Manchu and Sibe?
> 
> Where do you want to use them?

Well, they are already has their own language tag in the specification, but
they seems not found in Writer, at least in Character dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: LibreOffice Android for GSoC'17

2017-01-20 Thread Aleksandar Stefanović
Hello,

It is under active development if you actively develop on it ;)

On a serious note, it is under development, and you're always welcome to
contribute to the project. When you add a commit, add me to the reviewers
and I'll gladly review it.
There are two Android applications available: LO Viewer, which is the
"main" application, and Impress Remote, which is used for
remotely-controlling Impress presentations.
If you want to discuss potential changes that you want to introduce, but
you're unsure whether you should, or you have questions about the project,
I'm open for discussion.

2017-01-20 19:13 GMT+01:00 Jan Iversen :

> Welcome.
>
>
>
> Hello,
>
> I'm looking forward to contributing in LibreOffice for GSoC'17.
> I'm good with Java and Android. I want to know if LibreOffice Android is
> under active development or not.
>
> It sure is, I have Aleksandar CC on the mail, I hope he can help you get
> started.
>
> Rgds
> jan I.
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 63259] It should be possible to use shift + F3 case change, when cursor is at the beginning or end of a word and not only in the middle

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=63259

Justin L  changed:

   What|Removed |Added

 CC||jl...@mail.com

--- Comment #10 from Justin L  ---
Created attachment 130586
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130586=edit
ShiftF3_startEnd.diff1: patch enabling ShiftF3 to work at the beginning and end
of a word

Great care is need with this bug. It is using a function called
TransliterateText() which contains modules like
TransliterationModules_ignoreBaFa_ja_JP,
TransliterationModules_ignoreIterationMark_ja_JP,
TransliterationModules_IGNORE_KANA,
TransliterationModules_HIRAGANA_KATAKANA etc.

Transliteration text was first introduced by author jp 
 
2000-12-21 08:32:45 (GMT) in commit 52c520fd72373eb4d5ccd5edbb73e896c8731038
new: transliteration.

The section dealing with beginning/end positioning of the cursor has been
largely untouched since then. This patch fixes this for English, but unknown
how it affects other users or languages.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: [Libreoffice-commits] core.git: include/svl sc/source solenv/gdb svl/qa svl/source svx/source sw/source

2017-01-20 Thread Eike Rathke
Hi Noel,

On Tuesday, 2017-01-17 08:08:08 +, Noel Grandin wrote:

> commit 2757ee9fe610e253e4ccc37423fa420004d0f388
> Author: Noel Grandin 
> Date:   Mon Jan 9 10:27:22 2017 +0200
> 
> used std::map in SfxItemSet
> 
> instead of naked array

I suspect that introduced some performance drawback, which can be seen
as spikes of some tests at
http://perf.libreoffice.org/perf_html/suite_calc.html if the spike
occurs on Jan-17, for example in
http://perf.libreoffice.org/perf_html/tdf100709_load_of_calc_on_vm139.details.html
drilling into 30 days
http://perf.libreoffice.org/perf_html/tdf100709_load_of_calc_on_vm139.r30.details.html
and unchecking all but Ir, Cest and Runtime, the commit before the jump
with Ir: 6,537,893,256  is
https://cgit.freedesktop.org/libreoffice/core/log/?id=98397a48f1f33be3405b0f462fc20422f6363b68
and after the jump with Ir: 7,379,267,469  is
https://cgit.freedesktop.org/libreoffice/core/log/?id=a3bb39324e5e2cff2699e830454358ac1597
in which span is commit 2757ee9fe610e253e4ccc37423fa420004d0f388

Could you check if there are optimizations possible now that std::map is used?

Thanks
  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 93073] Add the ability to bookmark or comment spelling/ grammar mistakes in text from spellcheck dialog

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93073

--- Comment #10 from Cor Nouws  ---
(In reply to Heiko Tietze from comment #9)

> Cor's point is that the spellchecker is one dialog for all modules. There is
> no special Writer solution. Option 1: Cut it from Calc/Draw/Impress. Option
> 2: back into retreat and find a better solution. ;-)
Hiding a control in Impress/Calc should not be a problem, I guess.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 93073] Add the ability to bookmark or comment spelling/ grammar mistakes in text from spellcheck dialog

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93073

--- Comment #10 from Cor Nouws  ---
(In reply to Heiko Tietze from comment #9)

> Cor's point is that the spellchecker is one dialog for all modules. There is
> no special Writer solution. Option 1: Cut it from Calc/Draw/Impress. Option
> 2: back into retreat and find a better solution. ;-)
Hiding a control in Impress/Calc should not be a problem, I guess.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 105456] Date Format MM/DD/YY not accepting 17 in YY position

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105456

Ray  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #2 from Ray  ---
Did check the format selected and my selection was MM/DD/YY. This format has
been in used in my spreadsheets for at least 3 years and has worked just fine
until the current year. I just went and changed the format to MM/DD/ and
2017 is accepted. Also checked other dates past '16' in the MM/DD/YY format and
18, 19  in the YY position is NOT accepted and the error dialog comes up as
"Date Invalid".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105162] OPENGL: Crash when trying to drag some text in Writer

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105162

Aron Budea  changed:

   What|Removed |Added

 OS|All |Windows (All)

--- Comment #6 from Aron Budea  ---
Tomaz tested in Linux with a recent master build, no crash. Setting OS to
Windows.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] dev-tools.git: esc-reporting/esc-analyze.py esc-reporting/esc-tocsv.py

2017-01-20 Thread jan Iversen
 esc-reporting/esc-analyze.py |   56 -
 esc-reporting/esc-tocsv.py   |  248 +++
 2 files changed, 253 insertions(+), 51 deletions(-)

New commits:
commit 2b41473bd4c7fa35d97148ee3565d592e33827ed
Author: jan Iversen 
Date:   Fri Jan 20 19:17:03 2017 +0100

update to support csv request

diff --git a/esc-reporting/esc-analyze.py b/esc-reporting/esc-analyze.py
index eabbd64..76daab7 100755
--- a/esc-reporting/esc-analyze.py
+++ b/esc-reporting/esc-analyze.py
@@ -611,6 +611,11 @@ def runUpgrade(args):
   # create new statlist
   cfg['cutDate'] += datetime.timedelta(days=7)
   cfg['nowDate'] = cfg['cutDate']
+  cfg['1weekDate'] = cfg['nowDate'] - datetime.timedelta(days=7)
+  cfg['1monthDate'] = cfg['nowDate'] - datetime.timedelta(days=30)
+  cfg['3monthDate'] = cfg['nowDate'] - datetime.timedelta(days=90)
+  cfg['1yearDate'] = cfg['nowDate'] - datetime.timedelta(days=365)
+
   statList = util_create_statList()
   statList['aliases'] = csvList['aliases']
   analyze_mentoring()
@@ -618,57 +623,6 @@ def runUpgrade(args):
   analyze_qa()
   analyze_myfunc()
 
-  # combine old statlist with new statlist
-  orgStatList = util_load_data_file(cfg['homedir'] + 'OLDweeks/' + week)
-
-  # copy from old data
-  statList['data']['easyhacks']['assigned'] = 
orgStatList['data']['easyhacks']['assigned']
-  statList['data']['easyhacks']['cleanup_comments'] = 
orgStatList['data']['easyhacks']['cleanup_comments']
-  statList['data']['easyhacks']['needsDevEval'] = 
orgStatList['data']['easyhacks']['needsDevEval']
-  statList['data']['easyhacks']['needsUXEval'] = 
orgStatList['data']['easyhacks']['needsUXEval']
-  statList['data']['easyhacks']['open'] = 
orgStatList['data']['easyhacks']['open']
-  statList['data']['easyhacks']['total'] = 
orgStatList['data']['easyhacks']['total']
-  statList['data']['gerrit']['committer']['1month']['ABANDONED'] = 
orgStatList['data']['gerrit']['committer']['1month']['ABANDONED']
-  statList['data']['gerrit']['committer']['1month']['MERGED'] = 
orgStatList['data']['gerrit']['committer']['1month']['MERGED']
-  statList['data']['gerrit']['committer']['1month']['NEW'] = 
orgStatList['data']['gerrit']['committer']['1month']['NEW']
-  statList['data']['gerrit']['committer']['1month']['reviewed'] = 
orgStatList['data']['gerrit']['committer']['1month']['reviewed']
-  statList['data']['gerrit']['committer']['1week']['ABANDONED'] = 
orgStatList['data']['gerrit']['committer']['1week']['ABANDONED']
-  statList['data']['gerrit']['committer']['1week']['MERGED'] = 
orgStatList['data']['gerrit']['committer']['1week']['MERGED']
-  statList['data']['gerrit']['committer']['1week']['NEW'] = 
orgStatList['data']['gerrit']['committer']['1week']['NEW']
-  statList['data']['gerrit']['committer']['1week']['reviewed'] = 
orgStatList['data']['gerrit']['committer']['1week']['reviewed']
-  statList['data']['gerrit']['committer']['1year']['ABANDONED'] = 
orgStatList['data']['gerrit']['committer']['1year']['ABANDONED']
-  statList['data']['gerrit']['committer']['1year']['MERGED'] = 
orgStatList['data']['gerrit']['committer']['1year']['MERGED']
-  statList['data']['gerrit']['committer']['1year']['NEW'] = 
orgStatList['data']['gerrit']['committer']['1year']['NEW']
-  statList['data']['gerrit']['committer']['1year']['reviewed'] = 
orgStatList['data']['gerrit']['committer']['1year']['reviewed']
-  statList['data']['gerrit']['committer']['3month']['ABANDONED'] = 
orgStatList['data']['gerrit']['committer']['3month']['ABANDONED']
-  statList['data']['gerrit']['committer']['3month']['MERGED'] = 
orgStatList['data']['gerrit']['committer']['3month']['MERGED']
-  statList['data']['gerrit']['committer']['3month']['NEW'] = 
orgStatList['data']['gerrit']['committer']['3month']['NEW']
-  statList['data']['gerrit']['committer']['3month']['reviewed'] = 
orgStatList['data']['gerrit']['committer']['3month']['reviewed']
-  statList['data']['gerrit']['committer']['total'] = 
orgStatList['data']['gerrit']['committer']['1year']['total']
-  statList['data']['gerrit']['contributor']['1month']['ABANDONED'] = 
orgStatList['data']['gerrit']['contributor']['1month']['ABANDONED']
-  statList['data']['gerrit']['contributor']['1month']['MERGED'] = 
orgStatList['data']['gerrit']['contributor']['1month']['MERGED']
-  statList['data']['gerrit']['contributor']['1month']['NEW'] = 
orgStatList['data']['gerrit']['contributor']['1month']['NEW']
-  statList['data']['gerrit']['contributor']['1month']['reviewed'] = 
orgStatList['data']['gerrit']['contributor']['1month']['reviewed']
-  statList['data']['gerrit']['contributor']['1week']['ABANDONED'] = 
orgStatList['data']['gerrit']['contributor']['1week']['ABANDONED']
-  statList['data']['gerrit']['contributor']['1week']['MERGED'] = 

[Libreoffice-bugs] [Bug 104130] DRAW: The explaining text within the comboboxes of the line content panel are cut off

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104130

--- Comment #8 from Cor Nouws  ---
(In reply to Yousuf Philips (jay) from comment #3)
> This doesnt seem to be a problem to me as the preview is visible and the
> text is beneficial when the drop down menu is open and not crucial when it
> is closed.
> 
> So WFM. @Heiko, @Stuart, @Cor: Whats your take?

Agree. However, it looks nicer on Linux:
only preview is visible if the list is collapsed, and the open list is aligned
on the right side of the box, showing preview and text

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: LibreOffice Android for GSoC'17

2017-01-20 Thread Jan Iversen
Welcome.


> 
> Hello,
> 
> I'm looking forward to contributing in LibreOffice for GSoC'17. 
> I'm good with Java and Android. I want to know if LibreOffice Android is 
> under active development or not. 
It sure is, I have Aleksandar CC on the mail, I hope he can help you get 
started.

Rgds
jan I.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


A question about com.sun.star.frame.XStorable's URL

2017-01-20 Thread Takeshi Abe
Hi,

Preparing a patch for tdf#105382 [1], I come across a question about
character encoding for the path part of a URL representing a
com.sun.star.frame.XStorable's location.
I wonder if the original (before percent-encoded) path of such a URL can
be in an encoding other than UTF-8 or even in a different charset due
to e.g. a code page of some legacy filesystems.
Is it possible?
And, if so, is there any reasonable way to tell the encoding?

[1] https://gerrit.libreoffice.org/#/c/33261/

Cheers,
-- Takeshi Abe
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


LibreOffice Android for GSoC'17

2017-01-20 Thread Gautam Prajapati
Hello,

I'm looking forward to contributing in LibreOffice for GSoC'17.
I'm good with Java and Android. I want to know if LibreOffice Android is
under active development or not.

If I want to start with contributing to the project, is this "LibreOffice
for Android most annoying bugs
"
a good place to start or someone can help me with a list of other
introductory bugs so as to get acquainted with the codebase?

Cheers!

Gautam Prajapati
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 105456] Date Format MM/DD/YY not accepting 17 in YY position

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105456

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||ba...@caesar.elte.hu
 Ever confirmed|0   |1

--- Comment #1 from Aron Budea  ---
Please check Date Acceptance Patterns in Tools -> Options...; Language Settings
-> Languages, and if M/D/Y is there, cell formatting only affects output.
Then again, I'm not sure why it gives an error, for me it just isn't recognized
as date if the entry doesn't match acceptance pattern.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104675] Conditional Format not updated on change value in a cell it depends on by formula

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104675

--- Comment #9 from m.a.riosv  ---
And works with:
Version: 5.4.0.0.alpha0+
Build ID: bc8eb82877f544d8cf80e6f3ea02a9993e058491
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-01-17_07:28:47
Locale: es-ES (es_ES); Calc: CL

Only 5.3 affected.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105456] New: Date Format MM/DD/YY not accepting 17 in YY position

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105456

Bug ID: 105456
   Summary: Date Format MM/DD/YY not accepting 17 in YY position
   Product: LibreOffice
   Version: 5.1.6.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gramps1...@outlook.com

Description:
Does not crash. Dialog box appears stating "date invalid" with 01/19/17.
01/19/16 works in same cell. Cell formatted for MM/DD/YY.

Steps to Reproduce:
1.Select cell formatted for date MM/DD/YY
2.Input 01/19/17
3.Press ENTER key

Actual Results:  
Error dialog box appears stating "Date Invalid".

Expected Results:
Accepted the current year of 2017 and dropped down to next line.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/51.0.2704.79 Safari/537.36 Edge/14.14393

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104675] Conditional Format not updated on change value in a cell it depends on by formula

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104675

m.a.riosv  changed:

   What|Removed |Added

   Keywords||regression

--- Comment #8 from m.a.riosv  ---
Work with:
Version: 5.2.5.1 (x64)
Build ID: 0312e1a284a7d50ca85a365c316c7abbf20a4d22
CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; 
Locale: es-ES (es_ES); Calc: group

so regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104675] Conditional Format not updated on change value in a cell it depends on by formula

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104675

m.a.riosv  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #7 from m.a.riosv  ---
Reproducible:
Version: 5.3.0.2 (x64)
Build ID: 5ad7b2889021c491af62f7930a4b1cb631392f16
CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; Layout Engine: new; 
Locale: es-ES (es_ES); Calc: group

Looks the screen it's not refreshed, moving the range of CF out of the screen
forces the screen update.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105411] Crash deleting a conditional format

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105411

--- Comment #4 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=36f2fd038d6dd281358db9d3161d7082d9559f4c

tdf#105411: Add uitest

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: uitest/calc_tests

2017-01-20 Thread Xisco Fauli
 uitest/calc_tests/tdf105411.py |   35 +++
 1 file changed, 35 insertions(+)

New commits:
commit 36f2fd038d6dd281358db9d3161d7082d9559f4c
Author: Xisco Fauli 
Date:   Fri Jan 20 12:10:09 2017 +0100

tdf#105411: Add uitest

Change-Id: Iff93a61441aa13670903ef2dd82de38af4eb5320
Reviewed-on: https://gerrit.libreoffice.org/33347
Tested-by: Jenkins 
Reviewed-by: Xisco Faulí 

diff --git a/uitest/calc_tests/tdf105411.py b/uitest/calc_tests/tdf105411.py
new file mode 100644
index 000..c9910bc
--- /dev/null
+++ b/uitest/calc_tests/tdf105411.py
@@ -0,0 +1,35 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from uitest.framework import UITestCase
+
+class tdf105411(UITestCase):
+
+def test_delete_conditional_format(self):
+
+self.ui_test.create_doc_in_start_center("calc")
+
+
self.ui_test.execute_modeless_dialog_through_command(".uno:ConditionalFormatDialog")
+
+xCondFormatDlg = self.xUITest.getTopFocusWindow()
+
+xDeleteBtn = xCondFormatDlg.getChild("delete")
+xDeleteBtn.executeAction("CLICK", tuple())
+
+xCondFormatDlg = self.xUITest.getTopFocusWindow()
+
+xDeleteBtn = xCondFormatDlg.getChild("add")
+xDeleteBtn.executeAction("CLICK", tuple())
+
+xCondFormatDlg = self.xUITest.getTopFocusWindow()
+
+xOkBtn = xCondFormatDlg.getChild("ok")
+xOkBtn.executeAction("CLICK", tuple())
+
+self.ui_test.close_doc()
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 105455] Input width value to modify Table Column Width then OK by press enter, It does not works.

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105455

odinatlas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from odinatlas  ---
It works in LibreOffice 4.4.7.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105455] Input width value to modify Table Column Width then OK by press enter, It does not works.

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105455

--- Comment #1 from odinatlas  ---
Created attachment 130585
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130585=edit
Modify Column Width

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105455] New: Input width value to modify Table Column Width then OK by press enter, It does not works.

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105455

Bug ID: 105455
   Summary: Input width value to modify Table Column Width then
OK by press enter, It does not works.
   Product: LibreOffice
   Version: 5.3.0.1 rc
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: odinat...@gmail.com

Description:
Input width value to modify Table Column Width then  OK by press enter, It does
not works .
But works by mouse click OK.

Steps to Reproduce:
1.Into Table Properties.
2.Modify Column Width.
3.Input width value, Then OK by press enter.
4.It does not works.

Actual Results:  
Input width value, Then OK by press enter to modify Column Width.


Expected Results:
Input width value, Then OK by press enter.
It does works, So we can work faster.


Reproducible: Always

User Profile Reset: Yes

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:50.0) Gecko/20100101
Firefox/50.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: forms/source

2017-01-20 Thread Caolán McNamara
 forms/source/component/ImageControl.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f9bad9e8fbade0da2c706d37e9a4cc9db5fd44ba
Author: Caolán McNamara 
Date:   Fri Jan 20 17:17:52 2017 +

don't need an intermediate Image

Change-Id: I090d94cfe433763ded70f28b5139772bca229c34

diff --git a/forms/source/component/ImageControl.cxx 
b/forms/source/component/ImageControl.cxx
index 465b859..966bbb1 100644
--- a/forms/source/component/ImageControl.cxx
+++ b/forms/source/component/ImageControl.cxx
@@ -659,7 +659,7 @@ void SAL_CALL OImageControlModel::startProduction(  ) throw 
(RuntimeException, s
 
 IMPL_LINK( OImageControlModel, OnImageImportDone, ::Graphic*, i_pGraphic, void 
)
 {
-const Reference< XGraphic > xGraphic( i_pGraphic != nullptr ? Image( 
i_pGraphic->GetBitmapEx() ).GetXGraphic() : nullptr );
+const Reference< XGraphic > xGraphic(i_pGraphic != nullptr ? 
i_pGraphic->GetXGraphic() : nullptr);
 m_bExternalGraphic = false;
 try
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 105454] vcl harfbuzz / common sal layout: unexpected no wrap of text

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105454

--- Comment #6 from Khaled Hosny  ---
I don’t know off hand, my first thought would be kerning since we always enable
kerning but MSO does not (except in limited cases AFAIK), but this would have
shown up even pre-CSL as we had kerning on by default since 4.1 on Linux IIRC,
but  you can test this by appending “:-kern” to the font name (i.e.
“Callibri:-kern”) and see if it makes any difference (we have an old way to
disable kerning, but it currently ignored since not matter what I did it always
came as off and no way made it on).

If this does not make a difference, then it might be the use of unhinted glyph
advances; prior to CSL we used glyph advances from FreeType which would depend
on the hinting mode being set, but now we use unhinted glyph advances. It does
not seem right for the document layout to be dependent on the hinting mode
being used.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Aleix Pol license statement

2017-01-20 Thread Aleix Pol
All of my past & future contributions to LibreOffice may be
licensed under the MPLv2/LGPLv3+ dual license.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: sw/inc

2017-01-20 Thread Caolán McNamara
 sw/inc/ToxLinkProcessor.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8c32579d4840997e0bfd6075d5b6ecb66d468aa9
Author: Caolán McNamara 
Date:   Fri Jan 20 16:59:18 2017 +

Revert "doesn't seem to be a reason start and end are swapped"

breaks tests apparently

This reverts commit 92bfe7e3052a7540c81d9fa152f55920ad00b8ee.

diff --git a/sw/inc/ToxLinkProcessor.hxx b/sw/inc/ToxLinkProcessor.hxx
index 30fa07e..699c0ec 100644
--- a/sw/inc/ToxLinkProcessor.hxx
+++ b/sw/inc/ToxLinkProcessor.hxx
@@ -70,7 +70,7 @@ private:
  */
 struct ClosedLink {
 ClosedLink(const OUString& url, sal_Int32 startPosition, sal_Int32 
endPosition) :
-mINetFormat(url, OUString()), mStartTextPos(startPosition), 
mEndTextPos(endPosition) {
+mINetFormat(url, OUString()), mStartTextPos(endPosition), 
mEndTextPos(startPosition) {
 }
 SwFormatINetFormat mINetFormat;
 sal_Int32 mStartTextPos;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/source

2017-01-20 Thread Caolán McNamara
 vcl/source/control/imgctrl.cxx |   14 +-
 1 file changed, 5 insertions(+), 9 deletions(-)

New commits:
commit 4a149184210c4ec2e0f0fc2cfeeb0787100110be
Author: Caolán McNamara 
Date:   Fri Jan 20 16:56:19 2017 +

drop pointless pointer for reference

Change-Id: Ia2c32bab6825687d4964e7a6abaa137bb48b3a3c

diff --git a/vcl/source/control/imgctrl.cxx b/vcl/source/control/imgctrl.cxx
index 60d7b79..625706f 100644
--- a/vcl/source/control/imgctrl.cxx
+++ b/vcl/source/control/imgctrl.cxx
@@ -77,9 +77,8 @@ void ImageControl::ImplDraw(OutputDevice& rDev, DrawFlags 
nDrawFlags, const Poin
 }
 
 const Image& rImage( GetModeImage() );
-const Image* pImage = 
 const Rectangle aDrawRect( rPos, rSize );
-if ( !*pImage )
+if (!rImage)
 {
 OUString  sText( GetText() );
 if ( sText.isEmpty() )
@@ -95,23 +94,20 @@ void ImageControl::ImplDraw(OutputDevice& rDev, DrawFlags 
nDrawFlags, const Poin
 return;
 }
 
-const Size&  rBitmapSize = pImage->GetSizePixel();
+const Size& rBitmapSize = rImage.GetSizePixel();
 
 switch ( mnScaleMode )
 {
 case ImageScaleMode::NONE:
 {
-rDev.DrawImage( lcl_centerWithin( aDrawRect, rBitmapSize ), *pImage, 
nStyle );
+rDev.DrawImage(lcl_centerWithin( aDrawRect, rBitmapSize ), rImage, 
nStyle);
 }
 break;
 
 case ImageScaleMode::ISOTROPIC:
 {
 const Size aPaintSize = lcl_calcPaintSize( aDrawRect, rBitmapSize );
-rDev.DrawImage(
-lcl_centerWithin( aDrawRect, aPaintSize ),
-aPaintSize,
-*pImage, nStyle );
+rDev.DrawImage(lcl_centerWithin(aDrawRect, aPaintSize), aPaintSize, 
rImage, nStyle);
 }
 break;
 
@@ -120,7 +116,7 @@ void ImageControl::ImplDraw(OutputDevice& rDev, DrawFlags 
nDrawFlags, const Poin
 rDev.DrawImage(
 aDrawRect.TopLeft(),
 aDrawRect.GetSize(),
-*pImage, nStyle );
+rImage, nStyle );
 }
 break;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: 3 commits - framework/source include/vcl sw/inc vcl/source

2017-01-20 Thread Caolán McNamara
 framework/source/uiconfiguration/imagemanagerimpl.cxx |8 ++---
 include/vcl/commandinfoprovider.hxx   |5 +++
 sw/inc/ToxLinkProcessor.hxx   |2 -
 vcl/source/helper/commandinfoprovider.cxx |   28 --
 4 files changed, 29 insertions(+), 14 deletions(-)

New commits:
commit c41b7a397411814c98dceeea07b0a26f0d01c530
Author: Caolán McNamara 
Date:   Fri Jan 20 16:46:14 2017 +

split GetImageForCommand into GetBitmapForCommand and co

Change-Id: I89431532ef26fc33146252e218096e690825b896

diff --git a/include/vcl/commandinfoprovider.hxx 
b/include/vcl/commandinfoprovider.hxx
index 93f4f3f..0a8e53e 100644
--- a/include/vcl/commandinfoprovider.hxx
+++ b/include/vcl/commandinfoprovider.hxx
@@ -89,6 +89,11 @@ public:
 
 OUString GetCommandPropertyFromModule( const OUString& rCommandName, const 
OUString& rModuleName );
 
+BitmapEx GetBitmapForCommand(
+const OUString& rsCommandName,
+const css::uno::Reference& rxFrame,
+vcl::ImageType eImageType = vcl::ImageType::Small);
+
 Image GetImageForCommand(
 const OUString& rsCommandName,
 const css::uno::Reference& rxFrame,
diff --git a/vcl/source/helper/commandinfoprovider.cxx 
b/vcl/source/helper/commandinfoprovider.cxx
index e48367c..7a844c6 100644
--- a/vcl/source/helper/commandinfoprovider.cxx
+++ b/vcl/source/helper/commandinfoprovider.cxx
@@ -209,14 +209,14 @@ OUString 
CommandInfoProvider::GetRealCommandForCommand(const OUString& rCommandN
 return GetCommandProperty("TargetURL", rCommandName);
 }
 
-Image CommandInfoProvider::GetImageForCommand(const OUString& rsCommandName,
-  const Reference& 
rxFrame,
-  vcl::ImageType eImageType)
+BitmapEx CommandInfoProvider::GetBitmapForCommand(const OUString& 
rsCommandName,
+ const 
Reference& rxFrame,
+ vcl::ImageType eImageType)
 {
 SetFrame(rxFrame);
 
 if (rsCommandName.isEmpty())
-return Image();
+return BitmapEx();
 
 sal_Int16 nImageType(ui::ImageType::COLOR_NORMAL | 
ui::ImageType::SIZE_DEFAULT);
 
@@ -241,10 +241,11 @@ Image CommandInfoProvider::GetImageForCommand(const 
OUString& rsCommandName,
 
 aGraphicSeq = xDocImgMgr->getImages( nImageType, aImageCmdSeq );
 Reference xGraphic = aGraphicSeq[0];
-Image aImage(xGraphic);
+const Graphic aGraphic(xGraphic);
+BitmapEx aBitmap(aGraphic.GetBitmapEx());
 
-if (!!aImage)
-return aImage;
+if (!!aBitmap)
+return aBitmap;
 }
 }
 catch (Exception&)
@@ -264,13 +265,22 @@ Image CommandInfoProvider::GetImageForCommand(const 
OUString& rsCommandName,
 
 Reference xGraphic(aGraphicSeq[0]);
 
-return Image(xGraphic);
+const Graphic aGraphic(xGraphic);
+
+return aGraphic.GetBitmapEx();
 }
 catch (Exception&)
 {
 }
 
-return Image();
+return BitmapEx();
+}
+
+Image CommandInfoProvider::GetImageForCommand(const OUString& rsCommandName,
+  const Reference& 
rxFrame,
+  vcl::ImageType eImageType)
+{
+return Image(GetBitmapForCommand(rsCommandName, rxFrame, eImageType));
 }
 
 sal_Int32 CommandInfoProvider::GetPropertiesForCommand (
commit aa0951b22d958813a41f71f536bb4a07aa0e7f07
Author: Caolán McNamara 
Date:   Fri Jan 20 16:03:08 2017 +

empty Image is an empty XGraphic

Change-Id: I43fa17c2ef9324c841344554b093500d0fb26165

diff --git a/framework/source/uiconfiguration/imagemanagerimpl.cxx 
b/framework/source/uiconfiguration/imagemanagerimpl.cxx
index 6d6e6ba..d1e73bc 100644
--- a/framework/source/uiconfiguration/imagemanagerimpl.cxx
+++ b/framework/source/uiconfiguration/imagemanagerimpl.cxx
@@ -224,7 +224,7 @@ static bool implts_checkAndScaleGraphic( uno::Reference< 
XGraphic >& rOutGraphic
 
 if ( !rInGraphic.is() )
 {
-rOutGraphic = Image().GetXGraphic();
+rOutGraphic = uno::Reference();
 return false;
 }
 
@@ -882,7 +882,7 @@ throw ( css::lang::IllegalArgumentException,
 pDefaultImageList = implts_getDefaultImageList();
 }
 ImageList*pImageList= 
implts_getUserImageList(nIndex);
-uno::Reference< XGraphic >xEmptyGraphic( Image().GetXGraphic() 
);
+uno::Reference xEmptyGraphic;
 
 for ( sal_Int32 i = 0; i < aCommandURLSequence.getLength(); i++ )
 {
@@ -1034,8 +1034,8 @@ void ImageManagerImpl::reload()
 rGlobalImageList  = implts_getGlobalImageList();
 pDefaultImageList = implts_getDefaultImageList();
 }

[Libreoffice-bugs] [Bug 105454] vcl harfbuzz / common sal layout: unexpected no wrap of text

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105454

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: 2 commits - svtools/source vcl/inc vcl/source

2017-01-20 Thread Caolán McNamara
 svtools/source/graphic/provider.cxx |3 +--
 vcl/inc/image.h |   10 ++
 vcl/source/image/Image.cxx  |   26 --
 vcl/source/image/ImplImage.cxx  |8 ++--
 4 files changed, 17 insertions(+), 30 deletions(-)

New commits:
commit d3b94aae205597fdd369989d76a60420ae9b8ab1
Author: Caolán McNamara 
Date:   Fri Jan 20 16:36:10 2017 +

every ImplImage has a BitmapEx

Change-Id: I02561cfdff57eab7684d68c98ba2b3d83847c9c5

diff --git a/vcl/inc/image.h b/vcl/inc/image.h
index 72a7f32..873fc98 100644
--- a/vcl/inc/image.h
+++ b/vcl/inc/image.h
@@ -28,16 +28,10 @@
 struct ImplImage
 {
 BitmapChecksum maBitmapChecksum;
-
-std::unique_ptr mpBitmapEx;
+BitmapEx maBitmapEx;
 BitmapEx maDisabledBitmapEx;
 
-ImplImage();
-~ImplImage();
-
-private:
-ImplImage(const ImplImage&) = delete;
-void operator=(const ImplImage&) = delete;
+ImplImage(const BitmapEx& rBitmapEx);
 };
 
 #endif // INCLUDED_VCL_INC_IMAGE_H
diff --git a/vcl/source/image/Image.cxx b/vcl/source/image/Image.cxx
index bc663fb..d873d3e 100644
--- a/vcl/source/image/Image.cxx
+++ b/vcl/source/image/Image.cxx
@@ -82,8 +82,7 @@ void Image::ImplInit(const BitmapEx& rBitmapEx)
 {
 if (!rBitmapEx.IsEmpty())
 {
-mpImplData.reset(new ImplImage);
-mpImplData->mpBitmapEx.reset(new BitmapEx(rBitmapEx));
+mpImplData.reset(new ImplImage(rBitmapEx));
 }
 }
 
@@ -91,9 +90,9 @@ Size Image::GetSizePixel() const
 {
 Size aRet;
 
-if (mpImplData && mpImplData->mpBitmapEx)
+if (mpImplData)
 {
-aRet = mpImplData->mpBitmapEx->GetSizePixel();
+aRet = mpImplData->maBitmapEx.GetSizePixel();
 }
 
 return aRet;
@@ -103,9 +102,9 @@ BitmapEx Image::GetBitmapEx() const
 {
 BitmapEx aRet;
 
-if (mpImplData && mpImplData->mpBitmapEx)
+if (mpImplData)
 {
-aRet = BitmapEx(*mpImplData->mpBitmapEx);
+aRet = mpImplData->maBitmapEx;
 }
 
 return aRet;
@@ -127,29 +126,28 @@ bool Image::operator==(const Image& rImage) const
 else if (!rImage.mpImplData || !mpImplData)
 bRet = false;
 else
-bRet = *rImage.mpImplData->mpBitmapEx == *mpImplData->mpBitmapEx;
+bRet = rImage.mpImplData->maBitmapEx == mpImplData->maBitmapEx;
 
 return bRet;
 }
 
 void Image::Draw(OutputDevice* pOutDev, const Point& rPos, DrawImageFlags 
nStyle, const Size* pSize)
 {
-if (!mpImplData || !mpImplData->mpBitmapEx ||
-(!pOutDev->IsDeviceOutputNecessary() && pOutDev->GetConnectMetaFile() 
== nullptr))
+if (!mpImplData || (!pOutDev->IsDeviceOutputNecessary() && 
pOutDev->GetConnectMetaFile() == nullptr))
 return;
 
 const Point aSrcPos(0, 0);
-Size aBitmapSizePixel = mpImplData->mpBitmapEx->GetSizePixel();
+Size aBitmapSizePixel = mpImplData->maBitmapEx.GetSizePixel();
 
 Size aOutSize = pSize ? *pSize : pOutDev->PixelToLogic(aBitmapSizePixel);
 
 if (nStyle & DrawImageFlags::Disable)
 {
-BitmapChecksum aChecksum = mpImplData->mpBitmapEx->GetChecksum();
+BitmapChecksum aChecksum = mpImplData->maBitmapEx.GetChecksum();
 if (mpImplData->maBitmapChecksum != aChecksum)
 {
 mpImplData->maBitmapChecksum = aChecksum;
-mpImplData->maDisabledBitmapEx = 
BitmapProcessor::createDisabledImage(*mpImplData->mpBitmapEx);
+mpImplData->maDisabledBitmapEx = 
BitmapProcessor::createDisabledImage(mpImplData->maBitmapEx);
 }
 pOutDev->DrawBitmapEx(rPos, aOutSize, aSrcPos, aBitmapSizePixel, 
mpImplData->maDisabledBitmapEx);
 }
@@ -158,7 +156,7 @@ void Image::Draw(OutputDevice* pOutDev, const Point& rPos, 
DrawImageFlags nStyle
 if (nStyle & (DrawImageFlags::ColorTransform | 
DrawImageFlags::Highlight |
   DrawImageFlags::Deactive | 
DrawImageFlags::SemiTransparent))
 {
-BitmapEx aTempBitmapEx(*mpImplData->mpBitmapEx);
+BitmapEx aTempBitmapEx(mpImplData->maBitmapEx);
 
 if (nStyle & (DrawImageFlags::Highlight | 
DrawImageFlags::Deactive))
 {
@@ -190,7 +188,7 @@ void Image::Draw(OutputDevice* pOutDev, const Point& rPos, 
DrawImageFlags nStyle
 }
 else
 {
-pOutDev->DrawBitmapEx(rPos, aOutSize, aSrcPos, 
mpImplData->mpBitmapEx->GetSizePixel(), *mpImplData->mpBitmapEx);
+pOutDev->DrawBitmapEx(rPos, aOutSize, aSrcPos, 
mpImplData->maBitmapEx.GetSizePixel(), mpImplData->maBitmapEx);
 }
 }
 }
diff --git a/vcl/source/image/ImplImage.cxx b/vcl/source/image/ImplImage.cxx
index ad43120..82a2099 100644
--- a/vcl/source/image/ImplImage.cxx
+++ b/vcl/source/image/ImplImage.cxx
@@ -29,15 +29,11 @@
 #include 
 #include 
 
-ImplImage::ImplImage()
+ImplImage::ImplImage(const BitmapEx )
 : maBitmapChecksum(0)
-, mpBitmapEx()
+, maBitmapEx(rBitmapEx)
 , maDisabledBitmapEx()
 {
 }
 

Re: [Libreoffice-qa] [ANN] LibreOffice 5.3.0 rc2 test builds available

2017-01-20 Thread Tommy

Christian Lohmaier wrote:

Hi *,

for the upcoming new version 5.3.0, the builds for rc2 are now
available on pre-releases.

...

The list of fixed bugs relative to 5.3.0 rc1 is here:

http://dev-builds.libreoffice.org/pre-releases/src/bugs-libreoffice-5-3-0-release-5.3.0.2.log

...


no bug list have been yet published on the wiki...
https://wiki.documentfoundation.org/ReleasePlan/5.3#5.3.0_release

both betas and rc links are still empty

Tommy


___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 104675] Conditional Format not updated on change value in a cell it depends on by formula

2017-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104675

--- Comment #6 from Wolfgang Jäger  ---
Bug still present under V5.3.0.2RC. 

Version: 5.3.0.2 (x64)
Build ID: 5ad7b2889021c491af62f7930a4b1cb631392f16
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; Layout Engine:
new; 
Locale: de-DE (de_DE); Calc: group

Please note:

In the reloaded document the CF FIRST is working as expected.

After a functionlally irrelevant editing (insertion of an accepted space into
the CF formula next to an = sign) the CF did not update on changes to the
parameters in A1:A3. 

The CF now only worked if the view was changed to get the CF range out of sight
and then to get it back into sight. (Scroll / scroll back; Minimize / restore
window ...) 

Not the CF itself but the proper triggering of its recalculation was broken.

The broken recalculation persisted the reversion of the mentioned editing.
After the next reload everything again working as expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   3   >