date:20170125

[Libreoffice-commits] core.git: ucb/source

2017-01-25 Thread Stephan Bergmann

 ucb/source/ucp/webdav/UCBDeadPropertyValue.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9f80fceaa2ed360ef39710eefa5d00f2ad57a718
Author: Stephan Bergmann 
Date:   Thu Jan 26 08:54:57 2017 +0100

loplugin:salbool

Change-Id: I9c34c84d14084e84ab7d9fda78955cf2aebaf5dc

diff --git a/ucb/source/ucp/webdav/UCBDeadPropertyValue.cxx 
b/ucb/source/ucp/webdav/UCBDeadPropertyValue.cxx
index ba82a41..4676966 100644
--- a/ucb/source/ucp/webdav/UCBDeadPropertyValue.cxx
+++ b/ucb/source/ucp/webdav/UCBDeadPropertyValue.cxx
@@ -460,7 +460,7 @@ bool UCBDeadPropertyValue::toXML( const uno::Any & rInData,
 else if ( rType == cppu::UnoType::get() )
 {
 // boolean
-sal_Bool bValue = false;
+bool bValue = false;
 rInData >>= bValue;
 aStringValue = OUString::boolean( bValue );
 aStringType = aTypeBoolean;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104225] VIEWING: sluggishness while scrolling

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104225

--- Comment #3 from Telesto  ---
(In reply to Aron Budea from comment #2)
> Telesto, could you link the original bug the attachment is from for
> reference? Thanks!

bug 104222

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105374] Toolbars and UI elements wrong display

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105374

--- Comment #6 from Buovjaga  ---
Ok, but did you upgrade from 16.04 to 16.10 or did you do a clean install of
16.10?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 36747] Relationally link Save As formats and Default File Formats lists

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=36747

jan iversen  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: Makefile.fetch

2017-01-25 Thread Bryan Quigley

 Makefile.fetch |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 424897ba348093ab1697c676a3e44b9060c5b2da
Author: Bryan Quigley 
Date:   Wed Jan 25 15:13:25 2017 -0500

Stop working around broken IPv6 site

This basically reverts 324212ce01c10a8811d25c95d1ae6a83d8214f3d which
forced wget to only use IPv4.

dev-www.libreoffice.org's IPv6 support was broken for a while.  It
appears to be back to working.

Change-Id: Ib235ddd5719089eaf9d4559bd913571fc46069d1
Reviewed-on: https://gerrit.libreoffice.org/33558
Reviewed-by: jan iversen 
Tested-by: jan iversen 

diff --git a/Makefile.fetch b/Makefile.fetch
index db62719..a350b2f 100644
--- a/Makefile.fetch
+++ b/Makefile.fetch
@@ -11,7 +11,7 @@ fetch_LOGFILE := $(TARFILE_LOCATION)/fetch.log
 
 ifneq (,$(WGET))
 define fetch_Download__wget_command
-&& bash -c '$(WGET) --progress=dot:mega -4 -Q 0 -P "." -l 0 -nd -nH -N 
--no-use-server-timestamps $1/$2 2>&1 | tee -a $(fetch_LOGFILE) && [ 
$$PIPESTATUS -eq 0 ]'
+&& bash -c '$(WGET) --progress=dot:mega -Q 0 -P "." -l 0 -nd -nH -N 
--no-use-server-timestamps $1/$2 2>&1 | tee -a $(fetch_LOGFILE) && [ 
$$PIPESTATUS -eq 0 ]'
 endef
 
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

2017-01-25 Thread Jochen Nitschke

 sc/source/filter/inc/namebuff.hxx |   26 +++---
 1 file changed, 3 insertions(+), 23 deletions(-)

New commits:
commit 9c4c20367dd5b74c4302f9bf71030c23c8c49144
Author: Jochen Nitschke 
Date:   Wed Jan 25 20:06:47 2017 +0100

remove unused operators

Change-Id: Ic35d2071e844235bb755226c55d1e4bbbda4876c
Reviewed-on: https://gerrit.libreoffice.org/33555
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sc/source/filter/inc/namebuff.hxx 
b/sc/source/filter/inc/namebuff.hxx
index 18e8a75..13233c7 100644
--- a/sc/source/filter/inc/namebuff.hxx
+++ b/sc/source/filter/inc/namebuff.hxx
@@ -43,33 +43,13 @@ private:
 static sal_uInt32   MakeHashCode( const OUString& );
 public:
 inline  StringHashEntry( const OUString& );
-inline void operator =( const sal_Char* );
-inline void operator =( const OUString& );
-inline void operator =( const StringHashEntry& );
 inline bool operator ==( const StringHashEntry& ) const;
 };
 
-inline StringHashEntry::StringHashEntry( const OUString& r ) : aString( r )
+inline StringHashEntry::StringHashEntry( const OUString& r )
+: aString( r )
+, nHash( MakeHashCode(r) )
 {
-nHash = MakeHashCode( r );
-}
-
-inline void StringHashEntry::operator =( const sal_Char* p )
-{
-aString = OUString(p, strlen(p), RTL_TEXTENCODING_ASCII_US);
-nHash = MakeHashCode( aString );
-}
-
-inline void StringHashEntry::operator =( const OUString& r )
-{
-aString = r;
-nHash = MakeHashCode( r );
-}
-
-inline void StringHashEntry::operator =( const StringHashEntry& r )
-{
-nHash = r.nHash;
-aString = r.aString;
 }
 
 inline bool StringHashEntry::operator ==( const StringHashEntry& r ) const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

2017-01-25 Thread Jochen Nitschke

 sc/source/filter/inc/namebuff.hxx |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 26273f1c5522e6cccd4acd5e1523b28b277b7331
Author: Jochen Nitschke 
Date:   Wed Jan 25 20:12:27 2017 +0100

fix useless assign

typo from commit a599196064003b724c8ffe3144b77292a4082df3
Date:   Mon Sep 30 14:38:41 2013 +0200
covnert sc/source/filter/inc/namebuff.hxx from String to OUString

'=' should have been '+='
was 'aScAbsName.AppendAscii( RTL_CONSTASCII_STRINGPARAM( "_ABS" ) );'

Change-Id: Ic9c6dcd5c7871c35ae44e6be0f8314d073a863b3
Reviewed-on: https://gerrit.libreoffice.org/33556
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sc/source/filter/inc/namebuff.hxx 
b/sc/source/filter/inc/namebuff.hxx
index 13233c7..8f2b171 100644
--- a/sc/source/filter/inc/namebuff.hxx
+++ b/sc/source/filter/inc/namebuff.hxx
@@ -87,12 +87,11 @@ private:
 Entry( const OUString& rName, const OUString& 
rScName, const ScComplexRefData& rCRD )
 : aStrHashEntry( rName )
 , aScComplexRefDataRel( rCRD )
-, aScAbsName( rScName )
+, aScAbsName( rScName + "_ABS" )
 , nAbsInd(0)
 , nRelInd(0)
 , bSingleRef(false)
 {
-aScAbsName = "_ABS";
 }
 };
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

2017-01-25 Thread Jochen Nitschke

 sc/source/filter/excel/excdoc.cxx   |   33 ++---
 sc/source/filter/excel/excform.cxx  |1 +
 sc/source/filter/excel/exctools.cxx |1 +
 sc/source/filter/excel/impop.cxx|6 +-
 sc/source/filter/excel/namebuff.cxx |   16 
 sc/source/filter/inc/excdoc.hxx |4 
 sc/source/filter/inc/imp_op.hxx |2 --
 sc/source/filter/inc/namebuff.hxx   |   34 --
 8 files changed, 9 insertions(+), 88 deletions(-)

New commits:
commit 2640ec898a043c42f62a46f8381cb43cb33d91c2
Author: Jochen Nitschke 
Date:   Wed Jan 25 20:04:27 2017 +0100

NameBuffer is dead

all getters are gone since
commit 96d44c9b077a6cc8068067a795dc63248ab90fea
Date:   Wed Jul 22 10:20:03 2015 +0200
loplugin:unusedmethods sc

Change-Id: I26b1ac6b24680d0a6045e9a93d40fbbd2caa6a4b
Reviewed-on: https://gerrit.libreoffice.org/33542
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sc/source/filter/excel/excdoc.cxx 
b/sc/source/filter/excel/excdoc.cxx
index 6f3b2ad..e12f107 100644
--- a/sc/source/filter/excel/excdoc.cxx
+++ b/sc/source/filter/excel/excdoc.cxx
@@ -34,7 +34,6 @@
 #include "formulacell.hxx"
 #include "dociter.hxx"
 #include "document.hxx"
-#include "rangenam.hxx"
 #include "dbdata.hxx"
 #include "global.hxx"
 #include "globstr.hrc"
@@ -137,7 +136,6 @@ ExcTable::ExcTable( const XclExpRoot& rRoot ) :
 XclExpRoot( rRoot ),
 mnScTab( SCTAB_GLOBAL ),
 nExcTab( EXC_NOTAB ),
-pTabNames( new NameBuffer( nullptr, 16 ) ),
 mxNoteList( new XclExpNoteList )
 {
 }
@@ -146,7 +144,6 @@ ExcTable::ExcTable( const XclExpRoot& rRoot, SCTAB nScTab ) 
:
 XclExpRoot( rRoot ),
 mnScTab( nScTab ),
 nExcTab( rRoot.GetTabInfo().GetXclTab( nScTab ) ),
-pTabNames( new NameBuffer( nullptr, 16 ) ),
 mxNoteList( new XclExpNoteList )
 {
 }
@@ -174,9 +171,6 @@ void ExcTable::FillAsHeaderBinary( ExcBoundsheetList& 
rBoundsheetList )
 else
 Add( new ExcBofW8 );
 
-SCTAB   nC;
-OUString aTmpString;
-SCTAB  nScTabCount = rTabInfo.GetScTabCount();
 sal_uInt16  nExcTabCount= rTabInfo.GetXclTabCount();
 sal_uInt16  nCodenames  = static_cast< sal_uInt16 >( 
GetExtDocOptions().GetCodeNameCount() );
 
@@ -229,15 +223,6 @@ void ExcTable::FillAsHeaderBinary( ExcBoundsheetList& 
rBoundsheetList )
 
 Add( new XclExpUInt16Record( EXC_ID_FNGROUPCOUNT, 14 ) );
 
-// first setup table names and contents
-
-for( nC = 0 ; nC < nScTabCount ; nC++ )
-if( rTabInfo.IsExportTab( nC ) )
-{
-rDoc.GetName( nC, aTmpString );
-*pTabNames << aTmpString;
-}
-
 if ( GetBiff() <= EXC_BIFF5 )
 {
 // global link table: EXTERNCOUNT, EXTERNSHEET, NAME
@@ -290,6 +275,8 @@ void ExcTable::FillAsHeaderBinary( ExcBoundsheetList& 
rBoundsheetList )
 aRecList.AppendRecord( CreateRecord( EXC_ID_XFLIST ) );
 aRecList.AppendRecord( CreateRecord( EXC_ID_PALETTE ) );
 
+SCTAB   nC;
+SCTAB  nScTabCount = rTabInfo.GetScTabCount();
 if( GetBiff() <= EXC_BIFF5 )
 {
 // Bundlesheet
@@ -326,6 +313,7 @@ void ExcTable::FillAsHeaderBinary( ExcBoundsheetList& 
rBoundsheetList )
 rBoundsheetList.AppendRecord( xBoundsheet );
 }
 
+OUString aTmpString;
 for( SCTAB nAdd = 0; nC < static_cast(nCodenames) ; nC++, 
nAdd++ )
 {
 aTmpString = lcl_GetVbaTabName( nAdd );
@@ -362,24 +350,12 @@ void ExcTable::FillAsHeaderXml( ExcBoundsheetList& 
rBoundsheetList )
 ScDocument& rDoc = GetDoc();
 XclExpTabInfo& rTabInfo = GetTabInfo();
 
-SCTAB   nC;
-OUString aTmpString;
-SCTAB  nScTabCount = rTabInfo.GetScTabCount();
 sal_uInt16  nExcTabCount= rTabInfo.GetXclTabCount();
 sal_uInt16  nCodenames  = static_cast< sal_uInt16 >( 
GetExtDocOptions().GetCodeNameCount() );
 
 rR.pTabId = new XclExpChTrTabId( std::max( nExcTabCount, nCodenames ) );
 Add( rR.pTabId );
 
-// first setup table names and contents
-
-for( nC = 0 ; nC < nScTabCount ; nC++ )
-if( rTabInfo.IsExportTab( nC ) )
-{
-rDoc.GetName( nC, aTmpString );
-*pTabNames << aTmpString;
-}
-
 Add( new XclExpXmlStartSingleElementRecord( XML_workbookPr ) );
 Add( new XclExpBoolRecord(0x0040, false, XML_backupFile ) );// BACKUP
 Add( new XclExpBoolRecord(0x008D, false, XML_showObjects ) );   // HIDEOBJ
@@ -418,6 +394,8 @@ void ExcTable::FillAsHeaderXml( ExcBoundsheetList& 
rBoundsheetList )
 lcl_AddBookviews( aRecList, *this );
 
 // Bundlesheet
+SCTAB nC;
+SCTAB nScTabCount = rTabInfo.GetScTabCount();
 aRecList.AppendNewRecord( new XclExpXmlStartElementRecord( XML_sheets ) );
 for( nC = 0 ; nC < nScTabCount ; nC++ )
 if( rTabInfo.IsExportTab( nC ) )
@@

[Libreoffice-commits] core.git: 3 commits - include/editeng include/tools starmath/inc starmath/source sw/source

2017-01-25 Thread Noel Grandin

 include/editeng/flditem.hxx  |   54 +++
 include/editeng/measfld.hxx  |2 -
 include/tools/pstm.hxx   |2 -
 starmath/inc/view.hxx|6 ++--
 starmath/source/view.cxx |   18 +
 sw/source/uibase/inc/unoatxt.hxx |8 +++--
 sw/source/uibase/uno/unoatxt.cxx |   28 +---
 7 files changed, 57 insertions(+), 61 deletions(-)

New commits:
commit 0d172a803054801ff42296c65cfca844ad5e8f6b
Author: Noel Grandin 
Date:   Wed Jan 25 16:09:23 2017 +0200

use rtl::Reference in SmGraphicWindow

instead of storing both a raw pointer and an uno::Reference

Change-Id: Ib84809bee35c01fb590439174740d92bf4cd54bd

diff --git a/starmath/inc/view.hxx b/starmath/inc/view.hxx
index cec85a1..b41f5a7 100644
--- a/starmath/inc/view.hxx
+++ b/starmath/inc/view.hxx
@@ -23,6 +23,7 @@
 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -72,8 +73,7 @@ protected:
 bool IsInlineEditEnabled() const;
 
 private:
-css::uno::Reference xAccessible;
-SmGraphicAccessible* pAccessible;
+rtl::Reference mxAccessible;
 
 SmViewShell* pViewShell;
 sal_uInt16 nZoom;
@@ -131,7 +131,7 @@ public:
 using Window::GetAccessible;
 SmGraphicAccessible* GetAccessible_Impl()
 {
-return pAccessible;
+return mxAccessible.get();
 }
 };
 
diff --git a/starmath/source/view.cxx b/starmath/source/view.cxx
index dc099f9..0e93bdd 100644
--- a/starmath/source/view.cxx
+++ b/starmath/source/view.cxx
@@ -95,7 +95,6 @@ using namespace css::uno;
 
 SmGraphicWindow::SmGraphicWindow(SmViewShell* pShell)
 : ScrollableWindow(>GetViewFrame()->GetWindow())
-, pAccessible(nullptr)
 , pViewShell(pShell)
 , nZoom(100)
 {
@@ -122,10 +121,8 @@ SmGraphicWindow::~SmGraphicWindow()
 
 void SmGraphicWindow::dispose()
 {
-if (pAccessible)
-pAccessible->ClearWin();// make Accessible defunctional
-// Note: memory for pAccessible will be freed when the reference
-// xAccessible is released.
+if (mxAccessible.is())
+mxAccessible->ClearWin();// make Accessible defunctional
 CaretBlinkStop();
 ScrollableWindow::dispose();
 }
@@ -235,12 +232,12 @@ void SmGraphicWindow::GetFocus()
 void SmGraphicWindow::LoseFocus()
 {
 ScrollableWindow::LoseFocus();
-if (xAccessible.is())
+if (mxAccessible.is())
 {
 uno::Any aOldValue, aNewValue;
 aOldValue <<= AccessibleStateType::FOCUSED;
 // aNewValue remains empty
-pAccessible->LaunchEvent( AccessibleEventId::STATE_CHANGED,
+mxAccessible->LaunchEvent( AccessibleEventId::STATE_CHANGED,
 aOldValue, aNewValue );
 }
 if (!IsInlineEditEnabled())
@@ -614,12 +611,11 @@ void SmGraphicWindow::ZoomToFitInWindow()
 
 uno::Reference< XAccessible > SmGraphicWindow::CreateAccessible()
 {
-if (!pAccessible)
+if (!mxAccessible.is())
 {
-pAccessible = new SmGraphicAccessible( this );
-xAccessible = pAccessible;
+mxAccessible = new SmGraphicAccessible( this );
 }
-return xAccessible;
+return mxAccessible.get();
 }
 
 /**/
commit f025255bf66394ec168ae4cfc4d048c202800d16
Author: Noel Grandin 
Date:   Wed Jan 25 15:54:42 2017 +0200

use rtl::Reference in SwXAutoTextEntry

instead of storing both a raw pointer and an uno::Reference

Change-Id: I52c8827446d999d0a34b91ab17c056d4237d71a7

diff --git a/sw/source/uibase/inc/unoatxt.hxx b/sw/source/uibase/inc/unoatxt.hxx
index feaf0ce..00d6bb0 100644
--- a/sw/source/uibase/inc/unoatxt.hxx
+++ b/sw/source/uibase/inc/unoatxt.hxx
@@ -34,7 +34,9 @@
 #include 
 #include 
 #include 
+#include 
 #include 
+
 class SwTextBlocks;
 class SwGlossaries;
 class SwDoc;
@@ -172,12 +174,12 @@ class SwXAutoTextEntry
 OUStringsGroupName;
 OUStringsEntryName;
 SwDocShellRef   xDocSh;
-SwXBodyText*pBodyText;
-css::uno::Reference < css::lang::XServiceInfo> xBodyText;
+rtl::Reference
+mxBodyText;
 
 void EnsureBodyText ()
 {
-if ( !pBodyText )
+if ( !mxBodyText.is() )
 GetBodyText();
 }
 void GetBodyText ();
diff --git a/sw/source/uibase/uno/unoatxt.cxx b/sw/source/uibase/uno/unoatxt.cxx
index f50550a..3b19d0f 100644
--- a/sw/source/uibase/uno/unoatxt.cxx
+++ b/sw/source/uibase/uno/unoatxt.cxx
@@ -721,8 +721,7 @@ SwXAutoTextEntry::SwXAutoTextEntry(SwGlossaries* pGlss, 
const OUString& rGroupNa
 WeakComponentImplHelper(m_aMutex),
 pGlossaries(pGlss),
 sGroupName(rGroupName),
-sEntryName(rEntryName),
-pBodyText ( nullptr )
+sEntryName(rEntryName)
 {
 }
 
@@ -761,7 +760,7 @@ void SwXAutoTextEntry::Notify( SfxBroadcaster& _rBC, const 
SfxHint& _rHint )
 if (SfxEventHintId::PrepareCloseDoc ==

[Libreoffice-commits] core.git: include/com include/rtl include/tools

2017-01-25 Thread Noel Grandin

 include/com/sun/star/uno/Reference.h |9 +
 include/rtl/ref.hxx  |8 
 include/tools/ref.hxx|2 ++
 3 files changed, 19 insertions(+)

New commits:
commit 1480a2d05aff1eb6984882aacf39570b6b78a5d5
Author: Noel Grandin 
Date:   Wed Jan 25 10:42:28 2017 +0200

add 'explicit operator bool' to our reference classes

Change-Id: I91cfbe2646dcc55b98d2b809c49c9ea073f54f58
Reviewed-on: https://gerrit.libreoffice.org/33517
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/com/sun/star/uno/Reference.h 
b/include/com/sun/star/uno/Reference.h
index e657fd8..af2dc29 100644
--- a/include/com/sun/star/uno/Reference.h
+++ b/include/com/sun/star/uno/Reference.h
@@ -93,6 +93,15 @@ public:
 inline bool SAL_CALL is() const
 { return (NULL != _pInterface); }
 
+#if defined LIBO_INTERNAL_ONLY
+/** Checks if reference is null.
+
+@return true if reference acquires an interface, i.e. true if it is 
not null
+*/
+inline explicit operator bool() const
+{ return is(); }
+#endif
+
 /** Equality operator: compares two interfaces
 Checks if both references are null or refer to the same object.
 
diff --git a/include/rtl/ref.hxx b/include/rtl/ref.hxx
index b70088b..5eeb857 100644
--- a/include/rtl/ref.hxx
+++ b/include/rtl/ref.hxx
@@ -195,6 +195,14 @@ public:
 return (m_pBody != NULL);
 }
 
+#if defined LIBO_INTERNAL_ONLY
+/** Returns True if the handle does point to a valid body.
+ */
+inline explicit operator bool() const
+{
+return is();
+}
+#endif
 
 /** Returns True if this points to pBody.
  */
diff --git a/include/tools/ref.hxx b/include/tools/ref.hxx
index c251a78..97a5b36 100644
--- a/include/tools/ref.hxx
+++ b/include/tools/ref.hxx
@@ -90,6 +90,8 @@ public:
 
 bool Is() const { return pObj != nullptr; }
 
+explicit operator bool() const { return Is(); }
+
 T * get() const { return pObj; }
 
 T * operator ->() const { assert(pObj != nullptr); return pObj; }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105524] Reporting a particular crash never succeeds

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105524

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from Aron Budea  ---
The dump should be uploadable, though I didn't succeed myself (minidump_upload
hung on me):

 moggi: is there a way to submit the report manually in such case?
maybe having those details would be nice
<@moggi> fix the path in the dump.ini and run instdir/program/minidump_upload
instdir/crash/dump.ini

He also said it's very likely nothing can do about this bug. I'm fine with this
bug report being closed as WONTFIX eventually, since it's a very rare case, but
first I'd like to confirm that manual crash dump uploading works, so we can
advise bug reporters in a similar situation.

Setting to NEW for now myself, because reproduction will be difficult. If
anyone wants to attempt it, try hitting bug 105514 in VMWare Player with
Accelerate 3D graphics turned off.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104828] Several proportional characters shifted to the left within vertical text when they are upright

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104828

--- Comment #18 from Volga  ---
What happened if you intergrate HarfBuzz 1.3.4? This version has some improves
for vertical layout.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105539] New: [DE] LOCALHELP: XODER: "gerade Anzahl" instead of " ungerade Anzahl"

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105539

Bug ID: 105539
   Summary: [DE] LOCALHELP: XODER: "gerade Anzahl" instead of
"ungerade Anzahl"
   Product: LibreOffice
   Version: 5.2.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gilward.ku...@gmail.com

Description:
The description of the function XODER on the page "Kategorie Logisch" in the
German local help for Calc says "Ergibt WAHR, wenn eine gerade Anzahl von
Argumenten WAHR liefert."
Correct is "ungerade" instead of "gerade".

Actual Results:  


Expected Results:



Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:50.0) Gecko/20100101
Firefox/50.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

--- Comment #1 from Volga  ---
Created attachment 130688
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130688=edit
Screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] New: Download destination folder should be default to Download folder on Windows

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

Bug ID: 105538
   Summary: Download destination folder should be default to
Download folder on Windows
   Product: LibreOffice
   Version: 5.3.0.2 rc
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: shanshandehongx...@outlook.com

Description:
Currently the download destination is default to Desktop folder on Windows, but
this folder is intended to save quick launches used for Windows Desktop, no
intended to save downloaded files.

Steps to Reproduce:
1. Tools -> Options -> LibreOffice -> Online Update

Actual Results:  
The download destination is default to C:\Users\\Desktop, as the
attachment.

Expected Results:
Despite it can be replaced via Change button, download destination should
defaulting to C:\Users\\Download folder.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:51.0) Gecko/20100101
Firefox/51.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=93529

Aron Budea  changed:

   What|Removed |Added

 Depends on||104893


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104893
[Bug 104893] Assert from OpenGL code when activating chart object
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104893] Assert from OpenGL code when activating chart object

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104893

Aron Budea  changed:

   What|Removed |Added

 Blocks||93529


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=93529
[Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=93529
Bug 93529 depends on bug 100365, which changed state.

Bug 100365 Summary: LibreOffice close when try to create a chart
https://bugs.documentfoundation.org/show_bug.cgi?id=100365

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100365] LibreOffice close when try to create a chart

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100365

Aron Budea  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Blocks||93529
 Resolution|--- |INSUFFICIENTDATA

--- Comment #18 from Aron Budea  ---
No update, closing due to lack of information.
Let's hope an update fixed the crash.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=93529
[Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=93529

Aron Budea  changed:

   What|Removed |Added

 Depends on||100365


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100365
[Bug 100365] LibreOffice close when try to create a chart
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105537] [META] Assertion failed crashes

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105537

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Depends on||104920, 105103, 104893,
   ||99473
 Ever confirmed|0   |1
  Alias||Assert


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=99473
[Bug 99473] assertion "SolarMutex not locked"
https://bugs.documentfoundation.org/show_bug.cgi?id=104893
[Bug 104893] Assert from OpenGL code when activating chart object
https://bugs.documentfoundation.org/show_bug.cgi?id=104920
[Bug 104920] Clone Formatting in Writer Does Not Properly Copy Attributes
Sometimes
https://bugs.documentfoundation.org/show_bug.cgi?id=105103
[Bug 105103] typing after hitting 'Insert' key crashes LO with assertion failed
(dbg build)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99473] assertion "SolarMutex not locked"

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99473

Aron Budea  changed:

   What|Removed |Added

 Blocks||105537


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105537
[Bug 105537] [META] Assertion failed crashes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104920] Clone Formatting in Writer Does Not Properly Copy Attributes Sometimes

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104920

Aron Budea  changed:

   What|Removed |Added

 Blocks||105537


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105537
[Bug 105537] [META] Assertion failed crashes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105103] typing after hitting 'Insert' key crashes LO with assertion failed (dbg build)

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105103

Aron Budea  changed:

   What|Removed |Added

 Blocks||105537


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105537
[Bug 105537] [META] Assertion failed crashes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104893] Assert from OpenGL code when activating chart object

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104893

Aron Budea  changed:

   What|Removed |Added

 Blocks||105537


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105537
[Bug 105537] [META] Assertion failed crashes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105537] New: [META] Assertion failed crashes

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105537

Bug ID: 105537
   Summary: [META] Assertion failed crashes
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ba...@caesar.elte.hu

This is a quality-of-life bug report to make it easier to spot if a bug report
is about an assertion failed error (the alias will be shown in the Blocks
field).

Asserts are predicates that are expected to be true, but are only checked in
debug builds. While they are disregarded, and thus cause no crash in release
builds, they usually mean something went really wrong during execution, and
should be taken seriously.

Some information:
https://en.wikipedia.org/wiki/Assertion_(software_development)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105469] [META] Bugs hitting limit for GDI objects in Windows

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105469
Bug 105469 depends on bug 103927, which changed state.

Bug 103927 Summary: filter:xlsx LibreOffice crashes when importing XLSX file
https://bugs.documentfoundation.org/show_bug.cgi?id=103927

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101327] Impress crashes saving a pptx doc

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101327

--- Comment #23 from Kohei Yoshida  ---
I've tested this with a build that contains fix for Bug 103927, and I can't
reproduce the crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88070] FILESAVE: "The File could not be written" unable to save file with 3200+ comments

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=88070

--- Comment #14 from Kohei Yoshida  ---
I've tested it with a build that contains fix for Bug 103927, and I can't
reproduce this problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87204] FILESAVE: PowerPoint pps causes LO to crash or freeze...

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=87204

--- Comment #12 from Kohei Yoshida  ---
I've tested this with a build that contains fix for Bug 103927, and I can't
reproduce the crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104225] VIEWING: sluggishness while scrolling

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104225

--- Comment #2 from Aron Budea  ---
Telesto, could you link the original bug the attachment is from for reference?
Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105118] Impress table cells use way too many GDI objects

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105118

--- Comment #2 from Kohei Yoshida  ---
I can't reproduce this using the build that contains fix for Bug 103927.  The
fix for that bug most likely fixed this one too.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105521] Content gets pasted in two table cells when one cell is selected

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105521

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest, regression |
 CC||ba...@caesar.elte.hu
Version|4.2.0.4 release |Inherited From OOo

--- Comment #6 from Aron Budea  ---
Reproduced even with 3.3.0 / Ubuntu 16.04, using the 1st example file with the
steps shown in the screencast.
=> not a regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102688] Crash in: vcl::Window::dispose()

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102688

--- Comment #12 from Kohei Yoshida  ---
I've tested this with a build that contains the fix for Bug 103927, and didn't
get the crash.  I'm pretty sure this one is fixed by the same fix for the other
bug.  But someone else confirming would be great.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: wsd/ClientSession.cpp wsd/DocumentBroker.cpp

2017-01-25 Thread Ashod Nakashian

 wsd/ClientSession.cpp  |   10 --
 wsd/DocumentBroker.cpp |   10 --
 2 files changed, 12 insertions(+), 8 deletions(-)

New commits:
commit 6fe933b46678f3bf52a63f51890ac4c900989d3b
Author: Ashod Nakashian 
Date:   Wed Jan 25 20:55:39 2017 -0500

wsd: take lock to forward messages to clients

Change-Id: I15888e4a5c35511c21f1e2d2bdd25ecbb16e80b9
Reviewed-on: https://gerrit.libreoffice.org/33568
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index 742bb07..63db162 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -583,13 +583,10 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 }
 else if (tokens.size() == 2 && tokens[0] == "statechanged:")
 {
-if (docBroker)
+StringTokenizer stateTokens(tokens[1], "=", 
StringTokenizer::TOK_IGNORE_EMPTY | StringTokenizer::TOK_TRIM);
+if (stateTokens.count() == 2 && stateTokens[0] == 
".uno:ModifiedStatus")
 {
-StringTokenizer stateTokens(tokens[1], "=", 
StringTokenizer::TOK_IGNORE_EMPTY | StringTokenizer::TOK_TRIM);
-if (stateTokens.count() == 2 && stateTokens[0] == 
".uno:ModifiedStatus")
-{
-docBroker->setModified(stateTokens[1] == "true");
-}
+docBroker->setModified(stateTokens[1] == "true");
 }
 }
 
@@ -652,6 +649,7 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 stringToInteger(firstLineTokens[3], w);
 stringToInteger(firstLineTokens[4], h);
 }
+
 docBroker->invalidateCursor(x, y, w, h);
 }
 else
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 7b3ee4c..91f3ce4 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -759,8 +759,6 @@ bool DocumentBroker::handleInput(const std::vector& 
payload)
 
 void DocumentBroker::invalidateTiles(const std::string& tiles)
 {
-std::unique_lock lock(_mutex);
-
 // Remove from cache.
 _tileCache->invalidateTiles(tiles);
 }
@@ -904,6 +902,9 @@ void DocumentBroker::handleTileResponse(const 
std::vector& payload)
 const auto tile = TileDesc::parse(firstLine);
 const auto buffer = payload.data();
 const auto offset = firstLine.size() + 1;
+
+std::unique_lock lock(_mutex);
+
 tileCache().saveTileAndNotify(tile, buffer + offset, length - 
offset);
 }
 else
@@ -931,6 +932,9 @@ void DocumentBroker::handleTileCombinedResponse(const 
std::vector& payload
 const auto tileCombined = TileCombined::parse(firstLine);
 const auto buffer = payload.data();
 auto offset = firstLine.size() + 1;
+
+std::unique_lock lock(_mutex);
+
 for (const auto& tile : tileCombined.getTiles())
 {
 tileCache().saveTileAndNotify(tile, buffer + offset, 
tile.getImgSize());
@@ -1015,6 +1019,8 @@ bool DocumentBroker::forwardToClient(const 
std::shared_ptr& payload)
 std::string sid;
 if (LOOLProtocol::parseNameValuePair(payload->forwardToken(), name, sid, 
'-') && name == "client")
 {
+std::unique_lock lock(_mutex);
+
 const auto it = _sessions.find(sid);
 if (it != _sessions.end())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/ClientSession.cpp

2017-01-25 Thread Ashod Nakashian

 wsd/ClientSession.cpp |   22 ++
 1 file changed, 10 insertions(+), 12 deletions(-)

New commits:
commit b8edc135a7ce72631da8efefd78cd3cbc287c469
Author: Ashod Nakashian 
Date:   Sun Jan 22 23:19:04 2017 -0500

wsd: use Message object to handle responses back to clients

Change-Id: I5ddb32bbd7290c27308199f40f0ed286a869eafd
Reviewed-on: https://gerrit.libreoffice.org/33441
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index 6437d00..742bb07 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -477,9 +477,10 @@ void ClientSession::senderThread()
 
 bool ClientSession::handleKitToClientMessage(const char* buffer, const int 
length)
 {
-LOG_TRC(getName() + ": handling [" << getAbbreviatedMessage(buffer, 
length) << "].");
-const std::string firstLine = getFirstLine(buffer, length);
-StringTokenizer tokens(firstLine, " ", StringTokenizer::TOK_IGNORE_EMPTY | 
StringTokenizer::TOK_TRIM);
+const auto payload = std::make_shared(buffer, length, 
Message::Dir::Out);
+
+LOG_TRC(getName() + ": handling [" << payload->abbr() << "].");
+const std::string& firstLine = payload->firstLine();
 
 const auto docBroker = _docBroker.lock();
 if (!docBroker)
@@ -490,6 +491,7 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 
 LOOLWSD::dumpOutgoingTrace(docBroker->getJailId(), getId(), firstLine);
 
+const auto& tokens = payload->tokens();
 if (tokens[0] == "unocommandresult:")
 {
 const std::string stringMsg(buffer, length);
@@ -536,7 +538,6 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 errorKind == "passwordrequired:to-modify" ||
 errorKind == "wrongpassword")
 {
-const auto payload = std::make_shared(buffer, 
length, Message::Dir::Out);
 forwardToClient(payload);
 LOG_WRN("Document load failed: " << errorKind);
 return false;
@@ -544,13 +545,13 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 }
 }
 }
-else if (tokens[0] == "curpart:" && tokens.count() == 2)
+else if (tokens[0] == "curpart:" && tokens.size() == 2)
 {
 //TODO: Should forward to client?
 int curPart;
 return getTokenInteger(tokens[1], "part", curPart);
 }
-else if (tokens.count() == 2 && tokens[0] == "saveas:")
+else if (tokens.size() == 2 && tokens[0] == "saveas:")
 {
 std::string url;
 if (!getTokenString(tokens[1], "url", url))
@@ -580,7 +581,7 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 setSaveAsUrl(url);
 return true;
 }
-else if (tokens.count() == 2 && tokens[0] == "statechanged:")
+else if (tokens.size() == 2 && tokens[0] == "statechanged:")
 {
 if (docBroker)
 {
@@ -604,7 +605,6 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 docBroker->setLoaded();
 
 // Forward the status response to the client.
-const auto payload = std::make_shared(buffer, length, 
Message::Dir::Out);
 return forwardToClient(payload);
 }
 else if (tokens[0] == "commandvalues:")
@@ -628,7 +628,7 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 }
 else if (tokens[0] == "partpagerectangles:")
 {
-if (tokens.count() > 1 && !tokens[1].empty())
+if (tokens.size() > 1 && !tokens[1].empty())
 {
 docBroker->tileCache().saveTextFile(std::string(buffer, 
length), "partpagerectangles.txt");
 }
@@ -662,7 +662,7 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 else if (tokens[0] == "renderfont:")
 {
 std::string font, text;
-if (tokens.count() < 3 ||
+if (tokens.size() < 3 ||
 !getTokenString(tokens[1], "font", font))
 {
 LOG_ERR("Bad syntax for: " << firstLine);
@@ -672,7 +672,6 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 getTokenString(tokens[2], "char", text);
 assert(firstLine.size() < 
static_cast(length));
 docBroker->tileCache().saveRendering(font+text, "font", buffer + 
firstLine.size() + 1, length - firstLine.size() - 1);
-const auto payload = std::make_shared(buffer, length, 
Message::Dir::Out);
 return forwardToClient(payload);
 }
 }
@@ -682,7 +681,6 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 }

[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp wsd/DocumentBroker.hpp

2017-01-25 Thread Ashod Nakashian

 wsd/DocumentBroker.cpp |   80 +
 wsd/DocumentBroker.hpp |3 +
 2 files changed, 37 insertions(+), 46 deletions(-)

New commits:
commit f73a17c759f1628db26ec3e8606b5ab799b1acf3
Author: Ashod Nakashian 
Date:   Sun Jan 22 23:18:37 2017 -0500

wsd: use Message objects to handle kit responses

Change-Id: Ifc9c53ead8d87e9aebfd8c60442a726de5270cc5
Reviewed-on: https://gerrit.libreoffice.org/33440
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index fb19ca4..7b3ee4c 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -716,39 +716,42 @@ void DocumentBroker::alertAllUsers(const std::string& msg)
 
 bool DocumentBroker::handleInput(const std::vector& payload)
 {
-const auto msg = LOOLProtocol::getAbbreviatedMessage(payload);
+auto message = std::make_shared(payload.data(), payload.size(), 
Message::Dir::Out);
+const auto& msg = message->abbr();
 LOG_TRC("DocumentBroker handling child message: [" << msg << "].");
 
 LOOLWSD::dumpOutgoingTrace(getJailId(), "0", msg);
 
-const auto command = LOOLProtocol::getFirstToken(msg);
-if (command == "tile:")
+if (LOOLProtocol::getFirstToken(message->forwardToken(), '-') == "client")
 {
-handleTileResponse(payload);
-}
-else if (command == "tilecombine:")
-{
-handleTileCombinedResponse(payload);
-}
-else if (LOOLProtocol::getFirstToken(command, '-') == "client")
-{
-forwardToClient(command, payload);
-}
-else if (command == "errortoall:")
-{
-StringTokenizer tokens(msg, " ", StringTokenizer::TOK_IGNORE_EMPTY | 
StringTokenizer::TOK_TRIM);
-assert(tokens.count() == 3);
-std::string cmd, kind;
-LOOLProtocol::getTokenString(tokens, "cmd", cmd);
-assert(cmd != "");
-LOOLProtocol::getTokenString(tokens, "kind", kind);
-assert(kind != "");
-Util::alertAllUsers(cmd, kind);
+forwardToClient(message);
 }
 else
 {
-LOG_ERR("Unexpected message: [" << msg << "].");
-return false;
+const auto& command = message->firstToken();
+if (command == "tile:")
+{
+handleTileResponse(payload);
+}
+else if (command == "tilecombine:")
+{
+handleTileCombinedResponse(payload);
+}
+else if (command == "errortoall:")
+{
+LOG_CHECK_RET(message->tokens().size() == 3, false);
+std::string cmd, kind;
+LOOLProtocol::getTokenString((*message)[1], "cmd", cmd);
+LOG_CHECK_RET(cmd != "", false);
+LOOLProtocol::getTokenString((*message)[2], "kind", kind);
+LOG_CHECK_RET(kind != "", false);
+Util::alertAllUsers(cmd, kind);
+}
+else
+{
+LOG_ERR("Unexpected message: [" << msg << "].");
+return false;
+}
 }
 
 return true;
@@ -1002,37 +1005,24 @@ bool DocumentBroker::forwardToChild(const std::string& 
viewId, const std::string
 return false;
 }
 
-bool DocumentBroker::forwardToClient(const std::string& prefix, const 
std::vector& payload)
+bool DocumentBroker::forwardToClient(const std::shared_ptr& payload)
 {
-assert(payload.size() > prefix.size());
-
-// Remove the prefix and trim.
-size_t index = prefix.size();
-for ( ; index < payload.size(); ++index)
-{
-if (payload[index] != ' ')
-{
-break;
-}
-}
-
-auto data = payload.data() + index;
-auto size = payload.size() - index;
-const auto message = getAbbreviatedMessage(data, size);
-LOG_TRC("Forwarding payload to " << prefix << ' ' << message);
+const std::string& msg = payload->abbr();
+const std::string& prefix = payload->forwardToken();
+LOG_TRC("Forwarding payload to [" << prefix << "]: " << msg);
 
 std::string name;
 std::string sid;
-if (LOOLProtocol::parseNameValuePair(prefix, name, sid, '-') && name == 
"client")
+if (LOOLProtocol::parseNameValuePair(payload->forwardToken(), name, sid, 
'-') && name == "client")
 {
 const auto it = _sessions.find(sid);
 if (it != _sessions.end())
 {
-return it->second->handleKitToClientMessage(data, size);
+return 
it->second->handleKitToClientMessage(payload->data().data(), payload->size());
 }
 else
 {
-LOG_WRN("Client session [" << sid << "] not found to forward 
message: " << message);
+LOG_WRN("Client session [" << sid << "] not found to forward 
message: " << msg);
 }
 }
 else
diff --git a/wsd/DocumentBroker.hpp b/wsd/DocumentBroker.hpp
index 27c4916..8c416ba 100644
--- a/wsd/DocumentBroker.hpp
+++ b/wsd/DocumentBroker.hpp
@@ -35,6

[Libreoffice-commits] online.git: common/Message.hpp

2017-01-25 Thread Ashod Nakashian

 common/Message.hpp |   31 +++
 1 file changed, 27 insertions(+), 4 deletions(-)

New commits:
commit 9fe2d9322837806417af2b0ee0399f1d5f512c14
Author: Ashod Nakashian 
Date:   Sun Jan 22 16:09:08 2017 -0500

wsd: Message now supports parsing forwarding prefix

Change-Id: I2826a2df5136628b86421afb93e3b95fbc3ba45a
Reviewed-on: https://gerrit.libreoffice.org/33438
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/Message.hpp b/common/Message.hpp
index 5be6186..a71cf56 100644
--- a/common/Message.hpp
+++ b/common/Message.hpp
@@ -28,7 +28,8 @@ public:
 /// message must include the full first-line.
 Message(const std::string& message,
 const enum Dir dir) :
-_data(message.data(), message.data() + message.size()),
+_forwardToken(getForwardToken(message.data(), message.size())),
+_data(skipWhitespace(message.data() + _forwardToken.size()), 
message.data() + message.size()),
 _tokens(LOOLProtocol::tokenize(_data.data(), _data.size())),
 _id(makeId(dir)),
 _firstLine(LOOLProtocol::getFirstLine(_data.data(), _data.size())),
@@ -43,15 +44,17 @@ public:
 Message(const std::string& message,
 const enum Dir dir,
 const size_t reserve) :
+_forwardToken(getForwardToken(message.data(), message.size())),
 _data(std::max(reserve, message.size())),
-_tokens(LOOLProtocol::tokenize(message)),
+_tokens(LOOLProtocol::tokenize(message.data() + _forwardToken.size(), 
message.size() - _forwardToken.size())),
 _id(makeId(dir)),
 _firstLine(LOOLProtocol::getFirstLine(message)),
 _abbr(_id + ' ' + LOOLProtocol::getAbbreviatedMessage(message)),
 _type(detectType())
 {
 _data.resize(message.size());
-std::memcpy(_data.data(), message.data(), message.size());
+const auto offset = skipWhitespace(message.data() + 
_forwardToken.size());
+std::memcpy(_data.data(), offset, message.size() - (offset - 
message.data()));
 }
 
 /// Construct a message from a character array with type.
@@ -59,7 +62,8 @@ public:
 Message(const char* p,
 const size_t len,
 const enum Dir dir) :
-_data(p, p + len),
+_forwardToken(getForwardToken(p, len)),
+_data(skipWhitespace(p + _forwardToken.size()), p + len),
 _tokens(LOOLProtocol::tokenize(_data.data(), _data.size())),
 _id(makeId(dir)),
 _firstLine(LOOLProtocol::getFirstLine(_data.data(), _data.size())),
@@ -72,8 +76,10 @@ public:
 const std::vector& data() const { return _data; }
 
 const std::vector& tokens() const { return _tokens; }
+const std::string& forwardToken() const { return _forwardToken; }
 const std::string& firstToken() const { return _tokens[0]; }
 const std::string& firstLine() const { return _firstLine; }
+const std::string& operator[](size_t index) const { return _tokens[index]; 
}
 
 /// Return the abbreviated message for logging purposes.
 const std::string& abbr() const { return _abbr; }
@@ -129,7 +135,24 @@ private:
 return Type::Text;
 }
 
+std::string getForwardToken(const char* buffer, int length)
+{
+auto forward = LOOLProtocol::getFirstToken(buffer, length);
+return (forward.find('-') != std::string::npos ? forward : 
std::string());
+}
+
+const char* skipWhitespace(const char* p)
+{
+while (p && *p == ' ')
+{
+++p;
+}
+
+return p;
+}
+
 private:
+const std::string _forwardToken;
 std::vector _data;
 const std::vector _tokens;
 const std::string _id;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/Message.hpp wsd/ClientSession.cpp wsd/ClientSession.hpp wsd/TileCache.cpp

2017-01-25 Thread Ashod Nakashian

 common/Message.hpp|   31 +++
 wsd/ClientSession.cpp |   22 --
 wsd/ClientSession.hpp |8 ++--
 wsd/TileCache.cpp |   10 --
 4 files changed, 33 insertions(+), 38 deletions(-)

New commits:
commit acc029a4113349ccc88bf77accd264f4584574e0
Author: Ashod Nakashian 
Date:   Sat Jan 21 23:50:08 2017 -0500

wsd: autodetect message type

Change-Id: I0f3ab61867ea067f24050acb15660fa93fc7bbb5
Reviewed-on: https://gerrit.libreoffice.org/33437
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/Message.hpp b/common/Message.hpp
index cc7063e..5be6186 100644
--- a/common/Message.hpp
+++ b/common/Message.hpp
@@ -27,14 +27,13 @@ public:
 /// Construct a text message.
 /// message must include the full first-line.
 Message(const std::string& message,
-const enum Dir dir,
-const enum Type type = Type::Text) :
+const enum Dir dir) :
 _data(message.data(), message.data() + message.size()),
 _tokens(LOOLProtocol::tokenize(_data.data(), _data.size())),
 _id(makeId(dir)),
 _firstLine(LOOLProtocol::getFirstLine(_data.data(), _data.size())),
 _abbr(_id + ' ' + LOOLProtocol::getAbbreviatedMessage(_data.data(), 
_data.size())),
-_type(type)
+_type(detectType())
 {
 }
 
@@ -43,14 +42,13 @@ public:
 /// message must include the full first-line.
 Message(const std::string& message,
 const enum Dir dir,
-const enum Type type,
 const size_t reserve) :
 _data(std::max(reserve, message.size())),
 _tokens(LOOLProtocol::tokenize(message)),
 _id(makeId(dir)),
 _firstLine(LOOLProtocol::getFirstLine(message)),
 _abbr(_id + ' ' + LOOLProtocol::getAbbreviatedMessage(message)),
-_type(type)
+_type(detectType())
 {
 _data.resize(message.size());
 std::memcpy(_data.data(), message.data(), message.size());
@@ -60,14 +58,13 @@ public:
 /// Note: p must include the full first-line.
 Message(const char* p,
 const size_t len,
-const enum Dir dir,
-const enum Type type) :
+const enum Dir dir) :
 _data(p, p + len),
 _tokens(LOOLProtocol::tokenize(_data.data(), _data.size())),
 _id(makeId(dir)),
 _firstLine(LOOLProtocol::getFirstLine(_data.data(), _data.size())),
 _abbr(_id + ' ' + LOOLProtocol::getAbbreviatedMessage(_data.data(), 
_data.size())),
-_type(type)
+_type(detectType())
 {
 }
 
@@ -114,6 +111,24 @@ private:
 return (dir == Dir::In ? 'i' : 'o') + std::to_string(++Counter);
 }
 
+Type detectType() const
+{
+if (_tokens[0] == "tile:" ||
+_tokens[0] == "tilecombine:" ||
+_tokens[0] == "renderfont:")
+{
+return Type::Binary;
+}
+
+if (_data[_data.size() - 1] == '}')
+{
+return Type::JSON;
+}
+
+// All others are plain text.
+return Type::Text;
+}
+
 private:
 std::vector _data;
 const std::vector _tokens;
diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index 12b8fb8..6437d00 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -536,9 +536,7 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 errorKind == "passwordrequired:to-modify" ||
 errorKind == "wrongpassword")
 {
-const auto payload = std::make_shared(buffer, 
length,
-   
Message::Dir::Out,
-   
Message::Type::Text);
+const auto payload = std::make_shared(buffer, 
length, Message::Dir::Out);
 forwardToClient(payload);
 LOG_WRN("Document load failed: " << errorKind);
 return false;
@@ -606,9 +604,7 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 docBroker->setLoaded();
 
 // Forward the status response to the client.
-const auto payload = std::make_shared(buffer, length,
-   Message::Dir::Out,
-   
Message::Type::Text);
+const auto payload = std::make_shared(buffer, length, 
Message::Dir::Out);
 return forwardToClient(payload);
 }
 else if (tokens[0] == "commandvalues:")
@@ -676,9 +672,7 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 getTokenString(tokens[2], "char", text);

[Libreoffice-bugs] [Bug 105382] File name is percent-encoded when minimize presentation on Impress

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105382

--- Comment #6 from Shinji Enoki  ---
I tried it in the following environment. I think this bug has been fixed.


OS: Debian jessie
Version: 5.4.0.0.alpha0+
Build ID: 1337932c038d0a0f689e59de7c8ffd272dbdafa4
CPU Threads: 4; OS Version: Linux 3.16; UI Render: default; VCL: gtk3; 
Locale: ja-JP (ja_JP.utf8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: editeng/source

2017-01-25 Thread Kohei Yoshida

 editeng/source/editeng/eerdll.cxx   |   12 ++--
 editeng/source/editeng/eerdll2.hxx  |4 
 editeng/source/editeng/impedit.hxx  |1 -
 editeng/source/editeng/impedit2.cxx |   29 +++--
 4 files changed, 21 insertions(+), 25 deletions(-)

New commits:
commit b41186a2fc49e440890b8c86e5367352ffaf9cd6
Author: Kohei Yoshida 
Date:   Mon Jan 23 22:01:37 2017 -0500

tdf#103927: Share single standard VirtualDevice instance.

To avoid creating excessive amounts of VirtualDevice instances. Also,
since we now have VclPtr, we shouldn't need this bOwnerOfRefDev flag.

Change-Id: I97a6f553a178b32bc173b83a6716185d126f97e1
Reviewed-on: https://gerrit.libreoffice.org/33508
Tested-by: Jenkins 
Reviewed-by: Kohei Yoshida 

diff --git a/editeng/source/editeng/eerdll.cxx 
b/editeng/source/editeng/eerdll.cxx
index 558c475..94f9760 100644
--- a/editeng/source/editeng/eerdll.cxx
+++ b/editeng/source/editeng/eerdll.cxx
@@ -70,6 +70,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace ::com::sun::star;
 
@@ -83,9 +84,11 @@ EditDLL& EditDLL::Get()
 return theEditDLL::get();
 }
 
-GlobalEditData::GlobalEditData()
+GlobalEditData::GlobalEditData() :
+ppDefItems(nullptr),
+mpVirDev(VclPtr::Create())
 {
-ppDefItems = nullptr;
+mpVirDev->SetMapMode(MapUnit::MapTwip);
 }
 
 GlobalEditData::~GlobalEditData()
@@ -194,6 +197,11 @@ uno::Reference< linguistic2::XLanguageGuessing > const & 
GlobalEditData::GetLang
 return xLanguageGuesser;
 }
 
+VclPtr GlobalEditData::GetStdVirtualDevice()
+{
+return mpVirDev;
+}
+
 EditResId::EditResId(sal_uInt16 nId)
 : ResId(nId, *EditDLL::GetResMgr())
 {
diff --git a/editeng/source/editeng/eerdll2.hxx 
b/editeng/source/editeng/eerdll2.hxx
index 136b9cd..32c7c40 100644
--- a/editeng/source/editeng/eerdll2.hxx
+++ b/editeng/source/editeng/eerdll2.hxx
@@ -25,6 +25,7 @@
 #include 
 
 class SfxPoolItem;
+class VirtualDevice;
 
 class GlobalEditData
 {
@@ -33,6 +34,7 @@ private:
 std::vector*   ppDefItems;
 
 rtl::Reference xForbiddenCharsTable;
+VclPtr mpVirDev;
 
 public:
 GlobalEditData();
@@ -43,6 +45,8 @@ public:
 rtl::Reference const & 
GetForbiddenCharsTable();
 voidSetForbiddenCharsTable( 
rtl::Reference const & xForbiddenChars ) { 
xForbiddenCharsTable = xForbiddenChars; }
 css::uno::Reference< css::linguistic2::XLanguageGuessing > const & 
GetLanguageGuesser();
+
+VclPtr GetStdVirtualDevice();
 };
 
 #endif // INCLUDED_EDITENG_SOURCE_EDITENG_EERDLL2_HXX
diff --git a/editeng/source/editeng/impedit.hxx 
b/editeng/source/editeng/impedit.hxx
index 1b585f7..74a55ce 100644
--- a/editeng/source/editeng/impedit.hxx
+++ b/editeng/source/editeng/impedit.hxx
@@ -513,7 +513,6 @@ private:
 boolbIsInUndo:1;
 boolbUpdate:1;
 boolbUndoEnabled:1;
-boolbOwnerOfRefDev:1;
 boolbDowning:1;
 boolbUseAutoColor:1;
 boolbForceAutoColor:1;
diff --git a/editeng/source/editeng/impedit2.cxx 
b/editeng/source/editeng/impedit2.cxx
index 0d89b43..1c56dfb 100644
--- a/editeng/source/editeng/impedit2.cxx
+++ b/editeng/source/editeng/impedit2.cxx
@@ -95,7 +95,6 @@ ImpEditEngine::ImpEditEngine( EditEngine* pEE, SfxItemPool* 
pItemPool ) :
 bIsInUndo(false),
 bUpdate(true),
 bUndoEnabled(true),
-bOwnerOfRefDev(false),
 bDowning(false),
 bUseAutoColor(true),
 bForceAutoColor(false),
@@ -184,26 +183,15 @@ ImpEditEngine::~ImpEditEngine()
 delete mpIMEInfos;
 delete pColorConfig;
 delete pCTLOptions;
-if ( bOwnerOfRefDev )
-pRefDev.disposeAndClear();
 delete pSpellInfo;
 }
 
 void ImpEditEngine::SetRefDevice( OutputDevice* pRef )
 {
-if ( bOwnerOfRefDev )
-pRefDev.disposeAndClear();
-
-if ( !pRef )
-{
-pRefDev = VclPtr::Create();
-pRefDev->SetMapMode( MapUnit::MapTwip );
-bOwnerOfRefDev = true;
-} else
-{
+if (pRef)
 pRefDev = pRef;
-bOwnerOfRefDev = false;
-}
+else
+pRefDev = EditDLL::Get().GetGlobalData()->GetStdVirtualDevice();
 
 nOnePixelInRef = (sal_uInt16)pRefDev->PixelToLogic( Size( 1, 0 ) ).Width();
 
@@ -219,13 +207,10 @@ void ImpEditEngine::SetRefMapMode( const MapMode& 
rMapMode )
 if ( GetRefDevice()->GetMapMode() == rMapMode )
 return;
 
-if ( !bOwnerOfRefDev )
-{
-pRefDev = VclPtr::Create();
-pRefDev->SetMapMode( MapUnit::MapTwip );
-SetRefDevice( pRefDev );
-bOwnerOfRefDev = true;
-}
+pRefDev = VclPtr::Create();
+pRefDev->SetMapMode( MapUnit::MapTwip );
+SetRefDevice( pRefDev );
+
 pRefDev->SetMapMode( rMapMode );
 nOnePixelInRef = (sal_uInt16)pRefDev->PixelToLogic( Size( 1, 0 ) ).Width();
 if ( IsFormatted() )

[Libreoffice-bugs] [Bug 105530] Editing conditional formatting 2nd time

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105530

--- Comment #4 from Karl  ---
Windows build for 5.3.0.2 also seems to have this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105536] LibreOffice Fileopen PDF formatting: PDF is flipped ( upsidedown/backwards)

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105536

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||mikekagan...@hotmail.com,
   ||vmik...@collabora.co.uk,
   ||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #4 from V Stuart Foote  ---
Confirmed on windows 8.1 Ent 64-bit en-US with
Version: 5.3.0.2 (x64)
Build ID: 5ad7b2889021c491af62f7930a4b1cb631392f16
CPU Threads: 8; OS Version: Windows 6.29; UI Render: GL; Layout Engine: new; 
Locale: en-US (en_US); Calc: group

The grayscale bitmap image is upsidedown and flipped.

@Miklos, Mike this is a weird one.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105535] function keys not working and distorted text

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105535

--- Comment #2 from V Stuart Foote  ---
(In reply to V Stuart Foote from comment #1)
> The Back and Forward buttons on the Navigator toolbar are not page
> navigation.

s/Navigator toolbar/Navigation toolbar

As to text distorting on scroll, that is often a GPU/driver issue. Insufficient
detail in the OP to comment, but likely duplicate of bug 58358

=-ref-=
http://opengrok.libreoffice.org/xref/core/sw/source/uibase/wrtsh/navmgr.cxx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105535] function keys not working and distorted text

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105535

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |INVALID

--- Comment #1 from V Stuart Foote  ---
The Back and Forward buttons on the Navigator toolbar are not page navigation.

Rather they are controls for the navigation shell and will move forward and
backward between the objects tracked in the navigation history. Manipulate
using Navigator dialog F5 or the Navigator Sidebar deck.

If it is important to you, Page navigation can be added to the Navigator
toolbar with a customization. The Next Page, Previous Page, To Document End, To
Document Begin actions can each be added from the Navigate category.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105536] LibreOffice Fileopen PDF formatting: PDF is flipped ( upsidedown/backwards)

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105536

--- Comment #3 from Nick Humrich  ---
Created attachment 130687
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130687=edit
firefox screenshot

This is what it looks like in firefox (correct)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105536] LibreOffice Fileopen PDF formatting: PDF is flipped ( upsidedown/backwards)

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105536

--- Comment #2 from Nick Humrich  ---
Created attachment 130686
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130686=edit
libreoffice screenshot

This is what it looks like in libreoffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105536] LibreOffice Fileopen PDF formatting: PDF is flipped ( upsidedown/backwards)

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105536

--- Comment #1 from Nick Humrich  ---
Created attachment 130685
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130685=edit
original file

This is the pdf that wont open correctly

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105530] Editing conditional formatting 2nd time

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105530

--- Comment #3 from Karl  ---
I suspect that there is something un-initialized.


Do the following:
0. Go to a colored field, e.g. C6 if you are not already there.

1.  Format->Conditional Formatting->Condition
  ( Notice the current condition is not filled out )

2. Now, go to
 Conditional Formatting->Manage 
   find the cell. 
   Select "Edit"
 The previous condition will pop up.
Select "Cancel"

3. Then repeat the first step:
   Format->Conditional Formatting->Condition
  ( Notice the current condition is filled in the form )

I have also tested this on Libreoffice 5.0.3.2 on Linux. The bug is NOT present
there.

 - Karl

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105536] New: LibreOffice Fileopen PDF formatting: PDF is flipped ( upsidedown/backwards)

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105536

Bug ID: 105536
   Summary: LibreOffice Fileopen PDF formatting: PDF is flipped
(upsidedown/backwards)
   Product: LibreOffice
   Version: 5.2.3.3 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: nick.humr...@gmail.com

Description:
Opening this pdf file in libreoffice makes it appear like the file is
upsidedown and backwards. Basically it is orientational-wise inverted. If I
open it in firefox/adobe/inkscape it looks correct and right-side up.

Steps to Reproduce:
1. Open file in libre office using command line `libreoffice myfile.pdf` or my
opening draw, then going through the open dialog.
2. Feast your eyes upon the incorrectness!

Actual Results:  
The file was upsidedown and backwards

Expected Results:
The file should be readable and right-side up


Reproducible: Always

User Profile Reset: yes

Additional Info:
I tried on a different computer, and even in a docker container. This is on
libreoffice 5.2. I tried on 5.1 and got a blank pdf instead of an upside down
one. I dont know of a workaround because I am programatically converting pdf's
and its impossible to know which ones are (incorrectly) upside down, and which
ones are not.


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101
Firefox/50.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105531] Color scale conditional formatting doesn' t copy as expected

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105531

Karl  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105531] Color scale conditional formatting doesn' t copy as expected

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105531

--- Comment #2 from Karl  ---
Created attachment 130684
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130684=edit
Simple spreadsheet with conditional formatting

Method for obtaining this:
conditional-formatted cell C4 based on $B4.

Copy, Paste special ( only format ) to range C4 - D7 .
Expect D7 formatting to refer to $B7, not $B$4 .

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105530] Editing conditional formatting 2nd time

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105530

Karl  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105530] Editing conditional formatting 2nd time

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105530

--- Comment #2 from Karl  ---
Created attachment 130683
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130683=edit
Simple spreadsheet with conditional color-scale

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'libreoffice-5-3' - loleaflet/dist

2017-01-25 Thread Thorsten Behrens

 loleaflet/dist/toolbar/toolbar.js |9 -
 1 file changed, 9 deletions(-)

New commits:
commit 44b495aa89a852f679faff85f0ffebd018cf1f11
Author: Thorsten Behrens 
Date:   Wed Jan 25 23:28:47 2017 +0100

Remove Textwrap dropdown from toolbar for the while

Let's leave that out for 5.3 - removes parts of
5902700922d110aee29d67be6224094bb521132d

diff --git a/loleaflet/dist/toolbar/toolbar.js 
b/loleaflet/dist/toolbar/toolbar.js
index 80cdd08..cb95fcf 100644
--- a/loleaflet/dist/toolbar/toolbar.js
+++ b/loleaflet/dist/toolbar/toolbar.js
@@ -332,15 +332,6 @@ $(function () {
name: 'toolbar-up',
items: [
{type: 'html', id: 'left'},
-   {type: 'menu', id: 'writer:menu:wrap', caption: 
_('Textwrap'), items: [
-   { text: _('No wrap'), id: 'wrap-WrapOff' },
-   { text: _('Page wrap'), id: 'wrap-WrapOn' },
-   { text: _('Wrap anchor only'), id: 
'wrap-WrapAnchorOnly' },
-   { text: _('Ideal wrap'), id: 'wrap-WrapIdeal' },
-   { text: _('Left wrap'), id: 'wrap-WrapLeft' },
-   { text: _('Right wrap'), id: 'wrap-WrapRight' },
-   { text: _('Wrap through'), id: 
'wrap-WrapThrough' }
-   ]},
{type: 'button',  id: 'save', img: 'save', hint: 
_('Save'), uno: 'Save'},
{type: 'break'},
{type: 'button',  id: 'undo',  img: 'undo', hint: 
_('Undo'), uno: 'Undo'},
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.1' - canvas/source

2017-01-25 Thread Aron Budea

 canvas/source/directx/dx_9rm.cxx |   19 +++
 1 file changed, 11 insertions(+), 8 deletions(-)

New commits:
commit 6c6881f9c1011366c58176646f1770f6ecf7f4cf
Author: Aron Budea 
Date:   Mon Jan 23 03:47:19 2017 +0100

tdf#100151: Dispose of window if DX device creation failed

Before, if the device lacked Direct3D capabilities, VclPtr
handling became compromised, and caused a crash. This was
particularly a problem in virtualized/remote desktop
connections in Windows.

Now mpWindow instance is disposed of right away if DX
device creation fails.

Change-Id: I639340380affdb31a93ce6dccd8df33a0a466df6
Reviewed-on: https://gerrit.libreoffice.org/33413
Reviewed-by: Michael Meeks 
Tested-by: Jenkins 
(cherry picked from commit bb50474225f80b8aeea49f14ad66173462026a41)
Reviewed-on: https://gerrit.libreoffice.org/33544
Reviewed-by: Aron Budea 
Tested-by: Aron Budea 

diff --git a/canvas/source/directx/dx_9rm.cxx b/canvas/source/directx/dx_9rm.cxx
index 0d6833d..4c19a68 100644
--- a/canvas/source/directx/dx_9rm.cxx
+++ b/canvas/source/directx/dx_9rm.cxx
@@ -651,6 +651,14 @@ namespace dxcanvas
 // TODO(P2): get rid of those fine-grained locking
 ::osl::MutexGuard aGuard( maMutex );
 
+// TODO(F2): since we would like to share precious hardware
+// resources, the direct3d9 object should be global. each new
+// request for a canvas should only create a new swapchain.
+mpDirect3D9 = COMReference(
+Direct3DCreate9(D3D_SDK_VERSION));
+if(!mpDirect3D9.is())
+return false;
+
 maVertexCache.reserve( 1024 );
 
 mpWindow.disposeAndClear();
@@ -687,17 +695,12 @@ namespace dxcanvas
 // let the child window cover the same size as the parent window.
 mpWindow->setPosSizePixel(0,0,maSize.getX(),maSize.getY());
 
-// TODO(F2): since we would like to share precious hardware
-// resources, the direct3d9 object should be global. each new
-// request for a canvas should only create a new swapchain.
-mpDirect3D9 = COMReference(
-Direct3DCreate9(D3D_SDK_VERSION));
-if(!mpDirect3D9.is())
-return false;
-
 // create a device from the direct3d9 object.
 if(!(createDevice()))
+{
+mpWindow.disposeAndClear();
 return false;
+}
 
 mpWindow->Show();
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105491] Copying many cells in big spreadsheet makes LibreOffice crash

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105491

MM  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #7 from MM  ---
Unconfirmed with v5.2.5.1 under ubuntu 16.04 x64.
Confirmed with v5.2.5.1 under windows 7 x64.

Hangs for some time with ubuntu, but no crash. Seems windows only ?!
All cells without the IF's don't hang, copied fast.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svx/source

2017-01-25 Thread Tamás Zolnai

 svx/source/stbctrls/stbctrls.h |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 326729ce54de5296cb2a673ae88d2befa3e245ef
Author: TamÃ¡s Zolnai 
Date:   Wed Jan 25 23:03:34 2017 +0100

tdf#105520: "Selection Count" does not appear on Status bar when selected

Change-Id: I6ade03b39aeafffa08cfbfcca4739cfe5a73d4ac
Reviewed-on: https://gerrit.libreoffice.org/33561
Reviewed-by: TamÃ¡s Zolnai 
Tested-by: TamÃ¡s Zolnai 

diff --git a/svx/source/stbctrls/stbctrls.h b/svx/source/stbctrls/stbctrls.h
index 532bbe1..91d4fa9 100644
--- a/svx/source/stbctrls/stbctrls.h
+++ b/svx/source/stbctrls/stbctrls.h
@@ -37,7 +37,7 @@
 #define PSZ_FUNC_MAX4
 #define PSZ_FUNC_MIN5
 #define PSZ_FUNC_SUM9
-#define PSZ_FUNC_SELECTION_COUNT12
+#define PSZ_FUNC_SELECTION_COUNT13
 #define PSZ_FUNC_NONE   16
 
 #define XMLSEC_CALL 1
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105520] "Selection Count" does not appear on Status bar when selected.

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105520

--- Comment #3 from Commit Notification 
 ---
Tamás Zolnai committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=326729ce54de5296cb2a673ae88d2befa3e245ef

tdf#105520: "Selection Count" does not appear on Status bar when selected

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105520] "Selection Count" does not appear on Status bar when selected.

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105520

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105535] New: function keys not working and distorted text

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105535

Bug ID: 105535
   Summary: function keys not working and distorted text
   Product: LibreOffice
   Version: 5.2.4.2 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: winnytsng...@live.com

Description:
In Libre Writer, the page navigation arrows don't work and when scrolling
pages, texts become distorted !!! ( View- Toolbars- ''navigation'' arrows )
This has been going on in the previous versions, but with this update (
LibreOffice_5. 2. 4_Win_x86 ) I thought these bugs would be fixed. 
Please fix in the next update !!!

Steps to Reproduce:
Texts become blurry when scrolling up and down on the page.
As for the navigation arrows, they won't work when enabled and disappear when
another key function is pressed.

Actual Results:  
Same problem.

Expected Results:
The issue should've been fixed, but wasn't.


Reproducible: Always

User Profile Reset: No.

Additional Info:
I tried restarting the program ( Libre Writer ), but no fix.


User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:50.0) Gecko/20100101
Firefox/50.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103182

Julien Nabet  changed:

   What|Removed |Added

 Depends on|104153  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104153
[Bug 104153] EDITING: Application crash when remove filter from dynamic table
(gtk3) (see comment 1)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104153] EDITING: Application crash when remove filter from dynamic table (gtk3) ( see comment 1)

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104153

Julien Nabet  changed:

   What|Removed |Added

   Keywords|wantBacktrace   |haveBacktrace
 Blocks|103182  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103182
[Bug 103182] [META] GTK3-specific bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104153] EDITING: Application crash when remove filter from dynamic table

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104153

Julien Nabet  changed:

   What|Removed |Added

Summary|EDITING: Application crash  |EDITING: Application crash
   |when remove filter from |when remove filter from
   |dynamic table (gtk3) (see   |dynamic table
   |comment 1)  |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104153] EDITING: Application crash when remove filter from dynamic table (gtk3) ( see comment 1)

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104153

--- Comment #7 from Julien Nabet  ---
Created attachment 130682
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130682=edit
bt with debug symbols

On pc Debian x86-64 with master sources updated today (+enable-dbgutil), gtk3 I
could reproduce this.

Steps to reproduce:
1) Edit layout
2) Drag Marca field from available fields and drop it to page panel, click OK
=> layout is update with page Marca
3) Edit layout (again)
4) Drag Marca field from page panel and drop it to available fields (so to
remove it), click OK
=> crash

Remark: it's not specific to gtk3, I could reproduce this with gen and kde4
rendering

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105528] Random Freeze and Crash

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105528

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||serval2...@yahoo.fr
 Ever confirmed|0   |1

--- Comment #1 from Julien Nabet  ---
2 things you can do:
1) update to 5.2.4
2) take a look to https://wiki.documentfoundation.org/QA/FirstSteps which talks
about reset LO profile. Please don't tell me it's a complicate process to
rename a folder.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105362] FILEEXPORT: Slides nearly black and unreadable when exported to PNG with transparency enabled

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105362

Aron Budea  changed:

   What|Removed |Added

 CC||armin.le.gr...@me.com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||922

--- Comment #4 from Aron Budea  ---
Bibisect points to the commit referenced below. Adding Cc: to Armin Le Grand,
please take a look.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=f3ff67d3c3047de3ad43f8bb3f805d82eaef0479
author  Armin Le Grand   2016-03-02 16:21:10
(GMT)
committer   Michael Stahl    2016-03-02 21:29:48
(GMT)

"tdf#96922 Suppress EditView PageVisuailsation in GraphicExporter"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105362] FILEEXPORT: Slides nearly black and unreadable when exported to PNG with transparency enabled

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105362

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected

--- Comment #3 from Aron Budea  ---
281611bcbe466cc1fd08ad39c8a664b92322d27a is the first bad commit
commit 281611bcbe466cc1fd08ad39c8a664b92322d27a
Author: Norbert Thiebaud 
Date:   Wed Mar 9 00:46:39 2016 -0800

source sha:f3ff67d3c3047de3ad43f8bb3f805d82eaef0479

# bad: [86cb9d229718f48f9538032b80037238ea79e8a5] source
sha:78223678b7513ffe46804cb08f2dc5bc899b2bab
# good: [9ff0a94931d5aba1e838c680c9604562eb2e71e2] source
sha:76ec54e8c9f3580450bca85236a4f5af0c328588
git bisect start '86cb9d229718f48f9538032b80037238ea79e8a5' '9ff0a94'
# bad: [f5479928f74d40ebd332b0d23929c59bbf6fa411] source
sha:b5d7b60fe3c0befb07ba739b0168bfc17851667f
git bisect bad f5479928f74d40ebd332b0d23929c59bbf6fa411
# bad: [18e8fa47941375b9fcb3b5c41ee4945880cb] source
sha:7c0f6b9d0fb8d7d9e54865ccf1047bb8f8148101
git bisect bad 18e8fa47941375b9fcb3b5c41ee4945880cb
# good: [ac578e55fcf0b573382291810d43e94703fa0077] source
sha:4943ee042ac487bc9be4477fed7effa8ea9f74d4
git bisect good ac578e55fcf0b573382291810d43e94703fa0077
# bad: [64ce7f0568248e7fa02fe8c59e37dea1fe80f434] source
sha:8fb170cbe929fcbf85b24284bf31ec6b06150fbe
git bisect bad 64ce7f0568248e7fa02fe8c59e37dea1fe80f434
# good: [a287f76f68517ca3a34bdb0acdf918697209f265] source
sha:74040d447912eff5f7366b8ae61244ad101000dc
git bisect good a287f76f68517ca3a34bdb0acdf918697209f265
# good: [1b11c126f5d167c54ee01cbfa810fd9010505125] source
sha:def71473d25e88729c644e35523d267c8cd04e57
git bisect good 1b11c126f5d167c54ee01cbfa810fd9010505125
# good: [c2e0f20b7865e51c29df993d03072011ea88a89e] source
sha:3fd13a33670e8526bfe32bd4af83315cb35db697
git bisect good c2e0f20b7865e51c29df993d03072011ea88a89e
# bad: [ab5dc093c260c701ca701096b25c13d2a0e524ba] source
sha:bd2bf6bd559163389d1e6b6b948fc29cee5f13f5
git bisect bad ab5dc093c260c701ca701096b25c13d2a0e524ba
# good: [982ead95c22ca2cda7d3931f9439d54744bd69ed] source
sha:b2f5336b08b5f638f890a626eb2aeefaf499a79b
git bisect good 982ead95c22ca2cda7d3931f9439d54744bd69ed
# bad: [281611bcbe466cc1fd08ad39c8a664b92322d27a] source
sha:f3ff67d3c3047de3ad43f8bb3f805d82eaef0479
git bisect bad 281611bcbe466cc1fd08ad39c8a664b92322d27a
# good: [3ccc629b735d74b40461d9c0526341a0d51ab9b9] source
sha:3231e5c3626e5a194de0cc521606df54318117f4
git bisect good 3ccc629b735d74b40461d9c0526341a0d51ab9b9
# good: [3a550df1edb427e76ee0644c0f7a598055decad7] source
sha:01ffe26fdf1c4575cffdf64468e3c1c996a2d200
git bisect good 3a550df1edb427e76ee0644c0f7a598055decad7
# first bad commit: [281611bcbe466cc1fd08ad39c8a664b92322d27a] source
sha:f3ff67d3c3047de3ad43f8bb3f805d82eaef0479

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104153] EDITING: Application crash when remove filter from dynamic table (gtk3) ( see comment 1)

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104153

--- Comment #6 from Caolán McNamara  ---
I don't see it personally in 5-3 or master as of yet.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105534] Merge is too complicated and inflexible to use

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105534

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||serval2...@yahoo.fr
 Ever confirmed|0   |1

--- Comment #1 from Julien Nabet  ---
Could you please give a try to a recent LO version? 5.2.4 is last stable one.
You can also test prerelease 5.3.0 (see
https://www.libreoffice.org/download/pre-releases/).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105457] [RFE] Investigate supporting Plotinus

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105457

--- Comment #4 from Caolán McNamara  ---
It is indeed a native gtk menubar widget in gtk3, see
vcl/unx/gtk/gtksalmenu.cxx and gtk_menu_bar_new_from_model (the various right
click context menus are also native, see GtkSalMenu::ShowNativePopupMenu in the
same file for those).

Now we are not using a GtkApplication but we do try and set up some things like
that does, see vcl/unx/gtk3/gtk3gtkframe.cxx and ensure_dbus_setup which is how
we expose the menubar stuff to unity f.e. to get the integration of the menus
with the unity mac-like menubar.

I'm not sure what the hook plotinus uses is though, it might be useful to
find/point out the piece of code that plotinus uses to register the shortcut
and perhaps that might indicate the way to go.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105129] ".~lock files" constantly opening and slowing performance on all windows systems, not in Linux system.

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105129

--- Comment #7 from Julien Nabet  ---
K-Bob: you can use odt format, the native LO Writer format. I think any recent
MsOffice version is compatible with it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

re: Usage of ActiveX in Libre Office

2017-01-25 Thread sos

Bryan,Please clarify, will stuff like
oShell = CreateObject("WScript.Shell")

Still working after removing ActiveX?If not: then lots off API code will been 
broken and this will been a BIG regression ?
Greetz
Fernand

Sent from my Samsung Galaxy smartphone.
 Original message From: Bryan Quigley 
 Date: 25/01/2017  20:43  (GMT+01:00) To: 
libreoffice@lists.freedesktop.org, libroffice@artavi.de Subject: re: Usage 
of ActiveX in Libre Office 
Welcome and thanks for responding to notice!

You're the first person (AFAICT) who has written in response to the
deprecation notice.   My original intention was to remove it from the
5.2 release if we got no responses to that notice (that obviously
hasn't happened).

At this point the soonest release we could remove it from is 5.4
(which might be around Aug 2017).  It's far from scheduled though.

We really don't have much data to base this decision on, so I'll ask
you instead.  Knowing keeping support has an impact on LibreOffice
development, when do you think is reasonable for ActiveX support to be
removed?

What Windows version are you running?

Kind regards,
Bryan

[The whole original thread - quite long]
https://lists.freedesktop.org/archives/libreoffice/2015-December/071580.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 94457] LibreOffice Draw generate a bad EMF file, incompatible with Microsoft Office Word

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=94457

Caolán McNamara  changed:

   What|Removed |Added

   Keywords|bibisected  |
 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

--- Comment #13 from Caolán McNamara  ---
as far as I can see this has been broken since the initial emfplus work, so the
bisect seems off, anyhow, seem to work now and backports for 5-3 and 5-2 are in
gerrit

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103859] [META] EMF/WMF (Windows Metafile) bugs and enhancements

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103859
Bug 103859 depends on bug 94457, which changed state.

Bug 94457 Summary: LibreOffice Draw generate a bad EMF file, incompatible with 
Microsoft Office Word
https://bugs.documentfoundation.org/show_bug.cgi?id=94457

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - ad/c647b8ee821db925e7296d0ebe0300abe8607c

2017-01-25 Thread Caolán McNamara

 ad/c647b8ee821db925e7296d0ebe0300abe8607c |1 +
 1 file changed, 1 insertion(+)

New commits:
commit d2bd4369d5fff6a3e5313b6e8342d0f7583c240e
Author: CaolÃ¡n McNamara 
Date:   Wed Jan 25 20:39:44 2017 +

Notes added by 'git notes add'

diff --git a/ad/c647b8ee821db925e7296d0ebe0300abe8607c 
b/ad/c647b8ee821db925e7296d0ebe0300abe8607c
new file mode 100644
index 000..8e5c182
--- /dev/null
+++ b/ad/c647b8ee821db925e7296d0ebe0300abe8607c
@@ -0,0 +1 @@
+ignore: aoo
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 23/578f63821e340dc1718dc1ed0d046d63efe523

2017-01-25 Thread Caolán McNamara

 23/578f63821e340dc1718dc1ed0d046d63efe523 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 96145c0032c803a3e149029d4522bcb06a17e519
Author: CaolÃ¡n McNamara 
Date:   Wed Jan 25 20:38:54 2017 +

Notes added by 'git notes add'

diff --git a/23/578f63821e340dc1718dc1ed0d046d63efe523 
b/23/578f63821e340dc1718dc1ed0d046d63efe523
new file mode 100644
index 000..8ebbe55
--- /dev/null
+++ b/23/578f63821e340dc1718dc1ed0d046d63efe523
@@ -0,0 +1 @@
+ignore: obsolete
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 37/2c52f82b9e126159f76c4033923db14c9ec3fc

2017-01-25 Thread Caolán McNamara

 37/2c52f82b9e126159f76c4033923db14c9ec3fc |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 5d59e22ebdbd06e5256f8fdee3eb7c8a28b827cc
Author: CaolÃ¡n McNamara 
Date:   Wed Jan 25 20:37:54 2017 +

Notes added by 'git notes add'

diff --git a/37/2c52f82b9e126159f76c4033923db14c9ec3fc 
b/37/2c52f82b9e126159f76c4033923db14c9ec3fc
new file mode 100644
index 000..8ebbe55
--- /dev/null
+++ b/37/2c52f82b9e126159f76c4033923db14c9ec3fc
@@ -0,0 +1 @@
+ignore: obsolete
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 8f/13409161d2abbf4705d0732331c1c7175a51a8

2017-01-25 Thread Caolán McNamara

 8f/13409161d2abbf4705d0732331c1c7175a51a8 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 3c32a9323a0f91b692a2084b270eafe4f885a827
Author: CaolÃ¡n McNamara 
Date:   Wed Jan 25 20:37:01 2017 +

Notes added by 'git notes add'

diff --git a/8f/13409161d2abbf4705d0732331c1c7175a51a8 
b/8f/13409161d2abbf4705d0732331c1c7175a51a8
new file mode 100644
index 000..8ebbe55
--- /dev/null
+++ b/8f/13409161d2abbf4705d0732331c1c7175a51a8
@@ -0,0 +1 @@
+ignore: obsolete
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3-0' - sc/source

2017-01-25 Thread Eike Rathke

 sc/source/ui/view/cellsh1.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit df4efcbbb820f7e2c15afd15ccf29b4f613bca44
Author: Eike Rathke 
Date:   Wed Jan 25 13:34:43 2017 +0100

Resolves: tdf#105351 pass matching index key to conditional format dialog

Change-Id: I9d872140755c4ec0ae67349530b00f339057a356
(cherry picked from commit 0367acdcc59e14b0b067976a08202e8afef0ecf3)
Reviewed-on: https://gerrit.libreoffice.org/33529
Reviewed-by: Markus Mohrhard 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/sc/source/ui/view/cellsh1.cxx b/sc/source/ui/view/cellsh1.cxx
index f661f34..f17de35 100644
--- a/sc/source/ui/view/cellsh1.cxx
+++ b/sc/source/ui/view/cellsh1.cxx
@@ -2004,6 +2004,7 @@ void ScCellShell::ExecuteEdit( SfxRequest& rReq )
 {
 // found a matching range, edit this conditional 
format
 bCondFormatDlg = true;
+nIndex = pCondFormat->GetKey();
 break;
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Usage of ActiveX in Libre Office

2017-01-25 Thread Kaganski Mike

Hello,

On 1/23/2017 5:42 PM, libroffice@artavi.de 
wrote:
We are recently switched from AOO to LO. In the release notes a possible 
removal of ActiveX is announced.
You are asking for information about the use case so here we are:

We are using in our company a selfmade ERP system which is grown for more than 
15 years now. For historical reasons the system is written in Delphi. At the 
beginning MS Office was used as "office frontend", since about 10 years 
OOo/AOO/LO. The main workflow is using calc for business calculation and writer 
as a kind of report tool. Most information from the main database is delivered 
via ActiveX to calc. After working in calc the information are read back and 
used to create documents in writer. The complete project and document 
management (and many more) is done by our ERP.

I know there are others and probably more elegant ways and about once a year we 
are discussing to change that and finding the "big solution" - but this is a 
huge and expensive project.

Just wanted to mention two (now discontinued) projects that aimed to provide 
alternative ActiveX MS Office-compatible APIs for OpenOffice.org: AutomateIT! 
(https://sourceforge.net/projects/automateit/) and UniOffice 
(http://wiki.etersoft.ru/UniOffice, 
http://ftp.etersoft.ru/pub/Etersoft/UniOffice@Etersoft/). They are open-source, 
and may be of some interest if someone wants to take the code and 
improve/maintain it. In Russia, there were a number of working solutions based 
on them, so they are at least working starting point.


Removing ActiveX from LO will be a showstopper and nail us to the last 
supported release - or bring us back to AOO, who knows.

Best regards
Joergen Pisarz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


--
Best regards,
Mike Kaganski
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 105003] Rotating a PNG image is quite slow

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105003

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|bibisectRequest, regression |
 CC||xiscofa...@libreoffice.org

--- Comment #4 from Xisco Faulí  ---
Image rotation was introduced by commit
df155415d8f46d884ba18e370e8028d020ba6f3b and going back to that point it
already takes ~5 seconds, so this is not a regression at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 76/5f7daa65e8f8fa0fe54f23c16bbbea8e81880e

2017-01-25 Thread Caolán McNamara

 76/5f7daa65e8f8fa0fe54f23c16bbbea8e81880e |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 30bf391a893aacba2abfde677852707663575ada
Author: CaolÃ¡n McNamara 
Date:   Wed Jan 25 20:35:30 2017 +

Notes added by 'git notes add'

diff --git a/76/5f7daa65e8f8fa0fe54f23c16bbbea8e81880e 
b/76/5f7daa65e8f8fa0fe54f23c16bbbea8e81880e
new file mode 100644
index 000..8e5c182
--- /dev/null
+++ b/76/5f7daa65e8f8fa0fe54f23c16bbbea8e81880e
@@ -0,0 +1 @@
+ignore: aoo
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sc/source

2017-01-25 Thread Eike Rathke

 sc/source/core/data/conditio.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f6587264b2c5b9191a4a7b547416c366db1c5607
Author: Eike Rathke 
Date:   Wed Jan 25 11:40:52 2017 +0100

Resolves: tdf#104675 ScConditionalFormat ranges needed to start listening

Conditional format manager dialog holds a cloned list of
ScConditionalFormat and sets that at the document on OK. The ranges of a
format need to be set before ScFormatEntry/ScConditionEntry are added to
start their listeners.

Change-Id: I903553b1f6a8298838ee8753315a6ea263b29b08
(cherry picked from commit 657eea01046c7f39ee8ca4545241372177385946)
Reviewed-on: https://gerrit.libreoffice.org/33525
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/sc/source/core/data/conditio.cxx b/sc/source/core/data/conditio.cxx
index 0f8764b..6657dcf 100644
--- a/sc/source/core/data/conditio.cxx
+++ b/sc/source/core/data/conditio.cxx
@@ -1776,6 +1776,7 @@ ScConditionalFormat* 
ScConditionalFormat::Clone(ScDocument* pNewDoc) const
 pNewDoc = pDoc;
 
 ScConditionalFormat* pNew = new ScConditionalFormat(nKey, pNewDoc);
+pNew->SetRange( maRanges ); // prerequisite for listeners
 
 for (CondFormatContainer::const_iterator itr = maEntries.begin(); itr != 
maEntries.end(); ++itr)
 {
@@ -1783,7 +1784,6 @@ ScConditionalFormat* 
ScConditionalFormat::Clone(ScDocument* pNewDoc) const
 pNew->maEntries.push_back( std::unique_ptr(pNewEntry) );
 pNewEntry->SetParent(pNew);
 }
-pNew->SetRange( maRanges );
 
 return pNew;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105448] i18n: add Manchu and Sibe to language list

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105448

Eike Rathke  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
  Component|LibreOffice |Localization
   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |
Summary|Making more language|i18n: add Manchu and Sibe
   |specific features available |to language list
 Ever confirmed|0   |1
   Severity|normal  |enhancement

--- Comment #10 from Eike Rathke  ---
We won't add 7874 languages to that listbox..

For specific requests please follow
https://wiki.documentfoundation.org/LibreOffice_Localization_Guide/Adding_a_New_Language_or_Locale#Request_a_new_language.2Flocale_to_be_added

However, I can take this ticket here to add Manchu and Sibe, as you explicitly
mentioned them.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sw/qa sw/source

2017-01-25 Thread Justin Luth

 dev/null   |binary
 sw/qa/extras/ww8export/data/bnc863018b.doc |binary
 sw/qa/extras/ww8export/data/tdf96277.doc   |binary
 sw/qa/extras/ww8export/ww8export2.cxx  |   13 +
 sw/qa/extras/ww8import/ww8import.cxx   |   10 --
 sw/source/filter/ww8/ww8par.cxx|8 ++--
 sw/source/filter/ww8/ww8par.hxx|4 ++--
 sw/source/filter/ww8/ww8par2.cxx   |   11 ---
 sw/source/filter/ww8/ww8par6.cxx   |   20 +---
 9 files changed, 22 insertions(+), 44 deletions(-)

New commits:
commit a47cada052427bc5cf6123b11e3643a3a8a8516a
Author: Justin Luth 
Date:   Thu Jan 19 16:27:41 2017 +0300

tdf#96277 revert ww8 import: fix upper margin of floating table

commit 3755c87d0426a499d4755e82d8fbc77caa240764
mis-positions non-textframed floating tables.

The patch only worked under very ideal circumstances
that cannot be identified during import time. Lots of bug
reports indicate real world problems with it.

This is a pretty safe revert because the code only
processes a document one time, so old documents don't
depend on this to work.

Change-Id: I3b94d27901a20e46c2f5fd4305041d1d28acf33a
Reviewed-on: https://gerrit.libreoffice.org/33322
Reviewed-by: Justin Luth 
Tested-by: Justin Luth 
Reviewed-by: Miklos Vajna 
(cherry picked from commit 895f4bc27d518ecaa054d812fa6c24fd4301d327)
Reviewed-on: https://gerrit.libreoffice.org/33503
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/sw/qa/extras/ww8import/data/bnc863018.doc 
b/sw/qa/extras/ww8export/data/bnc863018b.doc
old mode 100644
new mode 100755
similarity index 63%
rename from sw/qa/extras/ww8import/data/bnc863018.doc
rename to sw/qa/extras/ww8export/data/bnc863018b.doc
index ab7511b..c9744b8
Binary files a/sw/qa/extras/ww8import/data/bnc863018.doc and 
b/sw/qa/extras/ww8export/data/bnc863018b.doc differ
diff --git a/sw/qa/extras/ww8export/data/tdf96277.doc 
b/sw/qa/extras/ww8export/data/tdf96277.doc
new file mode 100755
index 000..904b2da
Binary files /dev/null and b/sw/qa/extras/ww8export/data/tdf96277.doc differ
diff --git a/sw/qa/extras/ww8export/ww8export2.cxx 
b/sw/qa/extras/ww8export/ww8export2.cxx
index bf6b36f..3259d23 100644
--- a/sw/qa/extras/ww8export/ww8export2.cxx
+++ b/sw/qa/extras/ww8export/ww8export2.cxx
@@ -40,6 +40,19 @@ DECLARE_WW8EXPORT_TEST(testTdf89377, 
"tdf89377_tableWithBreakBeforeParaStyle.doc
 CPPUNIT_ASSERT_EQUAL( 2, getPages() );
 }
 
+DECLARE_WW8EXPORT_TEST(testTdf96277, "tdf96277.doc")
+{
+// mismatch between anchoring at paragraph and ULSpacing to Page
+CPPUNIT_ASSERT_EQUAL( 1, getPages() );
+}
+
+DECLARE_WW8EXPORT_TEST(testBnc863018b, "bnc863018b.doc")
+{
+// The whitespace above the table should allow text to flow between the 
table anchor and the table.
+// Since it doesn't, don't add the whitespace.
+CPPUNIT_ASSERT_EQUAL( 1, getPages() );
+}
+
 DECLARE_WW8EXPORT_TEST(testTdf104805, "tdf104805.doc")
 {
 uno::Reference 
xPropertySet(getStyles("NumberingStyles")->getByName("WW8Num1"), 
uno::UNO_QUERY);
diff --git a/sw/qa/extras/ww8import/ww8import.cxx 
b/sw/qa/extras/ww8import/ww8import.cxx
index 85f4ca3..b26c3db 100644
--- a/sw/qa/extras/ww8import/ww8import.cxx
+++ b/sw/qa/extras/ww8import/ww8import.cxx
@@ -42,16 +42,6 @@ DECLARE_WW8IMPORT_TEST(testN816593, "n816593.doc")
 CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xIndexAccess->getCount());
 }
 
-DECLARE_WW8IMPORT_TEST(testBnc863018, "bnc863018.doc")
-{
-// The problem was that there should be some whitespace above the table,
-// but there wasn't.
-uno::Reference xTextTablesSupplier(mxComponent, 
uno::UNO_QUERY);
-uno::Reference 
xIndexAccess(xTextTablesSupplier->getTextTables(), uno::UNO_QUERY);
-uno::Reference xTable(xIndexAccess->getByIndex(0), 
uno::UNO_QUERY);
-// This was 0.
-CPPUNIT_ASSERT_EQUAL(sal_Int32(5002), getProperty(xTable, 
"TopMargin"));
-}
 DECLARE_WW8IMPORT_TEST(testBnc875715, "bnc875715.doc")
 {
 uno::Reference 
xTextSectionsSupplier(mxComponent, uno::UNO_QUERY);
diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx
index 10094cf..8074908 100644
--- a/sw/source/filter/ww8/ww8par.cxx
+++ b/sw/source/filter/ww8/ww8par.cxx
@@ -2714,13 +2714,9 @@ bool SwWW8ImplReader::ProcessSpecial(bool , 
WW8_CP nStartCp)
 m_aApos[m_nInTable] = false;
 }
 
-// So that SwWW8ImplReader::StartApo() can write into this, and
-// WW8TabDesc::CreateSwTable() can read it, if necessary.
-SvxULSpaceItem aULSpaceItem(RES_UL_SPACE);
-
 if (aApo.mbStartApo)
 {
-m_aApos[m_nInTable] = StartApo(aApo, pTabPos, );
+m_aApos[m_nInTable] =

[Libreoffice-bugs] [Bug 105382] File name is percent-encoded when minimize presentation on Impress

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105382

--- Comment #5 from Commit Notification 
 ---
Takeshi Abe committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=dcd89d24f0837f85a359f2630981d985a9811d86=libreoffice-5-3

tdf#105382 Set URL-decoded default filename for minimized presentation

It will be available in 5.3.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105382] File name is percent-encoded when minimize presentation on Impress

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105382

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.4.0|target:5.4.0 target:5.3.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 5e/052c8193a5e7c8b57f1b11e4e25e2fe11663d2

2017-01-25 Thread Caolán McNamara

 5e/052c8193a5e7c8b57f1b11e4e25e2fe11663d2 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 02a4c6cba07b96c04640585eb272058eaea7744b
Author: CaolÃ¡n McNamara 
Date:   Wed Jan 25 20:34:16 2017 +

Notes added by 'git notes add'

diff --git a/5e/052c8193a5e7c8b57f1b11e4e25e2fe11663d2 
b/5e/052c8193a5e7c8b57f1b11e4e25e2fe11663d2
new file mode 100644
index 000..9d44873
--- /dev/null
+++ b/5e/052c8193a5e7c8b57f1b11e4e25e2fe11663d2
@@ -0,0 +1 @@
+prefer: 5955a98b2aff796a0c7311f6f61a13eac8754ce7
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sdext/Library_PresentationMinimizer.mk sdext/source

2017-01-25 Thread Takeshi Abe

 sdext/Library_PresentationMinimizer.mk |1 +
 sdext/source/minimizer/optimizerdialog.cxx |   27 +--
 2 files changed, 10 insertions(+), 18 deletions(-)

New commits:
commit dcd89d24f0837f85a359f2630981d985a9811d86
Author: Takeshi Abe 
Date:   Tue Jan 24 18:55:20 2017 +0900

tdf#105382 Set URL-decoded default filename for minimized presentation

See mailing-list thread starting at


for a discussion on the original presentation file's URL.

Reviewed-on: https://gerrit.libreoffice.org/33261
Reviewed-by: Stephan Bergmann 
Tested-by: Jenkins 
(cherry picked from commit d8aa4503966e2c8882c238a1a30c05b72bdf6f68)

Change-Id: I51ccd7672513118f39518c4ed21902de16b2298f
Reviewed-on: https://gerrit.libreoffice.org/33507
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/sdext/Library_PresentationMinimizer.mk 
b/sdext/Library_PresentationMinimizer.mk
index 2ae650a..eb8995f 100644
--- a/sdext/Library_PresentationMinimizer.mk
+++ b/sdext/Library_PresentationMinimizer.mk
@@ -28,6 +28,7 @@ $(eval $(call gb_Library_use_libraries,PresentationMinimizer,\
 cppu \
 cppuhelper \
 sal \
+tl \
 ))
 
 $(eval $(call gb_Library_add_exception_objects,PresentationMinimizer,\
diff --git a/sdext/source/minimizer/optimizerdialog.cxx 
b/sdext/source/minimizer/optimizerdialog.cxx
index 78c044a..40d8132 100644
--- a/sdext/source/minimizer/optimizerdialog.cxx
+++ b/sdext/source/minimizer/optimizerdialog.cxx
@@ -29,6 +29,7 @@
 #include 
 #include 
 #include 
+#include 
 
 
 using namespace ::com::sun::star::io;
@@ -511,24 +512,14 @@ void ActionListener::actionPerformed( const ActionEvent& 
rEvent )
 Reference< XStorable > xStorable( 
mrOptimizerDialog.mxController->getModel(), UNO_QUERY );
 if ( xStorable.is() && xStorable->hasLocation() )
 {
-OUString aLocation( xStorable->getLocation() );
-if ( !aLocation.isEmpty() )
-{
-sal_Int32 nIndex = aLocation.lastIndexOf( '/', 
aLocation.getLength() - 1 );
-if ( nIndex >= 0 )
-{
-if ( nIndex < aLocation.getLength() - 1 )
-aLocation = aLocation.copy( nIndex + 1 );
-
-// remove extension
-nIndex = aLocation.lastIndexOf( '.', 
aLocation.getLength() - 1 );
-if ( nIndex >= 0 )
-aLocation = aLocation.copy( 0, nIndex );
-
-// adding .mini
-aLocation = aLocation.concat( ".mini" );
-aFileOpenDialog.setDefaultName( aLocation );
-}
+INetURLObject aURLObj( xStorable->getLocation() );
+if ( !aURLObj.hasFinalSlash() &&
+ aURLObj.setExtension( "mini", 
INetURLObject::LAST_SEGMENT, false ) ) {
+// tdf#105382 uri-decode file name
+auto aName( aURLObj.getName( 
INetURLObject::LAST_SEGMENT,
+ false,
+ 
INetURLObject::DECODE_WITH_CHARSET ) );
+aFileOpenDialog.setDefaultName( aName );
 }
 }
  bool bDialogExecuted = aFileOpenDialog.execute() == 
dialogs::ExecutableDialogResults::OK;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104903] Firebird: Function ROUND gives wrong values

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104903

rob...@familiegrosskopf.de changed:

   What|Removed |Added

Version|5.4.0.0.alpha0+ Master  |5.3.0.0.alpha0+

--- Comment #3 from rob...@familiegrosskopf.de ---
Changed the version to the first LO 5.3, because the bug has been introduced
with new Firebird 3.0.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3-0' - canvas/source

2017-01-25 Thread Aron Budea

 canvas/source/directx/dx_9rm.cxx |   19 +++
 1 file changed, 11 insertions(+), 8 deletions(-)

New commits:
commit b0676e0ec9a770f83c19390d2d69df57bdb60d24
Author: Aron Budea 
Date:   Mon Jan 23 03:47:19 2017 +0100

tdf#100151: Dispose of window if DX device creation failed

Before, if the device lacked Direct3D capabilities, VclPtr
handling became compromised, and caused a crash. This was
particularly a problem in virtualized/remote desktop
connections in Windows.

Now mpWindow instance is disposed of right away if DX
device creation fails.

Change-Id: I639340380affdb31a93ce6dccd8df33a0a466df6
Reviewed-on: https://gerrit.libreoffice.org/33413
Reviewed-by: Michael Meeks 
Tested-by: Jenkins 
(cherry picked from commit bb50474225f80b8aeea49f14ad66173462026a41)
Reviewed-on: https://gerrit.libreoffice.org/33478
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/canvas/source/directx/dx_9rm.cxx b/canvas/source/directx/dx_9rm.cxx
index 1f58f2b..4b41d30 100644
--- a/canvas/source/directx/dx_9rm.cxx
+++ b/canvas/source/directx/dx_9rm.cxx
@@ -583,6 +583,14 @@ namespace dxcanvas
 // TODO(P2): get rid of those fine-grained locking
 ::osl::MutexGuard aGuard( maMutex );
 
+// TODO(F2): since we would like to share precious hardware
+// resources, the direct3d9 object should be global. each new
+// request for a canvas should only create a new swapchain.
+mpDirect3D9 = COMReference(
+Direct3DCreate9(D3D_SDK_VERSION));
+if(!mpDirect3D9.is())
+return false;
+
 maVertexCache.reserve( 1024 );
 
 mpWindow.disposeAndClear();
@@ -619,17 +627,12 @@ namespace dxcanvas
 // let the child window cover the same size as the parent window.
 mpWindow->setPosSizePixel(0,0,maSize.getX(),maSize.getY());
 
-// TODO(F2): since we would like to share precious hardware
-// resources, the direct3d9 object should be global. each new
-// request for a canvas should only create a new swapchain.
-mpDirect3D9 = COMReference(
-Direct3DCreate9(D3D_SDK_VERSION));
-if(!mpDirect3D9.is())
-return false;
-
 // create a device from the direct3d9 object.
 if(!(createDevice()))
+{
+mpWindow.disposeAndClear();
 return false;
+}
 
 mpWindow->Show();
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 94457] LibreOffice Draw generate a bad EMF file, incompatible with Microsoft Office Word

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=94457

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104903] Firebird: Function ROUND gives wrong values

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104903

--- Comment #2 from rob...@familiegrosskopf.de ---
Testing this again with Casting the type of the direct inputted value:

SELECT "ID", CAST(7.35 AS NUMERIC(4,2)) "7.35", ROUND(  CAST(7.35 AS
NUMERIC(4,2)), 1 ) "ROUND(7.35, 1)" FROM "Table"

will show the right values. Have changed the values of the field, because the
GUI will only show 2 digits by default.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94457] LibreOffice Draw generate a bad EMF file, incompatible with Microsoft Office Word

2017-01-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=94457

--- Comment #12 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=3d92c34d0a4db27435458e0f3dd50709622388a9

Resolves: tdf#94457 our EmfPlusSetPageTransform is malformed

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source

2017-01-25 Thread Caolán McNamara

 vcl/source/filter/wmf/emfwr.cxx |4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 3d92c34d0a4db27435458e0f3dd50709622388a9
Author: CaolÃ¡n McNamara 
Date:   Wed Jan 25 16:51:00 2017 +

Resolves: tdf#94457 our EmfPlusSetPageTransform is malformed

we write a single short, resulting in a record of 0x000C in length 
MS-EMFPLUS
spec has EmfPlusSetPageTransform as 0x0010 in length because we're not 
writing
the 4 byte PageScale value.

the previous pageunit unit we are writing is of value 1, which is
UnitTypeDisplay, the same spec says...

"The unit of measure for page space coordinates, from the UnitType 
enumeration.
This value SHOULD NOT be UnitTypeDisplay or UnitTypeWorld"

and footnotes that with...

"Windows never writes those values to the PageUnit field, but they are 
accepted
with undefined results."

Change-Id: Ic8b5ec463b59aab28ae9897947dfcdbd35b22048
Reviewed-on: https://gerrit.libreoffice.org/33548
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/vcl/source/filter/wmf/emfwr.cxx b/vcl/source/filter/wmf/emfwr.cxx
index 947d139..7eb9c63 100644
--- a/vcl/source/filter/wmf/emfwr.cxx
+++ b/vcl/source/filter/wmf/emfwr.cxx
@@ -102,8 +102,7 @@ enum class EmfPlusRecordType
 SetAntiAliasMode   = 0x401E,
 SetInterpolationMode   = 0x4021,
 SetPixelOffsetMode = 0x4022,
-SetCompositingQuality  = 0x4024,
-SetPageTransform   = 0x4030,
+SetCompositingQuality  = 0x4024
 };
 
 void EMFWriter::ImplBeginCommentRecord( sal_Int32 nCommentType )
@@ -190,7 +189,6 @@ void EMFWriter::WriteEMFPlusHeader( const Size 
, const Size 
 ImplPlusRecord( EmfPlusRecordType::SetPixelOffsetMode, 0x0 );
 ImplPlusRecord( EmfPlusRecordType::SetAntiAliasMode, 0x09 );  // TODO: 
Check actual values for AntiAlias
 ImplPlusRecord( EmfPlusRecordType::SetCompositingQuality, 0x0100 ); // 
Default Quality
-ImplPlusRecord( EmfPlusRecordType::SetPageTransform, 1 );
 ImplPlusRecord( EmfPlusRecordType::SetInterpolationMode, 0x00 );  // 
Default
 ImplPlusRecord( EmfPlusRecordType::GetDC, 0x00 );
 ImplEndCommentRecord();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

2017-01-25 Thread Caolán McNamara

 vcl/source/filter/ixpm/xpmread.cxx |  205 ++---
 1 file changed, 81 insertions(+), 124 deletions(-)

New commits:
commit 88a3b62194d07bb64bfd2fc186097441dc93dfa3
Author: CaolÃ¡n McNamara 
Date:   Wed Jan 25 12:09:04 2017 +

ofz: xpm parser is too slow

and keeps timing out on documents, this takes my example pathological
case from a callgrind cost of 40875 to 1292 million, and as a side effect
rhbz#1051121-xpm now look right

Change-Id: I840705007acf329579f270c390328f80190c19e7
Reviewed-on: https://gerrit.libreoffice.org/33532
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/vcl/source/filter/ixpm/xpmread.cxx 
b/vcl/source/filter/ixpm/xpmread.cxx
index dd31d97..a0306b5 100644
--- a/vcl/source/filter/ixpm/xpmread.cxx
+++ b/vcl/source/filter/ixpm/xpmread.cxx
@@ -22,6 +22,8 @@
 #include "rgbtable.hxx"
 #include "xpmread.hxx"
 #include 
+#include 
+#include 
 
 #define XPMTEMPBUFSIZE  0x8000
 #define XPMSTRINGBUF0x8000
@@ -39,9 +41,6 @@
 #define XPMSTRING   0x0004
 #define XPMFINISHED 0x0008
 
-#define XPMCASESENSITIVE0x0001
-#define XPMCASENONSENSITIVE 0x0002
-
 enum ReadState
 {
 XPMREAD_OK,
@@ -76,21 +75,26 @@ private:
 sal_uLong   mnTempAvail;
 sal_uInt8*  mpTempBuf;
 sal_uInt8*  mpTempPtr;
-sal_uInt8*  mpFastColorTable;
-sal_uInt8*  mpColMap;
+// each key is ( mnCpp )Byte(s)-> ASCII entry assigned to the colour
+// each colordata is
+// 1 Byte   -> 0xFF if colour is transparent
+// 3 Bytes  -> RGB value of the colour
+typedef std::array colordata;
+typedef std::map colormap;
+colormapmaColMap;
 sal_uLong   mnStringSize;
 sal_uInt8*  mpStringBuf;
 sal_uLong   mnParaSize;
 sal_uInt8*  mpPara;
 
 boolImplGetString();
-boolImplGetColor( sal_uLong );
+boolImplGetColor();
 boolImplGetScanLine( sal_uLong );
-boolImplGetColSub( sal_uInt8* );
+boolImplGetColSub(colordata );
 boolImplGetColKey( sal_uInt8 );
-voidImplGetRGBHex( sal_uInt8*, sal_uLong );
+voidImplGetRGBHex(colordata , sal_uLong);
 boolImplGetPara( sal_uLong numb );
-static bool ImplCompare( sal_uInt8 const *, sal_uInt8 const *, 
sal_uLong, sal_uLong nmode = XPMCASENONSENSITIVE );
+static bool ImplCompare(sal_uInt8 const *, sal_uInt8 const *, 
sal_uLong);
 sal_uLong   ImplGetULONG( sal_uLong nPara );
 
 public:
@@ -115,8 +119,6 @@ XPMReader::XPMReader(SvStream& rStm)
 , mnTempAvail(0)
 , mpTempBuf(nullptr)
 , mpTempPtr(nullptr)
-, mpFastColorTable(nullptr)
-, mpColMap(nullptr)
 , mnStringSize(0)
 , mpStringBuf(nullptr)
 , mnParaSize(0)
@@ -162,14 +164,9 @@ ReadState XPMReader::ReadXPM( Graphic& rGraphic )
 {
 mnIdentifier = XPMCOLORS;
 
-// mpColMap constitutes for all available
-// colour:   ( mnCpp )Byte(s)-> ASCII entry assigned to the 
colour
-//  1Byte   -> 0xFF if colour is transparent
-//  3Bytes  -> RGB value of the colour
-mpColMap = new sal_uInt8[ mnColors * ( 4 + mnCpp ) ];
-for ( sal_uLong i = 0; i < mnColors; i++ )
+for (sal_uLong i = 0; i < mnColors; ++i)
 {
-if ( !ImplGetColor( i ) )
+if (!ImplGetColor())
 {
 mbStatus = false;
 break;
@@ -202,34 +199,21 @@ ReadState XPMReader::ReadXPM( Graphic& rGraphic )
 }
 if( mpAcc && mbStatus )
 {
-sal_uLong   i;
-if ( mnColors <=256 )   // palette is only needed by 
using less than 257
-{   // colors
-
-sal_uInt8*  pPtr = [mnCpp];
-
-for ( i = 0; i < mnColors; i++ )
-{
-mpAcc->SetPaletteColor( (sal_uInt8)i, Color( 
pPtr[1], pPtr[2], pPtr[3] ) );
-pPtr += ( mnCpp + 4 );
-}
-// using 2 characters per pixel and less than 257 
Colors we speed up
-if ( mnCpp == 2 )   // by using a 64kb indexing 
table
+if (mnColors <= 256)  // palette is only needed by 
using less

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sw/inc sw/qa sw/source

2017-01-25 Thread Michael Stahl

 sw/inc/ToxLinkProcessor.hxx |2 -
 sw/qa/core/test_ToxLinkProcessor.cxx|   38 ++--
 sw/source/core/tox/ToxLinkProcessor.cxx |   18 +++
 3 files changed, 27 insertions(+), 31 deletions(-)

New commits:
commit 0f3c645a8f6662aff1d96307b905f5309079bddc
Author: Michael Stahl 
Date:   Wed Jan 25 17:12:42 2017 +0100

sw: revert ToX hyperlinks to LO 4.3 behaviour

Commit 94b296d5416dd71d721ad16216b50bce79e3dc04 changed this to
potentially insert multiple overlapping hyperlink items.

Unfortunately Writer can only have one RES_TXTATR_INETFMT on any given
position in the paragraph, so the hyperlink hints inevitably overwrite
each other.

Revert this to do it the same way as the old code in LO 4.3 did: match
the last unmatched link-start with the first link-end, and ignore all
the link-start before the matching one, as well as the link-end after
the matching one.

This should prevent surprising formatting changes on index update,
including entries spontaneously turning green, and there is no reason
why the result of the new way is objectively better than the old one.

Change-Id: I55be9c212c473908428fa8bd6487d136343fe852
(cherry picked from commit 68f7be01a78a5bad56ddd94c04764131676d6cc0)
Reviewed-on: https://gerrit.libreoffice.org/33552
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/sw/inc/ToxLinkProcessor.hxx b/sw/inc/ToxLinkProcessor.hxx
index 7fceef1..78bb7fb 100644
--- a/sw/inc/ToxLinkProcessor.hxx
+++ b/sw/inc/ToxLinkProcessor.hxx
@@ -82,7 +82,7 @@ private:
 
 std::vector m_ClosedLinks;
 
-std::vector m_StartedLinks;
+std::unique_ptr m_pStartedLink;
 
 friend class ::ToxLinkProcessorTest;
 };
diff --git a/sw/qa/core/test_ToxLinkProcessor.cxx 
b/sw/qa/core/test_ToxLinkProcessor.cxx
index eb4618e..d2d4721 100644
--- a/sw/qa/core/test_ToxLinkProcessor.cxx
+++ b/sw/qa/core/test_ToxLinkProcessor.cxx
@@ -30,17 +30,15 @@ using namespace sw;
 class ToxLinkProcessorTest : public test::BootstrapFixture
 {
 void NoExceptionIsThrownIfTooManyLinksAreClosed();
-void AddingAndClosingTwoLinksResultsInTwoClosedLinks();
+void AddingAndClosingTwoOverlappingLinksResultsInOneClosedLink();
 void LinkIsCreatedCorrectly();
 void LinkSequenceIsPreserved();
-void StandardOpenLinkIsAddedWhenMoreLinksThanAvaiableAreClosed();
 
 CPPUNIT_TEST_SUITE(ToxLinkProcessorTest);
 CPPUNIT_TEST(NoExceptionIsThrownIfTooManyLinksAreClosed);
-CPPUNIT_TEST(AddingAndClosingTwoLinksResultsInTwoClosedLinks);
+CPPUNIT_TEST(AddingAndClosingTwoOverlappingLinksResultsInOneClosedLink);
 CPPUNIT_TEST(LinkIsCreatedCorrectly);
 CPPUNIT_TEST(LinkSequenceIsPreserved);
-CPPUNIT_TEST(StandardOpenLinkIsAddedWhenMoreLinksThanAvaiableAreClosed);
 CPPUNIT_TEST_SUITE_END();
 public:
 void setUp() override {
@@ -71,30 +69,28 @@ 
ToxLinkProcessorTest::NoExceptionIsThrownIfTooManyLinksAreClosed()
 sut.CloseLink(1, URL_1);
 // fdo#85872 actually it turns out the UI does something like this
 // so an exception must not be thrown!
-sut.CloseLink(1, URL_1);
+// should not succeed either (for backward compatibility)
+sut.CloseLink(2, URL_1);
+CPPUNIT_ASSERT_EQUAL(1u, static_cast(sut.m_ClosedLinks.size()));
+CPPUNIT_ASSERT_EQUAL(1u, 
static_cast(sut.m_ClosedLinks.at(0)->mEndTextPos));
+CPPUNIT_ASSERT_MESSAGE("no links are open", sut.m_pStartedLink == nullptr);
 }
 
 void
-ToxLinkProcessorTest::StandardOpenLinkIsAddedWhenMoreLinksThanAvaiableAreClosed()
-{
-ToxLinkProcessor sut;
-sut.StartNewLink(0, STYLE_NAME_1);
-sut.CloseLink(1, URL_1);
-sut.CloseLink(1, URL_1);
-CPPUNIT_ASSERT_EQUAL(2u, static_cast(sut.m_ClosedLinks.size()));
-CPPUNIT_ASSERT_EQUAL(1u, 
static_cast(sut.m_ClosedLinks.at(1)->mEndTextPos));
-}
-
-void
-ToxLinkProcessorTest::AddingAndClosingTwoLinksResultsInTwoClosedLinks()
+ToxLinkProcessorTest::AddingAndClosingTwoOverlappingLinksResultsInOneClosedLink()
 {
 ToxLinkProcessor sut;
 sut.StartNewLink(0, STYLE_NAME_1);
 sut.StartNewLink(0, STYLE_NAME_2);
 sut.CloseLink(1, URL_1);
+// this should not cause an error, and should not succeed either
+// (for backward compatibility)
 sut.CloseLink(1, URL_2);
-CPPUNIT_ASSERT_EQUAL(2u, static_cast(sut.m_ClosedLinks.size()));
-CPPUNIT_ASSERT_MESSAGE("no links are open", sut.m_StartedLinks.empty());
+CPPUNIT_ASSERT_EQUAL(1u, static_cast(sut.m_ClosedLinks.size()));
+CPPUNIT_ASSERT_MESSAGE("no links are open", sut.m_pStartedLink == nullptr);
+// backward compatibility: the last start is closed by the first end
+CPPUNIT_ASSERT_EQUAL(STYLE_NAME_2, 
sut.m_ClosedLinks[0]->mINetFormat.GetINetFormat());
+CPPUNIT_ASSERT_EQUAL(URL_1,

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sw/inc sw/qa sw/source

2017-01-25 Thread Michael Stahl

 sw/inc/ToxLinkProcessor.hxx |2 -
 sw/qa/core/test_ToxLinkProcessor.cxx|   38 ++--
 sw/source/core/tox/ToxLinkProcessor.cxx |   18 +++
 3 files changed, 27 insertions(+), 31 deletions(-)

New commits:
commit 15c0e82005254e9da0fcd905379e9eca85571bf9
Author: Michael Stahl 
Date:   Wed Jan 25 17:12:42 2017 +0100

sw: revert ToX hyperlinks to LO 4.3 behaviour

Commit 94b296d5416dd71d721ad16216b50bce79e3dc04 changed this to
potentially insert multiple overlapping hyperlink items.

Unfortunately Writer can only have one RES_TXTATR_INETFMT on any given
position in the paragraph, so the hyperlink hints inevitably overwrite
each other.

Revert this to do it the same way as the old code in LO 4.3 did: match
the last unmatched link-start with the first link-end, and ignore all
the link-start before the matching one, as well as the link-end after
the matching one.

This should prevent surprising formatting changes on index update,
including entries spontaneously turning green, and there is no reason
why the result of the new way is objectively better than the old one.

Change-Id: I55be9c212c473908428fa8bd6487d136343fe852
(cherry picked from commit 68f7be01a78a5bad56ddd94c04764131676d6cc0)
Reviewed-on: https://gerrit.libreoffice.org/33550
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/sw/inc/ToxLinkProcessor.hxx b/sw/inc/ToxLinkProcessor.hxx
index 7fceef1..78bb7fb 100644
--- a/sw/inc/ToxLinkProcessor.hxx
+++ b/sw/inc/ToxLinkProcessor.hxx
@@ -82,7 +82,7 @@ private:
 
 std::vector m_ClosedLinks;
 
-std::vector m_StartedLinks;
+std::unique_ptr m_pStartedLink;
 
 friend class ::ToxLinkProcessorTest;
 };
diff --git a/sw/qa/core/test_ToxLinkProcessor.cxx 
b/sw/qa/core/test_ToxLinkProcessor.cxx
index eb4618e..d2d4721 100644
--- a/sw/qa/core/test_ToxLinkProcessor.cxx
+++ b/sw/qa/core/test_ToxLinkProcessor.cxx
@@ -30,17 +30,15 @@ using namespace sw;
 class ToxLinkProcessorTest : public test::BootstrapFixture
 {
 void NoExceptionIsThrownIfTooManyLinksAreClosed();
-void AddingAndClosingTwoLinksResultsInTwoClosedLinks();
+void AddingAndClosingTwoOverlappingLinksResultsInOneClosedLink();
 void LinkIsCreatedCorrectly();
 void LinkSequenceIsPreserved();
-void StandardOpenLinkIsAddedWhenMoreLinksThanAvaiableAreClosed();
 
 CPPUNIT_TEST_SUITE(ToxLinkProcessorTest);
 CPPUNIT_TEST(NoExceptionIsThrownIfTooManyLinksAreClosed);
-CPPUNIT_TEST(AddingAndClosingTwoLinksResultsInTwoClosedLinks);
+CPPUNIT_TEST(AddingAndClosingTwoOverlappingLinksResultsInOneClosedLink);
 CPPUNIT_TEST(LinkIsCreatedCorrectly);
 CPPUNIT_TEST(LinkSequenceIsPreserved);
-CPPUNIT_TEST(StandardOpenLinkIsAddedWhenMoreLinksThanAvaiableAreClosed);
 CPPUNIT_TEST_SUITE_END();
 public:
 void setUp() override {
@@ -71,30 +69,28 @@ 
ToxLinkProcessorTest::NoExceptionIsThrownIfTooManyLinksAreClosed()
 sut.CloseLink(1, URL_1);
 // fdo#85872 actually it turns out the UI does something like this
 // so an exception must not be thrown!
-sut.CloseLink(1, URL_1);
+// should not succeed either (for backward compatibility)
+sut.CloseLink(2, URL_1);
+CPPUNIT_ASSERT_EQUAL(1u, static_cast(sut.m_ClosedLinks.size()));
+CPPUNIT_ASSERT_EQUAL(1u, 
static_cast(sut.m_ClosedLinks.at(0)->mEndTextPos));
+CPPUNIT_ASSERT_MESSAGE("no links are open", sut.m_pStartedLink == nullptr);
 }
 
 void
-ToxLinkProcessorTest::StandardOpenLinkIsAddedWhenMoreLinksThanAvaiableAreClosed()
-{
-ToxLinkProcessor sut;
-sut.StartNewLink(0, STYLE_NAME_1);
-sut.CloseLink(1, URL_1);
-sut.CloseLink(1, URL_1);
-CPPUNIT_ASSERT_EQUAL(2u, static_cast(sut.m_ClosedLinks.size()));
-CPPUNIT_ASSERT_EQUAL(1u, 
static_cast(sut.m_ClosedLinks.at(1)->mEndTextPos));
-}
-
-void
-ToxLinkProcessorTest::AddingAndClosingTwoLinksResultsInTwoClosedLinks()
+ToxLinkProcessorTest::AddingAndClosingTwoOverlappingLinksResultsInOneClosedLink()
 {
 ToxLinkProcessor sut;
 sut.StartNewLink(0, STYLE_NAME_1);
 sut.StartNewLink(0, STYLE_NAME_2);
 sut.CloseLink(1, URL_1);
+// this should not cause an error, and should not succeed either
+// (for backward compatibility)
 sut.CloseLink(1, URL_2);
-CPPUNIT_ASSERT_EQUAL(2u, static_cast(sut.m_ClosedLinks.size()));
-CPPUNIT_ASSERT_MESSAGE("no links are open", sut.m_StartedLinks.empty());
+CPPUNIT_ASSERT_EQUAL(1u, static_cast(sut.m_ClosedLinks.size()));
+CPPUNIT_ASSERT_MESSAGE("no links are open", sut.m_pStartedLink == nullptr);
+// backward compatibility: the last start is closed by the first end
+CPPUNIT_ASSERT_EQUAL(STYLE_NAME_2, 
sut.m_ClosedLinks[0]->mINetFormat.GetINetFormat());
+CPPUNIT_ASSERT_EQUAL(URL_1,

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sw/inc sw/qa

2017-01-25 Thread Michael Stahl

 sw/inc/ToxLinkProcessor.hxx  |7 +--
 sw/qa/core/test_ToxLinkProcessor.cxx |2 +-
 2 files changed, 6 insertions(+), 3 deletions(-)

New commits:
commit ca512d0323c261d90559ddf6df561300cb048173
Author: Michael Stahl 
Date:   Wed Jan 25 16:42:16 2017 +0100

sw: stop swapping start and end position of links in ToX

This causes:

sw/source/core/txtnode/thints.cxx:3198: +SwpHints::Insert: invalid hint, 
end < start

Change-Id: I933c790127ab1469bb57c4d288dbb49be16ace19
(cherry picked from commit 4a43ffcef946067c5b3992a00c765a36804a194f)
Reviewed-on: https://gerrit.libreoffice.org/33549
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/sw/inc/ToxLinkProcessor.hxx b/sw/inc/ToxLinkProcessor.hxx
index 699c0ec..7fceef1 100644
--- a/sw/inc/ToxLinkProcessor.hxx
+++ b/sw/inc/ToxLinkProcessor.hxx
@@ -69,8 +69,11 @@ private:
  * A link is closed if it has both a start and an end token.
  */
 struct ClosedLink {
-ClosedLink(const OUString& url, sal_Int32 startPosition, sal_Int32 
endPosition) :
-mINetFormat(url, OUString()), mStartTextPos(endPosition), 
mEndTextPos(startPosition) {
+ClosedLink(const OUString& url, sal_Int32 startPosition, sal_Int32 
endPosition)
+: mINetFormat(url, OUString())
+, mStartTextPos(startPosition)
+, mEndTextPos(endPosition)
+{
 }
 SwFormatINetFormat mINetFormat;
 sal_Int32 mStartTextPos;
diff --git a/sw/qa/core/test_ToxLinkProcessor.cxx 
b/sw/qa/core/test_ToxLinkProcessor.cxx
index 0a15982..eb4618e 100644
--- a/sw/qa/core/test_ToxLinkProcessor.cxx
+++ b/sw/qa/core/test_ToxLinkProcessor.cxx
@@ -82,7 +82,7 @@ 
ToxLinkProcessorTest::StandardOpenLinkIsAddedWhenMoreLinksThanAvaiableAreClosed(
 sut.CloseLink(1, URL_1);
 sut.CloseLink(1, URL_1);
 CPPUNIT_ASSERT_EQUAL(2u, static_cast(sut.m_ClosedLinks.size()));
-CPPUNIT_ASSERT_EQUAL(0u, 
static_cast(sut.m_ClosedLinks.at(1)->mEndTextPos));
+CPPUNIT_ASSERT_EQUAL(1u, 
static_cast(sut.m_ClosedLinks.at(1)->mEndTextPos));
 }
 
 void
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

1 2 3 4 >

1 - 100 of 330 matches

Mail list logo