[Libreoffice-bugs] [Bug 106072] Assertion failed in o3tl/ typed_flags_set.hxx during PDF export
https://bugs.documentfoundation.org/show_bug.cgi?id=106072 Julien Nabetchanged: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- On pc Debian x86-64 with master sources updated yesterday + enable-dbgutil, I don't reproduce this. (gtk3 or gen rendering) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106037] Libreoffice crash when LAN connected. Simple single PC installation, without Samba, without network drives.
https://bugs.documentfoundation.org/show_bug.cgi?id=106037 Julien Nabetchanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Julien Nabet --- Let's put this one to WFM. Matthew: don't hesitate to reopen this tracker if you still reproduce the problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81234] [META] RTF filter issues
https://bugs.documentfoundation.org/show_bug.cgi?id=81234 Aron Budeachanged: What|Removed |Added Depends on||106070 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106070 [Bug 106070] RTF IO open file error -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106070] RTF IO open file error
https://bugs.documentfoundation.org/show_bug.cgi?id=106070 Aron Budeachanged: What|Removed |Added Keywords|bibisectRequest |notBibisectable Version|4.1 all versions|3.5.0 release Blocks||81234 --- Comment #3 from Aron Budea --- There's an error in 3.5.0.3, but not in 3.4.0.1, adjusting earliest version. Also an error in earliest commit of 43max repo, setting keyword notBibisectable. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=81234 [Bug 81234] [META] RTF filter issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106072] New: Assertion failed in o3tl/ typed_flags_set.hxx during PDF export
https://bugs.documentfoundation.org/show_bug.cgi?id=106072 Bug ID: 106072 Summary: Assertion failed in o3tl/typed_flags_set.hxx during PDF export Product: LibreOffice Version: 5.4.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Printing and PDF export Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu Requires debug build. - Start an empty document - File -> Export as PDF... - Make no changes, click Export, choose a file name, click Save => Asserion failed. http://opengrok.libreoffice.org/xref/core/include/o3tl/typed_flags_set.hxx#83 Expression: static_cast::type>(~0) == M || (value & ~M) == 0 For some reason I can't get a useful backtrace with my Windows debug builds. My build is from 2017-02-05, so it might be fixed by now. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105537] [META] Assertion failed crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=105537 Aron Budeachanged: What|Removed |Added Depends on||106072 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106072 [Bug 106072] Assertion failed in o3tl/typed_flags_set.hxx during PDF export -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106072] Assertion failed in o3tl/ typed_flags_set.hxx during PDF export
https://bugs.documentfoundation.org/show_bug.cgi?id=106072 Aron Budeachanged: What|Removed |Added Blocks||105537 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105537 [Bug 105537] [META] Assertion failed crashes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105856] XAdES signature created via LibreOffice is not compliant ( SignedProperties reference is missing Type attribute).
https://bugs.documentfoundation.org/show_bug.cgi?id=105856 Aron Budeachanged: What|Removed |Added Blocks||105605 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105605 [Bug 105605] [META] Digital signatures bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105605 Aron Budeachanged: What|Removed |Added Depends on||105856 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105856 [Bug 105856] XAdES signature created via LibreOffice is not compliant (SignedProperties reference is missing Type attribute). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105605 Aron Budeachanged: What|Removed |Added Depends on||105983 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105983 [Bug 105983] Supporting ECDSA (NIST P-256 curve) signatures created by Hungarian citizen eID card -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105983] Supporting ECDSA (NIST P-256 curve) signatures created by Hungarian citizen eID card
https://bugs.documentfoundation.org/show_bug.cgi?id=105983 Aron Budeachanged: What|Removed |Added CC||ba...@caesar.elte.hu Blocks||105605 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105605 [Bug 105605] [META] Digital signatures bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106071] Customized ctrl-alt-shift-right shortcut doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=106071 V Stuart Footechanged: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- Created attachment 131309 --> https://bugs.documentfoundation.org/attachment.cgi?id=131309=edit shortcuts correctly assigned and functional Can not confirm on Windows 10 Pro 64-bit en-US with Version: 5.3.0.3 (x64) Build ID: 7074905676c47b82bbcfbea1aeefc84afe1c50e1 CPU Threads: 8; OS Version: Windows 6.19; UI Render: default; Layout Engine: new; Locale: en-US (en_US); Calc: group correctly setting the keyboard accelerators as below results in functional formatting. 1. Open Writer 2. Tools -> Customize -> Keyboard 3. select the LibreOffice radio button (so shortcut will apply to all modules) 4. navigate down the shortcut keys list to the Ctrl+Alt+Shift+Left/Right values 5. select Ctrl+Alt+Shift+Left 6. navigate the Functions -> Category to Format 7. navigate the Function list to "Decrement Indent Value" 8. click the Modify button to apply 9. verify that the Keys list shows Ctrl+Alt+Shift+Left when "Decrement Indent Value" is selected. 10. select the Ctrl+Alt+Shift+Right from Shortcut Keys list 11. repeat 6 - 9 but use the "Increment Indent Value" and verify. Test the Shortcuts in the open Writer session. They should apply the formatting to increase and decrease the indentation. If they show in the dialog but do not assert--then your OS/DE is interfering. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106058] EDITING: Make Calc understand currency
https://bugs.documentfoundation.org/show_bug.cgi?id=106058 --- Comment #10 from cheate...@gmail.com --- so that it explicitly does not understand money? Only integers and floating point numbers and strings? I think you would be wiser than to do such a thing. P.S. sorry about splitting this into two comments, the bugzilla interface is quite broken on mobile chrome. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 106058] EDITING: Make Calc understand currency
https://bugs.documentfoundation.org/show_bug.cgi?id=106058 --- Comment #10 from cheate...@gmail.com --- so that it explicitly does not understand money? Only integers and floating point numbers and strings? I think you would be wiser than to do such a thing. P.S. sorry about splitting this into two comments, the bugzilla interface is quite broken on mobile chrome. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 106058] EDITING: Make Calc understand currency
https://bugs.documentfoundation.org/show_bug.cgi?id=106058 --- Comment #9 from cheate...@gmail.com --- Stuart, thanks for your comment. I am well aware that what you described *is* standard operating procedure. However, I strongly believe that it is not the most desirable state of things. Basically we currently have a language with a few primitive data types. It is desirable to extend those to support newer types. As spreadsheets are almost always used to hold money it is difficult to understand why no data type special to mobey has been introduced. I can only imagine this stems from historical heritage, from times of DOS spread sheets where every byte came at a cost. But if you were to design a language or tool *today* to calculate money accounts and transactions, would you explicitly build it so that it -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 106058] EDITING: Make Calc understand currency
https://bugs.documentfoundation.org/show_bug.cgi?id=106058 --- Comment #9 from cheate...@gmail.com --- Stuart, thanks for your comment. I am well aware that what you described *is* standard operating procedure. However, I strongly believe that it is not the most desirable state of things. Basically we currently have a language with a few primitive data types. It is desirable to extend those to support newer types. As spreadsheets are almost always used to hold money it is difficult to understand why no data type special to mobey has been introduced. I can only imagine this stems from historical heritage, from times of DOS spread sheets where every byte came at a cost. But if you were to design a language or tool *today* to calculate money accounts and transactions, would you explicitly build it so that it -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106058] EDITING: Make Calc understand currency
https://bugs.documentfoundation.org/show_bug.cgi?id=106058 --- Comment #8 from V Stuart Foote--- (In reply to cheater00 from comment #7) > But this is exactly the kind of hack I'm trying to avoid. > For each row you have to manually enter the conversion rate or at least a > reference to it. Thatt's prone to error and takes a lot of time. Is there a > less crappy way of doing things? Sorry, not a "hack" as that *is* the "normal" way to build a spread sheet. Making the work flow robust is up to the you as the user--the needed tools are provided. We just can't overload the floating point numbers in cells to give them attributes of currency--so your spread sheet has to provide for that. You have to make each value a tuple(pair) of amount and currency (using either two cells, or within one alphanumeric cell with tagging) to then be able to apply the desired exchange rate and convert the value for sorting. Using additional sheets to hold the converted values in scratch columns and the retrieved exchange rates would reduce clutter on your main sheet. And of course capturing this to a template would reduce errors and allow reproducible results. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 106058] EDITING: Make Calc understand currency
https://bugs.documentfoundation.org/show_bug.cgi?id=106058 --- Comment #8 from V Stuart Foote--- (In reply to cheater00 from comment #7) > But this is exactly the kind of hack I'm trying to avoid. > For each row you have to manually enter the conversion rate or at least a > reference to it. Thatt's prone to error and takes a lot of time. Is there a > less crappy way of doing things? Sorry, not a "hack" as that *is* the "normal" way to build a spread sheet. Making the work flow robust is up to the you as the user--the needed tools are provided. We just can't overload the floating point numbers in cells to give them attributes of currency--so your spread sheet has to provide for that. You have to make each value a tuple(pair) of amount and currency (using either two cells, or within one alphanumeric cell with tagging) to then be able to apply the desired exchange rate and convert the value for sorting. Using additional sheets to hold the converted values in scratch columns and the retrieved exchange rates would reduce clutter on your main sheet. And of course capturing this to a template would reduce errors and allow reproducible results. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 91797] "Find & Replace" dialog doesnt open with shortcut in full screen mode
https://bugs.documentfoundation.org/show_bug.cgi?id=91797 --- Comment #7 from jason--- Confirmed for Debian... but I can't get any other menus either in fullscreen mode :) http://pastebin.com/dRdWuZxX -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: uitest/calc_tests uitest/demo_ui uitest/uitest
uitest/calc_tests/about_test.py|2 +- uitest/calc_tests/create_chart.py | 12 ++-- uitest/calc_tests/create_range_name.py |4 ++-- uitest/calc_tests/edit_chart.py|2 +- uitest/calc_tests/function_wizard.py |2 +- uitest/calc_tests/tdf105411.py |2 +- uitest/calc_tests/tdf105466.py |2 +- uitest/calc_tests/tdf96453.py |2 +- uitest/demo_ui/radiobutton.py |2 +- uitest/demo_ui/tabdialog.py|4 ++-- uitest/uitest/test.py |2 +- 11 files changed, 18 insertions(+), 18 deletions(-) New commits: commit 7ec0500e20cf273d70c4fbddb4063b8f8295307c Author: Markus MohrhardDate: Tue Feb 14 00:45:12 2017 +0100 use special method to close dialog through button click Change-Id: Id884cc75503cb433742f9316d9647cff801565f7 Reviewed-on: https://gerrit.libreoffice.org/34230 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/uitest/calc_tests/about_test.py b/uitest/calc_tests/about_test.py index 016c486..a5082ee 100644 --- a/uitest/calc_tests/about_test.py +++ b/uitest/calc_tests/about_test.py @@ -18,7 +18,7 @@ class AboutDlgTest(UITestCase): xAboutDlg = self.xUITest.getTopFocusWindow() xCloseBtn = xAboutDlg.getChild("close") -xCloseBtn.executeAction("CLICK", tuple()) +self.ui_test.close_dialog_through_button(xCloseBtn) self.ui_test.close_doc() diff --git a/uitest/calc_tests/create_chart.py b/uitest/calc_tests/create_chart.py index d98eeff..427b4ce 100644 --- a/uitest/calc_tests/create_chart.py +++ b/uitest/calc_tests/create_chart.py @@ -39,7 +39,7 @@ class CalcChartUIDemo(UITestCase): xChartDlg = self.xUITest.getTopFocusWindow() xCancelBtn = xChartDlg.getChild("cancel") -xCancelBtn.executeAction("CLICK", tuple()) +self.ui_test.close_dialog_through_button(xCancelBtn) self.ui_test.close_doc() @@ -54,7 +54,7 @@ class CalcChartUIDemo(UITestCase): xChartDlg = self.xUITest.getTopFocusWindow() xOkBtn = xChartDlg.getChild("finish") -xOkBtn.executeAction("CLICK", tuple()) +self.ui_test.close_dialog_through_button(xOkBtn) self.ui_test.close_doc() @@ -78,7 +78,7 @@ class CalcChartUIDemo(UITestCase): xDataInCols.executeAction("CLICK", tuple()) xCancelBtn = xChartDlg.getChild("finish") -xCancelBtn.executeAction("CLICK", tuple()) +self.ui_test.close_dialog_through_button(xCancelBtn) self.ui_test.close_doc() @@ -95,7 +95,7 @@ class CalcChartUIDemo(UITestCase): xChartDlg = self.xUITest.getTopFocusWindow() xNextBtn = xChartDlg.getChild("finish") -xNextBtn.executeAction("CLICK", tuple()) +self.ui_test.close_dialog_through_button(xNextBtn) xGridWindow.executeAction("DESELECT", mkPropertyValues({"OBJECT": ""})) @@ -118,7 +118,7 @@ class CalcChartUIDemo(UITestCase): xChartDlg = self.xUITest.getTopFocusWindow() xNextBtn = xChartDlg.getChild("finish") -xNextBtn.executeAction("CLICK", tuple()) +self.ui_test.close_dialog_through_button(xNextBtn) xGridWindow.executeAction("DESELECT", mkPropertyValues({"OBJECT": ""})) @@ -144,7 +144,7 @@ class CalcChartUIDemo(UITestCase): xChartDlg = self.xUITest.getTopFocusWindow() xNextBtn = xChartDlg.getChild("finish") -xNextBtn.executeAction("CLICK", tuple()) +self.ui_test.close_dialog_through_button(xNextBtn) xGridWindow.executeAction("DESELECT", mkPropertyValues({"OBJECT": ""})) diff --git a/uitest/calc_tests/create_range_name.py b/uitest/calc_tests/create_range_name.py index 1ab7805..1babca7 100644 --- a/uitest/calc_tests/create_range_name.py +++ b/uitest/calc_tests/create_range_name.py @@ -24,7 +24,7 @@ class CreateRangeNameTest(UITestCase): type_text(xEdit, "simpleRangeName") xAddBtn = xAddNameDlg.getChild("add") -xAddBtn.executeAction("CLICK", tuple()) +self.ui_test.close_dialog_through_button(xAddBtn) self.ui_test.close_doc() @@ -43,7 +43,7 @@ class CreateRangeNameTest(UITestCase): select_pos(xScope, "1") xAddBtn = xAddNameDlg.getChild("add") -xAddBtn.executeAction("CLICK", tuple()) +self.ui_test.close_dialog_through_button(xAddBtn) self.ui_test.close_doc() diff --git a/uitest/calc_tests/edit_chart.py b/uitest/calc_tests/edit_chart.py index a8aa36e..4d44d52 100644 --- a/uitest/calc_tests/edit_chart.py +++ b/uitest/calc_tests/edit_chart.py @@ -42,7 +42,7 @@ class CalcChartEditUIDemo(UITestCase): xChartDlg = self.xUITest.getTopFocusWindow() xNextBtn = xChartDlg.getChild("finish") -xNextBtn.executeAction("CLICK", tuple()) +self.ui_test.close_dialog_through_button(xNextBtn)
[Libreoffice-commits] core.git: uitest/demo_ui
uitest/demo_ui/char_dialog.py |2 +- uitest/demo_ui/checkbox.py|2 +- uitest/demo_ui/combobox.py|2 +- uitest/demo_ui/edit.py|2 +- uitest/demo_ui/hierarchy.py | 35 +++ uitest/demo_ui/listbox.py |4 ++-- uitest/demo_ui/spinfield.py |6 +++--- 7 files changed, 44 insertions(+), 9 deletions(-) New commits: commit 19d52e56a4581bb12bc271765feec7b8ab78c45b Author: Markus MohrhardDate: Sat Feb 18 03:32:41 2017 +0100 uitest: use the correct method to close a dialog through a button Change-Id: I210c1d9a99a93b7a21478f679f440c270375bedc Reviewed-on: https://gerrit.libreoffice.org/34398 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/uitest/demo_ui/char_dialog.py b/uitest/demo_ui/char_dialog.py index 4c77163..d2b1fb0 100644 --- a/uitest/demo_ui/char_dialog.py +++ b/uitest/demo_ui/char_dialog.py @@ -29,7 +29,7 @@ class CharDialogText(UITestCase): sleep(5) xCancelBtn = xCharDialog.getChild("cancel") -xCancelBtn.executeAction("CLICK", tuple()) +self.ui_test.close_dialog_through_button(xCancelBtn) self.ui_test.close_doc() diff --git a/uitest/demo_ui/checkbox.py b/uitest/demo_ui/checkbox.py index 2138cf6..114473d 100644 --- a/uitest/demo_ui/checkbox.py +++ b/uitest/demo_ui/checkbox.py @@ -21,7 +21,7 @@ class CheckBoxTest(UITestCase): xNegativeNumRedCB.executeAction("CLICK",tuple()) okBtn = xCellsDlg.getChild("ok") -okBtn.executeAction("CLICK", tuple()) +self.ui_test.close_dialog_through_button(okBtn) self.ui_test.close_doc() diff --git a/uitest/demo_ui/combobox.py b/uitest/demo_ui/combobox.py index 32e6402..8b47f83 100644 --- a/uitest/demo_ui/combobox.py +++ b/uitest/demo_ui/combobox.py @@ -23,7 +23,7 @@ class ComboBoxTest(UITestCase): select_pos(scopeCB, "1") xCancelBtn = xAddNameDlg.getChild("cancel") -xCancelBtn.executeAction("CLICK", tuple()) +self.ui_test.close_dialog_through_button(xCancelBtn) self.ui_test.close_doc() diff --git a/uitest/demo_ui/edit.py b/uitest/demo_ui/edit.py index 5eff4e0..135a724 100644 --- a/uitest/demo_ui/edit.py +++ b/uitest/demo_ui/edit.py @@ -24,7 +24,7 @@ class EditTest(UITestCase): type_text(xEdit, "simpleRangeName") xAddBtn = xAddNameDlg.getChild("cancel") -xAddBtn.executeAction("CLICK", tuple()) +self.ui_test.close_dialog_through_button(xAddBtn) self.ui_test.close_doc() diff --git a/uitest/demo_ui/hierarchy.py b/uitest/demo_ui/hierarchy.py new file mode 100644 index 000..5f7b3c2 --- /dev/null +++ b/uitest/demo_ui/hierarchy.py @@ -0,0 +1,35 @@ +# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*- +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# + +from libreoffice.uno.propertyvalue import mkPropertyValues + +from uitest.framework import UITestCase + +import json + +class CheckBoxTest(UITestCase): + +def test_get_json(self): + +self.ui_test.create_doc_in_start_center("calc") + +self.ui_test.execute_dialog_through_command(".uno:About") + +xAboutDlg = self.xUITest.getTopFocusWindow() + +json_string = xAboutDlg.getHierarchy() +print(json_string) +json_content = json.loads(json_string) +print(json_content) +print(json.dumps(json_content, indent=4)) + +closeBtn = xAboutDlg.getChild("close") +self.ui_test.close_dialog_through_button(closeBtn) + +self.ui_test.close_doc() + +# vim: set shiftwidth=4 softtabstop=4 expandtab: diff --git a/uitest/demo_ui/listbox.py b/uitest/demo_ui/listbox.py index 15bd8ab..780da1f 100644 --- a/uitest/demo_ui/listbox.py +++ b/uitest/demo_ui/listbox.py @@ -23,7 +23,7 @@ class ListBoxTest(UITestCase): select_pos(categoryLB, "4") xOkBtn = xCellsDlg.getChild("ok") -xOkBtn.executeAction("CLICK", tuple()) +self.ui_test.close_dialog_through_button(xOkBtn) self.ui_test.close_doc() @@ -41,7 +41,7 @@ class ListBoxTest(UITestCase): categoryLB.executeAction("SELECT", actionProps) xOkBtn = xCellsDlg.getChild("ok") -xOkBtn.executeAction("CLICK", tuple()) +self.ui_test.close_dialog_through_button(xOkBtn) self.ui_test.close_doc() diff --git a/uitest/demo_ui/spinfield.py b/uitest/demo_ui/spinfield.py index a36189a..3f73006 100644 --- a/uitest/demo_ui/spinfield.py +++ b/uitest/demo_ui/spinfield.py @@ -29,7 +29,7 @@ class SpinFieldTest(UITestCase): assert(decimal_places_state["Text"] == "2") okBtn = xCellsDlg.getChild("ok") -okBtn.executeAction("CLICK", tuple()) +
Re: [libreoffice-projects] Infra call on Tue, Feb 21 at 17:30 UTC
On Fri, 17 Feb 2017 at 17:38:12 +0100, Heiko Tietze wrote: > Jitsi still lacks on screen sharing capabilities, which is a must for > the design team. Maybe you add this to your agenda. AFAICT there is no technical blocker and nothing to discus either, it's just that I had quite a few things on my plate since FOSDEM and didn't come back to it yet. It's it in my personal TODO, but I don't think it warrants an entry in the infra call agenda :-P -- Guilhem. signature.asc Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 94598] Tables in Word document collapsed
https://bugs.documentfoundation.org/show_bug.cgi?id=94598 Bartoszchanged: What|Removed |Added Attachment #120935|0 |1 is obsolete|| Attachment #126984|0 |1 is obsolete|| --- Comment #10 from Bartosz --- Created attachment 131308 --> https://bugs.documentfoundation.org/attachment.cgi?id=131308=edit Minimal file created with Word 2010 on which issue is reproducible -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sc/source
sc/source/core/data/dpoutput.cxx | 112 +++ 1 file changed, 68 insertions(+), 44 deletions(-) New commits: commit cbba64225a2abfdd8b2437e8a06925b15fb15d26 Author: Eike RathkeDate: Fri Feb 17 14:10:37 2017 +0100 Resolves: tdf#105858 check SC_DPOUT_MAXLEVELS to prevent crash Backported. This is a combination of 2 commits. Resolves: tdf#105858 check nDataCounthttps://gerrit.libreoffice.org/34370 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/sc/source/core/data/dpoutput.cxx b/sc/source/core/data/dpoutput.cxx index d62739e..09b005c 100644 --- a/sc/source/core/data/dpoutput.cxx +++ b/sc/source/core/data/dpoutput.cxx @@ -343,9 +343,10 @@ void lcl_FillNumberFormats( sal_uInt32*& rFormats, long& rCount, OUString aDataNames[SC_DPOUT_MAXLEVELS]; sal_uInt32 nDataFormats[SC_DPOUT_MAXLEVELS]; -long nDataCount = 0; -long nDimCount = xDims->getCount(); -for (long nDim=0; nDim getCount(); +sal_Int32 nDim = 0; +for ( ; nDim < nDimCount && nDataCount < SC_DPOUT_MAXLEVELS; nDim++) { uno::Reference xDim = ScUnoHelpFunctions::AnyToInterface( xDims->getByIndex(nDim) ); @@ -368,6 +369,8 @@ void lcl_FillNumberFormats( sal_uInt32*& rFormats, long& rCount, } } } +SAL_WARN_IF( nDim < nDimCount && nDataCount == SC_DPOUT_MAXLEVELS, "sc.core", +"lcl_FillNumberFormats - may have lost an output level due to SC_DPOUT_MAXLEVELS=" << SC_DPOUT_MAXLEVELS); if (!nDataCount) return; @@ -393,7 +396,7 @@ void lcl_FillNumberFormats( sal_uInt32*& rFormats, long& rCount, aName = pArray[nPos].Name; sal_uInt32 nFormat = 0; -for (long i=0; i getResults(); + pColFields[nColFieldCount].mnSrcNumFmt = nNumFmt; +pColFields[nColFieldCount].maName = aName; + pColFields[nColFieldCount].maCaption= aCaption; + pColFields[nColFieldCount].mbHasHiddenMember = bHasHiddenMember; + pColFields[nColFieldCount].mbDataLayout = bIsDataLayout; +if (!lcl_MemberEmpty(pColFields[nColFieldCount].aResult)) +++nColFieldCount; +} +else +{ +SAL_WARN("sc.core","ScDPOutput - nColFieldCount already at SC_DPOUT_MAXLEVELS=" << SC_DPOUT_MAXLEVELS); +} +break; case sheet::DataPilotFieldOrientation_ROW: -pRowFields[nRowFieldCount].nDim= nDim; -pRowFields[nRowFieldCount].nHier = nHierarchy; -pRowFields[nRowFieldCount].nLevel = nLev; -pRowFields[nRowFieldCount].nDimPos =
[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sc/source
sc/source/core/data/dpoutput.cxx | 118 +++ 1 file changed, 71 insertions(+), 47 deletions(-) New commits: commit e38914af31b0150a383cc556e634da48eceb1dbc Author: Eike RathkeDate: Fri Feb 17 14:10:37 2017 +0100 Resolves: tdf#105858 check SC_DPOUT_MAXLEVELS to prevent crash This is a combination of 2 commits. Resolves: tdf#105858 check nDataCounthttps://gerrit.libreoffice.org/34369 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/sc/source/core/data/dpoutput.cxx b/sc/source/core/data/dpoutput.cxx index 031aa12..6f1faf8 100644 --- a/sc/source/core/data/dpoutput.cxx +++ b/sc/source/core/data/dpoutput.cxx @@ -344,9 +344,10 @@ void lcl_FillNumberFormats( sal_uInt32*& rFormats, long& rCount, OUString aDataNames[SC_DPOUT_MAXLEVELS]; sal_uInt32 nDataFormats[SC_DPOUT_MAXLEVELS]; -long nDataCount = 0; -long nDimCount = xDims->getCount(); -for (long nDim=0; nDim getCount(); +sal_Int32 nDim = 0; +for ( ; nDim < nDimCount && nDataCount < SC_DPOUT_MAXLEVELS; nDim++) { uno::Reference xDim = ScUnoHelpFunctions::AnyToInterface( xDims->getByIndex(nDim) ); @@ -369,6 +370,8 @@ void lcl_FillNumberFormats( sal_uInt32*& rFormats, long& rCount, } } } +SAL_WARN_IF( nDim < nDimCount && nDataCount == SC_DPOUT_MAXLEVELS, "sc.core", +"lcl_FillNumberFormats - may have lost an output level due to SC_DPOUT_MAXLEVELS=" << SC_DPOUT_MAXLEVELS); if (!nDataCount) return; @@ -394,7 +397,7 @@ void lcl_FillNumberFormats( sal_uInt32*& rFormats, long& rCount, aName = pArray[nPos].Name; sal_uInt32 nFormat = 0; -for (long i=0; i getResults(); + pColFields[nColFieldCount].mnSrcNumFmt = nNumFmt; +pColFields[nColFieldCount].maName = aName; + pColFields[nColFieldCount].maCaption= aCaption; +pColFields[nColFieldCount].mfValue = fValue; + pColFields[nColFieldCount].mbHasHiddenMember = bHasHiddenMember; + pColFields[nColFieldCount].mbDataLayout = bIsDataLayout; +if (!lcl_MemberEmpty(pColFields[nColFieldCount].aResult)) +++nColFieldCount; +} +else +{ +SAL_WARN("sc.core","ScDPOutput - nColFieldCount already at SC_DPOUT_MAXLEVELS=" << SC_DPOUT_MAXLEVELS); +} +break; case sheet::DataPilotFieldOrientation_ROW: -pRowFields[nRowFieldCount].nDim= nDim; -pRowFields[nRowFieldCount].nHier = nHierarchy; -
[Libreoffice-bugs] [Bug 105114] Conditional formatting dialog closes while editing any condition 2nd time
https://bugs.documentfoundation.org/show_bug.cgi?id=105114 Markus Mohrhardchanged: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |markus.mohrhard@googlemail. |desktop.org |com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105542] First condition is not a good way to identify conditions in Manage Conditional Formatting (MCF)
https://bugs.documentfoundation.org/show_bug.cgi?id=105542 Markus Mohrhardchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from Markus Mohrhard --- There is not a better solution. Just use the range to identify the format. The shown condition is just a helpful addition. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87351] [META] Conditional formatting bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=87351 Bug 87351 depends on bug 105542, which changed state. Bug 105542 Summary: First condition is not a good way to identify conditions in Manage Conditional Formatting(MCF) https://bugs.documentfoundation.org/show_bug.cgi?id=105542 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105486] horizontal conditional formatting in xlsb file not visible
https://bugs.documentfoundation.org/show_bug.cgi?id=105486 Markus Mohrhardchanged: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |markus.mohrhard@googlemail. |desktop.org |com --- Comment #4 from Markus Mohrhard --- Simple fix. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/clientnb.cpp
net/clientnb.cpp | 11 +++ 1 file changed, 11 insertions(+) New commits: commit 6ac450cb2322cfb4550553e4ccb1fb5a7d0f2bbb Author: Michael MeeksDate: Sat Feb 18 02:09:43 2017 + SSL - accept self-signed certificates for tests. diff --git a/net/clientnb.cpp b/net/clientnb.cpp index 275938d..40ddc2f 100644 --- a/net/clientnb.cpp +++ b/net/clientnb.cpp @@ -212,6 +212,17 @@ public: EnableHttps = (args.size() > 0 && args[0] == "ssl"); std::cerr << "Starting " << (EnableHttps ? "HTTPS" : "HTTP") << " client." << std::endl; +if (EnableHttps) +{ +Poco::Net::initializeSSL(); +// Just accept the certificate anyway for testing purposes +Poco::SharedPtr invalidCertHandler = new Poco::Net::AcceptCertificateHandler(false); + +Poco::Net::Context::Params sslParams; +Poco::Net::Context::Ptr sslContext = new Poco::Net::Context(Poco::Net::Context::CLIENT_USE, sslParams); +Poco::Net::SSLManager::instance().initializeClient(nullptr, invalidCertHandler, sslContext); +} + testWebsocket(); testPing(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/socket.hpp
net/socket.hpp | 10 ++ 1 file changed, 10 insertions(+) New commits: commit 7832654282a648291813f1d82ca40b34405bdbed Author: Michael MeeksDate: Sat Feb 18 02:05:07 2017 + Socket - set nodelay. diff --git a/net/socket.hpp b/net/socket.hpp index fbc9003..3f43793 100644 --- a/net/socket.hpp +++ b/net/socket.hpp @@ -29,6 +29,7 @@ public: Socket() : _fd(socket(AF_INET, SOCK_STREAM | SOCK_NONBLOCK, 0)) { +setNoDelay(); } virtual ~Socket() @@ -50,6 +51,14 @@ public: virtual HandleResult handlePoll( int events ) = 0; +/// manage latency issues around packet aggregation +void setNoDelay(bool noDelay = true) +{ +int val = noDelay ? 1 : 0; +setsockopt (_fd, IPPROTO_TCP, TCP_NODELAY, +(char *) , sizeof(val)); +} + /// Sets the send buffer in size bytes. /// Must be called before accept or connect. /// Note: TCP will allocate twice this size for admin purposes, @@ -123,6 +132,7 @@ protected: Socket(const int fd) : _fd(fd) { +setNoDelay(); } private: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - 3 commits - net/clientnb.cpp net/loolnb.cpp net/socket.hpp
net/clientnb.cpp | 45 ++--- net/loolnb.cpp |2 - net/socket.hpp | 59 +-- 3 files changed, 82 insertions(+), 24 deletions(-) New commits: commit 4289058cbe741919cd492eb5fcbf28b87bb32dcb Author: Ashod NakashianDate: Fri Feb 17 20:41:27 2017 -0500 nb: enable HTTPS in server Change-Id: Ib0a4cb29f239bafe477ffab4194d3c91a588c384 diff --git a/net/loolnb.cpp b/net/loolnb.cpp index b91e4d2..2a0b6d1 100644 --- a/net/loolnb.cpp +++ b/net/loolnb.cpp @@ -415,7 +415,7 @@ int main(int, const char**) }); // Start the server. -server (addrHttp, poller); +server (addrSsl, poller); std::cout << "Shutting down server." << std::endl; commit 049d43c3fe3ff02385d9aaace76577d738153af3 Author: Ashod Nakashian Date: Fri Feb 17 20:41:09 2017 -0500 nb: support ssl handshake Change-Id: I9974b1228cdc35a22ee784b734811720ddd2a311 diff --git a/net/socket.hpp b/net/socket.hpp index 95d4991..fbc9003 100644 --- a/net/socket.hpp +++ b/net/socket.hpp @@ -388,6 +388,27 @@ class SslStreamSocket : public BufferingSocket public: bool readIncomingData() override { +if (_doHandshake) +{ +int rc; +do +{ +rc = SSL_do_handshake(_ssl); +} +while (rc < 0 && errno == EINTR); + +if (rc <= 0) +{ +rc = handleSslState(rc); +if (rc <= 0) +{ +return (rc != 0); +} +} + +_doHandshake = false; +} + ssize_t len; char buf[4096]; do @@ -397,7 +418,6 @@ public: while (len < 0 && errno == EINTR); len = handleSslState(len); - if (len > 0) { // We have more data, let the application consume it, if possible. @@ -414,6 +434,28 @@ public: { // Should never call SSL_write with 0 length data. assert (_outBuffer.size() > 0); + +if (_doHandshake) +{ +int rc; +do +{ +rc = SSL_do_handshake(_ssl); +} +while (rc < 0 && errno == EINTR); + +if (rc <= 0) +{ +rc = handleSslState(rc); +if (rc <= 0) +{ +return; +} +} + +_doHandshake = false; +} + ssize_t len; do { @@ -422,7 +464,6 @@ public: while (len < 0 && errno == EINTR); len = handleSslState(len); - if (len > 0) { // We've sent some data, remove from the buffer. @@ -453,7 +494,8 @@ protected: SslStreamSocket(const int fd) : BufferingSocket(fd), _ssl(nullptr), -_sslWantsTo(SslWantsTo::ReadOrWrite) +_sslWantsTo(SslWantsTo::ReadOrWrite), +_doHandshake(true) { BIO* bio = BIO_new(BIO_s_socket()); if (bio == nullptr) @@ -533,8 +575,8 @@ private: default: { // The error is comming from BIO. Find out what happened. -const long lastError = ERR_get_error(); -if (lastError == 0) +const long bioError = ERR_get_error(); +if (bioError == 0) { if (rc == 0) { @@ -553,7 +595,7 @@ private: else { char buf[512]; -ERR_error_string_n(lastError, buf, sizeof(buf)); +ERR_error_string_n(bioError, buf, sizeof(buf)); throw std::runtime_error(buf); } } @@ -565,7 +607,12 @@ private: private: SSL* _ssl; +/// During handshake SSL might want to read +/// on write, or write on read. SslWantsTo _sslWantsTo; +/// We must do the handshake during the first +/// read or write in non-blocking. +bool _doHandshake; }; /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ commit 095623915a8b62101d8127e125c93cc8e0eaecc2 Author: Ashod Nakashian Date: Fri Feb 17 20:40:17 2017 -0500 nb: support ssl in all client tests Change-Id: Ie077212426a07817914abe796c1280ef2afe89be diff --git a/net/clientnb.cpp b/net/clientnb.cpp index 2dc7950..275938d 100644 --- a/net/clientnb.cpp +++ b/net/clientnb.cpp @@ -53,6 +53,8 @@ const char *HostName = "127.0.0.1"; constexpr int HttpPortNumber = 9191; constexpr int SslPortNumber = 9193; +static bool EnableHttps = false; + struct Session { std::string _session_name; @@ -132,7 +134,7 @@ struct ThreadWorker : public Runnable { for (int i = 0; i < 100; ++i)
[Libreoffice-bugs] [Bug 106071] New: Customized ctrl-alt-shift-right shortcut doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=106071 Bug ID: 106071 Summary: Customized ctrl-alt-shift-right shortcut doesn't work Product: LibreOffice Version: 5.2.5.1 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j...@curioussymbols.com Using the 'customize' dialog, I set the ctrl-alt-shift-right keystroke to increase indent, and ctrl-alt-shift-left to decrease indent. Despite showing up clearly in the shortcut list, these shortcuts have no effect when I type them. My system is Ubuntu 16.04 LTS (with the Unity graphical shell) This issue that makes this especially irritating is that recent changes to the menu structure in LibreOffice have taken away the old 'alt sequences', eg Alt O N etc, so there is currently no alternative keyboard sequence that I can use. This issue is MAJOR because the broken keyboard functionality has painful implications for RSI sufferers seeking to minimise mouse usage. Perhaps what is happening here is that the operating system is somehow 'capturing' the keystroke event. I tested with 'xev' however and xev is able to catch ctrl-alt-shift-right no problems. Perhaps the customize dialog should use actual keystrokes instead of looking them up from a list. That way you would be simultaneously testing whether LO catches the relevant keystroke, and not just assuming that it can. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106058] EDITING: Make Calc understand currency
https://bugs.documentfoundation.org/show_bug.cgi?id=106058 --- Comment #7 from cheate...@gmail.com --- (In reply to V Stuart Foote from comment #5) > (In reply to cheater00 from comment #4) > > Could this functionality (eg points 2 and 4) be executed using a plug-in > > IIUC if you can do it manually now in the GUI it can be coded with the APIs > provided in the SDK, and then packaged as an .oxt extension. Thanks for the links guys. How would you perform currency-aware sort on a column using the gui? I don't see a way. You could add a column that converts everything to a single currency and then sort by that. But this is exactly the kind of hack I'm trying to avoid. For each row you have to manually enter the conversion rate or at least a reference to it. Thatt's prone to error and takes a lot of time. Is there a less crappy way of doing things? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 106058] EDITING: Make Calc understand currency
https://bugs.documentfoundation.org/show_bug.cgi?id=106058 --- Comment #7 from cheate...@gmail.com --- (In reply to V Stuart Foote from comment #5) > (In reply to cheater00 from comment #4) > > Could this functionality (eg points 2 and 4) be executed using a plug-in > > IIUC if you can do it manually now in the GUI it can be coded with the APIs > provided in the SDK, and then packaged as an .oxt extension. Thanks for the links guys. How would you perform currency-aware sort on a column using the gui? I don't see a way. You could add a column that converts everything to a single currency and then sort by that. But this is exactly the kind of hack I'm trying to avoid. For each row you have to manually enter the conversion rate or at least a reference to it. Thatt's prone to error and takes a lot of time. Is there a less crappy way of doing things? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/clientnb.cpp net/loolnb.cpp
net/clientnb.cpp | 35 ++ net/loolnb.cpp | 56 --- 2 files changed, 56 insertions(+), 35 deletions(-) New commits: commit 84be891579089b29070c1506531aec004d69414e Author: Michael MeeksDate: Sat Feb 18 00:58:49 2017 + WS: cleanup calculation, masking, short reads and other bits. diff --git a/net/clientnb.cpp b/net/clientnb.cpp index 96fdc80..2dc7950 100644 --- a/net/clientnb.cpp +++ b/net/clientnb.cpp @@ -167,6 +167,11 @@ struct Client : public Poco::Util::Application { Session session("ws"); std::shared_ptr ws = session.getWebSocket(); + +std::string send = "hello there"; +ws->sendFrame([0], send.length(), + WebSocket::SendFlags::FRAME_TEXT); + for (size_t i = 0; i < 10; i++) { ws->sendFrame(, sizeof(i), WebSocket::SendFlags::FRAME_BINARY); @@ -184,26 +189,24 @@ public: const bool https = (args.size() > 0 && args[0] == "ssl"); std::cerr << "Starting " << (https ? "HTTPS" : "HTTP") << " client." << std::endl; -if (getenv("WS")) -testWebsocket(); -else -{ -Session first("init", https); -Session second("init", https); +testWebsocket(); -int count = 42, back; -first.sendPing(count); -second.sendPing(count + 1); +Session first("init"); +Session second("init"); -back = first.getResponse(); -assert (back == count + 1); +int count = 42, back; +first.sendPing(count); +second.sendPing(count + 1); -back = second.getResponse(); -assert (back == count + 2); +back = first.getResponse(); +assert (back == count + 1); + +back = second.getResponse(); +assert (back == count + 2); + +testLadder(); +testParallel(); -testLadder(); -testParallel(); -} return 0; } }; diff --git a/net/loolnb.cpp b/net/loolnb.cpp index 2b5773c..b91e4d2 100644 --- a/net/loolnb.cpp +++ b/net/loolnb.cpp @@ -137,50 +137,59 @@ public: // websocket fun ! size_t len = T::_inBuffer.size(); char *p = ::_inBuffer[0]; -char *data, *mask; if (len < 2) // partial read return; -bool fin = *p & 0x80; -WSOpCode code = static_cast(*p & 0x0f); -p++; -bool hasMask = *p & 0x80; -size_t payloadLen = *p & 0x7f; -p++; +bool fin = p[0] & 0x80; +WSOpCode code = static_cast(p[0] & 0x0f); +bool hasMask = p[1] & 0x80; +size_t payloadLen = p[1] & 0x7f; +size_t headerLen = 2; +// normally - 7 bit length. if (payloadLen == 126) // 2 byte length { if (len < 2 + 2) return; std::cerr << "Implement me 2 byte\n"; -data = p + 2; -len -= 2; +headerLen += 2; } else if (payloadLen == 127) // 8 byte length { if (len < 2 + 8) return; std::cerr << "Implement me 8 byte\n"; -data = p + 8; -len -= 8; +// FIXME: crop read length to remove top / sign bits. +headerLen += 8; } -else + +char *data, *mask; + +if (hasMask) { -data = p; +mask = p + headerLen; +headerLen += 4; +} + +if (payloadLen + headerLen > len) +{ // partial read wait for more data. +return; } +data = p + headerLen; + if (hasMask) { -mask = data; -data += 4; -len -= 4; for (size_t i = 0; i < len; ++i) data[i] = data[i] ^ mask[i % 4]; // FIXME: copy and un-mask at the same time ... -_wsPayload.insert(_wsPayload.end(), data, data + std::min(payloadLen, len)); +_wsPayload.insert(_wsPayload.end(), data, data + payloadLen); } else -_wsPayload.insert(_wsPayload.end(), data, data + std::min(payloadLen, len)); +_wsPayload.insert(_wsPayload.end(), data, data + payloadLen); + +T::_inBuffer.erase(T::_inBuffer.begin(), T::_inBuffer.begin() + headerLen + payloadLen); + // FIXME: fin, aggregating payloads into _wsPayload etc. handleWSMessage(fin, code, _wsPayload); _wsPayload.clear(); @@ -225,7 +234,16 @@ public: virtual void handleWSMessage( bool fin, WSOpCode code, std::vector ) { -std::cerr << "Message: fin? " << fin << " code " << code << " data size " << data.size() << "\n"; +std::cerr << "Message: fin? " << fin << " code " << code << " data size " << data.size(); +if (code ==
[Libreoffice-bugs] [Bug 104855] Chinese characters clipped within vertical column when OpenGL is enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=104855 Volgachanged: What|Removed |Added Blocks||106045 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106045 [Bug 106045] [META] Bugs and enhancements related to vertical text direction -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105012] Tangut glyph orientation failed with OpenGL disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=105012 Volgachanged: What|Removed |Added Blocks||106045 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106045 [Bug 106045] [META] Bugs and enhancements related to vertical text direction -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105178] Latin text shifts to the left in vertical mode for certain fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=105178 Volgachanged: What|Removed |Added Blocks||106045 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106045 [Bug 106045] [META] Bugs and enhancements related to vertical text direction -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104874] First Tangut character per vertical texts clipped when OpenGL is enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=104874 Volgachanged: What|Removed |Added Blocks||106045 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106045 [Bug 106045] [META] Bugs and enhancements related to vertical text direction -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105650] Wrong text alignment with strikethrough within vertical writing
https://bugs.documentfoundation.org/show_bug.cgi?id=105650 Volgachanged: What|Removed |Added Blocks||106045 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106045 [Bug 106045] [META] Bugs and enhancements related to vertical text direction -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104854] Mongolian ellipsis and CJK brackets are clipped within vertical layout when OpenGL enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=104854 Volgachanged: What|Removed |Added Blocks||106045 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106045 [Bug 106045] [META] Bugs and enhancements related to vertical text direction -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106045] [META] Bugs and enhancements related to vertical text direction
https://bugs.documentfoundation.org/show_bug.cgi?id=106045 Volgachanged: What|Removed |Added Depends on||104854, 104874, 104855, ||105012, 105178, 105650, ||103969 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103969 [Bug 103969] Wrong glyph orientation for CJK Punctuations within vertical Mongolian https://bugs.documentfoundation.org/show_bug.cgi?id=104854 [Bug 104854] Mongolian ellipsis and CJK brackets are clipped within vertical layout when OpenGL enabled https://bugs.documentfoundation.org/show_bug.cgi?id=104855 [Bug 104855] Chinese characters clipped within vertical column when OpenGL is enabled https://bugs.documentfoundation.org/show_bug.cgi?id=104874 [Bug 104874] First Tangut character per vertical texts clipped when OpenGL is enabled https://bugs.documentfoundation.org/show_bug.cgi?id=105012 [Bug 105012] Tangut glyph orientation failed with OpenGL disabled https://bugs.documentfoundation.org/show_bug.cgi?id=105178 [Bug 105178] Latin text shifts to the left in vertical mode for certain fonts https://bugs.documentfoundation.org/show_bug.cgi?id=105650 [Bug 105650] Wrong text alignment with strikethrough within vertical writing -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106070] RTF IO open file error
https://bugs.documentfoundation.org/show_bug.cgi?id=106070 Xisco Faulíchanged: What|Removed |Added Priority|medium |high Status|UNCONFIRMED |NEW Version|5.2.5.1 release |4.1 all versions Keywords||bibisectRequest, regression CC||vmik...@collabora.co.uk, ||xiscofa...@libreoffice.org Ever confirmed|0 |1 Severity|normal |major OS|Windows (All) |All --- Comment #2 from Xisco Faulí --- - Version: 5.4.0.0.alpha0+ Build ID: 880033edde516fc30225005245253293a6a58ba4 CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group - Version: 5.0.0.0.alpha1+ Build ID: 0db96caf0fcce09b87621c11b584a6d81cc7df86 Locale: ca-ES (ca_ES.UTF-8) - Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a) but not in LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 @Miklos, one for you? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/socket.hpp
net/socket.hpp | 154 - 1 file changed, 141 insertions(+), 13 deletions(-) New commits: commit a3b6ef4a76aeb5daf4cbca3f25ca0983020bdca6 Author: Ashod NakashianDate: Fri Feb 17 19:05:53 2017 -0500 nb: basic SSL socket implementation Change-Id: Iaa2da47df17f14dfded44a8cf805020e8ef6b1ff Reviewed-on: https://gerrit.libreoffice.org/34395 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/net/socket.hpp b/net/socket.hpp index 69d2710..95d4991 100644 --- a/net/socket.hpp +++ b/net/socket.hpp @@ -339,11 +339,6 @@ protected: class StreamSocket : public BufferingSocket { public: -StreamSocket() : -BufferingSocket() -{ -} - bool readIncomingData() override { ssize_t len; @@ -391,26 +386,74 @@ protected: class SslStreamSocket : public BufferingSocket { public: -SslStreamSocket() : -BufferingSocket() +bool readIncomingData() override { +ssize_t len; +char buf[4096]; +do +{ +len = SSL_read(_ssl, buf, sizeof(buf)); +} +while (len < 0 && errno == EINTR); + +len = handleSslState(len); + +if (len > 0) +{ +// We have more data, let the application consume it, if possible. +assert (len < ssize_t(sizeof(buf))); +_inBuffer.insert(_inBuffer.end(), [0], [len]); +handleIncomingMessage(); +} +// else poll will handle errors. + +return len != 0; // zero is eof / clean socket close. } -bool readIncomingData() override +void writeOutgoingData() override { -//TODO: -return true; +// Should never call SSL_write with 0 length data. +assert (_outBuffer.size() > 0); +ssize_t len; +do +{ +len = SSL_write(_ssl, &_outBuffer[0], _outBuffer.size()); +} +while (len < 0 && errno == EINTR); + +len = handleSslState(len); + +if (len > 0) +{ +// We've sent some data, remove from the buffer. +_outBuffer.erase(_outBuffer.begin(), + _outBuffer.begin() + len); +} +// else poll will handle errors } -void writeOutgoingData() override +int getPollEvents() override { -//TODO; +if (_sslWantsTo == SslWantsTo::Read) +{ +// Must read next before attempting to write. +return POLLIN; +} +else if (_sslWantsTo == SslWantsTo::Write) +{ +// Must write next before attempting to read. +return POLLOUT; +} + +// Do whatever makes sense based on buffer state. +return (_outBuffer.empty() ? POLLIN : (POLLIN | POLLOUT)); } protected: SslStreamSocket(const int fd) : BufferingSocket(fd), -_ssl(nullptr) +_ssl(nullptr), +_sslWantsTo(SslWantsTo::ReadOrWrite) { BIO* bio = BIO_new(BIO_s_socket()); if (bio == nullptr) @@ -437,7 +480,92 @@ protected: template friend class ServerSocket; private: + +/// The possible next I/O operation that SSL want to do. +enum class SslWantsTo +{ +ReadOrWrite, +Read, +Write +}; + +/// Handles the state of SSL after read or write. +int handleSslState(const int rc) +{ +if (rc > 0) +{ +// Success: Reset so we can do either. +_sslWantsTo = SslWantsTo::ReadOrWrite; +return rc; +} + +// Last operation failed. Find out if SSL was trying +// to do something different that failed, or not. +const int sslError = SSL_get_error(_ssl, rc); +switch (sslError) +{ +case SSL_ERROR_ZERO_RETURN: +// Shutdown complete, we're disconnected. +return 0; + +case SSL_ERROR_WANT_READ: +_sslWantsTo = SslWantsTo::Read; +return rc; + +case SSL_ERROR_WANT_WRITE: +_sslWantsTo = SslWantsTo::Write; +return rc; + +case SSL_ERROR_WANT_CONNECT: +case SSL_ERROR_WANT_ACCEPT: +case SSL_ERROR_WANT_X509_LOOKUP: +// Unexpected. +return rc; + +case SSL_ERROR_SYSCALL: +if (errno != 0) +{ +// Posix API error, let the caller handle. +return rc; +} + +// fallthrough +default: +{ +// The error is comming from BIO. Find out what happened. +const long lastError = ERR_get_error(); +if (lastError == 0) +{ +if (rc == 0) +{ +// Socket closed. +return 0; +
[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/clientnb.cpp net/socket.hpp
net/clientnb.cpp | 16 ++-- net/socket.hpp |2 +- 2 files changed, 11 insertions(+), 7 deletions(-) New commits: commit 88b3c174ef800d435550495e44952d285f4e9f49 Author: Ashod NakashianDate: Fri Feb 17 18:55:10 2017 -0500 nb: support SSL in clientnb Change-Id: Ia895558c7115a39824474ba7acff060102192c10 Reviewed-on: https://gerrit.libreoffice.org/34394 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/net/clientnb.cpp b/net/clientnb.cpp index 2ab1980..96fdc80 100644 --- a/net/clientnb.cpp +++ b/net/clientnb.cpp @@ -50,7 +50,8 @@ using Poco::Util::Option; using Poco::Util::OptionSet; const char *HostName = "127.0.0.1"; -constexpr int PortNumber = 9191; +constexpr int HttpPortNumber = 9191; +constexpr int SslPortNumber = 9193; struct Session { @@ -61,9 +62,9 @@ struct Session : _session_name(session_name) { if (https) -_session = new Poco::Net::HTTPSClientSession(HostName, PortNumber); +_session = new Poco::Net::HTTPSClientSession(HostName, SslPortNumber); else -_session = new Poco::Net::HTTPClientSession(HostName, PortNumber); +_session = new Poco::Net::HTTPClientSession(HostName, HttpPortNumber); } ~Session() { @@ -178,14 +179,17 @@ struct Client : public Poco::Util::Application } public: -int main(const std::vector& /* args */) override +int main(const std::vector& args) override { +const bool https = (args.size() > 0 && args[0] == "ssl"); +std::cerr << "Starting " << (https ? "HTTPS" : "HTTP") << " client." << std::endl; + if (getenv("WS")) testWebsocket(); else { -Session first("init"); -Session second("init"); +Session first("init", https); +Session second("init", https); int count = 42, back; first.sendPing(count); diff --git a/net/socket.hpp b/net/socket.hpp index fae37a2..69d2710 100644 --- a/net/socket.hpp +++ b/net/socket.hpp @@ -184,7 +184,7 @@ public: if (_pollSockets[i]->handlePoll(_pollFds[i].revents) == Socket::HandleResult::SOCKET_CLOSED) { -std::cout << "Removing: " << _pollFds[i].fd << std::endl; +std::cout << "Removing client #" << _pollFds[i].fd << std::endl; _pollSockets.erase(_pollSockets.begin() + i); // Don't remove from pollFds; we'll recreate below. } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/loolnb.cpp
net/loolnb.cpp | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) New commits: commit 151dca0303c4fa31a9e1312a09693935bd28fe48 Author: Ashod NakashianDate: Fri Feb 17 18:36:43 2017 -0500 nb: SimpleResponseClient can now be an SSL or plain socket Depending on the base class, which is passed as template parameter, SimpleResponseClient can abstract away the underlying socket type. Change-Id: I59a403357512f329aa2565c1ef55094704e3b4ad Reviewed-on: https://gerrit.libreoffice.org/34393 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/net/loolnb.cpp b/net/loolnb.cpp index 9fb6dc0..2b5773c 100644 --- a/net/loolnb.cpp +++ b/net/loolnb.cpp @@ -36,7 +36,8 @@ constexpr int SslPortNumber = 9193; static std::string computeAccept(const std::string ); -class SimpleResponseClient : public StreamSocket +template +class SimpleResponseClient : public T { int _wsVersion; std::string _wsKey; @@ -46,7 +47,7 @@ class SimpleResponseClient : public StreamSocket public: SimpleResponseClient(const int fd) : -StreamSocket(fd), +T(fd), _wsVersion(0), _wsState(HTTP) { @@ -54,15 +55,15 @@ public: virtual void handleHTTP() { int number = 0; -MemoryInputStream message(&_inBuffer[0], _inBuffer.size()); +MemoryInputStream message(::_inBuffer[0], T::_inBuffer.size()); Poco::Net::HTTPRequest req; req.read(message); // if we succeeded - remove that from our input buffer -size_t consumed = std::min(_inBuffer.size(), +size_t consumed = std::min(T::_inBuffer.size(), std::max((size_t)message.tellg(), size_t(0))); -_inBuffer.erase(_inBuffer.begin(), _inBuffer.begin() + consumed); -std::cerr << "_inBuffer has " << _inBuffer.size() << " remaining\n"; +T::_inBuffer.erase(T::_inBuffer.begin(), T::_inBuffer.begin() + consumed); +std::cerr << "inBuffer has " << T::_inBuffer.size() << " remaining\n"; StringTokenizer tokens(req.getURI(), "/?"); if (tokens.count() == 4) @@ -85,7 +86,7 @@ public: << numberString; ; std::string str = oss.str(); -_outBuffer.insert(_outBuffer.end(), str.begin(), str.end()); +T::_outBuffer.insert(T::_outBuffer.end(), str.begin(), str.end()); } else if (tokens.count() == 2 && tokens[1] == "ws") { // create our websocket goodness ... @@ -102,7 +103,7 @@ public: << "Sec-Websocket-Accept: " << computeAccept(_wsKey) << "\r\n" << "\r\n"; std::string str = oss.str(); -_outBuffer.insert(_outBuffer.end(), str.begin(), str.end()); +T::_outBuffer.insert(T::_outBuffer.end(), str.begin(), str.end()); _wsState = WEBSOCKET; } else @@ -126,7 +127,7 @@ public: virtual void handleIncomingMessage() override { -std::cerr << "incoming message with buffer size " << _inBuffer.size() << "\n"; +std::cerr << "incoming message with buffer size " << T::_inBuffer.size() << "\n"; if (_wsState == HTTP) { handleHTTP(); @@ -134,8 +135,8 @@ public: } // websocket fun ! -size_t len = _inBuffer.size(); -char *p = &_inBuffer[0]; +size_t len = T::_inBuffer.size(); +char *p = ::_inBuffer[0]; char *data, *mask; if (len < 2) // partial read return; @@ -195,31 +196,31 @@ public: unsigned char header[2]; header[0] = (fin ? 0x80 : 0) | static_cast(code); header[1] = mask ? 0x80 : 0; -_outBuffer.push_back((char)header[0]); +T::_outBuffer.push_back((char)header[0]); // no out-bound masking ... if (len < 126) { header[1] |= len; -_outBuffer.push_back((char)header[1]); +T::_outBuffer.push_back((char)header[1]); } else if (len <= 0x) { header[1] |= 126; -_outBuffer.push_back((char)header[1]); +T::_outBuffer.push_back((char)header[1]); std::cerr << "FIXME: length\n"; } else { header[1] |= 127; -_outBuffer.push_back((char)header[1]); +T::_outBuffer.push_back((char)header[1]); std::cerr << "FIXME: length\n"; } // FIXME: pick random number and mask in the outbuffer etc. assert (!mask); -_outBuffer.insert(_outBuffer.end(), data.begin(), data.end()); +T::_outBuffer.insert(T::_outBuffer.end(), data.begin(), data.end()); } virtual void handleWSMessage( bool fin, WSOpCode code, std::vector ) @@ -396,7 +397,7 @@ int
[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/loolnb.cpp net/socket.hpp
net/loolnb.cpp | 12 +++- net/socket.hpp |6 -- 2 files changed, 11 insertions(+), 7 deletions(-) New commits: commit d15a3d3945ee8fbab0381644de1be5857ca6f9c0 Author: Ashod NakashianDate: Fri Feb 17 18:17:16 2017 -0500 nb: server can create any socket type on accept Change-Id: I1a786421628500844277e6a2f1d2fd7b0ac0c3e4 Reviewed-on: https://gerrit.libreoffice.org/34392 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/net/loolnb.cpp b/net/loolnb.cpp index d819a1c..9fb6dc0 100644 --- a/net/loolnb.cpp +++ b/net/loolnb.cpp @@ -280,6 +280,8 @@ Poco::Net::SocketAddress addrHttp("127.0.0.1", HttpPortNumber); Poco::Net::SocketAddress addrSsl("127.0.0.1", SslPortNumber); /// A non-blocking, streaming socket. +/// T is the socket type created by accept. +template class ServerSocket : public Socket { SocketPoll& _clientPoller; @@ -317,8 +319,7 @@ public: /// Accepts an incoming connection (Servers only). /// Does not retry on error. /// Returns a valid Socket shared_ptr on success only. -template - std::shared_ptr accept() +std::shared_ptr accept() { // Accept a connection (if any) and set it to non-blocking. // We don't care about the client's address, so ignored. @@ -333,7 +334,7 @@ public: HandleResult handlePoll( int /* events */ ) override { -std::shared_ptr clientSocket = accept(); +std::shared_ptr clientSocket = accept(); if (!clientSocket) { const std::string msg = "Failed to accept. (errno: "; @@ -347,10 +348,11 @@ public: } }; +template void server(const Poco::Net::SocketAddress& addr, SocketPoll& clientPoller) { // Start server. -auto server = std::make_shared(clientPoller); +auto server = std::make_shared (clientPoller); if (!server->bind(addr)) { const std::string msg = "Failed to bind. (errno: "; @@ -394,7 +396,7 @@ int main(int, const char**) }); // Start the server. -server(addrHttp, poller); +server(addrHttp, poller); std::cout << "Shutting down server." << std::endl; diff --git a/net/socket.hpp b/net/socket.hpp index 8982380..fae37a2 100644 --- a/net/socket.hpp +++ b/net/socket.hpp @@ -383,7 +383,8 @@ protected: { } -friend class ServerSocket; +// Will construct us upon accept. +template friend class ServerSocket; }; /// A SSL/TSL, non-blocking, data streaming socket. @@ -432,7 +433,8 @@ protected: SSL_set_accept_state(_ssl); } -friend class ServerSocket; +// Will construct us upon accept. +template friend class ServerSocket; private: SSL* _ssl; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/loolnb.cpp
net/loolnb.cpp | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) New commits: commit db352c5a0bf56c2bd14e8034bca1dc3415d43462 Author: Ashod NakashianDate: Fri Feb 17 18:13:52 2017 -0500 nb: support http and https in parallel Change-Id: I35f55abc853e8797625bef1b0f60eeda127681b4 Reviewed-on: https://gerrit.libreoffice.org/34391 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/net/loolnb.cpp b/net/loolnb.cpp index a235ba7..d819a1c 100644 --- a/net/loolnb.cpp +++ b/net/loolnb.cpp @@ -31,7 +31,8 @@ using Poco::StringTokenizer; #include "ssl.hpp" #include "socket.hpp" -constexpr int PortNumber = 9191; +constexpr int HttpPortNumber = 9191; +constexpr int SslPortNumber = 9193; static std::string computeAccept(const std::string ); @@ -275,7 +276,8 @@ private: std::thread _thread; }; -Poco::Net::SocketAddress addr("127.0.0.1", PortNumber); +Poco::Net::SocketAddress addrHttp("127.0.0.1", HttpPortNumber); +Poco::Net::SocketAddress addrSsl("127.0.0.1", SslPortNumber); /// A non-blocking, streaming socket. class ServerSocket : public Socket @@ -345,7 +347,7 @@ public: } }; -void server(SocketPoll& clientPoller) +void server(const Poco::Net::SocketAddress& addr, SocketPoll& clientPoller) { // Start server. auto server = std::make_shared(clientPoller); @@ -392,7 +394,7 @@ int main(int, const char**) }); // Start the server. -server(poller); +server(addrHttp, poller); std::cout << "Shutting down server." << std::endl; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/ssl.cpp
net/ssl.cpp |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit b0cf7e5d58cbb105bf9fad36d5262e7db0ccd6e8 Author: Ashod NakashianDate: Fri Feb 17 18:09:55 2017 -0500 nb: Enable partial writes and no retry Change-Id: I75567754b81cc43190087bae4f848a0742201fe0 Reviewed-on: https://gerrit.libreoffice.org/34390 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/net/ssl.cpp b/net/ssl.cpp index 1d56f6a..a1f23a1 100644 --- a/net/ssl.cpp +++ b/net/ssl.cpp @@ -94,7 +94,7 @@ SslContext::SslContext(const std::string& certFilePath, SSL_CTX_set_verify(_ctx, SSL_VERIFY_NONE, nullptr /**/); SSL_CTX_set_cipher_list(_ctx, "ALL:!ADH:!LOW:!EXP:!MD5:@STRENGTH"); SSL_CTX_set_verify_depth(_ctx, 9); -SSL_CTX_set_mode(_ctx, SSL_MODE_AUTO_RETRY); +SSL_CTX_set_mode(_ctx, SSL_MODE_ENABLE_PARTIAL_WRITE); SSL_CTX_set_session_cache_mode(_ctx, SSL_SESS_CACHE_OFF); initDH(); @@ -103,6 +103,7 @@ SslContext::SslContext(const std::string& certFilePath, catch (...) { SSL_CTX_free(_ctx); +_ctx = nullptr; throw; } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/socket.hpp
net/socket.hpp | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) New commits: commit 9707cf5e54dbacf32264f9702811e3ec62364681 Author: Ashod NakashianDate: Fri Feb 17 13:01:48 2017 -0500 nb: create SSL socket Change-Id: I2d5cc3441bcdb67b868557fefe93e2d0bd7770af Reviewed-on: https://gerrit.libreoffice.org/34389 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/net/socket.hpp b/net/socket.hpp index 5332456..8982380 100644 --- a/net/socket.hpp +++ b/net/socket.hpp @@ -20,6 +20,8 @@ #include +#include "ssl.hpp" + /// A non-blocking, streaming socket. class Socket { @@ -406,11 +408,34 @@ public: protected: SslStreamSocket(const int fd) : -BufferingSocket(fd) +BufferingSocket(fd), +_ssl(nullptr) { +BIO* bio = BIO_new(BIO_s_socket()); +if (bio == nullptr) +{ +throw std::runtime_error("Failed to create SSL BIO."); +} + +BIO_set_fd(bio, fd, BIO_NOCLOSE); + +_ssl = SslContext::newSsl(); +if (!_ssl) +{ +BIO_free(bio); +throw std::runtime_error("Failed to create SSL."); +} + +SSL_set_bio(_ssl, bio, bio); + +// We are a server-side socket. +SSL_set_accept_state(_ssl); } friend class ServerSocket; + +private: +SSL* _ssl; }; /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/socket.hpp
net/socket.hpp | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) New commits: commit 34454d04c981c28303475edf26d65086fc6a297b Author: Ashod NakashianDate: Fri Feb 17 12:52:48 2017 -0500 nb: no redundant visibility Change-Id: I8ad303f534ca8c953e4bf42d252c38fb2561f505 Reviewed-on: https://gerrit.libreoffice.org/34388 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/net/socket.hpp b/net/socket.hpp index 0f8345a..5332456 100644 --- a/net/socket.hpp +++ b/net/socket.hpp @@ -287,11 +287,6 @@ public: { } - protected: -std::vector< char > _inBuffer; -std::vector< char > _outBuffer; - public: - HandleResult handlePoll( int events ) override { bool closeSocket = false; @@ -333,6 +328,9 @@ protected: Socket(fd) { } + +std::vector< char > _inBuffer; +std::vector< char > _outBuffer; }; /// A plain, non-blocking, data streaming socket. @@ -344,8 +342,6 @@ public: { } - public: - bool readIncomingData() override { ssize_t len; @@ -397,8 +393,6 @@ public: { } - public: - bool readIncomingData() override { //TODO: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/loolnb.cpp
net/loolnb.cpp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ca9592e54b9fdd5bbc925fbdc408958a2a62282f Author: Ashod NakashianDate: Fri Feb 17 12:46:53 2017 -0500 nb: use make_shared where possible Change-Id: I7fb4e7086ac0ce86447db9de4c7ac77cdd7b40af Reviewed-on: https://gerrit.libreoffice.org/34387 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/net/loolnb.cpp b/net/loolnb.cpp index 17909cb..a235ba7 100644 --- a/net/loolnb.cpp +++ b/net/loolnb.cpp @@ -321,7 +321,7 @@ public: // Accept a connection (if any) and set it to non-blocking. // We don't care about the client's address, so ignored. const int rc = ::accept4(getFD(), nullptr, nullptr, SOCK_NONBLOCK); -return std::shared_ptr(rc != -1 ? new T(rc) : nullptr); +return (rc != -1 ? std::make_shared(rc) : std::shared_ptr(nullptr)); } int getPollEvents() override ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 105971] FILEOPEN DOC Image anchored To Character is positioned incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=105971 --- Comment #7 from David Chambers--- Thanks for your testing and input. I question why MS Word can cope and not Writer. There may well be an error to document creation or image positioning, however Word does seem to cope. The document is one of a series of newsletters produced by a lady. All readers with MS word see no problems, but Libre Writer readers see this signature image problem. I do not understand your AS character statement, I need to understand so that I can recommend to the document creator a practice of image placing that is stable and compatible with Writer. thank you in anticipation -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81397] FORMATTING: When Default cell style is modified, new sheets do not show correct row height
https://bugs.documentfoundation.org/show_bug.cgi?id=81397 m.a.riosvchanged: What|Removed |Added Priority|lowest |medium CC||miguelangelrv@libreoffice.o ||rg Severity|normal |major --- Comment #10 from m.a.riosv --- Still there Version: 5.3.0.3 (x64) Build ID: 7074905676c47b82bbcfbea1aeefc84afe1c50e1 CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; Layout Engine: new; Locale: es-ES (es_ES); Calc: group Save and reopen doesn't solve the issue. Only selecting the whole sheet and Menu/Format/Rows - Optimal height. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [libreoffice-projects] Infra call on Tue, Feb 21 at 17:30 UTC
Hi Heiko, On Friday, 2017-02-17 20:59:03 +0100, Heiko Tietze wrote: > > [...] https://github.com/jitsi/jidesha > Reported the issue to Guilhelm. I usually run Jitsi in Chromium without any > problem on meet.jit.si. When i connect to our vm184 I get a permission denied > with "Failed to install desktop sharing extension". The same browser, nothing > changed. Sounds like https://github.com/jitsi/jitsi-meet/issues/192 What I gist of that, to connect against own servers the extension needs to be rebuilt and published in the Chrome store (whatever *that* may imply..) and the server's Jitsi meet configuration have the Chrome ID added. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/ Care about Free Software, support the FSFE https://fsfe.org/support/?erack signature.asc Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 106042] Calc does not use all the default template formatting when creating new sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=106042 m.a.riosvchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||miguelangelrv@libreoffice.o ||rg Resolution|--- |NOTABUG --- Comment #1 from m.a.riosv --- Create a new sheet always have default options for columns and rows. For 1)2)5) you can modify the default style, for save with your template. But there is a simple way to duplicate a sheet, dragging the sheet tab with [Ctrl] key pressed. Everything on the sheet will be duplicated, not only formats. Resolved as not a bug, please if you are not agree, reopen it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [Libreoffice-qa] minutes of ESC call ...
Hi, On Thursday, 2017-02-16 15:43:18 +, Michael Meeks wrote: > + Most Pressing Bugs: http://tdf.io/mostressingbugs > + Older: > + Crash in: `anonymous > namespace'::ScCaptionCreator::UpdateCaptionPos() > + > https://bugs.documentfoundation.org/show_bug.cgi?id=105667 > + has been bisected, would love Eike to take a look at it > (?) Fixed and gerrit reviews pending for 5-3, 5-2 and 5-2-6 Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/ Care about Free Software, support the FSFE https://fsfe.org/support/?erack signature.asc Description: PGP signature ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: minutes of ESC call ...
Hi, On Thursday, 2017-02-16 15:43:18 +, Michael Meeks wrote: > + Most Pressing Bugs: http://tdf.io/mostressingbugs > + Older: > + Crash in: `anonymous > namespace'::ScCaptionCreator::UpdateCaptionPos() > + > https://bugs.documentfoundation.org/show_bug.cgi?id=105667 > + has been bisected, would love Eike to take a look at it > (?) Fixed and gerrit reviews pending for 5-3, 5-2 and 5-2-6 Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/ Care about Free Software, support the FSFE https://fsfe.org/support/?erack signature.asc Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: chart2/qa
chart2/qa/extras/chart2dump/chart2dump.cxx | 34 + 1 file changed, 16 insertions(+), 18 deletions(-) New commits: commit 5bb5a9dacb84ec14f7148a5a5d9ba38b7e9f1039 Author: Tamás ZolnaiDate: Sat Feb 18 00:08:09 2017 +0100 ChartDumpTest: Build fix Change-Id: I2271cb393ad5268d1c579fb2f9c5e1e73a42c8f3 diff --git a/chart2/qa/extras/chart2dump/chart2dump.cxx b/chart2/qa/extras/chart2dump/chart2dump.cxx index 1cffe81..6847fb0 100755 --- a/chart2/qa/extras/chart2dump/chart2dump.cxx +++ b/chart2/qa/extras/chart2dump/chart2dump.cxx @@ -25,7 +25,11 @@ #include +#if defined(X86) +#define INT_EPS 2.1 +#else #define INT_EPS 0.1 +#endif #define DECLARE_DUMP_TEST(TestName, BaseClass, DumpMode) \ class TestName : public BaseClass { \ @@ -639,10 +643,9 @@ DECLARE_DUMP_TEST(AxisGeometryTest, Chart2DumpTest, false) } } -#if !defined(MACOSX) - DECLARE_DUMP_TEST(AxisLabelTest, Chart2DumpTest, false) { +const double fLocalEPS = 150.1; const std::vector aTestFiles = { "default_formated_axis.odp", @@ -698,18 +701,18 @@ DECLARE_DUMP_TEST(AxisLabelTest, Chart2DumpTest, false) // Check size and position uno::Reference xLabelShape(xLabel, uno::UNO_QUERY); awt::Point aLabelPosition = xLabelShape->getPosition(); -CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aLabelPosition.X, INT_EPS); -CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aLabelPosition.Y, INT_EPS); +CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aLabelPosition.X, std::max(fLocalEPS, INT_EPS)); +CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aLabelPosition.Y, std::max(fLocalEPS, INT_EPS)); awt::Size aLabelSize = xLabelShape->getSize(); -CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aLabelSize.Height, INT_EPS); -CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aLabelSize.Width, INT_EPS); +CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aLabelSize.Height, std::max(fLocalEPS, INT_EPS)); +CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aLabelSize.Width, std::max(fLocalEPS, INT_EPS)); // Check transformation Reference< beans::XPropertySet > xPropSet(xLabelShape, UNO_QUERY_THROW); CPPUNIT_ASSERT(xPropSet.is()); drawing::HomogenMatrix3 aLabelTransformation; xPropSet->getPropertyValue("Transformation") >>= aLabelTransformation; - CPPUNIT_DUMP_ASSERT_TRANSFORMATIONS_EQUAL(aLabelTransformation, INT_EPS); + CPPUNIT_DUMP_ASSERT_TRANSFORMATIONS_EQUAL(aLabelTransformation, std::max(fLocalEPS, INT_EPS)); // Check font color and height util::Color aLabelFontColor = 0; @@ -723,8 +726,6 @@ DECLARE_DUMP_TEST(AxisLabelTest, Chart2DumpTest, false) } } -#endif - DECLARE_DUMP_TEST(ColumnBarChartTest, Chart2DumpTest, false) { const std::vector aTestFiles = @@ -800,10 +801,9 @@ DECLARE_DUMP_TEST(ColumnBarChartTest, Chart2DumpTest, false) } } -#if !defined(MACOSX) - DECLARE_DUMP_TEST(ChartWallTest, Chart2DumpTest, false) { +const double fLocalEPS = 400.1; const std::vector aTestFiles = { "chartwall_auto_adjust_with_titles.ods", @@ -827,18 +827,18 @@ DECLARE_DUMP_TEST(ChartWallTest, Chart2DumpTest, false) // Check position and size awt::Point aChartWallPosition = xChartWall->getPosition(); -CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aChartWallPosition.X, INT_EPS); -CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aChartWallPosition.Y, INT_EPS); +CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aChartWallPosition.X, std::max(fLocalEPS, INT_EPS)); +CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aChartWallPosition.Y, std::max(fLocalEPS, INT_EPS)); awt::Size aChartWallSize = xChartWall->getSize(); -CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aChartWallSize.Height, INT_EPS); -CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aChartWallSize.Width, INT_EPS); +CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aChartWallSize.Height, std::max(fLocalEPS, INT_EPS)); +CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aChartWallSize.Width, std::max(fLocalEPS, INT_EPS)); // Check transformation Reference< beans::XPropertySet > xPropSet(xChartWall, UNO_QUERY_THROW); CPPUNIT_ASSERT(xPropSet.is()); drawing::HomogenMatrix3 aChartWallTransformation; xPropSet->getPropertyValue("Transformation") >>= aChartWallTransformation; -CPPUNIT_DUMP_ASSERT_TRANSFORMATIONS_EQUAL(aChartWallTransformation, INT_EPS); +CPPUNIT_DUMP_ASSERT_TRANSFORMATIONS_EQUAL(aChartWallTransformation, std::max(fLocalEPS, INT_EPS)); // Check fill properties drawing::FillStyle aChartWallFillStyle; @@ -868,8 +868,6 @@ DECLARE_DUMP_TEST(ChartWallTest, Chart2DumpTest, false) } } -#endif - DECLARE_DUMP_TEST(PieChartTest, Chart2DumpTest, false) {
[Libreoffice-bugs] [Bug 106046] FILEOPEN NOT update value functions in format .XLS save
https://bugs.documentfoundation.org/show_bug.cgi?id=106046 m.a.riosvchanged: What|Removed |Added Status|NEW |RESOLVED CC||miguelangelrv@libreoffice.o ||rg Resolution|--- |NOTABUG --- Comment #1 from m.a.riosv --- Thanks for reporting but please don't set up as new yourself, a confirmation is needed. Wildcard have been implemented on calc, so now when an excel file is open, the use of wildcard instead regular expressions is selected. Menu/Tools/Options/LibreOffice calc/calculate Resolved as not a bug, please if you are not agree reopen it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/undo/undoblk3.cxx |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) New commits: commit a627c44026fcf883918f84bddd1c3b745e1f898c Author: Eike RathkeDate: Fri Feb 17 23:54:21 2017 +0100 Resolves: tdf#105667 forget target area's caption pointer in Merge Undo It's the same that was copied to the Undo document, so don't delete the caption. Change-Id: Ib89870ed6e392c4271de2f416c78d42135922609 diff --git a/sc/source/ui/undo/undoblk3.cxx b/sc/source/ui/undo/undoblk3.cxx index 7a6038b..5fe6c5e 100644 --- a/sc/source/ui/undo/undoblk3.cxx +++ b/sc/source/ui/undo/undoblk3.cxx @@ -699,7 +699,13 @@ void ScUndoMerge::DoChange( bool bUndo ) const // undo -> copy back deleted contents if (bUndo && mpUndoDoc) { -rDoc.DeleteAreaTab( aRange, InsertDeleteFlags::CONTENTS|InsertDeleteFlags::NOCAPTIONS ); +// If there are note captions to be deleted during Undo they were +// kept or moved during the merge and copied to the Undo document +// without cloning the caption. Forget the target area's caption +// pointer that is identical to the one in the Undo document +// instead of deleting it. +rDoc.DeleteAreaTab( aRange, +InsertDeleteFlags::CONTENTS | InsertDeleteFlags::NOCAPTIONS | InsertDeleteFlags::FORGETCAPTIONS ); mpUndoDoc->CopyToDocument(aRange, InsertDeleteFlags::ALL|InsertDeleteFlags::NOCAPTIONS, false, rDoc); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 106037] Libreoffice crash when LAN connected. Simple single PC installation, without Samba, without network drives.
https://bugs.documentfoundation.org/show_bug.cgi?id=106037 --- Comment #5 from matthewn...@yahoo.co.uk --- Thankyou, to advise anyone to do horodating (anyone else reading here - please do). You're right, I do already, about every move or column modification. The disk is a huge SSD with two USB memory sticks. It's quite useful actually, to learn to be so prudent. A very detailled work journal indeed! First thing I noticed today about 5.3.0 after 10 seconds was that the file save icon no longer changes from the floppy diskette symbol to green arrow down when clicked and finished. My routine is to use "save as" menu to give a new datehourminute but I used to click that icon every five minutes as well because it was blue again. A user tick rather than trick. I solemnly swear I will read and learn all about autosave in an attempt to understand it. Matthew -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106060] Calc - Formula drag & Autofill - The values of the filled formula cells include only first sheet values
https://bugs.documentfoundation.org/show_bug.cgi?id=106060 --- Comment #4 from Jacques Guilleron--- Created attachment 131307 --> https://bugs.documentfoundation.org/attachment.cgi?id=131307=edit A part I did only a part of the job. Can you provide the file where you find those issues? Thank you, Jacques -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98665] Saving document is quite a bit slower than before
https://bugs.documentfoundation.org/show_bug.cgi?id=98665 --- Comment #20 from Commit Notification--- Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1334702ec3c92484c70954ce8474882ae5da6764 tdf#98665 optimize table format style access It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98665] Saving document is quite a bit slower than before
https://bugs.documentfoundation.org/show_bug.cgi?id=98665 Commit Notificationchanged: What|Removed |Added Whiteboard||target:5.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/dbgui/PivotLayoutDialog.cxx| 25 +--- sc/source/ui/dbgui/PivotLayoutTreeList.cxx |8 +-- sc/source/ui/dbgui/PivotLayoutTreeListBase.cxx |2 - sc/source/ui/dbgui/PivotLayoutTreeListData.cxx | 11 ++ sc/source/ui/dbgui/PivotLayoutTreeListLabel.cxx | 15 -- 5 files changed, 20 insertions(+), 41 deletions(-) New commits: commit e75734dfc530a101cadfe263fc256b12acc3a718 Author: Tomaž VajngerlDate: Sun Feb 12 09:48:38 2017 +0100 Pivot dialog: use C++11 feat., get rid of using namespace std Change-Id: Ic3690bf94aac2ec69c074eb4707a765bd932e5b0 Reviewed-on: https://gerrit.libreoffice.org/34173 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/sc/source/ui/dbgui/PivotLayoutDialog.cxx b/sc/source/ui/dbgui/PivotLayoutDialog.cxx index 5503c5e..0e0ed4b 100644 --- a/sc/source/ui/dbgui/PivotLayoutDialog.cxx +++ b/sc/source/ui/dbgui/PivotLayoutDialog.cxx @@ -571,32 +571,27 @@ void ScPivotLayoutDialog::ApplySaveData(ScDPSaveData& rSaveData) void ScPivotLayoutDialog::ApplyLabelData(ScDPSaveData& rSaveData) { -ScDPLabelDataVector::const_iterator it; ScDPLabelDataVector& rLabelDataVector = GetLabelDataVector(); -for (it = rLabelDataVector.begin(); it != rLabelDataVector.end(); ++it) +for (std::unique_ptr const & pLabelData : rLabelDataVector) { -const ScDPLabelData& rLabelData = *it->get(); - -OUString aUnoName = ScDPUtil::createDuplicateDimensionName(rLabelData.maName, rLabelData.mnDupCount); +OUString aUnoName = ScDPUtil::createDuplicateDimensionName(pLabelData->maName, pLabelData->mnDupCount); ScDPSaveDimension* pSaveDimensions = rSaveData.GetExistingDimensionByName(aUnoName); if (pSaveDimensions == nullptr) continue; -pSaveDimensions->SetUsedHierarchy(rLabelData.mnUsedHier); -pSaveDimensions->SetShowEmpty(rLabelData.mbShowAll); -pSaveDimensions->SetRepeatItemLabels(rLabelData.mbRepeatItemLabels); -pSaveDimensions->SetSortInfo(); -pSaveDimensions->SetLayoutInfo(); -pSaveDimensions->SetAutoShowInfo(); +pSaveDimensions->SetUsedHierarchy(pLabelData->mnUsedHier); +pSaveDimensions->SetShowEmpty(pLabelData->mbShowAll); +pSaveDimensions->SetRepeatItemLabels(pLabelData->mbRepeatItemLabels); +pSaveDimensions->SetSortInfo(>maSortInfo); +pSaveDimensions->SetLayoutInfo(>maLayoutInfo); +pSaveDimensions->SetAutoShowInfo(>maShowInfo); -bool bManualSort = (rLabelData.maSortInfo.Mode == DataPilotFieldSortMode::MANUAL); +bool bManualSort = (pLabelData->maSortInfo.Mode == DataPilotFieldSortMode::MANUAL); -std::vector::const_iterator itMember; -for (itMember = rLabelData.maMembers.begin(); itMember != rLabelData.maMembers.end(); ++itMember) +for (ScDPLabelData::Member const & rLabelMember : pLabelData->maMembers) { -const ScDPLabelData::Member& rLabelMember = *itMember; ScDPSaveMember* pMember = pSaveDimensions->GetMemberByName(rLabelMember.maName); if (bManualSort || !rLabelMember.mbVisible || !rLabelMember.mbShowDetails) diff --git a/sc/source/ui/dbgui/PivotLayoutTreeList.cxx b/sc/source/ui/dbgui/PivotLayoutTreeList.cxx index 98fd3db0..684b000 100644 --- a/sc/source/ui/dbgui/PivotLayoutTreeList.cxx +++ b/sc/source/ui/dbgui/PivotLayoutTreeList.cxx @@ -17,8 +17,6 @@ #include "pivot.hxx" #include "scabstdlg.hxx" -using namespace std; - VCL_BUILDER_FACTORY_ARGS(ScPivotLayoutTreeList, WB_BORDER | WB_TABSTOP | WB_CLIPCHILDREN | WB_FORCE_MAKEVISIBLE) @@ -53,7 +51,7 @@ bool ScPivotLayoutTreeList::DoubleClickHdl() ScAbstractDialogFactory* pFactory = ScAbstractDialogFactory::Create(); -vector aDataFieldNames; +std::vector aDataFieldNames; mpParent->PushDataFieldNames(aDataFieldNames); ScopedVclPtr pDialog( @@ -73,10 +71,8 @@ void ScPivotLayoutTreeList::FillFields(ScPivotFieldVector& rFieldVector) Clear(); maItemValues.clear(); -ScPivotFieldVector::iterator it; -for (it = rFieldVector.begin(); it != rFieldVector.end(); ++it) +for (ScPivotField& rField : rFieldVector) { -ScPivotField& rField = *it; OUString aLabel = mpParent->GetItem( rField.nCol )->maName; ScItemValue* pItemValue = new ScItemValue( aLabel, rField.nCol, rField.nFuncMask ); maItemValues.push_back(std::unique_ptr(pItemValue)); diff --git a/sc/source/ui/dbgui/PivotLayoutTreeListBase.cxx b/sc/source/ui/dbgui/PivotLayoutTreeListBase.cxx index 1fd79e9..d136318 100644 --- a/sc/source/ui/dbgui/PivotLayoutTreeListBase.cxx +++ b/sc/source/ui/dbgui/PivotLayoutTreeListBase.cxx @@ -16,8 +16,6 @@ #include #include "scabstdlg.hxx" -using namespace std; -
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/docfmt.cxx | 45 +--- sw/source/core/unocore/unocoll.cxx | 31 +--- sw/source/core/unocore/unostyle.cxx | 31 3 files changed, 65 insertions(+), 42 deletions(-) New commits: commit 1334702ec3c92484c70954ce8474882ae5da6764 Author: Tomaž VajngerlDate: Tue Feb 7 18:19:38 2017 +0100 tdf#98665 optimize table format style access Rework GetTableFrameFormat and GetTableFrameFormatCount to a simpler implementation (searching forward and using c++11). Using GetTableFrameFormatCount to get the size and then in a loop call GetTableFrameFormat for every index, can get really slow as in each call we need to filter the whole collection. Through UNO we can't avoid this (without much more work), but for internal calls like SwXTextTableStyle::isInUse, we access the underlaying collection and iterate + filter ourselves. In the same way we can slightly optimize SwXTextTables::getByIndex UNO method (with removing the need to call GetTableFrameFormatCount). Change-Id: Ib8462c32311ccc162ec290fe4eec70820855a378 Reviewed-on: https://gerrit.libreoffice.org/34008 Reviewed-by: Tomaž Vajngerl Tested-by: Tomaž Vajngerl diff --git a/sw/source/core/doc/docfmt.cxx b/sw/source/core/doc/docfmt.cxx index 067dadc..6f70be5 100644 --- a/sw/source/core/doc/docfmt.cxx +++ b/sw/source/core/doc/docfmt.cxx @@ -771,34 +771,43 @@ SwDrawFrameFormat *SwDoc::MakeDrawFrameFormat( const OUString , size_t SwDoc::GetTableFrameFormatCount(bool bUsed) const { -size_t nCount = mpTableFrameFormatTable->size(); -if(bUsed) +if (!bUsed) { -SwAutoFormatGetDocNode aGetHt( () ); -for ( size_t i = nCount; i; ) -{ -if((*mpTableFrameFormatTable)[--i]->GetInfo( aGetHt )) ---nCount; -} +return mpTableFrameFormatTable->size(); +} + +SwAutoFormatGetDocNode aGetHt(()); +size_t nCount = 0; +for (SwFrameFormat* const & pFormat : *mpTableFrameFormatTable) +{ +if (!pFormat->GetInfo(aGetHt)) +nCount++; } return nCount; } -SwFrameFormat& SwDoc::GetTableFrameFormat(size_t nFormat, bool bUsed ) const +SwFrameFormat& SwDoc::GetTableFrameFormat(size_t nFormat, bool bUsed) const { -size_t nRemoved = 0; -if(bUsed) +if (!bUsed) { -SwAutoFormatGetDocNode aGetHt( () ); -for ( size_t i = 0; i <= nFormat; ++i ) +return *((*mpTableFrameFormatTable)[nFormat]); +} + +SwAutoFormatGetDocNode aGetHt(()); + +size_t index = 0; + +for (SwFrameFormat* const & pFormat : *mpTableFrameFormatTable) +{ +if (!pFormat->GetInfo(aGetHt)) { -while ( (*mpTableFrameFormatTable)[ i + nRemoved]->GetInfo( aGetHt )) -{ -nRemoved++; -} +if (index == nFormat) +return *pFormat; +else +index++; } } -return *((*mpTableFrameFormatTable)[nRemoved + nFormat]); +throw std::out_of_range("Format index out of range."); } SwTableFormat* SwDoc::MakeTableFrameFormat( const OUString , diff --git a/sw/source/core/unocore/unocoll.cxx b/sw/source/core/unocore/unocoll.cxx index f6db86e..0eea033 100644 --- a/sw/source/core/unocore/unocoll.cxx +++ b/sw/source/core/unocore/unocoll.cxx @@ -857,24 +857,37 @@ sal_Int32 SwXTextTables::getCount() return nRet; } -uno::Any SAL_CALL SwXTextTables::getByIndex(sal_Int32 nIndex) +uno::Any SAL_CALL SwXTextTables::getByIndex(sal_Int32 nInputIndex) { SolarMutexGuard aGuard; uno::Any aRet; -if(IsValid()) +if (IsValid()) { -if(0 <= nIndex && GetDoc()->GetTableFrameFormatCount(true) > static_cast(nIndex)) +if (nInputIndex < 0) +throw IndexOutOfBoundsException(); + +SwAutoFormatGetDocNode aGetHt( ()->GetNodes() ); +size_t nIndex = static_cast(nInputIndex); +size_t nCurrentIndex = 0; + +for (SwFrameFormat* const & pFormat : *GetDoc()->GetTableFrameFormats()) { -SwFrameFormat& rFormat = GetDoc()->GetTableFrameFormat(nIndex, true); -uno::Reference< XTextTable > xTable = SwXTextTables::GetObject(rFormat); -aRet <<= xTable; +if (!pFormat->GetInfo(aGetHt)) +{ +if (nCurrentIndex == nIndex) +{ +uno::Reference xTable = SwXTextTables::GetObject(*pFormat); +aRet <<= xTable; +return aRet; +} +else +nCurrentIndex++; +} } -else -throw IndexOutOfBoundsException(); +throw IndexOutOfBoundsException(); } else throw uno::RuntimeException(); -
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - 37 commits - comphelper/source configure.ac cui/source desktop/CppunitTest_desktop_app.mk desktop/Library_sofficeapp.mk desktop/Modul
comphelper/source/misc/lok.cxx | 12 + configure.ac |4 cui/source/options/optbasic.cxx | 25 +- desktop/CppunitTest_desktop_app.mk |2 desktop/Library_sofficeapp.mk|2 desktop/Module_desktop.mk|5 desktop/source/lib/init.cxx | 41 +++ desktop/source/lib/lokinteractionhandler.cxx | 42 ++- include/LibreOfficeKit/LibreOfficeKitEnums.h | 31 ++ include/comphelper/lok.hxx |4 include/test/testinteractionhandler.hxx | 160 +++ include/vcl/ITiledRenderable.hxx |7 include/vcl/opengl/OpenGLWrapper.hxx |8 libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx | 29 +- libreofficekit/source/gtk/lokdocview.cxx |9 sax/source/fastparser/fastparser.cxx |4 sc/source/ui/app/inputhdl.cxx|8 sc/source/ui/docshell/docfunc.cxx|2 sc/source/ui/drawfunc/futext3.cxx|2 sc/source/ui/inc/tabview.hxx |1 sc/source/ui/view/gridwin4.cxx | 14 + sc/source/ui/view/tabview5.cxx | 45 sc/source/ui/view/viewfun6.cxx |2 scripting/Module_scripting.mk|4 sfx2/source/control/unoctitm.cxx | 26 +- svtools/source/control/ruler.cxx |9 svx/Executable_gengal.mk |2 sw/CppunitTest_sw_ooxmlencryption.mk | 49 sw/Module_sw.mk |1 sw/inc/AnnotationWin.hxx |2 sw/inc/PostItMgr.hxx |2 sw/inc/SidebarWin.hxx|4 sw/inc/docufld.hxx | 15 + sw/inc/editsh.hxx|1 sw/inc/swundo.hxx|3 sw/inc/unotxdoc.hxx |3 sw/ooxmlexport_setup.mk |1 sw/qa/extras/docbookexport/docbookexport.cxx |2 sw/qa/extras/htmlexport/htmlexport.cxx |4 sw/qa/extras/htmlimport/htmlimport.cxx |2 sw/qa/extras/inc/swmodeltestbase.hxx | 99 ++--- sw/qa/extras/ooxmlexport/data/Encrypted_MSO2007_abc.docx |binary sw/qa/extras/ooxmlexport/data/Encrypted_MSO2010_abc.docx |binary sw/qa/extras/ooxmlexport/data/Encrypted_MSO2013_abc.docx |binary sw/qa/extras/ooxmlexport/ooxmlencryption.cxx | 47 sw/qa/extras/ooxmlimport/ooxmlimport.cxx |7 sw/qa/extras/tiledrendering/tiledrendering.cxx | 99 + sw/qa/extras/ww8import/ww8import.cxx |2 sw/source/core/edit/edws.cxx |3 sw/source/core/fields/docufld.cxx| 27 +- sw/source/core/undo/docundo.cxx | 12 + sw/source/core/view/viewsh.cxx |3 sw/source/uibase/docvw/PostItMgr.cxx | 158 +++--- sw/source/uibase/docvw/SidebarWin.cxx| 93 sw/source/uibase/shells/annotsh.cxx | 30 ++ sw/source/uibase/shells/basesh.cxx | 50 +++- sw/source/uibase/shells/textfld.cxx |6 sw/source/uibase/uno/unotxdoc.cxx| 52 sw/source/uibase/wrtsh/wrtundo.cxx |2 vcl/source/filter/graphicfilter.cxx |2 writerfilter/source/ooxml/OOXMLDocumentImpl.cxx |8 61 files changed, 1073 insertions(+), 216 deletions(-) New commits: commit 97eaa05c40a926a9e16a109028ca8c829d34cb34 Author: Mike KaganskiDate: Wed Jan 18 10:16:14 2017 +0300 Also consider saved exceptions when mbEnableThreads is true Previously, saved exceptions are only checked in FastSaxParserImpl::parse(), which is used in case mbEnableThreads is false (when data in input stream is no more than 1). This patch also enables the same check for the other case. Change-Id: Ie718556b7c01322e30698515ecd331b7ebad4105 Reviewed-on: https://gerrit.libreoffice.org/33249 Reviewed-by: Mike Kaganski Tested-by: Mike Kaganski (cherry picked from commit 18ae77a065cb8ae6940d4067f6ab7e99a3f74047) diff --git
[Libreoffice-bugs] [Bug 90613] FILEOPEN: DOCX import blank document created from MSO normal.dotm
https://bugs.documentfoundation.org/show_bug.cgi?id=90613 Bartoszchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #8 from Bartosz --- This bug is not existing with LibreOffice 5.2 and Ubuntu 16.10 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106058] EDITING: Make Calc understand currency
https://bugs.documentfoundation.org/show_bug.cgi?id=106058 m.a.riosvchanged: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #6 from m.a.riosv --- I didn't test but maybe the https://extensions.libreoffice.org/extensions/numbertext-1 could help in someway. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 106058] EDITING: Make Calc understand currency
https://bugs.documentfoundation.org/show_bug.cgi?id=106058 m.a.riosvchanged: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #6 from m.a.riosv --- I didn't test but maybe the https://extensions.libreoffice.org/extensions/numbertext-1 could help in someway. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 104520] [META] DOCX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=104520 Bug 104520 depends on bug 90613, which changed state. Bug 90613 Summary: FILEOPEN: DOCX import blank document created from MSO normal.dotm https://bugs.documentfoundation.org/show_bug.cgi?id=90613 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105947] Pattern area fill does not work for chart wall
https://bugs.documentfoundation.org/show_bug.cgi?id=105947 Katarina Behrens (CIB)changed: What|Removed |Added Status|UNCONFIRMED |NEW Version|5.4.0.0.alpha0+ Master |5.3.0.2 rc Ever confirmed|0 |1 OS|Windows (All) |All --- Comment #5 from Katarina Behrens (CIB) --- Yep -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89900] Pagination problem when saving file
https://bugs.documentfoundation.org/show_bug.cgi?id=89900 Bartoszchanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: android/mobile-config.py extras/Package_cfgsrvnolang.mk extras/source icon-themes/elementary icon-themes/galaxy icon-themes/hicontrast l10ntools/source officecfg/Config
Repository.mk | 1 android/mobile-config.py| 1 dev/null |binary extras/Package_cfgsrvnolang.mk | 54 extras/source/misc_config/wizard/web/layouts/diagonal/index.html.xsl| 120 extras/source/misc_config/wizard/web/layouts/frame_bottom/index.html.xsl| 87 extras/source/misc_config/wizard/web/layouts/frame_bottom/mainframe.html| 7 extras/source/misc_config/wizard/web/layouts/frame_bottom/tocframe.html.xsl | 117 extras/source/misc_config/wizard/web/layouts/frame_left/index.html.xsl | 87 extras/source/misc_config/wizard/web/layouts/frame_left/mainframe.html | 7 extras/source/misc_config/wizard/web/layouts/frame_left/tocframe.html.xsl | 113 extras/source/misc_config/wizard/web/layouts/frame_right/index.html.xsl | 87 extras/source/misc_config/wizard/web/layouts/frame_right/mainframe.html | 7 extras/source/misc_config/wizard/web/layouts/frame_right/tocframe.html.xsl | 116 extras/source/misc_config/wizard/web/layouts/frame_top/index.html.xsl | 87 extras/source/misc_config/wizard/web/layouts/frame_top/mainframe.html | 7 extras/source/misc_config/wizard/web/layouts/frame_top/tocframe.html.xsl| 116 extras/source/misc_config/wizard/web/layouts/layout.xsl | 195 - extras/source/misc_config/wizard/web/layouts/layoutF.xsl| 113 extras/source/misc_config/wizard/web/layouts/layoutX.xsl| 281 - extras/source/misc_config/wizard/web/layouts/simple/index.html.xsl | 148 - extras/source/misc_config/wizard/web/layouts/source.xml.xsl | 44 extras/source/misc_config/wizard/web/layouts/table_2/index.html.xsl | 202 - extras/source/misc_config/wizard/web/layouts/table_3/index.html.xsl | 208 - extras/source/misc_config/wizard/web/layouts/zigzag/index.html.xsl | 207 - extras/source/misc_config/wizard/web/preview.html | 41 extras/source/misc_config/wizard/web/styles/beige.css | 97 extras/source/misc_config/wizard/web/styles/bg.css | 97 extras/source/misc_config/wizard/web/styles/bgr.css | 97 extras/source/misc_config/wizard/web/styles/bgrey.css | 97 extras/source/misc_config/wizard/web/styles/bwb.css | 97 extras/source/misc_config/wizard/web/styles/bwo.css | 97 extras/source/misc_config/wizard/web/styles/dark.css| 97 extras/source/misc_config/wizard/web/styles/dp.css | 97 extras/source/misc_config/wizard/web/styles/forest.css | 97 extras/source/misc_config/wizard/web/styles/green.css | 97 extras/source/misc_config/wizard/web/styles/greenred.css| 97 extras/source/misc_config/wizard/web/styles/grey.css| 97 extras/source/misc_config/wizard/web/styles/ibg.css | 97 extras/source/misc_config/wizard/web/styles/ice.css | 97 extras/source/misc_config/wizard/web/styles/marine.css | 97 extras/source/misc_config/wizard/web/styles/orange.css | 97 extras/source/misc_config/wizard/web/styles/pc_old.css | 109 extras/source/misc_config/wizard/web/styles/red.css | 97 extras/source/misc_config/wizard/web/styles/rgb.css | 109 extras/source/misc_config/wizard/web/styles/strange.css | 97 extras/source/misc_config/wizard/web/styles/violet.css | 97 extras/source/misc_config/wizard/web/styles/water.css | 97 l10ntools/source/gRun.sh| 2 officecfg/Configuration_officecfg.mk| 1 officecfg/files.mk | 1 officecfg/registry/data/org/openoffice/Office/Common.xcu| 22 officecfg/registry/data/org/openoffice/Office/WebWizard.xcu | 1480 -- officecfg/registry/schema/org/openoffice/Office/WebWizard.xcs | 536 --- postprocess/CustomTarget_registry.mk| 2 postprocess/Rdb_services.mk | 1 wizards/Module_wizards.mk | 1 wizards/Pyuno_web.mk
[Libreoffice-bugs] [Bug 99967] Drop Web Wizard
https://bugs.documentfoundation.org/show_bug.cgi?id=99967 --- Comment #15 from Commit Notification--- Samuel Mehrbrodt committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5b3022860abfe7eefd2e25b60b5b2a563b42b3c0 tdf#99967 Drop Web Wizard It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 99967] Drop Web Wizard
https://bugs.documentfoundation.org/show_bug.cgi?id=99967 Commit Notificationchanged: What|Removed |Added Whiteboard||target:5.4.0 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 99967] Drop Web Wizard
https://bugs.documentfoundation.org/show_bug.cgi?id=99967 --- Comment #15 from Commit Notification--- Samuel Mehrbrodt committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5b3022860abfe7eefd2e25b60b5b2a563b42b3c0 tdf#99967 Drop Web Wizard It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 99967] Drop Web Wizard
https://bugs.documentfoundation.org/show_bug.cgi?id=99967 Commit Notificationchanged: What|Removed |Added Whiteboard||target:5.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106037] Libreoffice crash when LAN connected. Simple single PC installation, without Samba, without network drives.
https://bugs.documentfoundation.org/show_bug.cgi?id=106037 --- Comment #4 from Julien Nabet--- It's a good start! :-) Another piece of advice (but perhaps you already do this), do a backup of your files with horodating before changing them ; it may help. eg: research.ods research_20170217.ods Keep at least the 2 or 3 last backup of a file just to be sure. Of course, make copies of your backup files on network or on an usb key, just in case (hard disk may crash sometimes) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106070] RTF IO open file error
https://bugs.documentfoundation.org/show_bug.cgi?id=106070 Yan Paschanged: What|Removed |Added CC||yanp.b...@gmail.com --- Comment #1 from Yan Pas --- Created attachment 131306 --> https://bugs.documentfoundation.org/attachment.cgi?id=131306=edit rtf -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106070] New: RTF IO open file error
https://bugs.documentfoundation.org/show_bug.cgi?id=106070 Bug ID: 106070 Summary: RTF IO open file error Product: LibreOffice Version: 5.2.5.1 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: yanp.b...@gmail.com Description: - Steps to Reproduce: Just open attached file Actual Results: - Expected Results: - Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] mso-dumper.git: 2 commits - msodumper/docrecord.py
msodumper/docrecord.py |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) New commits: commit 5e117b0f158617c1c2ec23238fae5f85dcedc1d5 Author: Michael StahlDate: Fri Feb 17 22:06:34 2017 +0100 docrecord: try to survive missing fieldType diff --git a/msodumper/docrecord.py b/msodumper/docrecord.py index baa3d22..5b879f8 100644 --- a/msodumper/docrecord.py +++ b/msodumper/docrecord.py @@ -1287,7 +1287,10 @@ class NilPICFAndBinData(BinaryStream): self.printAndSet("ignored13", self.readInt32()) self.printAndSet("ignored14", self.readInt32()) self.printAndSet("ignored15", self.readInt16()) -fieldType = chpxFkp.transformeds[-2] +if len(chpxFkp.transformeds) > 1: +fieldType = chpxFkp.transformeds[-2] +else: +fieldType = ")-MISSING-(" if fieldType == " FORMTEXT ": FFData(self).dump() else: commit 7e60cac0e789677a6e599c1f1ef1a2b1854ebe45 Author: Michael Stahl Date: Fri Feb 17 21:56:26 2017 +0100 docrecord: add some missing shifts in FFDataBits.dump diff --git a/msodumper/docrecord.py b/msodumper/docrecord.py index 77588ca..baa3d22 100644 --- a/msodumper/docrecord.py +++ b/msodumper/docrecord.py @@ -1199,13 +1199,13 @@ class FFDataBits(BinaryStream): print '' buf = self.readuInt8() self.printAndSet("iType", buf & 0x0003, dict=IType) # 1..2nd bits -self.printAndSet("iRes", buf & 0x007c) # 3..7th bits +self.printAndSet("iRes", (buf & 0x007c) >> 2) # 3..7th bits self.printAndSet("fOwnHelp", self.getBit(buf, 8)) buf = self.readuInt8() self.printAndSet("fOwnStat", self.getBit(buf, 1)) self.printAndSet("fProt", self.getBit(buf, 2)) self.printAndSet("iSize", self.getBit(buf, 3)) -self.printAndSet("iTypeTxt", buf & 0x0038, dict=ITypeTxt) # 4..6th bits +self.printAndSet("iTypeTxt", (buf & 0x0038) >> 3, dict=ITypeTxt) # 4..6th bits self.printAndSet("fRecalc", self.getBit(buf, 7)) self.printAndSet("fHasListBox", self.getBit(buf, 8)) print '' ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 105992] FORMATTING: Writer doesn' t use kerning information of Times New Roman anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=105992 V Stuart Footechanged: What|Removed |Added CC||khaledho...@eglug.org Blocks||103729 --- Comment #16 from V Stuart Foote --- @Khaled, any insight into the Times New Roman "Core fonts" metrics as described used with the common HarfBuzz layout at 5.3? More differing table goodness? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103729 [Bug 103729] [META] Tracking HarfBuzz based common text layout regressions -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-qa] [ANN] LibreOffice 5.2.6 RC1 test builds available
Hi *, for the upcoming new version 5.2.6, the builds for RC1 are now available on pre-releases. 5.2.6 rc1 is in release-build configuration, meaning it will update a previous version of LibreOffice 5.2.6 will be the sixth bugfix release for the fresh 5.2 codeline and is prepared additionally, due to the out-of-line 5.2.5 release earlier. Grab the builds from here here: http://dev-builds.libreoffice.org/pre-releases/ If you've a bit of time, please give them a try & report any severe bugs not yet in bugzilla here, so we can incorporate them into the release notes. Please note that it takes approximately 24 hours to populate the mirrors, so that's about the time we have to collect feedback. The list of fixed bugs relative to 5.2.5 final (rc1) is here: http://dev-builds.libreoffice.org/pre-releases/src/bugs-libreoffice-5-2-6-release-5.2.6.1.log So playing with the areas touched there also greatly appreciated - and validation that those bugs are really fixed. Thanks a lot for your help, Christian ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 106037] Libreoffice crash when LAN connected. Simple single PC installation, without Samba, without network drives.
https://bugs.documentfoundation.org/show_bug.cgi?id=106037 matthewn...@yahoo.co.uk changed: What|Removed |Added CC||matthewn...@yahoo.co.uk --- Comment #3 from matthewn...@yahoo.co.uk --- Thankyou for the advice; First change. System upgraded, kernel 4.4.0, glibc, freetype 2.6.1, GTK 3.18.9, Second change. Then using ppa for LibreOffice fresh - which visited glib again. Seems Light Ubuntu supports all dependencies. LO is now at 5.3.0 Build ID: 1:5.3.0~rc3-0ubuntu1~xenial1.1 LAN cable reconnected and machine in use. Eight hours continuous use. No problems at all. Testing should show the effect within four days or so at this work rate; it's more thinking than doing at this stage. If a problem occurs with 5.3.0, I'll do all that's possible with backtrace, bearing in mind that the mouse and keyboard were unusable before, log files only. I'll revisit a few previous studies too, much larger files, to see what happens, noting the Status or replying to you. best regards from France Matthew Walker -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/data/functions/statistical/fods/chisq.inv.fods| 5838 +++ sc/qa/unit/data/functions/statistical/fods/chisq.inv.rt.fods | 5828 ++ 2 files changed, 11666 insertions(+) New commits: commit 9bc537b7943bc4d82e759b394941f89c35658516 Author: ZdenÄk CrhonekDate: Fri Feb 17 19:59:35 2017 +0100 add CHISQ.INV, CHISQ.INV.RT test case Change-Id: Ie09299e297bb915b9bd722d6f4f2135232337c32 Reviewed-on: https://gerrit.libreoffice.org/34380 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek diff --git a/sc/qa/unit/data/functions/statistical/fods/chisq.inv.fods b/sc/qa/unit/data/functions/statistical/fods/chisq.inv.fods new file mode 100644 index 000..84f03ae --- /dev/null +++ b/sc/qa/unit/data/functions/statistical/fods/chisq.inv.fods @@ -0,0 +1,5838 @@ + + +http://www.w3.org/1999/xlink; xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" xmlns:math="http://www.w3.org/1998/Math/MathML; xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" xmlns:ooo="http://openoffice.org/2004/office; xmlns:ooow="http://openoffice.org/2004/writer; xmlns:oooc="http://openoffice.org/2004/calc; xmlns:dom="http://www.w3.org/2001/xml-events; xmlns:xforms="http://www.w3.org/2002/xforms; xmlns:xsd="http://www.w3.org/2001/XMLSchema; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xmlns:rpt="http://openoffice.org/2005/report; xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" xmlns:xhtml="http://www.w3.org/1999/xhtml; xmlns:grddl="http://www.w3.org/2003/g/data-view#; xmlns:tableooo="http://openoffice.org/2009/table; xmlns:drawooo="http://openoffice.org/2010/draw; xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0" xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0" xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" xmlns:form x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" office:mimetype="application/vnd.oasis.opendocument.spreadsheet"> + 2017-02-17T19:42:47.143959875P0D1LibreOfficeDev/5.4.0.0.alpha0$Linux_X86_64 LibreOffice_project/2aea0d0148ea0940da2b32387c330f9aa590294c + + + 0 + 0 + 96176 + 28426 + + + view1 + + + 2 + 8 + 0 + 0 + 0 + 0 + 2 + 0 + 0 + 0 + 0 + 0 + 100 + 60 + true + false + + + 4 + 1 + 0 + 0 + 0 + 0 + 2 + 0 + 0 + 0 + 0 + 0 + 100 + 60 + true + false + + + Sheet2 + 1241 + 0 + 100 + 60 + false + true + true + true + 12632256 + true + true + true + true + true + false + false + 1270 + 1270 + 1 + 1 + true + false + + + + + 7 + false + false + true + true + false + false + false + 1270 + 1270 + true + true + true + true + true + false + 12632256 + false + Lexmark-E352dn + + + cs + CZ + + + + + + de + DE + + + + + + en + US + + + + + + nl + NL + + + + + + true + true + 3 + 1 + true + 1 + true + lgH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMAtwAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhClBhZ2VTaXplOkxldHRlcgAAEgBDT01QQVRfRFVQTEVYX01PREUPAER1cGxleE1vZGU6Ok9mZg== + false + 0 + + + + + http://openoffice.org/2004/office; xmlns:xlink="http://www.w3.org/1999/xlink;> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + KÄ + + + + - + + + KÄ + + + + + + + + + + ( + + ) + + + + - + + + + + + +
[Libreoffice-bugs] [Bug 105992] FORMATTING: Writer doesn' t use kerning information of Times New Roman anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=105992 --- Comment #15 from LibreTraining--- Your sample images above seem to show an issue with the "We" pair. Just checked the kerning tables and the values are identical. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/metaact.cxx |7 +++ 1 file changed, 7 insertions(+) New commits: commit 6f53409ef3a45e0c26cc87247dd2ea9aa4539d55 Author: Caolán McNamaraDate: Fri Feb 17 20:49:58 2017 + ofz: libFuzzer: out-of-memory from "unstable" log file https://oss-fuzz-build-logs.storage.googleapis.com/build_logs/libreoffice/latest.txt #5 0x617248 in operator new[](unsigned long) /src/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:84 #6 0x710843 in MetaCommentAction::Read(SvStream&, ImplMetaReadData*) /src/libreoffice/vcl/source/gdi/metaact.cxx:3363:18 #7 0x6e1921 in MetaAction::ReadMetaAction(SvStream&, ImplMetaReadData*) /src/libreoffice/vcl/source/gdi/metaact.cxx:266:18 Change-Id: I518adea27565d1fbe91c8817f41850deb0ba9877 diff --git a/vcl/source/gdi/metaact.cxx b/vcl/source/gdi/metaact.cxx index 05b24da..3ef9002 100644 --- a/vcl/source/gdi/metaact.cxx +++ b/vcl/source/gdi/metaact.cxx @@ -3354,6 +3354,13 @@ void MetaCommentAction::Read( SvStream& rIStm, ImplMetaReadData* ) maComment = read_uInt16_lenPrefixed_uInt8s_ToOString(rIStm); rIStm.ReadInt32( mnValue ).ReadUInt32( mnDataSize ); +if (mnDataSize > rIStm.remainingSize()) +{ +SAL_WARN("vcl.gdi", "Parsing error: " << rIStm.remainingSize() << + " available data, but " << mnDataSize << " claimed, truncating"); +mnDataSize = rIStm.remainingSize(); +} + SAL_INFO("vcl.gdi", "MetaCommentAction::Read " << maComment); delete[] mpData; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 106069] New: libreofficedev core not installed correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=106069 Bug ID: 106069 Summary: libreofficedev core not installed correctly Product: LibreOffice Version: 5.4.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: plokk...@fastmail.fm Description: When installing libreofficedev5.4 under ubuntu 16.04 x64 with sudo dpkg -i *.deb, lodevbasis5.4-core_5.4.0.0.alpha0-1_amd64.deb doesn't get installed correctly. Happens with Version: 5.4.0.0.alpha0+ Build ID: 1cde2eb9d128c9b1b658b1380074461429ab2214 from 14.02.2017 and newer, but not with Version: 5.4.0.0.alpha0+ Build ID: 1d810b69a584fc33f4178c7012f68f551ba2e03b CPU Threads: 2; OS Version: Linux 4.4; UI Render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-02-13_00:23:05 Locale: en-US (en_US.UTF-8); Calc: single The error when using sudo is: Unpacking lodevbasis5.4-core (5.4.0.0.alpha0-1) over (5.4.0.0.alpha0-1) ... dpkg: error processing archive lodevbasis5.4-core_5.4.0.0.alpha0-1_amd64.deb (--install): trying to overwrite '/opt/libreofficedev5.4/share/filter/oox-drawingml-cs-presets', which is also in package lodevbasis5.4-filter-data 5.4.0.0.alpha0-1 dpkg-deb: error: subprocess paste was killed by signal (Broken pipe) and when using SAL_USE_VCLPLUGIN=gtk3 libreofficedev5.4 --calc /opt/libreofficedev5.4/program/soffice.bin: symbol lookup error: /opt/libreofficedev5.4/program/../program/libsclo.so: undefined symbol: _ZN8SdrModel19SetCharCompressTypeE16CharCompressType If I revert back to the built from 13.02 everything works as expected again. Actual Results: core doesn't get updated. Expected Results: installs correctly. Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106056] EDITING: text cursor disappears after input of space or one of these characters: . , : ; _ / * ! ? % ' " into cell
https://bugs.documentfoundation.org/show_bug.cgi?id=106056 Xisco Faulíchanged: What|Removed |Added Keywords||bibisectRequest, regression Status|UNCONFIRMED |NEW CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #1 from Xisco Faulí --- Confirmed in Version: 5.4.0.0.alpha0+ Build ID: 880033edde516fc30225005245253293a6a58ba4 CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group but not in Version: 5.2.0.0.alpha1+ Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; Locale: ca-ES (ca_ES.UTF-8) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 106058] EDITING: Make Calc understand currency
https://bugs.documentfoundation.org/show_bug.cgi?id=106058 --- Comment #5 from V Stuart Foote--- (In reply to cheater00 from comment #4) > Could this functionality (eg points 2 and 4) be executed using a plug-in IIUC if you can do it manually now in the GUI it can be coded with the APIs provided in the SDK, and then packaged as an .oxt extension. [1] For Calc there is even the ability to add-in the extension as a service, i.e. implementing new FUNCTIONs But here, I still don't think you'd be able to overload the cell "value" making it currency aware. You still would need to use additional columns/sheets to perform the conversions and replace the fp numeric currency "value" with its conversion and sort accordingly. You probably also need to accommodate LibreOffice treatment of currency symbol defaults[2][3] for the locale, and OS system input locale-language. LibreOffice uses ISO 4217 code for Currency and Bank--these are just for styling the display when the cell Value is set to currency. =-ref-= [1] https://wiki.documentfoundation.org/Development/Extension_Development [2] http://opengrok.libreoffice.org/xref/core/offapi/com/sun/star/i18n/Currency.idl [3] http://opengrok.libreoffice.org/xref/core/i18npool/source/localedata/data/ -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 106058] EDITING: Make Calc understand currency
https://bugs.documentfoundation.org/show_bug.cgi?id=106058 --- Comment #5 from V Stuart Foote--- (In reply to cheater00 from comment #4) > Could this functionality (eg points 2 and 4) be executed using a plug-in IIUC if you can do it manually now in the GUI it can be coded with the APIs provided in the SDK, and then packaged as an .oxt extension. [1] For Calc there is even the ability to add-in the extension as a service, i.e. implementing new FUNCTIONs But here, I still don't think you'd be able to overload the cell "value" making it currency aware. You still would need to use additional columns/sheets to perform the conversions and replace the fp numeric currency "value" with its conversion and sort accordingly. You probably also need to accommodate LibreOffice treatment of currency symbol defaults[2][3] for the locale, and OS system input locale-language. LibreOffice uses ISO 4217 code for Currency and Bank--these are just for styling the display when the cell Value is set to currency. =-ref-= [1] https://wiki.documentfoundation.org/Development/Extension_Development [2] http://opengrok.libreoffice.org/xref/core/offapi/com/sun/star/i18n/Currency.idl [3] http://opengrok.libreoffice.org/xref/core/i18npool/source/localedata/data/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106038] Selected range of text disappears when going to Print Preview and back
https://bugs.documentfoundation.org/show_bug.cgi?id=106038 Xisco Faulíchanged: What|Removed |Added Keywords||needsUXEval CC||xiscofa...@libreoffice.org --- Comment #1 from Xisco Faulí --- Confirmed in Version: 5.4.0.0.alpha0+ Build ID: 880033edde516fc30225005245253293a6a58ba4 CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group However, adding needsUXEval to decide whether it's a bug to the UX team -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105992] FORMATTING: Writer doesn' t use kerning information of Times New Roman anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=105992 --- Comment #14 from LibreTraining--- Created attachment 131305 --> https://bugs.documentfoundation.org/attachment.cgi?id=131305=edit Times-New-Roman-Kerning-Tables-v2.82-and-v5.22.PDFs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93748] Explorer crash while drag & drop LibO 64bit ods file to google Drive
https://bugs.documentfoundation.org/show_bug.cgi?id=93748 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #3 from Xisco Faulí --- Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105992] FORMATTING: Writer doesn' t use kerning information of Times New Roman anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=105992 --- Comment #13 from LibreTraining--- There is something else going on here. I actually printed the kerning tables and compared them. They are identical. I just spot-checked the following pairs: Aa Ae Ac At Ay Ta Te Ti To Tr Ts Tu Tw Va Vc Ve Vi Vr Vu Vy All have the same kerning values. I will attach PDFs of the kerning tables for you to take a look. See attached ZIP: Times-New-Roman-Kerning-Tables-v2.82-and-v5.22.PDFs.zip -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106067] A chart in a duplicated sheet sometimes looses its data range
https://bugs.documentfoundation.org/show_bug.cgi?id=106067 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #1 from Xisco Faulí --- Thank you for reporting the bug. Please attach a sample document, as this makes it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided. (Please note that the attachment will be public, remove any sensitive information before attaching it. See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106052] 'Precision as shown' does not work with several subformats
https://bugs.documentfoundation.org/show_bug.cgi?id=106052 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #1 from Xisco Faulí --- Confirmed in Version: 5.4.0.0.alpha0+ Build ID: 880033edde516fc30225005245253293a6a58ba4 CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs