[Libreoffice-bugs] [Bug 104444] [META] DOCX table related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=10

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||106742


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106742
[Bug 106742] FILEOPEN: DOC(X) table with minus left spacing
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106742] FILEOPEN: DOC(X) table with minus left spacing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106742

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||10


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=10
[Bug 10] [META] DOCX table related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #40 from Mike Kaganski  ---
(In reply to Andreas Säger from comment #39)

I assume that you took the effort and found some places with modules shipped
with LO? So why not to tell exactly where did you find them, instead of posting
uninformative messages that essentially say "I found them but not telling
where; go and find yourself". And better yet, file a dedicated bug for that,
because that's part of LO (unlike external extensions), and should be tracked
by LO developers. The new bug report should reference this one in its See Also.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106585] EPS image inserted into a Writer document is incorrectly scaled, despite properties "keep scale" or "keep image size"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106585

Graham Freeman  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Graham Freeman  ---
I have tried my wife's computer, also running Linux and Version 5.2.3.3 of
LibreOffice, and pasting my EPS file into a Writer document works perfectly
with no shrinkage of the graphics if 100% is set as scaling. It looks like
something serious is wrong with the copy on my machine. I will have to
reinstall it.

Thanks for your help. I am sorry to trouble you over the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106585] EPS image inserted into a Writer document is incorrectly scaled, despite properties "keep scale" or "keep image size"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106585

--- Comment #7 from Graham Freeman  ---
There was a problem with my printer when I tried to print your PDF file
yesterday. I have rebooted it and it now prints the file without problem.
Furthermore, it does not exhibit the shrinkage problem that I experience with
my own copy of LibreOffice. The lines appear exactly where the EPS instructed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] dev-tools.git: uitest/execute.sh

[Markus Mohrhard]

 uitest/execute.sh |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 7dab560e7767b72598b7128f020a3dd526818899
Author: Markus Mohrhard 
Date:   Sat Mar 25 03:58:44 2017 +0100

make the uitest execute script more generic

diff --git a/uitest/execute.sh b/uitest/execute.sh
index 6fe09a5..5eb7bb5 100755
--- a/uitest/execute.sh
+++ b/uitest/execute.sh
@@ -1 +1,2 @@
-/home/moggi/devel/libo9/instdir/program/python 
/home/moggi/devel/libo9/uitest/test_main.py --debug 
--soffice=path:/home/moggi/devel/libo9/instdir/program/soffice 
--userdir=file:///tmp/libreoffice_$dir_name/4 
--file=/home/moggi/devel/libo9/uitest/calc_tests/create_range_name.py
+SRCDIR="${SRCDIR:-$(pwd)}"
+$SRCDIR/instdir/program/python $SRCDIR/uitest/test_main.py --debug 
--soffice=path:$SRCDIR/instdir/program/soffice 
--userdir=file:///tmp/libreoffice_$dir_name/4 
--file=$SRCDIR/uitest/calc_tests/create_range_name.py
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 93328] Editing circular reference causes #VALUE! error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93328

--- Comment #13 from Aron Budea  ---
(In reply to Kohei Yoshida from comment #12)
> No, they don't.  A presence of circular reference is a sure way to get a
> VALUE error, unless the iterative calculation option is turned on.

Indeed, I only took a look at that option now, and it is enabled in the
spreadsheet.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106763] New: EDITING

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106763

Bug ID: 106763
   Summary: EDITING
   Product: LibreOffice
   Version: 5.1.4.2 release
  Hardware: x86 (IA32)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dloch...@d2.net.au

Created attachment 132138
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132138=edit
Four rows are adjusted correctly or not, as noted in the comments.

This bug is so simple I wonder whether I misunderstand something but, if not, I
think it's critical.  It may be related to #42261 from Winfried Donkers.

The attachment illustrates the problem.  The four rows 6-9 containing value "1"
are summed with =SUM($B$6:$B$9).  If one right-clicks on row-5 "Add Rows Above"
the formula is correctly adjusted to =SUM($B$7:$B$10).  However the same
operation on row-6 results in the formula =SUM($B$6:$B$10) which sums five
rows.  I would expect it to also adjust the range to $B$7:$B$10.

This problem was first identified when a macro using:
oActSheet.insertCells (oCellRangeAddress,
com.sun.star.sheet.CellInsertMode.ROWS)
failed to work as expected though in a more complex way.

Regards,
David Lochrin

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106762] New: Color floating tolbars cant'n be created

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106762

Bug ID: 106762
   Summary: Color floating tolbars cant'n be created
   Product: LibreOffice
   Version: 5.3.1.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sanipache...@outlook.com.ar

Created attachment 132137
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132137=edit
Floating toolbar is not created

When you drag and drop the menu to select the colors and make it make a
floating toolbar, it is not created. It closes. It happens in all the programs
of the suite.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93328] Editing circular reference causes #VALUE! error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93328

--- Comment #12 from Kohei Yoshida  ---
(In reply to Aron Budea from comment #11)
> I think circular references to variables cancel each other out.

No, they don't.  A presence of circular reference is a sure way to get a VALUE
error, unless the iterative calculation option is turned on.

Either that, or maybe our definition of "circular reference" is different,
which is also a possibility.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106334] Cut and paste rows creates conditionnal formating on multiple columns

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106334

Markus Mohrhard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #12 from Markus Mohrhard  ---


*** This bug has been marked as a duplicate of bug 106242 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106753] Move the whole page using the arrows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106753

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
Maybe the scroll was locked on some way.

Please try resetting the user profile, sometimes solves strange issues.
https://wiki.documentfoundation.org/UserProfile
Usually it's enough renaming/deleting the file
"user/registrymodifications.xcu",  it affects all the options in
Menu/Tools/Options, and the files "user/basic/dialog.xlc" and "scrip.xlc" are
overwritten, additionally custom colors in "user/config/standard.soc" are lost.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93328] Editing circular reference causes #VALUE! error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93328

--- Comment #11 from Aron Budea  ---
I think circular references to variables cancel each other out.

But the bug isn't with handling circular references here, as it displays the
correct result (at least I assume so, didn't check the numbers) after
adding/removing the +1 if you:
- do a hard recalc, or
- tell Calc to treat empty cells as zero in Options.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: icon-themes/breeze icon-themes/breeze_dark icon-themes/breeze_svg icon-themes/galaxy

[andreas kainz]

 icon-themes/breeze/res/notebookbar.png  |binary
 icon-themes/breeze_dark/res/notebookbar.png |binary
 icon-themes/breeze_svg/res/notebookbar.svg  |   10 +-
 icon-themes/galaxy/res/notebookbar.png  |binary
 4 files changed, 1 insertion(+), 9 deletions(-)

New commits:
commit 193f8966135064a32164c9da08d01dab9c1fc15d
Author: andreas kainz 
Date:   Fri Mar 24 20:53:20 2017 +0100

update notebook icon now it work without background

Change-Id: I15e9d5e8ae8cef6d1f5063d2d6c0f418ea12826d
Reviewed-on: https://gerrit.libreoffice.org/35668
Tested-by: Jenkins 
Reviewed-by: Heiko Tietze 

diff --git a/icon-themes/breeze/res/notebookbar.png 
b/icon-themes/breeze/res/notebookbar.png
index 9557ad7d4fbd..610111d8bfdd 100644
Binary files a/icon-themes/breeze/res/notebookbar.png and 
b/icon-themes/breeze/res/notebookbar.png differ
diff --git a/icon-themes/breeze_dark/res/notebookbar.png 
b/icon-themes/breeze_dark/res/notebookbar.png
index b5d74ee336e8..aae0ead2d519 100644
Binary files a/icon-themes/breeze_dark/res/notebookbar.png and 
b/icon-themes/breeze_dark/res/notebookbar.png differ
diff --git a/icon-themes/breeze_svg/res/notebookbar.svg 
b/icon-themes/breeze_svg/res/notebookbar.svg
index a5b6d6f9d162..72d5cbb8477e 100644
--- a/icon-themes/breeze_svg/res/notebookbar.svg
+++ b/icon-themes/breeze_svg/res/notebookbar.svg
@@ -37,7 +37,7 @@
  id="namedview8"
  showgrid="false"
  inkscape:zoom="14.75"
- inkscape:cx="-2.2711864"
+ inkscape:cx="-12.542373"
  inkscape:cy="8"
  inkscape:window-x="0"
  inkscape:window-y="36"
@@ -53,14 +53,6 @@
   }
   
   
-  
   https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106749] average and sum defaults in status bar return a wrong number when the range include a date

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106749

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
Because dates are numbers in the cells, and only the format makes they showed
as dates. SUM doesn't take care of text even if it looks as number.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: configmgr/source

[Andrea Gelmini]

 configmgr/source/rootaccess.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c4e7c260c48069d3aeee4930d519ee6e18a80585
Author: Andrea Gelmini 
Date:   Wed Mar 22 11:11:10 2017 +0100

Fix configmgr argument

Commit 3e64874e7cd23 introduce a not-existent argument.
Dunno if it's an issue.
Just made this commit to show it to real developers!

Change-Id: I01f4b859631e76e0d76269db19bcbcf3481d827c
Reviewed-on: https://gerrit.libreoffice.org/35531
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/configmgr/source/rootaccess.hxx b/configmgr/source/rootaccess.hxx
index 1f4203ba9803..9564bbf34a63 100644
--- a/configmgr/source/rootaccess.hxx
+++ b/configmgr/source/rootaccess.hxx
@@ -58,7 +58,7 @@ class RootAccess:
 {
 public:
 RootAccess(
-Components & components, OUString const & pathRepresenation,
+Components & components, OUString const & pathRepresentation,
 OUString const & locale, bool update);
 
 virtual std::vector getAbsolutePath() override;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106745] Reference to a figure lost in .docx format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106745

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Xisco Faulí  ---
Actually, it seems like a dupe of bug 106584

*** This bug has been marked as a duplicate of bug 106584 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106584] Figure/Table references disappear when exporting to Word ( docx)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106584

Xisco Faulí  changed:

   What|Removed |Added

 CC||frederic.parrenin@univ-gren
   ||oble-alpes.fr

--- Comment #6 from Xisco Faulí  ---
*** Bug 106745 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106745] Reference to a figure lost in .docx format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106745

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||xiscofa...@libreoffice.org
Version|5.3.1.2 release |4.1 all versions
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Reproduced in

- Version: 5.4.0.0.alpha0+
Build ID: 1670cc25bc2771e87f7956a4b0dd634abaa4128b
CPU threads: 4; OS: Linux 4.8; UI render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

- Version: 5.0.0.0.alpha1+
Build ID: 0db96caf0fcce09b87621c11b584a6d81cc7df86
Locale: ca-ES (ca_ES.UTF-8)

- Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106706] Presentation with linked videos crashes Impress when loading.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106706

--- Comment #2 from Richard Marchessault  ---
I have sent a sample document. Was it received?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106761] New: HTML: charset setting not honored/broken CP1252

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106761

Bug ID: 106761
   Summary: HTML: charset setting not honored/broken CP1252
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer Web
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mh...@gmx.net

set OPTION/HTML-compatibility  to WINDOWS 1252

start a new HTML-page
tag charset is set to charset=windows-1252

type in the german Umlauts äöüÄÖÜß

these characters will be saved as html-entities  ( ä=)

so Windos-1252/latin1 is a subset of CP 1252 only

there are some other glitches within the editor, esp. the reformating of code,
which makes it difficult to edit/repair code, however, this issue is really
unneccessary, please implement foll windows-1252-support.

martin

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106695] German translation mistake "Text Abstand" instead of " Textabstand"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106695

Thomas Lendo  changed:

   What|Removed |Added

Summary|German translation mistake  |German translation mistake
   |"Text Abtand" instead of|"Text Abstand" instead of
   |"Textabstand"   |"Textabstand"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106366] "Open" for document in use doesn't give "Edit document" button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106366

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected,
   ||regression
 CC||s.mehrbr...@gmail.com,
   ||xiscofa...@libreoffice.org

--- Comment #2 from Xisco Faulí  ---
regression introduced by:

author  Samuel Mehrbrodt   2017-02-23 14:12:34
(GMT)
committer   Samuel Mehrbrodt   2017-02-23
15:35:33 (GMT)
commit  aa8efc72d43c2000cb3b5571fdc6b48617eb9b94 (patch)
treee6c7df22af47e2d14fbfa3d4970b1c8586530e3b
parent  544104b957e72cfb5701cd949bca5184324d20ed (diff)
tdf#101652 No infobar when doc attr is readonly
One can set the a document attribute to open the doc read-only.
In this case the read-only infobar should not be shown.

bisected with bibisect-linux-64-5.4.

Adding Cc: to Samuel Mehrbrodt

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106743] th_TH.aff has a bad encoding

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106743

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
I noticed this part:
283 { "TIS620.2533",RTL_TEXTENCODING_MS_874 }, /* th_TH.TIS620
*/
see http://opengrok.libreoffice.org/xref/core/sal/osl/unx/nlsupport.cxx#283

Could you explain a bit what you did?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106694] FILEOPEN: RTF: Incorrect TOC's numbers positions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106694

Miklos Vajna  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93328] Editing circular reference causes #VALUE! error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93328

--- Comment #10 from Kohei Yoshida  ---
Assuming that the formula chain contains a circular reference, wouldn't it be
correct to see errors in those cells?  Or is the VALUE error not the correct
error type to show, or... ?

Clarification is appreciated.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: About tdf#106732 (autocaption)

[julien2412]

After some gdb, I noticed that with additional var, there's a call to
ImpSvGlobalName::operator == in addition with SvGlobalName::operator ==
Perhaps it's related to ::o3tl::cow_wrapper mechanism



--
View this message in context: 
http://nabble.documentfoundation.org/About-tdf-106732-autocaption-tp4210964p4211001.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 93328] Editing circular reference causes #VALUE! error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93328

--- Comment #9 from Kohei Yoshida  ---
Can someone remind me what would be the correct behavior here?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106609] Inserting a note or a comment, after sharing an .ODS or .ODT files, greyed out...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106609

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #5 from Aron Budea  ---
(In reply to João Paulo Martins from comment #4)
> You guys make a software from scratch and don't know their features?? :D

Most of the team are volunteers with various amount of experience with
LibreOffice, you can't expect people to know all the details with such a
complex software. And no, we don't make the software from scratch, not only
because QA doesn't write software, but also because the history of this
software started more than 30 years ago.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: [libreoffice-design] System theme or branded theme

[jan]

Hello,

I like that concerns like:
- almost invisible elements
- color clashes
- Icon sizes…
are tackled.

However, I think it is still important to play along the basic visual
rules of the host OS. Firefox, as you [Heiko] mentions, archives a good
compromise there: It always looks like Firefox, but it blends in really
well and will adapt the basic colors of the host OS.

Jan

Am 24.03.2017 um 22:15 schrieb Heiko Tietze:
> In tdf#106756 [1] the fundamental idea to blend LibreOffice well into the 
> system theme is challenged. While we may be able to solve most of the issues 
> the idea is tempting to have a unique look and feel with the possibility to 
> customize the default according the system. Something like Mozilla does in 
> Firefox with Auralis [2].
> 
> Would be good to get opinions on the ticket.
> 
> [1] https://bugs.documentfoundation.org/show_bug.cgi?id=106756
> [2] 
> https://blog.mozilla.org/ux/2013/11/australis-is-landing-in-firefox-nightly/
> 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 106695] German translation mistake "Text Abtand" instead of " Textabstand"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106695

--- Comment #10 from gilward.ku...@gmail.com ---
After you have registered at Pootle, you can suggest translation changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: editeng/qa

[Varun Dhall]

 editeng/qa/unit/core-test.cxx |  131 ++
 1 file changed, 131 insertions(+)

New commits:
commit 07c8e72b8e391fb0167e1e588d1884a247d5d58a
Author: Varun Dhall 
Date:   Thu Mar 23 20:11:28 2017 +0530

Added Test for EditEngine - Copy/Paste with Hyperlinks in Text

Change-Id: Iabe11ddac346f1c48b355c21797c11de8db54b1f
Reviewed-on: https://gerrit.libreoffice.org/35593
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/editeng/qa/unit/core-test.cxx b/editeng/qa/unit/core-test.cxx
index 98bfacf0d5a9..9f8421048b86 100644
--- a/editeng/qa/unit/core-test.cxx
+++ b/editeng/qa/unit/core-test.cxx
@@ -54,6 +54,9 @@ public:
 /// AutoCorrect tests
 void testAutocorrect();
 
+/// Test Copy/Paste with hyperlinks in text using Legacy Format
+void testHyperlinkCopyPaste();
+
 /// Test Copy/Paste using Legacy Format
 void testCopyPaste();
 
@@ -75,6 +78,7 @@ public:
 CPPUNIT_TEST(testConstruction);
 CPPUNIT_TEST(testUnoTextFields);
 CPPUNIT_TEST(testAutocorrect);
+CPPUNIT_TEST(testHyperlinkCopyPaste);
 CPPUNIT_TEST(testCopyPaste);
 CPPUNIT_TEST(testTabsCopyPaste);
 CPPUNIT_TEST(testHyperlinkSearch);
@@ -383,6 +387,133 @@ void Test::testAutocorrect()
 }
 }
 
+void Test::testHyperlinkCopyPaste()
+{
+// Create EditEngine's instance
+EditEngine aEditEngine( mpItemPool );
+
+// Get EditDoc for current EditEngine's instance
+EditDoc  = aEditEngine.GetEditDoc();
+
+// New instance must be empty - no initial text
+CPPUNIT_ASSERT_EQUAL( sal_uLong(0), rDoc.GetTextLen() );
+CPPUNIT_ASSERT_EQUAL( OUString(""), rDoc.GetParaAsString(sal_Int32(0)) );
+
+// Get corresponding Field Item for inserting URLs in text
+// URL 1
+OUString aURL1 = "mailto:///u...@example.com;;
+OUString aRepres1 = "u...@example.com";
+SvxURLField aURLField1( aURL1, aRepres1, SVXURLFORMAT_REPR );
+SvxFieldItem aField1( aURLField1, EE_FEATURE_FIELD );
+// URL 2
+OUString aURL2 = "mailto:///exam...@domain.com;;
+OUString aRepres2 = "exam...@domain.com";
+SvxURLField aURLField2( aURL2, aRepres2, SVXURLFORMAT_REPR );
+SvxFieldItem aField2( aURLField2, EE_FEATURE_FIELD );
+
+// Insert initial text
+OUString aParaText = "sampletextfortestingfeaturefields";
+// Positions Ref  .*13*20..
+sal_Int32 aTextLen = aParaText.getLength();
+aEditEngine.SetText( aParaText );
+
+// Assert changes
+CPPUNIT_ASSERT_EQUAL( sal_uLong(aTextLen), rDoc.GetTextLen() );
+CPPUNIT_ASSERT_EQUAL( aParaText, rDoc.GetParaAsString(sal_Int32(0)) );
+
+// Insert URL 1
+ContentNode *pNode = rDoc.GetObject(0);
+EditSelection aSel1( EditPaM(pNode, 13), EditPaM(pNode, 13) );
+aEditEngine.InsertField( aSel1, aField1 );
+
+// Assert Field Count
+CPPUNIT_ASSERT_EQUAL( sal_uInt16(1), aEditEngine.GetFieldCount(0) );
+
+// Insert URL 2
+EditSelection aSel2( EditPaM(pNode, 20 + 1), EditPaM(pNode, 20 + 1) );
+aEditEngine.InsertField( aSel2, aField2 );
+
+// Assert Field Count
+CPPUNIT_ASSERT_EQUAL( sal_uInt16(2), aEditEngine.GetFieldCount(0) );
+
+// Update Fields
+aEditEngine.UpdateFields();
+
+// Assert URL Fields and text before copy
+// Check text
+CPPUNIT_ASSERT_EQUAL( sal_uLong(aTextLen + 2), rDoc.GetTextLen() );
+CPPUNIT_ASSERT_EQUAL( OUString("sampletextfor testing featurefields"), 
rDoc.GetParaAsString(sal_Int32(0)) );
+
+// Check Field 1
+EFieldInfo aURLFieldInfo1 = aEditEngine.GetFieldInfo( sal_Int32(0), 
sal_uInt16(0) );
+CPPUNIT_ASSERT_EQUAL( sal_Int32(13), aURLFieldInfo1.aPosition.nIndex );
+CPPUNIT_ASSERT_EQUAL( sal_uInt16(EE_FEATURE_FIELD), 
aURLFieldInfo1.pFieldItem->Which() );
+SvxURLField* pURLField1 = dynamic_cast ( 
const_cast (aURLFieldInfo1.pFieldItem->GetField()) );
+CPPUNIT_ASSERT_EQUAL( aURL1, pURLField1->GetURL() );
+CPPUNIT_ASSERT_EQUAL( aRepres1, pURLField1->GetRepresentation() );
+
+// Check Field 2
+EFieldInfo aURLFieldInfo2 = aEditEngine.GetFieldInfo( sal_Int32(0), 
sal_uInt16(1) );
+CPPUNIT_ASSERT_EQUAL( sal_Int32(21), aURLFieldInfo2.aPosition.nIndex );
+CPPUNIT_ASSERT_EQUAL( sal_uInt16(EE_FEATURE_FIELD), 
aURLFieldInfo2.pFieldItem->Which() );
+SvxURLField* pURLField2 = dynamic_cast ( 
const_cast (aURLFieldInfo2.pFieldItem->GetField()) );
+CPPUNIT_ASSERT_EQUAL( aURL2, pURLField2->GetURL() );
+CPPUNIT_ASSERT_EQUAL( aRepres2, pURLField2->GetRepresentation() );
+
+// Copy text using legacy format
+uno::Reference< datatransfer::XTransferable > xData = 
aEditEngine.CreateTransferable( ESelection(0,10,0,21) );
+
+// Paste text at the end
+aEditEngine.InsertText( xData, OUString(), rDoc.GetEndPaM(), true );
+
+// Assert Changes ACP, ACP: after Copy/Paste
+
+

Re: [Libreoffice-qa] Pre-released 5.3.2.1, no Win x64 available.

[Pedro]

carlo.strata wrote
> Hi Everyone,
> 
> I confirm no Win64 builds here:
> http://dev-builds.libreoffice.org/pre-releases/win/x86_64/
> for the 5.3.2.1 version...
> 
> What's the trouble?

From
http://nabble.documentfoundation.org/Libreoffice-qa-minutes-of-ESC-call-td4210895.html


Michael Meeks-5 wrote
> * Release Engineering update (Christian)
> + 5.3.2 RC1
> + now built – had a nasty Java issue with architecture confusion:
>   win64 and win32 java on the same machine
> + reverted the patch for RC1
> + fixed this now (Michael S)
> + turns out #ifdef WIN32 and #ifdef WIN64 are both defined at
>   the same time in some fun way.
> + binaries are up-loaded for all but win64 to the server.
> + had a Mac signing issue (Norbert)
> + had a patch for that, would welcome review.
>   https://gerrit.libreoffice.org/#/c/35542
> + ignores double signing warning.
> + 5.3.2 RC2
> + due next week.
>  

My understanding is that there won't be an x64 RC1 but the x64 RC2 will be
available next week.



--
View this message in context: 
http://nabble.documentfoundation.org/Pre-released-5-3-2-1-no-Win-x64-available-tp4210807p4210997.html
Sent from the QA mailing list archive at Nabble.com.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 105497] [META] Regressions introduced by Revert " Reverts a commit series that cripple windows ci."

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105497

Aron Budea  changed:

   What|Removed |Added

 Depends on||106080


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106080
[Bug 106080] Find and replace by format, font color "Automatic" is not accepted
except after changing to another color
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: editeng/qa

[Varun Dhall]

 editeng/qa/unit/core-test.cxx |   57 ++
 1 file changed, 57 insertions(+)

New commits:
commit 0115a5f908d2280d39381e616cec262fabf07ea0
Author: Varun Dhall 
Date:   Thu Mar 23 14:42:40 2017 +0530

Added Test for EditEngine - Copy/Paste with Tabs in Text

Change-Id: If40dabc53d35c01e61f8a17799f26e6ef9fd6b08
Reviewed-on: https://gerrit.libreoffice.org/35579
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/editeng/qa/unit/core-test.cxx b/editeng/qa/unit/core-test.cxx
index f62430c18b64..98bfacf0d5a9 100644
--- a/editeng/qa/unit/core-test.cxx
+++ b/editeng/qa/unit/core-test.cxx
@@ -57,6 +57,9 @@ public:
 /// Test Copy/Paste using Legacy Format
 void testCopyPaste();
 
+/// Test Copy/Paste with Tabs
+void testTabsCopyPaste();
+
 /// Test hyperlinks
 void testHyperlinkSearch();
 
@@ -73,6 +76,7 @@ public:
 CPPUNIT_TEST(testUnoTextFields);
 CPPUNIT_TEST(testAutocorrect);
 CPPUNIT_TEST(testCopyPaste);
+CPPUNIT_TEST(testTabsCopyPaste);
 CPPUNIT_TEST(testHyperlinkSearch);
 CPPUNIT_TEST(testBoldItalicCopyPaste);
 CPPUNIT_TEST(testUnderlineCopyPaste);
@@ -411,6 +415,59 @@ void Test::testCopyPaste()
 CPPUNIT_ASSERT_EQUAL( OUString(aText + aText), 
rDoc.GetParaAsString(sal_Int32(0)) );
 }
 
+void Test::testTabsCopyPaste()
+{
+// Create EditEngine's instance
+EditEngine aEditEngine( mpItemPool );
+
+// Get EditDoc for current EditEngine's instance
+EditDoc  = aEditEngine.GetEditDoc();
+
+// New instance must be empty - no initial text
+CPPUNIT_ASSERT_EQUAL( sal_uLong(0), rDoc.GetTextLen() );
+CPPUNIT_ASSERT_EQUAL( OUString(""), rDoc.GetParaAsString(sal_Int32(0)) );
+
+// Get corresponding Item for inserting tabs in the text
+SfxVoidItem aTab( EE_FEATURE_TAB );
+
+// Insert initial text
+OUString aParaText = "sampletextfortestingtab";
+// Positions Ref  ..*6...*23
+sal_Int32 aTextLen = aParaText.getLength();
+aEditEngine.SetText( aParaText );
+
+// Assert changes
+CPPUNIT_ASSERT_EQUAL( sal_uLong(aTextLen), rDoc.GetTextLen() );
+CPPUNIT_ASSERT_EQUAL( aParaText, rDoc.GetParaAsString(sal_Int32(0)) );
+
+// Insert tab 1 at desired position
+ContentNode *pNode = rDoc.GetObject(0);
+EditSelection aSel1( EditPaM(pNode, 6), EditPaM(pNode, 6) );
+aEditEngine.InsertFeature( aSel1, aTab );
+
+// Assert changes
+CPPUNIT_ASSERT_EQUAL( sal_uLong(aTextLen + 1), rDoc.GetTextLen() );
+CPPUNIT_ASSERT_EQUAL( OUString("sample\ttextfortestingtab"), 
rDoc.GetParaAsString(sal_Int32(0)) );
+
+// Insert tab 2 at desired position
+EditSelection aSel2( EditPaM(pNode, 23+1), EditPaM(pNode, 23+1) );
+aEditEngine.InsertFeature( aSel2, aTab );
+
+// Assert changes
+CPPUNIT_ASSERT_EQUAL( sal_uLong(aTextLen + 2), rDoc.GetTextLen() );
+CPPUNIT_ASSERT_EQUAL( OUString("sample\ttextfortestingtab\t"), 
rDoc.GetParaAsString(sal_Int32(0)) );
+
+// Copy text using legacy format
+uno::Reference< datatransfer::XTransferable > xData = 
aEditEngine.CreateTransferable( ESelection(0,6,0,aTextLen+2) );
+
+// Paste text at the end
+aEditEngine.InsertText( xData, OUString(), rDoc.GetEndPaM(), true );
+
+// Assert changes
+CPPUNIT_ASSERT_EQUAL( sal_uLong(aTextLen + aTextLen - 6 + 4 ), 
rDoc.GetTextLen() );
+CPPUNIT_ASSERT_EQUAL( 
OUString("sample\ttextfortestingtab\t\ttextfortestingtab\t"), 
rDoc.GetParaAsString(sal_Int32(0)) );
+}
+
 namespace {
 class UrlEditEngine : public EditEngine
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106080] Find and replace by format, font color "Automatic" is not accepted except after changing to another color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106080

Aron Budea  changed:

   What|Removed |Added

 Blocks||105497


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105497
[Bug 105497] [META] Regressions introduced by Revert "Reverts a commit series
that cripple windows ci."
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: starmath/inc starmath/source

[Takeshi Abe]

 starmath/inc/parse.hxx|2 +-
 starmath/source/parse.cxx |   29 +++--
 2 files changed, 12 insertions(+), 19 deletions(-)

New commits:
commit 075585928cc77cb53cce675d13dd7d55de8aa122
Author: Takeshi Abe 
Date:   Fri Mar 24 12:02:22 2017 +0900

starmath: Make SmParser::DoAlign() return SmNode

instead of pushing it to the stack, for later refactoring.

Change-Id: I61760fbfe95771dede62f90f82df3e9961efdcd6
Reviewed-on: https://gerrit.libreoffice.org/35609
Tested-by: Jenkins 
Reviewed-by: Takeshi Abe 

diff --git a/starmath/inc/parse.hxx b/starmath/inc/parse.hxx
index 8872b8edac9a..43b84bab221c 100644
--- a/starmath/inc/parse.hxx
+++ b/starmath/inc/parse.hxx
@@ -76,7 +76,7 @@ class SmParser
 SmOperNode *DoOperator();
 SmNode *DoOper();
 SmStructureNode *DoUnOper();
-voidDoAlign();
+SmNode *DoAlign();
 SmStructureNode *DoFontAttribut();
 SmAttributNode *DoAttribut();
 SmStructureNode *DoFont();
diff --git a/starmath/source/parse.cxx b/starmath/source/parse.cxx
index 4ba51289bf1b..3effa80d1ed4 100644
--- a/starmath/source/parse.cxx
+++ b/starmath/source/parse.cxx
@@ -963,7 +963,7 @@ SmTableNode *SmParser::DoTable()
 return pSNode.release();
 }
 
-void SmParser::DoAlign()
+SmNode *SmParser::DoAlign()
 // parse alignment info (if any), then go on with rest of expression
 {
 std::unique_ptr pSNode;
@@ -976,10 +976,7 @@ void SmParser::DoAlign()
 
 // allow for just one align statement in 5.0
 if (TokenInGroup(TG::Align))
-{
-Error(SmParseError::DoubleAlign);
-return;
-}
+return DoError(SmParseError::DoubleAlign);
 }
 
 std::unique_ptr pNode(DoExpression());
@@ -987,10 +984,9 @@ void SmParser::DoAlign()
 if (pSNode)
 {
 pSNode->SetSubNode(0, pNode.release());
-m_aNodeStack.push_front(std::move(pSNode));
+return pSNode.release();
 }
-else
-m_aNodeStack.push_front(std::move(pNode));
+return pNode.release();
 }
 
 void SmParser::DoLine()
@@ -1001,10 +997,7 @@ void SmParser::DoLine()
 // (and go on with expressions that must not have alignment
 // statements in 'while' loop below. See also 'Expression()'.)
 if (m_aCurToken.eType != TEND  &&  m_aCurToken.eType != TNEWLINE)
-{
-DoAlign();
-ExpressionArray.push_back(popOrZero(m_aNodeStack));
-}
+ExpressionArray.push_back(DoAlign());
 
 while (m_aCurToken.eType != TEND  &&  m_aCurToken.eType != TNEWLINE)
 ExpressionArray.push_back(DoExpression());
@@ -1304,7 +1297,7 @@ SmNode *SmParser::DoTerm(bool bGroupNumberIdent)
 return pSNode.release();
 }
 // go as usual
-DoAlign();
+m_aNodeStack.emplace_front(DoAlign());
 if (m_aCurToken.eType != TRGROUP)
 return DoError(SmParseError::RgroupExpected);
 NextToken();
@@ -1984,7 +1977,7 @@ SmBracebodyNode *SmParser::DoBracebody(bool bIsLeftRight)
 }
 else if (m_aCurToken.eType != TRIGHT)
 {
-DoAlign();
+m_aNodeStack.emplace_front(DoAlign());
 nNum++;
 
 if (m_aCurToken.eType != TMLINE  &&  m_aCurToken.eType != 
TRIGHT)
@@ -2004,7 +1997,7 @@ SmBracebodyNode *SmParser::DoBracebody(bool bIsLeftRight)
 }
 else if (!TokenInGroup(TG::RBrace))
 {
-DoAlign();
+m_aNodeStack.emplace_front(DoAlign());
 nNum++;
 
 if (m_aCurToken.eType != TMLINE  &&  !TokenInGroup(TG::RBrace))
@@ -2087,7 +2080,7 @@ SmStructureNode *SmParser::DoStack()
 do
 {
 NextToken();
-DoAlign();
+m_aNodeStack.emplace_front(DoAlign());
 n++;
 }
 while (m_aCurToken.eType == TPOUND);
@@ -2120,7 +2113,7 @@ SmStructureNode *SmParser::DoMatrix()
 do
 {
 NextToken();
-DoAlign();
+m_aNodeStack.emplace_front(DoAlign());
 c++;
 }
 while (m_aCurToken.eType == TPOUND);
@@ -2132,7 +2125,7 @@ SmStructureNode *SmParser::DoMatrix()
 NextToken();
 for (sal_uInt16 i = 0; i < c; i++)
 {
-DoAlign();
+m_aNodeStack.emplace_front(DoAlign());
 if (i < (c - 1))
 {
 if (m_aCurToken.eType == TPOUND)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: editeng/qa

[Varun Dhall]

 editeng/qa/unit/core-test.cxx |  125 ++
 1 file changed, 125 insertions(+)

New commits:
commit cfe2411ae0d2deb84408a13397659ef0389df045
Author: Varun Dhall 
Date:   Wed Mar 15 17:23:32 2017 +0530

Added Test for EditEngine - Copy/Paste using Underline Text

Just because Underline is as important as Bold/Italic we cannot skip a test 
for it :)

Change-Id: I6c240a3232cf97794c8265afe66f58ce6f68fa43
Reviewed-on: https://gerrit.libreoffice.org/35217
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/editeng/qa/unit/core-test.cxx b/editeng/qa/unit/core-test.cxx
index e7c2035959db..f62430c18b64 100644
--- a/editeng/qa/unit/core-test.cxx
+++ b/editeng/qa/unit/core-test.cxx
@@ -27,6 +27,7 @@
 #include "editeng/section.hxx"
 #include "editeng/editobj.hxx"
 #include "editeng/flditem.hxx"
+#include "editeng/udlnitem.hxx"
 #include "svl/srchitem.hxx"
 
 #include 
@@ -62,6 +63,9 @@ public:
 /// Test Copy/Paste with Bold/Italic text using Legacy Format
 void testBoldItalicCopyPaste();
 
+/// Test Copy/Paste with Underline text using Legacy Format
+void testUnderlineCopyPaste();
+
 void testSectionAttributes();
 
 CPPUNIT_TEST_SUITE(Test);
@@ -71,6 +75,7 @@ public:
 CPPUNIT_TEST(testCopyPaste);
 CPPUNIT_TEST(testHyperlinkSearch);
 CPPUNIT_TEST(testBoldItalicCopyPaste);
+CPPUNIT_TEST(testUnderlineCopyPaste);
 CPPUNIT_TEST(testSectionAttributes);
 CPPUNIT_TEST_SUITE_END();
 
@@ -710,6 +715,126 @@ void Test::testBoldItalicCopyPaste()
 CPPUNIT_ASSERT_EQUAL( 0, (int)pSecAttr->maAttributes.size() );
 }
 
+// Auxiliary function to test Underline text Copy/Paste using Legacy Format
+bool hasUnderline(const editeng::Section& rSecAttr)
+{
+std::vector::const_iterator it = 
rSecAttr.maAttributes.begin(), itEnd = rSecAttr.maAttributes.end();
+for (; it != itEnd; ++it)
+{
+const SfxPoolItem* p = *it;
+if (p->Which() != EE_CHAR_UNDERLINE)
+continue;
+
+if (static_cast(p)->GetLineStyle() != 
LINESTYLE_SINGLE)
+continue;
+
+return true;
+}
+return false;
+}
+
+void Test::testUnderlineCopyPaste()
+{
+// Create EditEngine's instance
+EditEngine aEditEngine( mpItemPool );
+
+// Get EditDoc for current EditEngine's instance
+EditDoc  = aEditEngine.GetEditDoc();
+
+// New instance must be empty - no initial text
+CPPUNIT_ASSERT_EQUAL( sal_uLong(0), rDoc.GetTextLen() );
+CPPUNIT_ASSERT_EQUAL( OUString(""), rDoc.GetParaAsString(sal_Int32(0)) );
+
+// Get corresponding ItemSet for inserting Underline text
+std::unique_ptr pSet( new 
SfxItemSet(aEditEngine.GetEmptyItemSet()) );
+SvxUnderlineItem aULine( LINESTYLE_SINGLE, EE_CHAR_UNDERLINE );
+
+// Insert initial text
+OUString aParaText = "sampletextforunderline";
+// Positions Ref  ..*6.*17..
+// Underline Ref  ..[UNDERLINE ]
+sal_Int32 aTextLen = aParaText.getLength();
+aEditEngine.SetText( aParaText );
+
+// Apply Underline style
+pSet->Put( aULine );
+CPPUNIT_ASSERT_EQUAL( static_cast(1), pSet->Count() );
+aEditEngine.QuickSetAttribs( *pSet, ESelection(0,6,0,18) );
+
+// Assert changes
+std::unique_ptr pEditText1( aEditEngine.CreateTextObject() 
);
+std::vector aAttrs1;
+pEditText1->GetAllSections( aAttrs1 );
+
+// There should be 3 sections - woUnderline - wUnderline - woUnderline (w 
- with, wo - without)
+size_t nSecCountCheck1 = 3;
+CPPUNIT_ASSERT_EQUAL( nSecCountCheck1, aAttrs1.size() );
+
+const editeng::Section* pSecAttr = [0];
+CPPUNIT_ASSERT_EQUAL( 0, (int)pSecAttr->mnParagraph );
+CPPUNIT_ASSERT_EQUAL( 0, (int)pSecAttr->mnStart );
+CPPUNIT_ASSERT_EQUAL( 6, (int)pSecAttr->mnEnd );
+CPPUNIT_ASSERT_EQUAL( 0, (int)pSecAttr->maAttributes.size() );
+
+pSecAttr = [1];
+CPPUNIT_ASSERT_EQUAL( 0, (int)pSecAttr->mnParagraph );
+CPPUNIT_ASSERT_EQUAL( 6, (int)pSecAttr->mnStart );
+CPPUNIT_ASSERT_EQUAL( 18, (int)pSecAttr->mnEnd );
+CPPUNIT_ASSERT_EQUAL( 1, (int)pSecAttr->maAttributes.size() );
+CPPUNIT_ASSERT_MESSAGE( "This section must be underlined.", 
hasUnderline(*pSecAttr) );
+
+pSecAttr = [2];
+CPPUNIT_ASSERT_EQUAL( 0, (int)pSecAttr->mnParagraph );
+CPPUNIT_ASSERT_EQUAL( 18, (int)pSecAttr->mnStart );
+CPPUNIT_ASSERT_EQUAL( 22, (int)pSecAttr->mnEnd );
+CPPUNIT_ASSERT_EQUAL( 0, (int)pSecAttr->maAttributes.size() );
+
+// Copy text using legacy format
+uno::Reference< datatransfer::XTransferable > xData = 
aEditEngine.CreateTransferable( ESelection(0,6,0,aTextLen-4) );
+
+// Paste text at the end
+aEditEngine.InsertText( xData, OUString(), rDoc.GetEndPaM(), true );
+
+// Assert changes
+CPPUNIT_ASSERT_EQUAL( sal_uLong(aTextLen + 
(OUString("textforunder")).getLength()), rDoc.GetTextLen() );
+ 

[Libreoffice-commits] core.git: external/hunspell

[László Németh]

 external/hunspell/0002-fix-other-regression-in-compounding.patch | 
  43 ++
 external/hunspell/0005-fix-syllable-counting-in-compound-word-handling.patch | 
  66 ++
 external/hunspell/UnpackedTarball_hunspell.mk| 
   2 
 3 files changed, 111 insertions(+)

New commits:
commit 3bc686ca3e746560770bfe24cd0b515cfdf83bd1
Author: László Németh 
Date:   Fri Mar 24 15:26:49 2017 +0100

tdf#106751 fix regressions in Hungarian spell checking

using recent fixes of Hunspell code base

Change-Id: I180a2ecba924180419c5eb1a0e78b5c84e7242c4
Reviewed-on: https://gerrit.libreoffice.org/35665
Tested-by: Jenkins 
Reviewed-by: László Németh 
Tested-by: László Németh 

diff --git a/external/hunspell/0002-fix-other-regression-in-compounding.patch 
b/external/hunspell/0002-fix-other-regression-in-compounding.patch
new file mode 100644
index ..cbf29e54f93a
--- /dev/null
+++ b/external/hunspell/0002-fix-other-regression-in-compounding.patch
@@ -0,0 +1,43 @@
+From 1fada01663b29b57c010a9c274e45a5cf9ecf222 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?L=C3=A1szl=C3=B3=20N=C3=A9meth?=
+ 
+Date: Sun, 19 Mar 2017 13:19:29 +0100
+Subject: [PATCH 2/7] fix other regression in compounding
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Allow compound words again with
+starting "kor", "alak", "asszony", "úr"
+related to the "REP kor _kor" etc. rules
+using the Hungarian spelling dictionary.
+
+regression from...
+
+commit 73b1cad1af7ab94252f75784fa6724cf062a6966
+Author: Martin Hosken 
+Date:   Mon Apr 18 16:28:26 2016 +0700
+
+Add support for bounded conversion
+---
+ src/hunspell/affixmgr.cxx | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/src/hunspell/affixmgr.cxx b/src/hunspell/affixmgr.cxx
+index 78c70e7..ec2093d 100644
+--- a/src/hunspell/affixmgr.cxx
 b/src/hunspell/affixmgr.cxx
+@@ -1290,8 +1290,8 @@ int AffixMgr::cpdrep_check(const char* word, int wl) {
+ // search every occurence of the pattern in the word
+ while ((r = strstr(r, reptable[i].pattern.c_str())) != NULL) {
+   std::string candidate(word);
+-  size_t type = r == word ? 1 : 0;
+-  if (r - word + reptable[i].pattern.size() == lenp)
++  size_t type = r == word && langnum != LANG_hu ? 1 : 0;
++  if (r - word + reptable[i].pattern.size() == lenp && langnum != LANG_hu)
+ type += 2;
+   candidate.replace(r - word, lenp, reptable[i].outstrings[type]);
+   if (candidate_check(candidate.c_str(), candidate.size()))
+-- 
+2.7.4
+
diff --git 
a/external/hunspell/0005-fix-syllable-counting-in-compound-word-handling.patch 
b/external/hunspell/0005-fix-syllable-counting-in-compound-word-handling.patch
new file mode 100644
index ..670d938e5441
--- /dev/null
+++ 
b/external/hunspell/0005-fix-syllable-counting-in-compound-word-handling.patch
@@ -0,0 +1,66 @@
+From f4ec6a283f972c82d068f4472320d424c40d45cb Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?L=C3=A1szl=C3=B3=20N=C3=A9meth?=
+ 
+Date: Thu, 23 Mar 2017 16:40:52 +0100
+Subject: [PATCH 5/7] fix syllable counting in compound word handling
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Note: one of the fixed regressions is related to an old
+hidden mistake: using clen instead of blen of the stem
+word lengths was indifferent with the original get_syllable(),
+because blen == clen at 8-bit encodings, and UTF-8
+words were handled by null-termination. Implementing Unicode
+support in Hunspell, clen was changed only in
+compound_check_morph() to blen accidentally, but not
+in compound_check(), resulting problems from the
+recent std::string conversion.
+
+Now this commit is a real fix for the regression from the
+commit c63c93237e4decdba5544a96093448605ac549c2,
+instead of the following bad fix:
+
+commit d06b0c57ae87ee8743f1bf53f80c1f8e364db619
+Author: László Németh 
+Date:   Fri Mar 17 15:11:23 2017 +0100
+
+fix Hungarian compound word handling
+---
+ src/hunspell/affixmgr.cxx | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/src/hunspell/affixmgr.cxx b/src/hunspell/affixmgr.cxx
+index 2ed8233..3d65539 100644
+--- a/src/hunspell/affixmgr.cxx
 b/src/hunspell/affixmgr.cxx
+@@ -1816,7 +1816,7 @@ struct hentry* AffixMgr::compound_check(const 
std::string& word,
+   // LANG_hu section: spec. Hungarian rule
+   if (langnum == LANG_hu) {
+ // calculate syllable number of the word
+-numsyllable += get_syllable(st.substr(i));
++numsyllable += get_syllable(st.substr(0, i));
+ // + 1 word, if syllable number of the prefix > 1 (hungarian
+ // 

[Libreoffice-ux-advise] [Bug 106756] Default Theme and Icon Set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106756

LibreTraining  changed:

   What|Removed |Added

 CC||libretraining.tutorials@gma
   ||il.com

--- Comment #5 from LibreTraining  ---
Sounds like a great idea.
Makes perfect sense.
Consistency is one of the stated UX goals.

Why would any of this be controversial?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 106756] Default Theme and Icon Set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106756

LibreTraining  changed:

   What|Removed |Added

 CC||libretraining.tutorials@gma
   ||il.com

--- Comment #5 from LibreTraining  ---
Sounds like a great idea.
Makes perfect sense.
Consistency is one of the stated UX goals.

Why would any of this be controversial?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

System theme or branded theme

[Heiko Tietze]

In tdf#106756 [1] the fundamental idea to blend LibreOffice well into the 
system theme is challenged. While we may be able to solve most of the issues 
the idea is tempting to have a unique look and feel with the possibility to 
customize the default according the system. Something like Mozilla does in 
Firefox with Auralis [2].

Would be good to get opinions on the ticket.

[1] https://bugs.documentfoundation.org/show_bug.cgi?id=106756
[2] https://blog.mozilla.org/ux/2013/11/australis-is-landing-in-firefox-nightly/
-- 
Dr. Heiko Tietze
UX Designer
Tel. +49 (0)179/1268509



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/source

[Michael Stahl]

 sw/source/core/access/acccell.cxx |6 +-
 sw/source/core/access/acccontext.cxx  |   26 ++--
 sw/source/core/access/acccontext.hxx  |   15 -
 sw/source/core/access/accdoc.cxx  |7 +-
 sw/source/core/access/accfootnote.cxx |2 
 sw/source/core/access/accheaderfooter.cxx |2 
 sw/source/core/access/accnotextframe.cxx  |9 +--
 sw/source/core/access/accpage.cxx |2 
 sw/source/core/access/accpara.cxx |   90 --
 sw/source/core/access/acctable.cxx|   47 ---
 sw/source/core/access/acctextframe.cxx|7 +-
 11 files changed, 116 insertions(+), 97 deletions(-)

New commits:
commit c7b74fd04e4020428217f0d9e6104c0a2b4ab790
Author: Michael Stahl 
Date:   Fri Mar 24 21:50:29 2017 +0100

sw: remove CHECK_FOR_DEFUNC macros

Change-Id: I317b5fcd6e5753b4f854930ed4f4ceea53a385c4

diff --git a/sw/source/core/access/acccell.cxx 
b/sw/source/core/access/acccell.cxx
index 85b733f74bcd..824169db9604 100644
--- a/sw/source/core/access/acccell.cxx
+++ b/sw/source/core/access/acccell.cxx
@@ -341,7 +341,8 @@ SwFrameFormat* SwAccessibleCell::GetTableBoxFormat() const
 uno::Any SwAccessibleCell::getCurrentValue( )
 {
 SolarMutexGuard aGuard;
-CHECK_FOR_DEFUNC( XAccessibleValue );
+
+ThrowIfDisposed();
 
 return uno::Any( GetTableBoxFormat()->GetTableBoxValue().GetValue() );
 }
@@ -349,7 +350,8 @@ uno::Any SwAccessibleCell::getCurrentValue( )
 sal_Bool SwAccessibleCell::setCurrentValue( const uno::Any& aNumber )
 {
 SolarMutexGuard aGuard;
-CHECK_FOR_DEFUNC( XAccessibleValue );
+
+ThrowIfDisposed();
 
 double fValue = 0;
 bool bValid = (aNumber >>= fValue);
diff --git a/sw/source/core/access/acccontext.cxx 
b/sw/source/core/access/acccontext.cxx
index bedbb8c7a813..5bc41b44b0bf 100644
--- a/sw/source/core/access/acccontext.cxx
+++ b/sw/source/core/access/acccontext.cxx
@@ -530,6 +530,15 @@ bool SwAccessibleContext::IsEditableState()
 return bRet;
 }
 
+void SwAccessibleContext::ThrowIfDisposed()
+{
+if (!(GetFrame() && GetMap()))
+{
+throw lang::DisposedException("object is nonfunctional",
+static_cast(this));
+}
+}
+
 SwAccessibleContext::SwAccessibleContext(std::shared_ptr 
const& pMap,
   sal_Int16 const nRole,
   const SwFrame *pF )
@@ -571,7 +580,8 @@ sal_Int32 SAL_CALL 
SwAccessibleContext::getAccessibleChildCount()
 {
 SolarMutexGuard aGuard;
 
-CHECK_FOR_DEFUNC( XAccessibleContext )
+ThrowIfDisposed();
+
 //Notify the frame is a document
 if (m_nRole == AccessibleRole::DOCUMENT_TEXT)
 m_bIsAccDocUse = true;
@@ -584,7 +594,7 @@ uno::Reference< XAccessible> SAL_CALL
 {
 SolarMutexGuard aGuard;
 
-CHECK_FOR_DEFUNC( XAccessibleContext )
+ThrowIfDisposed();
 
 //Notify the frame is a document
 if (m_nRole == AccessibleRole::DOCUMENT_TEXT)
@@ -631,7 +641,7 @@ uno::Reference< XAccessible> SAL_CALL 
SwAccessibleContext::getAccessibleParent()
 {
 SolarMutexGuard aGuard;
 
-CHECK_FOR_DEFUNC( XAccessibleContext )
+ThrowIfDisposed();
 
 const SwFrame *pUpper = GetParent();
 OSL_ENSURE( pUpper != nullptr || m_isDisposing, "no upper found" );
@@ -655,7 +665,7 @@ sal_Int32 SAL_CALL 
SwAccessibleContext::getAccessibleIndexInParent()
 {
 SolarMutexGuard aGuard;
 
-CHECK_FOR_DEFUNC( XAccessibleContext )
+ThrowIfDisposed();
 
 const SwFrame *pUpper = GetParent();
 OSL_ENSURE( pUpper != nullptr || m_isDisposing, "no upper found" );
@@ -696,7 +706,7 @@ uno::Reference SAL_CALL
 {
 SolarMutexGuard aGuard;
 
-CHECK_FOR_DEFUNC( XAccessibleContext )
+ThrowIfDisposed();
 
 ::utl::AccessibleStateSetHelper *pStateSet =
 new ::utl::AccessibleStateSetHelper;
@@ -776,7 +786,7 @@ uno::Reference< XAccessible > SAL_CALL 
SwAccessibleContext::getAccessibleAtPoint
 {
 SolarMutexGuard aGuard;
 
-CHECK_FOR_DEFUNC( XAccessibleComponent )
+ThrowIfDisposed();
 
 uno::Reference< XAccessible > xAcc;
 
@@ -834,7 +844,7 @@ awt::Rectangle SAL_CALL 
SwAccessibleContext::getBoundsImpl(bool bRelative)
 {
 SolarMutexGuard aGuard;
 
-CHECK_FOR_DEFUNC( XAccessibleComponent )
+ThrowIfDisposed();
 
 const SwFrame *pParent = GetParent();
 OSL_ENSURE( pParent, "no Parent found" );
@@ -923,7 +933,7 @@ void SAL_CALL SwAccessibleContext::grabFocus()
 {
 SolarMutexGuard aGuard;
 
-CHECK_FOR_DEFUNC( XAccessibleContext );
+ThrowIfDisposed();;
 
 if( GetFrame()->IsFlyFrame() )
 {
diff --git a/sw/source/core/access/acccontext.hxx 
b/sw/source/core/access/acccontext.hxx
index 1dc8b1972168..a316b7d0cad3 100644
--- a/sw/source/core/access/acccontext.hxx
+++ b/sw/source/core/access/acccontext.hxx
@@ -197,6 +197,8 @@ protected:
 }
 void RemoveFrameFromAccessibleMap();
 
+void ThrowIfDisposed();

[Libreoffice-ux-advise] [Bug 106756] Default Theme and Icon Set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106756

Heiko Tietze  changed:

   What|Removed |Added

   Keywords||needsDevAdvice, needsUXEval
 Status|UNCONFIRMED |NEW
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
Version|3.3.0 release   |unspecified
 Ever confirmed|0   |1

--- Comment #4 from Heiko Tietze  ---
Popcorn!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 106756] Default Theme and Icon Set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106756

Heiko Tietze  changed:

   What|Removed |Added

   Keywords||needsDevAdvice, needsUXEval
 Status|UNCONFIRMED |NEW
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
Version|3.3.0 release   |unspecified
 Ever confirmed|0   |1

--- Comment #4 from Heiko Tietze  ---
Popcorn!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104935] Crash with .PPS once slideshow is finished or after typing " Esc"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104935

Julien Nabet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #11 from Julien Nabet  ---
No crash with master sources updated today.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71732

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||106758


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106758
[Bug 106758] Weird display of combining diacritical acute accent mark
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106758] Weird display of combining diacritical acute accent mark

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106758

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||vstuart.fo...@utsa.edu
 Blocks||71732
 Ever confirmed|0   |1

--- Comment #2 from V Stuart Foote  ---
Believe that is a font fallback issue on Windows builds, should be fully
corrected at 5.3.1 release.

Please check the current 5.3.1 release (or 5.3.2 rc1 in pre-release)

=-ref-=
http://dev-builds.libreoffice.org/pre-releases/win/x86/

http://downloadarchive.documentfoundation.org/libreoffice/old/


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=71732
[Bug 71732] [META] Bugs related to text rendering, typography and font features
in LO
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106755] tifinagh rendering problems

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106755

V Stuart Foote  changed:

   What|Removed |Added

 CC||khaledho...@eglug.org,
   ||vstuart.fo...@utsa.edu
 Blocks||71732


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=71732
[Bug 71732] [META] Bugs related to text rendering, typography and font features
in LO
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71732

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||106755


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106755
[Bug 106755] tifinagh rendering problems
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94102] Impress saves as SWF but it's impossible play it

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94102

Ulrich Moser  changed:

   What|Removed |Added

   Hardware|All |x86-64 (AMD64)
Version|5.0.0.5 release |5.3.1.2 release
 OS|All |Linux (All)

--- Comment #5 from Ulrich Moser  ---
Also tru in Version: 5.3.1.2
Slide and animation timings are not respected

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/vcl vcl/source

[Miklos Vajna]

 include/vcl/filter/pdfdocument.hxx |5 +
 vcl/source/filter/ipdf/pdfdocument.cxx |   16 -
 vcl/source/gdi/pdfwriter_impl.cxx  |  100 -
 vcl/source/gdi/pdfwriter_impl.hxx  |3 
 4 files changed, 98 insertions(+), 26 deletions(-)

New commits:
commit f135a8bdeba15cf72dd31c7d613d335bbfc7017b
Author: Miklos Vajna 
Date:   Fri Mar 24 15:16:32 2017 +0100

tdf#106693 vcl PDF export, norefxobj: update XObject refs

Start copying referenced objects recursively, and also take care of
updating references to the object IDs as they appear in our output.

With this, the 4th image referenced from the PDF image has a correctly
updated reference in its dictionary's ColorSpace key.

Change-Id: I8b49701c1f60bd0ef5a097b24ce59164554c44fa
Reviewed-on: https://gerrit.libreoffice.org/35653
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins 

diff --git a/include/vcl/filter/pdfdocument.hxx 
b/include/vcl/filter/pdfdocument.hxx
index 135d30d8d8bb..fbfb81ed10a2 100644
--- a/include/vcl/filter/pdfdocument.hxx
+++ b/include/vcl/filter/pdfdocument.hxx
@@ -77,6 +77,8 @@ public:
 sal_uInt64 GetDictionaryLength();
 PDFDictionaryElement* GetDictionary() const;
 void SetDictionary(PDFDictionaryElement* pDictionaryElement);
+/// Get access to the parsed key-value items from the object dictionary.
+const std::map& GetDictionaryItems() const;
 void SetArray(PDFArrayElement* pArrayElement);
 void SetStream(PDFStreamElement* pStreamElement);
 /// Access to the stream of the object, if it has any.
@@ -109,6 +111,8 @@ class VCL_DLLPUBLIC PDFReferenceElement : public PDFElement
 PDFDocument& m_rDoc;
 int m_fObjectValue;
 int m_fGenerationValue;
+/// Location after the 'R' token.
+sal_uInt64 m_nOffset = 0;
 
 public:
 PDFReferenceElement(PDFDocument& rDoc, int fObjectValue, int 
fGenerationValue);
@@ -119,6 +123,7 @@ public:
 PDFObjectElement* LookupObject();
 int GetObjectValue() const;
 int GetGenerationValue() const;
+sal_uInt64 GetOffset() const;
 };
 
 /// Stream object: a byte array with a known length.
diff --git a/vcl/source/filter/ipdf/pdfdocument.cxx 
b/vcl/source/filter/ipdf/pdfdocument.cxx
index 900c5f281863..8744729fdd83 100644
--- a/vcl/source/filter/ipdf/pdfdocument.cxx
+++ b/vcl/source/filter/ipdf/pdfdocument.cxx
@@ -2224,7 +2224,10 @@ size_t PDFDictionaryElement::Parse(const std::vector< 
std::unique_ptrSetKeyOffset(aName, nNameOffset);
+pThisDictionary->SetKeyValueLength(aName, 
pReference->GetOffset() - nNameOffset);
+}
 aName.clear();
 }
 else
@@ -2421,6 +2424,11 @@ void 
PDFObjectElement::SetDictionary(PDFDictionaryElement* pDictionaryElement)
 m_pDictionaryElement = pDictionaryElement;
 }
 
+const std::map& PDFObjectElement::GetDictionaryItems() 
const
+{
+return m_aDictionary;
+}
+
 void PDFObjectElement::SetArray(PDFArrayElement* pArrayElement)
 {
 m_pArrayElement = pArrayElement;
@@ -2598,12 +2606,18 @@ PDFReferenceElement::PDFReferenceElement(PDFDocument& 
rDoc, int fObjectValue, in
 {
 }
 
-bool PDFReferenceElement::Read(SvStream& /*rStream*/)
+bool PDFReferenceElement::Read(SvStream& rStream)
 {
 SAL_INFO("vcl.filter", "PDFReferenceElement::Read: " << m_fObjectValue << 
" " << m_fGenerationValue << " R");
+m_nOffset = rStream.Tell();
 return true;
 }
 
+sal_uInt64 PDFReferenceElement::GetOffset() const
+{
+return m_nOffset;
+}
+
 double PDFReferenceElement::LookupNumber(SvStream& rStream) const
 {
 size_t nOffset = m_rDoc.GetObjectOffset(m_fObjectValue);
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index 3b7ee87f5e6c..061bc825d7a4 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -10852,6 +10852,77 @@ void PDFWriterImpl::writeJPG( JPGEmit& rObject )
 writeReferenceXObject(rObject.m_aReferenceXObject);
 }
 
+sal_Int32 PDFWriterImpl::copyExternalResource(SvMemoryStream& rDocBuffer, 
filter::PDFObjectElement& rObject)
+{
+sal_Int32 nObject = createObject();
+
+OStringBuffer aLine;
+aLine.append(nObject);
+aLine.append(" 0 obj\n");
+if (filter::PDFDictionaryElement* pDictionary = rObject.GetDictionary())
+{
+aLine.append("<<");
+
+// Complex case: can't copy the dictionary byte array as is, as it 
contains a reference.
+bool bDone = false;
+const std::map& rItems = 
rObject.GetDictionaryItems();
+OString aReferenceName("ColorSpace");
+auto it = rItems.find(aReferenceName);
+if (it != rItems.end())
+{
+auto pReference = 
dynamic_cast(it->second);
+if (pReference)
+{
+   

[Libreoffice-bugs] [Bug 106760] New: Missing way how to install non-English language support (Flatpak)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106760

Bug ID: 106760
   Summary: Missing way how to install non-English language
support (Flatpak)
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Linguistic
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: nesn...@email.cz

I've installed Flatpak LO version and there is no way how to get another spell
check language eg. Czech.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #39 from Andreas Säger  ---
Almost every Library shipped with LibreOffice shows the same problem as you can
prove by brwosing module by module and click the compile button.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.1' - 2 commits - desktop/CppunitTest_desktop_app.mk desktop/inc desktop/qa desktop/source include/LibreOfficeKit libreofficekit/qa vcl/sou

[Jan Holesovsky]

 desktop/CppunitTest_desktop_app.mk  |1 
 desktop/inc/lib/init.hxx|5 +
 desktop/qa/desktop_lib/test_desktop_lib.cxx |   30 +
 desktop/source/lib/init.cxx |   60 ++
 include/LibreOfficeKit/LibreOfficeKit.hxx   |4 +
 libreofficekit/qa/data/empty.ods|binary
 libreofficekit/qa/unit/tiledrendering.cxx   |   89 
 vcl/source/app/svapp.cxx|9 ++
 8 files changed, 197 insertions(+), 1 deletion(-)

New commits:
commit 87ab932064218ce209a05a34db1be5b69776a2f4
Author: Jan Holesovsky 
Date:   Fri Mar 24 16:23:02 2017 +0100

lok: Unit test for setting of the language during load of the document.

Change-Id: Idf4d3ba6b55be1f885f9d8fc89157e7e498d4e42

diff --git a/libreofficekit/qa/data/empty.ods b/libreofficekit/qa/data/empty.ods
new file mode 100644
index ..a36d1f97c405
Binary files /dev/null and b/libreofficekit/qa/data/empty.ods differ
diff --git a/libreofficekit/qa/unit/tiledrendering.cxx 
b/libreofficekit/qa/unit/tiledrendering.cxx
index 0a93c4651d77..ed94e72cbd33 100644
--- a/libreofficekit/qa/unit/tiledrendering.cxx
+++ b/libreofficekit/qa/unit/tiledrendering.cxx
@@ -67,6 +67,7 @@ public:
 void testImpressSlideNames( Office* pOffice );
 void testCalcSheetNames( Office* pOffice );
 void testPaintPartTile( Office* pOffice );
+void testDocumentLoadLanguage(Office* pOffice);
 #if 0
 void testOverlay( Office* pOffice );
 #endif
@@ -94,6 +95,7 @@ void TiledRenderingTest::runAllTests()
 testImpressSlideNames( pOffice.get() );
 testCalcSheetNames( pOffice.get() );
 testPaintPartTile( pOffice.get() );
+testDocumentLoadLanguage(pOffice.get());
 #if 0
 testOverlay( pOffice.get() );
 #endif
@@ -212,6 +214,93 @@ void TiledRenderingTest::testPaintPartTile(Office* pOffice)
 pDocument->paintPartTile(aBuffer.data(), /*nPart=*/0, nCanvasWidth, 
nCanvasHeight, /*nTilePosX=*/0, /*nTilePosY=*/0, /*nTileWidth=*/3840, 
/*nTileHeight=*/3840);
 }
 
+namespace {
+
+void processEventsToIdle()
+{
+typedef void (ProcessEventsToIdleFn)(void);
+static ProcessEventsToIdleFn *processFn = nullptr;
+if (!processFn)
+{
+void *me = dlopen(nullptr, RTLD_NOW);
+processFn = reinterpret_cast(dlsym(me, 
"unit_lok_process_events_to_idle"));
+}
+
+CPPUNIT_ASSERT(processFn);
+
+(*processFn)();
+}
+
+void insertString(Document& rDocument, const std::string& s)
+{
+for (const char c : s)
+{
+rDocument.postKeyEvent(LOK_KEYEVENT_KEYINPUT, c, 0);
+rDocument.postKeyEvent(LOK_KEYEVENT_KEYUP, c, 0);
+}
+processEventsToIdle();
+}
+
+}
+
+void TiledRenderingTest::testDocumentLoadLanguage(Office* pOffice)
+{
+const string sDocPath = m_sSrcRoot + "/libreofficekit/qa/data/empty.ods";
+const string sLockFile = m_sSrcRoot 
+"/libreofficekit/qa/data/.~lock.empty.ods#";
+
+// FIXME: LOK will fail when trying to open a locked file
+remove(sLockFile.c_str());
+
+// first try with the en-US locale
+std::unique_ptr 
pDocument(pOffice->documentLoad(sDocPath.c_str(), "Language=en-US"));
+
+// assert that '.' is the decimal separator
+insertString(*pDocument, "1.5");
+
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, 1027); // right arrow
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, 1027);
+processEventsToIdle();
+
+insertString(*pDocument, "=2*A1");
+
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, 1280); // enter
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, 1280);
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, 1025); // up arrow
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, 1025);
+processEventsToIdle();
+
+// we've got a meaningful result
+OString aResult = pDocument->getTextSelection("text/plain;charset=utf-8");
+CPPUNIT_ASSERT_EQUAL(OString("3\n"), aResult);
+
+pDocument.reset(nullptr);
+
+// FIXME: LOK will fail when trying to open a locked file
+remove(sLockFile.c_str());
+
+// load the file again, now in another language
+pDocument.reset(pOffice->documentLoad(sDocPath.c_str(), "Language=cs-CZ"));
+
+// with cs-CZ, the decimal separator is ',' instead, assert that
+insertString(*pDocument, "1,5");
+
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, 1027); // right arrow
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, 1027);
+processEventsToIdle();
+
+insertString(*pDocument, "=2*A1");
+
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, 1280); // enter
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, 1280);
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, 1025); // up arrow
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, 1025);
+processEventsToIdle();
+
+// we've got a meaningful result
+aResult = pDocument->getTextSelection("text/plain;charset=utf-8");
+CPPUNIT_ASSERT_EQUAL(OString("3\n"), aResult);

[Libreoffice-bugs] [Bug 106759] New: Not all linked spreadsheets are shown in 'Edit Links...' dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106759

Bug ID: 106759
   Summary: Not all linked spreadsheets are shown in 'Edit
Links...' dialog
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: j...@vandenoever.info

Created attachment 132136
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132136=edit
Spreadsheet with linked spreadsheets.

A spreadsheet (xls, ods, or xlsx) may contain links to other spreadsheets.

These links can be managed via the 'Edit Links' dialog that can be opened via
the 'Edit > Links' menu item.

The 'Edit Links' dialog does not show all links from the document. LibreOffice
may ask 'This file contains links to other files. Should they be updated?' when
opening a file but not show any links in the 'Edit Links' dialog.

Saving and reloading the spreadsheets can make the links visible.

For example, the attached spreadsheet asks 'This file contains links to other
files. Should they be updated?' when it is opened but shows no links in the
'Edit Links' dialog. If the file is saved as .ods and reopened, it asks again
if the links should be updated. Now the links are visible in the 'Edit links'
dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106757] LO Crashes with fatal error if try to edit master page in sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106757

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
I can't reproduce it in

Versión: 5.3.1.1
Id. de compilación: 72fee18f394a980128dc111963f2eefb05998eeb
Subpr. de CPU: 1; SO: Windows 6.1; Repr. de IU: predet.; Motor de trazado:
HarfBuzz; 
Configuración regional: es-ES (es_ES); Calc: group

Could you please try to reproduce it with LibreOffice 5.3.1.1 from
https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106080] Find and replace by format, font color "Automatic" is not accepted except after changing to another color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106080

raal  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected
 CC||caol...@redhat.com,
   ||r...@post.cz

--- Comment #3 from raal  ---
bibisect-linux-64-5.3$ 
bcdf4ea1ba4e6e9d1dbc89aec66fe57c89945634 is the first bad commit
commit bcdf4ea1ba4e6e9d1dbc89aec66fe57c89945634
Author: Jenkins Build User 
Date:   Mon Nov 7 22:23:35 2016 +0100

source sha:64a708cba9b954afe3331f63c58218eb53b3d0ce

author  Caolán McNamara 2016-11-05 20:28:27 (GMT)
committer   Caolán McNamara 2016-11-07 21:04:50
(GMT)
commit  64a708cba9b954afe3331f63c58218eb53b3d0ce (patch)
treeddc1bea3b63f32a1c6d377c1d1dd7aee0803fb70
parent  f01c49c4a89ecad2376fd0023625186e5cac642e (diff)
Revert "Reverts a commit series that cripple windows ci."
This reverts commit db380aab1063e8a5e40111c40ee9f7921aa82601.


author  Norbert Thiebaud   2016-11-05 18:28:17 (GMT)
committer   Norbert Thiebaud   2016-11-05 18:42:40
(GMT)
commit  db380aab1063e8a5e40111c40ee9f7921aa82601 (patch)
treef5057dfb205a7d7409251742888dfeaf4bfbee61
parent  ee2144aafc5b4be14630f723be9a2bb674671412 (diff)
Reverts a commit series that cripple windows ci.
Revert "SvxShadowTabPage::Construct was removed"
 f9a2c1c12ecad833c63b894c89d6008907477eb5.
Revert "replace OColorPopup with SvxColorWindow"
 f300754bb1c6a347c92bb9548be7a65237176542.
Revert "drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID"
 347c2c334589b18cc62af292674bb3df1dd54b71.
Revert "replace last ColorLB use with a listbox of colors"
 604b35bf55351751a396e34dcca3f85e75860fd5.
Revert "simplify, its just a vector of colors"
 351a97ce6bda3075677b59fa1387ba3d1ab17d7a.
Revert "replace user draw with an Image of the color"
 df738e0f8ceedb4bad756960be14d9c41adc165d.
Revert "strip down to the used pieces"
 commit 08d6cd788f2584ce10ab8fa10665245e953c59d9.
Revert "move now combined ColorLB to location of last user"
 a19b18ad7c9eb0197c10e6d7e451ec4542e4bc9e.
Revert "fold ColorListBox and ColorLB together"
 a989a0b1f2b425f05b58d0e44ce2de31c842ed65.
Revert "move ColorListBox beside sole thing that uses it"
 760a198e697f3070a5e0e029e4eff7be220eb9cd.
Revert "extensions leaks out details of Color Selector, patch it up"
 8bea644d6117a49405e6426dc97214220fc869d1.
Revert "inherit FillAttrLB from ListBox not ColorListBox"
 d2ce812f1d3a7a2aad89ca0bd11948b63d2db7b0.
Revert "unify color selectors"
 43bc3031483d172eccd72c3804e2d4fc2ef37de4.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106758] Weird display of combining diacritical acute accent mark

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106758

--- Comment #1 from Andy  ---
Created attachment 132135
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132135=edit
screenshot - after changing font (using the same font as before)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106758] New: Weird display of combining diacritical acute accent mark

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106758

Bug ID: 106758
   Summary: Weird display of combining diacritical acute accent
mark
   Product: LibreOffice
   Version: 5.2.6.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: a_salni...@yahoo.com

Created attachment 132134
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132134=edit
screenshot - right after inserting accent character

I'm having an issue when I try to add accent marks (U-0301) to the characters
in a document, accent is added but it screws up the appearance of a character
that it's added to - the character gets duplicated and overlapped with itself.
Please see attached image. Saving this garbled document to PDF shows exactly
the same is in PDF file.

I found that situation can be fixed if I select the word and change the font,
even using exactly the same font as it had before.

Would be nice to avoid using that font workaround and have it behaving
normally.

Thanks,
Andy

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106757] New: LO Crashes with fatal error if try to edit master page in sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106757

Bug ID: 106757
   Summary: LO Crashes with fatal error if try to edit master page
in sidebar
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bordfe...@web.de

LO 5.3.0.3 on Windows 10 Pro 64bit

Steps to reproduce:

1. start LO
2. open a new empty presentation
3. in sidebar select master pages
4. make a right click on the master page "used in this presentation" (default)
on the top of the sidebar
5. Select "edit master ..."
6. LO crashes with "fatal error" alert

always reproducable

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106756] Default Theme and Icon Set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106756

--- Comment #3 from Thibaut Brandscheid  ---
Created attachment 132133
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132133=edit
pic3 - LibreOffice fallback theme

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106756] Default Theme and Icon Set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106756

--- Comment #2 from Thibaut Brandscheid  ---
Created attachment 132132
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132132=edit
pic2 - openSUSE, i3, paragraph highlighting issue

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106756] Default Theme and Icon Set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106756

--- Comment #1 from Thibaut Brandscheid  ---
Created attachment 132131
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132131=edit
pic1 - FreeBSD, i3, dark theme

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106756] New: Default Theme and Icon Set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106756

Bug ID: 106756
   Summary: Default Theme and Icon Set
   Product: LibreOffice
   Version: 3.3.0 release
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: randal...@web.de

Description:
This bug report aims at reaching an agreement on the fact that having a default
theme and icon set is a good thing. 

The issue
=

Currently,  the appearance of LibreOffice varies, depending on the operating
system, the desktop shell, the used custom theme. In some cases the
functionality is narrowed because graphical elements are difficult to see or
almost completely hidden. Sometimes the colors of the theme and icon set don’t
match well, resulting in an unaesthetic appearance. Also the size of visual
items differ. The described issue existed already in OpenOffice and was never
fixed.


Major problem
-
By changing the operating system theme – an action not in control of
LibreOffice – the functionality can be reduced up to the point where certain
actions are not possible, because widgets blend with the background.

Sub-problems

* Current appearance is inconsistent across installations.
* Current appearance is neither beautiful nor aesthetic (debatable, I know).

To highlight some problems, I appended screenshots showing:

Pic 1 - LibreOffice on FreeBSD, using the i3 desktop shell with a dark theme
Image shows that the theme and icons set have a very bad contrast. The
functionality is reduced, some features are not usable at all, because UI
elements can not be differentiated from the background. The overall appearance
is unaesthetic, almost unpleasant.

Pic 2 -  LibreOffice on OpenSUSE Tumbleweed
The UI is not fully functional, because the blue – coming from the a custom
system theme – is too light and makes therefore the paragraph-highlighting
almost unusable. The blue dots from the paragraph-highlighting are hard to
identify between the words and the small light-gray background dots (a.k.a. the
visual-grid).

Pic 3 - The  fallback theme (SAL_USE_VCLPLUGIN=gen ./soffice)
Icons are too small, therefore hard to identify. The toolbars have a curved
background-style, not used in any other of my LibreOffice installations. The UI
elements feel out-of-place, the overall appearance is unpleasant, might remind
users of UI’s created in the nineties.

Suggested Solution
==

By using a single theme and icon set we could not only solve the above
described major problem – changes outside of LibreOffice would not affect its
appearance nor have possible usability impacts – it would also allow us to
improve the UI and make it beautiful and aesthetic by carefully arranging used
colors and shapes.

By controlling the theme and icon set we could also make sure the UI works for
color blind (approximately 4.5 % of the population) or slightly visually
impaired people.


Having a single theme and icon set means:

More control

* Would allow us to define color palettes and use them everywhere.
* Would allow us to make sure that icons have a nice contrast relative to their
surroundings.
* That the used visual style and the >>iconography<< are consistent.
* Would allow us to make the UI pixel-perfect, by defining precisely the size
and form of every visible item.

Branding

A consistent single UI is easily recognizable, people get used to it, it is
what people love about a product beside the functionality. Therefore a stronger
branding by having a default UI – which uses the same colors… – would be an
improvement.

Almost granted, but in this context should maybe be said, almost every
well-known application ships with a single default UI (some allow to switch to
a dark theme, but lets ignore that topic for now).

Have a preference setting to allow current behavior
---
To please power-users and preserve the current theming capabilities there
should be a check-box in the preferences to use the theme and icons from the
operating system.


Conclusion
==

I’m aware that this issue report might touch on a highly controversial topic. I
would love to hear your opinions/thoughts about why things are the way they
are, and how the situation could be improved.

Steps to Reproduce:
see description

Actual Results:  
see description

Expected Results:
see description


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
Firefox/52.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org

[Libreoffice-bugs] [Bug 106000] delete/ edit comment in context box not an option if comment is escaped without writing anything in it.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106000

raal  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||qui...@gmail.com,
   ||r...@post.cz
Version|5.3.0.3 release |5.0.6.3 release

--- Comment #2 from raal  ---
resize the column and red dot disappear

This seems to have begun at the below commit.
Adding Cc: to Tomaž Vajngerl  ; Could you possibly take a look at this one?
Thanks

bibisect-50max$ 
b505bc823706dd51e2652098fabb911cbcdd77e1 is the first bad commit
commit b505bc823706dd51e2652098fabb911cbcdd77e1
Author: Matthew Francis 
Date:   Wed May 27 22:45:22 2015 +0800

source-hash-dca01def7885ad69cf66edd75cf8207a5adb64f9

commit dca01def7885ad69cf66edd75cf8207a5adb64f9
Author: Tomaž Vajngerl 
AuthorDate: Thu May 7 14:18:37 2015 +0900
Commit: Jan Holesovsky 
CommitDate: Thu May 7 09:57:50 2015 +0200

refactor ListBox/ComboBox to use RenderContext

Change-Id: I367d6e4f54375bd61e46f0c1437444306b127c68

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - desktop/CppunitTest_desktop_app.mk desktop/inc desktop/qa desktop/source include/LibreOfficeKit libreofficekit/qa vcl/source

[Jan Holesovsky]

 desktop/CppunitTest_desktop_app.mk  |1 
 desktop/inc/lib/init.hxx|5 +
 desktop/qa/desktop_lib/test_desktop_lib.cxx |   30 +
 desktop/source/lib/init.cxx |   60 ++
 include/LibreOfficeKit/LibreOfficeKit.hxx   |3 
 libreofficekit/qa/data/empty.ods|binary
 libreofficekit/qa/unit/tiledrendering.cxx   |   89 
 vcl/source/app/svapp.cxx|9 ++
 8 files changed, 196 insertions(+), 1 deletion(-)

New commits:
commit 221247679bcbc2507d6f904f519040fc4467d4a1
Author: Jan Holesovsky 
Date:   Fri Mar 24 16:23:02 2017 +0100

lok: Unit test for setting of the language during load of the document.

Change-Id: Idf4d3ba6b55be1f885f9d8fc89157e7e498d4e42

diff --git a/libreofficekit/qa/data/empty.ods b/libreofficekit/qa/data/empty.ods
new file mode 100644
index ..a36d1f97c405
Binary files /dev/null and b/libreofficekit/qa/data/empty.ods differ
diff --git a/libreofficekit/qa/unit/tiledrendering.cxx 
b/libreofficekit/qa/unit/tiledrendering.cxx
index 70d7a4ae814b..a4e84ee8d122 100644
--- a/libreofficekit/qa/unit/tiledrendering.cxx
+++ b/libreofficekit/qa/unit/tiledrendering.cxx
@@ -73,6 +73,7 @@ public:
 void testImpressSlideNames( Office* pOffice );
 void testCalcSheetNames( Office* pOffice );
 void testPaintPartTile( Office* pOffice );
+void testDocumentLoadLanguage(Office* pOffice);
 #if 0
 void testOverlay( Office* pOffice );
 #endif
@@ -100,6 +101,7 @@ void TiledRenderingTest::runAllTests()
 testImpressSlideNames( pOffice.get() );
 testCalcSheetNames( pOffice.get() );
 testPaintPartTile( pOffice.get() );
+testDocumentLoadLanguage(pOffice.get());
 #if 0
 testOverlay( pOffice.get() );
 #endif
@@ -218,6 +220,93 @@ void TiledRenderingTest::testPaintPartTile(Office* pOffice)
 pDocument->paintPartTile(aBuffer.data(), /*nPart=*/0, nCanvasWidth, 
nCanvasHeight, /*nTilePosX=*/0, /*nTilePosY=*/0, /*nTileWidth=*/3840, 
/*nTileHeight=*/3840);
 }
 
+namespace {
+
+void processEventsToIdle()
+{
+typedef void (ProcessEventsToIdleFn)(void);
+static ProcessEventsToIdleFn *processFn = nullptr;
+if (!processFn)
+{
+void *me = dlopen(nullptr, RTLD_NOW);
+processFn = reinterpret_cast(dlsym(me, 
"unit_lok_process_events_to_idle"));
+}
+
+CPPUNIT_ASSERT(processFn);
+
+(*processFn)();
+}
+
+void insertString(Document& rDocument, const std::string& s)
+{
+for (const char c : s)
+{
+rDocument.postKeyEvent(LOK_KEYEVENT_KEYINPUT, c, 0);
+rDocument.postKeyEvent(LOK_KEYEVENT_KEYUP, c, 0);
+}
+processEventsToIdle();
+}
+
+}
+
+void TiledRenderingTest::testDocumentLoadLanguage(Office* pOffice)
+{
+const string sDocPath = m_sSrcRoot + "/libreofficekit/qa/data/empty.ods";
+const string sLockFile = m_sSrcRoot 
+"/libreofficekit/qa/data/.~lock.empty.ods#";
+
+// FIXME: LOK will fail when trying to open a locked file
+remove(sLockFile.c_str());
+
+// first try with the en-US locale
+std::unique_ptr 
pDocument(pOffice->documentLoad(sDocPath.c_str(), "Language=en-US"));
+
+// assert that '.' is the decimal separator
+insertString(*pDocument, "1.5");
+
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, 1027); // right arrow
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, 1027);
+processEventsToIdle();
+
+insertString(*pDocument, "=2*A1");
+
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, 1280); // enter
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, 1280);
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, 1025); // up arrow
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, 1025);
+processEventsToIdle();
+
+// we've got a meaningful result
+OString aResult = pDocument->getTextSelection("text/plain;charset=utf-8");
+CPPUNIT_ASSERT_EQUAL(OString("3\n"), aResult);
+
+pDocument.reset(nullptr);
+
+// FIXME: LOK will fail when trying to open a locked file
+remove(sLockFile.c_str());
+
+// load the file again, now in another language
+pDocument.reset(pOffice->documentLoad(sDocPath.c_str(), "Language=cs-CZ"));
+
+// with cs-CZ, the decimal separator is ',' instead, assert that
+insertString(*pDocument, "1,5");
+
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, 1027); // right arrow
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, 1027);
+processEventsToIdle();
+
+insertString(*pDocument, "=2*A1");
+
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, 1280); // enter
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, 1280);
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, 1025); // up arrow
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, 1025);
+processEventsToIdle();
+
+// we've got a meaningful result
+aResult = pDocument->getTextSelection("text/plain;charset=utf-8");
+CPPUNIT_ASSERT_EQUAL(OString("3\n"), 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - vcl/source

[Jan Holesovsky]

 vcl/source/app/svapp.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 9e42779a79cc37b302236d858aded0abd113ec15
Author: Jan Holesovsky 
Date:   Fri Mar 24 18:57:18 2017 +0100

lok: Scheduler::ProcessEventsToIdle() needs the solar mutex locked.

Change-Id: Ibd2e40a995e670db09ca7dbf09465a998f832446

diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index f94e9094ae44..6e70a6f04f80 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -551,6 +551,7 @@ extern "C" {
 /// used by unit tests that test only via the LOK API
 SAL_DLLPUBLIC_EXPORT void unit_lok_process_events_to_idle()
 {
+const SolarMutexGuard aGuard;
 Scheduler::ProcessEventsToIdle();
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104989] Problem with FILTERXML-Function in Basic ( IllegalArgumentException)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104989

raal  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||er...@redhat.com,
   ||r...@post.cz

--- Comment #3 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Eike Rathke ; Could you possibly take a look at this one?
Thanks

673fd98d31d5028e58e531a9f2b33c192bd28a93 is the first bad commit
commit 673fd98d31d5028e58e531a9f2b33c192bd28a93
Author: Jenkins Build User 
Date:   Thu Sep 29 03:44:33 2016 +0200

source sha:7d733e16513a1b9413303d60feb03c5a0de941fc

source sha:7d733e16513a1b9413303d60feb03c5a0de941fc

author  Eike Rathke   2016-08-17 13:58:42 (GMT)
committer   Eike Rathke   2016-08-17 14:01:47 (GMT)
commit  7d733e16513a1b9413303d60feb03c5a0de941fc (patch)
treee5ef06b8dfbd4d4943459f2c616d1f449ac20361
parent  190f0685c866b6232564c9d207456d3292d7a551 (diff)
Resolves: tdf#88257 handle FILTERXML array/matrix context
... in which subsequent node elements are to be stored in the result
matrix.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: LODev 5.4.0 TB62 x86 test build for Windows XP

[V Stuart Foote]

s/Breakbad/Breakpad / 



--
View this message in context: 
http://nabble.documentfoundation.org/LODev-5-4-0-TB62-x86-test-build-for-Windows-XP-tp4210986p4210987.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

LODev 5.4.0 TB62 x86 test build for Windows XP

[V Stuart Foote]

@Cloph, *

The TB62 test build for Windows XP

Version: 5.4.0.0.alpha0+
Build ID: 3d53ec9b2d1c4514adf90ea68915f20ce4d5bc81
CPU threads: 1; OS: Windows 5.1; UI render: default; 
Locale: en-US (en_US); Calc: group

with

https://cgit.freedesktop.org/libreoffice/core/commit/?id=c4c40632f1de6f64f0f903943d76d5c3cad0fc22

Installs and runs cleanly on a Windows XP sp3 VM on VMWare Workstation.

Looking at a verbose MS Intaller log nothing jumps out as a problem.

The VS 2015 SP3 components are installed to the Windows System32 directory
and registered.

vcruntime140.dll
msvcp140.dll
concrt140.dll
vccorlib140.dll

A cursory run through the UI and found no problems--although font quality on
screen is a little coarse. The CURL based check for updates runs--no idea if
the Breakbad mini-dump uploads will turn. But baring any thing really major,
we may be able to continue to support XP for the 5.4 release.

Have the verbose install log if anyone is interested.



--
View this message in context: 
http://nabble.documentfoundation.org/LODev-5-4-0-TB62-x86-test-build-for-Windows-XP-tp4210986.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 106750] * SPELLCH

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106750

Xisco Faulí  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - sw/source

[Pranav Kant]

 sw/source/uibase/uiview/view2.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 83a0659e4fe4dfcc5b61e8dba30304238ee32aaa
Author: Pranav Kant 
Date:   Fri Mar 24 22:36:05 2017 +0530

sw lok: Avoid double declaration of variable

Fallback from f20bb20f8e1147d8ea1b93ee6dc216722461d456 when fixing merge
conflicts

Change-Id: I04a9c5dac43e4aeb3196decc703ad8e14f7b9944

diff --git a/sw/source/uibase/uiview/view2.cxx 
b/sw/source/uibase/uiview/view2.cxx
index a9744b0b48b6..1cdfea949cc3 100644
--- a/sw/source/uibase/uiview/view2.cxx
+++ b/sw/source/uibase/uiview/view2.cxx
@@ -666,7 +666,6 @@ void SwView::Execute(SfxRequest )
 SwDoc *pDoc = m_pWrtShell->GetDoc();
 SwPaM *pCursor = m_pWrtShell->GetCursor();
 const SwRedlineTable& rRedlineTable = 
pDoc->getIDocumentRedlineAccess().GetRedlineTable();
-SwRedlineTable::size_type nRedline = SwRedlineTable::npos;
 sal_uInt16 nRedline = USHRT_MAX;
 if (pArgs && pArgs->GetItemState(nSlot, false, ) == 
SfxItemState::SET)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 8 commits - sw/source

[Michael Stahl]

 sw/source/core/access/acccell.cxx |1 
 sw/source/core/access/acccontext.cxx  |   46 ++
 sw/source/core/access/acccontext.hxx  |   29 +++---
 sw/source/core/access/accdoc.cxx  |   35 +++---
 sw/source/core/access/accfootnote.cxx |2 -
 sw/source/core/access/accframebase.cxx|2 -
 sw/source/core/access/accheaderfooter.cxx |4 --
 sw/source/core/access/accmap.cxx  |   14 +
 sw/source/core/access/accpage.cxx |8 +
 sw/source/core/access/accpara.cxx |   24 +++
 sw/source/core/access/acctable.cxx|4 +-
 11 files changed, 75 insertions(+), 94 deletions(-)

New commits:
commit 125ca372c1d0821139b4c682a02494294b322473
Author: Michael Stahl 
Date:   Fri Mar 24 17:49:07 2017 +0100

sw: just remove SwAccesibleContext must-override methods

What's the point?

Change-Id: Ifdff4aae85282d213f82bd2d69f61f96f8b5e40c

diff --git a/sw/source/core/access/acccontext.cxx 
b/sw/source/core/access/acccontext.cxx
index 9263e150a681..bedbb8c7a813 100644
--- a/sw/source/core/access/acccontext.cxx
+++ b/sw/source/core/access/acccontext.cxx
@@ -678,12 +678,6 @@ sal_Int16 SAL_CALL SwAccessibleContext::getAccessibleRole()
 return m_nRole;
 }
 
-OUString SAL_CALL SwAccessibleContext::getAccessibleDescription()
-{
-assert(!"description needs to be overridden");
-throw uno::RuntimeException("description needs to be overridden");
-}
-
 OUString SAL_CALL SwAccessibleContext::getAccessibleName()
 {
 return m_sName;
@@ -975,23 +969,11 @@ sal_Int32 SAL_CALL SwAccessibleContext::getBackground()
 return COL_WHITE;
 }
 
-OUString SAL_CALL SwAccessibleContext::getImplementationName()
-{
-assert(!"implementation name needs to be overridden");
-throw uno::RuntimeException("implementation name needs to be overridden");
-}
-
 sal_Bool SAL_CALL SwAccessibleContext::supportsService (const OUString& 
ServiceName)
 {
 return cppu::supportsService(this, ServiceName);
 }
 
-uno::Sequence< OUString > SAL_CALL 
SwAccessibleContext::getSupportedServiceNames()
-{
-assert(!"supported services names needs to be overridden");
-throw uno::RuntimeException("supported services names needs to be 
overridden");
-}
-
 void SwAccessibleContext::DisposeShape( const SdrObject *pObj,
 ::accessibility::AccessibleShape *pAccImpl )
 {
diff --git a/sw/source/core/access/acccontext.hxx 
b/sw/source/core/access/acccontext.hxx
index 4c006266c475..1dc8b1972168 100644
--- a/sw/source/core/access/acccontext.hxx
+++ b/sw/source/core/access/acccontext.hxx
@@ -230,9 +230,7 @@ public:
 virtual sal_Int16 SAL_CALL
 getAccessibleRole() override;
 
-// Return this object's description.
-virtual OUString SAL_CALL
-getAccessibleDescription() override;
+// getAccessibleDescription() is abstract
 
 // Return the object's current name.
 virtual OUString SAL_CALL
@@ -282,19 +280,12 @@ public:
 
 // XServiceInfo
 
-/** Returns an identifier for the implementation of this object. */
-virtual OUString SAL_CALL
-getImplementationName() override;
+// getImplementationName() and getSupportedServiceNames are abstract
 
 /** Return whether the specified service is supported by this class. */
 virtual sal_Bool SAL_CALL
 supportsService (const OUString& sServiceName) override;
 
-/** Returns a list of all supported services.  In this case that is just
-the AccessibleContext service. */
-virtual css::uno::Sequence< OUString> SAL_CALL
-getSupportedServiceNames() override;
-
 // thread safe C++ interface
 
 // The object is not visible an longer and should be destroyed
commit d9c2ba239d0b3d71aa64fc9319b7b1025517170f
Author: Michael Stahl 
Date:   Fri Mar 24 17:42:39 2017 +0100

sw: remove THROW_RUNTIME_EXCEPTION macro

Change-Id: I74d4b31ea619c94245759b7a061c40095a0879ad

diff --git a/sw/source/core/access/acccontext.cxx 
b/sw/source/core/access/acccontext.cxx
index f93cc5d2c1e0..9263e150a681 100644
--- a/sw/source/core/access/acccontext.cxx
+++ b/sw/source/core/access/acccontext.cxx
@@ -680,8 +680,8 @@ sal_Int16 SAL_CALL SwAccessibleContext::getAccessibleRole()
 
 OUString SAL_CALL SwAccessibleContext::getAccessibleDescription()
 {
-OSL_ENSURE(false, "description needs to be overridden");
-THROW_RUNTIME_EXCEPTION( XAccessibleContext, "internal error (method must 
be overridden)" );
+assert(!"description needs to be overridden");
+throw uno::RuntimeException("description needs to be overridden");
 }
 
 OUString SAL_CALL SwAccessibleContext::getAccessibleName()
@@ -977,9 +977,8 @@ sal_Int32 SAL_CALL SwAccessibleContext::getBackground()
 
 OUString SAL_CALL SwAccessibleContext::getImplementationName()
 {
-OSL_ENSURE( false, "implementation name needs to be overridden" );
-
-

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - libreofficekit/qa

[Jan Holesovsky]

 libreofficekit/qa/data/empty.ods |binary
 1 file changed

New commits:
commit b9308968af3fb3b812ee4494533e07fb66c1755d
Author: Jan Holesovsky 
Date:   Fri Mar 24 18:03:40 2017 +0100

lok: Forgotten file for the unit test.

Change-Id: Id20c32c1451bd0144377821ffaacbbdeaecbe7bd

diff --git a/libreofficekit/qa/data/empty.ods b/libreofficekit/qa/data/empty.ods
new file mode 100644
index ..a36d1f97c405
Binary files /dev/null and b/libreofficekit/qa/data/empty.ods differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106755] tifinagh rendering problems

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106755

--- Comment #1 from martin_hos...@sil.org ---
Created attachment 132130
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132130=edit
Tifinagh test font

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106755] New: tifinagh rendering problems

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106755

Bug ID: 106755
   Summary: tifinagh rendering problems
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: graphics stack
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: martin_hos...@sil.org

Created attachment 132129
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132129=edit
test text data

Tifinagh rendering problems. The enclosed font and text render happily in
firefox, and shape correctly with hb-shape (producing appropriate looking
ligatures of the diacritic over the base) for either OpenType or Graphite. But
the rendering is wrong (diacritics to the right of the base, with no ligatures)
in libo 5.3. Not sure why

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106750] * SPELLCH

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106750

posam-...@optusnet.com.au changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from posam-...@optusnet.com.au ---
Thanks  Xisco Faulí

* It appears that this annoyance has been resolved in Version: 5.3.1.2 * The
spell checker is still a bit slow but the major cause of the problem has been
fixed *

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106748] FILEOPEN: Opening this .docx file freezes LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106748

--- Comment #2 from Xisco Faulí  ---
Created attachment 132128
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132128=edit
the document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106748] FILEOPEN: Opening this .docx file freezes LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106748

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisectRequest, perf,
   ||regression
 Status|UNCONFIRMED |NEW
 CC||xiscofa...@libreoffice.org
Version|5.3.1.2 release |4.1 all versions
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Reproduced in ( LibreOffice freezes when scrolling )

- Version: 5.4.0.0.alpha0+
Build ID: 1670cc25bc2771e87f7956a4b0dd634abaa4128b
CPU threads: 4; OS: Linux 4.8; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

- Version: 4.3.0.0.alpha1+
Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e

- Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)

but not in

- LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: [Libreoffice-commits] core.git: basegfx/source bin/symbolstore.py chart2/source connectivity/source editeng/source forms/source fpicker/source include/editeng include/svx include/uno odk/examples

[Andrea Gelmini]

2017-03-20 9:24 GMT+01:00 Miklos Vajna :
> Please don't do this -- you change what is assumed to be a valid ODF 1.0
> with this change!

Got it!

Thanks a lot,
Andrea
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 106754] @:trewq 1-800-584-4611+++??? Quickbooks enterprise Number Quickbooks Number QuickBooks phone Number for enterprise ? Asked by hemantrawat321 a moment ago

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106754

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Component|General |deletionrequest
Version|1.13|3.3.1 release
 Resolution|--- |INVALID
Product|cppunit |LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: bridges/source

[Stephan Bergmann]

 bridges/source/cpp_uno/msvc_win32_x86-64/cpp2uno.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d7ebb703427a17d12e22101a1277e9a824c18123
Author: Stephan Bergmann 
Date:   Fri Mar 24 17:11:44 2017 +0100

loplugin:redundantcast

Change-Id: Ia7701e84ea87588abb526ad82da659114474bee5

diff --git a/bridges/source/cpp_uno/msvc_win32_x86-64/cpp2uno.cxx 
b/bridges/source/cpp_uno/msvc_win32_x86-64/cpp2uno.cxx
index fee1483180cf..864f80d7a615 100644
--- a/bridges/source/cpp_uno/msvc_win32_x86-64/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/msvc_win32_x86-64/cpp2uno.cxx
@@ -207,7 +207,7 @@ static inline typelib_TypeClass cpp2uno_call(
 }
 if ( pReturnTD )
 {
-typelib_TypeClass eRet = (typelib_TypeClass)pReturnTD->eTypeClass;
+typelib_TypeClass eRet = pReturnTD->eTypeClass;
 TYPELIB_DANGER_RELEASE( pReturnTD );
 return eRet;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106694] FILEOPEN: RTF: Incorrect TOC's numbers positions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106694

--- Comment #2 from Miklos Vajna  ---
Yes, I see the problem. The position is determined where is the first tab
position for the paragraph, and on master tab positions are lost during import.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106754] New: @:trewq 1-800-584-4611+++??? Quickbooks enterprise Number Quickbooks Number QuickBooks phone Number for enterprise ? Asked by hemantrawat321 a moment ago

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106754

Bug ID: 106754
   Summary: @:trewq 1-800-584-4611+++??? Quickbooks enterprise
Number Quickbooks Number QuickBooks phone Number for
enterprise? Asked by hemantrawat321 a moment ago
   Product: cppunit
   Version: 1.13
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: buff...@a41odgz7jh.com

@:trewq 1-800-584-4611+++???
https://answers.launchpad.net/inkscape/+question/588102 Quickbooks Number
QuickBooks phone Number for enterprise?
Asked by hemantrawat321 a moment ago
@:trewq 1-800-584-4611+++??? Quickbooks enterprise Number Quickbooks Number
QuickBooks phone Number for enterprise?

::""SHIVAY.COM10"":: 1800-584-4611+++??? Quickbooks enterprise Number
Quickbooks Number https://answers.launchpad.net/inkscape/+question/588102 for
enterprise?
Quickbooks number
Quickbooks number
Quickbooks number
Quickbooks number
https://answers.launchpad.net/inkscape/+question/588142
Quickbooks number
Quickbooks number
Quickbooks number
https://answers.launchpad.net/inkscape/+question/588145
Quickbooks enterprise number
Quickbooks enterprise number
Quickbooks enterprise number
https://answers.launchpad.net/inkscape/+question/588145
Quickbooks enterprise number
Quickbooks enterprise number
Quickbooks enterprise number
Quickbooks enterprise number
::Quickbooks enterprise support 1::800::584::4611 -+- Quickbooks enterprise
phone number 1.800.584.4611 Quickbooks enterprise support
Quickbooks enterprise tech Helpline Number; Quickbooks enterprise tech help
PhoNE number- Quickbooks enterprise tech Helpline Number, Quickbooks enterprise
tech Tech SuPpoRT Toll free Number, Quickbooks enterprise techSuPpoRT TELEPhoNE
Number, Quickbooks enterprise tech Tech Support phone number

KELA kHAO 1 800 584 4611 = Quickbooks enterprise tech support phone number =
Quickbooks enterprise tech phone number Quickbooks enterprise tech helpline
phone number
Quickbooks enterprise tech help desk phone number

Product Name : Intuit® Enterprise Quickbooks. Support Phone : +1.800.584.4611.
Subscriber of QuickBooks Enterprises version Call the Toll-Free
+1-(800)-584-4611 to connect with the USA Customer Support team Directly .
Customer From Canada call the +1-800-584-4611 to Speak with Canadian Customer
Services team.
::Quickbooks enterprise support 1::800::584::4611 -+- Quickbooks enterprise
phone number 1.800.584.4611 Quickbooks enterprise support
::Quickbooks enterprise support 1::800::584::4611 -+- Quickbooks enterprise
phone number 1.800.584.4611 Quickbooks enterprise support

Customer Services Toll-Free NO: Intuit® Enterprise Quickbooks. Support Phone:
+1.800.584.4611. Subscriber of QuickBooks Enterprises version Call the
Toll-Free +1-(800)-584-4611 to connect with the USA Customer Support team
Directly . Customer From Canada call the +1-800-584-4611 to Speak with Canadian
Customer Services team.41 mins ago

enterprise phone number 1.800.584.4611 Quickbooks enterprise support
::Quickbooks enterprise support 1::800::584::4611 Quickbooks enterprise phone
number 1.800.584.4611 Quickbooks enterprise support
::Quickbooks enterprise support 1::800::584::4611 Quickbooks enterprise phone
number 1.800.584.4611 Quickbooks enterprise support
::Quickbooks enterprise support 1::800::584::4611 Quickbooks enterprise phone
number 1.800.584.4611 Quickbooks enterprise support
::Quickbooks enterprise support 1::800::584::4611 Quickbooks enterprise phone
number 1.800.584.4611 Quickbooks enterprise support
::Quickbooks enterprise support 1::800::584::4611 Quickbooks enterprise phone
number 1.800.584.4611 Quickbooks enterprise support

v.k!!INTUIT ^Quickbooks Enterprise Support^ +1(800)-584-4611 Quickbooks
Enterprise Support Number,USA.
v.k!!INTUIT ^Quickbooks Enterprise Support^ +1(800)-584-4611 Quickbooks
Enterprise Support Number,USA.
v.k!!INTUIT ^Quickbooks Enterprise Support^ +1(800)-584-4611 Quickbooks
Enterprise Support Number,USA.
v.k!!INTUIT ^Quickbooks Enterprise Support^ +1(800)-584-4611 Quickbooks
Enterprise Support Number,USA.

quickbooks enterprise support

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106729] Crash setting setMultiSelectionMode for FilePicker

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106729

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

--- Comment #6 from Caolán McNamara  ---
I can reproduce this and have an idea where things may have gone wrong

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: ios/experimental

[jan Iversen]

 ios/experimental/LibreOfficeLight/LibreOfficeLight/DocumentController.swift
|  163 ++
 ios/experimental/LibreOfficeLight/LibreOfficeLight/FileManagerController.swift 
|  668 +-
 ios/experimental/LibreOfficeLight/LibreOfficeLight/en.lproj/Main.storyboard
|   90 -
 3 files changed, 531 insertions(+), 390 deletions(-)

New commits:
commit f7eab4dbb8046103df08176e11e0844371e0d20a
Author: jan Iversen 
Date:   Sun Mar 19 11:55:52 2017 +0100

iOS LibreOfficeLight, document actions

added action menu in Document viewer

Change-Id: Ia7c796f7806e363769a5932ce774f33bb4ae8bd2
Reviewed-on: https://gerrit.libreoffice.org/35666
Reviewed-by: jan iversen 
Tested-by: jan iversen 

diff --git 
a/ios/experimental/LibreOfficeLight/LibreOfficeLight/DocumentController.swift 
b/ios/experimental/LibreOfficeLight/LibreOfficeLight/DocumentController.swift
index 9c6cd1b9fb82..1b61f6bb2f2b 100755
--- 
a/ios/experimental/LibreOfficeLight/LibreOfficeLight/DocumentController.swift
+++ 
b/ios/experimental/LibreOfficeLight/LibreOfficeLight/DocumentController.swift
@@ -9,8 +9,87 @@ import UIKit
 
 
 
-class DocumentController: UIViewController
+class DocumentController: UIViewController, DocumentActionsControlDelegate
 {
+@IBAction func returned(segue: UIStoryboardSegue)
+{
+print("I returned")
+}
+
+
+
+// Last stop before displaying popover
+override func prepare(for segue: UIStoryboardSegue, sender: Any?)
+{
+if segue.identifier == "showActions" {
+let vc = segue.destination as! DocumentActions
+vc.delegate = self
+
+// JIX, TO BE CHANGED
+vc.isDocActive = true
+}
+}
+
+
+
+func actionNew(_ name : String)
+{
+// JIX Close active documents if any
+// Start new (with default name
+
+// Only interact with DocumentBrowser
+
+}
+
+
+
+func actionOpen()
+{
+// JIX Close active documents if any
+// Present FileManager
+performSegue(withIdentifier: "showFileManager", sender: self)
+
+// start DocumentBrowser with new document
+}
+
+
+
+func actionDelete()
+{
+// JIX Close active documents if any
+// Delete document
+}
+
+
+
+func actionSave()
+{
+// call save in DocumentBrowser
+
+}
+
+
+
+func actionSaveAs(_ name : String)
+{
+// call saveas in DocumentBrowser
+
+}
+
+
+
+func actionPDF()
+{
+// call savePDF in documentBrowser
+}
+
+
+
+func actionPrint()
+{
+// call print in DocumentBrowser
+}
+
 
 
 override func viewDidLoad()
@@ -20,49 +99,105 @@ class DocumentController: UIViewController
 }
 
 
-@IBAction func returned(segue: UIStoryboardSegue) {
-print("I returned")
-}
 
 override func didReceiveMemoryWarning()
 {
 super.didReceiveMemoryWarning()
 // Dispose of any resources that can be recreated.
 }
+}
+
 
 
+// Protocol for action popover callback
+protocol DocumentActionsControlDelegate
+{
+func actionNew(_ name : String)
+func actionOpen()
+func actionDelete()
+func actionSave()
+func actionSaveAs(_ name : String)
+func actionPDF()
+func actionPrint()
 }
 
 
 
 class DocumentActions: UITableViewController
 {
+// Pointer to callback class
+var delegate  : DocumentActionsControlDelegate?
+var isDocActive : Bool = false
+
+// Calling class might enable/disable each button
+@IBOutlet weak var buttonNew: UIButton!
+@IBOutlet weak var buttonOpen: UIButton!
+@IBOutlet weak var buttonDelete: UIButton!
+@IBOutlet weak var buttonSave: UIButton!
+@IBOutlet weak var buttonSaveAs: UIButton!
+@IBOutlet weak var buttonPDF: UIButton!
+@IBOutlet weak var buttonPrint: UIButton!
+
+
+// Actions
+@IBAction func doOpen(_ sender: UIButton)
+{
+delegate?.actionOpen()
+dismiss(animated: false)
+}
+
+
 
-@IBAction func doOpen(_ sender: UIButton) {
+@IBAction func doDelete(_ sender: UIButton)
+{
+delegate?.actionDelete()
+dismiss(animated: false)
 }
 
-@IBAction func doNew(_ sender: UIButton) {
+
+
+@IBAction func doSave(_ sender: UIButton)
+{
+delegate?.actionSave()
+dismiss(animated: false)
 }
 
-@IBAction func doSave(_ sender: UIButton) {
+
+
+@IBAction func doPDF(_ sender: UIButton)
+{
+delegate?.actionPDF()
+dismiss(animated: false)
 }
 
-@IBAction func doPDF(_ sender: UIButton) {
+
+
+@IBAction func doPrint(_ sender: UIButton)
+{
+delegate?.actionPrint()
+dismiss(animated: false)
 }
+
+
+
 override func viewDidLoad()
 {
 super.viewDidLoad()
-// Do any additional setup after loading the view.
+buttonDelete.isEnabled = isDocActive
+

Re: [Libreoffice-qa] Pre-released 5.3.2.1, no Win x64 available.

[Carlo Strata]

Hi Everyone,

I confirm no Win64 builds here:
http://dev-builds.libreoffice.org/pre-releases/win/x86_64/
for the 5.3.2.1 version...

What's the trouble?

Have All a nice evening,

Carlo

ing. Carlo Strata
-
via Botticelli 1/4
30031 Dolo - VE
Italia - Italy
-
tel. +39.041.822.0665
mobile +39.347.85.69.824
Skype carlo.strata
Google carlo.strata.69
-
carlo.str...@tiscali.it
PEC: carlo.str...@ingpec.eu

Il 22/03/2017 18:11, m.a.riosv ha scritto:

Hi,

there is pre-release build LibreOffice_5.3.2.1_Win_x86.msi  2017-03-19
03:03, but not for Win_x64.

Regards.
Miguel Ángel



--
View this message in context: 
http://nabble.documentfoundation.org/Pre-released-5-3-2-1-no-Win-x64-available-tp4210807.html
Sent from the QA mailing list archive at Nabble.com.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/


___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-commits] core.git: include/cppu include/rtl include/sal

[Stephan Bergmann]

 include/cppu/unotype.hxx |4 ++--
 include/rtl/ustrbuf.hxx  |2 +-
 include/sal/types.h  |2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit f9bf486e25bcec4831393b6dd78ea358ff981b38
Author: Stephan Bergmann 
Date:   Fri Mar 24 16:35:32 2017 +0100

Better check for 'defined LIBO_INTERNAL_ONLY'

(to avoid warnings about undefined macros in external code)

Change-Id: Ie1007207b22c19a3d9d96f0f94070c32d417595a

diff --git a/include/cppu/unotype.hxx b/include/cppu/unotype.hxx
index 40708129ae6f..904621fc6756 100644
--- a/include/cppu/unotype.hxx
+++ b/include/cppu/unotype.hxx
@@ -149,7 +149,7 @@ cppu_detail_getUnoType(
 ::typelib_TypeClass_UNSIGNED_SHORT);
 }
 
-#if LIBO_INTERNAL_ONLY
+#if defined LIBO_INTERNAL_ONLY
 // cf. sal/types.h sal_Unicode
 inline css::uno::Type const &
 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER sal_uInt16 const *) {
@@ -194,7 +194,7 @@ cppu_detail_getUnoType(SAL_UNUSED_PARAMETER 
::cppu::UnoCharType const *) {
 return ::cppu::detail::getTypeFromTypeClass(::typelib_TypeClass_CHAR);
 }
 
-#if LIBO_INTERNAL_ONLY
+#if defined LIBO_INTERNAL_ONLY
 // cf. sal/types.h sal_Unicode
 inline css::uno::Type const &
 cppu_detail_getUnoType(SAL_UNUSED_PARAMETER sal_Unicode const *) {
diff --git a/include/rtl/ustrbuf.hxx b/include/rtl/ustrbuf.hxx
index 32ce9cabe269..1a39bd3fe19f 100644
--- a/include/rtl/ustrbuf.hxx
+++ b/include/rtl/ustrbuf.hxx
@@ -779,7 +779,7 @@ public:
 return append( , 1 );
 }
 
-#if LIBO_INTERNAL_ONLY && (!defined SAL_W32 || defined __clang__)
+#if defined LIBO_INTERNAL_ONLY && (!defined SAL_W32 || defined __clang__)
 // cf. sal/types.h sal_Unicode
 void append(sal_uInt16) = delete;
 #endif
diff --git a/include/sal/types.h b/include/sal/types.h
index 6616670fcb01..93953753ae25 100644
--- a/include/sal/types.h
+++ b/include/sal/types.h
@@ -136,7 +136,7 @@ typedef unsigned char sal_uChar;
 typedef wchar_t sal_Unicode;
 #else
 #define SAL_UNICODE_NOTEQUAL_WCHAR_T
-#if LIBO_INTERNAL_ONLY && defined __cplusplus
+#if defined LIBO_INTERNAL_ONLY && defined __cplusplus
 typedef char16_t sal_Unicode;
 #else
 typedef sal_uInt16 sal_Unicode;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106753] New: Move the whole page using the arrows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106753

Bug ID: 106753
   Summary: Move the whole page using the arrows
   Product: LibreOffice
   Version: 5.3.1.2 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ljani...@wp.pl

The whole page moves with the arrow instead of the single cell

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: common/Session.cpp common/Session.hpp kit/ChildSession.cpp kit/ChildSession.hpp kit/Kit.cpp loleaflet/src test/WhiteBoxTests.cpp wsd/ClientSession.cpp wsd/protocol.tx

[Jan Holesovsky]

 common/Session.cpp   |6 ++
 common/Session.hpp   |   13 -
 kit/ChildSession.cpp |2 +-
 kit/ChildSession.hpp |3 ++-
 kit/Kit.cpp  |   16 +++-
 loleaflet/src/core/Socket.js |3 +++
 test/WhiteBoxTests.cpp   |3 ++-
 wsd/ClientSession.cpp|5 +
 wsd/protocol.txt |5 -
 9 files changed, 42 insertions(+), 14 deletions(-)

New commits:
commit 9f17050a7d4e1b5124a108dce3cce7001bf3deeb
Author: Jan Holesovsky 
Date:   Fri Mar 24 12:34:32 2017 +0100

Pass the locale settings from loleaflet to wsd/kit.

Change-Id: Ie530db73cfbdb62787f16eae0f4b07fbf8b8acb4

diff --git a/common/Session.cpp b/common/Session.cpp
index 78161f11..4c5c40cb 100644
--- a/common/Session.cpp
+++ b/common/Session.cpp
@@ -87,6 +87,7 @@ void Session::parseDocOptions(const std::vector& 
tokens, int& part,
 
 for (size_t i = offset; i < tokens.size(); ++i)
 {
+// FIXME use any kind of startsWith() instead of find(...) == 0
 if (tokens[i].find("url=") == 0)
 {
 _docURL = tokens[i].substr(strlen("url="));
@@ -120,6 +121,11 @@ void Session::parseDocOptions(const 
std::vector& tokens, int& part,
 _haveDocPassword = true;
 ++offset;
 }
+else if (tokens[i].find("lang=") == 0)
+{
+_lang = tokens[i].substr(strlen("lang="));
+++offset;
+}
 }
 
 if (tokens.size() > offset)
diff --git a/common/Session.hpp b/common/Session.hpp
index d12a7042..c8f2e63b 100644
--- a/common/Session.hpp
+++ b/common/Session.hpp
@@ -116,19 +116,19 @@ private:
 std::mutex _mutex;
 
 protected:
-// The actual URL, also in the child, even if the child never accesses 
that.
+/// The actual URL, also in the child, even if the child never accesses 
that.
 std::string _docURL;
 
-// The Jailed document path.
+/// The Jailed document path.
 std::string _jailedFilePath;
 
-// Password provided, if any, to open the document
+/// Password provided, if any, to open the document
 std::string _docPassword;
 
-// If password is provided or not
+/// If password is provided or not
 bool _haveDocPassword;
 
-// Whether document is password protected
+/// Whether document is password protected
 bool _isDocPasswordProtected;
 
 /// Document options: a JSON string, containing options (rendering, also 
possibly load in the future).
@@ -139,6 +139,9 @@ protected:
 
 /// Name of the user to whom the session belongs to
 std::string _userName;
+
+/// Language for the document based on what the user has in the UI.
+std::string _lang;
 };
 
 #endif
diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index de84a398..f62fe306 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -326,7 +326,7 @@ bool ChildSession::loadDocument(const char * /*buffer*/, 
int /*length*/, const s
 
 std::unique_lock lock(Mutex);
 
-bool loaded = _docManager.onLoad(getId(), _jailedFilePath, _userName, 
_docPassword, renderOpts, _haveDocPassword);
+bool loaded = _docManager.onLoad(getId(), _jailedFilePath, _userName, 
_docPassword, renderOpts, _haveDocPassword, _lang);
 if (!loaded || _viewId < 0)
 {
 LOG_ERR("Failed to get LoKitDocument instance.");
diff --git a/kit/ChildSession.hpp b/kit/ChildSession.hpp
index da609b58..ce47ed4c 100644
--- a/kit/ChildSession.hpp
+++ b/kit/ChildSession.hpp
@@ -35,7 +35,8 @@ public:
 const std::string& userName,
 const std::string& docPassword,
 const std::string& renderOpts,
-const bool haveDocPassword) = 0;
+const bool haveDocPassword,
+const std::string& lang) = 0;
 
 /// Unload a client session, which unloads the document
 /// if it is the last and only.
diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 9886a8c5..58f79b28 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -907,7 +907,8 @@ private:
 const std::string& userName,
 const std::string& docPassword,
 const std::string& renderOpts,
-const bool haveDocPassword) override
+const bool haveDocPassword,
+const std::string& lang) override
 {
 std::unique_lock lock(_mutex);
 
@@ -936,7 +937,7 @@ private:
 
 try
 {
-if (!load(session, uri, userName, docPassword, renderOpts, 
haveDocPassword))
+if (!load(session, uri, userName, docPassword, renderOpts, 
haveDocPassword, lang))
 {
 return false;
 }
@@ -1126,7 +1127,8 @@ private:
 const std::string& userName,
 const std::string& docPassword,
 

[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

--- Comment #6 from Frederic Parrenin 
 ---
If you start a fresh .odt file, it works as expected, i.e. the changes are
copied.
So this is really a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: chart2/source

[Bjoern Michaelsen]

 chart2/source/controller/main/ChartController.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 37843706156085d7cc456dfa47306cd5cbfa3ff3
Author: Bjoern Michaelsen 
Date:   Fri Mar 24 14:46:46 2017 +0100

fix for regression from 522e9c65: dont make all charts disappear

Change-Id: Ica8a8c8cfd1f0743c4ad9421f3cac9aa92645838
Reviewed-on: https://gerrit.libreoffice.org/35650
Reviewed-by: Björn Michaelsen 
Tested-by: Björn Michaelsen 

diff --git a/chart2/source/controller/main/ChartController.cxx 
b/chart2/source/controller/main/ChartController.cxx
index 542b061ff086..0f879f60259e 100644
--- a/chart2/source/controller/main/ChartController.cxx
+++ b/chart2/source/controller/main/ChartController.cxx
@@ -1453,7 +1453,7 @@ VclPtr ChartController::GetChartWindow()
 DBG_TESTSOLARMUTEX();
 if(!m_xViewWindow.is())
 return nullptr;
-return dynamic_cast(m_xViewWindow.get());
+return 
dynamic_cast(VCLUnoHelper::GetWindow(m_xViewWindow).get());
 }
 
 bool ChartController::isAdditionalShapeSelected()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106746] copy/pasting revisions copy deleted words

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106746

m.a.riosv  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #5 from m.a.riosv  ---
Sorry, I don't agree it is a bug, now we have the option to copy with/without
the changes changing the 'Show', if it works as you like there is no option to
copy with the changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - 2 commits - desktop/CppunitTest_desktop_app.mk desktop/inc desktop/qa desktop/source include/LibreOfficeKit libreofficekit/qa vcl/sou

[Jan Holesovsky]

 desktop/CppunitTest_desktop_app.mk  |1 
 desktop/inc/lib/init.hxx|5 +
 desktop/qa/desktop_lib/test_desktop_lib.cxx |   30 +
 desktop/source/lib/init.cxx |   60 ++
 include/LibreOfficeKit/LibreOfficeKit.hxx   |3 
 libreofficekit/qa/unit/tiledrendering.cxx   |   89 
 vcl/source/app/svapp.cxx|8 ++
 7 files changed, 195 insertions(+), 1 deletion(-)

New commits:
commit 74acf925171dacdc4c0ad58a6d8edabb1e6c3144
Author: Jan Holesovsky 
Date:   Fri Mar 24 16:23:02 2017 +0100

lok: Unit test for setting of the language during load of the document.

Change-Id: Idf4d3ba6b55be1f885f9d8fc89157e7e498d4e42

diff --git a/libreofficekit/qa/unit/tiledrendering.cxx 
b/libreofficekit/qa/unit/tiledrendering.cxx
index f201f766ca7b..565eea040a93 100644
--- a/libreofficekit/qa/unit/tiledrendering.cxx
+++ b/libreofficekit/qa/unit/tiledrendering.cxx
@@ -73,6 +73,7 @@ public:
 void testImpressSlideNames( Office* pOffice );
 void testCalcSheetNames( Office* pOffice );
 void testPaintPartTile( Office* pOffice );
+void testDocumentLoadLanguage(Office* pOffice);
 #if 0
 void testOverlay( Office* pOffice );
 #endif
@@ -100,6 +101,7 @@ void TiledRenderingTest::runAllTests()
 testImpressSlideNames( pOffice.get() );
 testCalcSheetNames( pOffice.get() );
 testPaintPartTile( pOffice.get() );
+testDocumentLoadLanguage(pOffice.get());
 #if 0
 testOverlay( pOffice.get() );
 #endif
@@ -218,6 +220,93 @@ void TiledRenderingTest::testPaintPartTile(Office* pOffice)
 pDocument->paintPartTile(aBuffer.data(), /*nPart=*/0, nCanvasWidth, 
nCanvasHeight, /*nTilePosX=*/0, /*nTilePosY=*/0, /*nTileWidth=*/3840, 
/*nTileHeight=*/3840);
 }
 
+namespace {
+
+void processEventsToIdle()
+{
+typedef void (ProcessEventsToIdleFn)(void);
+static ProcessEventsToIdleFn *processFn = nullptr;
+if (!processFn)
+{
+void *me = dlopen(nullptr, RTLD_NOW);
+processFn = reinterpret_cast(dlsym(me, 
"unit_lok_process_events_to_idle"));
+}
+
+CPPUNIT_ASSERT(processFn);
+
+(*processFn)();
+}
+
+void insertString(Document& rDocument, const std::string& s)
+{
+for (const char c : s)
+{
+rDocument.postKeyEvent(LOK_KEYEVENT_KEYINPUT, c, 0);
+rDocument.postKeyEvent(LOK_KEYEVENT_KEYUP, c, 0);
+}
+processEventsToIdle();
+}
+
+}
+
+void TiledRenderingTest::testDocumentLoadLanguage(Office* pOffice)
+{
+const string sDocPath = m_sSrcRoot + "/libreofficekit/qa/data/empty.ods";
+const string sLockFile = m_sSrcRoot 
+"/libreofficekit/qa/data/.~lock.empty.ods#";
+
+// FIXME: LOK will fail when trying to open a locked file
+remove(sLockFile.c_str());
+
+// first try with the en-US locale
+std::unique_ptr 
pDocument(pOffice->documentLoad(sDocPath.c_str(), "Language=en-US"));
+
+// assert that '.' is the decimal separator
+insertString(*pDocument, "1.5");
+
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, 1027); // right arrow
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, 1027);
+processEventsToIdle();
+
+insertString(*pDocument, "=2*A1");
+
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, 1280); // enter
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, 1280);
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, 1025); // up arrow
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, 1025);
+processEventsToIdle();
+
+// we've got a meaningful result
+OString aResult = pDocument->getTextSelection("text/plain;charset=utf-8");
+CPPUNIT_ASSERT_EQUAL(OString("3\n"), aResult);
+
+pDocument.reset(nullptr);
+
+// FIXME: LOK will fail when trying to open a locked file
+remove(sLockFile.c_str());
+
+// load the file again, now in another language
+pDocument.reset(pOffice->documentLoad(sDocPath.c_str(), "Language=cs-CZ"));
+
+// with cs-CZ, the decimal separator is ',' instead, assert that
+insertString(*pDocument, "1,5");
+
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, 1027); // right arrow
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, 1027);
+processEventsToIdle();
+
+insertString(*pDocument, "=2*A1");
+
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, 1280); // enter
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, 1280);
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, 1025); // up arrow
+pDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, 1025);
+processEventsToIdle();
+
+// we've got a meaningful result
+aResult = pDocument->getTextSelection("text/plain;charset=utf-8");
+CPPUNIT_ASSERT_EQUAL(OString("3\n"), aResult);
+}
+
 #if 0
 static void dumpRGBABitmap( const OUString& rPath, const unsigned char* 
pBuffer,
 const int nWidth, const int nHeight )
diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index 

[Libreoffice-commits] core.git: rsc/inc rsc/source

[Stephan Bergmann]

 rsc/inc/rscpar.hxx   |4 ++--
 rsc/source/parser/rsclex.cxx |   10 +-
 rsc/source/parser/rscpar.cxx |2 +-
 3 files changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 96208fc5983e459a854c8b4a3c3334e4a8904f56
Author: Stephan Bergmann 
Date:   Fri Mar 24 16:11:55 2017 +0100

This code trades in 'char' entities disguised as 'int'

(with EOF represented as 0), so better actually use 'char'.

Same as 0a92c29e4747f2289514cdb1030900b7c1cbb6ba "This code trades in 'char'
entities disguised as 'int'" in idl.

Change-Id: Ie664c1a0cceb7281fae29bdb75d191b998df44cc

diff --git a/rsc/inc/rscpar.hxx b/rsc/inc/rscpar.hxx
index 265158ba185c..a299af4a20ed 100644
--- a/rsc/inc/rscpar.hxx
+++ b/rsc/inc/rscpar.hxx
@@ -60,8 +60,8 @@ public:
 sal_uInt32  GetLineNo()   { return nLineNo; }
 sal_uInt32  GetScanPos()  { return nScanPos;}
 char *  GetLine() { return pLine;   }
-int GetChar();
-int GetFastChar()
+charGetChar();
+charGetFastChar()
 {
 return pLine[ nScanPos ] ?
 pLine[ nScanPos++ ] : GetChar();
diff --git a/rsc/source/parser/rsclex.cxx b/rsc/source/parser/rsclex.cxx
index e03aa09444d5..37ea1d3b3973 100644
--- a/rsc/source/parser/rsclex.cxx
+++ b/rsc/source/parser/rsclex.cxx
@@ -50,7 +50,7 @@ const char* StringContainer::putString( const char* pString )
 return aInsert.first->getStr();
 }
 
-static int  c;
+static char c;
 static bool bLastInclude;//  true, if last symbol was INCLUDE
 RscFileInst*pFI;
 RscTypCont* pTC;
@@ -166,7 +166,7 @@ int MakeToken( YYSTYPE * pTokenVal )
 c = pFI->GetFastChar();
 while( '>' != c && !pFI->IsEof() )
 {
-aBuf.append( sal_Char(c) );
+aBuf.append( c );
 c = pFI->GetFastChar();
 }
 c = pFI->GetFastChar();
@@ -204,10 +204,10 @@ int MakeToken( YYSTYPE * pTokenVal )
 aBuf.append( '\\' );
 c = pFI->GetFastChar();
 if( c )
-aBuf.append( sal_Char(c) );
+aBuf.append( c );
 }
 else
-aBuf.append( sal_Char(c) );
+aBuf.append( c );
 }
 pTokenVal->string = const_cast(pStringContainer->putString( 
aBuf.getStr() ));
 return STRING;
@@ -226,7 +226,7 @@ int MakeToken( YYSTYPE * pTokenVal )
 while( rtl::isAsciiAlphanumeric (static_cast(c))
|| (c == '_') || (c == '-') || (c == ':'))
 {
-aBuf.append( sal_Char(c) );
+aBuf.append( c );
 c = pFI->GetFastChar();
 }
 
diff --git a/rsc/source/parser/rscpar.cxx b/rsc/source/parser/rscpar.cxx
index 4fc1b11f8cdf..352e3422df95 100644
--- a/rsc/source/parser/rscpar.cxx
+++ b/rsc/source/parser/rscpar.cxx
@@ -57,7 +57,7 @@ RscFileInst::~RscFileInst()
 rtl_freeMemory( pLine );
 }
 
-int RscFileInst::GetChar()
+char RscFileInst::GetChar()
 {
 if( pLine[ nScanPos ] )
 return pLine[ nScanPos++ ];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104935] Crash with .PPS once slideshow is finished or after typing " Esc"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104935

--- Comment #10 from Caolán McNamara  ---
Is this still a problem. I don't see it myself on master

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106752] Quickbooks enterprise phone number (1800 584 4611) Quickbooks enterprise phone number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106752

Xisco Faulí  changed:

   What|Removed |Added

  Component|General |deletionrequest
Product|Document Liberation Project |LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106752] Quickbooks enterprise phone number (1800 584 4611) Quickbooks enterprise phone number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106752

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||xiscofa...@libreoffice.org
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106751] Regressions in Hungarian spell checking

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106751

László Németh  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |nem...@numbertext.org
   |desktop.org |
 QA Contact|nem...@numbertext.org   |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs