[Libreoffice-bugs] [Bug 106437] Unable to open or create ODG or ODP file : error on libsdlo.so

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106437

--- Comment #8 from Elmar  ---
Version: 5.4.0.0.alpha0+
Build ID: 1670cc25bc2771e87f7956a4b0dd634abaa4128b
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2017-03-23_00:46:07
Locale: en-ZA (en_GB.UTF-8); Calc: group

Safe Mode:
Did as requested: get same result as reported in Bug 106735
Impress does not start (does nothing)
Draw gets same error (see the dup bug)
Writer opens normal
Calc opens normal

Safe Mode with restore factory settings:
same result

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: master builds, starts but no UI

[Jean-Baptiste Faure]

Hi,

I confirm that the problematic commit is
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=6903066822900a700ccf67ae70fa171c94644a9a

Related: rhbz#1334915 tdf#100158 hack using startcenter icon under
wayland

Conditions to reproduce :
1/ use Xorg
2/ use GTK3 vcl plugin

Arnaud said me on irc that it works if you are using Wayland

Best regards.
JBF

Le 25/03/2017 à 23:23, Jean-Baptiste Faure a écrit :

Hi,

Le 25/03/2017 à 09:20, Jean-Baptiste Faure a écrit :

Hi,

I don't know if it is only me: current master builds without problem, it
starts but the UI does not show up and it does not crash, it does
nothing (CPU = 0%). Under gdb I see nothing I am able to interpret.
I am building under Ubuntu 16.04 x86-64

I encounter this problem one or two days, somewhere after the commit
7a46166beb714a3357f7fb04111ba98f6325065f
I am currently bisecting.


The StartCenter does not show up if you are not using Wayland.

I guess that the problematic commit is :
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=6903066822900a700ccf67ae70fa171c94644a9a

Related: rhbz#1334915 tdf#100158 hack using startcenter icon under wayland

I am currently building the master to confirm that this commit is the
first bad. Currently my first good is the next commit :
(42870930e2a625766288edc3ba956c1bcac198f0 starmath: Fix memory leak at
double sub/superscripts) and my first bad is the previous one
(51efa8fb3f92de9f8c02d2cc4e3bffcaa5caee7f Notebookbar: move shortcuts if
multiple rows of tabs)

Best regards.
JBF




--
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
Disclaimer: my Internet Provider being located in France, each of our
exchanges over Internet will be scanned by French spying services.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp

[Ashod Nakashian]

 wsd/DocumentBroker.cpp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5eed6575df0133ed38a6a47509d6b96c771e2b3c
Author: Ashod Nakashian 
Date:   Sun Mar 26 00:52:34 2017 -0400

wsd: don't pretent there was a recent save on creating DocBroker

Now the poll thread can exit immediately when loading
fails, since we don't think there is an active
saving on going.

Change-Id: I602b2b506f92309d34ec697553bac05523d70e20
Reviewed-on: https://gerrit.libreoffice.org/35714
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index fe0372e7..ba3a7595 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -143,7 +143,7 @@ DocumentBroker::DocumentBroker(const std::string& uri,
 _childRoot(childRoot),
 _cacheRoot(getCachePath(uriPublic.toString())),
 _lastSaveTime(std::chrono::steady_clock::now()),
-_lastSaveRequestTime(std::chrono::steady_clock::now()),
+_lastSaveRequestTime(std::chrono::steady_clock::now() - 
std::chrono::milliseconds(COMMAND_TIMEOUT_MS)),
 _markToDestroy(false),
 _lastEditableSession(false),
 _isLoaded(false),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/ClientSession.cpp wsd/LOOLWSD.cpp

[Ashod Nakashian]

 wsd/ClientSession.cpp |6 +++---
 wsd/LOOLWSD.cpp   |2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 1c5896f302befd2cede6098148d676cd678b91cf
Author: Ashod Nakashian 
Date:   Sun Mar 26 00:50:51 2017 -0400

wsd: count connections symmetrically

ClientSession::onDisconnect might not always be
called. The disymmetry between incrementing in
the ctor and decrementing in onDisconnect always
ran the risk of mismatch and leaking connection
counts, eventually blocking new clients.

Change-Id: I39ec65016984c0cddd0e16cfbf201049ced53713
Reviewed-on: https://gerrit.libreoffice.org/35713
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index fbc50b98..40d78f1d 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -47,7 +47,8 @@ ClientSession::ClientSession(const std::string& id,
 
 ClientSession::~ClientSession()
 {
-LOG_INF("~ClientSession dtor [" << getName() << "].");
+const size_t curConnections = --LOOLWSD::NumConnections;
+LOG_INF("~ClientSession dtor [" << getName() << "], current number of 
connections: " << curConnections);
 
 stop();
 }
@@ -726,8 +727,7 @@ bool ClientSession::forwardToClient(const 
std::shared_ptr& payload)
 
 void ClientSession::onDisconnect()
 {
-const size_t curConnections = --LOOLWSD::NumConnections;
-LOG_INF(getName() << " Disconnected, current # of connections: " << 
curConnections);
+LOG_INF(getName() << " Disconnected, current number of connections: " << 
LOOLWSD::NumConnections);
 
 const auto docBroker = getDocumentBroker();
 LOG_CHECK_RET(docBroker && "Null DocumentBroker instance", );
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index eaa02fcb..df3382a0 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -1285,7 +1285,7 @@ static std::shared_ptr 
findOrCreateDocBroker(WebSocketHandler& w
 static_assert(MAX_DOCUMENTS > 0, "MAX_DOCUMENTS must be positive");
 if (DocBrokers.size() + 1 > MAX_DOCUMENTS)
 {
-LOG_ERR("Maximum number of open documents reached.");
+LOG_ERR("Maximum number of open documents of " << MAX_DOCUMENTS << 
" reached.");
 shutdownLimitReached(ws);
 return nullptr;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: test/integration-http-server.cpp wsd/LOOLWSD.cpp

[Ashod Nakashian]

 test/integration-http-server.cpp |2 +-
 wsd/LOOLWSD.cpp  |   39 +--
 2 files changed, 22 insertions(+), 19 deletions(-)

New commits:
commit 25dee367d43d12b924dea75e702cdfa20252b97d
Author: Ashod Nakashian 
Date:   Sun Mar 26 00:43:43 2017 -0400

wsd: load the convert-to doc in callback

Since this a fake session that doesn't
have a client socket, we push the
messages directly into the ClientSession.
But since the DocBroker poll thread will
probably not be ready by then, there
is no child process and the other
document bits needed to load (or indeed
process any client messages).

So we defer all the fake messages in
a poll callback to insure they are done
in the correct order.

Change-Id: Id81dc4288b305829149e6e9c81d0f7da719c59ad
Reviewed-on: https://gerrit.libreoffice.org/35712
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/integration-http-server.cpp b/test/integration-http-server.cpp
index 5db9c9a5..3530ed57 100644
--- a/test/integration-http-server.cpp
+++ b/test/integration-http-server.cpp
@@ -44,7 +44,7 @@ class HTTPServerTest : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testLoleafletPost);
 CPPUNIT_TEST(testScriptsAndLinksGet);
 CPPUNIT_TEST(testScriptsAndLinksPost);
-// CPPUNIT_TEST(testConvertTo);
+CPPUNIT_TEST(testConvertTo);
 
 CPPUNIT_TEST_SUITE_END();
 
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 4bb13ffc..eaa02fcb 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -1943,24 +1943,27 @@ private:
 
 docBroker->startThread();
 
-// Load the document manually and request saving in 
the target format.
-std::string encodedFrom;
-URI::encode(docBroker->getPublicUri().getPath(), "", 
encodedFrom);
-const std::string load = "load url=" + encodedFrom;
-std::vector loadRequest(load.begin(), 
load.end());
-clientSession->handleMessage(true, 
WebSocketHandler::WSOpCode::Text, loadRequest);
-
-// FIXME: Check for security violations.
-Path toPath(docBroker->getPublicUri().getPath());
-toPath.setExtension(format);
-const std::string toJailURL = "file://" + 
std::string(JAILED_DOCUMENT_ROOT) + toPath.getFileName();
-std::string encodedTo;
-URI::encode(toJailURL, "", encodedTo);
-
-// Convert it to the requested format.
-const auto saveas = "saveas url=" + encodedTo + " 
format=" + format + " options=";
-std::vector saveasRequest(saveas.begin(), 
saveas.end());
-clientSession->handleMessage(true, 
WebSocketHandler::WSOpCode::Text, saveasRequest);
+docBroker->addCallback([&]()
+{
+// Load the document manually and request saving 
in the target format.
+std::string encodedFrom;
+URI::encode(docBroker->getPublicUri().getPath(), 
"", encodedFrom);
+const std::string load = "load url=" + encodedFrom;
+std::vector loadRequest(load.begin(), 
load.end());
+clientSession->handleMessage(true, 
WebSocketHandler::WSOpCode::Text, loadRequest);
+
+// FIXME: Check for security violations.
+Path toPath(docBroker->getPublicUri().getPath());
+toPath.setExtension(format);
+const std::string toJailURL = "file://" + 
std::string(JAILED_DOCUMENT_ROOT) + toPath.getFileName();
+std::string encodedTo;
+URI::encode(toJailURL, "", encodedTo);
+
+// Convert it to the requested format.
+const auto saveas = "saveas url=" + encodedTo + " 
format=" + format + " options=";
+std::vector saveasRequest(saveas.begin(), 
saveas.end());
+clientSession->handleMessage(true, 
WebSocketHandler::WSOpCode::Text, saveasRequest);
+});
 
 sent = true;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/LOOLWSD.cpp

[Ashod Nakashian]

 wsd/LOOLWSD.cpp |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit e9e36ba848df4f8933867b2adf9960052c532c14
Author: Ashod Nakashian 
Date:   Sat Mar 25 21:53:17 2017 -0400

wsd: reduce main poll timeout to recover child processes faster

Change-Id: Ic5c43df9df7d50e101a8ed3c84ed12a113da1f2b
Reviewed-on: https://gerrit.libreoffice.org/35711
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 7f4fd5bb..4bb13ffc 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -2481,7 +2481,8 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 {
 UnitWSD::get().invokeTest();
 
-mainWait.poll(SocketPoll::DefaultPollTimeoutMs * 2);
+// This timeout affects the recovery time of prespawned children.
+mainWait.poll(SocketPoll::DefaultPollTimeoutMs);
 
 // Wake the prisoner poll to spawn some children, if necessary.
 PrisonerPoll.wakeup();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/LOOLWSD.cpp

[Ashod Nakashian]

 wsd/LOOLWSD.cpp |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit c3e67575a7588cc5f05d02a98af4adffa4183cda
Author: Ashod Nakashian 
Date:   Sat Mar 25 21:52:46 2017 -0400

wsd: reject the client's connection when destroying the doc in question

Change-Id: Ieb437c9a35af6e809a08e5835aabb18db3934040
Reviewed-on: https://gerrit.libreoffice.org/35710
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 120671e8..7f4fd5bb 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -1256,7 +1256,11 @@ static std::shared_ptr 
findOrCreateDocBroker(WebSocketHandler& w
 // destruction when we add the session, -or- the client
 // re-connects.
 if (docBroker->isMarkedToDestroy())
-LOG_WRN("Associating with Document Broker with docKey [" << docKey 
<< "] that is marked to be destroyed!");
+{
+LOG_WRN("DocBroker with docKey [" << docKey << "] that is marked 
to be destroyed. Rejecting client request.");
+ws.shutdown(WebSocketHandler::StatusCodes::ENDPOINT_GOING_AWAY, 
"error: cmd=load kind=docunloading");
+return false;
+}
 }
 else
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: test/httpwstest.cpp

[Ashod Nakashian]

 test/httpwstest.cpp |   26 --
 1 file changed, 20 insertions(+), 6 deletions(-)

New commits:
commit c25d63b0d4307c5804f851d0d2f2bd881f06799d
Author: Ashod Nakashian 
Date:   Sat Mar 25 21:52:01 2017 -0400

wsd: more stable testCloseAfterClose test

Change-Id: Iac9392dbe455ddc3e4742a5f239c1f78f2bfe2ac
Reviewed-on: https://gerrit.libreoffice.org/35709
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index b8ca72c9..22fce917 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -315,9 +315,11 @@ void HTTPWSTest::testCloseAfterClose()
 const auto testname = "closeAfterClose ";
 try
 {
+std::cerr << testname << "Connecting and loading." << std::endl;
 auto socket = loadDocAndGetSocket("hello.odt", _uri, testname);
 
 // send normal socket shutdown
+std::cerr << testname << "Disconnecting." << std::endl;
 socket->shutdown();
 
 // 5 seconds timeout
@@ -330,16 +332,28 @@ void HTTPWSTest::testCloseAfterClose()
 do
 {
 bytes = socket->receiveFrame(buffer, sizeof(buffer), flags);
+std::cerr << testname << "Received [" << std::string(buffer, 
bytes) << "], flags: "<< std::hex << flags << std::dec << std::endl;
 }
 while (bytes > 0 && (flags & Poco::Net::WebSocket::FRAME_OP_BITMASK) 
!= Poco::Net::WebSocket::FRAME_OP_CLOSE);
 
-std::cerr << "Received " << bytes << " bytes, flags: "<< std::hex << 
flags << std::dec << std::endl;
+std::cerr << testname << "Received " << bytes << " bytes, flags: "<< 
std::hex << flags << std::dec << std::endl;
 
-// no more messages is received.
-bytes = socket->receiveFrame(buffer, sizeof(buffer), flags);
-std::cerr << "Received " << bytes << " bytes, flags: "<< std::hex << 
flags << std::dec << std::endl;
-CPPUNIT_ASSERT_EQUAL(0, bytes);
-CPPUNIT_ASSERT_EQUAL(0, flags);
+try
+{
+// no more messages is received.
+bytes = socket->receiveFrame(buffer, sizeof(buffer), flags);
+std::cerr << testname << "Received " << bytes << " bytes, flags: 
"<< std::hex << flags << std::dec << std::endl;
+CPPUNIT_ASSERT_EQUAL(0, bytes);
+CPPUNIT_ASSERT_EQUAL(0, flags);
+}
+catch (const Poco::Exception& exc)
+{
+// This is not unexpected, since WSD will close the socket after
+// echoing back the shutdown status code. However, if it doesn't
+// we assert above that it doesn't send any more data.
+std::cerr << testname << "Error: " << exc.displayText() << 
std::endl;
+
+}
 }
 catch (const Poco::Exception& exc)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: net/WebSocketHandler.hpp

[Ashod Nakashian]

 net/WebSocketHandler.hpp |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit c1ffb649048f6735a5804a8febc8689b52b28596
Author: Ashod Nakashian 
Date:   Sat Mar 25 21:51:25 2017 -0400

wsd: correct shutdown status code echoed back

Change-Id: Ieb685135ab280ed76070af3392bfa69cf313f35a
Reviewed-on: https://gerrit.libreoffice.org/35708
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/net/WebSocketHandler.hpp b/net/WebSocketHandler.hpp
index 08500bf2..6983fbae 100644
--- a/net/WebSocketHandler.hpp
+++ b/net/WebSocketHandler.hpp
@@ -213,8 +213,10 @@ public:
 if (!_shuttingDown)
 {
 // Peer-initiated shutdown must be echoed.
-// Otherwise, this is the echo to _out_ shutdown message.
-const StatusCodes statusCode = 
static_cast((static_cast(_wsPayload[0]) << 8) | 
_wsPayload[1]);
+// Otherwise, this is the echo to _our_ shutdown message, 
which we should ignore.
+const StatusCodes statusCode = 
static_castuint64_t)(unsigned char)_wsPayload[0]) << 8) +
+
(((uint64_t)(unsigned char)_wsPayload[1]) << 0));
+LOG_TRC("#" << socket->getFD() << ": Client initiated socket 
shutdown. Code: " << static_cast(statusCode));
 if (_wsPayload.size() > 2)
 {
 const std::string message(&_wsPayload[2], &_wsPayload[2] + 
_wsPayload.size() - 2);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100158] grouping processes doesn't work in gnome-shell/wayland

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100158

--- Comment #5 from Luke  ---
Ever since
http://cgit.freedesktop.org/libreoffice/core/commit/?id=6903066822900a700ccf67ae70fa171c94644a9a

Related: rhbz#1334915 tdf#100158 hack using startcenter icon under wayland

When I try to launch libreoffice, nothing happens. Reverting this commit fixes
the issue. I have reproduced this bug on both Ubuntu 16.04 and 16.10.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: net/Socket.hpp net/SslSocket.hpp net/WebSocketHandler.hpp

[Ashod Nakashian]

 net/Socket.hpp   |1 +
 net/SslSocket.hpp|2 +-
 net/WebSocketHandler.hpp |   15 ++-
 3 files changed, 12 insertions(+), 6 deletions(-)

New commits:
commit 3895897213930c45c63b9ab3049c6bc101ebc114
Author: Ashod Nakashian 
Date:   Sat Mar 25 21:50:24 2017 -0400

wsd: improved socket logging

Change-Id: Ib4751a5a73b7ec0c7ca319f552d5e0aaff06ffea
Reviewed-on: https://gerrit.libreoffice.org/35707
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/net/Socket.hpp b/net/Socket.hpp
index e0ecc807..56a33de6 100644
--- a/net/Socket.hpp
+++ b/net/Socket.hpp
@@ -69,6 +69,7 @@ public:
 /// TODO: Support separate read/write shutdown.
 virtual void shutdown()
 {
+LOG_TRC("#" << _fd << ": socket shutdown RDWR.");
 ::shutdown(_fd, SHUT_RDWR);
 }
 
diff --git a/net/SslSocket.hpp b/net/SslSocket.hpp
index 3654c4b7..ec732c1a 100644
--- a/net/SslSocket.hpp
+++ b/net/SslSocket.hpp
@@ -64,7 +64,7 @@ public:
 /// Shutdown the TLS/SSL connection properly.
 void closeConnection() override
 {
-LOG_DBG("SslStreamSocket::performShutdown() #" << getFD());
+LOG_DBG("SslStreamSocket::closeConnection() #" << getFD());
 if (SSL_shutdown(_ssl) == 0)
 {
 // Complete the bidirectional shutdown.
diff --git a/net/WebSocketHandler.hpp b/net/WebSocketHandler.hpp
index 64b057b9..08500bf2 100644
--- a/net/WebSocketHandler.hpp
+++ b/net/WebSocketHandler.hpp
@@ -107,7 +107,9 @@ public:
 if (socket == nullptr)
 return;
 
-LOG_TRC("#" << socket->getFD() << ": Shutdown websocket.");
+LOG_TRC("#" << socket->getFD() << ": Shutdown websocket, code: " <<
+static_cast(statusCode) << ", message: " << 
statusMessage);
+_shuttingDown = true;
 
 const size_t len = statusMessage.size();
 std::vector buf(2 + len);
@@ -119,7 +121,6 @@ public:
 
 auto lock = socket->getWriteLock();
 sendFrame(socket, buf.data(), buf.size(), flags);
-_shuttingDown = true;
 }
 
 /// Implementation of the SocketHandlerInterface.
@@ -197,16 +198,16 @@ public:
 socket->_inBuffer.erase(socket->_inBuffer.begin(), 
socket->_inBuffer.begin() + headerLen + payloadLen);
 
 // FIXME: fin, aggregating payloads into _wsPayload etc.
-LOG_TRC("#" << socket->getFD() << ": Incoming WebSocket message code " 
<< code << " fin? " << fin << " payload length " << _wsPayload.size());
+LOG_TRC("#" << socket->getFD() << ": Incoming WebSocket message code " 
<< code << " fin? " << fin << ", payload length: " << _wsPayload.size());
 
 switch (code)
 {
 case WSOpCode::Pong:
 _pingTimeUs = 
std::chrono::duration_cast(std::chrono::steady_clock::now()
 - _pingSent).count();
-LOG_TRC("Pong received: " << _pingTimeUs << " microseconds");
+LOG_TRC("#" << socket->getFD() << ": Pong received: " << 
_pingTimeUs << " microseconds");
 break;
 case WSOpCode::Ping:
-LOG_ERR("Clients should not send pings, only servers");
+LOG_ERR("#" << socket->getFD() << ": Clients should not send 
pings, only servers");
 // drop through
 case WSOpCode::Close:
 if (!_shuttingDown)
@@ -224,6 +225,10 @@ public:
 shutdown(statusCode);
 }
 }
+else
+{
+LOG_TRC("#" << socket->getFD() << ": Client responded to our 
shutdown.");
+}
 
 // TCP Close.
 socket->closeConnection();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106772] LibreOffice Hanging on Startup on Ubuntu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106772

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||0158

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100158] grouping processes doesn't work in gnome-shell/wayland

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100158

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6772

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: test/httpwstest.cpp test/integration-http-server.cpp

[Ashod Nakashian]

 test/httpwstest.cpp  |   19 ++-
 test/integration-http-server.cpp |2 +-
 2 files changed, 15 insertions(+), 6 deletions(-)

New commits:
commit a085f7998b95649ba2676a7c8e7d77cbd143e9f1
Author: Ashod Nakashian 
Date:   Sat Mar 25 14:21:49 2017 -0400

wsd: more informative testConnectNoLoad and error handling

Change-Id: Ide2c546d1bbe10b8bb0996bd454dcfd4906ba2fe
Reviewed-on: https://gerrit.libreoffice.org/35706
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index ed5649ca..b8ca72c9 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -374,29 +374,34 @@ void HTTPWSTest::testConnectNoLoad()
 std::string documentPath, documentURL;
 getDocumentPathAndURL("hello.odt", documentPath, documentURL, 
"connectNoLoad ");
 
+// Connect and disconnect without loading.
 Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, 
documentURL);
-std::cerr << testname1 << "Connecting." << std::endl;
+std::cerr << testname1 << "Connecting first to disconnect without 
loading." << std::endl;
 auto socket = connectLOKit(_uri, request, _response, testname1);
 CPPUNIT_ASSERT_MESSAGE("Failed to connect.", socket);
-std::cerr << testname1 << "Disconnecting." << std::endl;
+std::cerr << testname1 << "Disconnecting first." << std::endl;
 socket.reset();
 
 // Connect and load first view.
-std::cerr << testname2 << "Connecting." << std::endl;
+std::cerr << testname2 << "Connecting second to load first view." << 
std::endl;
 auto socket1 = connectLOKit(_uri, request, _response, testname2);
 CPPUNIT_ASSERT_MESSAGE("Failed to connect.", socket1);
 sendTextFrame(socket1, "load url=" + documentURL, testname2);
 CPPUNIT_ASSERT_MESSAGE("cannot load the document " + documentURL, 
isDocumentLoaded(socket1));
 
 // Connect but don't load second view.
-std::cerr << testname3 << "Connecting." << std::endl;
+std::cerr << testname3 << "Connecting third to disconnect without 
loading." << std::endl;
 auto socket2 = connectLOKit(_uri, request, _response, testname3);
 CPPUNIT_ASSERT_MESSAGE("Failed to connect.", socket2);
-std::cerr << testname3 << "Disconnecting." << std::endl;
+std::cerr << testname3 << "Disconnecting third." << std::endl;
 socket2.reset();
 
+std::cerr << testname2 << "Getting status from first view." << std::endl;
 sendTextFrame(socket1, "status", testname2);
 assertResponseString(socket1, "status:");
+
+std::cerr << testname2 << "Disconnecting second." << std::endl;
+socket1.reset();
 }
 
 void HTTPWSTest::testLoadSimple()
@@ -2199,6 +2204,10 @@ void HTTPWSTest::testEachView(const std::string& doc, 
const std::string& type,
 {
 CPPUNIT_FAIL(exc.displayText());
 }
+catch (const std::exception& exc)
+{
+CPPUNIT_FAIL(exc.what());
+}
 }
 
 void HTTPWSTest::testInvalidateViewCursor()
diff --git a/test/integration-http-server.cpp b/test/integration-http-server.cpp
index 3530ed57..5db9c9a5 100644
--- a/test/integration-http-server.cpp
+++ b/test/integration-http-server.cpp
@@ -44,7 +44,7 @@ class HTTPServerTest : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testLoleafletPost);
 CPPUNIT_TEST(testScriptsAndLinksGet);
 CPPUNIT_TEST(testScriptsAndLinksPost);
-CPPUNIT_TEST(testConvertTo);
+// CPPUNIT_TEST(testConvertTo);
 
 CPPUNIT_TEST_SUITE_END();
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106772] LibreOffice Hanging on Startup on Ubuntu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106772

Luke  changed:

   What|Removed |Added

   Keywords||bisected, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: wsd/ClientSession.cpp wsd/ClientSession.hpp wsd/DocumentBroker.cpp wsd/DocumentBroker.hpp

[Ashod Nakashian]

 wsd/ClientSession.cpp  |2 -
 wsd/ClientSession.hpp  |1 
 wsd/DocumentBroker.cpp |   62 ++---
 wsd/DocumentBroker.hpp |   15 ---
 4 files changed, 15 insertions(+), 65 deletions(-)

New commits:
commit d3a8106cda570fb8881139dc4347e02247036664
Author: Ashod Nakashian 
Date:   Sat Mar 25 14:19:17 2017 -0400

wsd: remove NewSessions

Sessions are now added to the DocBroker
_sessions map and loaded from the poll
thread first before processing their
messages.

Since messages are not read from the
sockets outside of the poll thread,
there is no reason to queue them
at all. The only exception is when
messages are passed directly
to ClientSession during convert-to
requests. That will be handled
separately (for now convert-to test
fails).

Change-Id: I798166b9e45b5707a33d31137e01a32ce63630b1
Reviewed-on: https://gerrit.libreoffice.org/35705
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index 73e4cb5b..fbc50b98 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -38,6 +38,7 @@ ClientSession::ClientSession(const std::string& id,
 _uriPublic(uriPublic),
 _isReadOnly(readOnly),
 _isDocumentOwner(false),
+_isLoaded(false),
 _stop(false)
 {
 const size_t curConnections = ++LOOLWSD::NumConnections;
@@ -632,7 +633,6 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 }
 else if (tokens[0] == "status:")
 {
-_isLoaded = true;
 docBroker->setLoaded();
 
 // Forward the status response to the client.
diff --git a/wsd/ClientSession.hpp b/wsd/ClientSession.hpp
index 19aee2af..c027f4b3 100644
--- a/wsd/ClientSession.hpp
+++ b/wsd/ClientSession.hpp
@@ -37,6 +37,7 @@ public:
 
 /// Returns true if a document is loaded (i.e. we got status message).
 bool isLoaded() const { return _isLoaded; }
+void setLoaded() { _isLoaded = true; }
 
 const std::string getUserId() const { return _userId; }
 void setUserId(const std::string& userId) { _userId = userId; }
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index eb204b8d..fe0372e7 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -211,41 +211,20 @@ void DocumentBroker::pollThread()
 // Main polling loop goodness.
 while (!_stop && !TerminationFlag && !ShutdownRequestFlag)
 {
-while (true)
+// First, load new sessions.
+for (const auto& pair : _sessions)
 {
-std::unique_lock lock(_mutex);
-if (_newSessions.empty())
-break;
-
-NewSession& newSession = _newSessions.front();
 try
 {
-addSession(newSession._session);
-
-// now send the queued messages
-for (std::string message : newSession._messages)
-{
-// provide the jailed document path to the 'load' message
-assert(!_uriJailed.empty());
-std::vector tokens = 
LOOLProtocol::tokenize(message);
-if (tokens.size() > 1 && tokens[1] == "load")
-{
-// The json options must come last.
-message = tokens[0] + ' ' + tokens[1] + ' ' + 
tokens[2];
-message += " jail=" + _uriJailed.toString() + ' ';
-message += Poco::cat(std::string(" "), tokens.begin() 
+ 3, tokens.end());
-}
-
-LOG_DBG("Sending a queued message: " + message);
-_childProcess->sendTextFrame(message);
-}
+auto& session = pair.second;
+if (!session->isLoaded())
+addSession(session);
 }
 catch (const std::exception& exc)
 {
 LOG_ERR("Error while adding new session to doc [" << _docKey 
<< "]: " << exc.what());
+//TODO: Send failure to client and remove session.
 }
-
-_newSessions.pop_front();
 }
 
 _poll->poll(SocketPoll::DefaultPollTimeoutMs);
@@ -740,10 +719,10 @@ size_t 
DocumentBroker::queueSession(std::shared_ptr& session)
 {
 Util::assertIsLocked(_mutex);
 
-_newSessions.push_back(NewSession(session));
+_sessions.emplace(session->getId(), session);
 _poll->wakeup();
 
-return _sessions.size() + _newSessions.size();
+return _sessions.size();
 }
 
 size_t DocumentBroker::addSession(const std::shared_ptr& 
session)
@@ -778,12 +757,9 @@ size_t DocumentBroker::addSession(const 
std::shared_ptr& session)
 _markToDestroy = false;
 _stop = false;
 
-const auto id = session->getId();
-   

[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp

[Ashod Nakashian]

 wsd/DocumentBroker.cpp |   11 ++-
 1 file changed, 6 insertions(+), 5 deletions(-)

New commits:
commit bd00aa405727ae193c6ae762ce0efd9b580043ae
Author: Ashod Nakashian 
Date:   Sat Mar 25 13:57:08 2017 -0400

wsd: assert isCorrectThread

Change-Id: I90bfa9ba6b47e657db28a3680fa8a13ef2553a6e
Reviewed-on: https://gerrit.libreoffice.org/35703
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 2f7ab961..2f542b14 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -302,7 +302,7 @@ DocumentBroker::~DocumentBroker()
 
 bool DocumentBroker::load(const std::shared_ptr& session, const 
std::string& jailId)
 {
-Util::assertIsLocked(_mutex);
+assert(isCorrectThread());
 
 const std::string sessionId = session->getId();
 
@@ -519,7 +519,7 @@ bool DocumentBroker::saveToStorage(const std::string& 
sessionId,
 bool DocumentBroker::saveToStorageInternal(const std::string& sessionId,
bool success, const std::string& 
result)
 {
-assert(_poll->isCorrectThread());
+assert(isCorrectThread());
 
 // If save requested, but core didn't save because document was unmodified
 // notify the waiting thread, if any.
@@ -745,7 +745,7 @@ size_t 
DocumentBroker::queueSession(std::shared_ptr& session)
 
 size_t DocumentBroker::addSession(const std::shared_ptr& 
session)
 {
-Util::assertIsLocked(_mutex);
+assert(isCorrectThread());
 
 try
 {
@@ -948,6 +948,7 @@ void DocumentBroker::invalidateTiles(const std::string& 
tiles)
 void DocumentBroker::handleTileRequest(TileDesc& tile,
const std::shared_ptr& 
session)
 {
+assert(isCorrectThread());
 std::unique_lock lock(_mutex);
 
 tile.setVersion(++_tileVersion);
@@ -1213,6 +1214,8 @@ bool DocumentBroker::forwardToChild(const std::string& 
viewId, const std::string
 
 bool DocumentBroker::forwardToClient(const std::shared_ptr& payload)
 {
+assert(isCorrectThread());
+
 const std::string& msg = payload->abbr();
 const std::string& prefix = payload->forwardToken();
 LOG_TRC("Forwarding payload to [" << prefix << "]: " << msg);
@@ -1224,8 +1227,6 @@ bool DocumentBroker::forwardToClient(const 
std::shared_ptr& payload)
 const auto& data = payload->data().data();
 const auto& size = payload->size();
 
-// std::unique_lock lock(_mutex);
-
 if (sid == "all")
 {
 // Broadcast to all.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp

[Ashod Nakashian]

 wsd/DocumentBroker.cpp |   11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

New commits:
commit a190084b43d6e4b2bedb3ddcfa6376db1f5b161c
Author: Ashod Nakashian 
Date:   Sat Mar 25 13:57:47 2017 -0400

wsd: log document loading stats only the first time

Since these numbers are against the thread start time,
they aren't useful for loading subsequent views.

Change-Id: Ib5cf580282841e5b2dbb71c7db4a1868f7eb29e1
Reviewed-on: https://gerrit.libreoffice.org/35704
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 2f542b14..eb204b8d 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -617,10 +617,13 @@ bool DocumentBroker::saveToStorageInternal(const 
std::string& sessionId,
 
 void DocumentBroker::setLoaded()
 {
-_isLoaded = true;
-_loadDuration = std::chrono::duration_cast(
-std::chrono::steady_clock::now() - _threadStart);
-LOG_TRC("Document loaded in " << _loadDuration.count() << "ms");
+if (!_isLoaded)
+{
+_isLoaded = true;
+_loadDuration = std::chrono::duration_cast(
+std::chrono::steady_clock::now() - 
_threadStart);
+LOG_TRC("Document loaded in " << _loadDuration.count() << "ms");
+}
 }
 
 bool DocumentBroker::autoSave(const bool force)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106772] New: LibreOffice Hanging on Startup on Ubuntu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106772

Bug ID: 106772
   Summary: LibreOffice Hanging on Startup on Ubuntu
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: critical
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lukebe...@hotmail.com

Ever since
http://cgit.freedesktop.org/libreoffice/core/commit/?id=6903066822900a700ccf67ae70fa171c94644a9a

Related: rhbz#1334915 tdf#100158 hack using startcenter icon under wayland

When I try to launch libreoffice, nothing happens. Reverting this commit fixes
the issue. I have reproduced this bug on both Ubuntu 16.04 and 16.10.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp wsd/DocumentBroker.hpp

[Ashod Nakashian]

 wsd/DocumentBroker.cpp |5 ++---
 wsd/DocumentBroker.hpp |4 ++--
 2 files changed, 4 insertions(+), 5 deletions(-)

New commits:
commit a57b9e6917c6d1a80eb4d800d63dfde7f40f79f2
Author: Ashod Nakashian 
Date:   Sat Mar 25 13:56:17 2017 -0400

wsd: const correctness

Change-Id: I2bba04ccba9fd97e10ecc56f7db1f62a66a8f5f0
Reviewed-on: https://gerrit.libreoffice.org/35702
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index d3934d1b..2f7ab961 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -300,7 +300,7 @@ DocumentBroker::~DocumentBroker()
 _childProcess.reset();
 }
 
-bool DocumentBroker::load(std::shared_ptr& session, const 
std::string& jailId)
+bool DocumentBroker::load(const std::shared_ptr& session, const 
std::string& jailId)
 {
 Util::assertIsLocked(_mutex);
 
@@ -743,7 +743,7 @@ size_t 
DocumentBroker::queueSession(std::shared_ptr& session)
 return _sessions.size() + _newSessions.size();
 }
 
-size_t DocumentBroker::addSession(std::shared_ptr& session)
+size_t DocumentBroker::addSession(const std::shared_ptr& 
session)
 {
 Util::assertIsLocked(_mutex);
 
@@ -864,7 +864,6 @@ size_t DocumentBroker::removeSessionInternal(const 
std::string& id)
 return _sessions.size();
 }
 
-
 void DocumentBroker::addCallback(SocketPoll::CallbackFn fn)
 {
 _poll->addCallback(fn);
diff --git a/wsd/DocumentBroker.hpp b/wsd/DocumentBroker.hpp
index 526f873d..13acb9bb 100644
--- a/wsd/DocumentBroker.hpp
+++ b/wsd/DocumentBroker.hpp
@@ -225,7 +225,7 @@ public:
 void startThread();
 
 /// Loads a document from the public URI into the jail.
-bool load(std::shared_ptr& session, const std::string& 
jailId);
+bool load(const std::shared_ptr& session, const 
std::string& jailId);
 bool isLoaded() const { return _isLoaded; }
 void setLoaded();
 
@@ -354,7 +354,7 @@ private:
 bool forwardToClient(const std::shared_ptr& payload);
 
 /// Add a new session. Returns the new number of sessions.
-size_t addSession(std::shared_ptr& session);
+size_t addSession(const std::shared_ptr& session);
 
 /// The thread function that all of the I/O for all sessions
 /// associated with this document.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 45983] FILESAVE: .doc with Custom Styles Corrupted on Roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45983

Luke  changed:

   What|Removed |Added

Summary|FILESAVE: .doc documents|FILESAVE: .doc with Custom
   |corrupted on roundtrip  |Styles Corrupted on
   ||Roundtrip

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45983] FILESAVE: .doc documents corrupted on roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45983

--- Comment #14 from Luke  ---
Created attachment 132145
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132145=edit
Reduced .doc shows problem with Styles

By reducing the .doc, I discovered that the problem here is with the styles. If
I further reduce the .doc by stripping out all of the custom document styles,
the error goes away in Word.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105762] Implement WIA based scanner support for LO Windows builds, 64 bit TWAIN drivers are not viable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105762

V Stuart Foote  changed:

   What|Removed |Added

 CC||caol...@redhat.com
 OS|All |Windows (All)

--- Comment #6 from V Stuart Foote  ---
this should be Windows only, TWAIN would remain viable for macOS and Linux

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: RepositoryExternal.mk

[Thorsten Behrens]

 RepositoryExternal.mk |4 
 1 file changed, 4 insertions(+)

New commits:
commit a4034d56813b6716ae93d455204079cdd2ff9f6f
Author: Thorsten Behrens 
Date:   Sun Mar 26 05:57:10 2017 +0200

Package gpgme only for Linux currently

Change-Id: Ie7323c59f0183c8e132127694e9e865de494c7a3

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index ed00ea4a9dac..c7671a336466 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -3412,6 +3412,8 @@ $(call gb_LinkTarget_use_package,$(1),gpgme)
 
 endef
 
+ifeq ($(OS),LINUX)
+
 $(eval $(call gb_Helper_register_packages_for_install,ooo,\
gpgme \
libassuan \
@@ -3420,6 +3422,8 @@ $(eval $(call 
gb_Helper_register_packages_for_install,ooo,\
 
 endif
 
+endif
+
 ifeq ($(ENABLE_GLTF),TRUE)
 
 ifneq ($(SYSTEM_LIBGLTF),TRUE)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 41063] Saving/Autosaving (Save/Autosave) while in table causes view to jump to cursor position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=41063

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6769

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 41063] Saving/Autosaving (Save/Autosave) while in table causes view to jump to cursor position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=41063

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6769

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106769] FILESAVE : Document scroll to show the caret : very annoying

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106769

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=41
   ||063
 Resolution|--- |DUPLICATE

--- Comment #1 from V Stuart Foote  ---
This was corrected target:5.3.0 target:5.2.0.1 for bug 95797

Verified that correction remains in place for current master/5.4.0.0alpha0+ and
current 5.3.1 release.

Still the residual issue of jump on save/autosave when edit cursor focus is in
a table cell, bug 41063

So if working with Writer tables that is 41063, otherwise it is correct--no
jump on save/autosave.

*** This bug has been marked as a duplicate of bug 95797 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95797] Current display of the document moves away (jumps) when saving or when autorecovery information is saved

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95797

V Stuart Foote  changed:

   What|Removed |Added

 CC||eric.cout...@gmail.com

--- Comment #17 from V Stuart Foote  ---
*** Bug 106769 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104269] [META] Bugs related to scanning

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104269
Bug 104269 depends on bug 101066, which changed state.

Bug 101066 Summary: Dialog "SCANNING" not work
https://bugs.documentfoundation.org/show_bug.cgi?id=101066

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105762] Implement WIA based scanner support for LO Windows builds, 64 bit TWAIN drivers are not viable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105762

V Stuart Foote  changed:

   What|Removed |Added

 CC||t...@bk.ru

--- Comment #5 from V Stuart Foote  ---
*** Bug 101066 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101066] Dialog "SCANNING" not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101066

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |DUPLICATE

--- Comment #3 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 105762 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104269] [META] Bugs related to scanning

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104269
Bug 104269 depends on bug 106770, which changed state.

Bug 106770 Summary: cannot find scanner
https://bugs.documentfoundation.org/show_bug.cgi?id=106770

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105762] Implement WIA based scanner support for LO Windows builds, 64 bit TWAIN drivers are not viable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105762

V Stuart Foote  changed:

   What|Removed |Added

 CC||n1...@juno.com

--- Comment #4 from V Stuart Foote  ---
*** Bug 106770 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104999] Dialog "scanning" does not work 64-bit Windows builds ( now requires TWAIN DSM present on 64-bit systems)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104999

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6770

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106770] cannot find scanner

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106770

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4999
 Resolution|--- |DUPLICATE

--- Comment #1 from V Stuart Foote  ---
LibreOffcie provides no WIA support, only TWAIN. So Windows 64-bit builds would
require 64-bit TWAIN driver support as provided [1],  but reality is that no
vendors provide 64-bit TWAIN drivers for Windows.

=-ref-=
[1] bug 104999

*** This bug has been marked as a duplicate of bug 105762 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: uitest/calc_tests

[Markus Mohrhard]

 uitest/calc_tests/autofilter.py |   27 +++
 1 file changed, 11 insertions(+), 16 deletions(-)

New commits:
commit aaea953b6e43ca5672b104308042419899a52c72
Author: Markus Mohrhard 
Date:   Sun Mar 26 01:13:34 2017 +0100

uitest: add demo showing how to use auto filter popup

Change-Id: Id42c2856e4eee03dae374ea36d6dcba16419c70e
Reviewed-on: https://gerrit.libreoffice.org/35700
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/uitest/calc_tests/autofilter.py b/uitest/calc_tests/autofilter.py
index fc5c1c897ef9..431043b02f03 100644
--- a/uitest/calc_tests/autofilter.py
+++ b/uitest/calc_tests/autofilter.py
@@ -31,23 +31,18 @@ class AutofilterTest(UITestCase):
 doc = self.ui_test.load_file(get_url_for_data_file("autofilter.ods"))
 
 xGridWin = self.xUITest.getTopFocusWindow().getChild("grid_window")
-xGridWin.executeAction("LAUNCH", mkPropertyValues({"AUTOFILTER": "", 
"COL": "1", "ROW": "1"}))
+xGridWin.executeAction("LAUNCH", mkPropertyValues({"AUTOFILTER": "", 
"COL": "0", "ROW": "0"}))
+
+xFloatWindow = self.xUITest.getFloatWindow()
+xCheckListMenu = xFloatWindow.getChild("check_list_menu")
+
+xTreeList = xCheckListMenu.getChild("check_list_box")
+xFirstEntry = xTreeList.getChild("0")
+
+xFirstEntry.executeAction("CLICK", tuple())
 
-time.sleep(3)
-
-print(xGridWin.getChildren())
-xCheckListMenu = xGridWin.getChild("check_list_menu")
-print("temp")
-print(xCheckListMenu)
-print(dir(xCheckListMenu))
-print("temp")
-
-json_string = xCheckListMenu.getHierarchy()
-print(json_string)
-json_content = json.loads(json_string)
-print(json_content)
-print(json.dumps(json_content, indent=4))
-time.sleep(10)
+xOkBtn = xFloatWindow.getChild("ok")
+xOkBtn.executeAction("CLICK", tuple())
 
 self.ui_test.close_doc()
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: uitest/calc_tests

[Markus Mohrhard]

 uitest/calc_tests/autofilter.py |   24 
 1 file changed, 24 insertions(+)

New commits:
commit b3ebb8942115ef0d3fa3840f2056eac9a3bbe23a
Author: Markus Mohrhard 
Date:   Sun Mar 26 01:19:00 2017 +0100

uitest: add demo showing how to interact with autofilter popup

Change-Id: Icda3c00a3a8c593a8f3129662c7688be000e3c7e
Reviewed-on: https://gerrit.libreoffice.org/35694
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/uitest/calc_tests/autofilter.py b/uitest/calc_tests/autofilter.py
index 82a2023fea75..fc5c1c897ef9 100644
--- a/uitest/calc_tests/autofilter.py
+++ b/uitest/calc_tests/autofilter.py
@@ -27,4 +27,28 @@ class AutofilterTest(UITestCase):
 
 self.ui_test.close_doc()
 
+def test_hierarchy(self):
+doc = self.ui_test.load_file(get_url_for_data_file("autofilter.ods"))
+
+xGridWin = self.xUITest.getTopFocusWindow().getChild("grid_window")
+xGridWin.executeAction("LAUNCH", mkPropertyValues({"AUTOFILTER": "", 
"COL": "1", "ROW": "1"}))
+
+time.sleep(3)
+
+print(xGridWin.getChildren())
+xCheckListMenu = xGridWin.getChild("check_list_menu")
+print("temp")
+print(xCheckListMenu)
+print(dir(xCheckListMenu))
+print("temp")
+
+json_string = xCheckListMenu.getHierarchy()
+print(json_string)
+json_content = json.loads(json_string)
+print(json_content)
+print(json.dumps(json_content, indent=4))
+time.sleep(10)
+
+self.ui_test.close_doc()
+
 # vim: set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svtools/source

[Markus Mohrhard]

 svtools/source/uitest/uiobject.cxx |9 +
 1 file changed, 9 insertions(+)

New commits:
commit f71208f49599cd13529447a0b3e2e27baeae2128
Author: Markus Mohrhard 
Date:   Sun Mar 26 00:21:32 2017 +0100

uitest: allow to change state of checkbox in treelist

Change-Id: If76ab528dfd835ea7718e153a943d182ecc4ce0a
Reviewed-on: https://gerrit.libreoffice.org/35698
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/svtools/source/uitest/uiobject.cxx 
b/svtools/source/uitest/uiobject.cxx
index aed862b0acbe..9dfc37c15f0a 100644
--- a/svtools/source/uitest/uiobject.cxx
+++ b/svtools/source/uitest/uiobject.cxx
@@ -116,6 +116,15 @@ void TreeListEntryUIObject::execute(const OUString& 
rAction, const StringMap& /*
 {
 mxTreeList->Expand(mpEntry);
 }
+else if (rAction == "CLICK")
+{
+if (!isCheckBoxList(mxTreeList))
+return;
+SvButtonState eState = mxTreeList->GetCheckButtonState(mpEntry);
+eState = eState == SvButtonState::Checked ? SvButtonState::Unchecked : 
SvButtonState::Checked;
+mxTreeList->SetCheckButtonState(mpEntry, eState);
+mxTreeList->CheckButtonHdl();
+}
 }
 
 std::unique_ptr TreeListEntryUIObject::get_child(const OUString& rID)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - sc/source svtools/source

[Markus Mohrhard]

 sc/source/ui/cctrl/checklistmenu.cxx |4 
 sc/source/ui/inc/checklistmenu.hxx   |1 +
 svtools/source/uitest/uiobject.cxx   |   10 ++
 3 files changed, 15 insertions(+)

New commits:
commit bc054e18712eb1a560ef27d0f2b0a62fc47bf962
Author: Markus Mohrhard 
Date:   Sun Mar 26 00:20:29 2017 +0100

uitest: add more IDs to autofilter elements

Change-Id: I6b22409403cf9ab39c9a120c712976316bf3a22a
Reviewed-on: https://gerrit.libreoffice.org/35696
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/sc/source/ui/cctrl/checklistmenu.cxx 
b/sc/source/ui/cctrl/checklistmenu.cxx
index 3b882f7e998f..ce637818191c 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -906,6 +906,9 @@ ScCheckListMenuWindow::ScCheckListMenuWindow(vcl::Window* 
pParent, ScDocument* p
 maChecks->SetTabStopsContainer(  );
 
 set_id("check_list_menu");
+maChkToggleAll->set_id("toggle_all");
+maBtnSelectSingle->set_id("select_current");
+maBtnUnselectSingle->set_id("unselect_current");
 }
 
 ScCheckListMenuWindow::~ScCheckListMenuWindow()
@@ -1610,6 +1613,7 @@ ScCheckListBox::ScCheckListBox( vcl::Window* pParent )
 :  SvTreeListBox( pParent, 0 ), mpCheckButton( nullptr ), 
mbSeenMouseButtonDown( false )
 {
 Init();
+set_id("check_list_box");
 }
 
 SvTreeListEntry* ScCheckListBox::FindEntry( SvTreeListEntry* pParent, const 
OUString& sNode )
diff --git a/sc/source/ui/inc/checklistmenu.hxx 
b/sc/source/ui/inc/checklistmenu.hxx
index 1723c9b0863b..f2e208ad4f6b 100644
--- a/sc/source/ui/inc/checklistmenu.hxx
+++ b/sc/source/ui/inc/checklistmenu.hxx
@@ -257,6 +257,7 @@ public:
 : Edit(pParent)
 , mpTabStops(nullptr)
 {
+set_id("search_edit");
 }
 
 virtual void MouseButtonDown( const MouseEvent& rMEvt ) override;
commit 3df98c595f1b9c4bd0705578a15252a4d194293c
Author: Markus Mohrhard 
Date:   Sun Mar 26 00:21:04 2017 +0100

uitest: add info whether a tree list box contains check boxes

Change-Id: Id214928de2e74ac7ec707eaf2276e4e808b630a4
Reviewed-on: https://gerrit.libreoffice.org/35697
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/svtools/source/uitest/uiobject.cxx 
b/svtools/source/uitest/uiobject.cxx
index 94da23aa6a54..aed862b0acbe 100644
--- a/svtools/source/uitest/uiobject.cxx
+++ b/svtools/source/uitest/uiobject.cxx
@@ -18,6 +18,15 @@ TreeListUIObject::TreeListUIObject(VclPtr 
xTreeList):
 {
 }
 
+namespace {
+
+bool isCheckBoxList(VclPtr xTreeList)
+{
+return (xTreeList->GetTreeFlags() & SvTreeFlags::CHKBTN) == 
SvTreeFlags::CHKBTN;
+}
+
+}
+
 StringMap TreeListUIObject::get_state()
 {
 StringMap aMap = WindowUIObject::get_state();
@@ -26,6 +35,7 @@ StringMap TreeListUIObject::get_state()
 aMap["VisibleCount"] = OUString::number(mxTreeList->GetVisibleCount());
 aMap["Children"] = OUString::number(mxTreeList->GetChildCount(nullptr));
 aMap["LevelChildren"] = 
OUString::number(mxTreeList->GetLevelChildCount(nullptr));
+aMap["CheckBoxList"] = OUString::boolean(isCheckBoxList(mxTreeList));
 return aMap;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

[Markus Mohrhard]

 vcl/source/uitest/uiobject.cxx |   21 +++--
 1 file changed, 15 insertions(+), 6 deletions(-)

New commits:
commit 013e5bacc65710f9412de2287749a84e469056a0
Author: Markus Mohrhard 
Date:   Sun Mar 26 01:20:10 2017 +0100

uitest: handle float windows better in the hierarchy dump

Change-Id: Ic49ac5774116bf9d8af980ecc0d99b0056fc8bed
Reviewed-on: https://gerrit.libreoffice.org/35695
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/vcl/source/uitest/uiobject.cxx b/vcl/source/uitest/uiobject.cxx
index 3dabf7a0e56f..24fac7a4dd31 100644
--- a/vcl/source/uitest/uiobject.cxx
+++ b/vcl/source/uitest/uiobject.cxx
@@ -93,16 +93,25 @@ bool isDialogWindow(vcl::Window* pWindow)
 return false;
 }
 
-vcl::Window* get_dialog_parent(vcl::Window* pWindow)
+bool isTopWindow(vcl::Window* pWindow)
 {
-if (isDialogWindow(pWindow))
+WindowType eType = pWindow->GetType();
+if (eType == WindowType::FLOATINGWINDOW)
+return true;
+
+return false;
+}
+
+vcl::Window* get_top_parent(vcl::Window* pWindow)
+{
+if (isDialogWindow(pWindow) || isTopWindow(pWindow))
 return pWindow;
 
 vcl::Window* pParent = pWindow->GetParent();
 if (!pParent)
 return pWindow;
 
-return get_dialog_parent(pParent);
+return get_top_parent(pParent);
 }
 
 std::vector generate_key_events_from_text(const OUString& rStr)
@@ -409,7 +418,7 @@ void addChildren(vcl::Window* pParent, std::set& 
rChildren)
 
 std::unique_ptr WindowUIObject::get_child(const OUString& rID)
 {
-vcl::Window* pDialogParent = get_dialog_parent(mxWindow.get());
+vcl::Window* pDialogParent = get_top_parent(mxWindow.get());
 vcl::Window* pWindow = findChild(pDialogParent, rID);
 
 if (!pWindow)
@@ -421,7 +430,7 @@ std::unique_ptr WindowUIObject::get_child(const 
OUString& rID)
 
 std::set WindowUIObject::get_children() const
 {
-vcl::Window* pDialogParent = get_dialog_parent(mxWindow.get());
+vcl::Window* pDialogParent = get_top_parent(mxWindow.get());
 std::set aChildren;
 aChildren.insert(pDialogParent->get_id());
 addChildren(pDialogParent, aChildren);
@@ -473,7 +482,7 @@ OUString WindowUIObject::dumpState() const
 
 OUString WindowUIObject::dumpHierarchy() const
 {
-vcl::Window* pDialogParent = get_dialog_parent(mxWindow.get());
+vcl::Window* pDialogParent = get_top_parent(mxWindow.get());
 std::unique_ptr pParentWrapper =
 pDialogParent->GetUITestFactory()(pDialogParent);
 return pParentWrapper->dumpState();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/vcl offapi/com vcl/source

[Markus Mohrhard]

 include/vcl/uitest/uitest.hxx   |2 ++
 offapi/com/sun/star/ui/test/XUITest.idl |2 ++
 vcl/source/uitest/uitest.cxx|   12 
 vcl/source/uitest/uno/uitest_uno.cxx|9 +
 4 files changed, 25 insertions(+)

New commits:
commit 3c979a362b59b87dee62c85403c3c1f28f59f951
Author: Markus Mohrhard 
Date:   Sun Mar 26 00:24:10 2017 +0100

uitest: provide a way to select a floating window, e.g. popup menu

Change-Id: Ice418b974c59c7d8c773b81a82f0a06c84547f10
Reviewed-on: https://gerrit.libreoffice.org/35699
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/include/vcl/uitest/uitest.hxx b/include/vcl/uitest/uitest.hxx
index 53a049069a14..1674ad2fd50f 100644
--- a/include/vcl/uitest/uitest.hxx
+++ b/include/vcl/uitest/uitest.hxx
@@ -24,6 +24,8 @@ public:
 static void executeDialog(const OUString& rCommand);
 
 static std::unique_ptr getFocusTopWindow();
+
+static std::unique_ptr getFloatWindow();
 };
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/offapi/com/sun/star/ui/test/XUITest.idl 
b/offapi/com/sun/star/ui/test/XUITest.idl
index 89da44c7d6e7..55f234164296 100644
--- a/offapi/com/sun/star/ui/test/XUITest.idl
+++ b/offapi/com/sun/star/ui/test/XUITest.idl
@@ -21,6 +21,8 @@ interface XUITest
 void executeDialog([in] string command);
 
 XUIObject getTopFocusWindow();
+
+XUIObject getFloatWindow();
 };
 
 }; }; }; }; };
diff --git a/vcl/source/uitest/uitest.cxx b/vcl/source/uitest/uitest.cxx
index 413201843ced..3b19a9acc49c 100644
--- a/vcl/source/uitest/uitest.cxx
+++ b/vcl/source/uitest/uitest.cxx
@@ -49,4 +49,16 @@ std::unique_ptr UITest::getFocusTopWindow()
 return rWinData.mpFirstFrame->GetUITestFactory()(rWinData.mpFirstFrame);
 }
 
+std::unique_ptr UITest::getFloatWindow()
+{
+ImplSVData* pSVData = ImplGetSVData();
+ImplSVWinData& rWinData = pSVData->maWinData;
+
+VclPtr pFloatWin = rWinData.mpFirstFloat;
+if (pFloatWin)
+return pFloatWin->GetUITestFactory()(pFloatWin);
+
+return nullptr;
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/uitest/uno/uitest_uno.cxx 
b/vcl/source/uitest/uno/uitest_uno.cxx
index c5a15a4f52ee..1d874c32c7d1 100644
--- a/vcl/source/uitest/uno/uitest_uno.cxx
+++ b/vcl/source/uitest/uno/uitest_uno.cxx
@@ -44,6 +44,8 @@ public:
 
 css::uno::Reference SAL_CALL getTopFocusWindow() 
override;
 
+css::uno::Reference SAL_CALL getFloatWindow() 
override;
+
 OUString SAL_CALL getImplementationName() override;
 
 sal_Bool SAL_CALL supportsService(OUString const & ServiceName) override;
@@ -76,6 +78,13 @@ css::uno::Reference SAL_CALL 
UITestUnoObj::getTopFocus
 return new UIObjectUnoObj(std::move(pObj));
 }
 
+css::uno::Reference SAL_CALL 
UITestUnoObj::getFloatWindow()
+{
+SolarMutexGuard aGuard;
+std::unique_ptr pObj = UITest::getFloatWindow();
+return new UIObjectUnoObj(std::move(pObj));
+}
+
 OUString SAL_CALL UITestUnoObj::getImplementationName()
 {
 return OUString("org.libreoffice.uitest.UITest");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: uitest/calc_tests

[Markus Mohrhard]

 uitest/calc_tests/autofilter.py   |   30 ++
 uitest/calc_tests/data/autofilter.ods |binary
 2 files changed, 30 insertions(+)

New commits:
commit 8d65a2076ee9e76ce2301762fd147cea7091aae4
Author: Markus Mohrhard 
Date:   Sat Mar 25 04:10:24 2017 +0100

uitest: add initial autofilter test

Change-Id: I06029afbf9be93054ef932f8c37a56b929c3e436
Reviewed-on: https://gerrit.libreoffice.org/35693
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/uitest/calc_tests/autofilter.py b/uitest/calc_tests/autofilter.py
new file mode 100644
index ..82a2023fea75
--- /dev/null
+++ b/uitest/calc_tests/autofilter.py
@@ -0,0 +1,30 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from uitest.framework import UITestCase
+from uitest.path import get_srcdir_url
+
+from libreoffice.uno.propertyvalue import mkPropertyValues
+
+import time
+
+def get_url_for_data_file(file_name):
+return get_srcdir_url() + "/uitest/calc_tests/data/" + file_name
+
+class AutofilterTest(UITestCase):
+
+def test_launch_autofilter(self):
+doc = self.ui_test.load_file(get_url_for_data_file("autofilter.ods"))
+
+xGridWin = self.xUITest.getTopFocusWindow().getChild("grid_window")
+xGridWin.executeAction("LAUNCH", mkPropertyValues({"AUTOFILTER": "", 
"COL": "1", "ROW": "1"}))
+
+time.sleep(1)
+
+self.ui_test.close_doc()
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/uitest/calc_tests/data/autofilter.ods 
b/uitest/calc_tests/data/autofilter.ods
new file mode 100644
index ..a03dba608076
Binary files /dev/null and b/uitest/calc_tests/data/autofilter.ods differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Markus Mohrhard]

 sc/source/ui/uitest/uiobject.cxx |   23 +++
 1 file changed, 23 insertions(+)

New commits:
commit a25033fabdf1fccd1b201941cb3b921e2cce81bd
Author: Markus Mohrhard 
Date:   Sat Mar 25 04:02:28 2017 +0100

uitest: add ability to open autofilter dialog

Change-Id: If03b2699975756ab650488abe032aefa8880a6b4
Reviewed-on: https://gerrit.libreoffice.org/35692
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/sc/source/ui/uitest/uiobject.cxx b/sc/source/ui/uitest/uiobject.cxx
index 0db6744ed9c3..96f07bc35743 100644
--- a/sc/source/ui/uitest/uiobject.cxx
+++ b/sc/source/ui/uitest/uiobject.cxx
@@ -172,6 +172,29 @@ void ScGridWinUIObject::execute(const OUString& rAction,
 else
 SAL_WARN("sc.uitest", "can't activate the current selection");
 }
+else if (rAction == "LAUNCH")
+{
+auto itr = rParameters.find("AUTOFILTER");
+if (itr != rParameters.end())
+{
+auto itrCol = rParameters.find("COL");
+if (itrCol == rParameters.end())
+{
+SAL_WARN("sc.uitest", "missing COL parameter");
+return;
+}
+
+auto itrRow = rParameters.find("ROW");
+if (itrRow == rParameters.end())
+{
+SAL_WARN("sc.uitest", "missing ROW parameter");
+return;
+}
+SCROW nRow = itrRow->second.toUInt32();
+SCCOL nCol = itrCol->second.toUInt32();
+mxGridWindow->LaunchAutoFilterMenu(nCol, nRow);
+}
+}
 else
 {
 WindowUIObject::execute(rAction, rParameters);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Markus Mohrhard]

 sc/source/ui/cctrl/checklistmenu.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 03c434e5acf8a2288679776076c3fe7718dfb569
Author: Markus Mohrhard 
Date:   Sat Mar 25 03:29:43 2017 +0100

uitest: add id to autofilter popup

Change-Id: Icf3b731c18333d97aa43535e31df73bc2dbfba42
Reviewed-on: https://gerrit.libreoffice.org/35691
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/source/ui/cctrl/checklistmenu.cxx 
b/sc/source/ui/cctrl/checklistmenu.cxx
index 3879d79f5fd3..3b882f7e998f 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -904,6 +904,8 @@ ScCheckListMenuWindow::ScCheckListMenuWindow(vcl::Window* 
pParent, ScDocument* p
 
 maEdSearch->SetTabStopsContainer(  );
 maChecks->SetTabStopsContainer(  );
+
+set_id("check_list_menu");
 }
 
 ScCheckListMenuWindow::~ScCheckListMenuWindow()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

[Markus Mohrhard]

 vcl/source/uitest/uiobject.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit b9af0c2964a75be1d59884f4aef1fa5a04f85336
Author: Markus Mohrhard 
Date:   Sun Mar 26 01:15:37 2017 +0100

uitest: allow to find ourself with an ID

Change-Id: I5418aba05acd53f00c8d60a7ac7005c83a04e5a4
Reviewed-on: https://gerrit.libreoffice.org/35701
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/vcl/source/uitest/uiobject.cxx b/vcl/source/uitest/uiobject.cxx
index b192f898c620..3dabf7a0e56f 100644
--- a/vcl/source/uitest/uiobject.cxx
+++ b/vcl/source/uitest/uiobject.cxx
@@ -364,6 +364,9 @@ vcl::Window* findChild(vcl::Window* pParent, const 
OUString& rID)
 if (!pParent)
 return nullptr;
 
+if (pParent->get_id() == rID)
+return pParent;
+
 size_t nCount = pParent->GetChildCount();
 for (size_t i = 0; i < nCount; ++i)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: uitest/uitest

[Markus Mohrhard]

 uitest/uitest/bisecting.py |   16 
 1 file changed, 16 insertions(+)

New commits:
commit 646be83e93fc2e68fc419cf6893bd1d1c1322bf7
Author: Markus Mohrhard 
Date:   Sun Mar 26 01:50:01 2017 +0100

uitest: add a decorator to document required revision

This is the first step in allowing easy bisecting with the UI testing
framework. We now also need a script that can execute tests and a way to
get the revision information back into the bisecting script.

Change-Id: If59db62ba25162ae69360d5b8ae769a6d179c16c

diff --git a/uitest/uitest/bisecting.py b/uitest/uitest/bisecting.py
new file mode 100644
index ..7d2f074411df
--- /dev/null
+++ b/uitest/uitest/bisecting.py
@@ -0,0 +1,16 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from functools import wraps
+
+def requires(revision):
+def decorator(f):
+f.requires = revision
+return f
+return decorator
+
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: RepositoryExternal.mk solenv/bin

[Thorsten Behrens]

 RepositoryExternal.mk   |2 +-
 solenv/bin/modules/installer/control.pm |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 8724bcff1e4c9e666125927659db747b483401c3
Author: Thorsten Behrens 
Date:   Sun Mar 26 04:01:02 2017 +0200

Fix gpgme packaging

Change-Id: I26ef55b8a7a210f9d86becd4f0aa10c2598681fd

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 75897bc7799e..ed00ea4a9dac 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -3413,7 +3413,7 @@ $(call gb_LinkTarget_use_package,$(1),gpgme)
 endef
 
 $(eval $(call gb_Helper_register_packages_for_install,ooo,\
-   gpgmepp \
+   gpgme \
libassuan \
libgpg-error \
 ))
diff --git a/solenv/bin/modules/installer/control.pm 
b/solenv/bin/modules/installer/control.pm
index 7670535715ea..decf519eb881 100644
--- a/solenv/bin/modules/installer/control.pm
+++ b/solenv/bin/modules/installer/control.pm
@@ -325,7 +325,7 @@ sub check_logfile
 $compareline =~ s/Error\.html//g;   # removing all occurrences of 
"Error.html"
 $compareline =~ s/error\.py//g; # removing all occurrences of 
"error.py"
 $compareline =~ s/error\.cpython\-3.(\.opt\-.|)\.py[co]//g;  # 
removing all occurrences of "error-cpython"
-$compareline =~ s/libgpg-error-0.dll//g;
+$compareline =~ s/libgpg-error//g;
 $compareline =~ s/Error-xref\.html//g;
 
 if ( $compareline =~ /\bError\b/i )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104269] [META] Bugs related to scanning

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104269

Aron Budea  changed:

   What|Removed |Added

 Depends on||106770


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106770
[Bug 106770] cannot find scanner
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106770] cannot find scanner

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106770

Aron Budea  changed:

   What|Removed |Added

 Blocks||104269


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104269
[Bug 104269] [META] Bugs related to scanning
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: drawinglayer/source

[Markus Mohrhard]

 drawinglayer/source/animation/animationtiming.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 49f8917cd4c10685645128768a2dc63043a7b398
Author: Markus Mohrhard 
Date:   Sun Mar 26 03:25:58 2017 +0200

fix loplugin:loopvartoosmall

Change-Id: I4fa577920565840edd5b37c673e5c8eb42da7ed7

diff --git a/drawinglayer/source/animation/animationtiming.cxx 
b/drawinglayer/source/animation/animationtiming.cxx
index 683c5f5b830c..44210b9567c6 100644
--- a/drawinglayer/source/animation/animationtiming.cxx
+++ b/drawinglayer/source/animation/animationtiming.cxx
@@ -161,14 +161,14 @@ namespace drawinglayer
 
 sal_uInt32 AnimationEntryList::impGetIndexAtTime(double fTime, double 
) const
 {
-sal_uInt32 nIndex(0L);
+size_t nIndex(0L);
 
 while(nIndex < maEntries.size() && 
basegfx::fTools::lessOrEqual(rfAddedTime + maEntries[nIndex]->getDuration(), 
fTime))
 {
 rfAddedTime += maEntries[nIndex++]->getDuration();
 }
 
-return nIndex;
+return sal_uInt32(nIndex);
 }
 
 AnimationEntryList::AnimationEntryList()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106771] New: FILESAVE: LibreOffice fails to embed fonts while saving PPT files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106771

Bug ID: 106771
   Summary: FILESAVE: LibreOffice fails to embed fonts while
saving PPT files
   Product: LibreOffice
   Version: 5.2.6.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: filters and storage
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mp3848-9...@yahoo.com

Description:
When saving PPT file, LibreOffice does not embed fonts even if "Embed fonts in
the document" has been chosen in Properties.

Steps to Reproduce:
1. Create a new Impress presentation.
2. Enter some text.
3. Choose "Properties" from "File" menu.
4. Check "Embed fonts in the document" in the "Font" tab and click "OK".
5. Save the file choosing the PPT file type (confirm the choice in dialog).
6. Close Impress and open the saved file in Microsoft PowerPoint.
7. Check the save options.

Actual Results:  
The checkbox "Embed fonts in a file" is unchecked in Microsoft PowerPoint.

Expected Results:
The checkbox "Embed fonts in a file" should be checked in Microsoft PowerPoint.


Reproducible: Always

User Profile Reset: No

Additional Info:
It is also possible to see the unchecked checkbox after reopening the file in
Impress itself, but in this case that's also because Impress doesn't detect
embedded fonts in PPT files.


User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
Firefox/52.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101987] Spellcheck dialog freezes for several seconds for every action chosen during Spelling Dialogue

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101987

Adolfo Jayme  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #5 from Adolfo Jayme  ---
This should be solved in 5.3.1 with
https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-5-3-1=53b186d85894c2c41afc025bda459db5cc6ef452

*** This bug has been marked as a duplicate of bug 105426 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106611] EDITING: click on status bar does not change the overwrite mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106611

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
Version|5.2.5.1 release |4.4.0.3 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106770] New: cannot find scanner

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106770

Bug ID: 106770
   Summary: cannot find scanner
   Product: LibreOffice
   Version: 5.3.1.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: n1...@juno.com

when trying to insert media from scanner, the select source and request do not
appear to do anything. The software does not see the scanner at all. Tried both
writer and draw. All my other software seems to find the scanner with no
trouble. I am using a hp deskjet f4280 all in one printer/scanner usb
connection to computer. No problems using the printer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106736] List break to a new line if there is text grid

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106736

Mark Hung  changed:

   What|Removed |Added

Version|4.4 all versions|3.3.0 release

--- Comment #2 from Mark Hung  ---
Reproducible with
LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

Have you set "Options/Language/Enabled for Asian Language"?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: chart2/source

[Bjoern Michaelsen]

 chart2/source/controller/main/ChartController.cxx |9 +
 1 file changed, 1 insertion(+), 8 deletions(-)

New commits:
commit 83c1a3235d8d803872e1d57a292d3cdc48dae928
Author: Bjoern Michaelsen 
Date:   Fri Mar 24 12:34:06 2017 +0100

Remove obsolete code

now that the ChartController doesnt own the VCL window anymore.

Change-Id: I2fefa73181a61b2a7828b36e70480b59aa7838f4
Reviewed-on: https://gerrit.libreoffice.org/35640
Tested-by: Jenkins 
Reviewed-by: Björn Michaelsen 

diff --git a/chart2/source/controller/main/ChartController.cxx 
b/chart2/source/controller/main/ChartController.cxx
index 0f879f60259e..3d163b791e1a 100644
--- a/chart2/source/controller/main/ChartController.cxx
+++ b/chart2/source/controller/main/ChartController.cxx
@@ -441,17 +441,10 @@ void SAL_CALL ChartController::attachFrame(
 pParent = VCLUnoHelper::GetWindow( xContainerWindow ).get();
 }
 
-auto pChartWindow(GetChartWindow());
-if(pChartWindow)
-{
-//@todo delete ...
-pChartWindow->clear();
-m_apDropTargetHelper.reset();
-}
 {
 // calls to VCL
 SolarMutexGuard aSolarGuard;
-pChartWindow = 
VclPtr::Create(this,pParent,pParent?pParent->GetStyle():0);
+auto pChartWindow = 
VclPtr::Create(this,pParent,pParent?pParent->GetStyle():0);
 pChartWindow->SetBackground();//no Background
 m_xViewWindow.set( pChartWindow->GetComponentInterface(), 
uno::UNO_QUERY );
 pChartWindow->Show();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106720] FILESAVE XLSX: Validity setting not saved for otherwise empty rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106720

--- Comment #5 from Aron Budea  ---
The bug seems to be in XclExpCellTable::XclExpCellTable( const XclExpRoot&
rRoot ).
http://opengrok.libreoffice.org/xref/core/sc/source/filter/excel/xetable.cxx#2437

This is where validation data is collected:
if( ScfTools::CheckItem( rItemSet, ATTR_VALIDDATA, false ) )
http://opengrok.libreoffice.org/xref/core/sc/source/filter/excel/xetable.cxx#2641

However, the large loop in that function ends with the last row where there's
data, and in this case there's no more data in rows 4-5, so they aren't
considered: the application exits the loop before being able to take care of
the validation data there.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

José Peixoto license statement

[José Peixoto]

All of my past & future contributions to LibreOffice may be licensed under
the MPLv2/LGPLv3+ dual license.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: filter/source

[Caolán McNamara]

 filter/source/msfilter/svdfppt.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 26262de4d508891d08a97dc280f00b28afcd8c7b
Author: Caolán McNamara 
Date:   Sat Mar 25 21:07:57 2017 +

ofz#942 fix leak

Change-Id: I52f69e9dc4c47764c1b3773b1c41b2f04807703e

diff --git a/filter/source/msfilter/svdfppt.cxx 
b/filter/source/msfilter/svdfppt.cxx
index b7e76ca57d6d..38c27e407a72 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -7597,13 +7597,14 @@ SdrObject* SdrPowerPointImport::CreateTable( SdrObject* 
pGroup, sal_uInt32* pTab
 aColumns.insert( aSnapRect.Left() );
 }
 }
-sdr::table::SdrTableObj* pTable = new sdr::table::SdrTableObj( pSdrModel );
-pTable->uno_lock();
-Reference< XTable > xTable( pTable->getTable() );
 
 if (aRows.empty())
 return pRet;
 
+sdr::table::SdrTableObj* pTable = new sdr::table::SdrTableObj( pSdrModel );
+pTable->uno_lock();
+Reference< XTable > xTable( pTable->getTable() );
+
 try
 {
 CreateTableRows( xTable->getRows(), aRows, 
pGroup->GetSnapRect().Bottom() );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: master builds, starts but no UI

[Jean-Baptiste Faure]

Hi,

Le 25/03/2017 à 09:20, Jean-Baptiste Faure a écrit :

Hi,

I don't know if it is only me: current master builds without problem, it
starts but the UI does not show up and it does not crash, it does
nothing (CPU = 0%). Under gdb I see nothing I am able to interpret.
I am building under Ubuntu 16.04 x86-64

I encounter this problem one or two days, somewhere after the commit
7a46166beb714a3357f7fb04111ba98f6325065f
I am currently bisecting.


The StartCenter does not show up if you are not using Wayland.

I guess that the problematic commit is :
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=6903066822900a700ccf67ae70fa171c94644a9a
Related: rhbz#1334915 tdf#100158 hack using startcenter icon under wayland

I am currently building the master to confirm that this commit is the 
first bad. Currently my first good is the next commit :
(42870930e2a625766288edc3ba956c1bcac198f0 starmath: Fix memory leak at 
double sub/superscripts) and my first bad is the previous one 
(51efa8fb3f92de9f8c02d2cc4e3bffcaa5caee7f Notebookbar: move shortcuts if 
multiple rows of tabs)


Best regards.
JBF

--
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
Disclaimer: my Internet Provider being located in France, each of our
exchanges over Internet will be scanned by French spying services.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - odk/docs

[Matthias Seidel]

 odk/docs/images/bg_table.png |binary
 odk/docs/sdk_styles.css  |   39 ++-
 2 files changed, 18 insertions(+), 21 deletions(-)

New commits:
commit 548f330f31bc238e041e4bfb7b413b8ea641d6ad
Author: Matthias Seidel 
Date:   Sat Mar 25 20:29:11 2017 +

Changed color of table head

diff --git a/odk/docs/images/bg_table.png b/odk/docs/images/bg_table.png
index 1cb4c1e92940..756c3b91bd20 100644
Binary files a/odk/docs/images/bg_table.png and b/odk/docs/images/bg_table.png 
differ
diff --git a/odk/docs/sdk_styles.css b/odk/docs/sdk_styles.css
index c258b0a8919f..c291840caa95 100644
--- a/odk/docs/sdk_styles.css
+++ b/odk/docs/sdk_styles.css
@@ -32,8 +32,8 @@ a:hover { color: #107EC0; text-decoration: underline; }
   font-family: Arial, Helvetica, sans-serif; }
 
 .note { font-size: 20px;
-font-weight: bold;
-   font-style: italic; 
+   font-weight: bold;
+   font-style: italic;
text-align: center; }
 
 .table1 { width: 100%;
@@ -52,56 +52,55 @@ a:hover { color: #107EC0; text-decoration: underline; }
  padding: 0; }
 
 .table4 { width: 100%;
- border-width: 1px; 
+ border-width: 1px;
  border-style: solid;
  border-color: #55;
- border-spacing: 0; 
+ border-spacing: 0;
  border-collapse: collapse; }
 
-.cell15 { width: 15%; 
- border-width: 1px; 
+.cell15 { width: 15%;
+ border-width: 1px;
  border-style: solid;
  border-color: #55;
  border-spacing: 0;
- border-collapse: collapse; 
+ border-collapse: collapse;
  padding: 4px; }
 
-.cell20 { width: 20%; 
- border-width: 1px; 
+.cell20 { width: 20%;
+ border-width: 1px;
  border-style: solid;
  border-color: #55;
  border-spacing: 0;
- border-collapse: collapse; 
+ border-collapse: collapse;
  padding: 4px; }
 
 .cell80 { width: 80%;
- border-width: 1px; 
+ border-width: 1px;
  border-style: solid;
  border-color: #55;
  border-spacing: 0;
  border-collapse: collapse;
  padding: 4px; }
 
-.cell85 { width: 85%; 
- border-width: 1px; 
+.cell85 { width: 85%;
+ border-width: 1px;
  border-style: solid;
  border-color: #55;
  border-spacing: 0;
- border-collapse: collapse; 
+ border-collapse: collapse;
  padding: 4px; }
 
 .nothing1 { width: 20px;
-  height: 1px; }
+   height: 1px; }
 
 .nothing8 { width: 20px;
height: 8px; }
 
 .nothing10 { width: 20px;
-   height: 10px; }
+height: 10px; }
 
 .nothing30 { width: 20px;
-   height: 30px; }
-
+height: 30px; }
 
 .appicon { width: 32px;
   height: 32px;
@@ -110,7 +109,6 @@ a:hover { color: #107EC0; text-decoration: underline; }
 .line { width: 100%;
 height: 1px; }
 
-
 .arrow { width: 16px;
 height: 13px; }
 
@@ -127,7 +125,7 @@ a:hover { color: #107EC0; text-decoration: underline; }
  font-weight: bold; }
 
 .thead { font-weight: bold;
- background-color: #CC; }
+ background-color: #89B3CD; }
 
 .navigate { border: 0; }
 
@@ -143,4 +141,3 @@ a:hover { color: #107EC0; text-decoration: underline; }
 
 .centertext { padding-left:20px; padding-top:3px; padding-bottom:5px; 
text-align:left; font-size: 12px; line-height:10pt; }
 .apachelogo { float: right; text-align: left; padding-bottom: 12px; 
padding-right: 8px; padding-left: 5px; width: 188px; height: 76px; }
-
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106728] Fail on Calc for vertical text cell format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106728

--- Comment #2 from Adolfo Jayme  ---
Please disable OpenGL rendering. That backend currently doesn’t support rotated
text.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106668] Unable to apply "Styles & Formatting" to Single Words.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106668

--- Comment #4 from Adolfo Jayme  ---
Please do file bug reports about the help content (component is
“Documentation”) or submit patches via Gerrit to the help repository. This repo
is the source for help.libreoffice.org, so any change eventually goes to that
site.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: source/text

[Adolfo Jayme Barrientos]

 source/text/shared/00/0003.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6be791160b0f09944f9bdbf56dc47273b44be708
Author: Adolfo Jayme Barrientos 
Date:   Sat Mar 25 15:35:42 2017 -0600

Use double prime character (U+2033) for inches

Change-Id: I107f94b795dd5150ed8029d7ac284f52bf0aa4c7

diff --git a/source/text/shared/00/0003.xhp 
b/source/text/shared/00/0003.xhp
index a901df17f..02d9cfbf8 100644
--- a/source/text/shared/00/0003.xhp
+++ b/source/text/shared/00/0003.xhp
@@ -67,7 +67,7 @@
 
 
 
-in or "
+in or 
″
 
 
 Inch
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Adolfo Jayme Barrientos]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a73f5a4223199a79c073f383b2968964eac36939
Author: Adolfo Jayme Barrientos 
Date:   Sat Mar 25 15:35:42 2017 -0600

Updated core
Project: help  6be791160b0f09944f9bdbf56dc47273b44be708

Use double prime character (U+2033) for inches

Change-Id: I107f94b795dd5150ed8029d7ac284f52bf0aa4c7

diff --git a/helpcontent2 b/helpcontent2
index b67d9744ba73..6be791160b0f 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit b67d9744ba73792377b249fd008848125696a769
+Subproject commit 6be791160b0f09944f9bdbf56dc47273b44be708
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106769] New: FILESAVE : Document scroll to show the caret : very annoying

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106769

Bug ID: 106769
   Summary: FILESAVE : Document scroll to show the caret : very
annoying
   Product: LibreOffice
   Version: 5.2.5.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eric.cout...@gmail.com

I edit my document. The caret is a at specific position in the document. I
scroll it via vertical scrollbar or via mouse wheel. So the caret doesn't move.
It's normal.

So, at this moment, i view the part of the document that I want to view.

When I do save  (File/Save or CTRL + S or click on icon), the document auto
scroll to show the caret. It's painful, really painful, because i lose my
concentration.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106767] broken txt file, If UTF8 without BOM

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106767

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Aron Budea  ---
As a workaround, you can choose "Text - Choose encoding" from file type
dropdown in Open dialog.

*** This bug has been marked as a duplicate of bug 61703 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 61703] Writer does not ask the character set of a .txt file at opening

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=61703

Aron Budea  changed:

   What|Removed |Added

 CC||neverappl...@gmail.com

--- Comment #11 from Aron Budea  ---
*** Bug 106767 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #44 from Andreas Säger  ---
Sorry, the correct base dir is ${INSTALLDIR}/share/basic/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #43 from Andreas Säger  ---
I'll attach a zip with all fixed Basic modules in ${INSTALLDIR}/basic/.
I appended a closing brace to all lines where the new Basic compiler complained
since this is what the old compiler assumed when one was missing.

Library.Module  Line_Numbers_in_Basic_IDE
--
Access2Base.Application 917,1149
Access2Base.Database 1443,
Access2Base.Event 255,
Access2Base.Recordset 1120
Access2Base.Trace 183
Access2Base.Utils 832
Depot.Currency 73
Depot.Internet 207
FormWizard.DBMeta 289,290
FormWizard.FormWizard 137,140,141
FormWizard.Language 48,//113,118,140,141,142,143
Gimmicks.ReadDir 247


FormWizard.Language had a comment starting with // in line 113.
Syntax highlighting indicates that this is a valid comment. But the compiler
does not accept this line. I've never seen a //comment in Basic.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser ( error message: "Basic Syntax error. Expected: ).")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106529

--- Comment #42 from Andreas Säger  ---
Created attachment 132144
  --> https://bugs.documentfoundation.org/attachment.cgi?id=132144=edit
Fixed Basic modules

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92268] Can't open document via webdav link + SSO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92268

--- Comment #9 from Victor  ---
(In reply to tommy27 from comment #8)
> @Victor and Giuseppe Castagno
> is this bug still reproducible with LibO 5.2.3.3?
> 
> status NEEDINFO.
> 
> set back to UNCONFIRMED if bug is still there (NEW if there's an independent
> confirmation) or RESOLVED WORKSFORME if the bug is gone.

Dear tommy27, we have switched from libreoffice to MS office because of this
bug. If we will test it again I will reply to this topic. Thank a lot for you
answer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106768] New: I wanna add Tabs and file/folder finder

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106768

Bug ID: 106768
   Summary: I wanna add Tabs and file/folder finder
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: neverappl...@gmail.com

Description:
Tabs : look like http://www.office-tabs.com/
file/folder finder : look like NERDTree for vim plugin

example : http://imgur.com/a/mVoKn (atom editor)

Steps to Reproduce:
.

Actual Results:  
.

Expected Results:
.


Reproducible: Always

User Profile Reset: 

Additional Info:
I can't know dev office.
Maybe it is too much of a suggestion...
but this is a really cool feature!

I'm looking forward to an comment. :D


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106710] Access2base Are you missing parentheses?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106710

Adolfo Jayme  changed:

   What|Removed |Added

 Whiteboard|target:5.3.3|target:5.4.0 target:5.3.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - df/c1786af2d6249558cc91d84a82a7a2772abb12

[Caolán McNamara]

 df/c1786af2d6249558cc91d84a82a7a2772abb12 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 54fb088ee7de079045d47dce57265299d4f79cef
Author: Caolán McNamara 
Date:   Sat Mar 25 20:52:09 2017 +

Notes added by 'git notes add'

diff --git a/df/c1786af2d6249558cc91d84a82a7a2772abb12 
b/df/c1786af2d6249558cc91d84a82a7a2772abb12
new file mode 100644
index ..765aa51f1f80
--- /dev/null
+++ b/df/c1786af2d6249558cc91d84a82a7a2772abb12
@@ -0,0 +1 @@
+prefer: ff0ad0493ee1729c726587f667761b04101d774c
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 13/abe86bb10ee68c302e9b27dba4a438a6c98168

[Caolán McNamara]

 13/abe86bb10ee68c302e9b27dba4a438a6c98168 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 8c3ff277d7e077d73d21f41ab76a5d8bbd9e8702
Author: Caolán McNamara 
Date:   Sat Mar 25 20:49:52 2017 +

Notes added by 'git notes add'

diff --git a/13/abe86bb10ee68c302e9b27dba4a438a6c98168 
b/13/abe86bb10ee68c302e9b27dba4a438a6c98168
new file mode 100644
index ..4acd5055836b
--- /dev/null
+++ b/13/abe86bb10ee68c302e9b27dba4a438a6c98168
@@ -0,0 +1 @@
+prefer: 0764292c5dcb7daa62e9adeb1ac9af1dbe14066f
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 86/2d03382236c006ccf21e710cbcb8f65eaf4317

[Caolán McNamara]

 86/2d03382236c006ccf21e710cbcb8f65eaf4317 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 333bdf68ad6308a35b47b5ceb0ee4228f1df0d4d
Author: Caolán McNamara 
Date:   Sat Mar 25 20:43:15 2017 +

Notes added by 'git notes add'

diff --git a/86/2d03382236c006ccf21e710cbcb8f65eaf4317 
b/86/2d03382236c006ccf21e710cbcb8f65eaf4317
new file mode 100644
index ..783121c6b0aa
--- /dev/null
+++ b/86/2d03382236c006ccf21e710cbcb8f65eaf4317
@@ -0,0 +1 @@
+prefer: bfc71eb03e2bc6f26d53f70b32f9a8937086808b
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 15/325f02503e3e47201a21fc9da3881fde3fab3f

[Caolán McNamara]

 15/325f02503e3e47201a21fc9da3881fde3fab3f |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 3293a644ea8c59f247d9acea24038cf64eadb636
Author: Caolán McNamara 
Date:   Sat Mar 25 20:42:03 2017 +

Notes added by 'git notes add'

diff --git a/15/325f02503e3e47201a21fc9da3881fde3fab3f 
b/15/325f02503e3e47201a21fc9da3881fde3fab3f
new file mode 100644
index ..8ebbe55237b1
--- /dev/null
+++ b/15/325f02503e3e47201a21fc9da3881fde3fab3f
@@ -0,0 +1 @@
+ignore: obsolete
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 40/6374cce33a9b0c06546b2490a33b4e6b183390

[Caolán McNamara]

 40/6374cce33a9b0c06546b2490a33b4e6b183390 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 2ee56048f09334cb0b70accd9a094814812b6388
Author: Caolán McNamara 
Date:   Sat Mar 25 20:36:16 2017 +

Notes added by 'git notes add'

diff --git a/40/6374cce33a9b0c06546b2490a33b4e6b183390 
b/40/6374cce33a9b0c06546b2490a33b4e6b183390
new file mode 100644
index ..8e5c182e7789
--- /dev/null
+++ b/40/6374cce33a9b0c06546b2490a33b4e6b183390
@@ -0,0 +1 @@
+ignore: aoo
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106767] New: broken txt file, If UTF8 without BOM

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106767

Bug ID: 106767
   Summary: broken txt file, If UTF8 without BOM
   Product: LibreOffice
   Version: 5.3.1.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: neverappl...@gmail.com

Description:
Nice work .txt opening if UTF8 with BOM .txt file.
but broken if UTF8 without BOM .txt file.

I check using Hex editor BOM and I can't found setting encoding opened file.

Steps to Reproduce:
1. open .txt without BOM file
2. broken!!

Actual Results:  
text broken 
example image :
http://stackoverflow.com/questions/27155051/broken-typo3-front-end-encoding
it's just example image from google search

Expected Results:
broken~~


Reproducible: Always

User Profile Reset: No

Additional Info:
I can't english. plz, I want easy english. ;)



User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106681] Feature Request: Ability to assign character styles to toolbar buttons...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106681

--- Comment #32 from Thomas Lendo  ---
I support what Regina said in comment 22 and comment 29, point (1): Make it
possible for users that want do it by themselves.

All other ideas (changing anything in toolbars etc.) that UX people avoid like
the plague (fürchten wie der Teufel das Weihwasser) must be handled in new bugs
and shouldn't result in closing THIS bug.

(In reply to Yousuf Philips (jay) from comment #27)
> What is possible today is to add some basic paragraph and character styles
> as clickable buttons to the formatting toolbar, similar to what Regina made
> with the guide, but these buttons wouldnt be toggle buttons, which means
> that you couldn't glance at them to know what is being applied. In order to
> have them as toggle buttons, UNO commands would need to be created for them
> and these commands would need to detect whether the underlying
> paragraph/character style is being applied. @Maxim, @Samuel, @Gulsah: Is
> this something that can easily be achieved?

This would be the optimum for that bug!

> When i mentioned the seamless experience above, it was focused on the easy
> ability with direct formatting to mix formatting attributes together like
> bold + italics or italics + underline when clicking on the toolbar buttons,
> while this wouldnt be possible with the character style buttons, as if text
> was in bold (aka strong emphasis) and you wanted to apply italics (aka
> emphasis) to that text, it would overwrite bold with italics and not mix the
> two together as a new character style.

The overwriting is was users expect, that know was styles and soft-formatting
are doing.

> It would be great if LibreOffice had
> a style-only mode, where all applied direct formatting was turned into
> styles, iWork works in this way i believe.
> 
> If there is interest in making this styles-focused formatting toolbar, i'd
> be up to brainstorming its creation with those interested in it.

Here we are ...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 106681] Feature Request: Ability to assign character styles to toolbar buttons...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106681

--- Comment #32 from Thomas Lendo  ---
I support what Regina said in comment 22 and comment 29, point (1): Make it
possible for users that want do it by themselves.

All other ideas (changing anything in toolbars etc.) that UX people avoid like
the plague (fürchten wie der Teufel das Weihwasser) must be handled in new bugs
and shouldn't result in closing THIS bug.

(In reply to Yousuf Philips (jay) from comment #27)
> What is possible today is to add some basic paragraph and character styles
> as clickable buttons to the formatting toolbar, similar to what Regina made
> with the guide, but these buttons wouldnt be toggle buttons, which means
> that you couldn't glance at them to know what is being applied. In order to
> have them as toggle buttons, UNO commands would need to be created for them
> and these commands would need to detect whether the underlying
> paragraph/character style is being applied. @Maxim, @Samuel, @Gulsah: Is
> this something that can easily be achieved?

This would be the optimum for that bug!

> When i mentioned the seamless experience above, it was focused on the easy
> ability with direct formatting to mix formatting attributes together like
> bold + italics or italics + underline when clicking on the toolbar buttons,
> while this wouldnt be possible with the character style buttons, as if text
> was in bold (aka strong emphasis) and you wanted to apply italics (aka
> emphasis) to that text, it would overwrite bold with italics and not mix the
> two together as a new character style.

The overwriting is was users expect, that know was styles and soft-formatting
are doing.

> It would be great if LibreOffice had
> a style-only mode, where all applied direct formatting was turned into
> styles, iWork works in this way i believe.
> 
> If there is interest in making this styles-focused formatting toolbar, i'd
> be up to brainstorming its creation with those interested in it.

Here we are ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] dev-tools.git: vim_scripts/.ycm_extra_conf.py

[Markus Mohrhard]

 vim_scripts/.ycm_extra_conf.py |  123 +
 1 file changed, 123 insertions(+)

New commits:
commit 27cb24a38aa9550f5b6011464c38717eb45c1924
Author: Markus Mohrhard 
Date:   Sun Jan 1 19:21:15 2017 +0100

add example .ycm_extra_conf.py script for youcompleteme

Change-Id: I6a08963def7a86024c64ded0f94b201b7a43afd9

diff --git a/vim_scripts/.ycm_extra_conf.py b/vim_scripts/.ycm_extra_conf.py
new file mode 100644
index 000..4600a86
--- /dev/null
+++ b/vim_scripts/.ycm_extra_conf.py
@@ -0,0 +1,123 @@
+# This is free and unencumbered software released into the public domain.
+#
+# Anyone is free to copy, modify, publish, use, compile, sell, or
+# distribute this software, either in source code form or as a compiled
+# binary, for any purpose, commercial or non-commercial, and by any
+# means.
+#
+# In jurisdictions that recognize copyright laws, the author or authors
+# of this software dedicate any and all copyright interest in the
+# software to the public domain. We make this dedication for the benefit
+# of the public at large and to the detriment of our heirs and
+# successors. We intend this dedication to be an overt act of
+# relinquishment in perpetuity of all present and future rights to this
+# software under copyright law.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+# IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR
+# OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+# OTHER DEALINGS IN THE SOFTWARE.
+#
+# For more information, please refer to 
+
+import os
+import ycm_core
+
+# These are the compilation flags that will be used in case there's no
+# compilation database set (by default, one is not set).
+# CHANGE THIS LIST OF FLAGS. YES, THIS IS THE DROID YOU HAVE BEEN LOOKING FOR.
+flags = [
+]
+
+
+# Set this to the absolute path to the folder (NOT the file!) containing the
+# compile_commands.json file to use that instead of 'flags'. See here for
+# more details: http://clang.llvm.org/docs/JSONCompilationDatabase.html
+#
+def DirectoryOfThisScript():
+  return os.path.dirname( os.path.abspath( __file__ ) )
+
+compilation_database_folder = DirectoryOfThisScript()
+
+if os.path.exists( compilation_database_folder ):
+  database = ycm_core.CompilationDatabase( compilation_database_folder )
+else:
+  database = None
+
+SOURCE_EXTENSIONS = [ '.cpp', '.cxx', '.cc', '.c', '.m', '.mm' ]
+
+def MakeRelativePathsInFlagsAbsolute( flags, working_directory ):
+  if not working_directory:
+return list( flags )
+  new_flags = []
+  make_next_absolute = False
+  path_flags = [ '-isystem', '-I', '-iquote', '--sysroot=' ]
+  for flag in flags:
+new_flag = flag
+
+if make_next_absolute:
+  make_next_absolute = False
+  if not flag.startswith( '/' ):
+new_flag = os.path.join( working_directory, flag )
+
+for path_flag in path_flags:
+  if flag == path_flag:
+make_next_absolute = True
+break
+
+  if flag.startswith( path_flag ):
+path = flag[ len( path_flag ): ]
+new_flag = path_flag + os.path.join( working_directory, path )
+break
+
+if new_flag:
+  new_flags.append( new_flag )
+  return new_flags
+
+
+def IsHeaderFile( filename ):
+  extension = os.path.splitext( filename )[ 1 ]
+  return extension in [ '.h', '.hxx', '.hpp', '.hh' ]
+
+
+def GetCompilationInfoForFile( filename ):
+  # The compilation_commands.json file generated by CMake does not have entries
+  # for header files. So we do our best by asking the db for flags for a
+  # corresponding source file, if any. If one exists, the flags for that file
+  # should be good enough.
+  if IsHeaderFile( filename ):
+basename = os.path.splitext( filename )[ 0 ]
+for extension in SOURCE_EXTENSIONS:
+  replacement_file = basename + extension
+  if os.path.exists( replacement_file ):
+compilation_info = database.GetCompilationInfoForFile(
+  replacement_file )
+if compilation_info.compiler_flags_:
+  return compilation_info
+return None
+  return database.GetCompilationInfoForFile( filename )
+
+
+def FlagsForFile( filename, **kwargs ):
+  if database:
+# Bear in mind that compilation_info.compiler_flags_ does NOT return a
+# python list, but a "list-like" StringVec object
+compilation_info = GetCompilationInfoForFile( filename )
+if not compilation_info:
+  return None
+
+final_flags = MakeRelativePathsInFlagsAbsolute(
+  compilation_info.compiler_flags_,
+  compilation_info.compiler_working_dir_ )
+
+  else:
+relative_to = DirectoryOfThisScript()
+final_flags = MakeRelativePathsInFlagsAbsolute( flags, 

[Libreoffice-bugs] [Bug 106628] Gibberish instead of Hebrew

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106628

--- Comment #5 from Boaz Dodin  ---
My package is from the  LibreOffice Fresh ppa.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106674] Master slide selector in slide properties is blank after you edit a master slide

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106674

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1
 OS|All |Linux (All)

--- Comment #1 from Buovjaga  ---
Can you reproduce, if you launch from the command line with
SAL_USE_VCLPLUGIN=gtk libreoffice

Set to NEEDINFO.
Change back to UNCONFIRMED after you have provided the information.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106638] FILEOPEN PPTX Arial (Corps) changed to Wingdings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106638

Buovjaga  changed:

   What|Removed |Added

   Keywords||filter:pptx
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
Summary|Text incorrectly imported   |FILEOPEN PPTX Arial (Corps)
   |from this pptx file |changed to Wingdings
 Ever confirmed|0   |1
 OS|Linux (All) |All

--- Comment #6 from Buovjaga  ---
In 5.3/5.4, the character formatting is said to be Wingdings (for me
substituted because I don't have the font). In 3.6 it is empty. In 3.3 it is
Arial.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.3.1.2
Build ID: 5.3.1-1
CPU Threads: 8; OS Version: Linux 4.10; UI Render: default; VCL: kde4; Layout
Engine: new; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: 54f9a81a1c041c18d209d7eb4659ac18a3ca76dd
CPU threads: 8; OS: Linux 4.10; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on March 25th 2016

Arch Linux 64-bit
LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

Arch Linux 64-bit
Version 3.6.7.2 (Build ID: e183d5b)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106575] Correct VLOOKUP Formula - Incorrect Value shown. Shows correct value if formula reapplied / changes made in other sheets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106575

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi
Summary|Correct Formula - Incorrect |Correct VLOOKUP Formula -
   |Value shown. Shows correct  |Incorrect Value shown.
   |value if formula reapplied  |Shows correct value if
   |/ changes made in other |formula reapplied / changes
   |sheets  |made in other sheets

--- Comment #12 from Buovjaga  ---
I confirm that it needs a hard recalc (Ctrl-Shift-F9). After that and saving &
reloading, the values stay.

There have been some vlookup recalc bugs: bug 61662 (but it went away).

Not sure what can be done about this.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: 54f9a81a1c041c18d209d7eb4659ac18a3ca76dd
CPU threads: 8; OS: Linux 4.10; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on March 25th 2016

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 61662] EDITING: No immediate VLOOKUP recalc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=61662

Buovjaga  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||todven...@suomi24.fi
 Resolution|--- |WORKSFORME

--- Comment #12 from Buovjaga  ---
(In reply to Mike from comment #11)
> Cannot reproduce this bug with:
> Version: 5.2.3.2 (from Ubuntu PPA)
> or with
> Version: 5.3.0.0.beta2 (vanilla).

Great, let's close.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106569] FILEOPEN DOCX: EMF logo text appears to be a lot thicker than in Word ( default rendering only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106569

Aron Budea  changed:

   What|Removed |Added

   Keywords||notBibisectable, regression
Version|5.3.0.3 release |4.1.0.4 release
Summary|FILEOPEN DOCX: EMF logo |FILEOPEN DOCX: EMF logo
   |text appears to be a lot|text appears to be a lot
   |thicker than in Word|thicker than in Word
   ||(default rendering only)

--- Comment #6 from Aron Budea  ---
Looks bad in 4.1.0.4, looks good in 4.0.0.3.
=> regression, but it's older than Windows bibisect repos, so not bibisectable

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106642] Label and Icon view .uno:Color and .uno:BackColor

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106642

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #2 from Buovjaga  ---
(In reply to andreas_k from comment #1)
> Created attachment 132010 [details]
> Label + Icon view

How do I get a view like this? Is QA supposed to confirm this or will you
rather just confirm with design team?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106619] LO Crashed Just after v5.3.1.2 x64 and Help french was installed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106619

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #3 from Buovjaga  ---
What is the help installation file you used? Please give a link to it.

Set to NEEDINFO.
Change back to UNCONFIRMED after you have provided the information.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106628] Gibberish instead of Hebrew

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106628

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #4 from Buovjaga  ---
Not reproduced and my CTL font is FreeSans. To test I pasted עברית‎.

Is the package from Ubuntu or from ppa or TDF's package?

Arch Linux 64-bit, KDE Plasma 5
Version: 5.3.1.2
Build ID: 5.3.1-1
CPU Threads: 8; OS Version: Linux 4.10; UI Render: default; VCL: kde4; Layout
Engine: new; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106681] Feature Request: Ability to assign character styles to toolbar buttons...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106681

--- Comment #31 from LibreTraining  ---

(In reply to Regina Henschel from comment #29)

> While you are mainly talk about (2) and its UX-problems, I think (1) can be
> done immediately and would be a good enhancement. For example, it would be
> possible to make document templates with a toolbar embedded in the template,
> that contains exact that styles, which are essential for that document
> template.

That is a great idea.
I assume a notebookbar style could be used?

With your guidance and input I would be happy to work on:
 - eBook Bar
 - Long Doc Bar

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 106681] Feature Request: Ability to assign character styles to toolbar buttons...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106681

--- Comment #31 from LibreTraining  ---

(In reply to Regina Henschel from comment #29)

> While you are mainly talk about (2) and its UX-problems, I think (1) can be
> done immediately and would be a good enhancement. For example, it would be
> possible to make document templates with a toolbar embedded in the template,
> that contains exact that styles, which are essential for that document
> template.

That is a great idea.
I assume a notebookbar style could be used?

With your guidance and input I would be happy to work on:
 - eBook Bar
 - Long Doc Bar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 106623] [LOCALHELP] Write help page for PIVOT CHARTS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106623

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106613] UI: navigator in Impress/ Draw not updated immediately when page/slide is renamed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106613

Buovjaga  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1
   Severity|normal  |minor

--- Comment #3 from Buovjaga  ---
Repro. It is updated after I add a new slide. It is not updated, if I switch
from Navigator to other decks in the sidebar.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: 54f9a81a1c041c18d209d7eb4659ac18a3ca76dd
CPU threads: 8; OS: Linux 4.10; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on March 25th 2016

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106616] Formatting column width indicator for entire sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106616

Buovjaga  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||todven...@suomi24.fi

--- Comment #1 from Buovjaga  ---
Pinging design team. Should we stick an arrow in the column header, if a cell
in the column has content exceeding the width?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 106616] Formatting column width indicator for entire sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106616

Buovjaga  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||todven...@suomi24.fi

--- Comment #1 from Buovjaga  ---
Pinging design team. Should we stick an arrow in the column header, if a cell
in the column has content exceeding the width?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 106681] Feature Request: Ability to assign character styles to toolbar buttons...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106681

--- Comment #30 from LibreTraining  ---
It appears part of the problem is these ridiculous personas.
Let’s remove all the useless fluff and nonsense about politics and eating
habits and look at how they actually use LibreOffice

Primary (Beginner) Benjamin – ignorant, lazy, slacker who will only use the
bare minimum of features which he can figure-out with an absolute minimum of
effort.
So the lofty goal of the Design Team is to cater to this basic idiot.

Primary (Expert) Eve – writes studies and reviews. (how vague)
How about some info about what features she actually uses to create these
studies and reports?
This should be the Beginner/Novice. At least she has a brain and some
initiative.

Secondary (Admin) Adrian – does not even use LibreOffice. 

If these are your target audience/user that explains the lack of support for
knowledgeable users.

Where are the REAL users?

Office Worker (Beginner)
We keep seeing the reports about this government agency or that city that has
dumped MS Office and moved to LibreOffice.
What problems will they encounter?
What features do they use?
What missing features do they need?
How are they going to convert all their documents?
How are they going to standardize on new style sheets?
How are they going to attach the new style sheet when that basic feature is
still missing?!

Student/Academic (Intermediate/Advanced)
Many educational institutions support using LibreOffice.
These users will take the time to actually learn to use LibreOffice because
they need the features required to create term papers, academic studies, and
other long documents.
What features do they use?
What missing features do they need?
Why do the default settings for creating an index bear no resemblance to the
real world?
Every time these users must recreate settings which are actually required. Dumb
defaults.
Many of these documents will be submitted as PDFs, or DOCs, or ODTs.
Why is there still no way to create links in the index?
That is ridiculous.

Author (Intermediate/Advanced)
Books are written using word processors. Duh.
Today many books are only available physically print or as an ebook. 
PDFs are getting harder to find.
Where do you think the thousands and thousands of books on Amazon, iTunes, etc.
come from?
Authors write their books in Word, or LibreOffice, or other word processor.
And while doing so they have to make sure to the document is structured
properly so it will convert properly to its final form.
What features do they need?
How about a toolbar with the proper styles they need?
How about a working search for direct formatting and replace with a proper
style?


These personas are REAL users who use LibreOffice everyday for real world
applications.
Not some lowest-common-denominator lazy slacker who could use any word
processor, poorly.

The idea that the above personas are some small insignificant percentage of
users is ridiculous.
The office workers alone would be hundreds of thousands, if not millions of
users.
Upper level students, academics, authors – hundreds of thousands.

Dump these useless silly personas and replace them with some real world
personas.
Then have a goal to attract, and to support, these intelligent motivated real
users.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 106681] Feature Request: Ability to assign character styles to toolbar buttons...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106681

--- Comment #30 from LibreTraining  ---
It appears part of the problem is these ridiculous personas.
Let’s remove all the useless fluff and nonsense about politics and eating
habits and look at how they actually use LibreOffice

Primary (Beginner) Benjamin – ignorant, lazy, slacker who will only use the
bare minimum of features which he can figure-out with an absolute minimum of
effort.
So the lofty goal of the Design Team is to cater to this basic idiot.

Primary (Expert) Eve – writes studies and reviews. (how vague)
How about some info about what features she actually uses to create these
studies and reports?
This should be the Beginner/Novice. At least she has a brain and some
initiative.

Secondary (Admin) Adrian – does not even use LibreOffice. 

If these are your target audience/user that explains the lack of support for
knowledgeable users.

Where are the REAL users?

Office Worker (Beginner)
We keep seeing the reports about this government agency or that city that has
dumped MS Office and moved to LibreOffice.
What problems will they encounter?
What features do they use?
What missing features do they need?
How are they going to convert all their documents?
How are they going to standardize on new style sheets?
How are they going to attach the new style sheet when that basic feature is
still missing?!

Student/Academic (Intermediate/Advanced)
Many educational institutions support using LibreOffice.
These users will take the time to actually learn to use LibreOffice because
they need the features required to create term papers, academic studies, and
other long documents.
What features do they use?
What missing features do they need?
Why do the default settings for creating an index bear no resemblance to the
real world?
Every time these users must recreate settings which are actually required. Dumb
defaults.
Many of these documents will be submitted as PDFs, or DOCs, or ODTs.
Why is there still no way to create links in the index?
That is ridiculous.

Author (Intermediate/Advanced)
Books are written using word processors. Duh.
Today many books are only available physically print or as an ebook. 
PDFs are getting harder to find.
Where do you think the thousands and thousands of books on Amazon, iTunes, etc.
come from?
Authors write their books in Word, or LibreOffice, or other word processor.
And while doing so they have to make sure to the document is structured
properly so it will convert properly to its final form.
What features do they need?
How about a toolbar with the proper styles they need?
How about a working search for direct formatting and replace with a proper
style?


These personas are REAL users who use LibreOffice everyday for real world
applications.
Not some lowest-common-denominator lazy slacker who could use any word
processor, poorly.

The idea that the above personas are some small insignificant percentage of
users is ridiculous.
The office workers alone would be hundreds of thousands, if not millions of
users.
Upper level students, academics, authors – hundreds of thousands.

Dump these useless silly personas and replace them with some real world
personas.
Then have a goal to attract, and to support, these intelligent motivated real
users.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs