[Libreoffice-bugs] [Bug 93571] FILEOPEN: Crash on specific LO Calc document with conditional formatting repeats

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93571

Timur  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #14 from Timur  ---
Looks like fixed in 5.3 and 5.4+ so I'll close. 
Feel free to reopen if tested otherwise.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101961] OpenGL Problem with Intel HD4400

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101961

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||1138

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101138] Driver crashes on Intel on Windows 7

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101138

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||1961

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/comphelper include/toolkit rsc/source

[Stephan Bergmann]

 include/comphelper/servicehelper.hxx |8 
 include/toolkit/helper/macros.hxx|2 +-
 rsc/source/parser/rscyacc.y  |   22 +++---
 3 files changed, 16 insertions(+), 16 deletions(-)

New commits:
commit 700e262a4943a6d279cc4800bb9bd173aff0c3e1
Author: Stephan Bergmann 
Date:   Thu May 18 18:09:04 2017 +0200

Some manual loplugin:comparisonwithconstant fixes in macros...

...and other code where the plugin wouldn't rewrite automatically

Change-Id: I84cac6398cd100e9830ef7e1944f32a8af048534

diff --git a/include/comphelper/servicehelper.hxx 
b/include/comphelper/servicehelper.hxx
index d1519ed14026..38641e10d7db 100644
--- a/include/comphelper/servicehelper.hxx
+++ b/include/comphelper/servicehelper.hxx
@@ -78,8 +78,8 @@ classname* classname::getImplementation( const 
uno::Reference< uno::XInterface >
 UNO3_GETIMPLEMENTATION_BASE_IMPL(classname)\
 sal_Int64 SAL_CALL classname::getSomething( const css::uno::Sequence< sal_Int8 
>& rId ) \
 { \
-if( rId.getLength() == 16 && 0 == memcmp( 
getUnoTunnelId().getConstArray(), \
- rId.getConstArray(), 
16 ) ) \
+if( rId.getLength() == 16 && memcmp( getUnoTunnelId().getConstArray(), \
+ rId.getConstArray(), 
16 ) == 0 ) \
 { \
 return 
sal::static_int_cast(reinterpret_cast(this)); \
 } \
@@ -90,8 +90,8 @@ sal_Int64 SAL_CALL classname::getSomething( const 
css::uno::Sequence< sal_Int8 >
 UNO3_GETIMPLEMENTATION_BASE_IMPL(classname)\
 sal_Int64 SAL_CALL classname::getSomething( const css::uno::Sequence< sal_Int8 
>& rId ) \
 { \
-if( rId.getLength() == 16 && 0 == memcmp( 
getUnoTunnelId().getConstArray(), \
- rId.getConstArray(), 
16 ) ) \
+if( rId.getLength() == 16 && memcmp( getUnoTunnelId().getConstArray(), \
+ rId.getConstArray(), 
16 ) == 0 ) \
 { \
 return 
sal::static_int_cast(reinterpret_cast(this)); \
 } \
diff --git a/include/toolkit/helper/macros.hxx 
b/include/toolkit/helper/macros.hxx
index 0bb97433cbfe..8df7340912b2 100644
--- a/include/toolkit/helper/macros.hxx
+++ b/include/toolkit/helper/macros.hxx
@@ -27,7 +27,7 @@
 #define IMPL_XUNOTUNNEL_MINIMAL( ClassName ) \
 sal_Int64 ClassName::getSomething( const css::uno::Sequence< sal_Int8 >& 
rIdentifier ) \
 { \
-if( ( rIdentifier.getLength() == 16 ) && ( 0 == memcmp( 
ClassName::GetUnoTunnelId().getConstArray(), rIdentifier.getConstArray(), 16 ) 
) ) \
+if( ( rIdentifier.getLength() == 16 ) && ( memcmp( 
ClassName::GetUnoTunnelId().getConstArray(), rIdentifier.getConstArray(), 16 ) 
== 0 ) ) \
 { \
 return sal::static_int_cast< sal_Int64 >(reinterpret_cast< sal_IntPtr 
>(this)); \
 } \
diff --git a/rsc/source/parser/rscyacc.y b/rsc/source/parser/rscyacc.y
index 6fd4eda414ef..45efad4891d7 100644
--- a/rsc/source/parser/rscyacc.y
+++ b/rsc/source/parser/rscyacc.y
@@ -98,7 +98,7 @@ bool DoClassHeader( RSCHEADER * pHeader, bool bMember )
 else
 aCopyInst.pClass = pHeader->pClass;
 
-if( TYPE_COPY == pHeader->nTyp )
+if( pHeader->nTyp == TYPE_COPY )
 {
 ObjNode * pCopyObj = aCopyInst.pClass->GetObjNode( aName2 );
 
@@ -172,7 +172,7 @@ bool DoClassHeader( RSCHEADER * pHeader, bool bMember )
 }
 else if( aError.IsError() )
 {
-if( ERR_CONT_INVALIDTYPE == aError.GetError() )
+if( aError.GetError() == ERR_CONT_INVALIDTYPE )
 pTC->pEH->Error( aError, S.Top().pClass, aName1,
  pHS->getString( pHeader->pClass->GetId() 
).getStr() );
 else
@@ -187,7 +187,7 @@ bool DoClassHeader( RSCHEADER * pHeader, bool bMember )
 S.Push( aTmpI );
 }
 }
-if( TYPE_REF == pHeader->nTyp )
+if( pHeader->nTyp == TYPE_REF )
 {
 ERRTYPE aError;
 
@@ -391,7 +391,7 @@ resource_definition
 class_definition
   : class_header class_body
   {
-  if( TYPE_REF == $1.nTyp )
+  if( $1.nTyp == TYPE_REF )
   {
   pTC->pEH->Error( ERR_REFNOTALLOWED, S.Top().pClass,
RscId( $1.nName1 ) );
@@ -403,9 +403,9 @@ class_definition
   ERRTYPE aError;
   RscId aRscId( $1.nName1 );
 
-  if( TYPE_NOTHING == $1.nTyp && aRscId.IsId() )
+  if( $1.nTyp == TYPE_NOTHING && aRscId.IsId() )
   aError = S.Top().pClass->SetRef( S.Top(), aRscId );
-  else if( TYPE_COPY == $1.nTyp )
+  else if( $1.nTyp == TYPE_COPY )
   aError = ERR_COPYNOTALLOWED;
   if( aError.IsError() || aError.IsWarning() )
   pTC->pEH->Error( aError, S.Top().pClass, aRscId );
@@ -506,7 +506,7 @@ var_definition
   | class_definition ';'
   | var_header_class class_body ';'
   {
-  if( TYPE_REF == $1.nTyp )
+  if( 

[Libreoffice-commits] core.git: cui/source sd/source sfx2/source svx/source sw/source vcl/source xmloff/source

[Stephan Bergmann]

 cui/source/tabpages/numpages.cxx   |2 +-
 sd/source/core/stlsheet.cxx|2 +-
 sfx2/source/doc/SfxDocumentMetaData.cxx|2 +-
 sfx2/source/doc/docinsert.cxx  |2 +-
 svx/source/table/cell.cxx  |2 +-
 svx/source/unodraw/unoshape.cxx|2 +-
 sw/source/filter/docx/swdocxreader.cxx |2 +-
 vcl/source/gdi/sallayout.cxx   |2 +-
 xmloff/source/text/XMLTextFrameContext.cxx |2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)

New commits:
commit c345299186841ccb1fe846f6f277039c188941d6
Author: Stephan Bergmann 
Date:   Thu May 18 18:04:20 2017 +0200

Remove parentheses around some comparisons

...where Clang would otherwise start to emit -Wparentheses-equality as soon 
as
the order of arguments were switched by loplugin:comparisonwithconstant

Change-Id: If064c2c6e2f81478154395137138b71f2d1c6534

diff --git a/cui/source/tabpages/numpages.cxx b/cui/source/tabpages/numpages.cxx
index f785bbec456e..e6d35cf4e517 100644
--- a/cui/source/tabpages/numpages.cxx
+++ b/cui/source/tabpages/numpages.cxx
@@ -1410,7 +1410,7 @@ voidSvxNumOptionsTabPage::Reset( const SfxItemSet* 
rSet )
 {
 sal_uInt16 nEntryData = 
(sal_uInt16)reinterpret_cast(m_pFmtLB->GetEntryData(i - 1));
 if(/*SVX_NUM_NUMBER_NONE == nEntryData ||*/
-((SVX_NUM_BITMAP|LINK_TOKEN) ==  nEntryData))
+(SVX_NUM_BITMAP|LINK_TOKEN) ==  nEntryData)
 m_pFmtLB->RemoveEntry(i - 1);
 }
 }
diff --git a/sd/source/core/stlsheet.cxx b/sd/source/core/stlsheet.cxx
index 2c34c5e068c9..9d984d001d02 100644
--- a/sd/source/core/stlsheet.cxx
+++ b/sd/source/core/stlsheet.cxx
@@ -1217,7 +1217,7 @@ PropertyState SAL_CALL SdStyleSheet::getPropertyState( 
const OUString& PropertyN
 }
 
 // if a item is set, this doesn't mean we want it :)
-if( ( PropertyState_DIRECT_VALUE == eState ) )
+if( PropertyState_DIRECT_VALUE == eState )
 {
 switch( pEntry->nWID )
 {
diff --git a/sfx2/source/doc/SfxDocumentMetaData.cxx 
b/sfx2/source/doc/SfxDocumentMetaData.cxx
index 606b4001c2bb..fa34dc6e498a 100644
--- a/sfx2/source/doc/SfxDocumentMetaData.cxx
+++ b/sfx2/source/doc/SfxDocumentMetaData.cxx
@@ -746,7 +746,7 @@ SfxDocumentMetaData::setMetaList(const char* i_name,
 
 // if nothing changed, do nothing
 // alas, this does not check for permutations, or attributes...
-if ((nullptr == i_pAttrs)) {
+if (nullptr == i_pAttrs) {
 if (static_cast(i_rValue.getLength()) == vec.size()) {
 bool isEqual(true);
 for (sal_Int32 i = 0; i < i_rValue.getLength(); ++i) {
diff --git a/sfx2/source/doc/docinsert.cxx b/sfx2/source/doc/docinsert.cxx
index 30cdb908ba11..5957b0fa4d92 100644
--- a/sfx2/source/doc/docinsert.cxx
+++ b/sfx2/source/doc/docinsert.cxx
@@ -255,7 +255,7 @@ IMPL_LINK_NOARG(DocumentInserter, DialogClosedHdl, 
sfx2::FileDialogHelper*, void
 m_pItemSet->Put( SfxBoolItem( SID_DOC_READONLY, true ) );
 else
 {
-if ( ( TemplateDescription::FILEOPEN_READONLY_VERSION == nDlgType 
) )
+if ( TemplateDescription::FILEOPEN_READONLY_VERSION == nDlgType )
 {
 try
 {
diff --git a/svx/source/table/cell.cxx b/svx/source/table/cell.cxx
index 3483a7d3bdcb..5266e5e2165f 100644
--- a/svx/source/table/cell.cxx
+++ b/svx/source/table/cell.cxx
@@ -1425,7 +1425,7 @@ PropertyState SAL_CALL Cell::getPropertyState( const 
OUString& PropertyName )
 }
 
 // if a item is set, this doesn't mean we want it :)
-if( ( PropertyState_DIRECT_VALUE == eState ) )
+if( PropertyState_DIRECT_VALUE == eState )
 {
 switch( pMap->nWID )
 {
diff --git a/svx/source/unodraw/unoshape.cxx b/svx/source/unodraw/unoshape.cxx
index 7cc707c7f510..ba50ddedc577 100644
--- a/svx/source/unodraw/unoshape.cxx
+++ b/svx/source/unodraw/unoshape.cxx
@@ -2017,7 +2017,7 @@ beans::PropertyState SAL_CALL 
SvxShape::_getPropertyState( const OUString& Prope
 }
 
 // if a item is set, this doesn't mean we want it :)
-if( ( beans::PropertyState_DIRECT_VALUE == eState ) )
+if( beans::PropertyState_DIRECT_VALUE == eState )
 {
 switch( pMap->nWID )
 {
diff --git a/sw/source/filter/docx/swdocxreader.cxx 
b/sw/source/filter/docx/swdocxreader.cxx
index 501b0e567a18..bba7dd1ff723 100644
--- a/sw/source/filter/docx/swdocxreader.cxx
+++ b/sw/source/filter/docx/swdocxreader.cxx
@@ -151,7 +151,7 @@ bool SwDOCXReader::MakeEntries( SwDoc *pD, SwTextBlocks 
 )
 if( rIdx.GetNode().GetTextNode() &&
 rIdx.GetNode().GetTextNode()->GetText().isEmpty() )
 rIdx = aStart.GetNode().EndOfSectionIndex() - 

[Libreoffice-bugs] [Bug 107934] New: cannot select text with mouse on a computer with touch screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107934

Bug ID: 107934
   Summary: cannot select text with mouse on a computer with touch
screen
   Product: LibreOffice Online
   Version: unspecified
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: uzno...@yahoo.com

Created attachment 133389
  --> https://bugs.documentfoundation.org/attachment.cgi?id=133389=edit
odd behavior when dragging a shape

On my win10 laptop with a touch screen, there is this problem. In the TDF
instance of LO Online, when I try to use mouse to select some text, it doesn't
allow me. The behavior is as if the selection is a "pan" touch motion event.
Also, there is an odd behavior when i drag a shape as shown in the attachment.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/tools sw/source

[Jan Holesovsky]

 include/tools/mapunit.hxx |   14 --
 sw/source/core/inc/rootfrm.hxx|3 +++
 sw/source/core/layout/newfrm.cxx  |2 +-
 sw/source/core/layout/pagechg.cxx |6 ++
 4 files changed, 10 insertions(+), 15 deletions(-)

New commits:
commit 1be2684512e5ad21526c65ee04acf2c71a8691b6
Author: Jan Holesovsky 
Date:   Thu May 18 13:25:31 2017 +0200

sw lok: Make the default for the Web view larger.

Change-Id: I943711e084adcfa0af2a79cf83d5c3e1b6dc45e6
Reviewed-on: https://gerrit.libreoffice.org/37758
Tested-by: Jenkins 
Reviewed-by: Jan Holesovsky 

diff --git a/include/tools/mapunit.hxx b/include/tools/mapunit.hxx
index 334e2f5202bf..2209f4d35261 100644
--- a/include/tools/mapunit.hxx
+++ b/include/tools/mapunit.hxx
@@ -34,20 +34,14 @@ enum class MapUnit
 LASTENUMDUMMY // used as an error return
 };
 
-inline sal_Int64 convertTwipToMm100(sal_Int64 n)
+constexpr sal_Int64 convertTwipToMm100(sal_Int64 n)
 {
-if (n >= 0)
-return (n*127+36)/72;
-else
-return (n*127-36)/72;
+return (n >= 0)? (n*127+36)/72: (n*127-36)/72;
 }
 
-inline sal_Int64 convertMm100ToTwip(sal_Int64 n)
+constexpr sal_Int64 convertMm100ToTwip(sal_Int64 n)
 {
-if (n >= 0)
-return (n*72+63)/127;
-else
-return (n*72-63)/127;
+return (n >= 0)? (n*72+63)/127: (n*72-63)/127;
 }
 
 #endif
diff --git a/sw/source/core/inc/rootfrm.hxx b/sw/source/core/inc/rootfrm.hxx
index 15efe013af46..66a3e590a490 100644
--- a/sw/source/core/inc/rootfrm.hxx
+++ b/sw/source/core/inc/rootfrm.hxx
@@ -96,6 +96,9 @@ class SwRootFrame: public SwLayoutFrame
 static bool   s_isInPaint; // Protection against double Paints
 static bool   s_isNoVirDev;// No virt. Device for SystemPaints
 
+/// Width of the HTML / Web document if not defined otherwise: 20cm.
+static constexpr sal_Int64 MIN_BROWSE_WIDTH = convertMm100ToTwip(2);
+
 boolmbCheckSuperfluous   :1; // Search for empty Pages?
 boolmbIdleFormat :1; // Trigger Idle Formatter?
 boolmbBrowseWidthValid   :1; // Is mnBrowseWidth valid?
diff --git a/sw/source/core/layout/newfrm.cxx b/sw/source/core/layout/newfrm.cxx
index e1a96cd25ac1..b5785c4b0330 100644
--- a/sw/source/core/layout/newfrm.cxx
+++ b/sw/source/core/layout/newfrm.cxx
@@ -464,7 +464,7 @@ SwRootFrame::SwRootFrame( SwFrameFormat *pFormat, 
SwViewShell * pSh ) :
 mbIsNewLayout( true ),
 mbCallbackActionEnabled ( false ),
 mbLayoutFreezed ( false ),
-mnBrowseWidth( MM50*4 ), //2cm minimum
+mnBrowseWidth(MIN_BROWSE_WIDTH),
 mpTurbo( nullptr ),
 mpLastPage( nullptr ),
 mpCurrShell( pSh ),
diff --git a/sw/source/core/layout/pagechg.cxx 
b/sw/source/core/layout/pagechg.cxx
index 9f61fab99771..906566892ecc 100644
--- a/sw/source/core/layout/pagechg.cxx
+++ b/sw/source/core/layout/pagechg.cxx
@@ -1604,10 +1604,8 @@ void SwRootFrame::ImplCalcBrowseWidth()
 
 mbBrowseWidthValid = true;
 SwViewShell *pSh = getRootFrame()->GetCurrShell();
-mnBrowseWidth = pSh
-? MINLAY + 2 * pSh->GetOut()->
-PixelToLogic( pSh->GetBrowseBorder() ).Width()
-: 5000;
+mnBrowseWidth = (!comphelper::LibreOfficeKit::isActive() && pSh)? MINLAY + 
2 * pSh->GetOut()-> PixelToLogic( pSh->GetBrowseBorder() ).Width(): 
MIN_BROWSE_WIDTH;
+
 do
 {
 if ( pFrame->IsInTab() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107933] New: description missing in customize dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107933

Bug ID: 107933
   Summary: description missing in customize dialog
   Product: LibreOffice
   Version: 5.3.3.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gautier.sop...@gmail.com

Description:
Description of commands are missing in the Description area of the Customize
dialog under the Menus, Context Menus and Toolbars tabs.


Steps to Reproduce:
1.Select Tools > Customize > Menus tab
2.Click on Add Command button
3.Click on any Category and Commands in the dialog that opens

Actual Results:  
Description area is active but remains empty

Expected Results:
Description of the commands is displayed in the area


Reproducible: Always

User Profile Reset: No

Additional Info:
Checked also in the FR version, no description is displayed too


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:53.0) Gecko/20100101
Firefox/53.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107728] FILESAVE: xlsx files always exported with comments shown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107728

--- Comment #8 from Buovjaga  ---
(In reply to Magnus Jacobsson from comment #7)
> (In reply to Buovjaga from comment #6)
> > Focus on the version: 4.2 is beyond obsolete. Test with 5.3. Closing.
> 
> It's not available on Ubuntu 14.04.5 LTS:

I know. Either switch to newer Ubuntu or use this ppa
https://launchpad.net/~libreoffice/+archive/ubuntu/ppa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107728] FILESAVE: xlsx files always exported with comments shown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107728

--- Comment #7 from Magnus Jacobsson  ---
(In reply to Buovjaga from comment #6)
> Focus on the version: 4.2 is beyond obsolete. Test with 5.3. Closing.

It's not available on Ubuntu 14.04.5 LTS:

> sudo apt-get install libreoffice
Reading package lists... Done
Building dependency tree   
Reading state information... Done
libreoffice is already the newest version.
The following packages were automatically installed and are no longer required:
  ant ant-optional gcc-4.8-base:i386 gyp libandroid-json-org-java
  libargs4j-java libatinject-jsr330-api-java libc-ares-dev libc-ares2
  libclang-common-3.8-dev libclang1-3.8 libclosure-compiler-java libguava-java
  libjs-node-uuid libjsr305-java libllvm3.8v4 libv8-3.14-dev libv8-3.14.5
  libxerces2-java libxml-commons-external-java libxml-commons-resolver1.1-java
  linux-headers-3.13.0-39 linux-headers-3.13.0-39-generic
  linux-image-3.13.0-39-generic linux-image-extra-3.13.0-39-generic llvm
  llvm-3.8 llvm-3.8-dev llvm-3.8-runtime llvm-runtime
Use 'apt-get autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 275 not upgraded.
> libreoffice --version
LibreOffice 4.2.8.2 420m0(Build:2)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: reportdesign/source

[Caolán McNamara]

 reportdesign/source/core/sdr/UndoActions.cxx  |2 +-
 reportdesign/source/ui/inspection/GeometryHandler.cxx |4 ++--
 reportdesign/source/ui/report/ReportController.cxx|6 +++---
 reportdesign/source/ui/report/SectionWindow.cxx   |3 ++-
 4 files changed, 8 insertions(+), 7 deletions(-)

New commits:
commit 8b1101023f01b2c7478a014b5ead73ada4fd4861
Author: Caolán McNamara 
Date:   Thu May 18 16:26:42 2017 +0100

drop toString

Change-Id: I0f67c8931523bbe90bfbc8cc7d9a5bd523758ee5

diff --git a/reportdesign/source/core/sdr/UndoActions.cxx 
b/reportdesign/source/core/sdr/UndoActions.cxx
index 390b9a0b8540..aedab260613f 100644
--- a/reportdesign/source/core/sdr/UndoActions.cxx
+++ b/reportdesign/source/core/sdr/UndoActions.cxx
@@ -383,7 +383,7 @@ void ORptUndoPropertyAction::setProperty(bool _bOld)
 
 OUString ORptUndoPropertyAction::GetComment() const
 {
-OUString aStr( ModuleRes(RID_STR_UNDO_PROPERTY).toString() );
+OUString aStr( ModuleRes(RID_STR_UNDO_PROPERTY) );
 
 return aStr.replaceFirst("#", m_aPropertyName);
 }
diff --git a/reportdesign/source/ui/inspection/GeometryHandler.cxx 
b/reportdesign/source/ui/inspection/GeometryHandler.cxx
index a50e3e01a40b..8297cba94832 100644
--- a/reportdesign/source/ui/inspection/GeometryHandler.cxx
+++ b/reportdesign/source/ui/inspection/GeometryHandler.cxx
@@ -1751,7 +1751,7 @@ void 
GeometryHandler::impl_fillScopeList_nothrow(::std::vector< OUString >& _out
 else if ( xSection == xReportDefinition->getDetail() )
 nPos = xGroups->getCount()-1;
 
-const OUString sGroup = ModuleRes(RID_STR_SCOPE_GROUP).toString();
+const OUString sGroup = ModuleRes(RID_STR_SCOPE_GROUP);
 for (sal_Int32 i = 0 ; i <= nPos ; ++i)
 {
 xGroup.set(xGroups->getByIndex(i),uno::UNO_QUERY_THROW);
@@ -1778,7 +1778,7 @@ uno::Reference< report::XFunctionsSupplier> 
GeometryHandler::fillScope_throw(OUS
 const uno::Reference< report::XGroup> 
xGroup(xSection->getGroup(),uno::UNO_QUERY);
 if ( xGroup.is() )
 {
-OUString sGroupName = ModuleRes(RID_STR_SCOPE_GROUP).toString();
+OUString sGroupName = ModuleRes(RID_STR_SCOPE_GROUP);
 _rsNamePostfix = xGroup->getExpression();
 m_sScope = sGroupName.replaceFirst("%1",_rsNamePostfix);
 xReturn = xGroup.get();
diff --git a/reportdesign/source/ui/report/ReportController.cxx 
b/reportdesign/source/ui/report/ReportController.cxx
index 2404ff61e236..d89b20903a21 100644
--- a/reportdesign/source/ui/report/ReportController.cxx
+++ b/reportdesign/source/ui/report/ReportController.cxx
@@ -2906,7 +2906,7 @@ uno::Reference 
OReportController::executeReport()
 
 // our first message says: we caught an exception
 sdb::SQLContext aFirstMessage;
-OUString 
sInfo(ModuleRes(RID_STR_CAUGHT_FOREIGN_EXCEPTION).toString());
+OUString sInfo(ModuleRes(RID_STR_CAUGHT_FOREIGN_EXCEPTION));
 sInfo = sInfo.replaceAll("$type$", 
aCaughtException.getValueTypeName());
 aFirstMessage.Message = sInfo;
 
@@ -3261,12 +3261,12 @@ void OReportController::createPageNumber(const 
Sequence< PropertyValue >& _aArgs
 SequenceAsHashMap aMap(_aArgs);
 bool bStateOfPage = aMap.getUnpackedValueOrDefault(PROPERTY_STATE, false);
 
-OUString sFunction( ModuleRes(STR_RPT_PN_PAGE).toString() );
+OUString sFunction( ModuleRes(STR_RPT_PN_PAGE) );
 sFunction = sFunction.replaceFirst("#PAGENUMBER#", "PageNumber()");
 
 if ( bStateOfPage )
 {
-sFunction += ModuleRes(STR_RPT_PN_PAGE_OF).toString();
+sFunction += ModuleRes(STR_RPT_PN_PAGE_OF);
 sFunction = sFunction.replaceFirst("#PAGECOUNT#", "PageCount()");
 }
 
diff --git a/reportdesign/source/ui/report/SectionWindow.cxx 
b/reportdesign/source/ui/report/SectionWindow.cxx
index 502609531ec0..6e4a3fa386e6 100644
--- a/reportdesign/source/ui/report/SectionWindow.cxx
+++ b/reportdesign/source/ui/report/SectionWindow.cxx
@@ -191,7 +191,8 @@ bool OSectionWindow::setGroupSectionTitle(const 
uno::Reference< report::XGroup>&
 sExpression = sLabel;
 }
 
-OUString sTitle( ModuleRes(_nResId).toString() );
+ModuleRes aRes(_nResId);
+OUString sTitle(aRes);
 sTitle = sTitle.replaceFirst("#", sExpression);
 m_aStartMarker->setTitle( sTitle );
 m_aStartMarker->Invalidate(InvalidateFlags::Children);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107728] FILESAVE: xlsx files always exported with comments shown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107728

Buovjaga  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #6 from Buovjaga  ---
Focus on the version: 4.2 is beyond obsolete. Test with 5.3. Closing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107728] FILESAVE: xlsx files always exported with comments shown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107728

Magnus Jacobsson  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

--- Comment #5 from Magnus Jacobsson  ---
If I hide the comment, save and reload, it does not stay hidden. Reopening.

Libreoffice Version: 4.2.8.2 Build ID: 420m0(Build:2)

> lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:Ubuntu 14.04.5 LTS
Release:14.04
Codename:   trusty

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107728] FILESAVE: xlsx files always exported with comments shown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107728

Buovjaga  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #4 from Buovjaga  ---
(In reply to Magnus Jacobsson from comment #3)
> Created attachment 133388 [details]
> Sample document

If I hide the comment, save and reload, it stays hidden. Closing.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.3.2.2
Build ID: 5.3.2-3
CPU Threads: 8; OS Version: Linux 4.10; UI Render: default; VCL: kde4; Layout
Engine: new; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

minutes of ESC call ...

[Michael Meeks]

* Present:
+ Caolan, Christian, Heiko, Kendy, JanI, Olivier, Xisco, Michael M,
  Sophie, Stephan, Miklos, Bjoern, Bubli, Eike, Norbert
 
* Completed Action Items:
+ dig out online E-mail from Andras & put on-line (Cloph)
   [ re-built the package to mend it (Timar) ]
+ mass conversion of helpcontent (Cloph)
   [ Translations are done; one thing left the xmllang default attribute 
change ]

* Pending Action Items:

* Release Engineering update (Christian)
+ 5.4.0 Beta 1 May 16th
  + tagged and up-loaded the beta build to early testing.
  + late features
+ Windows support for gpg sign/encrypt (Thorsten)
   + merged & reverted – with some issues in Jenkins.
+ 5.4.0 Beta 2 – June 6th
  + no additional reviews necessary on the branch, can push yourself until 
June 20th
+ 5.3.4 RC1 – after next week – May 30th
  + looking forward to seeing the crash / gdi fixes (Michael)
+ Android & iOS Remote
+ online
  + Andras is preparing the branch 
+ problems with replication to freedesktop
  + guillhelm looking at gerrit – leaking file-descriptors ? 

* Documentation (Olivier)
+ lots of encouraging contributions this week.
+ Patches, patches patches in helpcontent (tdf#84675)
+ fixes from translators (HC)
+ Nice HC contributions by Gabor Kelemen, Laurent Balland-Poirier, Cloph

* UX Update (Heiko)
   + Bugzilla (topicUI) statistics
256(256) (topicUI) bugs open, 465(465) (needsUXEval) needs to be 
evaluated by the UXteam
+ Updates:
BZ changes   1 week   1 month   3 months   12 months  
 added  5(1) 15(3) 37(4)  465(-2) 
 commented 60(20)   209(44)   546(11)3517(-7) 
   removed  0(0)  3(0)  7(0)   41(-1) 
  resolved  2(0) 11(-1)49(-29)230(0)  
+ top 10 contributors:
  Philips, Yousuf made 198 changes in 1 month, and 1371 changes in 1 
year
  Tietze, Heiko made 52 changes in 1 month, and 2013 changes in 1 year
  Buovjaga made 48 changes in 1 month, and 383 changes in 1 year
  Foote, V Stuart made 36 changes in 1 month, and 653 changes in 1 year
  Thomas Lendo made 25 changes in 1 month, and 110 changes in 1 year
  Iversen, Jan made 18 changes in 1 month, and 335 changes in 1 year
  Telesto made 14 changes in 1 month, and 58 changes in 1 year
  Faulí Tarazona, Xisco made 13 changes in 1 month, and 412 changes in 
1 year
  Henschel, Regina made 13 changes in 1 month, and 129 changes in 1 year
  LibreTraining made 12 changes in 1 month, and 51 changes in 1 year

+ vacation is impossible
+ returning had – 1000 mails/w ;-)
+ heated discussion about image compression, when, how, what tdf#34133
   + made a proposal on the workflow; pro. user feedback
   + if people want to know how these are compressed – poke the ticket.
   + auto-compressing images etc.
+ planning survey on default page margins – 2cm currently
   + what default do people want ?
+ desire to have a commmon goal / strategy / headline for (major) releases
  in the design team, e.g. bugfixing, notebookbar, dialogs...
   + “we all work on XYZ topic”
  + doomed as an approach, unless it’s just marketing (Michael)
 + like post-rationalization eg. MUFFIN.
 + agreed (Bjoern)
 + without power to commit resources, not wise to promise

* Crash Reporting (Caolan)
+ 2(+0) import failure, 0(+0) export failures
   + need to spend some time on crash testing to find these 2.
+ 49 coverity issues (down)
+ Google / ossfuzz: unchanged no fuzzers active now, ww6 added, ww8 
smoketesting
   + fixed a local crasher in ww8 – to add to queue in next few days.
   + PPT has just one version, looking good. Excel pending.
   + docx, and ODF formats pending.
   + coming to the end here (hopefully)
+ results depend on the input ? (Xisco)
   + they find their own input (Caolan)
  + using minimal set of documents – that exercises most of LibreOffice
  + using the corpus minimiser from AFL – to get smallest set that 
maximises
that space.
  + http://dev-www.libreoffice.org/corpus/

* Hackfests (Bjoern)
+ next venues / suggestions
+ Ladies who FOSS ? (Bubli)
+ Italian hack-fest coming up: 4 days May 27-30th
 + Expectation match on Presentations etc.
 + no idea wrt. Presentations (Eike)
AI:  + ask Osvaldo for an agenda (Eike)
 + Perugia University
 + https://wiki.documentfoundation.org/Hackfest/Perugia2017
+ Eike, Miklos, Cloph signed up.
+ Bjoern can’t come sadly.
+ Berlin meeting (Bubli)
+ Hamburg meeting exploded so to Berlin.
+ German community event
+ Weekend of June 23 → 25 – Friday → Sun.
+ Open Tech 

[Libreoffice-qa] minutes of ESC call ...

[Michael Meeks]

* Present:
+ Caolan, Christian, Heiko, Kendy, JanI, Olivier, Xisco, Michael M,
  Sophie, Stephan, Miklos, Bjoern, Bubli, Eike, Norbert
 
* Completed Action Items:
+ dig out online E-mail from Andras & put on-line (Cloph)
   [ re-built the package to mend it (Timar) ]
+ mass conversion of helpcontent (Cloph)
   [ Translations are done; one thing left the xmllang default attribute 
change ]

* Pending Action Items:

* Release Engineering update (Christian)
+ 5.4.0 Beta 1 May 16th
  + tagged and up-loaded the beta build to early testing.
  + late features
+ Windows support for gpg sign/encrypt (Thorsten)
   + merged & reverted – with some issues in Jenkins.
+ 5.4.0 Beta 2 – June 6th
  + no additional reviews necessary on the branch, can push yourself until 
June 20th
+ 5.3.4 RC1 – after next week – May 30th
  + looking forward to seeing the crash / gdi fixes (Michael)
+ Android & iOS Remote
+ online
  + Andras is preparing the branch 
+ problems with replication to freedesktop
  + guillhelm looking at gerrit – leaking file-descriptors ? 

* Documentation (Olivier)
+ lots of encouraging contributions this week.
+ Patches, patches patches in helpcontent (tdf#84675)
+ fixes from translators (HC)
+ Nice HC contributions by Gabor Kelemen, Laurent Balland-Poirier, Cloph

* UX Update (Heiko)
   + Bugzilla (topicUI) statistics
256(256) (topicUI) bugs open, 465(465) (needsUXEval) needs to be 
evaluated by the UXteam
+ Updates:
BZ changes   1 week   1 month   3 months   12 months  
 added  5(1) 15(3) 37(4)  465(-2) 
 commented 60(20)   209(44)   546(11)3517(-7) 
   removed  0(0)  3(0)  7(0)   41(-1) 
  resolved  2(0) 11(-1)49(-29)230(0)  
+ top 10 contributors:
  Philips, Yousuf made 198 changes in 1 month, and 1371 changes in 1 
year
  Tietze, Heiko made 52 changes in 1 month, and 2013 changes in 1 year
  Buovjaga made 48 changes in 1 month, and 383 changes in 1 year
  Foote, V Stuart made 36 changes in 1 month, and 653 changes in 1 year
  Thomas Lendo made 25 changes in 1 month, and 110 changes in 1 year
  Iversen, Jan made 18 changes in 1 month, and 335 changes in 1 year
  Telesto made 14 changes in 1 month, and 58 changes in 1 year
  Faulí Tarazona, Xisco made 13 changes in 1 month, and 412 changes in 
1 year
  Henschel, Regina made 13 changes in 1 month, and 129 changes in 1 year
  LibreTraining made 12 changes in 1 month, and 51 changes in 1 year

+ vacation is impossible
+ returning had – 1000 mails/w ;-)
+ heated discussion about image compression, when, how, what tdf#34133
   + made a proposal on the workflow; pro. user feedback
   + if people want to know how these are compressed – poke the ticket.
   + auto-compressing images etc.
+ planning survey on default page margins – 2cm currently
   + what default do people want ?
+ desire to have a commmon goal / strategy / headline for (major) releases
  in the design team, e.g. bugfixing, notebookbar, dialogs...
   + “we all work on XYZ topic”
  + doomed as an approach, unless it’s just marketing (Michael)
 + like post-rationalization eg. MUFFIN.
 + agreed (Bjoern)
 + without power to commit resources, not wise to promise

* Crash Reporting (Caolan)
+ 2(+0) import failure, 0(+0) export failures
   + need to spend some time on crash testing to find these 2.
+ 49 coverity issues (down)
+ Google / ossfuzz: unchanged no fuzzers active now, ww6 added, ww8 
smoketesting
   + fixed a local crasher in ww8 – to add to queue in next few days.
   + PPT has just one version, looking good. Excel pending.
   + docx, and ODF formats pending.
   + coming to the end here (hopefully)
+ results depend on the input ? (Xisco)
   + they find their own input (Caolan)
  + using minimal set of documents – that exercises most of LibreOffice
  + using the corpus minimiser from AFL – to get smallest set that 
maximises
that space.
  + http://dev-www.libreoffice.org/corpus/

* Hackfests (Bjoern)
+ next venues / suggestions
+ Ladies who FOSS ? (Bubli)
+ Italian hack-fest coming up: 4 days May 27-30th
 + Expectation match on Presentations etc.
 + no idea wrt. Presentations (Eike)
AI:  + ask Osvaldo for an agenda (Eike)
 + Perugia University
 + https://wiki.documentfoundation.org/Hackfest/Perugia2017
+ Eike, Miklos, Cloph signed up.
+ Bjoern can’t come sadly.
+ Berlin meeting (Bubli)
+ Hamburg meeting exploded so to Berlin.
+ German community event
+ Weekend of June 23 → 25 – Friday → Sun.
+ Open Tech 

[Libreoffice-commits] core.git: configure.ac

[Stephan Bergmann]

 configure.ac |   31 ---
 1 file changed, 31 deletions(-)

New commits:
commit 19e3af45fc8b53092f79e44485ac46b2ac80a197
Author: Stephan Bergmann 
Date:   Mon Mar 6 11:46:47 2017 +0100

Remove some dated configure checks after LO 5.4 branch-off

See b167466147baec95a3b123a07d648fc2589bc3c9 "Remove HAVE_CXX11_CONSTEXPR,
always true now" and f4884d051f1eea07a0fe371834cb7c1da1cbee07 "Remove
HAVE_CXX11_UTF16_STRING_LITERAL, always true now".  By now, any outdated
builders where this would fail should have been identified and taken care 
of.

Change-Id: If36354210f847718a507da490ccf158db8cea34a
Reviewed-on: https://gerrit.libreoffice.org/34922
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/configure.ac b/configure.ac
index 7286781a7f08..e535e9b7f871 100644
--- a/configure.ac
+++ b/configure.ac
@@ -6314,23 +6314,6 @@ CXXFLAGS=$save_CXXFLAGS
 
 AC_SUBST(CXXFLAGS_CXX11)
 
-AC_MSG_CHECKING([whether $CXX supports C++11 constexpr])
-save_CXXFLAGS=$CXXFLAGS
-CXXFLAGS="$CXXFLAGS $CXXFLAGS_CXX11"
-AC_LANG_PUSH([C++])
-AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
-struct S {
-int n_;
-constexpr S(int n): n_(n) {}
-};
-]])], [cxx11_constexpr=yes], [cxx11_constexpr=no])
-AC_LANG_POP([C++])
-CXXFLAGS=$save_CXXFLAGS
-AC_MSG_RESULT([$cxx11_constexpr])
-if test "$cxx11_constexpr" = no; then
-AC_MSG_ERROR([Your $CXX does not support 'constexpr'. This is no longer 
supported.])
-fi
-
 AC_MSG_CHECKING([whether $CXX supports C++14 constexpr])
 save_CXXFLAGS=$CXXFLAGS
 CXXFLAGS="$CXXFLAGS $CXXFLAGS_CXX11"
@@ -6384,20 +6367,6 @@ if test "$cxx11_ref_qualifier" = yes; then
 AC_DEFINE([HAVE_CXX11_REF_QUALIFIER])
 fi
 
-AC_MSG_CHECKING([whether $CXX supports C++11 char16_t string literals])
-save_CXXFLAGS=$CXXFLAGS
-CXXFLAGS="$CXXFLAGS $CXXFLAGS_CXX11"
-AC_LANG_PUSH([C++])
-AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
-auto s = u"";
-]])], [cxx11_utf16_string_literal=yes], [cxx11_utf16_string_literal=no])
-AC_LANG_POP([C++])
-CXXFLAGS=$save_CXXFLAGS
-AC_MSG_RESULT([$cxx11_utf16_string_literal])
-if test "$cxx11_utf16_string_literal" = no; then
-AC_MSG_ERROR([Your $CXX does not support UTF-16 string literals. This is 
no longer supported.])
-fi
-
 dnl _Pragma support (may require C++11)
 if test "$GCC" = "yes" -o "$COM_IS_CLANG" = TRUE; then
 AC_MSG_CHECKING([whether $CXX supports _Pragma operator])
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dev-tools.git: ciabot/libreoffice-bugzilla2.py

[Markus Mohrhard]

 ciabot/libreoffice-bugzilla2.py |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 80319fe1173f43bc75a6c0c1a7d063ceb7a4ab59
Author: Markus Mohrhard 
Date:   Thu May 18 16:46:14 2017 +0200

update master target for git bugzilla integration

diff --git a/ciabot/libreoffice-bugzilla2.py b/ciabot/libreoffice-bugzilla2.py
index 0dbb925..402d36c 100644
--- a/ciabot/libreoffice-bugzilla2.py
+++ b/ciabot/libreoffice-bugzilla2.py
@@ -33,7 +33,7 @@ import bugzilla
 from bugzilla import Bugzilla
 from bugzilla.base import _BugzillaToken
 
-master_target = "5.4.0"
+master_target = "5.5.0"
 bug_regex = "(?:tdf|fdo)#(\d+)"
 dry_run = False
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dev-tools.git: esc-reporting/esc-analyze.py

[jan Iversen]

 esc-reporting/esc-analyze.py |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 718cf68abe7cc59e5dc8d001412a2121a95f1635
Author: jan Iversen 
Date:   Thu May 18 16:34:28 2017 +0200

esc-report, reinstate try/Except for run_final

diff --git a/esc-reporting/esc-analyze.py b/esc-reporting/esc-analyze.py
index 6923552..de7ec26 100755
--- a/esc-reporting/esc-analyze.py
+++ b/esc-reporting/esc-analyze.py
@@ -931,11 +931,11 @@ def runAnalyze():
 except Exception as e:
   print('ERROR: analyze_reports failed with ' + str(e))
   pass
-#try:
-analyze_final()
-#except Exception as e:
-#  print('ERROR: analyze_final failed with ' + str(e))
-#  pass
+try:
+  analyze_final()
+except Exception as e:
+   print('ERROR: analyze_final failed with ' + str(e))
+   pass
 
 
 def runUpgrade(args):
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dev-tools.git: esc-reporting/esc-analyze.py

[jan Iversen]

 esc-reporting/esc-analyze.py |   17 +
 1 file changed, 9 insertions(+), 8 deletions(-)

New commits:
commit 014861ed6b999ef0ea3684ac5debcd2cafc72005
Author: jan Iversen 
Date:   Thu May 18 16:31:05 2017 +0200

esc-report: QAstat problem, user was int

diff --git a/esc-reporting/esc-analyze.py b/esc-reporting/esc-analyze.py
index 3c9587c..6923552 100755
--- a/esc-reporting/esc-analyze.py
+++ b/esc-reporting/esc-analyze.py
@@ -3,6 +3,7 @@
 # This file is part of the LibreOffice project.
 #
 # This Source Code Form is subject to the terms of the Mozilla Public
+# This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 #
@@ -489,9 +490,9 @@ def analyze_esc():
  'top15_reporters' : {},
  'top15_fixers' : []}
 for line in bugzillaESCData['ESC_QA_STATS_UPDATE']['top15_closers']:
-  statList['escList']['QAstat']['top15_squashers'][line['who']] = 
line['closed']
+  statList['escList']['QAstat']['top15_squashers'][str(line['who'])] = 
line['closed']
 for line in bugzillaESCData['ESC_QA_STATS_UPDATE']['top15_reporters']:
-  statList['escList']['QAstat']['top15_reporters'][line['who']] = 
line['reported']
+  statList['escList']['QAstat']['top15_reporters'][str(line['who'])] = 
line['reported']
 statList['escList']['MostPressingBugs'] = {'open': {'list': {}}, 'closed': 
{'list': {}}}
 for type in 'open', 'closed':
statList['escList']['MostPressingBugs'][type]['count'] = 
bugzillaESCData['MostPressingBugs'][type]['count']
@@ -528,7 +529,7 @@ def analyze_esc():
 who = statList['people'][who]['name']
   if not who in bug_fixers:
 bug_fixers[who] = 0
-  bug_fixers[who] += 1
+  bug_fixers[str(who)] += 1
 statList['escList']['QAstat']['top15_fixers'] = bug_fixers
 
 for id, row in bugzillaESCData['ESC_MAB_UPDATE'].items():
@@ -930,11 +931,11 @@ def runAnalyze():
 except Exception as e:
   print('ERROR: analyze_reports failed with ' + str(e))
   pass
-try:
-  analyze_final()
-except Exception as e:
-  print('ERROR: analyze_final failed with ' + str(e))
-  pass
+#try:
+analyze_final()
+#except Exception as e:
+#  print('ERROR: analyze_final failed with ' + str(e))
+#  pass
 
 
 def runUpgrade(args):
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/inc vcl/unx

[Caolán McNamara]

 vcl/inc/unx/gtk/gtkframe.hxx  |9 ++
 vcl/unx/gtk/gtksalframe.cxx   |   15 ++--
 vcl/unx/gtk3/gtk3gtkframe.cxx |  131 ++
 3 files changed, 112 insertions(+), 43 deletions(-)

New commits:
commit 7f60978b2ccd0e17816b78bde60c6e0e60a9d52e
Author: Caolán McNamara 
Date:   Thu May 18 15:05:27 2017 +0100

Related: rhbz#1367846 queue and merge scroll events

Change-Id: Ib45f61bbb35bd240829491ac8a79803222974778
Reviewed-on: https://gerrit.libreoffice.org/37779
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx
index 00a687422f82..37a4facabd0c 100644
--- a/vcl/inc/unx/gtk/gtkframe.hxx
+++ b/vcl/inc/unx/gtk/gtkframe.hxx
@@ -30,6 +30,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -280,7 +281,7 @@ class GtkSalFrame : public SalFrame
 static gboolean signalKey( GtkWidget*, GdkEventKey*, gpointer );
 static gboolean signalDelete( GtkWidget*, GdkEvent*, gpointer );
 static gboolean signalWindowState( GtkWidget*, GdkEvent*, gpointer );
-static gboolean signalScroll( GtkWidget*, GdkEventScroll*, gpointer );
+static gboolean signalScroll( GtkWidget*, GdkEvent*, gpointer );
 static gboolean signalCrossing( GtkWidget*, GdkEventCrossing*, 
gpointer );
 static gboolean signalVisibility( GtkWidget*, GdkEventVisibility*, 
gpointer );
 static void signalDestroy( GtkWidget*, gpointer );
@@ -347,6 +348,8 @@ public:
 cairo_surface_t*m_pSurface;
 basegfx::B2IVector  m_aFrameSize;
 DamageHandler   m_aDamageHandler;
+std::vector  m_aPendingScrollEvents;
+Idlem_aSmoothScrollIdle;
 int m_nGrabLevel;
 boolm_bSalObjectSetPosSize;
 #endif
@@ -427,6 +430,10 @@ public:
 void removeGrabLevel();
 
 void nopaint_container_resize_children(GtkContainer*);
+
+void LaunchAsyncScroll(GdkEvent* pEvent);
+DECL_LINK(AsyncScroll, Timer *, void);
+
 #endif
 virtual ~GtkSalFrame() override;
 
diff --git a/vcl/unx/gtk/gtksalframe.cxx b/vcl/unx/gtk/gtksalframe.cxx
index 02e06ae8c053..f32e49ad4f7b 100644
--- a/vcl/unx/gtk/gtksalframe.cxx
+++ b/vcl/unx/gtk/gtksalframe.cxx
@@ -2782,8 +2782,9 @@ gboolean GtkSalFrame::signalButton( GtkWidget*, 
GdkEventButton* pEvent, gpointer
 return true;
 }
 
-gboolean GtkSalFrame::signalScroll( GtkWidget*, GdkEventScroll* pEvent, 
gpointer frame )
+gboolean GtkSalFrame::signalScroll(GtkWidget*, GdkEvent* pInEvent, gpointer 
frame)
 {
+GdkEventScroll& rEvent = pInEvent->scroll;
 GtkSalFrame* pThis = static_cast(frame);
 
 static sal_uLongnLines = 0;
@@ -2795,16 +2796,16 @@ gboolean GtkSalFrame::signalScroll( GtkWidget*, 
GdkEventScroll* pEvent, gpointer
 nLines = SAL_WHEELMOUSE_EVENT_PAGESCROLL;
 }
 
-bool bNeg = (pEvent->direction == GDK_SCROLL_DOWN || pEvent->direction == 
GDK_SCROLL_RIGHT );
+bool bNeg = (rEvent.direction == GDK_SCROLL_DOWN || rEvent.direction == 
GDK_SCROLL_RIGHT );
 SalWheelMouseEvent aEvent;
-aEvent.mnTime   = pEvent->time;
-aEvent.mnX  = (sal_uLong)pEvent->x;
-aEvent.mnY  = (sal_uLong)pEvent->y;
+aEvent.mnTime   = rEvent.time;
+aEvent.mnX  = (sal_uLong)rEvent.x;
+aEvent.mnY  = (sal_uLong)rEvent.y;
 aEvent.mnDelta  = bNeg ? -120 : 120;
 aEvent.mnNotchDelta = bNeg ? -1 : 1;
 aEvent.mnScrollLines= nLines;
-aEvent.mnCode   = GetMouseModCode( pEvent->state );
-aEvent.mbHorz   = (pEvent->direction == GDK_SCROLL_LEFT || 
pEvent->direction == GDK_SCROLL_RIGHT);
+aEvent.mnCode   = GetMouseModCode( rEvent.state );
+aEvent.mbHorz   = (rEvent.direction == GDK_SCROLL_LEFT || 
rEvent.direction == GDK_SCROLL_RIGHT);
 
 if( AllSettings::GetLayoutRTL() )
 aEvent.mnX = pThis->maGeometry.nWidth-1-aEvent.mnX;
diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx
index bc19821cbdf5..30a729c5cbcc 100644
--- a/vcl/unx/gtk3/gtk3gtkframe.cxx
+++ b/vcl/unx/gtk3/gtk3gtkframe.cxx
@@ -807,6 +807,9 @@ void GtkSalFrame::InvalidateGraphics()
 
 GtkSalFrame::~GtkSalFrame()
 {
+m_aSmoothScrollIdle.Stop();
+m_aSmoothScrollIdle.ClearInvokeHandler();
+
 if (m_pDropTarget)
 {
 m_pDropTarget->deinitialize();
@@ -992,6 +995,8 @@ void GtkSalFrame::InitCommon()
 m_aDamageHandler.handle = this;
 m_aDamageHandler.damaged = ::damaged;
 
+m_aSmoothScrollIdle.SetInvokeHandler(LINK(this, GtkSalFrame, AsyncScroll));
+
 m_pTopLevelGrid = GTK_GRID(gtk_grid_new());
 gtk_container_add(GTK_CONTAINER(m_pWindow), GTK_WIDGET(m_pTopLevelGrid));
 
@@ -2653,53 

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - vcl/inc vcl/unx

[Caolán McNamara]

 vcl/inc/unx/gtk/gtkframe.hxx  |9 ++
 vcl/unx/gtk/gtksalframe.cxx   |   15 ++--
 vcl/unx/gtk3/gtk3gtkframe.cxx |  131 ++
 3 files changed, 112 insertions(+), 43 deletions(-)

New commits:
commit 8b6a29398315bf7a0b1a7d54b18d3902cb8e9dfa
Author: Caolán McNamara 
Date:   Thu May 18 15:05:27 2017 +0100

Related: rhbz#1367846 queue and merge scroll events

Change-Id: Ib45f61bbb35bd240829491ac8a79803222974778
Reviewed-on: https://gerrit.libreoffice.org/37780
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx
index 00a687422f82..37a4facabd0c 100644
--- a/vcl/inc/unx/gtk/gtkframe.hxx
+++ b/vcl/inc/unx/gtk/gtkframe.hxx
@@ -30,6 +30,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -280,7 +281,7 @@ class GtkSalFrame : public SalFrame
 static gboolean signalKey( GtkWidget*, GdkEventKey*, gpointer );
 static gboolean signalDelete( GtkWidget*, GdkEvent*, gpointer );
 static gboolean signalWindowState( GtkWidget*, GdkEvent*, gpointer );
-static gboolean signalScroll( GtkWidget*, GdkEventScroll*, gpointer );
+static gboolean signalScroll( GtkWidget*, GdkEvent*, gpointer );
 static gboolean signalCrossing( GtkWidget*, GdkEventCrossing*, 
gpointer );
 static gboolean signalVisibility( GtkWidget*, GdkEventVisibility*, 
gpointer );
 static void signalDestroy( GtkWidget*, gpointer );
@@ -347,6 +348,8 @@ public:
 cairo_surface_t*m_pSurface;
 basegfx::B2IVector  m_aFrameSize;
 DamageHandler   m_aDamageHandler;
+std::vector  m_aPendingScrollEvents;
+Idlem_aSmoothScrollIdle;
 int m_nGrabLevel;
 boolm_bSalObjectSetPosSize;
 #endif
@@ -427,6 +430,10 @@ public:
 void removeGrabLevel();
 
 void nopaint_container_resize_children(GtkContainer*);
+
+void LaunchAsyncScroll(GdkEvent* pEvent);
+DECL_LINK(AsyncScroll, Timer *, void);
+
 #endif
 virtual ~GtkSalFrame() override;
 
diff --git a/vcl/unx/gtk/gtksalframe.cxx b/vcl/unx/gtk/gtksalframe.cxx
index 02e06ae8c053..f32e49ad4f7b 100644
--- a/vcl/unx/gtk/gtksalframe.cxx
+++ b/vcl/unx/gtk/gtksalframe.cxx
@@ -2782,8 +2782,9 @@ gboolean GtkSalFrame::signalButton( GtkWidget*, 
GdkEventButton* pEvent, gpointer
 return true;
 }
 
-gboolean GtkSalFrame::signalScroll( GtkWidget*, GdkEventScroll* pEvent, 
gpointer frame )
+gboolean GtkSalFrame::signalScroll(GtkWidget*, GdkEvent* pInEvent, gpointer 
frame)
 {
+GdkEventScroll& rEvent = pInEvent->scroll;
 GtkSalFrame* pThis = static_cast(frame);
 
 static sal_uLongnLines = 0;
@@ -2795,16 +2796,16 @@ gboolean GtkSalFrame::signalScroll( GtkWidget*, 
GdkEventScroll* pEvent, gpointer
 nLines = SAL_WHEELMOUSE_EVENT_PAGESCROLL;
 }
 
-bool bNeg = (pEvent->direction == GDK_SCROLL_DOWN || pEvent->direction == 
GDK_SCROLL_RIGHT );
+bool bNeg = (rEvent.direction == GDK_SCROLL_DOWN || rEvent.direction == 
GDK_SCROLL_RIGHT );
 SalWheelMouseEvent aEvent;
-aEvent.mnTime   = pEvent->time;
-aEvent.mnX  = (sal_uLong)pEvent->x;
-aEvent.mnY  = (sal_uLong)pEvent->y;
+aEvent.mnTime   = rEvent.time;
+aEvent.mnX  = (sal_uLong)rEvent.x;
+aEvent.mnY  = (sal_uLong)rEvent.y;
 aEvent.mnDelta  = bNeg ? -120 : 120;
 aEvent.mnNotchDelta = bNeg ? -1 : 1;
 aEvent.mnScrollLines= nLines;
-aEvent.mnCode   = GetMouseModCode( pEvent->state );
-aEvent.mbHorz   = (pEvent->direction == GDK_SCROLL_LEFT || 
pEvent->direction == GDK_SCROLL_RIGHT);
+aEvent.mnCode   = GetMouseModCode( rEvent.state );
+aEvent.mbHorz   = (rEvent.direction == GDK_SCROLL_LEFT || 
rEvent.direction == GDK_SCROLL_RIGHT);
 
 if( AllSettings::GetLayoutRTL() )
 aEvent.mnX = pThis->maGeometry.nWidth-1-aEvent.mnX;
diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx
index bc19821cbdf5..30a729c5cbcc 100644
--- a/vcl/unx/gtk3/gtk3gtkframe.cxx
+++ b/vcl/unx/gtk3/gtk3gtkframe.cxx
@@ -807,6 +807,9 @@ void GtkSalFrame::InvalidateGraphics()
 
 GtkSalFrame::~GtkSalFrame()
 {
+m_aSmoothScrollIdle.Stop();
+m_aSmoothScrollIdle.ClearInvokeHandler();
+
 if (m_pDropTarget)
 {
 m_pDropTarget->deinitialize();
@@ -992,6 +995,8 @@ void GtkSalFrame::InitCommon()
 m_aDamageHandler.handle = this;
 m_aDamageHandler.damaged = ::damaged;
 
+m_aSmoothScrollIdle.SetInvokeHandler(LINK(this, GtkSalFrame, AsyncScroll));
+
 m_pTopLevelGrid = GTK_GRID(gtk_grid_new());
 gtk_container_add(GTK_CONTAINER(m_pWindow), GTK_WIDGET(m_pTopLevelGrid));
 
@@ -2653,53 

[Libreoffice-commits] core.git: external/libxmlsec

[Stephan Bergmann]

 external/libxmlsec/ExternalProject_xmlsec.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5206b0376dcd511843f0e6cb072fe4184adcc487
Author: Stephan Bergmann 
Date:   Thu May 18 16:13:55 2017 +0200

external/libxmlsec: Pass down gb_VISIBILITY_FLAGS

...otherwise ASan build started to fail in CppunitTest_services with

> ==16664==ERROR: AddressSanitizer: odr-violation (0x7f4583587440):
>   [1] size=35 'xmlSecNs' strings.c:22:15
>   [2] size=35 'xmlSecNs' strings.c:22:15
> These globals were registered at these points:
>   [1]:
> #0 0x44f410 in __asan_register_globals.part.11 
/data/sbergman/github.com/llvm-project/llvm-project-20170507/compiler-rt/lib/asan/asan_globals.cc:358
> #1 0x7f458295cded in asan.module_ctor 
(instdir/program/libxsec_gpg.so+0x197ded)
>
>   [2]:
> #0 0x44f410 in __asan_register_globals.part.11 
/data/sbergman/github.com/llvm-project/llvm-project-20170507/compiler-rt/lib/asan/asan_globals.cc:358
> #1 0x7f45833cc28d in asan.module_ctor 
(instdir/program/libxsec_xmlsec.so+0x5da28d)
>
> ==16664==HINT: if you don't care about these errors you may set 
ASAN_OPTIONS=detect_odr_violation=0
> SUMMARY: AddressSanitizer: odr-violation: global 'xmlSecNs' at 
strings.c:22:15
> ==16664==ABORTING

after cae5f2a543b31552ccd9765aca5eb514fa694e07 "gpg4libre: initial GPG 
signature
generation"

Change-Id: I689241df52a7e878bfbd2d3dd6409bf0c104638b

diff --git a/external/libxmlsec/ExternalProject_xmlsec.mk 
b/external/libxmlsec/ExternalProject_xmlsec.mk
index 66abd02ac3a5..33fe25bb6977 100644
--- a/external/libxmlsec/ExternalProject_xmlsec.mk
+++ b/external/libxmlsec/ExternalProject_xmlsec.mk
@@ -40,7 +40,7 @@ $(call gb_ExternalProject_get_state_target,xmlsec,build) :
&& ./configure \
--with-pic --disable-shared --disable-crypto-dl 
--without-libxslt --without-gnutls \
$(if 
$(verbose),--disable-silent-rules,--enable-silent-rules) \
-   CFLAGS="$(CFLAGS) $(if 
$(debug),$(gb_COMPILERNOOPTFLAGS) $(gb_DEBUGINFO_FLAGS) 
$(gb_DEBUG_CFLAGS),$(gb_COMPILEROPTFLAGS))" \
+   CFLAGS="$(CFLAGS) $(if 
$(debug),$(gb_COMPILERNOOPTFLAGS) $(gb_DEBUGINFO_FLAGS) 
$(gb_DEBUG_CFLAGS),$(gb_COMPILEROPTFLAGS)) $(gb_VISIBILITY_FLAGS)" \
$(if $(or $(filter-out 
ANDROID,$(OS)),$(DISABLE_OPENSSL)),--without-openssl,--with-openssl=$(call 
gb_UnpackedTarball_get_dir,openssl)) \
$(if $(filter 
MACOSX,$(OS)),--prefix=/@.__OOO)
 \
$(if $(SYSTEM_NSS),,$(if $(filter 
MACOSX,$(OS)),--disable-pkgconfig)) \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107895] Calc doesn' t distinguish dates from numbers when deleting cells content

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107895

Dolespa  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Dolespa  ---
Hi... I tried it in 5.3.3.2 and it is already solved.

Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - include/svl sc/inc sc/qa sc/source

[Arul Michael]

 include/svl/hint.hxx|1 
 sc/inc/column.hxx   |2 -
 sc/qa/unit/ucalc.hxx|2 +
 sc/qa/unit/ucalc_formula.cxx|   44 
 sc/source/core/data/column3.cxx |5 +---
 sc/source/core/data/formulacell.cxx |2 -
 sc/source/core/data/table5.cxx  |2 -
 7 files changed, 52 insertions(+), 6 deletions(-)

New commits:
commit 70ca2d0bc42a0360055b9c54e6e5edd3ef9317b8
Author: Arul Michael 
Date:   Tue May 16 17:05:19 2017 +0530

New HintId and unit test for hidden rows and SUBTOTAL, tdf#93171 follow-up

Adding new Hintid for HideRows so that we notify only formulas with subtotal
and aggregate function for recalculation. Added unit testing.

Change-Id: I44f2e45acaf697f91744bc8202f27b218faa5b43
(cherry picked from commit 6f9d7c3506ca13d79c8a2c732f42ce029452bd36)
Reviewed-on: https://gerrit.libreoffice.org/37776
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/include/svl/hint.hxx b/include/svl/hint.hxx
index 2c94c4529300..f7f0c73e062e 100644
--- a/include/svl/hint.hxx
+++ b/include/svl/hint.hxx
@@ -85,6 +85,7 @@ enum class SfxHintId {
 ScRefModeChanged,
 ScKillEditView,
 ScKillEditViewNoPaint,
+ScHiddenRowsChanged,
 
 // SC accessibility hints
 ScAccTableChanged,
diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index e163a1e295a1..0c195eb316d0 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -588,7 +588,7 @@ public:
 
 void Broadcast( SCROW nRow );
 void BroadcastCells( const std::vector& rRows, SfxHintId nHint );
-void BroadcastRows( SCROW nStartRow, SCROW nEndRow );
+void BroadcastRows( SCROW nStartRow, SCROW nEndRow, SfxHintId nHint );
 
 // cell notes
 ScPostIt* GetCellNote( SCROW nRow );
diff --git a/sc/qa/unit/ucalc.hxx b/sc/qa/unit/ucalc.hxx
index 732ab5b1ec3d..5d1def66c7c7 100644
--- a/sc/qa/unit/ucalc.hxx
+++ b/sc/qa/unit/ucalc.hxx
@@ -530,6 +530,7 @@ public:
 void testPrecisionAsShown();
 void testProtectedSheetEditByRow();
 void testProtectedSheetEditByColumn();
+void testFuncRowsHidden();
 
 CPPUNIT_TEST_SUITE(Test);
 CPPUNIT_TEST(testCollator);
@@ -800,6 +801,7 @@ public:
 CPPUNIT_TEST(testPrecisionAsShown);
 CPPUNIT_TEST(testProtectedSheetEditByRow);
 CPPUNIT_TEST(testProtectedSheetEditByColumn);
+CPPUNIT_TEST(testFuncRowsHidden);
 CPPUNIT_TEST_SUITE_END();
 
 private:
diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx
index 46fcdf05de68..223b88dd1f2f 100644
--- a/sc/qa/unit/ucalc_formula.cxx
+++ b/sc/qa/unit/ucalc_formula.cxx
@@ -7860,4 +7860,48 @@ void Test::testIntersectionOpExcel()
 m_pDoc->DeleteTab(0);
 }
 
+//Test Subtotal and Aggregate during hide rows #tdf93171
+void Test::testFuncRowsHidden()
+{
+sc::AutoCalcSwitch aACSwitch(*m_pDoc, true); // turn auto calc on.
+m_pDoc->InsertTab(0, "Test");
+m_pDoc->SetValue(0, 0, 0, 1); //A1
+m_pDoc->SetValue(0, 1, 0, 2); //A2
+m_pDoc->SetValue(0, 2, 0, 4); //A3
+m_pDoc->SetValue(0, 3, 0, 8); //A4
+m_pDoc->SetValue(0, 4, 0, 16); //A5
+m_pDoc->SetValue(0, 5, 0, 32); //A6
+
+ScAddress aPos(0,6,0);
+m_pDoc->SetString(aPos, "=SUBTOTAL(109; A1:A6)");
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Calculation of SUBTOTAL failed", 63.0, 
m_pDoc->GetValue(aPos));
+//Hide row 1
+m_pDoc->SetRowHidden(0, 0, 0, true);
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Calculation of SUBTOTAL failed", 62.0, 
m_pDoc->GetValue(aPos));
+m_pDoc->SetRowHidden(0, 0, 0, false);
+//Hide row 2 and 3
+m_pDoc->SetRowHidden(1, 2, 0, true);
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Calculation of SUBTOTAL failed", 57.0, 
m_pDoc->GetValue(aPos));
+m_pDoc->SetRowHidden(1, 2, 0, false);
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Calculation of SUBTOTAL failed", 63.0, 
m_pDoc->GetValue(aPos));
+
+m_pDoc->SetString(aPos, "=AGGREGATE(9; 5; A1:A6)"); //9=SUM 5=Ignore only 
hidden rows
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Calculation of AGGREGATE failed", 63.0, 
m_pDoc->GetValue(aPos));
+//Hide row 1
+m_pDoc->SetRowHidden(0, 0, 0, true);
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Calculation of AGGREGATE failed", 62.0, 
m_pDoc->GetValue(aPos));
+m_pDoc->SetRowHidden(0, 0, 0, false);
+//Hide rows 3 to 5
+m_pDoc->SetRowHidden(2, 4, 0, true);
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Calculation of AGGREGATE failed", 35.0, 
m_pDoc->GetValue(aPos));
+m_pDoc->SetRowHidden(2, 4, 0, false);
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Calculation of AGGREGATE failed", 63.0, 
m_pDoc->GetValue(aPos));
+
+m_pDoc->SetString(aPos, "=SUM(A1:A6)");
+m_pDoc->SetRowHidden(2, 4, 0, true);
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Calculation of SUM failed", 63.0, 
m_pDoc->GetValue(aPos));
+
+m_pDoc->DeleteTab(0);
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/core/data/column3.cxx 

[Libreoffice-commits] core.git: sw/inc

[Stephan Bergmann]

 sw/inc/swtypes.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit db5918f5cdf95f6d47adb250265253c5a186a5c7
Author: Stephan Bergmann 
Date:   Thu May 18 15:53:31 2017 +0200

Replace macro with function

Change-Id: I41603579d71190b60e6b7c349b2296120757e4f2

diff --git a/sw/inc/swtypes.hxx b/sw/inc/swtypes.hxx
index 2307091b98e4..9c40203b5402 100644
--- a/sw/inc/swtypes.hxx
+++ b/sw/inc/swtypes.hxx
@@ -179,7 +179,7 @@ namespace o3tl
 template<> struct typed_flags : is_typed_flags {};
 }
 
-#define SW_ISPRINTABLE( c ) ( c >= ' ' && 127 != c )
+constexpr bool SW_ISPRINTABLE(sal_Unicode c) { return c >= ' ' && 127 != c; }
 
 #define CHAR_HARDBLANK  u'\x00A0'
 #define CHAR_HARDHYPHEN u'\x2011'
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: chart2/qa

[Tomaž Vajngerl]

 chart2/qa/extras/PivotChartTest.cxx |  206 
 1 file changed, 206 insertions(+)

New commits:
commit 54ad4ef4f1d50bb4e4ce08b3600157471af2f565
Author: Tomaž Vajngerl 
Date:   Thu May 18 00:00:17 2017 +0200

tdf#107862 test case with outline mode and subtotals

Change-Id: Icfccdb3689a642a96e1666c499728f4ab8106578
Reviewed-on: https://gerrit.libreoffice.org/37741
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/chart2/qa/extras/PivotChartTest.cxx 
b/chart2/qa/extras/PivotChartTest.cxx
index 20a37b72595f..f1a345fa964c 100644
--- a/chart2/qa/extras/PivotChartTest.cxx
+++ b/chart2/qa/extras/PivotChartTest.cxx
@@ -10,6 +10,8 @@
 #include "charttest.hxx"
 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -23,6 +25,7 @@
 #include 
 
 #include 
+#include 
 
 #include 
 
@@ -39,6 +42,7 @@ public:
 void testPivotChartWithOneColumnField();
 void testPivotChartWithOneRowField();
 void testPivotTableDataProvider_PivotTableFields();
+void testPivotChartRowFieldInOutlineMode();
 
 CPPUNIT_TEST_SUITE(PivotChartTest);
 CPPUNIT_TEST(testRoundtrip);
@@ -46,6 +50,7 @@ public:
 CPPUNIT_TEST(testPivotChartWithOneColumnField);
 CPPUNIT_TEST(testPivotChartWithOneRowField);
 CPPUNIT_TEST(testPivotTableDataProvider_PivotTableFields);
+CPPUNIT_TEST(testPivotChartRowFieldInOutlineMode);
 CPPUNIT_TEST_SUITE_END();
 };
 
@@ -84,6 +89,46 @@ void 
lclModifyFunction(uno::Reference const & xDesc
 }
 }
 
+void lclModifyLayoutInfo(uno::Reference const & 
xDescriptor,
+  OUString const & sFieldName,
+  sheet::DataPilotFieldLayoutInfo aLayoutInfo)
+{
+uno::Reference 
xIndexAccess(xDescriptor->getDataPilotFields(), UNO_QUERY_THROW);
+sal_Int32 nCount = xIndexAccess->getCount();
+for (sal_Int32 i = 0; i < nCount; ++i)
+{
+uno::Reference xNamed(xIndexAccess->getByIndex(i), 
UNO_QUERY_THROW);
+OUString aName = xNamed->getName();
+uno::Reference xPropSet(xNamed, UNO_QUERY_THROW);
+if (aName == sFieldName)
+{
+uno::Any aValue;
+aValue <<= aLayoutInfo;
+xPropSet->setPropertyValue("LayoutInfo", aValue);
+}
+}
+}
+
+void lclModifySubtotals(uno::Reference const & 
xDescriptor,
+OUString const & sFieldName,
+uno::Sequence const & 
rSubtotalFunctions)
+{
+uno::Reference 
xIndexAccess(xDescriptor->getDataPilotFields(), UNO_QUERY_THROW);
+sal_Int32 nCount = xIndexAccess->getCount();
+for (sal_Int32 i = 0; i < nCount; ++i)
+{
+uno::Reference xNamed(xIndexAccess->getByIndex(i), 
UNO_QUERY_THROW);
+OUString aName = xNamed->getName();
+uno::Reference xPropSet(xNamed, UNO_QUERY_THROW);
+if (aName == sFieldName)
+{
+uno::Any aValue;
+aValue <<= rSubtotalFunctions;
+xPropSet->setPropertyValue("Subtotals", aValue);
+}
+}
+}
+
 void lclModifyColumnGrandTotal(uno::Reference 
const & xDataPilotDescriptor, bool bTotal)
 {
 uno::Reference xProperties(xDataPilotDescriptor, 
uno::UNO_QUERY_THROW);
@@ -108,6 +153,19 @@ void lclCheckSequence(std::vector const & 
reference,
 }
 }
 
+void lclCheckCategories(std::vector const & reference,
+uno::Reference const & 
xSequence)
+{
+uno::Reference 
xTextualDataSequence(xSequence, uno::UNO_QUERY_THROW);
+uno::Sequence aText = xTextualDataSequence->getTextualData();
+
+CPPUNIT_ASSERT_EQUAL(reference.size(), size_t(aText.getLength()));
+for (size_t i = 0; i < reference.size(); ++i)
+{
+CPPUNIT_ASSERT_EQUAL(reference[i], aText[i]);
+}
+}
+
 OUString lclGetLabel(Reference const & xChartDoc, 
sal_Int32 nSeriesIndex)
 {
 Reference xLabelDataSequence = 
getLabelDataSequenceFromDoc(xChartDoc, nSeriesIndex);
@@ -127,6 +185,18 @@ uno::Reference 
lclGetPivotTableByName(sal_Int32 nIndex,
 return 
uno::Reference(xDataPilotTables->getByName(sPivotTableName),
 UNO_QUERY_THROW);
 }
 
+uno::Sequence
+lclGetCategories(Reference const & xChartDoc)
+{
+uno::Sequence aArguments(1);
+aArguments[0] = beans::PropertyValue("CellRangeRepresentation", -1,
+ 
uno::makeAny("PT@categories"),
+ beans::PropertyState_DIRECT_VALUE);
+
+uno::Reference 
xDataProvider(xChartDoc->getDataProvider(), uno::UNO_QUERY_THROW);
+return xDataProvider->createDataSource(aArguments)->getDataSequences();
+}
+
 struct Value
 {
 OUString maString;
@@ -711,6 +781,142 @@ void 
PivotChartTest::testPivotTableDataProvider_PivotTableFields()
 CPPUNIT_ASSERT_EQUAL(OUString("Sum - Sales T2"), aFieldEntries[1].Name);
 }
 
+void PivotChartTest::testPivotChartRowFieldInOutlineMode()
+{
+   

[Libreoffice-commits] core.git: sc/source

[Tomaž Vajngerl]

 sc/source/ui/unoobj/PivotTableDataProvider.cxx |  103 +++--
 1 file changed, 63 insertions(+), 40 deletions(-)

New commits:
commit 2b675ddf550af524c1596c969dde1826865c8ad8
Author: Tomaž Vajngerl 
Date:   Wed May 17 14:37:47 2017 +0200

tdf#107862 ignore subtotals in outline mode and empty rows

Change-Id: Ifb469193d4f7b3a5f48ab1ef15ae9f5996bfa608
Reviewed-on: https://gerrit.libreoffice.org/37740
Reviewed-by: Tomaž Vajngerl 
Tested-by: Tomaž Vajngerl 

diff --git a/sc/source/ui/unoobj/PivotTableDataProvider.cxx 
b/sc/source/ui/unoobj/PivotTableDataProvider.cxx
index 8dcb1e776379..a9d453454918 100644
--- a/sc/source/ui/unoobj/PivotTableDataProvider.cxx
+++ b/sc/source/ui/unoobj/PivotTableDataProvider.cxx
@@ -300,21 +300,42 @@ void PivotTableDataProvider::collectPivotTableData()
 double fNan;
 rtl::math::setNan();
 
+std::unordered_set aValidRowIndex;
+
+size_t nRowIndex = 0;
 for (uno::Sequence const & xDataResults : 
xDataResultsSequence)
 {
-size_t nIndex = 0;
+std::vector aRow;
+bool bRowEmpty = true;
+// First pass - collect a row of valid data and track if the row is 
empty
 for (sheet::DataResult const & rDataResult : xDataResults)
 {
 if (rDataResult.Flags & css::sheet::DataResultFlags::SUBTOTAL)
 continue;
 if (rDataResult.Flags == 0 || rDataResult.Flags & 
css::sheet::DataResultFlags::HASDATA)
 {
-if (nIndex >= m_aDataRowVector.size())
-m_aDataRowVector.resize(nIndex + 1);
-
m_aDataRowVector[nIndex].push_back(ValueAndFormat(rDataResult.Flags ? 
rDataResult.Value : fNan, 0));
+aRow.push_back(ValueAndFormat(rDataResult.Flags ? 
rDataResult.Value : fNan, 0));
+if (rDataResult.Flags != 0) // set as valid only if we have 
data
+{
+bRowEmpty = false;
+// We need to remember all valid (non-empty) row indices
+aValidRowIndex.insert(nRowIndex);
+}
+}
+}
+// Second pass: add to collection only non-empty rows
+if (!bRowEmpty)
+{
+size_t nColumnIndex = 0;
+for (ValueAndFormat const & aValue : aRow)
+{
+if (nColumnIndex >= m_aDataRowVector.size())
+m_aDataRowVector.resize(nColumnIndex + 1);
+m_aDataRowVector[nColumnIndex].push_back(aValue);
+nColumnIndex++;
 }
-nIndex++;
 }
+nRowIndex++;
 }
 
 uno::Reference 
xDimensionsSupplier(pDPObject->GetSource());
@@ -382,10 +403,10 @@ void PivotTableDataProvider::collectPivotTableData()
 OUString sName;
 for (sheet::MemberResult const & rMember : aSequence)
 {
+// Skip grandtotals and subtotals
 if (rMember.Flags & 
sheet::MemberResultFlags::SUBTOTAL ||
 rMember.Flags & 
sheet::MemberResultFlags::GRANDTOTAL)
 continue;
-
 if (rMember.Flags & 
sheet::MemberResultFlags::HASMEMBER ||
 rMember.Flags & 
sheet::MemberResultFlags::CONTINUE)
 {
@@ -423,53 +444,55 @@ void PivotTableDataProvider::collectPivotTableData()
 uno::Sequence aSequence = 
xLevelResult->getResults();
 
 size_t i = 0;
+size_t nEachIndex = 0;
+std::unique_ptr pItem;
+
 for (sheet::MemberResult const & rMember : aSequence)
 {
+bool bFound = aValidRowIndex.find(nEachIndex) != 
aValidRowIndex.end();
+
+nEachIndex++;
+
 bool bHasContinueFlag = rMember.Flags & 
sheet::MemberResultFlags::CONTINUE;
-if (rMember.Flags & 
sheet::MemberResultFlags::SUBTOTAL ||
-rMember.Flags & 
sheet::MemberResultFlags::GRANDTOTAL)
-continue;
 
 if (rMember.Flags & 
sheet::MemberResultFlags::HASMEMBER || bHasContinueFlag)
 {
-std::unique_ptr pItem;
-
-double fValue = rMember.Value;
-
-if (rtl::math::isNan(fValue))
-{
-OUString sStringValue = bHasContinueFlag ? 
"" : rMember.Caption;
-pItem.reset(new 
ValueAndFormat(sStringValue));
-}
- 

[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-5.3-13'

[Christian Lohmaier]

Tag 'cp-5.3-13' created by Andras Timar  at 
2017-05-18 13:42 +

cp-5.3-13

Changes since cp-5.3-10:
Christian Lohmaier (1):
  update translations for 5.3.3 rc2

---
 source/am/cui/source/options.po|8 
 source/am/cui/source/tabpages.po   |8 
 source/am/cui/uiconfig/ui.po   |8 
 source/am/fpicker/source/office.po |   10 
 source/am/officecfg/registry/data/org/openoffice/Office.po |6 
 source/am/sc/source/ui/src.po  |8 
 source/am/sfx2/source/dialog.po|   12 
 source/am/svtools/source/dialogs.po|8 
 source/am/svtools/source/misc.po   |8 
 source/am/svx/source/stbctrls.po   |8 
 source/am/svx/uiconfig/ui.po   |   10 
 source/bg/sc/uiconfig/scalc/ui.po  |   20 
 source/bg/sfx2/source/dialog.po|   12 
 source/bg/svx/source/dialog.po |   30 
 source/bg/svx/source/form.po   |   10 
 source/bg/svx/source/stbctrls.po   |8 
 source/bg/svx/source/tbxctrls.po   |6 
 source/bg/svx/uiconfig/ui.po   |  289 
 source/bg/sw/source/ui/utlui.po|   21 
 source/bg/sw/source/uibase/utlui.po|6 
 source/bg/sw/uiconfig/swriter/ui.po|5 
 source/br/cui/uiconfig/ui.po   |   70 -
 source/br/extensions/source/bibliography.po|   12 
 source/br/extensions/source/propctrlr.po   |  152 ++--
 source/br/sc/source/ui/src.po  |   12 
 source/ca/helpcontent2/source/text/scalc/00.po |   20 
 source/ca/helpcontent2/source/text/scalc/01.po |8 
 source/ca/helpcontent2/source/text/scalc/guide.po  |   10 
 source/ca/helpcontent2/source/text/shared/01.po|6 
 source/ca/helpcontent2/source/text/shared/guide.po |5 
 source/ca/helpcontent2/source/text/shared/optionen.po  |8 
 source/ca/helpcontent2/source/text/simpress/guide.po   |   10 
 source/ca/helpcontent2/source/text/swriter/01.po   |   13 
 source/ca/helpcontent2/source/text/swriter/guide.po|   25 
 source/ca/officecfg/registry/data/org/openoffice/Office/UI.po  |8 
 source/ca/sc/uiconfig/scalc/ui.po  |6 
 source/ca/svx/uiconfig/ui.po   |   12 
 source/cy/cui/uiconfig/ui.po   |8 
 source/cy/sfx2/source/dialog.po|   12 
 source/cy/sfx2/uiconfig/ui.po  |   15 
 source/cy/svtools/source/dialogs.po|8 
 source/cy/svtools/source/misc.po   |8 
 source/cy/svx/source/stbctrls.po   |   10 
 source/cy/svx/uiconfig/ui.po   |   10 
 source/da/cui/uiconfig/ui.po   |8 
 source/da/helpcontent2/source/text/scalc/01.po |   12 
 source/da/sfx2/source/dialog.po|   14 
 source/da/sfx2/uiconfig/ui.po  |   17 
 source/da/svtools/source/dialogs.po|   10 
 source/da/svtools/source/java.po   |   12 
 source/da/svtools/source/misc.po   |   10 
 source/da/svx/source/stbctrls.po   |8 
 source/da/svx/uiconfig/ui.po   |   12 
 source/de/editeng/source/items.po  |   10 
 source/de/formula/source/core/resource.po  |8 
 source/de/helpcontent2/source/auxiliary.po |6 
 source/de/helpcontent2/source/text/sbasic/shared/01.po |   10 
 source/de/helpcontent2/source/text/scalc.po|6 
 source/de/helpcontent2/source/text/scalc/00.po |6 
 source/de/helpcontent2/source/text/scalc/01.po |  100 +-
 source/de/helpcontent2/source/text/scalc/guide.po  |   34 
 source/de/helpcontent2/source/text/schart/01.po|6 
 source/de/helpcontent2/source/text/shared/00.po|   10 
 source/de/helpcontent2/source/text/shared/01.po|   12 
 source/de/helpcontent2/source/text/shared/explorer/database.po |8 
 source/de/helpcontent2/source/text/shared/guide.po |   16 
 

[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-5.3-13'

[Andras Timar]

Tag 'cp-5.3-13' created by Andras Timar  at 
2017-05-18 13:42 +

cp-5.3-13

Changes since cp-5.3-12-19:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-5.3-13'

[Andras Timar]

Tag 'cp-5.3-13' created by Andras Timar  at 
2017-05-18 13:42 +

cp-5.3-13

Changes since libreoffice-5-3-branch-point-28:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-5.3-13'

[Olivier R]

Tag 'cp-5.3-13' created by Andras Timar  at 
2017-05-18 13:42 +

cp-5.3-13

Changes since cp-5.3-10:
Olivier R (1):
  tdf#107558 French spelling dictionary (6.0.3) and thesaurus

---
 fr_FR/README_fr.txt   |4 
 fr_FR/description.xml |2 
 fr_FR/fr.aff  |17751 ++--
 fr_FR/fr.dic  |155369 
+-
 fr_FR/package-description.txt |2 
 fr_FR/thes_fr.dat |  206 
 6 files changed, 88495 insertions(+), 84839 deletions(-)
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107728] FILESAVE: xlsx files always exported with comments shown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107728

--- Comment #3 from Magnus Jacobsson  ---
Created attachment 133388
  --> https://bugs.documentfoundation.org/attachment.cgi?id=133388=edit
Sample document

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - 9 commits - configure.ac filter/source include/o3tl shell/source sw/inc sw/qa sw/source vcl/headless vcl/source vcl/unx

[Andras Timar]

 configure.ac  |2 
 filter/source/graphicfilter/ieps/ieps.cxx |2 
 filter/source/xsltfilter/OleHandler.cxx   |   10 +-
 include/o3tl/safeint.hxx  |   89 +++
 shell/source/win32/SysShExec.cxx  |   22 
 sw/inc/swtypes.hxx|6 -
 sw/qa/extras/uiwriter/uiwriter.cxx|  134 ++
 sw/source/core/layout/findfrm.cxx |2 
 sw/source/core/layout/flowfrm.cxx |2 
 sw/source/core/layout/tabfrm.cxx  |   16 +++
 sw/source/core/txtnode/thints.cxx |   12 ++
 sw/source/core/undo/undobj1.cxx   |2 
 sw/source/filter/ww8/ww8par.cxx   |2 
 vcl/headless/svpbmp.cxx   |   18 +++-
 vcl/source/gdi/salmisc.cxx|   19 
 vcl/unx/generic/gdi/salbmp.cxx|   17 +++
 16 files changed, 339 insertions(+), 16 deletions(-)

New commits:
commit e639c2ad9c05a793b16db13bd879342ed75dcf95
Author: Andras Timar 
Date:   Thu May 18 15:38:18 2017 +0200

Bump version to 5.3-13

Change-Id: I6c5390ed7a6bb8298433c7897c5c3df7a220a82a

diff --git a/configure.ac b/configure.ac
index 0a0fb569b4ff..a157a0341cd4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([Collabora Office],[5.3.10.12],[],[],[https://collaboraoffice.com/])
+AC_INIT([Collabora Office],[5.3.10.13],[],[],[https://collaboraoffice.com/])
 
 AC_PREREQ([2.59])
 
commit 668e824b8885345d8c8d7847df5e8db002a57afc
Author: Caolán McNamara 
Date:   Mon May 15 11:17:57 2017 +0100

ofz#1605 check multiply and shift

Change-Id: I6aad9ad23e7bf080b3b610223f92df7074530beb
Reviewed-on: https://gerrit.libreoffice.org/37642
Tested-by: Jenkins 
Reviewed-by: Miklos Vajna 
(cherry picked from commit d881d77429371c3a04b758b151b091267c13d167)

diff --git a/include/o3tl/safeint.hxx b/include/o3tl/safeint.hxx
new file mode 100644
index ..ce144d22d9ea
--- /dev/null
+++ b/include/o3tl/safeint.hxx
@@ -0,0 +1,89 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#ifndef INCLUDED_O3TL_SAFEINT_HXX
+#define INCLUDED_O3TL_SAFEINT_HXX
+
+#include 
+#if defined(_MSC_VER)
+#include 
+#else
+#ifndef __has_builtin
+#   define __has_builtin(x) 0
+#endif
+#endif
+
+namespace o3tl
+{
+
+#if defined(_MSC_VER)
+
+template inline bool checked_multiply(T a, T b, T& result)
+{
+return !msl::utilities::SafeMultiply(a, b, result);
+}
+
+#elif (defined __GNUC__ && __GNUC__ >= 5) || 
(__has_builtin(__builtin_mul_overflow))
+
+template inline bool checked_multiply(T a, T b, T& result)
+{
+return __builtin_mul_overflow(a, b, );
+}
+
+#else
+
+//https://www.securecoding.cert.org/confluence/display/c/INT32-C.+Ensure+that+operations+on+signed+integers+do+not+result+in+overflow
+template inline typename std::enable_if::type checked_multiply(T a, T b, T& result)
+{
+  if (a > 0) {  /* a is positive */
+if (b > 0) {  /* a and b are positive */
+  if (a > (std::numeric_limits::max() / b)) {
+return true; /* Handle error */
+  }
+} else { /* a positive, b nonpositive */
+  if (b < (std::numeric_limits::min() / a)) {
+return true; /* Handle error */
+  }
+} /* a positive, b nonpositive */
+  } else { /* a is nonpositive */
+if (b > 0) { /* a is nonpositive, b is positive */
+  if (a < (std::numeric_limits::min() / b)) {
+return true; /* Handle error */
+  }
+} else { /* a and b are nonpositive */
+  if ( (a != 0) && (b < (std::numeric_limits::max() / a))) {
+return true; /* Handle error */
+  }
+} /* End if a and b are nonpositive */
+  } /* End if a is nonpositive */
+
+  result = a * b;
+
+  return false;
+}
+
+//https://www.securecoding.cert.org/confluence/display/c/INT30-C.+Ensure+that+unsigned+integer+operations+do+not+wrap
+template inline typename 
std::enable_if::type checked_multiply(T a, T 
b, T& result)
+{
+if (b && a > std::numeric_limits::max() / b) {
+return true;/* Handle error */
+}
+
+result = a * b;
+
+return false;
+}
+
+#endif
+
+}
+
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/headless/svpbmp.cxx b/vcl/headless/svpbmp.cxx
index 202d63c0a84e..71c5e52586c6 100644
--- a/vcl/headless/svpbmp.cxx
+++ 

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - 4 commits - sc/inc sc/qa sc/source sw/inc sw/source vcl/headless vcl/source vcl/unx

[Caolán McNamara]

 sc/inc/compiler.hxx|   12 ++--
 sc/qa/unit/helper/qahelper.cxx |6 ++
 sc/qa/unit/ucalc_condformat.cxx|   12 
 sc/qa/unit/ucalc_formula.cxx   |   18 ++
 sc/source/core/data/column.cxx |3 +--
 sc/source/core/data/conditio.cxx   |6 ++
 sc/source/core/data/formulacell.cxx|   24 
 sc/source/core/data/grouptokenconverter.cxx|3 +--
 sc/source/core/data/simpleformulacalc.cxx  |6 ++
 sc/source/core/opencl/formulagroupcl.cxx   |3 +--
 sc/source/core/tool/compiler.cxx   |   12 ++--
 sc/source/core/tool/interpr1.cxx   |6 ++
 sc/source/core/tool/rangenam.cxx   |   15 +--
 sc/source/core/tool/reftokenhelper.cxx |3 +--
 sc/source/filter/excel/xechart.cxx |3 +--
 sc/source/filter/excel/xeroot.cxx  |3 +--
 sc/source/filter/excel/xestream.cxx|1 +
 sc/source/filter/excel/xichart.cxx |3 +--
 sc/source/filter/oox/defnamesbuffer.cxx|3 +--
 sc/source/filter/oox/formulabuffer.cxx |9 +++--
 sc/source/filter/oox/revisionfragment.cxx  |3 +--
 sc/source/filter/orcus/interface.cxx   |6 ++
 sc/source/filter/xml/xmlimprt.cxx  |3 +--
 sc/source/ui/app/inputhdl.cxx  |3 +--
 sc/source/ui/condformat/condformatdlgentry.cxx |3 +--
 sc/source/ui/docshell/docfunc.cxx  |3 +--
 sc/source/ui/docshell/impex.cxx|3 +--
 sc/source/ui/formdlg/formula.cxx   |3 +--
 sc/source/ui/miscdlgs/anyrefdg.cxx |3 +--
 sc/source/ui/namedlg/namedefdlg.cxx|3 +--
 sc/source/ui/namedlg/namedlg.cxx   |3 +--
 sc/source/ui/unoobj/chart2uno.cxx  |6 ++
 sc/source/ui/unoobj/funcuno.cxx|3 +--
 sc/source/ui/unoobj/servuno.cxx|3 +--
 sc/source/ui/unoobj/tokenuno.cxx   |   12 
 sc/source/ui/vba/vbaname.cxx   |3 +--
 sc/source/ui/vba/vbanames.cxx  |3 +--
 sc/source/ui/vba/vbarange.cxx  |6 ++
 sc/source/ui/view/tabvwsha.cxx |3 +--
 sc/source/ui/view/viewfun2.cxx |3 +--
 sc/source/ui/view/viewfun4.cxx |3 +--
 sc/source/ui/view/viewfunc.cxx |3 +--
 sw/inc/docary.hxx  |8 +---
 sw/source/core/doc/DocumentRedlineManager.cxx  |9 ++---
 sw/source/core/doc/docredln.cxx|6 +++---
 vcl/headless/svpbmp.cxx|   18 --
 vcl/source/gdi/salmisc.cxx |   19 ++-
 vcl/unx/generic/gdi/salbmp.cxx |   17 -
 48 files changed, 155 insertions(+), 157 deletions(-)

New commits:
commit 8d6ca5f089feba768a0522f4ef6f1dbd8634a831
Author: Caolán McNamara 
Date:   Thu May 18 13:52:04 2017 +0100

ofz# InsertWithValidRanges didn't report that it deleted its argument 
anymore

since...

commit ddd84d08c9bb6e00fbd9a73bd52a28688a8c1ba7
Date:   Fri Jul 20 17:16:03 2012 +0200

Convert SV_DECL_PTRARR_SORT_DEL(_SwRedlineTbl) to o3tl::sorted_vector

Change-Id: Ie7edc6b32b373619d4c0ac154da93650743049cf

otherwise that p = nullptr line at the end doesn't make sense

Change-Id: Ibd5230beb87240cba4b3896dfa2217e25a4db697
Reviewed-on: https://gerrit.libreoffice.org/37769
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/inc/docary.hxx b/sw/inc/docary.hxx
index de663f105075..424680b329c6 100644
--- a/sw/inc/docary.hxx
+++ b/sw/inc/docary.hxx
@@ -318,6 +318,8 @@ struct CompareSwRedlineTable
 // Notification type for notifying about redlines to LOK clients
 enum class RedlineNotification { Add, Remove, Modify };
 
+typedef SwRangeRedline* SwRangeRedlinePtr;
+
 class SwRedlineTable
 {
 public:
@@ -333,9 +335,9 @@ public:
 bool Contains(const SwRangeRedline* p) const { return 
maVector.find(const_cast(p)) != maVector.end(); }
 size_type GetPos(const SwRangeRedline* p) const;
 
-bool Insert( SwRangeRedline* p );
-bool Insert( SwRangeRedline* p, size_type& rInsPos );
-bool InsertWithValidRanges( SwRangeRedline* p, size_type* pInsPos = 
nullptr );
+bool Insert(SwRangeRedlinePtr& p);
+bool Insert(SwRangeRedlinePtr& p, size_type& rInsPos);
+bool InsertWithValidRanges(SwRangeRedlinePtr& p, size_type* pInsPos = 
nullptr);
 
 void Remove( size_type nPos );
 bool Remove( const SwRangeRedline* p );
diff --git a/sw/source/core/doc/DocumentRedlineManager.cxx 

[Libreoffice-bugs] [Bug 107812] LibreOffice pdfimport and ipdf filter not picking up Italic or Bold+Italic for Type1 PS fonts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107812

Caolán McNamara  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: source/text

[Olivier Hallot]

 source/text/scalc/01/func_weekday.xhp  |6 +++---
 source/text/scalc/01/func_workday.intl.xhp |4 ++--
 source/text/shared/explorer/database/0200.xhp  |2 +-
 source/text/shared/explorer/database/querywizard05.xhp |2 +-
 source/text/shared/explorer/database/querywizard06.xhp |2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 9b2ab190af0db946c0ceb57d45ac6778fcfc2e6e
Author: Olivier Hallot 
Date:   Wed May 17 20:25:39 2017 -0300

Fix several mistakes flagged by translators

Change-Id: If2e081fa32ec82250514c59d820adb5fa071669b
Reviewed-on: https://gerrit.libreoffice.org/37743
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/source/text/scalc/01/func_weekday.xhp 
b/source/text/scalc/01/func_weekday.xhp
index 1bfaa7dc1..30012968c 100644
--- a/source/text/scalc/01/func_weekday.xhp
+++ b/source/text/scalc/01/func_weekday.xhp
@@ -133,15 +133,15 @@
 
 
 These values apply 
only to the standard date format that you select under %PRODUCTNAME - 
Preferences
-Tools - 
Options- 
%PRODUCTNAME Calc - Calculate.
+Tools - 
Options- 
%PRODUCTNAME Calc - Calculate.
 
 Examples
 =WEEKDAY("2000-06-14") returns 4 (the Type parameter is 
missing, therefore the standard count is used. The standard count starts with 
Sunday as day number 1. June 14, 2000 was a Wednesday and therefore day number 
4).
 =WEEKDAY("1996-07-24";2) returns 3 (the Type parameter is 
2, therefore Monday is day number 1. July 24, 1996 was a Wednesday and 
therefore day number 3).
 =WEEKDAY("1996-07-24";1) returns 4 (the Type parameter is 
1, therefore Sunday is day number 1. July 24, 1996 was a Wednesday and 
therefore day number 4).
-=WEEKDAY("2017-05-02";14) returns 6 (the Type 
parameter is 14, therefore Thursday is day number 1. May 2, 2017 was a Tuesday 
and therefore day number 6)
+=WEEKDAY("2017-05-02";14) returns 
6 (the Type parameter is 14, therefore Thursday is day number 1. May 2, 2017 
was a Tuesday and therefore day number 6)
 =WEEKDAY(NOW()) returns the number of the current 
day.
 To obtain a function 
indicating whether a day in A1 is a business day, use the IF and WEEKDAY 
functions as follows: IF(WEEKDAY(A1;2)6;"Business 
day";"Weekend")
 
 
-
\ No newline at end of file
+
diff --git a/source/text/scalc/01/func_workday.intl.xhp 
b/source/text/scalc/01/func_workday.intl.xhp
index 855cc68dc..635dc3479 100644
--- a/source/text/scalc/01/func_workday.intl.xhp
+++ b/source/text/scalc/01/func_workday.intl.xhp
@@ -54,8 +54,8 @@
 =WORKDAY.INTL(C3;D3;7;F3:J3) 
returns January 15, 2017 with weekend parameter 7.
 To 
define Sunday only the weekend day, use the weekend parameter 11.
 =WORKDAY.INTL(C3;D3;11;F3:J3) 
returns January 9, 2017.
-Alternatively, use the weekend string “001” for Sunday 
only weekend.
-=WORKDAY.INTL(C3;D3;“001”;F3:J3) returns January 
9, 2017.
+Alternatively, use the weekend string "001" for Sunday 
only weekend.
+=WORKDAY.INTL(C3;D3;"001";F3:J3) returns January 9, 
2017.
 The 
function can be used without the two optional parameters – Weekday and 
Holidays – by leaving them out:
 =WORKDAY.INTL(C3;D3) gives the 
result: January 10, 2017.
 
diff --git a/source/text/shared/explorer/database/0200.xhp 
b/source/text/shared/explorer/database/0200.xhp
index 6611a8051..281751778 100644
--- a/source/text/shared/explorer/database/0200.xhp
+++ b/source/text/shared/explorer/database/0200.xhp
@@ -61,7 +61,7 @@
 Print the 
document by choosing File - Print.
 
 
-You can also open 
the data source view (Ctrl+Shift+F4), select the entire database table in the 
data source view (button in the top left corner of the table), and then drag 
the selection to a text document or spreadsheet.
+You can also open 
the data source view (Ctrl+Shift+F4), select the entire database table in the 
data source view (click on the top left corner of the table), and then drag the 
selection to a text document or spreadsheet.
 Sorting and 
Filtering Data
 Allows you to 
sort and filter the data in a query table.
 Query 
Design
diff --git a/source/text/shared/explorer/database/querywizard05.xhp 
b/source/text/shared/explorer/database/querywizard05.xhp
index 12fc8802c..8f1182e4c 100644
--- a/source/text/shared/explorer/database/querywizard05.xhp
+++ b/source/text/shared/explorer/database/querywizard05.xhp
@@ -29,7 +29,7 @@
 
 
 Query Wizard - 
Grouping
-Specifies 
whether to group the query. The data source must support the SQL statement 
"Order by clauses" to enable this page of the Wizard.
+Specifies 
whether to group the query. The data source must support the SQL statement 
"Group by clauses" to enable this page of the Wizard.
 
 
 
diff --git a/source/text/shared/explorer/database/querywizard06.xhp 
b/source/text/shared/explorer/database/querywizard06.xhp
index 18d81439d..0f5c69f34 100644
--- 

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3af243a4facf67e4575513da00ce9921daf7eafc
Author: Olivier Hallot 
Date:   Wed May 17 20:25:39 2017 -0300

Updated core
Project: help  9b2ab190af0db946c0ceb57d45ac6778fcfc2e6e

Fix several mistakes flagged by translators

Change-Id: If2e081fa32ec82250514c59d820adb5fa071669b
Reviewed-on: https://gerrit.libreoffice.org/37743
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 6f947c50faf2..9b2ab190af0d 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 6f947c50faf2969405749fc118659d9d9934eb91
+Subproject commit 9b2ab190af0db946c0ceb57d45ac6778fcfc2e6e
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sc/source

[Eike Rathke]

 sc/source/core/tool/compiler.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 13238b860f546afd750db561cd0292ed6869744e
Author: Eike Rathke 
Date:   Thu May 18 14:13:43 2017 +0200

assert instead of OSL_ENSURE if grammar is GRAM_UNSPECIFIED

Change-Id: Ie23a5a98e9bc6dfbd5d685c482fb358ac3822845
(cherry picked from commit 730622df7c0e97917c3c0d53b1ec03691d0afb74)
Reviewed-on: https://gerrit.libreoffice.org/37766
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index a95f2da5698c..d6f171e7c621 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -195,7 +195,7 @@ void ScCompiler::InitCharClassEnglish()
 
 void ScCompiler::SetGrammar( const FormulaGrammar::Grammar eGrammar )
 {
-OSL_ENSURE( eGrammar != FormulaGrammar::GRAM_UNSPECIFIED, 
"ScCompiler::SetGrammar: don't pass FormulaGrammar::GRAM_UNSPECIFIED");
+assert( eGrammar != FormulaGrammar::GRAM_UNSPECIFIED && 
"ScCompiler::SetGrammar: don't pass FormulaGrammar::GRAM_UNSPECIFIED");
 if (eGrammar == GetGrammar())
 return; // nothing to be done
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fd71a6099c0f77279bfc9da8d3268a716adc5a7a
Author: Olivier Hallot 
Date:   Wed May 17 16:34:06 2017 -0300

Updated core
Project: help  6f947c50faf2969405749fc118659d9d9934eb91

tdf#84675 (part4) document VBA macros support

Change-Id: I61f60fb4f3ac27604a71972f0c1d8a7e9effdcc4
Reviewed-on: https://gerrit.libreoffice.org/37735
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index a50d8ddab0d6..6f947c50faf2 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit a50d8ddab0d6037ee72424a21a18b9d07d53bdb7
+Subproject commit 6f947c50faf2969405749fc118659d9d9934eb91
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 09a69222ffac4b053e792171e8e9d9abf5899b39
Author: Olivier Hallot 
Date:   Wed May 17 09:18:45 2017 -0300

Updated core
Project: help  a50d8ddab0d6037ee72424a21a18b9d07d53bdb7

tdf#84675 (part3) Document Basic constants

Document Basic constants more explicitely.

Change-Id: I76958041552148cc65e5bfb49eed6944991a0637
Reviewed-on: https://gerrit.libreoffice.org/37705
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 115035ec9e29..a50d8ddab0d6 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 115035ec9e29cc0db7837a52cd7ee8527526d6b1
+Subproject commit a50d8ddab0d6037ee72424a21a18b9d07d53bdb7
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: AllLangHelp_sbasic.mk source/text

[Olivier Hallot]

 AllLangHelp_sbasic.mk|2 
 source/text/sbasic/shared/03103350.xhp   |   71 
 source/text/sbasic/shared/main0601.xhp   |   38 
 source/text/sbasic/shared/vbasupport.xhp |   55 
 source/text/shared/optionen/01130100.xhp |  134 ++-
 5 files changed, 227 insertions(+), 73 deletions(-)

New commits:
commit 6f947c50faf2969405749fc118659d9d9934eb91
Author: Olivier Hallot 
Date:   Wed May 17 16:34:06 2017 -0300

tdf#84675 (part4) document VBA macros support

Change-Id: I61f60fb4f3ac27604a71972f0c1d8a7e9effdcc4
Reviewed-on: https://gerrit.libreoffice.org/37735
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/AllLangHelp_sbasic.mk b/AllLangHelp_sbasic.mk
index 4ac32080b..1be0b6bbe 100644
--- a/AllLangHelp_sbasic.mk
+++ b/AllLangHelp_sbasic.mk
@@ -252,6 +252,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,sbasic,\
 helpcontent2/source/text/sbasic/shared/03103100 \
 helpcontent2/source/text/sbasic/shared/03103200 \
 helpcontent2/source/text/sbasic/shared/03103300 \
+helpcontent2/source/text/sbasic/shared/03103350 \
 helpcontent2/source/text/sbasic/shared/03103400 \
 helpcontent2/source/text/sbasic/shared/03103450 \
 helpcontent2/source/text/sbasic/shared/03103500 \
@@ -324,6 +325,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,sbasic,\
 helpcontent2/source/text/sbasic/shared/keys \
 helpcontent2/source/text/sbasic/shared/main0211 \
 helpcontent2/source/text/sbasic/shared/main0601 \
+helpcontent2/source/text/sbasic/shared/vbasupport \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/source/text/sbasic/shared/03103350.xhp 
b/source/text/sbasic/shared/03103350.xhp
new file mode 100644
index 0..6cd1eb426
--- /dev/null
+++ b/source/text/sbasic/shared/03103350.xhp
@@ -0,0 +1,71 @@
+
+
+
+
+
+  
+Option VBASupport Statement 
[Runtime]
+/text/sbasic/shared/03103350.xhp
+  
+
+
+
+
+
+
+
+  MS Excel macros support;Enable
+  MS Excel macros support;Option VBASupport 
statement
+  VBA Support;Option VBASupport statement
+  Option VBASupport statement
+
+
+
+Option VBASupport Statement [Runtime]
+Specifies that 
%PRODUCTNAME Basic will support some VBA statements, functions and 
objects.
+
+The 
support for VBA is not complete, but covers a large portion of the common usage 
patterns.
+
+Syntax:
+
+Option VBASupport {1|0}
+
+
+Parameters:
+This statement 
must be added before the executable program code in a module.
+1: 
Enable VBA support in %PRODUCTNAME
+0: 
Disable VBA support
+
+Example:
+
+Option VBASupport 1
+Sub ExampleVBA
+Dim sVar As Single
+ sVar = Worksheets("Sheet1").Range("A1")
+Print sVar
+End Sub
+
+
+
+VBA 
Properties
+VBA support in 
%PRODUCTNAME
+
+
+
+
\ No newline at end of file
diff --git a/source/text/sbasic/shared/main0601.xhp 
b/source/text/sbasic/shared/main0601.xhp
index 45324adca..e9e9e5016 100644
--- a/source/text/sbasic/shared/main0601.xhp
+++ b/source/text/sbasic/shared/main0601.xhp
@@ -1,6 +1,5 @@
 
-
-
+
 
+-->
 
-
-
 
-
-$[officename] Basic Help
-/text/sbasic/shared/main0601.xhp
-
-
-Sun Microsystems, Inc.
-
+  
+$[officename] Basic Help
+/text/sbasic/shared/main0601.xhp
+  
 
+
 
+
 
-%PRODUCTNAME Basic Help
+
+%PRODUCTNAME Basic Help
+
 
-%PRODUCTNAME 
provides an Application Programming Interface (API) that allows controlling the 
$[officename] components with different programming languages by using the 
$[officename] Software Development Kit (SDK). For more information about the 
$[officename] API and the Software Development Kit, visit http://api.libreoffice.org/; 
name="http://api.libreoffice.org;>http://api.libreoffice.org
-This help 
section explains the most common runtime functions of %PRODUCTNAME Basic. For 
more in-depth information please refer to the http://wiki.documentfoundation.org/Documentation/BASIC_Guide;>OpenOffice.org
 BASIC Programming Guide on the Wiki.
+%PRODUCTNAME 
provides an Application Programming Interface (API) that allows controlling the 
$[officename] components with different programming languages by using the 
$[officename] Software Development Kit (SDK). For more information about the 
$[officename] API and the Software Development Kit, visit http://api.libreoffice.org/; 
name="http://api.libreoffice.org;>http://api.libreoffice.org
+This help 
section explains the most common runtime functions of %PRODUCTNAME Basic. For 
more in-depth information please refer to the http://wiki.documentfoundation.org/Documentation/BASIC_Guide;>OpenOffice.org
 BASIC Programming Guide on the Wiki.
 
-Working 
with %PRODUCTNAME Basic
+
+Working 
with %PRODUCTNAME Basic
 
 
 
@@ -46,7 +45,9 @@
 
 
 
-Help 
about the Help
+
+
+Help 
about the Help
 
 
 
@@ -55,4 +56,5 @@
 
 
 
-
+
+
\ No newline at end of file
diff --git a/source/text/sbasic/shared/vbasupport.xhp 

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ee04acf86ebaa54348e64d9b5721edc77eaf11de
Author: Olivier Hallot 
Date:   Tue May 16 18:20:38 2017 -0300

Updated core
Project: help  115035ec9e29cc0db7837a52cd7ee8527526d6b1

tdf#84675 (part2) Document hidden BASIC constants

Constants for TypeName/Vartype

add tablehead style

Change-Id: Ic613e1552af96df4a57d461600e26c11d5b289c2
Reviewed-on: https://gerrit.libreoffice.org/37692
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 7d4439d5b834..115035ec9e29 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 7d4439d5b834de3cb9b7d0d1dc8afe41d30c76b2
+Subproject commit 115035ec9e29cc0db7837a52cd7ee8527526d6b1
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: 2 commits - AllLangHelp_sbasic.mk source/text

[Olivier Hallot]

 AllLangHelp_sbasic.mk  |1 
 source/text/sbasic/shared/0300.xhp |   61 --
 source/text/sbasic/shared/0304.xhp |  201 +
 source/text/sbasic/shared/03103600.xhp |   96 ---
 4 files changed, 307 insertions(+), 52 deletions(-)

New commits:
commit a50d8ddab0d6037ee72424a21a18b9d07d53bdb7
Author: Olivier Hallot 
Date:   Wed May 17 09:18:45 2017 -0300

tdf#84675 (part3) Document Basic constants

Document Basic constants more explicitely.

Change-Id: I76958041552148cc65e5bfb49eed6944991a0637
Reviewed-on: https://gerrit.libreoffice.org/37705
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/AllLangHelp_sbasic.mk b/AllLangHelp_sbasic.mk
index d93e0b745..4ac32080b 100644
--- a/AllLangHelp_sbasic.mk
+++ b/AllLangHelp_sbasic.mk
@@ -144,6 +144,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,sbasic,\
 helpcontent2/source/text/sbasic/shared/03030301 \
 helpcontent2/source/text/sbasic/shared/03030302 \
 helpcontent2/source/text/sbasic/shared/03030303 \
+helpcontent2/source/text/sbasic/shared/0304 \
 helpcontent2/source/text/sbasic/shared/0305 \
 helpcontent2/source/text/sbasic/shared/03050100 \
 helpcontent2/source/text/sbasic/shared/03050200 \
diff --git a/source/text/sbasic/shared/0300.xhp 
b/source/text/sbasic/shared/0300.xhp
index 27cb47665..46d180104 100644
--- a/source/text/sbasic/shared/0300.xhp
+++ b/source/text/sbasic/shared/0300.xhp
@@ -1,6 +1,5 @@
 
-
-
+
 
+-->
 
-
 
-
-Run-Time Functions
-/text/sbasic/shared/0300.xhp
-
-
-Sun Microsystems, Inc.
-
+  
+Run-Time Functions
+/text/sbasic/shared/0300.xhp
+  
 
+
 
-  
-  
-  
-  Run-Time 
Functions
-  This section 
describes the Runtime Functions of %PRODUCTNAME 
Basic.
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
- 
-
+
+
+
+
+Run-Time 
Functions
+This section 
describes the Runtime Functions of %PRODUCTNAME 
Basic.
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file
diff --git a/source/text/sbasic/shared/0304.xhp 
b/source/text/sbasic/shared/0304.xhp
new file mode 100644
index 0..ec80f030d
--- /dev/null
+++ b/source/text/sbasic/shared/0304.xhp
@@ -0,0 +1,201 @@
+
+
+
+
+
+  
+Basic Constants
+/text/sbasic/shared/0304.xhp
+  
+
+
+
+
+
+
+
+  Pi;Basic constant
+  Null;Basic constant
+  Empty;Basic constant
+  Nothing;Basic constant
+  Basic constant;Nothing
+  Basic constant;Null
+  Basic constant;Empty
+  Basic constant;Pi
+  Basic constant;False
+  Basic constant;True
+
+
+
+Basic 
Constants
+Constants used in Basic 
programs
+
+
+Boolean constants
+
+
+  
+
+  Name
+
+
+  Type
+
+
+  Value
+
+  
+  
+
+  True
+
+
+  Boolean
+
+
+  1
+
+  
+  
+
+  False
+
+
+  Boolean
+
+
+  0
+
+  
+
+
+
+Example
+
+Dim bPositive as Boolean
+bPositive = True
+
+
+Mathematical constant
+
+
+  
+
+  Name
+
+
+  Type
+
+
+  Value
+
+  
+  
+
+  Pi
+
+
+  Double
+
+
+  3.14159265358979
+
+  
+
+
+
+Example
+
+Function Rad2Deg( aRad as Double) As Double
+Rad2Deg = aRad * 180.00 / Pi
+End Function
+
+
+Object Constants
+
+
+  
+
+  Name
+
+
+  Type
+
+
+  Usage
+
+  
+  
+
+  Empty
+
+
+  Variant
+
+
+  The Empty value indicates that the variable is 
not initialized.
+
+  
+  
+
+  Null
+
+
+  null
+
+
+  Indicates that the variable does not contain data.
+
+  
+  
+
+  Nothing
+
+
+  Object
+
+
+  Assign the Nothing object to a variable to remove 
a previous assignment.
+
+  
+
+
+
+Example
+
+SubExampleEmpty
+Dim sVar As Variant
+ sVar = Empty
+ Print IsEmpty(sVar) ' Returns True
+End Sub
+Sub ExampleNull
+Dim vVar As Variant
+ MsgBox IsNull(vVar)
+End Sub
+Sub ExampleNothing
+Dim oDoc As Object
+ Set oDoc = ThisComponent
+ Print oDoc.Title
+ oDoc = Nothing
+ Print oDoc ‘ Error
+End Sub
+
+
+
+
commit 115035ec9e29cc0db7837a52cd7ee8527526d6b1
Author: Olivier Hallot 
Date:   Tue May 16 18:20:38 2017 -0300

tdf#84675 (part2) Document hidden BASIC constants

Constants for TypeName/Vartype

add tablehead style

Change-Id: Ic613e1552af96df4a57d461600e26c11d5b289c2
Reviewed-on: https://gerrit.libreoffice.org/37692
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/source/text/sbasic/shared/03103600.xhp 
b/source/text/sbasic/shared/03103600.xhp
index 33a0d2c5a..bb1da9b39 100644
--- a/source/text/sbasic/shared/03103600.xhp
+++ b/source/text/sbasic/shared/03103600.xhp
@@ -41,7 +41,7 @@
 
 Syntax:
 

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sw/source

[Michael Stahl]

 sw/source/core/doc/DocumentRedlineManager.cxx |   21 +
 sw/source/core/inc/DocumentRedlineManager.hxx |1 +
 2 files changed, 22 insertions(+)

New commits:
commit 7ab4ee1677470ae09a843a53326da81c6e17714a
Author: Michael Stahl 
Date:   Tue Apr 25 21:38:28 2017 +0200

ofz#1262 sw: DeleteAndJoin could delete proposed new redline

... because that calls CompressRedlines, which may combine the new
redline with a previous one.

In that case, the part of the new redline that follows the currently
handled overlap cannot be checked for overlaps with subsequent existing
redlines.

So prevent this with a new flag m_isForbidCompressRedlines and instead
call CompressRedlines() at the end of AppendRedline().

Change-Id: I7567962c31366ded9a433a13232d3db985745e43
Reviewed-on: https://gerrit.libreoffice.org/37765
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/core/doc/DocumentRedlineManager.cxx 
b/sw/source/core/doc/DocumentRedlineManager.cxx
index b9e6b39e5025..047d345a1d6c 100644
--- a/sw/source/core/doc/DocumentRedlineManager.cxx
+++ b/sw/source/core/doc/DocumentRedlineManager.cxx
@@ -30,6 +30,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace com::sun::star;
 
@@ -1226,10 +1227,15 @@ bool DocumentRedlineManager::AppendRedline( 
SwRangeRedline* pNewRedl, bool bCall
 // also dealt with when moving the indices.
 if( bCallDelete )
 {
+::comphelper::FlagGuard 
g(m_isForbidCompressRedlines);
 mpRedlineTable->Insert( pNewRedl );
 
m_rDoc.getIDocumentContentOperations().DeleteAndJoin( *pRedl );
 if( !mpRedlineTable->Remove( pNewRedl ) )
+{
+assert(false); // can't happen
 pNewRedl = nullptr;
+}
+bCompress = true; // delayed compress
 }
 delete pRedl;
 }
@@ -1253,10 +1259,15 @@ bool DocumentRedlineManager::AppendRedline( 
SwRangeRedline* pNewRedl, bool bCall
 {
 // We insert temporarily so that pNew is
 // also dealt with when moving the indices.
+::comphelper::FlagGuard 
g(m_isForbidCompressRedlines);
 mpRedlineTable->Insert( pNewRedl );
 
m_rDoc.getIDocumentContentOperations().DeleteAndJoin( aPam );
 if( !mpRedlineTable->Remove( pNewRedl ) )
+{
+assert(false); // can't happen
 pNewRedl = nullptr;
+}
+bCompress = true; // delayed compress
 n = 0;  // re-initialize
 }
 bDec = true;
@@ -1279,10 +1290,15 @@ bool DocumentRedlineManager::AppendRedline( 
SwRangeRedline* pNewRedl, bool bCall
 {
 // We insert temporarily so that pNew is
 // also dealt with when moving the indices.
+::comphelper::FlagGuard 
g(m_isForbidCompressRedlines);
 mpRedlineTable->Insert( pNewRedl );
 
m_rDoc.getIDocumentContentOperations().DeleteAndJoin( aPam );
 if( !mpRedlineTable->Remove( pNewRedl ) )
+{
+assert(false); // can't happen
 pNewRedl = nullptr;
+}
+bCompress = true; // delayed compress
 n = 0;  // re-initialize
 bDec = true;
 }
@@ -1777,6 +1793,11 @@ bool DocumentRedlineManager::AppendTableCellRedline( 
SwTableCellRedline* pNewRed
 
 void DocumentRedlineManager::CompressRedlines()
 {
+if (m_isForbidCompressRedlines)
+{
+return;
+}
+
 CHECK_REDLINE( *this )
 
 void (SwRangeRedline::*pFnc)(sal_uInt16, size_t) = nullptr;
diff --git a/sw/source/core/inc/DocumentRedlineManager.hxx 
b/sw/source/core/inc/DocumentRedlineManager.hxx
index 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - include/xmloff sw/qa xmloff/source

[Tamás Zolnai]

 include/xmloff/txtimp.hxx   |5 +
 sw/qa/extras/odfimport/data/tdf100033_1.odt |binary
 sw/qa/extras/odfimport/data/tdf100033_2.odt |binary
 sw/qa/extras/odfimport/odfimport.cxx|   16 ++
 xmloff/source/text/XMLTextFrameContext.cxx  |   29 +++
 xmloff/source/text/txtimp.cxx   |   71 
 6 files changed, 112 insertions(+), 9 deletions(-)

New commits:
commit 25dd6bdca2ba08c3fdd90790df067db829231867
Author: Tamás Zolnai 
Date:   Wed May 17 15:00:30 2017 +0200

tdf#100033: Frames with the same name are removed

Allow to have frames with the same name. For removing
real duplicated frames (generated by LO earlier)
check other things also next to the frame name:
position, size or whether the two frames are anchored
to the same position.

Reviewed-on: https://gerrit.libreoffice.org/37702
Tested-by: Jenkins 
Reviewed-by: Tamás Zolnai 
(cherry picked from commit 6952d696439981962ad378aa28b0d16ea6e48f0e)

Change-Id: I191ae5128d0228eb85f78f065b44b1f0b3ba6dcf
Reviewed-on: https://gerrit.libreoffice.org/37708
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 

diff --git a/include/xmloff/txtimp.hxx b/include/xmloff/txtimp.hxx
index cab9f53653e4..ceedf377d9a2 100644
--- a/include/xmloff/txtimp.hxx
+++ b/include/xmloff/txtimp.hxx
@@ -536,6 +536,11 @@ public:
 GetChapterNumbering() const;
 
 bool HasFrameByName( const OUString& rName ) const;
+
+bool IsDuplicateFrame(const OUString& sName, sal_Int32 nX, sal_Int32 nY, 
sal_Int32 nWidth, sal_Int32 nHeight) const;
+void StoreLastImportedFrameName(const OUString& rName);
+void ClearLastImportedTextFrameName();
+
 void ConnectFrameChains( const OUString& rFrmName,
 const OUString& rNextFrmName,
 const css::uno::Reference< css::beans::XPropertySet >& rFrmPropSet );
diff --git a/sw/qa/extras/odfimport/data/tdf100033_1.odt 
b/sw/qa/extras/odfimport/data/tdf100033_1.odt
new file mode 100755
index ..b7f3ae7aaeb4
Binary files /dev/null and b/sw/qa/extras/odfimport/data/tdf100033_1.odt differ
diff --git a/sw/qa/extras/odfimport/data/tdf100033_2.odt 
b/sw/qa/extras/odfimport/data/tdf100033_2.odt
new file mode 100755
index ..98ae7bd6b31d
Binary files /dev/null and b/sw/qa/extras/odfimport/data/tdf100033_2.odt differ
diff --git a/sw/qa/extras/odfimport/odfimport.cxx 
b/sw/qa/extras/odfimport/odfimport.cxx
index 6c442edf0ad8..48d263ee985f 100644
--- a/sw/qa/extras/odfimport/odfimport.cxx
+++ b/sw/qa/extras/odfimport/odfimport.cxx
@@ -773,5 +773,21 @@ DECLARE_ODFIMPORT_TEST(testTdf107392, "tdf107392.odt")
 CPPUNIT_ASSERT_EQUAL(sal_Int32(2), 
getProperty(getShapeByName("SVG"), "ZOrder"));
 }
 
+DECLARE_ODFIMPORT_TEST(testTdf100033_1, "tdf100033_1.odt")
+{
+// Test document have three duplicated frames with the same name and 
position/size -> import one frame
+uno::Reference xTextFramesSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xIndexAccess(xTextFramesSupplier->getTextFrames(), uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xIndexAccess->getCount());
+}
+
+DECLARE_ODFIMPORT_TEST(testTdf100033_2, "tdf100033_2.odt")
+{
+// Test document have three different frames anchored to different 
paragraphs -> import all frames
+uno::Reference xTextFramesSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xIndexAccess(xTextFramesSupplier->getTextFrames(), uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(3), xIndexAccess->getCount());
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/xmloff/source/text/XMLTextFrameContext.cxx 
b/xmloff/source/text/XMLTextFrameContext.cxx
index 7edb08702ac6..a86d6d3d214c 100644
--- a/xmloff/source/text/XMLTextFrameContext.cxx
+++ b/xmloff/source/text/XMLTextFrameContext.cxx
@@ -410,6 +410,7 @@ class XMLTextFrameContext_Impl : public SvXMLImportContext
 boolbSyncHeight : 1;
 boolbCreateFailed : 1;
 boolbOwnBase64Stream : 1;
+boolmbMultipleContent : 1; // This context is created based on a 
multiple content (image)
 
 void Create( bool bHRefOrBase64 );
 
@@ -425,7 +426,8 @@ public:
 const css::uno::Reference & 
rAttrList,
 css::text::TextContentAnchorType eAnchorType,
 sal_uInt16 nType,
-const css::uno::Reference & 
rFrameAttrList );
+const css::uno::Reference & 
rFrameAttrList,
+bool bMultipleContent = false);
 virtual ~XMLTextFrameContext_Impl() override;
 
 virtual void EndElement() override;
@@ -448,6 +450,8 @@ public:
 
 void SetName();
 
+const OUString& GetOrigName() const { return m_sOrigName; }
+
 css::text::TextContentAnchorType GetAnchorType() const { return 
eAnchorType; }
 
 const 

[Libreoffice-bugs] [Bug 33944] [UI]: Option to export and print slides selected by custom slide show

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=33944

Timur  changed:

   What|Removed |Added

Summary|[PRESENTATION] [UI]: Option |[UI]: Option to export and
   |to export or print slides   |print slides selected by
   |selected by custom slide|custom slide show
   |show|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - filter/source

[Caolán McNamara]

 filter/source/graphicfilter/ieps/ieps.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1cbb19e187a981d4f4803aae189ed931d9e03a62
Author: Caolán McNamara 
Date:   Mon May 15 11:29:11 2017 +0100

ofz#1542 check remaining size of dest

Change-Id: I37cff45afdb242b31919a8a02e737424e2ecfd52
Reviewed-on: https://gerrit.libreoffice.org/37763
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/filter/source/graphicfilter/ieps/ieps.cxx 
b/filter/source/graphicfilter/ieps/ieps.cxx
index 3ab880a9ae3a..954668bdea92 100644
--- a/filter/source/graphicfilter/ieps/ieps.cxx
+++ b/filter/source/graphicfilter/ieps/ieps.cxx
@@ -654,7 +654,7 @@ ipsGraphicImport( SvStream & rStream, Graphic & rGraphic, 
FilterConfigItem* )
 long nHeight = ImplGetNumber(pDest, nSecurityCount);
 long nBitDepth = ImplGetNumber(pDest, nSecurityCount);
 long nScanLines = ImplGetNumber(pDest, nSecurityCount);
-pDest = ImplSearchEntry( pDest, reinterpret_cast("%"), 16, 1 );   // go to the first Scanline
+pDest = nSecurityCount ? ImplSearchEntry(pDest, 
reinterpret_cast("%"), 16, 1) : nullptr;   // go to the 
first Scanline
 if ( nSecurityCount && pDest && nWidth && nHeight && ( ( 
nBitDepth == 1 ) || ( nBitDepth == 8 ) ) && nScanLines )
 {
 rStream.Seek( nBufStartPos + ( pDest - pBuf.get() ) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 33982] [UI] Add option to print / export only selected slides from Slides Pane ( propagate selected slides to PDF export dialog)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=33982

Timur  changed:

   What|Removed |Added

 CC|LibreOffice@bielefeldundbus |dtar...@redhat.com
   |s.de|
Version|3.3.0 release   |Inherited From OOo
Summary|[UI] Add option to print /  |[UI] Add option to print /
   |export only selected slides |export only selected slides
   |from Slides Pane|from Slides Pane (propagate
   ||selected slides to PDF
   ||export dialog)

--- Comment #10 from Timur  ---
Previous commit is "propagate selected slides to print dialog" and it works. 
It works by writing selected slides to "Slides" which seem logical, but it
doesn't seem consistent with Bug 90436. Maybe there was no other way. 

But in 5.4+ PDF export still doesn't have this "propagate selected slides to
PDF export dialog" so this bug is still valid. 
Selection doesn't work for selected slides. It works as written in Description
"exports selected objects" and not even selected text (I have error, it's a
diff. bug).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sc/source

[Julien Nabet]

 sc/source/ui/unoobj/condformatuno.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 202c5747d23df7fae477f097648135b0bd675c07
Author: Julien Nabet 
Date:   Thu May 18 00:03:32 2017 +0200

tdf#107920: Crash when using ScCompiler in condformat

Just call SetGrammar from ScCompiler object with grammar of document
See bt in https://bugs.documentfoundation.org/attachment.cgi?id=133382

Change-Id: Iedf4b88f2821bbcf728e4b1c023041fd6f10e5f3
Reviewed-on: https://gerrit.libreoffice.org/37739
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 
(cherry picked from commit 63843a97262ccfa38d838a9cbbc3faadba8290a6)
Reviewed-on: https://gerrit.libreoffice.org/37755
Tested-by: Eike Rathke 

diff --git a/sc/source/ui/unoobj/condformatuno.cxx 
b/sc/source/ui/unoobj/condformatuno.cxx
index e97311a6cff1..549fb6710fd4 100644
--- a/sc/source/ui/unoobj/condformatuno.cxx
+++ b/sc/source/ui/unoobj/condformatuno.cxx
@@ -717,6 +717,7 @@ void SAL_CALL ScConditionEntryObj::setPropertyValue(
 if ((aValue >>= aFormula) && !aFormula.isEmpty())
 {
 ScCompiler aComp(>GetDocument(), 
getCoreObject()->GetSrcPos());
+aComp.SetGrammar(mpDocShell->GetDocument().GetGrammar());
 std::unique_ptr 
pArr(aComp.CompileString(aFormula));
 getCoreObject()->SetFormula1(*pArr);
 }
@@ -728,6 +729,7 @@ void SAL_CALL ScConditionEntryObj::setPropertyValue(
 if ((aValue >>= aFormula) && !aFormula.isEmpty())
 {
 ScCompiler aComp(>GetDocument(), 
getCoreObject()->GetSrcPos());
+aComp.SetGrammar(mpDocShell->GetDocument().GetGrammar());
 std::unique_ptr 
pArr(aComp.CompileString(aFormula));
 getCoreObject()->SetFormula2(*pArr);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Stephan Bergmann]

 sc/source/ui/pagedlg/tptable.cxx |8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

New commits:
commit 4544256d6e9fd502ec3cb94a834a8ca804b963d8
Author: Stephan Bergmann 
Date:   Thu May 18 15:13:59 2017 +0200

Replace macro with function

Change-Id: I005622c607a5a3dcd31b46f6e819546b7ece630b

diff --git a/sc/source/ui/pagedlg/tptable.cxx b/sc/source/ui/pagedlg/tptable.cxx
index 1190ef82fbc7..90754c32d1cc 100644
--- a/sc/source/ui/pagedlg/tptable.cxx
+++ b/sc/source/ui/pagedlg/tptable.cxx
@@ -68,7 +68,13 @@ static bool lcl_PutBoolItem( sal_uInt16nWhich,
 #define PAGENO_HDL  LINK(this,ScTablePage,PageNoHdl)
 #define PAGEDIR_HDL LINK(this,ScTablePage,PageDirHdl)
 
-#define WAS_DEFAULT(w,s)(SfxItemState::DEFAULT==(s).GetItemState((w)))
+namespace {
+
+bool WAS_DEFAULT(sal_uInt16 w, SfxItemSet const & s)
+{ return SfxItemState::DEFAULT==s.GetItemState(w); }
+
+}
+
 #define GET_BOOL(sid,set)   static_cast((set).Get(GetWhich((sid.GetValue()
 #define GET_USHORT(sid,set) static_cast((set).Get(GetWhich((sid.GetValue()
 #define GET_SHOW(sid,set)   ( ScVObjMode( static_cast((set).Get(GetWhich((sid.GetValue() ) \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: fpicker/source

[Caolán McNamara]

 fpicker/source/win32/folderpicker/MtaFop.cxx |7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

New commits:
commit a633ffc88c438e4af436c0e66c21a8a6f8c9
Author: Caolán McNamara 
Date:   Thu May 18 11:03:06 2017 +0100

gives names to mysterious 500 and 501

Change-Id: Ie2b02f10ab100ce11330d1a0808e60a02394e230
Reviewed-on: https://gerrit.libreoffice.org/37750
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/fpicker/source/win32/folderpicker/MtaFop.cxx 
b/fpicker/source/win32/folderpicker/MtaFop.cxx
index 3bd3f519672b..3bee561b9304 100644
--- a/fpicker/source/win32/folderpicker/MtaFop.cxx
+++ b/fpicker/source/win32/folderpicker/MtaFop.cxx
@@ -37,6 +37,9 @@ const bool MANUAL_RESET = true;
 const bool AUTO_RESET   = false;
 const bool INIT_NONSIGNALED = false;
 
+#define FOLDERPICKER_TITLE500
+#define FOLDER_PICKER_DEF_DESCRIPTION 501
+
 namespace
 {
 const char* const FOLDERPICKER_SRV_DLL_NAME = "fps.dll";
@@ -141,8 +144,8 @@ CMtaFolderPicker::CMtaFolderPicker( sal_uInt32 Flags ) :
 
 CResourceProvider ResProvider;
 
-m_dialogTitle = ResProvider.getResString( 500 );
-m_Description = ResProvider.getResString( 501 );
+m_dialogTitle = ResProvider.getResString(FOLDERPICKER_TITLE);
+m_Description = ResProvider.getResString(FOLDER_PICKER_DEF_DESCRIPTION);
 
 // signals that the thread was successfully set up
 m_hEvtThrdReady  = CreateEventA(
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sw/source

[Caolán McNamara]

 sw/source/filter/ww8/ww8graf.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 891998d48e2b7cd3c48273b4706b92735033ad17
Author: Caolán McNamara 
Date:   Mon Apr 24 15:06:10 2017 +0100

ofz#1220 sanitize nTyp to legal values

Change-Id: Iad71c4f79dbe03e2e325453eb0506a2d92d67c2d
Reviewed-on: https://gerrit.libreoffice.org/37762
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/filter/ww8/ww8graf.cxx b/sw/source/filter/ww8/ww8graf.cxx
index 121f605f34dd..d404d6c9c29c 100644
--- a/sw/source/filter/ww8/ww8graf.cxx
+++ b/sw/source/filter/ww8/ww8graf.cxx
@@ -1295,7 +1295,7 @@ SdrObject* SwWW8ImplReader::ReadCaptionBox(WW8_DPHEAD* 
pHd, SfxAllItemSet )
 else// no -> take lines
 SetStdAttr( rSet, aCallB.dpPolyLine.aLnt, aCallB.dptxbx.aShd );
 SetFill( rSet, aCallB.dptxbx.aFill );
-rSet.Put( SdrCaptionTypeItem( aCaptA[nTyp] ) );
+rSet.Put(SdrCaptionTypeItem(aCaptA[nTyp % SAL_N_ELEMENTS(aCaptA)]));
 
 return pObj;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - hwpfilter/source

[Caolán McNamara]

 hwpfilter/source/hbox.cxx|2 --
 hwpfilter/source/hbox.h  |2 --
 hwpfilter/source/hwpfile.cxx |   10 --
 hwpfilter/source/hwpread.cxx |1 +
 4 files changed, 1 insertion(+), 14 deletions(-)

New commits:
commit 77282b66b27f8e3156b2fb68a9a3a363643ff2f8
Author: Caolán McNamara 
Date:   Fri Apr 21 10:51:19 2017 +0100

ofz#1193 we only set these values, never read them

Change-Id: Ia2f54b536a4262e19abe260e8e19c9b15cc2d0ec
Reviewed-on: https://gerrit.libreoffice.org/37761
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/hwpfilter/source/hbox.cxx b/hwpfilter/source/hbox.cxx
index 3bfe57662656..ef6348817f48 100644
--- a/hwpfilter/source/hbox.cxx
+++ b/hwpfilter/source/hbox.cxx
@@ -328,8 +328,6 @@ FBox::FBox(hchar hch)
 , pgy(0)
 , pgno(0)
 , showpg(0)
-, prev(nullptr)
-, next(nullptr)
 {
 }
 
diff --git a/hwpfilter/source/hbox.h b/hwpfilter/source/hbox.h
index a110d70d0f32..8824a0911ded 100644
--- a/hwpfilter/source/hbox.h
+++ b/hwpfilter/source/hbox.h
@@ -316,8 +316,6 @@ struct FBox: public HBox
 short pgx, pgy;   // physical xpos, ypos
 short pgno, showpg;   // pageno where code is
 
-FBox  *prev, *next;
-
 explicit FBox( hchar hch );
 virtual ~FBox() override;
 };
diff --git a/hwpfilter/source/hwpfile.cxx b/hwpfilter/source/hwpfile.cxx
index 729f31a9e317..00c45475fdf1 100644
--- a/hwpfilter/source/hwpfile.cxx
+++ b/hwpfilter/source/hwpfile.cxx
@@ -466,18 +466,8 @@ EmPicture *HWPFile::GetEmPictureByName(char * name)
 return nullptr;
 }
 
-
 void HWPFile::AddBox(FBox * box)
 {
-// LATER if we don't use box->next(),
-// AddBox() and GetBoxHead() are useless;
-if (!blist.empty())
-{
-box->prev = blist.back();
-box->prev->next = box;
-}
-else
-box->prev = nullptr;
 blist.push_back(box);
 }
 
diff --git a/hwpfilter/source/hwpread.cxx b/hwpfilter/source/hwpread.cxx
index 92f484b1d10d..90564df487b9 100644
--- a/hwpfilter/source/hwpread.cxx
+++ b/hwpfilter/source/hwpread.cxx
@@ -219,6 +219,7 @@ bool TxtBox::Read(HWPFile & hwpf)
 hwpf.AddBox(this);
 hwpf.Read2b(_len, 1);
 hwpf.Read2b(, 1);
+unsigned short next;
 hwpf.Read2b(, 1);
 hwpf.Read2b(, 1);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 85786] TOOLBAR: Do not hide customize toolbar context menu after toggling a visible icon

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85786

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||momonas...@gmail.com

--- Comment #8 from Yousuf Philips (jay)  ---
(In reply to Caolán McNamara from comment #7)
> Another possibility is to change "visible buttons" from a submenu to
> menu item which launches an actual dialog where you have a list of entries
> in a list and check/uncheck them

Not really as we already have the 'customize toolbar...' entry just below it
which opens the dialog. I guess this technically cant be achieved and we should
just close it. @Maxim: Any thoughts?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sc/source

[Julien Nabet]

 sc/source/ui/unoobj/condformatuno.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 5756d3d5bd2175335ac302aaa806fd5f2277f564
Author: Julien Nabet 
Date:   Thu May 18 00:03:32 2017 +0200

tdf#107920: Crash when using ScCompiler in condformat

Just call SetGrammar from ScCompiler object with grammar of document
See bt in https://bugs.documentfoundation.org/attachment.cgi?id=133382

Change-Id: Iedf4b88f2821bbcf728e4b1c023041fd6f10e5f3
Reviewed-on: https://gerrit.libreoffice.org/37739
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 
(cherry picked from commit 63843a97262ccfa38d838a9cbbc3faadba8290a6)
Reviewed-on: https://gerrit.libreoffice.org/37756
Tested-by: Eike Rathke 

diff --git a/sc/source/ui/unoobj/condformatuno.cxx 
b/sc/source/ui/unoobj/condformatuno.cxx
index d64b71d9bedd..bfc003e94a05 100644
--- a/sc/source/ui/unoobj/condformatuno.cxx
+++ b/sc/source/ui/unoobj/condformatuno.cxx
@@ -745,6 +745,7 @@ void SAL_CALL ScConditionEntryObj::setPropertyValue(
 if ((aValue >>= aFormula) && !aFormula.isEmpty())
 {
 ScCompiler aComp(>GetDocument(), 
getCoreObject()->GetSrcPos());
+aComp.SetGrammar(mpDocShell->GetDocument().GetGrammar());
 std::unique_ptr 
pArr(aComp.CompileString(aFormula));
 getCoreObject()->SetFormula1(*pArr);
 }
@@ -756,6 +757,7 @@ void SAL_CALL ScConditionEntryObj::setPropertyValue(
 if ((aValue >>= aFormula) && !aFormula.isEmpty())
 {
 ScCompiler aComp(>GetDocument(), 
getCoreObject()->GetSrcPos());
+aComp.SetGrammar(mpDocShell->GetDocument().GetGrammar());
 std::unique_ptr 
pArr(aComp.CompileString(aFormula));
 getCoreObject()->SetFormula2(*pArr);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107166] Text is invisible, both in UI and in editor on update to 5.3.2, older AMD and Intel GPUs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107166

V Stuart Foote  changed:

   What|Removed |Added

   Keywords|possibleRegression  |regression
   Priority|high|highest
   Severity|normal  |major

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107914] .uno:RemoveDirectCharFormats command doesnt seem to work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107914

--- Comment #7 from Yousuf Philips (jay)  ---
(In reply to Maxim Monastirsky from comment #6)
> This commands also seems to revert to the default character style, so this
> is not what we want anyway.

True. I guess creating new commands is the right option (bug 78371).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 3 commits - sc/inc sc/qa sc/source

[Eike Rathke]

 sc/inc/compiler.hxx|   12 ++--
 sc/qa/unit/helper/qahelper.cxx |6 ++
 sc/qa/unit/ucalc_condformat.cxx|   12 
 sc/qa/unit/ucalc_formula.cxx   |   18 ++
 sc/source/core/data/column.cxx |3 +--
 sc/source/core/data/conditio.cxx   |6 ++
 sc/source/core/data/formulacell.cxx|   24 
 sc/source/core/data/grouptokenconverter.cxx|3 +--
 sc/source/core/data/simpleformulacalc.cxx  |6 ++
 sc/source/core/opencl/formulagroupcl.cxx   |3 +--
 sc/source/core/tool/compiler.cxx   |   14 +++---
 sc/source/core/tool/interpr1.cxx   |6 ++
 sc/source/core/tool/rangenam.cxx   |   15 +--
 sc/source/core/tool/reftokenhelper.cxx |3 +--
 sc/source/filter/excel/xechart.cxx |3 +--
 sc/source/filter/excel/xeroot.cxx  |3 +--
 sc/source/filter/excel/xestream.cxx|1 +
 sc/source/filter/excel/xichart.cxx |3 +--
 sc/source/filter/oox/defnamesbuffer.cxx|3 +--
 sc/source/filter/oox/formulabuffer.cxx |9 +++--
 sc/source/filter/oox/revisionfragment.cxx  |3 +--
 sc/source/filter/orcus/interface.cxx   |6 ++
 sc/source/filter/xml/xmlimprt.cxx  |3 +--
 sc/source/ui/app/inputhdl.cxx  |3 +--
 sc/source/ui/condformat/condformatdlgentry.cxx |3 +--
 sc/source/ui/docshell/docfunc.cxx  |3 +--
 sc/source/ui/docshell/impex.cxx|3 +--
 sc/source/ui/formdlg/formula.cxx   |3 +--
 sc/source/ui/miscdlgs/anyrefdg.cxx |3 +--
 sc/source/ui/namedlg/namedefdlg.cxx|3 +--
 sc/source/ui/namedlg/namedlg.cxx   |3 +--
 sc/source/ui/unoobj/chart2uno.cxx  |6 ++
 sc/source/ui/unoobj/funcuno.cxx|3 +--
 sc/source/ui/unoobj/servuno.cxx|3 +--
 sc/source/ui/unoobj/tokenuno.cxx   |   12 
 sc/source/ui/vba/vbaname.cxx   |3 +--
 sc/source/ui/vba/vbanames.cxx  |3 +--
 sc/source/ui/vba/vbarange.cxx  |6 ++
 sc/source/ui/view/tabvwsha.cxx |3 +--
 sc/source/ui/view/viewfun2.cxx |3 +--
 sc/source/ui/view/viewfun4.cxx |3 +--
 sc/source/ui/view/viewfunc.cxx |3 +--
 42 files changed, 92 insertions(+), 145 deletions(-)

New commits:
commit 1469a83ca1d712e30131597d70dad1b3eb322175
Author: Eike Rathke 
Date:   Thu May 18 14:59:54 2017 +0200

Pass grammar to ScCompiler ctor instead of subsequent SetGrammar()

Not only to have more concise code but also to avoid setting grammar
twice if the actual grammar differs from the document's default one.

Change-Id: I7bfd151c22c48a40aea05f5f983fa0370d9fd9ae

diff --git a/sc/qa/unit/helper/qahelper.cxx b/sc/qa/unit/helper/qahelper.cxx
index 7412e39e1188..3c70609298f1 100644
--- a/sc/qa/unit/helper/qahelper.cxx
+++ b/sc/qa/unit/helper/qahelper.cxx
@@ -480,8 +480,7 @@ ScTokenArray* compileFormula(
 ScAddress aPos(0,0,0);
 if (pPos)
 aPos = *pPos;
-ScCompiler aComp(pDoc, aPos);
-aComp.SetGrammar(eGram);
+ScCompiler aComp(pDoc, aPos, eGram);
 return aComp.CompileString(rFormula);
 }
 
@@ -554,8 +553,7 @@ bool isFormulaWithoutError(ScDocument& rDoc, const 
ScAddress& rPos)
 OUString toString(
 ScDocument& rDoc, const ScAddress& rPos, ScTokenArray& rArray, 
formula::FormulaGrammar::Grammar eGram)
 {
-ScCompiler aComp(, rPos, rArray);
-aComp.SetGrammar(eGram);
+ScCompiler aComp(, rPos, rArray, eGram);
 OUStringBuffer aBuf;
 aComp.CreateStringFromTokenArray(aBuf);
 return aBuf.makeStringAndClear();
diff --git a/sc/qa/unit/ucalc_condformat.cxx b/sc/qa/unit/ucalc_condformat.cxx
index 60344c248bde..d436b2b0aff8 100644
--- a/sc/qa/unit/ucalc_condformat.cxx
+++ b/sc/qa/unit/ucalc_condformat.cxx
@@ -739,8 +739,7 @@ void Test::testFormulaListenerSingleCellToSingleCell()
 {
 m_pDoc->InsertTab(0, "test");
 
-ScCompiler aCompiler(m_pDoc, ScAddress(10, 10, 0));
-aCompiler.SetGrammar(formula::FormulaGrammar::GRAM_ENGLISH);
+ScCompiler aCompiler(m_pDoc, ScAddress(10, 10, 0), 
formula::FormulaGrammar::GRAM_ENGLISH);
 
 std::unique_ptr pTokenArray(aCompiler.CompileString("A1"));
 
@@ -758,8 +757,7 @@ void Test::testFormulaListenerSingleCellToMultipleCells()
 {
 m_pDoc->InsertTab(0, "test");
 
-ScCompiler aCompiler(m_pDoc, ScAddress(10, 10, 0));
-aCompiler.SetGrammar(formula::FormulaGrammar::GRAM_ENGLISH);
+ScCompiler aCompiler(m_pDoc, ScAddress(10, 10, 0), 
formula::FormulaGrammar::GRAM_ENGLISH);
 
 std::unique_ptr pTokenArray(aCompiler.CompileString("A1"));
 
@@ -777,8 

[Libreoffice-commits] core.git: Changes to 'libreoffice-5-4'

[Christian Lohmaier]

New branch 'libreoffice-5-4' available with the following commits:
commit eeb9e60fb88ec44884938003d7d11771c7fffd78
Author: Christian Lohmaier 
Date:   Thu May 18 12:49:06 2017 +0200

bump product version to 5.4.0.0.beta1+

Change-Id: Ia95a0d0e8e5febce9b67e685457c6372864c5ee0

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 52225] Greek symbols default to non-italic, need additional control of the GreekCharStyle property

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=52225

--- Comment #26 from V Stuart Foote  ---
(In reply to john from comment #25)
> Yes please! Setting the default mode to '2' would be greatly preferred.

That was your bug 105483. Default setting changed to '2' at 5.4, rejected for
5.3

=-ref-=
master/5.4
https://gerrit.libreoffice.org/#/c/33480/

5.3 backport
https://gerrit.libreoffice.org/#/c/33598/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 52225] Greek symbols default to non-italic, need additional control of the GreekCharStyle property

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=52225

--- Comment #26 from V Stuart Foote  ---
(In reply to john from comment #25)
> Yes please! Setting the default mode to '2' would be greatly preferred.

That was your bug 105483. Default setting changed to '2' at 5.4, rejected for
5.3

=-ref-=
master/5.4
https://gerrit.libreoffice.org/#/c/33480/

5.3 backport
https://gerrit.libreoffice.org/#/c/33598/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 103494] [META] Textbox bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103494

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||107825


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107825
[Bug 107825] UX: Handling of empty textboxes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107825] UX: Handling of empty textboxes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107825

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||philip...@hotmail.com
 Blocks||103494
 Ever confirmed|0   |1

--- Comment #1 from Yousuf Philips (jay)  ---
(In reply to Telesto from comment #0)
> * Textboxes don't have any (visualized) border when deselected

Yes this should be fixed.

> * Empty text objects get removed automatically (because otherwise you might
> fill you document unintentionally with unused, empty and mostly invisible
> objects without noticing)

This is good behaviour.

> - dragging empty textbox (see also: bug 98856)

This is good behaviour.

> - pasting text into an empty textbox using right click paste

After the creation of the textbox, pressing ctrl+v or the context menu key
works, ideally this should also work.

> - make layout changes to the textbox before adding content

Layout changes after inserting text into the textbox is correct.

> - when cutting all the content out of a textbox and paste it into the
> regular text  (with the intention to use the textbox for something else). 

Yes the textbox should still be present after doing this and shouldnt
automatically be deleted because its empty.

As there are three things that can be fixed, we should separate them into
separate bugs.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103494
[Bug 103494] [META] Textbox bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 107825] UX: Handling of empty textboxes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107825

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||philip...@hotmail.com
 Blocks||103494
 Ever confirmed|0   |1

--- Comment #1 from Yousuf Philips (jay)  ---
(In reply to Telesto from comment #0)
> * Textboxes don't have any (visualized) border when deselected

Yes this should be fixed.

> * Empty text objects get removed automatically (because otherwise you might
> fill you document unintentionally with unused, empty and mostly invisible
> objects without noticing)

This is good behaviour.

> - dragging empty textbox (see also: bug 98856)

This is good behaviour.

> - pasting text into an empty textbox using right click paste

After the creation of the textbox, pressing ctrl+v or the context menu key
works, ideally this should also work.

> - make layout changes to the textbox before adding content

Layout changes after inserting text into the textbox is correct.

> - when cutting all the content out of a textbox and paste it into the
> regular text  (with the intention to use the textbox for something else). 

Yes the textbox should still be present after doing this and shouldnt
automatically be deleted because its empty.

As there are three things that can be fixed, we should separate them into
separate bugs.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103494
[Bug 103494] [META] Textbox bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 97720] Content of OLE object for ChemDraw not visible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97720

Bartosz  changed:

   What|Removed |Added

 CC||gan...@poczta.onet.pl

--- Comment #7 from Bartosz  ---
Created attachment 133387
  --> https://bugs.documentfoundation.org/attachment.cgi?id=133387=edit
Screenshot from LibreOffice 5.4. The image is displayed correctly

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97720] Content of OLE object for ChemDraw not visible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97720

Bartosz  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #6 from Bartosz  ---
This issue was already resolved with LibreOffice 5.4

*** This bug has been marked as a duplicate of bug 31814 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - loleaflet/po

[Andras Timar]

 loleaflet/po/help-kk.po|   40 ++-
 loleaflet/po/help-pa_IN.po |   58 
 loleaflet/po/ui-da.po  |   27 +++
 loleaflet/po/ui-eo.po  |   12 +--
 loleaflet/po/ui-es.po  |   20 ++---
 loleaflet/po/ui-eu.po  |   52 +++---
 loleaflet/po/ui-it.po  |6 -
 loleaflet/po/ui-nn.po  |   52 +++---
 loleaflet/po/ui-sk.po  |   12 +--
 loleaflet/po/ui-tr.po  |   54 +++
 loleaflet/po/ui-zh_CN.po   |  157 ++---
 11 files changed, 228 insertions(+), 262 deletions(-)

New commits:
commit b30d1250cf84ae5f5205a2f893760afcee7d2e68
Author: Andras Timar 
Date:   Thu May 18 14:47:10 2017 +0200

loleaflet: updated translations

Change-Id: Id087c7e380f86b6e43f7338bca4e7ecbd4fe26fc

diff --git a/loleaflet/po/help-kk.po b/loleaflet/po/help-kk.po
index 7b0874f7..4c431a8d 100644
--- a/loleaflet/po/help-kk.po
+++ b/loleaflet/po/help-kk.po
@@ -2,7 +2,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2017-04-24 18:11+\n"
+"POT-Creation-Date: 2017-05-15 08:01+\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME \n"
 "Language-Team: LANGUAGE \n"
@@ -12,7 +12,7 @@ msgstr ""
 "Content-Transfer-Encoding: 8bit\n"
 "X-Generator: Translate Toolkit 2.0.0\n"
 "X-Pootle-Path: /kk/libo_online/loleaflet-help-kk.po\n"
-"X-Pootle-Revision: 2514344\n"
+"X-Pootle-Revision: 2551346\n"
 
 #: dist%2Floleaflet-help.html+div.h1%3A25
 msgid "Keyboard Shortcuts"
@@ -134,99 +134,84 @@ msgstr "Ctrl + Alt + 5"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A45
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A166
-#, fuzzy
 msgid "Superscript"
-msgstr "Үстіңгі индекс"
+msgstr "Жоғарғы индекс"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A45
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A166
-#, fuzzy
 msgid "Ctrl + Shift + P"
 msgstr "Ctrl + Shift + P"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A46
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A167
-#, fuzzy
 msgid "Subscript"
-msgstr "Астыңғы индекс"
+msgstr "Төменгі индекс"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A46
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A167
-#, fuzzy
 msgid "Ctrl + Shift + B"
 msgstr "Ctrl + Shift + B"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A47
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A141
-#, fuzzy
 msgid "Remove direct formatting"
-msgstr "Пішімдеуін кетіру"
+msgstr "Пішімдеуін өшіру"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A47
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A141
-#, fuzzy
 msgid "Ctrl + M"
 msgstr "Ctrl + M"
 
 #: dist%2Floleaflet-help.html+div.div.h2%3A49
 #: dist%2Floleaflet-help.html+div.div.h2%3A170
-#, fuzzy
 msgid "Paragraph formatting"
 msgstr "Абзац пішімі"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A51
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A146
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A172
-#, fuzzy
 msgid "Align Center"
 msgstr "Ортасына туралау"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A51
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A146
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A172
-#, fuzzy
 msgid "Ctrl + E"
 msgstr "Ctrl + E"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A52
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A147
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A173
-#, fuzzy
 msgid "Align Left"
 msgstr "Солға туралау"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A52
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A147
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A173
-#, fuzzy
 msgid "Ctrl + L"
 msgstr "Ctrl + L"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A53
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A148
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A174
-#, fuzzy
 msgid "Align Right"
 msgstr "Оңға туралау"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A53
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A148
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A174
-#, fuzzy
 msgid "Ctrl + R"
 msgstr "Ctrl + R"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A54
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A149
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A175
-#, fuzzy
 msgid "Justify"
 msgstr "Енімен туралау"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A54
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A149
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A175
-#, fuzzy
 msgid "Ctrl + J"
 msgstr "Ctrl + J"
 
@@ -260,7 +245,6 @@ msgstr "Тақырыптама 3 абзац стилін 
іске асыру"
 
 #: 

[Libreoffice-bugs] [Bug 103494] [META] Textbox bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103494

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||91873


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=91873
[Bug 91873] Textbox border doesnt appear on bullet point textboxes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91873] Textbox border doesnt appear on bullet point textboxes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91873

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||103494


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103494
[Bug 103494] [META] Textbox bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107932] New: Add option to export slide titles as bookmarks from Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107932

Bug ID: 107932
   Summary: Add option to export slide titles as bookmarks from
Impress
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gti...@gmail.com

Impress like other LO apps has an option "Export bookmarks" on PDF export.
Seems to be there from OO.

It exports slide names, which seems not be documented. 
https://help.libreoffice.org/index.php?title=Common/Export_as_PDF only says:
...export bookmarks of Writer documents as PDF bookmarks. Bookmarks are created
for all outline paragraphs (Tools - Outline Numbering) 

Presentation usually has slide titles and rarely slide renames (at least in my
case). In that case bookmarks are: Slide 1, Slide 2, 

I propose having an option to also export slide titles as bookmarks, like:
"Export bookmarks as: [] Slide names  [] Slide titles".
In that case even both could be exported (Slide 1 Title 1), some (Slide 1 or
Title 1) or none (no bookmarks).

Notes: Interesting to see Bug 95193. Help should be amended for all this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-qa] Minutes of the Design Hangout: 2017-May-18

[Heiko Tietze]

Present:  Jay, Heiko

 * Context menu for text boxes
   + https://bugs.documentfoundation.org/show_bug.cgi?id=107635
   + Context menu needs to get split into text box and shape first 
   + After that the request will be possible and be done (Jay)
   
 * Handling of empty text boxes
   + https://bugs.documentfoundation.org/show_bug.cgi?id=107825
   + Somehow related to 
https://bugs.documentfoundation.org/show_bug.cgi?id=107688
   + Having a border sounds good, similar behavior like known from frames 
 with view > text boundaries on/off
   + related: https://bugs.documentfoundation.org/show_bug.cgi?id=107687 & 
tdf#107825

 * Default page margins
   + https://bugs.documentfoundation.org/show_bug.cgi?id=87902
   + Run a survey with the questions

 #1 What should LibreOffice Writer's default page margin should be?
  ( ) Current default - 0.79"/2cm (all sides)
  ( ) 1.00"/2.54cm (all sides)
  ( ) 1.25"/3.175cm (left and right), 1.00"/2.54cm (top and bottom)
  ( ) other [cm/in]
  left: [ ] (numerical)
  right: [ ] (numerical)
  top: [ ] (numerical)
  bottom: [ ] (numerical)
 #2 Why do you prefer this page margin?
  [  ]
 #3 How often do you have to change the margins?
  ( ) Never or maybe once in a year
  ( ) Monthly
  ( ) Weekly
  ( ) Daily
  ( ) With almost every document
  ( ) Never, as I has set my preferred margins as default
 #4 Do you know how to set a new default page margin?
  ( ) yes
  ( ) no
 #5 Any recommendations to the margins?
  [  ]
 #6 What is your default page size?
  ( ) A4
  ( ) Letter
  ( ) Other
  [ ]
 #7 Are there any page sizes that should be added to the page format drop 
down?
  [  ]



signature.asc
Description: OpenPGP digital signature
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Minutes of the Design Hangout: 2017-May-18

[Heiko Tietze]

Present:  Jay, Heiko

 * Context menu for text boxes
   + https://bugs.documentfoundation.org/show_bug.cgi?id=107635
   + Context menu needs to get split into text box and shape first 
   + After that the request will be possible and be done (Jay)
   
 * Handling of empty text boxes
   + https://bugs.documentfoundation.org/show_bug.cgi?id=107825
   + Somehow related to 
https://bugs.documentfoundation.org/show_bug.cgi?id=107688
   + Having a border sounds good, similar behavior like known from frames 
 with view > text boundaries on/off
   + related: https://bugs.documentfoundation.org/show_bug.cgi?id=107687 & 
tdf#107825

 * Default page margins
   + https://bugs.documentfoundation.org/show_bug.cgi?id=87902
   + Run a survey with the questions

 #1 What should LibreOffice Writer's default page margin should be?
  ( ) Current default - 0.79"/2cm (all sides)
  ( ) 1.00"/2.54cm (all sides)
  ( ) 1.25"/3.175cm (left and right), 1.00"/2.54cm (top and bottom)
  ( ) other [cm/in]
  left: [ ] (numerical)
  right: [ ] (numerical)
  top: [ ] (numerical)
  bottom: [ ] (numerical)
 #2 Why do you prefer this page margin?
  [  ]
 #3 How often do you have to change the margins?
  ( ) Never or maybe once in a year
  ( ) Monthly
  ( ) Weekly
  ( ) Daily
  ( ) With almost every document
  ( ) Never, as I has set my preferred margins as default
 #4 Do you know how to set a new default page margin?
  ( ) yes
  ( ) no
 #5 Any recommendations to the margins?
  [  ]
 #6 What is your default page size?
  ( ) A4
  ( ) Letter
  ( ) Other
  [ ]
 #7 Are there any page sizes that should be added to the page format drop 
down?
  [  ]



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 107912] headless firstrun crashes (exit code 81)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107912

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #4 from Xisco Faulí  ---
yes, you need to use soffice without .bin. I don't know the technical reasons
why but I know there's one ;-)
Closing as RESOLVED NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62728] Support for PDF/A-2 (ISO 19005-2:2011)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62728

Paddy Landau  changed:

   What|Removed |Added

 CC||pa...@landau.ws

--- Comment #4 from Paddy Landau  ---
Further to this, PDF-3 came out in 2012. It would be ideal for LibreOffice to
support not only PDF-2 but also PDF-3.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107891] Resizing window resets zoom (Online)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107891

Pranav Kant  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/po

[Andras Timar]

 loleaflet/po/help-dsb.po   |  401 +++---
 loleaflet/po/help-hsb.po   |   18 
 loleaflet/po/help-kk.po|   40 -
 loleaflet/po/help-pa_IN.po |   58 +-
 loleaflet/po/ui-cs.po  |   22 
 loleaflet/po/ui-cy.po  |   52 -
 loleaflet/po/ui-da.po  |   27 
 loleaflet/po/ui-dsb.po | 1222 +++--
 loleaflet/po/ui-el.po  |8 
 loleaflet/po/ui-eo.po  |   12 
 loleaflet/po/ui-es.po  |   22 
 loleaflet/po/ui-eu.po  |   52 -
 loleaflet/po/ui-gl.po  |   13 
 loleaflet/po/ui-hsb.po | 1115 -
 loleaflet/po/ui-it.po  |6 
 loleaflet/po/ui-nn.po  |   52 -
 loleaflet/po/ui-sk.po  |   12 
 loleaflet/po/ui-tr.po  |   54 -
 loleaflet/po/ui-zh_CN.po   |  157 ++---
 19 files changed, 1692 insertions(+), 1651 deletions(-)

New commits:
commit 8cbcf9a41a4fbd60b35077d92b10c43edcacd450
Author: Andras Timar 
Date:   Thu May 18 14:37:49 2017 +0200

loleaflet: updated translations

Change-Id: Ic25539b5a5800f9f77ed81697a59bc40ce3fb6da

diff --git a/loleaflet/po/help-dsb.po b/loleaflet/po/help-dsb.po
index 02dfa7f8..d0ba6145 100644
--- a/loleaflet/po/help-dsb.po
+++ b/loleaflet/po/help-dsb.po
@@ -2,7 +2,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2017-04-24 18:10+\n"
+"POT-Creation-Date: 2017-05-16 08:00+\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME \n"
 "Language-Team: LANGUAGE \n"
@@ -12,268 +12,268 @@ msgstr ""
 "Content-Transfer-Encoding: 8bit\n"
 "X-Generator: Translate Toolkit 2.0.0\n"
 "X-Pootle-Path: /dsb/libo_online/loleaflet-help-dsb.po\n"
-"X-Pootle-Revision: 2514048\n"
+"X-Pootle-Revision: 2524299\n"
 
 #: dist%2Floleaflet-help.html+div.h1%3A25
 msgid "Keyboard Shortcuts"
-msgstr ""
+msgstr "Tastowe skrotconki"
 
 #: dist%2Floleaflet-help.html+div.div.h2%3A27
 msgid "General Keyboard Shortcuts"
-msgstr ""
+msgstr "Powšykne tastowe skrotconki"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A29
 msgid "Undo"
-msgstr ""
+msgstr "Anulěrowaś"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A29
 msgid "Ctrl + Z"
-msgstr ""
+msgstr "Strg + Z"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A30
 msgid "Redo"
-msgstr ""
+msgstr "Wóspjetowaś"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A30
 msgid "Ctrl + Y"
-msgstr ""
+msgstr "Strg + Y"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A31
 msgid "Cut"
-msgstr ""
+msgstr "Wurězaś"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A31
 msgid "Ctrl + X"
-msgstr ""
+msgstr "Strg + X"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A32
 msgid "Paste as unformatted text"
-msgstr ""
+msgstr "Ako njeformatěrowany tekst zasajźiś"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A32
 msgid "Ctrl + Alt + Shift + V"
-msgstr ""
+msgstr "Strg + Alt + Umsch + V"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A33
 msgid "Print (Download as PDF)"
-msgstr ""
+msgstr "Śišćaś (ako PDF ześěgnuś)"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A33
 msgid "Ctrl + P"
-msgstr ""
+msgstr "Strg + P"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A34
 msgid "Display the Keyboard shortcuts help"
-msgstr ""
+msgstr "Pomoc za tastowe skrotconki pokazaś"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A34
 msgid "Ctrl + Shift + ?"
-msgstr ""
+msgstr "Strg + Umsch + ?"
 
 #: dist%2Floleaflet-help.html+div.div.h2%3A38
 #: dist%2Floleaflet-help.html+div.div.h2%3A160
 msgid "Text formatting"
-msgstr ""
+msgstr "Tekstowe formatěrowanje"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A40
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A137
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A162
 msgid "Bold"
-msgstr ""
+msgstr "Tucny"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A40
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A137
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A162
 msgid "Ctrl + B"
-msgstr ""
+msgstr "Strg + B"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A41
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A138
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A163
 msgid "Italic"
-msgstr ""
+msgstr "Kursiwny"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A41
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A138
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A163
 msgid "Ctrl + I"
-msgstr ""
+msgstr "Strg + I"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A42
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A139
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A164
 msgid "Underline"
-msgstr ""
+msgstr "Pódšmarnuś"
 
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A42
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A139
 #: dist%2Floleaflet-help.html+div.div.table.tr.td%3A164
 msgid "Ctrl + U"
-msgstr ""

[Libreoffice-bugs] [Bug 107731] Default red font color and yellow highlight color no long in default color palette

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107731

--- Comment #4 from Heiko Tietze  ---
(In reply to Maxim Monastirsky from comment #3)
> http://opengrok.libreoffice.org/xref/core/svx/source/tbxctrls/tbxcolorupdate.
> cxx#41

Would opengrok.libreoffice.org/xref/core/include/tools/colordata.hxx be also
relevant for chart graphics? Talking about bug 106534.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97160] Linux: OpenGL causes applications to crash on launch

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97160

--- Comment #25 from codywohlers  ---
still happens on 5.3.3.2

soffice.bin: Couldn't find current GLX or EGL context.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97160] Linux: OpenGL causes applications to crash on launch

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97160

codywohlers  changed:

   What|Removed |Added

Version|5.1.0.2 rc  |5.3.3.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104520] [META] DOCX (OOXML) bug tracker

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104520
Bug 104520 depends on bug 100072, which changed state.

Bug 100072 Summary: FILEOPEN DOCX Horizontal lines misplaced
https://bugs.documentfoundation.org/show_bug.cgi?id=100072

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100072] FILEOPEN DOCX Horizontal lines misplaced

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100072

Vasily Melenchuk (CIB)  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #11 from Vasily Melenchuk (CIB)  ---
Another issue causing difference was fixed. Both shape lines are right now
corrent width and are in correct positions.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann]

 compilerplugins/clang/comparisonwithconstant.cxx |   13 -
 1 file changed, 13 deletions(-)

New commits:
commit 9b51d16771175b1245f755d28877fd61a0b432a1
Author: Stephan Bergmann 
Date:   Thu May 18 14:26:47 2017 +0200

Remove unnecessary restrictions

Change-Id: Idc0db273f7ad2d6b3752ca01a1f2a327e991

diff --git a/compilerplugins/clang/comparisonwithconstant.cxx 
b/compilerplugins/clang/comparisonwithconstant.cxx
index 1c7daf5c3c4f..180e45df3a5c 100644
--- a/compilerplugins/clang/comparisonwithconstant.cxx
+++ b/compilerplugins/clang/comparisonwithconstant.cxx
@@ -74,11 +74,6 @@ bool ComparisonWithConstant::VisitBinaryOperator(const 
BinaryOperator* binaryOp)
 if (!(binaryOp->getOpcode() == BO_EQ || binaryOp->getOpcode() == BO_NE)) {
 return true;
 }
-// ignore logging macros
-if 
(compiler.getSourceManager().isMacroBodyExpansion(binaryOp->getSourceRange().getBegin())
-|| 
compiler.getSourceManager().isMacroArgExpansion(binaryOp->getSourceRange().getBegin()))
 {
-return true;
-}
 // protect against clang assert
 if (binaryOp->getLHS()->isValueDependent() || 
binaryOp->getRHS()->isValueDependent()) {
 return true;
@@ -118,14 +113,6 @@ bool ComparisonWithConstant::rewrite(const BinaryOperator 
* binaryOp) {
 const std::string lhsString = getExprAsString(lhsRange);
 const std::string rhsString = getExprAsString(rhsRange);
 
-/* we can't safely move around stuff containing comments, we mess up the 
resulting code */
-if ( lhsString.find("/*") != std::string::npos || lhsString.find("//") != 
std::string::npos ) {
-return false;
-}
-if ( rhsString.find("/*") != std::string::npos || rhsString.find("//") != 
std::string::npos ) {
-return false;
-}
-
 // switch LHS and RHS
 if (!replaceText(lhsRange, rhsString)) {
 return false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann]

 compilerplugins/clang/comparisonwithconstant.cxx |   10 ++
 1 file changed, 10 insertions(+)

New commits:
commit a7551b34adf84de976fdaa3a3432448eea3b
Author: Stephan Bergmann 
Date:   Thu May 18 14:25:38 2017 +0200

Rewrite in macro arguments

Change-Id: I6ae619edac26fe06d1f86f139b7cf71ce31146d4

diff --git a/compilerplugins/clang/comparisonwithconstant.cxx 
b/compilerplugins/clang/comparisonwithconstant.cxx
index b55a73e05c17..1c7daf5c3c4f 100644
--- a/compilerplugins/clang/comparisonwithconstant.cxx
+++ b/compilerplugins/clang/comparisonwithconstant.cxx
@@ -150,6 +150,11 @@ std::string 
ComparisonWithConstant::getExprAsString(SourceRange range)
 }
 
 SourceRange ComparisonWithConstant::ignoreMacroExpansions(SourceRange range) {
+while (compiler.getSourceManager().isMacroArgExpansion(range.getBegin())) {
+range.setBegin(
+compiler.getSourceManager().getImmediateMacroCallerLoc(
+range.getBegin()));
+}
 if (range.getBegin().isMacroID()) {
 SourceLocation loc;
 if (Lexer::isAtStartOfMacroExpansion(
@@ -159,6 +164,11 @@ SourceRange 
ComparisonWithConstant::ignoreMacroExpansions(SourceRange range) {
 range.setBegin(loc);
 }
 }
+while (compiler.getSourceManager().isMacroArgExpansion(range.getEnd())) {
+range.setEnd(
+compiler.getSourceManager().getImmediateMacroCallerLoc(
+range.getEnd()));
+}
 if (range.getEnd().isMacroID()) {
 SourceLocation loc;
 if (Lexer::isAtEndOfMacroExpansion(
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann]

 compilerplugins/clang/comparisonwithconstant.cxx |   29 ++-
 1 file changed, 28 insertions(+), 1 deletion(-)

New commits:
commit 64e5915b7a2c07c740aae25a4a6d00a306e704e4
Author: Stephan Bergmann 
Date:   Thu May 18 14:21:58 2017 +0200

Avoid nested automatic rewrites

...which would come out garbled.  One place is

> bool bRet = SfxItemState::SET == pSet->GetItemState( i, 
rAttr.Which() != RES_TXTATR_AUTOFMT,  );

in SwAttrHandler::PushAndChg (sw/source/core/text/atrstck.cxx)

Change-Id: I1486313b25850dc59e10edb38b8bd28a30e6aa63

diff --git a/compilerplugins/clang/comparisonwithconstant.cxx 
b/compilerplugins/clang/comparisonwithconstant.cxx
index d200d8ec212d..b55a73e05c17 100644
--- a/compilerplugins/clang/comparisonwithconstant.cxx
+++ b/compilerplugins/clang/comparisonwithconstant.cxx
@@ -33,11 +33,37 @@ public:
 TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
 }
 
+// Deliberatley drop RecursiveASTVisitor::TraverseBinEQ's 
DataRecursionQueue
+// parameter; TraveseBinEQ must use stack instead of data recursion for any
+// children's VisitBinaryOperator to see changes to occurrence_ by a parent
+// VisitBinaryOperator:
+bool TraverseBinEQ(BinaryOperator * S)
+{
+auto const saved = occurrence_;
+auto const ret = RecursiveASTVisitor::TraverseBinEQ(S);
+occurrence_ = saved;
+return ret;
+}
+
+// Deliberatley drop RecursiveASTVisitor::TraverseBinNE's 
DataRecursionQueue
+// parameter; TraveseBinNE must use stack instead of data recursion for any
+// children's VisitBinaryOperator to see changes to occurrence_ by a parent
+// VisitBinaryOperator:
+bool TraverseBinNE(BinaryOperator * S)
+{
+auto const saved = occurrence_;
+auto const ret = RecursiveASTVisitor::TraverseBinNE(S);
+occurrence_ = saved;
+return ret;
+}
+
 bool VisitBinaryOperator(const BinaryOperator *);
 private:
 bool rewrite(const BinaryOperator *);
 std::string getExprAsString(SourceRange range);
 SourceRange ignoreMacroExpansions(SourceRange range);
+
+bool occurrence_ = false;
 };
 
 bool ComparisonWithConstant::VisitBinaryOperator(const BinaryOperator* 
binaryOp)
@@ -63,13 +89,14 @@ bool ComparisonWithConstant::VisitBinaryOperator(const 
BinaryOperator* binaryOp)
 if (binaryOp->getRHS()->isEvaluatable(compiler.getASTContext())) {
 return true;
 }
-if (!rewrite(binaryOp))
+if (occurrence_ || !rewrite(binaryOp))
 {
 report(
 DiagnosticsEngine::Warning, "Rather put constant on right when 
comparing",
 binaryOp->getSourceRange().getBegin())
 << binaryOp->getSourceRange();
 }
+occurrence_ = true;
 return true;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann]

 compilerplugins/clang/plugin.cxx |   26 ++
 compilerplugins/clang/plugin.hxx |1 +
 2 files changed, 27 insertions(+)

New commits:
commit 8584b7f57c87b111526d5cc75cc1c45646ebf278
Author: Stephan Bergmann 
Date:   Thu May 18 14:18:58 2017 +0200

Refuse to rewrite in workdir

...instead of merely getting a warning from 
PluginHandler::HandleTranslationUnit
after the fact.  Such automatic rewriting should probably never be what one
wants.

Change-Id: I3829007224a197ebb4d55d24323b375cbbdf815c

diff --git a/compilerplugins/clang/plugin.cxx b/compilerplugins/clang/plugin.cxx
index 9c308b1f8509..3ec612ef 100644
--- a/compilerplugins/clang/plugin.cxx
+++ b/compilerplugins/clang/plugin.cxx
@@ -274,6 +274,8 @@ RewritePlugin::RewritePlugin( const InstantiationData& data 
)
 bool RewritePlugin::insertText( SourceLocation Loc, StringRef Str, bool 
InsertAfter, bool indentNewLines )
 {
 assert( rewriter );
+if (wouldRewriteWorkdir(Loc))
+return false;
 if( rewriter->InsertText( Loc, Str, InsertAfter, indentNewLines ))
 return reportEditFailure( Loc );
 return true;
@@ -282,6 +284,8 @@ bool RewritePlugin::insertText( SourceLocation Loc, 
StringRef Str, bool InsertAf
 bool RewritePlugin::insertTextAfter( SourceLocation Loc, StringRef Str )
 {
 assert( rewriter );
+if (wouldRewriteWorkdir(Loc))
+return false;
 if( rewriter->InsertTextAfter( Loc, Str ))
 return reportEditFailure( Loc );
 return true;
@@ -290,6 +294,8 @@ bool RewritePlugin::insertTextAfter( SourceLocation Loc, 
StringRef Str )
 bool RewritePlugin::insertTextAfterToken( SourceLocation Loc, StringRef Str )
 {
 assert( rewriter );
+if (wouldRewriteWorkdir(Loc))
+return false;
 if( rewriter->InsertTextAfterToken( Loc, Str ))
 return reportEditFailure( Loc );
 return true;
@@ -298,6 +304,8 @@ bool RewritePlugin::insertTextAfterToken( SourceLocation 
Loc, StringRef Str )
 bool RewritePlugin::insertTextBefore( SourceLocation Loc, StringRef Str )
 {
 assert( rewriter );
+if (wouldRewriteWorkdir(Loc))
+return false;
 if( rewriter->InsertTextBefore( Loc, Str ))
 return reportEditFailure( Loc );
 return true;
@@ -317,6 +325,8 @@ bool RewritePlugin::removeText( SourceRange range, 
RewriteOptions opts )
 bool RewritePlugin::removeText( CharSourceRange range, RewriteOptions opts )
 {
 assert( rewriter );
+if (wouldRewriteWorkdir(range.getBegin()))
+return false;
 if( rewriter->getRangeSize( range, opts ) == -1 )
 return reportEditFailure( range.getBegin());
 if( !handler.addRemoval( range.getBegin() ) )
@@ -378,6 +388,8 @@ bool RewritePlugin::adjustRangeForOptions( CharSourceRange* 
range, RewriteOption
 bool RewritePlugin::replaceText( SourceLocation Start, unsigned OrigLength, 
StringRef NewStr )
 {
 assert( rewriter );
+if (wouldRewriteWorkdir(Start))
+return false;
 if( OrigLength != 0 && !handler.addRemoval( Start ) )
 {
 report( DiagnosticsEngine::Warning, "double code replacement, possible 
plugin error", Start );
@@ -391,6 +403,8 @@ bool RewritePlugin::replaceText( SourceLocation Start, 
unsigned OrigLength, Stri
 bool RewritePlugin::replaceText( SourceRange range, StringRef NewStr )
 {
 assert( rewriter );
+if (wouldRewriteWorkdir(range.getBegin()))
+return false;
 if( rewriter->getRangeSize( range ) == -1 )
 return reportEditFailure( range.getBegin());
 if( !handler.addRemoval( range.getBegin() ) )
@@ -406,6 +420,8 @@ bool RewritePlugin::replaceText( SourceRange range, 
StringRef NewStr )
 bool RewritePlugin::replaceText( SourceRange range, SourceRange 
replacementRange )
 {
 assert( rewriter );
+if (wouldRewriteWorkdir(range.getBegin()))
+return false;
 if( rewriter->getRangeSize( range ) == -1 )
 return reportEditFailure( range.getBegin());
 if( !handler.addRemoval( range.getBegin() ) )
@@ -418,6 +434,16 @@ bool RewritePlugin::replaceText( SourceRange range, 
SourceRange replacementRange
 return true;
 }
 
+bool RewritePlugin::wouldRewriteWorkdir(SourceLocation loc) {
+if (loc.isInvalid() || loc.isMacroID()) {
+return false;
+}
+return
+compiler.getSourceManager().getFilename(
+compiler.getSourceManager().getSpellingLoc(loc))
+.startswith(WORKDIR "/");
+}
+
 bool RewritePlugin::reportEditFailure( SourceLocation loc )
 {
 report( DiagnosticsEngine::Warning, "cannot perform source modification 
(macro expansion involved?)", loc );
diff --git a/compilerplugins/clang/plugin.hxx b/compilerplugins/clang/plugin.hxx
index 7bb79598e854..413b2ab7cefb 100644
--- a/compilerplugins/clang/plugin.hxx
+++ b/compilerplugins/clang/plugin.hxx
@@ -141,6 +141,7 @@ class RewritePlugin
 private:
 template< typename T > friend class 

[Libreoffice-bugs] [Bug 100072] FILEOPEN DOCX Horizontal lines misplaced

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100072

--- Comment #10 from Commit Notification 
 ---
Vasily Melenchuk committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5477f7274e4df1210298c0f503a54eabc0f06bfc

tdf#100072 zero height of shape's path was causing geometry errors

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88774] Feature request: simpler possibility to add text at the background of a page, as a watermark

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88774

--- Comment #15 from Yan Pas  ---
Great news! Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 88774] Feature request: simpler possibility to add text at the background of a page, as a watermark

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88774

--- Comment #15 from Yan Pas  ---
Great news! Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] online.git: Changes to 'refs/tags/libreoffice-5-4-branch-point'

[Aditya Dewan]

Tag 'libreoffice-5-4-branch-point' created by Andras Timar 
 at 2017-05-18 12:15 +

libreoffice-5-4-branch-point

Changes since collabora-online-2-1-branch-point-356:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svx/source sw/qa

[Vasily Melenchuk]

 svx/source/customshapes/EnhancedCustomShape2d.cxx |   17 +++-
 sw/qa/extras/ooxmlexport/ooxmlexport9.cxx |9 
 sw/qa/extras/ooxmlimport/ooxmlimport.cxx  |   45 ++
 3 files changed, 60 insertions(+), 11 deletions(-)

New commits:
commit 5477f7274e4df1210298c0f503a54eabc0f06bfc
Author: Vasily Melenchuk 
Date:   Mon May 15 13:41:14 2017 +0300

tdf#100072 zero height of shape's path was causing geometry errors

DOCX custom geometry shape's path width and height are now used
independently for scaling calculations.

Change-Id: I368dd4dc065b8f122c4eb2911261e45047f03c70
Reviewed-on: https://gerrit.libreoffice.org/37639
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/svx/source/customshapes/EnhancedCustomShape2d.cxx 
b/svx/source/customshapes/EnhancedCustomShape2d.cxx
index c3c2d4c33099..c4de12bbcfc3 100644
--- a/svx/source/customshapes/EnhancedCustomShape2d.cxx
+++ b/svx/source/customshapes/EnhancedCustomShape2d.cxx
@@ -651,10 +651,23 @@ void EnhancedCustomShape2d::SetPathSize( sal_Int32 nIndex 
)
 "svx",
 "ooxml shape, path width: " << nCoordWidth << " height: "
 << nCoordHeight);
+
+// Try to set up scale separately, if given only width or height
+// This is possible case in OOXML when only width or height is non-zero
 if ( nCoordWidth == 0 )
-fXScale = 1.0;
+{
+if ( nWidth )
+fXScale = (double)aLogicRect.GetWidth() / (double)nWidth;
+else
+fXScale = 1.0;
+}
 if ( nCoordHeight == 0 )
-fYScale = 1.0;
+{
+if ( nHeight )
+fYScale = (double)aLogicRect.GetHeight() / (double)nHeight;
+else
+fYScale = 1.0;
+}
 }
 if ( (sal_uInt32)nXRef != 0x8000 && aLogicRect.GetHeight() )
 {
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
index ce8a77a02c8c..2aff1fb23ed1 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
@@ -490,15 +490,6 @@ DECLARE_OOXMLEXPORT_TEST(testTdf107033, "tdf107033.docx")
 CPPUNIT_ASSERT_EQUAL(static_cast(25), 
getProperty(xPageStyle, "FootnoteLineRelativeWidth"));
 }
 
-DECLARE_OOXMLEXPORT_TEST(testTdf100072, "tdf100072.docx")
-{
-// Ensure that shape has non-zero height
-CPPUNIT_ASSERT(getShape(1)->getSize().Height > 0);
-
-// Ensure that shape left corner is within page (positive)
-CPPUNIT_ASSERT(getShape(1)->getPosition().X > 0);
-}
-
 DECLARE_OOXMLEXPORT_TEST(testTdf107889, "tdf107889.docx")
 {
 uno::Reference xDrawPageSupplier(mxComponent, 
uno::UNO_QUERY);
diff --git a/sw/qa/extras/ooxmlexport/data/tdf100072.docx 
b/sw/qa/extras/ooxmlimport/data/tdf100072.docx
similarity index 100%
rename from sw/qa/extras/ooxmlexport/data/tdf100072.docx
rename to sw/qa/extras/ooxmlimport/data/tdf100072.docx
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index 87ccce61d9b5..90e36f1ef593 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -24,6 +24,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -59,6 +60,7 @@
 #include 
 #include 
 #include 
+#include 
 
 class Test : public SwModelTestBase
 {
@@ -1306,6 +1308,49 @@ DECLARE_OOXMLIMPORT_TEST(testTdf101627, "tdf101627.docx")
 CPPUNIT_ASSERT_EQUAL(sal_Int32(466), getProperty(xFrame, 
"Height"));
 }
 
+DECLARE_OOXMLIMPORT_TEST(testTdf100072, "tdf100072.docx")
+{
+uno::Reference xShape = getShape(1);
+
+// Ensure that shape has non-zero height
+CPPUNIT_ASSERT(xShape->getSize().Height > 0);
+
+// Ensure that shape left corner is within page (positive)
+CPPUNIT_ASSERT(xShape->getPosition().X > 0);
+
+// Save the first shape to a metafile.
+uno::Reference xGraphicExporter = 
drawing::GraphicExportFilter::create(comphelper::getProcessComponentContext());
+uno::Reference xSourceDoc(xShape, uno::UNO_QUERY);
+xGraphicExporter->setSourceDocument(xSourceDoc);
+
+SvMemoryStream aStream;
+uno::Reference xOutputStream(new 
utl::OStreamWrapper(aStream));
+uno::Sequence aDescriptor =
+{
+beans::PropertyValue("OutputStream", sal_Int32(0), 
uno::makeAny(xOutputStream), beans::PropertyState_DIRECT_VALUE),
+beans::PropertyValue("FilterName", sal_Int32(0), 
uno::makeAny(OUString("SVM")), beans::PropertyState_DIRECT_VALUE)
+};
+xGraphicExporter->filter(aDescriptor);
+aStream.Seek(STREAM_SEEK_TO_BEGIN);
+
+// Read it back and dump it as an XML file.
+Graphic aGraphic;
+ReadGraphic(aStream, aGraphic);
+const GDIMetaFile& rMetaFile = aGraphic.GetGDIMetaFile();
+MetafileXmlDump dumper;
+xmlDocPtr pXmlDoc = 

[Libreoffice-commits] online.git: Changes to 'libreoffice-5-4'

[Aditya Dewan]

New branch 'libreoffice-5-4' available with the following commits:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dev-tools.git: esc-reporting/esc-collect.py

[jan Iversen]

 esc-reporting/esc-collect.py |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit e40973cc6231177fdae510ee3056969fe8c47fec
Author: jan Iversen 
Date:   Thu May 18 14:08:30 2017 +0200

esc-report, corrected searchdata in bugzilla collect

diff --git a/esc-reporting/esc-collect.py b/esc-reporting/esc-collect.py
index af44973..5c77d6a 100755
--- a/esc-reporting/esc-collect.py
+++ b/esc-reporting/esc-collect.py
@@ -141,9 +141,9 @@ def get_bugzilla(cfg):
 searchDate, rawList = util_load_data_file(cfg, fileName, 'bugzilla', 
{'bugs': {}})
 print("Updating bugzilla dump from " + rawList['newest-entry'])
 
-searchDate - datetime.timedelta(days=1)
+searchData = searchDate - datetime.timedelta(days=2)
 url = 'https://bugs.documentfoundation.org/rest/bug?' \
-  
'f2=delta_ts=greaterthaneq_format=advanced=---=' + 
searchDate.strftime("%Y-%m-%d") + \
+  'f2=delta_ts=greaterthaneq_format=advanced=' + 
searchDate.strftime("%Y-%m-%d") + \
   '=200='
 newList = []
 while True:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 95193] Wrong bookmarks in Impress PDF export with notes pages, notes not bookmarked but slides bookmarks doubled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95193

Timur  changed:

   What|Removed |Added

Version|3.5.0 release   |Inherited From OOo
Summary|Wrong bookmarks in impress  |Wrong bookmarks in Impress
   |pdf export with notes pages |PDF export with notes
   ||pages, notes not bookmarked
   ||but slides bookmarks
   ||doubled

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107797] Autofilter dropdown behaves strangely when it' s created by a macro in a specific XLSM

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107797

Szymon Kłos  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |szymon.k...@collabora.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107912] headless firstrun crashes (exit code 81)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107912

--- Comment #3 from d...@pre-sense.de ---
Reproduced with the following systems:

http://dev-builds.libreoffice.org/daily/master/Linux-rpm_deb-x86_64@70-TDF/2017-05-17_23.34.19/master~2017-05-17_23.34.19_LibreOfficeDev_5.4.0.0.alpha1_Linux_x86-64_rpm.tar.gz
on openSUSE 42.2

http://download.opensuse.org/tumbleweed/iso/openSUSE-Tumbleweed-KDE-Live-x86_64-Current.iso
(has LibreOffice 5.3.2.2)
Run livecd (I used Qemu/KVM) and do:
$ sudo zypper in libreoffice-writer
[...]
$ /usr/lib64/libreoffice/program/soffice.bin --headless
$ echo $?
81

ftp://mirror.23media.de/ubuntu-releases/17.04/ubuntu-17.04-desktop-amd64.iso
Run livecd (I used Qemu/KVM) and do:
$ /usr/lib/libreoffice/program/soffice.bin --headless
$ echo $?
81

--

But I think I finally got the reason for this.

The bug only happends when calling ".../program/soffice.bin"

When calling ".../program/soffice" everything's fine.

I guess this is intended behavior!?
If yes, feel free to close / set to invalid.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - sw/source

[Jan Holesovsky]

 sw/source/core/inc/rootfrm.hxx|3 +++
 sw/source/core/layout/newfrm.cxx  |2 +-
 sw/source/core/layout/pagechg.cxx |6 ++
 3 files changed, 6 insertions(+), 5 deletions(-)

New commits:
commit fe579905acc511b98aeae370528e87810c9cd9d1
Author: Jan Holesovsky 
Date:   Thu May 18 13:25:31 2017 +0200

sw lok: Make the default for the Web view larger.

Change-Id: I943711e084adcfa0af2a79cf83d5c3e1b6dc45e6
Reviewed-on: https://gerrit.libreoffice.org/37759
Reviewed-by: Miklos Vajna 
Tested-by: Jan Holesovsky 

diff --git a/sw/source/core/inc/rootfrm.hxx b/sw/source/core/inc/rootfrm.hxx
index f67665eafbb7..e784efd9d51d 100644
--- a/sw/source/core/inc/rootfrm.hxx
+++ b/sw/source/core/inc/rootfrm.hxx
@@ -96,6 +96,9 @@ class SwRootFrame: public SwLayoutFrame
 static bool   s_isInPaint; // Protection against double Paints
 static bool   s_isNoVirDev;// No virt. Device for SystemPaints
 
+/// Width of the HTML / Web document if not defined otherwise: 20cm.
+static const sal_Int64 MIN_BROWSE_WIDTH = 20 * 2 * MM50;
+
 boolmbCheckSuperfluous   :1; // Search for empty Pages?
 boolmbIdleFormat :1; // Trigger Idle Formatter?
 boolmbBrowseWidthValid   :1; // Is mnBrowseWidth valid?
diff --git a/sw/source/core/layout/newfrm.cxx b/sw/source/core/layout/newfrm.cxx
index e1a96cd25ac1..b5785c4b0330 100644
--- a/sw/source/core/layout/newfrm.cxx
+++ b/sw/source/core/layout/newfrm.cxx
@@ -464,7 +464,7 @@ SwRootFrame::SwRootFrame( SwFrameFormat *pFormat, 
SwViewShell * pSh ) :
 mbIsNewLayout( true ),
 mbCallbackActionEnabled ( false ),
 mbLayoutFreezed ( false ),
-mnBrowseWidth( MM50*4 ), //2cm minimum
+mnBrowseWidth(MIN_BROWSE_WIDTH),
 mpTurbo( nullptr ),
 mpLastPage( nullptr ),
 mpCurrShell( pSh ),
diff --git a/sw/source/core/layout/pagechg.cxx 
b/sw/source/core/layout/pagechg.cxx
index ef167d34cf99..bafe1a96d7d1 100644
--- a/sw/source/core/layout/pagechg.cxx
+++ b/sw/source/core/layout/pagechg.cxx
@@ -1603,10 +1603,8 @@ void SwRootFrame::ImplCalcBrowseWidth()
 
 mbBrowseWidthValid = true;
 SwViewShell *pSh = getRootFrame()->GetCurrShell();
-mnBrowseWidth = pSh
-? MINLAY + 2 * pSh->GetOut()->
-PixelToLogic( pSh->GetBrowseBorder() ).Width()
-: 5000;
+mnBrowseWidth = (!comphelper::LibreOfficeKit::isActive() && pSh)? MINLAY + 
2 * pSh->GetOut()-> PixelToLogic( pSh->GetBrowseBorder() ).Width(): 
MIN_BROWSE_WIDTH;
+
 do
 {
 if ( pFrame->IsInTab() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105605

Cor Nouws  changed:

   What|Removed |Added

 Depends on||106454

--- Comment #1 from Cor Nouws  ---
adding Bug 106454 - Digital signatures from PINPAD readers


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106454
[Bug 106454] Digital signatures from PINPAD readers
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106454] Digital signatures from PINPAD readers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106454

Cor Nouws  changed:

   What|Removed |Added

 Blocks||105605


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105605
[Bug 105605] [META] Digital signatures bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 88774] Feature request: simpler possibility to add text at the background of a page, as a watermark

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88774

--- Comment #14 from Szymon Kłos  ---
This is not finished yet, I will extend Watermark dialog. It will be possible
to change font etc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise