[Libreoffice-bugs] [Bug 76104] VBA: set font color in cell
https://bugs.documentfoundation.org/show_bug.cgi?id=76104 --- Comment #6 from Laube Roman--- version 5.4.0.1 - this bug is still present. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96679] Add "create a character style & assign short cut" button to dialog format Character, tab Font Effects
https://bugs.documentfoundation.org/show_bug.cgi?id=96679 Thomas Lendochanged: What|Removed |Added Blocks||108734 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108734 [Bug 108734] [META] Character dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108734] [META] Character dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108734 Thomas Lendochanged: What|Removed |Added Depends on||96679 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=96679 [Bug 96679] Add "create a character style & assign short cut" button to dialog format Character, tab Font Effects -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75769] FORMATTING: Adding a feature to format images in detail in order the user to be able to cut an image to the user 's desired size and formatting.
https://bugs.documentfoundation.org/show_bug.cgi?id=75769 Thomas Lendochanged: What|Removed |Added Blocks||103270 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103270 [Bug 103270] [META] Image/Picture dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103270] [META] Image/Picture dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103270 Thomas Lendochanged: What|Removed |Added Depends on||75769 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=75769 [Bug 75769] FORMATTING: Adding a feature to format images in detail in order the user to be able to cut an image to the user's desired size and formatting. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107794] DDE-links do not work anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=107794 tommy27changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from tommy27 --- thanks for confirmation. status -> RESOLVED WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33684] autocompletion does not longer work by pressing TAB
https://bugs.documentfoundation.org/show_bug.cgi?id=33684 tommy27changed: What|Removed |Added CC||ba...@quipo.it --- Comment #36 from tommy27 --- (In reply to Kohei Yoshida from comment #14) > Unfortunately the normal shortcut key scheme doesn't apply in this case, > because these key inputs are handled as direct key input i.e. like typing > 'a', 'b', 'c, etc into a cell, and you can't assign a shortcut key to direct > key inputs. > > Of course it's not impossible to make this configurable, but it may create > more problems and makes the code less maintainable (the code that handles > direct key inputs is very fragile). And quite frankly I don't know if it's > worth the risk. it seems that this bug qualifies for a WONTFIX status. as Kohei said, a fix would probably create more serious side effects and would not be worth it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108848] support for hancom hanword (.hwp) file
https://bugs.documentfoundation.org/show_bug.cgi?id=108848 --- Comment #1 from krishna [:kr1shna]--- Created attachment 134371 --> https://bugs.documentfoundation.org/attachment.cgi?id=134371=edit .hwp file sample -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108713] Autosave document returns to beginning of document
https://bugs.documentfoundation.org/show_bug.cgi?id=108713 --- Comment #10 from Aron Budea--- (In reply to Ruudsch Ma' Hinda from comment #9) > This can easily be tested by opening a document and not do anything for > about two and a half minutes. Make sure to not even scroll or change window > focus. > > Just place the cursor somewhere in the document and after that time it jumps > back to absolute home position. The original report was about autosave, while in your case I see no reference to editing the document at all. I have the same experience as Pranav, the cursor stays in place. It would be interesting to see the logs. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108848] New: support for hancom hanword (.hwp) file
https://bugs.documentfoundation.org/show_bug.cgi?id=108848 Bug ID: 108848 Summary: support for hancom hanword (.hwp) file Product: LibreOffice Version: unspecified Hardware: ARM OS: Android Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Android Viewer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: qual...@hacari.net Description: .hwp files are not listing in file browser and cannot open or read the file. Steps to Reproduce: libreoffice viewer does not: [1] list .hwp files in file browser [2] cannot read .hwp file. please look into the above. Actual Results: Expected Results: Reproducible: Always User Profile Reset: No Additional Info: Version: 6.0.0.0.alpha0+Build ID: 643da8ec4e721d33dfdf8d78bedd50a915f1188d TinderBox: Android-ARM@24-Bytemark-Hosting, Branch: Master, Time: June 26, 2017 01:29:17 User-Agent: Mozilla/5.0 (Android 5.1; Mobile; rv:54.0) Gecko/54.0 Firefox/54.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108847] support for adobe flash (.swf) file
https://bugs.documentfoundation.org/show_bug.cgi?id=108847 --- Comment #1 from krishna [:kr1shna]--- Created attachment 134370 --> https://bugs.documentfoundation.org/attachment.cgi?id=134370=edit .swf file ssmple -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108847] New: support for adobe flash (.swf) file
https://bugs.documentfoundation.org/show_bug.cgi?id=108847 Bug ID: 108847 Summary: support for adobe flash (.swf) file Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Android Viewer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: qual...@hacari.net Description: .swf files are not listing in file browser and cannot open or read the file. Steps to Reproduce: libreoffice viewer does not: [1] list .swf files in file browser [2] cannot read .swf file. please look into the above. Actual Results: Expected Results: Reproducible: Always User Profile Reset: No Additional Info: Version: 6.0.0.0.alpha0+Build ID: 643da8ec4e721d33dfdf8d78bedd50a915f1188dTinderBox: Android-ARM@24-Bytemark-Hosting, Branch: Master, Time: June 26, 2017 01:29:17 User-Agent: Mozilla/5.0 (Android 5.1; Mobile; rv:54.0) Gecko/54.0 Firefox/54.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/sax sc/source xmloff/source
include/sax/fastattribs.hxx | 17 +++-- sc/source/filter/xml/xmlbodyi.cxx|7 +++ sc/source/filter/xml/xmlcelli.cxx|7 +++ sc/source/filter/xml/xmlexternaltabi.cxx |6 +++--- sc/source/filter/xml/xmlrowi.cxx |7 +++ sc/source/filter/xml/xmltabi.cxx |7 +++ xmloff/source/core/xmlictxt.cxx | 14 +- 7 files changed, 31 insertions(+), 34 deletions(-) New commits: commit d6da9e495d7ca32de6cda1a94cb4c8cd26b240cc Author: Mohammed Abdul AzeemDate: Wed Jun 28 21:45:39 2017 +0530 Using range-for instead of iterator loop: It's much easier to write and looks cleaner. And this doesn't affect performance, I think. Change-Id: Ia946b068979b9cef04ac2479c9179a70b6775dea Reviewed-on: https://gerrit.libreoffice.org/39370 Tested-by: Jenkins Reviewed-by: Mohammed Abdul Azeem diff --git a/include/sax/fastattribs.hxx b/include/sax/fastattribs.hxx index 958899015372..70ddc4c8bb85 100644 --- a/include/sax/fastattribs.hxx +++ b/include/sax/fastattribs.hxx @@ -123,22 +123,27 @@ public: return mnIdx != rhs.mnIdx; } -sal_Int32 getToken() +const FastAttributeIter& operator*() const +{ +return *this; +} + +sal_Int32 getToken() const { assert(mnIdx < mrList.maAttributeTokens.size()); return mrList.maAttributeTokens[mnIdx]; } -bool isEmpty() +bool isEmpty() const { assert(mnIdx < mrList.maAttributeTokens.size()); return mrList.AttributeValueLength(mnIdx) < 1; } -sal_Int32 toInt32() +sal_Int32 toInt32() const { assert(mnIdx < mrList.maAttributeTokens.size()); return rtl_str_toInt32(mrList.getFastAttributeValue(mnIdx), 10); } -OUString toString() +OUString toString() const { assert(mnIdx < mrList.maAttributeTokens.size()); return OUString(mrList.getFastAttributeValue(mnIdx), @@ -146,12 +151,12 @@ public: RTL_TEXTENCODING_UTF8); } -const char* toCString() +const char* toCString() const { assert(mnIdx < mrList.maAttributeTokens.size()); return mrList.getFastAttributeValue(mnIdx); } -bool isString(const char *str) +bool isString(const char *str) const { assert(mnIdx < mrList.maAttributeTokens.size()); return !strcmp(str, mrList.getFastAttributeValue(mnIdx)); diff --git a/sc/source/filter/xml/xmlbodyi.cxx b/sc/source/filter/xml/xmlbodyi.cxx index 2a21d52899f9..4aec839b76e7 100644 --- a/sc/source/filter/xml/xmlbodyi.cxx +++ b/sc/source/filter/xml/xmlbodyi.cxx @@ -92,11 +92,10 @@ ScXMLBodyContext::ScXMLBodyContext( ScXMLImport& rImport, if( !xAttrList.is() ) return; -sax_fastparser::FastAttributeList *pAttribList; -assert( dynamic_cast< sax_fastparser::FastAttributeList *>( xAttrList.get() ) != nullptr ); -pAttribList = static_cast< sax_fastparser::FastAttributeList *>( xAttrList.get() ); +sax_fastparser::FastAttributeList *pAttribList = +static_cast< sax_fastparser::FastAttributeList *>( xAttrList.get() ); -for ( auto it = pAttribList->begin(); it != pAttribList->end(); ++it) +for( auto : *pAttribList ) { sal_Int32 nToken = it.getToken(); if( NAMESPACE_TOKEN( XML_NAMESPACE_TABLE ) == ( nToken & NMSP_MASK ) ) diff --git a/sc/source/filter/xml/xmlcelli.cxx b/sc/source/filter/xml/xmlcelli.cxx index 0de5664fcba2..d7e9f3107b75 100644 --- a/sc/source/filter/xml/xmlcelli.cxx +++ b/sc/source/filter/xml/xmlcelli.cxx @@ -159,11 +159,10 @@ ScXMLTableRowCellContext::ScXMLTableRowCellContext( ScXMLImport& rImport, std::unique_ptr xCurrencySymbol; if( xAttrList.is() ) { -sax_fastparser::FastAttributeList *pAttribList; -assert( dynamic_cast< sax_fastparser::FastAttributeList *>( xAttrList.get() ) != nullptr ); -pAttribList = static_cast< sax_fastparser::FastAttributeList *>( xAttrList.get() ); +sax_fastparser::FastAttributeList *pAttribList = +static_cast< sax_fastparser::FastAttributeList *>( xAttrList.get() ); -for ( auto it = pAttribList->begin(); it != pAttribList->end(); ++it) +for( auto : *pAttribList ) { switch ( it.getToken() ) { diff --git a/sc/source/filter/xml/xmlexternaltabi.cxx b/sc/source/filter/xml/xmlexternaltabi.cxx index e8c0ef5db247..e6edaa66461b 100644 --- a/sc/source/filter/xml/xmlexternaltabi.cxx +++ b/sc/source/filter/xml/xmlexternaltabi.cxx @@ -54,7 +54,7 @@ ScXMLExternalRefTabSourceContext::ScXMLExternalRefTabSourceContext( { sax_fastparser::FastAttributeList
[Libreoffice-bugs] [Bug 107051] WOPI Error if german umlaute in domain
https://bugs.documentfoundation.org/show_bug.cgi?id=107051 Aron Budeachanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||ba...@caesar.elte.hu Ever confirmed|0 |1 --- Comment #1 from Aron Budea --- I'm afraid I won't be able to reproduce this, but I can guess punycode encoding is missing. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105498] loolkit several file exists error while linking to child-roots
https://bugs.documentfoundation.org/show_bug.cgi?id=105498 Aron Budeachanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #5 from Aron Budea --- Does this still occur with a current version? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100819] Can't save my file
https://bugs.documentfoundation.org/show_bug.cgi?id=100819 Aron Budeachanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #29 from Aron Budea --- That's good to hear. Feel free to set the status to RESOLVED / WORKSFORME in such case. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/dmapper/StyleSheetTable.cxx | 34 +++- 1 file changed, 22 insertions(+), 12 deletions(-) New commits: commit 803a17533f25d9174c6a19aa913a6713980c193d Author: Justin LuthDate: Thu Jun 22 17:53:00 2017 -0400 revert related tdf#82173 writerfilter: ignore case when mapping styles and added the missing lowercase "footnote reference" mapping. Word can create both Heading1 and heading1 styles in the same document. So case CAN be important. Unfortunately, these mappings precede git history, so it will require trial and error to judge which mappings are obsolete or simply invalid. At least one of the existing mappings was not really correct anyway (Endnote Text"->"Endnote Symbol") so reverting the change to prevent other unanticipated regressions. Change-Id: Ia8669c975debcb3074e758b42c24fb65233f8369 Reviewed-on: https://gerrit.libreoffice.org/39132 Reviewed-by: Justin Luth Tested-by: Justin Luth diff --git a/writerfilter/source/dmapper/StyleSheetTable.cxx b/writerfilter/source/dmapper/StyleSheetTable.cxx index 699f605a52a6..27e0ade07925 100644 --- a/writerfilter/source/dmapper/StyleSheetTable.cxx +++ b/writerfilter/source/dmapper/StyleSheetTable.cxx @@ -46,22 +46,11 @@ using namespace ::com::sun::star; -namespace { - -/** Functor for case-insensitive string comparison, usable in maps etc. */ -struct IgnoreCaseCompare -{ -bool operator()( const OUString& rName1, const OUString& rName2 ) const -{ return rName1.compareToIgnoreAsciiCase( rName2 ) < 0; } -}; - -} // namespace - namespace writerfilter { namespace dmapper { -typedef ::std::map< OUString, OUString, IgnoreCaseCompare> StringPairMap_t; +typedef ::std::map< OUString, OUString> StringPairMap_t; StyleSheetEntry::StyleSheetEntry() : @@ -1302,6 +1291,15 @@ const StyleSheetEntryPtr StyleSheetTable::FindParentStyleSheet(const OUString& _ static const sal_Char* const aStyleNamePairs[] = { "Normal", "Standard", +"heading 1", "Heading 1", +"heading 2", "Heading 2", +"heading 3", "Heading 3", +"heading 4", "Heading 4", +"heading 5", "Heading 5", +"heading 6", "Heading 6", +"heading 7", "Heading 7", +"heading 8", "Heading 8", +"heading 9", "Heading 9", "Heading1", "Heading 1", "Heading2", "Heading 2", "Heading3", "Heading 3", @@ -1339,6 +1337,15 @@ static const sal_Char* const aStyleNamePairs[] = "TOC 8", "Contents 8", "TOC 9", "Contents 9", "TOCHeading","Contents Heading", +"toc 1", "Contents 1", +"toc 2", "Contents 2", +"toc 3", "Contents 3", +"toc 4", "Contents 4", +"toc 5", "Contents 5", +"toc 6", "Contents 6", +"toc 7", "Contents 7", +"toc 8", "Contents 8", +"toc 9", "Contents 9", "TOC1", "Contents 1", "TOC2", "Contents 2", "TOC3", "Contents 3", @@ -1352,12 +1359,15 @@ static const sal_Char* const aStyleNamePairs[] = "Footnote Text", "Footnote", "Annotation Text", "", "Header","Header", +"header","Header", "Footer","Footer", +"footer","Footer", "Index Heading", "Index Heading", "Caption", "", "Table of Figures", "", "Envelope Address", "Addressee", "Envelope Return", "Sender", +"footnote reference","Footnote Characters", "Footnote Reference","Footnote Characters", "Annotation Reference", "", "Line Number", "Line numbering", ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 36747] Relationally link Save As formats and Default File Formats lists
https://bugs.documentfoundation.org/show_bug.cgi?id=36747 --- Comment #22 from Xisco Faulí--- A polite ping, still working on this bug -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 108666] Template manager does not refresh
https://bugs.documentfoundation.org/show_bug.cgi?id=108666 --- Comment #3 from Kenneth Hanson--- BTW, I was looking to see if there was an AppImage and found this: http://libreoffice.soluzioniopen.com/index.php/pre-releases Which is great! But it really needs to be on the main LO site. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108666] Template manager does not refresh
https://bugs.documentfoundation.org/show_bug.cgi?id=108666 --- Comment #2 from Kenneth Hanson--- Actually, I just discovered something. There's a separate oddity with LO 5.3 and earlier, which is that the "title" metadata of a template, which seems to be automatically generated from the filename, becomes the title of documents produced from that template. Noticing that this hadn't changed, I went and deleted the metadata from the template. Thereafter, the updated name was reflected in the template manager and quick start menu. Based on this, I suspect one of two things might have changed in the new version: 1. the template manager is no giving the title metadata priority over the filename 2. the title metadata is no longer being generated automatically At the very least, we should confirm which it is. I'll download the dev version once I'm on a better internet connection. Then I can check, unless someone beats me to it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100819] Can't save my file
https://bugs.documentfoundation.org/show_bug.cgi?id=100819 --- Comment #28 from Mark--- I have version 5.3.3.2 and the problem has gone away. Thanks for your help, but you can close this now. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108691] Hidden shape in imported XLSX shown in Print window and printed
https://bugs.documentfoundation.org/show_bug.cgi?id=108691 Aron Budeachanged: What|Removed |Added Attachment #134369|Sample with combination of |Samples with combinations description|hidden/not printed settings |of hidden/not printed ||settings -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108691] Hidden shape in imported XLSX shown in Print window and printed
https://bugs.documentfoundation.org/show_bug.cgi?id=108691 --- Comment #5 from Aron Budea--- Created attachment 134369 --> https://bugs.documentfoundation.org/attachment.cgi?id=134369=edit Sample with combination of hidden/not printed settings The conceptual difference is actually an issue. Office saves all four combination of hidden / fPrintsWithSheet settings in the file, since the two settings can be turned off/on independently. However, if the shape is hidden, the sheet displays and prints the same regardless of the other setting. Therefore in LO not only both have to be translated to the same ODF setting ("none"), afterwards it can't be unambiguously converted back to Excel format. In that case "none" should probably be converted back to hidden and printing as the more likely combination (and hidden and not printing would get lost). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/conditio.hxx|1 - sc/source/core/data/colorscale.cxx | 26 +- 2 files changed, 1 insertion(+), 26 deletions(-) New commits: commit 068755d9313b61a1e4691c27eea122116d3623df Author: Markus MohrhardDate: Tue Jun 27 19:29:02 2017 +0200 no need to manually keep track of listener range Change-Id: I833a2336f0c0ce8cc61eab4c56e1ffac3e36ae62 Reviewed-on: https://gerrit.libreoffice.org/39319 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/sc/inc/conditio.hxx b/sc/inc/conditio.hxx index 631d0449cc13..8dff0355a648 100644 --- a/sc/inc/conditio.hxx +++ b/sc/inc/conditio.hxx @@ -89,7 +89,6 @@ enum ScConditionMode class ScFormulaListener : public SvtListener { private: -std::vector maCells; mutable bool mbDirty; ScDocument* mpDoc; std::function maCallbackFunction; diff --git a/sc/source/core/data/colorscale.cxx b/sc/source/core/data/colorscale.cxx index 4bc29e669006..5b2a942e8ca9 100644 --- a/sc/source/core/data/colorscale.cxx +++ b/sc/source/core/data/colorscale.cxx @@ -52,8 +52,6 @@ void ScFormulaListener::startListening(ScTokenArray* pArr, const ScRange& rRange ScRange aRange(aCell, aCell2); if (aRange.IsValid()) mpDoc->StartListeningArea(aRange, false, this); - -maCells.push_back(aRange); } break; case formula::svDoubleRef: @@ -81,7 +79,6 @@ void ScFormulaListener::startListening(ScTokenArray* pArr, const ScRange& rRange } } mpDoc->StartListeningArea(aRange1, false, this); -maCells.push_back(aRange1); } } break; @@ -101,33 +98,12 @@ void ScFormulaListener::setCallback(const std::function & aCallback) maCallbackFunction = aCallback; } -namespace { - -struct StopListeningCell -{ -StopListeningCell(ScDocument* pDoc, SvtListener* pListener): -mpDoc(pDoc), mpListener(pListener) {} - -// TODO: moggi: use EndListeningArea -void operator()(const ScRange& rRange) -{ -mpDoc->EndListeningArea(rRange, false, mpListener); -} - -private: -ScDocument* mpDoc; -SvtListener* mpListener; -}; - -} - void ScFormulaListener::stopListening() { if (mpDoc->IsClipOrUndo()) return; -std::for_each(maCells.begin(), maCells.end(), StopListeningCell(mpDoc, this)); -maCells.clear(); +this->EndListeningAll(); } ScFormulaListener::~ScFormulaListener() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: LO 80731 - Incorrect syntax does compile, MID without end bracket
On 6/28/2017 2:03 PM, Stephan Bergmann wrote: > On 06/28/2017 12:12 PM, Pierre Lepage wrote: >> The solution brings a lot of hassle for customers of the LibreOffice >> suite whose work relies on the performance of StarBasic macros written >> by third parties. Macros containing code in error by the absence of a >> closing parenthesis suddenly cease to function. For this reason, the >> patch has not been released. Here I want to explore a transitional >> solution by getting your feedback first. This is to include in >> StarBasic options dialog accessible to the client a "StarBasic Pragma >> Strict" option (checkbox) by which the client consciously activates >> the solution (the patch that has not been published!). This check box >> would be available for a few years with a warning to prompt >> programmers and customers to require their programmer to correct their >> default code on the closing parenthesis. > > Another option might be to have some form of such a pragma in individual > BASIC source files, instead of as an IDE option. (And have the pragma > enabled in the "REM * BASIC ** Sub Main ... End Sub" boilerplate > that is automatically present in a fresh source file.) That way, users > could enable it for their own, new code, while (implicitly) keeping it > off for non-conforming old, 3rd-party code. I'd suggest also a special handling of "Compile" IDE command. It should always use strict parsing method. As it is a developer's tool, used when something is created anew, it would help all developers catch the problem early even when they don't know the strict option (wherever it be). -- Best regards, Mike Kaganski ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 104192] Last save location is not remembered across documents/ launches on Fedora 25+GNOME 3.22
https://bugs.documentfoundation.org/show_bug.cgi?id=104192 --- Comment #4 from Nate Graham--- Please ignore that comment. In a KDE environment, the correct behavior is seen with the *open* dialog, but not the *save* dialog. The original bug is still seen in both cases. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104192] Last save location is not remembered across documents/ launches on Fedora 25+GNOME 3.22
https://bugs.documentfoundation.org/show_bug.cgi?id=104192 --- Comment #3 from Nate Graham--- This may be an artifact of the GTK file pickers (or the way they're invoked), since I just noticed that the correct behavior is seen when LibreOffice is run in a KDE environment where it uses the QT file pickers instead. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108846] New: Fuzzy images when viewed in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=108846 Bug ID: 108846 Summary: Fuzzy images when viewed in Impress Product: LibreOffice Version: 5.2.6.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kevme...@outlook.com Description: Images copy and pasted in from Visio 2013 using Powerpoint 2013 and then when viewed in Impress show as "fuzzy". Almost as if there were two images (of the same data) slightly offset from each other. When viewed using Powerpoint 2013...images show OK. This happens over multiple .pptx files. Steps to Reproduce: 1. Use Visio to produce block diagrams. 2. Select all in Visio 3. Ctrl/C 4. Switch to Powerpoint and paste the clipboard 5. Save the .pptx file 6. Open in Impress Actual Results: "Fuzzy" images in IOmpress Expected Results: Sharp images! Reproducible: Always User Profile Reset: Yes Additional Info: Profile reset did NOT fix the problem. In fact, various parts of the diagrams vanished. User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108812] EDITING - Text display "doubles" on top of itself when deleting letters/numbers in a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=108812 --- Comment #6 from m.a.riosv--- Please try resetting the user profile, sometimes solves strange issues. https://wiki.documentfoundation.org/UserProfile Usually it's enough renaming/deleting the file "user/registrymodifications.xcu", it affects all the options in Menu/Tools/Options, and the files "user/basic/dialog.xlc" and "scrip.xlc" are overwritten, additionally custom colors in "user/config/standard.soc" are lost. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108845] New: pasting data from a CSV file didn't work properly: only a single row
https://bugs.documentfoundation.org/show_bug.cgi?id=108845 Bug ID: 108845 Summary: pasting data from a CSV file didn't work properly: only a single row Product: LibreOffice Version: 5.3.3.2 release Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: js...@hotmail.com Description: As per "https://help.libreoffice.org/Common/Importing_and_Exporting_Data_in_Base; I created a table with 3 fields, opened a CSV with 3 fields, selected all the data in the CSV file, then went to paste the data into the Base field. There should have been 10 records, but only a single row was created. When I clicked outside this row to accept it, I got a popup error message saying, "Error inserting the new record Value too long in statement [INSERT INTO "demographics" ("SEXF") VALUES (?)]". Steps to Reproduce: 1.Put cursor in row to be pasted into, 2. Got to Edit, select Paste, 3. Undo things so that I can move on. Actual Results: Cannot paste a table of selected data from CSV into a new Base table. I wish I could send a screenshot, or the CSV file (only 10 records in it) for more clarity. Expected Results: The bug is reproducible. If there's a trick to pasting data into Base, then the documentation needs to say how to do so more clearly. Otherwise, it looks as if this simple task just doesn't work as described, and that to me is the essence of a bug. Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: android/Bootstrap
android/Bootstrap/src/org/libreoffice/kit/Document.java | 21 1 file changed, 21 insertions(+) New commits: commit c746468607d020be10366f2ad2df6dddf947c656 Author: Ximeng ZuDate: Wed Jun 28 15:52:10 2017 -0500 Add LOKit Enums to Document.java Added LOKit callback enums to Document.java. Change-Id: I46b7b5fe0ceb40a89fd121082706acdf539ff916 Reviewed-on: https://gerrit.libreoffice.org/39375 Reviewed-by: Tomaž Vajngerl Tested-by: Tomaž Vajngerl diff --git a/android/Bootstrap/src/org/libreoffice/kit/Document.java b/android/Bootstrap/src/org/libreoffice/kit/Document.java index cd8297c21978..de92cd731eae 100644 --- a/android/Bootstrap/src/org/libreoffice/kit/Document.java +++ b/android/Bootstrap/src/org/libreoffice/kit/Document.java @@ -54,6 +54,8 @@ public class Document { /** * Callback message types + * Refer to http://opengrok.libreoffice.org/xref/core/include/LibreOfficeKit/LibreOfficeKitEnums.h + * for more details about each callback. */ public static final int CALLBACK_INVALIDATE_TILES = 0; public static final int CALLBACK_INVALIDATE_VISIBLE_CURSOR = 1; @@ -71,6 +73,25 @@ public class Document { public static final int CALLBACK_DOCUMENT_SIZE_CHANGED = 13; public static final int CALLBACK_SET_PART = 14; public static final int CALLBACK_SEARCH_RESULT_SELECTION = 15; +public static final int LOK_CALLBACK_UNO_COMMAND_RESULT = 16; +public static final int LOK_CALLBACK_CELL_CURSOR = 17; +public static final int LOK_CALLBACK_MOUSE_POINTER = 18; +public static final int LOK_CALLBACK_CELL_FORMULA = 19; +public static final int LOK_CALLBACK_DOCUMENT_PASSWORD = 20; +public static final int LOK_CALLBACK_DOCUMENT_PASSWORD_TO_MODIFY = 21; +public static final int LOK_CALLBACK_ERROR = 22; +public static final int LOK_CALLBACK_CONTEXT_MENU = 23; +public static final int LOK_CALLBACK_INVALIDATE_VIEW_CURSOR = 24; +public static final int LOK_CALLBACK_TEXT_VIEW_SELECTION = 25; +public static final int LOK_CALLBACK_CELL_VIEW_CURSOR = 26; +public static final int LOK_CALLBACK_GRAPHIC_VIEW_SELECTION = 27; +public static final int LOK_CALLBACK_VIEW_CURSOR_VISIBLE = 28; +public static final int LOK_CALLBACK_VIEW_LOCK = 29; +public static final int LOK_CALLBACK_REDLINE_TABLE_SIZE_CHANGED = 30; +public static final int LOK_CALLBACK_REDLINE_TABLE_ENTRY_MODIFIED = 31; +public static final int LOK_CALLBACK_COMMENT = 32; +public static final int LOK_CALLBACK_INVALIDATE_HEADER = 33; +public static final int LOK_CALLBACK_CELL_ADDRESS = 34; /** * Set text selection types ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
GSoC Weekly update - Solving MABs for Android Viewer - Ximeng Zu
Hello everyone, I spent my last week experimenting with Calc headers. Since a fetch-headers call would double the page size, I looked into working around this "bug". It turned out to be too much overhead in coding as well as app performance. There was also this offset between main view and header views. We managed to solve it by fixing the zoom to 1x in Calc document. The patch is pushed onto gerrit now. Next step is to add more controls to Calc UI as in LOOL. Ximeng Zu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 104791] Crash when changing lines to smoothed type in a diagram
https://bugs.documentfoundation.org/show_bug.cgi?id=104791 Julien Nabetchanged: What|Removed |Added Resolution|FIXED |WORKSFORME --- Comment #5 from Julien Nabet --- Let's put this one to WFM since there's no specific fix. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104791] Crash when changing lines to smoothed type in a diagram
https://bugs.documentfoundation.org/show_bug.cgi?id=104791 EHJchanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED --- Comment #4 from EHJ --- Resuelto en versiones posteriores. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108253] [META] Calc cell formula bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108253 Thomas Lendochanged: What|Removed |Added Depends on||75904 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=75904 [Bug 75904] References get updated differently whether it's copied or cut within the same columns -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75904] References get updated differently whether it' s copied or cut within the same columns
https://bugs.documentfoundation.org/show_bug.cgi?id=75904 Thomas Lendochanged: What|Removed |Added Blocks||108253 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108253 [Bug 108253] [META] Calc cell formula bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 54485] EDITING: cut / paste of a line of data doesn' t remove the selected lines
https://bugs.documentfoundation.org/show_bug.cgi?id=54485 Thomas Lendochanged: What|Removed |Added Blocks||108364 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108364 [Bug 108364] [META] Table/Row/Column/Cell management function bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 54485] EDITING: cut / paste of a line of data doesn' t remove the selected lines
https://bugs.documentfoundation.org/show_bug.cgi?id=54485 Thomas Lendochanged: What|Removed |Added Blocks||108364 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108364 [Bug 108364] [META] Table/Row/Column/Cell management function bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108364] [META] Table/Row/Column/ Cell management function bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108364 Thomas Lendochanged: What|Removed |Added Depends on||54485 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=54485 [Bug 54485] EDITING: cut / paste of a line of data doesn't remove the selected lines -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54485] EDITING: cut / paste of a line of data doesn' t remove the selected lines
https://bugs.documentfoundation.org/show_bug.cgi?id=54485 Thomas Lendochanged: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||thomas.le...@gmail.com --- Comment #8 from Thomas Lendo --- Adding keyword needsUXeval to see if a change is still a valid/wanted issue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108844] [META] Cut/copy bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108844 Thomas Lendochanged: What|Removed |Added Depends on||64028 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=64028 [Bug 64028] Enhancement: option to retain cell formating in Calc when X is used to cut contents of a cell -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108252] [META] Cell-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108252 Thomas Lendochanged: What|Removed |Added Depends on||64028 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=64028 [Bug 64028] Enhancement: option to retain cell formating in Calc when X is used to cut contents of a cell -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64028] Enhancement: option to retain cell formating in Calc when < Ctrl> X is used to cut contents of a cell
https://bugs.documentfoundation.org/show_bug.cgi?id=64028 Thomas Lendochanged: What|Removed |Added Blocks||108844, 108252 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108252 [Bug 108252] [META] Cell-related bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108844 [Bug 108844] [META] Cut/copy bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108836] CRASH: Bad allocation if undo count is set to zero (0) ( see comment 4)
https://bugs.documentfoundation.org/show_bug.cgi?id=108836 --- Comment #9 from Julien Nabet--- part of bt after having removed the assert: (gdb) bt #0 0x7fffc9911aa5 in rtl::OUString::operator+=(rtl::OUStringLiteral1_ const&) & (this=0x, literal=...) at /home/julien/lo/libreoffice/include/rtl/ustring.hxx:576 #1 0x7fffc9d3e35f in SwUndoInsert::CanGrouping (this=0x5ba65d00, cIns=32 u' ') at /home/julien/lo/libreoffice/sw/source/core/undo/unins.cxx:145 #2 0x7fffc9758e77 in sw::DocumentContentOperationsManager::InsertString (this=0x578b9a30, rRg=SwPaM = {...}, rStr=" ", nInsertMode=SwInsertFlags::EMPTYEXPAND) at /home/julien/lo/libreoffice/sw/source/core/doc/DocumentContentOperationsManager.cxx:2514 #3 0x7fffc99058f3 in SwAutoCorrDoc::Insert (this=0x7fff1230, nPos=5, rText=" ") at /home/julien/lo/libreoffice/sw/source/core/edit/acorrect.cxx:131 #4 0x736afedf in SvxAutoCorrect::DoAutoCorrect (this=0x57894ae0, rDoc=..., rTxt="azevb ", nInsPos=5, cChar=32 u' ', bInsert=true, pFrameWin=0x579ab5f0) at /home/julien/lo/libreoffice/editeng/source/misc/svxacorr.cxx:1271 #5 0x7fffc9959d37 in SwEditShell::AutoCorrect (this=0x579d3200, rACorr=..., bInsert=true, cChar=32 u' ') at /home/julien/lo/libreoffice/sw/source/core/edit/edws.cxx:255 #6 0x7fffca528d74 in SwWrtShell::AutoCorrect (this=0x579d3200, rACorr=..., cChar=32 u' ') at /home/julien/lo/libreoffice/sw/source/uibase/wrtsh/wrtsh1.cxx:1613 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=105500 Telestochanged: What|Removed |Added Blocks||108636 Summary|Small but noticeable lag|Small but noticeable lag |when selecting shapes |when selecting shapes with ||sidebar enabled --- Comment #6 from Telesto --- The lag is most likely caused by the fact that the sidebar is refreshing when a new shape is selected, which causes the reload of all palette related files (for example standard.soc) It's working fine without sidebar. Version: 6.0.0.0.alpha0+ Build ID: 9f3814af7264ce90685a82cbf4eb015a38f22bf7 CPU threads: 4; OS: Windows 6.19; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-06-28_00:47:42 Locale: nl-NL (nl_NL); Calc: CL Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108636 [Bug 108636] [META] Extensive file accesses -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108636] [META] Extensive file accesses
https://bugs.documentfoundation.org/show_bug.cgi?id=108636 Telestochanged: What|Removed |Added Depends on||105500 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105500 [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108844] [META] Cut/copy bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108844 Thomas Lendochanged: What|Removed |Added Status|UNCONFIRMED |NEW Blocks||108843 Ever confirmed|0 |1 Alias||Cut-Copy Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108843 [Bug 108843] [META] Clipboard bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108843] [META] Clipboard bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108843 Thomas Lendochanged: What|Removed |Added Depends on||108844 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108844 [Bug 108844] [META] Cut/copy bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108843] [META] Clipboard bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108843 Thomas Lendochanged: What|Removed |Added Status|UNCONFIRMED |NEW Depends on||102593 Ever confirmed|0 |1 Alias||Clipboard Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102593 [Bug 102593] [META] Paste bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 Thomas Lendochanged: What|Removed |Added Blocks||108843 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108843 [Bug 108843] [META] Clipboard bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108844] New: [META] Cut/copy bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108844 Bug ID: 108844 Summary: [META] Cut/copy bugs and enhancements Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thomas.le...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-5.3-18'
Tag 'cp-5.3-18' created by Andras Timarat 2017-06-28 20:40 + cp-5.3-18 Changes since cp-5.3-10: Christian Lohmaier (1): update translations for 5.3.3 rc2 --- source/am/cui/source/options.po|8 source/am/cui/source/tabpages.po |8 source/am/cui/uiconfig/ui.po |8 source/am/fpicker/source/office.po | 10 source/am/officecfg/registry/data/org/openoffice/Office.po |6 source/am/sc/source/ui/src.po |8 source/am/sfx2/source/dialog.po| 12 source/am/svtools/source/dialogs.po|8 source/am/svtools/source/misc.po |8 source/am/svx/source/stbctrls.po |8 source/am/svx/uiconfig/ui.po | 10 source/bg/sc/uiconfig/scalc/ui.po | 20 source/bg/sfx2/source/dialog.po| 12 source/bg/svx/source/dialog.po | 30 source/bg/svx/source/form.po | 10 source/bg/svx/source/stbctrls.po |8 source/bg/svx/source/tbxctrls.po |6 source/bg/svx/uiconfig/ui.po | 289 source/bg/sw/source/ui/utlui.po| 21 source/bg/sw/source/uibase/utlui.po|6 source/bg/sw/uiconfig/swriter/ui.po|5 source/br/cui/uiconfig/ui.po | 70 - source/br/extensions/source/bibliography.po| 12 source/br/extensions/source/propctrlr.po | 152 ++-- source/br/sc/source/ui/src.po | 12 source/ca/helpcontent2/source/text/scalc/00.po | 20 source/ca/helpcontent2/source/text/scalc/01.po |8 source/ca/helpcontent2/source/text/scalc/guide.po | 10 source/ca/helpcontent2/source/text/shared/01.po|6 source/ca/helpcontent2/source/text/shared/guide.po |5 source/ca/helpcontent2/source/text/shared/optionen.po |8 source/ca/helpcontent2/source/text/simpress/guide.po | 10 source/ca/helpcontent2/source/text/swriter/01.po | 13 source/ca/helpcontent2/source/text/swriter/guide.po| 25 source/ca/officecfg/registry/data/org/openoffice/Office/UI.po |8 source/ca/sc/uiconfig/scalc/ui.po |6 source/ca/svx/uiconfig/ui.po | 12 source/cy/cui/uiconfig/ui.po |8 source/cy/sfx2/source/dialog.po| 12 source/cy/sfx2/uiconfig/ui.po | 15 source/cy/svtools/source/dialogs.po|8 source/cy/svtools/source/misc.po |8 source/cy/svx/source/stbctrls.po | 10 source/cy/svx/uiconfig/ui.po | 10 source/da/cui/uiconfig/ui.po |8 source/da/helpcontent2/source/text/scalc/01.po | 12 source/da/sfx2/source/dialog.po| 14 source/da/sfx2/uiconfig/ui.po | 17 source/da/svtools/source/dialogs.po| 10 source/da/svtools/source/java.po | 12 source/da/svtools/source/misc.po | 10 source/da/svx/source/stbctrls.po |8 source/da/svx/uiconfig/ui.po | 12 source/de/editeng/source/items.po | 10 source/de/formula/source/core/resource.po |8 source/de/helpcontent2/source/auxiliary.po |6 source/de/helpcontent2/source/text/sbasic/shared/01.po | 10 source/de/helpcontent2/source/text/scalc.po|6 source/de/helpcontent2/source/text/scalc/00.po |6 source/de/helpcontent2/source/text/scalc/01.po | 100 +- source/de/helpcontent2/source/text/scalc/guide.po | 34 source/de/helpcontent2/source/text/schart/01.po|6 source/de/helpcontent2/source/text/shared/00.po| 10 source/de/helpcontent2/source/text/shared/01.po| 12 source/de/helpcontent2/source/text/shared/explorer/database.po |8 source/de/helpcontent2/source/text/shared/guide.po | 16
[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-5.3-18'
Tag 'cp-5.3-18' created by Andras Timarat 2017-06-28 20:40 + cp-5.3-18 Changes since cp-5.3-17-44: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108843] New: [META] Clipboard bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108843 Bug ID: 108843 Summary: [META] Clipboard bugs and enhancements Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thomas.le...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-5.3-18'
Tag 'cp-5.3-18' created by Andras Timarat 2017-06-28 20:40 + cp-5.3-18 Changes since libreoffice-5-3-branch-point-28: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-5.3-18'
Tag 'cp-5.3-18' created by Andras Timarat 2017-06-28 20:40 + cp-5.3-18 Changes since cp-5.3-10: Olivier R (1): tdf#107558 French spelling dictionary (6.0.3) and thesaurus --- fr_FR/README_fr.txt |4 fr_FR/description.xml |2 fr_FR/fr.aff |17751 ++-- fr_FR/fr.dic |155369 +- fr_FR/package-description.txt |2 fr_FR/thes_fr.dat | 206 6 files changed, 88495 insertions(+), 84839 deletions(-) --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3196fb8da4849a79352c97560f06a42a6092970c Author: Andras TimarDate: Wed Jun 28 22:39:53 2017 +0200 Bump version to 5.3-18 Change-Id: I2a46962eab6ca8ab5170437fad5b19c7377bcaf8 diff --git a/configure.ac b/configure.ac index a15bd9b2c70a..8bed5aa0644e 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([Collabora Office],[5.3.10.17],[],[],[https://collaboraoffice.com/]) +AC_INIT([Collabora Office],[5.3.10.18],[],[],[https://collaboraoffice.com/]) AC_PREREQ([2.59]) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91687] FILESAVE: Doc exporter scales up rotated watermarks
https://bugs.documentfoundation.org/show_bug.cgi?id=91687 Commit Notificationchanged: What|Removed |Added Whiteboard||target:6.0.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91687] FILESAVE: Doc exporter scales up rotated watermarks
https://bugs.documentfoundation.org/show_bug.cgi?id=91687 --- Comment #3 from Commit Notification--- Szymon Kłos committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d72e0cadceb0b43928a9b4f18d75c9d5d30afdda Watermark: tdf#91687 correct size in the .doc It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: filter/source include/svx sw/qa sw/source
filter/source/msfilter/escherex.cxx |4 +++ filter/source/msfilter/msdffimp.cxx | 34 ++- include/svx/msdffdef.hxx |7 ++ sw/qa/extras/ww8export/data/tdf91687.doc |binary sw/qa/extras/ww8export/ww8export2.cxx| 10 + sw/source/filter/ww8/wrtw8esh.cxx|7 +- 6 files changed, 56 insertions(+), 6 deletions(-) New commits: commit d72e0cadceb0b43928a9b4f18d75c9d5d30afdda Author: Szymon KÅosDate: Mon Jun 19 15:32:16 2017 +0200 Watermark: tdf#91687 correct size in the .doc Export: * Watermarks saved using Writer were very small in the MSO. Export fUsegtextFStretch property in the Geometry Text Boolean Properties. * tdf#91687: SnapRect contains size of Watermark after rotation. We have to export size without rotation. Import: * When import set height depending on used font and width. Text will keep the ratio. Remember the padding for export. * added unit test * introduced enum to avoid magic numbers for stretch and best fit properties. Change-Id: I3427afe78488d499f13c543ca401c096161aaf34 Reviewed-on: https://gerrit.libreoffice.org/38979 Tested-by: Jenkins Reviewed-by: Andras Timar diff --git a/filter/source/msfilter/escherex.cxx b/filter/source/msfilter/escherex.cxx index bf0450fe513b..674da67383c7 100644 --- a/filter/source/msfilter/escherex.cxx +++ b/filter/source/msfilter/escherex.cxx @@ -3482,6 +3482,10 @@ void EscherPropertyContainer::CreateCustomShapeProperties( const MSO_SPT eShapeT if ( pOutlinerParaObject && pOutlinerParaObject->IsVertical() ) nTextPathFlags |= 0x2000; } + +// Use gtextFStretch for Watermark like MSO does +nTextPathFlags |= use_gtextFStretch | gtextFStretch; + if ( nTextPathFlags != nTextPathFlagsOrg ) AddOpt( DFF_Prop_gtextFStrikethrough, nTextPathFlags ); } diff --git a/filter/source/msfilter/msdffimp.cxx b/filter/source/msfilter/msdffimp.cxx index 06b9fc1dde61..148a8977959c 100644 --- a/filter/source/msfilter/msdffimp.cxx +++ b/filter/source/msfilter/msdffimp.cxx @@ -4334,7 +4334,8 @@ SdrObject* SvxMSDffManager::ImportShape( const DffRecordHeader& rHd, SvStream& r pRet = new SdrObjCustomShape(); pRet->SetModel( pSdrModel ); -bool bIsFontwork = ( GetPropertyValue( DFF_Prop_gtextFStrikethrough, 0 ) & 0x4000 ) != 0; +sal_uInt32 ngtextFStrikethrough = GetPropertyValue( DFF_Prop_gtextFStrikethrough, 0 ); +bool bIsFontwork = ( ngtextFStrikethrough & 0x4000 ) != 0; // in case of a FontWork, the text is set by the escher import if ( bIsFontwork ) @@ -4359,16 +4360,16 @@ SdrObject* SvxMSDffManager::ImportShape( const DffRecordHeader& rHd, SvStream& r // SJ: applying fontattributes for Fontwork : if ( IsHardAttribute( DFF_Prop_gtextFItalic ) ) -aSet.Put( SvxPostureItem( ( GetPropertyValue( DFF_Prop_gtextFStrikethrough, 0 ) & 0x0010 ) != 0 ? ITALIC_NORMAL : ITALIC_NONE, EE_CHAR_ITALIC ) ); +aSet.Put( SvxPostureItem( ( ngtextFStrikethrough & 0x0010 ) != 0 ? ITALIC_NORMAL : ITALIC_NONE, EE_CHAR_ITALIC ) ); if ( IsHardAttribute( DFF_Prop_gtextFBold ) ) -aSet.Put( SvxWeightItem( ( GetPropertyValue( DFF_Prop_gtextFStrikethrough, 0 ) & 0x0020 ) != 0 ? WEIGHT_BOLD : WEIGHT_NORMAL, EE_CHAR_WEIGHT ) ); +aSet.Put( SvxWeightItem( ( ngtextFStrikethrough & 0x0020 ) != 0 ? WEIGHT_BOLD : WEIGHT_NORMAL, EE_CHAR_WEIGHT ) ); // SJ TODO: Vertical Writing is not correct, instead // this should be replaced through "CharacterRotation" // by 90 degrees, therefore a new Item has to be // supported by svx core, api and xml file format - static_cast (pRet)->SetVerticalWriting( ( GetPropertyValue( DFF_Prop_gtextFStrikethrough, 0 ) & 0x2000 ) != 0 ); + static_cast (pRet)->SetVerticalWriting( ( ngtextFStrikethrough & 0x2000 ) != 0 ); if ( SeekToContent( DFF_Prop_gtextUNICODE, rSt ) ) { @@ -4403,12 +4404,35 @@ SdrObject* SvxMSDffManager::ImportShape( const DffRecordHeader& rHd, SvStream& r if ( nTextWidth != 100 ) aSet.Put( SvxCharScaleWidthItem( (sal_uInt16)nTextWidth, EE_CHAR_FONTWIDTH ) );
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - filter/source include/svx sw/qa sw/source
filter/source/msfilter/escherex.cxx |4 +++ filter/source/msfilter/msdffimp.cxx | 34 ++- include/svx/msdffdef.hxx |7 ++ sw/qa/extras/ww8export/data/tdf91687.doc |binary sw/qa/extras/ww8export/ww8export2.cxx| 10 + sw/source/filter/ww8/wrtw8esh.cxx|7 +- 6 files changed, 56 insertions(+), 6 deletions(-) New commits: commit 617c577b372deebfb4050713a79c97cc512b16aa Author: Szymon KÅosDate: Mon Jun 19 15:32:16 2017 +0200 Watermark: tdf#91687 correct size in the .doc Export: * Watermarks saved using Writer were very small in the MSO. Export fUsegtextFStretch property in the Geometry Text Boolean Properties. * tdf#91687: SnapRect contains size of Watermark after rotation. We have to export size without rotation. Import: * When import set height depending on used font and width. Text will keep the ratio. Remember the padding for export. * added unit test * introduced enum to avoid magic numbers for stretch and best fit properties. Change-Id: I3427afe78488d499f13c543ca401c096161aaf34 Reviewed-on: https://gerrit.libreoffice.org/39355 Reviewed-by: Andras Timar Tested-by: Andras Timar diff --git a/filter/source/msfilter/escherex.cxx b/filter/source/msfilter/escherex.cxx index b8b5b831bd99..e349bc76c4fd 100644 --- a/filter/source/msfilter/escherex.cxx +++ b/filter/source/msfilter/escherex.cxx @@ -3492,6 +3492,10 @@ void EscherPropertyContainer::CreateCustomShapeProperties( const MSO_SPT eShapeT if ( pOutlinerParaObject && pOutlinerParaObject->IsVertical() ) nTextPathFlags |= 0x2000; } + +// Use gtextFStretch for Watermark like MSO does +nTextPathFlags |= use_gtextFStretch | gtextFStretch; + if ( nTextPathFlags != nTextPathFlagsOrg ) AddOpt( DFF_Prop_gtextFStrikethrough, nTextPathFlags ); } diff --git a/filter/source/msfilter/msdffimp.cxx b/filter/source/msfilter/msdffimp.cxx index 81d9ae86c8bf..de9f0d489111 100644 --- a/filter/source/msfilter/msdffimp.cxx +++ b/filter/source/msfilter/msdffimp.cxx @@ -4333,7 +4333,8 @@ SdrObject* SvxMSDffManager::ImportShape( const DffRecordHeader& rHd, SvStream& r pRet = new SdrObjCustomShape(); pRet->SetModel( pSdrModel ); -bool bIsFontwork = ( GetPropertyValue( DFF_Prop_gtextFStrikethrough, 0 ) & 0x4000 ) != 0; +sal_uInt32 ngtextFStrikethrough = GetPropertyValue( DFF_Prop_gtextFStrikethrough, 0 ); +bool bIsFontwork = ( ngtextFStrikethrough & 0x4000 ) != 0; // in case of a FontWork, the text is set by the escher import if ( bIsFontwork ) @@ -4358,16 +4359,16 @@ SdrObject* SvxMSDffManager::ImportShape( const DffRecordHeader& rHd, SvStream& r // SJ: applying fontattributes for Fontwork : if ( IsHardAttribute( DFF_Prop_gtextFItalic ) ) -aSet.Put( SvxPostureItem( ( GetPropertyValue( DFF_Prop_gtextFStrikethrough, 0 ) & 0x0010 ) != 0 ? ITALIC_NORMAL : ITALIC_NONE, EE_CHAR_ITALIC ) ); +aSet.Put( SvxPostureItem( ( ngtextFStrikethrough & 0x0010 ) != 0 ? ITALIC_NORMAL : ITALIC_NONE, EE_CHAR_ITALIC ) ); if ( IsHardAttribute( DFF_Prop_gtextFBold ) ) -aSet.Put( SvxWeightItem( ( GetPropertyValue( DFF_Prop_gtextFStrikethrough, 0 ) & 0x0020 ) != 0 ? WEIGHT_BOLD : WEIGHT_NORMAL, EE_CHAR_WEIGHT ) ); +aSet.Put( SvxWeightItem( ( ngtextFStrikethrough & 0x0020 ) != 0 ? WEIGHT_BOLD : WEIGHT_NORMAL, EE_CHAR_WEIGHT ) ); // SJ TODO: Vertical Writing is not correct, instead // this should be replaced through "CharacterRotation" // by 90 degrees, therefore a new Item has to be // supported by svx core, api and xml file format - static_cast (pRet)->SetVerticalWriting( ( GetPropertyValue( DFF_Prop_gtextFStrikethrough, 0 ) & 0x2000 ) != 0 ); + static_cast (pRet)->SetVerticalWriting( ( ngtextFStrikethrough & 0x2000 ) != 0 ); if ( SeekToContent( DFF_Prop_gtextUNICODE, rSt ) ) { @@ -4402,12 +4403,35 @@ SdrObject* SvxMSDffManager::ImportShape( const DffRecordHeader& rHd, SvStream& r if ( nTextWidth != 100 ) aSet.Put( SvxCharScaleWidthItem( (sal_uInt16)nTextWidth,
[Libreoffice-bugs] [Bug 108842] New: no icons on home build LO master 6.0
https://bugs.documentfoundation.org/show_bug.cgi?id=108842 Bug ID: 108842 Summary: no icons on home build LO master 6.0 Product: LibreOffice Version: 6.0.0.0.alpha0+ Master Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: xv3...@gmail.com Created attachment 134368 --> https://bugs.documentfoundation.org/attachment.cgi?id=134368=edit error message no icons one thing i want to ask about the home build LO i have no icons, the error message is as follow warn:fwk.uiconfiguration:23493:1:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_helpindex.png' from icon theme 'helpimg' warn:fwk.uiconfiguration:23493:1:framework/source/uiconfiguration/ImageArrayData.cxx:74: Failed to load image 'cmd/sc_extendedhelp.png' from icon theme 'helpimg' warn:legacy.tools:23493:1:svx/source/form/fmvwimp.cxx:445: FmXFormView::~FmXFormView: Window list not empty! warn:svl.items:23493:1:svl/source/items/itempool.cxx:420: old secondary pool: XOutdevItemPool of pool: ScDocumentPool must be empty. warn:svl.items:23493:1:svl/source/items/itempool.cxx:420: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty. warn:legacy.tools:23493:1:basic/source/sbx/sbxobj.cxx:94: Object element with dangling parent warn:legacy.tools:23493:1:basic/source/sbx/sbxobj.cxx:94: Object element with dangling parent warn:legacy.tools:23493:1:basic/source/sbx/sbxobj.cxx:94: Object element with dangling parent i don't get it -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108836] CRASH: Bad allocation if undo count is set to zero (0) ( see comment 4)
https://bugs.documentfoundation.org/show_bug.cgi?id=108836 --- Comment #8 from Telesto--- I personally would prefer to be able to set it to 0. For three reasons: - It makes it possible to move larger datasets in Calc (undo is a bit memory hungry) - It makes it a bit easier spotting real memory leaks - Writer is the only application crashing -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108840] Cell Border on PPTX is showing even though it' s set to no border in MS PowerPoint
https://bugs.documentfoundation.org/show_bug.cgi?id=108840 Xisco Faulíchanged: What|Removed |Added Keywords||bibisected, bisected, ||regression Status|UNCONFIRMED |RESOLVED CC||xiscofa...@libreoffice.org Resolution|--- |DUPLICATE --- Comment #2 from Xisco Faulí --- Regression introduced by 3e4d2043e99201ec542186039e3be34d3c226111 which is the same as in bug 104199. Closing as RESOLVED DUPLICATED *** This bug has been marked as a duplicate of bug 104199 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104199] FILEOPEN: PPTX Table cell borders shouldn't be displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=104199 Xisco Faulíchanged: What|Removed |Added CC||stuartc...@gmail.com --- Comment #2 from Xisco Faulí --- *** Bug 108840 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105541] Charts rendering stutters on bargraphs + hatched-areas
https://bugs.documentfoundation.org/show_bug.cgi?id=105541 Markus Mohrhardchanged: What|Removed |Added Component|Calc|Chart -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108684] LibO will accesses share\extensions\dict-da and dict-hu when hoovering over the toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=108684 --- Comment #2 from Telesto--- Created attachment 134367 --> https://bugs.documentfoundation.org/attachment.cgi?id=134367=edit Procmon filter My filter settings. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107970] Build ID: 3d9a8b4b4e538a85e0782bd6c2d430bafe583448 consume 100% CPU
https://bugs.documentfoundation.org/show_bug.cgi?id=107970 Xisco Faulíchanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108265] auto spell check is not working even after saving file also
https://bugs.documentfoundation.org/show_bug.cgi?id=108265 Julien Nabetchanged: What|Removed |Added Component|Base|Writer -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107450] [META] Cell protection bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107450 Thomas Lendochanged: What|Removed |Added Blocks||108252 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108252 [Bug 108252] [META] Cell-related bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108252] [META] Cell-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108252 Thomas Lendochanged: What|Removed |Added Depends on||107450 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107450 [Bug 107450] [META] Cell protection bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108252] [META] Cell-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108252 Thomas Lendochanged: What|Removed |Added Depends on||59284 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=59284 [Bug 59284] [META] Cell border related issues (Make it easier to apply borders to cells) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59284] [META] Cell border related issues ( Make it easier to apply borders to cells)
https://bugs.documentfoundation.org/show_bug.cgi?id=59284 Thomas Lendochanged: What|Removed |Added Blocks||108252 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108252 [Bug 108252] [META] Cell-related bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108827] [META] Calc functions bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108827 Thomas Lendochanged: What|Removed |Added Depends on||105582 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105582 [Bug 105582] [META] Function wizard dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105582] [META] Function wizard dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105582 Thomas Lendochanged: What|Removed |Added Blocks||108827 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108827 [Bug 108827] [META] Calc functions bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108252] [META] Cell-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108252 Thomas Lendochanged: What|Removed |Added Depends on|108320 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108320 [Bug 108320] [META] Calc cells merging and splitting bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108827] [META] Calc functions bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108827 Thomas Lendochanged: What|Removed |Added Blocks||108252 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108252 [Bug 108252] [META] Cell-related bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108252] [META] Cell-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108252 Thomas Lendochanged: What|Removed |Added Depends on||108827 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108827 [Bug 108827] [META] Calc functions bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108320] [META] Calc cells merging and splitting bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108320 Thomas Lendochanged: What|Removed |Added Blocks|108252 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108252 [Bug 108252] [META] Cell-related bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108684] LibO will accesses share\extensions\dict-da and dict-hu when hoovering over the toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=108684 Buovjagachanged: What|Removed |Added CC||todven...@suomi24.fi --- Comment #1 from Buovjaga --- Created attachment 134366 --> https://bugs.documentfoundation.org/attachment.cgi?id=134366=edit Procmon filter Here is a filter for process name soffice.bin and path contains dict-da and dict-hu. Load it from Filter - Organize filters - Import. I get no results. Do you get any with this? Version: 6.0.0.0.alpha0+ (x64) Build ID: e0f67add2ec56706ce06a03572535266f21c0303 CPU threads: 4; OS: Windows 6.19; UI render: default; TinderBox: Win-x86_64@42, Branch:master, Time: 2017-06-27_23:04:56 Locale: fi-FI (fi_FI); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108836] CRASH: Bad allocation if undo count is set to zero (0) ( see comment 4)
https://bugs.documentfoundation.org/show_bug.cgi?id=108836 Julien Nabetchanged: What|Removed |Added Keywords||haveBacktrace CC||mst...@redhat.com --- Comment #7 from Julien Nabet --- Michael: thought you might be interested in this one. I got an assert which has been introduced with https://cgit.freedesktop.org/libreoffice/core/commit/?id=e012f326c1c32c053304998a6826cb322f2c7728 (2013). Now I just wonder if putting 0 at undo should be forbidden since we've got an assert, or if we just should remove this assert. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108836] CRASH: Bad allocation if undo count is set to zero (0) ( see comment 4)
https://bugs.documentfoundation.org/show_bug.cgi?id=108836 Julien Nabetchanged: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #6 from Julien Nabet --- Created attachment 134365 --> https://bugs.documentfoundation.org/attachment.cgi?id=134365=edit bt with debug symbols On pc Debian x86-64 with master sources updated today, I got an assert. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108656] LibO is trying to access the non-existing user\config\standard.soc when opening the Paragraph dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=108656 Buovjagachanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #1 from Buovjaga --- Yeah, NO SUCH FILE. Version: 6.0.0.0.alpha0+ (x64) Build ID: e0f67add2ec56706ce06a03572535266f21c0303 CPU threads: 4; OS: Windows 6.19; UI render: default; TinderBox: Win-x86_64@42, Branch:master, Time: 2017-06-27_23:04:56 Locale: fi-FI (fi_FI); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108841] New: "+" button to appear while hovering a table
https://bugs.documentfoundation.org/show_bug.cgi?id=108841 Bug ID: 108841 Summary: "+" button to appear while hovering a table Product: LibreOffice Version: 6.0.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: marcoagpi...@mail.telepac.pt CC: marcoagpi...@mail.telepac.pt Created attachment 134364 --> https://bugs.documentfoundation.org/attachment.cgi?id=134364=edit screenshot of Word 2016 While hovering a table, a highlighted "+" sign should appear to add columns/rows to tables easily, just like in MS Office 2016. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108790] Interoperability of track changes and comments between Writer and Word ( OOXML)
https://bugs.documentfoundation.org/show_bug.cgi?id=108790 Aron Budeachanged: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=10 | |8791| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108791] Interoperability of track changes and comments between Writer and Word ( binary format)
https://bugs.documentfoundation.org/show_bug.cgi?id=108791 Aron Budeachanged: What|Removed |Added See Also|https://bugs.documentfounda |https://bugs.documentfounda |tion.org/show_bug.cgi?id=10 |tion.org/show_bug.cgi?id=10 |8790|5485 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105485] With track changes enabled, deleted comments persist in DOCX format
https://bugs.documentfoundation.org/show_bug.cgi?id=105485 Aron Budeachanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||8791 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108840] Cell Border on PPTX is showing even though it' s set to no border in MS PowerPoint
https://bugs.documentfoundation.org/show_bug.cgi?id=108840 --- Comment #1 from Stuart Ng--- Created attachment 134363 --> https://bugs.documentfoundation.org/attachment.cgi?id=134363=edit This is the repro doc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108840] New: Cell Border on PPTX is showing even though it' s set to no border in MS PowerPoint
https://bugs.documentfoundation.org/show_bug.cgi?id=108840 Bug ID: 108840 Summary: Cell Border on PPTX is showing even though it's set to no border in MS PowerPoint Product: LibreOffice Version: 4.4 all versions Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: stuartc...@gmail.com Description: Open a PPTX slide from PowerPoint, where the cell border are set to no borders. In Libreoffice the border shows Steps to Reproduce: 1. Upload the attached PPTX file 2. Open in Libreoffice Actual Results: Cell border is showing Expected Results: Cell border should not show Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88173] [META] DOCX (OOXML) format limitations
https://bugs.documentfoundation.org/show_bug.cgi?id=88173 Aron Budeachanged: What|Removed |Added Depends on||105485 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105485 [Bug 105485] With track changes enabled, deleted comments persist in DOCX format -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105485] With track changes enabled, deleted comments persist in DOCX format
https://bugs.documentfoundation.org/show_bug.cgi?id=105485 Aron Budeachanged: What|Removed |Added Hardware|x86-64 (AMD64) |All Version|3.6.7.2 release |Inherited From OOo Blocks||88173 Summary|Can't delete my own |With track changes enabled, |comments in a track changes |deleted comments persist in |docx after |DOCX format |closing/reopening Writer| Severity|minor |normal --- Comment #10 from Aron Budea --- (In reply to Buovjaga from comment #3) > Hmm.. you are right + the behavior is different when using ODT. With ODT, > there is no tracking of deleted comments: they just disappear immediately > upon deleting. There is, in ODT format comment addition/deletion is tracked (changing isn't). Let's change back severity to normal, as the bug does prevent professional work, and is an interoperability issue between Writer and Word. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=88173 [Bug 88173] [META] DOCX (OOXML) format limitations -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103341] [META] Auto Correct and Completion bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103341 Bug 103341 depends on bug 33684, which changed state. Bug 33684 Summary: autocompletion does not longer work by pressing TAB https://bugs.documentfoundation.org/show_bug.cgi?id=33684 What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTABUG |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33684] autocompletion does not longer work by pressing TAB
https://bugs.documentfoundation.org/show_bug.cgi?id=33684 Christoph Thieleckechanged: What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTABUG |--- --- Comment #35 from Christoph Thielecke --- I can't accept this. Kohei wrote something 2011 which is long time ago and does not fix the bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source
cui/source/customize/acccfg.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 91c838a4c9d0d7a8438e2e76a3636dc67a6221bb Author: Muhammet KaraDate: Wed Jun 28 11:15:48 2017 +0300 Use SvTreeListBox's own method: RemoveEntry Change-Id: I3d0c605450dc2b847ac3fa46b9d050720a7a1a03 Reviewed-on: https://gerrit.libreoffice.org/39350 Tested-by: Jenkins Reviewed-by: Muhammet Kara (cherry picked from commit 8cf31f15b3c8af2c5453c980e23cfc31cf34f519) Reviewed-on: https://gerrit.libreoffice.org/39372 diff --git a/cui/source/customize/acccfg.cxx b/cui/source/customize/acccfg.cxx index ce1c0d552004..73ed7747c48a 100644 --- a/cui/source/customize/acccfg.cxx +++ b/cui/source/customize/acccfg.cxx @@ -1544,7 +1544,7 @@ SvTreeListEntry* SfxAcceleratorConfigPage::applySearchFilter(OUString& rSearchTe if (!textSearch.SearchForward( aStr, , )) { -rListBox->GetModel()->Remove(pEntry); +rListBox->RemoveEntry(pEntry); } else if (!pFirstMatch) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 107794] DDE-links do not work anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=107794 --- Comment #2 from Denturck Frank--- The issue has been solved in version 5.3.4.2. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108624] EDITING: Spell checking suggestion isn' t showing up when another program had focus before
https://bugs.documentfoundation.org/show_bug.cgi?id=108624 Telestochanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #4 from Telesto --- Indeed, no repro with: Versie: 5.4.0.1 Build ID: 962a9c4e2f56d1dbdd354b1becda28edd471f4f2 CPU-threads: 4; Besturingssysteem:Windows 6.2; UI-render: standaard; Locale: nl-NL (nl_NL); Calc: CL Closing WFM -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa sc/source sfx2/source
sc/qa/unit/tiledrendering/tiledrendering.cxx | 67 +++ sc/source/ui/view/tabvwshb.cxx |3 + sfx2/source/view/viewfrm.cxx | 26 +- 3 files changed, 94 insertions(+), 2 deletions(-) New commits: commit 0ac92837d31c4065be4a41e2a2541811c9f6be00 Author: Henry CastroDate: Wed Jun 28 10:26:21 2017 -0400 sc lok: disable Undo/Redo state if conflict with other views Change-Id: I5bc5be2b17925ec3a203f9704f62a8c80ac5fc9d Reviewed-on: https://gerrit.libreoffice.org/39363 Tested-by: Jenkins Reviewed-by: Henry Castro diff --git a/sc/qa/unit/tiledrendering/tiledrendering.cxx b/sc/qa/unit/tiledrendering/tiledrendering.cxx index 3778f4be1093..c90032a8c0ca 100644 --- a/sc/qa/unit/tiledrendering/tiledrendering.cxx +++ b/sc/qa/unit/tiledrendering/tiledrendering.cxx @@ -83,6 +83,7 @@ public: void testUndoRepairDispatch(); void testInsertGraphicInvalidations(); void testDocumentSizeWithTwoViews(); +void testDisableUndoRepair(); CPPUNIT_TEST_SUITE(ScTiledRenderingTest); CPPUNIT_TEST(testRowColumnSelections); @@ -109,6 +110,7 @@ public: CPPUNIT_TEST(testUndoRepairDispatch); CPPUNIT_TEST(testInsertGraphicInvalidations); CPPUNIT_TEST(testDocumentSizeWithTwoViews); +CPPUNIT_TEST(testDisableUndoRepair); CPPUNIT_TEST_SUITE_END(); private: @@ -1347,6 +1349,71 @@ void ScTiledRenderingTest::testDocumentSizeWithTwoViews() comphelper::LibreOfficeKit::setActive(false); } +void ScTiledRenderingTest::testDisableUndoRepair() +{ +comphelper::LibreOfficeKit::setActive(); +ScModelObj* pModelObj = createDoc("cursor-away.ods"); +CPPUNIT_ASSERT(pModelObj); + +// view #1 +int nView1 = SfxLokHelper::getView(); +SfxViewShell* pView1 = SfxViewShell::Current(); + +// view #2 +SfxLokHelper::createView(); +int nView2 = SfxLokHelper::getView(); +SfxViewShell* pView2 = SfxViewShell::Current(); +CPPUNIT_ASSERT(pView1 != pView2); +{ +SfxItemSet aSet1(pView1->GetPool(), svl::Items {}); +SfxItemSet aSet2(pView2->GetPool(), svl::Items {}); +pView1->GetSlotState(SID_UNDO, nullptr, ); +pView2->GetSlotState(SID_UNDO, nullptr, ); +CPPUNIT_ASSERT_EQUAL(SfxItemState::DISABLED, aSet1.GetItemState(SID_UNDO)); +CPPUNIT_ASSERT_EQUAL(SfxItemState::DISABLED, aSet2.GetItemState(SID_UNDO)); +} + +// text edit a cell in view #1 +SfxLokHelper::setView(nView1); +pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 'h', 0); +pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 'h', 0); +pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, awt::Key::RETURN); +pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, awt::Key::RETURN); +Scheduler::ProcessEventsToIdle(); +{ +SfxItemSet aSet1(pView1->GetPool(), svl::Items {}); +SfxItemSet aSet2(pView2->GetPool(), svl::Items {}); +pView1->GetSlotState(SID_UNDO, nullptr, ); +pView2->GetSlotState(SID_UNDO, nullptr, ); +CPPUNIT_ASSERT_EQUAL(SfxItemState::SET, aSet1.GetItemState(SID_UNDO)); +CPPUNIT_ASSERT(dynamic_cast< const SfxStringItem* >(aSet1.GetItem(SID_UNDO))); +CPPUNIT_ASSERT_EQUAL(SfxItemState::SET, aSet2.GetItemState(SID_UNDO)); +CPPUNIT_ASSERT(dynamic_cast< const SfxUInt32Item* >(aSet2.GetItem(SID_UNDO))); +CPPUNIT_ASSERT_EQUAL(static_cast< sal_uInt32 >(SID_REPAIRPACKAGE), dynamic_cast< const SfxUInt32Item* >(aSet2.GetItem(SID_UNDO))->GetValue()); +} + +// text edit a cell in view #2 +SfxLokHelper::setView(nView2); +pModelObj->setPart(1); +pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 'c', 0); +pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 'c', 0); +pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, awt::Key::RETURN); +pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, awt::Key::RETURN); +Scheduler::ProcessEventsToIdle(); +Scheduler::ProcessEventsToIdle(); +{ +SfxItemSet aSet1(pView1->GetPool(), svl::Items {}); +SfxItemSet aSet2(pView2->GetPool(), svl::Items {}); +pView1->GetSlotState(SID_UNDO, nullptr, ); +pView2->GetSlotState(SID_UNDO, nullptr, ); +CPPUNIT_ASSERT_EQUAL(SfxItemState::SET, aSet1.GetItemState(SID_UNDO)); +CPPUNIT_ASSERT(dynamic_cast< const SfxUInt32Item* >(aSet1.GetItem(SID_UNDO))); +CPPUNIT_ASSERT_EQUAL(static_cast< sal_uInt32 >(SID_REPAIRPACKAGE), dynamic_cast< const SfxUInt32Item* >(aSet1.GetItem(SID_UNDO))->GetValue()); +CPPUNIT_ASSERT_EQUAL(SfxItemState::SET, aSet2.GetItemState(SID_UNDO)); +CPPUNIT_ASSERT(dynamic_cast< const SfxStringItem* >(aSet2.GetItem(SID_UNDO))); +} +} + } CPPUNIT_TEST_SUITE_REGISTRATION(ScTiledRenderingTest); diff --git
[Libreoffice-bugs] [Bug 103370] [META] Outline/Chapter numbering bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103370 Regina Henschelchanged: What|Removed |Added Depends on||98267 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=98267 [Bug 98267] Cannot change position of outline numbering via Tools > Outline numbering... Position -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98267] Cannot change position of outline numbering via Tools > Outline numbering... Position
https://bugs.documentfoundation.org/show_bug.cgi?id=98267 Regina Henschelchanged: What|Removed |Added CC||rb.hensc...@t-online.de Blocks||103370 --- Comment #8 from Regina Henschel --- The problem is inside the file. It has a setting of left-margin="0cm" in the style. Go to the tab 'Indents & Spacing' of the paragraph style and click on button "Standard" to remove the settings. You might need to remove direct formatting too. The behavior corresponds to the section 17.20 in the spec, where you read in the forth sentence, "The fo:text-indent and fo:margin-left attributes are evaluated only for paragraphs inside list items whose paragraph styles do not specify them. If one of the two properties, or both, are specified by the paragraph style, the text indent and/or left margin are taken from the paragraph style. In this case the paragraph style's properties are used to determine the indent and margin for the text lines and thus also the alignment position." After you remove the values, the settings of the Outline-Numbering-dialog will be mirrored to the paragraph style. The entire handling is strange. So I will keep it as "New" and add it to the meta bug Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103370 [Bug 103370] [META] Outline/Chapter numbering bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98589] Printing: selected paper size gets overridden when trying to print
https://bugs.documentfoundation.org/show_bug.cgi?id=98589 David Chattertonchanged: What|Removed |Added OS|All |Mac OS X (All) --- Comment #5 from David Chatterton --- This bug is apparent when using LibreOffice under Mac OS but seems to work alright when using LibreOffice under Ubuntu. The printer in question is a HP-Photosmart-7520 series used wirelessly i.e. via the WiFi. I have downloaded and installed the latest version of LibreOffice on the Mac and the bug is still there. Ubuntu automatically ensures that LibreOffice is up-to-date, its current version being 5.3.2.2. What I am trying to do it print a file to photo paper on the printer. It works using LibreOffice under Ubuntu but, on the Mac, the printer defaults to selecting A4 paper from the A4 paper tray and fails to select the photo paper in the photo tray. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs