[Libreoffice-bugs] [Bug 107166] Text is invisible, both in UI and in editor on update to 5.3.2, older AMD and Intel GPUs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107166

--- Comment #89 from Christoffer  ---
(In reply to Buovjaga from comment #86)
> (In reply to Christoffer from comment #85)
> > Created attachment 134766 [details]
> > No text visible on 5.4.0.2 RC2
> > 
> > I tried out the RC2 of 5.4 and this bug appeared. I guess it isn't fixed?
> 
> The commit went in just a few hours ago, it cannot be in 5.4 RC2. Test with
> a master build for now:
> http://dev-builds.libreoffice.org/daily/master/Win-x86_64@42/current/

Thank you. The issue has been solved for me in
libo-master64~2017-07-21_04.09.11_LibreOfficeDev_6.0.0.0.alpha0_Win_x64

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/qa

[Chris Sherlock]

 vcl/qa/cppunit/mnemonic.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 827aa375ddc89cbc468267cbf94a8cea1ef4215c
Author: Chris Sherlock 
Date:   Sat Jul 22 12:56:31 2017 +1000

vcl: fix Unicode cast in mnemonic test

Fix the following:


/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/vcl/qa/cppunit/mnemonic.cxx:35:50:error:
 in LIBO_INTERNAL_ONLY code, replace literal cast to 'sal_Unicode' (aka 
'char16_t') with a u'...' char16_t character literal 
[loplugin:salunicodeliteral]
CPPUNIT_ASSERT_EQUAL(sResult[1], sal_Unicode('~'));
 ^~~~

/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:300:32:
 note: expanded from macro 'CPPUNIT_ASSERT_EQUAL'
  (actual),\
   ^~
1 error generated.

Change-Id: I323270d4ddf9e8ae22f9bf7cd7333a8d7e58d17c
Reviewed-on: https://gerrit.libreoffice.org/40301
Reviewed-by: Chris Sherlock 
Tested-by: Chris Sherlock 

diff --git a/vcl/qa/cppunit/mnemonic.cxx b/vcl/qa/cppunit/mnemonic.cxx
index 1e5ec74c1ec8..c3a28730934e 100644
--- a/vcl/qa/cppunit/mnemonic.cxx
+++ b/vcl/qa/cppunit/mnemonic.cxx
@@ -32,7 +32,7 @@ void VclMnemonicTest::testMnemonic()
 {
 MnemonicGenerator aGenerator;
 OUString sResult = aGenerator.CreateMnemonic(OUString::fromUtf8(u8"ßa"));
-CPPUNIT_ASSERT_EQUAL(sResult[1], sal_Unicode('~'));
+CPPUNIT_ASSERT_EQUAL(sResult[1], u'~');
 }
 
 CPPUNIT_TEST_SUITE_REGISTRATION(VclMnemonicTest);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 93244] Widescreen aspect ratio (16:9) by default in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93244

--- Comment #7 from V Stuart Foote  ---
Agree 4:3 should be replaced with a 16:9 default. Also believe existing library
of 4:3 templates should be scaled and adjusted as needed. Any new template
submissions should be at 16:9 

>From a practical side, 4:3 projectors are increasingly rare. I moved my
classrooms to 16:9 FullHD projectors years ago, and faculty laptops and
workstations have been 16:9 almost as long.

So the UI authoring default should evolve to match common presentation
equipment and avoid distortion of slide when scaled. The loss of horizontal
space to the UI is negligible as the Sidebar deck can be collapsed, while
emerging MUFFIN interfaces provide alternative(s) to the Sidebar.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 93244] Widescreen aspect ratio (16:9) by default in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93244

--- Comment #7 from V Stuart Foote  ---
Agree 4:3 should be replaced with a 16:9 default. Also believe existing library
of 4:3 templates should be scaled and adjusted as needed. Any new template
submissions should be at 16:9 

From a practical side, 4:3 projectors are increasingly rare. I moved my
classrooms to 16:9 FullHD projectors years ago, and faculty laptops and
workstations have been 16:9 almost as long.

So the UI authoring default should evolve to match common presentation
equipment and avoid distortion of slide when scaled. The loss of horizontal
space to the UI is negligible as the Sidebar deck can be collapsed, while
emerging MUFFIN interfaces provide alternative(s) to the Sidebar.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

Re: LibreOffice Error during make command

[sherlock]

As It mentioned in the tutorial(
https://wiki.documentfoundation.org/Development/BuildingForAndroid ), I
downloaded latest version via this command( git clone
git://anongit.freedesktop.org/libreoffice/core libreoffice ). If I should
use special commit how can I download it?



--
View this message in context: 
http://nabble.documentfoundation.org/LibreOffice-Error-during-make-command-tp4218467p4218734.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: cui/Library_cui.mk cui/source

[Muhammet Kara]

 cui/Library_cui.mk|1 
 cui/source/customize/SvxToolbarConfigPage.cxx | 1169 
 cui/source/customize/cfg.cxx  | 1504 ++
 cui/source/inc/SvxMenuConfigPage.hxx  |4 
 cui/source/inc/SvxToolbarConfigPage.hxx   |  128 ++
 cui/source/inc/cfg.hxx|  239 ++--
 6 files changed, 1600 insertions(+), 1445 deletions(-)

New commits:
commit 8e71acc7b775aa4ad93b45aa18d0ec7d6a47a314
Author: Muhammet Kara 
Date:   Thu Jun 29 14:50:36 2017 +0300

Separate SvxToolbarConfigPage from cfg.cxx

Change-Id: I4aa504b92e9507635152c623a07d0538079860de
Reviewed-on: https://gerrit.libreoffice.org/39389
Tested-by: Jenkins 
Reviewed-by: Katarina Behrens 
Reviewed-on: https://gerrit.libreoffice.org/40297
Reviewed-by: Muhammet Kara 

diff --git a/cui/Library_cui.mk b/cui/Library_cui.mk
index 2f3bd0d5881b..8f29a4fa3ce0 100644
--- a/cui/Library_cui.mk
+++ b/cui/Library_cui.mk
@@ -89,6 +89,7 @@ $(eval $(call gb_Library_add_exception_objects,cui,\
 cui/source/customize/eventdlg \
 cui/source/customize/macropg \
 cui/source/customize/SvxMenuConfigPage \
+cui/source/customize/SvxToolbarConfigPage \
 cui/source/dialogs/about \
 cui/source/dialogs/colorpicker \
 cui/source/dialogs/cuicharmap \
diff --git a/cui/source/customize/SvxToolbarConfigPage.cxx 
b/cui/source/customize/SvxToolbarConfigPage.cxx
new file mode 100644
index ..272409d2825e
--- /dev/null
+++ b/cui/source/customize/SvxToolbarConfigPage.cxx
@@ -0,0 +1,1169 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ *   Licensed to the Apache Software Foundation (ASF) under one or more
+ *   contributor license agreements. See the NOTICE file distributed
+ *   with this work for additional information regarding copyright
+ *   ownership. The ASF licenses this file to you under the Apache
+ *   License, Version 2.0 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#include "sal/config.h"
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include "svtools/treelistentry.hxx"
+#include "svtools/viewdataentry.hxx"
+#include 
+#include 
+
+#include 
+#include "helpids.h"
+#include "strings.hrc"
+
+#include "acccfg.hxx"
+#include "cfg.hxx"
+#include "SvxToolbarConfigPage.hxx"
+#include "eventdlg.hxx"
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include "com/sun/star/ui/dialogs/TemplateDescription.hpp"
+#include 
+#include 
+
+#include "dlgname.hxx"
+
+SvxToolbarConfigPage::SvxToolbarConfigPage(vcl::Window *pParent, const 
SfxItemSet& rSet)
+: SvxConfigPage(pParent, rSet)
+, m_pMenu(get_menu("modifymenu"))
+, m_pEntry(get_menu("contentmenu"))
+{
+SetHelpId( HID_SVX_CONFIG_TOOLBAR );
+
+m_pContentsListBox = VclPtr::Create(m_pEntries, 
this);
+m_pContentsListBox->set_grid_left_attach(0);
+m_pContentsListBox->set_grid_top_attach(0);
+m_pContentsListBox->set_hexpand(true);
+m_pContentsListBox->set_vexpand(true);
+m_pContentsListBox->Show();
+
+m_pTopLevelListBox->SetHelpId ( HID_SVX_TOPLEVELLISTBOX );
+m_pIconsOnlyRB->SetHelpId ( HID_SVX_ICONSONLY );
+m_pTextOnlyRB->SetHelpId ( HID_SVX_TEXTONLY );
+m_pIconsAndTextRB->SetHelpId ( HID_SVX_ICONSANDTEXT );
+m_pContentsListBox->SetHelpId( HID_SVX_CONFIG_TOOLBAR_CONTENTS );
+m_pNewTopLevelButton->SetHelpId( HID_SVX_NEW_TOOLBAR );
+m_pModifyTopLevelButton->SetHelpId( HID_SVX_MODIFY_TOOLBAR );
+m_pAddCommandsButton->SetHelpId( HID_SVX_NEW_TOOLBAR_ITEM );
+m_pAddSeparatorButton->SetHelpId ( HID_SVX_ADD_SEPARATOR );
+m_pModifyCommandButton->SetHelpId( HID_SVX_MODIFY_TOOLBAR_ITEM );
+m_pDeleteCommandButton->SetHelpId ( HID_SVX_REMOVEBUTTON );
+m_pResetTopLevelButton->SetHelpId ( HID_SVX_RESETBUTTON );
+

[Libreoffice-bugs] [Bug 109260] Double-lined text shifted not same value as normal text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109260

--- Comment #5 from kong  ---
I checked and confirmed again that 5.3.3.2 on Windows is no problem at all.Just
only just only happens on linux.

Is difference between directX and others about /canvas/source ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #24 from Jim Raykowski  ---
Initial patch ready for comments. 

Yousuf, the tooltip is currently 'Navigation Element'. I would have changed it
but didn't see your comment until after uploading patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #24 from Jim Raykowski  ---
Initial patch ready for comments. 

Yousuf, the tooltip is currently 'Navigation Element'. I would have changed it
but didn't see your comment until after uploading patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 108529] Exported SVG does not appear when used in a browser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108529

--- Comment #8 from Regina Henschel  ---
If you remove the JavaScript you have to set the visibility to "visible" in
addition, because that would be done by the script. In the example you have
attached it is in line #166.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93244] Widescreen aspect ratio (16:9) by default in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93244

--- Comment #6 from Bastián Díaz  ---
(In reply to Yousuf Philips (jay) from comment #5)
> -1 for me, as
> 
> 1. 16:9 leaves less space to work with when both the slide pane and the
> sidebar are open

True, but the side panel can be easily hidden, in addition, it is not the only
available interface layout and many more come in (MUFFIN!).
On the other hand, if a user uses the 16: 9 format it is because it is the most
useful, practical and that gives him more space to present the content and in
the end that is what is important.

> 2. users have easy access to switch to it in the sidebar

The same if default is 16:9 and you want to use another page format.

> 3. most of our templates arent 16:9

How could this be solved? Means that each template must have a file for each
page format (eg 4:3, 16:9, 16:10, etc.). Whatever the decision, the most
popular formats for users should be offered IMHO.

> 4. most other presentation apps havent switch over to it

As I mentioned above when opening the report, most other presentation
applications changed to 16:9 by default.

> 5. users who prefer 16:9 can easily create a 16:9 template as their default

That's right, but I do not think it's the way to see the problem. Why keep the
4: 3 format by default? More than being the most popular or used format (it is
not already) is a legacy format and in my case, I have a template 4.3 for these
cases (contrary to what you propose).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 93244] Widescreen aspect ratio (16:9) by default in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93244

--- Comment #6 from Bastián Díaz  ---
(In reply to Yousuf Philips (jay) from comment #5)
> -1 for me, as
> 
> 1. 16:9 leaves less space to work with when both the slide pane and the
> sidebar are open

True, but the side panel can be easily hidden, in addition, it is not the only
available interface layout and many more come in (MUFFIN!).
On the other hand, if a user uses the 16: 9 format it is because it is the most
useful, practical and that gives him more space to present the content and in
the end that is what is important.

> 2. users have easy access to switch to it in the sidebar

The same if default is 16:9 and you want to use another page format.

> 3. most of our templates arent 16:9

How could this be solved? Means that each template must have a file for each
page format (eg 4:3, 16:9, 16:10, etc.). Whatever the decision, the most
popular formats for users should be offered IMHO.

> 4. most other presentation apps havent switch over to it

As I mentioned above when opening the report, most other presentation
applications changed to 16:9 by default.

> 5. users who prefer 16:9 can easily create a 16:9 template as their default

That's right, but I do not think it's the way to see the problem. Why keep the
4: 3 format by default? More than being the most popular or used format (it is
not already) is a legacy format and in my case, I have a template 4.3 for these
cases (contrary to what you propose).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 109243] LO crashes after trying to execute a report in base

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109243

Xisco Faulí  changed:

   What|Removed |Added

 Resolution|FIXED   |NOTOURBUG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: ODF 9.1.12 purpose of element

[Regina Henschel]

Hi Luke,

thank you for pointing to the code.

Luke Deller schrieb:

Hi Regina

On 21/07/17 21:52, Regina Henschel wrote:

it seems to me, that the element  is useless.
Exists any situation where LibreOffice writes such element?


I can see only two places in the code which will emit this element:

1. A chart object (e.g. in a spreadsheet) contains a 
representing the data for the chart.  LibreOffice always emits
 for this table.


Indeed. I can generate it from scratch. Fortunately LibreOffice can read 
the chart too, if I remove the  element. So older 
versions would be able to read charts, if the element is removed in a 
newer version.




2. A database (odb) file can contain reports containing tables, which
will be emitted with .


I was not able to generate such document. I have tried it with report as 
text document, report as spreadsheet and with the old kind of reports 
from OOo2.4.3. I always have got only  elements.





What is the purpose of this element?


In both of these cases the  simply wraps all the
 elements, which looks redundant to me.


I think it is redundant. I consider to propose, that the element is 
removed or at least deprecated in ODF 1.3.

BTW, the OASIS-issues are
https://issues.oasis-open.org/browse/OFFICE-3839
https://issues.oasis-open.org/browse/OFFICE-3838


Kind regards
Regina



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 109243] LO crashes after trying to execute a report in base

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109243

juergen.burcha...@online.de  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from juergen.burcha...@online.de  
---
@Alex Thurgood:
Thanks a lot for your hint. I used kernel version 4.4.0-83 and turned back to
4.4.0-81 and the problem didn't occur any longer!
With best regards
Juergen

PS.: I'm 73 now and I wonder how we solved our problems without the net!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108529] Exported SVG does not appear when used in a browser

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108529

--- Comment #7 from Bonnie  ---
Hello Buovjaga, 

The link I previously sent is not relevant. It contains our internal software
references to the svg file and do not impact the image. 

Ultimately the new version contains details in the image that break the image.
If you need an example showing how the image does not work online please let me
know and I'll prepare one for you. 

Ultimately we can both agree the details in the format of the SVG has changed.

Bonnie


(In reply to Buovjaga from comment #6)
> Bonnie: I asked for an explanation for this:
> 
> (In reply to Bonnie from comment #3)
> > The reference that does not display an image is: 
> > 
> >  > src="F_HTML_FIREWALLseatmap?map=PB_TM_SEQ > field>=PB_SEQ_only=no=svg"/>
> > 
> > 
> > The reference that does display the image is: 
> > 
> >  > src="F_HTML_SEATMAP > field>_colour=007700_boundary=true_seat_border=5
> > ormat=svg"/>
> 
> Preferably attach your full HTML.
> 
> The Javascript cannot be simply removed. I tried it with
> 
> sed 

[Libreoffice-bugs] [Bug 109243] LO crashes after trying to execute a report in base

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109243

juergen.burcha...@online.de  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - sw/source

[Michael Stahl]

 sw/source/core/doc/DocumentContentOperationsManager.cxx |   18 +++-
 1 file changed, 13 insertions(+), 5 deletions(-)

New commits:
commit 62f4151683cc6bde8db61820aa581ad9073b0841
Author: Michael Stahl 
Date:   Fri Jul 21 23:01:37 2017 +0200

sw: it looks like MoveRange() is never called with

... Undo enabled; let's try if somebody finds a way and remove this
later if not.

Change-Id: I9bad32342b129743ecfecb26901857cc4c79a89d

diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx 
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index 7df812d1cdd5..1d56dc7bd004 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -1666,8 +1666,7 @@ DocumentContentOperationsManager::CopyRange( SwPaM& rPam, 
SwPosition& rPos, cons
 // Special case for handling an area with several nodes,
 // or a single node that is not a TextNode
 OSL_ENSURE( _rDoc == pDoc, " invalid copy branch!" );
-OSL_FAIL("mst: i thought this could be dead code;"
-"please tell me what you did to get here!");
+assert(!"mst: this is assumed to be dead code");
 pDoc->getIDocumentRedlineAccess().SetRedlineFlags_intern(eOld | 
RedlineFlags::Ignore);
 
 // Then copy the area to the underlying document area
@@ -2084,6 +2083,8 @@ bool DocumentContentOperationsManager::MoveRange( SwPaM& 
rPaM, SwPosition& rPos,
 pTNd = aSavePam.GetNode().GetTextNode();
 if (m_rDoc.GetIDocumentUndoRedo().DoesUndo())
 {
+assert(!"mst: this is assumed to be dead code");
+
 // correct the SavePam's Content first
 if( bNullContent )
 {
commit 850795942b3e168cab8ce88b4f2b421945ff29ca
Author: Michael Stahl 
Date:   Fri Jul 21 22:55:51 2017 +0200

tdf#99692 sw: fix bookmark positions in tables at start of redlines

The code assumes that if it can move the cursor backward in line 2038,
that move can be "inverted" by moving the cursor forward after the
content has been moved - but if the cursor moved back a node, and the
moved content does not start with a SwTextNode, the cursor will move
forward skipping over the non-text nodes, so offsets in the aSaveBkmks
(and aSaveRedl, presumably) are going to be wrong.

Just don't use Move() if it leaves the current node.

Change-Id: I95278a10c14aeba9f76558486bb2712f6726dbcb

diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx 
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index 57204ff80b5a..7df812d1cdd5 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -2033,12 +2033,19 @@ bool DocumentContentOperationsManager::MoveRange( 
SwPaM& rPaM, SwPosition& rPos,
 
 // Put back the Pam by one "content"; so that it's always outside of
 // the manipulated range.
-// If there's no content anymore, set it to the StartNode (that's
-// always there).
-const bool bNullContent = !aSavePam.Move( fnMoveBackward, GoInContent );
+// tdf#99692 don't Move() back if that would end up in another node
+// because moving backward is not necessarily the inverse of forward then.
+const bool bNullContent = aSavePam.GetPoint()->nContent == 0;
 if( bNullContent )
 {
 aSavePam.GetPoint()->nNode--;
+aSavePam.GetPoint()->nContent.Assign(aSavePam.GetContentNode(), 0);
+}
+else
+{
+bool const success(aSavePam.Move(fnMoveBackward, GoInContent));
+assert(success);
+(void) success;
 }
 
 // Copy all Bookmarks that are within the Move range into an array,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99692] FILEOPEN: Crash on opening odt with change tracking

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99692

Michael Stahl  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |mst...@redhat.com
   |desktop.org |

--- Comment #11 from Michael Stahl  ---
now fixed the root-cause of the invalid mark indexes on master,
as it was triggering an assert in sw::mark::AnnotationMark::InitDoc()

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107166] Text is invisible, both in UI and in editor on update to 5.3.2, older AMD and Intel GPUs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107166

--- Comment #88 from V Stuart Foote  ---
(In reply to Philippe_E from comment #87)
> I just tested
> libo-master64~2017-07-21_04.09.11_LibreOfficeDev_6.0.0.0.alpha0_Win_x64 and
> no text is visible... Does this version contain the correction?

Yes it does. So, need to verify some details about your system.

Does turning off the Direct3D Aero themes still clear this up for you? 

You are on Windows 7 SP1 right?  

Do you have the SP1 Platform Update installed?

KB2670838 --
https://support.microsoft.com/en-us/help/2670838/platform-update-for-windows-7-sp1-and-windows-server-2008-r2-sp1

What GPU and driver are you using?  Run msinfo32.exe and copy text from the
Summary and the Components/Display panels.

Might also post result of dxdiag.exe, a screen clip of both the system and
display panel(s).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108951] FILEOPEN: RTF: Custom bullets are displayed as standard bullets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108951

Miklos Vajna  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: icon-themes/sifr icon-themes/sifr_dark

[Yousuf Philips]

 0 files changed

New commits:
commit 37185c03e1d66c494b0da298b22aca557d8a3f3c
Author: Yousuf Philips 
Date:   Sat Jul 1 23:51:38 2017 +0400

tdf#106533 Correct insert index entry icon filename

Change-Id: I70ba9feb06056a7dbcf34ed1b533639be217833b
Reviewed-on: https://gerrit.libreoffice.org/39441
Tested-by: Jenkins 
Reviewed-by: Yousuf Philips 

diff --git a/icon-themes/sifr/cmd/32/insertindexentry.png 
b/icon-themes/sifr/cmd/32/insertindexesentry.png
similarity index 100%
rename from icon-themes/sifr/cmd/32/insertindexentry.png
rename to icon-themes/sifr/cmd/32/insertindexesentry.png
diff --git a/icon-themes/sifr/cmd/lc_insertindexentry.png 
b/icon-themes/sifr/cmd/lc_insertindexesentry.png
similarity index 100%
rename from icon-themes/sifr/cmd/lc_insertindexentry.png
rename to icon-themes/sifr/cmd/lc_insertindexesentry.png
diff --git a/icon-themes/sifr/cmd/sc_insertindexentry.png 
b/icon-themes/sifr/cmd/sc_insertindexesentry.png
similarity index 100%
rename from icon-themes/sifr/cmd/sc_insertindexentry.png
rename to icon-themes/sifr/cmd/sc_insertindexesentry.png
diff --git a/icon-themes/sifr_dark/cmd/32/insertindexentry.png 
b/icon-themes/sifr_dark/cmd/32/insertindexesentry.png
similarity index 100%
rename from icon-themes/sifr_dark/cmd/32/insertindexentry.png
rename to icon-themes/sifr_dark/cmd/32/insertindexesentry.png
diff --git a/icon-themes/sifr_dark/cmd/lc_insertindexentry.png 
b/icon-themes/sifr_dark/cmd/lc_insertindexesentry.png
similarity index 100%
rename from icon-themes/sifr_dark/cmd/lc_insertindexentry.png
rename to icon-themes/sifr_dark/cmd/lc_insertindexesentry.png
diff --git a/icon-themes/sifr_dark/cmd/sc_insertindexentry.png 
b/icon-themes/sifr_dark/cmd/sc_insertindexesentry.png
similarity index 100%
rename from icon-themes/sifr_dark/cmd/sc_insertindexentry.png
rename to icon-themes/sifr_dark/cmd/sc_insertindexesentry.png
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 89620] Compress image should remember settings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89620

Yousuf Philips (jay)  changed:

   What|Removed |Added

  Component|Draw|LibreOffice
 Blocks|100467  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100467
[Bug 100467] [META] Improve File handling in Draw
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109265] [META] Remember dialog's previous settings issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109265

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||c...@nouenoff.nl,
   ||tietze.he...@gmail.com,
   ||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100467] [META] Improve File handling in Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100467

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on|89620   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=89620
[Bug 89620] Compress image should remember settings
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102019] [META] Dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102019

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||109265


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109265
[Bug 109265] [META] Remember dialog's previous settings issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98544] Find & Replace dialog should remember the 'other options' state

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98544

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||109265


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109265
[Bug 109265] [META] Remember dialog's previous settings issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 98728] Remember last saved location

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98728

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||109265


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109265
[Bug 109265] [META] Remember dialog's previous settings issues
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 89620] Compress image should remember settings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89620

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||109265


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109265
[Bug 109265] [META] Remember dialog's previous settings issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98728] Remember last saved location

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98728

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||109265


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109265
[Bug 109265] [META] Remember dialog's previous settings issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109265] New: [META] Remember dialog's previous settings issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109265

Bug ID: 109265
   Summary: [META] Remember dialog's previous settings issues
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
Depends on: 89620, 98544, 98728
Blocks: 102019


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=89620
[Bug 89620] Compress image should remember settings
https://bugs.documentfoundation.org/show_bug.cgi?id=98544
[Bug 98544] Find & Replace dialog should remember the 'other options' state
https://bugs.documentfoundation.org/show_bug.cgi?id=98728
[Bug 98728] Remember last saved location
https://bugs.documentfoundation.org/show_bug.cgi?id=102019
[Bug 102019] [META] Dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46221] Simplify file open dialog file types list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46221

Yousuf Philips (jay)  changed:

   What|Removed |Added

Summary|Simplify file open dialog   |Simplify file open dialog
   ||file types list

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 53695] Native file dialogs do not expand environment variables

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=53695

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
 CC||philip...@hotmail.com
 Blocks|102732  |87860

--- Comment #4 from Yousuf Philips (jay)  ---
(In reply to Urmas from comment #0)
> It is not possible to use environment substitution, like %TEMP%, in native
> dialogs. That is very inconvenient.

I'm assuming you are referring to LO's native dialogs and as %TEMP% works fine
in the Windows' native dialogs.

As you mentioned %TEMP%, is this a Windows only bug as using ~/Desktop works
fine in LO's native dialogs on Linux.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=87860
[Bug 87860] [META] LibreOffice's file dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102732
[Bug 102732] [META] File dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87860] [META] LibreOffice's file dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87860

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||53695


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=53695
[Bug 53695] Native file dialogs do not expand environment variables
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102732] [META] File dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102732

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on|53695   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=53695
[Bug 53695] Native file dialogs do not expand environment variables
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93244] Widescreen aspect ratio (16:9) by default in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93244

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl,
   ||gautier.sop...@gmail.com,
   ||rb.hensc...@t-online.de,
   ||s.mehrbr...@gmail.com,
   ||vstuart.fo...@utsa.edu

--- Comment #5 from Yousuf Philips (jay)  ---
-1 for me, as

1. 16:9 leaves less space to work with when both the slide pane and the sidebar
are open
2. users have easy access to switch to it in the sidebar
3. most of our templates arent 16:9
4. most other presentation apps havent switch over to it
5. users who prefer 16:9 can easily create a 16:9 template as their default

Stuart, Cor, Samuel, Regina, Sophie: what is your take?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 93244] Widescreen aspect ratio (16:9) by default in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93244

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl,
   ||gautier.sop...@gmail.com,
   ||rb.hensc...@t-online.de,
   ||s.mehrbr...@gmail.com,
   ||vstuart.fo...@utsa.edu

--- Comment #5 from Yousuf Philips (jay)  ---
-1 for me, as

1. 16:9 leaves less space to work with when both the slide pane and the sidebar
are open
2. users have easy access to switch to it in the sidebar
3. most of our templates arent 16:9
4. most other presentation apps havent switch over to it
5. users who prefer 16:9 can easily create a 16:9 template as their default

Stuart, Cor, Samuel, Regina, Sophie: what is your take?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: 3 commits - hwpfilter/source include/vcl solenv/gbuild vcl/CppunitTest_vcl_mnemonic.mk vcl/Module_vcl.mk vcl/qa vcl/source

[Caolán McNamara]

 hwpfilter/source/hbox.cxx|1 
 include/vcl/mnemonic.hxx |   12 -
 solenv/gbuild/AllLangMoTarget.mk |   12 +++--
 vcl/CppunitTest_vcl_mnemonic.mk  |   49 +++
 vcl/Module_vcl.mk|1 
 vcl/qa/cppunit/mnemonic.cxx  |   42 +
 vcl/source/window/mnemonic.cxx   |   10 +++
 7 files changed, 113 insertions(+), 14 deletions(-)

New commits:
commit 5488ff0be8ec4625822428781298ffb76ea84041
Author: Caolán McNamara 
Date:   Fri Jul 21 20:07:41 2017 +0100

mnemonics in words with Eszett misplaced

because the text is normalized with toUpper and uppercase
ß is SS and using the insertion index of the normalized
string in the original string is out by one

if we normalize with toLower then according to
icu/source/data/unidata/SpecialCasing.txt
then as long as the language is not Lithuanian
its always one to one

so just normalize to lower case with blank locale

Change-Id: I0ad1c7e2ad0216b7c27ec62105f9a25672ade8a8

diff --git a/include/vcl/mnemonic.hxx b/include/vcl/mnemonic.hxx
index 26e4e5e15458..f531ab66d348 100644
--- a/include/vcl/mnemonic.hxx
+++ b/include/vcl/mnemonic.hxx
@@ -31,14 +31,14 @@
 #define MNEMONIC_RANGE_1_START  0x30
 #define MNEMONIC_RANGE_1_END0x39
 // Latin A-Z
-#define MNEMONIC_RANGE_2_START  0x41
-#define MNEMONIC_RANGE_2_END0x5A
+#define MNEMONIC_RANGE_2_START  0x61
+#define MNEMONIC_RANGE_2_END0x7A
 // Cyrillic
-#define MNEMONIC_RANGE_3_START  0x0410
-#define MNEMONIC_RANGE_3_END0x042F
+#define MNEMONIC_RANGE_3_START  0x0430
+#define MNEMONIC_RANGE_3_END0x044F
 // Greek
-#define MNEMONIC_RANGE_4_START  0x0391
-#define MNEMONIC_RANGE_4_END0x03AB
+#define MNEMONIC_RANGE_4_START  0x03B1
+#define MNEMONIC_RANGE_4_END0x03CB
 #define MNEMONIC_RANGES 4
 #define MAX_MNEMONICS   
((MNEMONIC_RANGE_1_END-MNEMONIC_RANGE_1_START+1)+\
  
(MNEMONIC_RANGE_2_END-MNEMONIC_RANGE_2_START+1)+\
diff --git a/vcl/CppunitTest_vcl_mnemonic.mk b/vcl/CppunitTest_vcl_mnemonic.mk
new file mode 100644
index ..15dc99e8f0a9
--- /dev/null
+++ b/vcl/CppunitTest_vcl_mnemonic.mk
@@ -0,0 +1,49 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_CppunitTest_CppunitTest,vcl_mnemonic))
+
+$(eval $(call gb_CppunitTest_set_include,vcl_mnemonic,\
+$$(INCLUDE) \
+-I$(SRCDIR)/vcl/inc \
+))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,vcl_mnemonic, \
+   vcl/qa/cppunit/mnemonic \
+))
+
+$(eval $(call gb_CppunitTest_use_externals,vcl_mnemonic,boost_headers))
+
+$(eval $(call gb_CppunitTest_use_libraries,vcl_mnemonic, \
+   comphelper \
+   cppu \
+   cppuhelper \
+   sal \
+   svt \
+   test \
+   tl \
+   tk \
+   unotest \
+   vcl \
+))
+
+$(eval $(call gb_CppunitTest_use_sdk_api,vcl_mnemonic))
+
+$(eval $(call gb_CppunitTest_use_ure,vcl_mnemonic))
+$(eval $(call gb_CppunitTest_use_vcl,vcl_mnemonic))
+
+$(eval $(call gb_CppunitTest_use_components,vcl_mnemonic,\
+   configmgr/source/configmgr \
+   i18npool/util/i18npool \
+   ucb/source/core/ucb1 \
+))
+
+$(eval $(call gb_CppunitTest_use_configuration,vcl_mnemonic))
+
+# vim: set noet sw=4 ts=4:
diff --git a/vcl/Module_vcl.mk b/vcl/Module_vcl.mk
index 218cae68efc1..15e9d77ca485 100644
--- a/vcl/Module_vcl.mk
+++ b/vcl/Module_vcl.mk
@@ -149,6 +149,7 @@ $(eval $(call gb_Module_add_check_targets,vcl,\
CppunitTest_vcl_complextext \
CppunitTest_vcl_filters_test \
CppunitTest_vcl_mapmode \
+   CppunitTest_vcl_mnemonic \
CppunitTest_vcl_outdev \
CppunitTest_vcl_app_test \
CppunitTest_vcl_jpeg_read_write_test \
diff --git a/vcl/qa/cppunit/mnemonic.cxx b/vcl/qa/cppunit/mnemonic.cxx
new file mode 100644
index ..1e5ec74c1ec8
--- /dev/null
+++ b/vcl/qa/cppunit/mnemonic.cxx
@@ -0,0 +1,42 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+#include 
+#include 
+
+#include 
+#include 
+
+#include 
+
+class VclMnemonicTest : public test::BootstrapFixture
+{
+public:
+VclMnemonicTest() : BootstrapFixture(true, false) {}
+
+void testMnemonic();
+
+CPPUNIT_TEST_SUITE(VclMnemonicTest);
+

[Libreoffice-bugs] [Bug 85811] [META] Main menu bar bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85811

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||84655


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=84655
[Bug 84655] FILESAVE: Add menu "Overwrite XYZ.png" in File menu if drawing  was
exported
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100467] [META] Improve File handling in Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100467
Bug 100467 depends on bug 84655, which changed state.

Bug 84655 Summary: FILESAVE: Add menu "Overwrite XYZ.png" in File menu if 
drawing  was exported
https://bugs.documentfoundation.org/show_bug.cgi?id=84655

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85811] [META] Main menu bar bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85811
Bug 85811 depends on bug 84655, which changed state.

Bug 84655 Summary: FILESAVE: Add menu "Overwrite XYZ.png" in File menu if 
drawing  was exported
https://bugs.documentfoundation.org/show_bug.cgi?id=84655

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84655] FILESAVE: Add menu "Overwrite XYZ.png" in File menu if drawing was exported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84655

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||philip...@hotmail.com
 Blocks||85811
 Resolution|--- |WONTFIX

--- Comment #4 from Yousuf Philips (jay)  ---
Yes this option in GIMP is highly used, as you'd open a PNG to modify it and
then have to export it as a PNG rather than saving it as XCF, but unlike GIMP,
LO has easy access to export in the standard toolbar and also has a large File
menu (23 items now), so adding another entry in the File menu isnt an option.

Please file another enhancement report about remembering the settings of the
export dialog.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=85811
[Bug 85811] [META] Main menu bar bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108364] [META] Table/Row/Column/ Cell management function bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108364

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||77001


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=77001
[Bug 77001] Calc slows down when selecting discontinuous rows
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108364] [META] Table/Row/Column/ Cell management function bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108364
Bug 108364 depends on bug 77001, which changed state.

Bug 77001 Summary: Calc slows down when selecting discontinuous rows
https://bugs.documentfoundation.org/show_bug.cgi?id=77001

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109263] Pastes incorrect content when copied content contains link while EDITING

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109263

--- Comment #1 from Kenny Kruger  ---
Created attachment 134776
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134776=edit
Example test case of copy/paste issue

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109264] New: Insert Audio or Video fails when file name contains a square bracket

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109264

Bug ID: 109264
   Summary: Insert Audio or Video fails when file name contains a
square bracket
   Product: LibreOffice
   Version: 5.3.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bugzi...@greycube.com

Steps to re-create:

- Launch Impress, start a new presentation, Insert, Audio or Video, and select
a file.

- If file name contains a single square bracket [ ] in the name, it will say
"The format of the selected file is not supported". The same file without
square brackets will import successfully.

- It affects both audio and video files, and the position of the square bracket
does not seem to matter. Other brackets such as curly braces and parenthesis
work fine.

- This issue can obviously lead you think the file is encoded wrongly or you
don't have the correct codecs.

- I have tested this on 3 different Windows 10 PCs, one of which was a fresh
install with no codec packs, so only native WMV support, and same issue occurs
when a square bracket was in the WMV file name.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/borderline2' - 328 commits - accessibility/AllLangMoTarget_acc.mk accessibility/AllLangResTarget_acc.mk accessibility/inc accessibility/Module_accessibi

[Armin Le Grand]

Rebased ref, commits from common ancestor:
commit f9427dc98be255af64a8c34c1e923680b3f9fe75
Author: Armin Le Grand 
Date:   Fri Jul 21 17:34:40 2017 +0200

borderline: first versionj with line end adaptions

Added usage of defined extensions to the BorderLinePrimitive,
also added a first version to detect all cuts with adjacent
borders and produce the correct extensions, for single and
double lines. Not completely happy with it, but a first
version

Change-Id: I4b12a6cc0a70278bd5c506e9b3b2c5c126930dad

diff --git a/drawinglayer/source/primitive2d/borderlineprimitive2d.cxx 
b/drawinglayer/source/primitive2d/borderlineprimitive2d.cxx
index 84ea9fff10ca..a9822d6bcd06 100644
--- a/drawinglayer/source/primitive2d/borderlineprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/borderlineprimitive2d.cxx
@@ -144,8 +144,8 @@ namespace drawinglayer
 // single line, only inside values used, no vertical 
offsets
 addPolygonStrokePrimitive2D(
 rContainer,
-getStart(),
-getEnd(),
+getStart() - (aVector * getExtendLeftStart()),
+getEnd() + (aVector * getExtendLeftEnd()),
 getRGBColorLeft(),
 getLeftWidth(),
 getStyle(),
diff --git a/svx/source/dialog/framelink.cxx b/svx/source/dialog/framelink.cxx
index c193285b1a25..de93c9372d88 100644
--- a/svx/source/dialog/framelink.cxx
+++ b/svx/source/dialog/framelink.cxx
@@ -345,6 +345,153 @@ double lcl_GetExtent(
 return nCut;
 }
 
+void getOffsetsFromStyle(const Style& rStyle, std::vector< double >& offsets)
+{
+if (rStyle.Prim())
+{
+if (rStyle.Dist() && rStyle.Secn())
+{
+// both lines used (or all three), push four values, from outer to 
inner
+switch (rStyle.GetRefMode())
+{
+case RefMode::Centered:
+{
+const double fHalfFullWidth(rStyle.GetWidth() * 0.5);
+offsets.push_back(-fHalfFullWidth);
+offsets.push_back(rStyle.Prim() - fHalfFullWidth);
+offsets.push_back((rStyle.Prim() + rStyle.Dist()) - 
fHalfFullWidth);
+offsets.push_back(fHalfFullWidth);
+break;
+}
+case RefMode::Begin:
+offsets.push_back(0.0);
+offsets.push_back(rStyle.Prim());
+offsets.push_back(rStyle.Prim() + rStyle.Dist());
+offsets.push_back(rStyle.GetWidth());
+break;
+default: // case RefMode::End:
+{
+const double fFullWidth(rStyle.GetWidth());
+offsets.push_back(-fFullWidth);
+offsets.push_back(rStyle.Prim() - fFullWidth);
+offsets.push_back((rStyle.Prim() + rStyle.Dist()) - 
fFullWidth);
+offsets.push_back(0.0);
+break;
+}
+}
+}
+else
+{
+// one line used, push two values, from outer to inner
+switch (rStyle.GetRefMode())
+{
+case RefMode::Centered:
+offsets.push_back(rStyle.Prim() * -0.5);
+offsets.push_back(rStyle.Prim() * 0.5);
+break;
+case RefMode::Begin:
+offsets.push_back(0.0);
+offsets.push_back(rStyle.Prim());
+break;
+default: // case RefMode::End:
+offsets.push_back(-rStyle.Prim());
+offsets.push_back(0.0);
+break;
+}
+}
+}
+}
+
+void compareToStyle(
+const basegfx::B2DPoint& rOrigin,
+const basegfx::B2DVector& rOtherVector,
+const basegfx::B2DVector& rOtherUnifiedPerpendicular,
+const std::vector< double >& rOtherOffsets,
+const Style& rStyle,
+const basegfx::B2DVector& rMyVector,
+std::vector< std::vector< double >>& rOtherCuts)
+{
+if (rStyle.Prim())
+{
+std::vector< double > myOffsets;
+
+// get offsets from outer to inner (two or four, depending on style)
+getOffsetsFromStyle(rStyle, myOffsets);
+
+if (!myOffsets.empty())
+{
+const basegfx::B2DVector 
aMyUnifiedPerpendicular(basegfx::getNormalizedPerpendicular(rMyVector));
+
+for (size_t a(0); a < rOtherOffsets.size(); a++)
+{
+const basegfx::B2DPoint aOtherPos(rOrigin + 
(rOtherUnifiedPerpendicular * rOtherOffsets[a]));
+
+for (size_t b(0); b < myOffsets.size(); b++)
+{
+const basegfx::B2DPoint aMyPos(rOrigin + 
(aMyUnifiedPerpendicular * myOffsets[b]));
+double fCut(0.0);
+basegfx::tools::findCut(
+aOtherPos,
+   

[Libreoffice-bugs] [Bug 109263] New: Pastes incorrect content when copied content contains link while EDITING

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109263

Bug ID: 109263
   Summary: Pastes incorrect content when copied content contains
link while EDITING
   Product: LibreOffice
   Version: 5.3.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kenneth.j.kru...@gmail.com

Description:
I have a spreadsheet which contains cells that have links to external files.
The cell would contain text and the link. If you select the cell and copy it,
it will paste correctly. However, if you 'enter' a cell and select just the
content you want to copy (text + link), then enter a new cell to paste the
content -- the link will be missing, but the text pasted.

Steps to Reproduce:
1. Edit cell contents, adding the following content.
   "Words -> "
   Where words are normal text along with the -> arrow
   Where  is short text and links to a file to open
2. Edit difference cell's contents, pasting the clipboard
3. Notice the pasted content is only, "Words ->" -- no link or link text

Actual Results:  
Pasted content was, "Words ->"

Expected Results:
Pasted content to be, "Words -> "


Reproducible: Always

User Profile Reset: No

Additional Info:
I am able to reproduce the issue on other computers (same OS and architecture,
different user profiles)


User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/59.0.3071.115 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109262] New: exception at app.cxx:2060

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109262

Bug ID: 109262
   Summary: exception at app.cxx:2060
   Product: LibreOffice
   Version: 6.0.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lo_b...@iseries-guru.com

Created attachment 134775
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134775=edit
example spreadsheet

STR
---

( 1) Set your macro security level (Tools > Options > LibreOfficeDev >
 Security > "Macro Security") to Medium.

( 2) Optionally download attached test3.ods to /tmp/ and skip ahead to
 step (10).

( 3) Create new empty spreadsheet.

( 4) Take menu options Tools > Macros > "Organize Macros" >
 "LibreOfficeDev Basic...".  Program presents window
 "LibreOfficeDev Macros".

( 5) In pane "Macro From", click "Untitled 1" and then click .
 Program presents dialog "New Module" with default Name "Module 1".

( 6) In dialog "New Macro", click .  Program displays window
 "Untitled 1.Standard - LibreOfficeDev Basic 6.0".  In source pane
 observe line 3 "Sub Main" and line 5 "End Sub".

( 7) File > Close.  Program returns focus to window "Untitled 1 -
 LibreOfficeDev Calc 6.0".

( 8) Save the spreadsheet as /tmp/test3.ods.

( 9) Close LibreOffice.

(10) Run LibreOffice from the command line with parameters
 --script-cat /tmp/test3.ods

 Expected: I am not sure, as I have never actually seen output
   from this option.

 Observed:  Terminal output includes
UNO exception during client open: 
Application Error
Fatal exception: Signal 6
followed by a stack trace.

Note that the behaviour of Writer is exactly parallel to Calc.

I observe this on debian-stretch with daily Linux dbgutil bibisect
repository version 2017-07-21 and in a local build of commit 4b7b93be
(2017-07-05).

Experimentation in gdb shows that the message comes from
desktop/source/app/app.cxx:2074; the try block starts at line 2045.  A
`step` command at line 2060 -- "OpenClients(); -- transfers control
directly to the catch block.  The exception then is

$1 = (const com::sun::star::uno::Exception &) @0x58c7d510:
{ Message = ""
, Context = uno::Reference to
(basic::SfxScriptLibrary *) 0x58c7a9b0
}

Funnily enough, an attempt to backtrace from the catch block displays
two stack frames, and then gdb pegs one CPU.

Further work in the daily dbgutil bibisect repository shows that the
exception entered LibreOffice at about the same time as parameter
--script-cat, somewhere in the day before commit

2017-06-10: source-hash-076ed447f694239d5c67adee528ea6e471d909ff

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107817] [META] Impress UI/UX bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107817

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||93087


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=93087
[Bug 93087] New layouts for LO Impress
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93087] New layouts for LO Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93087

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||107817


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107817
[Bug 107817] [META] Impress UI/UX bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 93087] New layouts for LO Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93087

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||107817


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107817
[Bug 107817] [META] Impress UI/UX bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 78671] FILEOPEN: DOCX - Textbox that should appear on a page of its own is appearing overlapping text on the second page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78671

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
Version|4.2.4.2 release |Inherited From OOo

--- Comment #10 from Yousuf Philips (jay)  ---
So LO incorrectly renders the first page of attachment 134773 which has the
textbox, but if the textbox is removed as in attachment 134774, LO correctly
renders the first page.

Version: 6.0.0.0.alpha0+
Build ID: e0bafa78e3ad0df397d78cd65ad19bd5b07dc5f2
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78671] FILEOPEN: DOCX - Textbox that should appear on a page of its own is appearing overlapping text on the second page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78671

Yousuf Philips (jay)  changed:

   What|Removed |Added

  Attachment #98992|0   |1
is obsolete||

--- Comment #9 from Yousuf Philips (jay)  ---
Created attachment 134774
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134774=edit
sample doc with the removal of the textbox

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78671] FILEOPEN: DOCX - Textbox that should appear on a page of its own is appearing overlapping text on the second page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78671

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Attachment #134754|0   |1
is obsolete||

--- Comment #8 from Yousuf Philips (jay)  ---
Created attachment 134773
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134773=edit
sample doc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109261] Crash in: rtl_uString_acquire

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109261

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||9052

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109052] Crash in: mergedlo.dll (see comment 3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109052

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||9261

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93087] New layouts for LO Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93087

--- Comment #5 from Bastián Díaz  ---
(In reply to Heiko Tietze from comment #4)
> Don't see much advantage of it- whitespace is your friend.

I agree with you, however, the idea is not to impose a certain workflow to all
users and in practice a blank slide is one more layout, so having more options
will make the process easier for many users. Especially it would be good to
include some proposals for Notes and Handout, which are printable and very
useful options.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100135] SVG: svgOpen filter looses text and labeling, svgInsert filter not honoring mask or clip-path in rendering a simple plot graphic

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100135

--- Comment #9 from V Stuart Foote  ---
@Xisco, labeling seems OK now, should this be duped to one of the earlier SVG
clip path issues? E.g. bug 97657 or bug 90168

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97657] INSERT: SVG clippath mask not supported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97657

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=90
   ||168

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90168] FILEOPEN: SVG doesn't import clipPath element

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90168

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=97
   ||657

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94038] Right-click menu is empty when playing video

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94038

--- Comment #14 from Telesto  ---
No repro with:
Version: 6.0.0.0.alpha0+
Build ID: a9588baca8137f51e2ca72e40b1f448b0e1885d1
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-07-21_02:58:26
Locale: nl-NL (nl_NL); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109256] SVG written by Matplotlib is not displayed correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109256

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |DUPLICATE

--- Comment #5 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 100135 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100135] SVG: svgOpen filter looses text and labeling, svgInsert filter not honoring mask or clip-path in rendering a simple plot graphic

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100135

V Stuart Foote  changed:

   What|Removed |Added

 CC||petr_aleksand...@mail.ru

--- Comment #8 from V Stuart Foote  ---
*** Bug 109256 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109261] Crash in: rtl_uString_acquire

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109261

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||8889

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108889] Crash: When editing a document which is opened at the moment of setting the undo count to zero (0)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108889

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||9261

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109261] Crash in: rtl_uString_acquire

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109261

Telesto  changed:

   What|Removed |Added

   Severity|critical|normal

--- Comment #1 from Telesto  ---
Oops, forgot one essential step
Step 3b. Set the Undo count to zero (0). Menu -> Tools -> Options - Advanced ->
Open expert configuration: Set the undo count from 100 (default) to zero
(https://help.libreoffice.org/Common/Memory#Number_of_undo_steps)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109261] New: Crash in: rtl_uString_acquire

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109261

Bug ID: 109261
   Summary: Crash in: rtl_uString_acquire
   Product: LibreOffice
   Version: 4.4.6.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: critical
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

This bug was filed from the crash reporting server and is
br-de6c4a1c-2076-4ab2-ab3e-8942f59f6137.
=
1. Download a WMV file:
http://www.educationalquestions.com/video/DLP_PART_2_768k.wmv
2. Open Impress
3. Cancel the Template Dialog
4. Select the slide pane and add a slide
5. Click the video button on the second slide
6. Import the downloaded video -> Crash

7. No crash when using Insert -> Audio/Video

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 108928] Branding for 6.0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108928

--- Comment #22 from Heiko Tietze  ---
(In reply to V Stuart Foote from comment #21)
> Noticed with recent Windows builds of master, that the loading progress bar
> has shifted positing into the middle of the banner. Not sure if that was
> from resizing the banner, or if the anchor has shifted.

That was my fault. Will resize the banner next week.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 108928] Branding for 6.0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108928

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #21 from V Stuart Foote  ---
@Heiko, * 

Noticed with recent Windows builds of master, that the loading progress bar has
shifted positing into the middle of the banner. Not sure if that was from
resizing the banner, or if the anchor has shifted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 109259] FILESAVE: ODS vs XLS conditional formating

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109259

--- Comment #1 from Daniel Mondot  ---
Let me correct my earlier report.

I believe the change of color from green to yellow was probably due to using
"percentile" (which behavior I do not fully understand) instead of using
"Value".
When I use "value", there is no change of color.

So, it come down to losing conditional formatting when saving in specific
format:

When I save in .XLS, .UOS, >ODS or .DIF formats, the conditional formatting is
just completely lost.
When I save in .ODS format, it is only partially lost, if multiple consecutive
cells have the same format, only the first cell in each line shows that
formatting after reloading the file.
Example:
Lets say I have a color scale formatting on cell C403, and I duplicate it to
cells C403:N434, all the cells will show that color formatting.
If I go to Conditional Formatting > Manage, there is listing only for the cells
of column C.
There I can edit the entries and change it to say C403:N434
And only if I do that, when I save and reload the file, all the cells will have
the proper formatting.
So it's not really a problem of saving/restoring under .ODS format, but rather
that the information about the cells was wrong.

As proof of that, before I manually change the range of cells for a particular
conditional formatting, if I copy let's say column #2 to column 30, then column
30 will have no special formatting.

So, I believe the problem lies when I copy the formatting of a cell to a group
of cells spanning more than 1 column and more than 1 row.
If I copy a cell to more cells in the same column, it works
if I copy a column to multiple adjacent columns it works
but copying A1 to B2:F9 doesn't work, it only "appears" to work, as the cells
will be displayed correctly, but If I go to Formatting > Manage, I will see
that only the cells B2:B9 will have the formatting, and not C1:F9
So, if I save the file and reload it, the formatting of C1:F9 will appear to
have disappeared.

I hope this clarifies everything.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/comphelper oox/source sd/source

[Jan Holesovsky]

 include/comphelper/propertysequence.hxx  |7 +---
 oox/source/ppt/pptimport.cxx |2 -
 sd/source/core/CustomAnimationPreset.cxx |   10 +++---
 sd/source/ui/func/fuhhconv.cxx   |   11 +++---
 sd/source/ui/slidesorter/cache/SlsCacheConfiguration.cxx |   23 --
 sd/source/ui/tools/ConfigurationAccess.cxx   |   24 +--
 6 files changed, 29 insertions(+), 48 deletions(-)

New commits:
commit c23cc5d7551a0ed0e3dad2d33dd00b38643456a1
Author: Jan Holesovsky 
Date:   Fri Jul 21 15:11:02 2017 +0200

Rename InitAnySequence -> InitAnyPropertySequence, and convert some callers.

Change-Id: I410fef49679360f3308ec0f00bb032a2de0d7931
Reviewed-on: https://gerrit.libreoffice.org/40282
Tested-by: Jenkins 
Reviewed-by: Jan Holesovsky 

diff --git a/include/comphelper/propertysequence.hxx 
b/include/comphelper/propertysequence.hxx
index 6af3bb389929..c384edb2848d 100644
--- a/include/comphelper/propertysequence.hxx
+++ b/include/comphelper/propertysequence.hxx
@@ -14,7 +14,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 namespace comphelper
@@ -36,18 +35,18 @@ namespace comphelper
 return vResult;
 }
 
-/// Init list for property sequences that wrap the NamedValues in Anys.
+/// Init list for property sequences that wrap the PropertyValues in Anys.
 ///
 /// This is particularly useful for creation of sequences that are later
 /// unwrapped using comphelper::SequenceAsHashMap.
-inline css::uno::Sequence< css::uno::Any > InitAnySequence(
+inline css::uno::Sequence< css::uno::Any > InitAnyPropertySequence(
 ::std::initializer_list< ::std::pair< OUString, css::uno::Any > > 
vInit)
 {
 css::uno::Sequence 
vResult{static_cast(vInit.size())};
 size_t nCount{0};
 for(const auto& aEntry : vInit)
 {
-vResult[nCount] <<= css::beans::NamedValue(aEntry.first, 
aEntry.second);
+vResult[nCount] <<= css::beans::PropertyValue(aEntry.first, -1, 
aEntry.second, css::beans::PropertyState_DIRECT_VALUE);
 ++nCount;
 }
 return vResult;
diff --git a/oox/source/ppt/pptimport.cxx b/oox/source/ppt/pptimport.cxx
index 446a054ffd91..4f7b4ea41e08 100644
--- a/oox/source/ppt/pptimport.cxx
+++ b/oox/source/ppt/pptimport.cxx
@@ -219,7 +219,7 @@ sal_Bool SAL_CALL PowerPointImport::filter( const Sequence< 
PropertyValue >& rDe
 
 if (isExportFilter())
 {
-uno::Sequence aArguments(comphelper::InitAnySequence(
+uno::Sequence aArguments(comphelper::InitAnyPropertySequence(
 {
 {"IsPPTM", uno::makeAny(exportVBA())},
 }));
diff --git a/sd/source/core/CustomAnimationPreset.cxx 
b/sd/source/core/CustomAnimationPreset.cxx
index 502ed08a6bb5..2163676af665 100644
--- a/sd/source/core/CustomAnimationPreset.cxx
+++ b/sd/source/core/CustomAnimationPreset.cxx
@@ -34,6 +34,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -67,11 +68,10 @@ static Reference< XNameAccess > getNodeAccess( const 
Reference< XMultiServiceFac
 
 try
 {
-Sequence< Any > aArgs( 1 );
-PropertyValue   aPropValue;
-aPropValue.Name  = "nodepath";
-aPropValue.Value <<= rNodePath;
-aArgs[0] <<= aPropValue;
+Sequence aArgs(comphelper::InitAnyPropertySequence(
+{
+{"nodepath", uno::Any(rNodePath)}
+}));
 
 xConfigAccess.set(
 xConfigProvider->createInstanceWithArguments( 
"com.sun.star.configuration.ConfigurationAccess", aArgs ),
diff --git a/sd/source/ui/func/fuhhconv.cxx b/sd/source/ui/func/fuhhconv.cxx
index bb471096812a..f3179f84bb69 100644
--- a/sd/source/ui/func/fuhhconv.cxx
+++ b/sd/source/ui/func/fuhhconv.cxx
@@ -23,6 +23,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -203,12 +204,10 @@ void FuHangulHanjaConversion::StartChineseConversion()
 {
 //  initialize dialog
 Reference< awt::XWindow > xDialogParentWindow(nullptr);
-Sequence aSeq(1);
-Any* pArray = aSeq.getArray();
-PropertyValue aParam;
-aParam.Name = "ParentWindow";
-aParam.Value <<= xDialogParentWindow;
-pArray[0] <<= aParam;
+Sequence aSeq(comphelper::InitAnyPropertySequence(
+{
+{"ParentWindow", uno::Any(xDialogParentWindow)}
+}));
 xInit->initialize( aSeq );
 
 //execute dialog
diff --git a/sd/source/ui/slidesorter/cache/SlsCacheConfiguration.cxx 
b/sd/source/ui/slidesorter/cache/SlsCacheConfiguration.cxx
index 1e8765830c6f..8bb01e4b7bbb 100644
--- a/sd/source/ui/slidesorter/cache/SlsCacheConfiguration.cxx
+++ 

[Libreoffice-commits] core.git: sd/qa

[Jan Holesovsky]

 sd/qa/unit/data/pptm/macro.pptm|binary
 sd/qa/unit/export-tests-ooxml2.cxx |   32 
 sd/qa/unit/sdmodeltestbase.hxx |9 ++---
 3 files changed, 38 insertions(+), 3 deletions(-)

New commits:
commit 71ab0b8b8368b5010d3af4100d5ea3ca38b725a5
Author: Jan Holesovsky 
Date:   Fri Jul 21 11:45:36 2017 +0200

sd pptm: Unit tests for the .pptm support.

Change-Id: Ie0d05e70fe2b0869470a1750d5b60566f129247b
Reviewed-on: https://gerrit.libreoffice.org/40268
Tested-by: Jenkins 
Reviewed-by: Jan Holesovsky 

diff --git a/sd/qa/unit/data/pptm/macro.pptm b/sd/qa/unit/data/pptm/macro.pptm
new file mode 100755
index ..54e81db2a07b
Binary files /dev/null and b/sd/qa/unit/data/pptm/macro.pptm differ
diff --git a/sd/qa/unit/export-tests-ooxml2.cxx 
b/sd/qa/unit/export-tests-ooxml2.cxx
index f310309d0bf2..848ea8f5d1a4 100644
--- a/sd/qa/unit/export-tests-ooxml2.cxx
+++ b/sd/qa/unit/export-tests-ooxml2.cxx
@@ -98,6 +98,8 @@ public:
 void testTdf59046();
 void testTdf105739();
 void testPageBitmapWithTransparency();
+void testPptmContentType();
+void testPptmVBAStream();
 
 CPPUNIT_TEST_SUITE(SdOOXMLExportTest2);
 
@@ -123,6 +125,8 @@ public:
 CPPUNIT_TEST(testTdf59046);
 CPPUNIT_TEST(testTdf105739);
 CPPUNIT_TEST(testPageBitmapWithTransparency);
+CPPUNIT_TEST(testPptmContentType);
+CPPUNIT_TEST(testPptmVBAStream);
 
 CPPUNIT_TEST_SUITE_END();
 
@@ -804,6 +808,34 @@ void SdOOXMLExportTest2::testPageBitmapWithTransparency()
 xDocShRef->DoClose();
 }
 
+void SdOOXMLExportTest2::testPptmContentType()
+{
+::sd::DrawDocShellRef xDocShRef = 
loadURL(m_directories.getURLFromSrc("sd/qa/unit/data/pptm/macro.pptm"), PPTM);
+utl::TempFile tempFile;
+xDocShRef = saveAndReload(xDocShRef.get(), PPTM, );
+
+// Assert that the content type is the one of PPTM
+xmlDocPtr pXmlContentType = parseExport(tempFile, "[Content_Types].xml");
+assertXPath(pXmlContentType,
+
"/ContentType:Types/ContentType:Override[@PartName='/ppt/presentation.xml']",
+"ContentType",
+
"application/vnd.ms-powerpoint.presentation.macroEnabled.main+xml");
+
+xDocShRef->DoClose();
+}
+
+void SdOOXMLExportTest2::testPptmVBAStream()
+{
+::sd::DrawDocShellRef xDocShRef = 
loadURL(m_directories.getURLFromSrc("sd/qa/unit/data/pptm/macro.pptm"), PPTM);
+utl::TempFile tempFile;
+xDocShRef = saveAndReload(xDocShRef.get(), PPTM, );
+
+uno::Reference xNameAccess = 
packages::zip::ZipFileAccess::createWithURL(comphelper::getComponentContext(m_xSFactory),
 tempFile.GetURL());
+// This failed: VBA stream was not roundtripped
+CPPUNIT_ASSERT(xNameAccess->hasByName("ppt/vbaProject.bin"));
+
+xDocShRef->DoClose();
+}
 
 CPPUNIT_TEST_SUITE_REGISTRATION(SdOOXMLExportTest2);
 
diff --git a/sd/qa/unit/sdmodeltestbase.hxx b/sd/qa/unit/sdmodeltestbase.hxx
index 80f6693f568c..51cb204f76b4 100644
--- a/sd/qa/unit/sdmodeltestbase.hxx
+++ b/sd/qa/unit/sdmodeltestbase.hxx
@@ -58,6 +58,7 @@ struct FileFormat
 #define FODG_FORMAT_TYPE  (SfxFilterFlags::STARONEFILTER | SfxFilterFlags::OWN 
| SfxFilterFlags::IMPORT | SfxFilterFlags::EXPORT)
 #define FODP_FORMAT_TYPE  (SfxFilterFlags::STARONEFILTER | SfxFilterFlags::OWN 
| SfxFilterFlags::IMPORT | SfxFilterFlags::EXPORT)
 #define SXI_FORMAT_TYPE  (SfxFilterFlags::IMPORT | SfxFilterFlags::TEMPLATE | 
SfxFilterFlags::OWN | SfxFilterFlags::ALIEN | SfxFilterFlags::PREFERED | 
SfxFilterFlags::ENCRYPTION)
+#define PPTM_FORMAT_TYPE ( SfxFilterFlags::IMPORT | SfxFilterFlags::EXPORT | 
SfxFilterFlags::ALIEN | SfxFilterFlags::STARONEFILTER | 
SfxFilterFlags::PREFERED )
 
 /** List of file formats we support in Impress unit tests.
 
@@ -74,10 +75,11 @@ FileFormat aFileFormats[] =
 { "pptx", "Impress Office Open XML", "Office Open XML Presentation", "", 
PPTX_FORMAT_TYPE },
 { "html", "graphic_HTML", "graphic_HTML", "", HTML_FORMAT_TYPE },
 { "pdf",  "draw_pdf_import", "pdf_Portable_Document_Format", "", 
PDF_FORMAT_TYPE },
-{ "fodg",  "OpenDocument Drawing Flat XML", "Flat XML ODF Drawing", "", 
FODG_FORMAT_TYPE },
-{ "fodp",  "OpenDocument Presentation Flat XML", "Flat XML ODF 
Presentation", "", FODP_FORMAT_TYPE },
+{ "fodg", "OpenDocument Drawing Flat XML", "Flat XML ODF Drawing", "", 
FODG_FORMAT_TYPE },
+{ "fodp", "OpenDocument Presentation Flat XML", "Flat XML ODF 
Presentation", "", FODP_FORMAT_TYPE },
 { "sxi",  "StarOffice XML (Impress)", "OpenOffice.org 1.0 Presentation", 
"", SXI_FORMAT_TYPE },
 { "odg",  "draw8", "draw8", "", ODP_FORMAT_TYPE },
+{ "pptm", "Impress MS PowerPoint 2007 XML VBA", "MS PowerPoint 2007 XML 
VBA", "", PPTM_FORMAT_TYPE },
 { nullptr, nullptr, nullptr, nullptr, SfxFilterFlags::NONE }
 };
 
@@ -88,8 +90,9 @@ FileFormat aFileFormats[] =
 #define PDF  4
 #define FODG 5
 #define FODP 6
-#define 

[Libreoffice-commits] core.git: oox/source sd/source

[Jan Holesovsky]

 oox/source/ppt/presentationfragmenthandler.cxx |   37 +
 sd/source/filter/eppt/epptooxml.hxx|3 ++
 sd/source/filter/eppt/pptx-epptooxml.cxx   |   35 ++-
 3 files changed, 63 insertions(+), 12 deletions(-)

New commits:
commit ee6f8f1982d666f8fcda96d2141a9332a10b8273
Author: Jan Holesovsky 
Date:   Wed Jul 19 16:35:10 2017 +0200

sd pptm: Preserve the VBA stream on export.

This actually implements the reading of the VBA stream in Impress too, so 
the
user will get a warning when opening such a file (that the it contains
macros).

Change-Id: I1638199529196ed217cbd9ebef88eb7c88f2179a
Reviewed-on: https://gerrit.libreoffice.org/40197
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 
Reviewed-on: https://gerrit.libreoffice.org/40267
Tested-by: Jenkins 
Reviewed-by: Jan Holesovsky 

diff --git a/oox/source/ppt/presentationfragmenthandler.cxx 
b/oox/source/ppt/presentationfragmenthandler.cxx
index a41284c3177f..4ef9ea282dea 100644
--- a/oox/source/ppt/presentationfragmenthandler.cxx
+++ b/oox/source/ppt/presentationfragmenthandler.cxx
@@ -27,6 +27,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -34,16 +35,18 @@
 #include 
 #include 
 
-#include "oox/drawingml/theme.hxx"
-#include "oox/drawingml/drawingmltypes.hxx"
-#include "oox/drawingml/themefragmenthandler.hxx"
-#include "drawingml/textliststylecontext.hxx"
+#include 
+#include 
+#include 
+#include 
 #include 
-#include "oox/ppt/pptshape.hxx"
-#include "oox/ppt/presentationfragmenthandler.hxx"
-#include "oox/ppt/slidefragmenthandler.hxx"
-#include "oox/ppt/layoutfragmenthandler.hxx"
-#include "oox/ppt/pptimport.hxx"
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
 #include 
 #include 
 
@@ -394,8 +397,8 @@ void PresentationFragmentHandler::finalizeImport()
 StringRangeEnumerator aRangeEnumerator( aPageRange, 0, nPageCount - 1 );
 StringRangeEnumerator::Iterator aIter = aRangeEnumerator.begin();
 StringRangeEnumerator::Iterator aEnd  = aRangeEnumerator.end();
-if(aIter!=aEnd) {
-
+if (aIter!=aEnd)
+{
 // todo: localized progress bar text
 const Reference< task::XStatusIndicator >& rxStatusIndicator( 
getFilter().getStatusIndicator() );
 if ( rxStatusIndicator.is() )
@@ -424,6 +427,18 @@ void PresentationFragmentHandler::finalizeImport()
 if ( rxStatusIndicator.is() )
 rxStatusIndicator->end();
 }
+
+// open the VBA project storage
+OUString aVbaFragmentPath = 
getFragmentPathFromFirstType(CREATE_MSOFFICE_RELATION_TYPE("vbaProject"));
+if (!aVbaFragmentPath.isEmpty())
+{
+uno::Reference xInStrm = 
getFilter().openInputStream(aVbaFragmentPath);
+if (xInStrm.is())
+{
+StorageRef xPrjStrg(new 
oox::ole::OleStorage(getFilter().getComponentContext(), xInStrm, false));
+getFilter().getVbaProject().importVbaProject(*xPrjStrg);
+}
+}
 }
 
 // CT_Presentation
diff --git a/sd/source/filter/eppt/epptooxml.hxx 
b/sd/source/filter/eppt/epptooxml.hxx
index cc60f76d8089..aa27ad8adf19 100644
--- a/sd/source/filter/eppt/epptooxml.hxx
+++ b/sd/source/filter/eppt/epptooxml.hxx
@@ -157,6 +157,9 @@ private:
 AuthorsMap maAuthors;
 
 void WriteAuthors();
+
+/// If this is PPTM, output the VBA stream.
+void WriteVBA();
 };
 
 }
diff --git a/sd/source/filter/eppt/pptx-epptooxml.cxx 
b/sd/source/filter/eppt/pptx-epptooxml.cxx
index c359859358a6..ebf122d8a34c 100644
--- a/sd/source/filter/eppt/pptx-epptooxml.cxx
+++ b/sd/source/filter/eppt/pptx-epptooxml.cxx
@@ -28,12 +28,14 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -55,6 +57,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -69,6 +72,7 @@
 
 #include 
 #include 
+#include 
 #include 
 
 // presentation namespaces
@@ -399,6 +403,8 @@ bool PowerPointExport::exportDocument()
 
 WriteAuthors();
 
+WriteVBA();
+
 mPresentationFS->endElementNS( XML_p, XML_presentation );
 mPresentationFS.reset();
 // Free all FSHelperPtr, to flush data before committing storage
@@ -1439,7 +1445,8 @@ void PowerPointExport::WriteAuthors()
 
 sal_Int32 PowerPointExport::GetAuthorIdAndLastIndex( const OUString& sAuthor, 
sal_Int32& nLastIndex )
 {
-if ( maAuthors.count( sAuthor ) <= 0 ) {
+if (maAuthors.count(sAuthor) <= 0)
+{
 struct AuthorComments aAuthorComments;
 
 aAuthorComments.nId = maAuthors.size();
@@ -1513,6 +1520,32 @@ bool PowerPointExport::WriteComments( sal_uInt32 
nPageNum )
 return false;
 }
 
+void PowerPointExport::WriteVBA()
+{
+if (!mbPptm)
+return;
+
+uno::Reference 

[Libreoffice-commits] core.git: desktop/source

[Jan Holesovsky]

 desktop/source/lib/init.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit f7c3dafac4545c99e3ea4e469c23f7c7b7359807
Author: Jan Holesovsky 
Date:   Wed Jul 19 08:46:22 2017 +0200

lok: Add docm/xlsm/pptm filters to be known by LOK.

Change-Id: I4995498132b832ce783efc9740f1d7129f085a01
Reviewed-on: https://gerrit.libreoffice.org/40196
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 
Reviewed-on: https://gerrit.libreoffice.org/40266
Tested-by: Jenkins 
Reviewed-by: Jan Holesovsky 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 36aca9643248..be81a0fca0b0 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -117,6 +117,7 @@ typedef struct
 static const ExtensionMap aWriterExtensionMap[] =
 {
 { "doc",   "MS Word 97" },
+{ "docm",  "MS Word 2007 XML VBA" },
 { "docx",  "MS Word 2007 XML" },
 { "fodt",  "OpenDocument Text Flat XML" },
 { "html",  "HTML (StarWriter)" },
@@ -139,6 +140,7 @@ static const ExtensionMap aCalcExtensionMap[] =
 { "pdf",   "calc_pdf_Export" },
 { "xhtml", "XHTML Calc File" },
 { "xls",   "MS Excel 97" },
+{ "xlsm",  "Calc MS Excel 2007 VBA XML" },
 { "xlsx",  "Calc MS Excel 2007 XML" },
 { "png",   "calc_png_Export" },
 { nullptr, nullptr }
@@ -154,6 +156,7 @@ static const ExtensionMap aImpressExtensionMap[] =
 { "pdf",   "impress_pdf_Export" },
 { "potm",  "Impress MS PowerPoint 2007 XML Template" },
 { "pot",   "MS PowerPoint 97 Vorlage" },
+{ "pptm",  "Impress MS PowerPoint 2007 XML VBA" },
 { "pptx",  "Impress MS PowerPoint 2007 XML" },
 { "pps",   "MS PowerPoint 97 Autoplay" },
 { "ppt",   "MS PowerPoint 97" },
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: filter/Configuration_filter.mk filter/source oox/source sd/source sd/util

[Jan Holesovsky]

 filter/Configuration_filter.mk
|2 
 filter/source/config/fragments/filters/impress_MS_PowerPoint_2007_XML.xcu 
|2 
 filter/source/config/fragments/filters/impress_MS_PowerPoint_2007_XML_VBA.xcu 
|   30 +++
 filter/source/config/fragments/types/MS_PowerPoint_2007_XML.xcu   
|2 
 filter/source/config/fragments/types/MS_PowerPoint_2007_XML_VBA.xcu   
|   28 +++
 oox/source/core/filterdetect.cxx  
|6 
 oox/source/ppt/pptimport.cxx  
|   18 +-
 sd/source/filter/eppt/epptooxml.hxx   
|9 -
 sd/source/filter/eppt/pptx-epptooxml.cxx  
|   77 ++
 sd/source/ui/docshell/docshel4.cxx
|5 
 sd/util/sdfilt.component  
|2 
 11 files changed, 110 insertions(+), 71 deletions(-)

New commits:
commit 5d0901a75e7ef96dc722b5277450cc18ad163f7b
Author: Jan Holesovsky 
Date:   Wed Jul 19 08:42:36 2017 +0200

sd pptm: Add a separate PPTM filter.

Similarly to commit 697173f6fdfae581022cfdb5ec5171c5a3be58f0, we have to
preserve the correct content-type which is not the same for PPTX and PPTM.

This commit also changes sdfilt.component to use the constructor feature.

Change-Id: I4b334540ec07a53d308e6b9dd6403294842bddf8
Reviewed-on: https://gerrit.libreoffice.org/40195
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 
Reviewed-on: https://gerrit.libreoffice.org/40265
Tested-by: Jenkins 
Reviewed-by: Jan Holesovsky 

diff --git a/filter/Configuration_filter.mk b/filter/Configuration_filter.mk
index 0ed0d6170419..c39e5e03aba7 100644
--- a/filter/Configuration_filter.mk
+++ b/filter/Configuration_filter.mk
@@ -597,6 +597,7 @@ $(eval $(call 
filter_Configuration_add_types,fcfg_langpack,fcfg_impress_types.xc
MS_PowerPoint_2007_XML \
MS_PowerPoint_2007_XML_AutoPlay \
MS_PowerPoint_2007_XML_Template \
+   MS_PowerPoint_2007_XML_VBA \
impress_OOXML_Presentation \
impress_OOXML_Presentation_Template \
impress_OOXML_Presentation_AutoPlay \
@@ -622,6 +623,7 @@ $(eval $(call 
filter_Configuration_add_filters,fcfg_langpack,fcfg_impress_filter
impress_MS_PowerPoint_2007_XML \
impress_MS_PowerPoint_2007_XML_AutoPlay \
impress_MS_PowerPoint_2007_XML_Template \
+   impress_MS_PowerPoint_2007_XML_VBA \
impress_OOXML \
impress_OOXML_Template \
impress_OOXML_AutoPlay \
diff --git 
a/filter/source/config/fragments/filters/impress_MS_PowerPoint_2007_XML.xcu 
b/filter/source/config/fragments/filters/impress_MS_PowerPoint_2007_XML.xcu
index 8814d1e4413d..08d17d688a3b 100644
--- a/filter/source/config/fragments/filters/impress_MS_PowerPoint_2007_XML.xcu
+++ b/filter/source/config/fragments/filters/impress_MS_PowerPoint_2007_XML.xcu
@@ -27,4 +27,4 @@
 
 Microsoft PowerPoint 2007-2013 XML
 
-
+
diff --git 
a/filter/source/config/fragments/filters/impress_MS_PowerPoint_2007_XML_VBA.xcu 
b/filter/source/config/fragments/filters/impress_MS_PowerPoint_2007_XML_VBA.xcu
new file mode 100644
index ..3f52eea5eea8
--- /dev/null
+++ 
b/filter/source/config/fragments/filters/impress_MS_PowerPoint_2007_XML_VBA.xcu
@@ -0,0 +1,30 @@
+
+
+IMPORT EXPORT ALIEN 3RDPARTYFILTER PREFERRED 
ENCRYPTION PASSWORDTOMODIFY SUPPORTSSIGNING
+
+com.sun.star.comp.oox.ppt.PowerPointImport
+macro-enabled
+
+MS PowerPoint 2007 XML VBA
+
+com.sun.star.presentation.PresentationDocument
+
+Microsoft PowerPoint 2007-2013 XML VBA
+
+
diff --git a/filter/source/config/fragments/types/MS_PowerPoint_2007_XML.xcu 
b/filter/source/config/fragments/types/MS_PowerPoint_2007_XML.xcu
index b709d6b8804d..5c3fdc2e4c31 100644
--- a/filter/source/config/fragments/types/MS_PowerPoint_2007_XML.xcu
+++ b/filter/source/config/fragments/types/MS_PowerPoint_2007_XML.xcu
@@ -18,7 +18,7 @@
 
 com.sun.star.comp.oox.FormatDetector
 
-pptx pptm
+pptx
 application/vnd.openxmlformats-officedocument.presentationml.presentation
 true
 Impress MS PowerPoint 2007 
XML
diff --git 
a/filter/source/config/fragments/types/MS_PowerPoint_2007_XML_VBA.xcu 
b/filter/source/config/fragments/types/MS_PowerPoint_2007_XML_VBA.xcu
new file mode 100644
index ..4e4519f29794
--- /dev/null
+++ b/filter/source/config/fragments/types/MS_PowerPoint_2007_XML_VBA.xcu
@@ -0,0 +1,28 @@
+
+
+
+com.sun.star.comp.oox.FormatDetector
+
+pptm
+application/vnd.ms-powerpoint.presentation.macroEnabled.main+xml
+true
+Impress MS PowerPoint 2007 XML 
VBA
+Microsoft PowerPoint 

[Libreoffice-bugs] [Bug 83066] [META] CJK issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83066

kong  changed:

   What|Removed |Added

 Depends on||109260


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109260
[Bug 109260] Double-lined text shifted not same value as normal text
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106045] [META] Vertical text direction issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106045

kong  changed:

   What|Removed |Added

 Depends on||109260


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109260
[Bug 109260] Double-lined text shifted not same value as normal text
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109260] Double-lined text shifted not same value as normal text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109260

kong  changed:

   What|Removed |Added

   Keywords||text:cjk, text:rtl
 Blocks||83066, 106045


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83066
[Bug 83066] [META] CJK issues
https://bugs.documentfoundation.org/show_bug.cgi?id=106045
[Bug 106045] [META] Vertical text direction issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109254] [FEATURE] VLOOKUP is using dynamic array when created with Function Wizard

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109254

--- Comment #4 from Jacques Guilleron  ---
Criterion can be used as name for E2:E120 and to replace the first argument.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109007] crash pressing either "Insert Special Character" button standard toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109007

--- Comment #3 from V Stuart Foote  ---

On Windows builds, both UI buttons assert same fault.

https://opengrok.libreoffice.org/xref/core/include/vcl/builder.hxx#410

The button widget for the old dialog from uno:InsertSymbol using cui
(cuilo.dll), and the new split button for the GSOC uno:CharmapControl via sfx
(sfxlo.dll).

The warning dialog aborts at
https://opengrok.libreoffice.org/xref/core/desktop/source/app/officeipcthread.cxx#946

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109260] Double-lined text shifted not same value as normal text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109260

--- Comment #4 from kong  ---
Created attachment 134772
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134772=edit
vertical . shifted , and different style (double-lined and normal) different
shifting.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109260] Double-lined text shifted not same value as normal text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109260

--- Comment #3 from kong  ---
Created attachment 134771
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134771=edit
horizontal . no problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109260] Double-lined text shifted not same value as normal text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109260

--- Comment #2 from kong  ---
Created attachment 134770
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134770=edit
Test Document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Eike Rathke]

 sw/source/core/fields/flddat.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7b0607aa7d42e3ea4c1623d65b124970abc04d79
Author: Eike Rathke 
Date:   Fri Jul 21 17:17:27 2017 +0200

Initializing Date with an arbitrary day count is nonsense

It works here because Date is ignored and only Time is returned, so just 
init
empty. The original value was a double date.time since null date.

Change-Id: If420769464860481416b0da172ddd2e17c13e641

diff --git a/sw/source/core/fields/flddat.cxx b/sw/source/core/fields/flddat.cxx
index a611e088eb36..a8c0b6457594 100644
--- a/sw/source/core/fields/flddat.cxx
+++ b/sw/source/core/fields/flddat.cxx
@@ -152,7 +152,7 @@ tools::Time SwDateTimeField::GetTime() const
 {
 double fDummy;
 double fFract = modf(GetValue(), );
-DateTime aDT(Date(static_cast(fDummy)));
+DateTime aDT( DateTime::EMPTY );
 aDT.AddTime(fFract);
 return static_cast(aDT);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 109260] Double-lined text shifted not same value as normal text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109260

--- Comment #1 from kong  ---
The system i selected is Linux because @gabix , in the Ask system , said
Windows is no problem. I'm just only using Linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: extensions/source include/tools sc/source sfx2/source sw/inc sw/source tools/source writerfilter/source xmlsecurity/source

[Eike Rathke]

 extensions/source/propctrlr/standardcontrol.cxx   |4 ++--
 include/tools/datetime.hxx|8 +---
 include/tools/time.hxx|8 
 sc/source/filter/excel/xlroot.cxx |2 +-
 sfx2/source/doc/objcont.cxx   |2 +-
 sw/inc/docufld.hxx|2 +-
 sw/source/core/fields/flddat.cxx  |4 ++--
 sw/source/uibase/docvw/AnnotationWin2.cxx |2 +-
 tools/source/datetime/datetime.cxx|9 -
 writerfilter/source/dmapper/DomainMapper_Impl.cxx |4 ++--
 xmlsecurity/source/dialogs/certificateviewer.cxx  |4 ++--
 11 files changed, 21 insertions(+), 28 deletions(-)

New commits:
commit 252aab1b9dc1dbeace3087929a52e1248f043839
Author: Eike Rathke 
Date:   Fri Jul 21 13:32:10 2017 +0200

Eliminate DateTime::operator+=() and -=() with POD types

And make some tools::Time conversion ctors explicit to catch more oddities 
like
automatic conversion from sal_Int64 that might be unintentional.

Change-Id: If275297d86d6657544c056a712b862523e310e44
Reviewed-on: https://gerrit.libreoffice.org/40275
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/extensions/source/propctrlr/standardcontrol.cxx 
b/extensions/source/propctrlr/standardcontrol.cxx
index 8381a7abad88..f566a8483eb5 100644
--- a/extensions/source/propctrlr/standardcontrol.cxx
+++ b/extensions/source/propctrlr/standardcontrol.cxx
@@ -298,13 +298,13 @@ namespace pcr
 
 // add the "days" part
 double nDays = floor( nValue );
-aDateTime += nDays;
+aDateTime.AddDays( nDays );
 
 // add the "time" part
 double nTime = nValue - nDays;
 nTime = ::rtl::math::round( nTime * 86400.0 ) / 86400.0;
 // we're not interested in 100th seconds, and this here 
prevents rounding errors
-aDateTime += nTime;
+aDateTime.AddTime( nTime );
 
 util::DateTime aUNODateTime;
 ::utl::typeConvert( aDateTime, aUNODateTime );
diff --git a/include/tools/datetime.hxx b/include/tools/datetime.hxx
index 8d224dd73633..fd48e2314c27 100644
--- a/include/tools/datetime.hxx
+++ b/include/tools/datetime.hxx
@@ -80,13 +80,7 @@ public:
 voidConvertToUTC()   { *this -= Time::GetUTCOffset(); }
 voidConvertToLocalTime() { *this += Time::GetUTCOffset(); }
 
-DateTime&   operator +=( sal_Int32 nDays )
-{ AddDays( nDays ); return *this; }
-DateTime&   operator -=( sal_Int32 nDays )
-{ AddDays( -nDays ); return *this; }
-DateTime&   operator +=( double fTimeInDays );
-DateTime&   operator -=( double fTimeInDays )
-{ return operator+=( -fTimeInDays ); }
+voidAddTime( double fTimeInDays );
 DateTime&   operator +=( const tools::Time& rTime );
 DateTime&   operator -=( const tools::Time& rTime );
 
diff --git a/include/tools/time.hxx b/include/tools/time.hxx
index 12f1e909c8ec..d8b4e6d06fc6 100644
--- a/include/tools/time.hxx
+++ b/include/tools/time.hxx
@@ -64,13 +64,13 @@ public:
 static const sal_Int64 nanoPerMilli  = 100;
 static const sal_Int64 nanoPerCenti  = 1000;
 
-Time( TimeInitEmpty )
+explicit Time( TimeInitEmpty )
 { nTime = 0; }
-Time( TimeInitSystem );
-Time( sal_Int64 _nTime ) { Time::nTime = _nTime; }
+explicit Time( TimeInitSystem );
+explicit Time( sal_Int64 _nTime ) { Time::nTime = _nTime; }
 Time( const tools::Time& rTime );
 Time( const css::util::Time& rTime );
-Time( const css::util::DateTime& rDateTime );
+explicit Time( const css::util::DateTime& rDateTime );
 Time( sal_uInt32 nHour, sal_uInt32 nMin,
   sal_uInt32 nSec = 0, sal_uInt64 nNanoSec = 0 );
 
diff --git a/sc/source/filter/excel/xlroot.cxx 
b/sc/source/filter/excel/xlroot.cxx
index 72b1450a5084..2e9588b6e769 100644
--- a/sc/source/filter/excel/xlroot.cxx
+++ b/sc/source/filter/excel/xlroot.cxx
@@ -339,7 +339,7 @@ DateTime XclRoot::GetDateTimeFromDouble( double fValue ) 
const
 DateTime aDateTime = GetNullDate() + fValue;
 // adjust dates before 1900-03-01 to get correct time values
 if( aDateTime < DateTime( Date( 1, 3, 1900 ) ) )
-aDateTime += sal_Int32(1);
+aDateTime.AddDays(1);
 return aDateTime;
 }
 
diff --git a/sfx2/source/doc/objcont.cxx b/sfx2/source/doc/objcont.cxx
index ef8425a224fd..41d8869d811e 100644
--- a/sfx2/source/doc/objcont.cxx
+++ b/sfx2/source/doc/objcont.cxx
@@ -259,7 +259,7 @@ void 

Re: ODF 9.1.12 purpose of element

[Luke Deller]

Hi Regina

On 21/07/17 21:52, Regina Henschel wrote:
it seems to me, that the element  is useless. 
Exists any situation where LibreOffice writes such element?


I can see only two places in the code which will emit this element:

1. A chart object (e.g. in a spreadsheet) contains a  
representing the data for the chart.  LibreOffice always emits 
 for this table.


2. A database (odb) file can contain reports containing tables, which 
will be emitted with .



What is the purpose of this element?


In both of these cases the  simply wraps all the 
 elements, which looks redundant to me.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: +1 developer

[Áron Budea]

Hi Kartikey, 

Welcome! Please see the following introductory wiki page that
should help you get started:
https://wiki.documentfoundation.org/Development/GetInvolved
Good luck!

Cheers,
Aron

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Awami Nastaliq and LibreOffice for Pakistan

[Martin Hosken]

Dear All,

I realise this is a bit of a sales pitch, but it's a mutual benefit pitch.

SIL's Awami Nastaliq font has just been released 
http://software.sil.org/awami/release-1-000. This is a nastaliq Arabic font 
that, in combination with LibreOffice (since it's Graphite only) makes 
LibreOffice the most powerful accessible word processing system for not just 
Urdu but all the languages of Pakistan that use nastaliq.

So if you are of know of users in that region, please let them know that they 
now have the capability to produce nice looking text for free!

BTW the font also works in FireFox. So you can put up webpages with it too.

Yours,
Martin
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 109260] New: Double-lined text shifted not same value as normal text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109260

Bug ID: 109260
   Summary: Double-lined text shifted not same value as normal
text
   Product: LibreOffice
   Version: 5.3.4.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: riverkong...@gmail.com

Created attachment 134769
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134769=edit
What's difference of the problem between this issue and others.

That's two issue . 
one is text shifted ( but same way , same verctor value ) , that was talked
about in #101679. when i checked the #106045 , i also found #105178 and #105650
appear in 5.3.4.2 version on Fedora 26.
the other one is some text not shifted the same way.Double-lined text don't
shift , but normal text shifted.

So i asked a question here :
https://ask.libreoffice.org/en/question/112394/writerhow-to-fix-wrong-characters-position-in-vertical-text-direction/
:

Everything is perfect in horizontal text direction . If change to vertical text
direction ( Format -> Page -> Page -> Text direction -> Right-to-left
(vertical) ) , the asian characters are floating out the right place.Read the
following two images , the asian text content with ( paragraph ) black border
is never changed , just only set the text direction from horizontal to
vertical.


--
Version: 5.3.4.2
Build ID: 5.3.4.2-3.fc26
CPU Threads: 2; OS Version: Linux 4.11; UI Render: default; VCL: gtk3; Layout
Engine: new; 
Locale: en-GB (en_GB.utf8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: messages mentor...@libreoffice.org being returned

[Eike Rathke]

Hi Jim,

On Thursday, 2017-07-20 09:39:12 -0800, Jim Raykowski wrote:

> When sending to mentor...@libreoffice.org it returns

Where did you see that address? Afaik the correct alias is
mentor...@documentfoundation.org

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Care about Free Software, support the FSFE https://fsfe.org/support/?erack


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: LibreOffice Error during make command

[Eike Rathke]

Hi,

On Thursday, 2017-07-20 09:58:22 +0200, Michael Stahl wrote:

> but the email that is sent to the libreoffice list from nabble.com
> clearly does not contain the error message, so it is very confusing!
> 
> clearly this is a bug in the nabble.com software?  very unhelpful to
> send mails that miss the most critical parts!

Nabble nibbles attachments from mails it sends to the list. It might be
just too dumb to properly create MIME mails, I heard more than once that
it doesn't do that and there's nothing we could do. Likely it's one of
their means to direct traffic to nabble archives to display more ads.

To me Nabble is a read-only medium.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Care about Free Software, support the FSFE https://fsfe.org/support/?erack


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] minutes of ESC call ...

[Eike Rathke]

Hi,

On Friday, 2017-07-21 14:27:11 +0200, Markus Mohrhard wrote:

> So my suggestion would be that we all try to write a few lines in a mail
> when we have committed something that can/should be used by more developers.
> 
> What do you think?

I completely agree.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Care about Free Software, support the FSFE https://fsfe.org/support/?erack


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 109257] EDITING UI Drawing interface is very slow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109257

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||5500

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||9257

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91306] ODF export: Page number 0 (zero) cannot be stored - filed OASIS proposal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91306

Timur  changed:

   What|Removed |Added

Summary|ODF export: Page number 0   |ODF export: Page number 0
   |cannot be stored|(zero) cannot be stored -
   ||filed OASIS proposal

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107360] No Access connection (Windows)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107360

--- Comment #5 from Timur  ---
Please also add which driver you're using. Like in 
https://bugs.documentfoundation.org/show_bug.cgi?id=43187#c14

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109150] EDITING Writer freezes when document is editet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109150

Timur  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=10 |
   |9123|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109123] UI is locked after formula/chart insert

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109123

Timur  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=10 |
   |9150|

--- Comment #11 from Timur  ---
Looking at duplicates here, are some other related? 
Bug 108005 and those in Seel Also.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs