[Libreoffice-commits] core.git: bin/update

2017-08-03 Thread Markus Mohrhard 
 bin/update/create_partial_update.py |   31 +--
 bin/update/uncompress_mar.py|7 ---
 2 files changed, 21 insertions(+), 17 deletions(-)

New commits:
commit e74846af5130daa9c96babea6987befeb8a8e75c
Author: Markus Mohrhard 
Date:   Fri Aug 4 07:23:26 2017 +0200

updater: get the partial update generation working on windows

Change-Id: I01d8958801e7c5b2d08dd79b0469dfab1f6dee72
Reviewed-on: https://gerrit.libreoffice.org/40757
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/bin/update/create_partial_update.py 
b/bin/update/create_partial_update.py
index aa5a119166db..e4005d5173a9 100755
--- a/bin/update/create_partial_update.py
+++ b/bin/update/create_partial_update.py
@@ -13,10 +13,10 @@ from uncompress_mar import extract_mar
 from tools import get_file_info, get_hash
 from signing import sign_mar_file
 
-from path import UpdaterPath, mkdir_p
+from path import UpdaterPath, mkdir_p, convert_to_unix, convert_to_native
 
 BUF_SIZE = 1024
-current_dir_path = os.path.dirname(os.path.realpath(__file__))
+current_dir_path = os.path.dirname(os.path.realpath(convert_to_unix(__file__)))
 
 def InvalidFileException(Exception):
 
@@ -126,24 +126,27 @@ def main():
 for build, update in updates.items():
 file_name = generate_file_name(build_id, build, mar_name_prefix)
 mar_file = os.path.join(update_dir, file_name)
-subprocess.call([os.path.join(current_dir_path, 
'make_incremental_update.sh'), mar_file, update["complete"], 
current_build_path])
+subprocess.call([os.path.join(current_dir_path, 
'make_incremental_update.sh'), convert_to_native(mar_file), 
convert_to_native(update["complete"]), convert_to_native(current_build_path)])
 sign_mar_file(update_dir, config, mar_file, mar_name_prefix)
 
 partial_info = {"file":get_file_info(mar_file, config.base_url), 
"from": build, "to": build_id, "languages": {}}
-for lang, lang_info in update["languages"].items():
-lang_name = generate_lang_file_name(build_id, build, 
mar_name_prefix, lang)
 
-# write the file into the final directory
-lang_mar_file = os.path.join(update_dir, lang_name)
+# on Windows we don't use language packs
+if sys.platform != "cygwin":
+for lang, lang_info in update["languages"].items():
+lang_name = generate_lang_file_name(build_id, build, 
mar_name_prefix, lang)
 
-# the directory of the old language file is of the form
-# 
workdir/mar/language/en-US/LibreOffice___archive_langpack_/
-language_dir = add_single_dir(os.path.join(mar_dir, "language", 
lang))
-subprocess.call([os.path.join(current_dir_path, 
'make_incremental_update.sh'), lang_mar_file, lang_info, language_dir])
-sign_mar_file(update_dir, config, lang_mar_file, mar_name_prefix)
+# write the file into the final directory
+lang_mar_file = os.path.join(update_dir, lang_name)
 
-# add the partial language info
-partial_info["languages"][lang] = get_file_info(lang_mar_file, 
config.base_url)
+# the directory of the old language file is of the form
+# 
workdir/mar/language/en-US/LibreOffice___archive_langpack_/
+language_dir = add_single_dir(os.path.join(mar_dir, 
"language", lang))
+subprocess.call([os.path.join(current_dir_path, 
'make_incremental_update.sh'), convert_to_native(lang_mar_file), 
convert_to_native(lang_info), convert_to_native(language_dir)])
+sign_mar_file(update_dir, config, lang_mar_file, 
mar_name_prefix)
+
+# add the partial language info
+partial_info["languages"][lang] = get_file_info(lang_mar_file, 
config.base_url)
 
 data["partials"].append(partial_info)
 
diff --git a/bin/update/uncompress_mar.py b/bin/update/uncompress_mar.py
index 4c5f40733d41..cecb16af0e6c 100755
--- a/bin/update/uncompress_mar.py
+++ b/bin/update/uncompress_mar.py
@@ -13,17 +13,18 @@
 import os
 import sys
 import subprocess
+from path import convert_to_native
 
 def uncompress_content(file_path):
 bzip2 = os.environ.get('BZIP2', 'bzip2')
 file_path_compressed = file_path + ".bz2"
 os.rename(file_path, file_path_compressed)
-subprocess.check_call(["bzip2", "-d", file_path_compressed])
+subprocess.check_call(["bzip2", "-d", 
convert_to_native(file_path_compressed)])
 
 def extract_mar(mar_file, target_dir):
 mar = os.environ.get('MAR', 'mar')
-subprocess.check_call([mar, "-C", target_dir, "-x", mar_file])
-file_info = subprocess.check_output([mar, "-t", mar_file])
+subprocess.check_call([mar, "-C", convert_to_native(target_dir), "-x", 
convert_to_native(mar_file)])
+file_info = subprocess.check_output([mar,

[Libreoffice-bugs] [Bug 111318] Improve message about pivot table/chart when removing a cell

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111318

--- Comment #6 from Julien Nabet  ---
(In reply to Pedro from comment #5)
> How about
> "Deleting this cell(s) will also remove the whole pivot table and associated
> pivot
> charts. Do you want to proceed?"
The problem is the plural of "this cell" is "these cells", so "(s)" isn't
sufficient.
That's why I used "This action"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=83946

Aron Budea  changed:

   What|Removed |Added

 Depends on||109267


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109267
[Bug 109267] Assertion failed when undoing delete inside redline insert
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105537] [META] Assertion failed crashes

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=105537

Aron Budea  changed:

   What|Removed |Added

 Depends on||109267


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109267
[Bug 109267] Assertion failed when undoing delete inside redline insert
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109267] Assertion failed when undoing delete inside redline insert

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=109267

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest,|
   |haveBacktrace, regression   |
 CC||ba...@caesar.elte.hu
 Blocks||105537, 83946
Summary|Crash when undoing delete   |Assertion failed when
   |inside redline insert   |undoing delete inside
   ||redline insert
 OS|Windows (All)   |All

--- Comment #3 from Aron Budea  ---
Yes, it's an assert. Removing regression-related keywords, since it's not a
confirmed regression, and it's hard to check (though it's possible with daily
dbgutil bibisect repo in Linux).

Xisco, is it correct the Linux build you tested with wasn't a debug build?

My Win build failed at the same point as bug 109997, but it's a few days old,
the bug might be gone (the other bug report is still open, though).


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83946
[Bug 83946] [META] Tracking changes issues
https://bugs.documentfoundation.org/show_bug.cgi?id=105537
[Bug 105537] [META] Assertion failed crashes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111325] Adding a watermark automatically adds a page header

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111325

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||jbfa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #2 from Jean-Baptiste Faure  ---
Reproducible with LO 5.4.1.0.0+ built at home under Ubuntu 16.04 x86-64.
Header creation is not visible on the screencast on the blog post by Szymon
cited in the 5.4 release notes
(https://eszkadev.blogspot.fr/2017/06/watermark-for-libreoffice-writer.html).
So I guess it is no intended then it is a bug.

Set to NEW.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111328] New: fileopen .cwk display garbage

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111328

Bug ID: 111328
   Summary: fileopen .cwk display garbage
   Product: LibreOffice
   Version: unspecified
  Hardware: ARM
OS: Android
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kris...@grrlz.net

Description:
clarisworks .cwk file displays garbage on all alpha versions of libreoffice
viewer

Steps to Reproduce:
download and open clarisworks sample.cwk attachment 111839


Actual Results:  
display garbage

Expected Results:
display content

test result:
5.0.0.0.alpha1+-ab465b9 garbage
5.1.0.0.alpha1+1a6ec13 garbage
5.1.0.0.alpha1+-5b791ec garbage
5.2.0.0.alpha0+-f6a74ce garbage
5.3.0.0.alpha1+-4136757 garbage

os: android 5.1
device: lyf flame 3 [ ls-4001 ]


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Android 5.1; Mobile; rv:56.0) Gecko/56.0 Firefox/56.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109851] FILESAVE: ODT: image misplaced after roundtrip

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=109851

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bisected
 CC||ba...@caesar.elte.hu,
   ||vmik...@collabora.co.uk
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=98
   ||987

--- Comment #3 from Aron Budea  ---
Bibisected to the following commit using bibisect-win32-5.2. Adding Cc: to
Miklos Vajna, please take a look sometimes.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=50223ea6e212b60b7d33839c2753c5601fb50f95
author  Miklos Vajna   2016-03-31 13:05:48
(GMT)
committer   Miklos Vajna   2016-03-31 17:49:00
(GMT)

"tdf#98987 sw: add AddVerticalFrameOffsets compat mode"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: bin/update

2017-08-03 Thread Markus Mohrhard 
 bin/update/tools.py |4 
 1 file changed, 4 insertions(+)

New commits:
commit 71b0d8b89d4701fcf1d22e2baf1ef5d983bc10d5
Author: Markus Mohrhard 
Date:   Thu Aug 3 00:19:55 2017 +0200

updater: initial working on windows support for mar file generation

Change-Id: Ia91724afbb258c7667dd18e76a32be24bff369ef
Reviewed-on: https://gerrit.libreoffice.org/40753
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/bin/update/tools.py b/bin/update/tools.py
index 5a3e34521b40..1e14f793cceb 100644
--- a/bin/update/tools.py
+++ b/bin/update/tools.py
@@ -1,5 +1,6 @@
 import os
 import hashlib
+import zipfile
 import tarfile
 
 def uncompress_file_to_dir(compressed_file, uncompress_dir):
@@ -16,6 +17,9 @@ def uncompress_file_to_dir(compressed_file, uncompress_dir):
 tar.extractall(uncompress_dir)
 tar.close()
 elif extension == '.zip':
+zip_file = zipfile.ZipFile(compressed_file)
+zip_file.extractall(uncompress_dir)
+zip_file.close()
 pass
 else:
 print("Error: unknown extension " + extension)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 3 commits - bin/update Makefile.gbuild

2017-08-03 Thread Markus Mohrhard 
 Makefile.gbuild|4 +++-
 bin/update/common.sh   |   17 +
 bin/update/create_full_mar.py  |   10 +-
 bin/update/make_full_update.sh |1 +
 bin/update/path.py |   19 ++-
 bin/update/signing.py  |3 ++-
 6 files changed, 46 insertions(+), 8 deletions(-)

New commits:
commit e4420db1a80fc53e23eafcd6b1dfe1aca293d60f
Author: Markus Mohrhard 
Date:   Fri Aug 4 05:29:53 2017 +0200

updater: skip language packs for windows

Change-Id: I5707bc8d3827aa24a795e91a8851d12c81613cfc
Reviewed-on: https://gerrit.libreoffice.org/40756
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/Makefile.gbuild b/Makefile.gbuild
index 61df1425314a..a55bc5ffd4a7 100644
--- a/Makefile.gbuild
+++ b/Makefile.gbuild
@@ -34,7 +34,9 @@ create-update-info:
rm -rf $(UPDATE_DIR) || true
mkdir -p $(MAR_DIR)/language
MAR=$(INSTDIR)/program/mar $(SRCDIR)/bin/update/create_full_mar.py 
"$(PRODUCTNAME)" "$(WORKDIR)" "$(MAR_NAME_PREFIX)" "$(UPDATE_CONFIG)"
-   MAR=$(INSTDIR)/program/mar 
$(SRCDIR)/bin/update/create_full_mar_for_languages.py "$(PRODUCTNAME)" 
"$(WORKDIR)" "$(MAR_NAME_PREFIX)" "$(UPDATE_CONFIG)"
+   $(if $(filter WNT,$(OS)),, \
+   MAR=$(INSTDIR)/program/mar 
$(SRCDIR)/bin/update/create_full_mar_for_languages.py "$(PRODUCTNAME)" 
"$(WORKDIR)" "$(MAR_NAME_PREFIX)" "$(UPDATE_CONFIG)" \
+   )
 
 upload-update-info:
$(eval BUILDID := $(shell git -C $(SRCDIR) log -1 --format=%H))
commit 1878dac5e1a839bd4c07cae0f85cf62dd7474e45
Author: Markus Mohrhard 
Date:   Fri Aug 4 05:11:58 2017 +0200

updater: handle windows path in cygwin correctly

This is a huge mess. Any windows executable does not understand
cygwin paths but for example the bash script only understands unix paths.

Additionally, os.path is unixpath so it is not able to correctly handle
windows paths. We therefore convert everything that we need to handle
to unix paths and only the few paths that are passed in the end to windows
executables back to the native format. We selected mixed mode
(windows path with forward slash) to allow the unix scripts to manipulate
paths.

Change-Id: Ic443415ff5e8277bf0bb8704bbafd35f50767288
Reviewed-on: https://gerrit.libreoffice.org/40755
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/bin/update/create_full_mar.py b/bin/update/create_full_mar.py
index 38919542d6a4..48686be21e45 100755
--- a/bin/update/create_full_mar.py
+++ b/bin/update/create_full_mar.py
@@ -8,9 +8,9 @@ import json
 from tools import uncompress_file_to_dir, get_file_info, make_complete_mar_name
 from config import parse_config
 from signing import sign_mar_file
-from path import UpdaterPath
+from path import UpdaterPath, convert_to_unix, convert_to_native
 
-current_dir_path = os.path.dirname(os.path.realpath(__file__))
+current_dir_path = os.path.dirname(os.path.realpath(convert_to_unix(__file__)))
 
 def main():
 if len(sys.argv) < 5:
@@ -34,14 +34,14 @@ def main():
 
 config = parse_config(update_config)
 
-tar_dir = os.path.join(workdir, "installation", product_name, "archive", 
"install", "en-US")
+tar_dir = os.path.join(update_path.get_workdir(), "installation", 
product_name, "archive", "install", "en-US")
 tar_file = os.path.join(tar_dir, os.listdir(tar_dir)[0])
 
 uncompress_dir = uncompress_file_to_dir(tar_file, temp_dir)
 
 mar_file = make_complete_mar_name(target_dir, filename_prefix)
-subprocess.call([os.path.join(current_dir_path, 'make_full_update.sh'), 
mar_file, uncompress_dir])
-
+path = os.path.join(current_dir_path, 'make_full_update.sh')
+subprocess.call([path, convert_to_native(mar_file), 
convert_to_native(uncompress_dir)])
 
 sign_mar_file(target_dir, config, mar_file, filename_prefix)
 
diff --git a/bin/update/path.py b/bin/update/path.py
index 1bc14d70d940..0fe0fd5eb04f 100644
--- a/bin/update/path.py
+++ b/bin/update/path.py
@@ -9,6 +9,8 @@
 
 import os
 import errno
+import subprocess
+from sys import platform
 
 def mkdir_p(path):
 try:
@@ -19,10 +21,22 @@ def mkdir_p(path):
 else:
 raise
 
+def convert_to_unix(path):
+if platform == "cygwin":
+return subprocess.check_output(["cygpath", "-u", 
path]).decode("utf-8", "strict").rstrip()
+else:
+return path
+
+def convert_to_native(path):
+if platform == "cygwin":
+return subprocess.check_output(["cygpath", "-m", 
path]).decode("utf-8", "strict").rstrip()
+else:
+return path
+
 class UpdaterPath(object):
 
 def __init__(self, workdir):
-self._workdir = workdir
+self._workdir = convert_to_unix(workdir)

[Libreoffice-bugs] [Bug 91999] FILESAVE: Shapes Rotated 180 Moved on Round-Trip

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=91999

Luke  changed:

   What|Removed |Added

   Keywords|filter:docx |bisected, regression
Version|unspecified |4.2.8.2 release

--- Comment #7 from Luke  ---
Version: 4.2.8.2 correctly exports the test file, while 4.3.7.2 suffers from
this regression. Marking as bisected since reverting
https://cgit.freedesktop.org/libreoffice/core/commit/?id=60635557
fixes this issue.

Miklos, 
I assume the issue is the check for 180 should only apply to members of a
group. Any code pointers?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109024] support for ClarisDraw

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=109024

--- Comment #5 from krishna [:kr1shna]  ---
test result:
5.0.0.0.alpha1+-ab465b9 garbage
5.1.0.0.alpha1+1a6ec13 garbage
5.1.0.0.alpha1+-5b791ec garbage
5.2.0.0.alpha0+-f6a74ce garbage
5.3.0.0.alpha1+-4136757 garbage

os: android 5.1
device: lyf flame 3 [ ls-4001 ]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108896] support for AutoCAD DXF (.dxf) files

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=108896

--- Comment #3 from krishna [:kr1shna]  ---
test result:
5.0.0.0.alpha1+-ab465b9 crash
5.1.0.0.alpha1+1a6ec13 endless loop
5.1.0.0.alpha1+-5b791ec endless loop
5.2.0.0.alpha0+-f6a74ce endless loop
5.3.0.0.alpha1+-4136757 endless loop

os: android 5.1
device: lyf flame 3 [ ls-4001 ]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/inc sw/source

2017-08-03 Thread Ashod Nakashian 
 sw/inc/rdfhelper.hxx |   11 +++-
 sw/source/core/doc/rdfhelper.cxx |   50 +++
 sw/source/core/edit/edfcol.cxx   |   24 +++---
 3 files changed, 79 insertions(+), 6 deletions(-)

New commits:
commit 57446e0b60b9edbe1d72b13d664857f8d09c5048
Author: Ashod Nakashian 
Date:   Wed Aug 2 22:19:00 2017 -0400

sw: store paragraph signature as rdf metadata

Change-Id: I13e6079e2aa3bee3dac10b11b0a23e9b798e02a3
Reviewed-on: https://gerrit.libreoffice.org/40722
Tested-by: Jenkins 
Reviewed-by: Ashod Nakashian 

diff --git a/sw/inc/rdfhelper.hxx b/sw/inc/rdfhelper.hxx
index f89d470300ed..d7c03279cd7d 100644
--- a/sw/inc/rdfhelper.hxx
+++ b/sw/inc/rdfhelper.hxx
@@ -22,10 +22,17 @@ class SwTextNode;
 class SW_DLLPUBLIC SwRDFHelper
 {
 public:
-/// Gets all (rNode, key, value) statements in RDF graphs of type rType.
-static std::map getTextNodeStatements(const OUString& 
rType, const SwTextNode& rNode);
+/// Gets all (rTextNode, key, value) statements in RDF graphs of type 
rType.
+static std::map getTextNodeStatements(const OUString& 
rType, const SwTextNode& rTextNode);
+
 /// Add an (rTextNode, key, value) statement in the graph of type rType -- 
or if it does not exist, create a graph at rPath first.
 static void addTextNodeStatement(const OUString& rType, const OUString& 
rPath, SwTextNode& rTextNode, const OUString& rKey, const OUString& rValue);
+
+/// Remove an (rTextNode, key, value) statement in the graph of type rType.
+static void removeTextNodeStatement(const OUString& rType, SwTextNode& 
rTextNode, const OUString& rKey, const OUString& rValue);
+
+/// Update an (rTextNode, key, value) statement in the graph of type rType 
from old value to new. Creates the graph at rPath if doesn't exist.
+static void updateTextNodeStatement(const OUString& rType, const OUString& 
rPath, SwTextNode& rTextNode, const OUString& rKey, const OUString& rOldValue, 
const OUString& rNewValue);
 };
 
 #endif // INCLUDED_SW_INC_RDFHELPER_HXX
diff --git a/sw/source/core/doc/rdfhelper.cxx b/sw/source/core/doc/rdfhelper.cxx
index a139dfc0ba57..d43660dd258e 100644
--- a/sw/source/core/doc/rdfhelper.cxx
+++ b/sw/source/core/doc/rdfhelper.cxx
@@ -73,4 +73,54 @@ void SwRDFHelper::addTextNodeStatement(const OUString& 
rType, const OUString& rP
 xGraph->addStatement(xSubject, xKey, xValue);
 }
 
+void SwRDFHelper::removeTextNodeStatement(const OUString& rType, SwTextNode& 
rTextNode, const OUString& rKey, const OUString& rValue)
+{
+uno::Reference 
xComponentContext(comphelper::getProcessComponentContext());
+uno::Reference xType = rdf::URI::create(xComponentContext, 
rType);
+uno::Reference 
xDocumentMetadataAccess(rTextNode.GetDoc()->GetDocShell()->GetBaseModel(), 
uno::UNO_QUERY);
+uno::Sequence< uno::Reference > aGraphNames = 
xDocumentMetadataAccess->getMetadataGraphsWithType(xType);
+if (!aGraphNames.hasElements())
+return;
+
+uno::Reference xGraphName = aGraphNames[0];
+uno::Reference xGraph = 
xDocumentMetadataAccess->getRDFRepository()->getGraph(xGraphName);
+uno::Reference 
xSubject(SwXParagraph::CreateXParagraph(*rTextNode.GetDoc(), ), 
uno::UNO_QUERY);
+uno::Reference xKey = rdf::URI::create(xComponentContext, rKey);
+uno::Reference xValue = 
rdf::Literal::create(xComponentContext, rValue);
+xGraph->removeStatements(xSubject, xKey, xValue);
+}
+
+void SwRDFHelper::updateTextNodeStatement(const OUString& rType, const 
OUString& rPath, SwTextNode& rTextNode, const OUString& rKey, const OUString& 
rOldValue, const OUString& rNewValue)
+{
+uno::Reference 
xComponentContext(comphelper::getProcessComponentContext());
+uno::Reference xType = rdf::URI::create(xComponentContext, 
rType);
+uno::Reference 
xDocumentMetadataAccess(rTextNode.GetDoc()->GetDocShell()->GetBaseModel(), 
uno::UNO_QUERY);
+uno::Sequence< uno::Reference > aGraphNames = 
xDocumentMetadataAccess->getMetadataGraphsWithType(xType);
+uno::Reference xGraphName;
+if (aGraphNames.hasElements())
+{
+xGraphName = aGraphNames[0];
+}
+else
+{
+uno::Sequence< uno::Reference > xTypes = { xType };
+xGraphName = xDocumentMetadataAccess->addMetadataFile(rPath, xTypes);
+}
+
+uno::Reference xGraph = 
xDocumentMetadataAccess->getRDFRepository()->getGraph(xGraphName);
+uno::Reference 
xSubject(SwXParagraph::CreateXParagraph(*rTextNode.GetDoc(), ), 
uno::UNO_QUERY);
+uno::Reference xKey = rdf::URI::create(xComponentContext, rKey);
+
+if (aGraphNames.hasElements())
+{
+// Remove the old value.
+uno::Reference xOldValue = 
rdf::Literal::create(xComponentContext, rOldValue);
+xGraph->removeStatements(xSubject, xKey, xOldValue);
+}
+
+// Now add it with new value.
+

[Libreoffice-bugs] [Bug 108981] crash when open Adobe PageMaker (.pmd) file

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=108981

--- Comment #5 from krishna [:kr1shna]  ---
test result:
5.0.0.0.alpha1+-ab465b9 garbage
5.1.0.0.alpha1+1a6ec13 garbage
5.1.0.0.alpha1+-5b791ec garbage
5.2.0.0.alpha0+-f6a74ce garbage
5.3.0.0.alpha1+-4136757 garbage

os: android 5.1
device: lyf flame 3 [ ls-4001 ]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108971] support for Adobe FreeHand (.agd, .fhd) file

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=108971

--- Comment #4 from krishna [:kr1shna]  ---
forgot to mention

os: android 5.1
device: lyf flame 3 [ ls-4001 ]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108971] support for Adobe FreeHand (.agd, .fhd) file

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=108971

--- Comment #3 from krishna [:kr1shna]  ---
tested on
5.0.0.0.alpha1+-ab465b9 garbage
5.1.0.0.alpha1+1a6ec13 endless loop
5.1.0.0.alpha1+-5b791ec endless loop
5.2.0.0.alpha0+-f6a74ce endless loop
5.3.0.0.alpha1+-4136757 endless loop

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #35 from Jim Raykowski  ---
Ok I've experienced some setback due to changes made to SwResId which were
included in the dev master just after I pulled the master which my work was
based on. It confused me when things were working locally and Jenkins passed
the commit and Samual commented that it looked good but Heiko's build failed.
So I now have a master that is only two days old and am close to being able to
commit again. Also I found and have fixed a bug introduced when the SwResId was
changed that makes the previous and next tooltips for the popup and sidebar
controls not correctly display a tooltip. Specifically
SwScrollNaviPopup::GetToolTip const char* id=STR_IMGBTN_ARY[nResId] I believe
needs to be [nResId-NID_START] for the index. Along that line I have made the
scrolltoprevious and scrolltonext control tooltips to use the same as the popup
so instead of 'Previous Repeat Search' the scrolltoprevious toolbar control
will show 'Continue Search Backwards'

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sd/source

2017-08-03 Thread Markus Mohrhard 
 sd/source/filter/sdpptwrp.cxx |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 80095665bfcb8dd22b7cfe4fcc7d7a3023712385
Author: Markus Mohrhard 
Date:   Fri Aug 4 02:45:32 2017 +0200

fix regression from dafae0fe31353a8092334328d499bc108d39e44c

Found by the UBSAN tinderbox.

Change-Id: I0c23f316713bb6c8abc331a1a2d131a068962812
Reviewed-on: https://gerrit.libreoffice.org/40752
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sd/source/filter/sdpptwrp.cxx b/sd/source/filter/sdpptwrp.cxx
index ef9b8fe607eb..a25a8e0bc4b4 100644
--- a/sd/source/filter/sdpptwrp.cxx
+++ b/sd/source/filter/sdpptwrp.cxx
@@ -38,9 +38,9 @@ using namespace ::com::sun::star::beans;
 using namespace ::com::sun::star::task;
 using namespace ::com::sun::star::frame;
 
-typedef sal_Bool ( SAL_CALL *ExportPPTPointer )( const std::vector< 
css::beans::PropertyValue >&, tools::SvRef&,
- Reference< XModel > &,
- Reference< XStatusIndicator > &,
+typedef sal_Bool ( SAL_CALL *ExportPPTPointer )( const std::vector< 
css::beans::PropertyValue >&, tools::SvRef const&,
+ Reference< XModel > const &,
+ Reference< XStatusIndicator > 
const &,
  SvMemoryStream*, sal_uInt32 
nCnvrtFlags );
 
 typedef sal_Bool ( SAL_CALL *ImportPPTPointer )( SdDrawDocument*, SvStream&, 
SotStorage&, SfxMedium& );
@@ -49,9 +49,9 @@ typedef sal_Bool ( SAL_CALL *SaveVBAPointer )( 
SfxObjectShell&, SvMemoryStream*&
 
 #ifdef DISABLE_DYNLOADING
 
-extern "C" sal_Bool ExportPPT( const std::vector< css::beans::PropertyValue 
>&, tools::SvRef&,
-   Reference< XModel > &,
-   Reference< XStatusIndicator > &,
+extern "C" sal_Bool ExportPPT( const std::vector< css::beans::PropertyValue 
>&, tools::SvRef const&,
+   Reference< XModel > const &,
+   Reference< XStatusIndicator > const &,
SvMemoryStream*, sal_uInt32 nCnvrtFlags );
 
 extern "C" sal_Bool ImportPPT( SdDrawDocument*, SvStream&, SotStorage&, 
SfxMedium& );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

LO 80731 - Incorrect syntax does compile, MID without end bracket

2017-08-03 Thread Pierre Lepage 

Hi,

I have implemented a new warning option on compilation. I did not go too 
far. A simple checkbox "Warning On" and an "else" in the faulty 
structure causing the problem of the closing parenthesis does the trick. 
I have included a screen copy of the dialog with the "Warning On" option.


The behavior of StarBasic with the "Warning On" option would be as follows.

A) Warning On and active IDE window: Warning displayed on line where 
normally there would be an error.


B) Warning On and IDE window inactive: Warning at the beginning of the 
macro execution in the application window.


C) Warning Off: No tolerated error and no warning stop.

For the case of the closing parenthesis, the warning message could be 
the following: A closing parenthesis is missing in one or more 
expressions with the Mid function.



In ./basic/source/comp/exprtree.cxx:1055

if((pExprList->bBracket&==RPAREN)||SbiTokenizer::IsEoln(eTok))
{
if(SbiTokenizer::IsEoln(eTok)&>bBracket&&!CodeCompleteOptions::IsWarningOn())
{
pParser->Error(ERRCODE_BASIC_EXPECTED,RPAREN);
pExprList->bError=true;
}
else
{
//Warningoncompile!
//"Closingparenthesisismissing."
}
break;
}

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 111302] Paste function failed for no reason in Writer

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111302

--- Comment #2 from CSLam  ---
Ok, will try that, but I believe it is not related to the user profile.

Well, on further thoughts, maybe the following may help, which points to how
the problem usually gets triggered.

I have a long Word document (currently 400+ pages), from which I have to copy
something at the running location (updated daily), and something at the end of
the document, which I am to paste to the Writer document.

I use to begin from the latter, because it is easy getting to the end of the
Word document.  The first copying always causes no trouble, as far as I recall,
but copying of the second block, which is the piece at the running location
towards the end (but never the end) of the Word document, uses to trigger the
trouble.

As said, I do not need to do anything to the Writer document but just saving it
and reopening it again, the paste option will turn back ON, and I can paste
right away, not even having to mark the block from the Word document.

I hope this better illustrates the problem.

CSLam

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109196] : other problem hangs when using Safari / thesaurus at the same time

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=109196

Allegra May  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #2 from Allegra May  ---
At this point we believe Writer may be a contributing factor to high CPU usage,
but not the cause of it. In any case, it's impossible to identify a specific
set of actions in Writer that lead to the problem (other than type, cut, and
paste for 4-5 hours at a time). Or, as you say, this could be another example
of session resources being consumed. 
Since submitting this bug, we've had indications that malware on the router
might be involved, and since we made the router more secure, we haven't seen
any sustained high CPU usage to cause LibreOffice to hang. Feel free to mark
this RESOLVED if appropriate.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111301] Writer Window not giving way

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111301

--- Comment #4 from CSLam  ---
As said, it does not always happen.  Please see my second post, which triggers
the issue from time to time - but not always.

CSLam

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111327] Some fonts are displayed as monospaced fonts

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111327

--- Comment #1 from Leandro Martín Drudi  ---
Another fonts:
• Linux Biolinum G
• Linux Libertine Display G

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111327] New: Some fonts are displayed as monospaced fonts

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111327

Bug ID: 111327
   Summary: Some fonts are displayed as monospaced fonts
   Product: LibreOffice
   Version: 5.3.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sanipache...@outlook.com.ar

Created attachment 135117
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135117=edit
Fonts don't show correctly

Fonts like:
• Liberation Serif
• Liberation Sans Narrow
• Liberation Sans
• Linux Biolinum G
are shown as monospaced in old or new documents. Reinstalling the fonts does
not solve the problem.

Versión: 5.3.5.2 (x64)
Id. de compilación: 50d9bf2b0a79cdb85a3814b592608037a682059d
Subproc. CPU: 4; SO: Windows 6.19; Repres. IU: predet.; Layout Engine: new; 
Configuración regional: es-AR (es_AR); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111326] select a pdf document by columns instead of lines

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111326

alainroy...@gmail.com changed:

   What|Removed |Added

Version|unspecified |5.1.6.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111326] New: select a pdf document by columns instead of lines

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111326

Bug ID: 111326
   Summary: select a pdf document by columns instead of lines
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: alainroy...@gmail.com

Calc Version: 5.1.6.2
Build ID: 1:5.1.6~rc2-0ubuntu1~xenial2
Threads CPU : 4; Version de l'OS :Linux 4.10; UI Render : par défaut; 
Locale : fr-CA (fr_CA.UTF-8); Calc: group

When the content of a page in a pdf document is selected, lines are broken when
pasted into a notepad or a Calc sheet. the content is barely usable without a
great amont of work to rectify a wrongful paste operation.

The content is randomly pasted, sometimes one single column at a time, sometime
more, some times 5 or 6 lines are ok but the 10 following are broken and pasted
1 or 2 colums on the 10 next lines and then 2 or 3 source columns on the next
10 lines in 1 cell by line.

I tried to paste in a notepad as an intermediate buffer. again, lines are
broken.

a 10 lines, 5 columns pdf page can end on 30 lines. the first 10 lines carrying
col 1 and 2, line 11 to 20 having col3 and lines 21 to 30, col 4 and 5.
Sometimes I see text in a column split in two cells on a different line

is there a setting preventing this r a fix that can be aplied to correct this
situation?

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - include/oox include/svl oox/source sc/qa sc/source sd/qa sw/inc sw/source

2017-08-03 Thread Tamás Zolnai 
 include/oox/vml/vmldrawing.hxx |4 --
 include/svl/cryptosign.hxx |4 +-
 oox/source/ole/axcontrolfragment.cxx   |   19 +++
 oox/source/ppt/slidefragmenthandler.cxx|1 
 oox/source/vml/vmldrawing.cxx  |   10 +-
 sc/qa/unit/data/xlsx/activex_checkbox.xlsx |binary
 sc/qa/unit/subsequent_filters-test.cxx |   40 
 sc/source/filter/oox/worksheetfragment.cxx |2 -
 sd/qa/unit/data/pptx/activex_checkbox.pptx |binary
 sd/qa/unit/import-tests.cxx|   37 ++
 sw/inc/editsh.hxx  |5 ++-
 sw/source/core/edit/edfcol.cxx |   48 ++---
 sw/source/uibase/shells/textsh1.cxx|2 -
 13 files changed, 149 insertions(+), 23 deletions(-)

New commits:
commit c8e3633a352c2fda3aebb9781288a926e7a88c42
Author: Tamás Zolnai 
Date:   Thu Aug 3 19:58:22 2017 +0200

Make ActiveX controls import working again (PPTX / XLSX)

It used to work earlier, but there were an issue with the
shape id and so controls were not find. Also in PPTX import
the persistStorage attribute was handled only for parent
controls and not for other kind of controls.

Change-Id: I9784166b65407b79b6dfed8a38087b55b1b69835
Reviewed-on: https://gerrit.libreoffice.org/40751
Reviewed-by: Tamás Zolnai 
Tested-by: Tamás Zolnai 

diff --git a/include/oox/vml/vmldrawing.hxx b/include/oox/vml/vmldrawing.hxx
index e9309f6c8497..032d29494a44 100644
--- a/include/oox/vml/vmldrawing.hxx
+++ b/include/oox/vml/vmldrawing.hxx
@@ -78,14 +78,10 @@ struct OOX_DLLPUBLIC OleObjectInfo : public 
::oox::ole::OleObjectInfo
 /** Contains information about a form control embedded in a draw page. */
 struct OOX_DLLPUBLIC ControlInfo
 {
-OUString maShapeId;  ///< Shape identifier for shape lookup.
 OUString maFragmentPath; ///< Path to the fragment describing the 
form control properties.
 OUString maName; ///< Programmatical name of the form 
control.
 
 explicitControlInfo();
-
-/** Sets the string representation of the passed numeric shape identifier. 
*/
-voidsetShapeId( sal_Int32 nShapeId );
 };
 
 
diff --git a/oox/source/ole/axcontrolfragment.cxx 
b/oox/source/ole/axcontrolfragment.cxx
index fb8a4652c01b..351a4bd2aec7 100644
--- a/oox/source/ole/axcontrolfragment.cxx
+++ b/oox/source/ole/axcontrolfragment.cxx
@@ -130,11 +130,30 @@ ContextHandlerRef AxControlFragment::onCreateContext( 
sal_Int32 nElement, const
 Reference< XInputStream > xStrgStrm = 
getFilter().openInputStream( aFragmentPath );
 if( xStrgStrm.is() )
 {
+// Try to import as a parent control
+bool bImportedAsParent = false;
 OleStorage aStorage( 
getFilter().getComponentContext(), xStrgStrm, false );
 BinaryXInputStream aInStrm( aStorage.openInputStream( 
"f" ), true );
 if( !aInStrm.isEof() )
+{
 if( AxContainerModelBase* pModel = dynamic_cast< 
AxContainerModelBase* >( mrControl.createModelFromGuid( aClassId ) ) )
+{
 pModel->importBinaryModel( aInStrm );
+bImportedAsParent = true;
+}
+}
+// Import it as a non-parent control
+if(!bImportedAsParent)
+{
+BinaryXInputStream 
aInStrm2(aStorage.openInputStream("contents"), true);
+if (!aInStrm2.isEof())
+{
+if (ControlModelBase* pModel = 
mrControl.createModelFromGuid(aClassId))
+{
+pModel->importBinaryModel(aInStrm2);
+}
+}
+}
 }
 }
 }
diff --git a/oox/source/ppt/slidefragmenthandler.cxx 
b/oox/source/ppt/slidefragmenthandler.cxx
index 9d6fcf16aa99..3a967eea14ce 100644
--- a/oox/source/ppt/slidefragmenthandler.cxx
+++ b/oox/source/ppt/slidefragmenthandler.cxx
@@ -139,7 +139,6 @@ SlideFragmentHandler::~SlideFragmentHandler()
 case PPT_TOKEN( control ):
 {
 ::oox::vml::ControlInfo aInfo;
-aInfo.setShapeId( rAttribs.getInteger( XML_spid, 0 ) );
 aInfo.maFragmentPath = getFragmentPathFromRelId( 
rAttribs.getString( R_TOKEN( id ), OUString() ) );
 aInfo.maName = rAttribs.getXString( XML_name, OUString() );

[Libreoffice-commits] core.git: include/rtl

2017-08-03 Thread Ashod Nakashian 
 include/rtl/ustring.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 12e13f1f177d6f203edfbef4b31e1e7d3d3d7e78
Author: Ashod Nakashian 
Date:   Tue Aug 1 14:59:03 2017 -0400

rtl: typo in doc comment

Change-Id: I068d0bce3e0122d4539d489097ef7771f910ed0e
Reviewed-on: https://gerrit.libreoffice.org/40719
Tested-by: Jenkins 
Reviewed-by: Ashod Nakashian 

diff --git a/include/rtl/ustring.hxx b/include/rtl/ustring.hxx
index 5f41ff3ea2ea..602335e16768 100644
--- a/include/rtl/ustring.hxx
+++ b/include/rtl/ustring.hxx
@@ -443,7 +443,7 @@ public:
 /**
   Move assign a new string.
 
-  @paramstr a OString.
+  @paramstr an OUString.
   @since LibreOffice 5.2
 */
 OUString & operator=( OUString && str )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/svl include/vcl svl/source vcl/source

2017-08-03 Thread Ashod Nakashian 
 include/svl/cryptosign.hxx |3 ++
 include/vcl/filter/pdfdocument.hxx |1 
 include/vcl/pdfwriter.hxx  |3 --
 svl/source/crypto/cryptosign.cxx   |   49 +
 vcl/source/filter/ipdf/pdfdocument.cxx |   46 --
 5 files changed, 53 insertions(+), 49 deletions(-)

New commits:
commit 0a64fa41045eea8ea179bbf0eee306ffb5851500
Author: Ashod Nakashian 
Date:   Tue Aug 1 15:04:56 2017 -0400

svl: move DecodeHexString from vcl

Change-Id: I86da993050bde20f9ff0413ad5424673647a0e5c
Reviewed-on: https://gerrit.libreoffice.org/40720
Tested-by: Jenkins 
Reviewed-by: Ashod Nakashian 

diff --git a/include/svl/cryptosign.hxx b/include/svl/cryptosign.hxx
index 5d347c96d541..f8c1f36bdd8a 100644
--- a/include/svl/cryptosign.hxx
+++ b/include/svl/cryptosign.hxx
@@ -34,6 +34,9 @@ namespace svl {
 
 namespace crypto {
 
+/// Converts a hex-encoded string into a byte array.
+SVL_DLLPUBLIC std::vector DecodeHexString(const OString& rHex);
+
 /// Helper to cryptographically sign and verify
 /// arbitrary data blocks.
 class SVL_DLLPUBLIC Signing
diff --git a/include/vcl/filter/pdfdocument.hxx 
b/include/vcl/filter/pdfdocument.hxx
index 98806a3f17e7..e36fb687e0a0 100644
--- a/include/vcl/filter/pdfdocument.hxx
+++ b/include/vcl/filter/pdfdocument.hxx
@@ -314,7 +314,6 @@ class VCL_DLLPUBLIC PDFDocument
 /// All editing takes place in this buffer, if it happens.
 SvMemoryStream m_aEditBuffer;
 
-static int AsHex(char ch);
 /// Suggest a minimal, yet free signature ID to use for the next signature.
 sal_uInt32 GetNextSignature();
 /// Write the signature object as part of signing.
diff --git a/include/vcl/pdfwriter.hxx b/include/vcl/pdfwriter.hxx
index 78a28231ea10..b7ecbff71cd9 100644
--- a/include/vcl/pdfwriter.hxx
+++ b/include/vcl/pdfwriter.hxx
@@ -1231,9 +1231,6 @@ The following structure describes the permissions used in 
PDF security
 */
 void AddStream( const OUString& rMimeType, PDFOutputStream* pStream );
 
-/// Fill a PDF signature template.
-static bool Sign(PDFSignContext& rContext);
-
 /// Write rString as a PDF hex string into rBuffer.
 static void AppendUnicodeTextString(const OUString& rString, 
OStringBuffer& rBuffer);
 
diff --git a/svl/source/crypto/cryptosign.cxx b/svl/source/crypto/cryptosign.cxx
index 7d81ce90dcd7..1e0712fd8850 100644
--- a/svl/source/crypto/cryptosign.cxx
+++ b/svl/source/crypto/cryptosign.cxx
@@ -878,6 +878,55 @@ namespace svl {
 
 namespace crypto {
 
+static int AsHex(char ch)
+{
+int nRet = 0;
+if (rtl::isAsciiDigit(static_cast(ch)))
+nRet = ch - '0';
+else
+{
+if (ch >= 'a' && ch <= 'f')
+nRet = ch - 'a';
+else if (ch >= 'A' && ch <= 'F')
+nRet = ch - 'A';
+else
+return -1;
+nRet += 10;
+}
+return nRet;
+}
+
+std::vector DecodeHexString(const OString& rHex)
+{
+std::vector aRet;
+size_t nHexLen = rHex.getLength();
+{
+int nByte = 0;
+int nCount = 2;
+for (size_t i = 0; i < nHexLen; ++i)
+{
+nByte = nByte << 4;
+sal_Int8 nParsed = AsHex(rHex[i]);
+if (nParsed == -1)
+{
+SAL_WARN("svl.crypto", "DecodeHexString: invalid hex value");
+return aRet;
+}
+nByte += nParsed;
+--nCount;
+if (!nCount)
+{
+aRet.push_back(nByte);
+nCount = 2;
+nByte = 0;
+}
+}
+}
+
+return aRet;
+}
+
+
 #if defined(SVL_CRYPTO_NSS) || defined(SVL_CRYPTO_MSCRYPTO)
 
 bool Signing::Sign(OStringBuffer& rCMSHexBuffer)
diff --git a/vcl/source/filter/ipdf/pdfdocument.cxx 
b/vcl/source/filter/ipdf/pdfdocument.cxx
index 96960c407c1a..619041595c6b 100644
--- a/vcl/source/filter/ipdf/pdfdocument.cxx
+++ b/vcl/source/filter/ipdf/pdfdocument.cxx
@@ -1892,53 +1892,9 @@ std::vector 
PDFDocument::GetSignatureWidgets()
 return aRet;
 }
 
-int PDFDocument::AsHex(char ch)
-{
-int nRet = 0;
-if (rtl::isAsciiDigit(static_cast(ch)))
-nRet = ch - '0';
-else
-{
-if (ch >= 'a' && ch <= 'f')
-nRet = ch - 'a';
-else if (ch >= 'A' && ch <= 'F')
-nRet = ch - 'A';
-else
-return -1;
-nRet += 10;
-}
-return nRet;
-}
-
 std::vector PDFDocument::DecodeHexString(PDFHexStringElement 
const* pElement)
 {
-std::vector aRet;
-const OString& rHex = pElement->GetValue();
-size_t nHexLen = rHex.getLength();
-{
-int nByte = 0;
-int nCount = 2;
-for (size_t i = 0; i < nHexLen; ++i)
-{
-nByte = nByte << 4;
-sal_Int8 nParsed = AsHex(rHex[i]);
-if (nParsed == -1)
-

[Libreoffice-bugs] [Bug 111324] TutdaGill @**@1-844_79Ø* _9193 G.A.R.M.I.N gps phone number @ G.A.R.M.I.N customer service support help phone number @@ update

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111324

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Component|General |deletionrequest
 Resolution|--- |INVALID
Product|libcdr  |LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111323] !!*gps@gooogle8#$+1.844.79Ｏ.9193 garmin customer service phone number!! +1.844.79σ.9193 garmin customer service number!!

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111323

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Component|General |deletionrequest
Version|1.14|Inherited From OOo
 Resolution|--- |INVALID
Product|cppunit |LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111325] Adding a watermark automatically adds a page header

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111325

--- Comment #1 from Bastián Díaz  ---
Created attachment 135116
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135116=edit
Screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111325] New: Adding a watermark automatically adds a page header

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111325

Bug ID: 111325
   Summary: Adding a watermark automatically adds a page header
   Product: LibreOffice
   Version: 5.4.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: diazbast...@openmailbox.org

Description:
When you add a watermark additionally a new page header is added in the
document. When you try to erase the page header, the watermark is also deleted.

It also occurs if the user before adding a watermark already has a page header
established and if it is deleted, the watermark is deleted. So you can't have a
watermark without setting a page header.

Steps to Reproduce:
1. Open new document (Enable formatting marks to improve visibility)
2. Add a watermark: Ex. "Draft" using Format|Watermark
3. Delete the page header

Actual Results:  
When you add a watermark, system add a page header

Expected Results:
Only watermark is added


Reproducible: Always

User Profile Reset: Yes

Additional Info:
Testing on:
LibreOffice 5.4.0.3 (7556cbc6811c9d992f4064ab9287069087d7f62c) gtk+3
LibreOffice 6.0.0.0.alpha0 (e0bafa78e3ad0df397d78cd65ad19bd5b07dc5f2) gtk+3
Fedora 26 64bit XFCE


User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:54.0) Gecko/20100101
Firefox/54.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111322] Fill-in artifacts when rendering vector image at some zooming factors

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111322

sergio.calleg...@gmail.com changed:

   What|Removed |Added

   Hardware|All |x86-64 (AMD64)
 OS|All |Linux (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111322] Fill-in artifacts when rendering vector image at some zooming factors

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111322

--- Comment #3 from sergio.calleg...@gmail.com ---
Disabling the anti-aliasing prevents the issue from occurring (but obviously
the appearance is very much worsened).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111322] Fill-in artifacts when rendering vector image at some zooming factors

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111322

--- Comment #2 from sergio.calleg...@gmail.com ---
The issue is problematic, because it is unclear whether it occurs only while
editing drawings and presentations or it is possible even when /playing/
presentations.

Furthermore, it happens either with:

- EMF/WMF vector images
- SVG vector images
- native vector images

Hence, all vector image formats seem to be affected, apart from PDF in LibO 5.4
that has other issues (lack of background transparency).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111323] New: !!*gps@gooogle8#$+1.844.79Ｏ.9193 garmin customer service phone number!! +1.844.79σ.9193 garmin customer service number!!

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111323

Bug ID: 111323
   Summary: !!*gps@gooogle8#$+1.844.79Ｏ.9193 garmin customer
service phone number!! +1.844.79σ.9193 garmin customer
service number!!
   Product: cppunit
   Version: 1.14
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: maiqu...@ov3u841.com

Created attachment 135114
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135114=edit
https://readthedocs.org/projects/gpsgooogle818445469157-garmin-customer-service-phone-number-18446660662-garmin-customer-service-number/

!!*gps@gooogle8#$+1.844.79Ø.9193 garmin customer service phone number!!
+1.844.79Ø.9193 garmin customer service number!!

!!*gps@gooogle8#$+1.844.79Ø.9193 garmin customer service phone number!!
+1.844.79Ø.9193 garmin customer service number!!

!!*gps@gooogle8#$+1.844.79Ø.9193 garmin customer service phone number!!
+1.844.79Ø.9193 garmin customer service number!!

!!*gps@gooogle8#$+1.844.79Ø.9193 garmin customer service phone number!!
+1.844.79Ø.9193 garmin customer service number!!

garmin customer service reviews garmin support hours garmin suport garmin
support forum garmin contact info garmin 1 800 number garmin gps help garmin
customer service chat garmin gps contact number garmin nuvi technical support
phone number garmin support email garmin nuvi contact garmin nuvi contact phone
number garmin helpdesk garmin gps number garmin gps repair service garmin
hotline garmin 800 support garmin address garmin nuvi contact number garmin
nuvi support phone number garmin repair service garmin support usa garmin nuvi
repair centers garmin usa phone number garmin email address garmin canada
contact garmin corporate phone number garmin canada customer service garmin
tech support canada garmin email support garmin contact us garmin product
support specialist garmin usa customer service garmin contact canada call
garmin garmin usa support garmin support email address garmin customer service
canada garmin help phone number garmin help number garmin nuvi helpline garmin
live chat contact garmin canada garmin update service garmin service canada
email garmin support garmin gps helpline garmin forerunner customer service
garmin repair phone number garmin watch repair center garmin customer service
phone number canada garmin phone number usa garmin corporate office garmin
helpline phone number garmin help center garmin tech garmin contacts garmin
customer service number usa garmin help support garmin customer service phone
number usa garmin service hotline garmin international address garmin customer
support canada how to contact garmin customer service garmin customer service
email garmin canada phone number garmin support ireland contact garmin usa
garmin warranty service garmin gps contact information garmin customer service
repair garmin helpline number gps customer service garmin contact phone number
usa garmin international warranty garmin warranty customer service garmin
corporate headquarters how to contact garmin garmin olathe ks phone number
garmin contact phone number canada garmin contact number usa garmin call garmin
canada contact number garmin headquarters address garmin support hotline garmin
usa contact call garmin usa garmin support telefon garmin corporate
headquarters address garmin customer service phone number garmin customer
service garmin tech support garmin phone number garmin customer support garmin
gps customer service garmin support phone number garmin customer service number
garmin service center garmin telephone number garmin support phone garmin
support number phone number for garmin contact garmin support garmin contact
number garmin product support garmin nuvi customer service garmin contact
garmin toll free number garmin service number garmin service phone number
garmin 800 number garmin gps service garmin 1800 number garmin customer service
center garmin gps customer service number garmin customer service phone contact
garmin garmin call center garmin contact support
https://readthedocs.org/projects/gpsgooogle818445469157-garmin-customer-service-phone-number-18446660662-garmin-customer-service-number/
https://sunyasweetu9193gaamrninsupportphonenumber.wordpress.com/2017/08/03/gpsgooogle81-844-79%EF%BD%8F-9193-garmin-customer-service-phone-number-1-844-79%CF%83-9193-garmin-customer-service-number/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111321] PUMMA@@1-844_79σ_9193 G.A.R.M.I.N number @ G.A.R.M.I.N customer service phone number @@ update

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111321

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Component|General |deletionrequest
 Resolution|--- |INVALID
Product|libcdr  |LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111322] Fill-in artifacts when rendering vector image at some zooming factors

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111322

--- Comment #1 from sergio.calleg...@gmail.com ---
Created attachment 135113
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135113=edit
Illustration of the issue

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111322] New: Fill-in artifacts when rendering vector image at some zooming factors

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111322

Bug ID: 111322
   Summary: Fill-in artifacts when rendering vector image at some
zooming factors
   Product: LibreOffice
   Version: 5.3.5.1 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: graphics stack
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sergio.calleg...@gmail.com

Created attachment 135112
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135112=edit
Test document

Seen in 5.3.5.1 and 5.4.0, but almost surely introduced much earlier.

Consider the test case in demo.odp. This contains a presentation with a single
slide whose content is the logo of the University of Bologna in vector format
(taken from wikipedia and converted into emf with inkscape).

At some zoom factors, the image gets corrupted with parts of it being filled
in, as the screenshot shows.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111321] New: PUMMA@@1-844_79σ_9193 G.A.R.M.I.N number @ G.A.R.M.I.N customer service phone number @@ update

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111321

Bug ID: 111321
   Summary: PUMMA@@1-844_79σ_9193 G.A.R.M.I.N number @ G.A.R.M.I.N
customer service phone number @@ update
   Product: libcdr
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: maiqu...@ov3u841.com

Created attachment 135111
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135111=edit
https://maiquel3ov3u841comsupport.freshdesk.com/support/solutions/articles/3381908-pumma-1-844-79%CF%83-9193-g-a-r-m-i-n-number-g-a-r-m-i-n-customer-service-phone-number-update-

ChUMMA@@1-844_79Ｏ_9l93  G.A.R.M.I.N support number @ G.A.R.M.I.N customer
service number
ChUMMA@@1-844_79Ｏ_9l93  G.A.R.M.I.N support number @ G.A.R.M.I.N customer
service number
ChUMMA@@1-844_79Ｏ_9l93  G.A.R.M.I.N support number @ G.A.R.M.I.N customer
service number
ChUMMA@@1-844_79Ｏ_9l93  G.A.R.M.I.N support number @ G.A.R.M.I.N customer
service number
ChUMMA@@1-844_79Ｏ_9l93  G.A.R.M.I.N support number @ G.A.R.M.I.N customer
service number
ChUMMA@@1-844_79Ｏ_9l93  G.A.R.M.I.N support number @ G.A.R.M.I.N customer
service number
ChUMMA@@1-844_79Ｏ_9l93  G.A.R.M.I.N support number @ G.A.R.M.I.N customer
service number
ChUMMA@@1-844_79Ｏ_9l93  G.A.R.M.I.N support number @ G.A.R.M.I.N customer
service number
ChUMMA@@1-844_79Ｏ_9l93  G.A.R.M.I.N support number @ G.A.R.M.I.N customer
service number
ChUMMA@@1-844_79Ｏ_9l93  G.A.R.M.I.N support number @ G.A.R.M.I.N customer
service number
ChUMMA@@1-844_79Ｏ_9l93  G.A.R.M.I.N support number @ G.A.R.M.I.N customer
service number



~G.A.R.M.I.N support Number $$ ∣844-79Ｏ-8684 $$ G.A.R.M.I.N support Phone
Number@ G.A.R.M.I.N Customer care Number
~G.A.R.M.I.N support phone Number $$ ∣844-79Ｏ-8684 $$ G.A.R.M.I.N support
Number@ G.A.R.M.I.N Customer care Number
G.A.R.M.I.N support Number @ ∣844-79Ｏ-8684 G.A.R.M.I.N support number
~Iphone ∣844-79Ｏ-8684 G.A.R.M.I.N data recovery phone number
~SAम्पन ∣844-79Ｏ-8684 G.A.R.M.I.N support phone number macbook support number
~WIN ∣844-79Ｏ-8684 G.A.R.M.I.N support phone number macbook pro support number

~Iphone ∣844-79Ｏ-8684 G.A.R.M.I.N support phone number mac os x support number

~RAम्पन ∣844-79Ｏ6-8∣2 G.A.R.M.I.N customer support number mac support phone
number

~ipad ∣844-79Ｏ6-8∣2 G.A.R.M.I.N tech support number macbook support phone
number

~ipod ∣844-79Ｏ6-8∣2 G.A.R.M.I.N technical support number G.A.R.M.I.N support
phone number

G.A.R.M.I.N support number ,G.A.R.M.I.N phone number ,G.A.R.M.I.N
help,G.A.R.M.I.N customer service,G.A.R.M.I.N contact number ,G.A.R.M.I.N
support ,contact G.A.R.M.I.N,G.A.R.M.I.N contact,G.A.R.M.I.N help number
,G.A.R.M.I.N customer service number ,how to contact G.A.R.M.I.N,G.A.R.M.I.N
customer support ,contact G.A.R.M.I.N by phone,phone number for
G.A.R.M.I.N,G.A.R.M.I.N customer service phone number ,G.A.R.M.I.N number
,G.A.R.M.I.N helpline,G.A.R.M.I.N tech support ,G.A.R.M.I.N support
email,G.A.R.M.I.N help phone number,G.A.R.M.I.N problems,call
G.A.R.M.I.N,contact G.A.R.M.I.N support ,G.A.R.M.I.N customer service
email,G.A.R.M.I.N contact info,G.A.R.M.I.N phone numbersearch,G.A.R.M.I.N
customer service toll free number ,G.A.R.M.I.N help center,G.A.R.M.I.N
call,G.A.R.M.I.N contact us,how do i contact G.A.R.M.I.N,email
G.A.R.M.I.N,G.A.R.M.I.N support number ,G.A.R.M.I.N helpline number
,G.A.R.M.I.N telephone number ,G.A.R.M.I.N help email,G.A.R.M.I.N call
center,contact G.A.R.M.I.N customer service,G.A.R.M.I.N technical support
,contact G.A.R.M.I.N email,contact number for G.A.R.M.I.N,G.A.R.M.I.N help
center phone number ,contacting G.A.R.M.I.N,G.A.R.M.I.N support phone number
,G.A.R.M.I.N tech support number ,contact G.A.R.M.I.N phone number ,G.A.R.M.I.N
contact email,G.A.R.M.I.N help page,G.A.R.M.I.N customer care,help
G.A.R.M.I.N,call G.A.R.M.I.N support ,G.A.R.M.I.N contact phone number ,contact
G.A.R.M.I.N phone,call G.A.R.M.I.N customer service,how to contact G.A.R.M.I.N
support ,G.A.R.M.I.N phone support ,phone number G.A.R.M.I.N,email G.A.R.M.I.N
support ,G.A.R.M.I.N helpline phone number ,help with G.A.R.M.I.N,how to
contact G.A.R.M.I.N by phone,contacting G.A.R.M.I.N by phone,telephone number
for G.A.R.M.I.N,how can i contact G.A.R.M.I.N,customer service
G.A.R.M.I.N,G.A.R.M.I.N customer support number ,G.A.R.M.I.N technical support
phone number ,G.A.R.M.I.N ∣79Ｏ number ,phone number to G.A.R.M.I.N,G.A.R.M.I.N
technical support number ,G.A.R.M.I.N help center number ,G.A.R.M.I.N contact
information,G.A.R.M.I.N email support ,G.A.R.M.I.N hotline number ,G.A.R.M.I.N
phone numbers,G.A.R.M.I.N support contact,phone number for G.A.R.M.I.N help
center,call G.A.R.M.I.N help,how to contact G.A.R.M.I.N directly,G.A.R.M.I.N
tech support phone number ,G.A.R.M.I.N customer service live

[Libreoffice-bugs] [Bug 111320] New: baba bahussi: 1-844-79Ｏ_9l93 G.A.R.M.I.N support number G.A.R.M.I.N technical support phone number

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111320

Bug ID: 111320
   Summary: baba bahussi:1-844-79Ｏ_9l93 G.A.R.M.I.N support number
G.A.R.M.I.N technical support phone number
   Product: cppunit
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: maiqu...@ov3u841.com

Created attachment 135110
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135110=edit
https://maiquel3ov3u841comsupport.freshdesk.com/support/solutions/articles/3381805-baba-bahussi-1-844-79%EF%BC%AF-9l93-g-a-r-m-i-n-support-number-g-a-r-m-i-n-technical-support-phone-number

baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone numberbaba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number
G.A.R.M.I.N technical support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone numberbaba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number
G.A.R.M.I.N technical support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone numberbaba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number
G.A.R.M.I.N technical support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone numberbaba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number
G.A.R.M.I.N technical support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number

baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone numberbaba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number
G.A.R.M.I.N technical support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone numberbaba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number
G.A.R.M.I.N technical support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone numberbaba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number
G.A.R.M.I.N technical support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone numberbaba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number
G.A.R.M.I.N technical support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support number G.A.R.M.I.N technical
support phone number
baba bahussi:1-844-79σ_9193 G.A.R.M.I.N support

[Libreoffice-bugs] [Bug 111315] Crashreport: HTTP response code said error

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111315

Markus Mohrhard  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Markus Mohrhard  ---
The version on the server was still called 5.5.0.0.  I renamed the version to
6.0.0.0 but note that these crash reports from daily builds are not useful. We
only upload symbol information for official TDF releases and therefore are not
that helpful.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - download.lst external/expat

2017-08-03 Thread Caolán McNamara 
 download.lst |4 +-
 external/expat/StaticLibrary_expat.mk|1 
 external/expat/StaticLibrary_expat_x64.mk|1 
 external/expat/UnpackedTarball_expat.mk  |2 -
 external/expat/expat.getrandom_detection.patch.1 |   40 ---
 5 files changed, 5 insertions(+), 43 deletions(-)

New commits:
commit a5571712029f34afd343959983a5bb335e367794
Author: Caolán McNamara 
Date:   Thu Aug 3 14:03:27 2017 +0100

CVE-2017-11742: Expat 2.2.3

Reviewed-on: https://gerrit.libreoffice.org/40718
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit f680e5a441cecba4d238f031fc417ef3bccfd792)

Change-Id: I1a1de789eaa5a78d2dc0e41ef861d10fa97b689b
Reviewed-on: https://gerrit.libreoffice.org/40746
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/download.lst b/download.lst
index 8092bfcfa993..d7f08d41fb2f 100644
--- a/download.lst
+++ b/download.lst
@@ -41,8 +41,8 @@ export EPM_TARBALL := 
3ade8cfe7e59ca8e65052644fed9fca4-epm-3.7.tar.gz
 export ETONYEK_SHA256SUM := 
032f53e8d7691e48a73ddbe74fa84c906ff6ff32a33e6ee2a935b6fdb6aecb78
 export ETONYEK_VERSION_MICRO := 6
 export ETONYEK_TARBALL := libetonyek-0.1.$(ETONYEK_VERSION_MICRO).tar.bz2
-export EXPAT_SHA256SUM := 
1868cadae4c82a018e361e2b2091de103cd820aaacb0d6cfa49bd2cd83978885
-export EXPAT_TARBALL := expat-2.2.1.tar.bz2
+export EXPAT_SHA256SUM := 
b31890fb02f85c002a67491923f89bda5028a880fd6c374f707193ad81aace5f
+export EXPAT_TARBALL := expat-2.2.3.tar.bz2
 export FIREBIRD_SHA256SUM := 
6994be3555e23226630c587444be19d309b25b0fcf1f87df3b4e3f88943e5860
 export FIREBIRD_TARBALL := Firebird-3.0.0.32483-0.tar.bz2
 export FONTCONFIG_SHA256SUM := 
b449a3e10c47e1d1c7a6ec6e2016cca73d3bd68fbbd4f0ae5cc6b573f7d6c7f3
diff --git a/external/expat/StaticLibrary_expat.mk 
b/external/expat/StaticLibrary_expat.mk
index bdcc767e2905..31d03d03102e 100644
--- a/external/expat/StaticLibrary_expat.mk
+++ b/external/expat/StaticLibrary_expat.mk
@@ -48,6 +48,7 @@ $(eval $(call gb_StaticLibrary_add_cflags,expat,\
 ))
 
 $(eval $(call gb_StaticLibrary_add_generated_cobjects,expat,\
+   UnpackedTarball/expat/lib/loadlibrary \
UnpackedTarball/expat/lib/xmlparse \
UnpackedTarball/expat/lib/xmlrole \
UnpackedTarball/expat/lib/xmltok \
diff --git a/external/expat/StaticLibrary_expat_x64.mk 
b/external/expat/StaticLibrary_expat_x64.mk
index a38ba28c80dd..4f92d0fb284e 100644
--- a/external/expat/StaticLibrary_expat_x64.mk
+++ b/external/expat/StaticLibrary_expat_x64.mk
@@ -25,6 +25,7 @@ $(eval $(call gb_StaticLibrary_add_defs,expat_x64,\
 ))
 
 $(eval $(call gb_StaticLibrary_add_x64_generated_cobjects,expat_x64,\
+   UnpackedTarball/expat/lib/loadlibrary_x64 \
UnpackedTarball/expat/lib/xmlparse_x64 \
UnpackedTarball/expat/lib/xmltok_x64 \
UnpackedTarball/expat/lib/xmlrole_x64 \
diff --git a/external/expat/UnpackedTarball_expat.mk 
b/external/expat/UnpackedTarball_expat.mk
index 5d803dcf303a..f90fc8552568 100644
--- a/external/expat/UnpackedTarball_expat.mk
+++ b/external/expat/UnpackedTarball_expat.mk
@@ -13,7 +13,6 @@ $(eval $(call 
gb_UnpackedTarball_set_tarball,expat,$(EXPAT_TARBALL)))
 
 $(eval $(call gb_UnpackedTarball_add_patches,expat,\
external/expat/expat-winapi.patch \
-   external/expat/expat.getrandom_detection.patch.1 \
 ))
 
 # This is a bit hackish.
@@ -25,6 +24,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,expat,\
 
 $(eval $(call gb_UnpackedTarball_set_post_action,expat,\
$(if $(filter $(BUILD_X64),TRUE), \
+ cp lib/loadlibrary.c lib/loadlibrary_x64.c && \
  cp lib/xmlparse.c lib/xmlparse_x64.c && \
  cp lib/xmltok.c lib/xmltok_x64.c && \
  cp lib/xmlrole.c lib/xmlrole_x64.c) \
diff --git a/external/expat/expat.getrandom_detection.patch.1 
b/external/expat/expat.getrandom_detection.patch.1
deleted file mode 100644
index eaf25df767dd..
--- a/external/expat/expat.getrandom_detection.patch.1
+++ /dev/null
@@ -1,40 +0,0 @@
-https://github.com/libexpat/libexpat/issues/52
-
-fixes /usr/include/sys/random.h:37:22: error: expected ')'
-misdetection of random.h feature, already fixed upstream:
-https://github.com/libexpat/libexpat/commit/602e6c78ca750c082b72f8cdf4a38839b312959f
-
-diff -ur expat.org/configure expat/configure
 expat.org/configure2017-07-12 17:04:34.0 +0200
-+++ expat/configure2017-07-12 17:05:59.0 +0200
-@@ -16341,7 +16341,7 @@
-   }
- 
- _ACEOF
--if ac_fn_c_try_compile "$LINENO"; then :
-+if ac_fn_c_try_link "$LINENO"; then :
- 
- 
- $as_echo "#define HAVE_GETRANDOM 1" >>confdefs.h
-@@ -16386,7 +16386,8 @@
- conftest$ac_exeext conftest.$ac_ext
- 
- fi
--rm -f core conftest.err

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - download.lst external/expat

2017-08-03 Thread Caolán McNamara 
 download.lst |4 +-
 external/expat/StaticLibrary_expat.mk|1 
 external/expat/StaticLibrary_expat_x64.mk|1 
 external/expat/UnpackedTarball_expat.mk  |2 -
 external/expat/expat.getrandom_detection.patch.1 |   40 ---
 5 files changed, 5 insertions(+), 43 deletions(-)

New commits:
commit 2351570154e43fe919e5b9dd756bbe13a6b9c60d
Author: Caolán McNamara 
Date:   Thu Aug 3 14:03:27 2017 +0100

CVE-2017-11742: Expat 2.2.3

Reviewed-on: https://gerrit.libreoffice.org/40718
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit f680e5a441cecba4d238f031fc417ef3bccfd792)

Change-Id: I1a1de789eaa5a78d2dc0e41ef861d10fa97b689b
Reviewed-on: https://gerrit.libreoffice.org/40749
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/download.lst b/download.lst
index 4c6761285841..2e22bd1101df 100644
--- a/download.lst
+++ b/download.lst
@@ -33,8 +33,8 @@ export EPM_TARBALL := 
3ade8cfe7e59ca8e65052644fed9fca4-epm-3.7.tar.gz
 export ETONYEK_MD5SUM := 77ff46936dcc83670557274e7dd2aa33
 export ETONYEK_VERSION_MICRO := 6
 export ETONYEK_TARBALL := libetonyek-0.1.$(ETONYEK_VERSION_MICRO).tar.bz2
-export EXPAT_MD5SUM := d9c3baeab58774cefc2f04faf29f2cf8
-export EXPAT_TARBALL := expat-2.2.1.tar.bz2
+export EXPAT_MD5SUM := f053af63ef5f39bd9b78d01fbc203334
+export EXPAT_TARBALL := expat-2.2.3.tar.bz2
 export FIREBIRD_MD5SUM := 821260b61dafc22899d1464d4e91ee6a
 export FIREBIRD_TARBALL := Firebird-3.0.0.32483-0.tar.bz2
 export FONTCONFIG_TARBALL := 
77e15a92006ddc2adbb06f840d591c0e-fontconfig-2.8.0.tar.gz
diff --git a/external/expat/StaticLibrary_expat.mk 
b/external/expat/StaticLibrary_expat.mk
index 4d6957f9ef52..5a7d43d6c9bd 100644
--- a/external/expat/StaticLibrary_expat.mk
+++ b/external/expat/StaticLibrary_expat.mk
@@ -48,6 +48,7 @@ $(eval $(call gb_StaticLibrary_add_cflags,expat,\
 ))
 
 $(eval $(call gb_StaticLibrary_add_generated_cobjects,expat,\
+   UnpackedTarball/expat/lib/loadlibrary \
UnpackedTarball/expat/lib/xmlparse \
UnpackedTarball/expat/lib/xmlrole \
UnpackedTarball/expat/lib/xmltok \
diff --git a/external/expat/StaticLibrary_expat_x64.mk 
b/external/expat/StaticLibrary_expat_x64.mk
index a38ba28c80dd..4f92d0fb284e 100644
--- a/external/expat/StaticLibrary_expat_x64.mk
+++ b/external/expat/StaticLibrary_expat_x64.mk
@@ -25,6 +25,7 @@ $(eval $(call gb_StaticLibrary_add_defs,expat_x64,\
 ))
 
 $(eval $(call gb_StaticLibrary_add_x64_generated_cobjects,expat_x64,\
+   UnpackedTarball/expat/lib/loadlibrary_x64 \
UnpackedTarball/expat/lib/xmlparse_x64 \
UnpackedTarball/expat/lib/xmltok_x64 \
UnpackedTarball/expat/lib/xmlrole_x64 \
diff --git a/external/expat/UnpackedTarball_expat.mk 
b/external/expat/UnpackedTarball_expat.mk
index 5d803dcf303a..f90fc8552568 100644
--- a/external/expat/UnpackedTarball_expat.mk
+++ b/external/expat/UnpackedTarball_expat.mk
@@ -13,7 +13,6 @@ $(eval $(call 
gb_UnpackedTarball_set_tarball,expat,$(EXPAT_TARBALL)))
 
 $(eval $(call gb_UnpackedTarball_add_patches,expat,\
external/expat/expat-winapi.patch \
-   external/expat/expat.getrandom_detection.patch.1 \
 ))
 
 # This is a bit hackish.
@@ -25,6 +24,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,expat,\
 
 $(eval $(call gb_UnpackedTarball_set_post_action,expat,\
$(if $(filter $(BUILD_X64),TRUE), \
+ cp lib/loadlibrary.c lib/loadlibrary_x64.c && \
  cp lib/xmlparse.c lib/xmlparse_x64.c && \
  cp lib/xmltok.c lib/xmltok_x64.c && \
  cp lib/xmlrole.c lib/xmlrole_x64.c) \
diff --git a/external/expat/expat.getrandom_detection.patch.1 
b/external/expat/expat.getrandom_detection.patch.1
deleted file mode 100644
index eaf25df767dd..
--- a/external/expat/expat.getrandom_detection.patch.1
+++ /dev/null
@@ -1,40 +0,0 @@
-https://github.com/libexpat/libexpat/issues/52
-
-fixes /usr/include/sys/random.h:37:22: error: expected ')'
-misdetection of random.h feature, already fixed upstream:
-https://github.com/libexpat/libexpat/commit/602e6c78ca750c082b72f8cdf4a38839b312959f
-
-diff -ur expat.org/configure expat/configure
 expat.org/configure2017-07-12 17:04:34.0 +0200
-+++ expat/configure2017-07-12 17:05:59.0 +0200
-@@ -16341,7 +16341,7 @@
-   }
- 
- _ACEOF
--if ac_fn_c_try_compile "$LINENO"; then :
-+if ac_fn_c_try_link "$LINENO"; then :
- 
- 
- $as_echo "#define HAVE_GETRANDOM 1" >>confdefs.h
-@@ -16386,7 +16386,8 @@
- conftest$ac_exeext conftest.$ac_ext
- 
- fi
--rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
-+rm -f core conftest.err conftest.$ac_objext \
-+conftest$ac_exeext conftest.$ac_ext
- 
- 
- for ac_header in fcntl.h

[Libreoffice-bugs] [Bug 111308] Crash in: rtl_uString_assign

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111308

--- Comment #11 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2b4ebf00d21f6305966c78f82336f9ac76425804=libreoffice-5-3

Resolves: tdf#111308 crash after load designs with no design selected

It will be available in 5.3.6.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111308] Crash in: rtl_uString_assign

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111308

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.0.0 target:5.4.1   |target:6.0.0 target:5.4.1
   ||target:5.3.6

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111308] Crash in: rtl_uString_assign

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111308

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.0.0|target:6.0.0 target:5.4.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111308] Crash in: rtl_uString_assign

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111308

--- Comment #10 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ab3e90e48a7ce8b1ebcee39af56289f625940d69=libreoffice-5-4

Resolves: tdf#111308 crash after load designs with no design selected

It will be available in 5.4.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sd/source

2017-08-03 Thread Caolán McNamara 
 sd/source/ui/dlg/sdpreslt.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ab3e90e48a7ce8b1ebcee39af56289f625940d69
Author: Caolán McNamara 
Date:   Thu Aug 3 17:24:32 2017 +0100

Resolves: tdf#111308 crash after load designs with no design selected

Change-Id: Ia7d5e1d0c4c960700d94cfec01a8a01799f89d9a
Reviewed-on: https://gerrit.libreoffice.org/40732
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit e325a5442ab350e8eb66458aed98d38ce21aec06)
Reviewed-on: https://gerrit.libreoffice.org/40745
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/sd/source/ui/dlg/sdpreslt.cxx b/sd/source/ui/dlg/sdpreslt.cxx
index b7f7d3642671..2eacdbbedb31 100644
--- a/sd/source/ui/dlg/sdpreslt.cxx
+++ b/sd/source/ui/dlg/sdpreslt.cxx
@@ -121,7 +121,7 @@ void SdPresLayoutDlg::GetAttr(SfxItemSet& rOutAttrs)
 {
 aLayoutName = maName + "#" + maLayoutNames[ nId - 1 ];
 }
-else
+else if (nId)
 {
 aLayoutName = maLayoutNames[ nId - 1 ];
 if( aLayoutName == maStrNone )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sd/source

2017-08-03 Thread Caolán McNamara 
 sd/source/ui/dlg/sdpreslt.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2b4ebf00d21f6305966c78f82336f9ac76425804
Author: Caolán McNamara 
Date:   Thu Aug 3 17:24:32 2017 +0100

Resolves: tdf#111308 crash after load designs with no design selected

Change-Id: Ia7d5e1d0c4c960700d94cfec01a8a01799f89d9a
Reviewed-on: https://gerrit.libreoffice.org/40732
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit e325a5442ab350e8eb66458aed98d38ce21aec06)
Reviewed-on: https://gerrit.libreoffice.org/40750
Reviewed-by: Markus Mohrhard 

diff --git a/sd/source/ui/dlg/sdpreslt.cxx b/sd/source/ui/dlg/sdpreslt.cxx
index 6ee9b9a24b20..3e4f60861fea 100644
--- a/sd/source/ui/dlg/sdpreslt.cxx
+++ b/sd/source/ui/dlg/sdpreslt.cxx
@@ -120,7 +120,7 @@ void SdPresLayoutDlg::GetAttr(SfxItemSet& rOutAttrs)
 {
 aLayoutName = maName + "#" + maLayoutNames[ nId - 1 ];
 }
-else
+else if (nId)
 {
 aLayoutName = maLayoutNames[ nId - 1 ];
 if( aLayoutName == maStrNone )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [libreoffice-design] Minutes of the Design Hangout: 2017-Aug-03

2017-08-03 Thread Gabriele Ponzo 
It depends a lot if projectors are going to be used or screens.

With the new coming big size screens, sometimes, especially in new
buildings, you can find them instead of projectors.

But most of the times you'll find an old projector 4:3... I hate them and I
know and am with you that the future is and has to be 16:9.

But... i find really useful to have slides in 4:3 to put them in 16:9
videos, having room for the speaker face shot by cameras and usually a
logo, just like we use to have at our conferences and at FOSDEM.

So I'm with Italo believing that fixing the resizing behavior should be the
best, and probably not so difficult to achieve (it should just be: don't do
anything :).

I'd prefer to have all the objects to be placed correctly than having them
all stretched. Also because if correctly used, it should be just matter of
master slides and layouts to be modified, almost without having to touch
every single slide.

Il 3 ago 2017 3:43 PM, "Heiko Tietze"  ha
scritto:

> Your voice has been heard, like many other on G+. The change is about the
> default where today >70% have to switch from 4:3 to widescreen. In future
> it is the minority including you who has to change the format. The
> functionality remains as it is.
>
> On 03.08.2017 15:38, Italo Vignoli wrote:
> > On 03/08/2017 14:51, Heiko Tietze wrote:
> >
> >>  * Switch default to 16:9 in Impress/Draw
> >>+ good idea (Heiko), bad idea (Jay)
> >
> > I have sent a comment by email but it looks like it has been ignored:
> > most conference centers still have 4:3 configurations, so switching to
> > 16:9 would be a problem for all people speaking at conferences (with a
> > few exceptions). There should be a resizing feature which allows to
> > switch from 4:3 to 16:9 without changing the aspect ratio of iterms on
> > the slide (which is what happens today). A large slide with more white
> > space is not a problem, and is often acceptable, as much as a narrower
> > slide with less white space. A large slide with all objects stretched
> > orizontally is not acceptable (and needs a lot of rework).
> >
> >>+ perhaps make it dependent on the actual screen dimension (Eric)
> >
> > This should be a must.
> >
>
> --
> Dr. Heiko Tietze
> UX designer
> Tel. +49 (0)179/1268509
>
>
> --
> To unsubscribe e-mail to: design+unsubscr...@global.libreoffice.org
> Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-
> unsubscribe/
> Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
> List archive: http://listarchives.libreoffice.org/global/design/
> All messages sent to this list will be publicly archived and cannot be
> deleted
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 111318] Improve message about pivot table/chart when removing a cell

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111318

--- Comment #5 from Pedro  ---
(In reply to Julien Nabet from comment #4)
> Perhaps something like this?
> "This action will also remove the whole pivot chart and associated pivot
> charts. Do you agree to proceed?"
> (or "Do you want to proceed?")
> (not too long, indicate all the elements: initial action and its
> consequences)

How about

"Deleting this cell(s) will also remove the whole pivot table and associated
pivot
charts. Do you want to proceed?"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111086] Assertion failure after undo (!"EmptyProperties:: SetObjectItemSet() should never be called")

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111086

Julien Nabet  changed:

   What|Removed |Added

 OS|Windows (All)   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111086] Assertion failure after undo (!"EmptyProperties:: SetObjectItemSet() should never be called")

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111086

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #3 from Julien Nabet  ---
Created attachment 135109
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135109=edit
bt with debug symbols (gtk3)

On pc Debian x86-64 with master sources updated today + gtk3 + enable-dbgutil,
I could reproduce this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111319] defining a picture as background makes extremely difficult to select a table , text or object and to change its properties

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111319

--- Comment #1 from Cristiano Duarte  ---
Created attachment 135108
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135108=edit
Sample ODT file for watermark bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111319] New: defining a picture as background makes extremely difficult to select a table , text or object and to change its properties

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111319

Bug ID: 111319
   Summary: defining a picture as background makes extremely
difficult to select a table, text or object and to
change its properties
   Product: LibreOffice
   Version: 5.1.3.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: cunh...@gmail.com

Description:
Defining a picture as watermark (achoring it at the header's paragraph and
sending it to background) disables all table and cell backgrounds (fill colors)
and makes almost impossible to use the foreground content.

Steps to Reproduce:
1. Insert a picture, anchor it to the header's paragraph and send it to the
background (watermark)
2. If you have a text written on the document, over the picture, it is
extremely difficult to place the cursor over it, or even to select it with the
left button
3. It is impossible to place the cursor on an empty paragraph (ex: for adding
text), because the focus is always placed at the background picture
4. Right-clicking over paragraphs almost always brings the background picture
context menu

Actual Results:  
a) Unable or extremely difficult to select a text, place the cursor on an empty
paragraph, select table cells, etc. 
b) Also, there is no way to make a cell's or table's background to render when
there is a background image (watermark) configured at the page.

Expected Results:
a) When left-cliking anywhere in the document over a watermark, the background
image (watermark) placed at the header/footer, should only get selected when
the header/footer is active (editable).
b) The background for tables or cells which are placed over the watermark
(background image) should be rendered normally.



Reproducible: Always

User Profile Reset: No

Additional Info:
Operating System: Fedora release 25 (Twenty Five)
Version: 5.1.3.2


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/59.0.3071.115 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

GSoC update | Week 9 | LibreOffice online - Aditya Dewan

2017-08-03 Thread Aditya Dewan 
Hi Everyone,

During the 9th week of GSoc, I continued my work on adding the horizontal
ruler in LibreOffice Online.

This week was spent entirely on implementing the ruler in loleaflet, with
appropriate part implemented in core already. The basic functionality
limited to breakpoints, adjustable margins and dynamic size/position(on
zoom) is complete.
Placement and position of ruler needs to be handled for a few major cases
i.e. when the map size is greater that of the screen and when annotations
are displayed.

Work on this specific task will be continued later, and for now i have
started working on the next task of extending the WOPI elements to support
the 'save as' functionality in LibreOffice Online.

You can follow my progress at -
https://gerrit.libreoffice.org/#/q/owner:callmedewan%2540gmail.com

Regards,
Aditya Dewan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 111318] Improve message about pivot table/chart when removing a cell

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111318

--- Comment #4 from Julien Nabet  ---
(In reply to Pedro from comment #3)
> ...
> "Deleting this pivot table will also remove the pivot chart(s) associated
> with it. Continue?" Yes/No
> ...
The problem is the initial user action is to remove a cell not delete pivot
table (and even less + delete associated chart pivot) so a user may not see
(perhaps would fill a tracker) the relation between his/her action and this
message.

Perhaps something like this?
"This action will also remove the whole pivot chart and associated pivot
charts. Do you agree to proceed?"
(or "Do you want to proceed?")
(not too long, indicate all the elements: initial action and its consequences)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111318] Improve message about pivot table/chart when removing a cell

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111318

Pedro  changed:

   What|Removed |Added

 CC||pedl...@gmail.com

--- Comment #3 from Pedro  ---
(In reply to Julien Nabet from comment #1)

I'm not a native English speaker either but in my opinion

"There is at least one pivot chart associated with this pivot table. Should
remove all or abort?"

could be replaced by

"Deleting this pivot table will also remove the pivot chart(s) associated with
it. Continue?" Yes/No

(my French isn't good enough to suggest a translation :) )

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 110991] row colour alternation in tables (Calc and Writer)

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=110991

Jacques Guilleron  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||guillero...@aol.com
 Ever confirmed|0   |1

--- Comment #1 from Jacques Guilleron  ---
Hi Jérôme,

Did you see the results of the recent survey?
https://design.blog.documentfoundation.org/2017/05/08/results-table-styles-survey/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111173] FILEOPEN Calc crashes when opening XLSX with chart.

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=73

--- Comment #5 from Julien Nabet  ---
Created attachment 135107
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135107=edit
quick patch

The only location I found where xLabelGroupShape is initialized is here:

356 uno::Reference< container::XChild > xChild(
aPieLabelInfo.xTextShape, uno::UNO_QUERY );
357 if( xChild.is() )
358 aPieLabelInfo.xLabelGroupShape.set( xChild->getParent(),
uno::UNO_QUERY );
(see
https://opengrok.libreoffice.org/xref/core/chart2/source/view/charttypes/PieChart.cxx#358)

aPieLabelInfo.xTextShape is initialized some lines before:
350 aPieLabelInfo.xTextShape = createDataLabel(
351 xTextTarget, rSeries, nPointIndex, nVal, rParam.mfLogicYSum,
352 aScreenPosition2D, eAlignment, 0, nTextMaximumFrameWidth);

But "createDataLabel" may return an empty ref (see
https://opengrok.libreoffice.org/xref/core/chart2/source/view/charttypes/VSeriesPlotter.cxx#406)

I attached a quick (but perhaps dirty or wrong) patch.
With it I could open the file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: test/Makefile.am test/UnitOAuth.cpp wsd/Storage.cpp

2017-08-03 Thread Henry Castro 
 test/Makefile.am   |4 +
 test/UnitOAuth.cpp |  149 +
 wsd/Storage.cpp|3 +
 3 files changed, 155 insertions(+), 1 deletion(-)

New commits:
commit a262b7d7ba4a8ff9832446849662a5516e53db53
Author: Henry Castro 
Date:   Thu Aug 3 17:05:48 2017 -0400

wsd: OAuth token passing

MS-WOPI:
"The following HTTP header MUST be included in all WOPI requests."
"Authorization "Bearer" and "

Change-Id: Ie5327286e93b86a49a0248ff5886bf3ea99df768

diff --git a/test/Makefile.am b/test/Makefile.am
index f7f4c090..237c2e1a 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -16,7 +16,7 @@ noinst_LTLIBRARIES = \
 unit-timeout.la unit-prefork.la \
 unit-storage.la unit-client.la \
 unit-admin.la unit-tilecache.la \
-   unit-fuzz.la unit-oob.la
+   unit-fuzz.la unit-oob.la unit-oauth.la
 
 MAGIC_TO_FORCE_SHLIB_CREATION = -rpath /dummy
 AM_LDFLAGS = -pthread -module $(MAGIC_TO_FORCE_SHLIB_CREATION) $(ZLIB_LIBS)
@@ -62,6 +62,8 @@ unit_timeout_la_SOURCES = UnitTimeout.cpp
 unit_prefork_la_SOURCES = UnitPrefork.cpp
 unit_storage_la_SOURCES = UnitStorage.cpp
 unit_tilecache_la_SOURCES = UnitTileCache.cpp
+unit_oauth_la_SOURCES = UnitOAuth.cpp
+unit_oauth_la_LIBADD = $(CPPUNIT_LIBS)
 
 if HAVE_LO_PATH
 SYSTEM_STAMP = @SYSTEMPLATE_PATH@/system_stamp
diff --git a/test/UnitOAuth.cpp b/test/UnitOAuth.cpp
new file mode 100644
index ..2a24ed9b
--- /dev/null
+++ b/test/UnitOAuth.cpp
@@ -0,0 +1,149 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include "config.h"
+
+//#include "Exceptions.hpp"
+#include "Log.hpp"
+#include "Unit.hpp"
+#include "helpers.hpp"
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+using Poco::DateTimeFormatter;
+using Poco::DateTimeFormat;
+using Poco::JSON::Object;
+using Poco::Net::HTTPServer;
+using Poco::Net::HTTPRequest;
+using Poco::Net::HTTPResponse;
+using Poco::Net::HTTPRequestHandlerFactory;
+using Poco::Net::HTTPRequestHandler;
+using Poco::Net::HTTPServerRequest;
+using Poco::Net::HTTPServerResponse;
+using Poco::Net::HTTPServerParams;
+using Poco::Net::OAuth20Credentials;
+using Poco::Net::ServerSocket;
+
+class WopiHostRequestHandler: public HTTPRequestHandler
+{
+public:
+void handleRequest(HTTPServerRequest& request, HTTPServerResponse& 
response)
+{
+Poco::URI uriReq(request.getURI());
+
+// The resource server MUST validate the access token
+// and ensure that it has not expired and that its scope
+// covers the requested resource.
+OAuth20Credentials creds(request);
+assert (creds.getBearerToken() == "s3hn3ct0k3v");
+
+// CheckFileInfo
+if (uriReq.getPath() == "/wopi/files/0")
+{
+Poco::LocalDateTime now;
+Object::Ptr fileInfo = new Object();
+fileInfo->set("BaseFileName", "empty.odt");
+fileInfo->set("Size", "1024");
+fileInfo->set("Version", "1.0");
+fileInfo->set("OwnerId", "test");
+fileInfo->set("UserId", "test");
+fileInfo->set("UserFriendlyName", "test");
+fileInfo->set("UserCanWrite", "true");
+fileInfo->set("PostMessageOrigin", "localhost");
+fileInfo->set("LastModifiedTime", DateTimeFormatter::format(now, 
DateTimeFormat::ISO8601_FORMAT));
+
+std::ostringstream oss;
+fileInfo->stringify(oss);
+response.setContentType("application/json; charset=utf-8");
+std::ostream& ostr = response.send();
+ostr << oss.str();
+}
+// GetFile
+else if (uriReq.getPath() == "/wopi/files/0/contents")
+{
+response.sendFile(Poco::Path(TDOC, "empty.odt").toString(), 
"application/vnd.oasis.opendocument.text");
+response.setStatusAndReason(HTTPResponse::HTTP_OK);
+}
+}
+
+};
+
+class WopiHostRequestHandlerFactory: public HTTPRequestHandlerFactory
+{
+public:
+HTTPRequestHandler* createRequestHandler(const HTTPServerRequest& 
/*request*/)
+{
+return new WopiHostRequestHandler();
+}
+};
+
+
+class UnitOAuth : public UnitWSD
+{
+public:
+UnitOAuth()
+{
+}
+
+virtual void configure(Poco::Util::LayeredConfiguration& /*config*/) 
override
+{
+}
+
+void invokeTest() override
+{
+HTTPResponse response;
+ServerSocket wopiSocket(0);
+HTTPServerParams* wopiParams = new HTTPServerParams();
+wopiParams->setKeepAlive(false);
+

[Libreoffice-bugs] [Bug 86661] Incorrect usage of ATK_ROLE_TEXT

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=86661

Alex ARNAUD  changed:

   What|Removed |Added

   Keywords||accessibility
 CC||rpoite...@hypra.fr

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111173] FILEOPEN Calc crashes when opening XLSX with chart.

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=73

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #4 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.
Here are some extra info:
(gdb) frame 5
#5  0x7fffbfece0ef in chart::PieChart::performLabelBestFitInnerPlacement
(this=0x581c9370, rShapeParam=..., rPieLabelInfo=...)
at
/home/julien/lo/libreoffice/chart2/source/view/charttypes/PieChart.cxx:1558
1558awt::Point aOldPos( rPieLabelInfo.xLabelGroupShape->getPosition()
);
(gdb) p rPieLabelInfo.xLabelGroupShape
$1 = empty uno::Reference
(gdb) p rPieLabelInfo
$2 = (const chart::PieChart::PieLabelInfo &) @0x7ffecca0: {xTextShape =
empty uno::Reference, xLabelGroupShape = empty uno::Reference, 
  aFirstPosition = { = {mnX = 5086, mnY = 3323}, }, aOrigin = { = {mnX = 6276, mnY = 4339}, }, 
  fValue = 45, bMovementAllowed = true, bMoved = false, xTextTarget =
uno::Reference to (SvxShapeGroup *) 0x58309460, pPrevious = 0x0, pNext =
0x0, aPreviousPosition = {
X = 0, Y = 0}}

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111318] Improve message about pivot table/chart when removing a cell

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111318

--- Comment #2 from Jean-Baptiste Faure  ---
Thank you Julien. I changed the French translation of the second sentence in
"Tout doit-il être supprimé ou faut-il abandonner ?"

I will change again if we get a better original message.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109861] navigation toolbar pops up when inserting header/footer

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=109861

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #3 from Jean-Baptiste Faure  ---
(In reply to Maarten from comment #2)
[...]
> -Put the toolbar back up from left hand side to top; problem of nav bar
> popping up still there.

Yes the nav bar is still popping up but it pops up in the same bar row as the
standard toolbar and then it does not make the text area moving.
If, for you, the nav bar pops up in the second bar row, you should move the nav
bar at the end of the standard toolbar. Next time it will pop up, it will do
there.

> - switched off the sidebar.. problem still there
> - tested on other machine, with single toolbar on top: same problem.. 
> 
> So i think it might be a bug! 

Why ? Nav bar is intended to allow you to navigate between visited objects in
your document. By creating an header, you created and selected a new object.

So, at the end, what is your problem ?
1/ the nav bar shouldn't pop up at all in such situation, whatever its
location?
or
2/ the nav bar popping up make the text area moving and it is disturbing?  

If 1/ please explain why.
Back to needinfo.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111318] Improve message about pivot table/chart when removing a cell

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111318

Julien Nabet  changed:

   What|Removed |Added

URL||http://nabble.documentfound
   ||ation.org/about-STR-PIVOT-R
   ||EMOVE-PIVOTCHART-td4219197.
   ||html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108959] UI: Tooltips for contents type selection icons disappear quickly

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=108959

Ignacio Graffione  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #6 from Ignacio Graffione  ---
I've tried with the dev version (the dll's problem is solved), but the bug is
still present.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111318] Improve message about pivot table/chart when removing a cell

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111318

Julien Nabet  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||gautier.sop...@gmail.com,
   ||jbfa...@libreoffice.org,
   ||qui...@gmail.com

--- Comment #1 from Julien Nabet  ---
Sophie/Jean-Baptiste: I put you in cc (in addition with Tomaž) because the
French translation is incorrect. I don't know if we should change it right now
or first, wait for a better original message.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Moved to tdf#111318] Re: about STR_PIVOT_REMOVE_PIVOTCHART

2017-08-03 Thread Julien Nabet 

On 03/08/2017 16:26, Tomaž Vajngerl wrote:

...
This sounds OK to me. The problem is that it is not clear what happens
when you choose "no". This is why I have written "or abort". Maybe it
should be a different kind of message box here? At that time I just
didn't want to spend to much time with this.
I thought it could be interesting to have a bugtracker about this, so I 
created it:

https://bugs.documentfoundation.org/show_bug.cgi?id=111318

Julien
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [libreoffice-design] Minutes of the Design Hangout: 2017-Aug-03

2017-08-03 Thread Italo Vignoli 
On 03/08/2017 14:51, Heiko Tietze wrote:

>  * Switch default to 16:9 in Impress/Draw
>+ good idea (Heiko), bad idea (Jay)

I have sent a comment by email but it looks like it has been ignored:
most conference centers still have 4:3 configurations, so switching to
16:9 would be a problem for all people speaking at conferences (with a
few exceptions). There should be a resizing feature which allows to
switch from 4:3 to 16:9 without changing the aspect ratio of iterms on
the slide (which is what happens today). A large slide with more white
space is not a problem, and is often acceptable, as much as a narrower
slide with less white space. A large slide with all objects stretched
orizontally is not acceptable (and needs a lot of rework).

>+ perhaps make it dependent on the actual screen dimension (Eric)

This should be a must.

-- 
Italo Vignoli - LibreOffice Marketing & PR
mobile/signal +39.348.5653829 - email it...@libreoffice.org
hangout/jabber italo.vign...@gmail.com - skype italovignoli
GPG Key ID - 0xAAB8D5C0
DB75 1534 3FD0 EA5F 56B5 FDA6 DE82 934C AAB8 D5C0
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Experiences building LO from scratch as a "new" developer

2017-08-03 Thread Mike Saunders 
Hi everyone,

You may know me from doing marketing work and videos for TDF. But a
while back I was talking to some developers and we had an idea: I should
try to build LO from scratch (something I've never done before), using
our existing documentation, to find out what could be improved.

I'm pretty geeky (been using Linux since 1998, know my way around the
Bash prompt, and have written programming tutorials for magazines) so
I'm probably quite representative of a typical new LO developer.

I've described my findings below, running a fresh installation of
Xubuntu 17.04. Overall the process wasn't too complicated, although
there are some rather confusing bits, and places where we could provide
more info. Let me know what you think!


STEPS I TOOK

1. I go to Google and type "How to build LibreOffice".


2. The first hit is
https://wiki.documentfoundation.org/Development/BuildingOnLinux - so I
go there.


3. First job is build dependencies. I execute the command specified in
the bullet point:

 sudo apt-get build-dep libreoffice

An error comes up: "E: You must put some 'source' URIs in your
sources.list". I Googled the error and fixed this by checking "Source
code" in the software-properties-gtk tool

I ran the command again and it worked. It could be noted in the wiki
that it installs around 1GB of dependencies (of course that will vary
from distro to distro).


4. Next is this bullet point:

"With modern releases, use autogen to select a newer gstreamer, or
install the old package with: sudo apt install libgstreamer0.10-dev
libgstreamer-plugins-base0.10-dev"

I don't know what "modern" is here - I'm assuming my distro is modern as
it's just a few months old. But it's very vague. I click the link which
takes me to
https://wiki.documentfoundation.org/Development/Linux_Build_Dependencies#Debian
- but there's no anchor for that so I just see the top of the page

I scroll down to "Debian / Ubuntu" and run the command specified:

 sudo apt-get install git gstreamer1.0-libav libkrb5-dev nasm

In point 2 I'm told:

"To run build-dep your repository source should contain source-code
repository source"

It looks like this fixes the problem I encountered earlier, in the first
step of BuildingOnLinux, but I wasn't told until now. The wording here
is very confusing with "source" three times in one sentence - one
referring to repositories, and one to source code.

The following steps on that page just repeat what I did before as well.


5. I'm done with dependencies, so I go back to the BuildingOnLinux page.
I look again at:

 "With modern releases, use autogen to select a newer gstreamer"

But I don't know how to do that, and I can't recall using autogen to
select anything; I only installed gstreamer1.0-libav. I try entering
"autogen" but I'm told it's not installed. Looking back in
Linux_Build_Dependencies, I see "When you use autogen.sh" under the
"Older Ubuntu" section - but the previous page said "With *modern*
releases, use autogen"

So now I'm *totally confused* about when and where to use autogen, or
autogen.sh - if I should use it at all!


6. I decide to continue with the "Cloning and building" part. I run:

 git clone git://anongit.freedesktop.org/libreoffice/core libreoffice

NOTE: This requires 2.4GB of disk space - it's worth mentioning in the
wiki before the command. (I discover later that this info is buried
under "Details, Tips, Tricks and Hints" further down the page, but IMO
it should be higher.)

I'm assuming this is the master (very latest) LibreOffice source code,
but it could also be from the latest stable release. Might be good to
clarify this here.


7. Next, I cd into libreoffice and then I see the autogen.sh command in
the instructions - which I'm assuming is what was mentioned before. So I
run this, and it appears to work fine.


8. Then I run "make" which starts downloading more stuff from the
internet. It's probably worth mentioning this, for devs who want to work
offline or when travelling, and assume they don't need net access after
the "git clone" bit.

Question: does parallel make (eg "make -j 2") have any effect here on
multi-core systems?

Thought: it would be useful to have some rough benchmarks for how long
the build process takes. eg "Dual-core Intel i5 2.4GHz: around X hours".
It doesn't need to be very specific, but it should give new developers a
rough indication.

It has been building for a few hours now, so I thought I'd post this
instead of waiting further. My next task is to fix a minor bug (or
translate some German comments), and submit a patch, to see how that
process works.

-- 
Mike Saunders, Marketing & PR
The Document Foundation
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 111318] New: Improve message about pivot table/ chart when removing a cell

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111318

Bug ID: 111318
   Summary: Improve message about pivot table/chart when removing
a cell
   Product: LibreOffice
   Version: 6.0.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: serval2...@yahoo.fr

Description:
With master sources updated today, on Calc there's this specific message when
deleting a cell from pivot table with 1 or several pivot charts associated:
"There is at least one pivot chart associated with this pivot table. Should
remove all or abort?"

In French, the message is:
"Il y a au moins un diagramme dynamique associé avec cette table dynamique.
Tout doit-il est supprimé ou abandonner ?" (so with syntax problem).

The goal of this bugtracker is to discuss and improve the message.


Steps to Reproduce:
Not relevant here

Actual Results:  
"There is at least one pivot chart associated with this pivot table. Should
remove all or abort?"


Expected Results:
To discuss


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
Firefox/52.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svl/source

2017-08-03 Thread Noel Grandin 
 svl/source/numbers/zformat.cxx  |8 +++---
 svl/source/numbers/zforscan.cxx |   48 
 svl/source/numbers/zforscan.hxx |6 ++---
 3 files changed, 31 insertions(+), 31 deletions(-)

New commits:
commit db76b6e4f0bab7670a401c1b7b8b2ce92ef08a03
Author: Noel Grandin 
Date:   Thu Aug 3 11:49:40 2017 +0200

rename nAnzResStrings->nResultStringsCnt

Change-Id: I631236b5750f1ddb9828ab5ebd4c59e7f1b81390
Reviewed-on: https://gerrit.libreoffice.org/40710
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx
index 1cdf9ddfa7aa..314ab233168d 100644
--- a/svl/source/numbers/zformat.cxx
+++ b/svl/source/numbers/zformat.cxx
@@ -1070,7 +1070,7 @@ SvNumberformat::SvNumberformat(OUString& rString,
 sStr = sInsertCalendar + sStr;
 }
 sal_Int32 nStrPos = pSc->ScanFormat( sStr);
-sal_uInt16 nAnz = pSc->GetAnzResStrings();
+sal_uInt16 nAnz = pSc->GetResultStringsCnt();
 if (nAnz == 0)  // error
 {
 nStrPos = 1;
@@ -1199,7 +1199,7 @@ SvNumberformat::SvNumberformat(OUString& rString,
 OUString aAdd( pSc->GetStandardName() );
 if ( !pSc->ScanFormat( aAdd ) )
 {
-sal_uInt16 nAnz = pSc->GetAnzResStrings();
+sal_uInt16 nAnz = pSc->GetResultStringsCnt();
 if ( nAnz )
 {
 NumFor[0].Enlarge(nAnz);
@@ -1219,7 +1219,7 @@ SvNumberformat::SvNumberformat(OUString& rString,
 OUString aAdd( pSc->GetStandardName() );
 if ( !pSc->ScanFormat( aAdd ) )
 {
-sal_uInt16 nAnz = pSc->GetAnzResStrings();
+sal_uInt16 nAnz = pSc->GetResultStringsCnt();
 if ( nAnz )
 {
 NumFor[nIndex].Enlarge(nAnz);
@@ -1237,7 +1237,7 @@ SvNumberformat::SvNumberformat(OUString& rString,
 OUString aAdd( pSc->GetStandardName() );
 if ( !pSc->ScanFormat( aAdd ) )
 {
-sal_uInt16 nAnz = pSc->GetAnzResStrings();
+sal_uInt16 nAnz = pSc->GetResultStringsCnt();
 if ( nAnz )
 {
 NumFor[nIndex].Enlarge(nAnz);
diff --git a/svl/source/numbers/zforscan.cxx b/svl/source/numbers/zforscan.cxx
index 02e2b210bf4c..bb5f04b21275 100644
--- a/svl/source/numbers/zforscan.cxx
+++ b/svl/source/numbers/zforscan.cxx
@@ -1082,7 +1082,7 @@ bool 
ImpSvNumberformatScan::IsLastBlankBeforeFrac(sal_uInt16 i)
 void ImpSvNumberformatScan::Reset()
 {
 nStringsCnt = 0;
-nAnzResStrings = 0;
+nResultStringsCnt = 0;
 eScannedType = css::util::NumberFormat::UNDEFINED;
 bExp = false;
 bThousand = false;
@@ -1481,7 +1481,7 @@ bool ImpSvNumberformatScan::InsertSymbol( sal_uInt16 & 
nPos, svt::NfSymbolType e
 sStrArray[i] = sStrArray[i-1];
 }
 }
-++nAnzResStrings;
+++nResultStringsCnt;
 nTypeArray[nPos] = static_cast(eType);
 sStrArray[nPos] = rStr;
 return true;
@@ -1590,7 +1590,7 @@ sal_Int32 ImpSvNumberformatScan::FinalScan( OUString& 
rString )
 sal_Int32 nPos = 0;// error correction position
 sal_uInt16 i = 0;  // symbol loop counter
 sal_uInt16 nCounter = 0;   // counts digits
-nAnzResStrings = nStringsCnt;  // counts remaining symbols
+nResultStringsCnt = nStringsCnt;   // counts remaining symbols
 bDecSep = false;   // reset in case already used in 
TypeCheck
 bool bThaiT = false;   // Thai T NatNum modifier present
 bool bTimePart = false;
@@ -1831,7 +1831,7 @@ sal_Int32 ImpSvNumberformatScan::FinalScan( OUString& 
rString )
 rStr += sStrArray[i];
 nPos = nPos + sStrArray[i].getLength();
 nTypeArray[i] = NF_SYMBOLTYPE_EMPTY;
-nAnzResStrings--;
+nResultStringsCnt--;
 nCounter++;
 i++;
 }
@@ -1859,7 +1859,7 @@ sal_Int32 ImpSvNumberformatScan::FinalScan( OUString& 
rString )
 {
 nPos = nPos + sStrArray[i].getLength();
 nTypeArray[i] = NF_SYMBOLTYPE_EMPTY;
-nAnzResStrings--;
+nResultStringsCnt--;
 i++; // eat it
 }
 else
@@ -1880,7 +1880,7 @@ sal_Int32 ImpSvNumberformatScan::FinalScan( OUString& 
rString )

[Libreoffice-commits] core.git: compilerplugins/clang sw/inc sw/source

2017-08-03 Thread Noel Grandin 
 compilerplugins/clang/constparams.cxx   |1 +
 sw/inc/SwNumberTree.hxx |2 +-
 sw/inc/dcontact.hxx |4 ++--
 sw/inc/doc.hxx  |   10 +-
 sw/inc/dpage.hxx|2 +-
 sw/inc/ndarr.hxx|2 +-
 sw/inc/ndnotxt.hxx  |2 +-
 sw/inc/splargs.hxx  |2 +-
 sw/inc/tblafmt.hxx  |2 +-
 sw/inc/textboxhelper.hxx|8 
 sw/source/core/SwNumberTree/SwNumberTree.cxx|2 +-
 sw/source/core/doc/DocumentContentOperationsManager.cxx |2 +-
 sw/source/core/doc/docedt.cxx   |2 +-
 sw/source/core/doc/docfmt.cxx   |6 +++---
 sw/source/core/doc/docglbl.cxx  |4 ++--
 sw/source/core/doc/docnew.cxx   |2 +-
 sw/source/core/doc/htmltbl.cxx  |2 +-
 sw/source/core/doc/notxtfrm.cxx |2 +-
 sw/source/core/doc/swstylemanager.cxx   |4 ++--
 sw/source/core/doc/swstylemanager.hxx   |2 +-
 sw/source/core/doc/tblafmt.cxx  |2 +-
 sw/source/core/doc/textboxhelper.cxx|8 
 sw/source/core/docnode/finalthreadmanager.cxx   |2 +-
 sw/source/core/docnode/ndnotxt.cxx  |2 +-
 sw/source/core/docnode/ndsect.cxx   |4 ++--
 sw/source/core/docnode/ndtbl.cxx|4 ++--
 sw/source/core/docnode/ndtbl1.cxx   |4 ++--
 sw/source/core/docnode/node.cxx |2 +-
 sw/source/core/docnode/nodes.cxx|2 +-
 sw/source/core/docnode/threadmanager.cxx|2 +-
 sw/source/core/draw/dcontact.cxx|8 
 sw/source/core/draw/dflyobj.cxx |2 +-
 sw/source/core/draw/dpage.cxx   |2 +-
 sw/source/core/inc/threadmanager.hxx|2 +-
 34 files changed, 55 insertions(+), 54 deletions(-)

New commits:
commit 98d7b40986afaf35894f8a7b36530975cae73fa9
Author: Noel Grandin 
Date:   Thu Aug 3 16:49:32 2017 +0200

loplugin:constparams in sw part2

Change-Id: I51ae0e8caaf46f141d3d15ace47612df1e476de7
Reviewed-on: https://gerrit.libreoffice.org/40735
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/constparams.cxx 
b/compilerplugins/clang/constparams.cxx
index b79d9cd27ebf..4f683317f3a8 100644
--- a/compilerplugins/clang/constparams.cxx
+++ b/compilerplugins/clang/constparams.cxx
@@ -163,6 +163,7 @@ bool ConstParams::VisitFunctionDecl(const FunctionDecl * 
functionDecl)
 || name == "PyUNOStruct_getattr"
 || name == "GoNext"
 || name == "GoPrevious"
+|| name == "lcl_SetOtherLineHeight"
  // #ifdef win32
 || name == "convert_slashes"
 // UNO component entry points
diff --git a/sw/inc/SwNumberTree.hxx b/sw/inc/SwNumberTree.hxx
index c908eeca490c..f87c82c6d549 100644
--- a/sw/inc/SwNumberTree.hxx
+++ b/sw/inc/SwNumberTree.hxx
@@ -453,7 +453,7 @@ protected:
 
@param pChild  the child to invalidate
  */
-void Invalidate( SwNumberTreeNode * pChild );
+void Invalidate( SwNumberTreeNode const * pChild );
 
 /** Invalidation of all children
 
diff --git a/sw/inc/dcontact.hxx b/sw/inc/dcontact.hxx
index e9eb91a6b388..80630c5f0464 100644
--- a/sw/inc/dcontact.hxx
+++ b/sw/inc/dcontact.hxx
@@ -55,7 +55,7 @@ inline const SwFrameFormat *FindFrameFormat( const SdrObject 
*pObj )
 {   return ::FindFrameFormat( const_cast(pObj) ); }
 bool HasWrap( const SdrObject* pObj );
 
-void setContextWritingMode( SdrObject* pObj, SwFrame* pAnchor );
+void setContextWritingMode( SdrObject* pObj, SwFrame const * pAnchor );
 
 /// @return BoundRect plus distance.
 SwRect GetBoundRectOfAnchoredObj( const SdrObject* pObj );
@@ -361,7 +361,7 @@ class SwDrawContact final : public SwContact
 virtual SdrObject* GetMaster() override;
 
 const SwFrame* GetAnchorFrame( const SdrObject* _pDrawObj = nullptr ) 
const;
-SwFrame* GetAnchorFrame( SdrObject* _pDrawObj = nullptr );
+SwFrame* GetAnchorFrame( SdrObject const * _pDrawObj = nullptr );
 
 const SwPageFrame* GetPageFrame() const
 {
diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx
index 0053e1efddf5..4b47f00bb5d7 100644
--- a/sw/inc/doc.hxx
+++ b/sw/inc/doc.hxx
@@ -377,7 +377,7 @@ private:
 typedef SwFormat* (SwDoc:: *FNCopyFormat)( const OUString&,

[Libreoffice-commits] core.git: basic/qa

2017-08-03 Thread Zdeněk Crhonek 
 basic/qa/cppunit/test_vba.cxx|3 +
 basic/qa/vba_tests/string.vb |   70 
 basic/qa/vba_tests/strreverse.vb |   74 +++
 basic/qa/vba_tests/switch.vb |   69 
 4 files changed, 216 insertions(+)

New commits:
commit f060d6450702c9992948266385aea9aa06000a8a
Author: Zdeněk Crhonek 
Date:   Thu Aug 3 17:12:21 2017 +0200

VBA tests- add functions STRING,STRREVERSE,SWITCH

Change-Id: Ibba3b5cabee31af44f0e8dda5a11f152ab0cfe01
Reviewed-on: https://gerrit.libreoffice.org/40730
Tested-by: Jenkins 
Reviewed-by: Zdenek Crhonek 

diff --git a/basic/qa/cppunit/test_vba.cxx b/basic/qa/cppunit/test_vba.cxx
index e406a1dc661a..ff6e26db415c 100644
--- a/basic/qa/cppunit/test_vba.cxx
+++ b/basic/qa/cppunit/test_vba.cxx
@@ -127,6 +127,9 @@ void VBATest::testMiscVBAFunctions()
 "sqr.vb",
 "str.vb",
 "strcomp.vb",
+"string.vb",
+"strreverse.vb",
+"switch.vb",
 #ifndef WIN32 // missing 64bit Currency marshalling.
 "win32compat.vb", // windows compatibility hooks.
 #endif
diff --git a/basic/qa/vba_tests/string.vb b/basic/qa/vba_tests/string.vb
new file mode 100644
index ..8091ddf45a6c
--- /dev/null
+++ b/basic/qa/vba_tests/string.vb
@@ -0,0 +1,70 @@
+Option VBASupport 1
+Option Explicit
+Dim passCount As Integer
+Dim failCount As Integer
+Dim result As String
+
+Function doUnitTest() As String
+result = verify_testString()
+If failCount <> 0 And passCount > 0 Then
+doUnitTest = result
+Else
+doUnitTest = "OK"
+End If
+End Function
+
+
+
+Function verify_testString() As String
+
+passCount = 0
+failCount = 0
+
+result = "Test Results" & Chr$(10) & "" & Chr$(10)
+
+Dim testName As String
+Dim TestDateTime As Date
+Dim TestStr As String
+Dim date1, date2
+testName = "Test String function"
+On Error GoTo errorHandler
+
+date2 = "P"
+date1 = String(5, "P")
+TestLog_ASSERT date1 = date2, "the return String is: " & date1
+
+date2 = "a"
+date1 = String(5, "a")
+TestLog_ASSERT date1 = date2, "the return String is: " & date1
+
+date2 = ""
+date1 = String(0, "P")
+TestLog_ASSERT date1 = date2, "the return String is: " & date1
+
+result = result & Chr$(10) & "Tests passed: " & passCount & Chr$(10) & 
"Tests failed: " & failCount & Chr$(10)
+verify_testString = result
+
+Exit Function
+errorHandler:
+TestLog_ASSERT (False), testName & ": hit error handler"
+End Function
+
+Sub TestLog_ASSERT(assertion As Boolean, Optional testId As String, Optional 
testComment As String)
+
+If assertion = True Then
+passCount = passCount + 1
+Else
+Dim testMsg As String
+If Not IsMissing(testId) Then
+testMsg = testMsg + " : " + testId
+End If
+If Not IsMissing(testComment) And Not (testComment = "") Then
+testMsg = testMsg + " (" + testComment + ")"
+End If
+
+result = result & Chr$(10) & " Failed: " & testMsg
+failCount = failCount + 1
+End If
+
+End Sub
+
diff --git a/basic/qa/vba_tests/strreverse.vb b/basic/qa/vba_tests/strreverse.vb
new file mode 100644
index ..fc03880795c2
--- /dev/null
+++ b/basic/qa/vba_tests/strreverse.vb
@@ -0,0 +1,74 @@
+Option VBASupport 1
+Option Explicit
+Dim passCount As Integer
+Dim failCount As Integer
+Dim result As String
+
+Function doUnitTest() As String
+result = verify_testStrReverse()
+If failCount <> 0 And passCount > 0 Then
+doUnitTest = result
+Else
+doUnitTest = "OK"
+End If
+End Function
+
+
+
+Function verify_testStrReverse() As String
+
+passCount = 0
+failCount = 0
+
+result = "Test Results" & Chr$(10) & "" & Chr$(10)
+
+Dim testName As String
+Dim TestDateTime As Date
+Dim TestStr As String
+Dim date1, date2
+testName = "Test StrReverse function"
+On Error GoTo errorHandler
+
+date2 = "dcba"
+date1 = StrReverse("abcd")
+TestLog_ASSERT date1 = date2, "the return StrReverse is: " & date1
+
+date2 = "BABABA"
+date1 = StrReverse("ABABAB")
+TestLog_ASSERT date1 = date2, "the return StrReverse is: " & date1
+
+date2 = "654321"
+date1 = StrReverse("123456")
+TestLog_ASSERT date1 = date2, "the return StrReverse is: " & date1
+
+date2 = "6"
+date1 = StrReverse(6)
+TestLog_ASSERT date1 = date2, "the return StrReverse is: " & date1
+
+result = result & Chr$(10) & "Tests passed: " & passCount & Chr$(10) & 
"Tests failed: " & failCount & Chr$(10)
+verify_testStrReverse = result
+
+Exit Function
+errorHandler:
+TestLog_ASSERT (False), testName & ": hit error handler"
+End Function
+
+Sub TestLog_ASSERT(assertion As Boolean, Optional testId As String, Optional 
testComment As String)
+
+If

[Libreoffice-bugs] [Bug 111308] Crash in: rtl_uString_assign

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111308

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Caolán McNamara  ---
backports of fix to 5-4 and 5-3 in gerrit. "Moderate" business letter looks
like a weird typo to me. https://gerrit.libreoffice.org/#/c/40748/ I bet it was
supposed to be a Modern serif and Modern sans serif variants

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Minutes of ESC call 2017-08-03

2017-08-03 Thread Caolán McNamara 
On Thu, 2017-08-03 at 16:47 +0200, Miklos Vajna wrote:
> * l10n (Sophie/Christian)
> + duplicate strings in templates w/ gettext on master:
>   mainly in sd/messages.pot – printindialog.ui from various 
>   subdirs
>   + preferred would be: have them in separate files

I guess this is sd/uiconfig/sdraw/ui/printeroptions.ui and
sd/uiconfig/simpress/ui/printeroptions.ui. Is the problem just with
the output of "make translations" i.e. the generated
workdir/sd/messages.pot if so, then yeah a simple rename will do the
tricky, i.e. https://gerrit.libreoffice.org/#/c/40747/ and that seems
to be the only case (according to msgcat workdir/*/messages.pot)
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 95578] A dispersion chart show totally wrong data after updating formulas with F9

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=95578

Jacques Guilleron  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #16 from Jacques Guilleron  ---
Hi Andy and all, 

All seems to work fine now.
I tried repeated F9 on 
LO 5.4.0.3 (x64) Build ID: 92c2794a7c181ba4c1c5053618179937228ed1fb
Threads CPU : 2; OS : Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: CL
Also with
LO  5.2.1.2 Build ID: 31dd62db80d4e60af04904455ec9c9219178d620
Threads CPU : 2; Version de l'OS :Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: CL
Doesn't work with 
LO 5.2.0.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111317] New: The text in the menu is not clear - bad font rendering

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111317

Bug ID: 111317
   Summary: The text in the menu is not clear - bad font rendering
   Product: LibreOffice
   Version: 5.4.0.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ivaylo.tinc...@gmail.com

Created attachment 135106
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135106=edit
Bad blurred rendering of the font/s

The text is not clear in both menus and dialogs (UI) and the Writer
documents/Calc sheets. See the attached picture. Other software products don't
seem to have this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111000] Opening an Microsoft RTF file with LO Writer will prevent Spellcheck from functioning correctly

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111000

--- Comment #2 from Edward D Kukla Jr  ---
Created attachment 135105
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135105=edit
Microsoft WordPad files saved as RTF opened in LO -> LO Spellcheck fails

This file was created in Microsoft 7 WordPad, saved as RTF file. When this RTF
file is opened in LibreOffice (version below) on either Linux or Microsoft, the
LO Spellcheck fails to function on this file, even after saved as an ODF file
format. 

NOTE: Spellcheck will fail on all other files, as noted by no "wavy red line"
indicator of miss-spelled words, and F7 -> Whole document failing to find
obvious miss-spelled words.

Version: 5.3.4.2 (x64)
Build ID: f82d347ccc0be322489bf7da61d7e4ad13fe2ff3
CPU Threads: 2; OS Version: Windows 6.1; UI Render: default; Layout Engine:
new; 
Locale: en-US (en_US); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

"Moderate" business letter

2017-08-03 Thread Caolán McNamara 
We have in extras/source/templates/officorr/ a
Modern_business_letter_serif.ott
and a
Moderate_business_letter_sans_serif.ott
what is a "Moderate" business letter. I'm assuming this a typo gone
wrong and it should be (and its internal style name also) a 
Modern_business_letter_sans_serif.ott, right ?

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 111308] Crash in: rtl_uString_assign

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111308

--- Comment #8 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e325a5442ab350e8eb66458aed98d38ce21aec06

Resolves: tdf#111308 crash after load designs with no design selected

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111308] Crash in: rtl_uString_assign

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111308

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sd/source

2017-08-03 Thread Caolán McNamara 
 sd/source/ui/dlg/sdpreslt.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e325a5442ab350e8eb66458aed98d38ce21aec06
Author: Caolán McNamara 
Date:   Thu Aug 3 17:24:32 2017 +0100

Resolves: tdf#111308 crash after load designs with no design selected

Change-Id: Ia7d5e1d0c4c960700d94cfec01a8a01799f89d9a
Reviewed-on: https://gerrit.libreoffice.org/40732
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sd/source/ui/dlg/sdpreslt.cxx b/sd/source/ui/dlg/sdpreslt.cxx
index 6fe9e2b2b35b..2cd521ef899b 100644
--- a/sd/source/ui/dlg/sdpreslt.cxx
+++ b/sd/source/ui/dlg/sdpreslt.cxx
@@ -121,7 +121,7 @@ void SdPresLayoutDlg::GetAttr(SfxItemSet& rOutAttrs)
 {
 aLayoutName = maName + "#" + maLayoutNames[ nId - 1 ];
 }
-else
+else if (nId)
 {
 aLayoutName = maLayoutNames[ nId - 1 ];
 if( aLayoutName == maStrNone )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: download.lst external/expat

2017-08-03 Thread Caolán McNamara 
 download.lst |4 +-
 external/expat/StaticLibrary_expat.mk|1 
 external/expat/StaticLibrary_expat_x64.mk|1 
 external/expat/UnpackedTarball_expat.mk  |2 -
 external/expat/expat.getrandom_detection.patch.1 |   40 ---
 5 files changed, 5 insertions(+), 43 deletions(-)

New commits:
commit f680e5a441cecba4d238f031fc417ef3bccfd792
Author: Caolán McNamara 
Date:   Thu Aug 3 14:03:27 2017 +0100

CVE-2017-11742: Expat 2.2.3

Change-Id: I1a1de789eaa5a78d2dc0e41ef861d10fa97b689b
Reviewed-on: https://gerrit.libreoffice.org/40718
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/download.lst b/download.lst
index fd1e93d9a238..8e926aada0db 100644
--- a/download.lst
+++ b/download.lst
@@ -43,8 +43,8 @@ export EPUBGEN_TARBALL := libepubgen-0.0.1.tar.bz2
 export ETONYEK_SHA256SUM := 
032f53e8d7691e48a73ddbe74fa84c906ff6ff32a33e6ee2a935b6fdb6aecb78
 export ETONYEK_VERSION_MICRO := 6
 export ETONYEK_TARBALL := libetonyek-0.1.$(ETONYEK_VERSION_MICRO).tar.bz2
-export EXPAT_SHA256SUM := 
1868cadae4c82a018e361e2b2091de103cd820aaacb0d6cfa49bd2cd83978885
-export EXPAT_TARBALL := expat-2.2.1.tar.bz2
+export EXPAT_SHA256SUM := 
b31890fb02f85c002a67491923f89bda5028a880fd6c374f707193ad81aace5f
+export EXPAT_TARBALL := expat-2.2.3.tar.bz2
 export FIREBIRD_SHA256SUM := 
6994be3555e23226630c587444be19d309b25b0fcf1f87df3b4e3f88943e5860
 export FIREBIRD_TARBALL := Firebird-3.0.0.32483-0.tar.bz2
 export FONTCONFIG_SHA256SUM := 
668293fcc4b3c59765cdee5cee05941091c0879edcc24dfec5455ef83912e45c
diff --git a/external/expat/StaticLibrary_expat.mk 
b/external/expat/StaticLibrary_expat.mk
index bdcc767e2905..31d03d03102e 100644
--- a/external/expat/StaticLibrary_expat.mk
+++ b/external/expat/StaticLibrary_expat.mk
@@ -48,6 +48,7 @@ $(eval $(call gb_StaticLibrary_add_cflags,expat,\
 ))
 
 $(eval $(call gb_StaticLibrary_add_generated_cobjects,expat,\
+   UnpackedTarball/expat/lib/loadlibrary \
UnpackedTarball/expat/lib/xmlparse \
UnpackedTarball/expat/lib/xmlrole \
UnpackedTarball/expat/lib/xmltok \
diff --git a/external/expat/StaticLibrary_expat_x64.mk 
b/external/expat/StaticLibrary_expat_x64.mk
index a38ba28c80dd..4f92d0fb284e 100644
--- a/external/expat/StaticLibrary_expat_x64.mk
+++ b/external/expat/StaticLibrary_expat_x64.mk
@@ -25,6 +25,7 @@ $(eval $(call gb_StaticLibrary_add_defs,expat_x64,\
 ))
 
 $(eval $(call gb_StaticLibrary_add_x64_generated_cobjects,expat_x64,\
+   UnpackedTarball/expat/lib/loadlibrary_x64 \
UnpackedTarball/expat/lib/xmlparse_x64 \
UnpackedTarball/expat/lib/xmltok_x64 \
UnpackedTarball/expat/lib/xmlrole_x64 \
diff --git a/external/expat/UnpackedTarball_expat.mk 
b/external/expat/UnpackedTarball_expat.mk
index 6347d4ee3657..1725aefb4c45 100644
--- a/external/expat/UnpackedTarball_expat.mk
+++ b/external/expat/UnpackedTarball_expat.mk
@@ -14,7 +14,6 @@ $(eval $(call 
gb_UnpackedTarball_set_tarball,expat,$(EXPAT_TARBALL)))
 $(eval $(call gb_UnpackedTarball_add_patches,expat,\
external/expat/expat-winapi.patch \
external/expat/expat-iOS.patch \
-   external/expat/expat.getrandom_detection.patch.1 \
 ))
 
 # This is a bit hackish.
@@ -26,6 +25,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,expat,\
 
 $(eval $(call gb_UnpackedTarball_set_post_action,expat,\
$(if $(filter $(BUILD_X64),TRUE), \
+ cp lib/loadlibrary.c lib/loadlibrary_x64.c && \
  cp lib/xmlparse.c lib/xmlparse_x64.c && \
  cp lib/xmltok.c lib/xmltok_x64.c && \
  cp lib/xmlrole.c lib/xmlrole_x64.c) \
diff --git a/external/expat/expat.getrandom_detection.patch.1 
b/external/expat/expat.getrandom_detection.patch.1
deleted file mode 100644
index eaf25df767dd..
--- a/external/expat/expat.getrandom_detection.patch.1
+++ /dev/null
@@ -1,40 +0,0 @@
-https://github.com/libexpat/libexpat/issues/52
-
-fixes /usr/include/sys/random.h:37:22: error: expected ')'
-misdetection of random.h feature, already fixed upstream:
-https://github.com/libexpat/libexpat/commit/602e6c78ca750c082b72f8cdf4a38839b312959f
-
-diff -ur expat.org/configure expat/configure
 expat.org/configure2017-07-12 17:04:34.0 +0200
-+++ expat/configure2017-07-12 17:05:59.0 +0200
-@@ -16341,7 +16341,7 @@
-   }
- 
- _ACEOF
--if ac_fn_c_try_compile "$LINENO"; then :
-+if ac_fn_c_try_link "$LINENO"; then :
- 
- 
- $as_echo "#define HAVE_GETRANDOM 1" >>confdefs.h
-@@ -16386,7 +16386,8 @@
- conftest$ac_exeext conftest.$ac_ext
- 
- fi
--rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
-+rm -f core conftest.err conftest.$ac_objext \
-+conftest$ac_exeext conftest.$ac_ext
- 
- 
- for ac_header in fcntl.h unistd.h
-diff -ur expat.org/configure.ac expat/configure.ac

[Libreoffice-commits] core.git: compilerplugins/clang include/vbahelper sw/inc sw/source

2017-08-03 Thread Noel Grandin 
 compilerplugins/clang/constparams.cxx |2 ++
 include/vbahelper/vbaaccesshelper.hxx |   10 +-
 sw/inc/calc.hxx   |2 +-
 sw/inc/dbgoutsw.hxx   |2 +-
 sw/inc/doc.hxx|6 +++---
 sw/inc/modcfg.hxx |   12 ++--
 sw/inc/ndindex.hxx|4 ++--
 sw/inc/swcrsr.hxx |6 +++---
 sw/inc/viewopt.hxx|2 +-
 sw/inc/viscrs.hxx |4 ++--
 sw/source/core/access/accframe.cxx|4 ++--
 sw/source/core/access/accframe.hxx|4 ++--
 sw/source/core/access/accmap.cxx  |2 +-
 sw/source/core/bastyp/calc.cxx|4 ++--
 sw/source/core/crsr/bookmrk.cxx   |2 +-
 sw/source/core/crsr/callnk.cxx|4 ++--
 sw/source/core/crsr/callnk.hxx|2 +-
 sw/source/core/crsr/crbm.cxx  |2 +-
 sw/source/core/crsr/crsrsh.cxx|2 +-
 sw/source/core/crsr/crstrvl.cxx   |4 ++--
 sw/source/core/crsr/swcrsr.cxx|   10 +-
 sw/source/core/crsr/viscrs.cxx|4 ++--
 sw/source/core/doc/CntntIdxStore.cxx  |   26 +-
 sw/source/core/doc/dbgoutsw.cxx   |4 ++--
 sw/source/core/doc/doc.cxx|2 +-
 sw/source/core/doc/doccomp.cxx|2 +-
 sw/source/core/doc/docdesc.cxx|2 +-
 27 files changed, 66 insertions(+), 64 deletions(-)

New commits:
commit 5176c1dd609939df388d58871dfa7db789e13523
Author: Noel Grandin 
Date:   Thu Aug 3 15:54:44 2017 +0200

loplugin:constparams in sw part1

Change-Id: Id8d8afe268a82585ec2d3699411073dfb905d6ba
Reviewed-on: https://gerrit.libreoffice.org/40734
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/constparams.cxx 
b/compilerplugins/clang/constparams.cxx
index 54501dc527db..b79d9cd27ebf 100644
--- a/compilerplugins/clang/constparams.cxx
+++ b/compilerplugins/clang/constparams.cxx
@@ -161,6 +161,8 @@ bool ConstParams::VisitFunctionDecl(const FunctionDecl * 
functionDecl)
 || name == "PyUNO_setattr"
 || name == "PyUNOStruct_setattr"
 || name == "PyUNOStruct_getattr"
+|| name == "GoNext"
+|| name == "GoPrevious"
  // #ifdef win32
 || name == "convert_slashes"
 // UNO component entry points
diff --git a/include/vbahelper/vbaaccesshelper.hxx 
b/include/vbahelper/vbaaccesshelper.hxx
index 177bcddc2906..04460b165fb3 100644
--- a/include/vbahelper/vbaaccesshelper.hxx
+++ b/include/vbahelper/vbaaccesshelper.hxx
@@ -43,7 +43,7 @@ namespace ooo
 namespace vba
 {
 
-inline css::uno::Reference< css::lang::XMultiServiceFactory > 
getVBAServiceFactory( SfxObjectShell* pShell )
+inline css::uno::Reference< css::lang::XMultiServiceFactory > 
getVBAServiceFactory( SfxObjectShell const * pShell )
 {
 css::uno::Any aUnoVar;
 if ( !pShell || ! pShell->GetBasicManager()->GetGlobalUNOConstant( 
"VBAGlobals", aUnoVar ) )
@@ -53,7 +53,7 @@ namespace ooo
 }
 
 /// @throws css::uno::Exception
-inline css::uno::Reference< css::uno::XInterface > 
createVBAUnoAPIServiceWithArgs( SfxObjectShell* pShell,  const sal_Char* 
_pAsciiName, const css::uno::Sequence< css::uno::Any >& aArgs )
+inline css::uno::Reference< css::uno::XInterface > 
createVBAUnoAPIServiceWithArgs( SfxObjectShell const * pShell,  const sal_Char* 
_pAsciiName, const css::uno::Sequence< css::uno::Any >& aArgs )
 {
 OSL_PRECOND( pShell, "createVBAUnoAPIService: no shell!" );
 OUString sVarName( OUString::createFromAscii( _pAsciiName ) );
@@ -62,7 +62,7 @@ namespace ooo
 }
 
 
-inline bool isAlienDoc( SfxObjectShell& rDocShell, const char* 
pMimeType )
+inline bool isAlienDoc( SfxObjectShell const & rDocShell, const char* 
pMimeType )
 {
 bool bRes( false );
 const SfxMedium *pMedium = rDocShell.GetMedium();
@@ -71,10 +71,10 @@ namespace ooo
 bRes = pFilt->GetMimeType().equalsAscii( pMimeType );
 return bRes;
 }
-inline bool isAlienExcelDoc( SfxObjectShell& rDocShell ) { return 
isAlienDoc( rDocShell, "application/vnd.ms-excel" ); }
+inline bool isAlienExcelDoc( SfxObjectShell const & rDocShell ) { 
return isAlienDoc( rDocShell, "application/vnd.ms-excel" ); }
 //VBAHELPER_DLLPRIVATE inline bool isAlienWordDoc( SfxObjectShell& 
rDocShell ) { return isAlienDoc( rDocShell, "application/vnd.ms-word" ); }
 // word seems to return an erroneous mime type :-/ 
"application/msword"  not consistent with the excel one
-inline bool isAlienWordDoc( SfxObjectShell& rDocShell ) { return 
isAlienDoc( rDocShell, "application/msword" ); }
+inline bool

[Libreoffice-bugs] [Bug 109242] FILESAVE: Button Label still align on the left ( steps in comment 3 )

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=109242

--- Comment #12 from Xavier Van Wijmeersch  ---
confirm with

Version: 6.0.0.0.alpha0+
Build ID: 3dcf6dfceee58360501396390d78c006351aef47
CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/lok_dialog' - 2 commits - libreofficekit/qa

2017-08-03 Thread Pranav Kant 
 libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx |8 
---
 libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx |   11 
+-
 2 files changed, 11 insertions(+), 8 deletions(-)

New commits:
commit 9c83e29f1f33692b51031332cc0ee35ebbe243dc
Author: Pranav Kant 
Date:   Fri Aug 4 00:02:48 2017 +0530

lokdialog: drawing area needs to have focus to capture key events

With this, key events successfully work now.

Change-Id: I6dc6aff91dea08fcbc7ab840a77e2542ab9048ce

diff --git a/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx 
b/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx
index 6b19ddc506c0..e37f9f274062 100644
--- a/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx
@@ -110,7 +110,7 @@ gtv_lok_dialog_signal_button(GtkWidget* pDialogDrawingArea, 
GdkEventButton* pEve
(int)pEvent->x, (int)pEvent->y,
(int)pixelToTwip(pEvent->x),
(int)pixelToTwip(pEvent->y));
-gtk_widget_grab_focus(GTK_WIDGET(pDialog));
+gtk_widget_grab_focus(pDialogDrawingArea);
 
 switch (pEvent->type)
 {
@@ -194,7 +194,6 @@ gtv_lok_dialog_signal_motion(GtkWidget* pDialogDrawingArea, 
GdkEventButton* pEve
(int)pEvent->x, (int)pEvent->y,
(int)pixelToTwip(pEvent->x),
(int)pixelToTwip(pEvent->y));
-gtk_widget_grab_focus(GTK_WIDGET(pDialog));
 
 pDocument->pClass->postDialogMouseEvent(pDocument,
 priv->dialogid,
@@ -216,6 +215,7 @@ gtv_lok_dialog_signal_key(GtkWidget* pDialogDrawingArea, 
GdkEventKey* pEvent)
 GtvApplicationWindow* window = 
GTV_APPLICATION_WINDOW(gtk_window_get_transient_for(GTK_WINDOW(pDialog)));
 LibreOfficeKitDocument* pDocument = 
lok_doc_view_get_document(LOK_DOC_VIEW(window->lokdocview));
 
+g_info("lok_dialog_signal_key");
 int nCharCode = 0;
 int nKeyCode = 0;
 priv->m_nKeyModifier &= KEY_MOD2;
@@ -334,12 +334,14 @@ gtv_lok_dialog_init(GtvLokDialog* dialog)
 priv->m_nKeyModifier = 0;
 priv->m_nLastButtonPressed = 0;
 
-gtk_widget_add_events(GTK_WIDGET(priv->pDialogDrawingArea),
+gtk_widget_add_events(priv->pDialogDrawingArea,
   GDK_BUTTON_PRESS_MASK
   |GDK_BUTTON_RELEASE_MASK
   |GDK_BUTTON_MOTION_MASK
   |GDK_KEY_PRESS_MASK
   |GDK_KEY_RELEASE_MASK);
+// This is required to be able to capture key events on the drawing area
+gtk_widget_set_can_focus(priv->pDialogDrawingArea, true);
 
 g_signal_connect(G_OBJECT(priv->pDialogDrawingArea), "draw", 
G_CALLBACK(gtv_lok_dialog_draw), nullptr);
 g_signal_connect(G_OBJECT(priv->pDialogDrawingArea), "button-press-event", 
G_CALLBACK(gtv_lok_dialog_signal_button), nullptr);
commit 932993df9e866d586328a6d8d26ae23edc8600f3
Author: Pranav Kant 
Date:   Fri Aug 4 00:02:38 2017 +0530

lokdialog: Invalid free

Change-Id: I7713b8d025652770e7e46603edbaa86951588871

diff --git 
a/libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx 
b/libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx
index 72916b56f9ce..1dc1d3a38e23 100644
--- a/libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx
@@ -311,14 +311,15 @@ void LOKDocViewSigHandlers::dialogChild(LOKDocView* 
pDocView, gchar* pPayload, g
   std::string aAction = aRoot.get("action");
   std::string aPos = aRoot.get("position");
   gchar** ppCoordinates = g_strsplit(aPos.c_str(), ", ", 2);
+  gchar** ppCoordinate = ppCoordinates;
   int nX = 0;
   int nY = 0;
 
-  if (*ppCoordinates)
-  nX = atoi(*ppCoordinates);
-  ++ppCoordinates;
-  if (*ppCoordinates)
-  nY = atoi(*ppCoordinates);
+  if (*ppCoordinate)
+  nX = atoi(*ppCoordinate);
+  ++ppCoordinate;
+  if (*ppCoordinate)
+  nY = atoi(*ppCoordinate);
 
   g_strfreev(ppCoordinates);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 111316] FILESAVE pptx exported Slide can fails to open in MS-PowerPoint

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111316

--- Comment #2 from Christian  ---
Created attachment 135104
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135104=edit
LO 5.2.0.4 generated .pptx from the .odp attached to this bug

This is the resulting .pptx which I did a save as... on from the .odp provided
here as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111316] FILESAVE pptx exported Slide can fails to open in MS-PowerPoint

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111316

--- Comment #1 from Christian  ---
Created attachment 135103
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135103=edit
.odp file which will generate a broken .pptx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111316] New: FILESAVE pptx exported Slide can fails to open in MS-PowerPoint

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111316

Bug ID: 111316
   Summary: FILESAVE pptx exported Slide can fails to open in
MS-PowerPoint
   Product: LibreOffice
   Version: 5.2.0.4 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: cp...@gmx.de

Description:
When the provided pptx is opened in MS-PowerPoint it complains that the data is
broken and wants to compare it.

There is on text filed on the Slide Master which appears to be the problematic
element. I can not see anything special about this element. 

Please export it in a way which does not make MS-PP puke on it to improve
interoperability. 

Steps to Reproduce:
1. Open the provided .odp
2. File > Save as > chose .pptx format (MS PowerPoint 2007-2013)
3. Open the generated file in MS-PowerPoint (I used Version 2010)

Actual Results:  
Master of the slide is not properly displayed 

Expected Results:
The exported file should just open fine in MS-PP


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
Firefox/52.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 110443] View settings not preserved saving a calc file loaded in hidden mode.

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=110443

Jacques Guilleron  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||guillero...@aol.com
 Ever confirmed|0   |1

--- Comment #2 from Jacques Guilleron  ---
Hi Luis,

I reproduce with 
LO 5.4.0.3 (x64) Build ID: 92c2794a7c181ba4c1c5053618179937228ed1fb
Threads CPU : 2; OS : Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: CL
I Tried also with a populated sheet without result.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/lok_dialog' - libreofficekit/qa

2017-08-03 Thread Pranav Kant 
 libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx |   14 
+++---
 libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.hxx |2 -
 libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx |   14 
+-
 3 files changed, 25 insertions(+), 5 deletions(-)

New commits:
commit 9c44a71a06cb2312fd24ffd7c48302f0ae7807c1
Author: Pranav Kant 
Date:   Thu Aug 3 22:58:04 2017 +0530

lokdialog: Move the floating window to its actual position

gtk_window_move them to the position broadcasted to us by vcl

Change-Id: Id27b52a24e721b51d7a153cc7c0e03197a99ee2f

diff --git a/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx 
b/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx
index 1bfb9d538ead..6b19ddc506c0 100644
--- a/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx
@@ -460,7 +460,7 @@ gtv_lok_dialog_invalidate(GtvLokDialog* dialog)
 gtk_widget_queue_draw(priv->pDialogDrawingArea);
 }
 
-void gtv_lok_dialog_child_invalidate(GtvLokDialog* dialog)
+void gtv_lok_dialog_child_invalidate(GtvLokDialog* dialog, int nX, int nY)
 {
 g_info("Dialog's floating window invalidate");
 
@@ -474,14 +474,22 @@ void gtv_lok_dialog_child_invalidate(GtvLokDialog* dialog)
 gtk_container_add(GTK_CONTAINER(priv->pFloatingWin), pDrawingArea);
 
 gtk_window_set_transient_for(GTK_WINDOW(priv->pFloatingWin), 
GTK_WINDOW(dialog));
-gtk_window_set_position(GTK_WINDOW(priv->pFloatingWin), GTK_WIN_POS_MOUSE);
 gtk_window_set_destroy_with_parent(GTK_WINDOW(priv->pFloatingWin), true);
-
 g_signal_connect(G_OBJECT(pDrawingArea), "draw", 
G_CALLBACK(gtv_lok_dialog_floating_win_draw), dialog);
 
 gtk_widget_set_size_request(priv->pFloatingWin, 1, 1);
+gtk_window_set_type_hint(GTK_WINDOW(priv->pFloatingWin), 
GDK_WINDOW_TYPE_HINT_POPUP_MENU);
+gtk_window_set_screen(GTK_WINDOW(priv->pFloatingWin), 
gtk_window_get_screen(GTK_WINDOW(dialog)));
+
 gtk_widget_show_all(priv->pFloatingWin);
 gtk_window_present(GTK_WINDOW(priv->pFloatingWin));
+
+// Get the root coords of our new floating window
+GdkWindow* pGdkWin = gtk_widget_get_window(GTK_WIDGET(dialog));
+int nrX = 0;
+int nrY = 0;
+gdk_window_get_root_coords(pGdkWin, nX, nY, , );
+gtk_window_move(GTK_WINDOW(priv->pFloatingWin), nrX, nrY);
 }
 
 void gtv_lok_dialog_child_close(GtvLokDialog* dialog)
diff --git a/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.hxx 
b/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.hxx
index bce9edbadba1..ba565b4cebb0 100644
--- a/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.hxx
+++ b/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.hxx
@@ -39,7 +39,7 @@ GtkWidget* gtv_lok_dialog_new(LOKDocView* pDocView, const 
gchar* dialogId);
 
 void gtv_lok_dialog_invalidate(GtvLokDialog* dialog);
 
-void gtv_lok_dialog_child_invalidate(GtvLokDialog* dialog);
+void gtv_lok_dialog_child_invalidate(GtvLokDialog* dialog, int nX, int nY);
 
 void gtv_lok_dialog_child_close(GtvLokDialog* dialog);
 
diff --git 
a/libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx 
b/libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx
index d0778cef473d..72916b56f9ce 100644
--- a/libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx
@@ -309,6 +309,18 @@ void LOKDocViewSigHandlers::dialogChild(LOKDocView* 
pDocView, gchar* pPayload, g
   boost::property_tree::read_json(aStream, aRoot);
   std::string aDialogId = aRoot.get("dialogId");
   std::string aAction = aRoot.get("action");
+  std::string aPos = aRoot.get("position");
+  gchar** ppCoordinates = g_strsplit(aPos.c_str(), ", ", 2);
+  int nX = 0;
+  int nY = 0;
+
+  if (*ppCoordinates)
+  nX = atoi(*ppCoordinates);
+  ++ppCoordinates;
+  if (*ppCoordinates)
+  nY = atoi(*ppCoordinates);
+
+  g_strfreev(ppCoordinates);
 
   // temporary hack to invalidate/close floating window of all opened dialogs
   GList* pChildWins = gtv_application_window_get_all_child_windows(window);
@@ -316,7 +328,7 @@ void LOKDocViewSigHandlers::dialogChild(LOKDocView* 
pDocView, gchar* pPayload, g
   for (pIt = pChildWins; pIt != nullptr; pIt = pIt->next)
   {
   if (aAction == "invalidate")
-  gtv_lok_dialog_child_invalidate(GTV_LOK_DIALOG(pIt->data));
+  gtv_lok_dialog_child_invalidate(GTV_LOK_DIALOG(pIt->data), nX, nY);
   else if (aAction == "close")
   gtv_lok_dialog_child_close(GTV_LOK_DIALOG(pIt->data));
   }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 103945] Assertion when opening character properties dialog

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=103945

Telesto  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #3 from Telesto  ---
(In reply to Julien Nabet from comment #2)
> On pc Debian x86-64 with master sources updated today + enable-dbgutil, I
> don't reproduce the assert (gtk3 + gen rendering)
> 
> Any update with more recent sources?
> If assert reproduced, any chance for a bt?

No repro with Impress. However, I can produce this with Draw:
1. Open Draw with debug symbols
2. Open character properties dialog: Format -> Character...

Version: 6.0.0.0.alpha0+
Build ID: 9ca7bda2cc8b67c2d10fcb81cce8bfd4d8b79b09
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86@39, Branch:master, Time: 2017-08-02_01:19:29
Locale: nl-NL (nl_NL); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 110736] SAVING : Calc freezes during saving a remote file on Google Drive

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=110736

Thomas S.  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 110736] SAVING : Calc freezes during saving a remote file on Google Drive

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=110736

--- Comment #3 from Thomas S.  ---
So, I tried with LibreOffice 5.3.4 then 5.4.0.3. The problem is still there,
everything works the same way (doesn't respond when saving etc.).

I have another remark though (regardless of the version) : Everything works
fine when I edit the file just after opening, but after I have saved once, calc
behaves quite slowly and often freezes, when working on the file. It's very
annoying.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111311] EDITING: Blue header line will disappear after inserting a special character

2017-08-03 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=111311

Telesto  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

  1   2   3   4   >