[Libreoffice-commits] core.git: Branch 'feature/lok_dialog' - 1575 commits - accessibility/inc accessibility/source android/Bootstrap android/.gitignore android/README android/source apple_remote/sour

[Pranav Kant]

Rebased ref, commits from common ancestor:
commit 20f04025ca8b5ff60ebb9e46fcbd162b3e30193c
Author: Pranav Kant 
Date:   Fri Aug 18 15:26:26 2017 +0530

lokdialog: lok header changes

Change-Id: I1947dc84c91e2e01072fbff3e97aa94d514ecb5a

diff --git a/include/LibreOfficeKit/LibreOfficeKit.hxx 
b/include/LibreOfficeKit/LibreOfficeKit.hxx
index 10e0f0f199d0..d4e891af218a 100644
--- a/include/LibreOfficeKit/LibreOfficeKit.hxx
+++ b/include/LibreOfficeKit/LibreOfficeKit.hxx
@@ -156,6 +156,25 @@ public:
 }
 
 /**
+ * Renders a dialog with give dialog id and writes the width and height of 
the rendered dialog
+ *
+ * Client must truncate pBuffer according to the nWidth and nHeight 
returned after the call.
+ *
+ * @param pDialogId Unique dialog id to be painted
+ * @param pBuffer Buffer with enough memory allocated to render any dialog
+ * @param nWidth output parameter returning the width of the rendered 
dialog.
+ * @param nHeight output parameter returning the height of the rendered 
dialog
+ */
+void paintDialog(const char* pDialogId,
+ unsigned char* pBuffer,
+ int& nWidth,
+ int& nHeight)
+{
+return mpDoc->pClass->paintDialog(mpDoc, pDialogId, pBuffer,
+  &nWidth, &nHeight);
+}
+
+/**
  * Gets the tile mode: the pixel format used for the pBuffer of 
paintTile().
  *
  * @return an element of the LibreOfficeKitTileMode enum.
@@ -236,6 +255,22 @@ public:
 }
 
 /**
+ * Posts a mouse event to the dialog with given id.
+ *
+ * @param aDialogId Dialog id where mouse event is to be posted
+ * @param nType Event type, like down, move or up.
+ * @param nX horizontal position in document coordinates
+ * @param nY vertical position in document coordinates
+ * @param nCount number of clicks: 1 for single click, 2 for double click
+ * @param nButtons: which mouse buttons: 1 for left, 2 for middle, 4 right
+ * @param nModifier: which keyboard modifier: (see include/vcl/vclenum.hxx 
for possible values)
+ */
+void postDialogMouseEvent(const char* pDialogId, int nType, int nX, int 
nY, int nCount, int nButtons, int nModifier)
+{
+mpDoc->pClass->postDialogMouseEvent(mpDoc, pDialogId, nType, nX, nY, 
nCount, nButtons, nModifier);
+}
+
+/**
  * Posts an UNO command to the document.
  *
  * Example argument string:
commit 9b7a0e9860eceeda60e99d2a921e99a2341381c5
Author: Pranav Kant 
Date:   Wed Aug 16 08:46:40 2017 +0530

CD_DIALOG_INVALIDATE -> DIALOG

Change-Id: Ifdda1c868e19700013a0742a0a547c0a4e040fba

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 936c4d13e244..49b2b62639f4 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -782,7 +782,7 @@ void CallbackFlushHandler::queue(const int type, const 
char* data)
 case LOK_CALLBACK_SET_PART:
 case LOK_CALLBACK_TEXT_VIEW_SELECTION:
 case LOK_CALLBACK_INVALIDATE_HEADER:
-case LOK_CALLBACK_DIALOG_INVALIDATE:
+case LOK_CALLBACK_DIALOG:
 {
 const auto& pos = std::find_if(m_queue.rbegin(), m_queue.rend(),
 [type] (const queue_type::value_type& elem) { return 
(elem.first == type); });
commit 05bbc0038fcf7e61351c49a5658f34ee39daf7f9
Author: Pranav Kant 
Date:   Tue Aug 15 18:54:02 2017 +0530

lokdialog: Smoother mouse move on floating windows

Do away with an early hack to create the floating window with every
invalidate.

This gets rid of persistent blinking when moving the mouse over a
listbox, for example.

Change-Id: Ida9367156605edc9835529f83529363ad97beaee

diff --git a/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx 
b/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx
index ec734a011a88..43c14712646a 100644
--- a/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx
@@ -598,34 +598,34 @@ void gtv_lok_dialog_child_invalidate(GtvLokDialog* 
dialog, int nX, int nY)
 
 GtvLokDialogPrivate* priv = getPrivate(dialog);
 // remove any existing floating windows, for now
-if (priv->pFloatingWin)
-gtk_widget_destroy(priv->pFloatingWin);
-
-priv->pFloatingWin = gtk_window_new(GTK_WINDOW_POPUP);
-GtkWidget* pDrawingArea = gtk_drawing_area_new();
-gtk_container_add(GTK_CONTAINER(priv->pFloatingWin), pDrawingArea);
-
-gtk_window_set_transient_for(GTK_WINDOW(priv->pFloatingWin), 
GTK_WINDOW(dialog));
-gtk_window_set_destroy_with_parent(GTK_WINDOW(priv->pFloatingWin), true);
-
-gtk_widget_add_events(pDrawingArea,
-  GDK_BUTTON_PRESS_MASK
-  |GDK_POINTER_MOTION_MASK
-  |GDK_BUTTON_RELEASE_MASK
-  |GDK_BUTTON_MOTION_MASK);
-
-g_signal_connect(

New Defects reported by Coverity Scan for LibreOffice

[scan-admin]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

1 new defect(s) introduced to LibreOffice found with Coverity Scan.
9 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent 
build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1417678:  Error handling issues  (UNCAUGHT_EXCEPT)
/sw/source/uibase/dbui/dbmgr.cxx: 805 in SwDBManager::~SwDBManager()()



*** CID 1417678:  Error handling issues  (UNCAUGHT_EXCEPT)
/sw/source/uibase/dbui/dbmgr.cxx: 805 in SwDBManager::~SwDBManager()()
799 , pImpl(new SwDBManager_Impl(*this))
800 , pMergeEvtSrc(nullptr)
801 , m_pDoc(pDoc)
802 {
803 }
804 
>>> CID 1417678:  Error handling issues  (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::DeploymentException" is 
>>> thrown but the throw list "throw()" doesn't allow it to be thrown. This 
>>> will cause a call to unexpected() which usually calls terminate().
805 SwDBManager::~SwDBManager()
806 {
807 RevokeLastRegistrations();
808 
809 // copy required, m_DataSourceParams can be modified while 
disposing components
810 std::vector> aCopiedConnections;



To view the defects in Coverity Scan visit, 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyiAzi-2BqiP-2Fn0GhZ6XMoxLNyoKPGshfD1uM1PypPY9M-2F5f1bZDKVSQrvyuRHbqdJQPwoTl8MPwPr4unUNVvPs1HkkQDWZAvNI-2BejQFv93g4DzkzXtzNq7s31qo8Ayuva9vChXGvWsDewrjsUHa-2FezMxCZj-2BcPgPOq5gqCyxjqEyMc-3D

To manage Coverity Scan email notifications for 
"libreoffice@lists.freedesktop.org", click 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5lwWgMDuK-2FivqaohkU3M9kT-2Fww10Qt2GoaCJAOQCa0Wv4ijH4oV8jCt0XXa7QeAwh_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyiAzi-2BqiP-2Fn0GhZ6XMoxLNzu6kMKbrG1No7X1McLLYrBf-2Fh-2FZnWSHLpHQ8CeUn6S7vYuDVDf7IcovXIlanQVgO0vJjUY-2BphIDCrXzaXZyTU4F6Pp8PK95-2FsJB9zLXD8yu0EeuOynh3L8d3pKVqjYEB8W1cOnB6QRMvCAwyiUPFDA-3D

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sd/uiconfig

[Adolfo Jayme Barrientos]

 sd/uiconfig/sdraw/ui/dlgsnap.ui |   26 +-
 1 file changed, 13 insertions(+), 13 deletions(-)

New commits:
commit 40892cd3311021c55e943228e16bfd36df7b1011
Author: Adolfo Jayme Barrientos 
Date:   Sun Sep 24 19:43:48 2017 -0500

tdf#112622 Move dialog’s action buttons to the bottom

Change-Id: I41b51019ece99ab747377829bfd2473f39daf418

diff --git a/sd/uiconfig/sdraw/ui/dlgsnap.ui b/sd/uiconfig/sdraw/ui/dlgsnap.ui
index b66b879199ab..9ab94f6a6168 100644
--- a/sd/uiconfig/sdraw/ui/dlgsnap.ui
+++ b/sd/uiconfig/sdraw/ui/dlgsnap.ui
@@ -1,5 +1,5 @@
 
-
+
 
   
   
@@ -37,12 +37,12 @@
 
   
 False
+vertical
 12
 
   
 False
-vertical
-start
+end
 
   
 gtk-ok
@@ -73,30 +73,31 @@
   
 
 
-  
-gtk-delete
+  
+gtk-help
 True
 True
+True
+True
 True
 True
-bottom
+top
   
   
 False
 True
 2
+True
   
 
 
-  
-gtk-help
+  
+gtk-delete
 True
 True
-True
-True
 True
 True
-top
+bottom
   
   
 False
@@ -117,7 +118,6 @@
   
 True
 False
-vertical
 12
 
   
@@ -316,8 +316,8 @@
 
   ok
   cancel
-  delete
   help
+  delete
 
   
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - vcl/unx

[Caolán McNamara]

 vcl/unx/gtk3/gtk3gtkinst.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit 5deb6f29a4038f2de88abbc676e485f5bb5c150d
Author: Caolán McNamara 
Date:   Sun Sep 24 20:35:51 2017 +0100

fix some leaks

Change-Id: I06a3971d1d269b49b2a7954f977469fbc3d16f35
Reviewed-on: https://gerrit.libreoffice.org/42721
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 7c880270eeaf..01ec0a15abd5 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -106,7 +106,10 @@ std::vector 
GtkTransferable::getTransferDataFlavo
 
 // omit text/plain;charset=unicode since it is not well defined
 if (rtl_str_compare(pName, "text/plain;charset=unicode") == 0)
+{
+g_free(pName);
 continue;
+}
 
 for (size_t j = 0; j < SAL_N_ELEMENTS(aConversionTab); ++j)
 {
@@ -122,6 +125,7 @@ std::vector 
GtkTransferable::getTransferDataFlavo
 // them out for now before they confuse this code's clients:
 if (rtl_str_indexOfChar(pFinalName, '/') == -1)
 {
+g_free(pName);
 continue;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: framework/source include/svx svx/source

[Maxim Monastirsky]

 framework/source/uielement/toolbarmanager.cxx |6 +-
 include/svx/verttexttbxctrl.hxx   |3 +++
 svx/source/tbxctrls/verttexttbxctrl.cxx   |6 ++
 3 files changed, 10 insertions(+), 5 deletions(-)

New commits:
commit fb60217569b0fb5bc949c58b054da71992fe2582
Author: Maxim Monastirsky 
Date:   Sun Sep 24 19:27:26 2017 +0300

tdf#83320 Hide vertical text commands early

Instead of listing all commands in one big "if", just do
it unconditionally in the shared controller.

Change-Id: Ie415c4551a77ca8e1e29e73c0dabaff1dd13cbcb
Reviewed-on: https://gerrit.libreoffice.org/42715
Tested-by: Jenkins 
Reviewed-by: Maxim Monastirsky 

diff --git a/framework/source/uielement/toolbarmanager.cxx 
b/framework/source/uielement/toolbarmanager.cxx
index c5cf1738fdb2..a4525a204264 100644
--- a/framework/source/uielement/toolbarmanager.cxx
+++ b/framework/source/uielement/toolbarmanager.cxx
@@ -839,11 +839,7 @@ void ToolBarManager::CreateControllers()
 
 if (pController)
 {
-if(aCommandURL == ".uno:SwitchXFormsDesignMode" ||
-   aCommandURL == ".uno:ViewDataSourceBrowser" ||
-   aCommandURL == ".uno:ParaLeftToRight" ||
-   aCommandURL == ".uno:ParaRightToLeft"
-   )
+if (aCommandURL == ".uno:SwitchXFormsDesignMode" || 
aCommandURL == ".uno:ViewDataSourceBrowser")
 pController->setFastPropertyValue_NoBroadcast(1, 
makeAny(true));
 }
 }
diff --git a/include/svx/verttexttbxctrl.hxx b/include/svx/verttexttbxctrl.hxx
index 06a4aafa26df..920427c6746a 100644
--- a/include/svx/verttexttbxctrl.hxx
+++ b/include/svx/verttexttbxctrl.hxx
@@ -31,6 +31,9 @@ public:
 SvxVertCTLTextTbxCtrl( sal_uInt16 nSlotId, sal_uInt16 nId, ToolBox& rTbx );
 virtual ~SvxVertCTLTextTbxCtrl() override;
 
+// XInitialization
+virtual void SAL_CALL initialize(const css::uno::Sequence& 
rArguments) override;
+
 virtual voidStateChanged( sal_uInt16 nSID, SfxItemState 
eState,
   const SfxPoolItem* pState ) 
override;
 };
diff --git a/svx/source/tbxctrls/verttexttbxctrl.cxx 
b/svx/source/tbxctrls/verttexttbxctrl.cxx
index ed7184fca627..727fde8ebd45 100644
--- a/svx/source/tbxctrls/verttexttbxctrl.cxx
+++ b/svx/source/tbxctrls/verttexttbxctrl.cxx
@@ -52,6 +52,12 @@ SvxVertCTLTextTbxCtrl::~SvxVertCTLTextTbxCtrl( )
 {
 }
 
+void SvxVertCTLTextTbxCtrl::initialize(const 
css::uno::Sequence& rArguments)
+{
+SfxToolBoxControl::initialize(rArguments);
+setFastPropertyValue_NoBroadcast(1, css::uno::makeAny(true));
+}
+
 void SvxVertCTLTextTbxCtrl::StateChanged(
 sal_uInt16 nSID,
 SfxItemState eState,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/unx

[Caolán McNamara]

 vcl/unx/generic/printer/cpdmgr.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit a1976555e0ebb9fc1575c2241e8b0878ccb66410
Author: Caolán McNamara 
Date:   Sun Sep 24 20:40:41 2017 +0100

fix some newer leaks

Change-Id: I3a13406db4e441c3a29056f80cb728da2ecc3c25
Reviewed-on: https://gerrit.libreoffice.org/42720
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/unx/generic/printer/cpdmgr.cxx 
b/vcl/unx/generic/printer/cpdmgr.cxx
index 04f5adb9ce80..eb5c079e4625 100644
--- a/vcl/unx/generic/printer/cpdmgr.cxx
+++ b/vcl/unx/generic/printer/cpdmgr.cxx
@@ -248,9 +248,8 @@ CPDManager* CPDManager::tryLoadCPD()
 
 if (!pEnv || !*pEnv) {
 GDir *dir;
-GError *error = nullptr;
 const gchar *filename;
-dir = g_dir_open(BACKEND_DIR, 0, &error);
+dir = g_dir_open(BACKEND_DIR, 0, nullptr);
 if (dir != nullptr) {
 while ((filename = g_dir_read_name(dir))) {
 if (pManager == nullptr) {
@@ -328,7 +327,6 @@ const PPDParser* CPDManager::createCPDParser( const 
OUString& rPrinter )
 
 if( dest_it != m_aCPDDestMap.end() )
 {
-
 CPDPrinter* pDest = dest_it->second;
 GVariant* ret = nullptr;
 GError* error = nullptr;
@@ -457,7 +455,10 @@ const PPDParser* CPDManager::createCPDParser( const 
OUString& rPrinter )
 g_variant_unref(ret);
 }
 else
+{
+g_clear_error(&error);
 SAL_INFO("vcl.unx.print", "CPD GetAllOptions failed, falling back 
to generic driver");
+}
 }
 else
 SAL_INFO("vcl.unx.print", "no dest found for printer " << aPrinter);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/unx

[Caolán McNamara]

 vcl/unx/gtk3/gtk3gtkinst.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit 4aa12018c8078cabf1b74e5564cfac8b8a53b787
Author: Caolán McNamara 
Date:   Sun Sep 24 20:35:51 2017 +0100

fix some leaks

Change-Id: I06a3971d1d269b49b2a7954f977469fbc3d16f35
Reviewed-on: https://gerrit.libreoffice.org/42719
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 3cab164d80cf..cda9252f1dd1 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -106,7 +106,10 @@ std::vector 
GtkTransferable::getTransferDataFlavo
 
 // omit text/plain;charset=unicode since it is not well defined
 if (rtl_str_compare(pName, "text/plain;charset=unicode") == 0)
+{
+g_free(pName);
 continue;
+}
 
 for (size_t j = 0; j < SAL_N_ELEMENTS(aConversionTab); ++j)
 {
@@ -122,6 +125,7 @@ std::vector 
GtkTransferable::getTransferDataFlavo
 // them out for now before they confuse this code's clients:
 if (rtl_str_indexOfChar(pFinalName, '/') == -1)
 {
+g_free(pName);
 continue;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Caolán McNamara]

 sc/source/ui/view/gridwin.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit eaf7d58ef57daa7580057b38625cd9a96ffe2a43
Author: Caolán McNamara 
Date:   Sun Sep 24 19:15:41 2017 +0100

tdf#112388 make aComboButton release its ScGridWindow outputdevice

Change-Id: I938e36dda7fbc3b769b3fba8fd9a7d5d9b8e248c
Reviewed-on: https://gerrit.libreoffice.org/42716
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 7103511ced7b..3cff01b5ddbf 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -508,6 +508,7 @@ void ScGridWindow::dispose()
 mpNoteMarker.reset();
 mpAutoFilterPopup.disposeAndClear();
 mpDPFieldPopup.disposeAndClear();
+aComboButton.SetOutputDevice(nullptr);
 
 vcl::Window::dispose();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: locking closed bugs after some period of time ?

[Xisco Fauli]

Done ->
https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/commit/?id=76088f5be81ca2bf28c277638ffbc516020064c1


El 23/09/17 a les 01:56, Xisco Fauli ha escrit:
>
> Hello,
>
> I guess both approaches would work here, but I think, IMHO, the one
> mentioned by shinnok is easier to implement.
>
> For the time being, I already monitor incorrect workflows in Bugzilla
> with this script [1]. I'll add this one as well.
>
> Regards
>
> [1]
> https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/esc-reporting/qa-tools.py
>
> El 22/09/17 a les 19:01, Christian Lohmaier ha escrit:
>>
>> We control our bugzilla instance, so we could add this as a custom
>> feature..
>> Ciao
>> Christian
>>
>>
>> On Mi., 20. Sep. 2017, 12:49 Shinnok > > wrote:
>>
>> Hi Caolan,
>>
>> Nope, but the mentoring scripts could monitor for when that
>> happens and notify me or someone else.
>>
>> Regards,
>> Shinnok
>>
>> > On Sep 20, 2017, at 9:10 AM, Caolán McNamara
>> mailto:caol...@redhat.com>> wrote:
>> >
>> > Do we have any technical capacity to disallow bugs that are marked
>> > closed from being reopened after some timeout, say 6 or 12
>> months after
>> > getting closed ?
>> > ___
>> > LibreOffice mailing list
>> > LibreOffice@lists.freedesktop.org
>> 
>> > https://lists.freedesktop.org/mailman/listinfo/libreoffice
>>
>> ___
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org
>> 
>> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>>
>>
>>
>> ___
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>
> -- 
> Xisco Faulí
> Libreoffice QA Team
> IRC: x1sc0
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice

-- 
Xisco Faulí
Libreoffice QA Team
IRC: x1sc0

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] dev-tools.git: 2 commits - esc-reporting/qa-tools.py

[Xisco Fauli]

 esc-reporting/qa-tools.py |   45 +++--
 1 file changed, 35 insertions(+), 10 deletions(-)

New commits:
commit 76088f5be81ca2bf28c277638ffbc516020064c1
Author: Xisco Fauli 
Date:   Sun Sep 24 22:00:29 2017 +0200

QA tools: Warn about reopened bugs fixed for more than 6 months

diff --git a/esc-reporting/qa-tools.py b/esc-reporting/qa-tools.py
index 6ac2b1b..c91c91f 100755
--- a/esc-reporting/qa-tools.py
+++ b/esc-reporting/qa-tools.py
@@ -364,6 +364,9 @@ def analyze_bugzilla(statList, bugzillaData, cfg, lIgnore):
 bResolved = False
 lastAssignedEmail = ""
 patchAdded = False
+isReopened = False
+closeDate = None
+reopenerEmail = ""
 for action in row['history']:
 actionMail = action['who']
 actionDate = datetime.datetime.strptime(action['when'], 
"%Y-%m-%dT%H:%M:%SZ")
@@ -448,6 +451,7 @@ def analyze_bugzilla(statList, bugzillaData, cfg, lIgnore):
 if rowStatus == 'ASSIGNED' and addedStatus == 
'ASSIGNED':
 lastAssignedEmail = actionMail
 
+
 if actionDate >= cfg[reportPeriod] and not bResolved 
and isClosed(addedStatus) and isClosed(row['status']):
 bResolved = True
 week = str(actionDate.year) + '-' + 
str(actionDate.strftime("%V"))
@@ -522,16 +526,24 @@ def analyze_bugzilla(statList, bugzillaData, cfg, 
lIgnore):
 removeAssigned = True
 removeAssignedMail = actionMail
 
-elif newStatus and change['field_name'] == 'resolution':
-addedStatus = newStatus + "_" + change['added']
-util_increase_user_actions(statList, key, actionMail, 
bugTargets, 'status_changed', actionDate)
+elif change['field_name'] == 'resolution':
+if newStatus:
+addedStatus = newStatus + "_" + change['added']
+util_increase_user_actions(statList, key, 
actionMail, bugTargets, 'status_changed', actionDate)
+
+if actionDate >= cfg[reportPeriod] and rowStatus 
== addedStatus:
+
statList['detailedReport']['status_changed_to'][addedStatus] += 1
+
statList['detailedReport']['lists']['status_changed_to'][addedStatus][0].append(key)
+
statList['detailedReport']['lists']['status_changed_to'][addedStatus][1].append(actionMail)
 
-if actionDate >= cfg[reportPeriod] and rowStatus == 
addedStatus:
-
statList['detailedReport']['status_changed_to'][addedStatus] += 1
-
statList['detailedReport']['lists']['status_changed_to'][addedStatus][0].append(key)
-
statList['detailedReport']['lists']['status_changed_to'][addedStatus][1].append(actionMail)
+newStatus = None
 
-newStatus = None
+if change['added'] == 'FIXED' and isOpen(rowStatus):
+closeDate = actionDate
+elif change['removed'] == 'FIXED' and closeDate and 
actionDate >= cfg[reportPeriod] and \
+(actionDate - closeDate).days > 180:
+isReopened = True
+reopenerEmail = actionMail
 
 elif change['field_name'] == 'priority':
 newPriority = change['added']
@@ -708,6 +720,12 @@ def analyze_bugzilla(statList, bugzillaData, cfg, lIgnore):
 lResults['crashSignature'][0].append(rowId)
 lResults['crashSignature'][1].append('')
 
+if isReopened:
+if 'reopened6Months' not in lResults:
+lResults['reopened6Months'] = [[],[]]
+lResults['reopened6Months'][0].append(rowId)
+lResults['reopened6Months'][1].append(reopenerEmail)
+
 #In case the reporter assigned the bug to himself at creation time
 if addAssigned or (creationDate >= cfg[reportPeriod] and 
row['assigned_to'] != 'libreoffice-b...@lists.freedesktop.org' and \
 ( rowStatus == 'NEW' or rowStatus == 'UNCONFIRMED' or 
rowStatus == 'REOPENED')):
commit 8a2da47911850e75480828f6bb80a8d4b719dfd5
Author: Xisco Fauli 
Date:   Sun Sep 24 16:14:22 2017 +0200

QA tools: Warn about keyword patch added

diff --git a/esc-reporting/qa-tools.py b/esc-reporting/qa-tools.py
index fa301f7..6ac2b1b 100755
--- a/esc-reporting/qa-tools.py
+++ b/esc-reporting/qa-tools.py
@@ -363,6 +363,7 @@ def analyze_bugzilla(statList, bugzillaData, cfg, lIgnore):
 backPortAddedMail = ""
 bResolved = False
  

[Libreoffice-commits] help.git: AllLangHelp_scalc.mk source/text

[Olivier Hallot]

 AllLangHelp_scalc.mk   |1 
 source/text/scalc/01/data_provider.xhp |   53 +
 2 files changed, 54 insertions(+)

New commits:
commit 52ba0e435c17651f788021b74567c52e5c2b926f
Author: Olivier Hallot 
Date:   Sun Sep 24 15:19:57 2017 -0300

Placeholder for Calc 'data provider' help page

Change-Id: I3238c9b6e02486289463990e17ed3c59ca856b06
Reviewed-on: https://gerrit.libreoffice.org/42717
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/AllLangHelp_scalc.mk b/AllLangHelp_scalc.mk
index 5c2dd189e..ffa8ac033 100644
--- a/AllLangHelp_scalc.mk
+++ b/AllLangHelp_scalc.mk
@@ -180,6 +180,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,scalc,\
 helpcontent2/source/text/scalc/01/12120200 \
 helpcontent2/source/text/scalc/01/12120300 \
 helpcontent2/source/text/scalc/01/data_form \
+helpcontent2/source/text/scalc/01/data_provider \
 helpcontent2/source/text/scalc/01/ex_data_stat_func \
 helpcontent2/source/text/scalc/01/format_graphic \
 helpcontent2/source/text/scalc/01/ful_func \
diff --git a/source/text/scalc/01/data_provider.xhp 
b/source/text/scalc/01/data_provider.xhp
new file mode 100644
index 0..60922c45d
--- /dev/null
+++ b/source/text/scalc/01/data_provider.xhp
@@ -0,0 +1,53 @@
+
+
+
+
+
+  
+Data Provider for Spreadsheet
+/text/scalc/01/data_provider.xhp
+  
+
+
+
+
+
+
+
+
+  data provider;for spreadsheets
+
+
+
+Data Provider for 
Spreadsheets
+Data Provider for 
Spreadsheets
+
+
+
+
+Menu Data – Data 
Provider...
+
+
+
+
+Data Provider
+
+
+
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ecfd5934a904e5d478c13e2777eed09be427fe9c
Author: Olivier Hallot 
Date:   Sun Sep 24 15:19:57 2017 -0300

Updated core
Project: help  52ba0e435c17651f788021b74567c52e5c2b926f

Placeholder for Calc 'data provider' help page

Change-Id: I3238c9b6e02486289463990e17ed3c59ca856b06
Reviewed-on: https://gerrit.libreoffice.org/42717
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index bba68b154710..52ba0e435c17 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit bba68b1547105a25f16b752fd3035f51c1ed3625
+Subproject commit 52ba0e435c17651f788021b74567c52e5c2b926f
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: AllLangHelp_scalc.mk source/text

[Olivier Hallot]

 AllLangHelp_scalc.mk   |1 
 source/text/scalc/01/data_form.xhp |   56 +
 2 files changed, 57 insertions(+)

New commits:
commit bba68b1547105a25f16b752fd3035f51c1ed3625
Author: Olivier Hallot 
Date:   Sun Sep 24 12:39:32 2017 -0300

Placeholder for Calc 'data form' help page

Change-Id: I134c0f9148854c23a1252bbcb2d85b43b3654dd2
Reviewed-on: https://gerrit.libreoffice.org/42711
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/AllLangHelp_scalc.mk b/AllLangHelp_scalc.mk
index 7de32b6aa..5c2dd189e 100644
--- a/AllLangHelp_scalc.mk
+++ b/AllLangHelp_scalc.mk
@@ -179,6 +179,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,scalc,\
 helpcontent2/source/text/scalc/01/12120100 \
 helpcontent2/source/text/scalc/01/12120200 \
 helpcontent2/source/text/scalc/01/12120300 \
+helpcontent2/source/text/scalc/01/data_form \
 helpcontent2/source/text/scalc/01/ex_data_stat_func \
 helpcontent2/source/text/scalc/01/format_graphic \
 helpcontent2/source/text/scalc/01/ful_func \
diff --git a/source/text/scalc/01/data_form.xhp 
b/source/text/scalc/01/data_form.xhp
new file mode 100644
index 0..edf69ed9e
--- /dev/null
+++ b/source/text/scalc/01/data_form.xhp
@@ -0,0 +1,56 @@
+
+
+
+
+
+  
+Data Form for Spreadsheet
+/text/scalc/01/data_form.xhp
+  
+
+
+
+
+
+
+
+
+  data forms;for spreadsheets
+  data forms;insert data in spreadsheets
+  insert data;data forms for spreadsheets
+  spreadsheet;form to insert data
+
+
+
+Data Forms for 
Spreasheets
+Data Forms for Spreasheets
+
+
+
+
+Menu Data – Form...
+
+
+
+
+Form
+
+
+
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 507fedfcb30ea582eae91e26a0baf93513e29e23
Author: Olivier Hallot 
Date:   Sun Sep 24 12:39:32 2017 -0300

Updated core
Project: help  bba68b1547105a25f16b752fd3035f51c1ed3625

Placeholder for Calc 'data form' help page

Change-Id: I134c0f9148854c23a1252bbcb2d85b43b3654dd2
Reviewed-on: https://gerrit.libreoffice.org/42711
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 657385a5e4be..bba68b154710 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 657385a5e4be3bdef6aba37c17ba36e90548c911
+Subproject commit bba68b1547105a25f16b752fd3035f51c1ed3625
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: connectivity/source drawinglayer/source dtrans/source embedserv/source

[66kesara99]

 connectivity/source/commontools/dbtools.cxx|2 -
 connectivity/source/drivers/component/CTable.cxx   |2 -
 connectivity/source/drivers/dbase/DTable.cxx   |2 -
 drawinglayer/source/primitive3d/polygontubeprimitive3d.cxx |   14 -
 drawinglayer/source/primitive3d/sdrextrudelathetools3d.cxx |   20 ++---
 drawinglayer/source/primitive3d/sdrlatheprimitive3d.cxx|4 +-
 dtrans/source/cnttype/wbench/testcnttype.cxx   |4 +-
 embedserv/source/embed/ed_ipersiststr.cxx  |   12 +++
 embedserv/source/embed/syswinwrapper.cxx   |2 -
 9 files changed, 31 insertions(+), 31 deletions(-)

New commits:
commit 16549dc267149aaf098191591acb20024ea21513
Author: 66kesara99 
Date:   Sat Sep 23 07:07:14 2017 +0530

tdf#96505 Get rid of cargo cult "long" integer literals

Remove unnecessary "Long" literals in multiple locations

Change-Id: Icc44546f10fed841683053eee01b788274e0add1
Reviewed-on: https://gerrit.libreoffice.org/42683
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/connectivity/source/commontools/dbtools.cxx 
b/connectivity/source/commontools/dbtools.cxx
index 16c3d9b7782e..445d0e639275 100644
--- a/connectivity/source/commontools/dbtools.cxx
+++ b/connectivity/source/commontools/dbtools.cxx
@@ -175,7 +175,7 @@ sal_Int32 getDefaultNumberFormat(sal_Int32 _nDataType,
 {
 // generate a new format if necessary
 Reference< XNumberFormats > xFormats(_xTypes, UNO_QUERY);
-OUString sNewFormat = xFormats->generateFormat( 0L, 
_rLocale, false, false, (sal_Int16)_nScale, 1);
+OUString sNewFormat = xFormats->generateFormat( 0, 
_rLocale, false, false, (sal_Int16)_nScale, 1);
 
 // and add it to the formatter if necessary
 nFormat = xFormats->queryKey(sNewFormat, _rLocale, false);
diff --git a/connectivity/source/drivers/component/CTable.cxx 
b/connectivity/source/drivers/component/CTable.cxx
index a7e17a658874..c1a5e29b20fe 100644
--- a/connectivity/source/drivers/component/CTable.cxx
+++ b/connectivity/source/drivers/component/CTable.cxx
@@ -168,7 +168,7 @@ bool OComponentTable::seekRow(IResultSetHelper::Movement 
eCursorPosition, sal_In
 m_nFilePos = nNumberOfRecords;
 break;
 case IResultSetHelper::RELATIVE1:
-m_nFilePos = (m_nFilePos + nOffset < 0) ? 0L
+m_nFilePos = (m_nFilePos + nOffset < 0) ? 0
 : (sal_uInt32)(m_nFilePos + nOffset);
 break;
 case IResultSetHelper::ABSOLUTE1:
diff --git a/connectivity/source/drivers/dbase/DTable.cxx 
b/connectivity/source/drivers/dbase/DTable.cxx
index bed2e67af14b..a5574288a248 100644
--- a/connectivity/source/drivers/dbase/DTable.cxx
+++ b/connectivity/source/drivers/dbase/DTable.cxx
@@ -2568,7 +2568,7 @@ bool ODbaseTable::seekRow(IResultSetHelper::Movement 
eCursorPosition, sal_Int32
 m_nFilePos = nNumberOfRecords;
 break;
 case IResultSetHelper::RELATIVE1:
-m_nFilePos = (m_nFilePos + nOffset < 0) ? 0L
+m_nFilePos = (m_nFilePos + nOffset < 0) ? 0
 : (sal_uInt32)(m_nFilePos + nOffset);
 break;
 case IResultSetHelper::ABSOLUTE1:
diff --git a/drawinglayer/source/primitive3d/polygontubeprimitive3d.cxx 
b/drawinglayer/source/primitive3d/polygontubeprimitive3d.cxx
index f89e10858449..5657307dd5f3 100644
--- a/drawinglayer/source/primitive3d/polygontubeprimitive3d.cxx
+++ b/drawinglayer/source/primitive3d/polygontubeprimitive3d.cxx
@@ -82,16 +82,16 @@ namespace drawinglayer
 basegfx::B3DPolygon aNewPolygon;
 
 aNewPolygon.append(aNextLeft);
-aNewPolygon.setNormal(0L, 
basegfx::B3DVector(aNextLeft - aLeft));
+aNewPolygon.setNormal(0, 
basegfx::B3DVector(aNextLeft - aLeft));
 
 aNewPolygon.append(aLastLeft);
-aNewPolygon.setNormal(1L, 
basegfx::B3DVector(aLastLeft - aLeft));
+aNewPolygon.setNormal(1, 
basegfx::B3DVector(aLastLeft - aLeft));
 
 aNewPolygon.append(aLastRight);
-aNewPolygon.setNormal(2L, 
basegfx::B3DVector(aLastRight - aRight));
+aNewPolygon.setNormal(2, 
basegfx::B3DVector(aLastRight - aRight));
 
 aNewPolygon.append(aNextRight);
-aNewPolygon.setNormal(3L, 
basegfx::B3DVector(aNextRight - aRight));
+aNewPolygon.setNormal(3, 
basegfx::B3DVector(aNextRight - aRight));
 
 aNewPolygon.setClosed(true);
 
@@ -163,13 +163,13 @@ namespace drawinglayer
 basegfx::B3DPolygon 

[Libreoffice-commits] core.git: ios/experimental

[jan Iversen]

 ios/experimental/LibreOfficeKit/LibreOfficeKit.xcodeproj/project.pbxproj | 
 306 ++
 ios/experimental/LibreOfficeKit/LibreOfficeKit/LibreOfficeKit.h  | 
   8 
 ios/experimental/LibreOfficeKit/LibreOfficeKit/LibreOfficeKit.mm | 
  59 +
 ios/experimental/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj | 
   6 
 4 files changed, 377 insertions(+), 2 deletions(-)

New commits:
commit 3f19b593019a62d97c8739e38c32902d7e19d790
Author: jan Iversen 
Date:   Sun Sep 24 19:59:28 2017 +0200

iOS, static library.

First attempt to prelink all LO libraries into 1 static library.

With all libraries directly linking to the swift module, link time
is about 12 minutes.

Experiments let to be believe this can be reduced to 1-2 minutes
by doing prelinking, which will solve all symbols between the
libraries.

Because work will continue on the swift module, while the LoKit
is a pretty stable interface, this will save much developer time

Change-Id: I69b63481fc657f2188476f53c5b4d49abe59c5f6

diff --git 
a/ios/experimental/LibreOfficeKit/LibreOfficeKit.xcodeproj/project.pbxproj 
b/ios/experimental/LibreOfficeKit/LibreOfficeKit.xcodeproj/project.pbxproj
new file mode 100644
index ..ccff1022393c
--- /dev/null
+++ b/ios/experimental/LibreOfficeKit/LibreOfficeKit.xcodeproj/project.pbxproj
@@ -0,0 +1,306 @@
+// !$*UTF8*$!
+{
+   archiveVersion = 1;
+   classes = {
+   };
+   objectVersion = 46;
+   objects = {
+
+/* Begin PBXBuildFile section */
+   39B5D21A1F78130F008FB162 /* LibreOfficeKit.mm in Sources */ = 
{isa = PBXBuildFile; fileRef = 39B5D2191F78130F008FB162 /* LibreOfficeKit.mm 
*/; };
+   39B5D21B1F78130F008FB162 /* LibreOfficeKit.h in CopyFiles */ = 
{isa = PBXBuildFile; fileRef = 39B5D2181F78130F008FB162 /* LibreOfficeKit.h */; 
};
+/* End PBXBuildFile section */
+
+/* Begin PBXCopyFilesBuildPhase section */
+   39B5D2131F78130F008FB162 /* CopyFiles */ = {
+   isa = PBXCopyFilesBuildPhase;
+   buildActionMask = 2147483647;
+   dstPath = "include/$(PRODUCT_NAME)";
+   dstSubfolderSpec = 16;
+   files = (
+   39B5D21B1F78130F008FB162 /* LibreOfficeKit.h in 
CopyFiles */,
+   );
+   runOnlyForDeploymentPostprocessing = 0;
+   };
+/* End PBXCopyFilesBuildPhase section */
+
+/* Begin PBXFileReference section */
+   3969A8CA1F7826EB006F06A9 /* lo.xcconfig */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; name = 
lo.xcconfig; path = ../../ioswork/ios/generated/lo.xcconfig; sourceTree = 
""; };
+   39B5D2151F78130F008FB162 /* libLibreOfficeKit.a */ = {isa = 
PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = 
libLibreOfficeKit.a; sourceTree = BUILT_PRODUCTS_DIR; };
+   39B5D2181F78130F008FB162 /* LibreOfficeKit.h */ = {isa = 
PBXFileReference; lastKnownFileType = sourcecode.c.h; path = LibreOfficeKit.h; 
sourceTree = ""; };
+   39B5D2191F78130F008FB162 /* LibreOfficeKit.mm */ = {isa = 
PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = 
LibreOfficeKit.mm; sourceTree = ""; };
+/* End PBXFileReference section */
+
+/* Begin PBXFrameworksBuildPhase section */
+   39B5D2121F78130F008FB162 /* Frameworks */ = {
+   isa = PBXFrameworksBuildPhase;
+   buildActionMask = 2147483647;
+   files = (
+   );
+   runOnlyForDeploymentPostprocessing = 0;
+   };
+/* End PBXFrameworksBuildPhase section */
+
+/* Begin PBXGroup section */
+   3969A8C91F782610006F06A9 /* Support files */ = {
+   isa = PBXGroup;
+   children = (
+   3969A8CA1F7826EB006F06A9 /* lo.xcconfig */,
+   );
+   name = "Support files";
+   sourceTree = "";
+   };
+   39B5D20C1F78130F008FB162 = {
+   isa = PBXGroup;
+   children = (
+   39B5D2171F78130F008FB162 /* LibreOfficeKit */,
+   39B5D2161F78130F008FB162 /* Products */,
+   3969A8C91F782610006F06A9 /* Support files */,
+   );
+   sourceTree = "";
+   };
+   39B5D2161F78130F008FB162 /* Products */ = {
+   isa = PBXGroup;
+   children = (
+   39B5D2151F78130F008FB162 /* libLibreOfficeKit.a 
*/,
+   );
+   name = Products;
+   sourceTree = "";
+   };
+  

Build Fail because of "pdfiumlo.dll"

[ye gun kim]

My main purpose is creating Visual Studio Solution Project.

Thus, I was following instruction from
https://wiki.documentfoundation.org/Development/lode in order to build
LibreOffice in Windows.

I got stuck in "pdfiumlo.dll" issue.

LINK : fatal error LNK1181:
'C:/cygwin/home/wlfka/lode/dev/core/workdir/UnpackedTarball/lcms2/bin/lcms2.lib'
입력 파일을 열 수 없습니다.
make[1]: ***
[C:/cygwin/home/wlfka/lode/dev/core/external/pdfium/Library_pdfium.mk:10:
C:/cygwin/home/wlfka/lode/dev/core/instdir/program/pdfiumlo.dll] Error 42
make[1]: *** Waiting for unfinished jobs
make: *** [Makefile:266: build] Error 2

I found pdfiumlo.dll in
"C:\cygwin\home\wlfka\lode\dev\core\workdir\Headers\Library" but file size
is 0KB. It is empty.

My current environment is Windows 10 64bit, Cygwin x86, VS 2017 and 2015
with Windows SDK 10, 8.1, 8.0.

Please help me out with this issue... searching on google does not give me
any clue on this issue.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

libutllo.so error

[Xavier van wijmeersch]

This error i have about several days, when trying to build a daily
master and v5.4.2.0

Best regards


201070924_libutllo.so_error
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Makefile.in Repository.mk sd/source vcl/Executable_fodpfuzzer.mk vcl/Module_vcl.mk vcl/workben

[Caolán McNamara]

 Makefile.in   |2 -
 Repository.mk |1 
 sd/source/filter/xml/sdxmlwrp.cxx |   51 ++
 vcl/Executable_fodpfuzzer.mk  |   49 
 vcl/Module_vcl.mk |1 
 vcl/workben/fftester.cxx  |   14 ++
 vcl/workben/fodpfuzzer.cxx|   33 
 7 files changed, 150 insertions(+), 1 deletion(-)

New commits:
commit 14b057b7fe224ebf9409bf834e0c4c1a83187f76
Author: Caolán McNamara 
Date:   Thu Sep 21 09:43:17 2017 +0100

add fodp fuzzer

Change-Id: Ib6c439fa8db7de0544c8ee3340c07a40bf10bcb6
Reviewed-on: https://gerrit.libreoffice.org/42582
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/Makefile.in b/Makefile.in
index 62924dc2aae0..47864801fb47 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -475,7 +475,7 @@ $(foreach ide,\
 eclipsecdt,\
 $(eval $(call gb_Top_GbuildToIdeIntegrationNS,$(ide
 
-fuzzers: Library_sal Library_salhelper Library_reg Library_store 
Library_unoidl codemaker Library_cppu Library_i18nlangtag Library_cppuhelper 
Library_comphelper StaticLibrary_ulingu StaticLibrary_findsofficepath 
Library_tl Library_basegfx Library_canvastools Library_cppcanvas 
Library_dbtools Library_deploymentmisc Library_deploymentmisc Library_editeng 
Library_fwe Library_fwi Library_i18nutil Library_localebe1 Library_sax 
Library_sofficeapp Library_ucbhelper Library_opencl Rdb_services udkapi offapi 
Library_clew Library_gie Library_icg Library_reflection Library_invocadapt 
Library_bootstrap Library_introspection Library_stocservices Library_xmlreader 
Library_gcc3_uno instsetoo_native more_fonts StaticLibrary_boost_locale 
StaticLibrary_fuzzerstubs StaticLibrary_fuzzer_core StaticLibrary_fuzzer_calc 
StaticLibrary_fuzzer_draw StaticLibrary_fuzzer_writer Library_forui 
Library_binaryurp Library_io Library_invocation Library_namingservice 
Library_proxyfac Library_uuresolver Module_ure Exe
 cutable_wmffuzzer Executable_jpgfuzzer Executable_giffuzzer 
Executable_xbmfuzzer Executable_xpmfuzzer Executable_pngfuzzer 
Executable_bmpfuzzer Executable_svmfuzzer Executable_pcdfuzzer 
Executable_dxffuzzer Executable_metfuzzer Executable_ppmfuzzer 
Executable_psdfuzzer Executable_epsfuzzer Executable_pctfuzzer 
Executable_pcxfuzzer Executable_rasfuzzer Executable_tgafuzzer 
Executable_tiffuzzer Executable_hwpfuzzer Executable_602fuzzer 
Executable_lwpfuzzer Executable_olefuzzer Executable_pptfuzzer 
Executable_rtffuzzer Executable_cgmfuzzer Executable_ww2fuzzer 
Executable_ww6fuzzer Executable_ww8fuzzer Executable_qpwfuzzer 
Executable_slkfuzzer Executable_fodtfuzzer Executable_fodsfuzzer
+fuzzers: Library_sal Library_salhelper Library_reg Library_store 
Library_unoidl codemaker Library_cppu Library_i18nlangtag Library_cppuhelper 
Library_comphelper StaticLibrary_ulingu StaticLibrary_findsofficepath 
Library_tl Library_basegfx Library_canvastools Library_cppcanvas 
Library_dbtools Library_deploymentmisc Library_deploymentmisc Library_editeng 
Library_fwe Library_fwi Library_i18nutil Library_localebe1 Library_sax 
Library_sofficeapp Library_ucbhelper Library_opencl Rdb_services udkapi offapi 
Library_clew Library_gie Library_icg Library_reflection Library_invocadapt 
Library_bootstrap Library_introspection Library_stocservices Library_xmlreader 
Library_gcc3_uno instsetoo_native more_fonts StaticLibrary_boost_locale 
StaticLibrary_fuzzerstubs StaticLibrary_fuzzer_core StaticLibrary_fuzzer_calc 
StaticLibrary_fuzzer_draw StaticLibrary_fuzzer_writer Library_forui 
Library_binaryurp Library_io Library_invocation Library_namingservice 
Library_proxyfac Library_uuresolver Module_ure Exe
 cutable_wmffuzzer Executable_jpgfuzzer Executable_giffuzzer 
Executable_xbmfuzzer Executable_xpmfuzzer Executable_pngfuzzer 
Executable_bmpfuzzer Executable_svmfuzzer Executable_pcdfuzzer 
Executable_dxffuzzer Executable_metfuzzer Executable_ppmfuzzer 
Executable_psdfuzzer Executable_epsfuzzer Executable_pctfuzzer 
Executable_pcxfuzzer Executable_rasfuzzer Executable_tgafuzzer 
Executable_tiffuzzer Executable_hwpfuzzer Executable_602fuzzer 
Executable_lwpfuzzer Executable_olefuzzer Executable_pptfuzzer 
Executable_rtffuzzer Executable_cgmfuzzer Executable_ww2fuzzer 
Executable_ww6fuzzer Executable_ww8fuzzer Executable_qpwfuzzer 
Executable_slkfuzzer Executable_fodtfuzzer Executable_fodsfuzzer 
Executable_fodpfuzzer
 
 endif # MAKE_RESTARTS
 
diff --git a/Repository.mk b/Repository.mk
index 268b4982018a..c5924473eafa 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -132,6 +132,7 @@ $(eval $(call 
gb_Helper_register_executables_for_install,OOO,brand, \
$(call gb_Helper_optional,FUZZERS,slkfuzzer) \
$(call gb_Helper_optional,FUZZERS,fodtfuzzer) \
$(call gb_Helper_optional,FUZZERS,fodsfuzzer) \
+   $(call gb_Helper_optional,FUZZERS,fodpfuzzer) \
$(if $(filter-out ANDROID IOS MACOSX WNT,$(OS)),oosp

[Libreoffice-commits] core.git: dbaccess/source

[Julien Nabet]

 dbaccess/source/ui/dlg/directsql.cxx |2 +-
 dbaccess/source/ui/inc/directsql.hxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit fe0f1dba1369f5d9f382ee3432833e22fe0da442
Author: Julien Nabet 
Date:   Sun Sep 24 13:18:39 2017 +0200

Use a ref for arg of DirectSQLDialog::display

Change-Id: Ia30866edb5a243c09af3256bd963cafa9e2335ba
Reviewed-on: https://gerrit.libreoffice.org/42705
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/dbaccess/source/ui/dlg/directsql.cxx 
b/dbaccess/source/ui/dlg/directsql.cxx
index 5b109fedf23e..ed2f7c7dae5c 100644
--- a/dbaccess/source/ui/dlg/directsql.cxx
+++ b/dbaccess/source/ui/dlg/directsql.cxx
@@ -247,7 +247,7 @@ namespace dbaui
 addStatusText(sStatus);
 }
 
-void DirectSQLDialog::display(css::uno::Reference< css::sdbc::XResultSet > 
xRS)
+void DirectSQLDialog::display(const css::uno::Reference< 
css::sdbc::XResultSet >& xRS)
 {
 // get a handle for the rows
 css::uno::Reference< css::sdbc::XRow > xRow( xRS, css::uno::UNO_QUERY 
);
diff --git a/dbaccess/source/ui/inc/directsql.hxx 
b/dbaccess/source/ui/inc/directsql.hxx
index 7a48d4d58b12..5e5562f2a1f4 100644
--- a/dbaccess/source/ui/inc/directsql.hxx
+++ b/dbaccess/source/ui/inc/directsql.hxx
@@ -107,7 +107,7 @@ namespace dbaui
 void addOutputText(const OUString& _rMessage);
 
 /// displays resultset
-void display(css::uno::Reference< css::sdbc::XResultSet > xRS);
+void display(const css::uno::Reference< css::sdbc::XResultSet >& xRS);
 
 #ifdef DBG_UTIL
 const sal_Char* impl_CheckInvariants() const;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - xmloff/source

[Michael Stahl]

 xmloff/source/core/xmlexp.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e68c82d2c194aafc6406f9f27caa2d1e70a7614e
Author: Michael Stahl 
Date:   Tue Sep 19 21:43:23 2017 +0200

xmloff: fix stack-use-after-return in SvXMLExport::exportDoc()

PropertySetInfo(PropertyMapEntry const * pMap) stores the pointers,
and its lifetime is controlled by refcounting, so the lifetime
of aInfoMap can't be automatic.

ERROR: AddressSanitizer: stack-use-after-return on address ...
... is located in stack of thread T46
at offset 224 in frame SvXMLExport::exportDoc(xmloff::token::XMLTokenEnum)

This frame has 39 object(s):
  ...
  [224, 288) 'aInfoMap' <== Memory access at offset 224 is inside this 
variable

Change-Id: I4eaa9d38bab708b222d999b0982100d7ef97e95c
(cherry picked from commit ee599ea46365adc37f4d495d9ff9778c25c04c92)
Reviewed-on: https://gerrit.libreoffice.org/42505
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/xmloff/source/core/xmlexp.cxx b/xmloff/source/core/xmlexp.cxx
index aced8d37b245..cb12d33b11d5 100644
--- a/xmloff/source/core/xmlexp.cxx
+++ b/xmloff/source/core/xmlexp.cxx
@@ -1296,7 +1296,7 @@ sal_uInt32 SvXMLExport::exportDoc( enum 
::xmloff::token::XMLTokenEnum eClass )
 {
 try
 {
-::comphelper::PropertyMapEntry const aInfoMap[] =
+static ::comphelper::PropertyMapEntry const aInfoMap[] =
 {
 { OUString("Class"), 0,
 ::cppu::UnoType::get(),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sd/qa sd/source

[Tamás Zolnai]

 sd/qa/unit/data/odp/tdf112557.odp|binary
 sd/qa/unit/export-tests-ooxml2.cxx   |   14 ++
 sd/source/filter/eppt/pptx-epptooxml.cxx |   11 +++
 3 files changed, 21 insertions(+), 4 deletions(-)

New commits:
commit 9b9e576368ae36704908086ebc94e5889a7d68e8
Author: Tamás Zolnai 
Date:   Fri Sep 22 16:08:23 2017 +0200

tdf#112557: Subtitle placeholder shape leads to corrupted PPTX file

Reviewed-on: https://gerrit.libreoffice.org/42611
Tested-by: Jenkins 
Reviewed-by: Tamás Zolnai 
(cherry picked from commit 238cfa9efa21f08514703ea6cc181ce02d8feb12)

Change-Id: I26680ecdb5f0db4f27180c221de062341af0265c
Reviewed-on: https://gerrit.libreoffice.org/42650
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sd/qa/unit/data/odp/tdf112557.odp 
b/sd/qa/unit/data/odp/tdf112557.odp
new file mode 100755
index ..5587e7fcef82
Binary files /dev/null and b/sd/qa/unit/data/odp/tdf112557.odp differ
diff --git a/sd/qa/unit/export-tests-ooxml2.cxx 
b/sd/qa/unit/export-tests-ooxml2.cxx
index 3300dc4efcac..c7311ef1b5ca 100644
--- a/sd/qa/unit/export-tests-ooxml2.cxx
+++ b/sd/qa/unit/export-tests-ooxml2.cxx
@@ -102,6 +102,7 @@ public:
 void testTdf59046();
 void testTdf105739();
 void testTdf112552();
+void testTdf112557();
 
 CPPUNIT_TEST_SUITE(SdOOXMLExportTest2);
 
@@ -127,6 +128,7 @@ public:
 CPPUNIT_TEST(testTdf59046);
 CPPUNIT_TEST(testTdf105739);
 CPPUNIT_TEST(testTdf112552);
+CPPUNIT_TEST(testTdf112557);
 
 CPPUNIT_TEST_SUITE_END();
 
@@ -799,6 +801,18 @@ void SdOOXMLExportTest2::testTdf112552()
 xDocShRef->DoClose();
 }
 
+void SdOOXMLExportTest2::testTdf112557()
+{
+// Subtitle shape should be skipped by export.
+::sd::DrawDocShellRef xDocShRef = 
loadURL(m_directories.getURLFromSrc("/sd/qa/unit/data/odp/tdf112557.odp"), ODP);
+utl::TempFile tempFile;
+xDocShRef = saveAndReload(xDocShRef.get(), PPTX, &tempFile);
+
+xmlDocPtr pXmlDocContent = parseExport(tempFile, 
"ppt/slideMasters/slideMaster1.xml");
+assertXPath(pXmlDocContent, "/p:sldMaster/p:cSld/p:spTree/p:sp", 2); // 
title and object
+xDocShRef->DoClose();
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(SdOOXMLExportTest2);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sd/source/filter/eppt/pptx-epptooxml.cxx 
b/sd/source/filter/eppt/pptx-epptooxml.cxx
index cf5a37d32a48..d5b978315cf8 100644
--- a/sd/source/filter/eppt/pptx-epptooxml.cxx
+++ b/sd/source/filter/eppt/pptx-epptooxml.cxx
@@ -305,8 +305,11 @@ ShapeExport& PowerPointShapeExport::WriteUnknownShape( 
const Reference< XShape >
 }
 else if ( sShapeType == "com.sun.star.presentation.SubtitleShape" )
 {
-if( !WritePlaceholder( xShape, Subtitle, mbMaster ) )
-ShapeExport::WriteTextShape( xShape );
+if(mePageType != MASTER)
+{
+if( !WritePlaceholder( xShape, Subtitle, mbMaster ) )
+ShapeExport::WriteTextShape( xShape );
+}
 }
 
 return *this;
@@ -1714,7 +1717,7 @@ void PowerPointExport::ImplWriteSlideMaster( sal_uInt32 
nPageNum, Reference< XPr
 pFS->startElementNS( XML_p, XML_cSld, FSEND );
 
 ImplWriteBackground( pFS, aXBackgroundPropSet );
-WriteShapeTree( pFS, LAYOUT, true );
+WriteShapeTree( pFS, MASTER, true );
 
 pFS->endElementNS( XML_p, XML_cSld );
 
@@ -1871,7 +1874,7 @@ void PowerPointExport::WriteShapeTree( const FSHelperPtr& 
pFS, PageType ePageTyp
 
 ShapeExport& PowerPointShapeExport::WritePageShape( const Reference< XShape >& 
xShape, PageType ePageType, bool bPresObj )
 {
-if( ( ePageType == NOTICE && bPresObj ) || ePageType == LAYOUT )
+if( ( ePageType == NOTICE && bPresObj ) || ePageType == LAYOUT || 
ePageType == MASTER )
 return WritePlaceholderShape( xShape, SlideImage );
 
 return WriteTextShape( xShape );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - include/oox include/svx oox/source sd/qa

[Tamás Zolnai]

 include/oox/export/drawingml.hxx  |7 ++
 include/svx/EnhancedCustomShape2d.hxx |4 -
 oox/source/export/drawingml.cxx   |   89 --
 oox/source/export/shapes.cxx  |2 
 sd/qa/unit/data/odp/tdf112552.odp |binary
 sd/qa/unit/export-tests-ooxml2.cxx|   17 ++
 6 files changed, 68 insertions(+), 51 deletions(-)

New commits:
commit 2176657ce5ff01ef9f9571e3e193908692b7f04c
Author: Tamás Zolnai 
Date:   Fri Sep 22 15:56:28 2017 +0200

tdf#112552: Shape's gray background is lost after saving to PPTX

Reviewed-on: https://gerrit.libreoffice.org/42598
Tested-by: Jenkins 
Reviewed-by: Tamás Zolnai 
(cherry picked from commit 31919b8909fa7b34412dd52c3d4dff17bc5b6fab)

Change-Id: I30f371ad301eede82ddcece4d91ffcd32e164115
Reviewed-on: https://gerrit.libreoffice.org/42648
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/include/oox/export/drawingml.hxx b/include/oox/export/drawingml.hxx
index 4ee841d33eb2..677edbff5292 100644
--- a/include/oox/export/drawingml.hxx
+++ b/include/oox/export/drawingml.hxx
@@ -45,6 +45,7 @@
 #endif
 
 class Graphic;
+class SdrObjCustomShape;
 
 namespace com { namespace sun { namespace star {
 namespace awt {
@@ -58,6 +59,8 @@ namespace beans {
 }
 namespace drawing {
 class XShape;
+struct EnhancedCustomShapeParameterPair;
+struct EnhancedCustomShapeParameter;
 }
 namespace style {
 struct LineSpacing;
@@ -208,7 +211,9 @@ public:
 void WritePresetShape( const char* pShape , std::vector< 
std::pair> & rAvList );
 void WritePresetShape( const char* pShape );
 void WritePresetShape( const char* pShape, MSO_SPT eShapeType, bool 
bPredefinedHandlesUsed, sal_Int32 nAdjustmentsWhichNeedsToBeConverted, const 
css::beans::PropertyValue& rProp );
-bool WriteCustomGeometry( const css::uno::Reference& 
rXShape );
+bool WriteCustomGeometry( const css::uno::Reference& 
rXShape, const SdrObjCustomShape* pShape );
+void WriteCustomGeometryPoint(const 
css::drawing::EnhancedCustomShapeParameterPair& rParamPair, const 
SdrObjCustomShape* pShape);
+static sal_Int32 GetCustomGeometryPointValue(const 
css::drawing::EnhancedCustomShapeParameter& rParam, const SdrObjCustomShape* 
pShape);
 void WritePolyPolygon( const tools::PolyPolygon& rPolyPolygon );
 void WriteFill( const css::uno::Reference< css::beans::XPropertySet >& 
xPropSet );
 void WriteShapeStyle( const css::uno::Reference< css::beans::XPropertySet 
>& rXPropSet );
diff --git a/include/svx/EnhancedCustomShape2d.hxx 
b/include/svx/EnhancedCustomShape2d.hxx
index 87b21855aaf7..e086cede26b8 100644
--- a/include/svx/EnhancedCustomShape2d.hxx
+++ b/include/svx/EnhancedCustomShape2d.hxx
@@ -126,8 +126,6 @@ class SVX_DLLPUBLIC EnhancedCustomShape2d : public 
SfxItemSet
 SAL_DLLPRIVATE ColorGetColorData( const Color& rFillColor, 
sal_uInt32 nIndex, double dBrightness ) const;
 SAL_DLLPRIVATE void AdaptObjColor(SdrPathObj& rObj, const 
SfxItemSet& rCustomShapeSet,
   sal_uInt32& nColorIndex, 
sal_uInt32 nColorCount);
-SAL_DLLPRIVATE void GetParameter( double& rParameterReturnValue,  
const css::drawing::EnhancedCustomShapeParameter&,
-  const bool bReplaceGeoWidth, 
const bool bReplaceGeoHeight ) const;
 SAL_DLLPRIVATE PointGetPoint( const 
css::drawing::EnhancedCustomShapeParameterPair&,
 const bool bScale = true, 
const bool bReplaceGeoSize = false ) const;
 
@@ -190,6 +188,8 @@ class SVX_DLLPUBLIC EnhancedCustomShape2d : public 
SfxItemSet
 
 SAL_DLLPRIVATE double   GetEnumFunc( const 
EnhancedCustomShape::ExpressionFunct eVal ) const;
 
+void GetParameter( double& rParameterReturnValue,  const 
css::drawing::EnhancedCustomShapeParameter&,
+   const bool bReplaceGeoWidth, const bool 
bReplaceGeoHeight ) const;
 SAL_DLLPRIVATE double   GetAdjustValueAsDouble( const sal_Int32 nIndex 
) const;
 SAL_DLLPRIVATE double   GetEquationValueAsDouble( const sal_Int32 
nIndex ) const;
 
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index 1b05c1d8fb2a..16ad2a4d1749 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -90,6 +90,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace ::css;
 using namespace ::css::beans;
@@ -2377,7 +2378,7 @@ void DrawingML::WritePresetShape( const char* pShape, 
MSO_SPT eShapeType, bool b
 mpFS->endElementNS(  XML_a, XML_prstGeom );
 }
 
-bool DrawingML::WriteCustomGeometry( const Reference< XShape >& rXShape )
+bool DrawingML::WriteCustomGeometry( const Reference< XShape >& rXShape, const 
SdrObjCustomShape* pShape )
 {
 uno::Reference< beans::XPropertySet > aXPropSet;
 uno::An

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - lingucomponent/source

[Julien Nabet]

 lingucomponent/source/spellcheck/macosxspell/macspellimp.mm |   20 
 1 file changed, 8 insertions(+), 12 deletions(-)

New commits:
commit 635ea3a8f12e3e7b0cc4283126e67b1057810029
Author: Julien Nabet 
Date:   Sat Sep 16 22:14:26 2017 +0200

tdf#112425: fix 2 leaks in MacSpellChecker

by using "autorelease" keyword with init vars

corresponds to:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=83288332f7ced698610739419989c464256f1c4d
+

https://cgit.freedesktop.org/libreoffice/core/commit/?id=11fcdecb631fef7797da9489ea36468e292e2986

Change-Id: I056282460b94f8052287f5ad29d26a4870cd06a5
Reviewed-on: https://gerrit.libreoffice.org/42361
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 
Reviewed-on: https://gerrit.libreoffice.org/42703
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/lingucomponent/source/spellcheck/macosxspell/macspellimp.mm 
b/lingucomponent/source/spellcheck/macosxspell/macspellimp.mm
index 68239d90e9ed..a967731de9f3 100644
--- a/lingucomponent/source/spellcheck/macosxspell/macspellimp.mm
+++ b/lingucomponent/source/spellcheck/macosxspell/macspellimp.mm
@@ -232,14 +232,12 @@ sal_Int16 MacSpellChecker::GetSpellFailure( const 
OUString &rWord, const Locale
 {
 aEnc = 0;
 NSAutoreleasePool* pool = [[NSAutoreleasePool alloc] init];
-NSString* aNSStr = [[NSString alloc] initWithCharacters: 
reinterpret_cast(nWord.getStr()) length: nWord.getLength()];
-NSString* aLang = [[NSString alloc] initWithCharacters: 
reinterpret_cast(rLocale.Language.getStr()) length: 
rLocale.Language.getLength()];
+NSString* aNSStr = [[[NSString alloc] initWithCharacters: 
reinterpret_cast(nWord.getStr()) length: 
nWord.getLength()]autorelease];
+NSString* aLang = [[[NSString alloc] initWithCharacters: 
reinterpret_cast(rLocale.Language.getStr()) length: 
rLocale.Language.getLength()]autorelease];
 if(rLocale.Country.getLength()>0)
 {
-NSString* aCountry = [[NSString alloc] initWithCharacters: 
reinterpret_cast(rLocale.Country.getStr()) length: 
rLocale.Country.getLength()];
-NSString* aTag = @"_";
-NSString* aTaggedCountry = [aTag stringByAppendingString:aCountry];
-[aLang autorelease];
+NSString* aCountry = [[[NSString alloc] initWithCharacters: 
reinterpret_cast(rLocale.Country.getStr()) length: 
rLocale.Country.getLength()]autorelease];
+NSString* aTaggedCountry = [@"_" stringByAppendingString:aCountry];
 aLang = [aLang  stringByAppendingString:aTaggedCountry];
 }
 
@@ -334,14 +332,12 @@ Reference< XSpellAlternatives >
 if (n)
 {
 NSAutoreleasePool* pool = [[NSAutoreleasePool alloc] init];
-NSString* aNSStr = [[NSString alloc] initWithCharacters: 
reinterpret_cast(nWord.getStr()) length: nWord.getLength()];
-NSString* aLang = [[NSString alloc] initWithCharacters: 
reinterpret_cast(rLocale.Language.getStr()) length: 
rLocale.Language.getLength() ];
+NSString* aNSStr = [[[NSString alloc] initWithCharacters: 
reinterpret_cast(nWord.getStr()) length: 
nWord.getLength()]autorelease];
+NSString* aLang = [[[NSString alloc] initWithCharacters: 
reinterpret_cast(rLocale.Language.getStr()) length: 
rLocale.Language.getLength()]autorelease];
 if(rLocale.Country.getLength()>0)
 {
-NSString* aCountry = [[NSString alloc] initWithCharacters: 
reinterpret_cast(rLocale.Country.getStr()) length: 
rLocale.Country.getLength() ];
-NSString* aTag = @"_";
-NSString* aTaggedCountry = [aTag stringByAppendingString:aCountry];
-[aLang autorelease];
+NSString* aCountry = [[[NSString alloc] initWithCharacters: 
reinterpret_cast(rLocale.Country.getStr()) length: 
rLocale.Country.getLength()]autorelease];
+NSString* aTaggedCountry = [@"_" stringByAppendingString:aCountry];
 aLang = [aLang  stringByAppendingString:aTaggedCountry];
 }
 [macSpell setLanguage:aLang];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sc/qa xmloff/source

[Michael Stahl]

 sc/qa/unit/subsequent_export-test.cxx |   22 ++
 xmloff/source/draw/shapeexport.cxx|   22 +++---
 2 files changed, 37 insertions(+), 7 deletions(-)

New commits:
commit f67f4c377dde9659251829e738173a7ceb975236
Author: Michael Stahl 
Date:   Wed Sep 20 17:45:14 2017 +0200

tdf#112005 xmloff: ODF export: export embedded object text *first*

... before adding any attributes, so that the attributes don't
erroneously get added to the paragraph element.

Also fix the problem that if you set "ODF format version" to 1.1 or 1.2,
export asserts in SvXMLNamespaceMap::GetQNameByKey() because the "loext"
namespace isn't registered, and creates an invalid  element.

Change-Id: I637f9d3ff746d877ced480e35ef53f4545a06a4b
(cherry picked from commit 86f256596c8566e80993e1cf6035bc3534b6f816)
Reviewed-on: https://gerrit.libreoffice.org/42568
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/qa/unit/subsequent_export-test.cxx 
b/sc/qa/unit/subsequent_export-test.cxx
index 26ac932a7765..4e692e570784 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -126,6 +126,7 @@ public:
 void testLandscapeOrientationXLSX();
 
 void testInlineArrayXLS();
+void testEmbeddedChartODS();
 void testEmbeddedChartXLS();
 void testCellAnchoredGroupXLS();
 
@@ -235,6 +236,7 @@ public:
 CPPUNIT_TEST(testAllRowsHiddenXLSX);
 CPPUNIT_TEST(testLandscapeOrientationXLSX);
 CPPUNIT_TEST(testInlineArrayXLS);
+CPPUNIT_TEST(testEmbeddedChartODS);
 CPPUNIT_TEST(testEmbeddedChartXLS);
 CPPUNIT_TEST(testCellAnchoredGroupXLS);
 
@@ -323,6 +325,8 @@ void ScExportTest::registerNamespaces(xmlXPathContextPtr& 
pXmlXPathCtx)
 { BAD_CAST("office"), 
BAD_CAST("urn:oasis:names:tc:opendocument:xmlns:office:1.0") },
 { BAD_CAST("table"), 
BAD_CAST("urn:oasis:names:tc:opendocument:xmlns:table:1.0") },
 { BAD_CAST("text"), 
BAD_CAST("urn:oasis:names:tc:opendocument:xmlns:text:1.0") },
+{ BAD_CAST("style"), 
BAD_CAST("urn:oasis:names:tc:opendocument:xmlns:style:1.0") },
+{ BAD_CAST("draw"), 
BAD_CAST("urn:oasis:names:tc:opendocument:xmlns:drawing:1.0") },
 { BAD_CAST("xlink"), BAD_CAST("http://www.w3c.org/1999/xlink";) },
 { BAD_CAST("xdr"), 
BAD_CAST("http://schemas.openxmlformats.org/drawingml/2006/spreadsheetDrawing";) 
},
 { BAD_CAST("x"), 
BAD_CAST("http://schemas.openxmlformats.org/spreadsheetml/2006/main";) },
@@ -1922,6 +1926,24 @@ void ScExportTest::testInlineArrayXLS()
 xDocSh->DoClose();
 }
 
+void ScExportTest::testEmbeddedChartODS()
+{
+ScDocShellRef xShell = loadDoc("embedded-chart.", FORMAT_XLS);
+CPPUNIT_ASSERT(xShell.is());
+
+std::shared_ptr pTempFile(
+ScBootstrapFixture::exportTo(xShell.get(), FORMAT_ODS));
+
+xmlDocPtr pDoc = XPathHelper::parseExport(pTempFile, m_xSFactory, 
"content.xml");
+CPPUNIT_ASSERT(pDoc);
+assertXPath(pDoc,
+
"/office:document-content/office:body/office:spreadsheet/table:table[2]/table:table-row[7]/table:table-cell[2]/draw:frame/draw:object",
+"notify-on-update-of-ranges",
+"Chart1.B3:Chart1.B5 Chart1.C2:Chart1.C2 Chart1.C3:Chart1.C5");
+
+xShell->DoClose();
+}
+
 void ScExportTest::testEmbeddedChartXLS()
 {
 ScDocShellRef xShell = loadDoc("embedded-chart.", FORMAT_XLS);
diff --git a/xmloff/source/draw/shapeexport.cxx 
b/xmloff/source/draw/shapeexport.cxx
index 399544cae531..0f2194966dbb 100644
--- a/xmloff/source/draw/shapeexport.cxx
+++ b/xmloff/source/draw/shapeexport.cxx
@@ -1505,6 +1505,13 @@ bool XMLShapeExport::ImpExportPresentationAttributes( 
const uno::Reference< bean
 
 void XMLShapeExport::ImpExportText( const uno::Reference< drawing::XShape >& 
xShape, TextPNS eExtensionNS )
 {
+if (eExtensionNS == TextPNS::EXTENSION)
+{
+if (mrExport.getDefaultVersion() <= SvtSaveOptions::ODFVER_012)
+{
+return; // do not export to ODF 1.1/1.2
+}
+}
 uno::Reference< text::XText > xText( xShape, uno::UNO_QUERY );
 if( xText.is() )
 {
@@ -2770,6 +2777,14 @@ void XMLShapeExport::ImpExportOLE2Shape(
 
 if( !bIsEmptyPresObj || bSaveBackwardsCompatible )
 {
+// tdf#112005 export text *before* adding any attributes
+if (!bIsEmptyPresObj && supportsText(eShapeType))
+{
+// #i118485# Add text export, the draw OLE shape allows text 
now
+// fdo#58571 chart objects don't allow text:p
+ImpExportText( xShape, TextPNS::EXTENSION );
+}
+
 if (pAttrList)
 {
 mrExport.AddAttributeList(pAttrList);
@@ -2805,13 +2820,6 @@ void XMLShapeExport::ImpExportOLE2Shape(
 if( !sClassId.isEmpty() )
 mrExport.AddAttribute(XML_NAMESPACE_DRAW, XML_CLASS_ID,

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sc/qa xmloff/source

[Michael Stahl]

 sc/qa/unit/subsequent_export-test.cxx |   22 ++
 xmloff/source/draw/shapeexport.cxx|   22 +++---
 2 files changed, 37 insertions(+), 7 deletions(-)

New commits:
commit 65c99825ceb08743a70b6e598f65491a67d9a884
Author: Michael Stahl 
Date:   Wed Sep 20 17:45:14 2017 +0200

tdf#112005 xmloff: ODF export: export embedded object text *first*

... before adding any attributes, so that the attributes don't
erroneously get added to the paragraph element.

Also fix the problem that if you set "ODF format version" to 1.1 or 1.2,
export asserts in SvXMLNamespaceMap::GetQNameByKey() because the "loext"
namespace isn't registered, and creates an invalid  element.

Change-Id: I637f9d3ff746d877ced480e35ef53f4545a06a4b
(cherry picked from commit 86f256596c8566e80993e1cf6035bc3534b6f816)
Reviewed-on: https://gerrit.libreoffice.org/42569
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/qa/unit/subsequent_export-test.cxx 
b/sc/qa/unit/subsequent_export-test.cxx
index 9ffcdd7e7223..fa4543569b52 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -118,6 +118,7 @@ public:
 void testLandscapeOrientationXLSX();
 
 void testInlineArrayXLS();
+void testEmbeddedChartODS();
 void testEmbeddedChartXLS();
 void testCellAnchoredGroupXLS();
 
@@ -219,6 +220,7 @@ public:
 CPPUNIT_TEST(testAllRowsHiddenXLSX);
 CPPUNIT_TEST(testLandscapeOrientationXLSX);
 CPPUNIT_TEST(testInlineArrayXLS);
+CPPUNIT_TEST(testEmbeddedChartODS);
 CPPUNIT_TEST(testEmbeddedChartXLS);
 CPPUNIT_TEST(testCellAnchoredGroupXLS);
 
@@ -306,6 +308,8 @@ void ScExportTest::registerNamespaces(xmlXPathContextPtr& 
pXmlXPathCtx)
 { BAD_CAST("office"), 
BAD_CAST("urn:oasis:names:tc:opendocument:xmlns:office:1.0") },
 { BAD_CAST("table"), 
BAD_CAST("urn:oasis:names:tc:opendocument:xmlns:table:1.0") },
 { BAD_CAST("text"), 
BAD_CAST("urn:oasis:names:tc:opendocument:xmlns:text:1.0") },
+{ BAD_CAST("style"), 
BAD_CAST("urn:oasis:names:tc:opendocument:xmlns:style:1.0") },
+{ BAD_CAST("draw"), 
BAD_CAST("urn:oasis:names:tc:opendocument:xmlns:drawing:1.0") },
 { BAD_CAST("xlink"), BAD_CAST("http://www.w3c.org/1999/xlink";) },
 { BAD_CAST("xdr"), 
BAD_CAST("http://schemas.openxmlformats.org/drawingml/2006/spreadsheetDrawing";) 
},
 { BAD_CAST("x"), 
BAD_CAST("http://schemas.openxmlformats.org/spreadsheetml/2006/main";) },
@@ -1811,6 +1815,24 @@ void ScExportTest::testInlineArrayXLS()
 xDocSh->DoClose();
 }
 
+void ScExportTest::testEmbeddedChartODS()
+{
+ScDocShellRef xShell = loadDoc("embedded-chart.", FORMAT_XLS);
+CPPUNIT_ASSERT(xShell.Is());
+
+std::shared_ptr pTempFile(
+ScBootstrapFixture::exportTo(xShell.get(), FORMAT_ODS));
+
+xmlDocPtr pDoc = XPathHelper::parseExport(pTempFile, m_xSFactory, 
"content.xml");
+CPPUNIT_ASSERT(pDoc);
+assertXPath(pDoc,
+
"/office:document-content/office:body/office:spreadsheet/table:table[2]/table:table-row[7]/table:table-cell[2]/draw:frame/draw:object",
+"notify-on-update-of-ranges",
+"Chart1.B3:Chart1.B5 Chart1.C2:Chart1.C2 Chart1.C3:Chart1.C5");
+
+xShell->DoClose();
+}
+
 void ScExportTest::testEmbeddedChartXLS()
 {
 ScDocShellRef xShell = loadDoc("embedded-chart.", FORMAT_XLS);
diff --git a/xmloff/source/draw/shapeexport.cxx 
b/xmloff/source/draw/shapeexport.cxx
index 6d8f0185c249..e4ec98689841 100644
--- a/xmloff/source/draw/shapeexport.cxx
+++ b/xmloff/source/draw/shapeexport.cxx
@@ -1514,6 +1514,13 @@ bool XMLShapeExport::ImpExportPresentationAttributes( 
const uno::Reference< bean
 
 void XMLShapeExport::ImpExportText( const uno::Reference< drawing::XShape >& 
xShape, TextPNS eExtensionNS )
 {
+if (eExtensionNS == TextPNS::EXTENSION)
+{
+if (mrExport.getDefaultVersion() <= SvtSaveOptions::ODFVER_012)
+{
+return; // do not export to ODF 1.1/1.2
+}
+}
 uno::Reference< text::XText > xText( xShape, uno::UNO_QUERY );
 if( xText.is() )
 {
@@ -2780,6 +2787,14 @@ void XMLShapeExport::ImpExportOLE2Shape(
 
 if( !bIsEmptyPresObj || bSaveBackwardsCompatible )
 {
+// tdf#112005 export text *before* adding any attributes
+if (!bIsEmptyPresObj && supportsText(eShapeType))
+{
+// #i118485# Add text export, the draw OLE shape allows text 
now
+// fdo#58571 chart objects don't allow text:p
+ImpExportText( xShape, TextPNS::EXTENSION );
+}
+
 if (pAttrList)
 {
 mrExport.AddAttributeList(pAttrList);
@@ -2815,13 +2830,6 @@ void XMLShapeExport::ImpExportOLE2Shape(
 if( !sClassId.isEmpty() )
 mrExport.AddAttribute(XML_NAMESPACE_DRAW, XML_CLASS_ID,

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - xmloff/source

[Michael Stahl]

 xmloff/source/core/xmlexp.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 89a5b2c31b4c9d5e068e9d1aef2eac50d70df80e
Author: Michael Stahl 
Date:   Tue Sep 19 21:43:23 2017 +0200

xmloff: fix stack-use-after-return in SvXMLExport::exportDoc()

PropertySetInfo(PropertyMapEntry const * pMap) stores the pointers,
and its lifetime is controlled by refcounting, so the lifetime
of aInfoMap can't be automatic.

ERROR: AddressSanitizer: stack-use-after-return on address ...
... is located in stack of thread T46
at offset 224 in frame SvXMLExport::exportDoc(xmloff::token::XMLTokenEnum)

This frame has 39 object(s):
  ...
  [224, 288) 'aInfoMap' <== Memory access at offset 224 is inside this 
variable

Change-Id: I4eaa9d38bab708b222d999b0982100d7ef97e95c
(cherry picked from commit ee599ea46365adc37f4d495d9ff9778c25c04c92)
Reviewed-on: https://gerrit.libreoffice.org/42504
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/xmloff/source/core/xmlexp.cxx b/xmloff/source/core/xmlexp.cxx
index bfb18b8e0853..6c38127b9462 100644
--- a/xmloff/source/core/xmlexp.cxx
+++ b/xmloff/source/core/xmlexp.cxx
@@ -1284,7 +1284,7 @@ sal_uInt32 SvXMLExport::exportDoc( enum 
::xmloff::token::XMLTokenEnum eClass )
 {
 try
 {
-::comphelper::PropertyMapEntry const aInfoMap[] =
+static ::comphelper::PropertyMapEntry const aInfoMap[] =
 {
 { OUString("Class"), 0,
 ::cppu::UnoType::get(),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - odk/docs

[Michael Stahl]

 odk/docs/idl/main.dox |9 +
 1 file changed, 9 insertions(+)

New commits:
commit 174e8475b912d6b64f424d05f563d2ceff11d621
Author: Michael Stahl 
Date:   Tue Sep 19 17:43:55 2017 +0200

odk: document what doxygen means by "Protected Member" in IDL

Interfaces and services that are marked as "optional" in IDL are
deliberately tagged as "Protected" by doxygen, while everything else is
"Public", so that in the inheritance diagrams dashed lines are drawn
for "optional" bases and solid lines for non-optional bases.

Unfortunately this also causes doxygen to produce the text "Protected
Members", which appears hard to change, so just document it for now.

Change-Id: Ice878981bac5bbb7a8a33a10f2b5f68c394e4340
(cherry picked from commit 055456b075c0c953cd6216d518b5a92e8f5b54bf)
Reviewed-on: https://gerrit.libreoffice.org/42497
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/odk/docs/idl/main.dox b/odk/docs/idl/main.dox
index b5d1d755ed0a..5e9a6c8f953b 100644
--- a/odk/docs/idl/main.dox
+++ b/odk/docs/idl/main.dox
@@ -9,3 +9,12 @@
 /// \mainpage
 ///
 /// This is a reference documentation for the UNO IDL API.
+///
+/// \remark
+/// UNO IDL has no concept of "public" or "protected".
+/// "Protected Member" or "Protected Attribute" in the context
+/// of this IDL documentation actually means
+/// "members inherited from optional service or interface",
+/// i.e., not every implementation supports these members
+/// or attributes.
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: filter/source

[Caolán McNamara]

 filter/source/graphicfilter/itiff/itiff.cxx |   32 
 1 file changed, 32 insertions(+)

New commits:
commit 384f37c0624784dea32dabb813aba937430b22be
Author: Caolán McNamara 
Date:   Sun Sep 24 13:08:55 2017 +0100

ofz#3476 oom in tiff reader

Change-Id: Id103488ea0774b55521571f8b51059d06d4a0993
Reviewed-on: https://gerrit.libreoffice.org/42707
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/filter/source/graphicfilter/itiff/itiff.cxx 
b/filter/source/graphicfilter/itiff/itiff.cxx
index 9e5c6c62cfc0..083143600fc0 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -1366,6 +1366,38 @@ bool TIFFReader::ReadTIFF(SvStream & rTIFF, Graphic & 
rGraphic )
 
 if ( bStatus )
 {
+//sanity check consider ReadMap condition for last row and
+//last plane
+if (nCompression == 1 || nCompression == 32771)
+{
+sal_uInt32 nStripBytesPerRow;
+if (nCompression == 1)
+nStripBytesPerRow = nBytesPerRow;
+else
+nStripBytesPerRow = ( nBytesPerRow + 1 ) & 0xfffe;
+sal_uInt32 np = nPlanes - 1;
+if (np >= SAL_N_ELEMENTS(aMap))
+bStatus = false;
+sal_Int32 ny = nImageLength - 1;
+sal_uInt32 nStrip(0);
+if (bStatus)
+{
+nStrip = ny / GetRowsPerStrip() + np * nStripsPerPlane;
+if (nStrip >= aStripOffsets.size())
+bStatus = false;
+}
+if (bStatus)
+{
+auto nStart = aStripOffsets[ nStrip ] + ( ny % 
GetRowsPerStrip() ) * nStripBytesPerRow;
+auto nEnd = nStart + nBytesPerRow;
+if (nEnd > nEndOfFile)
+bStatus = false;
+}
+}
+}
+
+if ( bStatus )
+{
 pAlphaMask.reset();
 Size aTargetSize(nImageWidth, nImageLength);
 aBitmap = Bitmap(aTargetSize, nDstBitsPerPixel);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/uiconfig

[Kiyotaka Nishibori]

 sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui |   26 -
 1 file changed, 13 insertions(+), 13 deletions(-)

New commits:
commit d70988e4e3e4e9be71608242890c4a81c899cfd5
Author: Kiyotaka Nishibori 
Date:   Sun Sep 24 14:56:31 2017 +0900

Fix duplicated context attributes.

The duplication generates invalid .pot file: ./pot/sc/messages.pot.

Change-Id: If2a5248ad3226f5cc2e866fdf2033c867943e8b9
Reviewed-on: https://gerrit.libreoffice.org/42702
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui 
b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui
index fd1ecdc4aa4a..915da43f9157 100644
--- a/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui
+++ b/sc/uiconfig/scalc/ui/notebookbar_groupedbar_compact.ui
@@ -3853,7 +3853,7 @@
 True
 False
 .uno:StyleApply?Style:string=Default&FamilyName:string=CellStyles
-Default
+Default
   
 
 
@@ -3867,7 +3867,7 @@
 True
 False
 .uno:StyleApply?Style:string=Accent 
1&FamilyName:string=CellStyles
-Accent 1
+Accent 1
   
 
 
@@ -3875,7 +3875,7 @@
 True
 False
 .uno:StyleApply?Style:string=Accent 
2&FamilyName:string=CellStyles
-Accent 2
+Accent 2
   
 
 
@@ -3883,7 +3883,7 @@
 True
 False
 .uno:StyleApply?Style:string=Accent 
3&FamilyName:string=CellStyles
-Accent 3
+Accent 3
   
 
 
@@ -3897,7 +3897,7 @@
 True
 False
 .uno:StyleApply?Style:string=Heading 
1&FamilyName:string=CellStyles
-Header 1
+Header 1
   
 
 
@@ -3905,7 +3905,7 @@
 True
 False
 .uno:StyleApply?Style:string=Heading 
2&FamilyName:string=CellStyles
-Header 2
+Header 2
   
 
 
@@ -3919,7 +3919,7 @@
 True
 False
 .uno:StyleApply?Style:string=Bad&FamilyName:string=CellStyles
-Bad
+Bad
   
 
 
@@ -3927,7 +3927,7 @@
 True
 False
 .uno:StyleApply?Style:string=Error&FamilyName:string=CellStyles
-Error
+Error
   
 
 
@@ -3935,7 +3935,7 @@
 True
 False
 .uno:StyleApply?Style:string=Good&FamilyName:string=CellStyles
-Good
+Good
   
 
 
@@ -3943,7 +3943,7 @@
 True
 False
 .uno:StyleApply?Style:string=Neutral&FamilyName:string=CellStyles
-Neutral
+Neutral
   
 
 
@@ -3951,7 +3951,7 @@
 True
 False
 .uno:StyleApply?Style:string=Warning&FamilyName:string=CellStyles
-Warning
+Warning
   
 
 
@@ -3965,7 +3965,7 @@
 True
 False
 .uno:StyleApply?Style:string=Footnote&FamilyName:string=CellStyles
-Footnote
+Footnote
   
 
 
@@ -3973,7 +3973,7 @@
 True
 False
 .uno:StyleApply?Style:string=Note&FamilyName:string=CellStyles
-Note
+Note
   
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 26da7f8dcb29ae9808f31e0e9197f946b8758af6
Author: Olivier Hallot 
Date:   Sun Sep 24 11:27:25 2017 -0300

Updated core
Project: help  657385a5e4be3bdef6aba37c17ba36e90548c911

Placeholder for Calc 'XML source' help page

Awaiting for more contents

Change-Id: Ie43002a9abf255d81c7cd77fe5d453c490f7bdb5
Reviewed-on: https://gerrit.libreoffice.org/42710
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 55ffe5b2a3b2..657385a5e4be 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 55ffe5b2a3b2ef10e16d271ca9b11e7615b4db83
+Subproject commit 657385a5e4be3bdef6aba37c17ba36e90548c911
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: 2 commits - AllLangHelp_scalc.mk source/text

[Olivier Hallot]

 AllLangHelp_scalc.mk  |2 +
 source/text/scalc/01/live_data_stream.xhp |   53 ++
 source/text/scalc/01/xml_source.xhp   |   53 ++
 source/text/shared/need_help.xhp  |4 +-
 4 files changed, 110 insertions(+), 2 deletions(-)

New commits:
commit 657385a5e4be3bdef6aba37c17ba36e90548c911
Author: Olivier Hallot 
Date:   Sun Sep 24 11:27:25 2017 -0300

Placeholder for Calc 'XML source' help page

Awaiting for more contents

Change-Id: Ie43002a9abf255d81c7cd77fe5d453c490f7bdb5
Reviewed-on: https://gerrit.libreoffice.org/42710
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/AllLangHelp_scalc.mk b/AllLangHelp_scalc.mk
index 3a7caad48..7de32b6aa 100644
--- a/AllLangHelp_scalc.mk
+++ b/AllLangHelp_scalc.mk
@@ -248,6 +248,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,scalc,\
 helpcontent2/source/text/scalc/01/stat_data \
 helpcontent2/source/text/scalc/01/ODFF \
 helpcontent2/source/text/scalc/01/text2columns \
+helpcontent2/source/text/scalc/01/xml_source \
 helpcontent2/source/text/scalc/02/0213 \
 helpcontent2/source/text/scalc/02/0214 \
 helpcontent2/source/text/scalc/02/0215 \
diff --git a/source/text/scalc/01/xml_source.xhp 
b/source/text/scalc/01/xml_source.xhp
new file mode 100644
index 0..e3ee4eb33
--- /dev/null
+++ b/source/text/scalc/01/xml_source.xhp
@@ -0,0 +1,53 @@
+
+
+
+
+
+  
+Live Data Stream
+/text/scalc/01/xml_source.xhp
+  
+
+
+
+
+
+
+
+
+  XML Source;load XML data in spreadsheets
+
+
+
+XML 
Source
+Live data stream for 
spreadsheets
+
+
+
+
+Menu Data – XML 
Source...
+
+
+
+
+XML 
Source
+
+
+
+
commit 55ffe5b2a3b2ef10e16d271ca9b11e7615b4db83
Author: Olivier Hallot 
Date:   Sun Sep 24 10:57:10 2017 -0300

placeholder for Calc 'data stream' help page

Awaiting for more contents

Change-Id: Ia44adb3f25f26df5b2f0ec360ac9d0cc421d8fe3
Reviewed-on: https://gerrit.libreoffice.org/42709
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/AllLangHelp_scalc.mk b/AllLangHelp_scalc.mk
index 6e1c0502f..3a7caad48 100644
--- a/AllLangHelp_scalc.mk
+++ b/AllLangHelp_scalc.mk
@@ -240,6 +240,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,scalc,\
 helpcontent2/source/text/scalc/01/func_workday \
 helpcontent2/source/text/scalc/01/func_year \
 helpcontent2/source/text/scalc/01/func_yearfrac \
+helpcontent2/source/text/scalc/01/live_data_stream \
 helpcontent2/source/text/scalc/01/solver \
 helpcontent2/source/text/scalc/01/solver_options \
 helpcontent2/source/text/scalc/01/statistics \
diff --git a/source/text/scalc/01/live_data_stream.xhp 
b/source/text/scalc/01/live_data_stream.xhp
new file mode 100644
index 0..949c3c42e
--- /dev/null
+++ b/source/text/scalc/01/live_data_stream.xhp
@@ -0,0 +1,53 @@
+
+
+
+
+
+  
+Live Data Stream
+/text/scalc/01/live_data_stream.xhp
+  
+
+
+
+
+
+
+
+
+  Data Stream;Live data stream
+
+
+
+Live Data 
Stream
+Live data stream for 
spreadsheets
+
+
+
+
+Menu Data – 
Streams...
+
+
+
+
+Data streams
+
+
+
+
diff --git a/source/text/shared/need_help.xhp b/source/text/shared/need_help.xhp
index 430358127..e39e271c2 100644
--- a/source/text/shared/need_help.xhp
+++ b/source/text/shared/need_help.xhp
@@ -20,7 +20,7 @@
 
 
   
-We Need Your Help
+We Need Your Help
 /text/shared/need_help.xhp
   
 
@@ -29,7 +29,7 @@
 
 
 
-This help page 
needs further work for correctness and completion. Please join the LibreOffice 
project and help us out to write the missing information.
+This help 
page needs further work for correctness and completion. Please join the 
LibreOffice project and help us out to write the missing information. Visit our 
http://documentation.libreoffice.org/en/join-community/update-help-contents";>web
 page on writing Help contents.
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c479d1bdcd94f4fefb54a81c4b8208cdd636b95f
Author: Olivier Hallot 
Date:   Sun Sep 24 10:57:10 2017 -0300

Updated core
Project: help  55ffe5b2a3b2ef10e16d271ca9b11e7615b4db83

placeholder for Calc 'data stream' help page

Awaiting for more contents

Change-Id: Ia44adb3f25f26df5b2f0ec360ac9d0cc421d8fe3
Reviewed-on: https://gerrit.libreoffice.org/42709
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 2ab31faddac6..55ffe5b2a3b2 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 2ab31faddac65547ac961da7fc47f0c61dd694b3
+Subproject commit 55ffe5b2a3b2ef10e16d271ca9b11e7615b4db83
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: filter/source

[Caolán McNamara]

 filter/source/graphicfilter/itiff/itiff.cxx |   70 ++--
 1 file changed, 35 insertions(+), 35 deletions(-)

New commits:
commit 1524f58340e3a6b87244e23d6d9536f25daaf550
Author: Caolán McNamara 
Date:   Sun Sep 24 13:01:15 2017 +0100

move sanity checks before allocation

Change-Id: I7374b3cc4cb7f2be9cec71a385899051288234c9
Reviewed-on: https://gerrit.libreoffice.org/42706
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/filter/source/graphicfilter/itiff/itiff.cxx 
b/filter/source/graphicfilter/itiff/itiff.cxx
index 0c5c89737642..9e5c6c62cfc0 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -518,12 +518,12 @@ bool TIFFReader::ReadMap()
 {
 for (sal_uInt32 np = 0; np < nPlanes; ++np)
 {
+if (np >= SAL_N_ELEMENTS(aMap))
+return false;
 sal_uInt32 nStrip = ny / GetRowsPerStrip() + np * 
nStripsPerPlane;
 if ( nStrip >= aStripOffsets.size())
 return false;
 pTIFF->Seek( aStripOffsets[ nStrip ] + ( ny % 
GetRowsPerStrip() ) * nStripBytesPerRow );
-if (np >= SAL_N_ELEMENTS(aMap))
-return false;
 pTIFF->ReadBytes(aMap[np].data(), nBytesPerRow);
 if (!pTIFF->good())
 return false;
@@ -1340,49 +1340,49 @@ bool TIFFReader::ReadTIFF(SvStream & rTIFF, Graphic & 
rGraphic )
 else
 nDstBitsPerPixel = 8;
 
+if ( nPlanarConfiguration == 1 )
+nPlanes = 1;
+else
+nPlanes = nSamplesPerPixel;
+
+if ( ( nFillOrder == 2 ) && ( nCompression != 5 ) ) // in 
the LZW mode bits are already being inverted
+bByteSwap = true;
+
+nStripsPerPlane = ( nImageLength - 1 ) / GetRowsPerStrip() + 1;
+bStatus = nPlanes != 0;
+}
+
+if ( bStatus )
+{
+sal_uInt64 nRowSize = (static_cast(nImageWidth) * 
nSamplesPerPixel / nPlanes * nBitsPerSample + 7) >> 3;
+if (nRowSize > SAL_MAX_INT32 / SAL_N_ELEMENTS(aMap))
+{
+SAL_WARN("filter.tiff", "Ludicrous row size of: " << 
nRowSize << " required");
+bStatus = false;
+}
+else
+nBytesPerRow = nRowSize;
+}
+
+if ( bStatus )
+{
 pAlphaMask.reset();
 Size aTargetSize(nImageWidth, nImageLength);
 aBitmap = Bitmap(aTargetSize, nDstBitsPerPixel);
 xAcc = Bitmap::ScopedWriteAccess(aBitmap);
 if (xAcc && xAcc->Width() == nImageWidth && xAcc->Height() == 
nImageLength)
 {
-if ( nPlanarConfiguration == 1 )
-nPlanes = 1;
-else
-nPlanes = nSamplesPerPixel;
-
-if ( ( nFillOrder == 2 ) && ( nCompression != 5 ) ) // 
in the LZW mode bits are already being inverted
-bByteSwap = true;
-
-nStripsPerPlane = ( nImageLength - 1 ) / GetRowsPerStrip() 
+ 1;
-bStatus = nPlanes != 0;
-
-if (bStatus)
+for (auto& j : aMap)
 {
-sal_uInt64 nRowSize = 
(static_cast(nImageWidth) * nSamplesPerPixel / nPlanes * 
nBitsPerSample + 7) >> 3;
-if (nRowSize > SAL_MAX_INT32 / SAL_N_ELEMENTS(aMap))
+try
 {
-SAL_WARN("filter.tiff", "Ludicrous row size of: " 
<< nRowSize << " required");
-bStatus = false;
+j.resize(nBytesPerRow);
 }
-else
-nBytesPerRow = nRowSize;
-}
-
-if (bStatus)
-{
-for (auto& j : aMap)
+catch (const std::bad_alloc &)
 {
-try
-{
-j.resize(nBytesPerRow);
-}
-catch (const std::bad_alloc &)
-{
-j.clear();
-bStatus = false;
-break;
-}
+j.clear();
+bStatus = false;
+break;
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-co

[Libreoffice-commits] core.git: 6 commits - include/svtools include/svx include/vcl officecfg/registry reportdesign/Library_rptui.mk reportdesign/source reportdesign/util sc/source sd/source sd/uiconf

[Maxim Monastirsky]

 include/svtools/toolbarmenu.hxx |5 
 include/svx/colorbox.hxx|2 
 include/svx/colorwindow.hxx |3 
 include/svx/tbcontrl.hxx|   23 -
 include/vcl/dockwin.hxx |5 
 include/vcl/menubtn.hxx |4 
 include/vcl/toolbox.hxx |1 
 officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu |   84 +++-
 reportdesign/Library_rptui.mk   |1 
 reportdesign/source/ui/dlg/Condition.cxx|3 
 reportdesign/source/ui/inc/toolboxcontroller.hxx|   87 
 reportdesign/source/ui/misc/rptuiservices.cxx   |3 
 reportdesign/source/ui/misc/toolboxcontroller.cxx   |  210 
--
 reportdesign/util/rptui.component   |3 
 sc/source/ui/app/scdll.cxx  |9 
 sd/source/ui/app/sddll.cxx  |6 
 sd/uiconfig/simpress/ui/dockinganimation.ui |1 
 starmath/uiconfig/smath/ui/dockingelements.ui   |1 
 svtools/source/control/toolbarmenu.cxx  |   13 
 svx/source/tbxctrls/tbcontrl.cxx|  158 +--
 svx/uiconfig/ui/colorwindow.ui  |5 
 svx/uiconfig/ui/docking3deffects.ui |1 
 svx/uiconfig/ui/dockingcolorreplace.ui  |1 
 svx/uiconfig/ui/dockingfontwork.ui  |1 
 svx/util/svxcore.component  |4 
 sw/source/uibase/app/swmodule.cxx   |9 
 vcl/source/control/menubtn.cxx  |   16 
 vcl/source/window/dockmgr.cxx   |   33 +
 vcl/source/window/dockwin.cxx   |   58 +-
 vcl/source/window/toolbox.cxx   |5 
 30 files changed, 306 insertions(+), 449 deletions(-)

New commits:
commit 10e5729fb07d6b4c66182596bd86734d0ab386b9
Author: Maxim Monastirsky 
Date:   Sun Sep 24 03:11:51 2017 +0300

tdf#106762 Avoid warning when opening and closing the color picker

... from the Drawing toolbar in Impress. The warning was
"DockingWindow has become non-layout because extra children
have been added directly to it.", but this DockingWindow is
actually a ToolBox which set as the parent of the color picker,
although it isn't really a parent in layout terms.

Change-Id: Id1384653ceda938ca0cc300c35467e562984bca1

diff --git a/include/vcl/toolbox.hxx b/include/vcl/toolbox.hxx
index 09f912ef3ba6..3ee08e7fea24 100644
--- a/include/vcl/toolbox.hxx
+++ b/include/vcl/toolbox.hxx
@@ -299,6 +299,7 @@ public:
 virtual voidResizing( Size& rSize ) override;
 virtual SizeGetOptimalSize() const override;
 virtual voiddoDeferredInit(WinBits nBits) override;
+virtual voidqueue_resize(StateChangedType eReason = 
StateChangedType::Layout) override;
 
 /// Insert a command (like '.uno:Save').
 virtual voidInsertItem( const OUString& rCommand,
diff --git a/vcl/source/window/toolbox.cxx b/vcl/source/window/toolbox.cxx
index 810c589a8333..70d031d4ee69 100644
--- a/vcl/source/window/toolbox.cxx
+++ b/vcl/source/window/toolbox.cxx
@@ -1308,6 +1308,11 @@ void ToolBox::doDeferredInit(WinBits nBits)
 mbIsDeferredInit = false;
 }
 
+void ToolBox::queue_resize(StateChangedType eReason)
+{
+Window::queue_resize(eReason);
+}
+
 ToolBox::ToolBox( vcl::Window* pParent, WinBits nStyle ) :
 DockingWindow( WindowType::TOOLBOX )
 {
commit bf9360e6f5e38c9de3b38d9748a84d4d1c5067f9
Author: Maxim Monastirsky 
Date:   Tue Sep 19 14:26:24 2017 +0300

tdf#106762 Keep the previous m_xColorWindow lifecycle

Some logic here seems to depend on it.

Change-Id: I62a2eeba1511a9be77030f726ceaa67e3ca3ace8

diff --git a/include/svx/colorbox.hxx b/include/svx/colorbox.hxx
index be6165cdc5aa..7b0f8905249c 100644
--- a/include/svx/colorbox.hxx
+++ b/include/svx/colorbox.hxx
@@ -74,6 +74,8 @@ public:
 
 void SaveValue() { m_aSaveColor = GetSelectEntryColor(); }
 bool IsValueChangedFromSaved() const { return m_aSaveColor != 
GetSelectEntryColor(); }
+
+DECL_LINK(WindowEventListener, VclWindowEvent&, void);
 };
 
 /** A wrapper for SvxColorListBox. */
diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index 5d8237f07fa0..605568a88a28 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -3351,6 +3351,15 @@ void SvxColorListBox::ShowPreview(const NamedColor 
&rColor)
 SetText(rColor.second);
 }
 
+IMPL

[Libreoffice-commits] core.git: 3 commits - android/source external/owncloud-android-lib

[Christian Lohmaier]

 android/source/build.gradle
|   14 +-
 android/source/src/java/org/libreoffice/AboutDialogFragment.java   
|6 -
 android/source/src/java/org/libreoffice/ColorPaletteAdapter.java   
|2 
 android/source/src/java/org/libreoffice/ColorPickerAdapter.java
|2 
 android/source/src/java/org/libreoffice/DocumentPartViewListAdapter.java   
|4 
 android/source/src/java/org/libreoffice/FontController.java
|   26 ++---
 android/source/src/java/org/libreoffice/FormattingController.java  
|2 
 android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java   
|   16 +--
 android/source/src/java/org/libreoffice/PresentationActivity.java  
|8 -
 android/source/src/java/org/libreoffice/TileProviderFactory.java   
|1 
 android/source/src/java/org/libreoffice/overlay/CalcHeadersController.java 
|4 
 android/source/src/java/org/libreoffice/overlay/DocumentOverlay.java   
|2 
 
android/source/src/java/org/libreoffice/storage/external/DirectoryBrowserFragment.java
 |   14 +-
 android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java  
|   36 +++
 android/source/src/java/org/libreoffice/ui/RecentFilesAdapter.java 
|4 
 external/owncloud-android-lib/ExternalProject_owncloud_android_lib.mk  
|6 -
 external/owncloud-android-lib/UnpackedTarball_owncloud_android_lib.mk  
|2 
 external/owncloud-android-lib/build.gradle 
|   49 ++
 18 files changed, 124 insertions(+), 74 deletions(-)

New commits:
commit 506f7a5e2b6af0f2bdebab257a0c8ea33e0058fb
Author: Christian Lohmaier 
Date:   Sun Sep 24 12:53:54 2017 +0200

unused import

Change-Id: I45ba3c258594e8f3b50ffdc07ca1e09dc5691c3d

diff --git a/android/source/src/java/org/libreoffice/TileProviderFactory.java 
b/android/source/src/java/org/libreoffice/TileProviderFactory.java
index a090bd337eb2..3219ce2b4a31 100644
--- a/android/source/src/java/org/libreoffice/TileProviderFactory.java
+++ b/android/source/src/java/org/libreoffice/TileProviderFactory.java
@@ -10,7 +10,6 @@ package org.libreoffice;
 
 
 import org.libreoffice.kit.LibreOfficeKit;
-import org.mozilla.gecko.gfx.GeckoLayerClient;
 
 /**
  * Create a desired instance of TileProvider.
commit d67358d05c718683ef35cdcaefc802a6403de7ee
Author: Christian Lohmaier 
Date:   Sun Sep 24 12:49:51 2017 +0200

lint: remove redundant type casts (findViewById to object of type)

Change-Id: I0ec35ea5817d110ca20942ce9d95e0120848580a

diff --git a/android/source/src/java/org/libreoffice/AboutDialogFragment.java 
b/android/source/src/java/org/libreoffice/AboutDialogFragment.java
index c5875ecf0ee3..9b9a6c7b348f 100644
--- a/android/source/src/java/org/libreoffice/AboutDialogFragment.java
+++ b/android/source/src/java/org/libreoffice/AboutDialogFragment.java
@@ -40,13 +40,13 @@ public class AboutDialogFragment extends DialogFragment {
 
 // When linking text, force to always use default color. This works
 // around a pressed color state bug.
-TextView textView = (TextView) 
messageView.findViewById(R.id.about_credits);
+TextView textView = messageView.findViewById(R.id.about_credits);
 int defaultColor = textView.getTextColors().getDefaultColor();
 textView.setTextColor(defaultColor);
 
 // Take care of placeholders in the version and vendor text views.
-TextView versionView = 
(TextView)messageView.findViewById(R.id.about_version);
-TextView vendorView = 
(TextView)messageView.findViewById(R.id.about_vendor);
+TextView versionView = messageView.findViewById(R.id.about_version);
+TextView vendorView = messageView.findViewById(R.id.about_vendor);
 try
 {
 String versionName = getActivity().getPackageManager()
diff --git a/android/source/src/java/org/libreoffice/ColorPaletteAdapter.java 
b/android/source/src/java/org/libreoffice/ColorPaletteAdapter.java
index e5e078934c71..55c12792ae0a 100644
--- a/android/source/src/java/org/libreoffice/ColorPaletteAdapter.java
+++ b/android/source/src/java/org/libreoffice/ColorPaletteAdapter.java
@@ -122,7 +122,7 @@ public class ColorPaletteAdapter extends 
RecyclerView.Adapter
 }
 
 DocumentPartView documentPartView = getItem(position);
-TextView textView = (TextView) view.findViewById(R.id.text);
+TextView textView = view.findViewById(R.id.text);
 textView.setText(documentPartView.partName);
 
-ImageView imageView = (ImageView) view.findViewById(R.id.image);
+ImageView imageView = view.findViewById(R.id.image);
 thumbnailCollector.createThumbnail(position, imageView)

[Libreoffice-commits] core.git: sal/qa sal/textenc sw/qa writerfilter/source

[Stephan Bergmann]

 sal/qa/rtl/textenc/rtl_textcvt.cxx |1 +
 sal/textenc/tencinfo.cxx   |2 ++
 sw/qa/extras/rtfexport/rtfexport2.cxx  |2 +-
 writerfilter/source/rtftok/rtfdocumentimpl.cxx |6 +-
 4 files changed, 9 insertions(+), 2 deletions(-)

New commits:
commit 53b96765c555146e5c6a3a614420bfeeebc92b58
Author: Stephan Bergmann 
Date:   Tue Sep 19 16:26:24 2017 +0200

Map Windows code page 42 to RTL_TEXTENCODING_SYMBOL

 "WideCharToMultiByte function" suggests that there 
now
is CP_SYMBOL, "Windows 2000: Symbol code page (42)."  And a little test 
program
on Windows indicates that our RTL_TEXTENCODING_SYMBOL is working the same 
way as
CP_SYMBOL, where MultiByteToWideChar maps 00..1F to U+..1F and 20..FF to
U+F020..F0FF.

At least CppunitTest_writerfilter_rtftok, when testing
writerfilter/qa/cppunittests/rtftok/data/pass/EDB-18940-1.rtf, goes into 
case
RTF_FCHARSET in RTFDocumentImpl::dispatchValue
(writerfilter/source/rtftok/rtfdispatchvalue.cxx) with nParam matching
aRTFEncodings[2] (i.e., a mapping from charset 2 to codepage 42, see
writerfilter/source/rtftok/rtfcharsets.cxx), then passes 42 into
rtl_getTextEncodingFromWindowsCodePage and obtains an unhelpful
RTL_TEXTENCODING_DONTKNOW.

testFdo72031 (sw/qa/extras/rtfexport/rtfexport2.cxx, 
CppunitTest_sw_rtfexport2)
needed to be adapted, as the circled plus from the Symbol font is now 
internally
represented as U+F0C5, not (somewhat bogusly) as U+00C5 (aka LATIN CAPTIAL
LETTER A WITH RING ABOVE).  But, when displayed with the Symobl font, the 
glyph
that is actually shown remains the circled plus.

Turns out changing rtl_getTextEncodingFromWindowsCodePage would start to 
make
CppunitTest_sw_rtfimport fail:

  Sep 20 15:49:24  vmiklos, with
   , testN823675
   (sw/qa/extras/rtfimport/rtfimport.cxx) fails, the aFont.Name is not 
"Symbol";
   sw/qa/extras/rtfimport/data/n823675.rtf contains a \fonttbl that 
specifies
   \f3 to have \fcharset2 (i.e., symbol font) and fontname "Symbol".  
However,
   RTFDocumentImpl::checkUnicode
   (writerfilter/source/rtftok/rtfdocumentimpl.cxx)
   converts m_aHexBuffer (containing "Symbol;") with nCurrentEncoding 
apparently
   being the encoding specified by \fcharset2 (i.e., now 
RTL_TEXTENCODING_SYMBOL
   instead of old RTL_TEXTENCODING_DONTKNOW), so the resulting OUString is
   garbage
   (instead of the byte-for-byte conversion to Unicode "Symbol;" that
   RTL_TEXTENCODING_DONTKNOW would do there); do you know whether such 
\fonttbl
   fontnames should actually be interpreted in the given \fcharset?
  Sep 20 15:49:24  gerrit: »Map Windows code page 42 to
   RTL_TEXTENCODING_SYMBOL« by Stephan Bergmann for master [NEW]
  Sep 20 15:51:15  sberg: let me check if the spec covers that
  Sep 20 15:54:29  sberg: i think the name is typically encoded in the
   font's encoding but probably they have to make a (likely undocumented)
   exception for symbol encoding
  Sep 20 15:57:46  sberg: the spec only says that \fcharset is 
about
   the encoding of the content using that font, i don't see it described 
what
   would be the encoding of the font name itself
  Sep 20 15:58:51  sberg: i'm not sure about if that encoding 
should or
   should not affect the encoding of the font name in general, but indeed at
   least for 2 (symbol encoding) you're right, Word doesn't encoding the 
font
   name with that encoding, either.
  Sep 20 15:59:30  vmiklos, mst_, at the top of page 14 of
   Word2007RTFSpec9.docx I see "Note that runs of text marked with a 
particular
   font index (see \fN in the Font Table section) use the codepage for that 
font
   as given by \cpgN or implied by \fcharsetN, unless they use Unicode RTF
   described in the following section."  Would that match what mst_ says?
  Sep 20 15:59:33  so if it helps you case to handle at as e.g. 
ascii,
   just for that encoding, i think there would be no problem with that.
  Sep 20 16:00:07  sberg: that still talks about the content using 
the
   font, not the strings (font names) in the font table itself, i think.
  Sep 20 16:01:17  vmiklos, what's the control word to select such a
   font, also \fN?  I don't see any such in n823675.rtf
  Sep 20 16:02:16  loircbot: e.g. \af3
  Sep 20 16:02:31  sberg: ^
  Sep 20 16:02:47  04d5a280beeeb6e056df68395dc9c3b3a674361b
  Sep 20 16:02:50  core - related: fdo#77979: writerfilter RTF 
import:
   read encoded font name -
   
http://cgit.freedesktop.org/libreoffice/core/commit/?id=04d5a280beeeb6e056df68395dc9c3b3a674361b
  Sep 20 16:02:52  sberg: ^
  Sep 20 16:04:05  mst_, thanks; 

[Libreoffice-commits] core.git: ios/experimental

[jan Iversen]

 ios/experimental/Prototype/Prototype.xcodeproj/project.pbxproj 
| 2419 --
 ios/experimental/Prototype/Prototype/AppDelegate.h 
|   19 
 ios/experimental/Prototype/Prototype/AppDelegate.m 
|  128 
 
ios/experimental/Prototype/Prototype/Assets.xcassets/AppIcon.appiconset/Contents.json
  |   53 
 
ios/experimental/Prototype/Prototype/Assets.xcassets/LaunchImage.launchimage/Contents.json
 |   36 
 ios/experimental/Prototype/Prototype/Info.plist
|   41 
 ios/experimental/Prototype/Prototype/Prefix.pch
|   22 
 ios/experimental/Prototype/Prototype/ViewController.h  
|   15 
 ios/experimental/Prototype/Prototype/ViewController.m  
|   29 
 ios/experimental/Prototype/Prototype/en.lproj/InfoPlist.strings
|2 
 ios/experimental/Prototype/Prototype/lo.h  
|   21 
 ios/experimental/Prototype/Prototype/lo.mm 
|   99 
 ios/experimental/Prototype/Prototype/main.m
|   20 
 13 files changed, 2904 deletions(-)

New commits:
commit b97181e07a2adae0eb063f2192a256bcf75325e5
Author: jan Iversen 
Date:   Sun Sep 24 13:39:10 2017 +0200

iOS, removed outdated prototype

removed experiments prototype.

Change-Id: I691c82dca79c652d9a7c6078f2c69dada9034a36

diff --git a/ios/experimental/Prototype/Prototype.xcodeproj/project.pbxproj 
b/ios/experimental/Prototype/Prototype.xcodeproj/project.pbxproj
deleted file mode 100644
index 4f8816ae3035..
--- a/ios/experimental/Prototype/Prototype.xcodeproj/project.pbxproj
+++ /dev/null
@@ -1,2419 +0,0 @@
-// !$*UTF8*$!
-{
-   archiveVersion = 1;
-   classes = {
-   };
-   objectVersion = 48;
-   objects = {
-
-/* Begin PBXBuildFile section */
-   399857461E56322300F2DA60 /* InfoPlist.strings in Resources */ = 
{isa = PBXBuildFile; fileRef = 399857441E56322300F2DA60 /* InfoPlist.strings 
*/; };
-   BE82BD7618218E2E00A447B5 /* Foundation.framework in Frameworks 
*/ = {isa = PBXBuildFile; fileRef = BE82BD7518218E2E00A447B5 /* 
Foundation.framework */; };
-   BE82BD7818218E2E00A447B5 /* CoreGraphics.framework in 
Frameworks */ = {isa = PBXBuildFile; fileRef = BE82BD7718218E2E00A447B5 /* 
CoreGraphics.framework */; };
-   BE82BD7A18218E2E00A447B5 /* UIKit.framework in Frameworks */ = 
{isa = PBXBuildFile; fileRef = BE82BD7918218E2E00A447B5 /* UIKit.framework */; 
};
-   BE82BD8018218E2E00A447B5 /* InfoPlist.strings in Resources */ = 
{isa = PBXBuildFile; fileRef = BE82BD7E18218E2E00A447B5 /* InfoPlist.strings 
*/; };
-   BE82BD8218218E2E00A447B5 /* main.m in Sources */ = {isa = 
PBXBuildFile; fileRef = BE82BD8118218E2E00A447B5 /* main.m */; };
-   BE82BD8618218E2E00A447B5 /* AppDelegate.m in Sources */ = {isa 
= PBXBuildFile; fileRef = BE82BD8518218E2E00A447B5 /* AppDelegate.m */; };
-   BE82BD8C18218E2E00A447B5 /* ViewController.m in Sources */ = 
{isa = PBXBuildFile; fileRef = BE82BD8B18218E2E00A447B5 /* ViewController.m */; 
};
-   BE82BD8E18218E2E00A447B5 /* Assets.xcassets in Resources */ = 
{isa = PBXBuildFile; fileRef = BE82BD8D18218E2E00A447B5 /* Assets.xcassets */; 
};
-   BECAB372186054DE00F814F9 /* lo.mm in Sources */ = {isa = 
PBXBuildFile; fileRef = BECAB371186054DE00F814F9 /* lo.mm */; };
-   BED2593F18F6B87900C94C72 /* ImageIO.framework in Frameworks */ 
= {isa = PBXBuildFile; fileRef = BED2593E18F6B87900C94C72 /* ImageIO.framework 
*/; };
-   BED2594118F6B89000C94C72 /* MobileCoreServices.framework in 
Frameworks */ = {isa = PBXBuildFile; fileRef = BED2594018F6B89000C94C72 /* 
MobileCoreServices.framework */; };
-   BEEE02D11860ABDB00FBDE67 /* program in Resources */ = {isa = 
PBXBuildFile; fileRef = BEEE02CE1860ABB700FBDE67 /* program */; };
-   BEEE02D21860ABDB00FBDE67 /* share in Resources */ = {isa = 
PBXBuildFile; fileRef = BEEE02CF1860ABB700FBDE67 /* share */; };
-   BEEE02D31860ABDB00FBDE67 /* services in Resources */ = {isa = 
PBXBuildFile; fileRef = BEEE02D01860ABB700FBDE67 /* services */; };
-   BEEEFE011860A89100FBDE67 /* fundamentalrc in Resources */ = 
{isa = PBXBuildFile; fileRef = BEEEF96D1860A82900FBDE67 /* fundamentalrc */; };
-   BEEEFE021860A89100FBDE67 /* offapi.rdb in Resources */ = {isa = 
PBXBuildFile; fileRef = BEEEF96E1860A82900FBDE67 /* offapi.rdb */; };
-   BEEEFE031860A89100FBDE67 /* oovbaapi.rdb in Resources */ = {isa 
= PBXBuildFile; fileRef = BEEEF96F1860A82900FBDE67 /* oovbaapi.rdb */; };
-   BEEEFE041860A89100FBDE67 /* rc in Resour

[Libreoffice-commits] core.git: sd/uiconfig

[Yousuf Philips]

 sd/uiconfig/simpress/popupmenu/page.xml |   22 ++
 sd/uiconfig/simpress/popupmenu/pagepane.xml |   23 ++-
 2 files changed, 44 insertions(+), 1 deletion(-)

New commits:
commit 7fa728c40897041a18b988853d09e685236ff061
Author: Yousuf Philips 
Date:   Sat Sep 23 22:30:21 2017 +0400

tdf#96411 Add slide layout to context menus

Change-Id: Ia1a277b39ea1d553ff32af4b0287603dcbf5e2b0
Reviewed-on: https://gerrit.libreoffice.org/42698
Reviewed-by: Yousuf Philips 
Tested-by: Yousuf Philips 

diff --git a/sd/uiconfig/simpress/popupmenu/page.xml 
b/sd/uiconfig/simpress/popupmenu/page.xml
index 0da29484ddbb..dabb785811d1 100644
--- a/sd/uiconfig/simpress/popupmenu/page.xml
+++ b/sd/uiconfig/simpress/popupmenu/page.xml
@@ -12,6 +12,28 @@
   
   
   
+  
+
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+
+  
   
   
   
diff --git a/sd/uiconfig/simpress/popupmenu/pagepane.xml 
b/sd/uiconfig/simpress/popupmenu/pagepane.xml
index b12dba02ae48..46ad46146561 100644
--- a/sd/uiconfig/simpress/popupmenu/pagepane.xml
+++ b/sd/uiconfig/simpress/popupmenu/pagepane.xml
@@ -18,7 +18,28 @@
   
   
   
-  
+  
+
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+
+  
   
   
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

System crashes + slow GUI, on linux + intel graphics

[Xaver Gerster]

Hi,

I am experiencing critical graphics issues with LO on linux, namely
i) either very slow GUI responsiveness
ii) or frequent crashes of LO inducing crashes of the
complete user session

to avoid cross-postings I would very much appreciate if you would 
consider the corresponding extended description at


https://bugs.documentfoundation.org/show_bug.cgi?id=112610

Any help would be most welcome.

Xaver

.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/uiconfig

[Olivier Hallot]

 sw/uiconfig/swriter/ui/optcompatpage.ui |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ae0edc4740ea95cd456eb7157bd048615de9212e
Author: Olivier Hallot 
Date:   Thu Aug 24 19:08:51 2017 -0300

Improve wording for Writer compatibility option

Change-Id: I852304204c1a95022dbd8305a892812c159a4445
Reviewed-on: https://gerrit.libreoffice.org/41544
Tested-by: Jenkins 
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/sw/uiconfig/swriter/ui/optcompatpage.ui 
b/sw/uiconfig/swriter/ui/optcompatpage.ui
index 9a1847feaada..e37af6eb7f83 100644
--- a/sw/uiconfig/swriter/ui/optcompatpage.ui
+++ b/sw/uiconfig/swriter/ui/optcompatpage.ui
@@ -66,7 +66,7 @@
   Expand word space on lines with manual line 
breaks in justified paragraphs
   Protect form
   MS Word-compatible trailing blanks
-  Use LibreOffice 4.3 anchoring paint order (in 
current document)
+  Tolerate white lines of PDF page backgrounds for 
compatibility with old documents (in current document)
   
 
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: external/more_fonts extras/source postprocess/CustomTarget_fontconfig.mk postprocess/Module_postprocess.mk postprocess/Package_fontconfig.mk Repository.mk

[Stephan Bergmann]

 Repository.mk  |2 -
 external/more_fonts/Module_more_fonts.mk   |1 
 external/more_fonts/Package_conf.mk|   14 ---
 external/more_fonts/fc_local.snippet   |6 -
 extras/source/truetype/symbol/fc_local.snippet |6 +
 postprocess/CustomTarget_fontconfig.mk |   30 +
 postprocess/Module_postprocess.mk  |   11 +
 postprocess/Package_fontconfig.mk  |   18 +++
 8 files changed, 66 insertions(+), 22 deletions(-)

New commits:
commit e79f1261549d9c497a38ea1af8843a86883b02cd
Author: Stephan Bergmann 
Date:   Fri Sep 22 17:14:56 2017 +0200

Compensate for loss of Type 1 "Standard Symbols L" substitute for "Symbol"

At least for me on Linux since LO 5.3, 'soffice
sw/qa/extras/rtfexport/data/fdo72031.rtf' shows "Å" (rendered in "DejaVu 
Sans")
instead of "⊕" (rendered in "Standard Symbols L").  That's presumably 
because
47ea13ef8dc8ab9aeded6121845e3ebd1d28b292 "Kill the old Unix layout engines"
removed support for Type 1 fonts (see "Ignore Type 1 fonts" in
FontCfgWrapper::addFontSet, vcl/unx/generic/fontmanager/fontconfig.cxx), 
and my
(Fedora 25) /usr/share/fonts/default/Type1/s05l.pfb "Standard Symbols 
L" is
a Type 1 font.  So we fell back to fontconfig's generic (weak) suggestion of
"DejaVu Sans" as a substitute for "Symbol".

So extend our fc_local.conf to suggest our "OpenSymbol" as a substitute for
"Symbol".

As that fc_local.conf was originally brought along by --with-fonts, which is
enabled by default but can be disabled, compilation of fc_local.conf from 
the
various snippets is moved to postprocess.

macOS and Windows were never affected, as they both come with a "Symbol" 
font
installed in the system.  (And we don't install fc_local.conf on Windows at
all.)

Change-Id: I8d6d87f24974577fd66f5f3989f606237ebb3d75
Reviewed-on: https://gerrit.libreoffice.org/42670
Reviewed-by: Stephan Bergmann 
Tested-by: Stephan Bergmann 

diff --git a/Repository.mk b/Repository.mk
index 436e66ff6f50..268b4982018a 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -942,6 +942,7 @@ $(eval $(call gb_Helper_register_packages_for_install,ooo,\
 
 $(eval $(call gb_Helper_register_packages_for_install,ooo_fonts,\
extras_fonts \
+   $(if $(filter-out WNT,$(OS)),postprocess_fontconfig) \
$(call gb_Helper_optional,MORE_FONTS,\
fonts_caladea \
fonts_carlito \
@@ -955,7 +956,6 @@ $(eval $(call 
gb_Helper_register_packages_for_install,ooo_fonts,\
fonts_ptserif \
fonts_sourcecode \
fonts_sourcesans \
-   $(if $(filter-out WNT,$(OS)),more_fonts_conf) \
) \
 ))
 
diff --git a/external/more_fonts/Module_more_fonts.mk 
b/external/more_fonts/Module_more_fonts.mk
index eb2f3216c57a..6e5224752fe6 100644
--- a/external/more_fonts/Module_more_fonts.mk
+++ b/external/more_fonts/Module_more_fonts.mk
@@ -10,7 +10,6 @@
 $(eval $(call gb_Module_Module,more_fonts))
 
 $(eval $(call gb_Module_add_targets,more_fonts,\
-   $(if $(filter-out WNT,$(OS)),Package_conf) \
ExternalPackage_caladea \
ExternalPackage_carlito \
ExternalPackage_dejavu \
diff --git a/external/more_fonts/Package_conf.mk 
b/external/more_fonts/Package_conf.mk
deleted file mode 100644
index 2d259c2175c3..
--- a/external/more_fonts/Package_conf.mk
+++ /dev/null
@@ -1,14 +0,0 @@
-# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
-#
-# This file is part of the LibreOffice project.
-#
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-#
-
-$(eval $(call 
gb_Package_Package,more_fonts_conf,$(SRCDIR)/external/more_fonts/fonts))
-
-$(eval $(call 
gb_Package_add_file,more_fonts_conf,$(LIBO_SHARE_FOLDER)/fonts/truetype/fc_local.conf,fc_local.conf))
-
-# vim: set noet sw=4 ts=4:
diff --git a/external/more_fonts/fonts/fc_local.conf 
b/external/more_fonts/fc_local.snippet
similarity index 84%
rename from external/more_fonts/fonts/fc_local.conf
rename to external/more_fonts/fc_local.snippet
index 6af763c0b0f0..cb49929b0a4a 100644
--- a/external/more_fonts/fonts/fc_local.conf
+++ b/external/more_fonts/fc_local.snippet
@@ -1,7 +1,3 @@
-
-
-
-

 

@@ -31,5 +27,3 @@
  Caladea
  

-
-
diff --git a/extras/source/truetype/symbol/fc_local.snippet 
b/extras/source/truetype/symbol/fc_local.snippet
new file mode 100644
index ..5b29e1d58744
--- /dev/null
+++ b/extras/source/truetype/symbol/fc_local.snippet
@@ -0,0 +1,6 @@
+
+  Symbol
+  
+OpenSymbol
+  
+
diff --git a/postprocess/CustomTarget_fontconfig.mk 
b/postprocess/CustomTarget_fontconfig.mk
new file mode 100

[Libreoffice-commits] help.git: help3xsl/localized.xsl

[Olivier Hallot]

 help3xsl/localized.xsl |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 2ab31faddac65547ac961da7fc47f0c61dd694b3
Author: Olivier Hallot 
Date:   Sat Sep 23 05:48:07 2017 -0300

Add hungarian to helponline ui

Change-Id: Icc1abd566c32f6b873fd979cba2190a9ce959a69
Reviewed-on: https://gerrit.libreoffice.org/42685
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/help3xsl/localized.xsl b/help3xsl/localized.xsl
index 69ac4012e..99eaa4869 100644
--- a/help3xsl/localized.xsl
+++ b/help3xsl/localized.xsl
@@ -31,6 +31,7 @@ Stylesheet map language-dependent parameters and translation
 Contenu
 Contido
 Sadržaj
+Tartalom
 Efni
 Argomenti
 目次
@@ -69,6 +70,7 @@ Stylesheet map language-dependent parameters and translation
 Índex
 Índice
 Indeks
+Tárgymutató
 Atriðaskrá
 Indice
 索引
@@ -107,6 +109,7 @@ Stylesheet map language-dependent parameters and translation
 Recherche
 Buscar
 Pronađi
+Keresés
 Leita
 Cerca
 検索
@@ -145,6 +148,7 @@ Stylesheet map language-dependent parameters and translation
 Langue
 Idioma
 Jezik
+Nyelv
 Tungumál
 Lingua
 言語
@@ -175,6 +179,7 @@ Stylesheet map language-dependent parameters and translation
 var cx = 
'010161382024564278136:cdcn_oz4txg';
 var cx = 
'010161382024564278136:op1o8h6jnu8';
 var cx = 
'010161382024564278136:mimp7dbi-eq';
+var cx = 
'010161382024564278136:imtiawlmhnk';
 var cx = 
'010161382024564278136:xdxa9y906g0';
 var cx = 
'010161382024564278136:7wxg-zakzmu';
 var cx = 
'010161382024564278136:czaiuh5qxzu';
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 57357260250a9f5ae59ea346db03f94f76cce42b
Author: Olivier Hallot 
Date:   Sat Sep 23 05:48:07 2017 -0300

Updated core
Project: help  2ab31faddac65547ac961da7fc47f0c61dd694b3

Add hungarian to helponline ui

Change-Id: Icc1abd566c32f6b873fd979cba2190a9ce959a69
Reviewed-on: https://gerrit.libreoffice.org/42685
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/helpcontent2 b/helpcontent2
index c25389900adc..2ab31faddac6 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit c25389900adcc9915010b1867aa37e691ea05a62
+Subproject commit 2ab31faddac65547ac961da7fc47f0c61dd694b3
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits