[Libreoffice-bugs] [Bug 113490] Impossible to create new page style based on the current page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113490

george  changed:

   What|Removed |Added

Summary|Impossible to create new|Impossible to create new
   |style based on the current  |page style based on the
   |page|current page

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113490] New: Impossible to create new style based on the current page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113490

Bug ID: 113490
   Summary: Impossible to create new style based on the current
page
   Product: LibreOffice
   Version: 5.4.2.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gd...@yahoo.com

Description:
According to online libre office documentation here
(https://help.libreoffice.org/Writer/Creating_a_Page_Style_Based_on_the_Current_Page)
it is possible to create a new page style based on the current page. The
instructions are:

1.Open a new text document, choose View - Styles and Formatting, and then click
the Page Styles icon.
2.Click the New Style from Selection icon and select New Styles from Selection
from the submenu.
3.Type a name for the page in the Style name box, and then click OK.
4.Double-click the name in the list to apply the style to the current page.
5.Choose Insert - Header and Footer - Header, and choose the new page style
from the list.
6.Type the text that you want in the header. Position the cursor into the main
text area outside of the header.
7.Choose Insert - Manual Break.
8.In the Type area, select Page break and then select “Default” from the Style
box.
9.Repeat steps 2-6 to create a second custom page style with a different
header.

However no matter how many times I tried there is no "new style from selection
icon" and as a result each time I create a new page style I have to configure
it from scratch which is very very frustrating.

I think this is a major bug and should be fixed.


Steps to Reproduce:
1.Open writer
2.Go to view --> Styles and formatting (or just press F11)
3.Select Page Styles
4.Icon "create new style from selection" is nowhere to be found...

Actual Results:  
"Create new Style from selection" icon is missing.

Expected Results:
There should be a "create new style from selection" option, according to libre
writer documentation here -->
https://help.libreoffice.org/Writer/Creating_a_Page_Style_Based_on_the_Current_Page


Reproducible: Always


User Profile Reset: Yes



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: TextDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/62.0.3202.75 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 103317] New default set of templates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103317

--- Comment #11 from Yousuf Philips (jay)  ---
(In reply to Laurent BP from comment #8)
> Why removing LushGreen and Pencil template?

These have been restore with his patch and a batch of seven new templates are
being added (most modified by me)
https://gerrit.libreoffice.org/43973

Laurent if you are on telegram, it would be great to chat with you more about
these and more templates. - https://t.me/joinchat/B-szpERIwOCjY_97ehftHA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 74206] large autocorrect lists: typing in 'Replace' field is slower than 'With' field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=74206

--- Comment #8 from tommy27  ---
issue still present in LibO 6.0.0.0 alpha

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102283] [META] Slide/page pane bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102283

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||113489


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113489
[Bug 113489] Fill color of placeholder textbox doesnt appear in slide pane
preview
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113489] New: Fill color of placeholder textbox doesnt appear in slide pane preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113489

Bug ID: 113489
   Summary: Fill color of placeholder textbox doesnt appear in
slide pane preview
   Product: LibreOffice
   Version: 3.4.6 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: preBibisect, regression
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
Blocks: 102283

steps:
1. open https://wiki.documentfoundation.org/images/9/97/Classy_red.otp
2. Notice that preview of slide 1 in slide pane doesnt show red title
placeholder textbox color

regression as it did show in 3.3.

Version: 6.0.0.0.alpha1+
Build ID: 43d6b11a5c1dda0cc2c1e06c768eece25051a56c
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102283
[Bug 102283] [META] Slide/page pane bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - comphelper/source

[Caolán McNamara]

 comphelper/source/misc/docpasswordhelper.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit f95ec59f035ef1f6e9bd2a24e9d69e35edd6e089
Author: Caolán McNamara 
Date:   Fri Oct 27 17:00:41 2017 +0100

fix memory leak

Change-Id: I6683ab0d39dbbb5c0ba0958d72f0a1bbfab47164
Reviewed-on: https://gerrit.libreoffice.org/43955
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/comphelper/source/misc/docpasswordhelper.cxx 
b/comphelper/source/misc/docpasswordhelper.cxx
index 0ca3c01a55ab..042421ac29d0 100644
--- a/comphelper/source/misc/docpasswordhelper.cxx
+++ b/comphelper/source/misc/docpasswordhelper.cxx
@@ -337,6 +337,8 @@ Sequence< sal_Int8 > DocPasswordHelper::GetXLHashAsSequence(
 
 // Erase KeyData array and leave.
 rtl_secureZeroMemory (pKeyData, sizeof(pKeyData));
+
+rtl_digest_destroy(hDigest);
 }
 
 return aResultKey;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: solenv/gbuild

[Stephan Bergmann]

 solenv/gbuild/LinkTarget.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit df9edbcd2883cec2d0596133131cfbc220dee91f
Author: Stephan Bergmann 
Date:   Fri Oct 27 16:10:45 2017 +0200

Work around "xargs: environment is too large for exec" errors on Windows

...when e.g. doing 'make sal.clean'

Change-Id: I63c13dd010cf8d24f9548cf2fe089067381a4efe
Reviewed-on: https://gerrit.libreoffice.org/43948
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/solenv/gbuild/LinkTarget.mk b/solenv/gbuild/LinkTarget.mk
index d75b7fe1e355..6c7bfa09d1f1 100644
--- a/solenv/gbuild/LinkTarget.mk
+++ b/solenv/gbuild/LinkTarget.mk
@@ -538,7 +538,7 @@ $(WORKDIR)/Clean/LinkTarget/% :
$(call gb_LinkTarget_get_objects_list,$(LINKTARGET)) \
$(ILIBTARGET) \
$(AUXTARGETS)) && \
-   cat $${RESPONSEFILE} /dev/null | xargs -n 200 rm -fr && \
+   cat $${RESPONSEFILE} /dev/null | $(if $(filter WNT,$(OS)),env 
-i PATH="$$PATH") xargs -n 200 rm -fr && \
rm -f $${RESPONSEFILE}
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sfx2/sdi

[Yousuf Philips]

 sfx2/sdi/sfx.sdi |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 493d2870cfadb652ce4b39430bebd5a364c8f7f1
Author: Yousuf Philips 
Date:   Sat Oct 28 00:02:33 2017 +0400

tdf#113446 Make EditStyle appear in customization dialog

Change-Id: Ic9c13ec0b1a009a1fb3998517ca21471c9c2f23f
Reviewed-on: https://gerrit.libreoffice.org/43967
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/sfx2/sdi/sfx.sdi b/sfx2/sdi/sfx.sdi
index 03b536d3c4d6..323d7eece178 100644
--- a/sfx2/sdi/sfx.sdi
+++ b/sfx2/sdi/sfx.sdi
@@ -1062,9 +1062,9 @@ SfxVoidItem EditStyle SID_STYLE_EDIT
 RecordAbsolute = FALSE,
 RecordPerSet;
 
-AccelConfig = FALSE,
-MenuConfig = FALSE,
-ToolBoxConfig = FALSE,
+AccelConfig = TRUE,
+MenuConfig = TRUE,
+ToolBoxConfig = TRUE,
 GroupId = GID_TEMPLATE;
 ]
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - vcl/osx

[Xisco Fauli]

 vcl/osx/DataFlavorMapping.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 671182b8f59e8e390b79b7f3b35535b8c3ec1408
Author: Xisco Fauli 
Date:   Wed Oct 18 17:30:57 2017 +0200

tdf#109343 Fix paste as .RTF on Mac

Change-Id: Ida0433437301ea2803373e534df3d42f67d6aff8
Reviewed-on: https://gerrit.libreoffice.org/43513
Tested-by: Jenkins 
Reviewed-by: Bartosz Kosiorek 
(cherry picked from commit dd0bc7323014c528fefb516cacae0591f270862a)
Reviewed-on: https://gerrit.libreoffice.org/43857
Reviewed-by: Thorsten Behrens 

diff --git a/vcl/osx/DataFlavorMapping.cxx b/vcl/osx/DataFlavorMapping.cxx
index 6db7d4105985..012889abfb60 100644
--- a/vcl/osx/DataFlavorMapping.cxx
+++ b/vcl/osx/DataFlavorMapping.cxx
@@ -111,7 +111,7 @@ namespace
   static const FlavorMap flavorMap[] =
 {
   { NSStringPboardType, "text/plain;charset=utf-16", "Unicode Text 
(UTF-16)", true },
-  { NSRTFPboardType, "text/richtext", "Rich Text Format", false },
+  { NSRTFPboardType, "text/rtf", "Rich Text Format", false },
   { NSTIFFPboardType, "image/png", "Portable Network Graphics", false },
   { NSHTMLPboardType, "text/html", "Plain Html", false },
   { NSFilenamesPboardType, 
"application/x-openoffice-filelist;windows_formatname=\"FileList\"", 
"FileList", false },
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 113367] attribute transform in draw:frame has wrong namespace, is svg , has to be draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113367

--- Comment #4 from Commit Notification 
 ---
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7cebfbeabb24f908fb586ef5fa47f103042d769c

tdf#113367 Change namespace from svg to draw for attr transform

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: xmloff/source

[Regina Henschel]

 xmloff/source/text/txtimp.cxx   |2 +-
 xmloff/source/text/txtparae.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 7cebfbeabb24f908fb586ef5fa47f103042d769c
Author: Regina Henschel 
Date:   Thu Oct 26 14:41:38 2017 +0200

tdf#113367 Change namespace from svg to draw for attr transform

The new feature of rotating images in Writer first time triggers the
export of the attribute transform. So now it becomes visible, that
it has the wrong namespace, see ODF 19.228 part 1.

Change-Id: I00d5e6a12bd564e814679e8be862c7d08baae956
Reviewed-on: https://gerrit.libreoffice.org/43890
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/xmloff/source/text/txtimp.cxx b/xmloff/source/text/txtimp.cxx
index 54016575a620..87586098ec17 100644
--- a/xmloff/source/text/txtimp.cxx
+++ b/xmloff/source/text/txtimp.cxx
@@ -364,7 +364,7 @@ static const SvXMLTokenMapEntry aTextFrameAttrTokenMap[] =
 { XML_NAMESPACE_XLINK, XML_HREF, XML_TOK_TEXT_FRAME_HREF },
 { XML_NAMESPACE_DRAW, XML_NAME, XML_TOK_TEXT_FRAME_FILTER_NAME },
 { XML_NAMESPACE_DRAW, XML_ZINDEX, XML_TOK_TEXT_FRAME_Z_INDEX },
-{ XML_NAMESPACE_SVG, XML_TRANSFORM, XML_TOK_TEXT_FRAME_TRANSFORM },
+{ XML_NAMESPACE_DRAW, XML_TRANSFORM, XML_TOK_TEXT_FRAME_TRANSFORM },
 { XML_NAMESPACE_DRAW, XML_CLASS_ID, XML_TOK_TEXT_FRAME_CLASS_ID },
 { XML_NAMESPACE_DRAW,   XML_CODE,   XML_TOK_TEXT_FRAME_CODE },
 { XML_NAMESPACE_DRAW,   XML_OBJECT, XML_TOK_TEXT_FRAME_OBJECT },
diff --git a/xmloff/source/text/txtparae.cxx b/xmloff/source/text/txtparae.cxx
index 53548573be0a..65d072b240b8 100644
--- a/xmloff/source/text/txtparae.cxx
+++ b/xmloff/source/text/txtparae.cxx
@@ -3060,7 +3060,7 @@ void XMLTextParagraphExport::_exportTextGraphic(
 sRet.append( '(' );
 sRet.append( (sal_Int32)nVal );
 sRet.append( ')' );
-GetExport().AddAttribute( XML_NAMESPACE_SVG, XML_TRANSFORM,
+GetExport().AddAttribute( XML_NAMESPACE_DRAW, XML_TRANSFORM,
   sRet.makeStringAndClear() );
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 109343] Cannot paste formatted text (.rtf) from clipboard on Mac. It comes always unformatted. Still broken in 5.3.6 and 5.4.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109343

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.0.0|target:6.0.0 target:5.4.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109343] Cannot paste formatted text (.rtf) from clipboard on Mac. It comes always unformatted. Still broken in 5.3.6 and 5.4.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109343

--- Comment #23 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-5-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=671182b8f59e8e390b79b7f3b35535b8c3ec1408=libreoffice-5-4

tdf#109343 Fix paste as .RTF on Mac

It will be available in 5.4.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106084] certain EMF images from OOXML document are not rendered correctly LibreOffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106084

--- Comment #21 from Commit Notification 
 ---
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9270e6ad00b75eb35cae71998642a7c306eb4d03

tdf#106084 EMF+ Add support for RotateWorldTransform record

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: drawinglayer/source

[Bartosz Kosiorek]

 drawinglayer/source/tools/emfphelperdata.cxx |   18 ++
 drawinglayer/source/tools/emfphelperdata.hxx |2 +-
 2 files changed, 19 insertions(+), 1 deletion(-)

New commits:
commit 9270e6ad00b75eb35cae71998642a7c306eb4d03
Author: Bartosz Kosiorek 
Date:   Thu Oct 26 01:28:51 2017 +0200

tdf#106084 EMF+ Add support for RotateWorldTransform record

Change-Id: If5ce156b7d60d30be8451902beb8330b7177b26e
Reviewed-on: https://gerrit.libreoffice.org/43858
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/drawinglayer/source/tools/emfphelperdata.cxx 
b/drawinglayer/source/tools/emfphelperdata.cxx
index 79ce930a5358..ad67d6994d06 100644
--- a/drawinglayer/source/tools/emfphelperdata.cxx
+++ b/drawinglayer/source/tools/emfphelperdata.cxx
@@ -1440,6 +1440,24 @@ namespace emfplushelper
 "EMF+\t dx: " << maWorldTransform.get(2, 0) << ", 
dy: " << maWorldTransform.get(2, 1));
 break;
 }
+case EmfPlusRecordTypeRotateWorldTransform:
+{
+// Angle of rotation in degrees
+float eAngle;
+rMS.ReadFloat(eAngle);
+
+SAL_INFO("cppcanvas.emf", "EMF+ 
EmfPlusRecordTypeRotateWorldTransform Angle: " << eAngle);
+
+// Skipping flags & 0x2000
+// For rotation transformation there is no difference 
between post and pre multiply
+maWorldTransform.rotate(eAngle * F_PI180);
+
+mappingChanged();
+
+SAL_INFO("cppcanvas.emf",
+"EMF+\t " << maWorldTransform);
+break;
+}
 case EmfPlusRecordTypeSetClipRect:
 {
 int combineMode = (flags >> 8) & 0xf;
diff --git a/drawinglayer/source/tools/emfphelperdata.hxx 
b/drawinglayer/source/tools/emfphelperdata.hxx
index 99ef9964b945..082ad1ae4c69 100644
--- a/drawinglayer/source/tools/emfphelperdata.hxx
+++ b/drawinglayer/source/tools/emfphelperdata.hxx
@@ -80,7 +80,7 @@ namespace emfplushelper
 #define EmfPlusRecordTypeMultiplyWorldTransform 0x402C
 #define EmfPlusRecordTypeTranslateWorldTransform 0x402D
 #define EmfPlusRecordTypeScaleWorldTransform 0x402E
-//TODO EmfPlusRecordTypeRotateWorldTransform 0x402F
+#define EmfPlusRecordTypeRotateWorldTransform 0x402F
 #define EmfPlusRecordTypeSetPageTransform 0x4030
 //TODO EmfPlusRecordTypeResetClip 0x4031
 #define EmfPlusRecordTypeSetClipRect 0x4032
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106084] certain EMF images from OOXML document are not rendered correctly LibreOffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106084

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.4.0 target:5.3.4   |target:5.4.0 target:5.3.4
   ||target:6.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113367] attribute transform in draw:frame has wrong namespace, is svg , has to be draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113367

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113440] [META] Font size combobox and related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113440

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||110002


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=110002
[Bug 110002] Sidebar shows 2 as font height for some specific Impress tables
cells
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: drawinglayer/source

[Armin Le Grand]

 drawinglayer/source/primitive2d/metafileprimitive2d.cxx |   60 ++--
 1 file changed, 25 insertions(+), 35 deletions(-)

New commits:
commit bdb9cc1702d4e125db8c379f3b535bbd9f845b95
Author: Armin Le Grand 
Date:   Tue Oct 24 11:36:49 2017 +0200

tdf#113197 Add MaskPrimitive (clip) to EMF/WMF if needed

When the content of an imported EMF/WMF overlaps the defined
size in PrefMapMode/PrefSize, add clipping to hide it. This
was done in imports before EMF+ changes and is done in SVG, too.
If needed, orig contained size and content still accessible
using MetafilePrimitive2D::accessMetafile

Change-Id: Id86ff3c0a9820637e3601c0c4f489a2d67d190d0
Reviewed-on: https://gerrit.libreoffice.org/43746
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/drawinglayer/source/primitive2d/metafileprimitive2d.cxx 
b/drawinglayer/source/primitive2d/metafileprimitive2d.cxx
index bb3d243b4beb..5ace807a264d 100644
--- a/drawinglayer/source/primitive2d/metafileprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/metafileprimitive2d.cxx
@@ -20,43 +20,10 @@
 #include 
 #include 
 
-//#include 
 #include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
 #include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
-//#include 
+#include 
+#include 
 
 using namespace com::sun::star;
 
@@ -74,6 +41,29 @@ namespace drawinglayer
 {
 // get target size
 const ::tools::Rectangle 
aMtfTarget(getMetaFile().GetPrefMapMode().GetOrigin(), 
getMetaFile().GetPrefSize());
+const basegfx::B2DRange aMtfRange(aMtfTarget.Left(), 
aMtfTarget.Top(), aMtfTarget.Right(), aMtfTarget.Bottom());
+
+// tdf#113197 get content range and check if we have an 
overlap with
+// defined target range (aMtfRange)
+if (!aMtfRange.isEmpty())
+{
+const basegfx::B2DRange 
aContentRange(xRetval.getB2DRange(rViewInformation));
+
+// also test equal since isInside gives also true for equal
+if (!aMtfRange.equal(aContentRange) && 
!aMtfRange.isInside(aContentRange))
+{
+// contentRange is partly larger than aMtfRange (stuff 
sticks
+// outside), clipping is needed
+const drawinglayer::primitive2d::Primitive2DReference 
xMask(
+new drawinglayer::primitive2d::MaskPrimitive2D(
+basegfx::B2DPolyPolygon(
+basegfx::utils::createPolygonFromRect(
+aMtfRange)),
+xRetval));
+
+xRetval = 
drawinglayer::primitive2d::Primitive2DContainer{ xMask };
+}
+}
 
 // create transformation
 basegfx::B2DHomMatrix aAdaptedTransform;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 95694] One cannot print to A4 size paper in Impress.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95694

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95694] One cannot print to A4 size paper in Impress.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95694

--- Comment #8 from Commit Notification 
 ---
Katarina Behrens committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=51eb767eaf514ee8106401e364e75533fd6fcb51

Related tdf#95694: Enable papersize & orientation listboxes

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svtools/source

[Katarina Behrens]

 svtools/source/dialogs/prnsetup.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 51eb767eaf514ee8106401e364e75533fd6fcb51
Author: Katarina Behrens 
Date:   Wed Oct 25 12:46:33 2017 +0200

Related tdf#95694: Enable papersize & orientation listboxes

when called from File > Printer Properties > Properties. Anything
else doesn't make sense, user opens this dialog in order to be able
to edit the settings

Change-Id: I9559829551e6d6144da972757ab98afa5696bbfa
Reviewed-on: https://gerrit.libreoffice.org/43823
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/svtools/source/dialogs/prnsetup.cxx 
b/svtools/source/dialogs/prnsetup.cxx
index d7a8b06a7900..d3a46048b2dc 100644
--- a/svtools/source/dialogs/prnsetup.cxx
+++ b/svtools/source/dialogs/prnsetup.cxx
@@ -293,7 +293,10 @@ IMPL_LINK_NOARG(PrinterSetupDialog, ImplPropertiesHdl, 
Button*, void)
 {
 if ( !mpTempPrinter )
 mpTempPrinter = VclPtr::Create( mpPrinter->GetJobSetup() );
-mpTempPrinter->Setup( this );
+// 2nd argument: whether paper size and orientation from printer settings
+// override document settings, iow whether matching listboxes are editable
+// (this is a printer setup dialog, so they definitely should be editable)
+mpTempPrinter->Setup( this, true );
 }
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Serge Krot]

 sw/source/filter/ww8/wrtw8nds.cxx |   12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)

New commits:
commit 9a9cfb1d80cea14abddea3d2e18fedb1549c9293
Author: Serge Krot 
Date:   Thu Oct 26 17:17:03 2017 +0200

related tdf#38778 Speed-up: Do not traverse the whole array

It is known that text attributes are sorted inside SwpHints.
No need to check all entries if special position is provided.

Change-Id: Iac92cd40cd6d094d158f3b50fd768f47029ccdce
Reviewed-on: https://gerrit.libreoffice.org/43911
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/sw/source/filter/ww8/wrtw8nds.cxx 
b/sw/source/filter/ww8/wrtw8nds.cxx
index a43db5d01869..de0820b8204a 100644
--- a/sw/source/filter/ww8/wrtw8nds.cxx
+++ b/sw/source/filter/ww8/wrtw8nds.cxx
@@ -663,10 +663,16 @@ bool SwWW8AttrIter::IsTextAttr( sal_Int32 nSwPos )
 for (size_t i = 0; i < pTextAttrs->Count(); ++i)
 {
 const SwTextAttr* pHt = pTextAttrs->Get(i);
-if ( ( pHt->HasDummyChar() || pHt->HasContent() )
- && (pHt->GetStart() == nSwPos) )
+if (nSwPos == pHt->GetStart())
 {
-return true;
+if (pHt->HasDummyChar() || pHt->HasContent() )
+{
+return true;
+}
+}
+else if (nSwPos < pHt->GetStart())
+{
+break; // sorted by start
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Minutes of ESC call 2017-10-26

[Thorsten Behrens]

Miklos Vajna wrote:
> * clang-format-ness (Miklos)
> + Came up with a prototype at https://gerrit.libreoffice.org/#/c/43736/ 
>  + Tamas Z: autofix up style → added a config option
>  + Thorsten: server-side idea
>+ not clear if it’s nice-to-have or a blocker if not addressed (Miklos)
>  + Stephan: maintenance concern with given style config
>+ not a blocker, but having one more week to research this would be 
> nice (Stephan)
> 
> => discuss this once again next week
> 
Thanks for postponing a bit - my concerns are not a blocker of course,
just a strong desire to keep whatever a dev needs to hack (and commit!)
on LibreOffice code as lightweight as possible.

Having something on gerrit and/or jenkins pushes a potentially complex
& growing moving piece to a centrally-administered place...

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 113251] libreoffice crashes upon startup after quick forced terminate

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113251

--- Comment #2 from tree.w...@yahoo.com ---
(In reply to Xisco Faulí from comment #1)
> So, you just reproduced it once, or you can reproduce it systematically?
> 
> I can't reproduce it in
> 
> Version: 5.4.2.2
> Build ID: 1:5.4.2~rc2-0ubuntu0.17.04.1~lo2
> CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
> Locale: es-ES (ca_ES.UTF-8); Calc: group

I reproduced it multiple times by random, each time it was after i exited
hibernation. I cannot pinpoint where exactly it failed after. To clarify, in
the Arch linux repos, the extra/libreoffice-fresh version was the one that
crashed. I have since uninstalled that one and am using the
extra/libreoffice-still branch, and that hasn't crashed yet so far. So i am
guessing some new feauture in the fresh branch isn't working with my setup.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86349] [META] Context menu bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86349

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||113488


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113488
[Bug 113488] Better support for Assistive Technology tools by exposing
descriptive tooltips text with keyboard navigation
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113488] Better support for Assistive Technology tools by exposing descriptive tooltips text with keyboard navigation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113488

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||accessibility
 CC||momonas...@gmail.com,
   ||philip...@hotmail.com,
   ||vstuart.fo...@utsa.edu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||8458
 Blocks||113342, 85811, 86349


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=85811
[Bug 85811] [META] Main menu bar bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=86349
[Bug 86349] [META] Context menu bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113342
[Bug 113342] [META] Toolbar label bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113342] [META] Toolbar label bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113342

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||113488


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113488
[Bug 113488] Better support for Assistive Technology tools by exposing
descriptive tooltips text with keyboard navigation
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108458] Label changes for Toolbar use degrade function listing in the Customize dialog--have duplicate entries on the list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108458

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||3488

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85811] [META] Main menu bar bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85811

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||113488


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113488
[Bug 113488] Better support for Assistive Technology tools by exposing
descriptive tooltips text with keyboard navigation
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113488] New: Better support for Assistive Technology tools by exposing descriptive tooltips text with keyboard navigation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113488

Bug ID: 113488
   Summary: Better support for Assistive Technology tools by
exposing descriptive tooltips text with keyboard
navigation
   Product: LibreOffice
   Version: 4.1.0.4 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vstuart.fo...@utsa.edu

By default mouseover events expose a more descriptive tooltip, or an extended
tooltip--when offline local help is installed and has an article pointing at
the button.

And with Assistive Technology (AT) support enabled, on mouseover of a button
control the descriptive tooltip is sounded by AT instead of the button label.

When keyboard navigation is used: e.g. F10, F6, TAB/ShiftTab, or cursor
UP/DOWN/LEFT/RIGHT--the AT sounds *only* the abbreviated button label.  Same
for menu label, and context menu label which also sound just the short label.

If possible, for better accessibility support, keyboard navigation should offer
the same audible/visual rendering of the more descriptive tooltip(s) provided
with mouseover event of buttons.

A rework of label structure for menus, context menus and toolbar button labels
is being looked at for bug 108458. Perhaps in  conjunction with that, some
structural change to facilitate use of tooltip/extended tooltips with keyboard
navigation might be implemented.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] dictionaries.git: en/changelog.txt en/description.xml en/en_AU.dic en/en_CA.dic en/en_GB.aff en/en_GB.dic en/en_US.dic en/README_en_AU.txt en/README_en_CA.txt en/README_en_GB.txt

[Marco A . G . Pinto]

 en/README_en_AU.txt |6 
 en/README_en_CA.txt |6 
 en/README_en_GB.txt |1 
 en/README_en_US.txt |6 
 en/changelog.txt|  189 ++--
 en/description.xml  |2 
 en/en_AU.dic|  122 ++
 en/en_CA.dic|  122 ++
 en/en_GB.aff|9 
 en/en_GB.dic| 2316 +++-
 en/en_US.dic|  123 ++
 11 files changed, 2546 insertions(+), 356 deletions(-)

New commits:
commit 6feecdc45bb14d46b4273f2cf6c0e3491cbee276
Author: Marco A.G.Pinto 
Date:   Thu Oct 26 11:55:13 2017 +0100

Updated the English dictionaries: GB + US + CA + AU

Change-Id: If18f25780393258158ebf85cd68dbfa1075c4ab3
Reviewed-on: https://gerrit.libreoffice.org/43886
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/en/README_en_AU.txt b/en/README_en_AU.txt
index edb770a..cf345f3 100644
--- a/en/README_en_AU.txt
+++ b/en/README_en_AU.txt
@@ -1,6 +1,6 @@
 en_AU Hunspell Dictionary
-Version 2017.01.22
-Sun Jan 22 17:22:40 2017 -0500 [0c64f5c]
+Version 2017.08.24
+Thu Aug 24 14:36:19 2017 -0400 [2614b88]
 http://wordlist.sourceforge.net
 
 README file for English Hunspell dictionaries derived from SCOWL.
@@ -343,5 +343,5 @@ and Australian word list.  It is under the following 
copyright:
   OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   SUCH DAMAGE.
 
-Build Date: Sun Jan 22 17:42:52 EST 2017
+Build Date: Thu Aug 24 14:39:08 EDT 2017
 Wordlist Command: mk-list --accents=strip en_AU 60
diff --git a/en/README_en_CA.txt b/en/README_en_CA.txt
index d89861d..e8aaa5d 100644
--- a/en/README_en_CA.txt
+++ b/en/README_en_CA.txt
@@ -1,6 +1,6 @@
 en_CA Hunspell Dictionary
-Version 2017.01.22
-Sun Jan 22 17:22:40 2017 -0500 [0c64f5c]
+Version 2017.08.24
+Thu Aug 24 14:36:19 2017 -0400 [2614b88]
 http://wordlist.sourceforge.net
 
 README file for English Hunspell dictionaries derived from SCOWL.
@@ -343,5 +343,5 @@ and Australian word list.  It is under the following 
copyright:
   OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   SUCH DAMAGE.
 
-Build Date: Sun Jan 22 17:42:44 EST 2017
+Build Date: Thu Aug 24 14:39:03 EDT 2017
 Wordlist Command: mk-list --accents=strip en_CA 60
diff --git a/en/README_en_GB.txt b/en/README_en_GB.txt
index d60d8cd..7dbabe1 100644
--- a/en/README_en_GB.txt
+++ b/en/README_en_GB.txt
@@ -64,6 +64,7 @@ OOo Issue 63541 - remove *dessicated
  2016-06-21 - COMPOUNDING added to this clean version of the GB .AFF (Áron 
Budea)
  2016-08-01 - GB changelog is no longer included in the README file
  2016-09-11 - .AFF + .DIC now use Linux line endings
+ 2017-10-08 - Mozilla: used * to work with all 
future versions
  
 ---
 
diff --git a/en/README_en_US.txt b/en/README_en_US.txt
index 92122f0..df66b32 100644
--- a/en/README_en_US.txt
+++ b/en/README_en_US.txt
@@ -1,6 +1,6 @@
 en_US Hunspell Dictionary
-Version 2017.01.22
-Sun Jan 22 17:22:40 2017 -0500 [0c64f5c]
+Version 2017.08.24
+Thu Aug 24 14:36:19 2017 -0400 [2614b88]
 http://wordlist.sourceforge.net
 
 README file for English Hunspell dictionaries derived from SCOWL.
@@ -343,5 +343,5 @@ and Australian word list.  It is under the following 
copyright:
   OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
   SUCH DAMAGE.
 
-Build Date: Sun Jan 22 17:42:42 EST 2017
+Build Date: Thu Aug 24 14:39:01 EDT 2017
 Wordlist Command: mk-list --accents=strip en_US 60
diff --git a/en/changelog.txt b/en/changelog.txt
index 2fdc332..a51c3d1 100644
--- a/en/changelog.txt
+++ b/en/changelog.txt
@@ -1,3 +1,30 @@
+MAGP 2017-11-01
+
+Updated the Dictionaries:
+- British (Marco A.G.Pinto)*
+  * British has 467 new words (2017-10-01) + 824 new words (2017-11-01).
+
+
+
+MAGP 2017-09-01
+
+Updated the Dictionaries:
+- Australian (Kevin Atkinson)
+- American (Kevin Atkinson)
+- Canadian (Kevin Atkinson)
+- British (Marco A.G.Pinto)*
+  * British has 473 new words (2017-08-01) + 297 new words (2017-09-01).
+
+
+
+MAGP 2017-07-01
+
+Updated the Dictionaries:
+- British (Marco A.G.Pinto)*
+  * British has 480 new words (2017-06-01) + 433 new words (2017-07-01).
+
+
+
 MAGP 2017-05-01
 
 Updated the Dictionaries:
@@ -297,85 +324,85 @@ DNW 25/9/2008
 
 Version packaged as English Australian Dictionary Extension version 1 for 
OpenOffice version 3.
 
--- Notes for 2.1.1 --
-
-- Made some modifications as this dictionary is specifically aimed at Mozilla 
products and online users.
-
-My modifications:
-
-blog/RDGMS
-Bugzilla/M
-caffeinate/D
-Camino/M
-ChatZilla/M
-eBay/M
-Firefox/M
-Flock/M
--gauge/DaGS
-gauge/aBDGMS
-Google/M
-google/SGD
-HTML/M
-https
-inline/D
--install/7NRn
-install/7NRnSUGMB
--Internet/M
-internet/M
-JavaScript/M
-Mozilla/M
-phish/RG
--plug-in
-plug-in/SM
-plugin/SM
-podcast/MSRG
-PowerPoint/M
-screenshot/S
-SeaMonkey/M
-Songbird/M
--spam/DG
-spam/DGM
--spammer
-spammer/MRS
-subdomain/SM
-Sunbird/M

[Libreoffice-commits] core.git: dictionaries

[Marco A . G . Pinto]

 dictionaries |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 81d50fd137fdf712a0f37988217c43278cf24c26
Author: Marco A.G.Pinto 
Date:   Thu Oct 26 11:55:13 2017 +0100

Updated core
Project: dictionaries  6feecdc45bb14d46b4273f2cf6c0e3491cbee276

Updated the English dictionaries: GB + US + CA + AU

Change-Id: If18f25780393258158ebf85cd68dbfa1075c4ab3
Reviewed-on: https://gerrit.libreoffice.org/43886
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/dictionaries b/dictionaries
index a79cdcb292c8..6feecdc45bb1 16
--- a/dictionaries
+++ b/dictionaries
@@ -1 +1 @@
-Subproject commit a79cdcb292c8095049f2834a1f0c5cbffe9097fe
+Subproject commit 6feecdc45bb14d46b4273f2cf6c0e3491cbee276
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 113408] FILEOPEN: RTF - Indentation of image not retained

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113408

Miklos Vajna  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113483] FILESAVE DOCX Cross reference corrupted if the target is a non-ASCII bookmark

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113483

Gabor Kelemen  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113483] FILESAVE DOCX Cross reference corrupted if the target is a non-ASCII bookmark

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113483

--- Comment #5 from Gabor Kelemen  ---
Created attachment 137331
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137331=edit
Example file saved as docx then resaved again

In 6.0 alpha it is not broken the same way. 
Now the bookmark name changes as well: while it becomes an unreadable
"Els%C5%91" it is consistent with the reference name, so they work.
After one more resave to docx the names become: "Els%25C5%2591" - even harder
to read, but still consistent.

Version: 6.0.0.0.alpha1+
Build ID: 93947341acb91c7ad508d1de72f5705f730d8e93
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: en-US (hu_HU.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113483] FILESAVE DOCX Cross reference corrupted if the target is a non-ASCII bookmark

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113483

--- Comment #4 from Gabor Kelemen  ---
Created attachment 137330
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137330=edit
Example file saved as docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113483] FILESAVE DOCX Cross reference corrupted if the target is a non-ASCII bookmark

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113483

--- Comment #3 from Gabor Kelemen  ---
Created attachment 137329
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137329=edit
Example file in odt

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113487] LibreOffice file chooser dialog does not remember last used size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113487

Mike Kaganski  changed:

   What|Removed |Added

   Keywords||regression
 Status|UNCONFIRMED |NEW
Version|5.3.5.2 release |4.4.5.2 release
 Ever confirmed|0   |1

--- Comment #1 from Mike Kaganski  ---
Well, AFAICS the dialog on your screenshots is not a system file open dialog,
but LibreOffice own dialog (activated in Options-LibreOffice-General). And I
can reproduce the behavior with LibreOffice file dialog size being reset using:

Version: 5.4.2.2 (x64)
Build ID: 22b09f6418e8c2d508a9eaf86b2399209b0990f4
CPU threads: 4; OS: Windows 6.19; UI render: default; 
Locale: ru-RU (ru_RU); Calc: CL

(but the position is saved, so that standard-sized dialog appears with top left
corner at the place where that corner of resized dialog was). And also I see
the same behaviour with:

Version: 4.4.5.2
Build ID: a22f674fd25a3b6f45bdebf25400ed2adff0ff99
Locale: ru_RU

but not with:

Version: 4.3.0.4
Build ID: 62ad5818884a2fc2e5780dd45466868d41009ec0

(so it's a regression, but not new; and also has nothing to do with gtk,
because reproducible on Windows). Possibly you had used OS/WM dialogs
previously, and so didn't experience the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103428] [META] Properties deck/tab of the sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103428
Bug 103428 depends on bug 110002, which changed state.

Bug 110002 Summary: Sidebar shows 2 as font height for some specific Impress 
tables cells
https://bugs.documentfoundation.org/show_bug.cgi?id=110002

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sd/source

[Tamás Zolnai]

 sd/source/ui/func/futext.cxx |   20 +---
 1 file changed, 17 insertions(+), 3 deletions(-)

New commits:
commit e142027a26634f51b0fc0903076f980d4a37496a
Author: Tamás Zolnai 
Date:   Fri Oct 27 18:48:51 2017 +0200

tdf#110002: Sidebar shows 2 as font height for some specific...

... Impress tables cells

While clicking inside a table we can avoid to unmark and
remark the corresponding table. This unneccessary
unmark\remark operations trigger a lot of useless updating
stuff.
For example it regenerate the whole sidebar while we still in
the table so the sidebar's context did not actually change.

Change-Id: I4c56b87b032e3cced3f09801147784dd2baaf9ef
Reviewed-on: https://gerrit.libreoffice.org/43961
Tested-by: Jenkins 
Reviewed-by: Tamás Zolnai 

diff --git a/sd/source/ui/func/futext.cxx b/sd/source/ui/func/futext.cxx
index 03baf601f141..19f18efa9906 100644
--- a/sd/source/ui/func/futext.cxx
+++ b/sd/source/ui/func/futext.cxx
@@ -299,13 +299,26 @@ bool FuText::MouseButtonDown(const MouseEvent& rMEvt)
 }
 else
 {
+// Don't remark table when clicking in it, mark change 
triggers a lot of updating
+bool bMarkChanges = true;
+rtl::Reference< sdr::SelectionController > 
xSelectionController(mpView->getSelectionController());
+if (eHit == SdrHitKind::TextEditObj && 
xSelectionController.is())
+{
+const SdrMarkList& rMarkList = 
mpView->GetMarkedObjectList();
+if (rMarkList.GetMarkCount() == 1 && 
rMarkList.GetMark(0)->GetMarkedSdrObj() == aVEvt.pRootObj)
+bMarkChanges = false;
+}
+
 if (eHit != SdrHitKind::Handle)
 {
 // deselect selection
 if (!rMEvt.IsShift() && eHit == SdrHitKind::TextEditObj)
 {
-mpView->UnmarkAll();
-mpView->SetDragMode(SdrDragMode::Move);
+if(bMarkChanges)
+{
+mpView->UnmarkAll();
+mpView->SetDragMode(SdrDragMode::Move);
+}
 }
 }
 
@@ -321,7 +334,8 @@ bool FuText::MouseButtonDown(const MouseEvent& rMEvt)
 {
 /* hit text of unmarked object:
select object and set to EditMode */
-mpView->MarkObj(aVEvt.pRootObj, pPV);
+if (bMarkChanges)
+mpView->MarkObj(aVEvt.pRootObj, pPV);
 
 if (aVEvt.pObj && dynamic_cast< const SdrTextObj *>( 
aVEvt.pObj ) !=  nullptr)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[internal API] new LocaleDataWrapper::stringToDouble()

[Eike Rathke]

Hi,

https://cgit.freedesktop.org/libreoffice/core/commit/?id=7616e1c18869cda8a924e26337e3f1c83cbb7efe

adds two new LocaleDataWrapper::stringToDouble() functions (one taking
a const OUString& and the other const sal_Unicode* for start and end).
For a detailed description see include/unotools/localedatawrapper.hxx

These should be used whenever a string with locale dependent decimal and
group separators is to be parsed as a floating-point number into
a double, instead of obtaining separators from a LocaleDataWrapper
instance and calling rtl::math::stringToDouble().

Background is that due to
https://bugs.documentfoundation.org/show_bug.cgi?id=81671
now an alternative input decimal separator can be defined and these
functions take care of that.

I already changed existing places that called
rtl::math::stringToDouble() locale dependent, for example
https://cgit.freedesktop.org/libreoffice/core/commit/?id=7cf453c78ce67f17661bfc74d1df6073cfc9d2ad

SvNumberFormatter::IsNumberFormat() is also adapted, so places using
that need no change, same for cclass_Unicode::parseText() and thus
XCharacterClassification::parsePredefinedToken() and parseAnyToken() and
their class CharClass wrappers.

Also adapted are implementations in BASIC that use ImpGetIntntlSep().

Code that implements (why?) some own parsing likely has to be adjusted to
accept the alternative as well

Another thing I encountered was
connectivity/source/commontools/predicateinput.cxx that uses separators
obtained by getSeparatorChars(). I wasn't sure if and what change it
would need and the implications a change there would have.
Anyway, the OSQLParseNode::parseNodeToPredicateStr() used to translate
it back taking a casted (yuck) sal_Char separator looks crap and doesn't
work correctly with Arabic locales (and maybe others).

Happy Input.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Care about Free Software, support the FSFE https://fsfe.org/support/?erack


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 113447] Crash in: RTSPaperPage::update()

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113447

Jean-Baptiste Faure  changed:

   What|Removed |Added

Version|unspecified |6.0.0.0.alpha0+

--- Comment #6 from Jean-Baptiste Faure  ---
set version from crash report.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 103317] New default set of templates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103317

--- Comment #10 from Laurent BP  ---
(In reply to Heiko Tietze from comment #9)

> Unlike for the other two that I recreated because of the localization, I
> didn't touch Vintage, except image size and font name. Don't see an issue
> with the language there, what exactly would you change?

Oups,my fault. I opened it in English UI. If I open it in French UI, it is
correctly in French. Sorry for the noise.
I would suggest to change only preview image.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 113487] New: LibreOffice file chooser dialog does not remember last used size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113487

Bug ID: 113487
   Summary: LibreOffice file chooser dialog does not remember last
used size
   Product: LibreOffice
   Version: 5.3.5.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: drankina...@suddenlinkmail.com

Version: 5.3.5.2
Build ID: 30m0(Build:2)
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; VCL: x11; Layout
Engine: new; 
Locale: en-US (en_US.UTF-8); Calc: group
Leap 42.2 x86_64

Previously File with OpenSuSE, they requested it move upstream:
https://bugzilla.suse.com/show_bug.cgi?id=1065398

This isn't a showstopper, but it is annoying as all get-out.

The file chooser dialog for libreoffice does not remember its last used size.
Every time you open a file, you have to resize the dialog to be able to see
your directory names and you have to resize the total width to be able to see
your file information.

I have used LO for years and it always remembered the last used size of the
file dialogs. Now after the switch to gtk+3, that does not work. I end up
having to resize that thing every time I use writer or calc.

Before, that information was properly saved in
~/.config/gtk-2.0/gtkfilechooser.ini. There is no similar file in
~/.config/gtk-3.0 and nothing related to the file chooser. Is there another
file that should capture the chooser width and height?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: external/libwpd

[David Tardon]

 external/libwpd/ExternalProject_libwpd.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 648d6493994869d9ad9a41755b3bf5fd5162e1e1
Author: David Tardon 
Date:   Fri Oct 27 22:06:45 2017 +0200

there is no C code in libwpd

Change-Id: I2997c09aaafb9f64e654f8b3b78e37adfa3de733

diff --git a/external/libwpd/ExternalProject_libwpd.mk 
b/external/libwpd/ExternalProject_libwpd.mk
index d7eea6dc4355..d897342e6b61 100644
--- a/external/libwpd/ExternalProject_libwpd.mk
+++ b/external/libwpd/ExternalProject_libwpd.mk
@@ -35,7 +35,7 @@ $(call gb_ExternalProject_get_state_target,libwpd,build) :
$(if $(filter MACOSX,$(OS)), \

--prefix=/@.__OOO) \
$(if 
$(verbose),--disable-silent-rules,--enable-silent-rules) \
-   $(if $(filter 
TRUE,$(DISABLE_DYNLOADING)),CFLAGS="$(CFLAGS) $(gb_VISIBILITY_FLAGS) $(if 
$(ENABLE_OPTIMIZED),$(gb_COMPILEROPTFLAGS),$(gb_COMPILERNOOPTFLAGS))" 
CXXFLAGS="$(CXXFLAGS) $(gb_VISIBILITY_FLAGS) $(gb_VISIBILITY_FLAGS_CXX) $(if 
$(ENABLE_OPTIMIZED),$(gb_COMPILEROPTFLAGS),$(gb_COMPILERNOOPTFLAGS))") \
+   $(if $(filter 
TRUE,$(DISABLE_DYNLOADING)),CXXFLAGS="$(CXXFLAGS) $(gb_VISIBILITY_FLAGS) 
$(gb_VISIBILITY_FLAGS_CXX) $(if 
$(ENABLE_OPTIMIZED),$(gb_COMPILEROPTFLAGS),$(gb_COMPILERNOOPTFLAGS))") \
CPPFLAGS="$(CPPFLAGS) $(BOOST_CPPFLAGS)" \
$(if $(filter LINUX,$(OS)),$(if $(SYSTEM_REVENGE),, \
'LDFLAGS=-Wl$(COMMA)-z$(COMMA)origin \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 103238] [META] Customize dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103238
Bug 103238 depends on bug 113446, which changed state.

Bug 113446 Summary: "Edit Style" menu command missing from customize dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=113446

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107326] [META] Writer style bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107326
Bug 107326 depends on bug 113446, which changed state.

Bug 113446 Summary: "Edit Style" menu command missing from customize dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=113446

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113446] "Edit Style" menu command missing from customize dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113446

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |philip...@hotmail.com
   |desktop.org |

--- Comment #4 from Yousuf Philips (jay)  ---
5.4 patch - https://gerrit.libreoffice.org/43967

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113446] "Edit Style" menu command missing from customize dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113446

--- Comment #3 from Commit Notification 
 ---
Yousuf Philips committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=32ebd3d9351636c5c62c3939662ce3e057c714e7

tdf#113446 Make EditStyle appear in customization dialog

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113446] "Edit Style" menu command missing from customize dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113446

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sfx2/sdi

[Yousuf Philips]

 sfx2/sdi/sfx.sdi |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 32ebd3d9351636c5c62c3939662ce3e057c714e7
Author: Yousuf Philips 
Date:   Thu Oct 26 11:56:44 2017 +0400

tdf#113446 Make EditStyle appear in customization dialog

Change-Id: I4340ee14478384d84148323345b498710cba4696
Reviewed-on: https://gerrit.libreoffice.org/43868
Reviewed-by: Maxim Monastirsky 
Tested-by: Jenkins 
Reviewed-by: Yousuf Philips 

diff --git a/sfx2/sdi/sfx.sdi b/sfx2/sdi/sfx.sdi
index 26265ed57bbf..2ab56c45993f 100644
--- a/sfx2/sdi/sfx.sdi
+++ b/sfx2/sdi/sfx.sdi
@@ -1080,9 +1080,9 @@ SfxVoidItem EditStyle SID_STYLE_EDIT
 RecordAbsolute = FALSE,
 RecordPerSet;
 
-AccelConfig = FALSE,
-MenuConfig = FALSE,
-ToolBoxConfig = FALSE,
+AccelConfig = TRUE,
+MenuConfig = TRUE,
+ToolBoxConfig = TRUE,
 GroupId = SfxGroupId::Template;
 ]
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 95946] View menu and Display Mode tab order inconsistent

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95946

--- Comment #7 from Yousuf Philips (jay)  ---
The patch is here, if the agreement is to go forward
https://gerrit.libreoffice.org/#/c/43966/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108458] Label changes for Toolbar use degrade function listing in the Customize dialog--have duplicate entries on the list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108458

--- Comment #9 from V Stuart Foote  ---
(In reply to Yousuf Philips (jay) from comment #8)
> I get the issue now Stuart and you should file an enhancement bug for a11y
> that it should read the button tooltip and not the labels in the toolbars,
> as this wont be something solved in this issue.

Will do, just want to be sure that while refactoring the labeling that we don't
complicate what is needed for a11y support--and ideally facilitate it as
tooltip/extended tooltip from help should be derived from the label structure
in some fashion.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108458] Label changes for Toolbar use degrade function listing in the Customize dialog--have duplicate entries on the list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108458

--- Comment #8 from Yousuf Philips (jay)  ---
I get the issue now Stuart and you should file an enhancement bug for a11y that
it should read the button tooltip and not the labels in the toolbars, as this
wont be something solved in this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: correctly adding Help source to local repo

[Cor Nouws]

Hi Eike, Christian,

Eike Rathke wrote on 24-10-17 15:56:

> Define "correctly" ;-)

Ah, you got me ;)

Let me reply that the answers of you two made it clear to me that a
simple git clone would not have worked.
And give me useful hints that will help me to get the help
indeed integrated in the existing build.
If I come to it, and have additional questions, I'll be back here of course.

thanks for now!
Cor

-- 
Cor Nouws
GPD key ID: 0xB13480A6 - 591A 30A7 36A0 CE3C 3D28  A038 E49D 7365 B134 80A6
- vrijwilliger http://nl.libreoffice.org
- volunteer http://www.libreoffice.org
- The Document Foundation Membership Committee Member
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 111486] [META] Regressions from EMF+ reworking

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111486

--- Comment #3 from Commit Notification 
 ---
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b3ec92eaab075f58472717e87406bdf4c8915f5c

tdf#111486 Fix description of SAL_ macro after EMF refactor

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - comphelper/source emfio/source include/sal

[Caolán McNamara]

 comphelper/source/misc/docpasswordhelper.cxx |2 
 emfio/source/reader/emfreader.cxx|  132 +--
 emfio/source/reader/mtftools.cxx |4 
 include/sal/log-areas.dox|4 
 4 files changed, 74 insertions(+), 68 deletions(-)

New commits:
commit 8f293eedcdfaf2507d78f5cd9993e56f1796675a
Author: Caolán McNamara 
Date:   Fri Oct 27 17:00:41 2017 +0100

fix memory leak

Change-Id: I6683ab0d39dbbb5c0ba0958d72f0a1bbfab47164
Reviewed-on: https://gerrit.libreoffice.org/43954
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/comphelper/source/misc/docpasswordhelper.cxx 
b/comphelper/source/misc/docpasswordhelper.cxx
index ecf16fa2d3df..7d761bb9c740 100644
--- a/comphelper/source/misc/docpasswordhelper.cxx
+++ b/comphelper/source/misc/docpasswordhelper.cxx
@@ -336,6 +336,8 @@ Sequence< sal_Int8 > DocPasswordHelper::GetXLHashAsSequence(
 
 // Erase KeyData array and leave.
 rtl_secureZeroMemory (pKeyData, sizeof(pKeyData));
+
+rtl_digest_destroy(hDigest);
 }
 
 return aResultKey;
commit b3ec92eaab075f58472717e87406bdf4c8915f5c
Author: Bartosz Kosiorek 
Date:   Wed Oct 25 15:31:48 2017 +0200

tdf#111486 Fix description of SAL_ macro after EMF refactor

Change-Id: Ia4530d987e8555a5c09d49492e09079a3710b53b
Reviewed-on: https://gerrit.libreoffice.org/43838
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/emfio/source/reader/emfreader.cxx 
b/emfio/source/reader/emfreader.cxx
index a6f6d218fa98..4ffecf5d8e03 100644
--- a/emfio/source/reader/emfreader.cxx
+++ b/emfio/source/reader/emfreader.cxx
@@ -420,14 +420,14 @@ namespace emfio
 mpInputStream->ReadUInt16( type ).ReadUInt16( flags ).ReadUInt32( 
size ).ReadUInt32( dataSize );
 nRemainder -= nRequiredHeaderSize;
 
-SAL_INFO ("vcl.emf", "\t\tEMF+ record type: " << std::hex << type 
<< std::dec);
+SAL_INFO ("emfio", "\t\tEMF+ record type: " << std::hex << type << 
std::dec);
 
 // Get Device Context
 // TODO We should use  EmfPlusRecordType::GetDC instead
 if( type == 0x4004 )
 {
 bHaveDC = true;
-SAL_INFO ("vcl.emf", "\t\tEMF+ lock DC (device context)");
+SAL_INFO ("emfio", "\t\tEMF+ lock DC (device context)");
 }
 
 // look for the "dual mode" in header
@@ -493,7 +493,7 @@ namespace emfio
 tools::Polygon EmfReader::ReadPolygon(sal_uInt32 nStartIndex, sal_uInt32 
nPoints)
 {
 bool bRecordOk = nPoints <= SAL_MAX_UINT16;
-SAL_WARN_IF(!bRecordOk, "vcl.emf", "polygon record has more polygons 
than we can handle");
+SAL_WARN_IF(!bRecordOk, "emfio", "polygon record has more polygons 
than we can handle");
 if (!bRecordOk)
 return tools::Polygon();
 
@@ -504,7 +504,7 @@ namespace emfio
 *mpInputStream >> nX >> nY;
 if (!mpInputStream->good())
 {
-SAL_WARN("vcl.emf", "short read on polygon, truncating");
+SAL_WARN("emfio", "short read on polygon, truncating");
 aPolygon.SetSize(i);
 break;
 }
@@ -656,21 +656,21 @@ namespace emfio
 
 bool bFlag = false;
 
-SAL_INFO ("vcl.emf", "0x" << std::hex << (nNextPos - nRecSize) <<  
"-0x" << nNextPos << " " << record_type_name(nRecType) << " size: " <<  
nRecSize << std::dec);
+SAL_INFO ("emfio", "0x" << std::hex << (nNextPos - nRecSize) <<  
"-0x" << nNextPos << " " << record_type_name(nRecType) << " size: " <<  
nRecSize << std::dec);
 
 if( bEnableEMFPlus && nRecType == EMR_COMMENT ) {
 sal_uInt32 length;
 
 mpInputStream->ReadUInt32( length );
 
-SAL_INFO("vcl.emf", "\tGDI comment, length: " << length);
+SAL_INFO("emfio", "\tGDI comment, length: " << length);
 
 if( mpInputStream->good() && length >= 4 && length <= 
mpInputStream->remainingSize() ) {
 sal_uInt32 nCommentId;
 
 mpInputStream->ReadUInt32( nCommentId );
 
-SAL_INFO ("vcl.emf", "\t\tbegin " << (char)(nCommentId & 
0xff) << (char)((nCommentId & 0xff00) >> 8) << (char)((nCommentId & 0xff) 
>> 16) << (char)((nCommentId & 0xff00) >> 24) << " id: 0x" << std::hex << 
nCommentId << std::dec);
+SAL_INFO ("emfio", "\t\tbegin " << (char)(nCommentId & 
0xff) << (char)((nCommentId & 0xff00) >> 8) << (char)((nCommentId & 0xff) 
>> 16) << (char)((nCommentId & 0xff00) >> 24) << " id: 0x" << std::hex << 
nCommentId << std::dec);
 
 if( nCommentId == EMR_COMMENT_EMFPLUS && nRecSize >= 12 )
 

[Libreoffice-bugs] [Bug 67670] Change default value for spacing on Columns tab to be more than 0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67670

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |tietze.he...@gmail.com
   |desktop.org |

--- Comment #11 from Heiko Tietze  ---
We decided in the design team to go with 0.5cm as default for column spacing.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - sdext/source sd/source sw/inc sw/qa sw/source

[Noel Grandin]

 sd/source/filter/html/htmlex.cxx   |8 --
 sd/source/filter/html/htmlex.hxx   |2 
 sdext/source/minimizer/informationdialog.cxx   |   10 +--
 sdext/source/minimizer/optimizerdialogcontrols.cxx |   69 +++-
 sw/inc/SwStyleNameMapper.hxx   |4 -
 sw/inc/dbmgr.hxx   |3 
 sw/inc/doc.hxx |6 -
 sw/inc/undobj.hxx  |4 -
 sw/inc/unocrsrhelper.hxx   |8 --
 sw/qa/extras/mailmerge/mailmerge.cxx   |2 
 sw/source/core/doc/SwStyleNameMapper.cxx   |8 +-
 sw/source/core/doc/docnum.cxx  |5 -
 sw/source/core/docnode/ndnotxt.cxx |2 
 sw/source/core/docnode/ndtbl.cxx   |   40 +---
 sw/source/core/docnode/ndtbl1.cxx  |2 
 sw/source/core/docnode/node.cxx|4 -
 sw/source/core/frmedt/fetab.cxx|2 
 sw/source/core/inc/objectformatter.hxx |3 
 sw/source/core/layout/atrfrm.cxx   |2 
 sw/source/core/layout/objectformatter.cxx  |5 -
 sw/source/core/layout/paintfrm.cxx |6 -
 sw/source/core/text/EnhancedPDFExportHelper.cxx|8 +-
 sw/source/core/txtnode/fmtatr2.cxx |   12 +--
 sw/source/core/txtnode/ndtxt.cxx   |   37 +--
 sw/source/core/undo/undobj.cxx |9 --
 sw/source/core/unocore/SwXTextDefaults.cxx |2 
 sw/source/core/unocore/unocrsrhelper.cxx   |4 -
 sw/source/core/unocore/unoframe.cxx|6 -
 sw/source/core/unocore/unoidx.cxx  |   30 +++--
 sw/source/core/unocore/unoobj.cxx  |   19 ++---
 sw/source/core/unocore/unosett.cxx |   40 +---
 sw/source/core/unocore/unostyle.cxx|   40 ++--
 sw/source/core/unocore/unotbl.cxx  |4 -
 sw/source/filter/basflt/fltshell.cxx   |   11 +--
 sw/source/filter/html/css1atr.cxx  |   12 +--
 sw/source/filter/html/htmlatr.cxx  |2 
 sw/source/filter/html/htmldrawwriter.cxx   |   70 +
 sw/source/filter/html/htmlflywriter.cxx|2 
 sw/source/filter/html/wrthtml.hxx  |3 
 sw/source/filter/ww8/ww8par.cxx|   13 +--
 sw/source/filter/xml/xmlfmt.cxx|3 
 sw/source/filter/xml/xmlfmte.cxx   |3 
 sw/source/ui/chrdlg/numpara.cxx|6 -
 sw/source/uibase/app/docstyle.cxx  |4 -
 sw/source/uibase/dbui/dbmgr.cxx|   15 +---
 sw/source/uibase/inc/numpara.hxx   |2 
 sw/source/uibase/uno/unotxvw.cxx   |4 -
 47 files changed, 226 insertions(+), 330 deletions(-)

New commits:
commit 5f41f7b33e2f85be4c9d7380822916a7469cf39b
Author: Noel Grandin 
Date:   Fri Oct 27 16:17:13 2017 +0200

loplugin:constantparam in sw

Change-Id: Ia477de0fb910f6a8fbb0a5054f4bdb43dd9ff381
Reviewed-on: https://gerrit.libreoffice.org/43951
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sw/inc/SwStyleNameMapper.hxx b/sw/inc/SwStyleNameMapper.hxx
index 2ed5d2cdd08c..ee976470c714 100644
--- a/sw/inc/SwStyleNameMapper.hxx
+++ b/sw/inc/SwStyleNameMapper.hxx
@@ -137,13 +137,13 @@ public:
 // This gets the UI Name from the programmatic name
 static const OUString& GetUIName(const OUString& rName, 
SwGetPoolIdFromName);
 static void FillUIName(const OUString& rName, OUString& rFillName,
-SwGetPoolIdFromName, bool bDisambiguate);
+SwGetPoolIdFromName);
 
 // Get the programmatic Name from the UI name
 static const OUString& GetProgName(const OUString& rName,
SwGetPoolIdFromName);
 static void FillProgName(const OUString& rName, OUString& 
rFillName,
-SwGetPoolIdFromName, bool bDisambiguate);
+SwGetPoolIdFromName);
 
 // This gets the UI Name from the Pool ID
 SW_DLLPUBLIC static void FillUIName(sal_uInt16 nId, OUString& rFillName);
diff --git a/sw/inc/dbmgr.hxx b/sw/inc/dbmgr.hxx
index c78907987266..8d709cfb7431 100644
--- a/sw/inc/dbmgr.hxx
+++ b/sw/inc/dbmgr.hxx
@@ -433,8 +433,7 @@ public:
  Convenience function, which calls GetDBunoURI and has just one mandatory 
parameter.
  In case of success it returns the registered name, otherwise an empty 
string.
  */
-static OUStringLoadAndRegisterDataSource(const OUString& rURI, 
const OUString *pPrefix, const OUString *pDestDir,
- 

[Libreoffice-ux-advise] [Bug 113421] When UI open on widescreen monitor allow horizontal packing of toolbars, i.e. another toolbar packed to right of Standard toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113421

--- Comment #5 from zyklo...@web.de ---
Not per hardware, but per window width!

I use sidebar only (what is especially useful for wide-screen displays).

When I work on larger documents, I often change to full screen, for displaying
2-3 pages at once. But the top bar being not used for the main part, isn’t that
nice. You probably could check the window width against being as wide, for
fitting the second bar to the right of the first and then do just that…?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 113421] When UI open on widescreen monitor allow horizontal packing of toolbars, i.e. another toolbar packed to right of Standard toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113421

--- Comment #5 from zyklo...@web.de ---
Not per hardware, but per window width!

I use sidebar only (what is especially useful for wide-screen displays).

When I work on larger documents, I often change to full screen, for displaying
2-3 pages at once. But the top bar being not used for the main part, isn’t that
nice. You probably could check the window width against being as wide, for
fitting the second bar to the right of the first and then do just that…?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113486] German Character ß is not handle properly in LibreOffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113486

Adolfo Jayme  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Adolfo Jayme  ---
Yep, we still don’t handle the new capitalization of this character to ẞ
instead of SS.

*** This bug has been marked as a duplicate of bug 110003 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 110003] RFE Choice of replacement of ß when capitalized between SS and ẞ

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=110003

Adolfo Jayme  changed:

   What|Removed |Added

 CC||stuartc...@gmail.com

--- Comment #3 from Adolfo Jayme  ---
*** Bug 113486 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - configure.ac ios/LibreOfficeKit ios/LibreOfficeLight README.md

[jan Iversen]

 README.md   |4 +--
 configure.ac|4 +--
 ios/LibreOfficeKit/LibreOfficeKit.xcodeproj/project.pbxproj |   12 
+-
 ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj |   12 
+-
 ios/LibreOfficeLight/LibreOfficeLight/AppDelegate.swift |   10 +---
 ios/LibreOfficeLight/LibreOfficeLight/DocumentController.swift  |9 ---
 ios/LibreOfficeLight/LibreOfficeLight/en.lproj/Main.storyboard  |4 +--
 7 files changed, 29 insertions(+), 26 deletions(-)

New commits:
commit 8cd7e7dfe6630648d110fa77991c283c8bf069bb
Author: jan Iversen 
Date:   Fri Oct 27 20:04:38 2017 +0200

iOS update to 11.0

Starting to use 11.0 features

Change-Id: I0e147c0b436a93d11f220b533a5b2091f7cb56fc

diff --git a/README.md b/README.md
index 62deaffcbf27..3fe1dabac50d 100644
--- a/README.md
+++ b/README.md
@@ -42,8 +42,8 @@ run and compile LibreOffice, also used by the TDF builds:
  * Runtime: RHEL 6 or CentOS 6
  * Build: GCC 4.8.1 or Clang
 * iOS (only for LibreOfficeKit):
- * Runtime: 10.3 (only support for newer i devices == 64 bit)
- * Build: Xcode 9.0 and iPhone SDK 10.3
+ * Runtime: 11.0 (only support for newer i devices == 64 bit)
+ * Build: Xcode 9.0 and iPhone SDK 11.0
 
 If you want to use Clang with the LibreOffice compiler plugins, the minimal
 version of Clang is 3.4. Since Xcode doesn't provide the compiler plugin
diff --git a/configure.ac b/configure.ac
index d422adefa1e0..309ccb06b36c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2868,8 +2868,8 @@ if test $_os = iOS; then
 fi
 xcode_developer=`xcode-select -print-path`
 
-current_sdk_ver=10.3
-for sdkver in 11.0 10.3; do
+current_sdk_ver=11.0
+for sdkver in 11.0; do
 
t=$xcode_developer/Platforms/$platform.platform/Developer/SDKs/$platform$sdkver.sdk
 if test -d $t; then
 ios_sdk=$sdkver
diff --git a/ios/LibreOfficeKit/LibreOfficeKit.xcodeproj/project.pbxproj 
b/ios/LibreOfficeKit/LibreOfficeKit.xcodeproj/project.pbxproj
index caa67a55b8bf..f8a988031044 100644
--- a/ios/LibreOfficeKit/LibreOfficeKit.xcodeproj/project.pbxproj
+++ b/ios/LibreOfficeKit/LibreOfficeKit.xcodeproj/project.pbxproj
@@ -198,14 +198,14 @@

"$(LO_WORKDIR)/UnpackedTarball/icu/source/common",
"$(LO_SRCDIR)/ios/generated",
);
-   IPHONEOS_DEPLOYMENT_TARGET = 10.3;
+   IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_GENERATE_MAP_FILE = YES;
LD_MAP_FILE_PATH = ./iosKit.map;
LD_QUOTE_LINKER_ARGUMENTS_FOR_COMPILER_DRIVER = 
NO;
MACH_O_TYPE = staticlib;
MTL_ENABLE_DEBUG_INFO = YES;
ONLY_ACTIVE_ARCH = YES;
-   PRELINK_FLAGS = "-Wl -ios_version_min 10.3 -lz 
-liconv";
+   PRELINK_FLAGS = "-Wl -ios_version_min 11.0 -lz 
-liconv";
SDKROOT = iphoneos;
VALID_ARCHS = "x86_64 arm64";
};
@@ -265,14 +265,14 @@

"$(LO_WORKDIR)/UnpackedTarball/icu/source/common",
"$(LO_SRCDIR)/ios/generated",
);
-   IPHONEOS_DEPLOYMENT_TARGET = 10.3;
+   IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_GENERATE_MAP_FILE = YES;
LD_MAP_FILE_PATH = ./iosKit.map;
LD_QUOTE_LINKER_ARGUMENTS_FOR_COMPILER_DRIVER = 
NO;
MACH_O_TYPE = staticlib;
MTL_ENABLE_DEBUG_INFO = NO;
ONLY_ACTIVE_ARCH = YES;
-   PRELINK_FLAGS = "-Wl -ios_version_min 10.3 -lz 
-liconv";
+   PRELINK_FLAGS = "-Wl -ios_version_min 11.0 -lz 
-liconv";
SDKROOT = iphoneos;
VALIDATE_PRODUCT = YES;
VALID_ARCHS = "x86_64 arm64";
@@ -285,7 +285,7 @@
buildSettings = {
MACH_O_TYPE = staticlib;
OTHER_LDFLAGS = "";
-   PRELINK_FLAGS = "-ios_version_min 10.3";
+   PRELINK_FLAGS = "-ios_version_min 11.0";
PRELINK_LIBS = "";
PRODUCT_NAME = "$(TARGET_NAME)";
SKIP_INSTALL = YES;
@@ -298,7 +298,7 @@

[Libreoffice-bugs] [Bug 108458] Label changes for Toolbar use degrade function listing in the Customize dialog--have duplicate entries on the list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108458

--- Comment #7 from V Stuart Foote  ---
(In reply to Yousuf Philips (jay) from comment #6)
> Sorry Stuart, didnt fully get the a11y issue you were trying to address.
> Where you saying that in addition to whatever tooltip that is read by the
> screen reader, some additional instructions should be read?
> 

What I'm asking is that however the labeling is reworked--that function for
a11y be taken into account and made consistent as well.

For a11y we probably should be reading the descriptive tooltip for menu and
button objects.  But currently 5.4.3, with keyboard movements (F10 -> F6 ->
; or ) just the short button/menu label is
exposed.  

This contrasts to mouseover behavior which gets the descriptive tooltip--or the
extended tooltip pulled from offline local help when installed (and
auto-enabled when an AT is in use).

Differences between keyboard and mouseover event triggers are probably
unavoidable--but as the labeling controls what is exposed to AT, it needs to
considered as well while reworking label structure--and ideally make keyboard
and mouseover expose the same tooltip/enhanced tooltip when traversing menus,
context menus, and toolbars when Assistive Technology tool support is enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112416] [META] XLSX pivot table bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112416
Bug 112416 depends on bug 113159, which changed state.

Bug 113159 Summary: Pivot table: tabular mode is converted to oultine mode 
after RT XLSX in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=113159

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113486] German Character ß is not handle properly in LibreOffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113486

--- Comment #1 from Stuart Ng  ---
Created attachment 137328
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137328=edit
Sample file with the German Letter

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113486] New: German Character ß is not handle properly in LibreOffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113486

Bug ID: 113486
   Summary: German Character ß is not handle properly in
LibreOffice
   Product: LibreOffice
   Version: 4.4 all versions
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stuartc...@gmail.com

Description:
Opening a PPTX with that German Character shows the letters 'SS'

Steps to Reproduce:
1. Open the attached pptx


Actual Results:  
The letter ß is showing as SS. This causes the last character of the text to
get cut off

Expected Results:
The letter ß should show


Reproducible: Always


User Profile Reset: No



Additional Info:
Issue remains in LibreOffice 5.4


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/62.0.3202.62 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103381] [META] Pivot table (aka Data Pilot) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103381
Bug 103381 depends on bug 113268, which changed state.

Bug 113268 Summary: Pivot table: Missing popup button after opening a pivot 
table from ODS
https://bugs.documentfoundation.org/show_bug.cgi?id=113268

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basic/source

[Eike Rathke]

 basic/source/sbx/sbxconv.hxx |2 +-
 basic/source/sbx/sbxdec.cxx  |3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

New commits:
commit ae531b69b3d8f0aa1bb1438e0af63b0710c9c47a
Author: Eike Rathke 
Date:   Fri Oct 27 19:07:59 2017 +0200

Another ImpGetIntntlSep() fix, tdf#81671 follow-up

Change-Id: I9c056a137ab873f677e374d75c4e2f06bf370f21

diff --git a/basic/source/sbx/sbxconv.hxx b/basic/source/sbx/sbxconv.hxx
index 25edf9bc2163..441729a8d0cc 100644
--- a/basic/source/sbx/sbxconv.hxx
+++ b/basic/source/sbx/sbxconv.hxx
@@ -33,7 +33,7 @@ extern ErrCode ImpScan
 // with advanced evaluation (International, "TRUE"/"FALSE")
 extern bool ImpConvStringExt( OUString& rSrc, SbxDataType eTargetType );
 
-void ImpGetIntntlSep( sal_Unicode& rcDecimalSep, sal_Unicode& rcThousandSep );
+void ImpGetIntntlSep( sal_Unicode& rcDecimalSep, sal_Unicode& rcThousandSep, 
sal_Unicode& rcDecimalSepAlt );
 
 // SBXINT.CXX
 
diff --git a/basic/source/sbx/sbxdec.cxx b/basic/source/sbx/sbxdec.cxx
index 7896811dec25..b41bc914df92 100644
--- a/basic/source/sbx/sbxdec.cxx
+++ b/basic/source/sbx/sbxdec.cxx
@@ -203,7 +203,8 @@ bool SbxDecimal::setString( OUString* pOUString )
 // Convert delimiter
 sal_Unicode cDecimalSep;
 sal_Unicode cThousandSep;
-ImpGetIntntlSep( cDecimalSep, cThousandSep );
+sal_Unicode cDecimalSepAlt;
+ImpGetIntntlSep( cDecimalSep, cThousandSep, cDecimalSepAlt );
 
 bool bRet = false;
 HRESULT hResult;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: basic/source

[Eike Rathke]

 basic/source/sbx/sbxdec.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit ab7b10d6c37af426c782e8cb46563bc206e5881c
Author: Eike Rathke 
Date:   Fri Oct 27 19:01:52 2017 +0200

Fix build of Windows-only code, tdf#81671 follow-up

Change-Id: I68a468857c529e8cab80d4453832dc9f4b3657d8

diff --git a/basic/source/sbx/sbxdec.cxx b/basic/source/sbx/sbxdec.cxx
index 8356d36cab77..7896811dec25 100644
--- a/basic/source/sbx/sbxdec.cxx
+++ b/basic/source/sbx/sbxdec.cxx
@@ -354,7 +354,8 @@ void SbxDecimal::getString( OUString& rString )
 // Convert delimiter
 sal_Unicode cDecimalSep;
 sal_Unicode cThousandSep;
-ImpGetIntntlSep( cDecimalSep, cThousandSep );
+sal_Unicode cDecimalSepAlt;
+ImpGetIntntlSep( cDecimalSep, cThousandSep, cDecimalSepAlt );
 
 if( cDecimalSep != '.' || cThousandSep != ',' )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 113485] New: The 'Find and Replace' dialog box should react to a text selection made

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113485

Bug ID: 113485
   Summary: The 'Find and Replace' dialog box should react to a
text selection made
   Product: LibreOffice
   Version: 5.0 all versions
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: christianw_lehm...@arcor.de

Description:
If I select (mark) some stretch of text in the document and then call 'Find and
replace' (CTRL-ALT f), I still need to click 'Further options' and 'Only in
selection'. Could Writer please do this for me?

Steps to Reproduce:
1. Select/mark some paragraph of your text.
2. CTRL-ALT f.


Actual Results:  
No reaction.

Expected Results:
'Further options' should be opened, and 'Only in selection' should be marked.


Reproducible: Always


User Profile Reset: No



Additional Info:
If the user did not mean it (this could only be by error), he can always unmark
the cell 'Only in selection' before starting the operation.

This has been a desideratum since earlier versions, and still is in the current
version.


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:56.0) Gecko/20100101
Firefox/56.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101856] MAILMERGE Add conditional to expand / collapse bookmarks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101856

--- Comment #2 from Jan-Marek Glogowski  ---
Created attachment 137327
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137327=edit
Example glade bookmarks dialog

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112810] [META] Arabic language-specific RTL issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112810
Bug 112810 depends on bug 81671, which changed state.

Bug 81671 Summary: RTL: reconsider Arabic decimal separator handling
https://bugs.documentfoundation.org/show_bug.cgi?id=81671

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111942] [META] User locale bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111942
Bug 111942 depends on bug 81671, which changed state.

Bug 81671 Summary: RTL: reconsider Arabic decimal separator handling
https://bugs.documentfoundation.org/show_bug.cgi?id=81671

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113477] [META] Decimal separator key bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113477
Bug 113477 depends on bug 81671, which changed state.

Bug 81671 Summary: RTL: reconsider Arabic decimal separator handling
https://bugs.documentfoundation.org/show_bug.cgi?id=81671

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91292] FORMATTING: DOCX, Paragraph background color set to 'No Fill' not persisted on save

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91292

--- Comment #5 from Justin L  ---
The ability to round-trip the background was lost as of LO 4.4 commit
7d9bb549d498d6beed2c4050c402d09643febdfa by Author: Armin Le Grand on
CommitDate: Tue Jul 1 13:30:09 2014 +0200
   Related: #i124638# Second step of DrawingLayer FillAttributes...
   for Writer objects, now added support for Paragraph and PageStyle (including
   Header and Footer) for direct attributes and style attributes

At that point, you can't even SEE that a background color is set, until LO5.0
commit 24077b2d52ab3d0fd0db5afb25d8b94b62386e3e by Author: Miklos Vajna on
CommitDate: Sun Feb 1 01:48:38 2015 +0100
writerfilter: import paragraph color as fill attributes

In theory this is to be in sync with the ODF import. In practice the
old
UNO property seems not to have a proper fallback to populate the doc
model with the fillattributes, so without this even if the import
result
is visible, it would be lost on ODF export.

It looks like FormatFillStyle needs to update the m_pBackgroundAttrList?  This
total hack worked...
if ( m_pBackgroundAttrList.is() && rFillStyle.GetValue() ==
drawing::FillStyle_NONE )
{
m_pBackgroundAttrList = FastSerializerHelper::createAttrList();
m_pBackgroundAttrList->add( FSNS( XML_w, XML_fill ), "auto" );
m_pBackgroundAttrList->add( FSNS( XML_w, XML_val ), "clear" );
}

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113447] Crash in: RTSPaperPage::update()

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113447

--- Comment #5 from Peter Maunder  ---
Created attachment 137326
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137326=edit
gdbtrace.log from crash as requested

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 26 commits - basic/source i18npool/inc i18npool/source include/svl include/unotools offapi/com sc/inc sc/qa sc/source svl/source svx/source sw/source unotools/source vc

[Eike Rathke]

 basic/source/sbx/sbxscan.cxx  |   34 ++--
 i18npool/inc/cclass_unicode.hxx   |5 
 i18npool/inc/collatorImpl.hxx |4 
 i18npool/inc/numberformatcode.hxx |4 
 i18npool/inc/transliterationImpl.hxx  |4 
 i18npool/source/characterclassification/cclass_unicode_parser.cxx |   22 ++
 i18npool/source/collator/collatorImpl.cxx |4 
 i18npool/source/localedata/LocaleNode.cxx |   19 +-
 i18npool/source/localedata/data/ar_DZ.xml |1 
 i18npool/source/localedata/data/ar_EG.xml |1 
 i18npool/source/localedata/data/ar_LB.xml |1 
 i18npool/source/localedata/data/ar_SA.xml |1 
 i18npool/source/localedata/data/ar_TN.xml |1 
 i18npool/source/localedata/data/fa_IR.xml |1 
 i18npool/source/localedata/data/locale.dtd|3 
 i18npool/source/numberformatcode/numberformatcode.cxx |4 
 i18npool/source/transliteration/transliterationImpl.cxx   |4 
 include/svl/zforlist.hxx  |7 
 include/unotools/localedatawrapper.hxx|   74 
+-
 offapi/com/sun/star/i18n/LocaleItem.idl   |   12 +
 sc/inc/stringutil.hxx |3 
 sc/qa/unit/ucalc.cxx  |1 
 sc/source/core/data/column3.cxx   |   12 -
 sc/source/core/data/table3.cxx|2 
 sc/source/core/tool/compiler.cxx  |   17 +-
 sc/source/core/tool/formulaopt.cxx|8 -
 sc/source/core/tool/stringutil.cxx|6 
 sc/source/ui/cctrl/editfield.cxx  |7 
 sc/source/ui/docshell/docsh6.cxx  |4 
 sc/source/ui/miscdlgs/solveroptions.cxx   |8 -
 sc/source/ui/sidebar/AlignmentPropertyPanel.cxx   |3 
 svl/source/numbers/zforfind.cxx   |   15 +-
 svl/source/numbers/zforlist.cxx   |   13 +
 svx/source/sidebar/possize/PosSizePropertyPanel.cxx   |3 
 svx/source/sidebar/shadow/ShadowPropertyPanel.cxx |3 
 svx/source/svdraw/svdomeas.cxx|9 -
 sw/source/core/bastyp/calc.cxx|5 
 sw/source/core/doc/docsort.cxx|5 
 unotools/source/i18n/localedatawrapper.cxx|   58 
++-
 vcl/source/control/field.cxx  |3 
 vcl/source/control/longcurr.cxx   |3 
 41 files changed, 293 insertions(+), 101 deletions(-)

New commits:
commit 89e0a9183e7b21596bcd5504b104bf816f1d3ef3
Author: Eike Rathke 
Date:   Fri Oct 27 18:27:44 2017 +0200

Resolves: tdf#81671 add DecimalSeparatorAlternative to ar-* and fa-IR

In locales that use 'Ù«' U+066B ARABIC DECIMAL SEPARATOR
additionally have '.' normal dot as input separator.

Change-Id: Icb3f42374776e3fc65af3270abaca26ea5b24082

diff --git a/i18npool/source/localedata/data/ar_DZ.xml 
b/i18npool/source/localedata/data/ar_DZ.xml
index 16362ced8c01..4cb4d155018b 100644
--- a/i18npool/source/localedata/data/ar_DZ.xml
+++ b/i18npool/source/localedata/data/ar_DZ.xml
@@ -33,6 +33,7 @@
   /
    
   Ù«
+  .
   :
   Ù«
   ;
diff --git a/i18npool/source/localedata/data/ar_EG.xml 
b/i18npool/source/localedata/data/ar_EG.xml
index 4dfe9bec8ff1..5bcb4b689c30 100644
--- a/i18npool/source/localedata/data/ar_EG.xml
+++ b/i18npool/source/localedata/data/ar_EG.xml
@@ -33,6 +33,7 @@
   /
   Ù¬
   Ù«
+  .
   :
   .
   ;
diff --git a/i18npool/source/localedata/data/ar_LB.xml 
b/i18npool/source/localedata/data/ar_LB.xml
index 9499dfb8ba48..64ac706e8fa4 100644
--- a/i18npool/source/localedata/data/ar_LB.xml
+++ b/i18npool/source/localedata/data/ar_LB.xml
@@ -33,6 +33,7 @@
   /
   Ù¬
   Ù«
+  .
   :
   .
   ;
diff --git a/i18npool/source/localedata/data/ar_SA.xml 
b/i18npool/source/localedata/data/ar_SA.xml
index 05f0fb81edb3..f7970ffedd30 100644
--- a/i18npool/source/localedata/data/ar_SA.xml
+++ b/i18npool/source/localedata/data/ar_SA.xml
@@ -33,6 +33,7 @@
   /
   Ù¬
   Ù«
+  .
   :
   .
   ;
diff --git a/i18npool/source/localedata/data/ar_TN.xml 
b/i18npool/source/localedata/data/ar_TN.xml
index 014f77524603..ae37a4b84c0f 100644
--- 

Re: dumpAsXml

[Miklos Vajna]

Hi,

On Thu, Oct 26, 2017 at 02:24:33AM +, Yemelyanenko Fyodor 
 wrote:
> During work on bug https://bugs.documentfoundation.org/show_bug.cgi?id=108124 
> I found dumpAsXml methods in different classes (i.e. SwNode, SwNodes, SwDoc, 
> SwPaM, SwPosition, etc.)
> I've created separate function which creates XML writer, calls dumpAsXml from 
> some class and outputs result to debugger output. This is useful, as I can 
> call such function from debugger (using .call in WinDbg) and immediately get 
> class contents as xml (i.e SwNodes as xml). This function accepts only one 
> parameter - pointer to class. Such pointer can be found in locals window in 
> debugger. So dumping any class to debug output become easy and quick task, 
> without rewriting and recompiling code.
> 
> The code itself is at the end of this message (this is draft code, written 
> quickly).
> 
> I can make this code better (add cross-platform'ness as it depends on 
> OutputDebugStringA and I'm not sure that it exists in any other OS than 
> Windows), and submit as patch to master. Also I can add several lines here on 
> how to use my function to get xml dump during debugging 
> https://wiki.documentfoundation.org/Development/How_to_debug#Debugging_options
> 
> If all this makes sense and can be useful not only for me?

There are 2 dumpers in sw, a document and a layout dumper. To dump the
layout from a debugger, you need a reference to the SwRootFrame of the
document, then you can call pRoot->dumpAsXml() already, it'll write its
output in a file called layout.xml in the current directory.

The same is true for the doc xml dump, just it's SwDoc::dumpAsXml() and
the output is nodes.xml.

If some of that is not up to your expectations, feel free to submit a
gerrit patch to improve the output, the current contents is quite
ad-hoc, based on what was necessary for debugging past bugs and
features. :-)

(sw/qa/extras/README documents how the UI can invoke these functions in
debug mode via (Shift-)F12.)

Regards,

Miklos


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 110794] Slower LO redraw speed with big Writer table since 5.3 ( DirectWrite)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=110794

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #8 from V Stuart Foote  ---
Likely fixed by
https://cgit.freedesktop.org/libreoffice/core/commit/?id=5440837e02dee8bc884e02be697bfd4def621d26=libreoffice-5-3

Please retest with 5.3.7.2, or 5.4.3.1 build (or 5.4.3.2 when posted).

http://downloadarchive.documentfoundation.org/libreoffice/old/5.3.7.2/win/
http://downloadarchive.documentfoundation.org/libreoffice/old/5.4.3.1/win/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4-3' - sc/Module_sc.mk

[Stephan Bergmann]

 sc/Module_sc.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 39e0a8bb79ed7854d7eb74b766c9a1ba4911afa8
Author: Stephan Bergmann 
Date:   Fri Oct 20 10:52:48 2017 +0200

Disable CppunitTset_sc_*_functions_test for linux_aarch64 for now, too

> Oct 20 10:21:31  erAck, when "Testing
>  
file:///run/build/libreoffice/sc/qa/unit/data/functions/array/fods/linest.fods"
>  in CppunitTest_sc_array_functions_test fails with non-informative 
expected 1
>  vs. actual 0, how can I reasonably debug that?  (and no, I don't have an 
X11
>  connection to the relevant machine, to see what opening that .fods with 
LO
>  would look like there)
> Oct 20 10:25:04  sberg: sigh.. we're still lacking an "analyze 
steps"
>  in the functions test loader, so far only loading the doc and inspecting
>  provides that; maybe getting individual cell results via UNO would work

So disable these tests for aarch64 for now too, to get Flathub builds 
unstuck,
until somebody finds a way to actually debug this.

Change-Id: I9bf30d0d7185497f9ad4b04b60b6a67f34a8c44e
(cherry picked from commit 6cb20e0b298f41fe88984aebfe5454f936a0ae3a)
Reviewed-on: https://gerrit.libreoffice.org/43591
Reviewed-by: Michael Stahl 
Reviewed-by: Rene Engelhard 
Tested-by: Rene Engelhard 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk
index 4ab8f50489e7..67407eb5ec25 100644
--- a/sc/Module_sc.mk
+++ b/sc/Module_sc.mk
@@ -65,7 +65,7 @@ $(eval $(call gb_Module_add_slowcheck_targets,sc, \
 # point weirdness (x87, registers, compiler optimization, ... whatever),
 # disable them until someone finds a real cure.
 
-ifneq ($(PLATFORMID),linux_x86)
+ifneq ($(filter-out linux_aarch64 linux_x86,$(PLATFORMID)),)
 $(eval $(call gb_Module_add_slowcheck_targets,sc, \
CppunitTest_sc_functions_test_old \
CppunitTest_sc_database_functions_test \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4-3' - bridges/Library_cpp_uno.mk

[Stephan Bergmann]

 bridges/Library_cpp_uno.mk |5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit f88341e87d744a8115968aa8c38bb7e28a820842
Author: Stephan Bergmann 
Date:   Thu Oct 19 15:29:38 2017 +0200

Again, no -fstack-protector-strong for gcc3_linux_aarch64/cpp2uno.cxx

8d12e4ec8b843d59661a12a7a92bfec7e4473e0f "No -fstack-protect-strong for
gcc3_linux_aarch64/cpp2uno.cxx vtableSlotCall" had done that in the past (so
that setting up the x0/x1 return registers in vtableSlotCall is not 
clobbered
by the stack protector code), but gbuild details have apparently changed in 
the
meantime, so that gb_CXXFLAGS_COMMON's -fstack-protector-strong now ends up 
on
the compiler command line before what is covered by 
gb_Library_add_cxxobjects's
argument, so didn't get subst'ed to -fstack-protector.  That caused Flathub
aarch64 builds to fail in CustomTarget_testtools/uno_test.

However, if both -fstack-protector-strong and -fstack-protector are present 
on
the command line, the second apparently wins, so use that hack for now.
(-fstack-protector-strong is only available since GCC 4.9, but 
-fstack-protector
is already available in our current baseline GCC 4.8.1, and even for a 
build on
that baseline it wouldn't hurt if cpp2uno.cxx was explicitly built with
-fstack-protector even if none of the other files were built with
-fstack-protector-strong.)

Change-Id: I9d78d2e5b08b7c0a4adb1531b482cd43617886f7
(cherry picked from commit dddb527db1562f30a2a2b20338dfc8458086a4a9)
Reviewed-on: https://gerrit.libreoffice.org/43565
Reviewed-by: Michael Stahl 
Reviewed-by: Rene Engelhard 
Tested-by: Rene Engelhard 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/bridges/Library_cpp_uno.mk b/bridges/Library_cpp_uno.mk
index 01ee21f848fe..62d26448937b 100644
--- a/bridges/Library_cpp_uno.mk
+++ b/bridges/Library_cpp_uno.mk
@@ -37,9 +37,8 @@ bridge_exception_objects := abi callvirtualfunction uno2cpp
 
 $(eval $(call gb_Library_add_cxxobjects,$(gb_CPPU_ENV)_uno, \
 bridges/source/cpp_uno/$(bridges_SELECTED_BRIDGE)/cpp2uno, \
-$(subst -fstack-protector-strong,-fstack-protector, \
-$(gb_LinkTarget_EXCEPTIONFLAGS) \
-$(call gb_LinkTarget__get_cxxflags,$(gb_CPPU_ENV)_uno)) \
+$(gb_LinkTarget_EXCEPTIONFLAGS) \
+$(call gb_LinkTarget__get_cxxflags,$(gb_CPPU_ENV)_uno) -fstack-protector \
 ))
 endif
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108458] Label changes for Toolbar use degrade function listing in the Customize dialog--have duplicate entries on the list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108458

--- Comment #6 from Yousuf Philips (jay)  ---
Sorry Stuart, didnt fully get the a11y issue you were trying to address. Where
you saying that in addition to whatever tooltip that is read by the screen
reader, some additional instructions should be read?

(In reply to Maxim Monastirsky from comment #5)
> Are you sure? I got the impression that the menu usually uses the shorter
> form. e.g. open the insert menu, you have there "Image...", "Chart...",
> Fontwork...", and most of those don't appear in context menus anyway.

It maybe 50/50 between which one uses the shorter form, but that all depends on
how much work i've been doing to improve the organization of the menu. ;D

> Is it really worse than adding the label directly into xml files? I
> understand that this requires writing the command name again in officecfg,
> but for that you get the possibility of reusing that label somewhere else,
> something you couldn't do if the label was in xml.

Didnt fully get what you meant here, but adding labels directly into the XML
file means that they wont be translatable (e.g. bug 101566).

> So basically we shouldn't care about users adding paste special to a
> different place, and still getting there "More Options..." by default?
> That's why I suggested that a completely different label should go to alias.

I know i should have written this down in my last comment but i had to rush
out. :D So if a user uses the customization dialog, the PopupLabel text wont be
used when adding it to the context menu, the Label text will be used.

> During my work on context menus, I noticed that in many cases (esp. in Calc)
> PopupLabel is the same as Label, and needed only because ContextLabel uses
> the shorter form. So as long as we have PopupLabel fallback to ContextLabel,
> there will be no solution for the string duplication in this case.
> Similarly, if PopupLabel will fallback to Label, surely it will require
> duplicates for other cases. Which just shows us that the whole idea of
> relying on fallbacks is just broken by design.

Which is why i suggested number 6, which allows string duplication. Let me give
an example, which i wanted to as well before but had to rush out. :D


  
Basic Shapes
  
  
~Basic
  
  
Insert Basic Shapes
  
  
TooltipLabel
  


So in this example, PopupLabel is pulling in the label from TooltipLabel as
both the Label and ContextLabel aren't suitable and this wont require the
translation team to translate the tootlip string a second time.

> That's already possible with aliases, but you seem to not like it for some
> reason. Maybe we should clearly define what are the problems of the current
> aliases implementation, and just try to address them?

Aliases require additional translation, they dont appear in the customization
dialog and would also separate labels from all appearing under a single uno
command node, which will likely complicate things more.

Would be great if we could have a jitsi meetup and discuss all these issues
once by live voice/text as i can see things will likely be miscommunicated by
comments. If you have time, would be great if you can jump on telegram[1] or
irc[2] when you are free, so we could find a suitable meetup time, or you can
join the weekly design meeting[3] on thursday at 1pm UTC. You are free to do
any of these outside of this issue as well, you to Stuart. :D

[1] https://t.me/joinchat/B-szpERIwOCjY_97ehftHA
[2] https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-design
[3] https://meet.jit.si/LibreOfficeDesign

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4-3' - vcl/source

[Stephan Bergmann]

 vcl/source/filter/jpeg/jpegc.cxx |  607 ---
 1 file changed, 321 insertions(+), 286 deletions(-)

New commits:
commit b6c4cdf639d338e713443d4c8d8a665901e8be07
Author: Stephan Bergmann 
Date:   Wed Oct 18 13:02:28 2017 +0200

Avoid throwing C++ exception across libjpeg C frames

It causes trouble at least for (non-debug) 32-bit ARM Flatpak builds, where
CppunitTest_vcl_filters_test aborts with an uncaught 
css::uno::RuntimeException.

This is a partial revert of 6889fa826eef6bd1074d77507818e71dfe8ba152 "rework
jpeg error handling to throw rather than setjmp to avoid leaks", switching 
back
to setjmp/longjmp but trying to keep the leaks fixed by introducing any 
relevant
local variables before the setjmps.

Change-Id: Ia5984528ea98be1c89a21aee800b247120f88a89
Reviewed-on: https://gerrit.libreoffice.org/43494
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 
(cherry picked from commit cfbb8b5090537e79ba70e250ddee86d53facbe15)
Reviewed-on: https://gerrit.libreoffice.org/43535
Reviewed-by: Michael Stahl 
Tested-by: Rene Engelhard 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/source/filter/jpeg/jpegc.cxx b/vcl/source/filter/jpeg/jpegc.cxx
index 4305f065ed54..86dd30b71c7e 100644
--- a/vcl/source/filter/jpeg/jpegc.cxx
+++ b/vcl/source/filter/jpeg/jpegc.cxx
@@ -21,6 +21,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -37,12 +38,28 @@ extern "C" {
 #include 
 #include 
 
+#ifdef _MSC_VER
+#pragma warning(push, 1) /* disable to __declspec(align()) aligned warning */
+#pragma warning (disable: 4324)
+#endif
+
+struct ErrorManagerStruct
+{
+jpeg_error_mgr pub;
+jmp_buf setjmp_buffer;
+};
+
+#ifdef _MSC_VER
+#pragma warning(pop)
+#endif
+
 extern "C" void errorExit (j_common_ptr cinfo)
 {
 char buffer[JMSG_LENGTH_MAX];
 (*cinfo->err->format_message) (cinfo, buffer);
 SAL_WARN("vcl.filter", "fatal failure reading JPEG: " << buffer);
-throw css::uno::RuntimeException(OUString(buffer, strlen(buffer), 
RTL_TEXTENCODING_ASCII_US));
+ErrorManagerStruct * error = reinterpret_cast(cinfo->err);
+longjmp(error->setjmp_buffer, 1);
 }
 
 extern "C" void outputMessage (j_common_ptr cinfo)
@@ -55,226 +72,239 @@ extern "C" void outputMessage (j_common_ptr cinfo)
 class JpegDecompressOwner
 {
 public:
-JpegDecompressOwner(jpeg_decompress_struct ) : m_cinfo(cinfo)
+void set(jpeg_decompress_struct *cinfo)
 {
+m_cinfo = cinfo;
 }
 ~JpegDecompressOwner()
 {
-jpeg_destroy_decompress(_cinfo);
+if (m_cinfo != nullptr)
+{
+jpeg_destroy_decompress(m_cinfo);
+}
 }
 private:
-jpeg_decompress_struct _cinfo;
+jpeg_decompress_struct *m_cinfo = nullptr;
 };
 
 class JpegCompressOwner
 {
 public:
-JpegCompressOwner(jpeg_compress_struct ) : m_cinfo(cinfo)
+void set(jpeg_compress_struct *cinfo)
 {
+m_cinfo = cinfo;
 }
 ~JpegCompressOwner()
 {
-jpeg_destroy_compress(_cinfo);
+if (m_cinfo != nullptr)
+{
+jpeg_destroy_compress(m_cinfo);
+}
 }
 private:
-jpeg_compress_struct _cinfo;
+jpeg_compress_struct *m_cinfo = nullptr;
 };
 
 void ReadJPEG( JPEGReader* pJPEGReader, void* pInputStream, long* pLines,
Size const & previewSize, GraphicFilterImportFlags nImportFlags,
Bitmap::ScopedWriteAccess* ppAccess )
 {
-try
+jpeg_decompress_struct cinfo;
+ErrorManagerStruct jerr;
+
+JpegDecompressOwner aOwner;
+std::unique_ptr pScopedAccess;
+std::vector pScanLineBuffer;
+std::vector pCYMKBuffer;
+
+if ( setjmp( jerr.setjmp_buffer ) )
+{
+return;
+}
+
+cinfo.err = jpeg_std_error(  );
+jerr.pub.error_exit = errorExit;
+jerr.pub.output_message = outputMessage;
+
+jpeg_create_decompress(  );
+aOwner.set();
+jpeg_svstream_src( , pInputStream );
+SourceManagerStruct *source = 
reinterpret_cast(cinfo.src);
+jpeg_read_header( , TRUE );
+
+cinfo.scale_num = 1;
+cinfo.scale_denom = 1;
+cinfo.output_gamma = 1.0;
+cinfo.raw_data_out = FALSE;
+cinfo.quantize_colors = FALSE;
+
+/* change scale for preview import */
+long nPreviewWidth = previewSize.Width();
+long nPreviewHeight = previewSize.Height();
+if( nPreviewWidth || nPreviewHeight )
 {
-jpeg_decompress_struct cinfo;
-jpeg_error_mgr jerr;
-
-cinfo.err = jpeg_std_error(  );
-jerr.error_exit = errorExit;
-jerr.output_message = outputMessage;
-
-jpeg_create_decompress(  );
-JpegDecompressOwner aOwner(cinfo);
-jpeg_svstream_src( , pInputStream );
-SourceManagerStruct *source = 

[Libreoffice-commits] core.git: include/sal vcl/inc vcl/unx

[Jan-Marek Glogowski]

 include/sal/log-areas.dox |1 
 vcl/inc/unx/gendata.hxx   |3 
 vcl/inc/unx/tde/tdedata.hxx   |  114 --
 vcl/inc/vclpluginapi.h|   12 ---
 vcl/unx/generic/plugadapt/salplug.cxx |   14 
 5 files changed, 3 insertions(+), 141 deletions(-)

New commits:
commit 4805a3a8b6d2e9cc1710b9dced2041a6c7b5e596
Author: Jan-Marek Glogowski 
Date:   Fri Oct 27 10:29:14 2017 +0200

Remove some old KDE3 and TDE stuff

Both VCL plugins are long gone.
We currently just keep the desktop detection.
Generally fall back to gtk in VCL detection.

Change-Id: I35830868cb75d16ae7b90b20df699929cefa4636
Reviewed-on: https://gerrit.libreoffice.org/43940
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/include/sal/log-areas.dox b/include/sal/log-areas.dox
index 3f0aa406d6da..ab762e81dd50 100644
--- a/include/sal/log-areas.dox
+++ b/include/sal/log-areas.dox
@@ -456,7 +456,6 @@ certain functionality.
 @li @c vcl.headless - bitmap-based backend
 @li @c vcl.helper
 @li @c vcl.icontest
-@li @c vcl.kde - KDE
 @li @c vcl.kde4 - KDE4
 @li @c vcl.kde5 - KDE5
 @li @c vcl.layout - Widget layout
diff --git a/vcl/inc/unx/gendata.hxx b/vcl/inc/unx/gendata.hxx
index 4088985678a6..fda6680a962a 100644
--- a/vcl/inc/unx/gendata.hxx
+++ b/vcl/inc/unx/gendata.hxx
@@ -20,8 +20,7 @@ class SalGenericDisplay;
 namespace psp { class PrintFontManager; }
 
 enum GenericUnixSalDataType { SAL_DATA_GTK, SAL_DATA_GTK3,
-  SAL_DATA_TDE3,
-  SAL_DATA_KDE3,SAL_DATA_KDE4, SAL_DATA_KDE5,
+  SAL_DATA_KDE4, SAL_DATA_KDE5,
   SAL_DATA_UNX, SAL_DATA_SVP,
   SAL_DATA_ANDROID, SAL_DATA_IOS,
   SAL_DATA_HEADLESS };
diff --git a/vcl/inc/unx/tde/tdedata.hxx b/vcl/inc/unx/tde/tdedata.hxx
deleted file mode 100644
index d8f1363f2f95..
--- a/vcl/inc/unx/tde/tdedata.hxx
+++ /dev/null
@@ -1,114 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- *
- * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
- *
- * Copyright 2000, 2010 Oracle and/or its affiliates.
- * Copyright 2012 Timothy Pearson
- *
- * OpenOffice.org - a multi-platform office productivity suite
- *
- * This file is part of OpenOffice.org.
- *
- * OpenOffice.org is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License version 3
- * only, as published by the Free Software Foundation.
- *
- * OpenOffice.org is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Lesser General Public License version 3 for more details
- * (a copy is included in the LICENSE file that accompanied this code).
- *
- * You should have received a copy of the GNU Lesser General Public License
- * version 3 along with OpenOffice.org.  If not, see
- * 
- * for a copy of the LGPLv3 License.
- *
- /
-
-#ifndef INCLUDED_VCL_INC_UNX_TDE_TDEDATA_HXX
-#define INCLUDED_VCL_INC_UNX_TDE_TDEDATA_HXX
-
-#include 
-#include 
-#include 
-
-class TDEData : public X11SalData
-{
-public:
-TDEData( SalInstance *pInstance ) : X11SalData( SAL_DATA_TDE, pInstance ) 
{}
-virtual ~TDEData();
-
-virtual void Init();
-virtual void initNWF();
-virtual void deInitNWF();
-};
-
-class SalTDEDisplay : public SalX11Display
-{
-public:
-SalTDEDisplay( Display* pDisp );
-virtual ~SalTDEDisplay();
-};
-
-class TDESalFrame : public X11SalFrame
-{
-static const int nMaxGraphics = 2;
-
-struct GraphicsHolder
-{
-X11SalGraphics* pGraphics;
-boolbInUse;
-GraphicsHolder()
-: pGraphics( NULL ),
-  bInUse( false )
-{}
-~GraphicsHolder();
-};
-GraphicsHolder m_aGraphics[ nMaxGraphics ];
-
-public:
-TDESalFrame( SalFrame* pParent, SalFrameStyleFlags );
-virtual ~TDESalFrame();
-
-virtual SalGraphics* AcquireGraphics();
-virtual void ReleaseGraphics( SalGraphics *pGraphics );
-virtual void updateGraphics( bool bClear );
-virtual void UpdateSettings( AllSettings& rSettings );
-virtual void Show( bool bVisible, bool bNoActivate );
-};
-
-class TDESalInstance : public X11SalInstance
-{
-public:
-TDESalInstance( SalYieldMutex* pMutex )
-: X11SalInstance( pMutex ) {}
-virtual ~TDESalInstance() {}
-virtual SalFrame* CreateFrame( SalFrame* pParent, 

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sc/source

[Eike Rathke]

 sc/source/filter/qpro/qproform.cxx |   14 +-
 1 file changed, 13 insertions(+), 1 deletion(-)

New commits:
commit d78b60fc7b7acb6675afe077968cd23586092c96
Author: Eike Rathke 
Date:   Fri Oct 27 11:39:39 2017 +0200

ofz#2947 check for input stream end

Change-Id: I48d43a358e9a8e37a3c862c310a2e4b2e756f536
Reviewed-on: https://gerrit.libreoffice.org/43937
Reviewed-by: Eike Rathke 
Tested-by: Jenkins 
(cherry picked from commit b53974c1530d14eebdc561ada3ecaf8fc3b58929)
Reviewed-on: https://gerrit.libreoffice.org/43946
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/filter/qpro/qproform.cxx 
b/sc/source/filter/qpro/qproform.cxx
index 4ec3f386a338..0726f48d52e3 100644
--- a/sc/source/filter/qpro/qproform.cxx
+++ b/sc/source/filter/qpro/qproform.cxx
@@ -172,6 +172,14 @@ do { \
 nRef-=amt; \
 } while(false)
 
+#define SAFEREAD_OR_BREAK( aStream, i, nRef, eRet, ret ) \
+if (!aStream.good()) \
+{ \
+i = nRef-1; /* will be incremented at end of while */ \
+eRet = ret; \
+break;  /* switch */ \
+}
+
 ConvErr QProToSc::Convert( const ScTokenArray*& pArray )
 {
 sal_uInt8 nFmla[ nBufSize ], nArg;
@@ -245,6 +253,7 @@ ConvErr QProToSc::Convert( const ScTokenArray*& pArray )
 nDLLCount = 0;
 nArgCount = 0;
 nStringCount = 0;
+ConvErr eRet = ConvErr::OK;
 
 while( i < nRef && ( nFmla[ i ] != 0x03 ) )
 {
@@ -298,14 +307,17 @@ ConvErr QProToSc::Convert( const ScTokenArray*& pArray )
 
 case FT_Cref : // Single cell reference
 maIn.ReadUInt16( nNote ).ReadSChar( nCol ).ReadSChar( nPage 
).ReadUInt16( nRelBits );
+SAFEREAD_OR_BREAK( maIn, i, nRef, eRet, ConvErr::Count);
 ReadSRD( aSRD, nPage, nCol, nRelBits );
 aStack << aPool.Store( aSRD );
 break;
 
 case FT_Range: // Block reference
 maIn.ReadUInt16( nNote ).ReadSChar( nCol ).ReadSChar( nPage 
).ReadUInt16( nRelBits );
+SAFEREAD_OR_BREAK( maIn, i, nRef, eRet, ConvErr::Count);
 ReadSRD( aCRD.Ref1, nPage, nCol, nRelBits );
 maIn.ReadSChar( nCol ).ReadSChar( nPage ).ReadUInt16( nRelBits 
);
+SAFEREAD_OR_BREAK( maIn, i, nRef, eRet, ConvErr::Count);
 ReadSRD( aCRD.Ref2, nPage, nCol, nRelBits );
 // Sheet name of second corner is not displayed if identical
 if (aCRD.Ref1.IsFlag3D() && aCRD.Ref1.Tab() == aCRD.Ref2.Tab() 
&&
@@ -368,7 +380,7 @@ ConvErr QProToSc::Convert( const ScTokenArray*& pArray )
 i++;
 }
 pArray = aPool[ aStack.Get() ];
-return ConvErr::OK;
+return eRet;
 }
 
 static const struct
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svx/source

[Caolán McNamara]

 svx/source/xoutdev/xtabcolr.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 5922f9af749ff53e3bda2ff60a52116bf999a8a0
Author: Caolán McNamara 
Date:   Fri Oct 27 16:43:29 2017 +0100

survive without config

Change-Id: I410e486acc206ae2981fd16a9e2780dbd4d27af5

diff --git a/svx/source/xoutdev/xtabcolr.cxx b/svx/source/xoutdev/xtabcolr.cxx
index 04376c564dff..0a148eb1b084 100644
--- a/svx/source/xoutdev/xtabcolr.cxx
+++ b/svx/source/xoutdev/xtabcolr.cxx
@@ -19,6 +19,7 @@
 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -34,7 +35,9 @@ XColorListRef XColorList::CreateStdColorList()
 {
 return XPropertyList::AsColorList(
 XPropertyList::CreatePropertyList(
-XPropertyListType::Color, SvtPathOptions().GetPalettePath(), ""));
+XPropertyListType::Color, !utl::ConfigManager::IsAvoidConfig() ?
+  SvtPathOptions().GetPalettePath() :
+  "", ""));
 }
 
 XColorListRef XColorList::GetStdColorList()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83946

Yousuf Philips (jay)  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: tools/source

[Caolán McNamara]

 tools/source/generic/poly.cxx |   38 +-
 1 file changed, 29 insertions(+), 9 deletions(-)

New commits:
commit 3e2df29c520a7bc0c2cc4b37d42fb9bcd52da60f
Author: Caolán McNamara 
Date:   Fri Oct 27 14:52:49 2017 +0100

ofz#3791 Integer-overflow

Change-Id: I0b8258eaf676ee7291365aec10a7876833aba626
Reviewed-on: https://gerrit.libreoffice.org/43947
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/tools/source/generic/poly.cxx b/tools/source/generic/poly.cxx
index e7b9397ab734..c44c5ecf7b69 100644
--- a/tools/source/generic/poly.cxx
+++ b/tools/source/generic/poly.cxx
@@ -27,6 +27,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -628,12 +629,22 @@ Polygon::Polygon( const Point& rCenter, long nRadX, long 
nRadY )
 {
 if( nRadX && nRadY )
 {
-sal_uInt16 nPoints = 0;
+sal_uInt16 nPoints;
+
 // Compute default (depends on size)
-nPoints = (sal_uInt16) MinMax(
-( F_PI * ( 1.5 * ( nRadX + nRadY ) -
-   sqrt( (double) labs( nRadX * nRadY ) ) ) ),
-32, 256 );
+long nRadXY;
+const bool bOverflow = o3tl::checked_multiply(nRadX, nRadY, nRadXY);
+if (!bOverflow)
+{
+nPoints = (sal_uInt16) MinMax(
+( F_PI * ( 1.5 * ( nRadX + nRadY ) -
+   sqrt( (double) labs(nRadXY) ) ) ),
+32, 256 );
+}
+else
+{
+nPoints = 256;
+}
 
 if( ( nRadX > 32 ) && ( nRadY > 32 ) && ( nRadX + nRadY ) < 8192 )
 nPoints >>= 1;
@@ -683,10 +694,19 @@ Polygon::Polygon( const tools::Rectangle& rBound, const 
Point& rStart, const Poi
 const long  nRadY = aCenter.Y() - rBound.Top();
 sal_uInt16  nPoints;
 
-nPoints = (sal_uInt16) MinMax(
-( F_PI * ( 1.5 * ( nRadX + nRadY ) -
-   sqrt( (double) labs( nRadX * nRadY ) ) ) ),
-32, 256 );
+long nRadXY;
+const bool bOverflow = o3tl::checked_multiply(nRadX, nRadY, nRadXY);
+if (!bOverflow)
+{
+nPoints = (sal_uInt16) MinMax(
+( F_PI * ( 1.5 * ( nRadX + nRadY ) -
+   sqrt( (double) labs(nRadXY) ) ) ),
+32, 256 );
+}
+else
+{
+nPoints = 256;
+}
 
 if( ( nRadX > 32 ) && ( nRadY > 32 ) && ( nRadX + nRadY ) < 8192 )
 nPoints >>= 1;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

dumpAsXml

[Yemelyanenko Fyodor]

Hello!

During work on bug https://bugs.documentfoundation.org/show_bug.cgi?id=108124 I 
found dumpAsXml methods in different classes (i.e. SwNode, SwNodes, SwDoc, 
SwPaM, SwPosition, etc.)
I've created separate function which creates XML writer, calls dumpAsXml from 
some class and outputs result to debugger output. This is useful, as I can call 
such function from debugger (using .call in WinDbg) and immediately get class 
contents as xml (i.e SwNodes as xml). This function accepts only one parameter 
- pointer to class. Such pointer can be found in locals window in debugger. So 
dumping any class to debug output become easy and quick task, without rewriting 
and recompiling code.

The code itself is at the end of this message (this is draft code, written 
quickly).

I can make this code better (add cross-platform'ness as it depends on 
OutputDebugStringA and I'm not sure that it exists in any other OS than 
Windows), and submit as patch to master. Also I can add several lines here on 
how to use my function to get xml dump during debugging 
https://wiki.documentfoundation.org/Development/How_to_debug#Debugging_options

If all this makes sense and can be useful not only for me?

 Dumper function code 


 template 
void DumpXmlToDebug(ClassWithDumpAsXml& tDumpedToDebug)
{

xmlDocPtr doc;
xmlChar *xmlbuff;
int buffersize;

xmlTextWriterPtr xmlWrt = xmlNewTextWriterDoc(, 0);
assert(xmlWrt);

if (xmlTextWriterStartDocument(xmlWrt, NULL, "ISO-8859-1", NULL) < 0)
OutputDebugStringA("\n\nerror in xmlTextWriterStartDocument \n\n");

tDumpedToDebug.dumpAsXml(xmlWrt);

if (xmlTextWriterEndDocument(xmlWrt) < 0)
OutputDebugStringA("\n\nerror in xmlTextWriterEndDocument \n\n");

xmlDocDumpFormatMemory(doc, , , 1);

std::stringstream dbg;
dbg << "\n !! !!!\n !! Called for " << 
typeid(ClassWithDumpAsXml).name() << " !!\n " << (char *)xmlbuff << "\n\n\n";

OutputDebugStringA(dbg.str().c_str());

xmlFreeTextWriter(xmlWrt);
xmlFree(xmlbuff);
xmlFreeDoc(doc);
}


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: wizards/source

[Jean-Pierre Ledure]

 wizards/source/access2base/Database.xba |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 64cfc7de655ac302138553f9fc2b9de437e0353c
Author: Jean-Pierre Ledure 
Date:   Fri Oct 27 17:25:04 2017 +0200

Access2Base - Database events (2)

diff --git a/wizards/source/access2base/Database.xba 
b/wizards/source/access2base/Database.xba
index cdf26aa14bab..e3dba90c9ac6 100644
--- a/wizards/source/access2base/Database.xba
+++ b/wizards/source/access2base/Database.xba
@@ -1798,7 +1798,10 @@ Dim i As Integer, vEvents As Variant, sEvent As String, 
vEvent As Variant
sEvent = 
vEvents = Document.getEvents().ElementNames 
  Returns an array
For i = 0 To UBound(vEvents)
-   If UCase(vEvents(i)) = UCase(psProperty) Then 
sEvent = vEvents(i)
+   If UCase(vEvents(i)) = UCase(psProperty) Then
+   sEvent = vEvents(i)
+   Exit For
+   End If
Next i
If sEvent =  Then
_PropertyGet = 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 103317] New default set of templates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103317

--- Comment #9 from Heiko Tietze  ---
(In reply to Laurent BP from comment #8)
> Why removing LushGreen and Pencil template?

To clean up before adding new stuff. 

> ...remove language specific items. So each template is open in the language of
> user. See bug 107027
> 
> Update of Vintage template seem to have broken it.

Unlike for the other two that I recreated because of the localization, I didn't
touch Vintage, except image size and font name. Don't see an issue with the
language there, what exactly would you change?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: filter/source

[Caolán McNamara]

 filter/source/graphicfilter/ieps/ieps.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ac31598662c280ef99f305f6ca8ddc0be96ede06
Author: Caolán McNamara 
Date:   Fri Oct 27 13:34:46 2017 +0100

ofz#3837 Integer-overflow

Change-Id: Iaf9573ba7a8c08ba8c1b8dcf62340d0ea213e1a9
Reviewed-on: https://gerrit.libreoffice.org/43944
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/filter/source/graphicfilter/ieps/ieps.cxx 
b/filter/source/graphicfilter/ieps/ieps.cxx
index 4d6001cd9538..6d5c41cba7d8 100644
--- a/filter/source/graphicfilter/ieps/ieps.cxx
+++ b/filter/source/graphicfilter/ieps/ieps.cxx
@@ -766,7 +766,7 @@ ipsGraphicImport( SvStream & rStream, Graphic & rGraphic, 
FilterConfigItem* )
 bFail = o3tl::checked_sub(nNumb[2], nNumb[0], nWidth) || 
o3tl::checked_add(nWidth, 1L, nWidth);
 if (!bFail)
 bFail = o3tl::checked_sub(nNumb[3], nNumb[1], nHeight) || 
o3tl::checked_add(nWidth, 1L, nHeight);
-if (!bFail)
+if (!bFail && nWidth > 0 && nHeight > 0)
 {
 GDIMetaFile aMtf;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 103317] New default set of templates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103317

Laurent BP  changed:

   What|Removed |Added

 CC||jumbo4...@yahoo.fr

--- Comment #8 from Laurent BP  ---
Hello,

Why removing LushGreen and Pencil template?
Commit
https://cgit.freedesktop.org/libreoffice/core/commit/extras/source/templates/presnt?id=59cf94fac8e53d7f098eb2fbdf59d3a6aff254ce
updated templates to remove language specific items. So each template is open
in the language of user. See bug 107027

Update of Vintage template seem to have broken it.

Commit
https://cgit.freedesktop.org/libreoffice/core/commit/extras/source/templates/presnt?id=5c16d16ed3db32f922b2aeaad49592d2615c7e2c
modify preview image with "Lorem ipsum" text. See bug 107045. Shall we revert
it or do the same for the new templates?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 113468] Sudden High CPU Usage by "Idle" LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113468

--- Comment #6 from Alex Thurgood  ---
@Jon : to collect debug information you need a debug build. As far as I know,
none are being provided at the current time in the daily builds made available
for LibreOffice on OSX.

The only other way to obtain useful debug information is to build LO yourself
from source.

I suppose theoretically, you could try analysing a normal build in
Instruments.app (part of the XCode package) with a time profile trace or a core
profile trace, although without symbols and debug code, the results are
probably going to be a bit limited.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113468] Sudden High CPU Usage by "Idle" LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113468

--- Comment #5 from Alex Thurgood  ---
@Jon : seems to me that at least some of what you describe here, and equally in
bug 113467, has already been referenced in the See Also bugs I've added to this
report.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113468] Sudden High CPU Usage by "Idle" LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113468

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||7113

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs