[Libreoffice-commits] core.git: compilerplugins/clang

2017-11-09 Thread Stephan Bergmann
 compilerplugins/clang/unnecessaryoverride.cxx |2 --
 1 file changed, 2 deletions(-)

New commits:
commit d4ee66c15e8c57f2de54d1306128f6546dfb6e8d
Author: Stephan Bergmann 
Date:   Fri Nov 10 08:51:43 2017 +0100

No need to check both (identical) param_size() and getNumParams()

Change-Id: I481cfa8b0f4bb9cbc257d28f36c372fb7367f294

diff --git a/compilerplugins/clang/unnecessaryoverride.cxx 
b/compilerplugins/clang/unnecessaryoverride.cxx
index eb3dabb26f60..7a0431a2bf44 100644
--- a/compilerplugins/clang/unnecessaryoverride.cxx
+++ b/compilerplugins/clang/unnecessaryoverride.cxx
@@ -410,8 +410,6 @@ const CXXMethodDecl* 
UnnecessaryOverride::findOverriddenOrSimilarMethodInSupercl
 {
 continue;
 }
-if (methodDecl->param_size() != baseMethod->param_size())
-continue;
 if (methodDecl->getNumParams() != baseMethod->getNumParams())
 continue;
 bool bParamsMatch = true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 104870] crash when opening odp/ppt/ pps file from mail + ask slideshow (if not pps) then select Slide Sorter

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104870

--- Comment #28 from petitlou60  ---
Bug is again present in LO 5.4.3.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: wsd/FileServer.cpp

2017-11-09 Thread Pranav Kant
 wsd/FileServer.cpp |   26 +++---
 1 file changed, 3 insertions(+), 23 deletions(-)

New commits:
commit 768b0c040493ef983fba683a677ca3baad3b792f
Author: Pranav Kant 
Date:   Fri Nov 10 12:35:34 2017 +0530

Bin some duplicate 404 handling

Change-Id: Ibf3ed6c5558492b122662f25f31d321a6bbc151c

diff --git a/wsd/FileServer.cpp b/wsd/FileServer.cpp
index 2fa659c2..a0e74a2c 100644
--- a/wsd/FileServer.cpp
+++ b/wsd/FileServer.cpp
@@ -164,10 +164,10 @@ void FileServerRequestHandler::handleRequest(const 
HTTPRequest& request, Poco::M
 
 std::vector requestSegments;
 requestUri.getPathSegments(requestSegments);
-if (requestSegments.size() < 1)
-{
+const std::string relPath = getRequestPathname(request);
+// Is this a file we read at startup - if not; its not for serving.
+if (requestSegments.size() < 1 || FileHash.find(relPath) == 
FileHash.end())
 throw Poco::FileNotFoundException("Invalid URI request: [" + 
requestUri.toString() + "].");
-}
 
 const auto& config = Application::instance().config();
 const std::string loleafletHtml = config.getString("loleaflet_html", 
"loleaflet.html");
@@ -195,11 +195,6 @@ void FileServerRequestHandler::handleRequest(const 
HTTPRequest& request, Poco::M
 response.add("Referrer-Policy", "no-referrer");
 }
 
-const std::string relPath = getRequestPathname(request);
-// Is this a file we read at startup - if not; its not for serving.
-if (FileHash.find(relPath) == FileHash.end())
-throw Poco::FileAccessDeniedException("Invalid or forbidden 
file path: [" + relPath + "].");
-
 // Do we have an extension.
 const std::size_t extPoint = endPoint.find_last_of('.');
 if (extPoint == std::string::npos)
@@ -441,21 +436,6 @@ void FileServerRequestHandler::preprocessFile(const 
HTTPRequest& request, Poco::
 // Is this a file we read at startup - if not; its not for serving.
 const std::string relPath = getRequestPathname(request);
 LOG_DBG("Preprocessing file: " << relPath);
-if (FileHash.find(relPath) == FileHash.end())
-{
-LOG_ERR("File [" << relPath << "] does not exist.");
-
-// 404 not found
-std::ostringstream oss;
-oss << "HTTP/1.1 404\r\n"
-<< "Date: " << Poco::DateTimeFormatter::format(Poco::Timestamp(), 
Poco::DateTimeFormat::HTTP_FORMAT) << "\r\n"
-<< "User-Agent: " << WOPI_AGENT_STRING << "\r\n"
-<< "Content-Length: 0\r\n"
-<< "\r\n";
-socket->send(oss.str());
-return;
-}
-
 std::string preprocess = *getUncompressedFile(relPath);
 
 HTMLForm form(request, message);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: Running unit test by make

2017-11-09 Thread Zolnai Tamás
2017-11-10 7:44 GMT+01:00 Noel Grandin :

> if you don't want to run the tests you can do
>
>  make .build
> ​
>

Great, but then what is simple make for?
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] online.git: loleaflet/dist

2017-11-09 Thread Pranav Kant
 loleaflet/dist/loleaflet.html |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 377faf397191cc3ae1e247431bd8b7faa7dc9b8b
Author: Pranav Kant 
Date:   Fri Nov 10 12:25:04 2017 +0530

loleaflet: Disable selecting  element

Change-Id: I13a6fc949a9b419a0669a8c8fe608f9564991eb9

diff --git a/loleaflet/dist/loleaflet.html b/loleaflet/dist/loleaflet.html
index 13e60e54..1bc8072c 100644
--- a/loleaflet/dist/loleaflet.html
+++ b/loleaflet/dist/loleaflet.html
@@ -23,7 +23,7 @@
 
 
 
-  
+  
 

[Libreoffice-bugs] [Bug 113498] UI Wayland Calc pulldown font menu highlighted selection is four lines below cursor

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113498

--- Comment #1 from Roger T. Imai  ---
Appears to have been FIXED recently, but don't know what components were
updated, possibly not even Calc but some other component. THANK YOU!

Current Calc version:
Version: 5.2.7.2
Build ID: 1:5.2.7-1
CPU Threads: 4; OS Version: Linux 4.9; UI Render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: i18nlangtag/source include/i18nlangtag

2017-11-09 Thread Jochen Nitschke
 i18nlangtag/source/languagetag/languagetag.cxx |   32 -
 include/i18nlangtag/languagetag.hxx|2 -
 2 files changed, 34 deletions(-)

New commits:
commit d12699bab3eab6e29f0667f042148e5634c9efe4
Author: Jochen Nitschke 
Date:   Thu Nov 9 21:01:51 2017 +0100

clang-tidy modernize-use-equals-default LanguageTag

mbIsFallback was added to ctor but not to copy assignment in
commit 258d9fac7544f925c8250bad99b9554cc49578d5
CID#1103756 missing initialization

Change-Id: I91ee5daf68c3c3682b5d7007c028eaf3579a0715
Reviewed-on: https://gerrit.libreoffice.org/44563
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/i18nlangtag/source/languagetag/languagetag.cxx 
b/i18nlangtag/source/languagetag/languagetag.cxx
index 3f887de7d6c1..28842ccace6d 100644
--- a/i18nlangtag/source/languagetag/languagetag.cxx
+++ b/i18nlangtag/source/languagetag/languagetag.cxx
@@ -561,38 +561,6 @@ LanguageTag::LanguageTag( const rtl_Locale & rLocale )
 }
 
 
-LanguageTag::LanguageTag( const LanguageTag & rLanguageTag )
-:
-maLocale( rLanguageTag.maLocale),
-maBcp47( rLanguageTag.maBcp47),
-mnLangID( rLanguageTag.mnLangID),
-mpImpl( rLanguageTag.mpImpl),
-mbSystemLocale( rLanguageTag.mbSystemLocale),
-mbInitializedBcp47( rLanguageTag.mbInitializedBcp47),
-mbInitializedLocale( rLanguageTag.mbInitializedLocale),
-mbInitializedLangID( rLanguageTag.mbInitializedLangID),
-mbIsFallback(rLanguageTag.mbIsFallback)
-{
-}
-
-
-LanguageTag& LanguageTag::operator=( const LanguageTag & rLanguageTag )
-{
-if ( == this)
-return *this;
-
-maLocale= rLanguageTag.maLocale;
-maBcp47 = rLanguageTag.maBcp47;
-mnLangID= rLanguageTag.mnLangID;
-mpImpl  = rLanguageTag.mpImpl;
-mbSystemLocale  = rLanguageTag.mbSystemLocale;
-mbInitializedBcp47  = rLanguageTag.mbInitializedBcp47;
-mbInitializedLocale = rLanguageTag.mbInitializedLocale;
-mbInitializedLangID = rLanguageTag.mbInitializedLangID;
-return *this;
-}
-
-
 LanguageTag::~LanguageTag()
 {
 }
diff --git a/include/i18nlangtag/languagetag.hxx 
b/include/i18nlangtag/languagetag.hxx
index 42da7cc88179..a9937205ef8c 100644
--- a/include/i18nlangtag/languagetag.hxx
+++ b/include/i18nlangtag/languagetag.hxx
@@ -107,9 +107,7 @@ public:
  */
 explicit LanguageTag( const rtl_Locale & rLocale );
 
-LanguageTag( const LanguageTag & rLanguageTag );
 ~LanguageTag();
-LanguageTag& operator=( const LanguageTag & rLanguageTag );
 
 /** Obtain BCP 47 language tag.
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: accessibility/inc avmedia/source

2017-11-09 Thread Noel Grandin
 accessibility/inc/extended/AccessibleBrowseBoxHeaderBar.hxx  |6 ++--
 accessibility/inc/extended/AccessibleGridControl.hxx |7 +
 accessibility/inc/extended/AccessibleGridControlHeader.hxx   |6 ++--
 accessibility/inc/extended/AccessibleGridControlTable.hxx|7 ++---
 accessibility/inc/extended/accessibleeditbrowseboxcell.hxx   |6 +---
 accessibility/inc/extended/accessibleiconchoicectrl.hxx  |6 +---
 accessibility/inc/extended/accessibleiconchoicectrlentry.hxx |   10 ++-
 accessibility/inc/extended/accessiblelistbox.hxx |   14 --
 accessibility/inc/extended/accessiblelistboxentry.hxx|   15 ---
 accessibility/inc/extended/accessibletabbar.hxx  |4 --
 accessibility/inc/extended/accessibletabbarpagelist.hxx  |3 --
 accessibility/inc/standard/vclxaccessiblecheckbox.hxx|3 --
 accessibility/inc/standard/vclxaccessiblelist.hxx|7 +
 accessibility/inc/standard/vclxaccessiblelistitem.hxx|4 --
 accessibility/inc/standard/vclxaccessiblemenubar.hxx |3 --
 accessibility/inc/standard/vclxaccessibletabcontrol.hxx  |3 --
 accessibility/inc/standard/vclxaccessibletabpage.hxx |3 --
 accessibility/inc/standard/vclxaccessibletoolbox.hxx |3 --
 avmedia/source/gstreamer/gstplayer.hxx   |4 +-
 19 files changed, 42 insertions(+), 72 deletions(-)

New commits:
commit 19ee7861938b59085a50699a51e2f149e49a24e4
Author: Noel Grandin 
Date:   Tue Nov 7 15:29:54 2017 +0200

loplugin:finalclasses in accessibility

Change-Id: I9d8bc018dfe8bd8668d28daccd85ea5770fe31b0
Reviewed-on: https://gerrit.libreoffice.org/44537
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/accessibility/inc/extended/AccessibleBrowseBoxHeaderBar.hxx 
b/accessibility/inc/extended/AccessibleBrowseBoxHeaderBar.hxx
index c7bcacaec9a3..03a00d38725e 100644
--- a/accessibility/inc/extended/AccessibleBrowseBoxHeaderBar.hxx
+++ b/accessibility/inc/extended/AccessibleBrowseBoxHeaderBar.hxx
@@ -36,7 +36,7 @@ typedef ::cppu::ImplHelper1< 
css::accessibility::XAccessibleSelection >
 control (row or column header bar). This object supports the
 XAccessibleSelection interface. Selecting a child of this object selects
 complete rows or columns of the data table. */
-class AccessibleBrowseBoxHeaderBar :
+class AccessibleBrowseBoxHeaderBar final :
 public AccessibleBrowseBoxTableBase,
 public AccessibleBrowseBoxHeaderBarImplHelper
 {
@@ -50,7 +50,7 @@ public:
 ::svt::IAccessibleTableProvider& rBrowseBox,
 ::svt::AccessibleBrowseBoxObjType eObjType );
 
-protected:
+private:
 virtual ~AccessibleBrowseBoxHeaderBar() override;
 
 public:
@@ -157,7 +157,7 @@ public:
 /** @return  An unique implementation ID. */
 virtual css::uno::Sequence< sal_Int8 > SAL_CALL getImplementationId() 
override;
 
-protected:
+private:
 // internal virtual methods
 
 /** @attention  This method requires locked mutex's and a living object.
diff --git a/accessibility/inc/extended/AccessibleGridControl.hxx 
b/accessibility/inc/extended/AccessibleGridControl.hxx
index 438315acb7c9..d4cf435590a8 100644
--- a/accessibility/inc/extended/AccessibleGridControl.hxx
+++ b/accessibility/inc/extended/AccessibleGridControl.hxx
@@ -33,11 +33,10 @@ namespace accessibility {
 
 
 /** This class represents the complete accessible Grid Control object. */
-class AccessibleGridControl : public AccessibleGridControlBase
+class AccessibleGridControl final : public AccessibleGridControlBase
 {
 friend class AccessibleGridControlAccess;
 
-protected:
 AccessibleGridControl(
 const css::uno::Reference< css::accessibility::XAccessible >& 
_rxParent,
 const css::uno::Reference< css::accessibility::XAccessible >& 
_rxCreator,
@@ -50,7 +49,6 @@ protected:
 using AccessibleGridControlBase::disposing;
 virtual void SAL_CALL disposing() override;
 
-protected:
 // XAccessibleContext -
 
 /** @return  The count of visible children. */
@@ -106,7 +104,7 @@ public:
  void commitTableEvent(sal_Int16 nEventId, const css::uno::Any& rNewValue,
  const css::uno::Any& rOldValue);
 
-protected:
+private:
 // internal virtual methods ---
 
 /** @attention  This method requires locked mutex's and a living object.
@@ -140,7 +138,6 @@ protected:
 @return  An AccessibleGridControlTable. */
 AccessibleGridControlTable* createAccessibleTable();
 
-private:
 // members 
 std::unique_ptr< AccessibleGridControl_Impl > m_xImpl;
 };
diff --git a/accessibility/inc/extended/AccessibleGridControlHeader.hxx 

[Libreoffice-commits] core.git: 2 commits - basic/inc basic/source chart2/source include/basegfx include/basic include/canvas

2017-11-09 Thread Noel Grandin
 basic/inc/sbstdobj.hxx   |   
10 +++---
 basic/source/inc/namecont.hxx|
6 +++---
 basic/source/inc/symtbl.hxx  |
3 +--
 chart2/source/controller/chartapiwrapper/ChartDataWrapper.hxx|
6 ++
 chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.hxx  |
6 ++
 chart2/source/controller/chartapiwrapper/TitleWrapper.hxx|
6 ++
 chart2/source/controller/chartapiwrapper/WrappedScaleProperty.hxx|
6 ++
 chart2/source/controller/chartapiwrapper/WrappedTextRotationProperty.hxx |
4 ++--
 chart2/source/controller/dialogs/tp_ChartType.hxx|
5 ++---
 chart2/source/controller/dialogs/tp_DataSource.hxx   |
6 ++
 chart2/source/controller/dialogs/tp_RangeChooser.hxx |
6 ++
 chart2/source/controller/dialogs/tp_Wizard_TitlesAndObjects.hxx  |
5 ++---
 chart2/source/controller/inc/CharacterPropertyItemConverter.hxx  |
5 ++---
 chart2/source/controller/inc/dlg_DataSource.hxx  |
5 ++---
 chart2/source/inc/CachedDataSequence.hxx |
6 ++
 chart2/source/inc/ErrorBar.hxx   |
5 ++---
 chart2/source/inc/LifeTime.hxx   |
8 +++-
 chart2/source/inc/MediaDescriptorHelper.hxx  |
7 ++-
 chart2/source/inc/UncachedDataSequence.hxx   |
5 ++---
 chart2/source/inc/WrappedIgnoreProperty.hxx  |
4 ++--
 chart2/source/model/inc/DataSeries.hxx   |
5 ++---
 chart2/source/model/inc/Diagram.hxx  |
5 ++---
 chart2/source/model/inc/StockBar.hxx |
5 ++---
 chart2/source/model/main/Axis.hxx|
7 ++-
 chart2/source/model/main/DataPoint.hxx   |
5 ++---
 chart2/source/model/main/FormattedString.hxx |
5 ++---
 chart2/source/model/main/GridProperties.hxx  |
5 ++---
 chart2/source/model/main/Legend.hxx  |
5 ++---
 chart2/source/model/main/PageBackground.hxx  |
5 ++---
 chart2/source/model/main/Title.hxx   |
5 ++---
 chart2/source/model/main/Wall.hxx|
4 ++--
 chart2/source/model/template/AreaChartType.hxx   |
4 ++--
 chart2/source/model/template/BarChartType.hxx|
4 ++--
 chart2/source/model/template/BubbleChartType.hxx |
4 ++--
 chart2/source/model/template/CandleStickChartType.hxx|
4 ++--
 chart2/source/model/template/ColumnChartType.hxx |
4 ++--
 chart2/source/model/template/FilledNetChartType.hxx  |
4 ++--
 chart2/source/model/template/GL3DBarChartType.hxx|
4 ++--
 chart2/source/model/template/LineChartType.hxx   |
4 ++--
 chart2/source/model/template/NetChartType.hxx|
4 ++--
 chart2/source/model/template/PieChartType.hxx|
4 ++--
 chart2/source/model/template/ScatterChartType.hxx|
4 ++--
 chart2/source/tools/RegressionEquation.hxx   |
5 ++---
 chart2/source/view/axes/Tickmarks.hxx|
5 ++---
 include/basegfx/color/bcolormodifier.hxx |
3 +--
 include/basegfx/pixel/bpixel.hxx |
3 +--
 include/basegfx/tuple/b2i64tuple.hxx |
3 +--
 include/basic/sbx.hxx|
3 +--
 include/canvas/parametricpolypolygon.hxx |
5 ++---
 49 files changed, 96 insertions(+), 145 deletions(-)

New commits:
commit 049e026755f7c36c7594bf4e7891603930669a54
Author: Noel Grandin 
Date:   Tue Nov 7 15:01:52 2017 +0200

loplugin:finalclasses in basic,basegfx

Change-Id: Iff223782fa0ded0fe46b8b7af35bfd21f331015f
Reviewed-on: https://gerrit.libreoffice.org/44535
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/basic/inc/sbstdobj.hxx b/basic/inc/sbstdobj.hxx
index 8fe8c336b848..ba2190b143e2 100644
--- a/basic/inc/sbstdobj.hxx
+++ b/basic/inc/sbstdobj.hxx
@@ -35,9 +35,8 @@ public:
 };
 
 // class SbStdPicture

Re: Running unit test by make

2017-11-09 Thread Noel Grandin
if you don't want to run the tests you can do

 make .build
​
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 92190] PRINTs landscape despite configured as portrait (Mac OS)

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92190

--- Comment #81 from Mike Kaganski  ---
... and BTW, comment 76 might be of value as a tool for one who would work on
this further and compare following program's code flow.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 92190] PRINTs landscape despite configured as portrait (Mac OS)

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92190

--- Comment #80 from Mike Kaganski  ---
(In reply to Paul Hubert from comment #79)

Please din't spam the issue by irrelevant comments. Especially if you don't
understand the comment you reply to. Comment 76 was proposing *changes in
code*, which didn't introduce *any* change in inch support in software, just
did a small changes in in-built predefined size (so that subsequent code would
detect it and choose a different code path). It's not a correct approach, but
not because of what you think about it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113750] FILESAVE: URLs in comments are deleted/lost/ stripped when document is saved as Word .docx

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113750

Kevin Suo  changed:

   What|Removed |Added

Version|5.4.2.2 release |5.3.0.0.alpha0+

--- Comment #2 from Kevin Suo  ---
Also broken in
Version: 5.3.0.0.alpha0+
Build ID: a042951ad4db2b84021e1d43361511dec998ce82

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 92190] PRINTs landscape despite configured as portrait (Mac OS)

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92190

--- Comment #79 from Paul Hubert  ---
(In reply to Telesto from comment #76)
> @Mike
> The issue started after LibO 5.3.4.2 with the release builds. However, I'm
> noticing the same issue in my own LODE LibO 5.3.4.2 build.
> 
> The issue is resolved by removing the "+ 0.5" from
> https://opengrok.libreoffice.org/xref/core/i18nutil/source/utility/paper.
> cxx#55
> 
> or defining the page size in MM instead of of INCH in 
> https://opengrok.libreoffice.org/xref/core/i18nutil/source/utility/paper.
> cxx#74
> 
> So instead of IN2MM100( 8.5 ), IN2MM100( 11 ) -->  MM2MM100 (215.9) MM2MM100
> ( 279.4 )

The issue is "resolved" by -.

These proposals are NOT a "resolution", they are a "workaround".

If inches are supported, then inches should be fully functional.

The program IS usable with workarounds. 
I only hope someone IS looking at the CODE to resolve this, for unquestionably
the CODE is faulty.

Resolution is elimination of the bug, not any workaround.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/source

2017-11-09 Thread Julien Nabet
 sc/source/filter/excel/xichart.cxx |   40 ++---
 sc/source/filter/excel/xipivot.cxx |   10 -
 sc/source/filter/inc/xichart.hxx   |3 --
 sc/source/filter/inc/xipivot.hxx   |5 +---
 4 files changed, 28 insertions(+), 30 deletions(-)

New commits:
commit 20dbb652d8bff996ac417f1c2c0894277c52497c
Author: Julien Nabet 
Date:   Thu Nov 9 21:57:12 2017 +0100

Replace lists by vectors in xichart/xipivot (sc)

+ use for range loops

Change-Id: I598d09a363005781a89354a25ea6a87a2b7c8b62
Reviewed-on: https://gerrit.libreoffice.org/44568
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/sc/source/filter/excel/xichart.cxx 
b/sc/source/filter/excel/xichart.cxx
index 627c8f998521..571c47467576 100644
--- a/sc/source/filter/excel/xichart.cxx
+++ b/sc/source/filter/excel/xichart.cxx
@@ -1906,12 +1906,12 @@ void XclImpChSeries::FinalizeDataFormats()
 }
 
 // copy series formatting to child objects
-for( XclImpChSerTrendLineList::iterator aLIt = maTrendLines.begin(), 
aLEnd = maTrendLines.end(); aLIt != aLEnd; ++aLIt )
+for (auto const& trendLine : maTrendLines)
 {
-(*aLIt)->SetDataFormat(mxSeriesFmt);
+trendLine->SetDataFormat(mxSeriesFmt);
 if (mxTitleLink->HasString())
 {
-(*aLIt)->SetTrendlineName(mxTitleLink->GetString());
+trendLine->SetTrendlineName(mxTitleLink->GetString());
 }
 }
 for (auto const& it : m_ErrorBars)
@@ -1932,14 +1932,14 @@ void XclImpChSeries::FinalizeDataFormats()
 }
 
 // set text labels to data formats
-for( XclImpChTextMap::iterator aTIt = maLabels.begin(), aTEnd = 
maLabels.end(); aTIt != aTEnd; ++aTIt )
+for (auto const& label : maLabels)
 {
-sal_uInt16 nPointIdx = aTIt->first;
+sal_uInt16 nPointIdx = label.first;
 if (nPointIdx == EXC_CHDATAFORMAT_ALLPOINTS)
 {
 if (!mxSeriesFmt)
 mxSeriesFmt = CreateDataFormat(nPointIdx, 
EXC_CHDATAFORMAT_DEFAULT);
-mxSeriesFmt->SetDataLabel(aTIt->second);
+mxSeriesFmt->SetDataLabel(label.second);
 }
 else if (nPointIdx < EXC_CHDATAFORMAT_MAXPOINTCOUNT)
 {
@@ -1955,7 +1955,7 @@ void XclImpChSeries::FinalizeDataFormats()
 }
 else
 p = itr->second;
-p->SetDataLabel(aTIt->second);
+p->SetDataLabel(label.second);
 }
 }
 
@@ -1964,8 +1964,8 @@ void XclImpChSeries::FinalizeDataFormats()
 mxSeriesFmt->UpdateSeriesFormat( pTypeGroup->GetTypeInfo(), 
pTypeGroup->GetGroupFormat().get() );
 
 // update data point formats (removes unchanged automatic formatting)
-for( XclImpChDataFormatMap::iterator aFIt = maPointFmts.begin(), aFEnd 
= maPointFmts.end(); aFIt != aFEnd; ++aFIt )
-aFIt->second->UpdatePointFormat( pTypeGroup->GetTypeInfo(), 
mxSeriesFmt.get() );
+for (auto const& pointFormat : maPointFmts)
+pointFormat.second->UpdatePointFormat( pTypeGroup->GetTypeInfo(), 
mxSeriesFmt.get() );
 }
 }
 
@@ -2070,10 +2070,10 @@ Reference< XDataSeries > 
XclImpChSeries::CreateDataSeries() const
 }
 
 // data point formatting
-for( XclImpChDataFormatMap::const_iterator aIt = maPointFmts.begin(), 
aEnd = maPointFmts.end(); aIt != aEnd; ++aIt )
+for (auto const& pointFormat : maPointFmts)
 {
-ScfPropertySet aPointProp = lclGetPointPropSet( xDataSeries, 
aIt->first );
-aIt->second->Convert( aPointProp, rTypeInfo,  );
+ScfPropertySet aPointProp = lclGetPointPropSet( xDataSeries, 
pointFormat.first );
+pointFormat.second->Convert( aPointProp, rTypeInfo,  );
 }
 }
 return xDataSeries;
@@ -2147,11 +2147,11 @@ void XclImpChSeries::ConvertTrendLines( Reference< 
XDataSeries > const & xDataSe
 Reference< XRegressionCurveContainer > xRegCurveCont( xDataSeries, 
UNO_QUERY );
 if( xRegCurveCont.is() )
 {
-for( XclImpChSerTrendLineList::const_iterator aIt = 
maTrendLines.begin(), aEnd = maTrendLines.end(); aIt != aEnd; ++aIt )
+for (auto const& trendLine : maTrendLines)
 {
 try
 {
-Reference< XRegressionCurve > xRegCurve = 
(*aIt)->CreateRegressionCurve();
+Reference< XRegressionCurve > xRegCurve = 
trendLine->CreateRegressionCurve();
 if( xRegCurve.is() )
 {
 xRegCurveCont->addRegressionCurve( xRegCurve );
@@ -2867,11 +2867,11 @@ void XclImpChTypeGroup::InsertDataSeries( Reference< 
XChartType > const & xChart
 void XclImpChTypeGroup::CreateDataSeries( Reference< XChartType > const & 

[Libreoffice-commits] online.git: loleaflet/src

2017-11-09 Thread Pranav Kant
 loleaflet/src/control/Control.LokDialog.js |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 7e8d584f1e18c6a7a8ab09a9debf4555aaa2a926
Author: Pranav Kant 
Date:   Fri Nov 10 11:43:02 2017 +0530

loleaflet: Focus back to map after closing dialog

Change-Id: Ibc9e62d907922ad1b9824f014dd179d9793e798b

diff --git a/loleaflet/src/control/Control.LokDialog.js 
b/loleaflet/src/control/Control.LokDialog.js
index e079c5cc..8460eb0d 100644
--- a/loleaflet/src/control/Control.LokDialog.js
+++ b/loleaflet/src/control/Control.LokDialog.js
@@ -152,6 +152,7 @@ L.Control.LokDialog = L.Control.extend({
 
_onDialogClose: function(dialogId) {
$('#' + dialogId).remove();
+   this._map.focus();
delete this._dialogs[dialogId];
},
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 113616] Mouse pointer actions are offset vertically to actual mouse location ( win 10 )

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113616

--- Comment #15 from Adrian Levi  ---
Out of curiosity I reinstalled 5.1.0.0.alpha1 which is the earliest unaffected
version for me. I note that OpenGL is disabled by default in that version.

Enabling OpenGL causes the screen output to be blanked, the same as:
5.1.0.0.beta1-buildfix1 and
5.1.0.0.beta2

I had to delete the LibreOfficeDev profile to get it to work again.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/source

2017-11-09 Thread Julien Nabet
 sc/source/filter/excel/xecontent.cxx |   19 --
 sc/source/filter/oox/excelvbaproject.cxx |   10 ++---
 sc/source/filter/oox/worksheethelper.cxx |   57 +++
 3 files changed, 42 insertions(+), 44 deletions(-)

New commits:
commit 65e578640f0258768a9253389356dbc63c845b7e
Author: Julien Nabet 
Date:   Thu Nov 9 21:21:54 2017 +0100

Replace some lists by vectors in sc/source/filter

Change-Id: I85396e3192ca09aba8f97c564f8d80058b362d91
Reviewed-on: https://gerrit.libreoffice.org/44564
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/sc/source/filter/excel/xecontent.cxx 
b/sc/source/filter/excel/xecontent.cxx
index 2237811b32f4..8939aadf6113 100644
--- a/sc/source/filter/excel/xecontent.cxx
+++ b/sc/source/filter/excel/xecontent.cxx
@@ -20,7 +20,7 @@
 #include 
 #include 
 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -92,11 +92,10 @@ public:
 voidSaveXml( XclExpXmlStream& rStrm );
 
 private:
-typedef ::std::list< XclExpStringRef >  XclExpStringList;
 typedef ::std::vector< XclExpHashEntry >XclExpHashVec;
 typedef ::std::vector< XclExpHashVec >  XclExpHashTab;
 
-XclExpStringListmaStringList;   /// List of unique strings (in SST ID 
order).
+std::vector< XclExpStringRef > maStringVector;   /// List of unique 
strings (in SST ID order).
 XclExpHashTab   maHashTab;  /// Hashed table that manages string 
pointers.
 sal_uInt32  mnTotal;/// Total count of strings (including 
doubles).
 sal_uInt32  mnSize; /// Size of the SST (count of unique 
strings).
@@ -130,7 +129,7 @@ sal_uInt32 XclExpSstImpl::Insert( XclExpStringRef xString )
 if( (aIt == rVec.end()) || (*aIt->mpString != *xString) )
 {
 nSstIndex = mnSize;
-maStringList.push_back( xString );
+maStringVector.push_back( xString );
 rVec.insert( aIt, aEntry );
 ++mnSize;
 }
@@ -144,7 +143,7 @@ sal_uInt32 XclExpSstImpl::Insert( XclExpStringRef xString )
 
 void XclExpSstImpl::Save( XclExpStream& rStrm )
 {
-if( maStringList.empty() )
+if( maStringVector.empty() )
 return;
 
 SvMemoryStream aExtSst( 8192 );
@@ -161,7 +160,7 @@ void XclExpSstImpl::Save( XclExpStream& rStrm )
 rStrm.StartRecord( EXC_ID_SST, 8 );
 
 rStrm << mnTotal << mnSize;
-for( XclExpStringList::const_iterator aIt = maStringList.begin(), aEnd = 
maStringList.end(); aIt != aEnd; ++aIt )
+for (auto const& elem : maStringVector)
 {
 if( !nBucketIndex )
 {
@@ -173,7 +172,7 @@ void XclExpSstImpl::Save( XclExpStream& rStrm )
.WriteUInt16( 0 ); // reserved
 }
 
-rStrm << **aIt;
+rStrm << *elem;
 
 if( ++nBucketIndex == nPerBucket )
 nBucketIndex = 0;
@@ -195,7 +194,7 @@ void XclExpSstImpl::Save( XclExpStream& rStrm )
 
 void XclExpSstImpl::SaveXml( XclExpXmlStream& rStrm )
 {
-if( maStringList.empty() )
+if( maStringVector.empty() )
 return;
 
 sax_fastparser::FSHelperPtr pSst = rStrm.CreateOutputStream(
@@ -212,10 +211,10 @@ void XclExpSstImpl::SaveXml( XclExpXmlStream& rStrm )
 XML_uniqueCount, OString::number(  mnSize ).getStr(),
 FSEND );
 
-for( XclExpStringList::const_iterator aIt = maStringList.begin(), aEnd = 
maStringList.end(); aIt != aEnd; ++aIt )
+for (auto const& elem : maStringVector)
 {
 pSst->startElement( XML_si, FSEND );
-(*aIt)->WriteXml( rStrm );
+elem->WriteXml( rStrm );
 pSst->endElement( XML_si );
 }
 
diff --git a/sc/source/filter/oox/excelvbaproject.cxx 
b/sc/source/filter/oox/excelvbaproject.cxx
index dd617ef6e6ce..1f8c24807597 100644
--- a/sc/source/filter/oox/excelvbaproject.cxx
+++ b/sc/source/filter/oox/excelvbaproject.cxx
@@ -19,7 +19,7 @@
 
 #include 
 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -72,7 +72,7 @@ void ExcelVbaProject::prepareImport()
 ::std::set< OUString > aUsedCodeNames;
 
 // collect sheets without codenames
-::std::list< SheetCodeNameInfo >  aCodeNameInfos;
+::std::vector< SheetCodeNameInfo >  aCodeNameInfos;
 
 // iterate over all imported sheets
 Reference< XEnumerationAccess > xSheetsEA( mxDocument->getSheets(), 
UNO_QUERY_THROW );
@@ -98,20 +98,20 @@ void ExcelVbaProject::prepareImport()
 }
 
 // create new codenames if sheets do not have one
-for( ::std::list< SheetCodeNameInfo >::iterator aIt = 
aCodeNameInfos.begin(), aEnd = aCodeNameInfos.end(); aIt != aEnd; ++aIt )
+for (auto & codeName : aCodeNameInfos)
 {
 // search for an unused codename
 sal_Int32 nCounter = 1;
 OUString aCodeName;
 do
 {
-aCodeName = aIt->maPrefix + OUString::number( nCounter++ 

[Libreoffice-commits] online.git: loleaflet/Makefile.am

2017-11-09 Thread Pranav Kant
 loleaflet/Makefile.am |   16 +---
 1 file changed, 9 insertions(+), 7 deletions(-)

New commits:
commit 66556c1668f2b8e11b28faffc62ee269e53d19dd
Author: Pranav Kant 
Date:   Fri Nov 10 11:30:06 2017 +0530

Copy jquery-ui image files to dist/ during normal make

No need of dist-hook now to do the same. The good thing is that now
these images will also be available to a developer which was earlier not
possible without manually copying the files left & right. This means no
more annoying errors in developer's browser console.

Change-Id: Ie180720086feace00b61891f56ee3532f5f9df7b

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index aa0492f0..07209238 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -14,9 +14,13 @@ L10N_JSON = $(patsubst po/%.po,dist/l10n/%.json,$(L10N_PO))
 L10N_STYLES_PO = $(wildcard po/styles/*.po)
 L10N_STYLES_JSON = $(patsubst 
po/styles/%.po,dist/l10n/styles/%.json,$(L10N_STYLES_PO))
 
+JQUERY_UI_IMAGE_PATH = node_modules/jquery-ui/themes/ui-lightness/images
+JQUERY_UI_IMAGES = $(wildcard $(JQUERY_UI_IMAGE_PATH)/*.png)
+JQUERY_UI_DIST_IMAGES = $(patsubst 
$(JQUERY_UI_IMAGE_PATH)/%.png,dist/$(JQUERY_UI_IMAGE_PATH)/%.png,$(JQUERY_UI_IMAGES))
+
 EXTRA_DIST = $(shell find . -type f -not -path './.git/*' | sed 's/.\///')
 
-all-local: node_modules $(L10N_JSON) $(L10N_STYLES_JSON)
+all-local: node_modules $(L10N_JSON) $(L10N_STYLES_JSON) 
$(JQUERY_UI_DIST_IMAGES)
rm -rf dist/plugins/draw-$(DRAW_VERSION) && mkdir -p 
dist/plugins/draw-$(DRAW_VERSION)
cd plugins/draw-$(DRAW_VERSION) && jake build && cp -ar dist 
../../dist/plugins/draw-$(DRAW_VERSION)
jake build debug=$(ENABLE_DEBUG) minify=$(MINIFY)
@@ -25,6 +29,10 @@ node_modules: npm-shrinkwrap.json
npm install
touch node_modules
 
+dist/$(JQUERY_UI_IMAGE_PATH)/%.png: $(JQUERY_UI_IMAGE_PATH)/%.png
+   mkdir -p dist/$(JQUERY_UI_IMAGE_PATH)
+   cp -a $(JQUERY_UI_IMAGE_PATH)/* dist/$(JQUERY_UI_IMAGE_PATH)/
+
 dist/l10n/%.json: po/%.po
@util/po2json.py $< -o $@
 
@@ -35,12 +43,6 @@ install-data-hook:
mkdir -p $(DESTDIR)$(pkgdatadir)/loleaflet; \
cp -ar dist/ $(DESTDIR)$(pkgdatadir)/loleaflet/;
 
-dist-hook:
-   chmod u+w $(distdir)/dist
-
-   mkdir -p 
$(distdir)/dist/node_modules/jquery-ui/themes/ui-lightness/images/
-   cp -a 
"node_modules/jquery-ui/themes/ui-lightness/images/ui-bg_highlight-soft_100_ee_1x100.png"
 $(distdir)/dist/node_modules/jquery-ui/themes/ui-lightness/images/
-
 pot:
xgettext --from-code=UTF-8 --keyword=_ 
--output=po/templates/loleaflet-ui.pot \
admin.strings.js \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 113750] FILESAVE: URLs in comments are deleted/lost/ stripped when document is saved as Word .docx

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113750

Kevin Suo  changed:

   What|Removed |Added

   Keywords||filter:docx
 Status|UNCONFIRMED |NEW
 CC||suokunl...@126.com
 Ever confirmed|0   |1

--- Comment #1 from Kevin Suo  ---
Reproduced

Version: 5.4.4.0.0+
Build ID:0673cd4e4e8f4b2ab9e1ac14f61958b49eebaa7a
CPU 线程:4; 操作系统:Linux 4.13; UI 渲染:默认; VCL: gtk3; 
区域语言:zh-CN (zh_CN.UTF-8); Calc: group

Also in
Version: 5.3.7.2.0+
Build ID: 5.3.7.2-1.fc26
CPU Threads: 4; OS Version: Linux 4.13; UI Render: default; VCL: gtk3; Layout
Engine: new; 
Locale: zh-CN (zh_CN.UTF-8); Calc: group

Fedora 26 x64

Set to NEW.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 92190] PRINTs landscape despite configured as portrait (Mac OS)

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92190

--- Comment #78 from Mike Kaganski  ---
(In reply to Telesto from comment #76)

Unfortunately both your proposals are based on tricking LO to believe that its
Letter size is different from some other size in process of checking for
necessary adjustments. This kind of fix would mask this for Letter to bite
again in a different place. The proper fix would be finding the faulty code,
and fix it to do necessary adjustments when they need to be done. But I don't
own a Mac, so I cannot work on this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113750] New: FILESAVE: URLs in comments are deleted/lost/ stripped when document is saved as Word .docx

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113750

Bug ID: 113750
   Summary: FILESAVE: URLs in comments are deleted/lost/stripped
when document is saved as Word .docx
   Product: LibreOffice
   Version: 5.4.2.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: major
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: l...@zeta.org.au

Created attachment 137654
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137654=edit
Zip file containing two versions of an example document

I lost an hour or so of work, since I had spent time carefully finding example
URLs for various comments I made to a discussion document.  Every URL in every
comment was stripped from the document when it was saved.

Steps to reproduce:
1) In a comment, type in a URL and make it an actual hyperlink.
2) Save the file as a .docx.
3) Close the file and reopen it.
4) Note that the URL is gone.

See attached sample documents.  It's saved in the .odt, lost in the .docx.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/source

2017-11-09 Thread Tamás Zolnai
 sw/source/filter/ww8/wrtww8.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit e2eddd96bc1cd83da02c2d5a36c7a678a8544673
Author: Tamás Zolnai 
Date:   Tue Nov 7 20:43:44 2017 +0100

This aEndCps variable can be local

Change-Id: I61ed4b5fcac6b12e7d3c1b4eab61ccff1e207c5f
Reviewed-on: https://gerrit.libreoffice.org/44503
Tested-by: Jenkins 
Reviewed-by: Tamás Zolnai 

diff --git a/sw/source/filter/ww8/wrtww8.cxx b/sw/source/filter/ww8/wrtww8.cxx
index 97f4154a9544..4749fac3ecc8 100644
--- a/sw/source/filter/ww8/wrtww8.cxx
+++ b/sw/source/filter/ww8/wrtww8.cxx
@@ -191,7 +191,8 @@ typedef BKMKCPs::iterator CPItr;
 class WW8_WrtBookmarks
 {
 private:
-BKMKCPs aSttCps,aEndCps;
+/// Structure of one item inside this map: (startPos, (endPos, (a bool 
value?, bookmarkName)))
+BKMKCPs aSttCps;
 BKMKNames maSwBkmkNms;
 
 WW8_WrtBookmarks(WW8_WrtBookmarks const&) = delete;
@@ -259,6 +260,8 @@ void WW8_WrtBookmarks::Write( WW8Export& rWrt)
 std::vector aNames;
 SvMemoryStream aTempStrm1(65535,65535);
 SvMemoryStream aTempStrm2(65535,65535);
+
+BKMKCPs aEndCps;
 for (aItr = aSttCps.begin();aItr!=aSttCps.end();++aItr)
 {
 if (aItr->second)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Running unit test by make

2017-11-09 Thread Zolnai Tamás
Hi all,

I wonder what the reason of running some of the unit tests by calling
simple make on a module (e.g. make sd). I used to use simple make while
doing the intensive hacking of the code, when I don't need to run unit
tests at all. After I finished with the codewriting, I can run the unit
tests with make check or a top level make. I guess there is some additional
option with which I can avoid unit tests, but I would not waste my time
with typing.
So I wonder whether there is any good reason for having this unit tests run
by make. Why don't we run tests only by make check? Nowdays most of the
patches are pushed via gerrit, so we don't need to worry about that the
commiter don't run the unit tests before pushing to the branch. So I think
it might be good to remove this type of unit tests and run these tests as
slow check targets. At least a config option would be usefull, which can do
that.

Any thoughts about this?

Best Regards,
Tamás
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 113749] New: Gtk-WARNING: Drawing a gadget with negative dimensions. Did you forget to allocate a size ? (node arrow owner GtkTreeMenu)

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113749

Bug ID: 113749
   Summary: Gtk-WARNING: Drawing a gadget with negative
dimensions. Did you forget to allocate a size? (node
arrow owner GtkTreeMenu)
   Product: LibreOffice
   Version: 5.3.7.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: trivial
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: suokunl...@126.com

When run libreoffice from terminal, I noticed the following gtk warning:

> (soffice:5298): Gtk-WARNING **: Drawing a gadget with negative dimensions. 
> Did you forget to allocate a size? (node arrow owner GtkTreeMenu)

To reproduce, type run soffice in terminal, create new Calc -> Ctrl+S to save
-> Click the "All Formats" drop-down list box (at the bottom-right).


Version: 5.3.7.2.0+
Build ID: 5.3.7.2-1.fc26
CPU Threads: 4; OS Version: Linux 4.13; UI Render: default; VCL: gtk3; Layout
Engine: new; 
Locale: zh-CN (zh_CN.UTF-8); Calc: group
Fedora 26 x64.

Also reproduced in branch 5-4 daily.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/qa sw/source

2017-11-09 Thread Andrea Gelmini
 sw/qa/extras/ww8export/ww8export2.cxx|2 +-
 sw/source/filter/ww8/attributeoutputbase.hxx |2 +-
 sw/source/filter/ww8/ww8atr.cxx  |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit ac9ea45444d96a8369a0ab9407b2868eee7d7548
Author: Andrea Gelmini 
Date:   Fri Nov 10 00:42:59 2017 +0100

Fix typos

Change-Id: I2b6f476122a1991b77e7831da225f7dc17d4061c
Reviewed-on: https://gerrit.libreoffice.org/44570
Reviewed-by: Tamás Zolnai 
Tested-by: Tamás Zolnai 

diff --git a/sw/qa/extras/ww8export/ww8export2.cxx 
b/sw/qa/extras/ww8export/ww8export2.cxx
index 0a3179d853c3..06005998f5f4 100644
--- a/sw/qa/extras/ww8export/ww8export2.cxx
+++ b/sw/qa/extras/ww8export/ww8export2.cxx
@@ -459,7 +459,7 @@ DECLARE_OOXMLEXPORT_TEST( testTableCrossReference, 
"table_cross_reference.odt" )
 CPPUNIT_ASSERT_EQUAL(sal_Int16(0), nValue);
 break;
 }
-// Above / bellow reference
+// Above / below reference
 case 6:
 {
 
CPPUNIT_ASSERT(xServiceInfo->supportsService("com.sun.star.text.TextField.GetReference"));
diff --git a/sw/source/filter/ww8/attributeoutputbase.hxx 
b/sw/source/filter/ww8/attributeoutputbase.hxx
index 347153d501d2..94ed269fa453 100644
--- a/sw/source/filter/ww8/attributeoutputbase.hxx
+++ b/sw/source/filter/ww8/attributeoutputbase.hxx
@@ -626,7 +626,7 @@ protected:
 
 virtual bool AnalyzeURL( const OUString& rUrl, const OUString& rTarget, 
OUString* pLinkURL, OUString* pMark );
 
-/// Insert a bookmark inside the currently processed parargaph.
+/// Insert a bookmark inside the currently processed paragraph.
 virtual void WriteBookmarkInActParagraph( const OUString& rName, sal_Int32 
nFirstRunPos, sal_Int32 nLastRunPos ) = 0;
 
 ww8::GridColsPtr GetGridCols( ww8::WW8TableNodeInfoInner::Pointer_t const 
& pTableTextNodeInfoInner );
diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index cb7f1e734a84..9e7c114988e0 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -2007,7 +2007,7 @@ void 
AttributeOutputBase::GenerateBookmarksForSequenceField(const SwTextNode& rN
 // If we have a reference to the current 
sequence field
 if(pRefField->GetSeqNo() == nSeqFieldNumber && 
pRefField->GetSetRefName() == sObjectName)
 {
-// Need to create a seperate run for 
separator character
+// Need to create a separate run for 
separator character
 SwWW8AttrIter aLocalAttrIter( GetExport(), 
rNode ); // We need a local iterator having the right number of runs
 const OUString aText = rNode.GetText();
 const sal_Int32 nCategoryStart = 
aText.indexOf(pRefField->GetSetRefName());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 101733] Personalization not working

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101733

--- Comment #8 from Tim Chambers  
---
In 5.4.2.2 (x64, Windows 10 and on Linux Mint 18.2)the search for firefox
themes does not work - no themes are found, even in the "LibreOffice" category.
It did for a while. May be related to the firefox changes?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/CppunitTest_sc_condformats.mk sc/Module_sc.mk sc/qa

2017-11-09 Thread Jens Carl
 sc/CppunitTest_sc_condformats.mk |  106 ---
 sc/Module_sc.mk  |1 
 sc/qa/extras/sccondformats.cxx   |  130 ---
 3 files changed, 237 deletions(-)

New commits:
commit d31fdb27583f5f594e8424bf061a74fde5cf2704
Author: Jens Carl 
Date:   Thu Nov 2 00:19:40 2017 +

Remove obsolete sc_condformats unit test

Remove the special snowflake sc_condformats because it's
now covert by xsheetconditionalentries (see commit
44e9640748791f602edb22cbc499200283466e1e).

Change-Id: Ibdae392533605b56cf9b9c28f8c419ea0d32c0d8
Reviewed-on: https://gerrit.libreoffice.org/44523
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/sc/CppunitTest_sc_condformats.mk b/sc/CppunitTest_sc_condformats.mk
deleted file mode 100644
index f88d6b264674..
--- a/sc/CppunitTest_sc_condformats.mk
+++ /dev/null
@@ -1,106 +0,0 @@
-# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
-#*
-#
-# This file is part of the LibreOffice project.
-#
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-#
-#*
-
-$(eval $(call gb_CppunitTest_CppunitTest,sc_condformats))
-
-$(eval $(call gb_CppunitTest_add_exception_objects,sc_condformats, \
-   sc/qa/extras/sccondformats \
-))
-
-$(eval $(call gb_CppunitTest_use_external,sc_condformats,boost_headers))
-
-$(eval $(call gb_CppunitTest_use_libraries,sc_condformats, \
-   basegfx \
-   comphelper \
-   cppu \
-   cppuhelper \
-   drawinglayer \
-   editeng \
-   for \
-   forui \
-   i18nlangtag \
-   msfilter \
-   oox \
-   sal \
-   salhelper \
-   sax \
-   sb \
-   sc \
-   scqahelper \
-   sfx \
-   sot \
-   subsequenttest \
-   svl \
-   svt \
-   svx \
-   svxcore \
-   test \
-   tk \
-   tl \
-   ucbhelper \
-   unotest \
-   utl \
-   vbahelper \
-   vcl \
-   xo \
-))
-
-$(eval $(call gb_CppunitTest_set_include,sc_condformats,\
-   -I$(SRCDIR)/sc/source/ui/inc \
-   -I$(SRCDIR)/sc/inc \
-   $$(INCLUDE) \
-))
-
-$(eval $(call gb_CppunitTest_use_sdk_api,sc_condformats))
-
-$(eval $(call gb_CppunitTest_use_ure,sc_condformats))
-$(eval $(call gb_CppunitTest_use_vcl,sc_condformats))
-
-$(eval $(call gb_CppunitTest_use_components,sc_condformats,\
-   basic/util/sb \
-   comphelper/util/comphelp \
-   configmgr/source/configmgr \
-   dbaccess/util/dba \
-   filter/source/config/cache/filterconfig1 \
-   filter/source/storagefilterdetect/storagefd \
-   forms/util/frm \
-   framework/util/fwk \
-   i18npool/util/i18npool \
-   linguistic/source/lng \
-   oox/util/oox \
-   package/source/xstor/xstor \
-   package/util/package2 \
-   sax/source/expatwrap/expwrap \
-   scripting/source/basprov/basprov \
-   scripting/util/scriptframe \
-   sc/util/sc \
-   sc/util/scd \
-   sc/util/scfilt \
-   $(call gb_Helper_optional,SCRIPTING, \
-   sc/util/vbaobj) \
-   sfx2/util/sfx \
-   sot/util/sot \
-   svl/source/fsstor/fsstorage \
-   toolkit/util/tk \
-   ucb/source/core/ucb1 \
-   ucb/source/ucp/file/ucpfile1 \
-   ucb/source/ucp/tdoc/ucptdoc1 \
-   unotools/util/utl \
-   unoxml/source/rdf/unordf \
-   unoxml/source/service/unoxml \
-   uui/util/uui \
-   xmloff/util/xo \
-   svtools/util/svt \
-))
-
-$(eval $(call gb_CppunitTest_use_configuration,sc_condformats))
-
-# vim: set noet sw=4 ts=4:
diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk
index fab66a9a48c7..1879ca435abf 100644
--- a/sc/Module_sc.mk
+++ b/sc/Module_sc.mk
@@ -57,7 +57,6 @@ endif
 endif
 
 $(eval $(call gb_Module_add_slowcheck_targets,sc, \
-   CppunitTest_sc_condformats \
CppunitTest_sc_new_cond_format_api \
CppunitTest_sc_subsequent_filters_test \
CppunitTest_sc_subsequent_export_test \
diff --git a/sc/qa/extras/sccondformats.cxx b/sc/qa/extras/sccondformats.cxx
deleted file mode 100644
index 9aad32ba6f06..
--- a/sc/qa/extras/sccondformats.cxx
+++ /dev/null
@@ -1,130 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- */
-
-#include 
-#include 
-#include 
-#include 
-
-#include 
-#include 
-#include 
-#include 
-#include 

[Libreoffice-bugs] [Bug 101211] "To Begin of Previous Page" and "To Begin of Next Page" commands dont set view to beginning of page

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101211

--- Comment #6 from Kenneth Hanson  ---
Can we get the commands from the navigator added to the customize dialog?
Nobody has reported on why they aren't there already or whether this is
feasible.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 92190] PRINTs landscape despite configured as portrait (Mac OS)

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92190

--- Comment #77 from Paul Hubert  ---
The issue is "resolved" by -.
But who uses metric?? Or, more to the point, what of all the users who have no
useful introduction TO metric?

If inches are supported, then inches should be fully functional.

The program IS usable with workarounds. I only hope someone IS looking at the
CODE to resolve this.

Resolution is elimination of the bug, not any workaround.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113748] New: New download of Version 5.4.3.2 can' t open Excel spreadsheets

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113748

Bug ID: 113748
   Summary: New download of Version 5.4.3.2 can't open Excel
spreadsheets
   Product: LibreOffice
   Version: 5.4.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: janie...@yahoo.com

Description:
I downloaded the latest version of LibreOffice Suite and when I went to open my
Excel spreadsheet, it wouldn't open.  Excel appeared in a limited fashion,
since I have not downloaded the MS Office Suite, and I couldn't do anything
with my Excel workbook.  I have not encountered this problem before.  I select
a Custom download and check both Word and Excel on the install of LibreOffice
Suite.  I did this twice but it can't open Excel workbooks now.  And to think I
just accessed my Excel workbook recently without a problem. Can you fix this
please? BTW, I did have to repopulate my files after re-installing the O.S. on
my computer.  I don't know if something changed or what in the restoration of
my files by Carbonite.  The workbooks were always saved in Excel and opened by
LibreOffice.  My Word documents open up fine with LibreOffice.

Steps to Reproduce:
1. Open File Explorer.
2. Go to Documents and Choose Specific Folder to open.
3. Click on Excel worksheet
4. Microsoft brings up the actual Excel workbook and wants to Activate MS
Office.
5. Access is blocked to my Excel workbook though it's on the screen.  

Actual Results:  
This "Activate Office" box is blocking my ability to work in the Excel
workbook.  LibreOffice should have opened it up since it used to do that up
until two days ago or so.  I'm not sure what's going on.  There was a new MS
update two or three days ago.  MS Office seems to be overriding LibreOffice
even though I never downloaded MS Office.

Expected Results:
Nothing.  I was blocked from being able to work in my saved Excel workbook. 
LibreOffice did not open the Excel workbook, as it would normally do.


Reproducible: Always


User Profile Reset: No



Additional Info:
I downloaded the latest version of LibreOffice today, November 9, 2017.  It was
the second time to do so within a few days, as I had downloaded the earlier
version and there were some problems with it so I replaced it with the latest
version.  I have not done anything differently other than to reinstall the O.S.
on October 27, 2017.  The backup restoration started the next day and took two
days to repopulate my computer files.


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101
Firefox/56.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 101733] Personalization not working

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101733

--- Comment #7 from jonathon  ---
Persona works for me in LibO 5.4.2.2 

Persona does not work for me in LibO 5.4.3.1
Build ID: 32c8895c6cae21571f364dbb059f419a743ee44d
CPU threads: 2; OS: Linux 4.7; UI render: default; VCL: gtk2;
Locale: en-ZA (en_US.UTF-8); Calc: group

Unfortunately, Peter Maunder's paper didn't provide a workaround. :(

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113021] Impress media player REPEAT toggle function does not loop MP4 video clip

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113021

R. Bingham  changed:

   What|Removed |Added

Version|5.3.0.1 rc  |5.4.2.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112958] Embedded video clip play on NVIDIA display ( yet another OpenGL workaround)

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112958

--- Comment #2 from R. Bingham  ---
And OpenGL enabled.

Oy!  But now with OpenGL enabled, menu popup lists display blank.  Sigh.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113437] [FILEOPEN, FILESAVE] Truncated error message for I/O error

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113437

--- Comment #6 from B.J. Herbison  ---
Using "SAL_USE_VCLPLUGIN=gen libreoffice" the message is still on three lines,
but the message window is tall enough to see the full file name.

Version: 5.4.1.2
Build ID: 1:5.4.1-0ubuntu1
CPU threads: 8; OS: Linux 4.13; UI render: default; VCL: x11; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93529] [META] VCL/OpenGL rendering tracker bug for 5.0+

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93529
Bug 93529 depends on bug 112958, which changed state.

Bug 112958 Summary: Embedded video clip play on NVIDIA display (yet another 
OpenGL workaround)
https://bugs.documentfoundation.org/show_bug.cgi?id=112958

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112958] Embedded video clip play on NVIDIA display ( yet another OpenGL workaround)

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112958

R. Bingham  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from R. Bingham  ---
Reported differential Impress video playback display behavior now absent.

NVIDIA M1200 GPU driver updated to v388.16.
Java JRE x64 updated to 8u152 and 9u01.
K-Lite Codec pack updated to 13.6.0.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - 6 commits - include/sfx2 sc/source sfx2/source sw/qa sw/source writerfilter/source

2017-11-09 Thread Vasily Melenchuk
Rebased ref, commits from common ancestor:
commit aad3a938f9bb929869ed50482c9e747079bbc69e
Author: Vasily Melenchuk 
Date:   Fri Aug 18 22:14:08 2017 +0300

tdf#43017: Support for DOCX hyperlinks character properties

Here goes a bunch of related changes:

1. Create new character style based on current character properties

2. Apply created style to hyperlink object

3. Fixes to predefined style names usage in w:rPr

4. Disable style usage for hyperlinks in TOC: they will receive later
anoter styles

Reviewed-on: https://gerrit.libreoffice.org/41784
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 
(cherry picked from commit eaa9cf6a3069fba3d82c046f0041bfb537d9e648)

Conflicts:
sw/qa/extras/ooxmlimport/ooxmlimport.cxx
writerfilter/source/dmapper/DomainMapper_Impl.hxx

Change-Id: I1a228992eb7c1e259a6a811aa7f959debaae4f35

diff --git a/sw/qa/extras/ooxmlimport/data/tdf43017.docx 
b/sw/qa/extras/ooxmlimport/data/tdf43017.docx
new file mode 100644
index ..c3372e11a0c8
Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/tdf43017.docx differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index b55b17c05053..a9be7f45cb75 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -3286,6 +3286,17 @@ DECLARE_OOXMLIMPORT_TEST(testTdf96218, "tdf96218.docx")
 CPPUNIT_ASSERT(!getProperty(getShape(1), "IsFollowingTextFlow"));
 }
 
+DECLARE_OOXMLIMPORT_TEST(testTdf43017, "tdf43017.docx")
+{
+uno::Reference xParagraph = getParagraph(1);
+uno::Reference xText = getRun(xParagraph, 2, "kick the 
bucket");
+
+// Ensure that hyperlink text color is not blue (0xff), but default 
(-1)
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Hyperlink color should be black!",
+sal_Int32(-1), getProperty(xText, "CharColor"));
+}
+
+// tests should only be added to ooxmlIMPORT *if* they fail round-tripping in 
ooxmlEXPORT
 
 CPPUNIT_PLUGIN_IMPLEMENT();
 
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index 46aef6bf81c7..eec33d46246f 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -2155,11 +2155,11 @@ void DomainMapper::sprmWithProps( Sprm& rSprm, const 
PropertyMapPtr& rContext )
 {
 OUString sConvertedName( 
m_pImpl->GetStyleSheetTable()->ConvertStyleName( sStringValue, true ) );
 // First check if the style exists in the document.
-StyleSheetEntryPtr pEntry = m_pImpl->GetStyleSheetTable( 
)->FindStyleSheetByStyleName( sConvertedName );
+StyleSheetEntryPtr pEntry = m_pImpl->GetStyleSheetTable( 
)->FindStyleSheetByConvertedStyleName( sConvertedName );
 bool bExists = pEntry.get( ) && ( pEntry->nStyleTypeCode == 
STYLE_TYPE_CHAR );
-
-// Add the property if the style exists
-if ( bExists && m_pImpl->GetTopContext() )
+// Add the property if the style exists, but do not add it 
elements in TOC:
+// they will receive later another style references from TOC
+if ( bExists && m_pImpl->GetTopContext() && !m_pImpl->IsInTOC())
 m_pImpl->GetTopContext()->Insert( PROP_CHAR_STYLE_NAME, 
uno::makeAny( sConvertedName ) );
 }
 break;
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 19d6f1a82985..c5ca29a02510 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -1283,7 +1283,18 @@ void DomainMapper_Impl::appendTextPortion( const 
OUString& rString, const Proper
 }
 }
 else
+{
+if (IsOpenField() && GetTopFieldContext()->GetFieldId() == 
FIELD_HYPERLINK)
+{
+// It is content of hyperlink field. We need to create 
and remember
+// character style for later applying to hyperlink
+PropertyValueVector_t aProps = 
comphelper::sequenceToContainer< PropertyValueVector_t 
>(GetTopContext()->GetPropertyValues());
+OUString sHyperlinkStyleName = 
GetStyleSheetTable()->getOrCreateCharStyle(aProps, /*bAlwaysCreate=*/false);
+
GetTopFieldContext()->SetHyperlinkStyle(sHyperlinkStyleName);
+}
+
 xTextRange = xTextAppend->appendTextPortion(rString, 
aValues);
+}
 }
 
 CheckRedline( xTextRange );
@@ -3572,6 +3583,8 @@ void DomainMapper_Impl::CloseFieldCommand()
 aFieldConversionMap.find(std::get<0>(field));
 if(aIt != 

[Libreoffice-bugs] [Bug 113021] Impress media player REPEAT toggle function does not loop MP4 video clip

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113021

R. Bingham  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #6 from R. Bingham  ---
Installed
libo-master~2017-11-04_23.19.31_LibreOfficeDev_6.0.0.0.alpha1_Win_x86.msi and
tested Impress video player repeat function.

Repeat function performed as expected.

Re-tested LO 5.4.4.2 x64 and repeat function not changed, so still not
repeating.

Not quite an apples to apples comparison since LO 5.4.4.2 x64 vs LO 6.x but
maybe close enough to declare this bug a duplicate of bug 106981 per  Buovjaga.

FYI - but other video playback behavior changed affecting bug 112958, most
likely because of a NVIDIA driver update.

*** This bug has been marked as a duplicate of bug 106981 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 106981] The Repeat feature when you select an Inserted Video for it to play in a Loop during a slideshow no longer works (64-bit only)

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106981

R. Bingham  changed:

   What|Removed |Added

 CC||rdbing...@verizon.net

--- Comment #10 from R. Bingham  ---
*** Bug 113021 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - sw/qa writerfilter/source

2017-11-09 Thread Vasily Melenchuk
 sw/qa/extras/ooxmlimport/data/tdf43017.docx   |binary
 sw/qa/extras/ooxmlimport/ooxmlimport.cxx  |   11 +++
 writerfilter/source/dmapper/DomainMapper.cxx  |8 
 writerfilter/source/dmapper/DomainMapper_Impl.cxx |   21 +
 writerfilter/source/dmapper/DomainMapper_Impl.hxx |   17 +
 5 files changed, 49 insertions(+), 8 deletions(-)

New commits:
commit d280a38913d37d5b58cd72ff3798ca4a89028197
Author: Vasily Melenchuk 
Date:   Fri Aug 18 22:14:08 2017 +0300

tdf#43017: Support for DOCX hyperlinks character properties

Here goes a bunch of related changes:

1. Create new character style based on current character properties

2. Apply created style to hyperlink object

3. Fixes to predefined style names usage in w:rPr

4. Disable style usage for hyperlinks in TOC: they will receive later
anoter styles

Reviewed-on: https://gerrit.libreoffice.org/41784
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 
(cherry picked from commit eaa9cf6a3069fba3d82c046f0041bfb537d9e648)

Conflicts:
sw/qa/extras/ooxmlimport/ooxmlimport.cxx
writerfilter/source/dmapper/DomainMapper_Impl.hxx

Change-Id: I1a228992eb7c1e259a6a811aa7f959debaae4f35

diff --git a/sw/qa/extras/ooxmlimport/data/tdf43017.docx 
b/sw/qa/extras/ooxmlimport/data/tdf43017.docx
new file mode 100644
index ..c3372e11a0c8
Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/tdf43017.docx differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index b55b17c05053..a9be7f45cb75 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -3286,6 +3286,17 @@ DECLARE_OOXMLIMPORT_TEST(testTdf96218, "tdf96218.docx")
 CPPUNIT_ASSERT(!getProperty(getShape(1), "IsFollowingTextFlow"));
 }
 
+DECLARE_OOXMLIMPORT_TEST(testTdf43017, "tdf43017.docx")
+{
+uno::Reference xParagraph = getParagraph(1);
+uno::Reference xText = getRun(xParagraph, 2, "kick the 
bucket");
+
+// Ensure that hyperlink text color is not blue (0xff), but default 
(-1)
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Hyperlink color should be black!",
+sal_Int32(-1), getProperty(xText, "CharColor"));
+}
+
+// tests should only be added to ooxmlIMPORT *if* they fail round-tripping in 
ooxmlEXPORT
 
 CPPUNIT_PLUGIN_IMPLEMENT();
 
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index 46aef6bf81c7..eec33d46246f 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -2155,11 +2155,11 @@ void DomainMapper::sprmWithProps( Sprm& rSprm, const 
PropertyMapPtr& rContext )
 {
 OUString sConvertedName( 
m_pImpl->GetStyleSheetTable()->ConvertStyleName( sStringValue, true ) );
 // First check if the style exists in the document.
-StyleSheetEntryPtr pEntry = m_pImpl->GetStyleSheetTable( 
)->FindStyleSheetByStyleName( sConvertedName );
+StyleSheetEntryPtr pEntry = m_pImpl->GetStyleSheetTable( 
)->FindStyleSheetByConvertedStyleName( sConvertedName );
 bool bExists = pEntry.get( ) && ( pEntry->nStyleTypeCode == 
STYLE_TYPE_CHAR );
-
-// Add the property if the style exists
-if ( bExists && m_pImpl->GetTopContext() )
+// Add the property if the style exists, but do not add it 
elements in TOC:
+// they will receive later another style references from TOC
+if ( bExists && m_pImpl->GetTopContext() && !m_pImpl->IsInTOC())
 m_pImpl->GetTopContext()->Insert( PROP_CHAR_STYLE_NAME, 
uno::makeAny( sConvertedName ) );
 }
 break;
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 19d6f1a82985..c5ca29a02510 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -1283,7 +1283,18 @@ void DomainMapper_Impl::appendTextPortion( const 
OUString& rString, const Proper
 }
 }
 else
+{
+if (IsOpenField() && GetTopFieldContext()->GetFieldId() == 
FIELD_HYPERLINK)
+{
+// It is content of hyperlink field. We need to create 
and remember
+// character style for later applying to hyperlink
+PropertyValueVector_t aProps = 
comphelper::sequenceToContainer< PropertyValueVector_t 
>(GetTopContext()->GetPropertyValues());
+OUString sHyperlinkStyleName = 
GetStyleSheetTable()->getOrCreateCharStyle(aProps, /*bAlwaysCreate=*/false);
+

[Libreoffice-bugs] [Bug 113616] Mouse pointer actions are offset vertically to actual mouse location ( win 10 )

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113616

Kevin Suo  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #14 from Kevin Suo  ---
I think thua should be Set to NEW as There are several duplicates.The
workaround as said is to disable OpenGL temporarily in youR installation.
Maybe these drivers should also be put into the blacklist?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64690] EDITING: Process hang on find/replace in Basic code involving "\&"

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=64690

Jim Avera  changed:

   What|Removed |Added

   Keywords||regression

--- Comment #18 from Jim Avera  ---
Tried LO 3.3 and the bug is not there, works as expected (each character is
replaced by "ABC&").

Added "regression" keyword

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64690] EDITING: Process hang on find/replace in Basic code involving "\&"

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=64690

--- Comment #17 from Jim Avera  ---
Bug still there in master.   Locks up immediately, 100% CPU.

Version: 6.0.0.0.alpha0+
Build ID: cfbb8b5090537e79ba70e250ddee86d53facbe15
CPU threads: 8; OS: Linux 4.10; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2017-10-18_22:54:20
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113481] EDITING: it takes multiple backspace to delete one ideographic variation sequence

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113481

Kevin Suo  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
 CC||suokunl...@126.com
   Assignee|libreoffice-b...@lists.free |mark...@gmail.com
   |desktop.org |
 Ever confirmed|0   |1

--- Comment #3 from Kevin Suo  ---
Mark as ASSIGNED as I see a pending patch on gerrit By Mark Huang.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - sw/qa sw/source

2017-11-09 Thread Tamás Zolnai
 sw/qa/extras/ww8export/data/object_cross_reference.odt  |binary
 sw/qa/extras/ww8export/data/table_cross_reference.odt   |binary
 sw/qa/extras/ww8export/data/table_cross_reference_custom_format.odt |binary
 sw/qa/extras/ww8export/ww8export.cxx|  387 
++
 sw/source/filter/ww8/attributeoutputbase.hxx|   10 
 sw/source/filter/ww8/docxattributeoutput.cxx|  209 
-
 sw/source/filter/ww8/docxattributeoutput.hxx|   18 
 sw/source/filter/ww8/docxexport.cxx |2 
 sw/source/filter/ww8/rtfattributeoutput.cxx |4 
 sw/source/filter/ww8/rtfattributeoutput.hxx |6 
 sw/source/filter/ww8/wrtw8nds.cxx   |   27 
 sw/source/filter/ww8/wrtww8.cxx |6 
 sw/source/filter/ww8/wrtww8.hxx |1 
 sw/source/filter/ww8/ww8atr.cxx |  203 
+
 sw/source/filter/ww8/ww8attributeoutput.hxx |   12 
 15 files changed, 658 insertions(+), 227 deletions(-)

New commits:
commit 9df0dcc797dfa201f7843bb32984c342d274c1af
Author: Tamás Zolnai 
Date:   Thu Nov 9 17:55:14 2017 +0100

tdf#42346: DOC export of cross-references to objects

Same solution which was used for DOCX export:
98bc7215935f1eb2e0dc6f1db826d8e729430c13

Reviewed-on: https://gerrit.libreoffice.org/44502
Reviewed-by: Tamás Zolnai 
Tested-by: Tamás Zolnai 
(cherry picked from commit cbaa72d6e963847a4b98526430cd928bc7928fdd)

Change-Id: I8af46db003a6192c6adaae1a35dff58744919eee
Reviewed-on: https://gerrit.libreoffice.org/44560
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/sw/qa/extras/ww8export/data/object_cross_reference.odt 
b/sw/qa/extras/ww8export/data/object_cross_reference.odt
new file mode 100755
index ..9eaca352b68c
Binary files /dev/null and 
b/sw/qa/extras/ww8export/data/object_cross_reference.odt differ
diff --git a/sw/qa/extras/ww8export/data/table_cross_reference.odt 
b/sw/qa/extras/ww8export/data/table_cross_reference.odt
new file mode 100755
index ..95f33139c522
Binary files /dev/null and 
b/sw/qa/extras/ww8export/data/table_cross_reference.odt differ
diff --git 
a/sw/qa/extras/ww8export/data/table_cross_reference_custom_format.odt 
b/sw/qa/extras/ww8export/data/table_cross_reference_custom_format.odt
new file mode 100755
index ..1c41e364c6e5
Binary files /dev/null and 
b/sw/qa/extras/ww8export/data/table_cross_reference_custom_format.odt differ
diff --git a/sw/qa/extras/ww8export/ww8export.cxx 
b/sw/qa/extras/ww8export/ww8export.cxx
index f31bbda02a06..7985f479f0fa 100644
--- a/sw/qa/extras/ww8export/ww8export.cxx
+++ b/sw/qa/extras/ww8export/ww8export.cxx
@@ -726,6 +726,393 @@ DECLARE_WW8EXPORT_TEST(testTdf99474, "tdf99474.odt")
 CPPUNIT_ASSERT_EQUAL(COL_AUTO, charColor);
 }
 
+DECLARE_OOXMLEXPORT_TEST( testTableCrossReference, "table_cross_reference.odt" 
)
+{
+// tdf#42346: Cross references to tables were not saved
+// MSO uses simple bookmarks for referencing table caption, so we do the 
same by export
+if (!mbExported)
+return;
+
+// Check whether we have all the neccessary bookmarks exported and 
imported back
+uno::Reference xBookmarksSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xBookmarksByIdx(xBookmarksSupplier->getBookmarks(), uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(static_cast(4), 
xBookmarksByIdx->getCount());
+uno::Reference 
xBookmarksByName(xBookmarksSupplier->getBookmarks(), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xBookmarksByName->hasByName("Ref_Table0_full"));
+CPPUNIT_ASSERT(xBookmarksByName->hasByName("Ref_Table0_label_and_number"));
+CPPUNIT_ASSERT(xBookmarksByName->hasByName("Ref_Table0_caption_only"));
+CPPUNIT_ASSERT(xBookmarksByName->hasByName("Ref_Table0_number_only"));
+
+// Check bookmark text ranges
+{
+uno::Reference 
xContent(xBookmarksByName->getByName("Ref_Table0_full"), uno::UNO_QUERY);
+uno::Reference xRange(xContent->getAnchor(), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(OUString("Table 1: Table caption"), 
xRange->getString());
+}
+{
+uno::Reference 
xContent(xBookmarksByName->getByName("Ref_Table0_label_and_number"), 
uno::UNO_QUERY);
+uno::Reference xRange(xContent->getAnchor(), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(OUString("Table 1"), xRange->getString());
+}
+{
+uno::Reference 
xContent(xBookmarksByName->getByName("Ref_Table0_caption_only"), 
uno::UNO_QUERY);
+uno::Reference xRange(xContent->getAnchor(), 
uno::UNO_QUERY);
+

[Libreoffice-commits] core.git: sw/qa writerfilter/source

2017-11-09 Thread Vasily Melenchuk
 sw/qa/extras/ooxmlimport/data/tdf43017.docx   |binary
 sw/qa/extras/ooxmlimport/ooxmlimport.cxx  |   11 
 writerfilter/source/dmapper/DomainMapper.cxx  |8 +++---
 writerfilter/source/dmapper/DomainMapper_Impl.cxx |   21 +++
 writerfilter/source/dmapper/DomainMapper_Impl.hxx |   29 +++---
 5 files changed, 56 insertions(+), 13 deletions(-)

New commits:
commit eaa9cf6a3069fba3d82c046f0041bfb537d9e648
Author: Vasily Melenchuk 
Date:   Fri Aug 18 22:14:08 2017 +0300

tdf#43017: Support for DOCX hyperlinks character properties

Here goes a bunch of related changes:

1. Create new character style based on current character properties

2. Apply created style to hyperlink object

3. Fixes to predefined style names usage in w:rPr

4. Disable style usage for hyperlinks in TOC: they will receive later
anoter styles

Change-Id: I1a228992eb7c1e259a6a811aa7f959debaae4f35
Reviewed-on: https://gerrit.libreoffice.org/41784
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/sw/qa/extras/ooxmlimport/data/tdf43017.docx 
b/sw/qa/extras/ooxmlimport/data/tdf43017.docx
new file mode 100644
index ..c3372e11a0c8
Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/tdf43017.docx differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index 29e008b4d147..cafef1d2ee53 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -1548,6 +1548,17 @@ DECLARE_OOXMLIMPORT_TEST(testTdf111550, "tdf111550.docx")
 getCell(innerTable, "A1", "[outer:A2]\n[inner:A1]");
 }
 
+
+DECLARE_OOXMLIMPORT_TEST(testTdf43017, "tdf43017.docx")
+{
+uno::Reference xParagraph = getParagraph(1);
+uno::Reference xText = getRun(xParagraph, 2, "kick the 
bucket");
+
+// Ensure that hyperlink text color is not blue (0xff), but default 
(-1)
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Hyperlink color should be black!",
+sal_Int32(-1), getProperty(xText, "CharColor"));
+}
+
 // tests should only be added to ooxmlIMPORT *if* they fail round-tripping in 
ooxmlEXPORT
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index 4d034cab669a..a8eff5e63165 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -2207,11 +2207,11 @@ void DomainMapper::sprmWithProps( Sprm& rSprm, const 
PropertyMapPtr& rContext )
 {
 OUString sConvertedName( 
m_pImpl->GetStyleSheetTable()->ConvertStyleName( sStringValue, true ) );
 // First check if the style exists in the document.
-StyleSheetEntryPtr pEntry = m_pImpl->GetStyleSheetTable( 
)->FindStyleSheetByStyleName( sConvertedName );
+StyleSheetEntryPtr pEntry = m_pImpl->GetStyleSheetTable( 
)->FindStyleSheetByConvertedStyleName( sConvertedName );
 bool bExists = pEntry.get( ) && ( pEntry->nStyleTypeCode == 
STYLE_TYPE_CHAR );
-
-// Add the property if the style exists
-if ( bExists && m_pImpl->GetTopContext() )
+// Add the property if the style exists, but do not add it 
elements in TOC:
+// they will receive later another style references from TOC
+if ( bExists && m_pImpl->GetTopContext() && !m_pImpl->IsInTOC())
 m_pImpl->GetTopContext()->Insert( PROP_CHAR_STYLE_NAME, 
uno::makeAny( sConvertedName ) );
 }
 break;
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 823450f2aab8..9bc53f2f4b90 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -1383,7 +1383,18 @@ void DomainMapper_Impl::appendTextPortion( const 
OUString& rString, const Proper
 }
 }
 else
+{
+if (IsOpenField() && GetTopFieldContext()->GetFieldId() == 
FIELD_HYPERLINK)
+{
+// It is content of hyperlink field. We need to create 
and remember
+// character style for later applying to hyperlink
+PropertyValueVector_t aProps = 
comphelper::sequenceToContainer< PropertyValueVector_t 
>(GetTopContext()->GetPropertyValues());
+OUString sHyperlinkStyleName = 
GetStyleSheetTable()->getOrCreateCharStyle(aProps, /*bAlwaysCreate=*/false);
+
GetTopFieldContext()->SetHyperlinkStyle(sHyperlinkStyleName);
+}
+
 xTextRange = xTextAppend->appendTextPortion(rString, 
aValues);
+}
 }
 
 CheckRedline( xTextRange );
@@ -3708,6 

[Libreoffice-bugs] [Bug 103799] FILEOPEN PPTX: Impress ignores background color

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103799

--- Comment #4 from Ofir  ---
Still reproducible with LO 6.0.0.0.alpha1.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103798] FILEOPEN: PPTX wrong text order in RTL textbox

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103798

--- Comment #6 from Ofir  ---
Still reproducible with LO 6.0.0.0.alpha1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113617] Subform Postgresql "The column index out of range: 1, number of columns: 0

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113617

--- Comment #3 from jeffsum...@mail.com ---
(In reply to Alex Thurgood from comment #2)
> Under Advanced Database Properties, is the "Replace named parameters by '?'"
> box ticked or not ?
> 
> Does it make any difference if you tick/untick  and try your subform again ?

Was not ticked initially, ticked it and the error is the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 102780] FILEOPEN: Hebrew characters in EMF renders as other symbols

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102780

--- Comment #4 from Ofir  ---
Still reproducible with LO 6.0.0.0.alpha1.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 101569] FILEOPEN: PPTX import WordArt is invisible

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101569

--- Comment #5 from Ofir  ---
Still reproducible with LO 6.0.0.0.alpha1.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 100145] FILEOPEN: PPTX: Hide after animation doesn't work as expected

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100145

--- Comment #3 from Ofir  ---
Still reproducible with LO 6.0.0.0.alpha1 on Ubuntu 16.04.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 45497] FILEOPEN .pptx: VIEWING of complex 3-D rotation and shadow effect for picture incorrect

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45497

--- Comment #10 from Ofir  ---
Still reproducible with LO 6.0.0.0.alpha1 on Ubuntu 16.04.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 97825] SmartArt one-by-one Animation lost in PPTX import

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=97825

--- Comment #3 from Ofir  ---
Still reproducible with LO 6.0.0.0.alpha1 on Ubuntu 16.04.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 90140] FORMATTING/FILEOPEN: Add support PPTX files with multiple columns

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90140

--- Comment #3 from Ofir  ---
Reproducible with LO 6.0.0.0.alpha1 on Ubuntu 16.04.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94947] MotionPath animation of type Curve shows as Appear animation in the UI

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94947

--- Comment #3 from Ofir  ---
Reproducible with LO 6.0.0.0.alpha1 on Ubuntu 16.04.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113313] Highlighting isn’t drawn in the backgro =?UTF-8?Q?und?=, but instead even in front of adjacent glyphs

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113313

--- Comment #11 from Mohamed  ---
(In reply to Dieter Praas from comment #9)
> I also don't understand, why you confirmed it and changed it back to
> unconfirmed => set to NEW again

I am sorry, it was a mistake. Somebody was saving changes at the same time and
I got notification to merge it with mine.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93681] FILEOPEN: PPTX Import reverse order of columns in a right-to-left table

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93681

--- Comment #6 from Ofir  ---
Still reproducible with LO 6.0.0.0.alpha1 on Ubuntu 16.04.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 92641] Parentheses order wrong when a line with text direction Right-to-left starts with LTR characters

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=92641

--- Comment #12 from Ofir  ---
Omer, this is a bug. Try to load the attached PPTX in Impress and compare it to
PowerPoint.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 91388] Text upside down after pptx with Smart Art is saved to odp

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91388

--- Comment #7 from Ofir  ---
Still reproducible with LO 6.0.0.0.alpha1 on Ubuntu 16.04

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 91347] Placeholder is visible in SVG export

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91347

--- Comment #8 from Ofir  ---
Still reproducible with LO 6.0.0.0.alpha1 on Ubuntu 16.04.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 91252] Export of area fill gradients to paths for PDF (and EPS) are too coarse

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91252

--- Comment #10 from Ofir  ---
Still reproducible with LO 6.0.0.0.alpha1 on Ubuntu 16.04.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 91208] FILEOPEN Arial (Body) in pptx import causes text to wrap

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91208

--- Comment #11 from Ofir  ---
Still reproducible with LO 6.0.0.0.alpha1.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 80181] FILEOPEN: bad display of .pptx background color

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=80181

--- Comment #11 from Ofir  ---
Still reproducible with LO  6.0.0.0.alpha1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64095] VIEWING: LibreOffice Adds Non Existent Text Frame to .doc - resulting in bad layout

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=64095

--- Comment #10 from Ofir  ---
Still reproducible with LO  6.0.0.0.alpha1 on Ubuntu 16.04.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 62185] FORMATTING: text reflections lost in .PPTX export

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=62185

--- Comment #9 from Ofir  ---
Still reproducible with 6.0.0.0.alpha1 on Ubuntu 16.04.

Title should say import instead of export.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 77747] Latin text bullets in a list instead of Hebrew in .ppt

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=77747

--- Comment #8 from Ofir  ---
Still reproducible with LO 6.0.0.0.alpha1 on Ubuntu 16.04.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 77746] Missing list indentation in a pptx

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=77746

--- Comment #8 from Ofir  ---
Still reproducible:

Version: 6.0.0.0.alpha1
Build ID: c1d1f859b268f650143d48f294999cda0fa57350
CPU threads: 1; OS: Linux 4.10; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51733] Update icons for high-resolution HiDPI / Retina display

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=51733

Aleix  changed:

   What|Removed |Added

 CC||ki...@communia.org

--- Comment #18 from Aleix  ---
Created attachment 137653
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137653=edit
Screenshot of writer on m3800 with Hidpi screen, Icons are smooth.

As by now svg icons are supported (since
https://listarchives.libreoffice.org/global/design/msg07988.html). I can make
it work the provided breeze svg icon set from
https://cgit.freedesktop.org/libreoffice/core/tree/icon-themes/breeze_svg .
Finally a good looking lo in a hidpi screen :) ... 
I have created a git repo to push the icon set, The steps to make it work are
explained there: 
https://github.com/aleixq/images_breeze_svg_hidpi

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 77743] FILEOPEN: symbols missing in .pptx import

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=77743

--- Comment #11 from Ofir  ---
Reproducible with:

Version: 6.0.0.0.alpha1
Build ID: c1d1f859b268f650143d48f294999cda0fa57350
CPU threads: 1; OS: Linux 4.10; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 106073] FILEOPEN: DOCX has a different page count in LibreOffice

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106073

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
Summary|DOCX has a different page   |FILEOPEN: DOCX has a
   |count in LibreOffice|different page count in
   ||LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94598] FILEOPEN: Tables in Word document collapsed

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94598

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
Summary|Tables in Word document |FILEOPEN: Tables in Word
   |collapsed   |document collapsed

--- Comment #12 from Xisco Faulí  ---
Still reproducible in

Version: 6.0.0.0.alpha1+
Build ID: f5765d9f621bdc8fd0e1ac5eec1dcab9ae5b5d06
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: th-TH (ca_ES.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113742] FILEOPEN: DOCX: Frames not placed correctly

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113742

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||filter:docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113742] FILEOPEN: DOCX: Frames not placed correctly

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113742

Xisco Faulí  changed:

   What|Removed |Added

Summary|Frames not placed correctly |FILEOPEN: DOCX: Frames not
   |when opening this .docx |placed correctly
   |file|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113742] Frames not placed correctly when opening this .docx file

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113742

--- Comment #3 from Xisco Faulí  ---
Created attachment 137652
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137652=edit
LibreOffice 5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113742] Frames not placed correctly when opening this .docx file

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113742

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|UNCONFIRMED |NEW
 CC||r...@post.cz
Version|5.4.2.2 release |5.3.0.0.alpha1+
 Ever confirmed|0   |1

--- Comment #2 from Xisco Faulí  ---
it seems it was much better in

Version: 5.0.0.0.alpha1+
Build ID: 0db96caf0fcce09b87621c11b584a6d81cc7df86
Locale: ca-ES (ca_ES.UTF-8)

than in

Version: 6.0.0.0.alpha1+
Build ID: f5765d9f621bdc8fd0e1ac5eec1dcab9ae5b5d06
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: th-TH (ca_ES.UTF-8); Calc: group

or

Version: 5.2.0.0.alpha1+
Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; 
Locale: ca-ES (ca_ES.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113742] Frames not placed correctly when opening this .docx file

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113742

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Created attachment 137651
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137651=edit
comparison MSO 2010 and LibreOffice 6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/source

2017-11-09 Thread Eike Rathke
 sc/source/filter/inc/tokstack.hxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 7f603dd111afcc30eec8bbec97efc16ad8b4c4d1
Author: Eike Rathke 
Date:   Thu Nov 9 23:33:50 2017 +0100

Add values to SAL_WARN output

Change-Id: I7cfca9d920fd8e060ad984df05d62ae82bad4766

diff --git a/sc/source/filter/inc/tokstack.hxx 
b/sc/source/filter/inc/tokstack.hxx
index d0b2a59f2173..759e83e88f62 100644
--- a/sc/source/filter/inc/tokstack.hxx
+++ b/sc/source/filter/inc/tokstack.hxx
@@ -301,7 +301,7 @@ inline TokenStack ::operator <<( const TokenId& 
rNewId )
 }
 else
 {
-SAL_WARN("sc.filter", "*TokenStack::<<(): Stack overflow");
+SAL_WARN("sc.filter", "*TokenStack::<<(): Stack overflow for " << 
static_cast(rNewId));
 }
 
 return *this;
@@ -332,7 +332,7 @@ inline TokenPool& TokenPool::operator <<( const TokenId& 
rId )
 // rId -> ( sal_uInt16 ) rId - 1;
 if ((sal_uInt16)rId >= nScTokenOff)
 {
-SAL_WARN("sc.filter", "-TokenPool::operator <<: TokenId in 
DefToken-Range!");
+SAL_WARN("sc.filter", "-TokenPool::operator <<: TokenId in 
DefToken-Range! " << static_cast(rId));
 }
 
 if( nP_IdAkt >= nP_Id )
@@ -349,7 +349,7 @@ inline TokenPool& TokenPool::operator <<( const DefTokenId 
eId )
 {
 if ((sal_uInt32)eId + nScTokenOff >= 0x)
 {
-SAL_WARN("sc.filter", "-TokenPool::operator<<: enum too large!" );
+SAL_WARN("sc.filter", "-TokenPool::operator<<: enum too large! " << 
static_cast(eId));
 }
 
 if( nP_IdAkt >= nP_Id )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 113730] Arrow keys inverted in the "fuse cells" popup

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113730

Jacques Guilleron  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||guillero...@aol.com
 Ever confirmed|0   |1

--- Comment #1 from Jacques Guilleron  ---
Hi didi,

I don't reproduce with
LO  6.0.0.0.alpha1+ Build ID: 380d6afe5fd691f6ad4b17fc38b79b9fca4ba906
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@39, Branch:master, Time: 2017-10-22_09:58:27
Locale: fr-FR (fr_FR); Calc: CL
I Reach each item by using the up or down arrow two times.
Does it work this way for you too?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/source

2017-11-09 Thread Eike Rathke
 sc/source/filter/inc/tokstack.hxx |   29 +++--
 1 file changed, 19 insertions(+), 10 deletions(-)

New commits:
commit cf36b5d5f598d9b5528b273858584e2b419b23e9
Author: Eike Rathke 
Date:   Thu Nov 9 20:12:34 2017 +0100

Make this breakable in a debugger

Change-Id: I5db40b513de43a27a2e58937ea2ad9501d432917

diff --git a/sc/source/filter/inc/tokstack.hxx 
b/sc/source/filter/inc/tokstack.hxx
index d07aaef1ae56..d0b2a59f2173 100644
--- a/sc/source/filter/inc/tokstack.hxx
+++ b/sc/source/filter/inc/tokstack.hxx
@@ -276,13 +276,13 @@ class TokenStack
 
 inline const TokenId TokenStack::Get()
 {
-OSL_ENSURE( nPos > 0,
-"*TokenStack::Get(): is empty, is empty, ..." );
-
 TokenId nRet;
 
 if( nPos == 0 )
+{
+SAL_WARN("sc.filter", "*TokenStack::Get(): is empty, is empty, ...");
 nRet = 0;
+}
 else
 {
 nPos--;
@@ -294,25 +294,30 @@ inline const TokenId TokenStack::Get()
 
 inline TokenStack ::operator <<( const TokenId& rNewId )
 {// Element on Stack
-OSL_ENSURE( nPos < nSize, "*TokenStack::<<(): Stack overflow" );
 if( nPos < nSize )
 {
 pStack[ nPos ] = rNewId;
 nPos++;
 }
+else
+{
+SAL_WARN("sc.filter", "*TokenStack::<<(): Stack overflow");
+}
 
 return *this;
 }
 
 inline void TokenStack::operator >>( TokenId& rId )
 {// Element of Stack
-OSL_ENSURE( nPos > 0,
-"*TokenStack::>>(): is empty, is empty, ..." );
 if( nPos > 0 )
 {
 nPos--;
 rId = pStack[ nPos ];
 }
+else
+{
+SAL_WARN("sc.filter", "*TokenStack::>>(): is empty, is empty, ...");
+}
 }
 
 inline void TokenStack::Reset()
@@ -325,8 +330,10 @@ inline TokenPool& TokenPool::operator <<( const TokenId& 
rId )
 // POST: rId's are stored consecutively in Pool under a new Id;
 //   finalize with >> or Store()
 // rId -> ( sal_uInt16 ) rId - 1;
-OSL_ENSURE( ( sal_uInt16 ) rId < nScTokenOff,
-"-TokenPool::operator <<: TokenId in DefToken-Range!" );
+if ((sal_uInt16)rId >= nScTokenOff)
+{
+SAL_WARN("sc.filter", "-TokenPool::operator <<: TokenId in 
DefToken-Range!");
+}
 
 if( nP_IdAkt >= nP_Id )
 if (!GrowId())
@@ -340,8 +347,10 @@ inline TokenPool& TokenPool::operator <<( const TokenId& 
rId )
 
 inline TokenPool& TokenPool::operator <<( const DefTokenId eId )
 {
-OSL_ENSURE( ( sal_uInt32 ) eId + nScTokenOff < 0x,
-"-TokenPool::operator<<: enum too large!" );
+if ((sal_uInt32)eId + nScTokenOff >= 0x)
+{
+SAL_WARN("sc.filter", "-TokenPool::operator<<: enum too large!" );
+}
 
 if( nP_IdAkt >= nP_Id )
 if (!GrowId())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 93789] text background color not displayed in slide show

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93789

--- Comment #35 from mattreecebent...@gmail.com ---
Valid point

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93789] text background color not displayed in slide show

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93789

--- Comment #34 from Dr. David Alan Gilbert  ---
(In reply to mattreecebentley from comment #33)
> You want to remove the ability to show a slideshow in the program designed
> to show slideshows? :):):) :D

No, but removing the ability to set background colours on the text might be an
option if they never work.
(The downside is that means you wouldn't be able to remove background colours
already set/imported)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113746] Bug with click mouse

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113746

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Thank you for reporting the bug. To be certain the reported issue is not
related to corruption in the user profile, could you please reset your
Libreoffice profile ( https://wiki.documentfoundation.org/UserProfile ) and
re-test?

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the issue is still present

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89466] [META] SIDEBAR: Slide and Page content panels in Properties tab in Impress/Draw

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89466

Xisco Faulí  changed:

   What|Removed |Added

 Depends on||113747


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113747
[Bug 113747] Sidebar: master slide dropdown get empty after changing the view
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113747] Sidebar: master slide dropdown get empty after changing the view

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113747

Xisco Faulí  changed:

   What|Removed |Added

 Blocks||89466


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=89466
[Bug 89466] [META] SIDEBAR: Slide and Page content panels in Properties tab in
Impress/Draw
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113747] New: Sidebar: master slide dropdown get empty after changing the view

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113747

Bug ID: 113747
   Summary: Sidebar: master slide dropdown get empty after
changing the view
   Product: LibreOffice
   Version: 5.3.0.0.alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Steps to reproduce:
1. Launch Impress
2. Go to View - Outline
3. Go to View - Normal

Observed behaviour: Master Slide dropdown in sidebar is empty

Reproduced in

Version: 6.0.0.0.alpha1+
Build ID: f5765d9f621bdc8fd0e1ac5eec1dcab9ae5b5d06
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: th-TH (ca_ES.UTF-8); Calc: group

It seems the code hasn't change since it was originally introduced in commit
https://cgit.freedesktop.org/libreoffice/core/commit/?id=833088b1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113112] EDITING: Adding a new sheet before a existing large sheet is pretty slow

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113112

--- Comment #3 from Telesto  ---
Created attachment 137650
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137650=edit
Additional example

Additional example

1. Open the attached file
2. Move empty sheet 'Tabelle2' after 'Tabelle3' using drag an drop

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108526] Calc not Win10 DPI aware, display elements missing on 4K screen

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108526

Aron Budea  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: extras/source

2017-11-09 Thread heiko tietze
 extras/source/templates/presnt/Blueprint_Plans.otp |binary
 extras/source/templates/presnt/Portfolio.otp   |binary
 extras/source/templates/presnt/Progress.otp|binary
 extras/source/templates/presnt/Vintage.otp |binary
 4 files changed

New commits:
commit 82331a914d3544f06e471c48ac2aaf5cf201daca
Author: heiko tietze 
Date:   Tue Oct 31 10:47:24 2017 +0100

Language and country tags removed from temple

Change-Id: I53370561948a41f35974597edd3e7555d2b4ff9b
Reviewed-on: https://gerrit.libreoffice.org/44107
Reviewed-by: Heiko Tietze 
Tested-by: Heiko Tietze 

diff --git a/extras/source/templates/presnt/Blueprint_Plans.otp 
b/extras/source/templates/presnt/Blueprint_Plans.otp
index 939af570b158..4b71eaf60269 100644
Binary files a/extras/source/templates/presnt/Blueprint_Plans.otp and 
b/extras/source/templates/presnt/Blueprint_Plans.otp differ
diff --git a/extras/source/templates/presnt/Portfolio.otp 
b/extras/source/templates/presnt/Portfolio.otp
index 9ee2b5eed52e..8f6187a21f93 100644
Binary files a/extras/source/templates/presnt/Portfolio.otp and 
b/extras/source/templates/presnt/Portfolio.otp differ
diff --git a/extras/source/templates/presnt/Progress.otp 
b/extras/source/templates/presnt/Progress.otp
index 9f636a169588..b5d90215cc6b 100644
Binary files a/extras/source/templates/presnt/Progress.otp and 
b/extras/source/templates/presnt/Progress.otp differ
diff --git a/extras/source/templates/presnt/Vintage.otp 
b/extras/source/templates/presnt/Vintage.otp
index 13c7a0404524..7ef5628d68d7 100644
Binary files a/extras/source/templates/presnt/Vintage.otp and 
b/extras/source/templates/presnt/Vintage.otp differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 113660] Wrong label on sidebar slide pane after switching to handout view

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113660

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||xiscofa...@libreoffice.org
   Assignee|libreoffice-b...@lists.free |xiscofa...@libreoffice.org
   |desktop.org |

--- Comment #3 from Xisco Faulí  ---
Patch in gerrit: https://gerrit.libreoffice.org/#/c/44567/.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112627] 'Master Slide' label disappears from Slide content panel after context change

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112627

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |xiscofa...@libreoffice.org
   |desktop.org |

--- Comment #6 from Xisco Faulí  ---
Patch in gerrit: https://gerrit.libreoffice.org/#/c/44566/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 109236] [META] CSV import bugs and enhancements

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109236
Bug 109236 depends on bug 89683, which changed state.

Bug 89683 Summary: delimited text files  ('csv', 'tsv', etc.) are opened as 
text documents if Writer is the active window
https://bugs.documentfoundation.org/show_bug.cgi?id=89683

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89683] delimited text files ('csv', 'tsv', etc.) are opened as text documents if Writer is the active window

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89683

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 Status|NEW |RESOLVED
 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|
 Resolution|--- |WONTFIX

--- Comment #21 from Heiko Tietze  ---
We had a hot discussion during the design meeting. There are arguments for both
options and people are split. The safest way is to keep the current behavior,
so WF.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 89683] delimited text files ('csv', 'tsv', etc.) are opened as text documents if Writer is the active window

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89683

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 Status|NEW |RESOLVED
 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|
 Resolution|--- |WONTFIX

--- Comment #21 from Heiko Tietze  ---
We had a hot discussion during the design meeting. There are arguments for both
options and people are split. The safest way is to keep the current behavior,
so WF.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-ux-advise] [Bug 113235] Better wording for "Tools > Options > Calc > General .. Use legacy cursor movement behavior when selecting"

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113235

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|

--- Comment #8 from Heiko Tietze  ---
Design team recommends to use 'Excel multiple cell keyboard selection'.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 104267] change outlines selection for tables and cells

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104267

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 Status|NEW |RESOLVED
 CC||tietze.he...@gmail.com
 Resolution|--- |WONTFIX

--- Comment #4 from Heiko Tietze  ---
We discussed the proposal in the design meeting. The implementation effort
seems to be quite hight for not much benefit (actually the use case is not
clear). So the decision was to resolve this as wontfix.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 86508] Change default colors for conditional formatting color scales

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=86508

--- Comment #18 from Heiko Tietze  ---
Decision in the design meeting was to use "Yellow Light 3" and "Yellow Green 3"
from the new standard palette.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93789] text background color not displayed in slide show

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93789

--- Comment #33 from mattreecebent...@gmail.com ---
You want to remove the ability to show a slideshow in the program designed to
show slideshows? :):):) :D

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113661] Bottom of the button is cut off on sidebar after switching back from handout view

2017-11-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113661

Tamás Zolnai  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Tamás Zolnai  ---


*** This bug has been marked as a duplicate of bug 113725 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   3   4   >