date:20171122

[Libreoffice-commits] core.git: 3 commits - include/LibreOfficeKit ios/CustomTarget_iOS.mk ios/CustomTarget_iOS_setup.mk ios/LibreOfficeKit ios/loKit.xcconfig.in ios/Module_ios.mk ios/source ios/Stati

2017-11-22 Thread jan Iversen

 include/LibreOfficeKit/LibreOfficeKitInit.h |1 
 ios/CustomTarget_iOS_setup.mk   |   88 ---
 ios/LibreOfficeKit/LibreOfficeKit.xcodeproj/project.pbxproj |  334 
 ios/Module_ios.mk   |3 
 ios/StaticLibrary_iOSkit.mk |   31 +
 ios/loKit.xcconfig.in   |   19 
 ios/source/LibreOfficeKit.c |8 
 7 files changed, 50 insertions(+), 434 deletions(-)

New commits:
commit ed885a3cdbfc4b4d194d40508a29334b9780858f
Author: jan Iversen 
Date:   Thu Nov 23 08:47:59 2017 +0100

iOS, do not use different C compilers

LibreOfficeKit.c was compiled with an xcode project and not like
all other sources. Changed to use clang with same switches as
rest of LO.

Separated resource generation in own makefile

Removed project LibreOfficeKit which was responsible for prelink.

Change-Id: Iaf9fbb4b652501af0b7f3643ed3efcc2ed93b611

diff --git a/ios/CustomTarget_iOS.mk b/ios/CustomTarget_iOS_setup.mk
similarity index 55%
rename from ios/CustomTarget_iOS.mk
rename to ios/CustomTarget_iOS_setup.mk
index a9fb058db406..a1ae23e0fa3e 100644
--- a/ios/CustomTarget_iOS.mk
+++ b/ios/CustomTarget_iOS_setup.mk
@@ -8,43 +8,20 @@
 #- Env 
 IOSGEN := $(SRCDIR)/ios/generated
 IOSRES := $(IOSGEN)/resources
-IOSKITXC := $(WORKDIR)/ios/loKit.xcconfig
 IOSAPPXC := $(WORKDIR)/ios/loApp.xcconfig
-IOSKITSRC := $(SRCDIR)/ios/LibreOfficeKit/LibreOfficeKit
-IOSAPPSRC := $(SRCDIR)/ios/LibreOfficeLight/LibreOfficeLight
-IOSKITPRJ := $(SRCDIR)/ios/LibreOfficeKit/LibreOfficeKit.xcodeproj
-IOSAPPPRJ := $(SRCDIR)/ios/LibreOfficeLight/LibreOfficeLight.xcodeproj
-IOSAPP := $(INSTDIR)/LibreOfficeLight.app
-ifeq ($(ENABLE_DEBUG),TRUE)
-IOSKIT := libLibreOfficeKit_$(CPUNAME)_debug.a
-else
-IOSKIT := libLibreOfficeKit_$(CPUNAME).a
-endif
 
 
 #- Top level  -
-$(eval $(call gb_CustomTarget_CustomTarget,ios/ios))
+$(eval $(call gb_CustomTarget_CustomTarget,ios/ios_setup))
 
-$(call gb_CustomTarget_get_target,ios/ios): $(IOSGEN)/$(IOSKIT)
 
 
+$(call gb_CustomTarget_get_target,ios/ios_setup): $(IOSAPPXC) 
$(IOSGEN)/native-code.h
 
 
-#- Generate xcconfig files  ---
-$(IOSKITXC): $(SRCDIR)/ios/loKit.xcconfig.in $(BUILDDIR)/config_host.mk 
$(SRCDIR)/ios/CustomTarget_iOS.mk
-   $(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),ENV,2)
-   @mkdir -p $(WORKDIR)/ios
-   sed -e "s'@BUILDDIR@'$(BUILDDIR)'g" \
-   -e "s'@INSTDIR@'$(INSTDIR)'g" \
-   -e "s'@SRCDIR@'$(SRC_ROOT)'g" \
-   -e "s'@WORKDIR@'$(WORKDIR)'g" \
-   -e "s'@CFLAGS@'$(gb_GLOBALDEFS)'g" \
-   -e "s'@CPLUSPLUSFLAGS@'$(gb_GLOBALDEFS)'g" \
-   -e "s'@SYMROOT@'$(WORKDIR)/ios/build'g" \
-   -e "s'@PRELINK@'`$(SRCDIR)/bin/lo-all-static-libs`'g" \
-   $(SRCDIR)/ios/loKit.xcconfig.in > $(WORKDIR)/ios/loKit.xcconfig
 
-$(IOSAPPXC): $(SRCDIR)/ios/loKit.xcconfig.in $(BUILDDIR)/config_host.mk 
$(SRCDIR)/ios/CustomTarget_iOS.mk
+#- Generate dynamic files  ---
+$(IOSAPPXC): $(SRCDIR)/ios/loApp.xcconfig.in $(BUILDDIR)/config_host.mk 
$(SRCDIR)/ios/CustomTarget_iOS_setup.mk
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),ENV,2)
@mkdir -p $(WORKDIR)/ios
sed -e "s'@BUILDDIR@'$(BUILDDIR)'g" \
@@ -54,9 +31,11 @@ $(IOSAPPXC): $(SRCDIR)/ios/loKit.xcconfig.in 
$(BUILDDIR)/config_host.mk $(SRCDIR
-e "s'@CFLAGS@'$(gb_GLOBALDEFS)'g" \
-e "s'@CPLUSPLUSFLAGS@'$(gb_GLOBALDEFS)'g" \
-e "s'@SYMROOT@'$(WORKDIR)/ios/build'g" \
-   $(SRCDIR)/ios/loApp.xcconfig.in > $(WORKDIR)/ios/loApp.xcconfig
+   $(SRCDIR)/ios/loApp.xcconfig.in > $(IOSAPPXC)
+
+
 
-$(IOSGEN)/native-code.h: $(BUILDDIR)/config_host.mk 
$(SRCDIR)/ios/CustomTarget_iOS.mk
+$(IOSGEN)/native-code.h: $(BUILDDIR)/config_host.mk 
$(SRCDIR)/ios/CustomTarget_iOS_setup.mk
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),ENV,2)
mkdir -p $(IOSGEN) $(IOSRES) $(IOSRES)/services \
 $(IOSRES)/share/config $(IOSRES)/share/filter 
$(IOSRES)/program \
@@ -113,59 +92,12 @@ $(IOSGEN)/native-code.h: $(BUILDDIR)/config_host.mk 
$(SRCDIR)/ios/CustomTarget_i
echo "buildid=$(BUILDID)"   >> $(IOSRES)/program/versionrc
 
 
-#- build  -
-$(IOSGEN)/$(IOSKIT): $(IOSKITXC) $(IOSAPPXC) $(IOSGEN)/native-code.h 
STAT_LIB_DEPEND
-   $(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),APP,2)
-   CC=; \
-   $(call gb_Helper_print_on_error, \
-   xcodebuild \
-   -xcconfig $(IOSKITXC) \
-

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - svx/source

2017-11-22 Thread Julien Nabet

 svx/source/tbxctrls/tbcontrl.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 439a6e7c7e32089810b878dca77fa64ee454a596
Author: Julien Nabet 
Date:   Tue Sep 19 20:41:13 2017 +0200

tdf#111894: fix leak memory with PaletteManager (take 2)

Thanks to Maxim Monastirsky for the suggestion!

Change-Id: I6ab799848f80f785fd24905c0a540885c41afb86
Reviewed-on: https://gerrit.libreoffice.org/42494
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 
(cherry picked from commit 46fa042b94a0364c09482e8a09f8874119db231c)
Reviewed-on: https://gerrit.libreoffice.org/42610
Reviewed-by: David Tardon 

diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index 628bacad7065..5ef9cf378206 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -3230,7 +3230,7 @@ void SvxColorListBox::EnsurePaletteManager()
 if (!m_xPaletteManager)
 {
 m_xPaletteManager.reset(new PaletteManager);
-m_xPaletteManager->SetColorSelectFunction(m_aColorWrapper);
+m_xPaletteManager->SetColorSelectFunction(std::ref(m_aColorWrapper));
 m_xPaletteManager->SetLastColor(m_aSelectedColor.first);
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/test qadevOOo/Jar_OOoRunner.mk qadevOOo/objdsc qadevOOo/tests sc/qa test/Library_subsequenttest.mk test/source

2017-11-22 Thread Jens Carl

 include/test/sheet/xsheetauditing.hxx   |   38 +
 qadevOOo/Jar_OOoRunner.mk   |1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetObj.csv |7 
 qadevOOo/tests/java/ifc/sheet/_XSheetAuditing.java  |  195 
--
 sc/qa/extras/sctablesheetobj.cxx|   20 -
 test/Library_subsequenttest.mk  |1 
 test/source/sheet/xsheetauditing.cxx|  136 ++
 7 files changed, 192 insertions(+), 206 deletions(-)

New commits:
commit 39c5ade7bbb444eb204015955276748a5b381ad9
Author: Jens Carl 
Date:   Thu Nov 23 01:50:39 2017 +

tdf#45904 Move _XSheetAuditing Java tests to C++

Change-Id: I057447494ff488546d43d2d3068a65d5c0d402e0
Reviewed-on: https://gerrit.libreoffice.org/45120
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/include/test/sheet/xsheetauditing.hxx 
b/include/test/sheet/xsheetauditing.hxx
new file mode 100644
index ..44c1ddd5c5d5
--- /dev/null
+++ b/include/test/sheet/xsheetauditing.hxx
@@ -0,0 +1,38 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#ifndef INCLUDED_TEST_SHEET_XSHEETAUDITING_HXX
+#define INCLUDED_TEST_SHEET_XSHEETAUDITING_HXX
+
+#include 
+#include 
+
+#include 
+
+namespace apitest
+{
+class OOO_DLLPUBLIC_TEST XSheetAuditing
+{
+public:
+virtual css::uno::Reference init() = 0;
+
+void testShowHideDependents();
+void testShowHidePrecedents();
+void testShowErrors();
+void testShowInvalid();
+void testClearArrows();
+
+protected:
+~XSheetAuditing() {}
+};
+}
+
+#endif // INCLUDED_TEST_SHEET_XSHEETAUDITING_HXX
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk
index 9faab8d10327..f8d6b4a5ecd8 100644
--- a/qadevOOo/Jar_OOoRunner.mk
+++ b/qadevOOo/Jar_OOoRunner.mk
@@ -611,7 +611,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\
 qadevOOo/tests/java/ifc/sheet/_XScenario \
 qadevOOo/tests/java/ifc/sheet/_XScenarioEnhanced \
 qadevOOo/tests/java/ifc/sheet/_XSheetAnnotationAnchor \
-qadevOOo/tests/java/ifc/sheet/_XSheetAuditing \
 qadevOOo/tests/java/ifc/sheet/_XSheetCellCursor \
 qadevOOo/tests/java/ifc/style/_CharacterProperties \
 qadevOOo/tests/java/ifc/style/_CharacterPropertiesAsian \
diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetObj.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetObj.csv
index 9c5a9b9fe29f..6f434c9b484c 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetObj.csv
@@ -142,13 +142,6 @@
 
"ScTableSheetObj";"com::sun::star::sheet::XCellRangesQuery";"queryColumnDifferences()"
 
"ScTableSheetObj";"com::sun::star::sheet::XCellRangesQuery";"queryRowDifferences()"
 
"ScTableSheetObj";"com::sun::star::sheet::XCellRangesQuery";"queryIntersection()"
-"ScTableSheetObj";"com::sun::star::sheet::XSheetAuditing";"hideDependents()"
-"ScTableSheetObj";"com::sun::star::sheet::XSheetAuditing";"hidePrecedents()"
-"ScTableSheetObj";"com::sun::star::sheet::XSheetAuditing";"showDependents()"
-"ScTableSheetObj";"com::sun::star::sheet::XSheetAuditing";"showPrecedents()"
-"ScTableSheetObj";"com::sun::star::sheet::XSheetAuditing";"showErrors()"
-"ScTableSheetObj";"com::sun::star::sheet::XSheetAuditing";"showInvalid()"
-"ScTableSheetObj";"com::sun::star::sheet::XSheetAuditing";"clearArrows()"
 "ScTableSheetObj";"com::sun::star::sheet::XScenario";"getIsScenario()"
 "ScTableSheetObj";"com::sun::star::sheet::XScenario";"getScenarioComment()"
 "ScTableSheetObj";"com::sun::star::sheet::XScenario";"setScenarioComment()"
diff --git a/qadevOOo/tests/java/ifc/sheet/_XSheetAuditing.java 
b/qadevOOo/tests/java/ifc/sheet/_XSheetAuditing.java
deleted file mode 100644
index 49665104abd2..
--- a/qadevOOo/tests/java/ifc/sheet/_XSheetAuditing.java
+++ /dev/null
@@ -1,195 +0,0 @@
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding

[Libreoffice-bugs] [Bug 112568] Slow typing in Writer after inserting png image, image repaints all the time

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112568

--- Comment #3 from GAJ  ---
Created attachment 137934
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137934=edit
Text document with 7 MB image for typing-delay testing

I have attached a 4 page odt document with an image on page 2 for testing the
issues.

When I open this document, scrolling and typing additional text on the first
page works fine. When after scrolling down until the image appears, scrolling
becomes sluggish. With the image on page 2 is in sight, typing text (on page 2)
appears very, very slow. when scrolling further down until the image is no
longer visible, both scrolling and typing are fine again.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #82 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=39c5ade7bbb444eb204015955276748a5b381ad9

tdf#45904 Move _XSheetAuditing Java tests to C++

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113858] Remove color palettes Breeze, Tango and LibreOffice

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113858

--- Comment #18 from k-j  ---
I'm doing a coming out: I use Breeze. It is the first work when I install a new
LibO on any computer.
Breeze is a simple, strict and strateful palette with no bonbon or childish
colouring or fat icons like all the others. And there is no alternative for it.
IMO we don't need:
Crystal
Galaxy

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113858] Remove color palettes Breeze, Tango and LibreOffice

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113858

--- Comment #17 from k-j  ---
(In reply to Yousuf Philips (jay) from comment #16)
> Not sure how you are defining 'all this work' as adding a palette of
> existing colors is a simple process.

But to create the icon set isn't. Andreas made these. And it was his entrance
to our community (AFAIK).
And at least the most people who leave our community are doing this because
some lonely guys decide to kick their work away.
So @all: Be careful, when you delete the palettes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114001] New: [UI] [NotebookBar] [Groupedbar] Functions that invoke the sidebar must be toggleable in Impress

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114001

Bug ID: 114001
   Summary: [UI] [NotebookBar] [Groupedbar] Functions that invoke
the sidebar must be toggleable in Impress
   Product: LibreOffice
   Version: 6.0.0.0.alpha1+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: diazbast...@openmailbox.org

Description:
Some functions available in Groupedbar (full or compact) invoke the sidebar,
but to return to the previous state you have to hide the sidebar manually.

My proposal is that these functions (Slide transition, Slide layout and
Animation) allow the sidebar to be toggled, similar to how "show the styles
sidebar" button works in Writer (the same principle is seen in "show draw
functions" even though it is related to a toolbar).

Steps to Reproduce:
1. In GroupedBar (Full or compact) select Slide transition, Slide layout or
Animation button.
2. Click again.

Actual Results:  
The sidebar expands showing the selected function. When you click the button
again, nothing happens.

Expected Results:
When you click on the function button the sidebar expands and when you make a
second click the sidebar collapses.


Reproducible: Always


User Profile Reset: No



Additional Info:
Within the previous listing would include the "master slide" button even if it
is not related to the sidebar (it would benefit other layouts such as tabbed
NotebookBar).


User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:57.0) Gecko/20100101
Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113997] the modification date field doesn' t show the modification date of the document

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113997

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
Can not reproduce. On Windows 10 Home 64-bit en-US with
Version: 5.4.3.1 (x64)
Build ID: 32c8895c6cae21571f364dbb059f419a743ee44d
CPU threads: 4; OS: Windows 6.19; UI render: GL; 
Locale: en-US (en_US); Calc: group

It is possible an old document may have field types that have been changed. But
in creating a new document launching the Insert -> Fields dialog. On its
DocInformation tab Modified -> Date|Time fields populate on insertion, and
update correctly on save. The same information is picked up in the document
Dublin Core meta data.

Please retest with a current 5.4.3 build.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113975] Expand the documentation for regular expressions

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113975

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #2 from V Stuart Foote  ---
Actually, LibreOffice's RegEx support is via ICU libraries, our documentation
comes from there including coverage of ICU RegEx Operators to lookahead and
lookbehind and their negatives--the Lookarounds

The Help now links to the Wiki
https://wiki.documentfoundation.org/Documentation/HowTo/Writer/Regular_Expressions
 or to
https://wiki.documentfoundation.org/Documentation/HowTo/Calc/Regular_Expressions
both of which correctly defer to the ICU content [1].

It is a little thin, but authoritative, and should be basis for addition to our
Help and Documentation--with some practical examples included, preferably on
our Wiki. The OOo era content at AOO should probably go away.


=-ref-=
[1]
http://userguide.icu-project.org/strings/regexp#TOC-Regular-Expression-Operators

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106784] Custom toolbar icons don't appear if sized bigger than "small "

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=106784

Rainer Bielefeld Retired  changed:

   What|Removed |Added

 CC||LibreOffice@bielefeldundbus
   ||s.de
Summary|Custom icons dont appear in |Custom toolbar icons don't
   |default sized toolbars  |appear if sized bigger than
   ||"small"

--- Comment #5 from Rainer Bielefeld Retired  
---
a) For me the effect is visible for any symbol (icon) size bigger than "small"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2017-11-22 Thread Stephan Bergmann

 sw/source/core/unocore/unoframe.cxx |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 0e2f224d07a0e7f542984d9e9f48c9cda86a80f6
Author: Stephan Bergmann 
Date:   Wed Nov 22 10:38:15 2017 +0100

An anonymous GraphicObject instance suffices here

Change-Id: I13156c3194497a2e554cdfe3a92a4ff83e0ea2f1
Reviewed-on: https://gerrit.libreoffice.org/45073
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/sw/source/core/unocore/unoframe.cxx 
b/sw/source/core/unocore/unoframe.cxx
index d3d527a8e2ca..76ea5752dc97 100644
--- a/sw/source/core/unocore/unoframe.cxx
+++ b/sw/source/core/unocore/unoframe.cxx
@@ -1661,8 +1661,7 @@ void SwXFrame::setPropertyValue(const OUString& 
rPropertyName, const ::uno::Any&
 OString sId(OUStringToOString(
 aGrfUrl.copy(sizeof(sGraphicObjectProtocol)-1),
 RTL_TEXTENCODING_ASCII_US));
-GraphicObject pGrfObj( sId );
-aGraphic = pGrfObj.GetGraphic();
+aGraphic = GraphicObject( sId ).GetGraphic();
 bApply = true;
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

2017-11-22 Thread Stephan Bergmann

 sw/source/core/unocore/unoframe.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit d7f2de780e73d23a80cc3d15f84f433d9d056685
Author: Stephan Bergmann 
Date:   Tue Nov 21 23:33:51 2017 +0100

put GraphicObject on stack instead of heap

Change-Id: Ia673a88a397d3a4e5c3b2ff31a60d04ea9e70d1f
Reviewed-on: https://gerrit.libreoffice.org/45062
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/sw/source/core/unocore/unoframe.cxx 
b/sw/source/core/unocore/unoframe.cxx
index a65b25e47c0c..d3d527a8e2ca 100644
--- a/sw/source/core/unocore/unoframe.cxx
+++ b/sw/source/core/unocore/unoframe.cxx
@@ -1661,8 +1661,8 @@ void SwXFrame::setPropertyValue(const OUString& 
rPropertyName, const ::uno::Any&
 OString sId(OUStringToOString(
 aGrfUrl.copy(sizeof(sGraphicObjectProtocol)-1),
 RTL_TEXTENCODING_ASCII_US));
-auto pGrfObj = o3tl::make_unique( sId );
-aGraphic = pGrfObj->GetGraphic();
+GraphicObject pGrfObj( sId );
+aGraphic = pGrfObj.GetGraphic();
 bApply = true;
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

2017-11-22 Thread Stephan Bergmann

 sw/source/core/unocore/unoframe.cxx |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 1f56087504e30ae81bd8e55b8f1364f326b75e76
Author: Stephan Bergmann 
Date:   Tue Nov 21 23:31:14 2017 +0100

reduce scope of var

Change-Id: If9f4974fa1bf664b14c81e243f7dcd36abd3a1ce
Reviewed-on: https://gerrit.libreoffice.org/45061
Tested-by: Stephan Bergmann 
Reviewed-by: Stephan Bergmann 

diff --git a/sw/source/core/unocore/unoframe.cxx 
b/sw/source/core/unocore/unoframe.cxx
index e2e8a0232ef8..a65b25e47c0c 100644
--- a/sw/source/core/unocore/unoframe.cxx
+++ b/sw/source/core/unocore/unoframe.cxx
@@ -1650,7 +1650,6 @@ void SwXFrame::setPropertyValue(const OUString& 
rPropertyName, const ::uno::Any&
 Graphic aGraphic;
 if( bURL )
 {
-std::unique_ptr pGrfObj;
 OUString aGrfUrl;
 aValue >>= aGrfUrl;
 
@@ -1662,7 +1661,7 @@ void SwXFrame::setPropertyValue(const OUString& 
rPropertyName, const ::uno::Any&
 OString sId(OUStringToOString(
 aGrfUrl.copy(sizeof(sGraphicObjectProtocol)-1),
 RTL_TEXTENCODING_ASCII_US));
-pGrfObj = o3tl::make_unique( sId );
+auto pGrfObj = o3tl::make_unique( sId );
 aGraphic = pGrfObj->GetGraphic();
 bApply = true;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

2017-11-22 Thread Stephan Bergmann

 sw/source/core/unocore/unoframe.cxx |   25 +++--
 1 file changed, 11 insertions(+), 14 deletions(-)

New commits:
commit c7e0f494bfc7a663f07769b8ed5de0b59bdd11da
Author: Stephan Bergmann 
Date:   Tue Nov 21 23:28:44 2017 +0100

use std::unique_ptr

Change-Id: I28e3f253cc8d0d35275c6aa3bcf17a93e2f0c631
Reviewed-on: https://gerrit.libreoffice.org/45060
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/sw/source/core/unocore/unoframe.cxx 
b/sw/source/core/unocore/unoframe.cxx
index 789c24eb1903..e2e8a0232ef8 100644
--- a/sw/source/core/unocore/unoframe.cxx
+++ b/sw/source/core/unocore/unoframe.cxx
@@ -31,6 +31,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -1576,7 +1577,7 @@ void SwXFrame::setPropertyValue(const OUString& 
rPropertyName, const ::uno::Any&
 {
 OUString sGrfName;
 OUString sFltName;
-GraphicObject *pGrfObj = nullptr;
+std::unique_ptr pGrfObj;
 SwDoc::GetGrfNms( *static_cast(pFormat), 
,  );
 OUString sTmp;
 aValue >>= sTmp;
@@ -1585,7 +1586,7 @@ void SwXFrame::setPropertyValue(const OUString& 
rPropertyName, const ::uno::Any&
 {
 if( sTmp.startsWith(sPackageProtocol) )
 {
-pGrfObj = new GraphicObject;
+pGrfObj = o3tl::make_unique();
 pGrfObj->SetUserData( sTmp );
 sGrfName.clear();
 }
@@ -1594,7 +1595,7 @@ void SwXFrame::setPropertyValue(const OUString& 
rPropertyName, const ::uno::Any&
 const OString sId(OUStringToOString(
 sTmp.copy(sizeof(sGraphicObjectProtocol)-1),
 RTL_TEXTENCODING_ASCII_US));
-pGrfObj = new GraphicObject( sId );
+pGrfObj = o3tl::make_unique( sId );
 sGrfName.clear();
 }
 else
@@ -1614,14 +1615,12 @@ void SwXFrame::setPropertyValue(const OUString& 
rPropertyName, const ::uno::Any&
 SwGrfNode* pGrfNode = aIdx.GetNode().GetGrfNode();
 if(!pGrfNode)
 {
-delete pGrfObj;
 throw uno::RuntimeException();
 }
 SwPaM aGrfPaM(*pGrfNode);
 pFormat->GetDoc()->getIDocumentContentOperations().ReRead( 
aGrfPaM, sGrfName, sFltName, nullptr,
-pGrfObj );
+pGrfObj.get() );
 }
-delete pGrfObj;
 }
 else if( FN_UNO_GRAPHIC == pEntry->nWID )
 {
@@ -1651,7 +1650,7 @@ void SwXFrame::setPropertyValue(const OUString& 
rPropertyName, const ::uno::Any&
 Graphic aGraphic;
 if( bURL )
 {
-GraphicObject *pGrfObj = nullptr;
+std::unique_ptr pGrfObj;
 OUString aGrfUrl;
 aValue >>= aGrfUrl;
 
@@ -1663,11 +1662,10 @@ void SwXFrame::setPropertyValue(const OUString& 
rPropertyName, const ::uno::Any&
 OString sId(OUStringToOString(
 aGrfUrl.copy(sizeof(sGraphicObjectProtocol)-1),
 RTL_TEXTENCODING_ASCII_US));
-pGrfObj = new GraphicObject( sId );
+pGrfObj = o3tl::make_unique( sId );
 aGraphic = pGrfObj->GetGraphic();
 bApply = true;
 }
-delete pGrfObj;
 }
 else
 {
@@ -2813,13 +2811,13 @@ void SwXFrame::attachToRange(const uno::Reference< 
text::XTextRange > & xTextRan
 UnoActionContext aCont(pDoc);
 const ::uno::Any* pGraphicURL;
 OUString sGraphicURL;
-GraphicObject *pGrfObj = nullptr;
+std::unique_ptr pGrfObj;
 if(pProps->GetProperty(FN_UNO_GRAPHIC_U_R_L, 0, pGraphicURL))
 {
 (*pGraphicURL) >>= sGraphicURL;
 if( sGraphicURL.startsWith(sPackageProtocol) )
 {
-pGrfObj = new GraphicObject;
+pGrfObj = o3tl::make_unique();
 pGrfObj->SetUserData( sGraphicURL );
 sGraphicURL.clear();
 }
@@ -2828,7 +2826,7 @@ void SwXFrame::attachToRange(const uno::Reference< 
text::XTextRange > & xTextRan
 OString sId(OUStringToOString(
 sGraphicURL.copy( sizeof(sGraphicObjectProtocol)-1 ),
 RTL_TEXTENCODING_ASCII_US));
-pGrfObj = new GraphicObject( sId );
+pGrfObj = o3tl::make_unique( sId );
 sGraphicURL.clear();
 }
 }
@@ -2851,12 +2849,11 @@ void SwXFrame::attachToRange(const uno::Reference< 
text::XTextRange > &

[Libreoffice-bugs] [Bug 84687] UI: Property mapping - deletion is neither registered nor effective

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=84687

--- Comment #6 from pierre-yves samyn  ---
Hi

Still reproduced on windows 7/64 & Version: 5.4.3.2 (x64)

Regards
Pierre-Yves

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113957] Fonts appear very pixelated on Impress presentations

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113957

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |DUPLICATE

--- Comment #3 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 107090 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107090] Text is poorly rendered to presentation mode canvas with default rendering and "Use hardware acceleration" enabled ( OpenGL and CPU only rendering is correct) (DirectWr

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107090

V Stuart Foote  changed:

   What|Removed |Added

 CC||rodrigoeir...@gmail.com

--- Comment #35 from V Stuart Foote  ---
*** Bug 113957 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/headless vcl/inc

2017-11-22 Thread Julien Nabet

 vcl/headless/svpframe.cxx |7 +++
 vcl/headless/svpvd.cxx|7 +++
 vcl/inc/headless/svpframe.hxx |3 ++-
 vcl/inc/headless/svpvd.hxx|4 ++--
 4 files changed, 10 insertions(+), 11 deletions(-)

New commits:
commit 4ccddab6ef74cb07c2998eaf420785eeceda5a8d
Author: Julien Nabet 
Date:   Wed Nov 22 20:39:13 2017 +0100

Replace some lists by vectors in vcl/headless

+use for range loops when loops included "std::list"

Change-Id: Ic261571ef64b1a710233ff949c4feeb3cc4756cd
Reviewed-on: https://gerrit.libreoffice.org/45109
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/vcl/headless/svpframe.cxx b/vcl/headless/svpframe.cxx
index 12fbf88ba63b..711806226c49 100644
--- a/vcl/headless/svpframe.cxx
+++ b/vcl/headless/svpframe.cxx
@@ -156,7 +156,7 @@ SalGraphics* SvpSalFrame::AcquireGraphics()
 void SvpSalFrame::ReleaseGraphics( SalGraphics* pGraphics )
 {
 SvpSalGraphics* pSvpGraphics = dynamic_cast(pGraphics);
-m_aGraphics.remove( pSvpGraphics );
+m_aGraphics.erase(std::remove(m_aGraphics.begin(), m_aGraphics.end(), 
pSvpGraphics), m_aGraphics.end());
 delete pSvpGraphics;
 }
 
@@ -275,10 +275,9 @@ void SvpSalFrame::SetPosSize( long nX, long nY, long 
nWidth, long nHeight, sal_u
 aFrameSize.getY());
 
 // update device in existing graphics
-for( std::list< SvpSalGraphics* >::iterator it = m_aGraphics.begin();
- it != m_aGraphics.end(); ++it )
+for (auto const& graphic : m_aGraphics)
 {
- (*it)->setSurface(m_pSurface, aFrameSize);
+ graphic->setSurface(m_pSurface, aFrameSize);
 }
 }
 if( m_bVisible )
diff --git a/vcl/headless/svpvd.cxx b/vcl/headless/svpvd.cxx
index 660185da1d41..cf78ebc8eb7d 100644
--- a/vcl/headless/svpvd.cxx
+++ b/vcl/headless/svpvd.cxx
@@ -45,7 +45,7 @@ SalGraphics* SvpSalVirtualDevice::AcquireGraphics()
 
 void SvpSalVirtualDevice::ReleaseGraphics( SalGraphics* pGraphics )
 {
-m_aGraphics.remove( dynamic_cast(pGraphics) );
+m_aGraphics.erase(std::remove(m_aGraphics.begin(), m_aGraphics.end(), 
dynamic_cast(pGraphics)), m_aGraphics.end());
 delete pGraphics;
 }
 
@@ -96,9 +96,8 @@ bool SvpSalVirtualDevice::SetSizeUsingBuffer( long nNewDX, 
long nNewDY,
 #endif
 
 // update device in existing graphics
-for( std::list< SvpSalGraphics* >::iterator it = m_aGraphics.begin();
- it != m_aGraphics.end(); ++it )
-(*it)->setSurface(m_pSurface, m_aFrameSize);
+for (auto const& graphic : m_aGraphics)
+graphic->setSurface(m_pSurface, m_aFrameSize);
 }
 return true;
 }
diff --git a/vcl/inc/headless/svpframe.hxx b/vcl/inc/headless/svpframe.hxx
index eed5efec0c66..16de568794f8 100644
--- a/vcl/inc/headless/svpframe.hxx
+++ b/vcl/inc/headless/svpframe.hxx
@@ -26,6 +26,7 @@
 #include 
 
 #include 
+#include 
 
 #ifdef IOS
 #define SvpSalInstance AquaSalInstance
@@ -52,7 +53,7 @@ class VCL_DLLPUBLIC SvpSalFrame : public SalFrame
 
 SystemEnvData   m_aSystemChildData;
 
-std::list< SvpSalGraphics* >m_aGraphics;
+std::vector< SvpSalGraphics* >  m_aGraphics;
 
 static SvpSalFrame*   s_pFocusFrame;
 public:
diff --git a/vcl/inc/headless/svpvd.hxx b/vcl/inc/headless/svpvd.hxx
index 7ac156305abd..704488cdfae0 100644
--- a/vcl/inc/headless/svpvd.hxx
+++ b/vcl/inc/headless/svpvd.hxx
@@ -22,7 +22,7 @@
 
 #include 
 
-#include 
+#include 
 
 class SvpSalGraphics;
 typedef struct _cairo_surface cairo_surface_t;
@@ -33,7 +33,7 @@ class VCL_DLLPUBLIC SvpSalVirtualDevice : public 
SalVirtualDevice
 cairo_surface_t*m_pSurface;
 basegfx::B2IVector  m_aFrameSize;
 double  m_fScale;
-std::list< SvpSalGraphics* >m_aGraphics;
+std::vector< SvpSalGraphics* >  m_aGraphics;
 
 public:
 SvpSalVirtualDevice(DeviceFormat eFormat, double fScale)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

2017-11-22 Thread Julien Nabet

 vcl/source/gdi/pdfwriter_impl.cxx |   12 ++--
 vcl/source/gdi/pdfwriter_impl.hxx |2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit 3c508bf9fc1b2704080a71d7374bf3720343beb5
Author: Julien Nabet 
Date:   Wed Nov 22 21:21:18 2017 +0100

Replace list by vector for m_aJPGs pdfwriter_impl (vcl)

+use for range loop just for the loop containing "std::list"

Change-Id: Ie30dc016e9a001d0bb4ecd31a75749093326e2f6
Reviewed-on: https://gerrit.libreoffice.org/45112
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index e9dfafb02b57..6d958b3bc231 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -2293,13 +2293,13 @@ void PDFWriterImpl::endPage()
 it->m_aBitmap = BitmapEx();
 }
 }
-for( std::list::iterator jpeg = m_aJPGs.begin(); jpeg != 
m_aJPGs.end(); ++jpeg )
+for (auto & jpeg : m_aJPGs)
 {
-if( jpeg->m_pStream )
+if( jpeg.m_pStream )
 {
-writeJPG( *jpeg );
-jpeg->m_pStream.reset();
-jpeg->m_aMask = Bitmap();
+writeJPG( jpeg );
+jpeg.m_pStream.reset();
+jpeg.m_aMask = Bitmap();
 }
 }
 for( std::list::iterator t = 
m_aTransparentObjects.begin();
@@ -9796,7 +9796,7 @@ void PDFWriterImpl::drawJPGBitmap( SvStream& rDCTData, 
bool bIsTrueColor, const
 if( ! rMask.IsEmpty() )
 aID.m_nMaskChecksum = rMask.GetChecksum();
 
-std::list< JPGEmit >::const_iterator it;
+std::vector< JPGEmit >::const_iterator it;
 for( it = m_aJPGs.begin(); it != m_aJPGs.end() && ! (aID == it->m_aID); 
++it )
 ;
 if( it == m_aJPGs.end() )
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx 
b/vcl/source/gdi/pdfwriter_impl.hxx
index 7aba8c50d0e6..cf8fe720050c 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -634,7 +634,7 @@ private:
  *  file stream as XObjects*/
 std::list< BitmapEmit > m_aBitmaps;
 /* contains JPG streams until written to file */
-std::list  m_aJPGs;
+std::vectorm_aJPGs;
 /*--->i56629 contains all named destinations ever set during the PDF 
creation,
destination id is always the destination's position in this vector
  */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: binaryurp/source

2017-11-22 Thread Julien Nabet

 binaryurp/source/bridge.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 86cda9ab3cdfc2f253b4d2f44dd00f40d8574210
Author: Julien Nabet 
Date:   Wed Nov 22 18:48:12 2017 +0100

Revert partly 9d1f61a61893435b26f7239136ad92b7354545a8

The use of erase/remove idiom is wrong here since "there can be multiple
registrations of the same listener"

See Stephan's comments in 
https://gerrit.libreoffice.org/#/c/44892/3/binaryurp/source/bridge.cxx

Change-Id: Iebf979ca25520392ba9de6439d5bf19b8e3446b2
Reviewed-on: https://gerrit.libreoffice.org/45104
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/binaryurp/source/bridge.cxx b/binaryurp/source/bridge.cxx
index 92a1665d8a45..d39d1f24e667 100644
--- a/binaryurp/source/bridge.cxx
+++ b/binaryurp/source/bridge.cxx
@@ -927,7 +927,11 @@ void Bridge::removeEventListener(
 css::uno::Reference< css::lang::XEventListener > const & aListener)
 {
 osl::MutexGuard g(mutex_);
-listeners_.erase(std::remove(listeners_.begin(), listeners_.end(), 
aListener), listeners_.end());
+Listeners::iterator i(
+std::find(listeners_.begin(), listeners_.end(), aListener));
+if (i != listeners_.end()) {
+listeners_.erase(i);
+}
 }
 
 void Bridge::sendCommitChangeRequest() {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106137] Find & Replace: handle \uhhhh and \Uhhhhhhhh notation in replacement string

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=106137

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||3992
 CC||ulrich.wi...@rz.uni-regensb
   ||urg.de

--- Comment #9 from V Stuart Foote  ---
*** Bug 113992 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/inc sc/qa sc/source

2017-11-22 Thread Noel Grandin

 sc/inc/scitems.hxx|  201 +-
 sc/qa/unit/helper/qahelper.cxx|2 
 sc/qa/unit/subsequent_filters-test.cxx|2 
 sc/source/core/data/attarray.cxx  |   19 --
 sc/source/core/data/conditio.cxx  |3 
 sc/source/core/data/docpool.cxx   |5 
 sc/source/core/data/documen3.cxx  |3 
 sc/source/core/data/documen8.cxx  |8 -
 sc/source/core/data/documen9.cxx  |   13 -
 sc/source/core/data/document.cxx  |   12 -
 sc/source/core/data/fillinfo.cxx  |   10 -
 sc/source/core/data/global.cxx|4 
 sc/source/core/data/patattr.cxx   |  111 +-
 sc/source/core/data/postit.cxx|2 
 sc/source/core/data/stlpool.cxx   |4 
 sc/source/core/data/stlsheet.cxx  |5 
 sc/source/core/data/table2.cxx|6 
 sc/source/core/tool/autoform.cxx  |   56 +++
 sc/source/core/tool/detfunc.cxx   |3 
 sc/source/core/tool/editutil.cxx  |2 
 sc/source/filter/excel/xehelper.cxx   |2 
 sc/source/filter/excel/xepage.cxx |   56 +++
 sc/source/filter/excel/xestyle.cxx|   30 +--
 sc/source/filter/excel/xetable.cxx|   12 -
 sc/source/filter/excel/xipage.cxx |   10 -
 sc/source/filter/html/htmlexp.cxx |4 
 sc/source/filter/html/htmlimp.cxx |6 
 sc/source/filter/oox/sheetdatabuffer.cxx  |2 
 sc/source/filter/rtf/eeimpars.cxx |2 
 sc/source/filter/rtf/rtfparse.cxx |1 
 sc/source/ui/Accessibility/AccessibleText.cxx |2 
 sc/source/ui/app/transobj.cxx |2 
 sc/source/ui/cctrl/dpcontrol.cxx  |2 
 sc/source/ui/docshell/docsh3.cxx  |7 
 sc/source/ui/docshell/docsh4.cxx  |   40 ++---
 sc/source/ui/pagedlg/hfedtdlg.cxx |   21 --
 sc/source/ui/pagedlg/tphf.cxx |3 
 sc/source/ui/undo/undocell.cxx|2 
 sc/source/ui/unoobj/afmtuno.cxx   |1 
 sc/source/ui/unoobj/cellsuno.cxx  |   14 -
 sc/source/ui/unoobj/defltuno.cxx  |1 
 sc/source/ui/unoobj/styleuno.cxx  |   36 ++--
 sc/source/ui/unoobj/textuno.cxx   |2 
 sc/source/ui/vba/vbaformat.cxx|4 
 sc/source/ui/view/formatsh.cxx|   46 ++---
 sc/source/ui/view/gridwin4.cxx|4 
 sc/source/ui/view/preview.cxx |   17 +-
 sc/source/ui/view/prevwsh.cxx |4 
 sc/source/ui/view/printfun.cxx|   67 
 sc/source/ui/view/tabvwsha.cxx|6 
 sc/source/ui/view/viewfunc.cxx|   13 -
 51 files changed, 418 insertions(+), 472 deletions(-)

New commits:
commit a675428e349d3424ffcc844e9c3884a82cf82ef7
Author: Noel Grandin 
Date:   Wed Nov 22 14:31:53 2017 +0200

TypedWhichId for sc constants

Change-Id: I25a07d84ae24fdd3b4fbd303beea755169eb9acb
Reviewed-on: https://gerrit.libreoffice.org/45084
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sc/inc/scitems.hxx b/sc/inc/scitems.hxx
index 6664e91742d5..c1c60561b050 100644
--- a/sc/inc/scitems.hxx
+++ b/sc/inc/scitems.hxx
@@ -21,6 +21,7 @@
 #define INCLUDED_SC_INC_SCITEMS_HXX
 
 #include 
+#include 
 
 //  EditEngine is not allowed to define it's own ITEMID's
 #define INCLUDED_EDITENG_EEITEMID_HXX
@@ -51,110 +52,110 @@
 
 #define ATTR_PATTERN_START  100 // begin of cell-attribute-pattern
 
-#define ATTR_FONT   100 // begin of cell-attributes
-#define ATTR_FONT_HEIGHT101
-#define ATTR_FONT_WEIGHT102
-#define ATTR_FONT_POSTURE   103
-#define ATTR_FONT_UNDERLINE 104
-#define ATTR_FONT_OVERLINE  105
-#define ATTR_FONT_CROSSEDOUT106
-#define ATTR_FONT_CONTOUR   107
-#define ATTR_FONT_SHADOWED  108
-#define ATTR_FONT_COLOR 109
-#define ATTR_FONT_LANGUAGE  110
-#define ATTR_CJK_FONT   111
-#define ATTR_CJK_FONT_HEIGHT112
-#define ATTR_CJK_FONT_WEIGHT113
-#define ATTR_CJK_FONT_POSTURE   114
-#define ATTR_CJK_FONT_LANGUAGE  115
-#define ATTR_CTL_FONT   116
-#define ATTR_CTL_FONT_HEIGHT117
-#define ATTR_CTL_FONT_WEIGHT118
-#define ATTR_CTL_FONT_POSTURE   119
-#define ATTR_CTL_FONT_LANGUAGE  120
-#define ATTR_FONT_EMPHASISMARK  121
-#define ATTR_USERDEF122 // not saved in binary files
-#define ATTR_FONT_WORDLINE  123
-#define ATTR_FONT_RELIEF124
-#define ATTR_HYPHENATE  125
-#define ATTR_SCRIPTSPACE126
-#define ATTR_HANGPUNCTUATION127
-#define ATTR_FORBIDDEN_RULES128
-#define ATTR_HOR_JUSTIFY129
-#define ATTR_HOR_JUSTIFY_METHOD

[Libreoffice-bugs] [Bug 113992] Unable to replace unicode (\u####)

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113992

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6137
 Resolution|INVALID |DUPLICATE

--- Comment #2 from V Stuart Foote  ---
Rereading this, guess this could be considered a duplicate of bug 106137 if you
are asking to parse the Unicode for use in the replacement string.

The Replace string can not be RegEx based because our Regular Expression
support in the Find & Replace dialog uses ICU libraries for its direct Unicode
support. 

The Replace field does not implement its own RegEx beyond using the ICU pattern
matching buffers available from Find [1].

In the see also, devs suggest they may be able to provide new parser to enter
replacement text with \u or \U syntax but that it would not be fully functional
RegEx.

=-ref-=
[1] http://userguide.icu-project.org/strings/regexp

*** This bug has been marked as a duplicate of bug 106137 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basctl/source comphelper/source compilerplugins/clang connectivity/source cui/source extensions/source filter/source framework/source hwpfilter/source io/source jvmfwk/

2017-11-22 Thread Noel Grandin

 basctl/source/basicide/brkdlg.cxx  |2 
 comphelper/source/misc/types.cxx   |2 
 compilerplugins/clang/simplifybool.cxx |   52 +++--
 compilerplugins/clang/test/simplifybool.cxx|   18 +
 connectivity/source/drivers/odbc/OResultSet.cxx|2 
 cui/source/tabpages/swpossizetabpage.cxx   |2 
 extensions/source/update/feed/updatefeed.cxx   |2 
 filter/source/graphicfilter/icgm/class4.cxx|4 -
 framework/source/fwe/helper/propertysetcontainer.cxx   |4 -
 framework/source/fwi/uielement/itemcontainer.cxx   |2 
 framework/source/fwi/uielement/rootitemcontainer.cxx   |2 
 framework/source/layoutmanager/uielement.cxx   |4 -
 hwpfilter/source/hwpread.cxx   |   28 -
 io/source/stm/odata.cxx|6 -
 jvmfwk/plugins/sunmajor/pluginlib/sunversion.cxx   |2 
 oox/source/ole/vbainputstream.cxx  |2 
 pyuno/source/module/pyuno_runtime.cxx  |2 
 registry/source/regimpl.cxx|2 
 sal/osl/unx/pipe.cxx   |2 
 sal/rtl/digest.cxx |   18 ++---
 sal/rtl/math.cxx   |2 
 sax/source/expatwrap/saxwriter.cxx |2 
 sc/source/core/data/document.cxx   |4 -
 sc/source/core/opencl/op_database.cxx  |4 -
 sc/source/core/tool/charthelper.cxx|2 
 sc/source/filter/excel/xiescher.cxx|2 
 sc/source/filter/html/htmlpars.cxx |2 
 sc/source/filter/orcus/filterdetect.cxx|2 
 sc/source/filter/xml/XMLStylesExportHelper.cxx |6 -
 sc/source/ui/view/tabview.cxx  |2 
 sc/source/ui/view/viewdata.cxx |   12 +--
 sd/source/ui/dlg/sdtreelb.cxx  |2 
 sd/source/ui/presenter/PresenterTextView.cxx   |2 
 sfx2/source/dialog/templdlg.cxx|2 
 sfx2/source/doc/DocumentMetadataAccess.cxx |2 
 solenv/CompilerTest_compilerplugins_clang.mk   |1 
 starmath/source/accessibility.cxx  |   14 ++--
 store/source/lockbyte.cxx  |8 +-
 store/source/stordata.cxx  |6 -
 store/source/storpage.cxx  |6 -
 store/source/stortree.cxx  |   10 +--
 store/source/stortree.hxx  |2 
 svl/source/misc/inethist.cxx   |2 
 svl/source/numbers/zforlist.cxx|4 -
 svl/source/numbers/zformat.cxx |2 
 svtools/source/control/valueacc.cxx|2 
 svx/source/accessibility/GraphCtlAccessibleContext.cxx |2 
 svx/source/dialog/docrecovery.cxx  |4 -
 svx/source/form/formcontrolfactory.cxx |2 
 sw/source/core/doc/DocumentRedlineManager.cxx  |2 
 sw/source/core/doc/docfld.cxx  |2 
 sw/source/core/docnode/nodes.cxx   |2 
 sw/source/core/layout/flycnt.cxx   |4 -
 sw/source/core/layout/sectfrm.cxx  |2 
 sw/source/core/layout/trvlfrm.cxx  |2 
 sw/source/core/text/EnhancedPDFExportHelper.cxx|2 
 sw/source/core/text/porlay.cxx |2 
 sw/source/core/txtnode/ndtxt.cxx   |4 -
 sw/source/core/unocore/unofield.cxx|2 
 sw/source/filter/ww8/ww8atr.cxx|2 
 sw/source/filter/ww8/ww8par3.cxx   |2 
 sw/source/ui/frmdlg/frmpage.cxx|2 
 sw/source/uibase/app/swmodul1.cxx  |2 
 sw/source/uibase/frmdlg/frmmgr.cxx |4 -
 sw/source/uibase/shells/textfld.cxx|2 
 sw/source/uibase/uno/unomod.cxx|2 
 sw/source/uibase/utlui/content.cxx |2 
 toolkit/source/helper/formpdfexport.cxx|2 
 tools/source/generic/b3dtrans.cxx  |4 -
 vcl/source/font/font.cxx   |2 
 vcl/source/gdi/pdfwriter_impl.cxx  |2 
 vcl/source/opengl/OpenGLHelper.cxx |2 
 vcl/source/window/decoview.cxx |2 
 vcl/source/window/winproc.cxx  |4 -
 vcl/unx/generic/print/common_gfx.cxx   |4 -
 writerfilter/source/dmapper/ConversionHelper.cxx   |2 
 xmloff/source/style/xmlnumfi.cxx   |2 
 77

[Libreoffice-bugs] [Bug 112571] FILESAVE XLSX New named range is created every time an Excel made spreadsheet that contains print ranges is saved as XLSX

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112571

--- Comment #8 from Aron Budea  ---
The main issue is that eg. print area is exported once as a built-in name:

void XclExpNameManagerImpl::CreateBuiltInNames()
https://opengrok.libreoffice.org/xref/core/sc/source/filter/excel/xename.cxx#575

...and then as a user name as well (as many as there were). This is why after
each save there's one extra range. A set of "_0"-s are added during import to
avoid clash.

This is what the named range in xl\worksheets.xml looks like after one save
(different sample than the attachment, the range is different), at this point
the names are still clashing:


  Sheet1!$A$1:$E$5
  Sheet1!$A$1:$E$5

Note how in XclExpNameManagerImpl::CreateBuiltInNames() other built-in names
are created as well.
The quick fix seems to be to skip adding the user-created names separately if
they match a built-in name. Maybe they shouldn't even be listed among the
user-created names, if it's possible?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111474] UI: Row numbers are clipped when OpenGL is used

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=111474

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #8 from V Stuart Foote  ---
Think this was corrected by the DirectWrite adjustment for OpenGL rendering for
bug 113347

https://cgit.freedesktop.org/libreoffice/core/commit/?id=de811bb2359757b90a0a9851963bd8702b97dab0=libreoffice-5-4

Please retest it in a master build, or 5.4.4.1 when released.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102847] [META] Quick Find, Search and Replace

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102847

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||113992


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113992
[Bug 113992] Unable to replace unicode (\u)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113992] Unable to replace unicode (\u####)

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113992

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Blocks||102847
 Resolution|--- |INVALID

--- Comment #1 from V Stuart Foote  ---
The hex Unicode value \u00b0 search string picks up the "°" in a Find & Replace
dialog with Other Options -> Regular Expressions checked.  While our "\n"
replacement results in paragraph breaks.

This works as expected.

=-Testing-=
On Windows 10 Home 64-bit en-US (ver 1709)
Version: 5.4.3.1 (x64)
Build ID: 32c8895c6cae21571f364dbb059f419a743ee44d
CPU threads: 4; OS: Windows 6.19; UI render: GL; 
Locale: en-US (en_US); Calc: group


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102847
[Bug 102847] [META] Quick Find, Search and Replace
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102847] [META] Quick Find, Search and Replace

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102847
Bug 102847 depends on bug 113992, which changed state.

Bug 113992 Summary: Unable to replace unicode (\u)
https://bugs.documentfoundation.org/show_bug.cgi?id=113992

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113880] Fixing various accessibility issues in .ui files

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113880

--- Comment #9 from Yousuf Philips (jay)  ---
Image / Frame / OLE dialog
* labels and checkboxes not linked with drop-down lists or textboxes
* https://gerrit.libreoffice.org/45121

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113986] Support SVGZ format

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113986

--- Comment #2 from V Stuart Foote  ---
Created attachment 137933
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137933=edit
linked svgz filter inserted onto a Draw canvas

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99825] [META] SVG bugs and enhancements

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99825
Bug 99825 depends on bug 113986, which changed state.

Bug 113986 Summary: Support SVGZ format
https://bugs.documentfoundation.org/show_bug.cgi?id=113986

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75487] Other: support for svgz

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=75487

V Stuart Foote  changed:

   What|Removed |Added

 CC||shanshandehongxing@outlook.
   ||com

--- Comment #6 from V Stuart Foote  ---
*** Bug 113986 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113986] Support SVGZ format

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113986

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |DUPLICATE

--- Comment #1 from V Stuart Foote  ---
No, when correctly downloaded (the examples page puts up links), the car.svgz
can be inserted directly to Draw/Impress/Writer/Calc with good fidelity. And
when Opened into Draw, the filter does OK but with some annoying artifacts.

So, WFM => dupe of bug 75487

*** This bug has been marked as a duplicate of bug 75487 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113538] Bundle and use open source Hebrew fonts by default

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113538

--- Comment #27 from Yousuf Philips (jay)  ---
(In reply to Eyal Rozenberg from comment #24)
> Just to give a feel of what I've been taking about. For the David Libre
> spacing issue, just look at the "Ze Dai" (זה די) sequence. Notice how the
> inter-letter spacing between the Daled and Yod is essentially the same as
> the inter-word spacing between the Yod and the following Vav.

Okay i see it. So i guess this is one of the spacing issues you dont like about
David Libre.

(In reply to Eyal Rozenberg from comment #25)
> Created attachment 137926 [details]
> Some header/body font combinations

Nice combinations, though not sure why you included Narkisim in the mix if it
isnt an open source font. Hope others in the hebrew team will give their
opinions what combinations they like.

(In reply to Eyal Rozenberg from comment #26)
> So, a decision is being made about Latin. Why? That is, why isn't it a
> decision about languages? Why should there be a per-language decision? Maybe
> there are good reasons for it, maybe there aren't. If there are - what are
> they?

It is being discussed about Latin languages as a whole and individual Latin
languages can chose to adopt it or not. Every language should have the
independence to decide this based on what is common/best for that individual
language, just like how we are doing so here for Hebrew.

> First - I'm against the David Libre as the default (see below), but

The hebrew team, and possibly with input from the hebrew community, has to
decide which of the two David fonts they prefer to be default. My patch is
awaiting a final decision on it, as i'm indifferent about it.

> regardless, I'm personally against mixing serifs and non-serifs in font
> preference lists. On the web you usually see something like "super special
> sans serif fonts; kind of special sans serif font; helvetica; sans serif" or
> the same thing but with all serif fonts. I'd rather have a less-pleasing
> choice for a default font as a substitution than switch from serif to sans
> serif or back.

Didnt quite follow you here as i listed serif fonts separately from sans font
and was simply showing the sort order of what LO would pick based on what fonts
are on a users system.

> Ah, but the supposed "cramping" is what makes it a great running text font.
> The close-to-identical character widths and spacing are a _problem_, not a
> benefit: They prevent your eyes from properly capturing entire words and
> disrupt the reading sequence, making it a sequence of recognizing individual
> glyphs and putting them together. For this reason alone I would not at all
> recommend David Libre as the default; I'd even take a nice sans serif in its
> stead. I'd even insist that whatever I got in David Libre be changed to
> something else before reading it (if I can).

So you prefer the crammed look, which David Libre has less of compared to David
CLM, got it.

> Nachlieli doesn't give off the same vibe as Alef. It's much less
> presumptuous. To take what I mean to the extreme, suppose you were using
> some kind of Times for the body and MS Comic Sans for the headings. It's
> just... doesn't fit. Again, I'm taking this to the extreme. See my last
> attachment.

Got it, but you dont have to convince me, its up to the hebrew team to come to
some agreement. :D

> How about if I opened a bug about adding the extra weights in after 72944 is
> resolved?

You could but i've been waiting 3 years so far since i joined for it to be
fixed and dont see it being fixed anytime soon.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114000] Regression - selected character set not honoured when importing from Lotus .123 format

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114000

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||ba...@caesar.elte.hu
 Ever confirmed|0   |1

--- Comment #1 from Aron Budea  ---
Please upload a sample file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113604] Optimal column width of table in Writer is cumbersome and not persistent

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113604

cson...@halmai.hu changed:

   What|Removed |Added

 CC||cson...@halmai.hu

--- Comment #10 from cson...@halmai.hu ---
Created attachment 137932
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137932=edit
use case showing when automatic readjustment of column withs would destroy the
precisely adjusted layout

I add an attachment now to illustrate what kind of use case I was referring to. 

Let's say a teacher, who creates work sheets for their student and uses many
images for illustrations, they can adjust the images manually, like the
attachment shows. They create the document at 11pm in the evening, print them
for the next morning and probably never use the same document again. 

For them, this manual positioning is the most straightforward way (please
correct me if there is a better one). If a small change like "R" => "r" in this
example, would adjust the columns slightly and would destroy the precise
alignment between the umbrealla and the letter J then quite likely they would
realise it only after printing or maybe the next day. This would cause
frustration for them.

As there is no better way to define relative positions in a nicer way, they
don't have other choice than reviewing the whole document continuously.


I'm not saying LO should never reposition anything. I just showed an example
where this can be different what the user wants.

Cut a long story short, I think the user may need two things:
- adjust the column width to be optimal according to their current content
- permanently keep the column withs optimal

Now LO has the first functionality and doesn't have the second one. I think we
should keep the existing menu item and we should introduce a new checkbox in
the table propertise called "Keep column widths optimal".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 113604] Optimal column width of table in Writer is cumbersome and not persistent

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113604

cson...@halmai.hu changed:

   What|Removed |Added

 CC||cson...@halmai.hu

--- Comment #10 from cson...@halmai.hu ---
Created attachment 137932
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137932=edit
use case showing when automatic readjustment of column withs would destroy the
precisely adjusted layout

I add an attachment now to illustrate what kind of use case I was referring to. 

Let's say a teacher, who creates work sheets for their student and uses many
images for illustrations, they can adjust the images manually, like the
attachment shows. They create the document at 11pm in the evening, print them
for the next morning and probably never use the same document again. 

For them, this manual positioning is the most straightforward way (please
correct me if there is a better one). If a small change like "R" => "r" in this
example, would adjust the columns slightly and would destroy the precise
alignment between the umbrealla and the letter J then quite likely they would
realise it only after printing or maybe the next day. This would cause
frustration for them.

As there is no better way to define relative positions in a nicer way, they
don't have other choice than reviewing the whole document continuously.


I'm not saying LO should never reposition anything. I just showed an example
where this can be different what the user wants.

Cut a long story short, I think the user may need two things:
- adjust the column width to be optimal according to their current content
- permanently keep the column withs optimal

Now LO has the first functionality and doesn't have the second one. I think we
should keep the existing menu item and we should introduce a new checkbox in
the table propertise called "Keep column widths optimal".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 101522] [META] Media playback bugs and enhancements

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101522

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on|62408   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=62408
[Bug 62408] Cannot insert MP4 video files on Windows
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113321] [META] Media insert bugs and enhancements

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113321
Bug 113321 depends on bug 62408, which changed state.

Bug 62408 Summary: Cannot insert MP4 video files on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=62408

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62408] Cannot insert MP4 video files on Windows

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=62408

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Blocks|101522  |
 Resolution|--- |FIXED
Summary|Cannot insert or play MP4   |Cannot insert MP4 video
   |video files on Windows  |files on Windows

--- Comment #39 from Yousuf Philips (jay)  ---
(In reply to Aron Budea from comment #37)
> Created attachment 137917 [details]
> Sample ODP with embedded MP4

This is a 16.5Kb file that has no embedded MP4 in it though it references the
MP4 as content.xml as 

> This is also the case with MP4 playback, see attached sample, which shows a
> "?" in Impress / Windows 7 with the default Windows codecs (the presentation
> was created in Linux, as the MP4 can't be inserted in Windows).

I got the same thing as there is no MP4 in the file.

> The issue can surely be circumvented by installing codec packs, but this
> video format should be supported in Windows by default.

LO only supports playback through DirectShow filters, while "Windows Media
Player supports the Media Foundation framework besides DirectShow"[1]. So if
you dont have KLite or another codec pack installed that provides DirectShow
filters for MP4, you wont be able to play MP4s.

I'm closing this bug, so as mentioned in comment 36, if an MP4 doesnt insert or
play with KLite installed, please file a new bug and mention the path of the
file and attach or link to it in the description.

[1] https://en.wikipedia.org/wiki/Windows_Media_Player#History


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101522
[Bug 101522] [META] Media playback bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94655] Apple Color Emoji not Visible in Exported PDF

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=94655

V Stuart Foote  changed:

   What|Removed |Added

Summary|Emoji not Visible in|Apple Color Emoji not
   |Exported PDF|Visible in Exported PDF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94655] Emoji not Visible in Exported PDF

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=94655

--- Comment #20 from V Stuart Foote  ---
Created attachment 137931
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137931=edit
sample document using EmojiOne color, Apple Color Emoji and Symbola fonts

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114000] New: Regression - selected character set not honoured when importing from Lotus .123 format

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114000

Bug ID: 114000
   Summary: Regression - selected character set not honoured when
importing from Lotus .123 format
   Product: LibreOffice
   Version: 5.4.2.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: filters and storage
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xhaj...@hajny.biz

Description:
Accented characters are displayed incorrectly when opening files stored in
Lotus .123 format regardless from selecting the correct character set. The
chosen character set seems to be ignored. This is a regression - it used to
work correctly in older versions (I believe that this was the case in 4.2.2,
certainly in even older versions). The bug does not appear in the last Apache
OpenOffice release (i.e. the same file with the same character set selected
when opening is displayed correctly there).

Steps to Reproduce:
1.Open a file in Lotus .123 format stored in IBM codepage 852 (DOS / OS/2)
containing accented characters (e.g. in Czech).

2.Select "Eastern Europe (DOS/OS/2-852)"

3.See the displayed accented characters - they are incorrect

Actual Results:  
E.g. "ß" displayed instead of "ž", "°" instead of "í", "Ï" instead of "ý", etc.
Selected character set doesn't seem to have any impact - characters are
displayed the same way if selecting the correct character set (IBM CP 852 - see
above), or if selecting "Eastern Europe (Windows-1250/WinLatin 2)" (which is
not correct, because it contains the same characters on different positions /
with different ASCII codes).

Expected Results:
Correctly displayed characters (like in older LibreOffice or Apache OpenOffice
versions).


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
I tested with both 5.4.2.2 and 5.4.3.2. The following corresponds to the
latter:

Verze: 5.4.3.2 (x64)
ID sestavení: 92a7159f7e4af62137622921e809f8546db437e5
Vlákna CPU: 4; OS: Windows 6.1; Vykreslování UI: výchozí; 
Národní prostředí: cs-CZ (cs_CZ); Calc: group


User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:49.0) Gecko/20100101
Firefox/49.0 SeaMonkey/2.46 Lightning/5.1b1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94655] Emoji not Visible in Exported PDF

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=94655

V Stuart Foote  changed:

   What|Removed |Added

 CC||chris.sherloc...@gmail.com,
   ||khaledho...@eglug.org

--- Comment #19 from V Stuart Foote  ---
Think there are two issues at play, one is a font fall back issue where missing
fonts are not picking up Apple Color Emoji font. But there is a rendering issue
with the Apple Color Emoji not rendering with the LO PDF export filter. But
they are rendered on print to JPEG, and PNG. 

On macOS 10.13.1 with
Version: 5.4.3.2
Build ID: 92a7159f7e4af62137622921e809f8546db437e5
CPU threads: 8; OS: Mac OS X 10.13.1; UI render: default; 
Locale: en-US (en_US.UTF-8); Calc: group

On this system I have installed Symbola in addition to the EmojiOne Color we
deploy.

In the attached sample document Unicode points from the string

u+1f4fa u+1f50c u+2709 u+1f4de u+2328

are each converted to their glyph using the Command+Option+X toggle for a line
of EmojiOne Color, Apple Color Emoji, and Symbols

Printing to PS or PDF with the macOS print routine will pick up the Apple Color
Emoji in the result. As will export from LibreOffice to PNG or JPEG image.

But, the LibreOffice export to PDF is not rendering the Apple Color Emoji
glyphs to the resulting PDF.

The SVG based Apple Color Emoji (it is a TTF collection, but none of my font
tools actually read the SVG) are common now on macOS systems, since they'll be
frequent fallback selections with our expanded emoji handling the PDF rendering
needs help.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62408] Cannot insert or play MP4 video files on Windows

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=62408

Dennis Roczek  changed:

   What|Removed |Added

 CC||dennisroc...@libreoffice.or
   ||g

--- Comment #38 from Dennis Roczek  ---
REPRO with
Version: 5.4.2.2 (x64)
Build-ID: 22b09f6418e8c2d508a9eaf86b2399209b0990f4
CPU-Threads: 4; Betriebssystem:Windows 6.19; UI-Render: GL; 
Gebietsschema: de-DE (de_DE); Calc: group

(so windows 10 fall creators update without ANY codec packs!)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 113604] Optimal column width of table in Writer is cumbersome and not persistent

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113604

--- Comment #9 from cson...@halmai.hu ---
Reply(In reply to Christian Lehmann from comment #8)

> 2) Optimal column width is a permanent property of a table until the user
> resets it. It remains in vigor after editing the cells. Again, I cannot
> imagine a scenario where I would want optimal column width for the present
> content of my table, but not for a changed table content.

I can. :) 

Example: the user fills the cells with some content and then changes the column
widths to be optimal (whatever it means). Later on, they may change the content
slightly, like fixing some typos or making some other minor changes. It can
happen that the user still wants to keep the existing postion of each column,
for example, because they placed some wrap-through images or frames here and
there. 

I admit, in many cases applying such images and frames is not necessary or can
be avoided but there are some other cases when they provide the
quickest/simplest solution. In those cases the user may want to preserve the
overall layout of the page, including the table cell positions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 113604] Optimal column width of table in Writer is cumbersome and not persistent

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113604

--- Comment #9 from cson...@halmai.hu ---
Reply(In reply to Christian Lehmann from comment #8)

> 2) Optimal column width is a permanent property of a table until the user
> resets it. It remains in vigor after editing the cells. Again, I cannot
> imagine a scenario where I would want optimal column width for the present
> content of my table, but not for a changed table content.

I can. :) 

Example: the user fills the cells with some content and then changes the column
widths to be optimal (whatever it means). Later on, they may change the content
slightly, like fixing some typos or making some other minor changes. It can
happen that the user still wants to keep the existing postion of each column,
for example, because they placed some wrap-through images or frames here and
there. 

I admit, in many cases applying such images and frames is not necessary or can
be avoided but there are some other cases when they provide the
quickest/simplest solution. In those cases the user may want to preserve the
overall layout of the page, including the table cell positions.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113994] qt5 VCL plugin crashes on startup

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113994

--- Comment #1 from Bernhard Rosenkraenzer  ---
slightly different behavior when rebuilt with --enable-debug: Window doesn't
even open, error message isn't printed, but before aborting an extra warning is
printed:

warn:opencl:54163:54163:desktop/source/app/opencl.cxx:137: Failed to initialize
OpenCL for test

Seems unrelated though, Qt doesn't require OpenCL...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113995] Invisible checkboxes with SAL_USE_VCLPLUGIN=default

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113995

Bernhard Rosenkraenzer  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTOURBUG

--- Comment #1 from Bernhard Rosenkraenzer  ---
This problem goes away when installing the "galaxy" style -- omitting that
style in favor of breeze doesn't seem to be a good idea.

Fixing in our packaging by making "galaxy" mandatory.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113996] Crashing when synchronizing labels with graphics

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113996

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
I can't reproduce it in

Version: 6.0.0.0.alpha1+
Build ID: 921c8f50132de4042860956e102389c239da638a
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: th-TH (ca_ES.UTF-8); Calc: group threaded

it seems you're using an old version of LibreOffice.
Could you please try to reproduce it with the latest version of LibreOffice
from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86303] STATUSBAR: Easy access to change to read only mode

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=86303

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||86899

--- Comment #16 from Yousuf Philips (jay)  ---
Like other statusbar entries, not all users will want to have this in their
statusbar, so hopefully they will be able to remove it if they dont like (bug
113828).


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=86899
[Bug 86899] [META] Requests for the addition of UNO commands
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86899] [META] Requests for the addition of UNO commands

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=86899

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||86303


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=86303
[Bug 86303] STATUSBAR: Easy access to change to read only mode
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113828] Add statusbar tab to customization dialog

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113828

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||86066


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=86066
[Bug 86066] [META] Improvements to the statusbar
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86066] [META] Improvements to the statusbar

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=86066

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||113828


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113828
[Bug 113828] Add statusbar tab to customization dialog
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113976] Document how to escape double quotes in text functions

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113976

Dan Dascalescu  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTABUG |---

--- Comment #8 from Dan Dascalescu  ---
The bug was to document at https://help.libreoffice.org/Calc/Text_Functions how
to escape double quotes. Reopening.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sal/rtl

2017-11-22 Thread Stephan Bergmann

 sal/rtl/math.cxx |   12 ++--
 1 file changed, 10 insertions(+), 2 deletions(-)

New commits:
commit c24c32bf71b8e64bd0d36e511f554e1f6c015842
Author: Stephan Bergmann 
Date:   Wed Nov 22 15:34:09 2017 +0100

ofz#4366 Divide-by-zero

Change-Id: I3d0eb3bb6a69d09e71ce8bf91051f66e204eb0df
Reviewed-on: https://gerrit.libreoffice.org/45098
Reviewed-by: Eike Rathke 
Tested-by: Jenkins 

diff --git a/sal/rtl/math.cxx b/sal/rtl/math.cxx
index 997280784351..96c5843dcfea 100644
--- a/sal/rtl/math.cxx
+++ b/sal/rtl/math.cxx
@@ -34,6 +34,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -365,8 +366,15 @@ inline void doubleToString(typename T::String ** pResult,
 int nExp = 0;
 if ( fValue > 0.0 )
 {
-nExp = static_cast< int >(floor(log10(fValue)));
-fValue /= getN10Exp(nExp);
+// Cap nExp at a small value beyond which "fValue /= N10Exp" would 
lose precision (or N10Exp
+// might even be zero); that will produce output with the decimal 
point in a non-normalized
+// position, but the current quality of output for such small values 
is probably abysmal,
+// anyway:
+nExp = std::max(
+static_cast< int >(floor(log10(fValue))), 
std::numeric_limits::min_exponent10);
+double const N10Exp = getN10Exp(nExp);
+assert(N10Exp != 0);
+fValue /= N10Exp;
 }
 
 switch (eFormat)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Delay when running the Build

2017-11-22 Thread Eike Rathke

Hi Koushik,

On Monday, 2017-11-20 17:31:28 -0800, Koushik Sekhar wrote:

> So, is this delay have to do with my
> environment or generally it takes a long time for the build to complete? If
> so, could you tell me how long does it take for the build to complete?

Depending on your machine, number of cores, available RAM and disk speed
it may take any time between 2 and 6 hours, in bad cases even more,
worst case your build starts swapping with too little RAM (8GB
advisable, more if you build with debug).

For example, 4 cores (8 CPUs), 16GB RAM, SSD and a handful of
localizations (which each take extra time to build help and resources)
still takes 2-3 hours.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Care about Free Software, support the FSFE https://fsfe.org/support/?erack

signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 111474] UI: Row numbers are clipped when OpenGL is used

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=111474

kyama  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #7 from kyama  ---
The issue is still present in version 5.4.3 when "Use OpenGL for all rendering"
option is enabled.
But the display performance seems vastly improved in 5.4.3 even when the OpenGL
option is disabled. So I can use LO comfortably without the OpenGL option now.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113622] Impress can't play MP4 videos

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113622

Xisco Faulí  changed:

   What|Removed |Added

 CC||cl...@documentfoundation.or
   ||g

--- Comment #21 from Xisco Faulí  ---
This is the range between 5.4.0.2 and 5.4.0.1 ->
https://cgit.freedesktop.org/libreoffice/core/log/?h=libreoffice-5-4=range=3cde28795a21f4aef2d5882406a3c53e09e67815

I went through the suspicious commits ( I ignored sw, sc and gpg commits) by
reverting them and no luck

@Cloph: Do you know if anything changed between 5.4.0.1 and 5.4.0.2 or between
5.3.4.2 and 5.3.5.1 to cause this bug?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113976] Document how to escape double quotes in text functions

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113976

m.a.riosv  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #7 from m.a.riosv  ---
Resolved as not a bug, please if you are not agree reopen it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113976] Document how to escape double quotes in text functions

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113976

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #6 from m.a.riosv  ---
Created attachment 137929
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137929=edit
Sample showing no bug

I think the issue is with the search text not having double quotes as such but
as delimiters.

A1=CHAR(34)&"foo"(34) = "foo"
=SUBSTITUTE(A1;"""foo""";"""bar""";1) = "bar"
A1="""foo""" = "foo"
=SUBSTITUTE(A1;"""foo""";"""bar""";1) = "bar"

It works as @Eike indication.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113998] Moving a bulleted list entry up/ down also moves the subsequent text line

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113998

--- Comment #1 from zyklo...@web.de ---
Created attachment 137928
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137928=edit
Screen cast

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113998] New: Moving a bulleted list entry up/ down also moves the subsequent text line

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113998

Bug ID: 113998
   Summary: Moving a bulleted list entry up/down also moves the
subsequent text line
   Product: LibreOffice
   Version: 6.0.0.0.alpha1+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: zyklo...@web.de

Description:
See my appended screen cast. I just created a second level header via "Ctrl +
2" after a bulleted list, and moved one item up.

Steps to Reproduce:
See above.

Actual Results:  
Subsequent header gets moved.

Expected Results:
Subsequent header shouldn’t get moved.


Reproducible: Always


User Profile Reset: No



Additional Info:
It does not happen every time, seems to happen due to how the subsequent header
is created. In my example I pressed "enter" two times at the end of the second
bullet item, so that I exited the bulleted list. Then I entered the text and
pressed "Ctrl + 2".


User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:57.0) Gecko/20100101
Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 113831] Find All search result window should show the number of found results

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113831

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from Heiko Tietze  ---
The dialog has a label anyway, hidden by default, that shows the number of
'skipped' items for very long lists. We could always show this label and just
add the skipped to it.

Selection and CountA are alternative workflows.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 113831] Find All search result window should show the number of found results

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113831

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from Heiko Tietze  ---
The dialog has a label anyway, hidden by default, that shows the number of
'skipped' items for very long lists. We could always show this label and just
add the skipped to it.

Selection and CountA are alternative workflows.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: external/cairo

2017-11-22 Thread Christian Lohmaier

 external/cairo/UnpackedTarball_cairo.mk |1 -
 external/cairo/cairo/cairo-1.10.2.android.patch |   24 
 2 files changed, 25 deletions(-)

New commits:
commit 54e1441949b83a76eecd02f2839693697773f711
Author: Christian Lohmaier 
Date:   Wed Nov 22 23:14:26 2017 +0100

cairo: drop no longer needed patch for android

Change-Id: I7f52cc8686556e21b9d2b5fdf43ce13307bcfac0

diff --git a/external/cairo/UnpackedTarball_cairo.mk 
b/external/cairo/UnpackedTarball_cairo.mk
index 503e762cb4f5..d38ba6bac2e2 100644
--- a/external/cairo/UnpackedTarball_cairo.mk
+++ b/external/cairo/UnpackedTarball_cairo.mk
@@ -24,7 +24,6 @@ endif
 
 ifeq ($(OS),ANDROID)
 $(eval $(call gb_UnpackedTarball_add_patches,cairo,\
-   external/cairo/cairo/cairo-1.10.2.android.patch \
external/cairo/cairo/cairo.GL_RGBA.patch \
 ))
 endif
diff --git a/external/cairo/cairo/cairo-1.10.2.android.patch 
b/external/cairo/cairo/cairo-1.10.2.android.patch
deleted file mode 100644
index 237a0d4c2372..
--- a/external/cairo/cairo/cairo-1.10.2.android.patch
+++ /dev/null
@@ -1,24 +0,0 @@
 misc/cairo-1.10.2/build/ltmain.sh
-+++ misc/build/cairo-1.10.2/build/ltmain.sh
-@@ -3228,6 +3228,10 @@
- func_warning "\`-release' is ignored for convenience libraries"
-   else
- 
-+  # Force no versioning suffix for Android
-+
-+  version_type=none
-+
-   # Parse the version information argument.
-   save_ifs="$IFS"; IFS=':'
-   set dummy $vinfo 0 0 0
-diff -ur cairo.org/src/cairo-compiler-private.h 
cairo/src/cairo-compiler-private.h
 a/cairo.org/src/cairo-compiler-private.h   2016-01-16 00:47:17.392420675 
+0100
-+++ b/cairo/src/cairo-compiler-private.h   2016-01-16 00:51:55.601110129 
+0100
-@@ -258,4 +258,7 @@
- #define inline __inline__
- #endif
- 
-+/* no ffs in libc on android x86 (at least not in v15 that we compile 
against) */
-+#define ffs __builtin_ffs
-+
- #endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 113997] New: the modification date field doesn' t show the modification date of the document

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113997

Bug ID: 113997
   Summary: the modification date field doesn't show the
modification date of the document
   Product: LibreOffice
   Version: 5.2.6.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jerome.bo...@wanadoo.fr

Description:
I used the modification date of a document in the previous versions but I lost
this feature.

Steps to Reproduce:
With 5.0 version :
1. I insert the field modification>date
2. I save and close the document
3. I open the document again
4. the modification date of the document appears.

I lost this feature with 5.2 version

Actual Results:  
No text is printed.

Expected Results:
The date is printed into the document where the field is.


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101
Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76525] Other: Letter Wizard of german LibreOffice installation creates US formatted letter

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=76525

--- Comment #10 from norbert.flatin...@web.de ---
Sorry, I forgot to add the version information of the LO version I did my last
test:

Version: 5.4.2.2
Build-ID: 22b09f6418e8c2d508a9eaf86b2399209b0990f4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cd-5.3' - libreofficekit/Executable_tilebench.mk libreofficekit/Module_libreofficekit.mk libreofficekit/qa Repository.mk

2017-11-22 Thread Ashod Nakashian

 Repository.mk |2 
 libreofficekit/Executable_tilebench.mk|1 
 libreofficekit/Module_libreofficekit.mk   |5 -
 libreofficekit/qa/tilebench/tilebench.cxx |  134 +++---
 4 files changed, 90 insertions(+), 52 deletions(-)

New commits:
commit 84db465fdf9314b4a775d7cfb6558bd91bae7ab9
Author: Ashod Nakashian 
Date:   Tue Nov 21 22:04:27 2017 -0500

LOK: tilebench improvements

* Arguments for max number of parts and tiles to render (optional).
  + Automatic estimation of maximum tiles to render based on max parts
for Writer docs, since there is only 1 part, this caps the number
of pages to render, similar to other doc types.
* Fixed rendering of Writer documents over and over (as many times as 
pages).
  + Writer has a single part, unlike other doc types.
  + No point in rendering the whole document in writer to a single tile,
since that's completely unrealistic and impractical (it takes
forever for large docs and artificially spikes the memory).
* Rendering starts at the current part and not the first.
  + This gives the spreadsheet of interest priority (if saved as visible).
* The tile size is now more realistic as we use the same dimensions
  as the Online client does.
* When rendering tiles at scale, we use the same dimensions as the
  Online client rather than splitting the width by 4, for realism.
* Rendering of tiles is done rows-first, rather than columns-first,
  which is similar to what the Online client does, which is more
  cache friendly, therefore more realistic.
* Enabled compiling of tilebench when GTK3 is disabled, which
  was erroneous, since tilebench doesn't have any dependency on GTK.
  + Now it's possible to compile with local Cairo/Pixman libs.

Change-Id: If8439834cef9b0a2988a6d2c25d63b2b5bc6087f
Reviewed-on: https://gerrit.libreoffice.org/45090
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/Repository.mk b/Repository.mk
index 6eade9020edd..51c1b1b73dea 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -70,7 +70,7 @@ $(eval $(call gb_Helper_register_executables,NONE, \
 svptest \
 svpclient \
 pixelctl ) \
-   $(if $(and $(ENABLE_GTK3), $(filter LINUX %BSD SOLARIS,$(OS))), 
tilebench) \
+   $(if $(filter LINUX %BSD SOLARIS,$(OS)), tilebench) \
$(if $(filter LINUX MACOSX SOLARIS WNT %BSD,$(OS)),icontest \
outdevgrind) \
vcldemo \
diff --git a/libreofficekit/Executable_tilebench.mk 
b/libreofficekit/Executable_tilebench.mk
index 4da51d3ca686..9d8b2a134f99 100644
--- a/libreofficekit/Executable_tilebench.mk
+++ b/libreofficekit/Executable_tilebench.mk
@@ -15,7 +15,6 @@ $(eval $(call gb_Executable_set_include,tilebench,\
 ))
 
 $(eval $(call gb_Executable_use_libraries,tilebench,\
-libreofficekitgtk \
sal \
 ))
 
diff --git a/libreofficekit/Module_libreofficekit.mk 
b/libreofficekit/Module_libreofficekit.mk
index cc842b2f3f2c..079e4e15e5b4 100644
--- a/libreofficekit/Module_libreofficekit.mk
+++ b/libreofficekit/Module_libreofficekit.mk
@@ -23,10 +23,13 @@ ifneq ($(ENABLE_GTK3),)
 $(eval $(call gb_Module_add_targets,libreofficekit,\
 Library_libreofficekitgtk \
 Executable_gtktiledviewer \
+))
+endif # ($(ENABLE_GTK3),)
+
+$(eval $(call gb_Module_add_targets,libreofficekit,\
 Executable_tilebench \
 Package_selectionhandles \
 ))
-endif # ($(ENABLE_GTK3),)
 
 endif
 
diff --git a/libreofficekit/qa/tilebench/tilebench.cxx 
b/libreofficekit/qa/tilebench/tilebench.cxx
index b4912b1611ef..6ad0d578c464 100644
--- a/libreofficekit/qa/tilebench/tilebench.cxx
+++ b/libreofficekit/qa/tilebench/tilebench.cxx
@@ -10,10 +10,12 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
 
+#include 
 #include 
 #include 
 
@@ -21,7 +23,7 @@ using namespace lok;
 
 static int help()
 {
-fprintf( stderr, "Usage: tilebench  
[path to document]\n" );
+fprintf( stderr, "Usage: tilebench  
[path to document] [max parts|-1] [max tiles|-1]\n" );
 fprintf( stderr, "renders a selection of small tiles from the document, 
checksums them and times the process\n" );
 return 1;
 }
@@ -36,13 +38,17 @@ static double getTimeNow()
 
 int main( int argc, char* argv[] )
 {
+static const double origin = getTimeNow();
 struct TimeRecord {
 const char *mpName;
 double mfTime;
 
 TimeRecord() : mpName(nullptr), mfTime(getTimeNow()) { }
 explicit TimeRecord(const char *pName) :
-   mpName(pName ), mfTime(getTimeNow()) { }
+   mpName(pName), mfTime(getTimeNow())
+{
+fprintf(stderr, "%3.3fs - %s\n", (mfTime - origin), mpName);
+}
 };
 std::vector< TimeRecord > aTimes;
 if( argc < 2 ||
@@ -55,24 +61,38 @@ int

[Libreoffice-bugs] [Bug 113996] New: Crashing when synchronizing labels with graphics

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113996

Bug ID: 113996
   Summary: Crashing when synchronizing labels with graphics
   Product: LibreOffice
   Version: 5.1.6.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bd.dic...@icloud.com

Description:
When creating labels using the avery 5160 template in writer, I attempted to
add a graphic to my label and sync it between all labels from the master label.
Libreoffice would then freeze and crash. The graphics file is 195 kb and I also
had a small line drawn with writer added to the master label. The first time I
attempted to sync labels the line transfered and copied without issues. I tried
a smaller 2 kb file and when I clicked sync, libreoffice populated all the
labels, froze and then crashed.

Steps to Reproduce:
1.create labels using libre writer> file> new> Labels
2.syncronize contents box checked, add text (not populating from database)
3.press create
4.add text box for address text to master label
5.add graphic to master label
6.press syncronize
7.libreoffice freezes

Actual Results:  
Libre office crashes.

Expected Results:
Graphic to populate in all template fields


Reproducible: Always


User Profile Reset: No



Additional Info:
Tried reproducing this bug w/o adding any text boxes, and then I added a 2 kb
graphic to the right hand side of the master label. when I synced labels, they
populated fine, no freezing of libreoffice at all.

This is my opengl info from terminal

thisis5867@thisis5867:~$ glxinfo
name of display: :0
display: :0  screen: 0
direct rendering: Yes
server glx vendor string: SGI
server glx version string: 1.4
server glx extensions:
GLX_ARB_create_context, GLX_ARB_create_context_profile, 
GLX_ARB_fbconfig_float, GLX_ARB_framebuffer_sRGB, GLX_ARB_multisample, 
GLX_EXT_create_context_es2_profile, GLX_EXT_create_context_es_profile, 
GLX_EXT_fbconfig_packed_float, GLX_EXT_framebuffer_sRGB, 
GLX_EXT_import_context, GLX_EXT_texture_from_pixmap, GLX_EXT_visual_info, 
GLX_EXT_visual_rating, GLX_INTEL_swap_event, GLX_MESA_copy_sub_buffer, 
GLX_OML_swap_method, GLX_SGIS_multisample, GLX_SGIX_fbconfig, 
GLX_SGIX_pbuffer, GLX_SGIX_visual_select_group, GLX_SGI_swap_control
client glx vendor string: Mesa Project and SGI
client glx version string: 1.4
client glx extensions:
GLX_ARB_create_context, GLX_ARB_create_context_profile, 
GLX_ARB_create_context_robustness, GLX_ARB_fbconfig_float, 
GLX_ARB_framebuffer_sRGB, GLX_ARB_get_proc_address, GLX_ARB_multisample, 
GLX_EXT_buffer_age, GLX_EXT_create_context_es2_profile, 
GLX_EXT_create_context_es_profile, GLX_EXT_fbconfig_packed_float, 
GLX_EXT_framebuffer_sRGB, GLX_EXT_import_context, 
GLX_EXT_texture_from_pixmap, GLX_EXT_visual_info, GLX_EXT_visual_rating, 
GLX_INTEL_swap_event, GLX_MESA_copy_sub_buffer, 
GLX_MESA_multithread_makecurrent, GLX_MESA_query_renderer, 
GLX_MESA_swap_control, GLX_OML_swap_method, GLX_OML_sync_control, 
GLX_SGIS_multisample, GLX_SGIX_fbconfig, GLX_SGIX_pbuffer, 
GLX_SGIX_visual_select_group, GLX_SGI_make_current_read, 
GLX_SGI_swap_control, GLX_SGI_video_sync
GLX version: 1.4
GLX extensions:
GLX_ARB_create_context, GLX_ARB_create_context_profile, 
GLX_ARB_fbconfig_float, GLX_ARB_framebuffer_sRGB, 
GLX_ARB_get_proc_address, GLX_ARB_multisample, 
GLX_EXT_create_context_es2_profile, GLX_EXT_create_context_es_profile, 
GLX_EXT_fbconfig_packed_float, GLX_EXT_framebuffer_sRGB, 
GLX_EXT_import_context, GLX_EXT_texture_from_pixmap, GLX_EXT_visual_info, 
GLX_EXT_visual_rating, GLX_INTEL_swap_event, GLX_MESA_copy_sub_buffer, 
GLX_MESA_multithread_makecurrent, GLX_MESA_query_renderer, 
GLX_MESA_swap_control, GLX_OML_swap_method, GLX_OML_sync_control, 
GLX_SGIS_multisample, GLX_SGIX_fbconfig, GLX_SGIX_pbuffer, 
GLX_SGIX_visual_select_group, GLX_SGI_make_current_read, 
GLX_SGI_swap_control, GLX_SGI_video_sync
Extended renderer info (GLX_MESA_query_renderer):
Vendor: Intel Open Source Technology Center (0x8086)
Device: Mesa DRI Mobile Intel® GM45 Express Chipset  (0x2a42)
Version: 12.0.6
Accelerated: yes
Video memory: 1536MB
Unified memory: yes
Preferred profile: compat (0x2)
Max core profile version: 0.0
Max compat profile version: 2.1
Max GLES1 profile version: 1.1
Max GLES[23] profile version: 2.0
OpenGL vendor string: Intel Open Source Technology Center
OpenGL renderer string: Mesa DRI Mobile Intel® GM45 Express Chipset 
OpenGL version string: 2.1 Mesa 12.0.6
OpenGL shading language version string: 1.20
OpenGL extensions:
GL_3DFX_texture_compression_FXT1, GL_AMD_seamless_cubemap_per_texture, 
GL_AMD_shader_trinary_minmax,

[Libreoffice-commits] core.git: sc/source

2017-11-22 Thread Michael Meeks

 sc/source/core/tool/interpr4.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit df755b1b39fd501b18a513c342f4104dea7eaee8
Author: Michael Meeks 
Date:   Tue Nov 21 17:15:23 2017 +

Avoid using the hideous std::stack -> deque inside ::Interpret

dequeue loves to allocate and free memory crazily, vector is much saner.

Change-Id: Idcd2c1d693594f280ce94423161651502f25dc2d
Reviewed-on: https://gerrit.libreoffice.org/45086
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index 28f14137f077..67052e8906d4 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -3959,7 +3959,7 @@ StackVar ScInterpreter::Interpret()
 sal_uLong nRetIndexExpr = 0;
 sal_uInt16 nErrorFunction = 0;
 sal_uInt16 nErrorFunctionCount = 0;
-std::stack aErrorFunctionStack;
+std::vector aErrorFunctionStack;
 sal_uInt16 nStackBase;
 
 nGlobalError = FormulaError::NONE;
@@ -4522,15 +4522,15 @@ StackVar ScInterpreter::Interpret()
 if ( nLevel == 1 || (nLevel == 2 && aCode.IsEndOfPath()) )
 {
 if (nLevel == 1)
-aErrorFunctionStack.push( nErrorFunction);
+aErrorFunctionStack.push_back( nErrorFunction);
 bGotResult = JumpMatrix( nLevel );
 if (aErrorFunctionStack.empty())
 assert(!"ScInterpreter::Interpret - aErrorFunctionStack 
empty in JumpMatrix context");
 else
 {
-nErrorFunction = aErrorFunctionStack.top();
+nErrorFunction = aErrorFunctionStack.back();
 if (bGotResult)
-aErrorFunctionStack.pop();
+aErrorFunctionStack.pop_back();
 }
 }
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 113538] Bundle and use open source Hebrew fonts by default

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113538

--- Comment #26 from Eyal Rozenberg  ---
(In reply to Yousuf Philips (jay) from comment #21)
> (In reply to Eyal Rozenberg from comment #19)
> > You're "begging the question" (petitio principii) - assuming that's it may
> > be different in Hebrew than it is in Latin. Why?
> 
> Didnt follow.

So, a decision is being made about Latin. Why? That is, why isn't it a decision
about languages? Why should there be a per-language decision? Maybe there are
good reasons for it, maybe there aren't. If there are - what are they?

> Yes the order can include both sans and serif if required. This is the order
> that i've put into my patch.[1]
> 
> Serif: David Libre; David CLM; Liberation Serif; David; Raanana;
> Sans: Nachlieli CLM; Liberation Sans; Arial; Arial Hebrew;
>

First - I'm against the David Libre as the default (see below), but regardless,
I'm personally against mixing serifs and non-serifs in font preference lists.
On the web you usually see something like "super special sans serif fonts; kind
of special sans serif font; helvetica; sans serif" or the same thing but with
all serif fonts. I'd rather have a less-pleasing choice for a default font as a
substitution than switch from serif to sans serif or back.

> I tested the character widths and spacing in MS David vs David CLM and MS
> David is quite cramped comparatively, while David CLM and David Libre have
> close to identical character widths and spacing. 

Ah, but the supposed "cramping" is what makes it a great running text font. The
close-to-identical character widths and spacing are a _problem_, not a benefit:
They prevent your eyes from properly capturing entire words and disrupt the
reading sequence, making it a sequence of recognizing individual glyphs and
putting them together. For this reason alone I would not at all recommend David
Libre as the default; I'd even take a nice sans serif in its stead. I'd even
insist that whatever I got in David Libre be changed to something else before
reading it (if I can).

> If you are referring to the line spacing

No, the line spacing is less the issue. 

> Assume you mean the Alef would be the heading font, which isnt really out of
> place as we do use a sans font for headings presently - Nachlieli CLM.

Nachlieli doesn't give off the same vibe as Alef. It's much less presumptuous.
To take what I mean to the extreme, suppose you were using some kind of Times
for the body and MS Comic Sans for the headings. It's just... doesn't fit.
Again, I'm taking this to the extreme. See my last attachment.

> So is your order preference of sans is Nachlieli, Liberation Sans, Rubik?

I guess.

(In reply to Yousuf Philips (jay) from comment #22)
> David Libre, Frank Ruhl Hofshi, and Miriam Libre only take up 0.5Mb
> uncompressed, so its not really a problem space-wise, and with 2 variants of
> each, users have more choice, more freedom, and users will be able to tell
> us which of each they prefer in a later poll.

I don't mind the extra fonts in the bundle - as long as you keep all the
weights in.

> > I'm very much against this. We should foster finer use of weights and not
> > cripple the fonts by not bundling their full weight spectrum.
> 
> If... we could correctly handle them in the UI (bug 72944)...

How about if I opened a bug about adding the extra weights in after 72944 is
resolved?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113538] Bundle and use open source Hebrew fonts by default

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113538

Eyal Rozenberg  changed:

   What|Removed |Added

 Attachment #137924|0   |1
is obsolete||

--- Comment #25 from Eyal Rozenberg  ---
Created attachment 137926
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137926=edit
Some header/body font combinations

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2017-11-22 Thread Michael Meeks

 sc/source/core/tool/formulagroup.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 7ced0f88e0af360d5b47b320b9dd23b692d8d1ad
Author: Michael Meeks 
Date:   Tue Nov 21 17:26:43 2017 +

Don't re-create the interpreter context for each row.

Change-Id: I272c9dc09806d47add26866f517e6ea07282c35f
Reviewed-on: https://gerrit.libreoffice.org/45087
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 
Reviewed-by: Michael Meeks 

diff --git a/sc/source/core/tool/formulagroup.cxx 
b/sc/source/core/tool/formulagroup.cxx
index f6565e732086..b8b1ef1a79a8 100644
--- a/sc/source/core/tool/formulagroup.cxx
+++ b/sc/source/core/tool/formulagroup.cxx
@@ -175,6 +175,9 @@ public:
 double fNan;
 rtl::math::setNan();
 ScTokenArray aCode2;
+
+ScInterpreterContext aContext(mrDoc, mpFormatter);
+
 for (SCROW i = mnIdx; i <= mnLastIdx; ++i, maBatchTopPos.IncRow())
 {
 formula::FormulaTokenArrayPlainIterator aIter(mrCode);
@@ -298,7 +301,6 @@ public:
 
 ScCompiler aComp(, maBatchTopPos, aCode2);
 aComp.CompileTokenArray();
-ScInterpreterContext aContext(mrDoc, mpFormatter);
 ScInterpreter aInterpreter(pDest, , aContext, maBatchTopPos, 
aCode2);
 aInterpreter.Interpret();
 mrResults[i] = aInterpreter.GetResultToken();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 76525] Other: Letter Wizard of german LibreOffice installation creates US formatted letter

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=76525

--- Comment #9 from norbert.flatin...@web.de ---
Still absolutely no change in behaviour.
This is very sad. This bug is there for more than three and a half years now
and absolutely nothing has happened.
I can't be the only person, who would like to use the letter wizard in Germany.
So many people must be waiting for this feature to work again.
This nice and very useful - for me essential - feature was there, before
version 4 was introduced. Why was it removed?
It should be easy to bring it back...

So I'm still stuck with the latest 3.x version, hoping to be able to upgrade to
a usable actual version soon.

Regards,
Norbert

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113995] New: Invisible checkboxes with SAL_USE_VCLPLUGIN=default

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113995

Bug ID: 113995
   Summary: Invisible checkboxes with SAL_USE_VCLPLUGIN=default
   Product: LibreOffice
   Version: 6.0.0.0.alpha1+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: b...@lindev.ch

Created attachment 137925
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137925=edit
Screenshot showing the problem

When using SAL_USE_VCLPLUGIN=default, LO 6.0.0.0-alpha1+ (git from today) works
well - but checkboxes in dialog boxes are invisible.

Seen on OpenMandriva Cooker (linux 4.14, glibc 2.26, current Xorg) running
Plasma 5.11.3, no special theme selected.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108434] writer and base bugs

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108434

William Signer  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #5 from William Signer  ---
when I tried to reply to Xisco fauli's email the reply was rejected as not
sent.
It turned out that I had to go to this web site to make a reply. It would be
nice if I could have replied to the email that I was sent without needing to go
to another website to make the reply.

Here is the reply I tried to send:



Dash line problem


ddd
--

ff
--









NOTE WHEN I TRIED TO COPY MY ORIGINAL LIBREOFFICE WRITER PAGE
HERE THE DASH LINES AFTER THE f AND g LINES DID NOT COPY AND PAST

so i had to simulate what my page look liket in this document

NOTE the dash lines here did not shift up near the f and g lines
in this simulation like the3 do in my original document
that I was trying to copy here.



--



Maybe this will demo the dash line problem that I am experiencing with
LibreOffice Writer

The same issues are in all version of LibreOffice Writer that I have used and
do not appear in MS Office Word 

I use Windows 10 and Widows 7 and Ubuntu Linux

1. I used the arrow key to go down to create the d line 
2. I typed the d line then I hit the enter key at the end
3. Then hit the dash key to create the dash  line
4. Then  I used the arrow key to go down to create the f line
5  NOTE THE DASH LINE DID NOT MOVE UP CLOSER TO THE D LINE
6. Then  I hit the dash key to create the dash  line
7.  Then I hit the enter key at the end of the dash line
8  NOTE THE DASH LINE MOVE UP CLOSER TO THE f LINE
9. Then  I used the arrow key to go down to create the h line
10. I typed the h line then I hit the enter key at the end
11. Then  I hit the dash key to create the dash  line
12.  Then I hit the enter key at the end of the dash line
13.  NOTE THE DASH LINE MOVE UP CLOSER TO THE h LINE
14. Then I used the arrow key to move to the end of the h line
14.  Then I hit the enter key 5 times and instead of 5 new line space I got 5
dash lines
15 NOTE  it is impossible to remove the all of  the dash lines that move closer
to the
proceeding text line without removing the text line itself


Please Let me know if you can fix this dash line problem

Take care!
Bill Signer
wsig...@sbcglobal.net

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113994] New: qt5 VCL plugin crashes on startup

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113994

Bug ID: 113994
   Summary: qt5 VCL plugin crashes on startup
   Product: LibreOffice
   Version: 6.0.0.0.alpha1+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: b...@lindev.ch

Trying to run LibreOffice 6.0.0.0.alpha1+ (git from today) with
SAL_USE_VCLPLUGIN=qt5 results in an immediate crash:
*** Error in `/usr/lib64/libreoffice/program/soffice.bin': malloc(): memory
corruption: 0x01454280 ***
The splash screen and a window with title "soffice.bin" remain open (but
there's nothing in the window).

The build works well with SAL_USE_VCLPLUGIN=default or SAL_USE_VCLPLUGIN=gtk

This is on OpenMandriva Cooker x86_64 -- linux 4.14, glibc 2.26, Qt
5.10.0-beta4, KF5 5.40.0, Plasma Desktop 5.11.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113538] Bundle and use open source Hebrew fonts by default

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113538

--- Comment #24 from Eyal Rozenberg  ---
Created attachment 137924
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137924=edit
Some header/body font combinations (David CLM, Libre, Narkisim)

Just to give a feel of what I've been taking about. For the David Libre spacing
issue, just look at the "Ze Dai" (זה די) sequence. Notice how the inter-letter
spacing between the Daled and Yod is essentially the same as the inter-word
spacing between the Yod and the following Vav.

(note some of the spacing may be messed up since I'm using LO 5.4 with the
spacing issue.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111622] FILEOPEN DOCX - Writer gets wrong color scheme, if color is set to 'Automatic'

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=111622

--- Comment #9 from Mike  ---
Forgot my configuration:

Version: 6.0.0.0.alpha1+ (x64)
Build ID: a5af0fd9f27af42cf2e8571f659cdad6e606215b
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-11-07_00:30:02
Locale: de-DE (de_DE); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111622] FILEOPEN DOCX - Writer gets wrong color scheme, if color is set to 'Automatic'

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=111622

Mike  changed:

   What|Removed |Added

Summary|FILEOPEN: DOCX rendered |FILEOPEN DOCX - Writer gets
   |with a greyscale chart  |wrong color scheme, if
   |instead of a colored.   |color is set to 'Automatic'

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111622] FILEOPEN: DOCX rendered with a greyscale chart instead of a colored.

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=111622

Mike  changed:

   What|Removed |Added

Version|4.4.7.2 release |3.3.0 release

--- Comment #7 from Mike  ---
I created a minimum test case for this issue, that I attached now („Minimum
test case.docx“). To create this, I took the original file „Greyscales instead
of colors.docx“ and cut it down.

Issue: LO renders the rectangle of „Minimum test case.docx“ in grey scales
(instead of blue). Writer gets the wrong color scheme.

Then did I changed the color of the rectangle from "Automatic" to blue. I saved
this as „Minimum Text case fixed.docx“. This does the Job for Writer.

In the fixed test case, word\charts\chart1.xml got the more 
lines (line 40 to 42):





This issue is there since LO 4.2. From release 3.3 to 4.0 only a blank page
appeared (with both files!)

I'm not a coder, but it seems to be about this:

„ChartShapeProperties“→“SolidFill“→“SchemeColor“

using DocumentFormat.OpenXml.Drawing;
using DocumentFormat.OpenXml;
namespace GeneratedCode
{
public class GeneratedClass
{
// Creates an SchemeColor instance and adds its children.
public SchemeColor GenerateSchemeColor()
{
SchemeColor schemeColor1 = new SchemeColor(){ Val = 
SchemeColorValues.Accent1 };
return schemeColor1;
}
}
}

I also attached a PDF with screenshots to this report.

Regards,

Mike

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111622] FILEOPEN: DOCX rendered with a greyscale chart instead of a colored.

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=111622

--- Comment #8 from Mike  ---
Created attachment 137923
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137923=edit
Screenshots and description

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113939] double underline - inconsistent shortcut across components

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113939

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|

--- Comment #4 from Heiko Tietze  ---
We discussed the idea in the design meeting and think consistency is paramount.
Therefore double underline should be available in all modules, however with a
consistent shortcut where shift+ctrl+U is a good option.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113939] double underline - inconsistent shortcut across components

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113939

Heiko Tietze  changed:

   What|Removed |Added

   Keywords||easyHack, needsDevEval

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 113939] double underline - inconsistent shortcut across components

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113939

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|

--- Comment #4 from Heiko Tietze  ---
We discussed the idea in the design meeting and think consistency is paramount.
Therefore double underline should be available in all modules, however with a
consistent shortcut where shift+ctrl+U is a good option.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 86303] STATUSBAR: Easy access to change to read only mode

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=86303

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|
  Component|LibreOffice |Writer

--- Comment #15 from Heiko Tietze  ---
The design team discussed the proposal and supports the idea. The additional
status bar entry should toggle the read/write mode, ideally not per single or
double click but via context menu to avoid unintentional activation, and
clearly show the document status.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 86303] STATUSBAR: Easy access to change to read only mode

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=86303

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|
  Component|LibreOffice |Writer

--- Comment #15 from Heiko Tietze  ---
The design team discussed the proposal and supports the idea. The additional
status bar entry should toggle the read/write mode, ideally not per single or
double click but via context menu to avoid unintentional activation, and
clearly show the document status.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87742] When image anchor is set to 'As Character' it should set vertical align to top

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=87742

--- Comment #8 from Heiko Tietze  ---
Design team was split about whether this change is beneficial or just unneeded.
But there was no objection to do it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Minutes from the design/UX meeting 2017-Nov-22

2017-11-22 Thread Heiko Tietze

Present: Thomas, Csongor, Jay, Heiko

 * Vertical alignment of images anchored as character
   + https://bugs.documentfoundation.org/show_bug.cgi?id=87742
   + screenshot - 
https://bug-attachments.documentfoundation.org/attachment.cgi?id=111368
   + WF because alignment depend on use case; center is as good as top (Heiko, 
Csongor)
   + Top is better than centered, ideally first line at top, last at bottom 
(Thomas)
   => no objection but not worth the effort

 * Toggle read access at statusbar
   + https://bugs.documentfoundation.org/show_bug.cgi?id=86303
   + no need for this feature in the sb => WF (Heiko)
   + use case: multiple open documents where some are secured by the function 
(Csongor)
   + 2x pro the suggestion, 1x no opinion, 1x con
   => go

 * Shortcut for Double Underline in all modules
   + https://bugs.documentfoundation.org/show_bug.cgi?id=113939
   + if we do that it requires to switch from ctrl+D to shift+ctrl+U in Writer 
(Heiko)
   + advantage of consistency but have a better shortcut (Thomas)
   => go with shift+ctrl+U for double underline for all modules

 * Change string from 'Left' to 'Default' or 'Start' or code 'Right' entry
   + https://bugs.documentfoundation.org/show_bug.cgi?id=98211
   => postponed for Stuart

 * Removal of tango, breeze and libreoffice palettes
   + https://bugs.documentfoundation.org/show_bug.cgi?id=113858
   + at least LibreOffice should remain as it is our branding (Heiko)
   + Thomas, Jay pro cleaning up
   + keep LibO, remove Tango/Breeze (Csongor)
   + better names for LibO? (Thomas)
  + idea has been refused last year 
https://bugs.documentfoundation.org/show_bug.cgi?id=104053
   => keep going

 * Removal of Open Sans, PT_Serif, Source Sans/Code fonts (Jay)
   + https://bugs.documentfoundation.org/show_bug.cgi?id=103080
   + ESC were against removing of Libertine and DejaVu
   + would still like to remove Open Sans, PT_Serif, Source Sans Pro
 and Source Code that were added in 4.0 and 4.4 now that we are
 bundling Noto Sans and Noto Serif families.
 + we dont bundle Source Serif Pro as it isnt available in italics
   https://bugs.documentfoundation.org/show_bug.cgi?id=79022
   + like many different fonts (Csongor)
   + hate many different fonts, esp. when not installed via distro management 
(Heiko)
   + no opinion, don't like too much very similar fonts (Thomas)
   + be mindful of fallback for unique glyphs, U+1f512 for example--Source Code 
Pro our only location (Stuart)
  + what did we do before Source Code Pro was added in 4.0? (Jay)
  + shove them into OpenSymbol, the Emoji support has been painful (Stuart)
   => AI: ESC should confirm removal of the three

 * Optimal column width
   + https://bugs.documentfoundation.org/show_bug.cgi?id=113604
(auto size behavior, "style" instead of direct formatting)
   + https://bugs.documentfoundation.org/show_bug.cgi?id=113960
(table properties: col sizing tedious)
   + solution could include UI proposal from 
https://bugs.documentfoundation.org/show_bug.cgi?id=113603
   + Working With Tables in Writer - 
https://docs.google.com/document/d/1D212Ihf8BYVOa1VjSPifq4sO_Cq4CZPhC0vya68zk3c
   => would be a cool GSoC project, needs a design session
   => keep tickets but do not make small patches



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-qa] Minutes from the design/UX meeting 2017-Nov-22

2017-11-22 Thread Heiko Tietze

Present: Thomas, Csongor, Jay, Heiko

 * Vertical alignment of images anchored as character
   + https://bugs.documentfoundation.org/show_bug.cgi?id=87742
   + screenshot - 
https://bug-attachments.documentfoundation.org/attachment.cgi?id=111368
   + WF because alignment depend on use case; center is as good as top (Heiko, 
Csongor)
   + Top is better than centered, ideally first line at top, last at bottom 
(Thomas)
   => no objection but not worth the effort

 * Toggle read access at statusbar
   + https://bugs.documentfoundation.org/show_bug.cgi?id=86303
   + no need for this feature in the sb => WF (Heiko)
   + use case: multiple open documents where some are secured by the function 
(Csongor)
   + 2x pro the suggestion, 1x no opinion, 1x con
   => go

 * Shortcut for Double Underline in all modules
   + https://bugs.documentfoundation.org/show_bug.cgi?id=113939
   + if we do that it requires to switch from ctrl+D to shift+ctrl+U in Writer 
(Heiko)
   + advantage of consistency but have a better shortcut (Thomas)
   => go with shift+ctrl+U for double underline for all modules

 * Change string from 'Left' to 'Default' or 'Start' or code 'Right' entry
   + https://bugs.documentfoundation.org/show_bug.cgi?id=98211
   => postponed for Stuart

 * Removal of tango, breeze and libreoffice palettes
   + https://bugs.documentfoundation.org/show_bug.cgi?id=113858
   + at least LibreOffice should remain as it is our branding (Heiko)
   + Thomas, Jay pro cleaning up
   + keep LibO, remove Tango/Breeze (Csongor)
   + better names for LibO? (Thomas)
  + idea has been refused last year 
https://bugs.documentfoundation.org/show_bug.cgi?id=104053
   => keep going

 * Removal of Open Sans, PT_Serif, Source Sans/Code fonts (Jay)
   + https://bugs.documentfoundation.org/show_bug.cgi?id=103080
   + ESC were against removing of Libertine and DejaVu
   + would still like to remove Open Sans, PT_Serif, Source Sans Pro
 and Source Code that were added in 4.0 and 4.4 now that we are
 bundling Noto Sans and Noto Serif families.
 + we dont bundle Source Serif Pro as it isnt available in italics
   https://bugs.documentfoundation.org/show_bug.cgi?id=79022
   + like many different fonts (Csongor)
   + hate many different fonts, esp. when not installed via distro management 
(Heiko)
   + no opinion, don't like too much very similar fonts (Thomas)
   + be mindful of fallback for unique glyphs, U+1f512 for example--Source Code 
Pro our only location (Stuart)
  + what did we do before Source Code Pro was added in 4.0? (Jay)
  + shove them into OpenSymbol, the Emoji support has been painful (Stuart)
   => AI: ESC should confirm removal of the three

 * Optimal column width
   + https://bugs.documentfoundation.org/show_bug.cgi?id=113604
(auto size behavior, "style" instead of direct formatting)
   + https://bugs.documentfoundation.org/show_bug.cgi?id=113960
(table properties: col sizing tedious)
   + solution could include UI proposal from 
https://bugs.documentfoundation.org/show_bug.cgi?id=113603
   + Working With Tables in Writer - 
https://docs.google.com/document/d/1D212Ihf8BYVOa1VjSPifq4sO_Cq4CZPhC0vya68zk3c
   => would be a cool GSoC project, needs a design session
   => keep tickets but do not make small patches



signature.asc
Description: OpenPGP digital signature
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 111622] FILEOPEN: DOCX rendered with a greyscale chart instead of a colored.

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=111622

--- Comment #6 from Mike  ---
Created attachment 137922
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137922=edit
Manually "fixed" Minimum test case

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111622] FILEOPEN: DOCX rendered with a greyscale chart instead of a colored.

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=111622

--- Comment #5 from Mike  ---
Created attachment 137921
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137921=edit
Minimum test case

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: translations

2017-11-22 Thread Christian Lohmaier

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit dbe27473220cef519afde0a0acc67845bab596c8
Author: Christian Lohmaier 
Date:   Wed Nov 22 19:49:53 2017 +0100

Updated core
Project: translations  a0c08eb77f9fd9e3b53f5c40abb554e83195fa27

update translations for 6.0 beta1

and force-fix errors using pocheck

Change-Id: Ie5900800b8c1f0e6064d00b2b028afcf51e84e20

diff --git a/translations b/translations
index e113c687b97d..a0c08eb77f9f 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit e113c687b97d0f1b3b5a0afdddc04d2de33edb20
+Subproject commit a0c08eb77f9fd9e3b53f5c40abb554e83195fa27
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: extensions/source starmath/source

2017-11-22 Thread qzheng

 extensions/source/config/ldap/ldapaccess.cxx |   31 +--
 starmath/source/dialog.cxx   |5 +---
 2 files changed, 18 insertions(+), 18 deletions(-)

New commits:
commit 1783b33b52c4332be6163d15ae78bbeb4e16c172
Author: qzheng 
Date:   Tue Nov 14 15:19:26 2017 +0800

tdf#112689 Replace chained O(U)StringBuffer::append with operator+

Change OUStringBuffer::append() to operator+.

Change-Id: I13232cb69b1d62acfcf15d5ba5a2d72e5ab5d253
Reviewed-on: https://gerrit.libreoffice.org/44703
Tested-by: Jenkins 
Reviewed-by: Mark Hung 
Reviewed-by: Michael Stahl 

diff --git a/extensions/source/config/ldap/ldapaccess.cxx 
b/extensions/source/config/ldap/ldapaccess.cxx
index 1f6667ce4851..caece9d1cde5 100644
--- a/extensions/source/config/ldap/ldapaccess.cxx
+++ b/extensions/source/config/ldap/ldapaccess.cxx
@@ -66,13 +66,13 @@ static void checkLdapReturnCode(const sal_Char *aOperation,
 {
 if (aRetCode == LDAP_SUCCESS) { return ; }
 
-OUStringBuffer message;
+OUString message;
 
 if (aOperation != nullptr)
 {
-message.appendAscii(aOperation).append(": ") ;
+message += OUString::createFromAscii(aOperation) + ": ";
 }
-message.appendAscii(ldap_err2string(aRetCode)).append(" (") ;
+message += OUString::createFromAscii(ldap_err2string(aRetCode)) + " (" ;
 sal_Char *stub = nullptr ;
 
 #ifndef LDAP_OPT_SIZELIMIT // for use with OpenLDAP
@@ -80,7 +80,7 @@ static void checkLdapReturnCode(const sal_Char *aOperation,
 #endif
 if (stub != nullptr)
 {
-message.appendAscii(stub) ;
+message += OUString::createFromAscii(stub) ;
 // It would seem the message returned is actually
 // not a copy of a string but rather some static
 // string itself. At any rate freeing it seems to
@@ -88,10 +88,9 @@ static void checkLdapReturnCode(const sal_Char *aOperation,
 // This call is thus disabled for the moment.
 //ldap_memfree(stub) ;
 }
-else { message.append("No additional information") ; }
-message.append(")") ;
-throw ldap::LdapGenericException(message.makeStringAndClear(),
- nullptr, aRetCode) ;
+else { message += "No additional information" ; }
+message += ")" ;
+throw ldap::LdapGenericException(message, nullptr, aRetCode) ;
 }
 
 void  LdapConnection::connectSimple(const LdapDefinition& aDefinition)
@@ -234,11 +233,13 @@ void LdapConnection::initConnection()
 nullptr, 0) ;
 }
 
-
-OUStringBuffer filter( "(&(objectclass=" );
-
-filter.append( mLdapDefinition.mUserObjectClass ).append(")(") ;
-filter.append( mLdapDefinition.mUserUniqueAttr 
).append("=").append(aUser).append("))") ;
+OUString filter = "(&(objectclass="
++ mLdapDefinition.mUserObjectClass
++ ")("
++ mLdapDefinition.mUserUniqueAttr
++ "="
++ aUser
++ "))";
 
 LdapMessageHolder result;
 #ifdef _WIN32
@@ -246,13 +247,13 @@ void LdapConnection::initConnection()
 LdapErrCode retCode = ldap_search_sW(mConnection,
   
const_cast(o3tl::toW(mLdapDefinition.mBaseDN.getStr())),
   LDAP_SCOPE_SUBTREE,
-  
const_cast(o3tl::toW(filter.makeStringAndClear().getStr())), attributes, 
0, ) ;
+  
const_cast(o3tl::toW(filter.getStr())), attributes, 0, ) ;
 #else
 sal_Char * attributes [2] = { const_cast(LDAP_NO_ATTRS), 
nullptr };
 LdapErrCode retCode = ldap_search_s(mConnection,
   OUStringToOString( 
mLdapDefinition.mBaseDN, RTL_TEXTENCODING_UTF8 ).getStr(),
   LDAP_SCOPE_SUBTREE,
-  OUStringToOString( 
filter.makeStringAndClear(), RTL_TEXTENCODING_UTF8 ).getStr(), attributes, 0, 
) ;
+  OUStringToOString( filter, 
RTL_TEXTENCODING_UTF8 ).getStr(), attributes, 0, ) ;
 #endif
 checkLdapReturnCode("FindUserDn", retCode) ;
 OUString userDn ;
diff --git a/starmath/source/dialog.cxx b/starmath/source/dialog.cxx
index f710aa1988f0..e02ad89b86c6 100644
--- a/starmath/source/dialog.cxx
+++ b/starmath/source/dialog.cxx
@@ -1484,12 +1484,11 @@ IMPL_LINK_NOARG( SmSymbolDialog, GetClickHdl, Button*, 
void )
 const SmSym *pSym = GetSymbol();
 if (pSym)
 {
-OUStringBuffer aText;
-aText.append('%').append(pSym->GetName()).append(' ');
+OUString aText = "%" + pSym->GetName() + " ";
 
 rViewSh.GetViewFrame()->GetDispatcher()->ExecuteList(
 SID_INSERTSYMBOL, SfxCallMode::RECORD,
-{ new SfxStringItem(SID_INSERTSYMBOL, 
aText.makeStringAndClear())

[Libreoffice-bugs] [Bug 112689] Replace chained O(U)StringBuffer::append() with operator+

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112689

--- Comment #8 from Commit Notification 
 ---
qzheng committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1783b33b52c4332be6163d15ae78bbeb4e16c172

tdf#112689 Replace chained O(U)StringBuffer::append with operator+

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39593] copy/paste code detector / fixing

2017-11-22 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #30 from Commit Notification 
 ---
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=95da9d4c8f320d865939ef2cea268ad1aac20a8e

Follow our naming conventions, tdf#39593 follow-up

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2017-11-22 Thread Eike Rathke

 sc/source/ui/inc/output.hxx   |2 +-
 sc/source/ui/view/output2.cxx |   22 +++---
 2 files changed, 12 insertions(+), 12 deletions(-)

New commits:
commit 95da9d4c8f320d865939ef2cea268ad1aac20a8e
Author: Eike Rathke 
Date:   Wed Nov 22 21:14:10 2017 +0100

Follow our naming conventions, tdf#39593 follow-up

Change-Id: Iee95b5bf0dd42169447163a41be5b2aa1899e83c

diff --git a/sc/source/ui/inc/output.hxx b/sc/source/ui/inc/output.hxx
index 7abff2e541e2..2237b7daa560 100644
--- a/sc/source/ui/inc/output.hxx
+++ b/sc/source/ui/inc/output.hxx
@@ -250,7 +250,7 @@ private:
 bool Clip( DrawEditParam& rParam, const Size& aCellSize, OutputAreaParam& 
aAreaParam,
long nEngineHeight, bool bWrapFields);
 
-bool AdjustAreaParamClipRect(OutputAreaParam& aAreaParam);
+bool AdjustAreaParamClipRect(OutputAreaParam& rAreaParam);
 
 public:
 /**
diff --git a/sc/source/ui/view/output2.cxx b/sc/source/ui/view/output2.cxx
index a3a0348a3dd5..c6918b04640f 100644
--- a/sc/source/ui/view/output2.cxx
+++ b/sc/source/ui/view/output2.cxx
@@ -2720,29 +2720,29 @@ void 
ScOutputData::DrawEditParam::adjustForHyperlinkInPDF(Point aURLStart, const
 }
 
 // Returns true if the rect is clipped vertically
-bool ScOutputData::AdjustAreaParamClipRect(OutputAreaParam& aAreaParam)
+bool ScOutputData::AdjustAreaParamClipRect(OutputAreaParam& rAreaParam)
 {
-if( aAreaParam.maClipRect.Left() < nScrX )
+if( rAreaParam.maClipRect.Left() < nScrX )
 {
-aAreaParam.maClipRect.Left() = nScrX;
-aAreaParam.mbLeftClip = true;
+rAreaParam.maClipRect.Left() = nScrX;
+rAreaParam.mbLeftClip = true;
 }
-if( aAreaParam.maClipRect.Right() > nScrX + nScrW )
+if( rAreaParam.maClipRect.Right() > nScrX + nScrW )
 {
-aAreaParam.maClipRect.Right() = nScrX + nScrW;  //! minus one?
-aAreaParam.mbRightClip = true;
+rAreaParam.maClipRect.Right() = nScrX + nScrW;  //! minus one?
+rAreaParam.mbRightClip = true;
 }
 
 bool bVClip = false;
 
-if( aAreaParam.maClipRect.Top() < nScrY )
+if( rAreaParam.maClipRect.Top() < nScrY )
 {
-aAreaParam.maClipRect.Top() = nScrY;
+rAreaParam.maClipRect.Top() = nScrY;
 bVClip = true;
 }
-if( aAreaParam.maClipRect.Bottom() > nScrY + nScrH )
+if( rAreaParam.maClipRect.Bottom() > nScrY + nScrH )
 {
-aAreaParam.maClipRect.Bottom() = nScrY + nScrH; //! minus one?
+rAreaParam.maClipRect.Bottom() = nScrY + nScrH; //! minus one?
 bVClip = true;
 }
 return bVClip;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

1 2 3 >

1 - 100 of 286 matches

Mail list logo