[Libreoffice-bugs] [Bug 113908] [PIVOT TABLE]: filter of grouped date disappears after resaving XLSX file

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113908

--- Comment #5 from kompilainenn <79045_79...@mail.ru> ---
(In reply to Bartosz from comment #4)
> How I could edit filter of grouped date in MS Excel?
> 
> I would like to recreate similar document by ownself.
> How I could create such grouped filter?


0. create table with date in one column and any data in another columns
1. insert pivot table
2. In dialogue Pivot Table Layout: move field "date" from "Available fields" to
"Row fields", another field move to you need. Push "OK"
3. In pivot table right click on any cell with date and press F12 on keyboard.
Opens dialogue "Grouping"
4. Select Intervals (checkbox) "Months" and "Years". Press "OK"
5. On pivot table right click and select from context menu "Edit layout"
6. In dialogue Pivot Table Layout: move fields "date" and "Years" from "Row
fields" to "Page fields", another field move to you need. Push "OK"
7. In top of pivot table must creates two filter

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114037] Writer documents print only in landscape orientation

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114037

Telesto  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Telesto  ---


*** This bug has been marked as a duplicate of bug 92190 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92190] PRINTs landscape despite configured as portrait (Mac OS)

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=92190

Telesto  changed:

   What|Removed |Added

 CC||david.daved...@gmail.com

--- Comment #99 from Telesto  ---
*** Bug 114037 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113932] Make Select text by clicking in Margins MSO compliant

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113932

Magalaan  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |---
 Ever confirmed|0   |1

--- Comment #3 from Magalaan  ---
Excuse me for reopening, but I beg to differ because: 

1 
it makes no sense to have the same meaning for clicking in the margin as in the
text itself. One of the good things MS did is standardizing actions throughout
Windows and MSO. Clicking to left of a row/line generally means to select that
row. It works in Word text, it works in Excel, it works in Access, it works in
tables, and other situations. It is both intuitive and efficient. 

2 
Many people have trouble with double clicks. 3 clicks to select a sentence is
absurd, 4 clicks to select a paragraph is undoable. I fail most of the times,
because the clicks have to be in the exact same pace to succeed. You can not
expect people to train for this. Besides as one click in the margin does not
select anything, they will never even discover that double, triple, quadrupple
clicking in the margin selects even more. (Not that you would want to select
more than a line). 

3 
It is not about being correct, but about what works better. MSO solution is
clearly the superior one. 
When I suggest improvements here, I often met the counter argument that it is
not MSO compatible. It is really funny that you use the same argument the other
way (We do not care about being MSO compatible). So you rather prefer an
inferior solution than the better one that is the industry standard?  

5
I work a lot with both Writer and Word. When you are editing documents a lot,
the most basic operations become the most important for efficiency as you use
them all the time. For instance when I want to format a word I do not select it
by double clicking but click in the word and choose the style. This many times
faster and much less straining as repeated double clicking puts a lot of strain
on you hands (RSI). In the same way it may seem totally futile to you, but for
heavy users like me it really makes a difference if I can select a header with
only one click and format it. Try to format a text of a hundred pages and it
will soon become clear to you what I mean. 

In practice I will very rarely use double click to select a word (only to
delete  or replace it), I never use triple click to select a sentence, and
quadruple click to select paragraphs? I would not even dare go there. I will
select a longer text by dragging like all sane people. 

6
By the way, I found more strange behavior. I use writer for logging activities
starting each entry with a creation date field (that I assigned to a key). But
whenever you double-click in the margin before a line that starts with a field,
it start to edit the field (it executes a double-click on the first word). 

7
As to tables. I was talking about selecting a single cell by clicking in the
top  left corner. That is easy to empty cells. (But I agree  with Dieter this
should be a in different report)


I do not want to make things more difficult, just easier for users. I agree we
should rather want to improve on MSO. Let me make different suggestion, that
may make the code easier as well:

SUGGESTION:
- one click in the margin selects a whole paragraph. 
- double click in margin selects a whole paragraph + empty lines

JUSTIFICATION:
- A header is always one paragraph anyway, so this works for headers as well.
You never really want to select a line as part of a sentence. (Look at this
browser, triple click select a paragraph, not a line). 
- By selecting the following empty lines as well it becomes easy to move or
delete a paragraph. 

Frankly that is all a user needs in practice. I never select lines unless it is
a whole paragraph. I rarely select sentences (and even then by dragging). I do
select paragraphs. And on editing documents I often move paragraphs to change
the logical order. All we need can simply be done with one click. 

The Word Processor is a work horse for many people like me. If you can bring
the number of clicks down, that is a huge thing. One click in stead of two or
three clicks, that is a lot of clicks over a day. It is these details that can
make a lot of difference.  

If you do not appreciate me making suggestions, please say so, and I will stop
bothering.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113947] If open the document with the button, the controlfeld of button have wrong entries.

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113947

--- Comment #3 from Olaf Hautow  ---
The two documents are in attachement 137873 of 2017-11-20.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2017-11-24 Thread Matteo Casalin 
 sw/source/core/layout/calcmove.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 60fc08111d6453ca79603b4c5c85be05e45c35e7
Author: Matteo Casalin 
Date:   Wed Nov 1 11:16:42 2017 +0100

Fix a likely copypasta

All dimensions set to 0 seems to be a correct setting for an empty page.

Change-Id: Idf8a587ab405ecd07b44a7c80d5d2eaf98e1c146

diff --git a/sw/source/core/layout/calcmove.cxx 
b/sw/source/core/layout/calcmove.cxx
index 3a770bcb6a2b..de694019e1bd 100644
--- a/sw/source/core/layout/calcmove.cxx
+++ b/sw/source/core/layout/calcmove.cxx
@@ -777,10 +777,10 @@ void SwPageFrame::MakeAll(vcl::RenderContext* 
pRenderContext)
 {
 SwFrameAreaDefinition::FrameAreaWriteAccess aFrm(*this);
 aFrm.Width( 0 );
-aFrm.Width( 0 );
+aFrm.Height( 0 );
 
 SwFrameAreaDefinition::FramePrintAreaWriteAccess aPrt(*this);
-aPrt.Height( 0 );
+aPrt.Width( 0 );
 aPrt.Height( 0 );
 aPrt.Left( 0 );
 aPrt.Top( 0 );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/inc sc/qa sc/source

2017-11-24 Thread Tor Lillqvist 
 sc/inc/conditio.hxx|   54 
 sc/qa/unit/subsequent_filters-test.cxx |4 
 sc/qa/unit/ucalc_condformat.cxx|   40 +++---
 sc/qa/unit/ucalc_formula.cxx   |2 
 sc/source/core/data/conditio.cxx   |  162 -
 sc/source/core/data/validat.cxx|6 
 sc/source/filter/excel/xecontent.cxx   |  136 ++--
 sc/source/filter/excel/xicontent.cxx   |   38 ++---
 sc/source/filter/inc/condformatbuffer.hxx  |3 
 sc/source/filter/oox/condformatbuffer.cxx  |   82 ++--
 sc/source/filter/xml/xmlcondformat.cxx |   52 
 sc/source/filter/xml/xmlexprt.cxx  |   52 
 sc/source/ui/condformat/condformatdlg.cxx  |2 
 sc/source/ui/condformat/condformatdlgentry.cxx |   98 +++
 sc/source/ui/condformat/condformathelper.cxx   |6 
 sc/source/ui/dbgui/validate.cxx|   36 ++---
 sc/source/ui/unoobj/condformatuno.cxx  |   54 
 sc/source/ui/unoobj/fmtuno.cxx |   64 -
 sc/source/ui/view/cellsh2.cxx  |   10 -
 19 files changed, 451 insertions(+), 450 deletions(-)

New commits:
commit b48950d8b326d29891b809434fd862e960e2ec99
Author: Tor Lillqvist 
Date:   Thu Nov 23 16:22:38 2017 +0200

Convert ScConditionMode to scoped enum

Change-Id: I9b6aaa64e7f649581b27f0238e2908026ab6e0bd
Reviewed-on: https://gerrit.libreoffice.org/45157
Tested-by: Jenkins 
Reviewed-by: Tor Lillqvist 

diff --git a/sc/inc/conditio.hxx b/sc/inc/conditio.hxx
index 79554b1a8d67..10906f0dbacb 100644
--- a/sc/inc/conditio.hxx
+++ b/sc/inc/conditio.hxx
@@ -56,34 +56,34 @@ struct RefUpdateMoveTabContext;
 //  nOptions Flags
 #define SC_COND_NOBLANKS1
 
-enum ScConditionMode
+enum class ScConditionMode
 {
-SC_COND_EQUAL,
-SC_COND_LESS,
-SC_COND_GREATER,
-SC_COND_EQLESS,
-SC_COND_EQGREATER,
-SC_COND_NOTEQUAL,
-SC_COND_BETWEEN,
-SC_COND_NOTBETWEEN,
-SC_COND_DUPLICATE,
-SC_COND_NOTDUPLICATE,
-SC_COND_DIRECT,
-SC_COND_TOP10,
-SC_COND_BOTTOM10,
-SC_COND_TOP_PERCENT,
-SC_COND_BOTTOM_PERCENT,
-SC_COND_ABOVE_AVERAGE,
-SC_COND_BELOW_AVERAGE,
-SC_COND_ABOVE_EQUAL_AVERAGE,
-SC_COND_BELOW_EQUAL_AVERAGE,
-SC_COND_ERROR,
-SC_COND_NOERROR,
-SC_COND_BEGINS_WITH,
-SC_COND_ENDS_WITH,
-SC_COND_CONTAINS_TEXT,
-SC_COND_NOT_CONTAINS_TEXT,
-SC_COND_NONE
+Equal,
+Less,
+Greater,
+EqLess,
+EqGreater,
+NotEqual,
+Between,
+NotBetween,
+Duplicate,
+NotDuplicate,
+Direct,
+Top10,
+Bottom10,
+TopPercent,
+BottomPercent,
+AboveAverage,
+BelowAverage,
+AboveEqualAverage,
+BelowEqualAverage,
+Error,
+NoError,
+BeginsWith,
+EndsWith,
+ContainsText,
+NotContainsText,
+NONE
 };
 
 class ScFormulaListener : public SvtListener
diff --git a/sc/qa/unit/subsequent_filters-test.cxx 
b/sc/qa/unit/subsequent_filters-test.cxx
index 9f3bc88ba9f3..1a1ff8fa6452 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -1314,14 +1314,14 @@ void ScFiltersTest::testDataValidityODS()
 
 //sheet1's expected Data Validation Entry values
 ValDataTestParams aVDTParams1(
-SC_VALID_DECIMAL, SC_COND_GREATER, "3.14", EMPTY_OUSTRING, rDoc,
+SC_VALID_DECIMAL, ScConditionMode::Greater, "3.14", EMPTY_OUSTRING, 
rDoc,
 aValBaseAddr1, "Too small",
 "The number you are trying to enter is not greater than 3.14! Are you 
sure you want to enter it anyway?",
 SC_VALERR_WARNING, 1
 );
 //sheet2's expected Data Validation Entry values
 ValDataTestParams aVDTParams2(
-SC_VALID_WHOLE, SC_COND_BETWEEN, "1", "10", rDoc,
+SC_VALID_WHOLE, ScConditionMode::Between, "1", "10", rDoc,
 aValBaseAddr2, "Error sheet 2",
 "Must be a whole number between 1 and 10.",
 SC_VALERR_STOP, 2
diff --git a/sc/qa/unit/ucalc_condformat.cxx b/sc/qa/unit/ucalc_condformat.cxx
index 1e3d94473522..f98d2e94b8eb 100644
--- a/sc/qa/unit/ucalc_condformat.cxx
+++ b/sc/qa/unit/ucalc_condformat.cxx
@@ -100,7 +100,7 @@ void Test::testCondFormatINSDEL()
 ScConditionalFormat* pFormat = new ScConditionalFormat(1, m_pDoc);
 ScRangeList aRangeList(ScRange(0,0,0,0,3,0));
 pFormat->SetRange(aRangeList);
-ScCondFormatEntry* pEntry = new 
ScCondFormatEntry(SC_COND_DIRECT,"=B2","",m_pDoc,ScAddress(0,0,0),ScGlobal::GetRscString(STR_STYLENAME_RESULT));
+ScCondFormatEntry* pEntry = new 
ScCondFormatEntry(ScConditionMode::Direct,"=B2","",m_pDoc,ScAddress(0,0,0),ScGlobal::GetRscString(STR_STYLENAME_RESULT));
 pFormat->AddEntry(pEntry);
 
 m_pDoc->AddCondFormatData(pFormat->GetRange(), 0, 1);
@@ -125,7 +125,7 @@ void

[Libreoffice-commits] core.git: include/formula

2017-11-24 Thread Tor Lillqvist 
 include/formula/opcode.hxx |  475 +
 1 file changed, 475 insertions(+)

New commits:
commit bfa72a6a2a83ed10793d9723a1db24ec8ee03ed9
Author: Tor Lillqvist 
Date:   Fri Nov 24 22:37:26 2017 +0200

Add a debugging output OpCodeEnumToString() function

Change-Id: I5382107dc556df822292e72af48d23e04a3408a2
Reviewed-on: https://gerrit.libreoffice.org/45261
Reviewed-by: Tor Lillqvist 
Tested-by: Tor Lillqvist 

diff --git a/include/formula/opcode.hxx b/include/formula/opcode.hxx
index 181de360864e..88527b9244ee 100644
--- a/include/formula/opcode.hxx
+++ b/include/formula/opcode.hxx
@@ -20,6 +20,8 @@
 #ifndef INCLUDED_FORMULA_OPCODE_HXX
 #define INCLUDED_FORMULA_OPCODE_HXX
 
+#include 
+
 #include 
 #include 
 
@@ -511,6 +513,479 @@ enum OpCode : sal_uInt16
 ocNone  = SC_OPCODE_NONE
 };
 
+// Only to be used for debugging output. No guarantee of stability of the
+// return value.
+
+// Turn this into an operator<< when OpCode becomes a scoped enum
+
+inline std::string OpCodeEnumToString(OpCode eCode)
+{
+switch (eCode)
+{
+case ocPush: return "Push";
+case ocCall: return "Call";
+case ocStop: return "Stop";
+case ocExternal: return "External";
+case ocName: return "Name";
+case ocExternalRef: return "ExternalRef";
+case ocIf: return "If";
+case ocIfError: return "IfError";
+case ocIfNA: return "IfNA";
+case ocChoose: return "Choose";
+case ocOpen: return "Open";
+case ocClose: return "Close";
+case ocTableRefOpen: return "TableRefOpen";
+case ocTableRefClose: return "TableRefClose";
+case ocSep: return "Sep";
+case ocArrayOpen: return "ArrayOpen";
+case ocArrayClose: return "ArrayClose";
+case ocArrayRowSep: return "ArrayRowSep";
+case ocArrayColSep: return "ArrayColSep";
+case ocMissing: return "Missing";
+case ocBad: return "Bad";
+case ocStringXML: return "StringXML";
+case ocSpaces: return "Spaces";
+case ocMatRef: return "MatRef";
+case ocTableRefItemAll: return "TableRefItemAll";
+case ocTableRefItemHeaders: return "TableRefItemHeaders";
+case ocTableRefItemData: return "TableRefItemData";
+case ocTableRefItemTotals: return "TableRefItemTotals";
+case ocTableRefItemThisRow: return "TableRefItemThisRow";
+case ocSkip: return "Skip";
+case ocDBArea: return "DBArea";
+case ocTableRef: return "TableRef";
+case ocMacro: return "Macro";
+case ocColRowName: return "ColRowName";
+case ocColRowNameAuto: return "ColRowNameAuto";
+case ocPercentSign: return "PercentSign";
+case ocErrNull: return "ErrNull";
+case ocErrDivZero: return "ErrDivZero";
+case ocErrValue: return "ErrValue";
+case ocErrRef: return "ErrRef";
+case ocErrName: return "ErrName";
+case ocErrNum: return "ErrNum";
+case ocErrNA: return "ErrNA";
+case ocAdd: return "Add";
+case ocSub: return "Sub";
+case ocMul: return "Mul";
+case ocDiv: return "Div";
+case ocAmpersand: return "Ampersand";
+case ocPow: return "Pow";
+case ocEqual: return "Equal";
+case ocNotEqual: return "NotEqual";
+case ocLess: return "Less";
+case ocGreater: return "Greater";
+case ocLessEqual: return "LessEqual";
+case ocGreaterEqual: return "GreaterEqual";
+case ocAnd: return "And";
+case ocOr: return "Or";
+case ocXor: return "Xor";
+case ocIntersect: return "Intersect";
+case ocUnion: return "Union";
+case ocRange: return "Range";
+case ocNot: return "Not";
+case ocNeg: return "Neg";
+case ocNegSub: return "NegSub";
+case ocPi: return "Pi";
+case ocRandom: return "Random";
+case ocTrue: return "True";
+case ocFalse: return "False";
+case ocGetActDate: return "GetActDate";
+case ocGetActTime: return "GetActTime";
+case ocNotAvail: return "NotAvail";
+case ocCurrent: return "Current";
+case ocDeg: return "Deg";
+case ocRad: return "Rad";
+case ocSin: return "Sin";
+case ocCos: return "Cos";
+case ocTan: return "Tan";
+case ocCot: return "Cot";
+case ocArcSin: return "ArcSin";
+case ocArcCos: return "ArcCos";
+case ocArcTan: return "ArcTan";
+case ocArcCot: return "ArcCot";
+case ocSinHyp: return "SinHyp";
+case ocCosHyp: return "CosHyp";
+case ocTanHyp: return "TanHyp";
+case ocCotHyp: return "CotHyp";
+case ocArcSinHyp: return "ArcSinHyp";
+case ocArcCosHyp: return "ArcCosHyp";
+case ocArcTanHyp: return "ArcTanHyp";
+case ocArcCotHyp: return "ArcCotHyp";
+case ocCosecant: return "Cosecant";
+case ocSecant: return "Secant";
+case ocCosecantHyp: return "CosecantHyp";
+case ocSecantHyp: return "SecantHyp";
+case ocExp: return "Exp";
+case ocLn: return "Ln";
+case ocSqrt: return "Sqrt";
+case ocFact: return "Fact";
+case ocGetYear: return

[Libreoffice-bugs] [Bug 114008] Fehler Übersetzung Writer Tabellen

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114008

tommy27  changed:

   What|Removed |Added

 CC||ba...@quipo.it

--- Comment #4 from tommy27  ---
please translate in english the bug report title and description

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sccomp/qa

2017-11-24 Thread Stephan Bergmann 
 sccomp/qa/unit/SwarmSolverTest.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1fa761af825641da5c87f80c2a17135f92418960
Author: Stephan Bergmann 
Date:   Fri Nov 24 15:30:48 2017 +0100

Ridiculously large delta for SwarmSolverTest::testUnconstrained for now

At least the Jenkins lo_ubsan build sporadically keeps failing
CppunitTest_sccomp_swarmsolvertest due to rather widely off values here
(3.00064356398118 in  
and
2.8639022684852 in ), 
so
suggestion by Tomaž Vajngerl was: "Let's adapt the delta for now. Generally
anything close to 3 should be acceptable as the algorithm greatly depends on
random values."

Change-Id: Id8f8657e521381decb1c719a1cffdf959ae74ef4
Reviewed-on: https://gerrit.libreoffice.org/45231
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/sccomp/qa/unit/SwarmSolverTest.cxx 
b/sccomp/qa/unit/SwarmSolverTest.cxx
index 918cd9103021..0be632dfb174 100644
--- a/sccomp/qa/unit/SwarmSolverTest.cxx
+++ b/sccomp/qa/unit/SwarmSolverTest.cxx
@@ -103,7 +103,7 @@ void SwarmSolverTest::testUnconstrained()
 uno::Sequence aSolution = xSolver->getSolution();
 
 CPPUNIT_ASSERT_EQUAL(aSolution.getLength(), aVariables.getLength());
-CPPUNIT_ASSERT_DOUBLES_EQUAL(3.0, aSolution[0], 1E-5);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(3.0, aSolution[0], .2);
 }
 
 void SwarmSolverTest::testVariableBounded()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106208] Writer loses last user event if auto-save triggers at a similar times

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106208

--- Comment #5 from Luke Kendall  ---
Created attachment 137973
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137973=edit
Obfuscated sample long doc

Here is a requested long file.  (For me, a manualsave takes about 10 secs.
Which reminds me: auto-save seems to take a lot longer than a manual save. I
don't know if that's to be expected.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108230] [META] OOXML document theme issues

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=108230

Aron Budea  changed:

   What|Removed |Added

 Depends on||113271


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113271
[Bug 113271] FILEOPEN: XLSX: Incorrect font colour
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113271] FILEOPEN: XLSX: Incorrect font colour

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113271

--- Comment #8 from Bartosz  ---
With indexed colour, rgb and them, 


The priority is as follows:
1. theme
2. rgb
3. indexed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113271] FILEOPEN: XLSX: Incorrect font colour

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113271

Bartosz  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |gan...@poczta.onet.pl
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113271] FILEOPEN: XLSX: Incorrect font colour

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113271

--- Comment #7 from Bartosz  ---
I understand what is the root cause of problem.
If both rgb and theme is specified, like:


Then the "theme" should be taken into account instead of rgb

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113271] FILEOPEN: XLSX: Incorrect font colour

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113271

--- Comment #6 from Bartosz  ---
http://c-rex.net/projects/samples/ooxml/e1/Part4/OOXML_P4_DOCX_bgColor_topic_ID0ERK35.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113271] FILEOPEN: XLSX: Incorrect font colour

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113271

--- Comment #5 from Bartosz  ---
Generally both rgb="FF" and rgb="00", MS Excel is interpreting as Black
colour.
I think this is the main difference between LO and MS Excel.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113271] FILEOPEN: XLSX: Incorrect font colour

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113271

--- Comment #4 from Bartosz  ---
Import of font attributes is inside the file
sc/source/filter/oox/stylesbuffer.cxx inside method "void
Font::importAttribs(". We need to make sure that "color" is used properly
according to design (which is Data Bar Color):
http://www.contextures.com/excel-conditional-formatting-data-bars.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113532] Bundle and use open source Arabic fonts by default

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113532

--- Comment #14 from Yousuf Philips (jay)  ---
So i'll be tackling the issue of what we should bundle in this comment.

Windows and Mac both provide a calligraphy-styled Naskh font (Arabic
Typesetting, DecoType Naskh), a Kufi font (Andalus, KufiStandard GK), a variety
of regular Naskh fonts, including a default arabic fallback font (Simplified
Arabic/Times New Roman, Geeza Pro). Windows also includes monospace fonts
(Courier New, Simplified Arabic Fixed) and sans fonts (Tahoma, Segoe UI).

So in order to help Windows and Mac users to use open source arabic fonts, as
well as ensure interoperability of documents created on linux with the
available open source arabic fonts, we should bundle

* calligraphy-styled Naskh - Amiri
* traditional-styled Naskh - KACSTOffice, KACSTBook, Scheherazade
* Kufi-style   - Reem Kufi
* mono-space fonts - Ara­bic-Latin Modern Fixed, Thabit
* sans font- Noto Sans Arabic

I've left out fonts from the Arabeyes collection and XB Niloofar based on
Khaled's recommendation of their legal status. I also didnt include Noto/Droid
Kufi and Noto/Droid Naskh in the list as we are already shipping them (bug
103080).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113532] Bundle and use open source Arabic fonts by default

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113532

--- Comment #13 from Yousuf Philips (jay)  ---
Created attachment 137972
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137972=edit
open source arabic fonts grouped based on look/style

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112950] PDF: Hebrew characters overlapping or very close together with David CLM font

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=112950

--- Comment #18 from Xisco Faulí  ---
My question after reading comment 14 is, is this issue fixed on master? then we
can close it as RESOLVED WORKSFORME...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114037] Writer documents print only in landscape orientation

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114037

--- Comment #1 from Daveduck  ---
Restarted in Safe Mode, no change.

Restarted in Safe Mode, reset to factory defaults.  No change.

Deleted User Profile, restarted.  No change.

Restored User Profile (latest version), reverted to LO ver. 5.3.3.1, issue no
longer present.  (However, I'm using 5.3.3.1)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114023] Insert -> Field -> More Fields, or +, Fields dialog showing incorrect selection listbox contents

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114023

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||xiscofa...@libreoffice.org

--- Comment #7 from Xisco Faulí  ---
Regression introduced by:

author  Caolán McNamara 2017-06-11 19:56:30 (GMT)
committer   Caolán McNamara 2017-07-21 07:20:50
(GMT)
commit  00657aef09d854c74fb426a935a3e8b1fc390bb0 (patch)
treefd1a9bb264fe15dcc129498e62060ecd256b1ee7
parent  fa987cbb813cfd729fe490f2f1258b7c8d7fb174 (diff)
migrate to boost::gettext

Bisected with: bibisect-linux64-6.0

Adding Cc: to Caolán McNamara

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: external/libassuan

2017-11-24 Thread Thorsten Behrens 
 external/libassuan/w32-build-fixes.patch.1 |   24 
 1 file changed, 24 deletions(-)

New commits:
commit ff54dc5e63169aff0c4e7ef1a062468ee3124c77
Author: Thorsten Behrens 
Date:   Fri Nov 24 16:48:32 2017 +0100

libassuan: cleanup patchset

As noted by Stephan in gerrit#42745

Change-Id: Id8fd3000e7469b9eb2a0c5301ef9ce71b8a77723
Reviewed-on: https://gerrit.libreoffice.org/45242
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/external/libassuan/w32-build-fixes.patch.1 
b/external/libassuan/w32-build-fixes.patch.1
index c9250c4e5573..f8125496f6ad 100755
--- a/external/libassuan/w32-build-fixes.patch.1
+++ b/external/libassuan/w32-build-fixes.patch.1
@@ -1,27 +1,3 @@
 libassuan.orig/src/Makefile.in 2017-09-15 08:16:41.601057500 +0200
-+++ libassuan/src/Makefile.in  2017-09-24 13:01:24.950711300 +0200
-@@ -424,7 +424,7 @@
- nodist_include_HEADERS = assuan.h
- @HAVE_LD_VERSION_SCRIPT_FALSE@libassuan_version_script_cmd = 
- @HAVE_LD_VERSION_SCRIPT_TRUE@libassuan_version_script_cmd = 
-Wl,--version-script=$(srcdir)/libassuan.vers
--CLEANFILES = mkheader assuan.h
-+CLEANFILES = mkheader$(EXEEXT) assuan.h
- BUILT_SOURCES = assuan.h
- parts_of_assuan_h = \
-   posix-includes.inc.h   w32-includes.inc.h \
-@@ -1183,10 +1183,10 @@
- @HAVE_W32CE_SYSTEM_TRUE@  mv -f $(DESTDIR)$(bindir)/libgpgcedev-0.dll \
- @HAVE_W32CE_SYSTEM_TRUE@  $(DESTDIR)$(bindir)/gpgcedev.dll
- 
--mkheader: mkheader.c Makefile
-+mkheader$(EXEEXT): mkheader.c Makefile
-   $(CC_FOR_BUILD) -I. -I$(srcdir) -o $@ $(srcdir)/mkheader.c
- 
--assuan.h: assuan.h.in mkheader $(parts_of_assuan_h)
-+assuan.h: assuan.h.in mkheader$(EXEEXT) $(parts_of_assuan_h)
-   ./mkheader $(host_os) $(srcdir)/assuan.h.in \
-@VERSION@ @VERSION_NUMBER@ >$@
- 
 --- libassuan.orig/src/mkheader.c  2013-03-15 20:26:09.0 +0100
 +++ libassuan/src/mkheader.c   2017-09-24 14:17:33.584583300 +0200
 @@ -99,7 +99,7 @@
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114038] Range operations setting the values of previously empty cells can not be undone

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114038

--- Comment #1 from Mátyás Jani  ---
Workaround: set the target cells of the range to empty string before applying
the range operation. Do it in an undo context, to have enough undo steps to
undo the whole action in one.

Something like this:

undo = ThisComponent.UndoManager
undo.enterUndoContext("Copy range action")
' clear target range, undo workaround
for row = 4 to 8
for col = 0 to 1
sheet.getCellByPosition(col, row).string = ""
next col
next row
copyRange = sheet.getCellRangeByName("A1:B4")
pasteRange = sheet.getCellRangeByName("A5:B8")
pasteRange.DataArray = copyRange.DataArray
undo.leaveUndoContext

(Note, clearing the target range with range operation will not work.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114038] New: Range operations setting the values of previously empty cells can not be undone

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114038

Bug ID: 114038
   Summary: Range operations setting the values of previously
empty cells can not be undone
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jzo...@gmail.com

Created attachment 137971
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137971=edit
small spreadsheet demonstrating the bug

In LibreOffice Calc BASIC macros setting the values of empty cell ranges can
not be undone. The new values will remain in the previously empty cells after
pressing undo.

Tested functions, undo does not work after these:
targetRange.setDataArray(valueArray)
targetRange.DataArray = sourceRange.DataArray

Steps to reproduce:
1. create a macro that sets the values in a range of empty cells using the
above functions
2. execute the macro
3. press undo

Expected behaviour: the cells content will be erased after undo, restoring
their original state.
Actual behaviour: the cells content does not change, the values set by the
macro remains there.

See the attached .ods file.

Tested on:
Version: 5.4.3.2
Build ID: 5.4.3-2
CPU threads: 6; OS: Linux 4.13; UI render: default; VCL: kde4; 
Locale: hu-HU (hu_HU.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113271] FILEOPEN: XLSX: Incorrect font colour

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113271

--- Comment #3 from Bartosz  ---
Some useful information about colour scheme:
http://officeopenxml.com/SSstyles.php
http://officeopenxml.com/prSlide-color.php

Information about :
https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.fonts(v=office.14).aspx

Information about font:
https://msdn.microsoft.com/en-us/library/ff531892(v=office.12).aspx
https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.font(v=office.14).aspx

According to documentation the "" is "Data Bar
Color".

More information about color class:
https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.color(v=office.14).aspx
https://msdn.microsoft.com/en-us/library/ff532831(v=office.12).aspx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113271] FILEOPEN: XLSX: Incorrect font colour

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113271

--- Comment #2 from Bartosz  ---
The wrong colour information is inside the file:
xl/styles.xml file.

The wrong code which is causing this issue is:










Generally rgb="FF" colour could be for background, but I need to confirm.

The colours with themes are inside file:
xl/theme/theme1.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sw/source

2017-11-24 Thread Caolán McNamara 
 sw/source/filter/ww8/ww8par2.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit e977aad341f167347967046f5a884ba593ff2153
Author: Caolán McNamara 
Date:   Fri Nov 24 15:36:35 2017 +

ofz#4414 set new nWwCols after verifying legal size

otherwise we're returning early with the now wrong
nWwCols

Change-Id: I2031c23ca24241fb4946b5a5a62eabc27c2bdcc2
Reviewed-on: https://gerrit.libreoffice.org/45241
Reviewed-by: Michael Stahl 
Tested-by: Jenkins 

diff --git a/sw/source/filter/ww8/ww8par2.cxx b/sw/source/filter/ww8/ww8par2.cxx
index b65b763b73b1..225f124bbfb7 100644
--- a/sw/source/filter/ww8/ww8par2.cxx
+++ b/sw/source/filter/ww8/ww8par2.cxx
@@ -1244,13 +1244,13 @@ void WW8TabBandDesc::ReadDef(bool bVer67, const 
sal_uInt8* pS, short nLen)
 if (nCols > MAX_COL)
 return;
 
-short nOldCols = nWwCols;
-nWwCols = nCols;
-
 nLen -= 2 * (nCols + 1); //reduce len by claimed amount of next x-borders 
arguments
 if (nLen < 0)
 return;
 
+short nOldCols = nWwCols;
+nWwCols = nCols;
+
 const sal_uInt8* pT = [1];
 for (int i = 0; i <= nCols; i++, pT+=2)
 nCenter[i] = (sal_Int16)SVBT16ToShort( pT );// X-borders
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 113991] Named ranges without sheet reference are exported as corrupted XLSX

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113991

Bartosz  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114032] Base hangs while closing

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114032

Matt  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Matt  ---
Yes, this duplicates the bug I reported.

*** This bug has been marked as a duplicate of bug 107039 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107039] Crash on Close after acknowledging save changes - mutex issue ( steps in comment 21)

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107039

Matt  changed:

   What|Removed |Added

 CC||frnc.salva...@gmail.com

--- Comment #31 from Matt  ---
*** Bug 114032 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113973] linux mouse copy does not work correctly

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113973

--- Comment #7 from Michael Lashkevich  ---
(In reply to Buovjaga from comment #6)

> Are you running LibreOffice version 5.4.1 or greater?
No, libreoffice-5.3.5.2-18.9.4.x86_64.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114023] Insert -> Field -> More Fields, or +, Fields dialog showing incorrect selection listbox contents

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114023

V Stuart Foote  changed:

   What|Removed |Added

 CC||noelgran...@gmail.com

--- Comment #6 from V Stuart Foote  ---
Bibisect from builds on hand, appears between 2017-07-21 and 2017-07-23, looks
like Noel had been cleaning up some of the field crud in that time frame.

https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=a9588baca8137f51e2ca72e40b1f448b0e1885d1..28b382b7b0a32417e0aedd4ae415a69e479fe60b

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 68759] FILESAVE: Looses image flip when saving/loading in pptx format

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=68759

Paul Trojahn  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |paul.troj...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/formula

2017-11-24 Thread Tor Lillqvist 
 include/formula/token.hxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit ceff579722cd606de8ba71444a9d819f4e8a011d
Author: Tor Lillqvist 
Date:   Fri Nov 24 22:36:49 2017 +0200

Mention that the StackVarEnumToString should really be an operator<<

Change-Id: I71288daf10b1010ab0f9dbedd39875cc24f119ae

diff --git a/include/formula/token.hxx b/include/formula/token.hxx
index 3de7c761d658..c3144b4a2dcb 100644
--- a/include/formula/token.hxx
+++ b/include/formula/token.hxx
@@ -84,6 +84,9 @@ enum StackVar : sal_uInt8
 
 // Only to be used for debugging output. No guarantee of stability of the
 // return value.
+
+// Turn this into an operator<< when StackVar becomes a scoped enum
+
 inline std::string StackVarEnumToString(StackVar const e)
 {
 switch (e)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svl/source

2017-11-24 Thread Tor Lillqvist 
 svl/source/misc/sharedstring.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit f2b877fe69bf57f26ec8423627f540f9e58b0c9b
Author: Tor Lillqvist 
Date:   Fri Nov 24 11:14:21 2017 +0200

Clarify comment

Change-Id: I1f0d23cbda3d6729cc858e6bcba4c60fe44bab69

diff --git a/svl/source/misc/sharedstring.cxx b/svl/source/misc/sharedstring.cxx
index 9235783ce774..d3b10af4ddb4 100644
--- a/svl/source/misc/sharedstring.cxx
+++ b/svl/source/misc/sharedstring.cxx
@@ -94,7 +94,8 @@ SharedString& SharedString::operator= ( SharedString&& r )
 
 bool SharedString::operator== ( const SharedString& r ) const
 {
-// Only compare case sensitive strings.
+// Compare only the original (not case-folded) string.
+
 if (mpData == r.mpData)
 return true;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114037] New: Writer documents print only in landscape orientation

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114037

Bug ID: 114037
   Summary: Writer documents print only in landscape orientation
   Product: LibreOffice
   Version: 5.4.3.2 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: david.daved...@gmail.com

Description:
Since ver. 5.3.6, Writer documents will not print in portrait orientation.  Now
running 5.4.3 with same limitation.

Steps to Reproduce:
1.Create Writer document
2.Attempt to print Writer document in portrait mode
3.Resist urge to scream

Actual Results:  
Prints in landscape orientation every time.

Expected Results:
Should print in portrait orientation.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 5.4.3.2
Build ID: 92a7159f7e4af62137622921e809f8546db437e5
CPU threads: 8; OS: Mac OS X 10.9.5; UI render: default; 
Locale: en-US (en.UTF-8); Calc: group


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:57.0)
Gecko/20100101 Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - sw/qa sw/source

2017-11-24 Thread Szymon Kłos 
 sw/qa/extras/ooxmlexport/data/tdf65955.odt   |binary
 sw/qa/extras/ooxmlexport/ooxmlexport7.cxx|   17 +
 sw/source/filter/ww8/docxattributeoutput.cxx |   49 ++-
 sw/source/filter/ww8/docxattributeoutput.hxx |9 +++-
 sw/source/filter/ww8/docxexport.cxx  |   10 -
 5 files changed, 74 insertions(+), 11 deletions(-)

New commits:
commit def2754e91abec0937c44e693ac7d5e12d6c02d2
Author: Szymon Kłos 
Date:   Thu Nov 23 16:56:38 2017 +0100

tdf#65955 DOCX: bookmarks at the end of paragraph

End of line handling was incorrect and all bookmark
tags placed at the end were exported before last text.
I added additional collection to separate final marks
and export them after last piece of text.

Change-Id: Icc8f89164619c85405a846fda9871430c91dcbe1
Reviewed-on: https://gerrit.libreoffice.org/45168
Tested-by: Jenkins 
Reviewed-by: Szymon Kłos 
Reviewed-on: https://gerrit.libreoffice.org/45245
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf65955.odt 
b/sw/qa/extras/ooxmlexport/data/tdf65955.odt
new file mode 100755
index ..e133938e0383
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf65955.odt differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport7.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport7.cxx
index 51e3089d9647..de69453e71c2 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport7.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport7.cxx
@@ -1815,6 +1815,23 @@ DECLARE_OOXMLEXPORT_TEST( testObjectCrossReference, 
"object_cross_reference.odt"
 }
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf65955, "tdf65955.odt")
+{
+uno::Reference xBookmarksSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xBookmarksByIdx(xBookmarksSupplier->getBookmarks(), uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(xBookmarksByIdx->getCount(), 
static_cast(2));
+uno::Reference 
xBookmarksByName(xBookmarksSupplier->getBookmarks(), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xBookmarksByName->hasByName("a"));
+CPPUNIT_ASSERT(xBookmarksByName->hasByName("b"));
+// a
+uno::Reference 
xContent3(xBookmarksByName->getByName("a"), uno::UNO_QUERY);
+uno::Reference xRange3(xContent3->getAnchor(), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(xRange3->getString(), OUString());
+// b
+uno::Reference 
xContent2(xBookmarksByName->getByName("b"), uno::UNO_QUERY);
+uno::Reference xRange2(xContent2->getAnchor(), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(OUString("r"), xRange2->getString());
+}
 
 CPPUNIT_PLUGIN_IMPLEMENT();
 
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 96c593983795..f05afd2652ab 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -1230,8 +1230,8 @@ void DocxAttributeOutput::EndRun(const SwTextNode* pNode, 
sal_Int32 nPos, bool /
 // XML_r node should be surrounded with bookmark-begin and bookmark-end 
nodes if it has bookmarks.
 // The same is applied for permission ranges.
 // But due to unit test "testFdo85542" let's output bookmark-begin with 
bookmark-end.
-DoWriteBookmarksStart();
-DoWriteBookmarksEnd();
+DoWriteBookmarksStart(m_rBookmarksStart);
+DoWriteBookmarksEnd(m_rBookmarksEnd);
 DoWritePermissionsStart();
 DoWriteAnnotationMarks();
 
@@ -1370,6 +1370,8 @@ void DocxAttributeOutput::EndRun(const SwTextNode* pNode, 
sal_Int32 nPos, bool /
 m_nFieldsInHyperlink = 0;
 }
 
+DoWriteBookmarksStart(m_rFinalBookmarksStart);
+DoWriteBookmarksEnd(m_rFinalBookmarksEnd);
 DoWriteBookmarkEndIfExist(nPos);
 }
 
@@ -1427,9 +1429,9 @@ void 
DocxAttributeOutput::DoWriteBookmarkEndIfExist(sal_Int32 nRunPos)
 }
 
 /// Write the start bookmarks
-void DocxAttributeOutput::DoWriteBookmarksStart()
+void DocxAttributeOutput::DoWriteBookmarksStart(std::vector& rStarts)
 {
-for (const OUString & bookmarkName : m_rBookmarksStart)
+for (const OUString & bookmarkName : rStarts)
 {
 // Output the bookmark
 DoWriteBookmarkTagStart(bookmarkName);
@@ -1438,13 +1440,13 @@ void DocxAttributeOutput::DoWriteBookmarksStart()
 m_sLastOpenedBookmark = 
OUStringToOString(BookmarkToWord(bookmarkName), RTL_TEXTENCODING_UTF8).getStr();
 m_nNextBookmarkId++;
 }
-m_rBookmarksStart.clear();
+rStarts.clear();
 }
 
 /// export the end bookmarks
-void DocxAttributeOutput::DoWriteBookmarksEnd()
+void DocxAttributeOutput::DoWriteBookmarksEnd(std::vector& rEnds)
 {
-for (const OUString & bookmarkName : m_rBookmarksEnd)
+for (const OUString & bookmarkName : rEnds)
 {
 // Get the id of the bookmark
 auto pPos = m_rOpenedBookmarksIds.find(bookmarkName);
@@ -1456,7 +1458,7 @@ void

[Libreoffice-bugs] [Bug 114023] Insert -> Field -> More Fields, or +, Fields dialog showing incorrect selection listbox contents

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114023

Julien Nabet  changed:

   What|Removed |Added

   Priority|medium  |high
 OS|Windows (All)   |All
   Severity|normal  |major

--- Comment #5 from Julien Nabet  ---
Let's increase the importance since it's a regression + concerns all env.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basic/source

2017-11-24 Thread Eike Rathke 
 basic/source/sbx/sbxscan.cxx |   40 ++--
 1 file changed, 26 insertions(+), 14 deletions(-)

New commits:
commit 5e1d49db805b82fb0e75e34e21f2e935c04f58a7
Author: Eike Rathke 
Date:   Fri Nov 24 15:21:42 2017 +0100

Get rid of a temporary SvNumberFormatter instance

For each Format call..

Change-Id: I2f9d875ca27d5a10e609df1c0168be2dad65eaab
Reviewed-on: https://gerrit.libreoffice.org/45230
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/basic/source/sbx/sbxscan.cxx b/basic/source/sbx/sbxscan.cxx
index 2693ef22199b..3408c0e9f151 100644
--- a/basic/source/sbx/sbxscan.cxx
+++ b/basic/source/sbx/sbxscan.cxx
@@ -36,6 +36,7 @@
 
 #include "sbxres.hxx"
 #include 
+#include 
 #include 
 #include 
 
@@ -679,13 +680,24 @@ void SbxValue::Format( OUString& rRes, const OUString* 
pFmt ) const
 }
 
 LanguageType eLangType = 
Application::GetSettings().GetLanguageTag().getLanguageType();
-SvNumberFormatter aFormatter( 
comphelper::getProcessComponentContext(), eLangType );
+std::shared_ptr pFormatter;
+if (GetSbData()->pInst)
+{
+pFormatter = GetSbData()->pInst->GetNumberFormatter();
+}
+else
+{
+sal_uInt32 n;   // Dummy
+pFormatter = SbiInstance::PrepareNumberFormatter( n, n, n );
+}
 
-sal_uInt32 nIndex = 0;
+// Passing an index of a locale switches IsNumberFormat() to use that
+// locale in case the formatter wasn't default created with it.
+sal_uInt32 nIndex = pFormatter->GetStandardIndex( eLangType);
 double nNumber;
 Color* pCol;
 
-bool bSuccess = aFormatter.IsNumberFormat( aStr, nIndex, nNumber );
+bool bSuccess = pFormatter->IsNumberFormat( aStr, nIndex, nNumber );
 
 // number format, use SvNumberFormatter to handle it.
 if( bSuccess )
@@ -698,14 +710,14 @@ void SbxValue::Format( OUString& rRes, const OUString* 
pFmt ) const
 {
 if( pInfo->meType == VbaFormatType::Offset )
 {
-nIndex = aFormatter.GetFormatIndex( pInfo->meOffset, 
eLangType );
+nIndex = pFormatter->GetFormatIndex( pInfo->meOffset, 
eLangType );
 }
 else
 {
 aFmtStr = OUString::createFromAscii(pInfo->mpOOoFormat);
-aFormatter.PutandConvertEntry( aFmtStr, nCheckPos, nType, 
nIndex, LANGUAGE_ENGLISH, eLangType );
+pFormatter->PutandConvertEntry( aFmtStr, nCheckPos, nType, 
nIndex, LANGUAGE_ENGLISH, eLangType );
 }
-aFormatter.GetOutputString( nNumber, nIndex, rRes,  );
+pFormatter->GetOutputString( nNumber, nIndex, rRes,  );
 }
 else if( aFmtStr.equalsIgnoreAsciiCase( VBAFORMAT_GENERALDATE )
 || aFmtStr.equalsIgnoreAsciiCase( VBAFORMAT_C ))
@@ -713,16 +725,16 @@ void SbxValue::Format( OUString& rRes, const OUString* 
pFmt ) const
 if( nNumber <=-1.0 || nNumber >= 1.0 )
 {
 // short date
-nIndex = aFormatter.GetFormatIndex( NF_DATE_SYSTEM_SHORT, 
eLangType );
-aFormatter.GetOutputString( nNumber, nIndex, rRes,  );
+nIndex = pFormatter->GetFormatIndex( NF_DATE_SYSTEM_SHORT, 
eLangType );
+pFormatter->GetOutputString( nNumber, nIndex, rRes,  
);
 
 // long time
 if( floor( nNumber ) != nNumber )
 {
 aFmtStr = "H:MM:SS AM/PM";
-aFormatter.PutandConvertEntry( aFmtStr, nCheckPos, 
nType, nIndex, LANGUAGE_ENGLISH, eLangType );
+pFormatter->PutandConvertEntry( aFmtStr, nCheckPos, 
nType, nIndex, LANGUAGE_ENGLISH, eLangType );
 OUString aTime;
-aFormatter.GetOutputString( nNumber, nIndex, aTime, 
 );
+pFormatter->GetOutputString( nNumber, nIndex, aTime, 
 );
 rRes += " " + aTime;
 }
 }
@@ -730,8 +742,8 @@ void SbxValue::Format( OUString& rRes, const OUString* pFmt 
) const
 {
 // long time only
 aFmtStr = "H:MM:SS AM/PM";
-aFormatter.PutandConvertEntry( aFmtStr, nCheckPos, nType, 
nIndex, LANGUAGE_ENGLISH, eLangType );
-aFormatter.GetOutputString( nNumber, nIndex, rRes,  );
+pFormatter->PutandConvertEntry( aFmtStr, nCheckPos, nType, 
nIndex, LANGUAGE_ENGLISH, eLangType );
+pFormatter->GetOutputString( nNumber, nIndex, rRes,  
);
 }
 }
 else if( aFmtStr.equalsIgnoreAsciiCase( VBAFORMAT_N )

[Libreoffice-commits] core.git: basic/source

2017-11-24 Thread Eike Rathke 
 basic/source/sbx/sbxdate.cxx |   25 ++---
 1 file changed, 22 insertions(+), 3 deletions(-)

New commits:
commit bb4cd5271e38ac69b1a9a8738bfdd7e13189f1f4
Author: Eike Rathke 
Date:   Fri Nov 24 16:09:35 2017 +0100

Get rid of two more temporary SvNumberFormatter instances

Change-Id: Id2afd9dd9d791383a1374b5abe52b47b43a19f08
Reviewed-on: https://gerrit.libreoffice.org/45236
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/basic/source/sbx/sbxdate.cxx b/basic/source/sbx/sbxdate.cxx
index 4a9749a28b74..e59c9214a90b 100644
--- a/basic/source/sbx/sbxdate.cxx
+++ b/basic/source/sbx/sbxdate.cxx
@@ -26,6 +26,8 @@
 #include 
 #include 
 #include "sbxconv.hxx"
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -101,8 +103,16 @@ double ImpGetDate( const SbxValues* p )
 else
 {
 LanguageType eLangType = 
Application::GetSettings().GetLanguageTag().getLanguageType();
-
-std::unique_ptr pFormatter(new 
SvNumberFormatter( comphelper::getProcessComponentContext(), eLangType ));
+std::shared_ptr pFormatter;
+if (GetSbData()->pInst)
+{
+pFormatter = GetSbData()->pInst->GetNumberFormatter();
+}
+else
+{
+sal_uInt32 nDummy;
+pFormatter = SbiInstance::PrepareNumberFormatter( nDummy, 
nDummy, nDummy );
+}
 
 sal_uInt32 nIndex;
 sal_Int32 nCheckPos = 0;
@@ -269,7 +279,16 @@ start:
 Color* pColor;
 
 LanguageType eLangType = 
Application::GetSettings().GetLanguageTag().getLanguageType();
-std::unique_ptr pFormatter(new 
SvNumberFormatter( comphelper::getProcessComponentContext(), eLangType ));
+std::shared_ptr pFormatter;
+if (GetSbData()->pInst)
+{
+pFormatter = GetSbData()->pInst->GetNumberFormatter();
+}
+else
+{
+sal_uInt32 nDummy;
+pFormatter = SbiInstance::PrepareNumberFormatter( nDummy, 
nDummy, nDummy );
+}
 
 sal_uInt32 nIndex;
 sal_Int32 nCheckPos = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: basic/source

2017-11-24 Thread Eike Rathke 
 basic/source/sbx/sbxdate.cxx |   18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

New commits:
commit f1b5b22a5f6516e1159462c153dd7e28812e91c1
Author: Eike Rathke 
Date:   Fri Nov 24 15:56:59 2017 +0100

Get rid of that LANGUAGE_GERMAN nonsense

Change-Id: I1ca3125e893a54ac00a3d785d77ed5612fb01857
Reviewed-on: https://gerrit.libreoffice.org/45235
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/basic/source/sbx/sbxdate.cxx b/basic/source/sbx/sbxdate.cxx
index 342677d0fc0c..4a9749a28b74 100644
--- a/basic/source/sbx/sbxdate.cxx
+++ b/basic/source/sbx/sbxdate.cxx
@@ -286,20 +286,20 @@ start:
 {
 switch( eDate )
 {
-case DateOrder::MDY: aStr = "MM.TT."; break;
-case DateOrder::DMY: aStr = "TT.MM."; break;
-case DateOrder::YMD: aStr = ".MM.TT"; break;
-default:   aStr = "MM.TT.";
+default:
+case DateOrder::MDY: aStr = "MM/DD/"; break;
+case DateOrder::DMY: aStr = "DD/MM/"; break;
+case DateOrder::YMD: aStr = "/MM/DD"; break;
 }
 }
 else
 {
 switch( eDate )
 {
-case DateOrder::MDY: aStr = "MM.TT. HH:MM:SS"; break;
-case DateOrder::DMY: aStr = "TT.MM. HH:MM:SS"; break;
-case DateOrder::YMD: aStr = ".MM.TT HH:MM:SS"; break;
-default:  aStr = "MM.TT. HH:MM:SS";
+default:
+case DateOrder::MDY: aStr = "MM/DD/ HH:MM:SS"; 
break;
+case DateOrder::DMY: aStr = "DD/MM/ HH:MM:SS"; 
break;
+case DateOrder::YMD: aStr = "/MM/DD HH:MM:SS"; 
break;
 }
 }
 }
@@ -311,7 +311,7 @@ start:
 nCheckPos,
 nType,
 nIndex,
-LANGUAGE_GERMAN,
+LANGUAGE_ENGLISH_US,
 eLangType );
 pFormatter->GetOutputString( n, nIndex, *p->pOUString,  );
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: basic/source

2017-11-24 Thread Eike Rathke 
 basic/source/runtime/methods.cxx |   18 --
 1 file changed, 8 insertions(+), 10 deletions(-)

New commits:
commit 2f8174594da56e6feb0c339993f673afdd859794
Author: Eike Rathke 
Date:   Fri Nov 24 16:25:41 2017 +0100

Aaand another one.. SvNumberFormatter instance

... just to parse with LANGUAGE_ENGLISH_US if system locale failed..

Change-Id: Id9b7cfb5b5f21c46789f30e8e8c72a7524491e95
Reviewed-on: https://gerrit.libreoffice.org/45238
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/basic/source/runtime/methods.cxx b/basic/source/runtime/methods.cxx
index 6b47d8b2a78f..e91893d76d50 100644
--- a/basic/source/runtime/methods.cxx
+++ b/basic/source/runtime/methods.cxx
@@ -2043,24 +2043,22 @@ void SbRtl_DateValue(StarBASIC *, SbxArray & rPar, bool)
 pFormatter = SbiInstance::PrepareNumberFormatter( n, n, n );
 }
 
-sal_uInt32 nIndex = 0;
+LanguageType eLangType = 
Application::GetSettings().GetLanguageTag().getLanguageType();
+sal_uInt32 nIndex = pFormatter->GetStandardIndex( eLangType);
 double fResult;
 OUString aStr( rPar.Get(1)->GetOUString() );
 bool bSuccess = pFormatter->IsNumberFormat( aStr, nIndex, fResult );
 short nType = pFormatter->GetType( nIndex );
 
 // DateValue("February 12, 1969") raises error if the system locale is 
not en_US
-// by using SbiInstance::GetNumberFormatter.
-// It seems that both locale number formatter and English number 
formatter
-// are supported in Visual Basic.
-LanguageType eLangType = 
Application::GetSettings().GetLanguageTag().getLanguageType();
+// It seems that both locale number formatter and English number
+// formatter are supported in Visual Basic.
 if( !bSuccess && ( eLangType != LANGUAGE_ENGLISH_US ) )
 {
-// Create a new SvNumberFormatter by using LANGUAGE_ENGLISH to get 
the date value;
-SvNumberFormatter aFormatter( 
comphelper::getProcessComponentContext(), LANGUAGE_ENGLISH_US );
-nIndex = 0;
-bSuccess = aFormatter.IsNumberFormat( aStr, nIndex, fResult );
-nType = aFormatter.GetType( nIndex );
+// Try using LANGUAGE_ENGLISH_US to get the date value.
+nIndex = pFormatter->GetStandardIndex( LANGUAGE_ENGLISH_US);
+bSuccess = pFormatter->IsNumberFormat( aStr, nIndex, fResult );
+nType = pFormatter->GetType( nIndex );
 }
 
 if(bSuccess && (nType==css::util::NumberFormat::DATE || 
nType==css::util::NumberFormat::DATETIME))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 112603] FILEOPEN: EMF - Image has no bold border

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=112603

Bartosz  changed:

   What|Removed |Added

Summary|FILEOPEN: EMF+ - Image has  |FILEOPEN: EMF - Image has
   |no bold border  |no bold border

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114023] Insert -> Field -> More Fields, or +, Fields dialog showing incorrect selection listbox contents

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114023

Julien Nabet  changed:

   What|Removed |Added

 CC||caol...@redhat.com,
   ||serval2...@yahoo.fr

--- Comment #4 from Julien Nabet  ---
Caolán: thought you might be interested in this one. I'm not sure but wonder if
it could be related to boost::gettext part. Of course, I'm not sure, it's more
a guess.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basic/source

2017-11-24 Thread Eike Rathke 
 basic/source/comp/scanner.cxx |   18 ++
 1 file changed, 14 insertions(+), 4 deletions(-)

New commits:
commit 28288295aeddf2fe2100af4f60f453a05fe25508
Author: Eike Rathke 
Date:   Fri Nov 24 15:45:08 2017 +0100

Get rid of a temporary SvNumberFormatter instance

... in case we have a runtime instance already. Only used for
scanning date literals in source so not frequently used, otherwise
we could remember a non-runtime instance formatter somewhere.

Change-Id: I1146860c4b0aa4091708c22e498a6f720d6c7a13
Reviewed-on: https://gerrit.libreoffice.org/45232
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/basic/source/comp/scanner.cxx b/basic/source/comp/scanner.cxx
index 07d739f29bc0..67177b7d9f44 100644
--- a/basic/source/comp/scanner.cxx
+++ b/basic/source/comp/scanner.cxx
@@ -20,6 +20,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -560,12 +561,21 @@ bool SbiScanner::NextSym()
 aSym = aLine.copy( n, nCol - n - 1 );
 
 // parse date literal
-SvNumberFormatter 
aFormatter(comphelper::getProcessComponentContext(), LANGUAGE_ENGLISH_US);
-sal_uInt32 nIndex = 0;
-bool bSuccess = aFormatter.IsNumberFormat(aSym, nIndex, nVal);
+std::shared_ptr pFormatter;
+if (GetSbData()->pInst)
+{
+pFormatter = GetSbData()->pInst->GetNumberFormatter();
+}
+else
+{
+sal_uInt32 nDummy;
+pFormatter = SbiInstance::PrepareNumberFormatter( nDummy, 
nDummy, nDummy );
+}
+sal_uInt32 nIndex = pFormatter->GetStandardIndex( 
LANGUAGE_ENGLISH_US);
+bool bSuccess = pFormatter->IsNumberFormat(aSym, nIndex, nVal);
 if( bSuccess )
 {
-short nType_ = aFormatter.GetType(nIndex);
+short nType_ = pFormatter->GetType(nIndex);
 if( !(nType_ & css::util::NumberFormat::DATE) )
 bSuccess = false;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: basic/source

2017-11-24 Thread Eike Rathke 
 basic/source/inc/runtime.hxx  |6 +++---
 basic/source/runtime/methods.cxx  |   34 +-
 basic/source/runtime/methods1.cxx |7 +--
 basic/source/runtime/runtime.cxx  |   24 
 4 files changed, 21 insertions(+), 50 deletions(-)

New commits:
commit 4b98e352e543d0462f2727c5762552e32ef4d76a
Author: Eike Rathke 
Date:   Fri Nov 24 14:24:03 2017 +0100

Make the SbiInstance SvNumberFormatter shared_ptr

In preparation to get rid of the per call locally created
SvNumberFormatter instances..

Change-Id: Ic7db3bbb655aa18e939f5722964655a20f2eadf2
Reviewed-on: https://gerrit.libreoffice.org/45227
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/basic/source/inc/runtime.hxx b/basic/source/inc/runtime.hxx
index dc92fb87f3d9..86baec31ac53 100644
--- a/basic/source/inc/runtime.hxx
+++ b/basic/source/inc/runtime.hxx
@@ -133,7 +133,7 @@ class SbiInstance
 std::unique_ptrpDdeCtrl;
 // DLL-Calls (DECLARE)
 std::unique_ptrpDllMgr;
-std::unique_ptr pNumberFormatter;
+std::shared_ptr pNumberFormatter;
 StarBASIC*  pBasic;
 LanguageTypemeFormatterLangType;
 DateOrder   meFormatterDateOrder;
@@ -186,13 +186,13 @@ public:
 SbiDllMgr* GetDllMgr();
 SbiRTLData* GetRTLData() const { return 
const_cast(); }
 
-SvNumberFormatter* GetNumberFormatter();
+std::shared_ptr GetNumberFormatter();
 sal_uInt32 GetStdDateIdx() const { return nStdDateIdx; }
 sal_uInt32 GetStdTimeIdx() const { return nStdTimeIdx; }
 sal_uInt32 GetStdDateTimeIdx() const { return nStdDateTimeIdx; }
 
 // offer NumberFormatter also static
-static SvNumberFormatter* PrepareNumberFormatter( sal_uInt32 ,
+static std::shared_ptr PrepareNumberFormatter( 
sal_uInt32 ,
 sal_uInt32 , sal_uInt32 ,
 LanguageType const * peFormatterLangType=nullptr, DateOrder const * 
peFormatterDateOrder=nullptr );
 };
diff --git a/basic/source/runtime/methods.cxx b/basic/source/runtime/methods.cxx
index 6cbde3a5dcaa..6b47d8b2a78f 100644
--- a/basic/source/runtime/methods.cxx
+++ b/basic/source/runtime/methods.cxx
@@ -2032,7 +2032,7 @@ void SbRtl_DateValue(StarBASIC *, SbxArray & rPar, bool)
 else
 {
 // #39629 check GetSbData()->pInst, can be called from the URL line
-SvNumberFormatter* pFormatter = nullptr;
+std::shared_ptr pFormatter;
 if( GetSbData()->pInst )
 {
 pFormatter = GetSbData()->pInst->GetNumberFormatter();
@@ -2083,11 +2083,6 @@ void SbRtl_DateValue(StarBASIC *, SbxArray & rPar, bool)
 {
 StarBASIC::Error( ERRCODE_BASIC_CONVERSION );
 }
-// #39629 pFormatter can be requested itself
-if( !GetSbData()->pInst )
-{
-delete pFormatter;
-}
 }
 }
 
@@ -2099,7 +2094,7 @@ void SbRtl_TimeValue(StarBASIC *, SbxArray & rPar, bool)
 }
 else
 {
-SvNumberFormatter* pFormatter = nullptr;
+std::shared_ptr pFormatter;
 if( GetSbData()->pInst )
 pFormatter = GetSbData()->pInst->GetNumberFormatter();
 else
@@ -2126,10 +2121,6 @@ void SbRtl_TimeValue(StarBASIC *, SbxArray & rPar, bool)
 {
 StarBASIC::Error( ERRCODE_BASIC_CONVERSION );
 }
-if( !GetSbData()->pInst )
-{
-delete pFormatter;
-}
 }
 }
 
@@ -2288,7 +2279,7 @@ void SbRtl_Time(StarBASIC *, SbxArray & rPar, bool bWrite)
 double nDays = (double)nSeconds * ( 1.0 / (24.0*3600.0) );
 Color* pCol;
 
-SvNumberFormatter* pFormatter = nullptr;
+std::shared_ptr pFormatter;
 sal_uInt32 nIndex;
 if( GetSbData()->pInst )
 {
@@ -2302,11 +2293,6 @@ void SbRtl_Time(StarBASIC *, SbxArray & rPar, bool 
bWrite)
 }
 
 pFormatter->GetOutputString( nDays, nIndex, aRes,  );
-
-if( !GetSbData()->pInst )
-{
-delete pFormatter;
-}
 }
 pMeth->PutString( aRes );
 }
@@ -2339,7 +2325,7 @@ void SbRtl_Date(StarBASIC *, SbxArray & rPar, bool bWrite)
 OUString aRes;
 Color* pCol;
 
-SvNumberFormatter* pFormatter = nullptr;
+std::shared_ptr pFormatter;
 sal_uInt32 nIndex;
 if( GetSbData()->pInst )
 {
@@ -2354,11 +2340,6 @@ void SbRtl_Date(StarBASIC *, SbxArray & rPar, bool 
bWrite)
 
 pFormatter->GetOutputString( nDays, nIndex, aRes,  );
 pMeth->PutString( aRes );
-
-if( !GetSbData()->pInst )
-{
-delete pFormatter;
-}
 }
 else
 {
@@ -3097,7 +3078,7 @@ void SbRtl_FileDateTime(StarBASIC *, SbxArray & rPar, 
bool)
 
 Color* pCol;
 
-SvNumberFormatter*

[Libreoffice-bugs] [Bug 94655] Apple Color Emoji not Visible in Exported PDF

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=94655

--- Comment #21 from Khaled Hosny  ---
Apple Color Emoji uses “sbix” table to store colored emoji bitmaps (i.e. it is
embedding PNGs inside the font).

Our font subsetting code that we use for embedding fonts inside PDFs is decades
old and does not support this table (which is relatively new) and most likely
just discards it, so the embedded font will either show no emoji glyphs at all
or fallback black and white glyphs (if the font has any).

Even if our subsetter supported this table, there be still an issue in showing
these PDFs in environments that do not support this table (old versions of
macOS, other platforms, etc.), so we might need to even extract the PNGs and
embed them directly on the PDF stream, which is even more complex task.

The subsetter is at vcl/source/fontsubset/, the PDF generation code is in
vcl/source/gdi/pdfwriter*.

I hope this gives some pointers if anyone wants to work in this,

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa sc/source

2017-11-24 Thread Winfried Donkers 
 sc/qa/unit/data/functions/text/fods/left.fods |   88 +-
 sc/source/core/tool/interpr1.cxx  |7 +-
 2 files changed, 92 insertions(+), 3 deletions(-)

New commits:
commit 4e3530b4f870e0470c23ae89cdb8b9a09af54d59
Author: Winfried Donkers 
Date:   Mon Nov 13 15:43:00 2017 +0100

tdf#97198 Make Calc function LEFT work with Unicode non-BMP characters

Change-Id: I66d24dd962f824079fd0aea2827bd5b975ffe698
Reviewed-on: https://gerrit.libreoffice.org/44684
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/sc/qa/unit/data/functions/text/fods/left.fods 
b/sc/qa/unit/data/functions/text/fods/left.fods
index 535eff455432..45d659aab04e 100644
--- a/sc/qa/unit/data/functions/text/fods/left.fods
+++ b/sc/qa/unit/data/functions/text/fods/left.fods
@@ -1152,6 +1152,92 @@
  
  
 
+
+ 
+  ab😂d
+ 
+ 
+  ab😂d
+ 
+ 
+  WAAR
+ 
+ 
+  =LEFT(I11;4)
+ 
+ 
+  Excel 2016 returns the same result
+ 
+ 
+ ab😂de𝔖gh𝕬𝖈𝖍𝖙𝖚𝖓𝖌!
+ 
+ 
+
+
+ 
+  𧌒
+ 
+ 
+  𧌒
+ 
+ 
+  WAAR
+ 
+ 
+  =LEFT(I12;2)
+ 
+ 
+  Excel 2016 returns the same result
+ 
+ 
+ 𧌒𧀬
+ 
+ 
+
+
+ 
+  u
+ 
+ 
+  u
+ 
+ 
+  WAAR
+ 
+ 
+  =LEFT(I13;2)
+ 
+ 
+  Excel 2016 returns the same result
+ 
+ 
+ 
+  üë
+ 
+ 
+
+
+ 
+  𝕬𝖈𝖍𝖙
+ 
+ 
+  𝕬𝖈𝖍𝖙
+ 
+ 
+  WAAR
+ 
+ 
+  =LEFT(I14;4)
+ 
+ 
+  Excel 2016 returns the same result
+ 
+ 
+ 
+  𝕬𝖈𝖍𝖙𝖚𝖓𝖌!
+ 
+ 
+
 
  
  
@@ -1195,4 +1281,4 @@

   
  
-
\ No newline at end of file
+
diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index 88b1fd43759d..2895c93f2a2e 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -8579,8 +8579,11 @@ void ScInterpreter::ScLeft()
 else
 n = 1;
 OUString aStr = GetString().getString();
-n = std::min(n, aStr.getLength());
-aStr = aStr.copy( 0, n );
+sal_Int32 nIdx = 0;
+sal_Int32 nCnt = 0;
+while ( nIdx < aStr.getLength() && n > nCnt++ )
+aStr.iterateCodePoints(  );
+aStr = aStr.copy( 0, nIdx );
 PushString( aStr );
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa sc/source

2017-11-24 Thread Winfried Donkers 
 sc/qa/unit/data/functions/text/fods/search.fods |  160 +---
 sc/source/core/tool/interpr1.cxx|   11 +
 2 files changed, 156 insertions(+), 15 deletions(-)

New commits:
commit 78b7e5f76e72647e0cab662ad2c9342d4538704f
Author: Winfried Donkers 
Date:   Thu Nov 23 18:21:19 2017 +0100

tdf#97198 Make Calc function SEARCH work with UniCode non-BMP characters.

Change-Id: I99b44dc88fe9c8d4d5d7a319bd6bc84dd2bff4f3
Reviewed-on: https://gerrit.libreoffice.org/45170
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/qa/unit/data/functions/text/fods/search.fods 
b/sc/qa/unit/data/functions/text/fods/search.fods
index 12723d0e1154..c09827350d89 100644
--- a/sc/qa/unit/data/functions/text/fods/search.fods
+++ b/sc/qa/unit/data/functions/text/fods/search.fods
@@ -1416,21 +1416,153 @@
  
  
 
-
- 
- 
- 
- 
- 
+
+ 
+  2
+ 
+ 
+  2
+ 
+ 
+  TRUE
+ 
+ 
+  =SEARCH(I21;J21)
+ 
+ 
+  Excel 2016 has same result
+ 
+ 
+ 
+  B😂
+ 
+ 
+  ab😂de𝔖gh𝕬𝖈𝖍𝖙𝖚𝖓𝖌!
+ 
+ 
 
-
- 
- 
- 
- 
- 
+
+ 
+  3
+ 
+ 
+  3
+ 
+ 
+  TRUE
+ 
+ 
+  =SEARCH(I22;J21)
+ 
+ 
+  Excel 2016 has same result
+ 
+ 
+ 
+  😂d
+ 
+ 
+  ab😂
+ 
+ 
+
+
+ 
+  3
+ 
+ 
+  3
+ 
+ 
+  TRUE
+ 
+ 
+  =SEARCH(I23;J23)
+ 
+ 
+  Excel 2016 returns 4
+ 
+ 
+ 
+  𧀬
+ 
+ 𧌒𧀬
+ 
+ 
+
+
+ 
+  8
+ 
+ 
+  8
+ 
+ 
+  TRUE
+ 
+ 
+  =SEARCH(I24;J21)
+ 
+ 
+  Excel 2016 returns 10
+ 
+ 
+ 
+  h
+ 
+ 
+
+
+ 
+  4
+ 
+ 
+  4
+ 
+ 
+  TRUE
+ 
+ 
+  =SEARCH(I25;J25)
+ 
+ 
+  Excel 2016 has same result
+ 
+ 
+ 
+  e
+ 
+ 
+  üë
+ 
+ 
+
+
+ 
+  3
+ 
+ 
+  3
+ 
+ 
+  TRUE
+ 
+ 
+  =SEARCH(I26;J26)
+ 
+ 
+  Excel 2016 returns 5
+ 
+ 
+ 
+  𝖍𝖙
+ 
+ 
+  𝕬𝖈𝖍𝖙𝖚𝖓𝖌!
+ 
+ 
 
-
+
  
  
  
@@ -1483,4 +1615,4 @@

   
  
-
\ No newline at end of file
+
diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index 96d8f764a418..88b1fd43759d 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -8942,7 +8942,16 @@ void ScInterpreter::ScSearch()
 if (!bBool)
 PushNoValue();
 else
-PushDouble((double)nPos + 1);
+{
+sal_Int32 nIdx = 0;
+sal_Int32 nCnt = 0;
+while ( nIdx <= nPos )
+{
+sStr.iterateCodePoints(  );
+++nCnt;
+}
+PushDouble( ( double )nCnt );
+}
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: source/sl

2017-11-24 Thread Andras Timar 
 source/sl/cui/messages.po |  244 ++-
 source/sl/fpicker/messages.po |   52 
 source/sl/helpcontent2/source/text/shared/00.po   |   18 
 source/sl/helpcontent2/source/text/shared/01.po   |  126 +
 source/sl/helpcontent2/source/text/shared/02.po   |   14 
 source/sl/helpcontent2/source/text/shared/autopi.po   |   72 -
 source/sl/helpcontent2/source/text/shared/optionen.po |   16 
 source/sl/helpcontent2/source/text/swriter/01.po  |   30 
 source/sl/helpcontent2/source/text/swriter/02.po  |   22 
 source/sl/officecfg/registry/data/org/openoffice/Office.po|4 
 source/sl/officecfg/registry/data/org/openoffice/Office/UI.po |   24 
 source/sl/sc/messages.po  |4 
 source/sl/sccomp/messages.po  |4 
 source/sl/sd/messages.po  |  651 +-
 source/sl/svx/messages.po |   39 
 source/sl/sw/messages.po  |4 
 source/sl/vcl/messages.po |   92 -
 17 files changed, 825 insertions(+), 591 deletions(-)

New commits:
commit 5765656ed4e4fdcc576c853e85f6623eac128ae8
Author: Andras Timar 
Date:   Fri Nov 24 21:13:03 2017 +0100

Updated Slovenian translation

Change-Id: I72643fddd62800d45b150df26befeee43898e4a4

diff --git a/source/sl/cui/messages.po b/source/sl/cui/messages.po
index facff263f65..6c0c5dd100c 100644
--- a/source/sl/cui/messages.po
+++ b/source/sl/cui/messages.po
@@ -3,8 +3,8 @@ msgid ""
 msgstr ""
 "Project-Id-Version: LibreOffice 6.0\n"
 "Report-Msgid-Bugs-To: 
https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI\n;
-"POT-Creation-Date: 2017-11-20 20:14+0100\n"
-"PO-Revision-Date: 2017-11-20 23:40+0200\n"
+"POT-Creation-Date: 2017-11-24 12:50+0100\n"
+"PO-Revision-Date: 2017-11-24 14:51+0200\n"
 "Last-Translator: Martin Srebotnjak \n"
 "Language-Team: sl.libreoffice.org\n"
 "Language: sl\n"
@@ -2635,67 +2635,67 @@ msgctxt "backgroundpage|forft"
 msgid "F_or:"
 msgstr "Z_a:"
 
-#: backgroundpage.ui:89
+#: backgroundpage.ui:91
 msgctxt "backgroundpage|tablelb"
 msgid "Cell"
 msgstr "Celica"
 
-#: backgroundpage.ui:90
+#: backgroundpage.ui:92
 msgctxt "backgroundpage|tablelb"
 msgid "Row"
 msgstr "Vrstica"
 
-#: backgroundpage.ui:91
+#: backgroundpage.ui:93
 msgctxt "backgroundpage|tablelb"
 msgid "Table"
 msgstr "Tabela"
 
-#: backgroundpage.ui:212
+#: backgroundpage.ui:214
 msgctxt "backgroundpage|background_label"
 msgid "Background Color"
 msgstr "Barva ozadja"
 
-#: backgroundpage.ui:275
+#: backgroundpage.ui:276
 msgctxt "backgroundpage|unlinkedft"
 msgid "Unlinked image"
 msgstr "Nepovezana slika"
 
-#: backgroundpage.ui:287
+#: backgroundpage.ui:288
 msgctxt "backgroundpage|findgraphicsft"
 msgid "Find images"
 msgstr "Najdi slike"
 
-#: backgroundpage.ui:302
+#: backgroundpage.ui:304
 msgctxt "backgroundpage|browse"
 msgid "_Browse..."
 msgstr "Pre_brskaj ..."
 
-#: backgroundpage.ui:315
+#: backgroundpage.ui:317
 msgctxt "backgroundpage|link"
 msgid "_Link"
 msgstr "_Povezava"
 
-#: backgroundpage.ui:343
+#: backgroundpage.ui:345
 msgctxt "backgroundpage|label2"
 msgid "File"
 msgstr "Datoteka"
 
-#: backgroundpage.ui:401
+#: backgroundpage.ui:403
 msgctxt "backgroundpage|positionrb"
 msgid "_Position"
 msgstr "_Položaj"
 
-#: backgroundpage.ui:421
+#: backgroundpage.ui:423
 msgctxt "backgroundpage|arearb"
 msgid "Ar_ea"
 msgstr "Po_dročje"
 
-#: backgroundpage.ui:437
+#: backgroundpage.ui:439
 msgctxt "backgroundpage|tilerb"
 msgid "_Tile"
 msgstr "Razpos_tavi"
 
-#: backgroundpage.ui:465
+#: backgroundpage.ui:467
 msgctxt "backgroundpage|label8"
 msgid "Type"
 msgstr "Vrsta"
@@ -5195,87 +5195,107 @@ msgctxt "gradientpage|label1"
 msgid "Gradient"
 msgstr "Preliv"
 
-#: gradientpage.ui:150
+#: gradientpage.ui:149
 msgctxt "gradientpage|typeft"
 msgid "_Type:"
 msgstr "_Vrsta:"
 
-#: gradientpage.ui:164
+#: gradientpage.ui:165
 msgctxt "gradientpage|gradienttypelb"
 msgid "Linear"
 msgstr "Linearno"
 
-#: gradientpage.ui:165
+#: gradientpage.ui:166
 msgctxt "gradientpage|gradienttypelb"
 msgid "Axial"
 msgstr "Osno"
 
-#: gradientpage.ui:166
+#: gradientpage.ui:167
 msgctxt "gradientpage|gradienttypelb"
 msgid "Radial"
 msgstr "Radialno"
 
-#: gradientpage.ui:167
+#: gradientpage.ui:168
 msgctxt "gradientpage|gradienttypelb"
 msgid "Ellipsoid"
 msgstr "Elipsoidno"
 
-#: gradientpage.ui:168
+#: gradientpage.ui:169
 msgctxt "gradientpage|gradienttypelb"
 msgid "Quadratic"
 msgstr "Pravokotno"
 
-#: gradientpage.ui:169
+#: gradientpage.ui:170
 msgctxt "gradientpage|gradienttypelb"
 msgid "Square"
 msgstr "Kvadratno"
 
-#: gradientpage.ui:198
+#: gradientpage.ui:197
 msgctxt "gradientpage|incrementft"
 msgid "Increment:"
 msgstr "Prirastek:"

[Libreoffice-commits] core.git: sc/qa sc/source

2017-11-24 Thread Winfried Donkers 
 sc/qa/unit/data/functions/text/fods/len.fods |  100 +--
 sc/source/core/tool/interpr1.cxx |   10 ++
 2 files changed, 102 insertions(+), 8 deletions(-)

New commits:
commit 47155ce8fb4302d377b374d39b501d0a0f7577c5
Author: Winfried Donkers 
Date:   Mon Nov 13 15:18:52 2017 +0100

tdf#97198 Make Calc function LEN work with Unicode non-BMP characters.

Change-Id: Ibfdaaf1ed313257fc5f9036a7dd1ef51033fa8cd
Reviewed-on: https://gerrit.libreoffice.org/44681
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/sc/qa/unit/data/functions/text/fods/len.fods 
b/sc/qa/unit/data/functions/text/fods/len.fods
index 2d643cef2fcd..adc36d87f379 100644
--- a/sc/qa/unit/data/functions/text/fods/len.fods
+++ b/sc/qa/unit/data/functions/text/fods/len.fods
@@ -1189,13 +1189,99 @@
  
  
 
-
- 
- 
- 
- 
+
+ 
+  16
+ 
+ 
+  16
+ 
+ 
+  TRUE
+ 
+ 
+  =LEN(I10)
+ 
+ 
+  Excel 2016 returns 25
+ 
+ 
+ ab😂de𝔖gh𝕬𝖈𝖍𝖙𝖚𝖓𝖌!
+ 
  
- 
+
+
+ 
+  3
+ 
+ 
+  3
+ 
+ 
+  TRUE
+ 
+ 
+  =LEN(I11)
+ 
+ 
+  Excel 2016 returns 4
+ 
+ 
+ 
+  ab😂
+ 
+ 
+
+
+ 
+  4
+ 
+ 
+  4
+ 
+ 
+  TRUE
+ 
+ 
+  =LEN(I12)
+ 
+ 
+  Excel 2016 returns 6
+ 
+ 
+ 𧌒𧀬
+ 
+ 
+
+
+ 
+  6
+ 
+ 
+  6
+ 
+ 
+  TRUE
+ 
+ 
+  =LEN(I13)
+ 
+ 
+  Excel 2016 returns 6
+ 
+ 
+ 
+  üë
+ 
+ 
+
+
+  
+  
+ 
+  
+  
+  
  
 
 
@@ -1232,4 +1318,4 @@

   
  
-
\ No newline at end of file
+
diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index f83040c79e39..96d8f764a418 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -3064,7 +3064,15 @@ void ScInterpreter::ScLower()
 
 void ScInterpreter::ScLen()
 {
-PushDouble(GetString().getLength());
+OUString aStr = GetString().getString();
+sal_Int32 nIdx = 0;
+sal_Int32 nCnt = 0;
+while ( nIdx < aStr.getLength() )
+{
+aStr.iterateCodePoints(  );
+++nCnt;
+}
+PushDouble( nCnt );
 }
 
 void ScInterpreter::ScT()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa sc/source

2017-11-24 Thread Winfried Donkers 
 sc/qa/unit/data/functions/text/fods/find.fods |  148 +-
 sc/source/core/tool/interpr1.cxx  |   11 +
 2 files changed, 156 insertions(+), 3 deletions(-)

New commits:
commit 5e2a3eed69060d63070d72df60cd84247ca0bc9e
Author: Winfried Donkers 
Date:   Thu Nov 23 18:44:34 2017 +0100

tdf#97198 Make Calc function FIND work with UniCode non-BMP characters.

Change-Id: I512199a5d29aa955b278f0666c7ce904e67d9767
Reviewed-on: https://gerrit.libreoffice.org/45171
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/sc/qa/unit/data/functions/text/fods/find.fods 
b/sc/qa/unit/data/functions/text/fods/find.fods
index f5a1f2a2c06b..4f966cbe53a4 100644
--- a/sc/qa/unit/data/functions/text/fods/find.fods
+++ b/sc/qa/unit/data/functions/text/fods/find.fods
@@ -1254,7 +1254,151 @@
  
  
 
-
+
+ 
+  #VALUE!
+ 
+ 
+  #VALUE!
+ 
+ 
+  TRUE
+ 
+ 
+  =FIND(I16;J16)
+ 
+ 
+  Excel 2016 has same result
+ 
+ 
+ 
+  B😂
+ 
+ 
+  ab😂de𝔖gh𝕬𝖈𝖍𝖙𝖚𝖓𝖌!
+ 
+ 
+
+
+ 
+  3
+ 
+ 
+  3
+ 
+ 
+  TRUE
+ 
+ 
+  =FIND(I17;J16)
+ 
+ 
+  Excel 2016 has same result
+ 
+ 
+ 
+  😂d
+ 
+ 
+ 
+
+
+ 
+  3
+ 
+ 
+  3
+ 
+ 
+  TRUE
+ 
+ 
+  =FIND(I18;J18)
+ 
+ 
+  Excel 2016 returns 4
+ 
+ 
+ 
+  𧀬
+ 
+ 𧌒𧀬
+ 
+ 
+
+
+ 
+  8
+ 
+ 
+  8
+ 
+ 
+  TRUE
+ 
+ 
+  =FIND(I19;J16)
+ 
+ 
+  Excel 2016 returns 10
+ 
+ 
+ 
+  h
+ 
+ 
+
+
+ 
+  4
+ 
+ 
+  4
+ 
+ 
+  TRUE
+ 
+ 
+  =FIND(I20;J20)
+ 
+ 
+  Excel 2016 has same result
+ 
+ 
+ 
+  e
+ 
+ 
+  üë
+ 
+ 
+
+
+ 
+  3
+ 
+ 
+  3
+ 
+ 
+  TRUE
+ 
+ 
+  =FIND(I21;J21)
+ 
+ 
+  Excel 2016 returns 5
+ 
+ 
+ 
+  𝖍𝖙
+ 
+ 
+  𝕬𝖈𝖍𝖙𝖚𝖓𝖌!
+ 
+ 
+
+
  
  
  
@@ -1288,4 +1432,4 @@

   
  
-
\ No newline at end of file
+
diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index 2f2955b52927..f83040c79e39 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -8526,7 +8526,16 @@ void ScInterpreter::ScFind()
 if (nPos == -1)
 PushNoValue();
 else
-PushDouble((double)(nPos + 1));
+{
+sal_Int32 nIdx = 0;
+nCnt = 0;
+while ( nIdx <= nPos )
+{
+sStr.iterateCodePoints(  );
+++nCnt;
+}
+PushDouble( ( double )nCnt );
+}
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa sc/source

2017-11-24 Thread Winfried Donkers 
 sc/qa/unit/data/functions/text/fods/right.fods |  112 ++---
 sc/source/core/tool/interpr1.cxx   |   26 +
 2 files changed, 108 insertions(+), 30 deletions(-)

New commits:
commit 09455734727daa3774158795febd910b33b1d784
Author: Winfried Donkers 
Date:   Thu Nov 16 16:40:25 2017 +0100

tdf#97198 Make Calc function RIGHT work with Unicode non-BMP characters.

Change-Id: I775bc50d8e5948a2af9efb77dcea9d7cae7293d5
Reviewed-on: https://gerrit.libreoffice.org/44834
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/sc/qa/unit/data/functions/text/fods/right.fods 
b/sc/qa/unit/data/functions/text/fods/right.fods
index 9f4b97f1f8b3..fff9ffc855cc 100644
--- a/sc/qa/unit/data/functions/text/fods/right.fods
+++ b/sc/qa/unit/data/functions/text/fods/right.fods
@@ -1251,9 +1251,12 @@
  
   un
  
+ 
+  TRUE
+ 
  
  
- 
+ 
  
   b
  
@@ -1282,55 +1285,110 @@
  
 
 
- 
- 
- 
- 
- 
+ 
+  𝔖gh𝕬𝖈𝖍𝖙𝖚𝖓𝖌!
+ 
+ 
+  𝔖gh𝕬𝖈𝖍𝖙𝖚𝖓𝖌!
+ 
+ 
+  TRUE
+ 
+ 
+  
=RIGHT(ab😂de𝔖gh𝕬𝖈𝖍𝖙𝖚𝖓𝖌!;11)
+ 
+ 
+  Excel 2016 returns same result
+ 
+ 
  
   c
  
  
 
 
- 
- 
- 
- 
- 
+ 
+  b😂
+ 
+ 
+  b😂
+ 
+ 
+  TRUE
+ 
+ 
+  =RIGHT(ab😂;2)
+ 
+ 
+  Excel 2016 returns same result
+ 
+ 
  
   d
  
  
 
 
- 
- 
- 
- 
- 
+ 
+  𧀬
+ 
+ 
+  𧀬
+ 
+ 
+  TRUE
+ 
+ 
+  =RIGHT(𧌒𧀬;2)
+ 
+ 
+  Excel 2016 returns same result
+ 
+ 
  
   E
  
  
 
 
- 
- 
- 
- 
- 
+ 
+  ̈
+ 
+ 
+  ̈
+ 
+ 
+  TRUE
+ 
+ 
+  =RIGHT(üë;2)
+ 
+ 
+  Excel 2016 returns same result
+ 
+ 
  
   f
  
  
 
 
- 
- 
- 
- 
- 
+ 
+  𝖚𝖓𝖌!
+ 
+ 
+  𝖚𝖓𝖌!
+ 
+ 
+  TRUE
+ 
+ 
+  =RIGHT(𝕬𝖈𝖍𝖙𝖚𝖓𝖌!;4)
+ 
+ 
+  Excel 2016 returns same result
+ 
+ 
  
   g
  
@@ -1488,4 +1546,4 @@

   
  
-
\ No newline at end of file
+
diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index d53c00f9fcd7..2f2955b52927 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -8867,9 +8867,29 @@ void ScInterpreter::ScRight()
 else
 n = 1;
 OUString aStr = GetString().getString();
-if( n < aStr.getLength() )
-aStr = aStr.copy( aStr.getLength() - n );
-PushString( aStr );
+sal_Int32 nLen = aStr.getLength();
+sal_Int32 nIdx = 0;
+sal_Int32 nCnt = 0;
+while ( nIdx < nLen )
+{
+aStr.iterateCodePoints(  );
+++nCnt;
+}
+if ( nCnt <= n )
+PushString( aStr );
+else
+{
+sal_Int32 nCLen = nCnt;
+nIdx = 0;
+nCnt = 0;
+while ( nIdx < nLen && n < ( nCLen - nCnt ) )
+{
+aStr.iterateCodePoints(  );
+++nCnt;
+}
+aStr = aStr.copy( nIdx, nLen - nIdx );
+PushString( aStr );
+}
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa sc/source

2017-11-24 Thread Winfried Donkers 
 sc/qa/unit/data/functions/text/fods/mid.fods |  175 ++-
 sc/source/core/tool/interpr1.cxx |   28 +++-
 2 files changed, 166 insertions(+), 37 deletions(-)

New commits:
commit e78f508997f9384518c2dd1a005c5306ccd24783
Author: Winfried Donkers 
Date:   Tue Nov 21 16:08:32 2017 +0100

tdf#97198 Make calc function MID work with Unicode non-BMP characters.

Change-Id: Ic86344495490d6ca942f9fd2752874da22ef531f
Reviewed-on: https://gerrit.libreoffice.org/45040
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/qa/unit/data/functions/text/fods/mid.fods 
b/sc/qa/unit/data/functions/text/fods/mid.fods
index 56fcd55d3f27..68c7feb10299 100644
--- a/sc/qa/unit/data/functions/text/fods/mid.fods
+++ b/sc/qa/unit/data/functions/text/fods/mid.fods
@@ -1054,41 +1054,158 @@
  
  
 
-
- 
- 
- 
- 
- 
+
+ 
+  
+ 
+ 
+  
+ 
+ 
+  TRUE
+ 
+ 
+  =MID(I2;12;8)
+ 
+ 
 
 
- 
- 
- 
- 
+ 
+  Err:502
+ 
+ 
+  Err:502
+ 
+ 
+  TRUE
+ 
+ 
+  =MID(I2;0;3)
+ 
+ 
 
 
- 
- 
- 
- 
+ 
+  b😂
+ 
+ 
+  b😂
+ 
+ 
+  TRUE
+ 
+ 
+  =MID(I8;J8;K8)
+ 
+ 
+  result Excel 2016 is b😂
+ 
+ 
+ ab😂de𝔖gh𝕬𝖈𝖍𝖙𝖚𝖓𝖌!
+ 
+ 
+  2
+ 
 
-
- 
- 
- 
- 
- 
+
+ 
+  b
+ 
+ 
+  b
+ 
+ 
+  TRUE
+ 
+ 
+  =MID(I9;J9;K9)
+ 
+ 
+  result Excel 2016 is b
+ 
+ 
+ 
+  ab😂
+ 
+ 
+  2
+ 
+ 
+  1
+ 
 
-
- 
- 
- 
- 
- 
- 
+
+ 
+  𧌒𧀬
+ 
+ 
+  𧌒𧀬
+ 
+ 
+  TRUE
+ 
+ 
+  =MID(I10;J10;K10)
+ 
+ 
+  result Excel 2016 is 𧌒
+ 
+ 
+ 𧌒𧀬
+ 
+ 
+  2
+ 
+
+
+ 
+  ü
+ 
+ 
+  ü
+ 
+ 
+  TRUE
+ 
+ 
+  =MID(I11;J11;K11)
+ 
+ 
+  result Excel 2016 is identical
+ 
+ 
+ 
+  üë
+ 
+ 
+  2
+ 
+
+
+ 
+  𝖍𝖙𝖚
+ 
+ 
+  𝖍𝖙𝖚
+ 
+ 
+  TRUE
+ 
+ 
+  =MID(I12;J12;K12)
+ 
+ 
+  result Excel 2016 is 𝖈
+ 
+ 
+ 
+  𝕬𝖈𝖍𝖙𝖚𝖓𝖌!
+ 
+ 
+  3
+ 
 
-
+
  
  
  
@@ -1130,4 +1247,4 @@

   
  
-
\ No newline at end of file
+
diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index 5bb02e6e363d..d53c00f9fcd7 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -8914,18 +8914,30 @@ void ScInterpreter::ScMid()
 {
 if ( MustHaveParamCount( GetByte(), 3 ) )
 {
-double fCnt= GetStringPositionArgument();
-double fAnfang = GetStringPositionArgument();
+sal_Int32 nSubLen = ( sal_Int32 )GetStringPositionArgument();
+sal_Int32 nStart  = ( sal_Int32 )GetStringPositionArgument();
 OUString aStr = GetString().getString();
-if (fAnfang < 1.0 || fCnt < 0.0)
+if ( nStart < 1 || nSubLen < 0 )
 PushIllegalArgument();
 else
 {
-sal_Int32 nCharacters = 
std::min(static_cast(fCnt), aStr.getLength() - fAnfang + 
1);
-OUString sRes;
-if (nCharacters > 0)
-sRes = aStr.copy(static_cast(fAnfang-1), 
nCharacters);
-PushString(sRes);
+sal_Int32 nLen = aStr.getLength();
+sal_Int32 nIdx = 0;
+sal_Int32 nCnt = 0;
+while ( nIdx < nLen && nStart - 1 > nCnt )
+{
+aStr.iterateCodePoints(  );
+++nCnt;
+}
+sal_Int32 nIdx0 = nIdx;  //start position
+
+while ( nIdx < nLen && nStart + nSubLen - 1 > nCnt )
+{
+aStr.iterateCodePoints(  );
+++nCnt;
+}
+aStr = aStr.copy( nIdx0, nIdx - nIdx0 );
+PushString( aStr );
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 113908] [PIVOT TABLE]: filter of grouped date disappears after resaving XLSX file

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113908

--- Comment #4 from Bartosz  ---
How I could edit filter of grouped date in MS Excel?

I would like to recreate similar document by ownself.
How I could create such grouped filter?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114036] New: VIEWING : Symbol and Opensymbol fonts shows rectangles instead of greek characters in libreoffice writer 5.3

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114036

Bug ID: 114036
   Summary: VIEWING : Symbol and Opensymbol fonts shows rectangles
instead of greek characters in libreoffice writer 5.3
   Product: LibreOffice
   Version: 5.3.6.1 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bg...@juggling.ch

Description:
I work under linux KUbuntu 16.04 64 bits, with KDE.
I have many .odt files with greek characters coming from the "symbol.ttf" font.
It works very well under libreoffice 5.1.
I updated to libreoffice 5.3, there the greek characters disappeared.
They were all replaced by white rectangles.
I removed libreoffice 5.3 to come back to libreoffice 5.1 and characters are
back.
I tried on another computer also on linux KUbuntu 16.04 64 bits + KDE, with
version 5.4 of libreoffice, there the characters worked well.
So I hope this is just a temporary regression in 5.3, with is resolved in 5.4.

Thank you for your development, Bernard Gisin.




Steps to Reproduce:
1.Insert a symbol from the font  "symbol"  or  "opensymbol"
2.type a character just after your symbol, a rectangle appear.
3.OR
4.Type letters, select them then change the font to symbol, the greek letters
appear as rectangles.

Actual Results:  
white rectangles appear.

Expected Results:
greek characters should appear.


Reproducible: Always


User Profile Reset: No



Additional Info:
>From on test, as I already wrote, the problem doesn't appear under version 5.4



User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:54.0) Gecko/20100101
Firefox/54.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: external/gpgmepp RepositoryExternal.mk

2017-11-24 Thread Thorsten Behrens 
 RepositoryExternal.mk   |2 +-
 external/gpgmepp/ExternalPackage_gpgmepp.mk |4 
 2 files changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 0b202dbdc8b4eae8bcf083c7850480d4c6bcdb24
Author: Thorsten Behrens 
Date:   Fri Nov 24 21:02:22 2017 +0100

gpgme: fix build

Change-Id: I89170e90ea7fdd5b159a952fb0b2b1b4d0ae9204

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 4fba2a4c00e5..bb3c9b6895e0 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -3535,7 +3535,7 @@ $(eval $(call 
gb_Helper_register_libraries_for_install,PLAINLIBS_OOO,ooo,\
 ))
 
 $(eval $(call gb_Helper_register_executables_for_install,OOO,ooo, \
-   gpgmepp-w32spawn \
+   gpgme-w32spawn \
 ))
 
 endif
diff --git a/external/gpgmepp/ExternalPackage_gpgmepp.mk 
b/external/gpgmepp/ExternalPackage_gpgmepp.mk
index d5285520619f..3e841b5d98df 100644
--- a/external/gpgmepp/ExternalPackage_gpgmepp.mk
+++ b/external/gpgmepp/ExternalPackage_gpgmepp.mk
@@ -23,6 +23,10 @@ else ifeq ($(OS),MACOSX)
 $(eval $(call 
gb_ExternalPackage_add_file,gpgmepp,$(LIBO_LIB_FOLDER)/libgpgmepp.6.dylib,lang/cpp/src/.libs/libgpgmepp.6.dylib))
 $(eval $(call 
gb_ExternalPackage_add_file,gpgmepp,$(LIBO_LIB_FOLDER)/libgpgme.11.dylib,src/.libs/libgpgme.11.dylib))
 
+else ifeq ($(OS),WNT)
+
+$(eval $(call 
gb_ExternalPackage_add_file,gpgmepp,$(LIBO_LIB_FOLDER)/gpgme-w32spawn.exe,src/gpgme-w32spawn.exe))
+
 endif
 
 endif # $(DISABLE_DYNLOADING)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114035] Style loading fails on Open: Document all default style

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114035

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||serval2...@yahoo.fr
 Ever confirmed|0   |1

--- Comment #1 from Julien Nabet  ---
Could you give a try to last stable LO version 5.4.3?
I suppose you'll find it on LO ppa.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100037] Image arrangement (in Z dimension) not respected in docx ( EMF included)

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100037

--- Comment #7 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: package/source

2017-11-24 Thread Caolán McNamara 
 package/source/zipapi/XBufferedThreadedStream.cxx |   20 +---
 package/source/zipapi/XBufferedThreadedStream.hxx |4 ++--
 2 files changed, 7 insertions(+), 17 deletions(-)

New commits:
commit 2a7fa39bc1fb3a81fdcc632853aef224f4793f8a
Author: Caolán McNamara 
Date:   Fri Nov 24 14:05:58 2017 +

fix attempt to save and rethrow exception

Change-Id: Idff6ffef536d87d85f1092b3316d65da83527711
Reviewed-on: https://gerrit.libreoffice.org/45229
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/package/source/zipapi/XBufferedThreadedStream.cxx 
b/package/source/zipapi/XBufferedThreadedStream.cxx
index 82bb992f0128..2c36b73ea409 100644
--- a/package/source/zipapi/XBufferedThreadedStream.cxx
+++ b/package/source/zipapi/XBufferedThreadedStream.cxx
@@ -9,6 +9,7 @@
 
 #include "XBufferedThreadedStream.hxx"
 #include 
+#include 
 
 using namespace css::uno;
 using com::sun::star::packages::zip::ZipIOException;
@@ -27,20 +28,10 @@ private:
 {
 mxStream.produce();
 }
-catch( const RuntimeException  )
-{
-SAL_WARN("package", "RuntimeException from unbuffered Stream " << 
e );
-mxStream.saveException( new RuntimeException( e ) );
-}
-catch( const ZipIOException  )
-{
-SAL_WARN("package", "ZipIOException from unbuffered Stream " << e 
);
-mxStream.saveException( new ZipIOException( e ) );
-}
-catch( const Exception  )
+catch (const css::uno::Exception )
 {
 SAL_WARN("package", "Unexpected " << e );
-mxStream.saveException( new Exception( e ) );
+mxStream.saveException(cppu::getCaughtException());
 }
 
 mxStream.setTerminateThread();
@@ -58,7 +49,6 @@ XBufferedThreadedStream::XBufferedThreadedStream(
 , mnOffset( 0 )
 , mxUnzippingThread( new UnzippingThread(*this) )
 , mbTerminateThread( false )
-, maSavedException( nullptr )
 {
 mxUnzippingThread->launch();
 }
@@ -116,8 +106,8 @@ const Buffer& XBufferedThreadedStream::getNextBlock()
 if( maPendingBuffers.empty() )
 {
 maInUseBuffer = Buffer();
-if( maSavedException )
-throw *maSavedException;
+if (maSavedException.hasValue())
+cppu::throwException(maSavedException);
 }
 else
 {
diff --git a/package/source/zipapi/XBufferedThreadedStream.hxx 
b/package/source/zipapi/XBufferedThreadedStream.hxx
index 8bf3c5eb1283..b99864fbb268 100644
--- a/package/source/zipapi/XBufferedThreadedStream.hxx
+++ b/package/source/zipapi/XBufferedThreadedStream.hxx
@@ -37,7 +37,7 @@ private:
 std::condition_variable maBufferProduceResume;
 bool mbTerminateThread; /// indicates the 
failure of one of the threads
 
-css::uno::Exception *maSavedException;  /// exception 
caught during unzipping is saved to be thrown during reading
+css::uno::Any maSavedException; /// exception 
caught during unzipping is saved to be thrown during reading
 
 static const size_t nBufferLowWater = 2;
 static const size_t nBufferHighWater = 4;
@@ -66,7 +66,7 @@ public:
 
 void produce();
 void setTerminateThread();
-void saveException( css::uno::Exception *e ) { maSavedException = e; }
+void saveException(const css::uno::Any ) { maSavedException = rAny; }
 
 // XInputStream
 virtual sal_Int32 SAL_CALL readBytes( css::uno::Sequence< sal_Int8 >& 
aData, sal_Int32 nBytesToRead ) override;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114014] white program icons (except Calc and Math)

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114014

--- Comment #4 from Vianello  ---
Created attachment 137970
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137970=edit
Difference version 5.3 and 5.4 icon

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114014] white program icons (except Calc and Math)

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114014

Vianello  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #3 from Vianello  ---
I tried again by following the directions of the link you entered, deleting the
file shown and restarting.
Installed 5.4.3.2 64 bit, updating from 5.3.7.2 does not change anything.
Only 'Math' and 'calc' remain with the icon.
Yesterday I tried to install 5.4.3.2 directly after uninstalling 5.3.7.2
without success.
With the previous version 5.3 no problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114035] New: Style loading fails on Open: Document all default style

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114035

Bug ID: 114035
   Summary: Style loading fails on Open: Document all default
style
   Product: LibreOffice
   Version: 5.4.1.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: libromp...@inbox247.com

Created attachment 137969
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137969=edit
Broken document

Docx document styles becomes broken persistently so that LibreOffice can no
longer open them as docx document.

Please updated Writer to successfully load the attached document and to avoid
this problem in the future.


Symptom: for a broken docx document, on open, Text Body and table of contents
styles becomes Default Style.
All style information is reset and has to be reloaded using LibreOffice -
Styles - Styles and Formatting F11 - Load Styles… - Overwrite, OK

* In Ubuntu 16.04, document recovery was broken for Writer, so for docx, 20% of
the documents recovered had their style loading no longer working

* I have a lathe number of such document that on load have all styles set to
Default Style

* The cause is that style loading is aborted on Open so that no styles are
applied to the document paragraphs or table of contents

* Document cannot be repaired: of they are saved as odt they work, if they are
saved back to docx they are again broken

* If text are pasted to a functional document from a broken document, the
functional document is broken, too

https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1649295

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114034] .docx import: bad position of image

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114034

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de

--- Comment #2 from Dieter Praas  ---
There are some bugs with a similar summary. Perhaps you can check, if there is
a duplicate or not, for example bug 94353 or bug 96622

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92907] Exiting LibreOffice takes a long time with much spreadsheet data in the clipboard

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=92907

Telesto  changed:

   What|Removed |Added

 CC||tele...@surfxs.nl
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||2537

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112537] Ask if the clipboard should be cleared before closing, when a large amount data is stored on the Clipboard

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=112537

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=92
   ||907

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94109] Writer sluggish

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=94109

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||2568

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112568] Slow typing in Writer after inserting png image, image repaints all the time

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=112568

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=94
   ||109

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/sfx2

2017-11-24 Thread Noel Grandin 
 include/sfx2/viewsh.hxx |2 --
 1 file changed, 2 deletions(-)

New commits:
commit bd43062c98be535b37031b2bdae4af856f392eee
Author: Noel Grandin 
Date:   Fri Nov 24 14:48:28 2017 +0200

remove bogus ifdef block

since the define in question is defined at the top of the file

Change-Id: Ife67ad02db4a1a3c9ce4569b94ecf681dec5d2bf
Reviewed-on: https://gerrit.libreoffice.org/45225
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx
index 7c9929fbbe9e..65975dc8e27d 100644
--- a/include/sfx2/viewsh.hxx
+++ b/include/sfx2/viewsh.hxx
@@ -142,11 +142,9 @@ template bool checkSfxViewShell(const 
SfxViewShell* pShell)
 
 class SFX2_DLLPUBLIC SfxViewShell: public SfxShell, public SfxListener, public 
OutlinerViewShell
 {
-#ifdef INCLUDED_SFX2_VIEWSH_HXX
 friend class SfxViewFrame;
 friend class SfxBaseController;
 friend class SfxPrinterController;
-#endif
 
 std::unique_ptr   pImpl;
 SfxViewFrame*   pFrame;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99416] Copy/paste and adding/removing columns or lines is slow

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=99416

Xisco Faulí  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs and enhancements

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=103100

Sébastien Guyader  changed:

   What|Removed |Added

 Depends on|99416   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=99416
[Bug 99416] Copy/paste and adding/removing columns or lines is slow
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108364] [META] Table/Row/Column/ Cell management function bugs and enhancements

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=108364
Bug 108364 depends on bug 99416, which changed state.

Bug 99416 Summary: Copy/paste and adding/removing columns or lines is slow
https://bugs.documentfoundation.org/show_bug.cgi?id=99416

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99416] Copy/paste and adding/removing columns or lines is slow

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=99416

Sébastien Guyader  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Blocks|103100  |
 Resolution|--- |FIXED

--- Comment #8 from Sébastien Guyader  ---
It looks like the issue is solved (Version: 5.4.3.2; Build ID: 5.4.3-1; CPU
threads: 4; OS: Linux 4.14; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.utf8); Calc: group)

I'm changing the status to resolved. Thanks!


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99416] Copy/paste and adding/removing columns or lines is slow

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=99416

Telesto  changed:

   What|Removed |Added

 Blocks||103100


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs and enhancements

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=103100

Telesto  changed:

   What|Removed |Added

 Depends on||99416


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=99416
[Bug 99416] Copy/paste and adding/removing columns or lines is slow
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108353] Inserting lots of rows to table burns CPU if Automatic spell checking is enabled

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=108353

Telesto  changed:

   What|Removed |Added

 Blocks||103100


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs and enhancements

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=103100

Telesto  changed:

   What|Removed |Added

 Depends on||108353


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108353
[Bug 108353] Inserting lots of rows to table burns CPU if Automatic spell
checking is enabled
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs and enhancements

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=103100

Telesto  changed:

   What|Removed |Added

 Depends on||113981


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113981
[Bug 113981] Adding a table row and/or resizing a table column height/width for
a large table is noticeably slower compared to LibO 5.0
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113981] Adding a table row and/or resizing a table column height/ width for a large table is noticeably slower compared to LibO 5.0

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113981

Telesto  changed:

   What|Removed |Added

 Blocks||103100


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99416] Copy/paste and adding/removing columns or lines is slow

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=99416

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||3981,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||8353

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108353] Inserting lots of rows to table burns CPU if Automatic spell checking is enabled

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=108353

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||416

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113981] Adding a table row and/or resizing a table column height/ width for a large table is noticeably slower compared to LibO 5.0

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113981

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||416

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - svx/source

2017-11-24 Thread Julien Nabet 
 svx/source/dialog/fntctrl.cxx |   32 +---
 1 file changed, 21 insertions(+), 11 deletions(-)

New commits:
commit 479719b1f53cb5f44bbcc57e75dad1aae604cd20
Author: Julien Nabet 
Date:   Wed Nov 8 23:17:56 2017 +0100

tdf#113657: fix crash when trying to format empty paragraph

by creating a function to clean line feeds and returns if it's empty or not

Reviewed-on: https://gerrit.libreoffice.org/44513
Tested-by: Jenkins 
Tested-by: Xisco Faulí 
Reviewed-by: Michael Stahl 
(cherry picked from commit 3f289fef2f2b00dcca4948dd9fb2ba2c493fac6f)

svx: loplugin:staticmethods
(cherry picked from commit 16687c57b5e378db93972fc1887b9b19747d068c)

Change-Id: I3a744c52bdb457c92f38595463099e1cbf17a37e
Reviewed-on: https://gerrit.libreoffice.org/45151
Reviewed-by: Michael Stahl 
Tested-by: Jenkins 

diff --git a/svx/source/dialog/fntctrl.cxx b/svx/source/dialog/fntctrl.cxx
index 213126c069c1..f139cb7f631f 100644
--- a/svx/source/dialog/fntctrl.cxx
+++ b/svx/source/dialog/fntctrl.cxx
@@ -611,6 +611,24 @@ void SvxFontPrevWindow::UseResourceText()
 pImpl->mbUseResText = true;
 }
 
+/*
+ * removes line feeds and carriage returns from string
+ * returns if param is empty
+ */
+bool CleanAndCheckEmpty(OUString& rText)
+{
+bool bEmpty = true;
+for (sal_Int32 i = 0; i < rText.getLength(); ++i)
+{
+if (0xa == rText[i] || 0xd == rText[i])
+rText = rText.replaceAt(i, 1, " ");
+else
+bEmpty = false;
+}
+return bEmpty;
+}
+
+
 void SvxFontPrevWindow::Paint(vcl::RenderContext& rRenderContext, const 
tools::Rectangle&)
 {
 ApplySettings(rRenderContext);
@@ -644,7 +662,7 @@ void SvxFontPrevWindow::Paint(vcl::RenderContext& 
rRenderContext, const tools::R
 {
 pImpl->maText = pSh->GetSelectionText();
 pImpl->mbGetSelection = true;
-pImpl->mbSelection = !pImpl->maText.isEmpty();
+pImpl->mbSelection = !CleanAndCheckEmpty(pImpl->maText);
 }
 
 if (!pImpl->mbSelection || pImpl->mbUseFontNameAsText)
@@ -680,16 +698,8 @@ void SvxFontPrevWindow::Paint(vcl::RenderContext& 
rRenderContext, const tools::R
 pImpl->maText = makeRepresentativeTextForFont(LATIN, rFont);
 }
 
-// remove line feeds and carriage returns from string
-bool bNotEmpty = false;
-for (sal_Int32 i = 0; i < pImpl->maText.getLength(); ++i)
-{
-if (0xa == pImpl->maText[i] || 0xd == pImpl->maText[i])
- pImpl->maText = pImpl->maText.replaceAt(i, 1, " ");
-else
-bNotEmpty = true;
-}
-if (!bNotEmpty)
+bool bEmpty = CleanAndCheckEmpty(pImpl->maText);
+if (bEmpty)
 pImpl->maText = GetText();
 
 if (pImpl->maText.getLength() > (TEXT_WIDTH - 1))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107039] Crash on Close after acknowledging save changes - mutex issue ( steps in comment 21)

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107039

rob...@familiegrosskopf.de changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||4032

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114032] Base hangs while closing

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114032

rob...@familiegrosskopf.de changed:

   What|Removed |Added

 CC||rob...@familiegrosskopf.de
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||7039

--- Comment #1 from rob...@familiegrosskopf.de ---
Isn't this a duplicate of bug107039 ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105647] Paragraph style old value doesn't disappeared

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=105647

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #12 from Xisco Faulí  ---
Hi Xavier,

i can't reproduce it in

Version: 6.0.0.0.alpha1+
Build ID: d47aa694d0c6d10d52b7474b15e75a9462e991ff
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: th-TH (ca_ES.UTF-8); Calc: group threaded

Using SAL_SYNCRONIZE.
Do you use Gtk, Gtk3, kde? Could you please give us more info about your
desktop enviroment? Pasting the info from Help - About LibreOffice would be
helpful. OTOH, do you still reproduce it with the latest version of Libo?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - ios/CustomTarget_iOS_prelink.mk

2017-11-24 Thread jan Iversen 
 ios/CustomTarget_iOS_prelink.mk |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit e632cee783513891dccdf64b8f60398a8940c0fb
Author: jan Iversen 
Date:   Fri Nov 24 19:18:23 2017 +0100

iOS, typo in release mk

removed extra l

Change-Id: I6b01bb25a3e8d1caa5ba04ac09a5fa078bb2d664

diff --git a/ios/CustomTarget_iOS_prelink.mk b/ios/CustomTarget_iOS_prelink.mk
index 8c97019b8c41..76ece5a5023b 100644
--- a/ios/CustomTarget_iOS_prelink.mk
+++ b/ios/CustomTarget_iOS_prelink.mk
@@ -12,7 +12,7 @@ IOSLD = 
$(IOSDEV)Toolchains/XcodeDefault.xctoolchain/usr/bin/ld
 ifeq ($(ENABLE_DEBUG),TRUE)
 IOSKIT = $(SRCDIR)/ios/generated/libLibreOfficeKit_$(CPUNAME)_debug.o
 else
-IOSKIT = l$(SRCDIR)/ios/generated/libLibreOfficeKit_$(CPUNAME).o
+IOSKIT = $(SRCDIR)/ios/generated/libLibreOfficeKit_$(CPUNAME).o
 endif
 
 
commit d29439104f060fa3b5eb17260a2fda69d8943d16
Author: jan Iversen 
Date:   Fri Nov 24 19:13:25 2017 +0100

iOS, used wrong gbuild get_target macro

Change-Id: Ie23c71faef2b14480b3797dd66bfe9788401ccf4

diff --git a/ios/CustomTarget_iOS_prelink.mk b/ios/CustomTarget_iOS_prelink.mk
index b48b43e5e0c3..8c97019b8c41 100644
--- a/ios/CustomTarget_iOS_prelink.mk
+++ b/ios/CustomTarget_iOS_prelink.mk
@@ -28,7 +28,7 @@ $(call gb_CustomTarget_get_target,ios/iOS_prelink): $(IOSKIT)
 .PHONY: FORCE
 FORCE:
 
-$(IOSKIT): $(call gb_CustomTarget_get_target,iOS_kitBridge) FORCE
+$(IOSKIT): $(call gb_StaticLibrary_get_target,iOS_kitBridge) FORCE
$(IOSLD) -r -ios_version_min 11.1 \
-syslibroot $(MACOSX_SDK_PATH) \
-arch `echo $(CPUNAME) |  tr '[:upper:]' '[:lower:]'` \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99416] Copy/paste and adding/removing columns or lines is slow

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=99416

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #7 from Xisco Faulí  ---
Hi Sébastien,
Could you please try to reproduce it with the latest version of LibreOffice
from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113061] Tofu in menu bar with Cantarell in flatpak fresh on Fedora

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113061

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #4 from Buovjaga  ---
What about the release in here: https://flathub.org/apps.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106208] Writer loses last user event if auto-save triggers at a similar times

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106208

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #4 from Xisco Faulí  ---
Hi Luke,
Could you please share one of those long documents you mentioned in the
description?
(Please note that the attachment will be public, remove any sensitive
information before attaching it. 
See
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
for help on how to do so.)

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the requested document is provided.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114034] .docx import: bad position of image

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114034

--- Comment #1 from Frederic Parrenin 
 ---
Created attachment 137968
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137968=edit
.docx file to reproduce the problem

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114034] New: .docx import: bad position of image

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114034

Bug ID: 114034
   Summary: .docx import: bad position of image
   Product: LibreOffice
   Version: 5.4.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: frederic.parre...@univ-grenoble-alpes.fr

Description:
When opening the attached .docx file in Word and Writer, the image is not
placed in the same way.

Steps to Reproduce:
1. Open the attached .docx file in Writer
2. Open it in Word
3. Compare

Actual Results:  
In Writer, the image is placed under "French LIA manager"
In Word, the image is placed left of "Scientific coordinator of the project"

Expected Results:
The position of the image in Writer should be the same than in Word


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101
Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112891] Add percent sign to a cell without recalculation

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=112891

--- Comment #6 from Xisco Faulí  ---
Hi Caoĺán,
Is your commit intended to fix this issue or is it just a typo in the commit
message ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114022] Selection in Input Line, of cell containing also an email address as link, is not synchronized properly in the cell

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114022

Buovjaga  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #3 from Buovjaga  ---
Problem is not yet in 3.6.

Arch Linux 64-bit
Version: 6.0.0.0.alpha1+
Build ID: 008673c23db0c812eb0b48a1c29ab88b48aaa867
CPU threads: 8; OS: Linux 4.13; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group threaded
Built on November 23rd 2017

Arch Linux 64-bit
Version 3.6.7.2 (Build ID: e183d5b)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114033] New: Crash in: libgobject-2.0.so.0.5000.3

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114033

Bug ID: 114033
   Summary: Crash in: libgobject-2.0.so.0.5000.3
   Product: LibreOffice
   Version: 5.4.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bridgeportcontrac...@gmail.com

This bug was filed from the crash reporting server and is
br-fe533d7c-4d85-4e92-98ff-b0acbc756ee7.
=

A random crash, but I have seen this a bunch of times now.  

I think it might occur when moving the focus from one Form editing dialog to
another, especially if I click before the screen is fully redrawn.  But I can't
be sure.

Sometimes this just crashes LO, but not my cinnamon window manager.  Other
times, like this time, it also crashes cinnamon.  

I have not seen it also crash linux.

Not sure what other information I can provide that would help with this.


Recovery notes:

I was able to restart with:

* Ctrl-Alt-F2 to get to TTY2, then login to home, 
* then issue 'pkill cinnamon' to restart cinnamon.  
* Then once cinnamon restarted the LO windows were still dead.  
* So I had to click the upper right "X" of a LO window,  wait a bit, then click
Force quit.  
* Then restart LO.  

* Then as is often the case when I then try to restart LO this also fails and
have to again click the upper right "X" of a LO window,  wait a bit, then click
Force quit.  
* Then restart LO again.  This time it uses the older backup of my Base and
starts correctly, but loosing my edits.

linux 9.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - sw/qa sw/source

2017-11-24 Thread Mike Kaganski 
 sw/qa/extras/ooxmlexport/data/mailmerge.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlexport9.cxx|   27 +++
 sw/qa/extras/ww8export/data/mailmerge.doc|binary
 sw/qa/extras/ww8export/ww8export2.cxx|   27 +++
 sw/source/filter/ww8/rtfattributeoutput.cxx  |7 ++-
 sw/source/filter/ww8/ww8atr.cxx  |6 ++
 6 files changed, 62 insertions(+), 5 deletions(-)

New commits:
commit b8b75225a4b0af7bb841cd5205adc2ad2d13b705
Author: Mike Kaganski 
Date:   Fri Nov 24 00:18:09 2017 +0300

tdf#67207: export MERGEDIELD to DOCX and DOC

Also removed a hack for i119803, because proper solution is
implemented.

This does not export data source information yet.

Unit tests for DOC and DOCX are included. RTF export is already
covered in testFdo80905.

Change-Id: Id4f6d53344edf474add7e885e8ae6f36618e569f
Reviewed-on: https://gerrit.libreoffice.org/45193
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 
Reviewed-on: https://gerrit.libreoffice.org/45243
Tested-by: Mike Kaganski 

diff --git a/sw/qa/extras/ooxmlexport/data/mailmerge.docx 
b/sw/qa/extras/ooxmlexport/data/mailmerge.docx
new file mode 100644
index ..7e209a1b4dc9
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/mailmerge.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
index a7b36683f943..08de896708f8 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
@@ -11,6 +11,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -574,6 +575,32 @@ DECLARE_OOXMLEXPORT_TEST(testTdf111964, "tdf111964.docx")
 assertXPathContent(pXmlDoc, "/w:document/w:body/w:p/w:r[4]/w:t", 
sWSReference);
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf67207_MERGEFIELD, "mailmerge.docx")
+{
+uno::Reference xTextField = getProperty< 
uno::Reference >(getRun(getParagraph(1), 2), "TextField");
+CPPUNIT_ASSERT(xTextField.is());
+uno::Reference xServiceInfo(xTextField, 
uno::UNO_QUERY_THROW);
+uno::Reference xDependent(xTextField, 
uno::UNO_QUERY_THROW);
+
+
CPPUNIT_ASSERT(xServiceInfo->supportsService("com.sun.star.text.TextField.Database"));
+OUString sValue;
+xTextField->getPropertyValue("Content") >>= sValue;
+CPPUNIT_ASSERT_EQUAL(OUString::fromUtf8(u8"«Name»"), sValue);
+
+uno::Reference xFiledMaster = 
xDependent->getTextFieldMaster();
+uno::Reference xFiledMasterServiceInfo(xFiledMaster, 
uno::UNO_QUERY_THROW);
+
+
CPPUNIT_ASSERT(xFiledMasterServiceInfo->supportsService("com.sun.star.text.fieldmaster.Database"));
+
+// Defined properties: DataBaseName, Name, DataTableName, DataColumnName, 
DependentTextFields, DataCommandType, InstanceName, DataBaseURL
+CPPUNIT_ASSERT(xFiledMaster->getPropertyValue("Name") >>= sValue);
+CPPUNIT_ASSERT_EQUAL(OUString("Name"), sValue);
+CPPUNIT_ASSERT(xFiledMaster->getPropertyValue("DataColumnName") >>= 
sValue);
+CPPUNIT_ASSERT_EQUAL(OUString("Name"), sValue);
+CPPUNIT_ASSERT(xFiledMaster->getPropertyValue("InstanceName") >>= sValue);
+
CPPUNIT_ASSERT_EQUAL(OUString("com.sun.star.text.fieldmaster.DataBase.Name"), 
sValue);
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/qa/extras/ww8export/data/mailmerge.doc 
b/sw/qa/extras/ww8export/data/mailmerge.doc
new file mode 100644
index ..6ed882769ebb
Binary files /dev/null and b/sw/qa/extras/ww8export/data/mailmerge.doc differ
diff --git a/sw/qa/extras/ww8export/ww8export2.cxx 
b/sw/qa/extras/ww8export/ww8export2.cxx
index 2819fa3569dd..f4761cc6b381 100644
--- a/sw/qa/extras/ww8export/ww8export2.cxx
+++ b/sw/qa/extras/ww8export/ww8export2.cxx
@@ -12,6 +12,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -161,6 +162,32 @@ DECLARE_WW8EXPORT_TEST( testActiveXCheckbox, 
"checkbox_control.odt" )
 
CPPUNIT_ASSERT_EQUAL(text::TextContentAnchorType_AS_CHARACTER,getProperty(xPropertySet2,"AnchorType"));
 }
 
+DECLARE_WW8EXPORT_TEST(testTdf67207_MERGEFIELD, "mailmerge.doc")
+{
+uno::Reference xTextField = getProperty< 
uno::Reference >(getRun(getParagraph(1), 2), "TextField");
+CPPUNIT_ASSERT(xTextField.is());
+uno::Reference xServiceInfo(xTextField, 
uno::UNO_QUERY_THROW);
+uno::Reference xDependent(xTextField, 
uno::UNO_QUERY_THROW);
+
+
CPPUNIT_ASSERT(xServiceInfo->supportsService("com.sun.star.text.TextField.Database"));
+OUString sValue;
+xTextField->getPropertyValue("Content") >>= sValue;
+CPPUNIT_ASSERT_EQUAL(OUString::fromUtf8(u8"«Name»"), sValue);
+
+uno::Reference xFiledMaster = 
xDependent->getTextFieldMaster();
+uno::Reference xFiledMasterServiceInfo(xFiledMaster, 
uno::UNO_QUERY_THROW);
+
+

[Libreoffice-bugs] [Bug 114026] LibreOffice Vanilla does not recognize existing JDK installation

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114026

--- Comment #3 from himajin100...@gmail.com ---
https://wiki.documentfoundation.org/LibreOffice_Vanilla_for_Mac#Limitations

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114023] Insert -> Field -> More Fields, or +, Fields dialog showing incorrect selection listbox contents

2017-11-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114023

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

  1   2   3   >