[Libreoffice-bugs] [Bug 112852] Should unapplying Bold remove the attribute or force text to Regular?
https://bugs.documentfoundation.org/show_bug.cgi?id=112852 Timurchanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=90 ||646 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91368] UI: Styles and Formatting Performance
https://bugs.documentfoundation.org/show_bug.cgi?id=91368 Timurchanged: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=90 | |646 | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90646] Improving the "Style & Formatting" sidebar tab
https://bugs.documentfoundation.org/show_bug.cgi?id=90646 Timurchanged: What|Removed |Added See Also|https://bugs.documentfounda |https://bugs.documentfounda |tion.org/show_bug.cgi?id=86 |tion.org/show_bug.cgi?id=11 |905,|2852 |https://bugs.documentfounda | |tion.org/show_bug.cgi?id=91 | |368 | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86905] EDITING outline level on non-heading paragraphs does not respect setting in Paragraph > Outline and Numbering > Outline level..
https://bugs.documentfoundation.org/show_bug.cgi?id=86905 Timurchanged: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=90 | |646 | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: wsd/Storage.cpp
wsd/Storage.cpp |1 + 1 file changed, 1 insertion(+) New commits: commit 0547507b671e14b550e2f782cc993ef15010a023 Author: Pranav KantDate: Thu Jan 18 20:50:35 2018 +0530 wsd: Fix incorrect file size reported Close/flush the file after copying into it so that we can calculate the exact filesize later on. Change-Id: I30aca9d0ac3702394a4465c30c61954a726eec39 diff --git a/wsd/Storage.cpp b/wsd/Storage.cpp index d5c8db6b..1227c7fe 100644 --- a/wsd/Storage.cpp +++ b/wsd/Storage.cpp @@ -638,6 +638,7 @@ std::string WopiStorage::loadStorageFileToLocal(const Authorization& auth) std::copy(std::istreambuf_iterator(rs), std::istreambuf_iterator(), std::ostreambuf_iterator(ofs)); +ofs.close(); LOG_INF("WOPI::GetFile downloaded " << getFileSize(_jailedFilePath) << " bytes from [" << uriObject.toString() << "] -> " << _jailedFilePath << " in " << diff.count() << "s"); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: basctl/source
basctl/source/basicide/basobj3.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f867ead158730727e5eff0917a037ca0051d9df9 Author: Stephan BergmannDate: Thu Jan 18 17:33:00 2018 +0100 Fix callback function type ...that got broken with c394363c84064c041391627602665ea1fa74db60 "loplugin:constparams in basctl", causing -fsanitize=function to complain: > sfx2/source/appl/app.cxx:452:28: runtime error: call to function basicide_handle_basic_error through pointer to incorrect function type 'long (*)(void *)' > basctl/source/basicide/basobj3.cxx:48: note: basicide_handle_basic_error defined here > #0 0x7ff6340234aa in SfxApplication::GlobalBasicErrorHdl_Impl(SfxApplication*, StarBASIC*) sfx2/source/appl/app.cxx:452:28 > #1 0x7ff63401cbef in SfxApplication::LinkStubGlobalBasicErrorHdl_Impl(void*, StarBASIC*) sfx2/source/appl/app.cxx:434:1 > #2 0x7ff639142148 in Link ::Call(StarBASIC*) const include/tools/link.hxx:84:45 > #3 0x7ff63911f350 in StarBASIC::RTError(ErrCode, rtl::OUString const&, int, int, int) basic/source/classes/sb.cxx:1681:37 > #4 0x7ff63965aafe in SbiInstance::Abort() basic/source/runtime/runtime.cxx:518:16 > #5 0x7ff639664363 in SbiRuntime::Step() basic/source/runtime/runtime.cxx:865:28 > #6 0x7ff6392ec321 in SbModule::Run(SbMethod*) basic/source/classes/sbxmod.cxx:1141:25 [...] Change-Id: I66bd1ca720cebca4fb5fd52d86920de3fc7a604e Reviewed-on: https://gerrit.libreoffice.org/48142 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/basctl/source/basicide/basobj3.cxx b/basctl/source/basicide/basobj3.cxx index 7043bba6110a..246486331538 100644 --- a/basctl/source/basicide/basobj3.cxx +++ b/basctl/source/basicide/basobj3.cxx @@ -44,7 +44,7 @@ using namespace ::com::sun::star::uno; using namespace ::com::sun::star::container; extern "C" { -SAL_DLLPUBLIC_EXPORT long basicide_handle_basic_error( void const * pPtr ) +SAL_DLLPUBLIC_EXPORT long basicide_handle_basic_error( void * pPtr ) { return HandleBasicError( static_cast(pPtr) ); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: bridges/source codemaker/source connectivity/source cppuhelper/source cppu/source idlc/source include/osl include/rtl include/sal include/typelib include/uno io/test sa
bridges/source/cpp_uno/shared/vtablefactory.cxx |8 +++ codemaker/source/codemaker/global.cxx|2 - codemaker/source/cppumaker/cpputype.cxx |8 +++ connectivity/source/drivers/postgresql/pq_connection.cxx |2 - cppu/source/typelib/static_types.cxx |4 +-- cppu/source/typelib/typelib.cxx |4 +-- cppu/source/uno/check.cxx|4 +-- cppuhelper/source/access_control.cxx |4 +-- idlc/source/idlccompile.cxx |8 +++ idlc/source/idlcproduce.cxx |2 - include/osl/module.h |2 - include/osl/process.h|4 +-- include/osl/signal.h |4 +-- include/osl/time.h |4 +-- include/rtl/locale.h |4 +-- include/rtl/string.h |4 +-- include/rtl/ustring.h|4 +-- include/sal/main.h |6 ++--- include/sal/types.h |6 ++--- include/typelib/typedescription.h|4 +-- include/typelib/uik.h|4 +-- include/uno/any2.h |4 +-- include/uno/dispatcher.h |4 +-- include/uno/environment.h|4 +-- include/uno/mapping.h|4 +-- io/test/testcomponent.cxx|2 - sal/rtl/alloc_arena.cxx | 16 +++ sal/rtl/alloc_cache.cxx | 14 ++--- sal/rtl/alloc_impl.hxx |4 +-- sax/test/testcomponent.cxx |4 +-- sc/source/ui/inc/validate.hxx|4 +-- sccomp/source/solver/LpsolveSolver.cxx |2 - stoc/source/implementationregistration/implreg.cxx |2 - stoc/source/security/permissions.cxx |8 +++ sw/source/filter/ww8/ww8struc.hxx|4 +-- testtools/source/performance/ubtest.cxx |4 +-- 36 files changed, 86 insertions(+), 86 deletions(-) New commits: commit 697f01e052ae73e88d7e1a37386f2648d57e12e2 Author: Stephan BergmannDate: Thu Jan 18 16:39:59 2018 +0100 SAL_W32 is just an alias for _WIN32 ...so consistently use the latter instead of the former Change-Id: I144d5e7c472632f93b2258461510346bc85892d9 Reviewed-on: https://gerrit.libreoffice.org/48135 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/bridges/source/cpp_uno/shared/vtablefactory.cxx b/bridges/source/cpp_uno/shared/vtablefactory.cxx index 50419298d87f..56669a258680 100644 --- a/bridges/source/cpp_uno/shared/vtablefactory.cxx +++ b/bridges/source/cpp_uno/shared/vtablefactory.cxx @@ -43,7 +43,7 @@ #include #include #include -#elif defined SAL_W32 +#elif defined _WIN32 #define WIN32_LEAN_AND_MEAN #ifdef _MSC_VER #pragma warning(push,1) // disable warnings within system headers @@ -74,7 +74,7 @@ extern "C" void * allocExec( #else pagesize = sysconf(_SC_PAGESIZE); #endif -#elif defined SAL_W32 +#elif defined _WIN32 SYSTEM_INFO info; GetSystemInfo(); pagesize = info.dwPageSize; @@ -95,7 +95,7 @@ extern "C" void * allocExec( munmap (p, n); p = nullptr; } -#elif defined SAL_W32 +#elif defined _WIN32 p = VirtualAlloc(nullptr, n, MEM_COMMIT, PAGE_EXECUTE_READWRITE); #endif if (p != nullptr) { @@ -109,7 +109,7 @@ extern "C" void freeExec( { #if defined SAL_UNX munmap(address, size); -#elif defined SAL_W32 +#elif defined _WIN32 (void) size; // unused VirtualFree(address, 0, MEM_RELEASE); #endif diff --git a/codemaker/source/codemaker/global.cxx b/codemaker/source/codemaker/global.cxx index 512edab4fff7..daf031d7728d 100644 --- a/codemaker/source/codemaker/global.cxx +++ b/codemaker/source/codemaker/global.cxx @@ -26,7 +26,7 @@ #include #include -#if defined(SAL_W32) +#if defined(_WIN32) # include # include #endif diff --git a/codemaker/source/cppumaker/cpputype.cxx b/codemaker/source/cppumaker/cpputype.cxx index ba84a46b75f4..22711d444126 100644 --- a/codemaker/source/cppumaker/cpputype.cxx +++ b/codemaker/source/cppumaker/cpputype.cxx @@ -1813,7 +1813,7 @@ private: void PlainStructType::dumpDeclaration(FileStream & out) { -out << "\n#ifdef SAL_W32\n# pragma pack(push, 8)\n#endif\n\n" << indent(); +out << "\n#ifdef _WIN32\n# pragma pack(push,
[Libreoffice-commits] core.git: autogen.sh
autogen.sh |5 - 1 file changed, 5 deletions(-) New commits: commit 161af2120f41f34fe562f677907ccfba41f7012a Author: Stephan BergmannDate: Thu Jan 18 15:33:44 2018 +0100 Don't set autogen.sh KEY=VALUE arguments as environment variables > Jan 18 15:18:25 tml__, do you remember anything about > e3a07b8a6cc03b6d5063e4da5a474d8c91a84b0a ? looks odd to add configure > KEY=VALUE args to the environment > Jan 18 15:18:27 core - Include environment variables already in > autogen.sh's environment - > http://cgit.freedesktop.org/libreoffice/core/commit/?id=e3a07b8a6cc03b6d5063e4da5a474d8c91a84b0a > Jan 18 15:22:54 sberg: not really any recollection, sorry > Jan 18 15:23:09 sberg: are you sure this isn't what makes it possible > to have CC=clang etc in autogen.input? > Jan 18 15:24:07 or maybe this is related to propagating stuff when > make re-runs autogen.sh? > Jan 18 15:24:28 tml__, configure already takes care itself of its > KEY=VALUE command line arguments > Jan 18 15:24:36 sad that I didn't write a better commit message > Jan 18 15:24:55 feel free to revert it, and see if anybody notices;) > Jan 18 15:25:04 * cloph_away used it for CC/CXX and devtools repo > Jan 18 15:26:11 cloph_away: yes, but I think sberg says that should > work anyway, even without that commit The only reading from ENV after that code in autogen.sh (both today and at the time of e3a07b8a6cc03b6d5063e4da5a474d8c91a84b0a) is the if (defined $ENV{NOCONFIGURE}) { print "Skipping configure process."; check, which would now no longer work if you pass NOCONFIGURE= as an argument to autogen.sh (in autogen.input or on the command line) instead of as an environment variable. Change-Id: If50639978190d219b063ff39f81e29d2054c0443 Reviewed-on: https://gerrit.libreoffice.org/48133 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/autogen.sh b/autogen.sh index 6af2cf71da80..20976ce66d3f 100755 --- a/autogen.sh +++ b/autogen.sh @@ -257,11 +257,6 @@ for my $arg (@cmdline_args) { push @args, $arg; } } -for my $arg (@args) { -if ($arg =~ /^([A-Z]+)=(.*)/) { -$ENV{$1} = $2; -} -} if (defined $ENV{NOCONFIGURE}) { print "Skipping configure process."; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: autogen.sh
autogen.sh |1 + 1 file changed, 1 insertion(+) New commits: commit 2f9ee54cb7fa8767e43515bde1969f74be2533a8 Author: Stephan BergmannDate: Thu Jan 18 15:25:58 2018 +0100 Also strip leading whitespace from autogen.input lines ...which allows to align --enable/--disable switches on the part being en-/dis- abled, as in > --disable-assert-always-abort > --enable-avahi > --enable-breakpad > --enable-build-unowinreg > --disable-ccache for better readability Change-Id: I490402c74ea1ee535deee6ef79274b588b614820 Reviewed-on: https://gerrit.libreoffice.org/48130 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/autogen.sh b/autogen.sh index a4bab811a36b..6af2cf71da80 100755 --- a/autogen.sh +++ b/autogen.sh @@ -77,6 +77,7 @@ sub read_args($) open ($fh, $file) || die "can't open file: $file"; while (<$fh>) { chomp(); +s/^\s+//; s/\s+$//; # migrate from the old system if ( substr($_, 0, 1) eq "'" ) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115031] Installs but Will Only Run in Safe-Mode New PC Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=115031 --- Comment #5 from Samuel Mehrbrodt (CIB)--- (In reply to TeamProBono from comment #4) > Thank you, but I fixed the problem with the advice given above by Xisco > Fauli. Great! Can you please give us your hardware details so we can blacklist the device you use? See https://wiki.documentfoundation.org/OpenGL#Get_your_computer.27s_OpenGL_information -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-0-0' - sc/source
sc/source/core/data/table3.cxx | 75 + 1 file changed, 39 insertions(+), 36 deletions(-) New commits: commit 7c0e7e7fbcd90f739b9b8534aa19b39bf1a15c7b Author: Ahmed GHANMIDate: Thu Jan 18 10:40:50 2018 +0100 tdf#114720: Fix subtotal crash A condition was added in order to not make subtotal functions if category was not checked. Change-Id: I56f11330fa16bf0d3199576ce2545cbc8d13e864 Reviewed-on: https://gerrit.libreoffice.org/48099 Reviewed-by: Eike Rathke Tested-by: Eike Rathke (cherry picked from commit 6cb011cc644d8f2e189ce5b8e5de7ff297969840) Reviewed-on: https://gerrit.libreoffice.org/48163 Reviewed-by: Mike Kaganski Reviewed-by: Andras Timar Tested-by: Andras Timar diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx index b973dd8fd6bc..f4b63f4f1eaf 100644 --- a/sc/source/core/data/table3.cxx +++ b/sc/source/core/data/table3.cxx @@ -2139,48 +2139,51 @@ bool ScTable::DoSubTotals( ScSubTotalParam& rParam ) } } -// generate global total -SCROW nGlobalStartRow = aRowVector[0].nSubStartRow; -SCROW nGlobalStartFunc = aRowVector[0].nFuncStart; -SCROW nGlobalEndRow = 0; -SCROW nGlobalEndFunc = 0; -for ( ::std::vector< RowEntry >::const_iterator iEntry( aRowVector.begin()); -iEntry != aRowVector.end(); ++iEntry) -{ -nGlobalEndRow = (nGlobalEndRow < iEntry->nDestRow) ? iEntry->nDestRow : nGlobalEndRow; -nGlobalEndFunc = (nGlobalEndFunc < iEntry->nFuncEnd) ? iEntry->nFuncEnd : nGlobalEndRow; -} - -for (sal_uInt16 nLevel=0; nLevel 0) { -// increment end row -nGlobalEndRow++; +// generate global total +SCROW nGlobalStartRow = aRowVector[0].nSubStartRow; +SCROW nGlobalStartFunc = aRowVector[0].nFuncStart; +SCROW nGlobalEndRow = 0; +SCROW nGlobalEndFunc = 0; +for (::std::vector< RowEntry >::const_iterator iEntry(aRowVector.begin()); + iEntry != aRowVector.end(); ++iEntry) +{ +nGlobalEndRow = (nGlobalEndRow < iEntry->nDestRow) ? iEntry->nDestRow : nGlobalEndRow; +nGlobalEndFunc = (nGlobalEndFunc < iEntry->nFuncEnd) ? iEntry->nFuncEnd : nGlobalEndRow; +} -// add row entry for formula -aRowEntry.nGroupNo = nLevelCount-nLevel-1; -aRowEntry.nSubStartRow = nGlobalStartRow; -aRowEntry.nFuncStart = nGlobalStartFunc; -aRowEntry.nDestRow = nGlobalEndRow; -aRowEntry.nFuncEnd = nGlobalEndFunc; +for (sal_uInt16 nLevel = 0; nLevel InsertRow( 0, nTab, MAXCOL, nTab, aRowEntry.nDestRow, 1 ); +// increment row +nGlobalEndFunc++; -if (bSpaceLeft) -{ -aRowVector.push_back( aRowEntry ); -nEndRow++; -DBShowRow(aRowEntry.nDestRow, true); +bSpaceLeft = pDocument->InsertRow(0, nTab, MAXCOL, nTab, aRowEntry.nDestRow, 1); -// insert label -ScSubTotalFunc* eResFunc = rParam.pFunctions[aRowEntry.nGroupNo]; -OUString label = ScGlobal::GetRscString( STR_TABLE_GRAND ); -label += " "; -label += ScGlobal::GetRscString(lcl_GetSubTotalStrId(eResFunc[0])); -SetString( nGroupCol[aRowEntry.nGroupNo], aRowEntry.nDestRow, nTab, label ); -ApplyStyle( nGroupCol[aRowEntry.nGroupNo], aRowEntry.nDestRow, pStyle ); +if (bSpaceLeft) +{ +aRowVector.push_back(aRowEntry); +nEndRow++; +DBShowRow(aRowEntry.nDestRow, true); + +// insert label +ScSubTotalFunc* eResFunc = rParam.pFunctions[aRowEntry.nGroupNo]; +OUString label = ScGlobal::GetRscString(STR_TABLE_GRAND); +label += " "; +label += ScGlobal::GetRscString(lcl_GetSubTotalStrId(eResFunc[0])); +SetString(nGroupCol[aRowEntry.nGroupNo], aRowEntry.nDestRow, nTab, label); +ApplyStyle(nGroupCol[aRowEntry.nGroupNo], aRowEntry.nDestRow, pStyle); +} } } ___ Libreoffice-commits mailing list
[Libreoffice-commits] core.git: 17 commits - basic/source cppcanvas/source drawinglayer/source hwpfilter/source idl/inc idl/source include/basic include/drawinglayer include/editeng sfx2/source
basic/source/classes/sb.cxx | 20 ++-- basic/source/classes/sbintern.cxx |6 - basic/source/classes/sbunoobj.cxx |4 basic/source/classes/sbxmod.cxx | 42 - basic/source/comp/codegen.cxx | 10 -- basic/source/inc/sbintern.hxx |6 - basic/source/inc/sbunoobj.hxx |2 basic/source/inc/stdobj.hxx |2 basic/source/runtime/methods.cxx|7 - basic/source/runtime/runtime.cxx|7 - basic/source/runtime/stdobj.cxx |8 - basic/source/sbx/sbxvar.cxx | 19 +--- cppcanvas/source/mtfrenderer/emfpbrush.cxx | 43 ++ cppcanvas/source/mtfrenderer/emfpbrush.hxx | 10 +- cppcanvas/source/mtfrenderer/emfppen.cxx|6 - cppcanvas/source/mtfrenderer/emfppen.hxx|4 cppcanvas/source/mtfrenderer/emfpregion.cxx |6 - cppcanvas/source/mtfrenderer/emfpregion.hxx |2 drawinglayer/source/primitive2d/svggradientprimitive2d.cxx |7 - drawinglayer/source/processor3d/zbufferprocessor3d.cxx | 13 +-- drawinglayer/source/texture/texture3d.cxx | 15 +-- drawinglayer/source/tools/emfpbrush.cxx | 51 ++-- drawinglayer/source/tools/emfpbrush.hxx | 10 +- drawinglayer/source/tools/emfppen.cxx |6 - drawinglayer/source/tools/emfppen.hxx |4 hwpfilter/source/drawdef.h |5 - hwpfilter/source/drawing.h | 10 -- hwpfilter/source/hwpfile.cxx| 11 +- hwpfilter/source/hwpfile.h |4 hwpfilter/source/hwpreader.cxx | 14 +-- idl/inc/database.hxx|2 idl/inc/globals.hxx |7 - idl/source/prj/command.cxx |4 idl/source/prj/database.cxx |4 idl/source/prj/globals.cxx |2 include/basic/sbmod.hxx |7 - include/basic/sbxvar.hxx|4 include/drawinglayer/primitive2d/svggradientprimitive2d.hxx |2 include/drawinglayer/processor3d/zbufferprocessor3d.hxx |5 - include/drawinglayer/texture/texture3d.hxx |6 - include/editeng/outliner.hxx| 20 +--- sfx2/source/appl/appdata.cxx|4 sfx2/source/inc/appdata.hxx |5 - 43 files changed, 167 insertions(+), 259 deletions(-) New commits: commit 74403516c94a49d8878eb5c0224e6994f204cd2a Author: Noel GrandinDate: Tue Jan 16 15:09:56 2018 +0200 loplugin:useuniqueptr in EditFieldInfo Change-Id: I8c4cc4ab212409bce54b64d59d07d77a924ed11c diff --git a/include/editeng/outliner.hxx b/include/editeng/outliner.hxx index f6bba5cc89b6..2c2ca5f1285f 100644 --- a/include/editeng/outliner.hxx +++ b/include/editeng/outliner.hxx @@ -500,8 +500,8 @@ private: Outliner* pOutliner; const SvxFieldItem& rFldItem; -Color* pTxtColor; -Color* pFldColor; +std::unique_ptr pTxtColor; +std::unique_ptr pFldColor; OUStringaRepresentation; @@ -518,28 +518,22 @@ public: { pOutliner = pOutl; nPara = nPa; nPos = nPo; -pTxtColor = nullptr; pFldColor = nullptr; mpSdrPage = nullptr; } -~EditFieldInfo() -{ -delete pTxtColor; -delete pFldColor; -} Outliner* GetOutliner() const { return pOutliner; } const SvxFieldItem& GetField() const { return rFldItem; } -Color* GetTextColor() const { return pTxtColor; } +Color* GetTextColor() const { return pTxtColor.get(); } voidSetTextColor( const Color& rColor ) -{ delete pTxtColor; pTxtColor = new Color( rColor ); } +{ pTxtColor.reset( new Color( rColor ) ); } -Color* GetFieldColor() const { return pFldColor; } +Color* GetFieldColor() const { return pFldColor.get(); } voidSetFieldColor( const Color& rColor ) -{ delete pFldColor;
[Libreoffice-bugs] [Bug 115068] FILESAVE EXPORT as HTML : bad positioned images in HTML export
https://bugs.documentfoundation.org/show_bug.cgi?id=115068 --- Comment #6 from Xavier Van Wijmeersch--- With File => export=> xhtml i have the same results like you explain in comment 3, i have also the wrong results, no images at all, only text But with File => save as => html document then i have the correct results, see the zip file; i did forgot to explain properly Best regards -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55004] backup copy fails when using share / samba
https://bugs.documentfoundation.org/show_bug.cgi?id=55004 tomraymond...@gmail.com changed: What|Removed |Added Hardware|All |x86 (IA32) OS|All |Windows (All) --- Comment #35 from tomraymond...@gmail.com --- Getting same bug on Windows 10. LIBREOFFICE 5.4.4.2 Saving the document Error creating object could not create backup copy Received this message after multiple changes and saves of the same document. Trying to save backup on a DVD drive. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114272] Some Asian characters are garbled with western fonts.
https://bugs.documentfoundation.org/show_bug.cgi?id=114272 --- Comment #14 from Kamei--- (In reply to Alex Thurgood from comment #13) Thank you so much for testing!! Now the font I installed additionally is not the problem. And I think bug106148 is very similar to this bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115076] Calc crashs when a form control is added
https://bugs.documentfoundation.org/show_bug.cgi?id=115076 yelloffchanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115076] Calc crashs when a form control is added
https://bugs.documentfoundation.org/show_bug.cgi?id=115076 --- Comment #5 from yelloff--- (In reply to Chavdar from comment #1) > Unconfirmed > > No crash for me. Have you tried it in Safe Mode? > > Version: 6.0.0.2 (x64) > Build ID: 06b618bb6f431d27fd2def25aa19c833e29b61cd > CPU threads: 4; OS: Windows 10.0; UI render: default; > Locale: bg-BG (bg_BG); Calc: group No crash in Safe Mode. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115102] New: Stack Characters while Inputting Data on Cell Using Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=115102 Bug ID: 115102 Summary: Stack Characters while Inputting Data on Cell Using Calc Product: LibreOffice Version: 5.4.1.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sabaria.jho...@gmail.com Created attachment 139206 --> https://bugs.documentfoundation.org/attachment.cgi?id=139206=edit The image shows the stacking characters while entering data. While entering data on each cell on LO Calc, the characters seem to pile over the other and appear to be unreadable.This happens when the application shows you the suggested characters or data, also when you edit an entry on each cell. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115038] Umlaute (mutation) will be shown wrong in some objects when you type them first
https://bugs.documentfoundation.org/show_bug.cgi?id=115038 Thomas Lendochanged: What|Removed |Added Status|NEEDINFO|NEW CC||thomas.le...@gmail.com Blocks||108741, 71732 --- Comment #9 from Thomas Lendo --- Set to NEW as I can confirm the bug since I installed TrueType font Wingings. Interesting is, that I couldn't reproduce this bug in Draw and Impress until I installed Wingings. After that (with deinstalled or reinstalled font) I was able to reproduce it. Weird. Another interesting thing is that Windings must(?) only be installed, but Liberation Sans is still the default font in the buggy shapes. Version: 6.1.0.0.alpha0+ Build ID: acb43c0b8efbfb841e7b40603d75a8432eb21f21 CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-01-09_01:20:44 Locale: de-DE (de_DE.UTF-8); Calc: group threaded Ubuntu 16.04 LTS 64 bit Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=71732 [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO https://bugs.documentfoundation.org/show_bug.cgi?id=108741 [Bug 108741] [META] Shapes bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115076] Calc crashs when a form control is added
https://bugs.documentfoundation.org/show_bug.cgi?id=115076 --- Comment #6 from yelloff--- (In reply to Xisco Faulí from comment #3) > I can't reproduce it in > > Versión: 6.0.0.2 > Id. de compilación: 06b618bb6f431d27fd2def25aa19c833e29b61cd > Subproc. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; > Configuración regional: es-ES (es_ES); Calc: group > > To be certain the reported issue is not > related to corruption in the user profile, could you please reset your > Libreoffice profile ( https://wiki.documentfoundation.org/UserProfile ) and > re-test? > > I have set the bug's status to 'NEEDINFO'. Please change it back to > 'UNCONFIRMED' if the issue is still present After reseting the user profile everything is fine. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115078] Automatically insert a decimal point like in Excel 2016
https://bugs.documentfoundation.org/show_bug.cgi?id=115078 Thomas Lendochanged: What|Removed |Added Keywords||needsUXEval CC||c...@nouenoff.nl, ||tietze.he...@gmail.com, ||vstuart.fo...@utsa.edu Hardware|x86 (IA32) |All Blocks||107575 OS|Windows (All) |All --- Comment #1 from Thomas Lendo --- Nice concept, thanks Daniel. But I don't know if LibreOffice should allow such behavior. It's only useful if you insert more numbers with decimal places than without. In Tools > Options > Calc > Calculate there is a setting "Limit decimals for general number format" to fix a maximum number of decimal places. A new setting could be introduced similar to the setting in Microsoft Excel [1] with wording "Automatically insert decimals for general number format" with an identical number combobox. Adding needsUXEval to get some input from the design team. [1] https://fud.community.services.support.microsoft.com/Fud/FileDownloadHandler.ashx?fid=bfc35f10-67a2-4e7e-82a4-7847bf3092b6 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107575 [Bug 107575] [META] Number format bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85184] [META] Color picker toolbar, dialog and sidebar drop-down widget bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=85184 Bug 85184 depends on bug 115057, which changed state. Bug 115057 Summary: Color picker widget border missing when opened in dialog https://bugs.documentfoundation.org/show_bug.cgi?id=115057 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115103] Date field is formatted as number when mail merge is run on DOC(X) files
https://bugs.documentfoundation.org/show_bug.cgi?id=115103 --- Comment #1 from Aron Budea--- Created attachment 139208 --> https://bugs.documentfoundation.org/attachment.cgi?id=139208=edit Sample starting DOC -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113854] Cross-reference "above" and "below" in Swedish should trade places
https://bugs.documentfoundation.org/show_bug.cgi?id=113854 --- Comment #6 from CK--- Interesting it has been around so long. Just realised now: when I installed 5.4.4.2 as flatpack, maybe it just relied on the existing language pack I had though? Haven't been able to test on a clean system. However, if it currently reads as as cited, then certainly it explains the mixup. nedan ovan This would indeed be wrong way around. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108741 Thomas Lendochanged: What|Removed |Added Depends on||115038 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115038 [Bug 115038] Umlaute (mutation) will be shown wrong in some objects when you type them first -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104800] Windows 10 "Choose default apps" for Photo Viewer -- LO Draw module is available but displays only icon with no program label
https://bugs.documentfoundation.org/show_bug.cgi?id=104800 Mike Kaganskichanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #5 from Mike Kaganski --- Cannot reproduce with Version: 6.0.0.2 (x64) Build ID: 06b618bb6f431d27fd2def25aa19c833e29b61cd CPU threads: 4; OS: Windows 10.0; UI render: default; Locale: ru-RU (ru_RU); Calc: (see also comment 3) Closing WFM -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115103] Date field is formatted as number when mail merge is run on DOC(X) files
https://bugs.documentfoundation.org/show_bug.cgi?id=115103 --- Comment #2 from Aron Budea--- Created attachment 139209 --> https://bugs.documentfoundation.org/attachment.cgi?id=139209=edit Sample XLS to be used as an address list -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115003] System requirements web page should mention Java bitness requirements for Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=115003 Samuel Mehrbrodt (CIB)changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||s.mehrbr...@gmail.com Resolution|--- |NOTOURBUG --- Comment #1 from Samuel Mehrbrodt (CIB) --- Please report this at https://redmine.documentfoundation.org/projects/infrastructure/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/dockwin.hxx |2 include/vcl/settings.hxx |2 vcl/source/app/settings.cxx | 10 - vcl/source/window/brdwin.cxx | 26 +++- vcl/source/window/dockmgr.cxx | 226 -- 5 files changed, 42 insertions(+), 224 deletions(-) New commits: commit c5ecb2990123d666dde0d66ce38dc3b9f03802c4 Author: Maxim MonastirskyDate: Thu Jan 18 00:49:17 2018 +0200 Move toolbars to the border window tearoff mechanism and remove the one from ImplPopupFloatWin. Implemented using the FloatWinTitleType::TearOff case, which was unused otherwise. Change-Id: I82a86e5f5897ce1f2e76a2404bb382cbc007700c Reviewed-on: https://gerrit.libreoffice.org/48095 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky diff --git a/include/vcl/dockwin.hxx b/include/vcl/dockwin.hxx index 1378e07c1911..af10bceef5d5 100644 --- a/include/vcl/dockwin.hxx +++ b/include/vcl/dockwin.hxx @@ -112,7 +112,7 @@ private: DECL_LINK( PopupModeEnd, FloatingWindow*, void ); voidImplEnableStartDocking() { mbStartDockingEnabled = true; } boolImplStartDockingEnabled() const { return mbStartDockingEnabled; } -voidImplPreparePopupMode( FloatWinPopupFlags nFlags ); +voidImplPreparePopupMode(); public: ImplDockingWindowWrapper( const vcl::Window *pWindow ); diff --git a/include/vcl/settings.hxx b/include/vcl/settings.hxx index 9b6ab00f2029..6b061336f61d 100644 --- a/include/vcl/settings.hxx +++ b/include/vcl/settings.hxx @@ -483,8 +483,6 @@ public: voidSetFloatTitleHeight( long nSize ); longGetFloatTitleHeight() const; -longGetTearOffTitleHeight() const; - voidSetScrollBarSize( long nSize ); longGetScrollBarSize() const; diff --git a/vcl/source/app/settings.cxx b/vcl/source/app/settings.cxx index 97723e7a21b5..5429c20a400c 100644 --- a/vcl/source/app/settings.cxx +++ b/vcl/source/app/settings.cxx @@ -156,7 +156,6 @@ struct ImplStyleData longmnBorderSize; longmnTitleHeight; longmnFloatTitleHeight; -longmnTearOffTitleHeight; longmnScrollBarSize; longmnSplitSize; longmnSpinSize; @@ -632,7 +631,6 @@ ImplStyleData::ImplStyleData( const ImplStyleData& rData ) : mnBorderSize= rData.mnBorderSize; mnTitleHeight = rData.mnTitleHeight; mnFloatTitleHeight = rData.mnFloatTitleHeight; -mnTearOffTitleHeight= rData.mnTearOffTitleHeight; mnScrollBarSize = rData.mnScrollBarSize; mnMinThumbSize = rData.mnMinThumbSize; mnSplitSize = rData.mnSplitSize; @@ -752,7 +750,6 @@ void ImplStyleData::SetStandardStyles() mnBorderSize= 1; mnTitleHeight = 18; mnFloatTitleHeight = 13; -mnTearOffTitleHeight= 8; mbHighContrast = false; mbUseSystemUIFonts = true; mnUseFlatBorders= false; @@ -1755,12 +1752,6 @@ StyleSettings::GetFloatTitleHeight() const return mxData->mnFloatTitleHeight; } -long -StyleSettings::GetTearOffTitleHeight() const -{ -return mxData->mnTearOffTitleHeight; -} - void StyleSettings::SetScrollBarSize( long nSize ) { @@ -2286,7 +2277,6 @@ bool StyleSettings::operator ==( const StyleSettings& rSet ) const (mxData->mnBorderSize == rSet.mxData->mnBorderSize) && (mxData->mnTitleHeight == rSet.mxData->mnTitleHeight) && (mxData->mnFloatTitleHeight== rSet.mxData->mnFloatTitleHeight) && - (mxData->mnTearOffTitleHeight == rSet.mxData->mnTearOffTitleHeight) && (mxData->mnScrollBarSize == rSet.mxData->mnScrollBarSize) && (mxData->mnMinThumbSize== rSet.mxData->mnMinThumbSize) && (mxData->mnSplitSize == rSet.mxData->mnSplitSize) && diff --git a/vcl/source/window/brdwin.cxx b/vcl/source/window/brdwin.cxx index 5d8b14c7cde9..58914dd83fdc 100644 --- a/vcl/source/window/brdwin.cxx +++ b/vcl/source/window/brdwin.cxx @@ -36,6 +36,7 @@ #include #include #include +#include using namespace ::com::sun::star::uno; @@ -153,7 +154,7 @@ void ImplBorderWindowView::ImplInitTitle(ImplBorderFrameData* pData) { const StyleSettings& rStyleSettings = pData->mpOutDev->GetSettings().GetStyleSettings(); if (pData->mnTitleType ==
[Libreoffice-bugs] [Bug 115076] Calc crashs when a form control is added
https://bugs.documentfoundation.org/show_bug.cgi?id=115076 --- Comment #4 from yelloff--- (In reply to Aron Budea from comment #2) > No repro here either with 6.0.0.2 / Windows 7. > > I see "(Web)" in the title, how do you get in that state? Don't know how I got there. But it crashs anyway. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55004] backup copy fails when using share / samba
https://bugs.documentfoundation.org/show_bug.cgi?id=55004 Aron Budeachanged: What|Removed |Added Hardware|x86 (IA32) |All OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115078] Automatically insert a decimal point like in Excel 2016
https://bugs.documentfoundation.org/show_bug.cgi?id=115078 V Stuart Footechanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||er...@redhat.com, ||libreoff...@kohei.us Ever confirmed|0 |1 --- Comment #2 from V Stuart Foote --- Not a display setting, that would make no sense. Rather, this would have to be an auto-format/auto-correct action. That is--as an aid to doing the _integer_ data entry; and to override "normal" numeric input. Would expect that once entered, and a decimal place assigned, the number _must_ be handled as a numeric value and to take the number formatting otherwise applied to the cells. Also, assume the auto-format/auto-correction would be activated against a selected column/row. But alternatively toggled globally to parse _any_ integer numeric data input. And, what would happen if while the input mode is set against a cell (by row/column), one enters a floating point number with decimal? Assume it would revert to normal numeric input handling. Finally, would the decimal auto-format/auto-correct position be applied counting from the start or from the end of input--or should that be settable. Again this would be a data input formatting function--like using a "'" to set numeric input to be text. In that context could see some utility. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81642] PRINTING: problem with printing on sheets of other than A4 format
https://bugs.documentfoundation.org/show_bug.cgi?id=81642 --- Comment #7 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115031] Installs but Will Only Run in Safe-Mode New PC Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=115031 teamprob...@sbcglobal.net changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #4 from teamprob...@sbcglobal.net --- Thank you, but I fixed the problem with the advice given above by Xisco Fauli. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102998] [META] Mail merge bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102998 Aron Budeachanged: What|Removed |Added Depends on||115103 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115103 [Bug 115103] Date field is formatted as number when mail merge is run on DOC(X) files -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3-desktop' - 5 commits - sal/osl sal/rtl svtools/source sw/qa sw/source
sal/osl/unx/file_volume.cxx |9 - sal/rtl/alloc_arena.cxx |7 svtools/source/contnr/treelistbox.cxx |7 +--- sw/qa/extras/uiwriter/data/datasource.ods |binary sw/qa/extras/uiwriter/uiwriter.cxx| 49 ++ sw/source/filter/ww8/ww8atr.cxx | 44 ++ 6 files changed, 108 insertions(+), 8 deletions(-) New commits: commit 1d828cbd4b6f424b0f10f6336afef8aa1b5fd341 Author: Mike KaganskiDate: Wed Jan 17 12:41:41 2018 +0300 tdf#115013: quote columns with spaces and properly escape characters Unit test updated Change-Id: If36c90c0ff372ce4574d2487e6edf2536dbf Reviewed-on: https://gerrit.libreoffice.org/48038 Tested-by: Jenkins Reviewed-by: Mike Kaganski Reviewed-on: https://gerrit.libreoffice.org/48078 Reviewed-by: Aron Budea Tested-by: Aron Budea (cherry picked from commit 2425c5cc08b150c9b1b9a6f542b2f5b46a695b40) diff --git a/sw/qa/extras/uiwriter/data/datasource.ods b/sw/qa/extras/uiwriter/data/datasource.ods index 076659679575..81d78440656e 100644 Binary files a/sw/qa/extras/uiwriter/data/datasource.ods and b/sw/qa/extras/uiwriter/data/datasource.ods differ diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx b/sw/qa/extras/uiwriter/uiwriter.cxx index 6a065e712bea..5c96aacf7a1e 100644 --- a/sw/qa/extras/uiwriter/uiwriter.cxx +++ b/sw/qa/extras/uiwriter/uiwriter.cxx @@ -4647,7 +4647,9 @@ void SwUiWriterTest::testTdf104492() void SwUiWriterTest::testTdf115013() { -//create new writer document + const OUString sColumnName("Name with spaces, \"quotes\" and \\backslashes"); + + //create new writer document SwDoc* pDoc = createDoc(); { @@ -4663,7 +4665,7 @@ void SwUiWriterTest::testTdf115013() SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell(); CPPUNIT_ASSERT(pWrtShell); SwDBFieldType* pFieldType = static_cast (pWrtShell->InsertFieldType( -SwDBFieldType(pDoc, "Name", aDBData))); +SwDBFieldType(pDoc, sColumnName, aDBData))); CPPUNIT_ASSERT(pFieldType); // Insert the field into document @@ -4686,7 +4688,7 @@ void SwUiWriterTest::testTdf115013() CPPUNIT_ASSERT(pField); OUString sColumn = static_cast (pField->GetTyp())->GetColumnName(); // The column name must come correct after round trip -CPPUNIT_ASSERT_EQUAL(OUString("Name"), sColumn); +CPPUNIT_ASSERT_EQUAL(sColumnName, sColumn); } CPPUNIT_TEST_SUITE_REGISTRATION(SwUiWriterTest); diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx index abb637f923a4..7e90c2a27029 100644 --- a/sw/source/filter/ww8/ww8atr.cxx +++ b/sw/source/filter/ww8/ww8atr.cxx @@ -2458,6 +2458,46 @@ void WW8AttributeOutput::WriteExpand( const SwField* pField ) SwWW8Writer::WriteString16( m_rWW8Export.Strm(), sExpand, false ); } +namespace +{ +// Escapes a token string for storing in Word formats. Its import counterpart +// is lcl_ExtractToken in writerfilter/source/dmapper/DomainMapper_Impl.cxx +OUString EscapeToken(const OUString& rCommand) +{ +bool bWasEscaped = false; + +const int nBufferLen = rCommand.getLength()*1.5; +OUStringBuffer sResult(nBufferLen); +sResult.append('"'); // opening quote +for (sal_Int32 i = 0; i < rCommand.getLength(); ++i) +{ +sal_Unicode ch = rCommand[i]; +switch (ch) +{ +case '\\': +case '"': +// Backslashes and doublequotes must be escaped +bWasEscaped = true; +sResult.append('\\'); +break; +case ' ': +// Spaces require quotation +bWasEscaped = true; +break; +} +sResult.append(ch); +} + +if (bWasEscaped) +{ +sResult.append('"'); // closing quote +return sResult.makeStringAndClear(); +} +// No escapement/quotation was required +return rCommand; +} +} + void AttributeOutputBase::TextField( const SwFormatField& rField ) { const SwField* pField = rField.GetField(); @@ -2535,7 +2575,8 @@ void AttributeOutputBase::TextField( const SwFormatField& rField ) break; case RES_DBFLD: { -OUString sStr = FieldString(ww::eMERGEFIELD) + static_cast(pField->GetTyp())->GetColumnName() + " "; +OUString sStr = FieldString(ww::eMERGEFIELD) ++ EscapeToken(static_cast(pField->GetTyp())->GetColumnName()) + " "; GetExport().OutputField(pField, ww::eMERGEFIELD, sStr); } break; commit eb8da99e08ad01f8a6436e8107a6188f4a7f1a7d Author: Mike Kaganski Date: Tue Jan 16 09:40:11 2018 +0300 tdf#115013: write merge field column into docx merge fields
[Libreoffice-bugs] [Bug 105413] Any paragraph style applied to a short text in a document with track changes is lost after saving the document
https://bugs.documentfoundation.org/show_bug.cgi?id=105413 --- Comment #2 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sc/source
sc/source/core/data/table3.cxx | 75 + 1 file changed, 39 insertions(+), 36 deletions(-) New commits: commit a91cd78c443cc2365f4fd6398ea054cb7ef37ca5 Author: Ahmed GHANMIDate: Thu Jan 18 10:40:50 2018 +0100 tdf#114720: Fix subtotal crash A condition was added in order to not make subtotal functions if category was not checked. Change-Id: I56f11330fa16bf0d3199576ce2545cbc8d13e864 Reviewed-on: https://gerrit.libreoffice.org/48099 Reviewed-by: Eike Rathke Tested-by: Eike Rathke (cherry picked from commit 6cb011cc644d8f2e189ce5b8e5de7ff297969840) Reviewed-on: https://gerrit.libreoffice.org/48162 Tested-by: Jenkins diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx index b973dd8fd6bc..f4b63f4f1eaf 100644 --- a/sc/source/core/data/table3.cxx +++ b/sc/source/core/data/table3.cxx @@ -2139,48 +2139,51 @@ bool ScTable::DoSubTotals( ScSubTotalParam& rParam ) } } -// generate global total -SCROW nGlobalStartRow = aRowVector[0].nSubStartRow; -SCROW nGlobalStartFunc = aRowVector[0].nFuncStart; -SCROW nGlobalEndRow = 0; -SCROW nGlobalEndFunc = 0; -for ( ::std::vector< RowEntry >::const_iterator iEntry( aRowVector.begin()); -iEntry != aRowVector.end(); ++iEntry) -{ -nGlobalEndRow = (nGlobalEndRow < iEntry->nDestRow) ? iEntry->nDestRow : nGlobalEndRow; -nGlobalEndFunc = (nGlobalEndFunc < iEntry->nFuncEnd) ? iEntry->nFuncEnd : nGlobalEndRow; -} - -for (sal_uInt16 nLevel=0; nLevel 0) { -// increment end row -nGlobalEndRow++; +// generate global total +SCROW nGlobalStartRow = aRowVector[0].nSubStartRow; +SCROW nGlobalStartFunc = aRowVector[0].nFuncStart; +SCROW nGlobalEndRow = 0; +SCROW nGlobalEndFunc = 0; +for (::std::vector< RowEntry >::const_iterator iEntry(aRowVector.begin()); + iEntry != aRowVector.end(); ++iEntry) +{ +nGlobalEndRow = (nGlobalEndRow < iEntry->nDestRow) ? iEntry->nDestRow : nGlobalEndRow; +nGlobalEndFunc = (nGlobalEndFunc < iEntry->nFuncEnd) ? iEntry->nFuncEnd : nGlobalEndRow; +} -// add row entry for formula -aRowEntry.nGroupNo = nLevelCount-nLevel-1; -aRowEntry.nSubStartRow = nGlobalStartRow; -aRowEntry.nFuncStart = nGlobalStartFunc; -aRowEntry.nDestRow = nGlobalEndRow; -aRowEntry.nFuncEnd = nGlobalEndFunc; +for (sal_uInt16 nLevel = 0; nLevel InsertRow( 0, nTab, MAXCOL, nTab, aRowEntry.nDestRow, 1 ); +// increment row +nGlobalEndFunc++; -if (bSpaceLeft) -{ -aRowVector.push_back( aRowEntry ); -nEndRow++; -DBShowRow(aRowEntry.nDestRow, true); +bSpaceLeft = pDocument->InsertRow(0, nTab, MAXCOL, nTab, aRowEntry.nDestRow, 1); -// insert label -ScSubTotalFunc* eResFunc = rParam.pFunctions[aRowEntry.nGroupNo]; -OUString label = ScGlobal::GetRscString( STR_TABLE_GRAND ); -label += " "; -label += ScGlobal::GetRscString(lcl_GetSubTotalStrId(eResFunc[0])); -SetString( nGroupCol[aRowEntry.nGroupNo], aRowEntry.nDestRow, nTab, label ); -ApplyStyle( nGroupCol[aRowEntry.nGroupNo], aRowEntry.nDestRow, pStyle ); +if (bSpaceLeft) +{ +aRowVector.push_back(aRowEntry); +nEndRow++; +DBShowRow(aRowEntry.nDestRow, true); + +// insert label +ScSubTotalFunc* eResFunc = rParam.pFunctions[aRowEntry.nGroupNo]; +OUString label = ScGlobal::GetRscString(STR_TABLE_GRAND); +label += " "; +label += ScGlobal::GetRscString(lcl_GetSubTotalStrId(eResFunc[0])); +SetString(nGroupCol[aRowEntry.nGroupNo], aRowEntry.nDestRow, nTab, label); +ApplyStyle(nGroupCol[aRowEntry.nGroupNo], aRowEntry.nDestRow, pStyle); +} } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 98076] Form Control in Draw Menu bar
https://bugs.documentfoundation.org/show_bug.cgi?id=98076 Adolfo Jaymechanged: What|Removed |Added Whiteboard||target:6.1.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113005] UI: Draw' s close command is in another position in the File menu than in other components
https://bugs.documentfoundation.org/show_bug.cgi?id=113005 Adolfo Jaymechanged: What|Removed |Added Whiteboard||target:6.1.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115103] Date field is formatted as number when mail merge is run on DOC(X) files
https://bugs.documentfoundation.org/show_bug.cgi?id=115103 Aron Budeachanged: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: common/Log.cpp common/Log.hpp test/UnitAdmin.cpp test/UnitTimeout.cpp wsd/DocumentBroker.cpp wsd/QueueHandler.hpp wsd/Storage.cpp
common/Log.cpp | 42 common/Log.hpp | 20 ++--- test/UnitAdmin.cpp | 71 ++--- test/UnitTimeout.cpp |2 - wsd/DocumentBroker.cpp | 44 +++--- wsd/QueueHandler.hpp | 10 +++--- wsd/Storage.cpp|2 - 7 files changed, 77 insertions(+), 114 deletions(-) New commits: commit c06376cc1d2e3a331e133140fc359f73783cea0e Author: Ashod NakashianDate: Sun Jan 14 20:39:06 2018 -0500 wsd: cleanup logging and remove unused helpers Now all logging is done after checking if the level in question is enabled or not (thanks to the macros LOG_XXX), which saves unnecessary conversions and stringification when said level is disabled. Change-Id: Icde31e067f60269563896f04f8b0d65643720766 Reviewed-on: https://gerrit.libreoffice.org/47885 Reviewed-by: Michael Meeks Tested-by: Michael Meeks diff --git a/common/Log.cpp b/common/Log.cpp index 5a4f121f..ac05d2cc 100644 --- a/common/Log.cpp +++ b/common/Log.cpp @@ -182,53 +182,13 @@ namespace Log } oss << " Log level is [" << logger.getLevel() << "]."; -info(oss.str()); +LOG_INF(oss.str()); } Poco::Logger& logger() { return Poco::Logger::get(Source.inited ? Source.name : std::string()); } - -void trace(const std::string& msg) -{ -LOG_TRC(msg); -} - -void debug(const std::string& msg) -{ -LOG_DBG(msg); -} - -void info(const std::string& msg) -{ -LOG_INF(msg); -} - -void warn(const std::string& msg) -{ -LOG_WRN(msg); -} - -void error(const std::string& msg) -{ -LOG_ERR(msg); -} - -void syserror(const std::string& msg) -{ -LOG_SYS(msg); -} - -void fatal(const std::string& msg) -{ -LOG_FTL(msg); -} - -void sysfatal(const std::string& msg) -{ -LOG_SFL(msg); -} } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/common/Log.hpp b/common/Log.hpp index 0be4983f..a3e4a9ae 100644 --- a/common/Log.hpp +++ b/common/Log.hpp @@ -22,6 +22,13 @@ #include #include +inline std::ostream& operator<< (std::ostream& os, const Poco::Timestamp& ts) +{ +os << Poco::DateTimeFormatter::format(Poco::DateTime(ts), + Poco::DateTimeFormat::ISO8601_FRAC_FORMAT); +return os; +} + namespace Log { void initialize(const std::string& name, @@ -33,15 +40,6 @@ namespace Log char* prefix(char* buffer, const char* level, bool sigSafe); -void trace(const std::string& msg); -void debug(const std::string& msg); -void info(const std::string& msg); -void warn(const std::string& msg); -void error(const std::string& msg); -void syserror(const std::string& msg); -void fatal(const std::string& msg); -void sysfatal(const std::string& msg); - inline bool traceEnabled() { return logger().trace(); } inline bool debugEnabled() { return logger().debug(); } inline bool infoEnabled() { return logger().information(); } @@ -177,8 +175,8 @@ namespace Log { if (lhs.enabled()) { -lhs._stream << Poco::DateTimeFormatter::format(Poco::DateTime(rhs), - Poco::DateTimeFormat::ISO8601_FRAC_FORMAT); +lhs._stream << Poco::DateTimeFormatter::format(Poco::DateTime(rhs), + Poco::DateTimeFormat::ISO8601_FRAC_FORMAT); } return lhs; diff --git a/test/UnitAdmin.cpp b/test/UnitAdmin.cpp index cbead413..acc058e4 100644 --- a/test/UnitAdmin.cpp +++ b/test/UnitAdmin.cpp @@ -79,7 +79,7 @@ private: if (response.getStatus() == HTTPResponse::HTTP_UNAUTHORIZED) res = TestResult::Ok; -Log::info(std::string("testIncorrectPassword: ") + (res == TestResult::Ok ? "OK" : "FAIL")); +LOG_INF("testIncorrectPassword: " << (res == TestResult::Ok ? "OK" : "FAIL")); return res; } @@ -117,10 +117,10 @@ private: } else { -Log::info("testCorrectPassword: Invalid cookie properties"); +LOG_INF("testCorrectPassword: Invalid cookie properties"); } -Log::info(std::string("testCorrectPassword: ") + (res == TestResult::Ok ? "OK" : "FAIL")); +LOG_INF("testCorrectPassword: " << (res == TestResult::Ok ? "OK" : "FAIL")); return res; } @@ -138,7 +138,7 @@ private: _adminWs->sendFrame(testMessage.data(), testMessage.size()); if (_messageReceivedCV.wait_for(lock, std::chrono::milliseconds(_messageTimeoutMilliSeconds)) == std::cv_status::timeout) { -
[Libreoffice-bugs] [Bug 115063] Can not start Libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=115063 Samuel Mehrbrodt (CIB)changed: What|Removed |Added CC||s.mehrbr...@gmail.com --- Comment #1 from Samuel Mehrbrodt (CIB) --- Try starting in safe mode: libreoffice --safe-mode -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92969] UI: right-click in "Options/Paths" to open folder in file manager
https://bugs.documentfoundation.org/show_bug.cgi?id=92969 Manuj Vashistchanged: What|Removed |Added Assignee|libreoffice-b...@lists.free |manujvash...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115031] Installs but Will Only Run in Safe-Mode New PC Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=115031 Adolfo Jaymechanged: What|Removed |Added Resolution|FIXED |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 Thomas Lendochanged: What|Removed |Added Depends on||115081 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115081 [Bug 115081] Data | Validity restriction can be violated by coping value into the field -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105537] [META] Assertion failed crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=105537 Aron Budeachanged: What|Removed |Added Depends on||115100 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115100 [Bug 115100] Assertion failed, if I set vertical align for gluepoint -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93635] FILEOPEN: Embedded Word file slowly loaded and incorrectly scaled
https://bugs.documentfoundation.org/show_bug.cgi?id=93635 --- Comment #10 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109518] notebookbar does not render rightly at 1366 * 768 resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=109518 daved3...@gmail.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/ui/tabledesign/TableController.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4e035a609edb3d8435456e1b9a5fed279821f064 Author: Julien NabetDate: Thu Jan 18 12:43:45 2018 +0100 Fix reg from 4cb3e1c05a16af3dad03db9d789dc7ea061b33cf Change-Id: I853a949e68d192c48a90321a8b3b75a5d443638b Reviewed-on: https://gerrit.libreoffice.org/48111 Reviewed-by: Julien Nabet Tested-by: Jenkins diff --git a/dbaccess/source/ui/tabledesign/TableController.cxx b/dbaccess/source/ui/tabledesign/TableController.cxx index 2125ce4c777a..c117ef08ee91 100644 --- a/dbaccess/source/ui/tabledesign/TableController.cxx +++ b/dbaccess/source/ui/tabledesign/TableController.cxx @@ -1132,7 +1132,7 @@ void OTableController::alterColumns() // first look for columns where something other than the name changed for (auto const& row : m_vRowList) { -OSL_ENSURE(*aIter,"OTableRow is null!"); +OSL_ENSURE(row,"OTableRow is null!"); OFieldDescription* pField = row->GetActFieldDescr(); if ( !pField ) continue; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/qa
sc/qa/extras/sctabviewobj.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit c08d6e581fce4df501b84d5ad6349905db63 Author: Stephan BergmannDate: Thu Jan 18 12:00:57 2018 +0100 xSheetDoc cannot be null here ...as the UNO_QUERY_THROW above would already have caused an exception Change-Id: Ie0453b67716c64ddaddfa6becd498952a497be63 Reviewed-on: https://gerrit.libreoffice.org/48106 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/sc/qa/extras/sctabviewobj.cxx b/sc/qa/extras/sctabviewobj.cxx index 2bc4c7b7031f..8217c4e915a9 100644 --- a/sc/qa/extras/sctabviewobj.cxx +++ b/sc/qa/extras/sctabviewobj.cxx @@ -68,8 +68,6 @@ ScTabViewObj::ScTabViewObj() uno::Reference< uno::XInterface > ScTabViewObj::init() { uno::Reference< sheet::XSpreadsheetDocument > xSheetDoc(mxComponent, uno::UNO_QUERY_THROW); -CPPUNIT_ASSERT_MESSAGE("no calc document", xSheetDoc.is()); - uno::Reference< frame::XModel > xModel(xSheetDoc, uno::UNO_QUERY_THROW); return xModel->getCurrentController(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/uiwriter/data/tdf115065.odt |binary sw/qa/extras/uiwriter/uiwriter.cxx | 27 +++ sw/source/core/crsr/swcrsr.cxx |4 ++-- 3 files changed, 29 insertions(+), 2 deletions(-) New commits: commit 13e55cedd2944c41f3f4fe7032cfea1ef9e6015d Author: Mike KaganskiDate: Thu Jan 18 14:21:58 2018 +0300 tdf#115065: nullptr dereference Change-Id: Iafaaafdabf9fb7947fa0b03cd38d3b4a567a41b9 Reviewed-on: https://gerrit.libreoffice.org/48110 Reviewed-by: Michael Stahl Tested-by: Jenkins diff --git a/sw/qa/extras/uiwriter/data/tdf115065.odt b/sw/qa/extras/uiwriter/data/tdf115065.odt new file mode 100644 index ..86fc28aaf686 Binary files /dev/null and b/sw/qa/extras/uiwriter/data/tdf115065.odt differ diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx b/sw/qa/extras/uiwriter/uiwriter.cxx index 7e3a0d54e533..f32c512d84de 100644 --- a/sw/qa/extras/uiwriter/uiwriter.cxx +++ b/sw/qa/extras/uiwriter/uiwriter.cxx @@ -297,6 +297,7 @@ public: void testTdf113481(); void testTdf115013(); void testTdf114536(); +void testTdf115065(); CPPUNIT_TEST_SUITE(SwUiWriterTest); CPPUNIT_TEST(testReplaceForward); @@ -473,6 +474,7 @@ public: CPPUNIT_TEST(testTdf113481); CPPUNIT_TEST(testTdf115013); CPPUNIT_TEST(testTdf114536); +CPPUNIT_TEST(testTdf115065); CPPUNIT_TEST_SUITE_END(); private: @@ -5805,6 +5807,31 @@ void SwUiWriterTest::testTdf115013() CPPUNIT_ASSERT_EQUAL(sColumnName, sColumn); } +void SwUiWriterTest::testTdf115065() +{ +// In the document, the tables have table style assigned +// Source table (first one) has two rows; +// destination (second one) has only one row +SwDoc* pDoc = createDoc("tdf115065.odt"); +CPPUNIT_ASSERT(pDoc); +SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell(); +CPPUNIT_ASSERT(pWrtShell); + +pWrtShell->GotoTable("Table2"); +SwRect aRect = pWrtShell->GetCurrFrame()->getFrameArea(); +// Destination point is the middle of the first cell of second table +Point ptTo = Point(aRect.Left() + aRect.Width() / 2, aRect.Top() + aRect.Height() / 2); + +pWrtShell->GotoTable("Table1"); +aRect = pWrtShell->GetCurrFrame()->getFrameArea(); +// Source point is the middle of the first cell of first table +Point ptFrom = Point(aRect.Left() + aRect.Width() / 2, aRect.Top() + aRect.Height() / 2); + +pWrtShell->SelTableCol(); +// The copy operation (or closing document after that) segfaulted +pWrtShell->Copy(pWrtShell, ptFrom, ptTo); +} + CPPUNIT_TEST_SUITE_REGISTRATION(SwUiWriterTest); CPPUNIT_PLUGIN_IMPLEMENT(); diff --git a/sw/source/core/crsr/swcrsr.cxx b/sw/source/core/crsr/swcrsr.cxx index 973880821359..4705f5c625ac 100644 --- a/sw/source/core/crsr/swcrsr.cxx +++ b/sw/source/core/crsr/swcrsr.cxx @@ -2265,8 +2265,8 @@ void SwTableCursor::DeleteBox(size_t const nPos) bool SwTableCursor::NewTableSelection() { bool bRet = false; -const SwNode *pStart = GetContentNode()->FindTableBoxStartNode(); -const SwNode *pEnd = GetContentNode(false)->FindTableBoxStartNode(); +const SwNode *pStart = GetNode().FindTableBoxStartNode(); +const SwNode *pEnd = GetNode(false).FindTableBoxStartNode(); if( pStart && pEnd ) { const SwTableNode *pTableNode = pStart->FindTableNode(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 104800] Windows 10 "Choose default apps" for Photo Viewer -- LO Draw module is available but displays only icon with no program label
https://bugs.documentfoundation.org/show_bug.cgi?id=104800 --- Comment #4 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115103] New: Date field is formatted as number when mail merge is run on DOC(X) files
https://bugs.documentfoundation.org/show_bug.cgi?id=115103 Bug ID: 115103 Summary: Date field is formatted as number when mail merge is run on DOC(X) files Product: LibreOffice Version: 4.4.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu CC: mikekagan...@hotmail.com Blocks: 102998 Created attachment 139207 --> https://bugs.documentfoundation.org/attachment.cgi?id=139207=edit Sample starting DOCX - Open the attached DOC or DOCX, and run Tools -> Mail Merge Wizard... - Skip to step 3, and add the attached XLS as address list. - Do not specify an address block or salutation, just finish the merge. - See the different merged values for the field. => The dates are formatted as numbers instead (eg. 43099 instead of 2018-01-01). Observed using LO 6.0.0.1 & 4.4.0.3 / Windows 7. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102998 [Bug 102998] [META] Mail merge bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: ios/LibreOfficeLight sysui/desktop
ios/LibreOfficeLight/LibreOfficeLight/Info.plist | 28 +- sysui/desktop/freedesktop/freedesktop-menus.spec | 24 sysui/desktop/macosx/Info.plist.in| 28 +- sysui/desktop/menus/calc.desktop |2 sysui/desktop/menus/impress.desktop |2 sysui/desktop/menus/writer.desktop|2 sysui/desktop/mimetypes/ms-excel-sheet-12.desktop |2 sysui/desktop/mimetypes/ms-excel-sheet-12.keys|2 sysui/desktop/mimetypes/ms-excel-sheet-binary-12.desktop |2 sysui/desktop/mimetypes/ms-excel-sheet-binary-12.keys |2 sysui/desktop/mimetypes/ms-excel-template-12.desktop |2 sysui/desktop/mimetypes/ms-excel-template-12.keys |2 sysui/desktop/mimetypes/ms-powerpoint-presentation-12.desktop |2 sysui/desktop/mimetypes/ms-powerpoint-presentation-12.keys|2 sysui/desktop/mimetypes/ms-powerpoint-template-12.desktop |2 sysui/desktop/mimetypes/ms-powerpoint-template-12.keys|2 sysui/desktop/mimetypes/ms-word-document-12.desktop |2 sysui/desktop/mimetypes/ms-word-document-12.keys |2 sysui/desktop/mimetypes/ms-word-template-12.desktop |2 sysui/desktop/mimetypes/ms-word-template-12.keys |2 sysui/desktop/mimetypes/openoffice.applications |2 sysui/desktop/mimetypes/openoffice.mime | 14 ++--- sysui/desktop/solaris/mime.types | 12 ++-- 23 files changed, 71 insertions(+), 71 deletions(-) New commits: commit 8b23cd3d73feddc9363e3c8ebf7409fe5031f47c Author: Caolán McNamaraDate: Thu Jan 18 11:52:16 2018 + Resolves: rhbz#1535541 fdo#88004 mimetypes are .macroEnabled not .macroenabled Change-Id: If7942ec9d4cd40f29fae2b9a8f76df1ef08bfc17 Reviewed-on: https://gerrit.libreoffice.org/48120 Reviewed-by: Michael Stahl Tested-by: Michael Stahl diff --git a/ios/LibreOfficeLight/LibreOfficeLight/Info.plist b/ios/LibreOfficeLight/LibreOfficeLight/Info.plist index a14a9aeb6164..e8c48f1789c3 100755 --- a/ios/LibreOfficeLight/LibreOfficeLight/Info.plist +++ b/ios/LibreOfficeLight/LibreOfficeLight/Info.plist @@ -320,18 +320,18 @@ com.microsoft.excel.xls com.microsoft.powerpoint.ppt org.openxmlformats.wordprocessingml.document - org.openxmlformats.wordprocessingml.document.macroenabled + org.openxmlformats.wordprocessingml.document.macroEnabled org.openxmlformats.wordprocessingml.template - org.openxmlformats.wordprocessingml.template.macroenabled + org.openxmlformats.wordprocessingml.template.macroEnabled org.openxmlformats.spreadsheetml.sheet - org.openxmlformats.spreadsheetml.sheet.macroenabled - com.microsoft.excel.sheet.binary.macroenabled + org.openxmlformats.spreadsheetml.sheet.macroEnabled + com.microsoft.excel.sheet.binary.macroEnabled org.openxmlformats.spreadsheetml.template - org.openxmlformats.spreadsheetml.template.macroenabled + org.openxmlformats.spreadsheetml.template.macroEnabled org.openxmlformats.presentationml.presentation - org.openxmlformats.presentationml.presentation.macroenabled + org.openxmlformats.presentationml.presentation.macroEnabled org.openxmlformats.presentationml.template - org.openxmlformats.presentationml.template.macroenabled + org.openxmlformats.presentationml.template.macroEnabled org.libreoffice.pdb-document org.libreoffice.wpd-document org.libreoffice.hwp-document @@ -1124,7 +1124,7 @@ file, You can obtain one at http://mozilla.org/MPL/2.0/. UTTypeDescription Office Open XML word processing document (macros enabled) UTTypeIdentifier - org.openxmlformats.wordprocessingml.document.macroenabled + org.openxmlformats.wordprocessingml.document.macroEnabled UTTypeTagSpecification public.filename-extension @@
[Libreoffice-commits] core.git: desktop/source drawinglayer/source i18npool/source include/android include/sal oox/source sal/rtl sc/source vcl/source vcl/unx writerfilter/source
desktop/source/lib/init.cxx |1 - drawinglayer/source/processor2d/vclpixelprocessor2d.cxx |1 - i18npool/source/calendar/calendar_hijri.cxx |2 -- include/android/compatibility.hxx |2 +- include/sal/config.h|3 +++ oox/source/drawingml/textparagraph.cxx |1 - oox/source/drawingml/textparagraphpropertiescontext.cxx |2 -- oox/source/export/drawingml.cxx |1 - sal/rtl/math.cxx|1 - sc/source/core/data/attrib.cxx |1 - sc/source/filter/excel/xetable.cxx |1 - sc/source/ui/unoobj/dapiuno.cxx |1 - vcl/source/gdi/CommonSalLayout.cxx |1 - vcl/unx/generic/gdi/cairotextrender.cxx |1 - writerfilter/source/rtftok/rtfsdrimport.cxx |1 - 15 files changed, 4 insertions(+), 16 deletions(-) New commits: commit 022588bf2060a53ae70db6b0f1de713e4ba3ee6a Author: Stephan BergmannDate: Thu Jan 18 12:01:37 2018 +0100 Include android/compatibility.hxx from ubiquitous sal/config.h ...instead of having to add it to more and more individual .cxx files, as the need arises. Change-Id: If1e893c79abf1c1bb7fb7b89dcb9bd423a7f1b94 Reviewed-on: https://gerrit.libreoffice.org/48108 Reviewed-by: Stephan Bergmann Tested-by: Stephan Bergmann diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 126861d7877a..468a145f31c6 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -95,7 +95,6 @@ #include #include #include -#include #include diff --git a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx index 11b40ce4d56b..5d44610fef8d 100644 --- a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx +++ b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx @@ -55,7 +55,6 @@ #include #include #include -#include #include diff --git a/i18npool/source/calendar/calendar_hijri.cxx b/i18npool/source/calendar/calendar_hijri.cxx index ad337d397ae0..bee72af7e7e3 100644 --- a/i18npool/source/calendar/calendar_hijri.cxx +++ b/i18npool/source/calendar/calendar_hijri.cxx @@ -23,8 +23,6 @@ #include #include -#include - #include using namespace ::com::sun::star::uno; diff --git a/include/android/compatibility.hxx b/include/android/compatibility.hxx index 27c99f4f2604..a3fdb0d256b4 100644 --- a/include/android/compatibility.hxx +++ b/include/android/compatibility.hxx @@ -19,7 +19,7 @@ #include -#if defined(ANDROID) && defined(ARM) +#if defined(ARM) #include #include diff --git a/include/sal/config.h b/include/sal/config.h index 31c19a34a18b..7fcdbfab45ad 100644 --- a/include/sal/config.h +++ b/include/sal/config.h @@ -22,6 +22,9 @@ #if defined LIBO_INTERNAL_ONLY #include "config_global.h" +#if defined ANDROID && defined __cplusplus +#include +#endif #endif #include diff --git a/oox/source/drawingml/textparagraph.cxx b/oox/source/drawingml/textparagraph.cxx index f63b73024824..8f1e5d1b061c 100644 --- a/oox/source/drawingml/textparagraph.cxx +++ b/oox/source/drawingml/textparagraph.cxx @@ -29,7 +29,6 @@ #include #include #include -#include using namespace ::com::sun::star::text; using namespace ::com::sun::star::uno; diff --git a/oox/source/drawingml/textparagraphpropertiescontext.cxx b/oox/source/drawingml/textparagraphpropertiescontext.cxx index 5b7477a39a0c..fdc9c3f210a9 100644 --- a/oox/source/drawingml/textparagraphpropertiescontext.cxx +++ b/oox/source/drawingml/textparagraphpropertiescontext.cxx @@ -34,8 +34,6 @@ #include #include -#include - using namespace ::oox::core; using namespace ::com::sun::star::uno; using namespace ::com::sun::star::xml::sax; diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx index 3da6ad4f357e..5af5dce2d12f 100644 --- a/oox/source/export/drawingml.cxx +++ b/oox/source/export/drawingml.cxx @@ -101,7 +101,6 @@ #include #include #include -#include using namespace ::css; using namespace ::css::beans; diff --git a/sal/rtl/math.cxx b/sal/rtl/math.cxx index 18ece939e8d4..387ae3b2b4aa 100644 --- a/sal/rtl/math.cxx +++ b/sal/rtl/math.cxx @@ -30,7 +30,6 @@ #include #include #include -#include #include #include diff --git a/sc/source/core/data/attrib.cxx b/sc/source/core/data/attrib.cxx index cc614b28dbb6..29b1d92fd317 100644 --- a/sc/source/core/data/attrib.cxx +++ b/sc/source/core/data/attrib.cxx @@ -20,7 +20,6 @@ #include #include -#include #include diff --git a/sc/source/filter/excel/xetable.cxx b/sc/source/filter/excel/xetable.cxx index 98127479cf95..7ca907dff18f 100644 --- a/sc/source/filter/excel/xetable.cxx
[Libreoffice-bugs] [Bug 115100] Assertion failed, if I set vertical align for gluepoint
https://bugs.documentfoundation.org/show_bug.cgi?id=115100 Aron Budeachanged: What|Removed |Added CC||ba...@caesar.elte.hu Blocks||105537 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105537 [Bug 105537] [META] Assertion failed crashes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sysui/desktop
sysui/desktop/apparmor/program.oosplash|4 +++- sysui/desktop/apparmor/program.soffice.bin |4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) New commits: commit d4440ce6b5964d08be1e5841ed301112b260823d Author: Rene EngelhardDate: Thu Jan 18 23:19:46 2018 +0100 update copyright years Change-Id: I634c1132265295f90f624a53b93dddb2b18eabd5 diff --git a/sysui/desktop/apparmor/program.oosplash b/sysui/desktop/apparmor/program.oosplash index d68fa776de8f..333c0617aa86 100644 --- a/sysui/desktop/apparmor/program.oosplash +++ b/sysui/desktop/apparmor/program.oosplash @@ -1,18 +1,20 @@ # -- # #Copyright (C) 2016 Canonical Ltd. +#Copyright (C) 2018 Software in the Public Interest, Inc. # #This Source Code Form is subject to the terms of the Mozilla Public #License, v. 2.0. If a copy of the MPL was not distributed with this #file, You can obtain one at http://mozilla.org/MPL/2.0/. # #Author: Bryan Quigley +#Rene Engelhard # # -- #include -profile libreoffice-oopslash INSTDIR-program/oosplash { +profile libreoffice-oopslash INSTDIR-program/oosplash flags=(complain) { #include #include diff --git a/sysui/desktop/apparmor/program.soffice.bin b/sysui/desktop/apparmor/program.soffice.bin index 8aab5c155e8d..cbed1b69d4a2 100644 --- a/sysui/desktop/apparmor/program.soffice.bin +++ b/sysui/desktop/apparmor/program.soffice.bin @@ -1,7 +1,7 @@ # -- # #Copyright (C) 2016 Canonical Ltd. -#Copyright (C) 2017 Software in the Public Interest, Inc. +#Copyright (C) 2018 Software in the Public Interest, Inc. # #This Source Code Form is subject to the terms of the Mozilla Public #License, v. 2.0. If a copy of the MPL was not distributed with this @@ -72,7 +72,7 @@ #include -profile libreoffice-soffice INSTDIR-program/soffice.bin { +profile libreoffice-soffice INSTDIR-program/soffice.bin flags=(complain) { #include #include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/table3.cxx | 75 + 1 file changed, 39 insertions(+), 36 deletions(-) New commits: commit 6cb011cc644d8f2e189ce5b8e5de7ff297969840 Author: Ahmed GHANMIDate: Thu Jan 18 10:40:50 2018 +0100 tdf#114720: Fix subtotal crash A condition was added in order to not make subtotal functions if category was not checked. Change-Id: I56f11330fa16bf0d3199576ce2545cbc8d13e864 Reviewed-on: https://gerrit.libreoffice.org/48099 Reviewed-by: Eike Rathke Tested-by: Eike Rathke diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx index 2bb00607eb68..2f52aee82720 100644 --- a/sc/source/core/data/table3.cxx +++ b/sc/source/core/data/table3.cxx @@ -2139,48 +2139,51 @@ bool ScTable::DoSubTotals( ScSubTotalParam& rParam ) } } -// generate global total -SCROW nGlobalStartRow = aRowVector[0].nSubStartRow; -SCROW nGlobalStartFunc = aRowVector[0].nFuncStart; -SCROW nGlobalEndRow = 0; -SCROW nGlobalEndFunc = 0; -for ( ::std::vector< RowEntry >::const_iterator iEntry( aRowVector.begin()); -iEntry != aRowVector.end(); ++iEntry) -{ -nGlobalEndRow = (nGlobalEndRow < iEntry->nDestRow) ? iEntry->nDestRow : nGlobalEndRow; -nGlobalEndFunc = (nGlobalEndFunc < iEntry->nFuncEnd) ? iEntry->nFuncEnd : nGlobalEndRow; -} - -for (sal_uInt16 nLevel=0; nLevel 0) { -// increment end row -nGlobalEndRow++; +// generate global total +SCROW nGlobalStartRow = aRowVector[0].nSubStartRow; +SCROW nGlobalStartFunc = aRowVector[0].nFuncStart; +SCROW nGlobalEndRow = 0; +SCROW nGlobalEndFunc = 0; +for (::std::vector< RowEntry >::const_iterator iEntry(aRowVector.begin()); + iEntry != aRowVector.end(); ++iEntry) +{ +nGlobalEndRow = (nGlobalEndRow < iEntry->nDestRow) ? iEntry->nDestRow : nGlobalEndRow; +nGlobalEndFunc = (nGlobalEndFunc < iEntry->nFuncEnd) ? iEntry->nFuncEnd : nGlobalEndRow; +} -// add row entry for formula -aRowEntry.nGroupNo = nLevelCount-nLevel-1; -aRowEntry.nSubStartRow = nGlobalStartRow; -aRowEntry.nFuncStart = nGlobalStartFunc; -aRowEntry.nDestRow = nGlobalEndRow; -aRowEntry.nFuncEnd = nGlobalEndFunc; +for (sal_uInt16 nLevel = 0; nLevel InsertRow( 0, nTab, MAXCOL, nTab, aRowEntry.nDestRow, 1 ); +// increment row +nGlobalEndFunc++; -if (bSpaceLeft) -{ -aRowVector.push_back( aRowEntry ); -nEndRow++; -DBShowRow(aRowEntry.nDestRow, true); +bSpaceLeft = pDocument->InsertRow(0, nTab, MAXCOL, nTab, aRowEntry.nDestRow, 1); -// insert label -ScSubTotalFunc* eResFunc = rParam.pFunctions[aRowEntry.nGroupNo]; -OUString label = ScGlobal::GetRscString( STR_TABLE_GRAND ); -label += " "; -label += ScGlobal::GetRscString(lcl_GetSubTotalStrId(eResFunc[0])); -SetString( nGroupCol[aRowEntry.nGroupNo], aRowEntry.nDestRow, nTab, label ); -ApplyStyle( nGroupCol[aRowEntry.nGroupNo], aRowEntry.nDestRow, pStyle ); +if (bSpaceLeft) +{ +aRowVector.push_back(aRowEntry); +nEndRow++; +DBShowRow(aRowEntry.nDestRow, true); + +// insert label +ScSubTotalFunc* eResFunc = rParam.pFunctions[aRowEntry.nGroupNo]; +OUString label = ScGlobal::GetRscString(STR_TABLE_GRAND); +label += " "; +label += ScGlobal::GetRscString(lcl_GetSubTotalStrId(eResFunc[0])); +SetString(nGroupCol[aRowEntry.nGroupNo], aRowEntry.nDestRow, nTab, label); +ApplyStyle(nGroupCol[aRowEntry.nGroupNo], aRowEntry.nDestRow, pStyle); +} } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115088] Pasting multi-line text from external source behaves strangely
https://bugs.documentfoundation.org/show_bug.cgi?id=115088 --- Comment #4 from Thomas Lendo--- (In reply to Xisco Faulí from comment #3) > Dupe of bug 111349 or bug 111079 ? I think it's more similar bug 111349. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 3 commits - sysui/desktop
sysui/desktop/apparmor/program.oosplash|1 + sysui/desktop/apparmor/program.soffice.bin |8 2 files changed, 9 insertions(+) New commits: commit c6a19889e91f2585453636667e3d5779b153ab86 Author: Rene EngelhardDate: Thu Jan 18 23:12:03 2018 +0100 deb#887593 apparmor: allow soffice.bin reading .mozilla/firefox and .gnupg Change-Id: I74b57cd510b1babbb4a537d307a6ffc9ee1d9ce5 diff --git a/sysui/desktop/apparmor/program.soffice.bin b/sysui/desktop/apparmor/program.soffice.bin index 27f7e2f34277..8aab5c155e8d 100644 --- a/sysui/desktop/apparmor/program.soffice.bin +++ b/sysui/desktop/apparmor/program.soffice.bin @@ -84,6 +84,8 @@ profile libreoffice-soffice INSTDIR-program/soffice.bin { #include #include #include +# GnuPG1 only... +# #include #include #include @@ -166,4 +168,8 @@ profile libreoffice-soffice INSTDIR-program/soffice.bin { owner @{HOME}/.icons/*/cursors/* r, /usr/share/*-fonts/conf.avail/*.conf r, /usr/share/fonts-config/conf.avail/*.conf r, + + owner @{HOME}/.mozilla/firefox/** r, + # there is abstractions/gnupg but that's just for gpg1... + owner @{HOME}/.gnupg/* r, } commit e64e7da9b222cebfdff270059f5182e71b667796 Author: Rene Engelhard Date: Thu Jan 18 23:11:54 2018 +0100 deb#887593 add gpg and gpgsm to soffice.bin apparmor profile Change-Id: I4b37be72ebec86b9360ea2594b26815ddaab60cd diff --git a/sysui/desktop/apparmor/program.soffice.bin b/sysui/desktop/apparmor/program.soffice.bin index 9c7ec3c2a3f7..27f7e2f34277 100644 --- a/sysui/desktop/apparmor/program.soffice.bin +++ b/sysui/desktop/apparmor/program.soffice.bin @@ -124,6 +124,8 @@ profile libreoffice-soffice INSTDIR-program/soffice.bin { /usr/bin/lpr rmPUx, /usr/bin/paperconfrmix, /usr/bin/gpgconf rmix, + /usr/bin/gpg rmix, + /usr/bin/gpgsmrmix, /dev/tty rw, commit 616af7d9bd2e75e4bf9224ef8301c7e6b1b4d972 Author: Rene Engelhard Date: Thu Jan 18 23:11:38 2018 +0100 deb#887593 add #include to oosplash apparmor profile Change-Id: Ib9595b1e0fe888a6698c3c508a24390d3798b3e4 diff --git a/sysui/desktop/apparmor/program.oosplash b/sysui/desktop/apparmor/program.oosplash index fef54b7ee384..d68fa776de8f 100644 --- a/sysui/desktop/apparmor/program.oosplash +++ b/sysui/desktop/apparmor/program.oosplash @@ -14,6 +14,7 @@ profile libreoffice-oopslash INSTDIR-program/oosplash { #include + #include /etc/libreoffice/ r, /etc/libreoffice/** r, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 Thomas Lendochanged: What|Removed |Added Depends on||115038 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115038 [Bug 115038] Umlaute (mutation) will be shown wrong in some objects when you type them first -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa
sc/qa/extras/sctabviewobj.cxx | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) New commits: commit fe5c763250690cac53550b576f8a793f2d20a791 Author: Stephan BergmannDate: Wed Jan 17 18:03:27 2018 +0100 Don't let testSpreadsheetViewSettingsProperties interfere with existing tests ...by giving each test its own mxComponent. At least my Windows builds started to fail CppunitTest_sc_tabviewobj with > C:/lo/core/test/source/sheet/xviewsplitable.cxx:36:sc_apitest::ScTabViewObj::testSplit > equality assertion failed > - Expected: 1 > - Actual : 0 > - Wrong column after 95307f2ca73480176634e5cc46d96a19b735e87b "tdf#45904 Move _SpreadsheetViewSettings Java tests to C++" added the call to testSpreadsheetViewSettingsProperties ahead of the call to testSplit. (And allowing multiple tests to work on shared state and interfere like they apparently do here seems rather brittle in general.) Change-Id: I73a60ae3c703e59852c8e16b09f5897849f5bdf4 Reviewed-on: https://gerrit.libreoffice.org/48070 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/sc/qa/extras/sctabviewobj.cxx b/sc/qa/extras/sctabviewobj.cxx index 4a8cbfe2befb..2bc4c7b7031f 100644 --- a/sc/qa/extras/sctabviewobj.cxx +++ b/sc/qa/extras/sctabviewobj.cxx @@ -27,8 +27,6 @@ using namespace css::uno; namespace sc_apitest { -#define NUMBER_OF_TESTS 4 - class ScTabViewObj : public CalcUnoApiTest, public apitest::SpreadsheetViewSettings, public apitest::XSpreadsheetView, @@ -59,14 +57,9 @@ public: CPPUNIT_TEST_SUITE_END(); private: - -static sal_Int32 nTest; -static uno::Reference< lang::XComponent > mxComponent; +uno::Reference< lang::XComponent > mxComponent; }; -sal_Int32 ScTabViewObj::nTest = 0; -uno::Reference< lang::XComponent > ScTabViewObj::mxComponent; - ScTabViewObj::ScTabViewObj() : CalcUnoApiTest("/sc/qa/extras/testdocuments") { @@ -74,9 +67,6 @@ ScTabViewObj::ScTabViewObj() uno::Reference< uno::XInterface > ScTabViewObj::init() { -if (!mxComponent.is()) -mxComponent = loadFromDesktop("private:factory/scalc"); - uno::Reference< sheet::XSpreadsheetDocument > xSheetDoc(mxComponent, uno::UNO_QUERY_THROW); CPPUNIT_ASSERT_MESSAGE("no calc document", xSheetDoc.is()); @@ -87,19 +77,13 @@ uno::Reference< uno::XInterface > ScTabViewObj::init() void ScTabViewObj::setUp() { -nTest++; -CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS); CalcUnoApiTest::setUp(); +mxComponent = loadFromDesktop("private:factory/scalc"); } void ScTabViewObj::tearDown() { -if (nTest == NUMBER_OF_TESTS) -{ -closeDocument(mxComponent); -mxComponent.clear(); -} - +closeDocument(mxComponent); CalcUnoApiTest::tearDown(); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - cui/source LICENSE_ALv2 NOTICE
LICENSE_ALv2 |2 +- NOTICE |2 +- cui/source/dialogs/about.cxx |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 8e0650e18f94d9dec1c5c854bd3a93fa97b1964b Author: Matthias SeidelDate: Thu Jan 18 22:09:22 2018 + Update the Copyright year to 2018 According to: https://svn.apache.org/viewvc?view=revision=1780015 diff --git a/LICENSE_ALv2 b/LICENSE_ALv2 index 6e6b45666151..f999ddb9659c 100644 --- a/LICENSE_ALv2 +++ b/LICENSE_ALv2 @@ -187,7 +187,7 @@ same "printed page" as the copyright notice for easier identification within third-party archives. - Copyright 2011, 2012, 2013, 2014, 2015, 2016, 2017 Apache Software Foundation + Copyright 2011, 2012, 2013, 2014, 2015, 2016, 2017, 2018 Apache Software Foundation Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. diff --git a/NOTICE b/NOTICE index 2d2dbe1fee7a..68d964b9fd9f 100644 --- a/NOTICE +++ b/NOTICE @@ -1,6 +1,6 @@ Apache OpenOffice (https://www.openoffice.org) -Copyright 2011, 2017 The Apache Software Foundation +Copyright 2011, 2018 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (https://www.apache.org/). diff --git a/cui/source/dialogs/about.cxx b/cui/source/dialogs/about.cxx index ff944f69f59a..5e77cdf61f24 100644 --- a/cui/source/dialogs/about.cxx +++ b/cui/source/dialogs/about.cxx @@ -311,7 +311,7 @@ AboutDialog::AboutDialog( Window* pParent, const ResId & rId ) : sbcopyright.appendAscii("Copyright "); sbcopyright.append((sal_Unicode)0x00a9); sbcopyright.appendAscii(" "); -rtl::OUString sYear( RTL_CONSTASCII_USTRINGPARAM("2017") ); +rtl::OUString sYear( RTL_CONSTASCII_USTRINGPARAM("2018") ); if (vendor.EqualsAscii("Apache Software Foundation")) { sbcopyright.append(sYear); sbcopyright.appendAscii(" The Apache Software Foundation.\n\n"); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/dockmgr.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit c4d2710c1c42714fd95e99f6f1e1627bfe8881e1 Author: Maxim MonastirskyDate: Thu Jan 18 00:53:44 2018 +0200 Don't allow tearoff under Wayland as floating toolbars aren't movable there. Change-Id: I543344946f02d5a336ff738b4d6d9f9b21c595e9 Reviewed-on: https://gerrit.libreoffice.org/48096 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky diff --git a/vcl/source/window/dockmgr.cxx b/vcl/source/window/dockmgr.cxx index ed026a3fdf0d..7b7e3e52789f 100644 --- a/vcl/source/window/dockmgr.cxx +++ b/vcl/source/window/dockmgr.cxx @@ -799,7 +799,8 @@ void ImplDockingWindowWrapper::StartPopupMode( ToolBox *pParentToolBox, FloatWin ImplPreparePopupMode(); // don't allow tearoff, if globally disabled -if( GetWindow()->GetType() == WindowType::TOOLBOX && ToolBox::AlwaysLocked() ) +if( !StyleSettings::GetDockingFloatsSupported() || +( GetWindow()->GetType() == WindowType::TOOLBOX && ToolBox::AlwaysLocked() ) ) nFlags &= ~FloatWinPopupFlags::AllowTearOff; // if the subtoolbar was opened via keyboard make sure that key events ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 107575] [META] Number format bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107575 Thomas Lendochanged: What|Removed |Added Depends on||115078 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115078 [Bug 115078] Automatically insert a decimal point like in Excel 2016 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115076] Calc crashs when a form control is added
https://bugs.documentfoundation.org/show_bug.cgi?id=115076 Xisco Faulíchanged: What|Removed |Added Resolution|FIXED |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: android/CustomTarget_lo_android.mk
android/CustomTarget_lo_android.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a0f74a184f2057ebfca0d6f913a15d0a7542204b Author: Christian LohmaierDate: Thu Jan 18 22:00:00 2018 +0100 adjust path to generated apk to new defaults current android-gradle plugin creates the apk in dimension/flavor/variant (whatever you want to call it) specific directory Change-Id: I5514fe53c5c8c556d194a0f06ad6167b0b1cc98e diff --git a/android/CustomTarget_lo_android.mk b/android/CustomTarget_lo_android.mk index 05d6d4353d9f..642dfe2f569a 100644 --- a/android/CustomTarget_lo_android.mk +++ b/android/CustomTarget_lo_android.mk @@ -20,7 +20,7 @@ $(loandroid3_DIR)/done : $(call gb_Postprocess_get_target,AllModulesButInstsetNa # still looks for the .apk, and we want fresh daily builds to be uploaded. # Us "foo" instead of the old INPATH mkdir -p $(BUILDDIR)/instsetoo_native/foo/bin; \ - cp $(SRCDIR)/android/source/build/outputs/apk/*-debug.apk $(BUILDDIR)/instsetoo_native/foo/bin + cp $(SRCDIR)/android/source/build/outputs/apk/strippedUI/debug/*-debug.apk $(BUILDDIR)/instsetoo_native/foo/bin $(call gb_CustomTarget_get_clean_target,android/loandroid3) : $(call gb_Output_announce,$(subst $(WORKDIR)/Clean/,,$@),$(false),MAK,2) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/editeng
include/editeng/unotext.hxx |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) New commits: commit a46ff530d4cf3d7d87fc58f0c9201949b8cb832d Author: Caolán McNamaraDate: Thu Jan 18 12:52:30 2018 + ofz#5471 Null-dereference READ Change-Id: I5af76b87c3793c7ec7ac41ab25bb4de5d81fc3cf Reviewed-on: https://gerrit.libreoffice.org/48123 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/include/editeng/unotext.hxx b/include/editeng/unotext.hxx index 73e2afdf366d..4ee3bf4fc11d 100644 --- a/include/editeng/unotext.hxx +++ b/include/editeng/unotext.hxx @@ -309,7 +309,12 @@ protected: public: // Internal -const ESelection& GetSelection() const throw() { CheckSelection( const_cast (this)->maSelection, mpEditSource->GetTextForwarder() ); return maSelection; }; +const ESelection& GetSelection() const throw() +{ +const SvxTextForwarder* pForwarder = mpEditSource ? mpEditSource->GetTextForwarder() : nullptr; +CheckSelection(const_cast (this)->maSelection, pForwarder); +return maSelection; +} voidSetSelection( const ESelection& rSelection ) throw(); voidCollapseToStart() throw(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: oox/source
oox/source/export/chartexport.cxx | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) New commits: commit fa68bed11c180ebb0d45fb7779d538098b2921ff Author: Caolán McNamaraDate: Thu Jan 18 17:36:31 2018 + crashtesting: multiple export failures since... commit 84392651d2731cce91c3b2e144bed4ac07e4ddf1 Date: Wed Jan 3 23:27:16 2018 +0100 tdf#114173 Preserve size of chart legend during xlsx export Change-Id: Iebc936a0f490d6b707dfee0343732753f56728e7 Reviewed-on: https://gerrit.libreoffice.org/48147 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/oox/source/export/chartexport.cxx b/oox/source/export/chartexport.cxx index 3e9376f05662..72cfae098c67 100644 --- a/oox/source/export/chartexport.cxx +++ b/oox/source/export/chartexport.cxx @@ -863,7 +863,9 @@ void ChartExport::exportLegend( const Reference< css::chart::XChartDocument >& x FSEND); chart2::RelativePosition aPos = aRelativePos.get(); uno::Any aRelativeSize = xProp->getPropertyValue("RelativeSize"); -chart2::RelativeSize aSize = aRelativeSize.get(); +chart2::RelativeSize aSize; +if (aRelativeSize.hasValue()) +aSize = aRelativeSize.get(); const double x = aPos.Primary; const double y = aPos.Secondary; @@ -877,13 +879,17 @@ void ChartExport::exportLegend( const Reference< css::chart::XChartDocument >& x XML_val, IS(y), FSEND); -pFS->singleElement(FSNS(XML_c, XML_w), -XML_val, IS(w), -FSEND); +if (aRelativeSize.hasValue()) +{ +pFS->singleElement(FSNS(XML_c, XML_w), +XML_val, IS(w), +FSEND); + +pFS->singleElement(FSNS(XML_c, XML_h), +XML_val, IS(h), +FSEND); +} -pFS->singleElement(FSNS(XML_c, XML_h), -XML_val, IS(h), -FSEND); SAL_WARN_IF(aPos.Anchor != css::drawing::Alignment_TOP_LEFT, "oox", "unsupported anchor position"); pFS->endElement(FSNS(XML_c, XML_manualLayout)); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115031] Installs but Will Only Run in Safe-Mode New PC Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=115031 Samuel Mehrbrodt (CIB)changed: What|Removed |Added CC||s.mehrbr...@gmail.com --- Comment #3 from Samuel Mehrbrodt (CIB) --- When you start in safe mode, there is an option to disable hardware acceleration (OpenGL, OpenCL). Select that, click "Apply and restart". Does it work then? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/brdwin.cxx |4 ++-- vcl/source/window/dockmgr.cxx |2 +- vcl/source/window/floatwin.cxx |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) New commits: commit 829b0564959411d0cc64169fe69153a714050c0d Author: Maxim MonastirskyDate: Wed Jan 17 21:08:59 2018 +0200 tdf#115057 Never use ImplPopupFloatWin for anything except ToolBox ImplPopupFloatWin draws the window title and frame directly on the client window, which is incompatible with .ui layouts, as they try to occupy the whole available space. Instead just use a plain FloatingWindow whenever possible, and change the border window code to mimic the behavior of ImplPopupFloatWin, wrt removing part of the frame of toolbar popups w/o a title. Change-Id: If72ea89e31f913470faad7fcb8083f9b9787c9a8 Reviewed-on: https://gerrit.libreoffice.org/48094 Reviewed-by: Maxim Monastirsky Tested-by: Maxim Monastirsky diff --git a/vcl/source/window/brdwin.cxx b/vcl/source/window/brdwin.cxx index c929d0be35f8..5d8b14c7cde9 100644 --- a/vcl/source/window/brdwin.cxx +++ b/vcl/source/window/brdwin.cxx @@ -1418,7 +1418,7 @@ void ImplStdBorderWindowView::DrawWindow(vcl::RenderContext& rRenderContext, con vcl::Region oldClipRgn(rRenderContext.GetClipRegion()); // for popups, don't draw part of the frame -if (pData->mnTitleType == BorderWindowTitleType::Popup) +if (pData->mnTitleType >= BorderWindowTitleType::Popup) { FloatingWindow* pWin = dynamic_cast (pData->mpBorderWindow->GetWindow(GetWindowType::Client)); if (pWin) @@ -1444,7 +1444,7 @@ void ImplStdBorderWindowView::DrawWindow(vcl::RenderContext& rRenderContext, con --aInRect.Bottom(); // restore -if (pData->mnTitleType == BorderWindowTitleType::Popup) +if (pData->mnTitleType >= BorderWindowTitleType::Popup) rRenderContext.SetClipRegion(oldClipRgn); // Draw Border diff --git a/vcl/source/window/dockmgr.cxx b/vcl/source/window/dockmgr.cxx index ef290c642ced..57b83e568215 100644 --- a/vcl/source/window/dockmgr.cxx +++ b/vcl/source/window/dockmgr.cxx @@ -933,7 +933,7 @@ void ImplDockingWindowWrapper::ImplPreparePopupMode( FloatWinPopupFlags nFlags ) mpOldBorderWin = nullptr; // no border window found bool bAllowTearOff = bool( nFlags & FloatWinPopupFlags::AllowTearOff ); -bool bUseStdPopup = bAllowTearOff && GetWindow()->GetType() != WindowType::TOOLBOX; +bool bUseStdPopup = GetWindow()->GetType() != WindowType::TOOLBOX; // the new parent for popup mode VclPtr pWin; diff --git a/vcl/source/window/floatwin.cxx b/vcl/source/window/floatwin.cxx index 6377c6c6f853..304fadb40eb9 100644 --- a/vcl/source/window/floatwin.cxx +++ b/vcl/source/window/floatwin.cxx @@ -427,7 +427,7 @@ Point FloatingWindow::ImplCalcPos( vcl::Window* pWindow, aPos = pW->AbsoluteScreenToOutputPixel( aPos ); // store a cliprect that can be used to clip the common edge of the itemrect and the floating window -if( pFloatingWindow ) +if( pFloatingWindow && pFloatingWindow->mpImplData->mpBox ) { pFloatingWindow->mpImplData->maItemEdgeClipRect = tools::Rectangle( e1, e2 ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115081] Data | Validity restriction can be violated by coping value into the field
https://bugs.documentfoundation.org/show_bug.cgi?id=115081 Thomas Lendochanged: What|Removed |Added CC||thomas.le...@gmail.com Blocks||102593 --- Comment #1 from Thomas Lendo --- Thanks for your report, grofaty. >From my point of view, this behavior is intended as you copy a cell including all format and other cell attributes. You can avoid to destroy the cell validity with Edit > Paste Unformatted Text instead of Edit > Paste. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102593 [Bug 102593] [META] Paste bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115101] New: Form Editing, Table Control, Add Field, adds wrong items
https://bugs.documentfoundation.org/show_bug.cgi?id=115101 Bug ID: 115101 Summary: Form Editing, Table Control, Add Field, adds wrong items Product: LibreOffice Version: 6.0.0.0.beta2 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bridgeportcontrac...@gmail.com Created attachment 139205 --> https://bugs.documentfoundation.org/attachment.cgi?id=139205=edit database to demo this bug How to demonstrate: 1) Open the attached database ("Table Control Add Field bug.odb"). 2) Edit the "Categories" form 3) Click on the "Add Field" icon in the Form Design toolbar, (blue with rectangular grid in it). 4) In the "Add field: Table Categories" dialog press and hold the left mouse button on "CategoryID" and while holding the mouse button down, drag this into the darker top bar in the Table control, to the right of the existing ID field and release the mouse button. A field named CategoryID is created to the right of ID. 5) The bug: Again in the "Add field: Table Categories" dialog press and hold the left mouse button, but this time on "CategoryName" and while holding the mouse button down, drag this into the darker top bar in the Table control and to the right of the two other existing fields. Expected results: CategoryID & CategoryName would be added to right of the ID field. Actual result: CategoryID and CategoryID is added (twice). Notice that when you start to drag suddenly the blue highlight around CategoryName goes away and now CategoryID is magically highlighted. Also notice that if you try this again, you might sometimes be able to get what you want. ___- LO 6.0.0.0 and 5.4.3.2; Debian 9.3; Cinnamon 3.2.7 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101931] FILEOPEN: Drawings/shapes in DOCX (MS Office 2007) are not shown correctly (WPS)
https://bugs.documentfoundation.org/show_bug.cgi?id=101931 --- Comment #7 from Ljiljan--- The bug is stil present even in LibreOffice 6.0. The original document was created with MS Office 2007 using drawing canvas, so it might be that DOCX standards were different at that time... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/qa desktop/source sfx2/source sw/qa sw/source
desktop/qa/desktop_lib/test_desktop_lib.cxx|1 desktop/source/lib/init.cxx| 29 +++ sfx2/source/control/unoctitm.cxx | 25 ++-- sw/qa/extras/tiledrendering/tiledrendering.cxx | 27 +- sw/source/uibase/shells/textsh1.cxx| 37 +++-- 5 files changed, 101 insertions(+), 18 deletions(-) New commits: commit 252ce90e39648c47bcfdb39547d0ac82bacdbae6 Author: Henry CastroDate: Tue Jan 9 22:17:23 2018 -0400 sw lokit: add page syles to header & footer Change-Id: I3c0b0603d1e03f1cc19af4324dd2b909320d9d4a Reviewed-on: https://gerrit.libreoffice.org/47687 Tested-by: Jenkins Reviewed-by: Henry Castro diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx b/desktop/qa/desktop_lib/test_desktop_lib.cxx index d5d7cb26f18b..4488aa8c155c 100644 --- a/desktop/qa/desktop_lib/test_desktop_lib.cxx +++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx @@ -309,6 +309,7 @@ void DesktopLOKTest::testGetStyles() rPair.first != "CellStyles" && rPair.first != "ShapeStyles" && rPair.first != "TableStyles" && +rPair.first != "HeaderFooter" && rPair.first != "Commands") { CPPUNIT_FAIL("Unknown style family: " + rPair.first); diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 4c0b96b85951..126861d7877a 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -2769,6 +2769,35 @@ static char* getStyles(LibreOfficeKitDocument* pThis, const char* pCommand) aValues.add_child(sStyleFam.toUtf8().getStr(), aChildren); } +// Header & Footer Styles +{ +OUString sName; +bool bIsPhysical; +boost::property_tree::ptree aChild; +uno::Reference xProperty; +boost::property_tree::ptree aChildren; +uno::Reference xContainer; + +if (xStyleFamilies->getByName("PageStyles") >>= xContainer) +{ +uno::Sequence aSeqNames = xContainer->getElementNames(); +for (sal_Int32 itName = 0; itName < aSeqNames.getLength(); itName++) +{ +sName = aSeqNames[itName]; +xProperty.set(xContainer->getByName(sName), uno::UNO_QUERY); +if (xProperty.is() && (xProperty->getPropertyValue("IsPhysical") >>= bIsPhysical) && bIsPhysical) +{ +xProperty->getPropertyValue("DisplayName") >>= sName; +aChild.put("", sName.toUtf8()); +aChildren.push_back(std::make_pair("", aChild)); +} +else +bIsPhysical = false; +} +aValues.add_child("HeaderFooter", aChildren); +} +} + { boost::property_tree::ptree aCommandList; diff --git a/sfx2/source/control/unoctitm.cxx b/sfx2/source/control/unoctitm.cxx index 63df319437a5..2193914465f2 100644 --- a/sfx2/source/control/unoctitm.cxx +++ b/sfx2/source/control/unoctitm.cxx @@ -1019,9 +1019,7 @@ static void InterceptLOKStateChangeEvent(const SfxViewFrame* pViewFrame, const c aEvent.FeatureURL.Path == "AlignLeft" || aEvent.FeatureURL.Path == "AlignHorizontalCenter" || aEvent.FeatureURL.Path == "AlignRight" || -aEvent.FeatureURL.Path == "DocumentRepair" || -aEvent.FeatureURL.Path == "InsertPageHeader" || -aEvent.FeatureURL.Path == "InsertPageFooter") +aEvent.FeatureURL.Path == "DocumentRepair") { bool bTemp = false; aEvent.State >>= bTemp; @@ -1197,6 +1195,27 @@ static void InterceptLOKStateChangeEvent(const SfxViewFrame* pViewFrame, const c } } } +else if (aEvent.FeatureURL.Path == "InsertPageHeader" || + aEvent.FeatureURL.Path == "InsertPageFooter") +{ +if (aEvent.IsEnabled) +{ +css::uno::Sequence< OUString > aSeq; +if (aEvent.State >>= aSeq) +{ +aBuffer.append(u'{'); +for (sal_Int32 itSeq = 0; itSeq < aSeq.getLength(); itSeq++) +{ +aBuffer.append("\"" + aSeq[itSeq]); +if (itSeq != aSeq.getLength() - 1) +aBuffer.append("\":true,"); +else +aBuffer.append("\":true"); +} +aBuffer.append(u'}'); +} +} +} else { return; diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx b/sw/qa/extras/tiledrendering/tiledrendering.cxx index 3dd1335e50f9..3a9c1c6f9985 100644 --- a/sw/qa/extras/tiledrendering/tiledrendering.cxx +++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx @@ -23,6 +23,7 @@ #include #include #include +#include #include #include #include
[Libreoffice-bugs] [Bug 115100] New: Assertion failed, if I set vertical align for gluepoint
https://bugs.documentfoundation.org/show_bug.cgi?id=115100 Bug ID: 115100 Summary: Assertion failed, if I set vertical align for gluepoint Product: LibreOffice Version: 6.1.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Created attachment 139204 --> https://bugs.documentfoundation.org/attachment.cgi?id=139204=edit Output from VS 2017 at breakpoint after "wiederholen" at assertion. Draw a shape and insert a gluepoint, save and reload. Click on shape, click on Gluepoint-icon in toolbar, open the "Glue Points" toolbar and undock it. Select your gluepoint. Click on %-icon to deselect it. Click on "Vertical align top"-icon. --> Assertion failed. Program: C:\LO_build\core\instdir\program\svxcorelo.dll File: C:\LO_build\core\include\svx/svdglue.hxx Line: 102 Expression: (nAlg & static_cast(0xff00)) == SdrAlign::NONE I have set a break point in line 102. The attachment contains the output I have got from VS 2017. I have used Version: 6.1.0.0.alpha0+ (x64) Build ID: b97a0df0f3234b4c1140ba1418d4b96a592afa4a CPU threads: 8; OS: Windows 10.0; UI render: default; Locale: de-DE (de_DE); Calc: CL Please consider, that gluepoints might not work in your 5.4, see bug 115089. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/control/Control.Menubar.js | 118 +- loleaflet/src/map/handler/Map.StateChanges.js |4 2 files changed, 83 insertions(+), 39 deletions(-) New commits: commit 13e28686016c033ae5060a65aa12c2400e9567c2 Author: Henry CastroDate: Thu Jan 11 13:51:30 2018 -0400 loleaflet: add page styles to header & footer Change-Id: Iaea6edeb819e2b750148c9ebb62b1acda4d4c951 Reviewed-on: https://gerrit.libreoffice.org/47773 Reviewed-by: Henry Castro Tested-by: Henry Castro diff --git a/loleaflet/src/control/Control.Menubar.js b/loleaflet/src/control/Control.Menubar.js index f9a1f6aa..55347ad5 100644 --- a/loleaflet/src/control/Control.Menubar.js +++ b/loleaflet/src/control/Control.Menubar.js @@ -66,8 +66,9 @@ L.Control.Menubar = L.Control.extend({ {name: _UNO('.uno:InsertAnnotation', 'text'), id: 'insertcomment', type: 'action'}, {type: 'separator'}, {name: _UNO('.uno:InsertHeaderFooterMenu', 'text'), type: 'menu', menu: [ - {uno: '.uno:InsertPageHeader'}, - {uno: '.uno:InsertPageFooter'}]}, + {uno: '.uno:InsertPageHeader', type: 'menu', menu: [{name: _('All'), disabled: true, id: 'insertheader', tag: '_ALL_', uno: '.uno:InsertPageHeader?'}]}, + {uno: '.uno:InsertPageFooter', type: 'menu', menu: [{name: _('All'), disabled: true, id: 'insertfooter', tag: '_ALL_', uno: '.uno:InsertPageFooter?'}]} + ]}, {uno: '.uno:InsertFootnote'}, {uno: '.uno:InsertEndnote'}, {type: 'separator'}, @@ -392,6 +393,7 @@ L.Control.Menubar = L.Control.extend({ map.on('doclayerinit', this._onDocLayerInit, this); map.on('addmenu', this._addMenu, this); map.on('commandvalues', this._onInitMenu, this); + map.on('updatetoolbarcommandvalues', this._onStyleMenu, this); }, _addMenu: function (e) { @@ -412,19 +414,26 @@ L.Control.Menubar = L.Control.extend({ this._menubarCont.insertBefore(liItem, this._menubarCont.firstChild); }, - _createLangMenuItem: function (lang, command) { + _createUnoMenuItem: function (caption, command, tag) { var liItem, aItem; liItem = L.DomUtil.create('li', ''); aItem = L.DomUtil.create('a', '', liItem); - $(aItem).text(lang); + $(aItem).text(caption); $(aItem).data('type', 'unocommand'); - $(aItem).data('uno', '.uno:LanguageStatus?Language:string=' + command); + $(aItem).data('uno', command); + $(aItem).data('tag', tag); return liItem; }, + _onInitMenu: function (e) { if (e.commandName === '.uno:LanguageStatus' && L.Util.isArray(e.commandValues)) { - var resetLang = _('Reset to Default Language'), translated, neutral; + var translated, neutral; + var constDefa = 'Default_RESET_LANGUAGES'; + var constCurr = 'Current_RESET_LANGUAGES'; + var constPara = 'Paragraph_RESET_LANGUAGES'; + var constLang = '.uno:LanguageStatus?Language:string='; + var resetLang = _('Reset to Default Language'); var languages = []; e.commandValues.forEach(function(language) { @@ -440,16 +449,33 @@ L.Control.Menubar = L.Control.extend({ for (var lang in languages) { translated = languages[lang].translated; neutral = languages[lang].neutral; - $menuSelection.append(this._createLangMenuItem(translated, encodeURIComponent('Current_' + neutral))); - $menuParagraph.append(this._createLangMenuItem(translated, encodeURIComponent('Paragraph_' + neutral))); - $menuDefault.append(this._createLangMenuItem(translated, encodeURIComponent('Default_' + neutral))); + $menuSelection.append(this._createUnoMenuItem(translated, constLang + encodeURIComponent('Current_' + neutral))); + $menuParagraph.append(this._createUnoMenuItem(translated, constLang + encodeURIComponent('Paragraph_' + neutral))); + $menuDefault.append(this._createUnoMenuItem(translated, constLang + encodeURIComponent('Default_' + neutral))); }
[Libreoffice-bugs] [Bug 114773] TOC: Remove additional space after chapter number in ToC
https://bugs.documentfoundation.org/show_bug.cgi?id=114773 Thomas Lendochanged: What|Removed |Added CC||yr...@mun.ca --- Comment #4 from Thomas Lendo --- *** Bug 115060 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115060] Chapter Numbering: Unwanted space after numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=115060 Thomas Lendochanged: What|Removed |Added Keywords|needsUXEval | Status|NEW |RESOLVED CC||thomas.le...@gmail.com Resolution|--- |DUPLICATE --- Comment #6 from Thomas Lendo --- Hi Yvan, thanks for your report. Your initial reported issue is indeed a duplicate of bug 114773 so I will set it as dupe. If you encounter another issue or inconsistency than the space-in-ToC problem, please file another bug(s). Regina: That the chapter numbering setting "followed by" (nothing/space/tab) doesn't effect is a good thing. It's for chapter appearance. ToC appearance should be handled separately and if you want a space/whatever between chapter number and text, you maybe don't want the same in a ToC. (I'll second that.) I wouldn't want to influence a ToC by the chapter numbering dialog. *** This bug has been marked as a duplicate of bug 114773 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115099] New: Pattern Field: Improve property names related to the masking operation.
https://bugs.documentfoundation.org/show_bug.cgi?id=115099 Bug ID: 115099 Summary: Pattern Field: Improve property names related to the masking operation. Product: LibreOffice Version: 6.0.0.0.beta2 Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bridgeportcontrac...@gmail.com Created attachment 139203 --> https://bugs.documentfoundation.org/attachment.cgi?id=139203=edit Screenshot of "Properties: Pattern Field" dialog If possible please improve these property names as follows: Rename Literal mask To Mask literals Rename Edit maskTo Mask operators An alternate name option: Rename Literal mask To Mask character constants Rename Edit maskTo Mask character filter selectors Rationale: As it is now, with the word "mask" following "Literal" and "Edit", it appears that these are two different masks. You don't say "Dog brown". Rather you say "Brown dog". The 2nd word (in this case "dog") is the thing itself. Actually these properties are not two masks but rather two inputs used together for one masking operation. 1) The first property is a set of character constants, one per character position. The word literal is fine, but because it's singular it suggests just one thing. "Literals" (plural) suggests a set of independent things, which is closer to what is happening here. (Each character position operates independently of other character positions, thus the idea of a mask.) 2) The second property is a set of function selectors, one per character position, which might also be called operators. Therefore I think the word "Mask" should be first to denote that these are both related to the mask, then should be followed by what the property actually is, in this case the dog is a either a set of character literals or a set of function selectors or operators. (Both plural.) BTW, "Edit" (in "Edit mask") isn't really right because we're not always editing. We might be creating, like with a new record. Also as it is now some users get confused and think this is like a regular expression or globbing type pattern, ref: https://ask.libreoffice.org/en/question/64386/cannot-enter-phone-numbers-into-pattern-field/ Making these plural, and denoting that they both feed into the mask should help with this confusion I think. _ Contrast this to the terminology for a "bit mask operation", where 01101110 are the "mask bits", and the mask operation is specified elsewhere, e.g. XOR, AND, etc. In this case the mask operation is just one thing performed over and over for each bit position, in other words it's a set of side by side XORs - or a plurality. To better reflect on what Pattern Field does, imagine if each bit position were dealt with differently, e.g. bit position 0 as ANDed, bit position 1 was XORed, bit position 2 ORed, etc. Then we might refer to "bit operators" - again plural. _ So changing these properties from singular to plural to me suggests that what follows is not one thing that operates as a whole, but rather a plurality of things that operate independently which is what actually happens. _ For reference, here are the mask operators: a - Alpha : Input a-z | A-Z-> Outputs a-z & A-Z A - Alpha upper : Input a-z | A-Z-> Outputs A-Z c - Alpha-numeric : Input a-z | A-Z, & 0-9 -> Outputs a-z, A-Z, & 0-9 C - Alpha-numeric upper : Input a-z | A-Z, & 0-9 -> Outputs A-Z, & 0-9 N - Numeric : Input 0-9 -> Outputs 0-9 x - Any : Input *-> Outputs * X - Any upper : Input *-> Outputs uppercase* L - Literal : Use the "Literal mask"'s character value for this character position, i.e. this position can not be edited. With the "upper" flavors `a-z` will be automatically converted to `A-Z`. With '*' all printable characters can be input, and are output just as they are or upper case converted. Thank you. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115098] New: Easily reorder table columns
https://bugs.documentfoundation.org/show_bug.cgi?id=115098 Bug ID: 115098 Summary: Easily reorder table columns Product: LibreOffice Version: 5.4.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: por...@narod.ru Description: Please make it easy to reorder table columns (and rows). This can flow into a number of features: 1. add menu items like "Move left", "Move right" (and for rows). 2. make it possible to reorder columns (and rows) with mouse D after a column is selected. Actual Results: no easy way to reorder Expected Results: reordering columns and rows should be easy Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.84 Safari/537.36 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40163] Export to PDF with size based on bounding box of selected objects
https://bugs.documentfoundation.org/show_bug.cgi?id=40163 V Stuart Footechanged: What|Removed |Added Component|Draw|Printing and PDF export -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115097] New: Menu item not localizable
https://bugs.documentfoundation.org/show_bug.cgi?id=115097 Bug ID: 115097 Summary: Menu item not localizable Product: LibreOffice Online Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: leiflod...@gmail.com Created attachment 139202 --> https://bugs.documentfoundation.org/attachment.cgi?id=139202=edit Screendump The menu item Tools - Word count... is not localizable. I checked both Danish ans Swedish version here: https://8de8bb4a-e089-44e4-9fc5-bc97b4c3eb89.pub.cloud.scaleway.com/nextcloud/index.php -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 41063] Saving/Autosaving (Save/Autosave) while in table causes view to jump to cursor position
https://bugs.documentfoundation.org/show_bug.cgi?id=41063 --- Comment #64 from V Stuart Foote--- (In reply to V Stuart Foote from comment #63) > *** Bug 114729 has been marked as a duplicate of this bug. *** Sorry. Dyslexia at play... ref issue is a duplicate of bug 40163 not this. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 41063] Saving/Autosaving (Save/Autosave) while in table causes view to jump to cursor position
https://bugs.documentfoundation.org/show_bug.cgi?id=41063 --- Comment #64 from V Stuart Foote--- (In reply to V Stuart Foote from comment #63) > *** Bug 114729 has been marked as a duplicate of this bug. *** Sorry. Dyslexia at play... ref issue is a duplicate of bug 40163 not this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114729] Libreoffice draw export as PDF in "selection" mode should create a tight bounding box around the selection
https://bugs.documentfoundation.org/show_bug.cgi?id=114729 --- Comment #3 from V Stuart Foote--- Oops, lets mark that with the correct duplicate... *** This bug has been marked as a duplicate of bug 40163 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40163] Export to PDF with size based on bounding box of selected objects
https://bugs.documentfoundation.org/show_bug.cgi?id=40163 V Stuart Footechanged: What|Removed |Added CC||sergio.calleg...@gmail.com --- Comment #33 from V Stuart Foote --- *** Bug 114729 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 114729] Libreoffice draw export as PDF in "selection" mode should create a tight bounding box around the selection
https://bugs.documentfoundation.org/show_bug.cgi?id=114729 V Stuart Footechanged: What|Removed |Added Keywords|needsUXEval |filter:pdf Status|UNCONFIRMED |RESOLVED CC|libreoffice-ux-advise@lists |vstuart.fo...@utsa.edu |.freedesktop.org| Resolution|--- |DUPLICATE --- Comment #2 from V Stuart Foote --- Yep, valid, but a long recognized issue, to => DUP The pdfio filter needs to be tweaked. *** This bug has been marked as a duplicate of bug 41063 *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 41063] Saving/Autosaving (Save/Autosave) while in table causes view to jump to cursor position
https://bugs.documentfoundation.org/show_bug.cgi?id=41063 V Stuart Footechanged: What|Removed |Added CC||sergio.calleg...@gmail.com --- Comment #63 from V Stuart Foote --- *** Bug 114729 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 41063] Saving/Autosaving (Save/Autosave) while in table causes view to jump to cursor position
https://bugs.documentfoundation.org/show_bug.cgi?id=41063 V Stuart Footechanged: What|Removed |Added CC||sergio.calleg...@gmail.com --- Comment #63 from V Stuart Foote --- *** Bug 114729 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 114729] Libreoffice draw export as PDF in "selection" mode should create a tight bounding box around the selection
https://bugs.documentfoundation.org/show_bug.cgi?id=114729 V Stuart Footechanged: What|Removed |Added Keywords|needsUXEval |filter:pdf Status|UNCONFIRMED |RESOLVED CC|libreoffice-ux-advise@lists |vstuart.fo...@utsa.edu |.freedesktop.org| Resolution|--- |DUPLICATE --- Comment #2 from V Stuart Foote --- Yep, valid, but a long recognized issue, to => DUP The pdfio filter needs to be tweaked. *** This bug has been marked as a duplicate of bug 41063 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115096] New: For a Pattern Field please reverse the order of the mask related properties
https://bugs.documentfoundation.org/show_bug.cgi?id=115096 Bug ID: 115096 Summary: For a Pattern Field please reverse the order of the mask related properties Product: LibreOffice Version: 6.0.0.0.beta2 Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bridgeportcontrac...@gmail.com Created attachment 139201 --> https://bugs.documentfoundation.org/attachment.cgi?id=139201=edit Screenshot of "Properties: Pattern Field" dialog Please see attached snapshot for how the properties for a Pattern Field are currently organized in the dialog. As it is now the "Literal mask" property is positioned below the "Edit mask" property. Suggestion: Reorder properties for a Formatted Field and put "Literal mask" before "Edit mask", i.e. reverse them. Reason: You will probably always want to write the literal first. For example, for a standard phone number you would write: (___) ___- <- this is probably the first thing you would write. LNNNLLNNNL <- then you would use that to write this. It would be less obvious to first write: LNNNLLNNNL, until you had the (___) ___- in mind. Thank you! _ (Note: I plan to subsequently submit an enhancement request to rename these two properties. These names do not accurately reflect what these properties are, i.e. it appears there are two masks operations, Edit and Literal, but in fact there is just one mask operation with two input parameters.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115094] FILEOPEN: DOCX: Image in table is misplaced
https://bugs.documentfoundation.org/show_bug.cgi?id=115094 Dieter Praaschanged: What|Removed |Added Blocks||10 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=10 [Bug 10] [META] DOCX (OOXML) table-related issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=10 Dieter Praaschanged: What|Removed |Added Depends on||115094 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115094 [Bug 115094] FILEOPEN: DOCX: Image in table is misplaced -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109518] notebookbar does not render rightly at 1366 * 768 resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=109518 --- Comment #2 from daved3...@gmail.com --- Created attachment 139200 --> https://bugs.documentfoundation.org/attachment.cgi?id=139200=edit Notebookbar scaling issues I've got issues with notebookbar scaling and placement with some variants at version 5.4.4.2. Screen resolution is 1280x800, happened in every other linux machine i have installed that Groupedbar Full and Groupedbar Compact didn't scale correctly. I think that the problem may be matter of design. When the main window width is resized, elements dissapear, but resizing it to a bigger scale than that of my screen resolution "fixes" the problem. Similar situation for the tabbed one, it will move some tabs over the rest when there's is obviusly more than enough space. I've got some screens. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115081] Data | Validity restriction can be violated by coping value into the field
https://bugs.documentfoundation.org/show_bug.cgi?id=115081 Thomas Lendochanged: What|Removed |Added Blocks||108988 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108988 [Bug 108988] [META] Validity-related bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108988] [META] Validity-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108988 Thomas Lendochanged: What|Removed |Added Depends on||115081 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115081 [Bug 115081] Data | Validity restriction can be violated by coping value into the field -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
minutes of ESC call ...
* Present: + Miklos, Xisco, Olivier, Heiko, Stephan, Eike, Sophie, Christian, + Samuel, Michael S, Caolan, Michael M, Thorsten, David, Kendy * Completed Action Items: + review HTML patch and submit [ tested on Mac & Windows and will merge to master (Olivier) ] * Pending Action Items: + come up with a list of retiring committers to mail (Norbert) * Release Engineering update (Christian) + no release this week + 5.4.5 RC1 – last week of Jan – right before FOSDEM. + 6.0 RC3 – due next week + announce planned last week of Jan. + late features + gpg4libre branch (Thorsten) [ should all be in plus a bug-fix corner-case crash when people don’t have gpg installed, looks good for 6.0 ] + please remember to cherry-pick to libreoffice-6-0-0 +2 reviews for the final release. + Android + patches getting committed now; some reviews from Thorsten. + poking the Android tinderbox before doing a test release. + builds with bundled cairo: some memory wins (Michael) + Online + pending rc3 next. * Documentation (Olivier) + Patch for activating new local help (olivier) + next: test packaging. + Books: + Still working on GS 6.0 book w/ community. + Started Calc Guide Update * UX Update (Heiko) + Bugzilla (topicUI) statistics 254(254) (topicUI) bugs open, 317(317) (needsUXEval) needs to be evaluated by the UXteam + Updates: BZ changes 1 week1 month 3 months 12 months added 1(-4) 9(-2)32(-4) 109(-2) commented 34(-11) 154(8)514(-25) 2084(-39) removed 0(0) 0(0) 2(0) 18(-3) resolved 5(3) 19(2) 54(1) 227(-7) + top 10 contributors: Tietze, Heiko made 56 changes in 1 month, and 985 changes in 1 year Thomas Linard made 46 changes in 1 month, and 46 changes in 1 year Philips, Yousuf made 39 changes in 1 month, and 803 changes in 1 year Foote, V Stuart made 25 changes in 1 month, and 324 changes in 1 year Cor Nouws made 19 changes in 1 month, and 184 changes in 1 year Xisco Faulí made 18 changes in 1 month, and 399 changes in 1 year Buovjaga made 18 changes in 1 month, and 219 changes in 1 year Thomas Lendo made 12 changes in 1 month, and 414 changes in 1 year Henschel, Regina made 10 changes in 1 month, and 127 changes in 1 year Telesto made 9 changes in 1 month, and 81 changes in 1 year + Discussed how direct formatting and styles are applied and reverted + (tdf#112852) with the suggestion of a style inspector → good topic for newbies + another one might be to rework shortcut assignment + KEY_A = A != KEY_ = some non-latin char + two new people are showing up looking for easyhacks + (Abhishek Shrivastava – quickstarter & another). * Crash Hunting (Caolan) + 80(+2) import failure, 760 (+760) export failures + still some calc threading issues pending. + 12 coverity + 44 fuzzers * 3 sanitizers+engine combos (asan+libfuzzer, ubsan+libfuzzer, asan+afl), writer html last added + html an exciting set * Crash Reporter (Xisco) + http://crashreport.libreoffice.org/stats/version/5.3.6.1 + 1020 (last 7 days) (down) + http://crashreport.libreoffice.org/stats/version/5.3.7.2 + 1347 (last 7 days) (-) + http://crashreport.libreoffice.org/stats/version/5.4.3.2 + 2297 (last 7 days) (down) + http://crashreport.libreoffice.org/stats/version/5.4.4.2 + 1353 (last 7 days) (up) * GSOC Application (Thorsten) + Markus working on it; deadline Tues 23rd + ~90% done * Hackfests & Events (Michael) + FOSDEM hack-fest / meetings + dates confirmed (Monday + Tuesday), book your travel! + Hotel: La Grande Cloche over the street. + https://wiki.documentfoundation.org/Hackfest/FOSDEM2018 + Hamburg TNG – 1st new-style hackfest + outlined for April 7/8th. + https://wiki.documentfoundation.org/Hackfests/HackfestTNG + checkout the tender for mentoring: + https://blog.documentfoundation.org/blog/2018/01/16/tender-consultancy-libreoffice-feature-implementation-incl-site-development-training-201801-01/ + layers issues – one a dup; a large problem domain here. + still looking for people who want help learning how to fix their problems interactively at a hackfest. * mentoring/easyhack update committer... 1 week 1 month 3 months12 months open 73(-3) 137(-13) 139(-15) 142(-15) reviews 604(-13) 1762(3) 5008(215) 18666(-9) merged 262(-51) 1062(-124) 3686(143) 12013(49) abandoned 21(8)
[Libreoffice-qa] minutes of ESC call ...
* Present: + Miklos, Xisco, Olivier, Heiko, Stephan, Eike, Sophie, Christian, + Samuel, Michael S, Caolan, Michael M, Thorsten, David, Kendy * Completed Action Items: + review HTML patch and submit [ tested on Mac & Windows and will merge to master (Olivier) ] * Pending Action Items: + come up with a list of retiring committers to mail (Norbert) * Release Engineering update (Christian) + no release this week + 5.4.5 RC1 – last week of Jan – right before FOSDEM. + 6.0 RC3 – due next week + announce planned last week of Jan. + late features + gpg4libre branch (Thorsten) [ should all be in plus a bug-fix corner-case crash when people don’t have gpg installed, looks good for 6.0 ] + please remember to cherry-pick to libreoffice-6-0-0 +2 reviews for the final release. + Android + patches getting committed now; some reviews from Thorsten. + poking the Android tinderbox before doing a test release. + builds with bundled cairo: some memory wins (Michael) + Online + pending rc3 next. * Documentation (Olivier) + Patch for activating new local help (olivier) + next: test packaging. + Books: + Still working on GS 6.0 book w/ community. + Started Calc Guide Update * UX Update (Heiko) + Bugzilla (topicUI) statistics 254(254) (topicUI) bugs open, 317(317) (needsUXEval) needs to be evaluated by the UXteam + Updates: BZ changes 1 week1 month 3 months 12 months added 1(-4) 9(-2)32(-4) 109(-2) commented 34(-11) 154(8)514(-25) 2084(-39) removed 0(0) 0(0) 2(0) 18(-3) resolved 5(3) 19(2) 54(1) 227(-7) + top 10 contributors: Tietze, Heiko made 56 changes in 1 month, and 985 changes in 1 year Thomas Linard made 46 changes in 1 month, and 46 changes in 1 year Philips, Yousuf made 39 changes in 1 month, and 803 changes in 1 year Foote, V Stuart made 25 changes in 1 month, and 324 changes in 1 year Cor Nouws made 19 changes in 1 month, and 184 changes in 1 year Xisco Faulí made 18 changes in 1 month, and 399 changes in 1 year Buovjaga made 18 changes in 1 month, and 219 changes in 1 year Thomas Lendo made 12 changes in 1 month, and 414 changes in 1 year Henschel, Regina made 10 changes in 1 month, and 127 changes in 1 year Telesto made 9 changes in 1 month, and 81 changes in 1 year + Discussed how direct formatting and styles are applied and reverted + (tdf#112852) with the suggestion of a style inspector → good topic for newbies + another one might be to rework shortcut assignment + KEY_A = A != KEY_ = some non-latin char + two new people are showing up looking for easyhacks + (Abhishek Shrivastava – quickstarter & another). * Crash Hunting (Caolan) + 80(+2) import failure, 760 (+760) export failures + still some calc threading issues pending. + 12 coverity + 44 fuzzers * 3 sanitizers+engine combos (asan+libfuzzer, ubsan+libfuzzer, asan+afl), writer html last added + html an exciting set * Crash Reporter (Xisco) + http://crashreport.libreoffice.org/stats/version/5.3.6.1 + 1020 (last 7 days) (down) + http://crashreport.libreoffice.org/stats/version/5.3.7.2 + 1347 (last 7 days) (-) + http://crashreport.libreoffice.org/stats/version/5.4.3.2 + 2297 (last 7 days) (down) + http://crashreport.libreoffice.org/stats/version/5.4.4.2 + 1353 (last 7 days) (up) * GSOC Application (Thorsten) + Markus working on it; deadline Tues 23rd + ~90% done * Hackfests & Events (Michael) + FOSDEM hack-fest / meetings + dates confirmed (Monday + Tuesday), book your travel! + Hotel: La Grande Cloche over the street. + https://wiki.documentfoundation.org/Hackfest/FOSDEM2018 + Hamburg TNG – 1st new-style hackfest + outlined for April 7/8th. + https://wiki.documentfoundation.org/Hackfests/HackfestTNG + checkout the tender for mentoring: + https://blog.documentfoundation.org/blog/2018/01/16/tender-consultancy-libreoffice-feature-implementation-incl-site-development-training-201801-01/ + layers issues – one a dup; a large problem domain here. + still looking for people who want help learning how to fix their problems interactively at a hackfest. * mentoring/easyhack update committer... 1 week 1 month 3 months12 months open 73(-3) 137(-13) 139(-15) 142(-15) reviews 604(-13) 1762(3) 5008(215) 18666(-9) merged 262(-51) 1062(-124) 3686(143) 12013(49) abandoned 21(8)