date:20180126

https://bugs.documentfoundation.org/show_bug.cgi?id=73976

--- Comment #17 from Xisco Faulí  ---
Created attachment 139381
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139381=edit
How it looks in LibreOffice 6.1

They look pretty similar in

Version: 6.1.0.0.alpha0+
Build ID: 5cb225b0b3dbb55fd44899b1fb16bdcfeb866849
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114747] mailmerge wizard freezes in window 'personal salutation' under ubuntu

https://bugs.documentfoundation.org/show_bug.cgi?id=114747

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #3 from Buovjaga  ---
LibreOffice 5.1 is quite old. Please test with a fresh version. With an
appimage you can very easily test even a pre-release:
http://libreoffice.soluzioniopen.com/

Set to NEEDINFO.
Change back to UNCONFIRMED, if the problem persists. Change to RESOLVED
WORKSFORME, if the problem went away.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114721] Special char: find the char by drawing it

https://bugs.documentfoundation.org/show_bug.cgi?id=114721

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #4 from Buovjaga  ---
Let's put status to NEW as this is accepted to its own branch etc.:
https://cgit.freedesktop.org/libreoffice/core/log/?h=private/bansan/chardraw

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94416] FILESAVE: Don't change Qiqqa citation cluster objects

https://bugs.documentfoundation.org/show_bug.cgi?id=94416

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||xiscofa...@libreoffice.org
 Resolution|--- |WORKSFORME

--- Comment #8 from Xisco Faulí  ---
No longer reproducible in

Version: 6.1.0.0.alpha0+
Build ID: 5cb225b0b3dbb55fd44899b1fb16bdcfeb866849
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded

Closing as RESOLVED WORKSFORME

[Improvement found by office-interoperability-tools]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115246] New: Unable to open xls (SpreadsheetML, XML Spreadsheet 2003, or XMLSS) on LibreOffice v5.4.4.2

https://bugs.documentfoundation.org/show_bug.cgi?id=115246

Bug ID: 115246
   Summary: Unable to open xls (SpreadsheetML, XML Spreadsheet
2003, or XMLSS) on LibreOffice v5.4.4.2
   Product: LibreOffice
   Version: 5.4.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: asiel.l...@stic.cl

Description:
I have does the installation of LibreOffice on my organization and they can
open all documents except one, a .xls file (SpreadsheetML, XML Spreadsheet
2003, or XMLSS) who it´s generated from a third party CRM and i can´t change de
code. 

I had googling that for more than two days and i can´t find a solution for
that, that it´s a very important file for the organization.  
the file code it´s ok for Microsoft Office.

Thanks in advance.

Steps to Reproduce:
1.Open the file
2.Select codification ISO-8859-1
3.Accept

Actual Results:  
The file open like text code, not like regular spreadsheet

Expected Results:
Open the file like a spreadsheet


Reproducible: Didn't try


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Version: 5.4.4.2 (x64)
Build ID: 2524958677847fb3bb44820e40380acbe820f960
CPU threads: 4; OS: Windows 6.19; UI render: default; 
Locale: en-US (en_US); Calc: group


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97950] FILEOPEN RTF layout problem with extra pages

https://bugs.documentfoundation.org/show_bug.cgi?id=97950

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #6 from Xisco Faulí  ---
The document has 14 pages now

Version: 6.1.0.0.alpha0+
Build ID: 5cb225b0b3dbb55fd44899b1fb16bdcfeb866849
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - 11 commits - config_host/config_gtk3_kde5.h.in config_host/config_kde5.h.in config_host/config_qt5.h.in config_host/con

2018-01-26 Thread Milian Wolff

 Repository.mk  |7 
 RepositoryExternal.mk  |   64 ++
 config_host.mk.in  |   14 
 config_host/config_gtk3_kde5.h.in  |   10 
 config_host/config_kde5.h.in   |   10 
 config_host/config_qt5.h.in|   11 
 config_host/config_vclplug.h.in|1 
 configure.ac   |  237 +
 postprocess/Rdb_services.mk|3 
 scp2/InstallScript_setup_osl.mk|2 
 scp2/Module_scp2.mk|2 
 shell/Library_kde5be.mk|   32 +
 shell/Module_shell.mk  |6 
 shell/source/backends/desktopbe/desktopbackend.cxx |4 
 shell/source/backends/kde5be/kde5access.cxx|  316 
 shell/source/backends/kde5be/kde5access.hxx|   48 +
 shell/source/backends/kde5be/kde5backend.cxx   |  252 +
 shell/source/backends/kde5be/kde5be1.component |   25 
 vcl/CustomTarget_gtk3_kde5_moc.mk  |   22 
 vcl/Executable_lo_kde5filepicker.mk|   98 +++
 vcl/Library_vclplug_gtk3_kde5.mk   |  127 
 vcl/Module_vcl.mk  |7 
 vcl/unx/generic/plugadapt/salplug.cxx  |5 
 vcl/unx/gtk3_kde5/FPServiceInfo.hxx|   28 +
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkaction.cxx |   12 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkbridge.cxx |   12 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkcomponent.cxx  |   12 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkeditabletext.cxx   |   12 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkfactory.cxx|   12 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkhypertext.cxx  |   12 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkimage.cxx  |   12 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atklistener.cxx   |   12 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkregistry.cxx   |   12 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkselection.cxx  |   12 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atktable.cxx  |   12 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atktext.cxx   |   12 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atktextattributes.cxx |   12 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkutil.cxx   |   12 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkvalue.cxx  |   12 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkwindow.cxx |   12 
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkwrapper.cxx|   12 
 vcl/unx/gtk3_kde5/filepicker_ipc_commands.hxx  |  161 ++
 vcl/unx/gtk3_kde5/gtk3_kde5_a11y.cxx   |   38 +
 vcl/unx/gtk3_kde5/gtk3_kde5_cairo.cxx  |   22 
 vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.cxx |  432 +
 vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.hxx |  136 +
 vcl/unx/gtk3_kde5/gtk3_kde5_filepicker_ipc.cxx |  259 ++
 vcl/unx/gtk3_kde5/gtk3_kde5_filepicker_ipc.hxx |  113 
 vcl/unx/gtk3_kde5/gtk3_kde5_folderpicker.cxx   |   88 +++
 vcl/unx/gtk3_kde5/gtk3_kde5_folderpicker.hxx   |   61 ++
 vcl/unx/gtk3_kde5/gtk3_kde5_gloactiongroup.cxx |   22 
 vcl/unx/gtk3_kde5/gtk3_kde5_glomenu.cxx|   22 
 vcl/unx/gtk3_kde5/gtk3_kde5_gtkdata.cxx|   22 
 vcl/unx/gtk3_kde5/gtk3_kde5_gtkframe.cxx   |   22 
 vcl/unx/gtk3_kde5/gtk3_kde5_gtkinst.cxx|   55 ++
 vcl/unx/gtk3_kde5/gtk3_kde5_gtkobject.cxx  |   22 
 vcl/unx/gtk3_kde5/gtk3_kde5_gtksalmenu.cxx |   22 
 vcl/unx/gtk3_kde5/gtk3_kde5_gtksys.cxx |   22 
 vcl/unx/gtk3_kde5/gtk3_kde5_hudawareness.cxx   |   22 
 vcl/unx/gtk3_kde5/gtk3_kde5_printwrapper.cxx   |   22 
 vcl/unx/gtk3_kde5/gtk3_kde5_salnativewidgets-gtk.cxx   |   22 
 vcl/unx/gtk3_kde5/gtk3_kde5_salprn-gtk.cxx |   22 
 vcl/unx/gtk3_kde5/kde5_filepicker.cxx  |  245 +
 vcl/unx/gtk3_kde5/kde5_filepicker.hxx  |  110 
 vcl/unx/gtk3_kde5/kde5_filepicker_ipc.cxx  |  246 +
 vcl/unx/gtk3_kde5/kde5_filepicker_ipc.hxx  |   45 +
 vcl/unx/gtk3_kde5/kde5_lo_filepicker_main.cxx  |   54 ++
 67 files changed, 3839 insertions(+), 3 deletions(-)

New commits:
commit 93a0865bcd6260d36450c37afdf509d8b6e7d253
Author: Milian Wolff 
Date:   Thu Jan 25 14:08:28 2018 +0100

lo_kde5filepicker: cleanup main and add version and help options

This way users can figure out what this tool is about. Most notably,
you can run it now with `-h, --help` as one would expect.

Change-Id: If8dd3142bdcc96d2962a2647b2187d75666b9394
(cherry picked from commit 63d9c1f8bf94ea16f08e78a5f2667d5e4d96c22e)

diff --git

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sw/source

2018-01-26 Thread Fyodor Yemelyanenko

 sw/source/core/undo/untblk.cxx |   73 +++--
 1 file changed, 56 insertions(+), 17 deletions(-)

New commits:
commit b9d14fbad622a05320eb90211ae2ba89edfb8148
Author: Fyodor Yemelyanenko 
Date:   Thu Nov 16 17:06:28 2017 +1000

tdf#94225 - Writer crashes on Undo N times
when document contains flys anchored to paragraph.

Change-Id: I628ef10b1e7817b554afee5e3c8733c1a128b201
Reviewed-on: https://gerrit.libreoffice.org/44800
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 
(cherry picked from commit 70483089425d5bb22e036867290e06a6fc8d99fb)
Reviewed-on: https://gerrit.libreoffice.org/48697
Tested-by: Jenkins 

diff --git a/sw/source/core/undo/untblk.cxx b/sw/source/core/undo/untblk.cxx
index 9b44e00522ea..d00210353875 100644
--- a/sw/source/core/undo/untblk.cxx
+++ b/sw/source/core/undo/untblk.cxx
@@ -49,22 +49,24 @@ SwUndoInserts::SwUndoInserts( SwUndoId nUndoId, const 
SwPaM& rPam )
 if( pTextNd->HasSwAttrSet() )
 pHistory->CopyFormatAttr( *pTextNd->GetpSwAttrSet(), nSttNode );
 
-if( !nSttContent )// than take the Flys along
+// We may have some flys anchored to paragraph where we inserting.
+// These flys will be saved in pFrameFormats array (only flys which 
exist BEFORE insertion!)
+// Then in SwUndoInserts::SetInsertRange the flys saved in 
pFrameFormats will NOT create Undos.
+// m_FlyUndos will only be filled with newly inserted flys.
+
+const size_t nArrLen = pDoc->GetSpzFrameFormats()->size();
+for( size_t n = 0; n < nArrLen; ++n )
 {
-const size_t nArrLen = pDoc->GetSpzFrameFormats()->size();
-for( size_t n = 0; n < nArrLen; ++n )
+SwFrameFormat* pFormat = (*pDoc->GetSpzFrameFormats())[n];
+SwFormatAnchor const*const  pAnchor = >GetAnchor();
+const SwPosition* pAPos = pAnchor->GetContentAnchor();
+if (pAPos &&
+(pAnchor->GetAnchorId() == RndStdIds::FLY_AT_PARA) &&
+ nSttNode == pAPos->nNode.GetIndex() )
 {
-SwFrameFormat* pFormat = (*pDoc->GetSpzFrameFormats())[n];
-SwFormatAnchor const*const  pAnchor = >GetAnchor();
-const SwPosition* pAPos = pAnchor->GetContentAnchor();
-if (pAPos &&
-(pAnchor->GetAnchorId() == RndStdIds::FLY_AT_PARA) &&
- nSttNode == pAPos->nNode.GetIndex() )
-{
-if( !pFrameFormats )
-pFrameFormats = new std::vector;
-pFrameFormats->push_back( pFormat );
-}
+if( !pFrameFormats )
+pFrameFormats = new std::vector;
+pFrameFormats->push_back( pFormat );
 }
 }
 }
@@ -76,7 +78,18 @@ SwUndoInserts::SwUndoInserts( SwUndoId nUndoId, const SwPaM& 
rPam )
 }
 }
 
-// set destination after reading input
+// This method does two things:
+// 1. Adjusts SwUndoRng members, required for Undo.
+//  Members are:
+//  SwUndoRng::nSttNode - all nodes starting from this node will be deleted 
during Undo (in SwUndoInserts::UndoImpl)
+//  SwUndoRng::nSttContent - corresponding content index in SwUndoRng::nSttNode
+//  SwUndoRng::nEndNode - end node for deletion
+//  SwUndoRng::nEndContent - end content index
+// All these members are filled in during construction of SwUndoInserts 
instance, and can be adjusted using this method
+//
+// 2. Fills in m_FlyUndos array with flys anchored ONLY to first and last 
paragraphs (first == rPam.Start(), last == rPam.End())
+//  Flys, anchored to any paragraph, but not first and last, are handled by 
DelContentIndex (see SwUndoInserts::UndoImpl) and are not stored in m_FlyUndos.
+
 void SwUndoInserts::SetInsertRange( const SwPaM& rPam, bool bScanFlys,
 bool bSttIsTextNd )
 {
@@ -100,7 +113,9 @@ void SwUndoInserts::SetInsertRange( const SwPaM& rPam, bool 
bScanFlys,
 }
 }
 
-if( bScanFlys && !nSttContent )
+// Fill m_FlyUndos with flys anchored to first and last paragraphs
+
+if( bScanFlys)
 {
 // than collect all new Flys
 SwDoc* pDoc = rPam.GetDoc();
@@ -112,7 +127,7 @@ void SwUndoInserts::SetInsertRange( const SwPaM& rPam, bool 
bScanFlys,
 SwPosition const*const pAPos = pAnchor->GetContentAnchor();
 if (pAPos &&
 (pAnchor->GetAnchorId() == RndStdIds::FLY_AT_PARA) &&
-nSttNode == pAPos->nNode.GetIndex() )
+(nSttNode == pAPos->nNode.GetIndex() || nEndNode == 
pAPos->nNode.GetIndex()))
 {
 std::vector::iterator it;
 if( !pFrameFormats ||
@@ -145,6 +160,27 @@ SwUndoInserts::~SwUndoInserts()

[Libreoffice-bugs] [Bug 115245] New: tiny icons for table windows in base

https://bugs.documentfoundation.org/show_bug.cgi?id=115245

Bug ID: 115245
   Summary: tiny icons for table windows in base
   Product: LibreOffice
   Version: 5.4.2.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: robert.jean.le...@wanadoo.fr

Description:
so tiny as unreadable
this was in Ambiance or Radiance Gtk theme
changing for the only other theme (High Contrast) solves

Steps to Reproduce:
1.run LO base
2.display a table
3.

Actual Results:  
low border icons so tiny that unusable

Expected Results:
usable icons


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: fr
Module: FormDesign
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:58.0) Gecko/20100101
Firefox/58.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114653] using more than x custom properties in templates causes high CPU usage

https://bugs.documentfoundation.org/show_bug.cgi?id=114653

--- Comment #8 from Caolán McNamara  ---
The patch backported to 5-4 is the fix of
http://cgit.freedesktop.org/libreoffice/core/commit/?id=272a96da03522a82db4185e7858d05375f3ea95e
for bug 100922

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109072] [META] XLS (binary) format bug tracker

https://bugs.documentfoundation.org/show_bug.cgi?id=109072
Bug 109072 depends on bug 114221, which changed state.

Bug 114221 Summary: Calc corrupts password-protected XLS on save (Save as 
works) - newer MSO 2013 encryption saved as unencrypted file with encryption 
mode
https://bugs.documentfoundation.org/show_bug.cgi?id=114221

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108914] [META] Password protected file bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=108914
Bug 108914 depends on bug 114221, which changed state.

Bug 114221 Summary: Calc corrupts password-protected XLS on save (Save as 
works) - newer MSO 2013 encryption saved as unencrypted file with encryption 
mode
https://bugs.documentfoundation.org/show_bug.cgi?id=114221

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: filter/source include/filter

 filter/source/msfilter/mscodec.cxx  |   25 +++--
 include/filter/msfilter/mscodec.hxx |8 ++--
 2 files changed, 25 insertions(+), 8 deletions(-)

New commits:
commit 2372003d94d3c58d90f6af524e916a2aa761cee2
Author: Caolán McNamara 
Date:   Fri Jan 26 10:47:24 2018 +

Resolves: tdf#114221 generate both std97 and cryptoapi keys from password..

when we open a cryptoapi encrypted binary msoffice document. That way when 
we
save as the same format, and try to reuse the generated keys for 
encryption, we
have matching std97 encryption keys available because we always export using
that scheme.

Change-Id: I25f24a01d102242615768255ce888acb08ef6447
Reviewed-on: https://gerrit.libreoffice.org/48680
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/filter/source/msfilter/mscodec.cxx 
b/filter/source/msfilter/mscodec.cxx
index c4c0a4c83c85..975c9078dd1d 100644
--- a/filter/source/msfilter/mscodec.cxx
+++ b/filter/source/msfilter/mscodec.cxx
@@ -245,8 +245,9 @@ void MSCodec_Xor95::Skip( std::size_t nBytes )
 mnOffset = (mnOffset + nBytes) & 0x0F;
 }
 
-MSCodec97::MSCodec97(size_t nHashLen)
-: m_nHashLen(nHashLen)
+MSCodec97::MSCodec97(size_t nHashLen, const OUString& rEncKeyName)
+: m_sEncKeyName(rEncKeyName)
+, m_nHashLen(nHashLen)
 , m_hCipher(rtl_cipher_create(rtl_Cipher_AlgorithmARCFOUR, 
rtl_Cipher_ModeStream))
 , m_aDocId(16, 0)
 , m_aDigestValue(nHashLen, 0)
@@ -255,14 +256,14 @@ MSCodec97::MSCodec97(size_t nHashLen)
 }
 
 MSCodec_Std97::MSCodec_Std97()
-: MSCodec97(RTL_DIGEST_LENGTH_MD5)
+: MSCodec97(RTL_DIGEST_LENGTH_MD5, "STD97EncryptionKey")
 {
 m_hDigest = rtl_digest_create(rtl_Digest_AlgorithmMD5);
 assert(m_hDigest != nullptr);
 }
 
 MSCodec_CryptoAPI::MSCodec_CryptoAPI()
-: MSCodec97(RTL_DIGEST_LENGTH_SHA1)
+: MSCodec97(RTL_DIGEST_LENGTH_SHA1, "CryptoAPIEncryptionKey")
 {
 }
 
@@ -300,7 +301,7 @@ bool MSCodec97::InitCodec( const uno::Sequence< 
beans::NamedValue >& aData )
 bool bResult = false;
 
 ::comphelper::SequenceAsHashMap aHashData( aData );
-uno::Sequence< sal_Int8 > aKey = 
aHashData.getUnpackedValueOrDefault("STD97EncryptionKey", uno::Sequence< 
sal_Int8 >() );
+uno::Sequence aKey = 
aHashData.getUnpackedValueOrDefault(m_sEncKeyName, uno::Sequence());
 const size_t nKeyLen = aKey.getLength();
 if (nKeyLen == m_nHashLen)
 {
@@ -328,7 +329,7 @@ uno::Sequence< beans::NamedValue > 
MSCodec97::GetEncryptionData()
 {
 ::comphelper::SequenceAsHashMap aHashData;
 assert(m_aDigestValue.size() == m_nHashLen);
-aHashData[ OUString( "STD97EncryptionKey" ) ] <<= uno::Sequence< sal_Int8 
>( reinterpret_cast(m_aDigestValue.data()), m_nHashLen );
+aHashData[m_sEncKeyName] <<= 
uno::Sequence(reinterpret_cast(m_aDigestValue.data()), 
m_nHashLen);
 aHashData[ OUString( "STD97UniqueID" ) ] <<= uno::Sequence< sal_Int8 >( 
reinterpret_cast(m_aDocId.data()), m_aDocId.size() );
 
 return aHashData.getAsConstNamedValueList();
@@ -384,6 +385,9 @@ void MSCodec_CryptoAPI::InitKey (
 (void)memcpy(m_aDocId.data(), pDocId, 16);
 
 lcl_PrintDigest(m_aDocId.data(), "DocId value");
+
+//generate the old format key while we have the required data
+m_aStd97Key = ::comphelper::DocPasswordHelper::GenerateStd97Key(pPassData, 
pDocId);
 }
 
 bool MSCodec97::VerifyKey(const sal_uInt8* pSaltData, const sal_uInt8* 
pSaltDigest)
@@ -483,6 +487,15 @@ bool MSCodec_CryptoAPI::InitCipher(sal_uInt32 nCounter)
 return (result == rtl_Cipher_E_None);
 }
 
+uno::Sequence MSCodec_CryptoAPI::GetEncryptionData()
+{
+::comphelper::SequenceAsHashMap aHashData(MSCodec97::GetEncryptionData());
+//add in the old encryption key as well as our new key so saving using the
+//old crypto scheme can be done without reprompt for the password
+aHashData[OUString("STD97EncryptionKey")] <<= m_aStd97Key;
+return aHashData.getAsConstNamedValueList();
+}
+
 void MSCodec_Std97::CreateSaltDigest( const sal_uInt8 nSaltData[16], sal_uInt8 
nSaltDigest[16] )
 {
 #if DEBUG_MSO_ENCRYPTION_STD97
diff --git a/include/filter/msfilter/mscodec.hxx 
b/include/filter/msfilter/mscodec.hxx
index b0ab818449ae..aa38f6e9fc00 100644
--- a/include/filter/msfilter/mscodec.hxx
+++ b/include/filter/msfilter/mscodec.hxx
@@ -178,7 +178,7 @@ public:
 class MSFILTER_DLLPUBLIC MSCodec97
 {
 public:
-MSCodec97(size_t nHashLen);
+MSCodec97(size_t nHashLen, const OUString& rEncKeyName);
 virtual ~MSCodec97();
 
 /** Initializes the algorithm with the encryption data.
@@ -195,7 +195,7 @@ public:
 The sequence contains the necessary data to initialize
 the codec.
  */
-css::uno::Sequence< css::beans::NamedValue > GetEncryptionData();
+virtual css::uno::Sequence

[Libreoffice-commits] online.git: kit/Kit.cpp

 kit/Kit.cpp |   24 
 1 file changed, 24 insertions(+)

New commits:
commit 1d22f7bc548dc48c95390c6f23b67f1972825617
Author: Pranav Kant 
Date:   Fri Jan 26 21:04:49 2018 +0530

kit: start spamming the logs when linking/copying is slowww

This is sometimes the case in docker when the link operation 'copies up'
things from lower layers to the working docker container's layer. In
such cases, let the admin know.

Change-Id: Ib72b67304a292c3832838379cc76bcb4a7268cb3
Reviewed-on: https://gerrit.libreoffice.org/48710
Reviewed-by: pranavk 
Tested-by: pranavk 

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index f38af663..c853b3ed 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -120,6 +120,9 @@ namespace
 LinkOrCopyType linkOrCopyType;
 std::string sourceForLinkOrCopy;
 Path destinationForLinkOrCopy;
+std::chrono::time_point linkOrCopyStartTime;
+bool linkOrCopyVerboseLogging = false;
+unsigned slowLinkOrCopyLimitInSecs = 10; // after this much seconds, start 
spamming the logs
 
 bool shouldCopyDir(const char *path)
 {
@@ -151,6 +154,18 @@ namespace
 if (strcmp(fpath, sourceForLinkOrCopy.c_str()) == 0)
 return 0;
 
+if (!linkOrCopyVerboseLogging)
+{
+const auto durationInSecs = 
std::chrono::duration_cast(
+std::chrono::steady_clock::now() - linkOrCopyStartTime);
+if (durationInSecs.count() > slowLinkOrCopyLimitInSecs)
+{
+LOG_WRN("Linking/copying files from " << sourceForLinkOrCopy 
<< " to " << destinationForLinkOrCopy.toString() <<
+" is taking too much time. Enabling verbose link/copy 
logging at information level.");
+linkOrCopyVerboseLogging = true;
+}
+}
+
 assert(fpath[strlen(sourceForLinkOrCopy.c_str())] == '/');
 const char *relativeOldPath = fpath + 
strlen(sourceForLinkOrCopy.c_str()) + 1;
 Path newPath(destinationForLinkOrCopy, Path(relativeOldPath));
@@ -160,6 +175,9 @@ namespace
 case FTW_F:
 case FTW_SLN:
 File(newPath.parent()).createDirectories();
+
+if (linkOrCopyVerboseLogging)
+LOG_INF("Linking file \"" << fpath << "\" to \"" << 
newPath.toString() << "\"");
 if (link(fpath, newPath.toString().c_str()) == -1)
 {
 LOG_SYS("link(\"" << fpath << "\", \"" <<
@@ -223,10 +241,16 @@ namespace
 if (sourceForLinkOrCopy.back() == '/')
 sourceForLinkOrCopy.pop_back();
 destinationForLinkOrCopy = destination;
+linkOrCopyStartTime = std::chrono::steady_clock::now();
 if (nftw(source.c_str(), linkOrCopyFunction, 10, FTW_ACTIONRETVAL) == 
-1)
 {
 LOG_ERR("linkOrCopy: nftw() failed for '" << source << "'");
 }
+if (linkOrCopyVerboseLogging)
+{
+LOG_INF("Linking/Copying of files to " << 
destinationForLinkOrCopy.toString() << " finished.");
+linkOrCopyVerboseLogging = false;
+}
 }
 
 void dropCapability(cap_value_t capability)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115244] FILESAVE XLSX Cell Reference Error:507, with a reference external xlsx file cells

https://bugs.documentfoundation.org/show_bug.cgi?id=115244

--- Comment #3 from Gabor Kelemen  ---
Created attachment 139380
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139380=edit
Formula syntax settings used to test the bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115244] FILESAVE XLSX Cell Reference Error:507, with a reference external xlsx file cells

https://bugs.documentfoundation.org/show_bug.cgi?id=115244

--- Comment #2 from Gabor Kelemen  ---
Created attachment 139379
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139379=edit
The example files in Calc side by side

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115244] FILESAVE XLSX Cell Reference Error:507, with a reference external xlsx file cells

https://bugs.documentfoundation.org/show_bug.cgi?id=115244

--- Comment #1 from Gabor Kelemen  ---
Created attachment 139378
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139378=edit
Example file with reference to the external data source file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113993] LibreOffice - Writer distorts text when I type " Tashdid " character in Persian Language

https://bugs.documentfoundation.org/show_bug.cgi?id=113993

--- Comment #8 from Buovjaga  ---
(In reply to Hadi SetSH from comment #7)
> (In reply to Xisco Faulí from comment #5)
> > Setting to NEEDINFO as per comment 4
> 
> Sorry , I didn't replied , Just added a comment
> I have already added an Screenshot , Just see attachments

He wasn't asking for a screenshot, but an example document.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115244] New: FILESAVE XLSX Cell Reference Error:507, with a reference external xlsx file cells

https://bugs.documentfoundation.org/show_bug.cgi?id=115244

Bug ID: 115244
Summary: FILESAVE XLSX Cell Reference Error:507, with a
reference external xlsx file cells
Product: LibreOffice
Version: 5.4.3.2 release
Hardware: All
OS: All
Status: UNCONFIRMED
Keywords: filter:xlsx
Severity: normal
Priority: medium
Component: Calc
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: kelem...@ubuntu.com

Created attachment 139377
--> https://bugs.documentfoundation.org/attachment.cgi?id=139377=edit
Example data source file made with LO 5.4

These spreadsheets were created with LibreOffice 5.4.3.2 and LibreOffice Dev.
6.0. The main problem here is the cell reference which did not work correctly
if we want to refer to an external file. We got an Error (507) message in the
cell, if we use the Excel A1 Formula Syntax.

Steps to reproduce:
1. Create a new spreadsheet with LibreOffice Calc 5.4
2. Click on Tools then choose the options.
3. In the Option set the LibreOffice Calc Formula options just like as you can
see at the attached Formula_syntax_setting.PNG file.
4. Fill the A1 cells with some simple data.
5. Save the file as “Cell_reference_source.xlsx” or something like that.
6. Create a new spreadsheet with LibreOffice 5.4 and save as
“Cell_reference_target.xlsx”.
7. In the “Cell_reference_target.xlsx” file click on the B1 cell and then click
on the “equal sign” or “Function button”. After that click on the
“Cell_reference_source.xlsx” file’s A1 cell and hit Enter.
Here is the example code:
=['file:///c:/users/teszt_admin/desktop/lo-4-hivatkozasok/error-507/cell_reference_source.xlsx']munkalap1!a1

Actual results:
We got an Error:507 code in the “Cell_reference_target.xlsx” file’s B1 cell. If
we save the file and reload the spreadsheet the data will be updated and the
Error:507 code will disappear. But If we modify the
“Cell_reference_source.xlsx” file’s A1 Cell and save it, the data will not
updated in the “Cell_reference_target.xlsx” file even if we reload the file. If
we click in the function (refresh the link manual) and hit enter we got an
Error:507 code again.

Expected results:
We should not receive an error code in the cell, because the link and the
syntax is correct. The links should be updated when we got the “This file
contains links to another files Should they be updated?” message and we click
Yes.

Version: 5.4.3.2
Build ID: 92a7159f7e4af62137622921e809f8546db437e5
CPU threads: 4; OS: Windows 6.1; UI render: default;
Locale: hu-HU (hu_HU); Calc: group

Version: 6.0.0.1.0+
Build ID: c678dc5309741097d9b0265f03dd279a8794d256
CPU threads: 4; OS: Windows 6.1; UI render: default;
TinderBox: Win-x86@42, Branch:libreoffice-6-0, Time: 2017-12-28_04:21:33
Locale: hu-HU (hu_HU); Calc: group

--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115226] Update bundled Amiri to 0.111

https://bugs.documentfoundation.org/show_bug.cgi?id=115226

--- Comment #4 from Volga  ---
(In reply to Volga from comment #3)
> So if an user installed Amiri v1.111, does MSI package replace it to older
> version?

Oh, it was downgraded, so I opened bug 115243.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115243] New: Amiri 0.111 downgraded to 0.109 after installation

https://bugs.documentfoundation.org/show_bug.cgi?id=115243

Bug ID: 115243
   Summary: Amiri 0.111 downgraded to 0.109 after installation
   Product: LibreOffice
   Version: 6.0.0.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Installation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: shanshandehongx...@outlook.com

Description:
I've downloaded & installed Amiri 0.111, but after I installed LO 6.0.0.3, it
was downgraded to 0.109. 
This release is available here:
https://github.com/alif-type/amiri/releases/tag/0.111

Steps to Reproduce:
1. Download LibreOffice from
http://dev-builds.libreoffice.org/pre-releases/win/x86_64/

Actual Results:  
After installation, when I open C:\Windows\Fonts, I saw Amiri font, but the
version is 0.109. 

Expected Results:
If Amiri and other fonts are newer than bundled version, the installation
wizard shouldn't replace them.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.0.0.3 (x64)
Build ID：64a0f66915f38c6217de274f0aa8e15618924765
CPU 线程：4; 操作系统：Windows 10.0; UI 渲染：默认; 
区域语言：zh-CN (zh_CN); Calc: group


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101
Firefox/58.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - forms/source

2018-01-26 Thread Julien Nabet

 forms/source/component/Time.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit b34ddf572bd5dab6173bf7daf6341d3f0f74535a
Author: Julien Nabet 
Date:   Fri Jan 26 11:19:36 2018 +0100

tdf#108473: don't let empty date in datetime in forms

If only an hour is given (so no date part), copy behavior for table and 
query
and put 30/12/99 by default

Change-Id: Ifb371758538d2d11bd02b101a347d34816b6fddf
Reviewed-on: https://gerrit.libreoffice.org/48665
Reviewed-by: Julien Nabet 
(cherry picked from commit a30652295be09afdbba707ce13d0a03e22c4e7a3)
Reviewed-on: https://gerrit.libreoffice.org/48692
Reviewed-by: Lionel Elie Mamane 
Tested-by: Jenkins 

diff --git a/forms/source/component/Time.cxx b/forms/source/component/Time.cxx
index f54e160c038c..5ba0c808a981 100644
--- a/forms/source/component/Time.cxx
+++ b/forms/source/component/Time.cxx
@@ -22,6 +22,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace dbtools;
 
@@ -235,6 +236,8 @@ bool OTimeModel::commitControlValueToDbColumn( bool 
/*_bPostReset*/ )
 else
 {
 util::DateTime aDateTime = m_xColumn->getTimestamp();
+if (aDateTime.Year == 0 && aDateTime.Month == 0 && 
aDateTime.Day == 0)
+aDateTime = 
::com::sun::star::util::DateTime(0,0,0,0,30,12,1899, false);
 aDateTime.NanoSeconds = aTime.NanoSeconds;
 aDateTime.Seconds = aTime.Seconds;
 aDateTime.Minutes = aTime.Minutes;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115239] Bookmark on the first word can't be deleted.

https://bugs.documentfoundation.org/show_bug.cgi?id=115239

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
 Blocks||108288

--- Comment #1 from Dieter Praas  ---
(In reply to Julian Jung from comment #0)
> Bookmarks on other positions
> gets removed after deleting the whole word they belong to.
>

No bookmarks gets removed. I removed them in the navigator.

Version: 5.4.4.2 (x64)
Build-ID: 2524958677847fb3bb44820e40380acbe820f960
CPU-Threads: 4; BS: Windows 6.19; UI-Render: Standard; 
Gebietsschema: de-DE (de_DE); Calc: group


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108288
[Bug 108288] [META] Bookmark bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108288] [META] Bookmark bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=108288

Dieter Praas  changed:

   What|Removed |Added

 Depends on||115239


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115239
[Bug 115239] Bookmark on the first word can't be deleted.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115155] FILEOPEN: RTF: left indent is lost in second list

https://bugs.documentfoundation.org/show_bug.cgi?id=115155

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5242

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115242] FILEOPEN: RTF: Incorrect left indent

https://bugs.documentfoundation.org/show_bug.cgi?id=115242

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||filter:rtf, regression
 Status|UNCONFIRMED |NEW
 CC||vmik...@collabora.co.uk
Version|6.1.0.0.alpha0+ Master  |5.2 all versions
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4016,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5155
 Ever confirmed|0   |1

--- Comment #2 from Xisco Faulí  ---
Regression introduced by:

author  Miklos Vajna   2016-01-26 13:21:28 +0100
committer   Miklos Vajna   2016-01-26 13:21:54
+0100
commit  3915bf2dc877d5f1140798e24933db0f21386a4a (patch)
treebcc1034371fa11953556b3400f520ee593760727
parent  09e46424c510924bae09c6e0147095e2958fa009 (diff)
tdf#95376 DOCX import: fix incorrectly indented tab stops

Bisected with: bibisect-linux-64-5.2

Adding Cc: to Miklos Vajna

The situation has improved in c9dee880d88305312094b311abdae155e452bf14 as the
numbering indent after 3 is correct now

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105584] [META] Calc image bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=105584

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||114552


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114552
[Bug 114552] Keep aspect ratio of images when resizing cells
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114552] Keep aspect ratio of images when resizing cells

https://bugs.documentfoundation.org/show_bug.cgi?id=114552

Thomas Lendo  changed:

   What|Removed |Added

 CC||thomas.le...@gmail.com
 Blocks||105584


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105584
[Bug 105584] [META] Calc image bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115242] FILEOPEN: RTF: Incorrect left indent

https://bugs.documentfoundation.org/show_bug.cgi?id=115242

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Created attachment 139376
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139376=edit
comparison MSO 2010 and LibreOffice 6.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115242] New: FILEOPEN: RTF: Incorrect left indent

https://bugs.documentfoundation.org/show_bug.cgi?id=115242

Bug ID: 115242
   Summary: FILEOPEN: RTF: Incorrect left indent
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Created attachment 139375
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139375=edit
sample

Steps to reproduce:
1. Open attached document
2. Go to page 2 and compare the indent before the bullets and numbering. See
attached image

Reproduced in

Version: 6.1.0.0.alpha0+
Build ID: 5cb225b0b3dbb55fd44899b1fb16bdcfeb866849
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded

[Bug found by office-interoperability-tools]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: ios/LibreOfficeLight

2018-01-26 Thread jan Iversen

 ios/LibreOfficeLight/LibreOfficeLight/Info.plist |   23 +++
 1 file changed, 23 insertions(+)

New commits:
commit 2cbcaa58b9fdbe78119b43a2a4404bebbb3fcebd
Author: jan Iversen 
Date:   Fri Jan 26 15:46:20 2018 +0100

iOS, add support for PDF

Updated Document Types and import types.

Change-Id: Id7e5aef91cdf52783a83672becfd7bbb78f986ad

diff --git a/ios/LibreOfficeLight/LibreOfficeLight/Info.plist 
b/ios/LibreOfficeLight/LibreOfficeLight/Info.plist
index 8e26191c6a76..c50ff60567f3 100755
--- a/ios/LibreOfficeLight/LibreOfficeLight/Info.plist
+++ b/ios/LibreOfficeLight/LibreOfficeLight/Info.plist
@@ -349,6 +349,7 @@
org.libreoffice.cdr-document
org.libreoffice.visio-document
org.libreoffice.mspub-document
+   com.adobe.pdf



@@ -1784,6 +1785,28 @@ file, You can obtain one at 
http://mozilla.org/MPL/2.0/.



+   
+   UTTypeConformsTo
+   
+   public.data
+   public.composite-content
+   
+   UTTypeDescription
+Apple PDF pasteboard type PDF data
+   UTTypeIdentifier
+   com.adobe.pdf
+   UTTypeTagSpecification
+   
+   public.filename-extension
+
+pdf
+
+public.mime-type
+
+application/pdf
+
+   
+   

 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/LOOLWSD.cpp

 wsd/LOOLWSD.cpp |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 9ea81e792109b394713e71a5b72aa7f21a17755d
Author: Pranav Kant 
Date:   Fri Jan 26 20:10:36 2018 +0530

wsd: Update client port number if default is unavailable

And print that on the console so that user knows what port the current
wsd instance is using.

Change-Id: I68fb7d23f46df4ad56ba444735b2888c410f7bd5

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index ca0ca6a5..13ae0298 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -2587,6 +2587,7 @@ private:
 _exit(Application::EXIT_SOFTWARE);
 }
 
+MasterPortNumber = port;
 LOG_INF("Listening to prisoner connections on port " << port);
 return socket;
 }
@@ -2613,6 +2614,7 @@ private:
 ServerSocket::Type::Public, port, WebServerPoll, factory);
 }
 
+ClientPortNumber = port;
 LOG_INF("Listening to client connections on port " << port);
 return socket;
 }
@@ -2751,7 +2753,7 @@ int LOOLWSD::innerMain()
 /// The main-poll does next to nothing:
 SocketPoll mainWait("main");
 #if ENABLE_DEBUG
-std::cerr << "Ready to accept connections.\n" << std::endl;
+std::cerr << "Ready to accept connections on port " << ClientPortNumber << 
 ".\n" << std::endl;
 #endif
 
 const auto startStamp = std::chrono::steady_clock::now();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114653] using more than x custom properties in templates causes high CPU usage

https://bugs.documentfoundation.org/show_bug.cgi?id=114653

--- Comment #7 from Freddy  ---
For fedora there is a new 5.4 version available that contains a patch that
appears to solve the issue:

https://bugzilla.redhat.com/show_bug.cgi?id=1532323

One comment in there:"master doesn't suffer from the problem, so backporting
commit that fixed it"

I could not quite work out what patch they are referring to, but it seems to
have been fixed in 'master'?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: common/Util.cpp common/Util.hpp kit/Kit.cpp

 common/Util.cpp |   26 ++
 common/Util.hpp |3 +++
 kit/Kit.cpp |6 +++---
 3 files changed, 32 insertions(+), 3 deletions(-)

New commits:
commit c16d1985604940c2f35e49ac27a63d973a2a65ea
Author: Pranav Kant 
Date:   Fri Jan 26 20:02:09 2018 +0530

Print humanized bytes in the logs

Change-Id: I2ebdea0c3a360be1573ae13fa9cbe6f432436f29

diff --git a/common/Util.cpp b/common/Util.cpp
index 72c150a4..f8c493b9 100644
--- a/common/Util.cpp
+++ b/common/Util.cpp
@@ -170,6 +170,32 @@ namespace Util
 return nullptr;
 }
 
+std::string getHumanizedBytes(unsigned long nBytes)
+{
+constexpr unsigned factor = 1024;
+short count = 0;
+float val = nBytes;
+while (val >= factor && count < 4) {
+val /= factor;
+count++;
+}
+std::string unit;
+switch (count)
+{
+case 0: unit = ""; break;
+case 1: unit = "ki"; break;
+case 2: unit = "Mi"; break;
+case 3: unit = "Gi"; break;
+case 4: unit = "Ti"; break;
+default: assert(false);
+}
+
+unit += "B";
+std::stringstream ss;
+ss << std::fixed << std::setprecision(1) << val << ' ' << unit;
+return ss.str();
+}
+
 size_t getTotalSystemMemoryKb()
 {
 size_t totalMemKb = 0;
diff --git a/common/Util.hpp b/common/Util.hpp
index b4eb3504..5118efb6 100644
--- a/common/Util.hpp
+++ b/common/Util.hpp
@@ -97,6 +97,9 @@ namespace Util
 #endif
 }
 
+/// Print given number of bytes in human-understandable form (KB,MB, etc.)
+std::string getHumanizedBytes(unsigned long nBytes);
+
 /// Returns the total physical memory (in kB) available in the system
 size_t getTotalSystemMemoryKb();
 
diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 4d054427..f38af663 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -2103,17 +2103,17 @@ void lokit_main(const std::string& childRoot,
 
 rlimit rlim = { 0, 0 };
 if (getrlimit(RLIMIT_AS, ) == 0)
-LOG_INF("RLIMIT_AS is " << rlim.rlim_max << " bytes.");
+LOG_INF("RLIMIT_AS is " << Util::getHumanizedBytes(rlim.rlim_max) 
<< " (" << rlim.rlim_max << " bytes)");
 else
 LOG_SYS("Failed to get RLIMIT_AS.");
 
 if (getrlimit(RLIMIT_STACK, ) == 0)
-LOG_INF("RLIMIT_STACK is " << rlim.rlim_max << " bytes.");
+LOG_INF("RLIMIT_STACK is " << 
Util::getHumanizedBytes(rlim.rlim_max) << " (" << rlim.rlim_max << " bytes)");
 else
 LOG_SYS("Failed to get RLIMIT_STACK.");
 
 if (getrlimit(RLIMIT_FSIZE, ) == 0)
-LOG_INF("RLIMIT_FSIZE is " << rlim.rlim_max << " bytes.");
+LOG_INF("RLIMIT_FSIZE is " << 
Util::getHumanizedBytes(rlim.rlim_max) << " (" << rlim.rlim_max << " bytes)");
 else
 LOG_SYS("Failed to get RLIMIT_FSIZE.");
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115214] FILESAVE XLSX Function Syntax Error (#Name?), with a reference to an external xlsx file and Excel formula syntax

https://bugs.documentfoundation.org/show_bug.cgi?id=115214

--- Comment #9 from Gabor Kelemen  ---
Created attachment 139374
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139374=edit
Example file with function reference to the external data source file saved by
LO 6, in XLS

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115214] FILESAVE XLSX Function Syntax Error (#Name?), with a reference to an external xlsx file and Excel formula syntax

https://bugs.documentfoundation.org/show_bug.cgi?id=115214

--- Comment #8 from Gabor Kelemen  ---
Created attachment 139373
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139373=edit
Data source example file in XLS from LO 6

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114722] lack of focus; object element with dangling parent

https://bugs.documentfoundation.org/show_bug.cgi?id=114722

Buovjaga  changed:

   What|Removed |Added

 CC||philip...@hotmail.com,
   ||todven...@suomi24.fi

--- Comment #2 from Buovjaga  ---
Jay: you had an Xfce setup. Care to confirm this with a dbgutil build and
SAL_USE_VCLPLUGIN=gtk3?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - sw/source xmloff/source

2018-01-26 Thread Michael Stahl

 sw/source/core/undo/undobj.cxx  |3 +--
 xmloff/source/text/txtparae.cxx |4 
 2 files changed, 5 insertions(+), 2 deletions(-)

New commits:
commit 17d7f2971061a9e0b68da6d433835c64b946169a
Author: Michael Stahl 
Date:   Fri Jan 26 14:56:37 2018 +0100

sw: remove misleading comment from SwUndoSaveContent::DelContentIndex()

"Directories" weren't handled in the initial CVS import already.

Change-Id: Ic96921d8e3e8aa5a5e65e07391236f0a7747c867

diff --git a/sw/source/core/undo/undobj.cxx b/sw/source/core/undo/undobj.cxx
index 449479da46e9..bb6e1c50af90 100644
--- a/sw/source/core/undo/undobj.cxx
+++ b/sw/source/core/undo/undobj.cxx
@@ -837,7 +837,6 @@ void SwUndoSaveContent::MovePtForward( SwPaM& rPam, bool 
bMvBkwrd )
 //  - Footnotes
 //  - Flys
 //  - Bookmarks
-//  - Directories
 
 // #i81002# - extending method
 // delete certain (not all) cross-reference bookmarks at text node of 
@@ -1210,7 +1209,7 @@ void SwUndoSaveSection::SaveSection(
 {
 SwPaM aPam( rRange.aStart, rRange.aEnd );
 
-// delete all footnotes, fly frames, bookmarks and indexes
+// delete all footnotes, fly frames, bookmarks
 DelContentIndex( *aPam.GetMark(), *aPam.GetPoint() );
 {
 // move certain indexes out of deleted range
commit 55650f65de478bcee65fe1e1cf19f106e407f999
Author: Michael Stahl 
Date:   Fri Jan 26 14:24:02 2018 +0100

xmloff: ODF export: don't write LO_EXT attribute unless ODF expended

The loext namespace is not defined when exporting standard ODF
versions, which triggers an assert() in SvXMLNamespaceMap.

(regression from 4469b29faeb8dbf7793a5d81d9c5ddebacf3015f)

Change-Id: Ic93fb0ea8fe092463d3fd18a0fbf4429d8652642

diff --git a/xmloff/source/text/txtparae.cxx b/xmloff/source/text/txtparae.cxx
index 656c33a6cbb2..c5baccfe79fc 100644
--- a/xmloff/source/text/txtparae.cxx
+++ b/xmloff/source/text/txtparae.cxx
@@ -3141,7 +3141,11 @@ void XMLTextParagraphExport::_exportTextGraphic(
 const OString aExt( OUStringToOString( aSourceMimeType, 
RTL_TEXTENCODING_ASCII_US ) );
 aSourceMimeType = 
comphelper::GraphicMimeTypeHelper::GetMimeTypeForExtension( aExt );
 }
+
+if (GetExport().getDefaultVersion() > SvtSaveOptions::ODFVER_012)
+{
 GetExport().AddAttribute(XML_NAMESPACE_LO_EXT, "mime-type", 
aSourceMimeType);
+}
 
 {
 SvXMLElementExport aElement( GetExport(), XML_NAMESPACE_DRAW,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115214] FILESAVE XLSX Function Syntax Error (#Name?), with a reference to an external xlsx file and Excel formula syntax

https://bugs.documentfoundation.org/show_bug.cgi?id=115214

Gabor Kelemen  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #7 from Gabor Kelemen  ---
(In reply to m.a.riosv from comment #6)
> Looks like a duple of
> https://bugs.documentfoundation.org/show_bug.cgi?id=76047

In that one they claims that in XLS format they don't see the problem.
This one affects XLS too, I'm attaching such files for reference.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114698] LO documents do not show up in Plasma/KDE history

https://bugs.documentfoundation.org/show_bug.cgi?id=114698

Buovjaga  changed:

   What|Removed |Added

   Priority|medium  |lowest
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1
   Severity|normal  |trivial

--- Comment #2 from Buovjaga  ---
Confirmed.

The history works by creating .desktop files in ~/.local/share/RecentDocuments
So one would find mydocument.odt.desktop etc. inside that directory.

Arch Linux 64-bit
Version: 6.1.0.0.alpha0+
Build ID: 19f8a979ff86be39a3938b3d7b25c1431191e708
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group threaded
Built on January 25th 2018

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2018-01-26 Thread Fyodor Yemelyanenko

 sw/source/core/undo/untblk.cxx |   73 +++--
 1 file changed, 56 insertions(+), 17 deletions(-)

New commits:
commit 70483089425d5bb22e036867290e06a6fc8d99fb
Author: Fyodor Yemelyanenko 
Date:   Thu Nov 16 17:06:28 2017 +1000

tdf#94225 - Writer crashes on Undo N times
when document contains flys anchored to paragraph.

Change-Id: I628ef10b1e7817b554afee5e3c8733c1a128b201
Reviewed-on: https://gerrit.libreoffice.org/44800
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/sw/source/core/undo/untblk.cxx b/sw/source/core/undo/untblk.cxx
index 9b44e00522ea..d00210353875 100644
--- a/sw/source/core/undo/untblk.cxx
+++ b/sw/source/core/undo/untblk.cxx
@@ -49,22 +49,24 @@ SwUndoInserts::SwUndoInserts( SwUndoId nUndoId, const 
SwPaM& rPam )
 if( pTextNd->HasSwAttrSet() )
 pHistory->CopyFormatAttr( *pTextNd->GetpSwAttrSet(), nSttNode );
 
-if( !nSttContent )// than take the Flys along
+// We may have some flys anchored to paragraph where we inserting.
+// These flys will be saved in pFrameFormats array (only flys which 
exist BEFORE insertion!)
+// Then in SwUndoInserts::SetInsertRange the flys saved in 
pFrameFormats will NOT create Undos.
+// m_FlyUndos will only be filled with newly inserted flys.
+
+const size_t nArrLen = pDoc->GetSpzFrameFormats()->size();
+for( size_t n = 0; n < nArrLen; ++n )
 {
-const size_t nArrLen = pDoc->GetSpzFrameFormats()->size();
-for( size_t n = 0; n < nArrLen; ++n )
+SwFrameFormat* pFormat = (*pDoc->GetSpzFrameFormats())[n];
+SwFormatAnchor const*const  pAnchor = >GetAnchor();
+const SwPosition* pAPos = pAnchor->GetContentAnchor();
+if (pAPos &&
+(pAnchor->GetAnchorId() == RndStdIds::FLY_AT_PARA) &&
+ nSttNode == pAPos->nNode.GetIndex() )
 {
-SwFrameFormat* pFormat = (*pDoc->GetSpzFrameFormats())[n];
-SwFormatAnchor const*const  pAnchor = >GetAnchor();
-const SwPosition* pAPos = pAnchor->GetContentAnchor();
-if (pAPos &&
-(pAnchor->GetAnchorId() == RndStdIds::FLY_AT_PARA) &&
- nSttNode == pAPos->nNode.GetIndex() )
-{
-if( !pFrameFormats )
-pFrameFormats = new std::vector;
-pFrameFormats->push_back( pFormat );
-}
+if( !pFrameFormats )
+pFrameFormats = new std::vector;
+pFrameFormats->push_back( pFormat );
 }
 }
 }
@@ -76,7 +78,18 @@ SwUndoInserts::SwUndoInserts( SwUndoId nUndoId, const SwPaM& 
rPam )
 }
 }
 
-// set destination after reading input
+// This method does two things:
+// 1. Adjusts SwUndoRng members, required for Undo.
+//  Members are:
+//  SwUndoRng::nSttNode - all nodes starting from this node will be deleted 
during Undo (in SwUndoInserts::UndoImpl)
+//  SwUndoRng::nSttContent - corresponding content index in SwUndoRng::nSttNode
+//  SwUndoRng::nEndNode - end node for deletion
+//  SwUndoRng::nEndContent - end content index
+// All these members are filled in during construction of SwUndoInserts 
instance, and can be adjusted using this method
+//
+// 2. Fills in m_FlyUndos array with flys anchored ONLY to first and last 
paragraphs (first == rPam.Start(), last == rPam.End())
+//  Flys, anchored to any paragraph, but not first and last, are handled by 
DelContentIndex (see SwUndoInserts::UndoImpl) and are not stored in m_FlyUndos.
+
 void SwUndoInserts::SetInsertRange( const SwPaM& rPam, bool bScanFlys,
 bool bSttIsTextNd )
 {
@@ -100,7 +113,9 @@ void SwUndoInserts::SetInsertRange( const SwPaM& rPam, bool 
bScanFlys,
 }
 }
 
-if( bScanFlys && !nSttContent )
+// Fill m_FlyUndos with flys anchored to first and last paragraphs
+
+if( bScanFlys)
 {
 // than collect all new Flys
 SwDoc* pDoc = rPam.GetDoc();
@@ -112,7 +127,7 @@ void SwUndoInserts::SetInsertRange( const SwPaM& rPam, bool 
bScanFlys,
 SwPosition const*const pAPos = pAnchor->GetContentAnchor();
 if (pAPos &&
 (pAnchor->GetAnchorId() == RndStdIds::FLY_AT_PARA) &&
-nSttNode == pAPos->nNode.GetIndex() )
+(nSttNode == pAPos->nNode.GetIndex() || nEndNode == 
pAPos->nNode.GetIndex()))
 {
 std::vector::iterator it;
 if( !pFrameFormats ||
@@ -145,6 +160,27 @@ SwUndoInserts::~SwUndoInserts()
 delete pRedlData;
 }
 
+// Undo Insert operation
+//  It's important to note that Undo stores absolute node indexes. I.e. if 
during insertion, you insert nodes 31 to

[Libreoffice-bugs] [Bug 96011] Document is not focused on opening LO / opening existing documents

https://bugs.documentfoundation.org/show_bug.cgi?id=96011

--- Comment #20 from John Marchi  ---
The Import Options window issue is with Windows 8.1.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3-desktop' - 2 commits - sw/qa sw/source

2018-01-26 Thread Aron Budea

 sw/qa/extras/uiwriter/uiwriter.cxx |7 ++-
 sw/source/uibase/dbui/dbmgr.cxx|   21 ++---
 2 files changed, 20 insertions(+), 8 deletions(-)

New commits:
commit e3adde7b2dfa85c011640ea9689fa9258d0d61cc
Author: Aron Budea 
Date:   Mon Jan 22 03:00:28 2018 +0100

tdf115103: find data source if sDataSource/sCommand are empty

In several functions data source was only found if sDataSource and
sCommand corresponded to what was set in fields.
In imported DOC(X) files these aren't set.

Now use the data source even if field's sDataSource/sCommand are
empty (similarly to SwDBManager::IsDataSourceOpen(...)).

Reviewed-on: https://gerrit.libreoffice.org/48285
Tested-by: Jenkins 
Reviewed-by: Aron Budea 
(cherry picked from commit 6feeb77552c38e3d9819611e9678470a44c00c84)

Change-Id: I9563cb56e700e7fd033100cb200f41f074669020
Reviewed-on: https://gerrit.libreoffice.org/48614
Reviewed-by: Aron Budea 
Tested-by: Aron Budea 
(cherry picked from commit b4cef1fb91c7b5024c4e370b0c57a1d4c463a476)

diff --git a/sw/source/uibase/dbui/dbmgr.cxx b/sw/source/uibase/dbui/dbmgr.cxx
index 2c116217ba5d..a60ea06861eb 100644
--- a/sw/source/uibase/dbui/dbmgr.cxx
+++ b/sw/source/uibase/dbui/dbmgr.cxx
@@ -1711,7 +1711,8 @@ sal_uLong SwDBManager::GetColumnFormat( const OUString& 
rDBName,
 uno::Reference< sdbcx::XColumnsSupplier> xColsSupp;
 bool bDisposeConnection = false;
 if(pImpl->pMergeData &&
-pImpl->pMergeData->sDataSource.equals(rDBName) && 
pImpl->pMergeData->sCommand.equals(rTableName))
+((pImpl->pMergeData->sDataSource == rDBName && 
pImpl->pMergeData->sCommand == rTableName) ||
+(rDBName.isEmpty() && rTableName.isEmpty(
 {
 xConnection = pImpl->pMergeData->xConnection;
 xSource = SwDBManager::getDataSourceAsParent(xConnection,rDBName);
@@ -2419,11 +2420,15 @@ sal_uInt32  SwDBManager::GetSelectedRecordId(
 {
 sal_uInt32 nRet = 0x;
 //check for merge data source first
-if(pImpl->pMergeData && rDataSource == pImpl->pMergeData->sDataSource &&
-rTableOrQuery == pImpl->pMergeData->sCommand &&
-(nCommandType == -1 || nCommandType == 
pImpl->pMergeData->nCommandType) &&
-pImpl->pMergeData->xResultSet.is())
+if(pImpl->pMergeData &&
+((rDataSource == pImpl->pMergeData->sDataSource &&
+rTableOrQuery == pImpl->pMergeData->sCommand) ||
+(rDataSource.isEmpty() && rTableOrQuery.isEmpty())) &&
+(nCommandType == -1 || nCommandType == 
pImpl->pMergeData->nCommandType) &&
+pImpl->pMergeData->xResultSet.is())
+{
 nRet = GetSelectedRecordId();
+}
 else
 {
 SwDBData aData;
@@ -2479,8 +2484,10 @@ voidSwDBManager::CloseAll(bool bIncludingMerge)
 SwDSParam* SwDBManager::FindDSData(const SwDBData& rData, bool bCreate)
 {
 //prefer merge data if available
-if(pImpl->pMergeData && rData.sDataSource == 
pImpl->pMergeData->sDataSource &&
-rData.sCommand == pImpl->pMergeData->sCommand &&
+if(pImpl->pMergeData &&
+((rData.sDataSource == pImpl->pMergeData->sDataSource &&
+rData.sCommand == pImpl->pMergeData->sCommand) ||
+(rData.sDataSource.isEmpty() && rData.sCommand.isEmpty())) &&
 (rData.nCommandType == -1 || rData.nCommandType == 
pImpl->pMergeData->nCommandType ||
 (bCreate && pImpl->pMergeData->nCommandType == -1)))
 {
commit 2c9ff74995a58fae60ac7fe830db8bf07fb0b16b
Author: Mike Kaganski 
Date:   Fri Jan 19 10:14:07 2018 +0100

Don't create database files in $HOME

Regression from commit 46b3202bf883618f1585850191c19776861013ed

Change-Id: If8e0b309274ea14e996e0dde2d1ee9b49ff0f737
Reviewed-on: https://gerrit.libreoffice.org/48173
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 
Reviewed-on: https://gerrit.libreoffice.org/48477
Reviewed-by: Aron Budea 
Tested-by: Aron Budea 
(cherry picked from commit 61651849676ef1377f2e51675379bb4b7444557b)

diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index 5c96aacf7a1e..95206bf7944d 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -4649,13 +4649,16 @@ void SwUiWriterTest::testTdf115013()
 {
const OUString sColumnName("Name with spaces, \"quotes\" and 
\\backslashes");
 
+   utl::TempFile aTempDir(nullptr, true);
+   const OUString aWorkDir = aTempDir.GetURL();
+
//create new writer document
 SwDoc* pDoc = createDoc();
 
 {
 // Load and register data source
 const OUString

[Libreoffice-bugs] [Bug 87351] [META] Conditional formatting bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=87351

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||115241


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115241
[Bug 115241] CALC: See cells with conditional formatting set
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115241] CALC: See cells with conditional formatting set

https://bugs.documentfoundation.org/show_bug.cgi?id=115241

Thomas Lendo  changed:

   What|Removed |Added

 CC||thomas.le...@gmail.com
 Blocks||87351


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=87351
[Bug 87351] [META] Conditional formatting bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: forms/source

2018-01-26 Thread Julien Nabet

 forms/source/component/Time.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit a30652295be09afdbba707ce13d0a03e22c4e7a3
Author: Julien Nabet 
Date:   Fri Jan 26 11:19:36 2018 +0100

tdf#108473: don't let empty date in datetime in forms

If only an hour is given (so no date part), copy behavior for table and 
query
and put 30/12/99 by default

Change-Id: Ifb371758538d2d11bd02b101a347d34816b6fddf
Reviewed-on: https://gerrit.libreoffice.org/48665
Reviewed-by: Julien Nabet 
Tested-by: Jenkins 

diff --git a/forms/source/component/Time.cxx b/forms/source/component/Time.cxx
index 3e580c8451c2..ed87e9aa6224 100644
--- a/forms/source/component/Time.cxx
+++ b/forms/source/component/Time.cxx
@@ -22,6 +22,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace dbtools;
 
@@ -235,6 +236,8 @@ bool OTimeModel::commitControlValueToDbColumn( bool 
/*_bPostReset*/ )
 else
 {
 util::DateTime aDateTime = m_xColumn->getTimestamp();
+if (aDateTime.Year == 0 && aDateTime.Month == 0 && 
aDateTime.Day == 0)
+aDateTime = 
::com::sun::star::util::DateTime(0,0,0,0,30,12,1899, false);
 aDateTime.NanoSeconds = aTime.NanoSeconds;
 aDateTime.Seconds = aTime.Seconds;
 aDateTime.Minutes = aTime.Minutes;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - vcl/source

 vcl/source/window/seleng.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ea5384c177dcaf96a951019ab6a026b884832592
Author: Caolán McNamara 
Date:   Wed Jan 24 17:18:35 2018 +

gtk3: single click with selection set doesn't unselect

this is a safe backportable fix, the unconditional

nFlags |= SelectionEngineFlags::CMDEVT

looks the real dubious thing to me, but only the gtk3 backend has swipe 
support
so just returning immediately on a swipe definitely ok

Change-Id: Iade26d0d9260ce76dfb2766ac9e5ca9fa9275bf4
Reviewed-on: https://gerrit.libreoffice.org/48528
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/vcl/source/window/seleng.cxx b/vcl/source/window/seleng.cxx
index 3b06d3d11623..286fa10275d6 100644
--- a/vcl/source/window/seleng.cxx
+++ b/vcl/source/window/seleng.cxx
@@ -343,7 +343,7 @@ void SelectionEngine::Reset()
 void SelectionEngine::Command( const CommandEvent& rCEvt )
 {
 // Timer aWTimer is active during enlarging a selection
-if ( !pFunctionSet || !pWin || aWTimer.IsActive() )
+if ( !pFunctionSet || !pWin || aWTimer.IsActive() || rCEvt.GetCommand() == 
CommandEventId::Swipe )
 return;
 aWTimer.Stop();
 nFlags |= SelectionEngineFlags::CMDEVT;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107730] CRASH when opening simple document containing shapes with OpenGL enabled

https://bugs.documentfoundation.org/show_bug.cgi?id=107730

Aron Budea  changed:

   What|Removed |Added

 Attachment #133200|application/postscript  |application/vnd.oasis.opend
  mime type||ocument.graphics

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: source/text

 source/text/swriter/01/watermark.xhp |   20 +---
 1 file changed, 13 insertions(+), 7 deletions(-)

New commits:
commit 854f87b82b23d5409b4a3f6cea8628324fb238cc
Author: Olivier Hallot 
Date:   Fri Jan 26 10:56:19 2018 -0200

tdf#112356 Watermark help page, better bookmarking

Change-Id: Ia0f37984caaa32b74817e0bdd62c05813de50a6d
Reviewed-on: https://gerrit.libreoffice.org/48690
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/source/text/swriter/01/watermark.xhp 
b/source/text/swriter/01/watermark.xhp
index 41fee8839..dd714e55b 100644
--- a/source/text/swriter/01/watermark.xhp
+++ b/source/text/swriter/01/watermark.xhp
@@ -17,16 +17,17 @@
 
 
 
-
-
-
-watermark;text documents
-watermark;page background
-page background;watermark
-
+
 
 Page Watermark
 Insert a watermark text 
in the current page style background.
+
+
+
+watermark;text documents
+watermark;page background
+page background;watermark
+
 
 
 Choose Format - Watermark  

@@ -36,15 +37,20 @@
 Fill the dialog settings below.
 The 
values entered applies to the actual page style.
  
+
 Text
 Enter the watermark text to be displayed as image in the page 
brackground.
+
 Font
 Select the font from the list.
 You 
cannot choose font size or font style for the watermark text. The text size 
will be scaled to fit in one line in the page brackground.
+
 Angle
 Select the slant angle for the watermark. A positive angle 
displays tha watermark from bottom to top. A negative value displays the 
watermark text from top to bottom.
+
 Transparency
 Select the transparency index for the watermark. A 0% value 
produce an opaque watermark and a value of 100% is totally transparent 
(invisible).
+
 Color
 Select color from the drop-down box.
 To change a watermark contents or setting.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d4fecf0e6a1b98d251d6c17abb52b5417af810c8
Author: Olivier Hallot 
Date:   Fri Jan 26 10:56:19 2018 -0200

Updated core
Project: help  854f87b82b23d5409b4a3f6cea8628324fb238cc

tdf#112356 Watermark help page, better bookmarking

Change-Id: Ia0f37984caaa32b74817e0bdd62c05813de50a6d
Reviewed-on: https://gerrit.libreoffice.org/48690
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index f15eac158a47..854f87b82b23 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit f15eac158a47aac87d5dc40004899871ebc5739e
+Subproject commit 854f87b82b23d5409b4a3f6cea8628324fb238cc
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96011] Document is not focused on opening LO / opening existing documents

https://bugs.documentfoundation.org/show_bug.cgi?id=96011

Buovjaga  changed:

   What|Removed |Added

 CC||johnrmar...@comcast.net

--- Comment #19 from Buovjaga  ---
(In reply to John Marchi from comment #18)
> Upgraded to 5.4.4 today. Opened a .xls document with Calc. Calc opened the
> "Import Options" window behind other windows.

On Windows, Linux or Mac? Not sure, if the import options window is related to
this one.

Import options is known to be a bit unruly: bug 95630

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114736] Crash with CJK characters in status bar (OpenGL)

https://bugs.documentfoundation.org/show_bug.cgi?id=114736

Aron Budea  changed:

   What|Removed |Added

Crash report or||["MultiSalLayout::AdjustLay
crash signature||out(ImplLayoutArgs &)"]

--- Comment #15 from Aron Budea  ---
Thanks for taking a look, Tamas! It might be that the bug doesn't occur in
Linux, I've only tried in Windows, and the OSX repro also seems to be somewhat
different (bug 112990).

A crash report in 6.0.0.2 with symbols:
https://crashreport.libreoffice.org/stats/crash_details/81314640-d5bc-4bab-8ec5-61e0258b0e11

Bug is still there in 6.0.0.3 as well (unsurprisingly).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: tools/Config.cpp

 tools/Config.cpp |  234 +++
 1 file changed, 136 insertions(+), 98 deletions(-)

New commits:
commit f942e5a29ecb7aecdc0b085f8bafa7ac6a5d6f86
Author: Pranav Kant 
Date:   Fri Jan 26 18:29:12 2018 +0530

loolconfig: Allow changing loolwsd.xml

eg: `loolconfig set-raw-config admin_console.password admin`

And while at it, stop processing all the arguments given to the command.
Regard the first argument (without any "--") as command and let the
specific-command handling routine handle the remaining arguments the way
it wants.

Change-Id: I6cc406c56701dba2b99e0a3c4a98c505df70ee60

diff --git a/tools/Config.cpp b/tools/Config.cpp
index e12bbf4e..79f4398b 100644
--- a/tools/Config.cpp
+++ b/tools/Config.cpp
@@ -72,7 +72,14 @@ protected:
 int main(const std::vector&) override;
 };
 
-std::string Config::ConfigFile = LOOLWSD_CONFIGDIR "/loolwsd.xml";
+std::string Config::ConfigFile =
+#if ENABLE_DEBUG
+DEBUG_ABSSRCDIR
+#else
+LOOLWSD_CONFIGDIR
+#endif
+"/loolwsd.xml";
+
 std::string Config::SupportKeyString;
 bool Config::SupportKeyStringProvided = false;
 
@@ -80,17 +87,22 @@ void Config::displayHelp()
 {
 HelpFormatter helpFormatter(options());
 helpFormatter.setCommand(commandName());
-
-std::string usage = "set-admin-password";
-#if ENABLE_SUPPORT_KEY
-usage = "(set-admin-password|set-support-key)";
-#endif
-
-helpFormatter.setUsage(usage + " OPTIONS");
+helpFormatter.setUsage("COMMAND [OPTIONS]");
 helpFormatter.setHeader("loolconfig - Configuration tool for LibreOffice 
Online.\n"
 "\n"
-"Some options make sense only with a concrete 
command, in that case the command name is specified in brackets.");
+"Some options make sense only with a specific 
command.\n\n"
+"Options:");
+
 helpFormatter.format(std::cout);
+
+// Command list
+std::cout << std::endl
+  << "Commands: " << std::endl
+  << "set-admin-password\n"
+#if ENABLE_SUPPORT_KEY
+  << "set-support-key\n"
+#endif
+  << "set-raw-config  " << std::endl;
 }
 
 void Config::defineOptions(OptionSet& optionSet)
@@ -187,109 +199,135 @@ int Config::main(const std::vector& args)
 bool changed = false;
 _loolConfig.load(ConfigFile);
 
-for (unsigned long i = 0; i < args.size(); i++)
+if (args[0] == "set-admin-password")
 {
-if (args[i] == "set-admin-password")
-{
 #if HAVE_PKCS5_PBKDF2_HMAC
-unsigned char pwdhash[_adminConfig.pwdHashLength];
-unsigned char salt[_adminConfig.pwdSaltLength];
-RAND_bytes(salt, _adminConfig.pwdSaltLength);
-std::stringstream stream;
-
-// Ask for user password
-termios oldTermios;
-tcgetattr(STDIN_FILENO, );
-termios newTermios = oldTermios;
-// Disable user input mirroring on console for password input
-newTermios.c_lflag &= ~ECHO;
-tcsetattr(STDIN_FILENO, TCSANOW, );
-std::string adminPwd;
-std::cout << "Enter admin password: ";
-std::getline(std::cin, adminPwd);
-std::string reAdminPwd;
-std::cout << std::endl << "Confirm admin password: ";
-std::getline(std::cin, reAdminPwd);
-std::cout << std::endl;
-// Set the termios to old state
-tcsetattr(STDIN_FILENO, TCSANOW, );
-if (adminPwd != reAdminPwd)
-{
-std::cout << "Password mismatch." << std::endl;
-return Application::EXIT_DATAERR;
-}
+unsigned char pwdhash[_adminConfig.pwdHashLength];
+unsigned char salt[_adminConfig.pwdSaltLength];
+RAND_bytes(salt, _adminConfig.pwdSaltLength);
+std::stringstream stream;
+
+// Ask for user password
+termios oldTermios;
+tcgetattr(STDIN_FILENO, );
+termios newTermios = oldTermios;
+// Disable user input mirroring on console for password input
+newTermios.c_lflag &= ~ECHO;
+tcsetattr(STDIN_FILENO, TCSANOW, );
+std::string adminPwd;
+std::cout << "Enter admin password: ";
+std::getline(std::cin, adminPwd);
+std::string reAdminPwd;
+std::cout << std::endl << "Confirm admin password: ";
+std::getline(std::cin, reAdminPwd);
+std::cout << std::endl;
+// Set the termios to old state
+tcsetattr(STDIN_FILENO, TCSANOW, );
+if (adminPwd != reAdminPwd)
+{
+std::cout << "Password mismatch." << std::endl;
+return Application::EXIT_DATAERR;
+}
 
-// Do the magic !
-PKCS5_PBKDF2_HMAC(adminPwd.c_str(), -1,
-  salt,

[Libreoffice-commits] core.git: sc/source

2018-01-26 Thread Eike Rathke

 sc/source/ui/unoobj/cellsuno.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 09b81a42c2689b7249c8c39899c0b5b36c050306
Author: Eike Rathke 
Date:   Fri Jan 26 14:01:12 2018 +0100

coverity#1428611 check for nullptr

Change-Id: I4d0bd765e4c1677448dcd3a74f26f36394c4a358

diff --git a/sc/source/ui/unoobj/cellsuno.cxx b/sc/source/ui/unoobj/cellsuno.cxx
index 2731e69cfc79..8cee317d4f8b 100644
--- a/sc/source/ui/unoobj/cellsuno.cxx
+++ b/sc/source/ui/unoobj/cellsuno.cxx
@@ -6418,7 +6418,11 @@ sal_Int32 ScCellObj::GetResultType_Impl()
 if (pDocSh->GetDocument().GetCellType(aCellPos) == CELLTYPE_FORMULA)
 {
 ScFormulaCell* pFCell = 
pDocSh->GetDocument().GetFormulaCell(aCellPos);
-if (pFCell->GetErrCode() != FormulaError::NONE )
+if (!pFCell)
+{
+// should throw instead of default string?
+}
+else if (pFCell->GetErrCode() != FormulaError::NONE )
 {
 eRet = sheet::FormulaResult::ERROR;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114050] Image compression seems to be rather slow and CPU hogging for high resolution images

https://bugs.documentfoundation.org/show_bug.cgi?id=114050

--- Comment #4 from Telesto  ---
(In reply to Xisco Faulí from comment #3)
> Hi Telesto,
> Thanks for reporting this issue.
> IMHO, this report is to vague and general i don't think anybody would work
> on it.
> What's the goal here? being faster than FastStone image viewer/IrfanView) ?
> Probably, if you test hundreds of pictures, LibreOffice will be faster in
> some cases.
> OTOH, is 3 seconds of difference such a big deal? probably even the timing
> would be different with a different OS or HW.
> I'd say: RESOLVED WONTFIX. Please, change it back to UNCONFIRMED if you
> disagree.
> Regards

True. Another proposal would be a progress dialog ;-). Now it's a 5 second
hang..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: codemaker/source

 codemaker/source/cppumaker/cpputype.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4e5cb9fdbac5c7afef599648737bdcfe37af6ccf
Author: Caolán McNamara 
Date:   Fri Jan 26 13:01:10 2018 +

coverity#1019311 silence Unchecked return value

Change-Id: Ife2bfed0eecff5fe247d0fef6ee7d77626d9f0be

diff --git a/codemaker/source/cppumaker/cpputype.cxx 
b/codemaker/source/cppumaker/cpputype.cxx
index 15e1f116d638..c8b52857c648 100644
--- a/codemaker/source/cppumaker/cpputype.cxx
+++ b/codemaker/source/cppumaker/cpputype.cxx
@@ -449,7 +449,7 @@ void CppuType::dumpFile(
 throw;
 }
 out.close();
-makeValidTypeFile(
+(void)makeValidTypeFile(
u2b(fileUri), u2b(tmpUri), exists && options.isValid("-Gc"));
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

2018-01-26 Thread Eike Rathke

 sc/source/core/data/documen3.cxx |   14 ++
 1 file changed, 6 insertions(+), 8 deletions(-)

New commits:
commit 707e0f4e6b6e36432c0f04f22719428a7e1a50ee
Author: Eike Rathke 
Date:   Fri Jan 26 13:41:09 2018 +0100

coverity#1428613 check IsValidReference() return value, tdf#108989 follow-up

Also remove the unnecessary continue;break; construct and just
return if found.

Change-Id: Ib32ff214a1a24ef3ad3c6f7f659a8b7fde6b2d4a

diff --git a/sc/source/core/data/documen3.cxx b/sc/source/core/data/documen3.cxx
index f7f8687ca4b2..e5262cd23d89 100644
--- a/sc/source/core/data/documen3.cxx
+++ b/sc/source/core/data/documen3.cxx
@@ -212,7 +212,6 @@ bool ScDocument::IsAddressInRangeName( RangeNameScope 
eScope, ScAddress& rAddres
 {
 ScRangeName* pRangeNames;
 ScRange aNameRange;
-bool bRet = false;
 
 if (eScope == RangeNameScope::GLOBAL)
 pRangeNames= GetRangeName();
@@ -223,15 +222,14 @@ bool ScDocument::IsAddressInRangeName( RangeNameScope 
eScope, ScAddress& rAddres
 
 for (ScRangeName::iterator itr = itrBegin; itr != itrEnd; ++itr)
 {
-itr->second->IsValidReference(aNameRange);
-bRet = aNameRange.In(rAddress);
-if (!bRet)
-continue;
-else
-break;
+if (itr->second->IsValidReference(aNameRange))
+{
+if (aNameRange.In(rAddress))
+return true;
+}
 }
 
-return bRet;
+return false;
 }
 
 bool ScDocument::InsertNewRangeName( const OUString& rName, const ScAddress& 
rPos, const OUString& rExpr )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107567] Text previews in Paragraph dialog not showing correctly for RTL

https://bugs.documentfoundation.org/show_bug.cgi?id=107567

--- Comment #16 from Buovjaga  ---
(In reply to Samuel Mehrbrodt (CIB) from comment #15)
> Can someone please verify the fix? Then we can backport this to 6.0 too.

I verified it in December, see comment 13

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2018-01-26 Thread Mike Kaganski

 sc/source/ui/inc/tabview.hxx   |2 +-
 sc/source/ui/view/tabview2.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit fa3dc99fe354040aecfb64c4f5af49e313edfeef
Author: Mike Kaganski 
Date:   Fri Jan 26 08:38:31 2018 +0100

nMovX is SCCOL

Change-Id: I748f512fc424eacb2b56cb1a080b9ff15278c8d1
Reviewed-on: https://gerrit.libreoffice.org/48652
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/sc/source/ui/inc/tabview.hxx b/sc/source/ui/inc/tabview.hxx
index 885b207cbab3..e50d488c1d12 100644
--- a/sc/source/ui/inc/tabview.hxx
+++ b/sc/source/ui/inc/tabview.hxx
@@ -243,7 +243,7 @@ private:
 voidGetAreaMoveEndPosition(SCCOL nMovX, SCROW nMovY, 
ScFollowMode eMode,
SCCOL& rAreaX, SCROW& rAreaY, 
ScFollowMode& rMode);
 
-voidSkipCursorHorizontal(SCCOL& rCurX, SCROW& rCurY, SCCOL 
nOldX, SCROW nMovX);
+voidSkipCursorHorizontal(SCCOL& rCurX, SCROW& rCurY, SCCOL 
nOldX, SCCOL nMovX);
 voidSkipCursorVertical(SCCOL& rCurX, SCROW& rCurY, SCROW 
nOldY, SCROW nMovY);
 
 /**
diff --git a/sc/source/ui/view/tabview2.cxx b/sc/source/ui/view/tabview2.cxx
index da36ab8dff66..9653872b00cd 100644
--- a/sc/source/ui/view/tabview2.cxx
+++ b/sc/source/ui/view/tabview2.cxx
@@ -731,7 +731,7 @@ void ScTabView::GetAreaMoveEndPosition(SCCOL nMovX, SCROW 
nMovY, ScFollowMode eM
 rMode = eMode;
 }
 
-void ScTabView::SkipCursorHorizontal(SCCOL& rCurX, SCROW& rCurY, SCCOL nOldX, 
SCROW nMovX)
+void ScTabView::SkipCursorHorizontal(SCCOL& rCurX, SCROW& rCurY, SCCOL nOldX, 
SCCOL nMovX)
 {
 ScDocument* pDoc = aViewData.GetDocument();
 SCTAB nTab = aViewData.GetTabNo();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108817] Calc' s print preview starts at first page instead of page where user works

https://bugs.documentfoundation.org/show_bug.cgi?id=108817

Gülşah Köse  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108817] Calc' s print preview starts at first page instead of page where user works

https://bugs.documentfoundation.org/show_bug.cgi?id=108817

Gülşah Köse  changed:

   What|Removed |Added

   Assignee|gulsah.1...@gmail.com   |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: xmloff/source

 xmloff/source/draw/ximpshap.cxx |5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 013a4f951c016c7e266392a91e37a123c6d49a25
Author: Caolán McNamara 
Date:   Thu Jan 25 17:16:44 2018 +

ofz#5621 Integer-overflow

Change-Id: I621fb776457054f82078ed483c8b247acf734a3a
Reviewed-on: https://gerrit.libreoffice.org/48630
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/xmloff/source/draw/ximpshap.cxx b/xmloff/source/draw/ximpshap.cxx
index 5b6523a6ea5a..616dec4d1ba2 100644
--- a/xmloff/source/draw/ximpshap.cxx
+++ b/xmloff/source/draw/ximpshap.cxx
@@ -1091,8 +1091,8 @@ void SdXMLLineShapeContext::StartElement(const 
uno::Reference< xml::sax::XAttrib
 }
 
 // set sizes for transformation
-maSize.Width = aBottomRight.X - aTopLeft.X;
-maSize.Height = aBottomRight.Y - aTopLeft.Y;
+maSize.Width = o3tl::saturating_add(aBottomRight.X, -aTopLeft.X);
+maSize.Height = o3tl::saturating_add(aBottomRight.Y, -aTopLeft.Y);
 maPosition.X = aTopLeft.X;
 maPosition.Y = aTopLeft.Y;
 
@@ -1100,7 +1100,6 @@ void SdXMLLineShapeContext::StartElement(const 
uno::Reference< xml::sax::XAttrib
 SetTransformation();
 
 SdXMLShapeContext::StartElement(xAttrList);
-
 }
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115212] FILESAVE DOCX Change tracking deleted TOC entries cause invalid text node error in Word

https://bugs.documentfoundation.org/show_bug.cgi?id=115212

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #4 from Xisco Faulí  ---
I can't reproduce it in

Version: 6.1.0.0.alpha0+
Build ID: 5cb225b0b3dbb55fd44899b1fb16bdcfeb866849
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded

Do you reproduce it in master ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'libreoffice-6-0' - debian/loolwsd.service loolwsd.service

2018-01-26 Thread Andras Timar

 debian/loolwsd.service |2 +-
 loolwsd.service|2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit b0344acb473038418ff1a5f91c475b0e8f6d4d3b
Author: Andras Timar 
Date:   Mon Jan 22 23:08:49 2018 +0100

correct file server root for LibreOffice Online 6.0

Change-Id: I407c0f69e9a001a3a86f13926f0dc303c4df6d21
Reviewed-on: https://gerrit.libreoffice.org/48366
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/debian/loolwsd.service b/debian/loolwsd.service
index d43d5907..a2ae6e64 100644
--- a/debian/loolwsd.service
+++ b/debian/loolwsd.service
@@ -4,7 +4,7 @@ After=network.target
 
 [Service]
 EnvironmentFile=-/etc/sysconfig/loolwsd
-ExecStart=/usr/bin/loolwsd --version 
--o:sys_template_path=/opt/lool/systemplate 
--o:child_root_path=/opt/lool/child-roots 
--o:file_server_root_path=/usr/share/loolwsd
+ExecStart=/usr/bin/loolwsd --version 
--o:sys_template_path=/opt/lool/systemplate 
--o:child_root_path=/opt/lool/child-roots 
--o:file_server_root_path=/usr/share/libreoffice-online
 User=lool
 KillMode=control-group
 Restart=always
diff --git a/loolwsd.service b/loolwsd.service
index d43d5907..a2ae6e64 100644
--- a/loolwsd.service
+++ b/loolwsd.service
@@ -4,7 +4,7 @@ After=network.target
 
 [Service]
 EnvironmentFile=-/etc/sysconfig/loolwsd
-ExecStart=/usr/bin/loolwsd --version 
--o:sys_template_path=/opt/lool/systemplate 
--o:child_root_path=/opt/lool/child-roots 
--o:file_server_root_path=/usr/share/loolwsd
+ExecStart=/usr/bin/loolwsd --version 
--o:sys_template_path=/opt/lool/systemplate 
--o:child_root_path=/opt/lool/child-roots 
--o:file_server_root_path=/usr/share/libreoffice-online
 User=lool
 KillMode=control-group
 Restart=always
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: desktop/source

 desktop/source/lib/init.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d79c1e3c6eed70c221db8a82d061261d4835f618
Author: Caolán McNamara 
Date:   Fri Jan 26 12:05:10 2018 +

coverity#1428612 silence reasonable 'Unchecked return value' warning

Change-Id: If22f31471e0d15b6523355a44938c864b074ac93

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index dfff8646fef6..deba56c3eafc 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -3682,7 +3682,7 @@ static void preloadData()
 std::cerr << "Preload languages\n";
 // force load language singleton
 SvtLanguageTable::HasLanguageType(LANGUAGE_SYSTEM);
-LanguageTag::isValidBcp47("foo", nullptr);
+(void)LanguageTag::isValidBcp47("foo", nullptr);
 }
 
 static int lo_initialize(LibreOfficeKit* pThis, const char* pAppPath, const 
char* pUserProfileUrl)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'libreoffice-6-0' - loleaflet/dist

2018-01-26 Thread Andras Timar

 loleaflet/dist/toolbar/toolbar.js |   16 +++-
 1 file changed, 15 insertions(+), 1 deletion(-)

New commits:
commit 791fb5670b802cb4f3ad09973344d14fce18f620
Author: Andras Timar 
Date:   Wed Dec 27 22:17:22 2017 +0100

localize StateTableCell status bar string (Sum, Average, Count, etc.)

Change-Id: Ie4d6197115f8f8290f1d6f8608acf2e3e3642c79
Reviewed-on: https://gerrit.libreoffice.org/47107
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 
(cherry picked from commit 84bd0d7e5ebe1814eaecc973dedd9f66ee2881d8)
Reviewed-on: https://gerrit.libreoffice.org/47296
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/loleaflet/dist/toolbar/toolbar.js 
b/loleaflet/dist/toolbar/toolbar.js
index cb0b51a7..953917c2 100644
--- a/loleaflet/dist/toolbar/toolbar.js
+++ b/loleaflet/dist/toolbar/toolbar.js
@@ -712,6 +712,20 @@ var userJoinedPopupMessage = '' + _('%user has 
joined') + '';
 var userLeftPopupMessage = '' + _('%user has left') + '';
 var userPopupTimeout = null;
 
+function localizeStateTableCell (text) {
+   var stateArray = text.split(';');
+   var stateArrayLength = stateArray.length;
+   var localizedText = '';
+   for (var i = 0; i < stateArrayLength; i++) {
+   var labelValuePair = stateArray[i].split(':');
+   localizedText += _(labelValuePair[0].trim()) + ':' + 
labelValuePair[1];
+   if (stateArrayLength > 1 && i < stateArrayLength - 1) {
+   localizedText += '; ';
+   }
+   }
+   return localizedText;
+}
+
 function toLocalePattern (pattern, regex, text, sub1, sub2) {
var matches = new RegExp(regex, 'g').exec(text);
if (matches) {
@@ -1279,7 +1293,7 @@ map.on('commandstatechanged', function (e) {
updateToolbarItem(statusbar, 'StatusSelectionMode', 
$('#StatusSelectionMode').html(state ? 
L.Styles.selectionMode[state].toLocaleString() : 
'').parent().html());
}
else if (commandName == '.uno:StateTableCell') {
-   updateToolbarItem(statusbar, 'StateTableCell', 
$('#StateTableCell').html(state ? state : 
'').parent().html());
+   updateToolbarItem(statusbar, 'StateTableCell', 
$('#StateTableCell').html(state ? localizeStateTableCell(state) : 
'').parent().html());
}
else if (commandName === '.uno:StatusBarFunc') {
if (state) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

 vcl/source/filter/igif/gifread.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7ed8b9e3a9685eb3b07c65b7f2912612c5c9e810
Author: Caolán McNamara 
Date:   Fri Jan 26 12:01:04 2018 +

coverity#1428609 Unintended sign extension

and

coverity#1428610 Unintended sign extension

Change-Id: Ia6de85c7c438e610983a30204bda364367750d98

diff --git a/vcl/source/filter/igif/gifread.cxx 
b/vcl/source/filter/igif/gifread.cxx
index 78ed3036e67f..30cb0c674813 100644
--- a/vcl/source/filter/igif/gifread.cxx
+++ b/vcl/source/filter/igif/gifread.cxx
@@ -662,7 +662,7 @@ void GIFReader::CreateNewBitmaps()
 aAnimBmp.eDisposal = Disposal::Not;
 
 nAnimationByteSize += aAnimBmp.aBmpEx.GetSizeBytes();
-nAnimationMinFileData += nImageWidth * nImageHeight / 2560;
+nAnimationMinFileData += static_cast(nImageWidth) * 
nImageHeight / 2560;
 aAnimation.Insert( aAnimBmp );
 
 if( aAnimation.Count() == 1 )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115233] Replacing image resets the crop

https://bugs.documentfoundation.org/show_bug.cgi?id=115233

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
I can't reproduce it in

Version: 6.1.0.0.alpha0+
Build ID: 5cb225b0b3dbb55fd44899b1fb16bdcfeb866849
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded

Could you please try to reproduce it with the latest version of LibreOffice
from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115187] when importing a collada model, no errors occur but also nothing appears in the presentation

https://bugs.documentfoundation.org/show_bug.cgi?id=115187

Xisco Faulí  changed:

   What|Removed |Added

 Blocks||103759


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103759
[Bug 103759] [META] 3D model bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: AllLangHelp_swriter.mk source/media source/text

 AllLangHelp_swriter.mk 
 |1 
 
source/media/screenshots/modules/swriter/ui/watermarkdialog/WatermarkDialog.png 
|binary
 source/text/swriter/01/watermark.xhp   
 |   57 ++
 source/text/swriter/guide/pagebackground.xhp   
 |3 
 4 files changed, 60 insertions(+), 1 deletion(-)

New commits:
commit f15eac158a47aac87d5dc40004899871ebc5739e
Author: Olivier Hallot 
Date:   Thu Jan 25 17:47:31 2018 -0200

tdf#112356 Help page for watermark dialog

Change-Id: I3b509faf16579f1bfbf1428daca40f2d7054aad6
Reviewed-on: https://gerrit.libreoffice.org/48637
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/AllLangHelp_swriter.mk b/AllLangHelp_swriter.mk
index adf416fa5..188d41449 100644
--- a/AllLangHelp_swriter.mk
+++ b/AllLangHelp_swriter.mk
@@ -196,6 +196,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,swriter,\
 helpcontent2/source/text/swriter/01/mm_seltab \
 helpcontent2/source/text/swriter/01/selection_mode \
 helpcontent2/source/text/swriter/01/title_page \
+helpcontent2/source/text/swriter/01/watermark \
 helpcontent2/source/text/swriter/02/0211 \
 helpcontent2/source/text/swriter/02/0321 \
 helpcontent2/source/text/swriter/02/0322 \
diff --git 
a/source/media/screenshots/modules/swriter/ui/watermarkdialog/WatermarkDialog.png
 
b/source/media/screenshots/modules/swriter/ui/watermarkdialog/WatermarkDialog.png
new file mode 100644
index 0..2f3ff381a
Binary files /dev/null and 
b/source/media/screenshots/modules/swriter/ui/watermarkdialog/WatermarkDialog.png
 differ
diff --git a/source/text/swriter/01/watermark.xhp 
b/source/text/swriter/01/watermark.xhp
new file mode 100644
index 0..41fee8839
--- /dev/null
+++ b/source/text/swriter/01/watermark.xhp
@@ -0,0 +1,57 @@
+
+
+
+
+
+
+Page Watermark
+/text/swriter/01/watermark.xhp
+
+
+
+
+
+
+
+watermark;text documents
+watermark;page background
+page background;watermark
+
+
+Page Watermark
+Insert a watermark text 
in the current page style background.
+
+
+Choose Format - Watermark  

+
+A 
watermark is an identifying image or pattern in paper that appears as various 
shades of brightness when viewed by transmitted light. Watermarks were 
originally created directy during paper manufacturing to discourage 
counterfeiting of documents, currency bills, stamps and more.
+Use watermarks in %PRODUCTNAME Writer to simulate a paper 
watermark on the document pages.
+Fill the dialog settings below.
+The 
values entered applies to the actual page style.
+ 
+Text
+Enter the watermark text to be displayed as image in the page 
brackground.
+Font
+Select the font from the list.
+You 
cannot choose font size or font style for the watermark text. The text size 
will be scaled to fit in one line in the page brackground.
+Angle
+Select the slant angle for the watermark. A positive angle 
displays tha watermark from bottom to top. A negative value displays the 
watermark text from top to bottom.
+Transparency
+Select the transparency index for the watermark. A 0% value 
produce an opaque watermark and a value of 100% is totally transparent 
(invisible).
+Color
+Select color from the drop-down box.
+To change a watermark contents or setting.
+If 
the watermark in use is a text inserted by the Format - 
Watermark  menu command or by the document 
classification settings, you can edit the contents and settings on 
opening the watermark dialog.
+
+Document classification 
watermarks
+Page background
+
+
+
diff --git a/source/text/swriter/guide/pagebackground.xhp 
b/source/text/swriter/guide/pagebackground.xhp
index 44baea9b8..8bd4af4d0 100644
--- a/source/text/swriter/guide/pagebackground.xhp
+++ b/source/text/swriter/guide/pagebackground.xhp
@@ -128,6 +128,7 @@
 Click 
OK.
   
 
+
 
 
 
@@ -135,4 +136,4 @@
 
 
 
-
\ No newline at end of file
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 375b2f351dbc4b39274776aa06fbb1997dc579b7
Author: Olivier Hallot 
Date:   Thu Jan 25 17:47:31 2018 -0200

Updated core
Project: help  f15eac158a47aac87d5dc40004899871ebc5739e

tdf#112356 Help page for watermark dialog

Change-Id: I3b509faf16579f1bfbf1428daca40f2d7054aad6
Reviewed-on: https://gerrit.libreoffice.org/48637
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 482fb2a966c3..f15eac158a47 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 482fb2a966c3cfde24d94d7f43768b8edf63ceca
+Subproject commit f15eac158a47aac87d5dc40004899871ebc5739e
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 103759] [META] 3D model bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=103759

Xisco Faulí  changed:

   What|Removed |Added

 Depends on||115187


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115187
[Bug 115187] when importing a collada model, no errors occur but also nothing
appears in the presentation
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99619] Base crash when undo redo

https://bugs.documentfoundation.org/show_bug.cgi?id=99619

--- Comment #6 from Julien Nabet  ---
Created attachment 139372
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139372=edit
bt with debug symbols

On pc Debian x86-64 with master sources updated some days ago, I could
reproduce this.
Since the bt is different, I attach a new one.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99619] Base crash when undo redo

https://bugs.documentfoundation.org/show_bug.cgi?id=99619

Julien Nabet  changed:

   What|Removed |Added

 Attachment #124801|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115187] when importing a collada model, no errors occur but also nothing appears in the presentation

https://bugs.documentfoundation.org/show_bug.cgi?id=115187

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WONTFIX

--- Comment #5 from Xisco Faulí  ---
I guess we can close this as RESOLVED WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: help3xsl/xhp2html.sh

 help3xsl/xhp2html.sh |   14 --
 1 file changed, 4 insertions(+), 10 deletions(-)

New commits:
commit 482fb2a966c3cfde24d94d7f43768b8edf63ceca
Author: Olivier Hallot 
Date:   Fri Jan 26 09:46:22 2018 -0200

Adjust online builder xhp2html.sh to new bookmarks

Change-Id: Ie3a211d7247acd0ef7c15266368d9db7e1c8f232
Reviewed-on: https://gerrit.libreoffice.org/48681
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/help3xsl/xhp2html.sh b/help3xsl/xhp2html.sh
index d196625f2..919aa63f2 100755
--- a/help3xsl/xhp2html.sh
+++ b/help3xsl/xhp2html.sh
@@ -35,6 +35,8 @@ rm -f $bookmarkFile
 touch $bookmarkFile
 
 stub2=\'
+stub1='document.getElementById("Bookmarks").getElementsByClassName( "list" 
)[0].innerHTML='\'\\
+echo $stub1 >> $bookmarkFile
 
 xslfile=get_bookmark.xsl
 
@@ -42,43 +44,35 @@ param1=' --stringparam Language '$lang' --stringparam 
productversion '$productve
 
 # bookmarks for modules
 
-for i in CALC CHART WRITER DRAW IMPRESS MATH BASIC
+for i in WRITER CALC DRAW IMPRESS CHART MATH BASIC
 do
-stub1='document.getElementById("bookmark'$i'").innerHTML='\'\\
 sfind=$sourceDir'/'$(echo 'text/s'$i | tr '[:upper:]' '[:lower:]')
 param=$param1' --stringparam app '$i
 tempFile=$(mktemp)
 find $sfind -type f -name "*.xhp" -exec xsltproc $param $xslfile {} + >> 
$tempFile
-echo $stub1 >> $bookmarkFile
 sort -k3b -t\> -s -o $tempFile $tempFile
 awk 'NF' $tempFile >> $bookmarkFile
-echo $stub2 >> $bookmarkFile
 rm -f $tempFile
 done
 
 # Case of SHARED
 
-stub1='document.getElementById("bookmarkSHARED").innerHTML='\'\\
 tempFile=$(mktemp)
 param=$param1' --stringparam app SHARED'
 find $sourceDir'/text/shared' -type f -name "*.xhp" -exec xsltproc $param 
$xslfile {} + >> $tempFile
-echo $stub1 >> $bookmarkFile
 sort -k3b -t\> -s -o $tempFile $tempFile
 awk 'NF' $tempFile >> $bookmarkFile
-echo $stub2 >> $bookmarkFile
 rm -f $tempFile
 
 # Case of Explorer (BASE)
 
-stub1='document.getElementById("bookmarkBASE").innerHTML='\'\\
 tempFile=$(mktemp)
 param=$param1' --stringparam app BASE'
 find $sourceDir'/text/shared/explorer/database' -type f -name "*.xhp" -exec 
xsltproc $param $xslfile {} + >> $tempFile
-echo $stub1 >> $bookmarkFile
 sort -k3b -t\> -s -o $tempFile $tempFile
 awk 'NF' $tempFile >> $bookmarkFile
-echo $stub2 >> $bookmarkFile
 rm -f $tempFile
+echo $stub2 >> $bookmarkFile
 }
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 111837] Navigator: Lag in navigator selection update when clicking on next slide

https://bugs.documentfoundation.org/show_bug.cgi?id=111837

Tamás Zolnai  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |zolnaitamas2...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: helpcontent2

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0774af9889887fdd98ae65987f590c626def8d63
Author: Olivier Hallot 
Date:   Fri Jan 26 09:46:22 2018 -0200

Updated core
Project: help  482fb2a966c3cfde24d94d7f43768b8edf63ceca

Adjust online builder xhp2html.sh to new bookmarks

Change-Id: Ie3a211d7247acd0ef7c15266368d9db7e1c8f232
Reviewed-on: https://gerrit.libreoffice.org/48681
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 67a993c05d19..482fb2a966c3 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 67a993c05d19976f5ed347b16584d29d6866a870
+Subproject commit 482fb2a966c3cfde24d94d7f43768b8edf63ceca
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 111789] TextBox shadow propeties are not saved to PPTX

https://bugs.documentfoundation.org/show_bug.cgi?id=111789

Tamás Zolnai  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |zolnaitamas2...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114458] Can't finished the job. Application Just keep running

https://bugs.documentfoundation.org/show_bug.cgi?id=114458

--- Comment #3 from Xisco Faulí  ---
Hi Leon,
Does it work if you call LibreOffice from the terminal ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa writerfilter/source

2018-01-26 Thread Justin Luth

 sw/qa/extras/ooxmlexport/ooxmlexport10.cxx|8 ++
 writerfilter/source/dmapper/DomainMapper.cxx  |   75 -
 writerfilter/source/dmapper/DomainMapper_Impl.cxx |   77 ++
 3 files changed, 85 insertions(+), 75 deletions(-)

New commits:
commit cc1c9c7484d97167021301f32c3397124c4d79f5
Author: Justin Luth 
Date:   Tue Jan 23 21:56:00 2018 +0300

tdf#95377 ooxmlimport: treat default style like named styles

The default style was missing out on all of the fixes made
by LN_CT_PPrBase_pStyle. That included right margins, and
numbering styles.

Essentially, this change is just copy and paste from one function
to another. I tried to make all of the logic changes
separately in previous commits. So the adjustments here are simply
to accommodate different variable/function names. So if this
causes any regressions, it ought to just be related to either
applying later on (at finishparagraph instead of
LN_CT_PPrBase_pStyle or because it includes the default style.

One important note regards the preparatory
commit 254c80037a3939c110d5c66fef6c28caf47625e5.
If this commit is reverted, make sure to check that commit
to add a conditional wrappers around GetCurrentNumberingRules().

Change-Id: I9827b2cd1a74a13cf18ada9baa221c5c567a7391
Reviewed-on: https://gerrit.libreoffice.org/48458
Tested-by: Jenkins 
Reviewed-by: Justin Luth 
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx
index 9128303db319..4451e06148f1 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx
@@ -921,6 +921,14 @@ DECLARE_OOXMLEXPORT_TEST(testTdf95377, "tdf95377.docx")
 CPPUNIT_ASSERT_EQUAL(sal_Int32(-250), getProperty(xParagraph, 
"ParaFirstLineIndent"));
 CPPUNIT_ASSERT_EQUAL(sal_Int32(250), getProperty(xParagraph, 
"ParaLeftMargin"));
 CPPUNIT_ASSERT_EQUAL(beans::PropertyState_DIRECT_VALUE, 
xParagraph->getPropertyState("ParaFirstLineIndent"));
+
+//default style has numbering enabled.  Styles inherit numbering unless 
specifically disabled
+xmlDocPtr pXmlDoc = parseLayoutDump();
+assertXPath(pXmlDoc, "//body/txt/Special", 3);  //first three paragraphs 
have numbering
+assertXPath(pXmlDoc, "//body/txt[1]/Special", "rText", "a.");
+assertXPath(pXmlDoc, "//body/txt[2]/Special", "rText", "b.");
+assertXPath(pXmlDoc, "//body/txt[3]/Special", "rText", "c.");
+assertXPath(pXmlDoc, "/root/page/body/txt[4]/Special", 0); //last 
paragraph style disables numbering
 }
 
 DECLARE_OOXMLEXPORT_TEST(testTdf95376, "tdf95376.docx")
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index 9acb00fb86ae..a573275a338b 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -1194,30 +1194,6 @@ static bool ExchangeLeftRight(const PropertyMapPtr& 
rContext, DomainMapper_Impl&
 return bExchangeLeftRight;
 }
 
-/// Check if the style or its parent has a list id, recursively.
-static sal_Int32 lcl_getListId(const StyleSheetEntryPtr& rEntry, const 
StyleSheetTablePtr& rStyleTable)
-{
-const StyleSheetPropertyMap* pEntryProperties = dynamic_cast(rEntry->pProperties.get());
-if (!pEntryProperties)
-return -1;
-
-sal_Int32 nListId = pEntryProperties->GetListId();
-// The style itself has a list id.
-if (nListId >= 0)
-return nListId;
-
-// The style has no parent.
-if (rEntry->sBaseStyleIdentifier.isEmpty())
-return -1;
-
-const StyleSheetEntryPtr pParent = 
rStyleTable->FindStyleSheetByISTD(rEntry->sBaseStyleIdentifier);
-// No such parent style or loop in the style hierarchy.
-if (!pParent || pParent == rEntry)
-return -1;
-
-return lcl_getListId(pParent, rStyleTable);
-}
-
 void DomainMapper::sprmWithProps( Sprm& rSprm, const PropertyMapPtr& rContext )
 {
 // These SPRM's are not specific to any section, so it's expected that 
there is no context yet.
@@ -2121,57 +2097,6 @@ void DomainMapper::sprmWithProps( Sprm& rSprm, const 
PropertyMapPtr& rContext )
 const OUString sConvertedStyleName = pStyleTable->ConvertStyleName( 
sStringValue, true );
 if (m_pImpl->GetTopContext() && m_pImpl->GetTopContextType() != 
CONTEXT_SECTION)
 m_pImpl->GetTopContext()->Insert( PROP_PARA_STYLE_NAME, 
uno::makeAny( sConvertedStyleName ));
-//apply numbering to paragraph if it was set at the style, but only if 
the paragraph itself
-//does not specify the numbering
-if( !rContext->isSet(PROP_NUMBERING_RULES) ) // !contains
-{
-const StyleSheetEntryPtr pEntry = 
pStyleTable->FindStyleSheetByISTD(sStringValue);
-OSL_ENSURE(

[Libreoffice-bugs] [Bug 114050] Image compression seems to be rather slow and CPU hogging for high resolution images

https://bugs.documentfoundation.org/show_bug.cgi?id=114050

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||xiscofa...@libreoffice.org
 Resolution|--- |WONTFIX

--- Comment #3 from Xisco Faulí  ---
Hi Telesto,
Thanks for reporting this issue.
IMHO, this report is to vague and general i don't think anybody would work on
it.
What's the goal here? being faster than FastStone image viewer/IrfanView) ?
Probably, if you test hundreds of pictures, LibreOffice will be faster in some
cases.
OTOH, is 3 seconds of difference such a big deal? probably even the timing
would be different with a different OS or HW.
I'd say: RESOLVED WONTFIX. Please, change it back to UNCONFIRMED if you
disagree.
Regards

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker

https://bugs.documentfoundation.org/show_bug.cgi?id=108226
Bug 108226 depends on bug 107608, which changed state.

Bug 107608 Summary: FILEOPEN PPTX: pattern fill has transparent background 
instead of white background
https://bugs.documentfoundation.org/show_bug.cgi?id=107608

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/oox oox/source sd/qa

2018-01-26 Thread Tamás Zolnai

 include/oox/drawingml/shapepropertymap.hxx |3 
 oox/source/drawingml/fillproperties.cxx|9 +-
 oox/source/drawingml/shapepropertymap.cxx  |3 
 oox/source/token/properties.txt|1 
 sd/qa/unit/data/pptx/tdf107608.pptx|binary
 sd/qa/unit/data/xml/n820786_0.xml  |  102 ++---
 sd/qa/unit/export-tests-ooxml2.cxx |   26 +++
 7 files changed, 89 insertions(+), 55 deletions(-)

New commits:
commit 232251e11aecf051bc0e2a915e5af6c0d3650469
Author: Tamás Zolnai 
Date:   Thu Jan 25 18:32:53 2018 +0100

tdf#107608: PPTX: Import pattern fill background color

Change-Id: Ic7e9dc314c961605fc8467eebd465fa286993e17
Reviewed-on: https://gerrit.libreoffice.org/48633
Tested-by: Jenkins 
Reviewed-by: Tamás Zolnai 

diff --git a/include/oox/drawingml/shapepropertymap.hxx 
b/include/oox/drawingml/shapepropertymap.hxx
index 2ff40651ec33..86dbd569ebc7 100644
--- a/include/oox/drawingml/shapepropertymap.hxx
+++ b/include/oox/drawingml/shapepropertymap.hxx
@@ -73,7 +73,8 @@ enum class ShapeProperty
 FillHatch,
 ShadowXDistance,
 FillBitmapNameFromUrl,
-LAST = FillBitmapNameFromUrl
+FillBackground,
+LAST = FillBackground
 };
 
 typedef o3tl::enumarray ShapePropertyIds;
diff --git a/oox/source/drawingml/fillproperties.cxx 
b/oox/source/drawingml/fillproperties.cxx
index 3d81ec94c71c..d2d2775a3e3d 100644
--- a/oox/source/drawingml/fillproperties.cxx
+++ b/oox/source/drawingml/fillproperties.cxx
@@ -673,10 +673,15 @@ void FillProperties::pushToPropMap( ShapePropertyMap& 
rPropMap,
 Color aColor( maPatternProps.maPattFgColor );
 if( aColor.isUsed() && maPatternProps.moPattPreset.has() )
 {
-// we do not support hatches that have background
-// color too, so all this is some best-effort approach
 eFillStyle = FillStyle_HATCH;
 rPropMap.setProperty( ShapeProperty::FillHatch, 
createHatch( maPatternProps.moPattPreset.get(), aColor.getColor( 
rGraphicHelper, nPhClr ) ) );
+
+// Set background color for hatch
+if(maPatternProps.maPattBgColor.isUsed())
+{
+rPropMap.setProperty( 
ShapeProperty::FillBackground, true );
+rPropMap.setProperty( ShapeProperty::FillColor, 
maPatternProps.maPattBgColor.getColor( rGraphicHelper, nPhClr ) );
+}
 }
 else if ( maPatternProps.maPattBgColor.isUsed() )
 {
diff --git a/oox/source/drawingml/shapepropertymap.cxx 
b/oox/source/drawingml/shapepropertymap.cxx
index 6f71873df362..b1cf0239237e 100644
--- a/oox/source/drawingml/shapepropertymap.cxx
+++ b/oox/source/drawingml/shapepropertymap.cxx
@@ -45,7 +45,8 @@ static const ShapePropertyIds spnDefaultShapeIds =
 PROP_FillBitmapPositionOffsetX, PROP_FillBitmapPositionOffsetY, 
PROP_FillBitmapRectanglePoint,
 PROP_FillHatch,
 PROP_ShadowXDistance,
-PROP_FillBitmapName
+PROP_FillBitmapName,
+PROP_FillBackground
 };
 
 } // namespace
diff --git a/oox/source/token/properties.txt b/oox/source/token/properties.txt
index e6bc79ff3d08..caab75eae4d4 100644
--- a/oox/source/token/properties.txt
+++ b/oox/source/token/properties.txt
@@ -158,6 +158,7 @@ ExternalLinks
 ExtrapolateBackward
 ExtrapolateForward
 FileFormat
+FillBackground
 FillBitmapMode
 FillBitmapName
 FillBitmapPositionOffsetX
diff --git a/sd/qa/unit/data/pptx/tdf107608.pptx 
b/sd/qa/unit/data/pptx/tdf107608.pptx
new file mode 100755
index ..52973c8ed5aa
Binary files /dev/null and b/sd/qa/unit/data/pptx/tdf107608.pptx differ
diff --git a/sd/qa/unit/data/xml/n820786_0.xml 
b/sd/qa/unit/data/xml/n820786_0.xml
index 53a8ee93610d..a1a7b775faba 100644
--- a/sd/qa/unit/data/xml/n820786_0.xml
+++ b/sd/qa/unit/data/xml/n820786_0.xml
@@ -1,6 +1,6 @@
 
 
- 
+ 
   
   
   
@@ -65,7 +65,7 @@
  
  
   
-   
+   
 
 
 
@@ -148,7 +148,7 @@
  
 

-   
+   
 
 
 
@@ -238,7 +238,7 @@

   
  
- 
+ 
   
   
   
@@ -301,7 +301,7 @@

   
  
- 
+ 
   
   
   
@@ -364,7 +364,7 @@

   
  
- 
+ 
   
   
   
@@ -427,7 +427,7 @@

   
  
- 
+ 
   
   
   
@@ -490,7 +490,7 @@

   
  
- 
+ 
   
   
   
@@ -553,7 +553,7 @@

   
  
- 
+ 
   
   
   
@@ -616,7 +616,7 @@

   
  
- 
+ 
   
   
   
@@ -679,7 +679,7 @@

   
  
- 
+ 
   
   
   
@@ -742,7 +742,7 @@

   
  
- 
+ 
   
   
   
@@ -805,7 +805,7 @@

   
  
- 
+ 
   
   
   
@@ -868,7 +868,7 @@

   
  
- 
+ 
   
   
   
@@ -931,7 +931,7 @@

   
  
- 
+ 
   
   
   
@@ -994,7 +994,7 @@

   
  
- 
+ 
   
   
   
@@ -1057,7 +1057,7 @@

   
  
- 
+ 
   
   
   
@@ -1120,7

[Libreoffice-bugs] [Bug 115205] FILESAVE HTMLEXPORT images are overlapped when spreadsheet exported as HTML

https://bugs.documentfoundation.org/show_bug.cgi?id=115205

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 CC||xiscofa...@libreoffice.org
 Ever confirmed|1   |0

--- Comment #3 from Xisco Faulí  ---
You can't confirm your own bugs. Moving it back to UNCONFIRMED until someone
else confirms it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115240] LibreOffice 6.0.0.2rc Merge Cells loses formatting on adjacent cells

https://bugs.documentfoundation.org/show_bug.cgi?id=115240

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||xiscofa...@libreoffice.org
 Resolution|--- |DUPLICATE

--- Comment #3 from Xisco Faulí  ---
Hi john,
Thanks for reporting this issue.
This looks like a dupe of bug.
Armin is already looking into it and it will be fixed soon.
Regards

*** This bug has been marked as a duplicate of bug 113751 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'libreoffice-6-0' - loleaflet/admin.strings.js loleaflet/dist loleaflet/Makefile.am loleaflet/src

2018-01-26 Thread Andras Timar

 loleaflet/Makefile.am   |1 +
 loleaflet/admin.strings.js  |3 +++
 loleaflet/dist/admin/adminHistory.html  |6 +++---
 loleaflet/src/admin/AdminSocketAnalytics.js |4 ++--
 4 files changed, 9 insertions(+), 5 deletions(-)

New commits:
commit 5e6388f9212fe823d49f8eccb1c7fb0c430a15d0
Author: Andras Timar 
Date:   Tue Jan 2 23:55:04 2018 +0100

l10n: admin console fixes

Change-Id: I047e90c4977bcca2a8968d1af5422742b4ae43db
Reviewed-on: https://gerrit.libreoffice.org/47288
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 
(cherry picked from commit 6aa893badf1c1bc1669fac304a824663b5432868)
Reviewed-on: https://gerrit.libreoffice.org/47294
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index 07209238..46fa1dcc 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -50,6 +50,7 @@ pot:
unocommands.js \
dist/errormessages.js \
dist/toolbar/toolbar.js \
+   src/admin/AdminSocketAnalytics.js \
src/admin/AdminSocketBase.js \
src/admin/AdminSocketOverview.js \
src/admin/AdminSocketHistory.js \
diff --git a/loleaflet/admin.strings.js b/loleaflet/admin.strings.js
index 06812103..d4851649 100644
--- a/loleaflet/admin.strings.js
+++ b/loleaflet/admin.strings.js
@@ -35,6 +35,9 @@ l10nstrings.strCpuStatsInterval = _('Time interval of CPU 
statistics (in ms)');
 l10nstrings.strLimitVirtMemMb = _('Maximum Document process virtual memory (in 
MB) - reduce only');
 l10nstrings.strLimitStackMemKb = _('Maximum Document process stack memory (in 
KB) - reduce only');
 l10nstrings.strLimitFileSizeMb = _('Maximum file size allowed to write to disk 
(in MB) - reduce only');
+l10nstrings.strDocuments = _('Documents:');
+l10nstrings.strExpired = _('Expired:');
+l10nstrings.strRefresh = _('Refresh');
 
 if (module) {
module.exports = l10nstrings;
diff --git a/loleaflet/dist/admin/adminHistory.html 
b/loleaflet/dist/admin/adminHistory.html
index ba71ca0e..76dec2c9 100644
--- a/loleaflet/dist/admin/adminHistory.html
+++ b/loleaflet/dist/admin/adminHistory.html
@@ -64,10 +64,10 @@
 
 
   document.write(l10nstrings.strHistory)
-  refresh
+  document.write(l10nstrings.strRefresh)
   
-Documents:
-Expired:
+document.write(l10nstrings.strDocuments)
+document.write(l10nstrings.strExpired)
 
   
 
diff --git a/loleaflet/src/admin/AdminSocketAnalytics.js 
b/loleaflet/src/admin/AdminSocketAnalytics.js
index 7652d4b6..29473cac 100644
--- a/loleaflet/src/admin/AdminSocketAnalytics.js
+++ b/loleaflet/src/admin/AdminSocketAnalytics.js
@@ -214,11 +214,11 @@ var AdminSocketAnalytics = AdminSocketBase.extend({
 
var legendData = [
{
-   text: 'Recieved',
+   text: _('Received'),
color: 'red'
},
{
-   text: 'Sent',
+   text: _('Sent'),
color: 'green'
}
];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114679] MacOS: Copying the installation files is quite slow

https://bugs.documentfoundation.org/show_bug.cgi?id=114679

Telesto  changed:

   What|Removed |Added

 CC||cl...@documentfoundation.or
   ||g

--- Comment #2 from Telesto  ---
Cloph. Has there been a change related to the packaging of the MacOS installer
between 5.3 and 5.4? Which could cause a signing issue or something like that?

There is a noticeable slowness when copying the installer files to the Programs
directory. http://crl.apple.com/root is showing up in the console...

(Bug 114364 might me related to this too.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114221] Calc corrupts password-protected XLS on save (Save as works) - newer MSO 2013 encryption saved as unencrypted file with encryption mode

https://bugs.documentfoundation.org/show_bug.cgi?id=114221

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113541] EDITING - Link to external documents is not created correctly - incorrect URL formation when path contains upper case , spaces and '!', '#' or '$' characters

https://bugs.documentfoundation.org/show_bug.cgi?id=113541

Xisco Faulí  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |WORKSFORME
 Whiteboard||backportRequest

--- Comment #12 from Xisco Faulí  ---
It means the issue is fixed in master but not yet backported to 6-0 branch.
Closing as RESOLVED WORKSFORME and add the whiteboard 'backportRequest' to see
if someone can check when it was fixed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115238] Menu items are shown to the top of the menu boundary ( covers the menu thus makes the menu invisible)

https://bugs.documentfoundation.org/show_bug.cgi?id=115238

Kevin Suo  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=91
   ||781

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115231] FILESAVE: ODT: Signature is not displayed after RT

https://bugs.documentfoundation.org/show_bug.cgi?id=115231

--- Comment #5 from Samuel Mehrbrodt (CIB)  ---
(In reply to Xisco Faulí from comment #4)
> Ouch, I was too fast then.
> if you agree, we can leave it Open and close it once your work with bug
> 83877 is finished

Fine with me

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: officecfg/registry sc/source sc/uiconfig

2018-01-26 Thread manujvashist

 officecfg/registry/schema/org/openoffice/Office/Calc.xcs |   21 +
 sc/source/ui/dbgui/asciiopt.cxx  |   59 +++
 sc/source/ui/dbgui/csvgrid.cxx   |4 -
 sc/source/ui/dbgui/csvtablebox.cxx   |4 -
 sc/source/ui/dbgui/imoptdlg.cxx  |7 +
 sc/source/ui/dbgui/scuiasciiopt.cxx  |   32 ++--
 sc/source/ui/docshell/impex.cxx  |   24 +-
 sc/source/ui/inc/asciiopt.hxx|5 +
 sc/source/ui/inc/csvgrid.hxx |2 
 sc/source/ui/inc/csvtablebox.hxx |2 
 sc/source/ui/inc/imoptdlg.hxx|2 
 sc/source/ui/inc/impex.hxx   |2 
 sc/source/ui/inc/scuiasciiopt.hxx|1 
 sc/uiconfig/scalc/ui/textimportcsv.ui|   18 
 14 files changed, 148 insertions(+), 35 deletions(-)

New commits:
commit d999b55e28d0445df870f69b3a269964e3635def
Author: manujvashist 
Date:   Sun Dec 10 10:56:38 2017 +0530

tdf#114200  : added 'Trim space' feature in 'Text Import'

made a checkbox to Trim extra white spaces from both ends
while using seperators in 'Text Imort'

Change-Id: Ib05d9b17525e3ebec380ec8b7eebfa35fff78f01
Reviewed-on: https://gerrit.libreoffice.org/46177
Tested-by: Jenkins 
Reviewed-by: Manuj Vashist 
Reviewed-by: Heiko Tietze 
Tested-by: Heiko Tietze 

diff --git a/officecfg/registry/schema/org/openoffice/Office/Calc.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
index 2d5e7a8696e0..7951d4bf91cc 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
@@ -1088,6 +1088,13 @@
   
   false
 
+
+  
+If true, leading and trailing white spaces are trimmed 
off.
+RemoveSpace
+  
+  false
+
 
   
 If true, quoted field is always imported as text with no 
exception.
@@ -1163,6 +1170,13 @@
   
   false
 
+
+  
+If true, leading and trailing white spaces are trimmed 
off.
+RemoveSpace
+  
+  false
+
 
   
 If true, quoted field is always imported as text with no 
exception.
@@ -1245,6 +1259,13 @@
   
   false
 
+
+  
+If true, leading and trailing white spaces are trimmed 
off.
+RemoveSpace
+  
+  false
+
 
   
 List of Separators - as a String
diff --git a/sc/source/ui/dbgui/asciiopt.cxx b/sc/source/ui/dbgui/asciiopt.cxx
index 3032106518f4..d699b4ea3675 100644
--- a/sc/source/ui/dbgui/asciiopt.cxx
+++ b/sc/source/ui/dbgui/asciiopt.cxx
@@ -29,9 +29,12 @@ ScAsciiOptions::ScAsciiOptions() :
 bFixedLen   ( false ),
 aFieldSeps  ( OUString(';') ),
 bMergeFieldSeps ( false ),
+bRemoveSpace( false ),
 bQuotedFieldAsText(false),
 bDetectSpecialNumber(false),
 bSkipEmptyCells(false),
+bSaveAsShown(true),
+bSaveFormulas(false),
 cTextSep( cDefaultTextSep ),
 eCharSet( osl_getThreadTextEncoding() ),
 eLang   ( LANGUAGE_SYSTEM ),
@@ -74,7 +77,12 @@ ScAsciiOptions& ScAsciiOptions::operator=( const 
ScAsciiOptions& rCpy )
 bFixedLen   = rCpy.bFixedLen;
 aFieldSeps  = rCpy.aFieldSeps;
 bMergeFieldSeps = rCpy.bMergeFieldSeps;
+bRemoveSpace= rCpy.bRemoveSpace;
 bQuotedFieldAsText = rCpy.bQuotedFieldAsText;
+bDetectSpecialNumber = rCpy.bDetectSpecialNumber;
+bSkipEmptyCells = rCpy.bSkipEmptyCells;
+bSaveAsShown= rCpy.bSaveAsShown;
+bSaveFormulas   = rCpy.bSaveFormulas;
 cTextSep= rCpy.cTextSep;
 eCharSet= rCpy.eCharSet;
 bCharSetSystem  = rCpy.bCharSetSystem;
@@ -180,15 +188,34 @@ void ScAsciiOptions::ReadFromString( const OUString& 
rString )
 else
 bDetectSpecialNumber = true;// default of versions that didn't add 
the parameter
 
-// 9th token is used for "Save as shown" in export options
-// 10th token is used for "Save cell formulas" in export options
+// Token 8: used for "Save as shown" in export options
+if ( nPos >= 0 )
+{
+bSaveAsShown = rString.getToken(0, ',', nPos) == "true";
+}
+else
+bSaveAsShown = true;//default value
+// Token 9: used for "Save cell formulas" in export options
+if ( nPos >= 0 )
+{
+bSaveFormulas = rString.getToken(0, ',', nPos) == "true";
+}
+else
+bSaveFormulas = false;
+// Token 10: Boolean for Trim spaces.
+if

[Libreoffice-bugs] [Bug 115226] Update bundled Amiri to 0.111

https://bugs.documentfoundation.org/show_bug.cgi?id=115226

--- Comment #3 from Volga  ---
So if an user installed Amiri v1.111, does MSI package replace it to older
version?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108604] wrong kashida placement when exporting to PDF

https://bugs.documentfoundation.org/show_bug.cgi?id=108604

Buovjaga  changed:

   What|Removed |Added

 CC||khaledho...@eglug.org

--- Comment #11 from Buovjaga  ---
(In reply to Khaled Hosny from comment #10)
> Isn’t this a duplicate of bug 113428?

I guess not, as the problem remains.

Arch Linux 64-bit
Version: 6.1.0.0.alpha0+
Build ID: 19f8a979ff86be39a3938b3d7b25c1431191e708
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group threaded
Built on January 25th 2018

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/source dbaccess/source filter/source odk/examples ridljar/com sc/source sd/qa svtools/source sw/source test/source udkapi/com vcl/unx

2018-01-26 Thread Andrea Gelmini

 cui/source/dialogs/hltpbase.cxx
  |4 ++--
 dbaccess/source/core/api/RowSet.cxx
  |2 +-
 filter/source/xslt/export/spreadsheetml/table.xsl  
  |2 +-
 filter/source/xslt/odf2xhtml/export/common/styles/style_collector.xsl  
  |2 +-
 
odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/FlatXmlFilterDetection/filterdetect.cxx
 |2 +-
 ridljar/com/sun/star/lib/util/DisposeNotifier.java 
  |2 +-
 sc/source/ui/vba/vbavalidation.cxx 
  |2 +-
 sd/qa/unit/dialogs-test.cxx
  |2 +-
 svtools/source/misc/embedtransfer.cxx  
  |2 +-
 sw/source/core/layout/wsfrm.cxx
  |2 +-
 sw/source/filter/ww8/docxexport.cxx
  |2 +-
 test/source/screenshot_test.cxx
  |2 +-
 udkapi/com/sun/star/beans/XMultiPropertyStates.idl 
  |4 ++--
 vcl/unx/generic/print/psheader.ps  
  |4 ++--
 14 files changed, 17 insertions(+), 17 deletions(-)

New commits:
commit 32b2a1831d819f73def1485d1589522cd19f9f6c
Author: Andrea Gelmini 
Date:   Fri Jan 26 10:52:43 2018 +0100

Fix typos

Change-Id: I334f0bd5636940ea8105dcf93b95b3af28894aad
Reviewed-on: https://gerrit.libreoffice.org/48546
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/cui/source/dialogs/hltpbase.cxx b/cui/source/dialogs/hltpbase.cxx
index 933f3c394512..27cdd55e75a2 100644
--- a/cui/source/dialogs/hltpbase.cxx
+++ b/cui/source/dialogs/hltpbase.cxx
@@ -280,7 +280,7 @@ void SvxHyperlinkTabPageBase::FillStandardDlgFields ( const 
SvxHyperlinkItem* pH
 // Any action to do after apply-button is pressed
 void SvxHyperlinkTabPageBase::DoApply ()
 {
-// default-implemtation : do nothing
+// default-implementation : do nothing
 }
 
 // Ask page whether an insert is possible
@@ -293,7 +293,7 @@ bool SvxHyperlinkTabPageBase::AskApply ()
 // This method would be called from bookmark-window to set new mark-string
 void SvxHyperlinkTabPageBase::SetMarkStr ( const OUString& /*aStrMark*/ )
 {
-// default-implemtation : do nothing
+// default-implementation : do nothing
 }
 
 // Set initial focus
diff --git a/dbaccess/source/core/api/RowSet.cxx 
b/dbaccess/source/core/api/RowSet.cxx
index e83c9e896abf..1633376d7653 100644
--- a/dbaccess/source/core/api/RowSet.cxx
+++ b/dbaccess/source/core/api/RowSet.cxx
@@ -526,7 +526,7 @@ void SAL_CALL ORowSet::disposing()
 xComponent->removeEventListener(xEvt);
 }
 
-m_aActiveConnection = Any(); // the any conatains a reference too
+m_aActiveConnection = Any(); // the any contains a reference too
 if(m_bOwnConnection)
 ::comphelper::disposeComponent(m_xActiveConnection);
 m_xActiveConnection = nullptr;
diff --git a/filter/source/xslt/export/spreadsheetml/table.xsl 
b/filter/source/xslt/export/spreadsheetml/table.xsl
index a1dca71ec087..6a8c8bddb76e 100644
--- a/filter/source/xslt/export/spreadsheetml/table.xsl
+++ b/filter/source/xslt/export/spreadsheetml/table.xsl
@@ -834,7 +834,7 @@
 000
 
 
-
+
 
 T
 
diff --git 
a/filter/source/xslt/odf2xhtml/export/common/styles/style_collector.xsl 
b/filter/source/xslt/odf2xhtml/export/common/styles/style_collector.xsl
index be331280ed72..f66c3d79fcf8 100644
--- a/filter/source/xslt/odf2xhtml/export/common/styles/style_collector.xsl
+++ b/filter/source/xslt/odf2xhtml/export/common/styles/style_collector.xsl
@@ -630,7 +630,7 @@
 
 
 
 
 
diff --git 
a/odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/FlatXmlFilterDetection/filterdetect.cxx
 
b/odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/FlatXmlFilterDetection/filterdetect.cxx
index c9323efb940f..8d9e75e0b848 100644
--- 
a/odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/FlatXmlFilterDetection/filterdetect.cxx
+++ 
b/odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/FlatXmlFilterDetection/filterdetect.cxx
@@ -113,7 +113,7 @@ OUString SAL_CALL FilterDetect::detect(Sequence< 
PropertyValue >& aArguments )
 }
 
 // flatxml starts with an office:document element. this

[Libreoffice-bugs] [Bug 115231] FILESAVE: ODT: Signature is not displayed after RT

https://bugs.documentfoundation.org/show_bug.cgi?id=115231

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=83
   ||877

--- Comment #4 from Xisco Faulí  ---
(In reply to Samuel Mehrbrodt (CIB) from comment #3)
> The import is not yet implemented ;)
> Bug 83877 is still in progress...
> 
> But note that this only affects current master, not any released version.

Ouch, I was too fast then.
if you agree, we can leave it Open and close it once your work with bug 83877
is finished

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108473] Inserting into a Form Table Control Date/Time (Time) field gets stuck

https://bugs.documentfoundation.org/show_bug.cgi?id=108473

Julien Nabet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||lio...@mamane.lu
   Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr
   |desktop.org |

--- Comment #8 from Julien Nabet  ---
I submitted a patch to review here:
https://gerrit.libreoffice.org/#/c/48665/

Lionel: don't hesitate to comment on bugtracker or on gerrit. Perhaps the patch
is a bit naive.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114736] Crash with CJK characters in status bar (OpenGL)