date:20180130

[Libreoffice-bugs] [Bug 115324] New: Deleting cell contents doesn't preserve height

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115324

Bug ID: 115324
   Summary: Deleting cell contents doesn't preserve height
   Product: LibreOffice
   Version: 6.0.0.2 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ddascalescu+freedesk...@gmail.com

Created attachment 139457
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139457=edit
Delete the contents of cell N13 and notice the row height increasing

1. Open the attached food-bug.xls
2. Click on cell N13
3. Press Delete or clear the cell's contents

Notice how the row height increased.

Reproduced in both 6.0.0.2 and 5.4.4.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

--- Comment #8 from Tor Lillqvist  ---
> So if i get this correctly, you want to implement LO's fullscreen mode but be 
> able to toggle it with OSX fullscreen mode green button and shortcut.

Yes.

> wouldnt users want that same functionality in a fullscreen mode with LO when 
> toggled with the green bubble and not what LO defines as a fullscreen mode

How is that different from maximising the window (double-clicking the title
bar)?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/xmloff xmloff/source

2018-01-30 Thread Noel Grandin

 include/xmloff/xmlexp.hxx |   14 +++---
 xmloff/source/core/xmlexp.cxx |   42 +-
 2 files changed, 28 insertions(+), 28 deletions(-)

New commits:
commit a8c1083553ee4c0d85bacef4ea4cdef0de8927d3
Author: Noel Grandin 
Date:   Wed Jan 17 11:08:46 2018 +0200

loplugin:useuniqueptr in SvXMLExport

Change-Id: I8ce26b7cddeb74fd86f60896c84bf3574ccbc9bc
Reviewed-on: https://gerrit.libreoffice.org/48421
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/xmloff/xmlexp.hxx b/include/xmloff/xmlexp.hxx
index ad934e1f612a..fe73d0d6ab5d 100644
--- a/include/xmloff/xmlexp.hxx
+++ b/include/xmloff/xmlexp.hxx
@@ -140,10 +140,10 @@ class XMLOFF_DLLPUBLIC SvXMLExport : public 
cppu::WeakImplHelper<
 OUString msEmbeddedObjectProtocol;
 OUString msFilterName;
 OUString msImgFilterName;
-SvXMLNamespaceMap   *mpNamespaceMap;// the namepspace map
+std::unique_ptr mpNamespaceMap;// the namepspace map
 SvXMLUnitConverter  maUnitConv;// the unit converter
-SvXMLNumFmtExport   *mpNumExport;
-ProgressBarHelper   *mpProgressBarHelper;
+std::unique_ptr mpNumExport;
+std::unique_ptr mpProgressBarHelper;
 
 rtl::Reference< XMLTextParagraphExport > mxTextParagraphExport;
 rtl::Reference< XMLShapeExport > mxShapeExport;
@@ -152,9 +152,9 @@ class XMLOFF_DLLPUBLIC SvXMLExport : public 
cppu::WeakImplHelper<
 rtl::Reference< XMLPageExport > mxPageExport;
 rtl::Reference< XMLFontAutoStylePool > mxFontAutoStylePool;
 rtl::Reference< xmloff::OFormLayerXMLExport > mxFormExport;
-XMLEventExport* mpEventExport;
-XMLImageMapExport* mpImageMapExport;
-XMLErrors*  mpXMLErrors;
+std::unique_ptr mpEventExport;
+std::unique_ptr mpImageMapExport;
+std::unique_ptr  mpXMLErrors;
 
 const enum ::xmloff::token::XMLTokenEnum meClass;
 SAL_DLLPRIVATE void InitCtor_();
@@ -420,7 +420,7 @@ public:
 {
 mxNumberFormatsSupplier = _xNumberFormatSupplier;
 if ( mxNumberFormatsSupplier.is() && mxHandler.is() )
-mpNumExport = new SvXMLNumFmtExport(*this, 
mxNumberFormatsSupplier);
+mpNumExport.reset( new SvXMLNumFmtExport(*this, 
mxNumberFormatsSupplier) );
 }
 
 // get export helper for text
diff --git a/xmloff/source/core/xmlexp.cxx b/xmloff/source/core/xmlexp.cxx
index 796390f2b1e1..d06eb49da770 100644
--- a/xmloff/source/core/xmlexp.cxx
+++ b/xmloff/source/core/xmlexp.cxx
@@ -258,7 +258,7 @@ public:
 
 /// stack of backed up namespace maps
 /// long: depth at which namespace map has been backed up into the stack
-::std::stack< ::std::pair< SvXMLNamespaceMap *, long > > mNamespaceMaps;
+::std::stack< ::std::pair< std::unique_ptr, long > > 
mNamespaceMaps;
 /// counts depth (number of open elements/start tags)
 long mDepth;
 
@@ -480,7 +480,7 @@ SvXMLExport::SvXMLExport(
 InitCtor_();
 
 if (mxNumberFormatsSupplier.is())
-mpNumExport = new SvXMLNumFmtExport(*this, mxNumberFormatsSupplier);
+mpNumExport.reset( new SvXMLNumFmtExport(*this, 
mxNumberFormatsSupplier) );
 }
 
 SvXMLExport::SvXMLExport(
@@ -519,15 +519,15 @@ SvXMLExport::SvXMLExport(
 InitCtor_();
 
 if (mxNumberFormatsSupplier.is())
-mpNumExport = new SvXMLNumFmtExport(*this, mxNumberFormatsSupplier);
+mpNumExport.reset( new SvXMLNumFmtExport(*this, 
mxNumberFormatsSupplier) );
 }
 
 SvXMLExport::~SvXMLExport()
 {
-delete mpXMLErrors;
-delete mpImageMapExport;
-delete mpEventExport;
-delete mpNamespaceMap;
+mpXMLErrors.reset();
+mpImageMapExport.reset();
+mpEventExport.reset();
+mpNamespaceMap.reset();
 if (mpProgressBarHelper || mpNumExport)
 {
 if (mxExportInfo.is())
@@ -561,8 +561,8 @@ SvXMLExport::~SvXMLExport()
 }
 }
 }
-delete mpProgressBarHelper;
-delete mpNumExport;
+mpProgressBarHelper.reset();
+mpNumExport.reset();
 }
 
 if (mxEventListener.is() && mxModel.is())
@@ -585,7 +585,7 @@ void SAL_CALL SvXMLExport::setSourceDocument( const 
uno::Reference< lang::XCompo
 {
 mxNumberFormatsSupplier.set(mxModel, css::uno::UNO_QUERY);
 if(mxNumberFormatsSupplier.is() && mxHandler.is())
-mpNumExport = new SvXMLNumFmtExport(*this, 
mxNumberFormatsSupplier);
+mpNumExport.reset( new SvXMLNumFmtExport(*this, 
mxNumberFormatsSupplier) );
 }
 if (mxExportInfo.is())
 {
@@ -692,7 +692,7 @@ void SAL_CALL SvXMLExport::initialize( const uno::Sequence< 
uno::Any >& aArgumen
 *pAny >>= mxExtHandler;
 
 if (mxNumberFormatsSupplier.is() && mpNumExport == nullptr)
-mpNumExport = new SvXMLNumFmtExport(*this, 
mxNumberFormatsSupplier);
+

[Libreoffice-bugs] [Bug 77888] [basic] Macro editor: Digital Signature menu entry isn' t working

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=77888

Thomas Arnhold  changed:

   What|Removed |Added

Version|3.5.0 release   |Inherited From OOo

--- Comment #8 from Thomas Arnhold  ---
Bug is still present in 5.4.4.

I Also tested it with 3.3.0 where it was also present.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87638] Slide Pane should be titled 'Master Slides' when in master view

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=87638

b...@brianmorrow.net changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |b...@brianmorrow.net
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

2018-01-30 Thread Jens Carl

 sc/qa/extras/scstyleloaderobj.cxx |   83 +++---
 1 file changed, 25 insertions(+), 58 deletions(-)

New commits:
commit 00bf3c837120fa95bfa9df5cc4de33bacb9b5288
Author: Jens Carl 
Date:   Tue Jan 30 20:17:28 2018 +

Remove shared mxSourceComponent and mxTargetComponent (test documents)

in scstyleloaderobj

Change-Id: I7702f6458a56a9a4f8514a354505cf8f93ec8390
Reviewed-on: https://gerrit.libreoffice.org/48932
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/sc/qa/extras/scstyleloaderobj.cxx 
b/sc/qa/extras/scstyleloaderobj.cxx
index e9a2a2170c29..ef4e9d5e9bfe 100644
--- a/sc/qa/extras/scstyleloaderobj.cxx
+++ b/sc/qa/extras/scstyleloaderobj.cxx
@@ -9,17 +9,16 @@
 
 #include 
 #include 
+
+#include 
 #include 
 #include 
 
-
 using namespace css;
 using namespace css::uno;
 
 namespace sc_apitest {
 
-#define NUMBER_OF_TESTS 2
-
 class ScStyleLoaderObj : public CalcUnoApiTest, public apitest::XStyleLoader
 {
 public:
@@ -29,97 +28,65 @@ public:
 virtual void tearDown() override;
 
 virtual uno::Reference< uno::XInterface > init() override;
-virtual uno::Reference< lang::XComponent  > getTargetComponent() override;
+virtual uno::Reference< lang::XComponent > getTargetComponent() override;
 virtual uno::Reference< lang::XComponent > getSourceComponent() override;
 virtual OUString getTestURL() override;
 
 CPPUNIT_TEST_SUITE(ScStyleLoaderObj);
+
+// XStyleLoader
 CPPUNIT_TEST(testLoadStylesFromURL);
 CPPUNIT_TEST(testLoadStylesFromDocument);
-CPPUNIT_TEST_SUITE_END();
 
+CPPUNIT_TEST_SUITE_END();
 private:
-
-static sal_Int32 nTest;
-static uno::Reference< lang::XComponent > mxSourceComponent;
-static uno::Reference< lang::XComponent > mxTargetComponent;
-
-
+uno::Reference< lang::XComponent > mxSourceComponent;
+uno::Reference< lang::XComponent > mxTargetComponent;
 };
 
-sal_Int32 ScStyleLoaderObj::nTest = 0;
-uno::Reference< lang::XComponent > ScStyleLoaderObj::mxSourceComponent;
-uno::Reference< lang::XComponent > ScStyleLoaderObj::mxTargetComponent;
-
-
 ScStyleLoaderObj::ScStyleLoaderObj()
-   : CalcUnoApiTest("sc/qa/extras/testdocuments")
+: CalcUnoApiTest("sc/qa/extras/testdocuments")
 {
 }
 
-
 uno::Reference< uno::XInterface > ScStyleLoaderObj::init()
 {
-  return getTargetComponent();
+return getTargetComponent();
 }
 
-
-uno::Reference< lang::XComponent > ScStyleLoaderObj::getTargetComponent(){
-  // target is always an empty document
-
-if (mxTargetComponent.is())
-closeDocument(mxTargetComponent);
-
-mxTargetComponent = loadFromDesktop("private:factory/scalc");
-
+uno::Reference< lang::XComponent > ScStyleLoaderObj::getTargetComponent()
+{
+// target is always an empty document
 return mxTargetComponent;
 }
 
-uno::Reference< lang::XComponent > ScStyleLoaderObj::getSourceComponent(){
-
-if (mxSourceComponent.is())
-closeDocument(mxSourceComponent);
-
-  // get the test file url
-  OUString aFileURL = getTestURL();
-
-  if(!mxSourceComponent.is())
-  mxSourceComponent = loadFromDesktop(aFileURL);
-  CPPUNIT_ASSERT_MESSAGE("Component not loaded",mxSourceComponent.is());
-
+uno::Reference< lang::XComponent > ScStyleLoaderObj::getSourceComponent()
+{
+CPPUNIT_ASSERT_MESSAGE("Component not loaded",mxSourceComponent.is());
 return mxSourceComponent;
 }
 
-OUString ScStyleLoaderObj::getTestURL(){
-
+OUString ScStyleLoaderObj::getTestURL()
+{
   OUString aFileURL;
   createFileURL("ScStyleLoaderObj.ods", aFileURL);
-
   return aFileURL;
 }
 
 void ScStyleLoaderObj::setUp()
 {
-nTest++;
-CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS);
 CalcUnoApiTest::setUp();
+
+mxTargetComponent = loadFromDesktop("private:factory/scalc");
+// get the test file url
+OUString aFileURL = getTestURL();
+mxSourceComponent = loadFromDesktop(aFileURL);
 }
 
 void ScStyleLoaderObj::tearDown()
 {
-if (nTest == NUMBER_OF_TESTS)
-{
-  if (mxSourceComponent.is())
-  {
-  closeDocument(mxSourceComponent);
-  mxSourceComponent.clear();
-  }
-  if (mxTargetComponent.is())
-  {
-  closeDocument(mxTargetComponent);
-  mxTargetComponent.clear();
-  }
-}
+closeDocument(mxSourceComponent);
+closeDocument(mxTargetComponent);
 CalcUnoApiTest::tearDown();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

2018-01-30 Thread Jens Carl

 sc/qa/extras/scviewpaneobj.cxx |   30 --
 1 file changed, 8 insertions(+), 22 deletions(-)

New commits:
commit 96a47c604df8187ab5c68d9941d71e8f07acce6d
Author: Jens Carl 
Date:   Tue Jan 30 23:02:41 2018 +

Remove shared mxComponent (test document) in scviewpaneobj

Change-Id: I8bf7adb11e49d926a5910a4bd8279e16cf34833f
Reviewed-on: https://gerrit.libreoffice.org/48943
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/sc/qa/extras/scviewpaneobj.cxx b/sc/qa/extras/scviewpaneobj.cxx
index 02ceb63824e0..6e74fa8a4434 100644
--- a/sc/qa/extras/scviewpaneobj.cxx
+++ b/sc/qa/extras/scviewpaneobj.cxx
@@ -23,8 +23,6 @@ using namespace css::uno;
 
 namespace sc_apitest {
 
-#define NUMBER_OF_TESTS 3
-
 class ScViewPaneObj : public CalcUnoApiTest, public apitest::XViewPane
 {
 public:
@@ -35,32 +33,25 @@ public:
 virtual void tearDown() override;
 
 CPPUNIT_TEST_SUITE(ScViewPaneObj);
+
+// XViewPane
 CPPUNIT_TEST(testFirstVisibleColumn);
 CPPUNIT_TEST(testFirstVisibleRow);
 CPPUNIT_TEST(testVisibleRange);
+
 CPPUNIT_TEST_SUITE_END();
 
 private:
-
-static sal_Int32 nTest;
-static uno::Reference mxComponent;
-
+uno::Reference mxComponent;
 };
 
-sal_Int32 ScViewPaneObj::nTest = 0;
-uno::Reference< lang::XComponent > ScViewPaneObj::mxComponent;
-
 ScViewPaneObj::ScViewPaneObj()
-: CalcUnoApiTest("/sc/qa/extras/testdocuments")
+: CalcUnoApiTest("/sc/qa/extras/testdocuments")
 {
 }
 
 uno::Reference< uno::XInterface > ScViewPaneObj::init()
 {
-// create a calc document
-if (!mxComponent.is())
-mxComponent = loadFromDesktop("private:factory/scalc");
-
 uno::Reference< sheet::XSpreadsheetDocument > xSheetDoc(mxComponent, 
uno::UNO_QUERY_THROW);
 CPPUNIT_ASSERT_MESSAGE("no calc document!", xSheetDoc.is());
 
@@ -73,19 +64,14 @@ uno::Reference< uno::XInterface > ScViewPaneObj::init()
 
 void ScViewPaneObj::setUp()
 {
-nTest++;
-CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS);
 CalcUnoApiTest::setUp();
+// create a calc document
+mxComponent = loadFromDesktop("private:factory/scalc");
 }
 
 void ScViewPaneObj::tearDown()
 {
-if (nTest == NUMBER_OF_TESTS)
-{
-closeDocument(mxComponent);
-mxComponent.clear();
-}
-
+closeDocument(mxComponent);
 CalcUnoApiTest::tearDown();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115284] Shortcut and behaviour of fullscreen mode on Mac

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115284

--- Comment #7 from Yousuf Philips (jay)  ---
(In reply to Alex Thurgood from comment #1)
> OK, so my ha'penneth would be rather to enable native OSX fullscreen support
> properly and disable LO's pseudo attempt to do this.

I maybe wrong, but LO already has OSX fullscreen support when you click the
green bubble button in the title bar, though it likely needs work as i see a
black empty bar at the top above the toolbars.

> Either we want an app that behaves like a good citizen of the native macOS
> application world, or we don't, if we decide on not going down that route,
> then we should also make that perfectly clear to end users...

LO having OSX fullscreen support doesnt mean that we cant also have LO
fullscreen support, only that we should likely use a different shortcut for
them, so mac users arent focused.

(In reply to Tor Lillqvist from comment #2)
> Yousuf, Firefox is not necessarily a good application to compare with if you
> want to figure out what the "ideal" native full-screen look is, as it
> is also a cross-platform app that is playing catch-up with Apple's ideas;)
> Better to look at some of Apple's own apps, like Pages, iTunes, Photos.

I had already tested Pages and Safari and its fullscreen support was identical
to Firefox's (simply hide menubar and titlebar), but mentioned Firefox as it is
a cross-platform app like LO, and on windows and linux it has document area
fullscreen support and doesnt have the feature on mac. Tested Chrome just now
and it is similar to Firefox.

(In reply to Tor Lillqvist from comment #4)
> Heiko, that sounds mostly like prejudice. In fact, the Apple guidelines for
> Full-Screen Mode use the same wordings as you do;) So it is just up to the
> application to behave like that in Full-Screen Mode.

So if i get this correctly, you want to implement LO's fullscreen mode but be
able to toggle it with OSX fullscreen mode green button and shortcut.

> If some sample apps
> (even Apple ones) don't (but just expand the UI to fill the screen but
> including all the same GUI), well, that is not the fault of the APIs and
> reason enough to not use the system APIs for full-screen mode.

If apps, even Apple ones, have a OSX fullscreen mode that simply fills the app
on the screen, wouldnt users want that same functionality in a fullscreen mode
with LO when toggled with the green bubble and not what LO defines as a
fullscreen mode?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70607] LibO uses 100% CPU and crashes when quit during extension update

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=70607

--- Comment #13 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105593] Libreoffice renders table differently

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105593

--- Comment #3 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 77888] [basic] Macro editor: Digital Signature menu entry isn' t working

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=77888

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81640] Very slow and lagging if open file stored on network

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=81640

--- Comment #12 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103429] [META] Split and group buttons in toolbar and sidebar bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103429

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||115275


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115275
[Bug 115275] Shape split buttons have draggable grip but no title label
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115275] Shape split buttons have draggable grip but no title label

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115275

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||philip...@hotmail.com
 Blocks|108816  |103429, 108741
Summary|Tabbed/Notebookbar's Shapes |Shape split buttons have
   |Box title is garbage|draggable grip but no title
   ||label

--- Comment #11 from Yousuf Philips (jay)  ---
(In reply to Maxim Monastirsky from comment #10)
> (In reply to baffclan from comment #7)
> > However "Table" pulldown box has title.
> > I can not understand this difference...
> I don't think that difference is intentional. It just that the graphic grip
> concept which we use for the shapes popup is inherited from OOo, thus
> predates the text based title that we use for other popups like for color or
> table, which at first introduced in Go-oo and later imported into LO.

I think the difference is intentional as when you mouseover the grip the mouse
cursor changes indicating that it can be dragged, which isnt present when you
open up the table and color group/split buttons, as most users would never
think they were draggable anyway and likely shouldnt be.

> That bug deals with several different kinds of inconsistencies. If there's
> an agreement here that the shapes popup should be switched to a text title,
> I would suggest to reopen this bug, and set it as an enhancement to do the
> switch.

Left a comment in bug 87239 for what i think should be changed, but i wouldnt
be in favour of adding a title label to the shape buttons as the tooltip
already indicates this label for those who are unaware.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103429
[Bug 103429] [META] Split and group buttons in toolbar and sidebar bugs and
enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108741
[Bug 108741] [META] Shapes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108816
[Bug 108816] [META] Writer toolbar bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108741

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||115275


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115275
[Bug 115275] Shape split buttons have draggable grip but no title label
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108816] [META] Writer toolbar bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108816

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on|115275  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115275
[Bug 115275] Shape split buttons have draggable grip but no title label
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103429] [META] Split and group buttons in toolbar and sidebar bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103429

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||87239


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=87239
[Bug 87239] Inconsistent look and operation of drop-down buttons
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108816] [META] Writer toolbar bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108816

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on|87239   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=87239
[Bug 87239] Inconsistent look and operation of drop-down buttons
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87239] Inconsistent look and operation of drop-down buttons

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=87239

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||philip...@hotmail.com
 Blocks|108816  |103429

--- Comment #5 from Yousuf Philips (jay)  ---
(In reply to Mike Kaganski from comment #0)
> Pressing arrow next to "Font Color"/"Highlighting" toolbar button brings the
> drop-down panel that has a caption, that can be used for dragging. When
> dragged, it becomes a floating window. The drop-down (not draggged) stays on
> screen while the main application window is resized/moved.

Caption should be removed (tooltip and icon already tell you what will popup
from the spit buttons) and dragging should be disabled as there is no means to
dock it like the sidebar or toolbars, making its floating functionality very
limited.

> Pressing arrow next to "Insert Table" button gives a drop-down with caption;
> it behaves like draggable, but on release it disappears. Trying to
> resize/move main app window hides drop-down (as expected).

Caption should be removed (tooltip and icon already tell you what will popup)
and dragging should be disabled as it provides no useful functionality.

> Pressing arrow next to "Bullets On/Off" (or "Numbering On/Off") gives
> drop-down without header/double lines, not draggable, no borders. Items have
> flat appearance with thin black border on hover. Trying to resize/move main
> app window hides drop-down (as expected).

Didnt get what "without header/double lines" or "no borders" meant. Flat
appearance is important as its showing a preview of how it looks on a flat
page.

> Pressing arrow next to "Line Spacing" (recent versions) gives not draggable
> drop-down with some border. Items look like 3D buttons on hover. Trying to
> resize/move main app window hides drop-down (as expected).

3D buttons when hovering isnt good as these should be standard toggle buttons
or checkboxes (bug 113633).

> Pressing arrow next to "Insert Field"/"Paste" gives not draggable drop-down
> with some border. Items look like menu items (standard OS menu look;
> system-defined highlight color, etc). Trying to resize/move main app window
> hides drop-down (as expected).

Acts the same as other split/group buttons that pull out menu items like new,
open and save buttons.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103429
[Bug 103429] [META] Split and group buttons in toolbar and sidebar bugs and
enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108816
[Bug 108816] [META] Writer toolbar bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 87239] Inconsistent look and operation of drop-down buttons

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=87239

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||philip...@hotmail.com
 Blocks|108816  |103429

--- Comment #5 from Yousuf Philips (jay)  ---
(In reply to Mike Kaganski from comment #0)
> Pressing arrow next to "Font Color"/"Highlighting" toolbar button brings the
> drop-down panel that has a caption, that can be used for dragging. When
> dragged, it becomes a floating window. The drop-down (not draggged) stays on
> screen while the main application window is resized/moved.

Caption should be removed (tooltip and icon already tell you what will popup
from the spit buttons) and dragging should be disabled as there is no means to
dock it like the sidebar or toolbars, making its floating functionality very
limited.

> Pressing arrow next to "Insert Table" button gives a drop-down with caption;
> it behaves like draggable, but on release it disappears. Trying to
> resize/move main app window hides drop-down (as expected).

Caption should be removed (tooltip and icon already tell you what will popup)
and dragging should be disabled as it provides no useful functionality.

> Pressing arrow next to "Bullets On/Off" (or "Numbering On/Off") gives
> drop-down without header/double lines, not draggable, no borders. Items have
> flat appearance with thin black border on hover. Trying to resize/move main
> app window hides drop-down (as expected).

Didnt get what "without header/double lines" or "no borders" meant. Flat
appearance is important as its showing a preview of how it looks on a flat
page.

> Pressing arrow next to "Line Spacing" (recent versions) gives not draggable
> drop-down with some border. Items look like 3D buttons on hover. Trying to
> resize/move main app window hides drop-down (as expected).

3D buttons when hovering isnt good as these should be standard toggle buttons
or checkboxes (bug 113633).

> Pressing arrow next to "Insert Field"/"Paste" gives not draggable drop-down
> with some border. Items look like menu items (standard OS menu look;
> system-defined highlight color, etc). Trying to resize/move main app window
> hides drop-down (as expected).

Acts the same as other split/group buttons that pull out menu items like new,
open and save buttons.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103429
[Bug 103429] [META] Split and group buttons in toolbar and sidebar bugs and
enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108816
[Bug 108816] [META] Writer toolbar bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 115323] [META] Line spacing group button bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115323

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||83076


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83076
[Bug 83076] TOOLBAR: Adding of Line Spacing group button to formatting toolbar
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103429] [META] Split and group buttons in toolbar and sidebar bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103429

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on|113633  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113633
[Bug 113633] Turn hidden buttons to visible toggle buttons in line spacing
group button
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115323] [META] Line spacing group button bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115323

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||113633


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113633
[Bug 113633] Turn hidden buttons to visible toggle buttons in line spacing
group button
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103429] [META] Split and group buttons in toolbar and sidebar bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103429

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on|83076   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83076
[Bug 83076] TOOLBAR: Adding of Line Spacing group button to formatting toolbar
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115323] [META] Line spacing group button bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115323

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113633] Turn hidden buttons to visible toggle buttons in line spacing group button

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113633

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks|103429  |115323


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103429
[Bug 103429] [META] Split and group buttons in toolbar and sidebar bugs and
enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=115323
[Bug 115323] [META] Line spacing group button bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103429] [META] Split and group buttons in toolbar and sidebar bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103429

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||115323


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115323
[Bug 115323] [META] Line spacing group button bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109235] [META] Paragraph line spacing bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=109235

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||115323


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115323
[Bug 115323] [META] Line spacing group button bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115323] New: [META] Line spacing group button bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115323

Bug ID: 115323
   Summary: [META] Line spacing group button bugs and enhancements
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
Blocks: 103429, 109235


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103429
[Bug 103429] [META] Split and group buttons in toolbar and sidebar bugs and
enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109235
[Bug 109235] [META] Paragraph line spacing bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115322] New: FORMATTING: Drawing object size values change to near value when object is deselected /reselected.

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115322

Bug ID: 115322
   Summary: FORMATTING: Drawing object size values change to near
value when object is deselected/reselected.
   Product: LibreOffice
   Version: 5.4.3.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dooq...@gmail.com

Description:
When using millimeters as the unit of measurement, size values typed into
Position and Size panel do not remain as typed and are instead changed to a
near value.  For example, a width value of '8' or '8.00', whether typed or
arrived at through the spinner buttons, will change to '7.87 mm' if the object
is deselected and then selected again.

Steps to Reproduce:
1. Draw a horizontal line object.
2. Make sure that the line object is selected.  If not, then select it.
3. In the Width field on the Position and Size panel, type '8.00' or just '8'
4. Change field focus.
5. Deselect line object, then reselect.

Actual Results:  
Width field contains '7.87 mm'.

Expected Results:
Width field should contain '8.00 mm'.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Version: 6.0.0.3 (x64)
Build ID: 64a0f66915f38c6217de274f0aa8e15618924765
CPU threads: 8; OS: Windows 10.0; UI render: default; 
Locale: en-US (en_US); Calc: group

Renderer: GeForce GTX 650 Ti/PCIe/SSE2
Vendor: NVIDIA Corporation
Memory: 2048 MB
Version: 4.4.0 NVIDIA 388.13
Shading language version: 4.40 NVIDIA via Cg compiler

Issue persists in 6.0.0.3.


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

2018-01-30 Thread Jens Carl

 sc/qa/extras/sctablesheetobj.cxx |   34 --
 1 file changed, 4 insertions(+), 30 deletions(-)

New commits:
commit 0d4ab5f616919b1a89ca2e6df53726af2020e3da
Author: Jens Carl 
Date:   Tue Jan 30 22:35:00 2018 +

Remove shared mxComponent (test document) in sctablesheetobj

Change-Id: I4c381b7f7520bf7d3103dfea22e3643b2eae01b1
Reviewed-on: https://gerrit.libreoffice.org/48940
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/sc/qa/extras/sctablesheetobj.cxx b/sc/qa/extras/sctablesheetobj.cxx
index ad859a6a4153..30a2d365dedb 100644
--- a/sc/qa/extras/sctablesheetobj.cxx
+++ b/sc/qa/extras/sctablesheetobj.cxx
@@ -42,8 +42,6 @@ using namespace css::uno;
 namespace sc_apitest
 {
 
-#define NUMBER_OF_TESTS 35
-
 class ScTableSheetObj : public CalcUnoApiTest, public apitest::Scenario,
public 
apitest::XCellFormatRangesSupplier,
public 
apitest::XCellRangeAddressable,
@@ -170,13 +168,9 @@ public:
 
 private:
 OUString maFileURL;
-static sal_Int32 nTest;
-static uno::Reference< lang::XComponent > mxComponent;
+uno::Reference< lang::XComponent > mxComponent;
 };
 
-sal_Int32 ScTableSheetObj::nTest = 0;
-uno::Reference< lang::XComponent > ScTableSheetObj::mxComponent;
-
 ScTableSheetObj::ScTableSheetObj():
 CalcUnoApiTest("/sc/qa/extras/testdocuments"),
 apitest::XCellSeries(1, 0),
@@ -187,11 +181,6 @@ ScTableSheetObj::ScTableSheetObj():
 
 uno::Reference< uno::XInterface > ScTableSheetObj::init()
 {
-createFileURL("ScTableSheetObj.ods", maFileURL);
-if (!mxComponent.is())
-mxComponent = loadFromDesktop(maFileURL, 
"com.sun.star.sheet.SpreadsheetDocument");
-CPPUNIT_ASSERT_MESSAGE("no component loaded", mxComponent.is());
-
 uno::Reference< sheet::XSpreadsheetDocument > xDoc(mxComponent, 
UNO_QUERY_THROW);
 CPPUNIT_ASSERT_MESSAGE("no calc document", xDoc.is());
 
@@ -219,11 +208,6 @@ uno::Reference< uno::XInterface > ScTableSheetObj::init()
 
 uno::Reference ScTableSheetObj::getScenarioSpreadsheet()
 {
-createFileURL("ScTableSheetObj.ods", maFileURL);
-if (!mxComponent.is())
-mxComponent = loadFromDesktop(maFileURL, 
"com.sun.star.sheet.SpreadsheetDocument");
-CPPUNIT_ASSERT_MESSAGE("no component loaded", mxComponent.is());
-
 uno::Reference xDoc(mxComponent, 
UNO_QUERY_THROW);
 CPPUNIT_ASSERT_MESSAGE("no calc document", xDoc.is());
 
@@ -252,11 +236,6 @@ uno::Reference 
ScTableSheetObj::getScenarioSpreadsheet()
 
 uno::Reference< uno::XInterface > ScTableSheetObj::getXSpreadsheet()
 {
-createFileURL("ScTableSheetObj.ods", maFileURL);
-if (!mxComponent.is())
-mxComponent = loadFromDesktop(maFileURL, 
"com.sun.star.sheet.SpreadsheetDocument");
-CPPUNIT_ASSERT_MESSAGE("no component loaded", mxComponent.is());
-
 uno::Reference< sheet::XSpreadsheetDocument > xDoc(mxComponent, 
UNO_QUERY_THROW);
 CPPUNIT_ASSERT_MESSAGE("no calc document", xDoc.is());
 
@@ -288,19 +267,14 @@ OUString ScTableSheetObj::getFileURL()
 
 void ScTableSheetObj::setUp()
 {
-nTest++;
-CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS);
 CalcUnoApiTest::setUp();
+createFileURL("ScTableSheetObj.ods", maFileURL);
+mxComponent = loadFromDesktop(maFileURL, 
"com.sun.star.sheet.SpreadsheetDocument");
 }
 
 void ScTableSheetObj::tearDown()
 {
-if (nTest == NUMBER_OF_TESTS)
-{
-closeDocument(mxComponent);
-mxComponent.clear();
-}
-
+closeDocument(mxComponent);
 CalcUnoApiTest::tearDown();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115321] Vertical Japanese text lines with emphasis mark above in odt exported to PDF is shown a quarter font height lower than the normal lines , and no emphasis mark is shown

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115321

himajin100...@gmail.com changed:

   What|Removed |Added

 CC||himajin100...@gmail.com

--- Comment #1 from himajin100...@gmail.com ---
Created attachment 139455
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139455=edit
odt file to be exported

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115321] Vertical Japanese text lines with emphasis mark above in odt exported to PDF is shown a quarter font height lower than the normal lines , and no emphasis mark is shown

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115321

--- Comment #2 from himajin100...@gmail.com ---
Created attachment 139456
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139456=edit
result

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115321] New: Vertical Japanese text lines with emphasis mark above in odt exported to PDF is shown a quarter font height lower than the normal lines , and no emphasis mark is s

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115321

Bug ID: 115321
   Summary: Vertical Japanese text lines with emphasis mark above
in odt exported to PDF is shown a quarter font height
lower than the normal lines, and no emphasis mark is
shown
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: himajin100...@gmail.com

Description:
Open the attached odt
Export To PDF(the result is attached)

the attached pdf is exported version of the attached odt but uncompressed by:
qpdf --stream-data=uncompress in.pdf out.pdf

all the characters in the odt is in 20pt

When you open that pdf in text editor(Of course you can open it in hex editor,
if you don't mind unreadability from not caring newlines),

you will see the following lines
BT
1 0 0 1 575.3 824.1 Tm /F1 20 Tf<01>Tj
1 0 0 1 575.3 804.1 Tm<02>Tj
1 0 0 1 575.3 784.1 Tm<03>Tj
1 0 0 1 575.3 764.1 Tm<04>Tj
1 0 0 1 575.3 744.1 Tm<05>Tj
1 0 0 1 575.3 724 Tm<06>Tj
1 0 0 1 575.3 704 Tm<07>Tj
1 0 0 1 575.3 684 Tm<08>Tj
1 0 0 1 575.3 663.9 Tm<09>Tj
ET

and

BT
1 0 0 1 550.3 819.1 Tm /F1 20 Tf<01>Tj
1 0 0 1 550.3 799.1 Tm<02>Tj
1 0 0 1 550.3 779.1 Tm<03>Tj
1 0 0 1 550.3 759.1 Tm<04>Tj
1 0 0 1 550.3 739 Tm<05>Tj
1 0 0 1 550.3 719 Tm<06>Tj
1 0 0 1 550.3 698.9 Tm<07>Tj
1 0 0 1 550.3 678.9 Tm<08>Tj
1 0 0 1 550.3 658.9 Tm<09>Tj
ET

so the differences in y-value of the matching positions in two lines are

824.1 - 819.1 = 5
804.1 - 799.1 = 5
784.1 - 779.1 = 5

all the same: 5 , *which should be 0 instead.*

emphasis mark is seemingly not exported to PDF

Differences between the adjacent characters in the same line, such as 824.1 -
804.1 were the same as the font size: 20

these relationship did not change when I set 12pt for the characters.

differences in matching positions was all 3, and the differences in the same
line were the font size:12

from I've seen, I guess this is coming from this thing-y.
https://opengrok.libreoffice.org/xref/core/vcl/source/outdev/font.cxx?r=55f07d4d#1094

Expected result should have emphasis mark on the right side of the characters
instead of top side. But possibly export to pdf does not consider this, and
emphasis marks to be shown were somehow clipped?

Steps to Reproduce:
Open the attached odt
Export To PDF
see description

Actual Results:  
see description

Expected Results:
see description


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101
Firefox/60.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

2018-01-30 Thread Jens Carl

 sc/qa/extras/sctablevalidationobj.cxx |   23 ---
 1 file changed, 4 insertions(+), 19 deletions(-)

New commits:
commit 2e0f1f6ff0deb65370b8c5491dda6c326edae7e0
Author: Jens Carl 
Date:   Tue Jan 30 22:47:35 2018 +

Remove shared mxComponent (test document) in sctablevalidationobj

Change-Id: I94900cd87e61b5ee6618ccb736bee82c349c8cc3
Reviewed-on: https://gerrit.libreoffice.org/48942
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/sc/qa/extras/sctablevalidationobj.cxx 
b/sc/qa/extras/sctablevalidationobj.cxx
index 03dd18993305..0968b8042893 100644
--- a/sc/qa/extras/sctablevalidationobj.cxx
+++ b/sc/qa/extras/sctablevalidationobj.cxx
@@ -29,8 +29,6 @@ using namespace com::sun::star;
 
 namespace sc_apitest
 {
-#define NUMBER_OF_TESTS 5
-
 class ScTableValidationObj : public CalcUnoApiTest,
  public apitest::TableValidation,
  public apitest::XSheetCondition
@@ -56,13 +54,9 @@ public:
 CPPUNIT_TEST_SUITE_END();
 
 private:
-static sal_Int32 nTest;
-static uno::Reference mxComponent;
+uno::Reference mxComponent;
 };
 
-sal_Int32 ScTableValidationObj::nTest = 0;
-uno::Reference ScTableValidationObj::mxComponent;
-
 ScTableValidationObj::ScTableValidationObj()
 : CalcUnoApiTest("/sc/qa/extras/testdocuments")
 {
@@ -70,10 +64,6 @@ ScTableValidationObj::ScTableValidationObj()
 
 uno::Reference ScTableValidationObj::init()
 {
-// create a calc document
-if (!mxComponent.is())
-mxComponent = loadFromDesktop("private:factory/scalc");
-
 uno::Reference xDoc(mxComponent, 
uno::UNO_QUERY_THROW);
 CPPUNIT_ASSERT_MESSAGE("no calc document", xDoc.is());
 
@@ -93,19 +83,14 @@ uno::Reference ScTableValidationObj::init()
 
 void ScTableValidationObj::setUp()
 {
-nTest++;
-CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS);
 CalcUnoApiTest::setUp();
+// create a calc document
+mxComponent = loadFromDesktop("private:factory/scalc");
 }
 
 void ScTableValidationObj::tearDown()
 {
-if (nTest == NUMBER_OF_TESTS)
-{
-closeDocument(mxComponent);
-mxComponent.clear();
-}
-
+closeDocument(mxComponent);
 CalcUnoApiTest::tearDown();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108769] [META] DOCX (OOXML) character-related issues

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108769

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||115291


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115291
[Bug 115291] Text highlight color changes when .odt document saved as a .doc
document.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115291] Text highlight color changes when .odt document saved as a .doc document.

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115291

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||philip...@hotmail.com
   Hardware|x86-64 (AMD64)  |All
 Blocks||108769

--- Comment #5 from Yousuf Philips (jay)  ---
Microsoft only allows 15 colors to be used as highlight colors in both .doc and
.docx, so this is a format limitation bug that isnt ours.

(In reply to Telesto from comment #3)
> Contra
> *It will break the experience of MS Word users wanting to edit a file..

Users being able to modify the highlighting is the most important thing, so i'd
stick with this by default.

(In reply to Heiko Tietze from comment #4)
> Alternatively, we could ask the user when exporting a document may result in
> corrupt properties.

We already give users the 'Confirm File Format' dialog when not saving to ODF,
which does state 'This document may contain formatting or content that cannot
be saved in the currently selected file format'. We could go beyond this, if
devs are interested in implementing it, and create a dialog similar to the MS
compatibility checker.

http://technastic.com/wp-content/uploads/2016/02/Microsoft-Word-Compatibility-checker.jpg


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108769
[Bug 108769] [META] DOCX (OOXML) character-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 115291] Text highlight color changes when .odt document saved as a .doc document.

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115291

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||philip...@hotmail.com
   Hardware|x86-64 (AMD64)  |All
 Blocks||108769

--- Comment #5 from Yousuf Philips (jay)  ---
Microsoft only allows 15 colors to be used as highlight colors in both .doc and
.docx, so this is a format limitation bug that isnt ours.

(In reply to Telesto from comment #3)
> Contra
> *It will break the experience of MS Word users wanting to edit a file..

Users being able to modify the highlighting is the most important thing, so i'd
stick with this by default.

(In reply to Heiko Tietze from comment #4)
> Alternatively, we could ask the user when exporting a document may result in
> corrupt properties.

We already give users the 'Confirm File Format' dialog when not saving to ODF,
which does state 'This document may contain formatting or content that cannot
be saved in the currently selected file format'. We could go beyond this, if
devs are interested in implementing it, and create a dialog similar to the MS
compatibility checker.

http://technastic.com/wp-content/uploads/2016/02/Microsoft-Word-Compatibility-checker.jpg


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108769
[Bug 108769] [META] DOCX (OOXML) character-related issues
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: sw/qa sw/source writerfilter/source

2018-01-30 Thread Serge Krot

 sw/qa/extras/rtfexport/rtfexport2.cxx   |   17 +++
 sw/qa/extras/uiwriter/data/fdo72942-insert.docx |binary
 sw/qa/extras/uiwriter/data/fdo72942.docx|binary
 sw/qa/extras/uiwriter/uiwriter.cxx  |   35 
 sw/source/filter/docx/swdocxreader.cxx  |9 ++
 writerfilter/source/dmapper/StyleSheetTable.cxx |   15 ++
 6 files changed, 70 insertions(+), 6 deletions(-)

New commits:
commit deaa16bd24fba4a3a6b072ab2b94542a7dbd41c6
Author: Serge Krot 
Date:   Mon Jan 29 12:17:06 2018 +0100

tdf#72942 Do not overwrite styles from the inserted doc

During inserting of the text from the external document
we should not change original default styles in
currently opened document.

Added unit test.

Change-Id: Ida754a0da5efaaa043464cd807c0b52cfb0d5670
Reviewed-on: https://gerrit.libreoffice.org/48826
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/sw/qa/extras/rtfexport/rtfexport2.cxx 
b/sw/qa/extras/rtfexport/rtfexport2.cxx
index efab6c848c6c..a83ba3916674 100644
--- a/sw/qa/extras/rtfexport/rtfexport2.cxx
+++ b/sw/qa/extras/rtfexport/rtfexport2.cxx
@@ -677,20 +677,25 @@ DECLARE_RTFEXPORT_TEST(testFdo63428, "hello.rtf")
  getProperty(getRun(getParagraph(1), 4), 
"TextPortionType"));
 }
 
-DECLARE_RTFEXPORT_TEST(testFdo69384, "hello.rtf")
+#endif
+
+DECLARE_RTFEXPORT_TEST(testFdo69384, "fdo69384-paste.rtf")
+{
+// Check if the style is loaded
+getStyles("ParagraphStyles")->getByName("Text body justified");
+}
+
+DECLARE_RTFEXPORT_TEST(testFdo69384Inserted, "hello.rtf")
 {
 uno::Reference xTextDocument(mxComponent, 
uno::UNO_QUERY);
 uno::Reference xText(xTextDocument->getText(), 
uno::UNO_QUERY);
 uno::Reference xEnd = xText->getEnd();
 paste("fdo69384-paste.rtf", xEnd);
 
-// Import got interrupted in the middle of style sheet table import,
-// resulting in missing styles and text.
-getStyles("ParagraphStyles")->getByName("Text body justified");
+// During insert of the RTF document we do not insert new styles
+CPPUNIT_ASSERT(!getStyles("ParagraphStyles")->hasByName("Text body 
justified"));
 }
 
-#endif
-
 DECLARE_RTFEXPORT_TEST(testFdo61193, "hello.rtf")
 {
 // Pasting content that contained a footnote caused a crash.
diff --git a/sw/qa/extras/uiwriter/data/fdo72942-insert.docx 
b/sw/qa/extras/uiwriter/data/fdo72942-insert.docx
new file mode 100755
index ..fb1f80c4ae09
Binary files /dev/null and b/sw/qa/extras/uiwriter/data/fdo72942-insert.docx 
differ
diff --git a/sw/qa/extras/uiwriter/data/fdo72942.docx 
b/sw/qa/extras/uiwriter/data/fdo72942.docx
new file mode 100755
index ..0906ec464271
Binary files /dev/null and b/sw/qa/extras/uiwriter/data/fdo72942.docx differ
diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index 4789d2d39829..a87abf1d4bff 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -264,6 +264,7 @@ public:
 void testTdf106736();
 void testTdf58604();
 void testTdf112025();
+void testTdf72942();
 void testTdf113877();
 void testTdf113877NoMerge();
 void testMsWordCompTrailingBlanks();
@@ -442,6 +443,7 @@ public:
 CPPUNIT_TEST(testTdf106736);
 CPPUNIT_TEST(testTdf58604);
 CPPUNIT_TEST(testTdf112025);
+CPPUNIT_TEST(testTdf72942);
 CPPUNIT_TEST(testTdf113877);
 CPPUNIT_TEST(testTdf113877NoMerge);
 CPPUNIT_TEST(testMsWordCompTrailingBlanks);
@@ -5279,6 +5281,39 @@ void SwUiWriterTest::testTdf112025()
 CPPUNIT_ASSERT_EQUAL(true, getProperty(xStyle, "IsLandscape"));
 }
 
+void SwUiWriterTest::testTdf72942()
+{
+load(DATA_DIRECTORY, "fdo72942.docx");
+
+// get a page cursor
+uno::Reference xModel(mxComponent, uno::UNO_QUERY);
+uno::Reference 
xTextViewCursorSupplier(xModel->getCurrentController(), uno::UNO_QUERY);
+uno::Reference 
xCursor(xTextViewCursorSupplier->getViewCursor(), uno::UNO_QUERY);
+xCursor->jumpToEndOfPage();
+
+OUString insertFileid = m_directories.getURLFromSrc(DATA_DIRECTORY) + 
"fdo72942-insert.docx";
+uno::Sequence 
aPropertyValues(comphelper::InitPropertySequence({{ "Name", 
uno::makeAny(insertFileid) }}));
+lcl_dispatchCommand(mxComponent, ".uno:InsertDoc", aPropertyValues);
+
+// check styles of paragraphs added from [fdo72942.docx]
+const uno::Reference< text::XTextRange > xRun1 = getRun(getParagraph(1), 
1);
+CPPUNIT_ASSERT_EQUAL(OUString("Default English (Liberation serif) text 
with "), xRun1->getString());
+CPPUNIT_ASSERT_EQUAL(OUString("Liberation Serif"), 
getProperty(xRun1, "CharFontName"));
+
+const uno::Reference< text::XTextRange > xRun2 = getRun(getParagraph(2), 
1);
+CPPUNIT_ASSERT_EQUAL(OUString("Header 1 English text (Liberation sans) 
with "), xRun2->getString());
+

[Libreoffice-commits] core.git: sc/qa

2018-01-30 Thread Jens Carl

 sc/qa/extras/sctableconditionalformatobj.cxx |   23 ---
 1 file changed, 4 insertions(+), 19 deletions(-)

New commits:
commit d88e9c4be7110c9cbafb98dffa7a3b7c4126459e
Author: Jens Carl 
Date:   Tue Jan 30 21:56:31 2018 +

Remove shared mxComponent (test document) in sctableconditionalformatobj

Change-Id: I9a255067cce2ae013d1054fbad7efa10bce4378b
Reviewed-on: https://gerrit.libreoffice.org/48939
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/sc/qa/extras/sctableconditionalformatobj.cxx 
b/sc/qa/extras/sctableconditionalformatobj.cxx
index b1ba62f93c53..0d83f94ff33f 100644
--- a/sc/qa/extras/sctableconditionalformatobj.cxx
+++ b/sc/qa/extras/sctableconditionalformatobj.cxx
@@ -34,8 +34,6 @@ using namespace com::sun::star;
 
 namespace sc_apitest
 {
-#define NUMBER_OF_TESTS 3
-
 class ScTableConditionalFormatObj : public CalcUnoApiTest, public 
apitest::XSheetConditionalEntries
 {
 public:
@@ -56,13 +54,9 @@ public:
 CPPUNIT_TEST_SUITE_END();
 
 private:
-static sal_Int32 nTest;
-static uno::Reference mxComponent;
+uno::Reference mxComponent;
 };
 
-sal_Int32 ScTableConditionalFormatObj::nTest = 0;
-uno::Reference ScTableConditionalFormatObj::mxComponent;
-
 ScTableConditionalFormatObj::ScTableConditionalFormatObj()
 : CalcUnoApiTest("/sc/qa/extras/testdocuments")
 {
@@ -70,10 +64,6 @@ ScTableConditionalFormatObj::ScTableConditionalFormatObj()
 
 uno::Reference ScTableConditionalFormatObj::init()
 {
-// create a calc document
-if (!mxComponent.is())
-mxComponent = loadFromDesktop("private:factory/scalc");
-
 uno::Reference xDoc(mxComponent, 
uno::UNO_QUERY_THROW);
 CPPUNIT_ASSERT_MESSAGE("no calc document", xDoc.is());
 
@@ -114,19 +104,14 @@ uno::Sequence 
ScTableConditionalFormatObj::createCondition
 
 void ScTableConditionalFormatObj::setUp()
 {
-nTest++;
-CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS);
 CalcUnoApiTest::setUp();
+// create a calc document
+mxComponent = loadFromDesktop("private:factory/scalc");
 }
 
 void ScTableConditionalFormatObj::tearDown()
 {
-if (nTest == NUMBER_OF_TESTS)
-{
-closeDocument(mxComponent);
-mxComponent.clear();
-}
-
+closeDocument(mxComponent);
 CalcUnoApiTest::tearDown();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

2018-01-30 Thread Jens Carl

 sc/qa/extras/screcentfunctionsobj.cxx |   23 ---
 1 file changed, 4 insertions(+), 19 deletions(-)

New commits:
commit ef52c5bf90713bb4751e36b6849e236a768f0aa4
Author: Jens Carl 
Date:   Tue Jan 30 18:29:40 2018 +

Remove shared mxComponent (test document) in screcentfunctionsobj

Change-Id: Id0d9e3f86f9e48333f415b4eb2a05b3211473b67
Reviewed-on: https://gerrit.libreoffice.org/48925
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/sc/qa/extras/screcentfunctionsobj.cxx 
b/sc/qa/extras/screcentfunctionsobj.cxx
index 289c87479cb0..4dc32b67b0bd 100644
--- a/sc/qa/extras/screcentfunctionsobj.cxx
+++ b/sc/qa/extras/screcentfunctionsobj.cxx
@@ -24,8 +24,6 @@ using namespace com::sun::star;
 
 namespace sc_apitest
 {
-#define NUMBER_OF_TESTS 3
-
 class ScRecentFunctionsObj : public CalcUnoApiTest, public 
apitest::XRecentFunctions
 {
 public:
@@ -45,13 +43,9 @@ public:
 CPPUNIT_TEST_SUITE_END();
 
 private:
-static sal_Int32 nTest;
-static uno::Reference mxComponent;
+uno::Reference mxComponent;
 };
 
-sal_Int32 ScRecentFunctionsObj::nTest = 0;
-uno::Reference ScRecentFunctionsObj::mxComponent;
-
 ScRecentFunctionsObj::ScRecentFunctionsObj()
 : CalcUnoApiTest("/sc/qa/extras/testdocuments")
 {
@@ -59,10 +53,6 @@ ScRecentFunctionsObj::ScRecentFunctionsObj()
 
 uno::Reference ScRecentFunctionsObj::init()
 {
-// create a calc document
-if (!mxComponent.is())
-mxComponent = loadFromDesktop("private:factory/scalc");
-
 uno::Reference xDoc(mxComponent, 
UNO_QUERY_THROW);
 CPPUNIT_ASSERT_MESSAGE("no calc document", xDoc.is());
 
@@ -72,19 +62,14 @@ uno::Reference ScRecentFunctionsObj::init()
 
 void ScRecentFunctionsObj::setUp()
 {
-nTest++;
-CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS);
 CalcUnoApiTest::setUp();
+// create a calc document
+mxComponent = loadFromDesktop("private:factory/scalc");
 }
 
 void ScRecentFunctionsObj::tearDown()
 {
-if (nTest == NUMBER_OF_TESTS)
-{
-closeDocument(mxComponent);
-mxComponent.clear();
-}
-
+closeDocument(mxComponent);
 CalcUnoApiTest::tearDown();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108882] [META] Read-only bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108882
Bug 108882 depends on bug 106837, which changed state.

Bug 106837 Summary: Slide navigation shortcuts and uno commands don't work in 
file opened read-only
https://bugs.documentfoundation.org/show_bug.cgi?id=106837

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|INSUFFICIENTDATA|---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98259
Bug 98259 depends on bug 106837, which changed state.

Bug 106837 Summary: Slide navigation shortcuts and uno commands don't work in 
file opened read-only
https://bugs.documentfoundation.org/show_bug.cgi?id=106837

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|INSUFFICIENTDATA|---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98259

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||106837


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106837
[Bug 106837] Slide navigation shortcuts and uno commands don't work in file
opened read-only
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85811] [META] Main menu bar bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=85811
Bug 85811 depends on bug 106837, which changed state.

Bug 106837 Summary: Slide navigation shortcuts and uno commands don't work in 
file opened read-only
https://bugs.documentfoundation.org/show_bug.cgi?id=106837

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|INSUFFICIENTDATA|---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106837] Slide navigation shortcuts and uno commands don' t work in file opened read-only

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=106837

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
   Keywords||bibisectRequest, regression
   Hardware|x86-64 (AMD64)  |All
 CC||philip...@hotmail.com
 Resolution|INSUFFICIENTDATA|---
 Blocks||98259
Summary|Navigation shortcut don't   |Slide navigation shortcuts
   |work in file opened |and uno commands don't work
   |read-only   |in file opened read-only
 OS|Linux (All) |All

--- Comment #5 from Yousuf Philips (jay)  ---
regression as it works fine in 5.0.6.

Version: 6.1.0.0.alpha0+
Build ID: e29565272c57c6cd09cb015c2e66bfe8a1f4d7d2
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=98259
[Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115320] New: Automatic preview of slide transition gets triggered even when the value of the duration control isnt changed

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115320

Bug ID: 115320
   Summary: Automatic preview of slide transition gets triggered
even when the value of the duration control isnt
changed
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
Blocks: 103444

Steps:
1. open impress
2. change to slide transition deck
3. select wipe transition
4. press tab three times
5. notice that preview gets triggered after leaving duration control, though
the value wasnt changed

Version: 6.1.0.0.alpha0+
Build ID: e29565272c57c6cd09cb015c2e66bfe8a1f4d7d2
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103444
[Bug 103444] [META] Slide transition deck/tab of the sidebar
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103444] [META] Slide transition deck/tab of the sidebar

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103444

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||115320


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115320
[Bug 115320] Automatic preview of slide transition gets triggered even when the
value of the duration control isnt changed
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75317] FILEOPEN: OOXML label placement results in strange placement of labels

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=75317

Luke  changed:

   What|Removed |Added

Summary|FILEOPEN: OOXML label   |FILEOPEN: OOXML label
   |placement results in|placement results in
   |strange placement of some   |strange placement of
   |labels  | labels

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90497] Implementing document themes

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=90497

--- Comment #19 from Yousuf Philips (jay)  ---
Now that Noto font family is bundled with LO, a 'Noto Family' entry should be
added to initFontSets() and as Open Sans is no longer bundled, the 'Open Sans'
entry should be removed.

https://opengrok.libreoffice.org/xref/core/sw/source/uibase/sidebar/ThemePanel.cxx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113638] [META] Fonts listed in LibreOffice

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113638
Bug 113638 depends on bug 97431, which changed state.

Bug 97431 Summary: Shlomo font not accessible
https://bugs.documentfoundation.org/show_bug.cgi?id=97431

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTOURBUG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112812] [META] Hebrew language-specific RTL issues

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112812
Bug 112812 depends on bug 97431, which changed state.

Bug 97431 Summary: Shlomo font not accessible
https://bugs.documentfoundation.org/show_bug.cgi?id=97431

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTOURBUG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97431] Shlomo font not accessible

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97431

Khaled Hosny  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTOURBUG

--- Comment #13 from Khaled Hosny  ---
The font is simply broken; its “name” table has entries specifying the font as
Shlomo and other entries specifying it as Ezra SIL SR (as reported by
FontConfig), which if these entries ends up being used is system-dependent and
outside of LibreOffice control.

The font needs to be fixed and provide consistent name table. Please report
this to the font developer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103437] [META] Custom animation deck/tab of the sidebar

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103437

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||100898


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100898
[Bug 100898] Sidebar decks without a content panel title are unattainable with
keyboard
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103428] [META] Properties deck/tab of the sidebar

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103428

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on|100898  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100898
[Bug 100898] Sidebar decks without a content panel title are unattainable with
keyboard
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103444] [META] Slide transition deck/tab of the sidebar

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103444

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||100898


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100898
[Bug 100898] Sidebar decks without a content panel title are unattainable with
keyboard
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 100898] Sidebar decks without a content panel title are unattainable with keyboard

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100898

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks|103428  |103437, 103444

--- Comment #16 from Yousuf Philips (jay)  ---
Tested the behaviour and found two issues (please file new bug reports for them
if you feel they cant/shouldnt be fixed here).

1. If you access the sidebar with F6, tab correctly works to cycle through the
deck title and non-content panel controls, but if you click on a non-content
panel control and use tab, you wont be able to reach the deck title.

2. After accessing the sidebar with F6, the shift+tab cursor movement order
jumps incorrectly to the deck title and then transition/animation presets
rather than the correct opposite order.

Version: 6.1.0.0.alpha0+
Build ID: e29565272c57c6cd09cb015c2e66bfe8a1f4d7d2
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103428
[Bug 103428] [META] Properties deck/tab of the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=103437
[Bug 103437] [META] Custom animation deck/tab of the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=103444
[Bug 103444] [META] Slide transition deck/tab of the sidebar
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: sc/qa

2018-01-30 Thread Jens Carl

 sc/qa/extras/scoutlineobj.cxx |   36 
 1 file changed, 12 insertions(+), 24 deletions(-)

New commits:
commit 1a43f636b20dbeed0c112bd1b97d862184ead089
Author: Jens Carl 
Date:   Tue Jan 30 18:26:46 2018 +

Remove shared mxComponent (test document) in scoutlineobj

Change-Id: I054de2c9f421e13069314146f972e95ab9ae322b
Reviewed-on: https://gerrit.libreoffice.org/48924
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/sc/qa/extras/scoutlineobj.cxx b/sc/qa/extras/scoutlineobj.cxx
index de14185e2db5..167cab94ad6a 100644
--- a/sc/qa/extras/scoutlineobj.cxx
+++ b/sc/qa/extras/scoutlineobj.cxx
@@ -10,6 +10,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 
@@ -18,8 +19,6 @@ using namespace css::uno;
 
 namespace sc_apitest {
 
-#define NUMBER_OF_TESTS 6
-
 class ScOutlineObj : public CalcUnoApiTest, public apitest::XSheetOutline
 {
 public:
@@ -31,23 +30,22 @@ public:
 virtual uno::Reference< uno::XInterface > init() override;
 
 CPPUNIT_TEST_SUITE(ScOutlineObj);
+
+// XSheetOutline
 CPPUNIT_TEST(testHideDetail);
 CPPUNIT_TEST(testShowDetail);
 CPPUNIT_TEST(testShowLevel);
 CPPUNIT_TEST(testUngroup);
 CPPUNIT_TEST(testGroup);
-  //  CPPUNIT_TEST(testAutoOutline);
+//CPPUNIT_TEST(testAutoOutline);
 CPPUNIT_TEST(testClearOutline);
+
 CPPUNIT_TEST_SUITE_END();
-private:
 
-static sal_Int32 nTest;
-static uno::Reference< lang::XComponent > mxComponent;
+private:
+uno::Reference< lang::XComponent > mxComponent;
 };
 
-sal_Int32 ScOutlineObj::nTest = 0;
-uno::Reference< lang::XComponent > ScOutlineObj::mxComponent;
-
 ScOutlineObj::ScOutlineObj()
 : CalcUnoApiTest("/sc/qa/extras/testdocuments")
 {
@@ -55,13 +53,6 @@ ScOutlineObj::ScOutlineObj()
 
 uno::Reference< uno::XInterface > ScOutlineObj::init()
 {
-// get the test file
-OUString aFileURL;
-createFileURL("ScOutlineObj.ods", aFileURL);
-if(!mxComponent.is())
-mxComponent = loadFromDesktop(aFileURL);
-CPPUNIT_ASSERT_MESSAGE("Component not loaded", mxComponent.is());
-
 // get the first sheet
 uno::Reference< sheet::XSpreadsheetDocument > xDoc(mxComponent, 
UNO_QUERY_THROW);
 CPPUNIT_ASSERT_MESSAGE("no calc document", xDoc.is());
@@ -74,19 +65,16 @@ uno::Reference< uno::XInterface > ScOutlineObj::init()
 
 void ScOutlineObj::setUp()
 {
-nTest++;
-CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS);
 CalcUnoApiTest::setUp();
+// create a calc document
+OUString aFileURL;
+createFileURL("ScOutlineObj.ods", aFileURL);
+mxComponent = loadFromDesktop(aFileURL);
 }
 
 void ScOutlineObj::tearDown()
 {
-if (nTest == NUMBER_OF_TESTS)
-{
-closeDocument(mxComponent);
-mxComponent.clear();
-}
-
+closeDocument(mxComponent);
 CalcUnoApiTest::tearDown();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

2018-01-30 Thread Jens Carl

 sc/qa/extras/scsubtotaldescriptorbaseobj.cxx |   24 
 1 file changed, 4 insertions(+), 20 deletions(-)

New commits:
commit e0acc74c57a71985ded8f410bd8b44c89b933007
Author: Jens Carl 
Date:   Tue Jan 30 20:39:19 2018 +

Remove shared mxComponent (test document) in scsubtotaldescriptorbaseobj

Change-Id: Ia97f3e7b637c2b14a9c07c521dcd5b8ff1ff0686
Reviewed-on: https://gerrit.libreoffice.org/48935
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/sc/qa/extras/scsubtotaldescriptorbaseobj.cxx 
b/sc/qa/extras/scsubtotaldescriptorbaseobj.cxx
index 946722ed6116..519bb78ee4ea 100644
--- a/sc/qa/extras/scsubtotaldescriptorbaseobj.cxx
+++ b/sc/qa/extras/scsubtotaldescriptorbaseobj.cxx
@@ -31,8 +31,6 @@ using namespace com::sun::star;
 
 namespace sc_apitest {
 
-#define NUMBER_OF_TESTS 3
-
 class ScSubTotalDescriptorBaseObj : public CalcUnoApiTest,
 public apitest::SubTotalDescriptor,
 public apitest::XSubTotalDescriptor
@@ -56,14 +54,9 @@ public:
 CPPUNIT_TEST_SUITE_END();
 
 private:
-static sal_Int32 nTest;
-static uno::Reference< lang::XComponent > mxComponent;
-
+uno::Reference< lang::XComponent > mxComponent;
 };
 
-sal_Int32 ScSubTotalDescriptorBaseObj::nTest = 0;
-uno::Reference< lang::XComponent > ScSubTotalDescriptorBaseObj::mxComponent;
-
 ScSubTotalDescriptorBaseObj::ScSubTotalDescriptorBaseObj()
 : CalcUnoApiTest("/sc/qa/extras/testdocuments")
 {
@@ -71,10 +64,6 @@ ScSubTotalDescriptorBaseObj::ScSubTotalDescriptorBaseObj()
 
 uno::Reference< uno::XInterface > ScSubTotalDescriptorBaseObj::init()
 {
-// create a calc document
-if (!mxComponent.is())
-mxComponent = loadFromDesktop("private:factory/scalc");
-
 uno::Reference< sheet::XSpreadsheetDocument > xDoc(mxComponent, 
uno::UNO_QUERY_THROW);
 CPPUNIT_ASSERT_MESSAGE("no calc document", xDoc.is());
 
@@ -95,19 +84,14 @@ uno::Reference< uno::XInterface > 
ScSubTotalDescriptorBaseObj::init()
 
 void ScSubTotalDescriptorBaseObj::setUp()
 {
-nTest++;
-CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS);
 CalcUnoApiTest::setUp();
+// create a calc document
+mxComponent = loadFromDesktop("private:factory/scalc");
 }
 
 void ScSubTotalDescriptorBaseObj::tearDown()
 {
-if (nTest == NUMBER_OF_TESTS)
-{
-closeDocument(mxComponent);
-mxComponent.clear();
-}
-
+closeDocument(mxComponent);
 CalcUnoApiTest::tearDown();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97431] Shlomo font not accessible

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97431

Shai Berger  changed:

   What|Removed |Added

 CC||s...@platonix.com

--- Comment #12 from Shai Berger  ---
Created attachment 139452
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139452=edit
Shlomo font selected by typing, it was not in the font list

LO 5.4.4.2 on Debian Testing, Ezra SIL installed in the system.

Shlomo is not displayed in the font list, however, if I type in its name, I do
get it (I can tell because the text looks like Ezra SIL).

fc-list output is as in Comment 1.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - sw/source

2018-01-30 Thread Matthias Seidel

 sw/source/filter/ww8/ww8scan.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b4027b74a699d7a8070d0669e780b7fbe4d03807
Author: Matthias Seidel 
Date:   Tue Jan 30 22:43:38 2018 +

Translated German abbreviation (ggfs.) in comment

diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 679b735ebc9e..fac10fa80e5d 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -6197,7 +6197,7 @@ WW8Style::WW8Style(SvStream& rStream, WW8Fib& rFibPara)
 if ( 20 > nRead ) break;
 rSt >> ftcBi;
 
-// ggfs. Check the rest
+// if necessary check the rest
 if( 20 < nRead )
 rSt.SeekRel( nRead-20 );
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115319] Reference fields: support automatic Hungarian article selection

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115319

László Németh  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |nem...@numbertext.org
   |desktop.org |
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115319] New: Reference fields: support automatic Hungarian article selection

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115319

Bug ID: 115319
   Summary: Reference fields: support automatic Hungarian article
selection
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: nem...@numbertext.org

Description:
OOo Extension Hunart (Hungarian cross-reference toolbar) is an incomplete and
fragile workaround for this problem (it supports only sequence types, and it
uses hidden, but removable fields).

As a better solution, I propose the following OpenDocument improvement,
implemented in LibreOffice:

[text] additional text attribute for alternative language-specific reference
formats.

This is an enhancement, described in terms of changes to OpenDocument-v1.2 

1. RATIONALE

1.1 Use cases:

   Reference formats give an incomplete solution for
   Hungarian language, because they don't support
   automatic selection of the frequently used definitive
   articles before the reference.

   Supported (without article):

   "lásd 1. oldal" ("see page 1")

   Not supported (article "a" or "az"):

   "*az* 1. oldalon" ("on page 1")
   "*a* 2. oldalon" ("on page 2")

   LaTeX Babel package uses \aref, \apageref etc. commands
   for references with automatic Hungarian articles.

   Suggested text:reference-language attribute has
   got the following features:

   – i18n:

 It's possible to add alternative reference formats to
 Hungarian and other languages with similar needs.

   – back-compatibility:

 Only the alternative language-dependent layout,
 – in the case of Hungarian, only the articles – are
 missing in an older application, not the original
 reference format "chapter", "direction", "page" etc.

   – translation support:

 Alternative language-dependent layout of the
 reference fields is visible only in the same
 language text. For example, changing the
 language of a Hungarian document to English
 hides the Hungarian articles, helping
 translators.

1.2 Alternatives considered:
   None.

2. REQUESTED CHANGES TO THE ODF STANDARD

2.1 Text changes/additions:

   The text:reference-language attribute specifies an alternative way
   how information about a reference is displayed.

   The text:reference-language attribute has the data type languageCode.

   If the text:reference-language attribute is not specified, or the
   language of the text, where the reference inserted, is different from
   the specified reference language, common visualization of reference
   formats is used as the default.

   Letter case of the identifier can store the optional capitalization
   of the alternative reference format (like value "a" and "A" of
style:num-format).

   Examples

   – text:reference-language is not specified

 Visualizations: "1"; "2"

   – text:reference-language="hu" (Hungarian article "a" or "az")

 Visualizations: "az 1"; "a 2"

   – text:reference-language="Hu" (Hungarian article "A" or "Az")

 Visualizations: "Az 1"; "A 2"

   The text:reference-language attribute is usable with the following elements:
7.7.6,  7.7.7,  7.7.5
and
7.7.8.

2.2 Schema changes/additions:

   
   
   ...
   
   
   
   
   
   ...
   
   

3. IMPACTS

3.1 Conformance:
   This proposal will not add any mandatory features or behaviors.

3.2 Backwards compatibility:
   This element was not available in previous versions and is
   optional. Existing ODF processors may ignore it.

3.3 Accessibility impact:
   None.


Steps to Reproduce:
-

Actual Results:  
-

Expected Results:
-


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:58.0) Gecko/20100101
Firefox/58.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102283] [META] Slide/page pane bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102283

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||114830


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114830
[Bug 114830] After closing Page Pane, "Slide 1" tooltip remains on the screen
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114830] After closing Page Pane, "Slide 1" tooltip remains on the screen

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114830

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||102283
Summary|After closing   |After closing Page Pane,
   |"View-Page-Pane" tooltip|"Slide 1" tooltip remains
   |for preview "Slide 1"   |on the screen
   |remains on the screen   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102283
[Bug 102283] [META] Slide/page pane bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - sc/qa

2018-01-30 Thread Jens Carl

 sc/qa/extras/scscenariosobj.cxx   |   23 ---
 sc/qa/extras/scspreadsheetsettingsobj.cxx |   23 ---
 2 files changed, 8 insertions(+), 38 deletions(-)

New commits:
commit 8b521b2535ca1e80758f57abf1656fc3eb21a47c
Author: Jens Carl 
Date:   Tue Jan 30 20:04:19 2018 +

Remove shared mxComponent (test document) in scspreadsheetsettingsobj

Change-Id: I6c96bf694ec64fec2ddae66a42cf8cc2a8fc0e7a
Reviewed-on: https://gerrit.libreoffice.org/48931
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/sc/qa/extras/scspreadsheetsettingsobj.cxx 
b/sc/qa/extras/scspreadsheetsettingsobj.cxx
index 7cb3e22a6f90..34edd4cc916f 100644
--- a/sc/qa/extras/scspreadsheetsettingsobj.cxx
+++ b/sc/qa/extras/scspreadsheetsettingsobj.cxx
@@ -23,8 +23,6 @@ using namespace com::sun::star;
 
 namespace sc_apitest
 {
-#define NUMBER_OF_TESTS 1
-
 class ScSpreadsheetSettingsObj : public CalcUnoApiTest, public 
apitest::GlobalSheetSettings
 {
 public:
@@ -42,13 +40,9 @@ public:
 CPPUNIT_TEST_SUITE_END();
 
 private:
-static sal_Int32 nTest;
-static uno::Reference mxComponent;
+uno::Reference mxComponent;
 };
 
-sal_Int32 ScSpreadsheetSettingsObj::nTest = 0;
-uno::Reference ScSpreadsheetSettingsObj::mxComponent;
-
 ScSpreadsheetSettingsObj::ScSpreadsheetSettingsObj()
 : CalcUnoApiTest("/sc/qa/extras/testdocuments")
 {
@@ -56,10 +50,6 @@ ScSpreadsheetSettingsObj::ScSpreadsheetSettingsObj()
 
 uno::Reference ScSpreadsheetSettingsObj::init()
 {
-// create a calc document
-if (!mxComponent.is())
-mxComponent = loadFromDesktop("private:factory/scalc");
-
 uno::Reference xDoc(mxComponent, 
UNO_QUERY_THROW);
 CPPUNIT_ASSERT_MESSAGE("no calc document", xDoc.is());
 
@@ -69,19 +59,14 @@ uno::Reference 
ScSpreadsheetSettingsObj::init()
 
 void ScSpreadsheetSettingsObj::setUp()
 {
-nTest++;
-CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS);
 CalcUnoApiTest::setUp();
+// create a calc document
+mxComponent = loadFromDesktop("private:factory/scalc");
 }
 
 void ScSpreadsheetSettingsObj::tearDown()
 {
-if (nTest == NUMBER_OF_TESTS)
-{
-closeDocument(mxComponent);
-mxComponent.clear();
-}
-
+closeDocument(mxComponent);
 CalcUnoApiTest::tearDown();
 }
 
commit 3e32f5530b1292a9edc5fed5997a52d0fa554420
Author: Jens Carl 
Date:   Tue Jan 30 19:55:33 2018 +

Remove shared mxComponent (test document) in scscenariosobj

Change-Id: If37b9fa10fd935c5273a817acbf7d2d2f7eeedb8
Reviewed-on: https://gerrit.libreoffice.org/48930
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/sc/qa/extras/scscenariosobj.cxx b/sc/qa/extras/scscenariosobj.cxx
index 5f3533785103..27524fda7083 100644
--- a/sc/qa/extras/scscenariosobj.cxx
+++ b/sc/qa/extras/scscenariosobj.cxx
@@ -32,8 +32,6 @@ using namespace com::sun::star;
 
 namespace sc_apitest
 {
-#define NUMBER_OF_TESTS 2
-
 class ScScenariosObj : public CalcUnoApiTest, public apitest::XScenarios
 {
 public:
@@ -52,13 +50,9 @@ public:
 CPPUNIT_TEST_SUITE_END();
 
 private:
-static sal_Int32 nTest;
-static uno::Reference mxComponent;
+uno::Reference mxComponent;
 };
 
-sal_Int32 ScScenariosObj::nTest = 0;
-uno::Reference ScScenariosObj::mxComponent;
-
 ScScenariosObj::ScScenariosObj()
 : CalcUnoApiTest("/sc/qa/extras/testdocuments")
 {
@@ -66,10 +60,6 @@ ScScenariosObj::ScScenariosObj()
 
 uno::Reference ScScenariosObj::init()
 {
-// create a calc document
-if (!mxComponent.is())
-mxComponent = loadFromDesktop("private:factory/scalc");
-
 uno::Reference xDoc(mxComponent, 
uno::UNO_QUERY_THROW);
 CPPUNIT_ASSERT_MESSAGE("no calc document", xDoc.is());
 
@@ -95,19 +85,14 @@ uno::Reference ScScenariosObj::init()
 
 void ScScenariosObj::setUp()
 {
-nTest++;
-CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS);
 CalcUnoApiTest::setUp();
+// create a calc document
+mxComponent = loadFromDesktop("private:factory/scalc");
 }
 
 void ScScenariosObj::tearDown()
 {
-if (nTest == NUMBER_OF_TESTS)
-{
-closeDocument(mxComponent);
-mxComponent.clear();
-}
-
+closeDocument(mxComponent);
 CalcUnoApiTest::tearDown();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114251] Hang loading spreadsheet

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114251

--- Comment #36 from Eike Rathke  ---
My commits didn't claim to fix anything, they only touched related areas, hence
the "Related" in the commit message, which also lead to overeager vectorization
in earlier releases without causing this "hang" (which it is not, it is just
unbearable slow, eventually it will finish).

The real cause is triggering the threaded group interpreter here, see my
comment 3 and comment 4.

Something for Dennis to fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115233] Replacing image resets the crop

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115233

--- Comment #5 from Matthew  ---
Well the source files we typically use are png screenshots. So any such files
should work. We've hit this bug on both OSX and Linux so far.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

2018-01-30 Thread Jens Carl

 sc/qa/extras/scnamedrangesobj.cxx |   34 --
 1 file changed, 12 insertions(+), 22 deletions(-)

New commits:
commit d3297c0c356a76e328fff1f542c4f1e81361b4ac
Author: Jens Carl 
Date:   Tue Jan 30 18:20:12 2018 +

Remove shared mxComponent (test document) in scnamedrangesobj

Change-Id: Ibf08ba22508fbe3f37878ecb0c024a1fdeff8e64
Reviewed-on: https://gerrit.libreoffice.org/48923
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/sc/qa/extras/scnamedrangesobj.cxx 
b/sc/qa/extras/scnamedrangesobj.cxx
index 302e2d371ffc..dd08cbb01743 100644
--- a/sc/qa/extras/scnamedrangesobj.cxx
+++ b/sc/qa/extras/scnamedrangesobj.cxx
@@ -19,33 +19,30 @@ using namespace css::uno;
 
 namespace sc_apitest {
 
-#define NUMBER_OF_TESTS 3
-
 class ScNamedRangesObj : public CalcUnoApiTest, public apitest::XNamedRanges
 {
 public:
+ScNamedRangesObj();
+
 virtual void setUp() override;
 virtual void tearDown() override;
 
 virtual uno::Reference< uno::XInterface > init(sal_Int32 nSheet = 0) 
override;
 
-ScNamedRangesObj();
-
 CPPUNIT_TEST_SUITE(ScNamedRangesObj);
+
+// XNamedRanges
 CPPUNIT_TEST(testAddNewByName);
 CPPUNIT_TEST(testAddNewFromTitles);
 //CPPUNIT_TEST_EXCEPTION(testRemoveByName, uno::RuntimeException);
 CPPUNIT_TEST(testOutputList);
+
 CPPUNIT_TEST_SUITE_END();
 
 private:
-static sal_Int32 nTest;
-static uno::Reference< lang::XComponent > mxComponent;
+uno::Reference< lang::XComponent > mxComponent;
 };
 
-sal_Int32 ScNamedRangesObj::nTest = 0;
-uno::Reference< lang::XComponent > ScNamedRangesObj::mxComponent;
-
 ScNamedRangesObj::ScNamedRangesObj()
  : CalcUnoApiTest("/sc/qa/extras/testdocuments")
 {
@@ -53,10 +50,6 @@ ScNamedRangesObj::ScNamedRangesObj()
 
 uno::Reference< uno::XInterface > ScNamedRangesObj::init(sal_Int32 nSheet)
 {
-OUString aFileURL;
-createFileURL("ScNamedRangeObj.ods", aFileURL);
-if(!mxComponent.is())
-mxComponent = loadFromDesktop(aFileURL, 
"com.sun.star.sheet.SpreadsheetDocument");
 CPPUNIT_ASSERT_MESSAGE("no component loaded", mxComponent.is());
 
 uno::Reference< beans::XPropertySet > xPropSet (mxComponent, 
UNO_QUERY_THROW);
@@ -65,26 +58,23 @@ uno::Reference< uno::XInterface > 
ScNamedRangesObj::init(sal_Int32 nSheet)
 //set value from xnamedranges.hxx
 uno::Reference< sheet::XSpreadsheetDocument > xDoc(mxComponent, 
UNO_QUERY_THROW);
 uno::Reference< container::XIndexAccess > xIndexAccess(xDoc->getSheets(), 
UNO_QUERY_THROW);
-xSheet.set(xIndexAccess->getByIndex(nSheet),UNO_QUERY_THROW);
+xSheet.set(xIndexAccess->getByIndex(nSheet), UNO_QUERY_THROW);
 
 return xNamedRanges;
 }
 
 void ScNamedRangesObj::setUp()
 {
-nTest++;
-CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS);
 CalcUnoApiTest::setUp();
+// create a calc document
+OUString aFileURL;
+createFileURL("ScNamedRangeObj.ods", aFileURL);
+mxComponent = loadFromDesktop(aFileURL, 
"com.sun.star.sheet.SpreadsheetDocument");
 }
 
 void ScNamedRangesObj::tearDown()
 {
-if (nTest == NUMBER_OF_TESTS)
-{
-closeDocument(mxComponent);
-mxComponent.clear();
-}
-
+closeDocument(mxComponent);
 CalcUnoApiTest::tearDown();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

2018-01-30 Thread Jens Carl

 sc/qa/extras/scmodelobj.cxx |   25 ++---
 1 file changed, 6 insertions(+), 19 deletions(-)

New commits:
commit 4f24c1919be05eef757d0b4ae89349f3601c77ee
Author: Jens Carl 
Date:   Tue Jan 30 18:10:47 2018 +

Remove shared mxComponent (test document) in scmodelobj

Change-Id: I2937c85f3e86d76838c17b7e881a1d9f7cddd68d
Reviewed-on: https://gerrit.libreoffice.org/48921
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/sc/qa/extras/scmodelobj.cxx b/sc/qa/extras/scmodelobj.cxx
index 418a23e98e09..0b1e9c8118b3 100644
--- a/sc/qa/extras/scmodelobj.cxx
+++ b/sc/qa/extras/scmodelobj.cxx
@@ -21,8 +21,6 @@ using namespace css::uno;
 
 namespace sc_apitest {
 
-#define NUMBER_OF_TESTS 3
-
 class ScModelObj : public UnoApiTest, public apitest::XConsolidatable,
   public apitest::XGoalSeek
 {
@@ -46,8 +44,7 @@ public:
 CPPUNIT_TEST_SUITE_END();
 
 private:
-static sal_Int32 nTest;
-static uno::Reference< lang::XComponent > mxComponent;
+uno::Reference< lang::XComponent > mxComponent;
 };
 
 ScModelObj::ScModelObj()
@@ -55,15 +52,8 @@ ScModelObj::ScModelObj()
 {
 }
 
-sal_Int32 ScModelObj::nTest = 0;
-uno::Reference< lang::XComponent > ScModelObj::mxComponent;
-
 uno::Reference< uno::XInterface > ScModelObj::init()
 {
-OUString aFileURL;
-createFileURL("ScModelObj.ods", aFileURL);
-if(!mxComponent.is())
-mxComponent = loadFromDesktop(aFileURL, 
"com.sun.star.sheet.SpreadsheetDocument");
 CPPUNIT_ASSERT_MESSAGE("no component loaded", mxComponent.is());
 
 return mxComponent;
@@ -71,19 +61,16 @@ uno::Reference< uno::XInterface > ScModelObj::init()
 
 void ScModelObj::setUp()
 {
-nTest++;
-CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS);
 UnoApiTest::setUp();
+// create a calc document
+OUString aFileURL;
+createFileURL("ScModelObj.ods", aFileURL);
+mxComponent = loadFromDesktop(aFileURL, 
"com.sun.star.sheet.SpreadsheetDocument");
 }
 
 void ScModelObj::tearDown()
 {
-if (nTest == NUMBER_OF_TESTS)
-{
-closeDocument(mxComponent);
-mxComponent.clear();
-}
-
+closeDocument(mxComponent);
 UnoApiTest::tearDown();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 113638] [META] Fonts listed in LibreOffice

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113638

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||97431


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=97431
[Bug 97431] Shlomo font not accessible
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112812] [META] Hebrew language-specific RTL issues

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112812

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||97431


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=97431
[Bug 97431] Shlomo font not accessible
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97431] Shlomo font not accessible

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97431

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||khaledho...@eglug.org
 Blocks|102985  |113638, 112812

--- Comment #11 from Yousuf Philips (jay)  ---
Shlomo appears fine in the font list for me in Linux Mint 18 (ubuntu 16.04
base).

Version: 6.1.0.0.alpha0+
Build ID: ea89dabf8b6363972190a6b50c527c418d51c2c7
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102985
[Bug 102985] [META] Font bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112812
[Bug 112812] [META] Hebrew language-specific RTL issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113638
[Bug 113638] [META] Fonts listed in LibreOffice
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102985] [META] Font bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102985

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on|97431   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=97431
[Bug 97431] Shlomo font not accessible
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108542] [META] Chart label bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108542
Bug 108542 depends on bug 75317, which changed state.

Bug 75317 Summary: FILEOPEN: OOXML label placement results in strange placement 
of some labels
https://bugs.documentfoundation.org/show_bug.cgi?id=75317

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102985] [META] Font bugs and enhancements

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102985

--- Comment #6 from Yousuf Philips (jay)  ---
Base meta bug for all font related issues, but most bugs should fall under one
of the sub-meta bugs that deal with

* how fonts render in a document (bug 71732)
* rendering of font previews (bug 108736)
* fonts available in the font list (bug 113638)
* font formats that are supported (bug 113639)
* font substitution behavior and information (bug 103342)
* fonts that are bundled with libreoffice (bug 113305)
* font preferences per locale (bug 114750)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75054] FILEOPEN: MS .docx Fails to import chart properly

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=75054
Bug 75054 depends on bug 75317, which changed state.

Bug 75317 Summary: FILEOPEN: OOXML label placement results in strange placement 
of some labels
https://bugs.documentfoundation.org/show_bug.cgi?id=75317

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75057] [META] OOXML Chart object issues

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=75057
Bug 75057 depends on bug 75317, which changed state.

Bug 75317 Summary: FILEOPEN: OOXML label placement results in strange placement 
of some labels
https://bugs.documentfoundation.org/show_bug.cgi?id=75317

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75317] FILEOPEN: OOXML label placement results in strange placement of some labels

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=75317

Luke  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #7 from Luke  ---
Verified FIXED in Version: 6.1.0.0.alpha0+
Build ID: 20e5f64215853bdd32c5f16394ba7f2f36745904

Thanks Szymon Kłos

*** This bug has been marked as a duplicate of bug 114821 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75317] FILEOPEN: OOXML label placement results in strange placement of some labels

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=75317

Luke  changed:

   What|Removed |Added

Summary|automatic label placement   |FILEOPEN: OOXML label
   |results in strange  |placement results in
   |placement of some labels|strange placement of some
   ||labels

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2018-01-30 Thread tagezi

 sc/source/ui/view/tabview3.cxx |   31 +++
 1 file changed, 15 insertions(+), 16 deletions(-)

New commits:
commit b0a391d62c1df7525069a02913a52af940d92ecc
Author: tagezi 
Date:   Fri Jan 26 16:26:53 2018 +0300

Circular movement of cursor in a table with  hidden columns/rows, tdf#68290 
related

If there is a table with range on the edges of the hidden columns/rows,
it allows you to quickly jump to the beginning/end of a neighboring
column using Enter/Shift+Enter

Change-Id: I5b18789b70089a6987ec7718998f5861261b22f8
Reviewed-on: https://gerrit.libreoffice.org/48691
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/source/ui/view/tabview3.cxx b/sc/source/ui/view/tabview3.cxx
index 13e2ac264bea..f8a5a7b4da53 100644
--- a/sc/source/ui/view/tabview3.cxx
+++ b/sc/source/ui/view/tabview3.cxx
@@ -1369,21 +1369,21 @@ void ScTabView::MoveCursorEnter( bool bShift )  
// bShift -> up/down
 break;
 }
 
+SCCOL nCurX;
+SCROW nCurY;
+aViewData.GetMoveCursor( nCurX,nCurY );
+SCCOL nNewX = nCurX;
+SCROW nNewY = nCurY;
+SCTAB nTab  = aViewData.GetTabNo();
+
 ScMarkData& rMark = aViewData.GetMarkData();
+ScDocument* pDoc  = aViewData.GetDocument();
+
 if (rMark.IsMarked() || rMark.IsMultiMarked())
 {
-SCCOL nCurX;
-SCROW nCurY;
-aViewData.GetMoveCursor( nCurX,nCurY );
-SCCOL nNewX = nCurX;
-SCROW nNewY = nCurY;
-SCTAB nTab = aViewData.GetTabNo();
+pDoc->GetNextPos( nNewX, nNewY, nTab, nMoveX, nMoveY, true, false, 
rMark );
 
-ScDocument* pDoc = aViewData.GetDocument();
-pDoc->GetNextPos( nNewX,nNewY, nTab, nMoveX,nMoveY, true, false, rMark 
);
-
-MoveCursorRel( nNewX-nCurX, nNewY-nCurY,
-SC_FOLLOW_LINE, false, true );
+MoveCursorRel( nNewX - nCurX, nNewY - nCurY, SC_FOLLOW_LINE, false, 
true );
 
 //  update input line even if cursor was not moved
 if ( nNewX == nCurX && nNewY == nCurY )
@@ -1393,18 +1393,17 @@ void ScTabView::MoveCursorEnter( bool bShift )  
// bShift -> up/down
 {
 if ( nMoveY != 0 && !nMoveX )
 {
+pDoc->GetNextPos( nNewX, nNewY, nTab, nMoveX, nMoveY, true, false, 
rMark );
+
 // after Tab and Enter back to the starting column again
 SCCOL nTabCol = aViewData.GetTabStartCol();
 if (nTabCol != SC_TABSTART_NONE)
 {
-SCCOL nCurX;
-SCROW nCurY;
-aViewData.GetMoveCursor( nCurX,nCurY );
-nMoveX = nTabCol-nCurX;
+nNewX = nTabCol;
 }
 }
 
-MoveCursorRel( nMoveX,nMoveY, SC_FOLLOW_LINE, false );
+MoveCursorRel( nNewX - nCurX, nNewY - nCurY, SC_FOLLOW_LINE, false, 
true );
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114251] Hang loading spreadsheet

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114251

--- Comment #35 from Jim Avera  ---
master builds still hang while loading "hang3.ods" (attached).

Version: 6.1.0.0.alpha0+
Build ID: e29565272c57c6cd09cb015c2e66bfe8a1f4d7d2
CPU threads: 12; OS: Linux 4.13; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2018-01-29_23:29:16
Locale: en-US (en_US.UTF-8); Calc: group threaded


I also re-tested with the latest 5.4 build (5.4.5.0.0+ 2018-01-30_10:34:41), 
since some patches were submitted to 5.4 per comment #31,32,33, 34.
Everything seems normal, i.e. no hang or other problems.  
FWIW I never observed this bug on a 5.4 build.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79167] UI: Opening the new "navigate by" for choosing the object to go back opens the "big" navigation window, too

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=79167

--- Comment #40 from Harald Koester  ---
I checked the new drop down menu (Ver. 6.0.0.3, Win 10). 2 Comments:

(1) If you search for a previous or next item and the item does not exist,
there is no error message. I would expect a message similar, if a search string
is not found ("Search key not found"). Write new bug report?

(2) If you perform a normal find text operation, the object type of the new
drop down menu is switched to "Repeat search". This is a bit awkward, if you
always have to switch back to the original object type. To my opinion the item
"Repeat search" can be omitted in the new menu, because all searches can be
done with the drop down menu for searches.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115233] Replacing image resets the crop

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115233

--- Comment #4 from Telesto  ---
A two sample images for the testing purposes would make testing easier ;-).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114263] [LOCALHELP] More BASIC functions to document in Help pages

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114263

tagezi  changed:

   What|Removed |Added

 CC||lera.goncha...@gmail.com

--- Comment #1 from tagezi  ---
I see that functions below exists in code. But I am not sure that every from
they design at the end.

Me
Replace
ResolvePath
RTL

there is a document which gives function names and returned value for them.
http://www.imaccanici.org/en.libreofficeforum.org/sites/libreofficeforum.org/files/uploads/ian%20rsbugs_files/LibreOffice%20BASIC%20Functions%20including%20Parameters.pdf

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114855] Replacing Source Sans Pro by Source Sans Variable

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114855

--- Comment #3 from Yousuf Philips (jay)  ---


*** This bug has been marked as a duplicate of bug 103596 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103596] Support OpenType Font Variation based text layout

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103596

--- Comment #15 from Yousuf Philips (jay)  ---
*** Bug 114855 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115233] Replacing image resets the crop

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115233

--- Comment #3 from Matthew  ---
Any update on reproducing this on your side?

Thanks,
Matthew

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

2018-01-30 Thread Jens Carl

 sc/qa/extras/scnamedrangeobj.cxx |   28 
 1 file changed, 8 insertions(+), 20 deletions(-)

New commits:
commit b7896ade3e54c6809f588c3f2deab02b3d803a26
Author: Jens Carl 
Date:   Tue Jan 30 18:16:45 2018 +

Remove shared mxComponent (test document) in scnamedrangeobj

Change-Id: Ieb32cb4b4a4cc4c897ecbcdb29dd64bf5d31b28f
Reviewed-on: https://gerrit.libreoffice.org/48922
Reviewed-by: Jens Carl 
Tested-by: Jens Carl 

diff --git a/sc/qa/extras/scnamedrangeobj.cxx b/sc/qa/extras/scnamedrangeobj.cxx
index 49f7895c40a5..f0021cca3c9f 100644
--- a/sc/qa/extras/scnamedrangeobj.cxx
+++ b/sc/qa/extras/scnamedrangeobj.cxx
@@ -22,8 +22,6 @@ using namespace css::uno;
 
 namespace sc_apitest {
 
-#define NUMBER_OF_TESTS 9
-
 class ScNamedRangeObj : public CalcUnoApiTest, public apitest::XNamedRange, 
public apitest::XNamed, public apitest::XCellRangeReferrer
 {
 public:
@@ -36,6 +34,7 @@ public:
 virtual uno::Reference< sheet::XNamedRange > getNamedRange(const OUString& 
rRangeName) override;
 
 CPPUNIT_TEST_SUITE(ScNamedRangeObj);
+
 CPPUNIT_TEST(testGetContent);
 CPPUNIT_TEST(testSetContent);
 CPPUNIT_TEST(testGetType);
@@ -45,17 +44,13 @@ public:
 CPPUNIT_TEST(testSetName);
 CPPUNIT_TEST(testGetName);
 CPPUNIT_TEST(testGetReferredCells);
+
 CPPUNIT_TEST_SUITE_END();
 private:
 uno::Reference< sheet::XNamedRanges > init_impl();
-
-static sal_Int32 nTest;
-static uno::Reference< lang::XComponent > mxComponent;
+uno::Reference< lang::XComponent > mxComponent;
 };
 
-sal_Int32 ScNamedRangeObj::nTest = 0;
-uno::Reference< lang::XComponent > ScNamedRangeObj::mxComponent;
-
 ScNamedRangeObj::ScNamedRangeObj():
 CalcUnoApiTest("/sc/qa/extras/testdocuments"),
 apitest::XNamed("NamedRange"),
@@ -65,10 +60,6 @@ ScNamedRangeObj::ScNamedRangeObj():
 
 uno::Reference< sheet::XNamedRanges > ScNamedRangeObj::init_impl()
 {
-OUString aFileURL;
-createFileURL("ScNamedRangeObj.ods", aFileURL);
-if(!mxComponent.is())
-mxComponent = loadFromDesktop(aFileURL, 
"com.sun.star.sheet.SpreadsheetDocument");
 CPPUNIT_ASSERT_MESSAGE("no component loaded", mxComponent.is());
 
 uno::Reference< beans::XPropertySet > xPropSet (mxComponent, 
UNO_QUERY_THROW);
@@ -94,19 +85,16 @@ uno::Reference< uno::XInterface > ScNamedRangeObj::init()
 
 void ScNamedRangeObj::setUp()
 {
-nTest++;
-CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS);
 CalcUnoApiTest::setUp();
+// create a calc document
+OUString aFileURL;
+createFileURL("ScNamedRangeObj.ods", aFileURL);
+mxComponent = loadFromDesktop(aFileURL, 
"com.sun.star.sheet.SpreadsheetDocument");
 }
 
 void ScNamedRangeObj::tearDown()
 {
-if (nTest == NUMBER_OF_TESTS)
-{
-closeDocument(mxComponent);
-mxComponent.clear();
-}
-
+closeDocument(mxComponent);
 CalcUnoApiTest::tearDown();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

2018-01-30 Thread Jens Carl

 sc/qa/extras/sclabelrangesobj.cxx |   23 ---
 1 file changed, 4 insertions(+), 19 deletions(-)

New commits:
commit f8f4e9e605daf307a32531bbe8c89fd4575fea4e
Author: Jens Carl 
Date:   Tue Jan 30 18:07:25 2018 +

Remove shared mxComponent (test document) in sclabelrangesobj

Change-Id: I79fb234a55fa03cd0c45bcc22903963f2a353fe5
Reviewed-on: https://gerrit.libreoffice.org/48920
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/sc/qa/extras/sclabelrangesobj.cxx 
b/sc/qa/extras/sclabelrangesobj.cxx
index fd97e7be5261..e10554dae405 100644
--- a/sc/qa/extras/sclabelrangesobj.cxx
+++ b/sc/qa/extras/sclabelrangesobj.cxx
@@ -25,8 +25,6 @@ using namespace com::sun::star;
 
 namespace sc_apitest
 {
-#define NUMBER_OF_TESTS 2
-
 class ScLabelRangesObj : public CalcUnoApiTest, public apitest::XLabelRanges
 {
 public:
@@ -45,13 +43,9 @@ public:
 CPPUNIT_TEST_SUITE_END();
 
 private:
-static sal_Int32 nTest;
-static uno::Reference mxComponent;
+uno::Reference mxComponent;
 };
 
-sal_Int32 ScLabelRangesObj::nTest = 0;
-uno::Reference ScLabelRangesObj::mxComponent;
-
 ScLabelRangesObj::ScLabelRangesObj()
 : CalcUnoApiTest("/sc/qa/extras/testdocuments")
 {
@@ -59,10 +53,6 @@ ScLabelRangesObj::ScLabelRangesObj()
 
 uno::Reference ScLabelRangesObj::init()
 {
-// create a calc document
-if (!mxComponent.is())
-mxComponent = loadFromDesktop("private:factory/scalc");
-
 uno::Reference xDoc(mxComponent, 
uno::UNO_QUERY_THROW);
 CPPUNIT_ASSERT_MESSAGE("no calc document", xDoc.is());
 
@@ -79,19 +69,14 @@ uno::Reference ScLabelRangesObj::init()
 
 void ScLabelRangesObj::setUp()
 {
-nTest++;
-CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS);
 CalcUnoApiTest::setUp();
+// create a calc document
+mxComponent = loadFromDesktop("private:factory/scalc");
 }
 
 void ScLabelRangesObj::tearDown()
 {
-if (nTest == NUMBER_OF_TESTS)
-{
-closeDocument(mxComponent);
-mxComponent.clear();
-}
-
+closeDocument(mxComponent);
 CalcUnoApiTest::tearDown();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115318] New: Image and chart captions outside frame

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115318

Bug ID: 115318
   Summary: Image and chart captions outside frame
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: andis.lazd...@gmail.com

By default Captions to images and charts are inserted in additional frame,
which is different from captions for tables and all kind of captions in
Microsoft office and other office suites. It would be more convenient if all
cations by default would not create additional frames. There are excellent
options for paragraph and character formatting to keep captions in certain
positions.

It was already discussed some 12-15 years ago and there is excellent
workaround, but for unexperienced users, particularly for those used to
Microsoft office, it would be much more comfortable to have captions outside
frames. Additional frame for caption is also inconvenient if document is
exported to doc or docx (like the most of the Writer documents, I guess). Users
of Microsoft office don't know that it is great tradition to have those frames
and they might become a bit angry during deleting of frames.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - sw/source

2018-01-30 Thread Don Lewis

 sw/source/filter/ww8/ww8scan.cxx |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 399cb9a456bc7d0da10b3b61d17ebf4460f7fc3c
Author: Don Lewis 
Date:   Tue Jan 30 20:10:07 2018 +

Be slightly less tricky and change

do {
} while (!this);
to
do {
} while (0);

Computing !this must be done at runtime, whereas the intent is for
the loop to exit after the first iteration, which can be handled at
compile time when using a constant zero.  Also, "this" should always
be non-NULL in valid c++ code, but if ever happened to be NULL, then
this code could loop forever.

While here, translate nearby comments.

diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index f2f1391592b3..679b735ebc9e 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -6197,12 +6197,12 @@ WW8Style::WW8Style(SvStream& rStream, WW8Fib& rFibPara)
 if ( 20 > nRead ) break;
 rSt >> ftcBi;
 
-// ggfs. den Rest ueberlesen
+// ggfs. Check the rest
 if( 20 < nRead )
 rSt.SeekRel( nRead-20 );
 }
-while( !this ); // Trick: obiger Block wird genau einmal durchlaufen
-//   und kann vorzeitig per "break" verlassen werden.
+while( 0 ); // Trick: The above block is run through exactly once
+// and can be prematurely left by "break".
 
 if( 0 != rSt.GetError() )
 {
@@ -6255,19 +6255,19 @@ WW8_STD* WW8Style::Read1STDFixed( short& rSkip, short* 
pcbStd )
 if( 8 > nRead ) break;
 rSt >> pStd->bchUpe;
 
-// ab Ver8 sollten diese beiden Felder dazukommen:
+// from Ver8 these two fields should be added
 if(10 > nRead ) break;
 rSt >> a16Bit;
 pStd->fAutoRedef =   a16Bit & 0x0001   ;
 pStd->fHidden= ( a16Bit & 0x0002 ) >> 1;
 
-// man kann nie wissen: vorsichtshalber ueberlesen
-// wir eventuelle Fuellsel, die noch zum BASE-Part gehoeren...
+// you never know: as a precaution, we read over any
+// filler that still belongs to the BASE part...
 if( 10 < nRead )
 rSt.SeekRel( nRead-10 );
 }
-while( !this ); // Trick: obiger Block wird genau einmal durchlaufen
-//   und kann vorzeitig per "break" verlassen werden.
+while( 0 ); // Trick: above block is run through exactly once and
+// can be prematurely left by "break".
 
 if( (0 != rSt.GetError()) || !nRead )
 DELETEZ( pStd );// per NULL den Error melden
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

2018-01-30 Thread Caolán McNamara

 vcl/source/filter/jpeg/jpegc.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 1a8aedb933f6c82c84804de3e282412deb190a79
Author: Caolán McNamara 
Date:   Tue Jan 30 20:51:40 2018 +

ofz#3002 speed up cymk conversion a tad

Change-Id: Ie9e3c26b10301f4d2fa12d2cd6a221dd64001158

diff --git a/vcl/source/filter/jpeg/jpegc.cxx b/vcl/source/filter/jpeg/jpegc.cxx
index 6b4cce3607b1..98b642e13d82 100644
--- a/vcl/source/filter/jpeg/jpegc.cxx
+++ b/vcl/source/filter/jpeg/jpegc.cxx
@@ -290,6 +290,7 @@ void ReadJPEG(JpegStuff& rContext, JPEGReader* pJPEGReader, 
void* pInputStream,
 if (rContext.cinfo.out_color_space == JCS_CMYK)
 {
 // convert CMYK to RGB
+Scanline pScanline = pAccess->GetScanline(yIndex);
 for (long cmyk = 0, x = 0; cmyk < nWidth * 4; cmyk += 4, 
++x)
 {
 int color_C = 255 - rContext.pCYMKBuffer[cmyk + 0];
@@ -301,7 +302,7 @@ void ReadJPEG(JpegStuff& rContext, JPEGReader* pJPEGReader, 
void* pInputStream,
 sal_uInt8 cGreen = aRangeLimit[255L - (color_M + 
color_K)];
 sal_uInt8 cBlue = aRangeLimit[255L - (color_Y + 
color_K)];
 
-pAccess->SetPixel(yIndex, x, BitmapColor(cRed, cGreen, 
cBlue));
+pAccess->SetPixelOnData(pScanline, x, 
BitmapColor(cRed, cGreen, cBlue));
 }
 }
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 102232] FILESAVE: Crash in Confirm Format dialog when saving a file in the non-default format

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102232

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #14 from V Stuart Foote  ---
(In reply to Xisco Faulí from comment #13)

> @Alex ARNAUD, @V Stuart Foote, Do you still reproduce this issue in 5.4.4
> and the latest stable verion of nvda ?

With NVDA 2017.3 on Windows 10 Enterprise 64-bit en-US--no issues with 6.0.0.3,
nor with /a admin installs of 5.4.4.2 or 6.1.0alpha1+ master.

=> WFM

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 60251] [META] ACCESSIBILITY: Tracking Windows OS accessibility and AT issues

2018-01-30 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=60251
Bug 60251 depends on bug 102232, which changed state.

Bug 102232 Summary: FILESAVE: Crash in Confirm Format dialog when saving a file 
in the non-default format
https://bugs.documentfoundation.org/show_bug.cgi?id=102232

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

2018-01-30 Thread Jens Carl

 sc/qa/extras/sclabelrangeobj.cxx |   23 ---
 1 file changed, 4 insertions(+), 19 deletions(-)

New commits:
commit 7af7c18c11cfdb781daf6a8c4c7112d247f8c4a0
Author: Jens Carl 
Date:   Tue Jan 30 18:05:05 2018 +

Remove shared mxComponent (test document) in sclabelrangeobj

Change-Id: I5d9ab4b1ec384298334399dc2e02c3dcc6b2ca57
Reviewed-on: https://gerrit.libreoffice.org/48919
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/sc/qa/extras/sclabelrangeobj.cxx b/sc/qa/extras/sclabelrangeobj.cxx
index a0f0ed78c8f2..4cbbac83f776 100644
--- a/sc/qa/extras/sclabelrangeobj.cxx
+++ b/sc/qa/extras/sclabelrangeobj.cxx
@@ -26,8 +26,6 @@ using namespace com::sun::star;
 
 namespace sc_apitest
 {
-#define NUMBER_OF_TESTS 2
-
 class ScLabelRangeObj : public CalcUnoApiTest, public apitest::XLabelRange
 {
 public:
@@ -46,13 +44,9 @@ public:
 CPPUNIT_TEST_SUITE_END();
 
 private:
-static sal_Int32 nTest;
-static uno::Reference mxComponent;
+uno::Reference mxComponent;
 };
 
-sal_Int32 ScLabelRangeObj::nTest = 0;
-uno::Reference ScLabelRangeObj::mxComponent;
-
 ScLabelRangeObj::ScLabelRangeObj()
 : CalcUnoApiTest("/sc/qa/extras/testdocuments")
 {
@@ -60,10 +54,6 @@ ScLabelRangeObj::ScLabelRangeObj()
 
 uno::Reference ScLabelRangeObj::init()
 {
-// create a calc document
-if (!mxComponent.is())
-mxComponent = loadFromDesktop("private:factory/scalc");
-
 uno::Reference xDoc(mxComponent, 
uno::UNO_QUERY_THROW);
 CPPUNIT_ASSERT_MESSAGE("no calc document", xDoc.is());
 
@@ -82,19 +72,14 @@ uno::Reference ScLabelRangeObj::init()
 
 void ScLabelRangeObj::setUp()
 {
-nTest++;
-CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS);
 CalcUnoApiTest::setUp();
+// create calc document
+mxComponent = loadFromDesktop("private:factory/scalc");
 }
 
 void ScLabelRangeObj::tearDown()
 {
-if (nTest == NUMBER_OF_TESTS)
-{
-closeDocument(mxComponent);
-mxComponent.clear();
-}
-
+closeDocument(mxComponent);
 CalcUnoApiTest::tearDown();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: connectivity/source

2018-01-30 Thread Caolán McNamara

 connectivity/source/parse/sqlflex.l |   16 +++-
 1 file changed, 11 insertions(+), 5 deletions(-)

New commits:
commit d7f5e7e04adf607a5f82185777a2167bfde20fff
Author: Caolán McNamara 
Date:   Tue Jan 30 11:57:11 2018 +

coverity#1421119 Dereference after null check

Change-Id: Ic5002a25ed51fe72e1f36f365707101632d786e1
Reviewed-on: https://gerrit.libreoffice.org/48905
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/connectivity/source/parse/sqlflex.l 
b/connectivity/source/parse/sqlflex.l
index 5d8a59c27844..9bbf3d173b67 100644
--- a/connectivity/source/parse/sqlflex.l
+++ b/connectivity/source/parse/sqlflex.l
@@ -84,11 +84,17 @@ OSQLScanner* xxx_pGLOBAL_SQLSCAN = nullptr;
 result = (c == EOF) ? YY_NULL : (buf[0] = c, 1);\
 }
 
-#define YY_FATAL_ERROR(msg) \
-{   \
-xxx_pGLOBAL_SQLSCAN->SQLyyerror(msg);   \
-/*hack to silence -Wunused-function*/   \
-if (0) yy_fatal_error(msg); \
+// coverity[+kill]
+static void do_fatal_error(const char* msg)
+{
+xxx_pGLOBAL_SQLSCAN->SQLyyerror(msg);
+/*hack to silence -Wunused-function*/
+if (0) yy_fatal_error(msg);
+}
+
+#define YY_FATAL_ERROR(msg) \
+{   \
+do_fatal_error(msg);\
 }
 
 %}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

2018-01-30 Thread Caolán McNamara

 sc/source/core/tool/formulalogger.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c38f11918568f33400f7f774c591f76926fe2755
Author: Caolán McNamara 
Date:   Tue Jan 30 10:32:00 2018 +

ofz#5834 Null-dereference

Change-Id: If52162286c949bd8c4f283ca8669fb1a99a61b0c
Reviewed-on: https://gerrit.libreoffice.org/48897
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/core/tool/formulalogger.cxx 
b/sc/source/core/tool/formulalogger.cxx
index 3b12f09192b0..f202ac35414f 100644
--- a/sc/source/core/tool/formulalogger.cxx
+++ b/sc/source/core/tool/formulalogger.cxx
@@ -339,7 +339,7 @@ FormulaLogger::GroupScope FormulaLogger::enterGroup(
 {
 // Get the file name if available.
 const SfxObjectShell* pShell = rDoc.GetDocumentShell();
-const SfxMedium* pMedium = pShell->GetMedium();
+const SfxMedium* pMedium = pShell ? pShell->GetMedium() : nullptr;
 OUString aName;
 if (pMedium)
 aName = pMedium->GetURLObject().GetLastName();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: lotuswordpro/source

2018-01-30 Thread Caolán McNamara

 lotuswordpro/source/filter/lwpdoc.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit e27628946c9ea97429d6cebc8b5a790304c8c07f
Author: Caolán McNamara 
Date:   Tue Jan 30 10:41:29 2018 +

ofz: loop detect

Change-Id: Ie0b54686e1406c5114148f9fe9a0bacfb5b607e8
Reviewed-on: https://gerrit.libreoffice.org/48899
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/lotuswordpro/source/filter/lwpdoc.cxx 
b/lotuswordpro/source/filter/lwpdoc.cxx
index 72921cbae903..27db9a01978d 100644
--- a/lotuswordpro/source/filter/lwpdoc.cxx
+++ b/lotuswordpro/source/filter/lwpdoc.cxx
@@ -312,11 +312,15 @@ void LwpDocument::RegisterBulletStyles()
 return;
 LwpSilverBullet* pBullet = dynamic_cast
 (pBulletHead->GetHeadID().obj().get());
-while(pBullet)
+std::set aSeen;
+while (pBullet)
 {
+aSeen.insert(pBullet);
 pBullet->SetFoundry(m_pFoundry);
 pBullet->RegisterStyle();
 pBullet = dynamic_cast 
(pBullet->GetNext().obj().get());
+if (aSeen.find(pBullet) != aSeen.end())
+throw std::runtime_error("loop in conversion");
 }
 }
 /**
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: icon-themes/sifr icon-themes/sifr_dark

2018-01-30 Thread Matthias Freund

 icon-themes/sifr/cmd/32/defineprintarea.png |binary
 icon-themes/sifr/cmd/32/exportdirecttoepub.png  |binary
 icon-themes/sifr/cmd/32/freezepane.png  |binary
 icon-themes/sifr/cmd/32/mergecells.png  |binary
 icon-themes/sifr/cmd/lc_defineprintarea.png |binary
 icon-themes/sifr/cmd/lc_exportdirecttoepub.png  |binary
 icon-themes/sifr/cmd/lc_freezepane.png  |binary
 icon-themes/sifr/cmd/lc_mergecells.png  |binary
 icon-themes/sifr/cmd/sc_defineprintarea.png |binary
 icon-themes/sifr/cmd/sc_exportdirecttoepub.png  |binary
 icon-themes/sifr/cmd/sc_freezepane.png  |binary
 icon-themes/sifr/cmd/sc_mergecells.png  |binary
 icon-themes/sifr_dark/cmd/32/defineprintarea.png|binary
 icon-themes/sifr_dark/cmd/32/exportdirecttoepub.png |binary
 icon-themes/sifr_dark/cmd/32/freezepane.png |binary
 icon-themes/sifr_dark/cmd/32/mergecells.png |binary
 icon-themes/sifr_dark/cmd/32/splitcells.png |binary
 icon-themes/sifr_dark/cmd/lc_defineprintarea.png|binary
 icon-themes/sifr_dark/cmd/lc_exportdirecttoepub.png |binary
 icon-themes/sifr_dark/cmd/lc_freezepane.png |binary
 icon-themes/sifr_dark/cmd/lc_mergecells.png |binary
 icon-themes/sifr_dark/cmd/lc_splitcells.png |binary
 icon-themes/sifr_dark/cmd/sc_defineprintarea.png|binary
 icon-themes/sifr_dark/cmd/sc_exportdirecttoepub.png |binary
 icon-themes/sifr_dark/cmd/sc_freezepane.png |binary
 icon-themes/sifr_dark/cmd/sc_mergecells.png |binary
 icon-themes/sifr_dark/cmd/sc_splitcells.png |binary
 27 files changed

New commits:
commit 5e787f43dc93be087a67f72dcea1fd0ae0fff9a4
Author: Matthias Freund 
Date:   Mon Jan 29 22:43:14 2018 +0100

tdf#75256 Sifr update epub freezepane defineprintarea splitcells

Change-Id: Iba3a6675f00fe6aec6612c0348008c58f98e892a
Reviewed-on: https://gerrit.libreoffice.org/48856
Tested-by: Jenkins 
Reviewed-by: Matthias Freund 

diff --git a/icon-themes/sifr/cmd/32/defineprintarea.png 
b/icon-themes/sifr/cmd/32/defineprintarea.png
new file mode 100644
index ..02bf1c18108c
Binary files /dev/null and b/icon-themes/sifr/cmd/32/defineprintarea.png differ
diff --git a/icon-themes/sifr/cmd/32/exportdirecttoepub.png 
b/icon-themes/sifr/cmd/32/exportdirecttoepub.png
new file mode 100644
index ..86ed50bc5962
Binary files /dev/null and b/icon-themes/sifr/cmd/32/exportdirecttoepub.png 
differ
diff --git a/icon-themes/sifr/cmd/32/freezepane.png 
b/icon-themes/sifr/cmd/32/freezepane.png
new file mode 100644
index ..dfcfdd374568
Binary files /dev/null and b/icon-themes/sifr/cmd/32/freezepane.png differ
diff --git a/icon-themes/sifr/cmd/32/mergecells.png 
b/icon-themes/sifr/cmd/32/mergecells.png
new file mode 100644
index ..175d76561438
Binary files /dev/null and b/icon-themes/sifr/cmd/32/mergecells.png differ
diff --git a/icon-themes/sifr/cmd/lc_defineprintarea.png 
b/icon-themes/sifr/cmd/lc_defineprintarea.png
new file mode 100644
index ..804d31a79de8
Binary files /dev/null and b/icon-themes/sifr/cmd/lc_defineprintarea.png differ
diff --git a/icon-themes/sifr/cmd/lc_exportdirecttoepub.png 
b/icon-themes/sifr/cmd/lc_exportdirecttoepub.png
new file mode 100644
index ..323713df39b3
Binary files /dev/null and b/icon-themes/sifr/cmd/lc_exportdirecttoepub.png 
differ
diff --git a/icon-themes/sifr/cmd/lc_freezepane.png 
b/icon-themes/sifr/cmd/lc_freezepane.png
new file mode 100644
index ..be89cdf4adeb
Binary files /dev/null and b/icon-themes/sifr/cmd/lc_freezepane.png differ
diff --git a/icon-themes/sifr/cmd/lc_mergecells.png 
b/icon-themes/sifr/cmd/lc_mergecells.png
index 80279ab59aa9..320c061115b1 100644
Binary files a/icon-themes/sifr/cmd/lc_mergecells.png and 
b/icon-themes/sifr/cmd/lc_mergecells.png differ
diff --git a/icon-themes/sifr/cmd/sc_defineprintarea.png 
b/icon-themes/sifr/cmd/sc_defineprintarea.png
new file mode 100644
index ..50c2a2292064
Binary files /dev/null and b/icon-themes/sifr/cmd/sc_defineprintarea.png differ
diff --git a/icon-themes/sifr/cmd/sc_exportdirecttoepub.png 
b/icon-themes/sifr/cmd/sc_exportdirecttoepub.png
new file mode 100644
index ..991dc496f0aa
Binary files /dev/null and b/icon-themes/sifr/cmd/sc_exportdirecttoepub.png 
differ
diff --git a/icon-themes/sifr/cmd/sc_freezepane.png 
b/icon-themes/sifr/cmd/sc_freezepane.png
new file mode 100644
index ..01ea4ba4018b
Binary files /dev/null and b/icon-themes/sifr/cmd/sc_freezepane.png differ
diff --git a/icon-themes/sifr/cmd/sc_mergecells.png 
b/icon-themes/sifr/cmd/sc_mergecells.png
index 8961775d8116..15cc04f09e8d 100644
Binary files a/icon-themes/sifr/cmd/sc_mergecells.png and 
b/icon-themes/sifr/cmd/sc_mergecells.png differ
diff --git

1 2 3 4 >

1 - 100 of 350 matches

Mail list logo