[Libreoffice-commits] help.git: CustomTarget_imagelist.mk

[Stephan Bergmann]

 CustomTarget_imagelist.mk |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 76635096e9c9832d856e8eb1798ce70256f6d81b
Author: Stephan Bergmann 
Date:   Fri Feb 23 08:43:00 2018 +0100

Adapt CustomTarget_helpcontent2/source/auxiliary

...to core 906a2e4fa4e9ce231126c608e741c0c0d809157d "Always execute
pack_images.py with the right Python interpreter"

Change-Id: I7c6c9aed33222fb5b902e30a05cefe8f88c66df1

diff --git a/CustomTarget_imagelist.mk b/CustomTarget_imagelist.mk
index f0710e682..099bebe10 100644
--- a/CustomTarget_imagelist.mk
+++ b/CustomTarget_imagelist.mk
@@ -19,11 +19,12 @@ $(eval $(call 
gb_CustomTarget_register_targets,helpcontent2/source/auxiliary,\
 
 $(call 
gb_CustomTarget_get_workdir,helpcontent2/source/auxiliary)/images_helpimg.zip : 
\
$(call 
gb_CustomTarget_get_workdir,helpcontent2/source/auxiliary)/helpimg.ilst \
-   $(call 
gb_CustomTarget_get_workdir,helpcontent2/source/auxiliary)/screenshotimg.ilst
+   $(call 
gb_CustomTarget_get_workdir,helpcontent2/source/auxiliary)/screenshotimg.ilst \
+   | $(call gb_ExternalExecutable_get_dependencies,python)
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),PRL,1)
$(call gb_Helper_abbreviate_dirs, \
ILSTFILE=$(call var2file,$(shell $(gb_MKTEMP)),100,$(filter 
%.ilst,$^)) && \
-   $(PYTHON) $(SRCDIR)/solenv/bin/pack_images.py \
+   $(call gb_ExternalExecutable_get_command,python) 
$(SRCDIR)/solenv/bin/pack_images.py \
-g $(helpmedia_DIR) -m $(helpmedia_DIR) -c 
$(helpmedia_DIR) \
-l $${ILSTFILE} \
-s $< -o $@ \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Stephan Bergmann]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b9e591e7ab7eaa3ea7539ea3f778bda89177219c
Author: Stephan Bergmann 
Date:   Fri Feb 23 08:43:00 2018 +0100

Updated core
Project: help  76635096e9c9832d856e8eb1798ce70256f6d81b

Adapt CustomTarget_helpcontent2/source/auxiliary

...to core 906a2e4fa4e9ce231126c608e741c0c0d809157d "Always execute
pack_images.py with the right Python interpreter"

Change-Id: I7c6c9aed33222fb5b902e30a05cefe8f88c66df1

diff --git a/helpcontent2 b/helpcontent2
index 235783d1ed47..76635096e9c9 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 235783d1ed47620748fe297f5ff5133121fbe75e
+Subproject commit 76635096e9c9832d856e8eb1798ce70256f6d81b
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - include/vcl sc/source sd/source sw/source vcl/source

[Pranav Kant]

 include/vcl/dialog.hxx|3 +++
 sc/source/ui/unoobj/docuno.cxx|   24 ++--
 sd/source/ui/unoidl/unomodel.cxx  |   20 +++-
 sw/source/uibase/uno/unotxdoc.cxx |   19 +--
 vcl/source/window/dialog.cxx  |   26 +-
 5 files changed, 50 insertions(+), 42 deletions(-)

New commits:
commit 391660de4125da06775f7d94ef352da3926c115f
Author: Pranav Kant 
Date:   Wed Feb 21 13:10:00 2018 +0530

lokdialog: Allow Execute()ing first, silently cancels others

We want to be able to detect which dialogs are important and need to be
converted to async while not completely disallowing them. Allow only
first instance of such dialogs being Execute()d and warn when another
such instance tries to Execute().

Change-Id: I6742784fa95d9e3f9ff87ece294126d390ae9e9e
Reviewed-on: https://gerrit.libreoffice.org/50092
Tested-by: Jenkins 
Reviewed-by: pranavk 

diff --git a/include/vcl/dialog.hxx b/include/vcl/dialog.hxx
index e2ad43bcbf48..24e0dfd7378f 100644
--- a/include/vcl/dialog.hxx
+++ b/include/vcl/dialog.hxx
@@ -48,6 +48,7 @@ private:
 std::unique_ptr mpDialogImpl;
 longmnMousePositioned;
 boolmbInExecute;
+boolmbInSyncExecute;
 boolmbInClose;
 boolmbModalMode;
 boolmbPaintComplete;
@@ -127,6 +128,8 @@ public:
 
 virtual short   Execute();
 boolIsInExecute() const { return mbInExecute; }
+// Return true when dialog is synchronously executed (calling ::Execute())
+boolIsInSyncExecute() const { return mbInSyncExecute; };
 
 virtual FactoryFunction GetUITestFactory() const override;
 
diff --git a/vcl/source/window/dialog.cxx b/vcl/source/window/dialog.cxx
index 9ba5d57da2d4..2da8e08d7ebc 100644
--- a/vcl/source/window/dialog.cxx
+++ b/vcl/source/window/dialog.cxx
@@ -23,6 +23,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -803,13 +804,26 @@ bool Dialog::ImplStartExecuteModal()
 return false;
 }
 
+ImplSVData* pSVData = ImplGetSVData();
+
 switch ( Application::GetDialogCancelMode() )
 {
 case Application::DialogCancelMode::Off:
 break;
 case Application::DialogCancelMode::Silent:
 if (GetLOKNotifier())
-break;
+{
+// check if there's already some dialog being ::Execute()d
+const bool bDialogExecuting = 
std::any_of(pSVData->maWinData.mpExecuteDialogs.begin(),
+  
pSVData->maWinData.mpExecuteDialogs.end(),
+  [](const Dialog* 
pDialog) {
+  return 
pDialog->IsInSyncExecute();
+  });
+if (!(bDialogExecuting && IsInSyncExecute()))
+break;
+else
+SAL_WARN("lok.dialog", "Dialog \"" << ImplGetDialogText(this) 
<< "\" is being synchronously executed over an existing synchronously executing 
dialog.");
+}
 
 SAL_INFO(
 "vcl",
@@ -836,9 +850,7 @@ bool Dialog::ImplStartExecuteModal()
 }
 #endif
 
-ImplSVData* pSVData = ImplGetSVData();
-
- // link all dialogs which are being executed
+// link all dialogs which are being executed
 pSVData->maWinData.mpExecuteDialogs.push_back(this);
 
 // stop capturing, in order to have control over the dialog
@@ -950,6 +962,11 @@ short Dialog::Execute()
 #if HAVE_FEATURE_DESKTOP
 VclPtr xWindow = this;
 
+mbInSyncExecute = true;
+comphelper::ScopeGuard aGuard([&]() {
+mbInSyncExecute = false;
+});
+
 if ( !ImplStartExecuteModal() )
 return 0;
 
@@ -959,7 +976,6 @@ short Dialog::Execute()
 Application::Yield();
 
 ImplEndExecuteModal();
-
 #ifdef DBG_UTIL
 assert (!mpDialogParent || !mpDialogParent->IsDisposed());
 #endif
commit 190a44fe052f034368e254d263fca21fc000d6ce
Author: Pranav Kant 
Date:   Tue Feb 20 21:39:15 2018 +0530

lok: Factor out the code for finding vcl::Window of a document

This should also help with IME input on charts

Change-Id: Ie513790a5d0c87397c39301a328a44b59d394a45
Reviewed-on: https://gerrit.libreoffice.org/50091
Tested-by: Jenkins 
Reviewed-by: pranavk 

diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx
index b64645dfe667..cd56f7c5872e 100644
--- a/sc/source/ui/unoobj/docuno.cxx
+++ b/sc/source/ui/unoobj/docuno.cxx
@@ -552,10 +552,19 @@ OUString ScModelObj::getPartHash( int nPart )
 VclPtr ScModelObj::getDocWindow()
 {
 SolarMutexGuard aGuard;
+
+// There seems to be no clear way of getting the 

[Libreoffice-commits] core.git: desktop/source desktop/unx framework/source

[Thorsten Behrens]

 desktop/source/lib/init.cxx |2 +-
 desktop/unx/source/splashx.c|2 +-
 framework/source/fwe/helper/titlehelper.cxx |2 ++
 3 files changed, 4 insertions(+), 2 deletions(-)

New commits:
commit ce43b10ccac41d352bcbf3a40e36360c3d0483c2
Author: Thorsten Behrens 
Date:   Thu Feb 22 23:52:54 2018 +0100

get headless build to work again for Linux

This makes --disable-gui option build successfully again - which
means we again run on a headless server w/o any X11 or OpenGL libs.

Change-Id: I60019af571aecdac277adbe6d34d5fff065014f9
Reviewed-on: https://gerrit.libreoffice.org/50214
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 1953b05daf70..a741d09f7a3b 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -2016,7 +2016,7 @@ static void doc_paintTile(LibreOfficeKitDocument* pThis,
 return;
 }
 
-#if defined(UNX) && !defined(MACOSX) && !defined(ENABLE_HEADLESS)
+#if defined(UNX) && !defined(MACOSX)
 
 #if defined(IOS)
 SystemGraphicsData aData;
diff --git a/desktop/unx/source/splashx.c b/desktop/unx/source/splashx.c
index 8a1064e3673c..e6bc534726ab 100644
--- a/desktop/unx/source/splashx.c
+++ b/desktop/unx/source/splashx.c
@@ -9,7 +9,7 @@
 
 #include "splashx.h"
 
-#ifdef ENABLE_QUICKSTART_LIBPNG
+#if defined(ENABLE_QUICKSTART_LIBPNG) && !defined(LIBO_HEADLESS)
 
 #include 
 #include 
diff --git a/framework/source/fwe/helper/titlehelper.cxx 
b/framework/source/fwe/helper/titlehelper.cxx
index 82ded83040f4..3d7943623753 100644
--- a/framework/source/fwe/helper/titlehelper.cxx
+++ b/framework/source/fwe/helper/titlehelper.cxx
@@ -562,8 +562,10 @@ void TitleHelper::impl_appendDebugVersion (OUStringBuffer& 
sTitle)
 OUString sVersion = ::utl::Bootstrap::getBuildIdData("development");
 sTitle.append(" [");
 sTitle.append(sVersion);
+#ifndef LIBO_HEADLESS
 if (OpenGLWrapper::isVCLOpenGLEnabled())
 sTitle.append("-GL");
+#endif
 sTitle.append("]");
 }
 #else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115952] color drop down buttons have missing icons

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115952

Telesto  changed:

   What|Removed |Added

 CC||tele...@surfxs.nl

--- Comment #2 from Telesto  ---
Probably bug 115895

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115893] LO Base Report Builder Does Not Display CLOB (memo field) Data

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115893

Alex Thurgood  changed:

   What|Removed |Added

Version|unspecified |6.0.1.1 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115893] LO Base Report Builder Does Not Display CLOB (memo field) Data

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115893

Alex Thurgood  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #4 from Alex Thurgood  ---
@Jim : 

Please provide detailed, step-by-step instructions on how to reproduce and
provide a small test database file with which to experiment.

I'm assuming that you refer to a Firebird database, as CLOB support is/was
inexistent or at the least inconsistent in the version of embedded hsqldb that
we currently use.

Please also mention:

- how you access the database : is it an embedded db (Firebird, hsqldb) or an
externally hosted db ?

- are you using any particular driver, and if so, which one ?

Setting to NEEDINFO pending requested information.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107056] Character deformed when exporting PDF containing Source Han Serif font

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107056

--- Comment #8 from Volga  ---
LibreOffice Chinese Community forum also reported that this bug looks fixed in
6.0.1.
https://www.libreofficechina.org/thread-1928-2-1.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115184] Error message with the back-up option turned on

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115184

--- Comment #3 from Buovjaga  ---
Could you try with a recent master build?
https://dev-builds.libreoffice.org/daily/master/Win-x86_64@42/current/
There was a bug fixed yesterday regarding optical media: bug 115383

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107056] Character deformed when exporting PDF containing Source Han Serif font

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107056

--- Comment #7 from Volga  ---
Created attachment 140080
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140080=edit
Output Sample 6.0.1.1

Reproduced with:

Version: 6.0.1.1 (x64)
Build ID：60bfb1526849283ce2491346ed2aa51c465abfe6
CPU 线程：4; 操作系统：Windows 10.0; UI 渲染：默认; 
区域语言：zh-CN (zh_CN); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115739] LibreOffice Writer crashes when trying to save an untitled document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115739

clalam...@gmail.com changed:

   What|Removed |Added

Version|5.4.4.2 release |5.4.5.1 release

--- Comment #8 from clalam...@gmail.com ---
Using Kubuntu 17.10. Sometime between last use on 17 Feb and attempted use on
22 Feb, all attempts to save a new file resulted in a crash and recovery. All
subsequent attempts to save again resulted in crash and recovery.

>From the command line:
$ libreoffice
Couldn't open /usr/share/kde4/config/kdebug.areas (startup)

Upon starting a new file and attempting to save it, Writer crashes with a
recovery window. All subsequent attempts to save a file result in the same
action.

Upon shutdown the command line startup note is reiterated:
Couldn't open /usr/share/kde4/config/kdebug.areas

/usr/share/kde4/config/kdebug.areas is owned by root:root with the permissions
of 644.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Inquiry about gsoc

[Manuj Vashist]

Hello,
You can start with easyHacks and look for the code pointers provided there
by mentors, if not provided you can ask on the irc for the same.
Good luck.

On 23 Feb 2018 8:03 a.m., "fady esam"  wrote:

> When i read a bug im a specific part of the project like the hacks
> required for gsoc in a specific part like (saving)
> What part of the code do i start looking for this part?
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

GSoC project ideas for improving LOs core-code / performance

[Clemens Eisserer]

Hello,

I recently read through the list of GSoC project ideas for 2018, and
what made me wonder is that most project ideas center around small-mid
new features or new functionality.

Would it be also possible to work on projects, which improve the
current implementation.
There are e.g. a few long-standing performance problem with rendering
performance on Unix platforms:

https://bugs.documentfoundation.org/show_bug.cgi?id=80659
https://bugs.documentfoundation.org/show_bug.cgi?id=87485
https://bugs.documentfoundation.org/show_bug.cgi?id=115702
https://bugs.documentfoundation.org/show_bug.cgi?id=101162
..

The X11 backend has certain issues (e.g. reading back huge images via
XGetImage), the GTK3 backend performs all rendering via software and
the OpenGL backend on Linux lacks certain features which are crucial
to achieve acceptable performance (e.g. accelerated text rendering).

Such improvements would benefit all LIbreoffice' users on Unix platforms.
Would it be possible to get an item-point for profiling and improving
this situation on the project's idea page?

Thanks & best regards, Clemens
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 115702] Optimise GTK3 rendering

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115702

--- Comment #8 from Clemens Eisserer  ---
this is not just about image rendering - all rendering with the GTK3 backend is
slow, because it is performed on an image surface and therefore can not be
hardware accelerated.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115702] Optimise GTK3 rendering

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115702

Clemens Eisserer  changed:

   What|Removed |Added

Summary|Optimise GTK3 image |Optimise GTK3 rendering
   |rendering   |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115951] Arabic alphabet page number format is not showing correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115951

--- Comment #2 from radwan hallak  ---
*note: the bug is not found in LO 5.4 version

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3-desktop' - vcl/inc vcl/osx vcl/source

[Tor Lillqvist]

 vcl/inc/salinst.hxx   |4 
 vcl/osx/salinst.cxx   |3 +++
 vcl/source/app/svmain.cxx |4 
 3 files changed, 11 insertions(+)

New commits:
commit eb9e6c87622ef5436abf75a87f4868d5d0e826a1
Author: Tor Lillqvist 
Date:   Thu Feb 22 12:40:26 2018 +0200

tdf#103690: Set up notifications only after VCL has been initialised

On some Macs, it seems that LibreOffice (or any app?) gets an
NSApplicationDidChangeScreenParametersNotification as soon as it has
started and asked for such a notification. Our handler for that
notification assumes that VCL is initialised. Thus we should not ask
for such notifications before VCL has been initialised.

I could not reproduce the reported crash with an unmodified
LibreOffice, only after inserting a sleep after the notifications had
been set up. But I am fairly sure this change fixes the problem.

Change-Id: I18d342eb7dc0c77cb7fc8623756bead65a1bd329
Reviewed-on: https://gerrit.libreoffice.org/50164
Tested-by: Jenkins 
Reviewed-by: Tor Lillqvist 
Reviewed-on: https://gerrit.libreoffice.org/50197
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 
(cherry picked from commit 42a5a054b70c7850ca47074c2d5dd249de3202b4)
Reviewed-on: https://gerrit.libreoffice.org/50209
Tested-by: Tor Lillqvist 

diff --git a/vcl/inc/salinst.hxx b/vcl/inc/salinst.hxx
index da8b6dea8412..52466ac650d7 100644
--- a/vcl/inc/salinst.hxx
+++ b/vcl/inc/salinst.hxx
@@ -196,6 +196,10 @@ void DeInitSalData();   // called from 
Application-Dtor
 
 void InitSalMain();
 
+#ifdef MACOSX
+void postInitVCLinitNSApp();
+#endif
+
 #endif // INCLUDED_VCL_INC_SALINST_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/osx/salinst.cxx b/vcl/osx/salinst.cxx
index 4cd82d66bd94..b0c89ba81856 100644
--- a/vcl/osx/salinst.cxx
+++ b/vcl/osx/salinst.cxx
@@ -150,7 +150,10 @@ static void initNSApp()
 
 // activate our delegate methods
 [NSApp setDelegate: NSApp];
+}
 
+void postInitVCLinitNSApp()
+{
 [[NSNotificationCenter defaultCenter] addObserver: NSApp
   selector: 
@selector(systemColorsChanged:)
   name: 
NSSystemColorsDidChangeNotification
diff --git a/vcl/source/app/svmain.cxx b/vcl/source/app/svmain.cxx
index 2cd613727ab4..ca1fb4f1f457 100644
--- a/vcl/source/app/svmain.cxx
+++ b/vcl/source/app/svmain.cxx
@@ -178,6 +178,10 @@ int ImplSVMain()
 
 bool bInit = isInitVCL() || InitVCL();
 
+#ifdef MACOSX
+postInitVCLinitNSApp();
+#endif
+
 if( bInit )
 {
 // call application main
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - configure.ac download.lst external/liborcus sc/source

[Kohei Yoshida]

 configure.ac  |2 +-
 download.lst  |4 ++--
 external/liborcus/UnpackedTarball_liborcus.mk |1 -
 sc/source/filter/orcus/interface.cxx  |   20 +---
 4 files changed, 16 insertions(+), 11 deletions(-)

New commits:
commit e81e8f8807e7dce62e91845a94920c91a69f7af5
Author: Kohei Yoshida 
Date:   Wed Jan 31 21:27:44 2018 -0500

Update orcus to 0.13.3 and make necessary adjustments.

This is a collection of the following:

(cherry picked from commit 20945a9a4de6684010fd5b3603595e6da543807d)
(cherry picked from commit a1c36eff089c3cd695bd78090575ca1c7677121e)
(cherry picked from commit 45a4e70484e7d90dab07a677914ada2d948b415c)

with all necessary changes to resolve conflicts & preserve correct
handling of font and cell background color imports.

Change-Id: I08eb3495adf74858bb23a84245a9923ebe2a13e2
Reviewed-on: https://gerrit.libreoffice.org/50213
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/configure.ac b/configure.ac
index 289cf2911c93..956b6ceb47f6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -8960,7 +8960,7 @@ AC_SUBST(ENABLE_FUZZERS)
 dnl ===
 dnl Orcus
 dnl ===
-libo_CHECK_SYSTEM_MODULE([orcus],[ORCUS],[liborcus-0.13 >= 0.13.0])
+libo_CHECK_SYSTEM_MODULE([orcus],[ORCUS],[liborcus-0.13 >= 0.13.3])
 if test "$with_system_orcus" != "yes"; then
 if test "$SYSTEM_BOOST" = "TRUE"; then
 # ===
diff --git a/download.lst b/download.lst
index 9c7b589c00b3..89dd6b4fde62 100644
--- a/download.lst
+++ b/download.lst
@@ -190,8 +190,8 @@ export OPENLDAP_SHA256SUM := 
cdd6cffdebcd95161a73305ec13fc7a78e9707b46ca9f84fb89
 export OPENLDAP_TARBALL := openldap-2.4.45.tgz
 export OPENSSL_SHA256SUM := 
8c6ff15ec6b319b50788f42c7abc2890c08ba5a1cdcd3810eb9092deada37b0f
 export OPENSSL_TARBALL := openssl-1.0.2m.tar.gz
-export ORCUS_SHA256SUM := 
d7041ef455bb78db66b4ba7876af1b3d0fa377b9444e3ef72ceaccd2e8400937
-export ORCUS_TARBALL := liborcus-0.13.1.tar.gz
+export ORCUS_SHA256SUM := 
62e76de1fd3101e77118732b860354121b40a87bbb1ebfeb8203477fffac16e9
+export ORCUS_TARBALL := liborcus-0.13.3.tar.gz
 export OWNCLOUD_ANDROID_LIB_SHA256SUM := 
b18b3e3ef7fae6a79b62f2bb43cc47a5346b6330f6a383dc4be34439aca5e9fb
 export OWNCLOUD_ANDROID_LIB_TARBALL := 
owncloud-android-library-0.9.4-no-binary-deps.tar.gz
 export PAGEMAKER_SHA256SUM := 
66adacd705a7d19895e08eac46d1e851332adf2e736c566bef1164e7a442519d
diff --git a/external/liborcus/UnpackedTarball_liborcus.mk 
b/external/liborcus/UnpackedTarball_liborcus.mk
index 7fadaa46b1c9..6941760cd71a 100644
--- a/external/liborcus/UnpackedTarball_liborcus.mk
+++ b/external/liborcus/UnpackedTarball_liborcus.mk
@@ -18,7 +18,6 @@ $(eval $(call 
gb_UnpackedTarball_update_autoconf_configs,liborcus))
 $(eval $(call gb_UnpackedTarball_add_patches,liborcus,\
external/liborcus/0001-workaround-a-linking-problem-on-windows.patch \
external/liborcus/rpath.patch.0 \
-   external/liborcus/silence-assert.patch \

external/liborcus/0001-protect-the-self-closing-xml-element-code-against-se.patch
 \
 ))
 
diff --git a/sc/source/filter/orcus/interface.cxx 
b/sc/source/filter/orcus/interface.cxx
index de52b861e5fc..c28954af9f84 100644
--- a/sc/source/filter/orcus/interface.cxx
+++ b/sc/source/filter/orcus/interface.cxx
@@ -839,7 +839,8 @@ void ScOrcusStyles::fill::applyToItemSet(SfxItemSet& rSet) 
const
 return;
 }
 
-rSet.Put(SvxBrushItem(maBgColor, ATTR_BACKGROUND));
+if (maPattern.equalsIgnoreAsciiCase("solid"))
+rSet.Put(SvxBrushItem(maFgColor, ATTR_BACKGROUND));
 }
 
 ScOrcusStyles::protection::protection():
@@ -1175,12 +1176,13 @@ void 
ScOrcusStyles::set_font_underline_color(orcus::spreadsheet::color_elem_t al
 maCurrentFont.maUnderlineColor = Color(alpha, red, green, blue);
 }
 
-void ScOrcusStyles::set_font_color(orcus::spreadsheet::color_elem_t alpha,
+void ScOrcusStyles::set_font_color(orcus::spreadsheet::color_elem_t /*alpha*/,
 orcus::spreadsheet::color_elem_t red,
 orcus::spreadsheet::color_elem_t green,
 orcus::spreadsheet::color_elem_t blue)
 {
-maCurrentFont.maColor = Color(alpha, red, green, blue);
+// Ignore the alpha value for now.
+maCurrentFont.maColor = Color(red, green, blue);
 maCurrentFont.mbHasFontAttr = true;
 }
 
@@ -1265,15 +1267,19 @@ void ScOrcusStyles::set_fill_pattern_type(const char* 
s, size_t n)
 maCurrentFill.mbHasFillAttr = true;
 }
 
-void ScOrcusStyles::set_fill_fg_color(orcus::spreadsheet::color_elem_t alpha, 
orcus::spreadsheet::color_elem_t red, orcus::spreadsheet::color_elem_t green, 
orcus::spreadsheet::color_elem_t blue)

[Libreoffice-commits] core.git: cui/source include/sfx2 sfx2/source

[Mike Kaganski]

 cui/source/tabpages/borderconn.cxx |7 +
 include/sfx2/controlwrapper.hxx|7 +
 include/sfx2/itemconnect.hxx   |   17 --
 sfx2/source/dialog/tabdlg.cxx  |   44 +
 4 files changed, 67 insertions(+), 8 deletions(-)

New commits:
commit b37a46fdf91dbc66f6ddc1c070aec70716d94a01
Author: Mike Kaganski 
Date:   Wed Feb 21 11:25:16 2018 +0300

tdf#115938: Properly detect shadow size control's changed state

This change makes sure that only if the shadow size edit box' text
is changed, it is converted to the size in twips. It sets wrapper's
default value on each SetControlValue, to return proper initial
size when the size text wasn't modified.

Also both ExampleSet and OutSet in SfxTabDialog's Reset handler are
processed to set relevant items back to initial value; otherwise,
as the restored item (marked as unchanged) will be absent in tab's
result set, it would not modify the old items in the two, and they
would keep previous modified values.

Change-Id: Ie4362811968c6e6cbe0f9229bd3c9b29462f5704
Reviewed-on: https://gerrit.libreoffice.org/50196
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/cui/source/tabpages/borderconn.cxx 
b/cui/source/tabpages/borderconn.cxx
index 90b6b2f1b41e..7b49f35022f1 100644
--- a/cui/source/tabpages/borderconn.cxx
+++ b/cui/source/tabpages/borderconn.cxx
@@ -230,7 +230,10 @@ SvxShadowItem ShadowControlsWrapper::GetControlValue() 
const
 SvxShadowItem aItem( GetDefaultValue() );
 if( !maPosWrp.IsControlDontKnow() )
 aItem.SetLocation( maPosWrp.GetControlValue() );
-if( !maSizeWrp.IsControlDontKnow() )
+// Default value was saved; so don't change the aItem's width if the 
control
+// has not changed its value, to avoid round-trip errors (like 
twip->cm->twip)
+// E.g., initial 100 twip will become 0.18 cm, which will return as 102 
twip
+if( !maSizeWrp.IsControlDontKnow() && maSizeWrp.IsControlValueChanged() )
 aItem.SetWidth( maSizeWrp.GetControlValue() );
 if( !maColorWrp.IsControlDontKnow() )
 aItem.SetColor( maColorWrp.GetControlValue() );
@@ -239,8 +242,10 @@ SvxShadowItem ShadowControlsWrapper::GetControlValue() 
const
 
 void ShadowControlsWrapper::SetControlValue( SvxShadowItem aItem )
 {
+SetDefaultValue(aItem);
 maPosWrp.SetControlValue( aItem.GetLocation() );
 maSizeWrp.SetControlValue( aItem.GetWidth() );
+maSizeWrp.GetControl().SaveValue();
 maColorWrp.SetControlValue( aItem.GetColor() );
 }
 
diff --git a/include/sfx2/controlwrapper.hxx b/include/sfx2/controlwrapper.hxx
index c130ae1c7328..746a0821a9a8 100644
--- a/include/sfx2/controlwrapper.hxx
+++ b/include/sfx2/controlwrapper.hxx
@@ -259,6 +259,7 @@ public:
 
 virtual ValueT  GetControlValue() const SAL_OVERRIDE;
 virtual voidSetControlValue( ValueT nValue ) SAL_OVERRIDE;
+boolIsControlValueChanged() const;
 
 private:
 FieldUnit   meUnit;
@@ -480,6 +481,12 @@ void MetricFieldWrapper< ValueT >::SetControlValue( ValueT 
nValue )
 this->GetControl().SetValue( this->GetControl().Normalize( static_cast< 
sal_Int64 >( nValue ) ), meUnit );
 }
 
+template< typename ValueT >
+bool MetricFieldWrapper< ValueT >::IsControlValueChanged() const
+{
+return this->GetControl().IsValueChangedFromSaved();
+}
+
 
 template< typename ValueT >
 ValueT ListBoxWrapper< ValueT >::GetControlValue() const
diff --git a/include/sfx2/itemconnect.hxx b/include/sfx2/itemconnect.hxx
index a14361103bce..a4a122cddaac 100644
--- a/include/sfx2/itemconnect.hxx
+++ b/include/sfx2/itemconnect.hxx
@@ -243,6 +243,7 @@ protected:
 
 ItemWrapperType maItemWrp;
 std::unique_ptr   mxCtrlWrp;
+boolmbModified;
 };
 
 
@@ -393,7 +394,8 @@ ItemControlConnection< ItemWrpT, ControlWrpT 
>::ItemControlConnection(
 sal_uInt16 nSlot, ControlWrpT* pNewCtrlWrp, ItemConnFlags nFlags ) :
 ItemConnectionBase( nFlags ),
 maItemWrp( nSlot ),
-mxCtrlWrp( pNewCtrlWrp )
+mxCtrlWrp( pNewCtrlWrp ),
+mbModified( false )
 {
 }
 
@@ -402,7 +404,8 @@ ItemControlConnection< ItemWrpT, ControlWrpT 
>::ItemControlConnection(
 sal_uInt16 nSlot, ControlType& rControl, ItemConnFlags nFlags ) :
 ItemConnectionBase( nFlags ),
 maItemWrp( nSlot ),
-mxCtrlWrp( new ControlWrpT( rControl ) )
+mxCtrlWrp( new ControlWrpT( rControl ) ),
+mbModified( false )
 {
 }
 
@@ -425,6 +428,7 @@ void ItemControlConnection< ItemWrpT, ControlWrpT >::Reset( 
const SfxItemSet* pI
 mxCtrlWrp->SetControlDontKnow( pItem == nullptr );
 if( pItem )
 mxCtrlWrp->SetControlValue( maItemWrp.GetItemValue( *pItem ) );
+mbModified = false;
 }
 
 template< typename ItemWrpT, typename ControlWrpT >
@@ -432,7 +436,6 @@ bool ItemControlConnection< ItemWrpT, 

[Libreoffice-bugs] [Bug 115940] Base locks up when exiting after adding a folder.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115940

twisterddfsl83...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from twisterddfsl83...@gmail.com ---
Bug appears to be fixed in the 6.0.1.  Haven't had it reoccur again.  Gonna
mark this as resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115943] LO Calc Doesn' t Paste Query Results From Base With Calculated Field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115943

--- Comment #2 from jimj_...@yahoo.ca ---
I'm not sure which icon you're talking about?

I found that if I use Paste Special in Calc it will import the data.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99756] The high-contrast theme does NOT work properly in tables

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99756

--- Comment #8 from Diego Ramírez  ---
The bug is still mostly there. Now, when inserting a table using the default
style, the table is displayed properly. However, when opening an existing file
with a table, or inserting one with a non-default style, the table is displayed
with that style instead of the high-contrast one.

Versión: 6.0.1.1 (x64)
Id. de compilación: 60bfb1526849283ce2491346ed2aa51c465abfe6
Subprocs. CPU: 4; SO: Windows 10.0; Repres. IU: predet.; 
Configuración regional: es-ES-u-co-trad (es_ES); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112314] Typing accented/special characters doesn' t work in LO Online in OSX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112314

--- Comment #3 from Aron Budea  ---
Works in formula bar (browser text field), but not in native LO editors, ie.
cells or text input in Writer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115812] no interpunct in libreoffice online

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115812

Aron Budea  changed:

   What|Removed |Added

   Keywords|topicUI |
 Status|UNCONFIRMED |NEW
 CC||ba...@caesar.elte.hu
 Ever confirmed|0   |1
 OS|Linux (All) |Mac OS X (All)

--- Comment #1 from Aron Budea  ---
Seems that it doesn't work in LO's own editors, but it works in normal text
fields, ie. in the formula bar.

Since you specifically mentioned macOS, adjusting OS to that.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115956] Add function to import MathML formula from clipboard

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115956

--- Comment #1 from Volga  ---
On this editor if I input a quadratic formula ax² + bx + c =0, while I click
Copy button, paste to here, it will become the following MathML code:
http://www.w3.org/1998/Math/MathML;>ax2+bx+c=0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112316] Suggested word is persistent in LO Online' s formula bar in OSX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112316

--- Comment #1 from Aron Budea  ---
This seems to be much better now, however it only works in formula bar, and not
in a cell.

Additionally, if you type a typoed word, eg. "tset" in the formula bar, and
correct it to test, it gets in IME mode, but any further typing resumes normal
typing, so getting in IME mode is unnecessary.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115956] New: Add function to import MathML formula from clipboard

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115956

Bug ID: 115956
   Summary: Add function to import MathML formula from clipboard
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Formula Editor
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: shanshandehongx...@outlook.com

Description:
An online editer WIRIS Editor (http://www.wiris.com/en/editor) has an ability
to produce mathmatical formula from web page, and copying as MathML format.
Thus if a formula is copying as MathML format, LibO Math can be allowed to
import it from clipboard.

Steps to Reproduce:
-

Actual Results:  
-

Expected Results:
-


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Android 5.1.1; Mobile; rv:58.0) Gecko/58.0
Firefox/58.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115955] When using tab to navigate the Sidebar, Cell Style is updated without confirmation to screen reader.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115955

am_dxer  changed:

   What|Removed |Added

 Blocks||101912


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101912
[Bug 101912] [META] Accessibility (a11y) bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115955] New: When using tab to navigate the Sidebar, Cell Style is updated without confirmation to screen reader.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115955

Bug ID: 115955
   Summary: When using tab to navigate the Sidebar, Cell Style is
updated without confirmation to screen reader.
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: am_d...@fastmail.fm

Description:
When I press the tab key to navigate the sidebar, a cell style is applied but
nothing is spoken to give the user context of what is occurring.

Steps to Reproduce:
1. After oepning a spreadsheet, press Shift=f6 to access the sidebar.
2. Start Pressing Tab. Orca on Linux will read Update, New and then Nothing if
the tab key is pressed three times. NVDA on Windows is silent no matter how
many times the Tab key is pressed.
3. If we now visit the Edit menu, we see the option to Undo editing the cell
style.

Actual Results:  
Screen Readers do not announce anything about the cell style being edited.

Expected Results:
libreOffice should expose this information so that it can be spoken by readers.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 6.1.0.0.alpha0+
Build ID: 8d4d2bf5405ef9d4b0b126f96f882f01031defd6
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); Calc: group


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
Firefox/60.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101912

am_dxer  changed:

   What|Removed |Added

 Depends on||115955


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115955
[Bug 115955] When using tab to navigate the Sidebar, Cell Style is updated
without confirmation to screen reader.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101912

am_dxer  changed:

   What|Removed |Added

 Depends on||115954


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115954
[Bug 115954] Version Field in Abot Dialog not keyboard Focusable
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115954] Version Field in Abot Dialog not keyboard Focusable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115954

am_dxer  changed:

   What|Removed |Added

 Blocks||101912


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101912
[Bug 101912] [META] Accessibility (a11y) bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115954] New: Version Field in Abot Dialog not keyboard Focusable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115954

Bug ID: 115954
   Summary: Version Field in Abot Dialog not keyboard Focusable
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: am_d...@fastmail.fm

Description:
It is not possible to tab to the edit box that contains information about the
currently running version of LibreOffice. This makes it difficult for keyboard
only users to copy and paste this information.

Steps to Reproduce:
1. Go to the help menu
2. Select About
3. Tab through the controls.

Actual Results:  
Focus did not land in the edit box.

Expected Results:
Tab should have placed focus in this edit box.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 6.1.0.0.alpha0+
Build ID: 8d4d2bf5405ef9d4b0b126f96f882f01031defd6
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); Calc: group


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
Firefox/60.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115951] Arabic alphabet page number format is not showing correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115951

--- Comment #1 from radwan hallak  ---
Created attachment 140079
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140079=edit
video shoing the bug :(

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101912

am_dxer  changed:

   What|Removed |Added

 Depends on||115953


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115953
[Bug 115953] Keyboard shortcuts not spoken by Orca on Linux for Bullet and
Number Lists in Styles Menu
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115953] Keyboard shortcuts not spoken by Orca on Linux for Bullet and Number Lists in Styles Menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115953

am_dxer  changed:

   What|Removed |Added

 Blocks||101912


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101912
[Bug 101912] [META] Accessibility (a11y) bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115953] New: Keyboard shortcuts not spoken by Orca on Linux for Bullet and Number Lists in Styles Menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115953

Bug ID: 115953
   Summary: Keyboard shortcuts not spoken by Orca on Linux for
Bullet and Number Lists in Styles Menu
   Product: LibreOffice
   Version: 6.0.1.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: am_d...@fastmail.fm

Description:
When pressing the down arrow to navigate the Styles menu, the keyboard
shortcuts F12 and Shift+f12 which are used for a bullet list and a number list
are not spoken by the screen reader.

Steps to Reproduce:
1. Press F10 to open the menu.
2. Press Right arrow to reach the Styles menu.
3. Press Down arrow until the Cursor reaches Number list and Bullet List

Actual Results:  
Orca did not speak the keyboard shortcuts

Expected Results:
Orca should speak the keyboard shortcuts.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 6.0.1.1
Build ID: 6.0.1-1
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); Calc: group


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
Firefox/60.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115952] color drop down buttons have missing icons

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115952

--- Comment #1 from Gabriel Diosan  ---
Created attachment 140078
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140078=edit
Screenshot showing missing or not visible icon for color dropdown buttons

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115952] New: color drop down buttons have missing icons

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115952

Bug ID: 115952
   Summary: color drop down buttons have missing icons
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: trivial
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gabs...@gmail.com

Description:
The following dropdowns seem to have a white icon on white background:

- Font color
- Highlight color
- Background color
- Border color
- Fill color
- Line color

Tested with the following icon themes:

- Tango
- Elementary
- Breeze

When using LibreOffice 6.0.1 that is packaged with Ubuntu 18.04, the dropdown
color icons are visible.

Steps to Reproduce:
1. Open LibreOffice Writer, Calc, Draw or Impress
2. Observe the color dropdown buttons

Actual Results:  
The color dropdown buttons seem to have a white icon (or missing icon) on a
white background.

Expected Results:
The color dropdown buttons should display an icon.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Operating System:

System:Kernel: 4.15.0-10-generic x86_64
   bits: 64 gcc: 7.3.0
   Desktop: Gnome 3.26.2 (Gtk 3.22.28-1ubuntu3)
   Distro: Ubuntu Bionic Beaver (development branch)
Machine:   Device: desktop System: Gigabyte product: AB350M-D3H serial: N/A
   Mobo: Gigabyte model: AB350M-D3H-CF serial: N/A
   UEFI [Legacy]: American Megatrends v: F2 date: 04/07/2017
CPU:   6 core AMD Ryzen 5 1600 Six-Core (-MT-MCP-) 
   arch: Zen rev.1 cache: 3072 KB

   flags: (lm nx sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3 svm) bmips:
38329
   clock speeds: max: 3200 MHz 1: 1357 MHz 2: 1356 MHz 3: 3481 MHz
   4: 3647 MHz 5: 1356 MHz 6: 1356 MHz 7: 1356 MHz 8: 1356 MHz
   9: 1356 MHz 10: 1357 MHz 11: 3474 MHz 12: 3507 MHz
Graphics:  Card: Advanced Micro Devices [AMD/ATI] Ellesmere [Radeon RX 470/480]
   bus-ID: 09:00.0
   Display Server: x11 (X.Org 1.19.6 ) driver: amdgpu
   Resolution: 1920x1200@59.95hz
   OpenGL: renderer: AMD Radeon RX 470 Graphics (POLARIS10 / DRM 3.23.0
/ 4.15.0-10-generic, LLVM 5.0.1)
   version: 4.5 Mesa 18.0.0-rc4 Direct Render: Yes

LibreOffice Version:

Version: 6.1.0.0.alpha0+
Build ID: 0a46237093c1750ee69ddb6a365098dc1d06b758
CPU threads: 12; OS: Linux 4.15; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2018-02-21_21:56:55
Locale: en-AU (en_AU.UTF-8); Calc: group


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:58.0) Gecko/20100101
Firefox/58.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

GSoC Proposal

[Ekansh Jha]

Hello Community,

I am a 3rd-year undergraduate student, in the Department of Mathematics
pursuing Integrated M.Sc. in Applied Mathematics from Indian Institute of
Technology–Roorkee (IITR). I am keenly interested in contributing to
libreoffice as a part of GSoC.

I am familliar with the language C++ that is widely used in core,
additionally I have also worked with Java and python which might be helpful
to accomplish the project.

I would like to work on Improve VML import :
https://wiki.documentfoundation.org/Development/GSoC/Ideas#Improve_VML_import,
It would be really great if I can get help to start for a proposal.

I have been active in community since last October and would like to
contribute in the future as well.
To further explore, I tried my hands on different kinds of bugs :
https://gerrit.libreoffice.org/#/q/ekansh, Please have a look into my
gerrit submissions.

I currently use Ubuntu 16.04 GNU/Linux as my primary development platform.
The configurations of my machine are sufficient to efficiently build
libreoffice and multitask for long hours.

With Best Regards,
Ekansh Jha

‌
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Inquiry about gsoc

[fady esam]

When i read a bug im a specific part of the project like the hacks required
for gsoc in a specific part like (saving)
What part of the code do i start looking for this part?
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 107060] [META] Pivot chart issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107060
Bug 107060 depends on bug 112528, which changed state.

Bug 112528 Summary: Can't make chart with specific information in a dynamic 
table
https://bugs.documentfoundation.org/show_bug.cgi?id=112528

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|WONTFIX |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112528] Can't make chart with specific information in a dynamic table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112528

Aron Budea  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 CC||ba...@caesar.elte.hu
 Resolution|WONTFIX |---

--- Comment #11 from Aron Budea  ---
I assume this bug is still there, so the bug report should be kept open.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/inc

[Markus Mohrhard]

 sc/inc/bitmaps.hlst |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fecc5d4a4423938de6d07dd57e6a98160bf91f3e
Author: Markus Mohrhard 
Date:   Fri Feb 23 02:19:47 2018 +0100

fix crash while trying to access icon set image file

Change-Id: Iaad9b5aeb4163a5262bcaf0a414ee30fd9279a49
Reviewed-on: https://gerrit.libreoffice.org/50219
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/sc/inc/bitmaps.hlst b/sc/inc/bitmaps.hlst
index c87a47b000e7..254cd2db2d8e 100644
--- a/sc/inc/bitmaps.hlst
+++ b/sc/inc/bitmaps.hlst
@@ -96,7 +96,7 @@
 #define BMP_ICON_SET_PIES_THREE_QUARTER 
"sc/res/icon-set-pies-three-quarters.png"
 #define BMP_ICON_SET_PIES_FULL  "sc/res/icon-set-pies-full.png"
 #define BMP_ICON_SET_SHAPES_CIRCLE  
"sc/res/icon-set-shapes-circle.png"
-#define BMP_ICON_SET_SHAPES_TRIANGLE
"sc/res/icon-set-shapes-triangle"
+#define BMP_ICON_SET_SHAPES_TRIANGLE
"sc/res/icon-set-shapes-triangle.png"
 #define BMP_ICON_SET_SHAPES_DIAMOND 
"sc/res/icon-set-shapes-diamond.png"
 #define BMP_ICON_SET_SQUARES_EMPTY  
"sc/res/icon-set-squares-empty.png"
 #define BMP_ICON_SET_SQUARES_ONE_QUARTER
"sc/res/icon-set-squares-one-quarter.png"
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115951] New: Arabic alphabet page number format is not showing correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115951

Bug ID: 115951
   Summary: Arabic alphabet page number format is not showing
correctly
   Product: LibreOffice
   Version: 6.0.1.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rdwan.h...@gmail.com

Description:
when i insert page number and try to change its format to Arabic alphabet (أ -
ب - ج) the page number changed to alphabet of another language (sorry i do not
know its name), so this bug begin in LO 6.0 and still until now.

Steps to Reproduce:
1.from insert select page number
2. Double-click directly in the page number, You will see the Edit Fields
dialog
3. select the Arabic alphabet from the format section, like (أ-ب-ج) or (أ-ب-ت)

Actual Results:  
writer showing the different language alphabet that what i want.

Expected Results:
showing page number in Arabic alphabet 


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 6.0.1.1
Build ID: 1:6.0.1~rc1-0ubuntu0.16.04.1~lo1
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk2; 
Locale: ar-SY (en_US.UTF-8); Calc: group


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:58.0) Gecko/20100101
Firefox/58.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: icon-themes/galaxy

[Markus Mohrhard]

 icon-themes/galaxy/sc/res/icon-set-circles2-light-red.png |binary
 1 file changed

New commits:
commit f5eb32c635a07f6977b8e613ac8732242e8682e7
Author: Markus Mohrhard 
Date:   Fri Feb 23 02:36:14 2018 +0100

fix incorrect icon set size

Change-Id: Iadd08f5a95121cc2c5e6ac0d5719bdfa07b5c95a
Reviewed-on: https://gerrit.libreoffice.org/50220
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/icon-themes/galaxy/sc/res/icon-set-circles2-light-red.png 
b/icon-themes/galaxy/sc/res/icon-set-circles2-light-red.png
index 50f7e818d8bb..13c306e7f348 100644
Binary files a/icon-themes/galaxy/sc/res/icon-set-circles2-light-red.png and 
b/icon-themes/galaxy/sc/res/icon-set-circles2-light-red.png differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115950] EDITING: segfault while selecting cell format with double-click

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115950

Terrence Enger  changed:

   What|Removed |Added

   Keywords||bibisected, haveBacktrace,
   ||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115950] EDITING: segfault while selecting cell format with double-click

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115950

--- Comment #2 from Terrence Enger  ---
Created attachment 140077
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140077=edit
tail of bibisect output

Working on debian-buster in daily Linux dbgutil bibisect repository, I
see that the segfault entered LibreOffice somewhere in the 86 or so
source commits:


  commitdates-h
    --  
good  fad94b74  2018-01-15  7a6df88f
bad   9c7e1cf4  2018-01-16  3b773d5b

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115950] EDITING: segfault while selecting cell format with double-click

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115950

--- Comment #1 from Terrence Enger  ---
Created attachment 140076
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140076=edit
log file from gdb

Possible points of interest:

line  what
  --
   1  info threads
   8  backtrace full
  94  thread apply all backtrace

The attachment is from local build of commit 1d7f96a3 (2018-02-22
11:52 UTC) built and running on debian-buster.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115950] New: EDITING: segfault while selecting cell format with double-click

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115950

Bug ID: 115950
   Summary: EDITING: segfault while selecting cell format with
double-click
   Product: LibreOffice
   Version: 6.0.0.0.alpha0+
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lo_b...@iseries-guru.com

STR
---
(1) Run Calc.  Program presents Calc window "Untitled 1".

(2) Take menu options Format > Cell.  Program presents dialog Format
Cells.

(3) Click on tab Numbers.  Program displays tab numbers with catagory
Number and format General selected.

(4) Double-click format General.  Program segfaults.

I first saw this in daily Linux dbgutil bibisect repository version
2018-02-21 runningo on debian-buster.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 115817] Removal or disabling of the Navigation toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

--- Comment #3 from V Stuart Foote  ---
(In reply to Heiko Tietze from comment #2)
> Jay was right, we better have an extra ticket for the UX issue. 

Sorry I should also have included link to the navmgr.hxx.

Here is Maja's original description of the navigation history. When originaly
implemented the function tracked SwPosition--but Michael S. changed that to use
SwUnoCrsr (unocrsr.hxx) for more robust behavior [1]:

class SW_DLLPUBLIC SwNavigationMgr
{
private:
/*
* List of entries in the navigation history
* Each entry is a SwPosition, which represents a position within the document
* SwPosition is given by a node index (SwNodeIndex) which usually represents
the paragraph the position is in
* and an index (SwIndex), which represents the position inside this paragraph.
* You can find more on SwPositions at
http://wiki.services.openoffice.org/wiki/Writer_Core_And_Layout
*
* The navigation history behaves as a stack, to which items are added when we
jump to a new position
* (e.g. click a link, or double click an entry from the navigator).
* Every use of the back/forward buttons results in moving the stack pointer
within the navigation history
*/

So, it seems the Navigation toolbar is a dedicated shell for Writer that tracks
movement through the UI and permits "back" button navigation of its stack with
some concept of "curency" of position in the history of movements. Provides a
helper in addition to other Navigator's by "mode" provided movements. 

For example the "reminder" mode (the Paper clip icon) keeps a separate stack of
Marks (to depth of MAX_MARKS default of 5)--but the NavigationMgr
m_aNavigationMgr receives and follows these swUnoCursr objects on its stack.
The modes provided in Navigator are specific for each flavor of events. 

IIUC the NavigationMgr exposes the movement events (that it is aware of)
[2]--and implements a toolbar with Back/Forward button controls to move among
all of them.

I think the buttons from the toolbar probably ought to have been added to the
Navigator from the beginning. The Navigator's current Previous/Next buttons
apply to the active Navigator mode--while the Navigation buttons draw events
from across the UI.  Is there a spot on the Navigator UI the more general
movements from the Navigation toolbar would make sense?

Likewise I think some of the movements in the sw UI ought to be exposed to the
Navigation toolbar's buttons but aren't--position to Top of document, End of
document, next Paragraph, next page, etc. This may need some additional dev
effort to 

Also, seems the same ability to navigate between cursor positions in the other
LO modules by Back/Forward button action would be a good enhancement if this is
the right framework to hang it off of.


=-ref-=
[1]
https://opengrok.libreoffice.org/xref/core/sw/source/uibase/inc/navmgr.hxx?#24
[2]
https://opengrok.libreoffice.org/xref/core/sw/source/uibase/inc/wrtsh.hxx?#461

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

--- Comment #3 from V Stuart Foote  ---
(In reply to Heiko Tietze from comment #2)
> Jay was right, we better have an extra ticket for the UX issue. 

Sorry I should also have included link to the navmgr.hxx.

Here is Maja's original description of the navigation history. When originaly
implemented the function tracked SwPosition--but Michael S. changed that to use
SwUnoCrsr (unocrsr.hxx) for more robust behavior [1]:

class SW_DLLPUBLIC SwNavigationMgr
{
private:
/*
* List of entries in the navigation history
* Each entry is a SwPosition, which represents a position within the document
* SwPosition is given by a node index (SwNodeIndex) which usually represents
the paragraph the position is in
* and an index (SwIndex), which represents the position inside this paragraph.
* You can find more on SwPositions at
http://wiki.services.openoffice.org/wiki/Writer_Core_And_Layout
*
* The navigation history behaves as a stack, to which items are added when we
jump to a new position
* (e.g. click a link, or double click an entry from the navigator).
* Every use of the back/forward buttons results in moving the stack pointer
within the navigation history
*/

So, it seems the Navigation toolbar is a dedicated shell for Writer that tracks
movement through the UI and permits "back" button navigation of its stack with
some concept of "curency" of position in the history of movements. Provides a
helper in addition to other Navigator's by "mode" provided movements. 

For example the "reminder" mode (the Paper clip icon) keeps a separate stack of
Marks (to depth of MAX_MARKS default of 5)--but the NavigationMgr
m_aNavigationMgr receives and follows these swUnoCursr objects on its stack.
The modes provided in Navigator are specific for each flavor of events. 

IIUC the NavigationMgr exposes the movement events (that it is aware of)
[2]--and implements a toolbar with Back/Forward button controls to move among
all of them.

I think the buttons from the toolbar probably ought to have been added to the
Navigator from the beginning. The Navigator's current Previous/Next buttons
apply to the active Navigator mode--while the Navigation buttons draw events
from across the UI.  Is there a spot on the Navigator UI the more general
movements from the Navigation toolbar would make sense?

Likewise I think some of the movements in the sw UI ought to be exposed to the
Navigation toolbar's buttons but aren't--position to Top of document, End of
document, next Paragraph, next page, etc. This may need some additional dev
effort to 

Also, seems the same ability to navigate between cursor positions in the other
LO modules by Back/Forward button action would be a good enhancement if this is
the right framework to hang it off of.


=-ref-=
[1]
https://opengrok.libreoffice.org/xref/core/sw/source/uibase/inc/navmgr.hxx?#24
[2]
https://opengrok.libreoffice.org/xref/core/sw/source/uibase/inc/wrtsh.hxx?#461

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115943] LO Calc Doesn' t Paste Query Results From Base With Calculated Field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115943

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
What happens pasting with Data to text icon over the query view?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115935] PIVOT TABLE: add the option to link several tables as source on one pivot table.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115935

m.a.riosv  changed:

   What|Removed |Added

Summary|PIVOT TABLE: add the option |PIVOT TABLE: add the option
   |to link several tables at   |to link several tables as
   |source on one pivot table.  |source on one pivot table.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Status of LO embedding inside other processes windows?

[Thorsten Behrens]

Stephan Bergmann wrote:
> Most likely, yes.  That LO-in-Java-window thing is brittle at best.
>
Mmmh - so we have that working in production for a few clients, though
for Windows.

LOKit is fine, just it should be noted that ~all UI [1] and
interaction then needs to be implemented client-side.

[1] yes, there's dialog tunnelling, still that needs code to render &
interact on the client side.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ScFiltersTest::testOrcusODSStyleInterface fails with liborcus 0.13.3

[Kohei Yoshida]

On Thu, 2018-02-22 at 15:14 +0100, Rene Engelhard wrote:
> 
> I think that should be done.

Here we go.

https://gerrit.libreoffice.org/#/c/50213/

Hopefully the Jenkins builds will be all green.

Thanks,

Kohei
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 107060] [META] Pivot chart issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107060
Bug 107060 depends on bug 112528, which changed state.

Bug 112528 Summary: Can't make chart with specific information in a dynamic 
table
https://bugs.documentfoundation.org/show_bug.cgi?id=112528

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112528] Can't make chart with specific information in a dynamic table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112528

Julian  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115835] Calc - Copying Cells in a Row with Conditional formatting - Conditional formatting not copied

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115835

Markus Mohrhard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |markus.mohrhard@googlemail.
   |desktop.org |com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101912
Bug 101912 depends on bug 102060, which changed state.

Bug 102060 Summary: Modifying effect or options returns focus to slide after 
preview
https://bugs.documentfoundation.org/show_bug.cgi?id=102060

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115691] Automatic preview of custom animation throws focus out of the effects list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115691

Katarina Behrens (CIB)  changed:

   What|Removed |Added

 CC||philip...@hotmail.com

--- Comment #9 from Katarina Behrens (CIB)  ---
*** Bug 102060 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102060] Modifying effect or options returns focus to slide after preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102060

Katarina Behrens (CIB)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #6 from Katarina Behrens (CIB)  ---


*** This bug has been marked as a duplicate of bug 115691 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sysui/desktop

[Olivier Tilloy]

 sysui/desktop/apparmor/program.soffice.bin |   30 +++--
 1 file changed, 20 insertions(+), 10 deletions(-)

New commits:
commit 1ee5162cd58f61d645d72e51113fe4645e8629eb
Author: Olivier Tilloy 
Date:   Mon Jan 8 16:59:17 2018 +0100

tdf#114915 Apparmor profile update (invalid comments syntax)

The apparmor profile parser doesn't interpret # as a comment when on the 
same
line as a variable assignment. Ensure that comments are on their own line,
above the actual assignment.

Change-Id: If10bb05f11b0e9026746db2e271113f30da5cbef
Reviewed-on: https://gerrit.libreoffice.org/47605
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 
(cherry picked from commit 35ad7482af49ab80d348b619b6d420ee170d3e5d)
Reviewed-on: https://gerrit.libreoffice.org/50207
Reviewed-by: Eike Rathke 

diff --git a/sysui/desktop/apparmor/program.soffice.bin 
b/sysui/desktop/apparmor/program.soffice.bin
index 6b91d6091db8..1f3ac9ae0971 100644
--- a/sysui/desktop/apparmor/program.soffice.bin
+++ b/sysui/desktop/apparmor/program.soffice.bin
@@ -23,12 +23,18 @@
 #Some obscure ones we're excluded (mostly input)
 
 #Generic
-@{libreoffice_ext} = [tT][xX][tT]  #.txt
-@{libreoffice_ext} += {,f,F}[oO][dDtT][tTsSpPbBgGfF]  #All the open document 
format
-@{libreoffice_ext} += [xX][mMsS][lL]  #.xml and xsl
-@{libreoffice_ext} += [pP][dD][fF]  #.pdf
-@{libreoffice_ext} += [uU][oO][fFtTsSpP]  #Unified office format
-@{libreoffice_ext} += {,x,X}[hH][tT][mM]{,l,L}  #(x)htm(l)
+#.txt
+@{libreoffice_ext} = [tT][xX][tT]
+#All the open document format
+@{libreoffice_ext} += {,f,F}[oO][dDtT][tTsSpPbBgGfF]
+#.xml and xsl
+@{libreoffice_ext} += [xX][mMsS][lL]
+#.pdf
+@{libreoffice_ext} += [pP][dD][fF]
+#Unified office format
+@{libreoffice_ext} += [uU][oO][fFtTsSpP]
+#(x)htm(l)
+@{libreoffice_ext} += {,x,X}[hH][tT][mM]{,l,L}
 
 #Images
 @{libreoffice_ext} += [jJ][pP][gG]
@@ -45,15 +51,19 @@
 
 #Calc
 @{libreoffice_ext} += [xX][lL][sSwWtT]{,x,X}
-@{libreoffice_ext} += [dD][iIbB][fF]  #.dif dbf
-@{libreoffice_ext} += [cCtT][sS][vV]  #.tsv .csv
+#.dif dbf
+@{libreoffice_ext} += [dD][iIbB][fF]
+#.tsv .csv
+@{libreoffice_ext} += [cCtT][sS][vV]
 @{libreoffice_ext} += [sS][lL][kK]
 
 #Impress/Draw
 @{libreoffice_ext} += [pP][pP][tTsS]{,x,X}
 @{libreoffice_ext} += [pP][oO][tT]{,m,M}
-@{libreoffice_ext} += [sS][wW][fF]  #Flash
-@{libreoffice_ext} += [pP][sS][dD]  #Photoshop
+#Flash
+@{libreoffice_ext} += [sS][wW][fF]
+#Photoshop
+@{libreoffice_ext} += [pP][sS][dD]
 
 #Math
 @{libreoffice_ext} += [mM][mM][lL]
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114915] Apparmor profiles contain invalid comments in variable assignments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114915

--- Comment #2 from Commit Notification 
 ---
Olivier Tilloy committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1ee5162cd58f61d645d72e51113fe4645e8629eb=libreoffice-6-0

tdf#114915 Apparmor profile update (invalid comments syntax)

It will be available in 6.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114915] Apparmor profiles contain invalid comments in variable assignments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114915

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.1.0|target:6.1.0 target:6.0.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115948] Make start center optional

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115948

--- Comment #3 from Ted Lee  ---
Created attachment 140075
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140075=edit
picture of screen without start center

Here's a picture of how the top left portion of the screen would look without
the start center.  (I've added a big red L to my icon for the LibreOffice app.)
Just for illustrative purposes, I've shown it with the File menu opened.  I
think this answers the comment about "the rectangle".  There ain't one! Note
that the dock is on the left.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115866] UI Warning for CSV Export "Only the active sheet was saved" not translated

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

--- Comment #6 from Laurent BP  ---
Created attachment 140074
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140074=edit
Another not translated message: Split cells in Writer

In Writer, warning messages are neither translated:
1. Insert a table
2. Split cells as long as you get a warning message

Actual behavior:
See attached screenshot: message is in English

Expected behavior:
As UI is in French, message should also be in French.

In Basic, warning messages are correctly translated.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115902] Enable custom animation pane controls again, to pick different effect

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115902

--- Comment #4 from Thorsten Behrens (CIB)  ---
(In reply to Heiko Tietze from comment #3)
> What I mean is that you cannot "have a different effect" when none is added
> before. If an effect has been added all controls are accessible, if the list
> is empty the user have to add one.

Clarification & example - I want to assign 'motion path, five-point star'.
There's two ways currently to do that:

* add 'entrance, appear', then change the already-assigned effect to the one I
really wanted
* do the dance from above to an unrelated shape, then delete that effect, then
use the new default to assign 'motion path, five-point star' to my _actual_
shape

Before, with enabled extra controls, I could do all those tweaks _before_
assigning an effect. Note that assigning effects can _already_ trigger actions,
like splitting an outline text into sub-effects. So changing effect type before
or after is _not_ identical in all cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 115902] Enable custom animation pane controls again, to pick different effect

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115902

--- Comment #4 from Thorsten Behrens (CIB)  ---
(In reply to Heiko Tietze from comment #3)
> What I mean is that you cannot "have a different effect" when none is added
> before. If an effect has been added all controls are accessible, if the list
> is empty the user have to add one.

Clarification & example - I want to assign 'motion path, five-point star'.
There's two ways currently to do that:

* add 'entrance, appear', then change the already-assigned effect to the one I
really wanted
* do the dance from above to an unrelated shape, then delete that effect, then
use the new default to assign 'motion path, five-point star' to my _actual_
shape

Before, with enabled extra controls, I could do all those tweaks _before_
assigning an effect. Note that assigning effects can _already_ trigger actions,
like splitting an outline text into sub-effects. So changing effect type before
or after is _not_ identical in all cases.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 115933] XLSX password protected with algorithmName, hashValue, saltValue and spinCount

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115933

Eike Rathke  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---
Summary|XLSX password protected |XLSX  password
   ||protected with
   ||algorithmName, hashValue,
   ||saltValue and spinCount
 Ever confirmed|0   |1
   Severity|normal  |enhancement

--- Comment #10 from Eike Rathke  ---
This is not a duplicate, though similar or related. Bug 104250 is about the
 element, whereas this is about the  element.

This will need to support the  element with algorithmName,
hashValue, saltValue and spinCount attributes and feed those with the password
to be entered to the proper hashing/digest implementation.

Currently only the reservationPassword hash and readOnlyRecommended attributes
are supported, which are not present here. If reservationPassword hash or
readOnlyRecommended=true were present, the document would always be opened
read-only. A password dialogue unprotected write open is not implemented.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115948] Make start center optional

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115948

--- Comment #2 from Ted Lee  ---
What empty rectangle?  I'm on a Mac.  It's been a long time since I've been on
a Windows machine, so I'd forgotten you can't have a menu without a window! 
And it's been even longer since I used a unix machine, and I don't remember
what windowing system I used on it, so I don't know how your question applies
to that environment.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115949] New: Make size of start center previews (thumbnails) adjustable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115949

Bug ID: 115949
   Summary: Make size of start center previews (thumbnails)
adjustable
   Product: LibreOffice
   Version: 6.0.1.1 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tmp...@gmail.com

Provide the ability to select the size of the preview images on the right side
of the start center window.  Presumably below some size they'd be shown as
generic doc type icons rather than actual previews.  I would assume this would
be implemented as a new preference in the
LibreOffice/Preferences/LibreOffice/View window, but it could also be provided
as some feature in the start center window itself.  (If this ability is there
somewhere, I couldn't find it!)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47746] "Code folding" for Writer / section expand and collapse

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=47746

--- Comment #11 from Paul  ---
This would be a tremendous feature for working on long documents, and for
getting tangential material out of the way in any document. It doesn't seem it
would be very hard to do, and I hope it can be done soon.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115948] Make start center optional

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115948

--- Comment #1 from Mike Kaganski  ---
When the start center would be disabled, what would be in the empty rectangle
under the menu?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103690] macOS: libreoffice crash on startup, VCL thread mutex condition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103690

--- Comment #61 from Commit Notification 
 ---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=42a5a054b70c7850ca47074c2d5dd249de3202b4=libreoffice-6-0

tdf#103690: Set up notifications only after VCL has been initialised

It will be available in 6.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103690] macOS: libreoffice crash on startup, VCL thread mutex condition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103690

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.1.0|target:6.1.0 target:6.0.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - vcl/inc vcl/osx vcl/source

[Tor Lillqvist]

 vcl/inc/salinst.hxx   |4 
 vcl/osx/salinst.cxx   |3 +++
 vcl/source/app/svmain.cxx |4 
 3 files changed, 11 insertions(+)

New commits:
commit 42a5a054b70c7850ca47074c2d5dd249de3202b4
Author: Tor Lillqvist 
Date:   Thu Feb 22 12:40:26 2018 +0200

tdf#103690: Set up notifications only after VCL has been initialised

On some Macs, it seems that LibreOffice (or any app?) gets an
NSApplicationDidChangeScreenParametersNotification as soon as it has
started and asked for such a notification. Our handler for that
notification assumes that VCL is initialised. Thus we should not ask
for such notifications before VCL has been initialised.

I could not reproduce the reported crash with an unmodified
LibreOffice, only after inserting a sleep after the notifications had
been set up. But I am fairly sure this change fixes the problem.

Change-Id: I18d342eb7dc0c77cb7fc8623756bead65a1bd329
Reviewed-on: https://gerrit.libreoffice.org/50164
Tested-by: Jenkins 
Reviewed-by: Tor Lillqvist 
Reviewed-on: https://gerrit.libreoffice.org/50197
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/vcl/inc/salinst.hxx b/vcl/inc/salinst.hxx
index f33d9d4d912a..805ee035f077 100644
--- a/vcl/inc/salinst.hxx
+++ b/vcl/inc/salinst.hxx
@@ -194,6 +194,10 @@ void DeInitSalData();   // called from 
Application-Dtor
 
 void InitSalMain();
 
+#ifdef MACOSX
+void postInitVCLinitNSApp();
+#endif
+
 #endif // INCLUDED_VCL_INC_SALINST_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/osx/salinst.cxx b/vcl/osx/salinst.cxx
index 80b6fec66cc0..f3fd09cf8d44 100644
--- a/vcl/osx/salinst.cxx
+++ b/vcl/osx/salinst.cxx
@@ -157,7 +157,10 @@ static void initNSApp()
 
 // activate our delegate methods
 [NSApp setDelegate: NSApp];
+}
 
+void postInitVCLinitNSApp()
+{
 [[NSNotificationCenter defaultCenter] addObserver: NSApp
   selector: 
@selector(systemColorsChanged:)
   name: 
NSSystemColorsDidChangeNotification
diff --git a/vcl/source/app/svmain.cxx b/vcl/source/app/svmain.cxx
index e4b1468eecec..2d33836aea62 100644
--- a/vcl/source/app/svmain.cxx
+++ b/vcl/source/app/svmain.cxx
@@ -187,6 +187,10 @@ int ImplSVMain()
 
 bool bInit = isInitVCL() || InitVCL();
 
+#ifdef MACOSX
+postInitVCLinitNSApp();
+#endif
+
 if( bInit )
 {
 // call application main
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115948] New: Make start center optional

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115948

Bug ID: 115948
   Summary: Make start center optional
   Product: LibreOffice
   Version: 6.0.1.1 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tmp...@gmail.com

Provide the ability to turn off the automatic display of the start center. 
Right now it comes up whenever no document is selected.  With that change, the
Tools and Help menu should always be present, even if no document is being
displayed.  (If the automatic display has been turned off, of course the user
can always invoke the start center from the File menu item.)  Rather than new
preferences, I suppose the same functionality could be provided in the start
center window itself, but I think I'd prefer it be as a preference, presumably
in the LibreOffice/Preferences/LibreOffice/View window.  Obviously it's a
personal preference (that's why they're called that, right?) but most of the
time I find the start center an annoyance rather than a help.  I know other
apps I've used have similar functionality, but I don't like it in them either! 
As best I can tell, the only functionality you lose by turning off the start
center is to be able to delete individual items from the recents list.
(I'm assuming this applies to all OS's and hardware.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sfx2/source

[Mike Kaganski]

 sfx2/source/dialog/tabdlg.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 06f04bf84d48d6542d9b47d1e16228923de61302
Author: Mike Kaganski 
Date:   Wed Feb 21 21:45:35 2018 +0100

Simplify conditions a little

Change-Id: Iaa587f1a2d78f14b999f2e9e866db058d466493f
Reviewed-on: https://gerrit.libreoffice.org/50137
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/sfx2/source/dialog/tabdlg.cxx b/sfx2/source/dialog/tabdlg.cxx
index f6fd5f90299f..c707cccea6a8 100644
--- a/sfx2/source/dialog/tabdlg.cxx
+++ b/sfx2/source/dialog/tabdlg.cxx
@@ -776,10 +776,10 @@ short SfxTabDialog::Ok()
 
 if ( !m_pOutSet )
 {
-if ( !m_pExampleSet && m_pSet )
-m_pOutSet = m_pSet->Clone( false );  // without Items
-else if ( m_pExampleSet )
+if ( m_pExampleSet )
 m_pOutSet = new SfxItemSet( *m_pExampleSet );
+else if ( m_pSet )
+m_pOutSet = m_pSet->Clone( false );  // without Items
 }
 bool bModified = false;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115866] UI Warning for CSV Export "Only the active sheet was saved" not translated

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

--- Comment #5 from Laurent BP  ---
Created attachment 140073
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140073=edit
Warning word is missing, only 1st sentence is translated when too many rows for
XLS format

I can reproduce same bug with another warning message:
1. Go to last row # 1,048,576 with Ctrl+down arrow
2. Enter a value
3. File > Save as > sample.xls
4. Confirm XLS format

Actual behavior:
See attached file:
- no "Warning" word
- only 1st sentence is translated

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115947] New: FILESAVE: COPY: Inability to copy-to-clipboard the filename from the file-save dialogue box

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115947

Bug ID: 115947
   Summary: FILESAVE: COPY: Inability to copy-to-clipboard the
filename from the file-save dialogue box
   Product: LibreOffice
   Version: 6.0.0.3 release
  Hardware: All
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tagishsi...@gmail.com

Description:
We should be able to copy the filename of a Calc file to the clipboard, by, for
instance, File, Save As (to bring up the FileSave dialogue box) and then CTRL-A
CTRL-C in the Save As field.

Although CTRL-A works fine, CTRL-C does not copy the selected text to the
clipboard.

(The usecase for this is to capture a filename so as to use it elsewhere ...
something I often have cause to do)

Steps to Reproduce:
1. Create Calc file
2. Save calc file
3. File, Save As
4. Select some or all of the filename in the Save As field
5. CTRL-C

Actual Results:  
Selected content is NOT copied to the clipboard

Expected Results:
Selected content IS copied to the clipboard


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:58.0)
Gecko/20100101 Firefox/58.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115866] UI Warning for CSV Export "Only the active sheet was saved" not translated

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115866

--- Comment #4 from Laurent BP  ---
Bibisection of the bug in 5.4 branch:
c4160729ec120beae63d50db31dca1c6b05eef93 is the first bad commit
commit c4160729ec120beae63d50db31dca1c6b05eef93
Author: Jenkins Build User 
Date:   Thu Feb 16 13:45:05 2017 +0100

source sha:2c91fc19445bb503652e97cc8b9f9014db436c37

source sha:2c91fc19445bb503652e97cc8b9f9014db436c37

:04 04 5e1351f1a6a3f87c3140eccf2d4d18f0d698895b
412b2a9066ee625bc707d97a6b3a891043f7c3c2 M  instdir

"culprit" candidate:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=2c91fc19445bb503652e97cc8b9f9014db436c37

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115437] File Icons disappeared with 6.0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115437

--- Comment #10 from Ted Lee  ---
Did you try a safe boot (after closing all apps) and then rebooting normally? 
I don't know if that would fix your problem, but it did fix a similar problem I
had when replacing NeoOffice with LibreOffice.  The problem apparently is that
some file associations are kept in caches that don't get cleared or updated. 
Safe boot apparently clears a lot of caches.  (safe boot: press and hold shift
after the chime until the apple logo comes up.  You will probably have to log
in twice. "safe boot" or "safe mode" -- I forget which -- will be displayed in
red in the menu bar. Don't be worried:  it takes a lot longer than a normal
boot.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: offapi/com

[Tomaž Vajngerl]

 offapi/com/sun/star/drawing/GraphicObjectShape.idl |8 
 1 file changed, 8 insertions(+)

New commits:
commit 6103b6698c6bd832127e781308cd77566167fd3f
Author: Tomaž Vajngerl 
Date:   Thu Feb 22 08:09:53 2018 +0900

add some whitespace to make it more readable, no change

Change-Id: I7a08d316b5d7fc99043344b1cf7cb8e326df75ae
Reviewed-on: https://gerrit.libreoffice.org/50170
Reviewed-by: Tomaž Vajngerl 
Tested-by: Tomaž Vajngerl 

diff --git a/offapi/com/sun/star/drawing/GraphicObjectShape.idl 
b/offapi/com/sun/star/drawing/GraphicObjectShape.idl
index 3a6e8d219bd6..522d0019bd48 100644
--- a/offapi/com/sun/star/drawing/GraphicObjectShape.idl
+++ b/offapi/com/sun/star/drawing/GraphicObjectShape.idl
@@ -113,20 +113,28 @@ published service GraphicObjectShape
 
 /// Whether this shape is actually a signature line.
 [optional, property] boolean IsSignatureLine;
+
 /// The ID of the signature line, used to connect to a signature.
 [optional, property] string SignatureLineId;
+
 /// Suggested Signer, Name of the Signer
 [optional, property] string SignatureLineSuggestedSignerName;
+
 /// Suggested Signer, Line 2 (Title or additional information)
 [optional, property] string SignatureLineSuggestedSignerTitle;
+
 /// Suggested Signer Email
 [optional, property] string SignatureLineSuggestedSignerEmail;
+
 /// Signing instructions, to be shown at signing time
 [optional, property] string SignatureLineSigningInstructions;
+
 /// Whether the signing date should be shown in the shape
 [optional, property] boolean SignatureLineShowSignDate;
+
 /// Whether the user can attach a comment at signing time
 [optional, property] boolean SignatureLineCanAddComment;
+
 /** Image to be displayed when the signature line is unsigned
  *
  *  Images for signed signature lines (valid and invalid)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115945] FILESAVE PPTX Labels in chart change from white to black when saving as PPTX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115945

--- Comment #3 from Gerald Pfeifer  ---
Note: the font size went down as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115946] New: FORMATTING of RTF document with incomplete font table uses different substitution fonts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115946

Bug ID: 115946
   Summary: FORMATTING of RTF document with incomplete font table
uses different substitution fonts
   Product: LibreOffice
   Version: 5.4.5.1 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rob...@prino.org

Created attachment 140072
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140072=edit
Short file showing the problem - follow the steps in the comment box

This bug is (possibly) related to bug 115924.

The attached document contains Japanese characters encoded using "\uNNN" escape
sequences. It does not contain any fonts in its font table that contain such
characters, and as a consequence, it substitutes a font that does contain them,
in casu "MS Minchu". The result is that the document is displayed correctly in
Word.

When the document is subsequently selected in its entirety (Ctrl-A) and the
font is changed into "Courier New", nothing happens, and when the cursor is put
into the Japanese text, the font still shows as "MS Minchu".

Now repeat the procedure in Writer:

Due to the afore mentioned bug 115924, the formatting is incorrect, but

1) The substitution font here is "SimSun" (doesn't really bother us)
2) A "Ctrl-A" followed by a change of the font to "Courier New" will now also,
when the cursor is moved to the Japanese characters, show their font as
"Courier New", and this incorrect designation will survive a Save/Close/Open
sequence.

However, unlike in Word, changing the font to "Courier New" will radically
alter the formatting of the document, with the Japanese characters seeming to
change their metrics to almost those of "Courier New", but not enough to
display the table correctly. Manually changing them back to the "SimSun" font
will, if one diligently does so for all of them, (obviously) display the table
correctly again.

The same so saved (after step 2 above) document will still open correctly in
Word, and Word will again use the "MS Mincho" substitution font, ***and*** will
show that font in its font selection box.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115945] FILESAVE PPTX Labels in chart change from white to black when saving as PPTX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115945

--- Comment #2 from Gerald Pfeifer  ---
Created attachment 140071
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140071=edit
Screenshot after (saved as PPTX)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115945] FILESAVE PPTX Labels in chart change from white to black when saving as PPTX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115945

--- Comment #1 from Gerald Pfeifer  ---
Created attachment 140070
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140070=edit
Screenshot before

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115945] New: FILESAVE PPTX Labels in chart change from white to black when saving as PPTX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115945

Bug ID: 115945
   Summary: FILESAVE PPTX Labels in chart change from white to
black when saving as PPTX
   Product: LibreOffice
   Version: 6.0.1.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ger...@pfeifer.com

Created attachment 140069
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140069=edit
Sample document (in ODP)

Consider the attached document where the labels in the graph are white.

Saving this as PPTX and reopening the PPTX you'll find the color changed
to black.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 68889] FORMATTING: Font "Gill Sans MT Pro" always bold

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=68889

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|BSA |BSA target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 68889] FORMATTING: Font "Gill Sans MT Pro" always bold

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=68889

--- Comment #9 from Commit Notification 
 ---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f7733528e88a6619f82b54b59e92a9bca72c0a89

tdf#68889: Fix the weight reported by the system for the problematic font

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/quartz

[Tor Lillqvist]

 vcl/quartz/ctfonts.cxx |   11 +++
 1 file changed, 11 insertions(+)

New commits:
commit f7733528e88a6619f82b54b59e92a9bca72c0a89
Author: Tor Lillqvist 
Date:   Thu Feb 22 22:45:30 2018 +0200

tdf#68889: Fix the weight reported by the system for the problematic font

Like the previous fix for Courier Std. Let's hope there won't be a lot
of these special cases. Maybe some generic heuristic would be better.
Like if a font's GetStyleName() is "Medium", "Medium Oblique", or
"Medium Italic" then always force its weight to be WEIGHT_NORMAL?

Change-Id: I204655cd9c4e32d5cbbd68bb93c6282d23993b80

diff --git a/vcl/quartz/ctfonts.cxx b/vcl/quartz/ctfonts.cxx
index 297c4dd58941..1ac73c59a60f 100644
--- a/vcl/quartz/ctfonts.cxx
+++ b/vcl/quartz/ctfonts.cxx
@@ -394,6 +394,17 @@ FontAttributes DevFontFromCTFontDescriptor( 
CTFontDescriptorRef pFD, bool* bFont
 fWeight = 0;
 }
 
+// tdf#68889: Ditto for Gill Sans MT Pro. Here I can kinda understand it, 
maybe the
+// kCTFontWeightTrait is intended to give a subjective "optical" 
impression of how the font
+// looks, and Gill Sans MT Pro Medium is kinda heavy. But with the way 
LibreOffice uses fonts,
+// we still should think of it as being "medium" weight.
+if (rDFA.GetFamilyName() == "Gill Sans MT Pro" &&
+(rDFA.GetStyleName() == "Medium" || rDFA.GetStyleName() == "Medium 
Italic") &&
+fWeight > 0.2)
+{
+fWeight = 0;
+}
+
 if( fWeight > 0 )
 {
 nInt = rint(WEIGHT_NORMAL + fWeight * ((WEIGHT_BLACK - 
WEIGHT_NORMAL)/0.68));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Non-portable configure.ac

[Tor Lillqvist]

Perl is great.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 115941] base Record locater at the bottom of the displayed records is super small almost unreadable or useable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115941

--- Comment #3 from Aron Budea  ---
Created attachment 140068
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140068=edit
Screenshot of Table window as it opens

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115828] SQL: SHUTDOWN COMPACT fails in internal HSQLDB

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115828

--- Comment #11 from Julien Nabet  ---
I submitted a patch on gerrit to review here:
https://gerrit.libreoffice.org/#/c/50202/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/xmloff sw/inc sw/qa sw/source

[Tomaž Vajngerl]

 include/xmloff/txtparae.hxx  |1 
 sw/inc/cmdid.h   |4 +-
 sw/inc/unoprnms.hxx  |1 
 sw/qa/extras/odfexport/odfexport.cxx |5 +-
 sw/source/core/unocore/unoframe.cxx  |   61 ++-
 sw/source/core/unocore/unomap1.cxx   |2 -
 6 files changed, 10 insertions(+), 64 deletions(-)

New commits:
commit f0a14acc4ebe7f1192b195738540cd9f4e1435fa
Author: Tomaž Vajngerl 
Date:   Wed Feb 21 17:26:08 2018 +0900

sw: remove "ReplacementGraphicURL" related things

Change-Id: Ia6892e3cd84b2466ea30828e9b18310789dc1686
Reviewed-on: https://gerrit.libreoffice.org/50138
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/xmloff/txtparae.hxx b/include/xmloff/txtparae.hxx
index b9b8db588d93..35c163014a62 100644
--- a/include/xmloff/txtparae.hxx
+++ b/include/xmloff/txtparae.hxx
@@ -150,7 +150,6 @@ private:
 const OUString sGraphicFilter;
 const OUString sGraphicRotation;
 const OUString sGraphicURL;
-const OUString sReplacementGraphicURL;
 const OUString sHeight;
 const OUString sHoriOrient;
 const OUString sHoriOrientPosition;
diff --git a/sw/inc/cmdid.h b/sw/inc/cmdid.h
index 99b25ec056a8..2e048f6289a9 100644
--- a/sw/inc/cmdid.h
+++ b/sw/inc/cmdid.h
@@ -568,7 +568,7 @@
 #define FN_UNO_PARA_STYLE_CONDITIONS(FN_EXTRA2 + 100)
 #define FN_UNO_GRAPHIC  (FN_EXTRA2 + 101)
 
-#define FN_UNO_REPLACEMENT_GRAPHIC_URL  (FN_EXTRA2 + 102)
+// #define free (FN_EXTRA2 + 102)
 #define FN_UNO_CELL_ROW_SPAN(FN_EXTRA2 + 103)
 #define FN_UNO_TABLE_BORDER_DISTANCES   (FN_EXTRA2 + 104)
 #define FN_SPELL_GRAMMAR_DIALOG (FN_EXTRA2 + 105)
@@ -596,7 +596,7 @@
 #define FN_UNO_FOOTER_FIRST (FN_EXTRA2 + 119)
 #define FN_UNO_TABLE_BORDER2(FN_EXTRA2 + 120)
 
-#define FN_UNO_REPLACEMENT_GRAPHIC_U_R_L(FN_EXTRA2 + 121)
+// #define free (FN_EXTRA2 + 121)
 #define FN_UNO_HIDDEN   (FN_EXTRA2 + 122)
 #define FN_UNO_STYLE_INTEROP_GRAB_BAG   (FN_EXTRA2 + 123)
 #define FN_UNO_TABLE_TEMPLATE_NAME  (FN_EXTRA2 + 124)
diff --git a/sw/inc/unoprnms.hxx b/sw/inc/unoprnms.hxx
index e5e1f31d2464..b603a7a6be8c 100644
--- a/sw/inc/unoprnms.hxx
+++ b/sw/inc/unoprnms.hxx
@@ -828,7 +828,6 @@
 #define UNO_NAME_FOOTER_TEXT_FIRST "FooterTextFirst"
 #define UNO_NAME_INITIALS "Initials"
 #define UNO_NAME_TABLE_BORDER2 "TableBorder2"
-#define UNO_NAME_REPLACEMENT_GRAPHIC_URL "ReplacementGraphicURL"
 #define UNO_NAME_REPLACEMENT_GRAPHIC "ReplacementGraphic"
 #define UNO_NAME_HIDDEN "Hidden"
 #define UNO_NAME_DEFAULT_PAGE_MODE "DefaultPageMode"
diff --git a/sw/qa/extras/odfexport/odfexport.cxx 
b/sw/qa/extras/odfexport/odfexport.cxx
index c0ca863162c4..a602011ec992 100644
--- a/sw/qa/extras/odfexport/odfexport.cxx
+++ b/sw/qa/extras/odfexport/odfexport.cxx
@@ -1434,9 +1434,10 @@ DECLARE_ODFEXPORT_TEST(testEmbeddedPdf, 
"embedded-pdf.odt")
 {
 uno::Reference xShape = getShape(1);
 // This failed, pdf+png replacement graphics pair didn't survive an ODT 
roundtrip.
-CPPUNIT_ASSERT(!getProperty(xShape, 
"ReplacementGraphicURL").isEmpty());
+auto xReplacementGraphic = 
getProperty(xShape, "ReplacementGraphic");
+CPPUNIT_ASSERT(xReplacementGraphic.is());
 
-auto xGraphic = getProperty< uno::Reference >(xShape, 
"Graphic");
+auto xGraphic = getProperty(xShape, 
"Graphic");
 CPPUNIT_ASSERT(xGraphic.is());
 // This was image/x-vclgraphic, not exposing the info that the image is a 
PDF one.
 CPPUNIT_ASSERT_EQUAL(OUString("application/pdf"), 
getProperty(xGraphic, "MimeType"));
diff --git a/sw/source/core/unocore/unoframe.cxx 
b/sw/source/core/unocore/unoframe.cxx
index 8b3595b40af0..cb59f4ddae79 100644
--- a/sw/source/core/unocore/unoframe.cxx
+++ b/sw/source/core/unocore/unoframe.cxx
@@ -1639,41 +1639,13 @@ void SwXFrame::setPropertyValue(const OUString& 
rPropertyName, const ::uno::Any&
 }
 }
 }
-else if( FN_UNO_REPLACEMENT_GRAPHIC_URL == pEntry->nWID || 
FN_UNO_REPLACEMENT_GRAPHIC == pEntry->nWID )
+else if (FN_UNO_REPLACEMENT_GRAPHIC == pEntry->nWID)
 {
-bool bURL = FN_UNO_REPLACEMENT_GRAPHIC_URL == pEntry->nWID;
-bool bApply = false;
-Graphic aGraphic;
-if( bURL )
-{
-OUString aGrfUrl;
-aValue >>= aGrfUrl;
-
-// the package URL based graphics are handled in different way 
currently
-// TODO/LATER: actually this is the correct place to handle 
them
-OUString aGraphicProtocol( sGraphicObjectProtocol );
-if( aGrfUrl.startsWith( aGraphicProtocol ) )
-{
-OString 

[Libreoffice-bugs] [Bug 115924] FORMATTING Substituted font does not revert to original after last \uNNNN escape in RTF file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115924

--- Comment #2 from rob...@prino.org ---
The second file contains pre-massaged RTF (these files are created on z/OS
using a mixture of PL/I and REXX) that still shows the problem - ungrouped
(i.e. not enclosed in "{" and "}" white-space immediately following a group
with a different font, such as "{\f1\charscalex60
\u23431\u37117\u23470\u24066}" will ***not*** revert to the original (in casu
"\f0") font.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115924] FORMATTING Substituted font does not revert to original after last \uNNNN escape in RTF file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115924

--- Comment #1 from rob...@prino.org ---
Created attachment 140067
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140067=edit
Second file with pre-massaged RTF still showing the FORMATTING problem

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115944] Render differences of DOCX between Word and LO/AOO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115944

--- Comment #2 from jens.troe...@light-speed.de ---
Created attachment 140066
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140066=edit
Test document to reproduce the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115908] test_text_direction failures because the xTextDirectionList dropdown is not visible by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115908

Rico Tzschichholz  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs