[Libreoffice-commits] help.git: CustomTarget_imagelist.mk

[Stephan Bergmann]

 CustomTarget_imagelist.mk |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 76635096e9c9832d856e8eb1798ce70256f6d81b
Author: Stephan Bergmann 
Date:   Fri Feb 23 08:43:00 2018 +0100

Adapt CustomTarget_helpcontent2/source/auxiliary

...to core 906a2e4fa4e9ce231126c608e741c0c0d809157d "Always execute
pack_images.py with the right Python interpreter"

Change-Id: I7c6c9aed33222fb5b902e30a05cefe8f88c66df1

diff --git a/CustomTarget_imagelist.mk b/CustomTarget_imagelist.mk
index f0710e682..099bebe10 100644
--- a/CustomTarget_imagelist.mk
+++ b/CustomTarget_imagelist.mk
@@ -19,11 +19,12 @@ $(eval $(call 
gb_CustomTarget_register_targets,helpcontent2/source/auxiliary,\
 
 $(call 
gb_CustomTarget_get_workdir,helpcontent2/source/auxiliary)/images_helpimg.zip : 
\
$(call 
gb_CustomTarget_get_workdir,helpcontent2/source/auxiliary)/helpimg.ilst \
-   $(call 
gb_CustomTarget_get_workdir,helpcontent2/source/auxiliary)/screenshotimg.ilst
+   $(call 
gb_CustomTarget_get_workdir,helpcontent2/source/auxiliary)/screenshotimg.ilst \
+   | $(call gb_ExternalExecutable_get_dependencies,python)
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),PRL,1)
$(call gb_Helper_abbreviate_dirs, \
ILSTFILE=$(call var2file,$(shell $(gb_MKTEMP)),100,$(filter 
%.ilst,$^)) && \
-   $(PYTHON) $(SRCDIR)/solenv/bin/pack_images.py \
+   $(call gb_ExternalExecutable_get_command,python) 
$(SRCDIR)/solenv/bin/pack_images.py \
-g $(helpmedia_DIR) -m $(helpmedia_DIR) -c 
$(helpmedia_DIR) \
-l $${ILSTFILE} \
-s $< -o $@ \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Stephan Bergmann]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b9e591e7ab7eaa3ea7539ea3f778bda89177219c
Author: Stephan Bergmann 
Date:   Fri Feb 23 08:43:00 2018 +0100

Updated core
Project: help  76635096e9c9832d856e8eb1798ce70256f6d81b

Adapt CustomTarget_helpcontent2/source/auxiliary

...to core 906a2e4fa4e9ce231126c608e741c0c0d809157d "Always execute
pack_images.py with the right Python interpreter"

Change-Id: I7c6c9aed33222fb5b902e30a05cefe8f88c66df1

diff --git a/helpcontent2 b/helpcontent2
index 235783d1ed47..76635096e9c9 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 235783d1ed47620748fe297f5ff5133121fbe75e
+Subproject commit 76635096e9c9832d856e8eb1798ce70256f6d81b
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - include/vcl sc/source sd/source sw/source vcl/source

[Pranav Kant]

 include/vcl/dialog.hxx|3 +++
 sc/source/ui/unoobj/docuno.cxx|   24 ++--
 sd/source/ui/unoidl/unomodel.cxx  |   20 +++-
 sw/source/uibase/uno/unotxdoc.cxx |   19 +--
 vcl/source/window/dialog.cxx  |   26 +-
 5 files changed, 50 insertions(+), 42 deletions(-)

New commits:
commit 391660de4125da06775f7d94ef352da3926c115f
Author: Pranav Kant 
Date:   Wed Feb 21 13:10:00 2018 +0530

lokdialog: Allow Execute()ing first, silently cancels others

We want to be able to detect which dialogs are important and need to be
converted to async while not completely disallowing them. Allow only
first instance of such dialogs being Execute()d and warn when another
such instance tries to Execute().

Change-Id: I6742784fa95d9e3f9ff87ece294126d390ae9e9e
Reviewed-on: https://gerrit.libreoffice.org/50092
Tested-by: Jenkins 
Reviewed-by: pranavk 

diff --git a/include/vcl/dialog.hxx b/include/vcl/dialog.hxx
index e2ad43bcbf48..24e0dfd7378f 100644
--- a/include/vcl/dialog.hxx
+++ b/include/vcl/dialog.hxx
@@ -48,6 +48,7 @@ private:
 std::unique_ptr mpDialogImpl;
 longmnMousePositioned;
 boolmbInExecute;
+boolmbInSyncExecute;
 boolmbInClose;
 boolmbModalMode;
 boolmbPaintComplete;
@@ -127,6 +128,8 @@ public:
 
 virtual short   Execute();
 boolIsInExecute() const { return mbInExecute; }
+// Return true when dialog is synchronously executed (calling ::Execute())
+boolIsInSyncExecute() const { return mbInSyncExecute; };
 
 virtual FactoryFunction GetUITestFactory() const override;
 
diff --git a/vcl/source/window/dialog.cxx b/vcl/source/window/dialog.cxx
index 9ba5d57da2d4..2da8e08d7ebc 100644
--- a/vcl/source/window/dialog.cxx
+++ b/vcl/source/window/dialog.cxx
@@ -23,6 +23,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -803,13 +804,26 @@ bool Dialog::ImplStartExecuteModal()
 return false;
 }
 
+ImplSVData* pSVData = ImplGetSVData();
+
 switch ( Application::GetDialogCancelMode() )
 {
 case Application::DialogCancelMode::Off:
 break;
 case Application::DialogCancelMode::Silent:
 if (GetLOKNotifier())
-break;
+{
+// check if there's already some dialog being ::Execute()d
+const bool bDialogExecuting = 
std::any_of(pSVData->maWinData.mpExecuteDialogs.begin(),
+  
pSVData->maWinData.mpExecuteDialogs.end(),
+  [](const Dialog* 
pDialog) {
+  return 
pDialog->IsInSyncExecute();
+  });
+if (!(bDialogExecuting && IsInSyncExecute()))
+break;
+else
+SAL_WARN("lok.dialog", "Dialog \"" << ImplGetDialogText(this) 
<< "\" is being synchronously executed over an existing synchronously executing 
dialog.");
+}
 
 SAL_INFO(
 "vcl",
@@ -836,9 +850,7 @@ bool Dialog::ImplStartExecuteModal()
 }
 #endif
 
-ImplSVData* pSVData = ImplGetSVData();
-
- // link all dialogs which are being executed
+// link all dialogs which are being executed
 pSVData->maWinData.mpExecuteDialogs.push_back(this);
 
 // stop capturing, in order to have control over the dialog
@@ -950,6 +962,11 @@ short Dialog::Execute()
 #if HAVE_FEATURE_DESKTOP
 VclPtr xWindow = this;
 
+mbInSyncExecute = true;
+comphelper::ScopeGuard aGuard([&]() {
+mbInSyncExecute = false;
+});
+
 if ( !ImplStartExecuteModal() )
 return 0;
 
@@ -959,7 +976,6 @@ short Dialog::Execute()
 Application::Yield();
 
 ImplEndExecuteModal();
-
 #ifdef DBG_UTIL
 assert (!mpDialogParent || !mpDialogParent->IsDisposed());
 #endif
commit 190a44fe052f034368e254d263fca21fc000d6ce
Author: Pranav Kant 
Date:   Tue Feb 20 21:39:15 2018 +0530

lok: Factor out the code for finding vcl::Window of a document

This should also help with IME input on charts

Change-Id: Ie513790a5d0c87397c39301a328a44b59d394a45
Reviewed-on: https://gerrit.libreoffice.org/50091
Tested-by: Jenkins 
Reviewed-by: pranavk 

diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx
index b64645dfe667..cd56f7c5872e 100644
--- a/sc/source/ui/unoobj/docuno.cxx
+++ b/sc/source/ui/unoobj/docuno.cxx
@@ -552,10 +552,19 @@ OUString ScModelObj::getPartHash( int nPart )
 VclPtr ScModelObj::getDocWindow()
 {
 SolarMutexGuard aGuard;
+
+// There seems to be no clear way of getting the grid window for this
+// particular document, hence we need to hope we get the right window.
 ScViewData* pViewData = ScDocShell::GetView

[Libreoffice-commits] core.git: desktop/source desktop/unx framework/source

[Thorsten Behrens]

 desktop/source/lib/init.cxx |2 +-
 desktop/unx/source/splashx.c|2 +-
 framework/source/fwe/helper/titlehelper.cxx |2 ++
 3 files changed, 4 insertions(+), 2 deletions(-)

New commits:
commit ce43b10ccac41d352bcbf3a40e36360c3d0483c2
Author: Thorsten Behrens 
Date:   Thu Feb 22 23:52:54 2018 +0100

get headless build to work again for Linux

This makes --disable-gui option build successfully again - which
means we again run on a headless server w/o any X11 or OpenGL libs.

Change-Id: I60019af571aecdac277adbe6d34d5fff065014f9
Reviewed-on: https://gerrit.libreoffice.org/50214
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 1953b05daf70..a741d09f7a3b 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -2016,7 +2016,7 @@ static void doc_paintTile(LibreOfficeKitDocument* pThis,
 return;
 }
 
-#if defined(UNX) && !defined(MACOSX) && !defined(ENABLE_HEADLESS)
+#if defined(UNX) && !defined(MACOSX)
 
 #if defined(IOS)
 SystemGraphicsData aData;
diff --git a/desktop/unx/source/splashx.c b/desktop/unx/source/splashx.c
index 8a1064e3673c..e6bc534726ab 100644
--- a/desktop/unx/source/splashx.c
+++ b/desktop/unx/source/splashx.c
@@ -9,7 +9,7 @@
 
 #include "splashx.h"
 
-#ifdef ENABLE_QUICKSTART_LIBPNG
+#if defined(ENABLE_QUICKSTART_LIBPNG) && !defined(LIBO_HEADLESS)
 
 #include 
 #include 
diff --git a/framework/source/fwe/helper/titlehelper.cxx 
b/framework/source/fwe/helper/titlehelper.cxx
index 82ded83040f4..3d7943623753 100644
--- a/framework/source/fwe/helper/titlehelper.cxx
+++ b/framework/source/fwe/helper/titlehelper.cxx
@@ -562,8 +562,10 @@ void TitleHelper::impl_appendDebugVersion (OUStringBuffer& 
sTitle)
 OUString sVersion = ::utl::Bootstrap::getBuildIdData("development");
 sTitle.append(" [");
 sTitle.append(sVersion);
+#ifndef LIBO_HEADLESS
 if (OpenGLWrapper::isVCLOpenGLEnabled())
 sTitle.append("-GL");
+#endif
 sTitle.append("]");
 }
 #else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Inquiry about gsoc

[Manuj Vashist]

Hello,
You can start with easyHacks and look for the code pointers provided there
by mentors, if not provided you can ask on the irc for the same.
Good luck.

On 23 Feb 2018 8:03 a.m., "fady esam"  wrote:

> When i read a bug im a specific part of the project like the hacks
> required for gsoc in a specific part like (saving)
> What part of the code do i start looking for this part?
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

GSoC project ideas for improving LOs core-code / performance

[Clemens Eisserer]

Hello,

I recently read through the list of GSoC project ideas for 2018, and
what made me wonder is that most project ideas center around small-mid
new features or new functionality.

Would it be also possible to work on projects, which improve the
current implementation.
There are e.g. a few long-standing performance problem with rendering
performance on Unix platforms:

https://bugs.documentfoundation.org/show_bug.cgi?id=80659
https://bugs.documentfoundation.org/show_bug.cgi?id=87485
https://bugs.documentfoundation.org/show_bug.cgi?id=115702
https://bugs.documentfoundation.org/show_bug.cgi?id=101162
..

The X11 backend has certain issues (e.g. reading back huge images via
XGetImage), the GTK3 backend performs all rendering via software and
the OpenGL backend on Linux lacks certain features which are crucial
to achieve acceptable performance (e.g. accelerated text rendering).

Such improvements would benefit all LIbreoffice' users on Unix platforms.
Would it be possible to get an item-point for profiling and improving
this situation on the project's idea page?

Thanks & best regards, Clemens
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3-desktop' - vcl/inc vcl/osx vcl/source

[Tor Lillqvist]

 vcl/inc/salinst.hxx   |4 
 vcl/osx/salinst.cxx   |3 +++
 vcl/source/app/svmain.cxx |4 
 3 files changed, 11 insertions(+)

New commits:
commit eb9e6c87622ef5436abf75a87f4868d5d0e826a1
Author: Tor Lillqvist 
Date:   Thu Feb 22 12:40:26 2018 +0200

tdf#103690: Set up notifications only after VCL has been initialised

On some Macs, it seems that LibreOffice (or any app?) gets an
NSApplicationDidChangeScreenParametersNotification as soon as it has
started and asked for such a notification. Our handler for that
notification assumes that VCL is initialised. Thus we should not ask
for such notifications before VCL has been initialised.

I could not reproduce the reported crash with an unmodified
LibreOffice, only after inserting a sleep after the notifications had
been set up. But I am fairly sure this change fixes the problem.

Change-Id: I18d342eb7dc0c77cb7fc8623756bead65a1bd329
Reviewed-on: https://gerrit.libreoffice.org/50164
Tested-by: Jenkins 
Reviewed-by: Tor Lillqvist 
Reviewed-on: https://gerrit.libreoffice.org/50197
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 
(cherry picked from commit 42a5a054b70c7850ca47074c2d5dd249de3202b4)
Reviewed-on: https://gerrit.libreoffice.org/50209
Tested-by: Tor Lillqvist 

diff --git a/vcl/inc/salinst.hxx b/vcl/inc/salinst.hxx
index da8b6dea8412..52466ac650d7 100644
--- a/vcl/inc/salinst.hxx
+++ b/vcl/inc/salinst.hxx
@@ -196,6 +196,10 @@ void DeInitSalData();   // called from 
Application-Dtor
 
 void InitSalMain();
 
+#ifdef MACOSX
+void postInitVCLinitNSApp();
+#endif
+
 #endif // INCLUDED_VCL_INC_SALINST_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/osx/salinst.cxx b/vcl/osx/salinst.cxx
index 4cd82d66bd94..b0c89ba81856 100644
--- a/vcl/osx/salinst.cxx
+++ b/vcl/osx/salinst.cxx
@@ -150,7 +150,10 @@ static void initNSApp()
 
 // activate our delegate methods
 [NSApp setDelegate: NSApp];
+}
 
+void postInitVCLinitNSApp()
+{
 [[NSNotificationCenter defaultCenter] addObserver: NSApp
   selector: 
@selector(systemColorsChanged:)
   name: 
NSSystemColorsDidChangeNotification
diff --git a/vcl/source/app/svmain.cxx b/vcl/source/app/svmain.cxx
index 2cd613727ab4..ca1fb4f1f457 100644
--- a/vcl/source/app/svmain.cxx
+++ b/vcl/source/app/svmain.cxx
@@ -178,6 +178,10 @@ int ImplSVMain()
 
 bool bInit = isInitVCL() || InitVCL();
 
+#ifdef MACOSX
+postInitVCLinitNSApp();
+#endif
+
 if( bInit )
 {
 // call application main
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - configure.ac download.lst external/liborcus sc/source

[Kohei Yoshida]

 configure.ac  |2 +-
 download.lst  |4 ++--
 external/liborcus/UnpackedTarball_liborcus.mk |1 -
 sc/source/filter/orcus/interface.cxx  |   20 +---
 4 files changed, 16 insertions(+), 11 deletions(-)

New commits:
commit e81e8f8807e7dce62e91845a94920c91a69f7af5
Author: Kohei Yoshida 
Date:   Wed Jan 31 21:27:44 2018 -0500

Update orcus to 0.13.3 and make necessary adjustments.

This is a collection of the following:

(cherry picked from commit 20945a9a4de6684010fd5b3603595e6da543807d)
(cherry picked from commit a1c36eff089c3cd695bd78090575ca1c7677121e)
(cherry picked from commit 45a4e70484e7d90dab07a677914ada2d948b415c)

with all necessary changes to resolve conflicts & preserve correct
handling of font and cell background color imports.

Change-Id: I08eb3495adf74858bb23a84245a9923ebe2a13e2
Reviewed-on: https://gerrit.libreoffice.org/50213
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/configure.ac b/configure.ac
index 289cf2911c93..956b6ceb47f6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -8960,7 +8960,7 @@ AC_SUBST(ENABLE_FUZZERS)
 dnl ===
 dnl Orcus
 dnl ===
-libo_CHECK_SYSTEM_MODULE([orcus],[ORCUS],[liborcus-0.13 >= 0.13.0])
+libo_CHECK_SYSTEM_MODULE([orcus],[ORCUS],[liborcus-0.13 >= 0.13.3])
 if test "$with_system_orcus" != "yes"; then
 if test "$SYSTEM_BOOST" = "TRUE"; then
 # ===
diff --git a/download.lst b/download.lst
index 9c7b589c00b3..89dd6b4fde62 100644
--- a/download.lst
+++ b/download.lst
@@ -190,8 +190,8 @@ export OPENLDAP_SHA256SUM := 
cdd6cffdebcd95161a73305ec13fc7a78e9707b46ca9f84fb89
 export OPENLDAP_TARBALL := openldap-2.4.45.tgz
 export OPENSSL_SHA256SUM := 
8c6ff15ec6b319b50788f42c7abc2890c08ba5a1cdcd3810eb9092deada37b0f
 export OPENSSL_TARBALL := openssl-1.0.2m.tar.gz
-export ORCUS_SHA256SUM := 
d7041ef455bb78db66b4ba7876af1b3d0fa377b9444e3ef72ceaccd2e8400937
-export ORCUS_TARBALL := liborcus-0.13.1.tar.gz
+export ORCUS_SHA256SUM := 
62e76de1fd3101e77118732b860354121b40a87bbb1ebfeb8203477fffac16e9
+export ORCUS_TARBALL := liborcus-0.13.3.tar.gz
 export OWNCLOUD_ANDROID_LIB_SHA256SUM := 
b18b3e3ef7fae6a79b62f2bb43cc47a5346b6330f6a383dc4be34439aca5e9fb
 export OWNCLOUD_ANDROID_LIB_TARBALL := 
owncloud-android-library-0.9.4-no-binary-deps.tar.gz
 export PAGEMAKER_SHA256SUM := 
66adacd705a7d19895e08eac46d1e851332adf2e736c566bef1164e7a442519d
diff --git a/external/liborcus/UnpackedTarball_liborcus.mk 
b/external/liborcus/UnpackedTarball_liborcus.mk
index 7fadaa46b1c9..6941760cd71a 100644
--- a/external/liborcus/UnpackedTarball_liborcus.mk
+++ b/external/liborcus/UnpackedTarball_liborcus.mk
@@ -18,7 +18,6 @@ $(eval $(call 
gb_UnpackedTarball_update_autoconf_configs,liborcus))
 $(eval $(call gb_UnpackedTarball_add_patches,liborcus,\
external/liborcus/0001-workaround-a-linking-problem-on-windows.patch \
external/liborcus/rpath.patch.0 \
-   external/liborcus/silence-assert.patch \

external/liborcus/0001-protect-the-self-closing-xml-element-code-against-se.patch
 \
 ))
 
diff --git a/sc/source/filter/orcus/interface.cxx 
b/sc/source/filter/orcus/interface.cxx
index de52b861e5fc..c28954af9f84 100644
--- a/sc/source/filter/orcus/interface.cxx
+++ b/sc/source/filter/orcus/interface.cxx
@@ -839,7 +839,8 @@ void ScOrcusStyles::fill::applyToItemSet(SfxItemSet& rSet) 
const
 return;
 }
 
-rSet.Put(SvxBrushItem(maBgColor, ATTR_BACKGROUND));
+if (maPattern.equalsIgnoreAsciiCase("solid"))
+rSet.Put(SvxBrushItem(maFgColor, ATTR_BACKGROUND));
 }
 
 ScOrcusStyles::protection::protection():
@@ -1175,12 +1176,13 @@ void 
ScOrcusStyles::set_font_underline_color(orcus::spreadsheet::color_elem_t al
 maCurrentFont.maUnderlineColor = Color(alpha, red, green, blue);
 }
 
-void ScOrcusStyles::set_font_color(orcus::spreadsheet::color_elem_t alpha,
+void ScOrcusStyles::set_font_color(orcus::spreadsheet::color_elem_t /*alpha*/,
 orcus::spreadsheet::color_elem_t red,
 orcus::spreadsheet::color_elem_t green,
 orcus::spreadsheet::color_elem_t blue)
 {
-maCurrentFont.maColor = Color(alpha, red, green, blue);
+// Ignore the alpha value for now.
+maCurrentFont.maColor = Color(red, green, blue);
 maCurrentFont.mbHasFontAttr = true;
 }
 
@@ -1265,15 +1267,19 @@ void ScOrcusStyles::set_fill_pattern_type(const char* 
s, size_t n)
 maCurrentFill.mbHasFillAttr = true;
 }
 
-void ScOrcusStyles::set_fill_fg_color(orcus::spreadsheet::color_elem_t alpha, 
orcus::spreadsheet::color_elem_t red, orcus::spreadsheet::color_elem_t green, 
orcus::spreadsheet::color_elem_t blue)
+void ScOrcusStyles::set_fill_fg_color(
+orcus::spreadsheet::color_elem_t /*a

[Libreoffice-commits] core.git: cui/source include/sfx2 sfx2/source

[Mike Kaganski]

 cui/source/tabpages/borderconn.cxx |7 +
 include/sfx2/controlwrapper.hxx|7 +
 include/sfx2/itemconnect.hxx   |   17 --
 sfx2/source/dialog/tabdlg.cxx  |   44 +
 4 files changed, 67 insertions(+), 8 deletions(-)

New commits:
commit b37a46fdf91dbc66f6ddc1c070aec70716d94a01
Author: Mike Kaganski 
Date:   Wed Feb 21 11:25:16 2018 +0300

tdf#115938: Properly detect shadow size control's changed state

This change makes sure that only if the shadow size edit box' text
is changed, it is converted to the size in twips. It sets wrapper's
default value on each SetControlValue, to return proper initial
size when the size text wasn't modified.

Also both ExampleSet and OutSet in SfxTabDialog's Reset handler are
processed to set relevant items back to initial value; otherwise,
as the restored item (marked as unchanged) will be absent in tab's
result set, it would not modify the old items in the two, and they
would keep previous modified values.

Change-Id: Ie4362811968c6e6cbe0f9229bd3c9b29462f5704
Reviewed-on: https://gerrit.libreoffice.org/50196
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/cui/source/tabpages/borderconn.cxx 
b/cui/source/tabpages/borderconn.cxx
index 90b6b2f1b41e..7b49f35022f1 100644
--- a/cui/source/tabpages/borderconn.cxx
+++ b/cui/source/tabpages/borderconn.cxx
@@ -230,7 +230,10 @@ SvxShadowItem ShadowControlsWrapper::GetControlValue() 
const
 SvxShadowItem aItem( GetDefaultValue() );
 if( !maPosWrp.IsControlDontKnow() )
 aItem.SetLocation( maPosWrp.GetControlValue() );
-if( !maSizeWrp.IsControlDontKnow() )
+// Default value was saved; so don't change the aItem's width if the 
control
+// has not changed its value, to avoid round-trip errors (like 
twip->cm->twip)
+// E.g., initial 100 twip will become 0.18 cm, which will return as 102 
twip
+if( !maSizeWrp.IsControlDontKnow() && maSizeWrp.IsControlValueChanged() )
 aItem.SetWidth( maSizeWrp.GetControlValue() );
 if( !maColorWrp.IsControlDontKnow() )
 aItem.SetColor( maColorWrp.GetControlValue() );
@@ -239,8 +242,10 @@ SvxShadowItem ShadowControlsWrapper::GetControlValue() 
const
 
 void ShadowControlsWrapper::SetControlValue( SvxShadowItem aItem )
 {
+SetDefaultValue(aItem);
 maPosWrp.SetControlValue( aItem.GetLocation() );
 maSizeWrp.SetControlValue( aItem.GetWidth() );
+maSizeWrp.GetControl().SaveValue();
 maColorWrp.SetControlValue( aItem.GetColor() );
 }
 
diff --git a/include/sfx2/controlwrapper.hxx b/include/sfx2/controlwrapper.hxx
index c130ae1c7328..746a0821a9a8 100644
--- a/include/sfx2/controlwrapper.hxx
+++ b/include/sfx2/controlwrapper.hxx
@@ -259,6 +259,7 @@ public:
 
 virtual ValueT  GetControlValue() const SAL_OVERRIDE;
 virtual voidSetControlValue( ValueT nValue ) SAL_OVERRIDE;
+boolIsControlValueChanged() const;
 
 private:
 FieldUnit   meUnit;
@@ -480,6 +481,12 @@ void MetricFieldWrapper< ValueT >::SetControlValue( ValueT 
nValue )
 this->GetControl().SetValue( this->GetControl().Normalize( static_cast< 
sal_Int64 >( nValue ) ), meUnit );
 }
 
+template< typename ValueT >
+bool MetricFieldWrapper< ValueT >::IsControlValueChanged() const
+{
+return this->GetControl().IsValueChangedFromSaved();
+}
+
 
 template< typename ValueT >
 ValueT ListBoxWrapper< ValueT >::GetControlValue() const
diff --git a/include/sfx2/itemconnect.hxx b/include/sfx2/itemconnect.hxx
index a14361103bce..a4a122cddaac 100644
--- a/include/sfx2/itemconnect.hxx
+++ b/include/sfx2/itemconnect.hxx
@@ -243,6 +243,7 @@ protected:
 
 ItemWrapperType maItemWrp;
 std::unique_ptr   mxCtrlWrp;
+boolmbModified;
 };
 
 
@@ -393,7 +394,8 @@ ItemControlConnection< ItemWrpT, ControlWrpT 
>::ItemControlConnection(
 sal_uInt16 nSlot, ControlWrpT* pNewCtrlWrp, ItemConnFlags nFlags ) :
 ItemConnectionBase( nFlags ),
 maItemWrp( nSlot ),
-mxCtrlWrp( pNewCtrlWrp )
+mxCtrlWrp( pNewCtrlWrp ),
+mbModified( false )
 {
 }
 
@@ -402,7 +404,8 @@ ItemControlConnection< ItemWrpT, ControlWrpT 
>::ItemControlConnection(
 sal_uInt16 nSlot, ControlType& rControl, ItemConnFlags nFlags ) :
 ItemConnectionBase( nFlags ),
 maItemWrp( nSlot ),
-mxCtrlWrp( new ControlWrpT( rControl ) )
+mxCtrlWrp( new ControlWrpT( rControl ) ),
+mbModified( false )
 {
 }
 
@@ -425,6 +428,7 @@ void ItemControlConnection< ItemWrpT, ControlWrpT >::Reset( 
const SfxItemSet* pI
 mxCtrlWrp->SetControlDontKnow( pItem == nullptr );
 if( pItem )
 mxCtrlWrp->SetControlValue( maItemWrp.GetItemValue( *pItem ) );
+mbModified = false;
 }
 
 template< typename ItemWrpT, typename ControlWrpT >
@@ -432,7 +436,6 @@ bool ItemControlConnection< ItemWrpT, ControlWrpT 
>::FillItemSet(
 SfxItemSet& rDestSet, const SfxItemSet& rOldS

GSoC Proposal

[Ekansh Jha]

Hello Community,

I am a 3rd-year undergraduate student, in the Department of Mathematics
pursuing Integrated M.Sc. in Applied Mathematics from Indian Institute of
Technology–Roorkee (IITR). I am keenly interested in contributing to
libreoffice as a part of GSoC.

I am familliar with the language C++ that is widely used in core,
additionally I have also worked with Java and python which might be helpful
to accomplish the project.

I would like to work on Improve VML import :
https://wiki.documentfoundation.org/Development/GSoC/Ideas#Improve_VML_import,
It would be really great if I can get help to start for a proposal.

I have been active in community since last October and would like to
contribute in the future as well.
To further explore, I tried my hands on different kinds of bugs :
https://gerrit.libreoffice.org/#/q/ekansh, Please have a look into my
gerrit submissions.

I currently use Ubuntu 16.04 GNU/Linux as my primary development platform.
The configurations of my machine are sufficient to efficiently build
libreoffice and multitask for long hours.

With Best Regards,
Ekansh Jha

‌
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Inquiry about gsoc

[fady esam]

When i read a bug im a specific part of the project like the hacks required
for gsoc in a specific part like (saving)
What part of the code do i start looking for this part?
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/inc

[Markus Mohrhard]

 sc/inc/bitmaps.hlst |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fecc5d4a4423938de6d07dd57e6a98160bf91f3e
Author: Markus Mohrhard 
Date:   Fri Feb 23 02:19:47 2018 +0100

fix crash while trying to access icon set image file

Change-Id: Iaad9b5aeb4163a5262bcaf0a414ee30fd9279a49
Reviewed-on: https://gerrit.libreoffice.org/50219
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/sc/inc/bitmaps.hlst b/sc/inc/bitmaps.hlst
index c87a47b000e7..254cd2db2d8e 100644
--- a/sc/inc/bitmaps.hlst
+++ b/sc/inc/bitmaps.hlst
@@ -96,7 +96,7 @@
 #define BMP_ICON_SET_PIES_THREE_QUARTER 
"sc/res/icon-set-pies-three-quarters.png"
 #define BMP_ICON_SET_PIES_FULL  "sc/res/icon-set-pies-full.png"
 #define BMP_ICON_SET_SHAPES_CIRCLE  
"sc/res/icon-set-shapes-circle.png"
-#define BMP_ICON_SET_SHAPES_TRIANGLE
"sc/res/icon-set-shapes-triangle"
+#define BMP_ICON_SET_SHAPES_TRIANGLE
"sc/res/icon-set-shapes-triangle.png"
 #define BMP_ICON_SET_SHAPES_DIAMOND 
"sc/res/icon-set-shapes-diamond.png"
 #define BMP_ICON_SET_SQUARES_EMPTY  
"sc/res/icon-set-squares-empty.png"
 #define BMP_ICON_SET_SQUARES_ONE_QUARTER
"sc/res/icon-set-squares-one-quarter.png"
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: icon-themes/galaxy

[Markus Mohrhard]

 icon-themes/galaxy/sc/res/icon-set-circles2-light-red.png |binary
 1 file changed

New commits:
commit f5eb32c635a07f6977b8e613ac8732242e8682e7
Author: Markus Mohrhard 
Date:   Fri Feb 23 02:36:14 2018 +0100

fix incorrect icon set size

Change-Id: Iadd08f5a95121cc2c5e6ac0d5719bdfa07b5c95a
Reviewed-on: https://gerrit.libreoffice.org/50220
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/icon-themes/galaxy/sc/res/icon-set-circles2-light-red.png 
b/icon-themes/galaxy/sc/res/icon-set-circles2-light-red.png
index 50f7e818d8bb..13c306e7f348 100644
Binary files a/icon-themes/galaxy/sc/res/icon-set-circles2-light-red.png and 
b/icon-themes/galaxy/sc/res/icon-set-circles2-light-red.png differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Status of LO embedding inside other processes windows?

[Thorsten Behrens]

Stephan Bergmann wrote:
> Most likely, yes.  That LO-in-Java-window thing is brittle at best.
>
Mmmh - so we have that working in production for a few clients, though
for Windows.

LOKit is fine, just it should be noted that ~all UI [1] and
interaction then needs to be implemented client-side.

[1] yes, there's dialog tunnelling, still that needs code to render &
interact on the client side.

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ScFiltersTest::testOrcusODSStyleInterface fails with liborcus 0.13.3

[Kohei Yoshida]

On Thu, 2018-02-22 at 15:14 +0100, Rene Engelhard wrote:
> 
> I think that should be done.

Here we go.

https://gerrit.libreoffice.org/#/c/50213/

Hopefully the Jenkins builds will be all green.

Thanks,

Kohei
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sysui/desktop

[Olivier Tilloy]

 sysui/desktop/apparmor/program.soffice.bin |   30 +++--
 1 file changed, 20 insertions(+), 10 deletions(-)

New commits:
commit 1ee5162cd58f61d645d72e51113fe4645e8629eb
Author: Olivier Tilloy 
Date:   Mon Jan 8 16:59:17 2018 +0100

tdf#114915 Apparmor profile update (invalid comments syntax)

The apparmor profile parser doesn't interpret # as a comment when on the 
same
line as a variable assignment. Ensure that comments are on their own line,
above the actual assignment.

Change-Id: If10bb05f11b0e9026746db2e271113f30da5cbef
Reviewed-on: https://gerrit.libreoffice.org/47605
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 
(cherry picked from commit 35ad7482af49ab80d348b619b6d420ee170d3e5d)
Reviewed-on: https://gerrit.libreoffice.org/50207
Reviewed-by: Eike Rathke 

diff --git a/sysui/desktop/apparmor/program.soffice.bin 
b/sysui/desktop/apparmor/program.soffice.bin
index 6b91d6091db8..1f3ac9ae0971 100644
--- a/sysui/desktop/apparmor/program.soffice.bin
+++ b/sysui/desktop/apparmor/program.soffice.bin
@@ -23,12 +23,18 @@
 #Some obscure ones we're excluded (mostly input)
 
 #Generic
-@{libreoffice_ext} = [tT][xX][tT]  #.txt
-@{libreoffice_ext} += {,f,F}[oO][dDtT][tTsSpPbBgGfF]  #All the open document 
format
-@{libreoffice_ext} += [xX][mMsS][lL]  #.xml and xsl
-@{libreoffice_ext} += [pP][dD][fF]  #.pdf
-@{libreoffice_ext} += [uU][oO][fFtTsSpP]  #Unified office format
-@{libreoffice_ext} += {,x,X}[hH][tT][mM]{,l,L}  #(x)htm(l)
+#.txt
+@{libreoffice_ext} = [tT][xX][tT]
+#All the open document format
+@{libreoffice_ext} += {,f,F}[oO][dDtT][tTsSpPbBgGfF]
+#.xml and xsl
+@{libreoffice_ext} += [xX][mMsS][lL]
+#.pdf
+@{libreoffice_ext} += [pP][dD][fF]
+#Unified office format
+@{libreoffice_ext} += [uU][oO][fFtTsSpP]
+#(x)htm(l)
+@{libreoffice_ext} += {,x,X}[hH][tT][mM]{,l,L}
 
 #Images
 @{libreoffice_ext} += [jJ][pP][gG]
@@ -45,15 +51,19 @@
 
 #Calc
 @{libreoffice_ext} += [xX][lL][sSwWtT]{,x,X}
-@{libreoffice_ext} += [dD][iIbB][fF]  #.dif dbf
-@{libreoffice_ext} += [cCtT][sS][vV]  #.tsv .csv
+#.dif dbf
+@{libreoffice_ext} += [dD][iIbB][fF]
+#.tsv .csv
+@{libreoffice_ext} += [cCtT][sS][vV]
 @{libreoffice_ext} += [sS][lL][kK]
 
 #Impress/Draw
 @{libreoffice_ext} += [pP][pP][tTsS]{,x,X}
 @{libreoffice_ext} += [pP][oO][tT]{,m,M}
-@{libreoffice_ext} += [sS][wW][fF]  #Flash
-@{libreoffice_ext} += [pP][sS][dD]  #Photoshop
+#Flash
+@{libreoffice_ext} += [sS][wW][fF]
+#Photoshop
+@{libreoffice_ext} += [pP][sS][dD]
 
 #Math
 @{libreoffice_ext} += [mM][mM][lL]
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - vcl/inc vcl/osx vcl/source

[Tor Lillqvist]

 vcl/inc/salinst.hxx   |4 
 vcl/osx/salinst.cxx   |3 +++
 vcl/source/app/svmain.cxx |4 
 3 files changed, 11 insertions(+)

New commits:
commit 42a5a054b70c7850ca47074c2d5dd249de3202b4
Author: Tor Lillqvist 
Date:   Thu Feb 22 12:40:26 2018 +0200

tdf#103690: Set up notifications only after VCL has been initialised

On some Macs, it seems that LibreOffice (or any app?) gets an
NSApplicationDidChangeScreenParametersNotification as soon as it has
started and asked for such a notification. Our handler for that
notification assumes that VCL is initialised. Thus we should not ask
for such notifications before VCL has been initialised.

I could not reproduce the reported crash with an unmodified
LibreOffice, only after inserting a sleep after the notifications had
been set up. But I am fairly sure this change fixes the problem.

Change-Id: I18d342eb7dc0c77cb7fc8623756bead65a1bd329
Reviewed-on: https://gerrit.libreoffice.org/50164
Tested-by: Jenkins 
Reviewed-by: Tor Lillqvist 
Reviewed-on: https://gerrit.libreoffice.org/50197
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/vcl/inc/salinst.hxx b/vcl/inc/salinst.hxx
index f33d9d4d912a..805ee035f077 100644
--- a/vcl/inc/salinst.hxx
+++ b/vcl/inc/salinst.hxx
@@ -194,6 +194,10 @@ void DeInitSalData();   // called from 
Application-Dtor
 
 void InitSalMain();
 
+#ifdef MACOSX
+void postInitVCLinitNSApp();
+#endif
+
 #endif // INCLUDED_VCL_INC_SALINST_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/osx/salinst.cxx b/vcl/osx/salinst.cxx
index 80b6fec66cc0..f3fd09cf8d44 100644
--- a/vcl/osx/salinst.cxx
+++ b/vcl/osx/salinst.cxx
@@ -157,7 +157,10 @@ static void initNSApp()
 
 // activate our delegate methods
 [NSApp setDelegate: NSApp];
+}
 
+void postInitVCLinitNSApp()
+{
 [[NSNotificationCenter defaultCenter] addObserver: NSApp
   selector: 
@selector(systemColorsChanged:)
   name: 
NSSystemColorsDidChangeNotification
diff --git a/vcl/source/app/svmain.cxx b/vcl/source/app/svmain.cxx
index e4b1468eecec..2d33836aea62 100644
--- a/vcl/source/app/svmain.cxx
+++ b/vcl/source/app/svmain.cxx
@@ -187,6 +187,10 @@ int ImplSVMain()
 
 bool bInit = isInitVCL() || InitVCL();
 
+#ifdef MACOSX
+postInitVCLinitNSApp();
+#endif
+
 if( bInit )
 {
 // call application main
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sfx2/source

[Mike Kaganski]

 sfx2/source/dialog/tabdlg.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 06f04bf84d48d6542d9b47d1e16228923de61302
Author: Mike Kaganski 
Date:   Wed Feb 21 21:45:35 2018 +0100

Simplify conditions a little

Change-Id: Iaa587f1a2d78f14b999f2e9e866db058d466493f
Reviewed-on: https://gerrit.libreoffice.org/50137
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/sfx2/source/dialog/tabdlg.cxx b/sfx2/source/dialog/tabdlg.cxx
index f6fd5f90299f..c707cccea6a8 100644
--- a/sfx2/source/dialog/tabdlg.cxx
+++ b/sfx2/source/dialog/tabdlg.cxx
@@ -776,10 +776,10 @@ short SfxTabDialog::Ok()
 
 if ( !m_pOutSet )
 {
-if ( !m_pExampleSet && m_pSet )
-m_pOutSet = m_pSet->Clone( false );  // without Items
-else if ( m_pExampleSet )
+if ( m_pExampleSet )
 m_pOutSet = new SfxItemSet( *m_pExampleSet );
+else if ( m_pSet )
+m_pOutSet = m_pSet->Clone( false );  // without Items
 }
 bool bModified = false;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: offapi/com

[Tomaž Vajngerl]

 offapi/com/sun/star/drawing/GraphicObjectShape.idl |8 
 1 file changed, 8 insertions(+)

New commits:
commit 6103b6698c6bd832127e781308cd77566167fd3f
Author: Tomaž Vajngerl 
Date:   Thu Feb 22 08:09:53 2018 +0900

add some whitespace to make it more readable, no change

Change-Id: I7a08d316b5d7fc99043344b1cf7cb8e326df75ae
Reviewed-on: https://gerrit.libreoffice.org/50170
Reviewed-by: Tomaž Vajngerl 
Tested-by: Tomaž Vajngerl 

diff --git a/offapi/com/sun/star/drawing/GraphicObjectShape.idl 
b/offapi/com/sun/star/drawing/GraphicObjectShape.idl
index 3a6e8d219bd6..522d0019bd48 100644
--- a/offapi/com/sun/star/drawing/GraphicObjectShape.idl
+++ b/offapi/com/sun/star/drawing/GraphicObjectShape.idl
@@ -113,20 +113,28 @@ published service GraphicObjectShape
 
 /// Whether this shape is actually a signature line.
 [optional, property] boolean IsSignatureLine;
+
 /// The ID of the signature line, used to connect to a signature.
 [optional, property] string SignatureLineId;
+
 /// Suggested Signer, Name of the Signer
 [optional, property] string SignatureLineSuggestedSignerName;
+
 /// Suggested Signer, Line 2 (Title or additional information)
 [optional, property] string SignatureLineSuggestedSignerTitle;
+
 /// Suggested Signer Email
 [optional, property] string SignatureLineSuggestedSignerEmail;
+
 /// Signing instructions, to be shown at signing time
 [optional, property] string SignatureLineSigningInstructions;
+
 /// Whether the signing date should be shown in the shape
 [optional, property] boolean SignatureLineShowSignDate;
+
 /// Whether the user can attach a comment at signing time
 [optional, property] boolean SignatureLineCanAddComment;
+
 /** Image to be displayed when the signature line is unsigned
  *
  *  Images for signed signature lines (valid and invalid)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/quartz

[Tor Lillqvist]

 vcl/quartz/ctfonts.cxx |   11 +++
 1 file changed, 11 insertions(+)

New commits:
commit f7733528e88a6619f82b54b59e92a9bca72c0a89
Author: Tor Lillqvist 
Date:   Thu Feb 22 22:45:30 2018 +0200

tdf#68889: Fix the weight reported by the system for the problematic font

Like the previous fix for Courier Std. Let's hope there won't be a lot
of these special cases. Maybe some generic heuristic would be better.
Like if a font's GetStyleName() is "Medium", "Medium Oblique", or
"Medium Italic" then always force its weight to be WEIGHT_NORMAL?

Change-Id: I204655cd9c4e32d5cbbd68bb93c6282d23993b80

diff --git a/vcl/quartz/ctfonts.cxx b/vcl/quartz/ctfonts.cxx
index 297c4dd58941..1ac73c59a60f 100644
--- a/vcl/quartz/ctfonts.cxx
+++ b/vcl/quartz/ctfonts.cxx
@@ -394,6 +394,17 @@ FontAttributes DevFontFromCTFontDescriptor( 
CTFontDescriptorRef pFD, bool* bFont
 fWeight = 0;
 }
 
+// tdf#68889: Ditto for Gill Sans MT Pro. Here I can kinda understand it, 
maybe the
+// kCTFontWeightTrait is intended to give a subjective "optical" 
impression of how the font
+// looks, and Gill Sans MT Pro Medium is kinda heavy. But with the way 
LibreOffice uses fonts,
+// we still should think of it as being "medium" weight.
+if (rDFA.GetFamilyName() == "Gill Sans MT Pro" &&
+(rDFA.GetStyleName() == "Medium" || rDFA.GetStyleName() == "Medium 
Italic") &&
+fWeight > 0.2)
+{
+fWeight = 0;
+}
+
 if( fWeight > 0 )
 {
 nInt = rint(WEIGHT_NORMAL + fWeight * ((WEIGHT_BLACK - 
WEIGHT_NORMAL)/0.68));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Non-portable configure.ac

[Tor Lillqvist]

Perl is great.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: include/xmloff sw/inc sw/qa sw/source

[Tomaž Vajngerl]

 include/xmloff/txtparae.hxx  |1 
 sw/inc/cmdid.h   |4 +-
 sw/inc/unoprnms.hxx  |1 
 sw/qa/extras/odfexport/odfexport.cxx |5 +-
 sw/source/core/unocore/unoframe.cxx  |   61 ++-
 sw/source/core/unocore/unomap1.cxx   |2 -
 6 files changed, 10 insertions(+), 64 deletions(-)

New commits:
commit f0a14acc4ebe7f1192b195738540cd9f4e1435fa
Author: Tomaž Vajngerl 
Date:   Wed Feb 21 17:26:08 2018 +0900

sw: remove "ReplacementGraphicURL" related things

Change-Id: Ia6892e3cd84b2466ea30828e9b18310789dc1686
Reviewed-on: https://gerrit.libreoffice.org/50138
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/xmloff/txtparae.hxx b/include/xmloff/txtparae.hxx
index b9b8db588d93..35c163014a62 100644
--- a/include/xmloff/txtparae.hxx
+++ b/include/xmloff/txtparae.hxx
@@ -150,7 +150,6 @@ private:
 const OUString sGraphicFilter;
 const OUString sGraphicRotation;
 const OUString sGraphicURL;
-const OUString sReplacementGraphicURL;
 const OUString sHeight;
 const OUString sHoriOrient;
 const OUString sHoriOrientPosition;
diff --git a/sw/inc/cmdid.h b/sw/inc/cmdid.h
index 99b25ec056a8..2e048f6289a9 100644
--- a/sw/inc/cmdid.h
+++ b/sw/inc/cmdid.h
@@ -568,7 +568,7 @@
 #define FN_UNO_PARA_STYLE_CONDITIONS(FN_EXTRA2 + 100)
 #define FN_UNO_GRAPHIC  (FN_EXTRA2 + 101)
 
-#define FN_UNO_REPLACEMENT_GRAPHIC_URL  (FN_EXTRA2 + 102)
+// #define free (FN_EXTRA2 + 102)
 #define FN_UNO_CELL_ROW_SPAN(FN_EXTRA2 + 103)
 #define FN_UNO_TABLE_BORDER_DISTANCES   (FN_EXTRA2 + 104)
 #define FN_SPELL_GRAMMAR_DIALOG (FN_EXTRA2 + 105)
@@ -596,7 +596,7 @@
 #define FN_UNO_FOOTER_FIRST (FN_EXTRA2 + 119)
 #define FN_UNO_TABLE_BORDER2(FN_EXTRA2 + 120)
 
-#define FN_UNO_REPLACEMENT_GRAPHIC_U_R_L(FN_EXTRA2 + 121)
+// #define free (FN_EXTRA2 + 121)
 #define FN_UNO_HIDDEN   (FN_EXTRA2 + 122)
 #define FN_UNO_STYLE_INTEROP_GRAB_BAG   (FN_EXTRA2 + 123)
 #define FN_UNO_TABLE_TEMPLATE_NAME  (FN_EXTRA2 + 124)
diff --git a/sw/inc/unoprnms.hxx b/sw/inc/unoprnms.hxx
index e5e1f31d2464..b603a7a6be8c 100644
--- a/sw/inc/unoprnms.hxx
+++ b/sw/inc/unoprnms.hxx
@@ -828,7 +828,6 @@
 #define UNO_NAME_FOOTER_TEXT_FIRST "FooterTextFirst"
 #define UNO_NAME_INITIALS "Initials"
 #define UNO_NAME_TABLE_BORDER2 "TableBorder2"
-#define UNO_NAME_REPLACEMENT_GRAPHIC_URL "ReplacementGraphicURL"
 #define UNO_NAME_REPLACEMENT_GRAPHIC "ReplacementGraphic"
 #define UNO_NAME_HIDDEN "Hidden"
 #define UNO_NAME_DEFAULT_PAGE_MODE "DefaultPageMode"
diff --git a/sw/qa/extras/odfexport/odfexport.cxx 
b/sw/qa/extras/odfexport/odfexport.cxx
index c0ca863162c4..a602011ec992 100644
--- a/sw/qa/extras/odfexport/odfexport.cxx
+++ b/sw/qa/extras/odfexport/odfexport.cxx
@@ -1434,9 +1434,10 @@ DECLARE_ODFEXPORT_TEST(testEmbeddedPdf, 
"embedded-pdf.odt")
 {
 uno::Reference xShape = getShape(1);
 // This failed, pdf+png replacement graphics pair didn't survive an ODT 
roundtrip.
-CPPUNIT_ASSERT(!getProperty(xShape, 
"ReplacementGraphicURL").isEmpty());
+auto xReplacementGraphic = 
getProperty>(xShape, "ReplacementGraphic");
+CPPUNIT_ASSERT(xReplacementGraphic.is());
 
-auto xGraphic = getProperty< uno::Reference >(xShape, 
"Graphic");
+auto xGraphic = getProperty>(xShape, 
"Graphic");
 CPPUNIT_ASSERT(xGraphic.is());
 // This was image/x-vclgraphic, not exposing the info that the image is a 
PDF one.
 CPPUNIT_ASSERT_EQUAL(OUString("application/pdf"), 
getProperty(xGraphic, "MimeType"));
diff --git a/sw/source/core/unocore/unoframe.cxx 
b/sw/source/core/unocore/unoframe.cxx
index 8b3595b40af0..cb59f4ddae79 100644
--- a/sw/source/core/unocore/unoframe.cxx
+++ b/sw/source/core/unocore/unoframe.cxx
@@ -1639,41 +1639,13 @@ void SwXFrame::setPropertyValue(const OUString& 
rPropertyName, const ::uno::Any&
 }
 }
 }
-else if( FN_UNO_REPLACEMENT_GRAPHIC_URL == pEntry->nWID || 
FN_UNO_REPLACEMENT_GRAPHIC == pEntry->nWID )
+else if (FN_UNO_REPLACEMENT_GRAPHIC == pEntry->nWID)
 {
-bool bURL = FN_UNO_REPLACEMENT_GRAPHIC_URL == pEntry->nWID;
-bool bApply = false;
-Graphic aGraphic;
-if( bURL )
-{
-OUString aGrfUrl;
-aValue >>= aGrfUrl;
-
-// the package URL based graphics are handled in different way 
currently
-// TODO/LATER: actually this is the correct place to handle 
them
-OUString aGraphicProtocol( sGraphicObjectProtocol );
-if( aGrfUrl.startsWith( aGraphicProtocol ) )
-{
-OString sId(OUStringToOString(
-aGrfUrl.copy(sizeof(sGraphicObjectProtocol)-1),
-

[Libreoffice-commits] core.git: solenv/gbuild

[Rico Tzschichholz]

 solenv/gbuild/extensions/post_PackageInfo.mk |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 06db1b3bd9804efbe64784a1dbee11f4690a1038
Author: Rico Tzschichholz 
Date:   Thu Feb 22 14:21:50 2018 +0100

solenv: Update gb_PackageInfo_emit_l10n_for_one_lang

Add cjk_*, ctl_* and ctlseqcheck_$LANG.xcd files to install list

Change-Id: I2c56cf2af3cc444cb7075740a981b6954950e5f5
Reviewed-on: https://gerrit.libreoffice.org/50182
Reviewed-by: Rico Tzschichholz 
Reviewed-by: Michael Stahl 
Tested-by: Jenkins 

diff --git a/solenv/gbuild/extensions/post_PackageInfo.mk 
b/solenv/gbuild/extensions/post_PackageInfo.mk
index 1abd6e241d9f..331eeb89e194 100644
--- a/solenv/gbuild/extensions/post_PackageInfo.mk
+++ b/solenv/gbuild/extensions/post_PackageInfo.mk
@@ -69,6 +69,9 @@ define gb_PackageInfo_emit_l10n_for_one_lang
 $(if $(filter-out qtz en-US,$(1)),$(foreach packagedir,$(patsubst 
%/,%,$(gb_AllLangPackage_ALLDIRS)),$(call 
gb_PackageInfo_emit_l10n_for_one_alllangpackage,$(packagedir),$(1
 $(if $(filter $(gb_AllLangMoTarget_LANGS),$(1)),$(foreach 
target,$(gb_AllLangMoTarget_REGISTERED),$(call 
gb_PackageInfo_emit_l10n_for_one_mo,$(target),$(1
 $(if $(filter $(gb_Configuration_LANGS),$(1)),$(foreach configfile,Langpack- 
res/fcfg_langpack_ res/registry_,$(call 
gb_PackageInfo_emit_l10n_for_one_configfile,$(1),$(configfile
+$(if $(filter $(gb_CJK_LANGS),$(1)),$(foreach configfile,cjk_,$(call 
gb_PackageInfo_emit_l10n_for_one_configfile,$(1),$(configfile
+$(if $(filter $(gb_CTL_LANGS),$(1)),$(foreach configfile,ctl_,$(call 
gb_PackageInfo_emit_l10n_for_one_configfile,$(1),$(configfile
+$(if $(filter $(gb_CTLSEQCHECK_LANGS),$(1)),$(foreach 
configfile,ctlseqcheck_,$(call 
gb_PackageInfo_emit_l10n_for_one_configfile,$(1),$(configfile
 @echo "$(foreach suf,executables libraries 
files,$(gb_PackageInfo_get_target)/l10n-$(1).$(suf)) \\" >> 
$(WORKDIR)/Dep/packageinfo.d
 
 endef
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: postprocess/CustomTarget_images.mk solenv/bin

[Stephan Bergmann]

 postprocess/CustomTarget_images.mk |5 +++--
 solenv/bin/pack_images.py  |1 -
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 906a2e4fa4e9ce231126c608e741c0c0d809157d
Author: Stephan Bergmann 
Date:   Thu Feb 22 14:37:32 2018 +0100

Always execute pack_images.py with the right Python interpreter

With --enable-python=fully-internal, where PYTHON_FOR_BUILD is empty, this
executed the "#!/usr/bin/env python" shebang in pack_images.py, using 
whatever
python would be found (or not) on the system.

With this fixed, there is no need any more for pack_images.py to be 
executable.

Change-Id: I40ad3769898f3eb711dbe555d4c3faa9e3c1456d
Reviewed-on: https://gerrit.libreoffice.org/50180
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/postprocess/CustomTarget_images.mk 
b/postprocess/CustomTarget_images.mk
index 871c7bd6470c..77c653abf3fe 100644
--- a/postprocess/CustomTarget_images.mk
+++ b/postprocess/CustomTarget_images.mk
@@ -29,11 +29,12 @@ $(packimages_DIR)/%.zip : \
$(packimages_DIR)/commandimagelist.ilst \
$(packimages_DIR)/sourceimagelist.ilst \
$(SRCDIR)/wizards/source/imagelists/imagelists.ilst \
-   $(call gb_Helper_get_imagelists)
+   $(call gb_Helper_get_imagelists) \
+   | $(call gb_ExternalExecutable_get_dependencies,python)
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),PRL,2)
$(call gb_Helper_abbreviate_dirs, \
ILSTFILE=$(call var2file,$(shell $(gb_MKTEMP)),100,$(filter 
%.ilst,$^)) && \
-   $(PYTHON_FOR_BUILD) $(SRCDIR)/solenv/bin/pack_images.py \
+   $(call gb_ExternalExecutable_get_command,python) 
$(SRCDIR)/solenv/bin/pack_images.py \
$(if $(DEFAULT_THEME),\
-g $(packimages_DIR) -m $(packimages_DIR) -c 
$(packimages_DIR),\
-g $(SRCDIR)/icon-themes/$(subst images_,,$*) 
-m $(SRCDIR)/icon-themes/$(subst images_,,$*) -c $(SRCDIR)/icon-themes/$(subst 
images_,,$*) \
diff --git a/solenv/bin/pack_images.py b/solenv/bin/pack_images.py
old mode 100755
new mode 100644
index 0f493c8f3035..bd75b9044210
--- a/solenv/bin/pack_images.py
+++ b/solenv/bin/pack_images.py
@@ -1,4 +1,3 @@
-#!/usr/bin/env python
 # -*- coding: utf-8 -*-
 # -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
 #
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Render differences of DOCX between Word and LO/AOO

[Jens Tröger]

Chris, thank you, and done:
https://bugs.documentfoundation.org/show_bug.cgi?id=115944



--
Sent from: http://nabble.documentfoundation.org/Dev-f1639786.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Non-portable configure.ac

[Sander Maijers]

I must say autogen.sh being a Perl script surprised, even dismayed me.

Problems suchs as the one you describe are only to be expected when 
bolting on Perl for this purpose.


Have any arguments been made against getting rid of Perl, in this instance?


On 22-02-18 19:29, Jan-Marek Glogowski wrote:

Am 22.02.2018 um 18:36 schrieb Sander Maijers:

Note that checkbashisms 2.17.12-1 failed to catch this when I debugged
this issue.

https://www.archlinux.org/packages/community/any/checkbashisms/

Also note that on Arch Linux, I used dash 0.5.9.1-1, whereas Debian only
has various older versions

https://packages.debian.org/search?keywords=dash

Running shellcheck and checkbashisms regularly is advisable even for
autoconf generated scripts.

On my Ubuntu I also have sh -> dash. But I guess, like most people, I
use autogen.sh to run configure with flags from autogen.input.

And autogen.sh is really a Perl script, and Perls system call runs
configure by calling "bash ./configure …". That's probably why nobody
caught this yet. Now I have no idea why Perls system function uses bash
as shell…

Jan-Marek


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sal/osl

[Samuel Mehrbrodt]

 sal/osl/w32/file_dirvol.cxx |   16 
 1 file changed, 12 insertions(+), 4 deletions(-)

New commits:
commit 50bf4eec6ff3cb3db23484331965f2e32cb0b5bc
Author: Samuel Mehrbrodt 
Date:   Wed Feb 21 09:27:25 2018 +0100

Use long path prefix in osl_getFileStatus

When installing an extension e.g., paths can get very long and they
hit the 255 char limit, thus the installation fails.
So we need to prefix the path with the long file name prefix
when its longer than MAX_PATH for windows api calls to succeed.

Change-Id: Ie62644192ba40a9d4802772cd9837fc84fae947a
Reviewed-on: https://gerrit.libreoffice.org/50079
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/sal/osl/w32/file_dirvol.cxx b/sal/osl/w32/file_dirvol.cxx
index c3848e5662bc..929916965777 100644
--- a/sal/osl/w32/file_dirvol.cxx
+++ b/sal/osl/w32/file_dirvol.cxx
@@ -1573,9 +1573,16 @@ oslFileError SAL_CALL osl_getFileStatus(
 break;
 }
 
+OUString sFullPath(pItemImpl->m_pFullPath);
+
+// Prefix long paths, windows API calls expect this prefix
+// (only local paths starting with something like C: or D:)
+if (sFullPath.getLength() >= MAX_PATH && isalpha(sFullPath[0]) && 
sFullPath[1] == ':')
+sFullPath = "?\\" + sFullPath;
+
 if ( uFieldMask & osl_FileStatus_Mask_Validate )
 {
-HANDLE  hFind = FindFirstFileW( o3tl::toW(rtl_uString_getStr( 
pItemImpl->m_pFullPath )), &pItemImpl->FindData );
+HANDLE  hFind = FindFirstFileW( o3tl::toW(sFullPath.getStr() ), 
&pItemImpl->FindData );
 
 if ( hFind != INVALID_HANDLE_VALUE )
 FindClose( hFind );
@@ -1635,7 +1642,7 @@ oslFileError SAL_CALL osl_getFileStatus(
 
 if ( uFieldMask & osl_FileStatus_Mask_LinkTargetURL )
 {
-oslFileError error = osl_getFileURLFromSystemPath( 
pItemImpl->m_pFullPath, &pStatus->ustrLinkTargetURL );
+oslFileError error = osl_getFileURLFromSystemPath( sFullPath.pData, 
&pStatus->ustrLinkTargetURL );
 if (error != osl_File_E_None)
 return error;
 
@@ -1647,7 +1654,7 @@ oslFileError SAL_CALL osl_getFileStatus(
 if ( !pItemImpl->bFullPathNormalized )
 {
 ::osl::LongPathBuffer< sal_Unicode > aBuffer( MAX_LONG_PATH );
-sal_uInt32 nNewLen = GetCaseCorrectPathName( 
o3tl::toW(rtl_uString_getStr( pItemImpl->m_pFullPath )),
+sal_uInt32 nNewLen = GetCaseCorrectPathName( o3tl::toW( 
sFullPath.getStr() ),
  o3tl::toW( aBuffer ),
  
aBuffer.getBufSizeInSymbols(),
  true );
@@ -1655,11 +1662,12 @@ oslFileError SAL_CALL osl_getFileStatus(
 if ( nNewLen )
 {
 rtl_uString_newFromStr( &pItemImpl->m_pFullPath, aBuffer );
+sFullPath = OUString( pItemImpl->m_pFullPath );
 pItemImpl->bFullPathNormalized = TRUE;
 }
 }
 
-oslFileError error = osl_getFileURLFromSystemPath( 
pItemImpl->m_pFullPath, &pStatus->ustrFileURL );
+oslFileError error = osl_getFileURLFromSystemPath( sFullPath.pData, 
&pStatus->ustrFileURL );
 if (error != osl_File_E_None)
 return error;
 pStatus->uValidFields |= osl_FileStatus_Mask_FileURL;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: avmedia/source

[Tor Lillqvist]

 avmedia/source/macavf/framegrabber.hxx |1 -
 avmedia/source/macavf/framegrabber.mm  |   18 --
 2 files changed, 19 deletions(-)

New commits:
commit 5ec76e598899a9939fa1f3bceab1caae5dfd1a67
Author: Tor Lillqvist 
Date:   Thu Feb 22 16:52:56 2018 +0200

Bin unused function

Change-Id: I38e9f2e21fdb7cfeb379278e9300e6451c8b970d

diff --git a/avmedia/source/macavf/framegrabber.hxx 
b/avmedia/source/macavf/framegrabber.hxx
index ee1ccaac1199..9d9d436b042a 100644
--- a/avmedia/source/macavf/framegrabber.hxx
+++ b/avmedia/source/macavf/framegrabber.hxx
@@ -35,7 +35,6 @@ public:
 explicit FrameGrabber( const css::uno::Reference< 
css::lang::XMultiServiceFactory >& );
 virtual  ~FrameGrabber() override;
 
-boolcreate( const ::rtl::OUString& rURL );
 boolcreate( AVAsset* pMovie );
 
 // XFrameGrabber
diff --git a/avmedia/source/macavf/framegrabber.mm 
b/avmedia/source/macavf/framegrabber.mm
index 2293a05ba03a..07bf7000bbcb 100644
--- a/avmedia/source/macavf/framegrabber.mm
+++ b/avmedia/source/macavf/framegrabber.mm
@@ -41,24 +41,6 @@ FrameGrabber::~FrameGrabber()
 }
 
 
-bool FrameGrabber::create( const ::rtl::OUString& rURL )
-{
-NSString* pNSStr = [NSString stringWithCharacters:reinterpret_cast(rURL.getStr()) length:rURL.getLength()];
-SAL_WNODEPRECATED_DECLARATIONS_PUSH
-//TODO: 10.11 stringByAddingPercentEscapesUsingEncoding
-NSURL* pNSURL = [NSURL URLWithString: [pNSStr 
stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]];
-SAL_WNODEPRECATED_DECLARATIONS_POP
-AVAsset* pMovie = [AVURLAsset URLAssetWithURL:pNSURL options:nil];
-if( !pMovie )
-{
-SAL_WARN("avmedia", "AVGrabber::create() cannot load url=" << [pNSStr 
UTF8String] );
-return false;
-}
-
-return create( pMovie );
-}
-
-
 bool FrameGrabber::create( AVAsset* pMovie )
 {
 if( [[pMovie tracksWithMediaType:AVMediaTypeVideo] count] == 0)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/backendtest vcl/headless vcl/opengl vcl/source vcl/unx vcl/workben

[Noel Grandin]

 vcl/backendtest/VisualBackendTest.cxx |4 
 vcl/headless/svpbmp.cxx   |4 
 vcl/opengl/gdiimpl.cxx|   12 
 vcl/source/app/help.cxx   |   48 +--
 vcl/source/app/svapp.cxx  |4 
 vcl/source/control/button.cxx |  398 +++---
 vcl/source/control/combobox.cxx   |   58 ++--
 vcl/source/control/edit.cxx   |   42 +--
 vcl/source/control/field.cxx  |   10 
 vcl/source/control/fixed.cxx  |   12 
 vcl/source/control/group.cxx  |4 
 vcl/source/control/imgctrl.cxx|   12 
 vcl/source/control/imp_listbox.cxx|   66 ++--
 vcl/source/control/listbox.cxx|   62 ++--
 vcl/source/control/listctrl.cxx   |8 
 vcl/source/control/morebtn.cxx|8 
 vcl/source/control/notebookbar.cxx|2 
 vcl/source/control/prgsbar.cxx|4 
 vcl/source/control/scrbar.cxx |   60 ++--
 vcl/source/control/slider.cxx |   96 +++
 vcl/source/control/spinbtn.cxx|8 
 vcl/source/control/spinfld.cxx|   54 ++--
 vcl/source/control/tabctrl.cxx|  192 +++---
 vcl/source/edit/texteng.cxx   |   34 +-
 vcl/source/edit/textview.cxx  |   76 ++---
 vcl/source/edit/vclmedit.cxx  |   54 ++--
 vcl/source/filter/graphicfilter.cxx   |4 
 vcl/source/filter/graphicfilter2.cxx  |   44 +--
 vcl/source/filter/wmf/emfwr.cxx   |4 
 vcl/source/filter/wmf/wmfwr.cxx   |   12 
 vcl/source/gdi/CommonSalLayout.cxx|   12 
 vcl/source/gdi/animate.cxx|4 
 vcl/source/gdi/bitmap.cxx |   20 -
 vcl/source/gdi/gdimtf.cxx |   26 -
 vcl/source/gdi/gradient.cxx   |   32 +-
 vcl/source/gdi/graph.cxx  |   36 +-
 vcl/source/gdi/impanmvw.cxx   |   52 +--
 vcl/source/gdi/impvect.cxx|  152 +--
 vcl/source/gdi/metaact.cxx|4 
 vcl/source/gdi/pdfwriter_impl.cxx |  180 ++---
 vcl/source/gdi/pdfwriter_impl2.cxx|   16 -
 vcl/source/gdi/pngread.cxx|   12 
 vcl/source/gdi/print.cxx  |8 
 vcl/source/gdi/print2.cxx |   26 -
 vcl/source/gdi/print3.cxx |   16 -
 vcl/source/gdi/region.cxx |8 
 vcl/source/gdi/regionband.cxx |8 
 vcl/source/gdi/sallayout.cxx  |   14 -
 vcl/source/gdi/svmconverter.cxx   |8 
 vcl/source/helper/canvasbitmap.cxx|4 
 vcl/source/outdev/bitmap.cxx  |   16 -
 vcl/source/outdev/font.cxx|   34 +-
 vcl/source/outdev/gradient.cxx|   96 +++
 vcl/source/outdev/hatch.cxx   |   30 +-
 vcl/source/outdev/map.cxx |   44 +--
 vcl/source/outdev/outdev.cxx  |6 
 vcl/source/outdev/text.cxx|   58 ++--
 vcl/source/outdev/textline.cxx|8 
 vcl/source/outdev/transparent.cxx |8 
 vcl/source/outdev/wallpaper.cxx   |   24 -
 vcl/source/window/brdwin.cxx  |  144 +-
 vcl/source/window/btndlg.cxx  |   12 
 vcl/source/window/cursor.cxx  |   22 -
 vcl/source/window/decoview.cxx|  180 ++---
 vcl/source/window/dockingarea.cxx |   16 -
 vcl/source/window/dockmgr.cxx |   46 +--
 vcl/source/window/dockwin.cxx |   52 +--
 vcl/source/window/floatwin.cxx|   54 ++--
 vcl/source/window/layout.cxx  |  144 +-
 vcl/source/window/menu.cxx|  132 -
 vcl/source/window/menubarwindow.cxx   |8 
 vcl/source/window/menufloatingwindow.cxx  |   22 -
 vcl/source/window/mouse.cxx   |4 
 vcl/source/window/msgbox.cxx  |   44 +--
 vcl/source/window/paint.cxx   |8 
 vcl/source/window/printdlg.cxx|   20 -
 vcl/source/window/scrwnd.cxx  |4 
 vcl/source/window/split.cxx   |   36 +-
 vcl/source/window/splitwin.cxx|  234 -
 vcl/source/window/status.cxx  |   82 +++---
 vcl/source/window/syswin.cxx  |   20 -
 vcl/source/window/tabdlg.cxx  |   18 -
 vcl/source/window/toolbox.cxx |  246 +-
 vcl/source/window/toolbox2.cxx|   40 +--
 vcl/source/window/window.cxx  |   72 ++---
 vcl/source/window/window2.cxx |   20 -
 vcl/source/window/winproc.cxx |2 
 vcl/unx/generic/app/i18n_status.cxx   |   20 -
 vcl/unx/generic/app/wmadaptor.cxx |8 
 vcl/unx/generic/gdi/cairotextrender.cxx   |8 
 vcl/unx/generic/gdi/salbmp.cxx|8 
 vcl/unx/generic/window/salframe.cxx   |   12 
 vcl/unx/gtk/gtksalframe.cxx   | 

Open Source Dockerfiles for LibreOffice development

[Stefan Weiberg]

Hello *,

I started developing/configuring some Docker Images for LibreOffice
development. They are licensed with EUPLv1.2 (GPLv3 compatible):

https://gitea.hibiki.eu/suntorytimed/dockerimage-libreoffice-base
https://gitea.hibiki.eu/suntorytimed/dockerimage-libreoffice-user
https://gitea.hibiki.eu/suntorytimed/dockerimage-libreoffice-jenkins

Feel free to mirror/fork.

Cheers,
Stefan (suntorytimed)
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: vcl/quartz

[Tor Lillqvist]

 vcl/quartz/ctfonts.cxx |   14 +-
 1 file changed, 13 insertions(+), 1 deletion(-)

New commits:
commit 1d7f96a324a4c2ab82a04513c6a38dc31fd061fa
Author: Tor Lillqvist 
Date:   Thu Feb 22 13:52:13 2018 +0200

tdf#67744: Fix the weight reported by the system for the problematic font

A hack, but oh well.

Change-Id: I13580d27acfb0cc200bdb0cc1911518675d3e32e
Reviewed-on: https://gerrit.libreoffice.org/50172
Tested-by: Jenkins 
Reviewed-by: Tor Lillqvist 

diff --git a/vcl/quartz/ctfonts.cxx b/vcl/quartz/ctfonts.cxx
index dbe4eb2cb96e..297c4dd58941 100644
--- a/vcl/quartz/ctfonts.cxx
+++ b/vcl/quartz/ctfonts.cxx
@@ -1,4 +1,4 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
 /*
  * This file is part of the LibreOffice project.
  *
@@ -382,6 +382,18 @@ FontAttributes DevFontFromCTFontDescriptor( 
CTFontDescriptorRef pFD, bool* bFont
 CFNumberRef pWeightNum = static_cast(CFDictionaryGetValue( 
pAttrDict, kCTFontWeightTrait ));
 CFNumberGetValue( pWeightNum, kCFNumberDoubleType, &fWeight );
 int nInt = WEIGHT_NORMAL;
+
+// Special case fixes
+
+// tdf#67744: Courier Std Medium is always bold. We get a 
kCTFontWeightTrait of 0.23 which
+// surely must be wrong.
+if (rDFA.GetFamilyName() == "Courier Std" &&
+(rDFA.GetStyleName() == "Medium" || rDFA.GetStyleName() == "Medium 
Oblique") &&
+fWeight > 0.2)
+{
+fWeight = 0;
+}
+
 if( fWeight > 0 )
 {
 nInt = rint(WEIGHT_NORMAL + fWeight * ((WEIGHT_BLACK - 
WEIGHT_NORMAL)/0.68));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Non-portable configure.ac

[Jan-Marek Glogowski]

Am 22.02.2018 um 18:36 schrieb Sander Maijers:
> Note that checkbashisms 2.17.12-1 failed to catch this when I debugged
> this issue.
> 
> https://www.archlinux.org/packages/community/any/checkbashisms/
> 
> Also note that on Arch Linux, I used dash 0.5.9.1-1, whereas Debian only
> has various older versions
> 
> https://packages.debian.org/search?keywords=dash
> 
> Running shellcheck and checkbashisms regularly is advisable even for
> autoconf generated scripts.

On my Ubuntu I also have sh -> dash. But I guess, like most people, I
use autogen.sh to run configure with flags from autogen.input.

And autogen.sh is really a Perl script, and Perls system call runs
configure by calling "bash ./configure …". That's probably why nobody
caught this yet. Now I have no idea why Perls system function uses bash
as shell…

Jan-Marek
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: vcl/inc vcl/osx vcl/source

[Tor Lillqvist]

 vcl/inc/salinst.hxx   |4 
 vcl/osx/salinst.cxx   |3 +++
 vcl/source/app/svmain.cxx |4 
 3 files changed, 11 insertions(+)

New commits:
commit 8bd289c43c34ab9258f4b08a0f3f6143dc710e4e
Author: Tor Lillqvist 
Date:   Thu Feb 22 12:40:26 2018 +0200

tdf#103690: Set up notifications only after VCL has been initialised

On some Macs, it seems that LibreOffice (or any app?) gets an
NSApplicationDidChangeScreenParametersNotification as soon as it has
started and asked for such a notification. Our handler for that
notification assumes that VCL is initialised. Thus we should not ask
for such notifications before VCL has been initialised.

I could not reproduce the reported crash with an unmodified
LibreOffice, only after inserting a sleep after the notifications had
been set up. But I am fairly sure this change fixes the problem.

Change-Id: I18d342eb7dc0c77cb7fc8623756bead65a1bd329
Reviewed-on: https://gerrit.libreoffice.org/50164
Tested-by: Jenkins 
Reviewed-by: Tor Lillqvist 

diff --git a/vcl/inc/salinst.hxx b/vcl/inc/salinst.hxx
index 1eadc7ac382f..600f8ddfb8b3 100644
--- a/vcl/inc/salinst.hxx
+++ b/vcl/inc/salinst.hxx
@@ -205,6 +205,10 @@ void DeInitSalData();   // called from 
Application-Dtor
 
 void InitSalMain();
 
+#ifdef MACOSX
+void postInitVCLinitNSApp();
+#endif
+
 #endif // INCLUDED_VCL_INC_SALINST_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/osx/salinst.cxx b/vcl/osx/salinst.cxx
index 48eafa5eac1a..e008357b3641 100644
--- a/vcl/osx/salinst.cxx
+++ b/vcl/osx/salinst.cxx
@@ -157,7 +157,10 @@ static void initNSApp()
 
 // activate our delegate methods
 [NSApp setDelegate: NSApp];
+}
 
+void postInitVCLinitNSApp()
+{
 [[NSNotificationCenter defaultCenter] addObserver: NSApp
   selector: 
@selector(systemColorsChanged:)
   name: 
NSSystemColorsDidChangeNotification
diff --git a/vcl/source/app/svmain.cxx b/vcl/source/app/svmain.cxx
index 500eb3060c19..f44fd566aabc 100644
--- a/vcl/source/app/svmain.cxx
+++ b/vcl/source/app/svmain.cxx
@@ -187,6 +187,10 @@ int ImplSVMain()
 
 bool bInit = isInitVCL() || InitVCL();
 
+#ifdef MACOSX
+postInitVCLinitNSApp();
+#endif
+
 if( bInit )
 {
 // call application main
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-6.0.2.1'

[Xisco Fauli]

Tag 'libreoffice-6.0.2.1' created by Xisco Fauli  
at 2018-02-22 17:43 +

Tag libreoffice-6.0.2.1
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAABAgAGBQJajwE8AAoJEPQ0oe+v7q6j2jIP/0avKkp6grmGm8451DN5Ojuw
SBDxl4JVeFl57dlLjYR2v5487jl8332ezdmont5eShBwR8az6Px+oa5PcR9xv1Qk
it7wLO5epnnVYiBihSqUwWBbgN5Nk3nncLoPRaIr3hea4tTU1gu8VIU84sAZVqSI
sTQgC6TomLLsaO2y0LAbyFdq+mmFj6VJ+G4OR+xY2H2IpmqzWPj5Q71dx/zpGJqu
O+2rHoVf5GAUDyvxXpGwkNVpWQmhTXd+/mft7fpFWtYNNuWwDd1Vfs0NrWEheAIX
0oAh1iuXoXOZnRSeee1wdIAIlGgT4D+GWVwsu5rS5xEUfydooh5zBNDbd08rvGPa
0mELYSkv4If/mMsiQNT6YlA8DL4BdPo/gD8IoanCALAonvz2entXK+jLYjfW8wQ9
QXuMY9Vj73KcEk0XXj6kWxbPSfh7LmINO39VZEQV+WMFi801N211i4NcY+fiWnrQ
1LobKjSTmtIFp9kKXoywbvFhHRUcj4Hrkq1Oo33QNYQv7riYwyBK1A6o1YD10B5s
6vKkZvUm+Qhw+jCXzZ6agkTv85JzoROd1zyg5SGd9kFxXDcWB/83wCy+DeK+8g7b
CFaJ0hxmSx34/ZyubAVkzyC0nG+vhu3xQeD8d/4l8tO063ThjH1db3Ugrrw+yUND
Dcws3NEQEyWSi/lE6yBs
=Uw/b
-END PGP SIGNATURE-

Changes since libreoffice-6-0-branch-point-21:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-6.0.2.1'

[Xisco Fauli]

Tag 'libreoffice-6.0.2.1' created by Xisco Fauli  
at 2018-02-22 17:43 +

Tag libreoffice-6.0.2.1
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAABAgAGBQJajwE8AAoJEPQ0oe+v7q6jSl8P/25hLKYHc3TuH2a7ndWUx/TP
ZWrgziaLtb/d82+rffYZBLY+WRlg/gStr/pCZX7lYvmMEdGHmWnu+2/ECAwEOPNI
+m8A8/FmKBjQOJRp/FERvn/ylLXDzLSrlpNLT9jBUGYg/cHN2OFSAvBVIQhude1k
2qhiKOwhUmhSZrUxr4jV7d2hlmSFOczaQF5zU3EdvshTUwhSetv9I/ky3Sij+zsp
/wSYdAsniusCXQD275upsUlNn0tulzGmS0W7y6XhTvDFtWfLvKRwIUZ/ci3xYDJo
tIE8KpZbf+ML03hTwIpStw1lm+GDu70gs9CByN99yHr5C6x8xlTd4/kSrdJ+p/+0
jc9r5Ts8o2DjiuYSrfBsADcVEv1CwPEuArGqeJq5pmB7h+e1u1fX5xDFP00DKiBX
oQDPqpp7RZt3YRvCELJXTqMFn+tGucOofaVYYjQc2B7qgyqxNPXcunczuAGpVUVO
7EwfbiWsQ2ojLevXWW3GQn9exonya5bmNSGzIUW/++NNz71BBLc2uCNGO6hjznYS
hcmZJKdNtQlIiTgB0EObMs87r/DJEddak7lQNcTiS4rr5PDWnVtVxIyjngJEdAlI
UP2s7mo6U7SsUDy6eNf/9l+ldCDFjgSDr6uGnlNW44fLBtftrSE11QUao6amqUvn
GcNhekZJTv2UKYFTd+vg
=2f7L
-END PGP SIGNATURE-

Changes since libreoffice-6-0-branch-point-652:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-6.0.2.1'

[Xisco Fauli]

Tag 'libreoffice-6.0.2.1' created by Xisco Fauli  
at 2018-02-22 17:43 +

Tag libreoffice-6.0.2.1
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAABAgAGBQJajwE4AAoJEPQ0oe+v7q6jOkQQAJCJqdMuIgnuk0PDZIplUS3q
jgbHBgdWf79vdRo24z7SMoR0PhFYmdVawZp84+UyOqF/qcXGOU8BKoogffuwnp/2
BSnOZyp5gcxQiyQYfTdKYPx90ARhQso+jKEiAGqWEtJ+Osf0LJi0GThzSNwVTsH/
ZwRUf33ry5jznc0ZPIZDX42jacdN4Lg5SCGcsrExy7K4EglsnjMU59+ZtHZ3P8U/
LxcQekF+DdvoT9wzvdAOqhREpothXexGNe1JzRo+DxZsnLJN1R0dnhQq0aiszsCZ
L95M3zkYP4zJhuJXyw3/gftgxiWcc6gYdNZCi7Ia79T2KjPgsIAh4PLlkoz5e5cR
amopq0czbz7C4lx/AxQPvcsdq0T13DzhRZ7PTyJYGZPVaFByz+NwpZ1wZKkRN8EL
8SVozEPTTa2c19/2Lyuw1xw6g8wmZZF+Z+ceQt0zlfbMTp0fcFMHKcRKrN3f3RPx
zDfvHSsrVHLRJZP7/zXEgHpaJoPWFM5YThWG5bObvGgDrJi53wlUnZ2i7XQmvilX
OQfzMhu4xaSIJnHWqN6G6L5c/73mqfY6D1LPJEQY9irE82bx46T1xsUewo+r1GQm
Hz4PJSWL+RPYQZx02awc36YEZ2uCdZblf4/DrWbKKhXheARt4cQiVI1ENWWmWx7H
3dTk6Q+Bco5fI/B+BO+G
=An+3
-END PGP SIGNATURE-

Changes since libreoffice-6-0-branch-point-11:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-6.0.2.1'

[Xisco Fauli]

Tag 'libreoffice-6.0.2.1' created by Xisco Fauli  
at 2018-02-22 17:43 +

Tag libreoffice-6.0.2.1
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAABAgAGBQJajwE8AAoJEPQ0oe+v7q6jiS8P/3UDiBiwdLthO8JcxqopfEiP
wSpy30bb9MX229r7RX/2XLMvp34GeiRHQi6nCNEjPpPPjBIB5U0nA5wR5HA8ka2F
2MGOp8b4uunYQ/5UFtdTnScpfiLgPabexBT7GJCtqZXkB6tQ/XUCwx6NbZMTY8MA
6KGX56TY6xs7ExnfXgOFziTTLRkzuS0rA8N1XzyZyJ90kKSEGjLn5tnSso53L989
MoDYsWXU6Ewtck6/gJKgaSyzAViLE+PPfMji8Igu4bymZSWmH1M3wsamR3XfrWNA
4kyYXwfRcrDxbtgC1FoWFfeFMSs/6EkIcGJ8vnNIy1Dki6qs+6BHLsQuRfbixWFv
j63qVAKCoA38FX6VQpSuaRHF+Wzd9mDeYvOwCpHjE0vzRylndp0WN6yUC3OeR6hI
E1Ad0ngw0ba1Frc/U3t81eJ/AkwdRLP3x5x5i6IUohsjG0c18++Hnh7eI7lk1qHN
dOaUxcCCbq9p2tN7DRe7hPmcjthVFXbbrfa0T+10bmvgAsRUJoj0JCOluM/ErUKw
0+6wPkMa9oH+GGFR/c35Es6ZYcH3rvJVTKEMGSShHfDsAWKnGXGU3xwTICibnwbu
dRGZpdAzj3eePmrUBFZar1pb7B9osFOlVWOqHdecorgDntX435BxAh54amSwjSgE
ueNGTVjFcW5jq92lpxnR
=2rK0
-END PGP SIGNATURE-

Changes since libreoffice-6-0-branch-point-41:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0-2' - configure.ac

[Xisco Fauli]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7707c5f842de27c9f33f65b6641d88a3abdb7e2b
Author: Xisco Fauli 
Date:   Thu Feb 22 18:45:41 2018 +0100

bump product version to 6.0.2.1.0+

Change-Id: I497c530fff78ffaf2b545a1acf7eae30134f3b04

diff --git a/configure.ac b/configure.ac
index dcba0de5d5b1..bb8c7ca3ded3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[6.0.2.0.0+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[6.0.2.1.0+],[],[],[http://documentfoundation.org/])
 
 AC_PREREQ([2.59])
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Non-portable configure.ac

[Sander Maijers]

Thanks!

Note that checkbashisms 2.17.12-1 failed to catch this when I debugged 
this issue.


https://www.archlinux.org/packages/community/any/checkbashisms/

Also note that on Arch Linux, I used dash 0.5.9.1-1, whereas Debian only 
has various older versions


https://packages.debian.org/search?keywords=dash

Running shellcheck and checkbashisms regularly is advisable even for 
autoconf generated scripts.



On 22-02-18 12:07, Eike Rathke wrote:

Hi Sander,

On Wednesday, 2018-02-21 14:03:49 +0100, Sander Maijers wrote:


I have set dash as /bin/sh.

"Funny", because Debian has dash there as well and no problem.

Anyway.. this


./configure fails due a syntax error, since `${PRODUCTNAME// /}` not a
portable syntax.

has been changed to
PRODUCTNAME_WITHOUT_SPACES=$(printf %s "$PRODUCTNAME" | sed 's/ //g')

on master.

   Eike



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - configure.ac

[Xisco Fauli]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0de921a90343a7b35612fdf85ae69657f1eefe82
Author: Xisco Fauli 
Date:   Thu Feb 22 18:34:23 2018 +0100

bump product version to 6.0.3.0.0+

Change-Id: Ia3299fda6e1639e21b21030b2f4b1cf6506956ae

diff --git a/configure.ac b/configure.ac
index dcba0de5d5b1..289cf2911c93 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[6.0.2.0.0+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[6.0.3.0.0+],[],[],[http://documentfoundation.org/])
 
 AC_PREREQ([2.59])
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'libreoffice-6-0-2'

[Xisco Fauli]

New branch 'libreoffice-6-0-2' available with the following commits:
commit 38bcd7a89c6ae0e9f64fa25cf6620bbb140ca88a
Author: Xisco Fauli 
Date:   Thu Feb 22 18:28:26 2018 +0100

Branch libreoffice-6-0-2

This is 'libreoffice-6-0-2' - the stable branch for the 6.0.2 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 6.0.x release,
please use the 'libreoffice-6-0' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: I5af299610d96df788695c84809a7e25c64b4ffb9

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'libreoffice-6-0-2'

[Xisco Fauli]

New branch 'libreoffice-6-0-2' available with the following commits:
commit 00d890565744475637cd3f40f44fe01c199c2616
Author: Xisco Fauli 
Date:   Thu Feb 22 18:27:31 2018 +0100

Branch libreoffice-6-0-2

This is 'libreoffice-6-0-2' - the stable branch for the 6.0.2 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 6.0.x release,
please use the 'libreoffice-6-0' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: Idb586ec6b186507ec2ef1edf0c68667d5d114241

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Changes to 'libreoffice-6-0-2'

[Xisco Fauli]

New branch 'libreoffice-6-0-2' available with the following commits:
commit bbd8b54e3c79f8ac17248ee5d633d7199d720b8f
Author: Xisco Fauli 
Date:   Thu Feb 22 18:27:32 2018 +0100

Branch libreoffice-6-0-2

This is 'libreoffice-6-0-2' - the stable branch for the 6.0.2 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 6.0.x release,
please use the 'libreoffice-6-0' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: I4341e528dcaf846a38378f35fe979496a466d8e9

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: Changes to 'libreoffice-6-0-2'

[Xisco Fauli]

New branch 'libreoffice-6-0-2' available with the following commits:
commit 56a4ef0f210c057a3b011d248429e7ec8728d609
Author: Xisco Fauli 
Date:   Thu Feb 22 18:27:31 2018 +0100

Branch libreoffice-6-0-2

This is 'libreoffice-6-0-2' - the stable branch for the 6.0.2 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 6.0.x release,
please use the 'libreoffice-6-0' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: I6c8ef3414b28a0b41a35f984fbc207bdf1c8a932

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Invoking gla11y [was: core.git: bin/gla11y config_host.mk.in configure.ac solenv/gbuild]

[Samuel Thibault]

Stephan Bergmann, on jeu. 22 févr. 2018 18:03:28 +0100, wrote:
> Does that make sense?

Yes, thanks for making these clear :)

Samuel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sfx2/source

[Mike Kaganski]

 sfx2/source/dialog/tabdlg.cxx |   43 +-
 1 file changed, 14 insertions(+), 29 deletions(-)

New commits:
commit d4b4f5f1f4e452cb9f4a0e202b57c0a8610c1cad
Author: Mike Kaganski 
Date:   Thu Feb 22 11:45:24 2018 +0100

Remove useless special handling of single-value ranges

... as they are treated by generic code just fine.
A check added to guard against overflow (0x + 1 -> 0).

Change-Id: Ibef85191eab82002981e12f83f313f3d122da74c
Reviewed-on: https://gerrit.libreoffice.org/50163
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/sfx2/source/dialog/tabdlg.cxx b/sfx2/source/dialog/tabdlg.cxx
index 22d03b7073af..f6fd5f90299f 100644
--- a/sfx2/source/dialog/tabdlg.cxx
+++ b/sfx2/source/dialog/tabdlg.cxx
@@ -994,41 +994,26 @@ IMPL_LINK_NOARG(SfxTabDialog, BaseFmtHdl, Button*, void)
 {
 const sal_uInt16* pU = pTmpRanges + 1;
 
-if ( *pTmpRanges == *pU )
+// Correct Range with multiple values
+sal_uInt16 nTmp = *pTmpRanges, nTmpEnd = *pU;
+DBG_ASSERT( nTmp <= nTmpEnd, "Range is sorted the wrong way" );
+
+if ( nTmp > nTmpEnd )
+{
+// If really sorted wrongly, then set new
+std::swap(nTmp, nTmpEnd);
+}
+
+while ( nTmp && nTmp <= nTmpEnd ) // guard against overflow
 {
-// Range which two identical values -> only set one Item
-sal_uInt16 nWh = pPool->GetWhich( *pTmpRanges );
+// Iterate over the Range and set the Items
+sal_uInt16 nWh = pPool->GetWhich( nTmp );
 m_pExampleSet->ClearItem( nWh );
 aTmpSet.ClearItem( nWh );
 // At the Outset of InvalidateItem,
 // so that the change takes effect
 m_pOutSet->InvalidateItem( nWh );
-}
-else
-{
-// Correct Range with multiple values
-sal_uInt16 nTmp = *pTmpRanges, nTmpEnd = *pU;
-DBG_ASSERT( nTmp <= nTmpEnd, "Range is sorted the wrong way" );
-
-if ( nTmp > nTmpEnd )
-{
-// If really sorted wrongly, then set new
-sal_uInt16 nTmp1 = nTmp;
-nTmp = nTmpEnd;
-nTmpEnd = nTmp1;
-}
-
-while ( nTmp <= nTmpEnd )
-{
-// Iterate over the Range and set the Items
-sal_uInt16 nWh = pPool->GetWhich( nTmp );
-m_pExampleSet->ClearItem( nWh );
-aTmpSet.ClearItem( nWh );
-// At the Outset of InvalidateItem,
-// so that the change takes effect
-m_pOutSet->InvalidateItem( nWh );
-nTmp++;
-}
+nTmp++;
 }
 // Go to the next pair
 pTmpRanges += 2;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: solenv/gbuild

[Stephan Bergmann]

 solenv/gbuild/TargetLocations.mk |1 -
 solenv/gbuild/UIConfig.mk|8 ++--
 2 files changed, 2 insertions(+), 7 deletions(-)

New commits:
commit b7e8ae27f85aea1e924a28c7facfd82289b9e6a9
Author: Stephan Bergmann 
Date:   Thu Feb 22 09:46:07 2018 +0100

Fix clean-up of gb_UIConfig_get_a11yerrors_target

The old code tried to remove non-exisiting *.a11yerrors files corresponding 
to a
UIConfig's individual *.ui files, not the one single *.a11yerrors file
corresponding to the UIConfig itself.

Also, there's no need to have a UIA11YErrorsTarget merely for clean-up.  
Just
do that clean-up as part of gb_UIConfig_get_clean_target.

Change-Id: I6676f08496254398801bb75172c1326d1c843071
Reviewed-on: https://gerrit.libreoffice.org/50156
Reviewed-by: Samuel Thibault 
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/solenv/gbuild/TargetLocations.mk b/solenv/gbuild/TargetLocations.mk
index 06ec8bea0f43..4911b1b8c137 100644
--- a/solenv/gbuild/TargetLocations.mk
+++ b/solenv/gbuild/TargetLocations.mk
@@ -281,7 +281,6 @@ $(eval $(call gb_Helper_make_clean_targets,\
CppunitTestFakeExecutable \
CustomTarget \
ExternalProject \
-   UIA11YErrorsTarget \
UIConfig \
UIImageListTarget \
UIMenubarTarget \
diff --git a/solenv/gbuild/UIConfig.mk b/solenv/gbuild/UIConfig.mk
index 458d426ce413..e7de81a25839 100644
--- a/solenv/gbuild/UIConfig.mk
+++ b/solenv/gbuild/UIConfig.mk
@@ -117,6 +117,8 @@ $(call gb_UIConfig_get_clean_target,%) :
$(call gb_Helper_abbreviate_dirs,\
rm -f $(call gb_UIConfig_get_target,$*) $(call 
gb_UIConfig_get_imagelist_target,$*) \
)
+   $(call gb_Output_announce,$*,$(false),UIA,2)
+   rm -f $(call gb_UIConfig_get_a11yerrors_target,$*)
 
 define gb_UIConfig_a11yerrors__command
 $(call gb_Output_announce,$(2),$(true),UIA,1)
@@ -132,11 +134,6 @@ else
touch $@
 endif
 
-.PHONY : $(call gb_UIA11YErrorsTarget_get_clean_target,%)
-$(call gb_UIA11YErrorsTarget_get_clean_target,%) :
-   $(call gb_Output_announce,$*,$(false),UIA,2)
-   rm -f $(call gb_UIConfig_get_a11yerrors_target,$*)
-
 gb_UIConfig_get_packagename = UIConfig/$(1)
 gb_UIConfig_get_packagesetname = UIConfig/$(1)
 
@@ -190,7 +187,6 @@ $(call gb_UIConfig_get_imagelist_target,$(1)) : $(call 
gb_UIImageListTarget_get_
 $(call gb_UIConfig_get_clean_target,$(1)) : $(call 
gb_UIImageListTarget_get_clean_target,$(2))
 
 $(call gb_UIConfig_get_a11yerrors_target,$(1)) : UIFILES += $(SRCDIR)/$(2).ui
-$(call gb_UIConfig_get_clean_target,$(1)) : $(call 
gb_UIA11YErrorsTarget_get_clean_target,$(2))
 
 endef
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - solenv/gbuild

[Rico Tzschichholz]

 solenv/gbuild/extensions/post_PackageInfo.mk |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit e27c67107d128d1421e2c09d81c99f43ad0d45a4
Author: Rico Tzschichholz 
Date:   Thu Feb 22 14:21:50 2018 +0100

solenv: Update gb_PackageInfo_emit_l10n_for_one_lang

Add cjk_*, ctl_* and ctlseqcheck_$LANG.xcd files to install list

Change-Id: I2c56cf2af3cc444cb7075740a981b6954950e5f5
Reviewed-on: https://gerrit.libreoffice.org/50181
Reviewed-by: Michael Stahl 
Tested-by: Jenkins 

diff --git a/solenv/gbuild/extensions/post_PackageInfo.mk 
b/solenv/gbuild/extensions/post_PackageInfo.mk
index 1abd6e241d9f..331eeb89e194 100644
--- a/solenv/gbuild/extensions/post_PackageInfo.mk
+++ b/solenv/gbuild/extensions/post_PackageInfo.mk
@@ -69,6 +69,9 @@ define gb_PackageInfo_emit_l10n_for_one_lang
 $(if $(filter-out qtz en-US,$(1)),$(foreach packagedir,$(patsubst 
%/,%,$(gb_AllLangPackage_ALLDIRS)),$(call 
gb_PackageInfo_emit_l10n_for_one_alllangpackage,$(packagedir),$(1
 $(if $(filter $(gb_AllLangMoTarget_LANGS),$(1)),$(foreach 
target,$(gb_AllLangMoTarget_REGISTERED),$(call 
gb_PackageInfo_emit_l10n_for_one_mo,$(target),$(1
 $(if $(filter $(gb_Configuration_LANGS),$(1)),$(foreach configfile,Langpack- 
res/fcfg_langpack_ res/registry_,$(call 
gb_PackageInfo_emit_l10n_for_one_configfile,$(1),$(configfile
+$(if $(filter $(gb_CJK_LANGS),$(1)),$(foreach configfile,cjk_,$(call 
gb_PackageInfo_emit_l10n_for_one_configfile,$(1),$(configfile
+$(if $(filter $(gb_CTL_LANGS),$(1)),$(foreach configfile,ctl_,$(call 
gb_PackageInfo_emit_l10n_for_one_configfile,$(1),$(configfile
+$(if $(filter $(gb_CTLSEQCHECK_LANGS),$(1)),$(foreach 
configfile,ctlseqcheck_,$(call 
gb_PackageInfo_emit_l10n_for_one_configfile,$(1),$(configfile
 @echo "$(foreach suf,executables libraries 
files,$(gb_PackageInfo_get_target)/l10n-$(1).$(suf)) \\" >> 
$(WORKDIR)/Dep/packageinfo.d
 
 endef
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Invoking gla11y [was: core.git: bin/gla11y config_host.mk.in configure.ac solenv/gbuild]

[Stephan Bergmann]

On 22.02.2018 17:08, Samuel Thibault wrote:

Stephan Bergmann, on jeu. 22 févr. 2018 16:43:37 +0100, wrote:

On 22.02.2018 13:54, Samuel Thibault wrote:

Miklos Vajna, on jeu. 22 févr. 2018 09:53:43 +0100, wrote:

On Wed, Feb 21, 2018 at 10:11:18AM +0100, Samuel Thibault  
wrote:

Rene Engelhard, on mer. 21 févr. 2018 10:02:08 +0100, wrote:

OK, thanks - and then I wonder why this is ran in "normal" UIConfig targets and
not only in make check...

For the "error" cases (-W none), it makes sense:

« Add to the build process error checking (only the hard errors such as
bogus target names). »

That's really the kind of issues one should get as soon as compilation
time.

Later on I'll add a call in "make check" time for the warnings.


For source code we have warnings for these linter type problems


Err, these are not just "linter type problems". They are undefined
references, just like undefined C references. So the failure belongs to
compilation time. If somebody modifies a .ui file in a way that gets
such undefined reference, compilation itself should really fail, just
like it does when a variable defintion is missing.

The "make check" warnings I mentioned above are *other* kinds of issues,
which would indeed only be tested within make check, made warnings by
default, and turned into errors by Jenkins.


I don't understand the "turned into errors by Jenkins" part.  How would that
be done?

(And `make check` should ideally be "silent".  We do not want it to produce
any non-fatal warnings.)


Well, perhaps I didn't understand what Miklos meant, then.

Miklos Vajna, on jeu. 22 févr. 2018 09:53:43 +0100, wrote:

For source code we have warnings for these linter type problems and then
--enable-werror (Jenkins uses it) turns those warnings into errors.

Probably the best would be if the .ui checker would follow the same
pattern, instead of running it twice during 'make check' (which is a
superset of 'make').


What I had understood from that was that at "make" time there are only
compiler errors, and at "make check" time there are linter warnings, and
in Jenkins, --enable-werror is used to turn these warnings into errors.

Now that I re-read it with what you said, I understand that

- at "make" time there are some compiler warnings which are turned into
errors in Jenkins with --enable-werror
- Miklos suggested that we only call gla11y at "make" time, and not a
second time at "make check" time.

I'm fine with emitting accessibility warnings at "make" time and let
Jenkins turning them into errors, I just thought from the discussions at
FOSDEM that they should be done at "make check" time.


`make` vs. `make check` is completely orthogonal to 
--{en,dis}able-werror:  `make check` just runs more tests than `make`; 
some tests are expensive (and some are a bit brittle), so there are 
reasons why some builds want to be done without running the extra tests 
(though in an ideal world, they would always be included).


--enable-werror causes C/C++ compiler warnings to be turned into build 
failures.  We have a policy of a warning-free git master (and release 
branches), so that developers can --enable-werror and immediately find 
new issues they are introducing for which compilers emit warnings.  (And 
to keep master warning free on all platforms, Gerrit/Jenkins builds are 
also done with --enable-werror.)  Again, in an ideal world, 
--enable-werror would always be enabled for every build, but there are 
practical reasons (like some compiler emitting some hard-to-silence 
warnings only in -O2 production builds) why some builds use 
--disable-werror.


Now, gla11y shall do two things:

1  Find newly introduced bugs in .ui files.  Those should always cause 
the build to fail, regardless of `make` vs. `make check` or 
--enable-werror vs. --disable-werror.  I see no reason to have a build 
mode in which those bugs are either not detected at all, or do not fail 
the build.


2  Find existing bugs in .ui files (and maybe also minor newly 
introduced issues that are not severe enough to be considered fatal bugs 
upfront; I do not know).  Those should initially be suppressed by (1), 
but should eventually all be fixed (IIUC).  So for somebody working on 
fixing those issues, it would be useful to have a way to get a report of 
all those issues.  Maybe a new make target would be useful for that.


Does that make sense?
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Implementing accessibility non-regression check tool

[Samuel Thibault]

Stephan Bergmann, on jeu. 22 févr. 2018 16:36:44 +0100, wrote:
>  I have e.g. no idea whether/how
> it's possible to tell that lxml setup.py which libxml2/libxslt to use.

That was indeed a missing part in my patch, it's a mere setup.py option
which does work fine.

> (And whether e.g. the external/{libxml2,libxslt} case will require
> some extra scaffolding at the calling site of gla11y in UIConfig.mk.)

This is already handled with LD_LIBRARY_PATH on programs/

> Just be warned. ;)

Sure, I'm not saying that the plumbing is completely trivial :)

Samuel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Implementing accessibility non-regression check tool

[Samuel Thibault]

Michael Stahl, on jeu. 22 févr. 2018 16:59:21 +0100, wrote:
> On 22.02.2018 16:36, Stephan Bergmann wrote:
> > I was more hoping that there might be an established plain Python option 
> > for XML processing?
> 
> FWIW, there is at least xml.etree.ElementTree and xml.dom.minidom in the
> CPython bundled libs.
> 
> https://docs.python.org/3/library/xml.etree.elementtree.html
> https://docs.python.org/3/library/xml.dom.minidom.html

An issue with these is that they do not keep source line numbers of the
nodes.  That's really concerning for providing useful information to
the programmer.  We will be bothering them with new warnings that they
will have to learn about ; if we don't provide with line numbers, they
will get rightfully angry :) We could fallback to only providing the
class and id of the suspected widget. In some cases we have seen no id
defined, and thus no pointer to give to the programmer.

Samuel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ad1a885e3b34714980121f7ef273cf59f3f76e12
Author: Olivier Hallot 
Date:   Thu Feb 22 13:13:31 2018 -0300

Updated core
Project: help  235783d1ed47620748fe297f5ff5133121fbe75e

tdf#114995 CSV Link external data help page

Change-Id: I932bb17e0c599ea79dba950733e354e86f6efce4
Reviewed-on: https://gerrit.libreoffice.org/50193
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 75cf318614f7..235783d1ed47 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 75cf318614f73c93a51538a9508ccca2b47f82b1
+Subproject commit 235783d1ed47620748fe297f5ff5133121fbe75e
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[tagezi]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 01d64f4bee56f3db2348f29a24c9cd7325bb4ce2
Author: tagezi 
Date:   Sat Feb 17 17:47:10 2018 +0300

Updated core
Project: help  75cf318614f73c93a51538a9508ccca2b47f82b1

Deletion [Runtime] from names functions

[Runtime] was deleted
[Runtime - VBA] was replaced to [VBA]
Combination of words "runtime functions" and "runtime categiries"
was replaced to "functions" and "categiries" respectively

Change-Id: I1f03a5f2ef1697e216e144ecccbfb8942b315718
Reviewed-on: https://gerrit.libreoffice.org/49914
Tested-by: Olivier Hallot 
Reviewed-by: Sophie Gautier 
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 5339d3c91fb8..75cf318614f7 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 5339d3c91fb81ea593a96c5602b767d68aba623f
+Subproject commit 75cf318614f73c93a51538a9508ccca2b47f82b1
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Olivier Hallot]

 source/text/scalc/guide/rename_table.xhp |  144 +++
 1 file changed, 72 insertions(+), 72 deletions(-)

New commits:
commit 5339d3c91fb81ea593a96c5602b767d68aba623f
Author: Olivier Hallot 
Date:   Thu Feb 22 12:51:22 2018 -0300

tdf#115831 Review of rename sheet help page

Change-Id: Ibe2db947cd6a1ef52231013a6ecdb9efbf2e99a2
Reviewed-on: https://gerrit.libreoffice.org/50192
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/source/text/scalc/guide/rename_table.xhp 
b/source/text/scalc/guide/rename_table.xhp
index c750ca40a..0cebc5bcf 100644
--- a/source/text/scalc/guide/rename_table.xhp
+++ b/source/text/scalc/guide/rename_table.xhp
@@ -1,5 +1,6 @@
 
 
+
 
-
-
-  
-Renaming Sheets
-/text/scalc/guide/rename_table.xhp
-  
-
-
-
-
-
-  renaming;sheets
-  sheet tabs;renaming
-  tables;renaming
-  names; sheets
-
-mw made "renaming sheets" a two level entry.
+ -->
 
-Renaming 
Sheets 
 
-
-  
-Click the 
name of the sheet that you want to change.
-  
-  
-Open the 
context menu and choose the Rename Sheet command. A dialog box 
appears where you can enter a new name.
-  
-  
-Enter a new 
name for the sheet and click OK.
-  
-  
-Alternatively, hold down the Option key 
+
+  
+ Renaming Sheets
+ /text/scalc/guide/rename_table.xhp
+  
+   
+   
+renaming;sheets
+  sheet tabs;renaming
+  tables;renaming
+  names; sheets
+mw made "renaming sheets" a two level entry.
+Renaming 
Sheets
+
+Setting sheet names is an important feature to produce 
readable and understandable spreadsheets documents. To rename a sheet in your 
document:
+  
+ 
+Click on the sheet tab to select it.
+ 
+ 
+Open the context menu of the sheet tab and choose the 
Rename Sheet command. A dialog box appears where you can enter a 
new name.
+ 
+ 
+Enter a new name for the sheet and click 
OK.
+ 
+ 
+Alternatively, hold down the Option key
 Alt key and click 
on any sheet name and enter the new name directly.
-
-  
-
-Sheet 
names can contain almost any character. Some naming restrictions apply, the 
following characters are not allowed in sheet names:
-
-
-  
-colon :
-  
-  
-back slash \
-  
-  
-forward slash /
-  
-  
-question mark ?
-  
-  
-asterisk *
-  
-  
-left square bracket [
-  
-  
-right square bracket ]
-  
-  
-single quote ' as the first or last character of the 
name
-  
-In 
cell references, a sheet name has to be enclosed in single quotes ' if the name 
contains other characters than alphanumeric or underscore. A single quote 
contained within a name has to be escaped by doubling it (two single quotes). 
For example, you want to reference the cell A1 on a sheet with the following 
name:
-This 
year's sheet
-The 
reference must be enclosed in single quotes, and the one single quote inside 
the name must be doubled:
-'This 
year''s sheet'.A1
-The name of a 
sheet is independent of the name of the spreadsheet. You enter the spreadsheet 
name when you save it for the first time as a file. The document can contain up 
to 10,000 individual sheets, which can have different names.
-
-
-
-
-
-
+
+ 
+  
+  Sheet names can contain almost any character. Some naming 
restrictions apply, the following characters are not allowed in sheet 
names:
+  
+ 
+colon :
+ 
+ 
+back slash \
+ 
+ 
+forward slash /
+ 
+ 
+question mark ?
+ 
+ 
+asterisk *
+ 
+ 
+left square bracket [
+ 
+ 
+right square bracket ]
+ 
+ 
+single quote ' as the first or last character of the 
name
+ 
+  
+  In 
cell references, a sheet name must be enclosed in single quotes ' when the name 
contains other characters than alphanumeric or underscore. A single quote 
contained within a name has to be escaped by doubling it (two single 
quotes).
+  For example, you want to reference the cell A1 on a sheet with 
the following name:
+  This 
year's sheet
+  The reference must be enclosed in single quotes, and the one 
single quote inside the name must be doubled:
+  'This year''s sheet'.A1
+  The name of a 
sheet is independent of the name of the spreadsheet. You enter the spreadsheet 
name when you save it for the first time as a file.
+  The 
document can contain up to 10,000 individual sheets, which must have different 
names.
+  You can set a prefix for the names of new sheets you create. 
See this 
page of Calc options.
+  
+  New sheet names prefixing.
+ 
+  
+   
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https:/

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit dc646858a208e42cae39fb2c16c8c04eca91ee97
Author: Olivier Hallot 
Date:   Thu Feb 22 12:51:22 2018 -0300

Updated core
Project: help  5339d3c91fb81ea593a96c5602b767d68aba623f

tdf#115831 Review of rename sheet help page

Change-Id: Ibe2db947cd6a1ef52231013a6ecdb9efbf2e99a2
Reviewed-on: https://gerrit.libreoffice.org/50192
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 90671d8531b2..5339d3c91fb8 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 90671d8531b28cebf6129402932320a437cf4544
+Subproject commit 5339d3c91fb81ea593a96c5602b767d68aba623f
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: minutes of ESC call ...

[Thorsten Behrens]

Michael Meeks wrote:
> + go over the past budget ideas & cleanup as a base (Thorsten)
> 
First round done - see:

> * Budgeting (Thorsten)
> + collecting other wish-lists – cross-check with GSoC ideas
> + current ideas 
> list:https://wiki.documentfoundation.org/Development/Budget2018
> 
If people could please double-check that list & remove things that are
done or obsolete - and then we probably want to clone useful ideas to
the gsoc page (and vice versa).

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Invoking gla11y [was: core.git: bin/gla11y config_host.mk.in configure.ac solenv/gbuild]

[Samuel Thibault]

Stephan Bergmann, on jeu. 22 févr. 2018 16:43:37 +0100, wrote:
> On 22.02.2018 13:54, Samuel Thibault wrote:
> > Miklos Vajna, on jeu. 22 févr. 2018 09:53:43 +0100, wrote:
> > > On Wed, Feb 21, 2018 at 10:11:18AM +0100, Samuel Thibault 
> > >  wrote:
> > > > Rene Engelhard, on mer. 21 févr. 2018 10:02:08 +0100, wrote:
> > > > > OK, thanks - and then I wonder why this is ran in "normal" UIConfig 
> > > > > targets and
> > > > > not only in make check...
> > > > For the "error" cases (-W none), it makes sense:
> > > > 
> > > > « Add to the build process error checking (only the hard errors such as
> > > > bogus target names). »
> > > > 
> > > > That's really the kind of issues one should get as soon as compilation
> > > > time.
> > > > 
> > > > Later on I'll add a call in "make check" time for the warnings.
> > > 
> > > For source code we have warnings for these linter type problems
> > 
> > Err, these are not just "linter type problems". They are undefined
> > references, just like undefined C references. So the failure belongs to
> > compilation time. If somebody modifies a .ui file in a way that gets
> > such undefined reference, compilation itself should really fail, just
> > like it does when a variable defintion is missing.
> > 
> > The "make check" warnings I mentioned above are *other* kinds of issues,
> > which would indeed only be tested within make check, made warnings by
> > default, and turned into errors by Jenkins.
> 
> I don't understand the "turned into errors by Jenkins" part.  How would that
> be done?
> 
> (And `make check` should ideally be "silent".  We do not want it to produce
> any non-fatal warnings.)

Well, perhaps I didn't understand what Miklos meant, then.

Miklos Vajna, on jeu. 22 févr. 2018 09:53:43 +0100, wrote:
> For source code we have warnings for these linter type problems and then
> --enable-werror (Jenkins uses it) turns those warnings into errors.
> 
> Probably the best would be if the .ui checker would follow the same
> pattern, instead of running it twice during 'make check' (which is a
> superset of 'make').

What I had understood from that was that at "make" time there are only
compiler errors, and at "make check" time there are linter warnings, and
in Jenkins, --enable-werror is used to turn these warnings into errors.

Now that I re-read it with what you said, I understand that

- at "make" time there are some compiler warnings which are turned into
errors in Jenkins with --enable-werror
- Miklos suggested that we only call gla11y at "make" time, and not a
second time at "make check" time.

I'm fine with emitting accessibility warnings at "make" time and let
Jenkins turning them into errors, I just thought from the discussions at
FOSDEM that they should be done at "make check" time.

Samuel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: include/svx include/vcl sc/source sw/source

[Stephan Bergmann]

 include/svx/sidebar/AreaTransparencyGradientPopup.hxx |1 +
 include/vcl/syswin.hxx|2 --
 sc/source/ui/inc/navipi.hxx   |1 +
 sw/source/uibase/inc/convert.hxx  |1 +
 4 files changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 1888a602001c74b7da7e9c99cb78c9246714d8be
Author: Stephan Bergmann 
Date:   Thu Feb 22 09:13:25 2018 +0100

Remove unused forward declarations from vcl/syswin.hxx

Change-Id: Ide4990afa32ba4cc7851d0e7d3d8d1247eb27b3b
Reviewed-on: https://gerrit.libreoffice.org/50155
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/include/svx/sidebar/AreaTransparencyGradientPopup.hxx 
b/include/svx/sidebar/AreaTransparencyGradientPopup.hxx
index 5f23aa4b06ed..4004a0041267 100644
--- a/include/svx/sidebar/AreaTransparencyGradientPopup.hxx
+++ b/include/svx/sidebar/AreaTransparencyGradientPopup.hxx
@@ -24,6 +24,7 @@
 #include 
 #include 
 
+class VclContainer;
 class XFillFloatTransparenceItem;
 
 namespace svx { namespace sidebar {
diff --git a/include/vcl/syswin.hxx b/include/vcl/syswin.hxx
index 625143ebec6b..4a2088114fc6 100644
--- a/include/vcl/syswin.hxx
+++ b/include/vcl/syswin.hxx
@@ -28,11 +28,9 @@
 #include 
 #include 
 
-class ModalDialog;
 class MenuBar;
 class NotebookBar;
 class TaskPaneList;
-class VclContainer;
 
 #define ICON_LO_DEFAULT 1
 #define ICON_TEXT_DOCUMENT  2
diff --git a/sc/source/ui/inc/navipi.hxx b/sc/source/ui/inc/navipi.hxx
index dc62b5080d9f..1ee61b41a355 100644
--- a/sc/source/ui/inc/navipi.hxx
+++ b/sc/source/ui/inc/navipi.hxx
@@ -40,6 +40,7 @@ class ScNavigatorControllerItem;
 class ScNavigatorDialogWrapper;
 class ScNavigatorDlg;
 class ScNavigatorSettings;
+class VclContainer;
 
 #define SC_DROPMODE_URL 0
 #define SC_DROPMODE_LINK1
diff --git a/sw/source/uibase/inc/convert.hxx b/sw/source/uibase/inc/convert.hxx
index bb4177b976ce..faf7521a68d4 100644
--- a/sw/source/uibase/inc/convert.hxx
+++ b/sw/source/uibase/inc/convert.hxx
@@ -24,6 +24,7 @@
 #include 
 #include 
 
+class VclContainer;
 class SwTableAutoFormat;
 class SwView;
 class SwWrtShell;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Implementing accessibility non-regression check tool

[Michael Stahl]

On 22.02.2018 16:36, Stephan Bergmann wrote:
> I was more hoping that there might be an established plain Python option 
> for XML processing?

FWIW, there is at least xml.etree.ElementTree and xml.dom.minidom in the
CPython bundled libs.

https://docs.python.org/3/library/xml.etree.elementtree.html
https://docs.python.org/3/library/xml.dom.minidom.html

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: loleaflet/npm-shrinkwrap.json loleaflet/package.json

[Samuel Mehrbrodt]

 loleaflet/npm-shrinkwrap.json | 3293 --
 loleaflet/package.json|   11 
 2 files changed, 1914 insertions(+), 1390 deletions(-)

New commits:
commit 37e7e953043e8aecf7941a54d530d319dbefc119
Author: Samuel Mehrbrodt 
Date:   Thu Feb 22 16:23:55 2018 +0100

NPM Shrinkwrap: Upgrade to new format (v5)

Should be backwards compatible with npm 2,3 and 4

Change-Id: Ie40f39af4b6fb618916df33d9cdd2fc62e4bc592
Reviewed-on: https://gerrit.libreoffice.org/50191
Reviewed-by: pranavk 
Tested-by: pranavk 

diff --git a/loleaflet/npm-shrinkwrap.json b/loleaflet/npm-shrinkwrap.json
index 8c8d46ae..ffeb9e14 100644
--- a/loleaflet/npm-shrinkwrap.json
+++ b/loleaflet/npm-shrinkwrap.json
@@ -1,243 +1,363 @@
 {
   "name": "loleaflet",
   "version": "0.8.0-dev",
+  "lockfileVersion": 1,
+  "requires": true,
   "dependencies": {
 "autolinker": {
   "version": "1.4.3",
-  "from": "autolinker@latest",
-  "resolved": "./node_shrinkwrap/autolinker-1.4.3.tgz",
+  "resolved": 
"https://registry.npmjs.org/autolinker/-/autolinker-1.4.3.tgz";,
+  "integrity": "sha1-LmFQV8jjcTmabXeUmppq8k/kbfw=",
   "dev": true
 },
 "bootstrap": {
-  "version": "3.3.6",
-  "from": "node_shrinkwrap/bootstrap-3.3.6.tgz",
-  "resolved": "./node_shrinkwrap/bootstrap-3.3.6.tgz",
+  "version": "file:node_shrinkwrap/bootstrap-3.3.6.tgz",
+  "integrity": 
"sha512-XC+LTYJoVYHIalmjNcznwlZHY+YLhMJ9NPs8M2aEweugK7wMrto3h79POn7O5Vj/woDU/tjzmjyUbAd1HzSXIw==",
   "dev": true
 },
 "browserify": {
-  "version": "13.1.0",
-  "from": "node_shrinkwrap/browserify-13.1.0.tgz",
-  "resolved": "./node_shrinkwrap/browserify-13.1.0.tgz",
+  "version": "file:node_shrinkwrap/browserify-13.1.0.tgz",
+  "integrity": 
"sha512-i5iASp425UxqX6nhOfsxJVLmm+GKvPcapI8RsPixFSNQQbSbrZsYYLzPK1amobpeOuDF7nJDq/upZYkmw/C59w==",
   "dev": true,
+  "requires": {
+"JSONStream": "file:node_shrinkwrap/JSONStream-1.1.4.tgz",
+"assert": "file:node_shrinkwrap/assert-1.3.0.tgz",
+"browser-pack": "file:node_shrinkwrap/browser-pack-6.0.1.tgz",
+"browser-resolve": "file:node_shrinkwrap/browser-resolve-1.11.2.tgz",
+"browserify-zlib": "file:node_shrinkwrap/browserify-zlib-0.1.4.tgz",
+"buffer": "file:node_shrinkwrap/buffer-4.7.1.tgz",
+"concat-stream": "file:node_shrinkwrap/concat-stream-1.5.1.tgz",
+"console-browserify": 
"file:node_shrinkwrap/console-browserify-1.1.0.tgz",
+"constants-browserify": 
"file:node_shrinkwrap/constants-browserify-1.0.0.tgz",
+"crypto-browserify": 
"file:node_shrinkwrap/crypto-browserify-3.11.0.tgz",
+"defined": "file:node_shrinkwrap/defined-1.0.0.tgz",
+"deps-sort": "file:node_shrinkwrap/deps-sort-2.0.0.tgz",
+"domain-browser": "file:node_shrinkwrap/domain-browser-1.1.7.tgz",
+"duplexer2": "file:node_shrinkwrap/duplexer2-0.1.4.tgz",
+"events": "file:node_shrinkwrap/events-1.1.1.tgz",
+"glob": "file:node_shrinkwrap/glob-5.0.15.tgz",
+"has": "file:node_shrinkwrap/has-1.0.1.tgz",
+"htmlescape": "file:node_shrinkwrap/htmlescape-1.1.1.tgz",
+"https-browserify": "file:node_shrinkwrap/https-browserify-0.0.1.tgz",
+"inherits": "file:node_shrinkwrap/inherits-2.0.1.tgz",
+"insert-module-globals": 
"file:node_shrinkwrap/insert-module-globals-7.0.1.tgz",
+"labeled-stream-splicer": 
"file:node_shrinkwrap/labeled-stream-splicer-2.0.0.tgz",
+"module-deps": "file:node_shrinkwrap/module-deps-4.0.7.tgz",
+"os-browserify": "file:node_shrinkwrap/os-browserify-0.1.2.tgz",
+"parents": "file:node_shrinkwrap/parents-1.0.1.tgz",
+"path-browserify": "file:node_shrinkwrap/path-browserify-0.0.0.tgz",
+"process": "file:node_shrinkwrap/process-0.11.7.tgz",
+"punycode": "file:node_shrinkwrap/punycode-1.4.1.tgz",
+"querystring-es3": "file:node_shrinkwrap/querystring-es3-0.2.1.tgz",
+"read-only-stream": "file:node_shrinkwrap/read-only-stream-2.0.0.tgz",
+"readable-stream": "file:node_shrinkwrap/readable-stream-2.1.4.tgz",
+"resolve": "file:node_shrinkwrap/resolve-1.1.7.tgz",
+"shasum": "file:node_shrinkwrap/shasum-1.0.2.tgz",
+"shell-quote": "file:node_shrinkwrap/shell-quote-1.6.1.tgz",
+"stream-browserify": 
"file:node_shrinkwrap/stream-browserify-2.0.1.tgz",
+"stream-http": "file:node_shrinkwrap/stream-http-2.3.1.tgz",
+"string_decoder": "file:node_shrinkwrap/string_decoder-0.10.31.tgz",
+"subarg": "file:node_shrinkwrap/subarg-1.0.0.tgz",
+"syntax-error": "file:node_shrinkwrap/syntax-error-1.1.6.tgz",
+"through2": "file:node_shrinkwrap/through2-2.0.1.tgz",
+"timers-browserify": 
"file:node_shrinkwrap/timers-browserify-1.4.2.tgz",
+"tty-browserify": "file:node_shrinkwrap/tty-browserify-0.0.0.tgz",
+"url":

[Libreoffice-commits] core.git: solenv/gbuild

[Stephan Bergmann]

 solenv/gbuild/UIConfig.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9de93343afd95b991264ee3254bccbefc14761bc
Author: Stephan Bergmann 
Date:   Thu Feb 22 10:06:29 2018 +0100

gb_UIConfig_get_imagelist_target missing from clean target

Change-Id: I541bd57815bd66978326486b29165d0480d8a7b6
Reviewed-on: https://gerrit.libreoffice.org/50157
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/solenv/gbuild/UIConfig.mk b/solenv/gbuild/UIConfig.mk
index 640ead85d658..458d426ce413 100644
--- a/solenv/gbuild/UIConfig.mk
+++ b/solenv/gbuild/UIConfig.mk
@@ -115,7 +115,7 @@ $(call gb_UIConfig_get_imagelist_target,%) :
 $(call gb_UIConfig_get_clean_target,%) :
$(call gb_Output_announce,$*,$(false),UIC,2)
$(call gb_Helper_abbreviate_dirs,\
-   rm -f $(call gb_UIConfig_get_target,$*) \
+   rm -f $(call gb_UIConfig_get_target,$*) $(call 
gb_UIConfig_get_imagelist_target,$*) \
)
 
 define gb_UIConfig_a11yerrors__command
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Laurent BP]

 source/text/scalc/guide/rename_table.xhp |  142 +++
 1 file changed, 73 insertions(+), 69 deletions(-)

New commits:
commit 90671d8531b28cebf6129402932320a437cf4544
Author: Laurent BP 
Date:   Sun Feb 18 21:51:33 2018 +0100

tdf#115831 Renaming of sheet

Renaming of sheets have the same constraints whatever
the file format used.

Max number of sheets is 10,000. See tdf#3

File modified with HelpAuthoring

Change-Id: Iff4ecdea6cdfede9844475eaac31c27c9d903a3d
Reviewed-on: https://gerrit.libreoffice.org/49949
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/source/text/scalc/guide/rename_table.xhp 
b/source/text/scalc/guide/rename_table.xhp
index 8a18900cf..c750ca40a 100644
--- a/source/text/scalc/guide/rename_table.xhp
+++ b/source/text/scalc/guide/rename_table.xhp
@@ -1,6 +1,5 @@
 
 
-   
 
- 
-   
+-->
+
 
-  
- Renaming Sheets
- /text/scalc/guide/rename_table.xhp
-  
-   
-   
-renaming;sheets
-  sheet tabs;renaming
-  tables;renaming
-  names; sheets
-mw made "renaming sheets" a two level entry.
-Renaming 
Sheets
-
-  
- 
-Click the name of the sheet that you want to change.
- 
- 
-Open the context menu and choose the Rename Sheet 
command. A dialog box appears where you can enter a new name.
- 
- 
-Enter a new name for the sheet and click 
OK.
- 
- 
-Alternatively, hold down the Option key
+  
+Renaming Sheets
+/text/scalc/guide/rename_table.xhp
+  
+
+
+
+
+
+  renaming;sheets
+  sheet tabs;renaming
+  tables;renaming
+  names; sheets
+
+mw made "renaming sheets" a two level entry.
+
+Renaming 
Sheets 
+
+
+  
+Click the 
name of the sheet that you want to change.
+  
+  
+Open the 
context menu and choose the Rename Sheet command. A dialog box 
appears where you can enter a new name.
+  
+  
+Enter a new 
name for the sheet and click OK.
+  
+  
+Alternatively, hold down the Option key 
 Alt key and click 
on any sheet name and enter the new name directly.
-
- 
-  
-  Sheet names can contain almost any character. Some naming 
restrictions apply when you want to save the spreadsheet to Microsoft Excel 
format.
-  When saving to Microsoft Excel format, the following 
characters are not allowed in sheet names:
-  
- 
-colon :
- 
- 
-back slash \
- 
- 
-forward slash /
- 
- 
-question mark ?
- 
- 
-asterisk *
- 
- 
-left square bracket [
- 
- 
-right square bracket ]
- 
- 
-single quote ' as the first or last character of the 
name
- 
-  
-  In cell references, a sheet name has to be enclosed in single 
quotes ' if the name contains other characters than alphanumeric or underscore. 
A single quote contained within a name has to be escaped by doubling it (two 
single quotes). For example, you want to reference the cell A1 on a sheet with 
the following name:
-  This year's sheet
-  The reference must be enclosed in single quotes, and the one 
single quote inside the name must be doubled:
-  'This year''s sheet'.A1
-  The name 
of a sheet is independent of the name of the spreadsheet. You enter the 
spreadsheet name when you save it for the first time as a file. The document 
can contain up to 256 individual sheets, which can have different 
names.
-  
- 
-  
-   
+
+  
+
+Sheet 
names can contain almost any character. Some naming restrictions apply, the 
following characters are not allowed in sheet names:
+
+
+  
+colon :
+  
+  
+back slash \
+  
+  
+forward slash /
+  
+  
+question mark ?
+  
+  
+asterisk *
+  
+  
+left square bracket [
+  
+  
+right square bracket ]
+  
+  
+single quote ' as the first or last character of the 
name
+  
+In 
cell references, a sheet name has to be enclosed in single quotes ' if the name 
contains other characters than alphanumeric or underscore. A single quote 
contained within a name has to be escaped by doubling it (two single quotes). 
For example, you want to reference the cell A1 on a sheet with the following 
name:
+This 
year's sheet
+The 
reference must be enclosed in single quotes, and the one single quote inside 
the name must be doubled:
+'This 
year''s sheet'.A1
+The name of a 
sheet is independent of the name of the spreadsheet. You enter the spreadsheet 
name when you save it for the first time as a file. The document can contain up 
to 10,000 individual sheets, which can have different names.
+
+
+
+
+
+
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freede

[Libreoffice-commits] core.git: helpcontent2

[Laurent BP]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 136dfa3fe0bc66c2e1708e3b420e5836b02af11f
Author: Laurent BP 
Date:   Sun Feb 18 21:51:33 2018 +0100

Updated core
Project: help  90671d8531b28cebf6129402932320a437cf4544

tdf#115831 Renaming of sheet

Renaming of sheets have the same constraints whatever
the file format used.

Max number of sheets is 10,000. See tdf#3

File modified with HelpAuthoring

Change-Id: Iff4ecdea6cdfede9844475eaac31c27c9d903a3d
Reviewed-on: https://gerrit.libreoffice.org/49949
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index e256ca7d98c9..90671d8531b2 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit e256ca7d98c9e4da4e14bd405e648edf394a56c4
+Subproject commit 90671d8531b28cebf6129402932320a437cf4544
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'libreoffice-6-0-1'

[Christian Lohmaier]

New branch 'libreoffice-6-0-1' available with the following commits:
commit 8b911f0db1b245295711b5201c8aaea42fad4db1
Author: Christian Lohmaier 
Date:   Thu Feb 22 16:41:53 2018 +0100

Branch libreoffice-6-0-1

This is 'libreoffice-6-0-1' - the stable branch for the 6.0.1 release.

Change-Id: I73c6ff992a9cf02f62f7ab68d6d0b23fb1f5b45d

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [Libreoffice-commits] core.git: bin/gla11y config_host.mk.in configure.ac solenv/gbuild

[Stephan Bergmann]

On 22.02.2018 13:54, Samuel Thibault wrote:

Miklos Vajna, on jeu. 22 févr. 2018 09:53:43 +0100, wrote:

On Wed, Feb 21, 2018 at 10:11:18AM +0100, Samuel Thibault  
wrote:

Rene Engelhard, on mer. 21 févr. 2018 10:02:08 +0100, wrote:

OK, thanks - and then I wonder why this is ran in "normal" UIConfig targets and
not only in make check...

For the "error" cases (-W none), it makes sense:

« Add to the build process error checking (only the hard errors such as
bogus target names). »

That's really the kind of issues one should get as soon as compilation
time.

Later on I'll add a call in "make check" time for the warnings.


For source code we have warnings for these linter type problems


Err, these are not just "linter type problems". They are undefined
references, just like undefined C references. So the failure belongs to
compilation time. If somebody modifies a .ui file in a way that gets
such undefined reference, compilation itself should really fail, just
like it does when a variable defintion is missing.

The "make check" warnings I mentioned above are *other* kinds of issues,
which would indeed only be tested within make check, made warnings by
default, and turned into errors by Jenkins.


I don't understand the "turned into errors by Jenkins" part.  How would 
that be done?


(And `make check` should ideally be "silent".  We do not want it to 
produce any non-fatal warnings.)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] translations.git: Changes to 'libreoffice-6-0-1'

[Christian Lohmaier]

New branch 'libreoffice-6-0-1' available with the following commits:
commit ad5f6de64bdf8a336d353457d92e72d86be703df
Author: Christian Lohmaier 
Date:   Thu Feb 22 16:41:29 2018 +0100

Branch libreoffice-6-0-1

This is 'libreoffice-6-0-1' - the stable branch for the 6.0.1 release.

Change-Id: Id4e01b957f00409dd6908c4666f2f1870d1a373c

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: Changes to 'libreoffice-6-0-1'

[Christian Lohmaier]

New branch 'libreoffice-6-0-1' available with the following commits:
commit b13dd7e58817c6bce2f1c28abf212ee813ed9d67
Author: Christian Lohmaier 
Date:   Thu Feb 22 16:41:29 2018 +0100

Branch libreoffice-6-0-1

This is 'libreoffice-6-0-1' - the stable branch for the 6.0.1 release.

Change-Id: I982873cd5f22f8aa69b230ab90643426af97

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'libreoffice-6-0-1'

[Christian Lohmaier]

New branch 'libreoffice-6-0-1' available with the following commits:
commit 27780c9241d13cdb17b39bb73634629085022cc0
Author: Christian Lohmaier 
Date:   Thu Feb 22 16:41:29 2018 +0100

Branch libreoffice-6-0-1

This is 'libreoffice-6-0-1' - the stable branch for the 6.0.1 release.

Change-Id: Ib7b425b34fc931d1f6925994fa63bfafeb687bbf

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/dist

[Samuel Mehrbrodt]

 loleaflet/dist/errormessages.js |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 08ee839562c4f2e62570c9cecdbc0a6d3ce99b2f
Author: Samuel Mehrbrodt 
Date:   Thu Feb 22 14:50:26 2018 +0100

Improve message displayed when limit reached

Change-Id: I659d3e5156bc4ae8e6b30a7fd9f9957dd1a868ec
Reviewed-on: https://gerrit.libreoffice.org/50179
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/loleaflet/dist/errormessages.js b/loleaflet/dist/errormessages.js
index 36937c06..bdad9bb9 100644
--- a/loleaflet/dist/errormessages.js
+++ b/loleaflet/dist/errormessages.js
@@ -1,6 +1,6 @@
 exports.diskfull = _('No disk space left on server, please contact the server 
administrator to continue.');
 exports.emptyhosturl = _('The host URL is empty. The loolwsd server is 
probably misconfigured, please contact the administrator.');
-exports.limitreached = _('This is an unsupported version of {productname}. To 
avoid the impression that it is suitable for deployment in enterprises, this 
version is limited to {docs} documents, and {connections} connections.');
+exports.limitreached = _('This is an unsupported version of {productname}. To 
avoid the impression that it is suitable for deployment in enterprises, this 
message appears when more than {docs} documents or {connections} connections 
are in use concurrently');
 exports.infoandsupport = _('More information and support');
 exports.limitreachedprod = _('This service is limited to %0 documents, and %1 
connections total by the admin. This limit has been reached. Please try again 
later.');
 exports.serviceunavailable = _('Service is unavailable. Please try again later 
and report to your administrator if the issue persists.');
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Implementing accessibility non-regression check tool

[Stephan Bergmann]

On 22.02.2018 16:13, Samuel Thibault wrote:

Stephan Bergmann, on jeu. 22 févr. 2018 15:49:40 +0100, wrote:

That's four different ways how to build external/lxml, and slightly more
different ways (using the system lxml versus external/lxml) how to run the
gla11y tool in solenv/gbuild/UIConfig.mk.  And getting all those ways to
work, on the different platforms, will be hell.

[...]

(and the current building issue reported in gerrit 50115 is merely that
the current LO python3 module doesn't install any header file or such)


...and that's only the start, I guess. :)  I have e.g. no idea 
whether/how it's possible to tell that lxml setup.py which 
libxml2/libxslt to use.  (And whether e.g. the 
external/{libxml2,libxslt} case will require some extra scaffolding at 
the calling site of gla11y in UIConfig.mk.)


Just be warned. ;)


Isn't there another option to make that gla11y tool process XML data, one
that better matches LO's needs?


Well, we can reimplement the world for sure.

More seriously, we can of course at least depend only on libxml2. Not
depending on a higher-level library, however, means to have to
reimplement all the tree browsing functions needed to reach the pieces
of .ui files.  And avoiding python means, writing all of this in C?
That's neither fun nor easy to extend for further .ui checking.  The
eventual script we plan to integrate is only about 300 lines of python.
I'm scared by the maintenance of the equivalent without using python and
lxml more than maintenance of building lxml.


I was more hoping that there might be an established plain Python option 
for XML processing?


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

minutes of ESC call ...

[Michael Meeks]

* Present:
+ Stephan, Heiko, Michael M, Christian, Olivier, Miklos, Caolan
  Eike, Kendy, David, Kendy, Michael S, Jmux, Xisco, Thorsten

* Completed Action Items:

* Pending Action Items:
+ come up with a list of retiring committers to mail (Norbert)
+ go over the past budget ideas & cleanup as a base (Thorsten)

* Release Engineering update (Christian)
+ 6.0.2 - RC1 – tag Feb 2 0
+ will be done by Xisco later today
+ a 1 RC only release.
+ move back to normal branching further down the release.
+ problems with crash-reporter (Michael)
AI:  + do a branch on the tag (Christian)
+ 6.0 kill ? (Heiko)
+ on our download page – have access to 6.0
+ not sure it is a problem – hard to find (Cloph, Michael)
 + will disappear when builds go from the mirror directory.
+ 5.4.6 - RC1 tag Feb 27 next Tues. 
+ regular 2x RC schedule.
+ Android
+ roll out covers all users
+ crash reports looking much better
+ Online
+ should do a 6.0.2 RC1/final next week.

* Documentation (Olivier)
+ Catching up the help pages gap x features updates (ohallot, LaurentBP)
+ Published 3/8 Macro BASIC ref. cards (JF Nifenecker, ohallot)
   + written in French; now translated to English.
+ Resuming book review for Getting Started 6 (D. Barton, Jrodriguez, 
ohallot)
+ Please advise on https://gerrit.libreoffice.org/#/c/49914/
   + massive change, terminology: removing the word Runtime
   + is there a reason for that ? (Eike)
   + bothers the authors (Olivier)
   + “Runtime” doesn’t seem to be needed in text.
   + can we do this with a sed script across the translations ? 
(Michael)
   + yes, if only a script – but did translators translate it ? 
(Cloph)
   + if not – mostly tricky.
   + is “catagiries” in commit Categories in change? (Michael)
   + yes (Olivier)
AI:   + ask Sophie (Olivier)

* UX Update (Heiko)
+ Bugzilla (topicUI) statistics
250(250) (topicUI) bugs open, 322(322) (needsUXEval) needs to be 
evaluated by the UXteam
+ Updates:
BZ changes   1 week   1 month3 months   12 months  
 added  6(-2)15(-6) 33(-4) 107(-9) 
 commented 49(8)196(-37)   474(-28)   2016(-48)
   removed  0(0)  0(0)   2(0)   14(-1) 
  resolved  3(1) 12(1)  44(-2) 192(-23)
+ top 10 contributors:
  Tietze, Heiko made 94 changes in 1 month, and 887 changes in 1 year
  Philips, Yousuf made 28 changes in 1 month, and 782 changes in 1 year
  Buovjaga made 22 changes in 1 month, and 220 changes in 1 year
  Xisco Faulí made 19 changes in 1 month, and 286 changes in 1 year
  Foote, V Stuart made 19 changes in 1 month, and 296 changes in 1 year
  Budea, Áron made 19 changes in 1 month, and 58 changes in 1 year
  Thomas Lendo made 19 changes in 1 month, and 433 changes in 1 year
  Thomas Linard made 18 changes in 1 month, and 65 changes in 1 year
  Dieter Praas made 15 changes in 1 month, and 89 changes in 1 year
  Telesto made 15 changes in 1 month, and 85 changes in 1 year

  + Easyhacking: How to set up your environment

https://design.blog.documentfoundation.org/2018/02/22/easyhacking-set-environment/
   + collection of links to the wiki: so people can install code and hack 
on it
   + first of a series Heiko plans on this
   + since some GSOC students don’t know how to do it.

  + Improvements to Font Listing
https://design.blog.documentfoundation.org/2018/02/18/improvements-font-listing/
   + outcome of design session last week
   + how to filter out un-interesting fonts in the font-name drop-down.
   + 3 options; poll in the blog – give your feedback to inform the devs
 ultimate decisions as they implement.

  + New backgrounds gallery theme in 6.1
   + Extensions for legacy bitmaps available
   + now can install the old background images via extensions.

* Crash Hunting (Caolan)
+ 0 (-1) import failure, 0(+0) export failures
+ good news.
+ 4(+0) coverity
+ ?? 45 fuzzers * 3 sanitizers+engine combos (asan+libfuzzer,
ubsan+libfuzzer, asan+afl), font parser last added
+ something wrong up-stream; not producing results.
+ unclear what changed; exception suggests no config files.
+ forcepoint – have been finding things in master
+ also in DLP libraries
+ finding some bits in filter-detection
+ lots of overlap between fuzzing & crash-testing & coverity
+ finding the same things.
+ added a fuzzer for PDF importing and finding bits in PDF export.

* Crash Reporter (Xisco)
+ http://crashreport.libreoffice.org/stats/version/5.3.7.2
+ 1004 (last 7 days) (down)
+ http://crashreport.libreoffic

Re: Implementing accessibility non-regression check tool

[Samuel Thibault]

Stephan Bergmann, on jeu. 22 févr. 2018 15:49:40 +0100, wrote:
> That means external/lxml will need to:
> 
> * build against and run with either the system Python or the locally-built
> one from external/python3,
> 
> * build against and run with either the system libxml2/libxslt or the
> locally-built one from external/{libxml2,libxslt}.
> 
> That's four different ways how to build external/lxml, and slightly more
> different ways (using the system lxml versus external/lxml) how to run the
> gla11y tool in solenv/gbuild/UIConfig.mk.  And getting all those ways to
> work, on the different platforms, will be hell.

Well, python, libxml2 and libxslt are very-well-established projects
with a huge lot of reverse dependencies, and thus they have to take
backward compatibility into extremely careful consideration. I thus
don't fear too much problems building lxml against various versions of
them.

(and the current building issue reported in gerrit 50115 is merely that
the current LO python3 module doesn't install any header file or such)

> Isn't there another option to make that gla11y tool process XML data, one
> that better matches LO's needs?

Well, we can reimplement the world for sure.

More seriously, we can of course at least depend only on libxml2. Not
depending on a higher-level library, however, means to have to
reimplement all the tree browsing functions needed to reach the pieces
of .ui files.  And avoiding python means, writing all of this in C?
That's neither fun nor easy to extend for further .ui checking.  The
eventual script we plan to integrate is only about 300 lines of python.
I'm scared by the maintenance of the equivalent without using python and
lxml more than maintenance of building lxml.

Samuel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - sd/qa

[Tamás Zolnai]

 sd/qa/unit/tiledrendering/tiledrendering.cxx |9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

New commits:
commit 4152ecf98622d81aef50b68c9165292ba244abb9
Author: Tamás Zolnai 
Date:   Wed Feb 21 17:47:59 2018 +0100

Add some extra assert to this test case

To find out why this test fails for some linux tinderbox.

Change-Id: I49d1afbbac631abe49378b12b888615e3e0e1bef
Reviewed-on: https://gerrit.libreoffice.org/50121
Reviewed-by: Tamás Zolnai 
Tested-by: Tamás Zolnai 
(cherry picked from commit 0a46237093c1750ee69ddb6a365098dc1d06b758)
Reviewed-on: https://gerrit.libreoffice.org/50178
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx 
b/sd/qa/unit/tiledrendering/tiledrendering.cxx
index 0eabab25fab2..8b7a7ee89293 100644
--- a/sd/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx
@@ -1969,9 +1969,7 @@ void SdTiledRenderingTest::testPasteTextOnSlide()
 // Load the document.
 comphelper::LibreOfficeKit::setActive();
 SdXImpressDocument* pXImpressDocument = 
createDoc("paste_text_onslide.odp");
-
-ViewCallback aView1;
-
SfxViewShell::Current()->registerLibreOfficeKitViewCallback(&ViewCallback::callback,
 &aView1);
+CPPUNIT_ASSERT(pXImpressDocument);
 
 // select second text object
 pXImpressDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, awt::Key::TAB);
@@ -2017,7 +2015,10 @@ void SdTiledRenderingTest::testPasteTextOnSlide()
 Scheduler::ProcessEventsToIdle();
 
 // Check the position of the newly added text shape, created for pasted 
text
-SdrObject* pObject = 
pXImpressDocument->GetDocShell()->GetViewShell()->GetActualPage()->GetObj(2);
+SdPage* pActualPage = 
pXImpressDocument->GetDocShell()->GetViewShell()->GetActualPage();
+CPPUNIT_ASSERT_EQUAL(static_cast(3), pActualPage->GetObjCount());
+SdrObject* pObject = pActualPage->GetObj(2);
+CPPUNIT_ASSERT(pObject);
 SdrTextObj* pTextObj = dynamic_cast(pObject);
 CPPUNIT_ASSERT(pTextObj);
 CPPUNIT_ASSERT_EQUAL(static_cast(OBJ_TEXT), 
pTextObj->GetObjIdentifier());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Status of LO embedding inside other processes windows?

[Stephan Bergmann]

On 22.02.2018 14:14, Robert Marcano wrote:

On 02/22/2018 07:10 AM, Michael Stahl wrote:

On 21.02.2018 16:55, Robert Marcano wrote:

3- Now both processes should be using GTK2, but the problems with
keyboard input is a blocker


that sounds like a bug somewhere.  (unlikely to get fixed any time soon
given this is quite an esoteric use-case.)


LibreOffice online and if IIRC the Android viewer are more invested on 
using LibreOfficeKit, I think I should investigate that. My knowledge of 
what can be done with LibreOfficeKit tell me I can have an headless 
process rendering to a shared buffer and use that to draw on my Java 
process.


Is this a better long term strategy?


Most likely, yes.  That LO-in-Java-window thing is brittle at best.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Implementing accessibility non-regression check tool

[Stephan Bergmann]

I'm not sure basing this gla11y tool on lxml () is a 
good choice:  "The lxml XML toolkit is a Pythonic binding for the C 
libraries libxml2 and libxslt." ()


Different LO builds have the choice/need to use either a system Python 
or a locally-built one from external/python3.


Different LO builds have the choice/need to use either a system 
libxml2/libxslt or a locally-built one from external/{libxml2,libxslt}.


Adding lxml into the mix, different LO builds will have the choice/need 
to use either a system lxml or a locally-built one.  (Which 
 "Build external lxml if not 
provided by system" is going to add as external/lxml.)


That means external/lxml will need to:

* build against and run with either the system Python or the 
locally-built one from external/python3,


* build against and run with either the system libxml2/libxslt or the 
locally-built one from external/{libxml2,libxslt}.


That's four different ways how to build external/lxml, and slightly more 
different ways (using the system lxml versus external/lxml) how to run 
the gla11y tool in solenv/gbuild/UIConfig.mk.  And getting all those 
ways to work, on the different platforms, will be hell.


Isn't there another option to make that gla11y tool process XML data, 
one that better matches LO's needs?

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: loleaflet/dist

[Samuel Mehrbrodt]

 loleaflet/dist/loleaflet.css |1 +
 1 file changed, 1 insertion(+)

New commits:
commit deecd0e0d8bd66942800400ba13935955d231d3f
Author: Samuel Mehrbrodt 
Date:   Thu Feb 22 15:43:05 2018 +0100

Add some right margin for info msgs

Change-Id: I037b8dd42fa8dafb1686284e9241a32f4068ff75
Reviewed-on: https://gerrit.libreoffice.org/50185
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/loleaflet/dist/loleaflet.css b/loleaflet/dist/loleaflet.css
index 6315efbf..23a32a87 100644
--- a/loleaflet/dist/loleaflet.css
+++ b/loleaflet/dist/loleaflet.css
@@ -370,4 +370,5 @@ body {
 /* Place above statusbar */
 .vex.vex-theme-bottom-right-corner .vex-content {
bottom: 40px !important;
+   right: 10px !important;
 }
\ No newline at end of file
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: ScFiltersTest::testOrcusODSStyleInterface fails with liborcus 0.13.3

[Rene Engelhard]

Hi,

On Thu, Feb 22, 2018 at 08:21:40AM -0500, Kohei Yoshida wrote:
> > I initially filed
> > https://bugs.documentfoundation.org/show_bug.cgi?id=115931 but it was
> > suggested to me to raise the issue on the mailing list instead.
> > 
> > So here it goes: when building libreoffice 6.0 with an external
> > liborcus (version 0.13.3), unit tests fail:
> > 
> > subsequent_filters-test.cxx:2398:Assertion
> > Test name: ScFiltersTest::testOrcusODSStyleInterface
> > equality assertion failed
> > - Expected: Color: R:254 G:255 B: 204
> > - Actual : Color: R:255 G:255 B: 255
> > 
> > This is most likely caused by that upstream change:
> > https://gitlab.com/orcus/orcus/commit/f821995022df8dd1e580dd22cf131584b2b1ac4f
[...]
> Yes, so, you have raised this in a timely fashion.  While I was backporting a 
> patch against orcus for the 6-0 branch last night, I did notice the 
> possibility of this very issue, and was thinking of how to address it for 
> that branch.  Since you've already discovered this and emailed it to the 
> list, let me provide my thoughts on this.
> 
> First of all, your patch should work fine.  However, with this change, we 
> need to ensure that liborcus version 0.13.3 or later be used.  If you used an 
> earlier version this change does break things.
> 
> What I was thinking of proposing is backporting the following commits:
> 
> 20945a9a4de6684010fd5b3603595e6da543807d
> a1c36eff089c3cd695bd78090575ca1c7677121e
> 
> raise the orcus baseline to 0.13.3, and commit all of these as a single 
> backport commit to ensure that these all happen atomically.  This way if 
> someone wants to build from the 6-0 branch using the system liborcus then the 
> configure script should be able to catch it and fail.
> 
> How does this sound?

I think that should be done. I uploaded 0.13.3 to Debian (and Ubuntu
synced it) for 6.1 needing it (and bumped the build and runtime
dependency there already..) but when 6.0 breaks with it (should have
known better and tried...) that imho should be done, yes...

Will backport both patches above as a local patch for now.

Regards,

Rene
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: solenv/gbuild

[Stephan Bergmann]

 solenv/gbuild/UIConfig.mk |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit c7752298d4a23c5adecb14a704dfb93f888b47b6
Author: Stephan Bergmann 
Date:   Wed Feb 21 17:12:28 2018 +0100

Process all added uifiles

Change-Id: I9efb05973e7d8468afb82bd9875d527412a4fd1c
Reviewed-on: https://gerrit.libreoffice.org/50116
Reviewed-by: Stephan Bergmann 
Tested-by: Stephan Bergmann 

diff --git a/solenv/gbuild/UIConfig.mk b/solenv/gbuild/UIConfig.mk
index 9665dcaf9d18..640ead85d658 100644
--- a/solenv/gbuild/UIConfig.mk
+++ b/solenv/gbuild/UIConfig.mk
@@ -121,7 +121,7 @@ $(call gb_UIConfig_get_clean_target,%) :
 define gb_UIConfig_a11yerrors__command
 $(call gb_Output_announce,$(2),$(true),UIA,1)
 $(call gb_Helper_abbreviate_dirs,\
-   $(gb_UIConfig_a11yerrors_COMMAND) -W none $(UIFILE) > $@
+   $(gb_UIConfig_a11yerrors_COMMAND) -W none $(UIFILES) > $@
 )
 endef
 
@@ -189,7 +189,7 @@ $(call gb_UIConfig_get_imagelist_target,$(1)) : 
UI_IMAGELISTS += $(call gb_UIIma
 $(call gb_UIConfig_get_imagelist_target,$(1)) : $(call 
gb_UIImageListTarget_get_target,$(2))
 $(call gb_UIConfig_get_clean_target,$(1)) : $(call 
gb_UIImageListTarget_get_clean_target,$(2))
 
-$(call gb_UIConfig_get_a11yerrors_target,$(1)) : UIFILE := $(SRCDIR)/$(2).ui
+$(call gb_UIConfig_get_a11yerrors_target,$(1)) : UIFILES += $(SRCDIR)/$(2).ui
 $(call gb_UIConfig_get_clean_target,$(1)) : $(call 
gb_UIA11YErrorsTarget_get_clean_target,$(2))
 
 endef
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - include/osl

[Aron Budea]

 include/osl/file.hxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit c8bb752d21e25a1ba9b61e1197002e6d8c1746a5
Author: Aron Budea 
Date:   Wed Feb 21 14:49:11 2018 +0100

tdf#115383: revert mixup of E_ROFS and E_SPIPE in file.hxx

Regression from a9739f2dec197793fa9400dd95be49494dc85264

Change-Id: I1b55b0201888a63bd2439be8c0421f450d609018
Reviewed-on: https://gerrit.libreoffice.org/50105
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 
Reviewed-on: https://gerrit.libreoffice.org/50171
Reviewed-by: Noel Grandin 
Tested-by: Michael Stahl 

diff --git a/include/osl/file.hxx b/include/osl/file.hxx
index b005a31b5e76..96c155a18e1e 100644
--- a/include/osl/file.hxx
+++ b/include/osl/file.hxx
@@ -80,8 +80,8 @@ public:
 E_NOTTY= osl_File_E_NOTTY,  //< inappropriate I/O 
control operation
 E_FBIG = osl_File_E_FBIG,   //< file too large
 E_NOSPC= osl_File_E_NOSPC,  //< no space left on 
device, write failed
-E_SPIPE= osl_File_E_ROFS,   //< invalid seek operation 
(such as on pipe)
-E_ROFS = osl_File_E_SPIPE,  //< illegal modification 
to read-only filesystem
+E_SPIPE= osl_File_E_SPIPE,  //< invalid seek operation 
(such as on pipe)
+E_ROFS = osl_File_E_ROFS,   //< illegal modification 
to read-only filesystem
 E_MLINK= osl_File_E_MLINK,  //< too many links to file
 E_PIPE = osl_File_E_PIPE,   //< broken pipe; no 
process reading from other end of pipe
 E_DOM  = osl_File_E_DOM,//< domain error 
(mathematical error)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: ScFiltersTest::testOrcusODSStyleInterface fails with liborcus 0.13.3

[Olivier Tilloy]

On Thu, Feb 22, 2018 at 2:21 PM, Kohei Yoshida  wrote:
> Hi there,
>
>> On February 22, 2018 at 8:01 AM Olivier Tilloy 
>>  wrote:
>>
>>
>> Hello,
>>
>> I initially filed
>> https://bugs.documentfoundation.org/show_bug.cgi?id=115931 but it was
>> suggested to me to raise the issue on the mailing list instead.
>>
>> So here it goes: when building libreoffice 6.0 with an external
>> liborcus (version 0.13.3), unit tests fail:
>>
>> subsequent_filters-test.cxx:2398:Assertion
>> Test name: ScFiltersTest::testOrcusODSStyleInterface
>> equality assertion failed
>> - Expected: Color: R:254 G:255 B: 204
>> - Actual : Color: R:255 G:255 B: 255
>>
>> This is most likely caused by that upstream change:
>> https://gitlab.com/orcus/orcus/commit/f821995022df8dd1e580dd22cf131584b2b1ac4f
>>
>> I'm not familiar with that code, but I came up with a tentative patch
>> (which I will actually put to the test soon):
>>
>> --- a/sc/source/filter/orcus/interface.cxx
>> +++ b/sc/source/filter/orcus/interface.cxx
>> @@ -839,7 +839,7 @@ void ScOrcusStyles::fill::applyToItemSet
>>  return;
>>  }
>>
>> -rSet.Put(SvxBrushItem(maBgColor, ATTR_BACKGROUND));
>> +rSet.Put(SvxBrushItem(maFgColor, ATTR_BACKGROUND));
>>  }
>>
>> Thoughts and feedback welcome!
>
> Yes, so, you have raised this in a timely fashion.  While I was backporting a 
> patch against orcus for the 6-0 branch last night, I did notice the 
> possibility of this very issue, and was thinking of how to address it for 
> that branch.  Since you've already discovered this and emailed it to the 
> list, let me provide my thoughts on this.
>
> First of all, your patch should work fine.  However, with this change, we 
> need to ensure that liborcus version 0.13.3 or later be used.  If you used an 
> earlier version this change does break things.
>
> What I was thinking of proposing is backporting the following commits:
>
> 20945a9a4de6684010fd5b3603595e6da543807d
> a1c36eff089c3cd695bd78090575ca1c7677121e
>
> raise the orcus baseline to 0.13.3, and commit all of these as a single 
> backport commit to ensure that these all happen atomically.  This way if 
> someone wants to build from the 6-0 branch using the system liborcus then the 
> configure script should be able to catch it and fail.
>
> How does this sound?

That sounds correct to me.

I'm building packages for ubuntu 18.04 where liborcus is at version
0.13.3 in the archive already, which is why I've started hitting the
issue. I'll test the change I suggested earlier as a distro-patch, and
it can be dropped later when your changes are merged and released.

Regards,

 Olivier
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - svx/source

[Julien Nabet]

 svx/source/form/formcontroller.cxx |   34 ++
 1 file changed, 34 insertions(+)

New commits:
commit 074cda388a8c378f3ab433c1f4a5f086b4dcd67e
Author: Julien Nabet 
Date:   Thu Jan 25 14:52:43 2018 +0100

tdf#107134: add comparator in form filter

Change-Id: I86d3b5c4ebd231bdad70dc9f5a364658cfca6df4
Reviewed-on: https://gerrit.libreoffice.org/48609
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 
(cherry picked from commit 819ba42b3409bd2f66593f619f1934ea7f461364)
Reviewed-on: https://gerrit.libreoffice.org/49681
Reviewed-by: Eike Rathke 

diff --git a/svx/source/form/formcontroller.cxx 
b/svx/source/form/formcontroller.cxx
index 15be71774403..f7d53f99128a 100644
--- a/svx/source/form/formcontroller.cxx
+++ b/svx/source/form/formcontroller.cxx
@@ -51,6 +51,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -3170,6 +3171,39 @@ void 
FormController::setFilter(::std::vector& rFieldInfos)
 if ( pParseNode != nullptr )
 {
 OUString sCriteria;
+switch (pRefValues[j].Handle)
+{
+case css::sdb::SQLFilterOperator::EQUAL:
+sCriteria += "=";
+break;
+case 
css::sdb::SQLFilterOperator::NOT_EQUAL:
+sCriteria += "!=";
+break;
+case css::sdb::SQLFilterOperator::LESS:
+sCriteria += "<";
+break;
+case css::sdb::SQLFilterOperator::GREATER:
+sCriteria += ">";
+break;
+case 
css::sdb::SQLFilterOperator::LESS_EQUAL:
+sCriteria += "<=";
+break;
+case 
css::sdb::SQLFilterOperator::GREATER_EQUAL:
+sCriteria += ">=";
+break;
+case css::sdb::SQLFilterOperator::LIKE:
+sCriteria += "LIKE ";
+break;
+case css::sdb::SQLFilterOperator::NOT_LIKE:
+sCriteria += "NOT LIKE ";
+break;
+case css::sdb::SQLFilterOperator::SQLNULL:
+sCriteria += "IS NULL";
+break;
+case 
css::sdb::SQLFilterOperator::NOT_SQLNULL:
+sCriteria += "IS NOT NULL";
+break;
+}
 pParseNode->parseNodeToPredicateStr( sCriteria
 
,xConnection
 ,xFormatter
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Intro

[Muhammet Kara]

Hello Sourabh,

Welcome!

You don't have to know Android if you are not going to work on the 
Android viewer part. Just C++ would be enough to work on core.


And you are also free to contribute to LibreOffice documentation, but 
non-coding tasks/projects might not be acceptable for GSoC.


Cheers,
Muhammet

On 02/22/2018 03:22 AM, Sourabh Pruthi wrote:
Hello everyone myself Sourabh a student of pre-final year looking to 
apply for gsoc 2018 . I am really interested in contributing to 
LibreOffice. Actually I know only C++ and Java. Can I still able to 
proceed further because I don't know Android ? Another small query can 
I contribute to documentation as well?


Thanks


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sc/inc

[Eike Rathke]

 sc/inc/table.hxx |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 2110c7260ef8f536e2d8517145b91a62b6c52b68
Author: Eike Rathke 
Date:   Wed Feb 21 15:13:11 2018 +0100

Pass ScColumnsRange::Iterator as const& and use pre-increment/decrement

 This is a combination of 2 commits.

Pass ScColumnsRange::Iterator as const&

Specifically for each operator==() call two temporaries were
copied, for operator!=() even twice as much.. in
for(...:GetColumnsRange())

(cherry picked from commit 581b845509d20fa864b00088ed649f30fe4e1109)

 Conflicts:
 sc/inc/table.hxx

Use iterator pre-increment/decrement

(cherry picked from commit f599ff99ecb405e2934c8d4d472e54fd4064a26a)

079850116648dc69b8c92fa23b30233f63d9b6e7

Change-Id: I4b426ae855454544e50efca35aa73303138f7ba7
Reviewed-on: https://gerrit.libreoffice.org/50113
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index 2ec2cd87e892..d6af98d394f0 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -130,17 +130,17 @@ class ScColumnsRange final
 {
 std::vector::const_iterator maColIter;
 public:
-explicit Iterator(std::vector::const_iterator colIter) : 
maColIter(colIter) {}
+explicit Iterator(const std::vector::const_iterator& 
colIter) : maColIter(colIter) {}
 
-Iterator& operator++() { maColIter++; return *this;}
-Iterator& operator--() { maColIter--; return *this;}
+Iterator& operator++() { ++maColIter; return *this;}
+Iterator& operator--() { --maColIter; return *this;}
 
-bool operator==(Iterator other) const {return maColIter == 
other.maColIter;}
-bool operator!=(Iterator other) const {return !(*this == other);}
+bool operator==(const Iterator & rOther) const {return maColIter == 
rOther.maColIter;}
+bool operator!=(const Iterator & rOther) const {return !(*this == 
rOther);}
 reference operator*() const {return (*maColIter)->GetCol();}
 };
 
-ScColumnsRange(Iterator nBegin, Iterator nEnd) : maBegin(nBegin), 
maEnd(nEnd) {}
+ScColumnsRange(const Iterator & rBegin, const Iterator & rEnd) : 
maBegin(rBegin), maEnd(rEnd) {}
 const Iterator & begin() { return maBegin; }
 const Iterator & end() { return maEnd; }
 std::reverse_iterator rbegin() { return 
std::reverse_iterator(maEnd); }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/build loleaflet/debug loleaflet/dist loleaflet/main.css loleaflet/main.js loleaflet/README loleaflet/src

[Samuel Mehrbrodt]

 loleaflet/README |8 +
 loleaflet/build/deps.js  |5 ++-
 loleaflet/debug/document/loleaflet.html  |1 
 loleaflet/dist/errormessages.js  |3 +-
 loleaflet/dist/loleaflet.css |9 ++
 loleaflet/main.css   |1 
 loleaflet/main.js|1 
 loleaflet/src/control/Control.Infobar.js |   42 +++
 loleaflet/src/core/Socket.js |9 --
 9 files changed, 73 insertions(+), 6 deletions(-)

New commits:
commit 4c9872188f3ae5f876fb5652273c6bdb10065d14
Author: Samuel Mehrbrodt 
Date:   Thu Feb 22 14:19:03 2018 +0100

Add non-obtrusive notification method (infobar-alike)

This reuses the vex dialogs and pushes notifications to the bottom right 
area.
Converted the limit reached notification to this new type.

Change-Id: I20f0c1202eecde028e70156f02ba31497ef2f9b9

diff --git a/loleaflet/README b/loleaflet/README
index acc790da..4694417a 100644
--- a/loleaflet/README
+++ b/loleaflet/README
@@ -300,6 +300,14 @@ Error:
 + [e.cmd] = the command that caused the error
 + [e.kind] = the kind of error
 
+Infobars:
+- events
+map.on('infobar', function (e) {}) where
++ [e.msg] = a message
++ [e.actionlabel] = Label for the action button
++ [e.action] = A link (starting with http).
+   Please extend to allow other actions when needed.
+
 CommandValues:
 - api:
 map.getToolbarCommandValues(command)
diff --git a/loleaflet/build/deps.js b/loleaflet/build/deps.js
index 9c905d76..59f4cde3 100644
--- a/loleaflet/build/deps.js
+++ b/loleaflet/build/deps.js
@@ -343,8 +343,9 @@ var deps = {
 
ControlDialog: {
src: ['control/Control.js',
- 'control/Control.LokDialog.js',
- 'control/Control.AlertDialog.js'],
+   'control/Control.LokDialog.js',
+   'control/Control.AlertDialog.js',
+   'control/Control.Infobar.js'],
heading: 'Controls',
desc: 'Handles vex dialogs for displaying alerts'
},
diff --git a/loleaflet/debug/document/loleaflet.html 
b/loleaflet/debug/document/loleaflet.html
index 49c0dfce..2d7a6a75 100644
--- a/loleaflet/debug/document/loleaflet.html
+++ b/loleaflet/debug/document/loleaflet.html
@@ -20,6 +20,7 @@
 
 
 
+
 
 
 
diff --git a/loleaflet/dist/errormessages.js b/loleaflet/dist/errormessages.js
index edda0764..36937c06 100644
--- a/loleaflet/dist/errormessages.js
+++ b/loleaflet/dist/errormessages.js
@@ -1,6 +1,7 @@
 exports.diskfull = _('No disk space left on server, please contact the server 
administrator to continue.');
 exports.emptyhosturl = _('The host URL is empty. The loolwsd server is 
probably misconfigured, please contact the administrator.');
-exports.limitreached = _('This is an unsupported version of {productname}. To 
avoid the impression that it is suitable for deployment in enterprises, this 
version is limited to {docs} documents, and {connections} 
connections.{a}More information and support{/a}');
+exports.limitreached = _('This is an unsupported version of {productname}. To 
avoid the impression that it is suitable for deployment in enterprises, this 
version is limited to {docs} documents, and {connections} connections.');
+exports.infoandsupport = _('More information and support');
 exports.limitreachedprod = _('This service is limited to %0 documents, and %1 
connections total by the admin. This limit has been reached. Please try again 
later.');
 exports.serviceunavailable = _('Service is unavailable. Please try again later 
and report to your administrator if the issue persists.');
 exports.unauthorized = _('Unauthorized WOPI host. Please try again later and 
report to your administrator if the issue persists.');
diff --git a/loleaflet/dist/loleaflet.css b/loleaflet/dist/loleaflet.css
index f458c371..6315efbf 100644
--- a/loleaflet/dist/loleaflet.css
+++ b/loleaflet/dist/loleaflet.css
@@ -362,3 +362,12 @@ body {
 -webkit-user-select: none;
 -o-user-select: none;
 }
+
+/* Infobar */
+.vex-theme-bottom-right-corner .vex-dialog-message {
+   font-size: 1em;
+}
+/* Place above statusbar */
+.vex.vex-theme-bottom-right-corner .vex-content {
+   bottom: 40px !important;
+}
\ No newline at end of file
diff --git a/loleaflet/main.css b/loleaflet/main.css
index 729b21b3..de61241f 100644
--- a/loleaflet/main.css
+++ b/loleaflet/main.css
@@ -14,6 +14,7 @@
 @import url('node_modules/jquery-contextmenu/dist/jquery.contextMenu.css');
 @import url('node_modules/vex-js/css/vex.css');
 @import url('node_modules/vex-js/css/vex-theme-plain.css');
+@import url('node_modules/vex-js/css/vex-theme-bottom-right-corner.css');
 @import url('node_modules/w2ui/w2ui.css');
 @import url('node_modules/select2/dist/css/select2.css');
 @import url(

Re: ScFiltersTest::testOrcusODSStyleInterface fails with liborcus 0.13.3

[Kohei Yoshida]

Hi there,

> On February 22, 2018 at 8:01 AM Olivier Tilloy  
> wrote:
> 
> 
> Hello,
> 
> I initially filed
> https://bugs.documentfoundation.org/show_bug.cgi?id=115931 but it was
> suggested to me to raise the issue on the mailing list instead.
> 
> So here it goes: when building libreoffice 6.0 with an external
> liborcus (version 0.13.3), unit tests fail:
> 
> subsequent_filters-test.cxx:2398:Assertion
> Test name: ScFiltersTest::testOrcusODSStyleInterface
> equality assertion failed
> - Expected: Color: R:254 G:255 B: 204
> - Actual : Color: R:255 G:255 B: 255
> 
> This is most likely caused by that upstream change:
> https://gitlab.com/orcus/orcus/commit/f821995022df8dd1e580dd22cf131584b2b1ac4f
> 
> I'm not familiar with that code, but I came up with a tentative patch
> (which I will actually put to the test soon):
> 
> --- a/sc/source/filter/orcus/interface.cxx
> +++ b/sc/source/filter/orcus/interface.cxx
> @@ -839,7 +839,7 @@ void ScOrcusStyles::fill::applyToItemSet
>  return;
>  }
> 
> -rSet.Put(SvxBrushItem(maBgColor, ATTR_BACKGROUND));
> +rSet.Put(SvxBrushItem(maFgColor, ATTR_BACKGROUND));
>  }
> 
> Thoughts and feedback welcome!

Yes, so, you have raised this in a timely fashion.  While I was backporting a 
patch against orcus for the 6-0 branch last night, I did notice the possibility 
of this very issue, and was thinking of how to address it for that branch.  
Since you've already discovered this and emailed it to the list, let me provide 
my thoughts on this.

First of all, your patch should work fine.  However, with this change, we need 
to ensure that liborcus version 0.13.3 or later be used.  If you used an 
earlier version this change does break things.

What I was thinking of proposing is backporting the following commits:

20945a9a4de6684010fd5b3603595e6da543807d
a1c36eff089c3cd695bd78090575ca1c7677121e

raise the orcus baseline to 0.13.3, and commit all of these as a single 
backport commit to ensure that these all happen atomically.  This way if 
someone wants to build from the 6-0 branch using the system liborcus then the 
configure script should be able to catch it and fail.

How does this sound?

Kohei
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Status of LO embedding inside other processes windows?

[Robert Marcano]

Thanks for replying.

On 02/22/2018 07:10 AM, Michael Stahl wrote:

On 21.02.2018 16:55, Robert Marcano wrote:

Greetings. I have been playing with the developers guide example [1] for
embedding LO inside a Java window (Swing toolkit). The example works on
a Windows host, but on Linux I found the following problems (in the
order I found)

1- When the host Java application is running on a Wayland session (Java
Swing is still an X11 program), there is a crash. IIRC LO still is a X11
based application (or at least the Fedora compiled version is using the
X11 GTK back-end)

2- Switched to an X11 desktop session, there was no crash this time, but
the document was not shown embedded on the Java window, it was a
floating window with no window controls, unresponsive to the user.

3- Run the same application with the environment variable
SAL_USE_VCLPLUGIN=gtk in order to force the LO GTK2 back-end. The
document is embedded on the Java window as expected, but keyboard input
is not possible on the document or the controls, mouse actions works,
for example, I can change fonts using the mouse, but can't write
anything on the font combobox nor the document. New LO dialogs opened
from that document, keyboard input works.

4- Trying with SAL_USE_VCLPLUGIN=gen and keyboard input now works, but
with the outdated look of that LO VCL backend :(

So now the possible reasons that came to my head for each case:

1- Some confusion between Java being X11 and LO trying to do some
Wayland thing?


by default the "gtk3" vclplug will use Wayland if available.  probably
this won't work if the Java connects to X11 instead.  there is some
environment var GDK_BACKEND=x11 that can be used to force it.


GDK_BACKEND=x11 helps with not crashing on the Wayland session.




2- Java has a GTK Look and Feel/theme that loads GTK2 (the example
application does not load that theme) , I am under the impression that
if LO is loading GTK3, they are on different processes, so should not be
any conflict here.


AFAIK GTK 2 and GTK 3 cannot coexist in the same process, due to some
naming conflict of GObjects or so...


What I find weird is that there is no GTK libraries loaded on the 
process space of the Java example (verified checking /proc//maps), 
even when running the example in-place (not on an independent top level 
window)





3- Now both processes should be using GTK2, but the problems with
keyboard input is a blocker


that sounds like a bug somewhere.  (unlikely to get fixed any time soon
given this is quite an esoteric use-case.)


LibreOffice online and if IIRC the Android viewer are more invested on 
using LibreOfficeKit, I think I should investigate that. My knowledge of 
what can be done with LibreOfficeKit tell me I can have an headless 
process rendering to a shared buffer and use that to draw on my Java 
process.


Is this a better long term strategy?




4- Everything running without conflicting libraries/protocols (Wayland
vs X11 or GTK3 vs GTK2) and work, but the look and feel!!

Now, when running the example with a no inline option, everything works
fine, even when GTK2 and GTK3 are mixed. Wish to have an option to
create the new document top level window as a child of the Java window,
it is a pain for user that the document can go to the back of the
"caller" window. Any hints if this is possible between two processes
like Java and LO?


so does that option run LO as a separate process? yes, that would avoid
some of these issues, but as you found you get different issues instead :-/



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

ScFiltersTest::testOrcusODSStyleInterface fails with liborcus 0.13.3

[Olivier Tilloy]

Hello,

I initially filed
https://bugs.documentfoundation.org/show_bug.cgi?id=115931 but it was
suggested to me to raise the issue on the mailing list instead.

So here it goes: when building libreoffice 6.0 with an external
liborcus (version 0.13.3), unit tests fail:

subsequent_filters-test.cxx:2398:Assertion
Test name: ScFiltersTest::testOrcusODSStyleInterface
equality assertion failed
- Expected: Color: R:254 G:255 B: 204
- Actual : Color: R:255 G:255 B: 255

This is most likely caused by that upstream change:
https://gitlab.com/orcus/orcus/commit/f821995022df8dd1e580dd22cf131584b2b1ac4f

I'm not familiar with that code, but I came up with a tentative patch
(which I will actually put to the test soon):

--- a/sc/source/filter/orcus/interface.cxx
+++ b/sc/source/filter/orcus/interface.cxx
@@ -839,7 +839,7 @@ void ScOrcusStyles::fill::applyToItemSet
 return;
 }

-rSet.Put(SvxBrushItem(maBgColor, ATTR_BACKGROUND));
+rSet.Put(SvxBrushItem(maFgColor, ATTR_BACKGROUND));
 }

Thoughts and feedback welcome!

Regards,

 Olivier
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - readlicense_oo/license

[Christian Lohmaier]

 readlicense_oo/license/CREDITS.fodt | 4220 +++-
 1 file changed, 2292 insertions(+), 1928 deletions(-)

New commits:
commit 49bab70c93a400b997a16af77d6d8952c33e7395
Author: Christian Lohmaier 
Date:   Thu Feb 22 13:53:46 2018 +0100

update credits

Change-Id: I189e30718e5818d183dc308ecbb96f4943b4e20a
(cherry picked from commit 8faa6b8bbaf89f95d7c319d70af855331cc99b7d)

diff --git a/readlicense_oo/license/CREDITS.fodt 
b/readlicense_oo/license/CREDITS.fodt
index e8ec085487aa..73999319624f 100644
--- a/readlicense_oo/license/CREDITS.fodt
+++ b/readlicense_oo/license/CREDITS.fodt
@@ -1,10 +1,10 @@
 
 
 http://www.w3.org/1999/xlink"; 
xmlns:dc="http://purl.org/dc/elements/1.1/"; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML"; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" 
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oas
 is:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office"; 
xmlns:ooow="http://openoffice.org/2004/writer"; 
xmlns:oooc="http://openoffice.org/2004/calc"; 
xmlns:dom="http://www.w3.org/2001/xml-events"; 
xmlns:xforms="http://www.w3.org/2002/xforms"; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xmlns:rpt="http://openoffice.org/2005/report"; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml"; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#"; 
xmlns:officeooo="http://openoffice.org/2009/office"; 
xmlns:tableooo="http://openoffice.org/2009/table"; 
xmlns:drawooo="http://openoffice.org/2010/draw"; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:formx="urn:openoffice:names:
 experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/"; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.text">
- Credits » 
LibreOfficeCreditscontributorscodersdevelopersCredits
 for the LibreOffice 
development/coding.LibreOffice/5.4.4.2$Linux_X86_64
 
LibreOffice_project/2524958677847fb3bb44820e40380acbe820f9602012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA
+ Credits » 
LibreOfficeCreditscontributorscodersdevelopersCredits
 for the LibreOffice 
development/coding.LibreOffice/6.0.1.1$Linux_X86_64
 
LibreOffice_project/60bfb1526849283ce2491346ed2aa51c465abfe62012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA
  
   
-   563
+   690
501
41965
21327
@@ -16,9 +16,9 @@
  3649
  3471
  501
- 563
+ 690
  42464
- 21888
+ 22015
  0
  0
  false
@@ -39,6 +39,7 @@

false
false
+   true
false
false
false
@@ -71,7 +72,7 @@
false
false
true
-   7433446
+   7512211
false
false
false
@@ -317,26 +318,23 @@
  
  
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   

   
-  
-   
-  
   

   
@@ -398,24 +396,24 @@

   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   

   
-  
+  

   
   
@@ -748,21 +746,21 @@

   
   
-   
+   
 



   
   
-   
+   
 



   
   
-   
+   
 


@@ -1047,7 +1045,7 @@

   
  Credits
-1309 individuals contributed to 
OpenOffice.org (and whose contributions were imported into LibreOffice) or 
LibreOffice until 2018-01-23 23:15:28.
+1318 individuals contributed to 
OpenOffice.org (and whose contributions were imported into LibreOffice) or 
LibreOffice until 2018-02-21 21:22:32.
 * marks developers whose first contributions 
happened after 2010-09-28.
 Developers 
committing code since 2010-09-28
 
@@ -1074,10 +1072,10 @@
Vladimir 
GlazunovCommits: 25434Joined: 
2000-12-04
   
   
-   Caolán 
McNamaraCommits: 23451Joined: 
2000-10-10
+   Caolán 
McNamaraCommits: 23643Joined: 
2000-10-10
   
   
-   Stephan 
BergmannCommits: 15697Joined: 
2000-10-04
+   Stephan 
BergmannCommits: 15825Joined: 
2000-10-04
   
   
Ivo 
HinkelmannCommits: 9480Joined: 
2002-09-09
@@ -1085,30 +1083,30 @@
  
  
   
-   *Noel GrandinCommits: 
8646Joined: 2011-12-12
+   *Noel GrandinCommits: 
8847Joined: 2011-12-12
   
   
-   Tor 
LillqvistCommits: 8091Joined: 
2010-03-23
+  

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - readlicense_oo/license

[Christian Lohmaier]

 readlicense_oo/license/CREDITS.fodt | 4220 +++-
 1 file changed, 2292 insertions(+), 1928 deletions(-)

New commits:
commit 9187fec31abaae8890b06d36b5887c1012c1384a
Author: Christian Lohmaier 
Date:   Thu Feb 22 13:53:46 2018 +0100

update credits

Change-Id: I189e30718e5818d183dc308ecbb96f4943b4e20a
(cherry picked from commit 8faa6b8bbaf89f95d7c319d70af855331cc99b7d)

diff --git a/readlicense_oo/license/CREDITS.fodt 
b/readlicense_oo/license/CREDITS.fodt
index e8ec085487aa..73999319624f 100644
--- a/readlicense_oo/license/CREDITS.fodt
+++ b/readlicense_oo/license/CREDITS.fodt
@@ -1,10 +1,10 @@
 
 
 http://www.w3.org/1999/xlink"; 
xmlns:dc="http://purl.org/dc/elements/1.1/"; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML"; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" 
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oas
 is:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office"; 
xmlns:ooow="http://openoffice.org/2004/writer"; 
xmlns:oooc="http://openoffice.org/2004/calc"; 
xmlns:dom="http://www.w3.org/2001/xml-events"; 
xmlns:xforms="http://www.w3.org/2002/xforms"; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xmlns:rpt="http://openoffice.org/2005/report"; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml"; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#"; 
xmlns:officeooo="http://openoffice.org/2009/office"; 
xmlns:tableooo="http://openoffice.org/2009/table"; 
xmlns:drawooo="http://openoffice.org/2010/draw"; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:formx="urn:openoffice:names:
 experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/"; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.text">
- Credits » 
LibreOfficeCreditscontributorscodersdevelopersCredits
 for the LibreOffice 
development/coding.LibreOffice/5.4.4.2$Linux_X86_64
 
LibreOffice_project/2524958677847fb3bb44820e40380acbe820f9602012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA
+ Credits » 
LibreOfficeCreditscontributorscodersdevelopersCredits
 for the LibreOffice 
development/coding.LibreOffice/6.0.1.1$Linux_X86_64
 
LibreOffice_project/60bfb1526849283ce2491346ed2aa51c465abfe62012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA
  
   
-   563
+   690
501
41965
21327
@@ -16,9 +16,9 @@
  3649
  3471
  501
- 563
+ 690
  42464
- 21888
+ 22015
  0
  0
  false
@@ -39,6 +39,7 @@

false
false
+   true
false
false
false
@@ -71,7 +72,7 @@
false
false
true
-   7433446
+   7512211
false
false
false
@@ -317,26 +318,23 @@
  
  
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   

   
-  
-   
-  
   

   
@@ -398,24 +396,24 @@

   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   

   
-  
+  

   
   
@@ -748,21 +746,21 @@

   
   
-   
+   
 



   
   
-   
+   
 



   
   
-   
+   
 


@@ -1047,7 +1045,7 @@

   
  Credits
-1309 individuals contributed to 
OpenOffice.org (and whose contributions were imported into LibreOffice) or 
LibreOffice until 2018-01-23 23:15:28.
+1318 individuals contributed to 
OpenOffice.org (and whose contributions were imported into LibreOffice) or 
LibreOffice until 2018-02-21 21:22:32.
 * marks developers whose first contributions 
happened after 2010-09-28.
 Developers 
committing code since 2010-09-28
 
@@ -1074,10 +1072,10 @@
Vladimir 
GlazunovCommits: 25434Joined: 
2000-12-04
   
   
-   Caolán 
McNamaraCommits: 23451Joined: 
2000-10-10
+   Caolán 
McNamaraCommits: 23643Joined: 
2000-10-10
   
   
-   Stephan 
BergmannCommits: 15697Joined: 
2000-10-04
+   Stephan 
BergmannCommits: 15825Joined: 
2000-10-04
   
   
Ivo 
HinkelmannCommits: 9480Joined: 
2002-09-09
@@ -1085,30 +1083,30 @@
  
  
   
-   *Noel GrandinCommits: 
8646Joined: 2011-12-12
+   *Noel GrandinCommits: 
8847Joined: 2011-12-12
   
   
-   Tor 
LillqvistCommits: 8091Joined: 
2010-03-23
+  

[Libreoffice-commits] core.git: readlicense_oo/license

[Christian Lohmaier]

 readlicense_oo/license/CREDITS.fodt | 4220 +++-
 1 file changed, 2292 insertions(+), 1928 deletions(-)

New commits:
commit 8faa6b8bbaf89f95d7c319d70af855331cc99b7d
Author: Christian Lohmaier 
Date:   Thu Feb 22 13:53:46 2018 +0100

update credits

Change-Id: I189e30718e5818d183dc308ecbb96f4943b4e20a

diff --git a/readlicense_oo/license/CREDITS.fodt 
b/readlicense_oo/license/CREDITS.fodt
index e8ec085487aa..73999319624f 100644
--- a/readlicense_oo/license/CREDITS.fodt
+++ b/readlicense_oo/license/CREDITS.fodt
@@ -1,10 +1,10 @@
 
 
 http://www.w3.org/1999/xlink"; 
xmlns:dc="http://purl.org/dc/elements/1.1/"; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML"; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" 
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oas
 is:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office"; 
xmlns:ooow="http://openoffice.org/2004/writer"; 
xmlns:oooc="http://openoffice.org/2004/calc"; 
xmlns:dom="http://www.w3.org/2001/xml-events"; 
xmlns:xforms="http://www.w3.org/2002/xforms"; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xmlns:rpt="http://openoffice.org/2005/report"; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml"; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#"; 
xmlns:officeooo="http://openoffice.org/2009/office"; 
xmlns:tableooo="http://openoffice.org/2009/table"; 
xmlns:drawooo="http://openoffice.org/2010/draw"; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:formx="urn:openoffice:names:
 experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/"; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.text">
- Credits » 
LibreOfficeCreditscontributorscodersdevelopersCredits
 for the LibreOffice 
development/coding.LibreOffice/5.4.4.2$Linux_X86_64
 
LibreOffice_project/2524958677847fb3bb44820e40380acbe820f9602012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA
+ Credits » 
LibreOfficeCreditscontributorscodersdevelopersCredits
 for the LibreOffice 
development/coding.LibreOffice/6.0.1.1$Linux_X86_64
 
LibreOffice_project/60bfb1526849283ce2491346ed2aa51c465abfe62012-02-20T22:17:18.06000PT14M12S3JUebjoxEpqXoQcpltWRTwzBZEEHtch3wApdhgiQPFiA
  
   
-   563
+   690
501
41965
21327
@@ -16,9 +16,9 @@
  3649
  3471
  501
- 563
+ 690
  42464
- 21888
+ 22015
  0
  0
  false
@@ -39,6 +39,7 @@

false
false
+   true
false
false
false
@@ -71,7 +72,7 @@
false
false
true
-   7433446
+   7512211
false
false
false
@@ -317,26 +318,23 @@
  
  
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   

   
-  
-   
-  
   

   
@@ -398,24 +396,24 @@

   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   
-   
+   
   
   

   
-  
+  

   
   
@@ -748,21 +746,21 @@

   
   
-   
+   
 



   
   
-   
+   
 



   
   
-   
+   
 


@@ -1047,7 +1045,7 @@

   
  Credits
-1309 individuals contributed to 
OpenOffice.org (and whose contributions were imported into LibreOffice) or 
LibreOffice until 2018-01-23 23:15:28.
+1318 individuals contributed to 
OpenOffice.org (and whose contributions were imported into LibreOffice) or 
LibreOffice until 2018-02-21 21:22:32.
 * marks developers whose first contributions 
happened after 2010-09-28.
 Developers 
committing code since 2010-09-28
 
@@ -1074,10 +1072,10 @@
Vladimir 
GlazunovCommits: 25434Joined: 
2000-12-04
   
   
-   Caolán 
McNamaraCommits: 23451Joined: 
2000-10-10
+   Caolán 
McNamaraCommits: 23643Joined: 
2000-10-10
   
   
-   Stephan 
BergmannCommits: 15697Joined: 
2000-10-04
+   Stephan 
BergmannCommits: 15825Joined: 
2000-10-04
   
   
Ivo 
HinkelmannCommits: 9480Joined: 
2002-09-09
@@ -1085,30 +1083,30 @@
  
  
   
-   *Noel GrandinCommits: 
8646Joined: 2011-12-12
+   *Noel GrandinCommits: 
8847Joined: 2011-12-12
   
   
-   Tor 
LillqvistCommits: 8091Joined: 
2010-03-23
+   Tor 
LillqvistCommits: 8116Joined: 
2010-03-23
   
   
-   M

[Libreoffice-commits] core.git: basctl/source sw/source

[Shubham Verma]

 basctl/source/basicide/basicbox.cxx|3 +--
 sw/source/ui/config/mailconfigpage.cxx |6 +++---
 2 files changed, 4 insertions(+), 5 deletions(-)

New commits:
commit 0c371a6b5e6c6251d782c7a8ecbe0ab32c7812ac
Author: Shubham Verma 
Date:   Sat Feb 17 16:52:15 2018 +0530

tdf#112689 : Replace chained O(U)StringBuffer::append() with operator+

Change-Id: I119d33b171da7024daab5c4ca4488ceb495eab2f
Reviewed-on: https://gerrit.libreoffice.org/49898
Tested-by: Jenkins 
Reviewed-by: Muhammet Kara 

diff --git a/basctl/source/basicide/basicbox.cxx 
b/basctl/source/basicide/basicbox.cxx
index 3efa5d01a8b6..01238926670f 100644
--- a/basctl/source/basicide/basicbox.cxx
+++ b/basctl/source/basicide/basicbox.cxx
@@ -408,8 +408,7 @@ void LanguageBox::FillBox()
 OUString sLanguage = SvtLanguageTable::GetLanguageString( 
eLangType );
 if ( bIsDefault )
 {
-sLanguage += " ";
-sLanguage += m_sDefaultLanguageStr;
+sLanguage += " " + m_sDefaultLanguageStr;
 }
 sal_Int32 nPos = InsertEntry( sLanguage );
 SetEntryData( nPos, new LanguageEntry( pLocale[i], bIsDefault ) );
diff --git a/sw/source/ui/config/mailconfigpage.cxx 
b/sw/source/ui/config/mailconfigpage.cxx
index 3e5b043812a4..c7509d5f9d71 100644
--- a/sw/source/ui/config/mailconfigpage.cxx
+++ b/sw/source/ui/config/mailconfigpage.cxx
@@ -383,10 +383,10 @@ void SwTestAccountSettingsDialog::Test()
 
 if (!bIsServer || !bIsLoggedIn)
 {
-OUStringBuffer aErrorMessage(m_sErrorServer);
+OUString aErrorMessage(m_sErrorServer);
 if (!sException.isEmpty())
-aErrorMessage.append("\n--\n").append(sException);
-m_pErrorsED->SetText(aErrorMessage.makeStringAndClear());
+aErrorMessage += "\n--\n" + sException;
+m_pErrorsED->SetText(aErrorMessage);
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [Libreoffice-commits] core.git: bin/gla11y config_host.mk.in configure.ac solenv/gbuild

[Samuel Thibault]

Hello,

Miklos Vajna, on jeu. 22 févr. 2018 09:53:43 +0100, wrote:
> On Wed, Feb 21, 2018 at 10:11:18AM +0100, Samuel Thibault 
>  wrote:
> > Rene Engelhard, on mer. 21 févr. 2018 10:02:08 +0100, wrote:
> > > OK, thanks - and then I wonder why this is ran in "normal" UIConfig 
> > > targets and
> > > not only in make check...
> > For the "error" cases (-W none), it makes sense: 
> > 
> > « Add to the build process error checking (only the hard errors such as
> > bogus target names). »
> > 
> > That's really the kind of issues one should get as soon as compilation
> > time.
> > 
> > Later on I'll add a call in "make check" time for the warnings.
> 
> For source code we have warnings for these linter type problems

Err, these are not just "linter type problems". They are undefined
references, just like undefined C references. So the failure belongs to
compilation time. If somebody modifies a .ui file in a way that gets
such undefined reference, compilation itself should really fail, just
like it does when a variable defintion is missing.

The "make check" warnings I mentioned above are *other* kinds of issues,
which would indeed only be tested within make check, made warnings by
default, and turned into errors by Jenkins.

Samuel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - sc/source sd/source sw/source

[Pranav Kant]

 sc/source/ui/unoobj/docuno.cxx|4 ++--
 sd/source/ui/unoidl/unomodel.cxx  |5 +++--
 sw/source/uibase/uno/unotxdoc.cxx |4 ++--
 3 files changed, 7 insertions(+), 6 deletions(-)

New commits:
commit d5f0b3d725f678c1a7eb4b8b4ab3a2279742260c
Author: Pranav Kant 
Date:   Thu Feb 22 17:40:35 2018 +0530

Revert posting key events on the main thread

This partially reverts commit f2d3192e8a4ae743fcaab27ab6d829d57ae8fb60.

Change-Id: Ic273e3f742d48dbfb73060a6ecb4feb80afdcfaa
Reviewed-on: https://gerrit.libreoffice.org/50174
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx
index f415a7b5cd4c..b6cbc5e46fac 100644
--- a/sc/source/ui/unoobj/docuno.cxx
+++ b/sc/source/ui/unoobj/docuno.cxx
@@ -623,10 +623,10 @@ void ScModelObj::postKeyEvent(int nType, int nCharCode, 
int nKeyCode)
 switch (nType)
 {
 case LOK_KEYEVENT_KEYINPUT:
-Application::PostKeyEvent(VCLEVENT_WINDOW_KEYINPUT, pWindow, &aEvent);
+pWindow->KeyInput(aEvent);
 break;
 case LOK_KEYEVENT_KEYUP:
-Application::PostKeyEvent(VCLEVENT_WINDOW_KEYUP, pWindow, &aEvent);
+pWindow->KeyUp(aEvent);
 break;
 default:
 assert(false);
diff --git a/sd/source/ui/unoidl/unomodel.cxx b/sd/source/ui/unoidl/unomodel.cxx
index 30971a584e49..d9ea81e4982e 100644
--- a/sd/source/ui/unoidl/unomodel.cxx
+++ b/sd/source/ui/unoidl/unomodel.cxx
@@ -2507,13 +2507,14 @@ void SdXImpressDocument::postKeyEvent(int nType, int 
nCharCode, int nKeyCode)
 return;
 
 KeyEvent aEvent(nCharCode, nKeyCode, 0);
+
 switch (nType)
 {
 case LOK_KEYEVENT_KEYINPUT:
-Application::PostKeyEvent(VCLEVENT_WINDOW_KEYINPUT, pWindow, &aEvent);
+pWindow->KeyInput(aEvent);
 break;
 case LOK_KEYEVENT_KEYUP:
-Application::PostKeyEvent(VCLEVENT_WINDOW_KEYUP, pWindow, &aEvent);
+pWindow->KeyUp(aEvent);
 break;
 default:
 assert(false);
diff --git a/sw/source/uibase/uno/unotxdoc.cxx 
b/sw/source/uibase/uno/unotxdoc.cxx
index 103ae13f9111..0244b3db6a2b 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -3499,10 +3499,10 @@ void SwXTextDocument::postKeyEvent(int nType, int 
nCharCode, int nKeyCode)
 switch (nType)
 {
 case LOK_KEYEVENT_KEYINPUT:
-Application::PostKeyEvent(VCLEVENT_WINDOW_KEYINPUT, pWindow, &aEvent);
+pWindow->KeyInput(aEvent);
 break;
 case LOK_KEYEVENT_KEYUP:
-Application::PostKeyEvent(VCLEVENT_WINDOW_KEYUP, pWindow, &aEvent);
+pWindow->KeyUp(aEvent);
 break;
 default:
 assert(false);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - oox/source

[Jan Holesovsky]

 oox/source/core/xmlfilterbase.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 8dde1396f7c9aed30590bc7c55d3ac0e2252381f
Author: Jan Holesovsky 
Date:   Thu Feb 22 13:01:55 2018 +0100

Fix build.

Change-Id: I1048970fdfa431d20ff4f7861b7f1788aadedf4e
Reviewed-on: https://gerrit.libreoffice.org/50173
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/oox/source/core/xmlfilterbase.cxx 
b/oox/source/core/xmlfilterbase.cxx
index c858bd707e16..00d23a377564 100644
--- a/oox/source/core/xmlfilterbase.cxx
+++ b/oox/source/core/xmlfilterbase.cxx
@@ -51,7 +51,6 @@
 #include "oox/helper/zipstorage.hxx"
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -69,6 +68,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using ::com::sun::star::xml::dom::DocumentBuilder;
 using ::com::sun::star::xml::dom::XDocument;
@@ -1013,7 +1013,7 @@ void 
XmlFilterBase::importCustomFragments(css::uno::Reference xCustDoc = importFragment("customXml/item" + 
OUString::number(i) + ".xml");
 Reference xCustDocProps = 
importFragment("customXml/itemProps" + OUString::number(i) + ".xml");
-if (xCustDoc && xCustDocProps)
+if (xCustDoc.is() && xCustDocProps.is())
 {
 aCustomXmlDomList.emplace_back(xCustDoc);
 aCustomXmlDomPropsList.emplace_back(xCustDocProps);
@@ -1082,7 +1082,7 @@ void XmlFilterBase::exportCustomFragments()
 const OUString fragmentPath = "customXml/item" + 
OUString::number((j+1)) + ".xml";
 if (customXmlDom.is())
 {
-addRelation(oox::getRelationship(Relationship::CUSTOMXML), "../" + 
fragmentPath);
+
addRelation("http://schemas.openxmlformats.org/officeDocument/2006/relationships/customXml";,
 "../" + fragmentPath);
 
 uno::Reference 
serializer(customXmlDom, uno::UNO_QUERY);
 uno::Reference writer = 
xml::sax::Writer::create(comphelper::getProcessComponentContext());
@@ -1102,7 +1102,7 @@ void XmlFilterBase::exportCustomFragments()
 
 // Adding itemprops's relationship entry to item.xml.rels file
 addRelation(openFragmentStream(fragmentPath, "application/xml"),
-oox::getRelationship(Relationship::CUSTOMXMLPROPS),
+
"http://schemas.openxmlformats.org/officeDocument/2006/relationships/customXmlProps";,
 "itemProps"+OUString::number((j+1))+".xml");
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa

[Zdeněk Crhonek]

 sw/qa/uitest/writer_tests/watermark.py |   67 +
 1 file changed, 67 insertions(+)

New commits:
commit e313f0f959dfe0977366a8342ba43dbea6703adb
Author: Zdeněk Crhonek 
Date:   Wed Feb 21 21:22:32 2018 +0100

uitest - writer Watermark dialog

Change-Id: If701a563ce2ff0e811dfcaae6852ada05c925ce3
Reviewed-on: https://gerrit.libreoffice.org/50126
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sw/qa/uitest/writer_tests/watermark.py 
b/sw/qa/uitest/writer_tests/watermark.py
new file mode 100644
index ..d42f37bb2aff
--- /dev/null
+++ b/sw/qa/uitest/writer_tests/watermark.py
@@ -0,0 +1,67 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+from uitest.framework import UITestCase
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.uihelper.common import get_state_as_dict
+import time
+from uitest.debug import sleep
+from uitest.uihelper.common import select_pos
+
+
+class watermark(UITestCase):
+
+   def test_insert_watermark(self):
+self.ui_test.create_doc_in_start_center("writer")
+document = self.ui_test.get_component()
+xWriterDoc = self.xUITest.getTopFocusWindow()
+xWriterEdit = xWriterDoc.getChild("writer_edit")
+
+self.ui_test.execute_dialog_through_command(".uno:Watermark")
+xDialog = self.xUITest.getTopFocusWindow()
+xTextInput = xDialog.getChild("TextInput")
+xAngle = xDialog.getChild("Angle")
+xTransparency = xDialog.getChild("Transparency")
+
+xTextInput.executeAction("TYPE", 
mkPropertyValues({"TEXT":"Watermark"}))
+xAngle.executeAction("UP", tuple())
+xTransparency.executeAction("UP", tuple())
+
+xOkBtn = xDialog.getChild("ok")
+self.ui_test.close_dialog_through_button(xOkBtn)
+
+self.ui_test.execute_dialog_through_command(".uno:Watermark")
+xDialog = self.xUITest.getTopFocusWindow()
+xTextInput = xDialog.getChild("TextInput")
+xAngle = xDialog.getChild("Angle")
+xTransparency = xDialog.getChild("Transparency")
+
+self.assertEqual(get_state_as_dict(xTextInput)["Text"], "Watermark")
+self.assertEqual(get_state_as_dict(xAngle)["Text"], "46")
+self.assertEqual(get_state_as_dict(xTransparency)["Text"], "51")
+
+xCancBtn = xDialog.getChild("cancel")
+self.ui_test.close_dialog_through_button(xCancBtn)
+
+self.ui_test.execute_dialog_through_command(".uno:Watermark")
+xDialog = self.xUITest.getTopFocusWindow()
+xTextInput = xDialog.getChild("TextInput")
+xTextInput.executeAction("TYPE", 
mkPropertyValues({"KEYCODE":"CTRL+A"}))
+xTextInput.executeAction("TYPE", 
mkPropertyValues({"KEYCODE":"BACKSPACE"}))
+xOkBtn = xDialog.getChild("ok")
+self.ui_test.close_dialog_through_button(xOkBtn)
+
+self.ui_test.execute_dialog_through_command(".uno:Watermark")
+xDialog = self.xUITest.getTopFocusWindow()
+xTextInput = xDialog.getChild("TextInput")
+
+self.assertEqual(get_state_as_dict(xTextInput)["Text"], "")
+
+xCancBtn = xDialog.getChild("cancel")
+self.ui_test.close_dialog_through_button(xCancBtn)
+
+self.ui_test.close_doc()
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - external/liborcus

[Kohei Yoshida]

 
external/liborcus/0001-protect-the-self-closing-xml-element-code-against-se.patch
 |   30 ++
 external/liborcus/UnpackedTarball_liborcus.mk  
   |1 
 2 files changed, 31 insertions(+)

New commits:
commit 76bb102d90ecc04de0dd016019c31ba1abcb9b26
Author: Kohei Yoshida 
Date:   Wed Feb 21 20:08:23 2018 -0500

Patch liborcus to avoid incorrect parsing of XML.

Found by Antti Levomäki and Christian Jalio from Forcepoint.

This one is not a backport from the master branch.  On the master
branch the same fix will come from updating liborcus from 0.13.3
to 0.13.4.

Change-Id: I701c5a65ff67d77767913f8d056682b9db549f84
Reviewed-on: https://gerrit.libreoffice.org/50146
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git 
a/external/liborcus/0001-protect-the-self-closing-xml-element-code-against-se.patch
 
b/external/liborcus/0001-protect-the-self-closing-xml-element-code-against-se.patch
new file mode 100644
index ..990665f9c383
--- /dev/null
+++ 
b/external/liborcus/0001-protect-the-self-closing-xml-element-code-against-se.patch
@@ -0,0 +1,30 @@
+From 12e5d89cbd7101c61fbdf063322203a1590a0ef5 Mon Sep 17 00:00:00 2001
+From: Markus Mohrhard 
+Date: Wed, 21 Feb 2018 00:29:03 +0100
+Subject: [PATCH] protect the self-closing xml element code against
+ self-closing root elements
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Found by Antti Levomäki and Christian Jalio from Forcepoint.
+---
+ include/orcus/sax_parser.hpp | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/include/orcus/sax_parser.hpp b/include/orcus/sax_parser.hpp
+index ba5ebcd..67d5943 100644
+--- a/include/orcus/sax_parser.hpp
 b/include/orcus/sax_parser.hpp
+@@ -171,6 +171,8 @@ void 
sax_parser<_Handler,_Config>::element_open(std::ptrdiff_t begin_pos)
+ m_handler.start_element(elem);
+ reset_buffer_pos();
+ m_handler.end_element(elem);
++if (!m_nest_level)
++m_root_elem_open = false;
+ #if ORCUS_DEBUG_SAX_PARSER
+ cout << "element_open: ns='" << elem.ns << "', name='" << 
elem.name << "' (self-closing)" << endl;
+ #endif
+-- 
+2.7.4
+
diff --git a/external/liborcus/UnpackedTarball_liborcus.mk 
b/external/liborcus/UnpackedTarball_liborcus.mk
index e9270c24a5cb..7fadaa46b1c9 100644
--- a/external/liborcus/UnpackedTarball_liborcus.mk
+++ b/external/liborcus/UnpackedTarball_liborcus.mk
@@ -19,6 +19,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,liborcus,\
external/liborcus/0001-workaround-a-linking-problem-on-windows.patch \
external/liborcus/rpath.patch.0 \
external/liborcus/silence-assert.patch \
+   
external/liborcus/0001-protect-the-self-closing-xml-element-code-against-se.patch
 \
 ))
 
 ifeq ($(OS),WNT)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - external/liborcus

[Kohei Yoshida]

 
external/liborcus/0001-protect-the-self-closing-xml-element-code-against-se.patch
 |   30 ++
 external/liborcus/UnpackedTarball_liborcus.mk  
   |1 
 2 files changed, 31 insertions(+)

New commits:
commit f25bc1254782589af5d24471599260b65558154a
Author: Kohei Yoshida 
Date:   Wed Feb 21 20:08:23 2018 -0500

Patch liborcus to avoid incorrect parsing of XML.

Found by Antti Levomäki and Christian Jalio from Forcepoint.

This one is not a backport from the master branch.  On the master
branch the same fix will come from updating liborcus from 0.13.3
to 0.13.4.

(cherry picked from commit 160350de5f07024b22fb5a9b596918ccc7f22c75)

 Conflicts:
external/liborcus/UnpackedTarball_liborcus.mk

Change-Id: I701c5a65ff67d77767913f8d056682b9db549f84
Reviewed-on: https://gerrit.libreoffice.org/50147
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git 
a/external/liborcus/0001-protect-the-self-closing-xml-element-code-against-se.patch
 
b/external/liborcus/0001-protect-the-self-closing-xml-element-code-against-se.patch
new file mode 100644
index ..990665f9c383
--- /dev/null
+++ 
b/external/liborcus/0001-protect-the-self-closing-xml-element-code-against-se.patch
@@ -0,0 +1,30 @@
+From 12e5d89cbd7101c61fbdf063322203a1590a0ef5 Mon Sep 17 00:00:00 2001
+From: Markus Mohrhard 
+Date: Wed, 21 Feb 2018 00:29:03 +0100
+Subject: [PATCH] protect the self-closing xml element code against
+ self-closing root elements
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Found by Antti Levomäki and Christian Jalio from Forcepoint.
+---
+ include/orcus/sax_parser.hpp | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/include/orcus/sax_parser.hpp b/include/orcus/sax_parser.hpp
+index ba5ebcd..67d5943 100644
+--- a/include/orcus/sax_parser.hpp
 b/include/orcus/sax_parser.hpp
+@@ -171,6 +171,8 @@ void 
sax_parser<_Handler,_Config>::element_open(std::ptrdiff_t begin_pos)
+ m_handler.start_element(elem);
+ reset_buffer_pos();
+ m_handler.end_element(elem);
++if (!m_nest_level)
++m_root_elem_open = false;
+ #if ORCUS_DEBUG_SAX_PARSER
+ cout << "element_open: ns='" << elem.ns << "', name='" << 
elem.name << "' (self-closing)" << endl;
+ #endif
+-- 
+2.7.4
+
diff --git a/external/liborcus/UnpackedTarball_liborcus.mk 
b/external/liborcus/UnpackedTarball_liborcus.mk
index 93b988553116..791436e66016 100644
--- a/external/liborcus/UnpackedTarball_liborcus.mk
+++ b/external/liborcus/UnpackedTarball_liborcus.mk
@@ -18,6 +18,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,liborcus,\
external/liborcus/rpath.patch.0 \
external/liborcus/visibility.patch.0 \
external/liborcus/nullptr-in-ostringstream.patch.1 \
+   
external/liborcus/0001-protect-the-self-closing-xml-element-code-against-se.patch
 \
 ))
 
 ifeq ($(OS),WNT)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - translations

[Christian Lohmaier]

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 18350415ae85823d66fe9d063fd4eb75a6b77034
Author: Christian Lohmaier 
Date:   Thu Feb 22 12:41:14 2018 +0100

Updated core
Project: translations  a67ce9f4daaddb3b7a1a17ab5d4cb2216eec3961

update translations for 6.0.2 rc1

and force-fix errors using pocheck

Change-Id: I760bd52e6a79b34ebf7f59f7d7c11ce7605b4a79
(cherry picked from commit db79c9d122d554eb563cb501b8eafb289b38)

diff --git a/translations b/translations
index 27745d017226..a67ce9f4daad 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 27745d0172265edac7ea74fefc12de23d1037f4d
+Subproject commit a67ce9f4daaddb3b7a1a17ab5d4cb2216eec3961
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: translations

[Christian Lohmaier]

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b5ca7b7d6871be7a4f4de6f2e152cc98762e096a
Author: Christian Lohmaier 
Date:   Thu Feb 22 12:41:14 2018 +0100

Updated core
Project: translations  db79c9d122d554eb563cb501b8eafb289b38

update translations for 6.0.2 rc1

and force-fix errors using pocheck

Change-Id: I760bd52e6a79b34ebf7f59f7d7c11ce7605b4a79

diff --git a/translations b/translations
index 4092195506ca..db79c9d1 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 4092195506ca82679ed8ed0feb596777a39aaa20
+Subproject commit db79c9d122d554eb563cb501b8eafb289b38
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/osl

[Aron Budea]

 include/osl/file.hxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 2219f0f6f85316d05231130c89613b98e7fd2cf5
Author: Aron Budea 
Date:   Wed Feb 21 14:49:11 2018 +0100

tdf#115383: revert mixup of E_ROFS and E_SPIPE in file.hxx

Regression from a9739f2dec197793fa9400dd95be49494dc85264

Change-Id: I1b55b0201888a63bd2439be8c0421f450d609018
Reviewed-on: https://gerrit.libreoffice.org/50103
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 
Reviewed-by: Michael Stahl 

diff --git a/include/osl/file.hxx b/include/osl/file.hxx
index f6764f14ed27..76b2a1bb110f 100644
--- a/include/osl/file.hxx
+++ b/include/osl/file.hxx
@@ -80,8 +80,8 @@ public:
 E_NOTTY= osl_File_E_NOTTY,  ///< inappropriate I/O 
control operation
 E_FBIG = osl_File_E_FBIG,   ///< file too large
 E_NOSPC= osl_File_E_NOSPC,  ///< no space left on 
device, write failed
-E_SPIPE= osl_File_E_ROFS,   ///< invalid seek 
operation (such as on pipe)
-E_ROFS = osl_File_E_SPIPE,  ///< illegal modification 
to read-only filesystem
+E_SPIPE= osl_File_E_SPIPE,  ///< invalid seek 
operation (such as on pipe)
+E_ROFS = osl_File_E_ROFS,   ///< illegal modification 
to read-only filesystem
 E_MLINK= osl_File_E_MLINK,  ///< too many links to file
 E_PIPE = osl_File_E_PIPE,   ///< broken pipe; no 
process reading from other end of pipe
 E_DOM  = osl_File_E_DOM,///< domain error 
(mathematical error)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits