date:20180325

Re: GSoC 2018 : LIbreOffice | LOEclipse | Introduction : Shobhan Mandal

2018-03-25 Thread Samuel Mehrbrodt


Hi Markus,

Shobhan and I are in touch and we are on it.

For reference, here are his patches to LOEclipse up to now:

Merged: 
https://github.com/LibreOffice/loeclipse/commits?author=shobhanmandal


Under review: https://github.com/LibreOffice/loeclipse/pulls/shobhanmandal

Regards
Samuel


Am 25.03.2018 um 19:47 schrieb Markus Mohrhard:

Hello Shobhan,

On Wed, Mar 21, 2018 at 10:23 AM, Shobhan Mandal 
mailto:dev.shobhanman...@gmail.com>> wrote:


Greetings LibreOffice Community,

I am Shobhan Mandal, currently pursuing my Masters Degree in
Computer Science from International Institute of Information
Technology - Hyderabad, Hyderabad, Telangana, India.

I am interested in working on the GSoC 2018 project in LOEclipse
under LibreOffice. I have also started submitting patches towards
LOEclipse for the same. With experience in making projects using
C, Java and Python and help from this beautiful community, I
believe we can make some fruitful contribution to the LOEclipse
code-base.

Any help from you guys on improving how I contribute will always
be appreciated. Looking forward to working with you guys.


You should get in contact with Samuel and discuss your ideas to write 
a good application.


Regards,
Markus


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 2 commits - include/vcl sfx2/CppunitTest_sfx2_misc.mk vcl/headless vcl/inc vcl/opengl vcl/osx vcl/qt5 vcl/quartz vcl/source vcl/unx vcl/win writerperfect/Library_writer

2018-03-25 Thread Noel Grandin

 include/vcl/metaact.hxx  |1 
 include/vcl/outdevstate.hxx  |   17 ++---
 include/vcl/pdfwriter.hxx|1 
 include/vcl/salgtype.hxx |   12 ---
 sfx2/CppunitTest_sfx2_misc.mk|5 +
 vcl/headless/svpgdi.cxx  |   88 -
 vcl/headless/svptext.cxx |4 -
 vcl/inc/headless/svpgdi.hxx  |   18 ++---
 vcl/inc/opengl/LineRenderUtils.hxx   |2 
 vcl/inc/opengl/RenderList.hxx|   12 +--
 vcl/inc/opengl/VertexUtils.hxx   |   12 +--
 vcl/inc/opengl/program.hxx   |4 -
 vcl/inc/openglgdiimpl.hxx|   28 
 vcl/inc/outdata.hxx  |5 -
 vcl/inc/quartz/salbmp.h  |2 
 vcl/inc/quartz/salgdi.h  |   12 +--
 vcl/inc/quartz/salgdicommon.hxx  |9 --
 vcl/inc/salgdi.hxx   |   18 ++---
 vcl/inc/salgdiimpl.hxx   |   11 +--
 vcl/inc/textrender.hxx   |2 
 vcl/inc/unx/cairotextrender.hxx  |4 -
 vcl/inc/unx/genpspgraphics.h |   12 +--
 vcl/inc/unx/saldisp.hxx  |   12 +--
 vcl/inc/unx/salgdi.h |   24 +++
 vcl/inc/win/salgdi.h |   14 ++--
 vcl/opengl/LineRenderUtils.cxx   |8 +-
 vcl/opengl/RenderList.cxx|   18 ++---
 vcl/opengl/gdiimpl.cxx   |   58 -
 vcl/opengl/program.cxx   |   16 ++--
 vcl/osx/a11ytextattributeswrapper.mm |6 -
 vcl/osx/salinst.cxx  |2 
 vcl/qt5/Qt5Graphics.cxx  |6 -
 vcl/qt5/Qt5Graphics.hxx  |   18 ++---
 vcl/qt5/Qt5Graphics_GDI.cxx  |   12 +--
 vcl/qt5/Qt5Graphics_Text.cxx |2 
 vcl/quartz/salbmp.cxx|8 +-
 vcl/quartz/salgdi.cxx|6 -
 vcl/quartz/salgdicommon.cxx  |   34 +-
 vcl/source/gdi/salgdilayout.cxx  |8 +-
 vcl/source/outdev/gradient.cxx   |   14 ++--
 vcl/source/outdev/mask.cxx   |4 -
 vcl/source/outdev/outdevstate.cxx|   30 +++-
 vcl/source/outdev/pixel.cxx  |   10 --
 vcl/source/outdev/text.cxx   |4 -
 vcl/source/outdev/textline.cxx   |   10 +-
 vcl/unx/generic/app/saldisp.cxx  |  105 +++
 vcl/unx/generic/gdi/cairotextrender.cxx  |   14 ++--
 vcl/unx/generic/gdi/font.cxx |6 -
 vcl/unx/generic/gdi/gdiimpl.cxx  |   76 +++---
 vcl/unx/generic/gdi/gdiimpl.hxx  |   14 ++--
 vcl/unx/generic/gdi/salbmp.cxx   |   16 ++--
 vcl/unx/generic/gdi/salgdi.cxx   |   50 +++---
 vcl/unx/generic/gdi/salgdi2.cxx  |4 -
 vcl/unx/generic/gdi/xrender_peer.hxx |   10 +-
 vcl/unx/generic/print/genpspgraphics.cxx |   36 +-
 vcl/win/gdi/gdiimpl.cxx  |   75 ++
 vcl/win/gdi/gdiimpl.hxx  |   14 ++--
 vcl/win/gdi/salfont.cxx  |   10 +-
 vcl/win/gdi/salgdi.cxx   |   20 ++---
 vcl/win/gdi/salgdi2.cxx  |4 -
 vcl/win/gdi/salnativewidgets-luna.cxx|4 -
 vcl/win/gdi/winlayout.cxx|6 -
 writerperfect/Library_writerperfect.mk   |1 
 xmlsecurity/Executable_pdfverify.mk  |2 
 64 files changed, 519 insertions(+), 551 deletions(-)

New commits:
commit 38e7aef0fad58dcf2d59a7c219b7858d6c4cd771
Author: Noel Grandin 
Date:   Fri Mar 23 11:52:20 2018 +0200

use boost::optional in OutDevState

Change-Id: I83fb85fcba6cd2a5dc4f99fdfd3238d72afb7bc2
Reviewed-on: https://gerrit.libreoffice.org/51770
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/vcl/metaact.hxx b/include/vcl/metaact.hxx
index 9fac991ac19e..930261b5866f 100644
--- a/include/vcl/metaact.hxx
+++ b/include/vcl/metaact.hxx
@@ -36,7 +36,6 @@
 #include 
 #include 
 #include 
-#include 
 
 class SvStream;
 enum class DrawTextFlags;
diff --git a/include/vcl/outdevstate.hxx b/include/vcl/outdevstate.hxx
index d58faac00c52..d1f1ff6726b9 100644
--- a/include/vcl/outdevstate.hxx
+++ b/include/vcl/outdevstate.hxx
@@ -30,6 +30,7 @@
 #include 
 #include 
 #include 
+#include 
 
 class Color;
 
@@ -80,17 +81,17 @@ public:
 OutDevState();
 ~OutDevState();
 
-std::unique_ptrmpMapMode;
+boost::optionalmpMapMode;
 boolmbMapActive;
 std::unique_ptrmpClipRegion;
-std::unique_ptr  mpLineColor;
-std::unique_ptr  mpFillColor;
+boost::optional  mpLineColor;
+boost::optional  mpFillColor;
 std::unique_ptr  mpFont;
-std::unique_ptr  mpTextColor;
-std::unique_ptr  mpTextFillColor;
-std::unique_ptr  mpTextLineColor;
-std::unique_ptr

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 33 commits - chart2/source comphelper/source dbaccess/Library_dbahsql.mk dbaccess/source desktop/qa desktop/source embeddedobj/source

2018-03-25 Thread Henry Castro

 chart2/source/controller/inc/ChartWindow.hxx  |5 
 chart2/source/controller/main/ChartWindow.cxx |   15 
 comphelper/source/xml/ofopxmlhelper.cxx   |   32 
 dbaccess/Library_dbahsql.mk   |5 
 dbaccess/source/filter/hsqldb/columndef.hxx   |   10 
 dbaccess/source/filter/hsqldb/createparser.hxx|   10 
 dbaccess/source/filter/hsqldb/fbcreateparser.hxx  |   10 
 dbaccess/source/filter/hsqldb/hsqlbinarynode.cxx  |   61 +
 dbaccess/source/filter/hsqldb/hsqlbinarynode.hxx  |   39 +
 dbaccess/source/filter/hsqldb/hsqlimport.cxx  |  241 ++
 dbaccess/source/filter/hsqldb/hsqlimport.hxx  |   20 
 dbaccess/source/filter/hsqldb/parseschema.cxx |   26 
 dbaccess/source/filter/hsqldb/parseschema.hxx |   17 
 dbaccess/source/filter/hsqldb/rowinputbinary.cxx  |  246 
+++
 dbaccess/source/filter/hsqldb/rowinputbinary.hxx  |   46 +
 desktop/qa/desktop_lib/test_desktop_lib.cxx   |   13 
 desktop/source/lib/init.cxx   |   89 --
 embeddedobj/source/commonembedding/embedobj.cxx   |   34 
 extensions/source/ole/olethread.cxx   |   28 
 include/LibreOfficeKit/LibreOfficeKit.h   |   10 
 include/LibreOfficeKit/LibreOfficeKit.hxx |6 
 include/comphelper/ofopxmlhelper.hxx  |   12 
 include/oox/core/xmlfilterbase.hxx|6 
 include/sfx2/strings.hrc  |3 
 include/vbahelper/vbaaccesshelper.hxx |4 
 include/vcl/IDialogRenderable.hxx |2 
 include/vcl/ITiledRenderable.hxx  |  111 +++
 include/vcl/window.hxx|7 
 libreofficekit/qa/unit/tiledrendering.cxx |1 
 oox/source/core/xmlfilterbase.cxx |   40 -
 package/source/zippackage/ZipPackage.cxx  |   12 
 sc/qa/unit/data/xlsx/customxml.xlsx   |binary
 sc/qa/unit/helper/xpath.cxx   |7 
 sc/qa/unit/helper/xpath.hxx   |6 
 sc/qa/unit/subsequent_export-test.cxx |   21 
 sc/qa/unit/tiledrendering/tiledrendering.cxx  |3 
 sc/source/filter/excel/excdoc.cxx |3 
 sc/source/ui/cctrl/cbuttonw.cxx   |4 
 sc/source/ui/inc/gridwin.hxx  |7 
 sc/source/ui/unoobj/docuno.cxx|   47 -
 sc/source/ui/view/gridwin.cxx |   15 
 sc/source/ui/view/tabvwshf.cxx|   28 
 sd/qa/unit/data/pptx/customxml.pptx   |binary
 sd/qa/unit/export-tests-ooxml1.cxx|   23 
 sd/qa/unit/sdmodeltestbase.hxx|   21 
 sd/qa/unit/tiledrendering/tiledrendering.cxx  |7 
 sd/source/filter/eppt/pptx-epptooxml.cxx  |4 
 sd/source/ui/inc/ViewShell.hxx|6 
 sd/source/ui/inc/Window.hxx   |6 
 sd/source/ui/unoidl/unomodel.cxx  |   38 -
 sd/source/ui/view/sdwindow.cxx|   39 +
 sd/source/ui/view/viewshel.cxx|   39 -
 sfx2/source/dialog/mailmodel.cxx  |4 
 sfx2/source/doc/objserv.cxx   |   49 -
 sfx2/source/view/lokcharthelper.cxx   |   41 -
 shell/Executable_senddoc.mk   |8 
 shell/Library_smplmail.mk |7 
 shell/Module_shell.mk |1 
 shell/StaticLibrary_simplemapi.mk |   16 
 shell/source/win32/simplemail/senddoc.cxx |  346 
++
 shell/source/win32/simplemail/simplemapi.cxx  |   88 --
 shell/source/win32/simplemail/simplemapi.hxx  |   75 --
 shell/source/win32/simplemail/smplmailclient.cxx  |  124 +++
 shell/source/win32/simplemail/smplmailclient.hxx  |7 
 shell/source/win32/simplemail/smplmailsuppl.cxx   |3 
 shell/source/win32/simplemail/smplmailsuppl.hxx   |2 
 s

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - jvmaccess/inc jvmaccess/util

2018-03-25 Thread Damjan Jovanovic

 jvmaccess/inc/jvmaccess/unovirtualmachine.hxx |   18 +-
 jvmaccess/inc/jvmaccess/virtualmachine.hxx|   20 ++--
 jvmaccess/util/gcc3.map   |8 
 jvmaccess/util/mingw.map  |8 
 4 files changed, 27 insertions(+), 27 deletions(-)

New commits:
commit 2e2e14976eec69b80c04bdf4f5e8d393e04b78dc
Author: Damjan Jovanovic 
Date:   Mon Mar 26 04:48:54 2018 +

On Windows the main/jvmaccess module refuses to be linked to by main/stoc

due to not exporting typeinfos, or refuses to compile because it needs
array constructors from salhelper's simplereferenceobject.

It seems we have to hide all typeinfos, and export methods on a
case-by-case basis, just like the .map files do. This gets it to compile,
and seems to get main/stoc to link to it successfully.

Patch by: me

diff --git a/jvmaccess/inc/jvmaccess/unovirtualmachine.hxx 
b/jvmaccess/inc/jvmaccess/unovirtualmachine.hxx
index 73ada3b86c81..1e85c131fd30 100644
--- a/jvmaccess/inc/jvmaccess/unovirtualmachine.hxx
+++ b/jvmaccess/inc/jvmaccess/unovirtualmachine.hxx
@@ -36,20 +36,20 @@ class VirtualMachine;
 /** An encapsulating wrapper around a Java virtual machine and an appropriate
 UNO class loader.
  */
-class JVMACCESS_DLLPUBLIC UnoVirtualMachine: public 
salhelper::SimpleReferenceObject {
+class UnoVirtualMachine: public salhelper::SimpleReferenceObject {
 public:
 /** An exception indicating failure to create a UnoVirtualMachine.
  */
-class JVMACCESS_DLLPUBLIC CreationException
+class CreationException
 {
 public:
-CreationException();
+JVMACCESS_DLLPUBLIC CreationException();
 
-CreationException(CreationException const &);
+JVMACCESS_DLLPUBLIC CreationException(CreationException const &);
 
-virtual ~CreationException();
+JVMACCESS_DLLPUBLIC virtual ~CreationException();
 
-CreationException & operator =(CreationException const &);
+JVMACCESS_DLLPUBLIC CreationException & operator =(CreationException 
const &);
 };
 
 /** Create a wrapper around a Java virtual machine and an appropriate UNO
@@ -69,7 +69,7 @@ public:
 @exception CreationException
 Thrown in case creation fails (due to a JNI problem).
  */
-UnoVirtualMachine(
+JVMACCESS_DLLPUBLIC UnoVirtualMachine(
 rtl::Reference< jvmaccess::VirtualMachine > const & virtualMachine,
 void * classLoader);
 
@@ -78,7 +78,7 @@ public:
 @return
 The Java virtual machine wrapper.  Will never be null.
  */
-rtl::Reference< jvmaccess::VirtualMachine > getVirtualMachine() const;
+JVMACCESS_DLLPUBLIC rtl::Reference< jvmaccess::VirtualMachine > 
getVirtualMachine() const;
 
 /** Get the UNO class loader.
 
@@ -89,7 +89,7 @@ public:
 different for different JDK versions, so that the mangled C++ name of
 the function would depend on the JDK version used at compile time.
  */
-void * getClassLoader() const;
+JVMACCESS_DLLPUBLIC void * getClassLoader() const;
 
 private:
 UnoVirtualMachine(UnoVirtualMachine &); // not defined
diff --git a/jvmaccess/inc/jvmaccess/virtualmachine.hxx 
b/jvmaccess/inc/jvmaccess/virtualmachine.hxx
index 79205b1d3524..8ea6136bf342 100644
--- a/jvmaccess/inc/jvmaccess/virtualmachine.hxx
+++ b/jvmaccess/inc/jvmaccess/virtualmachine.hxx
@@ -41,7 +41,7 @@ namespace jvmaccess {
 
 /** An encapsulating wrapper around a Java virtual machine.
  */
-class JVMACCESS_DLLPUBLIC VirtualMachine: public 
salhelper::SimpleReferenceObject
+class VirtualMachine: public salhelper::SimpleReferenceObject
 {
 public:
 /** A helper to attach a thread to a Java virtual machine.
@@ -54,21 +54,21 @@ public:
 detach the thread from the virtual machine upon destruction of the 
guard
 at the bottom of the stack).
  */
-class JVMACCESS_DLLPUBLIC AttachGuard
+class AttachGuard
 {
 public:
 /** An exception indicating failure to create an AttachGuard.
  */
-class JVMACCESS_DLLPUBLIC CreationException
+class CreationException
 {
 public:
-CreationException();
+JVMACCESS_DLLPUBLIC CreationException();
 
-CreationException(CreationException const &);
+JVMACCESS_DLLPUBLIC CreationException(CreationException const &);
 
-virtual ~CreationException();
+JVMACCESS_DLLPUBLIC virtual ~CreationException();
 
-CreationException & operator =(CreationException const &);
+JVMACCESS_DLLPUBLIC CreationException & operator 
=(CreationException const &);
 };
 
 /** Attach the current thread to a virtual machine.
@@ -79,11 +79,11 @@ public:
 @exception CreationException
 Thrown in case attaching fails (due to a JNI problem).
  */
-explicit AttachGuard(rtl::Reference< Vi

Nickson Thanda license statement

2018-03-25 Thread Nick Thanda

All of my past & future contributions to LibreOffice may be licensed under the 
MPLv2/LGPLv3+ dual license.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/uiconfig

2018-03-25 Thread Stanislav Horacek

 sw/uiconfig/swriter/ui/queryrotateintostandarddialog.ui |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a488c7ad2763b944713997911c1ddb0315d8c93f
Author: Stanislav Horacek 
Date:   Sun Mar 25 13:21:32 2018 +0200

fix typo in dialog about rotation to standard orientation

Change-Id: Ia587c7fb41ed17e0c46845ca1823049ed6dfd67c

diff --git a/sw/uiconfig/swriter/ui/queryrotateintostandarddialog.ui 
b/sw/uiconfig/swriter/ui/queryrotateintostandarddialog.ui
index a4ce6a8ba7f8..79235d54133a 100644
--- a/sw/uiconfig/swriter/ui/queryrotateintostandarddialog.ui
+++ b/sw/uiconfig/swriter/ui/queryrotateintostandarddialog.ui
@@ -4,7 +4,7 @@
   
   
 False
-Rotate
 into standard orientation?`
+Rotate
 into standard orientation?
 False
 True
 dialog
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Paragraphs and numbering

2018-03-25 Thread Jens Tröger

Hello,

I’d like to get some confirmation on how Writer document represent numbered 
paragraphs. See the paragraph properties service, 
https://www.openoffice.org/api/docs/common/ref/com/sun/star/style/ParagraphProperties.html
 
.

If `NumberingIsNumber` is True then it’s a list item of sorts: `NumberingLevel` 
tells me which level in the nesting hierarchy it might be but really just 
counts the numbers of tab-indents. There’s a max of 10 levels (i.e. 
tab-indents). For each of the levels there exists a set of “rules” 
(`NumberingRules`) that contain the “type” (`NumberingType`) for each level. 
Meaning that I can get more information about a list item by getting its type = 
rules[level].

The `NumberingIsOutline` values seems to be unreliable, and `OutlineLevel` is 
greater than 1 if the paragraph is a heading of sorts. By default, “Title” and 
“Heading 1” are both 1. So checking whether a paragraph is a heading depends on 
the `OutlineLevel` rather than the `NumberingIsOutline` boolean.

Is that about right? What did I miss with respect to document hierarchy?

Cheers!
Jens

--
Jens Tröger
http://savage.light-speed.de/ 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

More Shapes for LibreOffice

2018-03-25 Thread Muhammad Ahsan Faheem

Hi LibreOffice Community,
I have applied for GSoC to work on LibreOffice development. Right now, I
want to work on an easyhack *"Bug 87892 - More shapes for LibreOffice draw
are needed" . *Hopefully, I will also understand the code by working on
this easyhack. I have built libreOffice successfully and just want someone
to tell me from where to start? I mean which part of code is responsible to
fix this easy hack?

Thanks,
Ahsan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 20 commits - avmedia/source cui/source desktop/source editeng/source extensions/source include/comphelper include/editeng include/sfx

2018-03-25 Thread martinb214

 avmedia/source/macavf/framegrabber.hxx  |1 
 avmedia/source/macavf/framegrabber.mm   |   18 --
 cui/source/inc/border.hxx   |1 
 cui/source/tabpages/border.cxx  |   32 +++-
 cui/source/tabpages/borderconn.cxx  |   17 +-
 cui/source/tabpages/borderconn.hxx  |2 
 desktop/source/lib/init.cxx |3 
 editeng/source/editeng/impedit.cxx  |3 
 extensions/source/ole/unoobjw.cxx   |   11 +
 include/comphelper/windowsdebugoutput.hxx   |   27 +++
 include/editeng/editids.hrc |2 
 include/sfx2/controlwrapper.hxx |7 +
 include/sfx2/itemconnect.hxx|   17 +-
 include/vcl/dialog.hxx  |7 -
 oox/source/export/drawingml.cxx |   87 ++--
 oox/source/export/shapes.cxx|1 
 sc/source/ui/app/inputhdl.cxx   |8 -
 sc/source/ui/unoobj/docuno.cxx  |   24 +--
 sd/qa/unit/data/pptx/tdf111789.pptx |binary
 sd/qa/unit/export-tests-ooxml2.cxx  |   39 +
 sd/qa/unit/tiledrendering/data/cut_selection_change.odp |binary
 sd/qa/unit/tiledrendering/data/paste_text_onslide.odp   |binary
 sd/qa/unit/tiledrendering/tiledrendering.cxx|  109 
 sd/source/ui/unoidl/unomodel.cxx|   20 +-
 sd/source/ui/view/sdview2.cxx   |8 +
 sfx2/source/control/unoctitm.cxx|1 
 sfx2/source/dialog/tabdlg.cxx   |   93 -
 sfx2/source/doc/docfile.cxx |   51 +--
 sw/qa/extras/ooxmlexport/ooxmlexport7.cxx   |6 
 sw/source/core/bastyp/init.cxx  |4 
 sw/source/ui/envelp/envfmt.cxx  |4 
 sw/source/uibase/app/docst.cxx  |6 
 sw/source/uibase/inc/uitool.hxx |   10 -
 sw/source/uibase/shells/textsh1.cxx |4 
 sw/source/uibase/uno/unotxdoc.cxx   |   19 +-
 sw/source/uibase/utlui/uitool.cxx   |   92 -
 uui/inc/strings.hrc |1 
 uui/source/iahndl-locking.cxx   |5 
 uui/source/trylater.cxx |   29 +++-
 uui/source/trylater.hxx |2 
 vcl/source/gdi/sallayout.cxx|4 
 vcl/source/window/dialog.cxx|   26 +++
 vcl/source/window/msgbox.cxx|1 
 vcl/source/window/window.cxx|2 
 44 files changed, 560 insertions(+), 244 deletions(-)

New commits:
commit 07c2d891cb6d83e47624104107226f20b9c2b4f3
Author: martinb214 
Date:   Wed Dec 6 20:58:45 2017 +0100

tdf#111790: Shadow imported from a PPTX file is not overriden

by the settings while saving back to PPTX

Reviewed-on: https://gerrit.libreoffice.org/45989
Tested-by: Jenkins 
Reviewed-by: Tamás Zolnai 
(cherry picked from commit 7f42b0f96a2798ae99aa65b84b0db3b2af2b282b)

Change-Id: I958f1987d0123bcf89ef37b13807f407781f3c15

diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index b13d79ac8169..1067240fbe81 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -3220,25 +3220,25 @@ sal_Int32 lcl_CalculateDir(const double dX, const 
double dY)
 
 void DrawingML::WriteShapeEffects( const Reference< XPropertySet >& rXPropSet )
 {
+if( !GetProperty( rXPropSet, "InteropGrabBag" ) )
+return;
+
 Sequence< PropertyValue > aGrabBag, aEffects, aOuterShdwProps;
-if( GetProperty( rXPropSet, "InteropGrabBag" ) )
+mAny >>= aGrabBag;
+for( sal_Int32 i=0; i < aGrabBag.getLength(); ++i )
 {
-mAny >>= aGrabBag;
-for( sal_Int32 i=0; i < aGrabBag.getLength(); ++i )
+if( aGrabBag[i].Name == "EffectProperties" )
 {
-if( aGrabBag[i].Name == "EffectProperties" )
+aGrabBag[i].Value >>= aEffects;
+for( sal_Int32 j=0; j < aEffects.getLength(); ++j )
 {
-aGrabBag[i].Value >>= aEffects;
-for( sal_Int32 j=0; j < aEffects.getLength(); ++j )
+if( aEffects[j].Name == "outerShdw" )
 {
-if( aEffects[j].Name == "outerShdw" )
-{
-aEffects[j].Value >>= aOuterShdwProps;
-break;
-}
+aEffects[j].Value >>= aOuterShdwProps;
+break;
 }
-

lode Error:Unsupported base_os:MINGW64_NT-10.0

2018-03-25 Thread Jörg Kubitz


Hi,

I am trying to get involved into libreoffice. Following the instruction 
(https://wiki.documentfoundation.org/Development/How_to_build) as good 
as i can i am stuck on

https://wiki.documentfoundation.org/Development/lode

I am getting error "Error:Unsupported base_os:MINGW64_NT-10.0" in the 
step "./setup --prereq"


How to proceed? Virtually impossible i am the first guy who is using 
windows 10 :-)



Jörg Kubitz



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: icon-themes/colibre

2018-03-25 Thread andreas kainz

 icon-themes/colibre/links.txt |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit eb077fc700242f405e87d90c4762f9b6cfd33784
Author: andreas kainz 
Date:   Sun Mar 25 10:49:58 2018 +0200

Colibre icons: update links.txt file

Change-Id: If3f9760e07318812d1a13dfd35f7832c4b6ed004
Reviewed-on: https://gerrit.libreoffice.org/51822
Tested-by: Jenkins 
Reviewed-by: andreas_kainz 

diff --git a/icon-themes/colibre/links.txt b/icon-themes/colibre/links.txt
index f421f0ac3ba5..70181775f337 100644
--- a/icon-themes/colibre/links.txt
+++ b/icon-themes/colibre/links.txt
@@ -947,9 +947,9 @@ formula/res/fx.png cmd/sc_dbviewfunctions.png
 # fpicker
 # ==
 fpicker/res/fp011.png cmd/sc_firstpage.png
-fpicker/res/fp011.png cmd/sc_open.png
-fpicker/res/fp011.png cmd/sc_starshapes.png
-fpicker/res/fp011.png desktop/res/shared_16.png
+fpicker/res/fp014.png cmd/sc_open.png
+fpicker/res/fp015.png cmd/sc_starshapes.png
+fpicker/res/fp016.png desktop/res/shared_16.png
 
 # reportdesign
 # ==
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: icon-themes/breeze icon-themes/breeze_dark icon-themes/breeze_svg

2018-03-25 Thread andreas kainz

 icon-themes/breeze/links.txt  |6 +++---
 icon-themes/breeze_dark/links.txt |6 +++---
 icon-themes/breeze_svg/links.txt  |6 +++---
 3 files changed, 9 insertions(+), 9 deletions(-)

New commits:
commit f6335b1bddb2ab95ce14535f64d30d8e7bac1611
Author: andreas kainz 
Date:   Sun Mar 25 10:48:35 2018 +0200

Breeze icons: update links.txt file

Change-Id: Iee4196e88b3d34dfa86b42cee895a4451edd4a4d
Reviewed-on: https://gerrit.libreoffice.org/51821
Tested-by: Jenkins 
Reviewed-by: andreas_kainz 

diff --git a/icon-themes/breeze/links.txt b/icon-themes/breeze/links.txt
index 815baf65b7a2..3c961e2ac9a2 100644
--- a/icon-themes/breeze/links.txt
+++ b/icon-themes/breeze/links.txt
@@ -965,9 +965,9 @@ formula/res/fx.png cmd/sc_dbviewfunctions.png
 # fpicker
 # ==
 fpicker/res/fp011.png cmd/sc_firstpage.png
-fpicker/res/fp011.png cmd/sc_open.png
-fpicker/res/fp011.png cmd/sc_starshapes.png
-fpicker/res/fp011.png desktop/res/shared_16.png
+fpicker/res/fp014.png cmd/sc_open.png
+fpicker/res/fp015.png cmd/sc_starshapes.png
+fpicker/res/fp016.png desktop/res/shared_16.png
 
 # reportdesign
 # ==
diff --git a/icon-themes/breeze_dark/links.txt 
b/icon-themes/breeze_dark/links.txt
index 815baf65b7a2..3c961e2ac9a2 100644
--- a/icon-themes/breeze_dark/links.txt
+++ b/icon-themes/breeze_dark/links.txt
@@ -965,9 +965,9 @@ formula/res/fx.png cmd/sc_dbviewfunctions.png
 # fpicker
 # ==
 fpicker/res/fp011.png cmd/sc_firstpage.png
-fpicker/res/fp011.png cmd/sc_open.png
-fpicker/res/fp011.png cmd/sc_starshapes.png
-fpicker/res/fp011.png desktop/res/shared_16.png
+fpicker/res/fp014.png cmd/sc_open.png
+fpicker/res/fp015.png cmd/sc_starshapes.png
+fpicker/res/fp016.png desktop/res/shared_16.png
 
 # reportdesign
 # ==
diff --git a/icon-themes/breeze_svg/links.txt b/icon-themes/breeze_svg/links.txt
index 815baf65b7a2..3c961e2ac9a2 100644
--- a/icon-themes/breeze_svg/links.txt
+++ b/icon-themes/breeze_svg/links.txt
@@ -965,9 +965,9 @@ formula/res/fx.png cmd/sc_dbviewfunctions.png
 # fpicker
 # ==
 fpicker/res/fp011.png cmd/sc_firstpage.png
-fpicker/res/fp011.png cmd/sc_open.png
-fpicker/res/fp011.png cmd/sc_starshapes.png
-fpicker/res/fp011.png desktop/res/shared_16.png
+fpicker/res/fp014.png cmd/sc_open.png
+fpicker/res/fp015.png cmd/sc_starshapes.png
+fpicker/res/fp016.png desktop/res/shared_16.png
 
 # reportdesign
 # ==
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/source

2018-03-25 Thread Caolán McNamara

 sd/source/ui/dlg/PhotoAlbumDialog.cxx |   76 +++---
 1 file changed, 62 insertions(+), 14 deletions(-)

New commits:
commit 1a600d6ed6578feda6e66d1e4f4f784818c308a6
Author: Caolán McNamara 
Date:   Sun Mar 25 17:16:36 2018 +0100

tdf#116544 crash on unhandled IllegalArgument exception

Change-Id: I290ba6097d6d91bf4677e7e92c896bd6359cbc49
Reviewed-on: https://gerrit.libreoffice.org/51833
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sd/source/ui/dlg/PhotoAlbumDialog.cxx 
b/sd/source/ui/dlg/PhotoAlbumDialog.cxx
index b3ab9cbaa344..739548ce570d 100644
--- a/sd/source/ui/dlg/PhotoAlbumDialog.cxx
+++ b/sd/source/ui/dlg/PhotoAlbumDialog.cxx
@@ -182,9 +182,16 @@ IMPL_LINK_NOARG(SdPhotoAlbumDialog, CreateHdl, Button*, 
void)
 aPicPos.Y = (aPageSize.Height - aPicSize.Height)/2;
 
 xShape->setPosition(aPicPos);
-xSlide->add(xShape);
-if(bCreateCaptions)
-createCaption( aPageSize );
+try
+{
+xSlide->add(xShape);
+if (bCreateCaptions)
+createCaption( aPageSize );
+}
+catch (const css::uno::Exception& exc)
+{
+SAL_WARN( "sd", exc );
+}
 }
 }
 else if( nOpt == TWO_IMAGES )
@@ -250,7 +257,14 @@ IMPL_LINK_NOARG(SdPhotoAlbumDialog, CreateHdl, Button*, 
void)
 aPicPos.Y = aPageSize.Height/2 - aPicSize.Height/2;
 
 xShape->setPosition(aPicPos);
-xSlide->add(xShape);
+try
+{
+xSlide->add(xShape);
+}
+catch (const css::uno::Exception& exc)
+{
+SAL_WARN( "sd", exc );
+}
 }
 
 if( !sUrl2.isEmpty() )
@@ -287,10 +301,17 @@ IMPL_LINK_NOARG(SdPhotoAlbumDialog, CreateHdl, Button*, 
void)
 aPicPos.Y = aPageSize.Height/2 - aPicSize.Height/2;
 
 xShape->setPosition(aPicPos);
-xSlide->add(xShape);
-if(bCreateCaptions)
-createCaption( aPageSize );
 
+try
+{
+xSlide->add(xShape);
+if(bCreateCaptions)
+createCaption( aPageSize );
+}
+catch (const css::uno::Exception& exc)
+{
+SAL_WARN( "sd", exc );
+}
 }
 }
 }
@@ -369,7 +390,14 @@ IMPL_LINK_NOARG(SdPhotoAlbumDialog, CreateHdl, Button*, 
void)
 aPicPos.Y = aPageSize.Height/4 - aPicSize.Height/2;
 
 xShape->setPosition(aPicPos);
-xSlide->add(xShape);
+try
+{
+xSlide->add(xShape);
+}
+catch (const css::uno::Exception& exc)
+{
+SAL_WARN( "sd", exc );
+}
 }
 if( !sUrl2.isEmpty() )
 {
@@ -405,7 +433,14 @@ IMPL_LINK_NOARG(SdPhotoAlbumDialog, CreateHdl, Button*, 
void)
 aPicPos.Y = aPageSize.Height/4 - aPicSize.Height/2;
 
 xShape->setPosition(aPicPos);
-xSlide->add(xShape);
+try
+{
+xSlide->add(xShape);
+}
+catch (const css::uno::Exception& exc)
+{
+SAL_WARN( "sd", exc );
+}
 }
 if( !sUrl3.isEmpty() )
 {
@@ -441,7 +476,14 @@ IMPL_LINK_NOARG(SdPhotoAlbumDialog, CreateHdl, Button*, 
void)
 aPicPos.Y = aPageSize.Height/4 - aPicSize.Height/2 + 
aPageSize.Height/2;
 
 xShape->setPosition(aPicPos);
-xSlide->add(xShape);
+try
+{
+xSlide->add(xShape);
+}
+catch (const css::uno::Exception& exc)
+{
+SAL_WARN( "sd", exc );
+}
 }
 if( !sUrl4.isEmpty() )
 {
@@ -477,10 +519,16 @@ IMPL_LINK_NOARG(SdPhotoAlbumDialog, CreateHdl, Button*, 
void)
 aPicPos.Y = aPageSize.Height/4 - aPicSize.Height/2 + 
aPageSize.Height/2;
 
 xShape->setPosition(aPicPos);
-xSlide->add(xShape);
-if(bCreateCaptions)
-createCapti

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 27 commits - comphelper/source configure.ac cui/source desktop/source editeng/qa editeng/source include/comphelper include/editeng in

2018-03-25 Thread Mike Kaganski

 comphelper/source/xml/ofopxmlhelper.cxx |   18 
 configure.ac|2 
 cui/source/tabpages/chardlg.cxx |   10 
 desktop/source/app/app.cxx  |4 
 desktop/source/lib/init.cxx |   41 +-
 editeng/qa/unit/core-test.cxx   |  144 +++
 editeng/source/editeng/editeng.cxx  |   10 
 editeng/source/editeng/impedit.hxx  |7 
 editeng/source/editeng/impedit2.cxx |   10 
 editeng/source/editeng/impedit3.cxx |   12 
 editeng/source/items/itemtype.cxx   |8 
 editeng/source/outliner/outliner.cxx|   10 
 editeng/source/xml/xmltxtexp.cxx|6 
 include/LibreOfficeKit/LibreOfficeKit.h |1 
 include/LibreOfficeKit/LibreOfficeKit.hxx   |6 
 include/comphelper/windowsdebugoutput.hxx   |  456 +++-
 include/editeng/editeng.hxx |4 
 include/editeng/outliner.hxx|4 
 include/oox/core/xmlfilterbase.hxx  |   12 
 include/svtools/ctrlbox.hxx |3 
 include/svx/svdmodel.hxx|4 
 include/svx/svdotext.hxx|2 
 include/vcl/ITiledRenderable.hxx|   12 
 include/vcl/field.hxx   |   18 
 oox/source/core/xmlfilterbase.cxx   |  206 ++
 oox/source/export/drawingml.cxx |   19 -
 package/inc/ZipPackageEntry.hxx |   10 
 package/source/zippackage/ZipPackage.cxx|   31 +
 sc/inc/docuno.hxx   |6 
 sc/qa/unit/tiledrendering/tiledrendering.cxx|6 
 sc/source/ui/unoobj/docuno.cxx  |   34 -
 sd/qa/unit/data/odp/tdf115639.odp   |binary
 sd/qa/unit/data/ppt/tdf115639.ppt   |binary
 sd/qa/unit/data/pptx/font-scale.pptx|binary
 sd/qa/unit/data/pptx/tdf115639.pptx |binary
 sd/qa/unit/export-tests-ooxml2.cxx  |   17 
 sd/qa/unit/import-tests.cxx |   33 +
 sd/qa/unit/tiledrendering/tiledrendering.cxx|6 
 sd/source/ui/docshell/docshel4.cxx  |   16 
 sd/source/ui/inc/unomodel.hxx   |3 
 sd/source/ui/unoidl/unomodel.cxx|   36 -
 sd/source/ui/view/Outliner.cxx  |1 
 solenv/vs/LibreOffice.natvis|7 
 svtools/source/control/ctrlbox.cxx  |   14 
 svx/source/svdraw/svdetc.cxx|1 
 svx/source/svdraw/svdmodel.cxx  |   22 +
 svx/source/svdraw/svdotext.cxx  |   63 +++
 sw/inc/strings.hrc  |1 
 sw/inc/unotxdoc.hxx |4 
 sw/qa/extras/tiledrendering/tiledrendering.cxx  |6 
 sw/source/filter/ww8/docxexport.cxx |   14 
 sw/source/uibase/app/docsh2.cxx |2 
 sw/source/uibase/app/docst.cxx  |3 
 sw/source/uibase/app/docstyle.cxx   |   24 -
 sw/source/uibase/uno/unotxdoc.cxx   |   30 -
 vcl/source/control/field.cxx|   77 +---
 vcl/source/control/fixed.cxx|   21 -
 vcl/source/window/toolbox.cxx   |2 
 vcl/source/window/window.cxx|8 
 writerfilter/source/filter/WriterFilter.cxx |   38 --
 writerfilter/source/ooxml/OOXMLDocumentImpl.cxx |   60 +--
 xmloff/source/core/xmlimp.cxx   |7 
 62 files changed, 1312 insertions(+), 320 deletions(-)

New commits:
commit 73629949c1d6245f7fad419b677cf92a49ffd18a
Author: Mike Kaganski 
Date:   Wed Feb 21 00:30:16 2018 +0300

tdf#115892: properly get the box' saved value

Previously textual value like "10,5 pt" was converted to int as simply
10 (multiplied by 10, it became 100), which compared as different from
unchanged value of 105. This made the fractional values to be treated
as always changed.

This patch uses the same code to convert saved value as is used for
current edit box value.

Reviewed-on: https://gerrit.libreoffice.org/50066
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 
(cherry picked from commit f00e891f3369f7b8c2532634d9ff4ab19da17c33)

Change-Id: I09a84a6bf33b17e0192b79b31af21ef14d7e9c63

diff --git a/cui/source/tabpages/chardlg.cxx b/cui/source/tabpages/chardlg.cxx
index af80bb565ef7..75dab248267c 100644
--- a/cui/source/tabpages/chardlg.cxx
+++ b/cui/source/tabpages/chardlg.cxx
@@ -1041,14 +1041,8 @@ bool SvxCharNamePage::FillItemSet_Impl( SfxItemSet& 
rSet, LanguageGroup eLangGrp
 
 if ( pSizeBox->GetText().isEmpty() )   // GetValue() returns the min-value
 nSize = 0;
-long nSavedSize = pSizeBox->GetSavedValue().toInt32();
-bool bRel = true;
-
-if ( !pSizeBox->IsRelative() )
-{
-nSavedSize *= 10;
-

[Libreoffice-commits] core.git: include/svx svx/inc svx/source

2018-03-25 Thread Jochen Nitschke

 include/svx/xpoly.hxx |   16 +-
 svx/inc/xpolyimp.hxx  |4 --
 svx/source/xoutdev/_xpoly.cxx |   67 ++
 3 files changed, 19 insertions(+), 68 deletions(-)

New commits:
commit 84f7b97e4e5e7183fdd98dd2c618a2a25b1cdaed
Author: Jochen Nitschke 
Date:   Sun Mar 25 15:18:58 2018 +0200

clang-tidy modernize-use-equals-default in XPolygon

Change-Id: I82a4a56bf02c6ff2495bd7a6058640d77e8c0b73
Reviewed-on: https://gerrit.libreoffice.org/51832
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/svx/xpoly.hxx b/include/svx/xpoly.hxx
index 2c6f848d00be..08f7c866aa4d 100644
--- a/include/svx/xpoly.hxx
+++ b/include/svx/xpoly.hxx
@@ -54,8 +54,8 @@ class SVX_DLLPUBLIC XPolygon final
 
 public:
 XPolygon( sal_uInt16 nSize=16 );
-XPolygon( const XPolygon& rXPoly );
-XPolygon( XPolygon&& rXPoly );
+XPolygon( const XPolygon& );
+XPolygon( XPolygon&& );
 XPolygon( const tools::Polygon& rPoly );
 XPolygon( const tools::Rectangle& rRect, long nRx = 0, long nRy = 0 );
 XPolygon( const Point& rCenter, long nRx, long nRy,
@@ -77,8 +77,8 @@ public:
 
 const Point&operator[]( sal_uInt16 nPos ) const;
   Point&operator[]( sal_uInt16 nPos );
-XPolygon&   operator=( const XPolygon& rXPoly );
-XPolygon&   operator=( XPolygon&& rXPoly );
+XPolygon&   operator=( const XPolygon& );
+XPolygon&   operator=( XPolygon&& );
 booloperator==( const XPolygon& rXPoly ) const;
 
 PolyFlags  GetFlags( sal_uInt16 nPos ) const;
@@ -116,8 +116,8 @@ class SVX_DLLPUBLIC XPolyPolygon final
 
 public:
 XPolyPolygon();
-XPolyPolygon( const XPolyPolygon& rXPolyPoly );
-XPolyPolygon( XPolyPolygon&& rXPolyPoly );
+XPolyPolygon( const XPolyPolygon& );
+XPolyPolygon( XPolyPolygon&& );
 
 ~XPolyPolygon();
 
@@ -135,8 +135,8 @@ public:
 { return GetObject( nPos ); }
 XPolygon&   operator[]( sal_uInt16 nPos );
 
-XPolyPolygon&   operator=( const XPolyPolygon& rXPolyPoly );
-XPolyPolygon&   operator=( XPolyPolygon&& rXPolyPoly );
+XPolyPolygon&   operator=( const XPolyPolygon& );
+XPolyPolygon&   operator=( XPolyPolygon&& );
 
 // transformations
 void Distort(const tools::Rectangle& rRefRect, const XPolygon& 
rDistortedRect);
diff --git a/svx/inc/xpolyimp.hxx b/svx/inc/xpolyimp.hxx
index 4b73dd6fe556..425d2a551058 100644
--- a/svx/inc/xpolyimp.hxx
+++ b/svx/inc/xpolyimp.hxx
@@ -55,10 +55,6 @@ class ImpXPolyPolygon
 {
 public:
 ::std::vector< XPolygon > aXPolyList;
-
-ImpXPolyPolygon() {}
-ImpXPolyPolygon( const ImpXPolyPolygon& rImpXPolyPoly );
-~ImpXPolyPolygon();
 };
 
 
diff --git a/svx/source/xoutdev/_xpoly.cxx b/svx/source/xoutdev/_xpoly.cxx
index a4024a061954..63d53d8585b9 100644
--- a/svx/source/xoutdev/_xpoly.cxx
+++ b/svx/source/xoutdev/_xpoly.cxx
@@ -209,15 +209,9 @@ XPolygon::XPolygon( sal_uInt16 nSize )
 {
 }
 
-XPolygon::XPolygon( const XPolygon& rXPoly )
-: pImpXPolygon(rXPoly.pImpXPolygon)
-{
-}
+XPolygon::XPolygon( const XPolygon& ) = default;
 
-XPolygon::XPolygon( XPolygon&& rXPoly )
-: pImpXPolygon(std::move(rXPoly.pImpXPolygon))
-{
-}
+XPolygon::XPolygon( XPolygon&& ) = default;
 
 /// create a XPolygon out of a standard polygon
 XPolygon::XPolygon( const tools::Polygon& rPoly )
@@ -333,9 +327,7 @@ XPolygon::XPolygon(const Point& rCenter, long nRx, long nRy,
 pImpXPolygon->nPoints = nPos + 1;
 }
 
-XPolygon::~XPolygon()
-{
-}
+XPolygon::~XPolygon() = default;
 
 void XPolygon::SetPointCount( sal_uInt16 nPoints )
 {
@@ -455,17 +447,9 @@ Point& XPolygon::operator[]( sal_uInt16 nPos )
 return pImpXPolygon->pPointAry[nPos];
 }
 
-XPolygon& XPolygon::operator=( const XPolygon& rXPoly )
-{
-pImpXPolygon = rXPoly.pImpXPolygon;
-return *this;
-}
+XPolygon& XPolygon::operator=( const XPolygon& ) = default;
 
-XPolygon& XPolygon::operator=( XPolygon&& rXPoly )
-{
-pImpXPolygon = std::move(rXPoly.pImpXPolygon);
-return *this;
-}
+XPolygon& XPolygon::operator=( XPolygon&& ) = default;
 
 bool XPolygon::operator==( const XPolygon& rXPoly ) const
 {
@@ -866,30 +850,11 @@ XPolygon::XPolygon(const basegfx::B2DPolygon& rPolygon)
 }
 
 // XPolyPolygon
+XPolyPolygon::XPolyPolygon() = default;
 
-ImpXPolyPolygon::ImpXPolyPolygon( const ImpXPolyPolygon& rImpXPolyPoly )
-: aXPolyList( rImpXPolyPoly.aXPolyList )
-{
-}
-
-ImpXPolyPolygon::~ImpXPolyPolygon()
-{
-}
-
-XPolyPolygon::XPolyPolygon()
-: pImpXPolyPolygon()
-{
-}
+XPolyPolygon::XPolyPolygon( const XPolyPolygon& ) = default;
 
-XPolyPolygon::XPolyPolygon( const XPolyPolygon& rXPolyPoly )
-: pImpXPolyPolygon( rXPolyPoly.pImpXPolyPolygon )
-{
-}
-
-XPolyPolygon::XPolyPolygon( XPolyPolygon&& rXPolyPoly )
-: pImpXPolyPolygon( std::move(

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 20 commits - basic/source cppuhelper/source cui/source desktop/qa desktop/source extensions/README extensions/source include/comphelp

2018-03-25 Thread Tor Lillqvist

 basic/source/classes/sbxmod.cxx   |5 
 cppuhelper/source/servicemanager.cxx  |   33 +
 cui/source/tabpages/backgrnd.cxx  |   20 ---
 desktop/qa/desktop_lib/test_desktop_lib.cxx   |3 
 desktop/source/lib/init.cxx   |   19 +++
 extensions/README |2 
 extensions/source/ole/ole2uno.cxx |5 
 extensions/source/ole/ole2uno.hxx |6 
 extensions/source/ole/oleobjw.cxx |   12 -
 extensions/source/ole/oleobjw.hxx |6 
 extensions/source/ole/olethread.cxx   |5 
 extensions/source/ole/servprov.cxx|   40 --
 extensions/source/ole/servprov.hxx|   29 
 extensions/source/ole/servreg.cxx |7 -
 extensions/source/ole/unoconversionutilities.hxx  |   21 +--
 extensions/source/ole/unoobjw.cxx |   10 -
 extensions/source/ole/unoobjw.hxx |   15 --
 extensions/source/ole/windata.hxx |5 
 include/LibreOfficeKit/LibreOfficeKit.h   |5 
 include/LibreOfficeKit/LibreOfficeKit.hxx |   11 +
 include/LibreOfficeKit/LibreOfficeKitEnums.h  |   11 +
 include/comphelper/windowsdebugoutput.hxx |   41 ++
 include/oox/ppt/slidetransitioncontext.hxx|1 
 include/sfx2/docfile.hxx  |   19 ++-
 include/sfx2/strings.hrc  |3 
 include/vcl/ITiledRenderable.hxx  |7 +
 include/vcl/ctrl.hxx  |2 
 include/vcl/vclevent.hxx  |2 
 include/vcl/window.hxx|3 
 oox/source/ppt/slidetransitioncontext.cxx |9 +
 sc/inc/docuno.hxx |3 
 sc/qa/unit/tiledrendering/tiledrendering.cxx  |   35 +
 sc/source/ui/app/scdll.cxx|   14 ++
 sc/source/ui/docshell/impex.cxx   |4 
 sc/source/ui/unoobj/docuno.cxx|   25 
 sd/qa/unit/data/pptx/tdf115394-zero.pptx  |binary
 sd/qa/unit/export-tests-ooxml2.cxx|   16 ++
 sd/qa/unit/tiledrendering/tiledrendering.cxx  |   42 ++
 sd/source/filter/eppt/pptx-epptooxml.cxx  |   10 -
 sd/source/ui/app/sddll.cxx|   11 +
 sd/source/ui/inc/unomodel.hxx |2 
 sd/source/ui/unoidl/unomodel.cxx  |   27 
 sfx2/source/doc/docfile.cxx   |   71 ---
 sfx2/source/view/viewfrm.cxx  |  134 --
 stoc/source/invocation/invocation.cxx |4 
 sw/inc/unotxdoc.hxx   |2 
 sw/qa/extras/tiledrendering/tiledrendering.cxx|   33 +
 sw/source/uibase/app/swdll.cxx|   11 +
 sw/source/uibase/uno/unotxdoc.cxx |   22 +++
 udkapi/com/sun/star/bridge/XBridgeSupplier.idl|3 
 udkapi/com/sun/star/bridge/XBridgeSupplier2.idl   |3 
 uui/inc/strings.hrc   |3 
 uui/source/iahndl-locking.cxx |   12 +
 uui/source/iahndl.cxx |9 -
 uui/source/openlocked.cxx |   22 +--
 uui/source/openlocked.hxx |2 
 vbahelper/source/vbahelper/vbaapplicationbase.cxx |8 -
 vbahelper/source/vbahelper/vbahelper.cxx  |8 +
 vcl/source/control/ctrl.cxx   |   18 --
 vcl/source/gdi/sallayout.cxx  |   30 +++-
 vcl/source/window/paint.cxx   |   57 -
 vcl/source/window/window.cxx  |   20 +++
 62 files changed, 716 insertions(+), 302 deletions(-)

New commits:
commit da9ea2718f6a5ee46b317ef5cb47552adf8c752d
Author: Tor Lillqvist 
Date:   Mon Feb 12 15:31:14 2018 +0200

Get rid of ole_adapter namespace level

None of this is DLLPUBLIC anyway, and it all goes into one DLL.

Change-Id: I3756f87aaa4561ef54a9e6aaeeac47b99350c6b3
Reviewed-on: https://gerrit.libreoffice.org/49616
Tested-by: Jenkins 
Reviewed-by: Tor Lillqvist 
(cherry picked from commit d9fc18d5a797972ba182fbcae941535a50098dcb)

diff --git a/extensions/README b/extensions/README
index eeff42a5d853..b74ff369baa1 100644
--- a/extensions/README
+++ b/extensions/README
@@ -24,7 +24,7 @@ See 
udkapi/com/sun/star/bridge/oleautomation/ApplicationRegistration.idl
 
 This is initialized in Desktop::Main() in Desktop::OpenClients_Impl()
 by creating the service "com.sun.star.bridge.OleApplicationRegistration",
-which is implemented by ole_adapter::OleServer_Impl.
+which is implemented by OleServer_Impl.
 
 See extensions/source/ole/
 
diff --git a/extensions/source/ole/ole2uno.cxx 
b/extensions/source/ole/ole2uno.cxx
index a42c26fac140..4899a2df11d4 100644
--- a/extensions/source/ole/ole2uno

Re: GSoC 2018 : LIbreOffice | LOEclipse | Introduction : Shobhan Mandal

2018-03-25 Thread Markus Mohrhard

Hello Shobhan,

On Wed, Mar 21, 2018 at 10:23 AM, Shobhan Mandal <
dev.shobhanman...@gmail.com> wrote:

> Greetings LibreOffice Community,
>
> I am Shobhan Mandal, currently pursuing my Masters Degree in Computer
> Science from International Institute of Information Technology - Hyderabad,
> Hyderabad, Telangana, India.
>
> I am interested in working on the GSoC 2018 project in LOEclipse under
> LibreOffice. I have also started submitting patches towards LOEclipse for
> the same. With experience in making projects using C, Java and Python and
> help from this beautiful community, I believe we can make some fruitful
> contribution to the LOEclipse code-base.
>
> Any help from you guys on improving how I contribute will always be
> appreciated. Looking forward to working with you guys.
>
>
You should get in contact with Samuel and discuss your ideas to write a
good application.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Serdar Oktay TUNÇ GSoC Introducyion

2018-03-25 Thread Markus Mohrhard

Hello Serdar,

On Sun, Mar 18, 2018 at 4:49 PM, serdar tunc  wrote:

> Hello Everyone!
> I am Serdar and I am last undergraduate year in Computer Engineering
> at Çanakkale Onsekiz Mart University. I know C++, python, git, gerrit,
> reading others code and gdb.
> I am interested in "Fix shape and text rotation in xlsx files". I've
> worked with this bug and solved one bug about this code section. I
> know how OOXML filter works.
>
> this is my contributions https://gerrit.libreoffice.org/#/q/serdar
>
>
>
I just noticed that you plan to apply for this project and that you have
added the corresponding project idea to the wiki page. Note that I had to
remove the project as I'm sure that I will not mentor such a project and I
assume that Eike will not have the time to mentor it. Additionally, I don't
think that the project idea is suitable for GSoC. Fixing shape and text
rotation in xlsx files would be about a week of work for me so it is quite
far from the required 3 month of at least 30 hour work.

I would suggest that you try to find a mentor for this project right now or
apply for a different idea that is already on the list.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sax/source sw/qa

2018-03-25 Thread Caolán McNamara

 sax/source/fastparser/fastparser.cxx |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 975884fbbc3f80a634258ee562037688a42027a9
Author: Caolán McNamara 
Date:   Sun Mar 25 14:36:28 2018 +0100

ofz#7110 ensure join is called on std::exceptions as well as uno::Exception

Change-Id: I1d17301e4d7f951b7176d5a91c0dca0ef051b2a2
Reviewed-on: https://gerrit.libreoffice.org/51830
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sax/source/fastparser/fastparser.cxx 
b/sax/source/fastparser/fastparser.cxx
index c6c9c0b207fd..2765584a08fc 100644
--- a/sax/source/fastparser/fastparser.cxx
+++ b/sax/source/fastparser/fastparser.cxx
@@ -290,7 +290,7 @@ private:
 {
 mpParser->parse();
 }
-catch (const Exception &)
+catch (...)
 {
 Entity &rEntity = mpParser->getEntity();
 rEntity.getEvent( EXCEPTION );
@@ -445,7 +445,7 @@ void Entity::startElement( Event const *pEvent )
 maContextStack.top().mxContext.set( xContext.get() );
 xContext.set( nullptr, SAL_NO_ACQUIRE );
 }
-catch (const Exception&)
+catch (...)
 {
 saveException( ::cppu::getCaughtException() );
 }
@@ -464,7 +464,7 @@ void Entity::characters( const OUString& sChars )
 {
 xContext->characters( sChars );
 }
-catch (const Exception&)
+catch (...)
 {
 saveException( ::cppu::getCaughtException() );
 }
@@ -488,7 +488,7 @@ void Entity::endElement()
 else
 xContext->endUnknownElement( aContext.maNamespace, 
aContext.maElementName );
 }
-catch (const Exception&)
+catch (...)
 {
 saveException( ::cppu::getCaughtException() );
 }
@@ -501,7 +501,7 @@ void Entity::processingInstruction( const OUString& 
rTarget, const OUString& rDa
 {
 mxDocumentHandler->processingInstruction( rTarget, rData );
 }
-catch (const Exception&)
+catch (...)
 {
 saveException( ::cppu::getCaughtException() );
 }
@@ -1225,7 +1225,7 @@ void FastSaxParserImpl::callbackStartElement(const 
xmlChar *localName , const xm
 rEntity.startElement( &rEvent );
 }
 }
-catch (const Exception&)
+catch (...)
 {
 rEntity.saveException( ::cppu::getCaughtException() );
 }
diff --git a/sw/qa/core/data/ooxml/pass/ofz4825-1.docx 
b/sw/qa/core/data/ooxml/fail/ofz4825-1.docx
similarity index 100%
rename from sw/qa/core/data/ooxml/pass/ofz4825-1.docx
rename to sw/qa/core/data/ooxml/fail/ofz4825-1.docx
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

2018-03-25 Thread Jens Carl

 sc/qa/extras/scautoformatobj.cxx |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 6189c211d52975442be4a23662af501dbb2582e2
Author: Jens Carl 
Date:   Sun Mar 25 05:12:03 2018 +

Correct class name of ScAutoFormatObj

Change-Id: I0abb4590126b7c7a7d855ec57f340ea0157c56d5
Reviewed-on: https://gerrit.libreoffice.org/51813
Tested-by: Jenkins 
Reviewed-by: Jens Carl 

diff --git a/sc/qa/extras/scautoformatobj.cxx b/sc/qa/extras/scautoformatobj.cxx
index 27d96f94f2fe..ca2b55cf200d 100644
--- a/sc/qa/extras/scautoformatobj.cxx
+++ b/sc/qa/extras/scautoformatobj.cxx
@@ -25,16 +25,16 @@ using namespace com::sun::star;
 
 namespace sc_apitest
 {
-class ScTableAutoFormatObj : public CalcUnoApiTest, public 
apitest::TableAutoFormat
+class ScAutoFormatObj : public CalcUnoApiTest, public apitest::TableAutoFormat
 {
 public:
-ScTableAutoFormatObj();
+ScAutoFormatObj();
 
 virtual uno::Reference init() override;
 virtual void setUp() override;
 virtual void tearDown() override;
 
-CPPUNIT_TEST_SUITE(ScTableAutoFormatObj);
+CPPUNIT_TEST_SUITE(ScAutoFormatObj);
 
 // TableAutoFormat
 CPPUNIT_TEST(testTableAutoFormatProperties);
@@ -45,12 +45,12 @@ private:
 uno::Reference mxComponent;
 };
 
-ScTableAutoFormatObj::ScTableAutoFormatObj()
+ScAutoFormatObj::ScAutoFormatObj()
 : CalcUnoApiTest("/sc/qa/extras/testdocuments")
 {
 }
 
-uno::Reference ScTableAutoFormatObj::init()
+uno::Reference ScAutoFormatObj::init()
 {
 uno::Reference xDoc(mxComponent, 
UNO_QUERY_THROW);
 CPPUNIT_ASSERT_MESSAGE("no calc document", xDoc.is());
@@ -64,19 +64,19 @@ uno::Reference ScTableAutoFormatObj::init()
 return xTableAutoFormat;
 }
 
-void ScTableAutoFormatObj::setUp()
+void ScAutoFormatObj::setUp()
 {
 CalcUnoApiTest::setUp();
 mxComponent = loadFromDesktop("private:factory/scalc");
 }
 
-void ScTableAutoFormatObj::tearDown()
+void ScAutoFormatObj::tearDown()
 {
 closeDocument(mxComponent);
 CalcUnoApiTest::tearDown();
 }
 
-CPPUNIT_TEST_SUITE_REGISTRATION(ScTableAutoFormatObj);
+CPPUNIT_TEST_SUITE_REGISTRATION(ScAutoFormatObj);
 
 } // end namespace
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 29 commits - comphelper/source configure.ac connectivity/source cui/source dbaccess/inc dbaccess/Library_dbahsql.mk dbaccess/Library_

2018-03-25 Thread Henry Castro

 Makefile.fetch|1 
 Repository.mk |4 
 RepositoryExternal.mk |   10 
 comphelper/source/misc/lok.cxx|   48 
 configure.ac  |   15 
 connectivity/source/drivers/firebird/Connection.cxx   |8 
 cui/source/tabpages/backgrnd.cxx  |   22 
 dbaccess/Library_dba.mk   |2 
 dbaccess/Library_dbahsql.mk   |   40 
 dbaccess/Module_dbaccess.mk   |1 
 dbaccess/README.vars  |1 
 dbaccess/inc/pch/precompiled_dbahsql.cxx  |   12 
 dbaccess/inc/pch/precompiled_dbahsql.hxx  |   38 
 dbaccess/source/core/dataaccess/datasource.cxx|   26 
 dbaccess/source/filter/hsqldb/columndef.cxx   |   41 
 dbaccess/source/filter/hsqldb/columndef.hxx   |   59 
 dbaccess/source/filter/hsqldb/createparser.cxx|  223 +
 dbaccess/source/filter/hsqldb/createparser.hxx|   51 
 dbaccess/source/filter/hsqldb/fbcreateparser.cxx  |  163 
 dbaccess/source/filter/hsqldb/fbcreateparser.hxx  |   38 
 dbaccess/source/filter/hsqldb/hsqlimport.cxx  |   56 
 dbaccess/source/filter/hsqldb/hsqlimport.hxx  |   47 
 dbaccess/source/filter/hsqldb/parseschema.cxx |   82 
 dbaccess/source/filter/hsqldb/parseschema.hxx |   44 
 desktop/source/app/officeipcthread.cxx|4 
 desktop/source/lib/init.cxx   |2 
 download.lst  |2 
 external/Module_external.mk   |1 
 external/twain/README |1 
 external/twain/inc/twain/twain.h  | 2289 --
 external/twain_dsm/ExternalPackage_twain_dsm.mk   |   20 
 external/twain_dsm/ExternalProject_twain_dsm.mk   |   33 
 external/twain_dsm/Module_twain_dsm.mk|   24 
 external/twain_dsm/README |1 
 external/twain_dsm/TWAIN_DSM_VS2015.vcxproj.filters.patch |   54 
 external/twain_dsm/TWAIN_DSM_VS2015.vcxproj.patch |  263 +
 external/twain_dsm/UnpackedTarball_twain_dsm.mk   |   21 
 fpicker/source/office/iodlg.cxx   |3 
 framework/source/classes/taskcreator.cxx  |4 
 framework/source/services/taskcreatorsrv.cxx  |2 
 include/comphelper/lok.hxx|2 
 include/oox/drawingml/shapepropertymap.hxx|3 
 include/oox/ppt/slidetransition.hxx   |4 
 include/toolkit/awt/vclxwindow.hxx|   17 
 include/vcl/window.hxx|2 
 lingucomponent/source/spellcheck/spell/sspellimp.cxx  |4 
 lingucomponent/source/thesaurus/libnth/nthesimp.cxx   |4 
 offapi/com/sun/star/presentation/DrawPage.idl |9 
 oox/source/drawingml/fillproperties.cxx   |9 
 oox/source/drawingml/shapepropertymap.cxx |3 
 oox/source/export/drawingml.cxx   |   30 
 oox/source/ppt/slidetransition.cxx|   22 
 oox/source/ppt/slidetransitioncontext.cxx |6 
 oox/source/token/properties.txt   |2 
 sc/source/ui/app/transobj.cxx |   22 
 sc/source/ui/inc/tabview.hxx  |2 
 sc/source/ui/vba/vbaglobals.cxx   |   10 
 sc/source/ui/view/cellsh1.cxx |2 
 sc/source/ui/view/tabview2.cxx|2 
 sd/qa/unit/data/ppt/tdf115394.ppt |binary
 sd/qa/unit/data/pptx/tdf107608.pptx   |binary
 sd/qa/unit/data/pptx/tdf111786.pptx   |binary
 sd/qa/unit/data/pptx/tdf115394.pptx   |binary
 sd/qa/unit/data/xml/n820786_0.xml |  102 
 sd/qa/unit/export-tests-ooxml2.cxx|   85 
 sd/qa/unit/export-tests.cxx   |   39 
 sd/qa/unit/import-tests.cxx   |   59 
 sd/source/filter/eppt/eppt.cxx|   26 
 sd/source/filter/eppt/pptx-epptooxml.cxx  |  150 
 sd/source/filter/ppt/pptin.cxx|6 
 sd/source/ui/inc/unoprnms.hxx |1 
 sd/source/ui/unoidl/unopage.cxx   |2 
 svtools/source/control/toolbarmenu.cxx|2 
 svtools/source/uno/popupwindowcontroller.cxx  |3 
 sw/inc/unotxdoc.hxx

[Libreoffice-commits] core.git: include/vcl vcl/source vcl/unx

2018-03-25 Thread Caolán McNamara

 include/vcl/weld.hxx  |6 +++-
 vcl/source/app/salvtables.cxx |7 +++--
 vcl/unx/gtk3/gtk3gtkinst.cxx  |   56 +++---
 3 files changed, 61 insertions(+), 8 deletions(-)

New commits:
commit 54c2637c1c9b526ffd9423e2d8e431474b535276
Author: Caolán McNamara 
Date:   Fri Mar 23 14:53:02 2018 +

provide a route to weld accessibility

Change-Id: I92e88a4356cb8e4bd958fd86d33c52f5be82be54
Reviewed-on: https://gerrit.libreoffice.org/51787
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index d6234273b703..4a8340e1ed63 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -17,6 +17,8 @@
 #include 
 #include 
 
+typedef css::uno::Reference a11yref;
+
 namespace weld
 {
 class Container;
@@ -595,7 +597,9 @@ public:
 virtual TextView* weld_text_view(const OString& id, bool bTakeOwnership = 
false) = 0;
 virtual Expander* weld_expander(const OString& id, bool bTakeOwnership = 
false) = 0;
 virtual Entry* weld_entry(const OString& id, bool bTakeOwnership = false) 
= 0;
-virtual DrawingArea* weld_drawing_area(const OString& id, bool 
bTakeOwnership = false) = 0;
+virtual DrawingArea* weld_drawing_area(const OString& id, const a11yref& 
rA11yImpl = nullptr,
+   bool bTakeOwnership = false)
+= 0;
 virtual ~Builder() {}
 };
 
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 9cfe42eb9376..9e0b4eb0ce0a 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -1224,10 +1224,11 @@ private:
 DECL_LINK(MouseReleaseHdl, const Point&, void);
 
 public:
-SalInstanceDrawingArea(VclDrawingArea* pDrawingArea, bool bTakeOwnership)
+SalInstanceDrawingArea(VclDrawingArea* pDrawingArea, const a11yref& rAlly, 
bool bTakeOwnership)
 : SalInstanceWidget(pDrawingArea, bTakeOwnership)
 , m_xDrawingArea(pDrawingArea)
 {
+m_xDrawingArea->SetAccessible(rAlly);
 m_xDrawingArea->SetPaintHdl(LINK(this, SalInstanceDrawingArea, 
PaintHdl));
 m_xDrawingArea->SetResizeHdl(LINK(this, SalInstanceDrawingArea, 
ResizeHdl));
 m_xDrawingArea->SetMousePressHdl(LINK(this, SalInstanceDrawingArea, 
MousePressHdl));
@@ -1601,10 +1602,10 @@ public:
 return pExpander ? new SalInstanceExpander(pExpander, bTakeOwnership) 
: nullptr;
 }
 
-virtual weld::DrawingArea* weld_drawing_area(const OString &id, bool 
bTakeOwnership) override
+virtual weld::DrawingArea* weld_drawing_area(const OString &id, const 
a11yref& rA11yImpl, bool bTakeOwnership) override
 {
 VclDrawingArea* pDrawingArea = m_xBuilder->get(id);
-return pDrawingArea ? new SalInstanceDrawingArea(pDrawingArea, 
bTakeOwnership) : nullptr;
+return pDrawingArea ? new SalInstanceDrawingArea(pDrawingArea, 
rA11yImpl, bTakeOwnership) : nullptr;
 }
 
 virtual ~SalInstanceBuilder() override
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 947d1cc2f1da..c5ba7be58909 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -8,7 +8,7 @@
  */
 
 #include "../gtk/gtkinst.cxx"
-
+#include "../gtk/a11y/atkwrapper.hxx"
 #include 
 #include 
 #include 
@@ -2615,6 +2615,8 @@ class GtkInstanceDrawingArea : public GtkInstanceWidget, 
public virtual weld::Dr
 {
 private:
 GtkDrawingArea* m_pDrawingArea;
+a11yref m_xAccessible;
+AtkObject *m_pAccessible;
 ScopedVclPtrInstance m_xDevice;
 std::vector m_aBuffer;
 cairo_surface_t* m_pSurface;
@@ -2699,9 +2701,11 @@ private:
 }
 
 public:
-GtkInstanceDrawingArea(GtkDrawingArea* pDrawingArea, bool bTakeOwnership)
+GtkInstanceDrawingArea(GtkDrawingArea* pDrawingArea, const a11yref& rA11y, 
bool bTakeOwnership)
 : GtkInstanceWidget(GTK_WIDGET(pDrawingArea), bTakeOwnership)
 , m_pDrawingArea(pDrawingArea)
+, m_xAccessible(rA11y)
+, m_pAccessible(nullptr)
 , m_xDevice(nullptr, Size(1, 1), DeviceFormat::DEFAULT)
 , m_pSurface(nullptr)
 , m_nDrawSignalId(g_signal_connect(m_pDrawingArea, "draw", 
G_CALLBACK(signalDraw), this))
@@ -2710,6 +2714,14 @@ public:
 , m_nMotionSignalId(g_signal_connect(m_pDrawingArea, 
"motion-notify-event", G_CALLBACK(signalMotion), this))
 , m_nButtonReleaseSignalId(g_signal_connect(m_pDrawingArea, 
"button-release-event", G_CALLBACK(signalButton), this))
 {
+g_object_set_data(G_OBJECT(m_pDrawingArea), 
"g-lo-GtkInstanceDrawingArea", this);
+}
+
+AtkObject* GetAtkObject()
+{
+if (!m_pAccessible && m_xAccessible.is())
+m_pAccessible = atk_object_wrapper_new(m_xAccessible);
+return m_pAccessible;
 }
 
 virtual void queue_draw() override
@@ -2724,6 +2736,9 @@ public:
 
 virtual ~GtkInstanceDrawingArea() override
 {
+

[Libreoffice-commits] libvisio.git: 7 commits - src/lib

2018-03-25 Thread David Tardon

 src/lib/VDXParser.cpp   |   39 ---
 src/lib/VSD5Parser.cpp  |7 ---
 src/lib/VSD6Parser.cpp  |5 +++--
 src/lib/VSDCharacterList.cpp|3 ++-
 src/lib/VSDContentCollector.cpp |3 ++-
 src/lib/VSDFieldList.cpp|3 ++-
 src/lib/VSDGeometryList.cpp |3 ++-
 src/lib/VSDInternalStream.cpp   |2 +-
 src/lib/VSDMetaData.cpp |1 +
 src/lib/VSDPages.cpp|1 +
 src/lib/VSDParagraphList.cpp|   33 ++---
 src/lib/VSDParagraphList.h  |3 ++-
 src/lib/VSDParser.cpp   |   23 +++
 src/lib/VSDShapeList.cpp|2 +-
 src/lib/VSDStencils.cpp |   25 +++--
 src/lib/VSDStencils.h   |7 ---
 src/lib/VSDStyles.cpp   |3 ++-
 src/lib/VSDStylesCollector.cpp  |3 ++-
 src/lib/VSDXMLHelper.cpp|5 +
 src/lib/VSDXMLParserBase.cpp|9 +
 src/lib/VSDXMLTokenMap.cpp  |1 +
 src/lib/VSDXMetaData.cpp|1 +
 src/lib/VSDXParser.cpp  |   39 ---
 src/lib/VisioDocument.cpp   |3 ++-
 src/lib/libvisio_utils.cpp  |6 ++
 src/lib/libvisio_xml.cpp|3 +++
 26 files changed, 112 insertions(+), 121 deletions(-)

New commits:
commit c1bb49486e73e9e19944be6a995e3bbd96210f8f
Author: David Tardon 
Date:   Sun Mar 25 16:49:53 2018 +0200

move define where it should be

Change-Id: Ie8080354158b01bd29c14105dce3919eb19a01e6

diff --git a/src/lib/VSDXMLHelper.cpp b/src/lib/VSDXMLHelper.cpp
index c0e1cf5..6f483b8 100644
--- a/src/lib/VSDXMLHelper.cpp
+++ b/src/lib/VSDXMLHelper.cpp
@@ -7,10 +7,6 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#ifndef BOOST_LEXICAL_CAST_ASSUME_C_LOCALE
-#define BOOST_LEXICAL_CAST_ASSUME_C_LOCALE 1
-#endif
-
 #include "VSDXMLHelper.h"
 
 #include 
diff --git a/src/lib/libvisio_xml.cpp b/src/lib/libvisio_xml.cpp
index fb18627..df0c5f9 100644
--- a/src/lib/libvisio_xml.cpp
+++ b/src/lib/libvisio_xml.cpp
@@ -9,6 +9,9 @@
 
 #include "libvisio_xml.h"
 
+#ifndef BOOST_LEXICAL_CAST_ASSUME_C_LOCALE
+#define BOOST_LEXICAL_CAST_ASSUME_C_LOCALE 1
+#endif
 #include 
 
 #include "VSDTypes.h"
commit 5fa2b1a754a026f7c36f339b396574c1c43700c8
Author: David Tardon 
Date:   Sun Mar 25 16:48:12 2018 +0200

make sure headers are self-contained

Change-Id: I77beb4ce00ec070f2599362f6462d967613abd2b

diff --git a/src/lib/VDXParser.cpp b/src/lib/VDXParser.cpp
index 0e5cc1b..c305ab8 100644
--- a/src/lib/VDXParser.cpp
+++ b/src/lib/VDXParser.cpp
@@ -7,12 +7,13 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+#include "VDXParser.h"
+
 #include 
 #include 
 #include 
 #include 
 #include 
-#include "VDXParser.h"
 #include "libvisio_utils.h"
 #include "libvisio_xml.h"
 #include "VSDContentCollector.h"
diff --git a/src/lib/VSD5Parser.cpp b/src/lib/VSD5Parser.cpp
index fe841cc..cfc0d94 100644
--- a/src/lib/VSD5Parser.cpp
+++ b/src/lib/VSD5Parser.cpp
@@ -7,13 +7,14 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+#include "VSD5Parser.h"
+
 #include 
 #include 
 #include 
 #include 
 #include 
 #include "libvisio_utils.h"
-#include "VSD5Parser.h"
 #include "VSDInternalStream.h"
 #include "VSDDocumentStructure.h"
 #include "VSDContentCollector.h"
diff --git a/src/lib/VSD6Parser.cpp b/src/lib/VSD6Parser.cpp
index ea3be55..a41016b 100644
--- a/src/lib/VSD6Parser.cpp
+++ b/src/lib/VSD6Parser.cpp
@@ -7,12 +7,13 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+#include "VSD6Parser.h"
+
 #include 
 #include 
 #include 
 #include 
 #include "libvisio_utils.h"
-#include "VSD6Parser.h"
 #include "VSDInternalStream.h"
 #include "VSDDocumentStructure.h"
 #include "VSDContentCollector.h"
diff --git a/src/lib/VSDCharacterList.cpp b/src/lib/VSDCharacterList.cpp
index 6f9fe8e..17935fc 100644
--- a/src/lib/VSDCharacterList.cpp
+++ b/src/lib/VSDCharacterList.cpp
@@ -7,9 +7,10 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#include "VSDCollector.h"
 #include "VSDCharacterList.h"
 
+#include "VSDCollector.h"
+
 namespace libvisio
 {
 
diff --git a/src/lib/VSDContentCollector.cpp b/src/lib/VSDContentCollector.cpp
index cde0ad0..8b297da 100644
--- a/src/lib/VSDContentCollector.cpp
+++ b/src/lib/VSDContentCollector.cpp
@@ -7,6 +7,8 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+#include "VSDContentCollector.h"
+
 #include 
 #include 
 #include  // for memcpy
@@ -17,7 +19,6 @@
 #include 
 #include 
 
-#include "VSDContentCollector.h"
 #include "VSDParser.h"
 #include "VSDInternalStream.h"
 
diff --git a/src/lib/VSDFieldList.cpp b/src/lib/VSDFieldList.cpp
index 363d20e..c4c16ef 100644
--- a/src/lib/VSDFieldList.cpp
+++ b/src/lib/VSDFieldList.cpp
@@ -7,9 +7,10 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+#include "VSDFieldList.h"
+

Crash test update

2018-03-25 Thread Crashtest VM

New crashtest update available at 
http://dev-builds.libreoffice.org/crashtest/9adc7bdf6d304c540339f389aa02c925733ef248/


exportCrashes.csv
Description: Binary data


importCrash.csv
Description: Binary data


validationErrors.csv
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: lotuswordpro/qa lotuswordpro/source

2018-03-25 Thread Caolán McNamara

 lotuswordpro/qa/cppunit/data/fail/recurse-4.lwp |binary
 lotuswordpro/source/filter/lwplayout.cxx|5 +++--
 lotuswordpro/source/filter/lwplayout.hxx|   14 --
 lotuswordpro/source/filter/lwppagelayout.cxx|2 +-
 4 files changed, 16 insertions(+), 5 deletions(-)

New commits:
commit 4df294a2eae0098f61b4b70ec17dde569fbfc2a0
Author: Caolán McNamara 
Date:   Sun Mar 25 14:01:25 2018 +0100

ofz#7109 infinite regress

Change-Id: Iac0bd81c9b0e3ac6b005bb0065895ca1b4ca4233
Reviewed-on: https://gerrit.libreoffice.org/51826
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/lotuswordpro/qa/cppunit/data/fail/recurse-4.lwp 
b/lotuswordpro/qa/cppunit/data/fail/recurse-4.lwp
new file mode 100644
index ..f48c5bb718a4
Binary files /dev/null and b/lotuswordpro/qa/cppunit/data/fail/recurse-4.lwp 
differ
diff --git a/lotuswordpro/source/filter/lwplayout.cxx 
b/lotuswordpro/source/filter/lwplayout.cxx
index 5f24dfa64932..7931f7b0dee4 100644
--- a/lotuswordpro/source/filter/lwplayout.cxx
+++ b/lotuswordpro/source/filter/lwplayout.cxx
@@ -79,6 +79,7 @@ LwpVirtualLayout::LwpVirtualLayout(LwpObjectHeader const 
&objHdr, LwpSvStream* p
 , m_bGettingMarginsSameAsParent(false)
 , m_bGettingHasProtection(false)
 , m_bGettingIsProtected(false)
+, m_bGettingIsAutoGrowDown(false)
 , m_bGettingMarginsValue(false)
 , m_bGettingExtMarginsValue(false)
 , m_bGettingUsePrinterSettings(false)
@@ -421,7 +422,7 @@ LwpVirtualLayout* 
LwpVirtualLayout::FindChildByType(LWP_LAYOUT_TYPE eType)
 */
 bool LwpVirtualLayout::IsFitGraphic()
 {
-return IsAutoGrowRight() && !IsAutoGrowLeft() && IsAutoGrowDown();
+return IsAutoGrowRight() && !IsAutoGrowLeft() && GetIsAutoGrowDown();
 }
 
 /**
@@ -1149,7 +1150,7 @@ bool LwpMiddleLayout::IsAutoGrowDown()
 rtl::Reference xBase(GetBasedOnStyle());
 if (LwpMiddleLayout* pLay = 
dynamic_cast(xBase.get()))
 {
-return pLay->IsAutoGrowDown();
+return pLay->GetIsAutoGrowDown();
 }
 }
 return LwpVirtualLayout::IsAutoGrowDown();
diff --git a/lotuswordpro/source/filter/lwplayout.hxx 
b/lotuswordpro/source/filter/lwplayout.hxx
index 4ec293c06cbb..a1e9db694e29 100644
--- a/lotuswordpro/source/filter/lwplayout.hxx
+++ b/lotuswordpro/source/filter/lwplayout.hxx
@@ -103,7 +103,6 @@ public:
 virtual double GetColGap(sal_uInt16 nIndex);
 virtual bool IsAutoGrow(){ return false;}
 virtual bool IsAutoGrowUp(){ return false;}
-virtual bool IsAutoGrowDown(){ return false;}
 virtual bool IsAutoGrowLeft(){ return false;}
 virtual bool IsAutoGrowRight(){ return false;}
 bool IsFitGraphic();
@@ -137,6 +136,15 @@ public:
 m_bGettingIsProtected = false;
 return bRet;
 }
+bool GetIsAutoGrowDown()
+{
+if (m_bGettingIsAutoGrowDown)
+throw std::runtime_error("recursion in layout");
+m_bGettingIsAutoGrowDown = true;
+bool bRet = IsAutoGrowDown();
+m_bGettingIsAutoGrowDown = false;
+return bRet;
+}
 bool GetHasProtection()
 {
 if (m_bGettingHasProtection)
@@ -216,6 +224,7 @@ protected:
 bool HasProtection();
 virtual bool HonorProtection();
 virtual bool IsProtected();
+virtual bool IsAutoGrowDown(){ return false;}
 virtual double MarginsValue(sal_uInt8 /*nWhichSide*/){return 0;}
 virtual double ExtMarginsValue(sal_uInt8 /*nWhichSide*/){return 0;}
 virtual bool MarginsSameAsParent();
@@ -224,6 +233,7 @@ protected:
 bool m_bGettingMarginsSameAsParent;
 bool m_bGettingHasProtection;
 bool m_bGettingIsProtected;
+bool m_bGettingIsAutoGrowDown;
 bool m_bGettingMarginsValue;
 bool m_bGettingExtMarginsValue;
 bool m_bGettingUsePrinterSettings;
@@ -353,7 +363,6 @@ public:
 LwpColor* GetBackColor();
 virtual bool IsAutoGrow() override;
 virtual bool IsAutoGrowUp() override;
-virtual bool IsAutoGrowDown() override;
 virtual bool IsAutoGrowLeft() override;
 virtual bool IsAutoGrowRight() override;
 virtual sal_uInt8 GetContentOrientation() override;
@@ -388,6 +397,7 @@ protected:
 virtual bool MarginsSameAsParent() override;
 virtual double MarginsValue(sal_uInt8 nWhichSide) override;
 virtual double ExtMarginsValue(sal_uInt8 nWhichSide) override;
+virtual bool IsAutoGrowDown() override;
 private:
 LwpObjectID m_BasedOnStyle;
 LwpLayoutGeometry* Geometry();
diff --git a/lotuswordpro/source/filter/lwppagelayout.cxx 
b/lotuswordpro/source/filter/lwppagelayout.cxx
index de414e5ed50c..efa9de8fc2d8 100644
--- a/lotuswordpro/source/filter/lwppagelayout.cxx
+++ b/lotuswordpro/source/filter/lwppagelayout.cxx
@@ -781,7 +781,7 @@ void LwpHeaderLayout::ParseMargins(XFHeaderStyle* ph1)
 {
 //Set height: from top of header to top of body, including the spacing 
between header and body
 double height = GetGeometry

[Libreoffice-commits] core.git: jvmaccess/source jvmfwk/plugins l10ntools/source libreofficekit/source linguistic/source

2018-03-25 Thread Julien Nabet

 jvmaccess/source/classpath.cxx |4 ++--
 jvmfwk/plugins/sunmajor/pluginlib/util.cxx |5 ++---
 l10ntools/source/helpmerge.cxx |   22 +-
 l10ntools/source/idxdict/idxdict.cxx   |7 ++-
 l10ntools/source/localize.cxx  |4 ++--
 l10ntools/source/merge.cxx |4 ++--
 l10ntools/source/pocheck.cxx   |   18 +-
 l10ntools/source/xmlparse.cxx  |   15 +++
 libreofficekit/source/gtk/tilebuffer.cxx   |5 ++---
 linguistic/source/convdic.cxx  |   18 ++
 linguistic/source/convdicxml.cxx   |   16 +++-
 linguistic/source/gciterator.cxx   |6 ++
 linguistic/source/hyphdsp.cxx  |5 ++---
 linguistic/source/lngsvcmgr.cxx|   15 ++-
 linguistic/source/spelldsp.cxx |5 ++---
 linguistic/source/thesdsp.cxx  |5 ++---
 16 files changed, 64 insertions(+), 90 deletions(-)

New commits:
commit f365b17bf170c8ed1baae299a2d719774fcc4305
Author: Julien Nabet 
Date:   Sun Mar 18 12:36:02 2018 +0100

Use for-range loops in some modules

jvmaccess, jvmfwk, l10ntools, libreofficekit and linguistic

Change-Id: I9d290d1098b25ccb3aee19d2df18c18f4aa65105
Reviewed-on: https://gerrit.libreoffice.org/51495
Reviewed-by: Noel Grandin 
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/jvmaccess/source/classpath.cxx b/jvmaccess/source/classpath.cxx
index 6a5ccf87b1d4..4be1fedb7d26 100644
--- a/jvmaccess/source/classpath.cxx
+++ b/jvmaccess/source/classpath.cxx
@@ -93,9 +93,9 @@ jobjectArray jvmaccess::ClassPath::translateToUrls(
 return nullptr;
 }
 jsize idx = 0;
-for (std::vector< jobject >::iterator i(urls.begin()); i != urls.end(); 
++i)
+for (auto const& url : urls)
 {
-environment->SetObjectArrayElement(result, idx++, *i);
+environment->SetObjectArrayElement(result, idx++, url);
 }
 return result;
 }
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/util.cxx 
b/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
index 187a2789b4cc..dfa4653054cc 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
@@ -614,10 +614,9 @@ bool getJavaInfoFromRegistry(const wchar_t* szRegKey,
 {
 bool bAppend= true;
 //iterate over the vector with java home strings
-for(auto itHome= vecJavaHome.begin();
-itHome != vecJavaHome.end(); ++itHome)
+for (auto const& javaHome : vecJavaHome)
 {
-if(usHomeUrl.equals(*itHome))
+if(usHomeUrl.equals(javaHome))
 {
 bAppend= false;
 break;
diff --git a/l10ntools/source/helpmerge.cxx b/l10ntools/source/helpmerge.cxx
index f09fe6af45a0..92f5171e5e67 100644
--- a/l10ntools/source/helpmerge.cxx
+++ b/l10ntools/source/helpmerge.cxx
@@ -52,9 +52,9 @@
 #if OSL_DEBUG_LEVEL > 2
 void HelpParser::Dump(XMLHashMap* rElem_in)
 {
-for(XMLHashMap::iterator pos = rElem_in->begin();pos != rElem_in->end(); 
++pos)
+for (auto const& pos : *rElem_in)
 {
-Dump(pos->second,pos->first);
+Dump(pos.second,pos.first);
 }
 }
 
@@ -63,10 +63,10 @@ void HelpParser::Dump(LangHashMap* rElem_in,const OString & 
sKey_in)
 OString x;
 OString y;
 fprintf(stdout,"+%s---+\n",sKey_in.getStr() );
-for(LangHashMap::iterator 
posn=rElem_in->begin();posn!=rElem_in->end();++posn)
+for (auto const& posn : *rElem_in)
 {
-x=posn->first;
-y=posn->second->ToOString();
+x=posn.first;
+y=posn.second->ToOString();
 fprintf(stdout,"key=%s value=%s\n",x.getStr(),y.getStr());
 }
 fprintf(stdout,"+--+\n");
@@ -110,12 +110,10 @@ bool HelpParser::CreatePO(
 XMLHashMap* aXMLStrHM = file->GetStrings();
 
 std::vector order = file->getOrder();
-std::vector::iterator pos;
-XMLHashMap::iterator posm;
 
-for( pos = order.begin(); pos != order.end() ; ++pos )
+for (auto const& pos : order)
 {
-posm = aXMLStrHM->find( *pos );
+auto posm = aXMLStrHM->find(pos);
 LangHashMap* pElem = posm->second;
 
 XMLElement* pXMLElement = (*pElem)[ "en-US" ];
@@ -173,12 +171,10 @@ bool HelpParser::MergeSingleFile( XMLFile* file , 
MergeDataFile* pMergeDataFile
 s_ResData.sResTyp   = "help";
 
 std::vector order = file->getOrder();
-std::vector::iterator pos;
-XMLHashMap::iterator posm;
 
-for( pos = order.begin(); pos != order.end() ; ++pos ) // Merge every l10n 
related string in the same order as export
+for (

[Libreoffice-commits] libvisio.git: 8 commits - src/lib

2018-03-25 Thread David Tardon

 src/lib/VSDCharacterList.cpp |   29 +++-
 src/lib/VSDCharacterList.h   |3 
 src/lib/VSDContentCollector.cpp  |3 
 src/lib/VSDFieldList.cpp |   31 +++--
 src/lib/VSDFieldList.h   |3 
 src/lib/VSDGeometryList.cpp  |  131 ++-
 src/lib/VSDGeometryList.h|5 -
 src/lib/VSDOutputElementList.cpp |   19 -
 src/lib/VSDParagraphList.cpp |   11 ++-
 src/lib/libvisio_utils.h |   12 +++
 10 files changed, 101 insertions(+), 146 deletions(-)

New commits:
commit 40c8a1d8216bebfccfcea5ec55af2848f3a72170
Author: David Tardon 
Date:   Sun Mar 25 14:25:47 2018 +0200

guard against self-assignment

Change-Id: I2eff7abe7d341455c111291ecf81ff348846bc11

diff --git a/src/lib/VSDCharacterList.cpp b/src/lib/VSDCharacterList.cpp
index 65de7af..6f9fe8e 100644
--- a/src/lib/VSDCharacterList.cpp
+++ b/src/lib/VSDCharacterList.cpp
@@ -88,10 +88,13 @@ libvisio::VSDCharacterList::VSDCharacterList(const 
libvisio::VSDCharacterList &c
 
 libvisio::VSDCharacterList &libvisio::VSDCharacterList::operator=(const 
libvisio::VSDCharacterList &charList)
 {
-  clear();
-  for (auto iter = charList.m_elements.begin(); iter != 
charList.m_elements.end(); ++iter)
-m_elements[iter->first] = clone(iter->second);
-  m_elementsOrder = charList.m_elementsOrder;
+  if (this != &charList)
+  {
+clear();
+for (auto iter = charList.m_elements.begin(); iter != 
charList.m_elements.end(); ++iter)
+  m_elements[iter->first] = clone(iter->second);
+m_elementsOrder = charList.m_elementsOrder;
+  }
   return *this;
 }
 
diff --git a/src/lib/VSDGeometryList.cpp b/src/lib/VSDGeometryList.cpp
index ac1b616..92746d8 100644
--- a/src/lib/VSDGeometryList.cpp
+++ b/src/lib/VSDGeometryList.cpp
@@ -579,10 +579,13 @@ libvisio::VSDGeometryList::VSDGeometryList(const 
VSDGeometryList &geomList) :
 
 libvisio::VSDGeometryList &libvisio::VSDGeometryList::operator=(const 
VSDGeometryList &geomList)
 {
-  clear();
-  for (auto iter = geomList.m_elements.begin(); iter != 
geomList.m_elements.end(); ++iter)
-m_elements[iter->first] = clone(iter->second);
-  m_elementsOrder = geomList.m_elementsOrder;
+  if (this != &geomList)
+  {
+clear();
+for (auto iter = geomList.m_elements.begin(); iter != 
geomList.m_elements.end(); ++iter)
+  m_elements[iter->first] = clone(iter->second);
+m_elementsOrder = geomList.m_elementsOrder;
+  }
   return *this;
 }
 
diff --git a/src/lib/VSDParagraphList.cpp b/src/lib/VSDParagraphList.cpp
index f279bb8..c1863a1 100644
--- a/src/lib/VSDParagraphList.cpp
+++ b/src/lib/VSDParagraphList.cpp
@@ -89,10 +89,13 @@ libvisio::VSDParagraphList::VSDParagraphList(const 
libvisio::VSDParagraphList &p
 
 libvisio::VSDParagraphList &libvisio::VSDParagraphList::operator=(const 
libvisio::VSDParagraphList ¶List)
 {
-  clear();
-  for (auto iter = paraList.m_elements.begin(); iter != 
paraList.m_elements.end(); ++iter)
-m_elements[iter->first] = iter->second->clone();
-  m_elementsOrder = paraList.m_elementsOrder;
+  if (this != ¶List)
+  {
+clear();
+for (auto iter = paraList.m_elements.begin(); iter != 
paraList.m_elements.end(); ++iter)
+  m_elements[iter->first] = iter->second->clone();
+m_elementsOrder = paraList.m_elementsOrder;
+  }
   return *this;
 }
 
commit 467618a5b883c7303fc6ef8e10756e203ceaed11
Author: David Tardon 
Date:   Sun Mar 25 14:23:08 2018 +0200

avoid manual memory mgmt

Change-Id: I4694b93a135dc568beb234a6300a492326122257

diff --git a/src/lib/VSDCharacterList.cpp b/src/lib/VSDCharacterList.cpp
index ae702ef..65de7af 100644
--- a/src/lib/VSDCharacterList.cpp
+++ b/src/lib/VSDCharacterList.cpp
@@ -83,14 +83,14 @@ libvisio::VSDCharacterList::VSDCharacterList(const 
libvisio::VSDCharacterList &c
   m_elementsOrder(charList.m_elementsOrder)
 {
   for (auto iter = charList.m_elements.begin(); iter != 
charList.m_elements.end(); ++iter)
-m_elements[iter->first] = iter->second->clone();
+m_elements[iter->first] = clone(iter->second);
 }
 
 libvisio::VSDCharacterList &libvisio::VSDCharacterList::operator=(const 
libvisio::VSDCharacterList &charList)
 {
   clear();
   for (auto iter = charList.m_elements.begin(); iter != 
charList.m_elements.end(); ++iter)
-m_elements[iter->first] = iter->second->clone();
+m_elements[iter->first] = clone(iter->second);
   m_elementsOrder = charList.m_elementsOrder;
   return *this;
 }
@@ -107,14 +107,11 @@ void libvisio::VSDCharacterList::addCharIX(unsigned id, 
unsigned level, unsigned
const boost::optional 
&allcaps, const boost::optional &initcaps, const boost::optional 
&smallcaps,
const boost::optional 
&superscript, const boost::optional &subscript, const 
boost::optional &scaleWidth)
 {
-  auto *tmpElement = dynamic_cast(m_elements[id]);
+  auto *tmpElement = dynamic_cast(m_elements[id].get());
   if (!tmpElement)
   {

[Libreoffice-commits] core.git: comphelper/source editeng/source include/comphelper

2018-03-25 Thread Arnaud Versini

 comphelper/source/misc/accessibletexthelper.cxx |   61 +---
 editeng/source/accessibility/AccessibleEditableTextPara.cxx |8 -
 include/comphelper/accessibletexthelper.hxx |8 -
 3 files changed, 36 insertions(+), 41 deletions(-)

New commits:
commit dd5df4ccb33048fa5fa8f85b2e6e69a6a225be57
Author: Arnaud Versini 
Date:   Sun Mar 18 20:25:25 2018 +0100

accessibility: simplify OCommonAccessibleText

Change-Id: Ied5520179d15f0a854c16b14f5a5e6b84cef1300
Reviewed-on: https://gerrit.libreoffice.org/51514
Tested-by: Jenkins 
Reviewed-by: Arnaud Versini 

diff --git a/comphelper/source/misc/accessibletexthelper.cxx 
b/comphelper/source/misc/accessibletexthelper.cxx
index 9f1cccea85ba..202be72977af 100644
--- a/comphelper/source/misc/accessibletexthelper.cxx
+++ b/comphelper/source/misc/accessibletexthelper.cxx
@@ -96,21 +96,19 @@ namespace comphelper
 }
 
 
-void OCommonAccessibleText::implGetGlyphBoundary( i18n::Boundary& 
rBoundary, sal_Int32 nIndex )
+void OCommonAccessibleText::implGetGlyphBoundary( const OUString& rText, 
i18n::Boundary& rBoundary, sal_Int32 nIndex )
 {
-OUString sText( implGetText() );
-
-if ( implIsValidIndex( nIndex, sText.getLength() ) )
+if ( implIsValidIndex( nIndex, rText.getLength() ) )
 {
 Reference < i18n::XBreakIterator > xBreakIter = 
implGetBreakIterator();
 if ( xBreakIter.is() )
 {
 sal_Int32 nCount = 1;
 sal_Int32 nDone;
-sal_Int32 nStartIndex = xBreakIter->previousCharacters( sText, 
nIndex, implGetLocale(), i18n::CharacterIteratorMode::SKIPCELL, nCount, nDone );
+sal_Int32 nStartIndex = xBreakIter->previousCharacters( rText, 
nIndex, implGetLocale(), i18n::CharacterIteratorMode::SKIPCELL, nCount, nDone );
 if ( nDone != 0 )
-nStartIndex = xBreakIter->nextCharacters( sText, 
nStartIndex, implGetLocale(), i18n::CharacterIteratorMode::SKIPCELL, nCount, 
nDone );
-sal_Int32 nEndIndex = xBreakIter->nextCharacters( sText, 
nStartIndex, implGetLocale(), i18n::CharacterIteratorMode::SKIPCELL, nCount, 
nDone );
+nStartIndex = xBreakIter->nextCharacters( rText, 
nStartIndex, implGetLocale(), i18n::CharacterIteratorMode::SKIPCELL, nCount, 
nDone );
+sal_Int32 nEndIndex = xBreakIter->nextCharacters( rText, 
nStartIndex, implGetLocale(), i18n::CharacterIteratorMode::SKIPCELL, nCount, 
nDone );
 if ( nDone != 0 )
 {
 rBoundary.startPos = nStartIndex;
@@ -126,23 +124,22 @@ namespace comphelper
 }
 
 
-bool OCommonAccessibleText::implGetWordBoundary( i18n::Boundary& 
rBoundary, sal_Int32 nIndex )
+bool OCommonAccessibleText::implGetWordBoundary( const OUString& rText, 
i18n::Boundary& rBoundary, sal_Int32 nIndex )
 {
 bool bWord = false;
-OUString sText( implGetText() );
 
-if ( implIsValidIndex( nIndex, sText.getLength() ) )
+if ( implIsValidIndex( nIndex, rText.getLength() ) )
 {
 Reference < i18n::XBreakIterator > xBreakIter = 
implGetBreakIterator();
 if ( xBreakIter.is() )
 {
-rBoundary = xBreakIter->getWordBoundary( sText, nIndex, 
implGetLocale(), i18n::WordType::ANY_WORD, true );
+rBoundary = xBreakIter->getWordBoundary( rText, nIndex, 
implGetLocale(), i18n::WordType::ANY_WORD, true );
 
 // it's a word, if the first character is an alpha-numeric 
character
 Reference< i18n::XCharacterClassification > xCharClass = 
implGetCharacterClassification();
 if ( xCharClass.is() )
 {
-sal_Int32 nType = xCharClass->getCharacterType( sText, 
rBoundary.startPos, implGetLocale() );
+sal_Int32 nType = xCharClass->getCharacterType( rText, 
rBoundary.startPos, implGetLocale() );
 if ( ( nType & ( i18n::KCharacterType::LETTER | 
i18n::KCharacterType::DIGIT ) ) != 0 )
 bWord = true;
 }
@@ -158,18 +155,16 @@ namespace comphelper
 }
 
 
-void OCommonAccessibleText::implGetSentenceBoundary( i18n::Boundary& 
rBoundary, sal_Int32 nIndex )
+void OCommonAccessibleText::implGetSentenceBoundary( const OUString& 
rText, i18n::Boundary& rBoundary, sal_Int32 nIndex )
 {
-OUString sText( implGetText() );
-
-if ( implIsValidIndex( nIndex, sText.getLength() ) )
+if ( implIsValidIndex( nIndex, rText.getLength() ) )
 {
 Locale aLocale = implGetLocale();
 Reference < i18n::XBreakIterator > xBreakIter = 
implGetBreakIterator();
 if ( xBreakIter.is() )
 {
-rBoundary.endPos = xBreakIter->endOfSentence( sText, nIndex, 
aLocale );
-rBoundary.startPos = xBreakIter-

[Libreoffice-commits] core.git: vcl/source

2018-03-25 Thread Noel Grandin

 vcl/source/bitmap/BitmapTools.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit db22599c8c5a4a8b553194c05fff65bd6d71ab40
Author: Noel Grandin 
Date:   Sat Mar 24 14:41:15 2018 +0200

tdf#116509 OpenGL: Slideshows with Transitions crashing Impress

regression from
commit  e5012e53b919ae4921d6d35660bde323a6f28417
use scanline when reading pixel data

Change-Id: I1980a1acfedadbea706b93aed7452790e03257f2
Reviewed-on: https://gerrit.libreoffice.org/51803
Reviewed-by: Julien Nabet 
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/vcl/source/bitmap/BitmapTools.cxx 
b/vcl/source/bitmap/BitmapTools.cxx
index 7a722a699043..cfc4734c8aa0 100644
--- a/vcl/source/bitmap/BitmapTools.cxx
+++ b/vcl/source/bitmap/BitmapTools.cxx
@@ -963,9 +963,9 @@ void CanvasCairoExtractBitmapData( BitmapEx & aBmpEx, 
Bitmap & aBitmap, unsigned
  yGetScanline( y );
 if( pAlphaReadAccess.get() != nullptr )
 {
+Scanline pScanlineReadAlpha = pAlphaReadAccess->GetScanline( y 
);
 for( long x=rect.X1;
  xhttps://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/comphelper

2018-03-25 Thread Tor Lillqvist

 include/comphelper/windowsdebugoutput.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9c7f19a6a38eb6796df6216ff3f014db30dd635a
Author: Tor Lillqvist 
Date:   Sun Mar 25 12:55:37 2018 +0300

Fix copy-paste error

Change-Id: I01b20482aefadb1a755cc1d2f5705b2f7f7cf739

diff --git a/include/comphelper/windowsdebugoutput.hxx 
b/include/comphelper/windowsdebugoutput.hxx
index 0bb71dce99bf..9b7447657075 100644
--- a/include/comphelper/windowsdebugoutput.hxx
+++ b/include/comphelper/windowsdebugoutput.hxx
@@ -91,7 +91,7 @@ inline std::basic_ostream& 
operator<<(std::basic_ostreamhttps://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sfx2/source

2018-03-25 Thread Mike Kaganski

 sfx2/source/control/objface.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 08953137a4cba86e033d9c102ac679277cbc2f27
Author: Mike Kaganski 
Date:   Sun Mar 25 09:31:29 2018 +0100

Remove useless check

Change-Id: I9cfb8e7865e31b5c69e0b4b99426e96c7444224f
Reviewed-on: https://gerrit.libreoffice.org/51820
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/sfx2/source/control/objface.cxx b/sfx2/source/control/objface.cxx
index 78f561e3cedf..365dad5812ee 100644
--- a/sfx2/source/control/objface.cxx
+++ b/sfx2/source/control/objface.cxx
@@ -219,7 +219,7 @@ const SfxSlot* SfxInterface::GetSlot( sal_uInt16 nFuncId ) 
const
 if ( !p && pGenoType )
 return pGenoType->GetSlot( nFuncId );
 
-return p ? static_cast(p) : nullptr;
+return static_cast(p);
 }
 
 const SfxSlot* SfxInterface::GetSlot( const OUString& rCommand ) const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Google Summer of Code '18

2018-03-25 Thread Heiko Tietze

Hi Nick,

welcome to LibreOffice and great to see your interest in this topic. Please 
submit a proposal at the official GSoC page. I suggest to use a certain number 
of solved paper cuts for the milestones. In particular we want to check the 
progress at the first evaluation.

Cheers,
Heiko

On 24.03.2018 21:02, Nick Thanda wrote:
> Hi,
> My name is Nickson Thanda and I'm a final year student at Queen Mary, 
> University of London studying Computer Science.
> 
> I'm interested in applying for the 100 project cuts projects that . I'm 
> currently working on of the issues. (tdf#113925) and I have a submitted a 
> patch to gerrit which is waiting to be reviewed ( 
> https://gerrit.libreoffice.org/#/c/51470/)
> 
> Thanks,
> Nickson



signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - RepositoryFixes.mk Repository.mk solenv/gbuild

2018-03-25 Thread Damjan Jovanovic

 Repository.mk|4 ++--
 RepositoryFixes.mk   |   11 ---
 solenv/gbuild/Library.mk |5 +
 3 files changed, 11 insertions(+), 9 deletions(-)

New commits:
commit c2a248c822c7ddff365ca266cf2e71f8178635a7
Author: Damjan Jovanovic 
Date:   Sun Mar 25 07:14:42 2018 +

Move reg and store to UNOVERLIBS, as they are definitely URE libraries

as per main/ure/source/README, and deal with their unusual names in
RepositoryFixes.mk. Also remove special handling for them in gbuild.

Patch by: me

diff --git a/Repository.mk b/Repository.mk
index c9dd1cad9384..7c9f570f506c 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -173,8 +173,6 @@ $(eval $(call gb_Helper_register_libraries,OOOLIBS, \
 ))
 
 $(eval $(call gb_Helper_register_libraries,PLAINLIBS_URE, \
-reg \
-store \
 xmlreader \
 ))
 
@@ -244,7 +242,9 @@ $(eval $(call gb_Helper_register_libraries,UNOLIBS_OOO, \
 $(eval $(call gb_Helper_register_libraries,UNOVERLIBS, \
 cppu \
 jvmfwk \
+reg \
 sal \
+store \
 ))
 
 $(eval $(call gb_Helper_register_static_libraries,PLAINLIBS, \
diff --git a/RepositoryFixes.mk b/RepositoryFixes.mk
index 09fc2044c10f..a3440d428381 100644
--- a/RepositoryFixes.mk
+++ b/RepositoryFixes.mk
@@ -31,8 +31,10 @@ gb_Library_FILENAMES := $(patsubst 
cppuhelper:libcppuhelper%,cppuhelper:libuno_c
 gb_Library_FILENAMES := $(patsubst 
cppuhelper:libcppuhelper%,cppuhelper:libuno_cppuhelper%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
jvmfwk:libuno_jvmfwk%,jvmfwk:libjvmfwk%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
jvmfwk:libuno_jvmfwk%,jvmfwk:libjvmfwk%,$(gb_Library_FILENAMES))
+gb_Library_FILENAMES := $(patsubst 
reg:libuno_reg%,reg:libreg%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
salhelper:libsalhelper%,salhelper:libuno_salhelper%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
salhelper:libsalhelper%,salhelper:libuno_salhelper%,$(gb_Library_FILENAMES))
+gb_Library_FILENAMES := $(patsubst 
store:libuno_store%,store:libstore%,$(gb_Library_FILENAMES))
 
 gb_Library_FILENAMES := $(patsubst 
stl:%,stl:libstdc++.so,$(gb_Library_FILENAMES))
 gb_Library_TARGETS := $(filter-out stl,$(gb_Library_TARGETS))
@@ -44,7 +46,9 @@ ifeq ($(OS),SOLARIS)
 gb_Library_FILENAMES := $(patsubst 
comphelper:libcomphelper%,comphelper:libcomphelp%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
cppuhelper:libcppuhelper%,cppuhelper:libuno_cppuhelper%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
jvmfwk:libuno_jvmfwk%,jvmfwk:libjvmfwk%,$(gb_Library_FILENAMES))
+gb_Library_FILENAMES := $(patsubst 
reg:libuno_reg%,reg:libreg%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
salhelper:libsalhelper%,salhelper:libuno_salhelper%,$(gb_Library_FILENAMES))
+gb_Library_FILENAMES := $(patsubst 
store:libuno_store%,store:libstore%,$(gb_Library_FILENAMES))
 #$(info libnames: $(gb_Library_FILENAMES))
 
 endif
@@ -54,7 +58,9 @@ ifeq ($(OS),MACOSX)
 gb_Library_FILENAMES := $(patsubst 
comphelper:libcomphelper%,comphelper:libcomphelp%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
cppuhelper:libcppuhelper%,cppuhelper:libuno_cppuhelper%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
jvmfwk:libuno_jvmfwk%,jvmfwk:libjvmfwk%,$(gb_Library_FILENAMES))
+gb_Library_FILENAMES := $(patsubst 
reg:libuno_reg%,reg:libreg%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
salhelper:libsalhelper%,salhelper:libuno_salhelper%,$(gb_Library_FILENAMES))
+gb_Library_FILENAMES := $(patsubst 
store:libuno_store%,store:libstore%,$(gb_Library_FILENAMES))
 
 ifneq ($(MACOSX_DEPLOYMENT_TARGET),10.4) # default to use libc++
 gb_Library_FILENAMES := $(patsubst 
stl:%,stl:libc++.dylib,$(gb_Library_FILENAMES))
@@ -83,7 +89,6 @@ gb_Library_FILENAMES := $(patsubst 
ssl:issl%,ssl:ssl%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
xml2:ixml2%,xml2:libxml2$(gb_Library_IARCEXT),$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
xslt:ixslt%,xslt:libxslt.dll$(gb_Library_IARCEXT),$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
rdf:irdf%,rdf:librdf.dll$(gb_Library_IARCEXT),$(gb_Library_FILENAMES))
-gb_Library_FILENAMES := $(patsubst reg:reg%,reg:reg3%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst z:iz%,z:zlib%,$(gb_Library_FILENAMES))
 
 gb_Library_FILENAMES := $(patsubst 
stl:istl%,stl:msvcprt%,$(gb_Library_FILENAMES))
@@ -142,7 +147,6 @@ gb_Library_FILENAMES := $(patsubst 
ssl:issl%,ssl:ssleay32%,$(gb_Library_FILENAME
 gb_Library_FILENAMES := $(patsubst 
xml2:ixml2%,xml2:libxml2%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
xslt:ixslt%,xslt:libxslt%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
rdf:irdf%,rdf:librdf%,$(gb_Library_FILENAMES))
-gb_Library_FILENAMES := $(patsubst reg:reg%,reg:reg3%,$(gb_Library_FILENAMES))
 gb_StaticLibrary_FILENAMES := $(patsubst 
graphite:graphite%,graphite:graphite

Re: GSOC

2018-03-25 Thread Pranav Kant

Hi Vaibhav,

On 24/03/18 22:00, VAIBHAV kumar wrote:
> Mr.Pranav Kant,
>  I am interested in your project and want to join you. Please consider me as I
> have knowledge of c++.

For us to be able to consider you, you need to have fixed at least one easy 
hack:

https://wiki.documentfoundation.org/Development/LibreOffice_Online

Please see the Easy Hacks section above. You might find other helpful
information in that page too. As with any project, first step is to build it.
Have you already built Online successfully?

If you have any specific questions, regarding how to build it, or about how to
fix the easy hacks, happy to help.

All the best.

Thanks.

-- 
Regards,
Pranav

signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: GSoC 2018 : LIbreOffice | LOEclipse | Introduction : Shobhan Mandal

[Libreoffice-commits] core.git: 2 commits - include/vcl sfx2/CppunitTest_sfx2_misc.mk vcl/headless vcl/inc vcl/opengl vcl/osx vcl/qt5 vcl/quartz vcl/source vcl/unx vcl/win writerperfect/Library_writer

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 33 commits - chart2/source comphelper/source dbaccess/Library_dbahsql.mk dbaccess/source desktop/qa desktop/source embeddedobj/source

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - jvmaccess/inc jvmaccess/util

Nickson Thanda license statement

[Libreoffice-commits] core.git: sw/uiconfig

Paragraphs and numbering

More Shapes for LibreOffice

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 20 commits - avmedia/source cui/source desktop/source editeng/source extensions/source include/comphelper include/editeng include/sfx

lode Error:Unsupported base_os:MINGW64_NT-10.0

[Libreoffice-commits] core.git: icon-themes/colibre

[Libreoffice-commits] core.git: icon-themes/breeze icon-themes/breeze_dark icon-themes/breeze_svg

[Libreoffice-commits] core.git: sd/source

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 27 commits - comphelper/source configure.ac cui/source desktop/source editeng/qa editeng/source include/comphelper include/editeng in

[Libreoffice-commits] core.git: include/svx svx/inc svx/source

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 20 commits - basic/source cppuhelper/source cui/source desktop/qa desktop/source extensions/README extensions/source include/comphelp

Re: GSoC 2018 : LIbreOffice | LOEclipse | Introduction : Shobhan Mandal

Re: Serdar Oktay TUNÇ GSoC Introducyion

[Libreoffice-commits] core.git: sax/source sw/qa

[Libreoffice-commits] core.git: sc/qa

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 29 commits - comphelper/source configure.ac connectivity/source cui/source dbaccess/inc dbaccess/Library_dbahsql.mk dbaccess/Library_

[Libreoffice-commits] core.git: include/vcl vcl/source vcl/unx

[Libreoffice-commits] libvisio.git: 7 commits - src/lib

Crash test update

[Libreoffice-commits] core.git: lotuswordpro/qa lotuswordpro/source

[Libreoffice-commits] core.git: jvmaccess/source jvmfwk/plugins l10ntools/source libreofficekit/source linguistic/source

[Libreoffice-commits] libvisio.git: 8 commits - src/lib

[Libreoffice-commits] core.git: comphelper/source editeng/source include/comphelper

[Libreoffice-commits] core.git: vcl/source

[Libreoffice-commits] core.git: include/comphelper

[Libreoffice-commits] core.git: sfx2/source

Re: Google Summer of Code '18

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - RepositoryFixes.mk Repository.mk solenv/gbuild

Re: GSOC

34 matches

Site Navigation

Mail list logo

Footer information