[ANN] libetonyek 0.1.8 has been released

[David Tardon]

libetonyek is a library for parsing Apple Keynote, Pages and Numbers
formats.

Special thanks to Laurent Alonso, who did most of the work for this
release!

List of changes:

- All formats:
  + Parse fields.
  + Improve parsing of lists.
  + Fix output of orphans and widows paragraph properties.
  + Correctly handle rectangles with rounded corners.
  + Improve output of callouts.
  + Parse line ends (arrows).
  + Parse curves with multiple components.
  + Improve parsing of fills.
  + Improve parsing of tables.
  + Handle cropped images.
  + Parse grouped shapes.
  + Parse audio/video preview images.
  + Parse text wrap.

- Keynote 2-5:
  + Parse old-style images (Keynote 2-3?).
  + Parse slide styles.
  + Output master slides.
  + Parse connection lines.

- Keynote 6:
  + Improve detection of Keynote 6 documents. (tdf#113737)
  + Output master slides.
  + Parse connection lines.

- Numbers 1-2:
  + Properly parse TRUE and FALSE functions.

- Pages 1-4:
  + Parse annotations.
  + Improve parsing of images (position etc.).
  + Handle tables in a group.
  + Parse page dimensions from print settings.
- Pages 5:
  + Parse page dimensions.
  + Parse footnotes/endnotes.
  + Parse comments.
  + Parse headers/footers.
  + Parse tables.
  + Parse textboxes.
  + Fix line spacing and paragraph margins.
  + Parse more text properties.

- Miscellaneous:
  + Add support for Keynote 1 documents.
  + Add support for Numbers 3 documents.
  + Fix several issues found by oss-fuzz.
  + Fix build with glm 0.9.9.
  + Other fixes and improvements.

Home page: https://wiki.documentfoundation.org/DLP/Libraries/libetonyek
Download from: http://dev-www.libreoffice.org/src/libetonyek/

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: vcl/source

[Khaled Hosny]

 vcl/source/gdi/CommonSalLayout.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 88d0b8ac42a6d60c385d1e90c5cb84e9e9d194be
Author: Khaled Hosny 
Date:   Sat Apr 21 19:03:38 2018 +0200

Glyph flags is now an int not long

Change-Id: Ica262bf1f1d36ae731647ee0a0345901aa7265ec
Reviewed-on: https://gerrit.libreoffice.org/53267
Tested-by: Jenkins 
Reviewed-by: Khaled Hosny 

diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index c455475ba53d..5f27b744779d 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -753,7 +753,7 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs)
 continue;
 }
 
-long nGlyphFlags = 0;
+int nGlyphFlags = 0;
 if (bRightToLeft)
 nGlyphFlags |= GlyphItem::IS_RTL_GLYPH;
 
@@ -767,7 +767,7 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs)
 nGlyphFlags |= GlyphItem::IS_DIACRITIC;
 
 if (u_isUWhiteSpace(aChar))
- nGlyphFlags |= GlyphItem::IS_SPACING;
+nGlyphFlags |= GlyphItem::IS_SPACING;
 
 if (aSubRun.maScript == HB_SCRIPT_ARABIC &&
 HB_DIRECTION_IS_BACKWARD(aSubRun.maDirection) &&
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/inc vcl/source

[Khaled Hosny]

 vcl/inc/sallayout.hxx|4 +++-
 vcl/source/gdi/sallayout.cxx |9 -
 2 files changed, 7 insertions(+), 6 deletions(-)

New commits:
commit bb56e2ded30d190c57810812983e5010f6945915
Author: Khaled Hosny 
Date:   Sat Apr 21 20:38:58 2018 +0200

Don’t abuse glyph id for flagging dropped glyphs

Use a bitflag instead.

Change-Id: I7833a37578112b5326f4a30578596e53085ff3c0
Reviewed-on: https://gerrit.libreoffice.org/53269
Tested-by: Jenkins 
Reviewed-by: Khaled Hosny 

diff --git a/vcl/inc/sallayout.hxx b/vcl/inc/sallayout.hxx
index ba9cd3bd08e9..ffc38d4b8adf 100644
--- a/vcl/inc/sallayout.hxx
+++ b/vcl/inc/sallayout.hxx
@@ -286,7 +286,8 @@ public:
 IS_DIACRITIC  = 0x004,
 IS_VERTICAL   = 0x008,
 IS_SPACING= 0x010,
-ALLOW_KASHIDA = 0x020
+ALLOW_KASHIDA = 0x020,
+IS_DROPPED= 0x040
 };
 
 boolIsClusterStart() const  { return ((mnFlags & IS_IN_CLUSTER) == 0); 
}
@@ -295,6 +296,7 @@ public:
 boolIsVertical() const  { return ((mnFlags & IS_VERTICAL) != 0); }
 boolIsSpacing() const   { return ((mnFlags & IS_SPACING) != 0); }
 boolAllowKashida() const{ return ((mnFlags & ALLOW_KASHIDA) != 0); 
}
+boolIsDropped() const   { return ((mnFlags & IS_DROPPED) != 0); }
 };
 
 class VCL_PLUGIN_PUBLIC GenericSalLayout : public SalLayout
diff --git a/vcl/source/gdi/sallayout.cxx b/vcl/source/gdi/sallayout.cxx
index 616fc63e27fc..2d73d55517ea 100644
--- a/vcl/source/gdi/sallayout.cxx
+++ b/vcl/source/gdi/sallayout.cxx
@@ -47,7 +47,6 @@
 // Glyph Flags
 #define GF_FONTMASK  0xF000
 #define GF_FONTSHIFT 28
-#define GF_DROPPED   0x
 
 
 std::ostream  <<(std::ostream& s, ImplLayoutArgs const )
@@ -1003,19 +1002,19 @@ void GenericSalLayout::DropGlyph( int nStart )
 
 std::vector::iterator pGlyphIter = m_GlyphItems.begin();
 pGlyphIter += nStart;
-pGlyphIter->maGlyphId = GF_DROPPED;
 pGlyphIter->mnCharPos = -1;
+pGlyphIter->mnFlags |= GlyphItem::IS_DROPPED;
 }
 
 void GenericSalLayout::Simplify( bool bIsBase )
 {
-const sal_GlyphId nDropMarker = bIsBase ? GF_DROPPED : 0;
-
 // remove dropped glyphs inplace
 size_t j = 0;
 for(size_t i = 0; i < m_GlyphItems.size(); i++ )
 {
-if( m_GlyphItems[i].maGlyphId == nDropMarker )
+if (bIsBase && m_GlyphItems[i].IsDropped())
+continue;
+if (!bIsBase && m_GlyphItems[i].maGlyphId == 0)
 continue;
 
 if( i != j )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117095] Writer takes at least 5 minutes to open a one-page .odt file - with 131.000 bookmark lines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117095

--- Comment #6 from Yomo Como  ---
(In reply to Yomo Como from comment #4)
> (In reply to Timur from comment #2)
> > Repro all the way from OO to master. Also slow with MS Word. 
> > But I'm not in favor of confirming a bug. Looks like WontFix to me.
> > Because this is specific ODT with large content.xml that has multiple:
> > 
> > How was this created?
> 
> I used LibreOffice 5.1 on Ubuntu to create it and saved as an rtf file.
> After getting nagged about saving it in ODT, I resaved it in ODT.

I also sometimes copied some text from the internet and pasted into the file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117095] Writer takes at least 5 minutes to open a one-page .odt file - with 131.000 bookmark lines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117095

--- Comment #5 from Yomo Como  ---
(In reply to Timur from comment #3)
> Created attachment 141482 [details]
> The same file cleaned
> 
> The same file cleaned of 131.000 bookmark lines.

Thanks for cleaning it up, Timur. I'm not sure why it was so big with just a
page of text. Abiword is also struggling opening up the original file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117095] Writer takes at least 5 minutes to open a one-page .odt file - with 131.000 bookmark lines

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117095

--- Comment #4 from Yomo Como  ---
(In reply to Timur from comment #2)
> Repro all the way from OO to master. Also slow with MS Word. 
> But I'm not in favor of confirming a bug. Looks like WontFix to me.
> Because this is specific ODT with large content.xml that has multiple:
> 
> How was this created?

I used LibreOffice 5.1 on Ubuntu to create it and saved as an rtf file. After
getting nagged about saving it in ODT, I resaved it in ODT.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/vcl vcl/Library_vcl.mk vcl/source

[Chris Sherlock]

 include/vcl/BitmapMosaicFilter.hxx   |   36 +
 include/vcl/bitmap.hxx   |1 
 vcl/Library_vcl.mk   |1 
 vcl/source/bitmap/BitmapMosaicFilter.cxx |  187 +++
 vcl/source/gdi/bitmap4.cxx   |  183 +-
 5 files changed, 233 insertions(+), 175 deletions(-)

New commits:
commit 63a716783a555e91ad3a32f25f20cffc88ca15e4
Author: Chris Sherlock 
Date:   Fri Apr 20 20:39:48 2018 +1000

vcl: ImplMosaic() -> BitmapMosaicFilter

Change-Id: Ia0910ae9166c4eb6b870ab25db761bc1703fec68
Reviewed-on: https://gerrit.libreoffice.org/53203
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/vcl/BitmapMosaicFilter.hxx 
b/include/vcl/BitmapMosaicFilter.hxx
new file mode 100644
index ..0fbf19613b5f
--- /dev/null
+++ b/include/vcl/BitmapMosaicFilter.hxx
@@ -0,0 +1,36 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#ifndef INCLUDED_VCL_BITMAPMOSAICFILTER_HXX
+#define INCLUDED_VCL_BITMAPMOSAICFILTER_HXX
+
+#include 
+
+class BitmapEx;
+
+class VCL_DLLPUBLIC BitmapMosaicFilter : public BitmapFilter
+{
+public:
+BitmapMosaicFilter(sal_uLong nTileWidth, sal_uLong nTileHeight)
+: mnTileWidth(nTileWidth)
+, mnTileHeight(nTileHeight)
+{
+}
+
+virtual BitmapEx execute(BitmapEx const& rBitmapEx) override;
+
+private:
+sal_uLong mnTileWidth;
+sal_uLong mnTileHeight;
+};
+
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/vcl/bitmap.hxx b/include/vcl/bitmap.hxx
index b71f8a4224ba..2c1621041d7a 100644
--- a/include/vcl/bitmap.hxx
+++ b/include/vcl/bitmap.hxx
@@ -659,7 +659,6 @@ public:
 SAL_DLLPRIVATE bool ImplDitherFloyd16();
 
 SAL_DLLPRIVATE bool ImplEmbossGrey( const BmpFilterParam* pFilterParam 
);
-SAL_DLLPRIVATE bool ImplMosaic( const BmpFilterParam* pFilterParam );
 SAL_DLLPRIVATE bool ImplDuotoneFilter( const sal_uLong nColorOne,  
sal_uLong nColorTwo );
 
 public:
diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index 82f67dd845b9..49044708edd3 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -315,6 +315,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
 vcl/source/bitmap/BitmapSobelGreyFilter \
 vcl/source/bitmap/BitmapSolarizeFilter \
 vcl/source/bitmap/BitmapSepiaFilter \
+vcl/source/bitmap/BitmapMosaicFilter \
 vcl/source/bitmap/BitmapPopArtFilter \
 vcl/source/bitmap/BitmapConvolutionMatrixFilter \
 vcl/source/bitmap/BitmapMedianFilter \
diff --git a/vcl/source/bitmap/BitmapMosaicFilter.cxx 
b/vcl/source/bitmap/BitmapMosaicFilter.cxx
new file mode 100644
index ..faefbe5d3766
--- /dev/null
+++ b/vcl/source/bitmap/BitmapMosaicFilter.cxx
@@ -0,0 +1,187 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+BitmapEx BitmapMosaicFilter::execute(BitmapEx const& rBitmapEx)
+{
+Bitmap aBitmap(rBitmapEx.GetBitmap());
+
+bool bRet = false;
+
+if (!mnTileWidth)
+mnTileWidth = 1;
+
+if (!mnTileHeight)
+mnTileHeight = 1;
+
+if (mnTileWidth > 1 || mnTileHeight > 1)
+{
+Bitmap* pNewBmp;
+BitmapReadAccess* pReadAcc;
+BitmapWriteAccess* pWriteAcc;
+
+if (aBitmap.GetBitCount() > 8)
+{
+pNewBmp = nullptr;
+pReadAcc = pWriteAcc = aBitmap.AcquireWriteAccess();
+}
+else
+{
+pNewBmp = new Bitmap(aBitmap.GetSizePixel(), 24);
+pReadAcc = aBitmap.AcquireReadAccess();
+pWriteAcc = pNewBmp->AcquireWriteAccess();
+}
+
+bool bConditionsMet = false;
+long nWidth(0);
+long nHeight(0);
+if (pReadAcc && pWriteAcc)
+{
+nWidth = pReadAcc->Width();
+nHeight = pReadAcc->Height();
+bConditionsMet = (nWidth > 0 && nHeight > 0);
+}
+
+if (bConditionsMet)
+{
+BitmapColor aCol;
+long nX, nY, nX1, nX2, nY1, nY2, nSumR, nSumG, nSumB;
+double fArea_1;
+
+nY1 = 0;
+nY2 = mnTileHeight - 1;
+
+if (nY2 >= nHeight)
+nY2 = nHeight - 1;
+
+do
+

[Libreoffice-commits] core.git: 3 commits - include/vcl vcl/Library_vcl.mk vcl/source

[Chris Sherlock]

 include/vcl/BitmapPopArtFilter.hxx |   33 
 include/vcl/BitmapSepiaFilter.hxx  |   34 
 include/vcl/BitmapSolarizeFilter.hxx   |   34 
 include/vcl/bitmap.hxx |3 
 vcl/Library_vcl.mk |3 
 vcl/source/bitmap/BitmapPopArtFilter.cxx   |  118 ++
 vcl/source/bitmap/BitmapSepiaFilter.cxx|  106 
 vcl/source/bitmap/BitmapSolarizeFilter.cxx |   68 
 vcl/source/gdi/bitmap4.cxx |  239 ++---
 9 files changed, 414 insertions(+), 224 deletions(-)

New commits:
commit 1ab12471f3a69c4d502e6271e84ddf8a981f507f
Author: Chris Sherlock 
Date:   Fri Apr 20 20:32:23 2018 +1000

vcl: ImplSepia -> BitmapSepiaFilter

Change-Id: I96a4072bf919bd37b30c01ab16d98779c76717ab
Reviewed-on: https://gerrit.libreoffice.org/53202
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/vcl/BitmapSepiaFilter.hxx 
b/include/vcl/BitmapSepiaFilter.hxx
new file mode 100644
index ..717f10d1466b
--- /dev/null
+++ b/include/vcl/BitmapSepiaFilter.hxx
@@ -0,0 +1,34 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#ifndef INCLUDED_VCL_BITMAPSEPIAFILTER_HXX
+#define INCLUDED_VCL_BITMAPSEPIAFILTER_HXX
+
+#include 
+
+class BitmapEx;
+
+class VCL_DLLPUBLIC BitmapSepiaFilter : public BitmapFilter
+{
+public:
+BitmapSepiaFilter(double nSepiaPercent)
+: mnSepiaPercent(nSepiaPercent)
+{
+}
+
+virtual BitmapEx execute(BitmapEx const& rBitmapEx) override;
+
+private:
+sal_uInt16 mnSepiaPercent;
+};
+
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/vcl/bitmap.hxx b/include/vcl/bitmap.hxx
index bffeca808ea2..b71f8a4224ba 100644
--- a/include/vcl/bitmap.hxx
+++ b/include/vcl/bitmap.hxx
@@ -659,7 +659,6 @@ public:
 SAL_DLLPRIVATE bool ImplDitherFloyd16();
 
 SAL_DLLPRIVATE bool ImplEmbossGrey( const BmpFilterParam* pFilterParam 
);
-SAL_DLLPRIVATE bool ImplSepia( const BmpFilterParam* pFilterParam );
 SAL_DLLPRIVATE bool ImplMosaic( const BmpFilterParam* pFilterParam );
 SAL_DLLPRIVATE bool ImplDuotoneFilter( const sal_uLong nColorOne,  
sal_uLong nColorTwo );
 
diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index 940bd8b35974..82f67dd845b9 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -314,6 +314,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
 vcl/source/bitmap/bitmapfilter \
 vcl/source/bitmap/BitmapSobelGreyFilter \
 vcl/source/bitmap/BitmapSolarizeFilter \
+vcl/source/bitmap/BitmapSepiaFilter \
 vcl/source/bitmap/BitmapPopArtFilter \
 vcl/source/bitmap/BitmapConvolutionMatrixFilter \
 vcl/source/bitmap/BitmapMedianFilter \
diff --git a/vcl/source/bitmap/BitmapSepiaFilter.cxx 
b/vcl/source/bitmap/BitmapSepiaFilter.cxx
new file mode 100644
index ..a953fcbee2a8
--- /dev/null
+++ b/vcl/source/bitmap/BitmapSepiaFilter.cxx
@@ -0,0 +1,106 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+BitmapEx BitmapSepiaFilter::execute(BitmapEx const& rBitmapEx)
+{
+Bitmap aBitmap(rBitmapEx.GetBitmap());
+Bitmap::ScopedReadAccess pReadAcc(aBitmap);
+bool bRet = false;
+
+if (pReadAcc)
+{
+const long nSepia = 1 - 100 * SAL_BOUND(mnSepiaPercent, 0, 100);
+BitmapPalette aSepiaPal(256);
+
+for (sal_uInt16 i = 0; i < 256; i++)
+{
+BitmapColor& rCol = aSepiaPal[i];
+const sal_uInt8 cSepiaValue = static_cast(nSepia * i / 
1);
+
+rCol.SetRed(static_cast(i));
+rCol.SetGreen(cSepiaValue);
+rCol.SetBlue(cSepiaValue);
+}
+
+Bitmap aNewBmp(aBitmap.GetSizePixel(), 8, );
+BitmapScopedWriteAccess pWriteAcc(aNewBmp);
+
+if (pWriteAcc)
+{
+BitmapColor aCol(sal_uInt8(0));
+const long nWidth = pWriteAcc->Width();
+const long nHeight = pWriteAcc->Height();
+
+if (pReadAcc->HasPalette())
+{
+const sal_uInt16 nPalCount = pReadAcc->GetPaletteEntryCount();
+std::unique_ptr pIndexMap(new 
sal_uInt8[nPalCount]);
+for 

[Libreoffice-commits] core.git: include/vcl vcl/Library_vcl.mk vcl/source

[Chris Sherlock]

 include/vcl/BitmapSobelGreyFilter.hxx   |   26 
 include/vcl/bitmap.hxx  |1 
 vcl/Library_vcl.mk  |1 
 vcl/source/bitmap/BitmapSobelGreyFilter.cxx |  166 
 vcl/source/gdi/bitmap4.cxx  |  135 +-
 5 files changed, 199 insertions(+), 130 deletions(-)

New commits:
commit 0474be6d5527baab609b16846d6cb38ed89d47fc
Author: Chris Sherlock 
Date:   Thu Apr 19 20:36:10 2018 +1000

vcl: ImplSobelGrey() -> BitmapSobelGreyFilter

Change-Id: I2082d7e3b90172b4517ad0f4be75f85006eb5891
Reviewed-on: https://gerrit.libreoffice.org/53150
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/vcl/BitmapSobelGreyFilter.hxx 
b/include/vcl/BitmapSobelGreyFilter.hxx
new file mode 100644
index ..ac4cd9498d65
--- /dev/null
+++ b/include/vcl/BitmapSobelGreyFilter.hxx
@@ -0,0 +1,26 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#ifndef INCLUDED_VCL_BITMAPSOBELGREYILTER_HXX
+#define INCLUDED_VCL_BITMAPSOBELGREYILTER_HXX
+
+#include 
+
+class VCL_DLLPUBLIC BitmapSobelGreyFilter : public BitmapFilter
+{
+public:
+BitmapSobelGreyFilter() {}
+
+virtual BitmapEx execute(BitmapEx const& rBitmapEx) override;
+};
+
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/vcl/bitmap.hxx b/include/vcl/bitmap.hxx
index b89b2004fed6..7f560e517ab0 100644
--- a/include/vcl/bitmap.hxx
+++ b/include/vcl/bitmap.hxx
@@ -658,7 +658,6 @@ public:
 SAL_DLLPRIVATE bool ImplDitherFloyd();
 SAL_DLLPRIVATE bool ImplDitherFloyd16();
 
-SAL_DLLPRIVATE bool ImplSobelGrey();
 SAL_DLLPRIVATE bool ImplEmbossGrey( const BmpFilterParam* pFilterParam 
);
 SAL_DLLPRIVATE bool ImplSolarize( const BmpFilterParam* pFilterParam );
 SAL_DLLPRIVATE bool ImplSepia( const BmpFilterParam* pFilterParam );
diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index ba26fb7fa91e..72aa7e122217 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -312,6 +312,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
 vcl/source/graphic/UnoGraphicTransformer \
 vcl/source/bitmap/bitmap \
 vcl/source/bitmap/bitmapfilter \
+vcl/source/bitmap/BitmapSobelGreyFilter \
 vcl/source/bitmap/BitmapConvolutionMatrixFilter \
 vcl/source/bitmap/BitmapMedianFilter \
 vcl/source/bitmap/BitmapInterpolateScaleFilter \
diff --git a/vcl/source/bitmap/BitmapSobelGreyFilter.cxx 
b/vcl/source/bitmap/BitmapSobelGreyFilter.cxx
new file mode 100644
index ..450772dd2abe
--- /dev/null
+++ b/vcl/source/bitmap/BitmapSobelGreyFilter.cxx
@@ -0,0 +1,166 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+BitmapEx BitmapSobelGreyFilter::execute(BitmapEx const& rBitmapEx)
+{
+Bitmap aBitmap(rBitmapEx.GetBitmap());
+
+bool bRet = aBitmap.ImplMakeGreyscales(256);
+
+if (bRet)
+{
+bRet = false;
+
+Bitmap::ScopedReadAccess pReadAcc(aBitmap);
+
+if (pReadAcc)
+{
+Bitmap aNewBmp(aBitmap.GetSizePixel(), 8, >GetPalette());
+BitmapScopedWriteAccess pWriteAcc(aNewBmp);
+
+if (pWriteAcc)
+{
+BitmapColor aGrey(sal_uInt8(0));
+const long nWidth = pWriteAcc->Width();
+const long nHeight = pWriteAcc->Height();
+const long nMask111 = -1, nMask121 = 0, nMask131 = 1;
+const long nMask211 = -2, nMask221 = 0, nMask231 = 2;
+const long nMask311 = -1, nMask321 = 0, nMask331 = 1;
+const long nMask112 = 1, nMask122 = 2, nMask132 = 1;
+const long nMask212 = 0, nMask222 = 0, nMask232 = 0;
+const long nMask312 = -1, nMask322 = -2, nMask332 = -1;
+long nGrey11, nGrey12, nGrey13;
+long nGrey21, nGrey22, nGrey23;
+long nGrey31, nGrey32, nGrey33;
+long* pHMap = new long[nWidth + 2];
+long* pVMap = new long[nHeight + 2];
+long nX, nY, nSum1, nSum2;
+
+// fill mapping tables
+pHMap[0] = 0;
+
+for (nX = 1; nX <= nWidth; nX++)
+{

[Libreoffice-commits] core.git: include/vcl vcl/Library_vcl.mk vcl/source

[Chris Sherlock]

 include/vcl/BitmapMedianFilter.hxx   |   28 +++
 include/vcl/bitmap.hxx   |1 
 vcl/Library_vcl.mk   |1 
 vcl/source/bitmap/BitmapMedianFilter.cxx |  226 +++
 vcl/source/gdi/bitmap4.cxx   |  175 
 5 files changed, 261 insertions(+), 170 deletions(-)

New commits:
commit 5b5d84df69765b9bd2fccb76a16d824720eea462
Author: Chris Sherlock 
Date:   Thu Apr 19 07:02:34 2018 +1000

vcl: ImplMedianFilter() -> BitmapMedianFilter

Change-Id: I72a0546c11d6ef8a8a4eb467d566d639c88dc8b9
Reviewed-on: https://gerrit.libreoffice.org/53130
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/vcl/BitmapMedianFilter.hxx 
b/include/vcl/BitmapMedianFilter.hxx
new file mode 100644
index ..e51a66eabcb7
--- /dev/null
+++ b/include/vcl/BitmapMedianFilter.hxx
@@ -0,0 +1,28 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#ifndef INCLUDED_VCL_BITMAPMEDIANFILTER_HXX
+#define INCLUDED_VCL_BITMAPMEDIANFILTER_HXX
+
+#include 
+
+class BitmapEx;
+
+class VCL_DLLPUBLIC BitmapMedianFilter : public BitmapFilter
+{
+public:
+BitmapMedianFilter() {}
+
+virtual BitmapEx execute(BitmapEx const& rBitmapEx) override;
+};
+
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/vcl/bitmap.hxx b/include/vcl/bitmap.hxx
index df6d094a9886..b89b2004fed6 100644
--- a/include/vcl/bitmap.hxx
+++ b/include/vcl/bitmap.hxx
@@ -658,7 +658,6 @@ public:
 SAL_DLLPRIVATE bool ImplDitherFloyd();
 SAL_DLLPRIVATE bool ImplDitherFloyd16();
 
-SAL_DLLPRIVATE bool ImplMedianFilter();
 SAL_DLLPRIVATE bool ImplSobelGrey();
 SAL_DLLPRIVATE bool ImplEmbossGrey( const BmpFilterParam* pFilterParam 
);
 SAL_DLLPRIVATE bool ImplSolarize( const BmpFilterParam* pFilterParam );
diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index 57cd8d3962c7..ba26fb7fa91e 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -313,6 +313,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
 vcl/source/bitmap/bitmap \
 vcl/source/bitmap/bitmapfilter \
 vcl/source/bitmap/BitmapConvolutionMatrixFilter \
+vcl/source/bitmap/BitmapMedianFilter \
 vcl/source/bitmap/BitmapInterpolateScaleFilter \
 vcl/source/bitmap/BitmapLightenFilter \
 vcl/source/bitmap/BitmapDisabledImageFilter \
diff --git a/vcl/source/bitmap/BitmapMedianFilter.cxx 
b/vcl/source/bitmap/BitmapMedianFilter.cxx
new file mode 100644
index ..45f1149a1c0c
--- /dev/null
+++ b/vcl/source/bitmap/BitmapMedianFilter.cxx
@@ -0,0 +1,226 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#include 
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+#define S2(a, b)   
\
+{  
\
+long t;
\
+if ((t = b - a) < 0)   
\
+{  
\
+a += t;
\
+b -= t;
\
+}  
\
+}
+#define MN3(a, b, c)   
\
+S2(a, b);  
\
+S2(a, c);
+#define MX3(a, b, c)   
\
+S2(b, c);  
\
+S2(a, c);
+#define MNMX3(a, b, c) 
\
+MX3(a, b, c);  
\
+S2(a, b);
+#define MNMX4(a, b, c, d)   

[Libreoffice-commits] core.git: include/vcl vcl/source

[Chris Sherlock]

 include/vcl/BitmapConvolutionMatrixFilter.hxx |7 +-
 include/vcl/BitmapSharpenFilter.hxx   |   28 ++
 vcl/source/gdi/bitmap4.cxx|5 +---
 3 files changed, 36 insertions(+), 4 deletions(-)

New commits:
commit 8559353af24123c7a736e64311d57d85bb3cb44c
Author: Chris Sherlock 
Date:   Thu Apr 19 06:50:32 2018 +1000

vcl: introduce BitmapSharpenFilter

Change-Id: Ib503efa3634b3a000261d2398d04f779079bfe3f
Reviewed-on: https://gerrit.libreoffice.org/53129
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/vcl/BitmapConvolutionMatrixFilter.hxx 
b/include/vcl/BitmapConvolutionMatrixFilter.hxx
index d27bfffb0fcd..a2189326322b 100644
--- a/include/vcl/BitmapConvolutionMatrixFilter.hxx
+++ b/include/vcl/BitmapConvolutionMatrixFilter.hxx
@@ -20,6 +20,11 @@ class BitmapEx;
 class VCL_DLLPUBLIC BitmapConvolutionMatrixFilter : public BitmapFilter
 {
 public:
+BitmapConvolutionMatrixFilter()
+: mpMatrix(nullptr)
+{
+}
+
 BitmapConvolutionMatrixFilter(const long* pMatrix)
 : mpMatrix(pMatrix)
 {
@@ -29,7 +34,7 @@ public:
 
 virtual BitmapEx execute(BitmapEx const& rBitmapEx) override;
 
-private:
+protected:
 const long* mpMatrix;
 };
 
diff --git a/include/vcl/BitmapSharpenFilter.hxx 
b/include/vcl/BitmapSharpenFilter.hxx
new file mode 100644
index ..7e965976d5e8
--- /dev/null
+++ b/include/vcl/BitmapSharpenFilter.hxx
@@ -0,0 +1,28 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#ifndef INCLUDED_VCL_BITMAPSHARPENFILTER_HXX
+#define INCLUDED_VCL_BITMAPSHARPENFILTER_HXX
+
+#include 
+
+class VCL_DLLPUBLIC BitmapSharpenFilter : public BitmapConvolutionMatrixFilter
+{
+public:
+BitmapSharpenFilter()
+{
+const long pSharpenMatrix[] = { -1, -1, -1, -1, 16, -1, -1, -1, -1 };
+mpMatrix = [0];
+}
+};
+
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/gdi/bitmap4.cxx b/vcl/source/gdi/bitmap4.cxx
index e7c18f01718d..f13aa0bb9d24 100644
--- a/vcl/source/gdi/bitmap4.cxx
+++ b/vcl/source/gdi/bitmap4.cxx
@@ -21,7 +21,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 
 #include 
 
@@ -60,9 +60,8 @@ bool Bitmap::Filter( BmpFilter eFilter, const BmpFilterParam* 
pFilterParam )
 
 case BmpFilter::Sharpen:
 {
-const long pSharpenMatrix[] = { -1, -1,  -1, -1, 16, -1, -1, -1,  
-1 };
 BitmapEx aBmpEx(*this);
-bRet = BitmapFilter::Filter(aBmpEx, 
BitmapConvolutionMatrixFilter([0]));
+bRet = BitmapFilter::Filter(aBmpEx, BitmapSharpenFilter());
 *this = aBmpEx.GetBitmap();
 }
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/vcl vcl/Library_vcl.mk vcl/source

[Chris Sherlock]

 include/vcl/BitmapSmoothenFilter.hxx   |   34 +++
 vcl/Library_vcl.mk |3 +-
 vcl/source/bitmap/BitmapSmoothenFilter.cxx |   36 +
 vcl/source/gdi/bitmap4.cxx |   24 +++
 4 files changed, 76 insertions(+), 21 deletions(-)

New commits:
commit 57faa86592ddfc60be206b70ee16671585b7ca60
Author: Chris Sherlock 
Date:   Wed Apr 18 21:19:58 2018 +1000

vcl: create BitmapSmoothenFilter

Change-Id: I5259035e18daada3cd8963f045731a0a65150718
Reviewed-on: https://gerrit.libreoffice.org/53099
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/vcl/BitmapSmoothenFilter.hxx 
b/include/vcl/BitmapSmoothenFilter.hxx
new file mode 100644
index ..131809700680
--- /dev/null
+++ b/include/vcl/BitmapSmoothenFilter.hxx
@@ -0,0 +1,34 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#ifndef INCLUDED_VCL_BITMAPSMOOTHENFILTER_HXX
+#define INCLUDED_VCL_BITMAPSMOOTHENFILTER_HXX
+
+#include 
+
+class BitmapEx;
+
+class VCL_DLLPUBLIC BitmapSmoothenFilter : public BitmapFilter
+{
+public:
+BitmapSmoothenFilter(double fRadius)
+: mfRadius(fRadius)
+{
+}
+
+virtual BitmapEx execute(BitmapEx const& rBitmapEx) override;
+
+private:
+double mfRadius;
+};
+
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index 644620981c94..57cd8d3962c7 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -320,7 +320,8 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
 vcl/source/bitmap/bitmappaint \
 vcl/source/bitmap/BitmapGaussianSeparableBlurFilter \
 vcl/source/bitmap/BitmapSeparableUnsharpenFilter \
-vcl/source/bitmap/BitmapFastScaleFilter \
+vcl/source/bitmap/BitmapSmoothenFilter \
+   vcl/source/bitmap/BitmapFastScaleFilter \
 vcl/source/bitmap/BitmapScaleSuperFilter \
 vcl/source/bitmap/BitmapScaleConvolutionFilter \
 vcl/source/bitmap/BitmapSymmetryCheck \
diff --git a/vcl/source/bitmap/BitmapSmoothenFilter.cxx 
b/vcl/source/bitmap/BitmapSmoothenFilter.cxx
new file mode 100644
index ..4c3b3f53c368
--- /dev/null
+++ b/vcl/source/bitmap/BitmapSmoothenFilter.cxx
@@ -0,0 +1,36 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+BitmapEx BitmapSmoothenFilter::execute(BitmapEx const& rBitmapEx)
+{
+BitmapEx aBitmapEx(rBitmapEx);
+bool bRet = false;
+
+if (mfRadius > 0.0) // Blur for positive values of mnRadius
+bRet = BitmapFilter::Filter(aBitmapEx, 
BitmapGaussianSeparableBlurFilter(mfRadius));
+else if (mfRadius < 0.0) // Unsharpen mask for negative values of mnRadius
+bRet = BitmapFilter::Filter(aBitmapEx, 
BitmapSeparableUnsharpenFilter(mfRadius));
+
+if (bRet)
+return BitmapEx(rBitmapEx);
+
+return BitmapEx();
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/gdi/bitmap4.cxx b/vcl/source/gdi/bitmap4.cxx
index 8e4d7a7d2f36..e7c18f01718d 100644
--- a/vcl/source/gdi/bitmap4.cxx
+++ b/vcl/source/gdi/bitmap4.cxx
@@ -20,8 +20,7 @@
 #include 
 #include 
 #include 
-#include 
-#include 
+#include 
 #include 
 
 #include 
@@ -53,24 +52,9 @@ bool Bitmap::Filter( BmpFilter eFilter, const 
BmpFilterParam* pFilterParam )
 {
 case BmpFilter::Smooth:
 {
-// Blur for positive values of mnRadius
-if (pFilterParam->mnRadius > 0.0)
-{
-BitmapEx aBmpEx(*this);
-bRet = BitmapFilter::Filter(aBmpEx, 
BitmapGaussianSeparableBlurFilter(pFilterParam->mnRadius));
-*this = aBmpEx.GetBitmap();
-}
-// Unsharpen Mask for negative values of mnRadius
-else if (pFilterParam->mnRadius < 0.0)
-{
-BitmapEx aBmpEx(*this);
-bRet = BitmapFilter::Filter(aBmpEx, 
BitmapSeparableUnsharpenFilter(pFilterParam->mnRadius));
-*this = aBmpEx.GetBitmap();
-}
-else
-{
-bRet = false;
-}
+BitmapEx aBmpEx(*this);
+bRet = BitmapFilter::Filter(aBmpEx, 

[Libreoffice-commits] core.git: include/vcl vcl/Library_vcl.mk vcl/source

[Chris Sherlock]

 include/vcl/BitmapConvolutionMatrixFilter.hxx   |   38 +++
 include/vcl/bitmap.hxx  |2 
 vcl/Library_vcl.mk  |1 
 vcl/source/bitmap/BitmapConvolutionMatrixFilter.cxx |  199 
 vcl/source/gdi/bitmap4.cxx  |  163 
 5 files changed, 242 insertions(+), 161 deletions(-)

New commits:
commit 7b06fcddf8d9a0b51bf396d29487f1fd715b82d3
Author: Chris Sherlock 
Date:   Wed Apr 18 21:06:15 2018 +1000

vcl: ImplConvolute3() -> BitmapConvolutionMatrixFilter

Change-Id: I0203e98d29192ef098719c0a297b967710b8729a
Reviewed-on: https://gerrit.libreoffice.org/53097
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/vcl/BitmapConvolutionMatrixFilter.hxx 
b/include/vcl/BitmapConvolutionMatrixFilter.hxx
new file mode 100644
index ..d27bfffb0fcd
--- /dev/null
+++ b/include/vcl/BitmapConvolutionMatrixFilter.hxx
@@ -0,0 +1,38 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#ifndef INCLUDED_VCL_BITMAPCONVOLUTIONMATRIXFILTER_HXX
+#define INCLUDED_VCL_BITMAPCONVOLUTIONMATRIXFILTER_HXX
+
+#include 
+
+class BitmapEx;
+
+/** Filter image based on a 3x3 convolution matrix
+ */
+class VCL_DLLPUBLIC BitmapConvolutionMatrixFilter : public BitmapFilter
+{
+public:
+BitmapConvolutionMatrixFilter(const long* pMatrix)
+: mpMatrix(pMatrix)
+{
+}
+
+~BitmapConvolutionMatrixFilter() override { delete mpMatrix; }
+
+virtual BitmapEx execute(BitmapEx const& rBitmapEx) override;
+
+private:
+const long* mpMatrix;
+};
+
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/vcl/bitmap.hxx b/include/vcl/bitmap.hxx
index 07573b1af1b0..df6d094a9886 100644
--- a/include/vcl/bitmap.hxx
+++ b/include/vcl/bitmap.hxx
@@ -658,8 +658,6 @@ public:
 SAL_DLLPRIVATE bool ImplDitherFloyd();
 SAL_DLLPRIVATE bool ImplDitherFloyd16();
 
-SAL_DLLPRIVATE bool ImplConvolute3( const long* pMatrix );
-
 SAL_DLLPRIVATE bool ImplMedianFilter();
 SAL_DLLPRIVATE bool ImplSobelGrey();
 SAL_DLLPRIVATE bool ImplEmbossGrey( const BmpFilterParam* pFilterParam 
);
diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index 8a2edf75b2b4..644620981c94 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -312,6 +312,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
 vcl/source/graphic/UnoGraphicTransformer \
 vcl/source/bitmap/bitmap \
 vcl/source/bitmap/bitmapfilter \
+vcl/source/bitmap/BitmapConvolutionMatrixFilter \
 vcl/source/bitmap/BitmapInterpolateScaleFilter \
 vcl/source/bitmap/BitmapLightenFilter \
 vcl/source/bitmap/BitmapDisabledImageFilter \
diff --git a/vcl/source/bitmap/BitmapConvolutionMatrixFilter.cxx 
b/vcl/source/bitmap/BitmapConvolutionMatrixFilter.cxx
new file mode 100644
index ..fea2e6dac4f4
--- /dev/null
+++ b/vcl/source/bitmap/BitmapConvolutionMatrixFilter.cxx
@@ -0,0 +1,199 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#include 
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+BitmapEx BitmapConvolutionMatrixFilter::execute(BitmapEx const& rBitmapEx)
+{
+Bitmap aBitmap(rBitmapEx.GetBitmap());
+
+const long nDivisor = 8;
+Bitmap::ScopedReadAccess pReadAcc(aBitmap);
+bool bRet = false;
+
+if (pReadAcc)
+{
+Bitmap aNewBmp(aBitmap.GetSizePixel(), 24);
+BitmapScopedWriteAccess pWriteAcc(aNewBmp);
+
+if (pWriteAcc)
+{
+const long nWidth = pWriteAcc->Width(), nWidth2 = nWidth + 2;
+const long nHeight = pWriteAcc->Height(), nHeight2 = nHeight + 2;
+long* pColm = new long[nWidth2];
+long* pRows = new long[nHeight2];
+BitmapColor* pColRow1
+= reinterpret_cast(new 
sal_uInt8[sizeof(BitmapColor) * nWidth2]);
+BitmapColor* pColRow2
+= reinterpret_cast(new 
sal_uInt8[sizeof(BitmapColor) * nWidth2]);
+BitmapColor* pColRow3
+= reinterpret_cast(new 
sal_uInt8[sizeof(BitmapColor) * nWidth2]);
+BitmapColor* pRowTmp1 = pColRow1;
+BitmapColor* pRowTmp2 = pColRow2;
+BitmapColor* pRowTmp3 

[Libreoffice-bugs] [Bug 42505] EDITING: Inserting a frame around a table is not undoable - Undo is reset

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=42505

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72101] UNDO incomplete when contents of a cell with formula is deleted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72101

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81512] Undo: Writer fails to restore Table Name

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=81512

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107319] Clear direct formatting doesnt work with frame styled elements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107319

--- Comment #2 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76259] EDITING: Undo: Tables vs numbered list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=76259

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107162] ods to xls conversion trouble

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107162

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79404] EDITING: Undo after AutoCorrect removes the whole cell content instead of reverting just the autocorrect changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79404

--- Comment #16 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89323] undo option after entering values in table is not working in Libreoffice Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89323

--- Comment #9 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 68472] UNDO incomplete: alignment not restored in cells after UNDO cells merge

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=68472

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107317] Undo label shows 'Insert $1'

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107317

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100298] Style names come and go (are blanked out / white) in Styles and Formatting window (OSX ≤ 10.10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100298

--- Comment #24 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89611] TOC: Undos lost after modifying index/table of contents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89611

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117150] New: calc notebook toolbar menubar issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117150

Bug ID: 117150
   Summary: calc notebook toolbar menubar issues
   Product: LibreOffice
   Version: 6.0.3.2 release
  Hardware: All
OS: other
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: perie_...@hotmail.com

issue 1: under notebookbar settings, menubar is missing. 

issue 2: Once in notebookbar settings, everything is defaulted to groupedbar
compact. Users cannot changed to contextual or to other selections. 

Both of these issues are present in windows 10 and 7

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117149] New: Crash in: BigPtrArray::Index2Block(unsigned long) const

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117149

Bug ID: 117149
   Summary: Crash in: BigPtrArray::Index2Block(unsigned long)
const
   Product: LibreOffice
   Version: 6.0.3.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: fiendi...@gmail.com

This bug was filed from the crash reporting server and is
br-1b57d12b-1051-4a92-9ffe-00d44f7f4e81.
=

Crash happened while undoing (ctrl-z) some edits in a change-tracked docx.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117126] Compress image breaks crop

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117126

Luke  changed:

   What|Removed |Added

   Keywords|regression  |
  Component|LibreOffice |Impress
Version|6.0.3.2 release |4.1.0.4 release

--- Comment #5 from Luke  ---
Repo in 6.1 master and Version: 4.1.0.1


Removed the "regression" keyword. Also, I fail to see how this is not a dupe of
bug 83734. Steps to reproduce are identical, just different components.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc

[Khaled Hosny]

 vcl/inc/fontsubset.hxx  |2 +-
 vcl/inc/pch/precompiled_vcl.hxx |1 -
 vcl/inc/salglyphid.hxx  |   27 ---
 vcl/inc/sallayout.hxx   |4 ++--
 vcl/inc/unx/fontmanager.hxx |2 +-
 5 files changed, 4 insertions(+), 32 deletions(-)

New commits:
commit 2ed7c02478968852d7d39c2c4677f2ecf3441bc7
Author: Khaled Hosny 
Date:   Sat Apr 21 20:15:03 2018 +0200

Drop header that had just one typedef

Move the typedef elsewhere.

Change-Id: I7a91ffd5ed4d1f182d6d57c80eb5188892fa5ccd
Reviewed-on: https://gerrit.libreoffice.org/53268
Tested-by: Jenkins 
Reviewed-by: Khaled Hosny 

diff --git a/vcl/inc/fontsubset.hxx b/vcl/inc/fontsubset.hxx
index 7973061eafd8..66368b7cbcb9 100644
--- a/vcl/inc/fontsubset.hxx
+++ b/vcl/inc/fontsubset.hxx
@@ -24,7 +24,7 @@
 #include 
 #include 
 
-#include "salglyphid.hxx"
+#include "sallayout.hxx"
 
 namespace vcl { struct TrueTypeFont; } ///< SFT's idea of a TTF font
 
diff --git a/vcl/inc/pch/precompiled_vcl.hxx b/vcl/inc/pch/precompiled_vcl.hxx
index d3ca3bf1e6f3..509a0493ffec 100644
--- a/vcl/inc/pch/precompiled_vcl.hxx
+++ b/vcl/inc/pch/precompiled_vcl.hxx
@@ -111,7 +111,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/vcl/inc/salglyphid.hxx b/vcl/inc/salglyphid.hxx
deleted file mode 100644
index 6f9550e50bca..
--- a/vcl/inc/salglyphid.hxx
+++ /dev/null
@@ -1,27 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-#ifndef INCLUDED_VCL_INC_SALGLYPHID_HXX
-#define INCLUDED_VCL_INC_SALGLYPHID_HXX
-
-typedef sal_uInt32 sal_GlyphId;
-
-
-#endif // INCLUDED_VCL_INC_SALGLYPHID_HXX
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/inc/sallayout.hxx b/vcl/inc/sallayout.hxx
index 3e75b606fd75..ba9cd3bd08e9 100644
--- a/vcl/inc/sallayout.hxx
+++ b/vcl/inc/sallayout.hxx
@@ -32,8 +32,6 @@
 #include  // for typedef sal_UCS4
 #include 
 
-#include "salglyphid.hxx"
-
 #define MAX_FALLBACK 16
 
 
@@ -251,6 +249,8 @@ private:
 boolmbIncomplete;
 };
 
+typedef sal_uInt32 sal_GlyphId;
+
 struct GlyphItem
 {
 int mnFlags;
diff --git a/vcl/inc/unx/fontmanager.hxx b/vcl/inc/unx/fontmanager.hxx
index 8b791722b4a8..8b2c70c25000 100644
--- a/vcl/inc/unx/fontmanager.hxx
+++ b/vcl/inc/unx/fontmanager.hxx
@@ -25,7 +25,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117147] latest update won't open the DOCX documents, crashes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117147

--- Comment #2 from rcdor...@gmail.com ---
Created attachment 141530
  --> https://bugs.documentfoundation.org/attachment.cgi?id=141530=edit
A 1 page punch (to do) list

crashreport.libreoffice.org/stats/crash_details/b6262822-9547-458b-b20f-b55184394fe0

Document That failed to open In Libreoffice attached.
It appears all DOCX documents do not open But crash LO After about 15 to 20
seconds.
Gonna downgrade to a previous version and see if the behaviors the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

CppCheck Report Update

[cppcheck.libreoff...@gmail.com]

A new cppcheck report is available at : 
http://dev-builds.libreoffice.org/cppcheck_reports/master/


Note:
The script generating this report was run at :
2018-22-04 02:18:43 with user buildslave at host vm140 as 
/home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s 
/home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w 
/home/buildslave/tmp/www

It can be found and improved here:

https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=cppcheck/cppcheck-report.sh


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 2 commits - extensions/source sc/source solenv/gbuild solenv/inc svtools/source

[Matthias Seidel]

 extensions/source/update/check/updatecheckconfig.hxx |4 ++--
 sc/source/ui/miscdlgs/retypepassdlg.src  |2 +-
 solenv/gbuild/platform/freebsd.mk|7 +++
 solenv/inc/unxfbsd.mk|7 ++-
 svtools/source/java/javaerror.src|2 +-
 5 files changed, 17 insertions(+), 5 deletions(-)

New commits:
commit 2549527d994cd3747a35ca51781f5fb79bb5b9c6
Author: Matthias Seidel 
Date:   Sun Apr 22 00:00:24 2018 +

Fixed typos, removed whitespace

diff --git a/extensions/source/update/check/updatecheckconfig.hxx 
b/extensions/source/update/check/updatecheckconfig.hxx
index 27262b2cb0cc..b5b311ada4da 100755
--- a/extensions/source/update/check/updatecheckconfig.hxx
+++ b/extensions/source/update/check/updatecheckconfig.hxx
@@ -80,8 +80,8 @@ private:
 
 
 /* This class implements the non published UNO service 
com.sun.star.setup.UpdateCheckConfig,
- * which primary use is to be able to track changes done in the Toos -> 
Options page of this
- * component, as this is not supported by the OOo configuration for extendable 
groups.
+ * which primary use is to be able to track changes done in the Tools -> 
Options page of this
+ * component, as this is not supported by the AOO configuration for extendable 
groups.
  */
 
 class UpdateCheckConfig : public ::cppu::WeakImplHelper3<
diff --git a/sc/source/ui/miscdlgs/retypepassdlg.src 
b/sc/source/ui/miscdlgs/retypepassdlg.src
index daba4b3ede34..9717acaca5b4 100644
--- a/sc/source/ui/miscdlgs/retypepassdlg.src
+++ b/sc/source/ui/miscdlgs/retypepassdlg.src
@@ -58,7 +58,7 @@ ModalDialog RID_SCDLG_RETYPEPASS
 
 WordBreak = TRUE ;
 
-Text [ en-US ] = "The document you are about to export has one or more 
protected items with password that cannot be exported.  Please re-type your 
password to be able to export your document." ;
+Text [ en-US ] = "The document you are about to export has one or more 
protected items with password that cannot be exported. Please re-type your 
password to be able to export your document." ;
 };
 
 FixedLine FL_DOCUMENT
diff --git a/svtools/source/java/javaerror.src 
b/svtools/source/java/javaerror.src
index ec24338661f0..3a2a118ab522 100644
--- a/svtools/source/java/javaerror.src
+++ b/svtools/source/java/javaerror.src
@@ -48,7 +48,7 @@ ErrorBox ERRORBOX_JVMCREATIONFAILED
 {
 Buttons = WB_OK;
 DefButton = WB_DEF_OK ;
-Message[ en-US ] = "%PRODUCTNAME requires a Java runtime environment (JRE) 
to perform this task. The selected JRE is defective. Please select another 
version or install a new JRE and select  it under Tools - Options - 
%PRODUCTNAME - Java.";
+Message[ en-US ] = "%PRODUCTNAME requires a Java runtime environment (JRE) 
to perform this task. The selected JRE is defective. Please select another 
version or install a new JRE and select it under Tools - Options - %PRODUCTNAME 
- Java.";
 };
 
 ErrorBox ERRORBOX_RESTARTREQUIRED
commit 00df62bded7abff051b3defcc56ad0731693c8cd
Author: Don Lewis 
Date:   Sat Apr 21 23:17:08 2018 +

Unbreak build on FreeBSD with clang 6.0 and newer.  Clang 6 changed

the its default C++ standard from C++98 to C++14 and our old code
is not prepared for that.  Avoid the problem by adding the -std=gnu++98
compiler flag.

Add the -fstack-protector compiler flag on FreeBSD INTEL and X86_64.

diff --git a/solenv/gbuild/platform/freebsd.mk 
b/solenv/gbuild/platform/freebsd.mk
index 5f4bc943186e..0148fc23fe57 100644
--- a/solenv/gbuild/platform/freebsd.mk
+++ b/solenv/gbuild/platform/freebsd.mk
@@ -92,6 +92,7 @@ gb_CXXFLAGS := \
-fno-use-cxa-atexit \
-fvisibility-inlines-hidden \
-fvisibility=hidden \
+   -std=gnu++98 \
-pipe
 ifeq ($(COM),CLANG)
 gb_CXXFLAGS += -DHAVE_STL_INCLUDE_PATH
@@ -142,6 +143,12 @@ gb_LinkTarget_LDFLAGS += \
 
 endif
 
+ifneq ($(filter $(CPUNAME),INTEL X86_64),)
+gb_CFLAGS += -fstack-protector
+gb_CXXFLAGS += -fstack-protector
+gb_LinkTarget_LDFLAGS += -fstack-protector
+endif
+
 ifeq ($(gb_DEBUGLEVEL),2)
 gb_COMPILEROPTFLAGS := -O0
 gb_COMPILEROPT1FLAGS := -O0
diff --git a/solenv/inc/unxfbsd.mk b/solenv/inc/unxfbsd.mk
index baa01f5ba4bb..92db30a813d4 100644
--- a/solenv/inc/unxfbsd.mk
+++ b/solenv/inc/unxfbsd.mk
@@ -105,11 +105,16 @@ CFLAGSEXCEPTIONS=-fexceptions -fno-enforce-eh-specs
 CFLAGS_NO_EXCEPTIONS=-fno-exceptions
 
 # -fpermissive should be removed as soon as possible
-CFLAGSCXX= -pipe $(ARCH_FLAGS) 
+CFLAGSCXX= -pipe $(ARCH_FLAGS) -std=gnu++98
 .IF "$(HAVE_GCC_VISIBILITY_FEATURE)" == "TRUE"
 CFLAGSCXX += -fvisibility-inlines-hidden
 .ENDIF # "$(HAVE_GCC_VISIBILITY_FEATURE)" == "TRUE"
 
+.IF "$(CPUNAME)" == "INTEL" || "$(CPUNAME)" == "X86_64"
+CFLAGSCC += -fstack-protector
+CFLAGSCXX += -fstack-protector
+.ENDIF
+
 # Compiler flags for compiling static object in multi threaded environment 
with graphical user interface
 

[Libreoffice-bugs] [Bug 108582] using nvda screen reader activating screen review in libreoffice 5.3 nvda reads dialog boxes and messages of libreoffice like one combine word!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108582

--- Comment #18 from V Stuart Foote  ---
(In reply to V Stuart Foote from comment #17)
> (In reply to zahra from comment #16)
> > 
> > but i am sure that i asked this problem in nvda user maling list and someone
> > confirms this problem in libreoffice 6.0!

> 
> No, I follow NVDA user and dev ML and of course LibreOffice, and this was
> not reproduced that I recall. 

I would not call the responses by one NVDA user in
https://nvda.groups.io/g/nvda/topic/12628487#35965 an energetic or well scoped
confirmation...

Rather, with Windows 10 Pro 64-bit en-US (ver 1709) with NVDA 2017.2, 2017.3,
2018.1.1. in Object navigation mode (NVDA key + F7) from the number pad the
Numpad 4 & 6 give clear by word break sounding, the numpad 1 & 3 give clear by
character sounding. And the numpad 7 & 9 give by line sounding--though in the
About -> Help dialog, the multiple lines of the description are read--with
audible breaks at word boundries. In other words it sounds correctly.

So this really is unconfirmed and works for me.

=-=-=

As you seem stuck working on Windows XP, here are links to the EOL final
releases:

5.2.7.2 --
http://downloadarchive.documentfoundation.org/libreoffice/old/5.2.7.2/win/x86/

5.3.7.2 --
http://downloadarchive.documentfoundation.org/libreoffice/old/5.3.7.2/win/x86/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82009] PIVOTTABLE: Black color on fields of Pivot Table Layout window (Mac OS X only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82009

eisa01  changed:

   What|Removed |Added

 Blocks||42082


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=42082
[Bug 42082] [META] Make LibreOffice shine and glow on OS X
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on OS X

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=42082

eisa01  changed:

   What|Removed |Added

 Depends on||82009


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=82009
[Bug 82009] PIVOTTABLE: Black color on fields of Pivot Table Layout window (Mac
OS X only)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108025] Kerning problem for glyph with applied OpenType Feature

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108025

LibreTraining  changed:

   What|Removed |Added

 CC||libretraining.tutorials@gma
   ||il.com

--- Comment #5 from LibreTraining  ---
Created attachment 141529
  --> https://bugs.documentfoundation.org/attachment.cgi?id=141529=edit
Insert Special Character as Workaround - Does Not Work

I assumed directly inserting the character should work as a workaround because
that would still be the same font.
It did not work.

This appears to point to a larger OpenType kerning issue.

The attached image shows tests in LibreOffice and other applications.
The alternate A character has been inserted directly.
Some applications do the kerning right, some do it wrong.

LibreOffice 6.0.3.2 - Wrong
Word 2016 - Wrong
InDesign 2018 - Right
Scribus 1.5.4 SVN - Wrong
GIMP 2.8 - Right
Inkscape 9.92.2 - Right
FontCreator - Right

FontCreator does not show a specific kerning pair(s) for that alternate
character.
It appears it is coming from the class.

It appears that GIMP, Inkscape, and InDesign read this properly and kern the
characters properly.

Should I enter this in the tracker as a separate issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117131] Double Line Formating Has Changed After Updating To v5.4.6.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117131

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INSUFFICIENTDATA

--- Comment #3 from V Stuart Foote  ---
(In reply to rayisfun from comment #2)
> Sadly, I have now uninstalled LibreOffice because I can't rely on it to work
> reliably. I'm now using Apache OpenOffice which opens my document correctly.
> I'll try another version of LibreOffice sometime in the future if/when this
> bug is fixed.

OK, good luck then. We'll be here...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117148] FIREBIRD allows no edit for table with unique index, but no primary key, contrary to message

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117148

--- Comment #2 from Drew Jensen  ---
Just now using the 6.0 dev build the GUI controls work, or in this case do not
work, similarly with either hsql or firebird sdbc. 

The GUI controls do not update tables without a primary key.

If IIRC the need for a unique key is for the API (ie. singleselectqueryanalyser
service ) and I would suppose that would be true for hsql or firebird. I didn't
try that with a macro just now against either engine to check. SQL insert
statement in the SQL window works with either engine and I was AR enough to do
that just now and in both.

So the GUI stuff, looks to me, to be working as expected but maybe problems
lower down?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source

[Khaled Hosny]

 vcl/source/gdi/CommonSalLayout.cxx |   11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

New commits:
commit 63a4ecc3881596a448d47f564c722ad944ff7e67
Author: Khaled Hosny 
Date:   Sat Apr 21 18:39:30 2018 +0200

tdf#86399 Correctly set cluster start for RTL runs

A followup for the fix in b1030f75d3e47719ca63ec518f1da75196bead1a (from
2015) that didn’t work for Arabic because we were setting cluster start
for RTL runs incorrectly.

I’ve been suffering from this for so long but too lazy to debug it,
until I saw this pace of code by pure chance and it looked dubious,
finding where this flag is used and then seeing the comment referring to
tdf#86399, then WOW I know what is going on!

Change-Id: Ib7850e5a90ed3184738e995885f7f8b459ea2bb9
Reviewed-on: https://gerrit.libreoffice.org/53261
Tested-by: Jenkins 
Reviewed-by: Khaled Hosny 

diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index 463eb255c1dc..c455475ba53d 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -695,6 +695,7 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs)
 int32_t nGlyphIndex = pHbGlyphInfos[i].codepoint;
 int32_t nCharPos = pHbGlyphInfos[i].cluster;
 int32_t nCharCount = 0;
+bool bInCluster = false;
 
 // Find the number of characters that make up this glyph.
 if (!bRightToLeft)
@@ -702,7 +703,10 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs)
 // If the cluster is the same as previous glyph, then this
 // already consumed, skip.
 if (i > 0 && pHbGlyphInfos[i].cluster == pHbGlyphInfos[i - 
1].cluster)
+{
 nCharCount = 0;
+bInCluster = true;
+}
 else
 {
 // Find the next glyph with a different cluster, or the
@@ -722,7 +726,10 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs)
 // If the cluster is the same as previous glyph, then this
 // will be consumed later, skip.
 if (i < nRunGlyphCount - 1 && pHbGlyphInfos[i].cluster == 
pHbGlyphInfos[i + 1].cluster)
+{
 nCharCount = 0;
+bInCluster = true;
+}
 else
 {
 // Find the previous glyph with a different cluster, or
@@ -746,10 +753,6 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs)
 continue;
 }
 
-bool bInCluster = false;
-if (i > 0 && pHbGlyphInfos[i].cluster == pHbGlyphInfos[i - 
1].cluster)
-bInCluster = true;
-
 long nGlyphFlags = 0;
 if (bRightToLeft)
 nGlyphFlags |= GlyphItem::IS_RTL_GLYPH;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 86399] find and replace dialogue - composed characters do not display properly - sometimes hidden completely

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86399

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:4.5.0 target:4.4.3   |target:4.5.0 target:4.4.3
   |target:4.3.7|target:4.3.7 target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86399] find and replace dialogue - composed characters do not display properly - sometimes hidden completely

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86399

--- Comment #17 from Commit Notification 
 ---
Khaled Hosny committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=63a4ecc3881596a448d47f564c722ad944ff7e67

tdf#86399 Correctly set cluster start for RTL runs

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108582] using nvda screen reader activating screen review in libreoffice 5.3 nvda reads dialog boxes and messages of libreoffice like one combine word!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108582

V Stuart Foote  changed:

   What|Removed |Added

 CC||quen...@nvaccess.org

--- Comment #17 from V Stuart Foote  ---
(In reply to zahra from comment #16)
> 
> but i am sure that i asked this problem in nvda user maling list and someone
> confirms this problem in libreoffice 6.0!
> why invalid?
> its a new bug which introducing harfbuzz made for nvda users!
> it does not depend on my windows, i am sure that i used remote control
> program and tested in the system of one person who has windows ten and
> observed this issue!
> i tested with libreoffice 5.3.0.3 remotely, but on that time, i did not know
> about harfbuzz and how to disable it!
> so, my report is not specific for one windows version and specific version
> of nvda!
> its one of the bugs that introducing harfbuzz made and i did not find any
> solution for resolving this issue except disabling harfbuzz as i mentioned
> that today i learned from your comment!
> why khaled removed the option for disabling harfbuzz in 5.4?
> even if libreoffice 6.0, did not support xp, i never used it, because of not
> possible to read dialogs and messages in screen review!

No, I follow NVDA user and dev ML and of course LibreOffice, and this was not
reproduced that I recall. And as you never provided a WinDbg stack trace or
link to Libreoffice crashreporter dumps for LibreOffice, nor NVDA verbose
logging catching the "crash" it is undocumented and not confirmed.

Invalid because even if it were confirmed--it has not been--it could not be
fixed as *both* software projects have moved on.  NVDA 2017.3 and 2018.1.1 or
next 2018.2 on Windows systems with GPU driver support do not have this issue--
and conflating in the HarfBuzz source is not reasonable.

It is equally likely the issue is with NVDA and the Symphony/IAccessible2
module which has some annoying locale detection language change behavior--that
HarfBuzz handling could have complicated, but with out logging its mute.

Otherwise please be aware that at the 5.4 release with a complete transition to
HarfBuzz based rendering cross platform--the legacy GDI/DirectWrite rendering
on Windows (the so called "Old" layout engine) was completely removed from the
code base. It is gone, and will not be brought back.

Making use of HarfBuzz, Windows builds of 5.4, 6.0 and current master have two
rendering modes--legacy GDI for the "Default" rendering (by CPU or Hardware)
and Direct3D DirectWrite with OpenGL rendering. Moving forward we will be
further reducing the use of legacy GDI handling again moving Direct3D
DirectWrite forward (or possibly implementing FreeType) for text rendering.

Sorry not to be cruel, but that is reality--up to you to move on.

@Quintin, do you have any perspective from the NVAccess side?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117125] Libreoffice stores same png multiple times

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117125

Telesto  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117131] Double Line Formating Has Changed After Updating To v5.4.6.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117131

--- Comment #2 from rayis...@hotmail.com ---
Thanks for your help. I tried your suggestion of proportional spacing but at
200% the spacing remains unaltered. A lower percentage reduces the spacing. I
found a fix by changing the line spacing to "Leading" at 0.70cm. The document
reverts back to 456 pages as normal.

I have used LibreOffice for many years. This document was created in it and for
over a year, up until v5.4.4, worked perfectly. A friend, who is helping me
with this document, is also unclear why this problem began after the v5.4.6.2
update. If, as you say, the font is at fault then why did this problem not
occur with v5.4.4? I don't understand why this document loads correctly with
456 pages and then a couple of seconds later shrinks down to 362 pages. For
some reason LibreOffice is re-formatting the document after it has loaded
correctly.

Sadly, I have now uninstalled LibreOffice because I can't rely on it to work
reliably. I'm now using Apache OpenOffice which opens my document correctly.
I'll try another version of LibreOffice sometime in the future if/when this bug
is fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: How to make a locale available for CTL text

[Khaled Hosny]

On Fri, Mar 30, 2018 at 01:59:51PM +0200, Khaled Hosny wrote:
> Hi,
> 
> I want to set a text in Malay [1] but using the Arabic script (AKA Jawi
> [2]), but it seems that Malay is only allowed for “Western” text and not
> “CTL” and free-form language tags are not allowed in CTL as well. Do I
> need to add a new locale or do something else? Any reason why free-form
> language tags are not allowed for CTL text?

I found https://bugs.documentfoundation.org/show_bug.cgi?id=81714 which
answers the last question somehow (though it is not clear what is
exactly needed). My main question about supporting Jawi is still
unanswered.

Regards,
Khaled
 
> 1. https://en.wikipedia.org/wiki/Malaysian_language
> 2. https://en.wikipedia.org/wiki/Jawi_alphabet
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 108582] using nvda screen reader activating screen review in libreoffice 5.3 nvda reads dialog boxes and messages of libreoffice like one combine word!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108582

--- Comment #16 from zahra  ---
(In reply to V Stuart Foote from comment #15)
> @Zahra, sorry. But going to go ahead and close this invalid.
> 
> When you eventually move off Windows XP to a current Windows platform, or
> adopt a Linux OS and can use Orca you'll be better served.
> 
> For now, LibreOffice 5.4 and 6.0 with NVDA 2017.3, or 2018.2 with windows 10
> correctly sound all elements of the dialogs exposed to screen review. We
> have no issue with the words being run together with either OpenGL rendering
> or default GDI rendering being run together.
> 
> If 5.3.7.2 and NVDA 2017.3 work well for you (having disabled Harfbuzz based
> rendering) great. 5.4 builds are the end of the line for you as support for
> Windows XP, and Vista have been dropped at 6.0.
>  
> There is no going back from the LibreOffice projects perspective, and as you
> know NVAccess and the NVDA project have ended support for Windows XP at
> 2017.3 release.

but i am sure that i asked this problem in nvda user maling list and someone
confirms this problem in libreoffice 6.0!
why invalid?
its a new bug which introducing harfbuzz made for nvda users!
it does not depend on my windows, i am sure that i used remote control program
and tested in the system of one person who has windows ten and observed this
issue!
i tested with libreoffice 5.3.0.3 remotely, but on that time, i did not know
about harfbuzz and how to disable it!
so, my report is not specific for one windows version and specific version of
nvda!
its one of the bugs that introducing harfbuzz made and i did not find any
solution for resolving this issue except disabling harfbuzz as i mentioned that
today i learned from your comment!
why khaled removed the option for disabling harfbuzz in 5.4?
even if libreoffice 6.0, did not support xp, i never used it, because of not
possible to read dialogs and messages in screen review!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97313] Freezes using NVDA screen reader when opening a file by using control+o or in the file menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97313

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #24 from V Stuart Foote  ---
Closing this out as Wont Fix. 

This issue lacks reliable STR with other NVDA users unable to reproduce--we
have never been able to review a LibreOffice stack trace/crash report or an
NVDA verbose log.

OPs Windows XP system configuration does not permit testing with current dev
versions and the LibreOffice and NVDA builds involved are EOL.

OP is advised to migrate to supported OS and Assistive technology tools that
stand some chance of providing functional a11y

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 60251] [META] ACCESSIBILITY: Tracking Windows OS accessibility and AT issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=60251
Bug 60251 depends on bug 97313, which changed state.

Bug 97313 Summary: Freezes using NVDA screen reader when opening a file by 
using control+o or in the file menu
https://bugs.documentfoundation.org/show_bug.cgi?id=97313

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117092] Migration to Firebird fails for a simple table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117092

--- Comment #16 from Gerhard Weydt  ---
(In reply to Julien Nabet from comment #14)
> (In reply to Gerhard Weydt from comment #13)
> ...
> I wasn't talking about LO but Firebird version.
> Last master sources of LO use Firebird 3.0.0 whereas current Firebird
> version is 3.0.3
> The problem is to be able to build Firebird 3.0.3 in LO master sources for
> every env: Linux, Windows and MacOS.

As I said, the use of multiple columns is already described in the manual for
Firebird 2.5, so I don't think it probable that installing Firebird 3.0.3
instead of 3.0.0 can solve the problem. It is much more probable that the
reason must be sought within LibO's connection and handling of Firebird.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

[Johnny_M]

 sc/source/filter/lotus/op.cxx |   28 ++--
 1 file changed, 14 insertions(+), 14 deletions(-)

New commits:
commit 5289441ffa227f5f358ca4dc28df416be922aa66
Author: Johnny_M 
Date:   Sat Apr 21 12:53:08 2018 +0200

Translate German variable names

Puffer -> Buffer in Lotus filter

Change-Id: If6d5190c7bc2f884083a2a47b6bd665b3f95b3b0
Reviewed-on: https://gerrit.libreoffice.org/53250
Tested-by: Jenkins 
Reviewed-by: Khaled Hosny 

diff --git a/sc/source/filter/lotus/op.cxx b/sc/source/filter/lotus/op.cxx
index e78419726141..7dec5cfbd0d1 100644
--- a/sc/source/filter/lotus/op.cxx
+++ b/sc/source/filter/lotus/op.cxx
@@ -196,9 +196,9 @@ void OP_NamedRange(LotusContext& rContext, SvStream& r, 
sal_uInt16 /*n*/)
 // POST: don't save for invalid coordinates
 sal_uInt16  nColSt, nRowSt, nColEnd, nRowEnd;
 
-sal_Char cPuffer[ 16+1 ];
-r.ReadBytes(cPuffer, 16);
-cPuffer[ 16 ] = 0;
+sal_Char cBuffer[ 16+1 ];
+r.ReadBytes(cBuffer, 16);
+cBuffer[ 16 ] = 0;
 
 r.ReadUInt16( nColSt ).ReadUInt16( nRowSt ).ReadUInt16( nColEnd 
).ReadUInt16( nRowEnd );
 
@@ -212,14 +212,14 @@ void OP_NamedRange(LotusContext& rContext, SvStream& r, 
sal_uInt16 /*n*/)
 pRange = new LotusRange( static_cast (nColSt), 
static_cast (nRowSt),
 static_cast (nColEnd), static_cast (nRowEnd) 
);
 
-sal_Char cBuf[sizeof(cPuffer)+1];
-if( rtl::isAsciiDigit( static_cast(*cPuffer) ) )
+sal_Char cBuf[sizeof(cBuffer)+1];
+if( rtl::isAsciiDigit( static_cast(*cBuffer) ) )
 {  // first char in name is a number -> prepend 'A'
 cBuf[0] = 'A';
-strcpy( cBuf + 1, cPuffer );   // #100211# - checked
+strcpy( cBuf + 1, cBuffer );   // #100211# - checked
 }
 else
-strcpy( cBuf, cPuffer );   // #100211# - checked
+strcpy( cBuf, cBuffer );   // #100211# - checked
 
 OUString  aTmp( cBuf, strlen(cBuf), rContext.pLotusRoot->eCharsetQ 
);
 
@@ -235,9 +235,9 @@ void OP_SymphNamedRange(LotusContext& rContext, SvStream& 
r, sal_uInt16 /*n*/)
 sal_uInt16  nColSt, nRowSt, nColEnd, nRowEnd;
 sal_uInt8   nType;
 
-sal_Char cPuffer[ 16+1 ];
-r.ReadBytes(cPuffer, 16);
-cPuffer[ 16 ] = 0;
+sal_Char cBuffer[ 16+1 ];
+r.ReadBytes(cBuffer, 16);
+cBuffer[ 16 ] = 0;
 
 r.ReadUInt16( nColSt ).ReadUInt16( nRowSt ).ReadUInt16( nColEnd 
).ReadUInt16( nRowEnd ).ReadUChar( nType );
 
@@ -251,14 +251,14 @@ void OP_SymphNamedRange(LotusContext& rContext, SvStream& 
r, sal_uInt16 /*n*/)
 pRange = new LotusRange( static_cast (nColSt), 
static_cast (nRowSt),
 static_cast (nColEnd), static_cast (nRowEnd) 
);
 
-sal_Char cBuf[sizeof(cPuffer)+1];
-if( rtl::isAsciiDigit( static_cast(*cPuffer) ) )
+sal_Char cBuf[sizeof(cBuffer)+1];
+if( rtl::isAsciiDigit( static_cast(*cBuffer) ) )
 {  // first char in name is a number -> prepend 'A'
 cBuf[0] = 'A';
-strcpy( cBuf + 1, cPuffer );   // #100211# - checked
+strcpy( cBuf + 1, cBuffer );   // #100211# - checked
 }
 else
-strcpy( cBuf, cPuffer );   // #100211# - checked
+strcpy( cBuf, cBuffer );   // #100211# - checked
 
 OUString  aTmp( cBuf, strlen(cBuf), rContext.pLotusRoot->eCharsetQ );
 aTmp = ScfTools::ConvertToScDefinedName( aTmp );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 60251] [META] ACCESSIBILITY: Tracking Windows OS accessibility and AT issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=60251
Bug 60251 depends on bug 108582, which changed state.

Bug 108582 Summary: using nvda screen reader activating screen review in 
libreoffice 5.3 nvda reads dialog boxes and messages of libreoffice like one 
combine word!
https://bugs.documentfoundation.org/show_bug.cgi?id=108582

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108582] using nvda screen reader activating screen review in libreoffice 5.3 nvda reads dialog boxes and messages of libreoffice like one combine word!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108582

V Stuart Foote  changed:

   What|Removed |Added

   Keywords|implementationError |
 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=89 |
   |870 |
 Resolution|--- |INVALID

--- Comment #15 from V Stuart Foote  ---
@Zahra, sorry. But going to go ahead and close this invalid.

When you eventually move off Windows XP to a current Windows platform, or adopt
a Linux OS and can use Orca you'll be better served.

For now, LibreOffice 5.4 and 6.0 with NVDA 2017.3, or 2018.2 with windows 10
correctly sound all elements of the dialogs exposed to screen review. We have
no issue with the words being run together with either OpenGL rendering or
default GDI rendering being run together.

If 5.3.7.2 and NVDA 2017.3 work well for you (having disabled Harfbuzz based
rendering) great. 5.4 builds are the end of the line for you as support for
Windows XP, and Vista have been dropped at 6.0.

There is no going back from the LibreOffice projects perspective, and as you
know NVAccess and the NVDA project have ended support for Windows XP at 2017.3
release.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117092] Migration to Firebird fails for a simple table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117092

--- Comment #15 from Gerhard Weydt  ---
referring to comment 10:
I created a new bug 117048 for the problem that t is not possible to edit data
if the table has only a unique key, contrary to the statement on save that
exactly this is allowed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117148] FIREBIRD allows no edit for table with unique index, but no primary key, contrary to message

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117148

Gerhard Weydt  changed:

   What|Removed |Added

Version|5.3.7.2 release |unspecified

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117148] FIREBIRD allows no edit for table with unique index, but no primary key, contrary to message

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117148

--- Comment #1 from Gerhard Weydt  ---
Created attachment 141528
  --> https://bugs.documentfoundation.org/attachment.cgi?id=141528=edit
TablkeOnlyUniqueIndex

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117148] New: FIREBIRD allows no edit for table with unique index, but no primary key, contrary to message

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117148

Bug ID: 117148
   Summary: FIREBIRD allows no edit for table with unique index,
but no primary key, contrary to message
   Product: LibreOffice
   Version: 5.3.7.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gerhard.we...@t-online.de

When you create a table in Base with Firebird database and save it without
having created a primary key, you get the following dialog:

  No primary key

  A unique index or primary key is required for data record identification in
this database.
  You can only enter data into this table when one of these two structural
conditions has been met.

  Should a primary key be created now?

But, following the alternative stated and creating a unique index only leaves
the table not editable. Only if a primary key is added, it becomes editable.

Steps to reproduce (or open attachment TableOnlyUniqueIndex):
1. create a new database document with Firebird database engine
2. create a table using Design View, with some columns
3. save the table; you will get the message shown above
4. reject the creation of a primary key by answering: No
5. choose Tools -> Index design or its symbol
6. create a unique index for the first two columns and save it
7. close the index and table dialogs
8. save the database document
9. open the table for editing

Result: the table is not editable
Expected result: the table should be editable, as stated explicitly in the
message shown above.

It doesn't help to close the document and to open it gain, the situation
remains unchanged.

To show that editability really depends from a primary key:
10. open the table definition for editing
11. create a new column or select one of the columns not used for the unique
index
12: right-click the header of the row describing this column and choose
"Primary Key"
13. save the table definition

After that the table can be edited.

Remark: for HSQLDB primary keys were always mandatory, maybe the same test
applies now to firebird. But for HSQLDB there is no message that you can use a
unique index instead!

This issue is connected with bug 117092, saying (despite its title, because the
fact was only discovered after the bug had been created) that it is not
possible to create a primary key with more than one column.
In the present state one would have to create
1. a unique index with the columns needed
2. a primary key with one column
where one index could be sufficient.

tested with:
Version: 6.1.0.0.alpha0+
Build ID: 9c4eaa7b81a40d97fe49b85272b40bfeaaf44f86
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-04-16_03:31:36
Locale: de-DE (de_DE); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117092] Migration to Firebird fails for a simple table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117092

--- Comment #14 from Julien Nabet  ---
(In reply to Gerhard Weydt from comment #13)
> ...
> Julien: if you do not want to create a new bug report, I will do it, but I
> will be waiting some time, in case Lionel sends a comment.

I wasn't talking about LO but Firebird version.
Last master sources of LO use Firebird 3.0.0 whereas current Firebird version
is 3.0.3
The problem is to be able to build Firebird 3.0.3 in LO master sources for
every env: Linux, Windows and MacOS.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117092] Migration to Firebird fails for a simple table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117092

--- Comment #13 from Gerhard Weydt  ---
I used the latest version available at the time of download, probably April
17th.

Version: 6.1.0.0.alpha0+
Build ID: 9c4eaa7b81a40d97fe49b85272b40bfeaaf44f86
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-04-16_03:31:36
Locale: de-DE (de_DE); Calc: group

Julien: if you do not want to create a new bug report, I will do it, but I will
be waiting some time, in case Lionel sends a comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105584] [META] Calc image bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105584
Bug 105584 depends on bug 42705, which changed state.

Bug 42705 Summary: Graphics Anchored to Cell Do Not Move With Data When Sorted, 
'Protect Position' Set or Not, 'Link' or Not
https://bugs.documentfoundation.org/show_bug.cgi?id=42705

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42705] Graphics Anchored to Cell Do Not Move With Data When Sorted, ' Protect Position' Set or Not, 'Link' or Not

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=42705

u2nBz  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #24 from u2nBz  ---
EDIT:

Just checked further down that bug page (way long) and find the fix is pushed
out to 6.1.

Only finding 6.0.3 currently available so can not verify. However, trusting
this will be resolved in the 6.1 release, marking so. If still present in 6.1
though, "I'll be back."

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117045] When ccache's cache limit is removed autogen print it' s less than 5GB

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117045

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||jbfa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Jean-Baptiste Faure  ---
Confirmed. I get the following warning message:
* WARNING : ccache's cache size is less than 1GB using it is
counter-productive: auto-ccache detection disabled

Status set to NEW.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105584] [META] Calc image bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105584
Bug 105584 depends on bug 42705, which changed state.

Bug 42705 Summary: Graphics Anchored to Cell Do Not Move With Data When Sorted, 
'Protect Position' Set or Not, 'Link' or Not
https://bugs.documentfoundation.org/show_bug.cgi?id=42705

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42705] Graphics Anchored to Cell Do Not Move With Data When Sorted, ' Protect Position' Set or Not, 'Link' or Not

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=42705

u2nBz  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---

--- Comment #23 from u2nBz  ---
@Regina Henschel, @Samuel Mehrbrodt (CIB), and @ Xisco Faulí;

Please note this bug:

 - Is NOT a duplicate of 98931 (which it predates anyway)

 - Is still present in the latest release, 5.3.6.1

 - Still needs to be fixed.

Before making any changes here, please download the example Calc spreadsheet
created by @d.r...@freenet.de and do a manual sort to see that this bug is
still present. And it still has nothing to do with bug 98931.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117147] latest update won't open the DOCX documents, crashes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117147

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
Would it be possible you attach a document so we can give a try?
Of course, remove any confidential/private part from it since it'll be
automatically made public.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117092] Migration to Firebird fails for a simple table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117092

Julien Nabet  changed:

   What|Removed |Added

 CC||lio...@mamane.lu

--- Comment #12 from Julien Nabet  ---
(In reply to Gerhard Weydt from comment #11)
> In reply to comment #9 by Julien:
> ...
> I suggest you create a new bug that Firebird does not allow primary keys
> with more than one column, in contrast to the documentation and also to
> HSQLDB. This bug here could perhaps be referenced, and a comment should be
> added that this is no migration issue, but an issue of Firebird
> implementation in Base.
> ...

I know very few Firebird process and perhaps it's already fixed in the current
version.

Lionel: thought you might be interested in this one or have some thoughts here,
so I put you in cc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117127] error when reading the value of a variable in the IDE

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117127

--- Comment #2 from emilio  ---

sorry, the name of the procedure is "Sub AnadirFilaTablaRF()"



I also report another error, if I declare the "LeyTConcepto()" array, (1409
elements), exceptions occur. To solve it, I have to declare the array in two
parts (LeyTConceptotemporal1(),  and LeyTConceptotemporal2()). 

unexperienced exceptions occur and the values ​​contained in the matrix are
false/error, This occurs when declaring the matrix with the 1409 elements.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117092] Migration to Firebird fails for a simple table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117092

--- Comment #11 from Gerhard Weydt  ---
In reply to comment #9 by Julien:
According to the Firebird documentation for version 2.5 (!) setting a primary
key with more than one column is definitely possible. And the generated syntax
is also correct.
I suggest you create a new bug that Firebird does not allow primary keys with
more than one column, in contrast to the documentation and also to HSQLDB. This
bug here could perhaps be referenced, and a comment should be added that this
is no migration issue, but an issue of Firebird implementation in Base.
I think that's better than renaming this bug, because one has to read 8
comments before one gets to the point.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108582] using nvda screen reader activating screen review in libreoffice 5.3 nvda reads dialog boxes and messages of libreoffice like one combine word!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108582

--- Comment #14 from Buovjaga  ---
(In reply to zahra from comment #13)
> can someone please confirm this bug?

I tried again, but I could only make it read the "Version" line, if I moved the
mouse over it. No other lines were read.
For the crash recovery, mouse hovering made it read the text.
With my Truly Ergonomic keyboard, numpad only exists using a modifier key. So I
cannot "turn numlock off" and use the keys because then they are just normal
keys (some numbers and letters).

Previously I had tried to reproduce on another machine, which did have a
numpad.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117147] New: latest update won't open the DOCX documents, crashes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117147

Bug ID: 117147
   Summary: latest update won't open the DOCX documents, crashes
   Product: LibreOffice
   Version: 6.0.3.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rcdor...@gmail.com

Just downloaded (04/21/18 11:32 AM) version 6.0.3.2 64-bit.
Before it took about 20 seconds to open 1 page DOCX ()
now it won't open it all and crashes!
useless!
Might as well stay with decrepit Microsoft Office 2016.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117137] FILESAVE: DOCX: file cannot be opened in MSO / numbering lost in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117137

--- Comment #5 from Justin L  ---
confirmed that reverting the identified commit resolves the problem.  
https://gerrit.libreoffice.org/53271 tdf#117137: Revert "DOCX import: don't try
to set grab-gag props as UNO props"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76260] FILEOPEN: extremely slow loading .docx with lots of footnotes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=76260

--- Comment #38 from rcdor...@gmail.com ---
Just upgraded (04/21/18 11:32am) to 6.0.3.2 64-bit and now nothing works
anymore!
Before it took Up to 20 seconds to open a Single page DOCX File.(!!!)
Now nothing happens anymore and it just crashes.
Useless!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108582] using nvda screen reader activating screen review in libreoffice 5.3 nvda reads dialog boxes and messages of libreoffice like one combine word!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108582

--- Comment #13 from zahra  ---
can someone please confirm this bug?
its very annoying for nvda screen reader users, when they read dialogs and
messages with screen review.
why my bug not be new?
i even found the cause of bug and found the solution by the patch of khaled and
comment of stuart and solved it in 5.3.4 as i said!
just see dialogs and messages of libreoffice in new and old TextLayoutEngine to
see the difference!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117071] Allows choose of page size when you create a new drawing in Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117071

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||jbfa...@libreoffice.org

--- Comment #1 from Jean-Baptiste Faure  ---
If you want to change the page size of your document, you can do that with a
single click if you are use the sidebar.

A new dialog is useless for me.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97313] Freezes using NVDA screen reader when opening a file by using control+o or in the file menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97313

zahra  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97313] Freezes using NVDA screen reader when opening a file by using control+o or in the file menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97313

--- Comment #23 from zahra  ---
(In reply to QA Administrators from comment #22)
> Dear Bug Submitter,
> 
> This bug has been in NEEDINFO status with no change for at least
> 6 months. Please provide the requested information as soon as
> possible and mark the bug as UNCONFIRMED. Due to regular bug
> tracker maintenance, if the bug is still in NEEDINFO status with
> no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
> due to lack of needed information.
> 
> For more information about our NEEDINFO policy please read the
> wiki located here:
> https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO
> 
> If you have already provided the requested information, please
> mark the bug as UNCONFIRMED so that the QA team knows that the
> bug is ready to be confirmed.
>  
> Thank you for helping us make LibreOffice even better for everyone!
> 
> Warm Regards,
> QA Team
> 
> MassPing-NeedInfo-Ping-20180404

hi.
i tested with many versions of libreoffice until 5.4.0 and the issue still
persists.
since i use windows xp, installing version 6.0 is not possible for me.
this issue only occur when windows dialog for open and save in libreoffice,
options, general is enabled.
if we use libreoffice dialogs, (as i tested) openning files works as normal
without crash using nvda.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108582] using nvda screen reader activating screen review in libreoffice 5.3 nvda reads dialog boxes and messages of libreoffice like one combine word!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108582

Buovjaga  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108582] using nvda screen reader activating screen review in libreoffice 5.3 nvda reads dialog boxes and messages of libreoffice like one combine word!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108582

zahra  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108582] using nvda screen reader activating screen review in libreoffice 5.3 nvda reads dialog boxes and messages of libreoffice like one combine word!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108582

zahra  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=89
   ||870

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108582] using nvda screen reader activating screen review in libreoffice 5.3 nvda reads dialog boxes and messages of libreoffice like one combine word!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108582

zahra  changed:

   What|Removed |Added

   Keywords|regression  |implementationError

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117137] FILESAVE: DOCX: file cannot be opened in MSO / numbering lost in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117137

Justin L  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108582] using nvda screen reader activating screen review in libreoffice 5.3 nvda reads dialog boxes and messages of libreoffice like one combine word!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108582

--- Comment #12 from zahra  ---
hi again.
by the grace of God,\
finally today i found a solution for my problem.
i write the method that how to resolve problem, but unfortunately it only works
in 5.3, not 5.4 and later!
steps for screen reader users to resolve the issue of reading any message and
dialogs in libreoffice 5.3
1- open libreoffice, (i tested only with writer).
2- press alt+f12 or find the options in the tool menu and activate it.
3- under libreoffice, find advance.
4- between advance settings find expert configuration and activate it.
5- in the edit box, type TextLayoutEngine and press search button.
6- press edit and rename new to old for disabling harfbuzz!
okay, now you can read any dialog box and message using nvda screen reader with
libreoffice 5.3 without any problem!
i tested with the version 5.3.4.2and it worked perfectly.
i am very glad that today i learned expert configuration and i sincerely
appreciate Yousuf Philips, Stuart, and Khaled Hosny that made possible using
libreoffice 5.3 by adding and supporting to add one configuration in expert
configuration to desable harfbuzz!
khaled added one option for disabling and enabling harfbuzz in expert
configurations and
today reading comment of stuart taught me how to enable old engine again in
libreoffice 5.3!
https://bugs.documentfoundation.org/show_bug.cgi?id=89870#c32
but i did not understand whats the reason that this great option is removed in
5.4!
how should nvda users read dialogs in libreoffice 5.4 and later with harfbuzz
enabled?
i sincerely appreciate you again, God bless you all!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117125] Libreoffice stores same png multiple times

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117125

--- Comment #4 from sergio.calleg...@gmail.com ---
File was first obtained with 6.0.3.2.

Then the behavior was replicated with 6.0.4.1

1) opened file
2) opened an empty drawing
3) copied first instance of the png image and pasted to the empty drawing
4) deleted both instances of the png image from the presentation
5) saved
6) verified that both instances were gone from the odp
7) copied back instance from the drawing and adjusted the cropping
8) copied again as a second instance and adjusted the cropping here too
9) saved again
10) verified that once more the odp has two identical instances of the odp.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc vcl/source

[Khaled Hosny]

 vcl/inc/sallayout.hxx  |   13 -
 vcl/source/gdi/CommonSalLayout.cxx |2 +-
 2 files changed, 1 insertion(+), 14 deletions(-)

New commits:
commit b9fde7e7b73c4902a8eb35fab46abd137e36856e
Author: Khaled Hosny 
Date:   Sat Apr 21 16:17:43 2018 +0200

Drop GlyphItem constructor that is used only once

Change-Id: I36aed033ea811daf2dfae89a89cf0ff5fc86b270
Reviewed-on: https://gerrit.libreoffice.org/53257
Tested-by: Jenkins 
Reviewed-by: Khaled Hosny 

diff --git a/vcl/inc/sallayout.hxx b/vcl/inc/sallayout.hxx
index 962f0f6905ac..3e75b606fd75 100644
--- a/vcl/inc/sallayout.hxx
+++ b/vcl/inc/sallayout.hxx
@@ -267,19 +267,6 @@ struct GlyphItem
 int mnFallbackLevel;
 
 public:
-GlyphItem( int nCharPos, sal_GlyphId aGlyphId, const Point& 
rLinearPos,
-long nFlags, int nOrigWidth )
-:   mnFlags(nFlags)
-,   mnCharPos(nCharPos)
-,   mnCharCount(1)
-,   mnOrigWidth(nOrigWidth)
-,   mnNewWidth(nOrigWidth)
-,   mnXOffset(0)
-,   maGlyphId(aGlyphId)
-,   maLinearPos(rLinearPos)
-,   mnFallbackLevel(0)
-{ }
-
 GlyphItem(int nCharPos, int nCharCount, sal_GlyphId aGlyphId, 
const Point& rLinearPos,
 long nFlags, int nOrigWidth, int nXOffset )
 :   mnFlags(nFlags)
diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index e00b21693091..463eb255c1dc 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -975,7 +975,7 @@ void CommonSalLayout::ApplyDXArray(ImplLayoutArgs& rArgs)
 int const nFlags = GlyphItem::IS_IN_CLUSTER | 
GlyphItem::IS_RTL_GLYPH;
 while (nCopies--)
 {
-GlyphItem aKashida(nCharPos, nKashidaIndex, aPos, nFlags, 
nKashidaWidth);
+GlyphItem aKashida(nCharPos, 0, nKashidaIndex, aPos, nFlags, 
nKashidaWidth, 0);
 pGlyphIter = m_GlyphItems.insert(pGlyphIter, aKashida);
 aPos.AdjustX(nKashidaWidth );
 aPos.AdjustX( -nOverlap );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117146] Saving as .csv corrupts unicode characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117146

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |NOTABUG

--- Comment #1 from V Stuart Foote  ---
The save-as export allows selection of the Character set when the "edit filter
settings" box is checked. Otherwise the CSV will be saved with the character
set  in use. Select Unicode (UTF-8) or (UTF-16).

Likewise, on import the character set encoding can be selected, and then a font
selection made in Calc for correct/prefered rendering of the Unicode glyphs.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/inc sw/source

[Mike Kaganski]

 sw/inc/swtable.hxx  |2 +-
 sw/source/core/table/swnewtable.cxx |   13 ++---
 2 files changed, 7 insertions(+), 8 deletions(-)

New commits:
commit 97fe7d5f0eed7d3ef4940f4e7a70a7dd64d2390f
Author: Mike Kaganski 
Date:   Sat Apr 21 11:47:43 2018 +0100

Use unique_ptr

Change-Id: I8fea12c523e07b895c47ee410120549398fc8f37
Reviewed-on: https://gerrit.libreoffice.org/53249
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 
Reviewed-by: Mike Kaganski 

diff --git a/sw/inc/swtable.hxx b/sw/inc/swtable.hxx
index 619d37dd432e..edeb04509d18 100644
--- a/sw/inc/swtable.hxx
+++ b/sw/inc/swtable.hxx
@@ -164,7 +164,7 @@ private:
 bool NewMerge( SwDoc*, const SwSelBoxes&, const SwSelBoxes& rMerged,
SwUndoTableMerge* );
 bool NewSplitRow( SwDoc*, const SwSelBoxes&, sal_uInt16, bool );
-SwBoxSelection* CollectBoxSelection( const SwPaM& rPam ) const;
+std::unique_ptr CollectBoxSelection( const SwPaM& rPam ) 
const;
 void InsertSpannedRow( SwDoc* pDoc, sal_uInt16 nIdx, sal_uInt16 nCnt );
 bool InsertRow_( SwDoc*, const SwSelBoxes&, sal_uInt16 nCnt, bool bBehind 
);
 bool NewInsertCol( SwDoc*, const SwSelBoxes& rBoxes, sal_uInt16 nCnt, bool 
);
diff --git a/sw/source/core/table/swnewtable.cxx 
b/sw/source/core/table/swnewtable.cxx
index e6a9a590187c..96702150011b 100644
--- a/sw/source/core/table/swnewtable.cxx
+++ b/sw/source/core/table/swnewtable.cxx
@@ -41,6 +41,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #ifdef DBG_UTIL
 #define CHECK_TABLE(t) (t).CheckConsistency();
@@ -322,7 +323,7 @@ static void lcl_ChangeRowSpan( const SwTable& rTable, const 
long nDiff,
 and prepares the selected cells for merging
 */
 
-SwBoxSelection* SwTable::CollectBoxSelection( const SwPaM& rPam ) const
+std::unique_ptr SwTable::CollectBoxSelection( const SwPaM& 
rPam ) const
 {
 OSL_ENSURE( m_bNewModel, "Don't call me for old tables" );
 if( m_aLines.empty() )
@@ -370,7 +371,7 @@ SwBoxSelection* SwTable::CollectBoxSelection( const SwPaM& 
rPam ) const
 bool bOkay = true;
 long nMid = ( nMin + nMax ) / 2;
 
-SwBoxSelection* pRet = new SwBoxSelection();
+auto pRet(o3tl::make_unique());
 std::vector< std::pair< SwTableBox*, long > > aNewWidthVector;
 size_t nCheckBottom = nBottom;
 long nLeftSpan = 0;
@@ -560,11 +561,11 @@ SwBoxSelection* SwTable::CollectBoxSelection( const 
SwPaM& rPam ) const
 --nRightSpanCnt;
 pRet->push_back(aBoxes);
 }
-pRet->mnMergeWidth = nMax - nMin;
 if( nCheckBottom > nBottom )
 bOkay = false;
 if( bOkay )
 {
+pRet->mnMergeWidth = nMax - nMin;
 for (auto const& newWidth : aNewWidthVector)
 {
 SwFrameFormat* pFormat = newWidth.first->ClaimFrameFormat();
@@ -573,10 +574,8 @@ SwBoxSelection* SwTable::CollectBoxSelection( const SwPaM& 
rPam ) const
 }
 }
 else
-{
-delete pRet;
-pRet = nullptr;
-}
+pRet.reset();
+
 return pRet;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/qa

[Thorsten Behrens]

 vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx |   15 +++
 1 file changed, 11 insertions(+), 4 deletions(-)

New commits:
commit d2d57d25aa71b71606c2112914831f25279fa279
Author: Thorsten Behrens 
Date:   Sat Apr 21 16:32:43 2018 +0200

Tweak unit test for 1bpp images a bit for robustness

Seems we're suffering gamma correction issue on a number of target
platforms, so let's compare colors a bit more fuzzily.

Fixup for eb5c0ccd47330fc726f4b4f854cf4cc518ac21cd

Change-Id: Ieace78d1054efa6f49d42f1878774604e85c1965
Reviewed-on: https://gerrit.libreoffice.org/53259
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx 
b/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx
index 2ee32a812d55..2f9274ddb7bc 100644
--- a/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx
+++ b/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx
@@ -62,9 +62,12 @@ void BitmapRenderTest::testTdf104141()
 BitmapEx aBitmap = aGraphic.GetBitmapEx();
 pVDev->DrawBitmapEx(Point(20, 20), aBitmap);
 
-// Check drawing resuts: ensure that it contains transparent (green) pixels
+// Check drawing resuts: ensure that it contains transparent
+// (greenish) pixels
 #if !defined MACOSX //TODO: on Mac colors are drifted, so exact compare fails
-CPPUNIT_ASSERT_EQUAL(COL_GREEN, pVDev->GetPixel(Point(21, 21)));
+const Color aColor = pVDev->GetPixel(Point(21, 21));
+CPPUNIT_ASSERT(aColor.GetGreen() > 10 * aColor.GetRed()
+   && aColor.GetGreen() > 10 * aColor.GetBlue());
 #endif
 }
 
@@ -84,9 +87,13 @@ void BitmapRenderTest::testTdf113918()
 BitmapEx aBitmap = aGraphic.GetBitmapEx();
 pVDev->DrawBitmapEx(Point(0, 0), aBitmap);
 
-// Ensure that image is drawn with gray color from palette
+// Ensure that image is drawn with white background color from palette
 CPPUNIT_ASSERT_EQUAL(COL_WHITE, pVDev->GetPixel(Point(21, 21)));
-CPPUNIT_ASSERT_EQUAL(Color(0x979797), pVDev->GetPixel(Point(1298, 1368)));
+
+// Ensure that image is drawn with gray text color from palette
+const Color aColor = pVDev->GetPixel(Point(1298, 1368));
+CPPUNIT_ASSERT(aColor.GetGreen() == aColor.GetRed() && aColor.GetGreen() 
== aColor.GetBlue());
+CPPUNIT_ASSERT(aColor.GetGreen() > 100);
 }
 
 CPPUNIT_TEST_SUITE_REGISTRATION(BitmapRenderTest);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117031] FILEOPEN DOCX: Table is wrongly rendered

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117031

--- Comment #12 from raal  ---
Word 2010 & Word Online - prices are not visible. I propose close the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117031] FILEOPEN DOCX: Table is wrongly rendered

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117031

--- Comment #11 from raal  ---
Created attachment 141527
  --> https://bugs.documentfoundation.org/attachment.cgi?id=141527=edit
printscreen from word Online

Word Online - prices not visible

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82009] PIVOTTABLE: Black color on fields of Pivot Table Layout window (Mac OS X only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82009

--- Comment #32 from kam3...@gmail.com ---
Still present on 6.0.3.2

I made a screencast to show what happens
https://www.screencast.com/t/eQlNzhmcpcI

It's very frustrating, because clicking on the fields only sometimes partially
removes the blackout, so sometimes you can't continue.

Build ID: 8f48d515416608e3a835360314dac7e47fd0b821
CPU threads: 2; OS: Mac OS X 10.13.4; UI render: default; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117031] FILEOPEN DOCX: Table is wrongly rendered

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117031

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #10 from raal  ---
Created attachment 141526
  --> https://bugs.documentfoundation.org/attachment.cgi?id=141526=edit
printscreen from word2010

as you can see at printscreen, the prices are not visible even in word2010

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117146] New: Saving as .csv corrupts unicode characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117146

Bug ID: 117146
   Summary: Saving as .csv corrupts unicode characters
   Product: LibreOffice
   Version: 6.0.3.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 2nie...@gmail.com

Description:
Saving file as .csv automatically encodes it in ANSI, and does not show unicode
characters, like Č or Ė.

Steps to Reproduce:
1. Create a calc document with characters 
2. Save file as .csv
3. Open .csv in text editor

Actual Results:  
Č, Ė, and probably more unicode characters appear as "?". 

Expected Results:
obvious :)


Reproducible: Always


User Profile Reset: No



Additional Info:
Marking all hardware with Windows, however, I suspect this is standard
behaviour which would reproduce also in other operating systems.


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101
Firefox/59.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117125] Libreoffice stores same png multiple times

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117125

--- Comment #3 from Telesto  ---
There is a duplicate in the attached file However, I'm not able to reproduce
this from scratch with
Version: 6.1.0.0.alpha0+
Build ID: 9c4eaa7b81a40d97fe49b85272b40bfeaaf44f86
CPU threads: 4; OS: Windows 6.3; UI render: GL; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-04-16_03:31:36
Locale: nl-NL (nl_NL); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117054] When typing into a text box keyboard characters arrive on screen in wrong order

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117054

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #2 from raal  ---
I cannot reproduce with Version: 6.1.0.0.alpha0+
Build ID: b11188835d3b87cd9d2a8cdb3da204cfda5d3e6e
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; 

For the test, could you test it in Safe mode? Help/ Restart in Safe mode. Thank
you

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117056] Date form control does not work after pdf export

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117056

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||r...@post.cz
 Ever confirmed|0   |1

--- Comment #2 from raal  ---
Hello,

Thank you for filing the bug. Please send us a sample document, as this makes
it easier for us to verify the bug. 
I have set the bug's status to 'NEEDINFO', so please do change it back to
'UNCONFIRMED' once you have attached a document.
(Please note that the attachment will be public, remove any sensitive
information before attaching it.)
How can I eliminate confidential data from a sample document?
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117137] FILESAVE: DOCX: file cannot be opened in MSO / numbering lost in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117137

--- Comment #4 from Jacques Guilleron  ---
OK,
Bad manip from me. I reproduce the same eror than raal after saving the file
into
LO 6.1.0.0.alpha0+ Build ID: f80029445e2b558f0d0e0a25c2c1bbcbe5254120
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-04-13_23:07:11
Locale: fr-FR (fr_FR); Calc: CL
but not with
LO  6.1.0.0.alpha0+ Build ID: 6fc9d4a482ab50a1bf8fefb1dae2a6ded3c7e3dd
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-01-24_04:37:19
Locale: fr-FR (fr_FR); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116169] Impress remote 2.3 distributed on Fdroid does not show slides on mobile

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116169

raal  changed:

   What|Removed |Added

 CC||a...@openmailbox.org

--- Comment #4 from raal  ---
*** Bug 117076 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117076] Can't see the thumbnails on Impress Remote 2.3.0 ( from Yalp Store) through WiFi

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117076

raal  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from raal  ---


*** This bug has been marked as a duplicate of bug 116169 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117076] Can't see the thumbnails on Impress Remote 2.3.0 ( from Yalp Store) through WiFi

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117076

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||r...@post.cz
 Ever confirmed|0   |1

--- Comment #2 from raal  ---
I can confirmr. Impress remote 2.3; Android 5; wifi and bluetooth connection.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117145] Crop Outline does not match Crop Area

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117145

--- Comment #1 from Luke  ---
Created attachment 141525
  --> https://bugs.documentfoundation.org/attachment.cgi?id=141525=edit
Screenshot of problem

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117119] Enable experimental features by default when build is not built in release configuration

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117119

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||jbfa...@libreoffice.org
 Resolution|--- |NOTABUG

--- Comment #2 from Jean-Baptiste Faure  ---
(In reply to V Stuart Foote from comment #1)
> This is a horrible idea. Experimental features are expected to be unstable,
> or marginally complete. Enabling them for testing is an opt in
> decision--best controlled as always from the Tools -> Options -> Advanced
> panel.
> 
> Forcing them active would just make daily TB builds unstable and really
> unsuitable for use--meaning with fewer folks testing by building or
> downloading. We would have less stability testing and fewer regressions
> picked up during dev cycle.
> 
> So IMHO, simply no.

Agreed. Closing as NotABug.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs