[Libreoffice-bugs] [Bug 117736] New: Crash in: SdrPage::getUnoPage()

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117736

Bug ID: 117736
   Summary: Crash in: SdrPage::getUnoPage()
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: danielp...@gmail.com

This bug was filed from the crash reporting server and is
br-399a38fe-dd16-4af2-adb2-aed75e3ef3e1.
=

This bug is related to moving an image inside the spreadsheet a few milimeters.
When I move it a big distance (cm) it moves normally. But when moved just a
little, the program crashes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117735] Crash in: SdrPage::getUnoPage()

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117735

--- Comment #1 from Daniel  ---
I am talking about, not editing the cell itself, but the comment. Also, when I
just hover the comment, it appears, but instead of disappearing when I move the
mouse, the program crashes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117735] Crash in: SdrPage::getUnoPage()

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117735

Daniel  changed:

   What|Removed |Added

Version|unspecified |6.1.0.0.alpha0+

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117735] New: Crash in: SdrPage::getUnoPage()

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117735

Bug ID: 117735
   Summary: Crash in: SdrPage::getUnoPage()
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: danielp...@gmail.com

This bug was filed from the crash reporting server and is
br-25f37754-b9ad-44c6-babb-57a875e64433.
=

Every time I select a cell with a comment and I try to edit it the program
crashes. It is quite annoying.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/uiconfig

[Olivier Hallot]

 cui/uiconfig/ui/signsignatureline.ui |   24 ++--
 1 file changed, 14 insertions(+), 10 deletions(-)

New commits:
commit c697e7f566302d5d52c3a043d5bddd8cf65499a1
Author: Olivier Hallot 
Date:   Sat May 19 23:11:10 2018 -0300

Place help button on the left of signature dialog

Change-Id: Ic78646b7540d2eaf176b3b6c57b0225793b866bd
Reviewed-on: https://gerrit.libreoffice.org/54597
Tested-by: Jenkins 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/cui/uiconfig/ui/signsignatureline.ui 
b/cui/uiconfig/ui/signsignatureline.ui
index b7182f9c8aaf..6eb036fbc944 100644
--- a/cui/uiconfig/ui/signsignatureline.ui
+++ b/cui/uiconfig/ui/signsignatureline.ui
@@ -1,5 +1,5 @@
 
-
+
 
   
   
@@ -10,6 +10,9 @@
 0
 0
 dialog
+
+  
+
 
   
 False
@@ -20,8 +23,8 @@
 False
 end
 
-  
-gtk-cancel
+  
+gtk-help
 True
 True
 True
@@ -31,16 +34,16 @@
 True
 True
 0
+True
   
 
 
-  
-Sign
+  
+gtk-cancel
 True
 True
-True
-True
 True
+True
   
   
 True
@@ -49,12 +52,13 @@
   
 
 
-  
-gtk-help
+  
+Sign
 True
 True
+True
+True
 True
-True
   
   
 True
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svx/source sw/qa

[Samuel Mehrbrodt]

 svx/source/xoutdev/_xoutbmp.cxx|   20 +---
 sw/qa/extras/htmlexport/htmlexport.cxx |2 +-
 2 files changed, 2 insertions(+), 20 deletions(-)

New commits:
commit 57cc8b2e4f93b3a93ce9ac46a2a98eb2a799faa3
Author: Samuel Mehrbrodt 
Date:   Fri May 18 16:26:37 2018 +0200

Fix svg to base64 conversion

This reverts part of ab14a9708d2937bc767c14542610ce91b56dda1e which had
a questionable fix by unconditionally removing the first 8 bytes of the svg
which led to svgs starting with

rsion="1.0" encoding="utf-8"?>

instead of



Change-Id: I8c4d78db1794473d20ddd77019ae81b88be0bb03
Reviewed-on: https://gerrit.libreoffice.org/54550
Tested-by: Jenkins 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/svx/source/xoutdev/_xoutbmp.cxx b/svx/source/xoutdev/_xoutbmp.cxx
index 1e57b09bfe3c..3fc0110ed9e7 100644
--- a/svx/source/xoutdev/_xoutbmp.cxx
+++ b/svx/source/xoutdev/_xoutbmp.cxx
@@ -393,25 +393,7 @@ bool XOutBitmap::GraphicToBase64(const Graphic& rGraphic, 
OUString& rOUString)
 css::uno::Sequence aOStmSeq( static_cast(aOStm.GetData()),aOStm.Tell() );
 OUStringBuffer aStrBuffer;
 ::comphelper::Base64::encode(aStrBuffer,aOStmSeq);
-OUString aEncodedBase64Image = aStrBuffer.makeStringAndClear();
-if( aLink.GetType() == GfxLinkType::NativeSvg )
-{
-  sal_Int32 ite(8);
-  sal_Int32 nBufferLength(aOStmSeq.getLength());
-  const sal_Int8* pBuffer = aOStmSeq.getConstArray();
-  css::uno::Sequence newTempSeq = aOStmSeq;// creates 
new Sequence to remove front 8 bits of garbage and encodes in base64
-  sal_Int8 *pOutBuffer = newTempSeq.getArray();
-  while(ite < nBufferLength)
-  {
-*pOutBuffer++ = pBuffer[ite];
-ite++;
-  }
-  ::comphelper::Base64::encode(aStrBuffer, newTempSeq);
-  aEncodedBase64Image = aStrBuffer.makeStringAndClear();
-  sal_Int32 SVGFixLength = aEncodedBase64Image.getLength();
-  aEncodedBase64Image = aEncodedBase64Image.replaceAt(SVGFixLength - 12, 
SVGFixLength, "") + "PC9zdmc+Cg=="; // removes rear 12 bits of garbage and adds 
svg closing tag in base64
-}
-rOUString = aMimeType + ";base64," + aEncodedBase64Image;
+rOUString = aMimeType + ";base64," + aStrBuffer.makeStringAndClear();
 return true;
 }
 
diff --git a/sw/qa/extras/htmlexport/htmlexport.cxx 
b/sw/qa/extras/htmlexport/htmlexport.cxx
index f7aaec10a79b..4199ffeb4092 100644
--- a/sw/qa/extras/htmlexport/htmlexport.cxx
+++ b/sw/qa/extras/htmlexport/htmlexport.cxx
@@ -280,7 +280,7 @@ DECLARE_HTMLEXPORT_TEST(testExportImageBulletList, 
"tdf66822.odt")
 
 // Encoded base64 SVG bullet should match and render on browser
 assertXPath(pDoc, "/html/body/ul", 1);
-assertXPath(pDoc, "/html/body/ul", "style", "list-style-image: 
url(data:image/svg+xml;base64,cnNpb249IjEuMCIgZW5jb2Rpbmc9InV0Zi04Ij8+DQo8IS0tIEdlbmVyYXRvcjogQWRvYmUgSWxsdXN0cmF0b3IgMTIuMC4xLCBTVkcgRXhwb3J0IFBsdWctSW4gLiBTVkcgVmVyc2lvbjogNi4wMCBCdWlsZCA1MTQ0OCkgIC0tPg0KPCFET0NUWVBFIHN2ZyBQVUJMSUMgIi0vL1czQy8vRFREIFNWRyAxLjEvL0VOIiAiaHR0cDovL3d3dy53My5vcmcvR3JhcGhpY3MvU1ZHLzEuMS9EVEQvc3ZnMTEuZHRkIiBbDQoJPCFFTlRJVFkgbnNfc3ZnICJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+DQoJPCFFTlRJVFkgbnNfeGxpbmsgImh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiPg0KXT4NCjxzdmcgIHZlcnNpb249IjEuMSIgaWQ9IkxheWVyXzEiIHhtbG5zPSImbnNfc3ZnOyIgeG1sbnM6eGxpbms9IiZuc194bGluazsiIHdpZHRoPSIxNC4wMDgiIGhlaWdodD0iMTQuMDEiDQoJIHZpZXdCb3g9IjAgMCAxNC4wMDggMTQuMDEiIG92ZXJmbG93PSJ2aXNpYmxlIiBlbmFibGUtYmFja2dyb3VuZD0ibmV3IDAgMCAxNC4wMDggMTQuMDEiIHhtbDpzcGFjZT0icHJlc2VydmUiPg0KPGc+DQoJPHJhZGlhbEdyYWRpZW50IGlkPSJYTUxJRF80XyIgY3g9IjcuMDA0NCIgY3k9IjcuMDA0OSIgcj0iNy4wMDQ0IiBncmFkaWVudFVuaXRzPSJ1c2VyU3BhY2VPblVzZSI+DQoJCTxzdG9wICBvZmZzZXQ9
 
IjAiIHN0eWxlPSJzdG9wLWNvbG9yOiMzNURCMzUiLz4NCgkJPHN0b3AgIG9mZnNldD0iMSIgc3R5bGU9InN0b3AtY29sb3I6IzAwQTAwMCIvPg0KCTwvcmFkaWFsR3JhZGllbnQ+DQoJPGNpcmNsZSBmaWxsPSJ1cmwoI1hNTElEXzRfKSIgY3g9IjcuMDA0IiBjeT0iNy4wMDUiIHI9IjcuMDA0Ii8+DQoJPGRlZnM+DQoJCTxmaWx0ZXIgaWQ9IkFkb2JlX09wYWNpdHlNYXNrRmlsdGVyIiBmaWx0ZXJVbml0cz0idXNlclNwYWNlT25Vc2UiIHg9IjMuNDgxIiB5PSIwLjY5MyIgd2lkdGg9IjYuOTg4IiBoZWlnaHQ9IjMuODkzIj4NCgkJCTxmZUNvbG9yTWF0cml4ICB0eXBlPSJtYXRyaXgiIHZhbHVlcz0iMSAwIDAgMCAwICAwIDEgMCAwIDAgIDAgMCAxIDAgMCAgMCAwIDAgMSAwIi8+DQoJCTwvZmlsdGVyPg0KCTwvZGVmcz4NCgk8bWFzayBtYXNrVW5pdHM9InVzZXJTcGFjZU9uVXNlIiB4PSIzLjQ4MSIgeT0iMC42OTMiIHdpZHRoPSI2Ljk4OCIgaGVpZ2h0PSIzLjg5MyIgaWQ9IlhNTElEXzVfIj4NCgkJPGcgZmlsdGVyPSJ1cmwoI0Fkb2JlX09wYWNpdHlNYXNrRmlsdGVyKSI+DQoJCQk8bGluZWFyR3JhZGllbnQgaWQ9IlhNTElEXzZfIiBncmFkaWVudFVuaXRzPSJ1c2VyU3BhY2VPblVzZSIgeDE9IjcuMTIyMSIgeTE9IjAuMTAzIiB4Mj0iNy4xMjIxIiB5Mj0iNS4yMzQ0Ij4NCgkJCQk8c3RvcCAgb2Zmc2V0PSIwIiBzdHlsZT0ic3RvcC1jb2xvcjojRkZGRkZGIi8+DQoJCQkJPHN0b3AgIG9mZnNldD0iMSIgc3R5bGU9I
 

[Libreoffice-commits] core.git: include/sfx2 sfx2/source

[Samuel Mehrbrodt]

 include/sfx2/docfile.hxx|3 +--
 sfx2/source/doc/docfile.cxx |3 ++-
 sfx2/source/doc/objserv.cxx |9 +++--
 3 files changed, 6 insertions(+), 9 deletions(-)

New commits:
commit 13596e704e4b48e8b0892867b3f3fc351a2729f9
Author: Samuel Mehrbrodt 
Date:   Thu May 17 13:35:31 2018 +0200

Don't pass ODF version, just retrieve it directly

Change-Id: I19ff42c348515b17dac17abe750ee03ca53efcbf
Reviewed-on: https://gerrit.libreoffice.org/54483
Tested-by: Jenkins 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/include/sfx2/docfile.hxx b/include/sfx2/docfile.hxx
index 7fe4911d3c55..6bf4d740e079 100644
--- a/include/sfx2/docfile.hxx
+++ b/include/sfx2/docfile.hxx
@@ -266,8 +266,7 @@ public:
 SAL_DLLPRIVATE bool
 SignContents_Impl(const css::uno::Reference 
xCert,
   const OUString& aSignatureLineId,
-  bool bSignScriptingContent, const OUString& aODFVersion,
-  bool bHasValidDocumentSignature);
+  bool bSignScriptingContent, bool 
bHasValidDocumentSignature);
 
 // the following two methods must be used and make sense only during 
saving currently
 // TODO/LATER: in future the signature state should be controlled by the 
medium not by the document
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index 76ca23eb8e1a..093dfbe8557b 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -3662,7 +3662,7 @@ void SfxMedium::CreateTempFileNoCopy()
 }
 
 bool SfxMedium::SignContents_Impl(const Reference xCert, const 
OUString& aSignatureLineId,
-  bool bSignScriptingContent, const OUString& 
aODFVersion,
+  bool bSignScriptingContent,
   bool bHasValidDocumentSignature)
 {
 bool bChanges = false;
@@ -3675,6 +3675,7 @@ bool SfxMedium::SignContents_Impl(const 
Reference xCert, const OUS
 
 // The component should know if there was a valid document signature, since
 // it should show a warning in this case
+OUString 
aODFVersion(comphelper::OStorageHelper::GetODFVersionFromStorage(GetStorage()));
 uno::Reference< security::XDocumentDigitalSignatures > xSigner(
 
security::DocumentDigitalSignatures::createWithVersionAndValidSignature(
 comphelper::getProcessComponentContext(), aODFVersion, 
bHasValidDocumentSignature ) );
diff --git a/sfx2/source/doc/objserv.cxx b/sfx2/source/doc/objserv.cxx
index c1b81cbf62e0..294ff9473faf 100644
--- a/sfx2/source/doc/objserv.cxx
+++ b/sfx2/source/doc/objserv.cxx
@@ -1556,9 +1556,8 @@ void SfxObjectShell::SignDocumentContent()
 if (CheckIsReadonly(false))
 return;
 
-OUString 
aODFVersion(comphelper::OStorageHelper::GetODFVersionFromStorage(GetStorage()));
 bool bSignSuccess = GetMedium()->SignContents_Impl(
-Reference(), "", false, aODFVersion, 
HasValidSignatures());
+Reference(), "", false, HasValidSignatures());
 
 AfterSigning(bSignSuccess, false);
 }
@@ -1572,9 +1571,8 @@ void SfxObjectShell::SignSignatureLine(const OUString& 
aSignatureLineId,
 if (CheckIsReadonly(false))
 return;
 
-OUString 
aODFVersion(comphelper::OStorageHelper::GetODFVersionFromStorage(GetStorage()));
 bool bSignSuccess = GetMedium()->SignContents_Impl(
-xCert, aSignatureLineId, false, aODFVersion, HasValidSignatures());
+xCert, aSignatureLineId, false, HasValidSignatures());
 
 AfterSigning(bSignSuccess, false);
 }
@@ -1592,9 +1590,8 @@ void SfxObjectShell::SignScriptingContent()
 if (CheckIsReadonly(true))
 return;
 
-OUString 
aODFVersion(comphelper::OStorageHelper::GetODFVersionFromStorage(GetStorage()));
 bool bSignSuccess = GetMedium()->SignContents_Impl(
-Reference(), OUString(), true, aODFVersion, 
HasValidSignatures());
+Reference(), OUString(), true, HasValidSignatures());
 
 AfterSigning(bSignSuccess, true);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/sfx2 sfx2/source

[Samuel Mehrbrodt]

 include/sfx2/objsh.hxx  |1 
 sfx2/source/doc/docfile.cxx |  225 +++-
 sfx2/source/doc/objserv.cxx |   49 +
 3 files changed, 148 insertions(+), 127 deletions(-)

New commits:
commit 039117eb27a11ee61d4f099c8616861cba961702
Author: Samuel Mehrbrodt 
Date:   Thu May 17 12:30:01 2018 +0200

Simplify SignContents_Impl by moving readonly check to caller methods

Change-Id: I95d9b12d7e1fc715363396e10bc4adc869978c44
Reviewed-on: https://gerrit.libreoffice.org/54478
Tested-by: Jenkins 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/include/sfx2/objsh.hxx b/include/sfx2/objsh.hxx
index 680b1ed8597f..0acc4f69a45d 100644
--- a/include/sfx2/objsh.hxx
+++ b/include/sfx2/objsh.hxx
@@ -355,6 +355,7 @@ public:
 
 /** Returns to if preparing was succesful, else false. */
 bool PrepareForSigning();
+bool CheckIsReadonly(bool bSignScriptingContent);
 void AfterSigning(bool bSignSuccess, bool bSignScriptingContent);
 bool HasValidSignatures();
 SignatureState  GetDocumentSignatureState();
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index acd54f1fc8c4..9498b287231a 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -3680,61 +3680,86 @@ bool SfxMedium::SignContents_Impl(const 
Reference xCert, const OUS
 comphelper::getProcessComponentContext(), aODFVersion, 
bHasValidDocumentSignature ) );
 
 uno::Reference< embed::XStorage > xWriteableZipStor;
-// Signing is not modification of the document, as seen by the user
-// ("only a saved document can be signed"). So allow signing in the
-// "opened read-only, but not physically-read-only" case.
-if (!IsOriginallyReadOnly())
+
+// we can reuse the temporary file if there is one already
+CreateTempFile( false );
+GetMedium_Impl();
+
+try
 {
-// we can reuse the temporary file if there is one already
-CreateTempFile( false );
-GetMedium_Impl();
+if ( !pImpl->xStream.is() )
+throw uno::RuntimeException();
 
+bool bODF = GetFilter()->IsOwnFormat();
 try
 {
-if ( !pImpl->xStream.is() )
-throw uno::RuntimeException();
+xWriteableZipStor = 
::comphelper::OStorageHelper::GetStorageOfFormatFromStream( 
ZIP_STORAGE_FORMAT_STRING, pImpl->xStream );
+}
+catch (const io::IOException& rException)
+{
+if (bODF)
+SAL_WARN("sfx.doc", "ODF stream is not a zip storage: " << 
rException);
+}
 
-bool bODF = GetFilter()->IsOwnFormat();
-try
-{
-xWriteableZipStor = 
::comphelper::OStorageHelper::GetStorageOfFormatFromStream( 
ZIP_STORAGE_FORMAT_STRING, pImpl->xStream );
-}
-catch (const io::IOException& rException)
-{
-if (bODF)
-SAL_WARN("sfx.doc", "ODF stream is not a zip storage: " << 
rException);
-}
+if ( !xWriteableZipStor.is() && bODF )
+throw uno::RuntimeException();
 
-if ( !xWriteableZipStor.is() && bODF )
+uno::Reference< embed::XStorage > xMetaInf;
+uno::Reference xNameAccess(xWriteableZipStor, 
uno::UNO_QUERY);
+if (xNameAccess.is() && xNameAccess->hasByName("META-INF"))
+{
+xMetaInf = xWriteableZipStor->openStorageElement(
+"META-INF",
+embed::ElementModes::READWRITE );
+if ( !xMetaInf.is() )
 throw uno::RuntimeException();
+}
+
+if ( bScriptingContent )
+{
+// If the signature has already the document signature it will be 
removed
+// after the scripting signature is inserted.
+uno::Reference< io::XStream > xStream(
+xMetaInf->openStreamElement( 
xSigner->getScriptingContentSignatureDefaultStreamName(),
+embed::ElementModes::READWRITE 
),
+uno::UNO_SET_THROW );
 
-uno::Reference< embed::XStorage > xMetaInf;
-uno::Reference 
xNameAccess(xWriteableZipStor, uno::UNO_QUERY);
-if (xNameAccess.is() && xNameAccess->hasByName("META-INF"))
+if ( xSigner->signScriptingContent( GetZipStorageToSign_Impl(), 
xStream ) )
 {
-xMetaInf = xWriteableZipStor->openStorageElement(
-"META-INF",
-embed::ElementModes::READWRITE 
);
-if ( !xMetaInf.is() )
-throw uno::RuntimeException();
-}
+// remove the document signature if any
+OUString aDocSigName = 

[Libreoffice-commits] core.git: include/sfx2 sfx2/source

[Samuel Mehrbrodt]

 include/sfx2/docfile.hxx|2 +-
 sfx2/source/doc/docfile.cxx |4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 99337b029a3f94257160077ecf11ee3c59c77b7c
Author: Samuel Mehrbrodt 
Date:   Thu May 17 12:33:30 2018 +0200

Rename parameter bScriptingContent -> bSignScriptingContent

Change-Id: I227e59417719625a9752e727060f5e4f5094092d
Reviewed-on: https://gerrit.libreoffice.org/54479
Tested-by: Jenkins 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/include/sfx2/docfile.hxx b/include/sfx2/docfile.hxx
index f7e34b957766..7fe4911d3c55 100644
--- a/include/sfx2/docfile.hxx
+++ b/include/sfx2/docfile.hxx
@@ -266,7 +266,7 @@ public:
 SAL_DLLPRIVATE bool
 SignContents_Impl(const css::uno::Reference 
xCert,
   const OUString& aSignatureLineId,
-  bool bScriptingContent, const OUString& aODFVersion,
+  bool bSignScriptingContent, const OUString& aODFVersion,
   bool bHasValidDocumentSignature);
 
 // the following two methods must be used and make sense only during 
saving currently
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index 9498b287231a..76ca23eb8e1a 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -3662,7 +3662,7 @@ void SfxMedium::CreateTempFileNoCopy()
 }
 
 bool SfxMedium::SignContents_Impl(const Reference xCert, const 
OUString& aSignatureLineId,
-  bool bScriptingContent, const OUString& 
aODFVersion,
+  bool bSignScriptingContent, const OUString& 
aODFVersion,
   bool bHasValidDocumentSignature)
 {
 bool bChanges = false;
@@ -3715,7 +3715,7 @@ bool SfxMedium::SignContents_Impl(const 
Reference xCert, const OUS
 throw uno::RuntimeException();
 }
 
-if ( bScriptingContent )
+if ( bSignScriptingContent )
 {
 // If the signature has already the document signature it will be 
removed
 // after the scripting signature is inserted.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sfx2/source

[Samuel Mehrbrodt]

 sfx2/source/doc/docfile.cxx |  276 ++--
 1 file changed, 139 insertions(+), 137 deletions(-)

New commits:
commit c4409edb4e0623b17c9760af11c7bd7b29a59d76
Author: Samuel Mehrbrodt 
Date:   Thu May 17 11:34:37 2018 +0200

Reduce indentation by returning early on error condition

Change-Id: Iebf6eca68f0dcba87ab517952009ee6dfb4b588c
Reviewed-on: https://gerrit.libreoffice.org/54475
Tested-by: Jenkins 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index 1ac4c883d30a..acd54f1fc8c4 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -3667,71 +3667,103 @@ bool SfxMedium::SignContents_Impl(const 
Reference xCert, const OUS
 {
 bool bChanges = false;
 
-// the medium should be closed to be able to sign, the caller is 
responsible to close it
-if ( !IsOpen() && !GetError() )
-{
-// The component should know if there was a valid document signature, 
since
-// it should show a warning in this case
-uno::Reference< security::XDocumentDigitalSignatures > xSigner(
-
security::DocumentDigitalSignatures::createWithVersionAndValidSignature(
-comphelper::getProcessComponentContext(), aODFVersion, 
bHasValidDocumentSignature ) );
-
-uno::Reference< embed::XStorage > xWriteableZipStor;
-// Signing is not modification of the document, as seen by the user
-// ("only a saved document can be signed"). So allow signing in the
-// "opened read-only, but not physically-read-only" case.
-if (!IsOriginallyReadOnly())
-{
-// we can reuse the temporary file if there is one already
-CreateTempFile( false );
-GetMedium_Impl();
+if (IsOpen() || GetError())
+{
+SAL_WARN("sfx.doc", "The medium must be closed by the signer!");
+return bChanges;
+}
+
+// The component should know if there was a valid document signature, since
+// it should show a warning in this case
+uno::Reference< security::XDocumentDigitalSignatures > xSigner(
+
security::DocumentDigitalSignatures::createWithVersionAndValidSignature(
+comphelper::getProcessComponentContext(), aODFVersion, 
bHasValidDocumentSignature ) );
+
+uno::Reference< embed::XStorage > xWriteableZipStor;
+// Signing is not modification of the document, as seen by the user
+// ("only a saved document can be signed"). So allow signing in the
+// "opened read-only, but not physically-read-only" case.
+if (!IsOriginallyReadOnly())
+{
+// we can reuse the temporary file if there is one already
+CreateTempFile( false );
+GetMedium_Impl();
+
+try
+{
+if ( !pImpl->xStream.is() )
+throw uno::RuntimeException();
 
+bool bODF = GetFilter()->IsOwnFormat();
 try
 {
-if ( !pImpl->xStream.is() )
-throw uno::RuntimeException();
+xWriteableZipStor = 
::comphelper::OStorageHelper::GetStorageOfFormatFromStream( 
ZIP_STORAGE_FORMAT_STRING, pImpl->xStream );
+}
+catch (const io::IOException& rException)
+{
+if (bODF)
+SAL_WARN("sfx.doc", "ODF stream is not a zip storage: " << 
rException);
+}
 
-bool bODF = GetFilter()->IsOwnFormat();
-try
-{
-xWriteableZipStor = 
::comphelper::OStorageHelper::GetStorageOfFormatFromStream( 
ZIP_STORAGE_FORMAT_STRING, pImpl->xStream );
-}
-catch (const io::IOException& rException)
-{
-if (bODF)
-SAL_WARN("sfx.doc", "ODF stream is not a zip storage: 
" << rException);
-}
+if ( !xWriteableZipStor.is() && bODF )
+throw uno::RuntimeException();
 
-if ( !xWriteableZipStor.is() && bODF )
+uno::Reference< embed::XStorage > xMetaInf;
+uno::Reference 
xNameAccess(xWriteableZipStor, uno::UNO_QUERY);
+if (xNameAccess.is() && xNameAccess->hasByName("META-INF"))
+{
+xMetaInf = xWriteableZipStor->openStorageElement(
+"META-INF",
+embed::ElementModes::READWRITE 
);
+if ( !xMetaInf.is() )
 throw uno::RuntimeException();
+}
 
-uno::Reference< embed::XStorage > xMetaInf;
-uno::Reference 
xNameAccess(xWriteableZipStor, uno::UNO_QUERY);
-if (xNameAccess.is() && xNameAccess->hasByName("META-INF"))
+if ( bScriptingContent )
+{
+   

[Libreoffice-bugs] [Bug 117734] New: Useless bugware galore!

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117734

Bug ID: 117734
   Summary: Useless bugware galore!
   Product: LibreOffice
   Version: 6.0.3.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rcdor...@gmail.com

Description:
So I had hoped to finally be able to get rid of this hideous Microsoft Office
2016
But I learned my lesson with "LaborOffice"
until the event I thought quite highly of libreoffice and now it's another
thing that goes to the trash as useless inane dysfunctional crap full of bugs!

I spent three hours on an important document today Creating in LibreOffice
Writer.
The first problem I came across which I posted here was that it did not retain
The three column sizes in a document while open. Also disable and not
accessible were the vertical separation lines settings.

I saved the document off as an RTF file so I would certainly have no issue
opening it in another writing program if needed.

Well guess what? libreoffice writer failed miserably and upon opening the RTF
file had thrown out all the formatting of the three columns!
and that includes all the hyperlinks as well which all produce error messages.
And before I forget the bookmarks Links too.

>From there on everything went downhill. 
Trying to re-create the three columns and set the column breaks I saved it
again.
upon opening the newly re-created document I had to discover that now it was
completely eff'd up!
the document now had more columns than I designated and section breaks none of
them which could be eliminated. In other words it was just a miracle that the
app did not start editing and writing text by itself.

these two major Disasters made my decision it's a piece of worthless crap Bug
where as unripe as a green apple. I cannot rely on The simplest thing. Might as
well get the old Remington typewriter. I spent considerable more time
re-creating and restoring a document then it took me to created The original
doc it in the first place!

Steps to Reproduce:
1.create a three column document spend a lot of time writing and formatting,
inserting hyperlinks etc.
2.save it as RTF
3.open it again and then bang your head on the wall for having wasted time with
libreoffice!

For those who want to be wise: yes the same thing in safe mode.
The same thing happens if you save it in Microsoft Word as RTF and open-it in
LibreOffice. Not so however, if you reopen it again in Microsoft Word. The
formatting is retained (That is the whole purpose of RTF!)
libreoffice dumps the formatting or creates It's own!
hyperlinks are gone to.
worthless, useless.
I need to work and be productive.

Actual Results:  
everything else but what expected. (and this in the year 2018)

Expected Results:
To open the document In the format and appearance the way I saved it! DUH!
or for that matter if I set certain column widths to retain and safe both
sizes!


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Version: 6.0.3.2 (x64)
Build ID: 8f48d515416608e3a835360314dac7e47fd0b821
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
Locale: en-US (en_US); Calc: 

with or without OpenGL enabled, it does not matter


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101
Firefox/56.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107867] Crash when working with form

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107867

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107259] ManagedMenuButton drop down arrow size different based on OS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107259

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106975] Download Link is not Localised

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106975

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105660] FILEOPEN: PPTX - polygon imported as two shapes, odd extra points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105660

--- Comment #8 from Regina Henschel  ---
The two extra points seem to fixed with one of the recent commits. But I still
get one polygon for the filling and a second polygon for the outline in
Version: 6.1.0.0.alpha1+ (x64)
Build ID: 88051c660fc6759346a01bc559818d3e23f8f55c
CPU threads: 8; OS: Windows 10.0; UI render: default; 
Locale: de-DE (de_DE); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84357] EDITING: Polygon objects are not able to manage text anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84357

Regina Henschel  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #26 from Regina Henschel  ---
The texts is visible in the shape and adapts to the contour in Version: 5.4.3.2
(x64)
Build ID: 92a7159f7e4af62137622921e809f8546db437e5
CPU threads: 8; OS: Windows 6.19; UI render: default; 
Locale: de-DE (de_DE); Calc: CL

The problem of wrong position of the rotated text in a rotated polygon is
tracked in bug 84507.

I don't know which commit fixes the problem, therefore I set the bug to "works
for me".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - basic/source

[Vasily Melenchuk]

 basic/source/runtime/dllmgr-x64.cxx |   17 -
 1 file changed, 12 insertions(+), 5 deletions(-)

New commits:
commit c4878f9009d41ee9b06d8d408ffcacf50fded61f
Author: Vasily Melenchuk 
Date:   Mon May 21 19:47:00 2018 +0300

tdf#97231: basic: do not use extra wrapping for string marshaling

previous approach did wrap string reference once again, making
practically "a pointer to pointer to string" so this code was not
working correctly for RegQueryValueExA WinAPI call.

String is already provided as a reference (see marshalString(), so
no reason to wrap its reference.

This approach was just copied from from dllmgr-x86.cxx plus some
minor changes to make both versions similar.

Reviewed-on: https://gerrit.libreoffice.org/54645
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

Conflicts:
basic/source/runtime/dllmgr-x64.cxx

Change-Id: I85065112407de3f078265d2c76437814402eb1b3

diff --git a/basic/source/runtime/dllmgr-x64.cxx 
b/basic/source/runtime/dllmgr-x64.cxx
index 8f2b0abdef8c..9d95a87a8146 100644
--- a/basic/source/runtime/dllmgr-x64.cxx
+++ b/basic/source/runtime/dllmgr-x64.cxx
@@ -32,6 +32,7 @@
 
 #include 
 #include 
+#include "runtime.hxx"
 #include 
 #include 
 #include 
@@ -256,9 +257,15 @@ SbError marshal(
 std::vector< char > & blob, std::size_t offset, MarshalData & data)
 {
 OSL_ASSERT(variable != 0);
-if (!(variable->GetFlags() & SbxFlagBits::Reference)) {
-if ((variable->GetType() & SbxARRAY) == 0) {
-switch (variable->GetType()) {
+
+SbxDataType eVarType = variable->GetType();
+bool bByVal = !(variable->GetFlags() & SbxFlagBits::Reference);
+if( !bByVal && !SbiRuntime::isVBAEnabled() && eVarType == SbxSTRING )
+bByVal = true;
+
+if (bByVal) {
+if ((eVarType & SbxARRAY) == 0) {
+switch (eVarType) {
 case SbxINTEGER:
 add(blob, variable->GetInteger(), outer ? 8 : 2, offset);
 break;
@@ -307,8 +314,8 @@ SbError marshal(
 }
 }
 } else {
-if ((variable->GetType() & SbxARRAY) == 0) {
-switch (variable->GetType()) {
+if ((eVarType & SbxARRAY) == 0) {
+switch (eVarType) {
 case SbxINTEGER:
 case SbxLONG:
 case SbxSINGLE:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: basic/source

[Vasily Melenchuk]

 basic/source/runtime/dllmgr-x64.cxx |   17 -
 1 file changed, 12 insertions(+), 5 deletions(-)

New commits:
commit b9ebabd675f916a0151ec3893a59131f3a8b2a05
Author: Vasily Melenchuk 
Date:   Mon May 21 19:47:00 2018 +0300

tdf#97231: basic: do not use extra wrapping for string marshaling

previous approach did wrap string reference once again, making
practically "a pointer to pointer to string" so this code was not
working correctly for RegQueryValueExA WinAPI call.

String is already provided as a reference (see marshalString(), so
no reason to wrap its reference.

This approach was just copied from from dllmgr-x86.cxx plus some
minor changes to make both versions similar.

Change-Id: I85065112407de3f078265d2c76437814402eb1b3
Reviewed-on: https://gerrit.libreoffice.org/54645
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/basic/source/runtime/dllmgr-x64.cxx 
b/basic/source/runtime/dllmgr-x64.cxx
index 4450bbfa6029..2c311861122a 100644
--- a/basic/source/runtime/dllmgr-x64.cxx
+++ b/basic/source/runtime/dllmgr-x64.cxx
@@ -31,6 +31,7 @@
 
 #include 
 #include 
+#include "runtime.hxx"
 #include 
 #include 
 #include 
@@ -256,9 +257,15 @@ ErrCode marshal(
 std::vector< char > & blob, std::size_t offset, MarshalData & data)
 {
 OSL_ASSERT(variable != nullptr);
-if (!(variable->GetFlags() & SbxFlagBits::Reference)) {
-if ((variable->GetType() & SbxARRAY) == 0) {
-switch (variable->GetType()) {
+
+SbxDataType eVarType = variable->GetType();
+bool bByVal = !(variable->GetFlags() & SbxFlagBits::Reference);
+if( !bByVal && !SbiRuntime::isVBAEnabled() && eVarType == SbxSTRING )
+bByVal = true;
+
+if (bByVal) {
+if ((eVarType & SbxARRAY) == 0) {
+switch (eVarType) {
 case SbxINTEGER:
 add(blob, variable->GetInteger(), outer ? 8 : 2, offset);
 break;
@@ -307,8 +314,8 @@ ErrCode marshal(
 }
 }
 } else {
-if ((variable->GetType() & SbxARRAY) == 0) {
-switch (variable->GetType()) {
+if ((eVarType & SbxARRAY) == 0) {
+switch (eVarType) {
 case SbxINTEGER:
 case SbxLONG:
 case SbxSINGLE:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: config_host/config_features.h.in configure.ac

[Tor Lillqvist]

 config_host/config_features.h.in |3 ++-
 configure.ac |4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 92664be7f876a5f219514cf598e7b4cd39a5b9c9
Author: Tor Lillqvist 
Date:   Tue May 22 01:45:06 2018 +0300

Fix misleading comment: We do check HAVE_FEATURE_READONLY_INSTALLSET...

...at least in a couple of places, and at least for a sandboxed macOS
build that check does its job, it prevents write attempts into the app
bundle.

Change-Id: I6d243d3e8a4c77f03a8265125aefd75becbf0998

diff --git a/config_host/config_features.h.in b/config_host/config_features.h.in
index d631ae1c0e42..c66435a12007 100644
--- a/config_host/config_features.h.in
+++ b/config_host/config_features.h.in
@@ -113,7 +113,8 @@
  *
  * Prevents attempts by LibreOffice to write into its installation. That means
  * at least that no "system-wide" extensions can be added, if the location for
- * them is the traditional one. Experimental work in progress, not actually 
implemented.
+ * them is the traditional one right in the middle of the installation.
+ * Probably not completely implemented.
  */
 
 #define HAVE_FEATURE_READONLY_INSTALLSET 0
diff --git a/configure.ac b/configure.ac
index fc07222114cb..f9202771c1b0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1430,8 +1430,8 @@ AC_ARG_WITH(package-version,
 libo_FUZZ_ARG_ENABLE(readonly-installset,
 AS_HELP_STRING([--enable-readonly-installset],
 [Prevents any attempts by LibreOffice to write into its installation. 
That means
- at least that no "system-wide" extensions can be added. Experimental 
work in
- progress.]),
+ at least that no "system-wide" extensions can be added. Partly 
experimental work in
+ progress, probably not fully implemented (but is useful for sandboxed 
macOS builds).]),
 ,)
 
 libo_FUZZ_ARG_ENABLE(postgresql-sdbc,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117733] New: no separator in multi-column (2 +) and column width not retained/stored

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117733

Bug ID: 117733
   Summary: no separator in multi-column (2 +) and column width
not retained/stored
   Product: LibreOffice
   Version: 6.0.3.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rcdor...@gmail.com

Created attachment 142237
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142237=edit
column formatting & line bug as described in 1), 2) & 3)

1) no vertical separator line in multicolumn (2 or more) document.
line choice not available.
2)reopening column choice defaults to symmetrical columns

1)do this:
click "format".
click "page".
select "columns" tab.
select a two or more column document page.

under separator line style is: -none-
no other line style available
all other fields (Width, height, position and color) are grayed out

2)try this: (like my document)
select:
1st column: 1.2 inch wide
2nd column: 4.53 inch wide
3rd column: 1.2 inch wide
spacing between 1st and 2nd  to 0.15 inch
spacing between 2nd and 3rd  to 0.15 inch
apply or okay

3) Now reopen as in 1)
column width (in my case) defaults to all column being 2.31 inch wide!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117726] Extend formula when inserting a column or row

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117726

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #3 from Regina Henschel  ---
You mean, that you want a short way for "insert new row, copy content of
previous row, paste into new row"?
Then do this: Mark the row, drag down a cell from that row while pressing
Ctrl+Alt.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116968] [META] Migrating existing embedded HSQLDB databases to Firebird

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116968

Aron Budea  changed:

   What|Removed |Added

 Depends on||117732


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=117732
[Bug 117732] Firebird: Migration: Time values are being changed during
migration process (data type TIME and DATETIME)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117732] Firebird: Migration: Time values are being changed during migration process ( data type TIME and DATETIME)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117732

Aron Budea  changed:

   What|Removed |Added

 Blocks||116968


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116968
[Bug 116968] [META] Migrating existing embedded HSQLDB databases to Firebird
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117709] Export and import to and from Org (Emacs org-mode)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117709

nona  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---
 Ever confirmed|0   |1

--- Comment #2 from nona  ---
(In reply to Jean-Baptiste Faure from comment #1)
> I agree, it is the same enhancement request as bug 103791.
> 
> Best regards. JBF
> 
> *** This bug has been marked as a duplicate of bug 103791 ***

I'm sorry, but that other report requests a change of GUI. What I suggest is an
exporting or importing feature. I still remember that it was not always
possible to export to PDF in LibreOffice, and now even your worst competition
copied your lead on this. Would you reconsider, or at least remove the
duplicate tag? Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117732] Firebird: Migration: Time values are being changed during migration process ( data type TIME and DATETIME)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117732

--- Comment #2 from Drew Jensen  ---
this issue came out of the verification process for a patch applied against 
https://bugs.documentfoundation.org/show_bug.cgi?id=117298

There is information in the comments on that issue of interest here,
particularly comment 10.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117732] Firebird: Migration: Time values are being changed during migration process ( data type TIME and DATETIME)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117732

--- Comment #1 from Drew Jensen  ---
Created attachment 142236
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142236=edit
zip with input and output of test run

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117732] New: Firebird: Migration: Time values are being changed during migration process ( data type TIME and DATETIME)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117732

Bug ID: 117732
   Summary: Firebird: Migration: Time values are being changed
during migration process (data type TIME and DATETIME)
   Product: LibreOffice
   Version: 6.1.0.0.alpha1+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: drewjensen.in...@gmail.com

Description:
During the migration time values, either in a time field or a datetime field
are being changed.

In the case of datetime fields, depending on the input time that may also
change the date portion of the field.

Attaching both the input (hsql embedded ) and output (firebird embedded) ODB in
a zip file.

Steps to Reproduce:
1. Down load the attached zip file and remove the two files.
2. Open the file moreTime_hsql.odb
3. Click on Tables to start the migration process and answer yes.


Actual Results:  
The test file included 3 columns of type datetime, date, time.
Values in datetime and time have changed. 
Records 2, 4, 5 and 7 also see a change in the date portion of the datetime
field.

Expected Results:
Table date migrates unchanged.


Reproducible: Always


User Profile Reset: No



Additional Info:
Tested on Ubuntu 18.04 with build:
Version: 6.1.0.0.alpha1+
Build ID: 6e7e4d9f02f286ccb817cb2c1f54a951dcebffad
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2018-05-21_01:55:12
Locale: en-US (en_US.UTF-8); Calc: group


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Ubuntu Chromium/66.0.3359.139 Chrome/66.0.3359.139 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113973] Linux middle mouse button copy does not work correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113973

--- Comment #18 from Michael Lashkevich  ---
(In reply to Jean-Baptiste Faure from comment #17)
> I just tried to copy (using only left click and middle click) between
> Writer and Thunderbird (mail editor) and it works. I did that with LO 6.0.4
> provided by Ubuntu.
Maybe, it depends on the build or on the graphic environment? I use OpenSUSE
42.3, the build from the main distribution, within KDE Plasma 5.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117726] Extend formula when inserting a column or row

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117726

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m.a.riosv  ---
There is the [Ctrl+D] shortcut, selecting a range after the last row with
data/formulas they are copied on the selected cells.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99623] Copy-paste freezes LibreOffice when CLCL is running ( sysdtrans.dll!CMtaOleClipboard::getClipboard) - no steps

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99623

--- Comment #19 from Leo442  ---
And here's the Procdump output :

> procdump.exe soffice.bin -h soffice.bin.dmp

ProcDump v9.0 - Sysinternals process dump utility
Copyright (C) 2009-2017 Mark Russinovich and Andrew Richards
Sysinternals - www.sysinternals.com

Process:   soffice.bin (7964)
Process image: C:\Program Files\LibreOffice\program\soffice.bin
CPU threshold: n/a
Performance counter:   n/a
Commit threshold:  n/a
Threshold seconds: 10
Hung window check: Enabled
Log debug strings: Disabled
Exception monitor: Disabled
Exception filter:  [Includes]
   *
   [Excludes]
Terminate monitor: Disabled
Cloning type:  Disabled
Concurrent limit:  n/a
Avoid outage:  n/a
Number of dumps:   1
Dump folder:   C:\Procdump\
Dump filename/mask:soffice.bin
Queue to WER:  Disabled
Kill after dump:   Disabled


Press Ctrl-C to end monitoring without terminating the process.

[22:57:30] Hung Window:
[22:57:30] Dump 1 initiated: C:\Procdump\soffice.bin.dmp
[22:57:31] Dump 1 complete: 6 MB written in 0.4 seconds
[22:57:31] Dump count reached.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117723] Writer crashes every time with a certain large file FILEOPEN

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117723

Julien Nabet  changed:

   What|Removed |Added

   Priority|medium  |high
   Severity|normal  |major

--- Comment #6 from Julien Nabet  ---
Regression+crash=> let's increase importance

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113973] Linux middle mouse button copy does not work correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113973

--- Comment #17 from Jean-Baptiste Faure  ---
(In reply to Michael Lashkevich from comment #16)
> [...]
> I _never_ use Ctrl-C, because I _never_ need it in Linux. I just mark with
> the mouse and paste with the mouse. LibreOffice is the only program that
> forces me to use Ctrl-C, because mouse marking does not work properly.

I just tried to copy (using only left click and middle click) between
Writer and Thunderbird (mail editor) and it works. I did that with LO 6.0.4
provided by Ubuntu.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99623] Copy-paste freezes LibreOffice when CLCL is running ( sysdtrans.dll!CMtaOleClipboard::getClipboard) - no steps

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99623

--- Comment #18 from Leo442  ---
Created attachment 142235
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142235=edit
Dump of soffice.bin performed with procdump tool

Here's the dump as requested

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117723] Writer crashes every time with a certain large file FILEOPEN

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117723

Julien Nabet  changed:

   What|Removed |Added

   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117723] Writer crashes every time with a certain large file FILEOPEN

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117723

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #5 from Julien Nabet  ---
Created attachment 142234
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142234=edit
gdb + bt trace

On pc Debian x86-64 with master sources updated today, I could reproduce this.

I attached gdb session which includes bt too.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Jim Raykowski]

 sw/source/core/doc/tblrwcl.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 137c38a1ba01c51c421f695e1558d2c1499c6627
Author: Jim Raykowski 
Date:   Sat Apr 28 22:20:51 2018 -0800

tdf#117189 Fix table InsertRow redo

Change-Id: I92ce18105550d9514b18b81080cfd0c19dfe648b
Reviewed-on: https://gerrit.libreoffice.org/53618
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/sw/source/core/doc/tblrwcl.cxx b/sw/source/core/doc/tblrwcl.cxx
index 0c589270ce24..c33b005e9a89 100644
--- a/sw/source/core/doc/tblrwcl.cxx
+++ b/sw/source/core/doc/tblrwcl.cxx
@@ -634,7 +634,7 @@ bool SwTable::InsertRow_( SwDoc* pDoc, const SwSelBoxes& 
rBoxes,
 pPCD->AddRowCols( *this, rBoxes, nCnt, bBehind );
 pDoc->UpdateCharts( GetFrameFormat()->GetName() );
 
-pDoc->GetDocShell()->GetFEShell()->UpdateTableStyleFormatting();
+pDoc->GetDocShell()->GetFEShell()->UpdateTableStyleFormatting( pTableNd );
 
 return true;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117731] New: Batch libreoffice --convert-to offers no way to wait for document completion

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117731

Bug ID: 117731
   Summary: Batch libreoffice --convert-to offers no way to wait
for document completion
   Product: LibreOffice
   Version: 6.0.3.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: richard.elk...@gmail.com

Description:
Command-line: libreoffice --headless --convert-to odt:writer8 myfile.txt
The returned status code ($?) is zero.  So far, so good.
But, when I try to use the ODT file (E.g. copy it), it doesn't exist yet.
Yes, I tried `sync; sync; sync` but it did not help.
If I add a `sleep 1` immediately after checking the status code, then this
seems to allow enough time for some libreoffice subprocess (?) to finish.

Before version 6, I did not need the sleep step.  Maybe, this is some sort of
optimization?  If so, please provide an option to indicate that libreoffice
should hold up the process until the desired output is available.

I am using libreoffice 1:6.0.3-0ubuntu1 on Xubuntu 18.04.

`libreoffice --help` shows: 
LibreOffice 6.0.3.2 00m0(Build:2)


Steps to Reproduce:
Linux batch script, starting with an existing text file called "myfile.txt":

libreoffice --headless --convert-to odt:writer8 myfile.txt
RC=$?
if [ $RC -ne 0 ]; then 
echo '*** libreoffice conversion failed for myfile.txt'
exit 86
fi
cp myfile.odt somewhere-else.odt



Actual Results:  
cp: cannot stat 'myfile.odt': No such file or directory



Expected Results:
Copy completes as normal because myfile.odt is available.


Reproducible: Always


User Profile Reset: No



Additional Info:




User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:60.0) Gecko/20100101
Firefox/60.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116763] EDITING: The find tool doesn't match smart (Unicode) apostrophes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116763

--- Comment #5 from mwtjunkm...@gmail.com ---
This:
---
Hello,
The automatic replacement of single quote by a smart apostrophe is controlled
via: Tools > AutoCorrect > AutoCorrect Options, Localized Options tab,
Check/Uncheck "Replace" checkbox for Single Quotes.

Options in Tools > Options > Language Settings > English sentence checking,
Punctuation propose the modification of the character afterwards.

You need to copy the word you are looking for.


Was the same response I got from someone else, who subsequently closed my bug
as not a bug, because we have the privilege as a work-around of putting up with
some asinine situation where we cannot use one function (smart quote
replacement) if we expect to use another (word search).

Unacceptable.  I tested in MS Word 365, and it has zero problems finding words
with smart quote apostrophes.

LibreOffice Writer should be no different.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113973] Linux middle mouse button copy does not work correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113973

--- Comment #16 from Michael Lashkevich  ---
(In reply to Buovjaga from comment #15)
> Are you now saying middle button works, but Ctrl-V does not? I can confirm
> that Ctrl-V does not work, but this is how it is in all the other software.
> The middle button buffer is not the same.
No, both middle button and Ctrl-V work well, when there is something in the
clipboard. The problem, that LibreOffice, in contrast to all other X-Window
applications, sends nothing to the clipboard (except for the first symbol), if
you just mark a text with the mouse with pressed _left_ button.

I _never_ use Ctrl-C, because I _never_ need it in Linux. I just mark with the
mouse and paste with the mouse. LibreOffice is the only program that forces me
to use Ctrl-C, because mouse marking does not work properly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117652] Crash when inserting fontwork shape

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117652

raal  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||r...@post.cz
 Resolution|--- |DUPLICATE

--- Comment #2 from raal  ---
no crash in Version: 6.1.0.0.alpha1+
Build ID: db608e8e5e27cce8eeda26918bcab71222d342df
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk3; 
and Version: 6.1.0.0.alpha1+ (x64)
Build ID: e1a8338876bd161de4e9d9a4b22d4bc5335f7cee
CPU threads: 1; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-05-18_23:55:37

*** This bug has been marked as a duplicate of bug 116993 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117719] add labels Minimum and Maximum for drop-down lists in dialogue Conditional Formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117719

--- Comment #7 from kompilainenn <79045_79...@mail.ru> ---
Created attachment 142233
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142233=edit
Labels in MS Excel

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117719] add labels Minimum and Maximum for drop-down lists in dialogue Conditional Formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117719

--- Comment #6 from kompilainenn <79045_79...@mail.ru> ---
Created attachment 142232
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142232=edit
Mockup for All cells - Color scale (3 entries)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117723] Writer crashes every time with a certain large file FILEOPEN

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117723

raal  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||l...@deller.id.au

--- Comment #4 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Luke Deller; Could you possibly take a look at this one?
Thanks
17972dcd73482ba1cccbb3119ee3d9aa710da0f1 is the first bad commit
commit 17972dcd73482ba1cccbb3119ee3d9aa710da0f1
Author: Matthew Francis 
Date:   Sat Mar 14 23:57:41 2015 +0800

source-hash-b4ccde72b8e2e45e7276d5b08b182495a1b1a617

commit b4ccde72b8e2e45e7276d5b08b182495a1b1a617
Author: Luke Deller 
AuthorDate: Sat Jul 12 21:49:50 2014 +1000
Commit: Luboš Luňák 
CommitDate: Mon Jul 28 13:01:08 2014 +0200

Copy first-header-footer test from ww8 to ooxml

The test document was converted from doc to docx using MS Word 2010.

Several fixes were required to make this test pass:

- Do not clear the "FirstIsShared" property on page styles, as the code
  instead uses the old fashioned method of translating a Word section
  with "different first page header/footer": two page styles linked
  together, the first page style and the follow page style.
  (Also remove a wrong test case which checks the FirstIsShared
property)

- Do not clear the "HeaderIsShared"/"FooterIsShared" properties on the
  first page style, only on the follow page style.

- Actually set the "FollowStyle" property on the first page style to
  link it to the follow page style.  This didn't matter for the very
  first Word section because it was mapped to the default page styles
  "First Page" and "Standard" which are already linked, but it does
  matter for subsequent Word sections.

- For some reason setting a new page style at a section break was
  excluded in the case where the following section had a title page.
  Remove this exclusion.

- The exclusion mentioned in the last point was masking that bnc#751077
  was not entirely fixed.  To resolve that issue:
  When checking if the last paragraph of the section is empty, consider
  not just text content but also shapes.

- Remove a workaround for bnc#780843 involving copying of headers and
  footers from the "Standard" (first section) page style in the case
  where the following section had a title page.  This workaround is no
  longer needed as the test case passes without it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

[Zdeněk Crhonek]

 sc/qa/uitest/calc_tests/data/standardFilter.ods |binary
 sc/qa/uitest/calc_tests/standardFilter.py   |  745 
 2 files changed, 745 insertions(+)

New commits:
commit 9913458256effd34ab24fca166c37c0184a91f14
Author: Zdeněk Crhonek 
Date:   Mon May 21 15:20:38 2018 +0200

uitest - Calc standard filter

Change-Id: I578e0fa94326677ce277cd24e043c699d152a5dd
Reviewed-on: https://gerrit.libreoffice.org/54636
Tested-by: Jenkins 
Reviewed-by: Zdenek Crhonek 

diff --git a/sc/qa/uitest/calc_tests/data/standardFilter.ods 
b/sc/qa/uitest/calc_tests/data/standardFilter.ods
new file mode 100644
index ..eee728b46e13
Binary files /dev/null and b/sc/qa/uitest/calc_tests/data/standardFilter.ods 
differ
diff --git a/sc/qa/uitest/calc_tests/standardFilter.py 
b/sc/qa/uitest/calc_tests/standardFilter.py
new file mode 100644
index ..8342b544eb8c
--- /dev/null
+++ b/sc/qa/uitest/calc_tests/standardFilter.py
@@ -0,0 +1,745 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+from uitest.framework import UITestCase
+from uitest.uihelper.common import get_state_as_dict
+from uitest.uihelper.common import select_pos
+from uitest.uihelper.calc import enter_text_to_cell
+from libreoffice.calc.document import get_cell_by_position
+from libreoffice.uno.propertyvalue import mkPropertyValues
+# import org.libreoffice.unotest
+# import pathlib
+from uitest.path import get_srcdir_url
+#Bug 113979 - Paste unformated text does not ignore empty cells
+def get_url_for_data_file(file_name):
+#return 
pathlib.Path(org.libreoffice.unotest.makeCopyFromTDOC(file_name)).as_uri()
+return get_srcdir_url() + "/sc/qa/uitest/calc_tests/data/" + file_name
+
+class standardFilter(UITestCase):
+def test_standard_filter(self):
+calc_doc = 
self.ui_test.load_file(get_url_for_data_file("standardFilter.ods"))
+xCalcDoc = self.xUITest.getTopFocusWindow()
+gridwin = xCalcDoc.getChild("grid_window")
+document = self.ui_test.get_component()
+gridwin.executeAction("SELECT", mkPropertyValues({"RANGE": "A1:C8"}))
+
+
self.ui_test.execute_modeless_dialog_through_command(".uno:DataFilterStandardFilter")
+xDialog = self.xUITest.getTopFocusWindow()
+xfield1 = xDialog.getChild("field1")
+xval1 = xDialog.getChild("val1")
+xconnect2 = xDialog.getChild("connect2")
+xfield2 = xDialog.getChild("field2")
+xval2 = xDialog.getChild("val2")
+
+props = {"TEXT": "a"}
+actionProps = mkPropertyValues(props)
+xfield1.executeAction("SELECT", actionProps)
+xval1.executeAction("TYPE", mkPropertyValues({"TEXT":"1"}))
+propsA = {"TEXT": "OR"}
+actionPropsA = mkPropertyValues(propsA)
+xconnect2.executeAction("SELECT", actionPropsA)
+props2 = {"TEXT": "b"}
+actionProps2 = mkPropertyValues(props2)
+xfield2.executeAction("SELECT", actionProps2)
+xval2.executeAction("TYPE", mkPropertyValues({"TEXT":"3"}))
+xOKBtn = xDialog.getChild("ok")
+self.ui_test.close_dialog_through_button(xOKBtn)
+#3x down - should be on row 9
+gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "A1"}))
+gridwin.executeAction("TYPE", mkPropertyValues({"KEYCODE": "DOWN"}))
+gridwin.executeAction("TYPE", mkPropertyValues({"KEYCODE": "DOWN"}))
+gridwin.executeAction("TYPE", mkPropertyValues({"KEYCODE": "DOWN"}))
+gridWinState = get_state_as_dict(gridwin)
+self.assertEqual(gridWinState["CurrentRow"], "8")
+#reopen filter and verify
+gridwin.executeAction("TYPE", mkPropertyValues({"KEYCODE": "UP"}))
+gridwin.executeAction("TYPE", mkPropertyValues({"KEYCODE": "UP"}))
+gridwin.executeAction("TYPE", mkPropertyValues({"KEYCODE": "UP"}))
+
self.ui_test.execute_modeless_dialog_through_command(".uno:DataFilterStandardFilter")
+xDialog = self.xUITest.getTopFocusWindow()
+xfield1 = xDialog.getChild("field1")
+xval1 = xDialog.getChild("val1")
+xconnect2 = xDialog.getChild("connect2")
+xfield2 = xDialog.getChild("field2")
+xval2 = xDialog.getChild("val2")
+
+self.assertEqual(get_state_as_dict(xfield1)["SelectEntryText"], "a")
+self.assertEqual(get_state_as_dict(xfield2)["SelectEntryText"], "b")
+self.assertEqual(get_state_as_dict(xconnect2)["SelectEntryText"], "OR")
+self.assertEqual(get_state_as_dict(xval1)["Text"], "1")
+self.assertEqual(get_state_as_dict(xval2)["Text"], "3")
+xOKBtn = xDialog.getChild("ok")
+self.ui_test.close_dialog_through_button(xOKBtn)
+

[Libreoffice-bugs] [Bug 116980] FIREBIRD: Migration: No migration possible with data in tables and declared realtionship

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116980

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||7298

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - include/sfx2 include/svx include/vcl sc/inc sc/source sc/uiconfig sfx2/source sfx2/uiconfig vcl/source vcl/unx

[Caolán McNamara]

 include/sfx2/checkin.hxx |   28 -
 include/sfx2/tabdlg.hxx  |1 
 include/svx/langbox.hxx  |2 
 include/vcl/layout.hxx   |3 
 include/vcl/scrbar.hxx   |1 
 include/vcl/weld.hxx |2 
 sc/inc/scabstdlg.hxx |2 
 sc/source/ui/attrdlg/scdlgfact.cxx   |   36 +-
 sc/source/ui/attrdlg/scdlgfact.hxx   |   20 +
 sc/source/ui/dbgui/sortdlg.cxx   |4 
 sc/source/ui/dbgui/sortkeydlg.cxx|  112 --
 sc/source/ui/dbgui/tpsort.cxx|  528 ++-
 sc/source/ui/inc/sortdlg.hxx |4 
 sc/source/ui/inc/sortkeydlg.hxx  |   53 ---
 sc/source/ui/inc/tpsort.hxx  |   88 ++---
 sc/source/ui/view/cellsh2.cxx|2 
 sc/uiconfig/scalc/ui/sortcriteriapage.ui |3 
 sc/uiconfig/scalc/ui/sortdialog.ui   |   80 +++-
 sc/uiconfig/scalc/ui/sortkey.ui  |   11 
 sc/uiconfig/scalc/ui/sortoptionspage.ui  |   26 -
 sfx2/source/dialog/checkin.cxx   |   30 -
 sfx2/source/dialog/tabdlg.cxx|   15 
 sfx2/source/doc/objserv.cxx  |6 
 sfx2/uiconfig/ui/checkin.ui  |   43 +-
 vcl/source/app/salvtables.cxx|   34 +
 vcl/source/control/combobox.cxx  |   11 
 vcl/source/window/layout.cxx |8 
 vcl/unx/gtk3/gtk3gtkinst.cxx |   12 
 28 files changed, 586 insertions(+), 579 deletions(-)

New commits:
commit 52eb2804bb4403e74483ee49bfcb4539065d7143
Author: Caolán McNamara 
Date:   Fri May 18 13:20:07 2018 +0100

weld ScSortDlg, ScTabPageSortOptions and ScTabPageSortFields

Change-Id: I103e5e3670f8c95c1f480ce0c36e08c3de74e900
Reviewed-on: https://gerrit.libreoffice.org/54541
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/include/sfx2/tabdlg.hxx b/include/sfx2/tabdlg.hxx
index 51e30e4c0d40..9da02d5c371e 100644
--- a/include/sfx2/tabdlg.hxx
+++ b/include/sfx2/tabdlg.hxx
@@ -244,6 +244,7 @@ private:
 std::unique_ptr   m_pOutSet;
 std::unique_ptr< TabDlg_Impl >m_pImpl;
 sal_uInt16* m_pRanges;
+OString m_sAppPageId;
 
 DECL_DLLPRIVATE_LINK(ActivatePageHdl, const OString&, void);
 DECL_DLLPRIVATE_LINK(DeactivatePageHdl, const OString&, bool);
diff --git a/include/svx/langbox.hxx b/include/svx/langbox.hxx
index 3b91701f8df9..848d93a2de72 100644
--- a/include/svx/langbox.hxx
+++ b/include/svx/langbox.hxx
@@ -157,7 +157,6 @@ private:
 bool m_bLangNoneIsLangAll;
 
 SVX_DLLPRIVATE int ImplTypeToPos(LanguageType eType) const;
-SVX_DLLPRIVATE void InsertLanguage(const LanguageType nLangType);
 SVX_DLLPRIVATE void ImplClear();
 DECL_LINK(ChangeHdl, weld::ComboBoxText&, void);
 public:
@@ -165,6 +164,7 @@ public:
 voidSetLanguageList( SvxLanguageListFlags nLangList,
 bool bHasLangNone, bool bLangNoneIsLangAll = false 
);
 voidAddLanguages( const std::vector< LanguageType >& 
rLanguageTypes, SvxLanguageListFlags nLangList );
+voidInsertLanguage(const LanguageType nLangType);
 voidSelectLanguage( const LanguageType eLangType );
 LanguageTypeGetSelectedLanguage() const;
 voidSelectEntryPos(int nPos) { m_xControl->set_active(nPos); }
diff --git a/include/vcl/layout.hxx b/include/vcl/layout.hxx
index 31ff24e2d2ee..6423d12488b9 100644
--- a/include/vcl/layout.hxx
+++ b/include/vcl/layout.hxx
@@ -507,10 +507,13 @@ class VCL_DLLPUBLIC VclViewport : public VclBin
 public:
 VclViewport(vcl::Window *pParent)
 : VclBin(pParent, WB_HIDE | WB_CLIPCHILDREN)
+, m_bInitialAllocation(true)
 {
 }
 protected:
 virtual void setAllocation(const Size ) override;
+private:
+bool m_bInitialAllocation;
 };
 
 //Enforces that its children are always the same size as itself.
diff --git a/include/vcl/scrbar.hxx b/include/vcl/scrbar.hxx
index db4d2ee9273c..5fadfb5fbe0d 100644
--- a/include/vcl/scrbar.hxx
+++ b/include/vcl/scrbar.hxx
@@ -133,6 +133,7 @@ public:
 ScrollType  GetType() const { return meScrollType; }
 
 voidSetScrollHdl( const Link& rLink ) { 
maScrollHdl = rLink; }
+const Link&   GetScrollHdl() const { return maScrollHdl; }
 voidSetEndScrollHdl( const Link& rLink ) { 
maEndScrollHdl = rLink; }
 const Link&   GetEndScrollHdl() const { return 
maEndScrollHdl; }
 
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index 423a65922796..ace717371fdd 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -120,6 +120,8 @@ public:
 = 0;
 virtual int vadjustment_get_value() const = 0;
 virtual void 

[Libreoffice-bugs] [Bug 102259] [HELP] Missing description of formula groups at Statistics tab page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102259

Olivier Hallot  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80430] [META] LOCALHELP: Features x Documentation gap

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80430
Bug 80430 depends on bug 102259, which changed state.

Bug 102259 Summary: [HELP] Missing description of formula groups at Statistics 
tab page
https://bugs.documentfoundation.org/show_bug.cgi?id=102259

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117719] add labels Minimum and Maximum for drop-down lists in dialogue Conditional Formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117719

--- Comment #5 from kompilainenn <79045_79...@mail.ru> ---
(In reply to Heiko Tietze from comment #2)
> You get what you want with "top n elements = 1" and bottom respectively
> given that the other patch is implemented. We should not overload the
> lengthy menu, so my take is WFN.

Heiko, it was my mistake. I made screenshot with not correct my comments =(
I attached new mockup with correct view

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117719] add labels Minimum and Maximum for drop-down lists in dialogue Conditional Formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117719

--- Comment #4 from kompilainenn <79045_79...@mail.ru> ---
Created attachment 142231
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142231=edit
Right mockup for this bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source

[Tor Lillqvist]

 vcl/source/window/floatwin.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c3a4937604fc296f3f6bf4dee48f224f255b9ffc
Author: Tor Lillqvist 
Date:   Mon May 21 21:49:19 2018 +0300

loplugin:staticaccess

Change-Id: I9e8accc56fc1d3b095390944a5ae2fc80bcbc05d

diff --git a/vcl/source/window/floatwin.cxx b/vcl/source/window/floatwin.cxx
index 4bffbb52b8cf..e30fd77f5c69 100644
--- a/vcl/source/window/floatwin.cxx
+++ b/vcl/source/window/floatwin.cxx
@@ -444,7 +444,7 @@ Point FloatingWindow::ImplCalcPos(vcl::Window* pWindow,
 if (pW->IsMapModeEnabled())
 *pLOKTwipsPos = pW->PixelToLogic(aPos, MapMode(MapUnit::MapTwip));
 else
-*pLOKTwipsPos = pW->LogicToLogic(aPos, pW->GetMapMode(), 
MapMode(MapUnit::MapTwip));
+*pLOKTwipsPos = OutputDevice::LogicToLogic(aPos, pW->GetMapMode(), 
MapMode(MapUnit::MapTwip));
 }
 
 // caller expects coordinates relative to top-level win
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117627] Impress shows only right side of page (twice) and renders white rectangle with hourglass over it in presentation mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117627

--- Comment #7 from directo...@gmx.de ---
(In reply to kompilainenn from comment #6)
> please add info from dialogue Help > About
> 
> I don't confirm on 
> 
> Version: 6.0.3.2
> Build ID: 8f48d515416608e3a835360314dac7e47fd0b821
> CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk2; 
> Locale: ru-RU (ru_RU.UTF-8); Calc: group
> Xubuntu 17.10 
> 
> -> Only Windows problem?

Version: 6.0.4.2 (x64)
Build-ID: 9b0d9b32d5dcda91d2f1a96dc04c645c450872bf
CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; 
Gebietsschema: de-DE (de_DE); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: officecfg/registry sd/sdi sd/source sd/uiconfig sd/UIConfig_sdraw.mk sfx2/source

[Kshitij Pathania]

 officecfg/registry/data/org/openoffice/Office/UI/ToolbarMode.xcu   |   96 
++
 officecfg/registry/schema/org/openoffice/Office/UI/ToolbarMode.xcs |5 
 sd/UIConfig_sdraw.mk   |4 
 sd/sdi/_docsh.sdi  |5 
 sd/source/ui/docshell/docshell.cxx |   15 +
 sd/uiconfig/sdraw/popupmenu/notebookbar.xml|   23 ++
 sd/uiconfig/sdraw/ui/notebookbar.ui|6 
 sd/uiconfig/sdraw/ui/notebookbar_groupedbar_compact.ui |6 
 sd/uiconfig/sdraw/ui/notebookbar_groupedbar_full.ui|6 
 sfx2/source/notebookbar/SfxNotebookBar.cxx |   10 +
 10 files changed, 173 insertions(+), 3 deletions(-)

New commits:
commit 24d43f21e92c0db040f549a226c0889db20621ac
Author: Kshitij Pathania 
Date:   Fri May 18 19:50:01 2018 +0530

Activated notebookbar in draw

Added tabbed and two groupedbars mode of notebookbar.

Change-Id: I208a365139ca6c83510a73a8ffa0260b05787793
Reviewed-on: https://gerrit.libreoffice.org/54547
Tested-by: Jenkins 
Reviewed-by: Szymon Kłos 

diff --git a/officecfg/registry/data/org/openoffice/Office/UI/ToolbarMode.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/ToolbarMode.xcu
index 64959d508520..adf337557450 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/ToolbarMode.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/ToolbarMode.xcu
@@ -10,6 +10,9 @@
   
 notebookbar.ui
   
+  
+notebookbar.ui
+  
   
 
   
@@ -679,6 +682,99 @@
 Arrow
   
 
+
+  
+Tabbed
+  
+  
+true
+  
+  
+true
+  
+  
+1
+  
+  
+notebookbar.ui
+  
+  
+
+
+  
+  
+
+
+  
+  
+Arrow
+  
+  
+true
+  
+
+
+  
+Groupedbar Compact
+  
+  
+true
+  
+  
+true
+  
+  
+8
+  
+  
+notebookbar_groupedbar_compact.ui
+  
+  
+
+
+  
+  
+
+
+  
+  
+Arrow
+  
+  
+true
+  
+
+
+  
+Groupedbar
+  
+  
+true
+  
+  
+true
+  
+  
+7
+  
+  
+notebookbar_groupedbar_full.ui
+  
+  
+
+
+  
+  
+
+
+  
+  
+Arrow
+  
+  
+true
+  
+
   
 
 
diff --git a/officecfg/registry/schema/org/openoffice/Office/UI/ToolbarMode.xcs 
b/officecfg/registry/schema/org/openoffice/Office/UI/ToolbarMode.xcs
index d641e80afb5e..f97ec55e2dc8 100644
--- a/officecfg/registry/schema/org/openoffice/Office/UI/ToolbarMode.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/UI/ToolbarMode.xcs
@@ -113,6 +113,11 @@
 Contains name of currently used implementation in the Impress 
module.
   
 
+
+  
+Contains name of currently used implementation in the Draw 
module.
+  
+
 
   
 Contains list of toolbar mode settings for each 
application.
diff --git a/sd/UIConfig_sdraw.mk b/sd/UIConfig_sdraw.mk
index 0091db50ddd8..a172013a70dd 100644
--- a/sd/UIConfig_sdraw.mk
+++ b/sd/UIConfig_sdraw.mk
@@ -32,6 +32,7 @@ $(eval $(call gb_UIConfig_add_popupmenufiles,modules/sdraw,\
sd/uiconfig/sdraw/popupmenu/measure \
sd/uiconfig/sdraw/popupmenu/media \
sd/uiconfig/sdraw/popupmenu/multiselect \
+   sd/uiconfig/sdraw/popupmenu/notebookbar \
sd/uiconfig/sdraw/popupmenu/oleobject \
sd/uiconfig/sdraw/popupmenu/outlinetext \
sd/uiconfig/sdraw/popupmenu/pagepanemaster \
@@ -111,6 +112,9 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/sdraw,\
sd/uiconfig/sdraw/ui/insertlayer \
sd/uiconfig/sdraw/ui/insertslidesdialog \
sd/uiconfig/sdraw/ui/namedesign \
+   sd/uiconfig/sdraw/ui/notebookbar \
+   sd/uiconfig/sdraw/ui/notebookbar_groupedbar_compact \
+   sd/uiconfig/sdraw/ui/notebookbar_groupedbar_full \
sd/uiconfig/sdraw/ui/paranumberingtab \
sd/uiconfig/sdraw/ui/queryunlinkimagedialog \
sd/uiconfig/sdraw/ui/vectorize \
diff --git a/sd/sdi/_docsh.sdi b/sd/sdi/_docsh.sdi
index ce225b38d922..29db81db02d2 100644
--- a/sd/sdi/_docsh.sdi
+++ 

[Libreoffice-bugs] [Bug 117659] Font looks ugly at chart when rotated

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117659

Adolfo Jayme  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||f...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #2 from Adolfo Jayme  ---
A screenshot is also helpful when reporting rendering issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117650] UI Impress: Overlapping Items in Animation Object List

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117650

--- Comment #9 from directo...@gmx.de ---
Created attachment 142230
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142230=edit
The presentation mode bug when Open GL is disactivated (enabling it solves this
problem)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117650] UI Impress: Overlapping Items in Animation Object List

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117650

--- Comment #8 from directo...@gmx.de ---
(In reply to kompilainenn from comment #4)
> please disable OpenGL in dialogue Options (Tools-Options, to left select
> LibreOffice-View, to right disable option "All rendering OpenGL"
> and try look to your problem

The problem is: if I disactivate Open GL I struggle with another bug, which
makes the presentation mode basically unusable. I posted this here, too. I will
also add a screenshot of that one, so you can see what I mean.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: bin/check-elf-dynamic-objects

[Michael Stahl]

 bin/check-elf-dynamic-objects |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 82e9d2e68fcb2f66b78501f3613386ac1e36aae7
Author: Michael Stahl 
Date:   Sun May 20 13:20:44 2018 +0200

check-elf-dynamic-objects: Fedora 28 GTK+ depends on libfribidi.so.0

... so add it to whitelists.

Change-Id: Ia9f55ecfa9dcbc809827070e0ae6522f1e7ba2bf
Reviewed-on: https://gerrit.libreoffice.org/54607
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/bin/check-elf-dynamic-objects b/bin/check-elf-dynamic-objects
index ea2d67e31ff4..1a11e6dca223 100755
--- a/bin/check-elf-dynamic-objects
+++ b/bin/check-elf-dynamic-objects
@@ -68,8 +68,8 @@ openglwhitelist="libGL.so.1"
 giowhitelist="libgio-2.0.so.0 libgobject-2.0.so.0 libgmodule-2.0.so.0 
libgthread-2.0.so.0 libglib-2.0.so.0 libdbus-glib-1.so.2 libdbus-1.so.3"
 gstreamer010whitelist="libgstpbutils-0.10.so.0 libgstinterfaces-0.10.so.0 
libgstreamer-0.10.so.0"
 gstreamerwhitelist="libgstpbutils-1.0.so.0 libgstvideo-1.0.so.0 
libgstbase-1.0.so.0 libgstreamer-1.0.so.0"
-gtk2whitelist="libgtk-x11-2.0.so.0 libgdk-x11-2.0.so.0 libpangocairo-1.0.so.0 
libatk-1.0.so.0 libcairo.so.2 libgio-2.0.so.0 libpangoft2-1.0.so.0 
libpango-1.0.so.0 libfontconfig.so.1 libfreetype.so.6 libgdk_pixbuf-2.0.so.0 
libgobject-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgthread-2.0.so.0 
libdbus-glib-1.so.2 libdbus-1.so.3"
-gtk3whitelist="libgtk-3.so.0 libgdk-3.so.0 libcairo-gobject.so.2 
libpangocairo-1.0.so.0 libatk-1.0.so.0 libcairo.so.2 libgio-2.0.so.0 
libpangoft2-1.0.so.0 libpango-1.0.so.0 libfontconfig.so.1 libfreetype.so.6 
libgdk_pixbuf-2.0.so.0 libgobject-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 
libgthread-2.0.so.0 libdbus-glib-1.so.2 libdbus-1.so.3"
+gtk2whitelist="libgtk-x11-2.0.so.0 libgdk-x11-2.0.so.0 libpangocairo-1.0.so.0 
libfribidi.so.0 libatk-1.0.so.0 libcairo.so.2 libgio-2.0.so.0 
libpangoft2-1.0.so.0 libpango-1.0.so.0 libfontconfig.so.1 libfreetype.so.6 
libgdk_pixbuf-2.0.so.0 libgobject-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 
libgthread-2.0.so.0 libdbus-glib-1.so.2 libdbus-1.so.3"
+gtk3whitelist="libgtk-3.so.0 libgdk-3.so.0 libcairo-gobject.so.2 
libpangocairo-1.0.so.0 libfribidi.so.0 libatk-1.0.so.0 libcairo.so.2 
libgio-2.0.so.0 libpangoft2-1.0.so.0 libpango-1.0.so.0 libfontconfig.so.1 
libfreetype.so.6 libgdk_pixbuf-2.0.so.0 libgobject-2.0.so.0 libglib-2.0.so.0 
libgmodule-2.0.so.0 libgthread-2.0.so.0 libdbus-glib-1.so.2 libdbus-1.so.3"
 kde4whitelist="libkio.so.5 libkfile.so.4 libkdeui.so.5 libkdecore.so.5 
libQtNetwork.so.4 libQtGui.so.4 libQtCore.so.4 libglib-2.0.so.0"
 qt5whitelist="libQt5Core.so.5 libQt5Gui.so.5 libQt5Network.so.5 
libQt5Widgets.so.5 libQt5X11Extras.so.5 libcairo.so.2 libglib-2.0.so.0"
 kf5whitelist="libKF5ConfigCore.so.5 libKF5CoreAddons.so.5 libKF5I18n.so.5 
libKF5KIOCore.so.5 libKF5KIOFileWidgets.so.5 libKF5KIOWidgets.so.5 
libKF5WindowSystem.so.5"
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117690] Add Notebookbar UI files to the Chart Editing UI to create Tabbedbars and Groupedbars for those toolbars

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117690

--- Comment #2 from Pedro  ---
Andreas,

needed commands to do chart editing are here:

https://opengrok.libreoffice.org/xref/core/chart2/uiconfig/toolbar/toolbar.xml



Szymon mentioned the following:

- You just have to edit notebookbar.ui file from calc directory using glade and
put these commands in the current Tabbed bar/Groupedbar "Object" tab.

- this should be implemented in the existing ui files. As you can see
notebookbar was switched to the tab "Object". Unfortunately we can't detect
what type of object is currently selected I think.
But we can put some functions from mentioned toolbars in this place (object
tab_

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117730] New: LibO is trying a little to hard to import a non-supported file: like mp3 (hang)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117730

Bug ID: 117730
   Summary: LibO is trying a little to hard to import a
non-supported file: like mp3 (hang)
   Product: LibreOffice
   Version: 4.4.7.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: filters and storage
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
I clicked a MP3 file by accident. Locks LibO

Steps to Reproduce:
1. Open a mp3 file with LibreOffice

Actual Results:  
Hang

Expected Results:
Some sort of prevention? A warning opening for opening non-support file (based
on extension or file-header)



Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.1.0.0.alpha1+ (x64)
Build ID: e1a8338876bd161de4e9d9a4b22d4bc5335f7cee
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-05-18_23:55:37
Locale: nl-NL (nl_NL); Calc: CL


User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101
Firefox/52.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117650] UI Impress: Overlapping Items in Animation Object List

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117650

--- Comment #7 from directo...@gmx.de ---
Created attachment 142229
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142229=edit
Text Scaling settings (?)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117650] UI Impress: Overlapping Items in Animation Object List

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117650

--- Comment #6 from directo...@gmx.de ---
(In reply to Aron Budea from comment #3)
> A random thought, do you have text scaling set in Windows?

I am not quite sure how to enable or disable that.
All I know is that in the display settings the scaling is set to 200%. I added
a screenshot of that. Is this what you mean?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117428] add an option to PDF export dialog to do ActualText per word

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117428
Bug 117428 depends on bug 117533, which changed state.

Bug 117533 Summary: Problems with copying text from generated PDF (for Graphite 
font)
https://bugs.documentfoundation.org/show_bug.cgi?id=117533

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 117428] add an option to PDF export dialog to do ActualText per word

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117428
Bug 117428 depends on bug 117533, which changed state.

Bug 117533 Summary: Problems with copying text from generated PDF (for Graphite 
font)
https://bugs.documentfoundation.org/show_bug.cgi?id=117533

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 117533] Problems with copying text from generated PDF ( for Graphite font)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117533

Khaled Hosny  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INVALID

--- Comment #5 from Khaled Hosny  ---
That is a PDF reader bug, then.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71732
Bug 71732 depends on bug 117533, which changed state.

Bug 117533 Summary: Problems with copying text from generated PDF (for Graphite 
font)
https://bugs.documentfoundation.org/show_bug.cgi?id=117533

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Takeshi Abe]

 sw/source/core/doc/DocumentFieldsManager.cxx |5 +++--
 sw/source/filter/html/htmlfld.cxx|5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

New commits:
commit 338d5f14ba3e77286c3447fb0bcbf46b0627a35f
Author: Takeshi Abe 
Date:   Mon May 21 19:01:02 2018 +0900

sw: Ask current datetime only once

Change-Id: I99bed9a09ed1701ce441ddb0a19b5259ab37f135
Reviewed-on: https://gerrit.libreoffice.org/54621
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sw/source/core/doc/DocumentFieldsManager.cxx 
b/sw/source/core/doc/DocumentFieldsManager.cxx
index b4b3c0b32d80..9d56929ff792 100644
--- a/sw/source/core/doc/DocumentFieldsManager.cxx
+++ b/sw/source/core/doc/DocumentFieldsManager.cxx
@@ -1336,8 +1336,9 @@ void DocumentFieldsManager::SetFixFields( const DateTime* 
pNewDateTime )
 }
 else
 {
-nDate = Date( Date::SYSTEM ).GetDate();
-nTime = tools::Time( tools::Time::SYSTEM ).GetTime();
+DateTime aDateTime( DateTime::SYSTEM );
+nDate = aDateTime.GetDate();
+nTime = aDateTime.GetTime();
 }
 
 SwFieldIds const aTypes[] {
diff --git a/sw/source/filter/html/htmlfld.cxx 
b/sw/source/filter/html/htmlfld.cxx
index 568f36576a84..53a7b1b435ab 100644
--- a/sw/source/filter/html/htmlfld.cxx
+++ b/sw/source/filter/html/htmlfld.cxx
@@ -320,8 +320,9 @@ void SwHTMLParser::NewField()
 case SwFieldIds::Time:
 {
 sal_uInt32 nNumFormat = 0;
-sal_Int64 nTime = tools::Time( tools::Time::SYSTEM ).GetTime();
-sal_Int32 nDate = Date( Date::SYSTEM ).GetDate();
+DateTime aDateTime( DateTime::SYSTEM );
+sal_Int64 nTime = aDateTime.GetTime();
+sal_Int32 nDate = aDateTime.GetDate();
 sal_uInt16 nSub = 0;
 bool bValidFormat = false;
 HTMLNumFormatTableEntry * pFormatTable;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117728] New: La correction orthographique ne fonctionne pas

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117728

Bug ID: 117728
   Summary: La correction orthographique ne fonctionne pas
   Product: LibreOffice
   Version: 5.4.7.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: trivial
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jefcomp...@yahoo.fr

Description:
Bonjour,
Je suis un nouvel utilisateur de Libre Office, je l'ai téléchargé car la
dernière update de Windows 10 n'autorise dorénavant plus, apparemment, l'usage
de Word 2000 qui plante de manière parfaitement aléatoire lorsqu'on écrit.
J'ai remarqué que la correction orthographique de Libre Office semblait
présenter un gros défaut, en fait, paraît inutilisable. Si la correction
orthographique automatique usuelle fonctionne bien, lorsqu'on tente d'utiliser
la fonction 'Orthographe et grammaire' on tombe sur un message qui indique "
Continuer la vérification au début du document " lorsqu'on clique 'Oui' rien ne
se passe. Par ailleurs impossible de sélectionner une langue dans la liste du
dessus, elle ne s'affiche pas, la rubrique affiche " Aucune ".
J'ai désinstaller le logiciel et l'ai résintallé mais le problème persiste
Merci


Actual Results:  
Lorsque je lance la fonction Orthographe et grammaire tout simplement

Expected Results:
Rien ne fonctionne


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: fr
Module: TextDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 Edge/17.17134

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117727] New: Dragging a fontwork over the sunset template is rather slow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117727

Bug ID: 117727
   Summary: Dragging a fontwork over the sunset template is rather
slow
   Product: LibreOffice
   Version: 6.0.0.1 rc
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Dragging a fontwork over the sunset template is rather slow

Steps to Reproduce:
1. Open Impress
2. Apply the sunset slide template (similar for focus template)
3. Insert a fontwork
4. Drag it around & monitor CPU

Actual Results:  
Really slow

Expected Results:
Fast


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.1.0.0.alpha1+ (x64)
Build ID: e1a8338876bd161de4e9d9a4b22d4bc5335f7cee
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-05-18_23:55:37
Locale: nl-NL (nl_NL); Calc: CL


User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101
Firefox/52.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117719] add labels Minimum and Maximum for drop-down lists in dialogue Conditional Formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117719

--- Comment #3 from Mike Kaganski  ---
(In reply to Heiko Tietze from comment #2)
> You get what you want with "top n elements = 1" and bottom respectively
> given that the other patch is implemented. We should not overload the
> lengthy menu, so my take is WFN.

I am sorry: IIUC, OP doesn't suggest adding something to the drop-down menu:
his proposal is to add labels next to drop-downs that would say something like
(referring to the screenshot he provided):

"Min: [Automatic ][V] Max: [Automatic][V]"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117715] Unlike other settings, Number Format in a conditional formatting style doesn' t apply if a cell has a number format applied by direct formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117715

Mike Kaganski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from Mike Kaganski  ---
Reproducible with Version: 6.1.0.0.alpha1+ (x64)
Build ID: db04be037b611e296ef9f2542322c52ed82d7a2b
CPU threads: 12; OS: Windows 10.0; UI render: GL; 
Locale: ru-RU (ru_RU); Calc: CL

STR:

1. Create a new empty spreadsheet
2. Put a number into A1 (e.g., 1)
3. Apply manual formatting to A1: e.g., Number format: 0 decimals; Font:
Liberation Mono size 20; Font color: Indigo; Horizontal alignment: Left;
Background: Orange.
4. Apply conditional formatting to A1: e.g., Condition: cell value greater than
0 => New style: Number formatting: Currency; Font: Liberation Serif size 8;
Font color: Red; Horizontal alignment: Center; Background: Light Lime 4.

Actual result: every setting from Conditional formatting had overwritten the
manual settings - *except for number formatting*, which is still Number 0
decimals, not Currency.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102259] [HELP] Missing description of formula groups at Statistics tab page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102259

--- Comment #4 from Commit Notification 
 ---
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/help/commit/?id=4e45182924569adab9bc43ec174b3c4c828c7452

tdf#102259 formula groups at Statistics tab page

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102259] [HELP] Missing description of formula groups at Statistics tab page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102259

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit aa8ea7d8c29a92b7b866eeb47317f79416db8eb8
Author: Olivier Hallot 
Date:   Mon May 21 09:26:51 2018 -0300

Updated core
Project: help  4e45182924569adab9bc43ec174b3c4c828c7452

tdf#102259 formula groups at Statistics tab page

Change-Id: I206139776c77e8855bd82fc5b5ffaa6c0ec60147
Reviewed-on: https://gerrit.libreoffice.org/54627
Tested-by: Jenkins 
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 1d9b92c466b2..4e4518292456 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 1d9b92c466b2b920ff46987d1668f4494b9f743a
+Subproject commit 4e45182924569adab9bc43ec174b3c4c828c7452
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Olivier Hallot]

 source/text/shared/01/01100400.xhp |   38 +++--
 1 file changed, 20 insertions(+), 18 deletions(-)

New commits:
commit 4e45182924569adab9bc43ec174b3c4c828c7452
Author: Olivier Hallot 
Date:   Mon May 21 09:26:51 2018 -0300

tdf#102259 formula groups at Statistics tab page

Change-Id: I206139776c77e8855bd82fc5b5ffaa6c0ec60147
Reviewed-on: https://gerrit.libreoffice.org/54627
Tested-by: Jenkins 
Reviewed-by: Olivier Hallot 

diff --git a/source/text/shared/01/01100400.xhp 
b/source/text/shared/01/01100400.xhp
index c45e3ad56..63e0e11de 100644
--- a/source/text/shared/01/01100400.xhp
+++ b/source/text/shared/01/01100400.xhp
@@ -20,7 +20,7 @@
  -->
 
 
-   
+
 
 
 
@@ -49,43 +49,45 @@
 
   
 
-Some statistic values can be used as 
variables in formulas. 
+Some statistic values can be used as 
variables in formulas.
 
 Pages:
 Number of 
pages in the file.
 Tables:Sheets:
-Number of tables in the file. 
-Number of sheets in the file. 
+Number of tables in the file.
+Number of sheets in the file.
  This statistic does not include tables that were 
inserted as OLE 
objects.
 Cells:
-Number of cells with content in the 
file. 
+Number of cells with content in the 
file.
 
-Images: 
+Formula 
groups:
+Number 
of contigous ranges in a column with same 
formula.
+Images:
 
-Number of images in the file. This 
statistic does not include images that were inserted as OLE objects. 
+Number of images in the file. This 
statistic does not include images that were inserted as OLE objects.
 
-OLE Objects: 
+OLE Objects:
 
-Number of OLE objects in the 
file, including tables and graphics that were inserted as OLE objects. 
+Number of OLE objects in the 
file, including tables and graphics that were inserted as OLE objects.
 
-Paragraphs: 
+Paragraphs:
 
-Number of paragraphs (including blank 
paragraphs) in the file. 
+Number of paragraphs (including blank 
paragraphs) in the file.
 
-Words: 
+Words:
 
-Number of words (including words 
consisting of a single character) in the file. 
+Number of words (including words 
consisting of a single character) in the file.
 
-Characters: 
+Characters:
 
-Number of characters (including 
spaces) in the file. Non-printable characters are not included. 
+Number of characters (including 
spaces) in the file. Non-printable characters are not included.
 
-Lines: 
+Lines:
 
-Number of lines in the file. 
+Number of lines in the file.
 
 
-Update 
+Update
 
 Updates the 
statistics.
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117723] Writer crashes every time with a certain large file FILEOPEN

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117723

Telesto  changed:

   What|Removed |Added

   Keywords||bibisectRequest
 CC||tele...@surfxs.nl
 OS|Linux (All) |All

--- Comment #3 from Telesto  ---
Repro with
Version: 6.1.0.0.alpha1+ (x64)
Build ID: e1a8338876bd161de4e9d9a4b22d4bc5335f7cee
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-05-18_23:55:37
Locale: nl-NL (nl_NL); Calc: CL

no repro with
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117719] add labels Minimum and Maximum for drop-down lists in dialogue Conditional Formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117719

--- Comment #2 from Heiko Tietze  ---
You get what you want with "top n elements = 1" and bottom respectively given
that the other patch is implemented. We should not overload the lengthy menu,
so my take is WFN.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107870] View jumps to cursor when activating or deactivating record changes and showing or hiding changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107870

--- Comment #3 from Alej  ---
Confirmed bug in LO 6.0.4. View jumps to cursor when activating or deactivating
record changes and showing or hiding changes.

View jumps to cursor when activating or deactivating record changes and showing
or hiding changes

Versión: 6.0.4.2
Id. de compilación: 9b0d9b32d5dcda91d2f1a96dc04c645c450872bf
Subprocs. CPU: 8; SO: Linux 3.16; Repres. IU: predet.; VCL: kde4; 
Configuración regional: es-AR (es_AR.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117049] Severe bug in LibreOffice (Calc Speadsheet)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117049

sarti_ca...@yahoo.com  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117657] Hotkey for fullscreen works only one way

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117657

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||jbfa...@libreoffice.org

--- Comment #3 from Jean-Baptiste Faure  ---
Not reproducible for me with the same version on Ubuntu 16.04 (64 bits).

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100894] FILEOPEN FILESAVE IMPORT Conditional formatting: xls file with a lot of Conditional formatting freeze Calc when opening Styles sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100894

--- Comment #10 from Buovjaga  ---
(In reply to Timur from comment #8)
> Could we make it a duplicate of Bug 61484?

Just to confirm, this is different from bug 61484, because the xls in bug 61484
takes a long time for me to open on Linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117688] The problem of increased use of memory when linking with csv file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117688

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||jbfa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Jean-Baptiste Faure  ---
Your bug description does not give enough information to reproduce it.
Please attach test files and explain, step by step, what we have to do to
reproduce the problem.

Status set to NEEDINFO, please set it back to UNCONFIRMED once requested
informations are provided.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103791] ORG-MODE for LIBREOFFICE

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103791

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||ed...@openmail.cc

--- Comment #5 from Jean-Baptiste Faure  ---
*** Bug 117709 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117709] Export and import to and from Org (Emacs org-mode)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117709

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||jbfa...@libreoffice.org
 Resolution|--- |DUPLICATE

--- Comment #1 from Jean-Baptiste Faure  ---
I agree, it is the same enhancement request as bug 103791.

Best regards. JBF

*** This bug has been marked as a duplicate of bug 103791 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100894] FILEOPEN FILESAVE IMPORT Conditional formatting: xls file with a lot of Conditional formatting freeze Calc when opening Styles sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100894

Buovjaga  changed:

   What|Removed |Added

Summary|FILEOPEN FILESAVE IMPORT|FILEOPEN FILESAVE IMPORT
   |Conditional formatting: xls |Conditional formatting: xls
   |file with a lot of  |file with a lot of
   |Conditional formatting  |Conditional formatting
   |freeze Calc |freeze Calc when opening
   ||Styles sidebar

--- Comment #9 from Buovjaga  ---
(In reply to Timur from comment #8)
> Could we make it a duplicate of Bug 61484?

Dunno, Maxim's file opens pretty fast for me in master, but F11 still makes it
freeze.

Arch Linux 64-bit
Version: 6.1.0.0.alpha1+
Build ID: 21b11273ae91f0cf7fd5f3f9fd2168e4349852c4
CPU threads: 8; OS: Linux 4.16; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on May 11th 2018

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117711] select all moves cursor to the end of the document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117711

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||jbfa...@libreoffice.org

--- Comment #1 from Jean-Baptiste Faure  ---
I reproduce this behavior, but I am not sure if it is a defect.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113046] renaming a style

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113046

--- Comment #3 from Stefano Bordoni  ---
still present into v6.0.4.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116980] FIREBIRD: Migration: No migration possible with data in tables and declared realtionship

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116980

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #12 from Julien Nabet  ---
Nitpick: testing tdf#117298 and the pb of time value, I noticed that in "Simple
example, only 2 tables, ...", the converted day in Persons table is wrong.
Indeed, I got a difference of 1 day for each date.
So instead of:
- 03.07.88
- 17.09.67
- 13.03.66

I got:
- 02.07.88
- 16.09.67
- 12.03.66
after FB migration.
Wonder if the pb has the same root cause.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117724] View Formula shortcut is not shown properly in menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117724

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||jbfa...@libreoffice.org
 Resolution|--- |DUPLICATE

--- Comment #1 from Jean-Baptiste Faure  ---
Already tracked in bug 103388

Best regards. JBF

*** This bug has been marked as a duplicate of bug 103388 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103388] UI: "View > Show Formula" shows the shortcut as "Ctrl+grave"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103388

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||vasoserg...@gmail.com

--- Comment #13 from Jean-Baptiste Faure  ---
*** Bug 117724 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/inc sw/source

[Bjoern Michaelsen]

 sw/inc/fmtrfmrk.hxx |1 
 sw/source/core/unocore/unorefmk.cxx |   63 
 2 files changed, 30 insertions(+), 34 deletions(-)

New commits:
commit 0c02f3c5d64bd6db96db0302169fb4c4b48dc27e
Author: Bjoern Michaelsen 
Date:   Thu May 10 10:51:42 2018 +0200

dont use SwClient/SwModify in unocore: RefMark

Change-Id: I021f410793c9debfe5e984d591144636d6793fd6
Reviewed-on: https://gerrit.libreoffice.org/54610
Tested-by: Jenkins 
Reviewed-by: Björn Michaelsen 

diff --git a/sw/inc/fmtrfmrk.hxx b/sw/inc/fmtrfmrk.hxx
index 9248e7353f84..b235961baf5b 100644
--- a/sw/inc/fmtrfmrk.hxx
+++ b/sw/inc/fmtrfmrk.hxx
@@ -36,6 +36,7 @@ class SwTextRefMark;
 class SwFormatRefMark
 : public SfxPoolItem
 , public SwModify
+, public sw::BroadcasterMixin
 {
 friend class SwTextRefMark;
 SwTextRefMark* m_pTextAttr;
diff --git a/sw/source/core/unocore/unorefmk.cxx 
b/sw/source/core/unocore/unorefmk.cxx
index 8560ef0ee8e9..162cb004cd45 100644
--- a/sw/source/core/unocore/unorefmk.cxx
+++ b/sw/source/core/unocore/unorefmk.cxx
@@ -18,13 +18,16 @@
  */
 
 #include 
-#include 
-
 #include 
 
-#include 
 #include 
+#include 
+#include 
 #include 
+#include 
+#include 
+#include 
+#include 
 #include 
 
 #include 
@@ -39,7 +42,13 @@
 #include 
 #include 
 #include 
-#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
 #include 
 #include 
 #include 
@@ -47,21 +56,12 @@
 #include 
 #include 
 #include 
-#include 
 #include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-
 
 using namespace ::com::sun::star;
 
 class SwXReferenceMark::Impl
-: public SwClient
+: public SvtListener
 {
 private:
 ::osl::Mutex m_Mutex; // just for OInterfaceContainerHelper2
@@ -69,30 +69,29 @@ private:
 public:
 uno::WeakReference m_wThis;
 ::comphelper::OInterfaceContainerHelper2 m_EventListeners;
-boolm_bIsDescriptor;
-SwDoc * m_pDoc;
-const SwFormatRefMark *m_pMarkFormat;
-OUString m_sMarkName;
+bool m_bIsDescriptor;
+SwDoc* m_pDoc;
+const SwFormatRefMark* m_pMarkFormat;
+OUString m_sMarkName;
 
-Impl(   SwDoc *const pDoc, SwFormatRefMark *const pRefMark)
-: SwClient(pRefMark)
-, m_EventListeners(m_Mutex)
+Impl(SwDoc* const pDoc, SwFormatRefMark* const pRefMark)
+: m_EventListeners(m_Mutex)
 , m_bIsDescriptor(nullptr == pRefMark)
 , m_pDoc(pDoc)
 , m_pMarkFormat(pRefMark)
 {
 if (pRefMark)
 {
+StartListening(pRefMark->GetNotifier());
 m_sMarkName = pRefMark->GetRefName();
 }
 }
 
-boolIsValid() const { return nullptr != GetRegisteredIn(); }
-voidInsertRefMark( SwPaM & rPam, SwXTextCursor const*const pCursor );
-voidInvalidate();
+bool IsValid() const { return m_pMarkFormat; }
+void InsertRefMark( SwPaM & rPam, SwXTextCursor const*const pCursor );
+void Invalidate();
 protected:
-// SwClient
-virtual voidModify( const SfxPoolItem* pOld, const SfxPoolItem *pNew) 
override;
+virtual void Notify(const SfxHint&) override;
 
 };
 
@@ -110,14 +109,10 @@ void SwXReferenceMark::Impl::Invalidate()
 m_EventListeners.disposeAndClear(ev);
 }
 
-void SwXReferenceMark::Impl::Modify( const SfxPoolItem* pOld, const 
SfxPoolItem *pNew)
+void SwXReferenceMark::Impl::Notify(const SfxHint& rHint)
 {
-ClientModify(this, pOld, pNew);
-
-if (!IsValid()) // removed => dispose
-{
+if(rHint.GetId() == SfxHintId::Dying)
 Invalidate();
-}
 }
 
 SwXReferenceMark::SwXReferenceMark(
@@ -272,8 +267,8 @@ void SwXReferenceMark::Impl::InsertRefMark(SwPaM& rPam,
 }
 
 m_pMarkFormat = >GetRefMark();
-
-const_cast(m_pMarkFormat)->Add(this);
+EndListeningAll();
+StartListening(const_cast(m_pMarkFormat)->GetNotifier());
 }
 
 void SAL_CALL
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117533] Problems with copying text from generated PDF ( for Graphite font)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117533

--- Comment #4 from Volga  ---
(In reply to Khaled Hosny from comment #3)
> Which seems to differ only in the randomly introduced spaces (a known
> issue), what PDF reader did you use?
I used Sumatra PDF 3.1.2 to view PDF files.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117726] Extend formula when inserting a column or row

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117726

Jean-Baptiste Faure  changed:

   What|Removed |Added

 OS|Windows (All)   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117726] Extend formula when inserting a column or row

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117726

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||jbfa...@libreoffice.org

--- Comment #1 from Jean-Baptiste Faure  ---
Not sure if it is a good idea. What happens if you insert a row between two
different formulas?

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: reportdesign/source reportdesign/uiconfig

[Caolán McNamara]

 reportdesign/source/ui/dlg/DateTime.cxx |  143 
 reportdesign/source/ui/inc/DateTime.hxx |   39 ++---
 reportdesign/source/ui/report/ReportController.cxx  |4 
 reportdesign/uiconfig/dbreport/ui/datetimedialog.ui |   16 +-
 4 files changed, 88 insertions(+), 114 deletions(-)

New commits:
commit 4da8aef20416d0e1320a1ee455e2edc2ae61f9ac
Author: Caolán McNamara 
Date:   Mon May 21 12:05:55 2018 +0100

weld ODateTimeDialog

Change-Id: Id93147f1d442e1e5f1cfba8ef2f9e476f4f6d728
Reviewed-on: https://gerrit.libreoffice.org/54623
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/reportdesign/source/ui/dlg/DateTime.cxx 
b/reportdesign/source/ui/dlg/DateTime.cxx
index c1b4e23e01b9..69f5cd531e05 100644
--- a/reportdesign/source/ui/dlg/DateTime.cxx
+++ b/reportdesign/source/ui/dlg/DateTime.cxx
@@ -40,25 +40,20 @@ using namespace ::comphelper;
 
 // class ODateTimeDialog
 
-ODateTimeDialog::ODateTimeDialog( vcl::Window* _pParent
-   ,const uno::Reference< 
report::XSection >& _xHoldAlive
-   ,OReportController* _pController)
-: ModalDialog( _pParent, "DateTimeDialog" , 
"modules/dbreport/ui/datetimedialog.ui" )
+ODateTimeDialog::ODateTimeDialog(weld::Window* _pParent, const uno::Reference< 
report::XSection >& _xHoldAlive,
+ OReportController* _pController)
+: GenericDialogController(_pParent, 
"modules/dbreport/ui/datetimedialog.ui", "DateTimeDialog")
 
-, m_aDateControlling()
-, m_aTimeControlling()
 , m_pController(_pController)
 , m_xHoldAlive(_xHoldAlive)
+, m_xDate(m_xBuilder->weld_check_button("date"))
+, m_xFTDateFormat(m_xBuilder->weld_label("datelistbox_label"))
+, m_xDateListBox(m_xBuilder->weld_combo_box_text("datelistbox"))
+, m_xTime(m_xBuilder->weld_check_button("time"))
+, m_xFTTimeFormat(m_xBuilder->weld_label("timelistbox_label"))
+, m_xTimeListBox(m_xBuilder->weld_combo_box_text("timelistbox"))
+, m_xPB_OK(m_xBuilder->weld_button("ok"))
 {
-get(m_pDate,"date");
-get(m_pFTDateFormat,"datelistbox_label");
-get(m_pDateListBox,"datelistbox");
-get(m_pTime,"time");
-get(m_pFTTimeFormat,"timelistbox_label");
-get(m_pTimeListBox,"timelistbox");
-get(m_pPB_OK,"ok");
-
-
 try
 {
 SvtSysLocale aSysLocale;
@@ -71,60 +66,36 @@ ODateTimeDialog::ODateTimeDialog( vcl::Window* _pParent
 {
 }
 
-m_pDateListBox->SelectEntryPos(0);
-
-m_pTimeListBox->SelectEntryPos(0);
-
-// use nice enhancement, to toggle enable/disable if a checkbox is checked 
or not
-m_aDateControlling.enableOnCheckMark( *m_pDate, *m_pFTDateFormat, 
*m_pDateListBox);
-m_aTimeControlling.enableOnCheckMark( *m_pTime, *m_pFTTimeFormat, 
*m_pTimeListBox);
-
-CheckBox* aCheckBoxes[] = { m_pDate,m_pTime};
-for (CheckBox* pCheckBox : aCheckBoxes)
-pCheckBox->SetClickHdl(LINK(this,ODateTimeDialog,CBClickHdl));
+m_xDateListBox->set_active(0);
+m_xTimeListBox->set_active(0);
 
+weld::CheckButton* aCheckBoxes[] = { m_xDate.get(), m_xTime.get() };
+for (weld::CheckButton* pCheckBox : aCheckBoxes)
+pCheckBox->connect_toggled(LINK(this,ODateTimeDialog,CBClickHdl));
 }
 
-void ODateTimeDialog::InsertEntry(sal_Int16 _nNumberFormatId)
+void ODateTimeDialog::InsertEntry(sal_Int16 _nNumberFormatId)
+{
+const bool bTime = util::NumberFormat::TIME == _nNumberFormatId;
+weld::ComboBoxText* pListBox = m_xDateListBox.get();
+if (bTime)
+pListBox = m_xTimeListBox.get();
+
+const uno::Reference< util::XNumberFormatter> xNumberFormatter = 
m_pController->getReportNumberFormatter();
+const uno::Reference< util::XNumberFormats> xFormats = 
xNumberFormatter->getNumberFormatsSupplier()->getNumberFormats();
+const uno::Sequence aFormatKeys = 
xFormats->queryKeys(_nNumberFormatId,m_nLocale,true);
+const sal_Int32* pIter = aFormatKeys.getConstArray();
+const sal_Int32* pEnd  = pIter + aFormatKeys.getLength();
+for (;pIter != pEnd; ++pIter)
 {
-const bool bTime = util::NumberFormat::TIME == _nNumberFormatId;
-ListBox* pListBox = m_pDateListBox;
-if ( bTime )
-pListBox = m_pTimeListBox;
-
-const uno::Reference< util::XNumberFormatter> xNumberFormatter = 
m_pController->getReportNumberFormatter();
-const uno::Reference< util::XNumberFormats> xFormats = 
xNumberFormatter->getNumberFormatsSupplier()->getNumberFormats();
-const uno::Sequence aFormatKeys = 
xFormats->queryKeys(_nNumberFormatId,m_nLocale,true);
-const sal_Int32* pIter = aFormatKeys.getConstArray();
-const sal_Int32* pEnd  = pIter + aFormatKeys.getLength();
-for(;pIter != pEnd;++pIter)
-{
-const 

[Libreoffice-bugs] [Bug 103680] Use HarfBuzz ot-math API to parse the OpenType MATH table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103680

--- Comment #11 from Volga  ---
As a workaround, if you want to make use of mathmetical fonts in LibreOffice,
you have to install XeLaTeX firstly, then install TexMaths extension (0.46 and
newer) and configure it to call XeLaTeX for foumulas.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116840] [META] regressions introduced by trying to preserve original compressed JPEGs harder

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116840
Bug 116840 depends on bug 104479, which changed state.

Bug 104479 Summary: Export as PDF of ODT with JPGs produces much larger PDFs
https://bugs.documentfoundation.org/show_bug.cgi?id=104479

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103378
Bug 103378 depends on bug 104479, which changed state.

Bug 104479 Summary: Export as PDF of ODT with JPGs produces much larger PDFs
https://bugs.documentfoundation.org/show_bug.cgi?id=104479

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104479] Export as PDF of ODT with JPGs produces much larger PDFs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104479

Timur  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |DUPLICATE
Summary|Export as PDF produces much |Export as PDF of ODT with
   |larger PDFs |JPGs produces much larger
   ||PDFs

--- Comment #43 from Timur  ---
(In reply to Steve Edmonds from comment #14)
> Using the same file (from comment 3), 90% compression, reduced 300dpi image
> resolution.
> LO 5.0.6.3. PDF 2.5MB
> LO 5.1.6.2.0+ PDF 6.3MB
> LO 5.2.4.1 PDF 11MB

LO 6.1+ before fix: PDF 7,6 MB
LO 6.1+ after fix: PDF 2,8 MB

*** This bug has been marked as a duplicate of bug 105954 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: extensions/source

[Tor Lillqvist]

 extensions/source/ole/servprov.cxx |   25 ++---
 extensions/source/ole/servprov.hxx |   13 ++---
 2 files changed, 16 insertions(+), 22 deletions(-)

New commits:
commit 17ad73232ff604329e6532817570cb40342857e8
Author: Tor Lillqvist 
Date:   Tue Feb 13 00:08:41 2018 +0200

In fact it's simpler to not have m_guid fields in these two classes at all

We can just pass the GUID as parameter to the single member function
registerClass() that needs it. This perhaps means the same class can
be used in more cases, also for objects/classes that aren't going to
be registered and don't need any GUID.

Change-Id: I28703190c52b14236c6f613dd4acbe359c075f5c
Reviewed-on: https://gerrit.libreoffice.org/54622
Tested-by: Jenkins 
Reviewed-by: Tor Lillqvist 

diff --git a/extensions/source/ole/servprov.cxx 
b/extensions/source/ole/servprov.cxx
index 60959ae323c4..78d59292368f 100644
--- a/extensions/source/ole/servprov.cxx
+++ b/extensions/source/ole/servprov.cxx
@@ -44,9 +44,8 @@ using namespace com::sun::star::bridge::ModelDependent;
 DEFINE_GUID(OID_ServiceManager, 0x82154420, 0xfbf, 0x11d4, 0x83, 0x13, 0x0, 
0x50, 0x4, 0x52, 0x6a, 0xb4);
 
 ProviderOleWrapper::ProviderOleWrapper(const Reference& 
smgr,
-   const Reference& 
xSFact, GUID const * pGuid)
+   const Reference& 
xSFact)
 : m_xSingleServiceFactory(xSFact),
-  m_guid(*pGuid),
   m_smgr( smgr)
 {
 Reference xInt = 
smgr->createInstance("com.sun.star.bridge.oleautomation.BridgeSupplier");
@@ -63,14 +62,14 @@ ProviderOleWrapper::~ProviderOleWrapper()
 {
 }
 
-bool ProviderOleWrapper::registerClass()
+bool ProviderOleWrapper::registerClass(GUID const * pGuid)
 {
 HRESULT hresult;
 
 o2u_attachCurrentThread();
 
 hresult = CoRegisterClassObject(
-m_guid,
+*pGuid,
 this,
 CLSCTX_INPROC_SERVER | CLSCTX_LOCAL_SERVER,
 REGCLS_MULTIPLEUSE,
@@ -171,11 +170,9 @@ STDMETHODIMP ProviderOleWrapper::LockServer(int /*fLock*/)
 }
 
 OneInstanceOleWrapper::OneInstanceOleWrapper(  const 
Reference& smgr,
-   const Reference& 
xInst,
-   GUID const * pGuid )
+   const Reference& 
xInst )
 : m_refCount(0)
 , m_xInst(xInst)
-, m_guid(*pGuid)
 , m_factoryHandle(0)
 , m_smgr(smgr)
 {
@@ -192,14 +189,14 @@ OneInstanceOleWrapper::~OneInstanceOleWrapper()
 {
 }
 
-bool OneInstanceOleWrapper::registerClass()
+bool OneInstanceOleWrapper::registerClass(GUID const * pGuid)
 {
 HRESULT hresult;
 
 o2u_attachCurrentThread();
 
 hresult = CoRegisterClassObject(
-m_guid,
+*pGuid,
 this,
 CLSCTX_INPROC_SERVER | CLSCTX_LOCAL_SERVER,
 REGCLS_MULTIPLEUSE,
@@ -617,24 +614,22 @@ css::uno::Sequence 
OleServer::getSupportedServiceNames()
 
 bool OleServer::provideService(const Reference& xSFact, 
GUID const * guid)
 {
-IClassFactoryWrapper* pFac = new ProviderOleWrapper( m_smgr, xSFact, guid);
+IClassFactoryWrapper* pFac = new ProviderOleWrapper( m_smgr, xSFact );
 
 pFac->AddRef();
-
 m_wrapperList.push_back(pFac);
 
-return pFac->registerClass();
+return pFac->registerClass(guid);
 }
 
 bool OleServer::provideInstance(const Reference& xInst, GUID const 
* guid)
 {
-IClassFactoryWrapper* pFac =
-new OneInstanceOleWrapper( m_smgr, xInst, guid );
+IClassFactoryWrapper* pFac = new OneInstanceOleWrapper( m_smgr, xInst );
 
 pFac->AddRef();
 m_wrapperList.push_back(pFac);
 
-return pFac->registerClass();
+return pFac->registerClass(guid);
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/extensions/source/ole/servprov.hxx 
b/extensions/source/ole/servprov.hxx
index d7caa9785df0..f8b6ad75d2c3 100644
--- a/extensions/source/ole/servprov.hxx
+++ b/extensions/source/ole/servprov.hxx
@@ -53,7 +53,7 @@ class IClassFactoryWrapper : public IClassFactory
 {
 public:
 
-virtual bool registerClass() = 0;
+virtual bool registerClass(GUID const * pGuid) = 0;
 virtual bool deregisterClass() = 0;
 
 protected:
@@ -79,10 +79,10 @@ class ProviderOleWrapper : public IClassFactoryWrapper
 public:
 
 ProviderOleWrapper( const Reference& smgr,
-const Reference& xSFactory, 
GUID const * pGuid);
+const Reference& xSFactory);
 virtual ~ProviderOleWrapper();
 
-bool registerClass() override;
+bool registerClass(GUID const * pGuid) override;
 bool deregisterClass() override;
 
 /* IUnknown methods */
@@ -98,7 +98,6 @@ protected:
 
 oslInterlockedCount m_refCount;
 Reference m_xSingleServiceFactory;
-const GUID  m_guid;
 DWORD   

[Libreoffice-bugs] [Bug 117365] Decimal separator is not updated on language change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117365

Laurent BP  changed:

   What|Removed |Added

Version|5.4.7.1 rc  |5.2.7.2 release

--- Comment #8 from Laurent BP  ---
Reproduce with Version: 5.2.7.2
Build ID: 2b7f1e640c46ceb28adf43ee075a6e8b8439ed10
Threads CPU : 8; Version de l'OS :Linux 4.13; UI Render : par défaut; VCL :
gtk2; 
Locale : fr-FR (fr_FR.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs