[Libreoffice-bugs] [Bug 91204] Some Items of Properties Dialogue are not Current if Option “Edit document properties before saving” is Chosen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91204

--- Comment #11 from Mike Kaganski  ---
(In reply to Timur from comment #1)
> Actually, the document is saved BEFORE document properties dialog appears.

This is incorrect. And one can easily check that: while the properties dialog
still open, use a file manager to check if the file has been updated (check
file modification time); even better it's seen when a file is created/saved as:
the new file is simply absent yet.

> Solution should be either:
> - Rename "Edit document properties BEFORE saving" to "Edit document
> properties AFTER saving" and display saved properties in the  properties
> dialog OR

So - this is a wrong option (wrt that "AFTER").

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117888] UI: List Box mouse wheel scroll behavior cannot be changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117888

rob...@familiegrosskopf.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||rob...@familiegrosskopf.de
Version|6.0.4.2 release |3.6.7.2 release
 Ever confirmed|0   |1

--- Comment #1 from rob...@familiegrosskopf.de ---
Could confirm it is impossible to switch mousewheel-behavior in listboxes.

Have tested it with LO 6.0.4.2 and also LO 3.6.7.2 on OpenSUSE 42.3 64bit rpm
Linux. Could be the bug has been there all the time, inherited with OOo.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117888] UI: List Box mouse wheel scroll behavior cannot be changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117888

rob...@familiegrosskopf.de changed:

   What|Removed |Added

 OS|Windows (All)   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117892] Area tab: Bitmap preview is not shown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117892

raal  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 Status|UNCONFIRMED |NEW
 CC||qui...@gmail.com,
   ||r...@post.cz
 Ever confirmed|0   |1

--- Comment #1 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Tomaž Vajngerl ; Could you possibly take a look at this one?
Thanks

c5e18ecabec7818a55e4a887ec4fe3d6739d7c49 is the first bad commit
commit c5e18ecabec7818a55e4a887ec4fe3d6739d7c49
Author: Jenkins Build User 
Date:   Fri Apr 20 09:59:26 2018 +0200

source sha:7b355669c6ddeab2e6cec692d6afdff41c61d0fb

author  Tomaž Vajngerl  2018-04-14 15:13:05
+0900
committer   Tomaž Vajngerl2018-04-20 09:15:22
+0200
commit  7b355669c6ddeab2e6cec692d6afdff41c61d0fb (patch)
tree46c55326bccfa68a2bb5fad6d637e0f4576c8d68
parent  663fd3d6e1f93ec989dc289e688d5dbfe434cbca (diff)
Function to load graphic swapped out (loaded on demand)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112926] FREEZE with some images images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112926

Elmar  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #5 from Elmar  ---
Please see my question in post on 2017-10-10

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106892] R-CLK on incorrectly spelled word cause calc and impress to hang

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106892

Elmar  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #6 from Elmar  ---
This has been resolved in v6.1 apha

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa

[Mike Kaganski]

 sw/qa/extras/ww8export/data/tdf91083.odt |binary
 sw/qa/extras/ww8export/ww8export.cxx |2 --
 2 files changed, 2 deletions(-)

New commits:
commit b7da22a63dcf09fdcbb3fe62c82af699d8546d3b
Author: Mike Kaganski 
Date:   Sun May 6 12:01:47 2018 +0300

ww8export: Fix testTableKeep

The tables in the test .ODT contain a cell with text "With merged cells".
The text is supposed to wrap, so that cell height includes the two lines.
The width of the cell is 32.72 mm. When it is exported to .DOC, due to
rounding errors, the width becomes 32.76 mm. It happens that the text
width is too close to these numbers, so depending on rounding when text
layouting, it may start to not wrap in .DOC.

This just adds an extra space character to the line, to stop depend on
rounding errors.

This also reverts commits b2a053160c4c8eb0acd66b74c52dbda23a654bda and
a30a36b3c70e64b62add9f3c5376202b9682851f, which had workarounded this
issue.

Change-Id: Ifdb7a042f78a1a3cce3a385e9db865a1b8c7b134
Reviewed-on: https://gerrit.libreoffice.org/53906
Reviewed-by: Justin Luth 
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/sw/qa/extras/ww8export/data/tdf91083.odt 
b/sw/qa/extras/ww8export/data/tdf91083.odt
index e4f55e58acf0..482a2dc4d5d1 100644
Binary files a/sw/qa/extras/ww8export/data/tdf91083.odt and 
b/sw/qa/extras/ww8export/data/tdf91083.odt differ
diff --git a/sw/qa/extras/ww8export/ww8export.cxx 
b/sw/qa/extras/ww8export/ww8export.cxx
index d5a84b2b1ded..6659749b3c80 100644
--- a/sw/qa/extras/ww8export/ww8export.cxx
+++ b/sw/qa/extras/ww8export/ww8export.cxx
@@ -1293,7 +1293,6 @@ DECLARE_WW8EXPORT_TEST(testCommentExport, 
"comment-export.odt")
 }
 }
 
-#if !defined(MACOSX) && !defined(_WIN32)
 #if !TEST_FONTS_MISSING
 DECLARE_WW8EXPORT_TEST(testTableKeep, "tdf91083.odt")
 {
@@ -1302,7 +1301,6 @@ DECLARE_WW8EXPORT_TEST(testTableKeep, "tdf91083.odt")
 CPPUNIT_ASSERT_EQUAL( OUString("Row 1"), 
parseDump("/root/page[6]/body/tab[1]/row[2]/cell[1]/txt[1]") );
 }
 #endif
-#endif
 
 DECLARE_WW8EXPORT_TEST(testTdf76349_textboxMargins, 
"tdf76349_textboxMargins.doc")
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101124] MERGE and centre cells loses formula

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101124

Elmar  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #7 from Elmar  ---
I think this has been resolved in v6.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117893] besselj gives error for negative order

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117893

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #1 from raal  ---
 specification
http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part2.html#__RefHeading__1018486_715980110


6.16.13BESSELJ
Summary: Returns the Bessel function of integer order Jn(x) (cylinder function)
Syntax: BESSELJ( Integer X ; Number N )
Returns: Number
Constraints: N >= 0, INT(N)=N; Evaluators may evaluate expressions where N >= 0
returns a non-error value.
Semantics: Computes the Bessel function of integer order Jn(x). N is also known
as the order.


Constraints: N >= 0 => not a bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117492] MSI: When installation fails, ensure not to remove previous installed version

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117492

--- Comment #5 from Mike Kaganski  ---
Another possible gain here is reduced requirements to close external programs
during the installation, because the process would presumably touch less
files/registry settings, and thus less likely to interfere with other programs
that lock resources (fonts, shell extension, etc.) - see also bug 69066.
However, that's just a guess, and depends on Windows Installer being smart
enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111857] FILESAVE: errors when saving to PPTX - TABs lost

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111857

--- Comment #4 from Elmar  ---
Created attachment 142396
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142396=edit
ppt version of tab issue is good

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111857] FILESAVE: errors when saving to PPTX - TABs lost

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111857

--- Comment #5 from Elmar  ---
Created attachment 142397
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142397=edit
pptx version of tab issue not good

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111857] FILESAVE: errors when saving to PPTX - TABs lost

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111857

--- Comment #3 from Elmar  ---
The tab issue works fine in the Impress doc saved to PPT.

However, the PPTX save does not view correctly in Powerpoint and also Impress.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111858] FILESAVE: errors when saving to PPTX - Font size lost

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111858

Elmar  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #3 from Elmar  ---
I think this can be closed now.

LO 6.1 does not seem to have the problem any more.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80693] EDITING: fill cell with random numbers with min = max

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80693

raal  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
 CC||r...@post.cz

--- Comment #8 from raal  ---
Cannot reproduce with Version: 6.2.0.0.alpha0+
Build ID: c0fbf99e5601da27c59d131bcca24fafd259e508
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk3; 
and 6.0.4.2 (x64), windoes 7

Please retest with current version. Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111859] FILESAVE: errors when saving to PPT/ X - shrink text to fit box attribute lost

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111859

--- Comment #8 from Elmar  ---
Note: if you open the PPT with Impress, then the text does shrink.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111859] FILESAVE: errors when saving to PPT/ X - shrink text to fit box attribute lost

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111859

--- Comment #7 from Elmar  ---
Created attachment 142395
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142395=edit
odp source file (for reference)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

[Luboš Luňák]

 sc/qa/uitest/calc_tests/tdf53482.py |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 173c3a7321d0ba2583f1198d5ea3b54983665f37
Author: Luboš Luňák 
Date:   Tue May 29 10:06:40 2018 +0200

Revert "UITest_calc_tests: disable randomly failing assert for now"

Fixed by my previous commit.
This reverts commit 27cc0064a8a52c9000d0249581e80fe7a0c8a7b6.

Change-Id: Ib64e7341251d848b4db0dbb1f58c4fcef51437ed

diff --git a/sc/qa/uitest/calc_tests/tdf53482.py 
b/sc/qa/uitest/calc_tests/tdf53482.py
index ff23eb8105e2..33ffa71d6283 100644
--- a/sc/qa/uitest/calc_tests/tdf53482.py
+++ b/sc/qa/uitest/calc_tests/tdf53482.py
@@ -49,8 +49,7 @@ class tdf53482(UITestCase):
 self.ui_test.close_dialog_through_button(xOK)
 #6. Expected behavior:  Ignore column labels when sorting
 self.assertEqual(get_cell_by_position(document, 0, 6, 7).getString(), 
"Occupation")
-# FIXME this fails randomly, e.g. travel Industry or ttavel Industry.
-#self.assertEqual(get_cell_by_position(document, 0, 6, 8).getString(), 
"Travel Industry")
+self.assertEqual(get_cell_by_position(document, 0, 6, 8).getString(), 
"Travel Industry")
 self.assertEqual(get_cell_by_position(document, 0, 6, 
123).getString(), "13")
 
 self.ui_test.close_doc()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 111859] FILESAVE: errors when saving to PPT/ X - shrink text to fit box attribute lost

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111859

--- Comment #6 from Elmar  ---
Created attachment 142394
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142394=edit
ppt textbox not shrinking

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: unotools/source

[Luboš Luňák]

 unotools/source/i18n/charclass.cxx |   56 -
 1 file changed, 55 insertions(+), 1 deletion(-)

New commits:
commit a2045f94677c4407c00a3299da0936ded696cfb2
Author: Luboš Luňák 
Date:   Tue May 29 12:27:34 2018 +0200

make CharClass also mutex-protect calls to its dependent class

When calc_tests runs test_tdf53482_Range_contains_column_headings_file()
with Calc's threading enabled, it ends up calling ScInterpreter::ScProper()
from threads, which calls to CharClass. And while CharClass tries to be
thread-safe (guessing from the mutex usage), it forwards calls to i18npool's
CharacterClassificationImpl and cclass_Unicode, both of which aren't
thread-safe. Which makes thread safety of CharClass itself pointless.

Since CharClass already acquires the mutex anyway because of getMyLocale(),
just extend the duration for the entire call, which hopefully shouldn't
make that much of a difference.

Change-Id: I544b34d7e58c4a901f3b6e3a3ff52156b9e320a8
Reviewed-on: https://gerrit.libreoffice.org/54999
Reviewed-by: Michael Meeks 
Tested-by: Luboš Luňák 

diff --git a/unotools/source/i18n/charclass.cxx 
b/unotools/source/i18n/charclass.cxx
index 9e3d184b1490..4be3ad89c3b8 100644
--- a/unotools/source/i18n/charclass.cxx
+++ b/unotools/source/i18n/charclass.cxx
@@ -64,7 +64,7 @@ const LanguageTag& CharClass::getLanguageTag() const
 
 const css::lang::Locale& CharClass::getMyLocale() const
 {
-::osl::MutexGuard aGuard( aMutex );
+// Mutex locked by callers.
 return maLanguageTag.getLocale();
 }
 
@@ -113,8 +113,11 @@ bool CharClass::isAlpha( const OUString& rStr, sal_Int32 
nPos ) const
 try
 {
 if ( xCC.is() )
+{
+::osl::MutexGuard aGuard( aMutex );
 return  (xCC->getCharacterType( rStr, nPos, getMyLocale() ) &
  nCharClassAlphaType) != 0;
+}
 }
 catch ( const Exception& )
 {
@@ -132,8 +135,11 @@ bool CharClass::isLetter( const OUString& rStr, sal_Int32 
nPos ) const
 try
 {
 if ( xCC.is() )
+{
+::osl::MutexGuard aGuard( aMutex );
 return  (xCC->getCharacterType( rStr, nPos, getMyLocale() ) &
  nCharClassLetterType) != 0;
+}
 }
 catch ( const Exception& )
 {
@@ -147,7 +153,10 @@ bool CharClass::isLetter( const OUString& rStr ) const
 try
 {
 if ( xCC.is() )
+{
+::osl::MutexGuard aGuard( aMutex );
 return isLetterType( xCC->getStringType( rStr, 0, 
rStr.getLength(), getMyLocale() ) );
+}
 }
 catch ( const Exception& )
 {
@@ -165,8 +174,11 @@ bool CharClass::isDigit( const OUString& rStr, sal_Int32 
nPos ) const
 try
 {
 if ( xCC.is() )
+{
+::osl::MutexGuard aGuard( aMutex );
 return  (xCC->getCharacterType( rStr, nPos, getMyLocale() ) &
  KCharacterType::DIGIT) != 0;
+}
 }
 catch ( const Exception& )
 {
@@ -180,7 +192,10 @@ bool CharClass::isNumeric( const OUString& rStr ) const
 try
 {
 if ( xCC.is() )
+{
+::osl::MutexGuard aGuard( aMutex );
 return isNumericType( xCC->getStringType( rStr, 0, 
rStr.getLength(), getMyLocale() ) );
+}
 }
 catch ( const Exception& )
 {
@@ -198,8 +213,11 @@ bool CharClass::isAlphaNumeric( const OUString& rStr, 
sal_Int32 nPos ) const
 try
 {
 if ( xCC.is() )
+{
+::osl::MutexGuard aGuard( aMutex );
 return  (xCC->getCharacterType( rStr, nPos, getMyLocale() ) &
 (nCharClassAlphaType | KCharacterType::DIGIT)) != 0;
+}
 }
 catch ( const Exception& )
 {
@@ -217,8 +235,11 @@ bool CharClass::isLetterNumeric( const OUString& rStr, 
sal_Int32 nPos ) const
 try
 {
 if ( xCC.is() )
+{
+::osl::MutexGuard aGuard( aMutex );
 return  (xCC->getCharacterType( rStr, nPos, getMyLocale() ) &
  (nCharClassLetterType | KCharacterType::DIGIT)) != 0;
+}
 }
 catch ( const Exception& )
 {
@@ -232,7 +253,10 @@ bool CharClass::isLetterNumeric( const OUString& rStr ) 
const
 try
 {
 if ( xCC.is() )
+{
+::osl::MutexGuard aGuard( aMutex );
 return isLetterNumericType( xCC->getStringType( rStr, 0, 
rStr.getLength(), getMyLocale() ) );
+}
 }
 catch ( const Exception& )
 {
@@ -246,7 +270,10 @@ OUString CharClass::titlecase(const OUString& rStr, 
sal_Int32 nPos, sal_Int32 nC
 try
 {
 if ( xCC.is() )
+{
+::osl::MutexGuard aGuard( aMutex );
 return xCC->toTitle( rStr, nPos, nCount, getMyLocale() );
+}
 }
 catch ( const Exception& )
 {
@@ -260,7 +287,10 @@ OUString CharClass::uppercase( const OUString& rStr, 
sal_Int32 

[Libreoffice-bugs] [Bug 111859] FILESAVE: errors when saving to PPT/ X - shrink text to fit box attribute lost

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111859

--- Comment #5 from Elmar  ---
I have added a new example file.

When I open it in LO (now 6.1 alpha) it displays fine. But when I open it in
MSPowerpoint the shrink text is lost.

However, if I save the LO file to PPTX, then the shrink text is working.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117417] Lost images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117417

--- Comment #9 from Jacinto Canales de Caso  ---
I could repet the process and sending the files if you are interested.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117417] Lost images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117417

--- Comment #8 from Jacinto Canales de Caso  ---
(In reply to Xisco Faulí from comment #7)
> So you created the document using Excel ? Which version?

I created the document with LibreOffice, but maybe it was converted by MS Excel
2010.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117893] New: besselj gives error for negative order

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117893

Bug ID: 117893
   Summary: besselj gives error for negative order
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: k...@drdoppler.com

=besselj(3.8,2) gives .409. Good
=besselj(3.8,-2) gives err502. Bad. It should give the same answer
=besselj(3.8,3) gives .418. Good
=besselj(3.8,-3) gives err502. Bad. It should give -.418
In general
besselj(x,-even order)=besselj(x,+even order) (behaves like cos(-x)=cos(x))
besselj(x,-odd order)=-besselj(x,+odd order) (behaves like sin(-x)=-sin(x))
Kent

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115607] [META] Bugs in Languages Used by Minority Nationalities of China

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115607

Volga  changed:

   What|Removed |Added

 Blocks||43808


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=43808
[Bug 43808] [META] Right-To-Left (aka Complex Text Layout) language issues
(RTL/CTL)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left (aka Complex Text Layout) language issues (RTL/CTL)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=43808

Volga  changed:

   What|Removed |Added

 Depends on||115607


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115607
[Bug 115607] [META] Bugs in Languages Used by Minority Nationalities of China
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113582] Export as PDF reduces arrow line width compared to display

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113582

--- Comment #9 from mattreecebent...@gmail.com ---
(In reply to Buovjaga from comment #8)
> (In reply to mattreecebentley from comment #7)
> > Yes I'm aware it's different, almost the reverse of the first problem.
> > If it is invisible in Impress, it should be invisible in PDF and vice-versa.
> 
> Hmm, I was unable to make it invisible in Impress. If you want, you could
> email me an example file where it shows as invisible for you.

Done

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117885] LibreOffice Incorrectly Calculating Page Size in .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117885

Luke  changed:

   What|Removed |Added

   Keywords||bibisectRequest

--- Comment #2 from Luke  ---
Version: 4.1.0.1
Build ID: 1b3956717a60d6ac35b133d7b0a0f5eb55e9155
GOOD

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70451] Table of contents does not respect line breaks in headings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70451

--- Comment #9 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108232] Marco Flotante (floating frame)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108232

--- Comment #2 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108080] [FILESAVE DOCX] Column Chart doesn' t preserve color scheme when changed to Pie chart, and later changed back to Column chart

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108080

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99394] Convert to HTML - Footer Problem

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99394

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93117] LibreOffice freezes when trying to access/open/read/ write documents on NFS mounts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93117

--- Comment #3 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105956] Changing chart type from pie chart to column chart brokes chart coloring

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105956

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97428] Variation of a interval for line and for symbols when clicking on text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97428

--- Comment #12 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97057] Shapes with Theme Color Lost When Resaved as XLSX File

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97057

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117766] Macros Digital Signatures menu option missing in main window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117766

Drew Jensen  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #4 from Drew Jensen  ---


*** This bug has been marked as a duplicate of bug 97694 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97694] Base macros cannot be digitally signed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97694

Drew Jensen  changed:

   What|Removed |Added

 CC||drewjensen.in...@gmail.com

--- Comment #8 from Drew Jensen  ---
*** Bug 117766 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117892] New: Area tab: Bitmap preview is not shown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117892

Bug ID: 117892
   Summary: Area tab: Bitmap preview is not shown
   Product: LibreOffice
   Version: 6.1.0.0.alpha1+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rayk...@gmail.com

Format > Paragraph > Area > Bitmap
or 
Format > Page > Area > Bitmap

result: Preview window is always blue

expected result: Preview window shows preview of selected bitmap

Version: 6.1.0.0.alpha1+
Build ID: 0374babfa347844a04c43abca57aa5e6b4ccbaaf
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); Calc: group

and

Version: 6.1.0.0.alpha1+ (x64)
Build ID: 7237db44dfac914e5b6003f418267d3df1e7f162
CPU threads: 4; OS: Windows 10.0; UI render: default;
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-05-05_12:19:17
Locale: en-US (en_US); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - README

[Matthias Seidel]

 README |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 8d04f84ef940b408f184e634f179cd0fc262d0ff
Author: Matthias Seidel 
Date:   Tue May 29 22:15:50 2018 +

Updated Readme for 250,000,000 downloads

diff --git a/README b/README
index 9f2029f3b2e9..45303ed84fbc 100644
--- a/README
+++ b/README
@@ -4,11 +4,11 @@ Apache OpenOffice (AOO)
 
 The Apache OpenOffice project provides a full featured office productivity 
suite
 based on open standards. It is the continuation of the OpenOffice.org 
project.
-
-For detailed information about Apache OpenOffice please visit 
+
+For detailed information about Apache OpenOffice please visit
 https://openoffice.apache.org/
 
-Apache OpenOffice is a very large project with many components and mainly 
+Apache OpenOffice is a very large project with many components and mainly
 implemented in C++ but also in Java, Perl, Python and other languages.
 
 Currently supported platforms include:
@@ -19,7 +19,7 @@ Apache OpenOffice (AOO)
 FreeBSD
 OS/2
 
-OpenOffice is used by millions of users worldwide and with more than 225 
million
+OpenOffice is used by millions of users worldwide and with more than 250 
million
 downloads it is one of the most successful open source projects.
 
 Getting the latest sources via Subversion
@@ -36,7 +36,7 @@ Building Apache OpenOffice
 ===
 
 Apache OpenOffice is a big project and depends on several other external 
libraries.
-The list of prerequisites varies for the different platforms. 
+The list of prerequisites varies for the different platforms.
 
 A comprehensive and complete building guide can be found in the project 
wiki under
 
@@ -54,7 +54,7 @@ Building Apache OpenOffice
 
 Note that building OpenOffice can take several hours.
 
-The default build will produce a setup version (e.g. setup program on 
windows, dmg on Mac OS, 
+The default build will produce a setup version (e.g. setup program on 
Windows, dmg on macOS,
 rpm and deb packages on Linux, pkg packages on Solaris) and an archived 
version. The output
 can be found in the  directory in 
instsetoo_native//Apache_OpenOffice/...
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117891] Base table icons in Main window Tables list are displaying the Calc Template icon

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117891

--- Comment #1 from Drew Jensen  ---
Created attachment 142393
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142393=edit
screen shot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117891] New: Base table icons in Main window Tables list are displaying the Calc Template icon

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117891

Bug ID: 117891
   Summary: Base table icons in Main window Tables list are
displaying the Calc Template icon
   Product: LibreOffice
   Version: 6.1.0.0.beta1+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: trivial
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: drewjensen.in...@gmail.com

Description:
This is the only icon theme where the tables use a template icon.
The Elementary theme uses icons for Text Tables (for hsql files) and Views
which do fit the basic iconography used in the other themes. 

Steps to Reproduce:
1. Open any Base file with tables defined
2. click on the Tables section
3.

Actual Results:  
Table items are using Calc Template icons

Expected Results:
The base table icon for that icon set


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Ubuntu Chromium/66.0.3359.181 Chrome/66.0.3359.181 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117784] "Bullets and Numbering" menu does not show any dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117784

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@caesar.elte.hu
 Ever confirmed|0   |1

--- Comment #1 from Aron Budea  ---
Confirmed with online+core master build.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117490] lo_startmain aborts by sigabrt while editing texts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117490

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||ba...@caesar.elte.hu
 Ever confirmed|0   |1

--- Comment #5 from Aron Budea  ---
(In reply to yova from comment #3)
> libreoffice_1  | office version details: { "ProductName": "Collabora
> OfficeDev", "ProductVersion": "6.0", "Produc
> tExtension": ".10.2", "BuildId": "45c83371948f33738effa0ceffd3fc3758b5c2ea"
> } 
This is the core commit, that's half of the information, what's the online
commit? Or rather, which online branch were you building it with? Well, only
master branch will work with that combination.

You don't need further setup for testing with make run, it displays test links
on console, which should launch the different applications with test files in
the browser.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117890] Math Online Help: The screenshots in the Symbols and Edit Symbols pages are unhelpful

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117890

Olivier Hallot  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Olivier Hallot  ---
Confirmed. OK to delete them.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Change file_path LOOL

[Renato Ribeiro]

Hello all,


When I launch the LOOL server I can use the link displayed to open a document 
in a web browser (link below)


https://localhost:9980/loleaflet/2bac/loleaflet.html?file_path=file:///home//libreoffice/online/test/data/hello_world.odt


But this link shows the path of my diretories' tree 
(/home//libreoffice/online/test/data/hello_world.odt).
 I would like to know how I can hide this path. Can I define a variable for 
this path and with this show online the name fo the variable instead the path? 
In which diretory I can change this?


Thanks in advance.

Best regards
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Invitation: ESC - evening slot. @ Wed May 30, 2018 5pm - 6pm (BST) (libreoffice@lists.freedesktop.org)

[Michael Meeks]

BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:REQUEST
BEGIN:VEVENT
DTSTART:20180530T16Z
DTEND:20180530T17Z
DTSTAMP:20180529T093433Z
ORGANIZER;CN=Michael Meeks:mailto:mejme...@gmail.com
UID:r5pktqhjf6sipob3l3nm3iq...@google.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=libreoffice-dev;X-NUM-GUESTS=0:mailto:libreoffice@lists.freedesktop
 .org
CREATED:20180529T093328Z
DESCRIPTION:Do join us for an ESC call - https://meet.jit.si/TDFESC\n\n-::~
 :~::~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~
 ::~:~::-\nPlease do not edit this section of the description.\n\nView your 
 event at https://www.google.com/calendar/event?action=VIEW=cjVwa3RxaGpm
 NnNpcG9iM2wzbm0zaXFkbW8gbGlicmVvZmZpY2VAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn=MT
 gjbWVqbWVla3NAZ21haWwuY29tNzBkYTBiOGYxNjBhZjBkYWY2NmFhODk0YzJjZDcyMWQwYzczM
 zEzNQ=Europe%2FLondon=en=1.\n-::~:~::~:~:~:~:~:~:~:~:~:~:~:~:~:~:
 ~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~:~::~:~::-
LAST-MODIFIED:20180529T093432Z
LOCATION:
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:ESC - evening slot.
TRANSP:OPAQUE
BEGIN:VALARM
ACTION:DISPLAY
DESCRIPTION:This is an event reminder
TRIGGER:-P0DT0H15M0S
END:VALARM
END:VEVENT
END:VCALENDAR


invite.ics
Description: application/ics
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on OS X

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=42082

andreas_k  changed:

   What|Removed |Added

 CC||kain...@gmail.com

--- Comment #28 from andreas_k  ---
About icon themes I would choose Colibre for OS-X cause of one reason
"documentation and support".

I'm very happy that LibreOffice offer different icon themes and I also
understood that for Linux users it is very important to have a consistent
desktop, but in "real life" maintenance and support are more important. Have an
online help, LibreOffice Books, Support Hotline, ... and everywhere they show
different icons it can be very confusing for the users to understood that an
icon will look different in different icon themes. If a user by a LibreOffice
book, the user is interested in learn how LibreOffice work. Should be the first
chapter in a book how to change the icon theme, cause otherwise it will be
difficult to read/translate the book.

>From my point of view it will be very professional to have on Windows and OS-X
the same icon theme. I don't have a Mac but I don't think that the icon theme
will that much out of place.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113794] Status bar’s Zoom slider and percentage =?UTF-8?Q?=20are=20separated?=; both controls belong together

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113794

Adolfo Jayme  changed:

   What|Removed |Added

   Keywords||needsDevEval

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112889] [META] Screen flickering when hovering on items or selecting text with default rendering

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112889

Adolfo Jayme  changed:

   What|Removed |Added

 Depends on||117829
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=11 |
   |7829|


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=117829
[Bug 117829] VIEWING: Text flickers in text box when moving mouse in and out of
it while it is not selected dependent on OpenGL video hardware acceleration
setting
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117829] VIEWING: Text flickers in text box when moving mouse in and out of it while it is not selected dependent on OpenGL video hardware acceleration setting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117829

Adolfo Jayme  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=11 |
   |2889|
 Blocks||112889


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112889
[Bug 112889] [META] Screen flickering when hovering on items or selecting text
with default rendering
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117877] UI: List Box mouse wheel scroll behavior cannot be changed / selecting an item scrolls the content

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117877

Adolfo Jayme  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117890] New: Math Online Help: The screenshots in the Symbols and Edit Symbols pages are unhelpful

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117890

Bug ID: 117890
   Summary: Math Online Help: The screenshots in the Symbols and
Edit Symbols pages are unhelpful
   Product: LibreOffice
   Version: 6.1.0.0.alpha1+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: f...@libreoffice.org
CC: olivier.hal...@documentfoundation.org

The screenshots in the Symbols and Edit Symbols pages [1, 2] are buggy and,
thus, unhelpful.

Both screenshots depict dialogs that are missing most of their UI elements,
such as the symbol tables. This is reproducible in all language versions of the
images.

 [1]:
https://help.libreoffice.org/6.1/es/text/smath/01/0601.html?DbPAR=MATH#bm_id3145799
 [2]:
https://help.libreoffice.org/6.1/es/text/smath/01/06010100.html?=MATH=UNIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117730] LibO is trying a little too hard to import a non-supported file: like mp3 (hang)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117730

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||7886

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117886] LibO becomes unresponsive when insert image with unknown format from Web

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117886

Telesto  changed:

   What|Removed |Added

 CC||tele...@surfxs.nl
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||7730

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117879] Formula truncated falsely if the first/ middle argument of the function(with two or more significant args) contains a non-constants parameter within array of constants

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117879

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #1 from m.a.riosv  ---
Have you tested with semicolon instead commas as separator.
It is on Menu/Tools/Options/LibreOffice calc/Formula - Separators - function.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117781] Hang when copying a sheet to a new document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117781

Telesto  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117857] Korean Hangul/Hanja Conversion Menu's "add Korean Ruby script " not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117857

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #5 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.

Thank you DaeHyun Sung, I finally found!
I had to select "Korean (RoK)" for User interface + select for "Asian:" drop
down associated list "Korean (RoK)"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117573] Extend LightProof to Support More Grammar Checkers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117573

--- Comment #4 from Keith Curtis  ---
Hi Laszlo,

Glad those links are helpful. It could be useful to factor out some common
punctuation, etc. rules that work across languages. I wouldn't move LightProof
to a library until it gets to 50K lines :-)  

Increasingly people realize AI is useless without data, so we can hope more
useful open datasets like Imagenet will become popular. Grammar is a
complicated problem, but that is what deep learning works best at. The
challenge today is that lots of people are building NL research toolkits, and
aren't trying to package up NL processing and great suggestions into one
component.

An online service could be a cool hackathon project, but it's a privacy,
performance, etc. challenge. We need to make the free desktop smart to stay
relevant. Inference should be able to run on low-end CPUs. A modern processor
can do 30 Imagenet inferences per second. I don't know what that translates
into grammar checking, but it is probably more than enough.  There are people
exploring ways to compress models, like Squeezenet:
https://arxiv.org/abs/1602.07360

The nice thing about the Link Grammar checker is that it seems to have an easy
API already. Do you think that could be an easy hack given the AbiWord wrapper
code and LightProof? It's not deep learning, but it should be a good way to
explore the possibilities of integrating a good engine.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/print_revamp' - vcl/inc vcl/source vcl/uiconfig

[Daniel]

 vcl/inc/printdlg.hxx   |3 +
 vcl/inc/strings.hrc|1 
 vcl/source/window/printdlg.cxx |   62 +
 vcl/uiconfig/ui/printdialog.ui |   16 ++
 4 files changed, 71 insertions(+), 11 deletions(-)

New commits:
commit b9c297021d2b95b67fa2ab2842f0f4b344338129
Author: Daniel 
Date:   Tue May 15 22:58:38 2018 -0300

tdf#67905 adds an option to disable print preview in print dialog

Change-Id: Id6dd1724a1b8f61d94f0685f63d28b3cff19988f

diff --git a/vcl/inc/printdlg.hxx b/vcl/inc/printdlg.hxx
index b16d91cad1f6..0a5b09fd366a 100644
--- a/vcl/inc/printdlg.hxx
+++ b/vcl/inc/printdlg.hxx
@@ -181,6 +181,7 @@ namespace vcl
 VclPtr   mpNumPagesText;
 VclPtr  mpBackwardBtn;
 VclPtr  mpForwardBtn;
+VclPtrmpPreviewBox;
 
 VclPtrmpOKButton;
 VclPtrmpCancelButton;
@@ -188,6 +189,7 @@ namespace vcl
 
 OUStringmaPageStr;
 OUStringmaNoPageStr;
+OUStringmaNoPreviewStr;
 sal_Int32   mnCurPage;
 sal_Int32   mnCachedPages;
 
@@ -247,6 +249,7 @@ namespace vcl
 bool isPrintToFile();
 bool isCollate();
 bool isSingleJobs();
+bool hasPreview();
 
 void previewForward();
 void previewBackward();
diff --git a/vcl/inc/strings.hrc b/vcl/inc/strings.hrc
index 1475e2a65ceb..1e5eb9d14743 100644
--- a/vcl/inc/strings.hrc
+++ b/vcl/inc/strings.hrc
@@ -113,6 +113,7 @@
 #define SV_ACCESSERROR_NO_FONTS  
NC_("SV_ACCESSERROR_NO_FONTS", "No fonts could be found on the system.")
 
 #define SV_PRINT_NOPAGES NC_("SV_PRINT_NOPAGES", 
"No pages")
+#define SV_PRINT_NOPREVIEW   NC_("SV_PRINT_NOPREVIEW", 
"Preview is disabled")
 #define SV_PRINT_TOFILE_TXT  
NC_("SV_PRINT_TOFILE_TXT", "Print to File...")
 #define SV_PRINT_DEFPRT_TXT  
NC_("SV_PRINT_DEFPRT_TXT", "Default printer")
 #define SV_PRINT_PRINTPREVIEW_TXT
NC_("SV_PRINT_PRINTPREVIEW_TXT", "Print preview")
diff --git a/vcl/source/window/printdlg.cxx b/vcl/source/window/printdlg.cxx
index 084763fa934b..e59694ca8c0f 100644
--- a/vcl/source/window/printdlg.cxx
+++ b/vcl/source/window/printdlg.cxx
@@ -650,6 +650,7 @@ PrintDialog::PrintDialog( vcl::Window* i_pParent, const 
std::shared_ptrGetText();
@@ -715,9 +717,6 @@ PrintDialog::PrintDialog( vcl::Window* i_pParent, const 
std::shared_ptrresetPrinterOptions( false );
 
-// get the first page
-preparePreview( true, true );
-
 // update the text fields for the printer
 updatePrinterText();
 
@@ -747,6 +746,7 @@ PrintDialog::PrintDialog( vcl::Window* i_pParent, const 
std::shared_ptrSetClickHdl( LINK( this, PrintDialog, ClickHdl ) );
 mpForwardBtn->SetClickHdl( LINK( this, PrintDialog, ClickHdl ) );
 mpBackwardBtn->SetClickHdl( LINK( this, PrintDialog, ClickHdl ) );
+mpPreviewBox->SetClickHdl( LINK( this, PrintDialog, ClickHdl ) );
 
 maJobPage.mpCollateBox->SetToggleHdl( LINK( this, PrintDialog, ToggleHdl ) 
);
 maJobPage.mpSetupButton->SetClickHdl( LINK( this, PrintDialog, ClickHdl ) 
);
@@ -805,6 +805,7 @@ void PrintDialog::dispose()
 mpNumPagesText.clear();
 mpBackwardBtn.clear();
 mpForwardBtn.clear();
+mpPreviewBox.clear();
 mpOKButton.clear();
 mpCancelButton.clear();
 mpHelpButton.clear();
@@ -834,6 +835,16 @@ void PrintDialog::readFromSettings()
 }
 }
 
+aValue = pItem->getValue( "PrintDialog", "HasPreview" );
+if ( aValue.equalsIgnoreAsciiCase("true") )
+{
+mpPreviewBox->Check();
+}
+else
+{
+mpPreviewBox->Check( false );
+}
+
 // persistent window state
 OUString aWinState( pItem->getValue( "PrintDialog",
   "WindowState" ) );
@@ -864,6 +875,9 @@ void PrintDialog::storeToSettings()
  "WindowState",
  OStringToOUString( GetWindowState(), 
RTL_TEXTENCODING_UTF8 )
  );
+pItem->setValue( "PrintDialog",
+ "HasPreview",
+ hasPreview() ? OUString("true") : OUString("false") );
 pItem->Commit();
 }
 
@@ -882,6 +896,11 @@ bool PrintDialog::isSingleJobs()
 return maOptionsPage.mpCollateSingleJobsBox->IsChecked();
 }
 
+bool PrintDialog::hasPreview()
+{
+return mpPreviewBox->IsChecked();
+}
+
 void setHelpId( vcl::Window* i_pWindow, const Sequence< OUString >& 
i_rHelpIds, sal_Int32 i_nIndex )
 {
 if( i_nIndex >= 0 && i_nIndex < i_rHelpIds.getLength() )
@@ -1381,25 +1400,43 @@ void PrintDialog::setPreviewText()
 
 void 

[Libreoffice-bugs] [Bug 115909] FILESAVE Impress: Change slide size and save as FODP duplicates autolayout area on master slide

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115909

--- Comment #3 from Andrew Watson  ---
Tested with:

Version: 6.1.0.0.beta1
Build ID: 8c76dfe1284e211954c30f219b3a38dcdd82f8a0
CPU threads: 4; OS: Mac OS X 10.11.6; UI render: default; 
Locale: en-US (en.UTF-8); Calc: group

 ... and "Steps to reproduce" no longer trigger the problem.

Can be closed as RESOLVED?

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Changes to 'feature/print_revamp'

[Caolán McNamara]

New branch 'feature/print_revamp' available with the following commits:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116543] Crash (fatal error) when attempting a mail merge print ( only the first time the connection is done)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116543

--- Comment #10 from Andrew Watson  ---
Reproduced in:

Version: 6.1.0.0.beta1
Build ID: 8c76dfe1284e211954c30f219b3a38dcdd82f8a0
CPU threads: 4; OS: Mac OS X 10.11.6; UI render: default; 
Locale: en-US (en.UTF-8); Calc: group

  using the steps to reproduce described in
https://bugs.documentfoundation.org/show_bug.cgi?id=117480

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117824] Crash in: ScInputHandler::EnterHandler(ScEnterMode)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117824

--- Comment #3 from Caolán McNamara  ---
something has that storage element open for editing already so trying to remove
it throws that exception.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117867] Firebird: migration: Auto Timestamp in HSQLDB not transfered to firebird

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117867

--- Comment #3 from Julien Nabet  ---
(In reply to Julien Nabet from comment #2)
> I tried to mimic
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=b18953565b68e46289ad85927d79f5978a51078b but I don't understand the
> difference between:
> - dbaccess/source/filter/hsqldb/fbcreateparser.cxx
> - dbaccess/source/filter/hsqldb/parseschema.cxx
> - dbaccess/source/filter/hsqldb/createparser.cxx

The last one isn't in the patch but allows to parse hsqldb too.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117867] Firebird: migration: Auto Timestamp in HSQLDB not transfered to firebird

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117867

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #2 from Julien Nabet  ---
I tried to mimic
https://cgit.freedesktop.org/libreoffice/core/commit/?id=b18953565b68e46289ad85927d79f5978a51078b
but I don't understand the difference between:
- dbaccess/source/filter/hsqldb/fbcreateparser.cxx
- dbaccess/source/filter/hsqldb/parseschema.cxx
- dbaccess/source/filter/hsqldb/createparser.cxx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/source

[Caolán McNamara]

 cui/source/tabpages/transfrm.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit 7725eff80a7bc3f3e422e56e1cd7bfa531f19a70
Author: Caolán McNamara 
Date:   Tue May 29 13:53:35 2018 +0100

fix pow by digits

Change-Id: I715b85fa1c1e3f6c391c742f861e3791a505a570
Reviewed-on: https://gerrit.libreoffice.org/55006
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/tabpages/transfrm.cxx b/cui/source/tabpages/transfrm.cxx
index 6cfe85e3c0bf..fcd86eb7c082 100644
--- a/cui/source/tabpages/transfrm.cxx
+++ b/cui/source/tabpages/transfrm.cxx
@@ -1063,6 +1063,8 @@ void SvxPositionSizeTabPage::Reset( const SfxItemSet*  )
 pItem = GetItem( mrOutAttrs, SID_ATTR_TRANSFORM_WIDTH );
 mfOldWidth = std::max( pItem ? static_cast(static_cast(pItem)->GetValue()) : 0.0, 1.0 );
 double 
fTmpWidth((OutputDevice::LogicToLogic(static_cast(mfOldWidth), 
mePoolUnit, MapUnit::Map100thMM)) / fUIScale);
+if (m_xMtrWidth->get_digits())
+fTmpWidth *= pow(10.0, m_xMtrWidth->get_digits());
 m_xMtrWidth->set_value(static_cast(fTmpWidth), FUNIT_100TH_MM);
 }
 
@@ -1070,6 +1072,8 @@ void SvxPositionSizeTabPage::Reset( const SfxItemSet*  )
 pItem = GetItem( mrOutAttrs, SID_ATTR_TRANSFORM_HEIGHT );
 mfOldHeight = std::max( pItem ? static_cast(static_cast(pItem)->GetValue()) : 0.0, 1.0 );
 double 
fTmpHeight((OutputDevice::LogicToLogic(static_cast(mfOldHeight), 
mePoolUnit, MapUnit::Map100thMM)) / fUIScale);
+if (m_xMtrHeight->get_digits())
+fTmpHeight *= pow(10.0, m_xMtrHeight->get_digits());
 m_xMtrHeight->set_value(static_cast(fTmpHeight), FUNIT_100TH_MM);
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Changes to 'refs/tags/cd-3.2.2-2'

[Andras Timar]

Tag 'cd-3.2.2-2' created by Andras Timar  at 
2018-05-29 20:23 +

cd-3.2.2-2

Changes since cd-3.2.2-1-3:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-cd-3-2' - 3 commits - debian/changelog debian/control loolwsd.spec.in

[Andras Timar]

 debian/changelog |7 +++
 debian/control   |2 +-
 loolwsd.spec.in  |2 +-
 3 files changed, 9 insertions(+), 2 deletions(-)

New commits:
commit a557eac1f335c3969b9fd365d918ea140de65127
Author: Andras Timar 
Date:   Tue May 29 22:23:18 2018 +0200

Bump package version to 3.2.2-2

diff --git a/debian/changelog b/debian/changelog
index 73ad63348..7c67d474f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,8 +1,15 @@
+loolwsd (3.2.2-2) unstable; urgency=medium
+
+  * see the git log: http://col.la/coolcd32
+
+ -- Andras Timar   Tue, 29 May 2018 22:20:00 +0100
+
 loolwsd (3.2.2-1) unstable; urgency=medium
 
   * see the git log: http://col.la/cool32
 
  -- Andras Timar   Thu, 10 May 2018 11:20:00 +0100
+
 loolwsd (3.2.1-1) unstable; urgency=medium
 
   * see the git log: http://col.la/cool321
diff --git a/loolwsd.spec.in b/loolwsd.spec.in
index e206dcf00..de6587671 100644
--- a/loolwsd.spec.in
+++ b/loolwsd.spec.in
@@ -12,7 +12,7 @@ Name:   loolwsd%{name_suffix}
 Name:   loolwsd
 %endif
 Version:@PACKAGE_VERSION@
-Release:1%{?dist}
+Release:2%{?dist}
 %if 0%{?suse_version} == 1110
 Group:  Productivity/Office/Suite
 BuildRoot:  %{_tmppath}/%{name}-%{version}-build
commit 1af148cbe68a8137f63b03f70254861234c32e95
Author: Andras Timar 
Date:   Tue May 29 22:20:22 2018 +0200

require Collabora Office 5.3-47

diff --git a/debian/control b/debian/control
index 0faa0656a..ee1310c5c 100644
--- a/debian/control
+++ b/debian/control
@@ -8,7 +8,7 @@ Standards-Version: 3.9.7
 Package: loolwsd
 Section: web
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, fontconfig, libsm6, 
libxinerama1, libxrender1, libgl1-mesa-glx, libcups2, libcurl3-gnutls, cpio, 
libcap2-bin, libexpat1, libicu55, libjpeg-turbo8, libnss3, libpng12-0, 
libpoppler58, libxcb-render0, libxcb-shm0, libxml2, libxslt1.1, 
collaboraofficebasis5.3-calc (>= 5.3.10.46), collaboraofficebasis5.3-core (>= 
5.3.10.46), collaboraofficebasis5.3-graphicfilter (>= 5.3.10.46), 
collaboraofficebasis5.3-images (>= 5.3.10.46), collaboraofficebasis5.3-impress 
(>= 5.3.10.46), collaboraofficebasis5.3-ooofonts (>= 5.3.10.46), 
collaboraofficebasis5.3-writer (>= 5.3.10.46), collaboraoffice5.3 (>= 
5.3.10.46), collaboraoffice5.3-ure (>= 5.3.10.46), 
collaboraofficebasis5.3-en-us (>= 5.3.10.46), 
collaboraofficebasis5.3-en-us-calc (>= 5.3.10.46), 
collaboraofficebasis5.3-en-us-res (>= 5.3.10.46), 
collaboraofficebasis5.3-noto-fonts (>= 5.3.10.46), collaboraofficebasis5.3-draw 
(>= 5.3.10.46), collaboraofficebasis5.3-extension-pdf-import (>= 5.3.10.46)
 , collaboraofficebasis5.3-filter-data (>= 5.3.10.46), 
collaboraofficebasis5.3-ooolinguistic (>= 5.3.10.46)
+Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, fontconfig, libsm6, 
libxinerama1, libxrender1, libgl1-mesa-glx, libcups2, libcurl3-gnutls, cpio, 
libcap2-bin, libexpat1, libicu55, libjpeg-turbo8, libnss3, libpng12-0, 
libpoppler58, libxcb-render0, libxcb-shm0, libxml2, libxslt1.1, 
collaboraofficebasis5.3-calc (>= 5.3.10.47), collaboraofficebasis5.3-core (>= 
5.3.10.47), collaboraofficebasis5.3-graphicfilter (>= 5.3.10.47), 
collaboraofficebasis5.3-images (>= 5.3.10.47), collaboraofficebasis5.3-impress 
(>= 5.3.10.47), collaboraofficebasis5.3-ooofonts (>= 5.3.10.47), 
collaboraofficebasis5.3-writer (>= 5.3.10.47), collaboraoffice5.3 (>= 
5.3.10.47), collaboraoffice5.3-ure (>= 5.3.10.47), 
collaboraofficebasis5.3-en-us (>= 5.3.10.47), 
collaboraofficebasis5.3-en-us-calc (>= 5.3.10.47), 
collaboraofficebasis5.3-en-us-res (>= 5.3.10.47), 
collaboraofficebasis5.3-noto-fonts (>= 5.3.10.47), collaboraofficebasis5.3-draw 
(>= 5.3.10.47), collaboraofficebasis5.3-extension-pdf-import (>= 5.3.10.47)
 , collaboraofficebasis5.3-filter-data (>= 5.3.10.47), 
collaboraofficebasis5.3-ooolinguistic (>= 5.3.10.47)
 Conflicts: collaboraofficebasis5.3-gnome-integration, 
collaboraofficebasis5.3-kde-integration
 Description: LibreOffice Online WebSocket Daemon
  LOOLWSD is a daemon that talks to web browser clients and provides LibreOffice
commit 0d5abf9189e2614305fa05361009af7e982ed91c
Author: Andras Timar 
Date:   Tue May 29 21:55:40 2018 +0200

missing dependencies

diff --git a/debian/control b/debian/control
index 76f676324..0faa0656a 100644
--- a/debian/control
+++ b/debian/control
@@ -8,7 +8,7 @@ Standards-Version: 3.9.7
 Package: loolwsd
 Section: web
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, fontconfig, libsm6, 
libxinerama1, libxrender1, libgl1-mesa-glx, libcups2, cpio, libcap2-bin, 
libxcb-render0, libxcb-shm0, collaboraofficebasis5.3-calc (>= 5.3.10.46), 
collaboraofficebasis5.3-core (>= 5.3.10.46), 
collaboraofficebasis5.3-graphicfilter (>= 5.3.10.46), 
collaboraofficebasis5.3-images (>= 5.3.10.46), collaboraofficebasis5.3-impress 
(>= 5.3.10.46), collaboraofficebasis5.3-ooofonts (>= 5.3.10.46), 
collaboraofficebasis5.3-writer (>= 5.3.10.46), collaboraoffice5.3 (>= 
5.3.10.46), 

[Libreoffice-bugs] [Bug 117877] UI: List Box mouse wheel scroll behavior cannot be changed / selecting an item scrolls the content

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117877

--- Comment #2 from Balint Fodor  ---
Okay, I have created two separate reports.
117888 and 117889
You can close this one.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117335] GIF images fail to display in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117335

--- Comment #7 from Andrew Watson  ---
Reproduced in:

Version: 6.1.0.0.beta1
Build ID: 8c76dfe1284e211954c30f219b3a38dcdd82f8a0
CPU threads: 4; OS: Mac OS X 10.11.6; UI render: default; 
Locale: en-US (en.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117889] New: UI: Selecting an item in a list box scrolls the content

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117889

Bug ID: 117889
   Summary: UI: Selecting an item in a list box scrolls the
content
   Product: LibreOffice
   Version: 6.0.4.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: fodorbal...@gmail.com

Created attachment 142392
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142392=edit
List box scrolling on item selection

When you select an item in the list box, and putting the focus on the box it at
the same time, the list will scroll, so that the selected item goes to the top
(if it can). This might be useful for showing items below the selected one to
choose from, but what if I set my sight on two items, and the first item I
select is further down in the list than the other? Then I will have to scroll
back to find the second item. It would be nice if this automatic scrolling
didn't happen at all... maybe a setting can be implemented for it, if the
developers want to keep the current behavior.
When the focus is already in the list box, things work fine.
Now, when you unfocus from the list box with an item selected, you get the same
behavior, the selected item goes to the top. If there are multiple selected
items, no scrolling will happen.
If - in an unfocused state - you scroll the box with the scrollbar, as soon as
you exit the scrollbar area (no matter if you the mouse remains in the list box
area or not), the selected item will come to the top. Now this is rather
inconvenient, when you want to select another item that is not in the view. You
have to click in the box and put the focus on it first. Mouse wheel scrolling
will make life easier here as the scrolling position will only be reset, when
you exit the list box area.
Again, no issues with multiple items selected.
I attach the example program.

Tested with Windows 10.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117888] New: UI: List Box mouse wheel scroll behavior cannot be changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117888

Bug ID: 117888
   Summary: UI: List Box mouse wheel scroll behavior cannot be
changed
   Product: LibreOffice
   Version: 6.0.4.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: fodorbal...@gmail.com

Created attachment 142391
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142391=edit
List box mouse wheel scroll

The mouse wheel scroll is always on, even if it is set to Never or When
focused.
See it in the example program.
Tested with Windows 10.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - dictionaries

[Kruno]

 dictionaries |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 317319422bd2780c883251d5adc623dd7cc11ae8
Author: Kruno 
Date:   Fri Apr 27 21:35:24 2018 +0100

Updated core
Project: dictionaries  7da396b70265569b851a1c2327e7dcf757e3f936

Update Croatian dictionary to version 2.1.1

Change-Id: I8425ab128d04d428ccc99cb6c8abe2635292f143
Reviewed-on: https://gerrit.libreoffice.org/53579
Reviewed-by: Christian Lohmaier 
Tested-by: Christian Lohmaier 

diff --git a/dictionaries b/dictionaries
index 37c3e3924d33..7da396b70265 16
--- a/dictionaries
+++ b/dictionaries
@@ -1 +1 @@
-Subproject commit 37c3e3924d33f29dbff7fb3dba40b36a694c6792
+Subproject commit 7da396b70265569b851a1c2327e7dcf757e3f936
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Branch 'libreoffice-6-0' - hr_HR/hr_HR.aff hr_HR/hr_HR.dic hr_HR/README_hr_HR.txt

[Kruno]

 hr_HR/README_hr_HR.txt |9 
 hr_HR/hr_HR.aff|  285 ++-
 hr_HR/hr_HR.dic|  509 +++--
 3 files changed, 607 insertions(+), 196 deletions(-)

New commits:
commit 7da396b70265569b851a1c2327e7dcf757e3f936
Author: Kruno 
Date:   Fri Apr 27 21:35:24 2018 +0100

Update Croatian dictionary to version 2.1.1

Change-Id: I8425ab128d04d428ccc99cb6c8abe2635292f143
Reviewed-on: https://gerrit.libreoffice.org/53579
Reviewed-by: Christian Lohmaier 
Tested-by: Christian Lohmaier 

diff --git a/hr_HR/README_hr_HR.txt b/hr_HR/README_hr_HR.txt
index d8bf8df..3f8cc76 100644
--- a/hr_HR/README_hr_HR.txt
+++ b/hr_HR/README_hr_HR.txt
@@ -11,11 +11,16 @@ repository: https://www.github.com/krunose/hr-hunspell
 
 ### Autori i doprinositelji ###
 
-Mirko Kos (m i r k o s 9 9 [ a t ] g m a i l . c o m), 2016. - 2017.
+
+Boris Juric, 2017. - 2018.
+
+-
+
+Mirko Kos (m i r k o s 9 9 [ a t ] g m a i l // c o m), 2016. - 2017.
 
 -
 
-Krunoslav Šebetić (k r u n o . s e [ a t ] g m x . c o m), 2014. - 2017.
+Krunoslav Šebetić (k r u n o . s e [ a t ] g m x // c o m), 2014. - 2018.
 
 -
 
diff --git a/hr_HR/hr_HR.aff b/hr_HR/hr_HR.aff
index 67e56bc..3e91312 100644
--- a/hr_HR/hr_HR.aff
+++ b/hr_HR/hr_HR.aff
@@ -25,6 +25,7 @@ SUBSTANDARD ZO
 FORBIDDENWORD ZN
 WARN ZM
 
+# NOSPLITSUGS
 # SUGSWITHDOTS
 # FORBIDWARN
 
@@ -75,12 +76,14 @@ ICONV ŕ r
 
 
 # REP - .
-REP 157
+REP 219
 REP ^pocrtava podcrtava
 REP ^zdrastv zdravstv
 REP nućemo$ nut_ćemo
 REP nućete$ nut_ćete
 REP ^riječo$ riječ_o
+REP ^usisač usisivač
+REP rejanac rejac
 REP ^prenat prednat
 REP šćemo$ st_ćemo
 REP šćete$ st_ćete
@@ -88,14 +91,19 @@ REP aćemo$ at_ćemo
 REP aćete$ at_ćete
 REP ićete$ it_ćete
 REP avaon ovaonic
+REP ^očenaš Očenaš
 REP ićemo$ it_ćemo
 REP ećete$ et_ćete
 REP nućeš$ nut_ćeš
 REP ećemo$ et_ćemo
 REP bčanci$ pčanki
+REP ^rasazn razazn
+REP ^kosmos kozmos
 REP stravn stavn
 REP ^poravo$ pravo
 REP skinj stkinj
+REP reank rejk
+REP ampiš ampinš
 REP ^nezna ne_zna
 REP ^prdon pridon
 REP dreti$ derati
@@ -104,6 +112,7 @@ REP ićeš$ it_ćeš
 REP ^subst supst
 REP aćeš$ at_ćeš
 REP ^obama$ oboma
+REP ^lotus lotos
 REP nuću$ nut_ću
 REP nion nionic
 REP nuće$ nut_će
@@ -117,24 +126,33 @@ REP natn nantn
 REP dvgn dvagn
 REP skma$ skima
 REP ^bimo$ bismo
+REP ^kazin kasin
 REP ^htjeo$ htio
 REP ^menom$ mnom
 REP ^bite$ biste
 REP ^stim$ s_tim
 REP ^polu- polu
+REP ^moće$ može
 REP skme$ skome
 REP nara napra
 REP skmu$ skomu
+REP ^ljud$ ljut
+REP ^paje$ pa_je
 REP ^trab trav
 REP ^trab treb
 REP ^jel$ je_li
 REP bljiv biv
+REP ljiv ljav
 REP najs naes
+REP sup sump
+REP ion ijun
 REP zir rizir
 REP aon aonic
 REP iće$ it_će
 REP šće$ st_će
 REP arn arnic
+REP iju e
+REP tid tud
 REP ^poveč več
 REP aću$ at_ću
 REP iću$ it_ću
@@ -151,10 +169,13 @@ REP skm$ skim
 REP skm$ skom
 REP ioc$ ilac
 REP kno ktno
+REP ije ive
 REP isl i_sl
+REP nest nijet
 REP aoc$ alac
 REP ^mže$ može
 REP rni rnu
+REP rh rth
 REP ljnj nj
 REP mnj mlj
 REP ^bim$ bih
@@ -169,6 +190,8 @@ REP skuj šć
 REP xy ksi
 REP je ije
 REP ^biš$ bi
+REP and ad
+REP ^sa su
 REP ije je
 REP om -om
 REP ći vši
@@ -182,6 +205,7 @@ REP is ijs
 REP un utn
 REP vši ći
 REP ko$ klo
+REP nk ngk
 REP ia ija
 REP lj nj
 REP iju$ e
@@ -190,6 +214,7 @@ REP zk sk
 REP ki$ ci
 REP bč pč
 REP dk tk
+REP dp tp
 REP bs ps
 REP gi zi
 REP zc sc
@@ -217,10 +242,14 @@ REP x ks
 REP c ts
 REP c ds
 REP a -a
+REP a aa
+REP d dd
 REP e ee
 REP u -u
+REP n nn
 REP o oo
 REP u uu
+REP s ss
 REP i je
 REP zš š
 REP j dž
@@ -228,13 +257,48 @@ REP dž č
 REP ^ts c
 REP št š
 REP st s
-REP - _
 REP c k
 REP g h
 REP ć č
 REP č ć
+REP ^a A
+REP ^b B
+REP ^c C
+REP ^č Č
+REP ^ć Ć
+REP ^d D
+REP ^dž Dž
+REP ^đ Đ
+REP ^e E
+REP ^f F
+REP ^g G
+REP ^h H
+REP ^i I
+REP ^j J
+REP ^k K
+REP ^l L
+REP ^lj Lj
+REP ^m M
+REP ^n N
+REP ^nj Nj
+REP ^o O
+REP ^p P
+REP ^q Q
+REP ^r R
+REP ^s S
+REP ^š Š
+REP ^t T
+REP ^u U
+REP ^v V
+REP ^w W
+REP ^x X
+REP ^y Y
+REP ^z Z
+REP ^ž Ž
+REP - _
+
 
-AF 403
+AF 416
 AF ZZ  # 1
 AF ZY  # 2
 AF ZX  # 3
@@ -637,7 +701,20 @@ AF TF  # 399
 AF TE  # 400
 AF TD  # 401
 AF THTGTETC# 402
-AF TB  #403
+AF TB  # 403
+AF TA  # 404
+AF SZ  # 405
+AF SY  # 406
+AF SX  # 407
+AF SW  # 408
+AF SV  # 409
+AF SU  # 410
+AF THTG# 411
+AF ST  # 412
+AF SS  # 413
+AF SOSPSR  # 414
+AF SMSNSR  # 415
+AF SL  # 416
 
 
 SFX XZ Y  21
@@ -3612,6 +3689,7 @@ SFX TF 0 -evoga .
 SFX TF 0 -evome .
 SFX TF 0 -evomu .
 
+
 SFX TE Y 7
 SFX TE 0 -ovac .
 SFX TE 0 -ovca .
@@ -3622,13 +3700,13 @@ SFX TE 0 -ovcem .
 SFX TE 0 -ovcima .
 
 SFX TD Y 7
-SFX TD 0 -evac .
-SFX TD 0 -evca .
-SFX TD 0 -evcu .
-SFX TD 0 -evcem .
-SFX TD 0 -evci .
-SFX TD 0 -evcem .
-SFX TD 0 -evcima .
+SFX TD 0 -evac im
+SFX TD 0 -evca im
+SFX TD 0 -evcu im
+SFX TD 0 -evcem im
+SFX TD 0 -evci im
+SFX TD 0 -evcem im
+SFX TD 0 -evcima im
 
 SFX TC Y 6
 SFX TC 0 -ovka .
@@ -3642,3 +3720,188 @@ SFX TB Y 3
 SFX TB 0 -a .

[Libreoffice-commits] dictionaries.git: hr_HR/hr_HR.aff hr_HR/hr_HR.dic hr_HR/README_hr_HR.txt

[Kruno]

 hr_HR/README_hr_HR.txt |9 
 hr_HR/hr_HR.aff|  285 ++-
 hr_HR/hr_HR.dic|  509 +++--
 3 files changed, 607 insertions(+), 196 deletions(-)

New commits:
commit 6c85a19c887b6147ec7d3a600b51cb2a44284fa2
Author: Kruno 
Date:   Fri Apr 27 21:35:24 2018 +0100

Update Croatian dictionary to version 2.1.1

Change-Id: I8425ab128d04d428ccc99cb6c8abe2635292f143
Reviewed-on: https://gerrit.libreoffice.org/53578
Reviewed-by: Christian Lohmaier 
Tested-by: Christian Lohmaier 

diff --git a/hr_HR/README_hr_HR.txt b/hr_HR/README_hr_HR.txt
index d8bf8df..3f8cc76 100644
--- a/hr_HR/README_hr_HR.txt
+++ b/hr_HR/README_hr_HR.txt
@@ -11,11 +11,16 @@ repository: https://www.github.com/krunose/hr-hunspell
 
 ### Autori i doprinositelji ###
 
-Mirko Kos (m i r k o s 9 9 [ a t ] g m a i l . c o m), 2016. - 2017.
+
+Boris Juric, 2017. - 2018.
+
+-
+
+Mirko Kos (m i r k o s 9 9 [ a t ] g m a i l // c o m), 2016. - 2017.
 
 -
 
-Krunoslav Šebetić (k r u n o . s e [ a t ] g m x . c o m), 2014. - 2017.
+Krunoslav Šebetić (k r u n o . s e [ a t ] g m x // c o m), 2014. - 2018.
 
 -
 
diff --git a/hr_HR/hr_HR.aff b/hr_HR/hr_HR.aff
index 67e56bc..3e91312 100644
--- a/hr_HR/hr_HR.aff
+++ b/hr_HR/hr_HR.aff
@@ -25,6 +25,7 @@ SUBSTANDARD ZO
 FORBIDDENWORD ZN
 WARN ZM
 
+# NOSPLITSUGS
 # SUGSWITHDOTS
 # FORBIDWARN
 
@@ -75,12 +76,14 @@ ICONV ŕ r
 
 
 # REP - .
-REP 157
+REP 219
 REP ^pocrtava podcrtava
 REP ^zdrastv zdravstv
 REP nućemo$ nut_ćemo
 REP nućete$ nut_ćete
 REP ^riječo$ riječ_o
+REP ^usisač usisivač
+REP rejanac rejac
 REP ^prenat prednat
 REP šćemo$ st_ćemo
 REP šćete$ st_ćete
@@ -88,14 +91,19 @@ REP aćemo$ at_ćemo
 REP aćete$ at_ćete
 REP ićete$ it_ćete
 REP avaon ovaonic
+REP ^očenaš Očenaš
 REP ićemo$ it_ćemo
 REP ećete$ et_ćete
 REP nućeš$ nut_ćeš
 REP ećemo$ et_ćemo
 REP bčanci$ pčanki
+REP ^rasazn razazn
+REP ^kosmos kozmos
 REP stravn stavn
 REP ^poravo$ pravo
 REP skinj stkinj
+REP reank rejk
+REP ampiš ampinš
 REP ^nezna ne_zna
 REP ^prdon pridon
 REP dreti$ derati
@@ -104,6 +112,7 @@ REP ićeš$ it_ćeš
 REP ^subst supst
 REP aćeš$ at_ćeš
 REP ^obama$ oboma
+REP ^lotus lotos
 REP nuću$ nut_ću
 REP nion nionic
 REP nuće$ nut_će
@@ -117,24 +126,33 @@ REP natn nantn
 REP dvgn dvagn
 REP skma$ skima
 REP ^bimo$ bismo
+REP ^kazin kasin
 REP ^htjeo$ htio
 REP ^menom$ mnom
 REP ^bite$ biste
 REP ^stim$ s_tim
 REP ^polu- polu
+REP ^moće$ može
 REP skme$ skome
 REP nara napra
 REP skmu$ skomu
+REP ^ljud$ ljut
+REP ^paje$ pa_je
 REP ^trab trav
 REP ^trab treb
 REP ^jel$ je_li
 REP bljiv biv
+REP ljiv ljav
 REP najs naes
+REP sup sump
+REP ion ijun
 REP zir rizir
 REP aon aonic
 REP iće$ it_će
 REP šće$ st_će
 REP arn arnic
+REP iju e
+REP tid tud
 REP ^poveč več
 REP aću$ at_ću
 REP iću$ it_ću
@@ -151,10 +169,13 @@ REP skm$ skim
 REP skm$ skom
 REP ioc$ ilac
 REP kno ktno
+REP ije ive
 REP isl i_sl
+REP nest nijet
 REP aoc$ alac
 REP ^mže$ može
 REP rni rnu
+REP rh rth
 REP ljnj nj
 REP mnj mlj
 REP ^bim$ bih
@@ -169,6 +190,8 @@ REP skuj šć
 REP xy ksi
 REP je ije
 REP ^biš$ bi
+REP and ad
+REP ^sa su
 REP ije je
 REP om -om
 REP ći vši
@@ -182,6 +205,7 @@ REP is ijs
 REP un utn
 REP vši ći
 REP ko$ klo
+REP nk ngk
 REP ia ija
 REP lj nj
 REP iju$ e
@@ -190,6 +214,7 @@ REP zk sk
 REP ki$ ci
 REP bč pč
 REP dk tk
+REP dp tp
 REP bs ps
 REP gi zi
 REP zc sc
@@ -217,10 +242,14 @@ REP x ks
 REP c ts
 REP c ds
 REP a -a
+REP a aa
+REP d dd
 REP e ee
 REP u -u
+REP n nn
 REP o oo
 REP u uu
+REP s ss
 REP i je
 REP zš š
 REP j dž
@@ -228,13 +257,48 @@ REP dž č
 REP ^ts c
 REP št š
 REP st s
-REP - _
 REP c k
 REP g h
 REP ć č
 REP č ć
+REP ^a A
+REP ^b B
+REP ^c C
+REP ^č Č
+REP ^ć Ć
+REP ^d D
+REP ^dž Dž
+REP ^đ Đ
+REP ^e E
+REP ^f F
+REP ^g G
+REP ^h H
+REP ^i I
+REP ^j J
+REP ^k K
+REP ^l L
+REP ^lj Lj
+REP ^m M
+REP ^n N
+REP ^nj Nj
+REP ^o O
+REP ^p P
+REP ^q Q
+REP ^r R
+REP ^s S
+REP ^š Š
+REP ^t T
+REP ^u U
+REP ^v V
+REP ^w W
+REP ^x X
+REP ^y Y
+REP ^z Z
+REP ^ž Ž
+REP - _
+
 
-AF 403
+AF 416
 AF ZZ  # 1
 AF ZY  # 2
 AF ZX  # 3
@@ -637,7 +701,20 @@ AF TF  # 399
 AF TE  # 400
 AF TD  # 401
 AF THTGTETC# 402
-AF TB  #403
+AF TB  # 403
+AF TA  # 404
+AF SZ  # 405
+AF SY  # 406
+AF SX  # 407
+AF SW  # 408
+AF SV  # 409
+AF SU  # 410
+AF THTG# 411
+AF ST  # 412
+AF SS  # 413
+AF SOSPSR  # 414
+AF SMSNSR  # 415
+AF SL  # 416
 
 
 SFX XZ Y  21
@@ -3612,6 +3689,7 @@ SFX TF 0 -evoga .
 SFX TF 0 -evome .
 SFX TF 0 -evomu .
 
+
 SFX TE Y 7
 SFX TE 0 -ovac .
 SFX TE 0 -ovca .
@@ -3622,13 +3700,13 @@ SFX TE 0 -ovcem .
 SFX TE 0 -ovcima .
 
 SFX TD Y 7
-SFX TD 0 -evac .
-SFX TD 0 -evca .
-SFX TD 0 -evcu .
-SFX TD 0 -evcem .
-SFX TD 0 -evci .
-SFX TD 0 -evcem .
-SFX TD 0 -evcima .
+SFX TD 0 -evac im
+SFX TD 0 -evca im
+SFX TD 0 -evcu im
+SFX TD 0 -evcem im
+SFX TD 0 -evci im
+SFX TD 0 -evcem im
+SFX TD 0 -evcima im
 
 SFX TC Y 6
 SFX TC 0 -ovka .
@@ -3642,3 +3720,188 @@ SFX TB Y 3
 SFX TB 0 -a .

[Libreoffice-commits] core.git: dictionaries

[Kruno]

 dictionaries |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ee4bbc3e9d8cca49eea89b99ea8e3836f7a4e224
Author: Kruno 
Date:   Fri Apr 27 21:35:24 2018 +0100

Updated core
Project: dictionaries  6c85a19c887b6147ec7d3a600b51cb2a44284fa2

Update Croatian dictionary to version 2.1.1

Change-Id: I8425ab128d04d428ccc99cb6c8abe2635292f143
Reviewed-on: https://gerrit.libreoffice.org/53578
Reviewed-by: Christian Lohmaier 
Tested-by: Christian Lohmaier 

diff --git a/dictionaries b/dictionaries
index e90e83b23b6a..6c85a19c887b 16
--- a/dictionaries
+++ b/dictionaries
@@ -1 +1 @@
-Subproject commit e90e83b23b6ace35349fc2b3e65bd2d69c80ddd8
+Subproject commit 6c85a19c887b6147ec7d3a600b51cb2a44284fa2
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - svtools/source

[Caolán McNamara]

 svtools/source/misc/embedhlp.cxx |   12 +++-
 1 file changed, 11 insertions(+), 1 deletion(-)

New commits:
commit 1663a364c80fde2ac8396dd2fbcbee4240231271
Author: Caolán McNamara 
Date:   Tue May 29 13:12:12 2018 +0100

forcepoint#43 endless update ole2 preview recursion

Change-Id: I7a6a52d2ea63f840a8a1800fdf7039b1e7b24cdc
Reviewed-on: https://gerrit.libreoffice.org/55004
Tested-by: Jenkins 
Reviewed-by: Christian Lohmaier 

diff --git a/svtools/source/misc/embedhlp.cxx b/svtools/source/misc/embedhlp.cxx
index 45beb0d17853..10cfeff47d23 100644
--- a/svtools/source/misc/embedhlp.cxx
+++ b/svtools/source/misc/embedhlp.cxx
@@ -228,6 +228,7 @@ struct EmbeddedObjectRef_Impl
 sal_Int64   nViewAspect;
 boolbIsLocked:1;
 boolbNeedUpdate:1;
+boolbUpdating:1;
 
 // #i104867#
 sal_uInt32  mnGraphicVersion;
@@ -239,6 +240,7 @@ struct EmbeddedObjectRef_Impl
 nViewAspect(embed::Aspects::MSOLE_CONTENT),
 bIsLocked(false),
 bNeedUpdate(false),
+bUpdating(false),
 mnGraphicVersion(0),
 aDefaultSizeForChart_In_100TH_MM(awt::Size(8000,7000))
 {}
@@ -252,6 +254,7 @@ struct EmbeddedObjectRef_Impl
 nViewAspect(r.nViewAspect),
 bIsLocked(r.bIsLocked),
 bNeedUpdate(r.bNeedUpdate),
+bUpdating(r.bUpdating),
 mnGraphicVersion(0),
 aDefaultSizeForChart_In_100TH_MM(r.aDefaultSizeForChart_In_100TH_MM)
 {
@@ -805,7 +808,14 @@ bool EmbeddedObjectRef::IsGLChart(const 
css::uno::Reference < css::embed::XEmbed
 
 void EmbeddedObjectRef::UpdateReplacement()
 {
-GetReplacement( true );
+if (mpImpl->bUpdating)
+{
+SAL_WARN("svtools.misc", "UpdateReplacement called while 
UpdateReplacement already underway");
+return;
+}
+mpImpl->bUpdating = true;
+GetReplacement(true);
+mpImpl->bUpdating = false;
 }
 
 void EmbeddedObjectRef::UpdateReplacementOnDemand()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - vcl/osx

[Tor Lillqvist]

 vcl/osx/vclnsapp.mm |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit b1eeeaccc3337510df93b147f5905fca3416fc48
Author: Tor Lillqvist 
Date:   Mon May 28 14:41:20 2018 +0300

tdf#117850: Just call _Exit() in our applicationWillTerminate:

Sure, it is just a workaround, but a very effective workaround.

Change-Id: Id0daff048a27dae5cf8fb5e0e949c5b21e03fc86
Reviewed-on: https://gerrit.libreoffice.org/54924
Tested-by: Jenkins 
Reviewed-by: Tor Lillqvist 
(cherry picked from commit aa81a086bd3dcd7d6b830951619f310bd0aff30c)
Reviewed-on: https://gerrit.libreoffice.org/54995
Reviewed-by: Christian Lohmaier 

diff --git a/vcl/osx/vclnsapp.mm b/vcl/osx/vclnsapp.mm
index 09c3a8001f2d..61dac67b5d77 100644
--- a/vcl/osx/vclnsapp.mm
+++ b/vcl/osx/vclnsapp.mm
@@ -22,6 +22,8 @@
 
 #include 
 
+#include 
+
 #include 
 #include 
 #include 
@@ -314,6 +316,7 @@ SAL_WNODEPRECATED_DECLARATIONS_POP
 {
 (void)aNotification;
 sal_detail_deinitialize();
+_Exit(0);
 }
 
 -(NSApplicationTerminateReply)applicationShouldTerminate: (NSApplication *) app
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - vcl/qa vcl/source

[Miklos Vajna]

 vcl/qa/cppunit/pdfexport/data/tdf113143.odp |binary
 vcl/qa/cppunit/pdfexport/pdfexport.cxx  |  173 +---
 vcl/source/gdi/pdfextoutdevdata.cxx |6 
 3 files changed, 114 insertions(+), 65 deletions(-)

New commits:
commit 257014ce03dee29506e8e70c204e912c4ed33172
Author: Miklos Vajna 
Date:   Thu May 24 17:29:13 2018 +0200

tdf#113143 PDF export: fix mis-scaled JPGs on Impress note pages

This is really similar to commit
4c2172a3e973bc6351107a3a1b554c77b40b75dd (tdf#106702 PDF export: fix
missing images from Writer headers/footers, 2018-05-22) just this one is
about the size of the output rectangle for JPG content, while the
previous problem was about the position of them.

Also extract PdfExportTest::exportAndParse() from the last two tests to
avoid duplication.

(cherry picked from commit 89dc667cebfec5315f0c0361e49d759e88458689)

Change-Id: I9812924d505e9fdaca2a95b4990e7aaa5e44fd7f
Reviewed-on: https://gerrit.libreoffice.org/54989
Tested-by: Jenkins 
Reviewed-by: Christian Lohmaier 

diff --git a/vcl/qa/cppunit/pdfexport/data/tdf113143.odp 
b/vcl/qa/cppunit/pdfexport/data/tdf113143.odp
new file mode 100644
index ..5f8a1b10e2e5
Binary files /dev/null and b/vcl/qa/cppunit/pdfexport/data/tdf113143.odp differ
diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx 
b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index 9e6924f2e66a..da3da74fc63d 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -40,8 +40,13 @@ class PdfExportTest : public test::BootstrapFixture, public 
unotest::MacrosTest
 uno::Reference mxComponent;
 FPDF_PAGE mpPdfPage = nullptr;
 FPDF_DOCUMENT mpPdfDocument = nullptr;
+utl::TempFile maTempFile;
+SvMemoryStream maMemory;
+// Export the document as PDF, then parse it with PDFium.
+void exportAndParse(const OUString& rURL, const utl::MediaDescriptor& 
rDescriptor);
 
 public:
+PdfExportTest();
 virtual void setUp() override;
 virtual void tearDown() override;
 void load(const OUString& rFile, vcl::filter::PDFDocument& rDocument);
@@ -77,6 +82,7 @@ public:
 void testTdf109143();
 void testTdf105954();
 void testTdf106702();
+void testTdf113143();
 
 CPPUNIT_TEST_SUITE(PdfExportTest);
 CPPUNIT_TEST(testTdf106059);
@@ -102,9 +108,32 @@ public:
 CPPUNIT_TEST(testTdf109143);
 CPPUNIT_TEST(testTdf105954);
 CPPUNIT_TEST(testTdf106702);
+CPPUNIT_TEST(testTdf113143);
 CPPUNIT_TEST_SUITE_END();
 };
 
+PdfExportTest::PdfExportTest()
+{
+maTempFile.EnableKillingFile();
+}
+
+void PdfExportTest::exportAndParse(const OUString& rURL, const 
utl::MediaDescriptor& rDescriptor)
+{
+// Import the bugdoc and export as PDF.
+mxComponent = loadFromDesktop(rURL);
+CPPUNIT_ASSERT(mxComponent.is());
+
+uno::Reference xStorable(mxComponent, uno::UNO_QUERY);
+xStorable->storeToURL(maTempFile.GetURL(), 
rDescriptor.getAsConstPropertyValueList());
+
+// Parse the export result with pdfium.
+SvFileStream aFile(maTempFile.GetURL(), StreamMode::READ);
+maMemory.WriteStream(aFile);
+mpPdfDocument
+= FPDF_LoadMemDocument(maMemory.GetData(), maMemory.GetSize(), 
/*password=*/nullptr);
+CPPUNIT_ASSERT(mpPdfDocument);
+}
+
 void PdfExportTest::setUp()
 {
 test::BootstrapFixture::setUp();
@@ -142,14 +171,12 @@ void PdfExportTest::load(const OUString& rFile, 
vcl::filter::PDFDocument& rDocum
 CPPUNIT_ASSERT(mxComponent.is());
 
 uno::Reference xStorable(mxComponent, uno::UNO_QUERY);
-utl::TempFile aTempFile;
-aTempFile.EnableKillingFile();
 utl::MediaDescriptor aMediaDescriptor;
 aMediaDescriptor["FilterName"] <<= OUString("writer_pdf_Export");
-xStorable->storeToURL(aTempFile.GetURL(), 
aMediaDescriptor.getAsConstPropertyValueList());
+xStorable->storeToURL(maTempFile.GetURL(), 
aMediaDescriptor.getAsConstPropertyValueList());
 
 // Parse the export result.
-SvFileStream aStream(aTempFile.GetURL(), StreamMode::READ);
+SvFileStream aStream(maTempFile.GetURL(), StreamMode::READ);
 CPPUNIT_ASSERT(rDocument.Read(aStream));
 }
 
@@ -161,8 +188,6 @@ void PdfExportTest::testTdf106059()
 CPPUNIT_ASSERT(mxComponent.is());
 
 uno::Reference xStorable(mxComponent, uno::UNO_QUERY);
-utl::TempFile aTempFile;
-aTempFile.EnableKillingFile();
 utl::MediaDescriptor aMediaDescriptor;
 aMediaDescriptor["FilterName"] <<= OUString("writer_pdf_Export");
 // Explicitly enable the usage of the reference XObject markup.
@@ -170,11 +195,11 @@ void PdfExportTest::testTdf106059()
 {"UseReferenceXObject", uno::Any(true) }
 }));
 aMediaDescriptor["FilterData"] <<= aFilterData;
-xStorable->storeToURL(aTempFile.GetURL(), 
aMediaDescriptor.getAsConstPropertyValueList());
+xStorable->storeToURL(maTempFile.GetURL(), 
aMediaDescriptor.getAsConstPropertyValueList());
 
 

[Libreoffice-commits] core.git: vcl/inc vcl/source

[Stephan Bergmann]

 vcl/inc/sft.hxx|1 -
 vcl/source/fontsubset/ttcr.hxx |1 -
 2 files changed, 2 deletions(-)

New commits:
commit 5a5518f7f0ce977cace7728c977b0c115589b254
Author: Stephan Bergmann 
Date:   Tue May 29 16:04:15 2018 +0200

Remove unused SFErrCodes::TableFormat

...which was apparently unused (under its original name SF_TABLEFORMAT) ever
since its introduction in 571f15004533c1e7a5472e033139d5765862fb73 "Unix PS-
Print Environment".  (Not sure what its appearance in the comment to 
AddTable,
also there since that introductory commit, was ever supposed to mean.)

Change-Id: I363e21e2e2d23aaf17c6f10b3936ba700203b9eb
Reviewed-on: https://gerrit.libreoffice.org/55020
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/vcl/inc/sft.hxx b/vcl/inc/sft.hxx
index c4bdee9f2a76..07146f03aa83 100644
--- a/vcl/inc/sft.hxx
+++ b/vcl/inc/sft.hxx
@@ -69,7 +69,6 @@ namespace vcl
 GlyphNum,/**< incorrect number of glyphs   
*/
 BadArg,  /**< incorrect arguments  
*/
 TtFormat,/**< incorrect TrueType font format   
*/
-TableFormat, /**< incorrect format of a TrueType 
table */
 FontNo   /**< incorrect logical font number of 
a TTC font  */
 };
 
diff --git a/vcl/source/fontsubset/ttcr.hxx b/vcl/source/fontsubset/ttcr.hxx
index 5acd5230ecd8..c1ac5d029dfd 100644
--- a/vcl/source/fontsubset/ttcr.hxx
+++ b/vcl/source/fontsubset/ttcr.hxx
@@ -64,7 +64,6 @@ namespace vcl
 
 /**
  * Adds a TrueType table to the TrueType creator.
- * SFErrCodes::TableFormat value.
  * @return value of SFErrCodes type
  */
 SFErrCodes AddTable(TrueTypeCreator *_this, TrueTypeTable *table);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svx/source

[Caolán McNamara]

 svx/source/dialog/SafeModeDialog.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit dc24a62c59121df2b70b25118b562661c24c2841
Author: Caolán McNamara 
Date:   Tue May 29 20:57:32 2018 +0100

tdf#117862 crash in profile export dialog

Change-Id: Ibb1ab10707262e8f0d36a805ab08562a5f0fecf4
Reviewed-on: https://gerrit.libreoffice.org/55033
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/svx/source/dialog/SafeModeDialog.cxx 
b/svx/source/dialog/SafeModeDialog.cxx
index 33e8912bebc5..d802258d3788 100644
--- a/svx/source/dialog/SafeModeDialog.cxx
+++ b/svx/source/dialog/SafeModeDialog.cxx
@@ -343,7 +343,7 @@ namespace {
 };
 
 ProfileExportedDialog::ProfileExportedDialog(weld::Window* pParent)
-: GenericDialogController(pParent, "svx/ui/profileexporteddialog.ui", 
"GenericDialogController")
+: GenericDialogController(pParent, "svx/ui/profileexporteddialog.ui", 
"ProfileExportedDialog")
 , m_xButton(m_xBuilder->weld_button("ok"))
 {
 m_xButton->connect_clicked(LINK(this, ProfileExportedDialog, OpenHdl));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117862] crash on save user profile

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117862

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - basic/source

[Caolán McNamara]

 basic/source/comp/scanner.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 15ea1cda0b3c37ff944ad9a239b7ed453e8b0591
Author: Caolán McNamara 
Date:   Mon May 28 21:51:01 2018 +0100

forcepoint#42 check available str length

Change-Id: Ie476968ddaa4c3e5475ae9aa6133e7aba38d5975
Reviewed-on: https://gerrit.libreoffice.org/54978
Tested-by: Jenkins 
Reviewed-by: Christian Lohmaier 

diff --git a/basic/source/comp/scanner.cxx b/basic/source/comp/scanner.cxx
index 67177b7d9f44..89f4140a7a60 100644
--- a/basic/source/comp/scanner.cxx
+++ b/basic/source/comp/scanner.cxx
@@ -607,7 +607,7 @@ bool SbiScanner::NextSym()
 case '>': if( *pLine == '=' ) n = 2; break;
 case ':': if( *pLine == '=' ) n = 2; break;
 }
-aSym = aLine.copy( nCol, n );
+aSym = aLine.copy(nCol, std::min(n, aLine.getLength() - nCol));
 pLine += n-1; nCol = nCol + n;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - drawinglayer/source

[Caolán McNamara]

 drawinglayer/source/texture/texture3d.cxx |   11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

New commits:
commit 0a2035492c66bc323d84ad6c2c4cbc0dc3c9d9aa
Author: Caolán McNamara 
Date:   Mon May 28 21:36:16 2018 +0100

forcepoint#41 null deref

Change-Id: I16e9e083811c6e14861da1ba1df7d46e8c8771d7
Reviewed-on: https://gerrit.libreoffice.org/54974
Tested-by: Jenkins 
Reviewed-by: Christian Lohmaier 

diff --git a/drawinglayer/source/texture/texture3d.cxx 
b/drawinglayer/source/texture/texture3d.cxx
index 2120b8f04280..91604803f8eb 100644
--- a/drawinglayer/source/texture/texture3d.cxx
+++ b/drawinglayer/source/texture/texture3d.cxx
@@ -74,8 +74,6 @@ namespace drawinglayer
 {
 // #121194# Todo: use alpha channel, too (for 3d)
 maBitmap = maBitmapEx.GetBitmap();
-mpReadBitmap = Bitmap::ScopedReadAccess(maBitmap);
-OSL_ENSURE(mpReadBitmap, "GeoTexSvxBitmapEx: Got no read access to 
Bitmap (!)");
 
 if(mbIsTransparent)
 {
@@ -92,8 +90,13 @@ namespace drawinglayer
 mpReadTransparence = Bitmap::ScopedReadAccess(maTransparence);
 }
 
-mfMulX = (double)mpReadBitmap->Width() / maSize.getX();
-mfMulY = (double)mpReadBitmap->Height() / maSize.getY();
+mpReadBitmap = Bitmap::ScopedReadAccess(maBitmap);
+SAL_WARN_IF(!mpReadBitmap, "drawinglayer", "GeoTexSvxBitmapEx: Got 
no read access to Bitmap");
+if (mpReadBitmap)
+{
+mfMulX = static_cast(mpReadBitmap->Width()) / 
maSize.getX();
+mfMulY = static_cast(mpReadBitmap->Height()) / 
maSize.getY();
+}
 
 if(maSize.getX() <= 1.0)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sc/qa sc/source

[Caolán McNamara]

 sc/qa/unit/data/xls/forcepoint-pivot-1.xls |binary
 sc/source/filter/excel/xipivot.cxx |8 
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 69c5be9b26cf1a45e220d69f65b1bb0fa2aedaf6
Author: Caolán McNamara 
Date:   Mon May 28 21:22:56 2018 +0100

forcepoint#40 null deref

presumably since

commit 0098bee792c3e208ea4f6ef1c676958d3f4cd207
Date:   Thu Sep 21 06:48:09 2017 +0200

tdf#112501: Pivot table: popupbuttons are placed on wrong cells

Change-Id: I5413c0ba06fca25cb22256a20ef9640767dd9e50
Reviewed-on: https://gerrit.libreoffice.org/54970
Tested-by: Jenkins 
Reviewed-by: Christian Lohmaier 

diff --git a/sc/qa/unit/data/xls/forcepoint-pivot-1.xls 
b/sc/qa/unit/data/xls/forcepoint-pivot-1.xls
new file mode 100644
index ..12919922666b
Binary files /dev/null and b/sc/qa/unit/data/xls/forcepoint-pivot-1.xls differ
diff --git a/sc/source/filter/excel/xipivot.cxx 
b/sc/source/filter/excel/xipivot.cxx
index e63db6cdb1ab..669d6262cc2d 100644
--- a/sc/source/filter/excel/xipivot.cxx
+++ b/sc/source/filter/excel/xipivot.cxx
@@ -1566,13 +1566,13 @@ void XclImpPivotTable::ApplyMergeFlags(const ScRange& 
rOutRange, const ScDPSaveD
 itr= aFieldBtns.begin();
 itrEnd = aFieldBtns.end();
 vector::const_iterator itDim = 
aFieldDims.begin();
-for (; itr != itrEnd; ++itr, ++itDim)
+for (; itr != itrEnd; ++itr)
 {
 ScMF nMFlag = ScMF::Button;
-const ScDPSaveDimension* pDim = *itDim;
-if (pDim->HasInvisibleMember())
+const ScDPSaveDimension* pDim = itDim != aFieldDims.end() ? 
*itDim++ : nullptr;
+if (pDim && pDim->HasInvisibleMember())
 nMFlag |= ScMF::HiddenMember;
-if (!pDim->IsDataLayout())
+if (!pDim || !pDim->IsDataLayout())
 nMFlag |= ScMF::ButtonPopup;
 rDoc.ApplyFlagsTab(itr->Col(), itr->Row(), itr->Col(), itr->Row(), 
itr->Tab(), nMFlag);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - cui/uiconfig

[Caolán McNamara]

 cui/uiconfig/ui/positionsizedialog.ui |2 +-
 cui/uiconfig/ui/possizetabpage.ui |   21 ++---
 cui/uiconfig/ui/rotationtabpage.ui|6 +++---
 3 files changed, 14 insertions(+), 15 deletions(-)

New commits:
commit 49a10ec8ce1f92a29b7ee9f8660b313d1d5c5c5b
Author: Caolán McNamara 
Date:   Tue May 29 10:53:06 2018 +0100

these spinbuttons should be focusable

Change-Id: I5af98ef0815f91b8c615441299eb43d602ebf57b
Reviewed-on: https://gerrit.libreoffice.org/55026
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/uiconfig/ui/positionsizedialog.ui 
b/cui/uiconfig/ui/positionsizedialog.ui
index 792fa764dddc..8b276311627c 100644
--- a/cui/uiconfig/ui/positionsizedialog.ui
+++ b/cui/uiconfig/ui/positionsizedialog.ui
@@ -93,7 +93,7 @@
 
   
 True
-False
+True
 True
 True
 
diff --git a/cui/uiconfig/ui/possizetabpage.ui 
b/cui/uiconfig/ui/possizetabpage.ui
index 76fffb89d621..94e7d628089e 100644
--- a/cui/uiconfig/ui/possizetabpage.ui
+++ b/cui/uiconfig/ui/possizetabpage.ui
@@ -2,7 +2,6 @@
 
 
   
-  
   
 -120
 240
@@ -86,7 +85,7 @@
 
   
 True
-False
+True
 True
 adjustmentPOS
 2
@@ -99,7 +98,7 @@
 
   
 True
-False
+True
 True
 adjustmentPOS1
 2
@@ -249,7 +248,7 @@
 
   
 True
-False
+True
 True
 adjustmentSIZE
 2
@@ -262,7 +261,7 @@
 
   
 True
-False
+True
 True
 adjustmentSIZE1
 2
@@ -276,7 +275,7 @@
   
 _Keep ratio
 True
-False
+True
 False
 True
 0
@@ -316,7 +315,7 @@
   
 
 
-   
+  
 True
 True
 center
@@ -401,7 +400,7 @@
   
 Positio_n
 True
-False
+True
 False
 True
 0
@@ -418,7 +417,7 @@
   
 _Size
 True
-False
+True
 False
 True
 0
@@ -475,7 +474,7 @@
   
 _Fit width to text
 True
-False
+True
 False
 True
 0
@@ -492,7 +491,7 @@
   
 Fit _height to text
 True
-False
+True
 False
 True
 0
diff --git a/cui/uiconfig/ui/rotationtabpage.ui 
b/cui/uiconfig/ui/rotationtabpage.ui
index af5f9ec6260c..0bb66f4d4282 100644
--- a/cui/uiconfig/ui/rotationtabpage.ui
+++ b/cui/uiconfig/ui/rotationtabpage.ui
@@ -80,7 +80,7 @@
 
   
 True
-False
+True
 True
 adjustmentPOS1
 2
@@ -93,7 +93,7 @@
 
   
 True
-False
+True
 True
 adjustmentPOS2
 2
@@ -231,7 +231,7 @@
 
   
 True
-False
+True
 True
 adjustmentANGLE
 2
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - chart2/source cui/source cui/uiconfig include/sfx2 include/svx sc/source sd/source sfx2/source svx/source sw/source

[Caolán McNamara]

 chart2/source/controller/main/ChartController_Position.cxx |3 
 chart2/source/controller/main/ShapeController.cxx  |2 
 cui/source/factory/dlgfact.cxx |   50 +++--
 cui/source/factory/dlgfact.hxx |   27 +-
 cui/source/inc/transfrm.hxx|   19 -
 cui/source/tabpages/transfrm.cxx   |   86 +++-
 cui/uiconfig/ui/positionsizedialog.ui  |  127 +++--
 include/sfx2/tabdlg.hxx|2 
 include/svx/svxdlg.hxx |   17 -
 sc/source/ui/drawfunc/drawsh.cxx   |2 
 sd/source/ui/func/futransf.cxx |6 
 sfx2/source/dialog/tabdlg.cxx  |7 
 svx/source/dialog/dialcontrol.cxx  |4 
 sw/source/uibase/shells/drwbassh.cxx   |2 
 14 files changed, 235 insertions(+), 119 deletions(-)

New commits:
commit eff752aec065d02a98693fff6c12092cb3c35176
Author: Caolán McNamara 
Date:   Tue May 29 09:32:41 2018 +0100

weld SvxTransformTabDialog

Change-Id: Ib6dabd04e3f834b61363d5a620de7f0219a1e644
Reviewed-on: https://gerrit.libreoffice.org/55018
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/chart2/source/controller/main/ChartController_Position.cxx 
b/chart2/source/controller/main/ChartController_Position.cxx
index 37b0ef9ef208..2304bb72cda0 100644
--- a/chart2/source/controller/main/ChartController_Position.cxx
+++ b/chart2/source/controller/main/ChartController_Position.cxx
@@ -136,8 +136,9 @@ void ChartController::executeDispatch_PositionAndSize()
 SolarMutexGuard aGuard;
 SvxAbstractDialogFactory * pFact = SvxAbstractDialogFactory::Create();
 OSL_ENSURE( pFact, "No dialog factory" );
+vcl::Window* pWin = GetChartWindow();
 ScopedVclPtr 
pDlg(pFact->CreateSchTransformTabDialog(
-GetChartWindow(), , pSdrView, bResizePossible ));
+pWin ? pWin->GetFrameWeld() : nullptr, , pSdrView, 
bResizePossible));
 OSL_ENSURE( pDlg, "Couldn't create SchTransformTabDialog" );
 
 if( pDlg->Execute() == RET_OK )
diff --git a/chart2/source/controller/main/ShapeController.cxx 
b/chart2/source/controller/main/ShapeController.cxx
index 1b6a89b94985..80203f179b83 100644
--- a/chart2/source/controller/main/ShapeController.cxx
+++ b/chart2/source/controller/main/ShapeController.cxx
@@ -399,7 +399,7 @@ void ShapeController::executeDispatch_TransformDialog()
 if ( pFact )
 {
 ScopedVclPtr< SfxAbstractTabDialog > pDlg(
-pFact->CreateSvxTransformTabDialog( pChartWindow, 
, pDrawViewWrapper ) );
+pFact->CreateSvxTransformTabDialog(pChartWindow ? 
pChartWindow->GetFrameWeld() : nullptr, , pDrawViewWrapper));
 if ( pDlg.get() && ( pDlg->Execute() == RET_OK ) )
 {
 const SfxItemSet* pOutAttr = pDlg->GetOutputItemSet();
diff --git a/cui/source/factory/dlgfact.cxx b/cui/source/factory/dlgfact.cxx
index a5c76ef405ab..05c404a88b5e 100644
--- a/cui/source/factory/dlgfact.cxx
+++ b/cui/source/factory/dlgfact.cxx
@@ -130,7 +130,16 @@ short AbstractSvxSearchSimilarityDialog_Impl::Execute()
 return m_xDlg->run();
 }
 
-IMPL_ABSTDLG_BASE(AbstractSvxTransformTabDialog_Impl);
+short AbstractSvxTransformTabDialog_Impl::Execute()
+{
+return m_xDlg->execute();
+}
+
+bool AbstractSvxTransformTabDialog_Impl::StartExecuteAsync(AsyncContext )
+{
+return SfxTabDialogController::runAsync(m_xDlg, rCtx.maEndDialogFn);
+}
+
 IMPL_ABSTDLG_BASE(AbstractSvxCaptionDialog_Impl);
 IMPL_ABSTDLG_BASE(AbstractSvxJSearchOptionsDialog_Impl);
 
@@ -579,31 +588,33 @@ bool AbstractSvxSearchSimilarityDialog_Impl::IsRelaxed()
 // AbstractSvxTransformTabDialog implementations just forwards everything to 
the dialog
 void AbstractSvxTransformTabDialog_Impl::SetCurPageId( const OString& rName )
 {
-pDlg->SetCurPageId( rName );
+m_xDlg->SetCurPageId( rName );
 }
 
 const SfxItemSet* AbstractSvxTransformTabDialog_Impl::GetOutputItemSet() const
 {
-return pDlg->GetOutputItemSet();
+return m_xDlg->GetOutputItemSet();
 }
 
 const sal_uInt16* AbstractSvxTransformTabDialog_Impl::GetInputRanges(const 
SfxItemPool& pItem )
 {
-return pDlg->GetInputRanges( pItem );
+return m_xDlg->GetInputRanges( pItem );
 }
 
 void AbstractSvxTransformTabDialog_Impl::SetInputSet( const SfxItemSet* pInSet 
)
 {
- pDlg->SetInputSet( pInSet );
+ m_xDlg->SetInputSet( pInSet );
 }
+
 //From class Window.
 void AbstractSvxTransformTabDialog_Impl::SetText( const OUString& rStr )
 {
-pDlg->SetText( rStr );
+m_xDlg->set_title(rStr);
 }
+
 void AbstractSvxTransformTabDialog_Impl::SetValidateFramePosLink( const 
Link& 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - include/sfx2 sfx2/source

[Caolán McNamara]

 include/sfx2/tabdlg.hxx   |1 +
 sfx2/source/dialog/tabdlg.cxx |   40 +---
 2 files changed, 26 insertions(+), 15 deletions(-)

New commits:
commit efdc9425394e790c325644cd32f537341594f0b8
Author: Caolán McNamara 
Date:   Tue May 29 10:43:11 2018 +0100

we need to be able to query the ranges before creating the pages

so don't create the pages until the first execute

Change-Id: I5ecc31d5a08bae44c0a912e39b786420f2da86ee
Reviewed-on: https://gerrit.libreoffice.org/55015
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/include/sfx2/tabdlg.hxx b/include/sfx2/tabdlg.hxx
index 9da02d5c371e..a83573d1dfa6 100644
--- a/include/sfx2/tabdlg.hxx
+++ b/include/sfx2/tabdlg.hxx
@@ -249,6 +249,7 @@ private:
 DECL_DLLPRIVATE_LINK(ActivatePageHdl, const OString&, void);
 DECL_DLLPRIVATE_LINK(DeactivatePageHdl, const OString&, bool);
 SAL_DLLPRIVATE void Init_Impl(bool bFmtFlag);
+SAL_DLLPRIVATE void CreatePages();
 
 protected:
 virtual short   Ok();
diff --git a/sfx2/source/dialog/tabdlg.cxx b/sfx2/source/dialog/tabdlg.cxx
index 31be0ca30543..5ccfb377fd0b 100644
--- a/sfx2/source/dialog/tabdlg.cxx
+++ b/sfx2/source/dialog/tabdlg.cxx
@@ -1615,6 +1615,8 @@ IMPL_LINK(SfxTabDialogController, ActivatePageHdl, const 
OString&, rPage, void)
 }
 
 VclPtr pTabPage = pDataObject->pTabPage;
+if (!pTabPage)
+return;
 
 if (pDataObject->bRefresh)
 pTabPage->Reset(m_pSet);
@@ -1935,24 +1937,30 @@ void SfxTabDialogController::AddTabPage
 )
 {
 m_pImpl->aData.push_back(new Data_Impl(m_pImpl->aData.size(), rName, 
pCreateFunc, pRangesFunc));
-Data_Impl* pDataObject = m_pImpl->aData.back();
+}
 
-assert(pDataObject->pTabPage == nullptr && "create TabPage more than 
once");
-weld::Container* pPage = m_xTabCtrl->get_page(rName);
-pDataObject->pTabPage = (pDataObject->fnCreatePage)(pPage, m_pSet);
-pDataObject->pTabPage->SetDialogController(this);
+void SfxTabDialogController::CreatePages()
+{
+for (auto pDataObject : m_pImpl->aData)
+{
+if (pDataObject->pTabPage)
+   continue;
+weld::Container* pPage = m_xTabCtrl->get_page(pDataObject->sId);
+pDataObject->pTabPage = (pDataObject->fnCreatePage)(pPage, m_pSet);
+pDataObject->pTabPage->SetDialogController(this);
 
-OUString sConfigId = 
OStringToOUString(pDataObject->pTabPage->GetConfigId(), RTL_TEXTENCODING_UTF8);
-SvtViewOptions aPageOpt(EViewType::TabPage, sConfigId);
-OUString sUserData;
-Any aUserItem = aPageOpt.GetUserItem(USERITEM_NAME);
-OUString aTemp;
-if ( aUserItem >>= aTemp )
-sUserData = aTemp;
-pDataObject->pTabPage->SetUserData(sUserData);
+OUString sConfigId = 
OStringToOUString(pDataObject->pTabPage->GetConfigId(), RTL_TEXTENCODING_UTF8);
+SvtViewOptions aPageOpt(EViewType::TabPage, sConfigId);
+OUString sUserData;
+Any aUserItem = aPageOpt.GetUserItem(USERITEM_NAME);
+OUString aTemp;
+if ( aUserItem >>= aTemp )
+sUserData = aTemp;
+pDataObject->pTabPage->SetUserData(sUserData);
 
-PageCreated(rName, *pDataObject->pTabPage);
-pDataObject->pTabPage->Reset(m_pSet);
+PageCreated(pDataObject->sId, *pDataObject->pTabPage);
+pDataObject->pTabPage->Reset(m_pSet);
+}
 }
 
 void SfxTabDialogController::RemoveTabPage(const OString& rId)
@@ -1996,6 +2004,8 @@ void SfxTabDialogController::RemoveTabPage(const OString& 
rId)
 
 void SfxTabDialogController::Start_Impl()
 {
+CreatePages();
+
 assert(m_pImpl->aData.size() == 
static_cast(m_xTabCtrl->get_n_pages())
 && "not all pages registered");
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - vcl/unx

[Caolán McNamara]

 vcl/unx/gtk3/gtk3gtkinst.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 5dc1b50e952765b160395aef15730c71864786ff
Author: Caolán McNamara 
Date:   Tue May 29 12:41:07 2018 +0100

disable inconsistent when setting true/false

Change-Id: Ib612e7f38c7a1a638d69af2a6d26f1293fe0c8da
Reviewed-on: https://gerrit.libreoffice.org/55017
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index e956f4a3c93b..577d5e1d2744 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -2692,6 +2692,7 @@ public:
 virtual void set_active(bool active) override
 {
 disable_notify_events();
+gtk_toggle_button_set_inconsistent(m_pToggleButton, false);
 gtk_toggle_button_set_active(m_pToggleButton, active);
 enable_notify_events();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: chart2/source cui/source cui/uiconfig include/sfx2 include/svx sc/source sd/source sfx2/source svx/source sw/source

[Caolán McNamara]

 chart2/source/controller/main/ChartController_Position.cxx |3 
 chart2/source/controller/main/ShapeController.cxx  |2 
 cui/source/factory/dlgfact.cxx |   50 +++--
 cui/source/factory/dlgfact.hxx |   27 +-
 cui/source/inc/transfrm.hxx|   19 -
 cui/source/tabpages/transfrm.cxx   |   86 +++-
 cui/uiconfig/ui/positionsizedialog.ui  |  127 +++--
 include/sfx2/tabdlg.hxx|2 
 include/svx/svxdlg.hxx |   17 -
 sc/source/ui/drawfunc/drawsh.cxx   |2 
 sd/source/ui/func/futransf.cxx |6 
 sfx2/source/dialog/tabdlg.cxx  |7 
 svx/source/dialog/dialcontrol.cxx  |4 
 sw/source/uibase/shells/drwbassh.cxx   |2 
 14 files changed, 235 insertions(+), 119 deletions(-)

New commits:
commit 6d0d201b30122395eb164807b93d76d567ff970b
Author: Caolán McNamara 
Date:   Tue May 29 09:32:41 2018 +0100

weld SvxTransformTabDialog

Change-Id: Ib6dabd04e3f834b61363d5a620de7f0219a1e644
Reviewed-on: https://gerrit.libreoffice.org/55012
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/chart2/source/controller/main/ChartController_Position.cxx 
b/chart2/source/controller/main/ChartController_Position.cxx
index 37b0ef9ef208..2304bb72cda0 100644
--- a/chart2/source/controller/main/ChartController_Position.cxx
+++ b/chart2/source/controller/main/ChartController_Position.cxx
@@ -136,8 +136,9 @@ void ChartController::executeDispatch_PositionAndSize()
 SolarMutexGuard aGuard;
 SvxAbstractDialogFactory * pFact = SvxAbstractDialogFactory::Create();
 OSL_ENSURE( pFact, "No dialog factory" );
+vcl::Window* pWin = GetChartWindow();
 ScopedVclPtr 
pDlg(pFact->CreateSchTransformTabDialog(
-GetChartWindow(), , pSdrView, bResizePossible ));
+pWin ? pWin->GetFrameWeld() : nullptr, , pSdrView, 
bResizePossible));
 OSL_ENSURE( pDlg, "Couldn't create SchTransformTabDialog" );
 
 if( pDlg->Execute() == RET_OK )
diff --git a/chart2/source/controller/main/ShapeController.cxx 
b/chart2/source/controller/main/ShapeController.cxx
index 1b6a89b94985..80203f179b83 100644
--- a/chart2/source/controller/main/ShapeController.cxx
+++ b/chart2/source/controller/main/ShapeController.cxx
@@ -399,7 +399,7 @@ void ShapeController::executeDispatch_TransformDialog()
 if ( pFact )
 {
 ScopedVclPtr< SfxAbstractTabDialog > pDlg(
-pFact->CreateSvxTransformTabDialog( pChartWindow, 
, pDrawViewWrapper ) );
+pFact->CreateSvxTransformTabDialog(pChartWindow ? 
pChartWindow->GetFrameWeld() : nullptr, , pDrawViewWrapper));
 if ( pDlg.get() && ( pDlg->Execute() == RET_OK ) )
 {
 const SfxItemSet* pOutAttr = pDlg->GetOutputItemSet();
diff --git a/cui/source/factory/dlgfact.cxx b/cui/source/factory/dlgfact.cxx
index a5c76ef405ab..05c404a88b5e 100644
--- a/cui/source/factory/dlgfact.cxx
+++ b/cui/source/factory/dlgfact.cxx
@@ -130,7 +130,16 @@ short AbstractSvxSearchSimilarityDialog_Impl::Execute()
 return m_xDlg->run();
 }
 
-IMPL_ABSTDLG_BASE(AbstractSvxTransformTabDialog_Impl);
+short AbstractSvxTransformTabDialog_Impl::Execute()
+{
+return m_xDlg->execute();
+}
+
+bool AbstractSvxTransformTabDialog_Impl::StartExecuteAsync(AsyncContext )
+{
+return SfxTabDialogController::runAsync(m_xDlg, rCtx.maEndDialogFn);
+}
+
 IMPL_ABSTDLG_BASE(AbstractSvxCaptionDialog_Impl);
 IMPL_ABSTDLG_BASE(AbstractSvxJSearchOptionsDialog_Impl);
 
@@ -579,31 +588,33 @@ bool AbstractSvxSearchSimilarityDialog_Impl::IsRelaxed()
 // AbstractSvxTransformTabDialog implementations just forwards everything to 
the dialog
 void AbstractSvxTransformTabDialog_Impl::SetCurPageId( const OString& rName )
 {
-pDlg->SetCurPageId( rName );
+m_xDlg->SetCurPageId( rName );
 }
 
 const SfxItemSet* AbstractSvxTransformTabDialog_Impl::GetOutputItemSet() const
 {
-return pDlg->GetOutputItemSet();
+return m_xDlg->GetOutputItemSet();
 }
 
 const sal_uInt16* AbstractSvxTransformTabDialog_Impl::GetInputRanges(const 
SfxItemPool& pItem )
 {
-return pDlg->GetInputRanges( pItem );
+return m_xDlg->GetInputRanges( pItem );
 }
 
 void AbstractSvxTransformTabDialog_Impl::SetInputSet( const SfxItemSet* pInSet 
)
 {
- pDlg->SetInputSet( pInSet );
+ m_xDlg->SetInputSet( pInSet );
 }
+
 //From class Window.
 void AbstractSvxTransformTabDialog_Impl::SetText( const OUString& rStr )
 {
-pDlg->SetText( rStr );
+m_xDlg->set_title(rStr);
 }
+
 void AbstractSvxTransformTabDialog_Impl::SetValidateFramePosLink( const 
Link& 

[Libreoffice-commits] core.git: include/sfx2 sfx2/source

[Caolán McNamara]

 include/sfx2/tabdlg.hxx   |1 +
 sfx2/source/dialog/tabdlg.cxx |   40 +---
 2 files changed, 26 insertions(+), 15 deletions(-)

New commits:
commit ba0408ae9a4ac1b391944b2fdcfd02f86ab2f773
Author: Caolán McNamara 
Date:   Tue May 29 10:43:11 2018 +0100

we need to be able to query the ranges before creating the pages

so don't create the pages until the first execute

Change-Id: I5ecc31d5a08bae44c0a912e39b786420f2da86ee
Reviewed-on: https://gerrit.libreoffice.org/55007
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/include/sfx2/tabdlg.hxx b/include/sfx2/tabdlg.hxx
index 9da02d5c371e..a83573d1dfa6 100644
--- a/include/sfx2/tabdlg.hxx
+++ b/include/sfx2/tabdlg.hxx
@@ -249,6 +249,7 @@ private:
 DECL_DLLPRIVATE_LINK(ActivatePageHdl, const OString&, void);
 DECL_DLLPRIVATE_LINK(DeactivatePageHdl, const OString&, bool);
 SAL_DLLPRIVATE void Init_Impl(bool bFmtFlag);
+SAL_DLLPRIVATE void CreatePages();
 
 protected:
 virtual short   Ok();
diff --git a/sfx2/source/dialog/tabdlg.cxx b/sfx2/source/dialog/tabdlg.cxx
index 31be0ca30543..5ccfb377fd0b 100644
--- a/sfx2/source/dialog/tabdlg.cxx
+++ b/sfx2/source/dialog/tabdlg.cxx
@@ -1615,6 +1615,8 @@ IMPL_LINK(SfxTabDialogController, ActivatePageHdl, const 
OString&, rPage, void)
 }
 
 VclPtr pTabPage = pDataObject->pTabPage;
+if (!pTabPage)
+return;
 
 if (pDataObject->bRefresh)
 pTabPage->Reset(m_pSet);
@@ -1935,24 +1937,30 @@ void SfxTabDialogController::AddTabPage
 )
 {
 m_pImpl->aData.push_back(new Data_Impl(m_pImpl->aData.size(), rName, 
pCreateFunc, pRangesFunc));
-Data_Impl* pDataObject = m_pImpl->aData.back();
+}
 
-assert(pDataObject->pTabPage == nullptr && "create TabPage more than 
once");
-weld::Container* pPage = m_xTabCtrl->get_page(rName);
-pDataObject->pTabPage = (pDataObject->fnCreatePage)(pPage, m_pSet);
-pDataObject->pTabPage->SetDialogController(this);
+void SfxTabDialogController::CreatePages()
+{
+for (auto pDataObject : m_pImpl->aData)
+{
+if (pDataObject->pTabPage)
+   continue;
+weld::Container* pPage = m_xTabCtrl->get_page(pDataObject->sId);
+pDataObject->pTabPage = (pDataObject->fnCreatePage)(pPage, m_pSet);
+pDataObject->pTabPage->SetDialogController(this);
 
-OUString sConfigId = 
OStringToOUString(pDataObject->pTabPage->GetConfigId(), RTL_TEXTENCODING_UTF8);
-SvtViewOptions aPageOpt(EViewType::TabPage, sConfigId);
-OUString sUserData;
-Any aUserItem = aPageOpt.GetUserItem(USERITEM_NAME);
-OUString aTemp;
-if ( aUserItem >>= aTemp )
-sUserData = aTemp;
-pDataObject->pTabPage->SetUserData(sUserData);
+OUString sConfigId = 
OStringToOUString(pDataObject->pTabPage->GetConfigId(), RTL_TEXTENCODING_UTF8);
+SvtViewOptions aPageOpt(EViewType::TabPage, sConfigId);
+OUString sUserData;
+Any aUserItem = aPageOpt.GetUserItem(USERITEM_NAME);
+OUString aTemp;
+if ( aUserItem >>= aTemp )
+sUserData = aTemp;
+pDataObject->pTabPage->SetUserData(sUserData);
 
-PageCreated(rName, *pDataObject->pTabPage);
-pDataObject->pTabPage->Reset(m_pSet);
+PageCreated(pDataObject->sId, *pDataObject->pTabPage);
+pDataObject->pTabPage->Reset(m_pSet);
+}
 }
 
 void SfxTabDialogController::RemoveTabPage(const OString& rId)
@@ -1996,6 +2004,8 @@ void SfxTabDialogController::RemoveTabPage(const OString& 
rId)
 
 void SfxTabDialogController::Start_Impl()
 {
+CreatePages();
+
 assert(m_pImpl->aData.size() == 
static_cast(m_xTabCtrl->get_n_pages())
 && "not all pages registered");
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - vcl/unx

[Caolán McNamara]

 vcl/unx/gtk3/gtk3gtkinst.cxx |   14 ++
 1 file changed, 14 insertions(+)

New commits:
commit 9773f6140e9c990f6f7e4ea366580cb94bd1539c
Author: Caolán McNamara 
Date:   Tue May 29 11:26:07 2018 +0100

only get notified for user events, not api ones

Change-Id: I4cbede587ed4de7950fd7ca435902baa26c8faf5
Reviewed-on: https://gerrit.libreoffice.org/55014
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 28ef5090b1fd..e956f4a3c93b 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -2514,9 +2514,23 @@ public:
 return OUString(pStr, pStr ? strlen(pStr) : 0, RTL_TEXTENCODING_UTF8);
 }
 
+virtual void disable_notify_events() override
+{
+g_signal_handler_block(m_pNotebook, m_nSignalId);
+GtkInstanceContainer::disable_notify_events();
+}
+
+virtual void enable_notify_events() override
+{
+GtkInstanceContainer::enable_notify_events();
+g_signal_handler_unblock(m_pNotebook, m_nSignalId);
+}
+
 virtual void remove_page(const OString& rIdent) override
 {
+disable_notify_events();
 gtk_notebook_remove_page(m_pNotebook, get_page_number(rIdent));
+enable_notify_events();
 }
 
 virtual ~GtkInstanceNotebook() override
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - cui/source

[Caolán McNamara]

 cui/source/tabpages/transfrm.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit 91ea25d7579ac1830e428fcefbf522c0b4da2a97
Author: Caolán McNamara 
Date:   Tue May 29 13:53:35 2018 +0100

fix pow by digits

Change-Id: I715b85fa1c1e3f6c391c742f861e3791a505a570
Reviewed-on: https://gerrit.libreoffice.org/55013
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/tabpages/transfrm.cxx b/cui/source/tabpages/transfrm.cxx
index cf3bc446a78e..0f5894d8d550 100644
--- a/cui/source/tabpages/transfrm.cxx
+++ b/cui/source/tabpages/transfrm.cxx
@@ -1071,6 +1071,8 @@ void SvxPositionSizeTabPage::Reset( const SfxItemSet*  )
 pItem = GetItem( mrOutAttrs, SID_ATTR_TRANSFORM_WIDTH );
 mfOldWidth = std::max( pItem ? static_cast(static_cast(pItem)->GetValue()) : 0.0, 1.0 );
 double 
fTmpWidth((OutputDevice::LogicToLogic(static_cast(mfOldWidth), 
mePoolUnit, MapUnit::Map100thMM)) / fUIScale);
+if (m_xMtrWidth->get_digits())
+fTmpWidth *= pow(10.0, m_xMtrWidth->get_digits());
 m_xMtrWidth->set_value(static_cast(fTmpWidth), FUNIT_100TH_MM);
 }
 
@@ -1078,6 +1080,8 @@ void SvxPositionSizeTabPage::Reset( const SfxItemSet*  )
 pItem = GetItem( mrOutAttrs, SID_ATTR_TRANSFORM_HEIGHT );
 mfOldHeight = std::max( pItem ? static_cast(static_cast(pItem)->GetValue()) : 0.0, 1.0 );
 double 
fTmpHeight((OutputDevice::LogicToLogic(static_cast(mfOldHeight), 
mePoolUnit, MapUnit::Map100thMM)) / fUIScale);
+if (m_xMtrHeight->get_digits())
+fTmpHeight *= pow(10.0, m_xMtrHeight->get_digits());
 m_xMtrHeight->set_value(static_cast(fTmpHeight), FUNIT_100TH_MM);
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - vcl/unx

[Caolán McNamara]

 vcl/unx/gtk3/gtk3gtkinst.cxx |   15 ---
 1 file changed, 8 insertions(+), 7 deletions(-)

New commits:
commit cb65109caf5ba5b2c04202464a435c658a4a1ccc
Author: Caolán McNamara 
Date:   Tue May 29 14:23:03 2018 +0100

remember button pressed to reuse for move

Change-Id: I4a7f5bb8e46e190f33150f666a653bfc04957a0f
Reviewed-on: https://gerrit.libreoffice.org/55016
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 9a1d58098e74..28ef5090b1fd 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -3647,6 +3647,7 @@ private:
 ScopedVclPtrInstance m_xDevice;
 std::vector m_aBuffer;
 cairo_surface_t* m_pSurface;
+sal_uInt16 m_nLastMouseButton;
 gulong m_nDrawSignalId;
 gulong m_nSizeAllocateSignalId;
 gulong m_nButtonPressSignalId;
@@ -3776,17 +3777,16 @@ private:
 return false;
 }
 
-sal_uInt16 nButton;
 switch (pEvent->button)
 {
 case 1:
-nButton = MOUSE_LEFT;
+m_nLastMouseButton = MOUSE_LEFT;
 break;
 case 2:
-nButton = MOUSE_MIDDLE;
+m_nLastMouseButton = MOUSE_MIDDLE;
 break;
 case 3:
-nButton = MOUSE_RIGHT;
+m_nLastMouseButton = MOUSE_RIGHT;
 break;
 default:
 return false;
@@ -3794,8 +3794,8 @@ private:
 
 Point aPos(pEvent->x, pEvent->y);
 sal_uInt32 nModCode = GtkSalFrame::GetMouseModCode(pEvent->state);
-sal_uInt16 nCode = nButton | (nModCode & (KEY_SHIFT | KEY_MOD1 | 
KEY_MOD2));
-MouseEvent aMEvt(aPos, nClicks, ImplGetMouseButtonMode(nButton, 
nModCode), nCode, nCode);
+sal_uInt16 nCode = m_nLastMouseButton | (nModCode & (KEY_SHIFT | 
KEY_MOD1 | KEY_MOD2));
+MouseEvent aMEvt(aPos, nClicks, 
ImplGetMouseButtonMode(m_nLastMouseButton, nModCode), nCode, nCode);
 
 if (nEventType == SalEvent::MouseButtonDown)
 m_aMousePressHdl.Call(aMEvt);
@@ -3814,7 +3814,7 @@ private:
 {
 Point aPos(pEvent->x, pEvent->y);
 sal_uInt32 nModCode = GtkSalFrame::GetMouseModCode(pEvent->state);
-sal_uInt16 nCode = (nModCode & (KEY_SHIFT | KEY_MOD1 | KEY_MOD2));
+sal_uInt16 nCode = m_nLastMouseButton | (nModCode & (KEY_SHIFT | 
KEY_MOD1 | KEY_MOD2));
 MouseEvent aMEvt(aPos, 0, ImplGetMouseMoveMode(nModCode), nCode, 
nCode);
 
 m_aMouseMotionHdl.Call(aMEvt);
@@ -3854,6 +3854,7 @@ public:
 , m_pAccessible(nullptr)
 , m_xDevice(nullptr, Size(1, 1), DeviceFormat::DEFAULT)
 , m_pSurface(nullptr)
+, m_nLastMouseButton(0)
 , m_nDrawSignalId(g_signal_connect(m_pDrawingArea, "draw", 
G_CALLBACK(signalDraw), this))
 , m_nSizeAllocateSignalId(g_signal_connect(m_pDrawingArea, 
"size_allocate", G_CALLBACK(signalSizeAllocate), this))
 , m_nButtonPressSignalId(g_signal_connect(m_pDrawingArea, 
"button-press-event", G_CALLBACK(signalButton), this))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sfx2/source

[Caolán McNamara]

 sfx2/source/appl/newhelp.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 509df47d2165fd08a7e0d270cade28ff52da532e
Author: Caolán McNamara 
Date:   Tue May 29 16:35:27 2018 +0100

Resolves: tdf#117712 closing help crashes

since...

commit 9fa32e5dce345dea17129587c401c03520fb398b
Date:   Wed May 16 11:54:52 2018 +0200

fix leak of HelpListener_Impl in SfxHelpWindow_Impl

Change-Id: I7e2cbb5d0c69e96fc7f2e1cc0c5563203c1f3dce
Reviewed-on: https://gerrit.libreoffice.org/55024
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sfx2/source/appl/newhelp.hxx b/sfx2/source/appl/newhelp.hxx
index ab95c195ec77..133502e6fef8 100644
--- a/sfx2/source/appl/newhelp.hxx
+++ b/sfx2/source/appl/newhelp.hxx
@@ -503,7 +503,7 @@ friend class SfxHelpIndexWindow_Impl;
 VclPtrpIndexWin;
 VclPtr pTextWin;
 HelpInterceptor_Impl*   pHelpInterceptor;
-std::unique_ptr pHelpListener;
+rtl::Reference pHelpListener;
 
 sal_Int32   nExpandWidth;
 sal_Int32   nCollapseWidth;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - vcl/inc vcl/unx

[Caolán McNamara]

 vcl/inc/unx/salobj.h  |1 +
 vcl/unx/generic/window/salobj.cxx |   12 +---
 2 files changed, 6 insertions(+), 7 deletions(-)

New commits:
commit d9c5e7f4aef8da58b2b59e3259d1704296648cbf
Author: Caolán McNamara 
Date:   Mon May 28 10:48:32 2018 +0100

tdf#117628 crash after closing media player with X11 backend

Change-Id: I812da5ddf7343573f93ea64e592442edb31cad2d
Reviewed-on: https://gerrit.libreoffice.org/54912
Tested-by: Jenkins 
Reviewed-by: Christian Lohmaier 

diff --git a/vcl/inc/unx/salobj.h b/vcl/inc/unx/salobj.h
index 8eb91b917efe..4a0535507dc2 100644
--- a/vcl/inc/unx/salobj.h
+++ b/vcl/inc/unx/salobj.h
@@ -56,6 +56,7 @@ class VCLPLUG_GEN_PUBLIC X11SalObject : public SalObject
 public:
 SystemEnvData maSystemChildData;
 SalFrame*   mpParent;
+::WindowmaParentWin;
 ::WindowmaPrimary;
 ::WindowmaSecondary;
 ColormapmaColormap;
diff --git a/vcl/unx/generic/window/salobj.cxx 
b/vcl/unx/generic/window/salobj.cxx
index 9d0833094c1d..de41bc8bf8cb 100644
--- a/vcl/unx/generic/window/salobj.cxx
+++ b/vcl/unx/generic/window/salobj.cxx
@@ -62,7 +62,8 @@ X11SalObject* X11SalObject::CreateObject( SalFrame* pParent, 
SystemWindowData* p
 SalDisplay* pSalDisp= 
vcl_sal::getSalDisplay(GetGenericUnixSalData());
 const SystemEnvData* pEnv   = pParent->GetSystemData();
 Display* pDisp  = pSalDisp->GetDisplay();
-::Window aObjectParent  = (::Window)pEnv->aWindow;
+::Window aObjectParent  = static_cast<::Window>(pEnv->aWindow);
+pObject->maParentWin = aObjectParent;
 
 // find out on which screen that window is
 XWindowAttributes aParentAttr;
@@ -235,8 +236,7 @@ X11SalObject::~X11SalObject()
 rObjects.remove( this );
 
 GetGenericUnixSalData()->ErrorTrapPush();
-const SystemEnvData* pEnv   = mpParent->GetSystemData();
-::Window aObjectParent  = (::Window)pEnv->aWindow;
+::Window aObjectParent = maParentWin;
 
XSetWindowBackgroundPixmap(static_cast(maSystemChildData.pDisplay), 
aObjectParent, None);
 if ( maSecondary )
 XDestroyWindow( static_cast(maSystemChildData.pDisplay), 
maSecondary );
@@ -400,12 +400,11 @@ bool X11SalObject::Dispatch( XEvent* pEvent )
)
 {
 SalMouseEvent aEvt;
-const SystemEnvData* pParentData = 
pObject->mpParent->GetSystemData();
 int dest_x, dest_y;
 ::Window aChild = None;
 XTranslateCoordinates( pEvent->xbutton.display,
pEvent->xbutton.root,
-   pParentData->aWindow,
+   pObject->maParentWin,
pEvent->xbutton.x_root,
pEvent->xbutton.y_root,
_x, _y,
@@ -466,9 +465,8 @@ bool X11SalObject::Dispatch( XEvent* pEvent )
 void X11SalObject::SetLeaveEnterBackgrounds(const 
css::uno::Sequence& rLeaveArgs, const 
css::uno::Sequence& rEnterArgs)
 {
 SalDisplay* pSalDisp= 
vcl_sal::getSalDisplay(GetGenericUnixSalData());
-const SystemEnvData* pEnv   = mpParent->GetSystemData();
 Display* pDisp  = pSalDisp->GetDisplay();
-::Window aObjectParent  = (::Window)pEnv->aWindow;
+::Window aObjectParent  = maParentWin;
 
 bool bFreePixmap = false;
 Pixmap aPixmap = None;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sfx2/source

[Caolán McNamara]

 sfx2/source/appl/newhelp.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 379a83359f93fa34799e116c38532f43d0534265
Author: Caolán McNamara 
Date:   Tue May 29 16:35:27 2018 +0100

Resolves: tdf#117712 closing help crashes

since...

commit 9fa32e5dce345dea17129587c401c03520fb398b
Date:   Wed May 16 11:54:52 2018 +0200

fix leak of HelpListener_Impl in SfxHelpWindow_Impl

Change-Id: I7e2cbb5d0c69e96fc7f2e1cc0c5563203c1f3dce
Reviewed-on: https://gerrit.libreoffice.org/55025
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sfx2/source/appl/newhelp.hxx b/sfx2/source/appl/newhelp.hxx
index ab95c195ec77..133502e6fef8 100644
--- a/sfx2/source/appl/newhelp.hxx
+++ b/sfx2/source/appl/newhelp.hxx
@@ -503,7 +503,7 @@ friend class SfxHelpIndexWindow_Impl;
 VclPtrpIndexWin;
 VclPtr pTextWin;
 HelpInterceptor_Impl*   pHelpInterceptor;
-std::unique_ptr pHelpListener;
+rtl::Reference pHelpListener;
 
 sal_Int32   nExpandWidth;
 sal_Int32   nCollapseWidth;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 86349] [META] Context menu bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86349
Bug 86349 depends on bug 117172, which changed state.

Bug 117172 Summary: Image context menu Save fails to do anything
https://bugs.documentfoundation.org/show_bug.cgi?id=117172

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108370] Impress Crash with videos

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108370

--- Comment #15 from Buovjaga  ---
Ale: the crashing stopped for me. Can you test with 6.0.4?

Arch Linux 64-bit
Version: 6.0.4.2
Build ID: 6.0.4-1
CPU threads: 8; OS: Linux 4.16; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs