[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948 Bug 105948 depends on bug 51223, which changed state. Bug 51223 Summary: EDITING: Cannot undo auto-capitalise with enter https://bugs.documentfoundation.org/show_bug.cgi?id=51223 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70044] Other: CTRL + mouse hold does not copy object in Writer, but it does in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=70044 grofaty changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #8 from grofaty --- In tested version it works exactly the same in Writer and in Draw. In my humble opinion it is fixed. === Help | About === Version: 6.0.5.2 (x64) Build ID: 54c8cbb85f300ac59db32fe8a675ff7683cd5a16 CPU threads: 3; OS: Windows 6.1; UI render: default; Locale: sl-SI (sl_SI); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108018] [META] Writer UX bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108018 Bug 108018 depends on bug 70044, which changed state. Bug 70044 Summary: Other: CTRL + mouse hold does not copy object in Writer, but it does in Draw https://bugs.documentfoundation.org/show_bug.cgi?id=70044 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108844] [META] Cut/copy bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108844 Bug 108844 depends on bug 70044, which changed state. Bug 70044 Summary: Other: CTRL + mouse hold does not copy object in Writer, but it does in Draw https://bugs.documentfoundation.org/show_bug.cgi?id=70044 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117713] UnoControlDialog is displayed in the wrong size
https://bugs.documentfoundation.org/show_bug.cgi?id=117713 joesc...@web.de changed: What|Removed |Added CC||joesc...@web.de --- Comment #2 from joesc...@web.de --- Created attachment 143391 --> https://bugs.documentfoundation.org/attachment.cgi?id=143391=edit File to reproduce the error Error descriptions are not made for end-users, but for experts! I won't describe the process again, because who wants to be able to fix the bug is also able to understand my description. I have attached a sample file that can be used to reproduce the error. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102619] FILESAVE: Numbering style not saved correctly on DOCX export
https://bugs.documentfoundation.org/show_bug.cgi?id=102619 --- Comment #9 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=39a4f21fc4a16f7c57a9b6f1ddd5ce2953781576 tdf#102619 writerfilter: first create style, then set FollowStyle It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102619] FILESAVE: Numbering style not saved correctly on DOCX export
https://bugs.documentfoundation.org/show_bug.cgi?id=102619 Commit Notification changed: What|Removed |Added Whiteboard||target:6.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/ooxmlexport.cxx|4 +++ writerfilter/source/dmapper/StyleSheetTable.cxx | 27 +++- 2 files changed, 26 insertions(+), 5 deletions(-) New commits: commit 39a4f21fc4a16f7c57a9b6f1ddd5ce2953781576 Author: Justin Luth Date: Fri Jul 6 15:19:26 2018 +0300 tdf#102619 writerfilter: first create style, then set FollowStyle Styles were having FollowStyle set to themselves (Heading 1), not to a defined follow (Text body). The style was being created with a FollowStyle property that identified a style which had not yet been created. So svl code was warning "svl.items", "StyleSheet-Follow not found" This section of code should really be cleaned up, but that will happen in a separate commit. Change-Id: Iae79fac917f64cdaa14ca6568e7d903ec6dc60fa Reviewed-on: https://gerrit.libreoffice.org/57074 Tested-by: Jenkins Reviewed-by: Justin Luth diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx index ca24b6420e5e..732a938c8094 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx @@ -818,6 +818,10 @@ DECLARE_OOXMLEXPORT_TEST(testTdf89791, "tdf89791.docx") uno::Reference xNameAccess = packages::zip::ZipFileAccess::createWithURL(comphelper::getComponentContext(m_xSFactory), maTempFile.GetURL()); CPPUNIT_ASSERT_EQUAL(false, bool(xNameAccess->hasByName("docProps/custom.xml"))); } + +//tdf#102619 - setting FollowStyle with a not-yet-created style was failing. (Titre is created before Corps de texte). +uno::Reference< beans::XPropertySet > properties(getStyles("ParagraphStyles")->getByName("Titre"), uno::UNO_QUERY); +CPPUNIT_ASSERT_EQUAL(OUString("Corps de texte"), getProperty(properties, "FollowStyle")); } DECLARE_OOXMLEXPORT_TEST(testTdf91261, "tdf91261.docx") diff --git a/writerfilter/source/dmapper/StyleSheetTable.cxx b/writerfilter/source/dmapper/StyleSheetTable.cxx index 383ac0d5a0f9..14c2348fb0d5 100644 --- a/writerfilter/source/dmapper/StyleSheetTable.cxx +++ b/writerfilter/source/dmapper/StyleSheetTable.cxx @@ -903,6 +903,7 @@ void StyleSheetTable::ApplyStyleSheets( const FontTablePtr& rFontTable ) if(xCharStyles.is() && xParaStyles.is()) { std::vector< ::std::pair> > aMissingParent; +std::vector< ::std::pair> > aMissingFollow; std::vector aTableStylesVec; std::vector< StyleSheetEntryPtr >::iterator aIt = m_pImpl->m_aStyleSheetEntries.begin(); while( aIt != m_pImpl->m_aStyleSheetEntries.end() ) @@ -1133,10 +1134,16 @@ void StyleSheetTable::ApplyStyleSheets( const FontTablePtr& rFontTable ) { if (!(*it)->sStyleName.isEmpty() && (*it)->sStyleIdentifierD == pEntry->sNextStyleIdentifier) { -beans::PropertyValue aNew; -aNew.Name = "FollowStyle"; -aNew.Value <<= ConvertStyleName((*it)->sStyleName); -aSortedPropVals.Insert(aNew); +const OUString sFollowStyle = ConvertStyleName((*it)->sStyleName); +if ( !xStyles->hasByName( sFollowStyle ) ) +aMissingFollow.emplace_back( sFollowStyle, xStyle ); +else +{ +beans::PropertyValue aNew; +aNew.Name = "FollowStyle"; +aNew.Value <<= sFollowStyle; +aSortedPropVals.Insert(aNew); +} break; } } @@ -1210,12 +1217,22 @@ void StyleSheetTable::ApplyStyleSheets( const FontTablePtr& rFontTable ) ++aIt; } -// Update the styles that were created before their parents +// Update the styles that were created before their parents or next-styles for( auto const & iter : aMissingParent ) { iter.second->setParentStyle( iter.first ); } +for( auto const & iter : aMissingFollow ) +{ +try +{ +uno::Reference xPropertySet(iter.second, uno::UNO_QUERY); +xPropertySet->setPropertyValue( "FollowStyle", uno::makeAny(iter.first) ); +} +catch( uno::Exception & ) {} +} + if (!aTableStylesVec.empty()) { // If we had any table styles, add a new document-level
[Libreoffice-bugs] [Bug 70183] characters £ ì è é ò ç à ° § ù © not accepted in PDF passwords
https://bugs.documentfoundation.org/show_bug.cgi?id=70183 --- Comment #14 from Mike Kaganski --- Still repro with Version: 6.1.0.1 (x64) Build ID: 378e26bd4f22a135cef5fa17afd5d4171d8da21a CPU threads: 4; OS: Windows 10.0; UI render: default; Locale: ru-RU (ru_RU); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70183] characters £ ì è é ò ç à ° § ù © not accepted in PDF passwords
https://bugs.documentfoundation.org/show_bug.cgi?id=70183 Mike Kaganski changed: What|Removed |Added Keywords||difficultyBeginner, ||easyHack, topicUI -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107547] EDITING: Table selection made with clicking and dragging flickers when it's only partially visible
https://bugs.documentfoundation.org/show_bug.cgi?id=107547 --- Comment #7 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109018] Character border conflict with hyphens
https://bugs.documentfoundation.org/show_bug.cgi?id=109018 --- Comment #3 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70183] characters £ ì è é ò ç à ° § ù © not accepted in PDF passwords
https://bugs.documentfoundation.org/show_bug.cgi?id=70183 --- Comment #13 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104204] irritating disfunctions in the table selecting
https://bugs.documentfoundation.org/show_bug.cgi?id=104204 --- Comment #3 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115707] Crash in: cppu::_copyConstructAny(_uno_Any *, void *, _typelib_TypeDescriptionReference *, _typelib_TypeDescription *, void (*)(void *), _uno_Mapping *)
https://bugs.documentfoundation.org/show_bug.cgi?id=115707 Aron Budea changed: What|Removed |Added Version|6.0.0.3 release |5.1.3.2 release --- Comment #10 from Aron Budea --- Had a 64-bit 5.1.3.2 installer lying around, and it already crashes when running the macro. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115707] Crash in: cppu::_copyConstructAny(_uno_Any *, void *, _typelib_TypeDescriptionReference *, _typelib_TypeDescription *, void (*)(void *), _uno_Mapping *)
https://bugs.documentfoundation.org/show_bug.cgi?id=115707 Aron Budea changed: What|Removed |Added Keywords|bibisected, bisected, | |regression | --- Comment #9 from Aron Budea --- The problem is that the last parameter of 'VbaApplicationBase::Run(...)' [1] (which is 'const uno::Any& varg30') is an invalid reference. This only occurs with 64-bit Windows builds. The crash mentioned in comment 6 is the same, and occurs with versions < 6.0: http://crashreport.libreoffice.org/stats/crash_details/14534211-f195-4792-adc9-210f44bef13b It's very likel Tamas' commit resulted in this macro running at start, otherwise there's no indicatino it'd be connected to the crash, especially since the commit isn't present in 5.4, but the crash is. Removing regression-related keywords. [1] https://opengrok.libreoffice.org/xref/core/vbahelper/source/vbahelper/vbaapplicationbase.cxx#331 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/uitest/uiobject.cxx | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) New commits: commit a7699fc27240f1329602a5d442667c326525ad55 Author: Markus Mohrhard Date: Mon Jul 9 00:48:16 2018 +0200 uitest: test for ui elements children first Change-Id: I837721533bc40cea55cbccaa14e1f14686aa3e3a Reviewed-on: https://gerrit.libreoffice.org/57165 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/vcl/source/uitest/uiobject.cxx b/vcl/source/uitest/uiobject.cxx index 1a292862ec52..0540b9ba0ec4 100644 --- a/vcl/source/uitest/uiobject.cxx +++ b/vcl/source/uitest/uiobject.cxx @@ -421,8 +421,15 @@ void addChildren(vcl::Window const * pParent, std::set& rChildren) std::unique_ptr WindowUIObject::get_child(const OUString& rID) { -vcl::Window* pDialogParent = get_top_parent(mxWindow.get()); -vcl::Window* pWindow = findChild(pDialogParent, rID); +// in a first step try the real children before moving to the top level parent +// This makes it easier to handle cases with the same ID as there is a way +// to resolve conflicts +vcl::Window* pWindow = findChild(mxWindow.get(), rID); +if (!pWindow) +{ +vcl::Window* pDialogParent = get_top_parent(mxWindow.get()); +pWindow = findChild(pDialogParent, rID); +} if (!pWindow) throw css::uno::RuntimeException("Could not find child with id: " + rID); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 118626] New: centos repo repomd.xml missing
https://bugs.documentfoundation.org/show_bug.cgi?id=118626 Bug ID: 118626 Summary: centos repo repomd.xml missing Product: LibreOffice Online Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: i...@markusneuberger.at When installing CODE 3.3.1 on centos 7.5 like explained (https://www.collaboraoffice.com/code/#packages_for_linux_x86_64_platform) it's not working because repomd.xml is missing: yum install loolwsd CODE-brand leads to: https://www.collaboraoffice.com/repos/CollaboraOnline/CODE-centos7/repodata/repomd.xml: [Errno 14] HTTPS Error 404 - Not Found -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98521] Font in tablecontrol isn't shown in right format
https://bugs.documentfoundation.org/show_bug.cgi?id=98521 --- Comment #13 from jorojma...@gmail.com --- I'm doing a program in libreoffice base and this error is conditioning me, it looks so small the letter that it is impossible for me not to wear glasses Who would be able to fix this problem? I consider this problem important. Thank you -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98521] Font in tablecontrol isn't shown in right format
https://bugs.documentfoundation.org/show_bug.cgi?id=98521 jorojma...@gmail.com changed: What|Removed |Added Version|5.0.0.5 release |6.1.0.1 rc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: bin/gbuild-to-ide
bin/gbuild-to-ide |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9d7166b448198875bdff43d7054d0f5914e675de Author: Markus Mohrhard Date: Mon Jul 9 00:54:02 2018 +0200 fix compile_commands.json when generated with modern gcc Change-Id: I4a17cfb567f5ebec8bb416b9aa4d58763ff36c36 diff --git a/bin/gbuild-to-ide b/bin/gbuild-to-ide index 90a732d7c614..b016bfe02a0c 100755 --- a/bin/gbuild-to-ide +++ b/bin/gbuild-to-ide @@ -379,7 +379,7 @@ class VimIntegrationGenerator(IdeIntegrationGenerator): command += ' -c ' command += file # Help clang when the tree is configured for gcc. -for gnu in ('-std=gnu++11', '-std=gnu++1y'): +for gnu in ('-std=gnu++11', '-std=gnu++1y', '-std=gnu++17'): command = command.replace(gnu, '-std=c++11') return command ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115890] Assert when using tab to move between controls in the Navigator in the Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=115890 Commit Notification changed: What|Removed |Added Whiteboard|target:6.2.0 target:6.1.0.2 |target:6.2.0 target:6.1.0.2 ||target:6.0.6 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115890] Assert when using tab to move between controls in the Navigator in the Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=115890 --- Comment #12 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-6-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a900c91447897e725fc0cf674205eee633b326eb=libreoffice-6-0 tdf#115890 sw: fix invalid cast in SwContentTree::GetEntryAltText() It will be available in 6.0.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sw/source
sw/source/uibase/utlui/content.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a900c91447897e725fc0cf674205eee633b326eb Author: Michael Stahl Date: Fri Jul 6 18:39:20 2018 +0200 tdf#115890 sw: fix invalid cast in SwContentTree::GetEntryAltText() AccessibleListBoxEntry calls this for any entry. This was always broken but now we have asserts to tell us about it. Change-Id: I7094a1dfbffd359e0f536ca60cba2478e2a62464 Reviewed-on: https://gerrit.libreoffice.org/57086 Reviewed-by: Michael Stahl Tested-by: Jenkins (cherry picked from commit 2986f4baa8bdef1f9ab9108240ea890075321be1) Reviewed-on: https://gerrit.libreoffice.org/57152 Reviewed-by: Thorsten Behrens diff --git a/sw/source/uibase/utlui/content.cxx b/sw/source/uibase/utlui/content.cxx index 9b59a912c722..9012fd86fbcf 100644 --- a/sw/source/uibase/utlui/content.cxx +++ b/sw/source/uibase/utlui/content.cxx @@ -902,7 +902,7 @@ Size SwContentTree::GetOptimalSize() const OUString SwContentTree::GetEntryAltText( SvTreeListEntry* pEntry ) const { -if( pEntry == nullptr) +if (pEntry == nullptr || !lcl_IsContent(pEntry)) return OUString(); assert(pEntry->GetUserData() == nullptr || dynamic_cast(static_cast(pEntry->GetUserData(; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source sc/uiconfig
sc/source/ui/dbgui/validate.cxx |2 +- sc/uiconfig/scalc/ui/erroralerttabpage.ui |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit c3c2ca43686b8cf63e60f783b81cb353d91973fa Author: Markus Mohrhard Date: Sun Jul 8 23:06:34 2018 +0200 rename UI element to prevent duplicate IDs in same dialog Small improvement for the UI testing. Change-Id: I49fa6a7566a492930532719271b6c83005bc85a8 Reviewed-on: https://gerrit.libreoffice.org/57163 Reviewed-by: Markus Mohrhard Tested-by: Markus Mohrhard diff --git a/sc/source/ui/dbgui/validate.cxx b/sc/source/ui/dbgui/validate.cxx index fe6bd005f669..688ebe5b7043 100644 --- a/sc/source/ui/dbgui/validate.cxx +++ b/sc/source/ui/dbgui/validate.cxx @@ -767,7 +767,7 @@ ScTPValidationError::ScTPValidationError( vcl::Window* pParent, get(m_pTsbShow,"tsbshow"); get(m_pLbAction,"actionCB"); get(m_pBtnSearch,"browseBtn"); -get(m_pEdtTitle,"title"); +get(m_pEdtTitle,"erroralert_title"); get(m_pFtError,"errormsg_label"); get(m_pEdError,"errorMsg"); m_pEdError->set_height_request(m_pEdError->GetTextHeight() * 12); diff --git a/sc/uiconfig/scalc/ui/erroralerttabpage.ui b/sc/uiconfig/scalc/ui/erroralerttabpage.ui index 0abfaa75340a..ef8f9bc8191d 100644 --- a/sc/uiconfig/scalc/ui/erroralerttabpage.ui +++ b/sc/uiconfig/scalc/ui/erroralerttabpage.ui @@ -75,7 +75,7 @@ 0 _Title: True -title +erroralert_title 0 @@ -106,7 +106,7 @@ - + True True ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 118624] RAND() in an array returns the same value for each cell
https://bugs.documentfoundation.org/show_bug.cgi?id=118624 --- Comment #1 from MM --- Unconfirmed on windows 7 x64 with Version: 6.0.5.2 (x64) Build ID: 54c8cbb85f300ac59db32fe8a675ff7683cd5a16 CPU threads: 3; OS: Windows 6.1; UI render: default -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa sc/source sc/uiconfig sc/UIConfig_scalc.mk
sc/UIConfig_scalc.mk |1 sc/qa/unit/datatransformation_test.cxx |8 - sc/source/ui/dataprovider/datatransformation.cxx | 124 --- sc/source/ui/inc/dataproviderdlg.hxx |1 sc/source/ui/inc/datatransformation.hxx |4 sc/source/ui/miscdlgs/dataproviderdlg.cxx| 79 ++ sc/uiconfig/scalc/ui/texttransformationentry.ui | 109 7 files changed, 261 insertions(+), 65 deletions(-) New commits: commit 9546f6fec9c16c0440ef6db940aa704d2f8c6657 Author: Manuj Vashist Date: Mon Jul 2 17:14:11 2018 +0530 added Text transformation in data provider dlg Change-Id: I69d8aae9289ad6d1cbdf92307c16299a533fcd56 Reviewed-on: https://gerrit.libreoffice.org/56807 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/sc/UIConfig_scalc.mk b/sc/UIConfig_scalc.mk index 6eb7c34d49f9..498540b645fb 100644 --- a/sc/UIConfig_scalc.mk +++ b/sc/UIConfig_scalc.mk @@ -156,6 +156,7 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/scalc,\ sc/uiconfig/scalc/ui/managenamesdialog \ sc/uiconfig/scalc/ui/mergecellsdialog \ sc/uiconfig/scalc/ui/mergecolumnentry \ + sc/uiconfig/scalc/ui/texttransformationentry \ sc/uiconfig/scalc/ui/movecopysheet \ sc/uiconfig/scalc/ui/movingaveragedialog \ sc/uiconfig/scalc/ui/multipleoperationsdialog \ diff --git a/sc/qa/unit/datatransformation_test.cxx b/sc/qa/unit/datatransformation_test.cxx index 3546104fdbee..baea46c694ad 100644 --- a/sc/qa/unit/datatransformation_test.cxx +++ b/sc/qa/unit/datatransformation_test.cxx @@ -170,7 +170,7 @@ void ScDataTransformationTest::testTextToLower() m_pDoc->SetString(2, 2, 0, "Paris"); m_pDoc->SetString(2, 3, 0, "Peking"); -sc::TextTransformation aTransform(2, sc::TEXT_TRANSFORM_TYPE::TO_LOWER); +sc::TextTransformation aTransform({2}, sc::TEXT_TRANSFORM_TYPE::TO_LOWER); aTransform.Transform(*m_pDoc); CPPUNIT_ASSERT_EQUAL(OUString("berlin"), m_pDoc->GetString(2, 0, 0)); @@ -186,7 +186,7 @@ void ScDataTransformationTest::testTextToUpper() m_pDoc->SetString(2, 2, 0, "Paris"); m_pDoc->SetString(2, 3, 0, "Peking"); -sc::TextTransformation aTransform(2, sc::TEXT_TRANSFORM_TYPE::TO_UPPER); +sc::TextTransformation aTransform({2}, sc::TEXT_TRANSFORM_TYPE::TO_UPPER); aTransform.Transform(*m_pDoc); CPPUNIT_ASSERT_EQUAL(OUString("BERLIN"), m_pDoc->GetString(2, 0, 0)); @@ -202,7 +202,7 @@ void ScDataTransformationTest::testTextCapitalize() m_pDoc->SetString(2, 2, 0, "si tu la ves"); m_pDoc->SetString(2, 3, 0, "cUaNdO mE EnAmOro"); -sc::TextTransformation aTransform(2, sc::TEXT_TRANSFORM_TYPE::CAPITALIZE); +sc::TextTransformation aTransform({2}, sc::TEXT_TRANSFORM_TYPE::CAPITALIZE); aTransform.Transform(*m_pDoc); CPPUNIT_ASSERT_EQUAL(OUString("Hello World"), m_pDoc->GetString(2, 0, 0)); @@ -217,7 +217,7 @@ void ScDataTransformationTest::testTextTrim() m_pDoc->SetString(2, 1, 0, "Brussels "); m_pDoc->SetString(2, 2, 0, " Paris "); -sc::TextTransformation aTransform(2, sc::TEXT_TRANSFORM_TYPE::TRIM); +sc::TextTransformation aTransform({2}, sc::TEXT_TRANSFORM_TYPE::TRIM); aTransform.Transform(*m_pDoc); CPPUNIT_ASSERT_EQUAL(OUString("Berlin"), m_pDoc->GetString(2, 0, 0)); diff --git a/sc/source/ui/dataprovider/datatransformation.cxx b/sc/source/ui/dataprovider/datatransformation.cxx index a1eae17c0df9..75e84a23c2ef 100644 --- a/sc/source/ui/dataprovider/datatransformation.cxx +++ b/sc/source/ui/dataprovider/datatransformation.cxx @@ -176,7 +176,7 @@ const ScSortParam & SortTransformation::getSortParam() const return maSortParam; } -TextTransformation::TextTransformation(SCCOL nCol, const TEXT_TRANSFORM_TYPE rType): +TextTransformation::TextTransformation(const std::set& nCol, const TEXT_TRANSFORM_TYPE rType): mnCol(nCol), maType(rType) { @@ -184,85 +184,91 @@ TextTransformation::TextTransformation(SCCOL nCol, const TEXT_TRANSFORM_TYPE rTy void TextTransformation::Transform(ScDocument& rDoc) const { -SCROW nEndRow = getLastRow(rDoc, mnCol); - -switch (maType) +SCROW nEndRow = 0; +for(auto& rCol : mnCol) { -case TEXT_TRANSFORM_TYPE::TO_LOWER: +nEndRow = getLastRow(rDoc, rCol); +} +for(auto& rCol : mnCol) +{ +switch (maType) { -for (SCROW nRow = 0; nRow <= nEndRow; ++nRow) +case TEXT_TRANSFORM_TYPE::TO_LOWER: { -CellType eType; -rDoc.GetCellType(mnCol, nRow, 0, eType); -if (eType == CELLTYPE_STRING) +for (SCROW nRow = 0; nRow <= nEndRow; ++nRow) { -OUString aStr = rDoc.GetString(mnCol, nRow, 0); -rDoc.SetString(mnCol, nRow, 0, ScGlobal::pCharClass->lowercase(aStr)); +CellType
[Libreoffice-bugs] [Bug 84670] Conditional formatting changes row height
https://bugs.documentfoundation.org/show_bug.cgi?id=84670 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added Blocks|107833 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107833 [Bug 107833] [META] Writer paragraph style bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107833] [META] Writer paragraph style bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107833 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added Depends on|84670 | --- Comment #1 from kompilainenn <79045_79...@mail.ru> --- 84670 is a Calc bug -> deleted from this META Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=84670 [Bug 84670] Conditional formatting changes row height -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/inc sc/Library_sc.mk sc/qa sc/source
sc/Library_sc.mk |1 sc/inc/datamapper.hxx |6 + sc/qa/unit/data/dataprovider/xml/test1.xml| 19 +++ sc/qa/unit/dataproviders_test.cxx | 44 sc/source/ui/dataprovider/dataprovider.cxx| 16 +++ sc/source/ui/dataprovider/xmldataprovider.cxx | 128 ++ sc/source/ui/dataprovider/xmldataprovider.hxx | 41 7 files changed, 255 insertions(+) New commits: commit e300efd3a029672e24114914355c5c690fb725d5 Author: Vikas Mahato Date: Sun Jun 24 20:53:01 2018 +0530 Added XML data provider Change-Id: Ib5727912977eb79cdf1f84bf874919beafc693eb Reviewed-on: https://gerrit.libreoffice.org/56356 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/sc/Library_sc.mk b/sc/Library_sc.mk index 2f4f06b6ea25..5425d681caab 100644 --- a/sc/Library_sc.mk +++ b/sc/Library_sc.mk @@ -399,6 +399,7 @@ $(eval $(call gb_Library_add_exception_objects,sc,\ sc/source/ui/dataprovider/dataprovider \ sc/source/ui/dataprovider/datatransformation \ sc/source/ui/dataprovider/htmldataprovider \ +sc/source/ui/dataprovider/xmldataprovider \ sc/source/ui/dbgui/asciiopt \ sc/source/ui/dbgui/consdlg \ sc/source/ui/dbgui/csvcontrol \ diff --git a/sc/inc/datamapper.hxx b/sc/inc/datamapper.hxx index 1d7e710051c0..9c59a7461b82 100644 --- a/sc/inc/datamapper.hxx +++ b/sc/inc/datamapper.hxx @@ -16,6 +16,8 @@ #include +#include "orcusxml.hxx" + class ScDocument; class ScDBData; @@ -62,6 +64,8 @@ private: */ OUString maID; +ScOrcusImportXMLParam maParam; + double mnUpdateFrequency; std::shared_ptr mpDataProvider; @@ -83,10 +87,12 @@ public: void setID(const OUString& rID); void setURL(const OUString& rURL); void setProvider(const OUString& rProvider); +void setXMLImportParam(const ScOrcusImportXMLParam& rParam); const OUString& getURL() const; const OUString& getProvider() const; const OUString& getID() const; +const ScOrcusImportXMLParam& getXMLImportParam() const; double getUpdateFrequency() const; OUString getDBName() const; void setDBData(const OUString& rDBName); diff --git a/sc/qa/unit/data/dataprovider/xml/test1.xml b/sc/qa/unit/data/dataprovider/xml/test1.xml new file mode 100644 index ..03ba28288825 --- /dev/null +++ b/sc/qa/unit/data/dataprovider/xml/test1.xml @@ -0,0 +1,19 @@ + + + +1 +test1 + + +2 +test2 + + +3 +test3 + + +4 +test4 + + \ No newline at end of file diff --git a/sc/qa/unit/dataproviders_test.cxx b/sc/qa/unit/dataproviders_test.cxx index 1960fa59eecf..aef3ec6abb05 100644 --- a/sc/qa/unit/dataproviders_test.cxx +++ b/sc/qa/unit/dataproviders_test.cxx @@ -14,6 +14,7 @@ #include #include #include +#include #include @@ -29,11 +30,13 @@ public: void testCSVImport(); void testDataLargerThanDB(); void testHTMLImport(); +void testXMLImport(); CPPUNIT_TEST_SUITE(ScDataProvidersTest); CPPUNIT_TEST(testCSVImport); CPPUNIT_TEST(testDataLargerThanDB); CPPUNIT_TEST(testHTMLImport); +CPPUNIT_TEST(testXMLImport); CPPUNIT_TEST_SUITE_END(); private: @@ -137,6 +140,47 @@ void ScDataProvidersTest::testHTMLImport() } } +void ScDataProvidersTest::testXMLImport() +{ +ScDBData* pDBData = new ScDBData("testDB", 0, 0, 0, 10, 10); +bool bInserted = m_pDoc->GetDBCollection()->getNamedDBs().insert(pDBData); +CPPUNIT_ASSERT(bInserted); + +OUString aFileURL; +ScOrcusImportXMLParam aParam; + +ScOrcusImportXMLParam::RangeLink aRangeLink; +aRangeLink.maPos = ScAddress(0,0,0); +aRangeLink.maFieldPaths.push_back("/bookstore/book/title"); +aRangeLink.maFieldPaths.push_back("/bookstore/book/author"); +aParam.maRangeLinks.push_back(aRangeLink); + +createFileURL("test1.", "xml", aFileURL); +sc::ExternalDataSource aDataSource(aFileURL, "org.libreoffice.calc.xml", m_pDoc); +aDataSource.setDBData("testDB"); +aDataSource.setXMLImportParam(aParam); + + +m_pDoc->GetExternalDataMapper().insertDataSource(aDataSource); +auto& rDataSources = m_pDoc->GetExternalDataMapper().getDataSources(); +CPPUNIT_ASSERT(!rDataSources.empty()); + +rDataSources[0].refresh(m_pDoc, true); +Scheduler::ProcessEventsToIdle(); + +CPPUNIT_ASSERT_EQUAL(OUString("title"), m_pDoc->GetString(0, 0, 0)); +CPPUNIT_ASSERT_EQUAL(OUString("author"), m_pDoc->GetString(1, 0, 0)); +CPPUNIT_ASSERT_EQUAL(1.0, m_pDoc->GetValue(0, 1, 0)); +CPPUNIT_ASSERT_EQUAL(OUString("test1"), m_pDoc->GetString(1, 1, 0)); +CPPUNIT_ASSERT_EQUAL(2.0, m_pDoc->GetValue(0, 2, 0)); +CPPUNIT_ASSERT_EQUAL(OUString("test2"), m_pDoc->GetString(1, 2, 0)); +CPPUNIT_ASSERT_EQUAL(3.0, m_pDoc->GetValue(0, 3, 0)); +CPPUNIT_ASSERT_EQUAL(OUString("test3"), m_pDoc->GetString(1, 3, 0)); +CPPUNIT_ASSERT_EQUAL(4.0,
[Libreoffice-bugs] [Bug 118617] LibreOffice_6.0.5_Win_x86_helppack_en-GB.msi.torrent creates LibreOffice_6.0.5_Win_x86.msi
https://bugs.documentfoundation.org/show_bug.cgi?id=118617 --- Comment #2 from Paul Wolstenholme --- Sorry - it seems I must have had finger trouble. I wish to withdraw this report. It seems I mis-handled the 'Save as' dialogue in one of the 2 instances of Bittorrent(bittornado) that I had open. Having incorrectly directed 2 .torrent downloads to the same .msi file, the .torrent file repeatedly wanted to re-link to the wrong .msi file name no matter how often Bittorrent(bittornado) is reloaded or the target files are deleted or moved. A fresh download of the .torrent file that had the wrong 'save as' destination filename was required to get the correct default destination filename. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91814] Problem when copying large table with floating-point values from Calc to Base (HSQLDB)
https://bugs.documentfoundation.org/show_bug.cgi?id=91814 --- Comment #10 from christian_k...@gmx.net --- Hello, the bug is still present in Base using HSQLDB: Version: 6.0.5.2 Build-ID: 54c8cbb85f300ac59db32fe8a675ff7683cd5a16 CPU-Threads: 4; BS: Windows 6.3; UI-Render: Standard; Gebietsschema: de-DE (de_DE); Calc: Group. Best regards, Christian -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sc/source
sc/source/core/tool/interpr1.cxx | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) New commits: commit 8f3515b5e54dabb08ddb01253d9503e9c16cfebe Author: Eike Rathke Date: Sat Jul 7 23:00:50 2018 +0200 Resolves: tdf#118561 handle external references as jump matrix result Change-Id: I0381179347960293f5d470ed231d626cb6707b5a Reviewed-on: https://gerrit.libreoffice.org/57144 Reviewed-by: Eike Rathke Tested-by: Jenkins (cherry picked from commit a5b9bb7be70c7aec2388199e68a0cf86dd220955) Reviewed-on: https://gerrit.libreoffice.org/57148 Reviewed-by: Markus Mohrhard diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx index 49c7d009f05a..cb0ac61a3cc6 100644 --- a/sc/source/core/tool/interpr1.cxx +++ b/sc/source/core/tool/interpr1.cxx @@ -714,10 +714,44 @@ bool ScInterpreter::JumpMatrix( short nStackLevel ) } } break; +case svExternalSingleRef: +{ +ScExternalRefCache::TokenRef pToken; +PopExternalSingleRef(pToken); +if (nGlobalError != FormulaError::NONE) +{ +pJumpMatrix->PutResultDouble( CreateDoubleError( nGlobalError), nC, nR ); +nGlobalError = FormulaError::NONE; +} +else +{ +switch (pToken->GetType()) +{ +case svDouble: +pJumpMatrix->PutResultDouble( pToken->GetDouble(), nC, nR ); +break; +case svString: +pJumpMatrix->PutResultString( pToken->GetString(), nC, nR ); +break; +case svEmptyCell: +pJumpMatrix->PutResultEmpty( nC, nR ); +break; +default: +// svError was already handled (set by +// PopExternalSingleRef()) with nGlobalError +// above. +assert(!"unhandled svExternalSingleRef case"); +pJumpMatrix->PutResultDouble( CreateDoubleError( + FormulaError::UnknownStackVariable), nC, nR ); +} +} +} +break; +case svExternalDoubleRef: case svMatrix: { // match matrix offsets double fVal; -ScMatrixRef pMat = PopMatrix(); +ScMatrixRef pMat = GetMatrix(); if ( nGlobalError != FormulaError::NONE ) { fVal = CreateDoubleError( nGlobalError ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 95880] Add lock mark on protected sheet tab before tab label
https://bugs.documentfoundation.org/show_bug.cgi?id=95880 --- Comment #19 from Commit Notification --- Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-6-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=dc9c326c378f252df83aa90a61df51a60d574c8c=libreoffice-6-0 tdf#118547: Remove lock mark only if password is correct, tdf#95880 follow-up It will be available in 6.0.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 95880] Add lock mark on protected sheet tab before tab label
https://bugs.documentfoundation.org/show_bug.cgi?id=95880 Commit Notification changed: What|Removed |Added Whiteboard|target:6.0.0 target:6.2.0 |target:6.0.0 target:6.2.0 |target:6.1.0.2 |target:6.1.0.2 target:6.0.6 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sc/source
sc/source/ui/undo/undotab.cxx |2 ++ sc/source/ui/view/viewfunc.cxx | 13 + 2 files changed, 11 insertions(+), 4 deletions(-) New commits: commit dc9c326c378f252df83aa90a61df51a60d574c8c Author: Eike Rathke Date: Fri Jul 6 20:09:55 2018 +0200 tdf#118547: Remove lock mark only if password is correct, tdf#95880 follow-up This is a combination of 3 commits. tdf#118547: Remove lock mark only if password is correct Reviewed-on: https://gerrit.libreoffice.org/57044 Tested-by: Jenkins Reviewed-by: Eike Rathke (cherry picked from commit c3a732a11c320b98e31dad79f421d4d73f33a15b) Related: tdf#118547 handle multi-sheet un-/protect, tdf#95880 follow-up Also don't attempt to remove a lock for TABLEID_DOC that is not a sheet. Reviewed-on: https://gerrit.libreoffice.org/57060 Reviewed-by: Eike Rathke Tested-by: Jenkins (cherry picked from commit 7eba8e98508d547f43fecbe3175a11a05956b30a) Handle protection lock mark in Undo/Redo, tdf#68290 follow-up Reviewed-on: https://gerrit.libreoffice.org/57063 Reviewed-by: Eike Rathke Tested-by: Jenkins (cherry picked from commit 6fb449d127d1da165f610c4c99c2c7d9c5afbb97) Change-Id: I9f5731dfaaf9b4cc67e600a8b1c01709e7c9ba99 28775a068215a59063ed95fd141e125cf2155aa7 c88cb375f9f6030c9268fca84de7a5434bb82dc1 Reviewed-on: https://gerrit.libreoffice.org/57091 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/sc/source/ui/undo/undotab.cxx b/sc/source/ui/undo/undotab.cxx index db0c34d0568c..f8bd5dc6940b 100644 --- a/sc/source/ui/undo/undotab.cxx +++ b/sc/source/ui/undo/undotab.cxx @@ -1254,6 +1254,8 @@ void ScUndoTabProtect::DoProtect(bool bProtect) ScTabViewShell* pViewShell = ScTabViewShell::GetActiveViewShell(); if (pViewShell) { +if (ScTabView* pTabView = pViewShell->GetViewData().GetView()) +pTabView->SetTabProtectionSymbol( mnTab, bProtect); pViewShell->UpdateLayerLocks(); pViewShell->UpdateInputHandler(true); // so that input can be immediately entered again } diff --git a/sc/source/ui/view/viewfunc.cxx b/sc/source/ui/view/viewfunc.cxx index 27e9ad05d738..3f6e583c6f60 100644 --- a/sc/source/ui/view/viewfunc.cxx +++ b/sc/source/ui/view/viewfunc.cxx @@ -2489,12 +2489,14 @@ void ScViewFunc::ProtectSheet( SCTAB nTab, const ScTableProtection& rProtect ) ScMarkData::iterator itr = rMark.begin(), itrEnd = rMark.end(); for (; itr != itrEnd; ++itr) +{ rFunc.ProtectSheet(*itr, rProtect); +SetTabProtectionSymbol(*itr, true); +} if (bUndo) pDocSh->GetUndoManager()->LeaveListAction(); -SetTabProtectionSymbol(nTab, true); UpdateLayerLocks(); //! broadcast to all views } @@ -2552,15 +2554,18 @@ bool ScViewFunc::Unprotect( SCTAB nTab, const OUString& rPassword ) ScMarkData::iterator itr = rMark.begin(), itrEnd = rMark.end(); for (; itr != itrEnd; ++itr) +{ if ( rFunc.Unprotect( *itr, rPassword, false ) ) -bChanged = true; +{ +bChanged = true; +SetTabProtectionSymbol( *itr, false); +} +} if (bUndo) pDocSh->GetUndoManager()->LeaveListAction(); } -SetTabProtectionSymbol(nTab, false); - if (bChanged) UpdateLayerLocks(); //! broadcast to all views ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/qa sc/source
sc/qa/unit/datatransformation_test.cxx | 213 sc/source/ui/dataprovider/datatransformation.cxx | 236 +++ sc/source/ui/inc/datatransformation.hxx | 19 + 3 files changed, 467 insertions(+), 1 deletion(-) New commits: commit 510073cf047101cf6297fcec2ad8296f9e63c486 Author: Vikas Date: Tue Jul 3 11:47:14 2018 +0530 Added number transformations for external data - Round allows you to round the numbers in the column up to a given number of decimal places - Round Up rounds the numbers in the column up to the nearest whole number - Round Down rounds the numbers in the column down to the nearest whole number - Absolute Value returns the absolute value of the numbers in the column - Logarithm - Natural returns the natural logarithm - Base-10 returns the base-10 logarithm - Cube returns the cube of the numbers - Square returns the square of the numbers - Square Root returns the square root of the numbers - Is Even returns TRUE if the values in the column are eve - Is Odd returns TRUE if the values in the column are odd - Sign returns 1 if the values in the column are positive, -1 if they are negative, and 0 otherwise. Change-Id: I7458d0d61da3749fe497b3999449373234391b04 Reviewed-on: https://gerrit.libreoffice.org/56886 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/sc/qa/unit/datatransformation_test.cxx b/sc/qa/unit/datatransformation_test.cxx index c011941a6cb7..3546104fdbee 100644 --- a/sc/qa/unit/datatransformation_test.cxx +++ b/sc/qa/unit/datatransformation_test.cxx @@ -39,6 +39,18 @@ public: void testAggregateAverage(); void testAggregateMin(); void testAggregateMax(); +void testNumberRound(); +void testNumberRoundUp(); +void testNumberRoundDown(); +void testNumberAbsolute(); +void testNumberLogE(); +void testNumberLog10(); +void testNumberCube(); +void testNumberSquare(); +void testNumberSquareRoot(); +void testNumberEven(); +void testNumberOdd(); +void testNumberSign(); CPPUNIT_TEST_SUITE(ScDataTransformationTest); CPPUNIT_TEST(testColumnRemove); @@ -52,6 +64,18 @@ public: CPPUNIT_TEST(testAggregateAverage); CPPUNIT_TEST(testAggregateMin); CPPUNIT_TEST(testAggregateMax); +CPPUNIT_TEST(testNumberRound); +CPPUNIT_TEST(testNumberRoundUp); +CPPUNIT_TEST(testNumberRoundDown); +CPPUNIT_TEST(testNumberAbsolute); +CPPUNIT_TEST(testNumberLogE); +CPPUNIT_TEST(testNumberLog10); +CPPUNIT_TEST(testNumberCube); +CPPUNIT_TEST(testNumberSquare); +CPPUNIT_TEST(testNumberSquareRoot); +CPPUNIT_TEST(testNumberEven); +CPPUNIT_TEST(testNumberOdd); +CPPUNIT_TEST(testNumberSign); CPPUNIT_TEST_SUITE_END(); private: @@ -272,6 +296,195 @@ void ScDataTransformationTest::testAggregateMax() CPPUNIT_ASSERT_DOUBLES_EQUAL(2034, m_pDoc->GetValue(3, 4, 0), 1e-10); } +void ScDataTransformationTest::testNumberRound() +{ +m_pDoc->SetValue(2, 0, 0, 2034.342453456); +m_pDoc->SetValue(2, 1, 0, 2342.252678567542); +m_pDoc->SetValue(2, 2, 0, 57453.651345687654345676); +m_pDoc->SetValue(2, 3, 0, -453.22234567543); + +sc::NumberTransformation aTransform(2, sc::NUMBER_TRANSFORM_TYPE::ROUND, 4); +aTransform.Transform(*m_pDoc); + +CPPUNIT_ASSERT_EQUAL(2034.3425, m_pDoc->GetValue(2, 0, 0)); +CPPUNIT_ASSERT_EQUAL(2342.2527, m_pDoc->GetValue(2, 1, 0)); +CPPUNIT_ASSERT_EQUAL(57453.6513, m_pDoc->GetValue(2, 2, 0)); +CPPUNIT_ASSERT_EQUAL(-453.2223, m_pDoc->GetValue(2, 3, 0)); +} + +void ScDataTransformationTest::testNumberRoundUp() +{ +m_pDoc->SetValue(2, 0, 0, 2034.34); +m_pDoc->SetValue(2, 1, 0, 2342.22); +m_pDoc->SetValue(2, 2, 0, 57453.65); +m_pDoc->SetValue(2, 3, 0, -453.22); + +sc::NumberTransformation aTransform(2, sc::NUMBER_TRANSFORM_TYPE::ROUND_UP); +aTransform.Transform(*m_pDoc); + +CPPUNIT_ASSERT_EQUAL(2035.0, m_pDoc->GetValue(2, 0, 0)); +CPPUNIT_ASSERT_EQUAL(2343.0, m_pDoc->GetValue(2, 1, 0)); +CPPUNIT_ASSERT_EQUAL(57454.0, m_pDoc->GetValue(2, 2, 0)); +CPPUNIT_ASSERT_EQUAL(-453.0, m_pDoc->GetValue(2, 3, 0)); +} + +void ScDataTransformationTest::testNumberRoundDown() +{ +m_pDoc->SetValue(2, 0, 0, 2034.34); +m_pDoc->SetValue(2, 1, 0, 2342.22); +m_pDoc->SetValue(2, 2, 0, 57453.65); +m_pDoc->SetValue(2, 3, 0, -453.22); + +sc::NumberTransformation aTransform(2, sc::NUMBER_TRANSFORM_TYPE::ROUND_DOWN); +aTransform.Transform(*m_pDoc); + +CPPUNIT_ASSERT_EQUAL(2034.0, m_pDoc->GetValue(2, 0, 0)); +CPPUNIT_ASSERT_EQUAL(2342.0, m_pDoc->GetValue(2, 1, 0)); +CPPUNIT_ASSERT_EQUAL(57453.0, m_pDoc->GetValue(2, 2, 0)); +CPPUNIT_ASSERT_EQUAL(-454.0, m_pDoc->GetValue(2, 3, 0)); +} + +void ScDataTransformationTest::testNumberAbsolute() +{ +m_pDoc->SetValue(2, 0, 0, 2034.34); +
[Libreoffice-bugs] [Bug 107140] FILESAVE XLSX Additional empty columns and larger filesize after deleting a column
https://bugs.documentfoundation.org/show_bug.cgi?id=107140 Buovjaga changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected, ||filter:xlsx Version|4.3.0.4 release |4.1.0.4 release Summary|FILESAVE Additional empty |FILESAVE XLSX Additional |columns and larger filesize |empty columns and larger |after deleting a column |filesize after deleting a ||column --- Comment #9 from Buovjaga --- Bisected (targeting the file size increase) on Ubuntu 14.04 with 41max to: commit d4723d83549aaba53d9aca7055f7831c70527a1d Author: Matthew Francis Date: Fri Sep 18 10:25:49 2015 +0800 source-hash-b75bf09a5b905a3ed9c251869983a400c70c7fc6 commit b75bf09a5b905a3ed9c251869983a400c70c7fc6 Author: Noel Power AuthorDate: Tue Jan 29 14:51:49 2013 + Commit: Noel Power CommitDate: Wed Jan 30 18:01:45 2013 + correctly handle repeated row heights for empty rows ( fdo#59973 ) it seems both xls & xlsx export suffer from problems with multiple row heights repeated ( if those rows are empty ) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94499] FORMATTING: "Expand formatting" affects non-empty adjacent cell
https://bugs.documentfoundation.org/show_bug.cgi?id=94499 Buovjaga changed: What|Removed |Added Keywords|bibisectRequest, regression | Version|4.3.0.4 release |Inherited From OOo CC||todven...@suomi24.fi --- Comment #12 from Buovjaga --- Problem is already in 3.3.0. Before testing with it, I went through various Linux bibisect repos (oldest/latest commits) and the problem always appeared. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Is there someone who successfully make their own build of LibreOffice with Visual Studio 15.8.0 Preview 3.0 ?
Is there someone who successfully make their own build of LibreOffice with Visual Studio 15.8.0 Preview 3.0 ? by asking this question, I'm trying to be sure that the error was not my fault. I get the following error C:/build/workdir/UnpackedTarball/libmwaw/src/lib/ClarisDrawText.cxx(58): fatal error C1075: '{': no matching token found even after adding seekpos as follows https://developercommunity.visualstudio.com/content/problem/282567/member-seekpos-in-class-fpos-is-missing.html If I remember what I have done myself correctly, I haven't changed any parts of sourcecode of libmwaw since I successfully made my own build in June with previous version of Visual Studio. --- himajin10 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 90621] FORMATTING: Custom character styles are not applied in bibliographies
https://bugs.documentfoundation.org/show_bug.cgi?id=90621 Buovjaga changed: What|Removed |Added Keywords|bibisectRequest |notBibisectable Version|4.3.3.2 release |4.2.0.4 release --- Comment #16 from Buovjaga --- I tried bibisecting this with 42max on Ubuntu 14.04, but unfortunately there are crashes with launching and creating a new style. These prevent getting any meaningful result. Continuing with git bisect skip would have been insanity. I walked in the commits, backwards from the first known bad commit with "git reset --hard HEAD~100" (various values used) and then bouncing back and forth (git checkout back to the crashing one) when I ran into good territory. The border is just good<->crash. Anyway ,the earliest bad commit in the repo is d4e1a1073fc3d8d51aae700fb004a1adeb7dba2c -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45048] Inconsistent field name: Statistics instead of page count
https://bugs.documentfoundation.org/show_bug.cgi?id=45048 Dieter Praas changed: What|Removed |Added Version|unspecified |4.0 all versions --- Comment #11 from Dieter Praas --- Still reproducible in Version: 6.0.5.2 (x64) Build-ID: 54c8cbb85f300ac59db32fe8a675ff7683cd5a16 CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; Gebietsschema: de-DE (de_DE); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118541] Undesired font embedded in pdf form created with Libre Office Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=118541 Dieter Praas changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Blocks||103378 --- Comment #16 from Dieter Praas --- I was able to reproduce thedescribed behaviour with attachment 143354 from comment 7 (there was some Colibiri Font within the document so first I changed all to Trebuchet MS). I'm no expert in PDFExport, but I change the status to NEW, that means, that it is reproducible. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103378 [Bug 103378] [META] PDF export bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Dieter Praas changed: What|Removed |Added Depends on||118541 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=118541 [Bug 118541] Undesired font embedded in pdf form created with Libre Office Writer -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sc/source
sc/source/core/tool/interpr1.cxx | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) New commits: commit 57e908136f4b7135e6c4a35a81e45c47f9f1b548 Author: Eike Rathke Date: Sat Jul 7 23:00:50 2018 +0200 Resolves: tdf#118561 handle external references as jump matrix result Change-Id: I0381179347960293f5d470ed231d626cb6707b5a Reviewed-on: https://gerrit.libreoffice.org/57144 Reviewed-by: Eike Rathke Tested-by: Jenkins (cherry picked from commit a5b9bb7be70c7aec2388199e68a0cf86dd220955) Reviewed-on: https://gerrit.libreoffice.org/57147 diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx index dd1aaca90d53..33cd8c3f840e 100644 --- a/sc/source/core/tool/interpr1.cxx +++ b/sc/source/core/tool/interpr1.cxx @@ -713,10 +713,44 @@ bool ScInterpreter::JumpMatrix( short nStackLevel ) } } break; +case svExternalSingleRef: +{ +ScExternalRefCache::TokenRef pToken; +PopExternalSingleRef(pToken); +if (nGlobalError != FormulaError::NONE) +{ +pJumpMatrix->PutResultDouble( CreateDoubleError( nGlobalError), nC, nR ); +nGlobalError = FormulaError::NONE; +} +else +{ +switch (pToken->GetType()) +{ +case svDouble: +pJumpMatrix->PutResultDouble( pToken->GetDouble(), nC, nR ); +break; +case svString: +pJumpMatrix->PutResultString( pToken->GetString(), nC, nR ); +break; +case svEmptyCell: +pJumpMatrix->PutResultEmpty( nC, nR ); +break; +default: +// svError was already handled (set by +// PopExternalSingleRef()) with nGlobalError +// above. +assert(!"unhandled svExternalSingleRef case"); +pJumpMatrix->PutResultDouble( CreateDoubleError( + FormulaError::UnknownStackVariable), nC, nR ); +} +} +} +break; +case svExternalDoubleRef: case svMatrix: { // match matrix offsets double fVal; -ScMatrixRef pMat = PopMatrix(); +ScMatrixRef pMat = GetMatrix(); if ( nGlobalError != FormulaError::NONE ) { fVal = CreateDoubleError( nGlobalError ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 118621] UI: Request for Enhancement: Turn off Footer/Header Menu.
https://bugs.documentfoundation.org/show_bug.cgi?id=118621 --- Comment #2 from Christoph Bartz --- Good Point. The Header/Footer menu provides settings, that you only can find in a well hidden sub menu in Page Style Modify menu. Looked at that way, some more controls need to be added in Insert Menu and/or Page style dialog. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 118621] UI: Request for Enhancement: Turn off Footer/Header Menu.
https://bugs.documentfoundation.org/show_bug.cgi?id=118621 --- Comment #2 from Christoph Bartz --- Good Point. The Header/Footer menu provides settings, that you only can find in a well hidden sub menu in Page Style Modify menu. Looked at that way, some more controls need to be added in Insert Menu and/or Page style dialog. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 118620] PivotTable: the last row of a worksheet can't be used in the PivotTable (crash)
https://bugs.documentfoundation.org/show_bug.cgi?id=118620 --- Comment #4 from kabilo --- 48/5000 This bug exists for any range of rows (the last row is part of the range), for example A10485754:B10485756 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118620] PivotTable: the last row of a worksheet can't be used in the PivotTable (crash)
https://bugs.documentfoundation.org/show_bug.cgi?id=118620 Xisco Faulí changed: What|Removed |Added CC||dennisfrancis...@gmail.com, ||libreoff...@kohei.us, ||xiscofa...@libreoffice.org Keywords||bibisected, bisected Hardware|x86-64 (AMD64) |All OS|Windows (All) |All --- Comment #3 from Xisco Faulí --- > Selecting A1:B10485756 (from first to last row) > Menu/Insert/Pivot table > Accept current range. > LibreOffice crash with attached screenshot message. > "multi_typevector::get_block_position#816:block position not found| > (logical pos=1048576, block size 2, logical size=1048576)" Following these steps, it started to crash ( before it used to hang ) after https://cgit.freedesktop.org/libreoffice/core/commit/?id=d4cd8677889ec3807c194ef5b462f8e031807e5b author Kohei Yoshida 2017-05-22 21:08:56 -0400 committer Kohei Yoshida 2017-05-24 05:19:40 +0200 commit d4cd8677889ec3807c194ef5b462f8e031807e5b (patch) tree4b53429527d6358d145feef9912d0460924cbde0 parent 7948e84091f37fbda75f524f20138d1171918e64 (diff) tdf#107945: properly iterate over mtv during pivot cache loading. This reduces the total time required for populating the pivot cache by ~60%. Bisected with: bibisect-linux64-6.0 Adding Cc: to Kohei Yoshida -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87680] No accessible caret-moved events in Writer tables
https://bugs.documentfoundation.org/show_bug.cgi?id=87680 Buovjaga changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected CC||todven...@suomi24.fi --- Comment #15 from Buovjaga --- Bisected on Ubuntu 14.04 (w/ Orca) with 43max to: commit 69a440abc1db5fd999eae36b86e5098c67a5ca13 Author: Matthew Francis Date: Thu May 28 17:35:24 2015 +0800 source-hash-76c549eb01dcb7b5bf28a271ce00e386f3d388ba commit 76c549eb01dcb7b5bf28a271ce00e386f3d388ba Author: Steve Yin AuthorDate: Fri Nov 29 13:03:27 2013 + Commit: Caolán McNamara CommitDate: Mon Dec 2 10:25:33 2013 + Integrate branch of IAccessible2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105262] Copy image isn't working in Read-only mode
https://bugs.documentfoundation.org/show_bug.cgi?id=105262 Xisco Faulí changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |xiscofa...@libreoffice.org |desktop.org | CC||xiscofa...@libreoffice.org --- Comment #4 from Xisco Faulí --- Taking: https://gerrit.libreoffice.org/#/c/57162/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86919] Writer loses focus when toggling between full screen mode
https://bugs.documentfoundation.org/show_bug.cgi?id=86919 Buovjaga changed: What|Removed |Added Version|4.3.3.2 release |3.5.0 release Keywords|bibisectRequest |bibisected --- Comment #9 from Buovjaga --- Bibisected on Ubuntu 14.04 with 43all. The important thing was to toggle it many times so a certainty could be established (even dozens). The focus-losing appeared between last35onmaster and oldest. The range: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=2175576c120806f8415be7ab2051ba639a18f564...a39f4e5b57f5e518cc1ba09d5801da07b52fbaa5 Yet, like I said in comment 8, would be nice to hear the current status from Geoff and Michael. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118625] New: AutoFilter is lost when selecting blank values with no header
https://bugs.documentfoundation.org/show_bug.cgi?id=118625 Bug ID: 118625 Summary: AutoFilter is lost when selecting blank values with no header Product: LibreOffice Version: 6.0.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: david.cortes.riv...@gmail.com If I apply the AutoFilter functionality to a cell range that has no header columns and filter out to display only blank values, the filter is then lost and the rows become hidden. Steps to reproduce: -Fill in random numeric values in some cell range. -Delete at least one cell in one column in some row other than the first one. -Add AutoFilter on that cell range *without* using the first row as headers. -Click the autofilter arrow on some column with at least one empty/blank cell. -Select only blank/empty values. Expected behavior: -Should maintain the filter (showing arrows) like it does when there is a heading column or when displaying non-blank values within the filter. Actual behavior: -The filter (arrows at the top row) disappears and the rows become hidden. Setup: LO 6.0.5.2 running on Linux (Debian buster/sid). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118624] New: RAND() in an array returns the same value for each cell
https://bugs.documentfoundation.org/show_bug.cgi?id=118624 Bug ID: 118624 Summary: RAND() in an array returns the same value for each cell Product: LibreOffice Version: 6.0.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: david.cortes.riv...@gmail.com When creating a random array using the RAND() function in LO Calc, all the cells in the array are filled with the same number. Steps to reproduce: -Select multiple cells. -Type =RAND(). -Press Ctrl+Shift+Enter. Expected behavior: -Each cell should be filled in with a different random number. Actual behavior: -Each cell is filled in with the same random number. Setup: LO Calc 6.0.5.2, running on Linux (Debian buster/sid). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106723] Better visibility of not found search term
https://bugs.documentfoundation.org/show_bug.cgi?id=106723 --- Comment #8 from Jim Raykowski --- Would it be ok if I just take this one? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118623] EDITING Formula not working with empty cell
https://bugs.documentfoundation.org/show_bug.cgi?id=118623 --- Comment #2 from r...@berthor.eu --- Sorry not an issue, the formula need a : not a ; ... I thought that was working before but apparently no... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118623] EDITING Formula not working with empty cell
https://bugs.documentfoundation.org/show_bug.cgi?id=118623 himajin100...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG --- Comment #1 from himajin100...@gmail.com --- WRONG: =MAX(B1;Z1) CORRECT: =MAX(B1;Z2) and the correct formula returns 2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118623] New: EDITING Formula not working with empty cell
https://bugs.documentfoundation.org/show_bug.cgi?id=118623 Bug ID: 118623 Summary: EDITING Formula not working with empty cell Product: LibreOffice Version: 6.0.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: r...@berthor.eu Description: If an empty cell is present in the range of a formula (for example MAX) the formula take into account only the first cell. Steps to Reproduce: 1. Create a calc table 2. Add 1 in B1 3. Add 2 in C2 4. Write formula =MAX(B1;Z1) in A1 Actual Results: Result of formula in A1 is 1 Expected Results: Result of formula in A1 should be 2 Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118621] UI: Request for Enhancement: Turn off Footer/Header Menu.
https://bugs.documentfoundation.org/show_bug.cgi?id=118621 V Stuart Foote changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||qui...@gmail.com, ||vstuart.fo...@utsa.edu Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Keywords||needsUXEval --- Comment #1 from V Stuart Foote --- Controlled from the document canvas at https://opengrok.libreoffice.org/xref/core/sw/source/uibase/docvw/HeaderFooterWin.cxx#125 with linkages back to UI and Insert menu controls, and modification of the Page Style dialog's Header and Footer tabs. Don't see that it can be suppressed now. But, if controls were to be suppressed on the document canvas (i.e. the click in area of header or footer), would there need to be more controls added to the Insert menu or the Page Style dialog? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 118621] UI: Request for Enhancement: Turn off Footer/Header Menu.
https://bugs.documentfoundation.org/show_bug.cgi?id=118621 V Stuart Foote changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||qui...@gmail.com, ||vstuart.fo...@utsa.edu Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Keywords||needsUXEval --- Comment #1 from V Stuart Foote --- Controlled from the document canvas at https://opengrok.libreoffice.org/xref/core/sw/source/uibase/docvw/HeaderFooterWin.cxx#125 with linkages back to UI and Insert menu controls, and modification of the Page Style dialog's Header and Footer tabs. Don't see that it can be suppressed now. But, if controls were to be suppressed on the document canvas (i.e. the click in area of header or footer), would there need to be more controls added to the Insert menu or the Page Style dialog? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 118622] New: Unhandled exception when selecting remote server if parameters are null
https://bugs.documentfoundation.org/show_bug.cgi?id=118622 Bug ID: 118622 Summary: Unhandled exception when selecting remote server if parameters are null Product: LibreOffice Version: 6.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Android Viewer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: merttu...@outlook.com Description: Unhandled exception occurs when selecting remote server if parameters like host is empty Actual Results: 07-08 17:48:05.625 12033-12094/org.example.libreoffice E/ReadRemoteFileOperation: Synchronizing file /: Unexpected exception java.lang.IllegalArgumentException: host parameter is null at org.apache.commons.httpclient.HttpConnection.(HttpConnection.java:206) at org.apache.commons.httpclient.HttpConnection.(HttpConnection.java:155) at org.apache.commons.httpclient.MultiThreadedHttpConnectionManager$HttpConnectionWithReference.(MultiThreadedHttpConnectionManager.java:1145) at org.apache.commons.httpclient.MultiThreadedHttpConnectionManager$ConnectionPool.createConnection(MultiThreadedHttpConnectionManager.java:762) at org.apache.commons.httpclient.MultiThreadedHttpConnectionManager.doGetConnection(MultiThreadedHttpConnectionManager.java:476) at org.apache.commons.httpclient.MultiThreadedHttpConnectionManager.getConnectionWithTimeout(MultiThreadedHttpConnectionManager.java:416) at org.apache.commons.httpclient.HttpMethodDirector.executeMethod(HttpMethodDirector.java:153) at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:397) at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:323) at com.owncloud.android.lib.common.OwnCloudClient.executeMethod(OwnCloudClient.java:217) at com.owncloud.android.lib.common.OwnCloudClient.executeMethod(OwnCloudClient.java:187) at com.owncloud.android.lib.resources.files.ReadRemoteFileOperation.run(ReadRemoteFileOperation.java:82) at com.owncloud.android.lib.common.operations.RemoteOperation.execute(RemoteOperation.java:130) at org.libreoffice.storage.owncloud.OwnCloudProvider.createFromUri(OwnCloudProvider.java:84) at org.libreoffice.storage.owncloud.OwnCloudProvider.getRootDirectory(OwnCloudProvider.java:77) at org.libreoffice.ui.LibreOfficeUIActivity$4.doInBackground(LibreOfficeUIActivity.java:435) at org.libreoffice.ui.LibreOfficeUIActivity$4.doInBackground(LibreOfficeUIActivity.java:428) at android.os.AsyncTask$2.call(AsyncTask.java:333) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:245) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636) at java.lang.Thread.run(Thread.java:764) Expected Results: handled exception like alerting ui like theres no host given Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101689] Android Viewer calc returns to first sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=101689 Mert Tumer changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84726] [META] LibreOffice for Android most annoying bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=84726 Bug 84726 depends on bug 106371, which changed state. Bug 106371 Summary: Android: Add ability to Insert and manipulate tables (Writer, Impress documents) https://bugs.documentfoundation.org/show_bug.cgi?id=106371 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106371] Android: Add ability to Insert and manipulate tables (Writer, Impress documents)
https://bugs.documentfoundation.org/show_bug.cgi?id=106371 Mert Tumer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118598] BASE form navigation toolbar record count not displayed correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=118598 Drew Jensen changed: What|Removed |Added CC||drewjensen.in...@gmail.com --- Comment #2 from Drew Jensen --- Created attachment 143390 --> https://bugs.documentfoundation.org/attachment.cgi?id=143390=edit example This is as good an example of it as any, single form. Just open it and move the cursor focus between the main form controls and the sub-form grid control a few times. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118598] BASE form navigation toolbar record count not displayed correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=118598 Drew Jensen changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Drew Jensen --- I can confirm this behavior with 5.4.7.2 and 6.0.5.2. It seems to have gone away with 6.1RC1 and 6.2Alpha0 So, I'll set it to new and maybe if there is a 6.0.6 the fix could be backported. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118571] LibO 6.1 Help does not work Windows builds
https://bugs.documentfoundation.org/show_bug.cgi?id=118571 --- Comment #13 from Leopoldo Saggin --- I also can confirm this bug in LO 6.1.0 RC1 I use LibO with the American English interface and Italian settings (comma vs dot, main dictionary Italian etc..). The Help I dowloaded was the American English one. If I try to open Help -> LibreOffice Help (F1), a Firefox (my default browser) blank page opens while on the address bar this address is reported: file:///C:/Program%20Files/LibreOffice/help/index.html?swriter/.uno:HelpIndex?Language=en-US=WIN=6.1 Please note that this happens even after an installation from scratch of LibO was performed. Everything was ok in the previous version I used, ie 6.0.5.2. Regards, Leopoldo Saggin aka Topoldo -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118511] Add feature of repeating first row or column while exporting as PDF or image in LibreCalc
https://bugs.documentfoundation.org/show_bug.cgi?id=118511 m.a.riosv changed: What|Removed |Added Resolution|--- |WORKSFORME Status|UNCONFIRMED |RESOLVED --- Comment #2 from m.a.riosv --- Version: 6.0.5.2 (x64) Build ID: 54c8cbb85f300ac59db32fe8a675ff7683cd5a16 CPU threads: 4; OS: Windows 10.0; UI render: GL; Locale: es-ES (es_ES); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118511] Add feature of repeating first row or column while exporting as PDF or image in LibreCalc
https://bugs.documentfoundation.org/show_bug.cgi?id=118511 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Created attachment 143389 --> https://bugs.documentfoundation.org/attachment.cgi?id=143389=edit Sample file working with. Attached a sample file that works for me. It has defined Menu/Format/Print ranges. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101778] Several Icons of Toolbars are not greyed, if Document is in Read-only mode
https://bugs.documentfoundation.org/show_bug.cgi?id=101778 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #4 from Xisco Faulí --- Submitted a patch for the image toolbar: https://gerrit.libreoffice.org/#/c/57158/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118617] LibreOffice_6.0.5_Win_x86_helppack_en-GB.msi.torrent creates LibreOffice_6.0.5_Win_x86.msi
https://bugs.documentfoundation.org/show_bug.cgi?id=118617 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME CC||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- Can not confirm. Please check the torrent link used, and transfer again. with qBittorrent on Windows 10 Home 64-bit en-US the project archives [1] link download of http://download.documentfoundation.org/libreoffice/stable/6.0.5/win/x86/LibreOffice_6.0.5_Win_x86_helppack_en-GB.msi.torrent results in a file size 4.89 MB (5,128,192 bytes) that matches the published HASH (md5, sha1, sha256) for the install package [2]. =-ref-= [1] https://downloadarchive.documentfoundation.org/libreoffice/old/6.0.5.2/win/x86/ [2] Mirrors for LibreOffice_6.0.5_Win_x86_helppack_en-GB.msi File information Filename: LibreOffice_6.0.5_Win_x86_helppack_en-GB.msi Path: /libreoffice/stable/6.0.5/win/x86/LibreOffice_6.0.5_Win_x86_helppack_en-GB.msi Size: 4.9M (5128192 bytes) Last modified: Thu, 21 Jun 2018 21:04:28 GMT (Unix time: 1529615068) SHA-256 Hash: 0e1683ab78837fce3a2223f2ddb9c5ac7ebfeff0f5254fdf63bcd53bf5d6cf1f SHA-1 Hash: 689ebd3cea2526c1fe23ec34764e900f9deb07ca MD5 Hash: 763dfa15dd375372c6de7ee13614c58d BitTorrent Information Hash: 6b4a9f6abdc77a857f73e29524424a8efdbfc77e PGP signature available -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115935] PIVOT TABLE: add the option to link several tables as source on one pivot table.
https://bugs.documentfoundation.org/show_bug.cgi?id=115935 m.a.riosv changed: What|Removed |Added CC||minute.visit...@gmail.com --- Comment #2 from m.a.riosv --- *** Bug 118575 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118575] Calc: Pivot table from more sheets - consolidate without function
https://bugs.documentfoundation.org/show_bug.cgi?id=118575 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from m.a.riosv --- I think ti's covered for tdf#115935 *** This bug has been marked as a duplicate of bug 115935 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118620] PivotTable: the last row of a worksheet can't be used in the PivotTable (crash)
https://bugs.documentfoundation.org/show_bug.cgi?id=118620 --- Comment #2 from m.a.riosv --- I doesn't happen also with: Version: 5.4.6.2 (x64) Build ID: 4014ce260a04f1026ba855d3b8d91541c224eab8 CPU threads: 4; OS: Windows 6.19; UI render: GL; Locale: es-ES (es_ES); Calc: group So I guess the regression it's with version 6. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118620] PivotTable: the last row of a worksheet can't be used in the PivotTable (crash)
https://bugs.documentfoundation.org/show_bug.cgi?id=118620 m.a.riosv changed: What|Removed |Added Version|6.1.0.1 rc |6.0.5.2 release Ever confirmed|0 |1 Keywords||regression Severity|normal |critical Priority|medium |high Status|UNCONFIRMED |NEW Summary|PivotTable: the last row of |PivotTable: the last row of |a worksheet can't be used |a worksheet can't be used |in the PivotTable |in the PivotTable (crash) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118620] PivotTable: the last row of a worksheet can't be used in the PivotTable
https://bugs.documentfoundation.org/show_bug.cgi?id=118620 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Created attachment 143388 --> https://bugs.documentfoundation.org/attachment.cgi?id=143388=edit Screenshot with the crash message. I'm not sure if it's the same. Selecting A1:B10485756 (from first to last row) Menu/Insert/Pivot table Accept current range. LibreOffice crash with attached screenshot message. "multi_typevector::get_block_position#816:block position not found| (logical pos=1048576, block size 2, logical size=1048576)" First version with the issue Version: 6.0.5.2 (x64) Build ID: 54c8cbb85f300ac59db32fe8a675ff7683cd5a16 CPU threads: 4; OS: Windows 10.0; UI render: GL; Locale: es-ES (es_ES); Calc: CL It's a regression, doesn't happen with: Version: 5.2.7.1 Build ID: bf0fa7b86c7c0592941ede29fca6fafff642a948 CPU Threads: 4; OS Version: Windows 6.2; UI Render: GL; Locale: es-ES (es_ES); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118621] New: UI: Request for Enhancement: Turn off Footer/Header Menu.
https://bugs.documentfoundation.org/show_bug.cgi?id=118621 Bug ID: 118621 Summary: UI: Request for Enhancement: Turn off Footer/Header Menu. Product: LibreOffice Version: 6.0.5.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ch...@posteo.de Description: Note: This is not a bug, it is a request for an enhancement! In Writer: When You click over/under the page text area, the Header/Footer Menu pops up, with a smooth fade in / fade out visual effect. That is certainly well-meant, but for a user with a little bit experience in office applications this function is rather useless and annoying than useful. 1. It is annoying, when you add a header/footer with just one unintentional click on the plus sign. 2. It is annoying when you want to select table columns when they are at the top of the page. 3. It is annoying when a image slide to the header/footer area and you just want to select it. Look: First: How often do you add a Header or a footer to a text document? At most just ONE time, if any! Is it really necessary that EVERY time you just work over text area this menu pops up?? Second: There are other good, easy and intuitive ways to add a header/footer: → Menu »Insert« → »Header and Footer« → Navigation Bar → Page → checkbox for header and footer. So, my request is: Please (PLEASE) add a configuration option to turn off that header/footer menu! Maybe You could add a option in Expert Configurations, I dont mind, but please make it possible to switch it off! Steps to Reproduce: 1. Open Writer 2. Click over/under page text area Actual Results: Header/Footer Menu occurs. Expected Results: (I want to turn it off.) Reproducible: Always User Profile Reset: No Additional Info: Version: 6.0.5.2 (x64) Build ID: 54c8cbb85f300ac59db32fe8a675ff7683cd5a16 CPU threads: 2; OS: Windows 10.0; UI render: default; Locale: de-DE (de_DE); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83946 Bug 83946 depends on bug 89893, which changed state. Bug 89893 Summary: When a document is in read-only mode, Edit->Track Changes->{Next, Previous} Change are greyed out https://bugs.documentfoundation.org/show_bug.cgi?id=89893 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108882] [META] Read-only bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108882 Bug 108882 depends on bug 89893, which changed state. Bug 89893 Summary: When a document is in read-only mode, Edit->Track Changes->{Next, Previous} Change are greyed out https://bugs.documentfoundation.org/show_bug.cgi?id=89893 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118571] LibO 6.1 Help does not work Windows builds
https://bugs.documentfoundation.org/show_bug.cgi?id=118571 --- Comment #12 from V Stuart Foote --- (In reply to MBB from comment #11) > > To test if the previous help worked, and to have a working help? > The moving trick does give a working help in the browser (so thanks for > that), but not inside a LO popup window. (Not a full fix) > I tend to update the help less often the program anyway, only at the major > updates for the new features. > No, at 6.1 the "pop-up" help view (which used an HTML viewer internal to LibreOffice) has been replaced for the "new" help implementation. It will instead open into your system default HTML browser. And why testing it is worth doing the work around 'til it can be repackaged. > I've looked there, but did not see a newer version (6.1.0.2 right?), and no > "378e26bd4f22a135cef5fa17afd5d4171d8da21a" files or directories. It may or may not get a 6.1.0.2 tag (hope it will not take that long), and likely will be just a swap out of the 6.1.0.1 files with new date stamps. The md5 hash (e.g. 378e2... ) is the build signature (taken from the git hash of the last commit pulled from source when finalizing the build) you'll find it in the installed (or unpacked) instance in the program/version.ini file. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118609] [CRASH] [Basic] [Calc] on closing a file if open hidden and if a particular subroutine is used before closing
https://bugs.documentfoundation.org/show_bug.cgi?id=118609 Xisco Faulí changed: What|Removed |Added Keywords||bibisected, bisected --- Comment #8 from Xisco Faulí --- (In reply to Laurent BP from comment #6) > Suspected commit: > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=6388a50c1e3ef2e25132f63547bb91d08a0f416c > > CC Marco Indeed! Regression introduced by: author Marco Cecchetti 2017-04-19 22:37:13 +0200 committer Marco Cecchetti 2017-10-02 18:42:57 +0200 commit 6388a50c1e3ef2e25132f63547bb91d08a0f416c (patch) treee9eccab1f95b42eed7feb7bbb3e50ec912290678 parent b9e89a201064b0c0aef5769766bce8d995fed46d (diff) lok: sc: overlays and edit view misplaced by other view actions The edit view, the cell cursor and the cell selection overlays become misplaced when another user inserts, deletes or resizes a row. The same is true for columns. The solution takes care of the current tab each view is displaying and of undo/redo actions. Bisected with: bibisect-linux64-6.0 Adding Cc: to Marco Cecchetti -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118609] [CRASH] [Basic] [Calc] on closing a file if open hidden and if a particular subroutine is used before closing
https://bugs.documentfoundation.org/show_bug.cgi?id=118609 Xisco Faulí changed: What|Removed |Added Crash report or||["ScInputHandler::EnterHand crash signature||ler(ScEnterMode)"] CC||xiscofa...@libreoffice.org See Also||https://crashreport.libreof ||fice.org/stats/signature/Sc ||InputHandler::EnterHandler( ||ScEnterMode) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa sc/source sc/uiconfig
sc/qa/uitest/statistics/data/regression.ods |binary sc/source/ui/StatisticsDialogs/RegressionDialog.cxx |2 +- sc/uiconfig/scalc/ui/regressiondialog.ui|9 - 3 files changed, 9 insertions(+), 2 deletions(-) New commits: commit 187af5be47db42e2f4ab94319f932b847f897ce2 Author: Dennis Francis Date: Sun Jul 8 11:12:14 2018 +0530 tdf#118556 : Respect locale specific decimal separator... in Regression dialog box's confidence-level entry. Do not write floating-point numbers to cells as strings using OUString::number() converter if the cell is supposed to be a numeric one. This also amends the uitest document such that the "expected" confidence level cell is numeric and not string. Thanks to Julien Nabet for pointing me to the specific issue. Change-Id: I7d12674bf69fc53348366a03b7e6ff0af9588511 Reviewed-on: https://gerrit.libreoffice.org/57151 Tested-by: Jenkins Reviewed-by: Dennis Francis diff --git a/sc/qa/uitest/statistics/data/regression.ods b/sc/qa/uitest/statistics/data/regression.ods index e38d0a7ab26b..f9f65bfda0f5 100644 Binary files a/sc/qa/uitest/statistics/data/regression.ods and b/sc/qa/uitest/statistics/data/regression.ods differ diff --git a/sc/source/ui/StatisticsDialogs/RegressionDialog.cxx b/sc/source/ui/StatisticsDialogs/RegressionDialog.cxx index 086ef9b451cd..b3e744cdf71d 100644 --- a/sc/source/ui/StatisticsDialogs/RegressionDialog.cxx +++ b/sc/source/ui/StatisticsDialogs/RegressionDialog.cxx @@ -513,7 +513,7 @@ void ScRegressionDialog::WriteRegressionANOVAResults(AddressWalkerWriter& rOutpu rOutput.newLine(); rOutput.writeString(ScResId(STR_LABEL_CONFIDENCE_LEVEL)); rOutput.nextColumn(); -rOutput.writeString(OUString::number(mpConfidenceLevelField->GetValue() / 100.0)); +rOutput.writeValue(mpConfidenceLevelField->GetValue() / 100.0); rTemplate.autoReplaceAddress("%CONFIDENCE_LEVEL_ADDR%", rOutput.current()); rOutput.newLine(); } diff --git a/sc/uiconfig/scalc/ui/regressiondialog.ui b/sc/uiconfig/scalc/ui/regressiondialog.ui index 4ef37adfafdd..faa4aa307cfd 100644 --- a/sc/uiconfig/scalc/ui/regressiondialog.ui +++ b/sc/uiconfig/scalc/ui/regressiondialog.ui @@ -3,6 +3,12 @@ + +1 +0.94996 +0.01 +0.10001 + False 6 @@ -466,7 +472,8 @@ True start center -0.95 +0,95 +confidencelevel-adjustment 2 True 0.94996 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/sdi
sw/sdi/swriter.sdi |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit eedeeb63d1287ed0416e1fe3d2f7ba37632626d0 Author: Xisco Fauli Date: Sat Jul 7 00:39:38 2018 +0200 tdf#89893: Enable previous/next track changes in read-only mode Change-Id: Ie7dd41b2f79347e9b959a73d5915379f2e2a Reviewed-on: https://gerrit.libreoffice.org/57100 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky diff --git a/sw/sdi/swriter.sdi b/sw/sdi/swriter.sdi index 058fc4bc09f6..19aa9dfeae05 100644 --- a/sw/sdi/swriter.sdi +++ b/sw/sdi/swriter.sdi @@ -7263,7 +7263,7 @@ SfxVoidItem NextTrackedChange FN_REDLINE_NEXT_CHANGE [ AutoUpdate = FALSE, FastCall = FALSE, -ReadOnlyDoc = FALSE, +ReadOnlyDoc = TRUE, Toggle = FALSE, Container = FALSE, RecordAbsolute = FALSE, @@ -7281,7 +7281,7 @@ SfxVoidItem PreviousTrackedChange FN_REDLINE_PREV_CHANGE [ AutoUpdate = FALSE, FastCall = FALSE, -ReadOnlyDoc = FALSE, +ReadOnlyDoc = TRUE, Toggle = FALSE, Container = FALSE, RecordAbsolute = FALSE, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 114905] CRASH: LibreOffice crashes opening the new file dialog from the notebookbar
https://bugs.documentfoundation.org/show_bug.cgi?id=114905 Xisco Faulí changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #9 from Xisco Faulí --- (In reply to Aron Budea from comment #8) > Xisco, is this crash still reproducible for you in 6.1.0.1? I can see the > layout has somewhat changed, and there's no crash for me anymore. Yep, you're right, I can't reproduce it anymore with the new layouts Version: 6.2.0.0.alpha0+ Build ID: 363146254bd44ab82d657f2ca0293d03bd111280 CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded closing as RESOLVED WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107237] [META] Notebookbar Tabbed Implementation
https://bugs.documentfoundation.org/show_bug.cgi?id=107237 Bug 107237 depends on bug 114905, which changed state. Bug 114905 Summary: CRASH: LibreOffice crashes opening the new file dialog from the notebookbar https://bugs.documentfoundation.org/show_bug.cgi?id=114905 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106723] Better visibility of not found search term
https://bugs.documentfoundation.org/show_bug.cgi?id=106723 --- Comment #7 from Xisco Faulí --- (In reply to Jim Raykowski from comment #5) > If anyone interested in working on this I can give code pointers from > experience with tdf#81925 and tdf#116596 You can also add the code pointers and add the keyword easyHack :) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118541] Undesired font embedded in pdf form created with Libre Office Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=118541 --- Comment #15 from himajin100...@gmail.com --- (In reply to jean.francois.taste from comment #14) > I don't understand why the status has been changed to unconfirmed as I sent > properties/Font copy showing Helvetica and ZapfDingbats in the pdf form > Can you please explain me ? > regards > > PS : sorry, I didn't view my 2 previous comments and thought that they were > not sent. The bug should be confirmed by another person than the reporter for the NEW status, and I first set to NEW status as such a person, thinking I was able to reproduce the bug myself by placing either checkbox, radio buttons, push buttons and take a look at the produced pdfs with my PDF-XChange. I thought those are the only controls that reproduces the situation with the source code pointer in comment 5 However, as given in comment 9 and in your attachements, later it turned out that you were able to reproduce the bug even without those controls. Here I came to think that what I'm seeing is not necessarily from the same cause as yours. That's why I set back to UNCONFIRMED status. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118541] Undesired font embedded in pdf form created with Libre Office Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=118541 --- Comment #14 from jean.francois.ta...@gmail.com --- I don't understand why the status has been changed to unconfirmed as I sent properties/Font copy showing Helvetica and ZapfDingbats in the pdf form Can you please explain me ? regards PS : sorry, I didn't view my 2 previous comments and thought that they were not sent. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118541] Undesired font embedded in pdf form created with Libre Office Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=118541 --- Comment #13 from jean.francois.ta...@gmail.com --- Created attachment 143387 --> https://bugs.documentfoundation.org/attachment.cgi?id=143387=edit pdf form properties You will find here attached a screen copy of the pdf form created with the original-odt-test-document. Showing that Helvetica and ZapfDingbats are present in the pdf file. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118555] mangled text in Expert Configuration
https://bugs.documentfoundation.org/show_bug.cgi?id=118555 Adolfo Jayme changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||8577 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118577] Corruption in letters of Autocorrect Options -> Replace tab pair listings
https://bugs.documentfoundation.org/show_bug.cgi?id=118577 Adolfo Jayme changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||8555 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118017] support macOS 10.14 mojave dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118017 --- Comment #1 from steve -_- --- Interesting thoughts on dark mode from dev perspective: https://mackuba.eu/2018/07/04/dark-side-mac-1/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/app/settings.cxx | 253 +++- 1 file changed, 88 insertions(+), 165 deletions(-) New commits: commit ce2a2c6cdf36d21dd208c3f2f4907de483ce6fd3 Author: Jochen Nitschke Date: Sat Jul 7 15:05:34 2018 +0200 cppcheck: useInitializationList in settings.cxx and remove some default-able constructors Change-Id: I3ff5cb9d68143bb13a362383255da98f7bf6bd86 Reviewed-on: https://gerrit.libreoffice.org/57135 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/vcl/source/app/settings.cxx b/vcl/source/app/settings.cxx index 92904ec759d6..a000b065092d 100644 --- a/vcl/source/app/settings.cxx +++ b/vcl/source/app/settings.cxx @@ -59,26 +59,23 @@ using namespace ::com::sun::star; struct ImplMouseData { -ImplMouseData(); -ImplMouseData( const ImplMouseData& rData ); - -MouseSettingsOptionsmnOptions; -sal_uInt64 mnDoubleClkTime; -longmnDoubleClkWidth; -longmnDoubleClkHeight; -longmnStartDragWidth; -longmnStartDragHeight; -sal_uInt16 mnStartDragCode; -sal_uInt16 mnContextMenuCode; -sal_uInt16 mnContextMenuClicks; -sal_uLong mnScrollRepeat; -sal_uLong mnButtonStartRepeat; -sal_uLong mnButtonRepeat; -sal_uLong mnActionDelay; -sal_uLong mnMenuDelay; -MouseFollowFlagsmnFollow; -MouseMiddleButtonAction mnMiddleButtonAction; -MouseWheelBehaviour mnWheelBehavior; +MouseSettingsOptionsmnOptions = MouseSettingsOptions::NONE; +sal_uInt64 mnDoubleClkTime = 500; +longmnDoubleClkWidth= 2; +longmnDoubleClkHeight = 2; +longmnStartDragWidth= 2 ; +longmnStartDragHeight = 2; +sal_uInt16 mnStartDragCode = MOUSE_LEFT; +sal_uInt16 mnContextMenuCode = MOUSE_RIGHT; +sal_uInt16 mnContextMenuClicks = 1; +sal_uLong mnScrollRepeat = 100; +sal_uLong mnButtonStartRepeat = 370; +sal_uLong mnButtonRepeat = 90; +sal_uLong mnActionDelay = 250; +sal_uLong mnMenuDelay = 150; +MouseFollowFlagsmnFollow= MouseFollowFlags::Menu | MouseFollowFlags::DDList; +MouseMiddleButtonAction mnMiddleButtonAction= MouseMiddleButtonAction::AutoScroll; +MouseWheelBehaviour mnWheelBehavior = MouseWheelBehaviour::ALWAYS; }; struct ImplStyleData @@ -213,7 +210,6 @@ struct ImplStyleData struct ImplMiscData { ImplMiscData(); -ImplMiscData( const ImplMiscData& rData ); TriStatemnEnableATT; boolmbEnableLocalizedDecimalSep; TriStatemnDisablePrinting; @@ -222,12 +218,9 @@ struct ImplMiscData struct ImplHelpData { -ImplHelpData(); -ImplHelpData( const ImplHelpData& rData ); - -sal_uLong mnTipDelay; -sal_uLong mnTipTimeout; -sal_uLong mnBalloonDelay; +sal_uLong mnTipDelay = 500; +sal_uLong mnTipTimeout = 3000; +sal_uLong mnBalloonDelay = 1500; }; struct ImplAllSettingsData @@ -250,48 +243,6 @@ struct ImplAllSettingsData SvtSysLocalemaSysLocale; }; -ImplMouseData::ImplMouseData() -{ -mnOptions = MouseSettingsOptions::NONE; -mnDoubleClkTime = 500; -mnDoubleClkWidth= 2; -mnDoubleClkHeight = 2; -mnStartDragWidth= 2; -mnStartDragHeight = 2; -mnStartDragCode = MOUSE_LEFT; -mnContextMenuCode = MOUSE_RIGHT; -mnContextMenuClicks = 1; -mnMiddleButtonAction= MouseMiddleButtonAction::AutoScroll; -mnScrollRepeat = 100; -mnButtonStartRepeat = 370; -mnButtonRepeat = 90; -mnActionDelay = 250; -mnMenuDelay = 150; -mnFollow= MouseFollowFlags::Menu | MouseFollowFlags::DDList; -mnWheelBehavior = MouseWheelBehaviour::ALWAYS; -} - -ImplMouseData::ImplMouseData( const
[Libreoffice-bugs] [Bug 79878] Writer freezes for minutes when opening .docx due to slow XML parse
https://bugs.documentfoundation.org/show_bug.cgi?id=79878 Commit Notification changed: What|Removed |Added Whiteboard||target:6.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79878] Writer freezes for minutes when opening .docx due to slow XML parse
https://bugs.documentfoundation.org/show_bug.cgi?id=79878 --- Comment #15 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a2193f8f33565cc896592acb9d3ab65c756d97fb tdf#79878 perf loading docx file, sax improvements It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: canvas/source io/test package/source sal/qa sw/source testtools/source vcl/unx vcl/workben
canvas/source/directx/dx_9rm.cxx |7 ++- io/test/stm/pumptest.cxx |5 ++--- io/test/testconnection.cxx|6 ++ package/source/zipapi/ZipOutputStream.cxx |3 +-- sal/qa/osl/mutex/osl_Mutex.cxx|5 + sal/qa/osl/pipe/osl_Pipe.cxx |5 + sal/qa/osl/process/osl_Thread.cxx |9 + sal/qa/rtl/doublelock/rtl_doublelocking.cxx | 10 +- sw/source/core/docnode/finalthreadmanager.cxx | 10 ++ testtools/source/bridgetest/cppobj.cxx|7 ++- testtools/source/performance/ubtest.cxx |6 ++ vcl/unx/generic/dtrans/X11_selection.cxx | 11 ++- vcl/workben/vcldemo.cxx | 19 --- 13 files changed, 27 insertions(+), 76 deletions(-) New commits: commit d0f44d8ba7e87aa263008d3cfc4e68294d783162 Author: Kevin Dubrulle Date: Sat Jul 7 13:34:20 2018 +0200 tdf#84323 - sal - add sane sleep interface: cleanup osl_waitThread Replace osl_waitThread by osl::Thread::wait. Use std::chrono instead of TimeValue. Change-Id: I71691d014feeeb0c5d0ba29d048bda8e25e6e7dd Reviewed-on: https://gerrit.libreoffice.org/57130 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/canvas/source/directx/dx_9rm.cxx b/canvas/source/directx/dx_9rm.cxx index 3cc7fd5437a3..55165bbcedcc 100644 --- a/canvas/source/directx/dx_9rm.cxx +++ b/canvas/source/directx/dx_9rm.cxx @@ -27,7 +27,7 @@ #include #include #include -#include +#include #include #include #include @@ -880,10 +880,7 @@ namespace dxcanvas return true; } -TimeValue aTimeout; -aTimeout.Seconds=1; -aTimeout.Nanosec=0; -osl_waitThread(); +osl::Thread::wait(std::chrono::seconds(1)); } while(hr == D3DERR_DEVICELOST); diff --git a/io/test/stm/pumptest.cxx b/io/test/stm/pumptest.cxx index 8077760a351f..d337bc21a81a 100644 --- a/io/test/stm/pumptest.cxx +++ b/io/test/stm/pumptest.cxx @@ -35,7 +35,7 @@ #include #include #include -#include +#include #include @@ -50,8 +50,7 @@ using namespace ::com::sun::star::test; static void mywait() { -TimeValue a = { 0, 1 }; -osl_waitThread( ); +osl::Thread::wait(std::chrono::microseconds(10)); osl_yieldThread(); osl_yieldThread(); } diff --git a/io/test/testconnection.cxx b/io/test/testconnection.cxx index 69a2bdeccfb8..68621643f0ec 100644 --- a/io/test/testconnection.cxx +++ b/io/test/testconnection.cxx @@ -127,8 +127,7 @@ void testConnection( const OUString , try { // Why is this wait necessary -TimeValue value = {1,0}; -osl_waitThread( ); +osl::Thread::wait(std::chrono::seconds(1)); r = rConnector->connect( sConnectionDescription ); OSL_ASSERT( r.is() ); doWrite( r ); @@ -238,8 +237,7 @@ int SAL_CALL main( int argc, char * argv[] ) MyThread thread( rAcceptor , OUString("socket,host=localhost,port=2001") ); thread.create(); -TimeValue value = {0,1}; -osl_waitThread( ); +osl::Thread::wait(std::chrono::nanoseconds(1)); try { rAcceptor->accept( OUString("socket,host=localhost,port=2001") ); diff --git a/package/source/zipapi/ZipOutputStream.cxx b/package/source/zipapi/ZipOutputStream.cxx index 94f8d024dd7c..c15fdaee48ef 100644 --- a/package/source/zipapi/ZipOutputStream.cxx +++ b/package/source/zipapi/ZipOutputStream.cxx @@ -154,8 +154,7 @@ void ZipOutputStream::reduceScheduledThreadsToGivenNumberOrLess(sal_Int32 nThrea if(static_cast< sal_Int32 >(m_aEntries.size()) > nThreads) { -const TimeValue aTimeValue(0, 10); -osl_waitThread(); +osl::Thread::wait(std::chrono::microseconds(100)); } } } diff --git a/sal/qa/osl/mutex/osl_Mutex.cxx b/sal/qa/osl/mutex/osl_Mutex.cxx index 90f5b31e2c79..c9959038c5ea 100644 --- a/sal/qa/osl/mutex/osl_Mutex.cxx +++ b/sal/qa/osl/mutex/osl_Mutex.cxx @@ -34,10 +34,7 @@ namespace ThreadHelper { void thread_sleep_tenth_sec(sal_uInt32 _nTenthSec) { -TimeValue nTV; -nTV.Seconds = _nTenthSec/10; -nTV.Nanosec = ( (_nTenthSec%10 ) * 1 ); -osl_waitThread(); +osl::Thread::wait(std::chrono::milliseconds(_nTenthSec * 100)); } void thread_sleep( sal_uInt32 _nSec ) { diff --git a/sal/qa/osl/pipe/osl_Pipe.cxx b/sal/qa/osl/pipe/osl_Pipe.cxx index ea29fdd7c742..dbd224e50da5 100644 --- a/sal/qa/osl/pipe/osl_Pipe.cxx +++ b/sal/qa/osl/pipe/osl_Pipe.cxx @@ -743,10 +743,7 @@ namespace osl_StreamPipe /// print statement in thread process must use fflush() to force display.
[Libreoffice-commits] core.git: include/sax sax/source writerfilter/source
include/sax/fastattribs.hxx| 11 + sax/source/fastparser/fastparser.cxx | 13 ++- sax/source/tools/fastattribs.cxx | 18 +++- writerfilter/source/ooxml/OOXMLFactory.cxx | 32 +++-- 4 files changed, 48 insertions(+), 26 deletions(-) New commits: commit a2193f8f33565cc896592acb9d3ab65c756d97fb Author: Noel Grandin Date: Thu Jul 5 12:33:51 2018 +0200 tdf#79878 perf loading docx file, sax improvements these are the smaller improvements, they make about 5% worth of difference - use std::vector instead of std::deque - use std::move on pendingCharacters instead of copying - in FastAttributeList::add, when reallocate the buffer, allocate twice the existing size, instead of increasing to only what we need - in FastAttributeList, create getAttributeIndex and friends, so we can avoid iterating the attribute list more often than necessary Change-Id: I3e3380ea50b77c6845b66e83404e245778ec06eb Reviewed-on: https://gerrit.libreoffice.org/57021 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/include/sax/fastattribs.hxx b/include/sax/fastattribs.hxx index b5fbe225ee28..029f3a12f780 100644 --- a/include/sax/fastattribs.hxx +++ b/include/sax/fastattribs.hxx @@ -93,6 +93,9 @@ public: bool getAsInteger( sal_Int32 nToken, sal_Int32 ) const; bool getAsDouble( sal_Int32 nToken, double ) const; bool getAsChar( sal_Int32 nToken, const char*& rPos ) const; +sal_Int32 getAsIntegerByIndex( sal_Int32 nTokenIndex ) const; +const char* getAsCharByIndex( sal_Int32 nTokenIndex ) const; +OUString getValueByIndex( sal_Int32 nTokenIndex ) const; // XFastAttributeList virtual sal_Bool SAL_CALL hasAttribute( ::sal_Int32 Token ) override; @@ -103,6 +106,14 @@ public: virtual css::uno::Sequence< css::xml::Attribute > SAL_CALL getUnknownAttributes( ) override; virtual css::uno::Sequence< css::xml::FastAttribute > SAL_CALL getFastAttributes() override; +sal_Int32 getAttributeIndex( ::sal_Int32 Token ) +{ +for (size_t i=0; i& xAttrList ) { diff --git a/sax/source/fastparser/fastparser.cxx b/sax/source/fastparser/fastparser.cxx index 2765584a08fc..9477559c12e8 100644 --- a/sax/source/fastparser/fastparser.cxx +++ b/sax/source/fastparser/fastparser.cxx @@ -178,13 +178,13 @@ struct Entity : public ParserData void throwException( const ::rtl::Reference< FastLocatorImpl > , bool mbDuringParse ); -std::stack< NameWithToken > maNamespaceStack; +std::stack< NameWithToken, std::vector > maNamespaceStack; /* Context for main thread consuming events. * startElement() stores the data, which characters() and endElement() uses */ -std::stack< SaxContext> maContextStack; +std::stack< SaxContext, std::vector > maContextStack; // Determines which elements of maNamespaceDefines are valid in current context -std::stack< sal_uInt32 > maNamespaceCount; +std::stack< sal_uInt32, std::vector > maNamespaceCount; std::vector< std::shared_ptr< NamespaceDefine > > maNamespaceDefines; @@ -270,7 +270,7 @@ private: ParserData maData; /// Cached parser configuration for next call of parseStream(). Entity *mpTop; /// std::stack::top() is amazingly slow => cache this. -std::stack< Entity > maEntities; /// Entity stack for each call of parseStream(). +std::stack< Entity > maEntities;/// Entity stack for each call of parseStream(). OUString pendingCharacters; /// Data from characters() callback that needs to be sent. }; @@ -674,11 +674,12 @@ sal_Int32 FastSaxParserImpl::GetTokenWithPrefix( const xmlChar* pPrefix, int nPr sal_uInt32 nNamespace = rEntity.maNamespaceCount.top(); while( nNamespace-- ) { -const OString& rPrefix( rEntity.maNamespaceDefines[nNamespace]->maPrefix ); +const auto & rNamespaceDefine = rEntity.maNamespaceDefines[nNamespace]; +const OString& rPrefix( rNamespaceDefine->maPrefix ); if( (rPrefix.getLength() == nPrefixLen) && (strncmp( rPrefix.getStr(), XML_CAST( pPrefix ), nPrefixLen ) == 0 ) ) { -nNamespaceToken = rEntity.maNamespaceDefines[nNamespace]->mnToken; +nNamespaceToken = rNamespaceDefine->mnToken; break; } diff --git a/sax/source/tools/fastattribs.cxx b/sax/source/tools/fastattribs.cxx index a9f0baf7a2c0..30a764368947 100644 --- a/sax/source/tools/fastattribs.cxx +++ b/sax/source/tools/fastattribs.cxx @@ -86,7 +86,7 @@ void FastAttributeList::add( sal_Int32 nToken, const sal_Char* pValue, size_t nV maAttributeValues.push_back( maAttributeValues.back() + nValueLength + 1 ); if (maAttributeValues.back() >
[Libreoffice-bugs] [Bug 118514] overflow at realpath()
https://bugs.documentfoundation.org/show_bug.cgi?id=118514 --- Comment #4 from Dhiraj --- (In reply to Stephan Bergmann from comment #3) > (In reply to Dhiraj from comment #0) > > File: > > https://github.com/LibreOffice/core/blob/master/desktop/unx/source/start. > > c#L191 > > i.e., > > dummy = realpath(pPath, pRealPath); > > > This function does not protect against buffer overflows, and some > > implementations can overflow internally. > > > > Ensure that the destination buffer is at least of size MAXPATHLEN, andto > > protect against implementation problems, the input argument should also be > > checked to ensure it is no larger than MAXPATHLEN. > > What is MAXPATHLEN? What platform are you talking about? At least SUSv4 > doesn't have any such requirements on realpath(3), nor does it mention > MAXPATHLEN. > > > According to the documentation of realpath() the output buffer needs to be > > at least of size PATH_MAX specifying output buffers large enough to handle > > the maximum-size possible result from path manipulation functions. > > ...and pRealPath is of sufficient size, see > > char pRealPath[PATH_MAX]; > > a few lines further up. Or what am I missing? In FreeBSD libc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118620] New: PivotTable: the last row of a worksheet can't be used in the PivotTable
https://bugs.documentfoundation.org/show_bug.cgi?id=118620 Bug ID: 118620 Summary: PivotTable: the last row of a worksheet can't be used in the PivotTable Product: LibreOffice Version: 6.1.0.1 rc Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: minute.visit...@gmail.com Description: the last row of a worksheet can't be used when create a new PivotTable. You receive error message. Actual Results: Expected Results: Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs