[Libreoffice-bugs] [Bug 121486] Text in Thai for some font go right to left

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121486

tongwa...@hotmail.com changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121486] Text in Thai for some font go right to left

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121486

--- Comment #2 from tongwa...@hotmail.com ---
Created attachment 147013
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147013=edit
Bug sample of problemati font in ODT doc

I've attached a document with passages in the fonts in question.
I've also embedded the font with the document, and included a link to download
them, and their Wikipedia page.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


License Statement

2018-11-24 Thread Howard Johnson

Hi,

As per your request onhttps://wiki.documentfoundation.org/Development/Developers


BUT, pleasedon't publicly post my bare email addressed to theDevelopers and 
Contributors list

at:https://wiki.documentfoundation.org/Development/Developers


Rather, please post this one:*h...@fullname.name*.

Thanks.



All of my past & future contributions to LibreOffice may be
licensed under the MPLv2/LGPLv3+ dual license.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 103459] [META] Sidebar UI and UX bugs and enhancements

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103459

Aron Budea  changed:

   What|Removed |Added

 Depends on||119370


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=119370
[Bug 119370] Sidebar - Calc sidebar unresponsive when editing a chart
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 119370] Sidebar - Calc sidebar unresponsive when editing a chart

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119370

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
 Blocks||103459

--- Comment #13 from Aron Budea  ---
For me it still doesn't work properly in 6.3.0.0.alpha0+
(67e062aa5e5946d4985921fe2b6f87766f363ddc) / Windows 7.

However, what I see doesn't seem to be a regression from the mentioned commit,
as I can reproduce even with 5.1.0.3, when the chart sidebar was introduced.

My steps (based on description):
- Have sidebar open, but no decks open initially.
- Create a chart, and click into it.

(=> Bug 1: list of sidebar decks isn't updated, it should only show Properties)

- Select an element, eg. the label.
- Open Properties deck, and click anywhere on it.

=> It behaves as if you selected a cell in the sheet where you clicked.

This only happens if you entered the chart with no open deck/sidebar. However,
if you entered it with an open deck/sidebar, and attempt to hide it, its empty
space will remain on the screen. It isn't exactly what Miguel Angel's
screenshot shows, but is likely related.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103459
[Bug 103459] [META] Sidebar UI and UX bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 100037] Image arrangement (in Z dimension) not respected in docx (EMF included)

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100037

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 67883] HTML Pasting merged cells gives wrong layout

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=67883

--- Comment #11 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112603] FILEOPEN: EMF - Image has no bold border

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112603

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 101313] Copy-paste a Table With Merged Cells: Loss of formatting (Cells Placed in Wrong Position)

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101313

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113441] Inserted PDFs - loss of sharpness since LO 5.4

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113441

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113999] Page format preview corrupted when height is getting smaller than width

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113999

--- Comment #3 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 106810] set transparent background color in form controls

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106810

he...@thedigitaldaisy.com changed:

   What|Removed |Added

  Component|Writer  |Draw

--- Comment #6 from he...@thedigitaldaisy.com ---
Yes please could this be looked into ASAP? This is such a brilliant set of
tools I am so stoked to have found it! But this is become a problem as I work
with a lot of fillable PDF forms (which I create in Draw & export as a PDF).
Thank you so much!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


CppCheck Report Update

2018-11-24 Thread cppcheck.libreoff...@gmail.com

A new cppcheck report is available at : 
http://dev-builds.libreoffice.org/cppcheck_reports/master/


Note:
The script generating this report was run at :
2018-25-11 03:18:52 with user buildslave at host vm140 as 
/home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s 
/home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w 
/home/buildslave/tmp/www

It can be found and improved here:

https://gerrit.libreoffice.org/plugins/gitiles/dev-tools/+/master/cppcheck/cppcheck-report.sh


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: sc/source

2018-11-24 Thread Libreoffice Gerrit user
 sc/source/filter/xml/XMLDDELinksContext.hxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 85f129b59ca690ba519cdbbdb4219fddc3e90098
Author: Julien Nabet 
AuthorDate: Sat Nov 24 23:33:47 2018 +0100
Commit: Julien Nabet 
CommitDate: Sun Nov 25 00:41:29 2018 +0100

Replace list by vector for ScDDELinkCells typedef (sc)

Change-Id: I3531ebc46bfc1c4362fafd7f6c93dd97f85676fa
Reviewed-on: https://gerrit.libreoffice.org/63963
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/sc/source/filter/xml/XMLDDELinksContext.hxx 
b/sc/source/filter/xml/XMLDDELinksContext.hxx
index 5c132353a0c1..67fbab3f29b1 100644
--- a/sc/source/filter/xml/XMLDDELinksContext.hxx
+++ b/sc/source/filter/xml/XMLDDELinksContext.hxx
@@ -21,7 +21,7 @@
 #define INCLUDED_SC_SOURCE_FILTER_XML_XMLDDELINKSCONTEXT_HXX
 
 #include "importcontext.hxx"
-#include 
+#include 
 
 namespace sax_fastparser { class FastAttributeList; }
 
@@ -44,7 +44,7 @@ struct ScDDELinkCell
 bool bEmpty;
 };
 
-typedef std::list ScDDELinkCells;
+typedef std::vector ScDDELinkCells;
 
 class ScXMLDDELinkContext : public ScXMLImportContext
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 120497] Fontwork messed up after last LibreOffice upgrade

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120497

--- Comment #6 from tiotrom  ---
Indeed I don't see the bug in 6.1.3 - awesome! :)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: autogen.sh compilerplugins/clang

2018-11-24 Thread Libreoffice Gerrit user
 autogen.sh  |2 +-
 compilerplugins/clang/pluginhandler.hxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit d057e61cb5aae15ea37ce9ac824647cd2060e331
Author: Stephan Bergmann 
AuthorDate: Sat Nov 24 22:36:48 2018 +0100
Commit: Stephan Bergmann 
CommitDate: Sun Nov 25 00:25:43 2018 +0100

Restrict Developer Toolset to Config=linux_gcc_release_64

The Jenkins "Gerrit Linux clang/dbgutil" builds started to fail in odd ways,
presumably because of having the Developer Toolset in the PATH now when 
building
compilerplugins.  So change compilerplugins/clang/pluginhandler.hxx 
slightly to
force rebuild.

Change-Id: I97b8f89dc2e20c85f130284ca5326a5c96c2a1ba
Reviewed-on: https://gerrit.libreoffice.org/63962
Tested-by: Stephan Bergmann 
Reviewed-by: Stephan Bergmann 

diff --git a/autogen.sh b/autogen.sh
index 478aed6944b5..98dcb950886e 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -153,7 +153,7 @@ if (defined $ENV{LODE_HOME})
 }
 # For the Config=linux_gcc_release_64 Jenkins jobs that build on CentOS 
against Developer
 # Toolset 7:
-if (-d '/opt/rh/devtoolset-7/root/usr/bin')
+if ($ENV{Config} eq 'linux_gcc_release_64' && -d 
'/opt/rh/devtoolset-7/root/usr/bin')
 {
 $ENV{PATH}="/opt/rh/devtoolset-7/root/usr/bin:$ENV{PATH}";
 print STDERR "added /opt/rh/devtoolset-7/root/usr/bin to PATH\n";
diff --git a/compilerplugins/clang/pluginhandler.hxx 
b/compilerplugins/clang/pluginhandler.hxx
index 1cb405d54d35..d51afebccac7 100644
--- a/compilerplugins/clang/pluginhandler.hxx
+++ b/compilerplugins/clang/pluginhandler.hxx
@@ -91,7 +91,7 @@ private:
 std::vector< std::string > _args;
 };
 
-} // namespace
+}
 
 #endif // COMPILEPLUGIN_H
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: basegfx/source

2018-11-24 Thread Libreoffice Gerrit user
 basegfx/source/polygon/b2dtrapezoid.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 2cc09c4650c2fc6acc0157cd26acad248f32c5ac
Author: Andrea Gelmini 
AuthorDate: Sat Nov 24 23:36:55 2018 +0100
Commit: Julien Nabet 
CommitDate: Sun Nov 25 00:15:25 2018 +0100

Fix typo

Change-Id: I8e90b4592d041e63bd2efa914446db96dd293ac9
Reviewed-on: https://gerrit.libreoffice.org/63964
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/basegfx/source/polygon/b2dtrapezoid.cxx 
b/basegfx/source/polygon/b2dtrapezoid.cxx
index 9bff42a0d0a6..9ddeed3309b9 100644
--- a/basegfx/source/polygon/b2dtrapezoid.cxx
+++ b/basegfx/source/polygon/b2dtrapezoid.cxx
@@ -588,7 +588,7 @@ namespace basegfx
 {
 // This is the central subdivider. The strategy is to use the 
first two entries
 // from the traversing edges as a potential trapezoid and do 
the needed corrections
-// and adaptions on the way.
+// and adaptations on the way.
 
 // There always must be two edges with the same YStart value: 
When adding the polygons
 // in the constructor, there is always a topmost point from 
which two edges start; when
@@ -661,7 +661,7 @@ namespace basegfx
 B2DPoint aLeftEnd(aLeft.getEnd());
 B2DPoint aRightEnd(aRight.getEnd());
 
-// check if end points are on the same line. If yes, no 
adaption
+// check if end points are on the same line. If yes, no 
adaptation
 // needs to be prepared. Also remember which one actually 
is longer.
 const bool bEndOnSameLine(fTools::equal(aLeftEnd.getY(), 
aRightEnd.getY()));
 bool bLeftIsLonger(false);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 121700] Can’t choose paragraph or character language from task bar

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121700

Joel Madero  changed:

   What|Removed |Added

 CC||jmadero@gmail.com

--- Comment #3 from Joel Madero  ---
Cathy - you sure this started with 6 at all? is this a regression from 5.x? If
you could check, that would be great:

https://downloadarchive.documentfoundation.org/libreoffice/old/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121699] Lots of menu buttons and icons are greyed out and Calc file window cannot be closed

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121699

Joel Madero  changed:

   What|Removed |Added

   Priority|medium  |low
 Status|UNCONFIRMED |NEW
 OS|Windows (All)   |All
 Ever confirmed|0   |1
 CC||jmadero@gmail.com
   Severity|normal  |minor

--- Comment #1 from Joel Madero  ---
Linux Mint 19
Version: 6.3.0.0.alpha0+
Build ID: cf6b3bece7d46878302075329c72c7541c65bbd0
CPU threads: 2; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

So I can confirm the behavior. More interesting is that once the conditions
dialog is closed, options are no longer grayed out on the first sheet (the one
where the conditions dialog was opened) but are still grayed out on the second.

That being said, minor issue, doesn't prevent high quality work. Adjusting
priority/severity.

@Ahiijny - if you have time to test against 3.3 that would help us identify
whether this is a regression or whether it's always been this way.
https://downloadarchive.documentfoundation.org/libreoffice/old/3.3.0.4/

If you can confirm same behavior on 3.3 then please update version to
"inherited from OOo", if it's not in 3.3 then let's throw "regression" into the
keywords. If it's a regression and you care to help narrow the issue, please
jump into our chat and we'll help you with the steps to narrow down the problem
(no programming or super IT skills needed).

irc.documentfoundation.org/?settings=#libreoffice-qa

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: connectivity/qa connectivity/source

2018-11-24 Thread Libreoffice Gerrit user
 connectivity/qa/connectivity/mysql/mysql.cxx|   11 +--
 connectivity/source/drivers/mysqlc/mysqlc_resultset.cxx |8 +++-
 2 files changed, 16 insertions(+), 3 deletions(-)

New commits:
commit 878c36f829fd88cda95ca218a2cf03003f50e53d
Author: Tamas Bunth 
AuthorDate: Fri Nov 23 18:31:37 2018 +0100
Commit: Tamás Bunth 
CommitDate: Sat Nov 24 23:15:51 2018 +0100

mysqlc: next() should move cursor from Last

XResultSet::next() should move cursor when called while cursor is on the
last position. It is not documented, but older versions of the mysqlc
extension are implemented that way. The cursor goes to the so called
afterlast position.

Even so, the next() call on the last position should return false.

Change-Id: I0fd145c920077151364a6a8c12e05290496b99c8
Reviewed-on: https://gerrit.libreoffice.org/63895
Tested-by: Jenkins
Reviewed-by: Tamás Bunth 

diff --git a/connectivity/qa/connectivity/mysql/mysql.cxx 
b/connectivity/qa/connectivity/mysql/mysql.cxx
index 44488848b5d6..16172439df0f 100644
--- a/connectivity/qa/connectivity/mysql/mysql.cxx
+++ b/connectivity/qa/connectivity/mysql/mysql.cxx
@@ -173,9 +173,16 @@ void MysqlTestDriver::testIntegerInsertAndQuery()
 CPPUNIT_ASSERT_MESSAGE("not enough result after query", hasRow);
 CPPUNIT_ASSERT_EQUAL(i, xRow->getLong(1)); // first and only column
 }
-bool hasRow = xResultSet->next();
-// no more rows
+CPPUNIT_ASSERT_MESSAGE("Cursor is not on last position.",
+   xResultSet->isLast()); // cursor is on last position
+CPPUNIT_ASSERT_EQUAL(ROW_COUNT, xResultSet->getRow()); // which is the 
last position
+
+bool hasRow = xResultSet->next(); // go to afterlast
+// no more rows, next should return false
 CPPUNIT_ASSERT_MESSAGE("next returns true after last row", !hasRow);
+// cursor should be in afterlast position
+CPPUNIT_ASSERT_EQUAL(ROW_COUNT + 1, xResultSet->getRow());
+CPPUNIT_ASSERT_MESSAGE("Cursor is not on after-last position.", 
xResultSet->isAfterLast());
 
 nUpdateCount = xStatement->executeUpdate("DROP TABLE myTestTable");
 CPPUNIT_ASSERT_EQUAL(0, nUpdateCount); // it's a DDL statement
diff --git a/connectivity/source/drivers/mysqlc/mysqlc_resultset.cxx 
b/connectivity/source/drivers/mysqlc/mysqlc_resultset.cxx
index f0f83e42c3a7..5ee7aa943206 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_resultset.cxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_resultset.cxx
@@ -691,8 +691,14 @@ sal_Bool SAL_CALL OResultSet::next()
 MutexGuard aGuard(m_aMutex);
 checkDisposed(OResultSet_BASE::rBHelper.bDisposed);
 ensureResultFetched();
-if (m_nRowPosition + 1 >= m_nRowCount)
+if (m_nRowPosition + 1 > m_nRowCount) // afterlast
 return false;
+if (m_nRowPosition + 1 == m_nRowCount) // last
+{
+// return false but take it to afterlast anyway
+++m_nRowPosition;
+return false;
+}
 ++m_nRowPosition;
 return true;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: connectivity/Module_connectivity.mk postprocess/CustomTarget_registry.mk postprocess/Rdb_services.mk Repository.mk

2018-11-24 Thread Libreoffice Gerrit user
 Repository.mk|2 +-
 connectivity/Module_connectivity.mk  |4 ++--
 postprocess/CustomTarget_registry.mk |   10 +-
 postprocess/Rdb_services.mk  |2 +-
 4 files changed, 9 insertions(+), 9 deletions(-)

New commits:
commit da16857fe39ab94f5584ef62b1cd59686f98a5ef
Author: Tamas Bunth 
AuthorDate: Fri Nov 23 17:49:54 2018 +0100
Commit: Tamás Bunth 
CommitDate: Sat Nov 24 23:15:34 2018 +0100

Build mysql_jdbc library even when building..

.. without java

Change-Id: Id44ef2d94992423a12b32234822e8ed3f5a48299
Reviewed-on: https://gerrit.libreoffice.org/63889
Tested-by: Jenkins
Reviewed-by: Tamás Bunth 

diff --git a/Repository.mk b/Repository.mk
index d23d93aaa9f5..12a104dd0eab 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -404,7 +404,7 @@ $(eval $(call 
gb_Helper_register_libraries_for_install,OOOLIBS,ooo, \
msfilter \
$(call gb_Helper_optional,SCRIPTING,msforms) \
mtfrenderer \
-   $(if $(ENABLE_JAVA),mysql_jdbc) \
+   $(call gb_Helper_optional,DBCONNECTIVITY,mysql_jdbc) \
$(call gb_Helper_optional,DBCONNECTIVITY,mysqlc) \
numbertext \
odbc \
diff --git a/connectivity/Module_connectivity.mk 
b/connectivity/Module_connectivity.mk
index 4d2596c4602e..a604345a4735 100644
--- a/connectivity/Module_connectivity.mk
+++ b/connectivity/Module_connectivity.mk
@@ -20,6 +20,7 @@ $(eval $(call gb_Module_add_targets,connectivity,\
Configuration_calc \
Configuration_dbase \
Configuration_flat \
+   Configuration_mysql_jdbc \
Configuration_odbc \
Configuration_writer \
Library_calc \
@@ -28,6 +29,7 @@ $(eval $(call gb_Module_add_targets,connectivity,\
Library_file \
Library_flat \
$(if $(filter ANDROID iOS,$(OS)),,Library_odbc) \
+   Library_mysql_jdbc \
Library_sdbc2 \
Library_writer \
 ))
@@ -40,8 +42,6 @@ ifneq ($(ENABLE_JAVA),)
 $(eval $(call gb_Module_add_targets,connectivity,\
Configuration_hsqldb \
Configuration_jdbc \
-   Configuration_mysql_jdbc \
-   Library_mysql_jdbc \
Jar_sdbc_hsqldb \
Library_hsqldb \
Library_jdbc \
diff --git a/postprocess/CustomTarget_registry.mk 
b/postprocess/CustomTarget_registry.mk
index d1583f2f81f5..e84c35eec7e5 100644
--- a/postprocess/CustomTarget_registry.mk
+++ b/postprocess/CustomTarget_registry.mk
@@ -331,9 +331,8 @@ endif
 ifeq ($(ENABLE_JAVA),TRUE)
 postprocess_FILES_main += \
$(call 
gb_XcuModuleTarget_get_target,connectivity/registry/hsqldb)/org/openoffice/Office/DataAccess/Drivers-hsqldb.xcu
 \
-   $(call 
gb_XcuModuleTarget_get_target,connectivity/registry/jdbc)/org/openoffice/Office/DataAccess/Drivers-jdbc.xcu
 \
-   $(call 
gb_XcuModuleTarget_get_target,connectivity/registry/mysql_jdbc)/org/openoffice/Office/DataAccess/Drivers-mysql_jdbc.xcu
-postprocess_DRIVERS += hsqldb jdbc mysql_jdbc
+   $(call 
gb_XcuModuleTarget_get_target,connectivity/registry/jdbc)/org/openoffice/Office/DataAccess/Drivers-jdbc.xcu
+postprocess_DRIVERS += hsqldb jdbc
 endif
 ifeq ($(ENABLE_FIREBIRD_SDBC),TRUE)
 postprocess_FILES_main += \
@@ -428,8 +427,9 @@ postprocess_FILES_writer := \
 
 ifeq (DBCONNECTIVITY,$(filter DBCONNECTIVITY,$(BUILD_TYPE)))
 postprocess_FILES_writer += \
-   $(call 
gb_XcuModuleTarget_get_target,connectivity/registry/writer)/org/openoffice/Office/DataAccess/Drivers-writer.xcu
-postprocess_DRIVERS += writer
+   $(call 
gb_XcuModuleTarget_get_target,connectivity/registry/writer)/org/openoffice/Office/DataAccess/Drivers-writer.xcu
 \
+   $(call 
gb_XcuModuleTarget_get_target,connectivity/registry/mysql_jdbc)/org/openoffice/Office/DataAccess/Drivers-mysql_jdbc.xcu
+postprocess_DRIVERS += writer mysql_jdbc
 endif
 
 postprocess_DEPS_xsltfilter := main
diff --git a/postprocess/Rdb_services.mk b/postprocess/Rdb_services.mk
index 7834751c660c..e189b433e4b0 100644
--- a/postprocess/Rdb_services.mk
+++ b/postprocess/Rdb_services.mk
@@ -261,8 +261,8 @@ $(eval $(call gb_Rdb_add_components,services,\
$(if $(ENABLE_JAVA), \
connectivity/source/drivers/hsqldb/hsqldb \
connectivity/source/drivers/jdbc/jdbc \
-   connectivity/source/drivers/mysql_jdbc/mysql_jdbc \
) \
+   connectivity/source/drivers/mysql_jdbc/mysql_jdbc \
connectivity/source/manager/sdbc2 \
connectivity/source/drivers/writer/writer \
dbaccess/source/ext/macromigration/dbmm \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 121683] Formatting: Some wrong colors in Standard palette

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121683

--- Comment #6 from V Stuart Foote  ---
Created attachment 147012
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147012=edit
screen clip of the adjusted SOC with 70% tint and shade

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121683] Formatting: Some wrong colors in Standard palette

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121683

V Stuart Foote  changed:

   What|Removed |Added

 Attachment #147011|ODF Writer page with table  |ODF Writer page with table
description|cells showing Light 4 and   |cells showing SOC modified
   |Dark 4 at 70.5%soc  |with Light 4 and Dark 4 at
   ||70.5%

--- Comment #5 from V Stuart Foote  ---
Comment on attachment 147011
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147011
ODF Writer page with table cells showing SOC modified with Light 4 and Dark 4
at 70.5%

clarified description

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121683] Formatting: Some wrong colors in Standard palette

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121683

--- Comment #4 from V Stuart Foote  ---
Created attachment 147011
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147011=edit
ODF Writer page with table cells showing Light 4 and Dark 4 at 70.5%soc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121700] Can’t choose paragraph or character language from task bar

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121700

Cathy Crumbley  changed:

   What|Removed |Added

 CC||catbil...@gmail.com

--- Comment #2 from Cathy Crumbley  ---
Created attachment 147010
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147010=edit
Window that appears when click "More"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121700] Can’t choose paragraph or character language from task bar

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121700

--- Comment #1 from Cathy Crumbley  ---
Second window that appears.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121683] Formatting: Some wrong colors in Standard palette

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121683

--- Comment #3 from V Stuart Foote  ---
Created attachment 147009
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147009=edit
current RYB standard.soc with Light 4 and Dark 4 levels adjusted to 70.5% tint
or shade

(In reply to Cathy Crumbley from comment #2)
> ...
> However, as a regular user, it just seems baffling and frustrating that the
> standard palette colors vary so much from their names and that so many
> colors are dark brown or dark gray.  I would imagine that the standard
> palette is the only palette that many users, if not most, use. They will
> find that the beautiful graphics and styles they have created now show
> completely different colors. I will not be the only one who thinks there is
> a bug.
> 

Colors are not held inside ODF document by name, rather by RGB triplet. So this
does not affect any existing document or template. So while bringing a more
flexible color palette selection and management mechanism to
LibreOffice--reworking the color dialog--we simplified the standard palette to
be derived from a RYB named color wheel as preferred by artists and graphics
designers.

For modern technical design we provide the specialized RGB Tonal palette, and
the CIE Lab process color palette for CMYK printing. Adopting a RYB for
standard layout--rather than a HSV/HSL derived palette--presents traditional
color wheel used in Design and Art education.

I've attached an alternative RYB palette--with 70.5% tint, and 70.5% shade
where the RYB hues are more obviously rendered, and a sample document showing
that RYB chart at those levels.

To see if reducing the tint and shade is appealing, simply add the
"vsf_70pt5_standard.soc" to the LO installations: share -> palette folder, and
select the palette for use rather than standard.soc when choosing a defined
palette to work with.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121700] New: Can’t choose paragraph or character language from task bar

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121700

Bug ID: 121700
   Summary: Can’t choose paragraph or character language from task
bar
   Product: LibreOffice
   Version: 6.2.0.0.alpha0+
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: catbil...@gmail.com

Created attachment 147008
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147008=edit
first window that appears when click Language in status bar

The tooltip for the language area of the status bar says “Text language.
Right-click to set character or paragraph language.”

However, in Calc and Impress, right clicking (or left clicking for that matter)
in the language area of the status bar opens a window with the options English,
None, Reset, and More. 

Clicking More opens the same window as the window located at Options > Language
Settings > Languages.

Neither window contains options for setting the language for paragraph or
character.

What I expected: a window with a link to a window for setting the paragraph
language and another link to a window for setting the character language.  This
is similar to what happens in Writer. In Writer, however, three windows need to
be opened before the option appears for setting the character language.

I don't know which version of 6 this started with.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: loleaflet/src

2018-11-24 Thread Libreoffice Gerrit user
 loleaflet/src/layer/tile/TileLayer.js |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d34f0d5b7fab9b394f95aa047729b2924cfbd6bd
Author: Michael Meeks 
AuthorDate: Fri Nov 23 12:47:33 2018 +
Commit: Michael Meeks 
CommitDate: Sat Nov 24 21:22:46 2018 +

Show cursor, even with a selected graphic / shape.

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 2a179ecec..ff078ce15 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -1629,7 +1629,7 @@ L.TileLayer = L.GridLayer.extend({
&& this._isCursorVisible// only when LOK has told us it 
is ok
&& this._isFocused  // not when document is not 
focused
&& !this._isZooming // not when zooming
-   && !this.isGraphicVisible() // not when sizing / 
positioning graphics
+// && !this.isGraphicVisible() // not when sizing / 
positioning graphics
&& !this._isEmptyRectangle(this._visibleCursor)) {
this._updateCursorPos();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/source

2018-11-24 Thread Libreoffice Gerrit user
 sw/source/core/unocore/unocoll.cxx |   13 +
 1 file changed, 5 insertions(+), 8 deletions(-)

New commits:
commit 796cbe6efcf0e7dcd9985bad0a8539a8952932f2
Author: Julien Nabet 
AuthorDate: Sat Nov 24 13:37:54 2018 +0100
Commit: Julien Nabet 
CommitDate: Sat Nov 24 21:55:09 2018 +0100

Replace list by vector in unocoll.cxx (sw)

Same logic as https://gerrit.libreoffice.org/#/c/63928/

Change-Id: I59d5329687f94dcf0dba53a428f580313467829c
Reviewed-on: https://gerrit.libreoffice.org/63939
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/sw/source/core/unocore/unocoll.cxx 
b/sw/source/core/unocore/unocoll.cxx
index 8bc20f1ed03d..d12bb74f5f8e 100644
--- a/sw/source/core/unocore/unocoll.cxx
+++ b/sw/source/core/unocore/unocoll.cxx
@@ -61,7 +61,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -1057,8 +1056,7 @@ namespace
 : public SwSimpleEnumeration_Base
 {
 private:
-typedef std::list< Any > frmcontainer_t;
-frmcontainer_t m_aFrames;
+std::vector< Any > m_aFrames;
 protected:
 virtual ~SwXFrameEnumeration() override {};
 public:
@@ -1085,10 +1083,8 @@ SwXFrameEnumeration::SwXFrameEnumeration(const SwDoc* 
const pDoc)
 return;
 // #i104937#
 const size_t nSize = pFormats->size();
-std::insert_iterator pInserter = 
std::insert_iterator(m_aFrames, m_aFrames.begin());
 // #i104937#
 SwFrameFormat* pFormat( nullptr );
-
 for( size_t i = 0; i < nSize; ++i )
 {
 // #i104937#
@@ -1100,7 +1096,7 @@ SwXFrameEnumeration::SwXFrameEnumeration(const SwDoc* 
const pDoc)
 continue;
 const SwNode* pNd = pDoc->GetNodes()[ pIdx->GetIndex() + 1 ];
 if(UnoFrameWrap_traits::filter(pNd))
-*pInserter++ = lcl_UnoWrapFrame(pFormat);
+m_aFrames.push_back(lcl_UnoWrapFrame(pFormat));
 }
 }
 
@@ -1117,8 +1113,9 @@ Any SwXFrameEnumeration::nextElement()
 SolarMutexGuard aGuard;
 if(m_aFrames.empty())
 throw NoSuchElementException();
-Any aResult = *m_aFrames.begin();
-m_aFrames.pop_front();
+
+Any aResult = m_aFrames.back();
+m_aFrames.pop_back();
 return aResult;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 121691] line callout doesn't draw in writer document

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121691

--- Comment #5 from Regina Henschel  ---
TOC = Table of Contents

Removing and newly inserting the table of content does not solve the problem
for this document. I have tried that already. But because I could not reproduce
the problem with a new document, it might help, if you make a new document and
transfer the content from the old document into it. First load the styles from
the old document, then copy and paste the content. If that does not solve the
problem, try it without preserving the styles.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: package/source

2018-11-24 Thread Libreoffice Gerrit user
 package/source/xstor/ohierarchyholder.cxx |   11 ---
 1 file changed, 8 insertions(+), 3 deletions(-)

New commits:
commit 487ed7fdd6ea9687336112afcd80e7e8d723b8fc
Author: Julien Nabet 
AuthorDate: Sat Nov 24 18:54:39 2018 +0100
Commit: Julien Nabet 
CommitDate: Sat Nov 24 21:37:24 2018 +0100

Use returned iterator by list::erase

Change-Id: I42312f5cbd0de65cc8915e6833eff668d244f66b
Reviewed-on: https://gerrit.libreoffice.org/63956
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/package/source/xstor/ohierarchyholder.cxx 
b/package/source/xstor/ohierarchyholder.cxx
index 5f6cf2291b54..800cfdf7ce1f 100644
--- a/package/source/xstor/ohierarchyholder.cxx
+++ b/package/source/xstor/ohierarchyholder.cxx
@@ -267,9 +267,14 @@ void SAL_CALL OHierarchyElement_Impl::disposing( const 
lang::EventObject& Source
 for ( OWeakStorRefList_Impl::iterator pStorageIter = 
m_aOpenStreams.begin();
   pStorageIter != m_aOpenStreams.end(); )
 {
-OWeakStorRefList_Impl::iterator pTmp = pStorageIter++;
-if ( !pTmp->get().is() || pTmp->get() == xStream )
-m_aOpenStreams.erase( pTmp );
+if ( !pStorageIter->get().is() || pStorageIter->get() == xStream )
+{
+pStorageIter = m_aOpenStreams.erase(pStorageIter);
+}
+else
+{
+++pStorageIter;
+}
 }
 
 aGuard.clear();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: compilerplugins/clang sc/inc sc/source

2018-11-24 Thread Libreoffice Gerrit user
 compilerplugins/clang/unusedenumconstants.readonly.results |2 --
 sc/inc/types.hxx   |1 -
 sc/source/core/data/bcaslot.cxx|4 
 3 files changed, 7 deletions(-)

New commits:
commit 843c55d132a1889ffbdfe230a48bb6dfae7d62a3
Author: Noel Grandin 
AuthorDate: Thu Nov 22 16:08:47 2018 +0200
Commit: Noel Grandin 
CommitDate: Sat Nov 24 21:24:11 2018 +0100

remove unused sc::ListenerGroupType::Single

Change-Id: I98a279731b22f88f57ab667b6f5ef8c71b030832
Reviewed-on: https://gerrit.libreoffice.org/63945
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/unusedenumconstants.readonly.results 
b/compilerplugins/clang/unusedenumconstants.readonly.results
index 139c7cc8932d..13c2670990e9 100644
--- a/compilerplugins/clang/unusedenumconstants.readonly.results
+++ b/compilerplugins/clang/unusedenumconstants.readonly.results
@@ -1170,8 +1170,6 @@ sc/inc/types.hxx:38
 enum ScMatValType NonvalueMask
 sc/inc/types.hxx:56
 enum ScFormulaVectorState FormulaVectorDisabledNotInSoftwareSubset
-sc/inc/types.hxx:123
-enum sc::ListenerGroupType Single
 sc/source/filter/lotus/lotread.cxx:41
 enum STATE S_WK1
 sc/source/ui/inc/viewdata.hxx:43
diff --git a/sc/inc/types.hxx b/sc/inc/types.hxx
index 51898c291fde..995f715c37c3 100644
--- a/sc/inc/types.hxx
+++ b/sc/inc/types.hxx
@@ -120,7 +120,6 @@ enum AreaOverlapType
 
 enum class ListenerGroupType
 {
-Single,
 Group,
 Both
 };
diff --git a/sc/source/core/data/bcaslot.cxx b/sc/source/core/data/bcaslot.cxx
index f607d20fc80e..f63e116cc083 100644
--- a/sc/source/core/data/bcaslot.cxx
+++ b/sc/source/core/data/bcaslot.cxx
@@ -517,10 +517,6 @@ void ScBroadcastAreaSlot::GetAllListeners(
 const ScRange& rAreaRange = pArea->GetRange();
 switch (eGroup)
 {
-case sc::ListenerGroupType::Single:
-if (pArea->IsGroupListening())
-continue;
-break;
 case sc::ListenerGroupType::Group:
 if (!pArea->IsGroupListening())
 continue;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: compilerplugins/clang sc/source

2018-11-24 Thread Libreoffice Gerrit user
 compilerplugins/clang/unusedenumconstants.readonly.results |4 -
 sc/source/filter/inc/unitconverter.hxx |   26 -
 sc/source/filter/oox/drawingbase.cxx   |4 -
 sc/source/filter/oox/drawingfragment.cxx   |2 
 sc/source/filter/oox/pagesettings.cxx  |   12 ++--
 sc/source/filter/oox/stylesbuffer.cxx  |2 
 sc/source/filter/oox/unitconverter.cxx |   35 -
 sc/source/filter/oox/worksheethelper.cxx   |6 +-
 8 files changed, 38 insertions(+), 53 deletions(-)

New commits:
commit 61d21e79e681753599b395f224ed48172e808bc4
Author: Noel Grandin 
AuthorDate: Thu Nov 22 15:47:57 2018 +0200
Commit: Noel Grandin 
CommitDate: Sat Nov 24 21:23:54 2018 +0100

convert Unit to scoped enum

and drop unused UNIT_REFDEVX,UNIT_REFDEVY values

Change-Id: I4e516f2c51672f6541f3cf7c03a87aebc4a1f1f6
Reviewed-on: https://gerrit.libreoffice.org/63944
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/unusedenumconstants.readonly.results 
b/compilerplugins/clang/unusedenumconstants.readonly.results
index 88093da091b3..139c7cc8932d 100644
--- a/compilerplugins/clang/unusedenumconstants.readonly.results
+++ b/compilerplugins/clang/unusedenumconstants.readonly.results
@@ -1172,10 +1172,6 @@ sc/inc/types.hxx:56
 enum ScFormulaVectorState FormulaVectorDisabledNotInSoftwareSubset
 sc/inc/types.hxx:123
 enum sc::ListenerGroupType Single
-sc/source/filter/inc/unitconverter.hxx:43
-enum oox::xls::Unit UNIT_REFDEVX
-sc/source/filter/inc/unitconverter.hxx:44
-enum oox::xls::Unit UNIT_REFDEVY
 sc/source/filter/lotus/lotread.cxx:41
 enum STATE S_WK1
 sc/source/ui/inc/viewdata.hxx:43
diff --git a/sc/source/filter/inc/unitconverter.hxx 
b/sc/source/filter/inc/unitconverter.hxx
index 87d19577bec8..ec22a34a19de 100644
--- a/sc/source/filter/inc/unitconverter.hxx
+++ b/sc/source/filter/inc/unitconverter.hxx
@@ -22,6 +22,7 @@
 
 #include 
 #include 
+#include 
 #include "workbookhelper.hxx"
 
 namespace com { namespace sun { namespace star {
@@ -32,20 +33,17 @@ namespace oox {
 namespace xls {
 
 /** Units supported by the UnitConverter class. */
-enum Unit
+enum class Unit
 {
-UNIT_INCH,  /// Inches.
-UNIT_POINT, /// Points.
-UNIT_TWIP,  /// Twips (1/20 point).
-UNIT_EMU,   /// English Metric Unit (1/360,000 cm).
-UNIT_SCREENX,   /// Horizontal screen pixels.
-UNIT_SCREENY,   /// Vertical screen pixels.
-UNIT_REFDEVX,   /// Horizontal pixels in Calc reference device.
-UNIT_REFDEVY,   /// Vertical pixels in Calc reference device.
-UNIT_DIGIT, /// Digit width of document default font.
-UNIT_SPACE, /// Space character width of document default font.
-
-UNIT_ENUM_SIZE
+Inch,  /// Inches.
+Point, /// Points.
+Twip,  /// Twips (1/20 point).
+Emu,   /// English Metric Unit (1/360,000 cm).
+ScreenX,   /// Horizontal screen pixels.
+ScreenY,   /// Vertical screen pixels.
+Digit, /// Digit width of document default font.
+Space, /// Space character width of document default font.
+LAST
 };
 
 /** Helper class that provides functions to convert values from and to
@@ -97,7 +95,7 @@ private:
 voidaddErrorCode( sal_uInt8 nErrorCode, const OUString& 
rErrorCode );
 
 private:
-std::vector maCoeffs;   /// Coefficients for unit 
conversion.
+o3tl::enumarray maCoeffs;   /// Coefficients for 
unit conversion.
 std::map maOoxErrCodes;  /// Maps error code 
strings to BIFF error constants.
 sal_Int32   mnNullDate; /// Nulldate of this workbook 
(number of days since -01-01).
 };
diff --git a/sc/source/filter/oox/drawingbase.cxx 
b/sc/source/filter/oox/drawingbase.cxx
index 92723180ffd7..9b6e0aba70b1 100644
--- a/sc/source/filter/oox/drawingbase.cxx
+++ b/sc/source/filter/oox/drawingbase.cxx
@@ -278,8 +278,8 @@ EmuPoint ShapeAnchor::calcCellAnchorEmu( const 
CellAnchorModel& rModel ) const
 case CellAnchorType::Pixel:
 {
 const UnitConverter& rUnitConv = getUnitConverter();
-aEmuPoint.X += static_cast< sal_Int64 >( rUnitConv.scaleValue( 
static_cast< double >( rModel.mnColOffset ), UNIT_SCREENX, UNIT_EMU ) );
-aEmuPoint.Y += static_cast< sal_Int64 >( rUnitConv.scaleValue( 
static_cast< double >( rModel.mnRowOffset ), UNIT_SCREENY, UNIT_EMU ) );
+aEmuPoint.X += static_cast< sal_Int64 >( rUnitConv.scaleValue( 
static_cast< double >( rModel.mnColOffset ), Unit::ScreenX, Unit::Emu ) );
+aEmuPoint.Y += static_cast< sal_Int64 >( rUnitConv.scaleValue( 
static_cast< double >( rModel.mnRowOffset ), Unit::ScreenY, Unit::Emu ) );
 }
 break;
 }
diff --git 

[Libreoffice-bugs] [Bug 121695] comments: after editing Position and Size, arrow points to cell A1

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121695

Xavier Van Wijmeersch  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 OS|Windows (All)   |All

--- Comment #1 from Xavier Van Wijmeersch  ---
can also reproduce under linux with

Version: 6.3.0.0.alpha0+
Build ID: 82cc30a832dde298832d9f029e0ead94a9d2d14b
CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); UI-Language: en-US
Calc: threaded

Version: 6.3.0.0.alpha0+
Build ID: d112ffd5f101a8533c48b2ce250951d8a1332252
CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: nl-BE (en_US.UTF-8); UI-Language: en-US
Calc: threaded

Version: 6.2.0.0.beta1+
Build ID: 19805f580fcbcf890790f8c6ab736aab80c08de7
CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); UI-Language: en-US
Calc: threaded

Version: 6.1.4.0.0+
Build ID: b3af23568f9b9b444ae09f2a1ab4a61d212b422a
CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: kde4; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:libreoffice-6-1, Time:
2018-11-23_09:38:29
Locale: nl-BE (en_US.UTF-8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120493] New feature Calc / write

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120493

ejj_samyn_...@yahoo.com changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120493] New feature Calc / write

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120493

--- Comment #2 from ejj_samyn_...@yahoo.com ---
(In reply to Jean-Baptiste Faure from comment #1)
> Did you try to embed a Calc file in a text document? 
> 
> Status set to NEEDINFO, please set it back to UNCONFIRMED once requested
> informations are provided.
> 
> Best regards. JBF

Yes, but it would be much easier to work with a single file with both
properties. To embed calc in write is nice when you just want a table or a
graph, but not very practical when you want a real spreadsheet tool with some
textual sheet to add formated text to complete your doc (for example if you
want to add a textual introduction, a user guide for your spreadsheet with
title levels, paragraphs,.., a contextual description, ...)

Hope this is clearer

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121691] line callout doesn't draw in writer document

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121691

--- Comment #4 from roumanet  ---
(In reply to Regina Henschel from comment #3)
> I can reproduce the problem with your document in Version: 6.3.0.0.alpha0+
> (x64)
> Build ID: 9e55c8c7ffc43004ca314edcd4712dcc29adf933
> CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; 
> Locale: de-DE (en_US); UI-Language: en-US
> Calc: threaded
> 
> I cannot produce the problem with a new document.
> 
> It seems to be somehow connected to the TOC. If I delete the TOC, the leg of
> the callout is visible, if I insert the TOC again, the leg of the callout
> vanishes.

What is the TOC ? could I delete it without datas lost ? thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121698] Saving a document with thousands of comments hangs (GTK3)

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121698

Xavier Van Wijmeersch  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Xavier Van Wijmeersch  ---
confirm with

Version: 6.3.0.0.alpha0+
Build ID: d112ffd5f101a8533c48b2ce250951d8a1332252
CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: nl-BE (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121699] New: Lots of menu buttons and icons are greyed out and Calc file window cannot be closed

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121699

Bug ID: 121699
   Summary: Lots of menu buttons and icons are greyed out and Calc
file window cannot be closed
   Product: LibreOffice
   Version: 6.1.2.1 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ahii...@gmail.com

Description:
Version: 6.1.2.1 (x64)
Build ID: 65905a128db06ba48db947242809d14d3f9a93fe
CPU threads: 8; OS: Windows 10.0; UI render: default; 
Locale: en-CA (en_CA); Calc: CL

I came across this bug when I was playing around with conditional formatting in
one Calc file, and then got sidetracked and opened another Calc file while the
conditional formatting dialog in the first file was still open.

This second Calc file seems to be stuck in some sort of super limited mode: All
of the icons in the toolbars are greyed out, and most main menu buttons are
greyed out, including "File > Exit" and "File > Save", but not "File > New". I
can select cells and type text, but when I hit enter, the words just disappear
and the cell becomes blank. 

The second Calc file window remains stuck in this state even after I close the
conditional formatting dialog in the first file window. The strangest thing
about this state is that it is not possible to close the window. The first Calc
file window is unaffected; I could close that normally without any issues. But
for the second Calc file window, Alt + F4 and clicking the X in the top-right
corner had no effect. The only thing that worked was killing the process
through Task Manager.

Steps to Reproduce:
1. Open a spreadsheet file in Calc.
2. Open Format > Conditional > Condition...
3. Open another spreadsheet file, either by clicking File > New > Spreadsheet
or by double-clicking another spreadsheet file in explorer (it's the same
either way).

Actual Results:
The file that opens will not be closeable, and most of icons and menu buttons
will be greyed out.

Expected Results:
The file window should open in a normal clickable state.


Reproducible: Always


User Profile Reset: Yes



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121696] [EDITING] Usage of "Inequality" criteria in function SUMIF creates wrong result

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121696

Oliver Brinzing  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=73
   ||081

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121696] [EDITING] Usage of "Inequality" criteria in function SUMIF creates wrong result

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121696

Oliver Brinzing  changed:

   What|Removed |Added

   Keywords||bibisected,
   ||bibisectRequest, bisected

--- Comment #5 from Oliver Brinzing  ---
code changed with:

Resolves: tdf#73081 *) empty <> not-empty is also a match if numeric
This simplifies to match empty for the same conditions whether
numeric or not, an empty string does not result in numeric 0 here.

https://gerrit.libreoffice.org/plugins/gitiles/core/+/88f10aed35c19cc43a88bbcd12b026cb32c0003f

*) tdf#73081
COUNTIF with criterium <>number does not count empty cells.
https://bugs.documentfoundation.org/show_bug.cgi?id=73081

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121689] Copy cells with condition to external programs (Word/Moodle) doesnt work properly

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121689

--- Comment #6 from Eduardo  ---
Also making some tests, i noticed than in writer the paste default option is to
paste as libreoffice calc object, but in word, excel and moodle is html.. So i
guess the problem is special paste in html.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121689] Copy cells with condition to external programs (Word/Moodle) doesnt work properly

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121689

--- Comment #5 from Eduardo  ---
https://drive.google.com/drive/folders/1n6RGj110ZMEYQ3057m71a8lmgiXhDl5U?usp=sharing

I have added a example which im currently working...the first column is the
name of pupil the second the maximum of that question, i put a different color
if the mark is less than zero or more than the maximum mark fot that
question...As all the numbers are correct, calc shows it ok, writer also, but
importing to excel, word and moodle ( at least) the appear the orange
background ( the color assigned to cells that are failing the conditions.

I can also send a mail or upload to that folder in google drive if you want to
take a look.

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121696] [EDITING] Usage of "Inequality" criteria in function SUMIF creates wrong result

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121696

--- Comment #4 from Oliver Brinzing  ---
Created attachment 147007
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147007=edit
example excel 2016

result with excel 2016 is 63

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 77125] Please make the shape of rounded rectangle callout customizable

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=77125

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #5 from Regina Henschel  ---
For totally new shapes you need no knowledge in C++. You only need the ODF
specification to define such shape. New kind of shapes can be added to the
Gallery.

The shape in question should fit to the predefined custom shape
"wedgeRoundRectCallout" of OOXML, but it doesn't. That should be changed in
core, without introducing new handles.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120883] [META] Hyphenation bugs and enhancements

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120883

raal  changed:

   What|Removed |Added

 Depends on||121657


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121657
[Bug 121657] FILEOPEN DOCX Automatic Hyphenate created with Word disappears
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121657] FILEOPEN DOCX Automatic Hyphenate created with Word disappears

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121657

raal  changed:

   What|Removed |Added

Version|6.2.0.0.alpha1+ |4.1.0.4 release
 Blocks||120883
 Ever confirmed|0   |1
 CC||r...@post.cz
 Status|UNCONFIRMED |NEW

--- Comment #3 from raal  ---
Confirm with Version: 6.2.0.0.beta1+
Build ID: 268364e35100b559f42d8c02b930c5cca1c84be7
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
and 4.1


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=120883
[Bug 120883] [META] Hyphenation bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121689] Copy cells with condition to external programs (Word/Moodle) doesnt work properly

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121689

--- Comment #4 from Eduardo  ---
Seems if i copy to writer dont happen...
But in moodle and word happens...
I have reseted profile.
Your example seems to work

The difference perhaps is that i use two conditions: value greater than zero
and value less than D14 ( for example)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121696] [EDITING] Usage of "Inequality" criteria in function SUMIF creates wrong result

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121696

Oliver Brinzing  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||oliver.brinz...@gmx.de
 Ever confirmed|0   |1

--- Comment #3 from Oliver Brinzing  ---
attached file has been saved with lo 6.1.3.2

checked with new userprofiles:

- open attached file with lo 6.0.7.1
- cell C10 shows 63
- ctrl+shift+F9 (calculate all)
- cell C10 shows 13

- open attached file with lo 6.1.3.2
- cell C10 shows 63
- ctrl+shift+F9 (calculate all)
- now cell C10 shows 63

so something has changed

- open attached file with lo 6.0.7.1
- ctrl+shift+F9 (calculate all)
- save and close
- open with lo 6.1.3.2
- cell C10 shows 13
- ctrl+shift+F9 (calculate all)
- now cell C10 shows 63

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121681] Button "Move up" from bullets and numbering's toolbar doesn't work cause a table

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121681

Dieter Praas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||dgp-m...@gmx.de
 Ever confirmed|0   |1

--- Comment #3 from Dieter Praas  ---
Thank you for reporting the bug. Please attach a sample document, as this makes
it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO'.
Please change it back to 'UNCONFIRMED' once the requested document is provided.
(Please note that the attachment will be public, remove any sensitive
information before attaching it)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94591] FILEOPEN: ODT - Custom shapes and ellipses not rendered correctly

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94591

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #9 from Regina Henschel  ---
"width" and "height" are wrong interpreted.

The error is still there in Version: 6.3.0.0.alpha0+ (x64)
Build ID: d71ea82055a6a304493c7eaa90809a348e23784d
CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-11-19_04:56:18
Locale: de-DE (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121688] Problems with cloud services One Drive and Google DRive

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121688

--- Comment #2 from Eduardo  ---
Just two cents:
1 - In ubuntuy 18.04 only appears Google Drive, One drive even not appear in
the list of services. Google drive ask for two authentication, but i dont have
it enabled. In Microsoft office i can acces without problems with user and
password.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120507] Crash if I open the Options dialog and click the 'Languages' under 'Language Settings'

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120507

--- Comment #7 from Atanas  ---
Yes, it still crashes. With this installation it disappears without any delay
right after I click on 'Languages'.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 117896] FILESAVE, EDITING Performance of Calc become very slow after copy sheet

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117896

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #7 from Buovjaga  ---
The copying takes a while, but after it is completed, the scrolling is smooth.

To be crystal clear: step 3 is done after the new sheet has appeared?

Arch Linux 64-bit
Version: 6.3.0.0.alpha0+
Build ID: 51e6a95757906dff8b2819a4141bf3dc7938e95f
CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk3_kde5; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded
Built on 24 November 2018

Version: 6.2.0.0.beta1 (x64)
Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: fi-FI (fi_FI); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121683] Formatting: Some wrong colors in Standard palette

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121683

--- Comment #2 from Cathy Crumbley  ---
I can see that there has been extensive discussion about making the RYB
standard. I don't understand the reasons for this but accept that there are
good reasons.  I also appreciate that there are several trade-offs and
challenges that people have been working diligently to overcome.

However, as a regular user, it just seems baffling and frustrating that the
standard palette colors vary so much from their names and that so many colors
are dark brown or dark gray.  I would imagine that the standard palette is the
only palette that many users, if not most, use. They will find that the
beautiful graphics and styles they have created now show completely different
colors. I will not be the only one who thinks there is a bug.

If there needs to be a RYB palette that looks like this, why can't it be
something other than the default palette?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang sc/source

2018-11-24 Thread Libreoffice Gerrit user
 compilerplugins/clang/unusedenumconstants.readonly.results |4 ---
 sc/source/filter/lotus/lotread.cxx |4 ---
 sc/source/filter/oox/formulabase.cxx   |   13 --
 sc/source/ui/inc/undobase.hxx  |6 
 sc/source/ui/undo/undobase.cxx |   16 +++--
 sc/source/ui/undo/undoblk.cxx  |8 +++---
 sc/source/ui/undo/undotab.cxx  |2 -
 7 files changed, 16 insertions(+), 37 deletions(-)

New commits:
commit f326c3c01c3f2dd1ed244bded68d096cd680ad18
Author: Noel Grandin 
AuthorDate: Thu Nov 22 15:40:22 2018 +0200
Commit: Noel Grandin 
CommitDate: Sat Nov 24 19:05:07 2018 +0100

remove unused FuncFlags::BIFFIMPORTONLY,STATE::S_WK1

Change-Id: I94d88f871bfc78a066f6fd583b7fb7a7305944c8
Reviewed-on: https://gerrit.libreoffice.org/63943
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/unusedenumconstants.readonly.results 
b/compilerplugins/clang/unusedenumconstants.readonly.results
index 0ad6cb92a0c2..88093da091b3 100644
--- a/compilerplugins/clang/unusedenumconstants.readonly.results
+++ b/compilerplugins/clang/unusedenumconstants.readonly.results
@@ -1178,8 +1178,6 @@ sc/source/filter/inc/unitconverter.hxx:44
 enum oox::xls::Unit UNIT_REFDEVY
 sc/source/filter/lotus/lotread.cxx:41
 enum STATE S_WK1
-sc/source/filter/oox/formulabase.cxx:63
-enum FuncFlags BIFFIMPORTONLY
 sc/source/ui/inc/viewdata.hxx:43
 enum ScSplitMode SC_SPLIT_MODE_MAX_ENUM
 sc/source/ui/inc/viewdata.hxx:45
diff --git a/sc/source/filter/lotus/lotread.cxx 
b/sc/source/filter/lotus/lotread.cxx
index 5be4db478cfc..155e265a6f4b 100644
--- a/sc/source/filter/lotus/lotread.cxx
+++ b/sc/source/filter/lotus/lotread.cxx
@@ -38,7 +38,6 @@ ErrCode ImportLotus::parse()
 enum STATE
 {
 S_START,// analyse first BOF
-S_WK1,  // in WK1-Stream
 S_WK3,  // in WK3-Section
 S_WK4,
 S_FM3,
@@ -107,9 +106,6 @@ ErrCode ImportLotus::parse()
 }
 break;
 
-case S_WK1: // S_WK1
-break;
-
 case S_WK3: // S_WK3
 case S_WK4: // S_WK4
 switch( nOp )
diff --git a/sc/source/filter/oox/formulabase.cxx 
b/sc/source/filter/oox/formulabase.cxx
index 4a11eef0ff87..7872a03529d1 100644
--- a/sc/source/filter/oox/formulabase.cxx
+++ b/sc/source/filter/oox/formulabase.cxx
@@ -60,13 +60,12 @@ enum class FuncFlags : sal_uInt16 {
 MACROCALL_NEW = MACROCALL | MACROCALL_FN, /** New Excel functions not
   defined in OOXML, _xlfn. 
prefix in all formats. OOXML name
   must exist. */
-BIFFIMPORTONLY= 0x0800,   /// Only used in BIFF binary import filter.
 BIFFEXPORTONLY= 0x1000,   /// Only used in BIFF binary export filter.
 INTERNAL  = 0x2000,   /// Function is internal in Calc.
 EUROTOOL  = 0x4000,   /// function of euro tool lib, 
FUNCLIB_EUROTOOL
 };
 namespace o3tl {
-template<> struct typed_flags : is_typed_flags {};
+template<> struct typed_flags : is_typed_flags {};
 }
 
 namespace oox {
@@ -191,13 +190,13 @@ struct FunctionData
 bool FunctionData::isSupported(bool bImportFilter) const
 {
 /*  For import filters: the FuncFlags::EXPORTONLY, 
FuncFlags::BIFFEXPORTONLY
-and FuncFlags::BIFFIMPORTONLY flag must not be set.
-For export filters: the FuncFlags::IMPORTONLY, 
FuncFlags::BIFFIMPORTONLY
-and FuncFlags::BIFFEXPORTONLY flag must not be 
set. */
+must not be set.
+For export filters: the FuncFlags::IMPORTONLY, 
FuncFlags::BIFFEXPORTONLY
+must not be set. */
 if (bImportFilter)
-return !(mnFlags & ( FuncFlags::EXPORTONLY | FuncFlags::BIFFEXPORTONLY 
| FuncFlags::BIFFIMPORTONLY));
+return !(mnFlags & ( FuncFlags::EXPORTONLY | 
FuncFlags::BIFFEXPORTONLY));
 else
-return !(mnFlags & ( FuncFlags::IMPORTONLY | FuncFlags::BIFFIMPORTONLY 
| FuncFlags::BIFFEXPORTONLY));
+return !(mnFlags & ( FuncFlags::IMPORTONLY | 
FuncFlags::BIFFEXPORTONLY));
 }
 
 const sal_uInt16 NOID = SAL_MAX_UINT16; /// No BIFF function identifier 
available.
commit 1ab34cdb4a8bf255ba6a0eb96b2a30c7be5e451b
Author: Noel Grandin 
AuthorDate: Thu Nov 22 15:37:23 2018 +0200
Commit: Noel Grandin 
CommitDate: Sat Nov 24 19:04:55 2018 +0100

remove ScMoveUndoMode enum

we only use one value

Change-Id: I7a0f3760615111adcd8b925234f53fafa46a0bd7
Reviewed-on: https://gerrit.libreoffice.org/63942
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git 

[Libreoffice-bugs] [Bug 121696] [EDITING] Usage of "Inequality" criteria in function SUMIF creates wrong result

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121696

--- Comment #2 from Mike Kaganski  ---
And what happens if you put 0 to B5 and B6?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113495] Calc: very slow scrolling - nearly impossible to work with a graphic inside

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113495

Buovjaga  changed:

   What|Removed |Added

   Keywords||haveBacktrace
 OS|Windows (All)   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113495] Calc: very slow scrolling - nearly impossible to work with a graphic inside

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113495

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #10 from Buovjaga  ---
Created attachment 147006
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147006=edit
Callgrind output from master

For me, the delay is slight. Not unworkable by any standards. I took a
callgrind trace nevertheless.

Arch Linux 64-bit
Version: 6.3.0.0.alpha0+
Build ID: 51e6a95757906dff8b2819a4141bf3dc7938e95f
CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk3_kde5; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded
Built on 24 November 2018

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 109335] OpenCL performance degradation

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109335

--- Comment #16 from Roman Kuznetsov <79045_79...@mail.ru> ---
It takes result 

2768 in file "Ground water daily" 
21139 in file "Dates worksheet"

in 

Version: 6.2.0.0.alpha1+ (x64)
Build ID: 20b2903354138f8ab19261fab74658fcf6af70e3
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-11-14_22:57:13
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: CL

And I disabled multi-threaded calculation

still repro

/cache/OpenCL.log

Device Index: 0
  Selected: false
  Device Name: GeForce GTX 1050
  Device Vendor: NVIDIA Corporation
  Device Version: OpenCL 1.2 CUDA
  Driver Version: 397.93
  Device Type: gpu 
  ...
  Device OpenCL C Version: OpenCL C 1.2 
  Device Available: true
  Device Compiler Available: true
  Device Linker Available: true
  Platform Name: NVIDIA CUDA
  Platform Vendor: NVIDIA Corporation
  Platform Version: OpenCL 1.2 CUDA 9.2.127
  Platform Profile: FULL_PROFILE
  ...

Device Index: 1
  Selected: true
  Device Name: Intel(R) HD Graphics 630
  Device Vendor: Intel(R) Corporation
  Device Version: OpenCL 2.1 
  Driver Version: 22.20.16.4708
  Device Type: gpu 
  ... 
  Device OpenCL C Version: OpenCL C 2.0 
  Device Available: true
  Device Compiler Available: true
  Device Linker Available: true
  Platform Name: Intel(R) OpenCL
  Platform Vendor: Intel(R) Corporation
  Platform Version: OpenCL 2.1 
  Platform Profile: FULL_PROFILE
  ...

Device Index: 2
  Selected: false
  Device Name: Intel(R) Core(TM) i5-7300HQ CPU @ 2.50GHz
  Device Vendor: Intel(R) Corporation
  Device Version: OpenCL 2.1 (Build 10)
  Driver Version: 7.2.0.10
  Device Type: cpu 
  ...
  Device OpenCL C Version: OpenCL C 2.0 
  Device Available: true
  Device Compiler Available: true
  Device Linker Available: true
  Platform Name: Intel(R) OpenCL
  Platform Vendor: Intel(R) Corporation
  Platform Version: OpenCL 2.1 
  Platform Profile: FULL_PROFILE
  ...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 76324] CALC becomes very slow with 5000+ comments

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76324

Buovjaga  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 CC||todven...@suomi24.fi

--- Comment #65 from Buovjaga  ---
Let's keep this as fixed where it belongs. New issues should get new reports. I
opened a report for a hang with GTK3: bug 121698

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 101216] [META] Calc comment bugs and enhancements

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101216
Bug 101216 depends on bug 76324, which changed state.

Bug 76324 Summary: CALC becomes very slow with 5000+ comments
https://bugs.documentfoundation.org/show_bug.cgi?id=76324

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121698] New: Saving a document with thousands of comments hangs (GTK3)

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121698

Bug ID: 121698
   Summary: Saving a document with thousands of comments hangs
(GTK3)
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Keywords: bibisectRequest, regression
  Severity: major
  Priority: high
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: todven...@suomi24.fi
Blocks: 103182

Created attachment 147005
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147005=edit
GDB trace of hang with master

1. Open attachment 96007 from bug 76324
2. Save as under some name

It hangs, but only with GTK3. Doesn't hang with 6.1.3

Arch Linux 64-bit
Version: 6.3.0.0.alpha0+
Build ID: 51e6a95757906dff8b2819a4141bf3dc7938e95f
CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded
Built on 24 November 2018


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103182
[Bug 103182] [META] GTK3-specific bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103182

Buovjaga  changed:

   What|Removed |Added

 Depends on||121698


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121698
[Bug 121698] Saving a document with thousands of comments hangs (GTK3)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 96751] EDITING writer hangs when editing an image in a docx file

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96751

--- Comment #11 from doriano@gmail.com ---
The bug is still present in version 6.1.1.2 (x64)
Build ID: 5d19a1bfa650b796764388cd8b33a5af1f5baa1b

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121697] New: [NEWHELP] Extend Help XHP for easier, simpler Help edition

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121697

Bug ID: 121697
   Summary: [NEWHELP] Extend Help XHP for easier, simpler Help
edition
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: olivier.hal...@documentfoundation.org
CC: olivier.hal...@documentfoundation.org

This bug refers to the proposed extension for XHP described in the wiki page 

https://wiki.documentfoundation.org/Documentation/Proposed_Extensions_for_XHP

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 49946] landscape PRINTING result on portrait paper sheet for 2 pages per sheet (Brother MFC-J6510DW)

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=49946

Drew Parsons  changed:

   What|Removed |Added

URL|http://hpsupportnumber.net/ |

--- Comment #50 from Drew Parsons  ---
This bug has attracted a hell lot of spam the last 6 months.  I suggest closing
it.  In any case I'm unsubscribing from it. The bug is now fixed for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112480] ODF: wrong attribute 'enhanced-path' is saved

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112480

--- Comment #7 from Regina Henschel  ---
The error still exists in Version: 6.3.0.0.alpha0+ (x64)
Build ID: d71ea82055a6a304493c7eaa90809a348e23784d
CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-11-19_04:56:18
Locale: de-DE (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121453] Remove the line feed and/or carriage return appended during either the cut or copy of a cell to the operating system’s clipboard

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121453

21na...@gmail.com changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #2 from 21na...@gmail.com ---
Steps to Reproduce:

1) Write at least one character in a cell;
2) Confirm its content by pressing “Enter” for example;
3) Click on the cell;
4) Put its content into the operating system’s clipboard by pressing “Ctrl + C”
for example;
5) Open a text editor (except LibreOffice Writer), then paste the content of
the operating system’s clipboard.


Actual Results:

The last step shows there is(are) a line feed or(and) carriage return at the
end.


Expected Results:

The last step should not show a line feed or(and) carriage return at the end,
see the comment 0.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121696] [EDITING] Usage of "Inequality" criteria in function SUMIF creates wrong result

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121696

Martin Lorscheid  changed:

   What|Removed |Added

 CC||lorma...@arcor.de

--- Comment #1 from Martin Lorscheid  ---
Created attachment 147004
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147004=edit
Example for SUMIF failure in combination with Inequality

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121691] line callout doesn't draw in writer document

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121691

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||rb.hensc...@t-online.de
 Ever confirmed|0   |1

--- Comment #3 from Regina Henschel  ---
I can reproduce the problem with your document in Version: 6.3.0.0.alpha0+
(x64)
Build ID: 9e55c8c7ffc43004ca314edcd4712dcc29adf933
CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: de-DE (en_US); UI-Language: en-US
Calc: threaded

I cannot produce the problem with a new document.

It seems to be somehow connected to the TOC. If I delete the TOC, the leg of
the callout is visible, if I insert the TOC again, the leg of the callout
vanishes.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121696] New: [EDITING] Usage of "Inequality" criteria in function SUMIF creates wrong result

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121696

Bug ID: 121696
   Summary: [EDITING] Usage of "Inequality" criteria in function
SUMIF creates wrong result
   Product: LibreOffice
   Version: 6.1.2.1 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lorma...@arcor.de

Description:
Starting with V. 6.1 the function SUMIF creates wrong results.
When using "<> 0" as criteria the function adds all content of Sum Range
without checking the range content.
Problem occurs since switching from V. 6.0.6.2 (x64)to V. 6.1.2.1 (x64)

see example Example_Inequality.ods


Steps to Reproduce:
see Example_Inequality.ods

Actual Results:
see Example_Inequality.ods

Expected Results:
see Example_Inequality.ods


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: SpreadsheetDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121687] LibreOffice Math Editor Characters bug

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121687

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||0204
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #4 from V Stuart Foote  ---
Beleive this is node stamping and bounding box mismatch as bug 120204,
corrected for 6.1.4, and refactored for master/6.2.0

Please retest 6.1.4, 6.2.0 or master...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120204] Scalable brackets: nodes with fractions and square roots are resized when updated

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120204

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||1687

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121659] FILESAVE DOCX Manual Column Break is lost after exported

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121659

raal  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 CC||vmik...@collabora.com

--- Comment #5 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to  Miklos Vajna ; Could you possibly take a look at this one?
Thanks

commit aeea51a8818a5deb7b95ba0b758463ba1703e9c4
Author: Matthew Francis 
Date:   Sat Mar 14 22:48:09 2015 +0800

source-hash-c4a5f8c1afd42acb52d0ae9b4d6f42f3e87364d5

commit c4a5f8c1afd42acb52d0ae9b4d6f42f3e87364d5
Author: Miklos Vajna 
AuthorDate: Tue Jul 8 14:41:10 2014 +0200
Commit: Miklos Vajna 
CommitDate: Tue Jul 8 15:35:47 2014 +0200

MSWordExportBase: fix export of header/footer in case of multiple
columns

Regression from 263938c4a8789d881f8e736d317b6bcc09c3bce5 (fdo#73596
[DOCX] Multiple Columns in Index, 2014-02-13), header / footer was lost
in multi-column section. This fixes both DOC and DOCX export.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121694] FILESAVE is broken

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121694

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||rb.hensc...@t-online.de
 Resolution|--- |DUPLICATE

--- Comment #1 from Regina Henschel  ---


*** This bug has been marked as a duplicate of bug 121569 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121695] New: comments: after editing Position and Size, arrow points to cell A1

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121695

Bug ID: 121695
   Summary: comments: after editing Position and Size, arrow
points to cell A1
   Product: LibreOffice
   Version: 6.1.3.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: oliver.brinz...@gmx.de

Created attachment 147003
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147003=edit
position and size demo

steps to reproduce:
- open attachment from
  https://bugs.documentfoundation.org/attachment.cgi?id=147002
- open comments context menu and select Position and Size"
- press [OK]
- arrow points to cell A1, see attached png.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121647] font list box preview certain malformed TTF fonts crash LO -- when receiving ShouldUseWinMetrics() handling

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121647

V Stuart Foote  changed:

   What|Removed |Added

Summary|font list box preview   |font list box preview
   |certain malformed TTF fonts |certain malformed TTF fonts
   |crash LO|crash LO -- when receiving
   ||ShouldUseWinMetrics()
   ||handling
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||6498

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/qa

2018-11-24 Thread Libreoffice Gerrit user
 vcl/qa/cppunit/pdfexport/pdfexport.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d806e7937c277cabc06ed40c6ed1d3efd805e15a
Author: Noel Grandin 
AuthorDate: Sat Nov 24 14:54:28 2018 +0200
Commit: Noel Grandin 
CommitDate: Sat Nov 24 16:50:43 2018 +0100

disable more vcl pdfexport test on win

Change-Id: I32fe34dc5d3d80dc26a5a2237c56155576789709
Reviewed-on: https://gerrit.libreoffice.org/63940
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx 
b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index dc402a4b1fdf..001b3de2f480 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -816,7 +816,6 @@ void PdfExportTest::testTdf108963()
 CPPUNIT_ASSERT_DOUBLES_EQUAL(793.7, aWidth, 0.01);
 const double aHeight = FPDF_GetPageHeight(pPdfPage.get());
 CPPUNIT_ASSERT_DOUBLES_EQUAL(446.46, aHeight, 0.01);
-#endif
 
 // Make sure there is a filled rectangle inside.
 int nPageObjectCount = FPDFPage_CountObjects(pPdfPage.get());
@@ -875,6 +874,7 @@ void PdfExportTest::testTdf108963()
 }
 
 CPPUNIT_ASSERT_EQUAL(1, nYellowPathCount);
+#endif
 }
 
 void PdfExportTest::testTdf118244_radioButtonGroup()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang slideshow/source starmath/inc starmath/source

2018-11-24 Thread Libreoffice Gerrit user
 compilerplugins/clang/unusedenumconstants.readonly.results |4 
 slideshow/source/engine/shapes/drawshapesubsetting.cxx |2 --
 slideshow/source/inc/doctreenode.hxx   |2 --
 starmath/inc/node.hxx  |5 ++---
 starmath/source/node.cxx   |3 +--
 5 files changed, 3 insertions(+), 13 deletions(-)

New commits:
commit 8a629c1f9b143e6222c4711c4d296f5f51b3485d
Author: Noel Grandin 
AuthorDate: Thu Nov 22 15:18:58 2018 +0200
Commit: Noel Grandin 
CommitDate: Sat Nov 24 16:49:45 2018 +0100

remove unused DocTreeNode::NodeType::Invalid

Change-Id: I68dde9c81ac73875382cd09bf342340b6c144ee8
Reviewed-on: https://gerrit.libreoffice.org/63935
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/unusedenumconstants.readonly.results 
b/compilerplugins/clang/unusedenumconstants.readonly.results
index d646e3e91cfe..2d3137a2774c 100644
--- a/compilerplugins/clang/unusedenumconstants.readonly.results
+++ b/compilerplugins/clang/unusedenumconstants.readonly.results
@@ -1232,8 +1232,6 @@ slideshow/source/engine/slideview.cxx:249
 enum slideshow::internal::(anonymous 
namespace)::LayerSpriteContainer::(anonymous at 
/home/noel/libo2/slideshow/source/engine/slideview.cxx:249:5) SPRITE_ULLAGE
 slideshow/source/engine/slideview.cxx:729
 enum slideshow::internal::(anonymous namespace)::SlideView::(anonymous at 
/home/noel/libo2/slideshow/source/engine/slideview.cxx:729:5) LAYER_ULLAGE
-slideshow/source/inc/doctreenode.hxx:52
-enum slideshow::internal::DocTreeNode::NodeType Invalid
 soltools/cpp/cpp.h:42
 int WS
 svgio/inc/svgstyleattributes.hxx:62
diff --git a/slideshow/source/engine/shapes/drawshapesubsetting.cxx 
b/slideshow/source/engine/shapes/drawshapesubsetting.cxx
index c7c9954316c1..5a0193e71928 100644
--- a/slideshow/source/engine/shapes/drawshapesubsetting.cxx
+++ b/slideshow/source/engine/shapes/drawshapesubsetting.cxx
@@ -604,8 +604,6 @@ namespace slideshow
 {
 switch( eNodeType )
 {
-case DocTreeNode::NodeType::Invalid:
-// FALLTHROUGH intended
 default:
 SAL_WARN( "slideshow", 
"DrawShapeSubsetting::mapDocTreeNode(): unexpected node type");
 return DrawShapeSubsetting::CLASS_NOOP;
diff --git a/slideshow/source/inc/doctreenode.hxx 
b/slideshow/source/inc/doctreenode.hxx
index 008979651b8a..1bb4beda5ec9 100644
--- a/slideshow/source/inc/doctreenode.hxx
+++ b/slideshow/source/inc/doctreenode.hxx
@@ -49,8 +49,6 @@ namespace slideshow
 /// Type of shape entity represented by this node
 enum class NodeType
 {
-Invalid=0,
-
 /// This node represents a paragraph
 LogicalParagraph=129,
 /// This node represents a word
commit 9afa992b34fbe9285398c6ec88e94d961da4094e
Author: Noel Grandin 
AuthorDate: Thu Nov 22 15:16:09 2018 +0200
Commit: Noel Grandin 
CommitDate: Sat Nov 24 16:49:32 2018 +0100

remove unused FontChangeMask::HorAlign

Change-Id: I9e38cf1d749aa78e5b3c32575b76a372ca25c7c8
Reviewed-on: https://gerrit.libreoffice.org/63933
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/unusedenumconstants.readonly.results 
b/compilerplugins/clang/unusedenumconstants.readonly.results
index 282427e96af2..d646e3e91cfe 100644
--- a/compilerplugins/clang/unusedenumconstants.readonly.results
+++ b/compilerplugins/clang/unusedenumconstants.readonly.results
@@ -1236,8 +1236,6 @@ slideshow/source/inc/doctreenode.hxx:52
 enum slideshow::internal::DocTreeNode::NodeType Invalid
 soltools/cpp/cpp.h:42
 int WS
-starmath/inc/node.hxx:62
-enum FontChangeMask HorAlign
 svgio/inc/svgstyleattributes.hxx:62
 enum svgio::svgreader::FontSize FontSize_notset
 svl/source/numbers/zformat.cxx:358
diff --git a/starmath/inc/node.hxx b/starmath/inc/node.hxx
index 9ee746d9d04c..640435a4101e 100644
--- a/starmath/inc/node.hxx
+++ b/starmath/inc/node.hxx
@@ -58,13 +58,12 @@ enum class FontChangeMask {
 Bold = 0x0004,
 Italic   = 0x0008,
 Color= 0x0010,
-Phantom  = 0x0020,
-HorAlign = 0x0040
+Phantom  = 0x0020
 };
 
 namespace o3tl
 {
-template<> struct typed_flags : 
is_typed_flags {};
+template<> struct typed_flags : 
is_typed_flags {};
 }
 
 
diff --git a/starmath/source/node.cxx b/starmath/source/node.cxx
index 2eba1f5c58f1..9e1ef9279997 100644
--- a/starmath/source/node.cxx
+++ b/starmath/source/node.cxx
@@ -204,8 +204,7 @@ void SmNode::SetSize(const Fraction )
 
 void SmNode::SetRectHorAlign(RectHorAlign eHorAlign, bool bApplyToSubTree )
 {
-if (!(Flags() & FontChangeMask::HorAlign))
-meRectHorAlign = eHorAlign;
+meRectHorAlign = eHorAlign;
 
 if (bApplyToSubTree)
 

[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang scaddins/source sc/source

2018-11-24 Thread Libreoffice Gerrit user
 compilerplugins/clang/unusedenumconstants.readonly.results |   12 ---
 sc/source/ui/vba/vbasheetobject.cxx|   42 +++--
 sc/source/ui/vba/vbasheetobject.hxx|   15 
 scaddins/source/analysis/analysis.cxx  |8 +-
 scaddins/source/analysis/analysishelper.cxx|   18 -
 scaddins/source/analysis/analysishelper.hxx|   12 ---
 6 files changed, 20 insertions(+), 87 deletions(-)

New commits:
commit 102091b73d824cdda7f88d9a7b79d04eb33fabf7
Author: Noel Grandin 
AuthorDate: Thu Nov 22 15:30:58 2018 +0200
Commit: Noel Grandin 
CommitDate: Sat Nov 24 16:50:11 2018 +0100

remove ScVbaControlObjectBase::ListenerType enum

we only use one value from it

Change-Id: I3d0391e76f07434915940be25025de36a5475bc5
Reviewed-on: https://gerrit.libreoffice.org/63937
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/unusedenumconstants.readonly.results 
b/compilerplugins/clang/unusedenumconstants.readonly.results
index 8e28a282002a..8b78a97df024 100644
--- a/compilerplugins/clang/unusedenumconstants.readonly.results
+++ b/compilerplugins/clang/unusedenumconstants.readonly.results
@@ -1194,14 +1194,6 @@ sc/source/ui/unoobj/condformatuno.cxx:274
 enum (anonymous namespace)::DateProperties Date_StyleName
 sc/source/ui/unoobj/condformatuno.cxx:275
 enum (anonymous namespace)::DateProperties DateType
-sc/source/ui/vba/vbasheetobject.hxx:140
-enum ScVbaControlObjectBase::ListenerType LISTENER_MOUSE
-sc/source/ui/vba/vbasheetobject.hxx:141
-enum ScVbaControlObjectBase::ListenerType LISTENER_TEXT
-sc/source/ui/vba/vbasheetobject.hxx:142
-enum ScVbaControlObjectBase::ListenerType LISTENER_VALUE
-sc/source/ui/vba/vbasheetobject.hxx:143
-enum ScVbaControlObjectBase::ListenerType LISTENER_CHANGE
 scaddins/source/datefunc/datefunc.hxx:41
 enum ScaCategory Finance
 scaddins/source/datefunc/datefunc.hxx:42
diff --git a/sc/source/ui/vba/vbasheetobject.cxx 
b/sc/source/ui/vba/vbasheetobject.cxx
index 9e5b7856d6c4..80f9d3249e57 100644
--- a/sc/source/ui/vba/vbasheetobject.cxx
+++ b/sc/source/ui/vba/vbasheetobject.cxx
@@ -36,6 +36,10 @@
 using namespace ::com::sun::star;
 using namespace ::ooo::vba;
 
+constexpr OUStringLiteral gaListenerType = "XActionListener";
+constexpr OUStringLiteral gaEventMethod = "actionPerformed";
+
+
 ScVbaButtonCharacters::ScVbaButtonCharacters(
 const uno::Reference< XHelperInterface >& rxParent,
 const uno::Reference< uno::XComponentContext >& rxContext,
@@ -292,37 +296,11 @@ ScVbaControlObjectBase::ScVbaControlObjectBase(
 const uno::Reference< uno::XComponentContext >& rxContext,
 const uno::Reference< frame::XModel >& rxModel,
 const uno::Reference< container::XIndexContainer >& rxFormIC,
-const uno::Reference< drawing::XControlShape >& rxControlShape,
-ListenerType eListenerType ) :
+const uno::Reference< drawing::XControlShape >& rxControlShape ) :
 ScVbaControlObject_BASE( rxParent, rxContext, rxModel, uno::Reference< 
drawing::XShape >( rxControlShape, uno::UNO_QUERY_THROW ) ),
 mxFormIC( rxFormIC, uno::UNO_SET_THROW ),
 mxControlProps( rxControlShape->getControl(), uno::UNO_QUERY_THROW )
 {
-// set listener and event name to be used for OnAction attribute
-switch( eListenerType )
-{
-case LISTENER_ACTION:
-maListenerType = "XActionListener";
-maEventMethod = "actionPerformed";
-break;
-case LISTENER_MOUSE:
-maListenerType = "XMouseListener";
-maEventMethod = "mouseReleased";
-break;
-case LISTENER_TEXT:
-maListenerType = "XTextListener";
-maEventMethod = "textChanged";
-break;
-case LISTENER_VALUE:
-maListenerType = "XAdjustmentListener";
-maEventMethod = "adjustmentValueChanged";
-break;
-case LISTENER_CHANGE:
-maListenerType = "XChangeListener";
-maEventMethod = "changed";
-break;
-// no default, to let the compiler complain about missing case
-}
 }
 
 // XSheetObject attributes
@@ -348,7 +326,7 @@ OUString SAL_CALL ScVbaControlObjectBase::getOnAction()
 const script::ScriptEventDescriptor* pEventEnd = pEvent + 
aEvents.getLength();
 const OUString aScriptType = "Script";
 for( ; pEvent < pEventEnd; ++pEvent )
-if( (pEvent->ListenerType == maListenerType) && 
(pEvent->EventMethod == maEventMethod) && (pEvent->ScriptType == aScriptType) )
+if( (pEvent->ListenerType == gaListenerType) && 
(pEvent->EventMethod == gaEventMethod) && (pEvent->ScriptType == aScriptType) )
 return extractMacroName( pEvent->ScriptCode );
 }
 return OUString();
@@ -360,7 +338,7 @@ void SAL_CALL ScVbaControlObjectBase::setOnAction( const 
OUString& rMacroName )

[Libreoffice-bugs] [Bug 121690] Comments are not shown in position saved

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121690

--- Comment #2 from Oliver Brinzing  ---
Created attachment 147002
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147002=edit
comment fixing

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121690] Comments are not shown in position saved

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121690

Oliver Brinzing  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||oliver.brinz...@gmx.de
 Ever confirmed|0   |1
Version|6.1.3.2 release |Inherited From OOo

--- Comment #1 from Oliver Brinzing  ---
confirming, already reproducible with

AOO415m1(Build:9789)  -  Rev. 1817496
2017-12-11 17:25

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121647] font list box preview certain malformed TTF fonts crash LO

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121647

--- Comment #8 from Khaled Hosny  ---
The crashing code was introduced in bug 116498.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 119951] Fileopen PPTX: Some row heights in table different from MSO

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119951

Korrawit Pruegsanusak  changed:

   What|Removed |Added

 Attachment #144972|application/octetstream |application/pdf
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 119953] Fileopen PPTX: chart legend text (Do not Autofit in MSO) not shown unless box size increased in Impress

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119953

Korrawit Pruegsanusak  changed:

   What|Removed |Added

 Attachment #144976|application/octetstream |application/pdf
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121689] Copy cells with condition to external programs (Word/Moodle) doesnt work properly

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121689

--- Comment #3 from Oliver Brinzing  ---
Created attachment 147001
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147001=edit
a simple conditional format example

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121689] Copy cells with condition to external programs (Word/Moodle) doesnt work properly

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121689

--- Comment #2 from Oliver Brinzing  ---
Created attachment 147000
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147000=edit
copy & paste from calc to word

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121689] Copy cells with condition to external programs (Word/Moodle) doesnt work properly

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121689

Oliver Brinzing  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Oliver Brinzing  ---
I can't reproduce it in

Version: 6.1.3.2 (x64)
Build ID: 86daf60bf00efa86ad547e59e09d6bb77c699acb
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: de-DE (de_DE); Calc: 

To be certain the reported issue is not
related to corruption in the user profile, could you please reset your
Libreoffice profile ( https://wiki.documentfoundation.org/UserProfile ) and
re-test?

Please attach a sample document, as this makes it easier for us to verify the
bug. 
(Please note that the attachment will be public, remove any sensitive
information before attaching it. 
See
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
for help on how to do so.)

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the issue is still present

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121500] Malformed pdf export with opentype font features

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121500

Korrawit Pruegsanusak  changed:

   What|Removed |Added

 Attachment #146727|application/octet-stream|application/zip
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120703] Bugs found by PVS-Studio static analyzer

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120703

Korrawit Pruegsanusak  changed:

   What|Removed |Added

 Attachment #145832|application/octet-stream|application/x-7z-compressed
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121465] Impossible to insert a cross reference without the separators

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121465

Korrawit Pruegsanusak  changed:

   What|Removed |Added

 Attachment #146726|application/octet-stream|application/vnd.oasis.opend
  mime type||ocument.text

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121465] Impossible to insert a cross reference without the separators

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121465

Korrawit Pruegsanusak  changed:

   What|Removed |Added

 Attachment #146766|application/octet-stream|application/vnd.oasis.opend
  mime type||ocument.text

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120441] LibreOffice consumes all memory on my Debian when opening this XLS file

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120441

Korrawit Pruegsanusak  changed:

   What|Removed |Added

 Attachment #146904|application/octet-stream|text/plain
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120130] No proper language choice possible in context menu neither on bottom (status ?) bar

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120130

Korrawit Pruegsanusak  changed:

   What|Removed |Added

 Attachment #145184|application/octet-stream|application/vnd.oasis.opend
  mime type||ocument.presentation

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120250] FILESAVE, when i save a big file windows crash

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120250

Korrawit Pruegsanusak  changed:

   What|Removed |Added

 Attachment #145305|application/octet-stream|application/vnd.oasis.opend
  mime type||ocument.spreadsheet

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 119224] Crash scrolling formatted 2007 DOCX with revision, comments and images (SfxListener::~SfxListener() EXCEPTION_ACCESS_VIOLATION_WRITE) ( steps in comment 8 )

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119224

Korrawit Pruegsanusak  changed:

   What|Removed |Added

 Attachment #144203|application/x-force-downloa |application/pdf
  mime type|d   |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 62613] unwanted spacing in DOC, table imported on another page (9 pages in MSO, was 40/12/19/12 pages in LO)

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=62613

Korrawit Pruegsanusak  changed:

   What|Removed |Added

 Attachment #143638|application/x-force-downloa |application/pdf
  mime type|d   |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 90693] Underline Does Also Include Indent for First Bullet Point After an Image

2018-11-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90693

Korrawit Pruegsanusak  changed:

   What|Removed |Added

 Attachment #114876|application/force-download  |application/zip
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   >