date:20181202

[Libreoffice-bugs] [Bug 121652] Option buttons in forms do not show current value if it is boolean

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121652

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||108440


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108440
[Bug 108440] [META] Database form bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108440] [META] Database form bugs and enhancements

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108440

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||121652


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121652
[Bug 121652] Option buttons in forms do not show current value if it is boolean
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121661] FILESAVE DOCX Hyphenation zone created with Word resets default value

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121661

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||104520


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104520
[Bug 104520] [META] DOCX (OOXML) bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104520] [META] DOCX (OOXML) bug tracker

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104520

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||121661


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121661
[Bug 121661] FILESAVE DOCX Hyphenation zone created with Word resets default
value
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sfx2/source

2018-12-02 Thread Libreoffice Gerrit user

 sfx2/source/sidebar/SidebarController.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit f3a19b124754d5506d047dabd5750b9e650bbb0a
Author: Jim Raykowski 
AuthorDate: Sat Nov 3 15:12:32 2018 -0800
Commit: Jim Raykowski 
CommitDate: Mon Dec 3 08:44:22 2018 +0100

Fix undocking sidebar with tab bar menu undock locks focus

Missed this in
I91194db3cc23a24e805a90edaf1566f950ac129d

Change-Id: I9a9bb3cb47b19929577f4ee36206ea1c052adeca
Reviewed-on: https://gerrit.libreoffice.org/62833
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sfx2/source/sidebar/SidebarController.cxx 
b/sfx2/source/sidebar/SidebarController.cxx
index f56534d02f46..46d03ba097b0 100644
--- a/sfx2/source/sidebar/SidebarController.cxx
+++ b/sfx2/source/sidebar/SidebarController.cxx
@@ -1046,6 +1046,8 @@ IMPL_LINK(SidebarController, OnMenuItemSelected, Menu*, 
pMenu, bool)
 {
 case MID_UNLOCK_TASK_PANEL:
 mpParentWindow->SetFloatingMode(true);
+if (mpParentWindow->IsFloatingMode())
+mpParentWindow->ToTop(ToTopFlags::GrabFocusOnly);
 break;
 
 case MID_LOCK_TASK_PANEL:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 121727] Security: Hangs if I open a .doc file with a virus (as marco?) even if macros are disabled

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121727

--- Comment #3 from Xavier Van Wijmeersch  ---
First try to reset your userprofile and test it again

Wish OS

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120722] Handles are not scaled properly on higher resolutions

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=120722

--- Comment #28 from 和尚蟹  ---
The ".docx" is the same as the ".doc" format. The "contact" cannot be
automatically scaled.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121624] No toolbars visible & no View -> User Interface selected (after upgrade?)

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121624

--- Comment #3 from Will Thompson  ---
It happened on every launch until I tried selecting a toolbar layout, after
which point it hasn't happened again. We also reproduced it only once in the
Endless QA system (with a fresh user profile).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121662] FILEOPEN DOCX Line Numbers created with Word do not start with the same value

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121662

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||104520


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104520
[Bug 104520] [META] DOCX (OOXML) bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104520] [META] DOCX (OOXML) bug tracker

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104520

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||121662


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121662
[Bug 121662] FILEOPEN DOCX Line Numbers created with Word do not start with the
same value
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sdext/source

2018-12-02 Thread Libreoffice Gerrit user

 sdext/source/minimizer/configurationaccess.cxx |   10 -
 sdext/source/minimizer/fileopendialog.cxx  |   20 +--
 sdext/source/minimizer/graphiccollector.cxx|   59 --
 sdext/source/minimizer/impoptimizer.cxx|   64 +--
 sdext/source/minimizer/optimizationstats.cxx   |7 -
 sdext/source/minimizer/optimizerdialogcontrols.cxx |   39 ++-
 sdext/source/minimizer/pagecollector.cxx   |   50 ++---
 sdext/source/pdfimport/odf/odfemitter.cxx  |9 -
 sdext/source/pdfimport/sax/emitcontext.cxx |6 -
 sdext/source/pdfimport/sax/saxattrlist.cxx |8 -
 sdext/source/pdfimport/tree/drawtreevisiting.cxx   |   23 ++--
 sdext/source/pdfimport/tree/genericelements.cxx|   26 ++--
 sdext/source/pdfimport/tree/style.cxx  |   15 +-
 sdext/source/pdfimport/tree/style.hxx  |   12 --
 sdext/source/pdfimport/tree/writertreevisiting.cxx |   97 -
 sdext/source/presenter/PresenterAccessibility.cxx  |   56 ++
 sdext/source/presenter/PresenterController.cxx |   40 +++
 sdext/source/presenter/PresenterHelpView.cxx   |   59 --
 sdext/source/presenter/PresenterPaneContainer.cxx  |   70 
 sdext/source/presenter/PresenterPaneFactory.cxx|6 -
 sdext/source/presenter/PresenterTextView.cxx   |   64 +++
 sdext/source/presenter/PresenterTheme.cxx  |   44 +++-
 sdext/source/presenter/PresenterTimer.cxx  |   23 +---
 sdext/source/presenter/PresenterToolBar.cxx|  115 -
 sdext/source/presenter/PresenterViewFactory.cxx|6 -
 sdext/source/presenter/PresenterWindowManager.cxx  |   63 ---
 26 files changed, 383 insertions(+), 608 deletions(-)

New commits:
commit 056845403c387f1fe286f9df13f73fa2fc6d0014
Author: Arkadiy Illarionov 
AuthorDate: Mon Dec 3 00:52:17 2018 +0300
Commit: Noel Grandin 
CommitDate: Mon Dec 3 08:14:15 2018 +0100

Simplify containers iterations in sdext

Use range-based loop or replace with STL functions

Change-Id: I760c1aaeae9afc99effee6a2645bb77439260ddf
Reviewed-on: https://gerrit.libreoffice.org/64435
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sdext/source/minimizer/configurationaccess.cxx 
b/sdext/source/minimizer/configurationaccess.cxx
index a7c5cbd6df4f..f7978379761b 100644
--- a/sdext/source/minimizer/configurationaccess.cxx
+++ b/sdext/source/minimizer/configurationaccess.cxx
@@ -466,14 +466,8 @@ Sequence< PropertyValue > 
ConfigurationAccess::GetConfigurationSequence()
 
 std::vector< OptimizerSettings >::iterator 
ConfigurationAccess::GetOptimizerSettingsByName( const OUString& rName )
 {
-std::vector< OptimizerSettings >::iterator aIter( maSettings.begin() + 1 );
-const std::vector< OptimizerSettings >::const_iterator aEnd( 
maSettings.end() );
-for ( ; aIter != aEnd; ++aIter )
-{
-if ( aIter->maName == rName )
-break;
-}
-return aIter;
+return std::find_if(maSettings.begin() + 1, maSettings.end(),
+[](const OptimizerSettings& rSettings) { return rSettings.maName 
== rName; });
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sdext/source/minimizer/fileopendialog.cxx 
b/sdext/source/minimizer/fileopendialog.cxx
index 13728bc5cba9..472951469571 100644
--- a/sdext/source/minimizer/fileopendialog.cxx
+++ b/sdext/source/minimizer/fileopendialog.cxx
@@ -118,12 +118,12 @@ FileOpenDialog::FileOpenDialog( const Reference< 
XComponentContext >& rxContext
 Reference< XNameAccess > xTypes( 
rxContext->getServiceManager()->createInstanceWithContext(
 "com.sun.star.document.TypeDetection", rxContext ), UNO_QUERY_THROW );
 
-for( std::vector< FilterEntry >::const_iterator 
aIter(aFilterEntryList.begin()), aEnd(aFilterEntryList.end()); aIter != aEnd; 
++aIter )
+for( const auto& rFilterEntry : aFilterEntryList )
 {
 Sequence< PropertyValue > aTypeProperties;
 try
 {
-if ( xTypes->getByName( aIter->maType ) >>= aTypeProperties )
+if ( xTypes->getByName( rFilterEntry.maType ) >>= aTypeProperties )
 {
 Sequence< OUString > aExtensions;
 for ( int i = 0; i < aTypeProperties.getLength(); i++ )
@@ -139,10 +139,10 @@ FileOpenDialog::FileOpenDialog( const Reference< 
XComponentContext >& rxContext
 // The filter title must be formed in the same way it is
 // currently done in the internal implementation:
 OUString aTitle(
-aIter->maUIName + " (." + aExtensions[0] + ")");
+rFilterEntry.maUIName + " (." + aExtensions[0] + ")");
 OUString aFilter("*." + aExtensions[0]);
 mxFilePicker->appendFilter(aTitle, aFilter);
-if ( aIter->maFlags & 0x100 )
+if (

[Libreoffice-commits] core.git: 2 commits - sw/inc sw/source

2018-12-02 Thread Libreoffice Gerrit user

 sw/inc/editsh.hxx|5 ++
 sw/source/core/edit/edfcol.cxx   |   68 ++-
 sw/source/core/txtnode/ndtxt.cxx |2 -
 3 files changed, 44 insertions(+), 31 deletions(-)

New commits:
commit 83a72f46d34fde7a119b00fcc0a7bf58dbe0076a
Author: Ashod Nakashian 
AuthorDate: Tue Oct 2 06:02:39 2018 -0400
Commit: Ashod Nakashian 
CommitDate: Mon Dec 3 08:12:39 2018 +0100

sw: paragraph-sign: formatting

Change-Id: I9bf1b58aa6e18202a5f7eba010cc5b914e1d33d4
Reviewed-on: https://gerrit.libreoffice.org/63005
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian 

diff --git a/sw/source/core/edit/edfcol.cxx b/sw/source/core/edit/edfcol.cxx
index f2be581ff73f..083ad320fbec 100644
--- a/sw/source/core/edit/edfcol.cxx
+++ b/sw/source/core/edit/edfcol.cxx
@@ -359,14 +359,16 @@ SignatureDescr lcl_getSignatureDescr(const 
uno::Reference& xModel
 SignatureDescr aDescr;
 aDescr.msId = sFieldId;
 
+const OUString prefix = ParagraphSignatureRDFNamespace + sFieldId;
 const std::map aStatements = 
lcl_getRDFStatements(xModel, xParagraph);
-const auto itSig = aStatements.find(ParagraphSignatureRDFNamespace + 
sFieldId + ParagraphSignatureDigestRDFName);
+
+const auto itSig = aStatements.find(prefix + 
ParagraphSignatureDigestRDFName);
 aDescr.msSignature = (itSig != aStatements.end() ? itSig->second : 
OUString());
 
-const auto itDate = aStatements.find(ParagraphSignatureRDFNamespace + 
sFieldId + ParagraphSignatureDateRDFName);
+const auto itDate = aStatements.find(prefix + 
ParagraphSignatureDateRDFName);
 aDescr.msDate = (itDate != aStatements.end() ? itDate->second : 
OUString());
 
-const auto itUsage = aStatements.find(ParagraphSignatureRDFNamespace + 
sFieldId + ParagraphSignatureUsageRDFName);
+const auto itUsage = aStatements.find(prefix + 
ParagraphSignatureUsageRDFName);
 aDescr.msUsage = (itUsage != aStatements.end() ? itUsage->second : 
OUString());
 
 return aDescr;
@@ -376,14 +378,16 @@ SignatureDescr lcl_getSignatureDescr(const 
uno::Reference& xModel
  const 
uno::Reference& xParagraph,
  const 
uno::Reference& xField)
 {
-const std::pair pair = lcl_getRDF(xModel, xField, 
ParagraphSignatureIdRDFName);
-return (!pair.second.isEmpty() ? lcl_getSignatureDescr(xModel, xParagraph, 
pair.second) : SignatureDescr());
+const OUString sFieldId = lcl_getRDF(xModel, xField, 
ParagraphSignatureIdRDFName).second;
+if (!sFieldId.isEmpty())
+return lcl_getSignatureDescr(xModel, xParagraph, sFieldId);
+
+return SignatureDescr();
 }
 
 /// Validate and create the signature field display text from the fields.
-std::pair
-lcl_MakeParagraphSignatureFieldText(const SignatureDescr& aDescr,
-const OString& utf8Text)
+std::pair lcl_MakeParagraphSignatureFieldText(const 
SignatureDescr& aDescr,
+  const OString& 
utf8Text)
 {
 OUString msg = SwResId(STR_INVALID_SIGNATURE);
 bool valid = false;
@@ -399,7 +403,8 @@ lcl_MakeParagraphSignatureFieldText(const SignatureDescr& 
aDescr,
 const std::vector 
sig(svl::crypto::DecodeHexString(encSignature));
 SignatureInformation aInfo(0);
 valid = svl::crypto::Signing::Verify(data, false, sig, aInfo);
-valid = valid && aInfo.nStatus == 
css::xml::crypto::SecurityOperationStatus_OPERATION_SUCCEEDED;
+valid = valid
+&& aInfo.nStatus == 
xml::crypto::SecurityOperationStatus_OPERATION_SUCCEEDED;
 
 msg = SwResId(STR_SIGNED_BY) + ": " + aInfo.ouSubject + ", ";
 msg += aDescr.msDate;
@@ -411,7 +416,6 @@ lcl_MakeParagraphSignatureFieldText(const SignatureDescr& 
aDescr,
 return std::make_pair(valid, msg);
 }
 
-
 /// Validate and return validation result and signature field display text.
 std::pair
 lcl_MakeParagraphSignatureFieldText(const uno::Reference& 
xModel,
@@ -427,11 +431,10 @@ lcl_MakeParagraphSignatureFieldText(const 
uno::Reference& xModel,
 OUString lcl_getNextSignatureId(const uno::Reference& xModel,
 const uno::Reference& 
xParagraph)
 {
-const std::pair pair = lcl_getRDF(xModel, xParagraph, 
ParagraphSignatureLastIdRDFName);
-return OUString::number(!pair.second.isEmpty() ? pair.second.toInt32() + 1 
: 1);
+const OUString sFieldId = lcl_getRDF(xModel, xParagraph, 
ParagraphSignatureLastIdRDFName).second;
+return OUString::number(!sFieldId.isEmpty() ? sFieldId.toInt32() + 1 : 1);
 }
 
-
 /// Creates and inserts Paragraph Signature Metadata field and creates the RDF 
entry
 uno::Reference lcl_InsertParagraphSignature(const 
uno::Reference& xModel,
   const 
uno::Reference& xParagraph,
@@ -465,10 +468,11 @@ uno::Reference

[Libreoffice-commits] core.git: sw/inc sw/source

2018-12-02 Thread Libreoffice Gerrit user

 sw/inc/rdfhelper.hxx |6 
 sw/source/core/doc/rdfhelper.cxx |   50 ---
 2 files changed, 43 insertions(+), 13 deletions(-)

New commits:
commit 1c17aa5056afc30c40bd307798180c8c7cf73c12
Author: Ashod Nakashian 
AuthorDate: Sun Oct 28 14:44:34 2018 -0400
Commit: Ashod Nakashian 
CommitDate: Mon Dec 3 08:11:41 2018 +0100

paragraph-sign: exception-safe metadata graph enumeration

Metadata graph enumeration can throw from a number
functions and break things in horrible ways.
Here we sanitize against the most egregious offenders,
but not all possible sources.

Change-Id: I40e006ea433dd7274d4fa08f3e8f8507680ef2f4
Reviewed-on: https://gerrit.libreoffice.org/63009
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian 

diff --git a/sw/inc/rdfhelper.hxx b/sw/inc/rdfhelper.hxx
index 218b81b0708c..4c351d8467f0 100644
--- a/sw/inc/rdfhelper.hxx
+++ b/sw/inc/rdfhelper.hxx
@@ -26,6 +26,7 @@ namespace com { namespace sun { namespace star {
 class XModel;
 }
 namespace rdf {
+class XDocumentMetadataAccess;
 class XResource;
 class XURI;
 }
@@ -37,6 +38,11 @@ class SW_DLLPUBLIC SwRDFHelper
 public:
 /// Gets all graph-names in RDF of a given type.
 static css::uno::Sequence>
+getGraphNames(const 
css::uno::Reference& xDocumentMetadataAccess,
+  const css::uno::Reference& xType);
+
+/// Gets all graph-names in RDF of a given type.
+static css::uno::Sequence>
 getGraphNames(const css::uno::Reference& xModel, const 
OUString& rType);
 
 /// Gets all (XResource, key, value) statements in RDF graphs given the 
graph-names.
diff --git a/sw/source/core/doc/rdfhelper.cxx b/sw/source/core/doc/rdfhelper.cxx
index 29e9e8dcf230..d1fb7d4dbf4f 100644
--- a/sw/source/core/doc/rdfhelper.cxx
+++ b/sw/source/core/doc/rdfhelper.cxx
@@ -23,15 +23,40 @@
 
 using namespace com::sun::star;
 
+css::uno::Sequence> 
SwRDFHelper::getGraphNames(
+const css::uno::Reference& 
xDocumentMetadataAccess,
+const css::uno::Reference& xType)
+{
+try
+{
+return xDocumentMetadataAccess->getMetadataGraphsWithType(xType);
+}
+catch (const uno::RuntimeException&)
+{
+return uno::Sequence>();
+}
+}
+
 css::uno::Sequence>
 SwRDFHelper::getGraphNames(const css::uno::Reference& 
xModel,
const OUString& rType)
 {
-uno::Reference xComponentContext(
-comphelper::getProcessComponentContext());
-uno::Reference xType = rdf::URI::create(xComponentContext, 
rType);
-uno::Reference 
xDocumentMetadataAccess(xModel, uno::UNO_QUERY);
-return xDocumentMetadataAccess->getMetadataGraphsWithType(xType);
+try
+{
+uno::Reference xComponentContext(
+comphelper::getProcessComponentContext());
+// rdf::URI::create may fail with type: 
com.sun.star.uno.DeploymentException
+// message: component context fails to supply service 
com.sun.star.rdf.URI of type com.sun.star.rdf.XURI
+// context: cppu::ComponentContext
+uno::Reference xType = rdf::URI::create(xComponentContext, 
rType);
+uno::Reference 
xDocumentMetadataAccess(xModel,
+ 
uno::UNO_QUERY);
+return getGraphNames(xDocumentMetadataAccess, xType);
+}
+catch (const ::css::uno::Exception&)
+{
+return uno::Sequence>();
+}
 }
 
 std::map
@@ -76,7 +101,7 @@ void SwRDFHelper::addStatement(const 
css::uno::Reference& xM
 uno::Reference 
xComponentContext(comphelper::getProcessComponentContext());
 uno::Reference xType = rdf::URI::create(xComponentContext, 
rType);
 uno::Reference 
xDocumentMetadataAccess(xModel, uno::UNO_QUERY);
-uno::Sequence< uno::Reference > aGraphNames = 
xDocumentMetadataAccess->getMetadataGraphsWithType(xType);
+const uno::Sequence< uno::Reference > aGraphNames = 
getGraphNames(xDocumentMetadataAccess, xType);
 uno::Reference xGraphName;
 if (aGraphNames.hasElements())
 xGraphName = aGraphNames[0];
@@ -96,8 +121,7 @@ bool SwRDFHelper::hasMetadataGraph(const 
css::uno::Reference
 uno::Reference 
xComponentContext(comphelper::getProcessComponentContext());
 uno::Reference xType = rdf::URI::create(xComponentContext, 
rType);
 uno::Reference 
xDocumentMetadataAccess(xModel, uno::UNO_QUERY);
-uno::Sequence< uno::Reference > aGraphNames = 
xDocumentMetadataAccess->getMetadataGraphsWithType(xType);
-return aGraphNames.hasElements();
+return getGraphNames(xDocumentMetadataAccess, xType).hasElements();
 }
 
 void SwRDFHelper::removeStatement(const 
css::uno::Reference& xModel,
@@ -108,7 +132,7 @@ void SwRDFHelper::removeStatement(const 
css::uno::Reference&
 uno::Reference 
xComponentContext(comphelper::getProcessComponentContext());
 uno::Reference xType = rdf::URI::create(xComponentContext, 
rType);

[Libreoffice-commits] core.git: sw/source

2018-12-02 Thread Libreoffice Gerrit user

 sw/source/core/edit/edfcol.cxx |   58 +
 1 file changed, 31 insertions(+), 27 deletions(-)

New commits:
commit 3750d0533e0e00941e5aef92fe5a26b6e7e27734
Author: Ashod Nakashian 
AuthorDate: Mon Oct 1 07:56:14 2018 -0400
Commit: Ashod Nakashian 
CommitDate: Mon Dec 3 08:12:01 2018 +0100

sw: paragraph-sign: get graph-names only once

And reduce other overheads to make the paragraph
signature validation significantly faster.

Change-Id: I631bd0f15200bb8f0b85b40c0d4819a7bc4d562e
Reviewed-on: https://gerrit.libreoffice.org/63003
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian 

diff --git a/sw/source/core/edit/edfcol.cxx b/sw/source/core/edit/edfcol.cxx
index b04f1c30dad2..b827f9306fc1 100644
--- a/sw/source/core/edit/edfcol.cxx
+++ b/sw/source/core/edit/edfcol.cxx
@@ -543,6 +543,7 @@ uno::Reference 
lcl_FindParagraphClassificationField(const uno:
 if (!xTextPortionEnumerationAccess.is())
 return xTextField;
 
+// Enumerate text portions to find metadata fields. This is expensive, 
best to enumerate fields only.
 uno::Reference xTextPortions = 
xTextPortionEnumerationAccess->createEnumeration();
 while (xTextPortions->hasMoreElements())
 {
@@ -560,7 +561,6 @@ uno::Reference 
lcl_FindParagraphClassificationField(const uno:
 uno::Reference xField(xServiceInfo, uno::UNO_QUERY);
 if (lcl_IsParagraphClassificationField(xModel, xField, sKey))
 {
-uno::Reference xText(xField, 
uno::UNO_QUERY);
 xTextField = xField;
 break;
 }
@@ -1156,10 +1156,6 @@ static void lcl_ApplyParagraphClassification(SwDoc* pDoc,
 if (!xNodeSubject.is())
 return;
 
-uno::Reference xMultiServiceFactory(xModel, 
uno::UNO_QUERY);
-
-sfx::ClassificationKeyCreator 
aKeyCreator(SfxClassificationHelper::getPolicyType());
-
 // Remove all paragraph classification fields.
 for (;;)
 {
@@ -1182,13 +1178,14 @@ static void lcl_ApplyParagraphClassification(SwDoc* 
pDoc,
 { return rResult.meType == 
svx::ClassificationType::PARAGRAPH; }),
   aResults.end());
 
+sfx::ClassificationKeyCreator 
aKeyCreator(SfxClassificationHelper::getPolicyType());
 std::vector aFieldNames;
 for (size_t nIndex = 0; nIndex < aResults.size(); ++nIndex)
 {
 const svx::ClassificationResult& rResult = aResults[nIndex];
 
 const bool isLast = nIndex == 0;
-const bool isFirst = nIndex == aResults.size() - 1;
+const bool isFirst = (nIndex == aResults.size() - 1);
 OUString sKey;
 OUString sValue = rResult.msName;
 switch (rResult.meType)
@@ -1909,19 +1906,23 @@ void SwEditShell::RestoreMetadataFields()
 uno::Reference xParagraphs = 
xParagraphEnumerationAccess->createEnumeration();
 if (!xParagraphs.is())
 return;
+
+static const OUString sBlank("");
+const sfx::ClassificationKeyCreator 
aKeyCreator(SfxClassificationHelper::getPolicyType());
+const css::uno::Sequence> aGraphNames = 
SwRDFHelper::getGraphNames(xModel, MetaNS);
+
 while (xParagraphs->hasMoreElements())
 {
 uno::Reference 
xParagraph(xParagraphs->nextElement(), uno::UNO_QUERY);
 
-std::map aSignatures;
-std::vector aResults;
-
 try
 {
-const sfx::ClassificationKeyCreator 
aKeyCreator(SfxClassificationHelper::getPolicyType());
-const OUString sBlank("");
+const css::uno::Reference 
xSubject(xParagraph, uno::UNO_QUERY);
+const std::map aStatements = 
SwRDFHelper::getStatements(xModel, aGraphNames, xSubject);
 
-const OUString sFieldNames = lcl_getRDF(xModel, xParagraph, 
ParagraphClassificationFieldNamesRDFName).second;
+const auto it = 
aStatements.find(ParagraphClassificationFieldNamesRDFName);
+const OUString sFieldNames = (it != aStatements.end() ? it->second 
: sBlank);
+std::vector aResults;
 if (!sFieldNames.isEmpty())
 {
 // Order the fields
@@ -1931,9 +1932,10 @@ void SwEditShell::RestoreMetadataFields()
 const OUString sCurFieldName = sFieldNames.getToken(0, 
'/', nIndex);
 if (sCurFieldName.isEmpty())
 break;
-std::pair fieldNameValue = 
lcl_getRDF(xModel, xParagraph, sCurFieldName);
-const OUString sName = fieldNameValue.first;
-const OUString sValue = fieldNameValue.second;
+
+const auto it2 = aStatements.find(sCurFieldName);
+const OUString sName = (it2 != aStatements.end() ? 
it->first : sBlank);
+const OUString sValue = (it2 != aStatements.end() ? 
it->second : sBlank);
 
 if (aKeyCreator.isMarkingTextKey(sName))
 {
@@

[Libreoffice-commits] core.git: sw/inc sw/source

2018-12-02 Thread Libreoffice Gerrit user

 sw/inc/rdfhelper.hxx |   17 +--
 sw/source/core/doc/rdfhelper.cxx |   42 +++
 2 files changed, 44 insertions(+), 15 deletions(-)

New commits:
commit 7ddfd67e71a1e7ec0769e4277c28b4f6580885b1
Author: Ashod Nakashian 
AuthorDate: Mon Oct 1 07:22:00 2018 -0400
Commit: Ashod Nakashian 
CommitDate: Mon Dec 3 08:11:23 2018 +0100

sw: rdf: Split graph-name lookup from getStatement

The graph-name lookup is significantly costly (compared
to the statement lookup, esp. when no statements exist).
Luckily, the graph-names do not change often and in the
course of enumerating all paragraphs (as happens for
paragraph-signature validation) it doesn't change at all.

This split allows for doing the graph-name lookup only
once and also allows for passing custom graph-names
directly, if we know them already.

Change-Id: I75425df201becb41105ba1fa6ba580af202d035c
Reviewed-on: https://gerrit.libreoffice.org/63002
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian 

diff --git a/sw/inc/rdfhelper.hxx b/sw/inc/rdfhelper.hxx
index 18ddd87127d7..218b81b0708c 100644
--- a/sw/inc/rdfhelper.hxx
+++ b/sw/inc/rdfhelper.hxx
@@ -17,6 +17,7 @@
 #include "swdllapi.h"
 
 #include 
+#include 
 
 class SwTextNode;
 
@@ -26,6 +27,7 @@ namespace com { namespace sun { namespace star {
 }
 namespace rdf {
 class XResource;
+class XURI;
 }
 }}}
 
@@ -33,11 +35,20 @@ namespace com { namespace sun { namespace star {
 class SW_DLLPUBLIC SwRDFHelper
 {
 public:
+/// Gets all graph-names in RDF of a given type.
+static css::uno::Sequence>
+getGraphNames(const css::uno::Reference& xModel, const 
OUString& rType);
+
+/// Gets all (XResource, key, value) statements in RDF graphs given the 
graph-names.
+static std::map
+getStatements(const css::uno::Reference& xModel,
+  const 
css::uno::Sequence>& rGraphNames,
+  const css::uno::Reference& xSubject);
 
 /// Gets all (XResource, key, value) statements in RDF graphs of type 
rType.
-static std::map getStatements(const 
css::uno::Reference& xModel,
-  const OUString& rType,
-  const 
css::uno::Reference& xSubject);
+static std::map
+getStatements(const css::uno::Reference& xModel, const 
OUString& rType,
+  const css::uno::Reference& xSubject);
 
 /// Add an (XResource, key, value) statement in the graph of type rType -- 
or if it does not exist, create a graph at rPath first.
 static void addStatement(const css::uno::Reference& 
xModel,
diff --git a/sw/source/core/doc/rdfhelper.cxx b/sw/source/core/doc/rdfhelper.cxx
index 8e8c78d90313..29e9e8dcf230 100644
--- a/sw/source/core/doc/rdfhelper.cxx
+++ b/sw/source/core/doc/rdfhelper.cxx
@@ -23,26 +23,36 @@
 
 using namespace com::sun::star;
 
-std::map SwRDFHelper::getStatements(const 
css::uno::Reference& xModel,
-const OUString& rType,
-const 
css::uno::Reference& xSubject)
+css::uno::Sequence>
+SwRDFHelper::getGraphNames(const css::uno::Reference& 
xModel,
+   const OUString& rType)
 {
-std::map aRet;
-
-uno::Reference 
xComponentContext(comphelper::getProcessComponentContext());
+uno::Reference xComponentContext(
+comphelper::getProcessComponentContext());
 uno::Reference xType = rdf::URI::create(xComponentContext, 
rType);
 uno::Reference 
xDocumentMetadataAccess(xModel, uno::UNO_QUERY);
-uno::Sequence< uno::Reference > aGraphNames = 
xDocumentMetadataAccess->getMetadataGraphsWithType(xType);
-if (!aGraphNames.hasElements())
+return xDocumentMetadataAccess->getMetadataGraphsWithType(xType);
+}
+
+std::map
+SwRDFHelper::getStatements(const css::uno::Reference& 
xModel,
+   const 
uno::Sequence>& rGraphNames,
+   const css::uno::Reference& 
xSubject)
+{
+std::map aRet;
+if (!rGraphNames.hasElements())
 return aRet;
 
-for (const uno::Reference& xGraphName : aGraphNames)
+uno::Reference 
xDocumentMetadataAccess(xModel, uno::UNO_QUERY);
+const uno::Reference& xRepo = 
xDocumentMetadataAccess->getRDFRepository();
+for (const uno::Reference& xGraphName : rGraphNames)
 {
-uno::Reference xGraph = 
xDocumentMetadataAccess->getRDFRepository()->getGraph(xGraphName);
-uno::Reference xStatements = 
xGraph->getStatements(xSubject, uno::Reference(), 
uno::Reference());
+uno::Reference xGraph = xRepo->getGraph(xGraphName);
+uno::Reference xStatements = 
xGraph->getStatements(
+xSubject, uno::Reference(), 
uno::Reference());
 while (xStatements->hasMoreElements())
 {
-rdf::Statement aStatement =

[Libreoffice-commits] core.git: 2 commits - sw/source

2018-12-02 Thread Libreoffice Gerrit user

 sw/source/core/doc/DocumentTimerManager.cxx |   34 +++-
 sw/source/core/inc/DocumentTimerManager.hxx |7 +
 sw/source/core/txtnode/ndtxt.cxx|9 ---
 3 files changed, 40 insertions(+), 10 deletions(-)

New commits:
commit b402d0112a0bb53221b847fa372bfa3f6390a0e2
Author: Ashod Nakashian 
AuthorDate: Fri Sep 28 06:27:09 2018 -0400
Commit: Ashod Nakashian 
CommitDate: Mon Dec 3 08:10:45 2018 +0100

sw: paragraph-sign: erase metafields from copied text correctly

This is relevant for paragraph signatures where the
metadata is not yet copied and so we exclude it.
The issue was that in some cases we didn't use
the proper range of text and an assertion was
triggered in debug builds.

Otherwise there should be no change of behavior
in release builds with this patch.

Change-Id: I90bc2ca56d586b96d39f34c68de53d3dac6099d7
Reviewed-on: https://gerrit.libreoffice.org/63000
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian 

diff --git a/sw/source/core/txtnode/ndtxt.cxx b/sw/source/core/txtnode/ndtxt.cxx
index a979650504e1..ce948ec68c3c 100644
--- a/sw/source/core/txtnode/ndtxt.cxx
+++ b/sw/source/core/txtnode/ndtxt.cxx
@@ -2018,7 +2018,7 @@ void SwTextNode::CopyText( SwTextNode *const pDest,
 {
 CHECK_SWPHINTS_IF_FRM(this);
 CHECK_SWPHINTS(pDest);
-sal_Int32 nTextStartIdx = rStart.GetIndex();
+const sal_Int32 nTextStartIdx = rStart.GetIndex();
 sal_Int32 nDestStart = rDestStart.GetIndex();  // remember old Pos
 
 if (pDest->GetDoc()->IsClipBoard() && GetNum())
@@ -2109,7 +2109,6 @@ void SwTextNode::CopyText( SwTextNode *const pDest,
 
 // Fetch end only now, because copying into self updates the start index
 // and all attributes
-nTextStartIdx = rStart.GetIndex();
 const sal_Int32 nEnd = nTextStartIdx + nLen;
 
 // 2. copy attributes
@@ -2257,8 +2256,10 @@ void SwTextNode::CopyText( SwTextNode *const pDest,
 std::reverse(metaFieldRanges.begin(), metaFieldRanges.end());
 for (const auto& pair : metaFieldRanges)
 {
-const SwIndex aIdx(pDest, pair.first);
-pDest->EraseText(aIdx, pair.second - pair.first);
+const SwIndex aIdx(pDest, std::max(pair.first - 
nTextStartIdx, 0));
+const sal_Int32 nCount = pair.second - pair.first;
+if (nCount > 0)
+pDest->EraseText(aIdx, nCount);
 }
 }
 
commit 349748e63c698076bb44f75da9eaa104489e959c
Author: Ashod Nakashian 
AuthorDate: Sat Oct 20 14:16:08 2018 -0400
Commit: Ashod Nakashian 
CommitDate: Mon Dec 3 08:10:32 2018 +0100

sw lok: delay processing idle jobs to let LOK finish initialization

When loading document, LOK needs to setup the client view, register
callbacks, get document size and type, etc. All of these need
to take SolarMutex, which is taken by the idle jobs immediately
after loading, blocking LOK from finishing initialization
and rendering the first tiles for the user. This gives the
user the impression that the document is loading for far
longer than it actually is, due to lack of interactivity
(or indeed any activity on the screen besides the spinning wheel).

By delaying the idle jobs, we allow time for LOK to finish
initialization and render the first tiles before the idle
jobs kick in and hog SolarMutex.

Reviewed-on: https://gerrit.libreoffice.org/56572
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 
(cherry picked from commit 1056640a6e1fd044cb61f5bf5ee85dfec3cbeb7c)

Reviewed-on: https://gerrit.libreoffice.org/58157
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 
(cherry picked from commit e5225f152c3128efa73cb602d7a524f2cb436189)

Change-Id: Ic6f437bfd6f43dfed2aaa1a9d3510d43f5ec30ae
Reviewed-on: https://gerrit.libreoffice.org/64013
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian 

diff --git a/sw/source/core/doc/DocumentTimerManager.cxx 
b/sw/source/core/doc/DocumentTimerManager.cxx
index 44984c86e583..e80c74c695eb 100644
--- a/sw/source/core/doc/DocumentTimerManager.cxx
+++ b/sw/source/core/doc/DocumentTimerManager.cxx
@@ -34,22 +34,38 @@
 #include 
 #include 
 #include 
+#include 
 
 namespace sw
 {
-
-DocumentTimerManager::DocumentTimerManager( SwDoc& i_rSwdoc ) : m_rDoc( 
i_rSwdoc ),
-
m_nIdleBlockCount( 0 ),
-
m_bStartOnUnblock( false ),
-m_aDocIdle( 
i_rSwdoc )
+DocumentTimerManager::DocumentTimerManager(SwDoc& i_rSwdoc)
+: m_rDoc(i_rSwdoc)
+, m_nIdleBlockCount(0)
+, m_bStartOnUnblock(false)
+, m_aDocIdle(i_rSwdoc)
+, m_aFireIdleJobsTimer("sw::DocumentTimerManager m_aFireIdleJobsTimer")
+, m_bWaitForLokInit(true)
 {

[Libreoffice-commits] core.git: sfx2/source

2018-12-02 Thread Libreoffice Gerrit user

 sfx2/source/doc/DocumentMetadataAccess.cxx |   67 +
 1 file changed, 50 insertions(+), 17 deletions(-)

New commits:
commit 8c84672e93a6bcdc53d93e7a3c8321684ed36736
Author: Ashod Nakashian 
AuthorDate: Mon Oct 1 07:03:47 2018 -0400
Commit: Ashod Nakashian 
CommitDate: Mon Dec 3 08:10:58 2018 +0100

sfx2: Combine metadata graph lookup and filtering

The graph lookup is suprisingly costly and so is
filtering. By specializing the lookup with filtering
the logic is more readable and slightly faster (~35%
in debug build).

Change-Id: Id35a562c76a84a81362f47b61ed67fb74d0a6dc7
Reviewed-on: https://gerrit.libreoffice.org/63001
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian 

diff --git a/sfx2/source/doc/DocumentMetadataAccess.cxx 
b/sfx2/source/doc/DocumentMetadataAccess.cxx
index 04c3fb4ea963..980e6ec06d37 100644
--- a/sfx2/source/doc/DocumentMetadataAccess.cxx
+++ b/sfx2/source/doc/DocumentMetadataAccess.cxx
@@ -417,6 +417,48 @@ isPartOfType(struct DocumentMetadataAccess_Impl const & 
i_rImpl,
 }
 }
 
+static ::std::vector>
+getAllParts(struct DocumentMetadataAccess_Impl const& i_rImpl,
+const uno::Reference& i_xType)
+{
+::std::vector> ret;
+try
+{
+const uno::Reference xEnum(
+i_rImpl.m_xManifest->getStatements(i_rImpl.m_xBaseURI.get(),
+   
getURI(i_rImpl.m_xContext),
+   nullptr),
+uno::UNO_SET_THROW);
+while (xEnum->hasMoreElements())
+{
+rdf::Statement stmt;
+if (!(xEnum->nextElement() >>= stmt))
+{
+throw uno::RuntimeException();
+}
+const uno::Reference xPart(stmt.Object, uno::UNO_QUERY);
+if (!xPart.is())
+continue;
+
+const uno::Reference xEnum2(
+i_rImpl.m_xManifest->getStatements(
+xPart.get(), 
getURI(i_rImpl.m_xContext), i_xType.get()),
+uno::UNO_SET_THROW);
+if (xEnum2->hasMoreElements())
+ret.emplace_back(xPart);
+}
+return ret;
+}
+catch (const uno::RuntimeException&)
+{
+throw;
+}
+catch (const uno::Exception& e)
+{
+throw lang::WrappedTargetRuntimeException("getAllParts: exception", 
nullptr,
+  uno::makeAny(e));
+}
+}
 
 static ucb::InteractiveAugmentedIOException
 mkException( OUString const & i_rMessage,
@@ -856,26 +898,17 @@ DocumentMetadataAccess::getElementByURI(
 return getElementByMetadataReference( beans::StringPair(path, idref) );
 }
 
-
-uno::Sequence< uno::Reference< rdf::XURI > > SAL_CALL
-DocumentMetadataAccess::getMetadataGraphsWithType(
-const uno::Reference & i_xType)
+uno::Sequence> SAL_CALL
+DocumentMetadataAccess::getMetadataGraphsWithType(const 
uno::Reference& i_xType)
 {
-if (!i_xType.is()) {
-throw lang::IllegalArgumentException(
-"DocumentMetadataAccess::getMetadataGraphsWithType: "
-"type is null", *this, 0);
+if (!i_xType.is())
+{
+throw 
lang::IllegalArgumentException("DocumentMetadataAccess::getMetadataGraphsWithType:
 "
+ "type is null",
+ *this, 0);
 }
 
-::std::vector< uno::Reference< rdf::XURI > > ret;
-const ::std::vector< uno::Reference< rdf::XURI > > parts(
-getAllParts(*m_pImpl) );
-::std::remove_copy_if(parts.begin(), parts.end(),
-::std::back_inserter(ret),
-[this, _xType](uno::Reference< rdf::XURI > aPart) {
-return !isPartOfType(*m_pImpl, aPart, i_xType);
-} );
-return ::comphelper::containerToSequence(ret);
+return ::comphelper::containerToSequence(getAllParts(*m_pImpl, i_xType));
 }
 
 uno::Reference SAL_CALL
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 121745] Time to copy sheet has doubled

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121745

--- Comment #2 from Aron Budea  ---
For me with the blamed commit it's ~1:30, with the preceding one, ~0:42, and
with latest commit from bibisect-win32-6.2 around ~1:10.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121507] Mouse pauses automatically

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121507

--- Comment #11 from 和尚蟹  ---
Created attachment 147233
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147233=edit
LibreOffice already has this feature, please increase the scope of use, the
answer is in the pattern.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121670] FILEOPEN DOCX Three type Column with Next Page Section Break created with Word isn’t added to a new page opened in Writer

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121670

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||10
   Keywords||filter:docx


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=10
[Bug 10] [META] DOCX (OOXML) table-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=10

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||121670


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121670
[Bug 121670] FILEOPEN DOCX Three type Column with Next Page Section Break
created with Word isn’t added to a new page opened in Writer
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/vcl vcl/headless vcl/source

2018-12-02 Thread Libreoffice Gerrit user

 include/vcl/BitmapTools.hxx   |6 +--
 vcl/headless/svpgdi.cxx   |9 +++--
 vcl/source/bitmap/BitmapTools.cxx |   59 ++
 3 files changed, 43 insertions(+), 31 deletions(-)

New commits:
commit 644188bf7f3a07222f2b58a3794348197fb8ad24
Author: Stephan Bergmann 
AuthorDate: Sun Dec 2 16:50:22 2018 +0100
Commit: Stephan Bergmann 
CommitDate: Mon Dec 3 07:53:30 2018 +0100

Compute (un-)premultiply_table at compile time

Change-Id: I34e624fcd5d11d02c26e775f5acdddec1fca9d87
Reviewed-on: https://gerrit.libreoffice.org/64428
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/include/vcl/BitmapTools.hxx b/include/vcl/BitmapTools.hxx
index ff431783ad24..c952498c5c58 100644
--- a/include/vcl/BitmapTools.hxx
+++ b/include/vcl/BitmapTools.hxx
@@ -28,10 +28,10 @@ namespace com { namespace sun { namespace star { namespace 
geometry { struct Int
 namespace vcl {
 namespace bitmap {
 
-typedef sal_uInt8 (*lookup_table)[256];
+typedef std::array, 256> lookup_table;
 
-lookup_table VCL_DLLPUBLIC get_premultiply_table();
-lookup_table VCL_DLLPUBLIC get_unpremultiply_table();
+VCL_DLLPUBLIC lookup_table const & get_premultiply_table();
+VCL_DLLPUBLIC lookup_table const & get_unpremultiply_table();
 
 /**
  * Intended to be used to feed into CreateFromData to create a BitmapEx. RGB 
data format.
diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index c936b0e1cbbe..848d2e0f2b04 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -1654,7 +1654,7 @@ void SvpSalGraphics::drawMask( const SalTwoRect& rTR,
 }
 sal_Int32 nStride;
 unsigned char *mask_data = aSurface.getBits(nStride);
-vcl::bitmap::lookup_table unpremultiply_table = 
vcl::bitmap::get_unpremultiply_table();
+vcl::bitmap::lookup_table const & unpremultiply_table = 
vcl::bitmap::get_unpremultiply_table();
 for (long y = rTR.mnSrcY ; y < rTR.mnSrcY + rTR.mnSrcHeight; ++y)
 {
 unsigned char *row = mask_data + (nStride*y);
@@ -1762,7 +1762,7 @@ Color SvpSalGraphics::getPixel( long nX, long nY )
 cairo_destroy(cr);
 
 cairo_surface_flush(target);
-vcl::bitmap::lookup_table unpremultiply_table = 
vcl::bitmap::get_unpremultiply_table();
+vcl::bitmap::lookup_table const & unpremultiply_table = 
vcl::bitmap::get_unpremultiply_table();
 unsigned char *data = cairo_image_surface_get_data(target);
 sal_uInt8 a = data[SVP_CAIRO_ALPHA];
 sal_uInt8 b = unpremultiply_table[a][data[SVP_CAIRO_BLUE]];
@@ -2096,8 +2096,9 @@ void SvpSalGraphics::releaseCairoContext(cairo_t* cr, 
bool bXorModeAllowed, cons
 sal_Int32 nUnscaledExtentsRight = nExtentsRight * m_fScale;
 sal_Int32 nUnscaledExtentsTop = nExtentsTop * m_fScale;
 sal_Int32 nUnscaledExtentsBottom = nExtentsBottom * m_fScale;
-vcl::bitmap::lookup_table unpremultiply_table = 
vcl::bitmap::get_unpremultiply_table();
-vcl::bitmap::lookup_table premultiply_table = 
vcl::bitmap::get_premultiply_table();
+vcl::bitmap::lookup_table const & unpremultiply_table
+= vcl::bitmap::get_unpremultiply_table();
+vcl::bitmap::lookup_table const & premultiply_table = 
vcl::bitmap::get_premultiply_table();
 for (sal_Int32 y = nUnscaledExtentsTop; y < nUnscaledExtentsBottom; 
++y)
 {
 unsigned char *true_row = target_surface_data + (nStride*y);
diff --git a/vcl/source/bitmap/BitmapTools.cxx 
b/vcl/source/bitmap/BitmapTools.cxx
index 4bac9745795e..f9095a86f541 100644
--- a/vcl/source/bitmap/BitmapTools.cxx
+++ b/vcl/source/bitmap/BitmapTools.cxx
@@ -8,6 +8,11 @@
  *
  */
 
+#include 
+
+#include 
+#include 
+
 #include 
 
 #include 
@@ -268,7 +273,7 @@ BitmapEx* CreateFromCairoSurface(Size aSize, 
cairo_surface_t * pSurface)
 cairo_surface_flush(pPixels);
 unsigned char *pSrc = cairo_image_surface_get_data( pPixels );
 unsigned int nStride = cairo_image_surface_get_stride( pPixels );
-vcl::bitmap::lookup_table unpremultiply_table = 
vcl::bitmap::get_unpremultiply_table();
+vcl::bitmap::lookup_table const & unpremultiply_table = 
vcl::bitmap::get_unpremultiply_table();
 for( unsigned long y = 0; y < static_cast(aSize.Height()); 
y++ )
 {
 sal_uInt32 *pPix = reinterpret_cast(pSrc + nStride * y);
@@ -727,7 +732,7 @@ void CanvasCairoExtractBitmapData( BitmapEx const & aBmpEx, 
Bitmap & aBitmap, un
 ::Color aColor;
 unsigned int nAlpha = 255;
 
-vcl::bitmap::lookup_table premultiply_table = 
vcl::bitmap::get_premultiply_table();
+vcl::bitmap::lookup_table const & premultiply_table = 
vcl::bitmap::get_premultiply_table();
 for( nY = 0; nY < nHeight; nY++ )
 {
 ::Scanline pReadScan;
@@ -1046,45 +1051,51 @@ void CanvasCairoExtractBitmapData( BitmapEx const & 
aBmpEx, Bitmap & aBitmap, un
 return bRet;
 }
 
-static sal_uInt8 unpremultiply(sal_uInt8 c, sal_uInt8 a)
+static constexpr sal_uInt8

[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107733

Dieter Praas  changed:

   What|Removed |Added

 Depends on||121875


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121875
[Bug 121875] Hyperlinks to IDN websites are broken
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121875] Hyperlinks to IDN websites are broken

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121875

Dieter Praas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 Blocks||107733
   Keywords||bibisectRequest, regression
 CC||dgp-m...@gmx.de

--- Comment #2 from Dieter Praas  ---
I confirm it with

Version: 6.2.0.0.beta1 (x64)
Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (de_DE); UI-Language: en-GB
Calc: threaded

but not with LO 5.4.7.2


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107733
[Bug 107733] [META] Hyperlink bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108897] [META] XLSX (OOXML) bug tracker

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108897

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||121714


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121714
[Bug 121714] FILEOPEN XLSX: Show comment at end of sheet setting is not
imported and printed
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121714] FILEOPEN XLSX: Show comment at end of sheet setting is not imported and printed

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121714

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||108897
   Keywords||filter:xlsx


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108897
[Bug 108897] [META] XLSX (OOXML) bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108253] [META] Calc cell formula bugs and enhancements

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108253

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||121696


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121696
[Bug 121696] [EDITING] Usage of "Inequality" criteria in function SUMIF creates
wrong result
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121696] [EDITING] Usage of "Inequality" criteria in function SUMIF creates wrong result

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121696

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||108253


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108253
[Bug 108253] [META] Calc cell formula bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121720] [TABLE] A merged table cell across page (due to other columns containing multiple rows) would cause Writer hang forever

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121720

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||103100


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs and enhancements

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103100

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||121720


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121720
[Bug 121720] [TABLE] A merged table cell across page (due to other columns
containing multiple rows) would cause Writer hang forever
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121793] Animated gif causes big CPU load

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121793

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||108438


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108438
[Bug 108438] [META] Animated image bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108438] [META] Animated image bugs and enhancements

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108438

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||121793


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121793
[Bug 121793] Animated gif causes big CPU load
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121624] No toolbars visible & no View -> User Interface selected (after upgrade?)

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121624

--- Comment #2 from Dieter Praas  ---
Will, could you reproduce this behaviour or did it only happen once?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104461] [META] DOCX (OOXML) frame-related issues

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104461

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||121804


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121804
[Bug 121804] docx import: no superscripts / subscripts in a textarea
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121804] docx import: no superscripts / subscripts in a textarea

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121804

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||104461
   Keywords||filter:docx


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104461
[Bug 104461] [META] DOCX (OOXML) frame-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #174 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/cee3278a3d5924e01d92ff8a39d7b9751996d7e3%5E%21

tdf#45904 Move XElementAccess Java tests to C++

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: bin/gbuild-to-ide

2018-12-02 Thread Libreoffice Gerrit user

 bin/gbuild-to-ide |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1ee8d4f63adf3113a4733a479c8faf9eb65f7b8d
Author: Andrea Gelmini 
AuthorDate: Sun Dec 2 18:58:04 2018 +0100
Commit: Jens Carl 
CommitDate: Mon Dec 3 07:21:51 2018 +0100

Fix typo

Change-Id: I69e4d471c806159d6748016a79f041c01b40b888
Reviewed-on: https://gerrit.libreoffice.org/64430
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/bin/gbuild-to-ide b/bin/gbuild-to-ide
index 14409b5490b9..5ea0406be71f 100755
--- a/bin/gbuild-to-ide
+++ b/bin/gbuild-to-ide
@@ -1507,7 +1507,7 @@ class 
QtCreatorIntegrationGenerator(IdeIntegrationGenerator):
 define += '=' + value
 defines_list.append(define)
 
-# All datas are prepared, store them for the lib.
+# All data are prepared, store them for the lib.
 if lib_folder in self.data_libs:
 self.data_libs[lib_folder]['sources'] |= set(sources_list)
 self.data_libs[lib_folder]['headers'] |= set(headers_list)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: framework/qa qadevOOo/Jar_OOoRunner.mk qadevOOo/objdsc qadevOOo/tests sc/qa

2018-12-02 Thread Libreoffice Gerrit user

 framework/qa/complex/api_internal/api.lst|1 
 qadevOOo/Jar_OOoRunner.mk|1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScLabelRangesObj.csv |2 
 qadevOOo/tests/java/mod/_sc/ScLabelRangesObj.java|  119 
--
 sc/qa/extras/sclabelrangesobj.cxx|   10 
 sc/qa/unoapi/sc_6.sce|1 
 6 files changed, 10 insertions(+), 124 deletions(-)

New commits:
commit cee3278a3d5924e01d92ff8a39d7b9751996d7e3
Author: Jens Carl 
AuthorDate: Sun Dec 2 18:23:41 2018 +
Commit: Jens Carl 
CommitDate: Mon Dec 3 07:20:39 2018 +0100

tdf#45904 Move XElementAccess Java tests to C++

Move XElementAccess Java tests to C++ for ScLabelRangesObj.

Change-Id: Icf49fb7e8c24b169e4fe33ffed8cc1412d21f9e8
Reviewed-on: https://gerrit.libreoffice.org/64432
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/framework/qa/complex/api_internal/api.lst 
b/framework/qa/complex/api_internal/api.lst
index b47dad57003c..a4b45dfd2053 100644
--- a/framework/qa/complex/api_internal/api.lst
+++ b/framework/qa/complex/api_internal/api.lst
@@ -91,7 +91,6 @@ job96=sc.ScFilterDescriptorBase
 job97=sc.ScFunctionListObj
 job98=sc.ScHeaderFieldObj
 job99=sc.ScHeaderFieldsObj
-job122=sc.ScLabelRangesObj
 job125=sc.ScScenariosObj
 job126=sc.ScSheetLinkObj
 job127=sc.ScSheetLinksObj
diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk
index 2c5673c4e86a..9de56bbe02dd 100644
--- a/qadevOOo/Jar_OOoRunner.mk
+++ b/qadevOOo/Jar_OOoRunner.mk
@@ -989,7 +989,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\
 qadevOOo/tests/java/mod/_sc/ScHeaderFieldsObj \
 qadevOOo/tests/java/mod/_sc/ScHeaderFooterTextCursor \
 qadevOOo/tests/java/mod/_sc/ScHeaderFooterTextObj \
-qadevOOo/tests/java/mod/_sc/ScLabelRangesObj \
 qadevOOo/tests/java/mod/_sc/ScModelObj \
 qadevOOo/tests/java/mod/_sc/ScNamedRangesObj \
 qadevOOo/tests/java/mod/_sc/ScScenariosObj \
diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScLabelRangesObj.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScLabelRangesObj.csv
deleted file mode 100644
index c814454c7897..
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScLabelRangesObj.csv
+++ /dev/null
@@ -1,2 +0,0 @@
-"ScLabelRangesObj";"com::sun::star::container::XElementAccess";"getElementType()"
-"ScLabelRangesObj";"com::sun::star::container::XElementAccess";"hasElements()"
diff --git a/qadevOOo/tests/java/mod/_sc/ScLabelRangesObj.java 
b/qadevOOo/tests/java/mod/_sc/ScLabelRangesObj.java
deleted file mode 100644
index 2806fd4cfb55..
--- a/qadevOOo/tests/java/mod/_sc/ScLabelRangesObj.java
+++ /dev/null
@@ -1,119 +0,0 @@
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-package mod._sc;
-
-import java.io.PrintWriter;
-
-import lib.TestCase;
-import lib.TestEnvironment;
-import lib.TestParameters;
-import util.SOfficeFactory;
-
-import com.sun.star.beans.XPropertySet;
-import com.sun.star.lang.XComponent;
-import com.sun.star.sheet.XLabelRanges;
-import com.sun.star.sheet.XSpreadsheetDocument;
-import com.sun.star.table.CellRangeAddress;
-import com.sun.star.uno.UnoRuntime;
-import com.sun.star.uno.XInterface;
-
-/**
-* Test for object which is represented by service
-* com.sun.star.sheet.LabelRanges. 
-* Object implements the following interfaces :
-* 
-*   com::sun::star::sheet::XLabelRanges
-*   com::sun::star::container::XIndexAccess
-*   com::sun::star::container::XElementAccess
-* 
-* @see com.sun.star.sheet.LabelRanges
-* @see com.sun.star.sheet.XLabelRanges
-* @see com.sun.star.container.XIndexAccess
-* @see com.sun.star.container.XElementAccess
-* @see ifc.sheet._XLabelRanges
-* @see ifc.container._XIndexAccess
-* @see ifc.container._XElementAccess
-*/
-public class ScLabelRangesObj extends TestCase {
-private XSpreadsheetDocument xSheetDoc = null;
-
-/**
-* Creates Spreadsheet document.
-*/
-@Override
-protected void initialize( TestParameters tParam, PrintWriter log ) throws 
Exception {
-// get a soffice factory object
-SOfficeFactory SOF =

[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #173 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/184d0c4baf3862bddf735aa416d219b83c6da421%5E%21

tdf#45904 Move XIndexAccess Java tests to C++

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: qadevOOo/objdsc sc/qa

2018-12-02 Thread Libreoffice Gerrit user

 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScLabelRangesObj.csv |2 -
 sc/qa/extras/sclabelrangesobj.cxx|   11 
--
 2 files changed, 9 insertions(+), 4 deletions(-)

New commits:
commit 184d0c4baf3862bddf735aa416d219b83c6da421
Author: Jens Carl 
AuthorDate: Sun Dec 2 18:13:40 2018 +
Commit: Jens Carl 
CommitDate: Mon Dec 3 07:20:03 2018 +0100

tdf#45904 Move XIndexAccess Java tests to C++

Move XIndexAccess Java tests to C++ for ScLabelRangesObj.

Change-Id: I448561be2395beb9448ffcfc29434a94468166cb
Reviewed-on: https://gerrit.libreoffice.org/64431
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScLabelRangesObj.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScLabelRangesObj.csv
index 62e3ab113118..c814454c7897 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScLabelRangesObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScLabelRangesObj.csv
@@ -1,4 +1,2 @@
-"ScLabelRangesObj";"com::sun::star::container::XIndexAccess";"getCount()"
-"ScLabelRangesObj";"com::sun::star::container::XIndexAccess";"getByIndex()"
 
"ScLabelRangesObj";"com::sun::star::container::XElementAccess";"getElementType()"
 "ScLabelRangesObj";"com::sun::star::container::XElementAccess";"hasElements()"
diff --git a/sc/qa/extras/sclabelrangesobj.cxx 
b/sc/qa/extras/sclabelrangesobj.cxx
index 44e05c8ef7a0..fefba462d117 100644
--- a/sc/qa/extras/sclabelrangesobj.cxx
+++ b/sc/qa/extras/sclabelrangesobj.cxx
@@ -9,6 +9,7 @@
 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -16,9 +17,9 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
-#include 
 
 using namespace css;
 using namespace css::uno;
@@ -28,6 +29,7 @@ namespace sc_apitest
 {
 class ScLabelRangesObj : public CalcUnoApiTest,
  public apitest::XEnumerationAccess,
+ public apitest::XIndexAccess,
  public apitest::XLabelRanges
 {
 public:
@@ -42,6 +44,10 @@ public:
 // XEnumerationAccess
 CPPUNIT_TEST(testCreateEnumeration);
 
+// XIndexAccess
+CPPUNIT_TEST(testGetByIndex);
+CPPUNIT_TEST(testGetCount);
+
 // XLabelRanges
 CPPUNIT_TEST(testAddNew);
 CPPUNIT_TEST(testRemoveByIndex);
@@ -54,6 +60,7 @@ private:
 
 ScLabelRangesObj::ScLabelRangesObj()
 : CalcUnoApiTest("/sc/qa/extras/testdocuments")
+, XIndexAccess(1)
 {
 }
 
@@ -87,7 +94,7 @@ void ScLabelRangesObj::tearDown()
 
 CPPUNIT_TEST_SUITE_REGISTRATION(ScLabelRangesObj);
 
-} // end namespace
+} // namespace sc_apitest
 
 CPPUNIT_PLUGIN_IMPLEMENT();
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 119949] Filter broken by blank line

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=119949

Dan Dascalescu  changed:

   What|Removed |Added

 Resolution|NOTABUG |---
 Ever confirmed|0   |1
 Status|RESOLVED|REOPENED

--- Comment #5 from Dan Dascalescu  ---
Just ran into this issue again, and would like to ask for a 3rd party opinion.
Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121852] Accelerator shortcut keys for recent files no longer work

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121852

--- Comment #5 from Dan Dascalescu  ---
(In reply to Durgapriyanka from comment #4)
> Cannot reproduce the bug in (en_US)
> 
> Version: 6.0.6.2
> Build ID: 0c292870b25a325b5ed35f6b45599d2ea4458e77
> CPU threads: 2; OS: Windows 6.1; UI render: default; 

Thanks for testing on Windows. I see the bug on Ubuntu.

Here's an exact sequence of key presses after launching Calc:

Alt+F
u
1

Result: nothing happens.
Expected result: the first recent document should open.

If I press right arrow while after the Recent Documents menu expands, then the
1, 2, 3, ... accelerators do work. So this key sequence does open the most
recent document in LibreCalc 6.2 on Ubuntu en_US:

Alt+F
u
Right arrow
1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84837] Make show/hide comments UNO command work in Calc

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=84837

Robert Beyer  changed:

   What|Removed |Added

 OS|All |Windows (All)
URL||https://www.hpsupportasista
   ||nt.com/
   Assignee|gulsah.1...@gmail.com   |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #110 from Robert Beyer  ---
HP Support Assistant comes preinstalled in most of the HP laptops and computers
and it auto-fixes many issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121126] can't open files with Cyrillic (Russian) file names

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121126

--- Comment #2 from muhammadmur...@list.ru ---
Hello.
I did 
root@ubuntu-server:~# update-locale LANG=C.UTF-8
then reboot. 
root@ubuntu-server:~# locale
LANG=C.UTF-8
The problem stays:
Dec  3 10:04:06 ubuntu-server loolwsd[1090]: kit-02223-02231 2018-12-03
05:04:06.101669 [ lokit_006 ] ERR  Failed to load:
file:///user/docs/YiZb8BVbc85mdLbt/%D0%A2%D0%B5%D1%81%D1%82.odt, error:
Unsupported URL
: "type
detection failed"| kit/Kit.cpp:1554
Dec  3 10:04:06 ubuntu-server loolwsd[1090]: kit-02223-02231 2018-12-03
05:04:06.102098 [ lokit_006 ] ERR  Failed to get LoKitDocument instance for
[file:///user/docs/YiZb8BVbc85mdLbt/%D0%A2%D0%B5%D1%81%D1%82.odt].|
kit/ChildSession.cpp:370

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112458] Base table does not retain record updates from Standalone form

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112458

--- Comment #18 from Terrence Enger  ---
Created attachment 147232
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147232=edit
bibisect in till53 repo, tail of terminal output

I now think I see that behaviour deteriorated in two steps:

(1) To close LibreOffice directly from the form loses changes, but
changes persist after closing the form window and then closing
LibreOffice from Start Center.  Comment 11 reports my results
bibisecting this problem.

(2) Additionally, to close the form window and then closing
LibreOffice from Start Center loses change.  This is what robert
reports in comment 17.

Working on debian-buster in the till53 bibisect repository, I see that
bug (2) entered LibreOffice in the 57 or so source commits
.

To summarize:

changes ...   commitdates-h
    --  
persist   567a8477  2015-08-03  71ace488
persist if close LO directly  b6f9394f  2015-08-04  cd6c9aef
persist if close LO directly  8bb36bab  2016-10-10  8bfbd7fb
lost either way   49fe466f  2016-10-11  e2f6c7f0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67770] CONFIGURATION: Sidebar customization settings not remembered after reopening

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=67770

--- Comment #43 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95927] Search for format does not work

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95927

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113881] Missing scrollbar in the "Navigator" sidebar in Writer

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113881

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63567] EDITING: no spellcheck suggestions for typos in comments

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=63567

--- Comment #9 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107569] Missing tango icon

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107569

--- Comment #28 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98331] FILEOPEN: missing table rows in a .doc file

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98331

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111825] Import from xlsx has wrong scaling of deep 3D column chart

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=111825

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95430] Embedded VISIO object is zoomed and can't be zoomed out

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95430

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38779] Position of text boxes not retained when opening MS Office .doc files FORMATTING problem

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=38779

--- Comment #18 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80543] SIDEBAR: Paragraph Property panel keyboard navigation hangs at the horizontalalignment toolbox--when AT has been activated (a11y)

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=80543

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72438] LibreLogo: icons in Logo toolbar replaced by text only

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=72438

--- Comment #19 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 64370] Templates with Different File Name but Same Title are not Displayed in Template Manager

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=64370

--- Comment #12 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39102] Object anchor displayed outside the page area

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=39102

--- Comment #19 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105731] RTF import gets indent wrong, mostly negative, in lines that contain numbering or bullets

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105731

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 37755] FORMAT: formats genering text strings (from cell content) doesn't adhere to text alignment format.

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=37755

--- Comment #13 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114063] FORMCONTROLS: No group borders in pdf fillable forms

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114063

--- Comment #5 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114069] Image bullets should have string names that are translatable

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114069

--- Comment #3 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95666] UI - Display glitches after resizing macro editor window

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95666

--- Comment #11 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 37604] LO loses graphics copied from a web page behind proxy with authentication

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=37604

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113994] qt5 VCL plugin crashes on startup

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113994

--- Comment #9 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89984] SIDEBAR: Inconsistent resizing behaviour in the sidebar

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=89984

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114167] Print preview glitches when trying to show page that disappears for printing

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114167

--- Comment #2 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97427] After closing a comment mouse cursor is incorrect

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97427

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89300] DIALOG: File -> Save As... has dialog titled 'Save'

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=89300

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 77141] leaks a fd on closed odb: locks file on Windows share

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=77141

--- Comment #22 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111949] MAILMERGE: Wizards 3rd step page should change title according to the document type selected in 2nd step

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=111949

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102046] Split and group buttons not exposed correctly on Linux

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102046

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121875] Hyperlinks to IDN websites are broken

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121875

--- Comment #1 from muso  ---
Created attachment 147231
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147231=edit
ODT file showing the bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121875] New: Hyperlinks to IDN websites are broken

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121875

Bug ID: 121875
   Summary: Hyperlinks to IDN websites are broken
   Product: LibreOffice
   Version: 6.1.3.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: uwesto...@web.de

Description:
Hyperlinks to IDN websites are broken

Steps to Reproduce:
1. insert a hyperlink to a website of your choice that contains non-ASCII
characters (Internationalized domain name, IDN)
2. try to Ctrl+click on the link to get to the website

result: LO issues an error of a missing file despite the link is no file link
but a weblink. The bug is definitively that LO doesn't handle the non-ASCII
character not correctly in the URL field. See also the attached simple example
file.

IDNs are already widely supported thus LO should support them too because they
become more and more popular.


Actual Results:


Expected Results:



Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121028] Table background bitmap replaced Painted White when changing the border color

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121028

--- Comment #14 from Jim Raykowski  ---
Here is a code pointer to why the bitmap is not re-selected:

https://opengrok.libreoffice.org/xref/core/svx/source/unodraw/unobrushitemhelper.cxx#66

There seems not to be a method to retrieve the name of the bitmap from the
graphic object so it is always set to empty string.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: chart2/source

2018-12-02 Thread Libreoffice Gerrit user

 chart2/source/model/main/ChartModel_Persistence.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit a0ac944bb3faf5bf11966215fbdeb247c8f405d7
Author: Mike Kaganski 
AuthorDate: Wed Nov 21 10:32:28 2018 +0100
Commit: Mike Kaganski 
CommitDate: Mon Dec 3 03:46:26 2018 +0100

Fix JunitTest_chart2_unoapi failing DBG_TESTSOLARMUTEX on Windows

The failing call stack:

ucrtbased.dll!issue_debug_notification(const wchar_t * const message)
Line 28
at 
minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(28)
ucrtbased.dll!__acrt_report_runtime_error(const wchar_t * message) Line 154
at 
minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(154)
ucrtbased.dll!abort() Line 61
at minkernel\crts\ucrt\src\appcrt\startup\abort.cpp(61)
ucrtbased.dll!common_assert_to_stderr(const wchar_t * const
expression, const wchar_t * const file_name, const unsigned int
line_number) Line 187
at minkernel\crts\ucrt\src\appcrt\startup\assert.cpp(187)
ucrtbased.dll!common_assert(const wchar_t * const expression,
const wchar_t * const file_name, const unsigned int line_number, void *
const return_address) Line 420
at minkernel\crts\ucrt\src\appcrt\startup\assert.cpp(420)
ucrtbased.dll!_wassert(const wchar_t * expression, const wchar_t *
file_name, unsigned int line_number) Line 444
at minkernel\crts\ucrt\src\appcrt\startup\assert.cpp(444)
vcllo.dll!ImplDbgTestSolarMutex() Line 46
at c:\lo\src\core\vcl\source\app\dbggui.cxx(46)
tllo.dll!DbgTestSolarMutex() Line 78
at c:\lo\src\core\tools\source\debug\debug.cxx(78)
vcllo.dll!OpenGLSalBitmap::Create(const Size & rSize, unsigned short
nBits, const BitmapPalette & rBitmapPalette) Line 164
at c:\lo\src\core\vcl\opengl\salbmp.cxx(164)
vcllo.dll!Bitmap::Bitmap(const Size & rSizePixel, unsigned short
nBitCount, const BitmapPalette * pPal) Line 108
at c:\lo\src\core\vcl\source\bitmap\bitmap.cxx(108)
vcllo.dll!o3tl::make_unique(Size &
, unsigned short & ) Line 29
at c:\lo\src\core\include\o3tl\make_unique.hxx(29)
vcllo.dll!vcl::PNGReaderImpl::ImplReadHeader(const Size &
rPreviewSizeHint) Line 665
at c:\lo\src\core\vcl\source\gdi\pngread.cxx(665)
vcllo.dll!vcl::PNGReaderImpl::GetBitmapEx(const Size & rPreviewSizeHint)
Line 342
at c:\lo\src\core\vcl\source\gdi\pngread.cxx(342)
vcllo.dll!vcl::PNGReader::Read(const Size & i_rPreviewSizeHint) Line 1732
at c:\lo\src\core\vcl\source\gdi\pngread.cxx(1732)
vcllo.dll!GraphicFilter::ImportGraphic(Graphic & rGraphic, const
rtl::OUString & rPath, SvStream & rIStream, unsigned short nFormat,
unsigned short * pDeterminedFormat, GraphicFilterImportFlags
nImportFlags,
com::sun::star::uno::Sequence *
pFilterData, const WmfExternal * pExtHeader) Line 1813
at c:\lo\src\core\vcl\source\filter\graphicfilter.cxx(1813)
vcllo.dll!GraphicFilter::ImportGraphic(Graphic & rGraphic, const
rtl::OUString & rPath, SvStream & rIStream, unsigned short nFormat,
unsigned short * pDeterminedFormat, GraphicFilterImportFlags
nImportFlags, const WmfExternal * pExtHeader) Line 1281
at c:\lo\src\core\vcl\source\filter\graphicfilter.cxx(1281)
vcllo.dll!GraphicFilter::FilterCallback(ConvertData & rData) Line 2509
at c:\lo\src\core\vcl\source\filter\graphicfilter.cxx(2509)
vcllo.dll!GraphicFilter::LinkStubFilterCallback(void * instance,
ConvertData & data) Line 2481
at c:\lo\src\core\vcl\source\filter\graphicfilter.cxx(2481)
sofficeapp.dll!Link::Call(ConvertData & data) Line 84
at c:\lo\src\core\include\tools\link.hxx(84)
sofficeapp.dll!desktop::Desktop::ImplInitFilterHdl(desktop::Desktop *
__formal, ConvertData & rData) Line 1752
at c:\lo\src\core\desktop\source\app\app.cxx(1752)
sofficeapp.dll!desktop::Desktop::LinkStubImplInitFilterHdl(void *
instance, ConvertData & data) Line 1749
at c:\lo\src\core\desktop\source\app\app.cxx(1749)
vcllo.dll!Link::Call(ConvertData & data) Line 84
at c:\lo\src\core\include\tools\link.hxx(84)
vcllo.dll!GraphicConverter::Import(SvStream & rIStm, Graphic & rGraphic,
ConvertDataFormat nFormat) Line 44
at c:\lo\src\core\vcl\source\gdi\cvtgrf.cxx(44)
chartcorelo.dll!chart::ChartModel::impl_loadGraphics(const
com::sun::star::uno::Reference &
xStorage) Line 621
at 
c:\lo\src\core\chart2\source\model\main\chartmodel_persistence.cxx(621)
chartcorelo.dll!chart::ChartModel::impl_load(const
com::sun::star::uno::Sequence &
rMediaDescriptor, const
com::sun::star::uno::Reference &
xStorage) Line 576
at 
c:\lo\src\core\chart2\source\model\main\chartmodel_persistence.cxx(576)

[Libreoffice-bugs] [Bug 103303] [META] Desktop integration bugs and enhancements

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103303
Bug 103303 depends on bug 113475, which changed state.

Bug 113475 Summary: Libreoffice main icon appears dock/launcher instead of 
module app icons in Ubuntu 17.10
https://bugs.documentfoundation.org/show_bug.cgi?id=113475

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTOURBUG   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113475] Libreoffice main icon appears dock/launcher instead of module app icons in Ubuntu 17.10

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113475

Dan Dascalescu  changed:

   What|Removed |Added

 Resolution|NOTOURBUG   |---
 Status|RESOLVED|REOPENED

--- Comment #9 from Dan Dascalescu  ---
I have the same problem with v6.2 dev on Ubuntu 16, installed alongside 5.4
stable.

I've installed the 6.2 .deb packages from
https://www.libreoffice.org/download/download/?type=deb-x86_64=6.2.0=en-US
by running `sudo dpkg -i *.deb`.

The icons show correctly the dash, but in the taskbar I see the generic
question mark icon.

LibreOffice 5.4 icons show correctly in both locations.

LibreOffice 6.2 .desktop files appear to be correctly installed in
/opt/libreofficedev6.2/share/xdg and symlinked from /usr/share/applications.

What can I do? Should we officially document this situation somewhere, since
I'm not alone? I found random answers online for other versions of LO, but
official guidance would be great:

* https://ubuntuforums.org/showthread.php?t=1795260
*
https://askubuntu.com/questions/763335/how-do-i-get-the-right-libreoffice-calc-icon-into-the-launcher

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: solenv/clang-format

2018-12-02 Thread Libreoffice Gerrit user

 solenv/clang-format/blacklist |2 --
 1 file changed, 2 deletions(-)

New commits:
commit 06b1e244ff9502664fe79dc27346e4fd9968afbc
Author: Jens Carl 
AuthorDate: Sun Dec 2 00:30:32 2018 +
Commit: Jens Carl 
CommitDate: Mon Dec 3 03:40:44 2018 +0100

test: enable clang-format for xindexaccess

Accidentally formatted the files with commit
d0a6f8a8e862bede67989cd3fac105d7c8231eb0. Might just enable them.

Change-Id: I2f017a17d29f63721be10eb3bff388ed1a5a49bb
Reviewed-on: https://gerrit.libreoffice.org/64418
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/solenv/clang-format/blacklist b/solenv/clang-format/blacklist
index 92aab89287bf..0b421e3d00ac 100644
--- a/solenv/clang-format/blacklist
+++ b/solenv/clang-format/blacklist
@@ -7576,7 +7576,6 @@ include/test/beans/xpropertyset.hxx
 include/test/bootstrapfixture.hxx
 include/test/calc_unoapi_test.hxx
 include/test/callgrind.hxx
-include/test/container/xindexaccess.hxx
 include/test/container/xnamecontainer.hxx
 include/test/container/xnamed.hxx
 include/test/container/xnamereplace.hxx
@@ -16567,7 +16566,6 @@ test/source/beans/xpropertyset.cxx
 test/source/bootstrapfixture.cxx
 test/source/calc_unoapi_test.cxx
 test/source/callgrind.cxx
-test/source/container/xindexaccess.cxx
 test/source/container/xnamecontainer.cxx
 test/source/container/xnamed.cxx
 test/source/container/xnamereplace.cxx
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 121727] Security: Hangs if I open a .doc file with a virus (as marco?) even if macros are disabled

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121727

--- Comment #2 from LFlo  ---
Can I get at least a security email address where I can send the malware to? I
don't want it to be available in the public bugtracker...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121727] Security: Hangs if I open a .doc file with a virus (as marco?) even if macros are disabled

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121727

--- Comment #1 from LFlo  ---
Sooo, nobody is interested in this issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116078] OpenPGP, X.509 and digital signatures documentation

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=116078

Olivier Hallot  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |olivier.hallot@documentfoun
   |desktop.org |dation.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 11 commits - cppuhelper/GoogleTest_cppuhelper_ifcontainer.mk cppuhelper/GoogleTest_cppuhelper_unourl.mk cppuhelper/Library_cppuhelper.mk cppuhelper

2018-12-02 Thread Libreoffice Gerrit user

 cppuhelper/GoogleTest_cppuhelper_ifcontainer.mk |   48 +++
 cppuhelper/GoogleTest_cppuhelper_unourl.mk  |   43 +++
 cppuhelper/Library_cppuhelper.mk|  173 +
 cppuhelper/Makefile |   32 ++
 cppuhelper/Module_cppuhelper.mk |   37 ++
 cppuhelper/Package_findsofficepath.mk   |   31 ++
 cppuhelper/Package_inc.mk   |   80 ++
 cppuhelper/Package_unorc.mk |   28 ++
 cppuhelper/source/msvc_win32_intel.map  |  305 
 curl/makefile.mk|5 
 sc/source/ui/src/scfuncs.src|2 
 solenv/gbuild/platform/windows.mk   |5 
 tools/inc/tools/debug.hxx   |   14 -
 tools/source/debug/debug.cxx|   12 
 tools/source/rc/resmgr.cxx  |4 
 vcl/source/gdi/outdev3.cxx  |5 
 16 files changed, 499 insertions(+), 325 deletions(-)

New commits:
commit 2463de78beeff993952e2950aa7dceeed050aaac
Author: Matthias Seidel 
AuthorDate: Sun Dec 2 11:33:56 2018 +
Commit: Matthias Seidel 
CommitDate: Sun Dec 2 11:33:56 2018 +

i123192 - Word Count Dialog: last digit truncated at the right

Patch by: hanya

Thank you for your contribution!

diff --git a/vcl/source/gdi/outdev3.cxx b/vcl/source/gdi/outdev3.cxx
index 2657f23e4970..3b9f42a135a3 100644
--- a/vcl/source/gdi/outdev3.cxx
+++ b/vcl/source/gdi/outdev3.cxx
@@ -6792,10 +6792,10 @@ Rectangle OutputDevice::GetTextRect( const Rectangle& 
rRect,
 else if ( nStyle & TEXT_DRAW_CENTER )
 {
 aRect.Left() += (nWidth-nMaxWidth)/2;
-aRect.Right() = aRect.Left()+nMaxWidth-1;
+aRect.Right() = aRect.Left()+nMaxWidth;
 }
 else
-aRect.Right() = aRect.Left()+nMaxWidth-1;
+aRect.Right() = aRect.Left()+nMaxWidth;
 
 if ( nStyle & TEXT_DRAW_BOTTOM )
 aRect.Top() = aRect.Bottom()-(nTextHeight*nLines)+1;
@@ -6807,7 +6807,6 @@ Rectangle OutputDevice::GetTextRect( const Rectangle& 
rRect,
 else
 aRect.Bottom() = aRect.Top()+(nTextHeight*nLines)-1;
 
-aRect.Right()++; // #99188# get rid of rounding problems when using this 
rect later
 return aRect;
 }
 
commit 5bab9af0eef386978f073ca04a2e478b157aee63
Author: Damjan Jovanovic 
AuthorDate: Sun Dec 2 05:57:21 2018 +
Commit: Damjan Jovanovic 
CommitDate: Sun Dec 2 05:57:21 2018 +

Revert the main/cppuhelper symbol visibility changes

in 1847839 and 1847840 for now, as they break the Windows build in the most
mysterious ways...

Patch by: me

diff --git a/cppuhelper/inc/cppuhelper/access_control.hxx 
b/cppuhelper/inc/cppuhelper/access_control.hxx
index 54964ec87ef2..53afcdd783ef 100644
--- a/cppuhelper/inc/cppuhelper/access_control.hxx
+++ b/cppuhelper/inc/cppuhelper/access_control.hxx
@@ -26,15 +26,13 @@
 #include 
 #include 
 
-#include "cppuhelper/cppuhelperdllapi.h"
-
 
 namespace cppu
 {
 
 /** Helper class retriving access controller singleton from component context.
 */
-class CPPUHELPER_DLLPUBLIC AccessControl
+class AccessControl
 {
 ::com::sun::star::uno::Reference< 
::com::sun::star::security::XAccessController > m_xController;
 
diff --git a/cppuhelper/inc/cppuhelper/bootstrap.hxx 
b/cppuhelper/inc/cppuhelper/bootstrap.hxx
index 2b28624620b5..e222164f1b36 100644
--- a/cppuhelper/inc/cppuhelper/bootstrap.hxx
+++ b/cppuhelper/inc/cppuhelper/bootstrap.hxx
@@ -29,8 +29,6 @@
 #include "rtl/ustring.hxx"
 #include "sal/types.h"
 
-#include "cppuhelper/cppuhelperdllapi.h"
-
 namespace com { namespace sun { namespace star {
 namespace container { class XHierarchicalNameAccess; }
 namespace registry { class XSimpleRegistry; }
@@ -45,7 +43,6 @@ namespace cppu
 @rBootstrapPath optional bootstrap path for initial components
 @return simple registry service instance
 */
-CPPUHELPER_DLLPUBLIC
 ::com::sun::star::uno::Reference< ::com::sun::star::registry::XSimpleRegistry >
 SAL_CALL createSimpleRegistry(
 const ::rtl::OUString & rBootstrapPath = ::rtl::OUString() )
@@ -56,7 +53,6 @@ SAL_CALL createSimpleRegistry(
 @rBootstrapPath optional bootstrap path for initial components
 @return nested registry service instance
 */
-CPPUHELPER_DLLPUBLIC
 ::com::sun::star::uno::Reference< ::com::sun::star::registry::XSimpleRegistry >
 SAL_CALL createNestedRegistry(
 const ::rtl::OUString & rBootstrapPath = ::rtl::OUString() )
@@ -67,7 +63,6 @@ SAL_CALL createNestedRegistry(
 @param xTDMgr manager instance
 @return true, if successfully registered
 */
-CPPUHELPER_DLLPUBLIC
 sal_Bool SAL_CALL installTypeDescriptionManager(
 ::com::sun::star::uno::Reference< 
::com::sun::star::container::XHierarchicalNameAccess > const & xTDMgr )
 SAL_THROW( () );
@@ -83,7 +78,6 @@ sal_Bool SAL_CALL installTypeDescriptionManager(
 @param rBootstrapPath optional bootstrap path for

[Libreoffice-commits] core.git: extensions/source

2018-12-02 Thread Libreoffice Gerrit user

 extensions/source/activex/so_activex.cxx |  686 +++
 1 file changed, 346 insertions(+), 340 deletions(-)

New commits:
commit aa4427f3f149b709cd95b3feb14c4f386f5d9e51
Author: Mike Kaganski 
AuthorDate: Sun Dec 2 15:56:58 2018 +0300
Commit: Mike Kaganski 
CommitDate: Mon Dec 3 01:20:48 2018 +0100

Let so_activex learn to work with Win32 errors and HRESULT properly

Previous code made ~no sense from error handling PoV. Closing registry
keys could be skipped because of prior errors; booleans were cast to
HRESULT to be checked later using SUCCEEDED macro.

Change-Id: I0735ab7e2f3b29682ab19adb0e96a581e997b8b5
Reviewed-on: https://gerrit.libreoffice.org/64425
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/extensions/source/activex/so_activex.cxx 
b/extensions/source/activex/so_activex.cxx
index 5935af977437..d5b4622f1e9b 100644
--- a/extensions/source/activex/so_activex.cxx
+++ b/extensions/source/activex/so_activex.cxx
@@ -50,6 +50,7 @@
 #include "SOActiveX.h"
 
 #include 
+#include 
 
 CComModule _Module;
 
@@ -123,6 +124,51 @@ STDAPI DllGetClassObject(REFCLSID rclsid, REFIID riid, 
LPVOID* ppv)
 
 // DllRegisterServer - Adds entries to the system registry
 
+namespace
+{
+// Wraps an updatable Win32 error; keeps first incoming error.
+// Ctor defines if upd will throw std::exception on error or
+// return false.
+class Status
+{
+public:
+explicit Status(bool bTrow)
+: m_bThrow(bTrow)
+{
+}
+// used to check success of an operation, and update the status if it's 
still ERROR_SUCCESS
+bool upd(LSTATUS nNewStatus)
+{
+if (m_nStatus == ERROR_SUCCESS)
+m_nStatus = nNewStatus;
+if (m_bThrow && nNewStatus != ERROR_SUCCESS)
+throw std::exception();
+return nNewStatus == ERROR_SUCCESS;
+};
+LSTATUS get() { return m_nStatus; }
+operator bool() { return m_nStatus == ERROR_SUCCESS; }
+
+private:
+LSTATUS m_nStatus = ERROR_SUCCESS;
+const bool m_bThrow;
+};
+
+class HRegKey
+{
+public:
+~HRegKey()
+{
+if (m_hkey)
+RegCloseKey(m_hkey);
+}
+PHKEY operator&() { return _hkey; }
+operator HKEY() { return m_hkey; }
+
+private:
+HKEY m_hkey = nullptr;
+};
+}
+
 // for now database component and chart are always installed
 #define SUPPORTED_EXT_NUM 30
 const char* const aFileExt[] = { ".vor",
@@ -194,199 +240,216 @@ const char* const aProxyStubActApprove = 
"{00020424---C000-0046}
 // The following prefix is required for HKEY_LOCAL_MACHINE and 
HKEY_CURRENT_USER ( not for HKEY_CLASSES_ROOT )
 const char* const aLocalPrefix = "Software\\Classes\\";
 
-static BOOL createKey( HKEY hkey,
+static LSTATUS createKey( HKEY hkey,
 const char* aKeyToCreate,
 REGSAM nKeyAccess,
 const char* aValue = nullptr,
 const char* aChildName = nullptr,
 const char* aChildValue = nullptr )
 {
-HKEY hkey1;
-
-return ( ERROR_SUCCESS == RegCreateKeyExA( hkey, aKeyToCreate, 0, nullptr, 
REG_OPTION_NON_VOLATILE, nKeyAccess, nullptr,  , nullptr )
-   && ( !aValue || ERROR_SUCCESS == RegSetValueExA( hkey1,
-   "",
-   0,
-   REG_SZ,
-   reinterpret_cast(aValue),
-   sal::static_int_cast(strlen(aValue
-   && ( !aChildName || ERROR_SUCCESS == RegSetValueExA( hkey1,
-   aChildName,
-   0,
-   REG_SZ,
-   reinterpret_cast(aChildValue),
-   sal::static_int_cast(strlen(aChildValue
-   && ERROR_SUCCESS == RegCloseKey( hkey1 ) );
-
+Status s(false); // no throw
+HRegKey hkey1;
+if (s.upd(RegCreateKeyExA(hkey, aKeyToCreate, 0, nullptr, 
REG_OPTION_NON_VOLATILE, nKeyAccess,
+  nullptr, , nullptr)))
+{
+if (aValue)
+s.upd(RegSetValueExA(hkey1, "", 0, REG_SZ, reinterpret_cast(aValue),
+ sal::static_int_cast(strlen(aValue;
+if (aChildName)
+s.upd(RegSetValueExA(hkey1, aChildName, 0, REG_SZ,
+ reinterpret_cast(aChildValue),
+ 
sal::static_int_cast(strlen(aChildValue;
+}
+return s.get();
 }
 
-static BOOL createKey( HKEY hkey,
+static LSTATUS createKey(HKEY hkey,
 const wchar_t* aKeyToCreate,
 REGSAM nKeyAccess,
 const wchar_t* aValue = nullptr,
 const wchar_t* aChildName = nullptr,
 const wchar_t* aChildValue =

[Libreoffice-bugs] [Bug 120703] Bugs found by PVS-Studio static analyzer

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=120703

--- Comment #136 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/eddee22b0eed069c3ee2929c9b36a9b4fb05f130%5E%21

tdf#120703 PVS: V560 A part of conditional expression is always true/false

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120703] Bugs found by PVS-Studio static analyzer

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=120703

--- Comment #135 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/6ed52ecfed5781659cd27ff9aea5d0a04be77cd1%5E%21

tdf#120703 PVS: V560 A part of conditional expression is always true/false

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - cui/source dbaccess/source editeng/source framework/source sd/source starmath/source svx/source sw/source tools/source

2018-12-02 Thread Libreoffice Gerrit user

 cui/source/dialogs/SpellDialog.cxx |2 +-
 dbaccess/source/ui/tabledesign/TableController.cxx |   12 +++-
 editeng/source/misc/splwrap.cxx|4 ++--
 framework/source/services/substitutepathvars.cxx   |2 +-
 sd/source/core/stlfamily.cxx   |2 +-
 starmath/source/symbol.cxx |2 +-
 svx/source/dialog/svxbmpnumvalueset.cxx|4 ++--
 svx/source/svdraw/svdedtv.cxx  |2 +-
 svx/source/svdraw/svdedxv.cxx  |8 +---
 svx/source/svdraw/svdmrkv.cxx  |1 -
 svx/source/svdraw/svdograf.cxx |2 +-
 svx/source/svdraw/svdomeas.cxx |2 +-
 svx/source/table/svdotable.cxx |   20 
 svx/source/table/tablecontroller.cxx   |4 ++--
 sw/source/core/doc/swserv.cxx  |2 +-
 sw/source/core/docnode/swbaslnk.cxx|7 ++-
 sw/source/core/layout/tabfrm.cxx   |8 
 sw/source/filter/html/swhtml.cxx   |9 -
 sw/source/uibase/dochdl/swdtflvr.cxx   |2 +-
 tools/source/stream/stream.cxx |3 ---
 20 files changed, 41 insertions(+), 57 deletions(-)

New commits:
commit eddee22b0eed069c3ee2929c9b36a9b4fb05f130
Author: Mike Kaganski 
AuthorDate: Sun Dec 2 20:46:02 2018 +0300
Commit: Mike Kaganski 
CommitDate: Mon Dec 3 01:20:21 2018 +0100

tdf#120703 PVS: V560 A part of conditional expression is always true/false

Change-Id: Id7af9a6eaefc8b49a790eb299620c4fa97067a11
Reviewed-on: https://gerrit.libreoffice.org/64429
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/cui/source/dialogs/SpellDialog.cxx 
b/cui/source/dialogs/SpellDialog.cxx
index 42c6721b3ec8..f1bc5f8ae708 100644
--- a/cui/source/dialogs/SpellDialog.cxx
+++ b/cui/source/dialogs/SpellDialog.cxx
@@ -1838,7 +1838,7 @@ svx::SpellPortions 
SentenceEditWindow_Impl::CreateSpellPortions() const
 ++aCursor.GetIndex();
 }
 
-if(nTextLen && aBreakPositions.empty())
+if (aBreakPositions.empty())
 {
 //if all content has been overwritten the attributes may have been 
removed, too
 svx::SpellPortion aPortion1;
diff --git a/editeng/source/misc/splwrap.cxx b/editeng/source/misc/splwrap.cxx
index 1a4e8568351b..33328dda8d37 100644
--- a/editeng/source/misc/splwrap.cxx
+++ b/editeng/source/misc/splwrap.cxx
@@ -159,8 +159,8 @@ SvxSpellWrapper::SvxSpellWrapper( vcl::Window* pWn,
 bOtherCntnt ( bOther ),
 bHyphen ( false ),
 bReverse( false ),
-bStartDone  ( bOther || ( !bReverse && bStart ) ),
-bEndDone( bReverse && bStart && !bOther ),
+bStartDone  ( bOther || bStart ),
+bEndDone( false ),
 bStartChk   ( bOther ),
 bRevAllowed ( false ),
 bAllRight   ( true )
diff --git a/framework/source/services/substitutepathvars.cxx 
b/framework/source/services/substitutepathvars.cxx
index afa83643b87a..13dc84760517 100644
--- a/framework/source/services/substitutepathvars.cxx
+++ b/framework/source/services/substitutepathvars.cxx
@@ -345,7 +345,7 @@ OUString SubstitutePathVariables::impl_substituteVariable( 
const OUString& rText
 // Is there something to replace ?
 bool bWorkRetrieved   = false;
 bool bWorkDirURLRetrieved = false;
-while ( !bSubstitutionCompleted && nDepth < nMaxRecursiveDepth )
+while (nDepth < nMaxRecursiveDepth)
 {
 while ( ( nPosition != -1 ) && ( nLength > 3 ) ) // "$(" ")"
 {
diff --git a/sd/source/core/stlfamily.cxx b/sd/source/core/stlfamily.cxx
index 54680db5d510..62eab7b25e43 100644
--- a/sd/source/core/stlfamily.cxx
+++ b/sd/source/core/stlfamily.cxx
@@ -148,7 +148,7 @@ SdStyleSheet* SdStyleFamily::GetSheetByName( const 
OUString& rName )
 {
 // we assume that we have only SdStyleSheets
 SdStyleSheet* pSdStyle = static_cast< SdStyleSheet* >( pStyle 
);
-if( pSdStyle && pSdStyle->GetApiName() == rName)
+if (pSdStyle->GetApiName() == rName)
 {
 pRet = pSdStyle;
 break;
diff --git a/svx/source/dialog/svxbmpnumvalueset.cxx 
b/svx/source/dialog/svxbmpnumvalueset.cxx
index 5b6df74f9c68..017bc1dfb853 100644
--- a/svx/source/dialog/svxbmpnumvalueset.cxx
+++ b/svx/source/dialog/svxbmpnumvalueset.cxx
@@ -259,7 +259,7 @@ void  SvxNumValueSet::UserDraw( const UserDrawEvent& rUDEvt 
)
 sal_Int32 nLevelCount = xLevel->getCount();
 if(nLevelCount > 5)
 nLevelCount = 5;
-for( sal_Int32 i = 0; i < nLevelCount && i < 5; i++)
+for( sal_Int32 i = 0; i < nLevelCount; i++)
 {
 long nTop = nStartY + nRectHeight * (aLinesArr[2 * i +

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-5-2+backports' - sfx2/source

2018-12-02 Thread Libreoffice Gerrit user

 sfx2/source/doc/docfile.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit b7311a04807932a164ac891715e39314fa00fe81
Author: Michael Stahl 
AuthorDate: Sat Dec 1 11:26:03 2018 +0100
Commit: Thorsten Behrens 
CommitDate: Mon Dec 3 00:49:07 2018 +0100

sfx2: fix Android build, check HAVE_FEATURE_MULTIUSER_ENVIRONMENT

Change-Id: I2d78f35898cc514b20500018a7d360e3c78127aa
(cherry picked from commit 2452c3f008fa8cb4f4a88dace1c7d204f775d3f1)

diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index 89ccdfcecbab..0473f61397ee 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -166,10 +166,12 @@ bool IsLockingUsed()
 
 #endif
 
+#if HAVE_FEATURE_MULTIUSER_ENVIRONMENT
 bool IsWebDAVLockingUsed()
 {
 return officecfg::Office::Common::Misc::UseWebDAVFileLocking::get();
 }
+#endif
 
 } // anonymous namespace
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: failing tinderboxes after commit

2018-12-02 Thread Jan-Marek Glogowski

Am 2. Dezember 2018 23:14:03 MEZ schrieb Jim Raykowski :
>Hello All,
>
>I have recently been granted the great privilege to be part of the
>Commiters group on gerrit. I have notice each time I have committed a
>patch
>a tinder box failure occurs and a message is sent saying "One of you
>broke
>the build of LibreOffice with your commit :-( Please commit and push a
>fix
>ASAP!"
>
>All commits have been +1'd by Jenkins.
>
>So before I break the build again I would very much appreciate commit
>pointers.

Simply said: Tinderboxes run in a lot of more different setups then Jenkins; 
that's basically their whole point. There are many more options to build LO 
then Jenkins could ever test in a sensible amount of time - same for the OS 
setup.

So I guess you're just unlucky. Those mails contain a list of all patches since 
the last successful build. If you committed your patch after the build was 
already broken, you'll also get these mails. Not much to do about it, as the 
tinderbox just knows the hash of the last successful build. It will continue to 
build LO with new patches in the configured branch. At some point the build 
will probably be fixed and you won't get any more of these mails.

These mails also contain the failure information from the build. Can be a 
compiler, unit test, infrastructure, disc space or many other problems. 
Normally you should be able to see quickly, if your change might have been the 
origin of the problem or if you can ignore the mail.

HTH

Jan-Marek

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 2 commits - dbaccess/source dbaccess/uiconfig sc/source

2018-12-02 Thread Libreoffice Gerrit user

 dbaccess/source/ui/dlg/sqlmessage.cxx |6 ++
 dbaccess/uiconfig/ui/sqlexception.ui  |4 ++--
 sc/source/core/data/documen3.cxx  |4 
 3 files changed, 12 insertions(+), 2 deletions(-)

New commits:
commit 3abcd34f37b6aba5025631c64a49d4c8c34effd2
Author: Caolán McNamara 
AuthorDate: Sat Dec 1 20:16:16 2018 +
Commit: Caolán McNamara 
CommitDate: Mon Dec 3 00:43:12 2018 +0100

Resolves: tdf#121810 wrong column order

Change-Id: Ie82c47ea772b6eb5fc7b84426bb3c1cc98dc9c14
Reviewed-on: https://gerrit.libreoffice.org/64409
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/dbaccess/source/ui/dlg/sqlmessage.cxx 
b/dbaccess/source/ui/dlg/sqlmessage.cxx
index f1683f82f700..74b4f115e6ec 100644
--- a/dbaccess/source/ui/dlg/sqlmessage.cxx
+++ b/dbaccess/source/ui/dlg/sqlmessage.cxx
@@ -323,6 +323,12 @@ OExceptionChainDialog::OExceptionChainDialog(weld::Window* 
pParent, const Except
 
 lcl_insertExceptionEntry(*m_xExceptionList, m_aExceptions.size() - 1, 
aInfo22018);
 }
+
+if (m_xExceptionList->n_children())
+{
+m_xExceptionList->select(0);
+OnExceptionSelected(*m_xExceptionList);
+}
 }
 
 IMPL_LINK_NOARG(OExceptionChainDialog, OnExceptionSelected, weld::TreeView&, 
void)
diff --git a/dbaccess/uiconfig/ui/sqlexception.ui 
b/dbaccess/uiconfig/ui/sqlexception.ui
index 86521e0a9102..ef392f219271 100644
--- a/dbaccess/uiconfig/ui/sqlexception.ui
+++ b/dbaccess/uiconfig/ui/sqlexception.ui
@@ -4,10 +4,10 @@
   
   
 
-  
-  
   
   
+  
+  
   
   
 
commit 3aa48124342e737f2a11eef9473ebc33a3873820
Author: Caolán McNamara 
AuthorDate: Sun Dec 2 21:07:56 2018 +
Commit: Caolán McNamara 
CommitDate: Mon Dec 3 00:42:59 2018 +0100

ofz#11679 avoid config using path

Change-Id: I5629c4e0bbe29390db5350b05523409c48bbb84d
Reviewed-on: https://gerrit.libreoffice.org/64434
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/core/data/documen3.cxx b/sc/source/core/data/documen3.cxx
index e9dcf697e10d..615f79d85f9f 100644
--- a/sc/source/core/data/documen3.cxx
+++ b/sc/source/core/data/documen3.cxx
@@ -71,6 +71,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 using namespace com::sun::star;
@@ -558,6 +559,9 @@ bool ScDocument::LinkExternalTab( SCTAB& rTab, const 
OUString& aDocTab,
 return false;
 }
 rTab = 0;
+#if ENABLE_FUZZERS
+return false;
+#endif
 OUString  aFilterName; // Is filled by the Loader
 OUString  aOptions; // Filter options
 sal_uInt32 nLinkCnt = pExtDocOptions ? 
pExtDocOptions->GetDocSettings().mnLinkCnt : 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re:

2018-12-02 Thread Markus Mohrhard

Hey Jim,

On Sun, Dec 2, 2018 at 11:14 PM Jim Raykowski  wrote:

> Hello All,
>
> I have recently been granted the great privilege to be part of the
> Commiters group on gerrit. I have notice each time I have committed a patch
> a tinder box failure occurs and a message is sent saying "One of you broke
> the build of LibreOffice with your commit :-( Please commit and push a fix
> ASAP!"
>
> All commits have been +1'd by Jenkins.
>
> So before I break the build again I would very much appreciate commit
> pointers.
>

Great to see that you got commit access.

That mail is sent to anyone who has committed since the last time the
tinderbox succeeded. I think we still have one that fails quite regularly
and you can usually quickly check if there are only your commits and the
failure message looks related to your changes. More often than not the
message is sent to dozens of people either because the box is unreliable or
the box has not been updated to recent build requirements. Nevertheless,
please pay attention to the mail and always have a quick check (after some
time one sadly starts to ignore these mails).

Regards,
Markus

>
> Thank you,
> Jim
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 115643] Problems connecting to OneDrive and Google Drive

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115643

m.a.riosv  changed:

   What|Removed |Added

 CC||pmazzoni1...@live.it

--- Comment #9 from m.a.riosv  ---
*** Bug 121871 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121871] When attempt to Save on remote with Google drive the Calc program ask me one 6 digit pin

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121871

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE
 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
This is already in
https://bugs.documentfoundation.org/show_bug.cgi?id=115643#c6

*** This bug has been marked as a duplicate of bug 115643 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108897] [META] XLSX (OOXML) bug tracker

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108897

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||121715


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121715
[Bug 121715] FILEOPEN XLSX First page header changes to default header
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121715] FILEOPEN XLSX First page header changes to default header

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121715

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||108897


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108897
[Bug 108897] [META] XLSX (OOXML) bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108897] [META] XLSX (OOXML) bug tracker

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108897

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||121717


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121717
[Bug 121717] FILEOPEN XLSX Size of header changes when the document is opened
in Calc
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121717] FILEOPEN XLSX Size of header changes when the document is opened in Calc

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121717

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||108897


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108897
[Bug 108897] [META] XLSX (OOXML) bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121718] FILESAVE XLSX Header page number changes after exported

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121718

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks|114039  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114039
[Bug 114039] [META] Field dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114039] [META] Field dialog bugs and enhancements

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114039

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||121718


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121718
[Bug 121718] FILESAVE XLSX Header page number changes after exported
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121718] FILESAVE XLSX Header page number changes after exported

2018-12-02 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=121718

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||114039, 108897


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108897
[Bug 108897] [META] XLSX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=114039
[Bug 114039] [META] Field dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

1 2 3 >

1 - 100 of 249 matches

Mail list logo