[Libreoffice-bugs] [Bug 98545] Digital signature with elliptic curve certificate not working

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98545

Miklos Vajna  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |vmik...@collabora.com
   |desktop.org |

--- Comment #5 from Miklos Vajna  ---
https://vmiklos.hu/blog/xmlsec-cng-ecsa.html LO 6.2 is meant to accept ECDSA
certificates on Windows, I implemented the certificate chooser support for that
in commit 93e33ba279e837356e157745177d7f6061d442b7. I did not mention this bug
in the commit message as I forgot that this was already reported. So let's mark
this as resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105605] [META] Digital signatures bugs and enhancements

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105605
Bug 105605 depends on bug 98545, which changed state.

Bug 98545 Summary: Digital signature with elliptic curve certificate not working
https://bugs.documentfoundation.org/show_bug.cgi?id=98545

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122779] New: FILEOPEN (BASE) Connection to Oracle DB via ODBC ends in [ODBC][ORACLE] Optional Feature not implemented

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122779

Bug ID: 122779
   Summary: FILEOPEN (BASE) Connection to Oracle DB via ODBC ends
in [ODBC][ORACLE] Optional Feature not implemented
   Product: LibreOffice
   Version: 6.2.0.2 rc
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: thierry.meni...@ptp-industry.com

Created attachment 148384
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148384=edit
Screen captures of error and LibO "About"

I had been using for a long time a connection to Oracle Database data through
Base using the Oracle ODBC Driver and this was perfectly working until I
updated to LibreOffice 6.2 (Orignally 6.2.1 and now 6.2.2 but does not change
result).
I tried to return to LibreOffice 6.1.4 (before installing 6.2, I was running
6.1.2) but, unfortunately any call to display a table, a view or a query ends
up with message [ODBC][ORACLE] Optional Feature not implemented.
Error displayed is HYC00.
I tried to reset my UserProfile but no improvement.

I underline that the ODBC driver is fully operational when used from other
Windows apllications like MS Excel or MS Access.

I tried to re-create a new Oracle ODBC linkage and connect through it but same
message appear. Curiously, when testing connection from my Base File properties
menu, test is OK.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: Problems with custom-shape path commando angle-ellipseto

2019-01-16 Thread Miklos Vajna
Hi Regina,

On Tue, Jan 15, 2019 at 02:04:05PM +0100, Regina Henschel 
 wrote:
> Oh, I have forgotten to tell, which apps I already use for testing:
> I have got MS Office 365 and use it regularly for testing.
> Google Docs: Import test possible; export not helpful because they use
> LibreOffice as generator.
> Calligra Karbon: in VM with Ubuntu. Other apps for Linux? I'm not familiar
> with Linux.
> Inkscape has .odg export, but has no handles and exports path; no import.
> Scribus has .odg, .odp, .fodg, and .fodp import, but has no handles; no
> export.
> SoftMaker has ODF support only for text documents.
> 
> Any other apps you know?

Oh wow, that's a list much longer than I had, so no, I don't have extra
tips on top of that. :-)

Regards,

Miklos


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] online.git: net/DelaySocket.cpp tools/Config.cpp

2019-01-16 Thread Libreoffice Gerrit user
 net/DelaySocket.cpp |   28 
 tools/Config.cpp|2 +-
 2 files changed, 17 insertions(+), 13 deletions(-)

New commits:
commit 6d57f0a0053bfe5e3554f85cea32d99a3d0646b8
Author: Miklos Vajna 
AuthorDate: Thu Jan 17 08:46:01 2019 +0100
Commit: Miklos Vajna 
CommitDate: Thu Jan 17 08:46:11 2019 +0100

net: make members private in DelaySocket

Change-Id: I5970d55f0723e46892ed5bea87bb79376c7ea530

diff --git a/net/DelaySocket.cpp b/net/DelaySocket.cpp
index 41eb4faf5..cfd8b7e54 100644
--- a/net/DelaySocket.cpp
+++ b/net/DelaySocket.cpp
@@ -31,14 +31,18 @@ class DelaySocket : public Socket {
 
 /// queued up data - sent to us by our opposite twin.
 struct WriteChunk {
+private:
 std::chrono::steady_clock::time_point _sendTime;
 std::vector _data;
+public:
 WriteChunk(int delayMs)
 {
 _sendTime = std::chrono::steady_clock::now() +
 std::chrono::milliseconds(delayMs);
 }
 bool isError() { return _data.size() == 0; }
+std::chrono::steady_clock::time_point getSendTime() const { return 
_sendTime; }
+std::vector& getData() { return _data; }
 private:
 WriteChunk();
 };
@@ -65,8 +69,8 @@ public:
 {
 os << "\t\tin: " <<
 std::chrono::duration_cast(
-chunk->_sendTime - now).count() << "ms - "
-   << chunk->_data.size() << "bytes\n";
+chunk->getSendTime() - now).count() << "ms - "
+   << chunk->getData().size() << "bytes\n";
 }
 }
 
@@ -79,7 +83,7 @@ public:
 if (_chunks.size() > 0)
 {
 int remainingMs = 
std::chrono::duration_cast(
-(*_chunks.begin())->_sendTime - now).count();
+(*_chunks.begin())->getSendTime() - now).count();
 if (remainingMs < timeoutMaxMs)
 DELAY_LOG("#" << getFD() << " reset timeout max to " << 
remainingMs
   << "ms from " << timeoutMaxMs << "ms\n");
@@ -87,7 +91,7 @@ public:
 }
 
 if (_chunks.size() > 0 &&
-now > (*_chunks.begin())->_sendTime)
+now > (*_chunks.begin())->getSendTime())
 return POLLIN | POLLOUT;
 else
 return POLLIN;
@@ -142,7 +146,7 @@ public:
 {
 DELAY_LOG("#" << getFD() << " read " << len
   << " to queue: " << _chunks.size() << "\n");
-chunk->_data.insert(chunk->_data.end(), [0], [len]);
+chunk->getData().insert(chunk->getData().end(), [0], 
[len]);
 if (_dest)
 _dest->_chunks.push_back(chunk);
 else
@@ -164,9 +168,9 @@ public:
 {
 std::shared_ptr chunk = *_chunks.begin();
 if (std::chrono::duration_cast(
-now - chunk->_sendTime).count() >= 0)
+now - chunk->getSendTime()).count() >= 0)
 {
-if (chunk->_data.size() == 0)
+if (chunk->getData().size() == 0)
 { // delayed error or close
 DELAY_LOG("#" << getFD() << " handling delayed close\n");
 changeState(Closed);
@@ -175,7 +179,7 @@ public:
 {
 ssize_t len;
 do {
-len = ::write(getFD(), >_data[0], 
chunk->_data.size());
+len = ::write(getFD(), >getData()[0], 
chunk->getData().size());
 } while (len < 0 && errno == EINTR);
 
 if (len < 0)
@@ -188,7 +192,7 @@ public:
 {
 DELAY_LOG("#" << getFD() << " failed onwards write 
"
   << len << "bytes of "
-  << chunk->_data.size()
+  << chunk->getData().size()
   << " queue: " << _chunks.size() << " 
error: "
   << Util::symbolicErrno(errno) << ": " << 
strerror(errno) << "\n");
 changeState(Closed);
@@ -197,12 +201,12 @@ public:
 else
 {
 DELAY_LOG("#" << getFD() << " written onwards " << len 
<< "bytes of "
-  << chunk->_data.size()
+  << chunk->getData().size()
   << " queue: " << _chunks.size() << "\n");
 if (len > 0)
-chunk->_data.erase(chunk->_data.begin(), 
chunk->_data.begin() + len);
+chunk->getData().erase(chunk->getData().begin(), 
chunk->getData().begin() + len);
 
-if (chunk->_data.size() == 0)
+if (chunk->getData().size() == 0)
  

[Libreoffice-bugs] [Bug 44451] References ( Illustration, Tables) don't work if the file is open with a UI language different than the one used to create it

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=44451

--- Comment #31 from Robert  ---
Now I found a difference between my LO at work
Version: 6.0.7.3 (x64)
Build-ID: dc89aa7a9eabfd848af146d5086077aeed2ae4a5
CPU-Threads: 4; BS: Windows 6.1; UI-Render: Standard; 
Gebietsschema: de-DE (de_DE); Calc: group
and my LO at home
Version: 6.1.0.3 (x64)
Build-ID: efb621ed25068d70781dc026f7e9c5187a4decd1
CPU-Threads: 8; BS: Windows 10.0; UI-Render: Standard; 
Gebietsschema: de-DE (de_DE); Calc: CL

When I create a new caption for a picture with LO/W7/6.0.7.3, there is a list
of categories:
[Keine]
Abbildung
Tabelle
Text
Zeichnung
Figure

Doing the same with LO/W10/6.1.0.3, there is a different list:
[Keine]
Abbildung
Tabelle
Text
Zeichnung
Abbildung

So instead of "Abbildung" and "Figure" in one list I have two "Abbildung",
which from my point of view cannot be OK.

When I create a caption Abbildung with LO/W7/... and copy the frame, the
caption number is increased. Now opening the same file with LO/W10/... and copy
a frame, the numbering of "Abbildung" starts with "1". So obviously, the two
LOs do not use the same instance. One uses an instance of "Abbildung" and names
ist "Abbildung" and the other uses an instance of "Figure" and names ist also
"Abbildung" (or something like that).

I hope, this is a valuable hint for the experts.
I do not dare to update LO on my W7 computer, because it feels, that the older
version with "Abbildung" and "Figure" is more correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/source

2019-01-16 Thread Libreoffice Gerrit user
 sw/source/filter/ww8/rtfexport.cxx   |4 ++--
 sw/source/filter/ww8/rtfexportfilter.hxx |3 ++-
 sw/source/filter/ww8/rtfsdrexport.cxx|8 ++--
 3 files changed, 10 insertions(+), 5 deletions(-)

New commits:
commit 767f6ee7be94158335cef55afd3708da2f871210
Author: Miklos Vajna 
AuthorDate: Wed Jan 16 20:54:48 2019 +0100
Commit: Miklos Vajna 
CommitDate: Thu Jan 17 08:45:38 2019 +0100

sw: make members of RtfExportFilter private

- also use std::make_unique
- also avoid multiple declarations in a single statement

Change-Id: Ib5429730fcf14131b7b68628a8724a812dcc018f
Reviewed-on: https://gerrit.libreoffice.org/66479
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/source/filter/ww8/rtfexport.cxx 
b/sw/source/filter/ww8/rtfexport.cxx
index 4e8b344c30df..451f09a611b8 100644
--- a/sw/source/filter/ww8/rtfexport.cxx
+++ b/sw/source/filter/ww8/rtfexport.cxx
@@ -692,7 +692,7 @@ ErrCode RtfExport::ExportDocument_Impl()
 // Font table
 WriteFonts();
 
-m_pStyles.reset(new MSWordStyles(*this));
+m_pStyles = std::make_unique(*this);
 // Color and stylesheet table
 WriteStyles();
 
@@ -1057,7 +1057,7 @@ RtfExport::RtfExport(RtfExportFilter* pFilter, SwDoc* 
pDocument, SwPaM* pCurrent
 m_pSdrExport = o3tl::make_unique(*this);
 
 if (!m_pWriter)
-m_pWriter = _pFilter->m_aWriter;
+m_pWriter = _pFilter->GetWriter();
 }
 
 RtfExport::~RtfExport() = default;
diff --git a/sw/source/filter/ww8/rtfexportfilter.hxx 
b/sw/source/filter/ww8/rtfexportfilter.hxx
index 34cf5985c34b..b7603c1de732 100644
--- a/sw/source/filter/ww8/rtfexportfilter.hxx
+++ b/sw/source/filter/ww8/rtfexportfilter.hxx
@@ -52,6 +52,7 @@ class RtfExportFilter final
 {
 css::uno::Reference m_xCtx;
 css::uno::Reference m_xSrcDoc;
+RtfWriter m_aWriter;
 
 public:
 explicit RtfExportFilter(css::uno::Reference 
xCtx);
@@ -66,7 +67,7 @@ public:
 void SAL_CALL
 setSourceDocument(const css::uno::Reference& xDoc) 
override;
 
-RtfWriter m_aWriter;
+Writer& GetWriter() { return m_aWriter; }
 };
 
 #endif // INCLUDED_SW_SOURCE_FILTER_WW8_RTFEXPORTFILTER_HXX
diff --git a/sw/source/filter/ww8/rtfsdrexport.cxx 
b/sw/source/filter/ww8/rtfsdrexport.cxx
index a6175b642970..9684964386da 100644
--- a/sw/source/filter/ww8/rtfsdrexport.cxx
+++ b/sw/source/filter/ww8/rtfsdrexport.cxx
@@ -220,7 +220,8 @@ void RtfSdrExport::Commit(EscherPropertyContainer& rProps, 
const tools::Rectangl
 case ESCHER_Prop_geoLeft:
 case ESCHER_Prop_geoTop:
 {
-sal_uInt32 nLeft = 0, nTop = 0;
+sal_uInt32 nLeft = 0;
+sal_uInt32 nTop = 0;
 
 if (nId == ESCHER_Prop_geoLeft)
 {
@@ -243,7 +244,10 @@ void RtfSdrExport::Commit(EscherPropertyContainer& rProps, 
const tools::Rectangl
 case ESCHER_Prop_geoRight:
 case ESCHER_Prop_geoBottom:
 {
-sal_uInt32 nLeft = 0, nRight = 0, nTop = 0, nBottom = 0;
+sal_uInt32 nLeft = 0;
+sal_uInt32 nRight = 0;
+sal_uInt32 nTop = 0;
+sal_uInt32 nBottom = 0;
 rProps.GetOpt(ESCHER_Prop_geoLeft, nLeft);
 rProps.GetOpt(ESCHER_Prop_geoTop, nTop);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 122778] New: Wrong focus after copy from another slide

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122778

Bug ID: 122778
   Summary: Wrong focus after copy from another slide
   Product: LibreOffice
   Version: 6.0.7.3 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: notebook22...@gmail.com

Reproduce:
1. Create Presentation with four slides
2. Select first slide 
3. Add a picture to the slide 
4. Mark the picture and copy it
5. Use the "Slides"-Sidebar to select the 3rd slide
6. Paste the picture
7. The picture will be pasted. It will be marked. 
8. Click the "arrow down" key on the keyboard.
9. The slide 4 will be selected


Expected:
@9: Picture moves down a little

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122777] Impress: "Slides" sidebar: Can't select slide, if Slide bubble shown

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122777

BottleOnTheGround  changed:

   What|Removed |Added

  Component|LibreOffice |Impress

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122776] Improve: Moving slides require to wait for animation finish

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122776

BottleOnTheGround  changed:

   What|Removed |Added

  Component|LibreOffice |Impress

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Gülşah Köse license statement

2019-01-16 Thread Gülşah Köse

All of my past & future contributions to LibreOffice may be
   licensed under the MPLv2/LGPLv3+ dual license.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 122446] MariaDB native connector: All tables are write protected

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122446

--- Comment #2 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated yesterday + this on my
autogen.input:
...
--without-system-mariadb
--enable-bundle-mariadb
...
I don't reproduce this.

I use a Mysql database on a local server.
Here are the steps:
- launch Base
- Connect to an existing database
- Mysql (I don't see any "Mariabd" entry)
- click Next
- Connect directly
- click Next
- fill database name, server 
- click Next
- fill User name + check Password required
- click test connection
- fill password
- click Ok
- click Ok to popup display "connection was established"
- click Next
- select "No, do not register the database
- click Finish
- choose filename

then
- edit table by adding a field
=> field is created.

Did I miss something?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 119813] FILEOPEN CSV import dialog doesn't get focus if libreoffice is already running [Ubuntu 18.04, 16.04]

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119813

--- Comment #5 from valentas  ---
Can reconfirm (why was the previous bug closed?) on Version: 6.0.7.3 Build ID:
1:6.0.7-0ubuntu0.18.04.2 gtk3. 

In 18.04 I have a new non-deterministic bug: sometimes a dock icon on the left
side panel is not created at all, if the first file you open is csv and the
icon is not locked to the dock (not in "Favorites"): an icon is initially
created for the import dialog but then disappears when you press OK, and does
not reappear on opening any other files - this leaves just "alt+tab" for
navigation an memomorizing what you have opened (or requires to keep Calc in
"Favorites").

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122777] New: Impress: "Slides" sidebar: Can't select slide, if Slide bubble shown

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122777

Bug ID: 122777
   Summary: Impress: "Slides" sidebar: Can't select slide, if
Slide bubble shown
   Product: LibreOffice
   Version: 6.0.7.3 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: notebook22...@gmail.com

Description:
It's not possible to select a slide through the "Slide bubble", that appears,
if the mouse cursor is hovering over a slide. 


I recorded a short clip showing the behaviour:
https://youtu.be/nwMGhc5nDdE
(unfortunately my mic wasn't recorded, so you don't here, that I clicked the
mouse button about 200 times )

Steps to Reproduce:
Current behaviour:
===

1. Create a presentation.
2. Make the "slides" sidebar being shown.
3. Insert so many slides to make them exceed the screens vertical (e.g. 20).
4. Select slide number 1.
5. Move the cursor the last slide shown on the screen.
6. A bubble will appear like ("Slide 7").
7. Now try to select the slide through the bubble.



Actual Results:
8. You cannot select the slide through the bubble.

Expected Results:
@8. Selecting a slide through a bubble is possible


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Happens with and without hardware acceleration (probably OpenGL)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: drawinglayer/source

2019-01-16 Thread Libreoffice Gerrit user
 drawinglayer/source/tools/emfpbrush.hxx  |1 -
 drawinglayer/source/tools/emfphelperdata.cxx |   21 -
 drawinglayer/source/tools/emfphelperdata.hxx |3 ---
 drawinglayer/source/tools/emfpregion.cxx |   16 +++-
 4 files changed, 15 insertions(+), 26 deletions(-)

New commits:
commit e3ccc09417731e61d3d35ed4cc1a7436e05f5325
Author: Bartosz Kosiorek 
AuthorDate: Tue Jan 15 15:11:28 2019 +0100
Commit: Bartosz Kosiorek 
CommitDate: Thu Jan 17 07:55:29 2019 +0100

tdf#122557 EMF+ Implement proper rotation support of DrawImage

Change-Id: I2c32a47fac06b2026d61a0f369e6d569c9f57502
Reviewed-on: https://gerrit.libreoffice.org/66392
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek 

diff --git a/drawinglayer/source/tools/emfpbrush.hxx 
b/drawinglayer/source/tools/emfpbrush.hxx
index b73507817de7..283ff304abf3 100644
--- a/drawinglayer/source/tools/emfpbrush.hxx
+++ b/drawinglayer/source/tools/emfpbrush.hxx
@@ -22,7 +22,6 @@
 
 #include "emfphelperdata.hxx"
 #include 
-#include 
 
 namespace emfplushelper
 {
diff --git a/drawinglayer/source/tools/emfphelperdata.cxx 
b/drawinglayer/source/tools/emfphelperdata.cxx
index 5c86d69f1282..03f23451c492 100644
--- a/drawinglayer/source/tools/emfphelperdata.cxx
+++ b/drawinglayer/source/tools/emfphelperdata.cxx
@@ -36,6 +36,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -336,12 +337,6 @@ namespace emfplushelper
 return maMapTransform * ::basegfx::B2DPoint(ix, iy);
 }
 
-::basegfx::B2DSize EmfPlusHelperData::MapSize(double iwidth, double 
iheight) const
-{
-// map in one step using complete MapTransform (see mappingChanged)
-return maMapTransform * ::basegfx::B2DSize(iwidth, iheight);
-}
-
 Color EmfPlusHelperData::EMFPGetBrushColorOrARGBColor(const sal_uInt16 
flags, const sal_uInt32 brushIndexOrColor) const {
 Color color;
 if (flags & 0x8000) // we use a color
@@ -1224,11 +1219,10 @@ namespace emfplushelper
 ReadPoint(rMS, x2, y2, flags); // 
upper-right
 ReadPoint(rMS, x3, y3, flags); // 
lower-left
 
-SAL_INFO("drawinglayer", "EMF+\t 
destination points: " << x1 << "," << y1 << " " << x2 << "," << y2 << " " << x3 
<< "," << y3);
-SAL_INFO("drawinglayer", "EMF+\t 
destination rectangle: " << x1 << "," << y1 << " " << x2 - x1 << "x" << y3 - 
y1);
+SAL_INFO("drawinglayer", "EMF+\t 
destination points: P1:" << x1 << "," << y1 << " P2:" << x2 << "," << y2 << " 
P3:" << x3 << "," << y3);
 
-aDstPoint = Map(x1, y1);
-aDstSize = MapSize(x2 - x1, y3 - y1);
+aDstPoint = ::basegfx::B2DPoint(x1, y1);
+aDstSize = ::basegfx::B2DSize(x2 - x1, y3 
- y1);
 }
 else
 {
@@ -1241,12 +1235,12 @@ namespace emfplushelper
 float dx, dy, dw, dh;
 ReadRectangle(rMS, dx, dy, dw, dh, bool(flags 
& 0x4000));
 SAL_INFO("drawinglayer", "EMF+\t destination 
rectangle: " << dx << "," << dy << " " << dw << "x" << dh);
-aDstPoint = Map(dx, dy);
-aDstSize = MapSize(dw, dh);
+aDstPoint = ::basegfx::B2DPoint(dx, dy);
+aDstSize = ::basegfx::B2DSize(dw, dh);
 }
 
 // create correct transform matrix
-basegfx::B2DHomMatrix aTransformMatrix = 
basegfx::utils::createScaleTranslateB2DHomMatrix(
+const basegfx::B2DHomMatrix aTransformMatrix = 
maMapTransform * basegfx::utils::createScaleTranslateB2DHomMatrix(
 aDstSize.getX(),
 aDstSize.getY(),
 aDstPoint.getX(),
@@ -1266,6 +1260,7 @@ namespace emfplushelper
 else
 {
 SAL_WARN("drawinglayer", "EMF+\t warning: 
empty bitmap");
+break;
 }
 }
 else if (image.type == ImageDataTypeMetafile)
diff --git a/drawinglayer/source/tools/emfphelperdata.hxx 
b/drawinglayer/source/tools/emfphelperdata.hxx
index d63301f50f5f..7499544b6330 100644
--- a/drawinglayer/source/tools/emfphelperdata.hxx
+++ b/drawinglayer/source/tools/emfphelperdata.hxx
@@ -24,8 +24,6 @@
 #include 
 #include 
 #include 
-#include 
-#include 
 #include 
 
 // predefines
@@ -204,7 

[Libreoffice-bugs] [Bug 122776] Improve: Moving slides require to wait for animation finish

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122776

BottleOnTheGround  changed:

   What|Removed |Added

   Keywords||accessibility

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122776] New: Improve: Moving slides require to wait for animation finish

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122776

Bug ID: 122776
   Summary: Improve: Moving slides require to wait for animation
finish
   Product: LibreOffice
   Version: 6.0.7.3 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: notebook22...@gmail.com

Current behaviour:
  1. Create several slides in a presentation
  2. Move(drag) one slide in between two other slides
  3 The surrounding slide will move up/down to make space for the new (still
dragged) slide
  4. If the mouse button is released too fast (probably before the animation
finished), the action is reverted.

Suggested behaviour:
  @4. Slide will be moved, even, if the animation is not yet finished

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/inc sc/source

2019-01-16 Thread Libreoffice Gerrit user
 sc/inc/chgtrack.hxx|   12 ++--
 sc/source/core/tool/chgtrack.cxx   |   32 
 sc/source/ui/docshell/docsh3.cxx   |2 +-
 sc/source/ui/miscdlgs/acredlin.cxx |   13 +++--
 4 files changed, 30 insertions(+), 29 deletions(-)

New commits:
commit 2972878854d224322998c537c0b2a50fab4e7f91
Author: Noel Grandin 
AuthorDate: Mon Jan 14 15:41:22 2019 +0200
Commit: Noel Grandin 
CommitDate: Thu Jan 17 07:37:29 2019 +0100

convert ScChangeTrackMsgType to scoped enum

Change-Id: Ie0baed90e3d0f51ec15c110dbd7ff41dcf7baa40
Reviewed-on: https://gerrit.libreoffice.org/66324
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/inc/chgtrack.hxx b/sc/inc/chgtrack.hxx
index 730494ab354d..65f049ad163f 100644
--- a/sc/inc/chgtrack.hxx
+++ b/sc/inc/chgtrack.hxx
@@ -783,13 +783,13 @@ public:
 };
 
 //  ScChangeTrack
-enum ScChangeTrackMsgType
+enum class ScChangeTrackMsgType
 {
-SC_CTM_NONE,
-SC_CTM_APPEND,  // Actions appended
-SC_CTM_REMOVE,  // Actions removed
-SC_CTM_CHANGE,  // Actions changed
-SC_CTM_PARENT   // became a parent (and wasn't before)
+NONE,
+Append,  // Actions appended
+Remove,  // Actions removed
+Change,  // Actions changed
+Parent   // became a parent (and wasn't before)
 };
 
 struct ScChangeTrackMsgInfo
diff --git a/sc/source/core/tool/chgtrack.cxx b/sc/source/core/tool/chgtrack.cxx
index a296fcd9a772..3c2df3c1b140 100644
--- a/sc/source/core/tool/chgtrack.cxx
+++ b/sc/source/core/tool/chgtrack.cxx
@@ -2306,7 +2306,7 @@ void ScChangeTrack::NotifyModified( ScChangeTrackMsgType 
eMsgType,
 {
 if ( !xBlockModifyMsg || xBlockModifyMsg->eMsgType != eMsgType ||
 (IsGenerated( nStartAction ) &&
-(eMsgType == SC_CTM_APPEND || eMsgType == SC_CTM_REMOVE)) )
+(eMsgType == ScChangeTrackMsgType::Append || eMsgType == 
ScChangeTrackMsgType::Remove)) )
 {   // Append within Append e.g. not
 StartBlockModify( eMsgType, nStartAction );
 EndBlockModify( nEndAction );
@@ -2419,18 +2419,18 @@ void ScChangeTrack::Append( ScChangeAction* pAppend, 
sal_uLong nAction )
 
 if ( aModifiedLink.IsSet() )
 {
-NotifyModified( SC_CTM_APPEND, nAction, nAction );
+NotifyModified( ScChangeTrackMsgType::Append, nAction, nAction );
 if ( pAppend->GetType() == SC_CAT_CONTENT )
 {
 ScChangeActionContent* pContent = 
static_cast(pAppend);
 if ( ( pContent = pContent->GetPrevContent() ) != nullptr )
 {
 sal_uLong nMod = pContent->GetActionNumber();
-NotifyModified( SC_CTM_CHANGE, nMod, nMod );
+NotifyModified( ScChangeTrackMsgType::Change, nMod, nMod );
 }
 }
 else
-NotifyModified( SC_CTM_CHANGE, pFirst->GetActionNumber(),
+NotifyModified( ScChangeTrackMsgType::Change, 
pFirst->GetActionNumber(),
 pLast->GetActionNumber() );
 }
 }
@@ -2452,7 +2452,7 @@ void ScChangeTrack::AppendDeleteRange( const ScRange& 
rRange,
 ScDocument* pRefDoc, SCTAB nDz, sal_uLong nRejectingInsert )
 {
 SetInDeleteRange( rRange );
-StartBlockModify( SC_CTM_APPEND, GetActionMax() + 1 );
+StartBlockModify( ScChangeTrackMsgType::Append, GetActionMax() + 1 );
 SCCOL nCol1;
 SCROW nRow1;
 SCTAB nTab1;
@@ -2734,7 +2734,7 @@ void ScChangeTrack::AppendContentRange( const ScRange& 
rRange,
 Undo( nStartLastCut, nEndLastCut ); // Remember Cuts here
 // StartAction only after Undo!
 nStartAction = GetActionMax() + 1;
-StartBlockModify( SC_CTM_APPEND, nStartAction );
+StartBlockModify( ScChangeTrackMsgType::Append, nStartAction );
 // Contents to overwrite in ToRange
 LookUpContents( aRange, pRefDoc, 0, 0, 0 );
 pLastCutMove->SetStartLastCut( nStartLastCut );
@@ -2747,7 +2747,7 @@ void ScChangeTrack::AppendContentRange( const ScRange& 
rRange,
 {
 bDoContents = true;
 nStartAction = GetActionMax() + 1;
-StartBlockModify( SC_CTM_APPEND, nStartAction );
+StartBlockModify( ScChangeTrackMsgType::Append, nStartAction );
 }
 if ( bDoContents )
 {
@@ -2782,7 +2782,7 @@ void ScChangeTrack::AppendContentsIfInRefDoc( ScDocument* 
pRefDoc,
 if (aIter.first())
 {
 nStartAction = GetActionMax() + 1;
-StartBlockModify( SC_CTM_APPEND, nStartAction );
+StartBlockModify( ScChangeTrackMsgType::Append, nStartAction );
 SvNumberFormatter* pFormatter = pRefDoc->GetFormatTable();
 do
 {
@@ -2847,7 +2847,7 @@ ScChangeActionContent* ScChangeTrack::GenerateDelContent(
 }
 pFirstGeneratedDelContent = pContent;
 aGeneratedMap.insert( std::make_pair( nGeneratedMin, pContent ) );
-NotifyModified( SC_CTM_APPEND, nGeneratedMin, nGeneratedMin 

[Libreoffice-commits] core.git: sc/source

2019-01-16 Thread Libreoffice Gerrit user
 sc/source/ui/Accessibility/AccessibleCsvControl.cxx   |4 
 sc/source/ui/Accessibility/AccessibleDocument.cxx |   47 
+--
 sc/source/ui/Accessibility/AccessibleDocumentPagePreview.cxx  |   65 
--
 sc/source/ui/Accessibility/AccessibleGlobal.cxx   |   11 -
 sc/source/ui/Accessibility/AccessiblePageHeader.cxx   |   24 +--
 sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx  |   40 ++
 sc/source/ui/StatisticsDialogs/TableFillingAndNavigationTools.cxx |   10 -
 sc/source/ui/app/drwtrans.cxx |5 
 sc/source/ui/app/inputhdl.cxx |   55 
++--
 sc/source/ui/app/inputwin.cxx |   18 +-
 sc/source/ui/app/rfindlst.cxx |8 -
 sc/source/ui/cctrl/checklistmenu.cxx  |   46 
+++
 sc/source/ui/cctrl/tbzoomsliderctrl.cxx   |   30 +---
 sc/source/ui/condformat/condformatdlg.cxx |   37 ++---
 sc/source/ui/condformat/condformatdlgentry.cxx|   28 +---
 sc/source/ui/condformat/condformatmgr.cxx |6 
 sc/source/ui/dbgui/dbnamdlg.cxx   |5 
 sc/source/ui/dbgui/filtdlg.cxx|5 
 sc/source/ui/dbgui/pfiltdlg.cxx   |5 
 sc/source/ui/dbgui/pvfundlg.cxx   |   28 ++--
 sc/source/ui/dbgui/sfiltdlg.cxx   |9 -
 sc/source/ui/dbgui/tpsort.cxx |6 
 22 files changed, 189 insertions(+), 303 deletions(-)

New commits:
commit 2b56117c188989a7b86cb74133b211cb7fadcca6
Author: Arkadiy Illarionov 
AuthorDate: Wed Jan 16 09:44:13 2019 +0300
Commit: Noel Grandin 
CommitDate: Thu Jan 17 07:34:03 2019 +0100

Simplify containers iterations in sc/source/ui/[A-Sa-d]*

Use range-based loop or replace with STL functions

Change-Id: I261dcba1778a9d895491452fb3fee3dd4e8dfc33
Reviewed-on: https://gerrit.libreoffice.org/66422
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/source/ui/Accessibility/AccessibleCsvControl.cxx 
b/sc/source/ui/Accessibility/AccessibleCsvControl.cxx
index dba9bdfa36db..3d5a283b7105 100644
--- a/sc/source/ui/Accessibility/AccessibleCsvControl.cxx
+++ b/sc/source/ui/Accessibility/AccessibleCsvControl.cxx
@@ -847,8 +847,8 @@ ScAccessibleCsvGrid::~ScAccessibleCsvGrid()
 void ScAccessibleCsvGrid::disposing()
 {
 SolarMutexGuard aGuard;
-for (XAccessibleSet::iterator aI = maAccessibleChildren.begin(); aI != 
maAccessibleChildren.end(); ++aI)
-aI->second->dispose();
+for (auto& rEntry : maAccessibleChildren)
+rEntry.second->dispose();
 maAccessibleChildren.clear();
 ScAccessibleCsvControl::disposing();
 }
diff --git a/sc/source/ui/Accessibility/AccessibleDocument.cxx 
b/sc/source/ui/Accessibility/AccessibleDocument.cxx
index 3782bd827ba7..2adccc76a3e9 100644
--- a/sc/source/ui/Accessibility/AccessibleDocument.cxx
+++ b/sc/source/ui/Accessibility/AccessibleDocument.cxx
@@ -811,33 +811,20 @@ uno::Reference< XAccessible > 
ScChildrenShapes::GetSelected(sal_Int32 nSelectedC
 }
 else
 {
-SortedShapes::iterator aItr = maZOrderedShapes.begin();
-SortedShapes::iterator aEndItr = maZOrderedShapes.end();
-bool bFound(false);
-while(!bFound && aItr != aEndItr)
+for(const auto& rpShape : maZOrderedShapes)
 {
-if (*aItr)
+if (!rpShape || rpShape->bSelected)
 {
-if ((*aItr)->bSelected)
+if (nSelectedChildIndex == 0)
 {
-if (nSelectedChildIndex == 0)
-bFound = true;
-else
---nSelectedChildIndex;
+if (rpShape)
+xAccessible = rpShape->pAccShape.get();
+break;
 }
-}
-else
-{
-if (nSelectedChildIndex == 0)
-bFound = true;
 else
 --nSelectedChildIndex;
 }
-if (!bFound)
-++aItr;
 }
-if (bFound && *aItr)
-xAccessible = (*aItr)->pAccShape.get();
 }
 
 return xAccessible;
@@ -1103,8 +1090,7 @@ bool ScChildrenShapes::FindSelectedShapesChanges(const 
uno::Reference(mpAccessibleDocument);
-uno::Reference< XAccessible > xChild( (*vi)->pAccShape.get());
+uno::Reference< XAccessible > xChild( rpShape->pAccShape.get());
 aEvent.NewValue <<= xChild;
 mpAccessibleDocument->CommitChange(aEvent);
 }
 }
-SortedShapes::iterator vi = vecSelectedShapeRemove.begin();

[Libreoffice-bugs] [Bug 122435] LibreOffice hangs when in Calc copying formula while in edit mode then leaving field with escape

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122435

Aron Budea  changed:

   What|Removed |Added

 Attachment #148228|application/zip |application/vnd.openxmlform
  mime type||ats-officedocument.spreadsh
   ||eetml.sheet

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: chart2/source

2019-01-16 Thread Libreoffice Gerrit user
 chart2/source/controller/dialogs/tp_Scale.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit dbbdc76f7fc8f762d9c9e8494cae61b527f7ddca
Author: Andrea Gelmini 
AuthorDate: Wed Jan 16 23:48:42 2019 +
Commit: Julien Nabet 
CommitDate: Thu Jan 17 07:07:26 2019 +0100

Fix typo

Change-Id: Ib920de1dfbe5ddf4c8576a00fcc7a557b5a6b2da
Reviewed-on: https://gerrit.libreoffice.org/66492
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/chart2/source/controller/dialogs/tp_Scale.hxx 
b/chart2/source/controller/dialogs/tp_Scale.hxx
index 16c29e8b2cf0..a44c12c91232 100644
--- a/chart2/source/controller/dialogs/tp_Scale.hxx
+++ b/chart2/source/controller/dialogs/tp_Scale.hxx
@@ -95,7 +95,7 @@ private:
 
 @param pControl
 If non-NULL, contains a pointer to the control in which the
-errornous value was in.  This method gives this control the focus
+erroneous value was in. This method gives this control the focus
 and selects its content.
 
 @return false, if nResIdMessage was 0, true otherwise
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 122775] New: Loss of Information in Quattro Pro Files

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122775

Bug ID: 122775
   Summary: Loss of Information in Quattro Pro Files
   Product: LibreOffice
   Version: 6.1.4.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: emper...@comcast.net

Description:
I have just started using this product to convert old Quattro Pro files (WQ1,
WQ2)into Excel XLSX files.  I can run Quattro Pro for DOS directly on a Windows
7 PC, and the files contain correct information.  When I open those same files
with LibreOffice on a Windows 10 PC, I find that numbers smaller than about
1E-6 are not imported accurately.  Once numbers are smaller than about 1E-8,
they are set to zero in LibreOffice.  This is on import, before conversion to
XLSX files.  My only recourse thus far is to open the file both in Quattro Pro
and in LibreOffice, so I can manually make repairs in LibreOffice and then
convert the file to XLSX.  I think LibreOffice is not carrying enough decimal
places during number import and conversion.

Steps to Reproduce:
1.Build a DOS Quattro Pro WQ2 file containing numbers ranging from 0 to 1E-14,
using several significant figures in those numbers.
2.Import the Quattro Pro file into LibreOffice.
3.Observe the error in conversion.  If you cannot do this, I can provide a
suitable Quattro Pro file.

Actual Results:
ActualImported
1.10E-06  1.10E-06
6.76E-07  6.80E-07
4.07E-07  4.10E-07
2.45E-07  2.40E-07
1.41E-07  1.40E-07
7.24E-08  7.00E-08
3.72E-08  4.00E-08
1.91E-08  2.00E-08
8.51E-09  1.00E-08
4.47E-09  0.00E+00
2.29E-09  0.00E+00
1.41E-09  0.00E+00
9.55E-10  0.00E+00


Expected Results:
 Imported numbers should match Actual numbers


Reproducible: Always


User Profile Reset: No



Additional Info:
That's all I know to say.  I don't know how to answer the next two items.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 54743] [FORMATTING] Shift+F3 works unexpected (uppercase and lowercase)

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=54743

--- Comment #9 from Дмитрий  ---
Created attachment 148383
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148383=edit
Visualization of work

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Contributing for GSoC 2019

2019-01-16 Thread Noumbissi Valere
Hello,
I am a final year student  in computer Engineering at university of
Buea-Cameroon.
Libreoffice is an office suit i used everyday  and i will love to use my
Python skills to contribute to it hoping to participate in GSoC 2019
through  it.

I am new to open source and will love to start contributing immediately.
please can someone tell me how to  get started?

Thanking you,
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 119569] Open Sub-Form causes PostgreSQL error

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119569

--- Comment #26 from ansari.a...@gmail.com ---
Forgive for asking this. But Please build a standalone sdbc-postgresql driver
with this patch. 

I am stuck with OO 3.1.1.Application in production with many standalone forms
with 5 levels of sub-forms filtering. We use over 10 computers daily for work.
And postgresql log become pretty un-manageable within a short period of time,
as it fills with this syntax error on each form load/reload.

We cannot change to LO as its file filecker with preview is modified in such a
way that the file-preview pane is not enlargeable any more. We use the OO file
picker with preview image function to look through the report/images scanned in
as .jpg, and is a much needed function for us.

Thank you
Ansari

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94423] UNO/Java: cannot retrieve Named Ranges from .ods, but can from .xls/.xlsx

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94423

Myk Dowling  changed:

   What|Removed |Added

 CC||poli...@gmail.com

--- Comment #7 from Myk Dowling  ---
Can confirm this bug is still active. Named ranges are not retrieved when
opening either an xlsx file or an ods file saved with Libre Office

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 77149] #6 envelope will not print (HP printer)

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=77149

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115010] gpg4libre: unit-test document encryptedGPG.odf has no reaction

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115010

--- Comment #2 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 98545] Digital signature with elliptic curve certificate not working

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98545

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 36737] default values for optional parameters are not processed

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=36737

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 52926] Format changes from "#10 Envelope" to "User" with different height, margin-top, and offset (Canon & Brother printers)

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=52926

--- Comment #15 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122774] New: All items in AutoFilter popup menu are not keyboard accessible

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122774

Bug ID: 122774
   Summary: All items in AutoFilter popup menu are not keyboard
accessible
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rayk...@gmail.com

Steps to repro:

1. Enter some data to cells in a column
2. Menu->Data->AutoFilter
3. Click on the AutoFilter popup menu button in cell
AutoFilter popup menu opens, cursor is in 'Search items...' edit box
4. Try to use keyboard navigation to access Sort Ascending, Sort Descending,
Top 10, Empty, Not Empty, and Standard Filter... menu items

Results:
Can't access all menu items using keyboard

Expected Results:
Keyboard can access all menu items in popup menu

Version: 6.3.0.0.alpha0+
Build ID: 8b461713c0c86bc19af739aada4b1345cfa5dfbe
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 102145] Textboxes content no longer read by screen reader

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102145

--- Comment #8 from Quentin Christensen  ---
Confirming this issue still exists as described on Windows 10 using LO 6.1.3.2
and NVDA 2018.4.1.

Also confirming when a second slide is added the issue disappears (on both the
first and subsequent slides.

There is still an issue with trying to read all of the contents object - Using
NVDA's read all command (INSERT+DOWN ARROW) only the current bullet point or
line is read.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 96471] Reading documents and presentations with screen readers

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96471

--- Comment #6 from Quentin Christensen  ---
Just replying to confirm this issue still exists in LO 6.1.3.2 as well as Open
Office 4.1.6.

One very messy workaround using NVDA is that the OCR function will read the
text on screen.  This would not be at all ideal when giving a presentation
however.

Also, anyone considering testing with NVDA, we no longer require an email
address on the download page (though there is still provision to provide one if
you wish): https://www.nvaccess.org/download

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #209 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/0b521ddd8396490939f1a2ee7dde8effbde6d82d%5E%21

tdf#45904 Move XIndexAccess Java tests to C++

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #210 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/4edf62ebc95ec00a3a04907213d1a5fbb57b390d%5E%21

tdf#45904 Move XElementAccess Java tests to C++

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/qa

2019-01-16 Thread Libreoffice Gerrit user
 sc/qa/extras/sctableconditionalformat.cxx |8 
 1 file changed, 8 insertions(+)

New commits:
commit 62ce65fe042543e7aeaf83bf66f8c2357ff902c6
Author: Jens Carl 
AuthorDate: Wed Jan 16 21:27:15 2019 +
Commit: Jens Carl 
CommitDate: Thu Jan 17 01:44:05 2019 +0100

Add XServiceInfo tests to ScTableConditionalFormat

Change-Id: Icc57e3d06c13b444bbbd2936112daafbe410c34b
Reviewed-on: https://gerrit.libreoffice.org/66489
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/sc/qa/extras/sctableconditionalformat.cxx 
b/sc/qa/extras/sctableconditionalformat.cxx
index 094f8831b6ca..cc5b42f5be20 100644
--- a/sc/qa/extras/sctableconditionalformat.cxx
+++ b/sc/qa/extras/sctableconditionalformat.cxx
@@ -12,6 +12,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -45,6 +46,7 @@ class ScTableConditionalFormat : public CalcUnoApiTest,
  public apitest::XEnumerationAccess,
  public apitest::XIndexAccess,
  public apitest::XNameAccess,
+ public apitest::XServiceInfo,
  public apitest::XSheetConditionalEntries
 {
 public:
@@ -73,6 +75,11 @@ public:
 CPPUNIT_TEST(testGetElementNames);
 CPPUNIT_TEST(testHasByName);
 
+// XServiceInfo
+CPPUNIT_TEST(testGetImplementationName);
+CPPUNIT_TEST(testGetSupportedServiceNames);
+CPPUNIT_TEST(testSupportsService);
+
 // XSheetConditionalEntries
 CPPUNIT_TEST(testAddNew);
 CPPUNIT_TEST(testClear);
@@ -89,6 +96,7 @@ ScTableConditionalFormat::ScTableConditionalFormat()
 , XElementAccess(cppu::UnoType::get())
 , XIndexAccess(2)
 , XNameAccess("Entry1")
+, XServiceInfo("ScTableConditionalFormat", 
"com.sun.star.sheet.TableConditionalFormat")
 {
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: framework/qa qadevOOo/Jar_OOoRunner.mk qadevOOo/objdsc qadevOOo/tests sc/qa

2019-01-16 Thread Libreoffice Gerrit user
 framework/qa/complex/api_internal/api.lst|
1 
 qadevOOo/Jar_OOoRunner.mk|
1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableConditionalFormat.csv |
2 
 qadevOOo/tests/java/mod/_sc/ScTableConditionalFormat.java|  
167 --
 sc/qa/extras/sctableconditionalformat.cxx|
9 
 sc/qa/unoapi/sc_7.sce|
1 
 6 files changed, 9 insertions(+), 172 deletions(-)

New commits:
commit 4edf62ebc95ec00a3a04907213d1a5fbb57b390d
Author: Jens Carl 
AuthorDate: Wed Jan 16 21:21:13 2019 +
Commit: Jens Carl 
CommitDate: Thu Jan 17 01:43:11 2019 +0100

tdf#45904 Move XElementAccess Java tests to C++

Move XElementAccess Java tests to C++ for ScTableConditionalFormat.

Change-Id: Ib2575920e05d56feed68c6f4c15b485ab7993600
Reviewed-on: https://gerrit.libreoffice.org/66488
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/framework/qa/complex/api_internal/api.lst 
b/framework/qa/complex/api_internal/api.lst
index 63e1236b4656..28698eb8fa4e 100644
--- a/framework/qa/complex/api_internal/api.lst
+++ b/framework/qa/complex/api_internal/api.lst
@@ -93,7 +93,6 @@ job131=sc.ScStyleFamilyObj
 job132=sc.ScStyleObj
 job134=sc.ScTableColumnObj
 job135=sc.ScTableColumnsObj
-job137=sc.ScTableConditionalFormat
 job138=sc.ScTableRowObj
 job139=sc.ScTableValidationObj
 job140=sc.XMLContentExporter
diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk
index 30d993211f78..e657d66f882e 100644
--- a/qadevOOo/Jar_OOoRunner.mk
+++ b/qadevOOo/Jar_OOoRunner.mk
@@ -995,7 +995,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\
 qadevOOo/tests/java/mod/_sc/ScSubTotalDescriptorBase \
 qadevOOo/tests/java/mod/_sc/ScTableColumnObj \
 qadevOOo/tests/java/mod/_sc/ScTableColumnsObj \
-qadevOOo/tests/java/mod/_sc/ScTableConditionalFormat \
 qadevOOo/tests/java/mod/_sc/ScTableRowObj \
 qadevOOo/tests/java/mod/_sc/ScTableSheetObj \
 qadevOOo/tests/java/mod/_sc/ScTableSheetsObj \
diff --git 
a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableConditionalFormat.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableConditionalFormat.csv
deleted file mode 100644
index 3c950b80fa3c..
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableConditionalFormat.csv
+++ /dev/null
@@ -1,2 +0,0 @@
-"ScTableConditionalFormat";"com::sun::star::container::XElementAccess";"getElementType()"
-"ScTableConditionalFormat";"com::sun::star::container::XElementAccess";"hasElements()"
diff --git a/qadevOOo/tests/java/mod/_sc/ScTableConditionalFormat.java 
b/qadevOOo/tests/java/mod/_sc/ScTableConditionalFormat.java
deleted file mode 100644
index 0e579afca64d..
--- a/qadevOOo/tests/java/mod/_sc/ScTableConditionalFormat.java
+++ /dev/null
@@ -1,167 +0,0 @@
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-package mod._sc;
-
-import java.io.PrintWriter;
-
-import lib.TestCase;
-import lib.TestEnvironment;
-import lib.TestParameters;
-import util.SOfficeFactory;
-
-import com.sun.star.beans.PropertyValue;
-import com.sun.star.beans.XPropertySet;
-import com.sun.star.container.XIndexAccess;
-import com.sun.star.lang.XComponent;
-import com.sun.star.sheet.ConditionOperator;
-import com.sun.star.sheet.XSheetConditionalEntries;
-import com.sun.star.sheet.XSpreadsheet;
-import com.sun.star.sheet.XSpreadsheetDocument;
-import com.sun.star.sheet.XSpreadsheets;
-import com.sun.star.table.CellAddress;
-import com.sun.star.uno.AnyConverter;
-import com.sun.star.uno.Type;
-import com.sun.star.uno.UnoRuntime;
-import com.sun.star.uno.XInterface;
-
-/**
-* Test for object which is represented by service
-* com.sun.star.sheet.TableConditionalFormat. 
-* Object implements the following interfaces :
-* 
-*   com::sun::star::container::XNameAccess
-*   com::sun::star::container::XIndexAccess
-*   com::sun::star::sheet::XSheetConditionalEntries
-*   com::sun::star::container::XElementAccess
-* 
-* @see com.sun.star.sheet.TableConditionalFormat
-* @see com.sun.star.container.XNameAccess
-* @see 

[Libreoffice-commits] core.git: qadevOOo/objdsc sc/qa

2019-01-16 Thread Libreoffice Gerrit user
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableConditionalFormat.csv |
2 --
 sc/qa/extras/sctableconditionalformat.cxx|
7 +++
 2 files changed, 7 insertions(+), 2 deletions(-)

New commits:
commit 0b521ddd8396490939f1a2ee7dde8effbde6d82d
Author: Jens Carl 
AuthorDate: Wed Jan 16 21:12:17 2019 +
Commit: Jens Carl 
CommitDate: Thu Jan 17 01:42:32 2019 +0100

tdf#45904 Move XIndexAccess Java tests to C++

Move XIndexAccess Java tests to C++ for ScTableConditionalFormat.

Change-Id: I4eb40fb4c44967f6d6dba7ea093818adfc4aacfb
Reviewed-on: https://gerrit.libreoffice.org/66486
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git 
a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableConditionalFormat.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableConditionalFormat.csv
index 7f6fbb59c56e..3c950b80fa3c 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableConditionalFormat.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableConditionalFormat.csv
@@ -1,4 +1,2 @@
-"ScTableConditionalFormat";"com::sun::star::container::XIndexAccess";"getCount()"
-"ScTableConditionalFormat";"com::sun::star::container::XIndexAccess";"getByIndex()"
 
"ScTableConditionalFormat";"com::sun::star::container::XElementAccess";"getElementType()"
 
"ScTableConditionalFormat";"com::sun::star::container::XElementAccess";"hasElements()"
diff --git a/sc/qa/extras/sctableconditionalformat.cxx 
b/sc/qa/extras/sctableconditionalformat.cxx
index 75ebd3adb399..5209dd5ed882 100644
--- a/sc/qa/extras/sctableconditionalformat.cxx
+++ b/sc/qa/extras/sctableconditionalformat.cxx
@@ -9,6 +9,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -38,6 +39,7 @@ namespace sc_apitest
 {
 class ScTableConditionalFormat : public CalcUnoApiTest,
  public apitest::XEnumerationAccess,
+ public apitest::XIndexAccess,
  public apitest::XNameAccess,
  public apitest::XSheetConditionalEntries
 {
@@ -54,6 +56,10 @@ public:
 // XEnumerationAccess
 CPPUNIT_TEST(testCreateEnumeration);
 
+// XIndexAccess
+CPPUNIT_TEST(testGetByIndex);
+CPPUNIT_TEST(testGetCount);
+
 // XNameAccess
 CPPUNIT_TEST(testGetByName);
 CPPUNIT_TEST(testGetElementNames);
@@ -72,6 +78,7 @@ private:
 
 ScTableConditionalFormat::ScTableConditionalFormat()
 : CalcUnoApiTest("/sc/qa/extras/testdocuments")
+, XIndexAccess(2)
 , XNameAccess("Entry1")
 {
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: qadevOOo/objdsc sc/qa

2019-01-16 Thread Libreoffice Gerrit user
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableConditionalFormat.csv |
3 ---
 sc/qa/extras/sctableconditionalformat.cxx|   
10 +-
 2 files changed, 9 insertions(+), 4 deletions(-)

New commits:
commit b69b90bbeac795b15418b884ac4b26e35ceb08db
Author: Jens Carl 
AuthorDate: Wed Jan 16 21:08:22 2019 +
Commit: Jens Carl 
CommitDate: Thu Jan 17 01:41:00 2019 +0100

tdf#45904 Move XNameAccess Java tests to C++

Move XNameAccess Java tests to C++ for ScTableConditionalFormat.

Change-Id: I675d5d5aea24f76c19507d2a4181715ab70dd48d
Reviewed-on: https://gerrit.libreoffice.org/66485
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git 
a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableConditionalFormat.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableConditionalFormat.csv
index acfc8dac9c8e..7f6fbb59c56e 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableConditionalFormat.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableConditionalFormat.csv
@@ -1,6 +1,3 @@
-"ScTableConditionalFormat";"com::sun::star::container::XNameAccess";"getByName()"
-"ScTableConditionalFormat";"com::sun::star::container::XNameAccess";"getElementNames()"
-"ScTableConditionalFormat";"com::sun::star::container::XNameAccess";"hasByName()"
 
"ScTableConditionalFormat";"com::sun::star::container::XIndexAccess";"getCount()"
 
"ScTableConditionalFormat";"com::sun::star::container::XIndexAccess";"getByIndex()"
 
"ScTableConditionalFormat";"com::sun::star::container::XElementAccess";"getElementType()"
diff --git a/sc/qa/extras/sctableconditionalformat.cxx 
b/sc/qa/extras/sctableconditionalformat.cxx
index d19ceccce756..75ebd3adb399 100644
--- a/sc/qa/extras/sctableconditionalformat.cxx
+++ b/sc/qa/extras/sctableconditionalformat.cxx
@@ -9,6 +9,7 @@
 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -22,12 +23,12 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
 #include 
 #include 
-#include 
 
 using namespace css;
 using namespace css::uno;
@@ -37,6 +38,7 @@ namespace sc_apitest
 {
 class ScTableConditionalFormat : public CalcUnoApiTest,
  public apitest::XEnumerationAccess,
+ public apitest::XNameAccess,
  public apitest::XSheetConditionalEntries
 {
 public:
@@ -52,6 +54,11 @@ public:
 // XEnumerationAccess
 CPPUNIT_TEST(testCreateEnumeration);
 
+// XNameAccess
+CPPUNIT_TEST(testGetByName);
+CPPUNIT_TEST(testGetElementNames);
+CPPUNIT_TEST(testHasByName);
+
 // XSheetConditionalEntries
 CPPUNIT_TEST(testAddNew);
 CPPUNIT_TEST(testClear);
@@ -65,6 +72,7 @@ private:
 
 ScTableConditionalFormat::ScTableConditionalFormat()
 : CalcUnoApiTest("/sc/qa/extras/testdocuments")
+, XNameAccess("Entry1")
 {
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #208 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/b69b90bbeac795b15418b884ac4b26e35ceb08db%5E%21

tdf#45904 Move XNameAccess Java tests to C++

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - 2 commits - vcl/qt5

2019-01-16 Thread Libreoffice Gerrit user
 vcl/qt5/Qt5Bitmap.cxx|4 
 vcl/qt5/Qt5Graphics_Text.cxx |7 ++-
 2 files changed, 10 insertions(+), 1 deletion(-)

New commits:
commit 15a9a00deea6dac77816862e6d6e0efcf5ea665f
Author: Jan-Marek Glogowski 
AuthorDate: Mon Dec 17 15:07:26 2018 +0100
Commit: Thorsten Behrens 
CommitDate: Thu Jan 17 00:49:34 2019 +0100

Qt5 don't re-register system fonts

System fonts are already registered in the QFontDatabase. And
addApplicationFont seems to be really expensive especially when
registering large fonts like the Noto CJK fonts, which increases
load time by 4 seconds per font.

This skips all font + style combinations already known in the DB.
Since addApplicationFont already relies on fontconfig on Unix/X11
this should be fine.

Change-Id: Ief13a613abd99b9fe391d9afe868541035340d1c
Reviewed-on: https://gerrit.libreoffice.org/65270
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 
(cherry picked from commit 5d13f3efe0157559d3625c6b8fe7e9741e601215)
Reviewed-on: https://gerrit.libreoffice.org/65290
(cherry picked from commit 6d3faf6a048eedf3fe4a1f43545eeda38adb2763)
Reviewed-on: https://gerrit.libreoffice.org/66457
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/vcl/qt5/Qt5Graphics_Text.cxx b/vcl/qt5/Qt5Graphics_Text.cxx
index 37a0879b0044..f63756c768f7 100644
--- a/vcl/qt5/Qt5Graphics_Text.cxx
+++ b/vcl/qt5/Qt5Graphics_Text.cxx
@@ -101,6 +101,7 @@ void Qt5Graphics::GetDevFontList(PhysicalFontCollection* 
pPFC)
 
 if (bUseFontconfig)
 {
+const QStringList aFontFamilyList = aFDB.families();
 ::std::vector aList;
 psp::FastPrintFontInfo aInfo;
 
@@ -112,7 +113,11 @@ void Qt5Graphics::GetDevFontList(PhysicalFontCollection* 
pPFC)
 continue;
 QString aFilename = toQString(
 OStringToOUString(rMgr.getFontFileSysPath(aInfo.m_nID), 
RTL_TEXTENCODING_UTF8));
-QFontDatabase::addApplicationFont(aFilename);
+QRawFont aRawFont(aFilename, 0.0);
+QString aFamilyName = aRawFont.familyName();
+if (!aFontFamilyList.contains(aFamilyName)
+|| !aFDB.styles(aFamilyName).contains(aRawFont.styleName()))
+QFontDatabase::addApplicationFont(aFilename);
 }
 
 SalGenericInstance::RegisterFontSubstitutors(pPFC);
commit ba48f577c51e3e39f56438b56582973e14f7ed01
Author: Aleksei Nikiforov 
AuthorDate: Mon Dec 17 15:31:16 2018 +0300
Commit: Thorsten Behrens 
CommitDate: Thu Jan 17 00:49:19 2019 +0100

Qt5: fix color bits interpretation for 32bit ARGB image formats

Change-Id: Iea8547089a0ce2dc9f6a06b84552f4261fbfa0f1
Reviewed-on: https://gerrit.libreoffice.org/65311
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 
(cherry picked from commit 7802d99c35f5acfa43203f1dd6d1752af4e7c0b6)
Reviewed-on: https://gerrit.libreoffice.org/65332
Reviewed-by: Aleksei Nikiforov 
Reviewed-on: https://gerrit.libreoffice.org/66458
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/vcl/qt5/Qt5Bitmap.cxx b/vcl/qt5/Qt5Bitmap.cxx
index 73df8c1c98e5..aac79e4181a5 100644
--- a/vcl/qt5/Qt5Bitmap.cxx
+++ b/vcl/qt5/Qt5Bitmap.cxx
@@ -263,7 +263,11 @@ BitmapBuffer* Qt5Bitmap::AcquireBuffer(BitmapAccessMode 
/*nMode*/)
 break;
 case 32:
 {
+#ifdef OSL_BIGENDIAN
 pBuffer->mnFormat = ScanlineFormat::N32BitTcArgb | 
ScanlineFormat::TopDown;
+#else
+pBuffer->mnFormat = ScanlineFormat::N32BitTcBgra | 
ScanlineFormat::TopDown;
+#endif
 pBuffer->maPalette = aEmptyPalette;
 break;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 122773] Vertical docked toolbar has broken icons

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122773

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Xisco Faulí  ---


*** This bug has been marked as a duplicate of bug 122761 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122761] Artifacts on the draw toolbar

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122761

Xisco Faulí  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #3 from Xisco Faulí  ---
*** Bug 122773 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122773] New: Vertical docked toolbar has broken icons

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122773

Bug ID: 122773
   Summary: Vertical docked toolbar has broken icons
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Keywords: regression
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 148382
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148382=edit
Screenshot of broken icons

Some icons in vertical docked toolbar are broken. They are displayed with black
triangle. Not all icons are affected. The "Drawing" toolbar has a lot of broken
icons.

I see the error in Version: 6.3.0.0.alpha0+ (x64)
Build ID: 86501f577638b44042c35e601d13651992b64fd5
CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

The error is newly introduced. I'm quite sure it was OK two days ago, but I
have no longer a build to test it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122260] EDITING Autofilters not properly cleared

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122260

Xisco Faulí  changed:

   What|Removed |Added

Version|6.2.0.1 rc  |6.1.0.0.alpha0+
 CC||serge.k...@cib.de,
   ||t...@libreoffice.org
   Keywords|bibisectRequest |bibisected, bisected

--- Comment #6 from Xisco Faulí  ---
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=c8a739a2c84f45f878d2ae75eaf16a2f814d1c6e

author  Serge Krot   2018-06-07 18:02:50 +0200
committer   Katarina Behrens   2018-06-12
16:09:33 +0200
commit  c8a739a2c84f45f878d2ae75eaf16a2f814d1c6e (patch)
tree034a7a24a6eb90d7a9e9e3c3523bf068092621ec
parent  df652aa70869f42ada2f4d8e7d1cacf55c6e6e96 (diff)
tdf#117276 filter reset: check complete data range selected

Bisected with: bibisect-linux64-6.2

Adding Cc: to Serge Krot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'aoo/trunk' - solenv/inc

2019-01-16 Thread Libreoffice Gerrit user
 solenv/inc/minor.mk |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit a1f6a5d075edc1b5060a62838ac502d9ac672bd8
Author: Jim Jagielski 
AuthorDate: Wed Jan 16 21:55:08 2019 +
Commit: Jim Jagielski 
CommitDate: Wed Jan 16 21:55:08 2019 +

Use something smaller for a build number for 4.5.0 (but leave room for 
4.2/3/4.0)

diff --git a/solenv/inc/minor.mk b/solenv/inc/minor.mk
index d2c9684586ca..f39950ec596f 100644
--- a/solenv/inc/minor.mk
+++ b/solenv/inc/minor.mk
@@ -21,7 +21,7 @@
 # $Id$
 
 RSCVERSION=450
-RSCREVISION=450m1(Build:1009800)
-BUILD=1009800
+RSCREVISION=450m1(Build:1)
+BUILD=1
 LAST_MINOR=m1
 SOURCEVERSION=AOO450
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 122214] Keyboard navigation skips set items by one for value set control (gtk2, windows)

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122214

Jim Raykowski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||2656

--- Comment #1 from Jim Raykowski  ---
bug no longer present in:

Version: 6.3.0.0.alpha0+
Build ID: 8b461713c0c86bc19af739aada4b1345cfa5dfbe
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

Resolved by fix for bug 122656

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122260] EDITING Autofilters not properly cleared

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122260

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
   Hardware|x86-64 (AMD64)  |All
 OS|Windows (All)   |All
   Keywords||bibisectRequest, regression

--- Comment #5 from Xisco Faulí  ---
Not reproduced in

Version: 5.4.0.0.alpha1+
Build ID: 9feb7f7039a3b59974cbf266922177e961a52dd1
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

-> regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/CppunitTest_sc_tableconditionalformat.mk sc/CppunitTest_sc_tableconditionalformatobj.mk sc/Module_sc.mk sc/qa

2019-01-16 Thread Libreoffice Gerrit user
 sc/CppunitTest_sc_tableconditionalformat.mk |   22 +++---
 sc/Module_sc.mk |2 +-
 sc/qa/extras/sctableconditionalformat.cxx   |   24 
 3 files changed, 24 insertions(+), 24 deletions(-)

New commits:
commit 1ffde9252f4583264a1f90449b9ea7cf83c2e9d9
Author: Jens Carl 
AuthorDate: Wed Jan 16 20:59:36 2019 +
Commit: Jens Carl 
CommitDate: Wed Jan 16 23:50:30 2019 +0100

Rename ScTableConditionalFormatObj to ScTableConditionalFormat

Rename ScTableConditionalFormatObj to ScTableConditionalFormat to match
the object name to test against.

Change-Id: Ic14bc1181a6c0724e0973955119d9f2e731d0940
Reviewed-on: https://gerrit.libreoffice.org/66484
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/sc/CppunitTest_sc_tableconditionalformatobj.mk 
b/sc/CppunitTest_sc_tableconditionalformat.mk
similarity index 80%
rename from sc/CppunitTest_sc_tableconditionalformatobj.mk
rename to sc/CppunitTest_sc_tableconditionalformat.mk
index 07e53f82b787..7809cd1e5179 100644
--- a/sc/CppunitTest_sc_tableconditionalformatobj.mk
+++ b/sc/CppunitTest_sc_tableconditionalformat.mk
@@ -9,15 +9,15 @@
 #
 #*
 
-$(eval $(call gb_CppunitTest_CppunitTest,sc_tableconditionalformatobj))
+$(eval $(call gb_CppunitTest_CppunitTest,sc_tableconditionalformat))
 
-$(eval $(call 
gb_CppunitTest_use_external,sc_tableconditionalformatobj,boost_headers))
+$(eval $(call 
gb_CppunitTest_use_external,sc_tableconditionalformat,boost_headers))
 
-$(eval $(call 
gb_CppunitTest_add_exception_objects,sc_tableconditionalformatobj, \
-   sc/qa/extras/sctableconditionalformatobj \
+$(eval $(call gb_CppunitTest_add_exception_objects,sc_tableconditionalformat, \
+   sc/qa/extras/sctableconditionalformat \
 ))
 
-$(eval $(call gb_CppunitTest_use_libraries,sc_tableconditionalformatobj, \
+$(eval $(call gb_CppunitTest_use_libraries,sc_tableconditionalformat, \
cppu \
sal \
subsequenttest \
@@ -25,20 +25,20 @@ $(eval $(call 
gb_CppunitTest_use_libraries,sc_tableconditionalformatobj, \
unotest \
 ))
 
-$(eval $(call gb_CppunitTest_set_include,sc_tableconditionalformatobj,\
+$(eval $(call gb_CppunitTest_set_include,sc_tableconditionalformat,\
-I$(SRCDIR)/sc/inc \
$$(INCLUDE) \
 ))
 
-$(eval $(call gb_CppunitTest_use_sdk_api,sc_tableconditionalformatobj))
+$(eval $(call gb_CppunitTest_use_sdk_api,sc_tableconditionalformat))
 
-$(eval $(call gb_CppunitTest_use_ure,sc_tableconditionalformatobj))
-$(eval $(call gb_CppunitTest_use_vcl,sc_tableconditionalformatobj))
+$(eval $(call gb_CppunitTest_use_ure,sc_tableconditionalformat))
+$(eval $(call gb_CppunitTest_use_vcl,sc_tableconditionalformat))
 
-$(eval $(call gb_CppunitTest_use_components,sc_tableconditionalformatobj,\
+$(eval $(call gb_CppunitTest_use_components,sc_tableconditionalformat,\
$(sc_unoapi_common_components) \
 ))
 
-$(eval $(call gb_CppunitTest_use_configuration,sc_tableconditionalformatobj))
+$(eval $(call gb_CppunitTest_use_configuration,sc_tableconditionalformat))
 
 # vim: set noet sw=4 ts=4:
diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk
index 6ee193103f70..761511caca05 100644
--- a/sc/Module_sc.mk
+++ b/sc/Module_sc.mk
@@ -181,7 +181,7 @@ $(eval $(call gb_Module_add_subsequentcheck_targets,sc,\
CppunitTest_sc_subtotaldescriptorbaseobj \
CppunitTest_sc_subtotalfieldobj \
CppunitTest_sc_tableconditionalentryobj \
-   CppunitTest_sc_tableconditionalformatobj \
+   CppunitTest_sc_tableconditionalformat \
CppunitTest_sc_tablerowsobj \
CppunitTest_sc_tablesheetobj \
CppunitTest_sc_tablesheetsobj \
diff --git a/sc/qa/extras/sctableconditionalformatobj.cxx 
b/sc/qa/extras/sctableconditionalformat.cxx
similarity index 84%
rename from sc/qa/extras/sctableconditionalformatobj.cxx
rename to sc/qa/extras/sctableconditionalformat.cxx
index adb0ae023820..d19ceccce756 100644
--- a/sc/qa/extras/sctableconditionalformatobj.cxx
+++ b/sc/qa/extras/sctableconditionalformat.cxx
@@ -35,19 +35,19 @@ using namespace com::sun::star;
 
 namespace sc_apitest
 {
-class ScTableConditionalFormatObj : public CalcUnoApiTest,
-public apitest::XEnumerationAccess,
-public apitest::XSheetConditionalEntries
+class ScTableConditionalFormat : public CalcUnoApiTest,
+ public apitest::XEnumerationAccess,
+ public apitest::XSheetConditionalEntries
 {
 public:
-ScTableConditionalFormatObj();
+ScTableConditionalFormat();
 
 virtual uno::Reference init() override;
 virtual uno::Sequence createCondition(const 
sal_Int32 nr) override;
 virtual void setUp() override;
 virtual void tearDown() override;
 
-CPPUNIT_TEST_SUITE(ScTableConditionalFormatObj);
+

[Libreoffice-bugs] [Bug 118519] LibO apps can not be closed by esc button

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118519

janko.kinces...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

--- Comment #6 from janko.kinces...@gmail.com ---
Dear company, when i press button called send error, then web browser app
opens. I expected little window in libre office to open with option to send
screenshot when i press send error button. Also system look fine now. Please
make app closable with esc button.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122226] DOCX Import Pie chart data labels new line separator changes to semicolon

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=16

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
Version|6.3.0.0.alpha0+ Master  |4.4 all versions

--- Comment #5 from Xisco Faulí  ---
Also reproduced in

Version: 5.2.0.0.alpha0+
Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53
Threads 4; Ver: 4.15; Render: default; 

Version: 4.3.0.0.alpha1+
Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121842] Hyperlinks in user-defined index does not work

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121842

Xisco Faulí  changed:

   What|Removed |Added

Version|6.3.0.0.alpha0+ Master  |4.1.3.2 release

--- Comment #3 from Xisco Faulí  ---
I guess we can use the same version as bug 71385

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108075] [META] Scrolling and Page up/down issues

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108075

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||119523


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=119523
[Bug 119523] Scrolling with touchpad in the slides pane is way too fast
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 119523] Scrolling with touchpad in the slides pane is way too fast

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119523

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||108075
 CC||vstuart.fo...@utsa.edu


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108075
[Bug 108075] [META] Scrolling and Page up/down issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122052] Undo Sequence Seems Incorrect When Undo-ing Auto Link/Email Formatting Created on Enter/Newline

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122052

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
 CC||xiscofa...@libreoffice.org

--- Comment #2 from Xisco Faulí  ---
i can't reproduce it in

Version: 6.3.0.0.alpha0+
Build ID: 1bf68dbf53f4b5308e295058226abd6d6fb49c3d
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

Steps:
1. I paste My email address is someb...@libreoffice.org
2. Enter
3. Undo -> Formatting is removed
4. Undo -> newline is removed

Could you please try to reproduce it with a master build from
http://dev-builds.libreoffice.org/daily/master/ ?
You can install it alongside the standard version.
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the master build

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: Buiiding LO6.1.4.2 with pdfium emits “error: invalid conversion from ‘int’ to ‘boolean’ [-fpermissive]”

2019-01-16 Thread Eike Rathke
Hi Дилян,

On Wednesday, 2019-01-16 15:11:26 +, Дилян Палаузов wrote:

> configurig LO 6.1.4.2 with
> ../configure --without-doxygen --with-jdk-home=/opt/jdk --with-ant-home=/opt
> /ant --without-junit
> 
> fails with
> 
> /usr/local/lib/gcc/x86_64-pc-linux-gnu/8.2.1/../../../../x86_64-pc-linux-gnu/bin/ld:
>  /src/libreoffice-
> 6.1.4.2/build3/workdir/CxxObject/l10ntools/source/xmlparse.o: in function 
> `(anonymous
> namespace)::lcl_QuotRange(icu_61::UnicodeString const&, int, int, bool)':
> xmlparse.cxx:(.text+0x92): undefined reference to `vtable for 
> icu_61::UnicodeString'

Looks like you didn't issue a  make clean   command after generating
your new configure that switches from various --with-system-..., in
particular --with-system-icu, to without. This may leave the build in an
indetermined state where it isn't known what to recompile or which
libraries to link against.

  Eike

-- 
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 122769] Touch-pad scroll speed too fast and too sensitive to be useful only in Libre Writer and Calc

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122769

V Stuart Foote  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||vstuart.fo...@utsa.edu
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 119745 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121684] Scroll speed unmanageably fast when using touchpad in windows

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121684

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #6 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 119745 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 119745] Scrolling with a laptop touchpad in Libreoffice way too fast

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119745

V Stuart Foote  changed:

   What|Removed |Added

 CC||nachodelosr...@gmail.com

--- Comment #8 from V Stuart Foote  ---
*** Bug 121684 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 119745] Scrolling with a laptop touchpad in Libreoffice way too fast

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119745

V Stuart Foote  changed:

   What|Removed |Added

 CC||skryfdit...@gmail.com

--- Comment #9 from V Stuart Foote  ---
*** Bug 122769 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122759] AutoFilter list is created not case sensitive but filtering is case sensitive

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122759

--- Comment #8 from Gabor Kelemen  ---
Created attachment 148380
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148380=edit
Autofilter in Calc 6.0.7

No repro with:

Verzió: 6.0.7.3
Build az.: 1:6.0.7-0ubuntu0.18.04.2
CPU szálak: 4; OS: Linux 4.15; Felületmegjelenítés: alapértelmezett; VCL: gtk3; 
Területi beállítások: hu-HU (hu_HU.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122157] "Open Remote File" silently fails on Win & OSX when using ssh, dav, or smb

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122157

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #6 from Xisco Faulí  ---
Is this a duplicate of bug 98897 ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122759] AutoFilter list is created not case sensitive but filtering is case sensitive

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122759

--- Comment #7 from Gabor Kelemen  ---
Created attachment 148379
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148379=edit
Autofilter in current Calc master

Version: 6.3.0.0.alpha0+
Build ID: 5843e14a4ddc6d2b1e375ca26eec33033bfad455
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: hu-HU (hu_HU.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122346] Font features set in dialog are not applied nor font is changed

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122346

Xisco Faulí  changed:

   What|Removed |Added

   Priority|medium  |high
   Keywords|implementationError |bibisected, bisected,
   ||regression
   Severity|normal  |major
 CC||caol...@redhat.com,
   ||xiscofa...@libreoffice.org

--- Comment #5 from Xisco Faulí  ---
Regression introduced by:

author  Caolán McNamara 2018-09-10 17:19:19 +0100
committer   Caolán McNamara 2018-09-14 11:43:51
+0100
commit  9237a905fa5f2b67db73c15847eff203a258c2b4 (patch)
treebf213e7f3fd7322ee032af9fa648d04c99faaba1
parent  34f6b7f4529cc5a3b0e286fbd7318c2b7bf9b132 (diff)
weld SvxCharNamePage

Bisected with: bibisect-linux64-6.2

Adding Cc: to Caolán McNamara

Once Lowercase to Small Capitals is selected the family dropdownlist should
change to Linux Libertine G:smcp, however it becomes blank in GTK/GEN and the
:smcp is not passed in GTK3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122759] AutoFilter list is created not case sensitive but filtering is case sensitive

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122759

--- Comment #6 from Gabor Kelemen  ---
Okay, the xlsx attachment is not a good example, sorry.

Try with a new document, in current 6.3 master I can reproduce it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 37494] Find \n replace\n does NOT work (regular expressions work wrong in Impress)

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=37494

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||2764

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122764] find and replace dialog - regular expression missing

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122764

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=37
   ||494
 CC||vstuart.fo...@utsa.edu

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122772] New: Table splits after AutoFilter popup menu use

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122772

Bug ID: 122772
   Summary: Table splits after AutoFilter popup menu use
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rayk...@gmail.com

Steps to repro:

1. Enter some data to cells in a column
2. Menu->Data->AutoFilter
3. Click on the AutoFilter popup menu button in cell
AutoFilter popup menu opens, cursor is in 'Search items...' edit box
4. Press down arrow key
cursor disappears
5. Press esc key
AutoFilter popup menu closes
6. Press down arrow
Table splits
7. Press arrow keys to split table horizontally and vertically

Results:
Table splits

Expected results:
Table cell navigation

Version: 6.3.0.0.alpha0+
Build ID: 8b461713c0c86bc19af739aada4b1345cfa5dfbe
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122762] Cannot use Java 1.8.0.191 on windows 10

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122762

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from V Stuart Foote  ---
Can not confirm on Windows 10 Ent 64-bit en-US with
Version: 6.1.4.2 (x64)
Build ID: 9d0f32d1f0b509096fd65e0d4bec26ddd1938fd3
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
Locale: en-US (en_US); Calc: CL

The required 64-bit Java JRE (1.8.0_201) is found and its radio button can be
checked active.

Be sure you have the 64-bit JRE needed to match your LO build installed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122318] Not possible to create a dynamic Named Range with a calculated reference (like with OFFSET) and use it as a Print Range, like Excel can.

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122318

Xisco Faulí  changed:

   What|Removed |Added

 CC||er...@redhat.com,
   ||winfrieddonkers@libreoffice
   ||.org

--- Comment #2 from Xisco Faulí  ---
@Eike, @Winfried, I thought you might be interested in this issue...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122318] Not possible to create a dynamic Named Range with a calculated reference (like with OFFSET) and use it as a Print Range, like Excel can.

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122318

Xisco Faulí  changed:

   What|Removed |Added

   Severity|normal  |enhancement
 CC||xiscofa...@libreoffice.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120917] Tab key at the beginning of heading has strange and inconsistent effects

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120917

Xisco Faulí  changed:

   What|Removed |Added

Version|6.1.2.1 release |Inherited From OOo

--- Comment #7 from Xisco Faulí  ---
Also reproduced in

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122222] FILEOPEN DOCX The comment marked as done property is lost in Writer

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=12

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
Version|6.3.0.0.alpha0+ Master  |4.1 all versions

--- Comment #8 from Xisco Faulí  ---
Also reproduced in

Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122254] LO Impress Presentation minimizer: Text at the 3rd line is cut in the final message

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122254

Xisco Faulí  changed:

   What|Removed |Added

Version|6.2.0.0.beta1+  |Inherited From OOo
 CC||xiscofa...@libreoffice.org
 OS|Linux (All) |All

--- Comment #3 from Xisco Faulí  ---
Also reproduced in

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

I guess we shoud shorten the name instead of the message...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 108844] [META] Cut/copy bugs and enhancements

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108844
Bug 108844 depends on bug 122385, which changed state.

Bug 122385 Summary: EDITING Calc freezes at copy or cut
https://bugs.documentfoundation.org/show_bug.cgi?id=122385

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122435] LibreOffice hangs when in Calc copying formula while in edit mode then leaving field with escape

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122435

Xisco Faulí  changed:

   What|Removed |Added

 CC||stefan_lange...@t-online.de

--- Comment #11 from Xisco Faulí  ---
*** Bug 122385 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122385] EDITING Calc freezes at copy or cut

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122385

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED
   Keywords||bibisectRequest, regression

--- Comment #2 from Xisco Faulí  ---
Seems to be similar to bug 122435.
@Oliver Brinzing, @Stefan Lange, if you see it's a regression as indicated in
the description, please add the regression keyword...

*** This bug has been marked as a duplicate of bug 122435 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122768] When selecting a certain printer Writer crashes

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122768

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Xisco Faulí  ---
Could you please try to reproduce it with LibreOffice 6.2 from
https://wiki.documentfoundation.org/QA/GetInvolved#Test_Pre-releases?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/inc vcl/qt5

2019-01-16 Thread Libreoffice Gerrit user
 vcl/inc/qt5/Qt5Menu.hxx |5 +
 vcl/qt5/Qt5Menu.cxx |  163 
 2 files changed, 154 insertions(+), 14 deletions(-)

New commits:
commit aa3ef0a5efa3da3fe1d06509af52fe46fe8c6c81
Author: Aleksei Nikiforov 
AuthorDate: Fri Jan 11 16:39:55 2019 +0300
Commit: Thorsten Behrens 
CommitDate: Wed Jan 16 22:41:18 2019 +0100

KDE5: Fix radiocheck menu items

This change fixes displaying of elements of 'Styles' menu of Writer

Change-Id: I455a4f1c37aa7bc6641ebdd15eec23f18a8430d9
Reviewed-on: https://gerrit.libreoffice.org/66387
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/vcl/inc/qt5/Qt5Menu.hxx b/vcl/inc/qt5/Qt5Menu.hxx
index 2f6e1a085fc8..91e1c3e116d5 100644
--- a/vcl/inc/qt5/Qt5Menu.hxx
+++ b/vcl/inc/qt5/Qt5Menu.hxx
@@ -34,13 +34,15 @@ private:
 bool mbMenuBar;
 QMenuBar* mpQMenuBar;
 QMenu* mpQMenu;
-QActionGroup* mpQActionGroup;
 
 void DoFullMenuUpdate(Menu* pMenuBar);
 static void NativeItemText(OUString& rItemText);
 
 QMenu* InsertMenuItem(Qt5MenuItem* pSalMenuItem, unsigned nPos);
 
+void ReinitializeActionGroup(unsigned nPos);
+void ResetAllActionGroups();
+
 public:
 Qt5Menu(bool bMenuBar);
 
@@ -88,6 +90,7 @@ public:
 Qt5Menu* mpSubMenu; // Submenu of this item (if defined)
 std::unique_ptr mpAction; // action corresponding to this item
 std::unique_ptr mpMenu; // menu corresponding to this item
+std::shared_ptr mpActionGroup; // empty if it's a separator 
element
 sal_uInt16 mnId; // Item ID
 MenuItemType mnType; // Item type
 bool mbVisible; // Item visibility.
diff --git a/vcl/qt5/Qt5Menu.cxx b/vcl/qt5/Qt5Menu.cxx
index ceaf0d9138f9..8fee56a9cf70 100644
--- a/vcl/qt5/Qt5Menu.cxx
+++ b/vcl/qt5/Qt5Menu.cxx
@@ -27,7 +27,6 @@ Qt5Menu::Qt5Menu(bool bMenuBar)
 , mbMenuBar(bMenuBar)
 , mpQMenuBar(nullptr)
 , mpQMenu(nullptr)
-, mpQActionGroup(nullptr)
 {
 connect(this, ::setFrameSignal, this, ::SetFrame, 
Qt::BlockingQueuedConnection);
 }
@@ -90,7 +89,11 @@ QMenu* Qt5Menu::InsertMenuItem(Qt5MenuItem* pSalMenuItem, 
unsigned nPos)
 }
 
 pQMenu = pTempQMenu;
-mpQActionGroup = new QActionGroup(pQMenu);
+
+ReinitializeActionGroup(nPos);
+
+// clear all action groups since menu is recreated
+pSalMenuItem->mpSubMenu->ResetAllActionGroups();
 
 connect(pQMenu, ::aboutToShow, this,
 [pSalMenuItem] { slotMenuAboutToShow(pSalMenuItem); });
@@ -114,6 +117,8 @@ QMenu* Qt5Menu::InsertMenuItem(Qt5MenuItem* pSalMenuItem, 
unsigned nPos)
 {
 pQMenu->addAction(pAction);
 }
+
+ReinitializeActionGroup(nPos);
 }
 else
 {
@@ -131,6 +136,8 @@ QMenu* Qt5Menu::InsertMenuItem(Qt5MenuItem* pSalMenuItem, 
unsigned nPos)
 pQMenu->addAction(pAction);
 }
 
+ReinitializeActionGroup(nPos);
+
 
pAction->setShortcut(toQString(nAccelKey.GetName(GetFrame()->GetWindow(;
 
 if (itemBits & MenuItemBits::CHECKABLE)
@@ -141,15 +148,12 @@ QMenu* Qt5Menu::InsertMenuItem(Qt5MenuItem* pSalMenuItem, 
unsigned nPos)
 else if (itemBits & MenuItemBits::RADIOCHECK)
 {
 pAction->setCheckable(true);
-if (!mpQActionGroup)
+
+if (pSalMenuItem->mpActionGroup)
 {
-mpQActionGroup = new QActionGroup(pQMenu);
-mpQActionGroup->setExclusive(true);
+pSalMenuItem->mpActionGroup->addAction(pAction);
 }
-// NOTE: QActionGroup support may need improvement
-// if menu item is added not to the end of menu,
-// it may be needed to add new item to QActionGroup 
different from last created one for this menu
-mpQActionGroup->addAction(pAction);
+
 pAction->setChecked(bChecked);
 }
 
@@ -165,6 +169,130 @@ QMenu* Qt5Menu::InsertMenuItem(Qt5MenuItem* pSalMenuItem, 
unsigned nPos)
 return pQMenu;
 }
 
+void Qt5Menu::ReinitializeActionGroup(unsigned nPos)
+{
+const unsigned nCount = GetItemCount();
+
+if (nCount == 0)
+{
+return;
+}
+
+if (nPos == MENU_APPEND)
+{
+nPos = nCount - 1;
+}
+else if (nPos >= nCount)
+{
+return;
+}
+
+Qt5MenuItem* pPrevItem = (nPos > 0) ? GetItemAtPos(nPos - 1) : nullptr;
+Qt5MenuItem* pCurrentItem = GetItemAtPos(nPos);
+Qt5MenuItem* pNextItem = (nPos < nCount - 1) ? GetItemAtPos(nPos + 1) : 
nullptr;
+
+if (pCurrentItem->mnType == MenuItemType::SEPARATOR)
+{
+pCurrentItem->mpActionGroup.reset();
+
+// if it's inserted into middle of existing group, 

[Libreoffice-commits] core.git: vcl/inc vcl/qt5

2019-01-16 Thread Libreoffice Gerrit user
 vcl/inc/qt5/Qt5Menu.hxx |1 -
 vcl/qt5/Qt5Menu.cxx |8 +++-
 2 files changed, 3 insertions(+), 6 deletions(-)

New commits:
commit f9231f054e5b6597ae8a92da165a1841e4199378
Author: Aleksei Nikiforov 
AuthorDate: Fri Jan 11 16:41:19 2019 +0300
Commit: Thorsten Behrens 
CommitDate: Wed Jan 16 22:39:53 2019 +0100

KDE5: minor Qt5Menu cleanup

Remove unnecessary destructor

Move MenuBar clearing out of DoFullMenuUpdate function

Change-Id: I0fb916c6935b2f8a675e75adf696d99203a2c016
Reviewed-on: https://gerrit.libreoffice.org/66386
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/vcl/inc/qt5/Qt5Menu.hxx b/vcl/inc/qt5/Qt5Menu.hxx
index d42f8ab85186..2f6e1a085fc8 100644
--- a/vcl/inc/qt5/Qt5Menu.hxx
+++ b/vcl/inc/qt5/Qt5Menu.hxx
@@ -43,7 +43,6 @@ private:
 
 public:
 Qt5Menu(bool bMenuBar);
-virtual ~Qt5Menu() override;
 
 virtual bool VisibleMenuBar() override; // must return TRUE to actually 
DISPLAY native menu bars
 
diff --git a/vcl/qt5/Qt5Menu.cxx b/vcl/qt5/Qt5Menu.cxx
index 9aaea199eeae..ceaf0d9138f9 100644
--- a/vcl/qt5/Qt5Menu.cxx
+++ b/vcl/qt5/Qt5Menu.cxx
@@ -32,8 +32,6 @@ Qt5Menu::Qt5Menu(bool bMenuBar)
 connect(this, ::setFrameSignal, this, ::SetFrame, 
Qt::BlockingQueuedConnection);
 }
 
-Qt5Menu::~Qt5Menu() { maItems.clear(); }
-
 bool Qt5Menu::VisibleMenuBar() { return true; }
 
 QMenu* Qt5Menu::InsertMenuItem(Qt5MenuItem* pSalMenuItem, unsigned nPos)
@@ -227,6 +225,9 @@ void Qt5Menu::SetFrame(const SalFrame* pFrame)
 if (pMainWindow)
 {
 mpQMenuBar = pMainWindow->menuBar();
+if (mpQMenuBar)
+mpQMenuBar->clear();
+
 mpQMenu = nullptr;
 mpQActionGroup = nullptr;
 
@@ -236,9 +237,6 @@ void Qt5Menu::SetFrame(const SalFrame* pFrame)
 
 void Qt5Menu::DoFullMenuUpdate(Menu* pMenuBar)
 {
-if (mbMenuBar && mpQMenuBar)
-mpQMenuBar->clear();
-
 for (sal_Int32 nItem = 0; nItem < static_cast(GetItemCount()); 
nItem++)
 {
 Qt5MenuItem* pSalMenuItem = GetItemAtPos(nItem);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/inc vcl/qt5

2019-01-16 Thread Libreoffice Gerrit user
 vcl/inc/qt5/Qt5Widget.hxx |2 ++
 vcl/qt5/Qt5Widget.cxx |   16 
 2 files changed, 18 insertions(+)

New commits:
commit 5843e14a4ddc6d2b1e375ca26eec33033bfad455
Author: Aleksei Nikiforov 
AuthorDate: Wed Jan 16 14:57:42 2019 +0300
Commit: Thorsten Behrens 
CommitDate: Wed Jan 16 22:38:30 2019 +0100

tdf#122238 KDE5: disable mechanism of Qt for shortcut activation

When QEvent::KeyPress event is processed, QEvent::ShortcutOverride event is 
created
and processed before finishing processing original event.

If it's an active shortcut, and QEvent::ShortcutOverride event is not 
accepted,
the shortcut is activated, but QEvent::KeyPress event is omitted.
If it's an active shortcut, and QEvent::ShortcutOverride event is accepted,
the shortcut is not activated, and QEvent::KeyPress event is sent as usual.

But it looks like even if shortcut activation is suppressed,
shortcut is still called somewhere from insides SalEvent::KeyInput
event processing callback from Qt5Widget::handleKeyEvent function.

Shortcuts are still assigned to menu actions
since it shows the key combinations used to activate them.

Change-Id: I1ffc63c2530dd61ae67ab66a96ea3efe767218c0
Reviewed-on: https://gerrit.libreoffice.org/66444
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/vcl/inc/qt5/Qt5Widget.hxx b/vcl/inc/qt5/Qt5Widget.hxx
index 26f26c8bf0a3..4337792dfc43 100644
--- a/vcl/inc/qt5/Qt5Widget.hxx
+++ b/vcl/inc/qt5/Qt5Widget.hxx
@@ -45,6 +45,8 @@ class Qt5Widget : public QWidget
 bool handleKeyEvent(QKeyEvent*, bool);
 void handleMouseButtonEvent(QMouseEvent*, bool);
 
+virtual bool event(QEvent*) override;
+
 virtual void focusInEvent(QFocusEvent*) override;
 virtual void focusOutEvent(QFocusEvent*) override;
 virtual void keyPressEvent(QKeyEvent*) override;
diff --git a/vcl/qt5/Qt5Widget.cxx b/vcl/qt5/Qt5Widget.cxx
index e96a1b1904b3..6d75cd60df73 100644
--- a/vcl/qt5/Qt5Widget.cxx
+++ b/vcl/qt5/Qt5Widget.cxx
@@ -395,6 +395,22 @@ bool Qt5Widget::handleKeyEvent(QKeyEvent* pEvent, bool 
bDown)
 return bStopProcessingKey;
 }
 
+bool Qt5Widget::event(QEvent* pEvent)
+{
+if (pEvent->type() == QEvent::ShortcutOverride)
+{
+// Accepted event disables shortcut activation,
+// but enables keypress event.
+// If event is not accepted and shortcut is successfully activated,
+// KeyPress event is omitted.
+// It looks like handleKeyEvent function still activates the shortcut 
on KeyPress event,
+// so there's no harm in disabling shortcut activation via Qt 
mechanisms.
+pEvent->accept();
+}
+
+return QWidget::event(pEvent);
+}
+
 void Qt5Widget::keyPressEvent(QKeyEvent* pEvent)
 {
 if (handleKeyEvent(pEvent, true))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - vcl/qt5

2019-01-16 Thread Libreoffice Gerrit user
 vcl/qt5/Qt5FilePicker.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 73d75d17b6fde2a5ebf0e1721cba988db497ee18
Author: Aleksei Nikiforov 
AuthorDate: Tue Dec 18 16:39:57 2018 +0300
Commit: Thorsten Behrens 
CommitDate: Wed Jan 16 22:31:08 2019 +0100

Qt5: remove assert leading to crash while executing 'open' dialog

When Writer is opened using "qt5" VCL plugin,
opening menu item "File" -> "Open" leads to a crash
due to presence of mentioned assert.

Impress crashes same way when same menu item is used.

Change-Id: I9d1937344c694d4f4620be1b71d1181eb9645427
Reviewed-on: https://gerrit.libreoffice.org/65344
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
(cherry picked from commit dd2421b148fedc40547ccff8b332285047a0b09e)
Reviewed-on: https://gerrit.libreoffice.org/65396
Reviewed-by: Aleksei Nikiforov 
Reviewed-by: Katarina Behrens 
(cherry picked from commit 77c5d0f4be46071f49957e3e2f7fce24f9e927f3)
Reviewed-on: https://gerrit.libreoffice.org/66462
Tested-by: Thorsten Behrens 

diff --git a/vcl/qt5/Qt5FilePicker.cxx b/vcl/qt5/Qt5FilePicker.cxx
index 9b795e5c7f2f..03fec892807e 100644
--- a/vcl/qt5/Qt5FilePicker.cxx
+++ b/vcl/qt5/Qt5FilePicker.cxx
@@ -186,7 +186,6 @@ sal_Int16 SAL_CALL Qt5FilePicker::execute()
 }
 
 vcl::Window* pWindow = ::Application::GetActiveTopWindow();
-assert(pWindow);
 QWidget* pTransientParent = nullptr;
 QWindow* pTransientWindow = nullptr;
 if (pWindow)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - vcl/qt5

2019-01-16 Thread Libreoffice Gerrit user
 vcl/qt5/Qt5AccessibleWidget.cxx |   17 -
 1 file changed, 16 insertions(+), 1 deletion(-)

New commits:
commit bbbd939a84b2a5e5a0b6e2d4ad929afe7f7f52e9
Author: Katarina Behrens 
AuthorDate: Tue Dec 18 18:31:08 2018 +0100
Commit: Thorsten Behrens 
CommitDate: Wed Jan 16 22:30:29 2019 +0100

tdf#122055: catch RuntimeException if a11y context no longer alive

otherwise Desktop::Main will do it and soffice will crash w/ empty
error msg

Change-Id: I56768909227a6ff158ae353e1eff9b249d6ba9d4
Reviewed-on: https://gerrit.libreoffice.org/65357
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
(cherry picked from commit d41bc9bd9359eb83f807fdfa72dbde0831f39be8)
Reviewed-on: https://gerrit.libreoffice.org/65384
(cherry picked from commit 20da54d941083a947d8890c2f6b0e8edf3bc9ed5)
Reviewed-on: https://gerrit.libreoffice.org/66460
Tested-by: Thorsten Behrens 

diff --git a/vcl/qt5/Qt5AccessibleWidget.cxx b/vcl/qt5/Qt5AccessibleWidget.cxx
index a31e13f49e3e..73bfdb7e21ab 100644
--- a/vcl/qt5/Qt5AccessibleWidget.cxx
+++ b/vcl/qt5/Qt5AccessibleWidget.cxx
@@ -633,7 +633,22 @@ void* 
Qt5AccessibleWidget::interface_cast(QAccessible::InterfaceType t)
 
 bool Qt5AccessibleWidget::isValid() const
 {
-return m_xAccessible.is() && m_xAccessible->getAccessibleContext().is();
+if (m_xAccessible.is())
+{
+try
+{
+// getAccessibleContext throws RuntimeException if context is no 
longer alive
+Reference xAc = 
m_xAccessible->getAccessibleContext();
+return xAc.is();
+}
+// so let's catch it here, cuz otherwise soffice falls flat on its face
+// with FatalError and nothing else
+catch (css::uno::RuntimeException /*ex*/)
+{
+return false;
+}
+}
+return false;
 }
 
 QObject* Qt5AccessibleWidget::object() const { return nullptr; }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - include/sal vcl/inc vcl/Library_vclplug_qt5.mk vcl/qt5

2019-01-16 Thread Libreoffice Gerrit user
 include/sal/log-areas.dox|1 
 vcl/Library_vclplug_qt5.mk   |1 
 vcl/inc/qt5/Qt5Object.hxx|8 +-
 vcl/inc/qt5/Qt5OpenGLContext.hxx |   50 
 vcl/qt5/Qt5Instance.cxx  |3 
 vcl/qt5/Qt5Object.cxx|5 +
 vcl/qt5/Qt5OpenGLContext.cxx |  151 +++
 7 files changed, 215 insertions(+), 4 deletions(-)

New commits:
commit c6d8cd0bb2c2955b3f6980fff19163559352f394
Author: Aleksei Nikiforov 
AuthorDate: Fri Dec 14 12:44:20 2018 +0300
Commit: Thorsten Behrens 
CommitDate: Wed Jan 16 22:30:48 2019 +0100

tdf#121247, tdf#121266 KDE5: Add basic support for OpenGL

Change-Id: Id3a5879f661a6fa51b9f9dc40af73687a8f624df
Reviewed-on: https://gerrit.libreoffice.org/65310
Reviewed-by: Katarina Behrens 
Tested-by: Jenkins
(cherry picked from commit 56b19f9a814ae5a39ed760ee542d715493cd0bf3)
Reviewed-on: https://gerrit.libreoffice.org/65393
Reviewed-by: Aleksei Nikiforov 
Reviewed-by: Thorsten Behrens 
(cherry picked from commit d51452fc4f15f956dde32cb2cc3e118473f4f23a)
Reviewed-on: https://gerrit.libreoffice.org/66461
Tested-by: Thorsten Behrens 

diff --git a/include/sal/log-areas.dox b/include/sal/log-areas.dox
index 88106232877b..8b9a597e9ae6 100644
--- a/include/sal/log-areas.dox
+++ b/include/sal/log-areas.dox
@@ -476,6 +476,7 @@ certain functionality.
 @li @c vcl.layout - Widget layout
 @li @c vcl.lazydelete
 @li @c vcl.opengl
+@li @c vcl.opengl.qt5 - QT5 OpenGL
 @li @c vcl.osx
 @li @c vcl.osx.print
 @li @c vcl.pdfwriter
diff --git a/vcl/Library_vclplug_qt5.mk b/vcl/Library_vclplug_qt5.mk
index cd3605720534..d51175756009 100644
--- a/vcl/Library_vclplug_qt5.mk
+++ b/vcl/Library_vclplug_qt5.mk
@@ -99,6 +99,7 @@ $(eval $(call gb_Library_add_exception_objects,vclplug_qt5,\
 vcl/qt5/Qt5MainWindow \
 vcl/qt5/Qt5Menu \
 vcl/qt5/Qt5Object \
+vcl/qt5/Qt5OpenGLContext \
 vcl/qt5/Qt5Painter \
 vcl/qt5/Qt5Printer \
 vcl/qt5/Qt5System \
diff --git a/vcl/inc/qt5/Qt5Object.hxx b/vcl/inc/qt5/Qt5Object.hxx
index 294f4da4d9db..640c83753deb 100644
--- a/vcl/inc/qt5/Qt5Object.hxx
+++ b/vcl/inc/qt5/Qt5Object.hxx
@@ -24,14 +24,18 @@
 
 #include 
 
-class QWidget;
 class Qt5Frame;
+class QWidget;
+class QWindow;
 
 class Qt5Object : public SalObject
 {
+friend class Qt5OpenGLContext;
+
 SystemEnvData m_aSystemData;
 Qt5Frame* m_pParent;
-QWidget* m_pQWidget;
+QWidget* m_pQWidget; // main widget, container
+QWindow* m_pQWindow; // contained window, used for opengl rendering
 QRegion m_pRegion;
 
 public:
diff --git a/vcl/inc/qt5/Qt5OpenGLContext.hxx b/vcl/inc/qt5/Qt5OpenGLContext.hxx
new file mode 100644
index ..778df689ba65
--- /dev/null
+++ b/vcl/inc/qt5/Qt5OpenGLContext.hxx
@@ -0,0 +1,50 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ *   Licensed to the Apache Software Foundation (ASF) under one or more
+ *   contributor license agreements. See the NOTICE file distributed
+ *   with this work for additional information regarding copyright
+ *   ownership. The ASF licenses this file to you under the Apache
+ *   License, Version 2.0 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#pragma once
+
+#include 
+
+class QWindow;
+class QOpenGLContext;
+
+class Qt5OpenGLContext : public OpenGLContext
+{
+public:
+virtual void initWindow() override;
+
+private:
+virtual const GLWindow& getOpenGLWindow() const override { return 
m_aGLWin; }
+virtual GLWindow& getModifiableOpenGLWindow() override { return m_aGLWin; }
+virtual bool ImplInit() override;
+
+virtual void makeCurrent() override;
+virtual void destroyCurrentContext() override;
+virtual bool isCurrent() override;
+virtual bool isAnyCurrent() override;
+virtual void resetCurrent() override;
+virtual void swapBuffers() override;
+
+static bool g_bAnyCurrent;
+
+GLWindow m_aGLWin;
+
+QWindow* m_pWindow;
+QOpenGLContext* m_pContext;
+};
diff --git a/vcl/qt5/Qt5Instance.cxx b/vcl/qt5/Qt5Instance.cxx
index bc34f1bec545..9142d8d371a9 100644
--- a/vcl/qt5/Qt5Instance.cxx
+++ b/vcl/qt5/Qt5Instance.cxx
@@ -30,6 +30,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -204,7 +205,7 @@ OUString Qt5Instance::GetConnectionIdentifier() { return 
OUString(); }
 
 void Qt5Instance::AddToRecentDocumentList(const OUString&, const OUString&, 
const OUString&) {}
 
-OpenGLContext* 

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - vcl/inc vcl/qt5

2019-01-16 Thread Libreoffice Gerrit user
 vcl/inc/qt5/Qt5Frame.hxx  |1 +
 vcl/inc/qt5/Qt5Object.hxx |4 +---
 vcl/qt5/Qt5Frame.cxx  |   11 +--
 vcl/qt5/Qt5Object.cxx |   18 ++
 4 files changed, 25 insertions(+), 9 deletions(-)

New commits:
commit bda114560fa363b77a0500601f5f3a797e728e74
Author: Aleksei Nikiforov 
AuthorDate: Fri Dec 14 12:39:44 2018 +0300
Commit: Thorsten Behrens 
CommitDate: Wed Jan 16 22:30:01 2019 +0100

Qt5: Fix fullscreen window size

Allow setting Qt5Object's position and size

Change-Id: I9f70b68ff402a3975e36baca4d81103603110d82
Reviewed-on: https://gerrit.libreoffice.org/65309
Reviewed-by: Jan-Marek Glogowski 
Tested-by: Jenkins
(cherry picked from commit 4aa66236d69c63b648a966de2e2d7a3f12eed8de)
Reviewed-on: https://gerrit.libreoffice.org/65368
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 
(cherry picked from commit 0cd4c92b56fb6259f8f3188fd50c315993883d2e)
Reviewed-on: https://gerrit.libreoffice.org/66459

diff --git a/vcl/inc/qt5/Qt5Frame.hxx b/vcl/inc/qt5/Qt5Frame.hxx
index 34cbc0b33001..3d29f4443b0b 100644
--- a/vcl/inc/qt5/Qt5Frame.hxx
+++ b/vcl/inc/qt5/Qt5Frame.hxx
@@ -79,6 +79,7 @@ class VCLPLUG_QT5_PUBLIC Qt5Frame : public QObject, public 
SalFrame
 
 bool m_bDefaultSize;
 bool m_bDefaultPos;
+bool m_bFullScreen;
 
 void Center();
 Size CalcDefaultSize();
diff --git a/vcl/inc/qt5/Qt5Object.hxx b/vcl/inc/qt5/Qt5Object.hxx
index 99fef78a681b..294f4da4d9db 100644
--- a/vcl/inc/qt5/Qt5Object.hxx
+++ b/vcl/inc/qt5/Qt5Object.hxx
@@ -22,8 +22,6 @@
 #include 
 #include 
 
-#include 
-
 #include 
 
 class QWidget;
@@ -32,8 +30,8 @@ class Qt5Frame;
 class Qt5Object : public SalObject
 {
 SystemEnvData m_aSystemData;
-std::unique_ptr m_pQWidget;
 Qt5Frame* m_pParent;
+QWidget* m_pQWidget;
 QRegion m_pRegion;
 
 public:
diff --git a/vcl/qt5/Qt5Frame.cxx b/vcl/qt5/Qt5Frame.cxx
index 9a70b9a6e391..8b2431770067 100644
--- a/vcl/qt5/Qt5Frame.cxx
+++ b/vcl/qt5/Qt5Frame.cxx
@@ -70,6 +70,7 @@ Qt5Frame::Qt5Frame(Qt5Frame* pParent, SalFrameStyleFlags 
nStyle, bool bUseCairo)
 , m_bInDrag(false)
 , m_bDefaultSize(true)
 , m_bDefaultPos(true)
+, m_bFullScreen(false)
 {
 Qt5Instance* pInst = static_cast(GetSalData()->m_pInstance);
 pInst->insertFrame(this);
@@ -380,7 +381,11 @@ Size Qt5Frame::CalcDefaultSize()
 else
 qSize = QApplication::desktop()->screenGeometry(0).size();
 
-return bestmaxFrameSizeForScreenSize(toSize(qSize));
+Size aSize = toSize(qSize);
+if (!m_bFullScreen)
+aSize = bestmaxFrameSizeForScreenSize(aSize);
+
+return aSize;
 }
 
 void Qt5Frame::SetDefaultSize()
@@ -560,13 +565,15 @@ void Qt5Frame::ShowFullScreen(bool bFullScreen, sal_Int32 
nScreen)
 // only top-level windows can go fullscreen
 assert(m_pTopLevel);
 
+m_bFullScreen = bFullScreen;
+
 // show it if it isn't shown yet
 if (!isWindow())
 m_pTopLevel->show();
 
 // do that before going fullscreen
 SetScreenNumber(nScreen);
-bFullScreen ? windowHandle()->showFullScreen() : 
windowHandle()->showNormal();
+m_bFullScreen ? windowHandle()->showFullScreen() : 
windowHandle()->showNormal();
 }
 
 void Qt5Frame::StartPresentation(bool)
diff --git a/vcl/qt5/Qt5Object.cxx b/vcl/qt5/Qt5Object.cxx
index 3b68c0746d30..4f0a92da7bf7 100644
--- a/vcl/qt5/Qt5Object.cxx
+++ b/vcl/qt5/Qt5Object.cxx
@@ -25,10 +25,13 @@
 
 Qt5Object::Qt5Object(Qt5Frame* pParent, bool bShow)
 : m_pParent(pParent)
+, m_pQWidget(nullptr)
 {
 if (!m_pParent || !pParent->GetQWidget())
 return;
-m_pQWidget.reset(new QWidget(pParent->GetQWidget()));
+
+m_pQWidget = new QWidget(pParent->GetQWidget());
+
 if (bShow)
 m_pQWidget->show();
 
@@ -43,7 +46,7 @@ Qt5Object::Qt5Object(Qt5Frame* pParent, bool bShow)
 
 void Qt5Object::ResetClipRegion()
 {
-if (m_pQWidget.get())
+if (m_pQWidget)
 m_pRegion = QRegion(m_pQWidget->geometry());
 else
 m_pRegion = QRegion();
@@ -58,11 +61,18 @@ void Qt5Object::UnionClipRegion(long nX, long nY, long 
nWidth, long nHeight)
 
 void Qt5Object::EndSetClipRegion()
 {
-if (m_pQWidget.get())
+if (m_pQWidget)
 m_pRegion = m_pRegion.intersected(m_pQWidget->geometry());
 }
 
-void Qt5Object::SetPosSize(long /*nX*/, long /*nY*/, long /*nWidth*/, long 
/*nHeight*/) {}
+void Qt5Object::SetPosSize(long nX, long nY, long nWidth, long nHeight)
+{
+if (m_pQWidget)
+{
+m_pQWidget->move(nX, nY);
+m_pQWidget->setFixedSize(nWidth, nHeight);
+}
+}
 
 void Qt5Object::Show(bool bVisible)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: Bug around legend of a pie chart

2019-01-16 Thread Luke Benes
There are many legend/title overlapping import issues on the bug tracker. The 
only universal solution will be to teach the chart engine the concept of not 
allowing overlapping legend/title and allow the importers to use this.

Awhile back Markus made some progress in this area. The basic work has already 
been done, but it has to be flushed out and extended with UNO API etc.

See:
https://bugs.documentfoundation.org/show_bug.cgi?id=90730

and
https://bugs.documentfoundation.org/show_bug.cgi?id=75330





___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - download.lst external/poppler sdext/source

2019-01-16 Thread Libreoffice Gerrit user
 download.lst  |4 +-
 external/poppler/StaticLibrary_poppler.mk |6 ---
 external/poppler/UnpackedTarball_poppler.mk   |   11 ++
 external/poppler/poppler-c++11.patch.1|   31 ++
 external/poppler/poppler-config.patch.1   |   12 +++---
 sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx |1 
 6 files changed, 52 insertions(+), 13 deletions(-)

New commits:
commit 33cbf95d65c876838507a7084ef0f65e00f93928
Author: Michael Stahl 
AuthorDate: Mon Jan 14 15:12:24 2019 +0100
Commit: Caolán McNamara 
CommitDate: Wed Jan 16 22:17:05 2019 +0100

poppler: upgrade to release 0.73.0

Reviewed-on: https://gerrit.libreoffice.org/66306
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 0609ea4fc27f34367716bf41c0cdaa7785aed9da)

Change-Id: If20998f8565b5534a96b3f29ccec572273edca1d
Reviewed-on: https://gerrit.libreoffice.org/66368
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/download.lst b/download.lst
index ad64655c75d9..eb404f665ed6 100644
--- a/download.lst
+++ b/download.lst
@@ -206,8 +206,8 @@ export PIXMAN_SHA256SUM := 
21b6b249b51c6800dc9553b65106e1e37d0e25df942c90531d4c3
 export PIXMAN_TARBALL := e80ebae4da01e77f68744319f01d52a3-pixman-0.34.0.tar.gz
 export LIBPNG_SHA256SUM := 
2f1e960d92ce3b3abd03d06dfec9637dfbd22febf107a536b44f7a47c60659f6
 export LIBPNG_TARBALL := libpng-1.6.34.tar.xz
-export POPPLER_SHA256SUM := 
2c096431adfb74bc2f53be466889b7646e1b599f28fa036094f3f7235cc9eae7
-export POPPLER_TARBALL := poppler-0.66.0.tar.xz
+export POPPLER_SHA256SUM := 
e44b5543903128884ba4538c2a97d3bcc8889e97ffacc4636112101f0238db03
+export POPPLER_TARBALL := poppler-0.73.0.tar.xz
 export POSTGRESQL_SHA256SUM := 
a754c02f7051c2f21e52f8669a421b50485afcde9a581674d6106326b189d126
 export POSTGRESQL_TARBALL := postgresql-9.2.24.tar.bz2
 export PYTHON_SHA256SUM := 
063d2c3b0402d6191b90731e0f735c64830e7522348aeb7ed382a83165d45009
diff --git a/external/poppler/StaticLibrary_poppler.mk 
b/external/poppler/StaticLibrary_poppler.mk
index f145b7ae9c39..aa5ed693eb22 100644
--- a/external/poppler/StaticLibrary_poppler.mk
+++ b/external/poppler/StaticLibrary_poppler.mk
@@ -53,11 +53,8 @@ $(eval $(call 
gb_StaticLibrary_set_generated_cxx_suffix,poppler,cc))
 
 $(eval $(call gb_StaticLibrary_add_generated_exception_objects,poppler,\
UnpackedTarball/poppler/goo/gfile \
-   UnpackedTarball/poppler/goo/gmempp \
-   UnpackedTarball/poppler/goo/GooList \
UnpackedTarball/poppler/goo/GooTimer \
UnpackedTarball/poppler/goo/GooString \
-   UnpackedTarball/poppler/goo/gmem \
UnpackedTarball/poppler/goo/FixedPoint \
UnpackedTarball/poppler/goo/NetPBMWriter \
UnpackedTarball/poppler/goo/PNGWriter \
@@ -80,6 +77,7 @@ $(eval $(call 
gb_StaticLibrary_add_generated_exception_objects,poppler,\
UnpackedTarball/poppler/poppler/BuiltinFontTables \
UnpackedTarball/poppler/poppler/CachedFile \
UnpackedTarball/poppler/poppler/Catalog \
+   UnpackedTarball/poppler/poppler/CertificateInfo \
UnpackedTarball/poppler/poppler/CharCodeToUnicode \
UnpackedTarball/poppler/poppler/CMap \
UnpackedTarball/poppler/poppler/DateInfo \
@@ -114,7 +112,6 @@ $(eval $(call 
gb_StaticLibrary_add_generated_exception_objects,poppler,\
UnpackedTarball/poppler/poppler/PDFDoc \
UnpackedTarball/poppler/poppler/PDFDocEncoding \
UnpackedTarball/poppler/poppler/PDFDocFactory \
-   UnpackedTarball/poppler/poppler/PopplerCache \
UnpackedTarball/poppler/poppler/ProfileData \
UnpackedTarball/poppler/poppler/PreScanOutputDev \
UnpackedTarball/poppler/poppler/PSTokenizer \
@@ -135,7 +132,6 @@ $(eval $(call 
gb_StaticLibrary_add_generated_exception_objects,poppler,\
UnpackedTarball/poppler/poppler/StdinPDFDocBuilder \
UnpackedTarball/poppler/poppler/Sound \
UnpackedTarball/poppler/poppler/ViewerPreferences \
-   UnpackedTarball/poppler/poppler/XpdfPluginAPI \
UnpackedTarball/poppler/poppler/Movie \
UnpackedTarball/poppler/poppler/Rendition \
UnpackedTarball/poppler/poppler/DCTStream \
diff --git a/external/poppler/UnpackedTarball_poppler.mk 
b/external/poppler/UnpackedTarball_poppler.mk
index 68fd06d9403b..5b91e1628ba6 100644
--- a/external/poppler/UnpackedTarball_poppler.mk
+++ b/external/poppler/UnpackedTarball_poppler.mk
@@ -13,6 +13,17 @@ $(eval $(call 
gb_UnpackedTarball_set_tarball,poppler,$(POPPLER_TARBALL),,poppler
 
 $(eval $(call gb_UnpackedTarball_add_patches,poppler,\
external/poppler/poppler-config.patch.1 \
+   external/poppler/poppler-c++11.patch.1 \
 ))
 
+# std::make_unique is only available in C++14
+# use "env -i" to avoid Cygwin "environment is too large for exec"
+# Mac OS X sed says "sed: RE error: illegal byte 

[Libreoffice-commits] core.git: sal/osl

2019-01-16 Thread Libreoffice Gerrit user
 sal/osl/unx/socket.cxx |   39 ++-
 1 file changed, 10 insertions(+), 29 deletions(-)

New commits:
commit a89f127d146c6e39113ccba9e7e114bd88145cca
Author: Stephan Bergmann 
AuthorDate: Wed Jan 16 16:43:26 2019 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Jan 16 22:11:48 2019 +0100

Avoid unnecessary string copying in osl_getDottedInetAddrOfSocketAddr

Change-Id: I57aea80f0489c4176990d7233a4c218e5199a993
Reviewed-on: https://gerrit.libreoffice.org/66467
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sal/osl/unx/socket.cxx b/sal/osl/unx/socket.cxx
index 454ff463d70f..a77b3f364bf0 100644
--- a/sal/osl/unx/socket.cxx
+++ b/sal/osl/unx/socket.cxx
@@ -278,9 +278,6 @@ static oslSocketAddr osl_psz_resolveHostname (
 static sal_Int32 osl_psz_getServicePort (
 const sal_Char* pszServicename, const sal_Char* pszProtocol);
 
-static oslSocketResult osl_psz_getDottedInetAddrOfSocketAddr (
-oslSocketAddr Addr, sal_Char *pBuffer, sal_uInt32 BufferSize);
-
 static void osl_psz_getLastSocketErrorDescription (
 oslSocket Socket, sal_Char* pBuffer, sal_uInt32 BufferSize);
 
@@ -1110,38 +1107,22 @@ oslSocketResult SAL_CALL 
osl_getHostnameOfSocketAddr(oslSocketAddr Addr, rtl_uSt
 
 oslSocketResult SAL_CALL osl_getDottedInetAddrOfSocketAddr(oslSocketAddr Addr, 
rtl_uString **ustrDottedInetAddr)
 {
-oslSocketResult Result;
-sal_Char pszDottedInetAddr[1024];
-
-pszDottedInetAddr[0] = '\0';
-
-Result = 
osl_psz_getDottedInetAddrOfSocketAddr(Addr,pszDottedInetAddr,sizeof(pszDottedInetAddr));
-
-rtl_uString_newFromAscii(ustrDottedInetAddr,pszDottedInetAddr);
-
-return Result;
+if( !Addr )
+{
+return osl_Socket_Error;
+}
 
-}
+struct sockaddr_in* pSystemInetAddr = reinterpret_cast(>m_sockaddr);
 
-oslSocketResult osl_psz_getDottedInetAddrOfSocketAddr(oslSocketAddr pAddr,
-  sal_Char *pBuffer, 
sal_uInt32 BufferSize)
-{
-SAL_WARN_IF( !pAddr, "sal.osl", "undefined address" );
-
-if( pAddr )
+if (pSystemInetAddr->sin_family != FAMILY_TO_NATIVE(osl_Socket_FamilyInet))
 {
-struct sockaddr_in* pSystemInetAddr = reinterpret_cast(>m_sockaddr);
+return osl_Socket_Error;
+}
 
-if (pSystemInetAddr->sin_family == 
FAMILY_TO_NATIVE(osl_Socket_FamilyInet))
-{
-strncpy(pBuffer, inet_ntoa(pSystemInetAddr->sin_addr), BufferSize);
-pBuffer[BufferSize - 1] = '\0';
+
rtl_uString_newFromAscii(ustrDottedInetAddr,inet_ntoa(pSystemInetAddr->sin_addr));
 
-return osl_Socket_Ok;
-}
-}
+return osl_Socket_Ok;
 
-return osl_Socket_Error;
 }
 
 oslSocket SAL_CALL osl_createSocket(
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 114774] LibreCalc becomes unresponsive when changing the font

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114774

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 75330] EDITING: "Show the legend without overlapping the chart"

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=75330

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||2765

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'aoo/trunk' - cui/source

2019-01-16 Thread Libreoffice Gerrit user
 cui/source/options/treeopt.src |  251 -
 1 file changed, 126 insertions(+), 125 deletions(-)

New commits:
commit 49d68b8ac2685703957b8541a9b5b81ee1c93452
Author: Matthias Seidel 
AuthorDate: Wed Jan 16 20:25:35 2019 +
Commit: Matthias Seidel 
CommitDate: Wed Jan 16 20:25:35 2019 +

Cleaned up resource file

Removed entry for MASKCOLOR

diff --git a/cui/source/options/treeopt.src b/cui/source/options/treeopt.src
index d43b4c970ad0..1fe188fe1bfa 100644
--- a/cui/source/options/treeopt.src
+++ b/cui/source/options/treeopt.src
@@ -30,91 +30,92 @@
 
 ModalDialog RID_OFADLG_OPTIONS_TREE
 {
-HelpID = HID_OFADLG_OPTIONS_TREE;
+HelpID = HID_OFADLG_OPTIONS_TREE ;
 Moveable = TRUE ;
 OutputSize = TRUE ;
 SVLook = TRUE ;
 
-Size = MAP_APPFONT ( COL_12 , ROW_5 ) ;
-Text [ en-US ] = "Options";
+Size = MAP_APPFONT ( COL_12, ROW_5 ) ;
+Text [ en-US ] = "Options" ;
 
 OKButton PB_OK
 {
 Pos = MAP_APPFONT ( COL_4, ROW_3 ) ;
-Size = MAP_APPFONT ( RSC_CD_PUSHBUTTON_WIDTH , 
RSC_CD_PUSHBUTTON_HEIGHT ) ;
+Size = MAP_APPFONT ( RSC_CD_PUSHBUTTON_WIDTH, RSC_CD_PUSHBUTTON_HEIGHT 
) ;
 TabStop = TRUE ;
-DefButton = TRUE;
+DefButton = TRUE ;
 };
 CancelButton PB_CANCEL
 {
 Pos = MAP_APPFONT ( COL_6, ROW_3 ) ;
-Size = MAP_APPFONT ( RSC_CD_PUSHBUTTON_WIDTH , 
RSC_CD_PUSHBUTTON_HEIGHT ) ;
+Size = MAP_APPFONT ( RSC_CD_PUSHBUTTON_WIDTH, RSC_CD_PUSHBUTTON_HEIGHT 
) ;
 TabStop = TRUE ;
 };
 HelpButton PB_HELP
 {
 Pos = MAP_APPFONT ( COL_8, ROW_3 ) ;
-Size = MAP_APPFONT ( RSC_CD_PUSHBUTTON_WIDTH , 
RSC_CD_PUSHBUTTON_HEIGHT ) ;
+Size = MAP_APPFONT ( RSC_CD_PUSHBUTTON_WIDTH, RSC_CD_PUSHBUTTON_HEIGHT 
) ;
 TabStop = TRUE ;
 };
 PushButton PB_BACK
 {
-HelpID = "cui:PushButton:RID_OFADLG_OPTIONS_TREE:PB_BACK";
+HelpID = "cui:PushButton:RID_OFADLG_OPTIONS_TREE:PB_BACK" ;
 Pos = MAP_APPFONT ( COL_10, ROW_3 ) ;
-Size = MAP_APPFONT ( RSC_CD_PUSHBUTTON_WIDTH , 
RSC_CD_PUSHBUTTON_HEIGHT ) ;
+Size = MAP_APPFONT ( RSC_CD_PUSHBUTTON_WIDTH, RSC_CD_PUSHBUTTON_HEIGHT 
) ;
 TabStop = TRUE ;
 Text [ en-US ] = "~Back" ;
 };
-//TreeListBox
+
+// TreeListBox
 Control TLB_PAGES
 {
 Pos = MAP_APPFONT ( COL_1, ROW_1 ) ;
-Size = MAP_APPFONT ( (COL_2-COL_1), (ROW_4-ROW_1) );
+Size = MAP_APPFONT ( (COL_2-COL_1), (ROW_4-ROW_1) ) ;
 TabStop = TRUE ;
-Border = TRUE;
+Border = TRUE ;
 };
 Control FB_BORDER
 {
 Pos = MAP_APPFONT ( COL_3, ROW_1 ) ;
 Size = MAP_APPFONT ( WIDTH_PAGEFRAME, HEIGHT_PAGEFRAME ) ;
-Hide = TRUE;
+Hide = TRUE ;
 };
 FixedImage IMG_HELP
 {
 Pos = MAP_APPFONT ( COL_3_1, ROW_1_1 ) ;
 Size = MAP_APPFONT ( WIDTH_IMG_HELP, HEIGHT_IMG_HELP ) ;
-Hide = TRUE;
+Hide = TRUE ;
 };
 FixedText FT_PAGE_TITLE
 {
 Pos = MAP_APPFONT ( COL_3_3, ROW_1_2 ) ;
 Size = MAP_APPFONT ( (COL_3_5-COL_3_3), 15 ) ;
-Hide = TRUE;
+Hide = TRUE ;
 };
 FixedLine FL_LINE_1
 {
-Pos = MAP_APPFONT ( COL_3_1 , ROW_1_3 ) ;
+Pos = MAP_APPFONT ( COL_3_1, ROW_1_3 ) ;
 Size = MAP_APPFONT ( (COL_3_5-COL_3_1), 1 ) ;
-Comment = "Trennlinie" ;
-Hide = TRUE;
+Comment = "Divider" ;
+Hide = TRUE ;
 };
 FixedText FT_HELPTEXT
 {
 Pos = MAP_APPFONT ( COL_3_3, ROW_1_4 ) ;
 Size = MAP_APPFONT ( (COL_3_5-COL_3_3), (HEIGHT_PAGEFRAME-ROW_1_4-1) ) 
;
-WordBreak = TRUE;
-Hide = TRUE;
+WordBreak = TRUE ;
+Hide = TRUE ;
 };
 String ST_LOAD_ERROR
 {
-Text [ en-US ] = "The selected module could not be loaded.";
+Text [ en-US ] = "The selected module could not be loaded." ;
 };
 StringArray STR_HELPTEXTS
 {
 ItemList [ en-US ] =
 {
-< "This dialog is used to define general settings when working 
with %PRODUCTNAME. Enter your personal data, the defaults to be used when 
saving documents, and paths to important files. These settings will be saved 
automatically and used in later sessions as well."; SID_GENERAL_OPTIONS; > ;
-< "This is where you make settings concerning language and writing 
aids for your work with %PRODUCTNAME."; SID_LANGUAGE_OPTIONS; > ;
+< "This dialog is used to define general settings when working 
with %PRODUCTNAME. Enter your personal data, the defaults to be used when 
saving documents, and paths to important files. These settings will be saved 
automatically and used in later sessions as well." ; SID_GENERAL_OPTIONS; > ;
+< "This is where you make settings concerning language and writing 
aids for your work with %PRODUCTNAME." ; SID_LANGUAGE_OPTIONS; > ;
   

[Libreoffice-commits] core.git: Branch 'libreoffice-6-1-5' - configure.ac

2019-01-16 Thread Libreoffice Gerrit user
 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 50838df509c3dff9b509f02fa9d706c6b9dacd72
Author: Christian Lohmaier 
AuthorDate: Wed Jan 16 21:49:07 2019 +0100
Commit: Christian Lohmaier 
CommitDate: Wed Jan 16 21:49:07 2019 +0100

bump product version to 6.1.5.1.0+

Change-Id: I2cc04817aaa6c00446e01d8836da8c3407103dfa

diff --git a/configure.ac b/configure.ac
index 4c213dc3fd47..fefd8d348ff5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[6.1.5.0.0+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[6.1.5.1.0+],[],[],[http://documentfoundation.org/])
 
 AC_PREREQ([2.59])
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-6.1.5.1'

2019-01-16 Thread Libreoffice Gerrit user
Tag 'libreoffice-6.1.5.1' created by Christian Lohmaier 
 at 2019-01-16 20:48 +

Tag libreoffice-6.1.5.1
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAlw/mJ8ACgkQ9DSh76/u
rqPetA/8C7dIh5/i5HfOc9l6NmjsYniQdkZGXmw+e4+zwTL1RH0iU5GO7WfuedGQ
ijZfO+8+GRiVGpHjXDh3d5z0zPLoWTv1uNPxIm4PkL4uBnwIfNPqMmAWHh3Vmoke
79km1XNf+ialv8jo9cGIVudwaokLQXqoZLM439H09i0m/d81DUrqYTiO5VdKO49g
Tp0MobmNB+Ytn3K+WneFzwdsp0DQ0tk5dAezTQS28774Yl2FYBBUR9hjzfoUMrfU
h2AU+KVe+AwdVXViXQMu8zsNXjs2TLntx9VZEqmgfjFnMmw2ukmFnZtsB5v2BeVW
XcsIkDk1VxfGQR7wg+uufYhcsMb15gJwV6opIdvjUGCi/OGTO7R8Peb6sBYgw7b6
6gJb+Ba9pLIWNj0FXi0Dz60QB5MLmEF4WM6G2F3UqxNWD3zhPSkP+FmN9NBE80Ti
69vkVGgatru7nduH4Rhi2fKKrlPtauj53fKeyO8yu5e5qiHtt8iDDmXa1xMnI6cr
FZyDMYGeMP00oSMWRMOLbqn1qCd3EoHIIfTMZO4GZ2FU6YtpAglrmQr8v2lJ54IT
lODf4h45D9CKgZop7SvgFQtnu04GApqg99YC5HO6qkI59sgUnNXJ7ZUBNwws1Azp
3WRUjDI1EAML2wLVsCDueMXJxNYjGaIu1UjJ9bJpDT75MWeeDnw=
=KITM
-END PGP SIGNATURE-

Changes since libreoffice-6-1-branch-point-70:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-6.1.5.1'

2019-01-16 Thread Libreoffice Gerrit user
Tag 'libreoffice-6.1.5.1' created by Christian Lohmaier 
 at 2019-01-16 20:48 +

Tag libreoffice-6.1.5.1
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAlw/mJ8ACgkQ9DSh76/u
rqOhsg//d2NaN6X++i+1bKRbAmzsvWkUbH4vgxykMilJ0x4vu6JafMsV4tVew2qH
6kxQ4HW23phIiIZ3CVRF3O9k3OeAPp+dezIaIW5hybmHWHqngdeDXCEfd5+mAdZd
RsOEmrrHbKeRgN+c30kpnfzQ1Doa3+X3a95RyeQsntrOT1coP1Kr+pMOGbxBNL2C
smID2K09uD7dp0c4rn59TriwgV5Mcq3CugehHWjQPWgiB3uWCeNvX2SOmq2GNLOg
uwX/W4HkKKs1OfEzz0CyVJlzkrgwK53jBRa3VyU9i9FYe3slca8IwEdj/0K2V1TA
wTrw9BvWQtoclctZ1m8gBa3L7KJTv3kyp4pls+nDa2JX81CLtsMynV0NN6ROfxID
EYxrX+i0wHV6E6Quk5EGLW88+f5NQAhHciStGjMv3mg5UdlCNW0pJY/AetULtm1y
YIhLhg93Anx9vvREs2ZQVrp2rxujche6rPeV3De0Wa2bO/xbY7+1hdVlJYNDvNmf
eHcsM2GdyMqxdAX0CM2UvalqflrFhSEZPZqJujl7EKFPPnTSKxy53uoFhLhF7FQA
HOA9VukEmF5OZGtawQd6aTR51qz+U494GY6JJYmGlR+7glvUtxyW4jQuQvjcUetC
mnZj60XETri4/fd7puOwo7Wuo/tKwKbVHglt34oQWTY9GMWVp5Y=
=7QtO
-END PGP SIGNATURE-

Changes since libreoffice-6-1-branch-point-28:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-6.1.5.1'

2019-01-16 Thread Libreoffice Gerrit user
Tag 'libreoffice-6.1.5.1' created by Christian Lohmaier 
 at 2019-01-16 20:48 +

Tag libreoffice-6.1.5.1
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAlw/mJ8ACgkQ9DSh76/u
rqOpKRAAnvDa996Kaq34S1iRtyIeeFR/FSuUJsnZZsltVcG3LZswJZg20ek6D4Tg
EOj4Hs36ziEryxpJ9j3FSKFVwkZQb6Vya1IYcMKqy5+iBOoXvRKVKqRtSguJAuox
8h/vBgF/A4HBmCDt6234b216SaNlMY9hOi5QO+Fr7ZuqONAPDUKOZIfK/eugCTay
e89fqRf/XbVRs24sQDtYZ5qaqehNBr11N7hKm+7bbK/88ejdaIn3c7efZIIGEWfF
4cf7wZ6dHopl8R04tKt7LsLWJDXdROu0grJ8C5Sg8GHSYAr0wAap3wumceb76N47
VqKRHs2b9yBYoq101lDauNMOsUouw1AzR4MSC63IL5IvQ1EuC6eyOr7cPXHx20lm
JR0tsxWpH7koYyCqpUihC7X7B8EjMajMtXN1YTNZGe6HdUGqP5FWK+2pdXYDZ0fc
+SODaF2VbW4u402pio0oT3/rTT3lQt9AjGbOy4BNZMmD3QC06dPHqdCcudSq0KC6
Nc29n4y0/Iu6tLs1m/rv849G1uhv+9Z88H+z3iN5I+H0sfbi5WZ0LN3hYCS2cMBF
B64SsEzP7CmALgeG+SbUZHWw9KY0UwBitjEC8q+jQY/e+ed+uoSNQ0U/fWFvdFYE
p0rY9NjtzAsIBJj2UccctrHw4fdTNrU9xMGVc2biJqsY34Y3lrw=
=4eP3
-END PGP SIGNATURE-

Changes since libreoffice-6-1-branch-point-1414:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-6.1.5.1'

2019-01-16 Thread Libreoffice Gerrit user
Tag 'libreoffice-6.1.5.1' created by Christian Lohmaier 
 at 2019-01-16 20:48 +

Tag libreoffice-6.1.5.1
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAlw/mJsACgkQ9DSh76/u
rqN44w//eTpaAr+Rn6VVR1bnlACOSvUI2/cCg9tfmYcthecl8xKXqV3NjiiFh70J
o3EXBz0mT9xXru58RHoOwIdQOqwi9p3cqeRGi1dJbQPGZZ2sNK/vJuWPJIbPxZg9
BlgbKoSTaOWwyW+AreoiEY349CJNVJqsJgxGf7n2ozpojqZVKu6zbYU2i96fjiqR
Gbk79QPemvh7TMxsU/P21BCqPzdcyUbh2uCl0h6+hmB2PNzKkKrH8q5dtV9Ezm6H
jmEq6SORDA+V36ob6ARc/FsAoYtHUxtp5So/bubafF5VYr5VQes0AXtbuP+PxtuC
27S5FrJ+A0ZCjuLokhtkda/6pTuG9FFE7dt+yTRsf7rV8Zzrrr7Y3ehluyglaxdg
rjH1Cjm2x73n0unx1NlYEx2duxTJSiSW504sX0+bzJG++7k65KYSkHY3qJo0FF90
GQBxCu+aH9kiukWgce/nIeiq8ovnINSeYBotXkyDdx8+301ycpIbwR5a5tXcN+1h
gQwUNTSBkcmsmD9EcXrGJgOHQMxW3neFznINoEoablrefUFSF/ZK/3sRkcnhooy5
SVEJ9nP+lCpDx2WaeDJ7LK5/t08cW6PWGlkGm/dOh9jcICPh+NGA+FRBQYiDVZ9o
FoZAmTNOULP89yhq1FF+Ck6h5DLdDTN1XUC9O6HQ0iZPqURoReI=
=GTIw
-END PGP SIGNATURE-

Changes since libreoffice-6-1-branch-point-12:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 122566] Depending on document same style's font sizes units may be displayed in point or percent.

2019-01-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122566

ricky.t...@gmail.com changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #4 from ricky.t...@gmail.com ---
Involved documents were edited in Libreoffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - configure.ac

2019-01-16 Thread Libreoffice Gerrit user
 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a3962d99ba6467f6043c431230e9a1df4bfc0e4b
Author: Christian Lohmaier 
AuthorDate: Wed Jan 16 21:45:54 2019 +0100
Commit: Christian Lohmaier 
CommitDate: Wed Jan 16 21:45:54 2019 +0100

bump product version to 6.1.6.0.0+

Change-Id: I7428b3f6cf16cb32813420b7fb39c1e41c13761e

diff --git a/configure.ac b/configure.ac
index 4c213dc3fd47..4c55cd4933c0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[6.1.5.0.0+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[6.1.6.0.0+],[],[],[http://documentfoundation.org/])
 
 AC_PREREQ([2.59])
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Changes to 'libreoffice-6-1-5'

2019-01-16 Thread Libreoffice Gerrit user
New branch 'libreoffice-6-1-5' available with the following commits:
commit 5acfba7450fdde352f970b6dd7d5aa53cbe7208f
Author: Christian Lohmaier 
Date:   Wed Jan 16 21:44:16 2019 +0100

Branch libreoffice-6-1-5

This is 'libreoffice-6-1-5' - the stable branch for the 6.1.5 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 6.1.x release,
please use the 'libreoffice-6-1' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: I39c0686cc938a64f050c9bc366fe8e8a4841f36b

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


  1   2   3   4   5   6   >