[Libreoffice-bugs] [Bug 121674] Cannot access previously created Input List from the Fields dialog

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121674

Bich 30  changed:

   What|Removed |Added

 Resolution|NOTABUG |FIXED

--- Comment #25 from Bich 30  ---
Very thanks, I test.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122752] gtk3_kde5/kde5: save file dialog doesn't add file extension and misses custom controls when using LXQt

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122752

Michael Weghorn  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |m.wegh...@posteo.de
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[SOLVED/WORKAROUNDED] Re: fatal error LNK1561 on nss (Visual Studio 2017)

2019-01-29 Thread julien2412
Patch pushed, see
https://cgit.freedesktop.org/libreoffice/core/commit/?id=930ec0e6ab7bd5492fb4cf4a8f6860e3b728929d



--
Sent from: 
http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103030

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||91018


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=91018
[Bug 91018] UI:  Navigator icons temporarily retain previous theme when
switching themes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 91018] UI: Navigator icons temporarily retain previous theme when switching themes

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91018

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||103030

--- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> ---
(In reply to Buovjaga from comment #2)
> (In reply to Beluga from comment #1)
> > 5.0 even crashes!
> 
> ..when closing the navigator dialog after theme change, that is.

no crash in

Version: 6.3.0.0.alpha0+
Build ID: ed707a4806a489467c6d9be7d1b787dab94b5f78
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded

but there is a problem with change of icons in the Navigator


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103030
[Bug 103030] [META] Navigator sidebar deck and floating window
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 90380] VIEWING: Navigator causes constant cpu usage when it does not have focus in documents with lots of text frames and images

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90380

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||103030

--- Comment #6 from Roman Kuznetsov <79045_79...@mail.ru> ---
still repro in

Version: 6.3.0.0.alpha0+
Build ID: ed707a4806a489467c6d9be7d1b787dab94b5f78
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103030
[Bug 103030] [META] Navigator sidebar deck and floating window
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123041] Autocorrect: Abbreviations with spaces are not considered within text

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123041

Jens Radloff  changed:

   What|Removed |Added

 CC||plixp...@yahoo.de

--- Comment #1 from Jens Radloff  ---
I can confirm the behaviour described in the description of this bug report in
version 6.3.0.0. 

Note that "z. B. Ein" is grammatically wrong in German, it should be "z. B.
ein". 

Please note the space character between "z." and "B." in this German
abbreviation. The correct spelling of this abbreviation and other German
abbrevations has to contain a space character.

I am using Linux Debian 9.7 ("Stretch") which is the currently stable Debian
release.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103030

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||90380


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=90380
[Bug 90380] VIEWING:  Navigator causes constant cpu usage when it does not have
focus in documents with lots of text frames and images
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89274] A subdocument doesn't get inserted after the currently selected item in the navigator

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89274

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||107805, 103030

--- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> ---
still repro in

Version: 6.3.0.0.alpha0+
Build ID: ed707a4806a489467c6d9be7d1b787dab94b5f78
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103030
[Bug 103030] [META] Navigator sidebar deck and floating window
https://bugs.documentfoundation.org/show_bug.cgi?id=107805
[Bug 107805] [META] Writer master document issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103030

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||89274


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=89274
[Bug 89274] A subdocument doesn't get inserted after the currently selected
item in the navigator
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107805] [META] Writer master document issues

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107805

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||89274


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=89274
[Bug 89274] A subdocument doesn't get inserted after the currently selected
item in the navigator
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103030

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||82786


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=82786
[Bug 82786] UI: Navigator: Hide "Go to Header" and "Go to footer" if there
aren't any
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 82786] UI: Navigator: Hide "Go to Header" and "Go to footer" if there aren't any

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=82786

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||103030


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103030
[Bug 103030] [META] Navigator sidebar deck and floating window
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 62282] targets overview and navigator need improved GUI

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=62282

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||103030


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103030
[Bug 103030] [META] Navigator sidebar deck and floating window
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103030

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||62282


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=62282
[Bug 62282] targets overview and navigator need improved GUI
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 63744] Navigator view moves and closes hierarchy while typing in document

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=63744

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||103030


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103030
[Bug 103030] [META] Navigator sidebar deck and floating window
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103030

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||63744


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=63744
[Bug 63744] Navigator view moves and closes hierarchy while typing in document
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #235 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/b89dbc08b735384cdc9e469b044842fb729ced0b%5E%21

tdf#45904 Move XPropertySet Java tests to C++

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: framework/qa qadevOOo/Jar_OOoRunner.mk qadevOOo/objdsc qadevOOo/tests sc/qa

2019-01-29 Thread Libreoffice Gerrit user
 framework/qa/complex/api_internal/api.lst|
1 
 qadevOOo/Jar_OOoRunner.mk|
1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSpreadsheetSettingsObj.csv |
7 
 qadevOOo/tests/java/mod/_sc/ScSpreadsheetSettingsObj.java|   
94 --
 sc/qa/extras/scspreadsheetsettingsobj.cxx|   
29 ++-
 sc/qa/unoapi/sc_6.sce|
1 
 6 files changed, 27 insertions(+), 106 deletions(-)

New commits:
commit b89dbc08b735384cdc9e469b044842fb729ced0b
Author: Jens Carl 
AuthorDate: Wed Jan 30 05:58:49 2019 +
Commit: Jens Carl 
CommitDate: Wed Jan 30 08:20:51 2019 +0100

tdf#45904 Move XPropertySet Java tests to C++

Move XPropertySet Java tests to C++ for ScSpreadsheetSettingsObj.

Change-Id: I59da149983ee3b897c1cdeaf5f40962b917c91ba
Reviewed-on: https://gerrit.libreoffice.org/67101
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/framework/qa/complex/api_internal/api.lst 
b/framework/qa/complex/api_internal/api.lst
index 751bb7ccd89c..64cfe9d6c7f7 100644
--- a/framework/qa/complex/api_internal/api.lst
+++ b/framework/qa/complex/api_internal/api.lst
@@ -83,7 +83,6 @@ job91=sc.ScDataPilotFieldsObj
 job98=sc.ScHeaderFieldObj
 job99=sc.ScHeaderFieldsObj
 job126=sc.ScSheetLinkObj
-job129=sc.ScSpreadsheetSettingsObj
 job131=sc.ScStyleFamilyObj
 job132=sc.ScStyleObj
 job134=sc.ScTableColumnObj
diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk
index a80f13887733..61623c302bb1 100644
--- a/qadevOOo/Jar_OOoRunner.mk
+++ b/qadevOOo/Jar_OOoRunner.mk
@@ -980,7 +980,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\
 qadevOOo/tests/java/mod/_sc/ScModelObj \
 qadevOOo/tests/java/mod/_sc/ScShapeObj \
 qadevOOo/tests/java/mod/_sc/ScSheetLinkObj \
-qadevOOo/tests/java/mod/_sc/ScSpreadsheetSettingsObj \
 qadevOOo/tests/java/mod/_sc/ScStyleFamilyObj \
 qadevOOo/tests/java/mod/_sc/ScStyleObj \
 qadevOOo/tests/java/mod/_sc/ScSubTotalDescriptorBase \
diff --git 
a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSpreadsheetSettingsObj.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSpreadsheetSettingsObj.csv
deleted file mode 100644
index 7a473c2de4b9..
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSpreadsheetSettingsObj.csv
+++ /dev/null
@@ -1,7 +0,0 @@
-"ScSpreadsheetSettingsObj";"com::sun::star::beans::XPropertySet";"getPropertySetInfo()"
-"ScSpreadsheetSettingsObj";"com::sun::star::beans::XPropertySet";"setPropertyValue()"
-"ScSpreadsheetSettingsObj";"com::sun::star::beans::XPropertySet";"getPropertyValue()"
-"ScSpreadsheetSettingsObj";"com::sun::star::beans::XPropertySet";"addPropertyChangeListener()"
-"ScSpreadsheetSettingsObj";"com::sun::star::beans::XPropertySet";"removePropertyChangeListener()"
-"ScSpreadsheetSettingsObj";"com::sun::star::beans::XPropertySet";"addVetoableChangeListener()"
-"ScSpreadsheetSettingsObj";"com::sun::star::beans::XPropertySet";"removeVetoableChangeListener()"
diff --git a/qadevOOo/tests/java/mod/_sc/ScSpreadsheetSettingsObj.java 
b/qadevOOo/tests/java/mod/_sc/ScSpreadsheetSettingsObj.java
deleted file mode 100644
index 84b6eeb895ad..
--- a/qadevOOo/tests/java/mod/_sc/ScSpreadsheetSettingsObj.java
+++ /dev/null
@@ -1,94 +0,0 @@
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-package mod._sc;
-
-import java.io.PrintWriter;
-
-import lib.StatusException;
-import lib.TestCase;
-import lib.TestEnvironment;
-import lib.TestParameters;
-import util.SOfficeFactory;
-
-import com.sun.star.lang.XComponent;
-import com.sun.star.sheet.XSpreadsheetDocument;
-import com.sun.star.uno.UnoRuntime;
-import com.sun.star.uno.XInterface;
-
-/**
-* Test for object which is represented by service
-* com.sun.star.sheet.SpreadsheetDocumentSettings. 
-* Object implements the following interfaces :
-* 
-*   com::sun::star::sheet::SpreadsheetDocumentSettings
-*   com::sun::star::beans::XPropertySet
-* 
-* @see com.sun.star.sheet.SpreadsheetDocumentSettings
-* @see com.sun.star.beans.XPropertySet
-* @see ifc.sheet._SpreadsheetDocumentSettings
-* @see 

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4' - 3 commits - loleaflet/css loleaflet/html loleaflet/src

2019-01-29 Thread Libreoffice Gerrit user
 loleaflet/css/loleaflet.css  |  172 ---
 loleaflet/html/loleaflet.html.m4 |8 -
 loleaflet/src/map/Map.js |5 +
 3 files changed, 100 insertions(+), 85 deletions(-)

New commits:
commit 59e728da9452cff6de6ea69af822919cff51816e
Author: Szymon Kłos 
AuthorDate: Tue Jan 29 20:51:16 2019 +0100
Commit: Szymon Kłos 
CommitDate: Tue Jan 29 21:19:46 2019 +0100

Unify whitespaces in loleaflet.css

Change-Id: I6d916acac8f6b7d4c71eab4fd63b5e13d61be4a1

diff --git a/loleaflet/css/loleaflet.css b/loleaflet/css/loleaflet.css
index d42c7c4e4..798612ca7 100644
--- a/loleaflet/css/loleaflet.css
+++ b/loleaflet/css/loleaflet.css
@@ -13,11 +13,11 @@
 }
 
 #document-container.readonly {
-top: 36px;
+   top: 36px;
 }
 
 #toolbar-wrapper.readonly {
-display: none;
+   display: none;
 }
 
 #map {
@@ -36,111 +36,112 @@
 }
 
 .loleaflet-scrollbar-show {
-opacity: 1 !important;
-filter: "alpha(opacity=100)" !important;
--ms-filter: "alpha(opacity=100)" !important;
+   opacity: 1 !important;
+   filter: "alpha(opacity=100)" !important;
+   -ms-filter: "alpha(opacity=100)" !important;
 }
 
 body {
-margin: 0;
-overflow: hidden;
-overscroll-behavior-y: none; /* disable the pull to reload gesture */
-background: #ff;
-touch-action: none;
+   margin: 0;
+   overflow: hidden;
+   overscroll-behavior-y: none; /* disable the pull to reload gesture */
+   background: #ff;
+   touch-action: none;
 }
 
 #presentation-controls-wrapper {
-background: #dfdfdf;
-position: absolute;
-top: 77px;
-left: 0px;
-bottom: 66px;
-max-width: 218px;
-border-top: 1px solid #b6b6b6;
-display: block;
+   background: #dfdfdf;
+   position: absolute;
+   top: 77px;
+   left: 0px;
+   bottom: 66px;
+   max-width: 218px;
+   border-top: 1px solid #b6b6b6;
+   display: block;
 }
 
 #presentation-controls-wrapper.drawing {
-bottom: 40px; /* Hide the presentation toolbar (insert slide etc.) for 
doctype = drawing */
+   bottom: 40px; /* Hide the presentation toolbar (insert slide etc.) for 
doctype = drawing */
 }
 
 #presentation-controls-wrapper.readonly {
-top: 36px;
+   top: 36px;
 }
 
 #toolbar-wrapper {
-position: relative;
-table-layout: fixed;
-border-collapse: collapse;
+   position: relative;
+   table-layout: fixed;
+   border-collapse: collapse;
width: 100%;
border-top: 1px solid #bb;
 }
 
 #toolbar-logo {
-width: 0;
+   width: 0;
 }
 
 #toolbar-hamburger {
-width: 0;
+   width: 0;
 }
 
 #mobile-edit-button {
-position: absolute;
-width: 56px;
-height: 56px;
-right: 16px;
-bottom: 16px;
-background-color: #0b87e7;
-border-radius: 50%;
-box-shadow: 0 4px 8px 0 rgba(0, 0, 0, 0.2), 0 6px 20px 0 rgba(0, 0, 0, 
0.19);
-z-index: 2000;
+   position: absolute;
+   width: 56px;
+   height: 56px;
+   right: 16px;
+   bottom: 16px;
+   background-color: #0b87e7;
+   border-radius: 50%;
+   box-shadow: 0 4px 8px 0 rgba(0, 0, 0, 0.2), 0 6px 20px 0 rgba(0, 0, 0, 
0.19);
+   z-index: 2000;
 }
 
 #mobile-edit-button-image {
-position: relative;
-left: 16px;
-top: 16px;
-width: 24px;
-height: 24px;
-background: url('images/baseline-edit-24px.svg') no-repeat center 
!important;
+   position: relative;
+   left: 16px;
+   top: 16px;
+   width: 24px;
+   height: 24px;
+   background: url('images/baseline-edit-24px.svg') no-repeat center 
!important;
 }
 
 @media (max-width: 767px),(max-device-height: 767px) {
-/* Show slidesorter beyond 768px only */
-#presentation-controls-wrapper {
+   /* Show slidesorter beyond 768px only */
+   #presentation-controls-wrapper {
display: none;
-}
+   }
 
-#document-container.tablet {
-top: 41px;
-}
+   #document-container.tablet {
+   top: 41px;
+   }
 
-#document-container.readonly {
-top: 41px;
-}
+   #document-container.readonly {
+   top: 41px;
+   }
 
-#document-container.parts-preview-document {
+   #document-container.parts-preview-document {
left: 0px !important;
-}
-#document-container.spreadsheet-document {
+   }
+   #document-container.spreadsheet-document {
top: 103px !important;
-}
-#document-container.spreadsheet-document.readonly {
+   }
+   #document-container.spreadsheet-document.readonly {
top: 61px !important;
-}
-#document-container {
+   }
+   #document-container {
top: 41px;
-}
-#spreadsheet-row-column-frame {
+
+   }
+   #spreadsheet-row-column-frame {
top: 83px !important;
-}
-#spreadsheet-row-column-frame.readonly {
+   }
+   #spreadsheet-row-column-frame.readonly {
  

[Libreoffice-bugs] [Bug 123047] Editing: Table of Contents (TOC) contains lines with dots only - no line break at appropriate position in text line above

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123047

--- Comment #3 from Jens Radloff  ---
Please note that before I inserted the respective text strings of the headings
from the original .odt document (which I do not want to upload here) into the
new .odt file (which is attached to this bug report), I copied these headings
from the original .odt file into a text editor programme and then from the text
editor programme into the new .odt file.

I did this to prevent heading formattings being transferred from the original
.odt document to the new .odt document.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123047] Editing: Table of Contents (TOC) contains lines with dots only - no line break at appropriate position in text line above

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123047

--- Comment #2 from Jens Radloff  ---
I have created a new .odt document containing only the headings which you can
see in the attached png file (screenshot). The behaviour occurs in this new
.odt. file, too. I have attached this new .odt file.

Basic information about how I set up my LO writer installation can be found in
the attached .odt file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123047] Editing: Table of Contents (TOC) contains lines with dots only - no line break at appropriate position in text line above

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123047

--- Comment #1 from Jens Radloff  ---
Created attachment 148745
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148745=edit
.odt file showing the behaviour (on my machine)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=49033

--- Comment #37 from Ljiljan  ---
(In reply to Mike Kaganski from comment #36)
> (In reply to Ljiljan from comment #35)
> 
> I had decided to fix this, and so I found all relevant code and  saw the
> implementation; while thinking of possible reimplementation, I fount it
> useful to ask specific questions, so that the programming decisions would be
> clear and based on user requirements.
> 
> But now you are free to fix this yourself. I'm no more interested in this.

No problem, I also stopped reporting bugs because their only purporse is to
make developer aware what makes me nervous. Their logic is always the right
one, afterall we are getting software for free so learn to live with that.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=49033

--- Comment #36 from Mike Kaganski  ---
(In reply to Ljiljan from comment #35)

I had decided to fix this, and so I found all relevant code and  saw the
implementation; while thinking of possible reimplementation, I fount it useful
to ask specific questions, so that the programming decisions would be clear and
based on user requirements.

But now you are free to fix this yourself. I'm no more interested in this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120695] FILEOPEN unixODBC connection to sqlite database not working

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120695

--- Comment #13 from verlata  ---
@Robert: you are right. I choose 6.1.2 because at the time I opened the bug
report 6.1.3 was not availabable in the version dropdown list.

Still waiting for an hint to help me debug and fix the problem...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=49033

--- Comment #35 from Ljiljan  ---
I just find it funny that we invest so much energy in something that just
cannot be user's logic. You select the text and you expect to see changes in
the selection.

My following reply should be considered only as the purpose to illustrate how
far we can go regarding this issue (my answer are written as satire just to
illustrate how pointless this can be). We don't have empirical evidence to
support which logic is right, but current logic "selection -> only selection
changes" make more sense than "selection -> both selection and the text until
the next full stop".

(In reply to Mike Kaganski from comment #34)
> (In reply to V Stuart Foote from comment #31)
> 
> Let's discuss the details :-)
> 
> 1. What should be done when a sentence start is selected, but not to the
> sentence end? (I'm pretty confident the sentence start here should be
> capitalized.)

Maybe changes should be extended to all sentences in the document, and all
sentence starts should be capitalized because that is what the user wants since
he/she selected the beginning of the sentence. In case he/she wanted to select
only the current sentence, then he/she should select the current sentence.
Otherwise, he /she indicates that the start of the sentence is important and it
should be changed consistently in the document. No, the user did not select
this part of the text (sentence start) expecting it to be changed, he/she was
expecting more! 

> 2. What should be done if a sentence end is selected, but not from start?
> (This one IMO is not that straightforward: we can capitalize the first
> selected character, or we may skip the sentence; my take would be 
> capitalized> first selected character.)

The first next sentence should be capitalized, but also it should recommend
capitalizing all other sentences in the following paragraph. After all, the
user did not intend to capitalize this sentence since he/she did not select it
from the beginning. No, the user did not select the sentence end expecting it
to be changed, he/she was expecting more!   

> 3. What should be done if selection starts in the middle of a word (possibly
> not the first in a sentence)? We could capitalize first character of the
> word (again not good for Shift+F3); or first selected character; or skip the
> sentence. (I'd capitalize first selected character.)

In this case, we should you SpellCheck to see it this word exists in our
dictionary. The user is probably not sure about the selection of the word
(maybe he/she wrote "upcoming", but now considering only using "coming"). No,
the user did not select this part of the text expecting it to be changed,
he/she was expecting more!


> 4. What should we do when there's no selection? We could capitalize first
> character of the current word (if any; like UPPERCASE at al work); or current
> sentence. (My take is Capitalize current sentence.)

This is a special case where we should use AI to detect eyes movement in order
to detect sentence user would like to capitalize. 

> 5. What should be done with Capitalize Every Word function, that now also
> expands to whole words, even if only parts are selected? It's not in
> Shift+F3 IIUC, but it would become inconsistent. (I'd say change it
> consistently.)

I don't understand this, but AI might help here too. 

> 6. Should we only do the change for Word, or for other modules
> (Calc/Impress/etc) too for consistency? (I'd say yes.)

Definitely. Impress would be great since people use bullets, no full stops, so
this will capitalize only first bullet, and the other points would be lower
case... One slide should look like a long sentence! The same applies to Calc.
Maybe all sentences in one column can be changed to make it look consistent! Or
row. Not sure anymore!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: include/svx svx/source sw/qa sw/source

2019-01-29 Thread Libreoffice Gerrit user
 include/svx/svdcrtv.hxx|3 +
 svx/source/svdraw/svdcrtv.cxx  |   45 +
 sw/qa/extras/tiledrendering/tiledrendering.cxx |6 ++-
 sw/source/core/frmedt/feshview.cxx |1 
 4 files changed, 34 insertions(+), 21 deletions(-)

New commits:
commit b6b28931435e44aca92b8c0e1659f701e3ed1a87
Author: Jan Holesovsky 
AuthorDate: Fri Jan 25 14:40:40 2019 +0100
Commit: Jan Holesovsky 
CommitDate: Wed Jan 30 07:29:52 2019 +0100

sw: Ctrl + shape insertion was not setting up the layer.

The consequence was that the shapes were inserted into the background
layer.

The problem was particularly visible with the LOK, but reproducible on
the desktop too.

Includes unit test.

Change-Id: I16137331f944101e25679ec8c4a034bea658bc57
Reviewed-on: https://gerrit.libreoffice.org/66917
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky 

diff --git a/include/svx/svdcrtv.hxx b/include/svx/svdcrtv.hxx
index 9b6a08e8f93b..2b1941373fb0 100644
--- a/include/svx/svdcrtv.hxx
+++ b/include/svx/svdcrtv.hxx
@@ -118,6 +118,9 @@ public:
 bool IsCreateObj() const { return pCurrentCreate!=nullptr; }
 SdrObject* GetCreateObj() const { return pCurrentCreate; }
 
+/// Setup layer (eg. foreground / background) of the given object.
+static void SetupObjLayer(const SdrPageView* pPageView, const OUString& 
aActiveLayer, SdrObject* pObj);
+
 // BegCreateCaptionObj() creates a SdrCaptionObj (legend item).
 // rObjSiz is the initial size of the legend text frame.
 // Only the length of the tip is dragged
diff --git a/svx/source/svdraw/svdcrtv.cxx b/svx/source/svdraw/svdcrtv.cxx
index 911481038d79..711080113382 100644
--- a/svx/source/svdraw/svdcrtv.cxx
+++ b/svx/source/svdraw/svdcrtv.cxx
@@ -569,6 +569,30 @@ void SdrCreateView::MovCreateObj(const Point& rPnt)
 }
 }
 
+void SdrCreateView::SetupObjLayer(const SdrPageView* pPageView, const 
OUString& aActiveLayer, SdrObject* pObj)
+{
+const SdrLayerAdmin& rAd = pPageView->GetPage()->GetLayerAdmin();
+SdrLayerID nLayer(0);
+
+// #i72535#
+if(dynamic_cast( pObj) !=  nullptr)
+{
+// for FormControls, force to form layer
+nLayer = rAd.GetLayerID(rAd.GetControlLayerName());
+}
+else
+{
+nLayer = rAd.GetLayerID(aActiveLayer);
+}
+
+if(SDRLAYER_NOTFOUND == nLayer)
+{
+nLayer = SdrLayerID(0);
+}
+
+pObj->SetLayer(nLayer);
+}
+
 bool SdrCreateView::EndCreateObj(SdrCreateCmd eCmd)
 {
 bool bRet=false;
@@ -599,26 +623,7 @@ bool SdrCreateView::EndCreateObj(SdrCreateCmd eCmd)
 SdrObject* pObj=pCurrentCreate;
 pCurrentCreate=nullptr;
 
-const SdrLayerAdmin& rAd = 
pCreatePV->GetPage()->GetLayerAdmin();
-SdrLayerID nLayer(0);
-
-// #i72535#
-if(dynamic_cast( pObj) !=  nullptr)
-{
-// for FormControls, force to form layer
-nLayer = rAd.GetLayerID(rAd.GetControlLayerName());
-}
-else
-{
-nLayer = rAd.GetLayerID(maActualLayer);
-}
-
-if(SDRLAYER_NOTFOUND == nLayer)
-{
-nLayer = SdrLayerID(0);
-}
-
-pObj->SetLayer(nLayer);
+SetupObjLayer(pCreatePV, maActualLayer, pObj);
 
 // recognize creation of a new 3D object inside a 3D scene
 bool bSceneIntoScene(false);
diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx 
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index 6bd016702026..be14c00a8ba6 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -470,10 +470,14 @@ void SwTiledRenderingTest::testInsertShape()
 comphelper::dispatchCommand(".uno:BasicShapes.circle", 
uno::Sequence());
 
 // check that the shape was inserted in the visible area, not outside
-SdrPage* pPage = 
pWrtShell->GetDoc()->getIDocumentDrawModelAccess().GetDrawModel()->GetPage(0);
+IDocumentDrawModelAccess  = 
pWrtShell->GetDoc()->getIDocumentDrawModelAccess();
+SdrPage* pPage = rDrawModelAccess.GetDrawModel()->GetPage(0);
 SdrObject* pObject = pPage->GetObj(0);
 CPPUNIT_ASSERT_EQUAL(tools::Rectangle(2736, 868, 7264, 3132), 
pObject->GetSnapRect());
 
+// check that it is in the foreground layer
+CPPUNIT_ASSERT_EQUAL(rDrawModelAccess.GetHeavenId().get(), 
pObject->GetLayer().get());
+
 comphelper::LibreOfficeKit::setActive(false);
 }
 
diff --git a/sw/source/core/frmedt/feshview.cxx 
b/sw/source/core/frmedt/feshview.cxx
index e7486384e692..126c95074b9e 100644
--- a/sw/source/core/frmedt/feshview.cxx
+++ b/sw/source/core/frmedt/feshview.cxx
@@ -3147,6 +3147,7 @@ long SwFEShell::GetSectionWidth( SwFormat const & rFormat 
) const
   

[Libreoffice-bugs] [Bug 84837] Make show/hide comments UNO command work in Calc

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84837

--- Comment #193 from Tech News  ---
Maruti Suzuki Connect App: A Platform To Help Users Manage Important Parameters
At Their Fingertips India's largest automobile manufacturer Maruti Suzuki has
established its innovative telematics alternative 'Suzuki Connect' because of
the Nexa clients.
https://www.thinkingtech.in/apps/maruti-suzuki-connect-app/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/inc vcl/win

2019-01-29 Thread Libreoffice Gerrit user
 vcl/inc/win/scoped_gdi.hxx |   17 ++
 vcl/win/gdi/gdiimpl.cxx|   52 +
 2 files changed, 42 insertions(+), 27 deletions(-)

New commits:
commit c2c60eb9969716ef91a83952203948b5e334ec85
Author: Dmitriy Shilin 
AuthorDate: Sun Jan 20 00:08:30 2019 -0800
Commit: Mike Kaganski 
CommitDate: Wed Jan 30 07:14:37 2019 +0100

tdf#107792 vcl/win: introduce ScopedCachedHDC

Change-Id: Ia6c5ca98005642bbcce9d9d66bf16a4d4cbed04e
Reviewed-on: https://gerrit.libreoffice.org/66648
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/vcl/inc/win/scoped_gdi.hxx b/vcl/inc/win/scoped_gdi.hxx
index 0fb82112e68c..d02ad9545749 100644
--- a/vcl/inc/win/scoped_gdi.hxx
+++ b/vcl/inc/win/scoped_gdi.hxx
@@ -12,6 +12,7 @@
 
 #include 
 #include 
+#include 
 
 #include 
 
@@ -53,6 +54,22 @@ using ScopedSelectedHPEN = ScopedSelectedGDI;
 using ScopedSelectedHFONT = ScopedSelectedGDI;
 using ScopedSelectedHBRUSH = ScopedSelectedGDI;
 
+template  class ScopedCachedHDC
+{
+public:
+explicit ScopedCachedHDC(HBITMAP hBitmap)
+: m_hDC(ImplGetCachedDC(ID, hBitmap))
+{
+}
+
+~ScopedCachedHDC() { ImplReleaseCachedDC(ID); }
+
+HDC get() const { return m_hDC; }
+
+private:
+HDC m_hDC;
+};
+
 #endif // INCLUDED_VCL_INC_WIN_SCOPED_GDI_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/vcl/win/gdi/gdiimpl.cxx b/vcl/win/gdi/gdiimpl.cxx
index a9406729fa21..1f654ebbee77 100644
--- a/vcl/win/gdi/gdiimpl.cxx
+++ b/vcl/win/gdi/gdiimpl.cxx
@@ -559,7 +559,8 @@ void ImplDrawBitmap( HDC hDC, const SalTwoRect& rPosAry, 
const WinSalBitmap& rSa
 }
 else if( hDrawDDB && !bPrintDDB )
 {
-HDC hBmpDC = ImplGetCachedDC( CACHED_HDC_DRAW, hDrawDDB );
+ScopedCachedHDC hBmpDC(hDrawDDB);
+
 COLORREFnOldBkColor = RGB(0xFF,0xFF,0xFF);
 COLORREFnOldTextColor = RGB(0,0,0);
 boolbMono = ( rSalBitmap.GetBitCount() == 1 );
@@ -592,7 +593,7 @@ void ImplDrawBitmap( HDC hDC, const SalTwoRect& rPosAry, 
const WinSalBitmap& rSa
 BitBlt( hDC,
 static_cast(rPosAry.mnDestX), 
static_cast(rPosAry.mnDestY),
 static_cast(rPosAry.mnDestWidth), 
static_cast(rPosAry.mnDestHeight),
-hBmpDC,
+hBmpDC.get(),
 static_cast(rPosAry.mnSrcX), 
static_cast(rPosAry.mnSrcY),
 nDrawMode );
 }
@@ -603,7 +604,7 @@ void ImplDrawBitmap( HDC hDC, const SalTwoRect& rPosAry, 
const WinSalBitmap& rSa
 StretchBlt( hDC,
 static_cast(rPosAry.mnDestX), 
static_cast(rPosAry.mnDestY),
 static_cast(rPosAry.mnDestWidth), 
static_cast(rPosAry.mnDestHeight),
-hBmpDC,
+hBmpDC.get(),
 static_cast(rPosAry.mnSrcX), 
static_cast(rPosAry.mnSrcY),
 static_cast(rPosAry.mnSrcWidth), 
static_cast(rPosAry.mnSrcHeight),
 nDrawMode );
@@ -616,8 +617,6 @@ void ImplDrawBitmap( HDC hDC, const SalTwoRect& rPosAry, 
const WinSalBitmap& rSa
 SetBkColor( hDC, nOldBkColor );
 ::SetTextColor( hDC, nOldTextColor );
 }
-
-ImplReleaseCachedDC( CACHED_HDC_DRAW );
 }
 }
 }
@@ -688,11 +687,11 @@ void WinSalGraphicsImpl::drawBitmap( const SalTwoRect& 
rPosAry,
 hMaskBitmap.reset(CreateCompatibleBitmap(hDC, nDstWidth, nDstHeight));
 }
 
-HDC hMemDC = ImplGetCachedDC( CACHED_HDC_1, hMemBitmap.get() );
-HDC hMaskDC = ImplGetCachedDC( CACHED_HDC_2, hMaskBitmap.get() );
+ScopedCachedHDC hMemDC(hMemBitmap.get());
+ScopedCachedHDC hMaskDC(hMaskBitmap.get());
 
 aPosAry.mnDestX = aPosAry.mnDestY = 0;
-BitBlt( hMemDC, 0, 0, nDstWidth, nDstHeight, hDC, nDstX, nDstY, SRCCOPY );
+BitBlt( hMemDC.get(), 0, 0, nDstWidth, nDstHeight, hDC, nDstX, nDstY, 
SRCCOPY );
 
 // WIN/WNT seems to have a minor problem mapping the correct color of the
 // mask to the palette if we draw the DIB directly ==> draw DDB
@@ -701,35 +700,32 @@ void WinSalGraphicsImpl::drawBitmap( const SalTwoRect& 
rPosAry,
 WinSalBitmap aTmp;
 
 if( aTmp.Create( rTransparentBitmap,  ) )
-ImplDrawBitmap( hMaskDC, aPosAry, aTmp, false, SRCCOPY );
+ImplDrawBitmap( hMaskDC.get(), aPosAry, aTmp, false, SRCCOPY );
 }
 else
-ImplDrawBitmap( hMaskDC, aPosAry, rTransparentBitmap, false, SRCCOPY );
+ImplDrawBitmap( hMaskDC.get(), aPosAry, rTransparentBitmap, false, 
SRCCOPY );
 
 // now MemDC contains background, MaskDC the transparency mask
 
 // #105055# Respect XOR mode
 if( mbXORMode )
 {
-ImplDrawBitmap( hMaskDC, aPosAry, rSalBitmap, 

[Libreoffice-commits] core.git: bin/lo-commit-stat

2019-01-29 Thread Libreoffice Gerrit user
 bin/lo-commit-stat |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 44df356a075acadeb980bce80e99c73154e846ea
Author: Andrea Gelmini 
AuthorDate: Mon Jan 28 10:43:44 2019 +
Commit: Julien Nabet 
CommitDate: Wed Jan 30 07:08:22 2019 +0100

Fix typo

Change-Id: I01f5a09e65091f460c28f6c18d683f5a3135762e
Reviewed-on: https://gerrit.libreoffice.org/67100
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/bin/lo-commit-stat b/bin/lo-commit-stat
index e76d0c0875bf..64278b894d42 100755
--- a/bin/lo-commit-stat
+++ b/bin/lo-commit-stat
@@ -466,7 +466,7 @@ sub usage()
   " --log-suffix= suffix of the log file name; the result 
will be\n" .
   "  commit-log--.log; 
the branch name\n" .
   "  is detected automatically\n" .
-  " --commitsgenerete log with all commits (default)\n" .
+  " --commitsgenerate log with all commits (default)\n" .
   " --bugs   generate log with bugzilla entries\n" .
   " --bugs-changelog generate log with bugzilla entries, use 
changelog style\n" .
   " --bugs-wiki  generate log with bugzilla entries, use wiki 
markup\n" .
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 123047] New: Editing: Table of Contents (TOC) contains lines with dots only - no line break at appropriate position in text line above

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123047

Bug ID: 123047
   Summary: Editing: Table of Contents (TOC) contains lines with
dots only - no line break at appropriate position in
text line above
   Product: LibreOffice
   Version: 6.1.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: plixp...@yahoo.de

Created attachment 148744
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148744=edit
Screenshot showing the behaviour

The TOC in the .odt document I am working on since months again shows lines
which only contain dots. This affects entries in the TOC of levels 1 and 2. My
document contains only the first and the second heading level.

For demonstration purposes, refer to the attached screenshot. 

In the TOC settings on the "Entries" tab, all levels are connected with the
character style "None". If I change the character style of level 1 or level 2
to the character style "Default style", then the behaviour described above does
not get resolved. By the way, if I then again open the "Entries" tab in the TOC
settings, the character style has been set back to "None" for level 1 and level
2.

I can easily provoke this behaviour. If I change the text of heading 

"'Nominelle' Mitgliedschaft in der NSDAP. Falsche Angabe über den Zeitpunkt des
Eintritts in die NSDAP" 

(the behaviour does not occur with this length of this heading) 

to 

"'Nominelle' Mitgliedschaft in der NSDAP. Falsche Angabe über den Zeitpunkt"

(i.e. I deleted the last three words of that heading)

, then the behaviour occurs, as it is visible with this shortened heading in
the attached screenshot.

I am using Linux Debian 9.7 ("Stretch"9), the currently stable Debian release.

I cannot upload the affected file here because it contains personal data about
my family.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 102052] Print Directly printer string should only appear in the tooltip

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102052

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112713] incorrect end-of-line on very large pages

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112713

--- Comment #3 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 114851] Toolbar names are translated numerous times

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114851

--- Comment #2 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 97160] Linux: OpenGL causes applications to crash on launch

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=97160

--- Comment #30 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112945] FORMATTING Tooltips for cell shadow swapped

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112945

--- Comment #2 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 91761] Crash when copying contents from one form to another form

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91761

--- Comment #12 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115257] FILESAVE: format of the base text and the ruby text lost or incorrect when saved as doc document.

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115257

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115256] FILESAVE: incorrect ruby text position in exported rtf file.

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115256

--- Comment #3 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 32418] Add an "insert symbol" to Math

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=32418

Ashwin Godbole  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |ashvin.godb...@gmail.com
   |desktop.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89998] Fill series should be the minimal increment for the given value, rather than always be added by 1

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89998

Adolfo Jayme  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |martin.vanz...@gmail.com
   |desktop.org |
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123046] New: Undo sequence causes Impress to freeze

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123046

Bug ID: 123046
   Summary: Undo sequence causes Impress to freeze
   Product: LibreOffice
   Version: 6.1.4.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rfgiu...@gmail.com

Description:
Impress freezes on certain sequences of undo involving nested items and slide
pasting, taking 100% CPU and requiring to be killed.

Steps to Reproduce:
1. Start a new presentation with blank theme
2. Insert a new slide
3. Click where instructed to add text
4. Input a one-word item and a nested one-word item
5. Select this slide on the slides list, copy and paste
6. On the pasted slide, click on the text area, select all text, and replace it
with a single item
7. In rapid succession, press CTRL+Z twice

Actual Results:
Impress freezes, takes 100% CPU, and stays frozen for minutes, eventually
requiring to be killed.

Expected Results:
The first undo should give you two nested items, the second should remove the
pasted slide


Reproducible: Always


User Profile Reset: No



Additional Info:
The bug is reproducible even in safe mode. I am note sure I properly managed to
reset my profile. However I was able to reproduce for a freshly created user.

This seems to happen only when the user launching LibreOffice is the same user
who started the session. That is, launching LO for a different user from the
terminal does not seem to reproduce the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123043] Type character detection on variable name should be Unicode-aware

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123043

--- Comment #4 from himajin100...@gmail.com ---
>Honestly I don't know why the code is performing cSuffix check twice. Isn't 
>once enough?

I was misrundertanding. the second one is for rIndex, not for rVar.

>How idiot I was!

typo: How idiot => What an idiot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85677] Dragging on a Windows touchscreen highlights instead of scrolling

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=85677

--- Comment #10 from Martin Plamondon  ---
LibreOffice 6.1.3.2 on Windows 10 and it is still an issue.  This is very
annoying with TouchScreen where we're used to use fingers to scroll everywhere.
 How can a bug like that not fixed after 4 years opened.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 44266] Objects taken from the gallery do not align to the grid (objects should have an anchor point)

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=44266

--- Comment #22 from Fisto Victor  ---
Very Helpful Information, I like it Very Much.. Thanks for this post

Visit us - http://www.restore-homepage.com/fixmestick-customer-support-service

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: include/test sc/qa solenv/clang-format test/Library_subsequenttest.mk test/source

2019-01-29 Thread Libreoffice Gerrit user
 include/test/sheet/xsheetfilterdescriptor.hxx  |   13 +++
 include/test/sheet/xsheetfilterdescriptor2.hxx |   35 
 include/test/sheet/xsheetfilterdescriptor3.hxx |   35 
 sc/qa/extras/scfilterdescriptorbase.cxx|   14 +++-
 solenv/clang-format/blacklist  |2 -
 test/Library_subsequenttest.mk |2 +
 test/source/sheet/xsheetfilterdescriptor.cxx   |   29 
 test/source/sheet/xsheetfilterdescriptor2.cxx  |   43 +
 test/source/sheet/xsheetfilterdescriptor3.cxx  |   43 +
 9 files changed, 192 insertions(+), 24 deletions(-)

New commits:
commit ce2b98580b9f36d6f358bd2c9c027d3d82cb33d7
Author: Jens Carl 
AuthorDate: Tue Jan 29 21:32:14 2019 +
Commit: Jens Carl 
CommitDate: Tue Jan 29 23:57:08 2019 +0100

Add XSheetFilterDescriptor2 and XSheetFilterDescriptor3 tests

Add XSheetFilterDescriptor2 and XSheetFilterDescriptor3 tests
to ScFilterDescriptorBase.

Change-Id: I932560c42d9c5f3077f47f116f6ae011f6aea79e
Reviewed-on: https://gerrit.libreoffice.org/67097
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/include/test/sheet/xsheetfilterdescriptor.hxx 
b/include/test/sheet/xsheetfilterdescriptor.hxx
index 3a4a6a695c1b..65620f0f0936 100644
--- a/include/test/sheet/xsheetfilterdescriptor.hxx
+++ b/include/test/sheet/xsheetfilterdescriptor.hxx
@@ -1,4 +1,4 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
 /*
  * This file is part of the LibreOffice project.
  *
@@ -10,18 +10,17 @@
 #ifndef INCLUDED_TEST_SHEET_XSHEETFILTERDESCRIPTOR_HXX
 #define INCLUDED_TEST_SHEET_XSHEETFILTERDESCRIPTOR_HXX
 
-
 #include 
 #include 
 
 #include 
 
-namespace apitest {
-
+namespace apitest
+{
 class OOO_DLLPUBLIC_TEST XSheetFilterDescriptor
 {
 public:
-virtual css::uno::Reference< css::uno::XInterface > init() =0;
+virtual css::uno::Reference init() = 0;
 
 void testGetSetFilterFields();
 
@@ -29,8 +28,8 @@ protected:
 ~XSheetFilterDescriptor() {}
 };
 
-}
+} // namespace apitest
 
 #endif // INCLUDED_TEST_SHEET_XSHEETFILTERDESCRIPTOR_HXX
 
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/include/test/sheet/xsheetfilterdescriptor2.hxx 
b/include/test/sheet/xsheetfilterdescriptor2.hxx
new file mode 100644
index ..7555c65cb3a5
--- /dev/null
+++ b/include/test/sheet/xsheetfilterdescriptor2.hxx
@@ -0,0 +1,35 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#ifndef INCLUDED_TEST_SHEET_XSHEETFILTERDESCRIPTOR2_HXX
+#define INCLUDED_TEST_SHEET_XSHEETFILTERDESCRIPTOR2_HXX
+
+#include 
+#include 
+
+#include 
+
+namespace apitest
+{
+class OOO_DLLPUBLIC_TEST XSheetFilterDescriptor2
+{
+public:
+virtual css::uno::Reference init() = 0;
+
+void testGetSetFilterFields2();
+
+protected:
+~XSheetFilterDescriptor2() {}
+};
+
+} // namespace apitest
+
+#endif // INCLUDED_TEST_SHEET_XSHEETFILTERDESCRIPTOR2_HXX
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/include/test/sheet/xsheetfilterdescriptor3.hxx 
b/include/test/sheet/xsheetfilterdescriptor3.hxx
new file mode 100644
index ..1d8f94087200
--- /dev/null
+++ b/include/test/sheet/xsheetfilterdescriptor3.hxx
@@ -0,0 +1,35 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#ifndef INCLUDED_TEST_SHEET_XSHEETFILTERDESCRIPTOR3_HXX
+#define INCLUDED_TEST_SHEET_XSHEETFILTERDESCRIPTOR3_HXX
+
+#include 
+#include 
+
+#include 
+
+namespace apitest
+{
+class OOO_DLLPUBLIC_TEST XSheetFilterDescriptor3
+{
+public:
+virtual css::uno::Reference init() = 0;
+
+void testGetSetFilterFields3();
+
+protected:
+~XSheetFilterDescriptor3() {}
+};
+
+} // namespace apitest
+
+#endif // INCLUDED_TEST_SHEET_XSHEETFILTERDESCRIPTOR3_HXX
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/sc/qa/extras/scfilterdescriptorbase.cxx 
b/sc/qa/extras/scfilterdescriptorbase.cxx
index c989e60b743b..7811d6c83bf1 100644
--- a/sc/qa/extras/scfilterdescriptorbase.cxx
+++ 

[Libreoffice-bugs] [Bug 113020] EDITING: Text alignment in some templates (for example) Alizarin not working for some textboxes

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113020

Aron Budea  changed:

   What|Removed |Added

 Blocks||103314
 CC||ba...@caesar.elte.hu
Version|5.4.0.1 rc  |Inherited From OOo

--- Comment #5 from Aron Budea  ---
Still in 6.3.0.0.alpha0+ (fdc91f7493171ae600ecb293ad380df5fa77a277), and
already existed in 3.3.0, when checked with a file generated in a later
version. If the file itself is broken, then it's a different case.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103314
[Bug 103314] [META] Templates bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103314] [META] Templates bugs and enhancements

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103314

Aron Budea  changed:

   What|Removed |Added

 Depends on||113020


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113020
[Bug 113020] EDITING: Text alignment in some templates (for example) Alizarin
not working for some textboxes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: svx/qa

2019-01-29 Thread Libreoffice Gerrit user
 0 files changed

New commits:
commit 37f4c73aef2acd02b2f03d1f28ebcadf5e5dbf5e
Author: Andrea Gelmini 
AuthorDate: Tue Jan 29 21:52:54 2019 +0100
Commit: Julien Nabet 
CommitDate: Tue Jan 29 23:08:12 2019 +0100

Removed executable permission on source file

Change-Id: I085a21afdf842a70dcdaaf9694fc6b09502985fe
Reviewed-on: https://gerrit.libreoffice.org/67096
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/svx/qa/unit/customshapes.cxx b/svx/qa/unit/customshapes.cxx
old mode 100755
new mode 100644
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 123045] FILEOPEN: Crash in: mergedlo.dll Opening MS .doc

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123045

--- Comment #1 from Steve Edmonds  ---
The crash report was submitted from Win10. Linux produces no crash report,
Writer just dies.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123045] FILEOPEN: Crash in: mergedlo.dll Opening MS .doc

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123045

Steve Edmonds  changed:

   What|Removed |Added

Summary|Crash in: mergedlo.dll  |FILEOPEN: Crash in:
   |Opening MS .doc |mergedlo.dll Opening MS
   ||.doc
 CC||st...@edmondsfamily.co.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123045] New: Crash in: mergedlo.dll Opening MS .doc

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123045

Bug ID: 123045
   Summary: Crash in: mergedlo.dll Opening MS .doc
   Product: LibreOffice
   Version: 6.1.2.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: st...@edmondsfamily.co.nz

Created attachment 148743
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148743=edit
Error and memory usage on Win. 10.

This bug was filed from the crash reporting server and is
br-8097e226-832d-46ab-9bd8-22c5f58212f6.
=

Opening a MS .doc causes huge memory use and Writer to crash. Document never
opens. Importing is very slow.

Occurs on 6.1.2.1 to 6.1.4.2 (tested)
Occurs on Win 10 and Opensuse Leap 42.3

Does not occur on 6.0.5.2, opening much faster on 6.0.5.2

Document (93MB) here
https://drive.google.com/file/d/1t1KUYvvNYs26SccTiUrnUoBmt1g_a5F4/view?usp=sharing

A similar document in docx opens ok.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123043] Type character detection on variable name should be Unicode-aware

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123043

--- Comment #3 from himajin100...@gmail.com ---
How idiot I was! I didn't notice that I've forgotten to attach the document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123043] Type character detection on variable name should be Unicode-aware

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123043

himajin100...@gmail.com changed:

   What|Removed |Added

 CC||himajin100...@gmail.com

--- Comment #2 from himajin100...@gmail.com ---
Created attachment 148742
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148742=edit
document to be used for STR

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 113553] FILESAVE: DOCX: space between footnote number and the content doubles after RT

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113553

Luke Munn  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---

--- Comment #14 from Luke Munn  ---
I can confirm that this is still occurring on 6.0.4.2. Namely, when saving from
ODT to DOCX, a tab is added before every single footnote. 

I imagine that, while new versions add more features, do bug fixes, etc, the
Import/Export Docx code doesn't get touched, which is why this has been an
issue, it seems, since 2015. 

As Milos noted, this is indeed a significant issue for academics wishing to use
LO. I use and advocate for FOSS, but others do use Word for tracking changes
and commenting. To keep having massive tabs appearing in my work, and my
supervisor to keep mentioning it, is a bit embarrassing. I really like LO in a
lot of ways, but this aspect is painful. 

Could this please be fixed?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 109195] [META] DOCX (OOXML) Footnote and Endnote bugs and enhancements

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109195
Bug 109195 depends on bug 113553, which changed state.

Bug 113553 Summary: FILESAVE: DOCX: space between footnote number and the 
content doubles after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=113553

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122752] gtk3_kde5/kde5: save file dialog doesn't add file extension and misses custom controls when using LXQt

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122752

--- Comment #18 from Michael Weghorn  ---
Sorry for my misleading comment 14. That was not meant as a command to be
executed "as is", but rather as a "human-readable instruction" that first had
to be converted into a "machine-readable command" like the one you used...

(In reply to Hans P. Möller from comment #17)
> So VCL=qt5 havs the checkbox but doesn't add the extension. Should I open a
> new bug?

Yes, that would be good. I think it makes sense to deal with these two things
separately.
(This behaviour matches my observations from comment 9.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sfx2/uiconfig

2019-01-29 Thread Libreoffice Gerrit user
 sfx2/uiconfig/ui/notebookbar.ui |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 070c1349e23a2d7c86f333b39c38b273aa8a0a11
Author: Caolán McNamara 
AuthorDate: Tue Jan 29 14:53:28 2019 +
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Jan 29 21:56:39 2019 +0100

Related: tdf#122977 widget claimed to be in wrong library

Change-Id: I635097e00e6b5d4f08badb1e99fa9b61b6b43856
Reviewed-on: https://gerrit.libreoffice.org/67085
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sfx2/uiconfig/ui/notebookbar.ui b/sfx2/uiconfig/ui/notebookbar.ui
index 3d192c007375..5c921496fe41 100644
--- a/sfx2/uiconfig/ui/notebookbar.ui
+++ b/sfx2/uiconfig/ui/notebookbar.ui
@@ -12,7 +12,7 @@
 False
 vertical
 
-  
+  
 True
 True
 True
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - solenv/flatpak-manifest.in

2019-01-29 Thread Libreoffice Gerrit user
 solenv/flatpak-manifest.in |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ed701cf97c1a26f938a6da6e6180e0b88431d487
Author: Stephan Bergmann 
AuthorDate: Tue Jan 29 15:18:32 2019 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Tue Jan 29 21:55:52 2019 +0100

Put back missing external/tarballs/ path in solenv/flatpak-manifest.in

...that accidentally got lost in 6584a5d9d1bb3e9b00e529358c989e8485071e36
"Upgrade libatomic_ops to latest libatomic_ops-7.6.8.tar.gz"

Change-Id: I79823428499efb951761c4d55eb16e154397ce60
Reviewed-on: https://gerrit.libreoffice.org/67081
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit 5543f99067a7aa1bc0a52fabe5bc693ec7d6fcbf)
Reviewed-on: https://gerrit.libreoffice.org/67094
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/solenv/flatpak-manifest.in b/solenv/flatpak-manifest.in
index 7aef2cd5e76c..d1cae8285ba0 100644
--- a/solenv/flatpak-manifest.in
+++ b/solenv/flatpak-manifest.in
@@ -545,7 +545,7 @@
 "url": 
"https://dev-www.libreoffice.org/src/libatomic_ops-7.6.8.tar.gz;,
 "sha256": 
"1d6a279edf81767e74d2ad2c9fce09459bc65f12c6525a40b0cb3e53c089f665",
 "type": "file",
-"dest-filename": "libatomic_ops-7.6.8.tar.gz"
+"dest-filename": 
"external/tarballs/libatomic_ops-7.6.8.tar.gz"
 },
 {
 "url": 
"https://dev-www.libreoffice.org/extern/49a64f3bcf20a7909ba2751349231d6652ded9cd2840e961b5164d09de3ffa63-opens___.ttf;,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 123026] LibreOffice ignore xlsxwriter 'text_wrap' formatting option, seems optimal height for row is not being set to hold cells with wrapped text

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123026

V Stuart Foote  changed:

   What|Removed |Added

 CC||bu...@bubli.org,
   ||vasily.melenc...@cib.de
   Keywords||needsDevEval
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=62
   ||268

--- Comment #4 from V Stuart Foote  ---
Correcting bug 62268 [1] looks to maintain performance by not recalculating
height of all rows, but just when parsing of ODF spreadsheets with row styling
"use-optimal-row-height" set true.

Guess that means for some externally generated XML, the XlsxWriter output here,
there is no style "use-optimal-row-height" being set in the import filter--so
the row height is locked at some default row height even though the text wrap
is enabled.

Can the import filter(s) be adjusted to set the use-optimal-row-height style on
rows when just the wrap text cell is encountered in a cell? That seems to be
the way Excel 2007+ consumed the XML--no row height.

Or, should handling output of the XlsxWriter generator be NOB? It does clear as
soon as we export to an ODF styled format, or modify the imported sheet.

=-ref-=

[1]https://gerrit.libreoffice.org/#/c/52521/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122752] gtk3_kde5/kde5: save file dialog doesn't add file extension and misses custom controls when using LXQt

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122752

--- Comment #17 from Hans P. Möller  ---
So VCL=qt5 havs the checkbox but doesn't add the extension. Should I open a new
bug?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122752] gtk3_kde5/kde5: save file dialog doesn't add file extension and misses custom controls when using LXQt

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122752

--- Comment #16 from Hans P. Möller  ---
> 
> Did you try this in lubuntu? it doesn't work in my case. I had to use export
> instead of set to change the envvar but it still launches with vcl=kde4

Nevermind, I could do it with
~$ SAL_USE_VCLPLUGIN=qt5 libreoffice6.2 --writer

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 94587] [META] ODF features missing or incorrectly imported

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=94587
Bug 94587 depends on bug 122964, which changed state.

Bug 122964 Summary: Multiple moveTo has to be treated as lineTo in 
draw:enhanced-path
https://bugs.documentfoundation.org/show_bug.cgi?id=122964

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122989] Update check item is available in Notebookbar Groupedbar without function if online update module is not installed

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122989

OfficeUser  changed:

   What|Removed |Added

   Severity|minor   |normal

--- Comment #8 from OfficeUser  ---
Like already stated, clicking "Check for Updates" without any message displayed
as result will very likely be interpreted as "Most recent version already
installed". So it is indirect security related.

--> Normal.


@Buovjaga please don't flood issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123044] Crash in: rptui::OReportController::createControl(com::sun::star::uno::Sequence const &, com::sun::star::uno::Reference

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123044

Bob W  changed:

   What|Removed |Added

Version|unspecified |6.1.3.2 release
   Hardware|All |x86-64 (AMD64)
 OS|All |Windows (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123044] New: Crash in: rptui::OReportController::createControl(com::sun::star::uno::Sequence const &, com::sun::star::uno::Reference

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123044

Bug ID: 123044
   Summary: Crash in:
rptui::OReportController::createControl(com::sun::star
::uno::Sequence
const
&,com::sun::star::uno::Reference const &,rtl::OUString const &,unsigned
short)
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: cyclingqua...@gmail.com

This bug was filed from the crash reporting server and is
br-e2600459-87c1-41b1-ba10-86ac2b2d4832.
=
Using Report Edit function attempted to insert label fields into Page Header
and Page Footer. Failed with immediate exit from LibreOffice Base and proceded
to restart with recovery. Recovery completed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123043] Type character detection on variable name should be Unicode-aware

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123043

--- Comment #1 from himajin100...@gmail.com ---
Honestly I don't know why the code is performing cSuffix check twice. Isn't
once enough?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 102187] [META] Options dialog bugs and enhancements

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102187
Bug 102187 depends on bug 122977, which changed state.

Bug 122977 Summary: CRASH: "Tools"->"Options" 
"LibreOfficeDev"->"Charts"->"Default Colors"
https://bugs.documentfoundation.org/show_bug.cgi?id=122977

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: 2 commits - loleaflet/css

2019-01-29 Thread Libreoffice Gerrit user
 loleaflet/css/loleaflet.css |  172 +++-
 1 file changed, 91 insertions(+), 81 deletions(-)

New commits:
commit fb924bf9316efe163dc63c58d1f2dc204da3a657
Author: Szymon Kłos 
AuthorDate: Tue Jan 29 20:51:16 2019 +0100
Commit: Szymon Kłos 
CommitDate: Tue Jan 29 21:15:01 2019 +0100

Unify whitespaces in loleaflet.css

Change-Id: I6d916acac8f6b7d4c71eab4fd63b5e13d61be4a1

diff --git a/loleaflet/css/loleaflet.css b/loleaflet/css/loleaflet.css
index d42c7c4e4..798612ca7 100644
--- a/loleaflet/css/loleaflet.css
+++ b/loleaflet/css/loleaflet.css
@@ -13,11 +13,11 @@
 }
 
 #document-container.readonly {
-top: 36px;
+   top: 36px;
 }
 
 #toolbar-wrapper.readonly {
-display: none;
+   display: none;
 }
 
 #map {
@@ -36,111 +36,112 @@
 }
 
 .loleaflet-scrollbar-show {
-opacity: 1 !important;
-filter: "alpha(opacity=100)" !important;
--ms-filter: "alpha(opacity=100)" !important;
+   opacity: 1 !important;
+   filter: "alpha(opacity=100)" !important;
+   -ms-filter: "alpha(opacity=100)" !important;
 }
 
 body {
-margin: 0;
-overflow: hidden;
-overscroll-behavior-y: none; /* disable the pull to reload gesture */
-background: #ff;
-touch-action: none;
+   margin: 0;
+   overflow: hidden;
+   overscroll-behavior-y: none; /* disable the pull to reload gesture */
+   background: #ff;
+   touch-action: none;
 }
 
 #presentation-controls-wrapper {
-background: #dfdfdf;
-position: absolute;
-top: 77px;
-left: 0px;
-bottom: 66px;
-max-width: 218px;
-border-top: 1px solid #b6b6b6;
-display: block;
+   background: #dfdfdf;
+   position: absolute;
+   top: 77px;
+   left: 0px;
+   bottom: 66px;
+   max-width: 218px;
+   border-top: 1px solid #b6b6b6;
+   display: block;
 }
 
 #presentation-controls-wrapper.drawing {
-bottom: 40px; /* Hide the presentation toolbar (insert slide etc.) for 
doctype = drawing */
+   bottom: 40px; /* Hide the presentation toolbar (insert slide etc.) for 
doctype = drawing */
 }
 
 #presentation-controls-wrapper.readonly {
-top: 36px;
+   top: 36px;
 }
 
 #toolbar-wrapper {
-position: relative;
-table-layout: fixed;
-border-collapse: collapse;
+   position: relative;
+   table-layout: fixed;
+   border-collapse: collapse;
width: 100%;
border-top: 1px solid #bb;
 }
 
 #toolbar-logo {
-width: 0;
+   width: 0;
 }
 
 #toolbar-hamburger {
-width: 0;
+   width: 0;
 }
 
 #mobile-edit-button {
-position: absolute;
-width: 56px;
-height: 56px;
-right: 16px;
-bottom: 16px;
-background-color: #0b87e7;
-border-radius: 50%;
-box-shadow: 0 4px 8px 0 rgba(0, 0, 0, 0.2), 0 6px 20px 0 rgba(0, 0, 0, 
0.19);
-z-index: 2000;
+   position: absolute;
+   width: 56px;
+   height: 56px;
+   right: 16px;
+   bottom: 16px;
+   background-color: #0b87e7;
+   border-radius: 50%;
+   box-shadow: 0 4px 8px 0 rgba(0, 0, 0, 0.2), 0 6px 20px 0 rgba(0, 0, 0, 
0.19);
+   z-index: 2000;
 }
 
 #mobile-edit-button-image {
-position: relative;
-left: 16px;
-top: 16px;
-width: 24px;
-height: 24px;
-background: url('images/baseline-edit-24px.svg') no-repeat center 
!important;
+   position: relative;
+   left: 16px;
+   top: 16px;
+   width: 24px;
+   height: 24px;
+   background: url('images/baseline-edit-24px.svg') no-repeat center 
!important;
 }
 
 @media (max-width: 767px),(max-device-height: 767px) {
-/* Show slidesorter beyond 768px only */
-#presentation-controls-wrapper {
+   /* Show slidesorter beyond 768px only */
+   #presentation-controls-wrapper {
display: none;
-}
+   }
 
-#document-container.tablet {
-top: 41px;
-}
+   #document-container.tablet {
+   top: 41px;
+   }
 
-#document-container.readonly {
-top: 41px;
-}
+   #document-container.readonly {
+   top: 41px;
+   }
 
-#document-container.parts-preview-document {
+   #document-container.parts-preview-document {
left: 0px !important;
-}
-#document-container.spreadsheet-document {
+   }
+   #document-container.spreadsheet-document {
top: 103px !important;
-}
-#document-container.spreadsheet-document.readonly {
+   }
+   #document-container.spreadsheet-document.readonly {
top: 61px !important;
-}
-#document-container {
+   }
+   #document-container {
top: 41px;
-}
-#spreadsheet-row-column-frame {
+
+   }
+   #spreadsheet-row-column-frame {
top: 83px !important;
-}
-#spreadsheet-row-column-frame.readonly {
+   }
+   #spreadsheet-row-column-frame.readonly {
top: 41px !important;
-}
-#toolbar-hamburger {
+   }
+   

[Libreoffice-bugs] [Bug 123043] New: Type character detection on variable name should be Unicode-aware

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123043

Bug ID: 123043
   Summary: Type character detection on variable name should be
Unicode-aware
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: himajin100...@gmail.com

Description:
see steps to reproduce

Steps to Reproduce:
1. Open the attached odt(Suffix.odt) file
2. Tools->Macros->Organize Macro->LibreOfficeDev Basic
3. Select Suffix.odt/Standard/Module1
4. Click Edit Button
5. You will find Sub Main(). This subroutine has one variable named "住所" 
,whose meaning is "address" in Japanese".

note: non-ascii character name is possible only when the code has "Option
VBASupport 1"

6. This variable name consists of two characters. U+4F4F and U+6240. 
Also, please note that '@' character, which is used for type character,is
U+0040

Type Characters
https://docs.microsoft.com/en-us/dotnet/visual-basic/programming-guide/language-features/data-types/type-characters

7. Select the variable name and Copy it. Then paste the name into "Watch:" in
the bottomside of the IDE and press Enter.

Actual Results:
Variable '住', not '住所', is registered as the watched variable.

Expected Results:
Variable '住所' is registered as the watched variable.


Reproducible: Always


User Profile Reset: No



Additional Info:
possible source code pointers:

https://opengrok.libreoffice.org/xref/core/basctl/source/basicide/baside2b.cxx?r=6256797d#90
https://opengrok.libreoffice.org/xref/core/basctl/source/basicide/baside2b.cxx?r=6256797d#161

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 13279b94080d87dde51bc8b8c669212bf71cacca
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-01-23_04:38:36
Locale: ja-JP (ja_JP); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: 2 commits - loleaflet/css

2019-01-29 Thread Libreoffice Gerrit user
 loleaflet/css/loleaflet.css |  189 ++--
 1 file changed, 81 insertions(+), 108 deletions(-)

New commits:
commit c38c5d2bf7e8cc7b4a2acda83e9b2cc5e9fa01de
Author: Szymon Kłos 
AuthorDate: Tue Jan 29 21:08:45 2019 +0100
Commit: Szymon Kłos 
CommitDate: Tue Jan 29 21:08:45 2019 +0100

Revert "Reduce readonly toolbar height"

This reverts commit d054da1e6bef02ac8cbbc7e430ba23e1637fc28c.

diff --git a/loleaflet/css/loleaflet.css b/loleaflet/css/loleaflet.css
index 2983bd724..fefaab466 100644
--- a/loleaflet/css/loleaflet.css
+++ b/loleaflet/css/loleaflet.css
@@ -9,21 +9,17 @@
 }
 
 #document-container.tablet {
-   top: 36px;
+   top: 41px;
 }
 
 #document-container.readonly {
-top: 36px;
+top: 41px;
 }
 
 #toolbar-wrapper.readonly {
 display: none;
 }
 
-#sidebar-dock-wrapper.tablet {
-   top: 36px;
-}
-
 #map {
position: absolute;
top: 0px;
@@ -69,7 +65,7 @@ body {
 }
 
 #presentation-controls-wrapper.readonly {
-top: 36px;
+top: 41px;
 }
 
 #toolbar-wrapper {
@@ -114,32 +110,6 @@ body {
 #presentation-controls-wrapper {
display: none;
 }
-<<< HEAD
-===
-
-/* Show sidebar beyond 768px only */
-#sidebar-dock-wrapper {
-   display: none;
-   top: 41px;
-}
-
-#document-container.tablet {
-top: 41px;
-}
-
-#document-container.readonly {
-top: 41px;
-}
-
-#sidebar-dock-wrapper.tablet {
-top: 41px;
-}
-
-#document-container.sidebar-document {
-   left: 0px !important;
-}
-
->>> c620fd91a... Reduce readonly toolbar height
 #document-container.parts-preview-document {
left: 0px !important;
 }
commit a29ae6cc595463fa74761361388a7874be6117f6
Author: Szymon Kłos 
AuthorDate: Tue Jan 29 21:08:32 2019 +0100
Commit: Szymon Kłos 
CommitDate: Tue Jan 29 21:08:32 2019 +0100

Revert "Unify whitespaces in loleaflet.css"

This reverts commit b858bf4ce752062919d3aa7b6ad85a4730fffa3f.

diff --git a/loleaflet/css/loleaflet.css b/loleaflet/css/loleaflet.css
index eac516f8a..2983bd724 100644
--- a/loleaflet/css/loleaflet.css
+++ b/loleaflet/css/loleaflet.css
@@ -13,11 +13,11 @@
 }
 
 #document-container.readonly {
-   top: 36px;
+top: 36px;
 }
 
 #toolbar-wrapper.readonly {
-   display: none;
+display: none;
 }
 
 #sidebar-dock-wrapper.tablet {
@@ -40,125 +40,128 @@
 }
 
 .loleaflet-scrollbar-show {
-   opacity: 1 !important;
-   filter: "alpha(opacity=100)" !important;
-   -ms-filter: "alpha(opacity=100)" !important;
+opacity: 1 !important;
+filter: "alpha(opacity=100)" !important;
+-ms-filter: "alpha(opacity=100)" !important;
 }
 
 body {
-   margin: 0;
-   overflow: hidden;
-   overscroll-behavior-y: none; /* disable the pull to reload gesture */
-   background: #ff;
-   touch-action: none;
+margin: 0;
+overflow: hidden;
+overscroll-behavior-y: none; /* disable the pull to reload gesture */
+background: #ff;
+touch-action: none;
 }
 
 #presentation-controls-wrapper {
-   background: #dfdfdf;
-   position: absolute;
-   top: 77px;
-   left: 0px;
-   bottom: 66px;
-   max-width: 218px;
-   border-top: 1px solid #b6b6b6;
-   display: block;
+background: #dfdfdf;
+position: absolute;
+top: 77px;
+left: 0px;
+bottom: 66px;
+max-width: 218px;
+border-top: 1px solid #b6b6b6;
+display: block;
 }
 
 #presentation-controls-wrapper.drawing {
-   bottom: 40px; /* Hide the presentation toolbar (insert slide etc.) for 
doctype = drawing */
+bottom: 40px; /* Hide the presentation toolbar (insert slide etc.) for 
doctype = drawing */
 }
 
 #presentation-controls-wrapper.readonly {
-   top: 36px;
+top: 36px;
 }
 
 #toolbar-wrapper {
-   position: relative;
-   table-layout: fixed;
-   border-collapse: collapse;
+position: relative;
+table-layout: fixed;
+border-collapse: collapse;
width: 100%;
border-top: 1px solid #bb;
 }
 
 #toolbar-logo {
-   width: 0;
+width: 0;
 }
 
 #toolbar-hamburger {
-   width: 0;
+width: 0;
 }
 
 #mobile-edit-button {
-   position: absolute;
-   width: 56px;
-   height: 56px;
-   right: 16px;
-   bottom: 16px;
-   background-color: #0b87e7;
-   border-radius: 50%;
-   box-shadow: 0 4px 8px 0 rgba(0, 0, 0, 0.2), 0 6px 20px 0 rgba(0, 0, 0, 
0.19);
-   z-index: 2000;
+position: absolute;
+width: 56px;
+height: 56px;
+right: 16px;
+bottom: 16px;
+background-color: #0b87e7;
+border-radius: 50%;
+box-shadow: 0 4px 8px 0 rgba(0, 0, 0, 0.2), 0 6px 20px 0 rgba(0, 0, 0, 
0.19);
+z-index: 2000;
 }
 
 #mobile-edit-button-image {
-   position: relative;
-   left: 16px;
-   top: 16px;
-   width: 24px;
-   height: 24px;
-   background: 

[Libreoffice-bugs] [Bug 122752] gtk3_kde5/kde5: save file dialog doesn't add file extension and misses custom controls when using LXQt

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122752

--- Comment #15 from Hans P. Möller  ---
(In reply to Michael Weghorn from comment #14)
> (In reply to Hans P. Möller from comment #13)
> > how can I change it to use the qt5 VCL? I thought there where only kde and
> > gtk
> 
> Set "SAL_USE_VCLPLUGIN=qt5". 
> 
> In fact, there's currently quite a bunch of VCL plugins on Linux (gtk, gtk3,
> kde4, kde5, gtk3_kde5, gen,...), some of them deprecated already (kde4 e.g.
> has already been removed from the current development version). Note
> however, that qt5 (which kde5 is based upon) and kde5 are only available
> from 6.2 on and currently still have several known issues... (s. meta bug
> 102495).

Did you try this in lubuntu? it doesn't work in my case. I had to use export
instead of set to change the envvar but it still launches with vcl=kde4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: 3 commits - loleaflet/css loleaflet/html loleaflet/src

2019-01-29 Thread Libreoffice Gerrit user
 loleaflet/css/loleaflet.css  |  189 ++-
 loleaflet/html/loleaflet.html.m4 |8 -
 loleaflet/src/map/Map.js |5 +
 3 files changed, 117 insertions(+), 85 deletions(-)

New commits:
commit b858bf4ce752062919d3aa7b6ad85a4730fffa3f
Author: Szymon Kłos 
AuthorDate: Tue Jan 29 20:51:16 2019 +0100
Commit: Szymon Kłos 
CommitDate: Tue Jan 29 21:03:51 2019 +0100

Unify whitespaces in loleaflet.css

Change-Id: I6d916acac8f6b7d4c71eab4fd63b5e13d61be4a1

diff --git a/loleaflet/css/loleaflet.css b/loleaflet/css/loleaflet.css
index 2983bd724..eac516f8a 100644
--- a/loleaflet/css/loleaflet.css
+++ b/loleaflet/css/loleaflet.css
@@ -13,11 +13,11 @@
 }
 
 #document-container.readonly {
-top: 36px;
+   top: 36px;
 }
 
 #toolbar-wrapper.readonly {
-display: none;
+   display: none;
 }
 
 #sidebar-dock-wrapper.tablet {
@@ -40,128 +40,125 @@
 }
 
 .loleaflet-scrollbar-show {
-opacity: 1 !important;
-filter: "alpha(opacity=100)" !important;
--ms-filter: "alpha(opacity=100)" !important;
+   opacity: 1 !important;
+   filter: "alpha(opacity=100)" !important;
+   -ms-filter: "alpha(opacity=100)" !important;
 }
 
 body {
-margin: 0;
-overflow: hidden;
-overscroll-behavior-y: none; /* disable the pull to reload gesture */
-background: #ff;
-touch-action: none;
+   margin: 0;
+   overflow: hidden;
+   overscroll-behavior-y: none; /* disable the pull to reload gesture */
+   background: #ff;
+   touch-action: none;
 }
 
 #presentation-controls-wrapper {
-background: #dfdfdf;
-position: absolute;
-top: 77px;
-left: 0px;
-bottom: 66px;
-max-width: 218px;
-border-top: 1px solid #b6b6b6;
-display: block;
+   background: #dfdfdf;
+   position: absolute;
+   top: 77px;
+   left: 0px;
+   bottom: 66px;
+   max-width: 218px;
+   border-top: 1px solid #b6b6b6;
+   display: block;
 }
 
 #presentation-controls-wrapper.drawing {
-bottom: 40px; /* Hide the presentation toolbar (insert slide etc.) for 
doctype = drawing */
+   bottom: 40px; /* Hide the presentation toolbar (insert slide etc.) for 
doctype = drawing */
 }
 
 #presentation-controls-wrapper.readonly {
-top: 36px;
+   top: 36px;
 }
 
 #toolbar-wrapper {
-position: relative;
-table-layout: fixed;
-border-collapse: collapse;
+   position: relative;
+   table-layout: fixed;
+   border-collapse: collapse;
width: 100%;
border-top: 1px solid #bb;
 }
 
 #toolbar-logo {
-width: 0;
+   width: 0;
 }
 
 #toolbar-hamburger {
-width: 0;
+   width: 0;
 }
 
 #mobile-edit-button {
-position: absolute;
-width: 56px;
-height: 56px;
-right: 16px;
-bottom: 16px;
-background-color: #0b87e7;
-border-radius: 50%;
-box-shadow: 0 4px 8px 0 rgba(0, 0, 0, 0.2), 0 6px 20px 0 rgba(0, 0, 0, 
0.19);
-z-index: 2000;
+   position: absolute;
+   width: 56px;
+   height: 56px;
+   right: 16px;
+   bottom: 16px;
+   background-color: #0b87e7;
+   border-radius: 50%;
+   box-shadow: 0 4px 8px 0 rgba(0, 0, 0, 0.2), 0 6px 20px 0 rgba(0, 0, 0, 
0.19);
+   z-index: 2000;
 }
 
 #mobile-edit-button-image {
-position: relative;
-left: 16px;
-top: 16px;
-width: 24px;
-height: 24px;
-background: url('images/baseline-edit-24px.svg') no-repeat center 
!important;
+   position: relative;
+   left: 16px;
+   top: 16px;
+   width: 24px;
+   height: 24px;
+   background: url('images/baseline-edit-24px.svg') no-repeat center 
!important;
 }
 
 @media (max-width: 767px),(max-device-height: 767px) {
-/* Show slidesorter beyond 768px only */
-#presentation-controls-wrapper {
+   /* Show slidesorter beyond 768px only */
+   #presentation-controls-wrapper {
display: none;
-}
-<<< HEAD
-===
+   }
 
-/* Show sidebar beyond 768px only */
-#sidebar-dock-wrapper {
+   /* Show sidebar beyond 768px only */
+   #sidebar-dock-wrapper {
display: none;
top: 41px;
-}
+   }
 
-#document-container.tablet {
-top: 41px;
-}
+   #document-container.tablet {
+   top: 41px;
+   }
 
-#document-container.readonly {
-top: 41px;
-}
+   #document-container.readonly {
+   top: 41px;
+   }
 
-#sidebar-dock-wrapper.tablet {
-top: 41px;
-}
+   #sidebar-dock-wrapper.tablet {
+   top: 41px;
+   }
 
-#document-container.sidebar-document {
+   #document-container.sidebar-document {
left: 0px !important;
-}
+   }
 
->>> c620fd91a... Reduce readonly toolbar height
-#document-container.parts-preview-document {
+   #document-container.parts-preview-document {
left: 0px !important;
-}
-#document-container.spreadsheet-document {
+  

[Libreoffice-commits] core.git: sw/qa sw/source

2019-01-29 Thread Libreoffice Gerrit user
 sw/qa/extras/uiwriter/uiwriter2.cxx   |  101 +++---
 sw/source/uibase/docvw/UnfloatTableButton.cxx |   23 +
 2 files changed, 83 insertions(+), 41 deletions(-)

New commits:
commit 70c29e50af8e16b864d1e5e5a74c30a1de8250de
Author: Tamás Zolnai 
AuthorDate: Tue Jan 29 19:05:56 2019 +0100
Commit: Tamás Zolnai 
CommitDate: Tue Jan 29 21:01:00 2019 +0100

Unfloat: Fix some issues with unfloat operation

- Use the correct method to remove the frame, so DOC
export will work correctly.
- Remove pagedesc attribute of the first text node if
the table is moved before it to avoid to generate a page
break.

Change-Id: I02802c4d25c947ec140b846c594848117815f1ce
Reviewed-on: https://gerrit.libreoffice.org/67093
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai 

diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx 
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index 93334ddc5027..6f56022e92ae 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -648,49 +648,70 @@ void SwUiWriterTest2::testUnfloatButtonReadOnlyMode()
 
 void SwUiWriterTest2::testUnfloating()
 {
-// Test what happens when pushing the unfloat button
-load(FLOATING_TABLE_DATA_DIRECTORY, "unfloatable_floating_table.odt");
-SwXTextDocument* pTextDoc = 
dynamic_cast(mxComponent.get());
-CPPUNIT_ASSERT(pTextDoc);
-SwWrtShell* pWrtShell = pTextDoc->GetDocShell()->GetWrtShell();
-CPPUNIT_ASSERT(pWrtShell);
-
-SwFlyFrame* pFlyFrame;
+// Test unfloating with tables imported from different file formats
+const std::vector aTestFiles = {
+"unfloatable_floating_table.odt",
+"unfloatable_floating_table.docx",
+"unfloatable_floating_table.doc",
+};
 
-// Before unfloating we have only one page with a fly frame
+for (const OUString& aTestFile : aTestFiles)
 {
-CPPUNIT_ASSERT_EQUAL(SwFrameType::Page, 
pWrtShell->GetLayout()->GetLower()->GetType());
-CPPUNIT_ASSERT(!pWrtShell->GetLayout()->GetLower()->GetNext());
-CPPUNIT_ASSERT_EQUAL(SwFrameType::Txt,
- 
pWrtShell->GetLayout()->GetLower()->GetLower()->GetLower()->GetType());
-const SwSortedObjs* pAnchored
-= 
pWrtShell->GetLayout()->GetLower()->GetLower()->GetLower()->GetDrawObjs();
-CPPUNIT_ASSERT(pAnchored);
-CPPUNIT_ASSERT_EQUAL(static_cast(1), pAnchored->size());
-SwAnchoredObject* pAnchoredObj = (*pAnchored)[0];
-pFlyFrame = dynamic_cast(pAnchoredObj);
-CPPUNIT_ASSERT(pFlyFrame);
-}
+OString sTestFileName = OUStringToOString(aTestFile, 
RTL_TEXTENCODING_UTF8);
+OString sFailureMessage = OString("Failure in the test file: ") + 
sTestFileName;
 
-// Select the floating table
-SdrObject* pObj = pFlyFrame->GetFormat()->FindRealSdrObject();
-CPPUNIT_ASSERT(pObj);
-pWrtShell->SelectObj(Point(), 0, pObj);
-CPPUNIT_ASSERT(pFlyFrame->IsShowUnfloatButton(pWrtShell));
-
-// Push the unfloat button
-pFlyFrame->ActiveUnfloatButton(pWrtShell);
-
-// After unfloating we have two pages with one table frame on each page
-CPPUNIT_ASSERT(pWrtShell->GetLayout()->GetLower()->GetNext());
-CPPUNIT_ASSERT_EQUAL(SwFrameType::Page,
- 
pWrtShell->GetLayout()->GetLower()->GetNext()->GetType());
-CPPUNIT_ASSERT(!pWrtShell->GetLayout()->GetLower()->GetNext()->GetNext());
-CPPUNIT_ASSERT_EQUAL(SwFrameType::Tab,
- 
pWrtShell->GetLayout()->GetLower()->GetLower()->GetLower()->GetType());
-CPPUNIT_ASSERT_EQUAL(
-SwFrameType::Tab,
-
pWrtShell->GetLayout()->GetLower()->GetNext()->GetLower()->GetLower()->GetType());
+// Test what happens when pushing the unfloat button
+load(FLOATING_TABLE_DATA_DIRECTORY, "unfloatable_floating_table.docx");
+SwXTextDocument* pTextDoc = 
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT_MESSAGE(sFailureMessage.getStr(), pTextDoc);
+SwWrtShell* pWrtShell = pTextDoc->GetDocShell()->GetWrtShell();
+CPPUNIT_ASSERT_MESSAGE(sFailureMessage.getStr(), pWrtShell);
+
+SwFlyFrame* pFlyFrame;
+
+// Before unfloating we have only one page with a fly frame
+{
+CPPUNIT_ASSERT_EQUAL_MESSAGE(sFailureMessage.getStr(), 
SwFrameType::Page,
+ 
pWrtShell->GetLayout()->GetLower()->GetType());
+CPPUNIT_ASSERT_MESSAGE(sFailureMessage.getStr(),
+   
!pWrtShell->GetLayout()->GetLower()->GetNext());
+CPPUNIT_ASSERT_EQUAL_MESSAGE(
+sFailureMessage.getStr(), SwFrameType::Txt,
+
pWrtShell->GetLayout()->GetLower()->GetLower()->GetLower()->GetType());
+const SwSortedObjs* pAnchored
+= 
pWrtShell->GetLayout()->GetLower()->GetLower()->GetLower()->GetDrawObjs();
+

[Libreoffice-ux-advise] [Bug 122950] Image -> Add Caption -> No description => Can't change caption instantly afterwards

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122950

Dieter Praas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 Blocks||114426
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

--- Comment #3 from Dieter Praas  ---
I confirm the behaviour with

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 411f3a050ac2be598019d512f8ccfe041080c28f
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-01-14_03:17:11
Locale: en-US (de_DE); UI-Language: en-US
Calc: threaded

Actual result:
If you have selcted the frame and
- click outside the frame => the cursor appears
- click within the image => the image is selected
- click once wihin the caption => nothing happens

Expected result:
One click within the caption => cursor should appear

I'm also unsecure, if this is a bug or an enhancement, so I add design team in
cc:


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114426
[Bug 114426] [META] Caption bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 122950] Image -> Add Caption -> No description => Can't change caption instantly afterwards

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122950

Dieter Praas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 Blocks||114426
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

--- Comment #3 from Dieter Praas  ---
I confirm the behaviour with

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 411f3a050ac2be598019d512f8ccfe041080c28f
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-01-14_03:17:11
Locale: en-US (de_DE); UI-Language: en-US
Calc: threaded

Actual result:
If you have selcted the frame and
- click outside the frame => the cursor appears
- click within the image => the image is selected
- click once wihin the caption => nothing happens

Expected result:
One click within the caption => cursor should appear

I'm also unsecure, if this is a bug or an enhancement, so I add design team in
cc:


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114426
[Bug 114426] [META] Caption bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 114426] [META] Caption bugs and enhancements

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114426

Dieter Praas  changed:

   What|Removed |Added

 Depends on||122950


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=122950
[Bug 122950] Image -> Add Caption -> No description => Can't change caption
instantly afterwards
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: cui/uiconfig sfx2/uiconfig

2019-01-29 Thread Libreoffice Gerrit user
 cui/uiconfig/ui/optchartcolorspage.ui |2 +-
 sfx2/uiconfig/ui/notebookbar.ui   |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 5d2dbcbd69a029d5f755111092df9d36ed1c1593
Author: Caolán McNamara 
AuthorDate: Tue Jan 29 14:53:28 2019 +
Commit: Caolán McNamara 
CommitDate: Tue Jan 29 20:51:23 2019 +0100

Resolves: tdf#122977 widget claimed to be in wrong library

Change-Id: I635097e00e6b5d4f08badb1e99fa9b61b6b43856
Reviewed-on: https://gerrit.libreoffice.org/67084
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/uiconfig/ui/optchartcolorspage.ui 
b/cui/uiconfig/ui/optchartcolorspage.ui
index 5e8debc83454..ee23c1cc7450 100644
--- a/cui/uiconfig/ui/optchartcolorspage.ui
+++ b/cui/uiconfig/ui/optchartcolorspage.ui
@@ -146,7 +146,7 @@
   
 
 
-  
+  
 True
 True
 True
diff --git a/sfx2/uiconfig/ui/notebookbar.ui b/sfx2/uiconfig/ui/notebookbar.ui
index 3d192c007375..5c921496fe41 100644
--- a/sfx2/uiconfig/ui/notebookbar.ui
+++ b/sfx2/uiconfig/ui/notebookbar.ui
@@ -12,7 +12,7 @@
 False
 vertical
 
-  
+  
 True
 True
 True
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83946
Bug 83946 depends on bug 52391, which changed state.

Bug 52391 Summary: EDITING: "Record/track changes": Rejected changes in 
character attributes are accepted instead of rejected
https://bugs.documentfoundation.org/show_bug.cgi?id=52391

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 52391] EDITING: "Record/track changes": Rejected changes in character attributes are accepted instead of rejected

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=52391

László Németh  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #9 from László Németh  ---
Rejected changes in character attributes aren't accepted any more, but the
recent rejection is still an approximation, using clearing direct formatting in
the area of the format-only tracked changes.

I close this issue, keeping Bug 58813 for the remaining problems.

Description of the previous commit:

tdf#52391 reject/clear formatting of format-only changes

Format-only changes had 1) disabled (in Manage Changes
dialog window) or 2) bad rejection (Track Changes toolbar
icons and Edit->Track Changes menu item functions
"Reject"/"Reject All" resulted acception of the tracked
format-only changes instead of rejection).

Because format-only changes haven't had real rejection
support, yet, this commit 1) adds an often useful
reject-like function in the Manage Changes dialog window:
instead of disabling Reject/Reject All, now these buttons
clears direct text formatting in the area of the tracked
format-only changes. Because this may be not a rejection
(ie. the original text can contain direct text formatting),
the labels of the button warn about it: "Reject/Clear
formatting" and "Reject All/Clear formatting".
Note: "Reject All" still rejects only
insertions/deletions at (now first) pressing,
as from commit a8a3928bd3614e52edc0a4df6f67ce53e787905c.

2) Icons and menu items "Reject"/"Reject All" clear
direct text formatting in the areas of the tracked
format-only changes. Note: this is still not ideal,
but it can help to avoid of unintended direct
text formatting until implementing upcoming ODF 1.3
change tracking.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123042] New: Right-click Delete All Comments crashes LibreOffice

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123042

Bug ID: 123042
   Summary: Right-click Delete All Comments crashes LibreOffice
   Product: LibreOffice
   Version: 6.0.7.3 release
  Hardware: All
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dkist...@gmail.com

Description:
With the cursor inside a comment, attempting to delete all commments in the
document results in the crash/recovery process. This happens with deleting all
comments by one individual or all comments in the document. It has repeated six
times in a row, so I think this is a bug. I was able to delete a single
comment. Once crashed, the Start Recovery window is buried behind all other
windows on the system.

Steps to Reproduce:
1.Place cursor on comment
2.Right-click, Delete All Comments (or Delete All Commments by User)
3.

Actual Results:
Repeated crashes requiring recovery of document.

Expected Results:
Software should have deleted all comments in the document as requested.


Reproducible: Always


User Profile Reset: Yes



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: solenv/flatpak-manifest.in

2019-01-29 Thread Libreoffice Gerrit user
 solenv/flatpak-manifest.in |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5543f99067a7aa1bc0a52fabe5bc693ec7d6fcbf
Author: Stephan Bergmann 
AuthorDate: Tue Jan 29 15:18:32 2019 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Jan 29 20:47:22 2019 +0100

Put back missing external/tarballs/ path in solenv/flatpak-manifest.in

...that accidentally got lost in 6584a5d9d1bb3e9b00e529358c989e8485071e36
"Upgrade libatomic_ops to latest libatomic_ops-7.6.8.tar.gz"

Change-Id: I79823428499efb951761c4d55eb16e154397ce60
Reviewed-on: https://gerrit.libreoffice.org/67081
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/solenv/flatpak-manifest.in b/solenv/flatpak-manifest.in
index 4582a79243fe..b5452fa1a285 100644
--- a/solenv/flatpak-manifest.in
+++ b/solenv/flatpak-manifest.in
@@ -556,7 +556,7 @@
 "url": 
"https://dev-www.libreoffice.org/src/libatomic_ops-7.6.8.tar.gz;,
 "sha256": 
"1d6a279edf81767e74d2ad2c9fce09459bc65f12c6525a40b0cb3e53c089f665",
 "type": "file",
-"dest-filename": "libatomic_ops-7.6.8.tar.gz"
+"dest-filename": 
"external/tarballs/libatomic_ops-7.6.8.tar.gz"
 },
 {
 "url": 
"https://dev-www.libreoffice.org/extern/49a64f3bcf20a7909ba2751349231d6652ded9cd2840e961b5164d09de3ffa63-opens___.ttf;,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 123022] AutoCorrect: Improve existing (German) abbreviations in AutoCorrect options (see comment 5)

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123022

Dieter Praas  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|UNCONFIRMED |RESOLVED

--- Comment #11 from Dieter Praas  ---
I opened bug 123041. I close this bug as RESOLVED WORKSFORME, because at least
in LO 6.3.0.0 it is possible to add abbreviatons with a space.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103341
Bug 103341 depends on bug 123022, which changed state.

Bug 123022 Summary: AutoCorrect: Improve existing (German) abbreviations in 
AutoCorrect options (see comment 5)
https://bugs.documentfoundation.org/show_bug.cgi?id=123022

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123022] AutoCorrect: Improve existing (German) abbreviations in AutoCorrect options (see comment 5)

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123022

Dieter Praas  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||3041

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 52391] EDITING: "Record/track changes": Rejected changes in character attributes are accepted instead of rejected

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=52391

--- Comment #8 from Commit Notification 
 ---
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/9c4eef7d809ad7d283860c7b47b0f561aa240906%5E%21

tdf#52391 reject/clear formatting of format-only changes

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123041] Autocorrect: Abbreviations with spaces are not considered within text

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123041

Dieter Praas  changed:

   What|Removed |Added

 Blocks||103341
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||3022


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103341
[Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103341

Dieter Praas  changed:

   What|Removed |Added

 Depends on||123041


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=123041
[Bug 123041] Autocorrect: Abbreviations with spaces are not considered within
text
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: include/svx svx/source svx/uiconfig sw/qa sw/source

2019-01-29 Thread Libreoffice Gerrit user
 include/svx/ctredlin.hxx  |3 +
 svx/source/dialog/ctredlin.cxx|   40 +++
 svx/uiconfig/ui/acceptrejectchangesdialog.ui  |5 ++
 sw/qa/extras/uiwriter/data2/tdf52391.fodt |   54 ++
 sw/qa/extras/uiwriter/uiwriter2.cxx   |   18 
 sw/source/core/doc/DocumentRedlineManager.cxx |   14 ++
 sw/source/uibase/misc/redlndlg.cxx|   21 ++
 7 files changed, 147 insertions(+), 8 deletions(-)

New commits:
commit 9c4eef7d809ad7d283860c7b47b0f561aa240906
Author: László Németh 
AuthorDate: Tue Jan 29 14:53:43 2019 +0100
Commit: László Németh 
CommitDate: Tue Jan 29 20:40:30 2019 +0100

tdf#52391 reject/clear formatting of format-only changes

Format-only changes had 1) disabled (in Manage Changes
dialog window) or 2) bad rejection (Track Changes toolbar
icons and Edit->Track Changes menu item functions
"Reject"/"Reject All" resulted acception of the tracked
format-only changes instead of rejection).

Because format-only changes haven't had real rejection
support, yet, this commit 1) adds an often useful
reject-like function in the Manage Changes dialog window:
instead of disabling Reject/Reject All, now these buttons
clears direct text formatting in the area of the tracked
format-only changes. Because this may be not a rejection
(ie. the original text can contain direct text formatting),
the labels of the button warn about it: "Reject/Clear
formatting" and "Reject All/Clear formatting".
Note: "Reject All" still rejects only
insertions/deletions at (now first) pressing,
as from commit a8a3928bd3614e52edc0a4df6f67ce53e787905c.

2) Icons and menu items "Reject"/"Reject All" clear
direct text formatting in the areas of the tracked
format-only changes. Note: this is still not ideal,
but it can help to avoid of unintended direct
text formatting until implementing upcoming ODF 1.3
change tracking.

Change-Id: I87c3ac6165019cae9c49ed4591eaadef9e06beb5
Reviewed-on: https://gerrit.libreoffice.org/67080
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/include/svx/ctredlin.hxx b/include/svx/ctredlin.hxx
index e83b9eec7e0c..7e2260b4f1c4 100644
--- a/include/svx/ctredlin.hxx
+++ b/include/svx/ctredlin.hxx
@@ -329,6 +329,9 @@ public:
 voidEnableAcceptAll(bool bFlag);
 voidEnableReject(bool bFlag);
 voidEnableRejectAll(bool bFlag);
+static void EnableClearFormatButton(VclPtr, bool bFlag);
+voidEnableClearFormat(bool bFlag);
+voidEnableClearFormatAll(bool bFlag);
 voidEnableUndo(bool bFlag=true);
 voidDisableUndo()   {EnableUndo(false);}
 voidShowUndo();
diff --git a/svx/source/dialog/ctredlin.cxx b/svx/source/dialog/ctredlin.cxx
index 188d7bc582e3..5e1aefc7f7c2 100644
--- a/svx/source/dialog/ctredlin.cxx
+++ b/svx/source/dialog/ctredlin.cxx
@@ -32,6 +32,8 @@
 
 #include 
 #include 
+#include 
+#include 
 
 #define WRITER_DATE 2
 #define CALC_DATE   3
@@ -371,6 +373,11 @@ SvxTPView::SvxTPView(vcl::Window *pParent, 
VclBuilderContainer *pTopLevel)
 pTopLevel->get(m_pRejectAll, "rejectall");
 pTopLevel->get(m_pUndo, "undo");
 
+// set wider window for the optional extending button labels
+// eg. "Reject/Clear formatting" instead of "Reject"
+EnableClearFormat(true);
+EnableClearFormatAll(true);
+
 SvSimpleTableContainer* pTable = get("changes");
 Size aControlSize(80, 65);
 aControlSize = LogicToPixel(aControlSize, MapMode(MapUnit::MapAppFont));
@@ -483,6 +490,39 @@ void SvxTPView::EnableRejectAll(bool bFlag)
 m_pRejectAll->Enable(bFlag);
 }
 
+void SvxTPView::EnableClearFormatButton(VclPtr pButton, bool bFlag)
+{
+OUString sText = pButton->GetText();
+OUString sClearFormat = SvxResId(RID_SVXSTR_CLEARFORM);
+sal_Int32 nPos = sText.indexOf(sClearFormat);
+
+// add or remove "Clear formatting" to get "Reject" or "Reject/Clear 
formatting"
+if (bFlag)
+{
+if (nPos == -1)
+{
+pButton->SetText(sText + "/" + sClearFormat);
+}
+}
+else
+{
+if (nPos > 0)
+{
+pButton->SetText(sText.copy(0, nPos - 1));
+}
+}
+}
+
+void SvxTPView::EnableClearFormat(bool bFlag)
+{
+EnableClearFormatButton( m_pReject, bFlag );
+}
+
+void SvxTPView::EnableClearFormatAll(bool bFlag)
+{
+EnableClearFormatButton( m_pRejectAll, bFlag );
+}
+
 void SvxTPView::ShowUndo()
 {
 m_pUndo->Show();
diff --git a/svx/uiconfig/ui/acceptrejectchangesdialog.ui 
b/svx/uiconfig/ui/acceptrejectchangesdialog.ui
index 0161bff86885..7e9817689a99 100644
--- a/svx/uiconfig/ui/acceptrejectchangesdialog.ui
+++ b/svx/uiconfig/ui/acceptrejectchangesdialog.ui
@@ -28,6 +28,7 @@
 False
 True

[Libreoffice-bugs] [Bug 123041] New: Autocorrect: Abbreviations with spaces are not considered within text

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123041

Bug ID: 123041
   Summary: Autocorrect: Abbreviations with spaces are not
considered within text
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dgp-m...@gmx.de

This bug is a follow up from bug 123022

Steps to reproduce:
1. Open document in writer
2. Tools => Autocorrect => Autocorrect Options => Tab Exceptions
3. In 6.3.0.0 it is now possible to add abbreviations with a space => add "z.
B." (abbreviation for German "Zum Beispiel" => NEW => OK.
4. Type a short Text like "z. B. ein"

Actual Result:
Text changes to "z. B. Ein"

Expected result:
No changes

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 411f3a050ac2be598019d512f8ccfe041080c28f
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-01-14_03:17:11
Locale: en-US (de_DE); UI-Language: en-US
Calc: threaded

Additional information: If I add an abbreviation like ggfls. and type a text,
it works.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - vcl/unx

2019-01-29 Thread Libreoffice Gerrit user
 vcl/unx/generic/printer/printerinfomanager.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 228dbf7ec113918bbd9e9616c5647410a824af5f
Author: Michael Stahl 
AuthorDate: Wed Jan 23 16:23:18 2019 +0100
Commit: Katarina Behrens 
CommitDate: Tue Jan 29 20:32:57 2019 +0100

vcl: unx: apply configuration to "Generic Printer" so it's PDF ...

... by default, instead of leaving it with
m_nPSLevel == 0 && m_nPDFDevice == 0.

Change-Id: I44059ac39791442602cbc48582670d98edc578ee
Reviewed-on: https://gerrit.libreoffice.org/66802
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit c8dd1c22d7512d4922461350c6cb804cd0864e0b)
Reviewed-on: https://gerrit.libreoffice.org/67064
Reviewed-by: Thorsten Behrens 
Reviewed-by: Katarina Behrens 

diff --git a/vcl/unx/generic/printer/printerinfomanager.cxx 
b/vcl/unx/generic/printer/printerinfomanager.cxx
index 35ac2902fc37..f3494b84c030 100644
--- a/vcl/unx/generic/printer/printerinfomanager.cxx
+++ b/vcl/unx/generic/printer/printerinfomanager.cxx
@@ -461,6 +461,9 @@ void PrinterInfoManager::initialize()
 
 setDefaultPaper( aPrinter.m_aInfo.m_aContext );
 
+// if it's a "Generic Printer", apply defaults from config...
+aPrinter.m_aInfo.resolveDefaultBackend();
+
 // finally insert printer
 FileBase::getFileURLFromSystemPath( aFile.PathToFileName(), 
aPrinter.m_aFile );
 aPrinter.m_bModified= false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: external/nss

2019-01-29 Thread Libreoffice Gerrit user
 external/nss/ExternalProject_nss.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 930ec0e6ab7bd5492fb4cf4a8f6860e3b728929d
Author: Julien Nabet 
AuthorDate: Tue Jan 29 18:32:54 2019 +0100
Commit: Miklos Vajna 
CommitDate: Tue Jan 29 20:27:38 2019 +0100

Disable NSS GTESTS also for Windows

Following 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=02623af4f5e0049ec5988df8ff6c7ff0f32f3fb1
See details here:

http://document-foundation-mail-archive.969070.n3.nabble.com/fatal-error-LNK1561-on-nss-Visual-Studio-2017-td4256601.html

Change-Id: I75f2c8a5409e484a8a5a12a6f12d5c20b244d2b2
Reviewed-on: https://gerrit.libreoffice.org/67092
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/external/nss/ExternalProject_nss.mk 
b/external/nss/ExternalProject_nss.mk
index ef807d503e58..211fa1d64437 100644
--- a/external/nss/ExternalProject_nss.mk
+++ b/external/nss/ExternalProject_nss.mk
@@ -25,6 +25,7 @@ $(call gb_ExternalProject_get_state_target,nss,build): $(call 
gb_ExternalExecuta
XCFLAGS="-arch:SSE $(SOLARINC)" \
$(MAKE) -j1 nss_build_all RC="rc.exe $(SOLARINC)" \
NSINSTALL='$(call 
gb_ExternalExecutable_get_command,python) $(SRCDIR)/external/nss/nsinstall.py' \
+   NSS_DISABLE_GTESTS=1 \
,nss)
 
 else # OS!=WNT
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/source vcl/source

2019-01-29 Thread Libreoffice Gerrit user
 sw/source/uibase/uno/unotxdoc.cxx |   26 --
 vcl/source/window/printdlg.cxx|   13 +
 2 files changed, 1 insertion(+), 38 deletions(-)

New commits:
commit eaec995a96b41963ae9e5156b6c5c7ac022f9a55
Author: Daniel 
AuthorDate: Wed Jan 16 18:51:47 2019 -0200
Commit: Michael Weghorn 
CommitDate: Tue Jan 29 20:25:48 2019 +0100

tdf#122079 - Document orientation is no longer changed in print dialog

Change-Id: I9d13cfd136f9b70674b3e43268525f8a6e1c0954
Reviewed-on: https://gerrit.libreoffice.org/66483
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 
Reviewed-by: Michael Weghorn 

diff --git a/sw/source/uibase/uno/unotxdoc.cxx 
b/sw/source/uibase/uno/unotxdoc.cxx
index c2f7f93b1935..24e360a76f90 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -2387,25 +2387,6 @@ static bool lcl_GetBoolProperty(
 return bRes;
 }
 
-static sal_Int32 lcl_GetIntProperty(
-const uno::Sequence< beans::PropertyValue >& rOptions,
-const sal_Char *pPropName,
-sal_Int32 nDefault )
-{
-sal_Int32 nRes = nDefault;
-const sal_Int32 nLen = rOptions.getLength();
-const beans::PropertyValue *pProps = rOptions.getConstArray();
-for ( sal_Int32 i = 0;  i < nLen;  ++i )
-{
-if ( pProps[i].Name.equalsAscii( pPropName ) )
-{
-pProps[i].Value >>= nRes;
-break;
-}
-}
-return nRes;
-}
-
 SfxViewShell * SwXTextDocument::GetRenderView(
 bool ,
 const uno::Sequence< beans::PropertyValue >& rOptions,
@@ -2599,13 +2580,6 @@ sal_Int32 SAL_CALL SwXTextDocument::getRendererCount(
 if (!pViewShell || !pViewShell->GetLayout())
 return 0;
 
-// make sure document orientation matches printer paper orientation
-sal_Int32 nLandscape = lcl_GetIntProperty( rxOptions, "IsLandscape", 
-1 );
-if ( nLandscape == 1 )
-pViewShell->ChgAllPageOrientation( Orientation::Landscape );
-else if ( nLandscape == 0 )
-pViewShell->ChgAllPageOrientation( Orientation::Portrait );
-
 if (bFormat)
 {
 // #i38289
diff --git a/vcl/source/window/printdlg.cxx b/vcl/source/window/printdlg.cxx
index 73d7b5b9a50f..e4a285e84575 100644
--- a/vcl/source/window/printdlg.cxx
+++ b/vcl/source/window/printdlg.cxx
@@ -1006,21 +1006,14 @@ void PrintDialog::preparePreview( bool i_bMayUseCache )
 
 void PrintDialog::updateOrientationBox( const bool bAutomatic )
 {
-Orientation eOrientation = maPController->getPrinter()->GetOrientation();
 if ( !bAutomatic )
 {
+Orientation eOrientation = 
maPController->getPrinter()->GetOrientation();
 mpOrientationBox->SelectEntryPos( static_cast(eOrientation) 
+ 1 );
-
-maPController->setValue( "IsLandscape",
- makeAny( static_cast(eOrientation) 
) );
 }
 else if ( hasOrientationChanged() )
 {
 mpOrientationBox->SelectEntryPos( ORIENTATION_AUTOMATIC );
-
-// used to make sure document orientation matches printer paper 
orientation
-maPController->setValue( "IsLandscape",
- makeAny( static_cast(eOrientation) 
) );
 }
 }
 
@@ -1061,10 +1054,6 @@ void PrintDialog::setPaperOrientation( Orientation 
eOrientation )
 Size& aPaperSize = maPController->getPaperSizeSetup();
 checkPaperSize( aPaperSize );
 }
-
-// used to sync printer paper orientation with document orientation
-maPController->setValue( "IsLandscape",
- makeAny( static_cast(eOrientation) ) );
 }
 
 void PrintDialog::checkControlDependencies()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 123037] Impress: Possibility of layout specific master pages

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123037

Regina Henschel  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||rb.hensc...@t-online.de

--- Comment #1 from Regina Henschel  ---
Can you please attach a PowerPoint presentation, which uses the features you
have described; if possible in pptx format?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/source

2019-01-29 Thread Libreoffice Gerrit user
 sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 77e2aba5a505762383b786c246754d51c9bcb1dc
Author: Szymon Kłos 
AuthorDate: Tue Jan 29 11:09:54 2019 +0100
Commit: Szymon Kłos 
CommitDate: Tue Jan 29 19:28:43 2019 +0100

Grab fous from child in spell dialog

Change-Id: I8c21623f7148ab2c05fe3d4198cf12231600f88d
Reviewed-on: https://gerrit.libreoffice.org/67077
Tested-by: Jenkins
Reviewed-by: Szymon Kłos 

diff --git a/sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx 
b/sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx
index 0f6725fc64e8..5dd83f837ea8 100644
--- a/sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx
+++ b/sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx
@@ -410,9 +410,10 @@ The code below would only be part of the solution.
 {
 LockFocusNotification( true );
 OUString sInfo( SwResId( STR_SPELLING_COMPLETED ) );
+vcl::Window* pThisWindow = GetWindow();
 // #i84610#
 std::unique_ptr xBox(
-Application::CreateMessageDialog( GetWindow()->GetFrameWeld(),
+Application::CreateMessageDialog( pThisWindow->GetFrameWeld(),
   VclMessageType::Info,
   VclButtonsType::Ok,
   sInfo ) );
@@ -420,6 +421,8 @@ The code below would only be part of the solution.
 LockFocusNotification( false );
 // take care that the now valid selection is stored
 LoseFocus();
+if( pThisWindow )
+pThisWindow->GrabFocus();
 }
 }
 return aRet;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 44266] Objects taken from the gallery do not align to the grid (objects should have an anchor point)

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=44266

--- Comment #21 from Thomes tout  ---
Very Helpful Information, I like it Very Much.. Thanks for this post
http://www.thedevicesupport.org/spectrum-customer-support;>spectrum
customer service number

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123039] UI Crash on inserting sheet from file

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123039

--- Comment #4 from Cor Nouws  ---
(In reply to Cor Nouws from comment #3)
> just corrupted user profile..
or information that should be proper, but makes LO crash anyway.
Anyway..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123039] UI Crash on inserting sheet from file

2019-01-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123039

Cor Nouws  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
   Keywords|bibisectRequest, regression |
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Cor Nouws  ---
ah shi..
just corrupted user profile..

thanks for testing, Raal!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: framework/source

2019-01-29 Thread Libreoffice Gerrit user
 framework/source/services/dispatchhelper.cxx |   24 +++-
 1 file changed, 23 insertions(+), 1 deletion(-)

New commits:
commit 22aa6508e0a65e65a6f9410b498fe4fd6c236639
Author: Miklos Vajna 
AuthorDate: Tue Jan 29 18:01:21 2019 +0100
Commit: Miklos Vajna 
CommitDate: Tue Jan 29 19:10:56 2019 +0100

framework: allow dispatching a command on the main thread

This is similar to commit 2dc3a6c273cb82506842864481d78df7294debbf
(framework: allow loading a component on the main thread, 2018-12-19),
just it allows saving (via .uno:Save) and other commands operating in a
similar environment.

The use-case is that once a document is loaded on the main thread (see
commit message of the above mentioned commit), then saving also has to
happen on the main thread, or OLE objects on Windows may be lost.

Change-Id: I7321659550b556e96085ac20f197a87d5d13f1ed
Reviewed-on: https://gerrit.libreoffice.org/67089
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/framework/source/services/dispatchhelper.cxx 
b/framework/source/services/dispatchhelper.cxx
index 3a1e6166197d..53a55d873249 100644
--- a/framework/source/services/dispatchhelper.cxx
+++ b/framework/source/services/dispatchhelper.cxx
@@ -26,6 +26,8 @@
 #include 
 
 #include 
+#include 
+#include 
 
 namespace framework{
 
@@ -47,6 +49,19 @@ DispatchHelper::DispatchHelper( const css::uno::Reference< 
css::uno::XComponentC
 {
 }
 
+/**
+ * Proxy around DispatchHelper::executeDispatch(), as
+ * vcl::solarthread::syncExecute() does not seem to accept lambdas.
+ */
+static css::uno::Any
+executeDispatchStatic(DispatchHelper* pThis,
+  const css::uno::Reference& 
xDispatch,
+  const css::util::URL& aURL, bool SyncronFlag,
+  const css::uno::Sequence& 
lArguments)
+{
+return pThis->executeDispatch(xDispatch, aURL, SyncronFlag, lArguments);
+}
+
 /** dtor.
 */
 DispatchHelper::~DispatchHelper()
@@ -103,7 +118,14 @@ css::uno::Any SAL_CALL DispatchHelper::executeDispatch(
 // search dispatcher
 css::uno::Reference< css::frame::XDispatch >  xDispatch   = 
xDispatchProvider->queryDispatch(aURL, sTargetFrameName, nSearchFlags);
 
-return executeDispatch(xDispatch, aURL, true, lArguments);
+utl::MediaDescriptor aDescriptor(lArguments);
+bool bOnMainThread = aDescriptor.getUnpackedValueOrDefault("OnMainThread", 
false);
+
+if (bOnMainThread)
+return vcl::solarthread::syncExecute(
+std::bind(, this, xDispatch, aURL, true, 
lArguments));
+else
+return executeDispatch(xDispatch, aURL, true, lArguments);
 }
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


  1   2   3   4   >