[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=10

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||90069


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=90069
[Bug 90069] DOCX: Font style table inconsistencies, new cells resetting font
styles
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 114501] Copy pasting from OpenOffice/LibreOffice to Thunderbird ruins formatting

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114501

--- Comment #8 from tbreport...@protonmail.com ---
Currently this is what is EXPORTED from LibreOffice:

Text here



Text here



Text here



Text here



Text here



Text here



Text
Text
Text
Text
End.



One solution would be to make LibreOffice export (and I presume then normal
CTRL+C and CTRL+V will work as desired) the above mentioned HTML like this:

Text here



Text here



Text here



Text here



Text here



Text here



Text
Text
Text
Text
End.


To reiterate, the problem with the current system seems to be:

1) Paragraphs have default margin-top value. The margin-top value should be
0cm!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 90026] OLE Object Toolbar

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90026

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||103239

--- Comment #5 from Roman Kuznetsov <79045_79...@mail.ru> ---
still repro in

Version: 6.1.4.2
Build ID: 1:6.1.4-0ubuntu0.18.10.1
CPU threads: 4; OS: Linux 4.18; UI render: default; VCL: gtk3_kde5; 
Locale: ru-RU (ru_RU.UTF-8); Calc: group threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103239
[Bug 103239] [META] Toolbars bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103239] [META] Toolbars bugs and enhancements

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103239

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||90026


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=90026
[Bug 90026] OLE Object Toolbar
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123020] Migration to Firebird db fails on "unknown token isc_dsql_prepare"

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123020

Julien Nabet  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr
   |desktop.org |

--- Comment #12 from Julien Nabet  ---
I submitted a patch on gerrit: https://gerrit.libreoffice.org/#/c/67259/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89472] Table background overriden by background image in header

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89472

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||103100


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103100

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||89472


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=89472
[Bug 89472] Table background overriden by background image in header
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89472] Table background overriden by background image in header

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89472

--- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> ---
still repro in

Version: 6.1.4.2
Build ID: 1:6.1.4-0ubuntu0.18.10.1
CPU threads: 4; OS: Linux 4.18; UI render: default; VCL: gtk3_kde5; 
Locale: ru-RU (ru_RU.UTF-8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123114] excess checkboxes in main menu Form with vcl:KDE

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123114

Katarina Behrens (CIB)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #3 from Katarina Behrens (CIB)  ---
Not a bug. Those menu items are toggles so it is correct that the checkboxes
are shown. 

Icon and checkbox can overlap in Windows native menus. Unfortunately this is
not how Linux (kde* and gtk*) native menus work. 

Go to Tools > Options > View > Icons in menus and set the value to 'Show' and
compare the behaviour of kde5 and gtk3 menus: you'll see both show checkbox and
icon side by side. Also other KDE application (kmail, kate etc.) display menus
in this way

So IDK, not a bug, or not our bug?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102495
Bug 102495 depends on bug 123114, which changed state.

Bug 123114 Summary: excess checkboxes in main menu Form with vcl:KDE
https://bugs.documentfoundation.org/show_bug.cgi?id=123114

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123117] New: Corrupt PDF output when exporting from LibreOffice Math

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123117

Bug ID: 123117
   Summary: Corrupt PDF output when exporting from LibreOffice
Math
   Product: LibreOffice
   Version: 6.1.4.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: qksw...@yahoo.com

Description:
It outputs a PDF with strange contents, not as it was supposed to be.

Steps to Reproduce:
1.Open LibreOffice Math
2.Write this: https://pastebin.com/Qe4eX3CR
3.Hit the button 'Export as PDF' at the top bar (next to the printer and paper
airplane icon).
4.See the result PDF.

Actual Results:
The PDF is strange. It does not seem like it is correct.

Expected Results:
What I have seen in LibreOffice Math screen.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.1.4.2
Build ID: 9d0f32d1f0b509096fd65e0d4bec26ddd1938fd3
CPU threads: 2; OS: Linux 3.16; UI render: GL; VCL: gtk2; 
Locale: en-US (en_US.utf8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 109323] [META] Graphic export bugs and enhancements (jpg, png, eps, tiff, gif ...)

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109323

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||89077


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=89077
[Bug 89077] Allow image export with "Selection" to limit to selected lines of
text
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89077] Allow image export with "Selection" to limit to selected lines of text

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89077

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||109323


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109323
[Bug 109323] [META] Graphic export bugs and enhancements (jpg, png, eps, tiff,
gif ...)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 114501] Copy pasting from OpenOffice/LibreOffice to Thunderbird ruins formatting

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114501

--- Comment #7 from tbreport...@protonmail.com ---
(In reply to tbreportbug from comment #6)
> And using find & replace does not work in LibreOffice. I tried to replaces
> all $ (new paragraph) with \n (new line break) but this does NOT replace
> those $ symbols, even though the tool CLAIMS that it changed many entries.

And even if I use this "trick"
(https://forum.openoffice.org/en/forum/viewtopic.php?f=20=67679#p301299):

START_QUOTE
Enter a line break normally and copy it to the clipboard

Edit > Find & Replace
Search for: $
Options/Regular expressions: ON
Click "Find All"

Edit > Paste
/END_QUOTE

to replace all $ signs, then all of my indentations and unordered list
formattings will be ruined in the process.

So using find & replace will not solve this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120169] LibreOffice dialog FileOpen opens with focus on path control and file type control doesn't take focus at all

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120169

Cor Nouws  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #7 from Cor Nouws  ---
and verified in the mean time in 63 master

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 120169] LibreOffice dialog FileOpen opens with focus on path control and file type control doesn't take focus at all

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120169

Cor Nouws  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #6 from Cor Nouws  ---
is ok in Versie: 6.2.0.3
Build ID: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62
CPU-threads: 4; Besturingssysteem: Linux 4.15; UI-render: standaard; VCL: gtk3; 
Locale: nl-NL (nl_NL.UTF-8); UI-taal: nl-NL
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 114501] Copy pasting from OpenOffice/LibreOffice to Thunderbird ruins formatting

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114501

--- Comment #6 from tbreport...@protonmail.com ---
And using find & replace does not work in LibreOffice. I tried to replaces all
$ (new paragraph) with \n (new line break) but this does NOT replace those $
symbols, even though the tool CLAIMS that it changed many entries.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 114501] Copy pasting from OpenOffice/LibreOffice to Thunderbird ruins formatting

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114501

tbreport...@protonmail.com changed:

   What|Removed |Added

 Resolution|NOTABUG |---
 Ever confirmed|0   |1
 Status|RESOLVED|REOPENED

--- Comment #5 from tbreport...@protonmail.com ---
(In reply to Buovjaga from comment #4)
> (In reply to tbreportbug from comment #2)
> > When you paste this text from LibreOffice into Thunderbird (or that
> > "midasdemo" website linked up there), you see that the formatting gets
> > ruined. In this case meaning that there is a lot more paragraph spacing
> > above and below each paragraph.
> 
> That's not the fault of LibreOffice, now is it?
> 
> If you look at the source of the Midas demo after pasting the stuff in, you
> see that inside every empty paragraph they have added a break element.
> Deleting these elements make for a sane line spacing.

The Midas demo does not add additional break elements. It is the LibreOffice
that is adding additional paragraph elements!

You can test this by going into LibreOffice, and then export (using Save As...)
the document as HTML. So exporting out you get this:

Text here



Text here



Text here



Text here



Text here



Text here



Text
Text
Text
Text
End.


But exporting SHOULD give something like this, to make it render properly in
Firefox and Thunderbird:

Text here

Text
here

Text here

Text here

Text
here

Text here

Text
Text
Text
Text
End.

The problem seems to be obviously with LibreOffice!

Can we now please get this fixed? This problem is completely ruining the usage
of Thunderbird!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123071] The font of a comment appears to be bold depening on zoomlevel for some comments

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123071

--- Comment #5 from Telesto  ---
In search for the cause.. Most likely cause: ClearType. It looks pretty decent
enabled. Bad disabled

Second question will be: is this a bug or not... or even a dupe of bug 103322

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 105876] FILEOPEN: DOCX with long floating table is not split over multiple pages (imported in a frame)

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105876

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
Summary|FILEOPEN: DOCX with long|FILEOPEN: DOCX with long
   |table is not split over |floating table is not split
   |multiple pages (missing |over multiple pages
   |page breaks)|(imported in a frame)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: Linker problems with system vs bundled libraries (RPATH vs RUNPATH)

2019-02-01 Thread Luboš Luňák
On Monday 28 of January 2019, Michael Stahl wrote:
> hope this will help:
>
> https://gerrit.libreoffice.org/#/c/67012/
>
> the idea is we use different symbol version for everything so LO libs
> call into bundled library, system libs call into system library.
>
> haven't tested it though, just make check runs fine here...


 Yes, that works. But before you do, could you please e.g. add URL of this 
discussion to the commit message? "unintended hilarity" is a rather poor 
problem description.

-- 
 Luboš Luňák
 l.lu...@collabora.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 122895] formatage conditionel

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122895

Oliver Brinzing  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #6 from Oliver Brinzing  ---
so setting this issue to resolved/notabug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 122895] formatage conditionel

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122895

--- Comment #5 from Oliver Brinzing  ---
OK, I seemed to have tested.
Without formatting in the collage, it does not modify the conditional
formatting.
False alert!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123116] Always allow table row to break across pages when longer than a page

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123116

Aron Budea  changed:

   What|Removed |Added

Summary|Always allow row to break   |Always allow table row to
   |across pages when longer|break across pages when
   |than a page |longer than a page

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123116] New: Always allow row to break across pages when longer than a page

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123116

Bug ID: 123116
   Summary: Always allow row to break across pages when longer
than a page
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ba...@caesar.elte.hu
Blocks: 107707

Created attachment 148852
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148852=edit
Sample ODT

Table rows have the following setting: Allow row to break across pages and
columns.

The setting is normally enabled, but when disabled, and when a table row is
taller than a page, the rest of the row becomes hidden, and falls of the page.
I can't find any reasonable explanation of this behavior, and suggest changing
it to always allow a row to break when it reaches full page length, regardless
of the setting.

Attaching a sample, it also includes a piece of text that gets hidden due to
the current behavior. Changing the behavior could lead to the layout of
existing files getting changed, though I can't imagine any files purposefully
having such a table (apart from hiding something).

The behavior also has interop aspects with MS Word:
- DOC files and DOCX files in compatibility mode behaves the same as Writer
does currently,
- DOCX files not in compatibility mode have the layout as proposed: the very
tall row starts on a new page, but is allowed to break further to the next
page.

Let's not deal with the interop part here, though. And frankly, I wouldn't care
if LO changed the behavior, and treated all files like that, unless there is a
compelling argument of possible side-effects.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107707
[Bug 107707] [META] Writer table enhancements requests
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 107707] [META] Writer table enhancements requests

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107707

Aron Budea  changed:

   What|Removed |Added

 Depends on||123116


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=123116
[Bug 123116] Always allow row to break across pages when longer than a page
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123071] The font of a comment appears to be bold depening on zoomlevel for some comments

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123071

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
   Priority|medium  |lowest
   Severity|normal  |trivial

--- Comment #4 from Dieter Praas  ---
I also can't confirm with

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 411f3a050ac2be598019d512f8ccfe041080c28f
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-01-14_03:17:11
Locale: en-US (de_DE); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123020] Migration to Firebird db fails on "unknown token isc_dsql_prepare"

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123020

--- Comment #11 from Julien Nabet  ---
(In reply to Julien Nabet from comment #10)
... 
> See
> https://opengrok.libreoffice.org/xref/core/dbaccess/source/filter/hsqldb/
> parseschema.cxx?r=3fb5f718#getIndexes

Rather
https://opengrok.libreoffice.org/xref/core/dbaccess/source/filter/hsqldb/parseschema.cxx?r=3fb5f718#getTableName

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123111] FILEOPEN | DOCX, Some text goes out of bound in textboxes in LO.

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123111

Telesto  changed:

   What|Removed |Added

Version|5.4.7.2 release |4.4.7.2 release

--- Comment #5 from Telesto  ---
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123110] FILEOPEN | DOCX, Text in shape changes color when opened in LO.

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123110

Telesto  changed:

   What|Removed |Added

Version|6.2.0.0.beta1+  |4.4.7.2 release

--- Comment #4 from Telesto  ---
Also in
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123020] Migration to Firebird db fails on "unknown token isc_dsql_prepare"

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123020

Julien Nabet  changed:

   What|Removed |Added

 OS|Windows (All)   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123020] Migration to Firebird db fails on "unknown token isc_dsql_prepare"

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123020

Julien Nabet  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |---
 Status|RESOLVED|NEW

--- Comment #10 from Julien Nabet  ---
Now that tdf#121469 has been fixed, let's recycle this tracker.
Indeed an empty error message appears and console indicates this:
warn:dbaccess:18254:18254:dbaccess/source/filter/hsqldb/hsqlimport.cxx:390:
Error during migration

Some debugging shows it's due to the fact that an index fails to be parsed
because it contains more that one word.
SET TABLE "Vald person i formul\u00e4r Konton" INDEX'110032 0'

See
https://opengrok.libreoffice.org/xref/core/dbaccess/source/filter/hsqldb/parseschema.cxx?r=3fb5f718#getIndexes

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: chart2/qa external/cppunit io/qa test/source

2019-02-01 Thread Libreoffice Gerrit user
 chart2/qa/extras/charttest.hxx  |1 
 external/cppunit/0001-Unconditionally-use-C-11-noreturn.patch.1 |   57 
++
 external/cppunit/UnpackedTarball_cppunit.mk |3 
 io/qa/textinputstream.cxx   |2 
 test/source/xmltesttools.cxx|3 
 5 files changed, 61 insertions(+), 5 deletions(-)

New commits:
commit 07d04fd3ae72dc1c9998f83a4131407ecc39cda9
Author: Stephan Bergmann 
AuthorDate: Fri Feb 1 14:17:42 2019 +0100
Commit: Stephan Bergmann 
CommitDate: Fri Feb 1 19:03:36 2019 +0100

Better fix for missing [[noreturn]] of CPPUNIT_FAIL

This includes a revert of commit 9808486a89c6368f836579f8d8c0dda63fd0063c 
"Avoid
-Werror,-Wimplicit-fallthrough with clang-cl", and also undoes older MSVC
workarounds (that would start to cause "warning C4702: unreachable code" 
now).

Change-Id: If72bf336e12e0a2db589857e8875003dae861977
Reviewed-on: https://gerrit.libreoffice.org/67248
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/chart2/qa/extras/charttest.hxx b/chart2/qa/extras/charttest.hxx
index a2b8efd2c427..84d74de2c117 100644
--- a/chart2/qa/extras/charttest.hxx
+++ b/chart2/qa/extras/charttest.hxx
@@ -340,7 +340,6 @@ Reference< chart2::data::XDataSequence > 
getLabelDataSequenceFromDoc(
 }
 
 CPPUNIT_FAIL("no Label sequence found");
-return Reference< chart2::data::XDataSequence > ();
 }
 
 Reference< chart2::data::XDataSequence > getDataSequenceFromDocByRole(
diff --git a/external/cppunit/0001-Unconditionally-use-C-11-noreturn.patch.1 
b/external/cppunit/0001-Unconditionally-use-C-11-noreturn.patch.1
new file mode 100644
index ..70ede229a3e6
--- /dev/null
+++ b/external/cppunit/0001-Unconditionally-use-C-11-noreturn.patch.1
@@ -0,0 +1,57 @@
+From c955b1041b9e3ebe7ee8a620340b78bddc820682 Mon Sep 17 00:00:00 2001
+From: Stephan Bergmann 
+Date: Fri, 1 Feb 2019 13:37:59 +0100
+Subject: [PATCH] Unconditionally use C++11 [[noreturn]]
+
+This helps avoid issues like  "Avoid
+-Werror,-Wimplicit-fallthrough with clang-cl ...where CPPUNIT_FAIL is marked as
+noreturn only for __GNUC__".
+
+Change-Id: Idb33af7375f103f2dd7a7b4c3dbf20ce731b17ad
+---
+ include/cppunit/Asserter.h | 12 +++-
+ 1 file changed, 3 insertions(+), 9 deletions(-)
+
+diff --git a/include/cppunit/Asserter.h b/include/cppunit/Asserter.h
+index 3321b87..dd39ead 100644
+--- a/include/cppunit/Asserter.h
 b/include/cppunit/Asserter.h
+@@ -43,23 +43,17 @@ class Message;
+  * \endcode
+  */
+ 
+-#if defined __GNUC__
+-#   define NORETURN __attribute__((noreturn))
+-#else
+-#   define NORETURN
+-#endif
+-
+ struct Asserter
+ {
+   /*! \brief Throws a Exception with the specified message and location.
+*/
+-  NORETURN static void CPPUNIT_API fail( const Message , 
++  [[noreturn]] static void CPPUNIT_API fail( const Message , 
+ const SourceLine  = SourceLine() );
+ 
+   /*! \brief Throws a Exception with the specified message and location.
+* \deprecated Use fail( Message, SourceLine ) instead.
+*/
+-  NORETURN static void CPPUNIT_API fail( std::string message, 
++  [[noreturn]] static void CPPUNIT_API fail( std::string message, 
+ const SourceLine  = SourceLine() );
+ 
+   /*! \brief Throws a Exception with the specified message and location.
+@@ -165,7 +159,7 @@ struct Asserter
+*  what are the differences between the expected 
and actual value.
+* \param shortDescription Short description for the failure message.
+*/
+-  NORETURN static void CPPUNIT_API failNotEqual( std::string expected, 
++  [[noreturn]] static void CPPUNIT_API failNotEqual( std::string expected, 
+ std::string actual, 
+ const SourceLine ,
+ const AdditionalMessage 
 = AdditionalMessage(),
+-- 
+2.20.1
+
diff --git a/external/cppunit/UnpackedTarball_cppunit.mk 
b/external/cppunit/UnpackedTarball_cppunit.mk
index 053a6020cd4f..649ba8fc4063 100644
--- a/external/cppunit/UnpackedTarball_cppunit.mk
+++ b/external/cppunit/UnpackedTarball_cppunit.mk
@@ -15,6 +15,8 @@ $(eval $(call 
gb_UnpackedTarball_update_autoconf_configs,cppunit))
 
 # gcc9.patch.0 addressed upstream with  
"Avoid GCC 9
 #  -Wdeprecated-copy":
+# 0001-Unconditionally-use-C-11-noreturn.patch.1 upstream at 

+#  "Unconditionally use C++11 [[noreturn]]"
 $(eval $(call gb_UnpackedTarball_add_patches,cppunit,\
external/cppunit/windows.patch \
external/cppunit/unix.patch \
@@ -22,6 +24,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,cppunit,\

[Libreoffice-bugs] [Bug 123115] KDE5: cannot paste table from Firefox into Calc

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123115

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
don't repro in

Version: 6.1.4.2
Build ID: 1:6.1.4-0ubuntu0.18.10.1
CPU threads: 4; OS: Linux 4.18; UI render: default; VCL: gtk3_kde5; 
Locale: ru-RU (ru_RU.UTF-8); Calc: group threaded

possible regression or implementation error

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: xmloff/source

2019-02-01 Thread Libreoffice Gerrit user
 xmloff/source/forms/elementimport.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ad972aad6ba94c5a8dd0fd1693efdd97a184e9e9
Author: Stephan Bergmann 
AuthorDate: Fri Feb 1 16:46:39 2019 +0100
Commit: Stephan Bergmann 
CommitDate: Fri Feb 1 19:04:33 2019 +0100

Use << instead of + in SAL_WARN_IF

Change-Id: Iedf02c89954458e762a1997ed1676a278570a00c
Reviewed-on: https://gerrit.libreoffice.org/67251
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/xmloff/source/forms/elementimport.cxx 
b/xmloff/source/forms/elementimport.cxx
index d0df9c2b604d..e234ce5cf132 100644
--- a/xmloff/source/forms/elementimport.cxx
+++ b/xmloff/source/forms/elementimport.cxx
@@ -889,7 +889,7 @@ namespace xmloff
 SAL_WARN_IF(
 _rPropValue.Name == PROPERTY_EFFECTIVE_VALUE
 ||  _rPropValue.Name == PROPERTY_EFFECTIVE_DEFAULT, "xmloff",
-"OControlImport::implTranslateValueProperty: invalid property 
type/name combination, Any and " + _rPropValue.Name);
+"OControlImport::implTranslateValueProperty: invalid property 
type/name combination, Any and " << _rPropValue.Name);
 
 // Both properties are allowed to have a double or a string value,
 // so first try to convert the string into a number
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 123095] Auto Filter Result is Wrong When Cell Value Contains Full-width and Half-width Characters

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123095

Durgapriyanka  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Durgapriyanka  ---
Thank you for reporting the bug. I confirm this bug in

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123115] KDE5: cannot paste table from Firefox into Calc

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123115

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   Keywords||implementationError,
   ||possibleRegression
 Blocks||102495


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
[Bug 102495] [META] KDE VCL backend bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123103] FILEOPEN | PPTX, Title changes from 3 lines to 2 lines in LO.

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123103

Durgapriyanka  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #3 from Durgapriyanka  ---
Thank you for reporting the bug. I confirm the bug in

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102495

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||123115


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=123115
[Bug 123115] KDE5: cannot paste table from Firefox into Calc
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: external/libgpg-error

2019-02-01 Thread Libreoffice Gerrit user
 external/libgpg-error/UnpackedTarball_libgpg-error.mk |2 ++
 external/libgpg-error/clang-cl.patch  |   11 +++
 2 files changed, 13 insertions(+)

New commits:
commit cd202a1cdb73fee4be460f07bb36154ee4e945f0
Author: Stephan Bergmann 
AuthorDate: Fri Feb 1 15:59:29 2019 +0100
Commit: Stephan Bergmann 
CommitDate: Fri Feb 1 19:03:50 2019 +0100

Missing extern in external/libgpg-error (clang-cl)

Change-Id: I31f2ae004dac16aee05b258984e50795db2582cc
Reviewed-on: https://gerrit.libreoffice.org/67250
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/external/libgpg-error/UnpackedTarball_libgpg-error.mk 
b/external/libgpg-error/UnpackedTarball_libgpg-error.mk
index 753f29716e2f..392bc26b640d 100644
--- a/external/libgpg-error/UnpackedTarball_libgpg-error.mk
+++ b/external/libgpg-error/UnpackedTarball_libgpg-error.mk
@@ -13,6 +13,8 @@ $(eval $(call 
gb_UnpackedTarball_set_tarball,libgpg-error,$(LIBGPGERROR_TARBALL)
 
 $(eval $(call gb_UnpackedTarball_set_patchlevel,libgpg-error,0))
 
+# clang-cl.patch src/gpgrt-int.h part upstream at 
 "Declaration of
+#  _gpgrt_functions_w32_pollable in src/gpgrt-int.h should be extern"
 $(eval $(call gb_UnpackedTarball_add_patches,libgpg-error, \
$(if $(filter MSC,$(COM)),external/libgpg-error/w32-build-fixes.patch) \
$(if $(filter 
MSC,$(COM)),external/libgpg-error/w32-build-fixes-2.patch.1) \
diff --git a/external/libgpg-error/clang-cl.patch 
b/external/libgpg-error/clang-cl.patch
index d98a948bdf59..ef1447fb61d9 100644
--- a/external/libgpg-error/clang-cl.patch
+++ b/external/libgpg-error/clang-cl.patch
@@ -9,3 +9,14 @@
  # define _GPG_ERR_GCC_VERSION (__GNUC__ * 1 \
 + __GNUC_MINOR__ * 100 \
 + __GNUC_PATCHLEVEL__)
+--- src/gpgrt-int.h
 src/gpgrt-int.h
+@@ -359,7 +359,7 @@
+ 
+ #if _WIN32
+ /* Prototypes for w32-estream.c.  */
+-struct cookie_io_functions_s _gpgrt_functions_w32_pollable;
++extern struct cookie_io_functions_s _gpgrt_functions_w32_pollable;
+ int _gpgrt_w32_pollable_create (void *_GPGRT__RESTRICT *_GPGRT__RESTRICT 
cookie,
+ unsigned int modeflags,
+ struct cookie_io_functions_s next_functions,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 123115] New: KDE5: cannot paste table from Firefox into Calc

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123115

Bug ID: 123115
   Summary: KDE5: cannot paste table from Firefox into Calc
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 79045_79...@mail.ru

Description:
follow from bug 122679

I tried copy in Firefox (Kubuntu 18.10) table with META on
https://wiki.documentfoundation.org/QA/Tracking_Bugs and paste it into Calc
(vcl:kde) and it happens nothing


Версия: 6.3.0.0.alpha0+
ID сборки: 51af3179cf972809d6495c7d58033e069f647bbf
Потоков ЦП: 4; ОС:Linux 4.18; Отрисовка ИП: по умолчанию; VCL: kde5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2019-02-01_00:15:00
Локаль: ru-RU (ru_RU.UTF-8); UI-Language: ru-RU
Calc: threaded

Steps to Reproduce:
1. Go to site https://wiki.documentfoundation.org/QA/Tracking_Bugs
2. Select Show >>>ALL<<< entries for table
3. Select all data in table and copy it
4. Open Calc
5. Select A1
6. Right click on cell and select Paste
7. It happens nothing

Actual Results:
It happens nothing after Paste

Expected Results:
Table from Firefox pasts into Calc spreadsheet


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123104] FILESAVE DOCX, Cell gets resized after saving in LO.

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123104

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
 Blocks||10


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=10
[Bug 10] [META] DOCX (OOXML) table-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=10

Dieter Praas  changed:

   What|Removed |Added

 Depends on||123104


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=123104
[Bug 123104] FILESAVE DOCX, Cell gets resized after saving in LO.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123104] FILESAVE DOCX, Cell gets resized after saving in LO.

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123104

Durgapriyanka  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #4 from Durgapriyanka  ---
Thank you for reporting the bug. I confirm the bug in

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123114] excess checkboxes in main menu Form with vcl:KDE

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123114

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||102495


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
[Bug 102495] [META] KDE VCL backend bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123114] New: excess checkboxes in main menu Form with vcl:KDE

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123114

Bug ID: 123114
   Summary: excess checkboxes in main menu Form with vcl:KDE
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 79045_79...@mail.ru

Description:
excess checkboxes in main menu Forms with vcl:KDE

see attaches

Steps to Reproduce:
1. Open Writer (use vcl:KDE)
2. Open Form menu
3.

Actual Results:
there are excess checkboxes in main menu Forms with vcl:KDE

Expected Results:
main menu Forms looks as in Windows (with icons and only needed checkboxes)


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123105] FILEOPEN | DOCX, Arrow changes its head color in LO.

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123105

Durgapriyanka  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #3 from Durgapriyanka  ---
Thank you for reporting the bug I confirm the bug in

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123106] FILESAVE | PPTX, Shape changes its color back to default.

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123106

Durgapriyanka  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #4 from Durgapriyanka  ---
Thank you for reporting the bug. I confirm the bug in

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102495

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||123114


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=123114
[Bug 123114] excess checkboxes in main menu Form with vcl:KDE
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123107] FILEOPEN | DOCX, Shape changes its fill color when opened in LO.

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123107

Durgapriyanka  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from Durgapriyanka  ---
Thank you for reporting the bug. I confirm the bug in

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123114] excess checkboxes in main menu Form with vcl:KDE

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123114

--- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> ---
Created attachment 148851
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148851=edit
Form menu in KDE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123114] excess checkboxes in main menu Form with vcl:KDE

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123114

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
Created attachment 148850
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148850=edit
Form menu in Windows

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123108] FILESAVE | XLSX, Shape changes color when saved in LO.

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123108

Durgapriyanka  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from Durgapriyanka  ---
Thank you for reporting the bug.I can confirm the bug in

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123110] FILEOPEN | DOCX, Text in shape changes color when opened in LO.

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123110

Durgapriyanka  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #3 from Durgapriyanka  ---
Thank you for reporting the bug. I confirm the bug in

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123101] FILESAVE PPTX Gradient backgrounds of slides are not preserved in PPTX format

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123101

--- Comment #4 from Durgapriyanka  ---
Thank you for reporting the bug.I cannot reproduce this bug. Gradient
backgrounds of slides are preserved even after saving as PPTX.

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: Temporarily yielding SolarMutex to another thread

2019-02-01 Thread Luboš Luňák
On Friday 01 of February 2019, Noel Grandin wrote:
> On Fri, 1 Feb 2019 at 17:11, Luboš Luňák  wrote:
> > - Calc threading - the Interpret() call may spawn several threads to
> > compute
>
> This case smells like this functionality should be using a different mutex
> instead of the SolarMutex, then the main thread could hold some kind of
> InterpretMutex, and the child threads could acquire and release the
> SolarMutex as necessary.

 That wouldn't work. As I said, the main thread cannot release SolarMutex at 
that point, since any other thread could acquire it there. And as long as the 
main thread cannot release SolarMutex, no other thread can acquire it, not 
even the child ones. And as long as the child threads cannot own SolarMutex, 
they cannot use all kinds of LO functionality that require it, not just Calc 
code, but anywhere.

> Perhaps the calling thread should pass both an operation and a
> std::function to the clipboard thread, which the clipboard thread can post
> back to the event thread once it's done - kind of a poor mans continuation.

 We have places locking SolarMutex all over the codebase. That'd be such a 
mess to do it from places that the child thread could possibly reach. Playing 
tricks with mutexes would be a nice clean approach compared to that.

> "freed too late" ? sounds like an ownership issue, not a threading issue?

 It's roughly like this: There's SdrModel and some SdrObject instances, which 
refer to the SdrModel. Some SdrObject may get added to clipboard contents. 
Later, when it all is about to get deleted, first all SdrObject instances get 
deleted from whatever may refer to it, which includes resetting clipboard 
contents to something that no longer refers to it. And when all that is done, 
SdrModel is destroyed too.

 Except, Windows clipboard handling decided it would be fun to delay resetting 
clipboard contents, and so one SdrObject actually gets destroyed only later, 
when the clipboard code finally gets to it. SdrObject dtor refers to the no 
longer existing SdrModel, *boom*.

 The way I see it, this is clearly a fault of the Windows clipboard code.

> I'm sure it is possible to get clever with mutexes, but I suspect you'd
> just be setting yourself up for bugs that are even harder to reason about.

 I disagree. Getting clever with mutexes indeed looks very wrong 
theoretically, but in practice it'd be a hack that'd be limited to a small 
scope. Assuming it doesn't deadlock (which should be easy to spot) and 
assuming it doesn't have a performance impact, what else can go wrong in 
practice?

-- 
 Luboš Luňák
 l.lu...@collabora.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 123079] Libreoffice leave tmp files in with new version

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123079

Mike Kaganski  changed:

   What|Removed |Added

 Ever confirmed|0   |1
Version|6.1.4.1 rc  |6.1.0.0.beta1+
 Status|UNCONFIRMED |NEW
 CC||michael.me...@collabora.com
   Keywords||bibisected, bisected,
   ||regression

--- Comment #3 from Mike Kaganski  ---
Reproducible.

Regression from
https://git.libreoffice.org/core/+/005abf983d34042a7ced46d886f8ef2250cb3fce

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123100] FILEOPEN XLS LibreOffice doesn't indicate the 256 column limitation of the format when editing XLS files

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123100

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #6 from Aron Budea  ---
There are plans to handle this with the column limit increase rework, see
(among the Tentative decisions):
https://lists.freedesktop.org/archives/libreoffice/2019-January/081909.html

(In reply to Gabor Kelemen from comment #5)
> Also note that this is displayed only on creating a new XLS file. 
> On editing an existing one there is not even this warning displayed.
This is worth opening a separate bug report on, does such a report exist? If
not, please create one.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: Temporarily yielding SolarMutex to another thread

2019-02-01 Thread Noel Grandin
On Fri, 1 Feb 2019 at 17:11, Luboš Luňák  wrote:

> - Calc threading - the Interpret() call may spawn several threads to
> compute
>

This case smells like this functionality should be using a different mutex
instead of the SolarMutex, then the main thread could hold some kind of
InterpretMutex, and the child threads could acquire and release the
SolarMutex as necessary.

Not ideal in terms of overhead, but less likelyhood of something going
wrong in the future.



> - Clipboard handling on Windows - I'm a bit hazy on the technical details,
> but
> if I'm getting it right, OLE requires all clipboard handling to be done by
> one thread, which our clipboard code does by creating a dedicated
> clipboard
> thread. Most clipboard operations ask the clipboard thread to do the job
> and
> block waiting for it,


Perhaps the calling thread should pass both an operation and a
std::function to the clipboard thread, which the clipboard thread can post
back to the event thread once it's done - kind of a poor mans continuation.

> but setting clipboard content is currently
> asynchronous, because decoding the set content requires SolarMutex, and
> again
> trying to acquire it from the clipboard thread would deadlock if the main
> thread holding it would block waiting for the clipboard thread. But the
> current situation with delayed handling can lead to previous clipboard
> contents freed too late, causing a crash.


"freed too late" ? sounds like an ownership issue, not a threading issue?

I'm sure it is possible to get clever with mutexes, but I suspect you'd
just be setting yourself up for bugs that are even harder to reason about.

>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] mso-dumper.git: pptx-kill-uuid.py

2019-02-01 Thread Libreoffice Gerrit user
 pptx-kill-uuid.py |   35 +++
 1 file changed, 35 insertions(+)

New commits:
commit f4faef33537d96307a198e09ccf1511cf74c7b62
Author: Miklos Vajna 
AuthorDate: Fri Feb 1 16:57:08 2019 +0100
Commit: Miklos Vajna 
CommitDate: Fri Feb 1 17:12:50 2019 +0100

pptx: add script that makes smartart uuids more readable

diff --git a/pptx-kill-uuid.py b/pptx-kill-uuid.py
new file mode 100755
index 000..c930ece
--- /dev/null
+++ b/pptx-kill-uuid.py
@@ -0,0 +1,35 @@
+#!/usr/bin/env python3
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+# PowerPoint generates SmartArt streams, like ppt/diagrams/data1.xml containing
+# UUIDs for each  element. This makes it hard to reason about them,
+# referring to numerical identifiers is just easier in notes. This script
+# replaces UUIDs with integers, which is the style used in the OOXML spec as
+# well.
+
+import re
+import sys
+
+
+def main():
+buf = sys.stdin.read()
+
+counter = 0
+while True:
+match = 
re.search("\{[0-9A-F]{8}-[0-9A-F]{4}-[0-9A-F]{4}-[0-9A-F]{4}-[0-9A-F]{12}\}", 
buf)
+if not match:
+break
+uuid = match.group()
+buf = buf.replace(uuid, str(counter))
+counter += 1
+
+sys.stdout.write(buf)
+
+
+if __name__ == "__main__":
+main()
+
+# vim:set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Temporarily yielding SolarMutex to another thread

2019-02-01 Thread Luboš Luňák

 Hello,

 does somebody know of a (solution) of a case when it would be useful to make 
another thread temporarily act if it held the SolarMutex? I've recently ran 
into 2 such cases:

- Calc threading - the Interpret() call may spawn several threads to compute 
in parallel a whole formula group. SolarMutex is still held by the main 
thread and the child threads generally try to avoid locking (it's ensured 
beforehand they will operate on distinct data). However, some functionality 
requires SolarMutex and those operations are currently blacklisted for 
threading, since this would deadlock. The main thread cannot release 
SolarMutex just like that in the middle of a computation, another independent 
thread could possibly access a state that's inconsistent at the moment. 
However, the main thread is blocked waiting for its child threads and so 
semantically all those threads "own" the SolarMutex, the child threads are 
there simply to use all CPU cores. I even remember seeing a piece of code 
which simply "silently" (with just a log warning) bails out if it can't 
acquire the SolarMutex.

- Clipboard handling on Windows - I'm a bit hazy on the technical details, but 
if I'm getting it right, OLE requires all clipboard handling to be done by 
one thread, which our clipboard code does by creating a dedicated clipboard 
thread. Most clipboard operations ask the clipboard thread to do the job and 
block waiting for it, but setting clipboard content is currently 
asynchronous, because decoding the set content requires SolarMutex, and again 
trying to acquire it from the clipboard thread would deadlock if the main 
thread holding it would block waiting for the clipboard thread. But the 
current situation with delayed handling can lead to previous clipboard 
contents freed too late, causing a crash. And again, this is really just one 
thread asking another one to do an operation, so again the clipboard thread 
could be semantically considered an owner of SolarMutex during such an 
operation.

 So, has somebody already handled a case like this? And is there a better way 
of handling this than adding some explicit ownership-yield operation to 
SolarMutex? It sounds a bit dirty to do something like that, but I can't 
think of anything better.

-- 
 Luboš Luňák
 l.lu...@collabora.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 123100] FILEOPEN XLS LibreOffice doesn't indicate the 256 column limitation of the format when editing XLS files

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123100

--- Comment #4 from Gabor Kelemen  ---
(In reply to V Stuart Foote from comment #3)
> We do not "open" XLS sheets--rather we import by filter, and saving back to
> XLS is an export filter.  Internally we "work" in 1024 columns.
> 

That's all nice and well, but still: if you open an XLS file, the default save
file name, metadata and format will be the same.

Which means you can add content in columns 256+, then on save get a humble
warning  about additional columns not being saved, and that's it.

If the user doesn't realize that this means data loss and close Calc, then they
are out of luck. 
One of ours was not exactly happy about this situation once he got into it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123100] FILEOPEN XLS LibreOffice doesn't indicate the 256 column limitation of the format when editing XLS files

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123100

--- Comment #5 from Gabor Kelemen  ---
Created attachment 148849
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148849=edit
I just ate your work. Are you okay with that?

Screenshot of data loss.
Also note that this is displayed only on creating a new XLS file. 
On editing an existing one there is not even this warning displayed.

Can't we really not hide this footgun from our users?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: xmloff/source

2019-02-01 Thread Libreoffice Gerrit user
 xmloff/source/forms/elementimport.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit c2d808a5ddf89ce40939d166e67dd0271852104f
Author: Noel Grandin 
AuthorDate: Thu Jan 31 17:04:26 2019 +0100
Commit: Noel Grandin 
CommitDate: Fri Feb 1 16:37:17 2019 +0100

fix incorrect OSL_ENSURE

broken in
commit 5e0b52c1893ffe04a68333026afa7a557c48d534
Date:   Thu May 17 14:51:04 2012 +0100
some more ConstAsciiString behind OSL_ENSURE

Also convert to SAL_WARN_IF, and make the error message more useful.

Change-Id: I7f1d0c577751e7309d5a0d544f38c5050b903a58
Reviewed-on: https://gerrit.libreoffice.org/67230
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/xmloff/source/forms/elementimport.cxx 
b/xmloff/source/forms/elementimport.cxx
index 16c24f1df352..d0df9c2b604d 100644
--- a/xmloff/source/forms/elementimport.cxx
+++ b/xmloff/source/forms/elementimport.cxx
@@ -886,10 +886,10 @@ namespace xmloff
 if (TypeClass_ANY == aProp.Type.getTypeClass())
 {
 // we have exactly 2 properties where this type class is allowed:
-OSL_ENSURE(
-_rPropValue.Name != PROPERTY_EFFECTIVE_VALUE
-&&  _rPropValue.Name != PROPERTY_EFFECTIVE_DEFAULT,
-"OControlImport::implTranslateValueProperty: invalid property 
type/name combination!");
+SAL_WARN_IF(
+_rPropValue.Name == PROPERTY_EFFECTIVE_VALUE
+||  _rPropValue.Name == PROPERTY_EFFECTIVE_DEFAULT, "xmloff",
+"OControlImport::implTranslateValueProperty: invalid property 
type/name combination, Any and " + _rPropValue.Name);
 
 // Both properties are allowed to have a double or a string value,
 // so first try to convert the string into a number
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/quartz

2019-02-01 Thread Libreoffice Gerrit user
 vcl/quartz/salgdi.cxx |3 ---
 1 file changed, 3 deletions(-)

New commits:
commit 3430192b9c9cc04f7aa46329c84b667f93c9ef39
Author: Noel Grandin 
AuthorDate: Thu Jan 31 16:49:40 2019 +0100
Commit: Noel Grandin 
CommitDate: Fri Feb 1 16:37:31 2019 +0100

remove unnecessary SAL_WARN

none of other backends warn about this

Change-Id: I9b7ceba413d15698a28806cbb35bd02ccc6e9585
Reviewed-on: https://gerrit.libreoffice.org/67229
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/vcl/quartz/salgdi.cxx b/vcl/quartz/salgdi.cxx
index 8a7a69890cd5..1331c229166e 100644
--- a/vcl/quartz/salgdi.cxx
+++ b/vcl/quartz/salgdi.cxx
@@ -425,10 +425,7 @@ void AquaSalGraphics::DrawTextLayout(const 
GenericSalLayout& rLayout)
 }
 
 if (aGlyphIds.empty())
-{
-SAL_WARN("vcl.quartz", "aGlyphIds is empty!?");
 return;
-}
 
 assert(aGlyphIds.size() == aGlyphPos.size());
 #if 0
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 97014] LibreOffice Online - Adding draw functions

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=97014

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #2 from Aron Budea  ---
This is mostly done now, with the exception of lines.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: include/vcl

2019-02-01 Thread Libreoffice Gerrit user
 include/vcl/errinf.hxx |6 --
 1 file changed, 6 deletions(-)

New commits:
commit b94eaae7a3e654b992ee7eea838245c57fea3017
Author: himajin10 
AuthorDate: Fri Feb 1 21:46:48 2019 +0900
Commit: Noel Grandin 
CommitDate: Fri Feb 1 16:33:17 2019 +0100

remove redundant typedef

Change-Id: I00cb289de0e75cb663f0a4fba0a9a5dc820e368b
Reviewed-on: https://gerrit.libreoffice.org/67246
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/vcl/errinf.hxx b/include/vcl/errinf.hxx
index e3d24ab0cc28..7d4f07207f46 100644
--- a/include/vcl/errinf.hxx
+++ b/include/vcl/errinf.hxx
@@ -97,12 +97,6 @@ namespace o3tl
 template<> struct typed_flags : is_typed_flags {};
 }
 
-typedef DialogMask WindowDisplayErrorFunc(
-weld::Window*, DialogMask nMask, const OUString , const OUString 
);
-
-typedef void BasicDisplayErrorFunc(
-const OUString , const OUString );
-
 class SAL_WARN_UNUSED VCL_DLLPUBLIC ErrorHandler
 {
 friend class ErrorStringFactory;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 123080] GTK3 VCL in 64-bit linux binary builds requires Wayland installation

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123080

--- Comment #2 from Yury  ---
I don't know how to answer the arguments of 'most distros' sort.
You could put a warning in the description at least, 'the default configuration
on linux requires Wayland-enabled GTK3'.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121338] Most transitions don't work.

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121338

--- Comment #6 from Ilsa  ---
I can confirm the same.  I have made a point to dabble with Impress every time
there is a new major release.

To date, OpenGL has *never* worked properly, going all the way back to when
LibreOffice came into existence.  I have tried using the OpenGL transitions
with every conceivable configuration of OS.  Various flavours of Windows, Mac
and Linux.

I have gotten the transitions working exactly once:  With the latest v6.1 (as a
Flatpak specifically, the default distro install doesn't work...), on Linux
Mint 19.1, using the Intel graphics driver.  When I tried using the nvidia
drivers (both proprietary and nouveau), the screen flickered badly during the
transition.  

I don't know where the problem lies, but it seems to me that the OGL
implementation in Impress is just hopelessly broken.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104442] [META] OOXML shape (DrawingML and VML) related issues

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104442

Dieter Praas  changed:

   What|Removed |Added

 Depends on|123111  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=123111
[Bug 123111] FILEOPEN | DOCX, Some text goes out of bound in textboxes in LO.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104449] [META] DOCX (OOXML) textbox-related issues

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104449

Dieter Praas  changed:

   What|Removed |Added

 Depends on||123111


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=123111
[Bug 123111] FILEOPEN | DOCX, Some text goes out of bound in textboxes in LO.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123111] FILEOPEN | DOCX, Some text goes out of bound in textboxes in LO.

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123111

Dieter Praas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
Summary|FILEOPEN | DOCX, Some text  |FILEOPEN | DOCX, Some text
   |goes out of bound in shapes |goes out of bound in
   |in LO.  |textboxes in LO.
 Blocks|104442  |104449
Version|6.2.0.0.beta1+  |5.4.7.2 release
 Ever confirmed|0   |1
 CC||dgp-m...@gmx.de

--- Comment #4 from Dieter Praas  ---
I confirm it with

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 411f3a050ac2be598019d512f8ccfe041080c28f
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-01-14_03:17:11
Locale: en-US (de_DE); UI-Language: en-US
Calc: threaded

and with

Version: 5.4.7.2 (x64)
Build-ID: c838ef25c16710f8838b1faec480ebba495259d0
CPU-Threads: 4; BS: Windows 6.19; UI-Render: GL; 
Gebietsschema: de-DE (de_DE); Calc: CL


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104442
[Bug 104442] [META] OOXML shape (DrawingML and VML) related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104449
[Bug 104449] [META] DOCX (OOXML) textbox-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 95228] FILEOPEN DOCX Textboxes overlap

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=95228

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de

--- Comment #5 from Dieter Praas  ---
Still present in 

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 411f3a050ac2be598019d512f8ccfe041080c28f
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-01-14_03:17:11
Locale: en-US (de_DE); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: dbaccess/source

2019-02-01 Thread Libreoffice Gerrit user
 dbaccess/source/filter/hsqldb/utils.cxx |   65 +---
 1 file changed, 43 insertions(+), 22 deletions(-)

New commits:
commit 6a736800ac87a6b23a90827aa7b431920a6b9a36
Author: Stephan Bergmann 
AuthorDate: Fri Feb 1 13:28:28 2019 +0100
Commit: Stephan Bergmann 
CommitDate: Fri Feb 1 16:03:23 2019 +0100

Fix conversion of non-BMP chars

...which are apparently encoded as two consecutive \u\u escape 
sequences
representing a UTF-16 surrogate pair

Change-Id: Ic47a678dee5e28ab4dc43e115ae5c4efefb1db96
Reviewed-on: https://gerrit.libreoffice.org/67245
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/dbaccess/source/filter/hsqldb/utils.cxx 
b/dbaccess/source/filter/hsqldb/utils.cxx
index dc869f51217b..fce71b6b6c57 100644
--- a/dbaccess/source/filter/hsqldb/utils.cxx
+++ b/dbaccess/source/filter/hsqldb/utils.cxx
@@ -30,24 +30,24 @@ using namespace dbahsql;
 
 namespace
 {
-//Find ascii escaped unicode
-sal_Int32 lcl_IndexOfUnicode(const OString& rSource, const sal_Int32 nFrom = 0)
+int getHexValue(sal_Unicode c)
 {
-const OString sHexDigits = "0123456789abcdefABCDEF";
-sal_Int32 nIndex = rSource.indexOf("\\u", nFrom);
-if (nIndex == -1)
+if (c >= '0' && c <= '9')
 {
-return -1;
+return c - '0';
 }
-bool bIsUnicode = true;
-for (short nDist = 2; nDist <= 5; ++nDist)
+else if (c >= 'A' && c <= 'F')
 {
-if (sHexDigits.indexOf(rSource[nIndex + nDist]) == -1)
-{
-bIsUnicode = false;
-}
+return c - 'A' + 10;
+}
+else if (c >= 'a' && c <= 'f')
+{
+return c - 'a' + 10;
+}
+else
+{
+return -1;
 }
-return bIsUnicode ? nIndex : -1;
 }
 
 } // unnamed namespace
@@ -55,17 +55,38 @@ sal_Int32 lcl_IndexOfUnicode(const OString& rSource, const 
sal_Int32 nFrom = 0)
 //Convert ascii escaped unicode to utf-8
 OUString utils::convertToUTF8(const OString& original)
 {
-OString sResult = original;
-sal_Int32 nIndex = lcl_IndexOfUnicode(sResult);
-while (nIndex != -1 && nIndex < original.getLength())
+OUString res = OStringToOUString(original, RTL_TEXTENCODING_UTF8);
+for (sal_Int32 i = 0;;)
 {
-const OString sHex = original.copy(nIndex + 2, 4);
-const sal_Unicode cDec = 
static_cast(strtol(sHex.getStr(), nullptr, 16));
-const OString sNewChar = OString(, 1, RTL_TEXTENCODING_UTF8);
-sResult = sResult.replaceAll("\\u" + sHex, sNewChar);
-nIndex = lcl_IndexOfUnicode(original, nIndex + 1);
+i = res.indexOf("\\u", i);
+if (i == -1)
+{
+break;
+}
+i += 2;
+if (res.getLength() - i >= 4)
+{
+bool escape = true;
+sal_Unicode c = 0;
+for (sal_Int32 j = 0; j != 4; ++j)
+{
+auto const n = getHexValue(res[i + j]);
+if (n == -1)
+{
+escape = false;
+break;
+}
+c = (c << 4) | n;
+}
+if (escape)
+{
+i -= 2;
+res = res.replaceAt(i, 6, OUString(c));
+++i;
+}
+}
 }
-return OStringToOUString(sResult, RTL_TEXTENCODING_UTF8);
+return res;
 }
 
 OUString utils::getTableNameFromStmt(const OUString& sSql)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 123109] RTF code - swapped \clpadl and \clpadt

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123109

--- Comment #3 from Julien Nabet  ---
(In reply to Miklos Vajna from comment #2)
> > // Top and left is swapped, that's what Word does.
> 
> Is the comment above the block, did you consider that?

Oups, I should open my eyes more widely! :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123113] type french date with field correctly (first day = "1ER")

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123113

christophe morand  changed:

   What|Removed |Added

Summary|type french date correctly  |type french date with field
   ||correctly (first day =
   ||"1ER")

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123113] New: type french date correctly

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123113

Bug ID: 123113
   Summary: type french date correctly
   Product: LibreOffice
   Version: 5.2.7.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: christophe.mor...@etat.ge.ch

Description:
It concerns date fields for the format "31 janvier 1999" (and also for
"vendredi 31 janvier 1999", maybe others). It works for all day in the month
but the first because in french, you don't say "le UN janvier" but le "le
PREMIER janvier". Therefore, it should NOT be written "1 janvier 1999"* BUT
"1er janvier 1999"["er" are smaller and higher character = "Exposant" in
french].
A small detail but it needs to be fixed to reach perfection
Pleas forward to the right team if not you
Thanks a lot for your work on this wonderful software

Actual Results:
1 février 2019 (date field with that format)

Expected Results:
1er février 2019 (with "ER" small and high ("Exposant" in french)


Reproducible: Always


User Profile Reset: No



Additional Info:
I wrote almost nothing because I honestly could put the thing in the summary,
please notice me briefly if I can do more

THX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123109] RTF code - swapped \clpadl and \clpadt

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123109

--- Comment #2 from Miklos Vajna  ---
> // Top and left is swapped, that's what Word does.

Is the comment above the block, did you consider that?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123100] FILEOPEN XLS LibreOffice doesn't indicate the 256 column limitation of the format when editing XLS files

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123100

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #3 from V Stuart Foote  ---
We do not "open" XLS sheets--rather we import by filter, and saving back to XLS
is an export filter.  Internally we "work" in 1024 columns.

Placing this restriction on format (and for bug 50916 ) we are working of
expanding our ODF support beyond 1024 columns. Which would deprecate any work
done for this.

IMHO => WF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123080] GTK3 VCL in 64-bit linux binary builds requires Wayland installation

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123080

Maxim Monastirsky  changed:

   What|Removed |Added

 CC||momonas...@gmail.com

--- Comment #1 from Maxim Monastirsky  ---
That's usually not a problem, as most distros do have Wayland-enabled gtk3
builds nowadays. And the gtk3 vclplug works fine with either X or Wayland, it
just that the system gtk3 lib needs to be compiled with the Wayland backend
turned on.

But what do you propose? Should we build our own gtk3 version with
--disable-wayland-backend, and compile/link against it? This will create
problems for users that do use Wayland, as anything inside #if
defined(GDK_WINDOWING_WAYLAND) will be left out of the binary. And using gtk3
under a Wayland session defaults to the Wayland backend, regardless of what
version was present on the build machine.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 123047] Editing: Table of Contents (TOC) contains lines with dots only - no line break at appropriate position in text line above

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123047

--- Comment #11 from Dieter Praas  ---
(In reply to Regina Henschel from comment #9)
> Manual changes will be lost on next update of the index.

That's true, but I think it is actual the only possibility to get a good
layout. Is it possible to have an option that "update index" only updates
headings and page numbers but not the style? I would prefer such a solution.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 123047] Editing: Table of Contents (TOC) contains lines with dots only - no line break at appropriate position in text line above

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123047

--- Comment #11 from Dieter Praas  ---
(In reply to Regina Henschel from comment #9)
> Manual changes will be lost on next update of the index.

That's true, but I think it is actual the only possibility to get a good
layout. Is it possible to have an option that "update index" only updates
headings and page numbers but not the style? I would prefer such a solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 115052] Allow other keys than from US keyboard as shortcut keys

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115052

dhinagh...@yahoo.fr changed:

   What|Removed |Added

Version|unspecified |6.1.4.2 release
 CC||dhinagh...@yahoo.fr
   Severity|enhancement |normal
 OS|All |Mac OS X (All)

--- Comment #14 from dhinagh...@yahoo.fr ---
I have the same "Cmd+`" issue with a french Keyboard on Mac 10.12.

It is very annoying when you are used to use this shortcut on all your
applications and that it does not work only on LibreOffice.

Also, this bug can be of high importance because when you have a selected
sentence (or paragraph or page...), doing "Cmd+`" will delete the text. As the
shortcut also change the window, you don't see that the text was deleted and
you can lose it.

Same thing on Spreadshit when you have selected a cell. Doing this short cut
will delete the cell content while shifting to the previous LibreOffice window
and then you don't realize the cell content was deleted.

Best,

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123047] Editing: Table of Contents (TOC) contains lines with dots only - no line break at appropriate position in text line above

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123047

--- Comment #10 from Heiko Tietze  ---
Neither linebreak nor a modified calculation seems to be a proper solution to
me. We have to modify the used styles and those have to work in other scenarios
as well (eg. applying to ordinary text).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 123047] Editing: Table of Contents (TOC) contains lines with dots only - no line break at appropriate position in text line above

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123047

--- Comment #10 from Heiko Tietze  ---
Neither linebreak nor a modified calculation seems to be a proper solution to
me. We have to modify the used styles and those have to work in other scenarios
as well (eg. applying to ordinary text).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 117115] Firebird: migration from HSQLDB does not respect language-specific characters

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117115

--- Comment #15 from Stephan Bergmann  ---
(In reply to Stephan Bergmann from comment #7)
> ...and a name using non-BMP chars like "" (U+1F4A9 PILE OF POO) is
> converted to something like "?" (the "in-transit" representation appears to
> be using an encoding of individual UTF-16 code units, "\ud83d\udca9", and
> the newly added lcl_ConvertToUTF8 tries to convert them back to UTF-8
> individually with
> 
>   const OString sNewChar = OString(, 1, RTL_TEXTENCODING_UTF8);
> 
> which doesn't work).

addressed now with  "Fix conversion of
non-BMP chars"


(In reply to Stephan Bergmann from comment #14)
> I assume the issue with table names has not yet been addressed (cf. bug
> 121469)?

apparently addressed with issue 121469 comment 11

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121241] MacOS: table borders aren't black but grayish ( zoom level < 150% )

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121241

--- Comment #14 from cpohle  ---
I can repoduce this (Version: 6.2.0.3, Build-ID:
98c6a8a1c6c7b144ce3cc729e34964b47ce25d62, CPU-Threads: 4; BS: Mac OS X 10.14.3;
UI-Render: GL; VCL: osx).

Table borders become visible at about 350 percent zoom level if anti-aliasing
is active. They look fine (and are usable) with anti-aliasing disabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] help.git: AllLangHelp_sbasic.mk source/text

2019-02-01 Thread Libreoffice Gerrit user
 AllLangHelp_sbasic.mk|1 
 source/text/sbasic/python/python_session.xhp |  160 +++
 2 files changed, 161 insertions(+)

New commits:
commit ae3c8a0a8a17b5cd3c427d7c62a4832631e18bb2
Author: Alain Romedenne 
AuthorDate: Thu Jan 31 14:51:22 2019 +0100
Commit: Olivier Hallot 
CommitDate: Fri Feb 1 13:25:59 2019 +0100

Add Help page for Python session

Change-Id: I01f1448176f5c95a5151bb3040e9c2ef53fcb7f1
Reviewed-on: https://gerrit.libreoffice.org/67214
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/AllLangHelp_sbasic.mk b/AllLangHelp_sbasic.mk
index e8c2c202f..81718f70e 100644
--- a/AllLangHelp_sbasic.mk
+++ b/AllLangHelp_sbasic.mk
@@ -375,6 +375,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,sbasic,\
 helpcontent2/source/text/sbasic/python/python_platform \
 helpcontent2/source/text/sbasic/python/python_programming \
 helpcontent2/source/text/sbasic/python/python_screen \
+helpcontent2/source/text/sbasic/python/python_session \
 helpcontent2/source/text/sbasic/python/python_shell \
 ))
 
diff --git a/source/text/sbasic/python/python_session.xhp 
b/source/text/sbasic/python/python_session.xhp
new file mode 100644
index 0..e6a49c91e
--- /dev/null
+++ b/source/text/sbasic/python/python_session.xhp
@@ -0,0 +1,160 @@
+
+
+
+
+
+Python_Session : Session 
class
+/text/sbasic/python/python_session.xhp
+
+
+
+
+Session;ComputerName
+Session;SharedScripts
+Session;SharedPythonScripts
+Session;UserProfile
+Session;UserScripts
+Session;UserPythonScripts
+
+Getting session information
+To compute %PRODUCTNAME user 
profile and shared modules system file paths can be performed with Python and 
with Basic language. BeanShell, Java, JavaScript and Python scripts locations 
can be derived from this information.
+Examples:
+With Python shell.
+ from the_module import 
Session
+ print(Session.SharedPythonScripts())  # class 
method
+ print(Session().UserName)  # object 
property
+ input(Session().UserProfile)  # object 
property
+From Tools – Macros - Run Macro... 
menu.
+
+from 
the_module import Session
+
+def 
demo_session():
+import 
screen_io as ui
+
ui.MsgBox(Session.Share(),title=Installation Share)  # class 
method
+
ui.Print(Session.SharedPythonScripts())  # class method
+s = Session() 
 # instance creation
+
ui.MsgBox(s.UserName,title=Hello)  # object property
+
ui.Print(s.UserPythonScripts)  # object property
+
+g_exportedScripts 
= demo_session,  # public macros
+
+With %PRODUCTNAME Basic.
+
+Sub 
Session_example()
+Dim s As New 
Session  instance of Platform class
+Print 
Shared scripts location:, s.SharedScripts
+MsgBox 
s.UserName,,Hello
+Print 
s.UserScripts, Chr(13), s.UserPythonScripts
+End Sub  
Session_example
+
+Using COM/OLE and Visual Basic Scripting language.
+
+ The 
service manager is always the entry point
+ If there 
is no office running then an office is started up
+Set sm = 
WScript.CreateObject(com.sun.star.ServiceManager)
+ 
PathSubstitution service exhibits information to infer
+ 
UserProfile|Share/Scripts/python locations from
+Set obj = 
sm.createInstance(com.sun.star.util.PathSubstitution)
+
+MsgBox 
CreateObject(WScript.Network).UserName,, 
Hello
+user = 
obj.getSubstituteVariableValue($(user))
+MsgBox user 
 /Scripts,, User scripts location
+libO = 
Replace(obj.getSubstituteVariableValue($(inst)), 
program/.., Share)
+MsgBox libO 
 /Scripts,, Shared scripts location
+
+Python Session class:
+
+import getpass, 
os, os.path, uno
+
+class 
Session():
+
@staticmethod
+def 
substitute(var_name):
+ctx = 
uno.getComponentContext()
+ps = 
ctx.getServiceManager().createInstanceWithContext(
+
com.sun.star.util.PathSubstitution, ctx)
+return 
ps.getSubstituteVariableValue(var_name)
+
@staticmethod
+def 
Share():
+inst = 
uno.fileUrlToSystemPath(Session.substitute($(prog)))
+return 
os.path.normpath(inst.replace(program, 
Share))
+
@staticmethod
+def 
SharedScripts():
+return 
.join([Session.Share(), os.sep, Scripts])
+
@staticmethod
+def 
SharedPythonScripts():
+return 
.join([Session.SharedScripts(), os.sep, 
python])
+@property  # 
alternative to $(username) variable
+def 
UserName(self): return getpass.getuser()
+
@property
+def 

[Libreoffice-bugs] [Bug 104442] [META] OOXML shape (DrawingML and VML) related issues

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104442
Bug 104442 depends on bug 123112, which changed state.

Bug 123112 Summary: FILEOPEN | DOCX, Some text goes out of bound in shapes in 
LO.
https://bugs.documentfoundation.org/show_bug.cgi?id=123112

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123112] FILEOPEN | DOCX, Some text goes out of bound in shapes in LO.

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123112

Dieter Praas  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||dgp-m...@gmx.de
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Dieter Praas  ---


*** This bug has been marked as a duplicate of bug 123111 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: helpcontent2

2019-02-01 Thread Libreoffice Gerrit user
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e9db8eceff48290be72591f7422b4fc45e5752fc
Author: Alain Romedenne 
AuthorDate: Thu Jan 31 14:51:22 2019 +0100
Commit: Gerrit Code Review 
CommitDate: Fri Feb 1 13:25:59 2019 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  - Add Help page for Python session

Change-Id: I01f1448176f5c95a5151bb3040e9c2ef53fcb7f1
Reviewed-on: https://gerrit.libreoffice.org/67214
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index c19fd80def3d..ae3c8a0a8a17 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit c19fd80def3d34e65302f13863aa8aeb88e2de42
+Subproject commit ae3c8a0a8a17b5cd3c427d7c62a4832631e18bb2
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 123111] FILEOPEN | DOCX, Some text goes out of bound in shapes in LO.

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123111

--- Comment #3 from Dieter Praas  ---
*** Bug 123112 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/source

2019-02-01 Thread Libreoffice Gerrit user
 sw/source/uibase/uiview/view2.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 854dc05d285d4bd5c91bada839f282d1d03dbb52
Author: Stephan Bergmann 
AuthorDate: Fri Feb 1 11:47:20 2019 +0100
Commit: Stephan Bergmann 
CommitDate: Fri Feb 1 13:18:43 2019 +0100

One more "Don't add snap point < MINZOOM"

...similar to a89f535d85bb7d32ccb5196813ba6233f45c0c83 "Don't add snap 
point <
MINZOOM", this time triggered during CppunitTest_smoketest

Change-Id: Ibee45c7b1ac9b29c7c4757bbdafd909076bcb058
Reviewed-on: https://gerrit.libreoffice.org/67243
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sw/source/uibase/uiview/view2.cxx 
b/sw/source/uibase/uiview/view2.cxx
index 63cd87a68867..11ba7904f18d 100644
--- a/sw/source/uibase/uiview/view2.cxx
+++ b/sw/source/uibase/uiview/view2.cxx
@@ -1458,7 +1458,10 @@ void SwView::StateStatusLine(SfxItemSet )
 nTmpWidth += aPageSize.Width() + 
pVOpt->GetGapBetweenPages();
 nFac = aWindowSize.Width() * 100 / nTmpWidth;
 nFac = std::min( nFac, nVisPercent );
-aZoomSliderItem.AddSnappingPoint( nFac );
+if (nFac >= MINZOOM)
+{
+aZoomSliderItem.AddSnappingPoint( nFac );
+}
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: test/source

2019-02-01 Thread Libreoffice Gerrit user
 test/source/xmltesttools.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 9808486a89c6368f836579f8d8c0dda63fd0063c
Author: Stephan Bergmann 
AuthorDate: Fri Feb 1 12:01:58 2019 +0100
Commit: Stephan Bergmann 
CommitDate: Fri Feb 1 13:12:57 2019 +0100

Avoid -Werror,-Wimplicit-fallthrough with clang-cl

...where CPPUNIT_FAIL is marked as noreturn only for __GNUC__

Change-Id: Id820b00d8dfe1218a10cd586d32cc20eb6a003de
Reviewed-on: https://gerrit.libreoffice.org/67244
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/test/source/xmltesttools.cxx b/test/source/xmltesttools.cxx
index 00d156c40ecf..b104599f4b9d 100644
--- a/test/source/xmltesttools.cxx
+++ b/test/source/xmltesttools.cxx
@@ -11,6 +11,7 @@
 
 #include 
 
+#include 
 #include 
 
 namespace {
@@ -96,6 +97,7 @@ OUString XmlTestTools::getXPathContent(xmlDocPtr pXmlDoc, 
const OString& rXPath)
 {
 case XPATH_UNDEFINED:
 CPPUNIT_FAIL("Undefined XPath type");
+O3TL_UNREACHABLE;
 case XPATH_NODESET:
 {
 xmlNodeSetPtr pXmlNodes = pXmlObj->nodesetval;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving the special configuration of SQLITE 3 ODBC

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121092

jorojma...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #12 from jorojma...@gmail.com ---
Libreoffice should take into account the SQLITE ODBC database since it is a
very interesting database as a second option after Firebird

here are many people who use SQLITE, a standardized database.


Thanks for the effort

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - officecfg/registry

2019-02-01 Thread Libreoffice Gerrit user
 officecfg/registry/data/org/openoffice/Office/ProtocolHandler.xcu |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1f4ef067619044e3ea05c421590109074dbf62b8
Author: Stephan Bergmann 
AuthorDate: Thu Jan 31 16:16:56 2019 +0100
Commit: Michael Stahl 
CommitDate: Fri Feb 1 12:57:54 2019 +0100

tdf#121780: com.sun.star.comp.sfx2.BackingComp needs to be registered always

...instead of never (as there is no handling of
org/openoffice/Office/ProtocolHandler-start.xcu in
officecfg/Configuration_officecfg.mk).  That install:module="start" 
included in
d930cefbe65d8b7f21100fcbf2ddcd977dd15cb1 "Startcenter: Refresh 
RecentDocsView
when select 'Clear list' menu option" was probably misguided 
cargo-cult-copying
from (meaningful) install:module="impress" that were already present in
officecfg/registry/data/org/openoffice/Office/ProtocolHandler.xcu.

Change-Id: I03ed0cf84b576597a7b88ee6627a12cedbca4960
Reviewed-on: https://gerrit.libreoffice.org/67224
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit dbc92eab4d1e11fcb1588d80cb118951a180e808)
Reviewed-on: https://gerrit.libreoffice.org/67238
Reviewed-by: Michael Stahl 

diff --git a/officecfg/registry/data/org/openoffice/Office/ProtocolHandler.xcu 
b/officecfg/registry/data/org/openoffice/Office/ProtocolHandler.xcu
index 62f7566875e6..3e64280d514c 100644
--- a/officecfg/registry/data/org/openoffice/Office/ProtocolHandler.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/ProtocolHandler.xcu
@@ -70,7 +70,7 @@
 vnd.com.sun.star.comp.PresentationMinimizer:*
   
 
-
+
   
 vnd.org.libreoffice.recentdocs:*
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: vcl/inc vcl/win

2019-02-01 Thread Libreoffice Gerrit user
 vcl/inc/win/salvd.h   |3 +-
 vcl/win/gdi/salvd.cxx |   55 +++---
 2 files changed, 28 insertions(+), 30 deletions(-)

New commits:
commit cd520894e7092349f1a7aad07066376bb28571fc
Author: Dmitriy Shilin 
AuthorDate: Sun Jan 20 01:24:02 2019 -0800
Commit: Mike Kaganski 
CommitDate: Fri Feb 1 12:45:38 2019 +0100

tdf#107792 vcl/win: use ScopedGDI in WinSalVirtualDevice

Change-Id: Ia804f4ab527870ded8d57aa0d49aae1d357b7ac9
Reviewed-on: https://gerrit.libreoffice.org/66649
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/vcl/inc/win/salvd.h b/vcl/inc/win/salvd.h
index f4825836036e..4121d2c89979 100644
--- a/vcl/inc/win/salvd.h
+++ b/vcl/inc/win/salvd.h
@@ -21,6 +21,7 @@
 #define INCLUDED_VCL_INC_WIN_SALVD_H
 
 #include 
+#include 
 
 #include 
 
@@ -33,7 +34,7 @@ class WinSalVirtualDevice : public SalVirtualDevice
 {
 private:
 HDC mhLocalDC;  // HDC or 0 for Cache 
Device
-HBITMAP mhBmp;  // Memory Bitmap
+ScopedHBITMAP   mhBmp;  // Memory Bitmap
 HBITMAP mhDefBmp;   // Default Bitmap
 std::unique_ptr mpGraphics; // current VirDev graphics
 WinSalVirtualDevice*mpNext; // next VirDev
diff --git a/vcl/win/gdi/salvd.cxx b/vcl/win/gdi/salvd.cxx
index f0cf1fc9f47b..6dc94f0b12a2 100644
--- a/vcl/win/gdi/salvd.cxx
+++ b/vcl/win/gdi/salvd.cxx
@@ -30,6 +30,7 @@
 #include 
 #include 
 #include 
+#include 
 
 HBITMAP WinSalVirtualDevice::ImplCreateVirDevBitmap(HDC hDC, long nDX, long 
nDY, sal_uInt16 nBitCount, void **ppData)
 {
@@ -184,8 +185,8 @@ WinSalVirtualDevice::~WinSalVirtualDevice()
 SelectBitmap( mpGraphics->getHDC(), mhDefBmp );
 if( !mbForeignDC )
 DeleteDC( mpGraphics->getHDC() );
-if( mhBmp )
-DeleteBitmap( mhBmp );
+
+mhBmp.reset();
 mpGraphics.reset();
 }
 
@@ -209,35 +210,31 @@ bool WinSalVirtualDevice::SetSize( long nDX, long nDY )
 {
 if( mbForeignDC || !mhBmp )
 return true;// ???
-else
+
+HBITMAP hNewBmp = ImplCreateVirDevBitmap(getHDC(), nDX, nDY, mnBitCount,
+ ::temporary(nullptr));
+if (!hNewBmp)
 {
-void *pDummy;
-HBITMAP hNewBmp = ImplCreateVirDevBitmap(getHDC(), nDX, nDY, 
mnBitCount, );
-if ( hNewBmp )
-{
-mnWidth = nDX;
-mnHeight = nDY;
-
-SelectBitmap( getHDC(), hNewBmp );
-DeleteBitmap( mhBmp );
-mhBmp = hNewBmp;
-
-if (mpGraphics)
-{
-WinOpenGLSalGraphicsImpl *pImpl;
-pImpl = dynamic_cast< WinOpenGLSalGraphicsImpl * 
>(mpGraphics->GetImpl());
-if (pImpl)
-pImpl->Init();
-}
-return true;
-}
-else
-{
-mnWidth = 0;
-mnHeight = 0;
-return false;
-}
+mnWidth = 0;
+mnHeight = 0;
+return false;
 }
+
+mnWidth = nDX;
+mnHeight = nDY;
+
+SelectBitmap(getHDC(), hNewBmp);
+mhBmp.reset(hNewBmp);
+
+if (mpGraphics)
+{
+WinOpenGLSalGraphicsImpl *pImpl;
+pImpl = dynamic_cast< WinOpenGLSalGraphicsImpl * 
>(mpGraphics->GetImpl());
+if (pImpl)
+pImpl->Init();
+}
+
+return true;
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 104442] [META] OOXML shape (DrawingML and VML) related issues

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104442

NISZ LibreOffice Team  changed:

   What|Removed |Added

 Depends on||123112


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=123112
[Bug 123112] FILEOPEN | DOCX, Some text goes out of bound in shapes in LO.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123112] FILEOPEN | DOCX, Some text goes out of bound in shapes in LO.

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123112

--- Comment #2 from NISZ LibreOffice Team  ---
Created attachment 148848
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148848=edit
Screenshot of the original document side by side in Word and Writer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123112] FILEOPEN | DOCX, Some text goes out of bound in shapes in LO.

2019-02-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123112

NISZ LibreOffice Team  changed:

   What|Removed |Added

 CC||kelem...@ubuntu.com,
   ||nem...@numbertext.org
 Blocks||104442


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104442
[Bug 104442] [META] OOXML shape (DrawingML and VML) related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


<    1   2   3   4   >