Re: gsoc 2019

2019-03-28 Thread Muhammet Kara

Hello Shubham,


On 29.03.2019 01:21, Shubham Verma wrote:

Hello Dear Sir,

My name is Shubham Verma. I am a B tech 2nd-year I.T. student and I 
would like to look into working with LibreOffice for the Google Summer 
of Code 2019.



Great! Welcome to LibreOffice!





I have just recently started learning and looking into the 
contributions that I can make to GitHub issues. As this is my first 
GSOC  I wanted to know what other things I have to do to be part of an 
organization.



We don't use GitHub at all for the LibreOffice project. What you see on 
our GitHub repo is just a read-only mirror.


The answer you got on the dev mailing list still stands mostly: 
https://lists.freedesktop.org/archives/libreoffice/2019-March/082306.html






I mentioned my interest and project on which I want to work on below, 
have a look at that and tell me what will be good for me. I want to 
work on the project Additions - Tight integration of extensions like 
GHNS! and 100 paper cuts under the guidance of yours. and I want to 
ask you if you have a particular long-standing idea on which I can work.



Both sound good.

For the 100-paper-cuts idea, you will need to go thorough the list of 
the paper-cuts,[0] and select 15-20 of them, preferably related to the 
same or similar part(s) of the code-base. Write a draft with them, and 
ask for input/opinion from me or Samuel Mehrbrodt.


For the "Additions - Tight integration of extensions like GHNS!" idea, 
you will need to investigate the current situation of the extensions 
website,[1] and the extension manager, go through the initial idea and 
the blog post[2] by Heiko Tietze, try to refine the idea, and come up 
with a final design. Attending design meetings[3], and also discussing 
the idea with Heiko Tietze and me would help a lot. Beware that this is 
a very nice project idea, but might need some preliminary work to give 
it a final shape, preferably before submitting your final proposal. 
Otherwise, it might cause you to lose some time at the beginning of the 
GSoC timeline.






I would be grateful if you can tell me if there's anything else that I 
could do which would be appreciated. Any further guidance or inputs 
would certainly be of great help.



If you are going to go with the 100-paper-cuts idea, here is a nice 
easyhack of 'interesting' level: 
https://bugs.documentfoundation.org/show_bug.cgi?id=115527


Any other 'interesting' easyhack, that you feel interested, would also 
be good.







Thank you!



Best,
Muhammet


[0] https://nextcloud.documentfoundation.org/s/zraEHZxyCKBTNY7
[1] https://extensions.libreoffice.org
[2] 
https://design.blog.documentfoundation.org/2016/11/11/additions-to-libreoffice/

[3] https://pad.documentfoundation.org/p/design

--
Consultant Software Engineer
Collabora Productivity
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 124414] New: Image doesn't print (to PDF)

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124414

Bug ID: 124414
   Summary: Image doesn't print (to PDF)
   Product: LibreOffice
   Version: 6.2.2.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Printing and PDF export
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: fredofromst...@gmail.com

Description:
I have a 295 pages document with about 10 images appearing here and there in
it. There is one, though, that doesn't print. It appears fine in the
LibreOffice document, but the PDF doesn't contain the image, just its frame.

Actual Results:
I open my document, I select Print in the menu, I chose to print in a file, I
ask that there are to pages printed side to side (1 2) : Tadam ! One image is
missing.

Expected Results:
Image not present in the PDF.


Reproducible: Always


User Profile Reset: No



Additional Info:
Put the image in it, like all the others.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65492] Opening Password for DOC file limited to 15 characters

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=65492

--- Comment #8 from Mike Kaganski  ---
(In reply to Mike from comment #7)
> Though, I tested the limit with MS Word 2007. It supports longer
> passwords. So, if you have to open an old DOC with a longer password, you
> need an older version of MS Office.

Just tested with Word 2007 (12.0.6784.5000) SP3: created a new document, saved
as DOC, and set its encryption password to 16-character "1234567890123456". It
swallowed the password (although asked me if I want to use DOCX instead because
of stronger encryption), and then trying to open the document using the same
16-character password failed, while entering the first 15 characters allowed me
to successfully open the document.

So was there actually a version that allowed to use more than 15 characters of
password for binary documents? Should the bug be closed NOTABUG (or concentrate
on proper indication of limiting entered password - something the person
entering the password might not notice), or set to NEEDINFO asking for a sample
of (or specific steps to get) such a document?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116663] Ungrouping collapsed rows leaves them hidden

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116663

--- Comment #5 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96592] Thunderbird Addressbook deleted records not reflected in Base

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96592

--- Comment #12 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116566] Respect configured AutoSpellCheck colour in the dialog too

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116566

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101200] Two objects are not deleted after the uninstallation

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101200

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116651] EDITING: possible to delete a slide in read-only mode or when edit mode is off

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116651

--- Comment #3 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116582] Sometimes suggestions for French spelling corrections no longer appear in Calc

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116582

--- Comment #5 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90652] Alternating focus between content and title makes either element invisible in the Slide pane preview

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90652

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116607] EDITING & FORMATTING: Percentage formatted cell cannot be use for addition

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116607

--- Comment #3 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124114] Setting the default view to "Web" (or "Normal")

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124114

--- Comment #3 from ddm...@gmail.com ---
Version: 6.2.0.3 (x64)

Other people have experienced the same problem. It's not just me.

Also, I save documents as .docx, if that matters.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123857] Can't define, name and save custom colours

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123857

--- Comment #2 from ddm...@gmail.com ---
Format>Area
https://help.libreoffice.org/Draw/Defining_Custom_Colors

Options>Color
https://www.maketecheasier.com/add-custom-color-in-libreoffice/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112099] Table borders in DOC or DOCX file render different

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112099

--- Comment #7 from Walter Cheuk  ---
The border is still not render correctly.

Version: 6.2.2.2 (x64)
Build ID: 2b840030fec2aae0fd2658d8d4f9548af4e3518d
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; 
Locale: en-GB (zh_TW); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/unx

2019-03-28 Thread Jan-Marek Glogowski (via logerrit)
 vcl/unx/gtk/gtkinst.cxx |   14 ++
 1 file changed, 6 insertions(+), 8 deletions(-)

New commits:
commit 22f5afb78aeaf6e5e9a4fb00d74833d73cef5bbc
Author: Jan-Marek Glogowski 
AuthorDate: Sat Mar 23 00:44:50 2019 +0100
Commit: Jan-Marek Glogowski 
CommitDate: Fri Mar 29 03:01:30 2019 +0100

GTK use SalYieldMutex lock arguments

The acquire and release functions already provide arguments to
release and re-acquire the lock, so use these. Also moves the
n-1 lock handling from release into acquire. This way release
doesn't need any special handling, which acquire already does.

Change-Id: If2fc92beb8e3ea1f5c078da4d8dde3ce9c774c6f
Reviewed-on: https://gerrit.libreoffice.org/69574
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/vcl/unx/gtk/gtkinst.cxx b/vcl/unx/gtk/gtkinst.cxx
index 64604ea3f92a..f18dc9457fd5 100644
--- a/vcl/unx/gtk/gtkinst.cxx
+++ b/vcl/unx/gtk/gtkinst.cxx
@@ -313,20 +313,18 @@ void GtkYieldMutex::ThreadsEnter()
 if (!yieldCounts.empty()) {
 auto n = yieldCounts.top();
 yieldCounts.pop();
-for (; n != 0; --n) {
-acquire();
-}
+assert(n > 0);
+n--;
+if (n > 0)
+acquire(n);
 }
 }
 
 void GtkYieldMutex::ThreadsLeave()
 {
 assert(m_nCount != 0);
-auto n = m_nCount - 1;
-yieldCounts.push(n);
-for (sal_uIntPtr i = 0; i != n + 1; ++i) {
-release();
-}
+yieldCounts.push(m_nCount);
+release(true);
 }
 
 std::unique_ptr GtkInstance::CreateVirtualDevice( 
SalGraphics *pG,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #288 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/d757b121e3f0f5de03da1be430ed51bf830dce67%5E%21

tdf#45904 Move XNamed Java tests to C++

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/test qadevOOo/objdsc sc/qa test/source

2019-03-28 Thread Jens Carl (via logerrit)
 include/test/container/xnamed.hxx  |2 +
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinkObj.csv |2 -
 sc/qa/extras/scsheetlinkobj.cxx|7 +
 test/source/container/xnamed.cxx   |   14 
++
 4 files changed, 23 insertions(+), 2 deletions(-)

New commits:
commit d757b121e3f0f5de03da1be430ed51bf830dce67
Author: Jens Carl 
AuthorDate: Fri Mar 29 00:30:18 2019 +
Commit: Jens Carl 
CommitDate: Fri Mar 29 02:47:05 2019 +0100

tdf#45904 Move XNamed Java tests to C++

Move XNamed Java tests to C++ for ScSheetLinkObj.

Change-Id: I64904ed6bae1b96767f8b0a65b0850a8694b10c2
Reviewed-on: https://gerrit.libreoffice.org/69907
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/include/test/container/xnamed.hxx 
b/include/test/container/xnamed.hxx
index 1b1a762ef8b4..de8618ce4436 100644
--- a/include/test/container/xnamed.hxx
+++ b/include/test/container/xnamed.hxx
@@ -30,6 +30,8 @@ public:
 
 void testGetName();
 void testSetName();
+// special case, here name is equal to links URL
+void testSetNameByScSheetLinkObj();
 void testSetNameThrowsException();
 
 virtual css::uno::Reference< css::uno::XInterface > init() = 0;
diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinkObj.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinkObj.csv
index 2d72f6819568..63be54e69d85 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinkObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinkObj.csv
@@ -1,5 +1,3 @@
-"ScSheetLinkObj";"com::sun::star::container::XNamed";"getName()"
-"ScSheetLinkObj";"com::sun::star::container::XNamed";"setName()"
 "ScSheetLinkObj";"com::sun::star::beans::XPropertySet";"getPropertySetInfo()"
 "ScSheetLinkObj";"com::sun::star::beans::XPropertySet";"setPropertyValue()"
 "ScSheetLinkObj";"com::sun::star::beans::XPropertySet";"getPropertyValue()"
diff --git a/sc/qa/extras/scsheetlinkobj.cxx b/sc/qa/extras/scsheetlinkobj.cxx
index 2819c915b6f0..5239a3288cee 100644
--- a/sc/qa/extras/scsheetlinkobj.cxx
+++ b/sc/qa/extras/scsheetlinkobj.cxx
@@ -8,6 +8,7 @@
  */
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -31,6 +32,7 @@ namespace sc_apitest
 {
 class ScSheetLinkObj : public CalcUnoApiTest,
public apitest::SheetLink,
+   public apitest::XNamed,
public apitest::XRefreshable
 {
 public:
@@ -46,6 +48,10 @@ public:
 // SheetLink
 CPPUNIT_TEST(testSheetLinkProperties);
 
+// XNamed
+CPPUNIT_TEST(testGetName);
+CPPUNIT_TEST(testSetNameByScSheetLinkObj);
+
 // XRefreshable
 CPPUNIT_TEST(testRefreshListener);
 
@@ -57,6 +63,7 @@ private:
 
 ScSheetLinkObj::ScSheetLinkObj()
 : CalcUnoApiTest("/sc/qa/extras/testdocuments")
+, 
XNamed(m_directories.getURLFromSrc("/sc/qa/extras/testdocuments/ScSheetLinkObj.ods"))
 {
 }
 
diff --git a/test/source/container/xnamed.cxx b/test/source/container/xnamed.cxx
index c8234f6dde4f..3b8023b6bc95 100644
--- a/test/source/container/xnamed.cxx
+++ b/test/source/container/xnamed.cxx
@@ -8,6 +8,7 @@
  */
 
 #include 
+#include 
 
 #include 
 #include 
@@ -40,6 +41,19 @@ void XNamed::testSetName()
 CPPUNIT_ASSERT_EQUAL(m_aTestName, xNamed->getName());
 }
 
+void XNamed::testSetNameByScSheetLinkObj()
+{
+uno::Reference xNamed(init(), uno::UNO_QUERY_THROW);
+OUString aTestName(m_aTestName.replaceAll("ScSheetLinkObj", 
"NewScSheetLinkObj"));
+
+xNamed->setName(aTestName);
+CPPUNIT_ASSERT_EQUAL(aTestName, xNamed->getName());
+
+// restore old name
+xNamed->setName(m_aTestName);
+CPPUNIT_ASSERT_EQUAL(m_aTestName, xNamed->getName());
+}
+
 void XNamed::testSetNameThrowsException()
 {
 uno::Reference xNamed(init(), uno::UNO_QUERY_THROW);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #287 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/8d45d5ee399d0148672e79c379f5d29e1c8ba6f3%5E%21

tdf#45904 Move XRefreshable Java tests to C++

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: qadevOOo/objdsc sc/qa

2019-03-28 Thread Jens Carl (via logerrit)
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinkObj.csv |3 -
 sc/qa/extras/scsheetlinkobj.cxx|   30 
+-
 sc/qa/extras/testdocuments/ScSheetLinkObj.ods  |binary
 3 files changed, 17 insertions(+), 16 deletions(-)

New commits:
commit 8d45d5ee399d0148672e79c379f5d29e1c8ba6f3
Author: Jens Carl 
AuthorDate: Thu Mar 28 22:21:59 2019 +
Commit: Jens Carl 
CommitDate: Fri Mar 29 01:36:42 2019 +0100

tdf#45904 Move XRefreshable Java tests to C++

Move XRefreshable Java tests to C++ for ScSheetLinkObj.

Change-Id: I8225a3eb8be903ebcf51950431a5f6810a5aaa4f
Reviewed-on: https://gerrit.libreoffice.org/69906
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinkObj.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinkObj.csv
index fb11276d69cb..2d72f6819568 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinkObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScSheetLinkObj.csv
@@ -1,6 +1,3 @@
-"ScSheetLinkObj";"com::sun::star::util::XRefreshable";"refresh()"
-"ScSheetLinkObj";"com::sun::star::util::XRefreshable";"addRefreshListener()"
-"ScSheetLinkObj";"com::sun::star::util::XRefreshable";"removeRefreshListener()"
 "ScSheetLinkObj";"com::sun::star::container::XNamed";"getName()"
 "ScSheetLinkObj";"com::sun::star::container::XNamed";"setName()"
 "ScSheetLinkObj";"com::sun::star::beans::XPropertySet";"getPropertySetInfo()"
diff --git a/sc/qa/extras/scsheetlinkobj.cxx b/sc/qa/extras/scsheetlinkobj.cxx
index fbad33a9f18c..2819c915b6f0 100644
--- a/sc/qa/extras/scsheetlinkobj.cxx
+++ b/sc/qa/extras/scsheetlinkobj.cxx
@@ -9,6 +9,8 @@
 
 #include 
 #include 
+#include 
+#include 
 
 #include 
 #include 
@@ -24,12 +26,12 @@
 #include 
 
 using namespace css;
-using namespace css::uno;
-using namespace com::sun::star;
 
 namespace sc_apitest
 {
-class ScSheetLinkObj : public CalcUnoApiTest, public apitest::SheetLink
+class ScSheetLinkObj : public CalcUnoApiTest,
+   public apitest::SheetLink,
+   public apitest::XRefreshable
 {
 public:
 ScSheetLinkObj();
@@ -44,6 +46,9 @@ public:
 // SheetLink
 CPPUNIT_TEST(testSheetLinkProperties);
 
+// XRefreshable
+CPPUNIT_TEST(testRefreshListener);
+
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -57,18 +62,17 @@ ScSheetLinkObj::ScSheetLinkObj()
 
 uno::Reference ScSheetLinkObj::init()
 {
-uno::Reference xDoc(mxComponent, 
UNO_QUERY_THROW);
+uno::Reference xDoc(mxComponent, 
uno::UNO_QUERY_THROW);
 
-uno::Reference xSheets(xDoc->getSheets(), 
UNO_QUERY_THROW);
-uno::Reference xIA(xSheets, UNO_QUERY_THROW);
-uno::Reference xSheet(xIA->getByIndex(0), 
UNO_QUERY_THROW);
+uno::Reference xSheets(xDoc->getSheets(), 
uno::UNO_QUERY_THROW);
+uno::Reference xIA(xSheets, uno::UNO_QUERY_THROW);
+uno::Reference xSheet(xIA->getByIndex(0), 
uno::UNO_QUERY_THROW);
 
-uno::Reference xSL(xSheet, UNO_QUERY_THROW);
-OUString aFileURL;
-createFileURL("ScSheetLinkObj.ods", aFileURL);
-xSL->link(aFileURL, "Sheet1", "", "", sheet::SheetLinkMode_VALUE);
+uno::Reference xSL(xSheet, uno::UNO_QUERY_THROW);
+
xSL->link(m_directories.getURLFromSrc("/sc/qa/extras/testdocuments/ScSheetLinkObj.ods"),
+  "Sheet1", "", "", sheet::SheetLinkMode_VALUE);
 
-uno::Reference xPropSet(xDoc, UNO_QUERY_THROW);
+uno::Reference xPropSet(xDoc, uno::UNO_QUERY_THROW);
 uno::Reference sheetLinks;
 CPPUNIT_ASSERT(xPropSet->getPropertyValue("SheetLinks") >>= sheetLinks);
 CPPUNIT_ASSERT(sheetLinks.is());
@@ -94,7 +98,7 @@ void ScSheetLinkObj::tearDown()
 
 CPPUNIT_TEST_SUITE_REGISTRATION(ScSheetLinkObj);
 
-} // end namespace
+} // namespace sc_apitest
 
 CPPUNIT_PLUGIN_IMPLEMENT();
 
diff --git a/sc/qa/extras/testdocuments/ScSheetLinkObj.ods 
b/sc/qa/extras/testdocuments/ScSheetLinkObj.ods
new file mode 100644
index ..7f09e0d978eb
Binary files /dev/null and b/sc/qa/extras/testdocuments/ScSheetLinkObj.ods 
differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124413] New: Crash on undo / redo in Basic IDE

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124413

Bug ID: 124413
   Summary: Crash on undo / redo in Basic IDE
   Product: LibreOffice
   Version: 6.1.0.0.beta1+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tvata...@starxpert.fr

Description:
LibreOffice crashes when some text is copied and pasted, and then paste is undo
/ redo several times.

Steps to Reproduce:
1. Open the Basic macros organizer and edit the module Module1 of the Standard
library.
3. Select at least two lines in the module
4. Copy selected text and overwrite it with clipboard content with Paste
command.
5. Cancel paste with undo keyboard shortcut or menu.
6. Restore paste with redo keyboard shortcut or menu.
7. Cancel paste with undo keyboard shortcut or menu.


Actual Results:
This leads to a crash of LibreOffice.

Expected Results:
LibreOffice should not crash.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
No crash if the text is cut instead of copied.
No crash if only a single line is copied and pasted.
Crashes only if copied text is pasted on itself.

Crash report :
https://crashreport.libreoffice.org/stats/crash_details/8cd21ecb-da84-420d-b838-d8eacb36db85

Informations from 'Help - About LibreOffice' :
Version: 6.1.0.0.beta1
Build ID: 8c76dfe1284e211954c30f219b3a38dcdd82f8a0
Threads CPU : 1; OS : Linux 4.9; UI Render : par défaut; VCL: gtk2; 
Locale : fr-FR (fr_FR.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123912] Legacy form fields in DOCX become uneditable after roundtrip

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123912

--- Comment #2 from Aron Budea  ---
Another symptom after the commit in the description, and before the commit in
comment 1 (which affects behavior):

Start an empty document, enter some text, enable 'Form protection' in Tools ->
Options..., LibreOffice Writer -> Compatibility, save it as DOCX, and open the
file in Word.

=> When switching to edit mode in Word, the text is editable. It should be
read-only, since only form filling should be enabled, and the document contains
no form fields.

Note that in Writer the text still appears to be read-only, the bug can only be
seen in Word.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124391] Doubled global menu in 6.2.2 with GTK VCL

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124391

Xisco Faulí  changed:

   What|Removed |Added

 Blocks||103182
 CC||caol...@redhat.com,
   ||xiscofa...@libreoffice.org

--- Comment #4 from Xisco Faulí  ---
@Caolán, I thought you might be interested in this issue...


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103182
[Bug 103182] [META] GTK3-specific bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103182

Xisco Faulí  changed:

   What|Removed |Added

 Depends on||124391


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=124391
[Bug 124391] Doubled global menu in 6.2.2 with GTK VCL
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124410] FORMATTING: Crash in libcuilo.so formatting range containing cells with diagonal borders

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124410

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Keywords||bibisected, bisected,
   ||regression
   Severity|normal  |major
 CC||caol...@redhat.com,
   ||xiscofa...@libreoffice.org
   Priority|medium  |high
 Status|UNCONFIRMED |NEW
Version|6.2.2.2 release |6.2.0.0.alpha1+

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=229483707c3ccb48d008d37f856bbeb6df199a90

author  Caolán McNamara 2018-09-03 16:06:49 +0100
committer   Caolán McNamara 2018-09-05 13:36:35
+0200
commit  229483707c3ccb48d008d37f856bbeb6df199a90 (patch)
treec202bfb4777a66e6095fc971e317794f92399b4a
parent  59b9fc4776940863d905de14e25d74421f7de603 (diff)
weld SvxBorderTabPage

Bisected with: bibisect-linux64-6.2

Adding Cc: to Caolán McNamara

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #286 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/b99ea0ff33b78ba76d1ae436895efac490252e0f%5E%21

tdf#45904 Move XShapes Java tests to C++

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/test qadevOOo/Jar_OOoRunner.mk qadevOOo/objdsc qadevOOo/tests sc/qa test/Library_subsequenttest.mk test/source

2019-03-28 Thread Jens Carl (via logerrit)
 include/test/drawing/xshapes.hxx  |   43 +++
 qadevOOo/Jar_OOoRunner.mk |1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDrawPageObj.csv |2 
 qadevOOo/tests/java/mod/_sc/ScDrawPageObj.java|  130 --
 sc/qa/extras/scdrawpageobj.cxx|9 
 sc/qa/unoapi/sc_4.sce |1 
 test/Library_subsequenttest.mk|1 
 test/source/drawing/xshapes.cxx   |   38 ++
 8 files changed, 90 insertions(+), 135 deletions(-)

New commits:
commit b99ea0ff33b78ba76d1ae436895efac490252e0f
Author: Jens Carl 
AuthorDate: Thu Mar 28 21:24:35 2019 +
Commit: Jens Carl 
CommitDate: Fri Mar 29 00:45:46 2019 +0100

tdf#45904 Move XShapes Java tests to C++

Move XShapes Java tests to C++ for ScDrawPageObj.

Change-Id: I1b65e8ad685c3d387a5023e8e8e9b9e06627af11
Reviewed-on: https://gerrit.libreoffice.org/69904
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/include/test/drawing/xshapes.hxx b/include/test/drawing/xshapes.hxx
new file mode 100644
index ..f04131dc41f7
--- /dev/null
+++ b/include/test/drawing/xshapes.hxx
@@ -0,0 +1,43 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#ifndef INCLUDED_TEST_DRAWING_XSHAPES_HXX
+#define INCLUDED_TEST_DRAWING_XSHAPES_HXX
+
+#include 
+#include 
+
+#include 
+
+#include 
+
+namespace apitest
+{
+class OOO_DLLPUBLIC_TEST XShapes
+{
+public:
+virtual css::uno::Reference init() = 0;
+void setShape(const css::uno::Reference& r_xShape)
+{
+m_xShape = r_xShape;
+}
+
+void testAddRemove();
+
+protected:
+~XShapes() {}
+
+private:
+css::uno::Reference m_xShape;
+};
+} // namespace apitest
+
+#endif // INCLUDED_TEST_DRAWING_XSHAPES_HXX
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk
index 4bc4edde3ba3..3cb59e2c61de 100644
--- a/qadevOOo/Jar_OOoRunner.mk
+++ b/qadevOOo/Jar_OOoRunner.mk
@@ -961,7 +961,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\
 qadevOOo/tests/java/mod/_sc/ScDatabaseRangeObj \
 qadevOOo/tests/java/mod/_sc/ScDataPilotItemObj \
 qadevOOo/tests/java/mod/_sc/ScDocumentConfiguration \
-qadevOOo/tests/java/mod/_sc/ScDrawPageObj \
 qadevOOo/tests/java/mod/_sc/ScHeaderFieldObj \
 qadevOOo/tests/java/mod/_sc/ScHeaderFieldsObj \
 qadevOOo/tests/java/mod/_sc/ScHeaderFooterTextCursor \
diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDrawPageObj.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDrawPageObj.csv
deleted file mode 100644
index b39d7b6062be..
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDrawPageObj.csv
+++ /dev/null
@@ -1,2 +0,0 @@
-"ScDrawPageObj";"com::sun::star::drawing::XShapes";"add()"
-"ScDrawPageObj";"com::sun::star::drawing::XShapes";"remove()"
diff --git a/qadevOOo/tests/java/mod/_sc/ScDrawPageObj.java 
b/qadevOOo/tests/java/mod/_sc/ScDrawPageObj.java
deleted file mode 100644
index 0619ca7533c4..
--- a/qadevOOo/tests/java/mod/_sc/ScDrawPageObj.java
+++ /dev/null
@@ -1,130 +0,0 @@
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-package mod._sc;
-
-import java.io.PrintWriter;
-
-import lib.TestCase;
-import lib.TestEnvironment;
-import lib.TestParameters;
-import util.DrawTools;
-import util.InstCreator;
-import util.SOfficeFactory;
-import util.ShapeDsc;
-
-import com.sun.star.drawing.XDrawPage;
-import com.sun.star.drawing.XDrawPages;
-import com.sun.star.drawing.XDrawPagesSupplier;
-import com.sun.star.drawing.XShape;
-import com.sun.star.lang.XComponent;
-import com.sun.star.sheet.XSpreadsheetDocument;
-import com.sun.star.uno.AnyConverter;
-import com.sun.star.uno.Type;

[Libreoffice-bugs] [Bug 124412] New: Conditional formatting screen always shows 'Date is today' as conditional when inserting date conditional UI

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124412

Bug ID: 124412
   Summary: Conditional formatting screen always shows 'Date is
today' as conditional when inserting date conditional
UI
   Product: LibreOffice
   Version: 6.2.0.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: trivial
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mat2904j...@gmail.com

Description:
Making conditions based on date always show as 'Date is today' even if the
condition is not 'Date is today'.

See here: https://i.imgur.com/DLok4qV.png
And here you see condition 2 isn't really Date is today:
https://i.imgur.com/aXzUHDI.png

Steps to Reproduce:
1. select a tile
2. Right mouse button on the selection, open conditional formatting
3. Create a formatting rule based on the 'Date is' version
4. Make a rule based on anything
5. Make a rule based on anything that is not 'Date is today'
6. Select the bottom condition


Actual Results:
See that the top condition now says: 'Condition # Date is today'

Expected Results:
See that the top condition now says: 'Condition # Actual condition'


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116585] Text is black on black inside the Math formula editor with "Breeze dark" theme (KDE)

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116585

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

--- Comment #6 from Michael Weghorn  ---
Created attachment 150385
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150385=edit
Screenshot with kde5

It seems this is now also reproducible with the new kde5 VCL plugin after going
to Plasma system settings -> "Workspace Theme" and setting the "Look and Feel"
and "Desktop Theme" to "Breeze Dark".

After logging out and in again, it looks as shown in the attached screenshot.
It's actually black font on grey background, so somewhat readable, but not
ideal...

Version: 6.3.0.0.alpha0+
Build ID: 28eab5de358631758315a3581e860d6ef533259a
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: kde5; 
Locale: en-GB (en_GB.UTF-8); UI-Language: en-US
Calc: threaded

Side note: It's just fine in the "Help" -> "About" dialog, for example (white
font used there).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124411] New: Impress: dragging image from file browser to slide replaces text

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124411

Bug ID: 124411
   Summary: Impress: dragging image from file browser to slide
replaces text
   Product: LibreOffice
   Version: 6.1.5.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: samtyg...@yahoo.co.uk

If I drag and drop an image from a file browser (caja) into a slide, it removes
and replaces the main text area.

1) Create a new presentation.
2) Set slide layout to "Title slide" or "Tile, content"
3) add some text to the main text area
4) Drag an image file from a file browser into the slide

Expected behaviour

A new image object is created.

Actual behaviour

The main text is deleted and the area is fill with a stretched version of the
image.

Happens in
Version: 6.1.5.2
Build ID: 6.1.5.2-2.fc29
CPU threads: 8; OS: Linux 5.0; UI render: default; VCL: gtk3; 
Locale: en-GB (en_GB.UTF-8); Calc: group threaded
and
Version: 6.2.2.2
Build ID: 2b840030fec2aae0fd2658d8d4f9548af4e3518d
CPU threads: 8; OS: Linux 5.0; UI render: default; VCL: gtk3; 
Locale: en-GB (en_GB.UTF-8); UI-Language: en-GB
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115627] Checkboxes and radio buttons are cropped in the menu (with KDE and Oxygen widgets)

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115627

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

--- Comment #14 from Michael Weghorn  ---
Is this still relevant with the new kde5 VCL plugin?
At a quick glance, it looks OK for me, but I didn't check any other
themes/widget styles.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70287] Saving a document as certain file types does not populate "History" in KDE Plasma Kickoff menu

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=70287

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

--- Comment #11 from Michael Weghorn  ---
Is an entry created for any other KDE application when it saves a file? If so,
can you give any examples?

At least Okular and Kate also didn't create any entries there in a quick test
of mine.

Entries in that "History" are created whenever a file is double-clicked from
Dolphin, and that seems to be the case no matter what application is used to
open the file, i.e. it works for odt files opened by LibreOffice in the same
way as for text files opened by Kate or PDF files opened by Okular.

No idea whether that's the way this is supposed to work (would probably have to
check the Plasma source code), but at a quick glance it seems to me like
LibreOffice was behaving just the same way as other KDE apps...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124405] LibreWriter Changed the graph saved in a .docx word file

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124405

mulla.tasa...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from mulla.tasa...@gmail.com ---
Thank you for reporting the bug.

I can confirm that the bug is present in

Version: 6.2.1.2 (x64)
Build ID: 7bcb35dc3024a62dea0caee87020152d1ee96e71
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL


Version: 6.3.0.0.alpha0+ (x64)
Build ID: 91cdf22b88a4f7bec243c8fb187627e766d3294c
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-03-08_00:38:10
Locale: en-US (en_US); UI-Language: en-US
Calc: CL

I have observed in LibreOffice that for first two graphs X axis starts at
2.8,so they are similar to graphs in Microsoft Word 
But in 3rd graph X axis coordinates are different.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa sc/source

2019-03-28 Thread Winfried Donkers (via logerrit)
 sc/qa/unit/data/functions/mathematical/fods/rounddown.fods |   19 ++
 sc/qa/unit/data/functions/mathematical/fods/roundup.fods   |   19 ++
 sc/source/core/inc/interpre.hxx|1 
 sc/source/core/tool/interpr2.cxx   |   37 ++---
 4 files changed, 66 insertions(+), 10 deletions(-)

New commits:
commit edcbe8c4e02a67c74ec6f85f28899431dbfa0765
Author: Winfried Donkers 
AuthorDate: Tue Mar 26 16:27:09 2019 +0100
Commit: Eike Rathke 
CommitDate: Thu Mar 28 23:18:37 2019 +0100

tdf#124286 fix annoying rounding error.

In case of ROUNDDOWN and ROUNDUP, it is possible that seemingly clear 
decimal
values are rounded unexpectedly (from the user's POV). This is caused by 
the i
decimal to binary to decimal conversions.
By rounding to 12 significanr digits before calling the round-down of -up
function, most of these unexpected roundings are eliminated.

Change-Id: Ia19181383b77e1ff40a067c4a1cea1ece0955871
Reviewed-on: https://gerrit.libreoffice.org/69762
Tested-by: Jenkins
Reviewed-by: Eike Rathke 

diff --git a/sc/qa/unit/data/functions/mathematical/fods/rounddown.fods 
b/sc/qa/unit/data/functions/mathematical/fods/rounddown.fods
index 5726eea4c9d5..0389f6348ef1 100644
--- a/sc/qa/unit/data/functions/mathematical/fods/rounddown.fods
+++ b/sc/qa/unit/data/functions/mathematical/fods/rounddown.fods
@@ -2123,6 +2123,23 @@
  
 
 
+ 
+  0.940
+ 
+ 
+  0.94
+ 
+ 
+  TRUE
+ 
+ 
+  =ROUNDDOWN(31415.92654, 3)
+ 
+ 
+ 
+ 
+
+
  
  
  
@@ -2408,4 +2425,4 @@

   
  
-
\ No newline at end of file
+
diff --git a/sc/qa/unit/data/functions/mathematical/fods/roundup.fods 
b/sc/qa/unit/data/functions/mathematical/fods/roundup.fods
index d1a56f7491cf..3fa289d4a2fc 100644
--- a/sc/qa/unit/data/functions/mathematical/fods/roundup.fods
+++ b/sc/qa/unit/data/functions/mathematical/fods/roundup.fods
@@ -2075,6 +2075,23 @@
  
 
 
+ 
+  0.060
+ 
+ 
+  0.06
+ 
+ 
+  TRUE
+ 
+ 
+  =ROUNDUP(8.06-8,2)
+ 
+ 
+ 
+ 
+
+
  
  
  
@@ -2360,4 +2377,4 @@

   
  
-
\ No newline at end of file
+
diff --git a/sc/source/core/inc/interpre.hxx b/sc/source/core/inc/interpre.hxx
index 3fd3dcf7668c..398fe707f86f 100644
--- a/sc/source/core/inc/interpre.hxx
+++ b/sc/source/core/inc/interpre.hxx
@@ -776,6 +776,7 @@ private:
 void ScConvertOOo();
 void ScEuroConvert();
 void ScRoundSignificant();
+static void RoundSignificant( double fX, double fDigits, double  );
 
 // financial functions
 void ScNPV();
diff --git a/sc/source/core/tool/interpr2.cxx b/sc/source/core/tool/interpr2.cxx
index b47acaddaf72..b8e4baef418f 100644
--- a/sc/source/core/tool/interpr2.cxx
+++ b/sc/source/core/tool/interpr2.cxx
@@ -983,10 +983,25 @@ void ScInterpreter::RoundNumber( rtl_math_RoundingMode 
eMode )
 else
 {
 sal_Int16 nDec = GetInt16();
+double fX = GetDouble();
 if ( nGlobalError != FormulaError::NONE || nDec < -20 || nDec > 20 
)
 PushIllegalArgument();
 else
-fVal = ::rtl::math::round( GetDouble(), nDec, eMode );
+{
+if ( ( eMode == rtl_math_RoundingMode_Down ||
+   eMode == rtl_math_RoundingMode_Up ) &&
+ nDec < 12 && fmod( fX, 1.0 ) != 0.0 )
+{
+// tdf124286 : round to 12 significant digits before 
rounding
+// down or up to avoid unexpected rounding 
errors
+// caused by decimal -> binary -> decimal 
conversion
+double fRes;
+RoundSignificant( fX, 12, fRes );
+fVal = ::rtl::math::round( fRes, nDec, eMode );
+}
+else
+fVal = ::rtl::math::round( fX, nDec, eMode );
+}
 }
 PushDouble(fVal);
 }
@@ -1007,6 +1022,17 @@ void ScInterpreter::ScRoundUp()
 RoundNumber( rtl_math_RoundingMode_Up );
 }
 
+void ScInterpreter::RoundSignificant( double fX, double fDigits, double  )
+{
+bool bNegVal = ( fX < 0 );
+if ( bNegVal )
+fX *= -1.0;
+double fTemp = ::rtl::math::approxFloor( log10( fX ) ) + 1.0 - fDigits;
+fRes = ::rtl::math::round( pow(10.0, -fTemp ) * fX ) * pow( 10.0, fTemp );
+if ( bNegVal )
+fRes *= -1.0;
+}
+
 // tdf#106931
 void ScInterpreter::ScRoundSignificant()
 {
@@ -1024,13 +1050,8 @@ void ScInterpreter::ScRoundSignificant()
 PushDouble( 0.0 );
 else
 {
-bool bNegVal = ( fX < 0 );
-if ( bNegVal )
-fX *= -1.0;
-double fTemp = ::rtl::math::approxFloor( log10( fX ) ) + 1.0 - 
fDigits;
-double fRes = 

[Libreoffice-bugs] [Bug 124410] New: FORMATTING: Crash in libcuilo.so formatting range containing cells with diagonal borders

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124410

Bug ID: 124410
   Summary: FORMATTING: Crash in libcuilo.so formatting range
containing cells with diagonal borders
   Product: LibreOffice
   Version: 6.2.2.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: u...@franke-auer.de

Created attachment 150384
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150384=edit
Formatting two cells with diagonal borders cause crsah when formatting range

This bug was filed from the crash reporting server and is
br-cca9c0fc-7f2e-4fcf-a7cf-8ff017d84363.
=

Crash in libcuilo.so formatting range containing cells with diagonal borders
(see Uploaded TestCase.ods file)

Reproducibility: Always

Steps to reproduce (see also attachment)
1) Open empty spreadsheet in Calc
2) Format one or more cells with a diagonal border
3) Select an arbitrary range containing cell(s) from step 2.
4) Right click and select "Format Cells"

=> Crash occurs

Configuration of reporter system
Version: 6.2.2.2
Build-ID: 2b840030fec2aae0fd2658d8d4f9548af4e3518d
CPU-Threads: 8; BS: Linux 4.12; UI-Render: GL; VCL: kde5; 
Gebietsschema: de-DE (de_DE.UTF-8); UI-Sprache: de-DE
Calc: threaded

Another report in
https://ask.libreoffice.org/de/question/188471/calc-seit-lo-62-fehler-bei-diagonalen-linien-in-zellen/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123641] Emailmerge: can not connect to SMTP server with TLS

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123641

--- Comment #7 from Ferry Toth  ---
I tried just now smtp.telfort.nl on port 587. The test fails due to both
connection and searching server. This is one I use all the time with
thunderbird (STARTTLS). It requires no login, but is closed from outside there
domain.

This same server fails in the same way with port 465.

Same results for mail.antagonist.nl on both 587 and 465.

Maybe you could try to reproduce with something other then just gmail?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122829] Images fail to load when many large ones with captions saved as docx FILEOPEN

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122829

--- Comment #15 from Hamish McIntyre-Bhatty  ---
Oops, didn't intend to do that!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 50504] EDITING: Can not add characters at the beginning of a cell which have a very long first line

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=50504

--- Comment #8 from pierre-louis.bonic...@gmx.fr ---
Am still able to reproduce it using "Version: 6.1.5.2".

Note that the FAQ mentions [1] "the maximum number of characters in one cell is
32767".


[1] https://wiki.documentfoundation.org/Faq/Calc/022/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/inc sc/source

2019-03-28 Thread Dennis Francis (via logerrit)
 sc/inc/column.hxx   |5 +--
 sc/source/core/data/column3.cxx |   66 +++-
 2 files changed, 55 insertions(+), 16 deletions(-)

New commits:
commit e7d0785a7d2a07e64dc58dee4f1b072a72e32aa5
Author: Dennis Francis 
AuthorDate: Tue Mar 26 16:50:44 2019 +0530
Commit: Eike Rathke 
CommitDate: Thu Mar 28 22:43:28 2019 +0100

tdf#120660: Populate rNewSharedRows even if no FC...

at specified position. At least in case of ScUndoPaste, during
undo operation, the content from changed area in main-document
is removed before actual undo-paste, so when cloned formula-cell
from undo-doc is inserted to main-doc, there is no "old" cell
to detach, so "rNewSharedRows" is not populated which is needed
for proper re-establishment of listeners if there are formula/
formula-groups adjacent to insertion position.

Change-Id: Id2bfb65a2a7a5abb03effbdcc4405015fddc401c
Next: fix the vector version of this case and write unit tests.
Reviewed-on: https://gerrit.libreoffice.org/69737
Tested-by: Jenkins
Reviewed-by: Eike Rathke 

diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index 15eb10b70238..b836fabef770 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -702,9 +702,10 @@ public:
 boolReservePatternCount( SCSIZE nReserve );
 private:
 
-sc::CellStoreType::iterator GetPositionToInsert( SCROW nRow, 
std::vector& rNewSharedRows );
+sc::CellStoreType::iterator GetPositionToInsert( SCROW nRow, 
std::vector& rNewSharedRows,
+ bool bInsertFormula );
 sc::CellStoreType::iterator GetPositionToInsert( const 
sc::CellStoreType::iterator& it, SCROW nRow,
- std::vector& 
rNewSharedRows );
+ std::vector& 
rNewSharedRows, bool bInsertFormula );
 
 void AttachNewFormulaCell(
 const sc::CellStoreType::iterator& itPos, SCROW nRow, ScFormulaCell& 
rCell,
diff --git a/sc/source/core/data/column3.cxx b/sc/source/core/data/column3.cxx
index 14c1c1424237..8e728cbe2916 100644
--- a/sc/source/core/data/column3.cxx
+++ b/sc/source/core/data/column3.cxx
@@ -256,9 +256,10 @@ void ScColumn::DeleteRow( SCROW nStartRow, SCSIZE nSize, 
std::vector*
 CellStorageModified();
 }
 
-sc::CellStoreType::iterator ScColumn::GetPositionToInsert( SCROW nRow, 
std::vector& rNewSharedRows )
+sc::CellStoreType::iterator ScColumn::GetPositionToInsert( SCROW nRow, 
std::vector& rNewSharedRows,
+bool bInsertFormula )
 {
-return GetPositionToInsert(maCells.begin(), nRow, rNewSharedRows);
+return GetPositionToInsert(maCells.begin(), nRow, rNewSharedRows, 
bInsertFormula);
 }
 
 void ScColumn::JoinNewFormulaCell(
@@ -534,17 +535,54 @@ void ScColumn::DetachFormulaCells( 
sc::EndListeningContext& rCxt, SCROW nRow1, S
 sc::ProcessFormula(it, maCells, nRow1, nRow2, aFunc);
 }
 
-sc::CellStoreType::iterator ScColumn::GetPositionToInsert( const 
sc::CellStoreType::iterator& it, SCROW nRow,
+static void lcl_AddFormulaGroupBoundaries(const 
sc::CellStoreType::position_type& rPos,
 std::vector& rNewSharedRows )
 {
+sc::CellStoreType::iterator itRet = rPos.first;
+if (itRet->type != sc::element_type_formula)
+return;
+
+ScFormulaCell& rFC = *sc::formula_block::at(*itRet->data, rPos.second);
+if ( rFC.IsShared() )
+{
+const SCROW nSharedTopRow = rFC.GetSharedTopRow();
+const SCROW nSharedLength = rFC.GetSharedLength();
+rNewSharedRows.push_back( nSharedTopRow);
+rNewSharedRows.push_back( nSharedTopRow + nSharedLength - 1);
+}
+else
+{
+const SCROW nRow = rFC.aPos.Row();
+rNewSharedRows.push_back( nRow);
+rNewSharedRows.push_back( nRow);
+}
+}
+
+sc::CellStoreType::iterator ScColumn::GetPositionToInsert( const 
sc::CellStoreType::iterator& it, SCROW nRow,
+std::vector& rNewSharedRows, bool bInsertFormula )
+{
 // See if we are overwriting an existing formula cell.
 sc::CellStoreType::position_type aPos = maCells.position(it, nRow);
 sc::CellStoreType::iterator itRet = aPos.first;
+
 if (itRet->type == sc::element_type_formula)
 {
 ScFormulaCell& rCell = *sc::formula_block::at(*itRet->data, 
aPos.second);
 DetachFormulaCell(aPos, rCell, rNewSharedRows);
 }
+else if (bInsertFormula && !GetDoc()->IsClipOrUndo())
+{
+if (nRow > 0)
+{
+sc::CellStoreType::position_type aPosBefore = 
maCells.position(maCells.begin(), nRow-1);
+lcl_AddFormulaGroupBoundaries(aPosBefore, rNewSharedRows);
+}
+if (nRow < MAXROW)
+{
+sc::CellStoreType::position_type aPosAfter = 
maCells.position(maCells.begin(), nRow+1);
+lcl_AddFormulaGroupBoundaries(aPosAfter, rNewSharedRows);
+}
+}
 
 return itRet;
 }
@@ -2085,7 

[Libreoffice-bugs] [Bug 122864] Navigator view, while an entry is being dragged, all its respective bar positions are kept displayed despite dragged positions do not match any more.

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122864

ricky.t...@gmail.com changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #6 from ricky.t...@gmail.com ---
appimage – Version: 6.2.2.2; Build ID: 2b840030fec2aae0fd2658d8d4f9548af4e3518d
CPU threads: 4; OS: Linux 5.0; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US; Calc: threaded

Two new cases appeared:
1. Position bar is not even exhibited when keeping a unique direction axis
while dragging a header through headers tree.
2. Once case 1. has been observed, keep on the header grabbed, then from now
drag it in the opposite direction axis compared to the one that prevailed in
case 1. and keep unchanged that new direction. Each one of the crossed headers
will be then marked with a persistent position bar.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123641] Emailmerge: can not connect to SMTP server with TLS

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123641

Ferry Toth  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #6 from Ferry Toth  ---
Bug 63388 affects 3.5.7.2. In comment 2 I write "testing SMTP with this dialog
works fine in LibO 5.4".

SMTP port I used is the port as detected by Thunderbird for the particular
providers I tried. Gmail was not one of them.

Other then this reason, what a strange question? The server determines the port
right, not the client.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83700] UI Window: LibreOffice should use macOS design language and components for drawing window frame

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83700

--- Comment #18 from Maarten Brouwers  ---
Created attachment 150383
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150383=edit
Proposal: move the quickactions to the application title bar (less minor)

Removing lines; less macOS style; but cleaner overall which I believe is
typically appreciated / better accepted by the macOS audience.

As written in my previous comment, award winning apps make these kind of
departures. Things, iA Writer, Pixelmator...

One might even drop the default 'tab' control and go for a more custom control.
Will I be banned for linking to a screenshot of Office for macOS?
https://itunes.apple.com/us/app/microsoft-word/id462054704 (zoom in; the images
have quite a high resolution). It's not hard to do a better job than MS.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/test

2019-03-28 Thread Jens Carl (via logerrit)
 include/test/helper/shape.hxx |   14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

New commits:
commit ee92196179d7697a514e55774be09cbf60f2c466
Author: Jens Carl 
AuthorDate: Thu Mar 28 20:12:35 2019 +
Commit: Jens Carl 
CommitDate: Thu Mar 28 22:18:48 2019 +0100

Fix header guard and improve comments

Change-Id: I7ddef04a88381e3e58a6604de35694dea658c81d
Reviewed-on: https://gerrit.libreoffice.org/69900
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/include/test/helper/shape.hxx b/include/test/helper/shape.hxx
index 9f8bd9e8b73b..e4322bec1357 100644
--- a/include/test/helper/shape.hxx
+++ b/include/test/helper/shape.hxx
@@ -7,8 +7,8 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#ifndef INCLUDED_TEST_HELPER_SHAPEFACTORY_HXX
-#define INCLUDED_TEST_HELPER_SHAPEFACTORY_HXX
+#ifndef INCLUDED_TEST_HELPER_SHAPE_HXX
+#define INCLUDED_TEST_HELPER_SHAPE_HXX
 
 #include 
 #include 
@@ -33,7 +33,7 @@ namespace shape
  * @param nYThe y-position of the shape.
  * @param nHeight   The height of the shape.
  * @param nWidthThe width of the shape.
- * @return  The create XShape.
+ * @return  The created XShape.
  */
 css::uno::Reference
 OOO_DLLPUBLIC_TEST createEllipse(const 
css::uno::Reference& r_xComponent,
@@ -47,7 +47,7 @@ css::uno::Reference
  * @param nYThe y-position of the shape.
  * @param nHeight   The height of the shape.
  * @param nWidthThe width of the shape.
- * @return  The create XShape.
+ * @return  The created XShape.
  */
 css::uno::Reference
 OOO_DLLPUBLIC_TEST createLine(const 
css::uno::Reference& r_xComponent,
@@ -61,7 +61,7 @@ css::uno::Reference
  * @param nYThe y-position of the shape.
  * @param nHeight   The height of the shape.
  * @param nWidthThe width of the shape.
- * @return  The create XShape.
+ * @return  The created XShape.
  */
 css::uno::Reference OOO_DLLPUBLIC_TEST
 createRectangle(const css::uno::Reference& 
r_xComponent, const sal_Int32 nX,
@@ -75,7 +75,7 @@ createRectangle(const 
css::uno::Reference& r_xComponent,
  * @param nYThe y-position of the shape.
  * @param nHeight   The height of the shape.
  * @param nWidthThe width of the shape.
- * @return  The create XShape.
+ * @return  The created XShape.
  */
 css::uno::Reference
 OOO_DLLPUBLIC_TEST createShape(const 
css::uno::Reference& r_xComponent,
@@ -86,6 +86,6 @@ css::uno::Reference
 } // namespace helper
 } // namespace apitest
 
-#endif // INCLUDED_TEST_HELPER_SHAPEFACTORY_HXX
+#endif // INCLUDED_TEST_HELPER_SHAPE_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 111310] [META] Data statistics bugs and enhancements

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=111310

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||121103


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=121103
[Bug 121103] ANOVA uses wrong formula when on new sheet
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124289] Slow Formula Bar

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124289

stepmo...@ntlworld.com changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |stepmo...@ntlworld.com
   |desktop.org |
 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #4 from stepmo...@ntlworld.com ---
Created attachment 150382
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150382=edit
FlashBack recording

Version: 6.2.1.2 (x64)
Build ID: 7bcb35dc3024a62dea0caee87020152d1ee96e71
CPU threads: 12; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-GB (en_GB); UI-Language: en-GB
Calc: threaded

FlashBack recording attached showing the slow Formula Bar when a) Calc is first
opened, b) after a new cell is selected and c) after hovering in the Formula
Bar for 1 second.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115843] HiDPI images in LibreOffice Writer are blurry with GTK3 backend

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115843

--- Comment #10 from Caolán McNamara  ---
I imagine we've scaled the image down and then upscaled that result up back
again

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83700] UI Window: LibreOffice should use macOS design language and components for drawing window frame

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83700

--- Comment #17 from Maarten Brouwers  ---
Created attachment 150381
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150381=edit
Proposal: move the quickactions to the application title bar (minor)

Selfishly addressing: #124407, but I believe LibreOffice.org is reasonably
close to getting there already. With a generic UI kit you won't get 100% native
experiences. Firefox, Chrome, Spotify, even pricewinning apps like Things and
iA writer, all took a different path and while not in line with mac OS
guidelines they don't look ugly. Above is actually not that far away from
default mac OS apps like the config tool for Audio that is shipped as a default
config screen with macOS. While I agree that LibreOffice.org should look more
like TextEdit and Pages I'm not sure whether LibreOffice.org would ever get
there. Maybe making even bolder departures from the default GUI (like the
earlier mentioned apps) have made is even better.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc vcl/unx

2019-03-28 Thread Caolán McNamara (via logerrit)
 vcl/inc/unx/gtk/gtkframe.hxx  |1 +
 vcl/unx/gtk/gtksalframe.cxx   |   16 
 vcl/unx/gtk/gtksalmenu.cxx|   14 ++
 vcl/unx/gtk3/gtk3gtkframe.cxx |   19 +++
 vcl/unx/gtk3/gtk3gtkinst.cxx  |8 
 5 files changed, 46 insertions(+), 12 deletions(-)

New commits:
commit d8064c1f50fca388d2701a9702be694330ff0bc5
Author: Caolán McNamara 
AuthorDate: Thu Mar 28 16:40:43 2019 +
Commit: Caolán McNamara 
CommitDate: Thu Mar 28 22:07:32 2019 +0100

mapped tooltip before attempting to show a menu is a problem

under wayland, see https://gitlab.gnome.org/GNOME/gtk/issues/1785

Change-Id: I542fb9e81b49144508d5403b2d5ad68a10ed8afe
Reviewed-on: https://gerrit.libreoffice.org/69897
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx
index 9d4f458a75ae..f0d2bd96bc08 100644
--- a/vcl/inc/unx/gtk/gtkframe.hxx
+++ b/vcl/inc/unx/gtk/gtkframe.hxx
@@ -558,6 +558,7 @@ public:
 static sal_uInt16   GetKeyCode(guint nKeyVal);
 static guintGetKeyValFor(GdkKeymap* pKeyMap, guint16 
hardware_keycode, guint8 group);
 static sal_uInt16   GetKeyModCode(guint nState);
+static GdkEvent*makeFakeKeyPress(GtkWidget* pWidget);
 };
 
 #define OOO_TYPE_FIXED ooo_fixed_get_type()
diff --git a/vcl/unx/gtk/gtksalframe.cxx b/vcl/unx/gtk/gtksalframe.cxx
index cdb07829976e..cc95a9f94e51 100644
--- a/vcl/unx/gtk/gtksalframe.cxx
+++ b/vcl/unx/gtk/gtksalframe.cxx
@@ -3614,4 +3614,20 @@ sal_uIntPtr GtkSalFrame::GetNativeWindowHandle()
 return widget_get_xid(m_pWindow);
 }
 
+GdkEvent* GtkSalFrame::makeFakeKeyPress(GtkWidget* pWidget)
+{
+GdkEvent *event = gdk_event_new(GDK_KEY_PRESS);
+event->key.window = 
GDK_WINDOW(g_object_ref(gtk_widget_get_window(pWidget)));
+event->key.send_event = 1 /* TRUE */;
+event->key.time = gtk_get_current_event_time();
+event->key.state = 0;
+event->key.keyval = 0;
+event->key.length = 0;
+event->key.string = nullptr;
+event->key.hardware_keycode = 0;
+event->key.group = 0;
+event->key.is_modifier = false;
+return event;
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/unx/gtk/gtksalmenu.cxx b/vcl/unx/gtk/gtksalmenu.cxx
index 27ba8096bce8..2f85e0710043 100644
--- a/vcl/unx/gtk/gtksalmenu.cxx
+++ b/vcl/unx/gtk/gtksalmenu.cxx
@@ -771,18 +771,8 @@ bool GtkSalMenu::TakeFocus()
 //activated via the keyboard. Doesn't do anything except cause the gtk
 //menubar "keyboard_mode" member to get set to true, so typically mnemonics
 //are shown which will serve as indication that the menubar has focus
-//(given that we wnt to show it with no menus popped down)
-GdkEvent *event = gdk_event_new(GDK_KEY_PRESS);
-event->key.window = 
GDK_WINDOW(g_object_ref(gtk_widget_get_window(mpMenuBarWidget)));
-event->key.send_event = 1 /* TRUE */;
-event->key.time = gtk_get_current_event_time();
-event->key.state = 0;
-event->key.keyval = 0;
-event->key.length = 0;
-event->key.string = nullptr;
-event->key.hardware_keycode = 0;
-event->key.group = 0;
-event->key.is_modifier = false;
+//(given that we want to show it with no menus popped down)
+GdkEvent *event = GtkSalFrame::makeFakeKeyPress(mpMenuBarWidget);
 gtk_widget_event(mpMenuBarWidget, event);
 gdk_event_free(event);
 
diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx
index b1311e207386..ed9895dabdd2 100644
--- a/vcl/unx/gtk3/gtk3gtkframe.cxx
+++ b/vcl/unx/gtk3/gtk3gtkframe.cxx
@@ -4374,4 +4374,23 @@ void 
GtkSalFrame::nopaint_container_resize_children(GtkContainer *pContainer)
 m_bSalObjectSetPosSize = false;
 }
 
+GdkEvent* GtkSalFrame::makeFakeKeyPress(GtkWidget* pWidget)
+{
+GdkEvent *event = gdk_event_new(GDK_KEY_PRESS);
+event->key.window = 
GDK_WINDOW(g_object_ref(gtk_widget_get_window(pWidget)));
+
+GdkSeat *seat = 
gdk_display_get_default_seat(gtk_widget_get_display(pWidget));
+gdk_event_set_device(event, gdk_seat_get_keyboard(seat));
+event->key.send_event = 1 /* TRUE */;
+event->key.time = gtk_get_current_event_time();
+event->key.state = 0;
+event->key.keyval = 0;
+event->key.length = 0;
+event->key.string = nullptr;
+event->key.hardware_keycode = 0;
+event->key.group = 0;
+event->key.is_modifier = false;
+return event;
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 06f0836df779..3b740f7a8985 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -4764,6 +4764,14 @@ public:
static_cast(rRect.GetWidth()), 
static_cast(rRect.GetHeight())};
 if (AllSettings::GetLayoutRTL())
 aRect.x = 

[Libreoffice-commits] core.git: extras/source include/sfx2 include/svx include/vcl sd/source sfx2/source sfx2/uiconfig solenv/bin svx/source sw/source vcl/source vcl/unx

2019-03-28 Thread Caolán McNamara (via logerrit)
 extras/source/glade/libreoffice-catalog.xml.in |7 
 include/sfx2/emojiviewitem.hxx |2 
 include/sfx2/inputdlg.hxx  |2 
 include/sfx2/recentdocsviewitem.hxx|9 
 include/sfx2/templatedlg.hxx   |   86 -
 include/sfx2/templatelocalview.hxx |  121 ++
 include/sfx2/templateviewitem.hxx  |2 
 include/sfx2/thumbnailview.hxx |  184 +++
 include/sfx2/thumbnailviewitem.hxx |6 
 include/svx/SvxPresetListBox.hxx   |2 
 include/svx/charmap.hxx|4 
 include/vcl/customweld.hxx |8 
 include/vcl/layout.hxx |6 
 include/vcl/weld.hxx   |   22 
 sd/source/ui/app/sdmod1.cxx|   11 
 sfx2/source/appl/appopen.cxx   |6 
 sfx2/source/appl/appserv.cxx   |4 
 sfx2/source/control/emojiviewitem.cxx  |2 
 sfx2/source/control/recentdocsviewitem.cxx |7 
 sfx2/source/control/templatelocalview.cxx  |  888 ++
 sfx2/source/control/templatesearchview.cxx |  143 +--
 sfx2/source/control/templateviewitem.cxx   |2 
 sfx2/source/control/thumbnailview.cxx  | 1176 -
 sfx2/source/control/thumbnailviewacc.cxx   |  560 +++
 sfx2/source/control/thumbnailviewacc.hxx   |  112 ++
 sfx2/source/control/thumbnailviewitem.cxx  |2 
 sfx2/source/dialog/inputdlg.cxx|2 
 sfx2/source/doc/templatedlg.cxx|  690 ++
 sfx2/source/inc/templatesearchview.hxx |   13 
 sfx2/source/inc/templatesearchviewitem.hxx |2 
 sfx2/uiconfig/ui/templatedlg.ui|  170 ++-
 solenv/bin/native-code.py  |2 
 svx/source/dialog/charmap.cxx  |4 
 svx/source/tbxctrls/SvxPresetListBox.cxx   |5 
 sw/source/uibase/uiview/view2.cxx  |4 
 vcl/source/app/customweld.cxx  |2 
 vcl/source/app/salvtables.cxx  |   76 +
 vcl/unx/gtk3/gtk3gtkinst.cxx   |  109 +-
 38 files changed, 3785 insertions(+), 668 deletions(-)

New commits:
commit 3e078e17ee2144fb976a7e6b9227152113cea0d4
Author: Caolán McNamara 
AuthorDate: Tue Mar 26 16:27:17 2019 +
Commit: Caolán McNamara 
CommitDate: Thu Mar 28 22:07:06 2019 +0100

weld SfxTemplateManagerDlg

like expert configuration change the gear menu not to display a down 
indicator

and use CommandEvent to distinguish mouse/non-mouse context menus

Change-Id: I64bb660a9c7dacb5b90b240d9d76d29324c5fd9f
Reviewed-on: https://gerrit.libreoffice.org/69893
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/extras/source/glade/libreoffice-catalog.xml.in 
b/extras/source/glade/libreoffice-catalog.xml.in
index abeb0910a2dc..57106338489d 100644
--- a/extras/source/glade/libreoffice-catalog.xml.in
+++ b/extras/source/glade/libreoffice-catalog.xml.in
@@ -134,10 +134,6 @@
 generic-name="Gamma Grid Widget" 
parent="GtkDrawingArea"
 icon-name="widget-gtk-drawingarea"/>
 
-
-
 
@@ -437,9 +433,6 @@
 
-
 
  m_xHelp;
 
 public:
-InputDialog(weld::Window* pParent, const OUString );
+InputDialog(weld::Widget* pParent, const OUString );
 OUString GetEntryText() const;
 void SetEntryText(const OUString& rStr);
 void HideHelpBtn();
diff --git a/include/sfx2/recentdocsviewitem.hxx 
b/include/sfx2/recentdocsviewitem.hxx
index 8320d4710d81..2ee90de19f03 100644
--- a/include/sfx2/recentdocsviewitem.hxx
+++ b/include/sfx2/recentdocsviewitem.hxx
@@ -12,10 +12,15 @@
 
 #include 
 
+namespace sfx2
+{
+class RecentDocsView;
+}
+
 class RecentDocsViewItem final : public ThumbnailViewItem
 {
 public:
-RecentDocsViewItem(ThumbnailView , const OUString ,
+RecentDocsViewItem(sfx2::RecentDocsView , const OUString ,
 const OUString , const BitmapEx& rThumbnail, sal_uInt16 nId, 
long nThumbnailSize);
 
 /** Updates own highlight status based on the aPoint position.
@@ -38,6 +43,8 @@ public:
 void OpenDocument();
 
 private:
+sfx2::RecentDocsView& mrParentView;
+
 /// Return area where is the icon to remove document from the recent 
documents.
 tools::Rectangle getRemoveIconArea() const;
 
diff --git a/include/sfx2/templatedlg.hxx b/include/sfx2/templatedlg.hxx
index 7f730c50161d..5e8a12853419 100644
--- a/include/sfx2/templatedlg.hxx
+++ b/include/sfx2/templatedlg.hxx
@@ -38,18 +38,16 @@ namespace com {
 }   }   }
 }
 
-class SFX2_DLLPUBLIC SfxTemplateManagerDlg : public ModalDialog
+class SFX2_DLLPUBLIC SfxTemplateManagerDlg : public 
weld::GenericDialogController
 {
 typedef bool (*selection_cmp_fn)(const ThumbnailViewItem*,const 
ThumbnailViewItem*);
 
 public:
 
-

[Libreoffice-bugs] [Bug 124314] remove MACRO is not working.

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124314

--- Comment #7 from Luuk  ---
That can (or could?) be true.
There is info in this sheet from 2004, back than i had Excel 2003.

But the message about the macros appeared in LibreOffice 6.2.0.3

A solution to make the message go away, without copying the contents of the
sheet(S) to another workbook would be the best option.

It would be best if this is a LibreOffice solution, because the file is, for
quite some time now, converted by LibreOffice to an .ods file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124409] New: Opening the WriterGuideLO.odt manual is slower in 6.3 compared to 4.4.7.2

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124409

Bug ID: 124409
   Summary: Opening the WriterGuideLO.odt manual is slower in 6.3
compared to 4.4.7.2
   Product: LibreOffice
   Version: 6.3.0.0.alpha0+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Opening the WriterGuideLO.odt manual is slower in 6.3 compared to 4.4.7.2

Steps to Reproduce:
1. Download
https://documentation.libreoffice.org/assets/Uploads/Documentation/en/WG6.0/WG60-WriterGuideLO.odt
2. Open Writer & Enable Automatic Spell check
3. Open the activity monitor
3. Open the file. File opening & spellchecker are noticeable faster in 4.4.7.2

Actual Results:
Until file open: 22 seconds (manual count) 10 second with 4.4.7.2
Spell checker processing 10 seconds with 4.4.7.2 25 with 6.3.0.0 (idle stuff
works different.. so maybe not a full check at once on open; but for every page
when scrolling?

Expected Results:
Fast file opening.. and less process intense spell checking?


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.3.0.0.alpha0+
Build ID: 20ea90a557b5bc744fd234e3a20ab1db484cf88b
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-03-22_03:21:58
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124408] Report builder does not work with aliases and grouping

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124408

--- Comment #1 from John Talbut  ---
Created attachment 150380
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150380=edit
Test database for grouping and aliases

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113499] [META] AutoFill bugs and enhancements

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113499
Bug 113499 depends on bug 115173, which changed state.

Bug 115173 Summary: EDITING: Drag to fill (Replicate) not always accurately 
replicating/updating cell references
https://bugs.documentfoundation.org/show_bug.cgi?id=115173

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115173] EDITING: Drag to fill (Replicate) not always accurately replicating/updating cell references

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115173

Colin  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEEDINFO|RESOLVED

--- Comment #7 from Colin  ---
(In reply to Xisco Faulí from comment #6)
> Hello Colin,
> A new major release of LibreOffice is available since this bug was reported.
> Could you please try to reproduce it with the latest version of LibreOffice
> from https://www.libreoffice.org/download/libreoffice-fresh/ ?
> I have set the bug's status to 'NEEDINFO'. Please change it back to
> 'UNCONFIRMED' if the bug is still present in the latest version.

Hi there, Xisco,
Just tried it with a far more complex "fill" with Release 6.1.5.2 and can no
löonger reproduce the error.
I have changed the status to RESOLVED - WORKS FOR ME. I hope this is the
correct course of action

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124408] New: Report builder does not work with aliases and grouping

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124408

Bug ID: 124408
   Summary: Report builder does not work with aliases and grouping
   Product: LibreOffice
   Version: 6.1.5.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: j...@dpets.uk

Description:
If I use aliases for calculated values in a query and use the aliases in a
report the fields are blank, but I can use grouping for the report.
If I don't use aliases for calculated values in a query and use the generated
names for the fields (e.g. CONCATENATED) in a report the fields shown
correctly, but I if use grouping for the report I get errors when I try to run
the report.

Steps to Reproduce:
1. Using the attached test database, try each of the four reports.  These give
the four different outputs, with and without aliases and with and without
grouping.


Actual Results:
See the reports produced.

Expected Results:
Reports with all fields correct and grouping.


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123473] Tabbed NotebookBar misaligned buttons

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123473

--- Comment #7 from Maarten Brouwers  ---
Confirmed also on macOS; UI render: default, LO 6.2.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123473] Tabbed NotebookBar misaligned buttons

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123473

Maarten Brouwers  changed:

   What|Removed |Added

 CC||freedesktop@murb.nl

--- Comment #6 from Maarten Brouwers  ---
Created attachment 150379
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150379=edit
Tools tab - macOS

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124407] Quickactions overlap with tabbed notebookbar on macOS

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124407

--- Comment #1 from Maarten Brouwers  ---
Created attachment 150378
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150378=edit
Demo overlapping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124407] New: Quickactions overlap with tabbed notebookbar on macOS

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124407

Bug ID: 124407
   Summary: Quickactions overlap with tabbed notebookbar on macOS
   Product: LibreOffice
   Version: 6.2.2.2 release
  Hardware: All
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: freedesktop@murb.nl

Description:
The quickactions (new, open, save, undo, redo, print) overlap with the tabs on
the menu bar. It is somewhat related to #83700 (a generic styling issue on
macOS) and #105290 (not well resizing of the notebookbar)

Steps to Reproduce:
1. Open Writer
2. Resize the window small enough

Actual Results:
Overlapping presentation

Expected Results:
Non overlapping presentation; maybe replace on different row or simply
integrate the buttons with the tabbed bar


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
macOS 10.14.4

occurs both with and without OpenGL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124388] Memory usage for ipsum lorem text (LibO4.4 88 MB; Libo 6.3 155 MB)

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124388

--- Comment #3 from Dieter Praas  ---
(In reply to Telesto from comment #2) 
> I forgot to mention: its the case with dictionary's installed. It's 20 MB
> less without

I have no dictionary installed in master. 73MB in LO 6.2.2.2 with dictionary.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121177] Please change the "paragraph symbol" of "Traditional Chinese version" to "↵"

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121177

--- Comment #12 from Franklin Weng  ---
(In reply to 和尚蟹 from comment #11)
> (In reply to Heiko Tietze from comment #10)
> 
> The issue is, Everyone is used to using "↵".

No.

> In this case, Persist in using "↵" users, Will not use LibreOffice.
> 
I don't think so.  I've never heard anyone complaining about this.

> Please think clearly...
> 
> "↵" is really very important, This is a habit problem.
> Trust me, Changed "↵", LibreOffice's market share, Will definitely increase.
> 

It's Microsoft way, not the standard.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124285] EDITING calculated field display truncates significant digits

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124285

Phil  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEEDINFO|RESOLVED

--- Comment #11 from Phil  ---
update 61xx fixes it.
the v4 update button didn't show update needed. Not a mac issue I think but
updating is the

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117408] Clean up dictionary file headers from licenses and whitespace

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117408

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   ||easyHack, topicCleanup
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #5 from Xisco Faulí  ---
Let's turn this into an easy hack then...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123669] Apple store requires Apple ID to download LibreOffice updates

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123669

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |NEEDINFO

--- Comment #3 from Xisco Faulí  ---
Hello  Dick1955,
is this issue still reproducible as per today ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123641] Emailmerge: can not connect to SMTP server with TLS

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123641

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||xiscofa...@libreoffice.org

--- Comment #5 from Xisco Faulí  ---
Dear Ferry Toth,
Please, answer comment 4 from Justin L.
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the question has been answered

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123672] System font size in LO 6.2

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123672

Xisco Faulí  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

--- Comment #3 from Xisco Faulí  ---
(In reply to Michal Janoušek from comment #2)
> Hello, thnaks very much. In Version 6.2 works well :-)

Thanks for retesting with the latest version.
Setting to RESOLVED WORKSFORME as the commit fixing this issue hasn't been
identified.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122025] Cell format change back cause sum function problem.

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122025

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #4 from Xisco Faulí  ---
Thank you for reporting the bug.
it seems you're using an old version of LibreOffice.
Could you please try to reproduce it with the latest version of LibreOffice
from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123672] System font size in LO 6.2

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123672

Michal Janoušek  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEEDINFO|RESOLVED

--- Comment #2 from Michal Janoušek  ---
Hello, thnaks very much. In Version 6.2 works well :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122829] Images fail to load when many large ones with captions saved as docx FILEOPEN

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122829

Xisco Faulí  changed:

   What|Removed |Added

 Status|REOPENED|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #14 from Xisco Faulí  ---
You can't confirm your own bugs. Moving it back to UNCONFIRMED until someone
else confirms it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63025] Copying chart to Writer looses data/ changes diagram type

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=63025

Xisco Faulí  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME
 CC||xiscofa...@libreoffice.org

--- Comment #14 from Xisco Faulí  ---
(In reply to mahfiaz from comment #13)
> This has been fixed. Works like a charm in 6.1.4.2.

Thanks for retesting with the latest version.
Setting to RESOLVED WORKSFORME as the commit fixing this issue hasn't been
identified.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: test/inc test/source

2019-03-28 Thread Jens Carl (via logerrit)
 test/inc/helper/form.hxx|   17 -
 test/source/helper/form.cxx |   25 +++--
 test/source/view/xcontrolaccess.cxx |5 +++--
 3 files changed, 30 insertions(+), 17 deletions(-)

New commits:
commit 1e2868296730d3548574f61a3c6e323aa5c0598a
Author: Jens Carl 
AuthorDate: Wed Mar 27 19:34:16 2019 +
Commit: Jens Carl 
CommitDate: Thu Mar 28 19:55:35 2019 +0100

Be consistent with namespaces and parameter order for UNO Api helpers

Have this file the same namespaces as the new introduced helpers in
include/test/helper/shape.hxx and also change the order of the parameter
be the same to avoid confusion.

Change-Id: I5614e9a79dff3ee9aca96ff2e50ddfafa83de539
Reviewed-on: https://gerrit.libreoffice.org/69870
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/test/inc/helper/form.hxx b/test/inc/helper/form.hxx
index 173306b118c8..271f06be0b7e 100644
--- a/test/inc/helper/form.hxx
+++ b/test/inc/helper/form.hxx
@@ -22,19 +22,26 @@
 
 namespace apitest
 {
+namespace helper
+{
+namespace form
+{
 /** @brief Create a XControlShape
  *
  * @param r_xComponent  The document.
- * @param nHeight   The height of the shape.
- * @param nWidthThe width of the shape.
+ * @param r_aKind   The kind of the shape.
  * @param nXThe x-position of the shape.
  * @param nYThe y-position of the shape.
- * @param r_aKind   The kind of the shape.
+ * @param nHeight   The height of the shape.
+ * @param nWidthThe width of the shape.
+ * @return  The create XControlShape.
  */
 css::uno::Reference OOO_DLLPUBLIC_TEST 
createControlShape(
-const css::uno::Reference& r_xComponent, const 
sal_Int32 nHeight,
-const sal_Int32 nWidth, const sal_Int32 nX, const sal_Int32 nY, const 
OUString& r_aKind);
+const css::uno::Reference& r_xComponent, const 
OUString& r_aKind,
+const sal_Int32 nX, const sal_Int32 nY, const sal_Int32 nHeight, const 
sal_Int32 nWidth);
 
+} // namespace form
+} // namespace helper
 } // namespace apitest
 
 #endif // INCLUDED_TEST_INC_HELPER_FORM_HXX
diff --git a/test/source/helper/form.cxx b/test/source/helper/form.cxx
index 47da3565f79d..610bd43f1a51 100644
--- a/test/source/helper/form.cxx
+++ b/test/source/helper/form.cxx
@@ -8,6 +8,8 @@
  */
 
 #include 
+#include 
+#include 
 
 #include 
 #include 
@@ -16,19 +18,20 @@
 #include 
 #include 
 
+#include 
 #include 
 
-#include 
-#include 
-
 using namespace css;
 
 namespace apitest
 {
-uno::Reference
-createControlShape(const uno::Reference& r_xComponent, const 
sal_Int32 nHeight,
-   const sal_Int32 nWidth, const sal_Int32 nX, const sal_Int32 
nY,
-   const OUString& r_aKind)
+namespace helper
+{
+namespace form
+{
+uno::Reference OOO_DLLPUBLIC_TEST createControlShape(
+const uno::Reference& r_xComponent, const OUString& 
r_aKind,
+const sal_Int32 nX, const sal_Int32 nY, const sal_Int32 nHeight, const 
sal_Int32 nWidth)
 {
 uno::Reference xMSF(r_xComponent, 
uno::UNO_QUERY_THROW);
 
@@ -38,9 +41,8 @@ createControlShape(const uno::Reference& 
r_xComponent, const s
 uno::Reference aComponent(
 xMSF->createInstance("com.sun.star.form.component." + r_aKind), 
uno::UNO_QUERY_THROW);
 uno::Reference xPropertySet(aComponent, 
uno::UNO_QUERY_THROW);
-uno::Any aValue;
-aValue <<= "com.sun.star.form.control." + r_aKind;
-xPropertySet->setPropertyValue("DefaultControl", aValue);
+xPropertySet->setPropertyValue("DefaultControl",
+   uno::makeAny("com.sun.star.form.control." + 
r_aKind));
 uno::Reference xControlModel(aComponent, 
uno::UNO_QUERY_THROW);
 
 xControlShape->setSize(awt::Size(nHeight, nWidth));
@@ -50,6 +52,9 @@ createControlShape(const uno::Reference& 
r_xComponent, const s
 
 return xControlShape;
 }
+
+} // namespace form
+} // namespace helper
 } // namespace apitest
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/test/source/view/xcontrolaccess.cxx 
b/test/source/view/xcontrolaccess.cxx
index 29ca1fa339aa..5f00e88a5f63 100644
--- a/test/source/view/xcontrolaccess.cxx
+++ b/test/source/view/xcontrolaccess.cxx
@@ -21,10 +21,11 @@
 #include 
 #include 
 
+#include 
+
 #include 
 
 using namespace css;
-using namespace css::uno;
 
 namespace apitest
 {
@@ -39,7 +40,7 @@ void XControlAccess::testGetControl()
 
 uno::Reference xShapes(xDP, uno::UNO_QUERY_THROW);
 uno::Reference xShape(
-createControlShape(xComponent, 100, 100, 1, 5, 
"CommandButton"),
+helper::form::createControlShape(xComponent, "CommandButton", 1, 
5, 100, 100),
 uno::UNO_QUERY_THROW);
 
 xShapes->add(xShape);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-bugs] [Bug 121792] Main table inherits table style of the inserted embedded table

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121792

Xisco Faulí  changed:

   What|Removed |Added

 CC||rayk...@gmail.com,
   ||s.mehrbr...@gmail.com

--- Comment #5 from Xisco Faulí  ---
@Samuel, @Jim, I thought you might be interested in this issue...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121792] Main table inherits table style of the inserted embedded table

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121792

Xisco Faulí  changed:

   What|Removed |Added

   Assignee|furkantoka...@gmail.com |libreoffice-b...@lists.free
   ||desktop.org
 Status|ASSIGNED|NEW

--- Comment #4 from Xisco Faulí  ---
Dear Furkan Tokac,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assigned it back to yourself if you're still working on this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115173] EDITING: Drag to fill (Replicate) not always accurately replicating/updating cell references

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115173

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |NEEDINFO

--- Comment #6 from Xisco Faulí  ---
Hello Colin,
A new major release of LibreOffice is available since this bug was reported.
Could you please try to reproduce it with the latest version of LibreOffice
from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123661] add "copy result to new sheet" for filter and sort functions

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123661

--- Comment #2 from m.a.riosv  ---
Even if can be done easily (create a new sheet and set up in the filter as
destination), maybe in some situations it's useful and quicker.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105500

--- Comment #20 from Telesto  ---
Repro with
Version: 6.3.0.0.alpha0+
Build ID: 20ea90a557b5bc744fd234e3a20ab1db484cf88b
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-03-22_03:21:58
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45820] insanely slow wmf import (complex clipping and basegfx::tools::findCuts)

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45820

--- Comment #19 from Telesto  ---
Repro
Version: 6.3.0.0.alpha0+
Build ID: 20ea90a557b5bc744fd234e3a20ab1db484cf88b
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-03-22_03:21:58
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122864] Navigator view, while an entry is being dragged, all its respective bar positions are kept displayed despite dragged positions do not match any more.

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122864

Buovjaga  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #5 from Buovjaga  ---
Please test with 6.2.x
If you are unable to do it otherwise, use an appimage:
https://libreoffice.soluzioniopen.com/

Set to NEEDINFO.
Change back to UNCONFIRMED, if the problem persists. Change to RESOLVED
WORKSFORME, if the problem went away.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124396] The setting for the storage dialog (LibreOffice or WindowsStandard) is missing

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124396

Oliver Brinzing  changed:

   What|Removed |Added

 CC||oliver.brinz...@gmx.de
 Resolution|--- |NOTABUG
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Oliver Brinzing  ---
this setting has been moved to expert configuration:

Tools/Options.../LibreOffice/Advanced
-> [Open Expert Configuration]

search for: UseSystemFileDialog

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 60425] Slow document scrolling due to WMF/EMF picture

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=60425

--- Comment #9 from Telesto  ---
Repro
Version: 6.3.0.0.alpha0+
Build ID: 20ea90a557b5bc744fd234e3a20ab1db484cf88b
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-03-22_03:21:58
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124388] Memory usage for ipsum lorem text (LibO4.4 88 MB; Libo 6.3 155 MB)

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124388

--- Comment #2 from Telesto  ---
(In reply to Dieter Praas from comment #1)
> I can't confirm it; 42 MB with
> 
> Version: 6.3.0.0.alpha0+ (x64)
> Build ID: 91cdf22b88a4f7bec243c8fb187627e766d3294c
> CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
> TinderBox: Win-x86_64@42, Branch:master, Time: 2019-03-08_00:38:10
> Locale: en-US (de_DE); UI-Language: en-US
> Calc: threaded

Thanks for testing.. Hmm.. odd. X64 mostly uses some more memory, instead of
less.. 
I forgot to mention: its the case with dictionary's installed. It's 20 MB less
without

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122864] Navigator view, while an entry is being dragged, all its respective bar positions are kept displayed despite dragged positions do not match any more.

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122864

--- Comment #4 from Jim Raykowski  ---
I have seen this behavior before but am unable to repro with any release
installs or dev builds I have at this time. 

I only get the drop bar when using gtk2 and win VCL backend.

Version: 6.3.0.0.alpha0+
Build ID: e2f227fa6f0ae0588ac033f772fb5dda5433bda4
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

Version: 6.2.0.2 (x64)
Build ID: 2ce5217b30a543f7666022df50f0562f82be0cff
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win;
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123360] Antialiasing not great for PNG images depending on zoomlevel without OpenGL enabled

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123360

--- Comment #4 from Telesto  ---
(In reply to Luboš Luňák from comment #3)
> - This only shows with OpenGL disabled either on Windows, or on Linux with
> the "gen" vcl plugin (SAL_DISABLEGL=1 SAL_USE_VCLPLUGIN=gen). So this
> shouldn't be a dependency of the VCL-OpenGL bugreport. Given that we default
> to OpenGL on Windows and on Linux pretty much nobody uses the gen plugin,
> most users shouldn't be affected.

Small note on that. The default is OpenGL. However the driver blacklist is
quite long. For example: Intel OpenGL issues where fixed by blacklisting them
(not quite up to date with the current situation, though).

The crash reporter shows quite some report on Windows without OpenGL enabled,
but could be a coincidence. Some states would be nice :-).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124379] libre calc does not sort

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124379

Oliver Brinzing  changed:

   What|Removed |Added

 CC||oliver.brinz...@gmx.de
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #4 from Oliver Brinzing  ---
Thank you for reporting the bug. 

Please add a detailed description how the bug can be reproduced, e.g.:

- select range: B1:G200
- Menu Data/Sort...
- ...

I have set the bug's status to 'NEEDINFO'. 
Please change it back to 'UNCONFIRMED' once the requested info is provided.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65872] EDITING: LibreOffice should not prompt with dialog every time the Paste keyboard shortcut or menu paste option is chosen

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=65872

--- Comment #19 from Marcel Partap  ---
This dialog should not even exist; 'automatic' should be the default and all
the options in there should go to the 'paste special' dialogue.
Does this need a bounty for someone to implement it, or what is causing the
delay fixing this issue of 
> Importance:   high
? If there is a lack of clarity among you LO devs, please inquire.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124355] Crash in: vcl::Window::DecModalCount()

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124355

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
@Luigi,
Thank you for reporting the bug. To be certain the reported issue is not
related to corruption in the user profile, could you please reset your
Libreoffice profile ( https://wiki.documentfoundation.org/UserProfile ) and
re-test?

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the issue is still present

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124397] FILEOPEN DOCX Deleting text frame from DOCX crashes LibreOffice Writer

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124397

--- Comment #8 from Julien Nabet  ---
Created attachment 150377
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150377=edit
console logs + bt

On pc Debian x86-64 with master sources updated today, I could reproduce this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124355] Crash in: vcl::Window::DecModalCount()

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124355

Xisco Faulí  changed:

   What|Removed |Added

Crash report or||["vcl::Window::DecModalCoun
crash signature||t()"]
   See Also||https://crashreport.libreof
   ||fice.org/stats/signature/vc
   ||l::Window::DecModalCount()

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124388] Memory usage for ipsum lorem text (LibO4.4 88 MB; Libo 6.3 155 MB)

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124388

Xisco Faulí  changed:

   What|Removed |Added

   Severity|normal  |trivial
   Priority|medium  |lowest
 CC||xiscofa...@libreoffice.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124386] Don't show all symbols

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124386

Xisco Faulí  changed:

   What|Removed |Added

 CC||caol...@redhat.com
Version|6.2.2.2 release |5.3.7.2 release

--- Comment #4 from Xisco Faulí  ---
Also reproduced in

Versión: 5.3.7.2
Id. de compilación: 6b8ed514a9f8b44d37a1b96673cbbdd077e24059
Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; Motor de trazado:
HarfBuzz; 
Configuración regional: es-ES (es_ES); Calc: group

@Caolán, any idea why the scrollbar doesn't work on Win unless the dialog is
resized ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124348] EDITING - incorrect cell contents

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124348

Oliver Brinzing  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|NEW |RESOLVED

--- Comment #4 from Oliver Brinzing  ---
that not a bug, it's a feature ;-)

please have a look at the attachment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124348] EDITING - incorrect cell contents

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124348

Oliver Brinzing  changed:

   What|Removed |Added

 CC||oliver.brinz...@gmx.de

--- Comment #3 from Oliver Brinzing  ---
Created attachment 150376
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150376=edit
cell properties

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123371] Macros are extremely slow in 6.2

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123371

Xisco Faulí  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

--- Comment #11 from Xisco Faulí  ---
(In reply to Alan from comment #10)
> Installed 6.2.2.2 from Ubuntu's repro. The issue is gone, macros take the
> right amount of time. Bug closed for me.
> Thanks!

Thanks for retesting with the latest version.
Setting to RESOLVED WORKSFORME as the commit fixing this issue hasn't been
identified.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124386] Don't show all symbols

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124386

--- Comment #3 from Xisco Faulí  ---
mmm, the scroll works if the dialog is resized...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123371] Macros are extremely slow in 6.2

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123371

Alan  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEEDINFO|RESOLVED

--- Comment #10 from Alan  ---
Installed 6.2.2.2 from Ubuntu's repro. The issue is gone, macros take the right
amount of time. Bug closed for me.
Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124386] Don't show all symbols

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124386

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
 OS|All |Windows (All)
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Xisco Faulí  ---
Win only.
I can reproduce it in

Versión: 6.2.2.2
Id. de compilación: 2b840030fec2aae0fd2658d8d4f9548af4e3518d
Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; VCL: win; 
Configuración regional: es-ES (es_ES); Idioma de IU: es-ES
Calc: threaded

but not in

Version: 6.3.0.0.alpha0+
Build ID: e74de110d16c95414fac7541c8fe6541d4597113
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

On win, the scroll doesn't work

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: [Libreoffice-qa] minutes of ESC call ...

2019-03-28 Thread Markus Mohrhard
Hey Michael, all,

On Fri, Mar 29, 2019 at 12:44 AM Michael Meeks 
wrote:

> Hi Markus,
>
> On 28/03/2019 16:13, Markus Mohrhard wrote:
> > so in general the fastest way to get some feedback might be to ping me
> > directly and give me some time to look into such issues. While I still
> > have quite bad internet and can't do any uploads of symbol information I
> > can still at least quickly inspect the problem.
>
> That would be wonderful ! =)
>


This one was caused by a missing symbol extraction after symbol upload. I
could not find any reason in the log files that explains why the upload of
the symbols would succeed but the unziping of the uploaded file would fail.
As a result the symbol information for most of our own symbols were missing.

After a manual extraction I can see at least most of the libmerged symbols
being resolved when I call minidump_stackwalk manually on the server.
However, the mentioned symbol information issue still remains and in some
cases where the top level stack frame is in a system library we still miss
some resolved stack frames.

Regards,
Markus


> > One general problem that we have is that we have no recent windows debug
> > symbol information. I tried to move that service from my local machine
> > to the server during the Munich hackfest but did not manage to replicate
> > my setup well enough that valid symbol information are generated. Sadly
> > this has some knock-on effects as can be seen by some of the unresolved
> > crash reports. At least on Windows getting a backtrace requires that
> > enough of the stack pointers can be guessed from the dumped stack. This
> > relies to some to degree on the system symbol informations.
>
> Interesting.
>
> > As soon as I have a non-mobile internet connection again I'll either run
> > a full set of system symbol download on my machine or finish the work on
> > moving that service to the server.
>
> Much appreciated ! our top crasher is (obviously) the one without
> any
> symbol information that lurks in libmerged currently ;-)
>
> Regards,
>
> Michael.
>
> --
> michael.me...@collabora.com <><, GM Collabora Productivity
> Hangout: mejme...@gmail.com, Skype: mmeeks
> (M) +44 7795 666 147 - timezone usually UK / Europe
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 124405] LibreWriter Changed the graph saved in a .docx word file

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124405

A.K.  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124405] LibreWriter Changed the graph saved in a .docx word file

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124405

--- Comment #2 from A.K.  ---
Created attachment 150375
  --> https://bugs.documentfoundation.org/attachment.cgi?id=150375=edit
The word document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 35092] Inking functionality: Ink drawings / annotations with Stylus, Pen or Finger on Touchscreen or Tablet

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=35092

--- Comment #15 from Charles Heath  ---
In principle, I agree with Yiyan because I also think there is a need to
include handwriting functionality in the LibreOffice product. When I was
engaged in essay writing help https://ca.edubirdie.com/essay-writing-help,
there was always a need for minor corrections for which handwritten water would
be the ideal solution. For me, such a decision would make the LibreOffice, a
step forward to perfection.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124289] Slow Formula Bar

2019-03-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124289

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #3 from Xisco Faulí  ---
Could you please paste the info from Help - about LibreOffice ?

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the information has been provided

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

  1   2   3   4   5   >