[Libreoffice-bugs] [Bug 106653] RTL Arabic justified text has some gaps between characters
https://bugs.documentfoundation.org/show_bug.cgi?id=106653 --- Comment #17 from Babak Razmjoo --- Created attachment 150527 --> https://bugs.documentfoundation.org/attachment.cgi?id=150527=edit The PDF generated by LibreOffice 6.2.2.2 from the previous file Everything is OK with this PDF,too -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106653] RTL Arabic justified text has some gaps between characters
https://bugs.documentfoundation.org/show_bug.cgi?id=106653 --- Comment #16 from Babak Razmjoo --- Created attachment 150526 --> https://bugs.documentfoundation.org/attachment.cgi?id=150526=edit The PDF generated by LibreOffice 6.1.5.2 from the previous file Everything is OK in this PDF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106653] RTL Arabic justified text has some gaps between characters
https://bugs.documentfoundation.org/show_bug.cgi?id=106653 --- Comment #15 from Babak Razmjoo --- Created attachment 150525 --> https://bugs.documentfoundation.org/attachment.cgi?id=150525=edit A repeated text in Farsi with several fonts -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124531] PostgreSQL Native Driver: Unable to create view through Base-GUI
https://bugs.documentfoundation.org/show_bug.cgi?id=124531 --- Comment #3 from Alex Thurgood --- Confirming also with Version: 6.1.5.2 Build ID: 90f8dcf33c87b3705e78202e3df5142b201bd805 Threads CPU : 4; OS : Mac OS X 10.14.4; UI Render : par défaut; Locale : fr-FR (fr_FR.UTF-8); Calc: group threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: minutes of ESC call ...
Hi, + 6.1.6 rc1: April 9 next week > + Most pressing bugs: Could someone please take a look at issue crash: use of "com.sun.star.ui.dialogs.FolderPicker" service from java seems to cause crashes https://bugs.documentfoundation.org/show_bug.cgi?id=123502 it affects windows 7/10 and is reproducible with LO 6.1.5.2 but not with LO 6.1.4.2. Regards Oliver ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 123502] crash: use of "com.sun.star.ui.dialogs.FolderPicker" service from java seems to cause crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=123502 Oliver Brinzing changed: What|Removed |Added Keywords||bibisected, bisected OS|All |Windows (All) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: configure.ac vcl/headless vcl/source
configure.ac |2 +-
vcl/headless/svpgdi.cxx | 23 ++-
vcl/source/bitmap/BitmapTools.cxx |4
3 files changed, 27 insertions(+), 2 deletions(-)
New commits:
commit 3c6c56b107d71d5f4790be0b76299e8f215f88cc
Author: Caolán McNamara
AuthorDate: Thu Apr 4 15:56:29 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 4 18:07:53 2019 +0200
Revert "raise cairo baseline to 1.12.0"
This reverts commit 50580f452cc7c88a231831619a3f05958ce56460.
Revert "raise cairo baseline to 1.10.0"
This reverts commit 58a0e60dee0d27a699f856827c20b792417d3478.
32bit baseline is currently at cairo 1.8.8
Change-Id: I5156df6aee03dbbb2e209dbd5717a98580256170
Reviewed-on: https://gerrit.libreoffice.org/70260
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/configure.ac b/configure.ac
index 02ea8809de4b..befe75bbac3a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -11600,7 +11600,7 @@ if test "$test_cairo" = "yes"; then
SYSTEM_CAIRO=TRUE
AC_MSG_RESULT([yes])
-PKG_CHECK_MODULES( CAIRO, cairo >= 1.12.0 )
+PKG_CHECK_MODULES( CAIRO, cairo >= 1.8.0 )
CAIRO_CFLAGS=$(printf '%s' "$CAIRO_CFLAGS" | sed -e
"s/-I/${ISYSTEM?}/g")
FilterLibs "${CAIRO_LIBS}"
CAIRO_LIBS="${filteredlibs}"
diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index b072bf946cdc..2cf49ca17696 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -47,6 +47,12 @@
#include
#include
+#if ENABLE_CAIRO_CANVAS
+# if defined CAIRO_VERSION && CAIRO_VERSION < CAIRO_VERSION_ENCODE(1, 10, 0)
+# define CAIRO_OPERATOR_DIFFERENCE (static_cast(23))
+# endif
+#endif
+
namespace
{
basegfx::B2DRange getClipBox(cairo_t* cr)
@@ -1739,7 +1745,11 @@ std::shared_ptr SvpSalGraphics::getBitmap(
long nX, long nY, long nWi
Color SvpSalGraphics::getPixel( long nX, long nY )
{
+#if CAIRO_VERSION >= CAIRO_VERSION_ENCODE(1, 12, 0)
cairo_surface_t *target = cairo_surface_create_similar_image(m_pSurface,
CAIRO_FORMAT_ARGB32, 1, 1);
+#else
+cairo_surface_t *target = cairo_image_surface_create(CAIRO_FORMAT_ARGB32,
1, 1);
+#endif
cairo_t* cr = cairo_create(target);
@@ -1795,7 +1805,14 @@ void SvpSalGraphics::invert(const basegfx::B2DPolygon
, SalInvert nFlags)
cairo_set_source_rgb(cr, 1.0, 1.0, 1.0);
-cairo_set_operator(cr, CAIRO_OPERATOR_DIFFERENCE);
+if (cairo_version() >= CAIRO_VERSION_ENCODE(1, 10, 0))
+{
+cairo_set_operator(cr, CAIRO_OPERATOR_DIFFERENCE);
+}
+else
+{
+SAL_WARN("vcl.gdi", "SvpSalGraphics::invert, archaic cairo");
+}
if (nFlags & SalInvert::TrackFrame)
{
@@ -1973,7 +1990,11 @@ cairo_surface_t*
SvpSalGraphics::createCairoSurface(const BitmapBuffer *pBuffer)
cairo_t* SvpSalGraphics::createTmpCompatibleCairoContext() const
{
+#if CAIRO_VERSION >= CAIRO_VERSION_ENCODE(1, 12, 0)
cairo_surface_t *target = cairo_surface_create_similar_image(m_pSurface,
+#else
+cairo_surface_t *target = cairo_image_surface_create(
+#endif
CAIRO_FORMAT_ARGB32,
m_aFrameSize.getX() * m_fScale,
m_aFrameSize.getY() * m_fScale);
diff --git a/vcl/source/bitmap/BitmapTools.cxx
b/vcl/source/bitmap/BitmapTools.cxx
index 212557d3c28a..6f14c3526d42 100644
--- a/vcl/source/bitmap/BitmapTools.cxx
+++ b/vcl/source/bitmap/BitmapTools.cxx
@@ -236,7 +236,11 @@ BitmapEx* CreateFromCairoSurface(Size aSize,
cairo_surface_t * pSurface)
// FIXME: if we could teach VCL/ about cairo handles, life could
// be significantly better here perhaps.
+#if CAIRO_VERSION >= CAIRO_VERSION_ENCODE(1, 12, 0)
cairo_surface_t *pPixels = cairo_surface_create_similar_image(pSurface,
+#else
+cairo_surface_t *pPixels = cairo_image_surface_create(
+#endif
CAIRO_FORMAT_ARGB32, aSize.Width(), aSize.Height());
cairo_t *pCairo = cairo_create( pPixels );
if( !pPixels || !pCairo || cairo_status(pCairo) != CAIRO_STATUS_SUCCESS )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 124550] New: In Writer, when a mail merge document has different header/footer on a first page, final merged document has page headers messed up
https://bugs.documentfoundation.org/show_bug.cgi?id=124550 Bug ID: 124550 Summary: In Writer, when a mail merge document has different header/footer on a first page, final merged document has page headers messed up Product: LibreOffice Version: 6.1.5.2 release Hardware: x86 (IA32) OS: Mac OS X (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sma...@email.t-com.hr Description: Mailmerge data is stored in a ODS, ODS is registered as a data source, and then displayed within Writer using View | Data Sources. Mail Merge toolbar is shown using View | Toolbars | Mail merge. Mail merge document is formed, with different page style for the first page. The first page has a bitmap image as a part of page header, other pages don't. After defining mail merge fields within mail merge document, clicking on "Save merged documents" (on the MM toolbar), and then choosing "save as one large document" renders a document that doesn't replicate the first page style in proper places. Clicking on "Edit individual documents" opens up a document that has correct first page styles for all mailmerge instances but the first one. The first instance (for the first data row from ODS) uses first page style for all pages... I used this same workflow 6 months ago and it worked OK then, I think, but I can't remember which version did I use then. Steps to Reproduce: 1. create a mail merge document in writer, having a different first page style (i.e. different first page header) 2. save merged documents as one big document - no first page style is replicated 3. edit individual documents - first page style is replicated in all instances but the first one. Actual Results: Merged documents with first page headers messed up in one way or the other Expected Results: Merged documents with proper first page styles Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Workaround - use "Edit individual documents", in the dataset repeat the first data row twice, and in final document delete the first instance manually. Version: 6.1.5.2 Build ID: 90f8dcf33c87b3705e78202e3df5142b201bd805 CPU threads: 8; OS: Mac OS X 10.13.6; UI render: default; Locale: hr-HR (en_HR.UTF-8); Calc: group threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119749] FILESAVE: xlsx files with "freeze panes" cause an error in MS Office if saved in CODE
https://bugs.documentfoundation.org/show_bug.cgi?id=119749 Aron Budea changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Whiteboard||target:6.3.0 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||6858 --- Comment #1 from Aron Budea --- The corruption issue should be fixed by the following commit, it will be part of the next version of CODE as well. Ultimately implementing frozen rows/columns in online would be the best solution, but that'll require more work. The feature is tracked in bug 116858. https://cgit.freedesktop.org/libreoffice/core/commit/?id=0ef7bc8a1d2f00715d6849f1bbceb26e32382d41 author Henry Castro 2019-03-29 09:01:05 -0400 committer Henry Castro 2019-04-01 17:57:45 +0200 sc lok: avoid save incorrect data, whether the pane has ... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116858] [Feature Request] View > Freeze Cells > Freeze Rows and Columns
https://bugs.documentfoundation.org/show_bug.cgi?id=116858 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||9749 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124549] New: Currently active fill mode button on Area tab can be deactivated by clicking on it
https://bugs.documentfoundation.org/show_bug.cgi?id=124549 Bug ID: 124549 Summary: Currently active fill mode button on Area tab can be deactivated by clicking on it Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Keywords: difficultyBeginner, easyHack, skillCpp, topicUI Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com Clicking on a currently active fill mode toggle button on "Area" tab deactivates that button, leaving no active button in the group. E.g., open a Page Style dialog on the Area tab; select Color button (so it is pressed). Click it second time => it gets deactivated (not pressed) - but still focused; now click on Palette combobox below, which moves focus. Now all the buttons in the fill mode group look identically inactive, despite in reality, Color mode is active. The problem is that clicking the toggle button should never toggle it off - so a click handler is needed for the toggle buttons in SvxAreaTabPage class (cui/source/tabpages/tparea.cxx), which would check the new status and return to active status if needed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124356] Shift key is accepted as input and clears cell content in KDE
https://bugs.documentfoundation.org/show_bug.cgi?id=124356 --- Comment #14 from Michael Weghorn --- (In reply to Owen Savill from comment #13) > I have noticed that most meta keys do the same thing, those I've found so > far are Tab, Ctrl, Alt, Alt Gr and both shift keys. So instead of moving the selection one cell to the right, Tab clears the content of the current cell? That's really odd and I'm running out of ideas... What keyboard layout are you using? What distro and what architecture (x86/x86_64)? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)
https://bugs.documentfoundation.org/show_bug.cgi?id=49033 V Stuart Foote changed: What|Removed |Added CC||jl...@mail.com --- Comment #56 from V Stuart Foote --- (In reply to Heiko Tietze from comment #55) > > Seems we agree on the required change. Cycle case should work on the > selection and if there is none on the full sentence (as today). OK, we should proceed--apply SENTENCE_CASE with a bimodal behavior [ selection | no selection ]. But, Mike K's list of questions from comment 34 need a resolution. Also there is Justin L's work on bug 63529 and his abandoned https://gerrit.libreoffice.org/#/c/33581/ which tweaked word boundaries and proposed some control over the transliteration sequence depending on current state. Should we address that from UX perspective--or let it be, and just be satisfied here with consistent "bimodal" selection handling of the fixed transliteration sequence for caserotate.cxx, i.e.: TITLE_CASE -> SENTENCE_CASE -> LOWERCASE_UPPERCASE -> UPPERCASE_LOWERCASE; -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109244] Undo fails to recreate fieldmarks in converted document
https://bugs.documentfoundation.org/show_bug.cgi?id=109244 Phil Krylov changed: What|Removed |Added Blocks||107739 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107739 [Bug 107739] [META] Field bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107739] [META] Field bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107739 Phil Krylov changed: What|Removed |Added Depends on||109244 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=109244 [Bug 109244] Undo fails to recreate fieldmarks in converted document -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107739] [META] Field bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107739 Phil Krylov changed: What|Removed |Added Depends on||116960 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=116960 [Bug 116960] Fieldmarks can't be enumerated via getTextFields / getBookmarks -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116960] Fieldmarks can't be enumerated via getTextFields / getBookmarks
https://bugs.documentfoundation.org/show_bug.cgi?id=116960 Phil Krylov changed: What|Removed |Added Blocks||107739 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107739 [Bug 107739] [META] Field bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124496] Adding diagonal borders to cells while EDITING calc file messes the file
https://bugs.documentfoundation.org/show_bug.cgi?id=124496 Xisco Faulí changed: What|Removed |Added Summary|Adding diagonal borders to |Adding diagonal borders to |cells while EDITING calc|cells while EDITING calc |file messes the file and|file messes the file |causes calc to crash| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124548] Activating Area tab, "None" is always focused, regardless of which fill type is selected
https://bugs.documentfoundation.org/show_bug.cgi?id=124548 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org Keywords||topicUI -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948 Bug 105948 depends on bug 120754, which changed state. Bug 120754 Summary: Crashes on UNDO https://bugs.documentfoundation.org/show_bug.cgi?id=120754 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2-3' - sc/source
sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
New commits:
commit 7708861765dae49a60386774970db21e598be7c1
Author: Jaromir Wysoglad
AuthorDate: Thu Mar 28 19:55:23 2019 +0100
Commit: Michael Weghorn
CommitDate: Thu Apr 4 17:28:23 2019 +0200
tdf#121103 ANOVA sum of squares formula correction
The ANOVA sum of squares is now hardcoded to use '$Sheet?' in the
source cell addless every time.
Change-Id: I215b719be11ecfc2ae20c5df8e86876bc22d50f0
Reviewed-on: https://gerrit.libreoffice.org/69899
Tested-by: Jenkins
Reviewed-by: Eike Rathke
(cherry picked from commit 66c08a0d308fd6119460546a906434bbc9d23c2e)
Reviewed-on: https://gerrit.libreoffice.org/70153
(cherry picked from commit 205f9756f70fe32db169d6f81795f4c66382d014)
Reviewed-on: https://gerrit.libreoffice.org/70183
Reviewed-by: Xisco Faulí
Reviewed-by: Michael Weghorn
Tested-by: Michael Weghorn
diff --git a/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx
b/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx
index a655c8c1bd51..1f823fae8204 100644
--- a/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx
@@ -67,7 +67,7 @@ OUString lclCreateMultiParameterFormula(
OUStringBuffer aResult;
for (size_t i = 0; i < aRangeList.size(); i++)
{
-OUString aRangeString(aRangeList[i].Format(ScRefFlags::RANGE_ABS,
pDocument, aAddressDetails));
+OUString aRangeString(aRangeList[i].Format(ScRefFlags::RANGE_ABS_3D,
pDocument, aAddressDetails));
OUString aFormulaString = aFormulaTemplate.replaceAll(aWildcard,
aRangeString);
aResult.append(aFormulaString);
if(i != aRangeList.size() - 1) // Not Last
@@ -260,7 +260,6 @@ void
ScAnalysisOfVarianceDialog::AnovaSingleFactor(AddressWalkerWriter& output,
output.nextColumn();
// Sum of Squares
-
aTemplate.setTemplate("=SUMPRODUCT(%SUM_RANGE%;%MEAN_RANGE%)-SUM(%SUM_RANGE%)^2/SUM(%COUNT_RANGE%)");
aTemplate.autoReplaceAddress("%BETWEEN_SS%", output.current());
output.writeFormula(aTemplate.getTemplate());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svx/source
svx/source/svdraw/svdundo.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit b8c49b1d4d4debd86c4b944b0bb2ba020ef1b030
Author: Caolán McNamara
AuthorDate: Thu Apr 4 12:22:06 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 4 17:21:46 2019 +0200
Resolves: tdf#120754 on undoing an obj insert use its current ordinal
there may have been changes not caught by undo to the object's
ordinal, so on use of RemoveObject (or ReplaceObject) call GetOrdNum
on the object to get its current position within its parent.
We can keep nOrdNum for the desired dest position within the parent
for InsertObject
Change-Id: I3bdabf387dd630fc1fadaaa1f3d8c05e93865e4f
Reviewed-on: https://gerrit.libreoffice.org/70251
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/svx/source/svdraw/svdundo.cxx b/svx/source/svdraw/svdundo.cxx
index 61b829b95249..300bcdb3a814 100644
--- a/svx/source/svdraw/svdundo.cxx
+++ b/svx/source/svdraw/svdundo.cxx
@@ -707,7 +707,7 @@ void SdrUndoRemoveObj::Redo()
{
ImplUnmarkObject( pObj );
E3DModifySceneSnapRectUpdater aUpdater(pObj);
-pObjList->RemoveObject(nOrdNum);
+pObjList->RemoveObject(pObj->GetOrdNum());
}
// Trigger PageChangeCall
@@ -729,7 +729,7 @@ void SdrUndoInsertObj::Undo()
{
ImplUnmarkObject( pObj );
-SdrObject* pChkObj= pObjList->RemoveObject(nOrdNum);
+SdrObject* pChkObj= pObjList->RemoveObject(pObj->GetOrdNum());
DBG_ASSERT(pChkObj==pObj,"UndoInsertObj: RemoveObjNum!=pObj");
}
}
@@ -885,7 +885,7 @@ void SdrUndoReplaceObj::Undo()
SetNewOwner(true);
ImplUnmarkObject( pNewObj );
-pObjList->ReplaceObject(pObj,nOrdNum);
+pObjList->ReplaceObject(pObj,pNewObj->GetOrdNum());
}
else
{
@@ -903,7 +903,7 @@ void SdrUndoReplaceObj::Redo()
SetNewOwner(false);
ImplUnmarkObject( pObj );
-pObjList->ReplaceObject(pNewObj,nOrdNum);
+pObjList->ReplaceObject(pNewObj,pObj->GetOrdNum());
}
else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 113335] [META] XLSX (OOXML) hyperlink bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=113335 Gabor Kelemen changed: What|Removed |Added Depends on||91634 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=91634 [Bug 91634] FILESAVE : XLSX Image hyperlink is not exported after roundtrip. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65136] FILESAVE, FILEOPEN: XLS, XLSX partial-cell hyperlink is reloaded as full-cell hyperlink
https://bugs.documentfoundation.org/show_bug.cgi?id=65136 --- Comment #10 from Gabor Kelemen --- A sane sounding proposal from the duplicate bug #112325 : It would be nice if a configuration option is introduced that allows to only add one hyper-link into a Cell for a specific spread sheet file. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120543] [META] Bugs and enhancements around hyperlinks in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=120543 Bug 120543 depends on bug 112325, which changed state. Bug 112325 Summary: FILESAVE XLSX Hyperlinks disappear randomly https://bugs.documentfoundation.org/show_bug.cgi?id=112325 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65136] FILESAVE, FILEOPEN: XLS, XLSX partial-cell hyperlink is reloaded as full-cell hyperlink
https://bugs.documentfoundation.org/show_bug.cgi?id=65136 Gabor Kelemen changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||2325 CC||cmflatsc...@yahoo.com --- Comment #9 from Gabor Kelemen --- *** Bug 112325 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112325] FILESAVE XLSX Hyperlinks disappear randomly
https://bugs.documentfoundation.org/show_bug.cgi?id=112325 Gabor Kelemen changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=65 ||136 --- Comment #12 from Gabor Kelemen --- *** This bug has been marked as a duplicate of bug 65136 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113335] [META] XLSX (OOXML) hyperlink bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=113335 Bug 113335 depends on bug 112325, which changed state. Bug 112325 Summary: FILESAVE XLSX Hyperlinks disappear randomly https://bugs.documentfoundation.org/show_bug.cgi?id=112325 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123864] No feedback for screen reader when radio button for underline attribute changes
https://bugs.documentfoundation.org/show_bug.cgi?id=123864 Xisco Faulí changed: What|Removed |Added Priority|medium |high --- Comment #7 from Xisco Faulí --- Hi Alex, Does it happen if you run LibreOffice with SAL_USE_VCLPLUGIN=gen ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65136] FILESAVE, FILEOPEN: XLS, XLSX partial-cell hyperlink is reloaded as full-cell hyperlink
https://bugs.documentfoundation.org/show_bug.cgi?id=65136 Gabor Kelemen changed: What|Removed |Added Blocks||113335 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113335 [Bug 113335] [META] XLSX (OOXML) hyperlink bug tracker -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113335] [META] XLSX (OOXML) hyperlink bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=113335 Gabor Kelemen changed: What|Removed |Added Depends on||65136 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=65136 [Bug 65136] FILESAVE, FILEOPEN: XLS, XLSX partial-cell hyperlink is reloaded as full-cell hyperlink -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92756] FILESAVE : Cell content transform into a hyperlink if there is an email address.(XLS file)
https://bugs.documentfoundation.org/show_bug.cgi?id=92756 Gabor Kelemen changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Gabor Kelemen --- *** This bug has been marked as a duplicate of bug 65136 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107733 Bug 107733 depends on bug 92756, which changed state. Bug 92756 Summary: FILESAVE : Cell content transform into a hyperlink if there is an email address.(XLS file) https://bugs.documentfoundation.org/show_bug.cgi?id=92756 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108897] [META] XLSX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108897 Bug 108897 depends on bug 92756, which changed state. Bug 92756 Summary: FILESAVE : Cell content transform into a hyperlink if there is an email address.(XLS file) https://bugs.documentfoundation.org/show_bug.cgi?id=92756 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65136] FILESAVE, FILEOPEN: XLS, XLSX partial-cell hyperlink is reloaded as full-cell hyperlink
https://bugs.documentfoundation.org/show_bug.cgi?id=65136 Gabor Kelemen changed: What|Removed |Added CC||andreidanbu...@gmail.com --- Comment #8 from Gabor Kelemen --- *** Bug 92756 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2-3' - vcl/source
vcl/source/app/salvtables.cxx |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
New commits:
commit 0b3ceaaf9bddd74aa61e8ab934caa68a7238e405
Author: Caolán McNamara
AuthorDate: Mon Apr 1 12:09:43 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 4 17:10:52 2019 +0200
Resolves: tdf#124440 nospin has no subedit
Change-Id: I4e801ec234e86be935a79c9e29f0e5091904f12e
Reviewed-on: https://gerrit.libreoffice.org/70053
Tested-by: Jenkins
Reviewed-by: Xisco Faulí
(cherry picked from commit 2c150f952fb75da271648bf76c3a1bbf32bd25da)
Reviewed-on: https://gerrit.libreoffice.org/70125
Reviewed-by: Adolfo Jayme Barrientos
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 297926d03012..bce3b3815f06 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -2559,7 +2559,10 @@ public:
m_xButton->SetLoseFocusHdl(LINK(this, SalInstanceSpinButton,
LoseFocusHdl));
m_xButton->SetOutputHdl(LINK(this, SalInstanceSpinButton, OutputHdl));
m_xButton->SetInputHdl(LINK(this, SalInstanceSpinButton, InputHdl));
-m_xButton->GetSubEdit()->SetActivateHdl(LINK(this,
SalInstanceSpinButton, ActivateHdl));
+if (Edit* pEdit = m_xButton->GetSubEdit())
+pEdit->SetActivateHdl(LINK(this, SalInstanceSpinButton,
ActivateHdl));
+else
+m_xButton->SetActivateHdl(LINK(this, SalInstanceSpinButton,
ActivateHdl));
}
virtual int get_value() const override
@@ -2621,6 +2624,8 @@ public:
{
if (Edit* pEdit = m_xButton->GetSubEdit())
pEdit->SetActivateHdl(Link());
+else
+m_xButton->SetActivateHdl(Link());
m_xButton->SetInputHdl(Link());
m_xButton->SetOutputHdl(Link());
m_xButton->SetLoseFocusHdl(Link());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)
https://bugs.documentfoundation.org/show_bug.cgi?id=49033 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=63 ||259 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124523] calc menubar: SheetCommentMenu should be in EditMenu instead of SheetMenu
https://bugs.documentfoundation.org/show_bug.cgi?id=124523 --- Comment #4 from Pedro --- +1 Also agree with this change. Makes it consistent with Writer and removes clutter from Sheet menu. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 63259] It should be possible to use shift + F3 case change, when cursor is at the beginning or end of a word and not only in the middle
https://bugs.documentfoundation.org/show_bug.cgi?id=63259 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=49 ||033 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/Package_theme_definitions.mk vcl/uiconfig
vcl/Package_theme_definitions.mk |2 vcl/uiconfig/theme_definitions/ios/definition.xml | 19 vcl/uiconfig/theme_definitions/ios/spinbox-left-disabled.svg |2 vcl/uiconfig/theme_definitions/ios/spinbox-left-pressed.svg |5 vcl/uiconfig/theme_definitions/ios/spinbox-left-rollover.svg |4 vcl/uiconfig/theme_definitions/ios/spinbox-left.svg |2 vcl/uiconfig/theme_definitions/ios/spinbox-right-disabled.svg |4 vcl/uiconfig/theme_definitions/ios/spinbox-right-pressed.svg |7 vcl/uiconfig/theme_definitions/ios/spinbox-right-rollover.svg |5 vcl/uiconfig/theme_definitions/ios/spinbox-right.svg |4 vcl/uiconfig/theme_definitions/ios/switch-off-disabled.svg| 192 - vcl/uiconfig/theme_definitions/ios/switch-off-pressed.svg | 170 vcl/uiconfig/theme_definitions/ios/switch-off.svg | 193 -- vcl/uiconfig/theme_definitions/ios/switch-on-disabled.svg | 157 vcl/uiconfig/theme_definitions/ios/switch-on-pressed.svg | 155 vcl/uiconfig/theme_definitions/ios/switch-on.svg | 157 vcl/uiconfig/theme_definitions/ios/tick-off-disabled.svg | 95 vcl/uiconfig/theme_definitions/ios/tick-off-pressed.svg | 135 -- vcl/uiconfig/theme_definitions/ios/tick-off.svg | 124 -- vcl/uiconfig/theme_definitions/ios/tick-on-disabled.svg | 134 -- vcl/uiconfig/theme_definitions/ios/tick-on-pressed.svg| 125 -- vcl/uiconfig/theme_definitions/ios/tick-on.svg| 127 -- 22 files changed, 153 insertions(+), 1665 deletions(-) New commits: commit 64ee37e4409dbde80bd98fb8d3f65b0146b9cb92 Author: Tomaž Vajngerl AuthorDate: Thu Apr 4 21:51:22 2019 +0900 Commit: Tomaž Vajngerl CommitDate: Thu Apr 4 16:59:26 2019 +0200 ios widget defs: update combobox, checkbox, spinbox SVGs In addition remove spinbox pressed state (it wasn't useful) and draw white filled empty rect for spinbox as we don't draw the background automatically. Change-Id: I892108c5839dc463cdb9e4f4f09276fc184f4944 Reviewed-on: https://gerrit.libreoffice.org/70258 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/vcl/Package_theme_definitions.mk b/vcl/Package_theme_definitions.mk index dbb0a92fe268..395a90b19b6e 100644 --- a/vcl/Package_theme_definitions.mk +++ b/vcl/Package_theme_definitions.mk @@ -25,11 +25,9 @@ $(eval $(call gb_Package_add_files_with_dir,vcl_theme_definitions,$(LIBO_SHARE_F ios/tick-on-disabled.svg \ ios/spinbox-left.svg \ ios/spinbox-left-pressed.svg \ - ios/spinbox-left-rollover.svg \ ios/spinbox-left-disabled.svg \ ios/spinbox-right.svg \ ios/spinbox-right-pressed.svg \ - ios/spinbox-right-rollover.svg \ ios/spinbox-right-disabled.svg \ ios/common-rect.svg \ ios/common-rect-disabled.svg \ diff --git a/vcl/uiconfig/theme_definitions/ios/definition.xml b/vcl/uiconfig/theme_definitions/ios/definition.xml index 5b4aa12b44ea..61d6aa21578e 100644 --- a/vcl/uiconfig/theme_definitions/ios/definition.xml +++ b/vcl/uiconfig/theme_definitions/ios/definition.xml @@ -102,7 +102,7 @@ - + @@ -113,7 +113,7 @@ - + @@ -130,7 +130,7 @@ - + @@ -192,8 +192,7 @@ - - + @@ -212,7 +211,9 @@ - + + + @@ -224,9 +225,6 @@ - - - @@ -238,9 +236,6 @@ - - - diff --git a/vcl/uiconfig/theme_definitions/ios/spinbox-left-disabled.svg b/vcl/uiconfig/theme_definitions/ios/spinbox-left-disabled.svg index b239b8e239b9..01cac0c3e881 100644 --- a/vcl/uiconfig/theme_definitions/ios/spinbox-left-disabled.svg +++ b/vcl/uiconfig/theme_definitions/ios/spinbox-left-disabled.svg @@ -1,4 +1,4 @@ http://www.w3.org/2000/svg;> - + diff --git a/vcl/uiconfig/theme_definitions/ios/spinbox-left-pressed.svg b/vcl/uiconfig/theme_definitions/ios/spinbox-left-pressed.svg index 1ddc6503b087..df8c90cccb89 100644 --- a/vcl/uiconfig/theme_definitions/ios/spinbox-left-pressed.svg +++ b/vcl/uiconfig/theme_definitions/ios/spinbox-left-pressed.svg @@ -1,4 +1,5 @@ http://www.w3.org/2000/svg;> - - + + + diff --git
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - vcl/source
vcl/source/filter/ipdf/pdfread.cxx |8
1 file changed, 8 insertions(+)
New commits:
commit cba5d19a4e0c929cafbeccbaaa1da63ee1ec20b5
Author: Tor Lillqvist
AuthorDate: Thu Apr 4 17:53:38 2019 +0300
Commit: Tor Lillqvist
CommitDate: Thu Apr 4 17:54:39 2019 +0300
Fix compilation in !HAVE_FEATURE_PDFIUM case
Change-Id: Ifc5e82f9bf57c76abe8810911f8f4339f9763453
diff --git a/vcl/source/filter/ipdf/pdfread.cxx
b/vcl/source/filter/ipdf/pdfread.cxx
index 87bfdc60b629..e1d5c5b9b890 100644
--- a/vcl/source/filter/ipdf/pdfread.cxx
+++ b/vcl/source/filter/ipdf/pdfread.cxx
@@ -292,6 +292,7 @@ size_t ImportPDF(const OUString& rURL, std::vector&
rBitmaps,
size_t ImportPDFUnloaded(const OUString& rURL, std::vector>& rGraphics,
const double fResolutionDPI)
{
+#if HAVE_FEATURE_PDFIUM
std::unique_ptr xStream(
::utl::UcbStreamHelper::CreateStream(rURL, StreamMode::READ |
StreamMode::SHARE_DENYNONE));
@@ -359,6 +360,13 @@ size_t ImportPDFUnloaded(const OUString& rURL,
std::vectorhttps://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 124535] LibreOffice 6.1.5.2 (x64) Calc would only output last page of the spreadsheet into PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=124535 --- Comment #1 from Durgapriyanka --- Thank you for reporting the bug. I cannot reproduce this in Version: 6.3.0.0.alpha0+ Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04 Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-qa] minutes of ESC call ...
* Present: + Stephan, Caolan, Christian, Michael M, Gabriel, Eduard A, Miklos, Heiko, Kendy, Xisco, Sophie, Olivier, Michael S, Eike, Sophie, Thorsten, Olivier, Michael W * Completed Action Items: + take a look at symbol / crashtest bits (Markus, Christian) [ server ran out of disk-space so couldn’t process them → now fixed ] + get Laurent Alonso commit access (Miklos) + talk to Tor / Nicolas if avoiding UNCONFIRMED for iOS makes sense (Miklos) [ seems like it is sorted ] + looking for mentor for idea “Calc Functions Sidebar” (Heiko) + https://lists.freedesktop.org/archives/libreoffice/2019-March/082315.html [ too late ] + review/update GSOC ideas page! (Mentors) + https://wiki.documentfoundation.org/Development/GSoC/Ideas [ also expired ] * Pending Action Items: + add monitoring for build bot daily failure rates (Christian) [ done manually for now – should be done next week ] * Release Engineering update (Christian) + no release this week. + 6.2.3 rc1 available on mirrors + 6.2.3 rc2 – available next week. + 6.1.6 rc1: April 9 next week + tagging Thur after 6.2.3 + 6.3 alpha1: early May + Remotes → no updates + Android viewer + Maven repo is published up to 6.0.4 – rest later today (Christian) + Online: * Documentation (Olivier) + New Help + Replacement icons now in gbuild (ohallot, buovjaga) + have a donation button in the help too now. + Help contents 2 + Housekeeping and maintenance (ohallot, libreofficiant, A.Gelmini) + Google season of Code / Docs + registered TDF as organization (ohallot) + working on projects (ohallot djredaux) + would love suggestions for simple projects so we can find tech. writers + “Easy-doc”. + not for students but for technical writers. + https://wiki.documentfoundation.org/Documentation/GSoDOC/2019 + Guides + more updated on Calc Guide (J. Weber) * UX Update (Heiko) + Bugzilla (topicUI) statistics 243(243) (topicUI) bugs open, 225(225) (needsUXEval) needs to be evaluated by the UXteam + Updates: BZ changes 1 week 1 month 3 months 12 months added 5(0) 14(0) 31(1) 78(-1) commented 47(-7) 175(9)497(55)1384(8) removed 1(1) 6(1) 10(1) 20(0) resolved 4(-4)21(-3)60(1) 133(1) + top 10 contributors: Tietze, Heiko made 70 changes in 1 month, and 567 changes in 1 year dieterp made 39 changes in 1 month, and 157 changes in 1 year Foote, V Stuart made 32 changes in 1 month, and 217 changes in 1 year Roman Kuznetsov made 31 changes in 1 month, and 144 changes in 1 year Xisco Faulí made 29 changes in 1 month, and 241 changes in 1 year Mehrbrodt, Samuel made 25 changes in 1 month, and 80 changes in 1 year Cor Nouws made 10 changes in 1 month, and 108 changes in 1 year Jim Raykowski made 9 changes in 1 month, and 27 changes in 1 year 和尚蟹 made 9 changes in 1 month, and 17 changes in 1 year Alexander Farrow made 8 changes in 1 month, and 8 changes in 1 year New needsUXEval between Mar/28-Apr/04 * Sidebar Separator lines + https://bugs.documentfoundation.org/show_bug.cgi?id=124376 * calc menubar: SheetCommentMenu should be in EditMenu instead of SheetMenu + https://bugs.documentfoundation.org/show_bug.cgi?id=124523 * LO request to enhancement: make the '?' sign workable in Help -> About + https://bugs.documentfoundation.org/show_bug.cgi?id=124541 => in discussion * Tabbed: Missing Some Required Functions from Previous Pop Up Toolbar in Tabbed interface + https://bugs.documentfoundation.org/show_bug.cgi?id=122751 * FRAME-DIALOG: Add an apply button + https://bugs.documentfoundation.org/show_bug.cgi?id=124278 -> * 'Pick a Color' dialog: Give option to add a color to the custom palette + https://bugs.documentfoundation.org/show_bug.cgi?id=124418 -> * Change case -> Sentence case doesn't honor selection; case of entire sentence changes + https://bugs.documentfoundation.org/show_bug.cgi?id=49033 * Redundant undo/redo items in grouped compact bar + https://bugs.documentfoundation.org/show_bug.cgi?id=124392 => accepted/forwarded -> * Change bullet styles names in Style section of Sidebar in Writer + https://bugs.documentfoundation.org/show_bug.cgi?id=124471 => fixed today. * toggeling settings - e.g. threaded calculations - need restart, UI unclear about this + https://bugs.documentfoundation.org/show_bug.cgi?id=124323 * Unable to use keyboard navigation to
minutes of ESC call ...
* Present: + Stephan, Caolan, Christian, Michael M, Gabriel, Eduard A, Miklos, Heiko, Kendy, Xisco, Sophie, Olivier, Michael S, Eike, Sophie, Thorsten, Olivier, Michael W * Completed Action Items: + take a look at symbol / crashtest bits (Markus, Christian) [ server ran out of disk-space so couldn’t process them → now fixed ] + get Laurent Alonso commit access (Miklos) + talk to Tor / Nicolas if avoiding UNCONFIRMED for iOS makes sense (Miklos) [ seems like it is sorted ] + looking for mentor for idea “Calc Functions Sidebar” (Heiko) + https://lists.freedesktop.org/archives/libreoffice/2019-March/082315.html [ too late ] + review/update GSOC ideas page! (Mentors) + https://wiki.documentfoundation.org/Development/GSoC/Ideas [ also expired ] * Pending Action Items: + add monitoring for build bot daily failure rates (Christian) [ done manually for now – should be done next week ] * Release Engineering update (Christian) + no release this week. + 6.2.3 rc1 available on mirrors + 6.2.3 rc2 – available next week. + 6.1.6 rc1: April 9 next week + tagging Thur after 6.2.3 + 6.3 alpha1: early May + Remotes → no updates + Android viewer + Maven repo is published up to 6.0.4 – rest later today (Christian) + Online: * Documentation (Olivier) + New Help + Replacement icons now in gbuild (ohallot, buovjaga) + have a donation button in the help too now. + Help contents 2 + Housekeeping and maintenance (ohallot, libreofficiant, A.Gelmini) + Google season of Code / Docs + registered TDF as organization (ohallot) + working on projects (ohallot djredaux) + would love suggestions for simple projects so we can find tech. writers + “Easy-doc”. + not for students but for technical writers. + https://wiki.documentfoundation.org/Documentation/GSoDOC/2019 + Guides + more updated on Calc Guide (J. Weber) * UX Update (Heiko) + Bugzilla (topicUI) statistics 243(243) (topicUI) bugs open, 225(225) (needsUXEval) needs to be evaluated by the UXteam + Updates: BZ changes 1 week 1 month 3 months 12 months added 5(0) 14(0) 31(1) 78(-1) commented 47(-7) 175(9)497(55)1384(8) removed 1(1) 6(1) 10(1) 20(0) resolved 4(-4)21(-3)60(1) 133(1) + top 10 contributors: Tietze, Heiko made 70 changes in 1 month, and 567 changes in 1 year dieterp made 39 changes in 1 month, and 157 changes in 1 year Foote, V Stuart made 32 changes in 1 month, and 217 changes in 1 year Roman Kuznetsov made 31 changes in 1 month, and 144 changes in 1 year Xisco Faulí made 29 changes in 1 month, and 241 changes in 1 year Mehrbrodt, Samuel made 25 changes in 1 month, and 80 changes in 1 year Cor Nouws made 10 changes in 1 month, and 108 changes in 1 year Jim Raykowski made 9 changes in 1 month, and 27 changes in 1 year 和尚蟹 made 9 changes in 1 month, and 17 changes in 1 year Alexander Farrow made 8 changes in 1 month, and 8 changes in 1 year New needsUXEval between Mar/28-Apr/04 * Sidebar Separator lines + https://bugs.documentfoundation.org/show_bug.cgi?id=124376 * calc menubar: SheetCommentMenu should be in EditMenu instead of SheetMenu + https://bugs.documentfoundation.org/show_bug.cgi?id=124523 * LO request to enhancement: make the '?' sign workable in Help -> About + https://bugs.documentfoundation.org/show_bug.cgi?id=124541 => in discussion * Tabbed: Missing Some Required Functions from Previous Pop Up Toolbar in Tabbed interface + https://bugs.documentfoundation.org/show_bug.cgi?id=122751 * FRAME-DIALOG: Add an apply button + https://bugs.documentfoundation.org/show_bug.cgi?id=124278 -> * 'Pick a Color' dialog: Give option to add a color to the custom palette + https://bugs.documentfoundation.org/show_bug.cgi?id=124418 -> * Change case -> Sentence case doesn't honor selection; case of entire sentence changes + https://bugs.documentfoundation.org/show_bug.cgi?id=49033 * Redundant undo/redo items in grouped compact bar + https://bugs.documentfoundation.org/show_bug.cgi?id=124392 => accepted/forwarded -> * Change bullet styles names in Style section of Sidebar in Writer + https://bugs.documentfoundation.org/show_bug.cgi?id=124471 => fixed today. * toggeling settings - e.g. threaded calculations - need restart, UI unclear about this + https://bugs.documentfoundation.org/show_bug.cgi?id=124323 * Unable to use keyboard navigation to
[Libreoffice-bugs] [Bug 124364] Inserting a diagram leads to an error
https://bugs.documentfoundation.org/show_bug.cgi?id=124364 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu --- Comment #3 from Aron Budea --- I could repro this a single time, then never again... not sure what it depends on. Nicolas, does it depend on the exact file for you, or can you repro with an empty/random document as well? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124548] Activating Area tab, "None" is always focused, regardless of which fill type is selected
https://bugs.documentfoundation.org/show_bug.cgi?id=124548 Durgapriyanka changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Durgapriyanka --- Thank you for reporting the bug. I can confirm the bug present in Version: 6.3.0.0.alpha0+ Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04 Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2-3' - configure.ac download.lst external/python3
configure.ac|2
download.lst|4 -
external/python3/UnpackedTarball_python3.mk |1
external/python3/python-3.5.7-c99.patch.1 | 62
4 files changed, 66 insertions(+), 3 deletions(-)
New commits:
commit e4fcef6ee19755b93213beb0d853a513c619f377
Author: Michael Stahl
AuthorDate: Wed Apr 3 11:03:17 2019 +0200
Commit: Caolán McNamara
CommitDate: Thu Apr 4 16:31:23 2019 +0200
python3: upgrade to release 3.5.7
Fixes CVE-2019-9636 CVE-2019-5010 CVE-2018-14647
Change-Id: If0a115960aed1ee90b63e6716c844669f0ec91e5
Reviewed-on: https://gerrit.libreoffice.org/70182
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 3c7354a85a9bd47a2676aadaad2f6622fe2d959c)
Reviewed-on: https://gerrit.libreoffice.org/70192
Reviewed-by: Thorsten Behrens
(cherry picked from commit 746a749a675859107bf959c0fce128f3b13188d8)
Reviewed-on: https://gerrit.libreoffice.org/70224
Reviewed-by: Michael Weghorn
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/configure.ac b/configure.ac
index 758dac7d2454..f544308bdcc3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -8443,7 +8443,7 @@ internal)
SYSTEM_PYTHON=
PYTHON_VERSION_MAJOR=3
PYTHON_VERSION_MINOR=5
-PYTHON_VERSION=${PYTHON_VERSION_MAJOR}.${PYTHON_VERSION_MINOR}.6
+PYTHON_VERSION=${PYTHON_VERSION_MAJOR}.${PYTHON_VERSION_MINOR}.7
if ! grep -q -i python.*${PYTHON_VERSION} ${SRC_ROOT}/download.lst; then
AC_MSG_ERROR([PYTHON_VERSION ${PYTHON_VERSION} but no matching file in
download.lst])
fi
diff --git a/download.lst b/download.lst
index bc6adeabc8c5..877497006626 100644
--- a/download.lst
+++ b/download.lst
@@ -210,8 +210,8 @@ export POPPLER_SHA256SUM :=
92e09fd3302567fd36146b36bb707db43ce436e8841219025a82
export POPPLER_TARBALL := poppler-0.74.0.tar.xz
export POSTGRESQL_SHA256SUM :=
a754c02f7051c2f21e52f8669a421b50485afcde9a581674d6106326b189d126
export POSTGRESQL_TARBALL := postgresql-9.2.24.tar.bz2
-export PYTHON_SHA256SUM :=
f55cde04f521f273c7cba08912921cc5642cfc15ca7b22d5829f0aff4371155f
-export PYTHON_TARBALL := Python-3.5.6.tar.xz
+export PYTHON_SHA256SUM :=
285892899bf4d5737fd08482aa6171c6b2564a45b9102dfacfb72826aebdc7dc
+export PYTHON_TARBALL := Python-3.5.7.tar.xz
export QXP_SHA256SUM :=
e137b6b110120a52c98edd02ebdc4095ee08d0d5295a94316a981750095a945c
export QXP_TARBALL := libqxp-0.0.2.tar.xz
export RAPTOR_SHA256SUM :=
ada7f0ba54787b33485d090d3d2680533520cd4426d2f7fb4782dd4a6a1480ed
diff --git a/external/python3/UnpackedTarball_python3.mk
b/external/python3/UnpackedTarball_python3.mk
index ec1bdabe4fdd..66a82955e440 100644
--- a/external/python3/UnpackedTarball_python3.mk
+++ b/external/python3/UnpackedTarball_python3.mk
@@ -27,6 +27,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,python3,\
external/python3/ubsan.patch.0 \
external/python3/python-3.5.tweak.strip.soabi.patch \
external/python3/0001-3.6-bpo-17239-Disable-external-entities-in-SAX-parse.patch.1
\
+ external/python3/python-3.5.7-c99.patch.1 \
))
ifneq ($(filter DRAGONFLY FREEBSD LINUX NETBSD OPENBSD SOLARIS,$(OS)),)
diff --git a/external/python3/python-3.5.7-c99.patch.1
b/external/python3/python-3.5.7-c99.patch.1
new file mode 100644
index ..558166d9953f
--- /dev/null
+++ b/external/python3/python-3.5.7-c99.patch.1
@@ -0,0 +1,62 @@
+remove C99 which isn't suppored by all compilers yet
+
+--- python3/Modules/_pickle.c.orig 2019-04-03 16:34:01.380124314 +0200
python3/Modules/_pickle.c 2019-04-03 16:35:18.579005171 +0200
+@@ -674,9 +674,12 @@
+ PyErr_NoMemory();
+ return NULL;
+ }
+-for (size_t i = 0; i < self->mt_allocated; i++) {
++{
++size_t i;
++for (i = 0; i < self->mt_allocated; i++) {
+ Py_XINCREF(self->mt_table[i].me_key);
+ }
++}
+ memcpy(new->mt_table, self->mt_table,
+sizeof(PyMemoEntry) * self->mt_allocated);
+
+@@ -4204,7 +4207,9 @@
+ return NULL;
+
+ memo = self->pickler->memo;
+-for (size_t i = 0; i < memo->mt_allocated; ++i) {
++{
++size_t i;
++for (i = 0; i < memo->mt_allocated; ++i) {
+ PyMemoEntry entry = memo->mt_table[i];
+ if (entry.me_key != NULL) {
+ int status;
+@@ -4225,6 +4230,7 @@
+ goto error;
+ }
+ }
++}
+ return new_memo;
+
+ error:
+@@ -6791,10 +6797,13 @@
+ if (new_memo == NULL)
+ return -1;
+
+-for (size_t i = 0; i < new_memo_size; i++) {
++{
++size_t i;
++for (i = 0; i < new_memo_size; i++) {
+ Py_XINCREF(unpickler->memo[i]);
+ new_memo[i] = unpickler->memo[i];
+ }
++}
+ }
+ else if (PyDict_Check(obj)) {
+ Py_ssize_t i = 0;
+@@ -6839,7 +6848,8 @@
+
+ error:
+ if
[Libreoffice-bugs] [Bug 124548] New: Activating Area tab, "None" is always focused, regardless of which fill type is selected
https://bugs.documentfoundation.org/show_bug.cgi?id=124548 Bug ID: 124548 Summary: Activating Area tab, "None" is always focused, regardless of which fill type is selected Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Keywords: difficultyBeginner, easyHack, skillCpp Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com Created attachment 150524 --> https://bugs.documentfoundation.org/attachment.cgi?id=150524=edit Screenshot of "None" selected when "Color" is active Activating Area tab, "None" is always focused, regardless of which fill type is active. Use e.g. these steps: - Create a new Writer document; - Format->Page; - Click "Area" tab in the Page Style dialog. => "None" toggle button is both active (pushed) and focused (has a frame around it, indicating the current focus control). - Click "Color" toggle button to set background to some color - Click "Page" (or any other) tab to leave "Area" tab; - Click "Area" tab to return. => "Color" toggle button is active (pushed); but "None" is focused. This creates a confusing impression of the two "active" modes; it's not always easy to tell which of the two distinct highlighted elements is really active: see the screenshot - on Windows 10, focusing makes the button so more emphasized than activating. Upon activation of the "Area" tab, currently active button should be both pressed, and focused. Code pointer: see SvxAreaTabPage::ActivatePage in cui/source/tabpages/tparea.cxx. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112318] Animations set to start 'With previous'/'After previous' don't work when OpenGL is enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=112318 Miklos Vajna changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |vmik...@collabora.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - vcl/Package_theme_definitions.mk vcl/uiconfig
vcl/Package_theme_definitions.mk |2 vcl/uiconfig/theme_definitions/ios/definition.xml | 19 vcl/uiconfig/theme_definitions/ios/spinbox-left-disabled.svg |2 vcl/uiconfig/theme_definitions/ios/spinbox-left-pressed.svg |5 vcl/uiconfig/theme_definitions/ios/spinbox-left-rollover.svg |4 vcl/uiconfig/theme_definitions/ios/spinbox-left.svg |2 vcl/uiconfig/theme_definitions/ios/spinbox-right-disabled.svg |4 vcl/uiconfig/theme_definitions/ios/spinbox-right-pressed.svg |7 vcl/uiconfig/theme_definitions/ios/spinbox-right-rollover.svg |5 vcl/uiconfig/theme_definitions/ios/spinbox-right.svg |4 vcl/uiconfig/theme_definitions/ios/switch-off-disabled.svg| 192 - vcl/uiconfig/theme_definitions/ios/switch-off-pressed.svg | 170 vcl/uiconfig/theme_definitions/ios/switch-off.svg | 193 -- vcl/uiconfig/theme_definitions/ios/switch-on-disabled.svg | 157 vcl/uiconfig/theme_definitions/ios/switch-on-pressed.svg | 155 vcl/uiconfig/theme_definitions/ios/switch-on.svg | 157 vcl/uiconfig/theme_definitions/ios/tick-off-disabled.svg | 95 vcl/uiconfig/theme_definitions/ios/tick-off-pressed.svg | 135 -- vcl/uiconfig/theme_definitions/ios/tick-off.svg | 124 -- vcl/uiconfig/theme_definitions/ios/tick-on-disabled.svg | 134 -- vcl/uiconfig/theme_definitions/ios/tick-on-pressed.svg| 125 -- vcl/uiconfig/theme_definitions/ios/tick-on.svg| 127 -- 22 files changed, 153 insertions(+), 1665 deletions(-) New commits: commit ad75f60e5fb00b4c7583c74c835ffcbc3058afe8 Author: Tomaž Vajngerl AuthorDate: Thu Apr 4 21:51:22 2019 +0900 Commit: Tomaž Vajngerl CommitDate: Thu Apr 4 22:47:27 2019 +0900 ios widget defs: update combobox, checkbox, spinbox SVGs In addition remove spinbox pressed state (it wasn't useful) and draw white filled empty rect for spinbox as we don't draw the background automatically. Change-Id: I892108c5839dc463cdb9e4f4f09276fc184f4944 diff --git a/vcl/Package_theme_definitions.mk b/vcl/Package_theme_definitions.mk index dbb0a92fe268..395a90b19b6e 100644 --- a/vcl/Package_theme_definitions.mk +++ b/vcl/Package_theme_definitions.mk @@ -25,11 +25,9 @@ $(eval $(call gb_Package_add_files_with_dir,vcl_theme_definitions,$(LIBO_SHARE_F ios/tick-on-disabled.svg \ ios/spinbox-left.svg \ ios/spinbox-left-pressed.svg \ - ios/spinbox-left-rollover.svg \ ios/spinbox-left-disabled.svg \ ios/spinbox-right.svg \ ios/spinbox-right-pressed.svg \ - ios/spinbox-right-rollover.svg \ ios/spinbox-right-disabled.svg \ ios/common-rect.svg \ ios/common-rect-disabled.svg \ diff --git a/vcl/uiconfig/theme_definitions/ios/definition.xml b/vcl/uiconfig/theme_definitions/ios/definition.xml index 5b4aa12b44ea..61d6aa21578e 100644 --- a/vcl/uiconfig/theme_definitions/ios/definition.xml +++ b/vcl/uiconfig/theme_definitions/ios/definition.xml @@ -102,7 +102,7 @@ - + @@ -113,7 +113,7 @@ - + @@ -130,7 +130,7 @@ - + @@ -192,8 +192,7 @@ - - + @@ -212,7 +211,9 @@ - + + + @@ -224,9 +225,6 @@ - - - @@ -238,9 +236,6 @@ - - - diff --git a/vcl/uiconfig/theme_definitions/ios/spinbox-left-disabled.svg b/vcl/uiconfig/theme_definitions/ios/spinbox-left-disabled.svg index b239b8e239b9..01cac0c3e881 100644 --- a/vcl/uiconfig/theme_definitions/ios/spinbox-left-disabled.svg +++ b/vcl/uiconfig/theme_definitions/ios/spinbox-left-disabled.svg @@ -1,4 +1,4 @@ http://www.w3.org/2000/svg;> - + diff --git a/vcl/uiconfig/theme_definitions/ios/spinbox-left-pressed.svg b/vcl/uiconfig/theme_definitions/ios/spinbox-left-pressed.svg index 1ddc6503b087..df8c90cccb89 100644 --- a/vcl/uiconfig/theme_definitions/ios/spinbox-left-pressed.svg +++ b/vcl/uiconfig/theme_definitions/ios/spinbox-left-pressed.svg @@ -1,4 +1,5 @@ http://www.w3.org/2000/svg;> - - + + + diff --git a/vcl/uiconfig/theme_definitions/ios/spinbox-left-rollover.svg
[Libreoffice-bugs] [Bug 108747] [META] File properties/settings (meta data) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108747 Bug 108747 depends on bug 122780, which changed state. Bug 122780 Summary: FILEOPEN DOCX Crash with too long Template tag in app.xml https://bugs.documentfoundation.org/show_bug.cgi?id=122780 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 3 commits - cui/source cui/uiconfig include/tools include/vcl vcl/Package_theme_definitions.mk vcl/source vcl/uiconfig
cui/source/inc/cuitabarea.hxx |2
cui/source/tabpages/tparea.cxx|2
cui/source/tabpages/tpgradnt.cxx | 27 +-
cui/uiconfig/ui/gradientpage.ui | 112 --
include/tools/gen.hxx |6
include/vcl/slider.hxx|1
vcl/Package_theme_definitions.mk |1
vcl/source/control/slider.cxx | 55 +++-
vcl/uiconfig/theme_definitions/ios/definition.xml | 15 +
vcl/uiconfig/theme_definitions/ios/slider-button-disabled.svg |3
10 files changed, 136 insertions(+), 88 deletions(-)
New commits:
commit c19d924a3abefe396beda2772ab8a7cf3c9527f8
Author: Tomaž Vajngerl
AuthorDate: Thu Apr 4 10:56:40 2019 +0900
Commit: Tomaž Vajngerl
CommitDate: Thu Apr 4 22:22:43 2019 +0900
ios theme definition: add slider disabled state
Change-Id: Ie4388f00c4a0c11df77782691fe9ea7f706d2b5c
Reviewed-on: https://gerrit.libreoffice.org/70231
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit aa5abc875934990d1ecec17abc6c58d51afd10b1)
diff --git a/vcl/Package_theme_definitions.mk b/vcl/Package_theme_definitions.mk
index 8f551ebaa8ce..dbb0a92fe268 100644
--- a/vcl/Package_theme_definitions.mk
+++ b/vcl/Package_theme_definitions.mk
@@ -53,6 +53,7 @@ $(eval $(call
gb_Package_add_files_with_dir,vcl_theme_definitions,$(LIBO_SHARE_F
ios/arrow-up.svg \
ios/arrow-down.svg \
ios/slider-button.svg \
+ ios/slider-button-disabled.svg \
))
# vim: set noet sw=4 ts=4:
diff --git a/vcl/uiconfig/theme_definitions/ios/definition.xml
b/vcl/uiconfig/theme_definitions/ios/definition.xml
index 0f0823193857..5b4aa12b44ea 100644
--- a/vcl/uiconfig/theme_definitions/ios/definition.xml
+++ b/vcl/uiconfig/theme_definitions/ios/definition.xml
@@ -295,14 +295,20 @@
-
+
+
+
+
-
+
+
+
+
@@ -310,9 +316,12 @@
-
+
+
+
+
diff --git a/vcl/uiconfig/theme_definitions/ios/slider-button-disabled.svg
b/vcl/uiconfig/theme_definitions/ios/slider-button-disabled.svg
new file mode 100644
index ..3c3b9fc56c2e
--- /dev/null
+++ b/vcl/uiconfig/theme_definitions/ios/slider-button-disabled.svg
@@ -0,0 +1,3 @@
+http://www.w3.org/2000/svg;>
+
+
commit 3a2cfc646afe5e2b8a1ff0bdb215897931268ba6
Author: Tomaž Vajngerl
AuthorDate: Wed Apr 3 22:11:41 2019 +0900
Commit: Tomaž Vajngerl
CommitDate: Thu Apr 4 22:21:41 2019 +0900
tdf#124155 fix slider to not go beyond rect bounds
We need to ask the NWF for the size of the thumb and not just use
the hard-coded value.
Reviewed-on: https://gerrit.libreoffice.org/70201
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit 9956cf0692058414ef3efdb0e8058fbb0b39f6bc)
Change-Id: I98c6b5782c6a043fc358198ddf844d36d7aa90d6
diff --git a/include/vcl/slider.hxx b/include/vcl/slider.hxx
index 426727c15ae7..ab7c035e52cc 100644
--- a/include/vcl/slider.hxx
+++ b/include/vcl/slider.hxx
@@ -36,6 +36,7 @@ private:
longmnThumbPixOffset;
longmnThumbPixRange;
longmnThumbPixPos;
+longmnThumbSize;
longmnChannelPixOffset;
longmnChannelPixRange;
longmnChannelPixTop;
diff --git a/vcl/source/control/slider.cxx b/vcl/source/control/slider.cxx
index c2af3bf820bc..f5f3984ad158 100644
--- a/vcl/source/control/slider.cxx
+++ b/vcl/source/control/slider.cxx
@@ -29,7 +29,6 @@
#define SLIDER_STATE_THUMB_DOWN ((sal_uInt16)0x0004)
#define SLIDER_THUMB_SIZE 9
-#define SLIDER_THUMB_HALFSIZE 4
#define SLIDER_CHANNEL_OFFSET 0
#define SLIDER_CHANNEL_SIZE 4
#define SLIDER_CHANNEL_HALFSIZE 2
@@ -43,6 +42,7 @@ void Slider::ImplInit( vcl::Window* pParent, WinBits nStyle )
mnThumbPixOffset= 0;
mnThumbPixRange = 0;
mnThumbPixPos = 0;// between mnThumbPixOffset and
mnThumbPixOffset+mnThumbPixRange
+mnThumbSize = SLIDER_THUMB_SIZE;
mnChannelPixOffset = 0;
mnChannelPixRange = 0;
mnChannelPixTop = 0;
@@ -116,8 +116,8 @@ void Slider::ImplUpdateRects( bool bUpdate )
{
if ( GetStyle() & WB_HORZ )
{
-maThumbRect.Left() = mnThumbPixPos-SLIDER_THUMB_HALFSIZE;
-maThumbRect.Right() = maThumbRect.Left()+SLIDER_THUMB_SIZE-1;
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/dialog/dinfdlg.cxx | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
New commits:
commit 9db7130e05b79fdcb9a60a3f1f4801e5401427de
Author: Caolán McNamara
AuthorDate: Thu Apr 4 13:09:17 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 4 15:29:27 2019 +0200
Resolves: tdf#122780 limit massive template names in ui to a sane length
Change-Id: I053b30b00dbda67819af68020e2f6fa4a5b5134e
Reviewed-on: https://gerrit.libreoffice.org/70255
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sfx2/source/dialog/dinfdlg.cxx b/sfx2/source/dialog/dinfdlg.cxx
index 5e411b37fb82..a3d0fedd6531 100644
--- a/sfx2/source/dialog/dinfdlg.cxx
+++ b/sfx2/source/dialog/dinfdlg.cxx
@@ -948,8 +948,14 @@ void SfxDocumentPage::Reset( const SfxItemSet* rSet )
const SfxDocumentInfoItem& rInfoItem = rSet->Get(SID_DOCINFO);
// template data
-if ( rInfoItem.HasTemplate() )
-m_xTemplValFt->set_label( rInfoItem.getTemplateName() );
+if (rInfoItem.HasTemplate())
+{
+const OUString& rName = rInfoItem.getTemplateName();
+if (rName.getLength() > SAL_MAX_INT16) // tdf#122780 pick some
~arbitrary max size
+m_xTemplValFt->set_label(rName.copy(0, SAL_MAX_INT16));
+else
+m_xTemplValFt->set_label(rName);
+}
else
{
m_xTemplFt->hide();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 124450] Libreoffice Calc: Autofilter functions are slow
https://bugs.documentfoundation.org/show_bug.cgi?id=124450 Gabor Kelemen changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=76 ||481 --- Comment #7 from Gabor Kelemen --- This looks like a duplicate to bug #76481 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76481] Using autofilter pulldown on column with particular amount of records will freeze graphical mode, after few minutes normal state is restored
https://bugs.documentfoundation.org/show_bug.cgi?id=76481 Gabor Kelemen changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||4450 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/oox oox/source sd/source sw/source
include/oox/export/utils.hxx |2 -
oox/source/export/chartexport.cxx| 11 ---
oox/source/export/drawingml.cxx | 38 ++-
oox/source/export/shapes.cxx | 17 +++-
sd/source/filter/eppt/pptx-animations.cxx| 23
sd/source/filter/eppt/pptx-epptooxml.cxx | 22 +++
sw/source/filter/ww8/docxattributeoutput.cxx |2 -
7 files changed, 61 insertions(+), 54 deletions(-)
New commits:
commit 4a4b1df72909fe96acdbcb95f90e30bd1a79c5eb
Author: Mike Kaganski
AuthorDate: Wed Mar 27 10:07:31 2019 +0100
Commit: Mike Kaganski
CommitDate: Thu Apr 4 15:24:49 2019 +0200
Get rid of USS macro
The helper marco is used in export code to convert UTF-16 internal
string representation to UTF-8 used in XML encoding. I suppose that all
strings here should be already valid UTF-16 (an invalid input should
have been validated at import/input stage). An invalid string at this
stage means a programming error in another part of code that breaks this
precondition, and should not be handled at export stage.
(See also commit 0267a2326b5282023e8b08a147eca178c5db1980.)
This effectively changes flags used in conversion from UTF-16 to UTF-8,
so that now RTL_UNICODETOTEXT_FLAGS_INVALID_ERROR is used instead of
RTL_UNICODETOTEXT_FLAGS_INVALID_DEFAULT, so that the result would be
truncated on invalid bytes instead of inserting U+FFFD, and would fail
assertion in debug builds.
Other changed flags don't affect UTF-16-to-UTF-8 conversion.
Change-Id: I12b2cc5378208904c3266924187d6402700ed6f3
Reviewed-on: https://gerrit.libreoffice.org/69801
Reviewed-by: Mike Kaganski
Tested-by: Mike Kaganski
diff --git a/include/oox/export/utils.hxx b/include/oox/export/utils.hxx
index fbe4c806dd70..fa758089136e 100644
--- a/include/oox/export/utils.hxx
+++ b/include/oox/export/utils.hxx
@@ -59,8 +59,6 @@ static constexpr const char* ToPsz10(bool b)
return b ? "1" : "0";
}
-#define USS(x) OUStringToOString( x, RTL_TEXTENCODING_UTF8 ).getStr()
-
static constexpr sal_Int64 PPTtoEMU( sal_Int32 nPPT )
{
return static_cast( static_cast(nPPT) * 1587.5 );
diff --git a/oox/source/export/chartexport.cxx
b/oox/source/export/chartexport.cxx
index 062636c91d62..5641d62119a1 100644
--- a/oox/source/export/chartexport.cxx
+++ b/oox/source/export/chartexport.cxx
@@ -457,7 +457,7 @@ void ChartExport::WriteChartObj( const Reference< XShape >&
xShape, sal_Int32 nI
pFS->singleElementNS( mnXmlNamespace, XML_cNvPr,
XML_id, I32S( nID ),
- XML_name, USS( sName ),
+ XML_name, sName.toUtf8(),
FSEND );
pFS->singleElementNS( mnXmlNamespace, XML_cNvGraphicFramePr,
@@ -526,9 +526,9 @@ void ChartExport::WriteChartObj( const Reference< XShape >&
xShape, sal_Int32 nI
XmlFilterBase* pFB = GetFB();
pFS->singleElement( FSNS( XML_c, XML_chart ),
-FSNS( XML_xmlns, XML_c ),
OUStringToOString(pFB->getNamespaceURL(OOX_NS(dmlChart)),
RTL_TEXTENCODING_UTF8).getStr(),
-FSNS( XML_xmlns, XML_r ),
OUStringToOString(pFB->getNamespaceURL(OOX_NS(officeRel)),
RTL_TEXTENCODING_UTF8).getStr(),
-FSNS( XML_r, XML_id ), USS( sId ),
+FSNS(XML_xmlns, XML_c),
pFB->getNamespaceURL(OOX_NS(dmlChart)).toUtf8(),
+FSNS(XML_xmlns, XML_r),
pFB->getNamespaceURL(OOX_NS(officeRel)).toUtf8(),
+FSNS(XML_r, XML_id), sId.toUtf8(),
FSEND );
pFS->endElement( FSNS( XML_a, XML_graphicData ) );
@@ -3082,7 +3082,8 @@ void writeCustomLabel( const FSHelperPtr& pFS,
ChartExport* pChartExport,
else
{
// Field
-pFS->startElement(FSNS(XML_a, XML_fld), XML_id,
USS(rField->getGuid()), XML_type, USS(sFieldType), FSEND);
+pFS->startElement(FSNS(XML_a, XML_fld), XML_id,
rField->getGuid().toUtf8(), XML_type,
+ sFieldType.toUtf8(), FSEND);
writeRunProperties(pChartExport, xPropertySet);
pFS->startElement(FSNS(XML_a, XML_t), FSEND);
diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index 4c1077b265f8..b5047b80eb15 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -190,7 +190,7 @@ bool DrawingML::GetProperty( const Reference< XPropertySet
>& rXPropertySet, con
}
catch( const Exception& )
{
-/* printf ("exception when trying to get value of property: %s\n",
USS(aName)); */
+/* printf ("exception when trying to get value of property: %s\n",
aName.toUtf8()); */
}
return false;
}
@@ -208,7 +208,7 @@ bool DrawingML::GetPropertyAndState( const Reference<
XPropertySet >& rXProperty
}
catch( const Exception& )
{
-/* printf ("exception
[Libreoffice-bugs] [Bug 112440] Change of language module in Writing aids isn't remembered
https://bugs.documentfoundation.org/show_bug.cgi?id=112440 Heiko Tietze changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||4542 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124542] Options: Apply button doesn't work in some cases if cancel afterwards
https://bugs.documentfoundation.org/show_bug.cgi?id=124542 Heiko Tietze changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||2440 --- Comment #2 from Heiko Tietze --- Same issue for language module in writing aid, see bug 112440. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124392] Redundant undo/redo items in grouped compact bar
https://bugs.documentfoundation.org/show_bug.cgi?id=124392 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | Ever confirmed|0 |1 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com |.freedesktop.org| Status|UNCONFIRMED |NEW --- Comment #2 from Heiko Tietze --- The actual layout of Notebookbar variants is up to the designer. Redundancy is per se not bad and I cannot argue whether or not having double it. It just depends on the design. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 124392] Redundant undo/redo items in grouped compact bar
https://bugs.documentfoundation.org/show_bug.cgi?id=124392 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | Ever confirmed|0 |1 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com |.freedesktop.org| Status|UNCONFIRMED |NEW --- Comment #2 from Heiko Tietze --- The actual layout of Notebookbar variants is up to the designer. Redundancy is per se not bad and I cannot argue whether or not having double it. It just depends on the design. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 124418] 'Pick a Color' dialog: Give option to add a color to the custom palette
https://bugs.documentfoundation.org/show_bug.cgi?id=124418 Heiko Tietze changed: What|Removed |Added Summary|COLOR PICKER DIALOG: Give |'Pick a Color' dialog: Give |option to add a color to|option to add a color to |the custom palette |the custom palette -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/svx reportdesign/source sd/inc sd/source svx/source
include/svx/svdundo.hxx|2 +-
reportdesign/source/core/inc/ReportUndoFactory.hxx |2 +-
reportdesign/source/core/sdr/ReportUndoFactory.cxx |4 ++--
sd/inc/undo/undofactory.hxx|2 +-
sd/inc/undo/undoobjects.hxx|2 +-
sd/source/core/undo/undofactory.cxx|4 ++--
sd/source/core/undo/undoobjects.cxx|4 ++--
svx/source/svdraw/svdundo.cxx |4 ++--
8 files changed, 12 insertions(+), 12 deletions(-)
New commits:
commit 3154770b49f84981432ccc3756ceb1840ff8d8a0
Author: Caolán McNamara
AuthorDate: Thu Apr 4 12:27:30 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 4 15:11:34 2019 +0200
CreateUndoRemoveObject default arg is always used
Change-Id: I5676281be56ff454962900fe7500d078b1f9e7e9
Reviewed-on: https://gerrit.libreoffice.org/70252
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/include/svx/svdundo.hxx b/include/svx/svdundo.hxx
index 0e30f39c4661..9c89285f7da2 100644
--- a/include/svx/svdundo.hxx
+++ b/include/svx/svdundo.hxx
@@ -709,7 +709,7 @@ public:
virtual std::unique_ptr CreateUndoMoveObject( SdrObject&
rObject, const Size& rDist );
virtual std::unique_ptr CreateUndoGeoObject( SdrObject&
rObject );
virtual std::unique_ptr CreateUndoAttrObject( SdrObject&
rObject, bool bStyleSheet1 = false, bool bSaveText = false );
-virtual std::unique_ptr CreateUndoRemoveObject( SdrObject&
rObject, bool bOrdNumDirect = false);
+virtual std::unique_ptr CreateUndoRemoveObject(SdrObject&
rObject);
virtual std::unique_ptr CreateUndoInsertObject( SdrObject&
rObject, bool bOrdNumDirect = false);
virtual std::unique_ptr CreateUndoDeleteObject( SdrObject&
rObject, bool bOrdNumDirect = false);
virtual std::unique_ptr CreateUndoNewObject( SdrObject&
rObject, bool bOrdNumDirect = false);
diff --git a/reportdesign/source/core/inc/ReportUndoFactory.hxx
b/reportdesign/source/core/inc/ReportUndoFactory.hxx
index 501bf68140b3..473f8ebe90c7 100644
--- a/reportdesign/source/core/inc/ReportUndoFactory.hxx
+++ b/reportdesign/source/core/inc/ReportUndoFactory.hxx
@@ -38,7 +38,7 @@ namespace rptui
virtual std::unique_ptr CreateUndoMoveObject(
SdrObject& rObject, const Size& rDist ) override;
virtual std::unique_ptr CreateUndoGeoObject( SdrObject&
rObject ) override;
virtual std::unique_ptr CreateUndoAttrObject(
SdrObject& rObject, bool bStyleSheet1 = false, bool bSaveText = false )
override;
-virtual std::unique_ptr CreateUndoRemoveObject(
SdrObject& rObject, bool bOrdNumDirect = false) override;
+virtual std::unique_ptr
CreateUndoRemoveObject(SdrObject& rObject) override;
virtual std::unique_ptr CreateUndoInsertObject(
SdrObject& rObject, bool bOrdNumDirect = false) override;
virtual std::unique_ptr CreateUndoDeleteObject(
SdrObject& rObject, bool bOrdNumDirect = false) override;
virtual std::unique_ptr CreateUndoNewObject( SdrObject&
rObject, bool bOrdNumDirect = false) override;
diff --git a/reportdesign/source/core/sdr/ReportUndoFactory.cxx
b/reportdesign/source/core/sdr/ReportUndoFactory.cxx
index 3ceba3851749..068e8ca8dcad 100644
--- a/reportdesign/source/core/sdr/ReportUndoFactory.cxx
+++ b/reportdesign/source/core/sdr/ReportUndoFactory.cxx
@@ -63,9 +63,9 @@ std::unique_ptr
OReportUndoFactory::CreateUndoAttrObject( SdrObje
return m_pUndoFactory->CreateUndoAttrObject( rObject, bStyleSheet1,
bSaveText );
}
-std::unique_ptr OReportUndoFactory::CreateUndoRemoveObject(
SdrObject& rObject, bool bOrdNumDirect )
+std::unique_ptr
OReportUndoFactory::CreateUndoRemoveObject(SdrObject& rObject)
{
-return m_pUndoFactory->CreateUndoRemoveObject( rObject, bOrdNumDirect );
+return m_pUndoFactory->CreateUndoRemoveObject(rObject);
}
std::unique_ptr OReportUndoFactory::CreateUndoInsertObject(
SdrObject& rObject, bool /*bOrdNumDirect*/ )
diff --git a/sd/inc/undo/undofactory.hxx b/sd/inc/undo/undofactory.hxx
index 742d0b358e76..e06f1e9ae029 100644
--- a/sd/inc/undo/undofactory.hxx
+++ b/sd/inc/undo/undofactory.hxx
@@ -28,7 +28,7 @@ namespace sd
class UndoFactory : public SdrUndoFactory
{
public:
-virtual std::unique_ptr CreateUndoRemoveObject( SdrObject&
rObject, bool bOrdNumDirect = false) override;
+virtual std::unique_ptr CreateUndoRemoveObject(SdrObject&
rObject) override;
virtual std::unique_ptr CreateUndoDeleteObject( SdrObject&
rObject, bool bOrdNumDirect = false) override;
virtual std::unique_ptr CreateUndoObjectSetText( SdrObject&
rNewObj, sal_Int32 nText ) override;
virtual std::unique_ptr CreateUndoReplaceObject( SdrObject&
rOldObject, SdrObject& rNewObject, bool bOrdNumDirect = false ) override;
diff --git a/sd/inc/undo/undoobjects.hxx b/sd/inc/undo/undoobjects.hxx
index 5121bc40c5f7..ad2f3d63fb00 100644
---
[Libreoffice-commits] core.git: include/vcl vcl/qa vcl/source
include/vcl/bitmap.hxx|6 ++--
vcl/qa/cppunit/BitmapTest.cxx | 20 +-
vcl/source/bitmap/BitmapColorQuantizationFilter.cxx |2 -
vcl/source/bitmap/BitmapSimpleColorQuantizationFilter.cxx |2 -
4 files changed, 13 insertions(+), 17 deletions(-)
New commits:
commit dc7fdd7e75ba4089e3c385479fd6b303d518efe5
Author: Tomaž Vajngerl
AuthorDate: Thu Apr 4 17:53:47 2019 +0900
Commit: Tomaž Vajngerl
CommitDate: Thu Apr 4 15:04:01 2019 +0200
change GetColorCount to use sal_Int64
Hopefully fixes problems on 32-bit linux.
Change-Id: I1fc22f1bb37c8297bd3bd6828206d1ffa9ae722d
Reviewed-on: https://gerrit.libreoffice.org/70241
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/vcl/bitmap.hxx b/include/vcl/bitmap.hxx
index 16dad0e6601d..71007c86b33d 100644
--- a/include/vcl/bitmap.hxx
+++ b/include/vcl/bitmap.hxx
@@ -131,7 +131,7 @@ public:
SizeGetSizePixel() const;
sal_uInt16 GetBitCount() const;
-inline sal_uLongGetColorCount() const;
+inline sal_Int64GetColorCount() const;
inline sal_uLongGetSizeBytes() const;
boolHasGreyPalette() const;
/** get system dependent bitmap data
@@ -574,9 +574,9 @@ inline void Bitmap::SetPrefSize( const Size& rSize )
maPrefSize = rSize;
}
-inline sal_uLong Bitmap::GetColorCount() const
+inline sal_Int64 Bitmap::GetColorCount() const
{
-return( sal_uLong(1) << static_cast(GetBitCount()) );
+return sal_Int64(1) << sal_Int64(GetBitCount());
}
inline sal_uLong Bitmap::GetSizeBytes() const
diff --git a/vcl/qa/cppunit/BitmapTest.cxx b/vcl/qa/cppunit/BitmapTest.cxx
index 11cfea33f2d6..632a243af0cf 100644
--- a/vcl/qa/cppunit/BitmapTest.cxx
+++ b/vcl/qa/cppunit/BitmapTest.cxx
@@ -77,8 +77,7 @@ void BitmapTest::testCreation()
CPPUNIT_ASSERT_MESSAGE("Not empty", aBmp.IsEmpty());
CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong bit count",
static_cast(0),
aBmp.GetBitCount());
-CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong color count",
static_cast(1),
- aBmp.GetColorCount());
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong color count", sal_Int64(1),
aBmp.GetColorCount());
CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong byte size",
static_cast(0),
aBmp.GetSizeBytes());
}
@@ -92,8 +91,7 @@ void BitmapTest::testCreation()
CPPUNIT_ASSERT_MESSAGE("Empty bitmap", !aBmp.IsEmpty());
CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong bit count",
static_cast(1),
aBmp.GetBitCount());
-CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong color count",
static_cast(2),
- aBmp.GetColorCount());
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong color count", sal_Int64(2),
aBmp.GetColorCount());
CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong byte size",
static_cast(12),
aBmp.GetSizeBytes());
}
@@ -107,8 +105,7 @@ void BitmapTest::testCreation()
CPPUNIT_ASSERT_MESSAGE("Empty bitmap", !aBmp.IsEmpty());
CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong bit count",
static_cast(4),
aBmp.GetBitCount());
-CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong color count",
static_cast(16),
- aBmp.GetColorCount());
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong color count", sal_Int64(16),
aBmp.GetColorCount());
CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong byte size",
static_cast(50),
aBmp.GetSizeBytes());
}
@@ -122,8 +119,7 @@ void BitmapTest::testCreation()
CPPUNIT_ASSERT_MESSAGE("Empty bitmap", !aBmp.IsEmpty());
CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong bit count",
static_cast(8),
aBmp.GetBitCount());
-CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong color count",
static_cast(256),
- aBmp.GetColorCount());
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong color count", sal_Int64(256),
aBmp.GetColorCount());
CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong byte size",
static_cast(100),
aBmp.GetSizeBytes());
}
@@ -137,7 +133,7 @@ void BitmapTest::testCreation()
CPPUNIT_ASSERT_MESSAGE("Empty bitmap", !aBmp.IsEmpty());
CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong bit count",
static_cast(24),
aBmp.GetBitCount());
-CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong color count",
static_cast(16777216),
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong color count", sal_Int64(16777216),
aBmp.GetColorCount());
CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong byte size",
static_cast(300),
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - toolkit/source
toolkit/source/controls/tabpagemodel.cxx |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
New commits:
commit b8412f1d8b70ee097f8cf00bf159514bd443ea07
Author: Vasily Melenchuk
AuthorDate: Wed Feb 6 00:41:25 2019 +0300
Commit: Thorsten Behrens
CommitDate: Thu Apr 4 15:02:17 2019 +0200
basic: fix for UnoControlTabPageModel get/set properties
The userformscontainers is required property to pass checks in
getter/setter, but returning true instead of actual type is
not a best idea. So let's return actually expected dummy empty
container.
Change-Id: I5cc3e5462ed82f6f2f8e5a45d9fc2d9f9ce1c76f
Reviewed-on: https://gerrit.libreoffice.org/67431
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 24e7d98219191ccdab3673ac96fa866c449cac5f)
Reviewed-on: https://gerrit.libreoffice.org/70235
Reviewed-by: Thorsten Behrens
diff --git a/toolkit/source/controls/tabpagemodel.cxx
b/toolkit/source/controls/tabpagemodel.cxx
index 044da501575e..5ddbe3d0f8ef 100644
--- a/toolkit/source/controls/tabpagemodel.cxx
+++ b/toolkit/source/controls/tabpagemodel.cxx
@@ -87,9 +87,10 @@ Any UnoControlTabPageModel::ImplGetDefaultValue( sal_uInt16
nPropId ) const
break;
case BASEPROPERTY_USERFORMCONTAINEES:
{
-// We do not have here any usercontainers (yet?), but let's return
something back
+// We do not have here any usercontainers (yet?), but let's return
empty container back
// so normal properties could be set without triggering
UnknownPropertyException
-return makeAny(true);
+aAny <<= uno::Reference< XNameContainer >();
+break;
}
default:
aAny = UnoControlModel::ImplGetDefaultValue( nPropId );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - 2 commits - toolkit/source
toolkit/source/controls/controlmodelcontainerbase.cxx |9 -
toolkit/source/controls/tabpagemodel.cxx |5 +++--
2 files changed, 11 insertions(+), 3 deletions(-)
New commits:
commit 7bb607467ff983a7d418537e06596263da733d74
Author: Vasily Melenchuk
AuthorDate: Wed Feb 6 00:41:25 2019 +0300
Commit: Thorsten Behrens
CommitDate: Thu Apr 4 15:02:03 2019 +0200
basic: fix for UnoControlTabPageModel get/set properties
The userformscontainers is required property to pass checks in
getter/setter, but returning true instead of actual type is
not a best idea. So let's return actually expected dummy empty
container.
Change-Id: I5cc3e5462ed82f6f2f8e5a45d9fc2d9f9ce1c76f
Reviewed-on: https://gerrit.libreoffice.org/67431
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 24e7d98219191ccdab3673ac96fa866c449cac5f)
Reviewed-on: https://gerrit.libreoffice.org/70234
Reviewed-by: Thorsten Behrens
diff --git a/toolkit/source/controls/tabpagemodel.cxx
b/toolkit/source/controls/tabpagemodel.cxx
index dc1730ea04a7..a8b45f108331 100644
--- a/toolkit/source/controls/tabpagemodel.cxx
+++ b/toolkit/source/controls/tabpagemodel.cxx
@@ -86,9 +86,10 @@ Any UnoControlTabPageModel::ImplGetDefaultValue( sal_uInt16
nPropId ) const
break;
case BASEPROPERTY_USERFORMCONTAINEES:
{
-// We do not have here any usercontainers (yet?), but let's return
something back
+// We do not have here any usercontainers (yet?), but let's return
empty container back
// so normal properties could be set without triggering
UnknownPropertyException
-return makeAny(true);
+aAny <<= uno::Reference< XNameContainer >();
+break;
}
default:
aAny = UnoControlModel::ImplGetDefaultValue( nPropId );
commit 5b9d543b7255eab74c401dee803bbac4a4ceef8a
Author: Vasily Melenchuk
AuthorDate: Tue Mar 26 15:23:28 2019 +0300
Commit: Thorsten Behrens
CommitDate: Thu Apr 4 15:01:48 2019 +0200
tdf#124385: toolkit: do not fail if ResourceListener is not defined
If current control (for example TabPageContainer) is missing
resource listener property we should not fail script with
exception. Just behave as with empty ResourceListener.
Change-Id: I260feec775a5d197bebc9414b652dd6f89e35035
Reviewed-on: https://gerrit.libreoffice.org/69740
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
(cherry picked from commit 4abb7335529a66346a2a68a089b9c8438faa2e39)
Reviewed-on: https://gerrit.libreoffice.org/70233
diff --git a/toolkit/source/controls/controlmodelcontainerbase.cxx
b/toolkit/source/controls/controlmodelcontainerbase.cxx
index 4d05caa81ff8..51f78d826a26 100644
--- a/toolkit/source/controls/controlmodelcontainerbase.cxx
+++ b/toolkit/source/controls/controlmodelcontainerbase.cxx
@@ -1743,6 +1743,9 @@ void
ControlContainerBase::ImplStartListingForResourceEvents()
{
Reference< resource::XStringResourceResolver > xStringResourceResolver;
+if ( !ImplHasProperty(PROPERTY_RESOURCERESOLVER) )
+return;
+
ImplGetPropertyValue( PROPERTY_RESOURCERESOLVER ) >>=
xStringResourceResolver;
// Add our helper as listener to retrieve notifications about changes
@@ -1759,7 +1762,11 @@ void ControlContainerBase::ImplUpdateResourceResolver()
{
Reference< resource::XStringResourceResolver > xStringResourceResolver;
-ImplGetPropertyValue( PROPERTY_RESOURCERESOLVER ) >>=
xStringResourceResolver;
+if ( !ImplHasProperty(PROPERTY_RESOURCERESOLVER) )
+return;
+
+ImplGetPropertyValue(PROPERTY_RESOURCERESOLVER) >>=
xStringResourceResolver;
+
if ( !xStringResourceResolver.is() )
return;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108619] Java Crash on x86 in jfw_plugin_startJavaVirtualMachine w/ recent linux kernels
https://bugs.documentfoundation.org/show_bug.cgi?id=108619 Xisco Faulí changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=12 | |4476| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124476] Calc occasionally crashes on File --> Open
https://bugs.documentfoundation.org/show_bug.cgi?id=124476 Xisco Faulí changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=10 | |8619| --- Comment #10 from Xisco Faulí --- bug 108619 is only happening in 32 bits... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/html
loleaflet/html/loading.html | 32
1 file changed, 32 deletions(-)
New commits:
commit afcfd7a616561decda77ab68bb756851a06038e7
Author: Alexandru Vlăduţu
AuthorDate: Thu Apr 4 15:32:47 2019 +0300
Commit: Szymon Kłos
CommitDate: Thu Apr 4 14:55:23 2019 +0200
loleaflet: remove loading html page leftover
loading.html resource made obsolete by commit
51e849bf5dcb4bcef1fd042bb45f07b4383cb461
Change-Id: I2308e4c121520f6ed293d5e86805c4daeec3fca6
Reviewed-on: https://gerrit.libreoffice.org/70257
Reviewed-by: Szymon Kłos
Tested-by: Szymon Kłos
diff --git a/loleaflet/html/loading.html b/loleaflet/html/loading.html
deleted file mode 100644
index a99cc7315..0
--- a/loleaflet/html/loading.html
+++ /dev/null
@@ -1,32 +0,0 @@
-
-
-
-
-
-
- .body {
-background: #FF;
- }
- .spinner
- {
-position: absolute;
-text-align: center;
-margin: auto;
-top: 0;
-right: 0;
-bottom: 0;
-left: 0;
-width: 100px;
-height: 100px;
- }
-
-
-
-
-
-
-
- var spinnerInterval =
window.parent.L.LOUtil.startSpinner(document.getElementById('spinner'), 1.5);
-
-
-
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108619] Java Crash on x86 in jfw_plugin_startJavaVirtualMachine w/ recent linux kernels
https://bugs.documentfoundation.org/show_bug.cgi?id=108619 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||4476 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124476] Calc occasionally crashes on File --> Open
https://bugs.documentfoundation.org/show_bug.cgi?id=124476 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||8619 --- Comment #9 from Roman Kuznetsov <79045_79...@mail.ru> --- try add to kernel parameter "stack_guard_gap=1" before start OS and try retest your bug with enabled JRE in LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123789] Extend SfxStyleFamily by Shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=123789 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #5 from Heiko Tietze --- (In reply to Xisco Faulí from comment #4) > What about adding this issue to the GSOC's ideas page ? https://wiki.documentfoundation.org/Development/GSoC/Ideas_without_a_mentor#Extend_SfxStyleFamily_by_Shapes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124476] Calc occasionally crashes on File --> Open
https://bugs.documentfoundation.org/show_bug.cgi?id=124476 --- Comment #8 from Roman Kuznetsov <79045_79...@mail.ru> --- (In reply to Owen Savill from comment #7) > Disabling Java seems to stop the crashing. Do you use any extensions in your LibreOffice? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124542] Options: Apply button doesn't work in some cases if cancel afterwards
https://bugs.documentfoundation.org/show_bug.cgi?id=124542 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124387] Crash after discarding file recovery
https://bugs.documentfoundation.org/show_bug.cgi?id=124387 Owen Savill changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID --- Comment #4 from Owen Savill --- I can no longer reproduce this. I have not updated LO so it's a bit of a mystery. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2-3' - sw/source
sw/source/core/doc/notxtfrm.cxx | 29 +++--
1 file changed, 27 insertions(+), 2 deletions(-)
New commits:
commit 1100ca5407e7ffd9ce58fc0c2f4afe7e8e60e0f8
Author: Armin Le Grand
AuthorDate: Tue Apr 2 17:59:40 2019 +0200
Commit: Michael Stahl
CommitDate: Thu Apr 4 14:39:14 2019 +0200
tdf#124272 use ClipRegion's geometry if not a rectangle
By error the ClipRegion's geometry was replaced by it's
BoundRect expanded to PixelBounds. If the ClipRegion
is not a rectangle, this will create wrong results. To
do both - extend to PixelBounds and have the original
geometry included - use the PolyPolygon topology as
needed (see comment in code for details)
Change-Id: If3f75223144eba8eb23909a7c701ad544346099b
Reviewed-on: https://gerrit.libreoffice.org/70146
Tested-by: Jenkins
Reviewed-by: Armin Le Grand
(cherry picked from commit 362c1cf2bd580f6dc8bf27bdcd79174111bc1b5c)
Reviewed-on: https://gerrit.libreoffice.org/70154
Reviewed-by: Thorsten Behrens
(cherry picked from commit 2b7b1a1501b88474ed5d691bafb45d465d8ab9f6)
Reviewed-on: https://gerrit.libreoffice.org/70181
Tested-by: Xisco Faulí
Tested-by: Thorsten Behrens
Reviewed-by: Xisco Faulí
Reviewed-by: Michael Stahl
diff --git a/sw/source/core/doc/notxtfrm.cxx b/sw/source/core/doc/notxtfrm.cxx
index 51c43fa0e2a1..04e556277738 100644
--- a/sw/source/core/doc/notxtfrm.cxx
+++ b/sw/source/core/doc/notxtfrm.cxx
@@ -982,9 +982,34 @@ void paintGraphicUsingPrimitivesHelper(
ceil(aClipRange.getMaxX() + aSinglePixelXY.getX()),
ceil(aClipRange.getMaxY() + aSinglePixelXY.getY()));
+// create the enclosing rectangle as polygon
+basegfx::B2DPolyPolygon
aTarget(basegfx::utils::createPolygonFromRect(aExpandedClipRange));
+
+// tdf#124272 the fix above (tdf#114076) was too rough - the
+// clip region used may be a PolyPolygon. In that case that
+// PolyPolygon would have to be scaled to mentioned PixelBounds.
+// Since that is not really possible geometrically (would need
+// more some 'grow in outside direction' but with unequal grow
+// values in all directions - just maaany problems
+// involved), use a graphical trick: The topology of the
+// PolyPolygon uses the stndard FillRule, so adding the now
+// guaranteed to be bigger or equal bounding (enclosing)
+// rectangle twice as polygon will expand the BoundRange, but
+// not change the geometry visualization at all
+if(!rOutputDevice.GetClipRegion().IsRectangle())
+{
+// double the outer rectangle range polygon to have it
+// included twice
+aTarget.append(aTarget.getB2DPolygon(0));
+
+// add the original clip 'inside' (due to being smaller
+// or equal). That PolyPolygon may have an unknown number
+// of polygons (>=1)
+aTarget.append(aClip);
+}
+
aContent[0] = new drawinglayer::primitive2d::MaskPrimitive2D(
-basegfx::B2DPolyPolygon(
-basegfx::utils::createPolygonFromRect(aExpandedClipRange)),
+aTarget,
aContent);
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 119978] Save dialog incorrectly selects first document in directory and pre-fills the filename with it
https://bugs.documentfoundation.org/show_bug.cgi?id=119978 Xisco Faulí changed: What|Removed |Added Resolution|FIXED |WORKSFORME --- Comment #6 from Xisco Faulí --- (In reply to Owen Savill from comment #5) > This appears to be fixed now, when Save As is selected the current filename > is selected even in the native Plasma file dialog. Thanks for retesting with the latest version. Setting to RESOLVED WORKSFORME as the commit fixing this issue hasn't been identified. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124387] Crash after discarding file recovery
https://bugs.documentfoundation.org/show_bug.cgi?id=124387 Owen Savill changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124356] Shift key is accepted as input and clears cell content in KDE
https://bugs.documentfoundation.org/show_bug.cgi?id=124356 Owen Savill changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #13 from Owen Savill --- Yes, it does. Opened for write a spreadsheet with content in cells A1 and B1. The first thing I did was press the Shift key and cell A1 was deleted. I have noticed that most meta keys do the same thing, those I've found so far are Tab, Ctrl, Alt, Alt Gr and both shift keys. LibreOffice knows a real edit has been made as it asks if it should save when the document is closed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-5-2+backports' - include/svtools svtools/source
include/svtools/prnsetup.hxx|1 +
svtools/source/dialogs/prnsetup.cxx |7 ++-
2 files changed, 7 insertions(+), 1 deletion(-)
New commits:
commit eaaf6f4f925bf04833a464176d376efe92cdcd69
Author: Katarina Behrens
AuthorDate: Thu Apr 4 12:27:23 2019 +0200
Commit: Thorsten Behrens
CommitDate: Thu Apr 4 14:34:13 2019 +0200
Redirect printer setup into the main thread
and avoid deadlock when called from extension in a non-main thread
Change-Id: I9fc0c02f580655015d583219b886c6b24af59c18
Reviewed-on: https://gerrit.libreoffice.org/70256
Reviewed-by: Thorsten Behrens
Tested-by: Thorsten Behrens
diff --git a/include/svtools/prnsetup.hxx b/include/svtools/prnsetup.hxx
index 007294e52656..267274d8d61a 100644
--- a/include/svtools/prnsetup.hxx
+++ b/include/svtools/prnsetup.hxx
@@ -47,6 +47,7 @@ private:
AutoTimer maStatusTimer;
VclPtrmpPrinter;
VclPtrmpTempPrinter;
+short solar_execute();
SVT_DLLPRIVATE void ImplSetInfo();
diff --git a/svtools/source/dialogs/prnsetup.cxx
b/svtools/source/dialogs/prnsetup.cxx
index cf8a3f5c5eb9..e7362e7bc44c 100644
--- a/svtools/source/dialogs/prnsetup.cxx
+++ b/svtools/source/dialogs/prnsetup.cxx
@@ -21,6 +21,7 @@
#include
#include
#include
+#include
void ImplFillPrnDlgListBox( const Printer* pPrinter,
@@ -331,6 +332,10 @@ void PrinterSetupDialog::DataChanged( const
DataChangedEvent& rDCEvt )
ModalDialog::DataChanged( rDCEvt );
}
+short PrinterSetupDialog::solar_execute()
+{
+return ModalDialog::Execute();
+}
short PrinterSetupDialog::Execute()
{
@@ -347,7 +352,7 @@ short PrinterSetupDialog::Execute()
maStatusTimer.Start();
// start dialog
-short nRet = ModalDialog::Execute();
+short nRet =
vcl::solarthread::syncExecute(std::bind(::solar_execute,
this));
// update data if the dialog was terminated with OK
if ( nRet == RET_OK )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2-3' - vcl/source
vcl/source/edit/textundo.cxx | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
New commits:
commit 0d66d95df3bf930926e888dfe8a8060d7c037d6e
Author: Noel Grandin
AuthorDate: Mon Apr 1 14:38:01 2019 +0200
Commit: Noel Grandin
CommitDate: Thu Apr 4 14:32:10 2019 +0200
tdf#124413 Crash on undo / redo in Basic IDE
regression from
commit 3a9d3f271c445641bebd057c4c91279f9b3cd7d5
Date: Mon Apr 23 09:38:41 2018 +0200
loplugin:useuniqueptr in TextDoc
Change-Id: I51ab5de7571e4ec358442e54d590adf88fbeb12d
Reviewed-on: https://gerrit.libreoffice.org/70061
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit 3ebdb97a305ada182af045ea6438432adfe74e80)
Reviewed-on: https://gerrit.libreoffice.org/70076
Tested-by: Xisco Faulí
Reviewed-by: Michael Stahl
diff --git a/vcl/source/edit/textundo.cxx b/vcl/source/edit/textundo.cxx
index 80e26d34c577..adbf8be9076c 100644
--- a/vcl/source/edit/textundo.cxx
+++ b/vcl/source/edit/textundo.cxx
@@ -163,14 +163,19 @@ void TextUndoDelPara::Undo()
void TextUndoDelPara::Redo()
{
+auto & rDocNodes = GetDoc()->GetNodes();
// pNode is not valid anymore in case an Undo joined paragraphs
-mpNode = GetDoc()->GetNodes()[ mnPara ].get();
+mpNode = rDocNodes[ mnPara ].get();
GetTEParaPortions()->Remove( mnPara );
// do not delete Node because of Undo!
-GetDoc()->GetNodes().erase( ::std::find_if( GetDoc()->GetNodes().begin(),
GetDoc()->GetNodes().end(),
-[&] (std::unique_ptr
const & p) { return p.get() == mpNode; } ) );
+auto it = ::std::find_if( rDocNodes.begin(), rDocNodes.end(),
+ [&] (std::unique_ptr const & p) {
return p.get() == mpNode; } );
+assert(it != rDocNodes.end());
+it->release();
+GetDoc()->GetNodes().erase( it );
+
GetTextEngine()->ImpParagraphRemoved( mnPara );
mbDelObject = true; // belongs again to the Undo
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [GSOC] LibreOffice appliances idea
Figured I'll post my proposal. Any input, positive or negative, from anyone, is welcome. https://docs.google.com/document/d/1FZKM2I_5Fc2ENsLxlMmkWTo6GJaS8_QHiYEERIVxVfY/edit?usp=sharing ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 119978] Save dialog incorrectly selects first document in directory and pre-fills the filename with it
https://bugs.documentfoundation.org/show_bug.cgi?id=119978 Owen Savill changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO|RESOLVED --- Comment #5 from Owen Savill --- This appears to be fixed now, when Save As is selected the current filename is selected even in the native Plasma file dialog. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124476] Calc occasionally crashes on File --> Open
https://bugs.documentfoundation.org/show_bug.cgi?id=124476 Owen Savill changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #7 from Owen Savill --- Disabling Java seems to stop the crashing. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc vcl/qt5 vcl/unx
vcl/inc/qt5/Qt5Instance.hxx | 22 +++-
vcl/qt5/Qt5Instance.cxx | 104 ++-
vcl/unx/kde5/KDE5SalInstance.cxx | 82 +++---
vcl/unx/kde5/KDE5SalInstance.hxx |4 +
4 files changed, 92 insertions(+), 120 deletions(-)
New commits:
commit 810e62b8ba9c0fa5152592ef6b01400bfcfe59c0
Author: Jan-Marek Glogowski
AuthorDate: Sat Mar 23 04:05:04 2019 +
Commit: Jan-Marek Glogowski
CommitDate: Thu Apr 4 14:19:43 2019 +0200
Qt5 / KDE5 refactor create_SalInstance
Move most common code into Qt5Instance (static) functions.
Not much saved with regard to LOC, but since the code was
95% C'n'P, I hope it'll be less error prone this way.
Also handle all QApplication argument pointers via
std::unique_ptr from the beginning.
Change-Id: I87b2f571d398db7ccce3e740f16205b251be4ced
Reviewed-on: https://gerrit.libreoffice.org/69578
Tested-by: Jenkins
Reviewed-by: Aleksei Nikiforov
diff --git a/vcl/inc/qt5/Qt5Instance.hxx b/vcl/inc/qt5/Qt5Instance.hxx
index 52153846faa1..a9be3581f64b 100644
--- a/vcl/inc/qt5/Qt5Instance.hxx
+++ b/vcl/inc/qt5/Qt5Instance.hxx
@@ -27,12 +27,21 @@
#include
+#include
#include
+#include
+#include
class QApplication;
class SalYieldMutex;
class SalFrame;
+struct StdFreeCStr
+{
+void operator()(char* arg) const noexcept { std::free(arg); }
+};
+using FreeableCStr = std::unique_ptr;
+
class VCLPLUG_QT5_PUBLIC Qt5Instance : public QObject,
public SalGenericInstance,
public SalUserEventList
@@ -44,9 +53,8 @@ class VCLPLUG_QT5_PUBLIC Qt5Instance : public QObject,
const bool m_bUseCairo;
std::unordered_map>
m_aClipboards;
-public:
std::unique_ptr m_pQApplication;
-std::unique_ptr m_pFakeArgvFreeable;
+std::vector m_pFakeArgvFreeable;
std::unique_ptr m_pFakeArgv;
std::unique_ptr m_pFakeArgc;
@@ -61,9 +69,17 @@ Q_SIGNALS:
void deleteObjectLaterSignal(QObject* pObject);
public:
-explicit Qt5Instance(bool bUseCairo = false);
+explicit Qt5Instance(std::unique_ptr& pQApp, bool bUseCairo
= false);
virtual ~Qt5Instance() override;
+// handle common SalInstance setup
+static void AllocFakeCmdlineArgs(std::unique_ptr& rFakeArgv,
+ std::unique_ptr& rFakeArgc,
+ std::vector&
rFakeArgvFreeable);
+void MoveFakeCmdlineArgs(std::unique_ptr& rFakeArgv,
std::unique_ptr& rFakeArgc,
+ std::vector& rFakeArgvFreeable);
+static std::unique_ptr CreateQApplication(int& nArgc, char**
pArgv);
+
void RunInMainThread(std::function func);
virtual SalFrame* CreateFrame(SalFrame* pParent, SalFrameStyleFlags
nStyle) override;
diff --git a/vcl/qt5/Qt5Instance.cxx b/vcl/qt5/Qt5Instance.cxx
index f0d42666e3ce..dd0edddc97cf 100644
--- a/vcl/qt5/Qt5Instance.cxx
+++ b/vcl/qt5/Qt5Instance.cxx
@@ -200,10 +200,11 @@ void Qt5Instance::ImplRunInMain()
(void)this; // suppress unhelpful [loplugin:staticmethods]; can't be static
}
-Qt5Instance::Qt5Instance(bool bUseCairo)
+Qt5Instance::Qt5Instance(std::unique_ptr& pQApp, bool bUseCairo)
: SalGenericInstance(std::make_unique())
, m_postUserEventId(-1)
, m_bUseCairo(bUseCairo)
+, m_pQApplication(std::move(pQApp))
{
ImplSVData* pSVData = ImplGetSVData();
if (bUseCairo)
@@ -232,8 +233,6 @@ Qt5Instance::~Qt5Instance()
// force freeing the QApplication before freeing the arguments,
// as it uses references to the provided arguments!
m_pQApplication.reset();
-for (int i = 0; i < *m_pFakeArgc; i++)
-free(m_pFakeArgvFreeable[i]);
}
void Qt5Instance::deleteObjectLater(QObject* pObject) {
pObject->deleteLater(); }
@@ -441,18 +440,16 @@ Reference Qt5Instance::CreateDropTarget()
return Reference(static_cast(new
Qt5DropTarget()));
}
-extern "C" {
-VCLPLUG_QT5_PUBLIC SalInstance* create_SalInstance()
+void Qt5Instance::AllocFakeCmdlineArgs(std::unique_ptr& rFakeArgv,
+ std::unique_ptr& rFakeArgc,
+ std::vector&
rFakeArgvFreeable)
{
OString aVersion(qVersion());
SAL_INFO("vcl.qt5", "qt version string is " << aVersion);
-QApplication* pQApplication;
-char** pFakeArgvFreeable = nullptr;
-
-int nFakeArgc = 2;
const sal_uInt32 nParams = osl_getCommandArgCount();
OString aDisplay;
+sal_uInt32 nDisplayValueIdx = 0;
OUString aParam, aBin;
for (sal_uInt32 nIdx = 0; nIdx < nParams; ++nIdx)
@@ -460,66 +457,85 @@ VCLPLUG_QT5_PUBLIC SalInstance* create_SalInstance()
osl_getCommandArg(nIdx, );
if (aParam != "-display")
continue;
-if (!pFakeArgvFreeable)
-{
-pFakeArgvFreeable = new char*[nFakeArgc + 2];
-
[Libreoffice-commits] core.git: vcl/Library_vclplug_kde5.mk vcl/qt5 vcl/unx
vcl/Library_vclplug_kde5.mk |1
vcl/qt5/Qt5Data.cxx | 15 +-
vcl/unx/kde5/KDE5SalData.cxx | 56 ---
vcl/unx/kde5/KDE5SalData.hxx | 33 --
vcl/unx/kde5/KDE5SalInstance.cxx |8 ++---
5 files changed, 16 insertions(+), 97 deletions(-)
New commits:
commit ae1e23651a6d2e97d39bbe46bab83b7982d19611
Author: Jan-Marek Glogowski
AuthorDate: Sun Mar 31 11:29:30 2019 +
Commit: Jan-Marek Glogowski
CommitDate: Thu Apr 4 14:17:55 2019 +0200
KDE5 merge KDE5SalData into Qt5Data
Currently there is no point for a seperate KDE5 SalData class.
The additional NWF settings fix the wrong popup menu for qt5, so
this just moves all the NWF data and gets rid of KDE5SalData.
Change-Id: I1c02d1f660df288a0d2e1c6607b34fc1ce593727
Reviewed-on: https://gerrit.libreoffice.org/70005
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/vcl/Library_vclplug_kde5.mk b/vcl/Library_vclplug_kde5.mk
index 704557150ae5..f011f397d7d3 100644
--- a/vcl/Library_vclplug_kde5.mk
+++ b/vcl/Library_vclplug_kde5.mk
@@ -80,7 +80,6 @@ $(eval $(call gb_Library_add_libs,vclplug_kde5,\
$(eval $(call gb_Library_add_exception_objects,vclplug_kde5,\
vcl/unx/kde5/KDE5FilePicker2 \
-vcl/unx/kde5/KDE5SalData \
vcl/unx/kde5/KDE5SalFrame \
vcl/unx/kde5/KDE5SalGraphics \
vcl/unx/kde5/KDE5SalInstance \
diff --git a/vcl/qt5/Qt5Data.cxx b/vcl/qt5/Qt5Data.cxx
index 597a0a4d0a77..9f9bf2557c3d 100644
--- a/vcl/qt5/Qt5Data.cxx
+++ b/vcl/qt5/Qt5Data.cxx
@@ -19,8 +19,10 @@
#include
-#include
#include
+#include
+#include
+#include
#include
@@ -156,8 +158,17 @@ Qt5Data::Qt5Data(SalInstance* pInstance)
{
ImplSVData* pSVData = ImplGetSVData();
-// draw toolbars on separate lines
pSVData->maNWFData.mbDockingAreaSeparateTB = true;
+pSVData->maNWFData.mbFlatMenu = true;
+pSVData->maNWFData.mbRolloverMenubar = true;
+pSVData->maNWFData.mbNoFocusRects = true;
+pSVData->maNWFData.mbNoFocusRectsForFlatButtons = true;
+
+QStyle* style = QApplication::style();
+pSVData->maNWFData.mnMenuFormatBorderX =
style->pixelMetric(QStyle::PM_MenuPanelWidth)
+ +
style->pixelMetric(QStyle::PM_MenuHMargin);
+pSVData->maNWFData.mnMenuFormatBorderY =
style->pixelMetric(QStyle::PM_MenuPanelWidth)
+ +
style->pixelMetric(QStyle::PM_MenuVMargin);
}
// outline dtor b/c of GlyphCache incomplete type
diff --git a/vcl/unx/kde5/KDE5SalData.cxx b/vcl/unx/kde5/KDE5SalData.cxx
deleted file mode 100644
index 587bf021410b..
--- a/vcl/unx/kde5/KDE5SalData.cxx
+++ /dev/null
@@ -1,56 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the "License"); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#include
-#include
-
-#undef Region
-
-#include "KDE5SalData.hxx"
-
-KDE5SalData::KDE5SalData(SalInstance* pInstance)
-: Qt5Data(pInstance)
-{
-}
-
-KDE5SalData::~KDE5SalData() {}
-
-void KDE5SalData::initNWF()
-{
-ImplSVData* pSVData = ImplGetSVData();
-
-// draw toolbars on separate lines
-pSVData->maNWFData.mbDockingAreaSeparateTB = true;
-// no borders for menu, theming does that
-pSVData->maNWFData.mbFlatMenu = true;
-// Qt theme engines may support a rollover menubar
-pSVData->maNWFData.mbRolloverMenubar = true;
-
-pSVData->maNWFData.mbNoFocusRects = true;
-pSVData->maNWFData.mbNoFocusRectsForFlatButtons = true;
-
-// Styled menus need additional space
-QStyle* style = QApplication::style();
-pSVData->maNWFData.mnMenuFormatBorderX =
style->pixelMetric(QStyle::PM_MenuPanelWidth)
- +
style->pixelMetric(QStyle::PM_MenuHMargin);
-pSVData->maNWFData.mnMenuFormatBorderY =
style->pixelMetric(QStyle::PM_MenuPanelWidth)
- +
style->pixelMetric(QStyle::PM_MenuVMargin);
-}
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/unx/kde5/KDE5SalData.hxx b/vcl/unx/kde5/KDE5SalData.hxx
deleted file mode 100644
[Libreoffice-bugs] [Bug 124547] New: LibreOffice rendering html border wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=124547 Bug ID: 124547 Summary: LibreOffice rendering html border wrong Product: LibreOffice Version: 6.0.6.2 release Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: korbinian.neuhaeus...@sae-portal.de Description: Rendering of html border is making a border out of 0px solid black Steps to Reproduce: 1. save the following code sniped into a file with extension .html and load it into libre office via drag and drop or insert -> text from file 0px solid black 0pt solid black Actual Results: a field with a border Expected Results: a field without a border Reproducible: Always User Profile Reset: No Additional Info: Version: 6.0.6.2 Build ID: 0c292870b25a325b5ed35f6b45599d2ea4458e77 CPU threads: 8; OS: Mac OS X 10.14.4; UI render: default; Locale: de-DE (de_DE.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - scp2/source
scp2/source/ooo/module_systemint.scp |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
New commits:
commit d06353475daf23b5afdaabf6784e0b7c26e8e350
Author: Jim Jagielski
AuthorDate: Thu Apr 4 11:28:00 2019 +
Commit: Jim Jagielski
CommitDate: Thu Apr 4 11:28:00 2019 +
Merge r1856914 from trunk:
Reviewed by: jim
diff --git a/scp2/source/ooo/module_systemint.scp
b/scp2/source/ooo/module_systemint.scp
index 684febdea109..dcb87b7130f3 100644
--- a/scp2/source/ooo/module_systemint.scp
+++ b/scp2/source/ooo/module_systemint.scp
@@ -36,7 +36,14 @@ Module gid_Module_Optional_Systemintegration
#else
Styles =
(SYSTEMMODULE,NOTRELOCATABLE,DONTSHOWINUSERINSTALL,INSTALLCANFAIL,USEFORCE);
#endif
- #if (defined(LINUX)) || (defined(SOLARIS))
+/*
+ * Hardcode name as 'openoffice' to handle Beta and Dev builds which
+ * would result in openoffice_beta, for example.
+ * See sysui/desktop/productversion.mk
+ */
+ #if (defined(LINUX))
+PackageName = "openoffice-desktop-integration.tar.gz";
+ #elif (defined(SOLARIS))
PackageName = "${SYSTEMINTUNIXPACKAGENAME}-desktop-integration.tar.gz";
#else
PackageName = "";
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 122780] FILEOPEN DOCX Crash with too long Template tag in app.xml
https://bugs.documentfoundation.org/show_bug.cgi?id=122780 Caolán McNamara changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | --- Comment #13 from Caolán McNamara --- its clearly an unreasonable length, there isn't anything in the spec however to justify clipping it at some arbitrary level, so lets clip it in the dialog to something like the max path length of the OS -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114773] TOC: Remove additional space after chapter number in ToC
https://bugs.documentfoundation.org/show_bug.cgi?id=114773 --- Comment #15 from Yvan Rose --- I just did some check with LO 6.2.2.2. The same problem is there. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72606] Consistently call Unicode Win32 functions, and define UNICODE globally
https://bugs.documentfoundation.org/show_bug.cgi?id=72606 Michael Stahl (CIB) changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #27 from Michael Stahl (CIB) --- Mike Kaganski has fixed it now with commit 558956dc811a1f0f07411e348f7081a467bbc3b5 "Drop UNICODE/_UNICODE defines" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: comphelper/StaticLibrary_windows_process.mk desktop/Executable_minidump_upload.mk desktop/Executable_sbase.mk desktop/Executable_scalc.mk desktop/Executable_sdraw.mk de
comphelper/StaticLibrary_windows_process.mk|4 desktop/Executable_minidump_upload.mk |4 desktop/Executable_sbase.mk|4 desktop/Executable_scalc.mk|4 desktop/Executable_sdraw.mk|4 desktop/Executable_simpress.mk |4 desktop/Executable_smath.mk|4 desktop/Executable_sweb.mk |4 desktop/Executable_swriter.mk |4 desktop/StaticLibrary_winlauncher.mk |4 dtrans/Library_sysdtrans.mk|5 - fpicker/Library_fps.mk |5 - onlineupdate/Executable_mar.mk |1 - onlineupdate/Executable_mbsdiff.mk |4 onlineupdate/Executable_test_updater_dialog.mk |4 onlineupdate/Executable_update_service.mk |4 onlineupdate/Executable_updater.mk |1 - onlineupdate/StaticLibrary_libmar.mk |4 onlineupdate/StaticLibrary_libmarverify.mk |6 +- onlineupdate/StaticLibrary_updatehelper.mk |1 - setup_native/Library_reg4allmsdoc.mk |2 -- setup_native/Library_shlxtmsi.mk |2 -- setup_native/StaticLibrary_quickstarter.mk |2 -- shell/Library_ooofilt.mk |2 -- shell/Library_ooofilt_x64.mk |2 -- shell/Library_propertyhdl.mk |2 -- shell/Library_propertyhdl_x64.mk |2 -- shell/Library_shlxthdl.mk |2 -- shell/Library_shlxthdl_x64.mk |2 -- shell/Library_spsupp.mk|5 - shell/Library_spsupp_x64.mk|5 - shell/StaticLibrary_shlxthandler_common.mk |2 -- shell/StaticLibrary_shlxthandler_common_x64.mk |2 -- winaccessibility/Library_uacccom.mk|2 -- 34 files changed, 1 insertion(+), 108 deletions(-) New commits: commit 558956dc811a1f0f07411e348f7081a467bbc3b5 Author: Mike Kaganski AuthorDate: Wed Apr 3 14:10:16 2019 +0300 Commit: Mike Kaganski CommitDate: Thu Apr 4 13:57:59 2019 +0200 Drop UNICODE/_UNICODE defines The code is using expicit (mostly W) Windows API, and is independent from the macro. Removing it here allows to catch places where some UNICODE-dependent macro is used unintentionally. Change-Id: I5dff40aecfc3c3dc7fc4cf7271a995a675943a45 Reviewed-on: https://gerrit.libreoffice.org/70237 Reviewed-by: Michael Stahl Reviewed-by: Mike Kaganski Tested-by: Mike Kaganski diff --git a/comphelper/StaticLibrary_windows_process.mk b/comphelper/StaticLibrary_windows_process.mk index 1b086eac952b..2ef95e46a071 100644 --- a/comphelper/StaticLibrary_windows_process.mk +++ b/comphelper/StaticLibrary_windows_process.mk @@ -13,10 +13,6 @@ $(eval $(call gb_StaticLibrary_set_include,windows_process,\ $$(INCLUDE) \ )) -$(eval $(call gb_StaticLibrary_add_defs,windows_process,\ - -DUNICODE \ -)) - $(eval $(call gb_StaticLibrary_add_exception_objects,windows_process,\ comphelper/source/windows/windows_process \ )) diff --git a/desktop/Executable_minidump_upload.mk b/desktop/Executable_minidump_upload.mk index 959d4af8c7c1..ccdcc97e743d 100644 --- a/desktop/Executable_minidump_upload.mk +++ b/desktop/Executable_minidump_upload.mk @@ -14,10 +14,6 @@ $(eval $(call gb_Executable_use_libraries,minidump_upload,\ sal \ )) -$(eval $(call gb_Executable_add_defs,minidump_upload,\ - -DUNICODE \ -)) - $(eval $(call gb_Executable_use_external,minidump_upload,curl)) $(eval $(call gb_Executable_add_exception_objects,minidump_upload,\ diff --git a/desktop/Executable_sbase.mk b/desktop/Executable_sbase.mk index 4dd6be02a9ee..d3a4fafea810 100644 --- a/desktop/Executable_sbase.mk +++ b/desktop/Executable_sbase.mk @@ -11,10 +11,6 @@ $(eval $(call gb_Executable_Executable,sbase)) $(eval $(call gb_Executable_set_targettype_gui,sbase,YES)) -$(eval $(call gb_Executable_add_defs,sbase,\ --DUNICODE \ -)) - $(eval $(call gb_Executable_add_ldflags,sbase,\ /ENTRY:wWinMainCRTStartup \ )) diff --git a/desktop/Executable_scalc.mk b/desktop/Executable_scalc.mk index fc066770b945..1a21840a3306 100644 --- a/desktop/Executable_scalc.mk +++ b/desktop/Executable_scalc.mk @@ -11,10 +11,6 @@ $(eval $(call gb_Executable_Executable,scalc)) $(eval $(call gb_Executable_set_targettype_gui,scalc,YES)) -$(eval $(call gb_Executable_add_defs,scalc,\ --DUNICODE \ -)) - $(eval $(call gb_Executable_add_ldflags,scalc,\ /ENTRY:wWinMainCRTStartup \ )) diff --git a/desktop/Executable_sdraw.mk b/desktop/Executable_sdraw.mk index 1b12bb0f2467..c6fd96373de1 100644 --- a/desktop/Executable_sdraw.mk +++ b/desktop/Executable_sdraw.mk @@ -11,10 +11,6 @@ $(eval $(call gb_Executable_Executable,sdraw)) $(eval
[Libreoffice-bugs] [Bug 124544] Slideshow loading spinner closes too early
https://bugs.documentfoundation.org/show_bug.cgi?id=124544 Alexandru Vladutu changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |alexandru.vlad...@1and1.ro |desktop.org | Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #1 from Alexandru Vladutu --- Fixed via https://gerrit.libreoffice.org/#/c/70250/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: configure.ac vcl/headless vcl/source
configure.ac |2 +-
vcl/headless/svpgdi.cxx |8
vcl/source/bitmap/BitmapTools.cxx |4
3 files changed, 1 insertion(+), 13 deletions(-)
New commits:
commit 50580f452cc7c88a231831619a3f05958ce56460
Author: Caolán McNamara
AuthorDate: Thu Apr 4 10:18:57 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 4 13:51:36 2019 +0200
raise cairo baseline to 1.12.0
Change-Id: I1816f23fea88e6b840539a88504956b00a546522
Reviewed-on: https://gerrit.libreoffice.org/70243
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/configure.ac b/configure.ac
index c2fbe8c6e0da..02ea8809de4b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -11600,7 +11600,7 @@ if test "$test_cairo" = "yes"; then
SYSTEM_CAIRO=TRUE
AC_MSG_RESULT([yes])
-PKG_CHECK_MODULES( CAIRO, cairo >= 1.10.0 )
+PKG_CHECK_MODULES( CAIRO, cairo >= 1.12.0 )
CAIRO_CFLAGS=$(printf '%s' "$CAIRO_CFLAGS" | sed -e
"s/-I/${ISYSTEM?}/g")
FilterLibs "${CAIRO_LIBS}"
CAIRO_LIBS="${filteredlibs}"
diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 6ea82e67ee55..b072bf946cdc 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -1739,11 +1739,7 @@ std::shared_ptr SvpSalGraphics::getBitmap(
long nX, long nY, long nWi
Color SvpSalGraphics::getPixel( long nX, long nY )
{
-#if CAIRO_VERSION >= CAIRO_VERSION_ENCODE(1, 12, 0)
cairo_surface_t *target = cairo_surface_create_similar_image(m_pSurface,
CAIRO_FORMAT_ARGB32, 1, 1);
-#else
-cairo_surface_t *target = cairo_image_surface_create(CAIRO_FORMAT_ARGB32,
1, 1);
-#endif
cairo_t* cr = cairo_create(target);
@@ -1977,11 +1973,7 @@ cairo_surface_t*
SvpSalGraphics::createCairoSurface(const BitmapBuffer *pBuffer)
cairo_t* SvpSalGraphics::createTmpCompatibleCairoContext() const
{
-#if CAIRO_VERSION >= CAIRO_VERSION_ENCODE(1, 12, 0)
cairo_surface_t *target = cairo_surface_create_similar_image(m_pSurface,
-#else
-cairo_surface_t *target = cairo_image_surface_create(
-#endif
CAIRO_FORMAT_ARGB32,
m_aFrameSize.getX() * m_fScale,
m_aFrameSize.getY() * m_fScale);
diff --git a/vcl/source/bitmap/BitmapTools.cxx
b/vcl/source/bitmap/BitmapTools.cxx
index 6f14c3526d42..212557d3c28a 100644
--- a/vcl/source/bitmap/BitmapTools.cxx
+++ b/vcl/source/bitmap/BitmapTools.cxx
@@ -236,11 +236,7 @@ BitmapEx* CreateFromCairoSurface(Size aSize,
cairo_surface_t * pSurface)
// FIXME: if we could teach VCL/ about cairo handles, life could
// be significantly better here perhaps.
-#if CAIRO_VERSION >= CAIRO_VERSION_ENCODE(1, 12, 0)
cairo_surface_t *pPixels = cairo_surface_create_similar_image(pSurface,
-#else
-cairo_surface_t *pPixels = cairo_image_surface_create(
-#endif
CAIRO_FORMAT_ARGB32, aSize.Width(), aSize.Height());
cairo_t *pCairo = cairo_create( pPixels );
if( !pPixels || !pCairo || cairo_status(pCairo) != CAIRO_STATUS_SUCCESS )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: configure.ac vcl/headless
configure.ac|2 +-
vcl/headless/svpgdi.cxx | 15 +--
2 files changed, 2 insertions(+), 15 deletions(-)
New commits:
commit 58a0e60dee0d27a699f856827c20b792417d3478
Author: Caolán McNamara
AuthorDate: Thu Apr 4 10:02:11 2019 +0100
Commit: Caolán McNamara
CommitDate: Thu Apr 4 13:50:54 2019 +0200
raise cairo baseline to 1.10.0
Change-Id: I721b80d7ce28d36babbd2bd1957fcbd6a2d27a27
Reviewed-on: https://gerrit.libreoffice.org/70242
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/configure.ac b/configure.ac
index f35fe56c02f6..c2fbe8c6e0da 100644
--- a/configure.ac
+++ b/configure.ac
@@ -11600,7 +11600,7 @@ if test "$test_cairo" = "yes"; then
SYSTEM_CAIRO=TRUE
AC_MSG_RESULT([yes])
-PKG_CHECK_MODULES( CAIRO, cairo >= 1.2.0 )
+PKG_CHECK_MODULES( CAIRO, cairo >= 1.10.0 )
CAIRO_CFLAGS=$(printf '%s' "$CAIRO_CFLAGS" | sed -e
"s/-I/${ISYSTEM?}/g")
FilterLibs "${CAIRO_LIBS}"
CAIRO_LIBS="${filteredlibs}"
diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 2cf49ca17696..6ea82e67ee55 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -47,12 +47,6 @@
#include
#include
-#if ENABLE_CAIRO_CANVAS
-# if defined CAIRO_VERSION && CAIRO_VERSION < CAIRO_VERSION_ENCODE(1, 10, 0)
-# define CAIRO_OPERATOR_DIFFERENCE (static_cast(23))
-# endif
-#endif
-
namespace
{
basegfx::B2DRange getClipBox(cairo_t* cr)
@@ -1805,14 +1799,7 @@ void SvpSalGraphics::invert(const basegfx::B2DPolygon
, SalInvert nFlags)
cairo_set_source_rgb(cr, 1.0, 1.0, 1.0);
-if (cairo_version() >= CAIRO_VERSION_ENCODE(1, 10, 0))
-{
-cairo_set_operator(cr, CAIRO_OPERATOR_DIFFERENCE);
-}
-else
-{
-SAL_WARN("vcl.gdi", "SvpSalGraphics::invert, archaic cairo");
-}
+cairo_set_operator(cr, CAIRO_OPERATOR_DIFFERENCE);
if (nFlags & SalInvert::TrackFrame)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loleaflet/css loleaflet/Makefile.am loleaflet/src
loleaflet/Makefile.am |1 +
loleaflet/css/leaflet-spinner.css |3 +++
loleaflet/src/map/handler/Map.SlideShow.js |2 --
3 files changed, 4 insertions(+), 2 deletions(-)
New commits:
commit 51e849bf5dcb4bcef1fd042bb45f07b4383cb461
Author: Alexandru Vlăduţu
AuthorDate: Thu Apr 4 13:57:23 2019 +0300
Commit: Szymon Kłos
CommitDate: Thu Apr 4 13:46:29 2019 +0200
loleaflet: optimize slideshow spinner
This commit fixes 2 issues:
- a UX issue described by tdf#124544 (slideshow spinner is not
displayed for the correct duration - user shown a blank screen while the
browser downloads slideshow.svg)
- an additional HTTP request is being made to loading.html just to
display an ordinary spinner (that can be otherwise loaded via css for
example)
tdf#124544
Change-Id: I90d1e73d1514d736dd58a53caa5921b42bc1bd75
Reviewed-on: https://gerrit.libreoffice.org/70250
Reviewed-by: Szymon Kłos
Tested-by: Szymon Kłos
diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index b3e084148..d6cff247e 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -63,6 +63,7 @@ LOLEAFLET_CSS =\
$(builddir)/node_modules/select2/dist/css/select2.css \
$(srcdir)/css/w2ui-1.5.rc1.css \
$(srcdir)/css/leaflet.css \
+ $(srcdir)/css/leaflet-spinner.css \
$(srcdir)/css/selectionMarkers.css \
$(srcdir)/css/loleaflet.css \
$(srcdir)/css/toolbar.css \
diff --git a/loleaflet/css/leaflet-spinner.css
b/loleaflet/css/leaflet-spinner.css
new file mode 100644
index 0..39899a71e
--- /dev/null
+++ b/loleaflet/css/leaflet-spinner.css
@@ -0,0 +1,3 @@
+.leaflet-slideshow {
+ background:
url(data:image/gif;base64,R0lGODlhMgAyAPZBAICAgIWFhYGBgf7+/pSUlPHx8YODg4aGhp+fn6qqqoiIiM7OzoKCgpiYmPv7++Dg4JGRke/v76amppycnLa2tqioqN/f352dnezs7MLCwtfX14eHh8nJyb6+vsDAwJaWlqGhodTU1KOjo/r6+ouLi+7u7rCwsLKysvb29pCQkPj4+I6Ojvn5+ZWVlZmZmbq6uvz8/Kurq66urvPz88XFxeXl5czMzLy8vOPj493d3dnZ2dvb28rKyomJidHR0cfHx7S0tP39/dLS0tzc3MvLy4qKipqamtDQ0K2trbOzs9jY2OTk5KSkpI+Pj8bGxr29vdXV1dra2q+vr7u7u9bW1vX19fDw8PLy8vT09Pf397W1tYyMjKKiop6enqenp7+/v8jIyO3t7cPDw6Wlpc3NzaCgoJubm5eXl42NjbGxscTExKysrN7e3tPT08/Pz7e3t6mpqeLi4sHBwebm5pOTk+Hh4efn5+rq6uvr6+np6bm5uYSEhLi4uOjo6JKSkgAAACH/C05FVFNDQVBFMi4wAwEh+QQJAwBBACH+GU9wdGltaXplZCB1c2luZyBlemdpZi5jb20ALAAyADIAAAf/gEGCg4SFgjAFPi8iJACOjhcyNAWGlZaXgxaKAo+dngAXNiOYpJUSQAGfqp8eKqWlLzQbq7SsKK+VAyErtb2fD7iEAzK+xZ40wUEOIMbNjyIsryouztWgMKTDxjc+OCojETU2zL4JpDe+C7eXKD89va2WO/ADuA7utSG5CrQX68kFqPUzRGwVhXrJBsE4MVAYJ1UUEppqKMiEQYQShSEwqPDhJ1cZDaHgp8pHxVU6QsrjGKTBKpWXBH6cgRLmypL4PtrcB7GgJwk7LfnsFGNCyaCVNDirgVTk0qaFBjiDaohkMaqFDDSjhFXZ064WDB4FK/aTiK4tIdpYNYrqyJ
IYQWpSzVBTJqQf0ajyUnXyLkaoAcc+YBCDKdpD6Dz9+3e44zNCHhonJcAgguRSughe3sy5s+fPoEOLHk26tOnTQQIBACH5BAkDAAQALAAyACcAAAf/gASCg4SFg0EFQlMiJACOCi0VNz4ohpaXmIMWPoyPnp8AXTYjmaWWEloBoKugHpWmmAMEU04brLetr7CEAzIhK7jBoLu8IMLHnxbEBCguyM+PYru90NWhpKU3z09CSygjiTbGwkGZQ8cLupYoP0W4MZcFkLg/P7KwI+23roYy7+rTnLEKYQiDgH33lgkKkmRfIX+stCg8FZHXwVVlEk48hKCiIA8DAW5cOO+ThEFnMI7ExGMgM5crLbVcJe3XqnIxKd58oTKnzIEVaPpcd4Bmi1VLhuo0aQtUAaUFoUGN+mxqoQHQnlpF+SzpVkEGMAr9Kk8sKBFfXxq9+ZUMRoNjPK3GECrQk72tzYTWekRF41QxrCpZYBDDa1oCwFYdOnyoUatBHhgf0pZMcrygjiQScmJ5Mx0GWjvHyzEoEAAh+QQJAwAEACwAMgAnAAAH/4AEgoOEhYIWbkEFbS9MWwABTWcJHW51WYaZmpsEElqRXAKQo6SjBZyomi80G6Wur102DqmoA22Sr7m5X5i0hgNIusK7vb6CDqHDyq4WxgRZZsvSpTS+wNPYo0zFmzfSZk9tS1kOVjU2ycJms5tDw2B0iZxZ8OrtCrpdWM++Re8Dv4IRc/asni4qhkyIgkWQUIFougpZWegKAcCGg4IkyUfoiy5uGAUJrEjoTC4dIQPueoYlYspf+EjWWfkykw1iudjVLGTyVYYODHcaUpKzgk+hMF/VoKMUaUKf/pg5lQj11VSq0646xHZKq6CYpRA09UrAQFVqZAucDKrVAqwwOTy93iQJEa3WGD5ZMQMpFJpPt2sgUbkoN+6+GmQH4drbKXHGqK4cZ6JnltSLjpIfk9qXWRNgLZ3n5bAyKBAAIfkECQM
ABQAsADIAKAAAB/+ABYKDhIWDD0dcV203TFsGEBMxX21LVkGGmZqbY1oBAKChoqFSNFabqJoDBTc0G6OwsV02I6m2A2shK7G8vB61tpkjXL3FvU/BhcPGzLFYyYK4zdOjD9A31NmkwTvNCwBGT5Uj5DU2zEzAqq/FP6vPmsTGRpiZa8Vd8Nw/RfjCAsdWQSswgl87gYNMHBuozMhCQlYAykLIMNqJh4I89FJXkdA9WdEKNJClo6MwBL4Izkhp8h/IOAZh1WtpiB0sVh9HeaGpiYevJ7Fs8OQU1IuzoT19HUXasGgspvaCQroJtZASWf1kVoWoVOvWaF2rfR1kU9Q5WFzGCppajRdHqFdAsAZV+4AkLHd07YKaQIXi1hgkReZSe4hB0BoECXt0+8yDYrAgZz4WOTfh5IJsQembDLHCNs49CTA4BVpVDkKBAAAh+QQJAwALACwAMgApAAAH/4ALgoOEhYMWPiICAC9MJABoCGlgFiUwhpiZmi80EloBkKGioRdSNFeaqZkDIWijr7ChZKq0CwNIsbmwI7WaDly6waMdKr2FKmbCyqLExo3L0KIWtUPQydGyqlcKymRVCx1CSyojlspMqrjBYAOpZMDBLL6LuRfftVlgPfWXmCb1WtoZs6UvVgJMVui9QiBw4KFczQZ1yFXMoaFrsKAQahBLh0WESSAKwpLrYyZ1sJIQ7GgSpEFbKEf1a3mM28IFQzCKkkAzE4+ONB69mtXTX0opGYv6NLhLKcID0JyejCq1kJKU+16hqvoQq1augwYwHQp2kE1hIsqahcar7LaFOkCzuT0qjZU8sGSAMoixZKRacCzv/R3JIGUBcIMldpyZeEEKlogTFxD6qvGxFwaGWa4pbTMmUp6fMrASGuGQQoEAACH5BAkDAAkALAAyACkAAAf/gAmCg4SFgmMJOUciAgBTjBsXSUR1LIaXmJmHP5EBAJ+goZ+SUFmap4YDUCuira6fqKgO
[Libreoffice-bugs] [Bug 113358] [META] Linux packaging/installation/removal bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113358 Bug 113358 depends on bug 124219, which changed state. Bug 124219 Summary: soffice won't launch because of missing symbol cairo_surface_get_device_scale https://bugs.documentfoundation.org/show_bug.cgi?id=124219 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124546] New: Número negativos em vermelho nos gráficos
https://bugs.documentfoundation.org/show_bug.cgi?id=124546 Bug ID: 124546 Summary: Número negativos em vermelho nos gráficos Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: junio.vie...@outlook.com.br A formatação de números para vermelho se negativo nos gráficos não funciona. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/headless vcl/inc vcl/unx
vcl/headless/svpgdi.cxx | 40
vcl/headless/svpvd.cxx |8 ++--
vcl/inc/headless/svpgdi.hxx |3 +++
vcl/unx/gtk3/gtk3gtkinst.cxx |2 +-
4 files changed, 34 insertions(+), 19 deletions(-)
New commits:
commit 0edf02fc88a444157713874686b1c7409a13f04c
Author: Caolán McNamara
AuthorDate: Thu Apr 4 09:38:47 2019 +0100
Commit: Michael Stahl
CommitDate: Thu Apr 4 13:42:19 2019 +0200
Resolves: tdf#124219 check at runtime for availability of cairo functions
Change-Id: I0ab3055760d8be690bdfff560212db368a0fa261
Reviewed-on: https://gerrit.libreoffice.org/70246
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 502aa43c792f..3a785d642301 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -43,6 +43,7 @@
#include
#include
#include
+#include
#if ENABLE_CAIRO_CANVAS
# if defined CAIRO_VERSION && CAIRO_VERSION < CAIRO_VERSION_ENCODE(1, 10, 0)
@@ -613,9 +614,7 @@ void SvpSalGraphics::setSurface(cairo_surface_t* pSurface,
const basegfx::B2IVec
{
m_pSurface = pSurface;
m_aFrameSize = rSize;
-#if CAIRO_VERSION >= CAIRO_VERSION_ENCODE(1, 14, 0)
-cairo_surface_get_device_scale(pSurface, _fScale, nullptr);
-#endif
+dl_cairo_surface_get_device_scale(pSurface, _fScale, nullptr);
ResetClipRegion();
}
@@ -1598,9 +1597,7 @@ void SvpSalGraphics::copyBits( const SalTwoRect& rTR,
cairo_surface_get_content(m_pSurface),
aTR.mnSrcWidth * m_fScale,
aTR.mnSrcHeight * m_fScale);
-#if CAIRO_VERSION >= CAIRO_VERSION_ENCODE(1, 14, 0)
-cairo_surface_set_device_scale(pCopy, m_fScale, m_fScale);
-#endif
+dl_cairo_surface_set_device_scale(pCopy, m_fScale, m_fScale);
cairo_t* cr = cairo_create(pCopy);
cairo_set_source_surface(cr, source, -aTR.mnSrcX, -aTR.mnSrcY);
cairo_rectangle(cr, 0, 0, aTR.mnSrcWidth, aTR.mnSrcHeight);
@@ -1893,9 +1890,7 @@ void SvpSalGraphics::invert(const basegfx::B2DPolygon
, SalInvert nFlags)
extents.getWidth() * m_fScale,
extents.getHeight() * m_fScale);
-#if CAIRO_VERSION >= CAIRO_VERSION_ENCODE(1, 14, 0)
-cairo_surface_set_device_scale(surface, m_fScale, m_fScale);
-#endif
+dl_cairo_surface_set_device_scale(surface, m_fScale, m_fScale);
cairo_t* stipple_cr = cairo_create(surface);
cairo_set_source_rgb(stipple_cr, 1.0, 1.0, 1.0);
cairo_mask(stipple_cr, pattern);
@@ -2049,9 +2044,7 @@ cairo_t*
SvpSalGraphics::createTmpCompatibleCairoContext() const
m_aFrameSize.getX() * m_fScale,
m_aFrameSize.getY() * m_fScale);
-#if CAIRO_VERSION >= CAIRO_VERSION_ENCODE(1, 14, 0)
-cairo_surface_set_device_scale(target, m_fScale, m_fScale);
-#endif
+dl_cairo_surface_set_device_scale(target, m_fScale, m_fScale);
return cairo_create(target);
}
@@ -2247,4 +2240,27 @@ GlyphCache& SvpSalGraphics::getPlatformGlyphCache()
return *pSalData->GetGlyphCache();
}
+void dl_cairo_surface_set_device_scale(cairo_surface_t *surface, double
x_scale, double y_scale)
+{
+static auto func = reinterpret_cast(
+dlsym(nullptr, "cairo_surface_set_device_scale"));
+if (func)
+func(surface, x_scale, y_scale);
+}
+
+void dl_cairo_surface_get_device_scale(cairo_surface_t *surface, double*
x_scale, double* y_scale)
+{
+static auto func = reinterpret_cast(
+dlsym(nullptr, "cairo_surface_get_device_scale"));
+if (func)
+func(surface, x_scale, y_scale);
+else
+{
+if (x_scale)
+*x_scale = 1.0;
+if (y_scale)
+*y_scale = 1.0;
+}
+}
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/headless/svpvd.cxx b/vcl/headless/svpvd.cxx
index 875f22a5d7fc..eeccf2c014a9 100644
--- a/vcl/headless/svpvd.cxx
+++ b/vcl/headless/svpvd.cxx
@@ -89,7 +89,6 @@ bool SvpSalVirtualDevice::SetSizeUsingBuffer( long nNewDX,
long nNewDY,
}
else if (pBuffer)
{
-#if CAIRO_VERSION >= CAIRO_VERSION_ENCODE(1, 14, 0)
double fXScale, fYScale;
if (comphelper::LibreOfficeKit::isActive())
{
@@ -98,18 +97,15 @@ bool SvpSalVirtualDevice::SetSizeUsingBuffer( long nNewDX,
long nNewDY,
}
else
{
-cairo_surface_get_device_scale(m_pRefSurface, ,
);
+dl_cairo_surface_get_device_scale(m_pRefSurface, ,
);
nNewDX *= fXScale;
nNewDY *= fYScale;
}
-#endif
m_pSurface = cairo_image_surface_create_for_data(pBuffer,
CAIRO_FORMAT_ARGB32,
[Libreoffice-commits] core.git: officecfg/registry
officecfg/registry/schema/org/openoffice/Office/Common.xcs |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 244e60ec32d593fe92f2c93b9934762067243947 Author: Andras Timar AuthorDate: Thu Apr 4 13:41:21 2019 +0200 Commit: Andras Timar CommitDate: Thu Apr 4 13:41:21 2019 +0200 typo: openning -> opening Change-Id: I7da07503badec82ffb227424819a0f19eabfbbe5 diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs b/officecfg/registry/schema/org/openoffice/Office/Common.xcs index 191d92eebaa2..59adc563ef6f 100644 --- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs @@ -3830,7 +3830,7 @@ Specifies if LO should create MSO lock files next to the LO lock files - when openning a file. This makes MSO to be able to read the user name from + when opening a file. This makes MSO to be able to read the user name from the lock file and show it for the user. false ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 124545] New: Botão ok selecionado por padrão
https://bugs.documentfoundation.org/show_bug.cgi?id=124545 Bug ID: 124545 Summary: Botão ok selecionado por padrão Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: junio.vie...@outlook.com.br Quando vou alterar a altura da linha ou largura da coluna na janela que se abre o botão "ok" não vem selecionado por padrão, o padrão é altura ideal, quando digito a nova altura e aperto enter apenas desmarca a caixa de seleção altura ideal, porém deveria confirmar a ação. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
