[Libreoffice-commits] core.git: sc/source

2019-05-15 Thread Andrea Gelmini (via logerrit)
 sc/source/ui/vba/excelvbahelper.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1e9c9c572f5be84be4833ba5afc54eaa95947e57
Author: Andrea Gelmini 
AuthorDate: Wed May 15 09:04:44 2019 +
Commit: Julien Nabet 
CommitDate: Thu May 16 07:58:15 2019 +0200

Fix typo

Change-Id: I38249b6ceeea7d59a23a6a4b841877724a343b78
Reviewed-on: https://gerrit.libreoffice.org/72390
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/sc/source/ui/vba/excelvbahelper.hxx 
b/sc/source/ui/vba/excelvbahelper.hxx
index 3b6a2f094369..04007ed16d77 100644
--- a/sc/source/ui/vba/excelvbahelper.hxx
+++ b/sc/source/ui/vba/excelvbahelper.hxx
@@ -80,7 +80,7 @@ public:
 static SfxItemSet* GetDataSet( ScCellRangesBase* pRangeObj );
 };
 
-// Extracts a implementation object ( via XUnoTunnel ) from a uno object.
+// Extracts an implementation object (via XUnoTunnel) from a UNO object.
 // Will throw if unsuccessful.
 /// @throws css::uno::RuntimeException
 template < typename ImplObject >
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: offapi/com

2019-05-15 Thread Andrea Gelmini (via logerrit)
 offapi/com/sun/star/security/ExtAltNameType.idl |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fe2af9db48ae493b6782b4b4d82da80f14638a10
Author: Andrea Gelmini 
AuthorDate: Wed May 15 09:05:49 2019 +
Commit: Julien Nabet 
CommitDate: Thu May 16 07:57:40 2019 +0200

Fix typo

Change-Id: I9fdd5e25dff09593dec3947de4c5a916a15f48a1
Reviewed-on: https://gerrit.libreoffice.org/72389
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/offapi/com/sun/star/security/ExtAltNameType.idl 
b/offapi/com/sun/star/security/ExtAltNameType.idl
index 1b4fd7b30366..661ac7606289 100644
--- a/offapi/com/sun/star/security/ExtAltNameType.idl
+++ b/offapi/com/sun/star/security/ExtAltNameType.idl
@@ -39,7 +39,7 @@ enum ExtAltNameType
 
 /**
  * The entry contains rfc822 name.
- * The value of CertAltNameEntry contains a OUString.
+ * The value of CertAltNameEntry contains an OUString.
  *
  * @see com::sun::star::security::CertAltNameEntry
  */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/Module_sc.mk sc/qa sc/UITest_calc_tests8.mk

2019-05-15 Thread Zdeněk Crhonek (via logerrit)
 sc/Module_sc.mk|1 
 sc/UITest_calc_tests8.mk   |   20 ++
 sc/qa/uitest/calc_tests/data/tdf124829.ods |binary
 sc/qa/uitest/calc_tests8/tdf124829.py  |   41 +
 4 files changed, 62 insertions(+)

New commits:
commit 92e2776fc24ea5a13239f7f753e7d50e0c901295
Author: Zdeněk Crhonek 
AuthorDate: Wed May 15 20:09:39 2019 +0200
Commit: Zdenek Crhonek 
CommitDate: Thu May 16 07:30:10 2019 +0200

uitest for bug tdf#124829

Change-Id: I5eea7de34a37270e1bdf16ede271d73f9ea05730
Reviewed-on: https://gerrit.libreoffice.org/72376
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek 

diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk
index 0b424cd0a381..7d4928f41599 100644
--- a/sc/Module_sc.mk
+++ b/sc/Module_sc.mk
@@ -252,6 +252,7 @@ $(eval $(call gb_Module_add_uicheck_targets,sc,\
UITest_sort \
UITest_chart \
UITest_pageFormat \
+   UITest_calc_tests8 \
 ))
 endif
 
diff --git a/sc/UITest_calc_tests8.mk b/sc/UITest_calc_tests8.mk
new file mode 100644
index ..b1c8dcbfcbdb
--- /dev/null
+++ b/sc/UITest_calc_tests8.mk
@@ -0,0 +1,20 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_UITest_UITest,calc_tests8))
+
+$(eval $(call gb_UITest_add_modules,calc_tests8,$(SRCDIR)/sc/qa/uitest,\
+   calc_tests8/ \
+))
+
+$(eval $(call gb_UITest_set_defs,calc_tests8, \
+TDOC="$(SRCDIR)/sc/qa/uitest/calc_tests/data" \
+))
+
+# vim: set noet sw=4 ts=4:
diff --git a/sc/qa/uitest/calc_tests/data/tdf124829.ods 
b/sc/qa/uitest/calc_tests/data/tdf124829.ods
new file mode 100644
index ..280d349cf73a
Binary files /dev/null and b/sc/qa/uitest/calc_tests/data/tdf124829.ods differ
diff --git a/sc/qa/uitest/calc_tests8/tdf124829.py 
b/sc/qa/uitest/calc_tests8/tdf124829.py
new file mode 100644
index ..b2aa6d3647e5
--- /dev/null
+++ b/sc/qa/uitest/calc_tests8/tdf124829.py
@@ -0,0 +1,41 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+from uitest.framework import UITestCase
+from uitest.uihelper.common import get_state_as_dict
+from uitest.uihelper.common import select_pos
+from uitest.uihelper.calc import enter_text_to_cell
+from libreoffice.calc.document import get_sheet_from_doc
+from libreoffice.calc.conditional_format import 
get_conditional_format_from_sheet
+from uitest.debug import sleep
+from libreoffice.calc.document import get_cell_by_position
+from libreoffice.uno.propertyvalue import mkPropertyValues
+import org.libreoffice.unotest
+import pathlib
+
+def get_url_for_data_file(file_name):
+return 
pathlib.Path(org.libreoffice.unotest.makeCopyFromTDOC(file_name)).as_uri()
+
+#Bug 124829 - CRASH: cutting and undoing a sheet with external links
+
+class tdf124829(UITestCase):
+def test_tdf124829_Crash_cutting_undo_sheet_external_links(self):
+#numberingformatpage.ui
+calc_doc = 
self.ui_test.load_file(get_url_for_data_file("tdf124829.ods"))
+xCalcDoc = self.xUITest.getTopFocusWindow()
+gridwin = xCalcDoc.getChild("grid_window")
+document = self.ui_test.get_component()
+
+self.xUITest.executeCommand(".uno:SelectAll")
+self.xUITest.executeCommand(".uno:Cut")
+for i in range(40):
+self.xUITest.executeCommand(".uno:Undo")
+
+#verify; no crashes
+self.assertEqual(get_cell_by_position(document, 5, 0, 0).getString(), 
"First Name")
+
+self.ui_test.close_doc()
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: extensions/source

2019-05-15 Thread Andrea Gelmini (via logerrit)
 extensions/source/ole/unoconversionutilities.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5917735000d1cddf4ae2fe982bc8701b5b0f1db7
Author: Andrea Gelmini 
AuthorDate: Wed May 15 10:59:18 2019 +
Commit: Julien Nabet 
CommitDate: Thu May 16 07:07:42 2019 +0200

Fix typo

Change-Id: I3e6446680571202a6825293e8b6c671022be6e0b
Reviewed-on: https://gerrit.libreoffice.org/72386
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/extensions/source/ole/unoconversionutilities.hxx 
b/extensions/source/ole/unoconversionutilities.hxx
index f211d4dbf3fa..e8e9ba0f10d9 100644
--- a/extensions/source/ole/unoconversionutilities.hxx
+++ b/extensions/source/ole/unoconversionutilities.hxx
@@ -943,7 +943,7 @@ void UnoConversionUtilities::anyToVariant(VARIANT* 
pVariant, const Any& rAny)
 default:
 //TypeClass_SERVICE:
 //TypeClass_EXCEPTION:
-//When a InvocationTargetException is thrown when calling 
XInvocation::invoke
+//When an InvocationTargetException is thrown when calling 
XInvocation::invoke
 //on a UNO object, then the target exception is directly used to 
create a
 //EXEPINFO structure
 //TypeClass_TYPEDEF
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/vcl

2019-05-15 Thread Andrea Gelmini (via logerrit)
 include/vcl/IconThemeInfo.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3ba921e3ea2afc5a078ebced86375bbc2fc190f3
Author: Andrea Gelmini 
AuthorDate: Wed May 15 09:09:16 2019 +
Commit: Julien Nabet 
CommitDate: Thu May 16 07:08:09 2019 +0200

Fix typo

Change-Id: I2615f979b9abbf87972dd67503ceda90724ce9bb
Reviewed-on: https://gerrit.libreoffice.org/72387
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/include/vcl/IconThemeInfo.hxx b/include/vcl/IconThemeInfo.hxx
index 54e71e73d07f..825a0e14cafa 100644
--- a/include/vcl/IconThemeInfo.hxx
+++ b/include/vcl/IconThemeInfo.hxx
@@ -51,7 +51,7 @@ public:
  */
 static Size SizeByThemeName(const OUString&);
 
-/** Check whether a IconThemeInfo can be constructed from a URL */
+/** Check whether an IconThemeInfo can be constructed from a URL */
 static bool UrlCanBeParsed(const OUString& url);
 
 /** Find an icon theme by its id in a vector.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 124925] Wrong error message: no corrupted files, but no more disk space

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124925

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125062] Export as PNG with transparency changes shape of objects radically

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125062

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122397] Editing: Writer jumps back to selected text when copying to another location using X-clipboard

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122397

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|QA:needsComment |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125138] in Impress the character dialog does not remember its size

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125138

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125065] Enhancement: I want an entry field added to be able to change the default amount of indent for the Increase Indent button in LibreOffice Writer, Calc, and any other Lib

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125065

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121879] Scale and units defined for a document not for an app

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121879

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|QA:needsComment |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119801] AutoCorrect options takes 5 minutes to open

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119801

--- Comment #10 from QA Administrators  ---
Dear zak,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122760] LibreOffice (on Gentoo Linux) freezes in some cases

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122760

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|QA:needsComment |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121451] editing page style takes a very long time and seems like a crash

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121451

--- Comment #4 from QA Administrators  ---
Dear Mark Hedges,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46014] LibreOffice cannot connect to the internet via a proxy that requires authentification

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=46014

--- Comment #11 from QA Administrators  ---
Dear honfui,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105573] PDF Export with EMF images moves and distorts images

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105573

--- Comment #21 from QA Administrators  ---
Dear Rex,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115081] Data validity restriction can be violated by copying value into a cell

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115081

--- Comment #6 from QA Administrators  ---
Dear grofaty,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117597] No scrolling with mousewheel while dragging slides around

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117597

--- Comment #6 from QA Administrators  ---
Dear Aron Budea,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95173] Progress Bar Dialog not working correctly

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=95173

--- Comment #6 from QA Administrators  ---
Dear kiloran.public+bugzilla,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117468] FILESAVE Writer crashes trying to save image as BMP, PNG, TIFF, JPEG

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117468

--- Comment #6 from QA Administrators  ---
Dear Emil Tanev,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 40929] Restart numbering is not saved for the first list in a sub-document (when viewed from master)

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=40929

--- Comment #16 from QA Administrators  ---
Dear Pavel,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108243] semicolon separated fonts substitution not working

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108243

--- Comment #9 from Kevin Suo  ---
(In reply to QA Administrators from comment #8)
Still reproducible

Version: 6.3.0.0.alpha1+
Build ID:d2fa9c0d657877c967e41fdd0091f81d1b7ca048
CPU 线程:4; 操作系统:Linux 4.18; UI 渲染:默认; VCL: gtk3; 
Locale: zh-CN (zh_CN.UTF-8); UI-Language: zh-CN
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sal/osl

2019-05-15 Thread Tor Lillqvist (via logerrit)
 sal/osl/unx/security.cxx |   30 ++
 1 file changed, 30 insertions(+)

New commits:
commit 93cdc8bbceafc37a796e68611a22ddc2395635ed
Author: Tor Lillqvist 
AuthorDate: Thu May 16 05:01:46 2019 +0300
Commit: Tor Lillqvist 
CommitDate: Thu May 16 05:21:31 2019 +0300

Use hand-crafted passwd entry for iOS Simulator as getpwuid_r() does not 
work

getpwuid_r() returns nullptr. Oddly enough, it does work on actual
iOS, though. So use hand-crafted values that match behaviour on actual
iOS.

Change-Id: Idcc95d330a93495938520229e039f340876c3653

diff --git a/sal/osl/unx/security.cxx b/sal/osl/unx/security.cxx
index 9370fe608cf9..8fc3e3f855a1 100644
--- a/sal/osl/unx/security.cxx
+++ b/sal/osl/unx/security.cxx
@@ -120,6 +120,35 @@ oslSecurity SAL_CALL osl_getCurrentSecurity()
 if (p == nullptr) {
 return nullptr;
 }
+#if defined(IOS) && defined(X86_64)
+// getpwuid_r() does not work in the iOS simulator
+(void) found;
+char * buffer = p->m_buffer;
+assert(n >= 100);
+strcpy(buffer, "mobile");
+p->m_pPasswd.pw_name = buffer;
+buffer += strlen(buffer) + 1;
+strcpy(buffer, "*");
+p->m_pPasswd.pw_passwd = buffer;
+buffer += strlen(buffer) + 1;
+p->m_pPasswd.pw_uid = geteuid();
+p->m_pPasswd.pw_gid = getegid();
+p->m_pPasswd.pw_change = 0;
+strcpy(buffer, "");
+p->m_pPasswd.pw_class = buffer;
+buffer += strlen(buffer) + 1;
+strcpy(buffer, "Mobile User");
+p->m_pPasswd.pw_gecos = buffer;
+buffer += strlen(buffer) + 1;
+strcpy(buffer, "/var/mobile"); // ???
+p->m_pPasswd.pw_dir = buffer;
+buffer += strlen(buffer) + 1;
+strcpy(buffer, "");
+p->m_pPasswd.pw_shell = buffer;
+buffer += strlen(buffer) + 1;
+p->m_pPasswd.pw_expire = 0;
+return p;
+#else
 switch (getpwuid_r(getuid(), >m_pPasswd, p->m_buffer, n, )) {
 case ERANGE:
 break;
@@ -132,6 +161,7 @@ oslSecurity SAL_CALL osl_getCurrentSecurity()
 deleteSecurityImpl(p);
 return nullptr;
 }
+#endif
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sal/osl

2019-05-15 Thread Tor Lillqvist (via logerrit)
 sal/osl/unx/security.cxx |   30 ++
 1 file changed, 30 insertions(+)

New commits:
commit f665456cd0da35649bef179755be66c2aab290a7
Author: Tor Lillqvist 
AuthorDate: Thu May 16 05:01:46 2019 +0300
Commit: Tor Lillqvist 
CommitDate: Thu May 16 05:08:19 2019 +0300

Use hand-crafted passwd entry for iOS Simulator as getpwuid_r() does not 
work

getpwuid_r() returns nullptr. Oddly enough, it does work on actual
iOS, though. So use hand-crafted values that match behaviour on actual
iOS.

Change-Id: Idcc95d330a93495938520229e039f340876c3653

diff --git a/sal/osl/unx/security.cxx b/sal/osl/unx/security.cxx
index 982b7c940c2f..413c67e943d3 100644
--- a/sal/osl/unx/security.cxx
+++ b/sal/osl/unx/security.cxx
@@ -126,6 +126,35 @@ oslSecurity SAL_CALL osl_getCurrentSecurity()
 if (p == nullptr) {
 return nullptr;
 }
+#if defined(IOS) && defined(X86_64)
+// getpwuid_r() does not work in the iOS simulator
+(void) found;
+char * buffer = p->m_buffer;
+assert(n >= 100);
+strcpy(buffer, "mobile");
+p->m_pPasswd.pw_name = buffer;
+buffer += strlen(buffer) + 1;
+strcpy(buffer, "*");
+p->m_pPasswd.pw_passwd = buffer;
+buffer += strlen(buffer) + 1;
+p->m_pPasswd.pw_uid = geteuid();
+p->m_pPasswd.pw_gid = getegid();
+p->m_pPasswd.pw_change = 0;
+strcpy(buffer, "");
+p->m_pPasswd.pw_class = buffer;
+buffer += strlen(buffer) + 1;
+strcpy(buffer, "Mobile User");
+p->m_pPasswd.pw_gecos = buffer;
+buffer += strlen(buffer) + 1;
+strcpy(buffer, "/var/mobile"); // ???
+p->m_pPasswd.pw_dir = buffer;
+buffer += strlen(buffer) + 1;
+strcpy(buffer, "");
+p->m_pPasswd.pw_shell = buffer;
+buffer += strlen(buffer) + 1;
+p->m_pPasswd.pw_expire = 0;
+return p;
+#else
 switch (getpwuid_r(getuid(), >m_pPasswd, p->m_buffer, n, )) {
 case ERANGE:
 break;
@@ -138,6 +167,7 @@ oslSecurity SAL_CALL osl_getCurrentSecurity()
 deleteSecurityImpl(p);
 return nullptr;
 }
+#endif
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125317] LO Viewer for Android is not recognized as able to open .odt files

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125317

--- Comment #1 from Jim Avera  ---
Hrm.  There is another app, "Open Document Reader" by Thomas Taschauer, that
seems to do everything LO Viewer aims for and at first glance works perfectly.

Website is  https://opendocument.app

It's ad-supported, but not obnoxious.  It's docs say it is "Open Source", so
maybe LO Viewer could pick up something useful from this program.   

Or maybe it's better to not spend energy re-inventing things and withdraw LO
Reader so people don't waste their time with it (as I've done with much
frustration).

-Jim

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125318] New: Copy & Paste does not work

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125318

Bug ID: 125318
   Summary: Copy & Paste does not work
   Product: LibreOffice
   Version: 6.0.0.0.alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jim.av...@gmail.com

Description:
In other Android apps, a long-press activates a copy/paste feature.  It seems
to be a standard mechanism, because the same options (copy, paste, etc.) appear
in many different apps.

But this does not happen in Libre Office Viewer for Android.  Long-press on
text in an open text document does nothing.

If the experimental (editing) option is enabled, then long-press seems to
activate a text selector (two cursors), but the enclosed text is not put into
the clipboard and doing 'paste' in another app does not get anything from LO
Viewer.

The lack of copy-and-paste support is pretty crippling for users who need to,
for example, copy URLs from a text document and paste them into Firefox or
another browser.

Steps to Reproduce:
1. Install LO Viewer for Android using the Play Store
2. Open a .odt document
3. pinch-zoom to make the text large enough to see easily
4. long-press on a word

Actual Results:
Nothing happens.

Expected Results:
The standard Android copy/paste dialog should appear, or something equivalent
which allows copying text so it can be pasted in another app.


Reproducible: Always


User Profile Reset: No



Additional Info:
Samsung Galaxy s7 running Android 8.0.0

By the way, the "current" version in the Google Play Store is 6.0.0.0.alpha+
which is a little suspicious.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: ios/README

2019-05-15 Thread Libreoffice Gerrit user
 ios/README |   71 ++---
 1 file changed, 49 insertions(+), 22 deletions(-)

New commits:
commit 420bedaadca9658559d415ab1689f92bc7fba4d6
Author: Tor Lillqvist 
AuthorDate: Thu May 16 02:14:23 2019 +0300
Commit: Tor Lillqvist 
CommitDate: Thu May 16 02:17:54 2019 +0300

Edit ios/README

Point out that in my way, you will (sadly) need GNU libtool for the
running of the autogen.sh script, even if not actually at all
otherwise.

(We should really try to get rid of the need for libtool. A minor
amount of hacking to loleaflet/Makefile.am should be enough.)

diff --git a/ios/README b/ios/README
index 4ca3b3a48..be2f1062f 100644
--- a/ios/README
+++ b/ios/README
@@ -18,24 +18,51 @@ there in instdir and workdir, but no app that can be run as 
such. (You
 can see a list of them in
 workdir/CustomTarget/ios/ios-all-static-libs.list)
 
-2) Do a separate clone of the online repo on macOS, but don't run any
-make or open the Mobile project there yet.
+2) Do a separate clone of the online repo on macOS, but don't do any
+autogen.sh, configure, or make, or open the Mobile Xcode project there
+yet. We call this the app folder.
 
-3) Either: do a separate clone of the online repo on Linux, run autogen.sh,
-and configure it with the --enable-iosapp option:
+3) Here the instructions split. tml uses the first way, mmeeks tried
+to use the second way. The paths will join again at step 4.
+
+EITHER:
+
+3a) On a Linux machine: Do a separate clone of the online repo, run
+autogen.sh, and configure it with the --enable-iosapp option:
 
 ./configure --enable-iosapp --with-iosapp-name="My Own Mobile LibreOffice"
 
 Then run make. That will produce files in loleaflet/dist, nothing
-else. Copy those to the corresponding folder in the online clone
-from step 2. This is what I do:
+else. Copy those to the corresponding folder in the app folder from
+step 2. This is how I do it:
+
+make clean && make && tar cf - loleaflet/dist | ssh misan.local 'cd 
lo/online-ios-device && rm -rf loleaflet/dist && tar xvf -'
+
+where misan.local is the macOS machine where I build the app, and
+~/lo/online-ios-device is the app folder from step 2.
+
+Then back to the Mac:
+
+As you were able to build LibreOffice in step 1, you must already have
+GNU autoconf installed on the Mac. Install also GNU automake and
+libtool. Preferrably from sources, to make sure a potential
+installation of brew or similar will not pollute your environment with
+unknown stuff.
+
+As GNU libtool will be needed only for a very minimal part of the
+build (running the autogen.sh script, but not anything else), it's
+safest to install it somewhere that is not in your $PATH. Let's say
+/opt/libtool. (Installing Automake in the default /usr/local, which is
+in $PATH, is less risky.)
 
-make clean && make && tar cf - loleaflet/dist | ssh misan.local 'cd 
lo/online-ios-device && tar xvf -'
+Run the autogen.sh script in the app folder, with GNU libtool
+available:
 
-where misan.local is the macOS machine where I build the app, in the
-~/lo/online-ios-device folder.
+PATH=/opt/libtool/bin:$PATH ./autogen.sh
 
-3) Or: install brew: https://brew.sh/
+OR:
+
+3b) Install brew: https://brew.sh/
 
Then:
 
@@ -45,31 +72,31 @@ sudo python -m ensurepip --default-pip
 sudo pip install polib lxml
 make ; make
 
-4) In the online folder form step 2, edit the
-ios/Mobile.xcodeproj/project.pbxproj file in your favourite text
-editor.
-
-Change LOSRCDIR and all instances of "../ios-device" to refer the the
-LibreOffice core source directory from step 1.
-
 Then run:
 
 ./autogen.sh
 
-and
+Now the instructions join again:
+
+4) In the app folder from step 2, edit the
+ios/Mobile.xcodeproj/project.pbxproj file in your favourite text
+editor. Change LOSRCDIR and all instances of "../ios-device" to refer
+the the LibreOffice core source directory from step 1.
+
+5) In the app folder, run:
 
 ./configure --enable-iosapp --with-iosapp-name="My Own Mobile LibreOffice" 
--with-lo-builddir=$HOME/lo/ios --with-poco-includes=/opt/ios-poco/include 
--with-poco-libs=/opt/ios-poco/lib
 
 The configure script puts the app name as the CFBundleDisplayName
-property into the ios/Mobile/Info.plist file, and set up some
+property into the ios/Mobile/Info.plist file, and sets up some
 symbolic links that point to the LibreOffice core source and build
-directories (which can be the same, of course).
+directories (which typically will be the same, of course).
 
-4) Before opening the Xcode project for the first time
+6) Before opening the Xcode project for the first time
- seriously consider disabling source code indexing, this
spawns a vast number of git processes, and consumes huge
amounts of CPU & memory:
 
Xcode -> Preferences, "Source Control", uncheck "Enable Source Control"
 
-5) Now you can open the Mobile Xcode project, build it, and run it.
+7) Now you can open the Mobile Xcode project, build 

[Libreoffice-bugs] [Bug 125317] New: LO Viewer for Android is not recognized as able to open .odt files

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125317

Bug ID: 125317
   Summary: LO Viewer for Android is not recognized as able to
open .odt files
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jim.av...@gmail.com

Description:
After installing LO Viewer for Android, attempting to open a .odt file using
the "My Files" app still gives an error saying no application exists to open
that file type.

I went to the Android config "apps" screen, and for Libre Office Viewer the
"Set as default" section was greyed out (inactive) with the notice "None set as
default".

There is no obvious way that I could find to manually configure the app to be
used to open .odt files.

Steps to Reproduce:
1.Install Libre Office Viewer for Android through the Play Store
2.Get an .odt file onto the phone, e.g. download with a browser
3.Use the "My Files" app (a Samsung thing, don't know about others) to navigate
to the relevant folder (e.g. Downloads) and tap .odt file to open it.

Actual Results:
Pop-up says there is no app configured to open that file type, and offers to
open Android Play Store to install something.

Expected Results:
Installing LO Viewer for Android should automatically configure the os to make
LO Viewer the default app for, at least, the ODF file types; or provide a user
dialog to configure same.



Reproducible: Always


User Profile Reset: No



Additional Info:
I installed LibreOffice Viewer Version 6.1.0.0.alpha0+ Build ID 484d0ea842da 
My phone is a Samsung Galaxy s7 running Android 8.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125316] New: "Attempt to get length of NULL Array" on first startup

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125316

Bug ID: 125316
   Summary: "Attempt to get length of NULL Array" on first startup
   Product: LibreOffice
   Version: 6.1.0.0.alpha1+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jim.av...@gmail.com

Description:
A pop-up appears when the app is started the first time saying something like
  "Attempt ot get length of Null Array"

I un-installed and re-installed, and the same thing happened.

The message does not appear on subsequent start-ups.

Steps to Reproduce:
1. Install Libre Office Viewer from the Google Play store
2. Press "Open" when the button appears in the Play Store (after iunstall
finishes)

Actual Results:
A black pop-up says "Attempt to get length of a Null Array" or similar.

Expected Results:
.


Reproducible: Always


User Profile Reset: No



Additional Info:
Android 8.0.0, Samsung Galaxy s7

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Removing SVX_DLLPRIVATE from GetInteractionHandles() and from DragMoveCustomShapeHdl()

2019-05-15 Thread Regina Henschel

Hi all,

for my ask for help in 
https://lists.freedesktop.org/archives/libreoffice/2019-May/082739.html 
Stephan has mentioned three ways for getting my unit test work

- using a different way --- I have no better idea.
- use gb_CppunitTest_use_library_objects --- That does not work.
- remove SVX_DLLPRIVATE --- That works.

I have changed the patch in https://gerrit.libreoffice.org/#/c/72229/4 
accordingly.


Is that OK? Or does it produce problems in other areas? I think, the 
author of that lines had a reason to restrict a public function with 
SVX_DLLPRIVATE?


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: vcl/qt5

2019-05-15 Thread Luboš Luňák (via logerrit)
 vcl/qt5/Qt5Clipboard.cxx |7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

New commits:
commit 294d4ed6aab4ae6dbf859626545cf6d75194bacd
Author: Luboš Luňák 
AuthorDate: Wed May 15 16:26:59 2019 +0200
Commit: Katarina Behrens 
CommitDate: Wed May 15 23:36:09 2019 +0200

do not add non-text to PRIMARY selection in VclQt5Clipboard

E.g. tdf#80853 repeatedly sets the selection, which results
in the entire document getting converted to html.

Other VCL backends seem to be even faster, it looks like they convert
the data only on-demand, but this at least makes things bearable.

Change-Id: Ib08423bd89d7c7065ad0522338979f1ce66701c7
Reviewed-on: https://gerrit.libreoffice.org/72369
Tested-by: Jenkins
Reviewed-by: Katarina Behrens 

diff --git a/vcl/qt5/Qt5Clipboard.cxx b/vcl/qt5/Qt5Clipboard.cxx
index 5fdbc47dfd2c..d4df05504b8e 100644
--- a/vcl/qt5/Qt5Clipboard.cxx
+++ b/vcl/qt5/Qt5Clipboard.cxx
@@ -249,8 +249,13 @@ void VclQt5Clipboard::setContents(
 {
 css::uno::Sequence aFormats
 = xTrans->getTransferDataFlavors();
+// Do not add non-text formats for the selection buffer,
+// I don't think that one is ever used for anything else
+// besides text and this gets called whenever something
+// in LO gets selected (which may be e.g. an entire Calc sheet).
 bool bHasHtml = false, bHasImage = false;
-lcl_peekFormats(aFormats, bHasHtml, bHasImage);
+if (m_aClipboardMode != QClipboard::Selection)
+lcl_peekFormats(aFormats, bHasHtml, bHasImage);
 
 std::unique_ptr pMimeData(new QMimeData);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/inc vcl/qt5

2019-05-15 Thread Jan-Marek Glogowski (via logerrit)
 vcl/inc/qt5/Qt5Menu.hxx |3 +++
 vcl/qt5/Qt5Menu.cxx |   23 ++-
 2 files changed, 17 insertions(+), 9 deletions(-)

New commits:
commit a348806baf31b4072f02886d142ac6c3e1bba665
Author: Jan-Marek Glogowski 
AuthorDate: Mon May 6 17:18:56 2019 +0200
Commit: Jan-Marek Glogowski 
CommitDate: Wed May 15 23:25:37 2019 +0200

Qt5 don't unconditionally disconnect close button

Change-Id: Ibfa4d493ed752a03554020c6ab06bfc38745d97d
Reviewed-on: https://gerrit.libreoffice.org/71871
Tested-by: Jenkins
Reviewed-by: Aleksei Nikiforov 
Reviewed-by: Jan-Marek Glogowski 

diff --git a/vcl/inc/qt5/Qt5Menu.hxx b/vcl/inc/qt5/Qt5Menu.hxx
index 76d865b263ff..cf60ee2c0bb7 100644
--- a/vcl/inc/qt5/Qt5Menu.hxx
+++ b/vcl/inc/qt5/Qt5Menu.hxx
@@ -18,6 +18,7 @@
 class MenuItemList;
 class QAction;
 class QActionGroup;
+class QPushButton;
 class QMenu;
 class QMenuBar;
 class Qt5MenuItem;
@@ -34,6 +35,8 @@ private:
 bool mbMenuBar;
 QMenuBar* mpQMenuBar;
 QMenu* mpQMenu;
+QPushButton* mpCloseButton;
+QMetaObject::Connection maCloseButtonConnection;
 
 void DoFullMenuUpdate(Menu* pMenuBar);
 static void NativeItemText(OUString& rItemText);
diff --git a/vcl/qt5/Qt5Menu.cxx b/vcl/qt5/Qt5Menu.cxx
index 5bfaefa9b931..733b1505b49c 100644
--- a/vcl/qt5/Qt5Menu.cxx
+++ b/vcl/qt5/Qt5Menu.cxx
@@ -30,6 +30,7 @@ Qt5Menu::Qt5Menu(bool bMenuBar)
 , mbMenuBar(bMenuBar)
 , mpQMenuBar(nullptr)
 , mpQMenu(nullptr)
+, mpCloseButton(nullptr)
 {
 }
 
@@ -411,7 +412,17 @@ void Qt5Menu::SetFrame(const SalFrame* pFrame)
 {
 mpQMenuBar = pMainWindow->menuBar();
 if (mpQMenuBar)
+{
 mpQMenuBar->clear();
+QPushButton* pButton
+= 
static_cast(mpQMenuBar->cornerWidget(Qt::TopRightCorner));
+if (pButton && ((mpCloseButton != pButton) || 
!maCloseButtonConnection))
+{
+maCloseButtonConnection
+= connect(pButton, ::clicked, this, 
::slotCloseDocument);
+mpCloseButton = pButton;
+}
+}
 
 mpQMenu = nullptr;
 
@@ -622,19 +633,13 @@ void Qt5Menu::ShowCloseButton(bool bShow)
 pButton->setFlat(true);
 pButton->setToolTip(toQString(VclResId(SV_HELPTEXT_CLOSEDOCUMENT)));
 mpQMenuBar->setCornerWidget(pButton, Qt::TopRightCorner);
+maCloseButtonConnection
+= connect(pButton, ::clicked, this, 
::slotCloseDocument);
+mpCloseButton = pButton;
 }
 
 if (bShow)
-{
-// The mpQMenuBar is used in multiple Qt5Menu. If one Qt5Menu is 
deleted, the clicked button
-// connection is severed. The reconnect could be handled in SetFrame, 
but ShowCloseButton is
-// called so seldomly, that I decided to keep the reconnect in this 
function in one place. As
-// we don't know the connection state, we unconditionally remove it, 
so slotCloseDocument
-// isn't called multiple times on click.
-pButton->disconnect(SIGNAL(clicked(bool)));
-connect(pButton, ::clicked, this, 
::slotCloseDocument);
 pButton->show();
-}
 else
 pButton->hide();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/qt5

2019-05-15 Thread Jan-Marek Glogowski (via logerrit)
 vcl/qt5/Qt5Widget.cxx |   54 ++
 1 file changed, 46 insertions(+), 8 deletions(-)

New commits:
commit 6dcc1e233f248696165fc976513cdf3f09dac2bd
Author: Jan-Marek Glogowski 
AuthorDate: Sat May 4 14:49:43 2019 +
Commit: Jan-Marek Glogowski 
CommitDate: Wed May 15 23:21:33 2019 +0200

Qt5 IM report selected text and anchor

Implement the text selection IM queries. Never seen them, but
since the text querying code is already there, it's easy to
extend to include the selection. Anchor is the non-cursor
position of the selection and should return the cursor in case
of not selected text.

Change-Id: I0e49a8593a5a6c6268395857748b5fc304372210
Reviewed-on: https://gerrit.libreoffice.org/71797
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/vcl/qt5/Qt5Widget.cxx b/vcl/qt5/Qt5Widget.cxx
index 8db1e05e6cf2..a073ab67158d 100644
--- a/vcl/qt5/Qt5Widget.cxx
+++ b/vcl/qt5/Qt5Widget.cxx
@@ -559,7 +559,8 @@ void Qt5Widget::inputMethodEvent(QInputMethodEvent* pEvent)
 pEvent->accept();
 }
 
-static bool lcl_retrieveSurrounding(sal_Int32& rPosition, QString* pText)
+static bool lcl_retrieveSurrounding(sal_Int32& rPosition, sal_Int32& rAnchor, 
QString* pText,
+QString* pSelection)
 {
 vcl::Window* pFocusWin = Application::GetFocusWindow();
 if (!pFocusWin)
@@ -576,17 +577,39 @@ static bool lcl_retrieveSurrounding(sal_Int32& rPosition, 
QString* pText)
 {
 SAL_WARN("vcl.qt5", "Exception in getting input method surrounding 
text: " << e);
 }
+
+bool result = false;
 if (xText.is())
 {
 rPosition = xText->getCaretPosition();
-if (rPosition != -1 && pText)
+if (rPosition != -1)
 {
-*pText = toQString(xText->getText());
+result = true;
+if (pText)
+*pText = toQString(xText->getText());
+
+sal_Int32 nSelStart = xText->getSelectionStart();
+sal_Int32 nSelEnd = xText->getSelectionEnd();
+if (nSelStart == nSelEnd)
+{
+rAnchor = rPosition;
+if (pSelection)
+result = false;
+}
+else
+{
+if (rPosition == nSelStart)
+rAnchor = nSelEnd;
+else
+rAnchor = nSelStart;
+if (pSelection)
+*pSelection = toQString(xText->getSelectedText());
+}
 return true;
 }
 }
 
-return false;
+return result;
 }
 
 QVariant Qt5Widget::inputMethodQuery(Qt::InputMethodQuery property) const
@@ -596,15 +619,15 @@ QVariant Qt5Widget::inputMethodQuery(Qt::InputMethodQuery 
property) const
 case Qt::ImSurroundingText:
 {
 QString aText;
-sal_Int32 nCursorPos;
-if (lcl_retrieveSurrounding(nCursorPos, ))
+sal_Int32 nCursorPos, nAnchor;
+if (lcl_retrieveSurrounding(nCursorPos, nAnchor, , nullptr))
 return QVariant(aText);
 [[fallthrough]];
 }
 case Qt::ImCursorPosition:
 {
-sal_Int32 nCursorPos;
-if (lcl_retrieveSurrounding(nCursorPos, nullptr))
+sal_Int32 nCursorPos, nAnchor;
+if (lcl_retrieveSurrounding(nCursorPos, nAnchor, nullptr, nullptr))
 return QVariant(nCursorPos);
 [[fallthrough]];
 }
@@ -615,6 +638,21 @@ QVariant Qt5Widget::inputMethodQuery(Qt::InputMethodQuery 
property) const
 return QVariant(
 QRect(aPosEvent.mnX, aPosEvent.mnY, aPosEvent.mnWidth, 
aPosEvent.mnHeight));
 }
+case Qt::ImAnchorPosition:
+{
+sal_Int32 nCursorPos, nAnchor;
+if (lcl_retrieveSurrounding(nCursorPos, nAnchor, nullptr, nullptr))
+return QVariant(nAnchor);
+[[fallthrough]];
+}
+case Qt::ImCurrentSelection:
+{
+QString aSelection;
+sal_Int32 nCursorPos, nAnchor;
+if (lcl_retrieveSurrounding(nCursorPos, nAnchor, nullptr, 
))
+return QVariant(aSelection);
+[[fallthrough]];
+}
 default:
 return QWidget::inputMethodQuery(property);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/qt5

2019-05-15 Thread Jan-Marek Glogowski (via logerrit)
 vcl/qt5/Qt5Widget.cxx |   53 ++
 1 file changed, 53 insertions(+)

New commits:
commit 7dc35d13e375cac1371ea491ee3bc46ef5ebf8a6
Author: Jan-Marek Glogowski 
AuthorDate: Sat May 4 01:04:35 2019 +
Commit: Jan-Marek Glogowski 
CommitDate: Wed May 15 23:21:06 2019 +0200

Qt5 IM handle surrounding text requests

This is almost a C'n'P from gtk / gtk3. That code is from 2006
(see i#68048 / commit 28c5cdcc53ae068b0c763c660d61a8291dd96726).
The original patch was described by the author (caolan) as
hilarious. No change from my side, except using QString.

Completely untested, in theory correct.

Change-Id: I8373ca7ac9eda6e377da985532fd2b7cd595bf48
Reviewed-on: https://gerrit.libreoffice.org/71786
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/vcl/qt5/Qt5Widget.cxx b/vcl/qt5/Qt5Widget.cxx
index 88ce1b18f0e7..8db1e05e6cf2 100644
--- a/vcl/qt5/Qt5Widget.cxx
+++ b/vcl/qt5/Qt5Widget.cxx
@@ -46,6 +46,12 @@
 #include 
 #include 
 #include 
+#include 
+
+#include 
+#include 
+
+using namespace com::sun::star;
 
 void Qt5Widget::paintEvent(QPaintEvent* pEvent)
 {
@@ -553,10 +559,55 @@ void Qt5Widget::inputMethodEvent(QInputMethodEvent* 
pEvent)
 pEvent->accept();
 }
 
+static bool lcl_retrieveSurrounding(sal_Int32& rPosition, QString* pText)
+{
+vcl::Window* pFocusWin = Application::GetFocusWindow();
+if (!pFocusWin)
+return false;
+
+uno::Reference xText;
+try
+{
+uno::Reference 
xAccessible(pFocusWin->GetAccessible());
+if (xAccessible.is())
+xText = 
FindFocusedEditableText(xAccessible->getAccessibleContext());
+}
+catch (const uno::Exception& e)
+{
+SAL_WARN("vcl.qt5", "Exception in getting input method surrounding 
text: " << e);
+}
+if (xText.is())
+{
+rPosition = xText->getCaretPosition();
+if (rPosition != -1 && pText)
+{
+*pText = toQString(xText->getText());
+return true;
+}
+}
+
+return false;
+}
+
 QVariant Qt5Widget::inputMethodQuery(Qt::InputMethodQuery property) const
 {
 switch (property)
 {
+case Qt::ImSurroundingText:
+{
+QString aText;
+sal_Int32 nCursorPos;
+if (lcl_retrieveSurrounding(nCursorPos, ))
+return QVariant(aText);
+[[fallthrough]];
+}
+case Qt::ImCursorPosition:
+{
+sal_Int32 nCursorPos;
+if (lcl_retrieveSurrounding(nCursorPos, nullptr))
+return QVariant(nCursorPos);
+[[fallthrough]];
+}
 case Qt::ImCursorRectangle:
 {
 SalExtTextInputPosEvent aPosEvent;
@@ -567,6 +618,8 @@ QVariant Qt5Widget::inputMethodQuery(Qt::InputMethodQuery 
property) const
 default:
 return QWidget::inputMethodQuery(property);
 }
+
+return QVariant();
 }
 
 void Qt5Widget::endExtTextInput()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97005] LOOL UX: Strike-through together with numbering/bullets does not work correctly

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=97005

--- Comment #7 from david merena  ---
strike through happens continuously when typing- turning the st off does not
help- just comes back on.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125309] EDITING XLSX Long Cell-level hyperlink is clickable in neighboring cells

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125309

--- Comment #3 from Durgapriyanka  ---
Thank you for reporting the bug. I can confirm the bug present in 

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

However, in version 3.3.0.4 I cannot confirm the bug.

There is no hyperlink popup in cell B10.

Also, Links in A9 and B9 doesn't popup as it pops up in version 6.3.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa

2019-05-15 Thread Zdeněk Crhonek (via logerrit)
 sw/qa/uitest/writer_tests/data/tdf124675.docx |binary
 sw/qa/uitest/writer_tests6/tdf124675.py   |   37 ++
 2 files changed, 37 insertions(+)

New commits:
commit bdad00277330cf49439fd86a87b8e025e946a098
Author: Zdeněk Crhonek 
AuthorDate: Wed May 15 19:37:43 2019 +0200
Commit: Zdenek Crhonek 
CommitDate: Wed May 15 22:56:18 2019 +0200

uitest for bug tdf#124675

Change-Id: I81070b04bb1aefb3a8983cade701afd1b0392f3d
Reviewed-on: https://gerrit.libreoffice.org/72374
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek 

diff --git a/sw/qa/uitest/writer_tests/data/tdf124675.docx 
b/sw/qa/uitest/writer_tests/data/tdf124675.docx
new file mode 100644
index ..13ee05c5e6e5
Binary files /dev/null and b/sw/qa/uitest/writer_tests/data/tdf124675.docx 
differ
diff --git a/sw/qa/uitest/writer_tests6/tdf124675.py 
b/sw/qa/uitest/writer_tests6/tdf124675.py
new file mode 100644
index ..2a02e36bcf12
--- /dev/null
+++ b/sw/qa/uitest/writer_tests6/tdf124675.py
@@ -0,0 +1,37 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+from uitest.framework import UITestCase
+from uitest.uihelper.common import get_state_as_dict
+from uitest.uihelper.common import select_pos
+from uitest.uihelper.calc import enter_text_to_cell
+from libreoffice.calc.document import get_cell_by_position
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.uihelper.common import get_state_as_dict, type_text
+from uitest.debug import sleep
+import org.libreoffice.unotest
+import pathlib
+
+def get_url_for_data_file(file_name):
+return 
pathlib.Path(org.libreoffice.unotest.makeCopyFromTDOC(file_name)).as_uri()
+
+#Bug 124675 - CRASH: after moving the content down and undoing
+
+class tdf124675(UITestCase):
+   def test_tdf124675_crash_moving_SwTextFrame_previous_page(self):
+writer_doc = 
self.ui_test.load_file(get_url_for_data_file("tdf124675.docx"))
+document = self.ui_test.get_component()
+xWriterDoc = self.xUITest.getTopFocusWindow()
+xWriterEdit = xWriterDoc.getChild("writer_edit")
+
+for i in range(52):
+xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE": 
"RETURN"}))
+
+self.xUITest.executeCommand(".uno:Undo")
+
+self.assertEqual(document.CurrentController.PageCount, 15)
+self.ui_test.close_doc()
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa

2019-05-15 Thread Zdeněk Crhonek (via logerrit)
 sw/qa/uitest/writer_tests/data/tdf125261.odt |binary
 sw/qa/uitest/writer_tests6/tdf125261.py  |   36 +++
 2 files changed, 36 insertions(+)

New commits:
commit 9551a1ed54fc8131b52ee58114398924196313fd
Author: Zdeněk Crhonek 
AuthorDate: Wed May 15 20:26:12 2019 +0200
Commit: Zdenek Crhonek 
CommitDate: Wed May 15 22:53:10 2019 +0200

uitest for bug tdf#125261

Change-Id: I282f4f3a07fece65bd482c7664aedd44d5852a4e
Reviewed-on: https://gerrit.libreoffice.org/72378
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek 

diff --git a/sw/qa/uitest/writer_tests/data/tdf125261.odt 
b/sw/qa/uitest/writer_tests/data/tdf125261.odt
new file mode 100644
index ..5fd8152448da
Binary files /dev/null and b/sw/qa/uitest/writer_tests/data/tdf125261.odt differ
diff --git a/sw/qa/uitest/writer_tests6/tdf125261.py 
b/sw/qa/uitest/writer_tests6/tdf125261.py
new file mode 100644
index ..c04952b4ffbf
--- /dev/null
+++ b/sw/qa/uitest/writer_tests6/tdf125261.py
@@ -0,0 +1,36 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+from uitest.framework import UITestCase
+from uitest.uihelper.common import get_state_as_dict
+from uitest.uihelper.common import select_pos
+from uitest.uihelper.calc import enter_text_to_cell
+from libreoffice.calc.document import get_cell_by_position
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.uihelper.common import get_state_as_dict, type_text
+from uitest.debug import sleep
+import org.libreoffice.unotest
+import pathlib
+
+def get_url_for_data_file(file_name):
+return 
pathlib.Path(org.libreoffice.unotest.makeCopyFromTDOC(file_name)).as_uri()
+
+#Bug 125261 - Applying autocorrect to text with URLs causes Writer to hang
+
+class tdf125261(UITestCase):
+   def test_tdf125261_crash_autocorrect_text_with_URL(self):
+writer_doc = 
self.ui_test.load_file(get_url_for_data_file("tdf125261.odt"))
+document = self.ui_test.get_component()
+xWriterDoc = self.xUITest.getTopFocusWindow()
+xWriterEdit = xWriterDoc.getChild("writer_edit")
+#apply autocorrect StartAutoCorrect
+self.xUITest.executeCommand(".uno:AutoFormatApply")
+
+self.xUITest.executeCommand(".uno:Undo")
+
+self.assertEqual(document.Text.String[0:4], "This")
+self.ui_test.close_doc()
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 122918] hotkeys in LibreOffice 6 on Win do not work correctly when uses RU keyboard layout

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122918

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
Summary|hotkeys in LibreOffice 6 on |hotkeys in LibreOffice 6 on
   |Win do not work correctly   |Win do not work correctly
   ||when uses RU keyboard
   ||layout

--- Comment #6 from Roman Kuznetsov <79045_79...@mail.ru> ---
(In reply to Julien Nabet from comment #5)
> Roman: if I well understood, according to your comment
> https://bugs.documentfoundation.org/show_bug.cgi?id=88027#c42, it doesn't
> work with RU layout but works with EN layout.

Julien, really. 

Then I can confirm this bug in

Версия: 6.2.2.2 (x64)
ID сборки: 2b840030fec2aae0fd2658d8d4f9548af4e3518d
Потоков ЦП: 4; ОС:Windows 10.0; Отрисовка ИП: GL; VCL: win; 
Локаль: ru-RU (ru_RU); Язык UI: ru-RU
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125104] [Ubuntu, Writer] Chaging page numbering to "1st, 2nd, 3rd, ..." causes crashes when trying to change Page settings later

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125104

--- Comment #22 from bok...@gmail.com ---
(In reply to Timur from comment #21)
> (In reply to boksy5 from comment #10)
> > Comment on attachment 151193 [details]
> I get dump on fileopen and it doesn't have ordinal or any page numbers: 
> STACK_COMMAND:  ~0s; .ecxr ; kb
> FOLLOWUP_IP: 
> python35!PyUnicode_RichCompare+f4
> 566e8e74 33c9xor ecx,ecx
> 
> (In reply to boksy5 from comment #0)
> > Steps to Reproduce:
> > 1. Format > Page
> > 2. Set page numbers to "1st, 2nd, 3rd..."
> > 3. Click "OK"
> Not clear. Format-Page doesn't insert page numbers. How exactly did you do
> it? First made footer? Then inserted page numbers and then edited?

I didn't insert page numbers, I set them.
I don't have to do anything (no footers or inserting) other than click on
Format > Page, and get this screen:
https://i.imgur.com/3i9TFX3.png
As you can see on this image, there are words that read like this: "Page
numbers", and right next to this is a button where a drop-down menu appears.
There you can set the numbering to "1st, 2nd, 3d...".
I'm sorry if this wasn't clear enough before, I hope this is more clear now.
Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103427] [META] Styles and Formatting sidebar deck and floating window

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103427

Dieter Praas  changed:

   What|Removed |Added

 Depends on||124152


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=124152
[Bug 124152] Paragraph styles panel not updated in realtime after modifying
"Default style"
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124152] Paragraph styles panel not updated in realtime after modifying "Default style"

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124152

Dieter Praas  changed:

   What|Removed |Added

 OS|Linux (All) |All
 Blocks||103427
 CC||dgp-m...@gmx.de

--- Comment #9 from Dieter Praas  ---
I can't confirm with

Version: 6.3.0.0.alpha1+ (x64)
Build ID: e92dcfdc7bd7b237e0bee26ff226a102d9e8e766
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-05-14_00:00:57
Locale: en-US (de_DE); UI-Language: en-US
Calc: threaded

and also not with

Version: 6.2.3.2 (x64)
Build-ID: aecc05fe267cc68dde00352a451aa867b3b546ac
CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: threaded

I could change font to Vivaldi.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103427
[Bug 103427] [META] Styles and Formatting sidebar deck and floating window
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98259

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||125230


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125230
[Bug 125230] Impress: assignment of shortcut key to View->Normal not possible
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125230] Impress: assignment of shortcut key to View->Normal not possible

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125230

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||98259

--- Comment #6 from Roman Kuznetsov <79045_79...@mail.ru> ---
don't repro in

Version: 6.2.2.2
Build ID: 1:6.2.2-0ubuntu2
CPU threads: 4; OS: Linux 5.0; UI render: default; VCL: kde5; 
Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US
Calc: threaded

I assigned F9 for both Normal from list and it works fine for all modes.

may be it's a locale shortcuts problem? or may be there is a conflict with OS
shortcuts?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=98259
[Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125306] Shortcut Ctrl+Shift+; work uncorrectly with JP keyboard

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125306

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
Could you attach the layout of your keyboard? Taking a look at
https://en.m.wikipedia.org/wiki/Language_input_keys, thought colon and sem
colon would be on 2 different keys

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125315] where are my documents

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125315

--- Comment #1 from Antonia  ---
please help me get my documents back. im crying and need it back. i worked 2
days on the for school and need it in less than 11 hours

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125315] New: where are my documents

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125315

Bug ID: 125315
   Summary: where are my documents
   Product: LibreOffice
   Version: 5.1.0.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: antoniatrus...@gmail.com

Description:
I saved all of my Important documents all over again and actually on my stick
too. i pulled the stick out and came back to check everything but its not there
anymore. i cant open it. its saying that its not existing. 

Actual Results:
i need these documents back. i worked on it for 2 days and i need it in 10
hours

Expected Results:
that i get back my documents


Reproducible: Always


User Profile Reset: Yes



Additional Info:
[Information automatically included from LibreOffice]
Locale: de
Module: StartModule
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107322] [META] Media (audio / video) bugs and enhancements

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107322

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||125242


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125242
[Bug 125242] OGG VIDEO NOT EMBEDDED
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125242] OGG VIDEO NOT EMBEDDED

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125242

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||107322


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107322
[Bug 107322] [META] Media (audio / video) bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125253] An chart object has a SeriesCollection collection but using it raise an 91 runtime error

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125253

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||108908


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108908
[Bug 108908] [META] Visual Basic for Applications (VBA) macro issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108908] [META] Visual Basic for Applications (VBA) macro issues

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108908

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||125253


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125253
[Bug 125253] An chart object has a SeriesCollection collection but using it
raise an 91 runtime error
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108908] [META] Visual Basic for Applications (VBA) macro issues

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108908

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||125252


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125252
[Bug 125252] The name property on a Chart object return an empty string
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125252] The name property on a Chart object return an empty string

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125252

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||108908


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108908
[Bug 108908] [META] Visual Basic for Applications (VBA) macro issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125250] ActiveChart is not implemented at all (423 runtime error)

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125250

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

  Component|Calc|BASIC

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108908] [META] Visual Basic for Applications (VBA) macro issues

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108908

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||125250


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125250
[Bug 125250] ActiveChart is not implemented at all (423 runtime error)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125250] ActiveChart is not implemented at all (423 runtime error)

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125250

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||108908


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108908
[Bug 108908] [META] Visual Basic for Applications (VBA) macro issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125271] Inserting this .mp4 file in impress leads to a CRASH

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125271

--- Comment #11 from Julien Nabet  ---
(In reply to Roman Kuznetsov from comment #10)
> (In reply to Julien Nabet from comment #7)
> > ...
> 
> Do you have any installed codecs in your OS like K-lite codec pack?

None so it’s due to this i suppose since LO must use not embedded libs

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107322] [META] Media (audio / video) bugs and enhancements

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107322

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||125271


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125271
[Bug 125271] Inserting this .mp4 file in impress leads to a CRASH
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125271] Inserting this .mp4 file in impress leads to a CRASH

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125271

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Blocks||107322

--- Comment #10 from Roman Kuznetsov <79045_79...@mail.ru> ---
(In reply to Julien Nabet from comment #7)
> On Win10 with master sources updated yesterday, I can't even insert the
> video.
> 
> I got an error popup message with:
> "The format of the selected file is not supported."
> 
> I click "OK" and it crashes.

Do you have any installed codecs in your OS like K-lite codec pack?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107322
[Bug 107322] [META] Media (audio / video) bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125291] EDITING: Chart is blank when chart has empty data set

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125291

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||90486


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=90486
[Bug 90486] [META] Chart bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90486] [META] Chart bugs and enhancements

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90486

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||125291


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125291
[Bug 125291] EDITING: Chart is blank when chart has empty data set
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125310] DOCX Change tracking: deleting paragraph end mark inserts a page break

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125310

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||115709


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115709
[Bug 115709] [META] DOCX (OOXML) Tracking changes-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115709] [META] DOCX (OOXML) Tracking changes-related issues

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115709

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||125310


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125310
[Bug 125310] DOCX Change tracking: deleting paragraph end mark inserts a page
break
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125306] Shortcut Ctrl+Shift+; work uncorrectly with JP keyboard

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125306

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||107243


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107243
[Bug 107243] [META] Locale keyboard shortcut issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107243] [META] Locale keyboard shortcut issues

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107243

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||125306


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125306
[Bug 125306] Shortcut Ctrl+Shift+; work uncorrectly  with JP keyboard
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118112] Parameter index out of range (1 > number of parameters, which is 0). (see comment 39 for manual fix)

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118112

--- Comment #46 from Julien Nabet  ---
(In reply to Gerhard Weydt from comment #45)
> ...
> The macro provided (see comment 28) works fine for me, now that I know, but
> this could be a problem for new users, indeed it could be a show-stopper.

I noticed the change was in release notes (see
https://wiki.documentfoundation.org/ReleaseNotes/6.1) but not the way to fix it
with the macro.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118112] Parameter index out of range (1 > number of parameters, which is 0). (see comment 39 for manual fix)

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118112

--- Comment #45 from Gerhard Weydt  ---
I still encounter this problem, although with a different message starting with
"Could not set parameter at position 1 (values was..." with Libo 6.2.2.2
(Windows 64 bit) with MariaDB and the JDBC connector (a native connector
unfortunately still does not seem to be available); erich reported nearly the
same in comment 36.
The macro provided (see comment 28) works fine for me, now that I know, but
this could be a problem for new users, indeed it could be a show-stopper.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125138] in Impress the character dialog does not remember its size

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125138

Laurent BP  changed:

   What|Removed |Added

   Keywords||regression

--- Comment #7 from Laurent BP  ---
I do NOT reproduce with same profile on Linux Ubuntu Version: 6.1.6.3
Build ID: 5896ab1714085361c45cf540f76f60673dd96a72
Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk2; 
Locale : fr-FR (fr_FR.UTF-8); Calc: group threaded

Set as regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88027] Shortcuts ctrl+; and ctrl+shift+; does not work in ru/es/pt/fi keyboard layouts

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88027

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||2918

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122918] hotkeys in LibreOffice 6 on Win do not work correctly

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122918

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=88
   ||027

--- Comment #5 from Julien Nabet  ---
Roman: if I well understood, according to your comment
https://bugs.documentfoundation.org/show_bug.cgi?id=88027#c42, it doesn't work
with RU layout but works with EN layout.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125138] in Impress the character dialog does not remember its size

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125138

--- Comment #6 from Laurent BP  ---
Correction:
(In reply to Laurent BP from comment #5)
> I do NOT reproduce:
> - on Win7, LibO 5.2.3.2
- on Win7, LibO 6.2.3.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125138] in Impress the character dialog does not remember its size

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125138

Laurent BP  changed:

   What|Removed |Added

 CC||jumbo4...@yahoo.fr
 Status|UNCONFIRMED |NEW
Version|unspecified |6.2.3.2 release
 OS|All |Linux (All)
 Ever confirmed|0   |1

--- Comment #5 from Laurent BP  ---
Thanks Jean-Baptiste for the screenshot.
I do NOT reproduce:
- on Win7, LibO 5.2.3.2
- on Linux Ubuntu Version: 6.3.0.0.alpha0+
Build ID: a42cce40cfbb9847edc23a3157dd51ac6d8b902c
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: fr-FR (fr_FR.UTF-8); UI-Language: en-US
Calc: threaded

I DO reproduce on Linux Ubuntu Version: 6.2.3.2
Build ID: aecc05fe267cc68dde00352a451aa867b3b546ac
Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3; 
Locale : fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR
Calc: threaded
WITHOUT options "Asian" and "Complex" in Language option

I do NOT reproduce if options are checked

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125234] qt5: exported PDf file misses embedded fonts with vcl=qt5

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125234

--- Comment #4 from Michael Weghorn  ---
(In reply to simon-eder from comment #3)
> I switched to the QT5 vcl some months back when Arch32 add a runtime
> dependency to the KDE libs(not installed on my system) and saving to file
> did crash LO.

That sounds like bug 123595 or bug 124598, which are be fixed now and I guess
you'd get gtk3 by default now (not sure if this this is what you want, though).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124753] Function =Randbetween(10; 99) updates value in cell every time when I paste it into another cell

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124753

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124753] Function =Randbetween(10; 99) updates value in cell every time when I paste it into another cell

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124753

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |NOTABUG

--- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> ---
(In reply to djtalisman from comment #3)
> Can you add options to choose old type?

I think better to create a new enhancement for this

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108827] [META] Calc functions bugs and enhancements

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108827
Bug 108827 depends on bug 124753, which changed state.

Bug 124753 Summary: Function =Randbetween(10;99) updates value in cell every 
time when I paste it into another cell
https://bugs.documentfoundation.org/show_bug.cgi?id=124753

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-qa] Minutes from the UX/design meeting 2019-May-15

2019-05-15 Thread Heiko Tietze
Present: Kompi, Heiko

Tickets 

* Rename tabbed layout to notebookbar
   + https://bugs.documentfoundation.org/show_bug.cgi?id=125009
   => ask on the marketing ML for input
   ==> feedback "Tabbed Notebookbar" given, UX input done

 * Insert image not in a new paragraph but in the current position or as 
character
   + https://bugs.documentfoundation.org/show_bug.cgi?id=45778
 + anchor as character and alignment "Base line at top" to comply with MS 
Word
 + q in ask.libreoffice.org
 + drawback of current alignment on paragraph is that more than one image 
adds on top of the other (Franklin)
   + see also https://bugs.documentfoundation.org/show_bug.cgi?id=87720
 + most word processors anchor as character
 + RFE: introduce an option how to anchor be default
   + provide user-defined defaults at tools > option (Csongor)
 + clutters options a bit (Franklin)
 + we could do it as expert option (Heiko)
   + alternatively keep the last used settings
 + might not work as you modify properties subsequently and we would have 
to store 
   properties at any time when changed
   => changing the default anchoring to 'as character' sounds good
   => providing agreement by ESC, ask the community and introduce the option 
when there is a split
  + Twitter: 31% To Page, 39% To Paragraph, 7% To Character, 
23% As Character (some comments "it depends")
+ result: no clear picture
  + ESC: agreement, though better w/o additional option
   + better not touch and keep to paragraph (Kompi)
   + better "to character" for wrapping and since mouse positioning is broken,
 suggest for empty paragraph "to paragraph" and when inside text "to 
character" (Regina)
   => since users and use cases differ the best solution is to have an option 
(and maybe more for 87728)

 * Save icon breaks icon customization
   + https://bugs.documentfoundation.org/show_bug.cgi?id=98193
   + accept the drawback (Andreas, Heiko)
   + possible solutions: a) combine two/n icons in one with a propriatary 
format,
 b) split the UNO command into uno:SAVEEMPTY and uno:SAVEMODIFIED, c1) draw 
the decoration
 programmatically, c2) combine/overlay two icons
   + never change icons (Kompi)
   => WF, becuase no good solution and inappropriate effort

 * Provide an option to hide the animation effect
   + https://bugs.documentfoundation.org/show_bug.cgi?id=124477
   + alternatively change the tree with details on animation into a table
 but this might exceed the sidebar width
   + option is rarely needed as most users do not have that many animations per 
slide
   + simple solution is an option "[x] Show animation type" (default = on)
   => go with the change

 * Option to turn off autocomplete text in quick find
   + https://bugs.documentfoundation.org/show_bug.cgi?id=124774
   + WF or needsDevAdvice
   + like the idea as it is often confusing (Kompi)
   => needsDevAdvice with recommendation to WF if there is no central place to 
switch it off

 * Page settings missing a few paper sizes
   + https://bugs.documentfoundation.org/show_bug.cgi?id=122696
   + adding too many options spams the list
   + not a big deal (Cor, Kompi), not convinced with 14 addiitonal options 
(Heiko)
   + even for DIN we have only A3-A6
   + it's easy to enter the paper dimension manually
   => ask the OP for a smaller selection with <5 items, eg. RA4, RA5

 * Formula result has different alignment than regular values
   + https://bugs.documentfoundation.org/show_bug.cgi?id=124860
   + switch on "Number Recognition"?
   => discussion ongoing at BZ (ticket might be a WFM now, @Cor)
   => postpone / discuss on BZ





signature.asc
Description: OpenPGP digital signature
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Minutes from the UX/design meeting 2019-May-15

2019-05-15 Thread Heiko Tietze
Present: Kompi, Heiko

Tickets 

* Rename tabbed layout to notebookbar
   + https://bugs.documentfoundation.org/show_bug.cgi?id=125009
   => ask on the marketing ML for input
   ==> feedback "Tabbed Notebookbar" given, UX input done

 * Insert image not in a new paragraph but in the current position or as 
character
   + https://bugs.documentfoundation.org/show_bug.cgi?id=45778
 + anchor as character and alignment "Base line at top" to comply with MS 
Word
 + q in ask.libreoffice.org
 + drawback of current alignment on paragraph is that more than one image 
adds on top of the other (Franklin)
   + see also https://bugs.documentfoundation.org/show_bug.cgi?id=87720
 + most word processors anchor as character
 + RFE: introduce an option how to anchor be default
   + provide user-defined defaults at tools > option (Csongor)
 + clutters options a bit (Franklin)
 + we could do it as expert option (Heiko)
   + alternatively keep the last used settings
 + might not work as you modify properties subsequently and we would have 
to store 
   properties at any time when changed
   => changing the default anchoring to 'as character' sounds good
   => providing agreement by ESC, ask the community and introduce the option 
when there is a split
  + Twitter: 31% To Page, 39% To Paragraph, 7% To Character, 
23% As Character (some comments "it depends")
+ result: no clear picture
  + ESC: agreement, though better w/o additional option
   + better not touch and keep to paragraph (Kompi)
   + better "to character" for wrapping and since mouse positioning is broken,
 suggest for empty paragraph "to paragraph" and when inside text "to 
character" (Regina)
   => since users and use cases differ the best solution is to have an option 
(and maybe more for 87728)

 * Save icon breaks icon customization
   + https://bugs.documentfoundation.org/show_bug.cgi?id=98193
   + accept the drawback (Andreas, Heiko)
   + possible solutions: a) combine two/n icons in one with a propriatary 
format,
 b) split the UNO command into uno:SAVEEMPTY and uno:SAVEMODIFIED, c1) draw 
the decoration
 programmatically, c2) combine/overlay two icons
   + never change icons (Kompi)
   => WF, becuase no good solution and inappropriate effort

 * Provide an option to hide the animation effect
   + https://bugs.documentfoundation.org/show_bug.cgi?id=124477
   + alternatively change the tree with details on animation into a table
 but this might exceed the sidebar width
   + option is rarely needed as most users do not have that many animations per 
slide
   + simple solution is an option "[x] Show animation type" (default = on)
   => go with the change

 * Option to turn off autocomplete text in quick find
   + https://bugs.documentfoundation.org/show_bug.cgi?id=124774
   + WF or needsDevAdvice
   + like the idea as it is often confusing (Kompi)
   => needsDevAdvice with recommendation to WF if there is no central place to 
switch it off

 * Page settings missing a few paper sizes
   + https://bugs.documentfoundation.org/show_bug.cgi?id=122696
   + adding too many options spams the list
   + not a big deal (Cor, Kompi), not convinced with 14 addiitonal options 
(Heiko)
   + even for DIN we have only A3-A6
   + it's easy to enter the paper dimension manually
   => ask the OP for a smaller selection with <5 items, eg. RA4, RA5

 * Formula result has different alignment than regular values
   + https://bugs.documentfoundation.org/show_bug.cgi?id=124860
   + switch on "Number Recognition"?
   => discussion ongoing at BZ (ticket might be a WFM now, @Cor)
   => postpone / discuss on BZ





signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 125272] CALC doesn’t detect an invalid entry for references in the aggregate function

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125272

Djaafar Benchikh  changed:

   What|Removed |Added

 Status|NEEDINFO|REOPENED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125272] CALC doesn’t detect an invalid entry for references in the aggregate function

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125272

--- Comment #3 from Djaafar Benchikh  ---

the correct format of references is like A1, A2, B1, B2.  while in CALC the
aggregate function gives a result for an incorrect format of references

aggregate(2,4,A1,A5)correcte format
aggregate(2,4,1,1) incorrect format

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125308] change in handling of adapting ranges when inserting space - intentional?

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125308

Oliver Brinzing  changed:

   What|Removed |Added

 CC||oliver.brinz...@gmx.de
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from Oliver Brinzing  ---
(In reply to b. from comment #0)
> sample: open attachment in next comment, check the range referenced in B2,
> mark the yellow range and insert rows above, check the range in the cell
> moved from B2 to B5, it's expanded above the cell with the formula. 

Do you use same settings, e.g.:

Tools/Options/LibreOfficeDEv Calc/General
[ ] Expand references when new columns/rows are inserted

Can you please add some screenshots/screencast to demonstrate?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Problem to build by using lode under Mac OS.

2019-05-15 Thread julien2412
If it's a Java problem, it could be interesting to remove any traces of Java
(you can for example take a look to
https://www.java.com/en/download/help/mac_uninstall_java.xml +
https://www.howtogeek.com/230145/how-to-uninstall-java-on-mac-os-x/) and
install a new version from scratch.

If possible, just install 1 Java, it'll make things easier.

Julien



--
Sent from: 
http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 124753] Function =Randbetween(10; 99) updates value in cell every time when I paste it into another cell

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124753

djtalis...@mail.ru changed:

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Ever confirmed|0   |1
 Resolution|NOTABUG |---

--- Comment #3 from djtalis...@mail.ru ---
Can you add options to choose old type?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108827] [META] Calc functions bugs and enhancements

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108827
Bug 108827 depends on bug 124753, which changed state.

Bug 124753 Summary: Function =Randbetween(10;99) updates value in cell every 
time when I paste it into another cell
https://bugs.documentfoundation.org/show_bug.cgi?id=124753

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|NOTABUG |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90297] LibreOffice Math dark theme > dark text and background

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90297

--- Comment #12 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/f9c94cfdde6c0af621cf80467a9d83c789699093%5E%21

tdf#90297 set default SmEditWindow background

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125314] document linking is not supported in .docx format and causes a silent failure and loss of function

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125314

--- Comment #1 from ke...@thecolyers.net ---
Created attachment 151447
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151447=edit
Three test documents in odt, doc and docx to demonstrate document linking bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125314] New: document linking is not supported in .docx format and causes a silent failure and loss of function

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125314

Bug ID: 125314
   Summary: document linking is not supported in .docx format and
causes a silent failure and loss of function
   Product: LibreOffice
   Version: 6.2.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ke...@thecolyers.net

Description:
When creating a document link to another document (.odt,.pdf or whatever) works
perfectly in .odt and .doc. However, it seems to work when the document is
.docx but although the links are made on saving the document and reopening the
link reverts to a internet form of linking. This means the document either
can't find the file pointed to as it uses web semantics to find the file and
can't match the path or just doesn't open the link. Especially when moving the
containing folder from user to user.

Steps to Reproduce:
1.Start a new document. Save as .docx
2.Start linking other documents using Insert / Hyperlink / Document
3.Test links with ctrl-click. Link works - opens linked document
4.Save and close.
4a. Optional - move containing folder
5.Reopen and test links with ctrl-click.

Actual Results:
Links do not open a file or file is not found. When examining the hyperlink the
document link is now an internet link.

Expected Results:
Should open the linked document even when the containing folder is transferred
to another user/place in file system.


Reproducible: Always


User Profile Reset: No



Additional Info:
A warning about a non-supported behaviour would have been helpful! Took a while
to track down!

This is a particularly annoying bug as you can test a link just after making
it, but on reopening the doc the link is gone. 

I know this is a .docx filter problem but I think it needs flagging. Just
turned out my employer really wanted me to link documents like this and .docx
was the gotcha!

Workaround: use .doc or .odt!!!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125009] Rename tabbed layout to notebookbar

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125009

--- Comment #17 from Heiko Tietze  ---
So let's go with Andreas' proposal in comment 15 (personally I don't like it).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125009] Rename tabbed layout to notebookbar

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125009

--- Comment #18 from Roman Kuznetsov <79045_79...@mail.ru> ---
(In reply to andreas_k from comment #15)
> (In reply to Heiko Tietze from comment #14)
> > Asked on the marketing list and the recommendation is to go with "Tabbed
> > Notebookbar".
> 
> For readability I would recommend
> - Notebookbar Tabbed
> - Notebookbar Tabbed compact
> 
> And for Toolbars
> - Toolbar Standard
> - Toolbar Single
> - Sidebar

Let's delete Sidebar from this submenu. There is the same item just in View

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111198] Offline help icons misplaced

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98

V Stuart Foote  changed:

   What|Removed |Added

 Resolution|WONTFIX |WORKSFORME

--- Comment #6 from V Stuart Foote  ---
(In reply to Pedro from comment #5)
> 
> This bug is now irrelevant. LibreOffice no longer (at least since the 6.1
> branch) uses the Windows Help system. The Offline help is a local copy of
> the Online help.
> It was not fixed and now it is an obsolete issue.

Sorry Pedro, but as you have once again not read the code--we have never used
the Windows help system. Rather an internally provided Writer/Web viewer for
the HELP content converted from XML via XSLT. See the bug 97629 meta to unwind
what has been done.

At the moment the  tagging (likely what you confuse for the Windows Help
system) is disconnected--see bug 118148 where essentially we have to reconnect
the old XHP links across the UI.

The NEWHELP has moved from that internal rendering of the HELP content, to a
javascript enabled content drawn from local URLs and rendered into a modern
browser as available on system per user choice. 

And, yes it packages the same help content delivered on line--but it has the
same path issues with icons. At the moment a lot of the .SVG icons are not
correctly picked up in locally installed NEWHELP.

The issue here though has been resolved, with off-line help installed the
images_helpimg.zip is being written and populated with icons still needed by
the NEWHELP instance. And the other icon themes no longer create a
../res/helpimg directory.

=> WFM

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 3 commits - editeng/source include/editeng starmath/inc starmath/source

2019-05-15 Thread Jan-Marek Glogowski (via logerrit)
 editeng/source/editeng/editeng.cxx|   10 
 editeng/source/editeng/impedit.hxx|4 -
 editeng/source/editeng/impedit2.cxx   |1 
 editeng/source/editeng/impedit3.cxx   |4 -
 include/editeng/editeng.hxx   |2 
 starmath/inc/ElementsDockingWindow.hxx|3 +
 starmath/inc/document.hxx |2 
 starmath/inc/edit.hxx |1 
 starmath/inc/smmod.hxx|2 
 starmath/inc/view.hxx |3 -
 starmath/source/ElementsDockingWindow.cxx |   68 +++---
 starmath/source/document.cxx  |8 +--
 starmath/source/edit.cxx  |   12 +++--
 starmath/source/smmod.cxx |   29 
 starmath/source/view.cxx  |   16 ++-
 15 files changed, 79 insertions(+), 86 deletions(-)

New commits:
commit 87b8c32f2f72fc9373abe1fc53a2d47183c5f5d3
Author: Jan-Marek Glogowski 
AuthorDate: Tue May 14 03:11:17 2019 +
Commit: Jan-Marek Glogowski 
CommitDate: Wed May 15 19:38:29 2019 +0200

SM fix element control scrollbar

The element layouting must always be done without a scrollbar, so
it can be decided, if a scrollbar is needed. If it's needed the
first paint will update the scrollbar accordingly.

This also sets the scrollbar's page size to the control height,
so clicking in an empty area will correctly scroll the widget not
just a single pixel.

Change-Id: Ib9a0eb1952bc0355f683cd8d116c61f9c9d462c4
Reviewed-on: https://gerrit.libreoffice.org/72315
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/starmath/inc/ElementsDockingWindow.hxx 
b/starmath/inc/ElementsDockingWindow.hxx
index fe712401f773..c98072143bdc 100644
--- a/starmath/inc/ElementsDockingWindow.hxx
+++ b/starmath/inc/ElementsDockingWindow.hxx
@@ -77,6 +77,7 @@ class SmElementsControl : public Control
 virtual void MouseButtonDown(const MouseEvent& rMEvt) override;
 virtual void MouseMove(const MouseEvent& rMEvt) override;
 virtual void RequestHelp(const HelpEvent& rHEvt) override;
+virtual void Resize() override;
 
 SmDocShell*   mpDocShell;
 SmFormat  maFormat;
@@ -88,6 +89,7 @@ class SmElementsControl : public Control
 Size  maMaxElementDimensions;
 bool  mbVerticalMode;
 VclPtr< ScrollBar > mxScroll;
+bool mbFirstPaintAfterLayout;
 
 void addElement(const OUString& aElementVisual, const OUString& 
aElementSource, const OUString& aHelpText);
 
diff --git a/starmath/source/ElementsDockingWindow.cxx 
b/starmath/source/ElementsDockingWindow.cxx
index ab0ad7dd689e..36af328f1ced 100644
--- a/starmath/source/ElementsDockingWindow.cxx
+++ b/starmath/source/ElementsDockingWindow.cxx
@@ -238,6 +238,7 @@ SmElementsControl::SmElementsControl(vcl::Window *pParent)
 , mpCurrentElement(nullptr)
 , mbVerticalMode(true)
 , mxScroll(VclPtr::Create(this, WB_VERT))
+, mbFirstPaintAfterLayout(false)
 {
 set_id("element_selector");
 SetMapMode( MapMode(MapUnit::Map100thMM) );
@@ -248,7 +249,6 @@ SmElementsControl::SmElementsControl(vcl::Window *pParent)
 maFormat.SetBaseSize(PixelToLogic(Size(0, SmPtsTo100th_mm(12;
 
 mxScroll->SetScrollHdl( LINK(this, SmElementsControl, ScrollHdl) );
-mxScroll->Show();
 }
 
 SmElementsControl::~SmElementsControl()
@@ -268,14 +268,19 @@ void SmElementsControl::setVerticalMode(bool 
bVerticalMode)
 mbVerticalMode = bVerticalMode;
 }
 
+/**
+ * !pContext => layout only
+ *
+ * Layouting is always done without a scrollbar and will show or hide it.
+ * The first paint (mbFirstPaintAfterLayout) therefore needs to update a
+ * visible scrollbar, because the layouting was wrong.
+ **/
 void SmElementsControl::LayoutOrPaintContents(vcl::RenderContext *pContext)
 {
-bool bOldVisibleState = mxScroll->IsVisible();
-
-sal_Int32 nScrollbarWidth = bOldVisibleState ? 
GetSettings().GetStyleSettings().GetScrollBarSize() : 0;
-
-sal_Int32 nControlWidth = GetOutputSizePixel().Width() - nScrollbarWidth;
-sal_Int32 nControlHeight = GetOutputSizePixel().Height();
+const sal_Int32 nScrollbarWidth = 
GetSettings().GetStyleSettings().GetScrollBarSize();
+const sal_Int32 nControlWidth = GetOutputSizePixel().Width()
+- (pContext && mxScroll->IsVisible() ? 
nScrollbarWidth : 0);
+const sal_Int32 nControlHeight = GetOutputSizePixel().Height();
 
 sal_Int32 boxX = maMaxElementDimensions.Width()  + 10;
 sal_Int32 boxY = maMaxElementDimensions.Height() + 10;
@@ -379,15 +384,21 @@ void 
SmElementsControl::LayoutOrPaintContents(vcl::RenderContext *pContext)
 }
 
 if (pContext)
-return;
+{
+if (!mbFirstPaintAfterLayout || !mxScroll->IsVisible())
+return;
+mbFirstPaintAfterLayout = false;
+}
+else
+mbFirstPaintAfterLayout = true;
 
 sal_Int32 

[Libreoffice-bugs] [Bug 125234] qt5: exported PDf file misses embedded fonts with vcl=qt5

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125234

--- Comment #3 from simon-e...@web.de ---
I'm using LxQt as DE based on QT5. 
I switched to the QT5 vcl some months back when Arch32 add a runtime dependency
to the KDE libs(not installed on my system) and saving to file did crash LO.
Switching to vcl=QT5 solved the problem. Everything worked fine until I wanted
to do an PDF export and it failed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Converting Python Tuples / Lists into Any in PyUNO

2019-05-15 Thread Thomas Viehmann

Hello,

currently, the PyUNO bridge converts tuples and lists by converting each 
element to Any and then constructing a list of []Any.
This is not what many functions expect and leads to a suboptimal 
experience, e.g. when using XPropertySet.setPropertyValue:


https://forum.openoffice.org/en/forum/viewtopic.php?t=56460

https://bugs.documentfoundation.org/show_bug.cgi?id=125307

A lazy grep through the sdk/idl gives
80 uses of []Any ( rgrep 'sequence< *any' sdk/idl | wc -l )
220 uses of []String ( rgrep 'sequence< *string' sdk/idl  | wc -l )

but that isn't really what this is about, it's about what sequence types 
are expected when an any is passed.


My intuition would be that the more specific type is better when 
applicable, but I would value your input whether such a change would be 
considered an improvement.


Best regards

Thomas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: vcl/qt5

2019-05-15 Thread Michael Weghorn (via logerrit)
 vcl/qt5/Qt5Widget.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 48e44b367a6fde947963de0d896e5d276a7f231e
Author: Michael Weghorn 
AuthorDate: Wed May 15 13:28:15 2019 +0200
Commit: Rene Engelhard 
CommitDate: Wed May 15 19:11:57 2019 +0200

qt5: Fix build error on 32 bit archs

... as observed in [1]:

> [...]
> In file included from /usr/include/c++/8/algorithm:61,
>  from 
/usr/include/i386-linux-gnu/qt5/QtCore/qglobal.h:142,
>  from 
/usr/include/i386-linux-gnu/qt5/QtGui/qtguiglobal.h:43,
>  from 
/usr/include/i386-linux-gnu/qt5/QtWidgets/qtwidgetsglobal.h:43,
>  from 
/usr/include/i386-linux-gnu/qt5/QtWidgets/qwidget.h:43,
>  from /usr/include/i386-linux-gnu/qt5/QtWidgets/QWidget:1,
>  from /<>/vcl/inc/qt5/Qt5Widget.hxx:22,
>  from /<>/vcl/qt5/Qt5Widget.cxx:20:
> /usr/include/c++/8/bits/stl_algobase.h:265:5: note: candidate: 
‘template constexpr const _Tp& std::max(const _Tp&, 
const _Tp&, _Compare)’
>  max(const _Tp& __a, const _Tp& __b, _Compare __comp)
>  ^~~
> /usr/include/c++/8/bits/stl_algobase.h:265:5: note:   template argument 
deduction/substitution failed:
> /<>/vcl/qt5/Qt5Widget.cxx:502:69: note:   deduced 
conflicting types for parameter ‘const _Tp’ (‘int’ and ‘sal_Int32’ {aka ‘long 
int’})
>  std::vector aTextAttrs(std::max(1, nLength), 
ExtTextInputAttr::NONE);

[1] 
https://buildd.debian.org/status/fetch.php?pkg=libreoffice=i386=1%3A6.3.0%7Ealpha1-1=1557890923=0

Change-Id: Ic0e3e0b8bc65d9755b3d62385673f8d1e357b122
Reviewed-on: https://gerrit.libreoffice.org/72352
Tested-by: Jenkins
Reviewed-by: Rene Engelhard 
Tested-by: Rene Engelhard 

diff --git a/vcl/qt5/Qt5Widget.cxx b/vcl/qt5/Qt5Widget.cxx
index 23afbea688fd..88ce1b18f0e7 100644
--- a/vcl/qt5/Qt5Widget.cxx
+++ b/vcl/qt5/Qt5Widget.cxx
@@ -499,7 +499,8 @@ void Qt5Widget::inputMethodEvent(QInputMethodEvent* pEvent)
 
 const sal_Int32 nLength = aInputEvent.maText.getLength();
 const QList& rAttrList = 
pEvent->attributes();
-std::vector aTextAttrs(std::max(1, nLength), 
ExtTextInputAttr::NONE);
+std::vector aTextAttrs(std::max(sal_Int32(1), 
nLength),
+ ExtTextInputAttr::NONE);
 aInputEvent.mpTextAttr = [0];
 
 for (int i = 0; i < rAttrList.size(); ++i)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125312] FILEOPEN DOCX Table with two rows disappears after line break

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125312

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
 Status|UNCONFIRMED |NEW
 Blocks||108519, 108771, 10
 Ever confirmed|0   |1

--- Comment #3 from Dieter Praas  ---
I confirm it with

Version: 6.2.3.2 (x64)
Build-ID: aecc05fe267cc68dde00352a451aa867b3b546ac
CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: threaded

Additional information: It doesn't depend on change of page format. If I change
second page to portrait the bug occurs also.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=10
[Bug 10] [META] DOCX (OOXML) table-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108519
[Bug 108519] [META] Page break bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108771
[Bug 108771] [META] DOCX (OOXML) page-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108519] [META] Page break bugs and enhancements

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108519

Dieter Praas  changed:

   What|Removed |Added

 Depends on||125312


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125312
[Bug 125312] FILEOPEN DOCX Table with two rows disappears after line break
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108771] [META] DOCX (OOXML) page-related issues

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108771

Dieter Praas  changed:

   What|Removed |Added

 Depends on||125312


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125312
[Bug 125312] FILEOPEN DOCX Table with two rows disappears after line break
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=10

Dieter Praas  changed:

   What|Removed |Added

 Depends on||125312


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125312
[Bug 125312] FILEOPEN DOCX Table with two rows disappears after line break
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc vcl/source vcl/unx

2019-05-15 Thread Jan-Marek Glogowski (via logerrit)
 vcl/inc/window.h|5 +++
 vcl/source/window/accessibility.cxx |   46 +++
 vcl/unx/gtk/gtksalframe.cxx |   47 
 vcl/unx/gtk3/gtk3gtkframe.cxx   |   47 
 4 files changed, 53 insertions(+), 92 deletions(-)

New commits:
commit ffd98521de175057e47d53f80685a70215959384
Author: Jan-Marek Glogowski 
AuthorDate: Wed May 15 13:39:38 2019 +
Commit: Jan-Marek Glogowski 
CommitDate: Wed May 15 19:07:52 2019 +0200

Move FindFocusedEditableText from gtk* into vcl

Now that it will be used by four VCL plugins, move its code into
the common VCL library. The none-XAccessibility, none-UNO version
used on Windows needs much more work to function with various
widgets (including some API refactoring IMHO).
(see ImplHandleSalSurroundingTextRequest and friends).

Change-Id: I0fdf72336a66fc578b18b1edc8f8627d5dfdc57f
Reviewed-on: https://gerrit.libreoffice.org/72364
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/vcl/inc/window.h b/vcl/inc/window.h
index 8e0e53b88202..bdd64c1de5db 100644
--- a/vcl/inc/window.h
+++ b/vcl/inc/window.h
@@ -58,6 +58,8 @@ namespace com { namespace sun { namespace star {
 
 namespace accessibility {
 class XAccessible;
+class XAccessibleContext;
+class XAccessibleEditableText;
 }
 
 namespace rendering {
@@ -424,6 +426,9 @@ void ImplHandleResize( vcl::Window* pWindow, long 
nNewWidth, long nNewHeight );
 VCL_DLLPUBLIC void ImplWindowStateFromStr(WindowStateData& rData, const 
OString& rStr);
 VCL_DLLPUBLIC OString ImplWindowStateToStr(const WindowStateData& rData);
 
+VCL_DLLPUBLIC css::uno::Reference
+FindFocusedEditableText(css::uno::Reference
 const&);
+
 #endif // INCLUDED_VCL_INC_WINDOW_H
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/window/accessibility.cxx 
b/vcl/source/window/accessibility.cxx
index a4e800373347..1b858386eb06 100644
--- a/vcl/source/window/accessibility.cxx
+++ b/vcl/source/window/accessibility.cxx
@@ -73,6 +73,8 @@
 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -638,4 +640,48 @@ void Window::SetAccessibilityEventsSuppressed(bool 
bSuppressed)
 
 } /* namespace vcl */
 
+uno::Reference
+FindFocusedEditableText(uno::Reference 
const& xContext)
+{
+if (!xContext.is())
+return uno::Reference();
+
+uno::Reference xState = 
xContext->getAccessibleStateSet();
+if (xState.is())
+{
+if (xState->contains(accessibility::AccessibleStateType::FOCUSED))
+{
+uno::Reference xText
+= 
uno::Reference(xContext, 
uno::UNO_QUERY);
+if (xText.is())
+return xText;
+if 
(xState->contains(accessibility::AccessibleStateType::MANAGES_DESCENDANTS))
+return 
uno::Reference();
+}
+}
+
+bool bSafeToIterate = true;
+sal_Int32 nCount = xContext->getAccessibleChildCount();
+if (nCount < 0 || nCount > SAL_MAX_UINT16 /* slow enough for anyone */)
+bSafeToIterate = false;
+if (!bSafeToIterate)
+return uno::Reference();
+
+for (sal_Int32 i = 0; i < xContext->getAccessibleChildCount(); ++i)
+{
+uno::Reference xChild = 
xContext->getAccessibleChild(i);
+if (!xChild.is())
+continue;
+uno::Reference xChildContext
+= xChild->getAccessibleContext();
+if (!xChildContext.is())
+continue;
+uno::Reference xText
+= FindFocusedEditableText(xChildContext);
+if (xText.is())
+return xText;
+}
+return uno::Reference();
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/unx/gtk/gtksalframe.cxx b/vcl/unx/gtk/gtksalframe.cxx
index abad3d42a241..75be17dcddc9 100644
--- a/vcl/unx/gtk/gtksalframe.cxx
+++ b/vcl/unx/gtk/gtksalframe.cxx
@@ -69,9 +69,6 @@
 #endif
 
 #include 
-#include 
-#include 
-#include 
 #include 
 
 #include 
@@ -3485,48 +3482,6 @@ void GtkSalFrame::IMHandler::signalIMPreeditEnd( 
GtkIMContext*, gpointer im_hand
 pThis->updateIMSpotLocation();
 }
 
-static uno::Reference
-FindFocus(const uno::Reference< accessibility::XAccessibleContext >& 
xContext)
-{
-if (!xContext.is())
-return uno::Reference< accessibility::XAccessibleEditableText >();
-
-uno::Reference xState = 
xContext->getAccessibleStateSet();
-if (xState.is())
-{
-if (xState->contains(accessibility::AccessibleStateType::FOCUSED))
-{
-uno::Reference< accessibility::XAccessibleEditableText > xText =
-
uno::Reference(xContext, 
uno::UNO_QUERY);
-if (xText.is())
-return xText;
-if 
(xState->contains(accessibility::AccessibleStateType::MANAGES_DESCENDANTS))
-return uno::Reference< accessibility::XAccessibleEditableText 
>();
- 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - chart2/source comphelper/source cui/source include/comphelper include/svx sc/source sd/source sw/source

2019-05-15 Thread Caolán McNamara (via logerrit)
 chart2/source/controller/main/ChartController_TextEdit.cxx |2 
 comphelper/source/misc/dispatchcommand.cxx |   28 +++--
 cui/source/dialogs/cuicharmap.cxx  |   17 ---
 cui/source/factory/dlgfact.cxx |9 ++--
 cui/source/factory/dlgfact.hxx |4 -
 cui/source/factory/init.cxx|2 
 cui/source/inc/cuicharmap.hxx  |5 +-
 cui/source/tabpages/autocdlg.cxx   |4 -
 cui/source/tabpages/chardlg.cxx|2 
 cui/source/tabpages/numpages.cxx   |2 
 include/comphelper/dispatchcommand.hxx |9 +++-
 include/svx/svxdlg.hxx |3 -
 sc/source/ui/view/cellsh1.cxx  |5 +-
 sc/source/ui/view/viewutil.cxx |3 -
 sd/source/ui/func/fubullet.cxx |3 -
 sw/source/ui/misc/insfnote.cxx |2 
 sw/source/ui/misc/srtdlg.cxx   |2 
 sw/source/uibase/shells/annotsh.cxx|3 -
 sw/source/uibase/shells/drwtxtsh.cxx   |3 -
 sw/source/uibase/shells/textsh.cxx |3 -
 20 files changed, 67 insertions(+), 44 deletions(-)

New commits:
commit cdaa535937a645345b91c90fbebae344c811e741
Author: Caolán McNamara 
AuthorDate: Tue May 14 12:41:09 2019 +0100
Commit: Michael Stahl 
CommitDate: Wed May 15 19:04:22 2019 +0200

Resolves: tdf#120423 dispatch against the correct Frame

Change-Id: I5ea2e5d7b79efbd2b14d0b528e5a5c3e44e643bc
Reviewed-on: https://gerrit.libreoffice.org/72292
Reviewed-by: Michael Stahl 
Tested-by: Jenkins

diff --git a/chart2/source/controller/main/ChartController_TextEdit.cxx 
b/chart2/source/controller/main/ChartController_TextEdit.cxx
index 0a9669626fcb..668c433830dc 100644
--- a/chart2/source/controller/main/ChartController_TextEdit.cxx
+++ b/chart2/source/controller/main/ChartController_TextEdit.cxx
@@ -168,7 +168,7 @@ void 
ChartController::executeDispatch_InsertSpecialCharacter()
 aSet.Put( SvxFontItem( aCurFont.GetFamilyType(), aCurFont.GetFamilyName(), 
aCurFont.GetStyleName(), aCurFont.GetPitch(), aCurFont.GetCharSet(), 
SID_ATTR_CHAR_FONT ) );
 
 vcl::Window* pWin = GetChartWindow();
-ScopedVclPtr pDlg(pFact->CreateCharMapDialog(pWin ? 
pWin->GetFrameWeld() : nullptr, aSet, false));
+ScopedVclPtr pDlg(pFact->CreateCharMapDialog(pWin ? 
pWin->GetFrameWeld() : nullptr, aSet, nullptr));
 if( pDlg->Execute() == RET_OK )
 {
 const SfxItemSet* pSet = pDlg->GetOutputItemSet();
diff --git a/comphelper/source/misc/dispatchcommand.cxx 
b/comphelper/source/misc/dispatchcommand.cxx
index 90d181d2e0e4..0b5d3b18a65a 100644
--- a/comphelper/source/misc/dispatchcommand.cxx
+++ b/comphelper/source/misc/dispatchcommand.cxx
@@ -31,22 +31,15 @@ using namespace css;
 
 namespace comphelper {
 
-bool dispatchCommand(const OUString& rCommand, const 
css::uno::Sequence& rArguments, const 
uno::Reference& aListener)
+bool dispatchCommand(const OUString& rCommand, const 
uno::Reference& rFrame, const 
css::uno::Sequence& rArguments, const 
uno::Reference& rListener)
 {
-// Target where we will execute the .uno: command
-uno::Reference xContext = 
::comphelper::getProcessComponentContext();
-uno::Reference xDesktop = 
frame::Desktop::create(xContext);
-
-uno::Reference xFrame(xDesktop->getActiveFrame());
-if (!xFrame.is())
-xFrame.set(xDesktop, uno::UNO_QUERY);
-
-uno::Reference xDispatchProvider(xFrame, 
uno::UNO_QUERY);
+uno::Reference xDispatchProvider(rFrame, 
uno::UNO_QUERY);
 if (!xDispatchProvider.is())
 return false;
 
 util::URL aCommandURL;
 aCommandURL.Complete = rCommand;
+uno::Reference xContext = 
::comphelper::getProcessComponentContext();
 uno::Reference xParser = 
util::URLTransformer::create(xContext);
 xParser->parseStrict(aCommandURL);
 
@@ -57,13 +50,26 @@ bool dispatchCommand(const OUString& rCommand, const 
css::uno::Sequence xNotifyingDisp(xDisp, 
uno::UNO_QUERY);
 if (xNotifyingDisp.is())
-xNotifyingDisp->dispatchWithNotification(aCommandURL, rArguments, 
aListener);
+xNotifyingDisp->dispatchWithNotification(aCommandURL, rArguments, 
rListener);
 else
 xDisp->dispatch(aCommandURL, rArguments);
 
 return true;
 }
 
+bool dispatchCommand(const OUString& rCommand, const 
css::uno::Sequence& rArguments, const 
uno::Reference& rListener)
+{
+// Target where we will execute the .uno: command
+uno::Reference xContext = 
::comphelper::getProcessComponentContext();
+uno::Reference xDesktop = 
frame::Desktop::create(xContext);
+
+uno::Reference xFrame(xDesktop->getActiveFrame());
+if (!xFrame.is())
+   

  1   2   3   4   5   >