[Libreoffice-bugs] [Bug 125609] radiobutton receives item status changed event after listbox value selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125609

--- Comment #12 from Justin L  ---
Created attachment 152284
  --> https://bugs.documentfoundation.org/attachment.cgi?id=152284=edit
multipleRadioButtonsChecked-grammalecte.oxt: minimal example with all the radio
buttons checked

proposed fix for comments 10/11 at https://gerrit.libreoffice.org/74108
tdf#125609c10 vcl/button: enforce only one radio selected on init

which will also solve the problem of ignoring the "checked" status if the first
radio is marked as tabstop - which was the case in the Grammalecte extension.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: framework/inc framework/source

[Arkadiy Illarionov (via logerrit)]

 framework/inc/uielement/constitemcontainer.hxx|3 +--
 framework/inc/uielement/itemcontainer.hxx |3 +--
 framework/source/fwi/uielement/constitemcontainer.cxx |   13 +++--
 framework/source/fwi/uielement/itemcontainer.cxx  |   11 ++-
 framework/source/fwi/uielement/rootitemcontainer.cxx  |2 +-
 5 files changed, 8 insertions(+), 24 deletions(-)

New commits:
commit 60271c4433372097ef5ecc74e522532ebf5af8e0
Author: Arkadiy Illarionov 
AuthorDate: Wed Jun 19 00:10:12 2019 +0300
Commit: Stephan Bergmann 
CommitDate: Wed Jun 19 07:53:35 2019 +0200

tdf#39593 Remove GetImplementation from ConstItemContainer and ItemContainer

Replace with comphelper::getUnoTunnelImplementation.

Change-Id: I87e1d3afd3a742926c7054179092d3b58b6b4563
Reviewed-on: https://gerrit.libreoffice.org/74310
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/framework/inc/uielement/constitemcontainer.hxx 
b/framework/inc/uielement/constitemcontainer.hxx
index 5efc22b30fdb..9ed27693829d 100644
--- a/framework/inc/uielement/constitemcontainer.hxx
+++ b/framework/inc/uielement/constitemcontainer.hxx
@@ -56,8 +56,7 @@ class FWI_DLLPUBLIC ConstItemContainer : public 
::cppu::WeakImplHelper<
 virtual ~ConstItemContainer() override;
 
 // XUnoTunnel
-static const css::uno::Sequence< sal_Int8 >&   GetUnoTunnelId() 
throw();
-static ConstItemContainer*  
GetImplementation( const css::uno::Reference< css::uno::XInterface >& rxIFace ) 
throw();
+static const css::uno::Sequence< sal_Int8 >&   getUnoTunnelId() 
throw();
 sal_Int64   SAL_CALL 
getSomething( const css::uno::Sequence< sal_Int8 >& rIdentifier ) override;
 
 // XIndexAccess
diff --git a/framework/inc/uielement/itemcontainer.hxx 
b/framework/inc/uielement/itemcontainer.hxx
index d3fb00b56952..156d7ffd4904 100644
--- a/framework/inc/uielement/itemcontainer.hxx
+++ b/framework/inc/uielement/itemcontainer.hxx
@@ -48,8 +48,7 @@ class FWI_DLLPUBLIC ItemContainer :   public 
::cppu::WeakImplHelper< css::contai
 //  XInterface, XTypeProvider
 
 // XUnoTunnel
-static const css::uno::Sequence< sal_Int8 >&   GetUnoTunnelId() 
throw();
-static ItemContainer*   
GetImplementation( const css::uno::Reference< css::uno::XInterface >& rxIFace ) 
throw();
+static const css::uno::Sequence< sal_Int8 >&   getUnoTunnelId() 
throw();
 
 // XIndexContainer
 virtual void SAL_CALL insertByIndex( sal_Int32 Index, const 
css::uno::Any& Element ) override;
diff --git a/framework/source/fwi/uielement/constitemcontainer.cxx 
b/framework/source/fwi/uielement/constitemcontainer.cxx
index d1e45af96492..03d638f10ae6 100644
--- a/framework/source/fwi/uielement/constitemcontainer.cxx
+++ b/framework/source/fwi/uielement/constitemcontainer.cxx
@@ -151,7 +151,7 @@ Reference< XIndexAccess > 
ConstItemContainer::deepCopyContainer( const Reference
 Reference< XIndexAccess > xReturn;
 if ( rSubContainer.is() )
 {
-ItemContainer*  pSource = ItemContainer::GetImplementation( 
rSubContainer );
+ItemContainer*  pSource = 
comphelper::getUnoTunnelImplementation( rSubContainer );
 ConstItemContainer* pSubContainer( nullptr );
 if ( pSource )
 pSubContainer = new ConstItemContainer( *pSource );
@@ -166,7 +166,7 @@ Reference< XIndexAccess > 
ConstItemContainer::deepCopyContainer( const Reference
 // XUnoTunnel
 sal_Int64 ConstItemContainer::getSomething( const css::uno::Sequence< sal_Int8 
>& rIdentifier )
 {
-if( ( rIdentifier.getLength() == 16 ) && ( 0 == memcmp( 
ConstItemContainer::GetUnoTunnelId().getConstArray(), 
rIdentifier.getConstArray(), 16 ) ) )
+if( ( rIdentifier.getLength() == 16 ) && ( 0 == memcmp( 
ConstItemContainer::getUnoTunnelId().getConstArray(), 
rIdentifier.getConstArray(), 16 ) ) )
 {
 return reinterpret_cast< sal_Int64 >( this );
 }
@@ -178,18 +178,11 @@ namespace
 class theConstItemContainerUnoTunnelId : public rtl::Static< 
UnoTunnelIdInit, theConstItemContainerUnoTunnelId > {};
 }
 
-const Sequence< sal_Int8 >& ConstItemContainer::GetUnoTunnelId() throw()
+const Sequence< sal_Int8 >& ConstItemContainer::getUnoTunnelId() throw()
 {
 return theConstItemContainerUnoTunnelId::get().getSeq();
 }
 
-ConstItemContainer* ConstItemContainer::GetImplementation( const 
css::uno::Reference< css::uno::XInterface >& rxIFace ) throw()
-{
-css::uno::Reference< css::lang::XUnoTunnel > xUT( rxIFace, 
css::uno::UNO_QUERY );
-return xUT.is() ? reinterpret_cast< ConstItemContainer* 
>(sal::static_int_cast< sal_IntPtr >(
-  xUT->getSomething( 
ConstItemContainer::GetUnoTunnelId() ))) : nullptr;
-}
-
 // XElementAccess
 sal_Bool SAL_CALL ConstItemContainer::hasElements()
 {
diff --git 

[Libreoffice-bugs] [Bug 39593] copy/paste code detector / fixing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39593

--- Comment #59 from Commit Notification 
 ---
Arkadiy Illarionov committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/60271c4433372097ef5ecc74e522532ebf5af8e0%5E%21

tdf#39593 Remove GetImplementation from ConstItemContainer and ItemContainer

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117787] strips of data bar merge into one block if values in adjacent cells are equal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117787

--- Comment #6 from Roman Kuznetsov <79045_79...@mail.ru> ---
still repro in

Version: 6.4.0.0.alpha0+ (x86)
Build ID: 99971d009e9c96d1d47aec14ecfbfeaa06dc140d
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-06-18_03:59:27
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sc/qa sc/source

[Mike Kaganski (via logerrit)]

 sc/qa/unit/pivottable_filters_test.cxx |   56 ++
 sc/source/filter/excel/xepivotxml.cxx  |   99 +++--
 2 files changed, 115 insertions(+), 40 deletions(-)

New commits:
commit acdc657d0c1f9d03c8162104f2d5ead37343f07f
Author: Mike Kaganski 
AuthorDate: Mon Apr 15 23:33:38 2019 +0300
Commit: Mike Kaganski 
CommitDate: Wed Jun 19 07:27:15 2019 +0200

tdf#124736: Sort group field items

Excel expects the group field items to be in ascending order starting
from "<01/02/2010", then "Jan", "Feb", ..., then end with ">01/02/2020".

Change-Id: I29e9b55f43091ed007f59e10dec64f46a37c7d5f
Reviewed-on: https://gerrit.libreoffice.org/70800
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 
Reviewed-on: https://gerrit.libreoffice.org/70815
Tested-by: Mike Kaganski 
Reviewed-on: https://gerrit.libreoffice.org/74329

diff --git a/sc/qa/unit/pivottable_filters_test.cxx 
b/sc/qa/unit/pivottable_filters_test.cxx
index 84ad5eade972..5f546875af94 100644
--- a/sc/qa/unit/pivottable_filters_test.cxx
+++ b/sc/qa/unit/pivottable_filters_test.cxx
@@ -90,6 +90,7 @@ public:
 void testTdf123923();
 void testTdf123939();
 void testTdf124651();
+void testTdf124736();
 
 CPPUNIT_TEST_SUITE(ScPivotTableFiltersTest);
 
@@ -134,6 +135,7 @@ public:
 CPPUNIT_TEST(testTdf123923);
 CPPUNIT_TEST(testTdf123939);
 CPPUNIT_TEST(testTdf124651);
+CPPUNIT_TEST(testTdf124736);
 
 CPPUNIT_TEST_SUITE_END();
 
@@ -2471,6 +2473,60 @@ void ScPivotTableFiltersTest::testTdf124651()
 assertXPath(pDoc, "/x:pivotTableDefinition/x:dataFields/x:dataField", 
"name", "");
 }
 
+void ScPivotTableFiltersTest::testTdf124736()
+{
+ScDocShellRef xDocSh = loadDoc("pivot-table/shared-dategroup.", 
FORMAT_XLSX);
+CPPUNIT_ASSERT(xDocSh.is());
+
+std::shared_ptr pXPathFile
+= ScBootstrapFixture::exportTo(xDocSh.get(), FORMAT_XLSX);
+xDocSh->DoClose();
+
+xmlDocPtr pTable = XPathHelper::parseExport(pXPathFile, m_xSFactory,
+
"xl/pivotCache/pivotCacheDefinition1.xml");
+CPPUNIT_ASSERT(pTable);
+
+assertXPath(pTable,
+
"/x:pivotCacheDefinition/x:cacheFields/x:cacheField[1]/x:fieldGroup/x:groupItems",
+"count", "45");
+// Group items must start with "<05/16/1958", then years sorted ascending, 
then ">06/11/2009"
+// They used to have years in the beginning, then "<05/16/1958", then 
">06/11/2009".
+// The "<" and ">" date strings are locale-dependent, so test depends on 
en_US locale
+assertXPath(
+pTable,
+
"/x:pivotCacheDefinition/x:cacheFields/x:cacheField[1]/x:fieldGroup/x:groupItems/x:s[1]",
+"v", "<05/16/1958");
+for (int i = 2; i <= 44; ++i)
+assertXPath(
+pTable,
+
"/x:pivotCacheDefinition/x:cacheFields/x:cacheField[1]/x:fieldGroup/x:groupItems/x:s["
++ OString::number(i) + "]",
+"v", OUString::number(1963 + i));
+assertXPath(
+pTable,
+
"/x:pivotCacheDefinition/x:cacheFields/x:cacheField[1]/x:fieldGroup/x:groupItems/x:s[45]",
+"v", ">06/11/2009");
+
+// Now check that table references these in correct order 
(document-dependent, so this is how
+// it should be in this specific testdoc which shows "<" and ">" values in 
the end)
+pTable = XPathHelper::parseExport(pXPathFile, m_xSFactory, 
"xl/pivotTables/pivotTable1.xml");
+CPPUNIT_ASSERT(pTable);
+assertXPath(pTable, 
"/x:pivotTableDefinition/x:pivotFields/x:pivotField[1]/x:items", "count",
+"46");
+const int vals[] = { 1,  2,  3,  4,  5,  6,  7,  8,  9,  10, 11, 12, 13, 
14, 15,
+ 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 
29, 30,
+ 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 
0,  44 };
+for (size_t i = 0; i < SAL_N_ELEMENTS(vals); ++i)
+{
+assertXPath(pTable,
+
"/x:pivotTableDefinition/x:pivotFields/x:pivotField[1]/x:items/x:item["
++ OString::number(i + 1) + "]",
+"x", OUString::number(vals[i]));
+}
+assertXPath(pTable, 
"/x:pivotTableDefinition/x:pivotFields/x:pivotField[1]/x:items/x:item[46]",
+"t", "default");
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(ScPivotTableFiltersTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sc/source/filter/excel/xepivotxml.cxx 
b/sc/source/filter/excel/xepivotxml.cxx
index e6af90295288..c1e46ef1c5ee 100644
--- a/sc/source/filter/excel/xepivotxml.cxx
+++ b/sc/source/filter/excel/xepivotxml.cxx
@@ -200,7 +200,42 @@ OUString GetExcelFormattedDate( double fSerialDateTime, 
const SvNumberFormatter&
 ::sax::Converter::convertDateTime(sBuf, aUDateTime, nullptr, true);
 return sBuf.makeStringAndClear();
 }
+
+// Excel seems to expect different order of group item values; we need to 
rearrange elements

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - sfx2/source

[Caolán McNamara (via logerrit)]

 sfx2/source/doc/objmisc.cxx |   13 +
 1 file changed, 13 insertions(+)

New commits:
commit aedf347ba9a494fa39a1f2fac96539585fc8bb44
Author: Caolán McNamara 
AuthorDate: Fri Jun 7 14:04:07 2019 +0100
Commit: Michael Weghorn 
CommitDate: Wed Jun 19 07:14:11 2019 +0200

explictly exclude LibreLogo from XScript usage

Change-Id: I567647f0e2f8b82e4ef2995c673abe82f4564228
Reviewed-on: https://gerrit.libreoffice.org/73659
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit cb0024e3668979dfdef44db5aa15ddfaf035e695)
Reviewed-on: https://gerrit.libreoffice.org/74289
Reviewed-by: Michael Weghorn 
Tested-by: Michael Weghorn 

diff --git a/sfx2/source/doc/objmisc.cxx b/sfx2/source/doc/objmisc.cxx
index 8bee369851ec..8594e9522e48 100644
--- a/sfx2/source/doc/objmisc.cxx
+++ b/sfx2/source/doc/objmisc.cxx
@@ -1346,6 +1346,16 @@ namespace
 }
 }
 
+namespace {
+
+// don't allow LibreLogo to be used with our mouseover/etc dom-alike events
+bool UnTrustedScript(const OUString& rScriptURL)
+{
+return 
rScriptURL.startsWithIgnoreAsciiCase("vnd.sun.star.script:LibreLogo");
+}
+
+}
+
 ErrCode SfxObjectShell::CallXScript( const Reference< XInterface >& 
_rxScriptContext, const OUString& _rScriptURL,
 const Sequence< Any >& aParams, Any& aRet, Sequence< sal_Int16 >& 
aOutParamIndex, Sequence< Any >& aOutParam, bool bRaiseError, const 
css::uno::Any* pCaller )
 {
@@ -1358,6 +1368,9 @@ ErrCode SfxObjectShell::CallXScript( const Reference< 
XInterface >& _rxScriptCon
 if ( bIsDocumentScript && !lcl_isScriptAccessAllowed_nothrow( 
_rxScriptContext ) )
 return ERRCODE_IO_ACCESSDENIED;
 
+if ( UnTrustedScript(_rScriptURL) )
+return ERRCODE_IO_ACCESSDENIED;
+
 bool bCaughtException = false;
 Any aException;
 try
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - librelogo/source

[László Németh (via logerrit)]

 librelogo/source/LibreLogo/LibreLogo.py |   51 +++-
 1 file changed, 50 insertions(+), 1 deletion(-)

New commits:
commit 6d0701eeb44e819113537e209c768dae55e910e2
Author: László Németh 
AuthorDate: Thu Jun 6 14:25:32 2019 +0200
Commit: Michael Weghorn 
CommitDate: Wed Jun 19 07:13:30 2019 +0200

sanitize LibreLogo calls

Change-Id: Ie4d9858e5b4b3e55ab08416fb9338d2df34ee5e1
Reviewed-on: https://gerrit.libreoffice.org/73627
Tested-by: Jenkins
Reviewed-by: László Németh 
(cherry picked from commit 1b63fa32bbd4a5b89d2ee3a53b28de4250c8dad3)
Reviewed-on: https://gerrit.libreoffice.org/74288
Reviewed-by: Michael Weghorn 
Tested-by: Michael Weghorn 

diff --git a/librelogo/source/LibreLogo/LibreLogo.py 
b/librelogo/source/LibreLogo/LibreLogo.py
index 57d385b41ca1..960d48a97e81 100644
--- a/librelogo/source/LibreLogo/LibreLogo.py
+++ b/librelogo/source/LibreLogo/LibreLogo.py
@@ -145,6 +145,7 @@ __LineStyle_DOTTED__ = 2
 class __Doc__:
 def __init__(self, doc):
 self.doc = doc
+self.secure = False
 try:
 self.drawpage = doc.DrawPage # Writer
 except:
@@ -463,10 +464,58 @@ class LogoProgram(threading.Thread):
 self.code = code
 threading.Thread.__init__(self)
 
+def secure(self):
+# 0 = secure
+if _.secure:
+return 0
+
+# 1 = forms, fields or embedded objects are forbidden
+if _.doc.DrawPage.Forms.getCount() > 0 or 
_.doc.getTextFields().createEnumeration().hasMoreElements() or 
_.doc.getEmbeddedObjects().getCount() > 0:
+return 1
+
+# 2 = hyperlinks with script events
+nodes = _.doc.Text.createEnumeration()
+while nodes.hasMoreElements():
+node = nodes.nextElement()
+if node.supportsService("com.sun.star.text.Paragraph"):
+portions = node.createEnumeration()
+while portions.hasMoreElements():
+portion = portions.nextElement()
+if 
portion.PropertySetInfo.hasPropertyByName("HyperLinkEvents"):
+events = portion.getPropertyValue("HyperLinkEvents")
+for event in events.getElementNames():
+attributes = events.getByName(event)
+for attribute in attributes:
+if attribute.Name == "EventType" and 
attribute.Value == "Script":
+return 2
+
+# 2 = images with script events
+images = _.doc.DrawPage.createEnumeration()
+while images.hasMoreElements():
+image = images.nextElement()
+try:
+events = image.Events
+for event in events.getElementNames():
+attributes = events.getByName(event)
+for attribute in attributes:
+if attribute.Name == "EventType" and attribute.Value 
== "Script":
+return 2
+except:
+pass
+
+_.secure = True
+return 0
+
 def run(self):
 global __thread__
 try:
-exec(self.code)
+# check document security
+secid = self.secure()
+if secid > 0:
+parent = _.doc.CurrentController.Frame.ContainerWindow
+MessageBox(parent, "Document objects with%s script events" % 
[" possible", ""][secid-1], "LibreLogo program can't start", "errorbox")
+else:
+exec(self.code)
 if _.origcursor[0] and _.origcursor[1]:
 __dispatcher__(".uno:Escape")
 try:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sc/inc sc/qa sc/source

[Mike Kaganski (via logerrit)]

 sc/inc/dputil.hxx  |2 
 sc/qa/unit/pivottable_filters_test.cxx |  167 +
 sc/source/core/data/dpobject.cxx   |5 
 sc/source/filter/excel/xepivotxml.cxx  |  120 ++-
 4 files changed, 208 insertions(+), 86 deletions(-)

New commits:
commit b4f61d5bb36130198a83a8cdcf060ebddea07b23
Author: Mike Kaganski 
AuthorDate: Fri Mar 22 14:06:19 2019 +0300
Commit: Mike Kaganski 
CommitDate: Wed Jun 19 07:09:02 2019 +0200

tdf#113908: Implement exporting pivot tables' groups fields to XSLX

Two tests in sc/qa/unit/pivottable_filters_test.cxx were extended
to also test round-trip of group fields in XLSX.

Change-Id: I70b7c15b09040c64fa1da2f88001af7ba16f2c6f
Reviewed-on: https://gerrit.libreoffice.org/69653
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 
Reviewed-on: https://gerrit.libreoffice.org/70687
Tested-by: Mike Kaganski 
Reviewed-on: https://gerrit.libreoffice.org/74328

diff --git a/sc/inc/dputil.hxx b/sc/inc/dputil.hxx
index b2539a159bce..735843b84578 100644
--- a/sc/inc/dputil.hxx
+++ b/sc/inc/dputil.hxx
@@ -33,7 +33,7 @@ public:
 
 SC_DLLPUBLIC static OUString createDuplicateDimensionName(const OUString& 
rOriginal, size_t nDupCount);
 
-static OUString getDateGroupName(
+SC_DLLPUBLIC static OUString getDateGroupName(
 sal_Int32 nDatePart, sal_Int32 nValue, SvNumberFormatter* pFormatter,
 double fStart, double fEnd);
 
diff --git a/sc/qa/unit/pivottable_filters_test.cxx 
b/sc/qa/unit/pivottable_filters_test.cxx
index 2c3448b78cfc..84ad5eade972 100644
--- a/sc/qa/unit/pivottable_filters_test.cxx
+++ b/sc/qa/unit/pivottable_filters_test.cxx
@@ -53,8 +53,8 @@ public:
 void testPivotTableSharedCacheGroupODS();
 void testGetPivotDataXLS();
 void testPivotTableSharedGroupXLSX();
-void testPivotTableSharedDateGroupXLSX();
-void testPivotTableSharedNestedDateGroupXLSX();
+void testPivotTableSharedDateGroupXLSX(); // + export
+void testPivotTableSharedNestedDateGroupXLSX(); // + export
 void testPivotTableSharedNumGroupXLSX();
 void testPivotTableNoColumnsLayout();
 void testTdf112501();
@@ -532,86 +532,99 @@ void 
ScPivotTableFiltersTest::testPivotTableSharedGroupXLSX()
 
 void ScPivotTableFiltersTest::testPivotTableSharedDateGroupXLSX()
 {
-ScDocShellRef xDocSh = loadDoc("pivot-table/shared-dategroup.", 
FORMAT_XLSX);
-CPPUNIT_ASSERT_MESSAGE("Failed to load file", xDocSh.is());
-ScDocument& rDoc = xDocSh->GetDocument();
-
-// Check whether right date labels are imported for both tables
-// First table
-CPPUNIT_ASSERT_EQUAL(OUString("a"), rDoc.GetString(ScAddress(0, 3, 1)));
-CPPUNIT_ASSERT_EQUAL(OUString("1965"), rDoc.GetString(ScAddress(0, 4, 1)));
-CPPUNIT_ASSERT_EQUAL(OUString("1989"), rDoc.GetString(ScAddress(0, 5, 1)));
-CPPUNIT_ASSERT_EQUAL(OUString("2000"), rDoc.GetString(ScAddress(0, 6, 1)));
-CPPUNIT_ASSERT_EQUAL(OUString("2004"), rDoc.GetString(ScAddress(0, 7, 1)));
-// TODO: check why this fails with 2005
-// CPPUNIT_ASSERT_EQUAL(OUString("2007"), 
rDoc.GetString(ScAddress(0,8,1)));
-
-// Second table
-CPPUNIT_ASSERT_EQUAL(OUString("a"), rDoc.GetString(ScAddress(5, 3, 1)));
-CPPUNIT_ASSERT_EQUAL(OUString("1965"), rDoc.GetString(ScAddress(5, 4, 1)));
-CPPUNIT_ASSERT_EQUAL(OUString("1989"), rDoc.GetString(ScAddress(5, 5, 1)));
-CPPUNIT_ASSERT_EQUAL(OUString("2000"), rDoc.GetString(ScAddress(5, 6, 1)));
-CPPUNIT_ASSERT_EQUAL(OUString("2004"), rDoc.GetString(ScAddress(5, 7, 1)));
-// TODO: check why this fails with 2005
-// CPPUNIT_ASSERT_EQUAL(OUString("2007"), 
rDoc.GetString(ScAddress(5,8,1)));
-
-// There should be exactly 2 pivot tables and 1 cache.
-ScDPCollection* pDPs = rDoc.GetDPCollection();
-CPPUNIT_ASSERT_EQUAL(static_cast(2), pDPs->GetCount());
-
-ScDPCollection::SheetCaches& rSheetCaches = pDPs->GetSheetCaches();
-CPPUNIT_ASSERT_EQUAL(static_cast(1), rSheetCaches.size());
-
-const ScDPCache* pCache = rSheetCaches.getExistingCache(ScRange(0, 0, 0, 
9, 24, 0));
-CPPUNIT_ASSERT_MESSAGE("Pivot cache is expected for A1:J25 on the first 
sheet.", pCache);
-CPPUNIT_ASSERT_EQUAL(static_cast(10), pCache->GetFieldCount());
-
-xDocSh->DoClose();
+auto testThis = [](ScDocShellRef& xDocSh) {
+CPPUNIT_ASSERT_MESSAGE("Failed to load file", xDocSh.is());
+ScDocument& rDoc = xDocSh->GetDocument();
+
+// Check whether right date labels are imported for both tables
+// First table
+CPPUNIT_ASSERT_EQUAL(OUString("a"), rDoc.GetString(ScAddress(0, 3, 
1)));
+CPPUNIT_ASSERT_EQUAL(OUString("1965"), rDoc.GetString(ScAddress(0, 4, 
1)));
+CPPUNIT_ASSERT_EQUAL(OUString("1989"), rDoc.GetString(ScAddress(0, 5, 
1)));
+CPPUNIT_ASSERT_EQUAL(OUString("2000"), rDoc.GetString(ScAddress(0, 6, 
1)));
+CPPUNIT_ASSERT_EQUAL(OUString("2004"), 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sc/qa sc/source

[Mike Kaganski (via logerrit)]

 sc/qa/unit/data/ods/tdf124651_simplePivotTable.ods |binary
 sc/qa/unit/pivottable_filters_test.cxx |   15 +++
 sc/source/filter/excel/xepivotxml.cxx  |7 +--
 3 files changed, 20 insertions(+), 2 deletions(-)

New commits:
commit 8c800d3cc9541a28e665707bda0bf68d81a3269b
Author: Mike Kaganski 
AuthorDate: Wed Apr 10 15:18:07 2019 +0300
Commit: Mike Kaganski 
CommitDate: Wed Jun 19 07:08:45 2019 +0200

tdf#124651: always write "name" attribute to dataField element

Despite being optional as per ECMA-376-1:2016, Excel 2016 seems to
require the presence of "name" attribute in dataField element of
pivot table definition, so make sure to write at least empty string
there.

Change-Id: Iaab5674f86b7dd0b267776678e11af47086635d7
Reviewed-on: https://gerrit.libreoffice.org/70522
Reviewed-by: Mike Kaganski 
Tested-by: Mike Kaganski 
Reviewed-on: https://gerrit.libreoffice.org/74327

diff --git a/sc/qa/unit/data/ods/tdf124651_simplePivotTable.ods 
b/sc/qa/unit/data/ods/tdf124651_simplePivotTable.ods
new file mode 100644
index ..05fd5fec838f
Binary files /dev/null and b/sc/qa/unit/data/ods/tdf124651_simplePivotTable.ods 
differ
diff --git a/sc/qa/unit/pivottable_filters_test.cxx 
b/sc/qa/unit/pivottable_filters_test.cxx
index a476e0d7b450..2c3448b78cfc 100644
--- a/sc/qa/unit/pivottable_filters_test.cxx
+++ b/sc/qa/unit/pivottable_filters_test.cxx
@@ -89,6 +89,7 @@ public:
 void testTdf112106();
 void testTdf123923();
 void testTdf123939();
+void testTdf124651();
 
 CPPUNIT_TEST_SUITE(ScPivotTableFiltersTest);
 
@@ -132,6 +133,7 @@ public:
 CPPUNIT_TEST(testTdf112106);
 CPPUNIT_TEST(testTdf123923);
 CPPUNIT_TEST(testTdf123939);
+CPPUNIT_TEST(testTdf124651);
 
 CPPUNIT_TEST_SUITE_END();
 
@@ -2443,6 +2445,19 @@ void ScPivotTableFiltersTest::testTdf123939()
 "containsMixedTypes", "1");
 }
 
+void ScPivotTableFiltersTest::testTdf124651()
+{
+ScDocShellRef xDocSh = loadDoc("tdf124651_simplePivotTable.", FORMAT_ODS);
+CPPUNIT_ASSERT(xDocSh.is());
+
+xmlDocPtr pDoc = XPathHelper::parseExport2(*this, *xDocSh, m_xSFactory,
+"xl/pivotTables/pivotTable1.xml", FORMAT_XLSX);
+CPPUNIT_ASSERT(pDoc);
+// We have to export name attribute, even though it's optional according 
to ECMA-376 standard,
+// because Excel (at least 2016) seems to require it.
+assertXPath(pDoc, "/x:pivotTableDefinition/x:dataFields/x:dataField", 
"name", "");
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(ScPivotTableFiltersTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sc/source/filter/excel/xepivotxml.cxx 
b/sc/source/filter/excel/xepivotxml.cxx
index 41fa2161f9c2..5538bd8770b1 100644
--- a/sc/source/filter/excel/xepivotxml.cxx
+++ b/sc/source/filter/excel/xepivotxml.cxx
@@ -968,9 +968,12 @@ void XclExpXmlPivotTables::SavePivotTableXml( 
XclExpXmlStream& rStrm, const ScDP
 assert(aCachedDims[nDimIdx]); // the loop above should have 
screened for NULL's.
 const ScDPSaveDimension& rDim = *it->mpDim;
 const boost::optional & pName = rDim.GetLayoutName();
+// tdf#124651: despite being optional in CT_DataField according to 
ECMA-376 Part 1,
+// Excel (at least 2016) seems to insist on the presence of "name" 
attribute in
+// dataField element, even if empty
+const OString sName = pName ? pName->toUtf8() : "";
 pPivotStrm->write("<")->writeId(XML_dataField);
-if (pName)
-rStrm.WriteAttributes(XML_name, 
XclXmlUtils::ToOString(*pName), FSEND);
+rStrm.WriteAttributes(XML_name, sName, FSEND);
 
 rStrm.WriteAttributes(XML_fld, OString::number(nDimIdx).getStr(), 
FSEND);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125682] Wrong calculation number of pages(field NUMPAGES) if page numbering(field PAGE) starts from EVEN number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125682

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124763] unable to open *any* document if path includes %xx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124763

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|QA:needsComment |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125954] Form wizard creates separate form controls inside a tablecontrol

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125954

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125693] Print dialogue lacks english

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125693

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125988] Menubar is broken after open a DOC file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125988

--- Comment #4 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125562] LibreOffice fonts aren't installed with LibreOffice 6.2.4.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125562

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125317] LO Viewer for Android is not recognized as able to open .odt files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125317

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117587] Ordinal/cardinal numbering: preview is shown in program locale language, not in language of selected text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117587

--- Comment #3 from QA Administrators  ---
Dear Mike Kaganski,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100894] FILEOPEN FILESAVE IMPORT Conditional formatting: xls file with a lot of Conditional formatting freeze Calc when opening Styles sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100894

--- Comment #17 from QA Administrators  ---
Dear Maxim Britov,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113755] Crash in: SfxSlotPool::GetSlotPool(SfxViewFrame *) from 5.4.0, even 5.3.6 in Windows (no steps)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113755

--- Comment #25 from QA Administrators  ---
Dear m.a.riosv,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125988] Menubar is broken after open a DOC file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125988

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109852] CRASH: When creating more than 85 Writer/Calc documents with x86 and x64 build

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109852

--- Comment #8 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121503] L.O. Calc may not be setting Landscape mode properly,

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121503

--- Comment #3 from QA Administrators  ---
Dear Dick Johnson,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121955] No menubar in libreoffice windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121955

--- Comment #3 from QA Administrators  ---
Dear Jan Drouaud,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108153] Crash in: OpenGLSalGraphicsImpl::doFlush()

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108153

--- Comment #7 from QA Administrators  ---
Dear daniel,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121503] L.O. Calc may not be setting Landscape mode properly,

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121503

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121467] font colour cannot be changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121467

--- Comment #3 from QA Administrators  ---
Dear pinakid3,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121467] font colour cannot be changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121467

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111187] CRASH: Crash clicking somewhere in the sheet after adding a textbox with zero undo steps

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87

--- Comment #5 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117782] Noticeable lag when re-arranging sheets (for a specific sheet)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117782

--- Comment #2 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101682] Sluggishness, freezing and crashes experienced upon insertion of (many?) compressed SVG (svgz) graphics

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101682

--- Comment #5 from QA Administrators  ---
Dear Daniel Grigoras,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117744] Insane amount of stuff going on while user doing nothing in the Character dialog (both Linux and macOS at least)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117744

--- Comment #6 from QA Administrators  ---
Dear Tor Lillqvist,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51806] Chart in XLS spreadsheet not importing (import from XLSX works)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=51806

--- Comment #8 from QA Administrators  ---
Dear skiani,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51644] FORMATTING: text animation suddenly not possible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=51644

--- Comment #11 from QA Administrators  ---
Dear bugquestcontri,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118225] LibreOffice Writer: Heading Style Indenting Keeps Defaulting To 0.76cm

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118225

--- Comment #6 from QA Administrators  ---
Dear librelibre,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106730] Searching for Character Formatting is Broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106730

--- Comment #10 from QA Administrators  ---
Dear vermontpoet,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79138] Calc crash on large selection Delete

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=79138

--- Comment #14 from QA Administrators  ---
Dear Luuk,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107651] VIEWING: Mouse wheel doesn't scroll one screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107651

--- Comment #8 from QA Administrators  ---
Dear q21,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117787] strips of data bar merge into one block if values in adjacent cells are equal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117787

--- Comment #5 from QA Administrators  ---
Dear kompilainenn,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116039] Resizing Report navigator dialog repaints new area in black

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116039

--- Comment #23 from QA Administrators  ---
Dear Howard Johnson,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89573] Can not type non-breaking space into Find & Replace dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89573

--- Comment #8 from QA Administrators  ---
Dear Jim Avera,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108976] Crash in: OutputDevice::GetOutputSizePixel()

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108976

--- Comment #5 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89471] FILEOPEN pdf: When opening a PDF with RTL language text in Draw, text gets mirrored

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89471

--- Comment #23 from V Stuart Foote  ---
(In reply to Eyal Rozenberg from comment #21)
> Oh, no no no!
> 
> We seem to have a huge misunderstanding with respect to this bug.
> 
Eyal, *

I will state again and quite clearly--LibreOffice is _NOT_ a PDF editor!

We can read it as a source document, opening into Writer, Impress, Calc, or
Draw. We can filter export to PDF from any document--but that would
overwrite/replace any source PDF, and only as os/DE allows.

We do not edit the PDF stream

We do not edit any of the PDF objects

ALL we do is read and filter import the PDF stream. 

We do not write back to the original source document and must swap in a
reconstructed PDF stream with any changes.

Either of our two import filters: pdfium based or poppler based keeps a copy of
the PDF source file, but always covert its contents for manipulation on the
LibreOffice canvas. We do not work directly on the "original" we do not "edit"
it!

That said, in practice the Poppler based import filter parses the object
streams from PDF and converts them into corresponding LibreOffice Draw
objects--Text boxes, Shapes, meta images, etc. Fidelity between the original
PDF objects and the import filter result varies depending on the object type
and if corresponding Draw object supports an attribute--clipping masks for
example (bug 86211).

The pdfium base import filter is configured to render content of the PDF as a
bitmap image with high fidelity to the document layout published in the PDF.
Currently it only handles the first page of a PDF 'inserted as image', with the
bitmap resolution set at just 96 dpi.

The issue here is that on filter import of the PDF--the object stream holding
text runs is added to a Draw text box. Withing the source PDF, some original
text will be broken into multiple text runs in multiple text objects.  

The text stream is sequenced as entered RTL, but as filter import is written
out to the Text box the run is written LTR--with no handling of the text run of
glyphs as RTL, or IIRC for more complex composite scripts.

LibreOffice uses extensively the ICU project
(https://en.wikipedia.org/wiki/International_Components_for_Unicode) for script
recognition and transliteration. But would seem text runs for non-western
scripts are not being supported--and we may not be using the ICU Unicode text
handling that is needed.

You'll note the pdfium filter (bug 89727) correctly handles the Hebrew and
Arabic text of the sample documents attached here.  But less you think that is
the solution for better fidelity and potential for "editing" PDF, like the
poppler based import filter, selecting the graphic object and 'breaking' out
its PDF stream objects results are not well rendered to document canvas--either
losing the Unicode glyph, or getting incorrect font fallback (or a mix).

As Khaled said--PDF is not a format intended to be edited. And, LibreOffice is
not a PDF editor. But we are mishandling RTL text runs and that needs to be
investigated.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sw/qa

[Mike Kaganski (via logerrit)]

 sw/qa/extras/ooxmlexport/ooxmlexport9.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 9bf161ea08e7432dcfb76feda4e57bebf91f8cf4
Author: Mike Kaganski 
AuthorDate: Thu Apr 11 23:35:13 2019 +0300
Commit: Mike Kaganski 
CommitDate: Wed Jun 19 04:16:11 2019 +0200

f315fee54eee57e6e55e5fcacf2522534682c2ce follow-up: fix tdf#109310 unit test

The test should guarantee presense of w:val attribute of w:rStyle element.
Turns out we must not use w: namespace before attribute name; likely it
is true when attribute namespace is the same as of its element.

Change-Id: I28e2936b51f039473326c6debf4b5559e2baf24c
Reviewed-on: https://gerrit.libreoffice.org/70612
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 
(cherry picked from commit 735964c39097ff952fcaffee6b35c79e210c019c)
Reviewed-on: https://gerrit.libreoffice.org/74326
Tested-by: Mike Kaganski 

diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
index 4a3b1a0c412d..a44c8f78d9cf 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
@@ -488,7 +488,9 @@ DECLARE_OOXMLEXPORT_TEST(testTdf109310_endnoteStyleForMSO, 
"tdf109310_endnoteSty
 xmlDocPtr pXmlDoc = parseExport("word/endnotes.xml");
 if (!pXmlDoc)
 return;
-//assertXPath(pXmlDoc, 
"/w:endnotes/w:endnote[@w:id='2']/w:p/w:r[1]/w:rPr/w:rStyle", "w:val"); // what 
does it test?
+// Check w:rStyle element has w:val attribute - note that w: is not 
specified for attribute
+assertXPath(pXmlDoc, 
"/w:endnotes/w:endnote[@w:id='2']/w:p/w:r[1]/w:rPr/w:rStyle", "val",
+"EndnoteCharacters");
 }
 
 DECLARE_OOXMLEXPORT_TEST(testTdf103389, "tdf103389.docx")
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116010] Overlapping text with substitution font - ligature handling bug

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116010

--- Comment #8 from Khaled Hosny  ---
I can't reproduce any of the issues described here with 6.2.4.2, do anyone else
still reproduce?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sc/uiconfig sd/uiconfig sw/uiconfig

[Roman Kuznetsov (via logerrit)]

 sc/uiconfig/scalc/toolbar/formcontrols.xml|4 ++--
 sd/uiconfig/sdraw/toolbar/formcontrols.xml|4 ++--
 sd/uiconfig/simpress/toolbar/formcontrols.xml |4 ++--
 sw/uiconfig/sglobal/toolbar/formcontrols.xml  |4 ++--
 sw/uiconfig/sweb/toolbar/formcontrols.xml |4 ++--
 sw/uiconfig/swform/toolbar/formcontrols.xml   |4 ++--
 sw/uiconfig/swreport/toolbar/formcontrols.xml |4 ++--
 sw/uiconfig/swriter/toolbar/formcontrols.xml  |4 ++--
 sw/uiconfig/swxform/toolbar/formcontrols.xml  |4 ++--
 9 files changed, 18 insertions(+), 18 deletions(-)

New commits:
commit 099d183410eb7b0dbede3db70966d54a41a971d7
Author: Roman Kuznetsov 
AuthorDate: Mon Jun 17 19:51:30 2019 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Wed Jun 19 03:24:10 2019 +0200

tdf#125947 Two tools are missing from default Form Controls toolbar

Change-Id: Ie54b2a3f5051b115f8f04467282090a93525dfc3
Reviewed-on: https://gerrit.libreoffice.org/74191
Tested-by: Jenkins
Reviewed-by: Roman Kuznetsov 
(cherry picked from commit 385128671716e70b9540a67e213d6495bf50662b)
Reviewed-on: https://gerrit.libreoffice.org/74267
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sc/uiconfig/scalc/toolbar/formcontrols.xml 
b/sc/uiconfig/scalc/toolbar/formcontrols.xml
index f0b133503d4d..bd4c0d22ea36 100644
--- a/sc/uiconfig/scalc/toolbar/formcontrols.xml
+++ b/sc/uiconfig/scalc/toolbar/formcontrols.xml
@@ -53,6 +53,6 @@
  
  
  
- 
- 
+ 
+ 
 
diff --git a/sd/uiconfig/sdraw/toolbar/formcontrols.xml 
b/sd/uiconfig/sdraw/toolbar/formcontrols.xml
index f0b133503d4d..bd4c0d22ea36 100644
--- a/sd/uiconfig/sdraw/toolbar/formcontrols.xml
+++ b/sd/uiconfig/sdraw/toolbar/formcontrols.xml
@@ -53,6 +53,6 @@
  
  
  
- 
- 
+ 
+ 
 
diff --git a/sd/uiconfig/simpress/toolbar/formcontrols.xml 
b/sd/uiconfig/simpress/toolbar/formcontrols.xml
index f0b133503d4d..bd4c0d22ea36 100644
--- a/sd/uiconfig/simpress/toolbar/formcontrols.xml
+++ b/sd/uiconfig/simpress/toolbar/formcontrols.xml
@@ -53,6 +53,6 @@
  
  
  
- 
- 
+ 
+ 
 
diff --git a/sw/uiconfig/sglobal/toolbar/formcontrols.xml 
b/sw/uiconfig/sglobal/toolbar/formcontrols.xml
index f0b133503d4d..bd4c0d22ea36 100644
--- a/sw/uiconfig/sglobal/toolbar/formcontrols.xml
+++ b/sw/uiconfig/sglobal/toolbar/formcontrols.xml
@@ -53,6 +53,6 @@
  
  
  
- 
- 
+ 
+ 
 
diff --git a/sw/uiconfig/sweb/toolbar/formcontrols.xml 
b/sw/uiconfig/sweb/toolbar/formcontrols.xml
index f0b133503d4d..bd4c0d22ea36 100644
--- a/sw/uiconfig/sweb/toolbar/formcontrols.xml
+++ b/sw/uiconfig/sweb/toolbar/formcontrols.xml
@@ -53,6 +53,6 @@
  
  
  
- 
- 
+ 
+ 
 
diff --git a/sw/uiconfig/swform/toolbar/formcontrols.xml 
b/sw/uiconfig/swform/toolbar/formcontrols.xml
index f0b133503d4d..bd4c0d22ea36 100644
--- a/sw/uiconfig/swform/toolbar/formcontrols.xml
+++ b/sw/uiconfig/swform/toolbar/formcontrols.xml
@@ -53,6 +53,6 @@
  
  
  
- 
- 
+ 
+ 
 
diff --git a/sw/uiconfig/swreport/toolbar/formcontrols.xml 
b/sw/uiconfig/swreport/toolbar/formcontrols.xml
index f0b133503d4d..bd4c0d22ea36 100644
--- a/sw/uiconfig/swreport/toolbar/formcontrols.xml
+++ b/sw/uiconfig/swreport/toolbar/formcontrols.xml
@@ -53,6 +53,6 @@
  
  
  
- 
- 
+ 
+ 
 
diff --git a/sw/uiconfig/swriter/toolbar/formcontrols.xml 
b/sw/uiconfig/swriter/toolbar/formcontrols.xml
index f0b133503d4d..bd4c0d22ea36 100644
--- a/sw/uiconfig/swriter/toolbar/formcontrols.xml
+++ b/sw/uiconfig/swriter/toolbar/formcontrols.xml
@@ -53,6 +53,6 @@
  
  
  
- 
- 
+ 
+ 
 
diff --git a/sw/uiconfig/swxform/toolbar/formcontrols.xml 
b/sw/uiconfig/swxform/toolbar/formcontrols.xml
index f0b133503d4d..bd4c0d22ea36 100644
--- a/sw/uiconfig/swxform/toolbar/formcontrols.xml
+++ b/sw/uiconfig/swxform/toolbar/formcontrols.xml
@@ -53,6 +53,6 @@
  
  
  
- 
- 
+ 
+ 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125988] Menubar is broken after open a DOC file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125988

--- Comment #3 from Volga  ---
Created attachment 152283
  --> https://bugs.documentfoundation.org/attachment.cgi?id=152283=edit
Test file

File from the original source

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125988] Menubar is broken after open a DOC file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125988

Volga  changed:

   What|Removed |Added

   Hardware|All |x86-64 (AMD64)
 OS|All |Windows (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125975] which version is it?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125975

tor...@yahoo.com changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|NEEDINFO|RESOLVED

--- Comment #4 from tor...@yahoo.com ---
So, Alpha replaced the installed release, Beta does not.
I did not know that. TY.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125926] KDE5 VCL uses unnecessarily bold fonts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125926

--- Comment #9 from Ongun Kanat  ---
I have it tested with the latest non-debug daily build. It is the same.

Version: 6.4.0.0.alpha0+
Build ID: f75c2b04785aa05cff3bcd52689feb7400a14e8e
CPU threads: 8; OS: Linux 5.1; UI render: default; VCL: kde5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2019-06-15_11:49:26
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125673] KDE5: Calc sheet tab's context menu has unexpected highlighting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125673

--- Comment #16 from Ongun Kanat  ---
(In reply to Ongun Kanat from comment #15)
> Created attachment 152282 [details]
> Video showing slow highlighting.
> 
> (In reply to Michael Weghorn from comment #13)
> > (In reply to Ongun Kanat from comment #12)
> > > I tested the build below today:
> > > 
> > > Version: 6.4.0.0.alpha0+
> > > Build ID: b674d3c12a5819fbcb551e83bf6862afc85ef7f3
> > > CPU threads: 8; OS: Linux 5.1; UI render: default; VCL: kde5; 
> > > TinderBox: Linux-rpm_deb-x86_64@86-TDF-dbg, Branch:master, Time:
> > > 2019-06-15_21:06:59
> > > Locale: en-US (en_US.UTF-8); UI-Language: en-US
> > > Calc: threaded
> > > 
> > > The highlighting is solved but it is really slow.
> > 
> > Since debug builds are always slower: Can you retest with a release (i.e.
> > non-debug) build? I've updated [1] to mention how to extract debs without
> > 'dpkg-deb', so this will hopefully work for you on Arch as well.
> > 
> > [1]
> > https://wiki.documentfoundation.org/Installing_in_parallel/Linux#Step_3:
> > _Tweaking_the_Install_Destination
> 
> 
> It is still slow. Highlighting happens instantly on other Qt / GTK programs.


Version: 6.4.0.0.alpha0+
Build ID: f75c2b04785aa05cff3bcd52689feb7400a14e8e
CPU threads: 8; OS: Linux 5.1; UI render: default; VCL: kde5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2019-06-15_11:49:26
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125673] KDE5: Calc sheet tab's context menu has unexpected highlighting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125673

--- Comment #15 from Ongun Kanat  ---
Created attachment 152282
  --> https://bugs.documentfoundation.org/attachment.cgi?id=152282=edit
Video showing slow highlighting.

(In reply to Michael Weghorn from comment #13)
> (In reply to Ongun Kanat from comment #12)
> > I tested the build below today:
> > 
> > Version: 6.4.0.0.alpha0+
> > Build ID: b674d3c12a5819fbcb551e83bf6862afc85ef7f3
> > CPU threads: 8; OS: Linux 5.1; UI render: default; VCL: kde5; 
> > TinderBox: Linux-rpm_deb-x86_64@86-TDF-dbg, Branch:master, Time:
> > 2019-06-15_21:06:59
> > Locale: en-US (en_US.UTF-8); UI-Language: en-US
> > Calc: threaded
> > 
> > The highlighting is solved but it is really slow.
> 
> Since debug builds are always slower: Can you retest with a release (i.e.
> non-debug) build? I've updated [1] to mention how to extract debs without
> 'dpkg-deb', so this will hopefully work for you on Arch as well.
> 
> [1]
> https://wiki.documentfoundation.org/Installing_in_parallel/Linux#Step_3:
> _Tweaking_the_Install_Destination


It is still slow. Highlighting happens instantly on other Qt / GTK programs.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125999] New: Add button name to extended tooltips

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125999

Bug ID: 125999
   Summary: Add button name to extended tooltips
   Product: LibreOffice
   Version: 6.0.7.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ulf.zi...@gmx.de

Description:
In normal mode on hovering over a button, I see the name of the button, e.g.
"Align left".
With extended tooltips enabled I don't see this any more, but a longer
description.
I think it would be better to see both then, i.e. the button name in the first
line and the longer description in the following lines.

This will help to better refer to a certain functionality, e.g. in help
questions.

Steps to Reproduce:
1. Hover over a button, field or checkbox option.


Actual Results:
In normal mode on hovering, I see the name of the button, e.g. "Align left".
With extended tooltips enabled I don't see this any more, but a longer
description.

Expected Results:
I think it would be better to see both then, i.e. the button name in the first
line and the longer description in the following lines.


Reproducible: Always


User Profile Reset: No



Additional Info:
This will help to better refer to a particular functionality, e.g. in help
questions.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89471] FILEOPEN pdf: When opening a PDF with RTL language text in Draw, text gets mirrored

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89471

--- Comment #22 from Eyal Rozenberg  ---
(In reply to Khaled Hosny from comment #19)
> My own recommendation is to not try to edit PDFs in LibreOffice, PDF is not
> an editable format (despite what some tools would lead you to believe), and
> what you get is just some complex hacks. Making PDF editable in LibreOffice
> was a misguided mistake to begin with, and if it were for me I'd just
> deprecate and eventually remove support for it.

With respect - this is an irrelevant recommendation. People edit PDFs exactly
because they don't have access to the source files with which they were
generated; or because they want to be certain they begin editing in the
absolute final typeset form of a document.

PDFs are pretty editable. There are PDF editors, which work. Inkscape works.
Adobe Acrobat (the full suite) works. They may work in the somewhat handicapped
fashion I described above (not sure about the full Acrobat) - but they are
quite useful. But I want LibreOffice draw functionality for these PDFs! and
when this bug is fixed I can have it. Mostly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Gsoc

[srinivasan r]

Hi my name is srinivasan and i interested in gsoc so i like to contribute
to your organisation and i literally don't know any about the process to
join and i know c ,c++ learning python so if you people help to guide
through the process and how it works it would be great
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

UNO connection problems (GSOC Report Week 3)

[Rasmus Jonsson]

So last week (until June 16th) I ran into issues with integrating my
program with LibreOffice using UNO. The goal is to start LibreOffice
Impress, connect to it (initially using the Impress Remote Protocol, but
it was decided that UNO would be more suitable), and open/ play/ control
slideshows this way.

Below is some information on what was done.

LibreOffice was started thus,

soffice --impress "--accept=socket,host=localhost,port=2002;urp;"

or thus,

soffice --impress "--accept=pipe,name=hello;urp;"

My mentor was able to run the following script and successfully connect
to LibreOffice,

http://paste.debian.net/1088385/

However, when I ran the same script `python3 myscript.py` I got this,

http://paste.debian.net/1088386/

My mentor advised to run `make UITest_demo_ui` which ran fine, but
`make UITest` failed with the same error as above,

http://paste.debian.net/hidden/ca319a53/

Would be great if anyone had any advice on how to solve this. 

rasmus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 89471] FILEOPEN pdf: When opening a PDF with RTL language text in Draw, text gets mirrored

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89471

--- Comment #21 from Eyal Rozenberg  ---
(In reply to Khaled Hosny from comment #18)
> PDF outputs glyphs in visual order, so the original (logical) order of the
> text is lost, so the reverse of the bidi algorithm needs to be applied to
> the text extracted from the PDF, but there is no reliable or documented
> algorithm to do this.

Oh, no no no!

We seem to have a huge misunderstanding with respect to this bug.

Stuart, Khaled - the bug is not about how the original text order
reconstruction is failing for RTL. The bug is that it is _performed_ at all.
Basically, nothing in the PDF should be touched when we open it in Draw, unless
the user actively change it. If I open a PDF file in Draw, then save it - I
should get a PDF with essentially the same thing that came in. Only if I modify
a specific frame/box/object within the PDF is Draw allowed to do any of this
reconstruction stuff. If I touch something and the RTL text gets flipped or
messed up due to my edit - that's sad, but it's not terrible. I can either
not-touch it, or replace it (but just it) with newly-written text.

Now, I agree that proper reconstruction of RTL text runs from arbitrary PDFs is
difficult and challenging; but that would be a request of an interesting future
feature, not a bug report.

(PS - If LO Draw could write meta-data/hints regarding the correct logical
order, it could at least do perfect reconstruction for those files. But that
too is a feature request and doesn't belong in this bug.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125998] Conditional formatting not applying condition correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125998

--- Comment #1 from juan_velasquez...@hotmail.com ---
Created attachment 152281
  --> https://bugs.documentfoundation.org/attachment.cgi?id=152281=edit
File with the bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125998] New: Conditional formatting not applying condition correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125998

Bug ID: 125998
   Summary: Conditional formatting not applying condition
correctly
   Product: LibreOffice
   Version: 6.2.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: juan_velasquez...@hotmail.com

Description:
Libreoffice calc is not applying correct formatting in some ranges. In the
attached .ods file the columns U and W should apply warning format when the
cell's value is different to another column but the cell gets formatted even
when the values are the same.

Actual Results:
The format is applied when the condition is not satisfied.

Expected Results:
The format should be applied only when the condition is satisfied.


Reproducible: Couldn't Reproduce


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - icon-themes/colibre icon-themes/colibre_svg icon-themes/elementary icon-themes/elementary_svg icon-themes/karasa_jaga icon-themes/karasa_jaga

[rizmut (via logerrit)]

 dev/null|binary
 icon-themes/colibre/cmd/32/hideallnotes.png |binary
 icon-themes/colibre/cmd/32/hidenote.png |binary
 icon-themes/colibre/cmd/32/showannotations.png  |binary
 icon-themes/colibre/cmd/32/shownote.png |binary
 icon-themes/colibre/cmd/lc_hidenote.png |binary
 icon-themes/colibre/cmd/lc_showannotations.png  |binary
 icon-themes/colibre/cmd/sc_showannotations.png  |binary
 icon-themes/colibre/links.txt   |   20 
 icon-themes/colibre_svg/cmd/32/hideallnotes.svg |1 
 icon-themes/colibre_svg/cmd/32/hidenote.svg |1 
 icon-themes/colibre_svg/cmd/32/showannotations.svg  |2 
 icon-themes/colibre_svg/cmd/32/shownote.svg |1 
 icon-themes/colibre_svg/cmd/lc_hidenote.svg |2 
 icon-themes/colibre_svg/cmd/lc_showallnotes.svg |1 
 icon-themes/colibre_svg/cmd/lc_showannotations.svg  |2 
 icon-themes/colibre_svg/cmd/sc_showallnotes.svg |1 
 icon-themes/colibre_svg/cmd/sc_showannotations.svg  |2 
 icon-themes/colibre_svg/cmd/sc_switchcontroldesignmode.svg  |3 -
 icon-themes/colibre_svg/svx/res/markers.svg |2 
 icon-themes/elementary/cmd/32/smallcaps.png |binary
 icon-themes/elementary/cmd/32/zoomnext.png  |binary
 icon-themes/elementary/cmd/32/zoompage.png  |binary
 icon-themes/elementary/cmd/32/zoompanning.png   |binary
 icon-themes/elementary/cmd/32/zoomprevious.png  |binary
 icon-themes/elementary/cmd/lc_insertpagenumberfield.png |binary
 icon-themes/elementary/cmd/lc_patternfield.png  |binary
 icon-themes/elementary/cmd/lc_smallcaps.png |binary
 icon-themes/elementary/cmd/lc_zoomnext.png  |binary
 icon-themes/elementary/cmd/lc_zoomobjects.png   |binary
 icon-themes/elementary/cmd/lc_zoompage.png  |binary
 icon-themes/elementary/cmd/lc_zoomprevious.png  |binary
 icon-themes/elementary/cmd/sc_smallcaps.png |binary
 icon-themes/elementary/cmd/sc_zoomobjects.png   |binary
 icon-themes/elementary/links.txt|   28 ++--
 icon-themes/elementary_svg/cmd/32/smallcaps.svg |2 
 icon-themes/elementary_svg/cmd/32/zoomnext.svg  |2 
 icon-themes/elementary_svg/cmd/32/zoompage.svg  |2 
 icon-themes/elementary_svg/cmd/32/zoompanning.svg   |2 
 icon-themes/elementary_svg/cmd/32/zoomprevious.svg  |2 
 icon-themes/elementary_svg/cmd/lc_insertpagenumberfield.svg |2 
 icon-themes/elementary_svg/cmd/lc_patternfield.svg  |2 
 icon-themes/elementary_svg/cmd/lc_smallcaps.svg |2 
 icon-themes/elementary_svg/cmd/lc_zoomnext.svg  |2 
 icon-themes/elementary_svg/cmd/lc_zoomobjects.svg   |2 
 icon-themes/elementary_svg/cmd/lc_zoompage.svg  |2 
 icon-themes/elementary_svg/cmd/lc_zoomprevious.svg  |2 
 icon-themes/elementary_svg/cmd/sc_smallcaps.svg |2 
 icon-themes/elementary_svg/cmd/sc_zoomobjects.svg   |2 
 icon-themes/elementary_svg/svx/res/markers.svg  |2 
 icon-themes/karasa_jaga/links.txt   |   22 -
 51 files changed, 60 insertions(+), 58 deletions(-)

New commits:
commit 38f79ddf341c35d654e6156a241ddacc5927b444
Author: rizmut 
AuthorDate: Wed Jun 19 00:38:26 2019 +0700
Commit: Rizal Muttaqin 
CommitDate: Tue Jun 18 23:52:29 2019 +0200

Colibre, elementary, KJ: Fix for tdf#107144

elementary:
- Fix blurred zoom icons
- Reverse top arrow on Small Capitals icons

Change-Id: I81883334e5cfaf3dab528ed61ea46894017a6c36
Reviewed-on: https://gerrit.libreoffice.org/74301
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin 
(cherry picked from commit 11a1bdc5fa0312111ddf9c1b7779a114b97e361c)
Reviewed-on: https://gerrit.libreoffice.org/74317
Tested-by: Rizal Muttaqin 

diff --git a/icon-themes/colibre/cmd/32/hideallnotes.png 
b/icon-themes/colibre/cmd/32/hideallnotes.png
new file mode 100644
index ..077b168603e9
Binary files /dev/null and b/icon-themes/colibre/cmd/32/hideallnotes.png differ
diff --git a/icon-themes/colibre/cmd/32/hidenote.png 
b/icon-themes/colibre/cmd/32/hidenote.png
new file mode 100644
index ..330c1f48570e
Binary files /dev/null and b/icon-themes/colibre/cmd/32/hidenote.png differ
diff --git a/icon-themes/colibre/cmd/32/showannotations.png 
b/icon-themes/colibre/cmd/32/showannotations.png
index f8d663467326..0b2da685b910 100644
Binary files a/icon-themes/colibre/cmd/32/showannotations.png and 

[Libreoffice-bugs] [Bug 107144] CALC: Add icon for Show Comment on/off text button and change icon for Show Comments on/off and rename existing buttons

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107144

--- Comment #28 from Commit Notification 
 ---
rizmut committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/38f79ddf341c35d654e6156a241ddacc5927b444%5E%21

Colibre, elementary, KJ: Fix for tdf#107144

It will be available in 6.3.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107144] CALC: Add icon for Show Comment on/off text button and change icon for Show Comments on/off and rename existing buttons

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107144

--- Comment #27 from Commit Notification 
 ---
rizmut committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/11a1bdc5fa0312111ddf9c1b7779a114b97e361c%5E%21

Colibre, elementary, KJ: Fix for tdf#107144

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg icon-themes/elementary icon-themes/elementary_svg icon-themes/karasa_jaga icon-themes/karasa_jaga_svg

[rizmut (via logerrit)]

 dev/null|binary
 icon-themes/colibre/cmd/32/hideallnotes.png |binary
 icon-themes/colibre/cmd/32/hidenote.png |binary
 icon-themes/colibre/cmd/32/showannotations.png  |binary
 icon-themes/colibre/cmd/32/shownote.png |binary
 icon-themes/colibre/cmd/lc_hidenote.png |binary
 icon-themes/colibre/cmd/lc_showannotations.png  |binary
 icon-themes/colibre/cmd/sc_showannotations.png  |binary
 icon-themes/colibre/links.txt   |   20 
 icon-themes/colibre_svg/cmd/32/hideallnotes.svg |1 
 icon-themes/colibre_svg/cmd/32/hidenote.svg |1 
 icon-themes/colibre_svg/cmd/32/showannotations.svg  |2 
 icon-themes/colibre_svg/cmd/32/shownote.svg |1 
 icon-themes/colibre_svg/cmd/lc_hidenote.svg |2 
 icon-themes/colibre_svg/cmd/lc_showallnotes.svg |1 
 icon-themes/colibre_svg/cmd/lc_showannotations.svg  |2 
 icon-themes/colibre_svg/cmd/sc_showallnotes.svg |1 
 icon-themes/colibre_svg/cmd/sc_showannotations.svg  |2 
 icon-themes/colibre_svg/cmd/sc_switchcontroldesignmode.svg  |3 -
 icon-themes/colibre_svg/svx/res/markers.svg |2 
 icon-themes/elementary/cmd/32/smallcaps.png |binary
 icon-themes/elementary/cmd/32/zoomnext.png  |binary
 icon-themes/elementary/cmd/32/zoompage.png  |binary
 icon-themes/elementary/cmd/32/zoompanning.png   |binary
 icon-themes/elementary/cmd/32/zoomprevious.png  |binary
 icon-themes/elementary/cmd/lc_insertpagenumberfield.png |binary
 icon-themes/elementary/cmd/lc_patternfield.png  |binary
 icon-themes/elementary/cmd/lc_smallcaps.png |binary
 icon-themes/elementary/cmd/lc_zoomnext.png  |binary
 icon-themes/elementary/cmd/lc_zoomobjects.png   |binary
 icon-themes/elementary/cmd/lc_zoompage.png  |binary
 icon-themes/elementary/cmd/lc_zoomprevious.png  |binary
 icon-themes/elementary/cmd/sc_smallcaps.png |binary
 icon-themes/elementary/cmd/sc_zoomobjects.png   |binary
 icon-themes/elementary/links.txt|   28 ++--
 icon-themes/elementary_svg/cmd/32/smallcaps.svg |2 
 icon-themes/elementary_svg/cmd/32/zoomnext.svg  |2 
 icon-themes/elementary_svg/cmd/32/zoompage.svg  |2 
 icon-themes/elementary_svg/cmd/32/zoompanning.svg   |2 
 icon-themes/elementary_svg/cmd/32/zoomprevious.svg  |2 
 icon-themes/elementary_svg/cmd/lc_insertpagenumberfield.svg |2 
 icon-themes/elementary_svg/cmd/lc_patternfield.svg  |2 
 icon-themes/elementary_svg/cmd/lc_smallcaps.svg |2 
 icon-themes/elementary_svg/cmd/lc_zoomnext.svg  |2 
 icon-themes/elementary_svg/cmd/lc_zoomobjects.svg   |2 
 icon-themes/elementary_svg/cmd/lc_zoompage.svg  |2 
 icon-themes/elementary_svg/cmd/lc_zoomprevious.svg  |2 
 icon-themes/elementary_svg/cmd/sc_smallcaps.svg |2 
 icon-themes/elementary_svg/cmd/sc_zoomobjects.svg   |2 
 icon-themes/elementary_svg/svx/res/markers.svg  |2 
 icon-themes/karasa_jaga/links.txt   |   22 -
 51 files changed, 60 insertions(+), 58 deletions(-)

New commits:
commit 11a1bdc5fa0312111ddf9c1b7779a114b97e361c
Author: rizmut 
AuthorDate: Wed Jun 19 00:38:26 2019 +0700
Commit: Rizal Muttaqin 
CommitDate: Tue Jun 18 23:50:46 2019 +0200

Colibre, elementary, KJ: Fix for tdf#107144

elementary:
- Fix blurred zoom icons
- Reverse top arrow on Small Capitals icons

Change-Id: I81883334e5cfaf3dab528ed61ea46894017a6c36
Reviewed-on: https://gerrit.libreoffice.org/74301
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin 

diff --git a/icon-themes/colibre/cmd/32/hideallnotes.png 
b/icon-themes/colibre/cmd/32/hideallnotes.png
new file mode 100644
index ..077b168603e9
Binary files /dev/null and b/icon-themes/colibre/cmd/32/hideallnotes.png differ
diff --git a/icon-themes/colibre/cmd/32/hidenote.png 
b/icon-themes/colibre/cmd/32/hidenote.png
new file mode 100644
index ..330c1f48570e
Binary files /dev/null and b/icon-themes/colibre/cmd/32/hidenote.png differ
diff --git a/icon-themes/colibre/cmd/32/showannotations.png 
b/icon-themes/colibre/cmd/32/showannotations.png
index f8d663467326..0b2da685b910 100644
Binary files a/icon-themes/colibre/cmd/32/showannotations.png and 
b/icon-themes/colibre/cmd/32/showannotations.png differ
diff --git a/icon-themes/colibre/cmd/32/shownote.png 
b/icon-themes/colibre/cmd/32/shownote.png
new file mode 100644
index 

[Libreoffice-bugs] [Bug 125562] LibreOffice fonts aren't installed with LibreOffice 6.2.4.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125562

--- Comment #2 from João Paulo  ---
I rebooted after an uninstall then installed again. Sorry I didn't mention here
already (I forgot to save the bug's web page address to revisit it).

I think rebooting after uninstall functions as a workaround.

Maybe the .MSI package from the older version didn't unregister correctly the
fonts after uninstalling, then a reboot/logoff was necessary so Windows would
rescan installed/registered fonts and the .MSI package for the new version
could register the fonts again.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125997] Sending document as PDF via 'Send merged document as e-mail' is missing line numbers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125997

--- Comment #2 from buschfe...@posteo.de ---
Created attachment 152280
  --> https://bugs.documentfoundation.org/attachment.cgi?id=152280=edit
PDF - Result without line numbers

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125997] Sending document as PDF via 'Send merged document as e-mail' is missing line numbers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125997

--- Comment #1 from buschfe...@posteo.de ---
Created attachment 152279
  --> https://bugs.documentfoundation.org/attachment.cgi?id=152279=edit
Writer - Send merged document as e-mail

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - vcl/qt5

[Jan-Marek Glogowski (via logerrit)]

 vcl/qt5/Qt5Instance.cxx |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit f9cc6303d80ee70e44ce090c6ad2714f7430a7c9
Author: Jan-Marek Glogowski 
AuthorDate: Tue Jun 18 14:11:31 2019 +
Commit: Jan-Marek Glogowski 
CommitDate: Tue Jun 18 23:29:33 2019 +0200

tdf#125934 Qt5 set the desktop file name...

.. but only on wayland, as this also overrides the individual
window icons on X11.

Change-Id: I1b453b23f0dfd4ef2616d7b8054580a6018cdc53
Reviewed-on: https://gerrit.libreoffice.org/74293
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 
(cherry picked from commit 17c91a53d25c0b82524e04a0c108f8e0abc76685)
Reviewed-on: https://gerrit.libreoffice.org/74304

diff --git a/vcl/qt5/Qt5Instance.cxx b/vcl/qt5/Qt5Instance.cxx
index 26e2e5782147..556e8a640148 100644
--- a/vcl/qt5/Qt5Instance.cxx
+++ b/vcl/qt5/Qt5Instance.cxx
@@ -242,8 +242,10 @@ Qt5Instance::~Qt5Instance()
 
 void Qt5Instance::AfterAppInit()
 {
-// sets the default application icon on Wayland
-
QGuiApplication::setDesktopFileName(QStringLiteral("libreoffice-startcenter.desktop"));
+// set the default application icon via destop file just on Wayland,
+// as this otherwise overrides the individual desktop icons on X11.
+if (QGuiApplication::platformName() == "wayland")
+
QGuiApplication::setDesktopFileName(QStringLiteral("libreoffice-startcenter.desktop"));
 }
 
 void Qt5Instance::deleteObjectLater(QObject* pObject) { 
pObject->deleteLater(); }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125934] No application icon on Wayland with the kde5 backend

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125934

--- Comment #8 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/f9cc6303d80ee70e44ce090c6ad2714f7430a7c9%5E%21

tdf#125934 Qt5 set the desktop file name...

It will be available in 6.3.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - vcl/qt5

[Jan-Marek Glogowski (via logerrit)]

 vcl/qt5/Qt5Transferable.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 60d83e5d5490bb488e26f52d5aeee667ffd206fd
Author: Jan-Marek Glogowski 
AuthorDate: Tue Jun 18 16:26:28 2019 +0200
Commit: Jan-Marek Glogowski 
CommitDate: Tue Jun 18 23:29:13 2019 +0200

Qt5 initialize bool before lcl_textMimeInfo call

Change-Id: Ie1b2e77145c4f84dc7d2c1edd214363b7fa0625e
Reviewed-on: https://gerrit.libreoffice.org/74294
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 
(cherry picked from commit 288e729ecfdb7dbb9a4ca00cbc03bcdfe9442a0d)
Reviewed-on: https://gerrit.libreoffice.org/74303

diff --git a/vcl/qt5/Qt5Transferable.cxx b/vcl/qt5/Qt5Transferable.cxx
index 79e524d71eae..10a139093041 100644
--- a/vcl/qt5/Qt5Transferable.cxx
+++ b/vcl/qt5/Qt5Transferable.cxx
@@ -79,7 +79,7 @@ css::uno::Sequence SAL_CALL 
Qt5Transferable::getT
 continue;
 
 // LO doesn't like 'text/plain', so we have to provide UTF-16
-bool bIsNoCharset = false, bIsUTF8 = false, bIsUTF16 = false;
+bool bIsNoCharset = false, bIsUTF16 = false, bIsUTF8 = false;
 if (lcl_textMimeInfo(toOUString(rMimeType), bIsNoCharset, bIsUTF16, 
bIsUTF8))
 {
 bHaveNoCharset |= bIsNoCharset;
@@ -252,7 +252,7 @@ QStringList Qt5MimeData::formats() const
 css::uno::Sequence aFormats
 = m_aContents->getTransferDataFlavors();
 QStringList aList;
-bool bHaveUTF16;
+bool bHaveUTF16 = false;
 
 for (const auto& rFlavor : aFormats)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125997] New: Sending document as PDF via 'Send merged document as e-mail' is missing line numbers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125997

Bug ID: 125997
   Summary: Sending document as PDF via 'Send merged document as
e-mail' is missing line numbers
   Product: LibreOffice
   Version: 6.2.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: buschfe...@posteo.de

Description:
I wanted to send a document via Writers "Send merged document as e-mail"
function, which is really nice and helpful, which has activated line numbers,
but these are not shown in the PDF sent via e-mail.

Steps to Reproduce:
1. Setup mail server in Writer settings
2. Create a document with text and enable line numbers for each but emtpy lines
3. Use the function "Send merged document as e-mail" to send the document as
PDF attachment (setup address source from calc document - everythin working so
far)
4. Click "Send documents"

Actual Results:
Mail(s) are sent but the attached PDF doesn't contain line numbers.

Expected Results:
Mail(s) are sent and the attached PDF doesn contain line numbers, like setup in
the initial document.


Reproducible: Always


User Profile Reset: No



Additional Info:
Exporting into a PDF via Writer leads to line numbers geting shown, so there is
some bug in the "Send merged document as e-mail" code IMHO.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123540] Basic "Tutorials" library is missing in Basic IDE

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123540

--- Comment #2 from Olivier Hallot  ---
To enable it in Basic IDE, add the line below



to the file

<$Installation>/share/basic/script.xlc

check if the code runs without errors before patching, and evaluate if the code
is relevant for the end user. For some reasons in the past, it has been hidden
for the user.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125971] Image import in KDE LibreOffice fails if filename contains non-latin characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125971

--- Comment #8 from Stephan Bergmann  ---
(In reply to Jan-Marek Glogowski from comment #7)
> I'll fix this eventually by using
> 
> OUString aNewURL =
> uri::ExternalUriReferenceTranslator::create(m_xContext)-
> >translateToInternal(toOUString(aURL.toEncoded()));

...which, as I said on IRC, is wrong.  QUrl::toEncoded is documented
( ) to generate a file URL whose
"payload" is UTF-8--encoded.  But
css.uri.XExternalUriReferenceTranslator::translateToInternal expects its
argument to have a "payload" encoded according to the system locale (i.e.,
osl_getThreadTextEncoding).  As QUrl provides a file URL with "payload" in
UTF-8, which is the same format as used internally in LO, there is no need to
map here from external to internal URL.

Lets wait for Piotr to reply why he uses LO with LANG=C.  If you have files in
your file system whose names are encoded with UTF-8, the only reliable way to
access them from LO is to run LO with a UTF-8 system locale (like
LANG=pl.UTF-8).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125806] Broken UI in Writer after pasting website contents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125806

Michael Weghorn  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Michael Weghorn  ---
(In reply to Xisco Faulí from comment #4)
> Hi Michael,
> Looking at the screencast, it seems like a regression from
> a46a257794f1f53b294735fc876c394be23a3811, which got reverted in
> 76c4ed30437125a922936c036a3dc57441938c61.
> Could you please try again with a recent master version ?

Yes, thanks, it (both, the initial report and what is mentioned in comment 1)
works fine again with

Version: 6.4.0.0.alpha0+
Build ID: 4a478227f5af8322164ecce66fd056e9bf2eac89
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: kde5; 
Locale: en-GB (en_GB.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sfx2/inc sfx2/source

[Muhammet Kara (via logerrit)]

 sfx2/inc/autoredactdialog.hxx|   14 +-
 sfx2/source/doc/autoredactdialog.cxx |   25 -
 sfx2/source/doc/objserv.cxx  |2 +-
 3 files changed, 14 insertions(+), 27 deletions(-)

New commits:
commit 1200845272cb1a92507cfe01c125c5aca2d5452f
Author: Muhammet Kara 
AuthorDate: Tue Jun 18 21:04:26 2019 +0300
Commit: Muhammet Kara 
CommitDate: Tue Jun 18 22:20:31 2019 +0200

Copy targets instead of moving during redaction

To allow properly remembering the last state.

* And some clean-up.

Change-Id: Id0b0f4251e3578b8baced1e6e6b1161f46e324dc
Reviewed-on: https://gerrit.libreoffice.org/74302
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 
Reviewed-on: https://gerrit.libreoffice.org/74308
Tested-by: Muhammet Kara 

diff --git a/sfx2/inc/autoredactdialog.hxx b/sfx2/inc/autoredactdialog.hxx
index 2cec20cc64c8..7082052d60a9 100644
--- a/sfx2/inc/autoredactdialog.hxx
+++ b/sfx2/inc/autoredactdialog.hxx
@@ -106,6 +106,7 @@ class SFX2_DLLPUBLIC SfxAutoRedactDialog : public 
SfxDialogController
 std::vector> m_aTableTargets;
 std::unique_ptr m_pFileDlg;
 bool m_bIsValidState;
+bool m_bTargetsCopied;
 
 std::unique_ptr m_xRedactionTargetsLabel;
 std::unique_ptr m_xTargetsBox;
@@ -138,16 +139,11 @@ public:
 bool hasTargets() const;
 /// Check if the dialog is in a valid state.
 bool isValidState() const { return m_bIsValidState; }
-/** Literally moves targets into the given vector.
- *  At the end of the operation, m_aTableTargets vector becomes empty.
- *  The contents of the given vector will be erased before being filled in.
- *  Returns true if successfull.
+/** Copies targets vector
+ *  Does a shallow copy.
+ *  Returns true if successful.
  */
-bool moveTargets(std::vector>& 
r_aTargets);
-
-// TODO: Some method(s) to check emptiness/validity
-// TODO: Some method(s) to get the search params/objects
-// TODO: Some method(s) to load/save redaction target sets
+bool getTargets(std::vector>& 
r_aTargets);
 };
 
 class SfxAddTargetDialog : public weld::GenericDialogController
diff --git a/sfx2/source/doc/autoredactdialog.cxx 
b/sfx2/source/doc/autoredactdialog.cxx
index c7248446f9f3..b1882f7b5717 100644
--- a/sfx2/source/doc/autoredactdialog.cxx
+++ b/sfx2/source/doc/autoredactdialog.cxx
@@ -545,6 +545,7 @@ void SfxAutoRedactDialog::clearTargets()
 SfxAutoRedactDialog::SfxAutoRedactDialog(weld::Window* pParent)
 : SfxDialogController(pParent, "sfx/ui/autoredactdialog.ui", 
"AutoRedactDialog")
 , m_bIsValidState(true)
+, m_bTargetsCopied(false)
 , m_xRedactionTargetsLabel(m_xBuilder->weld_label("labelRedactionTargets"))
 , m_xTargetsBox(new TargetsTable(m_xBuilder->weld_tree_view("targets")))
 , m_xLoadBtn(m_xBuilder->weld_button("btnLoadTargets"))
@@ -636,7 +637,8 @@ SfxAutoRedactDialog::~SfxAutoRedactDialog()
OStringToOUString(m_xDialog->get_help_id(), 
RTL_TEXTENCODING_UTF8));
 aDlgOpt.SetUserItem("UserItem", css::uno::makeAny(sUserDataStr));
 
-clearTargets();
+if (!m_bTargetsCopied)
+clearTargets();
 }
 catch (css::uno::Exception& e)
 {
@@ -656,24 +658,13 @@ bool SfxAutoRedactDialog::hasTargets() const
 return true;
 }
 
-bool SfxAutoRedactDialog::moveTargets(
-std::vector>& r_aTargets)
+bool SfxAutoRedactDialog::getTargets(std::vector>& r_aTargets)
 {
-try
-{
-r_aTargets.clear();
-r_aTargets.insert(r_aTargets.end(), 
std::make_move_iterator(m_aTableTargets.begin()),
-  std::make_move_iterator(m_aTableTargets.end()));
-m_aTableTargets.clear();
-m_bIsValidState = false;
-}
-catch (const css::uno::Exception& e)
-{
-SAL_WARN("sfx.doc", "Exception caught while moving redaction targets: 
" << e.Message);
-m_bIsValidState = false;
-return false;
-}
+if (m_aTableTargets.empty())
+return true;
 
+r_aTargets = m_aTableTargets;
+m_bTargetsCopied = true;
 return true;
 }
 
diff --git a/sfx2/source/doc/objserv.cxx b/sfx2/source/doc/objserv.cxx
index 9b9b3fc0f9dc..73bc90490f22 100644
--- a/sfx2/source/doc/objserv.cxx
+++ b/sfx2/source/doc/objserv.cxx
@@ -560,7 +560,7 @@ void SfxObjectShell::ExecFile_Impl(SfxRequest )
 
 // else continue with normal redaction
 bIsAutoRedact = true;
-aDlg.moveTargets(aRedactionTargets);
+aDlg.getTargets(aRedactionTargets);
 
 [[fallthrough]];
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sfx2/source

[Muhammet Kara (via logerrit)]

 sfx2/source/doc/autoredactdialog.cxx |   73 ---
 1 file changed, 67 insertions(+), 6 deletions(-)

New commits:
commit 9c2043f649078c3b316415f174e6ec2840908d7e
Author: Muhammet Kara 
AuthorDate: Mon Jun 17 15:33:37 2019 +0300
Commit: Muhammet Kara 
CommitDate: Tue Jun 18 22:19:56 2019 +0200

Let autoredact dialog remember last state

* By storing the JSON string as SvtViewOptions

Change-Id: I08e323005612cb0181d2176af659eb54267fbb3f
Reviewed-on: https://gerrit.libreoffice.org/74169
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 
Reviewed-on: https://gerrit.libreoffice.org/74305
Tested-by: Muhammet Kara 

diff --git a/sfx2/source/doc/autoredactdialog.cxx 
b/sfx2/source/doc/autoredactdialog.cxx
index 798ab965d831..c7248446f9f3 100644
--- a/sfx2/source/doc/autoredactdialog.cxx
+++ b/sfx2/source/doc/autoredactdialog.cxx
@@ -557,6 +557,7 @@ SfxAutoRedactDialog::SfxAutoRedactDialog(weld::Window* 
pParent)
 OUString sExtraData;
 SvtViewOptions aDlgOpt(EViewType::Dialog,
OStringToOUString(m_xDialog->get_help_id(), 
RTL_TEXTENCODING_UTF8));
+
 if (aDlgOpt.Exists())
 {
 css::uno::Any aUserItem = aDlgOpt.GetUserItem("UserItem");
@@ -564,12 +565,34 @@ SfxAutoRedactDialog::SfxAutoRedactDialog(weld::Window* 
pParent)
 }
 
 // update the targets configuration if necessary
+if (!sExtraData.isEmpty())
 {
 weld::WaitObject aWaitCursor(m_xDialog.get());
-//m_aTargets.Update();
-}
 
-// TODO: fill the targets box
+try
+{
+// Create path string, and read JSON from file
+boost::property_tree::ptree aTargetsJSON;
+std::stringstream 
aStream(std::string(sExtraData.toUtf8().getStr()));
+
+boost::property_tree::read_json(aStream, aTargetsJSON);
+
+// Recreate & add the targets to the dialog
+for (const boost::property_tree::ptree::value_type& rValue :
+ aTargetsJSON.get_child("RedactionTargets"))
+{
+RedactionTarget* pTarget = JSONtoRedactionTarget(rValue);
+addTarget(pTarget);
+}
+}
+catch (css::uno::Exception& e)
+{
+SAL_WARN("sfx.doc",
+ "Exception caught while trying to load the last dialog 
state: " << e.Message);
+return;
+//TODO: Warn the user with a message box
+}
+}
 
 // Handler connections
 m_xLoadBtn->connect_clicked(LINK(this, SfxAutoRedactDialog, Load));
@@ -581,9 +604,47 @@ SfxAutoRedactDialog::SfxAutoRedactDialog(weld::Window* 
pParent)
 
 SfxAutoRedactDialog::~SfxAutoRedactDialog()
 {
-// Store the view options
-/*SvtViewOptions aDlgOpt(EViewType::Dialog, 
OStringToOUString(m_xDialog->get_help_id(), RTL_TEXTENCODING_UTF8));
-aDlgOpt.SetUserItem("UserItem", 
css::uno::makeAny(m_xMoreBt->get_expanded() ? OUString("Y") : OUString("N")));*/
+if (m_aTableTargets.empty())
+{
+// Clear the dialog data
+SvtViewOptions aDlgOpt(EViewType::Dialog,
+   OStringToOUString(m_xDialog->get_help_id(), 
RTL_TEXTENCODING_UTF8));
+aDlgOpt.Delete();
+return;
+}
+
+try
+{
+// Put the targets into a JSON array
+boost::property_tree::ptree aTargetsArray;
+for (const auto& targetPair : m_aTableTargets)
+{
+aTargetsArray.push_back(std::make_pair("", 
redactionTargetToJSON(targetPair.first)));
+}
+
+// Build the JSON tree
+boost::property_tree::ptree aTargetsTree;
+aTargetsTree.add_child("RedactionTargets", aTargetsArray);
+std::stringstream aStream;
+
+boost::property_tree::write_json(aStream, aTargetsTree, false);
+
+OUString sUserDataStr(OUString::fromUtf8(aStream.str().c_str()));
+
+// Store the dialog data
+SvtViewOptions aDlgOpt(EViewType::Dialog,
+   OStringToOUString(m_xDialog->get_help_id(), 
RTL_TEXTENCODING_UTF8));
+aDlgOpt.SetUserItem("UserItem", css::uno::makeAny(sUserDataStr));
+
+clearTargets();
+}
+catch (css::uno::Exception& e)
+{
+SAL_WARN("sfx.doc",
+ "Exception caught while trying to store the dialog state: " 
<< e.Message);
+return;
+//TODO: Warn the user with a message box
+}
 }
 
 bool SfxAutoRedactDialog::hasTargets() const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125961] [Website] Download page should support non-English users better

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125961

sbucks  changed:

   What|Removed |Added

   Keywords||skillDesign

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sfx2/inc sfx2/source

[Muhammet Kara (via logerrit)]

 sfx2/inc/autoredactdialog.hxx|   12 
 sfx2/source/doc/autoredactdialog.cxx |   25 -
 sfx2/source/doc/objserv.cxx  |2 +-
 3 files changed, 13 insertions(+), 26 deletions(-)

New commits:
commit 881e6fdd47386e430ad4c5489e3a6bbf0b46c85f
Author: Muhammet Kara 
AuthorDate: Tue Jun 18 21:04:26 2019 +0300
Commit: Muhammet Kara 
CommitDate: Tue Jun 18 21:59:35 2019 +0200

Copy targets instead of moving during redaction

To allow properly remembering the last state.

* And some clean-up.

Change-Id: Id0b0f4251e3578b8baced1e6e6b1161f46e324dc
Reviewed-on: https://gerrit.libreoffice.org/74302
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 

diff --git a/sfx2/inc/autoredactdialog.hxx b/sfx2/inc/autoredactdialog.hxx
index 9734f236de10..f7cdecc15cce 100644
--- a/sfx2/inc/autoredactdialog.hxx
+++ b/sfx2/inc/autoredactdialog.hxx
@@ -106,6 +106,7 @@ class SFX2_DLLPUBLIC SfxAutoRedactDialog : public 
SfxDialogController
 std::vector> m_aTableTargets;
 std::unique_ptr m_pFileDlg;
 bool m_bIsValidState;
+bool m_bTargetsCopied;
 
 std::unique_ptr m_xRedactionTargetsLabel;
 std::unique_ptr m_xTargetsBox;
@@ -138,16 +139,11 @@ public:
 bool hasTargets() const;
 /// Check if the dialog is in a valid state.
 bool isValidState() const { return m_bIsValidState; }
-/** Literally moves targets into the given vector.
- *  At the end of the operation, m_aTableTargets vector becomes empty.
- *  The contents of the given vector will be erased before being filled in.
+/** Copies targets vector
+ *  Does a shallow copy.
  *  Returns true if successful.
  */
-bool moveTargets(std::vector>& 
r_aTargets);
-
-// TODO: Some method(s) to check emptiness/validity
-// TODO: Some method(s) to get the search params/objects
-// TODO: Some method(s) to load/save redaction target sets
+bool getTargets(std::vector>& 
r_aTargets);
 };
 
 class SfxAddTargetDialog : public weld::GenericDialogController
diff --git a/sfx2/source/doc/autoredactdialog.cxx 
b/sfx2/source/doc/autoredactdialog.cxx
index 950684ac4d1c..54f40fc35abd 100644
--- a/sfx2/source/doc/autoredactdialog.cxx
+++ b/sfx2/source/doc/autoredactdialog.cxx
@@ -545,6 +545,7 @@ void SfxAutoRedactDialog::clearTargets()
 SfxAutoRedactDialog::SfxAutoRedactDialog(weld::Window* pParent)
 : SfxDialogController(pParent, "sfx/ui/autoredactdialog.ui", 
"AutoRedactDialog")
 , m_bIsValidState(true)
+, m_bTargetsCopied(false)
 , m_xRedactionTargetsLabel(m_xBuilder->weld_label("labelRedactionTargets"))
 , m_xTargetsBox(new TargetsTable(m_xBuilder->weld_tree_view("targets")))
 , m_xLoadBtn(m_xBuilder->weld_button("btnLoadTargets"))
@@ -636,7 +637,8 @@ SfxAutoRedactDialog::~SfxAutoRedactDialog()
OStringToOUString(m_xDialog->get_help_id(), 
RTL_TEXTENCODING_UTF8));
 aDlgOpt.SetUserItem("UserItem", css::uno::makeAny(sUserDataStr));
 
-clearTargets();
+if (!m_bTargetsCopied)
+clearTargets();
 }
 catch (css::uno::Exception& e)
 {
@@ -656,24 +658,13 @@ bool SfxAutoRedactDialog::hasTargets() const
 return true;
 }
 
-bool SfxAutoRedactDialog::moveTargets(
-std::vector>& r_aTargets)
+bool SfxAutoRedactDialog::getTargets(std::vector>& r_aTargets)
 {
-try
-{
-r_aTargets.clear();
-r_aTargets.insert(r_aTargets.end(), 
std::make_move_iterator(m_aTableTargets.begin()),
-  std::make_move_iterator(m_aTableTargets.end()));
-m_aTableTargets.clear();
-m_bIsValidState = false;
-}
-catch (const css::uno::Exception& e)
-{
-SAL_WARN("sfx.doc", "Exception caught while moving redaction targets: 
" << e.Message);
-m_bIsValidState = false;
-return false;
-}
+if (m_aTableTargets.empty())
+return true;
 
+r_aTargets = m_aTableTargets;
+m_bTargetsCopied = true;
 return true;
 }
 
diff --git a/sfx2/source/doc/objserv.cxx b/sfx2/source/doc/objserv.cxx
index 24eee80787f8..74edeb4d57da 100644
--- a/sfx2/source/doc/objserv.cxx
+++ b/sfx2/source/doc/objserv.cxx
@@ -561,7 +561,7 @@ void SfxObjectShell::ExecFile_Impl(SfxRequest )
 
 // else continue with normal redaction
 bIsAutoRedact = true;
-aDlg.moveTargets(aRedactionTargets);
+aDlg.getTargets(aRedactionTargets);
 
 [[fallthrough]];
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 82664] Character Position missing in styles dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82664

--- Comment #14 from Cor Nouws  ---
(In reply to V Stuart Foote from comment #13)

> into style (and setting each from Character dialog is always direct
> formatting)?
- Create a text box, set e.g. Width scaling 200%
- create new style with that box selected
- apply to another text box
  > width scaling applied

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125992] Copying a url of youtube video to my text (Writer) file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125992

--- Comment #1 from Dieter Praas  ---
I can't confirm it with

Version: 6.4.0.0.alpha0+ (x64)
Build ID: b170256fb6ebaf774b02b89835b19d9f3a1afb89
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-06-07_03:30:35
Locale: de-DE (de_DE); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 125993] CHAPTER NUMBERING DIALOG: Give option to seperate different chapter levels with a dash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125993

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Severity|normal  |enhancement
 Status|UNCONFIRMED |NEW
 Blocks||115121
Summary|problem(Please,Help)：When   |CHAPTER NUMBERING DIALOG:
   |in Writer: Show sublevels   |Give option to seperate
   ||different chapter levels
   ||with a dash
 Ever confirmed|0   |1

--- Comment #1 from Dieter Praas  ---
I confirm, that it is not possible to set chapter numbering to 1-1 or A-1

Version: 6.4.0.0.alpha0+ (x64)
Build ID: b170256fb6ebaf774b02b89835b19d9f3a1afb89
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-06-07_03:30:35
Locale: de-DE (de_DE); UI-Language: en-US
Calc: threaded

I think, if it is part of APA-Style, it should be implemented

=> NEW Enhancement

cc: Design Team for further input


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115121
[Bug 115121] [META] Chapter numbering dialog bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 115121] [META] Chapter numbering dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115121

Dieter Praas  changed:

   What|Removed |Added

 Depends on||125993


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125993
[Bug 125993] CHAPTER NUMBERING DIALOG: Give option to seperate different
chapter levels with a dash
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125993] CHAPTER NUMBERING DIALOG: Give option to seperate different chapter levels with a dash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125993

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Severity|normal  |enhancement
 Status|UNCONFIRMED |NEW
 Blocks||115121
Summary|problem(Please,Help)：When   |CHAPTER NUMBERING DIALOG:
   |in Writer: Show sublevels   |Give option to seperate
   ||different chapter levels
   ||with a dash
 Ever confirmed|0   |1

--- Comment #1 from Dieter Praas  ---
I confirm, that it is not possible to set chapter numbering to 1-1 or A-1

Version: 6.4.0.0.alpha0+ (x64)
Build ID: b170256fb6ebaf774b02b89835b19d9f3a1afb89
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-06-07_03:30:35
Locale: de-DE (de_DE); UI-Language: en-US
Calc: threaded

I think, if it is part of APA-Style, it should be implemented

=> NEW Enhancement

cc: Design Team for further input


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115121
[Bug 115121] [META] Chapter numbering dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125962] Blurry toolbar icons in hidpi (3000x2000) screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125962

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||90796


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=90796
[Bug 90796] [META] HiDPI / Retina bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90796

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||125962


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125962
[Bug 125962] Blurry toolbar icons in hidpi (3000x2000) screen
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125963] Small font in options with hidpi monitor (3000x2000, dpi: 192)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125963

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||90796


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=90796
[Bug 90796] [META] HiDPI / Retina bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90796

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||125963


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125963
[Bug 125963] Small font in options with hidpi monitor (3000x2000, dpi: 192)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125988] Menubar is broken after open a DOC file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125988

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> ---
Volga, please attach file here

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125987] LibreOffice Online Delete Slide does not work from the upper menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125987

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

Version|6.3.0.0.alpha0+ |unspecified
Product|LibreOffice |LibreOffice Online
  Component|LibreOffice |Impress

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125934] No application icon on Wayland with the kde5 backend

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125934

--- Comment #7 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/17c91a53d25c0b82524e04a0c108f8e0abc76685%5E%21

tdf#125934 Qt5 set the desktop file name...

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125996] New: EDITING: Gif images not shown correctly on the presentation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125996

Bug ID: 125996
   Summary: EDITING: Gif images not shown correctly on the
presentation
   Product: LibreOffice
   Version: 6.2.4.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tkayi...@gmx.com

Created attachment 152278
  --> https://bugs.documentfoundation.org/attachment.cgi?id=152278=edit
A minimal example

The gif images are imported properly, they are shown in an animated way as
well. However, the changes made in the Libreoffice itself do not take into
effect during the presentation, but rather the original form of the image is
displayed.

I attached an example 1-slide presentation to show the problem. Basically, the
images look fine on the slide, they appear animated. However, when I enter the
presentation mode, the slide shown is different (i.e. not WYSIWYG)

a) I drew borders around two of them, and they do not appear at all.
b) The applied 90 degrees rotation is not observed on the right most image.

Ordinary images I deal with such as .png and .jpg behave just fine in this
regard.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/headless vcl/inc vcl/Library_vcl.mk vcl/osx vcl/qt5 vcl/source vcl/unx vcl/win

[Jan-Marek Glogowski (via logerrit)]

 vcl/Library_vcl.mk|1 
 vcl/headless/svpframe.cxx |2 
 vcl/headless/svpgdi.cxx   |   63 -
 vcl/inc/WidgetDrawInterface.hxx   |   57 
 vcl/inc/headless/svpgdi.hxx   |   21 
 vcl/inc/qt5/Qt5Graphics.hxx   |   49 --
 vcl/inc/qt5/Qt5Graphics_Controls.hxx  |   27 ++---
 vcl/inc/qt5/Qt5SvpGraphics.hxx|   41 
 vcl/inc/quartz/salgdi.h   |   10 +-
 vcl/inc/salgdi.hxx|  139 +++---
 vcl/inc/unx/gtk/gtkgdi.hxx|   17 ++-
 vcl/inc/win/salgdi.h  |5 -
 vcl/osx/salnativewidgets.cxx  |2 
 vcl/qt5/Qt5Graphics.cxx   |   25 ++---
 vcl/qt5/Qt5Graphics_Controls.cxx  |4 
 vcl/qt5/Qt5SvpGraphics.cxx|   51 +--
 vcl/source/gdi/salgdilayout.cxx   |   56 +++-
 vcl/source/gdi/salnativewidgets-none.cxx  |   53 ---
 vcl/source/outdev/nativecontrols.cxx  |2 
 vcl/unx/gtk/gtksalframe.cxx   |2 
 vcl/unx/gtk/salnativewidgets-gtk.cxx  |8 +
 vcl/unx/gtk3/gtk3gtkframe.cxx |2 
 vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx |   49 +++---
 vcl/win/gdi/salnativewidgets-luna.cxx |2 
 24 files changed, 193 insertions(+), 495 deletions(-)

New commits:
commit 4a478227f5af8322164ecce66fd056e9bf2eac89
Author: Jan-Marek Glogowski 
AuthorDate: Sun Jun 16 14:19:09 2019 +
Commit: Jan-Marek Glogowski 
CommitDate: Tue Jun 18 20:27:49 2019 +0200

VCL cleanup WidgetDrawInterface

I don't understand why WidgetDrawInterface, which is basically a
copy of the SalGraphics native controls interface, duplicated it,
instead of cleaning things up.

The whole commit message of commit 8fcfa3853a81, which added this
code, is just: "custom widgets: Custom Widget Themes". That's it.

So this patch does, what the original one skipped: replacing the
SalGraphics interface with the WidgetDrawInterface. One result is
the addition of handleDamage to SalGraphics to correctly handle
the damage done by a custom widget theme to the underlying
SalGraphics implementation.

Change-Id: I5fda1a64b28e6560fb3c62e02b6dcda827f698e2
Reviewed-on: https://gerrit.libreoffice.org/74118
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index deb7cf049106..c8391717c492 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -300,7 +300,6 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
 vcl/source/gdi/salgdiimpl \
 vcl/source/gdi/sallayout \
 vcl/source/gdi/salmisc \
-vcl/source/gdi/salnativewidgets-none \
 vcl/source/gdi/vectorgraphicdata \
 vcl/source/gdi/textlayout \
 vcl/source/gdi/virdev \
diff --git a/vcl/headless/svpframe.cxx b/vcl/headless/svpframe.cxx
index f54103ff1ecc..4259a84d5a0b 100644
--- a/vcl/headless/svpframe.cxx
+++ b/vcl/headless/svpframe.cxx
@@ -441,7 +441,7 @@ void SvpSalFrame::UpdateSettings( AllSettings& rSettings )
 }
 rSettings.SetStyleSettings(aStyleSettings);
 #ifndef IOS // For now...
-pGraphics->updateSettings(rSettings);
+pGraphics->UpdateSettings(rSettings);
 #endif
 if (bFreeGraphics)
 ReleaseGraphics(pGraphics);
diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 0f6fda87fd5b..b335d2ed630b 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -1866,69 +1866,6 @@ bool SvpSalGraphics::drawEPS( long, long, long, long, 
void*, sal_uInt32 )
 return false;
 }
 
-/* Widget drawing */
-
-bool SvpSalGraphics::IsNativeControlSupported(ControlType eType, ControlPart 
ePart)
-{
-if (hasWidgetDraw())
-return m_pWidgetDraw->isNativeControlSupported(eType, ePart);
-
-return false;
-}
-
-bool SvpSalGraphics::hitTestNativeControl(ControlType eType, ControlPart ePart,
-   const tools::Rectangle& 
rBoundingControlRegion,
-   const Point& rPosition, bool& rIsInside)
-{
-if (hasWidgetDraw())
-{
-return m_pWidgetDraw->hitTestNativeControl(eType, ePart, 
rBoundingControlRegion, rPosition, rIsInside);
-}
-
-return false;
-}
-
-bool SvpSalGraphics::drawNativeControl(ControlType eType, ControlPart ePart,
-   const tools::Rectangle& rControlRegion,
-   ControlState eState, const 
ImplControlValue& aValue,
-   const OUString& aCaptions)
-{
-if (hasWidgetDraw())
-{
-bool bReturn = m_pWidgetDraw->drawNativeControl(eType, ePart, 
rControlRegion,
-eState, aValue, 
aCaptions);
-return bReturn;
-}
-
-return false;
-}
-
-bool 

[Libreoffice-commits] core.git: 2 commits - sfx2/source vcl/qt5

[Jan-Marek Glogowski (via logerrit)]

 sfx2/source/doc/autoredactdialog.cxx |   73 ---
 vcl/qt5/Qt5Instance.cxx  |6 +-
 2 files changed, 71 insertions(+), 8 deletions(-)

New commits:
commit 17c91a53d25c0b82524e04a0c108f8e0abc76685
Author: Jan-Marek Glogowski 
AuthorDate: Tue Jun 18 14:11:31 2019 +
Commit: Jan-Marek Glogowski 
CommitDate: Tue Jun 18 20:22:32 2019 +0200

tdf#125934 Qt5 set the desktop file name...

.. but only on wayland, as this also overrides the individual
window icons on X11.

Change-Id: I1b453b23f0dfd4ef2616d7b8054580a6018cdc53
Reviewed-on: https://gerrit.libreoffice.org/74293
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/vcl/qt5/Qt5Instance.cxx b/vcl/qt5/Qt5Instance.cxx
index 7961d5be0209..f83cf86b25ba 100644
--- a/vcl/qt5/Qt5Instance.cxx
+++ b/vcl/qt5/Qt5Instance.cxx
@@ -243,8 +243,10 @@ Qt5Instance::~Qt5Instance()
 
 void Qt5Instance::AfterAppInit()
 {
-// sets the default application icon on Wayland
-
QGuiApplication::setDesktopFileName(QStringLiteral("libreoffice-startcenter.desktop"));
+// set the default application icon via destop file just on Wayland,
+// as this otherwise overrides the individual desktop icons on X11.
+if (QGuiApplication::platformName() == "wayland")
+
QGuiApplication::setDesktopFileName(QStringLiteral("libreoffice-startcenter.desktop"));
 }
 
 void Qt5Instance::deleteObjectLater(QObject* pObject) { 
pObject->deleteLater(); }
commit 3cc152695af2117fecc0006ac2d34d43a9df0d86
Author: Muhammet Kara 
AuthorDate: Mon Jun 17 15:33:37 2019 +0300
Commit: Muhammet Kara 
CommitDate: Tue Jun 18 20:20:08 2019 +0200

Let autoredact dialog remember last state

* By storing the JSON string as SvtViewOptions

Change-Id: I08e323005612cb0181d2176af659eb54267fbb3f
Reviewed-on: https://gerrit.libreoffice.org/74169
Tested-by: Jenkins
Reviewed-by: Muhammet Kara 

diff --git a/sfx2/source/doc/autoredactdialog.cxx 
b/sfx2/source/doc/autoredactdialog.cxx
index cc0aa1456db8..950684ac4d1c 100644
--- a/sfx2/source/doc/autoredactdialog.cxx
+++ b/sfx2/source/doc/autoredactdialog.cxx
@@ -557,6 +557,7 @@ SfxAutoRedactDialog::SfxAutoRedactDialog(weld::Window* 
pParent)
 OUString sExtraData;
 SvtViewOptions aDlgOpt(EViewType::Dialog,
OStringToOUString(m_xDialog->get_help_id(), 
RTL_TEXTENCODING_UTF8));
+
 if (aDlgOpt.Exists())
 {
 css::uno::Any aUserItem = aDlgOpt.GetUserItem("UserItem");
@@ -564,12 +565,34 @@ SfxAutoRedactDialog::SfxAutoRedactDialog(weld::Window* 
pParent)
 }
 
 // update the targets configuration if necessary
+if (!sExtraData.isEmpty())
 {
 weld::WaitObject aWaitCursor(m_xDialog.get());
-//m_aTargets.Update();
-}
 
-// TODO: fill the targets box
+try
+{
+// Create path string, and read JSON from file
+boost::property_tree::ptree aTargetsJSON;
+std::stringstream aStream(std::string(sExtraData.toUtf8()));
+
+boost::property_tree::read_json(aStream, aTargetsJSON);
+
+// Recreate & add the targets to the dialog
+for (const boost::property_tree::ptree::value_type& rValue :
+ aTargetsJSON.get_child("RedactionTargets"))
+{
+RedactionTarget* pTarget = JSONtoRedactionTarget(rValue);
+addTarget(pTarget);
+}
+}
+catch (css::uno::Exception& e)
+{
+SAL_WARN("sfx.doc",
+ "Exception caught while trying to load the last dialog 
state: " << e.Message);
+return;
+//TODO: Warn the user with a message box
+}
+}
 
 // Handler connections
 m_xLoadBtn->connect_clicked(LINK(this, SfxAutoRedactDialog, Load));
@@ -581,9 +604,47 @@ SfxAutoRedactDialog::SfxAutoRedactDialog(weld::Window* 
pParent)
 
 SfxAutoRedactDialog::~SfxAutoRedactDialog()
 {
-// Store the view options
-/*SvtViewOptions aDlgOpt(EViewType::Dialog, 
OStringToOUString(m_xDialog->get_help_id(), RTL_TEXTENCODING_UTF8));
-aDlgOpt.SetUserItem("UserItem", 
css::uno::makeAny(m_xMoreBt->get_expanded() ? OUString("Y") : OUString("N")));*/
+if (m_aTableTargets.empty())
+{
+// Clear the dialog data
+SvtViewOptions aDlgOpt(EViewType::Dialog,
+   OStringToOUString(m_xDialog->get_help_id(), 
RTL_TEXTENCODING_UTF8));
+aDlgOpt.Delete();
+return;
+}
+
+try
+{
+// Put the targets into a JSON array
+boost::property_tree::ptree aTargetsArray;
+for (const auto& targetPair : m_aTableTargets)
+{
+aTargetsArray.push_back(std::make_pair("", 
redactionTargetToJSON(targetPair.first)));
+}
+
+// Build the JSON tree
+boost::property_tree::ptree aTargetsTree;
+aTargetsTree.add_child("RedactionTargets", 

[Libreoffice-commits] core.git: vcl/qt5

[Jan-Marek Glogowski (via logerrit)]

 vcl/qt5/Qt5Transferable.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 288e729ecfdb7dbb9a4ca00cbc03bcdfe9442a0d
Author: Jan-Marek Glogowski 
AuthorDate: Tue Jun 18 16:26:28 2019 +0200
Commit: Jan-Marek Glogowski 
CommitDate: Tue Jun 18 20:18:10 2019 +0200

Qt5 initialize bool before lcl_textMimeInfo call

Change-Id: Ie1b2e77145c4f84dc7d2c1edd214363b7fa0625e
Reviewed-on: https://gerrit.libreoffice.org/74294
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/vcl/qt5/Qt5Transferable.cxx b/vcl/qt5/Qt5Transferable.cxx
index 79e524d71eae..10a139093041 100644
--- a/vcl/qt5/Qt5Transferable.cxx
+++ b/vcl/qt5/Qt5Transferable.cxx
@@ -79,7 +79,7 @@ css::uno::Sequence SAL_CALL 
Qt5Transferable::getT
 continue;
 
 // LO doesn't like 'text/plain', so we have to provide UTF-16
-bool bIsNoCharset = false, bIsUTF8 = false, bIsUTF16 = false;
+bool bIsNoCharset = false, bIsUTF16 = false, bIsUTF8 = false;
 if (lcl_textMimeInfo(toOUString(rMimeType), bIsNoCharset, bIsUTF16, 
bIsUTF8))
 {
 bHaveNoCharset |= bIsNoCharset;
@@ -252,7 +252,7 @@ QStringList Qt5MimeData::formats() const
 css::uno::Sequence aFormats
 = m_aContents->getTransferDataFlavors();
 QStringList aList;
-bool bHaveUTF16;
+bool bHaveUTF16 = false;
 
 for (const auto& rFlavor : aFormats)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125971] Image import in KDE LibreOffice fails if filename contains non-latin characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125971

--- Comment #7 from Jan-Marek Glogowski  ---
Just opening the file is a KDE only problem, that I can fix / work around. But
then there will be much more problems. I've created bug 125971 for that.

I'll fix this eventually by using

OUString aNewURL =
uri::ExternalUriReferenceTranslator::create(m_xContext)->translateToInternal(toOUString(aURL.toEncoded()));

but strictly speaking this should be somewhow handled correctly in
INetURLObject.

Then the fix will just be to use aURL.toEncoded() instead of aURL.toString().

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: comphelper/source compilerplugins/clang connectivity/source cppcanvas/source include/comphelper include/sfx2 include/svl include/svx include/vcl oox/source sc/source sd

[Noel Grandin (via logerrit)]

 comphelper/source/misc/logging.cxx |2 +-
 compilerplugins/clang/passstuffbyref.cxx   |   12 
 connectivity/source/drivers/firebird/ResultSet.cxx |2 +-
 connectivity/source/drivers/firebird/ResultSet.hxx |2 +-
 cppcanvas/source/mtfrenderer/textlineshelper.hxx   |2 +-
 include/comphelper/logging.hxx |2 +-
 include/sfx2/sidebar/SidebarController.hxx |2 +-
 include/svl/itempool.hxx   |4 ++--
 include/svx/charmap.hxx|2 +-
 include/svx/svdlayer.hxx   |6 +++---
 include/svx/unoshape.hxx   |2 +-
 include/vcl/menu.hxx   |2 +-
 include/vcl/menubtn.hxx|2 +-
 oox/source/drawingml/texteffectscontext.cxx|2 +-
 sc/source/filter/inc/stylesbuffer.hxx  |2 +-
 sc/source/ui/dataprovider/datatransformation.cxx   |   12 ++--
 sc/source/ui/inc/datatransformation.hxx|   12 ++--
 sdext/source/minimizer/unodialog.hxx   |2 +-
 sfx2/inc/SfxRedactionHelper.hxx|8 
 sfx2/inc/autoredactdialog.hxx  |4 ++--
 sfx2/source/doc/SfxRedactionHelper.cxx |   12 +---
 sfx2/source/doc/autoredactdialog.cxx   |6 +++---
 starmath/inc/ElementsDockingWindow.hxx |2 +-
 svtools/source/control/tabbar.cxx  |2 +-
 svx/source/dialog/charmap.cxx  |2 +-
 svx/source/stbctrls/zoomctrl.cxx   |2 +-
 svx/source/unodraw/unoshape.cxx|2 +-
 sw/inc/authfld.hxx |2 +-
 sw/inc/viewsh.hxx  |2 +-
 sw/source/core/fields/authfld.cxx  |2 +-
 sw/source/filter/ww8/docxtablestyleexport.cxx  |2 +-
 vcl/inc/image.h|4 ++--
 vcl/inc/qt5/Qt5FontFace.hxx|2 +-
 vcl/qt5/Qt5FontFace.cxx|2 +-
 vcl/source/gdi/FileDefinitionWidgetDraw.cxx|2 +-
 vcl/source/gdi/svmconverter.cxx|2 +-
 vcl/source/image/ImplImage.cxx |4 ++--
 writerfilter/source/dmapper/SettingsTable.cxx  |2 +-
 writerfilter/source/dmapper/SettingsTable.hxx  |2 +-
 writerfilter/source/dmapper/StyleSheetTable.cxx|2 +-
 writerfilter/source/dmapper/StyleSheetTable.hxx|2 +-
 writerfilter/source/rtftok/rtfdocumentimpl.hxx |4 ++--
 writerperfect/source/writer/exp/xmlfmt.cxx |2 +-
 xmlsecurity/inc/documentsignaturemanager.hxx   |2 +-
 44 files changed, 81 insertions(+), 71 deletions(-)

New commits:
commit 31f04378dbc07d4367dc3b66163aaed171cf0323
Author: Noel Grandin 
AuthorDate: Tue Jun 18 09:32:00 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Jun 18 20:10:57 2019 +0200

loplugin:passstuffbyref

Change-Id: Icb7c22cf4ac95eab54d04e79312fb471ca27bceb
Reviewed-on: https://gerrit.libreoffice.org/74246
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/comphelper/source/misc/logging.cxx 
b/comphelper/source/misc/logging.cxx
index dfd52f8d5bcb..d9b7caf52634 100644
--- a/comphelper/source/misc/logging.cxx
+++ b/comphelper/source/misc/logging.cxx
@@ -86,7 +86,7 @@ namespace comphelper
 return false;
 }
 
-const css::uno::Reference EventLogger::getLogger()
+const css::uno::Reference & EventLogger::getLogger()
 {
 return m_pImpl->getLogger();
 }
diff --git a/compilerplugins/clang/passstuffbyref.cxx 
b/compilerplugins/clang/passstuffbyref.cxx
index 1fd14619b62f..cff1e781455c 100644
--- a/compilerplugins/clang/passstuffbyref.cxx
+++ b/compilerplugins/clang/passstuffbyref.cxx
@@ -271,6 +271,18 @@ void PassStuffByRef::checkReturnValue(const FunctionDecl * 
functionDecl, const C
 .GlobalNamespace()) {
 return;
 }
+// hides a constructor
+if 
(dc.Function("createNonOwningCopy").Class("SortedAutoCompleteStrings").Namespace("editeng")
+.GlobalNamespace()) {
+return;
+}
+// template function
+if 
(dc.Function("convertItems").Class("ValueParser").Namespace("configmgr").GlobalNamespace()
+|| 
dc.Function("parseListValue").AnonymousNamespace().Namespace("configmgr").GlobalNamespace()
+|| 
dc.Function("parseSingleValue").AnonymousNamespace().Namespace("configmgr").GlobalNamespace()
+|| 
dc.Function("Create").Class("HandlerComponentBase").Namespace("pcr").GlobalNamespace())
 {
+return;
+}
 if (startswith(type.getAsString(), "struct o3tl::strong_int")) {
 return;
 }
diff --git a/connectivity/source/drivers/firebird/ResultSet.cxx 
b/connectivity/source/drivers/firebird/ResultSet.cxx
index 38384282040b..d0c19c6dacf9 100644
--- 

[Libreoffice-bugs] [Bug 125806] Broken UI in Writer after pasting website contents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125806

--- Comment #5 from Xavier Van Wijmeersch  ---
For me it working

Version: 6.4.0.0.alpha0+
Build ID: adcb7bacb452dccde70b20a902f5c1f23f37913f
CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: nl-BE (en_US.UTF-8); UI-Language: en-US
Calc: threaded

Version: 6.4.0.0.alpha0+
Build ID: adcb7bacb452dccde70b20a902f5c1f23f37913f
CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: qt5; 
Locale: nl-BE (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 32500] [META] GTK style doesn't draw some elements via GTK

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=32500

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Depends on||125995


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125995
[Bug 125995] C locale is currently broken for file handling
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102495

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Depends on||125995


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125995
[Bug 125995] C locale is currently broken for file handling
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125971] Image import in KDE LibreOffice fails if filename contains non-latin characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125971

Jan-Marek Glogowski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5995

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125995] C locale is currently broken for file handling

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125995

Jan-Marek Glogowski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5971
 CC||sberg...@redhat.com
 Blocks||102495, 32500


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=32500
[Bug 32500] [META] GTK style doesn't draw some elements via GTK
https://bugs.documentfoundation.org/show_bug.cgi?id=102495
[Bug 102495] [META] KDE VCL backend bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125995] New: C locale is currently broken for file handling

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125995

Bug ID: 125995
   Summary: C locale is currently broken for file handling
   Product: LibreOffice
   Version: 6.4.0.0.alpha0+ Master
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: glo...@fbihome.de

Description:
This is the "extension" of bug 125971.

Something in the local file URL handling is currently broken when you use the C
locale, at least on all unix backends. I can't test MacOS and Windows, but
since I suspect an error in the URL handling with regard to the current locale
setting, at least MacOS might be affected too. Has Windows some equivalent of C
locale?

Steps to Reproduce:
1. Have a unicode / UTF8 file system (that's standard I guess)
2. Have a file name with non-ASCII characters (łąka.png - 'LC_ALL=C ls -b' will
show the correct UTF8 encoding \305\202\304\205ka.png)
3. Start LO with LANG=C / LC_ALL=C
4. Open the file
5. Export the file

Actual Results:
1. The file picker for "gen" shows the wrong file names. kde5 and gtk3 are
fine.
2. After opening, the window title has the file name with a wrong encoding.
3. The recent file list has the file name with wrong encoding (which actually
works!)
4. The save dialog has the wrong default name.

5. Saving the file will generate the right file name only for gen.
For gen the wrong default on save is consequently correct and it'll ask before
overwriting the existing opened file. kde5 and gtk3 will write a new file with
a - now really wrong name.

The saved file name for gtk3 and kde5 is:
\303\205\302\202\303\204\302\205ka.png. 

That's the same encoded name I would generate for the fix for bug 125971 via

OUString aNewURL =
uri::ExternalUriReferenceTranslator::create(m_xContext)->translateToInternal(toOUString(aURL.toEncoded()));

But this is actually some double encoding, because aURL.toEncoded() is already
the correctly encoded UTF8, which LO expects. And it's probably the origin of
most of the bug. 

FWIW this is the only encoding variant LO currently accepts from either kde5 or
the  gtk3 file picker.

Expected Results:
The correct filename is used everywhere, where it's now wrong in the "Actual
Results".


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs