[Libreoffice-bugs] [Bug 114760] Word Count problem with symbols in Chinese mixed with English text
https://bugs.documentfoundation.org/show_bug.cgi?id=114760 --- Comment #4 from Naruhiko Ogasawara --- Just exclude symbols to word count is enough? Or we need extra count (currently "word" count)? Now I'm digging this issue, then I would like to confirm the real problem we should fix. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126052] New: Can't drag the color picker window out of my way
https://bugs.documentfoundation.org/show_bug.cgi?id=126052 Bug ID: 126052 Summary: Can't drag the color picker window out of my way Product: LibreOffice Version: 6.0.7.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bugrepor...@gmail.com >From the highlight color button on the toolbar, you Left click on custom color. That opens a window called "Pick a color". If you click on the top bar of the window, it won't let you drag the window to the side so you can see what colors you highlighted in your document. Someone on Ubuntu suggested this was because the color picker window is modal and asked me if I would file an upstream bug report to TDF (The Document Foundation) asking if it was modal by design or not and if yes, asking is it necessary that it stays modal? Would TDF consider changing it to not be modal? (***PS I was able to shut off the modal property by installing GNOME Tweaks from a terminal window sudo apt update sudo apt gnome-tweak-tool then shutting the terminal window then opening a new terminal window and typing gnome-tweaks (to run the program) >From inside Tweaks: click on Windows turn the Attach Modal Dialogs button to "off" ***) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121655] Doesn't display contents in Print Preview in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=121655 --- Comment #5 from QA Administrators --- Dear Me, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125797] Sidebar: keyboard navigation does not skip over disabled tabs
https://bugs.documentfoundation.org/show_bug.cgi?id=125797 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81234] [META] RTF filter issues
https://bugs.documentfoundation.org/show_bug.cgi?id=81234 Bug 81234 depends on bug 117734, which changed state. Bug 117734 Summary: Columns and formatting lost when saved and reopened as RTF https://bugs.documentfoundation.org/show_bug.cgi?id=117734 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117734] Columns and formatting lost when saved and reopened as RTF
https://bugs.documentfoundation.org/show_bug.cgi?id=117734 --- Comment #9 from QA Administrators --- Dear rcdorner, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125790] Setting language via menu and then clearing direct formatting resets paragraph style
https://bugs.documentfoundation.org/show_bug.cgi?id=125790 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121651] Crash in: SwAccessibleMap::GetContext(SwFrame const *, bool)
https://bugs.documentfoundation.org/show_bug.cgi?id=121651 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121655] Doesn't display contents in Print Preview in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=121655 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117734] Columns and formatting lost when saved and reopened as RTF
https://bugs.documentfoundation.org/show_bug.cgi?id=117734 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121651] Crash in: SwAccessibleMap::GetContext(SwFrame const *, bool)
https://bugs.documentfoundation.org/show_bug.cgi?id=121651 --- Comment #3 from QA Administrators --- Dear intelati26, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118129] The implementation of the ooo.vba.excel.XWindow.Caption property getter obviously does not work as intended
https://bugs.documentfoundation.org/show_bug.cgi?id=118129 --- Comment #2 from QA Administrators --- Dear Tor Lillqvist, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34749] FORMATTING: Text field character formatting reset while undo
https://bugs.documentfoundation.org/show_bug.cgi?id=34749 --- Comment #16 from QA Administrators --- Dear sasha.libreoffice, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122146] MAILMERGE: Bulk Letter with Calc Table
https://bugs.documentfoundation.org/show_bug.cgi?id=122146 --- Comment #8 from QA Administrators --- Dear Willy, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65940] FORMATTING: Style/templates not persistent
https://bugs.documentfoundation.org/show_bug.cgi?id=65940 --- Comment #9 from QA Administrators --- Dear aw-libreoffice, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117995] Faulty page numbering sequence when using paragraph style page break
https://bugs.documentfoundation.org/show_bug.cgi?id=117995 --- Comment #5 from QA Administrators --- Dear ajlittoz, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53501] Wrong line spacing when mixing large fonts with small ones near a box
https://bugs.documentfoundation.org/show_bug.cgi?id=53501 --- Comment #10 from QA Administrators --- Dear Ingo Ruhnke, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108621] Form-Navigation: CTRL+TAB only works right with Design-Mode switched off
https://bugs.documentfoundation.org/show_bug.cgi?id=108621 --- Comment #7 from QA Administrators --- Dear robert, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44387] double shadow for rectangle / square shape
https://bugs.documentfoundation.org/show_bug.cgi?id=44387 --- Comment #14 from QA Administrators --- Dear mhofmann, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118054] Writer doesn't show the initial image before cropping in the background (like Calc/Impress/Draw)
https://bugs.documentfoundation.org/show_bug.cgi?id=118054 --- Comment #5 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118035] FORMATTING: Text-to-text alignment doesn't work in Textbox
https://bugs.documentfoundation.org/show_bug.cgi?id=118035 --- Comment #2 from QA Administrators --- Dear Wouter Klein, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118053] Weird cropping border aspect ratio
https://bugs.documentfoundation.org/show_bug.cgi?id=118053 --- Comment #4 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55049] FILEOPEN: CSV import - \" is not seen as an escaped quote, and hence interpreted as string delimiters
https://bugs.documentfoundation.org/show_bug.cgi?id=55049 --- Comment #9 from QA Administrators --- Dear Sander Bol, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92519] SVG images are wrongly embedded tens of times in FODT
https://bugs.documentfoundation.org/show_bug.cgi?id=92519 --- Comment #11 from QA Administrators --- Dear g3855563, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114251] Hang loading spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=114251 --- Comment #41 from QA Administrators --- Dear Jim Avera, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118048] Dragging a 2D object around in the presence of complex 3D object is slow and CPU hogging
https://bugs.documentfoundation.org/show_bug.cgi?id=118048 --- Comment #3 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99138] Honeycomb slide transition doesnt work
https://bugs.documentfoundation.org/show_bug.cgi?id=99138 --- Comment #13 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115904] Auto text does not properly insert field variables
https://bugs.documentfoundation.org/show_bug.cgi?id=115904 --- Comment #10 from QA Administrators --- Dear Sven Neuz (SERPENTEQ), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
CppCheck Report Update
A new cppcheck report is available at : http://dev-builds.libreoffice.org/cppcheck_reports/master/ Note: The script generating this report was run at : 2019-23-06 03:16:02 with user buildslave at host vm140 as /home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s /home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w /home/buildslave/tmp/www It can be found and improved here: https://gerrit.libreoffice.org/plugins/gitiles/dev-tools/+/master/cppcheck/cppcheck-report.sh ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 45904] move java based api tests to c++
https://bugs.documentfoundation.org/show_bug.cgi?id=45904 --- Comment #322 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/8567d3d2567e83d1a8769651295384cfe5d68ce1%5E%21 tdf#45904 Move XIndexAccess Java tests to C++ It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: qadevOOo/objdsc sc/qa
qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTabViewObj.csv |2 --
sc/qa/extras/sctabviewobj.cxx|7 +++
2 files changed, 7 insertions(+), 2 deletions(-)
New commits:
commit 8567d3d2567e83d1a8769651295384cfe5d68ce1
Author: Jens Carl
AuthorDate: Sat Jun 22 13:34:05 2019 -0700
Commit: Jens Carl
CommitDate: Sun Jun 23 02:30:34 2019 +0200
tdf#45904 Move XIndexAccess Java tests to C++
Move XIndexAccess Java tests to C++ for ScTabViewObj.
Change-Id: Ic3364f405e4e4c42443a7f439a257ed6328f32a8
Reviewed-on: https://gerrit.libreoffice.org/74586
Tested-by: Jenkins
Reviewed-by: Jens Carl
diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTabViewObj.csv
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTabViewObj.csv
index eee960dcfa3e..ffd0cf5a2114 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTabViewObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTabViewObj.csv
@@ -1,5 +1,3 @@
-"ScTabViewObj";"com::sun::star::container::XIndexAccess";"getCount()"
-"ScTabViewObj";"com::sun::star::container::XIndexAccess";"getByIndex()"
"ScTabViewObj";"com::sun::star::lang::XComponent";"dispose()"
"ScTabViewObj";"com::sun::star::lang::XComponent";"addEventListener()"
"ScTabViewObj";"com::sun::star::lang::XComponent";"removeEventListener()"
diff --git a/sc/qa/extras/sctabviewobj.cxx b/sc/qa/extras/sctabviewobj.cxx
index 14b46abc725e..fef454f8899a 100644
--- a/sc/qa/extras/sctabviewobj.cxx
+++ b/sc/qa/extras/sctabviewobj.cxx
@@ -9,6 +9,7 @@
#include
#include
+#include
#include
#include
#include
@@ -35,6 +36,7 @@ class ScTabViewObj : public CalcUnoApiTest,
public apitest::XActivationBroadcaster,
public apitest::XCellRangeReferrer,
public apitest::XEnumerationAccess,
+ public apitest::XIndexAccess,
public apitest::XSpreadsheetView,
public apitest::XViewFreezable,
public apitest::XViewSplitable
@@ -63,6 +65,10 @@ public:
// XEnumerationAccess
CPPUNIT_TEST(testCreateEnumeration);
+// XIndexAccess
+CPPUNIT_TEST(testGetByIndex);
+CPPUNIT_TEST(testGetCount);
+
// XSpreadsheetView
CPPUNIT_TEST(testGetSetActiveSheet);
@@ -80,6 +86,7 @@ private:
ScTabViewObj::ScTabViewObj()
: CalcUnoApiTest("/sc/qa/extras/testdocuments")
+, XIndexAccess(1)
{
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120946] [META] Karasa Jaga icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120946 Bug 120946 depends on bug 107144, which changed state. Bug 107144 Summary: CALC: Add icon for Show Comment on/off text button and change icon for Show Comments on/off and rename existing buttons https://bugs.documentfoundation.org/show_bug.cgi?id=107144 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122247] [META] Icon requests
https://bugs.documentfoundation.org/show_bug.cgi?id=122247 Bug 122247 depends on bug 107144, which changed state. Bug 107144 Summary: CALC: Add icon for Show Comment on/off text button and change icon for Show Comments on/off and rename existing buttons https://bugs.documentfoundation.org/show_bug.cgi?id=107144 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107139] [META] Breeze icons
https://bugs.documentfoundation.org/show_bug.cgi?id=107139 Bug 107139 depends on bug 107144, which changed state. Bug 107144 Summary: CALC: Add icon for Show Comment on/off text button and change icon for Show Comments on/off and rename existing buttons https://bugs.documentfoundation.org/show_bug.cgi?id=107144 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117497] [META] Colibre icons
https://bugs.documentfoundation.org/show_bug.cgi?id=117497 Bug 117497 depends on bug 107144, which changed state. Bug 107144 Summary: CALC: Add icon for Show Comment on/off text button and change icon for Show Comments on/off and rename existing buttons https://bugs.documentfoundation.org/show_bug.cgi?id=107144 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120949] [META] Elementary icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120949 Bug 120949 depends on bug 107144, which changed state. Bug 107144 Summary: CALC: Add icon for Show Comment on/off text button and change icon for Show Comments on/off and rename existing buttons https://bugs.documentfoundation.org/show_bug.cgi?id=107144 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101216] [META] Calc comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101216 Bug 101216 depends on bug 107144, which changed state. Bug 107144 Summary: CALC: Add icon for Show Comment on/off text button and change icon for Show Comments on/off and rename existing buttons https://bugs.documentfoundation.org/show_bug.cgi?id=107144 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125965] [META] Sifr icons
https://bugs.documentfoundation.org/show_bug.cgi?id=125965 Bug 125965 depends on bug 107144, which changed state. Bug 107144 Summary: CALC: Add icon for Show Comment on/off text button and change icon for Show Comments on/off and rename existing buttons https://bugs.documentfoundation.org/show_bug.cgi?id=107144 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107144] CALC: Add icon for Show Comment on/off text button and change icon for Show Comments on/off and rename existing buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=107144 Rizal Muttaqin changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126044] Colibre icon for insert -> Field -> Field name in Draw/Impress is a but confusing (file open icon)
https://bugs.documentfoundation.org/show_bug.cgi?id=126044 Rizal Muttaqin changed: What|Removed |Added Blocks||117497 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=117497 [Bug 117497] [META] Colibre icons -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117497] [META] Colibre icons
https://bugs.documentfoundation.org/show_bug.cgi?id=117497 Rizal Muttaqin changed: What|Removed |Added Depends on||126044 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=126044 [Bug 126044] Colibre icon for insert -> Field -> Field name in Draw/Impress is a but confusing (file open icon) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122924] Wrong placement of last_custom_common_grey.png in Colibre icon theme
https://bugs.documentfoundation.org/show_bug.cgi?id=122924 Rizal Muttaqin changed: What|Removed |Added Blocks||117497 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=117497 [Bug 117497] [META] Colibre icons -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117497] [META] Colibre icons
https://bugs.documentfoundation.org/show_bug.cgi?id=117497 Rizal Muttaqin changed: What|Removed |Added Depends on||122924 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122924 [Bug 122924] Wrong placement of last_custom_common_grey.png in Colibre icon theme -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126051] FORMATTING: Negative margins when boundary values are used between page and header/footer margins.
https://bugs.documentfoundation.org/show_bug.cgi?id=126051 --- Comment #1 from Andreas N --- Created attachment 152354 --> https://bugs.documentfoundation.org/attachment.cgi?id=152354=edit Short video that goes through the steps to reproduce the issue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126051] New: FORMATTING: Negative margins when boundary values are used between page and header/footer margins.
https://bugs.documentfoundation.org/show_bug.cgi?id=126051 Bug ID: 126051 Summary: FORMATTING: Negative margins when boundary values are used between page and header/footer margins. Product: LibreOffice Version: 6.2.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: qa.software.tester.anielsen+...@gmail.com Description: Version: 6.2.4.2 (x64) Build ID: 2412653d852ce75f65fbfa83fb7e7b669a126d64 CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: CL Setting the page margins to outside of the print range, and maximizing the header/footer margins, then switching between the tabs sets the fields to negative values. Applying the changes pushes the content off the page. Using the replication steps, this issue can be repeated with the Footer tab (instead of Header), and you can use the right margin instead of the left as well (although the content will be pushed off to the other side of the page). I’d consider this an edge case as it would be very unlikely that anyone with good intentions would go anywhere near those margin values. Steps to Reproduce: 1. Open new LibreOffice document 2. Click on Format > Page … > Page tab 3. Set the Left Margin value to 0 4. Click on the Header tab 5. When prompted about margin being out of print range, click yes. 6. Toggle Header on. 7. Set the Left Margin to (anything beyond the current margin limit) 8. Click on the Page tab. 9. See the value for Left Margin is now negative. 10. Click on Header tab again. 11. See Left Margin now negative, and preview shows content area far off the page. 12. Click OK (to accept edits and close the window). 13. Try to type things in header or main content area. No text appears, but character count increases. Actual Results: Margins automatically got set to negative values. Text does not appear anywhere, but word count increases as you type. Expected Results: Margins should never be negative and cause text to appear outside of view. Reproducible: Always User Profile Reset: No Additional Info: I will attach a short video that goes through the steps and gives a visual overview of the issue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117967] On Linux LibreOffice doesn't protect users from accidental content overwrite when a file was updated outside of LibreOffice and the warning dialog was cancelled out of
https://bugs.documentfoundation.org/show_bug.cgi?id=117967 --- Comment #6 from yury.dubin...@gmail.com --- I re-tested per your suggestion. I installed 6.2.4. Unfortunately, this behaviour was not changed. There are steps that I performed. 1. Create a text document. (Or any other LO file) 2. Create in another directory a soft link to this file. 3. In any file manager click the original file and the link. LO will open the file and the link in two separate windows. 4. Make a change in one window and save it. 5. Make a change in another window and try to save. You will receive the pop-up warning with two options: save anyway or cancel. Press Cancel and then save again. The content of the file will be overwritten. To avoid this problem, we need to check the file timestamp before each save, and not just the first time we try to save. In addition, most editors check the timestamp every time the window becomes active. Then users will be informed before they start changing the content. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107385] Autofilter sorting breaks rows data alignment without warning
https://bugs.documentfoundation.org/show_bug.cgi?id=107385 --- Comment #6 from Jean-Baptiste Faure --- I do not see this behavior as a bug. It is up to the user to select all the columns that are linked. In case you can have several independent blocks of data sharing the same rows, it's clear that Calc can't know what columns are linked to the column in which the sort is performed. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - include/vcl vcl/source
include/vcl/tabctrl.hxx|2
vcl/source/control/tabctrl.cxx | 83 ++---
2 files changed, 46 insertions(+), 39 deletions(-)
New commits:
commit 84d1c29495f8684e390a6d56ae328eea101e5dca
Author: Jan-Marek Glogowski
AuthorDate: Thu Jun 20 13:41:53 2019 +
Commit: Jan-Marek Glogowski
CommitDate: Sat Jun 22 23:17:22 2019 +0200
VCL constify ImplTabItem::m_nId
I actually wanted to simply make it const, but emplace needs to
copy / move these classes, which gets ugly with const members. So
this simply hides the value and adds an ro-accessor.
Change-Id: If8ec6bc25bc6a7d012b7197b1fcb8c200693744d
Reviewed-on: https://gerrit.libreoffice.org/74481
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit ac7fe279c497076ef07b20a90c6189cfbc65d3e3)
Reviewed-on: https://gerrit.libreoffice.org/74579
diff --git a/include/vcl/tabctrl.hxx b/include/vcl/tabctrl.hxx
index 956c5ece7a6b..bbbc3842463b 100644
--- a/include/vcl/tabctrl.hxx
+++ b/include/vcl/tabctrl.hxx
@@ -27,7 +27,7 @@
#include
#include
-struct ImplTabItem;
+class ImplTabItem;
struct ImplTabCtrlData;
class TabPage;
class ListBox;
diff --git a/vcl/source/control/tabctrl.cxx b/vcl/source/control/tabctrl.cxx
index 9b269e8ef66c..190cb218b6be 100644
--- a/vcl/source/control/tabctrl.cxx
+++ b/vcl/source/control/tabctrl.cxx
@@ -44,9 +44,11 @@
#include
#include
-struct ImplTabItem
+class ImplTabItem final
{
-sal_uInt16 mnId;
+sal_uInt16 m_nId;
+
+public:
VclPtr mpTabPage;
OUStringmaText;
OUStringmaFormatText;
@@ -60,14 +62,20 @@ struct ImplTabItem
boolm_bVisible; ///< the tab / page can be visible
Image maTabImage;
-ImplTabItem()
-: mnId( 0 ), mpTabPage( nullptr ),
- mnLine( 0 ), mbFullVisible( false )
-, m_bEnabled(true)
-, m_bVisible(true)
-{}
+ImplTabItem(sal_uInt16 nId);
+
+sal_uInt16 id() const { return m_nId; }
};
+ImplTabItem::ImplTabItem(sal_uInt16 nId)
+: m_nId(nId)
+, mnLine(0)
+, mbFullVisible(false)
+, m_bEnabled(true)
+, m_bVisible(true)
+{
+}
+
struct ImplTabCtrlData
{
std::unordered_map< int, int >maLayoutPageIdToLine;
@@ -209,7 +217,7 @@ ImplTabItem* TabControl::ImplGetItem( sal_uInt16 nId ) const
{
for (auto & item : mpTabCtrlData->maItemList)
{
-if( item.mnId == nId )
+if (item.id() == nId)
return
}
@@ -437,7 +445,7 @@ bool TabControl::ImplPlaceTabs( long nWidth )
nLineWidthAry[nLines] += aSize.Width();
nX += aSize.Width();
-if ( item.mnId == mnCurPageId )
+if (item.id() == mnCurPageId)
nCurLine = nLines;
++nPos;
@@ -797,7 +805,7 @@ void TabControl::ImplDrawItem(vcl::RenderContext&
rRenderContext, ImplTabItem co
nOff = 0;
// if this is the active Page, we have to draw a little more
-if (pItem->mnId == mnCurPageId)
+if (pItem->id() == mnCurPageId)
{
nOff2 = 2;
if (!ImplGetSVData()->maNWFData.mbNoActiveTabTextRaise)
@@ -827,7 +835,7 @@ void TabControl::ImplDrawItem(vcl::RenderContext&
rRenderContext, ImplTabItem co
ControlState nState = ControlState::NONE;
-if (pItem->mnId == mnCurPageId)
+if (pItem->id() == mnCurPageId)
{
nState |= ControlState::SELECTED;
// only the selected item can be focused
@@ -1023,7 +1031,7 @@ void TabControl::MouseButtonDown( const MouseEvent& rMEvt
)
ImplTabItem *pItem = ImplGetItem(rMEvt.GetPosPixel());
if (pItem && pItem->m_bEnabled)
-SelectTabPage(pItem->mnId);
+SelectTabPage(pItem->id());
}
void TabControl::KeyInput( const KeyEvent& rKEvt )
@@ -1069,7 +1077,7 @@ void TabControl::Paint( vcl::RenderContext&
rRenderContext, const tools::Rectang
ImplTabItem* pCurItem = nullptr;
for (auto & item : mpTabCtrlData->maItemList)
{
-if (item.mnId == mnCurPageId)
+if (item.id() == mnCurPageId)
{
pCurItem =
break;
@@ -1434,10 +1442,10 @@ void TabControl::Command( const CommandEvent& rCEvt )
ScopedVclPtrInstance aMenu;
for (auto const& item : mpTabCtrlData->maItemList)
{
-aMenu->InsertItem( item.mnId, item.maText,
MenuItemBits::CHECKABLE | MenuItemBits::RADIOCHECK );
-if ( item.mnId == mnCurPageId )
-aMenu->CheckItem( item.mnId );
-aMenu->SetHelpId( item.mnId, item.maHelpId );
+aMenu->InsertItem(item.id(), item.maText,
MenuItemBits::CHECKABLE | MenuItemBits::RADIOCHECK);
+if (item.id() == mnCurPageId)
+aMenu->CheckItem(item.id());
+aMenu->SetHelpId(item.id(), item.maHelpId);
}
sal_uInt16 nId = aMenu->Execute( this,
[Libreoffice-bugs] [Bug 104717] Repeated copy/paste is broken in Calc for KDE plasma "Clipboard contents" setting "Synchronize contents of the clipboard and the selection"
https://bugs.documentfoundation.org/show_bug.cgi?id=104717 --- Comment #17 from Jan-Marek Glogowski --- I just realized that there is currently an other uncommon behavior. Calc clears the PRIMARY when you remove a selection. So you select some cells in Calc, and the PRIMARY gets updated, then remove that selection by clicking somewhere else or using the arrow keys and Calc clears the PRIMARY. Normally an app / your text editor wouldn't clear the PRIMARY, just replace it when something else is selected. You can copy something empty to the CLIPBOARD but not the PRIMARY, as you can't select nothing, just unselect. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104717] Repeated copy/paste is broken in Calc for KDE plasma "Clipboard contents" setting "Synchronize contents of the clipboard and the selection"
https://bugs.documentfoundation.org/show_bug.cgi?id=104717 --- Comment #16 from Jan-Marek Glogowski --- Just to make it clear. After the first paste the selection is set correct, so even if the clipboard manager destroys the clipboard from the selection, you could now use the middle mouse button to "paste" cells. Not very obvious. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: qadevOOo/objdsc
qadevOOo/objdsc/sc/com.sun.star.comp.office.ScShapeObj.csv |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f7a6b7a82469f2b4bd6cec3e7aa697aefd5775b7 Author: Jens Carl AuthorDate: Thu Jun 20 23:25:31 2019 -0700 Commit: Jens Carl CommitDate: Sat Jun 22 21:52:09 2019 +0200 tdf#45904 Correct mishap with removed converted tests Deleted the wrong test and also forgot to remove a test with commit 0e73f9eb4157. Change-Id: I31257908e935b2130c46436e8d5425bc058b21c5 Reviewed-on: https://gerrit.libreoffice.org/74484 Tested-by: Jenkins Reviewed-by: Jens Carl diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScShapeObj.csv b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScShapeObj.csv index be9506938cdc..5c145a956d1b 100644 --- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScShapeObj.csv +++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScShapeObj.csv @@ -15,4 +15,4 @@ "ScShapeObj";"com::sun::star::beans::XPropertySet";"addPropertyChangeListener()" "ScShapeObj";"com::sun::star::beans::XPropertySet";"removePropertyChangeListener()" "ScShapeObj";"com::sun::star::beans::XPropertySet";"addVetoableChangeListener()" -"ScShapeObj";"com::sun::star::drawing::XShape";"setSize()" +"ScShapeObj";"com::sun::star::beans::XPropertySet";"removeVetoableChangeListener()" ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 45904] move java based api tests to c++
https://bugs.documentfoundation.org/show_bug.cgi?id=45904 --- Comment #321 from Commit Notification --- Jens Carl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/f7a6b7a82469f2b4bd6cec3e7aa697aefd5775b7%5E%21 tdf#45904 Correct mishap with removed converted tests It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126039] Dimension line Dimensions dialog preview shows traces when values updated
https://bugs.documentfoundation.org/show_bug.cgi?id=126039 Caolán McNamara changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125803] UI: checkbox in menu not updated immediately when set with space bar (gtk3)
https://bugs.documentfoundation.org/show_bug.cgi?id=125803 Caolán McNamara changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | --- Comment #4 from Caolán McNamara --- yeah, correct way to do this is probably quite a bit of work, but deactivating the menu hierarchy regardless of what got activated is easy. Won't do anything in the unity case though, but that's a goner I think. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126036] Inconsistent arrangement of dialog buttons (and inconsistency in availability of certain buttons)
https://bugs.documentfoundation.org/show_bug.cgi?id=126036 Caolán McNamara changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #9 from Caolán McNamara --- a) page style dialog now has 'reset' back b) insert section should be consistent in ordering with everything else c) options dialog should be consistent in ordering with everything else d) table properties is unchanged, no idea whether it should have an 'apply' or not. It never did though FWIW. Possibly there's scope for an additional feature request bug for that if someone else wants to follow that up -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: cui/source cui/uiconfig sw/uiconfig
cui/source/options/treeopt.cxx|3
cui/uiconfig/ui/optionsdialog.ui | 119 +-
sw/uiconfig/swriter/ui/insertsectiondialog.ui | 33 +++
3 files changed, 82 insertions(+), 73 deletions(-)
New commits:
commit 38f1412294e7d2987072a2e211e1f68c197f16fa
Author: Caolán McNamara
AuthorDate: Sat Jun 22 18:47:46 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jun 22 21:38:35 2019 +0200
Related: tdf#126036 give options dialog consistent button order
its not welded yet, but skip ahead and give it explicit consistent
button order in the meantime
Change-Id: Ia850a024cb5a87b9231b5ffdec701646d7014e08
Reviewed-on: https://gerrit.libreoffice.org/74573
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/source/options/treeopt.cxx b/cui/source/options/treeopt.cxx
index 93b53e01005c..31c5e0400615 100644
--- a/cui/source/options/treeopt.cxx
+++ b/cui/source/options/treeopt.cxx
@@ -490,6 +490,9 @@ struct OptionsGroupInfo
void OfaTreeOptionsDialog::InitWidgets()
{
+VclButtonBox *pButtonBox = get_action_area();
+pButtonBox->sort_native_button_order();
+
get(pOkPB, "ok");
get(pApplyPB, "apply");
get(pBackPB, "revert");
diff --git a/cui/uiconfig/ui/optionsdialog.ui b/cui/uiconfig/ui/optionsdialog.ui
index 8baa0d609b12..9d7b4ff2df39 100644
--- a/cui/uiconfig/ui/optionsdialog.ui
+++ b/cui/uiconfig/ui/optionsdialog.ui
@@ -1,5 +1,5 @@
-
+
@@ -10,6 +10,9 @@
6
Options
dialog
+
+
+
False
@@ -17,38 +20,32 @@
True
vertical
12
-
-
-True
+
+
False
-True
-True
-6
+end
-
+
+gtk-help
True
True
-True
-
-
-
+True
+True
False
True
0
+True
-
+
+gtk-revert-to-saved
True
-False
-True
-True
-vertical
-
-
-
+True
+True
+True
False
@@ -56,50 +53,39 @@
1
-
-
-False
-True
-0
-
-
-
-
-False
-end
-
-gtk-ok
+
+gtk-apply
True
True
-True
-True
True
True
False
True
-0
+2
-
-gtk-cancel
+
+gtk-ok
True
True
+True
+True
True
True
False
True
-1
+3
-
-gtk-help
+
+gtk-cancel
True
True
True
@@ -108,53 +94,70 @@
False
True
-2
-True
+4
+
+
+False
+True
+end
+1
+
+
+
+
+True
+False
+True
+True
+6
-
-gtk-apply
+
True
True
-True
-True
+True
+
+
+
False
True
-3
+0
-
-gtk-revert-to-saved
+
True
-True
-True
-True
+False
+True
+True
+vertical
+
+
+
False
True
-4
+1
[Libreoffice-ux-advise] [Bug 126036] Inconsistent arrangement of dialog buttons (and inconsistency in availability of certain buttons)
https://bugs.documentfoundation.org/show_bug.cgi?id=126036 --- Comment #8 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/38f1412294e7d2987072a2e211e1f68c197f16fa%5E%21 Related: tdf#126036 give options dialog consistent button order It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: emfio/source
emfio/source/reader/emfreader.cxx | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
New commits:
commit 33150fd592162f8f3de835b42176ad87d6ad58fe
Author: Caolán McNamara
AuthorDate: Sat Jun 22 18:39:16 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jun 22 21:38:18 2019 +0200
Resolves; ofz#15426 Integer-overflow
Change-Id: I43ac26058a98a85fc09321a93e29dbeb151f5069
Reviewed-on: https://gerrit.libreoffice.org/74572
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/emfio/source/reader/emfreader.cxx
b/emfio/source/reader/emfreader.cxx
index 51a8a6fb029b..6a974085d887 100644
--- a/emfio/source/reader/emfreader.cxx
+++ b/emfio/source/reader/emfreader.cxx
@@ -1360,14 +1360,16 @@ namespace emfio
if(!aBitmapEx.IsEmpty())
{
// test if it is sensible to crop
-if ( ( cxSrc > 0 ) && ( cySrc > 0 ) &&
-( xSrc >= 0 ) && ( ySrc >= 0 ) &&
-( xSrc + cxSrc <
aBitmapEx.GetSizePixel().Width() ) &&
-( ySrc + cySrc <
aBitmapEx.GetSizePixel().Height() ) )
+if (cxSrc > 0 && cySrc > 0 && xSrc >= 0 &&
ySrc >= 0)
{
-const tools::Rectangle aCropRect(
Point( xSrc, ySrc ), Size( cxSrc, cySrc ) );
-
-aBitmapEx.Crop( aCropRect );
+sal_Int32 xEndSrc;
+sal_Int32 yEndSrc;
+if (!o3tl::checked_add(xSrc, cxSrc,
xEndSrc) && xEndSrc < aBitmapEx.GetSizePixel().Width() &&
+!o3tl::checked_add(ySrc, cySrc,
yEndSrc) && yEndSrc < aBitmapEx.GetSizePixel().Height())
+{
+const tools::Rectangle aCropRect(
Point( xSrc, ySrc ), Size( cxSrc, cySrc ) );
+aBitmapEx.Crop( aCropRect );
+}
}
#ifdef DBG_UTIL
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 123779] KDE: Tooltip when entering a formula in cell hides cell
https://bugs.documentfoundation.org/show_bug.cgi?id=123779 Michael Weghorn changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #7 from Michael Weghorn --- Verified with Version: 6.4.0.0.alpha0+ Build ID: a2dad3e10ada8adcc9b5bdb60d3d516e33aa3f07 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: kde5; Locale: en-GB (en_GB.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106070] RTF IO open file error
https://bugs.documentfoundation.org/show_bug.cgi?id=106070 Aron Budea changed: What|Removed |Added Keywords|notBibisectable |preBibisect --- Comment #7 from Aron Budea --- (In reply to Aron Budea from comment #3) > Also an error in earliest commit of 43max repo, setting keyword > notBibisectable. I meant bibisect-43all, and the correct keyword is preBibisect. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111851] FILEOPEN: RTF: table's shading ignored
https://bugs.documentfoundation.org/show_bug.cgi?id=111851 Aron Budea changed: What|Removed |Added Keywords|notBibisectable |preBibisect Summary|FILEOPEN: RTF: table's |FILEOPEN: RTF: table's |shadow ignored |shading ignored --- Comment #6 from Aron Budea --- (In reply to Aron Budea from comment #3) > Alredy buggy in 3.5.0.3. And in oldest of bibisect-43all, the correct keyword is preBibisect. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style
https://bugs.documentfoundation.org/show_bug.cgi?id=105884 Commit Notification changed: What|Removed |Added Whiteboard|target:6.4.0|target:6.4.0 target:6.3.0.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style
https://bugs.documentfoundation.org/show_bug.cgi?id=105884 --- Comment #18 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/466cc6c63c4020519d47ec442739f22d7779e901%5E%21 tdf#105884 Qt5 implement TabControl theming It will be available in 6.3.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - include/vcl vcl/qt5 vcl/source
include/vcl/salnativewidgets.hxx | 26 +++
vcl/qt5/Qt5Graphics_Controls.cxx | 81 ++-
vcl/source/control/tabctrl.cxx | 31 +
vcl/source/outdev/nativecontrols.cxx | 19 +++-
4 files changed, 145 insertions(+), 12 deletions(-)
New commits:
commit 466cc6c63c4020519d47ec442739f22d7779e901
Author: Jan-Marek Glogowski
AuthorDate: Thu Jun 20 13:00:58 2019 +
Commit: Jan-Marek Glogowski
CommitDate: Sat Jun 22 20:53:22 2019 +0200
tdf#105884 Qt5 implement TabControl theming
Drawing a QTabWidget is a really complex procedure. The main
problems I had were the adjustment of the frame, which I totally
missed in the Qt code for a long time.
Then there is the frame gap, which Qt draws by simply overlapping
the items a bit with the frame. And all the calculations need the
tabs together with the pane. None of it really fits very good into
the way VCL handles drawing the TabControl and since I needed a
way back from the plugin into VCL for the nOverlap value, there is
this hack using a static. I hope nOverlap never changes.
Change-Id: I8fe6eb12d39a2ac7f6fb89424586cac76e12545b
Reviewed-on: https://gerrit.libreoffice.org/74480
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit 430b406e5e8249983fc030aa0f867372f5da74d2)
Reviewed-on: https://gerrit.libreoffice.org/74575
diff --git a/include/vcl/salnativewidgets.hxx b/include/vcl/salnativewidgets.hxx
index 03d9a0eee00e..2a67ceb47b24 100644
--- a/include/vcl/salnativewidgets.hxx
+++ b/include/vcl/salnativewidgets.hxx
@@ -181,6 +181,9 @@ enum class ControlPart
// hardcoded 2 pixel overlap between adjacent tabs
TabsDrawRtl = 3000,
+// Qt doesn't have a separate header to draw
+TabPaneWithHeader = 3001,
+
// For themes that do not want to have the focus
// rectangle part drawn by VCL but take care of the
// whole inner control part by themselves
@@ -340,6 +343,29 @@ class VCL_DLLPUBLIC SliderValue : public ImplControlValue
SliderValue & operator =(SliderValue &&) = delete; // due to
ImplControlValue
};
+class VCL_DLLPUBLIC TabPaneValue : public ImplControlValue
+{
+public:
+tools::Rectangle m_aTabHeaderRect;
+tools::Rectangle m_aSelectedTabRect;
+// increased tab size, so it'll overlab the frame rect when draing
+// static value, as there is currently no sane way to return additional
data
+static int m_nOverlap;
+
+TabPaneValue(const tools::Rectangle , const
tools::Rectangle )
+: ImplControlValue(ControlType::TabPane, 0)
+, m_aTabHeaderRect(rTabHeaderRect)
+, m_aSelectedTabRect(rSelectedTabRect)
+{
+}
+TabPaneValue* clone() const override;
+
+TabPaneValue(TabPaneValue const &) = default;
+TabPaneValue(TabPaneValue &&) = default;
+TabPaneValue & operator =(TabPaneValue const &) = delete;
+TabPaneValue & operator =(TabPaneValue &&) = delete;
+};
+
/* TabitemValue:
*
* Value container for tabitems.
diff --git a/vcl/qt5/Qt5Graphics_Controls.cxx b/vcl/qt5/Qt5Graphics_Controls.cxx
index c8f706901ae7..32a376a388b7 100644
--- a/vcl/qt5/Qt5Graphics_Controls.cxx
+++ b/vcl/qt5/Qt5Graphics_Controls.cxx
@@ -105,6 +105,10 @@ bool
Qt5Graphics_Controls::IsNativeControlSupported(ControlType type, ControlPar
case ControlType::Slider:
return (part == ControlPart::TrackHorzArea || part ==
ControlPart::TrackVertArea);
+case ControlType::TabItem:
+case ControlType::TabPane:
+return ((part == ControlPart::Entire) || part ==
ControlPart::TabPaneWithHeader);
+
default:
break;
}
@@ -112,7 +116,6 @@ bool
Qt5Graphics_Controls::IsNativeControlSupported(ControlType type, ControlPar
return false;
}
-/// helper drawing methods
namespace
{
void draw(QStyle::ControlElement element, QStyleOption* option, QImage* image,
@@ -163,6 +166,27 @@ void lcl_drawFrame(QStyle::PrimitiveElement element,
QImage* image, QStyle::Stat
painter.setClipRegion(QRegion(aRect).subtracted(aRect.adjusted(fw, fw,
-fw, -fw)));
QApplication::style()->drawPrimitive(element, , );
}
+
+void lcl_fillQStyleOptionTab(const ImplControlValue& value, QStyleOptionTab&
sot)
+{
+const TabitemValue& rValue = static_cast(value);
+if (rValue.isFirst())
+sot.position = rValue.isLast() ? QStyleOptionTab::OnlyOneTab :
QStyleOptionTab::Beginning;
+else if (rValue.isLast())
+sot.position = rValue.isFirst() ? QStyleOptionTab::OnlyOneTab :
QStyleOptionTab::End;
+else
+sot.position = QStyleOptionTab::Middle;
+}
+
+void lcl_fullQStyleOptionTabWidgetFrame(QStyleOptionTabWidgetFrame& option)
+{
+option.state = QStyle::State_Enabled;
+option.rightCornerWidgetSize = QSize(0, 0);
+option.leftCornerWidgetSize = QSize(0, 0);
+option.lineWidth =
[Libreoffice-bugs] [Bug 119803] FILEOPEN Table in frame in DOC not displayed in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=119803 Aron Budea changed: What|Removed |Added Keywords|notBibisectable |preBibisect --- Comment #4 from Aron Budea --- (In reply to Aron Budea from comment #2) > Bibisected the second change to the following commit with repo > bibisect-44max. > The first change occurs before 3.4 => notBibisectable The correct keyword for that is preBibisect. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - vcl/inc vcl/qt5
vcl/inc/qt5/Qt5Frame.hxx |3 ---
vcl/inc/qt5/Qt5Widget.hxx |3 ---
vcl/qt5/Qt5Frame.cxx | 10 +-
vcl/qt5/Qt5Widget.cxx |7 ---
4 files changed, 5 insertions(+), 18 deletions(-)
New commits:
commit e3988fa785c0430ae708527cbc5a7baa6d9d55a6
Author: Jan-Marek Glogowski
AuthorDate: Sat Jun 22 02:25:24 2019 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sat Jun 22 20:17:19 2019 +0200
Qt5 directly show tooltips + respect the help area
I'm not sure why this redirection was implemented, which also ommited
the provided help area. I tried hard to use vc::Window code in the
beginning, but that also mirrors the cursor position for the window.
Using Qt here is simply straight forward, so just do that,
Change-Id: Ia8c4efc1e43b915c4b071ee26d4da37d7580817c
Reviewed-on: https://gerrit.libreoffice.org/74548
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit ab5f341efd144adb6b7d0e00fece76a2153acd10)
Reviewed-on: https://gerrit.libreoffice.org/74571
diff --git a/vcl/inc/qt5/Qt5Frame.hxx b/vcl/inc/qt5/Qt5Frame.hxx
index d7f8f1aa6e1f..5b1bc1025445 100644
--- a/vcl/inc/qt5/Qt5Frame.hxx
+++ b/vcl/inc/qt5/Qt5Frame.hxx
@@ -133,9 +133,6 @@ class VCLPLUG_QT5_PUBLIC Qt5Frame : public QObject, public
SalFrame
void TriggerPaintEvent();
void TriggerPaintEvent(QRect aRect);
-Q_SIGNALS:
-void tooltipRequest(const OUString& rTooltip);
-
public:
Qt5Frame(Qt5Frame* pParent, SalFrameStyleFlags nSalFrameStyle, bool
bUseCairo);
virtual ~Qt5Frame() override;
diff --git a/vcl/inc/qt5/Qt5Widget.hxx b/vcl/inc/qt5/Qt5Widget.hxx
index 8ead4b3ec945..85523951cda2 100644
--- a/vcl/inc/qt5/Qt5Widget.hxx
+++ b/vcl/inc/qt5/Qt5Widget.hxx
@@ -70,9 +70,6 @@ class Qt5Widget : public QWidget
void inputMethodEvent(QInputMethodEvent*) override;
QVariant inputMethodQuery(Qt::InputMethodQuery) const override;
-public slots:
-static void showTooltip(const OUString& rTip);
-
public:
Qt5Widget(Qt5Frame& rFrame, Qt::WindowFlags f = Qt::WindowFlags());
diff --git a/vcl/qt5/Qt5Frame.cxx b/vcl/qt5/Qt5Frame.cxx
index b009847456e7..20cb4483295c 100644
--- a/vcl/qt5/Qt5Frame.cxx
+++ b/vcl/qt5/Qt5Frame.cxx
@@ -155,9 +155,6 @@ Qt5Frame::Qt5Frame(Qt5Frame* pParent, SalFrameStyleFlags
nStyle, bool bUseCairo)
else
m_pQWidget = new Qt5Widget(*this, aWinFlags);
-connect(this, ::tooltipRequest,
static_cast(m_pQWidget),
-::showTooltip);
-
if (pParent && !(pParent->m_nStyle & SalFrameStyleFlags::PLUG))
{
QWindow* pParentWindow =
pParent->GetQWidget()->window()->windowHandle();
@@ -743,9 +740,12 @@ void Qt5Frame::Flush()
// destroyed, so that state should be safely flushed.
}
-bool Qt5Frame::ShowTooltip(const OUString& rText, const tools::Rectangle&
/*rHelpArea*/)
+bool Qt5Frame::ShowTooltip(const OUString& rText, const tools::Rectangle&
rHelpArea)
{
-emit tooltipRequest(rText);
+QRect aHelpArea(toQRect(rHelpArea));
+if (QGuiApplication::isRightToLeft())
+aHelpArea.moveLeft(maGeometry.nWidth - aHelpArea.width() -
aHelpArea.left() - 1);
+QToolTip::showText(QCursor::pos(), toQString(rText), m_pQWidget,
aHelpArea);
return true;
}
diff --git a/vcl/qt5/Qt5Widget.cxx b/vcl/qt5/Qt5Widget.cxx
index 3b4c114a0a45..8dca7aa03001 100644
--- a/vcl/qt5/Qt5Widget.cxx
+++ b/vcl/qt5/Qt5Widget.cxx
@@ -40,7 +40,6 @@
#include
#include
#include
-#include
#include
#include
@@ -502,12 +501,6 @@ void Qt5Widget::focusOutEvent(QFocusEvent*)
m_rFrame.CallCallback(SalEvent::LoseFocus, nullptr);
}
-void Qt5Widget::showTooltip(const OUString& rTooltip)
-{
-QPoint pt = QCursor::pos();
-QToolTip::showText(pt, toQString(rTooltip));
-}
-
Qt5Widget::Qt5Widget(Qt5Frame& rFrame, Qt::WindowFlags f)
: QWidget(Q_NULLPTR, f)
, m_rFrame(rFrame)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 123779] KDE: Tooltip when entering a formula in cell hides cell
https://bugs.documentfoundation.org/show_bug.cgi?id=123779 --- Comment #6 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/dd0bca3ac7ad2e498ba420718df703f651efdc21%5E%21 tdf#123779 Qt5 correctly fill Qt5Frame::maGeometry It will be available in 6.3.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123779] KDE: Tooltip when entering a formula in cell hides cell
https://bugs.documentfoundation.org/show_bug.cgi?id=123779 Commit Notification changed: What|Removed |Added Whiteboard|target:6.4.0|target:6.4.0 target:6.3.0.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - 2 commits - include/vcl toolkit/source vcl/source
include/vcl/tabctrl.hxx | 21 -
toolkit/source/awt/vclxtabpagecontainer.cxx |2
vcl/source/control/tabctrl.cxx | 569 +++-
vcl/source/window/window.cxx| 16
4 files changed, 160 insertions(+), 448 deletions(-)
New commits:
commit 9f53774b1f177b99317b90d756ea8fe9c7930d73
Author: Jan-Marek Glogowski
AuthorDate: Sun Jun 16 21:41:31 2019 +
Commit: Jan-Marek Glogowski
CommitDate: Sat Jun 22 20:02:08 2019 +0200
VCL merge most of NotebookbarTabControlBase
NotebookbarTabControlBase (NBBTCB) tried to be clever and save
a bool per TabControl page, by not adding a mbVisible to the
ImplTabItem and misuse mbEnabled.
The result is not only a bug with tab highlighting in notebook
bars, but also a lot of duplicate code and additional virtual
functions. Normal TabControls highlight correct.
I'm not 100% sure about the dropped Resize()s, but the code in
ImplPaint() and calculateRequisition() differs by three lines;
which can be merged by adding the TabControl feature to hide
tabs and not just disable them. I first tried to additionally
merge ImplPlaceTabs() too, but the NBBTCB version differs much
more and I didn't want to touch larger parts of TabControl.
Change-Id: Ie6e18fb03b76b46e3627923eb1ac0f674c3eb7e8
Reviewed-on: https://gerrit.libreoffice.org/74126
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit 6540912ae1a570fd8c2318f77b757e07b87c0707)
Reviewed-on: https://gerrit.libreoffice.org/74568
diff --git a/include/vcl/tabctrl.hxx b/include/vcl/tabctrl.hxx
index cf64e66efc64..956c5ece7a6b 100644
--- a/include/vcl/tabctrl.hxx
+++ b/include/vcl/tabctrl.hxx
@@ -64,8 +64,10 @@ protected:
using Control::ImplInitSettings;
SAL_DLLPRIVATE void ImplInitSettings( bool bBackground );
SAL_DLLPRIVATE ImplTabItem* ImplGetItem( sal_uInt16 nId ) const;
+SAL_DLLPRIVATE ImplTabItem* ImplGetItem(const Point& rPt) const;
SAL_DLLPRIVATE Size ImplGetItemSize( ImplTabItem* pItem, long
nMaxWidth );
SAL_DLLPRIVATE tools::RectangleImplGetTabRect( sal_uInt16 nPos, long
nWidth = -1, long nHeight = -1 );
+SAL_DLLPRIVATE tools::Rectangle ImplGetTabRect(const ImplTabItem*, long
nWidth = -1, long nHeight = -1);
SAL_DLLPRIVATE void ImplChangeTabPage( sal_uInt16 nId, sal_uInt16
nOldId );
SAL_DLLPRIVATE bool ImplPosCurTabPage();
virtual voidImplActivateTabPage( bool bNext );
@@ -85,9 +87,8 @@ protected:
virtual voidFillLayoutData() const override;
virtual const vcl::Font&GetCanonicalFont( const StyleSettings& _rStyle
) const override;
virtual const Color&GetCanonicalTextColor( const StyleSettings&
_rStyle ) const override;
-SAL_DLLPRIVATE tools::Rectangle* ImplFindPartRect( const Point& rPt );
virtual boolImplPlaceTabs( long nWidth );
-virtual voidImplPaint(vcl::RenderContext& rRenderContext,
const tools::Rectangle& rRect);
+SAL_DLLPRIVATE Size ImplCalculateRequisition(sal_uInt16& nHeaderHeight)
const;
public:
TabControl( vcl::Window* pParent,
@@ -124,21 +125,23 @@ public:
sal_uInt16 nPos = TAB_APPEND );
voidRemovePage( sal_uInt16 nPageId );
voidClear();
-voidEnablePage( sal_uInt16 nPageId, bool bEnable = true );
+
+void SetPageEnabled(sal_uInt16 nPageId, bool bEnable = true);
+void SetPageVisible(sal_uInt16 nPageId, bool bVisible = true);
sal_uInt16 GetPagePos( sal_uInt16 nPageId ) const;
sal_uInt16 GetPageCount() const;
sal_uInt16 GetPageId( sal_uInt16 nPos ) const;
-virtual sal_uInt16 GetPageId( const Point& rPos ) const;
+sal_uInt16 GetPageId(const Point& rPos) const;
sal_uInt16 GetPageId( const TabPage& rPage ) const;
sal_uInt16 GetPageId( const OString& rName ) const;
-virtual voidSetCurPageId( sal_uInt16 nPageId );
+void SetCurPageId(sal_uInt16 nPageId);
sal_uInt16 GetCurPageId() const;
-virtual voidSelectTabPage( sal_uInt16 nPageId );
+voidSelectTabPage( sal_uInt16 nPageId );
-voidSetTabPage( sal_uInt16 nPageId, TabPage* pPage );
+void SetTabPage(sal_uInt16 nPageId, TabPage* pPage);
TabPage*GetTabPage( sal_uInt16 nPageId ) const;
voidSetPageText( sal_uInt16 nPageId, const OUString& rText
);
@@ -203,15 +206,11 @@ public:
ToolBox* GetToolBox() { return m_pShortcuts; }
PushButton* GetOpenMenu() { return m_pOpenMenu; }
-virtual sal_uInt16 GetPageId( const Point& rPos ) const override;
-virtual voidSelectTabPage( sal_uInt16 nPageId ) override;
-virtual
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - vcl/inc vcl/qt5
vcl/inc/qt5/Qt5MainWindow.hxx |3 +
vcl/inc/salframe.hxx |3 +
vcl/qt5/Qt5Frame.cxx | 83 +-
vcl/qt5/Qt5MainWindow.cxx | 11 -
vcl/qt5/Qt5Widget.cxx | 35 ++---
5 files changed, 84 insertions(+), 51 deletions(-)
New commits:
commit dd0bca3ac7ad2e498ba420718df703f651efdc21
Author: Jan-Marek Glogowski
AuthorDate: Fri Jun 21 04:09:02 2019 +
Commit: Jan-Marek Glogowski
CommitDate: Sat Jun 22 20:01:34 2019 +0200
tdf#123779 Qt5 correctly fill Qt5Frame::maGeometry
The tooltip in the bug is actually not one, but the VCL implementation
of Gtk's popover widget triggered by SalFrame::ShowPopover. This has
no Qt equivalent, so we currently rely on the crude VCL version.
But for this maGeometry must contain the correct information, AKA the
absolute, unmirrored, paintable system geometry of the frame. Then the
window can be positioned correctly.
The patch gets rid of most of the code initially copied from gtk, when
this VCL backend was in a very early state.
Change-Id: Id44e4dc2aac41f1f01d51c4d8107892e644ef243
Reviewed-on: https://gerrit.libreoffice.org/74546
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit 337b592a721bef2c54cbe8c4927e5cc5a68c2138)
Reviewed-on: https://gerrit.libreoffice.org/74566
diff --git a/vcl/inc/qt5/Qt5MainWindow.hxx b/vcl/inc/qt5/Qt5MainWindow.hxx
index a2a7e184c291..a0836170f644 100644
--- a/vcl/inc/qt5/Qt5MainWindow.hxx
+++ b/vcl/inc/qt5/Qt5MainWindow.hxx
@@ -28,9 +28,10 @@ class Qt5MainWindow : public QMainWindow
{
Q_OBJECT
-Qt5Frame* m_pFrame;
+Qt5Frame& m_rFrame;
virtual void closeEvent(QCloseEvent* pEvent) override;
+void moveEvent(QMoveEvent*) override;
public:
Qt5MainWindow(Qt5Frame& rFrame, QWidget* parent = Q_NULLPTR,
diff --git a/vcl/inc/salframe.hxx b/vcl/inc/salframe.hxx
index 86ad6da98b6e..19293b913621 100644
--- a/vcl/inc/salframe.hxx
+++ b/vcl/inc/salframe.hxx
@@ -124,7 +124,7 @@ public:
SalFrame();
virtual ~SalFrame() override;
-SalFrameGeometrymaGeometry;
+SalFrameGeometrymaGeometry; ///< absolute, unmirrored values
// SalGeometryProvider
virtual long GetWidth() const override { return maGeometry.nWidth; }
@@ -165,6 +165,7 @@ public:
const SalFrameGeometry& GetUnmirroredGeometry() const { return maGeometry;
}
virtual voidSetWindowState( const SalFrameState* pState ) = 0;
+// return the absolute, unmirrored system frame state
// if this returns false the structure is uninitialised
[[nodiscard]]
virtual boolGetWindowState( SalFrameState* pState ) = 0;
diff --git a/vcl/qt5/Qt5Frame.cxx b/vcl/qt5/Qt5Frame.cxx
index 6307a70233fe..b009847456e7 100644
--- a/vcl/qt5/Qt5Frame.cxx
+++ b/vcl/qt5/Qt5Frame.cxx
@@ -171,8 +171,8 @@ Qt5Frame::Qt5Frame(Qt5Frame* pParent, SalFrameStyleFlags
nStyle, bool bUseCairo)
{
maGeometry.nDisplayScreenNumber = 0;
Size aDefSize = CalcDefaultSize();
-maGeometry.nX = -1;
-maGeometry.nY = -1;
+maGeometry.nX = 0;
+maGeometry.nY = 0;
maGeometry.nWidth = aDefSize.Width();
maGeometry.nHeight = aDefSize.Height();
maGeometry.nTopDecoration = 0;
@@ -372,8 +372,7 @@ void Qt5Frame::Show(bool bVisible, bool /*bNoActivate*/)
{
assert(m_pQWidget);
-if (m_bDefaultSize)
-SetDefaultSize();
+SetDefaultSize();
auto* pSalInst(static_cast(GetSalData()->m_pInstance));
assert(pSalInst);
@@ -431,9 +430,13 @@ Size Qt5Frame::CalcDefaultSize()
void Qt5Frame::SetDefaultSize()
{
+if (!m_bDefaultSize)
+return;
+
Size aDefSize = CalcDefaultSize();
SetPosSize(0, 0, aDefSize.Width(), aDefSize.Height(),
SAL_FRAME_POSSIZE_WIDTH | SAL_FRAME_POSSIZE_HEIGHT);
+assert(!m_bDefaultSize);
}
void Qt5Frame::SetPosSize(long nX, long nY, long nWidth, long nHeight,
sal_uInt16 nFlags)
@@ -441,38 +444,57 @@ void Qt5Frame::SetPosSize(long nX, long nY, long nWidth,
long nHeight, sal_uInt1
if (!isWindow() || isChild(true, false))
return;
-if ((nFlags & (SAL_FRAME_POSSIZE_WIDTH | SAL_FRAME_POSSIZE_HEIGHT))
-&& (nWidth > 0 && nHeight > 0) // sometimes stupid things happen
-)
+if (nFlags & (SAL_FRAME_POSSIZE_WIDTH | SAL_FRAME_POSSIZE_HEIGHT))
{
m_bDefaultSize = false;
if (isChild(false) || !m_pQWidget->isMaximized())
{
-if (m_nStyle & SalFrameStyleFlags::SIZEABLE)
-asChild()->resize(nWidth, nHeight);
-else
-asChild()->setFixedSize(nWidth, nHeight);
+if (!(nFlags & SAL_FRAME_POSSIZE_WIDTH))
+nWidth = maGeometry.nWidth;
+else if (!(nFlags & SAL_FRAME_POSSIZE_HEIGHT))
+
[Libreoffice-bugs] [Bug 124118] Old Hungarian letters doesn't appeared in typing time, produce tofus under KDE.
https://bugs.documentfoundation.org/show_bug.cgi?id=124118 Jan-Marek Glogowski changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #23 from Jan-Marek Glogowski --- Verified in comment 20 for 6.4. Thanks for that. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left (aka Complex Text Layout) language issues (RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=43808 Bug 43808 depends on bug 124118, which changed state. Bug 124118 Summary: Old Hungarian letters doesn't appeared in typing time, produce tofus under KDE. https://bugs.documentfoundation.org/show_bug.cgi?id=124118 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 124118, which changed state. Bug 124118 Summary: Old Hungarian letters doesn't appeared in typing time, produce tofus under KDE. https://bugs.documentfoundation.org/show_bug.cgi?id=124118 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124118] Old Hungarian letters doesn't appeared in typing time, produce tofus under KDE.
https://bugs.documentfoundation.org/show_bug.cgi?id=124118 Jan-Marek Glogowski changed: What|Removed |Added Status|REOPENED|RESOLVED Summary|Old Hungarian letters |Old Hungarian letters |doesn't appeared in typing |doesn't appeared in typing |time on 6.0.0.0beta,|time, produce tofus under |produce tofus under KDE.|KDE. |Patch is given and works on | |6.4.0.0Alpha. | Resolution|--- |FIXED --- Comment #22 from Jan-Marek Glogowski --- (In reply to Kovács Viktor from comment #21) > Jan-Marek Glogowski's patch is working. > Is it possible backport to earlier version of LibreOffice than 6.0.0.1? This is just a fix for the new qt5 / kde5 code added in 6.2. The code depends on many other fixes, so it won't even be fixed in 6.2. If it's broken in 6.0 you have a different bug, but probably that 6.0.0.1 is a typo, as you claim it just happens in 6.2 as earliest affected, which makes sense. 6.0 is EOL, so no fix there anyway. (In reply to Kovács Viktor from comment #20) > Works on: 6.4.0.0alpha, but not works on Version: 6.3.0.0.beta1 > Build ID: a187af327633f5f00363be5131bd21a13e0f1a7b AFAIK the patch was merged after the 6.3 beta (commit date was 2019-06-06). Can't check for sure, as git claims it doesn't know the build id, which is strange. And since there are no 6.3 daily builds you can't check either. I reset this bug to FIXED, as you say it works with 6.4. And I reset the summary. No version information should go there. Please open a new report when 6.3 is out and it's still broken there. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108604] wrong kashida placement when exporting to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=108604 --- Comment #14 from Fahad Al-Saidi --- Not fixed yet -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 126036] Inconsistent arrangement of dialog buttons (and inconsistency in availability of certain buttons)
https://bugs.documentfoundation.org/show_bug.cgi?id=126036 --- Comment #6 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/01cd1d68d96057624db38b9baaa6c6795353758d%5E%21 Related: tdf#126036 sort button by native order for async dialogs too It will be available in 6.3.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 126036] Inconsistent arrangement of dialog buttons (and inconsistency in availability of certain buttons)
https://bugs.documentfoundation.org/show_bug.cgi?id=126036 --- Comment #7 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/4cbf5a4f666ac4d7b01746bc36ab01400e28ff40%5E%21 Related: tdf#126036 sort button by native order for async dialogs too It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - cui/Library_cui.mk cui/source cui/uiconfig extras/source include/cui include/sfx2 include/svx include/vcl sc/source sd/inc sd/source sfx2/sou
cui/Library_cui.mk |1
cui/source/dialogs/SpellAttrib.cxx | 105 -
cui/source/dialogs/SpellAttrib.hxx | 100 -
cui/source/dialogs/SpellDialog.cxx | 1654 ++-
cui/source/dialogs/cuicharmap.cxx|2
cui/source/factory/dlgfact.cxx | 27
cui/source/factory/dlgfact.hxx | 16
cui/source/factory/init.cxx |4
cui/source/inc/SpellDialog.hxx | 189 +-
cui/uiconfig/ui/spellingdialog.ui| 159 +
extras/source/glade/libreoffice-catalog.xml.in |3
include/cui/cuicharmap.hxx |2
include/sfx2/basedlgs.hxx|3
include/svx/ClassificationEditView.hxx |4
include/svx/langbox.hxx |2
include/svx/svxdlg.hxx |6
include/vcl/edit.hxx |2
include/vcl/weld.hxx | 10
sc/source/ui/inc/spelleng.hxx|4
sc/source/ui/view/cellsh.cxx |4
sc/source/ui/view/spelleng.cxx | 33
sd/inc/Outliner.hxx |6
sd/source/ui/view/Outliner.cxx | 20
sfx2/source/appl/appinit.cxx |6
sfx2/source/dialog/basedlgs.cxx | 15
solenv/bin/native-code.py|1
svx/source/dialog/SpellDialogChildWindow.cxx |6
svx/source/dialog/rubydialog.cxx |6
svx/source/dialog/srchdlg.cxx|6
sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx |9
vcl/source/app/salvtables.cxx| 33
vcl/source/control/edit.cxx |4
vcl/source/edit/vclmedit.cxx |4
vcl/unx/gtk3/gtk3gtkinst.cxx | 50
34 files changed, 1369 insertions(+), 1127 deletions(-)
New commits:
commit 243b5b392906042ab03800e0b5765e6f3513372c
Author: Caolán McNamara
AuthorDate: Fri Jun 14 21:56:44 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jun 22 19:28:38 2019 +0200
weld SpellDialog
a) use EditEngine instead of TextEngine as the former can be hosted in a
foreign widget
b) use a SfxGrabBagItem to hold the custom spellchecking info inside the
EditEngine
c) in longer paragraphs the current word is now auto-scrolled into view
d) rename Invalidate to InvalidateDialog
Change-Id: Ic6db019c32cdfd5f354c58ee7394fdaa040b86e1
Reviewed-on: https://gerrit.libreoffice.org/74535
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/Library_cui.mk b/cui/Library_cui.mk
index 2d46420c4b1a..cce2b7098da9 100644
--- a/cui/Library_cui.mk
+++ b/cui/Library_cui.mk
@@ -132,7 +132,6 @@ $(eval $(call gb_Library_add_exception_objects,cui,\
cui/source/dialogs/SignSignatureLineDialog \
cui/source/dialogs/sdrcelldlg \
cui/source/dialogs/showcols \
-cui/source/dialogs/SpellAttrib \
cui/source/dialogs/SpellDialog \
cui/source/dialogs/splitcelldlg \
cui/source/dialogs/srchxtra \
diff --git a/cui/source/dialogs/SpellAttrib.cxx
b/cui/source/dialogs/SpellAttrib.cxx
deleted file mode 100644
index 9d761a55b3f1..
--- a/cui/source/dialogs/SpellAttrib.cxx
+++ /dev/null
@@ -1,105 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the "License"); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#include "SpellAttrib.hxx"
-#include
-
-using namespace svx;
-using namespace com::sun::star::linguistic2;
-using namespace com::sun::star::uno;
-
-
-SpellErrorAttrib::SpellErrorAttrib( const SpellErrorDescription& rDesc ) :
-TextAttrib(TEXTATTR_SPELL_ERROR),
-m_aSpellErrorDescription( rDesc )
-{
-}
-
-
-void SpellErrorAttrib::SetFont( vcl::Font& ) const
-{
-//this attribute doesn't have a visual effect
-}
-
-
[Libreoffice-commits] core.git: 2 commits - vcl/inc vcl/qt5 vcl/source
vcl/inc/qt5/Qt5Frame.hxx |3 ---
vcl/inc/qt5/Qt5Widget.hxx |3 ---
vcl/qt5/Qt5Frame.cxx | 10 +-
vcl/qt5/Qt5Widget.cxx |7 ---
vcl/source/app/salvtables.cxx |6 ++
5 files changed, 11 insertions(+), 18 deletions(-)
New commits:
commit ab5f341efd144adb6b7d0e00fece76a2153acd10
Author: Jan-Marek Glogowski
AuthorDate: Sat Jun 22 02:25:24 2019 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sat Jun 22 19:28:12 2019 +0200
Qt5 directly show tooltips + respect the help area
I'm not sure why this redirection was implemented, which also ommited
the provided help area. I tried hard to use vc::Window code in the
beginning, but that also mirrors the cursor position for the window.
Using Qt here is simply straight forward, so just do that,
Change-Id: Ia8c4efc1e43b915c4b071ee26d4da37d7580817c
Reviewed-on: https://gerrit.libreoffice.org/74548
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/vcl/inc/qt5/Qt5Frame.hxx b/vcl/inc/qt5/Qt5Frame.hxx
index d7f8f1aa6e1f..5b1bc1025445 100644
--- a/vcl/inc/qt5/Qt5Frame.hxx
+++ b/vcl/inc/qt5/Qt5Frame.hxx
@@ -133,9 +133,6 @@ class VCLPLUG_QT5_PUBLIC Qt5Frame : public QObject, public
SalFrame
void TriggerPaintEvent();
void TriggerPaintEvent(QRect aRect);
-Q_SIGNALS:
-void tooltipRequest(const OUString& rTooltip);
-
public:
Qt5Frame(Qt5Frame* pParent, SalFrameStyleFlags nSalFrameStyle, bool
bUseCairo);
virtual ~Qt5Frame() override;
diff --git a/vcl/inc/qt5/Qt5Widget.hxx b/vcl/inc/qt5/Qt5Widget.hxx
index 8ead4b3ec945..85523951cda2 100644
--- a/vcl/inc/qt5/Qt5Widget.hxx
+++ b/vcl/inc/qt5/Qt5Widget.hxx
@@ -70,9 +70,6 @@ class Qt5Widget : public QWidget
void inputMethodEvent(QInputMethodEvent*) override;
QVariant inputMethodQuery(Qt::InputMethodQuery) const override;
-public slots:
-static void showTooltip(const OUString& rTip);
-
public:
Qt5Widget(Qt5Frame& rFrame, Qt::WindowFlags f = Qt::WindowFlags());
diff --git a/vcl/qt5/Qt5Frame.cxx b/vcl/qt5/Qt5Frame.cxx
index dbdc51ea9465..d585f627b7fd 100644
--- a/vcl/qt5/Qt5Frame.cxx
+++ b/vcl/qt5/Qt5Frame.cxx
@@ -155,9 +155,6 @@ Qt5Frame::Qt5Frame(Qt5Frame* pParent, SalFrameStyleFlags
nStyle, bool bUseCairo)
else
m_pQWidget = new Qt5Widget(*this, aWinFlags);
-connect(this, ::tooltipRequest,
static_cast(m_pQWidget),
-::showTooltip);
-
if (pParent && !(pParent->m_nStyle & SalFrameStyleFlags::PLUG))
{
QWindow* pParentWindow =
pParent->GetQWidget()->window()->windowHandle();
@@ -743,9 +740,12 @@ void Qt5Frame::Flush()
// destroyed, so that state should be safely flushed.
}
-bool Qt5Frame::ShowTooltip(const OUString& rText, const tools::Rectangle&
/*rHelpArea*/)
+bool Qt5Frame::ShowTooltip(const OUString& rText, const tools::Rectangle&
rHelpArea)
{
-emit tooltipRequest(rText);
+QRect aHelpArea(toQRect(rHelpArea));
+if (QGuiApplication::isRightToLeft())
+aHelpArea.moveLeft(maGeometry.nWidth - aHelpArea.width() -
aHelpArea.left() - 1);
+QToolTip::showText(QCursor::pos(), toQString(rText), m_pQWidget,
aHelpArea);
return true;
}
diff --git a/vcl/qt5/Qt5Widget.cxx b/vcl/qt5/Qt5Widget.cxx
index 42f3353ff26b..843ce798a989 100644
--- a/vcl/qt5/Qt5Widget.cxx
+++ b/vcl/qt5/Qt5Widget.cxx
@@ -40,7 +40,6 @@
#include
#include
#include
-#include
#include
#include
@@ -503,12 +502,6 @@ void Qt5Widget::focusOutEvent(QFocusEvent*)
m_rFrame.CallCallback(SalEvent::LoseFocus, nullptr);
}
-void Qt5Widget::showTooltip(const OUString& rTooltip)
-{
-QPoint pt = QCursor::pos();
-QToolTip::showText(pt, toQString(rTooltip));
-}
-
Qt5Widget::Qt5Widget(Qt5Frame& rFrame, Qt::WindowFlags f)
: QWidget(Q_NULLPTR, f)
, m_rFrame(rFrame)
commit 4cbf5a4f666ac4d7b01746bc36ab01400e28ff40
Author: Caolán McNamara
AuthorDate: Fri Jun 21 21:55:20 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jun 22 19:28:04 2019 +0200
Related: tdf#126036 sort button by native order for async dialogs too
Change-Id: Iddc689b8d332e8e0127806c37b5ccce66eadfcf6
Reviewed-on: https://gerrit.libreoffice.org/74540
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index b17e0215258d..fc62bb6441e2 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -1218,6 +1218,9 @@ public:
VclAbstractDialog::AsyncContext aCtx;
aCtx.mxOwnerDialogController = aOwner;
aCtx.maEndDialogFn = rEndDialogFn;
+VclButtonBox* pActionArea = m_xDialog->get_action_area();
+if (pActionArea)
+ pActionArea->sort_native_button_order();
return m_xDialog->StartExecuteAsync(aCtx);
}
@@ -1229,6 +1232,9 @@ public:
// which is that rxSelf enforces.
aCtx.mxOwnerSelf = rxSelf;
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - vcl/source
vcl/source/app/salvtables.cxx |6 ++ 1 file changed, 6 insertions(+) New commits: commit 01cd1d68d96057624db38b9baaa6c6795353758d Author: Caolán McNamara AuthorDate: Fri Jun 21 21:55:20 2019 +0100 Commit: Caolán McNamara CommitDate: Sat Jun 22 19:28:18 2019 +0200 Related: tdf#126036 sort button by native order for async dialogs too Change-Id: Iddc689b8d332e8e0127806c37b5ccce66eadfcf6 Reviewed-on: https://gerrit.libreoffice.org/74541 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx index 1330b125320f..f5f86da203f7 100644 --- a/vcl/source/app/salvtables.cxx +++ b/vcl/source/app/salvtables.cxx @@ -1202,6 +1202,9 @@ public: VclAbstractDialog::AsyncContext aCtx; aCtx.mxOwnerDialogController = aOwner; aCtx.maEndDialogFn = rEndDialogFn; +VclButtonBox* pActionArea = m_xDialog->get_action_area(); +if (pActionArea) + pActionArea->sort_native_button_order(); return m_xDialog->StartExecuteAsync(aCtx); } @@ -1213,6 +1216,9 @@ public: // which is that rxSelf enforces. aCtx.mxOwnerSelf = rxSelf; aCtx.maEndDialogFn = rEndDialogFn; +VclButtonBox* pActionArea = m_xDialog->get_action_area(); +if (pActionArea) + pActionArea->sort_native_button_order(); return m_xDialog->StartExecuteAsync(aCtx); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 126036] Inconsistent arrangement of dialog buttons (and inconsistency in availability of certain buttons)
https://bugs.documentfoundation.org/show_bug.cgi?id=126036 --- Comment #5 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/8e0b55bc9b788d2ac95768af6b9e88996dc10d29%5E%21 Related: tdf#126036 missing "reset" button It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 126036] Inconsistent arrangement of dialog buttons (and inconsistency in availability of certain buttons)
https://bugs.documentfoundation.org/show_bug.cgi?id=126036 Commit Notification changed: What|Removed |Added Whiteboard|target:6.3.0.1 |target:6.3.0.1 target:6.4.0 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sw/source
sw/source/uibase/fldui/fldwrap.cxx |2 --
1 file changed, 2 deletions(-)
New commits:
commit 3d98a2b8135315c57af86490eac32963688e3be4
Author: Caolán McNamara
AuthorDate: Fri Jun 21 15:41:05 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jun 22 19:27:48 2019 +0200
field dialogs all welded
Change-Id: I0a468ec6926b8b1cd5666839ea0de192c6d11d16
Reviewed-on: https://gerrit.libreoffice.org/74528
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sw/source/uibase/fldui/fldwrap.cxx
b/sw/source/uibase/fldui/fldwrap.cxx
index 69cb72de640a..ce704d0ab51d 100644
--- a/sw/source/uibase/fldui/fldwrap.cxx
+++ b/sw/source/uibase/fldui/fldwrap.cxx
@@ -47,8 +47,6 @@ IMPL_LINK_NOARG(SwChildWinWrapper, UpdateHdl, Timer *, void)
{
if (GetController())
GetController()->Activate();// update dialog
-else if (GetWindow())
-GetWindow()->Activate();// update dialog
}
// newly initialise dialog after Doc switch
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 126036] Inconsistent arrangement of dialog buttons (and inconsistency in availability of certain buttons)
https://bugs.documentfoundation.org/show_bug.cgi?id=126036 --- Comment #4 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/ac9715d5f83843c1bb6004e50e1ce812971acbdd%5E%21 Related: tdf#126036 missing "reset" button It will be available in 6.3.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 126036] Inconsistent arrangement of dialog buttons (and inconsistency in availability of certain buttons)
https://bugs.documentfoundation.org/show_bug.cgi?id=126036 Commit Notification changed: What|Removed |Added Whiteboard||target:6.3.0.1 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sfx2/source
sfx2/source/dialog/tabdlg.cxx |1 -
1 file changed, 1 deletion(-)
New commits:
commit ac9715d5f83843c1bb6004e50e1ce812971acbdd
Author: Caolán McNamara
AuthorDate: Fri Jun 21 20:39:55 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jun 22 19:27:21 2019 +0200
Related: tdf#126036 missing "reset" button
removing 'standard' should not also hide 'reset'
Change-Id: I0c12ea16c378a225052468d01e0f1a99a6d59846
Reviewed-on: https://gerrit.libreoffice.org/74537
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sfx2/source/dialog/tabdlg.cxx b/sfx2/source/dialog/tabdlg.cxx
index f75b78a1a9f7..e903d6b76a84 100644
--- a/sfx2/source/dialog/tabdlg.cxx
+++ b/sfx2/source/dialog/tabdlg.cxx
@@ -1106,7 +1106,6 @@ void SfxTabDialogController::RemoveResetButton()
void SfxTabDialogController::RemoveStandardButton()
{
m_xBaseFmtBtn->hide();
-m_pImpl->bHideResetBtn = true;
}
SfxTabPage* SfxTabDialogController::GetTabPage(const OString& rPageId) const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/dialog/tabdlg.cxx |1 -
1 file changed, 1 deletion(-)
New commits:
commit 8e0b55bc9b788d2ac95768af6b9e88996dc10d29
Author: Caolán McNamara
AuthorDate: Fri Jun 21 20:39:55 2019 +0100
Commit: Caolán McNamara
CommitDate: Sat Jun 22 19:27:07 2019 +0200
Related: tdf#126036 missing "reset" button
removing 'standard' should not also hide 'reset'
Change-Id: I0c12ea16c378a225052468d01e0f1a99a6d59846
Reviewed-on: https://gerrit.libreoffice.org/74536
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sfx2/source/dialog/tabdlg.cxx b/sfx2/source/dialog/tabdlg.cxx
index a078525f5c03..c341b751c84e 100644
--- a/sfx2/source/dialog/tabdlg.cxx
+++ b/sfx2/source/dialog/tabdlg.cxx
@@ -1104,7 +1104,6 @@ void SfxTabDialogController::RemoveResetButton()
void SfxTabDialogController::RemoveStandardButton()
{
m_xBaseFmtBtn->hide();
-m_pImpl->bHideResetBtn = true;
}
SfxTabPage* SfxTabDialogController::GetTabPage(const OString& rPageId) const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 108342] BASE, Editing: list field in table grid shows status row changed on opening form when it's first column
https://bugs.documentfoundation.org/show_bug.cgi?id=108342 Gerhard Weydt changed: What|Removed |Added Summary|Editing: list field in |BASE, Editing: list field |table grid shows status row |in table grid shows status |changed on opening form |row changed on opening form |when it's first column |when it's first column -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124118] Old Hungarian letters doesn't appeared in typing time on 6.0.0.0beta, produce tofus under KDE. Patch is given and works on 6.4.0.0Alpha.
https://bugs.documentfoundation.org/show_bug.cgi?id=124118 Kovács Viktor changed: What|Removed |Added Summary|Old Hungarian letters |Old Hungarian letters |doesn't appeared in typing |doesn't appeared in typing |time on 6.0.0.0beta,|time on 6.0.0.0beta, |produce tofus under KDE.|produce tofus under KDE. |Patch is given and works. |Patch is given and works on ||6.4.0.0Alpha. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124118] Old Hungarian letters doesn't appeared in typing time on 6.0.0.0beta, produce tofus under KDE. Patch is given and works.
https://bugs.documentfoundation.org/show_bug.cgi?id=124118 Kovács Viktor changed: What|Removed |Added Summary|Old Hungarian letters |Old Hungarian letters |doesn't appeared in typing |doesn't appeared in typing |time, produce tofus under |time on 6.0.0.0beta, |KDE.|produce tofus under KDE. ||Patch is given and works. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left (aka Complex Text Layout) language issues (RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=43808 Bug 43808 depends on bug 124118, which changed state. Bug 124118 Summary: Old Hungarian letters doesn't appeared in typing time, produce tofus under KDE. https://bugs.documentfoundation.org/show_bug.cgi?id=124118 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124118] Old Hungarian letters doesn't appeared in typing time, produce tofus under KDE.
https://bugs.documentfoundation.org/show_bug.cgi?id=124118 Kovács Viktor changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #21 from Kovács Viktor --- Jan-Marek Glogowski's patch is working. Is it possible backport to earlier version of LibreOffice than 6.0.0.1? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 124118, which changed state. Bug 124118 Summary: Old Hungarian letters doesn't appeared in typing time, produce tofus under KDE. https://bugs.documentfoundation.org/show_bug.cgi?id=124118 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97513] In Pivot tables, compute sum for numbers and counts for other formats by default
https://bugs.documentfoundation.org/show_bug.cgi?id=97513 --- Comment #10 from kaese...@gmail.com --- I'd just like to second this, this is a wish I had for YEARS, summing for variables with numerics in them and counting unique values for anything else makes just so much more sense and will save users countless clicks. It would be great if this could be done ... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40259] Unexpected behaviour with Shapes → Intersect
https://bugs.documentfoundation.org/show_bug.cgi?id=40259 --- Comment #20 from RGB --- Same behavior on 6.2.4.2: if the picture was resized before the procedure, Shapes → Intersect gives a distorted "background" to the resulting shape. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126049] Copying a table in HTML from web browser to Calc, automatic data format correction is wrong (ignoring settings)
https://bugs.documentfoundation.org/show_bug.cgi?id=126049 m.a.riosv changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG --- Comment #5 from m.a.riosv --- Use paste special [Ctrl+Shift+V], select the column head of dates and in the dropbox select text, or click on the right arrow of paste button, select unformatted text and do the same. The issue happens with lines where the letters of a day can be interpreted as a letter of a month. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50916] Allow more than 1024 columns in calc
https://bugs.documentfoundation.org/show_bug.cgi?id=50916 --- Comment #83 from tr00don --- This really is an important missing feature. If you work with large data sets, especially in ML/DL, 1024 is a serious limitation. Seeing as the first request was filed in 2012, I find it surprising that a fix is still pending. Do consider a change of file format if necessary for backward compatibility but please include this feature in 9.3. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 105884, which changed state. Bug 105884 Summary: Make the tabs of tabbed Notebookbar follow KDE style https://bugs.documentfoundation.org/show_bug.cgi?id=105884 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107191] [META] Notebookbar theming issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107191 Bug 107191 depends on bug 105884, which changed state. Bug 105884 Summary: Make the tabs of tabbed Notebookbar follow KDE style https://bugs.documentfoundation.org/show_bug.cgi?id=105884 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105884] Make the tabs of tabbed Notebookbar follow KDE style
https://bugs.documentfoundation.org/show_bug.cgi?id=105884 Jan-Marek Glogowski changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
