[Libreoffice-bugs] [Bug 124759] ODBC - DB2 database access - First row missing from Base query results.

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124759

--- Comment #6 from kovacs.zsolt.san...@gmail.com ---
(In reply to Xisco Faulí from comment #5)
> Could you please try to reproduce it with the latest version of LibreOffice
> from https://www.libreoffice.org/download/libreoffice-fresh/ ?
> I have set the bug's status to 'NEEDINFO'. Please change it back to
> 'UNCONFIRMED' if the bug is still present in the latest version.

Unfortunately, the problem still exists in the new version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126220] Name Box of LO 6.3.0.0.beta2 Calc does not clear previous values

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126220

--- Comment #21 from Nukool Chompuparn  ---
Created attachment 152699
  --> https://bugs.documentfoundation.org/attachment.cgi?id=152699=edit
LO 6.3.0.0.beta2 About message box of the other notebook

I have 2 notebooks with the same installations OS and LO. But there is no
error. I have made this screenshot for your consideration.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122906] [WOPI] SSL error

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122906

--- Comment #6 from harryred123  ---
Some bugs related to sign in errors are really very common as the users are
getting very frequently. They can also take help from
https://supportphonenumberaustralia.com/blog/xbox-sign-in-error-0x87dd0006/ 
that will help to resolve easily.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126321] New: Writer Tabbed: Blinking Page Size contents

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126321

Bug ID: 126321
   Summary: Writer Tabbed: Blinking Page Size contents
   Product: LibreOffice
   Version: 6.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: riz_17_...@yahoo.co.id

Page size's box and its content always blinking for unknown reason. It happens
continuously under my Windows and Ubuntu boxes.

Step to reproduce:

1. Open Writer/Create a new text document
2. Enable tabbed interface (View >  User Interface > Tabbed)
3. Go to Layout tab > Page Size

Version: 6.4.0.0.alpha0+ (x64)
Build ID: 49422a469646ad8be43ba828ca24c2484c26b9e8
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-07-08_02:14:23
Locale: id-ID (id_ID); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: tdf#74702 2/2

2019-07-09 Thread Tomaž Vajngerl
Hi,

On Wed, Jul 10, 2019 at 5:54 AM Adrien Ollier  wrote:

>
> Also, let's take a concrete example:
>
> 
> https://opengrok.libreoffice.org/xref/core/vcl/source/control/edit.cxx?r=d00ee2cb
> void Edit::Draw(OutputDevice* pDev, const Point& rPos, const Size& rSize,
> DrawFlags nFlags)
> see l.1771
>
> Can you tell me how you would remove the use of GetOutDevType?
>

In this case I would remove the condition "eOutDevType == OUTDEV_PRINTER"
completely. No idea why it exists but color printers exist today and
overriding the text color to black just because the output device is a
printer is backwards and wrong. Anything that a printer can't handle should
be modified in the output device itself and not outside of it. In this
case, what would happen if the background of the Edit is set to black? Yup
- the text would be drawn in black instead of the color that was set. I
tried it with inserting a combo box into a writer document with black
background and white font color to confirm and surely it printed it with
black text. I think you actually found a bug, or a workaround for some
assumption made in the past that's not relevant today anymore. ;)

Regards, Tomaž
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 126320] New: Converting text to contour, polygon, or curve does not honor color border/width settings upon export to PNG/JPG/etc.

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126320

Bug ID: 126320
   Summary: Converting text to contour, polygon, or curve does not
honor color border/width settings upon export to
PNG/JPG/etc.
   Product: LibreOffice
   Version: 6.3.0.1 rc
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mwtjunkm...@gmail.com

Description:
Converting text to contour, polygon, or curve has a default border/line
thickness of black, even when the border is set to none.
See bug #126097

Steps to Reproduce:
1. Open Draw
2. Create text. Make it pink or something other than black.
3. Keep the text's border to none.
4. Convert the text to a contour, polygon, or curve (doesn't matter which)
5. Export to any format (JPG, PNG, TIFF)

Actual Results:
Black border appears around the converted text despite a different border
color/thickness.

Expected Results:
The export should adopt the border properties of the converted text, not
default to black (or even appear if the border is set to none).


Reproducible: Always


User Profile Reset: No



Additional Info:
See bug #126097

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2019-07-09 Thread Mike Kaganski (via logerrit)
 sc/source/ui/docshell/externalrefmgr.cxx |   23 ---
 1 file changed, 16 insertions(+), 7 deletions(-)

New commits:
commit 03c708bf085f91480c014d7fa31e7a317b2c7b8f
Author: Mike Kaganski 
AuthorDate: Tue Jul 9 18:44:42 2019 +1000
Commit: Mike Kaganski 
CommitDate: Wed Jul 10 06:08:43 2019 +0200

Postpone filter detection until link update is allowed

Change-Id: I85b2185e550f2a133ceb485241ef513b40593e34
Reviewed-on: https://gerrit.libreoffice.org/75301
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sc/source/ui/docshell/externalrefmgr.cxx 
b/sc/source/ui/docshell/externalrefmgr.cxx
index 8e995ebf0c40..d7010ca66463 100644
--- a/sc/source/ui/docshell/externalrefmgr.cxx
+++ b/sc/source/ui/docshell/externalrefmgr.cxx
@@ -2115,6 +2115,15 @@ void insertRefCellByIterator(
 }
 }
 
+bool IsLinkUpdateAllowedInDoc(const ScDocument& rDoc)
+{
+SfxObjectShell* pDocShell = rDoc.GetDocumentShell();
+if (!pDocShell)
+return false;
+
+return pDocShell->GetEmbeddedObjectContainer().getUserAllowsLinkUpdate();
+}
+
 }
 
 void ScExternalRefManager::insertRefCell(sal_uInt16 nFileId, const ScAddress& 
rCell)
@@ -2322,13 +2331,8 @@ ScDocument* 
ScExternalRefManager::getInMemorySrcDocument(sal_uInt16 nFileId)
 return nullptr;
 
 // Do not load document until it was allowed
-SfxObjectShell* pDocShell = mpDoc->GetDocumentShell();
-if ( pDocShell )
-{
-const comphelper::EmbeddedObjectContainer& rContainer = 
pDocShell->GetEmbeddedObjectContainer();
-if ( !rContainer.getUserAllowsLinkUpdate() )
-return nullptr;
-}
+if (!IsLinkUpdateAllowedInDoc(*mpDoc))
+return nullptr;
 
 ScDocument* pSrcDoc = nullptr;
 ScDocShell* pShell = 
static_cast(SfxObjectShell::GetFirst(checkSfxObjectShell,
 false));
@@ -2573,6 +2577,11 @@ void ScExternalRefManager::maybeLinkExternalFile( 
sal_uInt16 nFileId, bool bDefe
 aFilter = pFileData->maFilterName;
 aOptions = pFileData->maFilterOptions;
 }
+
+// Filter detection may access external links; defer it until we are 
allowed
+if (!bDeferFilterDetection)
+bDeferFilterDetection = !IsLinkUpdateAllowedInDoc(*mpDoc);
+
 // If a filter was already set (for example, loading the cached table),
 // don't call GetFilterName which has to access the source file.
 // If filter detection is deferred, the next successful loadSrcDocument()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 126097] Exporting creates jagged outlines on text that has been converted to curves/polygons/contours

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126097

--- Comment #4 from mwtjunkm...@gmail.com ---
Still happens in 6.3 RC1. 
Unfortunate, means I'll need to install an older version until this is fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[GSoC - QR Code] Weekly Report (1 July - 7 July)

2019-07-09 Thread shubham goyal
*Work Done this week*

*Done more work in Dialog Box patch and ODF import/export patch.
The patches are not yet merge able.

*QR Dialog Box
https://gerrit.libreoffice.org/#/c/74167/ - patch under review

* ODF export import filters for QR Code
https://gerrit.libreoffice.org/#/c/74853/ - patch under review

*Tasks Week( 8 July - 14 July)*

*make the above patches merge able.

Thanks and Regards
Shubham Goyal
IRC nick - shubhamg
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 126095] NB toolbars visible which should be hidden

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126095

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126261] Right to left (RTL) writing doesn't work

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126261

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126293] Save icon changes size when document gets modified

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126293

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126080] Idle session does not respond to postMessage API requests

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126080

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126295] Unable to open files in LO Calc -- timeout waiting for threadpool tasks

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126295

--- Comment #4 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122000] Trouble with Libre Office docs saved on hard drive and flash drive

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122000

--- Comment #3 from QA Administrators  ---
Dear ajtorregrossa,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126220] Name Box of LO 6.3.0.0.beta2 Calc does not clear previous values

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126220

--- Comment #20 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126261] Right to left (RTL) writing doesn't work

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126261

--- Comment #8 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121986] external url update

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121986

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121986] external url update

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121986

--- Comment #4 from QA Administrators  ---
Dear Albert,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126295] Unable to open files in LO Calc -- timeout waiting for threadpool tasks

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126295

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126070] New Bullets Dialog - Preview zone not resizable + levels above 6-7 not visible with default zone size

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126070

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126220] Name Box of LO 6.3.0.0.beta2 Calc does not clear previous values

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126220

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121943] UI: Impress select template dialog opens up as inactive

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121943

--- Comment #7 from QA Administrators  ---
Dear ostruzina,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122000] Trouble with Libre Office docs saved on hard drive and flash drive

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122000

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108491] XHTML export puts inline formulae on separate lines (not with save-as)

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108491

--- Comment #23 from QA Administrators  ---
Dear Shmuel (Seymour J.) Metz,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121650] LibreOffice 6.1.1.2 Calc - Date formatting for US and UK are interchanged

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121650

--- Comment #6 from QA Administrators  ---
Dear Hector Acevedo,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121790] When typing traditional Chinese characters, status bar consider those as simplified ones.

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121790

--- Comment #5 from QA Administrators  ---
Dear lego91003,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 73259] Ctrl + F10 doesn't show unprintable characters

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=73259

--- Comment #12 from QA Administrators  ---
Dear Romulo,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 55793] Problem rendering multiple Asian fonts in Impress

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=55793

--- Comment #19 from QA Administrators  ---
Dear Floater,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121650] LibreOffice 6.1.1.2 Calc - Date formatting for US and UK are interchanged

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121650

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121913] Title case setting for style headings capitalizes 'and'

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121913

--- Comment #3 from QA Administrators  ---
Dear gs_garcia,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121894] text boxes do not inherit master formatting

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121894

--- Comment #9 from QA Administrators  ---
Dear Elmar,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118637] EXPORT: XHTML: text missing after formula

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118637

--- Comment #4 from QA Administrators  ---
Dear Xisco Faulí,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107115] Not installed font 'Calibri Light' rendered different (and wrong) on Ubuntu compared to Windows

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107115

--- Comment #16 from QA Administrators  ---
Dear Cor Nouws,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117345] Mail Merge Wizard cannot be opend

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117345

--- Comment #9 from QA Administrators  ---
Dear Anton Vossen,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114022] Selection in Input Line, of cell containing also an email address as link, is not synchronized properly in the cell

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114022

--- Comment #6 from QA Administrators  ---
Dear Cor Nouws,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118529] LO crashes when on various UI actions (FreeBSD)

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=118529

--- Comment #15 from QA Administrators  ---
Dear Pelle Hjek,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108757] PDF Export of a particular spreadsheet is slower than it has been before

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108757

--- Comment #6 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87680] No accessible caret-moved events in Writer tables

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=87680

--- Comment #17 from QA Administrators  ---
Dear Joanmarie Diggs,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115707] Crash in: cppu::_copyConstructAny(_uno_Any *, void *, _typelib_TypeDescriptionReference *, _typelib_TypeDescription *, void (*)(void *), _uno_Mapping *)

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=115707

--- Comment #11 from QA Administrators  ---
Dear dimagsv,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83649] Right edge of the wide table pasted as RTF from Calc to Writer is unreacheable in Normal view

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83649

--- Comment #9 from QA Administrators  ---
Dear freeseek,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126214] LibreOffice Online (loolwsd) right mouse click not work

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126214

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #1 from Aron Budea  ---
Can you paste the commit hashes from the About box?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: setup_native/source

2019-07-09 Thread nd101 (via logerrit)
 setup_native/source/win32/customactions/inst_msu/inst_msu.cxx |   12 --
 1 file changed, 10 insertions(+), 2 deletions(-)

New commits:
commit 3811e9b80bbd4f1598ab8958a8bf050262170265
Author: nd101 
AuthorDate: Fri Jul 5 15:35:18 2019 +0800
Commit: Mike Kaganski 
CommitDate: Wed Jul 10 04:45:27 2019 +0200

fix HRESULT_FROM_WIN32 can not be placed inside switch for SDK8.1

For Windows SDK 8.1 HRESULT_FROM_WIN32 is defined as an inline
function without the constexpr, which is required for case statement
inside a switch.

Change-Id: Ibb195ef900926d87ff04f82a6d73112b8858f633
Reviewed-on: https://gerrit.libreoffice.org/75111
Reviewed-by: Mike Kaganski 
Tested-by: Jenkins

diff --git a/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx 
b/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx
index 6ce517f2f863..26f7668ff069 100644
--- a/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx
+++ b/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx
@@ -604,13 +604,21 @@ extern "C" __declspec(dllexport) UINT __stdcall 
InstallMSU(MSIHANDLE hInstall)
 if (!GetExitCodeProcess(pi.hProcess, ))
 ThrowLastError("GetExitCodeProcess");
 
-switch (HRESULT hr = static_cast(nExitCode))
+HRESULT hr = static_cast(nExitCode);
+
+// HRESULT_FROM_WIN32 is defined as an inline function in SDK 8.1 
without the constexpr
+// And it won't work to place it inside the switch statement.
+if (HRESULT_FROM_WIN32(ERROR_SUCCESS_REBOOT_REQUIRED) == hr)
+{
+hr = ERROR_SUCCESS_REBOOT_REQUIRED;
+}
+
+switch (hr)
 {
 case S_OK:
 case WU_S_ALREADY_INSTALLED:
 case WU_E_NOT_APPLICABLE: // Windows could lie us about its 
version, etc.
 case ERROR_SUCCESS_REBOOT_REQUIRED:
-case HRESULT_FROM_WIN32(ERROR_SUCCESS_REBOOT_REQUIRED):
 case WU_S_REBOOT_REQUIRED:
 WriteLog(hInstall, "wusa.exe succeeded with exit code", 
Num2Hex(nExitCode));
 return ERROR_SUCCESS;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 126319] FILESAVE: exporting selection to bitmap formats produces distorted output

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126319

Christopher Chavez  changed:

   What|Removed |Added

 Attachment #152697|PNG output for text box and |PNG output for upper text
description|circle  |box and circle

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126319] FILESAVE: exporting selection to bitmap formats produces distorted output

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126319

--- Comment #5 from Christopher Chavez  ---
Created attachment 152698
  --> https://bugs.documentfoundation.org/attachment.cgi?id=152698=edit
PNG output for lower text box and circle

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126319] FILESAVE: exporting selection to bitmap formats produces distorted output

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126319

--- Comment #3 from Christopher Chavez  ---
Created attachment 152696
  --> https://bugs.documentfoundation.org/attachment.cgi?id=152696=edit
PNG output for two text boxes

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126319] FILESAVE: exporting selection to bitmap formats produces distorted output

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126319

--- Comment #4 from Christopher Chavez  ---
Created attachment 152697
  --> https://bugs.documentfoundation.org/attachment.cgi?id=152697=edit
PNG output for text box and circle

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126319] FILESAVE: exporting selection to bitmap formats produces distorted output

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126319

--- Comment #2 from Christopher Chavez  ---
Created attachment 152695
  --> https://bugs.documentfoundation.org/attachment.cgi?id=152695=edit
PNG output for single text box

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126318] Drag fill adds 1 in each cell to text with an ending number

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126318

Mike Kaganski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #2 from Mike Kaganski  ---
(In reply to res06...@verizon.net from comment #1)
> If LO Calc is working as designed, how do you turn this feature off?

Holding Ctrl while dragging. See the relevant help topic, which discusses this
[1].

Closing NOTABUG.

[1] https://help.libreoffice.org/6.2/en-US/text/scalc/guide/calc_series.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126319] FILESAVE: exporting selection to bitmap formats produces distorted output

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126319

--- Comment #1 from Christopher Chavez  ---
Created attachment 152694
  --> https://bugs.documentfoundation.org/attachment.cgi?id=152694=edit
Test drawing used to produce example PNG files

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126319] New: FILESAVE: exporting selection to bitmap formats produces distorted output

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126319

Bug ID: 126319
   Summary: FILESAVE: exporting selection to bitmap formats
produces distorted output
   Product: LibreOffice
   Version: 6.2.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: chrischa...@gmx.us

Note that this issue also applies to Impress; not sure if I should have
selected a different component.

Selecting objects and then doing File > Export, checking "selection", and
saving to various bitmap image formats (bmp, png, jpeg, etc.) produces files
that are distorted (i.e. incorrect aspect ratio): usually, the objects appear
to be stretched vertically/compressed horizontally. Attempting to change the
height/width options does not prevent this issue since changing one causes the
other to be recalculated according to the (incorrect) aspect ratio.

Unfortunately, I'm not sure what the exact conditions for reproducing this are.
At first, I believed this only occurred when selecting single text boxes, and
not when selecting two text boxes or a text box plus a shape; but I have since
been able to create distorted output for selections of multiple objects.

The attached examples are of a single text box, two offset identical text
boxes, and each text box with a circle; all have some amount of distortion, but
the single text box is the most noticeable example.

This issue seems to happen regardless of OS (have reproduced on Windows, Mac
and Linux).

Earliest version I have tried so far which has this issue is 6.2.4; it does not
appear to be present in 6.1.6 or earlier.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126318] Drag fill adds 1 in each cell to text with an ending number

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126318

--- Comment #1 from res06...@verizon.net  ---

If LO Calc is working as designed, how do you turn this feature off?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126318] New: Drag fill adds 1 in each cell to text with an ending number

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126318

Bug ID: 126318
   Summary: Drag fill adds 1 in each cell to text with an ending
number
   Product: LibreOffice
   Version: 6.4.0.0.alpha0+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: res06...@verizon.net

Drag fill is adding a 1 (one) to each entry when the originating text has a
number at the end of the text. E.G. jberg88 results in:

jberg88
jberg89
jberg90
jberg91
jberg92
jberg93
jberg94
jberg95
jberg96

It doesn't matter if the text+number is typed in or copied from a text file
such as from Notepad. And it occurs in a new blank spreadsheet.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

2019-07-09 Thread Jan-Marek Glogowski (via logerrit)
 sc/qa/unit/subsequent_export-test.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 2f2f4767089512c34514896bc37823f9310e9dd4
Author: Jan-Marek Glogowski 
AuthorDate: Wed Jul 10 00:12:04 2019 +0200
Commit: Jan-Marek Glogowski 
CommitDate: Wed Jul 10 01:48:08 2019 +0200

tdf#126255 compare the URL of the exported file

xDocSh contains the original loaded file.

Change-Id: Idfe15ebd637b55590ba25c521904fbb7406a6a9a
Reviewed-on: https://gerrit.libreoffice.org/75328
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/sc/qa/unit/subsequent_export-test.cxx 
b/sc/qa/unit/subsequent_export-test.cxx
index ed7ad9df3269..82106d2bc0d2 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -3089,7 +3089,8 @@ void ScExportTest::testRelativePathsODS()
 ScDocShellRef xDocSh = loadDoc("fdo79305.", FORMAT_ODS);
 CPPUNIT_ASSERT(xDocSh.is());
 
-xmlDocPtr pDoc = XPathHelper::parseExport2(*this, *xDocSh, m_xSFactory, 
"content.xml", FORMAT_ODS);
+std::shared_ptr pTempFile = exportTo(xDocSh.get(), 
FORMAT_ODS);
+xmlDocPtr pDoc = XPathHelper::parseExport(pTempFile, m_xSFactory, 
"content.xml");
 CPPUNIT_ASSERT(pDoc);
 OUString aURL = getXPath(pDoc,
 
"/office:document-content/office:body/office:spreadsheet/table:table/table:table-row[2]/table:table-cell[2]/text:p/text:a",
 "href");
@@ -3098,7 +3099,7 @@ void ScExportTest::testRelativePathsODS()
 // there is no way to get a relative URL for the link, because ../X:/ is 
undefined.
 if (!aURL.startsWith(".."))
 {
-sal_Unicode aDocDrive = 
lcl_getWindowsDrive(xDocSh->getDocumentBaseURL());
+sal_Unicode aDocDrive = lcl_getWindowsDrive(pTempFile->GetURL());
 sal_Unicode aLinkDrive = lcl_getWindowsDrive(aURL);
 CPPUNIT_ASSERT_MESSAGE("document on the same drive but no relative 
link!",
aDocDrive != 0 && aLinkDrive != 0 && aDocDrive 
!= aLinkDrive);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 103428] [META] Properties deck/tab of the sidebar

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103428
Bug 103428 depends on bug 83618, which changed state.

Bug 83618 Summary: SIDEBAR: Paragraph dialog and SideBar Paragraph Content 
Panel -- using different source for their Line spacing values
https://bugs.documentfoundation.org/show_bug.cgi?id=83618

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113136] [META] Find & Replace Dialog

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113136
Bug 113136 depends on bug 122386, which changed state.

Bug 122386 Summary: Dragging Find dialog leaves trail until 
stopping/pausing
https://bugs.documentfoundation.org/show_bug.cgi?id=122386

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122386] Dragging Find dialog leaves trail until stopping/pausing

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122386

Aron Budea  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|UNCONFIRMED |RESOLVED
 CC||ba...@caesar.elte.hu

--- Comment #6 from Aron Budea  ---
Indeed, seems fixed for me now in the latest 6.4 bibisect repo build. Let's
close as WFM.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103542] [META] vcl: scheduler tracker bug.

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103542
Bug 103542 depends on bug 122386, which changed state.

Bug 122386 Summary: Dragging Find dialog leaves trail until 
stopping/pausing
https://bugs.documentfoundation.org/show_bug.cgi?id=122386

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa

2019-07-09 Thread Mike Kaganski (via logerrit)
 sw/qa/extras/ooxmlexport/ooxmlexport3.cxx |   38 ++
 1 file changed, 29 insertions(+), 9 deletions(-)

New commits:
commit 691e9427117f909273f648d167465802580ec770
Author: Mike Kaganski 
AuthorDate: Tue Jul 9 23:08:23 2019 +1000
Commit: Mike Kaganski 
CommitDate: Wed Jul 10 01:04:21 2019 +0200

Fix CppunitTest_sw_ooxmlexport3 on systems with DPI scaling

... after commit 3f7e8ddea89f6340cd18b5b34f5a7c5f503962be

The tests are DPI-dependent, and failed on systems with DPI other
than 96, so take that into account.

Change-Id: I0297aab7988c3b78cbd3132f21e5a101bc32c1f6
Reviewed-on: https://gerrit.libreoffice.org/75302
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 
Reviewed-by: Mike Kaganski 

diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
index bddb9323ac2f..405cba6c78a4 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
@@ -573,9 +573,15 @@ DECLARE_OOXMLEXPORT_TEST(testTdf106974_int32Crop, 
"tdf106974_int32Crop.docx")
 
 imageProperties->getPropertyValue( "GraphicCrop" ) >>= aGraphicCropStruct;
 
+// The crop is constructed in GraphicProperties::pushToPropMap, where
+// GraphicHelper::getOriginalSize tries to get graphic size in mm, then 
falls back to pixels,
+// which are then converted to mm taking screen DPI scaling into account. 
Thus, the resulting
+// values are DPI-dependent.
+const double fXScaleFactor = 96.0 / 
Application::GetDefaultDevice()->GetDPIX();
+
 CPPUNIT_ASSERT_MESSAGE(
 OString::number(aGraphicCropStruct.Right).getStr(),
-sal_Int32( 40470 ) < aGraphicCropStruct.Right );
+40470 * fXScaleFactor < aGraphicCropStruct.Right);
 }
 
 DECLARE_OOXMLEXPORT_TEST(testLineSpacingexport, "test_line_spacing.docx")
@@ -701,10 +707,17 @@ DECLARE_OOXMLEXPORT_TEST(testGIFImageCrop, 
"test_GIF_ImageCrop.docx")
 
 imageProperties->getPropertyValue( "GraphicCrop" ) >>= aGraphicCropStruct;
 
-CPPUNIT_ASSERT_EQUAL( sal_Int32( 1085 ), aGraphicCropStruct.Left );
-CPPUNIT_ASSERT_EQUAL( sal_Int32( 3651 ), aGraphicCropStruct.Right );
-CPPUNIT_ASSERT_EQUAL( sal_Int32( 953 ), aGraphicCropStruct.Top );
-CPPUNIT_ASSERT_EQUAL( sal_Int32( 1244 ), aGraphicCropStruct.Bottom );
+// The crop is constructed in GraphicProperties::pushToPropMap, where
+// GraphicHelper::getOriginalSize tries to get graphic size in mm, then 
falls back to pixels,
+// which are then converted to mm taking screen DPI scaling into account. 
Thus, the resulting
+// values are DPI-dependent.
+const double fXScaleFactor = 96.0 / 
Application::GetDefaultDevice()->GetDPIX();
+const double fYScaleFactor = 96.0 / 
Application::GetDefaultDevice()->GetDPIY();
+
+CPPUNIT_ASSERT_DOUBLES_EQUAL(1085 * fXScaleFactor, 
aGraphicCropStruct.Left, 1);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(3651 * fXScaleFactor, 
aGraphicCropStruct.Right, 1);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(953 * fYScaleFactor, aGraphicCropStruct.Top, 
1);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(1244 * fYScaleFactor, 
aGraphicCropStruct.Bottom, 1);
 }
 
 DECLARE_OOXMLEXPORT_TEST(testPNGImageCrop, "test_PNG_ImageCrop.docx")
@@ -719,10 +732,17 @@ DECLARE_OOXMLEXPORT_TEST(testPNGImageCrop, 
"test_PNG_ImageCrop.docx")
 
 imageProperties->getPropertyValue( "GraphicCrop" ) >>= aGraphicCropStruct;
 
-CPPUNIT_ASSERT_EQUAL( sal_Int32( 1058 ), aGraphicCropStruct.Left );
-CPPUNIT_ASSERT_EQUAL( sal_Int32(  ), aGraphicCropStruct.Right );
-CPPUNIT_ASSERT_EQUAL( sal_Int32( 1164 ), aGraphicCropStruct.Top );
-CPPUNIT_ASSERT_EQUAL( sal_Int32( 635 ), aGraphicCropStruct.Bottom );
+// The crop is constructed in GraphicProperties::pushToPropMap, where
+// GraphicHelper::getOriginalSize tries to get graphic size in mm, then 
falls back to pixels,
+// which are then converted to mm taking screen DPI scaling into account. 
Thus, the resulting
+// values are DPI-dependent.
+const double fXScaleFactor = 96.0 / 
Application::GetDefaultDevice()->GetDPIX();
+const double fYScaleFactor = 96.0 / 
Application::GetDefaultDevice()->GetDPIY();
+
+CPPUNIT_ASSERT_DOUBLES_EQUAL(1058 * fXScaleFactor, 
aGraphicCropStruct.Left, 1);
+CPPUNIT_ASSERT_DOUBLES_EQUAL( * fXScaleFactor, 
aGraphicCropStruct.Right, 1);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(1164 * fYScaleFactor, aGraphicCropStruct.Top, 
1);
+CPPUNIT_ASSERT_DOUBLES_EQUAL(635 * fYScaleFactor, 
aGraphicCropStruct.Bottom, 1);
 }
 
 DECLARE_OOXMLEXPORT_TEST(testTdf41542_imagePadding, 
"tdf41542_imagePadding.odt")
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - configure.ac

2019-07-09 Thread Jan-Marek Glogowski (via logerrit)
 configure.ac |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 895bfb1efde4dc4e149f42b2aed6fa71696642e6
Author: Jan-Marek Glogowski 
AuthorDate: Tue Jul 9 00:23:14 2019 +
Commit: Michael Weghorn 
CommitDate: Wed Jul 10 00:15:56 2019 +0200

Qt5 / KDE5 don't require qt_version_tag symbol

Thanks to the extensive debugging information by the reporter of
tdf#126272, I found the embedded Qt5 version tag:

$ objdump -T libvclplug_qt5lo.so | grep qt_version_tag
00..   DO *UND*   00..   Qt_5.9   qt_version_tag

So even if we try to stay Qt 5.6 compatible, this adds a dependeny
to the build Qt version. But fortunatly this symbol dependency can
be prevented by using -DQT_NO_VERSION_TAGGING, which this patch
does. We still can't be sure we don't use newer symbols, but this
way we won't prevent running with older Qt versions at all.

Change-Id: Ia85c14f888d9743645909f59867b7ad568dc6f42
Reviewed-on: https://gerrit.libreoffice.org/75280
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 
(cherry picked from commit 98df07a89dbdef020c7cd849861c5aa426021153)
Reviewed-on: https://gerrit.libreoffice.org/75296
Reviewed-by: Michael Weghorn 
(cherry picked from commit 04c8d3335b434c7d54b2001a8b3ac194040f13d1)
Reviewed-on: https://gerrit.libreoffice.org/75316

diff --git a/configure.ac b/configure.ac
index 0ff53b7aa6f7..720939dfbe59 100644
--- a/configure.ac
+++ b/configure.ac
@@ -11292,7 +11292,7 @@ then
 AC_MSG_ERROR([Qt5 libraries not found.  Please specify the root of 
your Qt5 installation by exporting QT5DIR before running "configure".])
 fi
 
-QT5_CFLAGS="-I$qt5_incdir -DQT_CLEAN_NAMESPACE -DQT_THREAD_SUPPORT"
+QT5_CFLAGS="-I$qt5_incdir -DQT_CLEAN_NAMESPACE -DQT_THREAD_SUPPORT 
-DQT_NO_VERSION_TAGGING"
 QT5_CFLAGS=$(printf '%s' "$QT5_CFLAGS" | sed -e "s/-I/${ISYSTEM?}/g")
 QT5_LIBS="-L$qt5_libdir -lQt5Core -lQt5Gui -lQt5Widgets -lQt5Network"
 
@@ -11392,7 +11392,7 @@ then
 AC_MSG_ERROR([KF5 libraries not found.  Please specify the root of 
your KF5 installation by exporting KF5DIR before running "configure".])
 fi
 
-KF5_CFLAGS="-I$kf5_incdir -I$kf5_incdir/KCoreAddons -I$kf5_incdir/KI18n 
-I$kf5_incdir/KConfigCore -I$kf5_incdir/KWindowSystem -I$kf5_incdir/KIOCore 
-I$kf5_incdir/KIOWidgets -I$kf5_incdir/KIOFileWidgets -I$qt5_incdir 
-I$qt5_incdir/QtCore -I$qt5_incdir/QtGui -I$qt5_incdir/QtWidgets 
-I$qt5_incdir/QtNetwork -DQT_CLEAN_NAMESPACE -DQT_THREAD_SUPPORT"
+KF5_CFLAGS="-I$kf5_incdir -I$kf5_incdir/KCoreAddons -I$kf5_incdir/KI18n 
-I$kf5_incdir/KConfigCore -I$kf5_incdir/KWindowSystem -I$kf5_incdir/KIOCore 
-I$kf5_incdir/KIOWidgets -I$kf5_incdir/KIOFileWidgets -I$qt5_incdir 
-I$qt5_incdir/QtCore -I$qt5_incdir/QtGui -I$qt5_incdir/QtWidgets 
-I$qt5_incdir/QtNetwork -DQT_CLEAN_NAMESPACE -DQT_THREAD_SUPPORT 
-DQT_NO_VERSION_TAGGING"
 KF5_LIBS="-L$kf5_libdir -lKF5CoreAddons -lKF5I18n -lKF5ConfigCore 
-lKF5WindowSystem -lKF5KIOCore -lKF5KIOWidgets -lKF5KIOFileWidgets 
-L$qt5_libdir -lQt5Core -lQt5Gui -lQt5Widgets -lQt5Network"
 KF5_CFLAGS=$(printf '%s' "$KF5_CFLAGS" | sed -e "s/-I/${ISYSTEM?}/g")
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 126315] Tooltip for new drop-down widget in Formula bar in Calc should be another

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126315

Heiko Tietze  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #1 from Heiko Tietze  ---
Tooltips should be informative beyond the ordinary caption. In case of
unlabelled controls it should be the minimum information. My take: "Select one
out of the most frequently functions" or alternatively "Select Function".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 126315] Tooltip for new drop-down widget in Formula bar in Calc should be another

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126315

Heiko Tietze  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #1 from Heiko Tietze  ---
Tooltips should be informative beyond the ordinary caption. In case of
unlabelled controls it should be the minimum information. My take: "Select one
out of the most frequently functions" or alternatively "Select Function".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

Reveal Codes macros now works

2019-07-09 Thread Andrew Pitonyak

There was so much static related to the orginal question, that I opted to 
simply started a new thread. 
I was provided with a linke to the orignal documents:

https://web.archive.org/web/20180326030224/http://homepages.paradise.net.nz/hillview/OOo/

There are three documents and I have the original description listed below, 
but, this is what I did. 
I ignored the original document. I have working copies of documents 2 and 3. 
They are not well tested, but, they are in the ODT format, and they seem to do 
what they are supposed. I don't think i can attach them. I can post them to my 
own site later tonight, or, I can post them in some other suggested location. 

This is the originally posted description. 

RevealCodes.sxw - This is very much a work in progress that I need some 
feedback on. The concept is to try and provide the sort of functionality that 
WordPerfect's RevealCodes. At this stage it is fairly primitive - I need 
feedback as to what people want so that I can improve it. Last updated 10 June 
2004.

RevealCodes2.sxw - This is an alternative to the above RevealCodes and is, 
perhaps, closer to the way WordPerfect works. If you want this macro to be 
improved then give me feedback! Either directly or via the forum thread: 
http://www.oooforum.org/forum/viewtopic.php?p=36976. Last updated 06 Oct 2004.

RevealCodes3.sxw - A third alternative. This macro requires to be installed to 
be able to use it - therefore it doesn't have a Demo button. Use RevealCodes2 
above for a general concept demo. This version is configurable, including 
button colours and what happens when you click a button. Last updated 
12-Nov-2004.

 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] libvisio.git: src/lib src/test

2019-07-09 Thread Libreoffice Gerrit user
 src/lib/VSD5Parser.cpp   |2 
 src/lib/VSD6Parser.cpp   |6 -
 src/lib/VSDCollector.h   |2 
 src/lib/VSDContentCollector.cpp  |5 -
 src/lib/VSDContentCollector.h|2 
 src/lib/VSDDocumentStructure.h   |   51 +
 src/lib/VSDFieldList.cpp |  104 ---
 src/lib/VSDFieldList.h   |9 +-
 src/lib/VSDParser.cpp|6 -
 src/lib/VSDStylesCollector.cpp   |2 
 src/lib/VSDStylesCollector.h |2 
 src/test/data/Visio11TextFieldsWithUnits.vsd |binary
 src/test/data/Visio6TextFieldsWithUnits.vsd  |binary
 src/test/importtest.cpp  |   11 ++
 14 files changed, 176 insertions(+), 26 deletions(-)

New commits:
commit 9bf6a30786fb75cb725fe038d77ef03e1ebc4bc0
Author: Bartosz Kosiorek 
AuthorDate: Tue Jul 9 22:54:57 2019 +0200
Commit: Bartosz Kosiorek 
CommitDate: Tue Jul 9 22:54:57 2019 +0200

tdf#126292 Fix unit conversion

Change-Id: I88711a1bf1bfd6078dc6948194449bcc91f34cce

diff --git a/src/lib/VSD5Parser.cpp b/src/lib/VSD5Parser.cpp
index f16160e..c918510 100644
--- a/src/lib/VSD5Parser.cpp
+++ b/src/lib/VSD5Parser.cpp
@@ -464,7 +464,7 @@ void 
libvisio::VSD5Parser::readTextField(librevenge::RVNGInputStream *input)
   else
   {
 double numericValue = readDouble(input);
-m_shape.m_fields.addNumericField(m_header.id, m_header.level, 
VSD_FIELD_FORMAT_Unknown, numericValue, 0x);
+m_shape.m_fields.addNumericField(m_header.id, m_header.level, 
VSD_FIELD_FORMAT_Unknown, UNIT_NoCast, numericValue, 0x);
   }
 }
 
diff --git a/src/lib/VSD6Parser.cpp b/src/lib/VSD6Parser.cpp
index d2dd941..012528e 100644
--- a/src/lib/VSD6Parser.cpp
+++ b/src/lib/VSD6Parser.cpp
@@ -337,7 +337,7 @@ void 
libvisio::VSD6Parser::readTextField(librevenge::RVNGInputStream *input)
   unsigned long initialPosition = input->tell();
   input->seek(7, librevenge::RVNG_SEEK_CUR);
   unsigned char unit = readU8(input);
-  if (unit == 0xe8)
+  if (unit == UNIT_StringWithoutUnit)
   {
 int nameId = readS32(input);
 input->seek(6, librevenge::RVNG_SEEK_CUR);
@@ -391,13 +391,13 @@ void 
libvisio::VSD6Parser::readTextField(librevenge::RVNGInputStream *input)
 
 if (blockIdx != 2)
 {
-  if (unit == 0x28)
+  if (unit == UNIT_Date)
 formatNumber = VSD_FIELD_FORMAT_MsoDateShort;
   else
 formatNumber = VSD_FIELD_FORMAT_Unknown;
 }
 
-m_shape.m_fields.addNumericField(m_header.id, m_header.level, 
formatNumber, numericValue, formatStringId);
+m_shape.m_fields.addNumericField(m_header.id, m_header.level, 
formatNumber, unit, numericValue, formatStringId);
   }
 }
 
diff --git a/src/lib/VSDCollector.h b/src/lib/VSDCollector.h
index 7286d1c..11fd25e 100644
--- a/src/lib/VSDCollector.h
+++ b/src/lib/VSDCollector.h
@@ -150,7 +150,7 @@ public:
   // Field list
   virtual void collectFieldList(unsigned id, unsigned level) = 0;
   virtual void collectTextField(unsigned id, unsigned level, int nameId, int 
formatStringId) = 0;
-  virtual void collectNumericField(unsigned id, unsigned level, unsigned short 
format, double number, int formatStringId) = 0;
+  virtual void collectNumericField(unsigned id, unsigned level, unsigned short 
format, unsigned short unit, double number, int formatStringId) = 0;
 
   // Metadata
   virtual void collectMetaData(const librevenge::RVNGPropertyList ) = 
0;
diff --git a/src/lib/VSDContentCollector.cpp b/src/lib/VSDContentCollector.cpp
index e15b4d9..e808b21 100644
--- a/src/lib/VSDContentCollector.cpp
+++ b/src/lib/VSDContentCollector.cpp
@@ -3436,7 +3436,7 @@ void 
libvisio::VSDContentCollector::collectTextField(unsigned id, unsigned level
   }
 }
 
-void libvisio::VSDContentCollector::collectNumericField(unsigned id, unsigned 
level, unsigned short format, double number, int formatStringId)
+void libvisio::VSDContentCollector::collectNumericField(unsigned id, unsigned 
level, unsigned short format, unsigned short unit, double number, int 
formatStringId)
 {
   _handleLevelChange(level);
   VSDFieldListElement *pElement = m_stencilFields.getElement(m_fields.size());
@@ -3446,6 +3446,7 @@ void 
libvisio::VSDContentCollector::collectNumericField(unsigned id, unsigned le
 if (element)
 {
   element->setValue(number);
+  element->setUnit(unit);
   if (format == VSD_FIELD_FORMAT_Unknown)
   {
 std::map::const_iterator iter = 
m_names.find(formatStringId);
@@ -3460,7 +3461,7 @@ void 
libvisio::VSDContentCollector::collectNumericField(unsigned id, unsigned le
   }
   else
   {
-VSDNumericField tmpField(id, level, format, number, formatStringId);
+VSDNumericField tmpField(id, level, format, unit, number, formatStringId);
 m_fields.push_back(tmpField.getString(m_names));
   }
 }
diff --git a/src/lib/VSDContentCollector.h 

RE: tdf#74702 2/2

2019-07-09 Thread Adrien Ollier



De : Michael Stahl 
Envoyé : lundi 8 juillet 2019 13:15
À : Tomaž Vajngerl; Adrien Ollier
Cc : libreoffice@lists.freedesktop.org
Objet : Re: tdf#74702 2/2

On 08.07.19 13:06, Tomaž Vajngerl wrote:
> Hi,
>
> On 06.07.19 19:59, Adrien Ollier wrote:
> 
>
>
> Well IMHO the problem that you even have to think about this is that
> OutputDevice is a enormous class, and then you have to deal with another
> even more enormous subclass vcl::Window, which should never be a
> subclass of OutputDevice in the first place. However the work to change
> that is quite big and non-trivial.

i rarely work with VCL's implementation so i can't really have an
informed opinion but if you say that delegation instead of inheritance
would be an improvement here i'm all for it.


Hello Michael,

thank you for your answer.
Can you explain what delegation means for you? I don't understand what you mean.

Also, I quite disagree with you.
First, C++ allows an overriding function to have a return type that is a 
subclass of the return type of the overridden function. You can ensure this by 
running the following example program:

#include 

struct A
{
A() = default;
A(const A&) = default;
A(A&&) = default;
virtual ~A() = default;
};

struct B : A {};

struct C
{
virtual A* getNewInstance() const { return new A{}; }
};

struct D : C
{
B* getNewInstance() const override { return new B{}; }
};

int main(int argc, char* argv[])
{
D d;
A* a = d.getNewInstance();
delete a;

return 0;
}

Also, let's take a concrete example:
https://opengrok.libreoffice.org/xref/core/vcl/source/control/edit.cxx?r=d00ee2cb
void Edit::Draw(OutputDevice* pDev, const Point& rPos, const Size& rSize, 
DrawFlags nFlags)
see l.1771

Can you tell me how you would remove the use of GetOutDevType?


Regards,
Adrien Ollier
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 126317] New: Saving to remote (Webdav) freezes Libreoffice for a long time

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126317

Bug ID: 126317
   Summary: Saving to remote (Webdav) freezes Libreoffice for a
long time
   Product: LibreOffice
   Version: 6.2.4.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: filters and storage
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jens-libreoff...@spamfreemail.de

Description:
I am saving files to a webdav (Nextcloud) instance.
When I do this, every save operation takes ~5..10 seconds to finish.
This may be realistic (files are >1MB and my DSL uplink is 10MBit) but it makes
for a terrible user experience.

I wonder if the save operation can be done in its own thread so it doesn't
block other Libreoffice windows, and the whole UI?

Steps to Reproduce:
1. Open a >1MB file on webdav server which was previously configured.
2. Save
3. Record the time the LIbreoffice UI is frozen

Actual Results:
Libreoffice UI is frozen

Expected Results:
Libreoffice UI should not freeze just because of a slow save target location.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.2.4.2
Build-ID: 1:6.2.4-0ubuntu0.18.04.1~lo1
CPU-Threads: 4; BS: Linux 4.15; UI-Render: Standard; VCL: kde5; 
Gebietsschema: de-DE (de_DE.UTF-8); UI-Sprache: de-DE
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47746] "Code folding" for Writer / Collapse or expand parts of a document

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=47746

--- Comment #20 from aslmx  ---
I've been told this is possible in Word. Searched if this feature exists in LO
and after some minutes I find this feature request.

+1 

 Folding text for the sake of having a better overview or because a piece of
text is not needed right now is a feature i want to see in LO.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126316] [EDITING] Selecting text with the mouse automatically places the text in the clipboard

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126316

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |glo...@fbihome.de
   |desktop.org |

--- Comment #2 from Jan-Marek Glogowski  ---
Regression from 

commit ce9795954d3957e98d24bf711869efd846df6f15
Author: Caolán McNamara 
Date:   Tue Jun 18 14:04:27 2019 +0100

fix crash in header/footer calc dialog

cut and paste can happen when the EditView isn't in a vcl::Window

That replaced some GetPrimarySelection() with GetClipboard().

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/unx

2019-07-09 Thread Jan-Marek Glogowski (via logerrit)
 vcl/unx/kde4/KDESalInstance.cxx |7 +++
 vcl/unx/kde4/KDESalInstance.hxx |3 +++
 2 files changed, 10 insertions(+)

New commits:
commit cd98258b659d98871787fa932698a290b20f56cf
Author: Jan-Marek Glogowski 
AuthorDate: Tue Jul 9 03:15:28 2019 +0200
Commit: Katarina Behrens 
CommitDate: Tue Jul 9 22:21:18 2019 +0200

KDE4 create KDESalGraphics based X11VirtualDevice

In the spirit of commit 5ee408eb4c9f ("tdf#125673 KDE5 implement
a KDE5SalVirtualDevice"), this might help with KDE4 graphics
problems, like the ones mentioned in tdf#126272.

Change-Id: I50875b69e1c1494803f08746bfc3b99a57e36414
Reviewed-on: https://gerrit.libreoffice.org/75281
Tested-by: Jenkins
Reviewed-by: Katarina Behrens 

diff --git a/vcl/unx/kde4/KDESalInstance.cxx b/vcl/unx/kde4/KDESalInstance.cxx
index c11d62689b52..e487bb00362b 100644
--- a/vcl/unx/kde4/KDESalInstance.cxx
+++ b/vcl/unx/kde4/KDESalInstance.cxx
@@ -24,6 +24,7 @@
 
 #include "KDEXLib.hxx"
 #include "KDESalDisplay.hxx"
+#include "KDESalGraphics.hxx"
 
 #include 
 #include 
@@ -63,4 +64,10 @@ bool KDESalInstance::IsMainThread() const
 return qApp->thread() == QThread::currentThread();
 }
 
+std::unique_ptr 
KDESalInstance::CreateVirtualDevice(SalGraphics* pGraphics,
+long , long , DeviceFormat eFormat, const SystemGraphicsData 
*pData)
+{
+return CreateX11VirtualDevice(pGraphics, nDX, nDY, eFormat, pData, 
o3tl::make_unique());
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/unx/kde4/KDESalInstance.hxx b/vcl/unx/kde4/KDESalInstance.hxx
index 87328a88406e..589b485299d3 100644
--- a/vcl/unx/kde4/KDESalInstance.hxx
+++ b/vcl/unx/kde4/KDESalInstance.hxx
@@ -40,6 +40,9 @@ public:
   css::uno::XComponentContext >& ) override;
 
 virtual bool IsMainThread() const override;
+
+std::unique_ptr CreateVirtualDevice(SalGraphics* 
pGraphics,
+long , long , DeviceFormat eFormat, const SystemGraphicsData 
*pData) override;
 };
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 47055] EDITING: Cannot comment on block of text

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=47055

--- Comment #2 from Munna  ---
Great, what an amazing post I like this post this is really an awesome post
visitors should visit here on this website.
https://windows10download.xyz/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] libvisio.git: src/lib

2019-07-09 Thread Libreoffice Gerrit user
 src/lib/VSD5Parser.cpp  |2 +-
 src/lib/VSD6Parser.cpp  |   10 +-
 src/lib/VSDContentCollector.cpp |4 ++--
 src/lib/VSDParser.cpp   |   10 +-
 4 files changed, 13 insertions(+), 13 deletions(-)

New commits:
commit 187e3c83fe021267b913068432d1387ea140944a
Author: Bartosz Kosiorek 
AuthorDate: Mon Jul 8 22:06:47 2019 +0200
Commit: Bartosz Kosiorek 
CommitDate: Tue Jul 9 21:44:44 2019 +0200

Replace magic numbers with defines

Change-Id: I76211f335341c4ebc40c38766dc04969d3b420df
Reviewed-on: https://gerrit.libreoffice.org/75245
Reviewed-by: Bartosz Kosiorek 
Tested-by: Bartosz Kosiorek 

diff --git a/src/lib/VSD5Parser.cpp b/src/lib/VSD5Parser.cpp
index cfc0d94..f16160e 100644
--- a/src/lib/VSD5Parser.cpp
+++ b/src/lib/VSD5Parser.cpp
@@ -464,7 +464,7 @@ void 
libvisio::VSD5Parser::readTextField(librevenge::RVNGInputStream *input)
   else
   {
 double numericValue = readDouble(input);
-m_shape.m_fields.addNumericField(m_header.id, m_header.level, 0x, 
numericValue, 0x);
+m_shape.m_fields.addNumericField(m_header.id, m_header.level, 
VSD_FIELD_FORMAT_Unknown, numericValue, 0x);
   }
 }
 
diff --git a/src/lib/VSD6Parser.cpp b/src/lib/VSD6Parser.cpp
index a41016b..d2dd941 100644
--- a/src/lib/VSD6Parser.cpp
+++ b/src/lib/VSD6Parser.cpp
@@ -336,8 +336,8 @@ void 
libvisio::VSD6Parser::readTextField(librevenge::RVNGInputStream *input)
 {
   unsigned long initialPosition = input->tell();
   input->seek(7, librevenge::RVNG_SEEK_CUR);
-  unsigned char tmpCode = readU8(input);
-  if (tmpCode == 0xe8)
+  unsigned char unit = readU8(input);
+  if (unit == 0xe8)
   {
 int nameId = readS32(input);
 input->seek(6, librevenge::RVNG_SEEK_CUR);
@@ -391,10 +391,10 @@ void 
libvisio::VSD6Parser::readTextField(librevenge::RVNGInputStream *input)
 
 if (blockIdx != 2)
 {
-  if (tmpCode == 0x28)
-formatNumber = 200;
+  if (unit == 0x28)
+formatNumber = VSD_FIELD_FORMAT_MsoDateShort;
   else
-formatNumber = 0x;
+formatNumber = VSD_FIELD_FORMAT_Unknown;
 }
 
 m_shape.m_fields.addNumericField(m_header.id, m_header.level, 
formatNumber, numericValue, formatStringId);
diff --git a/src/lib/VSDContentCollector.cpp b/src/lib/VSDContentCollector.cpp
index 27b7195..e15b4d9 100644
--- a/src/lib/VSDContentCollector.cpp
+++ b/src/lib/VSDContentCollector.cpp
@@ -3446,13 +3446,13 @@ void 
libvisio::VSDContentCollector::collectNumericField(unsigned id, unsigned le
 if (element)
 {
   element->setValue(number);
-  if (format == 0x)
+  if (format == VSD_FIELD_FORMAT_Unknown)
   {
 std::map::const_iterator iter = 
m_names.find(formatStringId);
 if (iter != m_names.end())
   parseFormatId(iter->second.cstr(), format);
   }
-  if (format != 0x)
+  if (format != VSD_FIELD_FORMAT_Unknown)
 element->setFormat(format);
 
   m_fields.push_back(element->getString(m_names));
diff --git a/src/lib/VSDParser.cpp b/src/lib/VSDParser.cpp
index 71b56ce..cc0bb96 100644
--- a/src/lib/VSDParser.cpp
+++ b/src/lib/VSDParser.cpp
@@ -2172,8 +2172,8 @@ void 
libvisio::VSDParser::readTextField(librevenge::RVNGInputStream *input)
 {
   unsigned long initialPosition = input->tell();
   input->seek(7, librevenge::RVNG_SEEK_CUR);
-  unsigned char tmpCode = readU8(input);
-  if (tmpCode == 0xe8)
+  unsigned char unit = readU8(input);
+  if (unit == 0xe8)
   {
 int nameId = readS32(input);
 input->seek(6, librevenge::RVNG_SEEK_CUR);
@@ -2227,10 +2227,10 @@ void 
libvisio::VSDParser::readTextField(librevenge::RVNGInputStream *input)
 
 if (blockIdx != 2)
 {
-  if (tmpCode == 0x28)
-formatNumber = 200;
+  if (unit == 0x28)
+formatNumber = VSD_FIELD_FORMAT_MsoDateShort;
   else
-formatNumber = 0x;
+formatNumber = VSD_FIELD_FORMAT_Unknown;
 }
 
 m_shape.m_fields.addNumericField(m_header.id, m_header.level, 
formatNumber, numericValue, formatStringId);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sd/uiconfig

2019-07-09 Thread andreas kainz (via logerrit)
 sd/uiconfig/sdraw/ui/notebookbar_compact.ui|2 +-
 sd/uiconfig/simpress/ui/notebookbar_compact.ui |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 2be31163b54862076fed47a032761139318da02c
Author: andreas kainz 
AuthorDate: Mon Jul 8 23:37:10 2019 +0200
Commit: andreas_kainz 
CommitDate: Tue Jul 9 21:41:49 2019 +0200

NB tabbed_compact sd apps fix wrong DrawText command

Change-Id: Icdad248e46172ba161de86bfb3f4edae4ef43139
Reviewed-on: https://gerrit.libreoffice.org/75253
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/sd/uiconfig/sdraw/ui/notebookbar_compact.ui 
b/sd/uiconfig/sdraw/ui/notebookbar_compact.ui
index aa63fb1d9d15..725b9e60b5cd 100644
--- a/sd/uiconfig/sdraw/ui/notebookbar_compact.ui
+++ b/sd/uiconfig/sdraw/ui/notebookbar_compact.ui
@@ -5065,7 +5065,7 @@
   
 True
 False
-.uno:DrawText
+.uno:Text
   
   
 False
diff --git a/sd/uiconfig/simpress/ui/notebookbar_compact.ui 
b/sd/uiconfig/simpress/ui/notebookbar_compact.ui
index 34416a75e6cb..591a2c68674e 100644
--- a/sd/uiconfig/simpress/ui/notebookbar_compact.ui
+++ b/sd/uiconfig/simpress/ui/notebookbar_compact.ui
@@ -5338,7 +5338,7 @@
   
 True
 False
-.uno:DrawText
+.uno:Text
   
   
 False
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/uiconfig

2019-07-09 Thread andreas kainz (via logerrit)
 sw/uiconfig/swriter/ui/notebookbar_single.ui |   10 --
 1 file changed, 4 insertions(+), 6 deletions(-)

New commits:
commit a9359cf49ad9367d536d239187d7ef615709ea53
Author: andreas kainz 
AuthorDate: Mon Jul 8 23:32:26 2019 +0200
Commit: andreas_kainz 
CommitDate: Tue Jul 9 21:41:19 2019 +0200

NB writer tabbed_single: fix wrong alignment of commands

Change-Id: Ic5001f86cfb0b403fd05aa2609ebb395a9e514b1
Reviewed-on: https://gerrit.libreoffice.org/75250
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/sw/uiconfig/swriter/ui/notebookbar_single.ui 
b/sw/uiconfig/swriter/ui/notebookbar_single.ui
index 5387187d67ff..307eea196e9c 100644
--- a/sw/uiconfig/swriter/ui/notebookbar_single.ui
+++ b/sw/uiconfig/swriter/ui/notebookbar_single.ui
@@ -450,8 +450,8 @@
 True
 False
 center
-8
-8
+5
+5
 vertical
   
   
@@ -465,7 +465,6 @@
   
 True
 False
-5
 False
 
   
@@ -1716,8 +1715,8 @@
 True
 False
 center
-8
-8
+5
+5
 vertical
   
   
@@ -1731,7 +1730,6 @@
   
 True
 False
-5
 False
 
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sw/uiconfig

2019-07-09 Thread andreas kainz (via logerrit)
 sw/uiconfig/swriter/ui/notebookbar_single.ui |   10 --
 1 file changed, 4 insertions(+), 6 deletions(-)

New commits:
commit 0a51030808d7142db808d8445eb9f8a56303292b
Author: andreas kainz 
AuthorDate: Mon Jul 8 23:32:26 2019 +0200
Commit: andreas_kainz 
CommitDate: Tue Jul 9 21:41:31 2019 +0200

NB writer tabbed_single: fix wrong alignment of commands

Change-Id: Ic5001f86cfb0b403fd05aa2609ebb395a9e514b1
Reviewed-on: https://gerrit.libreoffice.org/75252
Tested-by: Jenkins
Reviewed-by: andreas_kainz 

diff --git a/sw/uiconfig/swriter/ui/notebookbar_single.ui 
b/sw/uiconfig/swriter/ui/notebookbar_single.ui
index 5387187d67ff..307eea196e9c 100644
--- a/sw/uiconfig/swriter/ui/notebookbar_single.ui
+++ b/sw/uiconfig/swriter/ui/notebookbar_single.ui
@@ -450,8 +450,8 @@
 True
 False
 center
-8
-8
+5
+5
 vertical
   
   
@@ -465,7 +465,6 @@
   
 True
 False
-5
 False
 
   
@@ -1716,8 +1715,8 @@
 True
 False
 center
-8
-8
+5
+5
 vertical
   
   
@@ -1731,7 +1730,6 @@
   
 True
 False
-5
 False
 
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125987] LibreOffice Online Delete Slide does not work from the upper menu

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125987

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #4 from Aron Budea  ---
That version is from ~6 months ago, please update and try again.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: CppunitTest_sw_ooxmlexport3 broken on HiDPI setup

2019-07-09 Thread Jan-Marek Glogowski

Am 09.07.19 um 21:31 schrieb Luke Benes:
> Ever since the additional unit tests were enabled with
> https://cgit.freedesktop.org/libreoffice/core/commit/?id=3f7e8ddea89f6340cd18b5b34f5a7c5f503962be
> 
> The CppunitTest_sw_ooxmlexport3 unit test is failing when display scaling 
> does not equal 100%

https://gerrit.libreoffice.org/#/c/75302/

If you can test, I can't.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

CppunitTest_sw_ooxmlexport3 broken on HiDPI setup

2019-07-09 Thread Luke Benes
Ever since the additional unit tests were enabled with
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3f7e8ddea89f6340cd18b5b34f5a7c5f503962be

The CppunitTest_sw_ooxmlexport3 unit test is failing when display scaling does 
not equal 100%


For 125% the test is failing with the following errors:



[build CUT] sw_ooxmlexport3
test_GIF_ImageCrop.docx:
D:/core/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx:704:testGIFImageCrop::Import
equality assertion failed
- Expected: 1085
- Actual  : 868

testGIFImageCrop::Import finished in: 689ms
File tested,Execution Time (ms)
test_GIF_ImageCrop.docx:
D:/core/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx:704:testGIFImageCrop::Import_Export_Import
equality assertion failed
- Expected: 1085
- Actual  : 868

File tested,Execution Time (ms)
E:  file lt-string.c: line 189: assertion `string != ((void *)0)' failed
E:  sfile lt-string.c: line 189: assertion `string != ((void *)0)' failed
E:  sfile lt-string.c: line 189: assertion `string != ((void *)0)' failed
E:  l)file lt-string.c: line 189: assertion `string != ((void *)0)' failed
mce.docx:
420
testMce::Import finished in: 440ms
test_PNG_ImageCrop.docx:
D:/core/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx:722:testPNGImageCrop::Import
equality assertion failed
- Expected: 1058
- Actual  : 847

testPNGImageCrop::Import finished in: 385ms
File tested,Execution Time (ms)
test_PNG_ImageCrop.docx:
D:/core/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx:722:testPNGImageCrop::Import_Export_Import
equality assertion failed
- Expected: 1058
- Actual  : 847

tdf106974_int32Crop.docx:
D:/core/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx:578:testTdf106974_int32Crop::Import
assertion failed
- Expression: sal_Int32( 40470 ) < aGraphicCropStruct.Right
- 37107

testTdf106974_int32Crop::Import finished in: 454ms
File tested,Execution Time (ms)
tdf106974_int32Crop.docx:
D:/core/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx:578:testTdf106974_int32Crop::Import_Export_Import
assertion failed
- Expression: sal_Int32( 40470 ) < aGraphicCropStruct.Right
- 37110

testTdf106974_int32Crop::Import_Export_Import finished in: 2363ms

floatingtbl_with_formula.docx:
1856
testFileOpenInputOutputError::Import_Export_Import finished in: 1881ms
D:/core/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx(704) : error : Assertion
Test name: testGIFImageCrop::Import
equality assertion failed
- Expected: 1085
- Actual  : 868

D:/core/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx(704) : error : Assertion
Test name: testGIFImageCrop::Import_Export_Import
equality assertion failed
- Expected: 1085
- Actual  : 868

D:/core/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx(722) : error : Assertion
Test name: testPNGImageCrop::Import
equality assertion failed
- Expected: 1058
- Actual  : 847

D:/core/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx(722) : error : Assertion
Test name: testPNGImageCrop::Import_Export_Import
equality assertion failed
- Expected: 1058
- Actual  : 847

D:/core/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx(578) : error : Assertion
Test name: testTdf106974_int32Crop::Import
assertion failed
- Expression: sal_Int32( 40470 ) < aGraphicCropStruct.Right
- 37107

D:/core/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx(578) : error : Assertion
Test name: testTdf106974_int32Crop::Import_Export_Import
assertion failed
- Expression: sal_Int32( 40470 ) < aGraphicCropStruct.Right
- 37110

Failures !!!
Run: 90   Failure total: 6   Failures: 6   Errors: 0

Error: a unit test failed, please do one of:
make CppunitTest_sw_ooxmlexport3 CPPUNITTRACE=TRUE # which is a shortcut for 
the following line
make CppunitTest_sw_ooxmlexport3 CPPUNITTRACE="'C:/Program Files 
(x86)/Microsoft Visual Studio/2017/Community/Common7/IDE/devenv.exe' /debugexe" 
# for interactive debugging in Visual Studio
make CppunitTest_sw_ooxmlexport3 CPPUNITTRACE="drmemory -free_max_frames 20" # 
for memory checking (install Dr.Memory first, and put it to your PATH)

You can limit the execution to just one particular test by:

make CppunitTest_sw_ooxmlexport3 CPPUNIT_TEST_NAME="testXYZ" ...above mentioned 
params...

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 125401] FILESAVE: Saving a document creates a new file (new inode number) thereby messing-up with the creation time of the document

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125401

--- Comment #16 from Alex  ---
PS: I realize I was maybe not very clear either in my initial explanation,
sorry about that...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126314] FILEOPEN: DOCX: Incorrect height of line

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126314

--- Comment #3 from Gabor Kelemen  ---
Created attachment 152693
  --> https://bugs.documentfoundation.org/attachment.cgi?id=152693=edit
Screenshot of the document in LO 6.0 and 6.4master

It was "normal" text but now it's all subscript for me on a current-ish local
master build.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125401] FILESAVE: Saving a document creates a new file (new inode number) thereby messing-up with the creation time of the document

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125401

--- Comment #15 from Alex  ---
(In reply to Miklos Vajna from comment #14)
> I got back to this and I'm afraid 'cp -a' can't copy the creation time of
> the destination document after all.
> 
> Here is what I tried:
> 
> 1) Save test.odt using Writer.
> 
> 2) Check creation time:
> 
> $ sudo debugfs -R "stat $PWD/test.odt" /dev/mapper/system-root | grep crtime
> crtime: 0x5d246d4a:24aeed68 -- Tue Jul  9 12:32:42 2019
> 
> 3) 'cp -a test.odt test2.odt'
> 
> 4) Check creation time of test2.odt:
> 
> $ sudo debugfs -R "stat $PWD/test2.odt" /dev/mapper/system-root | grep crtime
> crtime: 0x5d246eaf:7a4c63cc -- Tue Jul  9 12:38:39 2019
> 
> Based on this, I still think we can't do much here -> closing, sorry. The
> document has meta.xml BTW, which always contains the creation / modification
> time, and that is correct.
> 
> If it is discovered that there is some sane API we can use, similar to
> stat() and S_ISLNK(), then it would make sense to reopen this.
> 
> (Marking as "not our bug", given that this works fine on Windows, it's a
> shorcoming of the APIs we have available inside #ifdef UNX, I would say.)

Hello Miklos and thank you for looking into this.

Following your explanation, I fear you did not get the point.

Of course if you copy a file using 'cp -a SOURCE DEST' to a NEW (non existing)
destination file DEST, the new destination will have an updated creation time
(since it is created at the time the 'cp' command is called.

However, the command 'cp -a SOURCE DEST' applied to an already existing DEST
file preserves the creation time of DEST.

This is what could be used to preserve the creation time of any document being
edited, where SOURCE would be the cached and currently being edited version,
and DEST the initial file from which the edition resumed.

Could you consider reassessing the scenario and therefore maybe reopening the
bug?

Thanks,

Alex

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125987] LibreOffice Online Delete Slide does not work from the upper menu

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125987

--- Comment #3 from Brenda McDonald  ---
.odp files have the same problem for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125987] LibreOffice Online Delete Slide does not work from the upper menu

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125987

--- Comment #2 from Brenda McDonald  ---
Created attachment 152692
  --> https://bugs.documentfoundation.org/attachment.cgi?id=152692=edit
LibreOfficeOnline Version Information

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126295] Unable to open files in LO Calc -- timeout waiting for threadpool tasks

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126295

--- Comment #3 from res06...@verizon.net  ---
Version: 6.2.4.2 (x64)
Build ID: 2412653d852ce75f65fbfa83fb7e7b669a126d64
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

I'm a new user.

See
https://forum.openoffice.org/en/forum/viewtopic.php?f=9=98440=472895=472895
for a discussion of what I'm trying to do, and the solution.

The problem in opening the file occurs during "Adapt row height".

There are 81,000+ rows in the failing file on Sheet1. Resetting the profile to
factory settings did not solve the problem.

I also experienced the problem while doing drag fill in a column where I'm
using SUMPRODUCT. In about the middle of the file, after changing the range in
the formula, I went beyond the range in the formula with the drag fill.
CGH

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-android-20'

2019-07-09 Thread Jan Holesovsky (via logerrit)
Tag 'cp-android-20' created by Jan Holesovsky  at 
2019-07-09 18:31 +

cp-android-20

Changes since co-6.0-33-19:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Changes to 'refs/tags/cp-android-20'

2019-07-09 Thread Jan Holesovsky (via logerrit)
Tag 'cp-android-20' created by Jan Holesovsky  at 
2019-07-09 18:31 +

cp-android-20

Changes since cp-android-19-29:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 126013] Writer failed to load background from a DOC file

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126013

--- Comment #4 from Volga  ---
This bug is still affect

版本: 6.3.0.1 (x64)
Build ID: 41ac97386aba908b6db860cfb4cfe2da871886ae
CPU 线程: 4; 操作系统: Windows 10.0; UI 渲染: 默认; VCL: win; 
区域语言: zh-CN (zh_CN); UI 语言: zh-CN
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

2019-07-09 Thread Jan-Marek Glogowski (via logerrit)
 sc/qa/unit/subsequent_export-test.cxx |   23 +++
 1 file changed, 23 insertions(+)

New commits:
commit 3f1527fba7b9fe729e421322a9ea91a24aa495e0
Author: Jan-Marek Glogowski 
AuthorDate: Tue Jul 9 14:11:58 2019 +
Commit: Jan-Marek Glogowski 
CommitDate: Tue Jul 9 20:15:56 2019 +0200

tdf#126255 handle _WIN32 with different drive letters

Copying the source comment: if the exported document is not on the
same drive then the linked document, there is no way to get a
relative URL for the link, because ../X:/ is undefined.

Change-Id: Ic83be54d878f968daa027918ce0f588774044a94
Reviewed-on: https://gerrit.libreoffice.org/75306
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/sc/qa/unit/subsequent_export-test.cxx 
b/sc/qa/unit/subsequent_export-test.cxx
index 473be4c8593b..ed7ad9df3269 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -3073,6 +3073,17 @@ void ScExportTest::testCustomXml()
 CPPUNIT_ASSERT(pStream);
 }
 
+#ifdef _WIN32
+static sal_Unicode lcl_getWindowsDrive(const OUString& aURL)
+{
+static const sal_Int32 nMinLen = strlen("file:///X:/");
+if (aURL.getLength() <= nMinLen)
+return 0;
+const OUString aUrlStart = aURL.copy(0, nMinLen);
+return (aUrlStart.startsWith("file:///") && aUrlStart.endsWith(":/")) ? 
aUrlStart[8] : 0;
+}
+#endif
+
 void ScExportTest::testRelativePathsODS()
 {
 ScDocShellRef xDocSh = loadDoc("fdo79305.", FORMAT_ODS);
@@ -3082,6 +3093,18 @@ void ScExportTest::testRelativePathsODS()
 CPPUNIT_ASSERT(pDoc);
 OUString aURL = getXPath(pDoc,
 
"/office:document-content/office:body/office:spreadsheet/table:table/table:table-row[2]/table:table-cell[2]/text:p/text:a",
 "href");
+#ifdef _WIN32
+// if the exported document is not on the same drive then the linked 
document,
+// there is no way to get a relative URL for the link, because ../X:/ is 
undefined.
+if (!aURL.startsWith(".."))
+{
+sal_Unicode aDocDrive = 
lcl_getWindowsDrive(xDocSh->getDocumentBaseURL());
+sal_Unicode aLinkDrive = lcl_getWindowsDrive(aURL);
+CPPUNIT_ASSERT_MESSAGE("document on the same drive but no relative 
link!",
+   aDocDrive != 0 && aLinkDrive != 0 && aDocDrive 
!= aLinkDrive);
+return;
+}
+#endif
 // make sure that the URL is relative
 CPPUNIT_ASSERT(aURL.startsWith(".."));
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125987] LibreOffice Online Delete Slide does not work from the upper menu

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125987

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
 Whiteboard| QA:needsComment|

--- Comment #1 from Aron Budea  ---
This works for me even with a PowerPoint presentation, and also with ODP. Does
an ODP presentation behave differently? Which version of LibreOffice Online are
you using?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/inc sw/qa sw/source

2019-07-09 Thread Miklos Vajna (via logerrit)
 sw/inc/HandleAnchorNodeChg.hxx|5 +
 sw/qa/extras/uiwriter/data2/image-comment-at-char.odt |binary
 sw/qa/extras/uiwriter/uiwriter2.cxx   |   29 +++
 sw/source/core/layout/atrfrm.cxx  |   69 --
 4 files changed, 99 insertions(+), 4 deletions(-)

New commits:
commit 5da29a31903e0c11802548327b41511519e61d7d
Author: Miklos Vajna 
AuthorDate: Tue Jul 9 17:48:14 2019 +0200
Commit: Miklos Vajna 
CommitDate: Tue Jul 9 20:01:55 2019 +0200

sw comments on frames: fix comment handling when changing at-char anchor

If the user drags the at-char image and the anchor changes, then need to
update the comment anchor (and its annotation range) as well. Use the
same API that's used by SwTransferable::PrivateDrop(), except work with
doc model positions, not with screen coordinates, like drag does.

Change-Id: Ib9610b3eddc77f9973b68a1c5c8cdbe1f7079ab9
Reviewed-on: https://gerrit.libreoffice.org/75312
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sw/inc/HandleAnchorNodeChg.hxx b/sw/inc/HandleAnchorNodeChg.hxx
index 7453e4e6b9be..e01da4c932a6 100644
--- a/sw/inc/HandleAnchorNodeChg.hxx
+++ b/sw/inc/HandleAnchorNodeChg.hxx
@@ -59,6 +59,11 @@ private:
 // and that re-creation of fly frames is necessary.
 bool mbAnchorNodeChanged;
 
+/// If the fly frame has a comment, this points to the old comment anchor.
+std::unique_ptr mpCommentAnchor;
+
+SwWrtShell* mpWrtShell;
+
 SwHandleAnchorNodeChg( const SwHandleAnchorNodeChg& ) = delete;
 void operator=( const SwHandleAnchorNodeChg ) = delete;
 };
diff --git a/sw/qa/extras/uiwriter/data2/image-comment-at-char.odt 
b/sw/qa/extras/uiwriter/data2/image-comment-at-char.odt
index a3638ffe7276..ac6a06780a81 100644
Binary files a/sw/qa/extras/uiwriter/data2/image-comment-at-char.odt and 
b/sw/qa/extras/uiwriter/data2/image-comment-at-char.odt differ
diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx 
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index b0c08917e787..83a49883dbc6 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -1647,6 +1647,35 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, 
testImageCommentAtChar)
 // 1', i.e. the comment of the image was not deleted when the image was 
deleted.
 CPPUNIT_ASSERT_EQUAL(static_cast(0),
  
pDoc->getIDocumentMarkAccess()->getAnnotationMarksCount());
+
+// Undo the deletion and move the image down, so the anchor changes.
+pView->GetViewFrame()->GetDispatcher()->Execute(SID_UNDO, 
SfxCallMode::SYNCHRON);
+CPPUNIT_ASSERT_EQUAL(static_cast(1),
+ 
pDoc->getIDocumentMarkAccess()->getAnnotationMarksCount());
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+Point aNewAnchor = pWrtShell->GetFlyRect().TopLeft();
+aNewAnchor.Move(0, 600);
+pWrtShell->SetFlyPos(aNewAnchor);
+
+// Get the image anchor doc model position.
+SwFlyFrame* pFly = pWrtShell->GetCurrFlyFrame(false);
+CPPUNIT_ASSERT(pFly);
+SwFrameFormat& rFlyFormat = pFly->GetFrameFormat();
+const SwPosition* pImageAnchor = rFlyFormat.GetAnchor().GetContentAnchor();
+CPPUNIT_ASSERT(pImageAnchor);
+
+// Get the annotation mark doc model start.
+auto it = pDoc->getIDocumentMarkAccess()->getAnnotationMarksBegin();
+CPPUNIT_ASSERT(it != 
pDoc->getIDocumentMarkAccess()->getAnnotationMarksEnd());
+const sw::mark::IMark* pMark = *it;
+const SwPosition& rAnnotationMarkStart = pMark->GetMarkPos();
+
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: SwPosition (node 14, offset 15)
+// - Actual  : SwPosition (node 12, offset 3)
+// This means moving the image anchor did not move the comment anchor / 
annotation mark, so the
+// image and its comment got out of sync.
+CPPUNIT_ASSERT_EQUAL(*pImageAnchor, rAnnotationMarkStart);
 }
 
 CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf120338)
diff --git a/sw/source/core/layout/atrfrm.cxx b/sw/source/core/layout/atrfrm.cxx
index 0cbb44249644..4969bdc54599 100644
--- a/sw/source/core/layout/atrfrm.cxx
+++ b/sw/source/core/layout/atrfrm.cxx
@@ -87,13 +87,13 @@
 #include 
 #include 
 
-#ifndef NDEBUG
 #include 
-#endif
 
 #include 
 #include 
 #include 
+#include 
+#include 
 
 using namespace ::com::sun::star;
 
@@ -3224,15 +3224,16 @@ SwHandleAnchorNodeChg::SwHandleAnchorNodeChg( 
SwFlyFrameFormat& _rFlyFrameFormat
   const SwFormatAnchor& 
_rNewAnchorFormat,
   SwFlyFrame const * 
_pKeepThisFlyFrame )
 : mrFlyFrameFormat( _rFlyFrameFormat ),
-  mbAnchorNodeChanged( false )
+  mbAnchorNodeChanged( false ),
+  mpWrtShell(nullptr)
 {
+const SwFormatAnchor& aOldAnchorFormat(_rFlyFrameFormat.GetAnchor());
 const RndStdIds nNewAnchorType( 

[Libreoffice-bugs] [Bug 126037] Last modified time is not reset on Action_Save request

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126037

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu,
   ||ke...@collabora.com
 Whiteboard| QA:needsComment|

--- Comment #1 from Aron Budea  ---
I tested this in a local build of 4.0.4 using a test page, and the timestamp
got updated for me right away.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126235] FILESAVE: empty cells in CSV not quoted

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126235

Eike Rathke  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTOURBUG
Summary|FILESAVE|FILESAVE: empty cells in
   ||CSV not quoted

--- Comment #5 from Eike Rathke  ---
Saving empty cells in CSV as unquoted empty fields is correct. Though saving
them quoted (with no further content) is equally correct. A software relying on
empty fields being quoted is broken. See http://tools.ietf.org/html/rfc4180 and
maybe http://www.creativyst.com/Doc/Articles/CSV/CSV01.htm

Btw, the options dialog does not offer to "quote all cell values", but "Quote
all text cells". Which empty cells are not.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126316] [EDITING] Selecting text with the mouse automatically places the text in the clipboard

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126316

--- Comment #1 from ziga...@free.fr ---
This behaviour appeared in the 6.3.0.1 RC, it is not exhibited in the 6.2.5.2
release.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126316] New: [EDITING] Selecting text with the mouse automatically places the text in the clipboard

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126316

Bug ID: 126316
   Summary: [EDITING] Selecting text with the mouse automatically
places the text in the clipboard
   Product: LibreOffice
   Version: 6.3.0.1 rc
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ziga...@free.fr

Hi !

Selecting text automatically places it in the clipboard. To reproduce this bug
:

- create an empty presentation
- in the title zone (works also in the content zone) type in " "
- using the mouse, select "" (by double-clicking or simply selecting text)
- type CTRL+C to copy the text in the clipboard
- using the mouse, select ""
- type CTRL+V to paste the text from the clipboard
- the "" word is replaced by "", not by ""

or
- create an empty presentation
- in the title zone (works also in the content zone) type in ""
- using the mouse, select "" (by double-clicking or simply selecting text)
- place the cursor after the word ""
- type CTRL+V
- the "" word is appended to the line.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 126315] Tooltip for new drop-down widget in Formula bar in Calc should be another

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126315

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval, topicUI
 Blocks||114019


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114019
[Bug 114019] [META] Tooltip bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 126315] Tooltip for new drop-down widget in Formula bar in Calc should be another

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126315

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval, topicUI
 Blocks||114019


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114019
[Bug 114019] [META] Tooltip bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114019] [META] Tooltip bugs and enhancements

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114019

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||126315


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=126315
[Bug 126315] Tooltip for new drop-down widget in Formula bar in Calc should be
another
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126315] New: Tooltip for new drop-down widget in Formula bar in Calc should be another

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126315

Bug ID: 126315
   Summary: Tooltip for new drop-down widget in Formula bar in
Calc should be another
   Product: LibreOffice
   Version: 6.3.0.1 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 79045_79...@mail.ru

Description:
Tooltip for new drop-down widget in Formula bar in Calc should be another

Steps to Reproduce:
1. Open Calc
2. Move mouse point to new drop-down widget in Formula bar
3. Look at tooltip "Autosum" O_o
4. This widget just has 5 functions - Sum, Average, Min, Max, Count, that you
can select fast now. Where is Autosum here?

I suggest change tootip to another, like "Fast functions" or "Popular
functions"
Or maybe let's delete tooltip here at all.

Actual Results:
There is wrong tooltip (for me)

Expected Results:
There is no tooltip here or tooltip is more suitable


Reproducible: Always


User Profile Reset: No



Additional Info:
Версия: 6.3.0.1
ID сборки: 41ac97386aba908b6db860cfb4cfe2da871886ae
Потоков ЦП: 4; ОС:Linux 5.0; Отрисовка ИП: по умолчанию; VCL: kde5; 
Локаль: ru-RU (ru_RU.UTF-8); UI-Language: ru-RU
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66890] EDITING: Double-clicking fill handle should also overwrite down the entire range (until empty cells)

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=66890

--- Comment #21 from Eike Rathke  ---
What I'm missing here so far is a clear definition of the circumstances/cases
when to overwrite content and when not. Specifically if two or more columns are
selected and not all columns have yet content immediately below the selection.
Should an overwriting fill be started or not? And how far should be filled,
e.g. should the fill stop at the first blank cell anywhere in a row of the
selected columns, or should it continue if one of the adjacent cells in the
selected columns does have content? The non-overwriting fill (all cells
immediately below the selection are blank) is guided by the column immediately
left (or right if no data there) and stops if that has no content; what would
be expected of an overwriting fill? Stop there as well? Or continue to fill
until all data in all selected columns end? Or continue to fill until data in
one of the selected columns ends?

Apart from that, I'm not a friend of overwriting data by just double clicking a
handle of a selection. Twitching finger and boom..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 66890] EDITING: Double-clicking fill handle should also overwrite down the entire range (until empty cells)

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=66890

--- Comment #21 from Eike Rathke  ---
What I'm missing here so far is a clear definition of the circumstances/cases
when to overwrite content and when not. Specifically if two or more columns are
selected and not all columns have yet content immediately below the selection.
Should an overwriting fill be started or not? And how far should be filled,
e.g. should the fill stop at the first blank cell anywhere in a row of the
selected columns, or should it continue if one of the adjacent cells in the
selected columns does have content? The non-overwriting fill (all cells
immediately below the selection are blank) is guided by the column immediately
left (or right if no data there) and stops if that has no content; what would
be expected of an overwriting fill? Stop there as well? Or continue to fill
until all data in all selected columns end? Or continue to fill until data in
one of the selected columns ends?

Apart from that, I'm not a friend of overwriting data by just double clicking a
handle of a selection. Twitching finger and boom..

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 66890] EDITING: Double-clicking fill handle should also overwrite down the entire range (until empty cells)

2019-07-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=66890

--- Comment #20 from Eike Rathke  ---
(In reply to p19991 from comment #9)
> missed the purpose of the fill handle that has always work
> that way in many other spreadsheet software.
"many other"? Which except Excel?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

  1   2   3   4   >