[Libreoffice-bugs] [Bug 61558] High CPU load when scrolling a document with many comments
https://bugs.documentfoundation.org/show_bug.cgi?id=61558 --- Comment #54 from Dominic --- If I scroll continuously (by placing the cursor in the scroll bar and scroll down the page at a time) the CPU usage falls to about half of what it was. The CPU usage rises as soon as the scrolling stops. That is strange! We have a guide for the setup, which you can find on the following link:https://www.techsupportdubai.com/led-tv-repair/ If I take a screen dump with Alt/PrtScr (or it might be AltGr/PrtScr) the CPU usage jumps while the screenshot is taken, and then falls to virtually zero. This last bit is a bit intermittent - mostly it does. It might depend on whether the Writer Window is active when the screen dump is taken. Why does the Writer CPU fall after the screenshot? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/Library_cui.mk cui/source cui/uiconfig include/editeng include/svl include/svx offapi/com offapi/UnoApi_offapi.mk RepositoryExternal.mk svx/source
RepositoryExternal.mk |2
cui/Library_cui.mk|2
cui/source/dialogs/QrCodeGenDialog.cxx| 288 ++
cui/source/inc/QrCodeGenDialog.hxx| 58 +++
cui/uiconfig/ui/qrcodegen.ui | 273 +
include/editeng/unoprnms.hxx |1
include/svl/solar.hrc |2
include/svx/svdograf.hxx | 15
include/svx/unoshprp.hxx |7
offapi/UnoApi_offapi.mk |2
offapi/com/sun/star/drawing/GraphicObjectShape.idl|5
offapi/com/sun/star/drawing/QRCode.idl| 42 ++
offapi/com/sun/star/drawing/QRCodeErrorCorrection.idl | 50 +++
svx/source/svdraw/svdograf.cxx| 10
svx/source/unodraw/unoshap2.cxx | 22 +
15 files changed, 775 insertions(+), 4 deletions(-)
New commits:
commit 2de42b53b7c23223c38e64a75eae248d8a0cd4ec
Author: Shubham Goyal <22shub...@gmail.com>
AuthorDate: Wed Jul 3 12:15:08 2019 +0530
Commit: Samuel Mehrbrodt
CommitDate: Thu Jul 25 07:15:10 2019 +0200
QRCode Dialog Box feature
The patch handles the created QR code as a Customized Shape (Graphic
Object)
Change-Id: I1cee6f0e7fac585de880a9ac34e3bc441a4b7390
Reviewed-on: https://gerrit.libreoffice.org/74167
Reviewed-by: Stephan Bergmann
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
Reviewed-by: Samuel Mehrbrodt
diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index a66077d3bcbb..021d9a7b650e 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -4172,7 +4172,7 @@ gb_ExternalProject__use_qrcodegen :=
else # !SYSTEM_QRCODEGEN
define gb_LinkTarget__use_qrcodegen
-l$(call gb_LinkTarget_use_unpacked,$(1),qrcodegen)
+$(call gb_LinkTarget_use_unpacked,$(1),qrcodegen)
$(call gb_LinkTarget_set_include,$(1),\
-I$(call gb_UnpackedTarball_get_dir,qrcodegen/cpp/)\
$$(INCLUDE) \
diff --git a/cui/Library_cui.mk b/cui/Library_cui.mk
index e3cd0c36ba4f..620d3de8fa69 100644
--- a/cui/Library_cui.mk
+++ b/cui/Library_cui.mk
@@ -73,6 +73,7 @@ $(eval $(call gb_Library_use_externals,cui,\
libxml2 \
orcus-parser \
orcus \
+qrcodegen \
))
ifeq ($(DISABLE_GUI),)
$(eval $(call gb_Library_use_externals,cui,\
@@ -129,6 +130,7 @@ $(eval $(call gb_Library_add_exception_objects,cui,\
cui/source/dialogs/screenshotannotationdlg \
cui/source/dialogs/pastedlg \
cui/source/dialogs/postdlg \
+cui/source/dialogs/QrCodeGenDialog \
cui/source/dialogs/scriptdlg \
cui/source/dialogs/SignatureLineDialogBase \
cui/source/dialogs/SignatureLineDialog \
diff --git a/cui/source/dialogs/QrCodeGenDialog.cxx
b/cui/source/dialogs/QrCodeGenDialog.cxx
new file mode 100644
index ..628ada1df38b
--- /dev/null
+++ b/cui/source/dialogs/QrCodeGenDialog.cxx
@@ -0,0 +1,288 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4;
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+using namespace css;
+using namespace css::uno;
+using namespace css::beans;
+using namespace css::container;
+using namespace css::frame;
+using namespace css::io;
+using namespace css::lang;
+using namespace css::frame;
+using namespace css::sheet;
+using namespace css::text;
+using namespace css::drawing;
+using namespace css::graphic;
+using namespace qrcodegen;
+
+QrCodeGenDialog::QrCodeGenDialog(weld::Widget* pParent, Reference
xModel,
+ bool bEditExisting)
+: GenericDialogController(pParent, "cui/ui/qrcodegen.ui",
"QrCodeGenDialog")
+, m_xModel(std::move(xModel))
+, m_xEdittext(m_xBuilder->weld_entry("edit_text"))
+, m_xRadioLow(m_xBuilder->weld_radio_button("button_low"))
+, m_xRadioMedium(m_xBuilder->weld_radio_button("button_medium"))
+, m_xRadioQuartile(m_xBuilder->weld_radio_button("button_quartile"))
+, m_xRadioHigh(m_xBuilder->weld_radio_button("button_high"))
+, m_xSpinBorder(m_xBuilder->weld_spin_button("edit_border"))
+{
+maBox.AddButton(m_xRadioLow.get());
+maBox.AddButton(m_xRadioMedium.get());
+maBox.AddButton(m_xRadioQuartile.get());
+maBox.AddButton(m_xRadioHigh.get());
+
+// Set ECC to Low by Default.
+if
[Libreoffice-commits] core.git: extensions/source include/unotools lotuswordpro/inc offapi/com reportbuilder/java sc/source sd/source sw/inc sw/source unotools/source xmloff/source xmlsecurity/inc
extensions/source/ole/unoconversionutilities.hxx
|2 +-
include/unotools/streamwrap.hxx
|6 +++---
lotuswordpro/inc/xfilter/xfparastyle.hxx
|2 +-
offapi/com/sun/star/document/TypeDetection.idl
|2 +-
offapi/com/sun/star/form/FormComponentType.idl
|2 +-
offapi/com/sun/star/ui/XImageManager.idl
|2 +-
reportbuilder/java/org/libreoffice/report/pentaho/model/OfficeStylesCollection.java
|2 +-
reportbuilder/java/org/libreoffice/report/pentaho/output/StyleUtilities.java
|6 +++---
sc/source/core/tool/interpr2.cxx
|2 +-
sc/source/core/tool/interpr3.cxx
|2 +-
sc/source/core/tool/interpr7.cxx
|2 +-
sd/source/ui/inc/tools/AsynchronousTask.hxx
|2 +-
sd/source/ui/unoidl/unocpres.cxx
|2 +-
sw/inc/tox.hxx
|2 +-
sw/source/core/doc/CntntIdxStore.cxx
|2 +-
sw/source/core/view/viewsh.cxx
|2 +-
unotools/source/config/configitem.cxx
|4 ++--
xmloff/source/draw/shapeimport.cxx
|2 +-
xmlsecurity/inc/framework/saxeventkeeperimpl.hxx
|2 +-
19 files changed, 24 insertions(+), 24 deletions(-)
New commits:
commit 5ccc8124a03cffca3a1848f754524a06a063cb51
Author: Andrea Gelmini
AuthorDate: Thu Jul 25 00:42:27 2019 +0200
Commit: Andrea Gelmini
CommitDate: Thu Jul 25 07:07:25 2019 +0200
Fix typos
Change-Id: I59a0fd175fa5185c15d093d2d9bed9f95bb4cfd5
Reviewed-on: https://gerrit.libreoffice.org/76280
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini
diff --git a/extensions/source/ole/unoconversionutilities.hxx
b/extensions/source/ole/unoconversionutilities.hxx
index c75428c87caa..8948de229205 100644
--- a/extensions/source/ole/unoconversionutilities.hxx
+++ b/extensions/source/ole/unoconversionutilities.hxx
@@ -1821,7 +1821,7 @@ Reference
UnoConversionUtilities::createAdapter(const Sequence xIntAdapterFac;
xIntAdapterFac= m_smgr->createInstance(INTERFACE_ADAPTER_FACTORY);
// We create an adapter object that does not only implement the required
type but also
-// all types that the COM object pretends to implement. An COM object must
therefore
+// all types that the COM object pretends to implement. A COM object must
therefore
// support the property "_implementedInterfaces".
Reference xIntAdapted;
Reference xInv(receiver, UNO_QUERY);
diff --git a/include/unotools/streamwrap.hxx b/include/unotools/streamwrap.hxx
index 299b6dfd081f..bb34dd7af7e6 100644
--- a/include/unotools/streamwrap.hxx
+++ b/include/unotools/streamwrap.hxx
@@ -39,7 +39,7 @@ namespace utl
// workaround for incremental linking bugs in MSVC2015
class SAL_DLLPUBLIC_TEMPLATE OInputStreamWrapper_Base : public
cppu::WeakImplHelper< css::io::XInputStream > {};
-/// helper class for wrapping an SvStream into an com.sun.star.io::XInputStream
+/// helper class for wrapping an SvStream into a com.sun.star.io::XInputStream
class UNOTOOLS_DLLPUBLIC OInputStreamWrapper : public OInputStreamWrapper_Base
{
protected:
@@ -73,7 +73,7 @@ protected:
//= OSeekableInputStreamWrapper
-/** helper class for wrapping an SvStream into an com.sun.star.io::XInputStream
+/** helper class for wrapping an SvStream into a com.sun.star.io::XInputStream
which is seekable (i.e. supports the com.sun.star.io::XSeekable interface).
*/
class UNOTOOLS_DLLPUBLIC OSeekableInputStreamWrapper
@@ -119,7 +119,7 @@ protected:
typedef ::cppu::ImplHelper1 < css::io::XSeekable
> OSeekableOutputStreamWrapper_Base;
-/** helper class for wrapping an SvStream into an
com.sun.star.io::XOutputStream
+/** helper class for wrapping an SvStream into a com.sun.star.io::XOutputStream
which is seekable (i.e. supports the com.sun.star.io::XSeekable interface).
*/
class UNOTOOLS_DLLPUBLIC OSeekableOutputStreamWrapper
diff --git a/lotuswordpro/inc/xfilter/xfparastyle.hxx
b/lotuswordpro/inc/xfilter/xfparastyle.hxx
index 7c066d61c513..8b947a9ea8be 100644
--- a/lotuswordpro/inc/xfilter/xfparastyle.hxx
+++ b/lotuswordpro/inc/xfilter/xfparastyle.hxx
@@ -104,7 +104,7 @@ public:
public:
/**
* @descr Set layout for the paragraph. When such property was set, this
paragraph will
- * start at an
[Libreoffice-bugs] [Bug 103512] [META] AutoFilter-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103512 Bug 103512 depends on bug 122772, which changed state. Bug 122772 Summary: Table splits after AutoFilter popup menu use https://bugs.documentfoundation.org/show_bug.cgi?id=122772 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122772] Table splits after AutoFilter popup menu use
https://bugs.documentfoundation.org/show_bug.cgi?id=122772 Jim Raykowski changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103512] [META] AutoFilter-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103512 Bug 103512 depends on bug 122774, which changed state. Bug 122774 Summary: All items in AutoFilter popup menu are not keyboard accessible https://bugs.documentfoundation.org/show_bug.cgi?id=122774 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126519] UI - Calculation incorrect with VLOOKUP function, will not correct on recalculate
https://bugs.documentfoundation.org/show_bug.cgi?id=126519 --- Comment #2 from a...@patternjugglers.co.nz --- Created attachment 152972 --> https://bugs.documentfoundation.org/attachment.cgi?id=152972=edit Copy of sample problem spreadsheet, with unnecessary extra data removed • the yellow highlighted cells in column C contain the same value • the green hightlighted cell in column J has calculated correctly from the VLOOKUP • the red highlighted cells in column J are displaying 0.00, which is incorrect -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126527] find (and replace) by format does not find anything (in some cases)
https://bugs.documentfoundation.org/show_bug.cgi?id=126527 --- Comment #4 from stragu --- Very interesting! Thanks for testing, m.a.riosv I should add that using the "Find & Replace > Attributes... > Strikethrough" works as expected in both documents. I also just tried to restart in safe mode with user profile as factory settings, which didn't fix it. I also noticed that, when selecting single strikethrough as the format searched for, we can see underneath the Find box: "Single strikethrough, Indent left 0.0 inch, From top 0.0 inch, From bottom 0.0 inch" Is that expected? It is confusing, as the search didn't specify any values for indentation. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126527] find (and replace) by format does not find anything (in some cases)
https://bugs.documentfoundation.org/show_bug.cgi?id=126527 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #3 from m.a.riosv --- Works for me Version: 6.2.5.2 (x64) Build ID: 1ec314fa52f458adc18c4f025c545a4e8b22c159 CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; Locale: es-ES (es_ES); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118384] Sidebar: Style is not added back to hierarchy after deleting and redoing it
https://bugs.documentfoundation.org/show_bug.cgi?id=118384 Jim Raykowski changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |rayk...@gmail.com |desktop.org | --- Comment #5 from Jim Raykowski --- Here is a patch for this: https://gerrit.libreoffice.org/#/c/76279/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47807] EDITING: Undo button not active for style change
https://bugs.documentfoundation.org/show_bug.cgi?id=47807 --- Comment #16 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/ed882d693f37779e3a09641e7cd43b7a925d2312%5E%21 tdf#47807 Invalidate bindings to Undo Redo It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47807] EDITING: Undo button not active for style change
https://bugs.documentfoundation.org/show_bug.cgi?id=47807 Commit Notification changed: What|Removed |Added Whiteboard||target:6.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/svx svx/source
include/svx/sdrundomanager.hxx |2 ++
svx/source/svdraw/sdrundomanager.cxx | 20
2 files changed, 22 insertions(+)
New commits:
commit ed882d693f37779e3a09641e7cd43b7a925d2312
Author: Jim Raykowski
AuthorDate: Mon Jul 22 21:28:54 2019 -0800
Commit: Jim Raykowski
CommitDate: Thu Jul 25 00:50:05 2019 +0200
tdf#47807 Invalidate bindings to Undo Redo
Change-Id: I71a16e60395003402372202a755b976d37690a27
Reviewed-on: https://gerrit.libreoffice.org/76146
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/include/svx/sdrundomanager.hxx b/include/svx/sdrundomanager.hxx
index 60a06bd546c5..854c4be54c51 100644
--- a/include/svx/sdrundomanager.hxx
+++ b/include/svx/sdrundomanager.hxx
@@ -63,6 +63,8 @@ public:
// by a last undo during text edit
bool isEndTextEditTriggeredFromUndo() { return
mbEndTextEditTriggeredFromUndo; }
void SetDocShell(SfxObjectShell* pDocShell);
+
+virtual void AddUndoAction( std::unique_ptr pAction, bool
bTryMerg=false ) override;
};
#endif // INCLUDED_SVX_SDRUNDOMANAGER_HXX
diff --git a/svx/source/svdraw/sdrundomanager.cxx
b/svx/source/svdraw/sdrundomanager.cxx
index 78e72e76196a..5d13d8e5e8a8 100644
--- a/svx/source/svdraw/sdrundomanager.cxx
+++ b/svx/source/svdraw/sdrundomanager.cxx
@@ -18,7 +18,10 @@
*/
#include
+#include
+#include
#include
+#include
#include
SdrUndoManager::SdrUndoManager()
@@ -146,4 +149,21 @@ void SdrUndoManager::EmptyActionsChanged()
}
}
+void SdrUndoManager::AddUndoAction( std::unique_ptr pAction,
bool bTryMerg )
+{
+EditUndoManager::AddUndoAction( std::move(pAction), bTryMerg);
+
+if (m_pDocSh)
+{
+SfxViewFrame* pViewFrame = SfxViewFrame::GetFirst( m_pDocSh );
+while ( pViewFrame )
+{
+pViewFrame->GetBindings().Invalidate( SID_UNDO );
+pViewFrame->GetBindings().Invalidate( SID_REDO );
+pViewFrame = SfxViewFrame::GetNext( *pViewFrame, m_pDocSh );
+}
+}
+}
+
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
SHA1/MD5 in sal/rtl/source/digest.c patch license able for OO
Hello all, I would like to ask if I or any other from OpenOffice Development team can port the patch from LibreOffice to OpenOffice to fix this Issue under the APL2 License, so the Issue can be fixed in OpenOffice without more work then necessary. LO Issue: 114939 OO Issue: 127661 Thanks for your considerations. All the Best Peter ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 126532] New: Export PDF Overwrite Original on Save
https://bugs.documentfoundation.org/show_bug.cgi?id=126532 Bug ID: 126532 Summary: Export PDF Overwrite Original on Save Product: LibreOffice Version: 6.2.4.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: grieb.k...@gmail.com Description: I open a file (PDF) for editing and want to save (export) that file overwriting the original file. Open > Export as PDF > Save (replace currently opened file) > General/Input Output error (Unable to save export). I am able to save other file types with them open, but would also like this feature for the export functionality. Steps to Reproduce: 1. Open PDF 2. Export as PDF 3. Select the currently opened file Actual Results: General Input/Output Error Expected Results: File Save Reproducible: Always User Profile Reset: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87064] [META] Color picker dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=87064 V Stuart Foote changed: What|Removed |Added Depends on||126525 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=126525 [Bug 126525] Suite-wide color picker -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126525] Suite-wide color picker
https://bugs.documentfoundation.org/show_bug.cgi?id=126525 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Blocks||87064 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=87064 [Bug 87064] [META] Color picker dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107237] [META] Notebookbar Tabbed
https://bugs.documentfoundation.org/show_bug.cgi?id=107237 V Stuart Foote changed: What|Removed |Added Depends on||126530 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=126530 [Bug 126530] Tabbed Notebook Bar Usability Issues on Windows 10 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126530] Tabbed Notebook Bar Usability Issues on Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=126530 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Blocks||107237 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107237 [Bug 107237] [META] Notebookbar Tabbed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/rtl offapi/com sal/osl sc/inc svtools/source xmloff/source
include/rtl/uri.h |2 +-
offapi/com/sun/star/rdf/URI.idl |8
offapi/com/sun/star/rdf/XDocumentMetadataAccess.idl |4 ++--
offapi/com/sun/star/rdf/XLiteral.idl|2 +-
offapi/com/sun/star/rdf/XURI.idl|6 +++---
sal/osl/unx/file_url.cxx|2 +-
sc/inc/externalrefmgr.hxx |4 ++--
svtools/source/svhtml/htmlkywd.cxx |2 +-
xmloff/source/transform/AttrTransformerAction.hxx |4 ++--
9 files changed, 17 insertions(+), 17 deletions(-)
New commits:
commit 6131288f2a85d43ba21210e677648c9245793e52
Author: Andrea Gelmini
AuthorDate: Tue Jul 23 22:25:57 2019 +0200
Commit: Andrea Gelmini
CommitDate: Wed Jul 24 23:36:21 2019 +0200
Fix typo
"an URI", to complete:
https://gerrit.libreoffice.org/#/c/75985/
Change-Id: I57489b05117fd12ae6aa22544437ab5bc6b5154f
Reviewed-on: https://gerrit.libreoffice.org/76037
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini
diff --git a/include/rtl/uri.h b/include/rtl/uri.h
index af472dae4d52..3b134fbb80af 100644
--- a/include/rtl/uri.h
+++ b/include/rtl/uri.h
@@ -309,7 +309,7 @@ SAL_DLLPUBLIC void SAL_CALL rtl_uriDecode(
signaled.
@param pRelUriRef
-An URI reference that may be either absolute or relative. If it is
+A URI reference that may be either absolute or relative. If it is
absolute, it will be returned unmodified.
@param pResult
diff --git a/offapi/com/sun/star/rdf/URI.idl b/offapi/com/sun/star/rdf/URI.idl
index b057e42660d6..dbdbc2248227 100644
--- a/offapi/com/sun/star/rdf/URI.idl
+++ b/offapi/com/sun/star/rdf/URI.idl
@@ -27,7 +27,7 @@
module com { module sun { module star { module rdf {
-/** represents an URI node that may occur in a RDF graph.
+/** represents a URI node that may occur in a RDF graph.
@since OOo 3.0
@@ -36,7 +36,7 @@ module com { module sun { module star { module rdf {
service URI : XURI
{
-/** creates an URI RDF node.
+/** creates a URI RDF node.
@param Value
the URI, represented as `string`.
@@ -47,7 +47,7 @@ service URI : XURI
create( [in] string Value )
raises( com::sun::star::lang::IllegalArgumentException );
-/** creates an URI RDF node from namespace prefix and local name.
+/** creates a URI RDF node from namespace prefix and local name.
@param Namespace
the namespace prefix of the URI, represented as
@@ -62,7 +62,7 @@ service URI : XURI
createNS( [in] string Namespace, [in] string LocalName )
raises( com::sun::star::lang::IllegalArgumentException );
-/** creates an URI RDF node for a well-known URI.
+/** creates a URI RDF node for a well-known URI.
@param Id
the URI, represented as a constant from URIs.
diff --git a/offapi/com/sun/star/rdf/XDocumentMetadataAccess.idl
b/offapi/com/sun/star/rdf/XDocumentMetadataAccess.idl
index 8760322ddbe1..b7d143555feb 100644
--- a/offapi/com/sun/star/rdf/XDocumentMetadataAccess.idl
+++ b/offapi/com/sun/star/rdf/XDocumentMetadataAccess.idl
@@ -77,10 +77,10 @@ interface XDocumentMetadataAccess
XMetadatable getElementByMetadataReference(
[in] com::sun::star::beans::StringPair MetadataReference);
-/** get the ODF element that corresponds to an URI.
+/** get the ODF element that corresponds to a URI.
@param URI
-an URI that may identify an ODF element
+a URI that may identify an ODF element
@returns
the ODF element that corresponds to the given URI, or `NULL`
diff --git a/offapi/com/sun/star/rdf/XLiteral.idl
b/offapi/com/sun/star/rdf/XLiteral.idl
index de67596b35d1..7366d021fe7f 100644
--- a/offapi/com/sun/star/rdf/XLiteral.idl
+++ b/offapi/com/sun/star/rdf/XLiteral.idl
@@ -33,7 +33,7 @@ module com { module sun { module star { module rdf {
just a string Value
Value and Language
-typed literal: Value and Datatype (represented by an URI)
+typed literal: Value and Datatype (represented by a URI)
Note that there is no literal with both Language and Datatype.
diff --git a/offapi/com/sun/star/rdf/XURI.idl b/offapi/com/sun/star/rdf/XURI.idl
index 1d08b9cfeb45..5386186d9ede 100644
--- a/offapi/com/sun/star/rdf/XURI.idl
+++ b/offapi/com/sun/star/rdf/XURI.idl
@@ -26,7 +26,7 @@
module com { module sun { module star { module rdf {
-/** represents an URI node that may occur in a RDF graph.
+/** represents a URI node that may occur in a RDF graph.
Note that this is actually an IRI, but the RDF literature speaks of URIs
@@ -41,8 +41,8 @@ module com { module sun { module star { module rdf {
after the last occurrence of the path separator: "/"
after the last occurrence of the scheme separator: ":"
-An URI without a ":" is
[Libreoffice-commits] core.git: basic/source qadevOOo/tests scaddins/source sdext/source svx/source sw/source vcl/unx xmerge/source xmloff/inc xmloff/source xmlsecurity/inc xmlsecurity/source
basic/source/classes/sbunoobj.cxx
|2 -
qadevOOo/tests/java/ifc/ucb/_XCachedDynamicResultSetFactory.java
|2 -
qadevOOo/tests/java/ifc/ucb/_XCachedDynamicResultSetStubFactory.java
|2 -
scaddins/source/datefunc/datefunc.cxx
|2 -
sdext/source/pdfimport/tree/writertreevisiting.cxx
|2 -
svx/source/table/tablelayouter.cxx
|2 -
svx/source/table/tablelayouter.hxx
|2 -
sw/source/filter/html/htmlatr.cxx
|2 -
sw/source/uibase/shells/textsh1.cxx
|2 -
vcl/unx/generic/print/common_gfx.cxx
|2 -
xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/DocumentMergerImpl.java
|2 -
xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/xslt/DocumentMergerImpl.java
|2 -
xmloff/inc/xmlmultiimagehelper.hxx
|2 -
xmloff/source/chart/SchXMLExport.cxx
|2 -
xmloff/source/script/XMLEventImportHelper.cxx
|2 -
xmlsecurity/inc/framework/saxeventkeeperimpl.hxx
|6 ++--
xmlsecurity/inc/framework/securityengine.hxx
|2 -
xmlsecurity/source/framework/buffernode.cxx
|6 ++--
xmlsecurity/source/framework/buffernode.hxx
| 14 +-
xmlsecurity/source/framework/elementcollector.cxx
|4 +-
xmlsecurity/source/framework/elementmark.cxx
|4 +-
xmlsecurity/source/framework/saxeventkeeperimpl.cxx
|2 -
xmlsecurity/source/framework/signatureengine.cxx
|2 -
xmlsecurity/source/helper/xsecctl.cxx
|2 -
24 files changed, 36 insertions(+), 36 deletions(-)
New commits:
commit afad1a0cbc893291ea32baa7234c4ed7a5ffcf80
Author: Andrea Gelmini
AuthorDate: Wed Jul 24 19:48:51 2019 +0200
Commit: Andrea Gelmini
CommitDate: Wed Jul 24 23:34:49 2019 +0200
Fix typos
Change-Id: Ib778a6598f3797fe871a25b56b7b4b7761889296
Reviewed-on: https://gerrit.libreoffice.org/76269
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini
diff --git a/basic/source/classes/sbunoobj.cxx
b/basic/source/classes/sbunoobj.cxx
index c4bec7580d48..321ac7faedeb 100644
--- a/basic/source/classes/sbunoobj.cxx
+++ b/basic/source/classes/sbunoobj.cxx
@@ -1011,7 +1011,7 @@ static Any sbxToUnoValueImpl( const SbxValue* pVar, bool
bBlockConversionToSmall
if( !bBlockConversionToSmallestType )
{
-// #79615 Choose "smallest" represention for int values
+// #79615 Choose "smallest" representation for int values
// because up cast is allowed, downcast not
switch( eType )
{
diff --git a/qadevOOo/tests/java/ifc/ucb/_XCachedDynamicResultSetFactory.java
b/qadevOOo/tests/java/ifc/ucb/_XCachedDynamicResultSetFactory.java
index 595033744c2e..814f4a9436f3 100644
--- a/qadevOOo/tests/java/ifc/ucb/_XCachedDynamicResultSetFactory.java
+++ b/qadevOOo/tests/java/ifc/ucb/_XCachedDynamicResultSetFactory.java
@@ -36,7 +36,7 @@ import com.sun.star.ucb.XDynamicResultSet;
*
* 'CachedDynamicResultSetStub' (of type
* com.sun.star.sdbc.XDynamicResultSet):
-* this must be an imlementation of
+* this must be an implementation of
* com.sun.star.ucb.CachedDynamicResultSetStub service.
*
* Test is NOT multithread compliant.
diff --git
a/qadevOOo/tests/java/ifc/ucb/_XCachedDynamicResultSetStubFactory.java
b/qadevOOo/tests/java/ifc/ucb/_XCachedDynamicResultSetStubFactory.java
index b0c91ffdc74e..ac505faf4435 100644
--- a/qadevOOo/tests/java/ifc/ucb/_XCachedDynamicResultSetStubFactory.java
+++ b/qadevOOo/tests/java/ifc/ucb/_XCachedDynamicResultSetStubFactory.java
@@ -39,7 +39,7 @@ import com.sun.star.uno.UnoRuntime;
*
* 'DynamicResultSet' (of type
* com.sun.star.sdbc.XDynamicResultSet):
-* this must be an imlementation of
+* this must be an implementation of
* com.sun.star.ucb.DynamicResultSet service.
*
* Test is NOT multithread compliant.
diff --git a/scaddins/source/datefunc/datefunc.cxx
b/scaddins/source/datefunc/datefunc.cxx
index 3011ccb32480..e09f871c8ae1 100644
--- a/scaddins/source/datefunc/datefunc.cxx
+++
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/commontools/FValue.cxx | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
New commits:
commit 30320abbef8fabfeadda2b31b72f595c4a1c1ed9
Author: Caolán McNamara
AuthorDate: Wed Jul 24 11:22:58 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 22:21:32 2019 +0200
cid#1448360 Assignment of overlapping memory
Change-Id: Ifefa007ff7534e65cc35cdbcb4983012b36ed6e0
Reviewed-on: https://gerrit.libreoffice.org/76248
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/connectivity/source/commontools/FValue.cxx
b/connectivity/source/commontools/FValue.cxx
index 61f344bb92b5..51adab4f3e98 100644
--- a/connectivity/source/commontools/FValue.cxx
+++ b/connectivity/source/commontools/FValue.cxx
@@ -2086,11 +2086,19 @@ void ORowSetValue::setSigned(bool _bMod)
}
break;
case DataType::BIGINT:
+{
if ( m_bSigned )
-m_aValue.m_nInt64 =
static_cast(m_aValue.m_uInt64);
+{
+auto nTmp = static_cast(m_aValue.m_uInt64);
+m_aValue.m_nInt64 = nTmp;
+}
else
-m_aValue.m_uInt64 =
static_cast(m_aValue.m_nInt64);
+{
+auto nTmp = static_cast(m_aValue.m_nInt64);
+m_aValue.m_uInt64 = nTmp;
+}
break;
+}
}
m_eTypeKind = nType;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126531] New: Connector Behavior Broken since 6.2.x
https://bugs.documentfoundation.org/show_bug.cgi?id=126531 Bug ID: 126531 Summary: Connector Behavior Broken since 6.2.x Product: LibreOffice Version: 6.2.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ralf.kr...@bluewin.ch Created attachment 152971 --> https://bugs.documentfoundation.org/attachment.cgi?id=152971=edit Connector_Bug_example Hi The Behavior of the connector is broken since LO 6.2.x. At least since LO 6.2.4. It worked without problems in LO 6.1.x: To reproduce the Bug 1. Open the attached File 2. Take the Arrow from a gluepoint of the circle to another -> it should be updated in realtime. But it is only updated when the curser released. Hope this is enough... Thanks Ralf -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sc/source
sc/source/ui/drawfunc/futext3.cxx |5 +
1 file changed, 5 insertions(+)
New commits:
commit f5f894e1608a75dffc07ddb3644b566fee1b6848
Author: Miklos Vajna
AuthorDate: Mon Jul 22 13:58:57 2019 +0200
Commit: Caolán McNamara
CommitDate: Wed Jul 24 21:35:47 2019 +0200
tdf#106000 sc ui: fix missing invalidation when cancelling note creation
Regression from commit dca01def7885ad69cf66edd75cf8207a5adb64f9
(refactor ListBox/ComboBox to use RenderContext, 2015-05-07),
invalidating the area of note anchors worked like this in the past:
- user ended text edit of a new, empty comment
- the Calc shell was updated from shape text edit to the tab view, which
called ImplListBoxWindow::SelectEntry()
- this called ImplPaint(), which invoked maUserDrawHdl (if it was set)
- and at the end this invoked ScViewFunc::UpdateSelectionArea(), all
triggered by the font name and font size listboxes
So the update of the cell of the former note depended on the presence of
font name/size listboxes, by accident.
This broke, because ImplListBoxWindow::SelectEntry() now calls
Invalidate(), and Paint() calls ImplDoPaint(), which doesn't invoke
maUserDrawHdl anymore. Fix the problem by invalidating the cell
explicitly, so in case the user customizes the toolbar to not have these
listboxes, the behavior is still correct.
Do this in FuText::StopEditMode(), because there we know the position of
the deleted note and that's where we delete the matching SdrCaptionObj
(via the RemoveLastUndoAction()).
(cherry picked from commit d001492faddb0b95356c7744aa4d193aacb38d7d)
Change-Id: Iaa4b609477ac6c7f23efc575fddac6e39aa6a7b5
Reviewed-on: https://gerrit.libreoffice.org/76128
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/ui/drawfunc/futext3.cxx
b/sc/source/ui/drawfunc/futext3.cxx
index 5c1d3a6ed00b..cbdcefb7d893 100644
--- a/sc/source/ui/drawfunc/futext3.cxx
+++ b/sc/source/ui/drawfunc/futext3.cxx
@@ -157,6 +157,11 @@ void FuText::StopEditMode()
if( bNewNote && bDeleteNote )
{
pUndoMgr->RemoveLastUndoAction();
+
+// Make sure the former area of the note anchor is invalidated.
+ScRangeList aRangeList(aNotePos);
+ScMarkData aMarkData(aRangeList);
+rViewShell.UpdateSelectionArea(aMarkData);
}
else if( bNewNote || bDeleteNote )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: qadevOOo/tests
qadevOOo/tests/java/ifc/text/_XSimpleText.java |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit ceac24b4a140a471a36f423bf48dce32860e8911
Author: Caolán McNamara
AuthorDate: Wed Jul 24 10:53:42 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 21:34:01 2019 +0200
cid#1448461 RV: Bad use of return value
Change-Id: I11dce56c00931b0e04c5fa52f2598a8f80625d5b
Reviewed-on: https://gerrit.libreoffice.org/76243
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/qadevOOo/tests/java/ifc/text/_XSimpleText.java
b/qadevOOo/tests/java/ifc/text/_XSimpleText.java
index 8f1c32d40911..f4ab856f3b5d 100644
--- a/qadevOOo/tests/java/ifc/text/_XSimpleText.java
+++ b/qadevOOo/tests/java/ifc/text/_XSimpleText.java
@@ -98,7 +98,7 @@ public class _XSimpleText extends MultiMethodTest {
}
catch(com.sun.star.lang.IllegalArgumentException e ) {
// Some exception.FAILED
-Status.failed( e.toString() );
+log.println(e.toString());
bOK = false;
}
String gStr = oObj.getString() ;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - qadevOOo/tests sdext/source
qadevOOo/tests/java/ifc/text/_XText.java |2 +-
sdext/source/pdfimport/tree/writertreevisiting.cxx |8
2 files changed, 5 insertions(+), 5 deletions(-)
New commits:
commit bb6f5ae90332fee2eb650398d1ae0b554ac89ce2
Author: Caolán McNamara
AuthorDate: Wed Jul 24 10:57:27 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 21:33:38 2019 +0200
cid#1448446 Unchecked dynamic_cast
Change-Id: I790f55e5edfce37b28dfc8b915970e123425f434
Reviewed-on: https://gerrit.libreoffice.org/76244
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sdext/source/pdfimport/tree/writertreevisiting.cxx
b/sdext/source/pdfimport/tree/writertreevisiting.cxx
index b84e5f2fcb07..96b9e4bcfab9 100644
--- a/sdext/source/pdfimport/tree/writertreevisiting.cxx
+++ b/sdext/source/pdfimport/tree/writertreevisiting.cxx
@@ -671,8 +671,8 @@ void WriterXmlOptimizer::checkHeaderAndFooter( PageElement&
rElem )
auto it = std::find_if(rElem.Children.begin(), rElem.Children.end(),
isParagraphElement);
if (it != rElem.Children.end())
{
-ParagraphElement* pPara = dynamic_cast(it->get());
-if( pPara->y+pPara->h < rElem.h*0.15 && pPara->isSingleLined(
m_rProcessor ) )
+ParagraphElement& rPara = dynamic_cast(*it->get());
+if( rPara.y+rPara.h < rElem.h*0.15 && rPara.isSingleLined(
m_rProcessor ) )
{
auto next_it = it;
ParagraphElement* pNextPara = nullptr;
@@ -680,10 +680,10 @@ void WriterXmlOptimizer::checkHeaderAndFooter(
PageElement& rElem )
{
pNextPara = dynamic_cast(next_it->get());
}
-if( pNextPara && pNextPara->y > pPara->y+pPara->h*2 )
+if( pNextPara && pNextPara->y > rPara.y+rPara.h*2 )
{
rElem.HeaderElement = std::move(*it);
-pPara->Parent = nullptr;
+rPara.Parent = nullptr;
rElem.Children.erase( it );
}
}
commit 1779f7fcbaf11428e9064653a61045dc267778be
Author: Caolán McNamara
AuthorDate: Wed Jul 24 11:43:15 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 21:33:14 2019 +0200
cid#1448285 RV: Bad use of return value
Change-Id: I3509620b37884b75a00c89ae38b68adc324da00c
Reviewed-on: https://gerrit.libreoffice.org/76252
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/qadevOOo/tests/java/ifc/text/_XText.java
b/qadevOOo/tests/java/ifc/text/_XText.java
index 234dd5f1882f..0e2d8a3d6ea9 100644
--- a/qadevOOo/tests/java/ifc/text/_XText.java
+++ b/qadevOOo/tests/java/ifc/text/_XText.java
@@ -145,7 +145,7 @@ public class _XText extends MultiMethodTest {
}
catch( com.sun.star.container.NoSuchElementException nseE ){
// Some exception.FAILED
-Status.failed( nseE.toString() );
+log.println(nseE.toString());
return;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - reportbuilder/java sd/source
reportbuilder/java/org/libreoffice/report/pentaho/output/OfficeDocumentReportTarget.java
|1 -
sd/source/ui/dlg/BulletAndPositionDlg.cxx
|1 +
2 files changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 852d5b7b3bc289c1018da5373dea50b7aa68ef0b
Author: Caolán McNamara
AuthorDate: Wed Jul 24 11:45:00 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 21:32:49 2019 +0200
cid#1448272 RV: Bad use of return value
Change-Id: I716c4e617ae2493385391f96567e2fb4571cd440
Reviewed-on: https://gerrit.libreoffice.org/76253
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git
a/reportbuilder/java/org/libreoffice/report/pentaho/output/OfficeDocumentReportTarget.java
b/reportbuilder/java/org/libreoffice/report/pentaho/output/OfficeDocumentReportTarget.java
index 0a3f23c6986e..330a5e091aa0 100644
---
a/reportbuilder/java/org/libreoffice/report/pentaho/output/OfficeDocumentReportTarget.java
+++
b/reportbuilder/java/org/libreoffice/report/pentaho/output/OfficeDocumentReportTarget.java
@@ -1026,7 +1026,6 @@ public abstract class OfficeDocumentReportTarget extends
AbstractReportTarget
DocumentBuilder dBuilder = dbFactory.newDocumentBuilder();
Document document = dBuilder.parse(new
InputSource(inputStream));
-document.getElementsByTagName("document-meta/meta/generator");
Node node =
document.getFirstChild().getFirstChild().getFirstChild().getFirstChild();
String creator = node.getNodeValue();
node.setNodeValue(creator + "/report_builder");
commit 554e7d8ee6bee44d87392476a498fb7f3f6068c6
Author: Caolán McNamara
AuthorDate: Wed Jul 24 11:51:10 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 21:32:22 2019 +0200
cid#1448222 Out-of-bounds read
possibly coverity gold
Change-Id: I6443225482eab5be31e1e12d282e420e767f23b2
Reviewed-on: https://gerrit.libreoffice.org/76254
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sd/source/ui/dlg/BulletAndPositionDlg.cxx
b/sd/source/ui/dlg/BulletAndPositionDlg.cxx
index 26e81878661f..17e7b20136f2 100644
--- a/sd/source/ui/dlg/BulletAndPositionDlg.cxx
+++ b/sd/source/ui/dlg/BulletAndPositionDlg.cxx
@@ -521,6 +521,7 @@ void SvxBulletAndPositionDlg::InitControls()
{
nNumberingType = SVX_NUM_NUMBER_NONE;
bAllLevel = false;
+bSameDistBorderNum = false;
bSameBulRelSize = false;
bSameBulColor = false;
bSameStart = false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/frmedt/fefly1.cxx |2 +-
sw/source/core/frmedt/feshview.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit fd40f94e6bfcd8df200a30c933e4d09d1b99e897
Author: Caolán McNamara
AuthorDate: Wed Jul 24 11:54:59 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 21:31:11 2019 +0200
cid#1401334 Uncaught exception
Change-Id: I371610e76e513a40da800eb11de0883775fdbd2d
Reviewed-on: https://gerrit.libreoffice.org/76255
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sw/source/core/frmedt/fefly1.cxx b/sw/source/core/frmedt/fefly1.cxx
index f81fb14a647c..bd6b66a5dabe 100644
--- a/sw/source/core/frmedt/fefly1.cxx
+++ b/sw/source/core/frmedt/fefly1.cxx
@@ -592,7 +592,7 @@ Point SwFEShell::FindAnchorPos( const Point& rAbsPos, bool
bMoveIt )
// re-created. Thus, delete all fly frames except the
before the
// anchor attribute is change and re-create them
afterwards.
{
-std::unique_ptr
pHandleAnchorNodeChg;
+std::unique_ptr> pHandleAnchorNodeChg;
SwFlyFrameFormat* pFlyFrameFormat(
dynamic_cast() );
if ( pFlyFrameFormat )
{
diff --git a/sw/source/core/frmedt/feshview.cxx
b/sw/source/core/frmedt/feshview.cxx
index 136a5fbfe385..736b10235109 100644
--- a/sw/source/core/frmedt/feshview.cxx
+++ b/sw/source/core/frmedt/feshview.cxx
@@ -576,7 +576,7 @@ bool SwFEShell::MoveAnchor( SwMove nDir )
// re-created. Thus, delete all fly frames except the
before the
// anchor attribute is change and re-create them afterwards.
{
-std::unique_ptr pHandleAnchorNodeChg;
+std::unique_ptr> pHandleAnchorNodeChg;
SwFlyFrameFormat* pFlyFrameFormat(
dynamic_cast() );
if ( pFlyFrameFormat )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/inc
sw/inc/swmodule.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 40b5af334464b7e30bc29e479ec6a626a4ad0d48 Author: Caolán McNamara AuthorDate: Wed Jul 24 11:56:23 2019 +0100 Commit: Caolán McNamara CommitDate: Wed Jul 24 21:30:46 2019 +0200 cid#1401328 Uncaught exception Change-Id: I15b1157220631e984f30f6e3c0a0362167236c9c Reviewed-on: https://gerrit.libreoffice.org/76256 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/sw/inc/swmodule.hxx b/sw/inc/swmodule.hxx index be21755a08cc..5d96a31da341 100644 --- a/sw/inc/swmodule.hxx +++ b/sw/inc/swmodule.hxx @@ -77,7 +77,7 @@ class SW_DLLPUBLIC SwModule final : public SfxModule, public SfxListener, public OUStringm_sActAuthor; // ConfigItems -std::unique_ptr m_pModuleConfig; +std::unique_ptr> m_pModuleConfig; std::unique_ptr> m_pUsrPref; std::unique_ptr> m_pWebUsrPref; std::unique_ptr m_pPrintOptions; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/font/fontcharmap.cxx | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
New commits:
commit 63922db083dc70c9b248c9eb34b24382048adf08
Author: Caolán McNamara
AuthorDate: Wed Jul 24 12:07:57 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 21:29:49 2019 +0200
rename search+replaced Getsal_uInt16 result back to GetUShort
Change-Id: Ia6e35d0ca15b0ac2310ad847c6eda6db548b25f6
Reviewed-on: https://gerrit.libreoffice.org/76258
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/source/font/fontcharmap.cxx b/vcl/source/font/fontcharmap.cxx
index 8d8dd5815dc1..9c8b54682041 100644
--- a/vcl/source/font/fontcharmap.cxx
+++ b/vcl/source/font/fontcharmap.cxx
@@ -87,7 +87,7 @@ bool ImplFontCharMap::isDefaultMap() const
}
static unsigned GetUInt( const unsigned char* p ) {
return((p[0]<<24)+(p[1]<<16)+(p[2]<<8)+p[3]);}
-static unsigned Getsal_uInt16( const unsigned char* p ){ return((p[0]<<8) |
p[1]);}
+static unsigned GetUShort( const unsigned char* p ){ return((p[0]<<8) | p[1]);}
static int GetSShort( const unsigned char* p ){ return
static_cast((p[0]<<8)|p[1]);}
// TODO: move CMAP parsing directly into the ImplFontCharMap class
@@ -104,10 +104,10 @@ bool ParseCMAP( const unsigned char* pCmap, int nLength,
CmapResult& rResult )
if( !pCmap || (nLength < 24) )
return false;
-if( Getsal_uInt16( pCmap ) != 0x ) // simple check for CMAP corruption
+if( GetUShort( pCmap ) != 0x ) // simple check for CMAP corruption
return false;
-int nSubTables = Getsal_uInt16( pCmap + 2 );
+int nSubTables = GetUShort( pCmap + 2 );
if( (nSubTables <= 0) || (nLength < (24 + 8*nSubTables)) )
return false;
@@ -120,8 +120,8 @@ bool ParseCMAP( const unsigned char* pCmap, int nLength,
CmapResult& rResult )
int nBestVal = 0;
for( const unsigned char* p = pCmap + 4; --nSubTables >= 0; p += 8 )
{
-int nPlatform = Getsal_uInt16( p );
-int nEncoding = Getsal_uInt16( p+2 );
+int nPlatform = GetUShort( p );
+int nEncoding = GetUShort( p+2 );
int nPlatformEncoding = (nPlatform << 8) + nEncoding;
int nValue;
@@ -150,7 +150,7 @@ bool ParseCMAP( const unsigned char* pCmap, int nLength,
CmapResult& rResult )
continue;
int nTmpOffset = GetUInt( p+4 );
-int nTmpFormat = Getsal_uInt16( pCmap + nTmpOffset );
+int nTmpFormat = GetUShort( pCmap + nTmpOffset );
if( nTmpFormat == 12 ) // 32bit code -> glyph map
format
nValue += 3;
else if( nTmpFormat != 4 ) // 16bit code -> glyph map
format
@@ -177,7 +177,7 @@ bool ParseCMAP( const unsigned char* pCmap, int nLength,
CmapResult& rResult )
// format 4, the most common 16bit char mapping table
if( (nFormat == 4) && ((nOffset+16) < nLength) )
{
-int nSegCountX2 = Getsal_uInt16( pCmap + nOffset + 6 );
+int nSegCountX2 = GetUShort( pCmap + nOffset + 6 );
nRangeCount = nSegCountX2/2 - 1;
pCodePairs = new sal_UCS4[ nRangeCount * 2 ];
pStartGlyphs = new int[ nRangeCount ];
@@ -188,10 +188,10 @@ bool ParseCMAP( const unsigned char* pCmap, int nLength,
CmapResult& rResult )
sal_UCS4* pCP = pCodePairs;
for( int i = 0; i < nRangeCount; ++i )
{
-const sal_UCS4 cMinChar = Getsal_uInt16( pBeginBase + 2*i );
-const sal_UCS4 cMaxChar = Getsal_uInt16( pLimitBase + 2*i );
+const sal_UCS4 cMinChar = GetUShort( pBeginBase + 2*i );
+const sal_UCS4 cMaxChar = GetUShort( pLimitBase + 2*i );
const int nGlyphDelta = GetSShort( pDeltaBase + 2*i );
-const int nRangeOffset = Getsal_uInt16( pOffsetBase + 2*i );
+const int nRangeOffset = GetUShort( pOffsetBase + 2*i );
if( cMinChar > cMaxChar ) { // no sane font should trigger this
SAL_WARN("vcl.gdi", "Min char should never be more than the
max char!");
break;
@@ -219,7 +219,7 @@ bool ParseCMAP( const unsigned char* pCmap, int nLength,
CmapResult& rResult )
break;
}
for( sal_UCS4 c = cMinChar; c <= cMaxChar; ++c, pGlyphIdPtr+=2
) {
-const int nGlyphIndex = Getsal_uInt16( pGlyphIdPtr ) +
nGlyphDelta;
+const int nGlyphIndex = GetUShort( pGlyphIdPtr ) +
nGlyphDelta;
aGlyphIdArray.push_back(
static_cast(nGlyphIndex) );
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/font/fontcharmap.cxx |5 +
1 file changed, 5 insertions(+)
New commits:
commit 52b92a591943c1988fd3d660bd6fc5ac53ce0f33
Author: Caolán McNamara
AuthorDate: Wed Jul 24 12:18:10 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 21:28:26 2019 +0200
cid#1209863 Untrusted loop bound
Change-Id: Ic8d20e92b4021dfebe01e1265c3afb2bcd509827
Reviewed-on: https://gerrit.libreoffice.org/76259
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/source/font/fontcharmap.cxx b/vcl/source/font/fontcharmap.cxx
index b057a2056645..8d8dd5815dc1 100644
--- a/vcl/source/font/fontcharmap.cxx
+++ b/vcl/source/font/fontcharmap.cxx
@@ -232,6 +232,11 @@ bool ParseCMAP( const unsigned char* pCmap, int nLength,
CmapResult& rResult )
else if( (nFormat == 12) && ((nOffset+16) < nLength) )
{
nRangeCount = GetUInt( pCmap + nOffset + 12 );
+if (nRangeCount < 0)
+{
+SAL_WARN("vcl.gdi", "negative RangeCount");
+nRangeCount = 0;
+}
const int nGroupOffset = nOffset + 16;
const int nRemainingLen = nLength - nGroupOffset;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/inc sd/source
sd/inc/CustomAnimationPreset.hxx|6 +++-
sd/source/core/CustomAnimationPreset.cxx| 34 ++--
sd/source/ui/animations/CustomAnimationPane.cxx | 20 --
sd/source/ui/animations/CustomAnimationPane.hxx | 12 +---
4 files changed, 34 insertions(+), 38 deletions(-)
New commits:
commit 3b55741586883d4fbb7f3e4c5368b5382c3ce5f8
Author: Ashod Nakashian
AuthorDate: Mon Jan 28 10:03:39 2019 -0500
Commit: Noel Grandin
CommitDate: Wed Jul 24 21:01:51 2019 +0200
sd: LOK: support per-user localization of CustomAnimationPreset
This only fixes the caching in CustomAnimationPreset and
CustomAnimationPane. Other cached labels will be done separately.
Reviewed-on: https://gerrit.libreoffice.org/68263
Reviewed-by: Andras Timar
Tested-by: Andras Timar
(cherry picked from commit b44679e47211a27f4fe22d05762d9d48c8f88935)
Change-Id: Iaf511168d26b3a5567ca53556e242d3c071d2623
Reviewed-on: https://gerrit.libreoffice.org/76241
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sd/inc/CustomAnimationPreset.hxx b/sd/inc/CustomAnimationPreset.hxx
index ac55ad77..57669734014b 100644
--- a/sd/inc/CustomAnimationPreset.hxx
+++ b/sd/inc/CustomAnimationPreset.hxx
@@ -88,6 +88,9 @@ public:
SAL_DLLPRIVATE CustomAnimationPresets();
SAL_DLLPRIVATE ~CustomAnimationPresets();
+/** This method gets presets instance, which is localized
+ * for the current user's locale.
+*/
static const CustomAnimationPresets& getCustomAnimationPresets();
SAL_DLLPRIVATE css::uno::Reference< css::animations::XAnimationNode >
getRandomPreset( sal_Int16 nPresetClass ) const;
@@ -125,7 +128,8 @@ private:
PresetCategoryList maMotionPathsPresets;
PresetCategoryList maMiscPresets;
-SAL_DLLPRIVATE static CustomAnimationPresets* mpCustomAnimationPresets;
+//! Maps per-language the animation presets.
+SAL_DLLPRIVATE static std::map
mpCustomAnimationPresetsMap;
};
diff --git a/sd/source/core/CustomAnimationPreset.cxx
b/sd/source/core/CustomAnimationPreset.cxx
index 1f2066e6af9c..4c02acc25d6c 100644
--- a/sd/source/core/CustomAnimationPreset.cxx
+++ b/sd/source/core/CustomAnimationPreset.cxx
@@ -35,6 +35,9 @@
#include
#include
#include
+#include
+#include
+#include
#include
#include
@@ -521,22 +524,27 @@ void CustomAnimationPresets::changePresetSubType( const
CustomAnimationEffectPtr
}
}
-CustomAnimationPresets* CustomAnimationPresets::mpCustomAnimationPresets =
nullptr;
+std::map
CustomAnimationPresets::mpCustomAnimationPresetsMap;
const CustomAnimationPresets&
CustomAnimationPresets::getCustomAnimationPresets()
{
-if( !mpCustomAnimationPresets )
-{
-SolarMutexGuard aGuard;
-
-if( !mpCustomAnimationPresets )
-{
-mpCustomAnimationPresets = new sd::CustomAnimationPresets();
-mpCustomAnimationPresets->importResources();
-}
-}
-
-return *mpCustomAnimationPresets;
+// Support localization per-view. Currently not useful for Desktop
+// but very much critical for LOK. The cache now is per-language.
+const OUString aLang = comphelper::LibreOfficeKit::isActive()
+ ?
comphelper::LibreOfficeKit::getLanguageTag().getLanguage()
+ :
SvtSysLocaleOptions().GetLanguageTag().getLanguage();
+
+SolarMutexGuard aGuard;
+const auto it = mpCustomAnimationPresetsMap.find(aLang);
+if (it != mpCustomAnimationPresetsMap.end())
+return *it->second;
+
+// Note: we are invoked recursively(!), so we must set the instance pointer
+// in the cache map before we importResources, lest we get in infinite
loop.
+sd::CustomAnimationPresets* pCustomAnimationPresets = new
sd::CustomAnimationPresets();
+mpCustomAnimationPresetsMap[aLang] = pCustomAnimationPresets;
+pCustomAnimationPresets->importResources();
+return *pCustomAnimationPresets;
}
Reference< XAnimationNode > CustomAnimationPresets::getRandomPreset( sal_Int16
nPresetClass ) const
diff --git a/sd/source/ui/animations/CustomAnimationPane.cxx
b/sd/source/ui/animations/CustomAnimationPane.cxx
index 6971328837e8..ee1807187fbd 100644
--- a/sd/source/ui/animations/CustomAnimationPane.cxx
+++ b/sd/source/ui/animations/CustomAnimationPane.cxx
@@ -124,7 +124,6 @@ CustomAnimationPane::CustomAnimationPane( Window* pParent,
ViewShellBase& rBase,
const
css::uno::Reference& rxFrame )
: PanelLayout( pParent, "CustomAnimationsPanel",
"modules/simpress/ui/customanimationspanel.ui", rxFrame ),
mrBase( rBase ),
-mpCustomAnimationPresets(nullptr),
mnPropertyType( nPropertyTypeNone ),
mnCurvePathPos( LISTBOX_ENTRY_NOTFOUND ),
mnPolygonPathPos( LISTBOX_ENTRY_NOTFOUND ),
@@ -532,7 +531,7 @@ void CustomAnimationPane::updateControls()
{
[Libreoffice-commits] core.git: sd/source
sd/source/ui/framework/configuration/ConfigurationTracer.cxx |7 ---
sd/source/ui/framework/configuration/ConfigurationTracer.hxx |3 ++-
2 files changed, 6 insertions(+), 4 deletions(-)
New commits:
commit 0c4a2b126c4aaa6f87baa1d86973b25fe7691009
Author: Ashod Nakashian
AuthorDate: Sun Nov 18 14:58:45 2018 -0500
Commit: Noel Grandin
CommitDate: Wed Jul 24 21:01:33 2019 +0200
sd: use OSL_DEBUG_LEVEL instead of DEBUG
Change-Id: I0703a1564a23657e956e43fe4cbf1d9549acb94f
Reviewed-on: https://gerrit.libreoffice.org/68258
Reviewed-by: Andras Timar
Tested-by: Andras Timar
Reviewed-on: https://gerrit.libreoffice.org/76240
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sd/source/ui/framework/configuration/ConfigurationTracer.cxx
b/sd/source/ui/framework/configuration/ConfigurationTracer.cxx
index aef2366824c6..7ddaa23ae906 100644
--- a/sd/source/ui/framework/configuration/ConfigurationTracer.cxx
+++ b/sd/source/ui/framework/configuration/ConfigurationTracer.cxx
@@ -19,6 +19,7 @@
#include "ConfigurationTracer.hxx"
+#include
#include
using namespace ::com::sun::star::uno;
@@ -30,11 +31,11 @@ void ConfigurationTracer::TraceConfiguration (
const Reference& rxConfiguration,
const char* pMessage)
{
-#ifdef DEBUG
+#if OSL_DEBUG_LEVEL >=1
SAL_INFO("sd.ui","" << pMessage << " at " << rxConfiguration.get() << "
{");
if (rxConfiguration.is())
{
-TraceBoundResources(rxConfiguration, NULL, 0);
+TraceBoundResources(rxConfiguration, nullptr, 0);
}
else
{
@@ -47,7 +48,7 @@ void ConfigurationTracer::TraceConfiguration (
#endif
}
-#ifdef DEBUG
+#if OSL_DEBUG_LEVEL >=1
void ConfigurationTracer::TraceBoundResources (
const Reference& rxConfiguration,
const Reference& rxResourceId,
diff --git a/sd/source/ui/framework/configuration/ConfigurationTracer.hxx
b/sd/source/ui/framework/configuration/ConfigurationTracer.hxx
index c2fc122b499a..facedd3f4600 100644
--- a/sd/source/ui/framework/configuration/ConfigurationTracer.hxx
+++ b/sd/source/ui/framework/configuration/ConfigurationTracer.hxx
@@ -23,6 +23,7 @@
#include
namespace com { namespace sun { namespace star { namespace drawing { namespace
framework { class XConfiguration; } } } } }
+namespace com { namespace sun { namespace star { namespace drawing { namespace
framework { class XResourceId; } } } } }
namespace com { namespace sun { namespace star { namespace uno { template
class Reference; } } } }
namespace sd { namespace framework {
@@ -36,7 +37,7 @@ public:
static void TraceConfiguration (
const css::uno::Reference&
rxConfiguration,
const char* pMessage);
-#ifdef DEBUG
+#if OSL_DEBUG_LEVEL >=1
static void TraceBoundResources (
const css::uno::Reference&
rxConfiguration,
const css::uno::Reference&
rxResourceId,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126530] Tabbed Notebook Bar Usability Issues on Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=126530 --- Comment #1 from Damian Hofmann --- Created attachment 152970 --> https://bugs.documentfoundation.org/attachment.cgi?id=152970=edit Tabbed Notebar on Windows 10 HiDPI -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126530] New: Tabbed Notebook Bar Usability Issues on Windows 10
https://bugs.documentfoundation.org/show_bug.cgi?id=126530 Bug ID: 126530 Summary: Tabbed Notebook Bar Usability Issues on Windows 10 Product: LibreOffice Version: 6.2.5.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: damian.hofm...@gmx.ch Description: The tabbed Notebook Bar has a host of display/usability issues on Windows 10: 1. Tabs are too small in height 2. Underlined Mnemonics add visual noise 3. Padding between text and border of tabs is too small 4. Not enough contrast between colors for currently active and inactive tabs 5. Buttons are poorly aligned, have no space between and are missing borders Overall, the Notebook Bar looks cramped and noisy. Lack of contrast makes it difficult to see, which tab is currently active. These layout problems impact usability. Tested on Windows 10 1809 with LO 6.2.5 Screen resolution: 4K (3840 x 2160) with 250% text scaling Steps to Reproduce: 1.View > User Interface > Tabbed Actual Results: cramped and noisy UI Expected Results: clean UI Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50916] Allow more than 1024 columns in calc
https://bugs.documentfoundation.org/show_bug.cgi?id=50916 --- Comment #90 from Gerry --- Test of the attachment to comment 86 with Gnumeric 1.12.43. Gnumeric loads the spreadsheet nicely up to column 3201. No problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125179] Writer crash footer Insert Field More Fields
https://bugs.documentfoundation.org/show_bug.cgi?id=125179 Ian Eales changed: What|Removed |Added Resolution|--- |NOTOURBUG Status|NEEDINFO|RESOLVED --- Comment #6 from Ian Eales --- Uninstalled 6.2.3 Huge hassle as programs folder locked by system Installed 6.2.5 Version: 6.2.5.2 (x64) Still crashes. uninstalled 6.2.5 Deleted %AppData%\Roaming\LibreOffice Installed 6.2.5 No more crashes on inserting Additional Fields -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50916] Allow more than 1024 columns in calc
https://bugs.documentfoundation.org/show_bug.cgi?id=50916 --- Comment #89 from Gerry --- Another test with the attachement to comment 86: I opened the file in the document viewer of UBPorts (Ubuntu Touch). The document viewer is based on LibreOffice 5.x Kit (is it version 5.4?). The document loads fine. There is no error message. However, the application crashes when I scroll to column 1024. Actually, it crashes when I am in column 1019, because then 1024 would be visible, which seems to cause the crash. System: UBports with document viewer (LibreOfficeKit 5.x) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100853] HiDPI: Check marks in Windows menus are drawn pixellated
https://bugs.documentfoundation.org/show_bug.cgi?id=100853 --- Comment #13 from Damian Hofmann --- Created attachment 152969 --> https://bugs.documentfoundation.org/attachment.cgi?id=152969=edit LO 6.2.5 on Windows 10 1803 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100853] HiDPI: Check marks in Windows menus are drawn pixellated
https://bugs.documentfoundation.org/show_bug.cgi?id=100853 --- Comment #12 from Damian Hofmann --- Still looks bad. Retested with LO 6.2.5 on Windows 10 1803. See attached screenshot. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126499] Chart in a form: setmodified(true) won't be executed
https://bugs.documentfoundation.org/show_bug.cgi?id=126499 Oliver Brinzing changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #4 from Oliver Brinzing --- i can confirm with LO 6.1.3/LO 5.4.7.2: - macro ChangeData() is called onLoad "Temperaturverlauf". - macro is called after changinag a value, - and chart model data is updated with new values - but chart does not refresh but it works with LO 4.4.7.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126529] Crash in: SwCursorShell::GetCurrFrame
https://bugs.documentfoundation.org/show_bug.cgi?id=126529 --- Comment #1 from opensuse.lietuviu.ka...@gmail.com --- See also http://crashreport.libreoffice.org/stats/crash_details/1023a717-541c-4422-9ffd-095919bb4f09 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126529] New: Crash in: SwCursorShell::GetCurrFrame
https://bugs.documentfoundation.org/show_bug.cgi?id=126529 Bug ID: 126529 Summary: Crash in: SwCursorShell::GetCurrFrame Product: LibreOffice Version: 6.2.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: opensuse.lietuviu.ka...@gmail.com This bug was filed from the crash reporting server and is br-2c9d5aea-982b-413d-85c7-79e80685e4fe. = I copied big part of text from one document. This text contained a lot of tracked changes. I pasted text into another document as DDE link. LO Writer crashed. I successed to reproduce bug with same steps and same text. But I can not reproduce with simple text or liitle tracked changes. Versija: 6.2.4.2 Darinio identifikatorius: 2412653d852ce75f65fbfa83fb7e7b669a126d64 Procesoriaus gijos: 4; OS:Linux 4.4; Sąsajos pateikimas: numatytasis; VCL: kde4; Lokalė: lt-LT (lt_LT.UTF-8); UI-Language: lt-LT Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/lok-clipboard' - 3 commits - desktop/source
Rebased ref, commits from common ancestor:
commit ad28cf191d24dfbd0b0c29ab1d72a5b20f4b66ef
Author: Ashod Nakashian
AuthorDate: Mon Jul 22 19:00:23 2019 -0400
Commit: Michael Meeks
CommitDate: Tue Jul 23 09:51:36 2019 +0100
clipboard: log before erasing
Change-Id: I6d59cdd31c62bbc7db81ccb8985745f68d19cd28
diff --git a/desktop/source/lib/lokclipboard.cxx
b/desktop/source/lib/lokclipboard.cxx
index 7eefd09370d1..f44f4e9fed81 100644
--- a/desktop/source/lib/lokclipboard.cxx
+++ b/desktop/source/lib/lokclipboard.cxx
@@ -51,8 +51,8 @@ void LOKClipboardFactory::releaseClipboardForView(int nViewId)
auto it = gClipboards.get()->find(nViewId);
if (it != gClipboards.get()->end())
{
+SAL_INFO("lok", "Releasing clip: " << it->second.get() << " for
destroyed " << nViewId);
gClipboards.get()->erase(it);
-SAL_INFO("lok", "Released clip: " << it->second.get() << " for
destroyed " << nViewId);
}
}
}
commit 26255a756c308ec296a670da4f758980b8fa105c
Author: Michael Meeks
AuthorDate: Tue Jul 23 09:49:11 2019 +0100
Commit: Michael Meeks
CommitDate: Tue Jul 23 09:49:11 2019 +0100
clipboard: check for null.
Change-Id: I07060035a9744642c98d4a0946695408dc0f6b42
diff --git a/desktop/source/lib/lokclipboard.cxx
b/desktop/source/lib/lokclipboard.cxx
index 3285965c846f..7eefd09370d1 100644
--- a/desktop/source/lib/lokclipboard.cxx
+++ b/desktop/source/lib/lokclipboard.cxx
@@ -37,7 +37,6 @@ rtl::Reference
LOKClipboardFactory::getClipboardForCurView()
return xClip;
}
-/// FIXME: should really copy and stash its content for a bit.
void LOKClipboardFactory::releaseClipboardForView(int nViewId)
{
osl::MutexGuard aGuard(gMutex);
@@ -47,7 +46,7 @@ void LOKClipboardFactory::releaseClipboardForView(int nViewId)
gClipboards.get()->clear();
SAL_INFO("lok", "Released all clipboards on doc destroy\n");
}
-else
+else if (gClipboards.get())
{
auto it = gClipboards.get()->find(nViewId);
if (it != gClipboards.get()->end())
commit c6ad8b963e64217ccdac1914720b9e20c81fd28a
Author: Michael Meeks
AuthorDate: Mon Jul 22 09:48:46 2019 +0100
Commit: Michael Meeks
CommitDate: Mon Jul 22 11:39:22 2019 +0100
lok: share more of the clipboard mime-type handling code.
Change-Id: I98fc9fa0fd1b5afa00c33b642d2d504eab0b62ba
diff --git a/desktop/source/lib/lokclipboard.cxx
b/desktop/source/lib/lokclipboard.cxx
index 17a9c5c54e4f..3285965c846f 100644
--- a/desktop/source/lib/lokclipboard.cxx
+++ b/desktop/source/lib/lokclipboard.cxx
@@ -189,20 +189,7 @@ LOKTransferable::LOKTransferable(const size_t nInCount,
const char** pInMimeType
m_aFlavors = css::uno::Sequence(nInCount);
for (size_t i = 0; i < nInCount; ++i)
{
-OUString aMimeType = OUString::fromUtf8(pInMimeTypes[i]);
-
-// cf. sot/source/base/exchange.cxx for these two exceptional types.
-if (aMimeType.startsWith("text/plain"))
-{
-aMimeType = "text/plain;charset=utf-16";
-m_aFlavors[i].DataType = cppu::UnoType::get();
-}
-else if (aMimeType == "application/x-libreoffice-tsvc")
-m_aFlavors[i].DataType = cppu::UnoType::get();
-else
-m_aFlavors[i].DataType =
cppu::UnoType>::get();
-m_aFlavors[i].MimeType = aMimeType;
-m_aFlavors[i].HumanPresentableName = aMimeType;
+initFlavourFromMime(m_aFlavors[i],
OUString::fromUtf8(pInMimeTypes[i]));
uno::Any aContent;
if (m_aFlavors[i].DataType == cppu::UnoType::get())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: qadevOOo/tests
qadevOOo/tests/java/ifc/style/_ParagraphProperties.java | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 426eff7c6652033518c22d124f22c423e1ae054b
Author: Caolán McNamara
AuthorDate: Wed Jul 24 11:31:58 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 18:14:12 2019 +0200
cid#1448303 RV: Bad use of return value
Change-Id: I779ba87054cbfc10d2d1b26159c5c4873364ebfa
Reviewed-on: https://gerrit.libreoffice.org/76250
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/qadevOOo/tests/java/ifc/style/_ParagraphProperties.java
b/qadevOOo/tests/java/ifc/style/_ParagraphProperties.java
index d1f134b9f258..88b1cae74dce 100644
--- a/qadevOOo/tests/java/ifc/style/_ParagraphProperties.java
+++ b/qadevOOo/tests/java/ifc/style/_ParagraphProperties.java
@@ -329,23 +329,23 @@ public class _ParagraphProperties extends
MultiPropertyTest {
NumberingRules = (XIndexReplace) AnyConverter.toObject(
new Type(XIndexReplace.class),
oObj.getPropertyValue("NumberingRules"));
} catch (com.sun.star.lang.IllegalArgumentException ex) {
-Status.failed( "could not get NumberingRuels: "+ ex.toString() );
+log.println("could not get NumberingRules: "+ ex.toString() );
return;
} catch (UnknownPropertyException ex) {
-Status.failed( "could not get NumberingRuels: "+ ex.toString() );
+log.println( "could not get NumberingRules: "+ ex.toString() );
return;
} catch (WrappedTargetException ex) {
-Status.failed( "could not get NumberingRuels: "+ ex.toString() );
+log.println( "could not get NumberingRules: "+ ex.toString() );
return;
}
try {
propertyValues = (PropertyValue[]) NumberingRules.getByIndex(0);
} catch (com.sun.star.lang.IndexOutOfBoundsException ex) {
-Status.failed( "could not get NumberlingLevel-Array from
NumberingRuels: "+ ex.toString() );
+log.println( "could not get NumberlingLevel-Array from
NumberingRules: "+ ex.toString() );
return;
} catch (WrappedTargetException ex) {
-Status.failed( "could not get NumberlingLevel-Array from
NumberingRuels: "+ ex.toString() );
+log.println( "could not get NumberlingLevel-Array from
NumberingRules: "+ ex.toString() );
return;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: idlc/source
idlc/source/astexpression.cxx | 390 +-
1 file changed, 312 insertions(+), 78 deletions(-)
New commits:
commit d4dae168e4d82864636952b7cd4b4ef7e9befd6e
Author: Caolán McNamara
AuthorDate: Wed Jul 24 10:01:29 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 17:44:29 2019 +0200
cid#1448213 Assignment of overlapping memory
Change-Id: I6611f09000a0901b0d016cda7d8a418fc399fc63
Reviewed-on: https://gerrit.libreoffice.org/76229
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/idlc/source/astexpression.cxx b/idlc/source/astexpression.cxx
index 48963d43a0ac..aab83ba58948 100644
--- a/idlc/source/astexpression.cxx
+++ b/idlc/source/astexpression.cxx
@@ -106,55 +106,82 @@ coerce_value(AstExprValue *ev, ExprType t)
case ET_short:
return true;
case ET_ushort:
+{
if (ev->u.usval > SAL_MAX_INT16)
return false;
-ev->u.sval = static_cast(ev->u.usval);
+auto tmp = static_cast(ev->u.usval);
+ev->u.sval = tmp;
ev->et = ET_short;
return true;
+}
case ET_long:
+{
if (ev->u.lval < SAL_MIN_INT16 || ev->u.lval >
SAL_MAX_INT16)
return false;
-ev->u.sval = static_cast(ev->u.lval);
+auto tmp = static_cast(ev->u.lval);
+ev->u.sval = tmp;
ev->et = ET_short;
return true;
+}
case ET_ulong:
+{
if (ev->u.ulval > SAL_MAX_INT16)
return false;
-ev->u.sval = static_cast(ev->u.ulval);
+auto tmp = static_cast(ev->u.ulval);
+ev->u.sval = tmp;
ev->et = ET_short;
return true;
+}
case ET_hyper:
+{
if (ev->u.hval < SAL_MIN_INT16 || ev->u.hval >
SAL_MAX_INT16)
return false;
-ev->u.sval = static_cast(ev->u.hval);
+auto tmp = static_cast(ev->u.hval);
+ev->u.sval = tmp;
ev->et = ET_short;
return true;
+}
case ET_uhyper:
+{
if (ev->u.uhval > SAL_MAX_INT16)
return false;
-ev->u.sval = static_cast(ev->u.uhval);
+auto tmp = static_cast(ev->u.uhval);
+ev->u.sval = tmp;
ev->et = ET_short;
return true;
+}
case ET_boolean:
-ev->u.sval = static_cast(ev->u.bval);
+{
+auto tmp = static_cast(ev->u.bval);
+ev->u.sval = tmp;
ev->et = ET_short;
return true;
+}
case ET_float:
+{
if (ev->u.fval < SAL_MIN_INT16 || ev->u.fval >
SAL_MAX_INT16)
return false;
-ev->u.sval = static_cast(ev->u.fval);
+auto tmp = static_cast(ev->u.fval);
+ev->u.sval = tmp;
ev->et = ET_short;
return true;
+}
case ET_double:
+{
if (ev->u.dval < SAL_MIN_INT16 || ev->u.dval >
SAL_MAX_INT16)
return false;
-ev->u.sval = static_cast(ev->u.dval);
+auto tmp = static_cast(ev->u.dval);
+ev->u.sval = tmp;
ev->et = ET_short;
return true;
+}
case ET_byte:
-ev->u.sval = static_cast(ev->u.byval);
+{
+auto tmp = static_cast(ev->u.byval);
+ev->u.sval = tmp;
ev->et = ET_short;
return true;
+}
default:
OSL_ASSERT(false);
return false;
@@ -163,57 +190,84 @@ coerce_value(AstExprValue *ev, ExprType t)
switch (ev->et)
{
case ET_short:
+{
if (ev->u.sval < 0)
return false;
-ev->u.usval = static_cast(ev->u.sval);
+auto tmp = static_cast(ev->u.sval);
+ev->u.usval = tmp;
ev->et = ET_ushort;
return true;
+}
[Libreoffice-bugs] [Bug 126519] UI - Calculation incorrect with VLOOKUP function, will not correct on recalculate
https://bugs.documentfoundation.org/show_bug.cgi?id=126519 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEEDINFO --- Comment #1 from m.a.riosv --- Please attach a sample file showing the issues. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126528] [LocalHelp] Add Python info inside "Organize macros" help page
https://bugs.documentfoundation.org/show_bug.cgi?id=126528 Olivier Hallot changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sax/source
sax/source/fastparser/fastparser.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit da346f7afbe5e42b07c205c1c61c48d0f7036931
Author: Caolán McNamara
AuthorDate: Wed Jul 24 11:16:14 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 17:37:22 2019 +0200
cid#1448394 can't change xml_parse_config setting
Change-Id: I8c45c9d5e0a6bc7439aa4d0827e4752ec364d12c
Reviewed-on: https://gerrit.libreoffice.org/76247
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sax/source/fastparser/fastparser.cxx
b/sax/source/fastparser/fastparser.cxx
index 1ac7b209d311..6114cbc469d1 100644
--- a/sax/source/fastparser/fastparser.cxx
+++ b/sax/source/fastparser/fastparser.cxx
@@ -1055,6 +1055,7 @@ void FastSaxParserImpl::parse()
throw SAXException("Couldn't create parser", Reference<
XInterface >(), Any() );
// Tell libxml2 parser to decode entities in attribute values.
+// coverity[unsafe-xml-parse-config] - entity support is required
xmlCtxtUseOptions(rEntity.mpParser, XML_PARSE_NOENT);
}
else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126528] [LocalHelp] Add Python info inside "Organize macros" help page
https://bugs.documentfoundation.org/show_bug.cgi?id=126528 LibreOfficiant changed: What|Removed |Added Version|6.3.0.0.alpha0+ |6.3.0.2 rc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126528] [LocalHelp] Add Python info inside "Organize macros" help page
https://bugs.documentfoundation.org/show_bug.cgi?id=126528 LibreOfficiant changed: What|Removed |Added URL||https://help.libreoffice.or ||g/6.4/en-US/text/shared/01/ ||06130200.html?DbPAR=SHARED# ||bm_id3237403 Keywords||easyHack, ||skillDocumentation, ||skillPython --- Comment #1 from LibreOfficiant --- Python main page is https://help.libreoffice.org/6.3/en-US/text/sbasic/python/main.html?DbPAR=BASIC#bm_id491543348147708 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99296] Calc: Disable headers/footers by default
https://bugs.documentfoundation.org/show_bug.cgi?id=99296 --- Comment #23 from Heiko Tietze --- (In reply to Roman Kuznetsov from comment #22) > Heiko, I suggest merge back your patch disabling header/footer by default. > > For solution of the problem with "Insert->Headers and Footers" menu item I > suggest follow variants for discuss: > > 1. Just delete menu item Insert->Headers and Footers at all and update > guides and Help. > 2. Insert->Headers and Footers should be split to two menu items > Insert->Header and Insert->Footer that will be open Format->Page dialog on > Header and Footer tabs and will activate options "Header on" / "Footer on" > respectively. > > I think disabling of Headers/Footers by default is more important and useful > thing than disabled "Insert->Headers and Footers" menu item that btw. has > workaround. Samuel, would that reassess your concerns? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126528] New: [LocalHelp] Add Python info inside "Organize macros" help page
https://bugs.documentfoundation.org/show_bug.cgi?id=126528 Bug ID: 126528 Summary: [LocalHelp] Add Python info inside "Organize macros" help page Product: LibreOffice Version: 6.3.0.0.alpha0+ Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: libreoffici...@sfr.fr CC: olivier.hal...@libreoffice.org Description: https://help.libreoffice.org/6.4/en-US/text/shared/01/06130200.html?DbPAR=SHARED#bm_id3237403 help page details Basic/BeanShell/JavaScript while it omits Python. A new help Python page must be created, modelled as the above 3, that solely document "Run" button and proposes to consult created Python help pages. An short presentation of APSO extension is a plus! Steps to Reproduce: 1. Open https://help.libreoffice.org/6.4/en-US/text/shared/01/06130200.html?DbPAR=SHARED#bm_id3237403 2. Observe Python information is missing 3. I'm done with steps Actual Results: 3 links are available Expected Results: a 4th link would be welcome Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: soltools/cpp
soltools/cpp/_cpp.c |1 +
soltools/cpp/_lex.c |1 +
soltools/cpp/_macro.c |7 +++
soltools/cpp/_unix.c |1 +
4 files changed, 10 insertions(+)
New commits:
commit 421c7d874d62f3d0f696df540744845753902583
Author: Caolán McNamara
AuthorDate: Wed Jul 24 10:25:09 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 17:20:04 2019 +0200
cid#1448523 silence bogus Out-of-bounds read
Change-Id: I0911133287ace66454e741f7ea994f191d06931c
Reviewed-on: https://gerrit.libreoffice.org/76232
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/soltools/cpp/_cpp.c b/soltools/cpp/_cpp.c
index 0a7ce78d1749..003611c3f53b 100644
--- a/soltools/cpp/_cpp.c
+++ b/soltools/cpp/_cpp.c
@@ -74,6 +74,7 @@ void
{
trp->tp = trp->lp = trp->bp;
outptr = outbuf;
+// coverity[overrun-buffer-arg: FALSE] - a multiple of trp->max is
allocated, not trp->max itself
anymacros |= gettokens(trp, 1);
trp->tp = trp->bp;
}
diff --git a/soltools/cpp/_lex.c b/soltools/cpp/_lex.c
index 0efd303d242e..dfd8605a3950 100644
--- a/soltools/cpp/_lex.c
+++ b/soltools/cpp/_lex.c
@@ -364,6 +364,7 @@ continue2:
{
trp->lp = tp;
tp = growtokenrow(trp);
+// coverity[overrun-local : FALSE] - a multiple of trp->max is
allocated, not trp->max itself
maxp = >bp[trp->max];
}
tp->type = UNCLASS;
diff --git a/soltools/cpp/_macro.c b/soltools/cpp/_macro.c
index 8a89e9379d36..eaafb86034ef 100644
--- a/soltools/cpp/_macro.c
+++ b/soltools/cpp/_macro.c
@@ -287,7 +287,10 @@ void
if (np->flag & ISMAC)
builtin(trp, np->val);
else
+{
+// coverity[overrun-buffer-arg: FALSE] - a multiple of trp->max is
allocated, not trp->max itself
expand(trp, np, );
+}
tp = trp->tp;
} // end for
if (flag)
@@ -430,7 +433,10 @@ int
while (parens > 0)
{
if (trp->tp >= trp->lp)
+{
+// coverity[overrun-buffer-arg: FALSE] - a multiple of trp->max is
allocated, not trp->max itself
gettokens(trp, 0);
+}
if (needspace)
{
needspace = 0;
@@ -602,6 +608,7 @@ void
tt[len] = '\0';
setsource("<##>", -1, -1, tt, 0);
maketokenrow(3, );
+// coverity[overrun-buffer-arg: FALSE] - a multiple of
trp->max is allocated, not trp->max itself
gettokens(, 1);
unsetsource();
if (ntr.bp->type == UNCLASS)
diff --git a/soltools/cpp/_unix.c b/soltools/cpp/_unix.c
index 2ee9215524a2..ac4b7624a00a 100644
--- a/soltools/cpp/_unix.c
+++ b/soltools/cpp/_unix.c
@@ -87,6 +87,7 @@ void
case 'A':
setsource("", -1, -1, optarg, 0);
maketokenrow(3, );
+// coverity[overrun-buffer-arg: FALSE] - a multiple of
trp->max is allocated, not trp->max itself
gettokens(, 1);
doadefine(, c);
dofree(tr.bp);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/validat.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 672da0902b406c88042dfa3b48dd565700514343
Author: Caolán McNamara
AuthorDate: Wed Jul 24 11:28:35 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 17:16:12 2019 +0200
cid#1448321 Dereference after null check
Change-Id: I724e4c19df9aa446f496b21ea5f3918e2def28da
Reviewed-on: https://gerrit.libreoffice.org/76249
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/core/data/validat.cxx b/sc/source/core/data/validat.cxx
index 0444dbf2ef5b..4e0e62ddcada 100644
--- a/sc/source/core/data/validat.cxx
+++ b/sc/source/core/data/validat.cxx
@@ -846,7 +846,7 @@ bool ScValidationData::GetSelectionFromFormula(
if( pEntry )
{
-assert(pEntry);
+assert(pStrings);
pStrings->push_back(*pEntry);
n++;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/fontsubset/sft.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 29a2296af8c0d0e6a630bce1c064e1211047d014
Author: Caolán McNamara
AuthorDate: Wed Jul 24 11:37:16 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 17:05:43 2019 +0200
cid#1448301 silence Untrusted loop bound
Change-Id: Ib5b592fdcf234a78747058eb3cdc7efc5d9cddc6
Reviewed-on: https://gerrit.libreoffice.org/76251
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/source/fontsubset/sft.cxx b/vcl/source/fontsubset/sft.cxx
index 2e974a10d3c6..e9aae0ba9356 100644
--- a/vcl/source/fontsubset/sft.cxx
+++ b/vcl/source/fontsubset/sft.cxx
@@ -436,6 +436,7 @@ static int GetSimpleTTOutline(TrueTypeFont const *ttf,
sal_uInt32 glyphID, Contr
pa[i++].flags = static_cast(flag);
if (flag & 8) { /*- repeat flag */
n = *p++;
+// coverity[tainted_data] - i > lastPoint extra checks the n loop
bound
for (j=0; j lastPoint) {/*- if the font is
really broken */
free(pa);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: unoidl/source
unoidl/source/sourceprovider-parser.y | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
New commits:
commit d397372f5cf9ff1fa67720c76768c3cc29f7de59
Author: Caolán McNamara
AuthorDate: Wed Jul 24 09:09:06 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 17:04:24 2019 +0200
cid#1448548 Assignment of overlapping memory
Change-Id: I146abd4635db993a5a0c5e612bb3f6dc23cdfe24
Reviewed-on: https://gerrit.libreoffice.org/76227
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/unoidl/source/sourceprovider-parser.y
b/unoidl/source/sourceprovider-parser.y
index 94573b1ea147..965a3b9b8c37 100644
--- a/unoidl/source/sourceprovider-parser.y
+++ b/unoidl/source/sourceprovider-parser.y
@@ -228,8 +228,11 @@ bool coerce(
ok = true;
break;
case unoidl::detail::SourceProviderExpr::TYPE_FLOAT:
-lhs->fval = lhs->uval;
-ok = true;
+{
+auto nTmp = lhs->uval;
+lhs->fval = nTmp;
+ok = true;
+}
break;
}
break;
@@ -239,12 +242,18 @@ bool coerce(
ok = false;
break;
case unoidl::detail::SourceProviderExpr::TYPE_INT:
-rhs->fval = rhs->ival;
-ok = true;
+{
+auto tmp = rhs->ival;
+rhs->fval = tmp;
+ok = true;
+}
break;
case unoidl::detail::SourceProviderExpr::TYPE_UINT:
-rhs->fval = rhs->uval;
-ok = true;
+{
+auto tmp = rhs->uval;
+rhs->fval = tmp;
+ok = true;
+}
break;
case unoidl::detail::SourceProviderExpr::TYPE_FLOAT:
ok = true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: filter/source
filter/source/msfilter/dffpropset.cxx | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
New commits:
commit a657260c419a7138971aeb0151c81dcb23df3748
Author: Caolán McNamara
AuthorDate: Wed Jul 24 10:34:01 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 17:04:04 2019 +0200
cid#1448519 Untrusted loop bound
Change-Id: I92952fdef3e1066082d7ba8c3befebfcb7f9adc1
Reviewed-on: https://gerrit.libreoffice.org/76242
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/filter/source/msfilter/dffpropset.cxx
b/filter/source/msfilter/dffpropset.cxx
index 73c0e45d64db..5b0b1194ae06 100644
--- a/filter/source/msfilter/dffpropset.cxx
+++ b/filter/source/msfilter/dffpropset.cxx
@@ -20,6 +20,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -1109,14 +1110,22 @@ void DffPropSet::ReadPropSet( SvStream& rIn, bool
bSetUninitializedOnly )
sal_uInt32 nComplexDataFilePos = rIn.Tell() + ( nPropCount * 6 );
-for( sal_uInt32 nPropNum = 0; nPropNum < nPropCount; nPropNum++ )
+const size_t nMaxPossibleRecords = rIn.remainingSize() /
(sizeof(sal_uInt16) + sizeof(sal_uInt32));
+if (nPropCount > nMaxPossibleRecords)
{
-sal_uInt16 nTmp;
-sal_uInt32 nRecType, nContent;
+SAL_WARN("filter.ms", "Parsing error: " << nMaxPossibleRecords <<
+ " max possible entries, but " << nPropCount << " claimed,
truncating");
+nPropCount = nMaxPossibleRecords;
+}
+
+for (sal_uInt32 nPropNum = 0; nPropNum < nPropCount; ++nPropNum)
+{
+sal_uInt16 nTmp(0);
+sal_uInt32 nContent(0);
rIn.ReadUInt16( nTmp )
.ReadUInt32( nContent );
-nRecType = nTmp & 0x3fff;
+sal_uInt32 nRecType = nTmp & 0x3fff;
if ( nRecType > 0x3ff )
break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115709] [META] DOCX (OOXML) Tracking changes-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=115709 Bug 115709 depends on bug 126516, which changed state. Bug 126516 Summary: FILEOPEN DOCX Rejecting multi-paragraph deletion destroys change tracking of formatting https://bugs.documentfoundation.org/show_bug.cgi?id=126516 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126516] FILEOPEN DOCX Rejecting multi-paragraph deletion destroys change tracking of formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=126516 László Németh changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #3 from László Németh --- Fixed in https://gerrit.libreoffice.org/#/c/76154/ https://gerrit.libreoffice.org/plugins/gitiles/core/+/5ab9cbe7f8d0c0bfd6a2fe1de2e14dfe201d008b%5E%21 tdf#126516 DOCX change tracking: fix paragraph style rejection by keeping paragraph-level ParagraphFormat redlines. (regression from commit a5abe0fc4d435d3a7a7de8bf55ec74087fdd299a "tdf#125546 DOCX import: fix overgrowth of change tracking entries") -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126527] find (and replace) by format does not find anything (in some cases)
https://bugs.documentfoundation.org/show_bug.cgi?id=126527 --- Comment #2 from stragu --- Created attachment 152968 --> https://bugs.documentfoundation.org/attachment.cgi?id=152968=edit preexisting doc converted from RTF to ODT -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126527] find (and replace) by format does not find anything (in some cases)
https://bugs.documentfoundation.org/show_bug.cgi?id=126527 --- Comment #1 from stragu --- Created attachment 152967 --> https://bugs.documentfoundation.org/attachment.cgi?id=152967=edit new doc created with Writer -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126527] New: find (and replace) by format does not find anything (in some cases)
https://bugs.documentfoundation.org/show_bug.cgi?id=126527 Bug ID: 126527 Summary: find (and replace) by format does not find anything (in some cases) Product: LibreOffice Version: 6.2.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: stephane.guil...@member.fsf.org Description: Using "Find and Replace > Format..." does not work in a new document, when looking for text formatted in a certain way. It does however work in other documents. Steps to Reproduce: 1. Open attachment new_doc.odt (brand new document created with LibreOffice) 2. Find and Replace > Format... > Font Effects > Strikethrough > Single 3. Click "OK" 4. Click "Find all" Actual Results: The words that are strikethrough are not selected Expected Results: Nothing was found Reproducible: Always User Profile Reset: No Additional Info: The same steps done in preexisting_doc.odt work as expected for some reason. This file used to be an RTF document, that had (possibly) been edited with Microsoft Office at some stage. Not sure how to consistently create a document in which the format search will work. Tested with: Version: 6.2.5.2 Build ID: 1:6.2.5-0ubuntu0.18.04.1~lo1 CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: en-AU (en_AU.UTF-8); UI-Language: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56959] libvisio: Draw does not import properly MS Visio connectors
https://bugs.documentfoundation.org/show_bug.cgi?id=56959 --- Comment #20 from Bartosz --- Detection of connectors are implemented here: https://gerrit.libreoffice.org/#/c/75649/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dtrans/test
dtrans/test/win32/dnd/atlwindow.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e622abbab580434038c117b013757885d3f0fb58 Author: Andrea Gelmini AuthorDate: Wed Jul 24 08:42:54 2019 +0200 Commit: Andrea Gelmini CommitDate: Wed Jul 24 16:40:36 2019 +0200 Fix typo Change-Id: I6632893980c8f71addda60c9bf447ceca962804d Reviewed-on: https://gerrit.libreoffice.org/72691 Tested-by: Jenkins Reviewed-by: Andrea Gelmini diff --git a/dtrans/test/win32/dnd/atlwindow.cxx b/dtrans/test/win32/dnd/atlwindow.cxx index 9e1e2e1fc693..95aca10e75fc 100644 --- a/dtrans/test/win32/dnd/atlwindow.cxx +++ b/dtrans/test/win32/dnd/atlwindow.cxx @@ -115,7 +115,7 @@ LRESULT AWindow::OnCreate(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL& bHandle m_xDropTarget->addDropTargetListener( static_cast ( new DropTargetListener( m_hwndEdit)) ); -// // make this window tho a drop target +// // make this window a drop target m_xDropTarget->setActive(sal_True); return 0; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126526] New: Overlays of cell's borders using Rows to repeat
https://bugs.documentfoundation.org/show_bug.cgi?id=126526 Bug ID: 126526 Summary: Overlays of cell's borders using Rows to repeat Product: LibreOffice Version: 6.1.6.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: micael.camo...@gmail.com Description: the top border of the free cells overlays the bottom border of the Rows to repeat staring from the 2nd page Steps to Reproduce: 1.Set full borders in black color in A1 2.Set "Rows to repeat" to row 1 3.Set full borders in red color from A2 to A80 4.Click on "print preview" Actual Results: If you look at the preview, the borders of the A1 cell are black in 1st page, but when you go to next page, the bottom border becomes red. The border of the free cells overlays the fixex cells. Expected Results: If I want to repeat a row, I expect to see its full features, including the bottom borders. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93331] LibreOffice.app bundle integrity is destroyed by language pack installer
https://bugs.documentfoundation.org/show_bug.cgi?id=93331 --- Comment #14 from Tor Lillqvist --- Allow me a bit of marketing: The LibreOffice Vanilla app in the Mac App Store does not suffer from this problem. It includes a bunch of languages already. (The localisations included are those that have "good enough" coverage to be worth it, and yes, that is not something that can be decided objectively, but a guesstimate.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126521] Incorrect export to Excel of Calc spreadsheet containing Multiple Operations
https://bugs.documentfoundation.org/show_bug.cgi?id=126521 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords||filter:xlsx CC||er...@redhat.com -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126525] New: Suite-wide color picker
https://bugs.documentfoundation.org/show_bug.cgi?id=126525 Bug ID: 126525 Summary: Suite-wide color picker Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gtomor...@libero.it I was reading https://bugs.documentfoundation.org/show_bug.cgi?id=93813;>Bug 93813 and got to thinking about how the entire suite, not just Draw, needs this feature as swatch creation in LO is non-trivial. I'm pretty sure some developer on your team had already considered this...but just in case... I was thinking LO could hook into the existing system-wide color picker available in Win/Mac/Linux...ah, Linux (regardless of DE) doesn't have a system-wide color picker. So, instead of "reinventing the wheel" and coding from scratch, couldn't an existing GPL/MIT solution be integrated, thus eliminating the need for (at least) three different solutions. Pardon me for being presumptious. I admit I'm not in anyway a programmer, just an end-user, but I feel in this day and age a suite-wide color picker is commonplace, and judging by questions and requests posted here, on ask.libreoffice.org and elsewhere, I'm not alone. Thank you. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93331] LibreOffice.app bundle integrity is destroyed by language pack installer
https://bugs.documentfoundation.org/show_bug.cgi?id=93331 --- Comment #13 from Dale --- I believe this bug is still present. Information from "About LibreOffice": Version: 6.2.5.2 Build ID: 1ec314fa52f458adc18c4f025c545a4e8b22c159 CPU threads: 16; OS: Mac OS X 10.14.6; UI render: default; VCL: osx; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded To reproduce: install LibreOffice.app into ~/Applications (or anywhere your user can write to it), start LibreOffice, open a blank Writer document. Afterwards: $ codesign -vv ~/Applications/LibreOffice.app/ /Users/dale/Applications/LibreOffice.app/: a sealed resource is missing or invalid file added: /Users/dale/Applications/LibreOffice.app/Contents/Resources/__pycache__/uno.cpython-35.pyc file added: /Users/dale/Applications/LibreOffice.app/Contents/Resources/__pycache__/pythonloader.cpython-35.pyc file added: /Users/dale/Applications/LibreOffice.app/Contents/Resources/__pycache__/unohelper.cpython-35.pyc file added: /Users/dale/Applications/LibreOffice.app/Contents/Resources/extensions/dict-en/pythonpath/__pycache__/lightproof_opts_en.cpython-35.pyc file added: /Users/dale/Applications/LibreOffice.app/Contents/Resources/extensions/dict-en/pythonpath/__pycache__/lightproof_impl_en.cpython-35.pyc file added: /Users/dale/Applications/LibreOffice.app/Contents/Resources/extensions/dict-en/pythonpath/__pycache__/lightproof_en.cpython-35.pyc file added: /Users/dale/Applications/LibreOffice.app/Contents/Resources/extensions/dict-en/pythonpath/__pycache__/lightproof_handler_en.cpython-35.pyc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112470] EDITING: Exiting edit mode via clicking on header skewes column selection
https://bugs.documentfoundation.org/show_bug.cgi?id=112470 Miklos Vajna changed: What|Removed |Added Blocks|118739 | --- Comment #2 from Miklos Vajna --- I just tried this again with older versions, I can even see rendering errors with OpenOffice.org on Linux. So at least it does not belong to the "List-Combobox-RenderContext-regressions" tracker. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=118739 [Bug 118739] [META] Refactor ListBox/ComboBox to use RenderContext regressions -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118739] [META] Refactor ListBox/ComboBox to use RenderContext regressions
https://bugs.documentfoundation.org/show_bug.cgi?id=118739 Miklos Vajna changed: What|Removed |Added Depends on|112470 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112470 [Bug 112470] EDITING: Exiting edit mode via clicking on header skewes column selection -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99296] Calc: Disable headers/footers by default
https://bugs.documentfoundation.org/show_bug.cgi?id=99296 --- Comment #22 from Roman Kuznetsov <79045_79...@mail.ru> --- Heiko, I suggest merge back your patch disabling header/footer by default. For solution of the problem with "Insert->Headers and Footers" menu item I suggest follow variants for discuss: 1. Just delete menu item Insert->Headers and Footers at all and update guides and Help. 2. Insert->Headers and Footers should be split to two menu items Insert->Header and Insert->Footer that will be open Format->Page dialog on Header and Footer tabs and will activate options "Header on" / "Footer on" respectively. I think disabling of Headers/Footers by default is more important and useful thing than disabled "Insert->Headers and Footers" menu item that btw. has workaround. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126446] Pixelated and blurry icons on a fresh Windows 10 install with dpi higher than 125%
https://bugs.documentfoundation.org/show_bug.cgi?id=126446 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #3 from V Stuart Foote --- Default 'Automatic' icon theme selection on Windows are the Colibre icons in PNG. The PNG will be scaled in bulk in response to setting os UI magnification. That scaling of the PNG bitmaped icons can appear pixeleated at higher valuse--I find 175% to be ugly, %150 is marginal. Fortunately to support scaling to support HiDPI displays, LibreOffice now provides icon themes as SVG. The SVG are scaled and then saved in bulk to new PNG corresponding to the UI magnification. Give the SVGs a test from Tools -> Options -> View: 'Icon Style' droplist then close and reopen LibreOffice--a new SVG derived icon set will be built for the UI magnification set. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/ui/unoidl/UnoDocumentSettings.cxx |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 1733b527ac07fcb0067905e7277227f086b53afb
Author: Caolán McNamara
AuthorDate: Wed Jul 24 08:43:28 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 16:04:39 2019 +0200
cid#1451642 silence Division or modulo by zero
Change-Id: I728528ecbb69c23b63807944e4ae0beb9cb86cbb
Reviewed-on: https://gerrit.libreoffice.org/76222
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sd/source/ui/unoidl/UnoDocumentSettings.cxx
b/sd/source/ui/unoidl/UnoDocumentSettings.cxx
index 3add9902b8c7..2b426a632380 100644
--- a/sd/source/ui/unoidl/UnoDocumentSettings.cxx
+++ b/sd/source/ui/unoidl/UnoDocumentSettings.cxx
@@ -701,7 +701,9 @@ DocumentSettings::_setPropertyValues(const
PropertyMapEntry** ppEntries,
sal_Int32 nValue = 0;
if( *pValues >>= nValue )
{
-Fraction aFract( pDoc->GetUIScale().GetNumerator(),
nValue );
+auto nNumerator = pDoc->GetUIScale().GetNumerator();
+assert(nNumerator != 0);
+Fraction aFract(nNumerator, nValue);
pDoc->SetUIScale( aFract );
bOk = true;
bChanged = true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/source
sd/source/ui/view/drviews1.cxx | 26 +-
1 file changed, 5 insertions(+), 21 deletions(-)
New commits:
commit 8213923c183c95c58b8c82ab6ad5e3f1611a4202
Author: Ashod Nakashian
AuthorDate: Wed Nov 28 22:06:05 2018 -0500
Commit: Noel Grandin
CommitDate: Wed Jul 24 16:02:18 2019 +0200
LOK: sd: use native SdPage to flag selection
The slide-sorter is actually still necessary to apply/change
the master slide of a given slide, so we must enable it.
Change-Id: I3f59f58be76ab1c63453b4f6288044572800a556
Change-Id: I7554ba4afd28d7ea4f3ed6ba375d9765a89ef21c
Reviewed-on: https://gerrit.libreoffice.org/69618
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
Reviewed-on: https://gerrit.libreoffice.org/73497
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sd/source/ui/view/drviews1.cxx b/sd/source/ui/view/drviews1.cxx
index 768bf33ef473..67a651122497 100644
--- a/sd/source/ui/view/drviews1.cxx
+++ b/sd/source/ui/view/drviews1.cxx
@@ -774,31 +774,15 @@ bool DrawViewShell::ActivateObject(SdrOle2Obj* pObj, long
nVerb)
*/
bool DrawViewShell::SelectPage(sal_uInt16 nPage, sal_uInt16 nSelect)
{
-slidesorter::SlideSorterViewShell* pSlideSorterViewShell
-=
slidesorter::SlideSorterViewShell::GetSlideSorter(GetViewShellBase());
-if (pSlideSorterViewShell != nullptr)
+SdPage* pPage = GetDoc()->GetSdPage(nPage, PageKind::Standard);
+if (pPage)
{
-slidesorter::controller::PageSelector& aPageSelector
-=
pSlideSorterViewShell->GetSlideSorter().GetController().GetPageSelector();
if (nSelect == 0)
-{
-// Deselect.
-aPageSelector.DeselectPage(nPage);
-
-}
+pPage->SetSelected(false); // Deselect.
else if (nSelect == 1)
-{
-// Select.
-aPageSelector.SelectPage(nPage);
-}
+pPage->SetSelected(true); // Select.
else
-{
-// Toggle.
-if (aPageSelector.IsPageSelected(nPage))
-aPageSelector.DeselectPage(nPage);
-else
-aPageSelector.SelectPage(nPage);
-}
+pPage->SetSelected(!pPage->IsSelected()); // Toggle.
return true;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126400] LibreOffice math does not get focus back after using tool window
https://bugs.documentfoundation.org/show_bug.cgi?id=126400 V Stuart Foote changed: What|Removed |Added Ever confirmed|0 |1 Blocks||103461 Status|UNCONFIRMED |NEEDINFO CC||rb.hensc...@t-online.de, ||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- Can not confirm on Winndows 10 Home 64-bit en-US (1903) with Version: 6.2.5.2 (x64) Build ID: 1ec314fa52f458adc18c4f025c545a4e8b22c159 CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded Focus after selection from the elements pane shifts back to the input window. I didn't check with (experimental) visual mode--but that is not likely relevant here. What os/DE distro are you using? And, have you tried using a different VCL plugin? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103461 [Bug 103461] [META] Elements pane/dock/window/sidebar in Math -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103461] [META] Elements pane/dock/window/sidebar in Math
https://bugs.documentfoundation.org/show_bug.cgi?id=103461 V Stuart Foote changed: What|Removed |Added Depends on||126400 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=126400 [Bug 126400] LibreOffice math does not get focus back after using tool window -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126524] Default unnamed data series name longer than in Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=126524 Gabor Kelemen changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |kelem...@ubuntu.com |desktop.org | Ever confirmed|0 |1 Status|UNCONFIRMED |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126524] Default unnamed data series name longer than in Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=126524 NISZ LibreOffice Team changed: What|Removed |Added Blocks||75057 CC||kelem...@ubuntu.com, ||nem...@numbertext.org Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=75057 [Bug 75057] [META] OOXML Chart object issues -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75057] [META] OOXML Chart object issues
https://bugs.documentfoundation.org/show_bug.cgi?id=75057 NISZ LibreOffice Team changed: What|Removed |Added Depends on||126524 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=126524 [Bug 126524] Default unnamed data series name longer than in Excel -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126524] Default unnamed data series name longer than in Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=126524 --- Comment #2 from NISZ LibreOffice Team --- Created attachment 152966 --> https://bugs.documentfoundation.org/attachment.cgi?id=152966=edit Screenshot of the original document side by side in Word and Writer -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126524] Default unnamed data series name longer than in Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=126524 --- Comment #1 from NISZ LibreOffice Team --- Created attachment 152965 --> https://bugs.documentfoundation.org/attachment.cgi?id=152965=edit Example file from Word -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126524] New: Default unnamed data series name longer than in Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=126524 Bug ID: 126524 Summary: Default unnamed data series name longer than in Excel Product: LibreOffice Version: 6.4.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: libreoff...@nisz.hu Description: If there is an unnamed data series in a chart data source then the default placeholder name is much longer than in MSO. This can affect the layout of the chart. Steps to Reproduce: Steps to reproduce: 1. Open attached file in Word and recent Writer Actual Results: The default data series name is “Unnamed Series N” instead of “SeriesN”. As consequence the chart draw area is a bit narrower. Expected Results: Same default name. Reproducible: Always User Profile Reset: No Additional Info: LibreOffice details: Version: 6.4.0.0.alpha0+ (x86) Build ID: 382aceb80d3c0f420d51762e1f88eee2334ff11b CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-07-21_23:45:18 Locale: hu-HU (hu_HU); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang framework/inc framework/source
compilerplugins/clang/unusedfields.only-used-in-constructor.results | 30 +++--- compilerplugins/clang/unusedfields.readonly.results | 26 ++--- compilerplugins/clang/unusedfields.untouched.results| 14 +- compilerplugins/clang/unusedfields.writeonly.results| 50 +- framework/inc/xml/imagesdocumenthandler.hxx |5 - framework/source/xml/imagesdocumenthandler.cxx | 10 -- 6 files changed, 63 insertions(+), 72 deletions(-) New commits: commit 5ae7908ecec19d2d7f5464bf89fcd26a4aef3ace Author: Noel Grandin AuthorDate: Wed Jul 24 11:26:48 2019 +0200 Commit: Noel Grandin CommitDate: Wed Jul 24 15:36:24 2019 +0200 loplugin:unusedfields Change-Id: I80ed513cf690f94bf4320b040b36d7f904c63482 Reviewed-on: https://gerrit.libreoffice.org/76233 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/compilerplugins/clang/unusedfields.only-used-in-constructor.results b/compilerplugins/clang/unusedfields.only-used-in-constructor.results index 8d2d4d9bb5d5..283d724286d2 100644 --- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results +++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results @@ -76,9 +76,9 @@ connectivity/source/inc/flat/EResultSet.hxx:42 connectivity::flat::OFlatResultSet m_bBookmarkable _Bool connectivity/source/inc/java/lang/Object.hxx:45 connectivity::SDBThreadAttach m_aGuard jvmaccess::class VirtualMachine::AttachGuard -cppcanvas/source/mtfrenderer/textaction.cxx:809 +cppcanvas/source/mtfrenderer/textaction.cxx:811 cppcanvas::internal::(anonymous namespace)::EffectTextAction maTextLineInfo const tools::TextLineInfo -cppcanvas/source/mtfrenderer/textaction.cxx:1638 +cppcanvas/source/mtfrenderer/textaction.cxx:1644 cppcanvas::internal::(anonymous namespace)::OutlineAction maTextLineInfo const tools::TextLineInfo cppu/source/threadpool/threadpool.cxx:354 _uno_ThreadPool dummy sal_Int32 @@ -186,6 +186,16 @@ filter/source/graphicfilter/icgm/chart.hxx:46 DataNode nBoxX2 sal_Int16 filter/source/graphicfilter/icgm/chart.hxx:47 DataNode nBoxY2 sal_Int16 +framework/inc/xml/imagesdocumenthandler.hxx:99 +framework::OReadImagesDocumentHandler m_bExternalImagesStartFound _Bool +framework/inc/xml/imagesdocumenthandler.hxx:100 +framework::OReadImagesDocumentHandler m_bExternalImageStartFound _Bool +framework/inc/xml/imagesdocumenthandler.hxx:101 +framework::OReadImagesDocumentHandler m_nHashMaskModeBitmap sal_Int32 +framework/inc/xml/imagesdocumenthandler.hxx:102 +framework::OReadImagesDocumentHandler m_nHashMaskModeColor sal_Int32 +framework/inc/xml/imagesdocumenthandler.hxx:133 +framework::OWriteImagesDocumentHandler m_aXMLXlinkNS class rtl::OUString helpcompiler/inc/HelpCompiler.hxx:197 HelpCompiler lang const std::string include/basic/basmgr.hxx:56 @@ -736,9 +746,9 @@ sw/inc/unosett.hxx:145 SwXNumberingRules m_pImpl ::sw::UnoImplPtr sw/qa/core/test_ToxTextGenerator.cxx:139 ToxTextGeneratorWithMockedChapterField mChapterFieldType class SwChapterFieldType -sw/qa/extras/layout/layout.cxx:2608 - class SvtSysLocaleOptions & -sw/qa/extras/uiwriter/uiwriter.cxx:4068 +sw/qa/extras/uiwriter/uiwriter2.cxx:65 + class SwUiWriterTest2 * +sw/qa/extras/uiwriter/uiwriter.cxx:4065 IdleTask maIdle class Idle sw/source/core/crsr/crbm.cxx:66 (anonymous namespace)::CursorStateHelper m_aSaveState const class SwCursorSaveState @@ -750,10 +760,6 @@ sw/source/core/text/inftxt.hxx:679 SwTextSlot aText class rtl::OUString sw/source/core/text/porfld.cxx:143 SwFieldSlot aText class rtl::OUString -sw/source/filter/inc/fltshell.hxx:214 -SwFltRedline aStampPrev const class DateTime -sw/source/filter/inc/fltshell.hxx:216 -SwFltRedline eTypePrev const enum RedlineType sw/source/uibase/docvw/romenu.hxx:35 SwReadOnlyPopup m_aBuilder class VclBuilder sw/source/uibase/inc/condedit.hxx:43 @@ -832,9 +838,9 @@ vcl/source/app/salvtables.cxx:2568 SalInstanceEntry m_aTextFilter class (anonymous namespace)::WeldTextFilter vcl/source/app/salvtables.cxx:5012 SalInstanceComboBoxWithEdit m_aTextFilter class (anonymous namespace)::WeldTextFilter -vcl/source/gdi/jobset.cxx:36 +vcl/source/gdi/jobset.cxx:35 ImplOldJobSetupData cDeviceName char [32] -vcl/source/gdi/jobset.cxx:37 +vcl/source/gdi/jobset.cxx:36 ImplOldJobSetupData cPortName char [32] vcl/source/gdi/pdfbuildin_fonts.hxx:34 vcl::pdf::BuildinFont m_nAscent const int @@ -842,7 +848,7 @@ vcl/source/gdi/pdfbuildin_fonts.hxx:35 vcl::pdf::BuildinFont m_nDescent const int vcl/source/gdi/pdfbuildin_fonts.hxx:42 vcl::pdf::BuildinFont m_aWidths const int [256] -vcl/unx/gtk3/gtk3gtkinst.cxx:3593 +vcl/unx/gtk3/gtk3gtkinst.cxx:3597 CrippledViewport viewport GtkViewport vcl/unx/gtk/a11y/atkhypertext.cxx:29 HyperLink atk_hyper_link const AtkHyperlink diff
[Libreoffice-commits] core.git: extensions/source
extensions/source/ole/unoobjw.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 4bd1b38633d6cb288eb559afc0ac6b961538ae60
Author: Tor Lillqvist
AuthorDate: Thu Mar 7 14:55:57 2019 +0200
Commit: Tor Lillqvist
CommitDate: Wed Jul 24 15:19:10 2019 +0200
Add FIXME
Change-Id: Id8a553ef880c79a1d71b6df9586f75a83f53746a
Reviewed-on: https://gerrit.libreoffice.org/76266
Reviewed-by: Tor Lillqvist
Tested-by: Tor Lillqvist
diff --git a/extensions/source/ole/unoobjw.cxx
b/extensions/source/ole/unoobjw.cxx
index 3c8313e4c83e..1a476117e739 100644
--- a/extensions/source/ole/unoobjw.cxx
+++ b/extensions/source/ole/unoobjw.cxx
@@ -951,6 +951,7 @@ HRESULT STDMETHODCALLTYPE
CXTypeInfo::GetDocumentation(MEMBERID memid,
}
else
{
+// FIXME: Shouldn't we be able to know the names of the members of
UNO interfaces?
*pBstrName =
SysAllocString(o3tl::toW(OUString("UnknownNameOfMember#" +
OUString::number(memid)).getStr()));
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125681] Clicking on Insert Symbol hangs session
https://bugs.documentfoundation.org/show_bug.cgi?id=125681 Commit Notification changed: What|Removed |Added Whiteboard||target:6.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125681] Clicking on Insert Symbol hangs session
https://bugs.documentfoundation.org/show_bug.cgi?id=125681 --- Comment #4 from Commit Notification --- Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/online/+/f7a70ba9d3411953ca4147ac8cc484dd8745b5b7%5E%21 tdf#125681: Get rid of ChildSession::getDocumentMutex() and associated code -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: 2 commits - common/Session.cpp common/Session.hpp kit/ChildSession.cpp kit/ChildSession.hpp kit/Kit.cpp test/data test/Makefile.am test/UnitWOPITemplate.cpp test/Whit
common/Session.cpp|7 +
common/Session.hpp|2
kit/ChildSession.cpp | 184 +++---
kit/ChildSession.hpp |7 -
kit/Kit.cpp | 30 +--
test/Makefile.am |9 +-
test/UnitWOPITemplate.cpp | 172 +++
test/WhiteBoxTests.cpp|8 --
test/data/test.ott|binary
wsd/ClientSession.cpp | 16 +++-
wsd/DocumentBroker.cpp| 10 ++
wsd/LOOLWSD.cpp |3
wsd/Storage.cpp | 24 --
wsd/Storage.hpp | 14 ++-
14 files changed, 311 insertions(+), 175 deletions(-)
New commits:
commit 760864870fa8992fda58be03f3f55232b247506f
Author: Henry Castro
AuthorDate: Tue May 21 23:33:26 2019 -0400
Commit: Jan Holesovsky
CommitDate: Wed Jul 24 12:10:15 2019 +0200
wsd: introduce "TemplateSource" WOPI property
Change-Id: I9df1d5d0d4be7fe10ee15c40c36195c86ccf857e
Reviewed-on: https://gerrit.libreoffice.org/76190
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Jan Holesovsky
diff --git a/common/Session.cpp b/common/Session.cpp
index 1c37e5ba2..5c8d11568 100644
--- a/common/Session.cpp
+++ b/common/Session.cpp
@@ -75,7 +75,7 @@ bool Session::sendBinaryFrame(const char *buffer, int length)
return sendMessage(buffer, length, WSOpCode::Binary) >= length;
}
-void Session::parseDocOptions(const std::vector& tokens, int&
part, std::string& timestamp)
+void Session::parseDocOptions(const std::vector& tokens, int&
part, std::string& timestamp, std::string& doctemplate)
{
// First token is the "load" command itself.
size_t offset = 1;
@@ -161,6 +161,11 @@ void Session::parseDocOptions(const
std::vector& tokens, int& part,
timestamp = value;
++offset;
}
+else if (name == "template")
+{
+doctemplate = value;
+++offset;
+}
}
Util::mapAnonymized(_userId, _userIdAnonym);
diff --git a/common/Session.hpp b/common/Session.hpp
index f09af7574..ddee50d55 100644
--- a/common/Session.hpp
+++ b/common/Session.hpp
@@ -124,7 +124,7 @@ protected:
/// Parses the options of the "load" command,
/// shared between MasterProcessSession::loadDocument() and
ChildProcessSession::loadDocument().
-void parseDocOptions(const std::vector& tokens, int& part,
std::string& timestamp);
+void parseDocOptions(const std::vector& tokens, int& part,
std::string& timestamp, std::string& doctemplate);
void updateLastActivityTime()
{
diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index 60cf4c087..a229ae5f0 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -534,8 +534,8 @@ bool ChildSession::loadDocument(const char * /*buffer*/,
int /*length*/, const s
return false;
}
-std::string timestamp;
-parseDocOptions(tokens, part, timestamp);
+std::string timestamp, doctemplate;
+parseDocOptions(tokens, part, timestamp, doctemplate);
std::string renderOpts;
if (!getDocOptions().empty())
@@ -556,7 +556,7 @@ bool ChildSession::loadDocument(const char * /*buffer*/,
int /*length*/, const s
const bool loaded = _docManager.onLoad(getId(), getJailedFilePath(),
getJailedFilePathAnonym(),
getUserName(), getUserNameAnonym(),
getDocPassword(), renderOpts,
getHaveDocPassword(),
- getLang(), getWatermarkText());
+ getLang(), getWatermarkText(),
doctemplate);
if (!loaded || _viewId < 0)
{
LOG_ERR("Failed to get LoKitDocument instance for [" <<
getJailedFilePathAnonym() << "].");
@@ -566,6 +566,17 @@ bool ChildSession::loadDocument(const char * /*buffer*/,
int /*length*/, const s
LOG_INF("Created new view with viewid: [" << _viewId << "] for username:
[" <<
getUserNameAnonym() << "] in session: [" << getId() << "].");
+if (!doctemplate.empty())
+{
+std::string url = getJailedFilePath();
+bool success = getLOKitDocument()->saveAs(url.c_str(), nullptr,
nullptr);
+if (!success)
+{
+LOG_ERR("Failed to save template [" << getJailedFilePath() <<
"].");
+return false;
+}
+}
+
getLOKitDocument()->setView(_viewId);
_docType = LOKitHelper::getDocumentTypeAsString(getLOKitDocument()->get());
diff --git a/kit/ChildSession.hpp b/kit/ChildSession.hpp
index 215d1ad4b..bb6a3d720 100644
--- a/kit/ChildSession.hpp
+++ b/kit/ChildSession.hpp
@@ -46,7 +46,8 @@ public:
const std::string& renderOpts,
const bool haveDocPassword,
const std::string& lang,
-const std::string& watermarkText) = 0;
+const std::string& watermarkText,
+
[Libreoffice-commits] core.git: compilerplugins/clang cui/source sc/source
compilerplugins/clang/unusedenumconstants.readonly.results | 482 compilerplugins/clang/unusedenumconstants.untouched.results | 124 compilerplugins/clang/unusedenumconstants.writeonly.results | 6638 +--- cui/source/inc/cuihyperdlg.hxx | 10 cui/source/inc/iconcdlg.hxx |1 sc/source/ui/inc/PivotLayoutTreeListBase.hxx|3 6 files changed, 3596 insertions(+), 3662 deletions(-) New commits: commit 8d73da6696e42f57abbd8317d227054a4b5475ed Author: Noel Grandin AuthorDate: Wed Jul 24 12:17:29 2019 +0200 Commit: Noel Grandin CommitDate: Wed Jul 24 15:10:17 2019 +0200 loplugin:unusedenumconstants Change-Id: I484b39d1060e6a563dabdde03867989b8ba067f9 Reviewed-on: https://gerrit.libreoffice.org/76237 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/compilerplugins/clang/unusedenumconstants.readonly.results b/compilerplugins/clang/unusedenumconstants.readonly.results index bf5ce11700ea..57147a88192c 100644 --- a/compilerplugins/clang/unusedenumconstants.readonly.results +++ b/compilerplugins/clang/unusedenumconstants.readonly.results @@ -5,7 +5,7 @@ bridges/source/cpp_uno/gcc3_linux_x86-64/abi.cxx:78 bridges/source/cpp_uno/gcc3_linux_x86-64/abi.cxx:79 enum x86_64_reg_class X86_64_X87UP_CLASS chart2/source/inc/CharacterProperties.hxx:121 -enum chart::CharacterProperties::(anonymous at /home/noel/libo2/chart2/source/inc/CharacterProperties.hxx:42:5) FAST_PROPERTY_ID_END_CHAR_PROP +enum chart::CharacterProperties::(anonymous at /media/noel/disk3/libo6/chart2/source/inc/CharacterProperties.hxx:42:5) FAST_PROPERTY_ID_END_CHAR_PROP chart2/source/inc/TitleHelper.hxx:48 enum chart::TitleHelper::eTitleType NORMAL_TITLE_END chart2/source/view/inc/ShapeFactory.hxx:50 @@ -38,45 +38,19 @@ chart2/source/view/inc/ShapeFactory.hxx:63 enum chart::SymbolEnum Symbol_HorizontalBar chart2/source/view/inc/ShapeFactory.hxx:64 enum chart::SymbolEnum Symbol_VerticalBar -configmgr/source/access.hxx:455 -enum configmgr::Access::(anonymous at /home/noel/libo2/configmgr/source/access.hxx:453:5) IS_GROUP_MEMBER -configmgr/source/access.hxx:455 -enum configmgr::Access::(anonymous at /home/noel/libo2/configmgr/source/access.hxx:453:5) IS_SET_MEMBER -configmgr/source/parsemanager.hxx:47 -enum configmgr::ParseManager::(anonymous at /home/noel/libo2/configmgr/source/parsemanager.hxx:47:5) NAMESPACE_XS -configmgr/source/parsemanager.hxx:47 -enum configmgr::ParseManager::(anonymous at /home/noel/libo2/configmgr/source/parsemanager.hxx:47:5) NAMESPACE_OOR -configmgr/source/parsemanager.hxx:47 -enum configmgr::ParseManager::(anonymous at /home/noel/libo2/configmgr/source/parsemanager.hxx:47:5) NAMESPACE_XSI +configmgr/source/access.hxx:445 +enum configmgr::Access::(anonymous at /media/noel/disk3/libo6/configmgr/source/access.hxx:443:5) IS_GROUP_MEMBER +configmgr/source/access.hxx:445 +enum configmgr::Access::(anonymous at /media/noel/disk3/libo6/configmgr/source/access.hxx:443:5) IS_SET_MEMBER +configmgr/source/parsemanager.hxx:44 +enum configmgr::ParseManager::(anonymous at /media/noel/disk3/libo6/configmgr/source/parsemanager.hxx:44:5) NAMESPACE_XSI +configmgr/source/parsemanager.hxx:44 +enum configmgr::ParseManager::(anonymous at /media/noel/disk3/libo6/configmgr/source/parsemanager.hxx:44:5) NAMESPACE_OOR +configmgr/source/parsemanager.hxx:44 +enum configmgr::ParseManager::(anonymous at /media/noel/disk3/libo6/configmgr/source/parsemanager.hxx:44:5) NAMESPACE_XS connectivity/source/drivers/evoab2/NConnection.hxx:41 connectivity::evoab::SDBCAddress::sdbc_address_type Unknown -cppcanvas/source/mtfrenderer/emfppen.cxx:53 -enum cppcanvas::internal::EmfPlusPenData PenDataTransform -cppcanvas/source/mtfrenderer/emfppen.cxx:54 -enum cppcanvas::internal::EmfPlusPenData PenDataStartCap -cppcanvas/source/mtfrenderer/emfppen.cxx:55 -enum cppcanvas::internal::EmfPlusPenData PenDataEndCap -cppcanvas/source/mtfrenderer/emfppen.cxx:56 -enum cppcanvas::internal::EmfPlusPenData PenDataJoin -cppcanvas/source/mtfrenderer/emfppen.cxx:57 -enum cppcanvas::internal::EmfPlusPenData PenDataMiterLimit -cppcanvas/source/mtfrenderer/emfppen.cxx:58 -enum cppcanvas::internal::EmfPlusPenData PenDataLineStyle -cppcanvas/source/mtfrenderer/emfppen.cxx:59 -enum cppcanvas::internal::EmfPlusPenData PenDataDashedLineCap -cppcanvas/source/mtfrenderer/emfppen.cxx:60 -enum cppcanvas::internal::EmfPlusPenData PenDataDashedLineOffset -cppcanvas/source/mtfrenderer/emfppen.cxx:61 -enum cppcanvas::internal::EmfPlusPenData PenDataDashedLine -cppcanvas/source/mtfrenderer/emfppen.cxx:62 -enum cppcanvas::internal::EmfPlusPenData PenDataNonCenter -cppcanvas/source/mtfrenderer/emfppen.cxx:63 -enum cppcanvas::internal::EmfPlusPenData PenDataCompoundLine -cppcanvas/source/mtfrenderer/emfppen.cxx:64 -enum
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/svlbitm.hxx |3 +--
include/vcl/treelistbox.hxx |3 +--
vcl/source/treelist/svlbitm.cxx |9 -
3 files changed, 6 insertions(+), 9 deletions(-)
New commits:
commit be07f2b19ddce09eb4f18b0a7cc4f1583b3f86e0
Author: Noel Grandin
AuthorDate: Wed Jul 24 11:55:34 2019 +0200
Commit: Noel Grandin
CommitDate: Wed Jul 24 15:05:22 2019 +0200
remove unused SvLBoxButtonKind::StaticImage
and consequently unused SvBmp::STATICIMAGE
Change-Id: Ie48deb0c757e6eb9e22e7b29cde72b0145c16943
Reviewed-on: https://gerrit.libreoffice.org/76235
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/vcl/svlbitm.hxx b/include/vcl/svlbitm.hxx
index 8d267e0754af..c28bed22f460 100644
--- a/include/vcl/svlbitm.hxx
+++ b/include/vcl/svlbitm.hxx
@@ -39,8 +39,7 @@ enum class SvBmp
TRISTATE = 2,
HIUNCHECKED = 3,
HICHECKED= 4,
-HITRISTATE = 5,
-STATICIMAGE = 6
+HITRISTATE = 5
};
enum class SvItemStateFlags
diff --git a/include/vcl/treelistbox.hxx b/include/vcl/treelistbox.hxx
index c6a13397ba80..ef515aebf5a8 100644
--- a/include/vcl/treelistbox.hxx
+++ b/include/vcl/treelistbox.hxx
@@ -57,8 +57,7 @@ namespace utl {
enum class SvLBoxButtonKind
{
EnabledCheckbox,
-DisabledCheckbox,
-StaticImage
+DisabledCheckbox
};
enum class SvButtonState { Unchecked, Checked, Tristate };
diff --git a/vcl/source/treelist/svlbitm.cxx b/vcl/source/treelist/svlbitm.cxx
index 56b4f016d9e9..58433644ee93 100644
--- a/vcl/source/treelist/svlbitm.cxx
+++ b/vcl/source/treelist/svlbitm.cxx
@@ -40,7 +40,7 @@ void SvLBoxButtonData::InitData( bool _bRadioBtn, const
Control* pCtrl )
{
nWidth = nHeight = 0;
-aBmps.resize(int(SvBmp::STATICIMAGE)+1);
+aBmps.resize(int(SvBmp::HITRISTATE)+1);
bDataOk = false;
pImpl->bDefaultImages = true;
@@ -307,14 +307,13 @@ void SvLBoxButton::Paint(
const Point& rPos, SvTreeListBox& rDev, vcl::RenderContext& rRenderContext,
const SvViewDataEntry* /*pView*/, const SvTreeListEntry& /*rEntry*/)
{
-SvBmp nIndex = eKind == SvLBoxButtonKind::StaticImage ? SvBmp::STATICIMAGE
: SvLBoxButtonData::GetIndex(nItemFlags);
+SvBmp nIndex = SvLBoxButtonData::GetIndex(nItemFlags);
DrawImageFlags nStyle = eKind != SvLBoxButtonKind::DisabledCheckbox &&
rDev.IsEnabled() ? DrawImageFlags::NONE : DrawImageFlags::Disable;
//Native drawing
bool bNativeOK = false;
ControlType eCtrlType = (pData->IsRadio())? ControlType::Radiobutton :
ControlType::Checkbox;
-if ( nIndex != SvBmp::STATICIMAGE &&
rRenderContext.IsNativeControlSupported( eCtrlType, ControlPart::Entire) )
-
+if ( rRenderContext.IsNativeControlSupported( eCtrlType,
ControlPart::Entire) )
{
Size aSize(pData->Width(), pData->Height());
ImplAdjustBoxSize(aSize, eCtrlType, rRenderContext);
@@ -386,7 +385,7 @@ void SvLBoxButton::InitViewData(SvTreeListBox*
pView,SvTreeListEntry* pEntry, Sv
Size aSize( pData->Width(), pData->Height() );
ControlType eCtrlType = (pData->IsRadio())? ControlType::Radiobutton :
ControlType::Checkbox;
-if ( eKind != SvLBoxButtonKind::StaticImage && pView )
+if ( pView )
ImplAdjustBoxSize(aSize, eCtrlType, *pView);
pViewData->mnWidth = aSize.Width();
pViewData->mnHeight = aSize.Height();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126523] New: Crash in: com::sun::star::uno::operator<<= >(com::sun::star::uno::Any &, com::sun::star::uno::R
https://bugs.documentfoundation.org/show_bug.cgi?id=126523 Bug ID: 126523 Summary: Crash in: com::sun::star::uno::operator<<= >(com::sun::star::uno::Any &,com::sun::star::uno::Reference const &) Product: LibreOffice Version: 6.1.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: framework Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j...@hp-homepages.de This bug was filed from the crash reporting server and is br-a1ec90c7-7e6f-4ca9-a628-2660bbbe2535. = The bug occurs in a database form inside a LibreOffice Writer document and leads to crashes without any error message. The crashes seem to occur randomly/nondeterministic when clicking different parts of the form. Often it continues crashing on the same data set after reopening the document until it suddenly works without any changes. Sometimes the form can be used for hours without any problems before it starts crashing. Related crash reports: http://crashreport.libreoffice.org/stats/crash_details/b20278ac-5c25-498f-9468-cbf4257f275b http://crashreport.libreoffice.org/stats/crash_details/15c39ed8-d785-44a9-87ad-b11a888f8b2a -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118739] [META] Refactor ListBox/ComboBox to use RenderContext regressions
https://bugs.documentfoundation.org/show_bug.cgi?id=118739 Miklos Vajna changed: What|Removed |Added Depends on|122830 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122830 [Bug 122830] UI: Hint is a empty gray box for line-setting in the cell appearance dialog of the sidebar with OpenGL enabled (very flickery without) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122830] UI: Hint is a empty gray box for line-setting in the cell appearance dialog of the sidebar with OpenGL enabled (very flickery without)
https://bugs.documentfoundation.org/show_bug.cgi?id=122830 Miklos Vajna changed: What|Removed |Added Blocks|118739 | --- Comment #4 from Miklos Vajna --- Adjusting the tracker bug list, this is not a regression from dca01def7885ad69cf66edd75cf8207a5adb64f9. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=118739 [Bug 118739] [META] Refactor ListBox/ComboBox to use RenderContext regressions -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/inc sc/qa sc/source
sc/inc/types.hxx | 11 +--
sc/qa/unit/ucalc.cxx |8
sc/qa/unit/ucalc_sharedformula.cxx |6 +++---
sc/source/core/data/bcaslot.cxx| 13 -
sc/source/core/data/table3.cxx |6 +++---
5 files changed, 19 insertions(+), 25 deletions(-)
New commits:
commit 8c1d25e0dbbcc9b6d4ed58f4bc9e87e10e5e
Author: Noel Grandin
AuthorDate: Wed Jul 24 11:51:57 2019 +0200
Commit: Noel Grandin
CommitDate: Wed Jul 24 14:43:54 2019 +0200
convert AreaOverlapType to scoped enum
and remove unused AreaPartialOverlap
Change-Id: I21e94d8d15c59485c1287e99dcc6558e0570a8eb
Reviewed-on: https://gerrit.libreoffice.org/76234
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sc/inc/types.hxx b/sc/inc/types.hxx
index c4e62ae63452..5c68c606d0fe 100644
--- a/sc/inc/types.hxx
+++ b/sc/inc/types.hxx
@@ -107,13 +107,12 @@ struct MultiDataCellState
MultiDataCellState( StateType eState );
};
-enum AreaOverlapType
+enum class AreaOverlapType
{
-AreaInside,
-AreaPartialOverlap,
-AreaInsideOrOverlap,
-OneRowInsideArea,
-OneColumnInsideArea
+Inside,
+InsideOrOverlap,
+OneRowInside,
+OneColumnInside
};
enum class ListenerGroupType
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 4db44ce1b6c1..c4a6f84cd3e6 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -4225,7 +4225,7 @@ void Test::testCopyPasteRepeatOneFormula()
ScRange aWholeSheet(0,0,0,MAXCOL,MAXROW,0);
ScBroadcastAreaSlotMachine* pBASM = m_pDoc->GetBASM();
CPPUNIT_ASSERT(pBASM);
-std::vector aListeners =
pBASM->GetAllListeners(aWholeSheet, sc::AreaInside);
+std::vector aListeners =
pBASM->GetAllListeners(aWholeSheet, sc::AreaOverlapType::Inside);
CPPUNIT_ASSERT_EQUAL(static_cast(1), aListeners.size());
const sc::AreaListener* pListener = aListeners.data();
CPPUNIT_ASSERT_EQUAL(ScRange(0,0,0,1,0,0), pListener->maArea);
@@ -4258,7 +4258,7 @@ void Test::testCopyPasteRepeatOneFormula()
#if !defined(USE_FORMULA_GROUP_LISTENER) || USE_FORMULA_GROUP_LISTENER
// At this point, there should only be one area listener and it should be
// a group listener listening on A1:B10.
-aListeners = pBASM->GetAllListeners(aWholeSheet, sc::AreaInside);
+aListeners = pBASM->GetAllListeners(aWholeSheet,
sc::AreaOverlapType::Inside);
CPPUNIT_ASSERT_EQUAL(static_cast(1), aListeners.size());
pListener = aListeners.data();
CPPUNIT_ASSERT_EQUAL(ScRange(0,0,0,1,9,0), pListener->maArea);
@@ -4276,7 +4276,7 @@ void Test::testCopyPasteRepeatOneFormula()
// This check makes only sense if group listeners are activated.
#if !defined(USE_FORMULA_GROUP_LISTENER) || USE_FORMULA_GROUP_LISTENER
// Make there we only have one group area listener listening on A2:B11.
-aListeners = pBASM->GetAllListeners(aWholeSheet, sc::AreaInside);
+aListeners = pBASM->GetAllListeners(aWholeSheet,
sc::AreaOverlapType::Inside);
CPPUNIT_ASSERT_EQUAL(static_cast(1), aListeners.size());
pListener = aListeners.data();
CPPUNIT_ASSERT_EQUAL(ScRange(0,1,0,1,10,0), pListener->maArea);
@@ -4303,7 +4303,7 @@ void Test::testCopyPasteRepeatOneFormula()
// This check makes only sense if group listeners are activated.
#if !defined(USE_FORMULA_GROUP_LISTENER) || USE_FORMULA_GROUP_LISTENER
// Check the group area listener again to make sure it's listening on
A1:B10 once again.
-aListeners = pBASM->GetAllListeners(aWholeSheet, sc::AreaInside);
+aListeners = pBASM->GetAllListeners(aWholeSheet,
sc::AreaOverlapType::Inside);
CPPUNIT_ASSERT_EQUAL(static_cast(1), aListeners.size());
pListener = aListeners.data();
CPPUNIT_ASSERT_EQUAL(ScRange(0,0,0,1,9,0), pListener->maArea);
diff --git a/sc/qa/unit/ucalc_sharedformula.cxx
b/sc/qa/unit/ucalc_sharedformula.cxx
index ea22e3651d4d..d07d7edaf391 100644
--- a/sc/qa/unit/ucalc_sharedformula.cxx
+++ b/sc/qa/unit/ucalc_sharedformula.cxx
@@ -648,7 +648,7 @@ void Test::testSharedFormulasRefUpdateRangeDeleteRow()
// Check the area listener status.
ScBroadcastAreaSlotMachine* pBASM = m_pDoc->GetBASM();
CPPUNIT_ASSERT(pBASM);
-std::vector aListeners =
pBASM->GetAllListeners(aWholeArea, sc::AreaInside);
+std::vector aListeners =
pBASM->GetAllListeners(aWholeArea, sc::AreaOverlapType::Inside);
std::sort(aListeners.begin(), aListeners.end(), SortByArea());
// This check makes only sense if group listeners are activated.
@@ -688,7 +688,7 @@ void Test::testSharedFormulasRefUpdateRangeDeleteRow()
// This check makes only sense if group listeners are activated.
#if !defined(USE_FORMULA_GROUP_LISTENER) || USE_FORMULA_GROUP_LISTENER
// We should only have one listener group-listening on A1:B4.
-aListeners = pBASM->GetAllListeners(aWholeArea, sc::AreaInside);
+aListeners = pBASM->GetAllListeners(aWholeArea,
sc::AreaOverlapType::Inside);
[Libreoffice-commits] core.git: include/svx svx/source
include/svx/DescriptionGenerator.hxx | 13 ---
svx/source/accessibility/DescriptionGenerator.cxx | 76 --
2 files changed, 1 insertion(+), 88 deletions(-)
New commits:
commit ba031cc41321c7817c5b23e0b5378e532f7e1dea
Author: Noel Grandin
AuthorDate: Wed Jul 24 11:57:52 2019 +0200
Commit: Noel Grandin
CommitDate: Wed Jul 24 14:38:59 2019 +0200
remove unused accessibility::DescriptionGenerator::PropertyType::FillStyle
Change-Id: I20005ad23088d41262ff988eac2132918db56ab8
Reviewed-on: https://gerrit.libreoffice.org/76236
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/svx/DescriptionGenerator.hxx
b/include/svx/DescriptionGenerator.hxx
index 8d3010ea5b94..7769a25dbe6a 100644
--- a/include/svx/DescriptionGenerator.hxx
+++ b/include/svx/DescriptionGenerator.hxx
@@ -44,8 +44,7 @@ public:
enum class PropertyType {
Color,
Integer,
-String,
-FillStyle
+String
};
/** Creates a new description generator with an empty description
@@ -165,16 +164,6 @@ private:
*/
SVX_DLLPRIVATE void AddString (const OUString& sPropertyName,
const OUString& sLocalizedName, sal_uInt16 nWhichId);
-
-/** Add a property value formatted as fill style to the description
-string. If the fill style is HATCH,
-GRADIENT, or BITMAP, then the of the
-hatch, gradient, or bitmap is appended as well.
-@param sPropertyName
-Name of the property. Usually this will be "FillStyle".
-*/
-SVX_DLLPRIVATE void AddFillStyle (const OUString& sPropertyName,
-const OUString& sLocalizedName);
};
diff --git a/svx/source/accessibility/DescriptionGenerator.cxx
b/svx/source/accessibility/DescriptionGenerator.cxx
index cefe8e104fcc..ff5bb21f20eb 100644
--- a/svx/source/accessibility/DescriptionGenerator.cxx
+++ b/svx/source/accessibility/DescriptionGenerator.cxx
@@ -169,9 +169,6 @@ void DescriptionGenerator::AddProperty (const OUString&
sPropertyName,
case PropertyType::String:
AddString (sPropertyName, sLocalizedName, nWhichId);
break;
-case PropertyType::FillStyle:
-AddFillStyle (sPropertyName, sLocalizedName);
-break;
}
}
}
@@ -266,79 +263,6 @@ void DescriptionGenerator::AddString (const OUString&
sPropertyName,
}
-void DescriptionGenerator::AddFillStyle (const OUString& sPropertyName,
-const OUString& sLocalizedName)
-{
-msDescription.append(sLocalizedName);
-msDescription.append('=');
-
-try
-{
-if (mxSet.is())
-{
-uno::Any aValue = mxSet->getPropertyValue (sPropertyName);
-drawing::FillStyle aFillStyle;
-aValue >>= aFillStyle;
-
-// Get the fill style name from the resource.
-OUString sFillStyleName;
-{
-SolarMutexGuard aGuard;
-switch (aFillStyle)
-{
-case drawing::FillStyle_NONE:
-sFillStyleName =
SvxResId(RID_SVXSTR_A11Y_FILLSTYLE_NONE);
-break;
-case drawing::FillStyle_SOLID:
-sFillStyleName =
SvxResId(RID_SVXSTR_A11Y_FILLSTYLE_SOLID);
-break;
-case drawing::FillStyle_GRADIENT:
-sFillStyleName =
SvxResId(RID_SVXSTR_A11Y_FILLSTYLE_GRADIENT);
-break;
-case drawing::FillStyle_HATCH:
-sFillStyleName =
SvxResId(RID_SVXSTR_A11Y_FILLSTYLE_HATCH);
-break;
-case drawing::FillStyle_BITMAP:
-sFillStyleName =
SvxResId(RID_SVXSTR_A11Y_FILLSTYLE_BITMAP);
-break;
-default:
-break;
-}
-}
-msDescription.append (sFillStyleName);
-
-// Append the appropriate properties.
-switch (aFillStyle)
-{
-case drawing::FillStyle_NONE:
-break;
-case drawing::FillStyle_SOLID:
-AddProperty ("FillColor", PropertyType::Color,
SIP_XA_FILLCOLOR);
-break;
-case drawing::FillStyle_GRADIENT:
-AddProperty ("FillGradientName", PropertyType::String,
SIP_XA_FILLGRADIENT,
-XATTR_FILLGRADIENT);
-break;
-case drawing::FillStyle_HATCH:
-AddProperty ("FillColor", PropertyType::Color,
SIP_XA_FILLCOLOR);
-AddProperty ("FillHatchName", PropertyType::String,
SIP_XA_FILLHATCH,
-XATTR_FILLHATCH);
-break;
-case drawing::FillStyle_BITMAP:
[Libreoffice-bugs] [Bug 126493] EDITING: Objects don't snap to grid properly
https://bugs.documentfoundation.org/show_bug.cgi?id=126493 --- Comment #2 from Harald Berger --- See also https://ask.libreoffice.org/en/question/201719/objects-dont-snap-exactly-to-gridlines-in-writer/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126493] EDITING: Objects don't snap to grid properly
https://bugs.documentfoundation.org/show_bug.cgi?id=126493 Harald Berger changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Harald Berger --- I confirm the bug below Windows 10 Home; Version 1903; 64-Bit Version: 6.2.5.2 (x64) Build ID: 1ec314fa52f458adc18c4f025c545a4e8b22c159 CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; Locale: en-GB (en_GB); UI-Language: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - cui/source sw/source
cui/source/dialogs/SpellDialog.cxx |1 +
sw/source/filter/ww8/ww8scan.cxx |3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 00af4b1e5157d1a7f71da168dc7b48707e9113cd
Author: Caolán McNamara
AuthorDate: Wed Jul 24 09:02:41 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 14:25:29 2019 +0200
cid#1451635 silence Dereference after null check
Change-Id: Ie5978be908647fe1215e1517a2bf638c7936dae2
Reviewed-on: https://gerrit.libreoffice.org/76225
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/source/dialogs/SpellDialog.cxx
b/cui/source/dialogs/SpellDialog.cxx
index 9c6e90b74c25..dc2a9b4ef83e 100644
--- a/cui/source/dialogs/SpellDialog.cxx
+++ b/cui/source/dialogs/SpellDialog.cxx
@@ -1483,6 +1483,7 @@ bool SentenceEditWindow_Impl::KeyInput(const KeyEvent&
rKeyEvt)
if (pErrorAttrib->nStart != m_nErrorStart ||
pErrorAttrib->nEnd != m_nErrorEnd)
{
std::unique_ptr
xNewError(pErrorAttrib->pAttr->Clone());
+assert(pErrorAttr);
m_xEditEngine->RemoveAttribs(ESelection(0,
pErrorAttr->nStart, 0, pErrorAttr->nEnd), false, EE_CHAR_GRABBAG);
SetAttrib(*xNewError, m_nErrorStart, m_nErrorEnd);
}
commit b055dda3c82086f5c633403bd952209d6ed4288f
Author: Caolán McNamara
AuthorDate: Wed Jul 24 10:05:59 2019 +0100
Commit: Caolán McNamara
CommitDate: Wed Jul 24 14:25:08 2019 +0200
cid#1448539 try silence Double free
Change-Id: I05f30f33acc06325eba59965a84fa43749d6f394
Reviewed-on: https://gerrit.libreoffice.org/76230
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 19e0d81e7850..196c0eef3936 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -2859,13 +2859,14 @@ WW8PLCFx_Fc_FKP::WW8Fkp::Entry&
mnIStd = rEntry.mnIStd;
mbMustDelete = rEntry.mbMustDelete;
-if (mbMustDelete)
+if (rEntry.mbMustDelete)
{
mpData = new sal_uInt8[mnLen];
memcpy(mpData, rEntry.mpData, mnLen);
}
else
mpData = rEntry.mpData;
+
return *this;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/source
vcl/source/app/salvtables.cxx |2 +- vcl/source/window/aboutdialog.cxx |2 +- vcl/source/window/builder.cxx |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 2d63403fa3bf7fe6019b58ce4af5c49968e03a5b Author: Caolán McNamara AuthorDate: Tue Jul 23 21:31:26 2019 +0100 Commit: Caolán McNamara CommitDate: Wed Jul 24 14:24:55 2019 +0200 move aboutdialog header inside vcl Change-Id: I1906992759afec0176b723917662fa0644a03c1c Reviewed-on: https://gerrit.libreoffice.org/76221 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/include/vcl/aboutdialog.hxx b/vcl/inc/aboutdialog.hxx similarity index 100% rename from include/vcl/aboutdialog.hxx rename to vcl/inc/aboutdialog.hxx diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx index 5aab75be773d..6f8d11cb7886 100644 --- a/vcl/source/app/salvtables.cxx +++ b/vcl/source/app/salvtables.cxx @@ -36,7 +36,6 @@ #include #include #include -#include #include #include #include @@ -65,6 +64,7 @@ #include #include #include +#include #include SalFrame::SalFrame() diff --git a/vcl/source/window/aboutdialog.cxx b/vcl/source/window/aboutdialog.cxx index b8a8aa595982..ba09f423ab05 100644 --- a/vcl/source/window/aboutdialog.cxx +++ b/vcl/source/window/aboutdialog.cxx @@ -12,11 +12,11 @@ #include #include #include -#include #include #include #include #include +#include #include #include diff --git a/vcl/source/window/builder.cxx b/vcl/source/window/builder.cxx index 604d9950dece..0a4c66e0cbf1 100644 --- a/vcl/source/window/builder.cxx +++ b/vcl/source/window/builder.cxx @@ -20,7 +20,6 @@ #include #include #include -#include #include #include #include @@ -61,6 +60,7 @@ #include #include #include +#include #include #include #include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
