[Libreoffice-bugs] [Bug 122218] After Update to 6.1.4 on macOS fonts are blurred on retina display

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122218

trainma...@gmail.com changed:

   What|Removed |Added

 CC||pentapo...@live.com

--- Comment #26 from trainma...@gmail.com ---
*** Bug 126982 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126982] Blurry text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126982

trainma...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from trainma...@gmail.com ---


*** This bug has been marked as a duplicate of bug 122218 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Mike Kaganski (via logerrit)]

 sw/source/core/unocore/unoobj.cxx |   13 -
 1 file changed, 4 insertions(+), 9 deletions(-)

New commits:
commit 17eb2f4d403cdbbacb8fa2c14a006b25241815d4
Author: Mike Kaganski 
AuthorDate: Fri Aug 16 15:07:12 2019 +0200
Commit: Mike Kaganski 
CommitDate: Sat Aug 17 07:05:07 2019 +0200

Use a nice way of merging ranges

... which will ensure correct sorted order of the ranges.

Change-Id: I6acb068c38af581354f4736f8058cf73d14f5dc2
Reviewed-on: https://gerrit.libreoffice.org/77585
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sw/source/core/unocore/unoobj.cxx 
b/sw/source/core/unocore/unoobj.cxx
index 0b1b3c78b083..e47a0b11a904 100644
--- a/sw/source/core/unocore/unoobj.cxx
+++ b/sw/source/core/unocore/unoobj.cxx
@@ -1783,7 +1783,8 @@ void SwUnoCursorHelper::SetPropertyValues(
 OUString aUnknownExMsg, aPropertyVetoExMsg;
 
 // Build set of attributes we want to fetch
-std::vector aWhichPairs;
+const sal_uInt16 zero = 0;
+SfxItemSet aItemSet(pDoc->GetAttrPool(), );
 std::vector> 
aEntries;
 aEntries.reserve(rPropertyValues.getLength());
 for (const auto& rPropVal : rPropertyValues)
@@ -1803,19 +1804,13 @@ void SwUnoCursorHelper::SetPropertyValues(
 {
 aPropertyVetoExMsg += "Property is read-only: '" + rPropertyName + 
"' ";
 continue;
-} else {
-// FIXME: we should have some nice way of merging ranges surely ?
-aWhichPairs.push_back(pEntry->nWID);
-aWhichPairs.push_back(pEntry->nWID);
 }
+aItemSet.MergeRange(pEntry->nWID, pEntry->nWID);
 aEntries.emplace_back(pEntry, rPropVal.Value);
 }
 
-if (!aWhichPairs.empty())
+if (!aEntries.empty())
 {
-aWhichPairs.push_back(0); // terminate
-SfxItemSet aItemSet(pDoc->GetAttrPool(), aWhichPairs.data());
-
 // Fetch, overwrite, and re-set the attributes from the core
 
 bool bPreviousPropertyCausesSideEffectsInNodes = false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - officecfg/registry

[Laurent BP (via logerrit)]

 officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu |   10 
+-
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 97b6565f27acad7288de016530c753f27f9d55f9
Author: Laurent BP 
AuthorDate: Fri Aug 16 10:40:38 2019 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Aug 17 06:59:48 2019 +0200

tdf#126908 Add lang to Tooltiplabel

Addition to commit c3ca559841c857bf7b39f665433d71c89d220d0f

Change-Id: Ie51412b31239f6aaf3813dee5c226a21c7d9c79d
Reviewed-on: https://gerrit.libreoffice.org/77562
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 
(cherry picked from commit 003369b6d76225761373d46754890dd7f3c296c3)
Reviewed-on: https://gerrit.libreoffice.org/77590
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
index 568a093e3ea4..37cbd22f5010 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
@@ -1536,7 +1536,7 @@
   ~Rows
 
 
-  Delete selected rows
+  Delete selected rows
 
 
   1
@@ -1550,7 +1550,7 @@
   ~Columns
 
 
-  Delete selected columns
+  Delete selected columns
 
 
   1
@@ -1564,7 +1564,7 @@
   ~Table
 
 
-  Delete table
+  Delete table
 
 
   1
@@ -1655,7 +1655,7 @@
   C~ell
 
 
-  Select Cell
+  Select Cell
 
 
   1
@@ -1693,7 +1693,7 @@
   ~Table
 
 
-  Select Table
+  Select Table
 
 
   1
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 46988] VIEWING: Screen jumps when scrolling down with arrow keys, refactor Smooth Scroll function

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46988

--- Comment #33 from Metal450  ---
...Is perhaps a some more appropriate place to bring this up for discussion? 
Seven years & counting (and it seems, no attention/consideration/replies in
well over a year)?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 46988] VIEWING: Screen jumps when scrolling down with arrow keys, refactor Smooth Scroll function

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46988

--- Comment #33 from Metal450  ---
...Is perhaps a some more appropriate place to bring this up for discussion? 
Seven years & counting (and it seems, no attention/consideration/replies in
well over a year)?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 126982] Blurry text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126982

--- Comment #1 from Penta-Power  ---
Created attachment 153451
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153451=edit
Blurry text example

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126982] New: Blurry text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126982

Bug ID: 126982
   Summary: Blurry text
   Product: LibreOffice
   Version: 6.3.0.4 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: pentapo...@live.com

Description:
Libre Office 6.3.0 Mac version doesn't display text clearly but very blurry.
This didn't happen in the previous version (6.2). The Mac version is 10.14.6.
This bug happens with both OpenGL enabled and disabled.

Actual Results:
All files are the same.

Expected Results:
Text should be clear as in other Mac apps.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Version: 6.3.0.4
Build ID: 057fc023c990d676a43019934386b85b21a9ee99
CPU threads: 4; OS: Mac OS X 10.14.6; UI render: GL; VCL: osx; 
Locale: vi-VN (fr_VN.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126787] Setting borders on character format become paragraph format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126787

--- Comment #3 from Mark Hung  ---
Hi Mike,

You may want to check this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126787] Setting borders on character format become paragraph format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126787

--- Comment #2 from Mark Hung  ---
I've bisected the issue.

c3586f0cde707dc41cde7debba89138c4d428ac1 is the first bad commit
commit c3586f0cde707dc41cde7debba89138c4d428ac1
Author: Jenkins Build User 
Date:   Mon Aug 5 18:29:19 2019 +0200

source sha:30d03b495f437e9b2edbb0f8ceebe3020ba7459c

source sha:30d03b495f437e9b2edbb0f8ceebe3020ba7459c

:04 04 4fd372475270d57fa931c5c9668dd36ff8955804
117fee423c7c8a9fc84540fd37094fa7f0562919 M  instdir

commit 30d03b495f437e9b2edbb0f8ceebe3020ba7459c
Author: Mike Kaganski 
Date:   Mon Aug 5 14:36:19 2019 +0300

tdf#126684: store "DialogUseCharAttr" in RES_PARATR_GRABBAG

... because RES_CHRATR_GRABBAG value may be later reset by initial
value read from char format, when it's present there.
OTOH, RES_PARATR_GRABBAG shouldn't be present in character format,
so it should be safe to pass the grabbag item there.

Regression after commit 074fc4a1499aac6eb67cd0b2dca00a51071cff0e.

Change-Id: Iebbee04929714d6a3fb72274a211699b2a80b3d2
Reviewed-on: https://gerrit.libreoffice.org/76981
Reviewed-by: Mike Kaganski 
Tested-by: Mike Kaganski 

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'private/EL-SHREIF/ui_logger' - uitest/ui_logger_dsl

[Ahmed ElShreif (via logerrit)]

 uitest/ui_logger_dsl/dsl_core.py |   88 +++
 1 file changed, 52 insertions(+), 36 deletions(-)

New commits:
commit 25fbad996379ca0b73a95268253828d73d2be6f9
Author: Ahmed ElShreif 
AuthorDate: Fri Aug 16 21:56:42 2019 -0500
Commit: Ahmed ElShreif 
CommitDate: Fri Aug 16 22:33:41 2019 -0500

Fix some Logger issues:

Ignore the logging part of the QuerySaveDialog while closing the app

Change-Id: I18fcc81fa54362dfaa574ec04125e66b37a5aad8

diff --git a/uitest/ui_logger_dsl/dsl_core.py b/uitest/ui_logger_dsl/dsl_core.py
index b8e0b9b7269c..088fcf4a0d64 100644
--- a/uitest/ui_logger_dsl/dsl_core.py
+++ b/uitest/ui_logger_dsl/dsl_core.py
@@ -33,6 +33,7 @@ class ul_Compiler:
 current_app=""
 parent_hierarchy_count=0
 last_parent=[]
+flag_for_QuerySaveDialog=False
 
 def __init__(self , input_address , output_address):
 self.ui_dsl_mm = metamodel_from_file('ui_logger_dsl_grammar.tx')
@@ -190,21 +191,27 @@ class ul_Compiler:
 def handle_Dialog(self, DialogCommand):
 
 if (DialogCommand.__class__.__name__ == "OpenModalDialog"):
-old_line = self.variables.pop()
 
-if (self.prev_command.__class__.__name__ == "UNOCommand"):
-key_word=self.prev_command.uno_command_name[-6:]
-else:
-key_word=old_line[-9:-3]
+if( DialogCommand.dialog_name != "QuerySaveDialog" ):
+# This part is just to ignore saving the Save dialog while 
closing the app
 
-if ( key_word == "Dialog"):
-old_line= double_tab + 
"self.ui_test.execute_dialog_through_command(\""+\
-self.prev_command.uno_command_name+"\")\n"
-self.variables.append(old_line)
-line = double_tab + DialogCommand.dialog_name + " = 
self.xUITest.getTopFocusWindow()\n"
-self.variables.append(line)
-self.last_parent.append(DialogCommand.dialog_name)
-self.parent_hierarchy_count=self.parent_hierarchy_count+1
+old_line = self.variables.pop()
+if (self.prev_command.__class__.__name__ == "UNOCommand"):
+key_word=self.prev_command.uno_command_name[-6:]
+else:
+key_word=old_line[-9:-3]
+
+if ( key_word == "Dialog"):
+old_line= double_tab + 
"self.ui_test.execute_dialog_through_command(\""+\
+self.prev_command.uno_command_name+"\")\n"
+self.variables.append(old_line)
+line = double_tab + DialogCommand.dialog_name + " = 
self.xUITest.getTopFocusWindow()\n"
+self.variables.append(line)
+self.last_parent.append(DialogCommand.dialog_name)
+self.parent_hierarchy_count=self.parent_hierarchy_count+1
+
+else:
+self.flag_for_QuerySaveDialog=True
 
 elif (DialogCommand.__class__.__name__ == "OpenModelessDialog"):
 old_line = self.variables.pop()
@@ -223,37 +230,46 @@ class ul_Compiler:
 self.parent_hierarchy_count=self.parent_hierarchy_count+1
 
 elif (DialogCommand.__class__.__name__ == "CloseDialog"):
-if (self.prev_command.__class__.__name__ == "ButtonUIObject"):
-old_line = self.variables.pop()
-line=""
-if(keyword.iskeyword( self.prev_command.ui_button )):
-line= double_tab + 
"self.ui_test.close_dialog_through_button(x"+\
-self.prev_command.ui_button+")\n"
-else:
-line= double_tab + 
"self.ui_test.close_dialog_through_button("+\
-self.prev_command.ui_button+")\n"
-self.variables.append(line)
-self.last_parent.pop()
-self.parent_hierarchy_count=self.parent_hierarchy_count-1
+
+if( not ( self.flag_for_QuerySaveDialog ) ):
+# This part is just to ignore saving the Save dialog while 
closing the app
+
+if (self.prev_command.__class__.__name__ == "ButtonUIObject"):
+old_line = self.variables.pop()
+line=""
+if(keyword.iskeyword( self.prev_command.ui_button )):
+line= double_tab + 
"self.ui_test.close_dialog_through_button(x"+\
+self.prev_command.ui_button+")\n"
+else:
+line= double_tab + 
"self.ui_test.close_dialog_through_button("+\
+self.prev_command.ui_button+")\n"
+self.variables.append(line)
+self.last_parent.pop()
+self.parent_hierarchy_count=self.parent_hierarchy_count-1
+else:
+self.flag_for_QuerySaveDialog=False
 
 self.prev_command=DialogCommand
 
 def handle_button(self, 

[Libreoffice-commits] online.git: wsd/ClientSession.cpp wsd/DocumentBroker.cpp

[Ashod Nakashian (via logerrit)]

 wsd/ClientSession.cpp  |   24 +++-
 wsd/DocumentBroker.cpp |1 -
 2 files changed, 15 insertions(+), 10 deletions(-)

New commits:
commit 6d94b35c35bd30e10963bc64bea9ca4e1e253a81
Author: Ashod Nakashian 
AuthorDate: Tue Aug 13 20:03:40 2019 -0400
Commit: Ashod Nakashian 
CommitDate: Sat Aug 17 04:44:51 2019 +0200

wsd: block save of read-only documents

WSD is responsible for checking permissions,
as we do with DisableCopy and DisablePrint,
but until now we allowed saving even on
read-only documents.

The reason, it seems, was that when we failed
to save a document due to disk space, we
set documents as read-only. So presumably
we still had to allow saving, so users
preserve their latest changes when the disk
has some free space. Meanwhile, we didn't
let users make further changes. At least
this seems to be a reasonable explanation.

Unfortunately this meant that we allowed
saving when the user had no permission,
or the document was loaded as read-only.

Now we no longer mark documents that fail
to save due to disk-space limitation as
read-only, and instead expect the client
to notify the user and (possibly) block
further edits. And read-only documents,
or users without write permission, are
no longer allowed to get saved.

This change makes sure that the ctrl+s
shortcut respects the read-only flag,
while we allow clients to disable
the default handler and decide what to
do (although now they cannot force saving
when the user has no permission, something
they could do previously).

Change-Id: I16c3b75fd3e54435d750948a25afd6f71c9f963b
Reviewed-on: https://gerrit.libreoffice.org/77594
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index 5dbcaa7d0..56f2a3443 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -499,16 +499,23 @@ bool ClientSession::_handleInput(const char *buffer, int 
length)
 }
 else if (tokens[0] == "save")
 {
-int dontTerminateEdit = 1;
-if (tokens.size() > 1)
-getTokenInteger(tokens[1], "dontTerminateEdit", dontTerminateEdit);
+if (isReadOnly())
+{
+LOG_WRN("The document is read-only, cannot save.");
+}
+else
+{
+int dontTerminateEdit = 1;
+if (tokens.size() > 1)
+getTokenInteger(tokens[1], "dontTerminateEdit", 
dontTerminateEdit);
 
-// Don't save unmodified docs by default, or when read-only.
-int dontSaveIfUnmodified = 1;
-if (!isReadOnly() && tokens.size() > 2)
-getTokenInteger(tokens[2], "dontSaveIfUnmodified", 
dontSaveIfUnmodified);
+// Don't save unmodified docs by default.
+int dontSaveIfUnmodified = 1;
+if (tokens.size() > 2)
+getTokenInteger(tokens[2], "dontSaveIfUnmodified", 
dontSaveIfUnmodified);
 
-docBroker->sendUnoSave(getId(), dontTerminateEdit != 0, 
dontSaveIfUnmodified != 0);
+docBroker->sendUnoSave(getId(), dontTerminateEdit != 0, 
dontSaveIfUnmodified != 0);
+}
 }
 else if (tokens[0] == "savetostorage")
 {
@@ -1003,7 +1010,6 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 #endif
 
 const auto& tokens = payload->tokens();
-
 if (tokens[0] == "unocommandresult:")
 {
 const std::string stringMsg(buffer, length);
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 5105e426d..026bdda08 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -975,7 +975,6 @@ bool DocumentBroker::saveToStorageInternal(const 
std::string& sessionId,
 // Make everyone readonly and tell everyone that storage is low on 
diskspace.
 for (const auto& sessionIt : _sessions)
 {
-sessionIt.second->setReadOnly();
 sessionIt.second->sendTextFrame("error: cmd=storage 
kind=savediskfull");
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: kit/ChildSession.cpp

[Ashod Nakashian (via logerrit)]

 kit/ChildSession.cpp |   15 +--
 1 file changed, 9 insertions(+), 6 deletions(-)

New commits:
commit 64c5ec5bbc5e12e92499fdd50f192eea468ea54a
Author: Ashod Nakashian 
AuthorDate: Sun Jan 20 16:44:28 2019 -0500
Commit: Ashod Nakashian 
CommitDate: Sat Aug 17 04:44:29 2019 +0200

wsd: don't warn incorrectly when selecting current part

Change-Id: I3c872469911b1f232e40cc110859402fc0814f3a
Reviewed-on: https://gerrit.libreoffice.org/69640
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/71104

diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index b044adeba..fadbca1ea 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -1956,14 +1956,17 @@ bool ChildSession::selectClientPart(const char* 
/*buffer*/, int /*length*/, cons
 
 getLOKitDocument()->setView(_viewId);
 
-if (getLOKitDocument()->getDocumentType() != LOK_DOCTYPE_TEXT && nPart != 
getLOKitDocument()->getPart())
+if (getLOKitDocument()->getDocumentType() != LOK_DOCTYPE_TEXT)
 {
-getLOKitDocument()->selectPart(nPart, nSelect);
+if (nPart != getLOKitDocument()->getPart())
+{
+getLOKitDocument()->selectPart(nPart, nSelect);
 
-// Notify the client of the selection update.
-const std::string status = 
LOKitHelper::documentStatus(getLOKitDocument()->get());
-if (!status.empty())
-return sendTextFrame("statusupdate: " + status);
+// Notify the client of the selection update.
+const std::string status = 
LOKitHelper::documentStatus(getLOKitDocument()->get());
+if (!status.empty())
+return sendTextFrame("statusupdate: " + status);
+}
 }
 else
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

[Ashod Nakashian (via logerrit)]

 loleaflet/src/control/Control.PartsPreview.js |8 
 loleaflet/src/control/Parts.js|1 -
 2 files changed, 8 insertions(+), 1 deletion(-)

New commits:
commit 22d03720a22bd1749fce0c57117c7a36d965d9c0
Author: Ashod Nakashian 
AuthorDate: Wed Nov 28 22:07:33 2018 -0500
Commit: Ashod Nakashian 
CommitDate: Sat Aug 17 04:43:00 2019 +0200

leaflet: select the current slide and update previews after reordering

Change-Id: Iec1c41b257744e99d8447518be0b38eb9a28d715
Reviewed-on: https://gerrit.libreoffice.org/69639
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/71103

diff --git a/loleaflet/src/control/Control.PartsPreview.js 
b/loleaflet/src/control/Control.PartsPreview.js
index 854fe21f0..b46d356c6 100644
--- a/loleaflet/src/control/Control.PartsPreview.js
+++ b/loleaflet/src/control/Control.PartsPreview.js
@@ -162,6 +162,7 @@ L.Control.PartsPreview = L.Control.extend({
console.log('shift');
} else {
this._map.setPart(partId);
+   this._map.selectPart(partId, 1, false); // And 
select.
}
}
},
@@ -343,6 +344,13 @@ L.Control.PartsPreview = L.Control.extend({
if (partId < 0)
partId = -1; // First item is -1.

this.partsPreview._map._socket.sendMessage('moveselectedclientparts position=' 
+ partId);
+   // Update previews, after a second, since we only get 
the dragged one invalidated.
+   var that = this.partsPreview;
+   setTimeout(function () {
+   for (var i = 0; i < that._previewTiles.length; 
++i) {
+   that._map.getPreview(i, i, 180, 180, 
{autoUpdate: that.options.autoUpdate, broadcast: true});
+   }
+   }, 1000);
}
 
this.classList.remove('preview-img-dropsite');
diff --git a/loleaflet/src/control/Parts.js b/loleaflet/src/control/Parts.js
index 95e5bc2a0..c428408e7 100644
--- a/loleaflet/src/control/Parts.js
+++ b/loleaflet/src/control/Parts.js
@@ -63,7 +63,6 @@ L.Map.include({
// part is the part index/id
// how is 0 to deselect, 1 to select, and 2 to toggle selection
selectPart: function (part, how, external) {
-   //TODO: Update/track selected parts(?).
var docLayer = this._docLayer;
var index = docLayer._selectedParts.indexOf(part);
if (index >= 0 && how != 1) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/css loleaflet/src

[Ashod Nakashian (via logerrit)]

 loleaflet/css/partsPreviewControl.css |2 +-
 loleaflet/src/control/Control.PartsPreview.js |3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 11335b0e206aa6193f996062b203eda1d0e74bf8
Author: Ashod Nakashian 
AuthorDate: Fri Nov 23 01:50:30 2018 -0500
Commit: Ashod Nakashian 
CommitDate: Sat Aug 17 04:42:25 2019 +0200

leaflet: make the slide drop sites more visible

Change-Id: Idc8e2ee33fc61449300180e8200f5aa75b82f07e
Reviewed-on: https://gerrit.libreoffice.org/69638
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/71102

diff --git a/loleaflet/css/partsPreviewControl.css 
b/loleaflet/css/partsPreviewControl.css
index 39bba0121..e5afa218a 100644
--- a/loleaflet/css/partsPreviewControl.css
+++ b/loleaflet/css/partsPreviewControl.css
@@ -41,5 +41,5 @@
 
 /* Highlight where a slide can be dropped when reordering by drag-and-drop. */
 .preview-img-dropsite {
-border-bottom: 2px solid red;
+border-bottom: 3px solid red;
 }
diff --git a/loleaflet/src/control/Control.PartsPreview.js 
b/loleaflet/src/control/Control.PartsPreview.js
index 35c5e57cc..854fe21f0 100644
--- a/loleaflet/src/control/Control.PartsPreview.js
+++ b/loleaflet/src/control/Control.PartsPreview.js
@@ -67,7 +67,8 @@ L.Control.PartsPreview = L.Control.extend({
var frame = L.DomUtil.create('div', 
'preview-frame', this._scrollContainer);
this._addDnDHandlers(frame);
frame.setAttribute('draggable', false);
-   L.DomUtil.setStyle(frame, 'height', '12px');
+   L.DomUtil.setStyle(frame, 'height', '20px');
+   L.DomUtil.setStyle(frame, 'margin', '0em');
 
// Create the preview parts
for (var i = 0; i < parts; i++) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

[Ashod Nakashian (via logerrit)]

 loleaflet/src/control/Control.PartsPreview.js |   13 +++--
 1 file changed, 11 insertions(+), 2 deletions(-)

New commits:
commit 001dcac278ebbff58b4d8437e17ce81c4e824cbe
Author: Ashod Nakashian 
AuthorDate: Fri Nov 23 01:36:17 2018 -0500
Commit: Ashod Nakashian 
CommitDate: Sat Aug 17 04:41:59 2019 +0200

leaflet: support reordering slides to first position

Change-Id: I23fba5d7e10d861ec482974cf355c9fb1ae13a64
Reviewed-on: https://gerrit.libreoffice.org/69637
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/71101

diff --git a/loleaflet/src/control/Control.PartsPreview.js 
b/loleaflet/src/control/Control.PartsPreview.js
index 25ffd099d..35c5e57cc 100644
--- a/loleaflet/src/control/Control.PartsPreview.js
+++ b/loleaflet/src/control/Control.PartsPreview.js
@@ -63,6 +63,13 @@ L.Control.PartsPreview = L.Control.extend({
});
this._scrollContainer = $('#slide-sorter 
.mCSB_container').get(0);
 
+   // Add a special frame just as a drop-site for 
reordering.
+   var frame = L.DomUtil.create('div', 
'preview-frame', this._scrollContainer);
+   this._addDnDHandlers(frame);
+   frame.setAttribute('draggable', false);
+   L.DomUtil.setStyle(frame, 'height', '12px');
+
+   // Create the preview parts
for (var i = 0; i < parts; i++) {

this._previewTiles.push(this._createPreview(i, e.partNames[i], bottomBound));
}
@@ -144,7 +151,7 @@ L.Control.PartsPreview = L.Control.extend({
_setPart: function (e) {
var part = $('#slide-sorter .mCSB_container 
.preview-frame').index(e.target.parentNode);
if (part !== null) {
-   var partId = parseInt(part);
+   var partId = parseInt(part) - 1; // The first part is 
just a drop-site for reordering.
 
if (e.ctrlKey) {
this._map.selectPart(partId, 2, false); // 
Toggle selection on ctrl+click.
@@ -331,7 +338,9 @@ L.Control.PartsPreview = L.Control.extend({
 
var part = $('#slide-sorter .mCSB_container 
.preview-frame').index(e.target.parentNode);
if (part !== null) {
-   var partId = parseInt(part);
+   var partId = parseInt(part) - 1; // First frame is a 
drop-site for reordering.
+   if (partId < 0)
+   partId = -1; // First item is -1.

this.partsPreview._map._socket.sendMessage('moveselectedclientparts position=' 
+ partId);
}
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: kit/ChildSession.cpp kit/ChildSession.hpp kit/Kit.cpp loleaflet/css loleaflet/src test/WhiteBoxTests.cpp

[Ashod Nakashian (via logerrit)]

 kit/ChildSession.cpp  |9 +++--
 kit/ChildSession.hpp  |3 +++
 kit/Kit.cpp   |   10 --
 loleaflet/css/partsPreviewControl.css |   13 +++--
 loleaflet/src/control/Control.PartsPreview.js |   11 ---
 loleaflet/src/control/Parts.js|   23 +--
 loleaflet/src/core/Socket.js  |8 
 loleaflet/src/layer/tile/ImpressTileLayer.js  |2 ++
 test/WhiteBoxTests.cpp|5 +
 9 files changed, 65 insertions(+), 19 deletions(-)

New commits:
commit d45ecd586cc4490d219bf494d9de7b9aedcd2ed5
Author: Ashod Nakashian 
AuthorDate: Mon Sep 17 06:31:36 2018 -0400
Commit: Ashod Nakashian 
CommitDate: Sat Aug 17 04:41:36 2019 +0200

wsd: leaflet: track multi-selection

Change-Id: I17c092e950fb4d7a0cb4129c537d60a8e5edd06a
Reviewed-on: https://gerrit.libreoffice.org/69636
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/71100

diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index be169fc6f..b044adeba 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -1959,6 +1959,11 @@ bool ChildSession::selectClientPart(const char* 
/*buffer*/, int /*length*/, cons
 if (getLOKitDocument()->getDocumentType() != LOK_DOCTYPE_TEXT && nPart != 
getLOKitDocument()->getPart())
 {
 getLOKitDocument()->selectPart(nPart, nSelect);
+
+// Notify the client of the selection update.
+const std::string status = 
LOKitHelper::documentStatus(getLOKitDocument()->get());
+if (!status.empty())
+return sendTextFrame("statusupdate: " + status);
 }
 else
 {
@@ -1984,10 +1989,10 @@ bool ChildSession::moveSelectedClientParts(const char* 
/*buffer*/, int /*length*
 {
 getLOKitDocument()->moveSelectedParts(nPosition, false); // Move, 
don't duplicate.
 
-// Get the status to recreate the previews and correctly order parts.
+// Get the status to notify clients of the reordering and selection 
change.
 const std::string status = 
LOKitHelper::documentStatus(getLOKitDocument()->get());
 if (!status.empty())
-return sendTextFrame("statusupdate: " + status);
+return _docManager->notifyAll("statusupdate: " + status);
 }
 else
 {
diff --git a/kit/ChildSession.hpp b/kit/ChildSession.hpp
index 1d2cd3fdd..4880bc4dc 100644
--- a/kit/ChildSession.hpp
+++ b/kit/ChildSession.hpp
@@ -59,6 +59,9 @@ public:
 /// Access to the document instance.
 virtual std::shared_ptr getLOKitDocument() = 0;
 
+/// Send msg to all active sessions.
+virtual bool notifyAll(const std::string& msg) = 0;
+
 /// Send updated view info to all active sessions.
 virtual void notifyViewInfo() = 0;
 virtual void updateEditorSpeeds(int id, int speed) = 0;
diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 75d208e64..40fe64ff9 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -1594,6 +1594,13 @@ private:
 return _editorId;
 }
 
+/// Notify all views with the given message
+bool notifyAll(const std::string& msg) override
+{
+// Broadcast updated viewinfo to all clients.
+return sendTextFrame("client-all " + msg);
+}
+
 /// Notify all views of viewId and their associated usernames
 void notifyViewInfo() override
 {
@@ -1641,10 +1648,9 @@ private:
 
 oss.seekp(-1, std::ios_base::cur); // Remove last comma.
 oss << "]";
-const std::string msg = oss.str();
 
 // Broadcast updated viewinfo to all clients.
-sendTextFrame("client-all " + msg);
+notifyAll(oss.str());
 }
 
 void updateEditorSpeeds(int id, int speed) override
diff --git a/loleaflet/css/partsPreviewControl.css 
b/loleaflet/css/partsPreviewControl.css
index 66e47c9bb..39bba0121 100644
--- a/loleaflet/css/partsPreviewControl.css
+++ b/loleaflet/css/partsPreviewControl.css
@@ -27,10 +27,19 @@
border: 2px solid #dfdfdf;
}
 
-.preview-img-selected {
-   border-color: #00;
+/* The current part the user is on. */
+.preview-img-currentpart {
+border-color: #00;
+border-style: solid;
 }
 
+/* One of (potentially many) selected parts, but not the current. */
+.preview-img-selectedpart {
+border-color: #00;
+border-style: dotted;
+}
+
+/* Highlight where a slide can be dropped when reordering by drag-and-drop. */
 .preview-img-dropsite {
 border-bottom: 2px solid red;
 }
diff --git a/loleaflet/src/control/Control.PartsPreview.js 
b/loleaflet/src/control/Control.PartsPreview.js
index 8f0629957..25ffd099d 100644
--- a/loleaflet/src/control/Control.PartsPreview.js
+++ b/loleaflet/src/control/Control.PartsPreview.js
@@ -25,6 +25,7 @@ L.Control.PartsPreview = L.Control.extend({
_updateDisabled: function (e) {
var 

[Libreoffice-commits] online.git: kit/ChildSession.cpp kit/ChildSession.hpp loleaflet/css loleaflet/src wsd/ClientSession.cpp wsd/protocol.txt

[Ashod Nakashian (via logerrit)]

 kit/ChildSession.cpp  |   33 ++
 kit/ChildSession.hpp  |1 
 loleaflet/css/partsPreviewControl.css |6 ++
 loleaflet/src/control/Control.PartsPreview.js |   61 ++
 wsd/ClientSession.cpp |   18 +++
 wsd/protocol.txt  |4 +
 6 files changed, 122 insertions(+), 1 deletion(-)

New commits:
commit 2eab5cea763d037ed7d11f0ba88b8299edc592ff
Author: Ashod Nakashian 
AuthorDate: Mon Sep 17 07:17:31 2018 -0400
Commit: Ashod Nakashian 
CommitDate: Sat Aug 17 04:33:04 2019 +0200

wsd: leaflet: support reordering of slides via drag-and-drop

Change-Id: I1b471ba07dd0a1016a0759de729171ae968262cb
Reviewed-on: https://gerrit.libreoffice.org/69635
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/71099

diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index fc41597e5..be169fc6f 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -232,6 +232,10 @@ bool ChildSession::_handleInput(const char *buffer, int 
length)
 {
 return selectClientPart(buffer, length, tokens);
 }
+else if (tokens[0] == "moveselectedclientparts")
+{
+return moveSelectedClientParts(buffer, length, tokens);
+}
 else if (tokens[0] == "setpage")
 {
 return setPage(buffer, length, tokens);
@@ -1964,6 +1968,35 @@ bool ChildSession::selectClientPart(const char* 
/*buffer*/, int /*length*/, cons
 return true;
 }
 
+bool ChildSession::moveSelectedClientParts(const char* /*buffer*/, int 
/*length*/, const std::vector& tokens)
+{
+int nPosition;
+if (tokens.size() < 2 ||
+!getTokenInteger(tokens[1], "position", nPosition))
+{
+sendTextFrame("error: cmd=moveselectedclientparts kind=invalid");
+return false;
+}
+
+getLOKitDocument()->setView(_viewId);
+
+if (getLOKitDocument()->getDocumentType() != LOK_DOCTYPE_TEXT)
+{
+getLOKitDocument()->moveSelectedParts(nPosition, false); // Move, 
don't duplicate.
+
+// Get the status to recreate the previews and correctly order parts.
+const std::string status = 
LOKitHelper::documentStatus(getLOKitDocument()->get());
+if (!status.empty())
+return sendTextFrame("statusupdate: " + status);
+}
+else
+{
+LOG_WRN("ChildSession::moveSelectedClientParts[" << getName() << "]: 
error moving parts on text documents.");
+}
+
+return true; // Non-fatal to fail.
+}
+
 bool ChildSession::setPage(const char* /*buffer*/, int /*length*/, const 
std::vector& tokens)
 {
 int page;
diff --git a/kit/ChildSession.hpp b/kit/ChildSession.hpp
index cc5ff6a15..1d2cd3fdd 100644
--- a/kit/ChildSession.hpp
+++ b/kit/ChildSession.hpp
@@ -269,6 +269,7 @@ private:
 bool saveAs(const char* buffer, int length, const 
std::vector& tokens);
 bool setClientPart(const char* buffer, int length, const 
std::vector& tokens);
 bool selectClientPart(const char* buffer, int length, const 
std::vector& tokens);
+bool moveSelectedClientParts(const char* buffer, int length, const 
std::vector& tokens);
 bool setPage(const char* buffer, int length, const 
std::vector& tokens);
 bool sendWindowCommand(const char* buffer, int length, const 
std::vector& tokens);
 bool signDocumentContent(const char* buffer, int length, const 
std::vector& tokens);
diff --git a/loleaflet/css/partsPreviewControl.css 
b/loleaflet/css/partsPreviewControl.css
index 438b137d3..66e47c9bb 100644
--- a/loleaflet/css/partsPreviewControl.css
+++ b/loleaflet/css/partsPreviewControl.css
@@ -20,7 +20,7 @@
 
 .preview-img {
/* In draw docs, the width of previews are small, but we want a min of 
180px to align it with document's left edge */
-min-width: 180px;
+   min-width: 180px;
vertical-align: middle;
max-width: 184px;
cursor: pointer;
@@ -30,3 +30,7 @@
 .preview-img-selected {
border-color: #00;
 }
+
+.preview-img-dropsite {
+border-bottom: 2px solid red;
+}
diff --git a/loleaflet/src/control/Control.PartsPreview.js 
b/loleaflet/src/control/Control.PartsPreview.js
index 3ebe4baaa..8f0629957 100644
--- a/loleaflet/src/control/Control.PartsPreview.js
+++ b/loleaflet/src/control/Control.PartsPreview.js
@@ -85,6 +85,7 @@ L.Control.PartsPreview = L.Control.extend({
 
_createPreview: function (i, hashCode, bottomBound) {
var frame = L.DomUtil.create('div', 'preview-frame', 
this._scrollContainer);
+   this._addDnDHandlers(frame);
L.DomUtil.create('span', 'preview-helper', frame);
 
var imgClassName = 'preview-img';
@@ -209,6 +210,7 @@ L.Control.PartsPreview = L.Control.extend({
for (it = 0; it < parts; it++) {
if (this._previewTiles[it].hash !== 

[Libreoffice-commits] online.git: loleaflet/src wsd/ClientSession.cpp wsd/protocol.txt

[Ashod Nakashian (via logerrit)]

 loleaflet/src/layer/tile/TileLayer.js |2 +-
 wsd/ClientSession.cpp |4 +++-
 wsd/protocol.txt  |7 ++-
 3 files changed, 10 insertions(+), 3 deletions(-)

New commits:
commit 8e118889cbabc279d7cf6746576330816f0e562c
Author: Ashod Nakashian 
AuthorDate: Mon Sep 17 06:45:57 2018 -0400
Commit: Ashod Nakashian 
CommitDate: Sat Aug 17 04:32:09 2019 +0200

wsd: leaflet: support statusupdate: messages to sync clients

This new message is identical to status: except it doesn't
imply (re)connection. It's unfortunate that status: is
assumed to be sent only when establishing connection and
loading a document, so we need a different notification
that can be sent at any time, without triggering
initalization logic on the client-side.

Change-Id: I9c804119aec292b873aeed132cc32f13c030d845
Reviewed-on: https://gerrit.libreoffice.org/69634
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/71098

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 87cf380f4..63a47d4bc 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -452,7 +452,7 @@ L.TileLayer = L.GridLayer.extend({
else if (textMsg.startsWith('statechanged:')) {
this._onStateChangedMsg(textMsg);
}
-   else if (textMsg.startsWith('status:')) {
+   else if (textMsg.startsWith('status:') || 
textMsg.startsWith('statusupdate:')) {
this._onStatusMsg(textMsg);
}
else if (textMsg.startsWith('textselection:')) {
diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index e12f57a46..f10f08724 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -404,6 +404,7 @@ bool ClientSession::_handleInput(const char *buffer, int 
length)
  tokens[0] != "selectclientpart" &&
  tokens[0] != "setpage" &&
  tokens[0] != "status" &&
+ tokens[0] != "statusupdate" &&
  tokens[0] != "tile" &&
  tokens[0] != "tilecombine" &&
  tokens[0] != "uno" &&
@@ -419,6 +420,7 @@ bool ClientSession::_handleInput(const char *buffer, int 
length)
  tokens[0] != "removesession" &&
  tokens[0] != "renamefile")
 {
+LOG_ERR("Session [" << getId() << "] got unknown command [" << 
tokens[0] << "].");
 sendTextFrame("error: cmd=" + tokens[0] + " kind=unknown");
 return false;
 }
@@ -481,7 +483,7 @@ bool ClientSession::_handleInput(const char *buffer, int 
length)
 {
 return sendFontRendering(buffer, length, tokens, docBroker);
 }
-else if (tokens[0] == "status")
+else if (tokens[0] == "status" || tokens[0] == "statusupdate")
 {
 assert(firstLine.size() == static_cast(length));
 return forwardToChild(firstLine, docBroker);
diff --git a/wsd/protocol.txt b/wsd/protocol.txt
index 0df5bdb9c..a1bdb39cb 100644
--- a/wsd/protocol.txt
+++ b/wsd/protocol.txt
@@ -373,11 +373,16 @@ saveas: url= name=
  is the resulting name (without path) that was created on the wopi
 host. It can differ from what was requested in case the file already 
existed.
 
-status: type= parts= current= 
width= height= viewid= [partNames]
+status: type= parts= current= 
width= height= viewid= hiddenparts= 
selectedparts= [partNames]
 
  is 'text, 'spreadsheet', 'presentation', 'drawing' or 'other. 
Others are numbers.
 if the document has multiple parts and those have names, part names follow 
separated by '\n'
 
+statusupdate: type= parts= 
current= width= height= viewid= 
hiddenparts= selectedparts= [partNames]
+
+Same as status: but issued whenever the document parts have updated 
significantly.
+status: implies document loading. statusupdate: is just an update.
+
 styles: {"styleFamily": ["styles in family"], etc. }
 
 statechanged: =
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: kit/KitHelper.hpp loleaflet/src

[Ashod Nakashian (via logerrit)]

 kit/KitHelper.hpp  |   51 -
 loleaflet/src/control/Parts.js |1 
 loleaflet/src/core/Socket.js   |7 +
 3 files changed, 38 insertions(+), 21 deletions(-)

New commits:
commit 7d03d68e1ac9a483a48bc01ad00aa1af79561736
Author: Ashod Nakashian 
AuthorDate: Sun Sep 16 17:32:56 2018 -0400
Commit: Ashod Nakashian 
CommitDate: Sat Aug 17 04:30:42 2019 +0200

wsd: leaflet: status now includes selected parts

Change-Id: I3eeb2fbc52d28047dd0ab7e4318fa44d5c5c0a98
Reviewed-on: https://gerrit.libreoffice.org/69632
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/71096

diff --git a/kit/KitHelper.hpp b/kit/KitHelper.hpp
index b0962276a..0c449262c 100644
--- a/kit/KitHelper.hpp
+++ b/kit/KitHelper.hpp
@@ -64,32 +64,41 @@ namespace LOKitHelper
 
 if (type == LOK_DOCTYPE_SPREADSHEET || type == 
LOK_DOCTYPE_PRESENTATION)
 {
-if (type == LOK_DOCTYPE_SPREADSHEET)
+std::ostringstream hposs;
+std::ostringstream sposs;
+for (int i = 0; i < parts; ++i)
 {
-std::ostringstream hposs;
-for (int i = 0; i < parts; ++i)
+ptrValue = loKitDocument->pClass->getPartInfo(loKitDocument, 
i);
+const std::string partinfo(ptrValue);
+std::free(ptrValue);
+for (const auto& prop : Util::JsonToMap(partinfo))
 {
-
-ptrValue = 
loKitDocument->pClass->getPartInfo(loKitDocument, i);
-std::string partinfo(ptrValue);
-std::free(ptrValue);
-const auto aPartInfo = Util::JsonToMap(partinfo);
-for (const auto& prop: aPartInfo)
+const std::string& name = prop.first;
+if (name == "visible")
 {
-const std::string& name = prop.first;
-if (name == "visible")
-{
-if (prop.second == "0")
-hposs << i << ",";
-}
+if (prop.second == "0")
+hposs << i << ',';
+}
+else if (name == "selected")
+{
+if (prop.second == "1")
+sposs << i << ',';
 }
 }
-std::string hiddenparts = hposs.str();
-if (!hiddenparts.empty())
-{
-hiddenparts.pop_back();
-oss << " hiddenparts=" << hiddenparts;
-}
+}
+
+std::string hiddenparts = hposs.str();
+if (!hiddenparts.empty())
+{
+hiddenparts.pop_back(); // Remove last ','
+oss << " hiddenparts=" << hiddenparts;
+}
+
+std::string selectedparts = sposs.str();
+if (!selectedparts.empty())
+{
+selectedparts.pop_back(); // Remove last ','
+oss << " selectedparts=" << selectedparts;
 }
 
 for (int i = 0; i < parts; ++i)
diff --git a/loleaflet/src/control/Parts.js b/loleaflet/src/control/Parts.js
index 49a8de3ec..24e57ba55 100644
--- a/loleaflet/src/control/Parts.js
+++ b/loleaflet/src/control/Parts.js
@@ -57,6 +57,7 @@ L.Map.include({
// part is the part index/id
// how is 0 to deselect, 1 to select, and 2 to toggle selection
selectPart: function (part, how, external) {
+   //TODO: Update/track selected parts.
var docLayer = this._docLayer;
if (typeof (part) === 'number' && part >= 0 && part < 
docLayer._parts) {
var selectedPart = part;
diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js
index e676b724a..5488697c9 100644
--- a/loleaflet/src/core/Socket.js
+++ b/loleaflet/src/core/Socket.js
@@ -976,6 +976,13 @@ L.Socket = L.Class.extend({

command.hiddenparts.push(parseInt(item));
});
}
+   else if (tokens[i].startsWith('selectedparts=')) {
+   var selectedparts = 
tokens[i].substring(14).split(',');
+   command.selectedparts = [];
+   selectedparts.forEach(function (item) {
+   
command.selectedparts.push(parseInt(item));
+   });
+   }
}
if (command.tileWidth && command.tileHeight && 
this._map._docLayer) {
var defaultZoom = this._map.options.zoom;

[Libreoffice-commits] online.git: kit/ChildSession.cpp kit/ChildSession.hpp loleaflet/src wsd/ClientSession.cpp wsd/protocol.txt

[Ashod Nakashian (via logerrit)]

 kit/ChildSession.cpp  |   30 ++
 kit/ChildSession.hpp  |1 
 loleaflet/src/control/Control.PartsPreview.js |   12 +-
 loleaflet/src/control/Parts.js|   25 -
 wsd/ClientSession.cpp |   20 +
 wsd/protocol.txt  |9 +++
 6 files changed, 95 insertions(+), 2 deletions(-)

New commits:
commit eaed3615bb08b50a27592346e6e18aa8c438ff0f
Author: Ashod Nakashian 
AuthorDate: Tue Sep 11 19:30:55 2018 -0400
Commit: Ashod Nakashian 
CommitDate: Sat Aug 17 04:30:05 2019 +0200

wsd: loleaflet: select multiple parts

Primarily support for selecting multiple slides
to edit their properties together.

Change-Id: I96c7ec048668494b5b769677db6874df91cbb42d
Reviewed-on: https://gerrit.libreoffice.org/69631
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/71095

diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index c3dd0a3ae..fc41597e5 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -228,6 +228,10 @@ bool ChildSession::_handleInput(const char *buffer, int 
length)
 {
 return setClientPart(buffer, length, tokens);
 }
+else if (tokens[0] == "selectclientpart")
+{
+return selectClientPart(buffer, length, tokens);
+}
 else if (tokens[0] == "setpage")
 {
 return setPage(buffer, length, tokens);
@@ -1934,6 +1938,32 @@ bool ChildSession::setClientPart(const char* /*buffer*/, 
int /*length*/, const s
 return true;
 }
 
+bool ChildSession::selectClientPart(const char* /*buffer*/, int /*length*/, 
const std::vector& tokens)
+{
+int nPart;
+int nSelect;
+if (tokens.size() < 3 ||
+!getTokenInteger(tokens[1], "part", nPart) ||
+!getTokenInteger(tokens[2], "how", nSelect))
+{
+sendTextFrame("error: cmd=selectclientpart kind=invalid");
+return false;
+}
+
+getLOKitDocument()->setView(_viewId);
+
+if (getLOKitDocument()->getDocumentType() != LOK_DOCTYPE_TEXT && nPart != 
getLOKitDocument()->getPart())
+{
+getLOKitDocument()->selectPart(nPart, nSelect);
+}
+else
+{
+LOG_WRN("ChildSession::selectClientPart[" << getName() << "]: error 
selecting part on text documents.");
+}
+
+return true;
+}
+
 bool ChildSession::setPage(const char* /*buffer*/, int /*length*/, const 
std::vector& tokens)
 {
 int page;
diff --git a/kit/ChildSession.hpp b/kit/ChildSession.hpp
index 3a2f6b3cf..cc5ff6a15 100644
--- a/kit/ChildSession.hpp
+++ b/kit/ChildSession.hpp
@@ -268,6 +268,7 @@ private:
 bool resetSelection(const char* buffer, int length, const 
std::vector& tokens);
 bool saveAs(const char* buffer, int length, const 
std::vector& tokens);
 bool setClientPart(const char* buffer, int length, const 
std::vector& tokens);
+bool selectClientPart(const char* buffer, int length, const 
std::vector& tokens);
 bool setPage(const char* buffer, int length, const 
std::vector& tokens);
 bool sendWindowCommand(const char* buffer, int length, const 
std::vector& tokens);
 bool signDocumentContent(const char* buffer, int length, const 
std::vector& tokens);
diff --git a/loleaflet/src/control/Control.PartsPreview.js 
b/loleaflet/src/control/Control.PartsPreview.js
index 82aa8af45..3ebe4baaa 100644
--- a/loleaflet/src/control/Control.PartsPreview.js
+++ b/loleaflet/src/control/Control.PartsPreview.js
@@ -138,7 +138,17 @@ L.Control.PartsPreview = L.Control.extend({
_setPart: function (e) {
var part = $('#slide-sorter .mCSB_container 
.preview-frame').index(e.target.parentNode);
if (part !== null) {
-   this._map.setPart(parseInt(part));
+   var partId = parseInt(part);
+
+   if (e.ctrlKey) {
+   this._map.selectPart(partId, 2, false); // 
Toggle selection on ctrl+click.
+   } else if (e.altKey) {
+   console.log('alt');
+   } else if (e.shiftKey) {
+   console.log('shift');
+   } else {
+   this._map.setPart(partId);
+   }
}
},
 
diff --git a/loleaflet/src/control/Parts.js b/loleaflet/src/control/Parts.js
index 1b309146c..49a8de3ec 100644
--- a/loleaflet/src/control/Parts.js
+++ b/loleaflet/src/control/Parts.js
@@ -1,6 +1,6 @@
 /* -*- js-indent-level: 8 -*- */
 /*
- * Document parts switching handler
+ * Document parts switching and selecting handler
  */
 L.Map.include({
setPart: function (part, external, calledFromSetPartHandler) {
@@ -54,6 +54,29 @@ L.Map.include({
}
},
 
+   // part is the part index/id
+   // how is 0 to 

[Libreoffice-commits] online.git: common/Util.cpp

[Ashod Nakashian (via logerrit)]

 common/Util.cpp |9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

New commits:
commit f1aa98af75d75eb0a3ad43fdd1d2e2d0732bac56
Author: Ashod Nakashian 
AuthorDate: Sun Apr 14 14:14:12 2019 -0400
Commit: Ashod Nakashian 
CommitDate: Sat Aug 17 04:28:07 2019 +0200

wsd: Use unordered map for anonymization

And simplify the trace-logging enablement check.

Change-Id: I4f5c9e08912b8dbc708b191b80032660ce4e1ba0
Reviewed-on: https://gerrit.libreoffice.org/70742
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/71093

diff --git a/common/Util.cpp b/common/Util.cpp
index 774b522db..9cba4a24c 100644
--- a/common/Util.cpp
+++ b/common/Util.cpp
@@ -36,6 +36,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -683,7 +684,7 @@ namespace Util
 return std::make_tuple(base, filename, ext, params);
 }
 
-static std::map AnonymizedStrings;
+static std::unordered_map AnonymizedStrings;
 static std::atomic AnonymizationCounter(0);
 static std::mutex AnonymizedMutex;
 
@@ -692,8 +693,7 @@ namespace Util
 if (plain.empty() || anonymized.empty())
 return;
 
-auto  = Log::logger();
-if (log.trace() && plain != anonymized)
+if (Log::traceEnabled() && plain != anonymized)
 LOG_TRC("Anonymizing [" << plain << "] -> [" << anonymized << 
"].");
 
 std::unique_lock lock(AnonymizedMutex);
@@ -709,8 +709,7 @@ namespace Util
 const auto it = AnonymizedStrings.find(text);
 if (it != AnonymizedStrings.end())
 {
-auto  = Log::logger();
-if (log.trace() && text != it->second)
+if (Log::traceEnabled() && text != it->second)
 LOG_TRC("Found anonymized [" << text << "] -> [" << 
it->second << "].");
 return it->second;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: tools/Config.cpp

[Ashod Nakashian (via logerrit)]

 tools/Config.cpp |   30 ++
 1 file changed, 30 insertions(+)

New commits:
commit 159e6d0f7288cb44b81ab72c9f3c99dfb69f4f4c
Author: Ashod Nakashian 
AuthorDate: Mon Apr 1 00:13:03 2019 -0400
Commit: Ashod Nakashian 
CommitDate: Sat Aug 17 04:28:49 2019 +0200

looltool: support anonymizing strings

The user is able to override the salt,
or use the one from the config file.

Change-Id: Ida634374549fb490ec2437f557d46c44d4760c56
Reviewed-on: https://gerrit.libreoffice.org/70036
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/71094

diff --git a/tools/Config.cpp b/tools/Config.cpp
index 3bffb0ddc..2cf45ac3f 100644
--- a/tools/Config.cpp
+++ b/tools/Config.cpp
@@ -74,6 +74,8 @@ public:
 static std::string ConfigFile;
 static std::string SupportKeyString;
 static bool SupportKeyStringProvided;
+static std::uint64_t AnonymizationSalt;
+static bool AnonymizationSaltProvided;
 
 protected:
 void defineOptions(OptionSet&) override;
@@ -91,6 +93,8 @@ std::string Config::ConfigFile =
 
 std::string Config::SupportKeyString;
 bool Config::SupportKeyStringProvided = false;
+std::uint64_t Config::AnonymizationSalt = 0;
+bool Config::AnonymizationSaltProvided = false;
 
 void Config::displayHelp()
 {
@@ -107,6 +111,7 @@ void Config::displayHelp()
 // Command list
 std::cout << std::endl
   << "Commands: " << std::endl
+  << "anonymize [string-1]...[string-n]" << std::endl
   << "set-admin-password" << std::endl
 #if ENABLE_SUPPORT_KEY
   << "set-support-key" << std::endl
@@ -146,6 +151,11 @@ void Config::defineOptions(OptionSet& optionSet)
 .repeatable(false)
 .argument("key"));
 #endif
+
+optionSet.addOption(Option("anonymization-salt", "", "Anonymize strings 
with the given 64-bit salt instead of the one in the config file.")
+.required(false)
+.repeatable(false)
+.argument("salt"));
 }
 
 void Config::handleOption(const std::string& optionName, const std::string& 
optionValue)
@@ -195,6 +205,12 @@ void Config::handleOption(const std::string& optionName, 
const std::string& opti
 SupportKeyString = optionValue;
 SupportKeyStringProvided = true;
 }
+else if (optionName == "anonymization-salt")
+{
+AnonymizationSalt = std::stoull(optionValue);
+AnonymizationSaltProvided = true;
+std::cout << "Anonymization Salt: [" << AnonymizationSalt << "]." << 
std::endl;
+}
 }
 
 int Config::main(const std::vector& args)
@@ -354,6 +370,20 @@ int Config::main(const std::vector& args)
 if (retval != 0)
 std::cerr << "Error when executing command." << std::endl;
 }
+else if (args[0] == "anonymize")
+{
+if (!AnonymizationSaltProvided)
+{
+const std::string val = 
_loolConfig.getString("logging.anonymize.anonymization_salt");
+AnonymizationSalt = std::stoull(val);
+std::cout << "Anonymization Salt: [" << AnonymizationSalt << "]." 
<< std::endl;
+}
+
+for (std::size_t i = 1; i < args.size(); ++i)
+{
+std::cout << "[" << args[i] << "]: " << 
Util::anonymizeUrl(args[i], AnonymizationSalt) << std::endl;
+}
+}
 else
 {
 std::cerr << "No such command, \"" << args[0]  << "\"" << std::endl;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: net/WebSocketHandler.hpp

[Ashod Nakashian (via logerrit)]

 net/WebSocketHandler.hpp |   14 +-
 1 file changed, 9 insertions(+), 5 deletions(-)

New commits:
commit fca12fc1ab45c4c215ffd05814a34bb8b9855c8e
Author: Ashod Nakashian 
AuthorDate: Sun Mar 31 23:30:05 2019 -0400
Commit: Ashod Nakashian 
CommitDate: Sat Aug 17 04:27:26 2019 +0200

wsd: formatting

Change-Id: I07b91c494fe89395ebe1e91506baef46dc03aca8
Reviewed-on: https://gerrit.libreoffice.org/70035
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/71092

diff --git a/net/WebSocketHandler.hpp b/net/WebSocketHandler.hpp
index 30381a7ed..f37d459a2 100644
--- a/net/WebSocketHandler.hpp
+++ b/net/WebSocketHandler.hpp
@@ -227,7 +227,8 @@ public:
 
 if (payloadLen + headerLen > len)
 { // partial read wait for more data.
-LOG_TRC("#" << socket->getFD() << ": Still incomplete WebSocket 
frame, have " << len << " bytes, frame is " << payloadLen + headerLen << " 
bytes");
+LOG_TRC("#" << socket->getFD() << ": Still incomplete WebSocket 
frame, have " << len
+<< " bytes, frame is " << payloadLen + headerLen << " 
bytes");
 return false;
 }
 
@@ -238,7 +239,8 @@ public:
 return true;
 }
 
-LOG_TRC("#" << socket->getFD() << ": Incoming WebSocket data of " << 
len << " bytes: " << Util::stringifyHexLine(socket->getInBuffer(), 0, 
std::min((size_t)32, len)));
+LOG_TRC("#" << socket->getFD() << ": Incoming WebSocket data of " << 
len << " bytes: "
+<< Util::stringifyHexLine(socket->getInBuffer(), 0, 
std::min((size_t)32, len)));
 
 data = p + headerLen;
 
@@ -693,7 +695,8 @@ protected:
 {
 std::shared_ptr socket = _socket.lock();
 
-LOG_TRC("Incoming client websocket upgrade response: " << 
std::string(>getInBuffer()[0], socket->getInBuffer().size()));
+LOG_TRC("Incoming client websocket upgrade response: "
+<< std::string(>getInBuffer()[0], 
socket->getInBuffer().size()));
 
 bool bOk = false;
 StreamSocket::MessageMap map;
@@ -715,8 +718,9 @@ protected:
 map._headerSize = itBody - socket->getInBuffer().begin() + 
marker.size();
 }
 
-if (response.getStatus() == 
Poco::Net::HTTPResponse::HTTP_SWITCHING_PROTOCOLS &&
-response.has("Upgrade") && 
Poco::icompare(response.get("Upgrade"), "websocket") == 0)
+if (response.getStatus() == 
Poco::Net::HTTPResponse::HTTP_SWITCHING_PROTOCOLS
+&& response.has("Upgrade")
+&& Poco::icompare(response.get("Upgrade"), "websocket") == 0)
 {
 #if 0 // SAL_DEBUG ...
 const std::string wsKey = response.get("Sec-WebSocket-Accept", 
"");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/Util.cpp common/Util.hpp kit/Kit.cpp loolwsd.xml.in test/WhiteBoxTests.cpp wsd/LOOLWSD.cpp wsd/LOOLWSD.hpp

[Ashod Nakashian (via logerrit)]

 common/Util.cpp|   37 -
 common/Util.hpp|8 ++---
 kit/Kit.cpp|   13 ++--
 loolwsd.xml.in |3 +-
 test/WhiteBoxTests.cpp |   72 +++--
 wsd/LOOLWSD.cpp|8 -
 wsd/LOOLWSD.hpp|6 ++--
 7 files changed, 103 insertions(+), 44 deletions(-)

New commits:
commit 919a93cd4b123f3757ce1ae454ed622019d1d02c
Author: Ashod Nakashian 
AuthorDate: Sun Apr 14 12:21:19 2019 -0400
Commit: Ashod Nakashian 
CommitDate: Sat Aug 17 04:26:35 2019 +0200

wsd: improved anonymization algorithm

Better hashing algorithm based on FNV-1a.
Adds support for salting the hash, and
for providing salt via configuration.

More unit-tests added, and better formatting.

Change-Id: I2be42675d0cdbaa73c3d7faed99e07631a9c20fc
Reviewed-on: https://gerrit.libreoffice.org/70034
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/71091

diff --git a/common/Util.cpp b/common/Util.cpp
index bb3983239..774b522db 100644
--- a/common/Util.cpp
+++ b/common/Util.cpp
@@ -304,16 +304,16 @@ namespace Util
 return true;
 }
 
-std::string encodeId(const unsigned number, const int padding)
+std::string encodeId(const std::uint64_t number, const int padding)
 {
 std::ostringstream oss;
 oss << std::hex << std::setw(padding) << std::setfill('0') << number;
 return oss.str();
 }
 
-unsigned decodeId(const std::string& str)
+std::uint64_t decodeId(const std::string& str)
 {
-unsigned id = 0;
+std::uint64_t id = 0;
 std::stringstream ss;
 ss << std::hex << str;
 ss >> id;
@@ -684,7 +684,7 @@ namespace Util
 }
 
 static std::map AnonymizedStrings;
-static std::atomic AnonymizationSalt(0);
+static std::atomic AnonymizationCounter(0);
 static std::mutex AnonymizedMutex;
 
 void mapAnonymized(const std::string& plain, const std::string& anonymized)
@@ -701,7 +701,7 @@ namespace Util
 AnonymizedStrings[plain] = anonymized;
 }
 
-std::string anonymize(const std::string& text)
+std::string anonymize(const std::string& text, const std::uint64_t 
nAnonymizationSalt)
 {
 {
 std::unique_lock lock(AnonymizedMutex);
@@ -716,15 +716,26 @@ namespace Util
 }
 }
 
-// We just need something irreversible, short, and
-// quite simple.
-std::size_t hash = 0;
+// Modified 64-bit FNV-1a to add salting.
+// For the algorithm and the magic numbers, see 
http://isthe.com/chongo/tech/comp/fnv/
+std::uint64_t hash = 0xCBF29CE484222325LL;
+hash ^= nAnonymizationSalt;
+hash *= 0x10001b3ULL;
 for (const char c : text)
-hash += c;
+{
+hash ^= static_cast(c);
+hash *= 0x10001b3ULL;
+}
+
+hash ^= nAnonymizationSalt;
+hash *= 0x10001b3ULL;
 
 // Generate the anonymized string. The '#' is to hint that it's 
anonymized.
-// Prepend with salt to make it unique, in case we get collisions 
(which we will, eventually).
-const std::string res = '#' + Util::encodeId(AnonymizationSalt++, 0) + 
'#' + Util::encodeId(hash, 0) + '#';
+// Prepend with count to make it unique within a single process 
instance,
+// in case we get collisions (which we will, eventually). N.B.: 
Identical
+// strings likely to have different prefixes when logged in WSD 
process vs. Kit.
+const std::string res
+= '#' + Util::encodeId(AnonymizationCounter++, 0) + '#' + 
Util::encodeId(hash, 0) + '#';
 mapAnonymized(text, res);
 return res;
 }
@@ -739,7 +750,7 @@ namespace Util
 return filename;
 }
 
-std::string anonymizeUrl(const std::string& url)
+std::string anonymizeUrl(const std::string& url, const std::uint64_t 
nAnonymizationSalt)
 {
 std::string base;
 std::string filename;
@@ -747,7 +758,7 @@ namespace Util
 std::string params;
 std::tie(base, filename, ext, params) = Util::splitUrl(url);
 
-return base + Util::anonymize(filename) + ext + params;
+return base + Util::anonymize(filename, nAnonymizationSalt) + ext + 
params;
 }
 
 std::string getHttpTimeNow()
diff --git a/common/Util.hpp b/common/Util.hpp
index 9e01181fa..e16479f68 100644
--- a/common/Util.hpp
+++ b/common/Util.hpp
@@ -74,9 +74,9 @@ namespace Util
 /// Hex to unsigned char
 bool dataFromHexString(const std::string& hexString, std::vector& data);
 /// Encode an integral ID into a string, with padding support.
-std::string encodeId(const unsigned number, const int padding = 5);
+std::string encodeId(const std::uint64_t number, const int padding = 5);
 /// Decode an integral ID from a string.
-

[Libreoffice-bugs] [Bug 119393] Draw - SVG Export of rotated textbox causes multiple lines of text to be displayed on top of each other.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119393

Nick222  changed:

   What|Removed |Added

Version|5.0.0.5 release |6.3.0.4 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: configure.ac kit/Kit.cpp loolwsd.xml.in wsd/ClientSession.cpp wsd/DocumentBroker.cpp wsd/LOOLWSD.cpp wsd/LOOLWSD.hpp wsd/Storage.cpp

[Ashod Nakashian (via logerrit)]

 configure.ac   |   35 +-
 kit/Kit.cpp|   18 ++-
 loolwsd.xml.in |3 --
 wsd/ClientSession.cpp  |2 -
 wsd/DocumentBroker.cpp |2 -
 wsd/LOOLWSD.cpp|   57 +
 wsd/LOOLWSD.hpp|7 ++
 wsd/Storage.cpp|   20 ++---
 8 files changed, 66 insertions(+), 78 deletions(-)

New commits:
commit 226c2fe71c53f4c8e460bf13a30870aaa0ea7581
Author: Ashod Nakashian 
AuthorDate: Sun Apr 14 12:24:45 2019 -0400
Commit: Ashod Nakashian 
CommitDate: Sat Aug 17 03:42:19 2019 +0200

wsd: unify anonymization flags under one

This simplifies the anonymization configuration
as virtually always they are all either enabled
together, or not at all.

Change-Id: I6fe60f5287fc5d71cd7a6ac3268eac67e5e6e9fb
Reviewed-on: https://gerrit.libreoffice.org/70033
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/71090

diff --git a/configure.ac b/configure.ac
index 681d5bdde..711de7d01 100644
--- a/configure.ac
+++ b/configure.ac
@@ -59,13 +59,9 @@ AC_ARG_ENABLE([browsersync],
   AS_HELP_STRING([--enable-browsersync],
  [Don't copy files to the target directory but 
create the symlink to allow browsersync usage]))
 
-AC_ARG_ENABLE([anonymize-usernames],
-  AS_HELP_STRING([--enable-anonymize-usernames],
- [Enable anonymization/obfuscation of usernames in 
logs]))
-
-AC_ARG_ENABLE([anonymize-filenames],
-  AS_HELP_STRING([--enable-anonymize-filenames],
- [Enable anonymization/obfuscation of filenames in 
logs]))
+AC_ARG_ENABLE([anonymization],
+  AS_HELP_STRING([--enable-anonymization],
+ [Enable anonymization/obfuscation of user-data in 
logs]))
 
 AC_ARG_ENABLE([iosapp],
   AS_HELP_STRING([--enable-iosapp],
@@ -213,8 +209,7 @@ ENABLE_DEBUG=
 LOOLWSD_LOGLEVEL="warning"
 LOOLWSD_LOG_TO_FILE="false"
 LOOLWSD_LOGFILE="/var/log/loolwsd.log"
-LOOLWSD_ANONYMIZE_FILENAMES=false
-LOOLWSD_ANONYMIZE_USERNAMES=false
+LOOLWSD_ANONYMIZE_USER_DATA=false
 LOLEAFLET_LOGGING="false"
 debug_msg="secure mode: product build"
 anonym_msg=""
@@ -224,8 +219,7 @@ if test "$enable_debug" = "yes"; then
LOOLWSD_LOGLEVEL="trace"
LOOLWSD_LOG_TO_FILE="true"
LOOLWSD_LOGFILE="/tmp/loolwsd.log"
-   LOOLWSD_ANONYMIZE_FILENAMES=false
-   LOOLWSD_ANONYMIZE_USERNAMES=false
+   LOOLWSD_ANONYMIZE_USER_DATA=false
LOLEAFLET_LOGGING="true"
debug_msg="low security debugging mode"
 else
@@ -252,22 +246,15 @@ if test -n "$with_logfile" ; then
 fi
 AC_SUBST(LOOLWSD_LOGFILE)
 
-if test "$enable_anonymize_filenames" = "yes" ; then
-   LOOLWSD_ANONYMIZE_FILENAMES=true
-   anonym_msg="filenames anonymized; "
-fi
-AC_DEFINE_UNQUOTED([LOOLWSD_ANONYMIZE_FILENAMES],[$LOOLWSD_ANONYMIZE_FILENAMES],[Enable
 permanent filenames anonymization in logs])
-AC_SUBST(LOOLWSD_ANONYMIZE_FILENAMES)
-
-if test "$enable_anonymize_usernames" = "yes" ; then
-   LOOLWSD_ANONYMIZE_USERNAMES=true
-   anonym_msg="${anonym_msg}usernames anonymized; "
+if test "$enable_anonymization" = "yes" ; then
+   LOOLWSD_ANONYMIZE_USER_DATA=true
+   anonym_msg="anonymization of user-data is enabled"
 fi
-AC_DEFINE_UNQUOTED([LOOLWSD_ANONYMIZE_USERNAMES],[$LOOLWSD_ANONYMIZE_USERNAMES],[Enable
 permanent usernames anonymization in logs])
-AC_SUBST(LOOLWSD_ANONYMIZE_USERNAMES)
+AC_DEFINE_UNQUOTED([LOOLWSD_ANONYMIZE_USER_DATA],[$LOOLWSD_ANONYMIZE_USER_DATA],[Enable
 permanent anonymization in logs])
+AC_SUBST(LOOLWSD_ANONYMIZE_USER_DATA)
 
 if test -z "$anonym_msg";  then
-  anonym_msg="no anonymization of usernames or filenames"
+  anonym_msg="anonymization of user-data is disabled"
 fi
 
 # macOS: When configuring for building the app itself, on macOS, we need these.
diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index c76e4cf50..425c0b5fb 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -112,8 +112,7 @@ using std::size_t;
 class Document;
 static std::shared_ptr document;
 #ifndef BUILDING_TESTS
-static bool AnonymizeFilenames = false;
-static bool AnonymizeUsernames = false;
+static bool AnonymizeUserData = false;
 static std::string ObfuscatedFileId;
 #endif
 
@@ -2236,7 +2235,7 @@ protected:
 logger << _socketName << ": recv [";
 for (const std::string& token : tokens)
 {
-// Don't log PII, there are anonymized versions that get 
logged instead.
+// Don't log user-data, there are anonymized versions that get 
logged instead.
 if (Util::startsWith(token, "jail") ||
 Util::startsWith(token, "author") ||
 Util::startsWith(token, "name") ||
@@ -2468,10 +2467,8 @@ void lokit_main(
 LOG_INF("Setting log-level to [trace] and delaying setting to 
configured [" << LogLevel 

[Libreoffice-commits] online.git: loleaflet/src

[Ashod Nakashian (via logerrit)]

 loleaflet/src/core/Socket.js |   15 +--
 1 file changed, 9 insertions(+), 6 deletions(-)

New commits:
commit 74e28ad711f6d18e9ccb96a6c35ab0dd7f19475b
Author: Ashod Nakashian 
AuthorDate: Sat Mar 30 12:15:09 2019 -0400
Commit: Ashod Nakashian 
CommitDate: Sat Aug 17 03:39:32 2019 +0200

leaflet: suppress empty error messages

This also adds support to suppress errors
by setting their message to blank.

Change-Id: I2baabd121afb59c48e950b139f984c64d1720512
Reviewed-on: https://gerrit.libreoffice.org/70032
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 
Reviewed-on: https://gerrit.libreoffice.org/71089
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js
index ddb23f24b..e676b724a 100644
--- a/loleaflet/src/core/Socket.js
+++ b/loleaflet/src/core/Socket.js
@@ -509,12 +509,15 @@ L.Socket = L.Class.extend({
return;
}
 
-   // Parse the storage url as link
-   var tmpLink = document.createElement('a');
-   tmpLink.href = this._map.options.doc;
-   // Insert the storage server address to be more friendly
-   storageError = storageError.replace('%storageserver', 
tmpLink.host);
-   this._map.fire('warn', {msg: storageError});
+   // Skip empty errors (and allow for suppressing errors 
by making them blank).
+   if (storageError != '') {
+   // Parse the storage url as link
+   var tmpLink = document.createElement('a');
+   tmpLink.href = this._map.options.doc;
+   // Insert the storage server address to be more 
friendly
+   storageError = 
storageError.replace('%storageserver', tmpLink.host);
+   this._map.fire('warn', {msg: storageError});
+   }
 
return;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/Log.cpp

[Ashod Nakashian (via logerrit)]

 common/Log.cpp |   12 ++--
 1 file changed, 10 insertions(+), 2 deletions(-)

New commits:
commit c6c673ed6fb5ff213fcd3030a38e221d28e6aa86
Author: Ashod Nakashian 
AuthorDate: Sun Mar 24 23:16:29 2019 -0400
Commit: Ashod Nakashian 
CommitDate: Sat Aug 17 03:38:43 2019 +0200

wsd: cache the logger instance to avoid costly lookups

Change-Id: Idf9261d46b44afc42a960146886c180e37d8d51f
Reviewed-on: https://gerrit.libreoffice.org/69641
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 
Reviewed-on: https://gerrit.libreoffice.org/71085
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/Log.cpp b/common/Log.cpp
index 5a0c2655d..4441eb785 100644
--- a/common/Log.cpp
+++ b/common/Log.cpp
@@ -45,11 +45,13 @@ namespace Log
 struct StaticNameHelper
 {
 private:
-std::atomic _inited;
+Poco::Logger* _logger;
 std::string _name;
 std::string _id;
+std::atomic _inited;
 public:
 StaticNameHelper() :
+_logger(nullptr),
 _inited(true)
 {
 }
@@ -67,6 +69,9 @@ namespace Log
 void setName(const std::string& name) { _name = name; }
 
 const std::string& getName() const { return _name; }
+
+void setLogger(Poco::Logger* logger) { _logger = logger; };
+Poco::Logger* getLogger() { return _logger; }
 };
 static StaticNameHelper Source;
 
@@ -179,6 +184,7 @@ namespace Log
  * */
 channel->open();
 auto& logger = Poco::Logger::create(Source.getName(), channel, 
Poco::Message::PRIO_TRACE);
+Source.setLogger();
 
 logger.setLevel(logLevel.empty() ? std::string("trace") : logLevel);
 
@@ -201,7 +207,9 @@ namespace Log
 
 Poco::Logger& logger()
 {
-return Poco::Logger::get(Source.getInited() ? Source.getName() : 
std::string());
+Poco::Logger* pLogger = Source.getLogger();
+return pLogger ? *pLogger
+   : Poco::Logger::get(Source.getInited() ? 
Source.getName() : std::string());
 }
 
 #if !MOBILEAPP
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: bundled/include kit/ChildSession.cpp kit/Kit.cpp kit/KitHelper.hpp tools/KitClient.cpp

[Ashod Nakashian (via logerrit)]

 bundled/include/LibreOfficeKit/LibreOfficeKit.h  |   30 +
 bundled/include/LibreOfficeKit/LibreOfficeKit.hxx|   38 +-
 bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h |  112 +++
 kit/ChildSession.cpp |   23 +--
 kit/Kit.cpp  |8 -
 kit/KitHelper.hpp|  101 -
 tools/KitClient.cpp  |   54 -
 7 files changed, 193 insertions(+), 173 deletions(-)

New commits:
commit 32007cbb329f4d2bb1b44d0353ad141996d623f7
Author: Ashod Nakashian 
AuthorDate: Fri Aug 16 09:24:38 2019 -0400
Commit: Ashod Nakashian 
CommitDate: Sat Aug 17 03:38:08 2019 +0200

Update LOK headers and reuse callback-type-to-string helper

Also, avoid repeatedly converting INT_MAX to string.
It's an arbitrary large number, so use 1 billion,
which is probably more easily recognizable as an
arbitrary large number.

Change-Id: Ie6f898d6e8978efa29c355f3cb50b60114870f0d
Reviewed-on: https://gerrit.libreoffice.org/77593
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/bundled/include/LibreOfficeKit/LibreOfficeKit.h 
b/bundled/include/LibreOfficeKit/LibreOfficeKit.h
index e4e96483c..93b430f5d 100644
--- a/bundled/include/LibreOfficeKit/LibreOfficeKit.h
+++ b/bundled/include/LibreOfficeKit/LibreOfficeKit.h
@@ -378,6 +378,36 @@ struct _LibreOfficeKitDocumentClass
 /// @see lok::Document::createViewWithOptions().
 int (*createViewWithOptions) (LibreOfficeKitDocument* pThis, const char* 
pOptions);
 
+/// @see lok::Document::selectPart().
+void (*selectPart) (LibreOfficeKitDocument* pThis, int nPart, int nSelect);
+
+/// @see lok::Document::moveSelectedParts().
+void (*moveSelectedParts) (LibreOfficeKitDocument* pThis, int nPosition, 
bool bDuplicate);
+
+/// Resize window with given id.
+/// @see lok::Document::resizeWindow().
+void (*resizeWindow) (LibreOfficeKitDocument* pThis, unsigned nWindowId,
+  const int width, const int height);
+
+/// Pass a nullptr terminated array of mime-type strings
+/// @see lok::Document::getClipboard for more details
+int (*getClipboard) (LibreOfficeKitDocument* pThis,
+ const char **pMimeTypes,
+ size_t  *pOutCount,
+ char  ***pOutMimeTypes,
+ size_t **pOutSizes,
+ char  ***pOutStreams);
+
+/// @see lok::Document::setClipboard
+int (*setClipboard) (LibreOfficeKitDocument* pThis,
+ const size_t   nInCount,
+ const char   **pInMimeTypes,
+ const size_t  *pInSizes,
+ const char   **pInStreams);
+
+/// @see lok::Document::getSelectionType
+int (*getSelectionType) (LibreOfficeKitDocument* pThis);
+
 #endif // defined LOK_USE_UNSTABLE_API || defined LIBO_INTERNAL_ONLY
 };
 
diff --git a/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx 
b/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx
index 0d1c6e94d..517a38a50 100644
--- a/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx
+++ b/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx
@@ -188,7 +188,7 @@ public:
  *
  * @param nWindowid
  */
-void postWindow(unsigned nWindowId, int nAction, const char* pData)
+void postWindow(unsigned nWindowId, int nAction, const char* pData = 
nullptr)
 {
 return mpDoc->pClass->postWindow(mpDoc, nWindowId, nAction, pData);
 }
@@ -436,7 +436,7 @@ public:
 /**
  * Returns a json mapping of the possible values for the given command
  * e.g. {commandName: ".uno:StyleApply", commandValues: {"familyName1" : 
["list of style names in the family1"], etc.}}
- * @param pCommand a uno command for which the possible values are 
requested
+ * @param pCommand a UNO command for which the possible values are 
requested
  * @return {commandName: unoCmd, commandValues: {possible_values}}
  */
 char* getCommandValues(const char* pCommand)
@@ -676,7 +676,7 @@ public:
 /**
  * Gets an image of the selected shapes.
  * @param pOutput contains the result; use free to deallocate.
- * @return the size ouf *pOutput in bytes.
+ * @return the size of *pOutput in bytes.
  */
 size_t renderShapeSelection(char** pOutput)
 {
@@ -698,6 +698,36 @@ public:
 {
 return mpDoc->pClass->postWindowGestureEvent(mpDoc, nWindowId, pType, 
nX, nY, nOffset);
 }
+
+/// Set a part's selection mode.
+/// nSelect is 0 to deselect, 1 to select, and 2 to toggle.
+void selectPart(int nPart, int nSelect)
+{
+mpDoc->pClass->selectPart(mpDoc, nPart, nSelect);
+}
+
+/// Moves the selected pages/slides to a new position.
+/// nPosition is the new position where the 

[Libreoffice-bugs] [Bug 126838] Install fails when silent and desktop shortcut creation is forbidden

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126838

--- Comment #2 from Joda Stößer  ---
I am using AppGet to install LibreOffice:
https://github.com/appget/appget.packages/blob/450c3c3f12a2f8e736471d6cc30b8c0102ce236e/manifests/libreoffice/libreoffice.yaml
I don't know the exact way the silent install is performed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76017] Two Finger Horizontal Scroll is Reversed with Synaptics Touchpad Drivers on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=76017

--- Comment #31 from Ted Lee  ---
(In reply to Luke from comment #30)
> Gym and Ted see Bug 126680. The 6.3.0.4 issue on Mac OS should have been
> fixed there. It was backported to 6.3.1.
Thanks. See comment I made on 126680 (the fix doesn't seem to have made it in
to a Mac build yet.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117692] Frame at top of page moves into header with wrong padding when reloading exported DOCX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117692

Aron Budea  changed:

   What|Removed |Added

URL|http://www.hitechnumber.org |
   |/sbcglobal-customer-support |
   |-number/|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126792] DOCX legacy drop-downs are only supposed to hold 25 items

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126792

--- Comment #1 from Aron Budea  ---
Created attachment 153450
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153450=edit
Sample DOCX (dropdown with 25 entries)

To make repro easier, this sample, created in Word has a dropdown with 25
entries.
Roundtrip it in Writer, Word will open it just fine.
Add another entry in Writer, and Word will stop opening the file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112976] [META] DOCX (OOXML) OLE object-related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112976

Aron Budea  changed:

   What|Removed |Added

 Depends on||126981


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=126981
[Bug 126981] FILESAVE DOCX Embedded Visio object doesn't survive roundtrip
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126981] New: FILESAVE DOCX Embedded Visio object doesn't survive roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126981

Bug ID: 126981
   Summary: FILESAVE DOCX Embedded Visio object doesn't survive
roundtrip
   Product: LibreOffice
   Version: 4.0.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: filter:docx
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ba...@caesar.elte.hu
Blocks: 112976

Created attachment 153449
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153449=edit
Sample DOCX with embedded Visio object

Attached DOCX contains a simple Visio drawing (inside the zip it's
word\embeddings\Microsoft_Visio_Drawing1.vsdx). When opened in Word and
clicking on the object, it clearly behaves as an embedded object (upon
double-clicking it'll complain if Visio isn't installed, that's expected).

- Open and save it in Writer, then reopen in Word.

=> The object appears as a picture in Word (Picture tools ribbon shows on
toolbar).
The visio file is still there, but now it's word\embeddings\oleObject1.bin.

Observed using LO 6.4.0.0.alpha0+ (d3d13140f0036c53aa74820b41acfeffa3572168),
5.0.0.5 / Windows 7.
In 4.0.0.3 even the embedded file gets lost.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112976
[Bug 112976] [META] DOCX (OOXML) OLE object-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76017] Two Finger Horizontal Scroll is Reversed with Synaptics Touchpad Drivers on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=76017

--- Comment #30 from Luke  ---
Gym and Ted see Bug 126680. The 6.3.0.4 issue on Mac OS should have been fixed
there. It was backported to 6.3.1.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/LibreOfficeKit libreofficekit/source

[Ashod Nakashian (via logerrit)]

 include/LibreOfficeKit/LibreOfficeKitEnums.h |  103 ++
 libreofficekit/source/gtk/lokdocview.cxx |  105 ---
 2 files changed, 105 insertions(+), 103 deletions(-)

New commits:
commit 6c80baa5c2aa33aa39f65f6223bf380e9e4e3c94
Author: Ashod Nakashian 
AuthorDate: Fri Aug 16 09:08:10 2019 -0400
Commit: Ashod Nakashian 
CommitDate: Sat Aug 17 00:28:50 2019 +0200

LOK: move LOK callback-type-to-string helper to header

This is a very common function that is used by clients
as well as LO Core, so makes sense to have it implemented
once and updated when new callback-types are added,
all in one place.

Change-Id: Id6a1d6bcf5585d7be440b62a0c3a9c993e46e5e0
Reviewed-on: https://gerrit.libreoffice.org/77587
Tested-by: Jenkins
Reviewed-by: Ashod Nakashian 

diff --git a/include/LibreOfficeKit/LibreOfficeKitEnums.h 
b/include/LibreOfficeKit/LibreOfficeKitEnums.h
index 43762cc54c48..44bf83eab205 100644
--- a/include/LibreOfficeKit/LibreOfficeKitEnums.h
+++ b/include/LibreOfficeKit/LibreOfficeKitEnums.h
@@ -10,6 +10,8 @@
 #ifndef INCLUDED_LIBREOFFICEKIT_LIBREOFFICEKITENUMS_H
 #define INCLUDED_LIBREOFFICEKIT_LIBREOFFICEKITENUMS_H
 
+#include 
+
 #ifdef __cplusplus
 extern "C"
 {
@@ -706,6 +708,107 @@ typedef enum
 }
 LibreOfficeKitExtTextInputType;
 
+/// Returns the string representation of a LibreOfficeKitCallbackType 
enumeration element.
+static inline const char* lokCallbackTypeToString(int nType)
+{
+switch (static_cast(nType))
+{
+case LOK_CALLBACK_INVALIDATE_TILES:
+return "LOK_CALLBACK_INVALIDATE_TILES";
+case LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR:
+return "LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR";
+case LOK_CALLBACK_TEXT_SELECTION:
+return "LOK_CALLBACK_TEXT_SELECTION";
+case LOK_CALLBACK_TEXT_SELECTION_START:
+return "LOK_CALLBACK_TEXT_SELECTION_START";
+case LOK_CALLBACK_TEXT_SELECTION_END:
+return "LOK_CALLBACK_TEXT_SELECTION_END";
+case LOK_CALLBACK_CURSOR_VISIBLE:
+return "LOK_CALLBACK_CURSOR_VISIBLE";
+case LOK_CALLBACK_VIEW_CURSOR_VISIBLE:
+return "LOK_CALLBACK_VIEW_CURSOR_VISIBLE";
+case LOK_CALLBACK_GRAPHIC_SELECTION:
+return "LOK_CALLBACK_GRAPHIC_SELECTION";
+case LOK_CALLBACK_GRAPHIC_VIEW_SELECTION:
+return "LOK_CALLBACK_GRAPHIC_VIEW_SELECTION";
+case LOK_CALLBACK_CELL_CURSOR:
+return "LOK_CALLBACK_CELL_CURSOR";
+case LOK_CALLBACK_HYPERLINK_CLICKED:
+return "LOK_CALLBACK_HYPERLINK_CLICKED";
+case LOK_CALLBACK_MOUSE_POINTER:
+return "LOK_CALLBACK_MOUSE_POINTER";
+case LOK_CALLBACK_STATE_CHANGED:
+return "LOK_CALLBACK_STATE_CHANGED";
+case LOK_CALLBACK_STATUS_INDICATOR_START:
+return "LOK_CALLBACK_STATUS_INDICATOR_START";
+case LOK_CALLBACK_STATUS_INDICATOR_SET_VALUE:
+return "LOK_CALLBACK_STATUS_INDICATOR_SET_VALUE";
+case LOK_CALLBACK_STATUS_INDICATOR_FINISH:
+return "LOK_CALLBACK_STATUS_INDICATOR_FINISH";
+case LOK_CALLBACK_SEARCH_NOT_FOUND:
+return "LOK_CALLBACK_SEARCH_NOT_FOUND";
+case LOK_CALLBACK_DOCUMENT_SIZE_CHANGED:
+return "LOK_CALLBACK_DOCUMENT_SIZE_CHANGED";
+case LOK_CALLBACK_SET_PART:
+return "LOK_CALLBACK_SET_PART";
+case LOK_CALLBACK_SEARCH_RESULT_SELECTION:
+return "LOK_CALLBACK_SEARCH_RESULT_SELECTION";
+case LOK_CALLBACK_DOCUMENT_PASSWORD:
+return "LOK_CALLBACK_DOCUMENT_PASSWORD";
+case LOK_CALLBACK_DOCUMENT_PASSWORD_TO_MODIFY:
+return "LOK_CALLBACK_DOCUMENT_PASSWORD_TO_MODIFY";
+case LOK_CALLBACK_CONTEXT_MENU:
+return "LOK_CALLBACK_CONTEXT_MENU";
+case LOK_CALLBACK_INVALIDATE_VIEW_CURSOR:
+return "LOK_CALLBACK_INVALIDATE_VIEW_CURSOR";
+case LOK_CALLBACK_TEXT_VIEW_SELECTION:
+return "LOK_CALLBACK_TEXT_VIEW_SELECTION";
+case LOK_CALLBACK_CELL_VIEW_CURSOR:
+return "LOK_CALLBACK_CELL_VIEW_CURSOR";
+case LOK_CALLBACK_CELL_ADDRESS:
+return "LOK_CALLBACK_CELL_ADDRESS";
+case LOK_CALLBACK_CELL_FORMULA:
+return "LOK_CALLBACK_CELL_FORMULA";
+case LOK_CALLBACK_UNO_COMMAND_RESULT:
+return "LOK_CALLBACK_UNO_COMMAND_RESULT";
+case LOK_CALLBACK_ERROR:
+return "LOK_CALLBACK_ERROR";
+case LOK_CALLBACK_VIEW_LOCK:
+return "LOK_CALLBACK_VIEW_LOCK";
+case LOK_CALLBACK_REDLINE_TABLE_SIZE_CHANGED:
+return "LOK_CALLBACK_REDLINE_TABLE_SIZE_CHANGED";
+case LOK_CALLBACK_REDLINE_TABLE_ENTRY_MODIFIED:
+return "LOK_CALLBACK_REDLINE_TABLE_ENTRY_MODIFIED";
+case LOK_CALLBACK_INVALIDATE_HEADER:
+return "LOK_CALLBACK_INVALIDATE_HEADER";
+case LOK_CALLBACK_COMMENT:
+return "LOK_CALLBACK_COMMENT";
+case LOK_CALLBACK_RULER_UPDATE:
+return "LOK_CALLBACK_RULER_UPDATE";
+case LOK_CALLBACK_WINDOW:
+return "LOK_CALLBACK_WINDOW";
+case LOK_CALLBACK_VALIDITY_LIST_BUTTON:
+ 

[Libreoffice-bugs] [Bug 112192] FILEOPEN: PPTX: Shape not displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112192

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #6 from Regina Henschel  ---
LibreOffice fails because of the missing viewbox. I don't know yet why.

As workaround, you can add the cx and cy values as w and h attributes to the
path element.







-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123009] Impress v6.14 slideview presentation after 68 slides or so stops. Screen message: LibreOffice fatal error: could not create system bitmap

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123009

--- Comment #19 from Richard Ward  ---
Created attachment 153448
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153448=edit
Bug 123009 16Aug 2019 report

Buovjaga.
In reply to Comment 18.
I ran the presentation in read only mode again first on LO6.3 on Windows 8.1
platform The presentation crashed I created a report and sent See attachement
for details.
Then I ran the presentation in read only mode on LO6.4 on Windows 8.1 platform
tit stopped at slide 92 then numerous LH mouse clicks progressed  to slide 95
where the LH mouse did nothing - RH click dropout of LibreOffice to the Windows
main screen Reload LO6.4 document recovery required even though in read only
mode.
see attached report.
regards
Richard

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76017] Two Finger Horizontal Scroll is Reversed with Synaptics Touchpad Drivers on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=76017

--- Comment #29 from Ted Lee  ---
Same bug is in 6.3.0.4 in Calc on Mac OS 10.13.6.  I've been too busy with a
variety of things to keep current on LO versions.  The most recent one I've
used before this was 6.1.0.3 and two-finger scrolling on the trackpad works as
it is supposed to there. It was immediately obvious when I moved up to 6.3.0.4
and starting working with a spreadsheet that there was something wrong with the
horizontal scrolling. Hardware is a  13" MacBook Pro Retina.  I looked for
other reports of the bug and the one this comment is attached to is the only
one I found.  Should there be a new bug report that isn't hardware specific?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa

[Miklos Vajna (via logerrit)]

 sw/qa/extras/uiwriter/uiwriter2.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit d658e1f5e88b82dbd9c0ba48e5b742a3872b0453
Author: Miklos Vajna 
AuthorDate: Fri Aug 16 16:56:15 2019 +0200
Commit: Miklos Vajna 
CommitDate: Fri Aug 16 23:35:30 2019 +0200

CppunitTest_sw_uiwriter: fix top/left confusion in testImageComment

This worked before as usually both are 1418, but in the case of
 the left
is a larger value (4194), while the top stays the same.

Change-Id: Ie31cb29720f6426ad9e2a28405f326e6e82febaa
Reviewed-on: https://gerrit.libreoffice.org/77597
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx 
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index d2035512c393..e59f84a68c68 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -1626,6 +1626,7 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testImageComment)
 CPPUNIT_ASSERT_GREATER(static_cast(0), rAnchored.size());
 SwAnchoredObject* pObject = rAnchored[0];
 long nFrameLeft = pObject->GetObjRect().Left();
+long nFrameTop = pObject->GetObjRect().Top();
 
 // Make sure that the anchor points to the bottom left corner of the image.
 // Without the accompanying fix in place, this test would have failed with:
@@ -1659,7 +1660,7 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testImageComment)
 OString aExpected;
 aExpected += OString::number(nFrameLeft);
 aExpected += ", ";
-aExpected += OString::number(nFrameLeft);
+aExpected += OString::number(nFrameTop);
 aExpected += ", 0, 0";
 CPPUNIT_ASSERT_EQUAL(aExpected, aAnchorPos);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 119393] Draw - SVG Export of rotated textbox causes multiple lines of text to be displayed on top of each other.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119393

m.a.riosv  changed:

   What|Removed |Added

 CC||nick...@yandex.ru

--- Comment #10 from m.a.riosv  ---
*** Bug 126952 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126952] SVG: Wrong export from Draw to SVG-file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126952

m.a.riosv  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||miguelangelrv@libreoffice.o
   ||rg
 Resolution|--- |DUPLICATE

--- Comment #4 from m.a.riosv  ---
Looks like a duplicate of
https://bugs.documentfoundation.org/show_bug.cgi?id=119393

Please if you are not agree reopen it.

*** This bug has been marked as a duplicate of bug 119393 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78916] Custom page size missing from print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78916

Christoffer  changed:

   What|Removed |Added

 CC||ekber...@hotmail.com

--- Comment #34 from Christoffer  ---
Created attachment 153447
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153447=edit
Two differently sized/dimensioned pages

(In reply to Cor Nouws from comment #9)
> Hi Huber,
> 
> (In reply to huber.joseph from comment #0)
> 
> > There is no "Custom" paper size available in the LibreOffice "Print" dialog
> > box. LibreOffice picks a paper size closest to the actual document page
> > size, and uses that. This results in improper placement of the content on
> > the page whent printed.
> 
> Click "Use only paper size from printer preferences" checkbox on the File >
> Print .. Options tab.
> 
> See
> https://bugs.documentfoundation.org/show_bug.cgi?id=61186
> and
> https://wiki.documentfoundation.org/ReleaseNotes/4.1#Other
> 
> So I think closing as duplicate of 67576 is appropriate?
> 
> (Note: discussion on improving the position of that option is ongoing)

The "Use only paper size from printer preferences" checkbox seems to have
disappeared from the new print dialogue form in recent versions of LO.

I have also uploaded a document with 2 pages using different dimensions, which
causes some related weird behavior.
Switching between the pages in the print dialogue somehow mixes the page
dimensions up in the v6.3 print dialogue / preview.

Furthermore, the width and height of landscape-oriented pages are reported to
the printer driver in portrait-oriented mode. LO ignores the fact that most
printers print landscape-oriented pages in 90 degrees rotation compared to
portrait-orientation.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123478] Impress crashes immediately when EDITING and trying to insert a specific video file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123478

--- Comment #13 from Allen  ---
Yes, they both have gstreamer installed but they are different versions.  Here
is the first line of the output from dpkg -l for each.

On 18.04:

ii  gir1.2-gstreamer-1.0:amd64 1.14.5-0ubuntu1~18.04.1 
amd64GObject introspection data for the GStreamer
library


On 16.04:

ii  gir1.2-gstreamer-1.0  1.8.3-1~ubuntu0.1
   amd64GObject introspection data for the GStreamer
library

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126897] Cell Drawing End of Content Rather than Beginning of Content

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126897

--- Comment #7 from m.a.riosv  ---
What you can do it's request for enhancement changing the second box of
'Importance' modifying the title, and status to unconfirmed.

No working as everyone likes it's not a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126952] SVG: Wrong export from Draw to SVG-file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126952

Durgapriyanka  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #3 from Durgapriyanka  ---
Thank you for reporting the bug. I can confirm the bug present in 

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

and

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4 

No text appears after SVG-file export

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126980] New: Global Menu shows up twice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126980

Bug ID: 126980
   Summary: Global Menu shows up twice
   Product: LibreOffice
   Version: 6.2.5.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dougjsha...@gmail.com

Description:
KDE Plasma 5.16.4 Global Menu is showing two sets of menus in all LibreOffice
components.  The leftward one works, the second has pulldown menus, but the
options are greyed out and don't work.   I was using the 6.1.x version of
LibreOffice that was in Ubuntu 18.04 LTS repos without this problem.  I updated
to the 6.2 and then 6.3 version from libreoffice/ppa, and experienced the
problem in both of those versions of LibreOffice.

Steps to Reproduce:
1. Enable Global Menus in KDE Plasma 5.16.4.  (I am using KDE Neon, global menu
is embedded in panel)
2. Open either LibreOffice 6.2 or 6.3
3. Problem should be visible immediately

Actual Results:
LibreOffice opens the global menu twice

Expected Results:
LibreOffice should only open one global menu


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Version: 6.3.0.4
Build ID: 1:6.3.0-0ubuntu0.18.04.1~lo2
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126979] DOCX Import: Image is misplaced

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126979

Durgapriyanka  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from Durgapriyanka  ---
Thank you for reporting the bug. I can confirm the bug present in

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

and

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/source/app/salvtables.cxx |8 
 vcl/unx/gtk3/gtk3gtkinst.cxx  |8 
 2 files changed, 16 deletions(-)

New commits:
commit f52d015b04779b8aaa3e353cbd9d0d5da3e73a16
Author: Caolán McNamara 
AuthorDate: Fri Aug 16 08:21:01 2019 +0100
Commit: Caolán McNamara 
CommitDate: Fri Aug 16 22:32:19 2019 +0200

get_current_page_help_id is now tried first already

Change-Id: Id7f5d2c4bcfaba68afc83d471151e1daabf1a830
Reviewed-on: https://gerrit.libreoffice.org/77558
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 90481eaf0c7e..a5a8dc8c1592 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -5590,14 +5590,6 @@ void SalInstanceWidget::help_hierarchy_foreach(const 
std::functionGetParent()))
 {
-if (m_pBuilder && pParent->IsDialog())
-{
-// tdf#122355 before trying dialog help, check to see if there is 
a notebook
-// called tabcontrol, and try the help for the current page of 
that first
-OString sPageHelpId(m_pBuilder->get_current_page_help_id());
-if (!sPageHelpId.isEmpty() && func(sPageHelpId))
-return;
-}
 if (func(pParent->GetHelpId()))
 return;
 }
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index aa831c1bfbb9..97069acbb568 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -10919,14 +10919,6 @@ void GtkInstanceWidget::help_hierarchy_foreach(const 
std::functionget_current_page_help_id());
-if (!sPageHelpId.isEmpty() && func(sPageHelpId))
-return;
-}
 if (func(::get_help_id(pParent)))
 return;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: chart2/source compilerplugins/clang dbaccess/source extensions/source include/svtools include/vcl solenv/clang-format svtools/Library_svt.mk svtools/source sw/source vc

[Caolán McNamara (via logerrit)]

 chart2/source/controller/dialogs/dlg_CreationWizard.cxx |6 +--
 chart2/source/controller/dialogs/tp_ChartType.cxx   |4 +-
 chart2/source/controller/dialogs/tp_ChartType.hxx   |6 +--
 chart2/source/controller/dialogs/tp_DataSource.cxx  |   10 ++---
 chart2/source/controller/dialogs/tp_DataSource.hxx  |6 +--
 chart2/source/controller/dialogs/tp_RangeChooser.cxx|6 +--
 chart2/source/controller/dialogs/tp_RangeChooser.hxx|6 +--
 chart2/source/controller/dialogs/tp_Wizard_TitlesAndObjects.cxx |2 -
 chart2/source/controller/dialogs/tp_Wizard_TitlesAndObjects.hxx |6 +--
 compilerplugins/clang/constantparam.numbers.results |8 ++--
 dbaccess/source/ext/macromigration/macromigrationpages.cxx  |4 +-
 dbaccess/source/ext/macromigration/macromigrationpages.hxx  |6 +--
 dbaccess/source/ui/dlg/ConnectionPageSetup.cxx  |2 -
 dbaccess/source/ui/dlg/ConnectionPageSetup.hxx  |2 -
 dbaccess/source/ui/dlg/adminpages.cxx   |2 -
 dbaccess/source/ui/dlg/adminpages.hxx   |6 +--
 dbaccess/source/ui/dlg/dbwiz.cxx|6 +--
 dbaccess/source/ui/dlg/dbwizsetup.cxx   |3 +
 dbaccess/source/ui/inc/dbwiz.hxx|6 +--
 dbaccess/source/ui/inc/dbwizsetup.hxx   |2 -
 extensions/source/abpilot/abpfinalpage.cxx  |4 +-
 extensions/source/abpilot/abpfinalpage.hxx  |2 -
 extensions/source/abpilot/abspage.hxx   |4 +-
 extensions/source/abpilot/tableselectionpage.cxx|2 -
 extensions/source/abpilot/tableselectionpage.hxx|2 -
 extensions/source/abpilot/typeselectionpage.cxx |2 -
 extensions/source/abpilot/typeselectionpage.hxx |2 -
 extensions/source/dbpilots/commonpagesdbp.cxx   |4 +-
 extensions/source/dbpilots/commonpagesdbp.hxx   |4 +-
 extensions/source/dbpilots/controlwizard.cxx|4 +-
 extensions/source/dbpilots/controlwizard.hxx|6 +--
 extensions/source/dbpilots/gridwizard.cxx   |7 +--
 extensions/source/dbpilots/gridwizard.hxx   |2 -
 extensions/source/dbpilots/groupboxwiz.cxx  |   18 
+-
 extensions/source/dbpilots/groupboxwiz.hxx  |   10 ++---
 extensions/source/dbpilots/listcombowizard.cxx  |   12 ++
 extensions/source/dbpilots/listcombowizard.hxx  |6 +--
 include/svtools/roadmapwizard.hxx   |6 +--
 include/svtools/strings.hrc |3 -
 include/vcl/wizardmachine.hxx   |   16 
 solenv/clang-format/blacklist   |4 +-
 svtools/Library_svt.mk  |1 
 svtools/source/dialogs/roadmapwizard.cxx|   18 
+-
 svtools/source/uno/wizard/wizardpagecontroller.cxx  |4 --
 svtools/source/uno/wizard/wizardpagecontroller.hxx  |6 +--
 svtools/source/uno/wizard/wizardshell.cxx   |8 ++--
 svtools/source/uno/wizard/wizardshell.hxx   |2 -
 sw/source/ui/dbui/mailmergewizard.cxx   |4 +-
 sw/source/ui/dbui/mmaddressblockpage.cxx|8 ++--
 sw/source/ui/dbui/mmaddressblockpage.hxx|6 +--
 sw/source/ui/dbui/mmdocselectpage.cxx   |   12 +++---
 sw/source/ui/dbui/mmdocselectpage.hxx   |6 +--
 sw/source/ui/dbui/mmgreetingspage.cxx   |6 +--
 sw/source/ui/dbui/mmgreetingspage.hxx   |6 +--
 sw/source/ui/dbui/mmlayoutpage.cxx  |8 ++--
 sw/source/ui/dbui/mmlayoutpage.hxx  |6 +--
 sw/source/ui/dbui/mmoutputtypepage.cxx  |4 +-
 sw/source/ui/dbui/mmoutputtypepage.hxx  |4 +-
 sw/source/ui/inc/mmresultdialogs.hxx|1 
 sw/source/uibase/inc/mailmergewizard.hxx|2 -
 vcl/Library_vcl.mk  |1 
 vcl/inc/strings.hrc |4 ++
 vcl/source/control/wizardmachine.cxx|   14 +++
 63 files changed, 173 insertions(+), 177 deletions(-)

New commits:
commit 4d450704d672dddf2c555fda5ff3140d8c537d02
Author: Caolán McNamara 
AuthorDate: Sat Aug 3 20:17:38 2019 +0100
Commit: Caolán McNamara 

[Libreoffice-commits] core.git: sfx2/source solenv/doc svl/source sw/source

[Andrea Gelmini (via logerrit)]

 sfx2/source/doc/objmisc.cxx |2 +-
 sfx2/source/view/ipclient.cxx   |2 +-
 solenv/doc/gbuild/doxygen.cfg   |2 +-
 svl/source/items/itemset.cxx|2 +-
 sw/source/core/text/atrstck.cxx |4 ++--
 5 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit bf888e249079fa7bb791041e0699eb7bd41de327
Author: Andrea Gelmini 
AuthorDate: Fri Aug 16 21:40:44 2019 +0200
Commit: Julien Nabet 
CommitDate: Fri Aug 16 22:23:08 2019 +0200

Fix typos

Change-Id: Ifa56c292559977577af45204f4cc8346e5706616
Reviewed-on: https://gerrit.libreoffice.org/77611
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/sfx2/source/doc/objmisc.cxx b/sfx2/source/doc/objmisc.cxx
index 6fc2027bc2df..df52c23c0b7c 100644
--- a/sfx2/source/doc/objmisc.cxx
+++ b/sfx2/source/doc/objmisc.cxx
@@ -361,7 +361,7 @@ void SfxObjectShell::SetReadOnlyUI( bool bReadOnly )
 
 /*  [Description]
 
-Turns the document in an r/o and r/w state respectively without reloading
+Turns the document in a r/o and r/w state respectively without reloading
 it and without changing the open mode of the medium.
 */
 
diff --git a/sfx2/source/view/ipclient.cxx b/sfx2/source/view/ipclient.cxx
index 07fd91bbdd5c..2e50126df545 100644
--- a/sfx2/source/view/ipclient.cxx
+++ b/sfx2/source/view/ipclient.cxx
@@ -509,7 +509,7 @@ void SAL_CALL SfxInPlaceClient_Impl::changedPlacement( 
const awt::Rectangle& aPo
 Size aNewObjSize( long( aNewLogicRect.GetWidth()  / m_aScaleWidth ),
   long( aNewLogicRect.GetHeight() / m_aScaleHeight ) );
 
-// now remove scaling from new placement and keep this a the new 
object area
+// now remove scaling from new placement and keep this at the new 
object area
 aNewLogicRect.SetSize( aNewObjSize );
 m_aObjArea = aNewLogicRect;
 
diff --git a/solenv/doc/gbuild/doxygen.cfg b/solenv/doc/gbuild/doxygen.cfg
index af0ba2171919..d66fe0cd1670 100644
--- a/solenv/doc/gbuild/doxygen.cfg
+++ b/solenv/doc/gbuild/doxygen.cfg
@@ -1422,7 +1422,7 @@ RTF_HYPERLINKS = NO
 
 RTF_STYLESHEET_FILE=
 
-# Set optional variables used in the generation of an rtf document.
+# Set optional variables used in the generation of an RTF document.
 # Syntax is similar to doxygen's config file.
 
 RTF_EXTENSIONS_FILE=
diff --git a/svl/source/items/itemset.cxx b/svl/source/items/itemset.cxx
index 75709c3f4072..1faf57230a58 100644
--- a/svl/source/items/itemset.cxx
+++ b/svl/source/items/itemset.cxx
@@ -55,7 +55,7 @@ sal_uInt16 Count_Impl( const sal_uInt16 *pRanges )
 
 /**
  * Determines the total number of sal_uInt16s described in a 0-terminated
- * array of pairs of sal_uInt16s, each representing an range of sal_uInt16s.
+ * array of pairs of sal_uInt16s, each representing a range of sal_uInt16s.
  */
 sal_uInt16 Capacity_Impl( const sal_uInt16 *pRanges )
 {
diff --git a/sw/source/core/text/atrstck.cxx b/sw/source/core/text/atrstck.cxx
index 3447e0e2b889..b195e2ddaafb 100644
--- a/sw/source/core/text/atrstck.cxx
+++ b/sw/source/core/text/atrstck.cxx
@@ -526,7 +526,7 @@ void SwAttrHandler::ActivateTop( SwFont& rFnt, const 
sal_uInt16 nAttr )
 else if ( RES_TXTATR_CJK_RUBY == nAttr )
 {
 // ruby stack has no more attributes
-// check, if an rotation attribute has to be applied
+// check, if a rotation attribute has to be applied
 const sal_uInt16 nTwoLineStack = StackPos[ RES_CHRATR_TWO_LINES ];
 bool bTwoLineAct = false;
 const SwTextAttr* pTwoLineAttr = GetTop(nTwoLineStack);
@@ -543,7 +543,7 @@ void SwAttrHandler::ActivateTop( SwFont& rFnt, const 
sal_uInt16 nAttr )
 if ( bTwoLineAct )
 return;
 
-// eventually, an rotate attribute has to be activated
+// eventually, a rotate attribute has to be activated
 const sal_uInt16 nRotateStack = StackPos[ RES_CHRATR_ROTATE ];
 const SwTextAttr* pRotateAttr = GetTop(nRotateStack);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source writerfilter/inc xmerge/source xmloff/source

[Andrea Gelmini (via logerrit)]

 sw/source/filter/xml/xmltbli.cxx|2 
+-
 writerfilter/inc/dmapper/resourcemodel.hxx  |2 
+-
 xmerge/source/xmerge/java/org/openoffice/xmerge/DocumentMerger.java |4 
++--
 xmerge/source/xmerge/java/org/openoffice/xmerge/DocumentSerializer.java |6 
+++---
 xmloff/source/forms/propertyimport.hxx  |2 
+-
 5 files changed, 8 insertions(+), 8 deletions(-)

New commits:
commit f8cb50799e34b0adb0c36c392502deb7baf556c5
Author: Andrea Gelmini 
AuthorDate: Fri Aug 16 21:40:46 2019 +0200
Commit: Julien Nabet 
CommitDate: Fri Aug 16 22:21:50 2019 +0200

Fix typos

Change-Id: I8ab75eb5cd54d14fda42bcdb1a251e9e2b6fefdf
Reviewed-on: https://gerrit.libreoffice.org/77612
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/sw/source/filter/xml/xmltbli.cxx b/sw/source/filter/xml/xmltbli.cxx
index 4356945c11b6..d5fcebe1667c 100644
--- a/sw/source/filter/xml/xmltbli.cxx
+++ b/sw/source/filter/xml/xmltbli.cxx
@@ -2375,7 +2375,7 @@ void SwXMLTableContext::MakeTable_( SwTableBox *pBox )
 // All column that have absolute widths get relative widths;
 // these widths relate to each over like the original absolute
 // widths. The smallest column gets a width that has the same
-// value as the smallest column that has an relative width
+// value as the smallest column that has a relative width
 // already.
 if( 0 == nMinRelColWidth )
 nMinRelColWidth = nMinAbsColWidth;
diff --git a/writerfilter/inc/dmapper/resourcemodel.hxx 
b/writerfilter/inc/dmapper/resourcemodel.hxx
index cb6cae6cd4d5..728c6ed9a641 100644
--- a/writerfilter/inc/dmapper/resourcemodel.hxx
+++ b/writerfilter/inc/dmapper/resourcemodel.hxx
@@ -58,7 +58,7 @@ typedef sal_uInt32 Id;
 namespace writerfilter {
 
 /**
-Reference to an resource that generates events and sends them to a
+Reference to a resource that generates events and sends them to a
 handler.
 
 The reference can be resolved, i.e. the resource generates its
diff --git 
a/xmerge/source/xmerge/java/org/openoffice/xmerge/DocumentMerger.java 
b/xmerge/source/xmerge/java/org/openoffice/xmerge/DocumentMerger.java
index 4347c70fc6f8..3ec19e7484be 100644
--- a/xmerge/source/xmerge/java/org/openoffice/xmerge/DocumentMerger.java
+++ b/xmerge/source/xmerge/java/org/openoffice/xmerge/DocumentMerger.java
@@ -33,7 +33,7 @@ package org.openoffice.xmerge;
  * utilizes to know how the Office {@code Document} tags are
  * supported in the Device format.
  *
- * The {@code DocumentMerger} object is created by a the
+ * The {@code DocumentMerger} object is created by the
  * {@code DocumentMergerFactory} {@link
  * org.openoffice.xmerge.DocumentMergerFactory#createDocumentMerger
  * createDocumenMerger} method.  When it is constructed, the Original
@@ -71,4 +71,4 @@ public interface DocumentMerger {
  * @throws  MergeException  If any merge error occurs.
  */
 void merge(Document modifiedDoc) throws MergeException;
-}
\ No newline at end of file
+}
diff --git 
a/xmerge/source/xmerge/java/org/openoffice/xmerge/DocumentSerializer.java 
b/xmerge/source/xmerge/java/org/openoffice/xmerge/DocumentSerializer.java
index c31e07c54ef1..87f5da1c2fe4 100644
--- a/xmerge/source/xmerge/java/org/openoffice/xmerge/DocumentSerializer.java
+++ b/xmerge/source/xmerge/java/org/openoffice/xmerge/DocumentSerializer.java
@@ -25,10 +25,10 @@ import java.io.IOException;
  * Office {@code Document} to a Device {@code Document}
  * format.
  *
- * The {@code DocumentSerializer} object is created by a the
+ * The {@code DocumentSerializer} object is created by the
  * {@code PluginFactory} {@link
  * org.openoffice.xmerge.DocumentSerializerFactory#createDocumentSerializer
- * createDocumentSerializer} method.  When it is constructed, a
+ * createDocumentSerializer} method.  When it is constructed, an
  * Office {@code Document} object is passed in to be used as input.
  * 
  *
@@ -51,4 +51,4 @@ public interface DocumentSerializer {
  * @throws  IOException   If any I/O error occurs.
  */
 ConvertData serialize() throws ConvertException, IOException;
-}
\ No newline at end of file
+}
diff --git a/xmloff/source/forms/propertyimport.hxx 
b/xmloff/source/forms/propertyimport.hxx
index 2f95767a5721..a08727902dbb 100644
--- a/xmloff/source/forms/propertyimport.hxx
+++ b/xmloff/source/forms/propertyimport.hxx
@@ -123,7 +123,7 @@ namespace xmloff
 
 /** determine if the element imported by the object had a given 
attribute.
 Please be aware of the fact that the name given must be a local 
name, i.e. not contain a namespace.
-All form relevant attributes are in the same namespace, so this 
would be an redundant information.
+All form relevant attributes are in the same namespace, so this 
would be a redundant 

[Libreoffice-commits] core.git: include/svtools include/tools odk/examples offapi/com

[Andrea Gelmini (via logerrit)]

 include/svtools/templatefoldercache.hxx  | 
   2 +-
 include/tools/diagnose_ex.h  | 
   2 +-
 odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/OfficeConnect.java | 
   2 +-
 odk/examples/DevelopersGuide/OfficeDev/OfficeConnect.java| 
   2 +-
 offapi/com/sun/star/chart2/XRegressionCurveContainer.idl | 
   2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 3681229b125238b02e03cf1bdf53b404f080f091
Author: Andrea Gelmini 
AuthorDate: Fri Aug 16 21:40:42 2019 +0200
Commit: Julien Nabet 
CommitDate: Fri Aug 16 22:21:07 2019 +0200

Fix typos

Change-Id: I5d0776d5f90f44ebbeeb5916cbbf6e87406adcad
Reviewed-on: https://gerrit.libreoffice.org/77609
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/include/svtools/templatefoldercache.hxx 
b/include/svtools/templatefoldercache.hxx
index 2bcba8e7ec65..abaa5ec99e7c 100644
--- a/include/svtools/templatefoldercache.hxx
+++ b/include/svtools/templatefoldercache.hxx
@@ -32,7 +32,7 @@ namespace svt
 
 class TemplateFolderCacheImpl;
 /** allows to cache the state of the template directories of OOo
-Usually, this class is used together with an instance of a the
+Usually, this class is used together with an instance of the
 DocumentTemplates 
service. It allows to scan the template folders
 of the Office, and updates the configuration so that it reflects the 
most recent state of the folders.
 As this is an expensive, the TemplateFolderCache has been introduced. 
It caches the state of the template
diff --git a/include/tools/diagnose_ex.h b/include/tools/diagnose_ex.h
index 2d76241cadd0..fc814d91db40 100644
--- a/include/tools/diagnose_ex.h
+++ b/include/tools/diagnose_ex.h
@@ -91,7 +91,7 @@ inline css::uno::Any DbgGetCaughtException()
arg ); }
 
 /** This macro asserts the given condition (in debug mode), and throws
-an RuntimeException afterwards.
+a RuntimeException afterwards.
  */
 #define ENSURE_OR_THROW(c, m) \
 if( !(c) ){ \
diff --git 
a/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/OfficeConnect.java 
b/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/OfficeConnect.java
index 9388181f3b15..617e38047106 100644
--- 
a/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/OfficeConnect.java
+++ 
b/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/OfficeConnect.java
@@ -39,7 +39,7 @@
 // __ Implementation __
 
 /**
- * support ONE singleton uno connection to an running office installation!
+ * support ONE singleton uno connection to a running office installation!
  * Can be used to open/use/close connection to uno environment of an office. If
  * necessary a new office instance is started.
  * ctor isn't available from outside. You should call static function
diff --git a/odk/examples/DevelopersGuide/OfficeDev/OfficeConnect.java 
b/odk/examples/DevelopersGuide/OfficeDev/OfficeConnect.java
index 0e9e5fadd273..d8db72aad323 100644
--- a/odk/examples/DevelopersGuide/OfficeDev/OfficeConnect.java
+++ b/odk/examples/DevelopersGuide/OfficeDev/OfficeConnect.java
@@ -40,7 +40,7 @@ import com.sun.star.uno.UnoRuntime;
 // __ Implementation __
 
 /**
- * support ONE singleton uno connection to an running office installation!
+ * support ONE singleton uno connection to a running office installation!
  * Can be used to open/use/close connection to uno environment of an already 
running office.
  * ctor isn't available from outside. You should call static function 
"getConnection()"
  * to open or use internal set connection which is created one times only.
diff --git a/offapi/com/sun/star/chart2/XRegressionCurveContainer.idl 
b/offapi/com/sun/star/chart2/XRegressionCurveContainer.idl
index db48fd9c680d..05b76365b3a8 100644
--- a/offapi/com/sun/star/chart2/XRegressionCurveContainer.idl
+++ b/offapi/com/sun/star/chart2/XRegressionCurveContainer.idl
@@ -35,7 +35,7 @@ module chart2
 
 interface XRegressionCurveContainer : com::sun::star::uno::XInterface
 {
-/** add an regression curve to the container
+/** add a regression curve to the container
 
 @throws IllegalArgumentException
 If the given regression curve is already contained in the
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: dtrans/source framework/source include/connectivity include/svtools

[Andrea Gelmini (via logerrit)]

 dtrans/source/win32/clipb/MtaOleClipb.hxx |2 +-
 dtrans/source/win32/dtobj/TxtCnvtHlp.cxx  |4 ++--
 framework/source/loadenv/loadenv.cxx  |4 ++--
 include/connectivity/dbmetadata.hxx   |2 +-
 include/svtools/ctrlbox.hxx   |2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit fdf032c366c6c8ba854a2e922dd25ff390be66e1
Author: Andrea Gelmini 
AuthorDate: Fri Aug 16 21:40:41 2019 +0200
Commit: Julien Nabet 
CommitDate: Fri Aug 16 22:20:21 2019 +0200

Fix typos

Change-Id: I488908096aac319daf30875aee1e46b914cc4759
Reviewed-on: https://gerrit.libreoffice.org/77608
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/dtrans/source/win32/clipb/MtaOleClipb.hxx 
b/dtrans/source/win32/clipb/MtaOleClipb.hxx
index 58583ce6c7e5..bf71ac26e8f8 100644
--- a/dtrans/source/win32/clipb/MtaOleClipb.hxx
+++ b/dtrans/source/win32/clipb/MtaOleClipb.hxx
@@ -56,7 +56,7 @@ public:
 private:
 unsigned int run( );
 
-// create a hidden window which serves as an request target; so we
+// create a hidden window which serves as a request target; so we
 // guarantee synchronization
 void createMtaOleReqWnd( );
 
diff --git a/dtrans/source/win32/dtobj/TxtCnvtHlp.cxx 
b/dtrans/source/win32/dtobj/TxtCnvtHlp.cxx
index 91f26ed9f0c0..1ea9f4c9f549 100644
--- a/dtrans/source/win32/dtobj/TxtCnvtHlp.cxx
+++ b/dtrans/source/win32/dtobj/TxtCnvtHlp.cxx
@@ -76,7 +76,7 @@ int MultiByteToWideCharEx( UINT cp_src,
 // setup a global memory pointer
 CRawHGlobalPtr ptrHGlob( refDTransHelper );
 
-// do the conversion an return
+// do the conversion and return
 return MultiByteToWideChar( cp_src,
 0,
 lpMultiByteString,
@@ -110,7 +110,7 @@ int WideCharToMultiByteEx( UINT cp_dest,
 // setup a global memory pointer
 CRawHGlobalPtr ptrHGlob( refDTransHelper );
 
-// do the conversion an return
+// do the conversion and return
 return WideCharToMultiByte( cp_dest,
 0,
 lpWideCharString,
diff --git a/framework/source/loadenv/loadenv.cxx 
b/framework/source/loadenv/loadenv.cxx
index ff19bdff0006..73180facd46a 100644
--- a/framework/source/loadenv/loadenv.cxx
+++ b/framework/source/loadenv/loadenv.cxx
@@ -1190,8 +1190,8 @@ css::uno::Reference< css::uno::XInterface > 
LoadEnv::impl_searchLoader()
 throw LoadEnvException(LoadEnvException::ID_INVALID_ENVIRONMENT);
 }
 
-// Otherwise ...
-// We need this type information to locate an registered frame loader
+// Otherwise...
+// We need this type information to locate a registered frame loader
 // Without such information we can't work!
 OUString sType = 
m_lMediaDescriptor.getUnpackedValueOrDefault(utl::MediaDescriptor::PROP_TYPENAME(),
 OUString());
 if (sType.isEmpty())
diff --git a/include/connectivity/dbmetadata.hxx 
b/include/connectivity/dbmetadata.hxx
index 21c8d63013c6..085b30b52875 100644
--- a/include/connectivity/dbmetadata.hxx
+++ b/include/connectivity/dbmetadata.hxx
@@ -66,7 +66,7 @@ namespace dbtools
 @throws css::sdbc::SQLException
 if obtaining the meta data from the connection throws an 
SQLException
 @throws css::uno::RuntimeException
-if obtaining the meta data from the connection throws an 
RuntimeException
+if obtaining the meta data from the connection throws a 
RuntimeException
 */
 DatabaseMetaData(
 const css::uno::Reference< css::sdbc::XConnection >& _connection );
diff --git a/include/svtools/ctrlbox.hxx b/include/svtools/ctrlbox.hxx
index 06c97e2ccff3..56b7f55026e8 100644
--- a/include/svtools/ctrlbox.hxx
+++ b/include/svtools/ctrlbox.hxx
@@ -175,7 +175,7 @@ All sizes are in 1/10 typographic point (pt).
 
 The passed FontList must be retained until the next fill call.
 
-Additionally it supports an relative mod, which allows entering
+Additionally it supports a relative mod, which allows entering
 percentage values. This, eg., can be useful for template dialogs.
 This mode can only be enabled, but not disabled again.
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: canvas/source cli_ure/source dbaccess/source dtrans/source

[Andrea Gelmini (via logerrit)]

 canvas/source/directx/dx_textlayout_drawhelper.cxx  |2 +-
 cli_ure/source/uno_bridge/cli_data.cxx  |2 +-
 dbaccess/source/core/dataaccess/databasecontext.cxx |2 +-
 dbaccess/source/ui/control/tabletree.cxx|4 ++--
 dtrans/source/win32/clipb/MtaOleClipb.cxx   |2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit de6422b5f3a5e06fe1994442a0f1c277ebed2a45
Author: Andrea Gelmini 
AuthorDate: Fri Aug 16 21:40:40 2019 +0200
Commit: Julien Nabet 
CommitDate: Fri Aug 16 22:19:34 2019 +0200

Fix typos

Change-Id: I207333e9bafc5d6c38ffa53a303046e437b7a815
Reviewed-on: https://gerrit.libreoffice.org/77607
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/canvas/source/directx/dx_textlayout_drawhelper.cxx 
b/canvas/source/directx/dx_textlayout_drawhelper.cxx
index cc3afab92c3a..c751b941e8b5 100644
--- a/canvas/source/directx/dx_textlayout_drawhelper.cxx
+++ b/canvas/source/directx/dx_textlayout_drawhelper.cxx
@@ -73,7 +73,7 @@ namespace dxcanvas
 {
 HDC hdc = rGraphics->GetHDC();
 
-// issue an ReleaseHDC() when leaving the scope
+// issue a ReleaseHDC() when leaving the scope
 const ::comphelper::ScopeGuard aGuard(
 [, ]() mutable { rGraphics->ReleaseHDC(hdc); } );
 
diff --git a/cli_ure/source/uno_bridge/cli_data.cxx 
b/cli_ure/source/uno_bridge/cli_data.cxx
index 16f7047a80dd..4545538a1f5b 100644
--- a/cli_ure/source/uno_bridge/cli_data.cxx
+++ b/cli_ure/source/uno_bridge/cli_data.cxx
@@ -80,7 +80,7 @@ System::Object^ Bridge::map_uno2cli(uno_Interface * pUnoI, 
typelib_InterfaceType
 retVal = CliEnvHolder::g_cli_env->getRegisteredInterface(sOid, 
ifaceType);
 if (retVal)
 {
-// There is already an registered object. It can either be a proxy
+// There is already a registered object. It can either be a proxy
 // for the UNO object or a real cli object. In the first case we
 // tell the proxy that it shall also represent the current UNO
 // interface. If it already does that, then it does nothing
diff --git a/dbaccess/source/core/dataaccess/databasecontext.cxx 
b/dbaccess/source/core/dataaccess/databasecontext.cxx
index 0bcdb475c353..1c6cb283fe29 100644
--- a/dbaccess/source/core/dataaccess/databasecontext.cxx
+++ b/dbaccess/source/core/dataaccess/databasecontext.cxx
@@ -635,7 +635,7 @@ Any ODatabaseContext::getByName(const OUString& _rName)
 if ( xExistent.is() )
 return makeAny( xExistent );
 
-// see whether this is an registered name
+// see whether this is a registered name
 OUString sURL;
 if ( hasRegisteredDatabase( _rName ) )
 {
diff --git a/dbaccess/source/ui/control/tabletree.cxx 
b/dbaccess/source/ui/control/tabletree.cxx
index a0e126254062..19dd1429eefb 100644
--- a/dbaccess/source/ui/control/tabletree.cxx
+++ b/dbaccess/source/ui/control/tabletree.cxx
@@ -168,7 +168,7 @@ void OTableTreeListBox::UpdateTableList( const Reference< 
XConnection >& _rxConn
 }
 catch(RuntimeException&)
 {
-OSL_FAIL("OTableTreeListBox::UpdateTableList : caught an 
RuntimeException!");
+OSL_FAIL("OTableTreeListBox::UpdateTableList : caught a 
RuntimeException!");
 }
 catch ( const SQLException& )
 {
@@ -210,7 +210,7 @@ void TableTreeListBox::UpdateTableList( const Reference< 
XConnection >& _rxConne
 }
 catch(RuntimeException&)
 {
-OSL_FAIL("OTableTreeListBox::UpdateTableList : caught an 
RuntimeException!");
+OSL_FAIL("OTableTreeListBox::UpdateTableList : caught a 
RuntimeException!");
 }
 catch ( const SQLException& )
 {
diff --git a/dtrans/source/win32/clipb/MtaOleClipb.cxx 
b/dtrans/source/win32/clipb/MtaOleClipb.cxx
index ea9f6dfb380f..ae831cc76bb2 100644
--- a/dtrans/source/win32/clipb/MtaOleClipb.cxx
+++ b/dtrans/source/win32/clipb/MtaOleClipb.cxx
@@ -389,7 +389,7 @@ HRESULT CMtaOleClipboard::setClipboard( IDataObject* 
pIDataObject )
 // destroyed before the ole clipboard
 // can acquire it
 // remember: pIDataObject may be NULL
-// which is an request to clear the
+// which is a request to clear the
 // current clipboard content
 if ( pIDataObject )
 pIDataObject->AddRef( );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: offapi/com reportbuilder/java sc/source

[Andrea Gelmini (via logerrit)]

 offapi/com/sun/star/document/XGraphicObjectResolver.idl
   |2 +-
 offapi/com/sun/star/form/validation/ValidatableControlModel.idl
   |2 +-
 offapi/com/sun/star/ucb/ListEvent.idl  
   |2 +-
 
reportbuilder/java/org/libreoffice/report/pentaho/layoutprocessor/OfficeGroupSectionLayoutController.java
 |2 +-
 sc/source/filter/inc/stylesbuffer.hxx  
   |2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 0650ffefe0ff680e0ef7de9cce724b0e47d8c359
Author: Andrea Gelmini 
AuthorDate: Fri Aug 16 21:40:43 2019 +0200
Commit: Julien Nabet 
CommitDate: Fri Aug 16 22:19:01 2019 +0200

Fix typos

Change-Id: Ia8335622cb2e2b44f2b1ee36f7370b126d1ae642
Reviewed-on: https://gerrit.libreoffice.org/77610
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/offapi/com/sun/star/document/XGraphicObjectResolver.idl 
b/offapi/com/sun/star/document/XGraphicObjectResolver.idl
index ea8f5ea270b7..2296a0c2c6cb 100644
--- a/offapi/com/sun/star/document/XGraphicObjectResolver.idl
+++ b/offapi/com/sun/star/document/XGraphicObjectResolver.idl
@@ -36,7 +36,7 @@ published interface XGraphicObjectResolver: 
com::sun::star::uno::XInterface
 /** converts the given URL from the source URL namespace to the destination
 URL space of this instance.
 
-@deprecated since LibreOffice 6.1 - throws an RuntimeException if 
called
+@deprecated since LibreOffice 6.1 - throws a RuntimeException if called
 */
 string resolveGraphicObjectURL( [in] string aURL );
 };
diff --git a/offapi/com/sun/star/form/validation/ValidatableControlModel.idl 
b/offapi/com/sun/star/form/validation/ValidatableControlModel.idl
index 7af85a9282b5..cf5591e09bbb 100644
--- a/offapi/com/sun/star/form/validation/ValidatableControlModel.idl
+++ b/offapi/com/sun/star/form/validation/ValidatableControlModel.idl
@@ -49,7 +49,7 @@ service ValidatableControlModel
 
 /** enables support for validating the value of the control model
 
-Setting an retrieving the current validator of the control model is
+Setting and retrieving the current validator of the control model is
 possible via the XValidatable interface (which
 XValidatableFormComponent is derived from).
 
diff --git a/offapi/com/sun/star/ucb/ListEvent.idl 
b/offapi/com/sun/star/ucb/ListEvent.idl
index 3f465515c09f..84a4f663b5a9 100644
--- a/offapi/com/sun/star/ucb/ListEvent.idl
+++ b/offapi/com/sun/star/ucb/ListEvent.idl
@@ -31,7 +31,7 @@ module com { module sun { module star { module ucb {
 published struct ListEvent: com::sun::star::lang::EventObject
 {
 /** If you apply the given ListActions one after the other
-to the old version of an result set in given order, you will get the
+to the old version of a result set in given order, you will get the
 positions in the new version.
 */
 sequence Changes;
diff --git 
a/reportbuilder/java/org/libreoffice/report/pentaho/layoutprocessor/OfficeGroupSectionLayoutController.java
 
b/reportbuilder/java/org/libreoffice/report/pentaho/layoutprocessor/OfficeGroupSectionLayoutController.java
index 11a3693463a0..956a6928361a 100644
--- 
a/reportbuilder/java/org/libreoffice/report/pentaho/layoutprocessor/OfficeGroupSectionLayoutController.java
+++ 
b/reportbuilder/java/org/libreoffice/report/pentaho/layoutprocessor/OfficeGroupSectionLayoutController.java
@@ -35,7 +35,7 @@ import org.jfree.report.structure.Element;
 /**
  * This layoutcontroller simply checks, whether the parent layout controller
  * is an OfficeGroupLayoutController and whether this layout controller is
- * processing the normal flow or an repeating section. If a repeating section
+ * processing the normal flow or a repeating section. If a repeating section
  * is being processed, an marker attribute is added to the element's call
  * to OutputProcessor.startElement() and OutputProcessor.endElement().
  *
diff --git a/sc/source/filter/inc/stylesbuffer.hxx 
b/sc/source/filter/inc/stylesbuffer.hxx
index 61d438684761..897c7904156a 100644
--- a/sc/source/filter/inc/stylesbuffer.hxx
+++ b/sc/source/filter/inc/stylesbuffer.hxx
@@ -243,7 +243,7 @@ public:
 const css::awt::FontDescriptor& getFontDescriptor() const { return 
maApiData.maDesc;}
 /** Returns true, if the font requires rich text formatting in Calc.
 @descr  Example: Font escapement is a cell attribute in Excel, but Calc
-needs an rich text cell for this attribute. */
+needs a rich text cell for this attribute. */
 boolneedsRichTextFormat() const;
 
 voidfillToItemSet( SfxItemSet& rItemSet, bool 
bEditEngineText, bool bSkipPoolDefs = false ) const;
___

[Libreoffice-bugs] [Bug 126979] DOCX Import: Image is misplaced

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126979

--- Comment #2 from Gülşah Köse  ---
Created attachment 153446
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153446=edit
comparison MSO and LO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126979] DOCX Import: Image is misplaced

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126979

Gülşah Köse  changed:

   What|Removed |Added

 CC||gulsah.k...@collabora.com

--- Comment #1 from Gülşah Köse  ---
Created attachment 153445
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153445=edit
Sample file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126979] New: DOCX Import: Image is misplaced

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126979

Bug ID: 126979
   Summary: DOCX Import: Image is misplaced
   Product: LibreOffice
   Version: 6.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gulsah.k...@collabora.com

Description:
When we have a overflowed image in docx, if we want to open it in LibreOffice,
image location is changing to fit into the file. Real problem is LibreOffice
does not have an image overflow feature. We can not create an odt with
overflowed image. It is not possible to correct it manually.

Steps to Reproduce:
1. Open sample.docx

Actual Results:
İmage fits into the document.

Expected Results:
We should see only bottom of the image. See the comparison pdf at the
attachment.


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126978] Measurement units for paper size in 'Print' dialog does not follow application settings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126978

Heiko Schramm  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|NEW |RESOLVED

--- Comment #3 from Heiko Schramm  ---
(In reply to Oliver Brinzing from comment #2)
> confirmung, it seems, print dialog follows Locale settings from Menu
> Tools/Options.../Language Settings/Languages/Locale setting
> 
> with [English (USA)]:
> 
> Version: 6.3.0.4 (x64)
> Build ID: 057fc023c990d676a43019934386b85b21a9ee99
> CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
> Locale: en-US (de_DE); UI-Language: en-US
> Calc: 
> 
> print dialog shows "in"
> 
> and with [English (Canada)]:
> 
> Version: 6.3.0.4 (x64)
> Build ID: 057fc023c990d676a43019934386b85b21a9ee99
> CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
> Locale: en-CA (de_DE); UI-Language: en-US
> Calc: 
> 
> it shows "mm".
> 
> but i am not sure, if this is a bug, cause one can change the "Measurement
> Unit" separat for each component (writer, calc).

I can confirm that setting the locale under 'Language Settings' changes the
default measurement units for the program, however setting the application
(Calc, Writer, ...) locale does not change the units in the print dialogue - it
seems to only look at the 'Language Settings', not the application specific
settings. 
Agreed - Not necessarily a bug. This may be by design so that 'print' dialogue
is unaffected by application setting and always shows print size according to
locale. Seeing page sizes in 'point' or 'pica' may not be desirable.
Marking as 'Resolved'

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126819] Can't retrieve the mouse position written in the statusbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126819

Noel Grandin  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126819] Can't retrieve the mouse position written in the statusbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126819

--- Comment #5 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/c53f3f8f58f55d0978fb968446975856d72a52f8%5E%21

tdf#126819 Can't retrieve the mouse position written in the statusbar

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svx sd/source svx/source sw/source

[Noel Grandin (via logerrit)]

 include/svx/pszctrl.hxx |2 ++
 include/svx/zoomctrl.hxx|2 ++
 sd/source/ui/app/tmplctrl.cxx   |1 -
 svx/source/stbctrls/insctrl.cxx |1 -
 svx/source/stbctrls/pszctrl.cxx |   31 +--
 svx/source/stbctrls/zoomctrl.cxx|   12 
 sw/source/uibase/utlui/bookctrl.cxx |1 -
 sw/source/uibase/utlui/tmplctrl.cxx |1 -
 sw/source/uibase/utlui/zoomctrl.cxx |6 +-
 9 files changed, 38 insertions(+), 19 deletions(-)

New commits:
commit c53f3f8f58f55d0978fb968446975856d72a52f8
Author: Noel Grandin 
AuthorDate: Fri Aug 16 15:33:15 2019 +0200
Commit: Noel Grandin 
CommitDate: Fri Aug 16 21:40:17 2019 +0200

tdf#126819 Can't retrieve the mouse position written in the statusbar

regression from
commit 77e260f915e0c77ddb1e915e9fd27ab0bdccc763
Date:   Mon Jul 8 11:22:12 2019 +0200
tdf#121793 speedup VCLXAccessibleStatusBarItem::GetItemText

Make the custom StatusBarControls set better text on their parent
StatusBar. Also remove some unnecessary work being done in the Paint
methods, to reduce confusion.

Change-Id: I3b0a0af3b01d3b01f85ab335a3eb5993c07a50f4
Reviewed-on: https://gerrit.libreoffice.org/77586
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/svx/pszctrl.hxx b/include/svx/pszctrl.hxx
index d22e0ba05d18..faf8923d94cc 100644
--- a/include/svx/pszctrl.hxx
+++ b/include/svx/pszctrl.hxx
@@ -39,6 +39,8 @@ public:
 virtual voidStateChanged( sal_uInt16 nSID, SfxItemState eState, const 
SfxPoolItem* pState ) override;
 virtual voidPaint( const UserDrawEvent& rEvt ) override;
 virtual voidCommand( const CommandEvent& rCEvt ) override;
+private:
+void ImplUpdateItemText();
 };
 
 #endif
diff --git a/include/svx/zoomctrl.hxx b/include/svx/zoomctrl.hxx
index afd3130e2c20..e0daa4b971ca 100644
--- a/include/svx/zoomctrl.hxx
+++ b/include/svx/zoomctrl.hxx
@@ -40,6 +40,8 @@ public:
 
 SvxZoomStatusBarControl( sal_uInt16 nSlotId, sal_uInt16 nId, StatusBar& 
rStb );
 
+private:
+void ImplUpdateItemText();
 };
 
 class SVX_DLLPUBLIC SvxZoomPageStatusBarControl : public SfxStatusBarControl
diff --git a/sd/source/ui/app/tmplctrl.cxx b/sd/source/ui/app/tmplctrl.cxx
index 2c27db05bafb..c78f1a3ef126 100644
--- a/sd/source/ui/app/tmplctrl.cxx
+++ b/sd/source/ui/app/tmplctrl.cxx
@@ -89,7 +89,6 @@ void SdTemplateControl::StateChanged(
 
 void SdTemplateControl::Paint( const UserDrawEvent&  )
 {
-GetStatusBar().SetItemText( GetId(), msTemplate );
 }
 
 void SdTemplateControl::Command( const CommandEvent& rCEvt )
diff --git a/svx/source/stbctrls/insctrl.cxx b/svx/source/stbctrls/insctrl.cxx
index 952f82332f8e..eaad418e4909 100644
--- a/svx/source/stbctrls/insctrl.cxx
+++ b/svx/source/stbctrls/insctrl.cxx
@@ -65,7 +65,6 @@ void SvxInsertStatusBarControl::StateChanged( sal_uInt16 , 
SfxItemState eState,
 
 void SvxInsertStatusBarControl::Paint( const UserDrawEvent& )
 {
-DrawItemText_Impl();
 }
 
 void SvxInsertStatusBarControl::DrawItemText_Impl()
diff --git a/svx/source/stbctrls/pszctrl.cxx b/svx/source/stbctrls/pszctrl.cxx
index 474ca2c81f0d..06877c8f06e4 100644
--- a/svx/source/stbctrls/pszctrl.cxx
+++ b/svx/source/stbctrls/pszctrl.cxx
@@ -231,6 +231,7 @@ SvxPosSizeStatusBarControl::SvxPosSizeStatusBarControl( 
sal_uInt16 _nSlotId,
 addStatusListener( STR_POSITION); // SID_ATTR_POSITION
 addStatusListener( STR_TABLECELL);   // SID_TABLE_CELL
 addStatusListener( STR_FUNC);// SID_PSZ_FUNCTION
+ImplUpdateItemText();
 }
 
 /*  [Description]
@@ -334,12 +335,7 @@ void SvxPosSizeStatusBarControl::StateChanged( sal_uInt16 
nSID, SfxItemState eSt
 
 GetStatusBar().SetItemData( GetId(), nullptr );
 
-//  set only strings as text at the statusBar, so that the Help-Tips
-//  can work with the text, when it is too long for the statusBar
-OUString aText;
-if ( pImpl->bTable )
-aText = pImpl->aStr;
-GetStatusBar().SetItemText( GetId(), aText );
+ImplUpdateItemText();
 }
 
 
@@ -461,4 +457,27 @@ void SvxPosSizeStatusBarControl::Paint( const 
UserDrawEvent& rUsrEvt )
 pDev->SetFillColor( aOldFillColor );
 }
 
+void SvxPosSizeStatusBarControl::ImplUpdateItemText()
+{
+//  set only strings as text at the statusBar, so that the Help-Tips
+//  can work with the text, when it is too long for the statusBar
+OUString aText;
+if ( pImpl->bPos || pImpl->bSize )
+{
+aText = GetMetricStr_Impl( pImpl->aPos.X());
+aText += " / ";
+aText += GetMetricStr_Impl( pImpl->aPos.Y());
+if ( pImpl->bSize )
+{
+aText += " ";
+aText += GetMetricStr_Impl( pImpl->aSize.Width() );
+aText += " x ";
+aText += GetMetricStr_Impl( pImpl->aSize.Height() );
+}
+}
+else if ( pImpl->bTable )
+   aText = pImpl->aStr;
+
+GetStatusBar().SetItemText( 

[Libreoffice-bugs] [Bug 126819] Can't retrieve the mouse position written in the statusbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126819

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125340] CRASH: closing LibreOffice while migration dialog is open ( GTK3 )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125340

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: stoc/test

[Stephan Bergmann (via logerrit)]

 stoc/test/uriproc/test_uriproc.cxx |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit db7701a3072117e9808e73bc3a071b236daacfc5
Author: Stephan Bergmann 
AuthorDate: Fri Aug 16 16:44:38 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Aug 16 21:22:35 2019 +0200

Fix tests taken from RFC 2396

"/g" was missing, and "http:g" had an extra "." (consistently applied to all
three occurrences of "http", but for unclear reasons).

( claims that "?y" is an invalid
example that should be removed, but our algorithm does resolve it to the 
value
 originally given in RFC 2396, so lets keep it for now.)

Change-Id: I3187abd36135723bd13293367a6cb6c06ca70b90
Reviewed-on: https://gerrit.libreoffice.org/77602
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/stoc/test/uriproc/test_uriproc.cxx 
b/stoc/test/uriproc/test_uriproc.cxx
index 7b30dd84375f..dbf095a3bd04 100644
--- a/stoc/test/uriproc/test_uriproc.cxx
+++ b/stoc/test/uriproc/test_uriproc.cxx
@@ -300,6 +300,8 @@ void Test::testMakeAbsolute() {
   css::uri::RelativeUriExcessParentSegments_ERROR, "http://a/b/c/g; },
 { "http://a/b/c/d;p?q;, "g/", true,
   css::uri::RelativeUriExcessParentSegments_ERROR, "http://a/b/c/g/; },
+{ "http://a/b/c/d;p?q;, "/g", true,
+  css::uri::RelativeUriExcessParentSegments_ERROR, "http://a/g; },
 { "http://a/b/c/d;p?q;, "//g", true,
   css::uri::RelativeUriExcessParentSegments_ERROR, "http://g; },
 { "http://a/b/c/d;p?q;, "?y", true,
@@ -396,8 +398,8 @@ void Test::testMakeAbsolute() {
 { "http://a/b/c/d;p?q;, "g#s/../x", true,
   css::uri::RelativeUriExcessParentSegments_ERROR,
   "http://a/b/c/g#s/../x; },
-{ "http.://a/b/c/d;p?q", "http.:g", true,
-  css::uri::RelativeUriExcessParentSegments_ERROR, "http.:g" },
+{ "http://a/b/c/d;p?q;, "http:g", true,
+  css::uri::RelativeUriExcessParentSegments_ERROR, "http:g" },
 
 { "scheme://a", "", true,
   css::uri::RelativeUriExcessParentSegments_ERROR, "scheme://a" },
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103182
Bug 103182 depends on bug 126844, which changed state.

Bug 126844 Summary: Find & Replace Dialog no longer permits me to format 
"Replace" text. (GTK3)
https://bugs.documentfoundation.org/show_bug.cgi?id=126844

   What|Removed |Added

 Status|VERIFIED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

[Eike Rathke (via logerrit)]

 sc/source/ui/docshell/docsh.cxx  |   13 --
 sc/source/ui/docshell/docsh4.cxx |   67 ---
 sc/source/ui/docshell/externalrefmgr.cxx |8 +++
 sc/source/ui/inc/docsh.hxx   |2 
 4 files changed, 56 insertions(+), 34 deletions(-)

New commits:
commit 54bf84746a2a9a2e2aaf0df9e429b0cfd538f640
Author: Eike Rathke 
AuthorDate: Fri Aug 16 15:36:15 2019 +0200
Commit: Eike Rathke 
CommitDate: Fri Aug 16 21:00:26 2019 +0200

Resolves: tdf#126928 allow link updates in an intermediate linked document

... if link updates are allowed in the current document and that
intermediate document resides in a trusted location.

This works with both, the "Always (from trusted locations)" and
the "On request" settings under Tools -> Options -> Calc ->
General. It can't work with documents residing in a non-trusted
location as there is no way to allow updates on demand for a such
loaded document (hidden via formulas).

Change-Id: Ie483f7743db7c6d5cf947dc16a9c3660855f3423
Reviewed-on: https://gerrit.libreoffice.org/77588
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/sc/source/ui/docshell/docsh.cxx b/sc/source/ui/docshell/docsh.cxx
index ad8d664dd690..6859942b79d4 100644
--- a/sc/source/ui/docshell/docsh.cxx
+++ b/sc/source/ui/docshell/docsh.cxx
@@ -582,15 +582,22 @@ bool ScDocShell::Load( SfxMedium& rMedium )
 bool bRet = SfxObjectShell::Load(rMedium);
 if (bRet)
 {
-comphelper::EmbeddedObjectContainer& rEmbeddedObjectContainer = 
getEmbeddedObjectContainer();
-rEmbeddedObjectContainer.setUserAllowsLinkUpdate(false);
-
 if (GetMedium())
 {
 const SfxUInt16Item* pUpdateDocItem = 
SfxItemSet::GetItem(rMedium.GetItemSet(), SID_UPDATEDOCMODE, 
false);
 m_nCanUpdate = pUpdateDocItem ? pUpdateDocItem->GetValue() : 
css::document::UpdateDocMode::NO_UPDATE;
 }
 
+// GetLinkUpdateModeState() evaluates m_nCanUpdate so that must have
+// been set first. Do not override an already forbidden LinkUpdate (the
+// default is allow).
+comphelper::EmbeddedObjectContainer& rEmbeddedObjectContainer = 
getEmbeddedObjectContainer();
+if (rEmbeddedObjectContainer.getUserAllowsLinkUpdate())
+{
+// For anything else than LM_ALWAYS we need user confirmation.
+rEmbeddedObjectContainer.setUserAllowsLinkUpdate( 
GetLinkUpdateModeState() == LM_ALWAYS);
+}
+
 {
 //  prepare a valid document for XML filter
 //  (for ConvertFrom, InitNew is called before)
diff --git a/sc/source/ui/docshell/docsh4.cxx b/sc/source/ui/docshell/docsh4.cxx
index a46aac7147ba..c83a3f154f72 100644
--- a/sc/source/ui/docshell/docsh4.cxx
+++ b/sc/source/ui/docshell/docsh4.cxx
@@ -144,6 +144,41 @@ IMPL_LINK_NOARG( ScDocShell, ReloadAllLinksHdl, Button*, 
void )
 SAL_WARN_IF(!pViewFrame, "sc", "expected there to be a ViewFrame");
 }
 
+ScLkUpdMode ScDocShell::GetLinkUpdateModeState() const
+{
+const ScDocument& rDoc = GetDocument();
+
+ScLkUpdMode nSet = rDoc.GetLinkMode();
+
+if (nSet == LM_UNKNOWN)
+{
+ScAppOptions aAppOptions = SC_MOD()->GetAppOptions();
+nSet = aAppOptions.GetLinkMode();
+}
+
+if (m_nCanUpdate == css::document::UpdateDocMode::NO_UPDATE)
+nSet = LM_NEVER;
+else if (m_nCanUpdate == css::document::UpdateDocMode::FULL_UPDATE)
+nSet = LM_ALWAYS;
+
+if (nSet == LM_ALWAYS
+&& !(SvtSecurityOptions().isTrustedLocationUriForUpdatingLinks(
+GetMedium() == nullptr ? OUString() : 
GetMedium()->GetName())
+|| (IsDocShared()
+&& 
SvtSecurityOptions().isTrustedLocationUriForUpdatingLinks(
+GetSharedFileURL()
+{
+nSet = LM_ON_DEMAND;
+}
+if (m_nCanUpdate == css::document::UpdateDocMode::QUIET_UPDATE
+&& nSet == LM_ON_DEMAND)
+{
+nSet = LM_NEVER;
+}
+
+return nSet;
+}
+
 void ScDocShell::Execute( SfxRequest& rReq )
 {
 const SfxItemSet* pReqArgs = rReq.GetArgs();
@@ -441,37 +476,7 @@ void ScDocShell::Execute( SfxRequest& rReq )
 break;
 case SID_UPDATETABLINKS:
 {
-ScDocument& rDoc = GetDocument();
-
-ScLkUpdMode nSet = rDoc.GetLinkMode();
-
-if(nSet==LM_UNKNOWN)
-{
-ScAppOptions aAppOptions=SC_MOD()->GetAppOptions();
-nSet=aAppOptions.GetLinkMode();
-}
-
-if (m_nCanUpdate == css::document::UpdateDocMode::NO_UPDATE)
-nSet = LM_NEVER;
-else if (m_nCanUpdate == 
css::document::UpdateDocMode::FULL_UPDATE)
-nSet = LM_ALWAYS;
-
-if (nSet == LM_ALWAYS
-&& !(SvtSecurityOptions()
-  

[Libreoffice-commits] core.git: sw/qa sw/source

[Mike Kaganski (via logerrit)]

 sw/qa/extras/unowriter/unowriter.cxx |   23 +++
 sw/source/core/unocore/unoobj.cxx|   12 ++--
 2 files changed, 29 insertions(+), 6 deletions(-)

New commits:
commit 6dc0f6b65e79ca4af69338411e3887d9aaef1cac
Author: Mike Kaganski 
AuthorDate: Fri Aug 16 15:04:15 2019 +0200
Commit: Mike Kaganski 
CommitDate: Fri Aug 16 20:46:06 2019 +0200

This was meant to be 'continue', not 'break'

... when commit ee0bf5d58bc59052923c4ced928a989956e71456 had introduced
SwUnoCursorHelper::SetPropertyValues, and the intent obviously was to
skip bad values, populating relevant error messages, and set all correct
values.

Change-Id: Id699f74a9df179c810608400983f88db1a7164b8
Reviewed-on: https://gerrit.libreoffice.org/77584
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sw/qa/extras/unowriter/unowriter.cxx 
b/sw/qa/extras/unowriter/unowriter.cxx
index e819cb9d7d7d..ffb57d836f48 100644
--- a/sw/qa/extras/unowriter/unowriter.cxx
+++ b/sw/qa/extras/unowriter/unowriter.cxx
@@ -621,6 +621,29 @@ CPPUNIT_TEST_FIXTURE(SwUnoWriter, testViewCursorPageStyle)
 CPPUNIT_ASSERT_EQUAL(OUString("Standard"), aActualPageStyleName);
 }
 
+CPPUNIT_TEST_FIXTURE(SwUnoWriter, testXTextCursor_setPropertyValues)
+{
+// Create a new document, type a character, pass a set of property/value 
pairs consisting of one
+// unknown property and CharStyleName, assert that it threw 
UnknownPropertyException (actually
+// wrapped into WrappedTargetException), and assert the style was set, not 
discarded.
+loadURL("private:factory/swriter", nullptr);
+
+uno::Reference xTextDocument(mxComponent, 
uno::UNO_QUERY);
+uno::Reference xBodyText = xTextDocument->getText();
+xBodyText->insertString(xBodyText->getStart(), "x", false);
+
+uno::Reference xCursor(xBodyText->createTextCursor());
+xCursor->goLeft(1, true);
+
+uno::Reference xCursorProps(xCursor, 
uno::UNO_QUERY);
+uno::Sequence aPropNames = { "OneUnknownProperty", 
"CharStyleName" };
+uno::Sequence aPropValues = { uno::Any(), 
uno::Any(OUString("Emphasis")) };
+CPPUNIT_ASSERT_THROW(xCursorProps->setPropertyValues(aPropNames, 
aPropValues),
+ lang::WrappedTargetException);
+CPPUNIT_ASSERT_EQUAL(OUString("Emphasis"),
+ getProperty(xCursorProps, "CharStyleName"));
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/unocore/unoobj.cxx 
b/sw/source/core/unocore/unoobj.cxx
index 7da731df197a..0b1b3c78b083 100644
--- a/sw/source/core/unocore/unoobj.cxx
+++ b/sw/source/core/unocore/unoobj.cxx
@@ -1784,7 +1784,7 @@ void SwUnoCursorHelper::SetPropertyValues(
 
 // Build set of attributes we want to fetch
 std::vector aWhichPairs;
-std::vector aEntries;
+std::vector> 
aEntries;
 aEntries.reserve(rPropertyValues.getLength());
 for (const auto& rPropVal : rPropertyValues)
 {
@@ -1797,18 +1797,18 @@ void SwUnoCursorHelper::SetPropertyValues(
 if (!pEntry)
 {
 aUnknownExMsg += "Unknown property: '" + rPropertyName + "' ";
-break;
+continue;
 }
 else if (pEntry->nFlags & beans::PropertyAttribute::READONLY)
 {
 aPropertyVetoExMsg += "Property is read-only: '" + rPropertyName + 
"' ";
-break;
+continue;
 } else {
 // FIXME: we should have some nice way of merging ranges surely ?
 aWhichPairs.push_back(pEntry->nWID);
 aWhichPairs.push_back(pEntry->nWID);
 }
-aEntries.push_back(pEntry);
+aEntries.emplace_back(pEntry, rPropVal.Value);
 }
 
 if (!aWhichPairs.empty())
@@ -1821,7 +1821,7 @@ void SwUnoCursorHelper::SetPropertyValues(
 bool bPreviousPropertyCausesSideEffectsInNodes = false;
 for (size_t i = 0; i < aEntries.size(); ++i)
 {
-SfxItemPropertySimpleEntry const*const pEntry = aEntries[i];
+SfxItemPropertySimpleEntry const*const pEntry = aEntries[i].first;
 bool bPropertyCausesSideEffectsInNodes =
 propertyCausesSideEffectsInNodes(pEntry->nWID);
 
@@ -1832,7 +1832,7 @@ void SwUnoCursorHelper::SetPropertyValues(
 SwUnoCursorHelper::GetCursorAttr(rPaM, aItemSet);
 }
 
-const uno::Any  = rPropertyValues[i].Value;
+const uno::Any  = aEntries[i].second;
 // this can set some attributes in nodes' mpAttrSet
 if (!SwUnoCursorHelper::SetCursorPropertyValue(*pEntry, rValue, 
rPaM, aItemSet))
 rPropSet.setPropertyValue(*pEntry, rValue, aItemSet);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: We'd like to continue the production of the 32-bit deb packages

[dreamn...@gmail.com]

Finally sort of solved.

We were not able to get ‘make’ without cppunit errors. Tried numerous times
on VMs with Escuelas Linux and Bodhi Linux (both based on Ubuntu 18.04) and
on Debian 10 (on a VM and on a schroot environment).

What we did if after a ‘make’ with errors, we had to ran ‘make
build-nocheck’ to be able to bypass those errors on a Debian 10 schroot
environment. This time, the required debs files were produced. However,
when installing those debs and trying to run LibreOffice on Escuelas Linux
(the main target distribution) it does not work, as it complains about a
glibc mismatch version. So, it seems that the generated deb files are not
distribution-independent as the ones that were previously released by The
Document Foundation.

Under these circumstances, we then proceeded to create the deb files inside
a Escuelas Linux VM.

In Escuelas Linux (and I guess on any Ubuntu 18.04 system) the command

sudo apt-get build-dep libreoffice

does not install all the required packages to pass the autogen.sh phase, as
we found to be the case in Debian 10. It complains about missing KF5 stuff,
so we installed these (some packages might not be necessary, but at least
this worked)


sudo apt-get install \

 libkf5archive-dev libkf5bookmarks-dev libkf5coreaddons-dev libkf5config-dev \
 libkf5configwidgets-dev libkf5dbusaddons-dev libkf5kio-dev
libkf5widgetsaddons-dev \
 libkf5notifyconfig-dev libkf5newstuff-dev libkf5xmlgui-dev
libkf5declarative-dev \
 libkf5notifications-dev libkf5guiaddons-dev libkf5textwidgets-dev
libkf5iconthemes-dev \
 kdoctools-dev libkf5crash-dev libkf5filemetadata-dev extra-cmake-modules \
 libsm-dev cmake qtdeclarative5-dev kde-runtime kinit  kio \
 qml-module-qtquick-controls

We also had to install qt5-default and libqt5x11extras5-dev.

Just to be sure, we also installed IBM Java, as it is the one used in
Escuelas Linux. Other Java environments have an ugly effect specifically on
LibreOffice 32-bit, as we reported at the time on our blog:

https://sourceforge.net/p/escuelaslinux/blog/2019/03/how-to-fix-libreoffice-startup-crashes-in-escuelas-linux-62-32-bit/

However, switching our distribution to IBM Java solved those issues in a
better way than passing stack_guard_gap=1.

Our autogen.input is:

*--with-distro=LibreOfficeLinux**--disable-gstreamer-0-10**--with-lang=es**--with-myspell-dicts**--enable-release-build**--with-package-format=deb**--disable-dependency-tracking**--with-jdk-home=/usr/lib/jvm/**ibm-java90-jdk-i386**/*

Again, after we got a ‘make’ with errors, we had to ran ‘make
build-nocheck’ to be able to bypass those. The deb files were produced and
seem to be working fine when installed on Escuelas Linux.

As the resulting .deb files does not seem to be distribution independent,
we may not be offering then to download in our SourceForge site as we
planned. If as time passes somebody knows how to solve the make errors we
get, and how to release distro-independent deb packages, we might then
offer LibreOffice 32-bit binary deb builts available for download, for
parties that might be still interested on them.

For now, I’m happy to announce that our upcoming Escuelas Linux version
6.5, will include, among other things, LibreOffice 6.3.0.4 in both of our
editions, 32-bit and 64-bit.

Many thanks to all the folks that helped us in this thread. I owe you a big
beer ;-)

https://sourceforge.net/projects/escuelaslinux/

https://www.facebook.com/escuelas.linux



El vie., 26 jul. 2019 a las 10:01, dreamn...@gmail.com ()
escribió:

> Hi! Greetings from the Escuelas Linux team. We are small Linux
> distribution that can be downloaded from
> https://sourceforge.net/projects/escuelaslinux/.
> Some more references about our activity can be found by doing an Internet
> search, or on own Facebook account, escuelas.linux
>
> We still provide a 32-bit edition of our distro, because among our users
> there are a lot of low-income public schools, in which are still in use old
> computers with about 512 MB to a 1 GB of RAM. That amount of RAM would make
> running a Linux 64-bit system awfully slow, so we have to accommodate to
> the needs and possibilities of what is available in poor areas, those in
> which even having an old computer is still somehow a luxury.
>
> We perfectly understand that TDF releasing 32-bit Linux LibreOffice
> packages was not worth anymore, given the small amount of downloads.
> Certainly some of those downloads were made by us, as we only required one
> download of a given LibreOffice version to have it installed in our distro
> and be used in hundreds of computers. A lot of those computers could not
> even be traceable, since there are no Internet connection in poor or remote
> schools. But we believe that even if we reported who and where are those
> schools, that would be still a small amount to be worth the effort and
> resources required to match the bigger amounts of downloads that seems to
> be receiving the LibreOffice 32-bit Windows counterpart.
>
> 

[Libreoffice-bugs] [Bug 123753] Libreoffice writer and calc freeze from 30 seconds to 2 minutes.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123753

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #12 from Buovjaga  ---
Thanks, I guess we should close this for now as you suspect other software
might contribute to the resource problem

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: compilerplugins/clang solenv/CompilerTest_compilerplugins_clang.mk

[Stephan Bergmann (via logerrit)]

 compilerplugins/clang/nullptr.cxx|8 
 compilerplugins/clang/test/nullptr.cxx   |   23 +++
 solenv/CompilerTest_compilerplugins_clang.mk |1 +
 3 files changed, 32 insertions(+)

New commits:
commit e380e353485c3479abe645d3b6da9e007057a079
Author: Stephan Bergmann 
AuthorDate: Fri Aug 16 16:25:48 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Aug 16 19:54:25 2019 +0200

Adapt loplugin:nullptr to RecursiveASTVisitior::TraverseInitListExpr change

... "[AST] Treat semantic form of
InitListExpr as implicit code in traversals"

Change-Id: Ifd17009fcc6933abf0e9178dbe47fb9c14b274b7
Reviewed-on: https://gerrit.libreoffice.org/77595
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/nullptr.cxx 
b/compilerplugins/clang/nullptr.cxx
index bcdf606c13e3..30458d7f7f5a 100644
--- a/compilerplugins/clang/nullptr.cxx
+++ b/compilerplugins/clang/nullptr.cxx
@@ -75,6 +75,8 @@ public:
 
 bool TraverseLinkageSpecDecl(LinkageSpecDecl * decl);
 
+bool TraverseInitListExpr(InitListExpr * expr, DataRecursionQueue * queue 
= nullptr);
+
 // bool shouldVisitTemplateInstantiations() const { return true; }
 
 private:
@@ -231,6 +233,12 @@ bool Nullptr::TraverseLinkageSpecDecl(LinkageSpecDecl * 
decl) {
 return ret;
 }
 
+bool Nullptr::TraverseInitListExpr(InitListExpr * expr, DataRecursionQueue * 
queue) {
+return WalkUpFromInitListExpr(expr)
+&& TraverseSynOrSemInitListExpr(
+expr->isSemanticForm() ? expr : expr->getSemanticForm(), queue);
+}
+
 bool Nullptr::isInLokIncludeFile(SourceLocation spellingLocation) const {
 return loplugin::hasPathnamePrefix(
 getFileNameOfSpellingLoc(spellingLocation),
diff --git a/compilerplugins/clang/test/nullptr.cxx 
b/compilerplugins/clang/test/nullptr.cxx
new file mode 100644
index ..bf7376cb6562
--- /dev/null
+++ b/compilerplugins/clang/test/nullptr.cxx
@@ -0,0 +1,23 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+struct S
+{
+void* p;
+};
+
+int main()
+{
+S s{
+0 // expected-error {{NullToPointer ValueDependentIsNotNull 
ZeroLiteral -> nullptr [loplugin:nullptr]}}
+};
+(void)s;
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/solenv/CompilerTest_compilerplugins_clang.mk 
b/solenv/CompilerTest_compilerplugins_clang.mk
index 711137705ba3..caeee4333e78 100644
--- a/solenv/CompilerTest_compilerplugins_clang.mk
+++ b/solenv/CompilerTest_compilerplugins_clang.mk
@@ -36,6 +36,7 @@ $(eval $(call 
gb_CompilerTest_add_exception_objects,compilerplugins_clang, \
 compilerplugins/clang/test/indentation \
 compilerplugins/clang/test/logexceptionnicely \
 compilerplugins/clang/test/loopvartoosmall \
+compilerplugins/clang/test/nullptr \
 compilerplugins/clang/test/mapindex \
 compilerplugins/clang/test/oncevar \
 compilerplugins/clang/test/oslendian-1 \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: stoc/CppunitTest_stoc_uriproc.mk stoc/Module_stoc.mk stoc/test

[Stephan Bergmann (via logerrit)]

 stoc/CppunitTest_stoc_uriproc.mk   |   26 
 stoc/Module_stoc.mk|4 
 stoc/test/uriproc/test_uriproc.cxx |  217 ++---
 3 files changed, 139 insertions(+), 108 deletions(-)

New commits:
commit 91e213f58f264f110c6a94c1c18c00333e6fcdf6
Author: Stephan Bergmann 
AuthorDate: Fri Aug 16 14:10:51 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Aug 16 19:44:33 2019 +0200

Re-enable stoc/test/uriproc/

...which had gone missing with d2097ad456b4626dd6972e015489ce3d22eb1872
"gbuildize stoc".  Required lots of loplugin warning fixes now.

Change-Id: I411034f462846557f72ea1e9a91cd88517d2944c
Reviewed-on: https://gerrit.libreoffice.org/77579
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/stoc/CppunitTest_stoc_uriproc.mk b/stoc/CppunitTest_stoc_uriproc.mk
new file mode 100644
index ..6ca328edc39a
--- /dev/null
+++ b/stoc/CppunitTest_stoc_uriproc.mk
@@ -0,0 +1,26 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t; fill-column: 
100 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_CppunitTest_CppunitTest,stoc_uriproc))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,stoc_uriproc, \
+stoc/test/uriproc/test_uriproc \
+))
+
+$(eval $(call gb_CppunitTest_use_libraries,stoc_uriproc, \
+cppu \
+cppuhelper \
+sal \
+))
+
+$(eval $(call gb_CppunitTest_use_udk_api,stoc_uriproc))
+
+$(eval $(call gb_CppunitTest_use_ure,stoc_uriproc))
+
+# vim: set noet sw=4 ts=4:
diff --git a/stoc/Module_stoc.mk b/stoc/Module_stoc.mk
index 7c77f6b3dc39..d05c53d55fd3 100644
--- a/stoc/Module_stoc.mk
+++ b/stoc/Module_stoc.mk
@@ -29,4 +29,8 @@ $(eval $(call gb_Module_add_targets,stoc,\
 
 endif
 
+$(eval $(call gb_Module_add_check_targets,stoc, \
+CppunitTest_stoc_uriproc \
+))
+
 # vim:set noet sw=4 ts=4:
diff --git a/stoc/test/uriproc/test_uriproc.cxx 
b/stoc/test/uriproc/test_uriproc.cxx
index fe8178d0d1d2..7b30dd84375f 100644
--- a/stoc/test/uriproc/test_uriproc.cxx
+++ b/stoc/test/uriproc/test_uriproc.cxx
@@ -32,10 +32,10 @@
 #include 
 #include 
 #include 
-#include "cppunit/TestAssert.h"
-#include "cppunit/TestFixture.h"
-#include "cppunit/extensions/HelperMacros.h"
-#include "cppunit/plugin/TestPlugIn.h"
+#include 
+#include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -49,11 +49,11 @@
 namespace {
 
 #define TEST_ASSERT_EQUAL(token1, token2, token3, expected, actual) \
-CPPUNIT_ASSERT_MESSAGE( \
+CPPUNIT_ASSERT_EQUAL_MESSAGE( \
 createTestAssertEqualMessage( \
 token1, token2, token3, #expected, #actual, expected, actual). \
 getStr(), \
-(actual) == (expected))
+(expected), (actual))
 
 template< typename T > void append(
 OUStringBuffer & buffer, T const & value)
@@ -62,7 +62,7 @@ template< typename T > void append(
 }
 
 template<> void append(OUStringBuffer & buffer, bool const & value) {
-buffer.append(static_cast< sal_Bool >(value));
+buffer.append(value);
 }
 
 template<> void append(OUStringBuffer & buffer, std::size_t const & value)
@@ -165,37 +165,37 @@ void Test::testParse() {
 char const * fragment;
 };
 Data data[] = {
-{ "", 0, "", true, 0,
-  "", true, 0, "", "", "", "", "", 0, 0 },
-{ "scheme:", 0, 0, false, 0,
-  0, false, 0, 0, 0, 0, 0, 0, 0, 0 },
-{ "scheme:/", "scheme", "/", true, 0,
-  "/", false, 1, "", "", "", "", "", 0, 0 },
+{ "", nullptr, "", true, nullptr,
+  "", true, 0, "", "", "", "", "", nullptr, nullptr },
+{ "scheme:", nullptr, nullptr, false, nullptr,
+  nullptr, false, 0, nullptr, nullptr, nullptr, nullptr, nullptr, 
nullptr, nullptr },
+{ "scheme:/", "scheme", "/", true, nullptr,
+  "/", false, 1, "", "", "", "", "", nullptr, nullptr },
 { "scheme://", "scheme", "//", true, "",
-  "", false, 0, "", "", "", "", "", 0, 0 },
+  "", false, 0, "", "", "", "", "", nullptr, nullptr },
 { "scheme:///", "scheme", "///", true, "",
-  "/", false, 1, "", "", "", "", "", 0, 0 },
+  "/", false, 1, "", "", "", "", "", nullptr, nullptr },
 { "scheme:", "scheme", "", true, "",
-  "//", false, 2, "", "", "", "", "", 0, 0 },
+  "//", false, 2, "", "", "", "", "", nullptr, nullptr },
 { "scheme:", "scheme", "", true, "",
-  "//", false, 2, "", "", "", "", "", 0, 0 },
-{ "scheme:#", 0, 0, false, 0,
-  0, false, 0, 0, 0, 0, 0, 0, 0, 0 },
-{ "scheme:?", "scheme", "?", false, 0,
-  "?", false, 0, "", "", "", "", "", 0, 0 },
-{ "/", 0, "/", true, 0,
-  "/", false, 1, "", "", "", "", "", 

[Libreoffice-bugs] [Bug 126877] crash on inserting floating frame

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126877

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126877] crash on inserting floating frame

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126877

Noel Grandin  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126877] crash on inserting floating frame

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126877

--- Comment #3 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/23f60bbf283414bae6f649992c18253c9d0ac2ab%5E%21

tdf#126877 crash on inserting floating frame

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: embeddedobj/source

[Noel Grandin (via logerrit)]

 embeddedobj/source/commonembedding/embedobj.cxx |   31 +++-
 1 file changed, 25 insertions(+), 6 deletions(-)

New commits:
commit 23f60bbf283414bae6f649992c18253c9d0ac2ab
Author: Noel Grandin 
AuthorDate: Fri Aug 16 14:16:36 2019 +0200
Commit: Noel Grandin 
CommitDate: Fri Aug 16 19:35:43 2019 +0200

tdf#126877 crash on inserting floating frame

regression from
commit 5043421fdc527d18d18121ec5fe2d4e009c8191a
Date:   Fri Jul 19 14:05:10 2019 +0200
loplugin:referencecasting in embeddedobj

OSpecialEmbeddedObject is playing games and effectively "unimplementing"
an interface it's superclass implements by doing custom stuff in
OSpecialEmbeddedObject::queryInterface.

So lets rather implement this in a more direct and obvious way.

Change-Id: I341b8e0b6acafac80cbd55f745811b73d2593585
Reviewed-on: https://gerrit.libreoffice.org/77580
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/embeddedobj/source/commonembedding/embedobj.cxx 
b/embeddedobj/source/commonembedding/embedobj.cxx
index a34020d354e1..3370c273dc6a 100644
--- a/embeddedobj/source/commonembedding/embedobj.cxx
+++ b/embeddedobj/source/commonembedding/embedobj.cxx
@@ -50,6 +50,7 @@
 #include 
 #include 
 #include "embedobj.hxx"
+#include 
 
 using namespace ::com::sun::star;
 
@@ -174,13 +175,31 @@ void OCommonEmbeddedObject::SwitchStateTo_Impl( sal_Int32 
nNextState )
 }
 else
 {
-// in case embedded object is in loaded state the contents must
-// be stored in the related storage and the storage
-// must be created already
-if ( !m_xObjectStorage.is() )
-   throw io::IOException(); //TODO: access denied
+if ( !dynamic_cast(this) )
+{
+// in case embedded object is in loaded state the contents 
must
+// be stored in the related storage and the storage
+// must be created already
+if ( !m_xObjectStorage.is() )
+throw io::IOException(); //TODO: access denied
 
-m_xDocHolder->SetComponent( LoadDocumentFromStorage_Impl(), 
m_bReadOnly );
+m_xDocHolder->SetComponent( 
LoadDocumentFromStorage_Impl(), m_bReadOnly );
+}
+else
+{
+// objects without persistence will be initialized 
internally
+uno::Sequence < uno::Any > aArgs(1);
+aArgs[0] <<= uno::Reference < embed::XEmbeddedObject >( 
this );
+uno::Reference< util::XCloseable > xDocument(
+
m_xContext->getServiceManager()->createInstanceWithArgumentsAndContext( 
GetDocumentServiceName(), aArgs, m_xContext),
+uno::UNO_QUERY );
+
+uno::Reference < container::XChild > xChild( xDocument, 
uno::UNO_QUERY );
+if ( xChild.is() )
+xChild->setParent( m_xParent );
+
+m_xDocHolder->SetComponent( xDocument, m_bReadOnly );
+}
 }
 
 if ( !m_xDocHolder->GetComponent().is() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107993] FORMATTING: Free space filling broken with thousands separator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107993

--- Comment #7 from Laurent BP  ---
Reproduced with Version: 6.3.0.4
Build ID: 057fc023c990d676a43019934386b85b21a9ee99
Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3; 
Locale : fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR
Calc: threaded

Same bug with format
+*\# ##0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123753] Libreoffice writer and calc freeze from 30 seconds to 2 minutes.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123753

--- Comment #11 from miguel  ---
I upgraded my Win 10 Home pc to LO 6.3.  the non responsiveness continues to
happen but not as bad.  The non response does not last as long; I still get the
lightened screen, with LO not responding at the top, but not quite as long.  LO
6.3 is better than versions 6.2 and 6.1.  

Personally, I think it is the Win 10 Home OS and my hardware.  I don't have or
use MS office or any other MS software; other than what comes with Win 10 Home;
much of the Windows apps I have turned off.  I think Win 10 does not like not
having other Office suite software installed.  I find the problem with LO being
not responding, mostly when I use my Intuit ProSeries Income Tax software;
always causes the LO not responding.  Intuit ProSeries is heavily attached to
IE and Microsoft Windows it seems.  If I use the ProSeries help links in the
software, it wants to only use Internet Explorer or EDGE; been that way for 15
years (began when using TurboTax, which an Intuit product).  

The only other issue/problem that could be causing the issues, that I know of
is:  I use Seamonkey (browser and email) and LO 6.1 portable off of my external
hard drive; for security purposes; most of the time.  LO 6.1 portable works
better than the hard drive installs of LO 6.x.  I don't get as much of the LO
not responding messages; but then again, I am not usually using the Intuit
ProSeries during these times.  The portable LO versions have worked much better
(using thru PortableApps on my external hard drive).  I think Win 10 Home (and
yes, with all current updates installed for Win 10), does not really do well
with some multi-tasking.  the problem with not good multi-tasking may be with
my hardware and Win 10 pc.  

Mostly, I see the LO not responding, when I am using LO from my internal C:
hard drive and my external drive while using my portable apps.

I hope this helps.  But, thankfully, LO 6.3 is working much better with not as
much LO not responding.

Thank you all for your kind and prompt assistance.  You all do such great work.
 God Bless!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: starmath/inc starmath/source

[Andrea Gelmini (via logerrit)]

 starmath/inc/node.hxx |8 
 starmath/source/accessibility.cxx |2 +-
 starmath/source/mathmlimport.cxx  |2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 0b42faf3d09cb4e63feebcd056c7c014c657d404
Author: Andrea Gelmini 
AuthorDate: Wed Jul 31 18:46:37 2019 +0200
Commit: Julien Nabet 
CommitDate: Fri Aug 16 19:22:15 2019 +0200

Fix typos

Change-Id: Id8c879b81cde8da6119ac08d9d9028221486dc6a
Reviewed-on: https://gerrit.libreoffice.org/76764
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/starmath/inc/node.hxx b/starmath/inc/node.hxx
index 73bfb17132c9..845da0a95fc0 100644
--- a/starmath/inc/node.hxx
+++ b/starmath/inc/node.hxx
@@ -117,7 +117,7 @@ public:
 virtual ~SmNode();
 
 /**
- * Returns true if this is a instance of SmVisibleNode's subclass, false 
otherwise.
+ * Returns true if this is an instance of SmVisibleNode's subclass, false 
otherwise.
  */
 virtual boolIsVisible() const = 0;
 
@@ -453,7 +453,7 @@ public:
  *
  * This node is used with commands: oper, uoper and boper.
  * E.g. in "A boper op B", "op" will be an instance of SmGlyphSpecialNode.
- * "boper" simply interprets "op", the following token, as an binary operator.
+ * "boper" simply interprets "op", the following token, as a binary operator.
  * The command "uoper" interprets the following token as unary operator.
  * For these commands an instance of SmGlyphSpecialNode is used for the
  * operator token, following the command.
@@ -560,7 +560,7 @@ public:
 
 /** Error node, for parsing errors
  *
- * This node is used for parsing errors and draws an questionmark turned upside
+ * This node is used for parsing errors and draws a questionmark turned upside
  * down (inverted question mark).
  */
 class SmErrorNode : public SmMathSymbolNode
@@ -582,7 +582,7 @@ public:
  *
  * This is the root node for the formula tree. This node is also used for the
  * STACK and BINOM commands. When used for root node, its
- * children are instances of SmLineNode, and in some obscure cases the a child
+ * children are instances of SmLineNode, and in some obscure cases the child
  * can be an instance of SmExpressionNode, mainly when errors occur.
  */
 class SmTableNode : public SmStructureNode
diff --git a/starmath/source/accessibility.cxx 
b/starmath/source/accessibility.cxx
index 2121f5da59e6..8fb20618c701 100644
--- a/starmath/source/accessibility.cxx
+++ b/starmath/source/accessibility.cxx
@@ -1034,7 +1034,7 @@ static SfxItemState GetSvxEditEngineItemState( EditEngine 
const & rEditEngine, c
 rEditEngine.GetCharAttribs( nPara, aAttribs );
 
 bool bEmpty = true; // we found no item inside the selection of 
this paragraph
-bool bGaps  = false;// we found items but theire gaps between them
+bool bGaps  = false;// we found items but there are gaps between 
them
 sal_Int32 nLastEnd = nPos;
 
 const SfxPoolItem* pParaItem = nullptr;
diff --git a/starmath/source/mathmlimport.cxx b/starmath/source/mathmlimport.cxx
index f49d88ca794b..48de32c3e0bd 100644
--- a/starmath/source/mathmlimport.cxx
+++ b/starmath/source/mathmlimport.cxx
@@ -890,7 +890,7 @@ public:
 };
 
 
-/*avert thy gaze from the proginator*/
+/*avert the gaze from the originator*/
 class SmXMLRowContext_Impl : public SmXMLDocContext_Impl
 {
 protected:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115528] Datetime2 extension gives error in LO 6.0.0.3 (locale-dependent)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115528

Laurent BP  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #14 from Laurent BP  ---
(In reply to vlb from comment #13)
> I have change the func and it works now!
> Thanks for help here to solve it.
As it seems solved, I close this report. Feel free to reopen it if necessary.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107575] [META] Number format bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107575
Bug 107575 depends on bug 115528, which changed state.

Bug 115528 Summary: Datetime2 extension gives error in LO 6.0.0.3 
(locale-dependent)
https://bugs.documentfoundation.org/show_bug.cgi?id=115528

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: starmath/inc starmath/source

[Andrea Gelmini (via logerrit)]

 starmath/inc/cursor.hxx  |4 ++--
 starmath/inc/visitors.hxx|2 +-
 starmath/source/cursor.cxx   |2 +-
 starmath/source/document.cxx |2 +-
 starmath/source/mathtype.cxx |2 +-
 starmath/source/parse.cxx|2 +-
 starmath/source/rect.cxx |2 +-
 starmath/source/visitors.cxx |6 +++---
 8 files changed, 11 insertions(+), 11 deletions(-)

New commits:
commit 3db23609d368687dd2b3122160d450e4bc5bbb78
Author: Andrea Gelmini 
AuthorDate: Fri Aug 16 16:34:34 2019 +0200
Commit: Julien Nabet 
CommitDate: Fri Aug 16 19:16:10 2019 +0200

Fix typos

Split from
https://gerrit.libreoffice.org/#/c/76764/

Change-Id: I19f11f80f08ce0d5b4ffda20449f1cddea980b7d
Reviewed-on: https://gerrit.libreoffice.org/77596
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/starmath/inc/cursor.hxx b/starmath/inc/cursor.hxx
index b04b39748829..2ba17fb0a46c 100644
--- a/starmath/inc/cursor.hxx
+++ b/starmath/inc/cursor.hxx
@@ -62,7 +62,7 @@ class SmDocShell;
 /** Formula cursor
  *
  * This class is used to represent a cursor in a formula, which can be used to 
manipulate
- * an formula programmatically.
+ * a formula programmatically.
  * @remarks This class is a very intimate friend of SmDocShell.
  */
 class SmCursor{
@@ -140,7 +140,7 @@ public:
 
 /** Insert a new row or newline
  *
- * Inserts a new row if position is in an matrix or stack command.
+ * Inserts a new row if position is in a matrix or stack command.
  * Otherwise a newline is inserted if we're in a toplevel line.
  *
  * @returns True, if a new row/line could be inserted.
diff --git a/starmath/inc/visitors.hxx b/starmath/inc/visitors.hxx
index 290f1bdeacb8..39f5c6323064 100644
--- a/starmath/inc/visitors.hxx
+++ b/starmath/inc/visitors.hxx
@@ -272,7 +272,7 @@ private:
  * denoted by | in "H|".
  *
  * Parameter variables:
- *  The following variables are used to transfer parameters in to calls and 
results out
+ *  The following variables are used to transfer parameters into calls and 
results out
  *  of calls.
  *  pRightMost : SmCaretPosGraphEntry*
  *
diff --git a/starmath/source/cursor.cxx b/starmath/source/cursor.cxx
index 2d74d454a2f6..f7d127bd25e9 100644
--- a/starmath/source/cursor.cxx
+++ b/starmath/source/cursor.cxx
@@ -1299,7 +1299,7 @@ void SmCursor::EndEdit(){
 //I think this notifies people around us that we've modified this 
document...
 mpDocShell->SetModified();
 //I think SmDocShell uses this value when it sends an update graphics event
-//Anyway comments elsewhere suggests it need to be updated...
+//Anyway comments elsewhere suggests it needs to be updated...
 mpDocShell->mnModifyCount++;
 
 //TODO: Consider copying the update accessibility code from 
SmDocShell::SetText in here...
diff --git a/starmath/source/document.cxx b/starmath/source/document.cxx
index b8222e2c0a02..c3373f5968c9 100644
--- a/starmath/source/document.cxx
+++ b/starmath/source/document.cxx
@@ -394,7 +394,7 @@ void SmDocShell::DrawFormula(OutputDevice , Point 
, bool bDrawSel
 rPosition.AdjustY(maFormat.GetDistance( DIS_TOPSPACE  ) );
 
 //! in case of high contrast-mode (accessibility option!)
-//! the draw mode needs to be set to default, because when imbedding
+//! the draw mode needs to be set to default, because when embedding
 //! Math for example in Calc in "a over b" the fraction bar may not
 //! be visible else. More generally: the FillColor may have been changed.
 DrawModeFlags nOldDrawMode = DrawModeFlags::Default;
diff --git a/starmath/source/mathtype.cxx b/starmath/source/mathtype.cxx
index 65a7bb834009..da48da787fa5 100644
--- a/starmath/source/mathtype.cxx
+++ b/starmath/source/mathtype.cxx
@@ -1817,7 +1817,7 @@ bool MathType::HandleSize(sal_Int16 nLstSize,sal_Int16 
nDefSize, int )
 }
 else
 {
-/*sizetable should theoreticaly be filled with the default sizes
+/*sizetable should theoretically be filled with the default sizes
  *of the various font groupings matching starmaths equivalents
  in aTypeFaces, and a test would be done to see if the new font
  size would be the same as what starmath would have chosen for
diff --git a/starmath/source/parse.cxx b/starmath/source/parse.cxx
index 102851120a22..663aa1c22361 100644
--- a/starmath/source/parse.cxx
+++ b/starmath/source/parse.cxx
@@ -1954,7 +1954,7 @@ std::unique_ptr SmParser::DoFontSize()
 {
 aValue = fTmp;
 
-//!! keep the numerator and denominator from being to large
+//!! keep the numerator and denominator from being too large
 //!! otherwise ongoing multiplications may result in overflows
 //!! (for example in SmNode::SetFontSize the font size calculated
 //!! may become 0 because of this!!! Happens e.g. for ftmp = 2.9 
with Linux
diff --git a/starmath/source/rect.cxx b/starmath/source/rect.cxx

[Libreoffice-bugs] [Bug 126883] HTML-Export: Tableexport with background supresses border

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126883

raal  changed:

   What|Removed |Added

 CC||oliver.spe...@cib.de,
   ||r...@post.cz
   Keywords||bibisected, bisected

--- Comment #6 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Oliver Specht ; Could you possibly take a look at this one?
Thanks

7957aec5c3c634ccfbdce0f25f57da477c84e13e is the first bad commit
commit 7957aec5c3c634ccfbdce0f25f57da477c84e13e
Author: Jenkins Build User 
Date:   Thu Dec 14 06:24:03 2017 +0100

source sha:46fa816aa0a713c54836b9689fa7a1c9ff55ef5a

author  Oliver Specht 2016-03-18 15:57:17 +0100
committer   Oliver Specht 2016-03-23 13:57:16
+
commit  46fa816aa0a713c54836b9689fa7a1c9ff55ef5a (patch)
tree8dad103eca59e741a51a2b761c9bfd69a24f95fc
parent  f9cf53a082f1d99b313ebd09c8791541859eac40 (diff)
tdf#63211: saving embedded images to HTML optional

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118345] FILESAVE: Decimal part of scientific numbers not correctly saved in ODF with '?'

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118345

--- Comment #6 from Laurent BP  ---
Created attachment 153443
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153443=edit
Some examples using such format

Hi Eike, sorry for the delay
(In reply to Eike Rathke from comment #3)
> Does formatting as 0.??E+0 really make sense? Instead of 1.00E+45 or 1E+45
> 1.  E+45
> looks very odd to me.

User may expect some alignment, with engineering notation for instance:
##0.???E+00

Examples attached

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126975] Copy and Paste from Calc to Writer ignores filter when using RTF as target

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126975

Oliver Brinzing  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||4646
 Ever confirmed|0   |1
 CC||oliver.brinz...@gmx.de

--- Comment #1 from Oliver Brinzing  ---
confirming with:

Version: 6.3.0.4 (x64)
Build ID: 057fc023c990d676a43019934386b85b21a9ee99
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-US
Calc: 

copy & paste into an existing writer table has been fixed in LO 6.3:

https://wiki.documentfoundation.org/ReleaseNotes/6.3/en#Writer
Bug 124646 - EDITOR ODT Writer inserts all data from filtered range 

but copy & paste special "Rich text formating (RTF)" ignores filter.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123009] Impress v6.14 slideview presentation after 68 slides or so stops. Screen message: LibreOffice fatal error: could not create system bitmap

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123009

Buovjaga  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #18 from Buovjaga  ---
(In reply to Richard Ward from comment #17)
> I have had to renamed as not recognised as an ‘odp’ file type I think due to
> the name being too long (possible reason for no file found previously) and I
> have changed the name to:
> 
> OriginalWinwickPassvideov4LO614videosetof3finalslide1click-slides31,68,97-
> Auto5s.odp
> 
> and can be downloaded at:
> 
> https://gofile.io/?c=7Y3IvD

I am able to advance through the presentation without issues.

Arch Linux 64-bit
Version: 6.4.0.0.alpha0+
Build ID: b9a776837462eeb6d50d0decc42604c0c3008eb1
CPU threads: 8; OS: Linux 5.2; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded
Built on 11 August 2019

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 121982] Support for database items as data source in charts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121982

Buovjaga  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval
 Whiteboard|QA:needsComment |

--- Comment #14 from Buovjaga  ---
(In reply to Markus Elfring from comment #13)
> (In reply to Buovjaga from comment #12)
> 
> I suggest to take another look at the specification of data ranges.
> https://help.libreoffice.org/6.3/en-US/text/schart/01/wiz_data_range.html
> 
> How do you think about to refer to database items there instead of spread
> sheet cells (of a document)?

Ok, I guess this is as far as we can pry open this cryptic clamshell of a
topic. Let's ask design team, if they have any bold visions regarding this or
if they will just throw it in the trashbin.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 121982] Support for database items as data source in charts

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121982

Buovjaga  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval
 Whiteboard|QA:needsComment |

--- Comment #14 from Buovjaga  ---
(In reply to Markus Elfring from comment #13)
> (In reply to Buovjaga from comment #12)
> 
> I suggest to take another look at the specification of data ranges.
> https://help.libreoffice.org/6.3/en-US/text/schart/01/wiz_data_range.html
> 
> How do you think about to refer to database items there instead of spread
> sheet cells (of a document)?

Ok, I guess this is as far as we can pry open this cryptic clamshell of a
topic. Let's ask design team, if they have any bold visions regarding this or
if they will just throw it in the trashbin.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 118682] FILEOPEN Cell content in DOCX document isn't treated as number, and formula can't be updated

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118682

Laurent BP  changed:

   What|Removed |Added

 CC||jumbo4...@yahoo.fr

--- Comment #3 from Laurent BP  ---
Confirmed with Version: 6.3.0.4
Build ID: 057fc023c990d676a43019934386b85b21a9ee99
Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3; 
Locale : en-US (fr_FR.UTF-8); Langue IHM : fr-FR
Calc: threaded

There are two problems:
1. Numbers are not automatically recognized (need to modify each number)
2. Formula has not a correct syntax. It should be:
*
instead of
A1*B1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123221] impossible to open libreoffice on ubuntu 18.10: crash opening an existing file with OpenGL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123221

--- Comment #7 from Willem Schreuder  ---
I had the same error:


lowriter --norestore
dbus[26734]: arguments to dbus_message_iter_append_basic() were incorrect,
assertion "_dbus_check_is_valid_utf8 (*string_p)" failed in file
../../../dbus/dbus-message.c line 2754.
This is normally a bug in some application using the D-Bus library.

  D-Bus not built with -rdynamic so unable to print a backtrace
Application Error


Fatal exception: Signal 6
Stack:
/usr/lib/libreoffice/program/libuno_sal.so.3(+0x13568)[0x7f776455e568]
/usr/lib/libreoffice/program/libuno_sal.so.3(+0x3c5d6)[0x7f77645875d6]
/lib/x86_64-linux-gnu/libc.so.6(+0x3ef20)[0x7f7764198f20]
/lib/x86_64-linux-gnu/libc.so.6(gsignal+0xc7)[0x7f7764198e97]
/lib/x86_64-linux-gnu/libc.so.6(abort+0x141)[0x7f776419a801]
/usr/lib/libreoffice/program/libmergedlo.so(+0x2d5d6e2)[0x7f77675026e2]
/usr/lib/libreoffice/program/libmergedlo.so(_ZN11Application5AbortERKN3rtl8OUStringE+0xa2)[0x7f776748e092]
/usr/lib/libreoffice/program/libmergedlo.so(+0x1d0e9b0)[0x7f77664b39b0]
/usr/lib/libreoffice/program/libmergedlo.so(+0x2ceea3d)[0x7f7767493a3d]
/usr/lib/libreoffice/program/libuno_sal.so.3(+0x165b2)[0x7f77645615b2]
/usr/lib/libreoffice/program/libuno_sal.so.3(+0x3c49f)[0x7f776458749f]
/lib/x86_64-linux-gnu/libc.so.6(+0x3ef20)[0x7f7764198f20]
/lib/x86_64-linux-gnu/libc.so.6(gsignal+0xc7)[0x7f7764198e97]
/lib/x86_64-linux-gnu/libc.so.6(abort+0x141)[0x7f776419a801]
/lib/x86_64-linux-gnu/libdbus-1.so.3(_dbus_abort+0x24)[0x7f7761901274]
/lib/x86_64-linux-gnu/libdbus-1.so.3(_dbus_strdup+0x0)[0x7f77618f7b00]
/lib/x86_64-linux-gnu/libdbus-1.so.3(dbus_message_iter_append_basic+0x361)[0x7f77618e9321]
/lib/x86_64-linux-gnu/libdbus-1.so.3(dbus_message_append_args_valist+0x2f3)[0x7f77618e9e03]
/lib/x86_64-linux-gnu/libdbus-1.so.3(dbus_message_append_args+0x99)[0x7f77618e9ed9]
/usr/lib/x86_64-linux-gnu/libavahi-client.so.3(avahi_record_browser_new+0x17c)[0x7f7755651bdc]
/usr/lib/x86_64-linux-gnu/libcups.so.2(+0x29316)[0x7f775e53e316]
/usr/lib/x86_64-linux-gnu/libcups.so.2(cupsGetDests2+0x94)[0x7f775e53e464]
/usr/lib/libreoffice/program/libmergedlo.so(+0x2d73127)[0x7f7767518127]
/usr/lib/libreoffice/program/libuno_sal.so.3(+0x3f179)[0x7f776458a179]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x76db)[0x7f7761d466db]
/lib/x86_64-linux-gnu/libc.so.6(clone+0x3f)[0x7f776427b88f]

=
This can be fixed by disabling CUPS:
SAL_DISABLE_CUPS=true lowriter --norestore
which restores normal operation.

With our without --safe-mode makes no difference.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126978] Measurement units for paper size in 'Print' dialog does not follow application settings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126978

Oliver Brinzing  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||oliver.brinz...@gmx.de

--- Comment #2 from Oliver Brinzing  ---
confirmung, it seems, print dialog follows Locale settings from Menu
Tools/Options.../Language Settings/Languages/Locale setting

with [English (USA)]:

Version: 6.3.0.4 (x64)
Build ID: 057fc023c990d676a43019934386b85b21a9ee99
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (de_DE); UI-Language: en-US
Calc: 

print dialog shows "in"

and with [English (Canada)]:

Version: 6.3.0.4 (x64)
Build ID: 057fc023c990d676a43019934386b85b21a9ee99
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-CA (de_DE); UI-Language: en-US
Calc: 

it shows "mm".

but i am not sure, if this is a bug, cause one can change the "Measurement
Unit" separat for each component (writer, calc).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126830] Icons not showing in menus

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126830

raal  changed:

   What|Removed |Added

 CC||noelgran...@gmail.com,
   ||r...@post.cz
   Keywords|bibisectRequest |bibisected, bisected

--- Comment #3 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Noel Grandin ; Could you possibly take a look at this one?
Thanks

5bf61ce1eb7304a72c9bdc6562355ea76071d5e2 is the first bad commit
commit 5bf61ce1eb7304a72c9bdc6562355ea76071d5e2
Author: Jenkins Build User 
Date:   Mon Apr 29 08:47:23 2019 +0200

source sha:9eae42ce01cb289b9e736454abcf835b8394

author  Noel Grandin  2019-04-28 09:54:42
+0200
committer   Noel Grandin  2019-04-29
08:30:26 +0200
commit  9eae42ce01cb289b9e736454abcf835b8394 (patch)
tree7e6f1d44f609ebcf05e3675ea8f10e41652cc078
parent  8647288180806f8515bf2548db7280cbc657eaf3 (diff)
speed up gtk menu construction at startup

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123113] type french date with field correctly (first day = "1ER")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123113

Laurent BP  changed:

   What|Removed |Added

 CC||jumbo4...@yahoo.fr

--- Comment #9 from Laurent BP  ---
List of format examples is defined for each local in:
https://opengrok.libreoffice.org/xref/core/i18npool/source/localedata/data/fr_FR.xml?r=d5146c0e#145

Default displayed value is defined here:
https://opengrok.libreoffice.org/xref/core/include/svx/flagsdef.hxx?r=c049c76f#86

But it is the same value for all languages. Shall we increase
SvxNumValCategory::Date and SvxNumValCategory::Time by 2 (to avoid same value
for day and month) => January, 2nd 2000
or decrease by 30 => December, 1st 2000

By the way, format 
[NatNum12 J=ordinal-number]J  
add ordinal notation to all days, not only the first:
vendredi 31ᵉ décembre 1999
which may be not expected by user. We need a conditional formatting to follow
typographic rules.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - vcl/source

[Miklos Vajna (via logerrit)]

 vcl/source/edit/texteng.cxx   |3 +++
 vcl/source/uitest/uiobject.cxx|5 +
 vcl/source/window/aboutdialog.cxx |2 ++
 3 files changed, 10 insertions(+)

New commits:
commit 0df3e9fd645e9613c4a852b4a0966ff2eea7e313
Author: Miklos Vajna 
AuthorDate: Mon Aug 12 11:35:51 2019 +0200
Commit: Caolán McNamara 
CommitDate: Fri Aug 16 18:12:28 2019 +0200

tdf#118856 vcl: avoid flicker in the about dialog

There were two problems here:

1) The flickering widget in question is VclMultiLineEdit, but it wasn't
like its own painting caused a flicker, rather the calling
vcl::Window::PushPaintHelper() already erased the widget and later the
widget painted itself. So the easy way with vcl::BufferDevice is not
enough here. VclMultiLineEdit seems to be working with double buffering
just fine, so enable that in the vcl::AboutDialog ctor.

2) Now that text did not flicker, its background was wrong. In case the
NWF determines some gray background, the background was white for most
text when there was no selection.

When there was selection, then the after-selection area (in a single
line) was fine, but nothing else.

It seems TextEngine::ImpPaint() assumes that no need to set a default
text fill color before drawing text, but the above shows that there is
difference between the starting state and after clearing away a custom
color with SetTextFillColor(). So fix this problem by always explicitly
calling SetTextFillColor() before text paint: either setting the
selection color or the default one.

This brings improvement for the Windows GDI backend; Windows GL, Linux
gen/gtk/gtk3 is unchanged in practice.

(cherry picked from commit 7eb37a422f2e66bc177d72404c53659a248661ca)

Change-Id: Ie7ff3a7f36bedf73424ea579a00588bd8858d6c4
Reviewed-on: https://gerrit.libreoffice.org/77369
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/source/edit/texteng.cxx b/vcl/source/edit/texteng.cxx
index b6835dbc07a2..cab426c8b001 100644
--- a/vcl/source/edit/texteng.cxx
+++ b/vcl/source/edit/texteng.cxx
@@ -1964,6 +1964,7 @@ void TextEngine::ImpPaint( OutputDevice* pOutDev, const 
Point& rStartPos, tools:
 {
 const sal_Int32 nL = 
pSelStart->GetIndex() - nTmpIndex;
 pOutDev->SetFont( aFont);
+
pOutDev->SetTextFillColor();
 aPos.setX( rStartPos.X() + 
ImpGetOutputOffset( nPara, , nTmpIndex, nTmpIndex+nL ) );
 pOutDev->DrawText( aPos, 
pPortion->GetNode()->GetText(), nTmpIndex, nL );
 nTmpIndex = nTmpIndex + nL;
@@ -1989,6 +1990,7 @@ void TextEngine::ImpPaint( OutputDevice* pOutDev, const 
Point& rStartPos, tools:
 if ( nTmpIndex < nEnd )
 {
 nL = nEnd-nTmpIndex;
+
pOutDev->SetTextFillColor();
 aPos.setX( rStartPos.X() + 
ImpGetOutputOffset( nPara, , nTmpIndex, nTmpIndex+nL ) );
 pOutDev->DrawText( aPos, 
pPortion->GetNode()->GetText(), nTmpIndex, nEnd-nTmpIndex );
 }
@@ -1997,6 +1999,7 @@ void TextEngine::ImpPaint( OutputDevice* pOutDev, const 
Point& rStartPos, tools:
 }
 if ( !bDone )
 {
+pOutDev->SetTextFillColor();
 aPos.setX( rStartPos.X() + 
ImpGetOutputOffset( nPara, , nTmpIndex, nEnd ) );
 pOutDev->DrawText( aPos, 
pPortion->GetNode()->GetText(), nTmpIndex, nEnd-nTmpIndex );
 }
diff --git a/vcl/source/uitest/uiobject.cxx b/vcl/source/uitest/uiobject.cxx
index b8932913cf53..2a86abcdd4ef 100644
--- a/vcl/source/uitest/uiobject.cxx
+++ b/vcl/source/uitest/uiobject.cxx
@@ -273,6 +273,11 @@ WindowUIObject::WindowUIObject(const VclPtr& 
xWindow):
 
 StringMap WindowUIObject::get_state()
 {
+// Double-buffering is not interesting for uitesting, but can result in 
direct paint for a
+// double-buffered widget, which is incorrect.
+if (mxWindow->SupportsDoubleBuffering())
+mxWindow->RequestDoubleBuffering(false);
+
 StringMap aMap;
 aMap["Visible"] = OUString::boolean(mxWindow->IsVisible());
 aMap["ReallyVisible"] = 

[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-6.3.1.1'

[Christian Lohmaier (via logerrit)]

Tag 'libreoffice-6.3.1.1' created by Christian Lohmaier 
 at 2019-08-16 16:10 +

Tag libreoffice-6.3.1.1
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAl1W1VoACgkQ9DSh76/u
rqOgnA/+PmJb3sEkBMqYILg2gionVysnVmGedSpvE4POoDPl1SNwvFsIVWB3wI4q
5hH8odf+9OJzN6NP63d956mnrxi89ZsUGvMswcHRaM9fcSRw3FyctO1k09UG3/wR
fbQIULNU7QBmbAhzbl+2QD5YcKuv0ei1VUwlDVvBm+o7XWheuzPbTaoOnd9k1fh+
5QgVt26gvlcxUA8yBvcATsJzVBsGzj2Zw7PKyXB3KGKzcJ4CuzBf8elcwDtUfopJ
WzldRZV0KFzJTxbN3eg/RDRW3Gvql7ZoMeBhyDT/LZPe1wtAtcwunOFpPRHjLSHL
QdW7R1me97FBfMNU+rf2kE5aV5wMzGIDr29JJwWWYBD39bHAG0gEDvs8wX6BoWq3
T2EKkF4z2vlshSAFsif1FHKClOyyecfbzSCpo7MBaLJigtwycuwLLB79GKd/EGOH
j1e/EoygCP+cndh1NPFth2nOL1PsOzwOahD0PoKQgo5QZB4Ur+hAlXTaHdnKL8WT
JUPwPUt/E0teGHbLJhPrz8WFJc9ThO7RSShgI86Dlf5415Z8OviV3CuYl241SR99
T8a1XVSu0LARJiYcx3+IrAHrwbX9EREANo2McJ+hbAABpxSfyJaZ1pRPJcXn23Dw
cbUJUyTfT3fL4zwsmBfT6YsO78qE0691XxqaJiTakyDgCaLLJGs=
=8ffm
-END PGP SIGNATURE-

Changes since libreoffice-6-3-branch-point-16:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-6.3.1.1'

[Christian Lohmaier (via logerrit)]

Tag 'libreoffice-6.3.1.1' created by Christian Lohmaier 
 at 2019-08-16 16:10 +

Tag libreoffice-6.3.1.1
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAl1W1VoACgkQ9DSh76/u
rqMZdA//T2tSm23SHwFgTKdDr2LfcxAXGdUUlapjsmLRtyf2ppuJIVdtIawg+tn7
QhSRTbFdqSZxH3mW27O80N3DrzL+tbCWANy7SLHbyAWpfbxx5RZnPWmGTqm8lp5e
jn/HGfB7dn70KQwrZnpMDkUOl3jZmzj5amNLxC6cOBjapMeVmKC5FxVUuvE+UeqU
tIoVgdmong1M94chwozYFsqmSeHIGv0IWxpvLLgkXcF2vW7pvB/alP4Kd9rzvphT
CTbX3u68XVYIw1FYHYn2QjXIiaLdkKGsmhKfvoFoMBAjcHFf1yfddg0K0fFXB9CG
tkmKjtcbEtbPNJhBua5uBT/4tqnbpClem9T2ZXFuBNj/w/J2r2rX/Ow/oLp1Wj0D
TWOJRvZEU60InIRipBJJjunTlguoLKgeDcvSaIiPXhNJ3w2MlO/xgIVN0alXbWA1
IyBGWg3R2Q021Ll+MnRsOV4Z73We/QPXep2FIF4mGoHUQ94A3Bn8g1hJe9TWeeeM
oCmjba3Nw5iVTi1BIuXTce5GkDy7idd6X0fsbrVjoRvTAXVHioMXmSdL58i4hVzq
fMAwfgqpPO9WvaQUp8dFwGESPtIYY2jSnTvLaD3ScNjZPp2WUcI7VaVP4KqE6obE
h4Rlohox79cRFUEKbsMEhXOh8WA91XAasb3jpXGSxbV+bSHqPVI=
=x8Ne
-END PGP SIGNATURE-

Changes since libreoffice-6-3-branch-point-9:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3-1' - configure.ac

[Christian Lohmaier (via logerrit)]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 699f276e178249b3f2fc44fcb572bdf67c3f07ed
Author: Christian Lohmaier 
AuthorDate: Fri Aug 16 18:10:28 2019 +0200
Commit: Christian Lohmaier 
CommitDate: Fri Aug 16 18:10:28 2019 +0200

bump product version to 6.3.1.1.0+

Change-Id: If9d17681b3a1c22bd01481c6cb3cb1cddfd2e572

diff --git a/configure.ac b/configure.ac
index bc309b8037e9..69afb1881e47 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[6.3.1.0.0+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[6.3.1.1.0+],[],[],[http://documentfoundation.org/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits