[Libreoffice-ux-advise] [Bug 91296] FILEOPEN: UI: GUI does not reflect original Header And Footer Settings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91296

Heiko Tietze  changed:

   What|Removed |Added

 CC||olivier.hallot@libreoffice.
   ||org

--- Comment #10 from Heiko Tietze  ---
(In reply to Timur from comment #6)
> - .DOC is open all pages with "Default Style" and unchecks Same Content...
> - .DOCX is open first page with "First Page" and:

Sounds like the round-trip in MSO is broken. Don't see need to document this on
our help.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 91296] FILEOPEN: UI: GUI does not reflect original Header And Footer Settings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91296

Heiko Tietze  changed:

   What|Removed |Added

 CC||olivier.hallot@libreoffice.
   ||org

--- Comment #10 from Heiko Tietze  ---
(In reply to Timur from comment #6)
> - .DOC is open all pages with "Default Style" and unchecks Same Content...
> - .DOCX is open first page with "First Page" and:

Sounds like the round-trip in MSO is broken. Don't see need to document this on
our help.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: external/gpgmepp

[Mike Kaganski (via logerrit)]

 external/gpgmepp/UnpackedTarball_gpgmepp.mk |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit ff898ea321299b370d3776430c490ad4acc3b0d2
Author: Mike Kaganski 
AuthorDate: Tue Aug 27 15:33:36 2019 +0200
Commit: Mike Kaganski 
CommitDate: Wed Aug 28 07:32:27 2019 +0200

Record patch as upstreamed

Change-Id: Ia84db6c3d8051b872a838b530a8c44ce4a4b2821
Reviewed-on: https://gerrit.libreoffice.org/78198
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/external/gpgmepp/UnpackedTarball_gpgmepp.mk 
b/external/gpgmepp/UnpackedTarball_gpgmepp.mk
index 4dfee72890b5..9fc213c7e51c 100644
--- a/external/gpgmepp/UnpackedTarball_gpgmepp.mk
+++ b/external/gpgmepp/UnpackedTarball_gpgmepp.mk
@@ -13,6 +13,8 @@ $(eval $(call 
gb_UnpackedTarball_set_tarball,gpgmepp,$(GPGME_TARBALL)))
 
 $(eval $(call gb_UnpackedTarball_set_patchlevel,gpgmepp,0))
 
+# * external/gpgmepp/add-gpgme_set_global_flag-wrapper.patch upstreamed at
+#    "No gpgmepp API to call 
gpgme_set_global_flag"
 # * external/gpgmepp/version.patch upstream at  
"gpgme: `make dist`
 #   introduced VERSION can clash with new C++ ":
 $(eval $(call gb_UnpackedTarball_add_patches,gpgmepp, \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 126938] Add shortcuts for accepting and rejecting changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126938

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Heiko Tietze  ---
We run out of (good) shortcuts long time ago. There are things like
shift+ctrl+e to open the extension manager, which is absolutely not needed. But
once users know this shortcut it's very hard to remove it again. So unless you
have a good proposal I'd recommend to customize locally (Tools > Customize >
Keyboard, and enter the search term at Functions).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 126938] Add shortcuts for accepting and rejecting changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126938

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Heiko Tietze  ---
We run out of (good) shortcuts long time ago. There are things like
shift+ctrl+e to open the extension manager, which is absolutely not needed. But
once users know this shortcut it's very hard to remove it again. So unless you
have a good proposal I'd recommend to customize locally (Tools > Customize >
Keyboard, and enter the search term at Functions).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127183] EDITING: Selection of words by double click and mouse move

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127183

Heiko Tietze  changed:

   What|Removed |Added

 CC||er...@redhat.com

--- Comment #2 from Heiko Tietze  ---
Don't think that's possible with Calc's edit engine. Would be a nice to have
for conformity but definitely not needed, as Stuart pointed out. Eike, am I
right and this is (much) more than an easy hack?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127157] Add the ability to store comments within palette files (.soc)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127157

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #5 from Heiko Tietze  ---
Stuart and me voted for WF on the tooltip for license/version/etc. info. There
are plenty of opportunities to share this information.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126914] Calc does not highlight the current cell or cell range

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126914

raal  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|NEEDINFO|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125166] czech translation - Review Revize

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125166

--- Comment #8 from Jean-Baptiste Faure  ---
(In reply to Julien Nabet from comment #4)
[...]
> Sophie/Jean-Baptiste: any idea which release will include the fix and above
> all when?

I guess for 6.3.2.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vbahelper/source

[Julien Nabet (via logerrit)]

 vbahelper/source/vbahelper/vbacolorformat.cxx |2 +-
 vbahelper/source/vbahelper/vbacolorformat.hxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 1c539c548b662104431e283aa4a62cb81174380b
Author: Julien Nabet 
AuthorDate: Tue Aug 27 20:08:41 2019 +0200
Commit: Julien Nabet 
CommitDate: Wed Aug 28 07:18:11 2019 +0200

Typo: HAPICOLOR_WITHE->HAPICOLOR_WHITE (vbahelper)

Change-Id: I51a43e190345a1e981f9bd524d8b2feaf0eb2521
Reviewed-on: https://gerrit.libreoffice.org/78207
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/vbahelper/source/vbahelper/vbacolorformat.cxx 
b/vbahelper/source/vbahelper/vbacolorformat.cxx
index 7c72c65a1eeb..653d0db23a2a 100644
--- a/vbahelper/source/vbahelper/vbacolorformat.cxx
+++ b/vbahelper/source/vbahelper/vbacolorformat.cxx
@@ -27,7 +27,7 @@ sal_Int32
 MsoColorIndices::getColorIndex( sal_Int32 nIndex )
 {
 const static sal_Int32 COLORINDICES[56] =
-{   HAPICOLOR_BLACK, HAPICOLOR_WITHE, HAPICOLOR_RED, 
HAPICOLOR_BRIGHTGREEN, HAPICOLOR_BLUE, HAPICOLOR_YELLOW, HAPICOLOR_PINK,
+{   HAPICOLOR_BLACK, HAPICOLOR_WHITE, HAPICOLOR_RED, 
HAPICOLOR_BRIGHTGREEN, HAPICOLOR_BLUE, HAPICOLOR_YELLOW, HAPICOLOR_PINK,
 HAPICOLOR_TURQUOISE, HAPICOLOR_DARKRED, HAPICOLOR_GREEN, 
HAPICOLOR_DARKBLUE, HAPICOLOR_DARKYELLOW, HAPICOLOR_VIOLET,
 HAPICOLOR_TEAL, HAPICOLOR_GRAY_25_PERCENT, HAPICOLOR_GRAY_50_PERCENT, 
HAPICOLOR_PERIWINCKLE, HAPICOLOR_PLUM,
 HAPICOLOR_IVORY, HAPICOLOR_LIGHTTURQUOISE, HAPICOLOR_DARKPRUPLE, 
HAPICOLOR_CORAL, HAPICOLOR_OCEANBLUE, HAPICOLOR_ICEBLUE,
diff --git a/vbahelper/source/vbahelper/vbacolorformat.hxx 
b/vbahelper/source/vbahelper/vbacolorformat.hxx
index d1573a0f0b5d..746c87c9fadc 100644
--- a/vbahelper/source/vbahelper/vbacolorformat.hxx
+++ b/vbahelper/source/vbahelper/vbacolorformat.hxx
@@ -40,7 +40,7 @@ public:
 struct MsoColorIndices
 {
 const static sal_Int32 HAPICOLOR_BLACK = 0;
-const static sal_Int32 HAPICOLOR_WITHE = 16777215;
+const static sal_Int32 HAPICOLOR_WHITE = 16777215;
 const static sal_Int32 HAPICOLOR_RED = 16711680;
 const static sal_Int32 HAPICOLOR_BRIGHTGREEN = 65280;
 const static sal_Int32 HAPICOLOR_BLUE = 255;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 127191] while using remote saving option

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127191

jofin  changed:

   What|Removed |Added

 CC||jofinjose...@gmail.com

--- Comment #1 from jofin  ---
Created attachment 153696
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153696=edit
file>>remote save>> after this steps i getting this ERROR

file>>remote save>> after this steps i getting this ERROR message,
all required fields are given perfectly , but message is like this 

Error saving the document (FILE NAME):
The specified device is invalid.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127157] Add the ability to store comments within palette files (.soc)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127157

--- Comment #4 from Jean-Francois Nifenecker 
 ---
Of course, it could.

Don't forget that the concern is about office documents design documentation,
which is lacking very much is all office suite I know of and would be a
blessing if present.

Currently, it's very cumbersome to clearly and precisely document such items as
conditional formats in Calc, .bau files in Writer, or such files as palettes
(of course, there are plenty other places as you noted; let's just start
somewhere ;). Adding the ability to insert comments within palette files is a
step in this direction that can make a difference and ease the professional
designers workflow.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124462] Crash if I open the File dialog and click the 'Save' tab

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124462

Stacy Watson  changed:

   What|Removed |Added

URL|http://msofficesetup.org|http://officeexperttoday.co
   ||m

--- Comment #4 from Stacy Watson  ---
Microsoft office.com/setup with your product key. Get started: step 1. Go to
office.com/setup - Sign in, 2nd. Enter product key, and 3rd. Install Office 365
or Office 2016. If you are having any Office Setup issue then call us at 24*7
for technical help. we also help with like Excel, PowerPoint, PowerPoint, Word,
OneNote, office.com/setup


http://officeexperttoday.com

https://office-office.org/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127191] New: while using remote saving option

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127191

Bug ID: 127191
   Summary: while using remote saving option
   Product: LibreOffice
   Version: 6.3.0.4 release
  Hardware: Other
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jofinjose...@gmail.com

Description:
using remote saving option a message shows like this* Error saving the
document (file name): The specified device is invalid. VERSION IS UPTO DATE
6.3

Steps to Reproduce:
1.FileSave Remote>>>Add Service>>>
2.select GOOGLE DRIVE >> give User(GOOGLE) google 6 digit OTP or
authentication code from google authentication app
3.getting error

Actual Results:
The specified device is invalid >>> while trying to setup remote saving


Expected Results:
wnt to save to cloud storage of google docs or microsoft one drive VIA writer
FileSave Remote option


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126810] FILESAVE

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126810

--- Comment #10 from steffan.steff...@gmx.net ---

Sorry, wrong language, so here goes again, same comment in English
(by the way, is there a editung function for comments on bugzilla ??)

I finally found time to check what the reason for my problems might be (and I
was successful)

A hint was that my WORD 2016 behaves exactly as LibreOffice should  (that is,
as described here under Comment 1.

e.g.
T?ES:T - Der Dateiname ist ungültig.
::TEST - Ungültige Klassenzeichenfolge

This led me to believe that remains of older versions of LibreOffice might be
responsible. So I deinstalled my current version of LibreOffice, and then I
deleted all remaining folders I could find.

I deleted

C:\Program Files\LibreOffice 5
C:\Program Files (x86)\LibreOffice 5
C:\Users\x\AppData\Roaming\LibreOffice

and then I installed the new version  6.3.0.4 (x64):

Result: behaviour is now exactly as described under comment 1.

Maybe this could at least be useful for the user support department – even
though it might not really be a novelty that deleting all old files and folders
of a programs is actually helpful in some cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127186] FORMATTING: underbrace/overbrace too narrow(tiny height) to be legible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127186

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #2 from V Stuart Foote  ---
Created attachment 153695
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153695=edit
sm Formula with overbrace and underbrace looks OK

Can not confirm on Windows 10 Home 64-bit en-US (1903) with
recent master Version: 6.4.0.0.alpha0+ (x64)
Build ID: 3e64065612acec2eb29aa21e2b515953422256d7
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2019-08-15_22:57:26
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

The overbrace and underbrace render fully into the layout box for their node,
height is correct. And the node scale correctly in response to size # {}
specification.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - l10ntools/source scp2/source solenv/inc

[Christian Lohmaier (via logerrit)]

 l10ntools/source/ulfconv/msi-encodinglist.txt |1 +
 scp2/source/ooo/module_langpack.ulf   |6 ++
 solenv/inc/langlist.mk|1 +
 3 files changed, 8 insertions(+)

New commits:
commit ab54f146490d3576e0b73ec918fa5b8ba09e31ef
Author: Christian Lohmaier 
AuthorDate: Tue Aug 27 14:09:34 2019 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Wed Aug 28 06:00:58 2019 +0200

add Silesian (szl) language pack

Change-Id: I47d9659fc21abec652a5a440004c0c2d27ec3b53
(cherry picked from commit f22ce154c7aa2275ed51a5321892ba0d5254d94c)
Reviewed-on: https://gerrit.libreoffice.org/78192
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/l10ntools/source/ulfconv/msi-encodinglist.txt 
b/l10ntools/source/ulfconv/msi-encodinglist.txt
index 3c98165caae8..062988a85de5 100644
--- a/l10ntools/source/ulfconv/msi-encodinglist.txt
+++ b/l10ntools/source/ulfconv/msi-encodinglist.txt
@@ -149,6 +149,7 @@ st   0  1072   # Southern Sotho, Sutu
 sv   0  1053
 sw   0  1089   # Swahili
 sw-TZ0  1089   # Swahili
+szl  0  1689   # Silesian
 so   0  1143
 ta   0  1097   # Tamil
 ta-IN0  1097   # Tamil
diff --git a/scp2/source/ooo/module_langpack.ulf 
b/scp2/source/ooo/module_langpack.ulf
index 3cc7df5f0464..c4ee1701f1c5 100644
--- a/scp2/source/ooo/module_langpack.ulf
+++ b/scp2/source/ooo/module_langpack.ulf
@@ -718,6 +718,12 @@ en-US = "Sidama"
 [STR_DESC_MODULE_LANGPACK_SID]
 en-US = "Installs the Sidama user interface"
 
+[STR_NAME_MODULE_LANGPACK_SZL]
+en-US = "Silesian"
+
+[STR_DESC_MODULE_LANGPACK_SZL]
+en-US = "Installs the Silesian user interface"
+
 [STR_NAME_MODULE_LANGPACK_QTZ]
 en-US = "KeyID"
 
diff --git a/solenv/inc/langlist.mk b/solenv/inc/langlist.mk
index 9c8f266fba7e..7391ed2661fe 100644
--- a/solenv/inc/langlist.mk
+++ b/solenv/inc/langlist.mk
@@ -115,6 +115,7 @@ ss \
 st \
 sv \
 sw-TZ \
+szl \
 ta \
 te \
 tg \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 126810] FILESAVE

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126810

steffan.steff...@gmx.net changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126810] FILESAVE

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126810

--- Comment #9 from steffan.steff...@gmx.net ---
Also, ich habe jetzt doch noch überprüft, woran es liegen könnte (und bin auch
fündig geworden ..)

Ein Hinweis für mich war, dass sich mein WORD 2016 genauso verhält, wie das
LibreOffice das auch soll (also so, wie hier in Comment 1 beschrieben).

Also z.B.
T?ES:T - Der Dateiname ist ungültig.
::TEST - Ungültige Klassenzeichenfolge

Das hat mich auf die Idee gebracht, dass alte Versionen von LibreOffice
„schuld“ sein könnten. Ich habe also mein LibreOffice 6 deinstalliert, und auch
alle alten Ordner manuell gelöscht, also

C:\Program Files\LibreOffice 5
C:\Program Files (x86)\LibreOffice 5
C:\Users\x\AppData\Roaming\LibreOffice

und dann die neueste Version: 6.3.0.4 (x64) installiert:

Ergebnis: jetzt ist bei mir ebenfalls alles so, wie in Comment 1 beschrieben.

Zumindest könnte das als Information für den Benutzersupport brauchbar sein,
wobei es sicherlich dort keine Neuigkeit ist, dass das komplette Löschen aller
alten Dateien eines Programms bisweilen  Probleme / unerwünschtes Verhalten
beseitigen kann ...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127190] FILESAVE: math crashes when export to pdf

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127190

--- Comment #4 from V Stuart Foote  ---
(In reply to V Stuart Foote from comment #3)
> Can not confirm on Windows 10 Home 64-bit en-US (1903) with
> Version: 6.4.0.0.alpha0+ (x64)
> Build ID: 3e64065612acec2eb29aa21e2b515953422256d7
> CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
> TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2019-08-15_22:57:26
> Locale: en-US (en_US); UI-Language: en-US
> Calc: threaded
> 
> Export to PDF from sm Formula editor creates readable PDF.

This build also WFM with Default rendering, not OpenG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127190] FILESAVE: math crashes when export to pdf

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127190

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #3 from V Stuart Foote  ---
Can not confirm on Windows 10 Home 64-bit en-US (1903) with
Version: 6.4.0.0.alpha0+ (x64)
Build ID: 3e64065612acec2eb29aa21e2b515953422256d7
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2019-08-15_22:57:26
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

Export to PDF from sm Formula editor creates readable PDF.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127187] Auto Strikethrough Gets in the Way

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127187

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |NOTABUG

--- Comment #1 from V Stuart Foote  ---
Functions as intended => NAB

You can disable the Autocorrect of bold, italic, strike through or underline
from the Auto Correct Options dialog -> Options tab. Or you can immediately
revert the autocorrection with a +Z entry.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 127183] EDITING: Selection of words by double click and mouse move

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127183

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||vstuart.fo...@utsa.edu

--- Comment #1 from V Stuart Foote  ---
 + with Mouse click allows expanded selection, but not at word bounds.

While ++R/L cursor will expand shrink selection at word bounds.

Good enough? Not clear additional work is justified for Word bounds selection
in Calc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 127183] EDITING: Selection of words by double click and mouse move

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127183

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||vstuart.fo...@utsa.edu

--- Comment #1 from V Stuart Foote  ---
 + with Mouse click allows expanded selection, but not at word bounds.

While ++R/L cursor will expand shrink selection at word bounds.

Good enough? Not clear additional work is justified for Word bounds selection
in Calc.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127140] Right click menu options for frequent documents in Windows 10 taskbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127140

V Stuart Foote  changed:

   What|Removed |Added

Summary|Feature Request: Right  |Right click menu options
   |click menu options for  |for frequent documents in
   |frequent documents in   |Windows 10 taskbar
   |Windows 10 taskbar  |
 Resolution|FIXED   |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126739] Click-and-move textbox with image underneath, after moving image, is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126739

V Stuart Foote  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127190] FILESAVE: math crashes when export to pdf

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127190

VincentYu  changed:

   What|Removed |Added

 OS|All |Windows (All)
   Hardware|All |x86-64 (AMD64)

--- Comment #2 from VincentYu  ---
Happened on my PC with Win8.1 Pro(64bit)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Fwd: [global-libreoffice-ci] lo_daily_update_gandalf - Build # 666 - Still Failing!

[Luke Benes]

https://cgit.freedesktop.org/libreoffice/core/commit/?id=14087d3e5fed9b56384432d9aeac608a5e8d86cf


        tdf#121670 ooxmlimport: no columns in page styles, only sections

was the cause of this failure
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Fwd: [global-libreoffice-ci] lo_daily_update_gandalf - Build # 666 - Still Failing!

[Luke Benes]

A clean install of KDE Neon is failing with the same error that Stephan 
reported:
https://ci.libreoffice.org/job/lo_daily_update_gandalf/lastBuild/console

ooxmlexport4.cxx:1209:Assertion
Test name: testTdf81345_045Original::Import_Export_Import
assertion failed
- Expression: pageStyleName != "Standard"

I bisected this regression to:

tdf#121670 ooxmlimport: no columns in page styles, only sections

Where can I find Gandalf's configuration? Was kde base install on it?

Justin,
Could you look into why your patch is failing on Gandalf and KDE Neon?

-Luke
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124176

Ezekiel Reyna  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |reynaezek...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

libreoffice command line not running 6.3.0.4

[Jerry Geis]

here is the strace of soffice.bin -
I have loaded 6.3.0.4 on CentOS 7 on two machines - first machine it worked
- this machine
its not running - and just exists...
Sometimes I see Application error - sometimes not.

What is it not happy about, how can I get it running ???
Thanks

Jerry

[pid  3559] lstat("/opt", {st_dev=makedev(8, 1), st_ino=165,
st_mode=S_IFDIR|0755, st_nlink=5, st_uid=0, st_gid=0, st_blksize=4096,
st_blocks=0, st_size=57, st_atime=2019/08/27-19:04:26.017323665,
st_mtime=2019/08/26-11:09:05.495139453,
st_ctime=2019/08/26-11:09:05.495139453}) = 0
[pid  3559] lstat("/opt/libreoffice6.3", {st_dev=makedev(8, 1),
st_ino=33693800, st_mode=S_IFDIR|0755, st_nlink=7, st_uid=0, st_gid=0,
st_blksize=4096, st_blocks=0, st_size=136,
st_atime=2019/08/27-19:04:29.206279248, st_mtime=2019/08/06-14:09:21,
st_ctime=2019/08/26-11:09:22.638921010}) = 0
[pid  3559] lstat("/opt", {st_dev=makedev(8, 1), st_ino=165,
st_mode=S_IFDIR|0755, st_nlink=5, st_uid=0, st_gid=0, st_blksize=4096,
st_blocks=0, st_size=57, st_atime=2019/08/27-19:04:26.017323665,
st_mtime=2019/08/26-11:09:05.495139453,
st_ctime=2019/08/26-11:09:05.495139453}) = 0
[pid  3559] lstat("/opt/libreoffice6.3", {st_dev=makedev(8, 1),
st_ino=33693800, st_mode=S_IFDIR|0755, st_nlink=7, st_uid=0, st_gid=0,
st_blksize=4096, st_blocks=0, st_size=136,
st_atime=2019/08/27-19:04:29.206279248, st_mtime=2019/08/06-14:09:21,
st_ctime=2019/08/26-11:09:22.638921010}) = 0
[pid  3559] lstat("/opt/libreoffice6.3/program", {st_dev=makedev(8, 1),
st_ino=67735592, st_mode=S_IFDIR|0755, st_nlink=10, st_uid=0, st_gid=0,
st_blksize=4096, st_blocks=40, st_size=16384,
st_atime=2019/08/27-19:10:29.491261022,
st_mtime=2019/08/27-19:08:54.833579460,
st_ctime=2019/08/27-19:08:54.833579460}) = 0
[pid  3559] lstat("/opt", {st_dev=makedev(8, 1), st_ino=165,
st_mode=S_IFDIR|0755, st_nlink=5, st_uid=0, st_gid=0, st_blksize=4096,
st_blocks=0, st_size=57, st_atime=2019/08/27-19:04:26.017323665,
st_mtime=2019/08/26-11:09:05.495139453,
st_ctime=2019/08/26-11:09:05.495139453}) = 0
[pid  3559] lstat("/opt/libreoffice6.3", {st_dev=makedev(8, 1),
st_ino=33693800, st_mode=S_IFDIR|0755, st_nlink=7, st_uid=0, st_gid=0,
st_blksize=4096, st_blocks=0, st_size=136,
st_atime=2019/08/27-19:04:29.206279248, st_mtime=2019/08/06-14:09:21,
st_ctime=2019/08/26-11:09:22.638921010}) = 0
[pid  3559] lstat("/opt/libreoffice6.3/program", {st_dev=makedev(8, 1),
st_ino=67735592, st_mode=S_IFDIR|0755, st_nlink=10, st_uid=0, st_gid=0,
st_blksize=4096, st_blocks=40, st_size=16384,
st_atime=2019/08/27-19:10:29.491261022,
st_mtime=2019/08/27-19:08:54.833579460,
st_ctime=2019/08/27-19:08:54.833579460}) = 0
[pid  3559] lstat("/opt/libreoffice6.3/program/libuno_cppu.so.3",
{st_dev=makedev(8, 1), st_ino=67735646, st_mode=S_IFREG|0755, st_nlink=1,
st_uid=0, st_gid=0, st_blksize=4096, st_blocks=472, st_size=240680,
st_atime=2019/08/27-19:03:53.516776348, st_mtime=2019/08/06-14:09:51,
st_ctime=2019/08/26-11:09:06.065132190}) = 0
[pid  3559] munmap(0x7fb32edde000, 57362) = 0
[pid  3559] close(4)= 0
[pid  3559] munmap(0x7fb32ed38000, 678980) = 0
[pid  3559] close(6)= 0
[pid  3559] munmap(0x7fb32ece2000, 350966) = 0
[pid  3559] close(7)= 0
[pid  3559] lstat("/root/.config/libreoffice/4/.lock", {st_dev=makedev(8,
1), st_ino=100990808, st_mode=S_IFREG|0644, st_nlink=1, st_uid=0, st_gid=0,
st_blksize=4096, st_blocks=8, st_size=138,
st_atime=2019/08/27-19:10:43.320068407,
st_mtime=2019/08/27-19:10:43.320068407,
st_ctime=2019/08/27-19:10:43.320068407}) = 0
[pid  3559] unlink("/root/.config/libreoffice/4/.lock") = 0
[pid  3559] socket(AF_LOCAL, SOCK_STREAM, 0) = 4
[pid  3559] connect(4, {sa_family=AF_LOCAL,
sun_path="/tmp/OSL_PIPE_0_SingleOfficeIPC_53bc4297d6d012e1a744f3977d159334"},
110) = 0
[pid  3564] <... accept resumed> NULL, NULL) = 9
[pid  3559] close(4 
[pid  3564] close(9 
[pid  3559] <... close resumed> )   = 0
[pid  3564] <... close resumed> )   = 0
[pid  3559] shutdown(5, SHUT_RDWR 
[pid  3564] madvise(0x7fb30dfae000, 8368128, MADV_DONTNEED) = 0
[pid  3559] <... shutdown resumed> )= 0
[pid  3564] exit(0) = ?
[pid  3559] close(5 
[pid  3564] +++ exited with 0 +++
[pid  3559] <... close resumed> )   = 0
[pid  3559]
unlink("/tmp/OSL_PIPE_0_SingleOfficeIPC_53bc4297d6d012e1a744f3977d159334")
= 0
[pid  3559] rt_sigaction(SIGXFSZ, {SIG_DFL, [], SA_RESTORER,
0x7fb32a239280}, NULL, 8) = 0
[pid  3559] rt_sigaction(SIGXCPU, {SIG_DFL, [], SA_RESTORER,
0x7fb32a239280}, NULL, 8) = 0
[pid  3559] rt_sigaction(SIGVTALRM, {SIG_DFL, [], SA_RESTORER,
0x7fb32a239280}, NULL, 8) = 0
[pid  3559] rt_sigaction(SIGIO, {SIG_DFL, [], SA_RESTORER, 0x7fb32a239280},
NULL, 8) = 0
[pid  3559] rt_sigaction(SIGURG, {SIG_DFL, [], SA_RESTORER,
0x7fb32a239280}, NULL, 8) = 0
[pid  3559] rt_sigaction(SIGWINCH, {SIG_DFL, [], SA_RESTORER,
0x7fb32a239280}, NULL, 8) = 0
[pid  3559] rt_sigaction(SIGPWR, {SIG_DFL, [], SA_RESTORER,
0x7fb32a239280}, NULL, 8) = 0
[pid  

[Libreoffice-bugs] [Bug 127140] Feature Request: Right click menu options for frequent documents in Windows 10 taskbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127140

Tracey C  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEEDINFO|RESOLVED

--- Comment #8 from Tracey C  ---
(In reply to V Stuart Foote from comment #3)

> =-ref-=
> 
> https://www.tenforums.com/tutorials/3469-turn-off-recent-items-frequent-
> places-windows-10-a.html

Thank you for the informational link on showing / hiding the recently used
documents in Windows. Apparently that had been turned off. I turned it back on,
and this has made LO show recent documents in Windows from the task bar right
click menu as well as the Start menu entry.

After re-testing on MacOS I also see recent documents there. So apparently this
was a Windows setting issue rather than a LO issue.

(In reply to Jan-Marek Glogowski from comment #7)

> > 2 - There  is an option to pin documents to a list of pinned documents
> 
> That is a completely different enhancement request. I don't know if any OS
> offers support for this in the context of recent document handling (or even
> outside), but I guess that would need some LO-only implementation, to save a
> "pinned documents" list. I don't think these could be available as part of
> the recent file lists. Should be handled in an extra bug report IMHO.

Fair point about pinned documents being a different feature request, given that
this turned out to be a Windows setting issue. I will open a separate issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127132] In LibreOffice Calc (Dutch), the tab "Extra" is called "Exta"...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127132

--- Comment #5 from Marqeaux  ---
Created attachment 153694
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153694=edit
The misspelled tab "Extra" is also shown in Windows (both 7 and 10)

The misspelled tab "Extra" is also shown in Windows 7 and 10 (and probably also
in 8 and 8.1). A fresh user profile doesn't do the trick, and the word "Exta"
remains.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127132] In LibreOffice Calc (Dutch), the tab "Extra" is called "Exta"...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127132

--- Comment #4 from Marqeaux  ---
(In reply to Julien Nabet from comment #3)
> On which env are you?
> For the test, could you rename your LO directory profile (see
> https://wiki.documentfoundation.org/UserProfile) and give a new try?
> 
> If you still reproduce this, could you provide detailed step by step process?
> Indeed, on master sources updated today, I don't reproduce this.
I'm on Linux (several distro's) and sometimes on Windows (7 and 10), but it's
shows on every environment/platform.

I renamed the user profile (on both Linux and Windows), but no effect
whatsoever. The tab "Extra" is still named "Exta", even with a fresh profile. I
don't know if this misspelling is also the case with other locales other than
the Dutch language, but LibreOffice in the Dutch locale shows "Exta". This is
the case in LO 6.2.* and 6.3.0.0.

I filed this misspelling before (don't know why I can't find it anywhere
anymore), and there was also said that this misspelling was removed from the
master sources. But unfortunately this misspelled word is still present in LO
6.3.

Because you can't find it in the master sources, could it be possible that the
misspelling is not in LibreOffice itself, but in the files that translates the
GUI to the Dutch language?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Problems with LineStyle Dash-Dot definitions in standard.sod

[Regina Henschel]

Hi all,

I'm working on import and export of Dash-Dot LineStyles. I have not yet 
checked whether it does not break a unit test. But from visual 
appearance and file format these works already:


Roundtrip in pptx and ppt format with MS Office preset dash definitions.

Roundtrip in pptx format with custom LineStyle definitions as far as 
possible. There are some principle incompatible things: OOXML dash 
length is always relative to line width, but ODF allows absolute dash 
length. OOXML allows a arbitrary number of dash kinds in one definition, 
but ODF allows only one or two. OOXML allows different space length in 
one definition, but ODF has only a single space length.


Now my problem:
The current set of LineStyles in standard.sod is a mix of styles with 
absolute dash length and relative dash length. None of the definitions 
corresponds to a MS Office preset definition. Roundtrip with MS binary 
format does not work at all.


So what to do?
Map the styles from standard.sod to a roughly fitting MS Office preset 
definition on export to ppt?


Get rid of the current set in standard.sod and provide instead only the 
MS preset dash definitions in standard.sod?


Is it even possible to use custom dash definitions in binary format? If 
so, how do you do it and is it worth to implement?


Kind regards
Regina


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 113869] [META] MS Office XML formats (pre-OOXML) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113869

Kohei Yoshida  changed:

   What|Removed |Added

 Depends on|75726   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=75726
[Bug 75726] importing MSO2003 xls w/ merged cells corrupts conditional
formatting
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75726] importing MSO2003 xls w/ merged cells corrupts conditional formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75726

Kohei Yoshida  changed:

   What|Removed |Added

 Blocks|113869  |

--- Comment #8 from Kohei Yoshida  ---
This is a binary Excel file, not a MSO 2003 XML file.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113869
[Bug 113869] [META] MS Office XML formats (pre-OOXML) bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126739] Click-and-move textbox with image underneath, after moving image, is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126739

--- Comment #5 from mattreecebent...@gmail.com ---
Sorry no, I'm given as much energy into this as I intend to.
Best of luck.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127190] FILESAVE: math crashes when export to pdf

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127190

MM  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
Crash report or||crashreport.libreoffice.org
crash signature||/stats/crash_details/5e15b8
   ||9f-4b81-4e44-b81f-fa98b7491
   ||ebc
 Ever confirmed|0   |1

--- Comment #1 from MM  ---
Confirmed on windows 7 x64 with Version: 6.2.6.2 (x64)
Build ID: 684e730861356e74889dfe6dbddd3562aae2e6ad
CPU threads: 3; OS: Windows 6.1; UI render: default; VCL: win

crashreport.libreoffice.org/stats/crash_details/5e15b89f-4b81-4e44-b81f-fa98b7491ebc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127190] New: FILESAVE: math crashes when export to pdf

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127190

Bug ID: 127190
   Summary: FILESAVE: math crashes when export to pdf
   Product: LibreOffice
   Version: 6.2.6.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Formula Editor
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vincent_hy...@hotmail.com

Title says all. Open math, create a formula, export to pdf, boom it crashes.
I've clicked to send reports to LO.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127189] Editing a particular math formula destroys the UI under GTK3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127189

--- Comment #13 from Laurent BP  ---
(In reply to Laurent BP from comment #12)
> Equation is visible (except the big underbrace "ce qui entre") also with
> LibreOffice 3.3.0 
> OOO330m19 (Build:6)
> tag libreoffice-3.3.0.4

Same behavior as LibO 3.3.0 for AOO 4.1.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127186] FORMATTING: underbrace/overbrace too narrow(tiny height) to be legible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127186

--- Comment #1 from VincentYu  ---
It's more serious when you zoom out to see 100% of the page.
Tried to insert it into draw and then export as pdf. It looked ok either zoomed
in or out. So this is probably a display/rendering problem with LO.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127189] Editing a particular math formula destroys the UI under GTK3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127189

--- Comment #12 from Laurent BP  ---
Equation is visible (except the big underbrace "ce qui entre") also with
LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127189] Editing a particular math formula destroys the UI under GTK3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127189

--- Comment #11 from Laurent BP  ---
There is no large underbrace with "ce qui entre", with any version, with any
VCL I tested. Even with old Version: 5.2.7.2
Build ID: 2b7f1e640c46ceb28adf43ee075a6e8b8439ed10
Threads CPU : 8; Version de l'OS :Linux 4.15; UI Render : par défaut; VCL :
x11; 
Locale : fr-FR (fr_FR.UTF-8); Calc: group
I saw it in small preview, preview printing and PDF export.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

[Kohei Yoshida (via logerrit)]

 sc/source/ui/xmlsource/xmlsourcedlg.cxx |   38 ++--
 1 file changed, 17 insertions(+), 21 deletions(-)

New commits:
commit 0fb2927a8fe06e6c3255544b8e4c4c9c0f5a67d3
Author: Kohei Yoshida 
AuthorDate: Tue Aug 27 16:10:08 2019 -0400
Commit: Kohei Yoshida 
CommitDate: Wed Aug 28 00:04:32 2019 +0200

Remove unnecessary braces.

As to the reason why they were there can be explained by the commit
48b35ed43db87d21a943e66cfa4f59213dcfe3a1.  They braces did make sense
before that commit.

Change-Id: Ie889d9e2404436c1cc0249dcf71bf18ebfd40636
Reviewed-on: https://gerrit.libreoffice.org/78212
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida 

diff --git a/sc/source/ui/xmlsource/xmlsourcedlg.cxx 
b/sc/source/ui/xmlsource/xmlsourcedlg.cxx
index 0cd202c8dec6..148aba1d0443 100644
--- a/sc/source/ui/xmlsource/xmlsourcedlg.cxx
+++ b/sc/source/ui/xmlsource/xmlsourcedlg.cxx
@@ -496,38 +496,34 @@ void ScXMLSourceDlg::OkPressed()
 ScOrcusImportXMLParam aParam;
 
 // Convert single cell links.
+for (const auto& rEntry : maCellLinks)
 {
-for (const auto& rEntry : maCellLinks)
-{
-OUString aPath = getXPath(*mxLbTree, *rEntry, aParam.maNamespaces);
-const ScOrcusXMLTreeParam::EntryData* pUserData = 
ScOrcusXMLTreeParam::getUserData(*mxLbTree, *rEntry);
+OUString aPath = getXPath(*mxLbTree, *rEntry, aParam.maNamespaces);
+const ScOrcusXMLTreeParam::EntryData* pUserData = 
ScOrcusXMLTreeParam::getUserData(*mxLbTree, *rEntry);
 
-aParam.maCellLinks.emplace_back(
-pUserData->maLinkedPos, OUStringToOString(aPath, 
RTL_TEXTENCODING_UTF8));
-}
+aParam.maCellLinks.emplace_back(
+pUserData->maLinkedPos, OUStringToOString(aPath, 
RTL_TEXTENCODING_UTF8));
 }
 
 // Convert range links. For now, an element with range link takes all its
 // child elements as its fields.
+for (const auto& rEntry: maRangeLinks)
 {
-for (const auto& rEntry: maRangeLinks)
-{
-const ScOrcusXMLTreeParam::EntryData* pUserData = 
ScOrcusXMLTreeParam::getUserData(*mxLbTree, *rEntry);
+const ScOrcusXMLTreeParam::EntryData* pUserData = 
ScOrcusXMLTreeParam::getUserData(*mxLbTree, *rEntry);
 
-ScOrcusImportXMLParam::RangeLink aRangeLink;
-aRangeLink.maPos = pUserData->maLinkedPos;
+ScOrcusImportXMLParam::RangeLink aRangeLink;
+aRangeLink.maPos = pUserData->maLinkedPos;
 
-// Go through all its child elements.
-getFieldLinks(aRangeLink, aParam.maNamespaces, *mxLbTree, *rEntry);
+// Go through all its child elements.
+getFieldLinks(aRangeLink, aParam.maNamespaces, *mxLbTree, *rEntry);
 
-// Add the reference entry as a row-group node, which will be used
-// as a row position increment point.
-OUString aThisEntry = getXPath(*mxLbTree, *rEntry, 
aParam.maNamespaces);
-aRangeLink.maRowGroups.push_back(
-OUStringToOString(aThisEntry, RTL_TEXTENCODING_UTF8));
+// Add the reference entry as a row-group node, which will be used
+// as a row position increment point.
+OUString aThisEntry = getXPath(*mxLbTree, *rEntry, 
aParam.maNamespaces);
+aRangeLink.maRowGroups.push_back(
+OUStringToOString(aThisEntry, RTL_TEXTENCODING_UTF8));
 
-aParam.maRangeLinks.push_back(aRangeLink);
-}
+aParam.maRangeLinks.push_back(aRangeLink);
 }
 
 // Remove duplicate namespace IDs.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 127188] FORMATTING adding decimal places changes format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127188

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
Version|6.2.5.2 release |Inherited From OOo

--- Comment #1 from m.a.riosv  ---
Repro
Aoo 4.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: dbaccess/source sd/source writerfilter/source

[Andrea Gelmini (via logerrit)]

 dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx|4 ++--
 sd/source/core/sdpage.cxx|4 ++--
 writerfilter/source/dmapper/DomainMapperTableManager.cxx |2 +-
 writerfilter/source/rtftok/rtfsprm.cxx   |2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit bde3c5329f953f2a89e76e5677e8484564f4408b
Author: Andrea Gelmini 
AuthorDate: Tue Aug 27 23:09:41 2019 +0200
Commit: Julien Nabet 
CommitDate: Tue Aug 27 23:32:43 2019 +0200

Fix typos

Change-Id: If2fcd9aaf920f30b49a7bb828ba174939b13a3e7
Reviewed-on: https://gerrit.libreoffice.org/78091
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx 
b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
index deaedd84fbc1..513687abfa98 100644
--- a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
+++ b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
@@ -2067,7 +2067,7 @@ static const long nVisibleRowMask[] =
 sal_Int32 OSelectionBrowseBox::GetNoneVisibleRows() const
 {
 sal_Int32 nErg(0);
-// only the first 11 row are interesting
+// only the first 11 rows are interesting
 sal_Int32 const nSize = SAL_N_ELEMENTS(nVisibleRowMask);
 for(sal_Int32 i=0;i obj = objectChildren->item(j);
 OUString nodename = obj->getNodeName();
 
-//check whether children is blank 'text-node' or 
'object-prop' node
+//check whether child is blank 'text-node' or 
'object-prop' node
 if(nodename == "object-prop")
 {
 Reference ObjAttributes = 
obj->getAttributes();
@@ -1383,7 +1383,7 @@ static void CalcAutoLayoutRectangles( SdPage const & 
rPage,::tools::Rectangle* r
 Reference presobj = layoutChildren->item(j);
 nodename=presobj->getNodeName();
 
-//check whether children is blank 'text-node' or 'presobj' node
+//check whether child is blank 'text-node' or 'presobj' node
 if(nodename == "presobj")
 {
 // TODO: rework sd to permit arbitrary number of presentation 
objects
diff --git a/writerfilter/source/dmapper/DomainMapperTableManager.cxx 
b/writerfilter/source/dmapper/DomainMapperTableManager.cxx
index 9b9f884e7b5a..13a14fb2c3d0 100644
--- a/writerfilter/source/dmapper/DomainMapperTableManager.cxx
+++ b/writerfilter/source/dmapper/DomainMapperTableManager.cxx
@@ -609,7 +609,7 @@ void DomainMapperTableManager::endOfRowAction()
 //calculate number of used grids - it has to match the size of m_aTableGrid
 size_t nGrids = std::accumulate(pCurrentSpans->begin(), 
pCurrentSpans->end(), sal::static_int_cast(0));
 
-// sj: the grid is having no units... they is containing only relative 
values.
+// sj: the grid is having no units... it is containing only relative 
values.
 // a table with a grid of "1:2:1" looks identical as if the table is having
 // a grid of "20:40:20" and it doesn't have to do something with the 
tableWidth
 // -> so we have get the sum of each grid entry for the fullWidthRelative:
diff --git a/writerfilter/source/rtftok/rtfsprm.cxx 
b/writerfilter/source/rtftok/rtfsprm.cxx
index 7d2de7c0bb79..6ba986e6b987 100644
--- a/writerfilter/source/rtftok/rtfsprm.cxx
+++ b/writerfilter/source/rtftok/rtfsprm.cxx
@@ -202,7 +202,7 @@ static bool isSPRMDeduplicateBlacklist(Id nId)
 }
 }
 
-/// Should this SPRM be removed if all its children is removed?
+/// Should this SPRM be removed if all its children are removed?
 static bool isSPRMChildrenExpected(Id nId)
 {
 switch (nId)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 127189] Editing a particular math formula destroys the UI under GTK3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127189

--- Comment #10 from Jean-Baptiste Faure  ---
(In reply to Laurent BP from comment #9)
> I do NOT reproduce with:
> - Version: 6.0.7.2
> Build ID: 78c12ce5f2b8960f18b204a7ea82f971769f1679
> Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk2; 
> Locale : fr-FR (fr_FR.UTF-8); Calc: group
> - Version: 6.1.6.3
> Build ID: 5896ab1714085361c45cf540f76f60673dd96a72
> Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk2; 
> Locale : fr-FR (fr_FR.UTF-8); Calc: group threaded
> 
> I DO reproduce with:
> - Version: 6.2.6.2
> Build ID: 684e730861356e74889dfe6dbddd3562aae2e6ad
> Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3; 
> Locale : fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR
> Calc: threaded

Do you see the big underbrace with gtk2 ?

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

[Kohei Yoshida (via logerrit)]

 sc/source/filter/orcus/xmlcontext.cxx |   18 ++
 1 file changed, 6 insertions(+), 12 deletions(-)

New commits:
commit 5c59051deb1b1294b3a6985bc753d639bf943fae
Author: Kohei Yoshida 
AuthorDate: Tue Aug 27 14:05:20 2019 -0400
Commit: Kohei Yoshida 
CommitDate: Tue Aug 27 23:19:27 2019 +0200

Use lambda expression here instead of a function object.

Change-Id: I469cc9fa0506153e6dc4ff8fe6d5bad19c02b285
Reviewed-on: https://gerrit.libreoffice.org/78208
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida 

diff --git a/sc/source/filter/orcus/xmlcontext.cxx 
b/sc/source/filter/orcus/xmlcontext.cxx
index 18574b0c2a1f..489878391b29 100644
--- a/sc/source/filter/orcus/xmlcontext.cxx
+++ b/sc/source/filter/orcus/xmlcontext.cxx
@@ -135,17 +135,6 @@ public:
 }
 };
 
-class InsertFieldPath
-{
-orcus::orcus_xml& mrFilter;
-public:
-explicit InsertFieldPath(orcus::orcus_xml& rFilter) : mrFilter(rFilter) {}
-void operator() (const OString& rPath)
-{
-mrFilter.append_field_link(rPath.getStr());
-}
-};
-
 void loadContentFromURL(const OUString& rURL, std::string& rStrm)
 {
 ucbhelper::Content aContent(
@@ -274,7 +263,12 @@ void ScOrcusXMLContextImpl::importXML(const 
ScOrcusImportXMLParam& rParam)
 OUStringToOString(aTabName, RTL_TEXTENCODING_UTF8).getStr(),
 rLink.maPos.Row(), rLink.maPos.Col());
 
-std::for_each(rLink.maFieldPaths.begin(), 
rLink.maFieldPaths.end(), InsertFieldPath(filter));
+std::for_each(rLink.maFieldPaths.begin(), rLink.maFieldPaths.end(),
+[](const OString& rFieldPath)
+{
+filter.append_field_link(rFieldPath.getStr());
+}
+);
 
 std::for_each(rLink.maRowGroups.begin(), rLink.maRowGroups.end(),
 [] (const OString& rRowGroup)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 127189] Editing a particular math formula destroys the UI under GTK3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127189

--- Comment #9 from Laurent BP  ---
I do NOT reproduce with:
- Version: 6.0.7.2
Build ID: 78c12ce5f2b8960f18b204a7ea82f971769f1679
Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk2; 
Locale : fr-FR (fr_FR.UTF-8); Calc: group
- Version: 6.1.6.3
Build ID: 5896ab1714085361c45cf540f76f60673dd96a72
Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk2; 
Locale : fr-FR (fr_FR.UTF-8); Calc: group threaded

I DO reproduce with:
- Version: 6.2.6.2
Build ID: 684e730861356e74889dfe6dbddd3562aae2e6ad
Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3; 
Locale : fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127189] Editing a particular math formula destroys the UI under GTK3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127189

Laurent BP  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||jumbo4...@yahoo.fr
 Status|UNCONFIRMED |NEW

--- Comment #8 from Laurent BP  ---
I can reproduce with Version: 6.3.0.4
Build ID: 057fc023c990d676a43019934386b85b21a9ee99
Threads CPU : 8; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3; 
Locale : fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - svx/source

[Tamás Zolnai (via logerrit)]

 svx/source/svdraw/svdedtv1.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 78172b81a4cabdd39bea4dd037c3cd8309d6c57a
Author: Tamás Zolnai 
AuthorDate: Fri Nov 23 13:01:02 2018 +0100
Commit: Tor Lillqvist 
CommitDate: Tue Aug 27 22:25:55 2019 +0200

lok: Right rotation calculation in case of delta angle

Change-Id: Ia7d0a573c1902fba3fc1e69f425bbf2dc93a1c82
(cherry picked from commit 173953dd0ede08ad5972e48286f0d10e0d588733)
Reviewed-on: https://gerrit.libreoffice.org/78197
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tor Lillqvist 
Tested-by: Tor Lillqvist 

diff --git a/svx/source/svdraw/svdedtv1.cxx b/svx/source/svdraw/svdedtv1.cxx
index 31fc953ed2b1..c0efa3a717a4 100644
--- a/svx/source/svdraw/svdedtv1.cxx
+++ b/svx/source/svdraw/svdedtv1.cxx
@@ -1544,7 +1544,7 @@ void SdrEditView::SetGeoAttrToMarked(const SfxItemSet& 
rAttr)
 
 // rotation
 if (SfxItemState::SET == 
rAttr.GetItemState(SID_ATTR_TRANSFORM_DELTA_ANGLE, true, )) {
-nRotateAngle = static_cast(pPoolItem)->GetValue() 
+ nOldRotateAngle;
+nRotateAngle = static_cast(pPoolItem)->GetValue();
 bRotate = (nRotateAngle != 0);
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 125166] czech translation - Review Revize

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125166

--- Comment #7 from Stanislav Horacek  ---
Great, now I see - thanks a lot!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125166] czech translation - Review Revize

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125166

--- Comment #6 from Julien Nabet  ---
(In reply to Stanislav Horacek from comment #5)
> I'm sorry, I don't understand - what was the fix? I believed that the
> translation "_Revize" was correct as the source string contains the
> underscore accelerator as well.

Argh, you're right, my copy paste are wrong.
master:
https://translations.documentfoundation.org/cs/translate/#search=~Revize=source,target=159139546=0

6.2:
https://translations.documentfoundation.org/cs/translate/#search=~Revize=source,target=159920450=0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125166] czech translation - Review Revize

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=125166

--- Comment #5 from Stanislav Horacek  ---
I'm sorry, I don't understand - what was the fix? I believed that the
translation "_Revize" was correct as the source string contains the underscore
accelerator as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127189] Editing a particular math formula destroys the UI under GTK3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127189

Jean-Baptiste Faure  changed:

   What|Removed |Added

   Keywords||regression
   Severity|normal  |major
   Priority|medium  |high

--- Comment #7 from Jean-Baptiste Faure  ---
set as regression because it worked with earlier version. That said I do not
know if the problem is in LibreOffice or in libfreetype.

Set importance as high/major because user may believe that her document is
corrupted and her data are lost.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127189] Editing a particular math formula destroys the UI under GTK3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127189

--- Comment #6 from Jean-Baptiste Faure  ---
Created attachment 153693
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153693=edit
screencopy with gen plugin

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127189] Editing a particular math formula destroys the UI under GTK3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127189

--- Comment #5 from Jean-Baptiste Faure  ---
Created attachment 153692
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153692=edit
screencopy with gtk3 plugin (editing)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127189] Editing a particular math formula destroys the UI under GTK3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127189

--- Comment #4 from Jean-Baptiste Faure  ---
Created attachment 153691
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153691=edit
screencopy with gtk3 plugin (view)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127169] Auto-redaction doesn't cover the title completely

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127169

Muhammet Kara  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |muhammet.k...@collabora.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127189] Editing a particular math formula destroys the UI under GTK3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127189

--- Comment #2 from Jean-Baptiste Faure  ---
Created attachment 153689
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153689=edit
test file with embedded formula from real life

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127189] Editing a particular math formula destroys the UI under GTK3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127189

--- Comment #3 from Jean-Baptiste Faure  ---
Created attachment 153690
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153690=edit
pdf export

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107733
Bug 107733 depends on bug 74045, which changed state.

Bug 74045 Summary: SLIDESHOW: ImageMap hyperlink doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=74045

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/src

[Tomaž Vajngerl (via logerrit)]

 loleaflet/src/layer/tile/TileLayer.js  |3 ++-
 loleaflet/src/layer/vector/SVGGroup.js |9 ++---
 2 files changed, 8 insertions(+), 4 deletions(-)

New commits:
commit 1e044a40aa9e0b8e2313d4677755c630cb48
Author: Tomaž Vajngerl 
AuthorDate: Tue Aug 27 23:44:14 2019 +0900
Commit: Tomaž Vajngerl 
CommitDate: Tue Aug 27 21:59:36 2019 +0200

suppress mouseout even when dragging a graphic selection

This fixes the problem when a mouseout event interrupts dragging
of a graphic selection. Not sure if it is the most correct thing
to do, but we can't set "pointer-events" to none on the graphic
selection as this then wouldn't recognise that we want to move
it around.

Change-Id: I42a4785fec0b674d47cd4d7c2977877607b03db8
Reviewed-on: https://gerrit.libreoffice.org/78200
Reviewed-by: Tomaž Vajngerl 
Tested-by: Tomaž Vajngerl 

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index bbd91a889..95b489b84 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -2373,7 +2373,8 @@ L.TileLayer = L.GridLayer.extend({
transform: true,
stroke: false,
fillOpacity: 0,
-   fill: true
+   fill: true,
+   ignoreMouseOut: true
});
 
if (!this._graphicMarker) {
diff --git a/loleaflet/src/layer/vector/SVGGroup.js 
b/loleaflet/src/layer/vector/SVGGroup.js
index c0297e080..203d0f63a 100644
--- a/loleaflet/src/layer/vector/SVGGroup.js
+++ b/loleaflet/src/layer/vector/SVGGroup.js
@@ -7,7 +7,8 @@ L.SVGGroup = L.Layer.extend({
 
options: {
noClip: true,
-   manualDrag: false
+   manualDrag: false,
+   ignoreMouseOut: false
},
 
initialize: function (bounds, options) {
@@ -64,7 +65,8 @@ L.SVGGroup = L.Layer.extend({
if (!this.options.manualDrag) {
L.DomEvent.on(this._dragShape, 'mousemove', 
this._onDrag, this);
L.DomEvent.on(this._dragShape, 'mouseup', 
this._onDragEnd, this);
-   L.DomEvent.on(this._dragShape, 'mouseout', 
this._onDragEnd, this);
+   if (!this.options.ignoreMouseOut)
+   L.DomEvent.on(this._dragShape, 'mouseout', 
this._onDragEnd, this);
}
 
var data = {
@@ -99,7 +101,8 @@ L.SVGGroup = L.Layer.extend({
if (!this.options.manualDrag) {
L.DomEvent.off(this._dragShape, 'mousemove', 
this._onDrag, this);
L.DomEvent.off(this._dragShape, 'mouseup', 
this._onDragEnd, this);
-   L.DomEvent.off(this._dragShape, 'mouseout', 
this._onDragEnd, this);
+   if (!this.options.ignoreMouseOut)
+   L.DomEvent.off(this._dragShape, 'mouseout', 
this._onDragEnd, this);
}
 
this._moved = false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: slideshow/CppunitTest_slideshow.mk slideshow/Library_slideshow.mk slideshow/source

[Samuel Mehrbrodt (via logerrit)]

 slideshow/CppunitTest_slideshow.mk |2 
 slideshow/Library_slideshow.mk |1 
 slideshow/source/engine/slide/shapemanagerimpl.cxx |   50 ++---
 slideshow/source/engine/slide/shapemanagerimpl.hxx |7 ++
 slideshow/source/engine/slide/slideimpl.cxx|3 -
 5 files changed, 56 insertions(+), 7 deletions(-)

New commits:
commit ae94ed1ffca7ec7fa86f3fd650dbee74db0565d6
Author: Samuel Mehrbrodt 
AuthorDate: Mon Aug 26 22:04:37 2019 +0200
Commit: Samuel Mehrbrodt 
CommitDate: Tue Aug 27 21:58:17 2019 +0200

tdf#74045 Make ImageMaps in slideshow clickable

Change-Id: I151983ce34a58c0f0d4b1e912f43525de4c0ad28
Reviewed-on: https://gerrit.libreoffice.org/78157
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 

diff --git a/slideshow/CppunitTest_slideshow.mk 
b/slideshow/CppunitTest_slideshow.mk
index d72a0409d63b..030a4baa1fa5 100644
--- a/slideshow/CppunitTest_slideshow.mk
+++ b/slideshow/CppunitTest_slideshow.mk
@@ -29,6 +29,8 @@ $(eval $(call gb_CppunitTest_use_libraries,slideshow,\
 sal \
 salhelper \
 svt \
+svx \
+svxcore \
 tl \
 utl \
 vcl \
diff --git a/slideshow/Library_slideshow.mk b/slideshow/Library_slideshow.mk
index d1526754a1fb..0b958305 100644
--- a/slideshow/Library_slideshow.mk
+++ b/slideshow/Library_slideshow.mk
@@ -48,6 +48,7 @@ $(eval $(call gb_Library_use_libraries,slideshow,\
 sal \
 salhelper \
 svt \
+svxcore \
 tl \
 utl \
 vcl \
diff --git a/slideshow/source/engine/slide/shapemanagerimpl.cxx 
b/slideshow/source/engine/slide/shapemanagerimpl.cxx
index d498e50cf90f..54be9f9daf60 100644
--- a/slideshow/source/engine/slide/shapemanagerimpl.cxx
+++ b/slideshow/source/engine/slide/shapemanagerimpl.cxx
@@ -17,17 +17,26 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-
+#include 
+#include 
 #include 
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
+#include 
+#include 
 
 #include "shapemanagerimpl.hxx"
 
 #include 
 
-using namespace com::sun::star;
+using namespace css;
+using namespace css::uno;
+using namespace css::drawing;
+using namespace css::system;
 
 namespace slideshow {
 namespace internal {
@@ -36,7 +45,8 @@ ShapeManagerImpl::ShapeManagerImpl( EventMultiplexer& 
   rMultiplexer,
 LayerManagerSharedPtr const& rLayerManager,
 CursorManager&   
rCursorManager,
 const ShapeEventListenerMap& 
rGlobalListenersMap,
-const ShapeCursorMap&
rGlobalCursorMap ):
+const ShapeCursorMap&
rGlobalCursorMap,
+const Reference& xDrawPage ):
 mrMultiplexer(rMultiplexer),
 mpLayerManager(rLayerManager),
 mrCursorManager(rCursorManager),
@@ -45,7 +55,8 @@ ShapeManagerImpl::ShapeManagerImpl( EventMultiplexer& 
   rMultiplexer,
 maShapeListenerMap(),
 maShapeCursorMap(),
 maHyperlinkShapes(),
-mbEnabled(false)
+mbEnabled(false),
+mxDrawPage(xDrawPage)
 {
 }
 
@@ -126,6 +137,17 @@ bool ShapeManagerImpl::handleMouseReleased( 
awt::MouseEvent const& e )
 return true; // event consumed
 }
 
+// tdf#74045 Handle ImageMaps
+OUString const imageMapLink(checkForImageMap(e));
+if (!imageMapLink.isEmpty())
+{
+Reference exec(
+
SystemShellExecute::create(comphelper::getProcessComponentContext()));
+exec->execute(imageMapLink, OUString(), 
SystemShellExecuteFlags::URIS_ONLY);
+
+return true;
+}
+
 // find matching shape (scan reversely, to coarsely match
 // paint order)
 auto aCurrBroadcaster = std::find_if(maShapeListenerMap.rbegin(), 
maShapeListenerMap.rend(),
@@ -172,7 +194,7 @@ bool ShapeManagerImpl::handleMouseMoved( const 
awt::MouseEvent& e )
 const ::basegfx::B2DPoint aPosition( e.X, e.Y );
 sal_Int16 nNewCursor(-1);
 
-if( !checkForHyperlink(aPosition).isEmpty() )
+if( !checkForHyperlink(aPosition).isEmpty() || 
!checkForImageMap(e).isEmpty() )
 {
 nNewCursor = awt::SystemPointer::REFHAND;
 }
@@ -362,6 +384,24 @@ OUString ShapeManagerImpl::checkForHyperlink( 
basegfx::B2DPoint const& hitPos )
 return OUString();
 }
 
+OUString ShapeManagerImpl::checkForImageMap( awt::MouseEvent const& evt ) const
+{
+for (sal_Int32 i = 0; i < mxDrawPage->getCount(); i++)
+{
+Reference xShape(mxDrawPage->getByIndex(i), UNO_QUERY_THROW);
+SvxShape* pShape = 
comphelper::getUnoTunnelImplementation(xShape);
+SdrObject* pObj = pShape ? pShape->GetSdrObject() : nullptr;
+if (!pObj)
+continue;
+const IMapObject* pIMapObj = SvxIMapInfo::GetHitIMapObject(pObj, 
Point(evt.X, evt.Y));
+if (pIMapObj && !pIMapObj->GetURL().isEmpty())
+  

[Libreoffice-bugs] [Bug 127189] Editing a particular math formula destroys the UI under GTK3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127189

--- Comment #1 from Jean-Baptiste Faure  ---
Created attachment 153688
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153688=edit
test file (math formula)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127183] EDITING: Selection of words by double click and mouse move

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127183

i...@scito.ch changed:

   What|Removed |Added

Summary|UI: Selection of words by   |EDITING: Selection of words
   |double click and mouse move |by double click and mouse
   ||move

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127189] New: Editing a particular math formula destroys the UI under GTK3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127189

Bug ID: 127189
   Summary: Editing a particular math formula destroys the UI
under GTK3
   Product: LibreOffice
   Version: 6.0.7.3 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Formula Editor
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jbfa...@libreoffice.org

Description:
In the formmula {expression_1} underbrace {expression_2} if expression_1 is
large enough, the UI disappears and it is not possible to recover it without
closing LO.

Steps to Reproduce:
0. download first attachment (test_formula.odf)
1. in a terminal, launch LO with the following command : SAL_USE_VCLPLUGIN=gtk3
libreoffice6.3 test_formula.odf
2. in the command panel, add one letter at the end of first expression
(ABCD...)
3.

Actual Results:
View panel and command panel disappear and it is not possible to recover the
hand on LO. The only thing to do is to close LO using Ctrl+Q or the main menu.

In the terminal, I get several blocs of the following error messages:
(soffice:18182): Gtk-WARNING **: 21:32:09.346: drawing failure for widget
'OOoFixed': error occurred in libfreetype
(soffice:18182): Gtk-WARNING **: 21:32:09.346: drawing failure for widget
'GtkEventBox': error occurred in libfreetype
(soffice:18182): Gtk-WARNING **: 21:32:09.346: drawing failure for widget
'GtkGrid': error occurred in libfreetype
(soffice:18182): Gtk-WARNING **: 21:32:09.347: drawing failure for widget
'GtkWindow': error occurred in libfreetype

No other messages than these ones. 

Same behavior if the math formula is embedded in a text document. If I open a
text document (e.g. the second attachment) containing such a formula with LO
under GTK3, the formula is not visible. If I try to edit the formula the UI
disappears. All formulas that follow the wrong formula become invisible.

If I use the generic backend  (SAL_USE_VCLPLUGIN=gen libreoffice6.3
test_formula.odf) the underbrace becomes invisible when I edit the formula but
the UI is not destroyed. 

Expected Results:
Be able to view and edit a math formula like this one. 


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Even if the formula is not visible, PDF export works as expected.

I reproduce the problem in LO 6.0 (from Ubuntu), 6.1, 6.2, 6.3 and master (all
built at home under Ubuntu 18.04 x86-64).
My version of libfreetype is 2.8.1-2ubuntu2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83946

Dieter Praas  changed:

   What|Removed |Added

 Depends on||126938


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=126938
[Bug 126938] Add shortcuts for accepting and rejecting changes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126938] Add shortcuts for accepting and rejecting changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126938

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval
 Blocks||83946


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83946
[Bug 83946] [META] Tracking changes issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 126938] Add shortcuts for accepting and rejecting changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126938

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval
 Blocks||83946


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83946
[Bug 83946] [META] Tracking changes issues
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 126739] Click-and-move textbox with image underneath, after moving image, is broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126739

Dieter Praas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||dgp-m...@gmx.de

--- Comment #4 from Dieter Praas  ---
mattreecebentley, it seems to be not so easy to reproduce this bug. Could you
add a sample document, including the first three steps.Perhaps this makes it
easier to reproduce the bug.

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the requested document is provided.
(Please note that the attachment will be public, remove any sensitive
information before attaching it)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126810] FILESAVE

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126810

Dieter Praas  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||dgp-m...@gmx.de

--- Comment #8 from Dieter Praas  ---
(In reply to steffan.steffner from comment #7)
> If this bug stays open for comments a few more days, maybe I’ll find the
> time to check on my Windows and I will post here what I found.

Stefan, any news about this bug? Shall we leave it open or shall we close it?

=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126835] Odd cursor movement when adding new rows to a Autoformattted table using tab

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126835

Dieter Praas  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126835] Odd cursor movement when adding new rows to a Autoformattted table using tab

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126835

Dieter Praas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||dgp-m...@gmx.de
 Ever confirmed|0   |1

--- Comment #1 from Dieter Praas  ---
Telesto, I miss the step about creating the table (couldn't reproduce it with a
table, that I created on my own)
=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/sfx2 sfx2/source

[Stephan Bergmann (via logerrit)]

 include/sfx2/app.hxx |2 +-
 sfx2/source/appl/app.cxx |4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 036e635678aedc414e2d55217e4f7f8359ed1b9a
Author: Stephan Bergmann 
AuthorDate: Tue Aug 27 17:45:06 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Tue Aug 27 21:25:40 2019 +0200

Fix signature of basicide_macro_organizer

see the function definition in basctl/source/basicide/basobj2.cxx

Change-Id: If19f0a82d5498795ceef26342e0152fb12ef983d
Reviewed-on: https://gerrit.libreoffice.org/78204
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/include/sfx2/app.hxx b/include/sfx2/app.hxx
index 1dbd14eaac99..e3517d3d64db 100644
--- a/include/sfx2/app.hxx
+++ b/include/sfx2/app.hxx
@@ -146,7 +146,7 @@ public:
 // Basic/Scripting
 static bool IsXScriptURL( const OUString& rScriptURL );
 static OUString ChooseScript(weld::Window *pParent);
-static void MacroOrganizer(const weld::Window* pParent, 
sal_Int16 nTabId);
+static void MacroOrganizer(weld::Window* pParent, 
sal_Int16 nTabId);
 static ErrCode  CallBasic( const OUString&, BasicManager*, 
SbxArray *pArgs, SbxValue *pRet );
 static ErrCode  CallAppBasic( const OUString& i_macroName )
 { return CallBasic( i_macroName, 
SfxApplication::GetBasicManager(), nullptr, nullptr ); }
diff --git a/sfx2/source/appl/app.cxx b/sfx2/source/appl/app.cxx
index 3b6a8af8ef23..1bbb425c58b7 100644
--- a/sfx2/source/appl/app.cxx
+++ b/sfx2/source/appl/app.cxx
@@ -414,7 +414,7 @@ void SfxApplication::Invalidate( sal_uInt16 nId )
 #ifndef DISABLE_DYNLOADING
 
 typedef long (*basicide_handle_basic_error)(void const *);
-typedef void (*basicide_macro_organizer)(void const *, sal_Int16);
+typedef void (*basicide_macro_organizer)(void *, sal_Int16);
 
 extern "C" { static void thisModule() {} }
 
@@ -520,7 +520,7 @@ SfxApplication::ChooseScript(weld::Window *pParent)
 return aScriptURL;
 }
 
-void SfxApplication::MacroOrganizer(const weld::Window* pParent, sal_Int16 
nTabId)
+void SfxApplication::MacroOrganizer(weld::Window* pParent, sal_Int16 nTabId)
 {
 #if !HAVE_FEATURE_SCRIPTING
 (void) pParent;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/svx svx/source

[Noel Grandin (via logerrit)]

 include/svx/svdobj.hxx|2 --
 include/svx/svdoedge.hxx  |2 --
 svx/source/svdraw/svdpage.cxx |2 +-
 3 files changed, 1 insertion(+), 5 deletions(-)

New commits:
commit 61c97e941b1d73bf94293f05fdd26636b55a4bce
Author: Noel Grandin 
AuthorDate: Tue Aug 27 14:45:13 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Aug 27 21:19:16 2019 +0200

no need to add a new virtual method (tdf#119388 related)

we can re-use the existing GetObjIdentifier infrastructure

Change-Id: Ie604d643186a925da41a1e67ccd5f2461ceb20f1
Reviewed-on: https://gerrit.libreoffice.org/78193
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/svx/svdobj.hxx b/include/svx/svdobj.hxx
index 2d3dd91f90c0..0b1e5c3a832b 100644
--- a/include/svx/svdobj.hxx
+++ b/include/svx/svdobj.hxx
@@ -911,8 +911,6 @@ public:
 
 void setSuitableOutlinerBg(Outliner& rOutliner) const;
 
-virtual bool IsSdrEdgeObj() const { return false; }
-
 protected:
 tools::RectangleaOutRect; // surrounding rectangle for 
Paint (incl. LineWidth, ...)
 Point   aAnchor;  // anchor position (Writer)
diff --git a/include/svx/svdoedge.hxx b/include/svx/svdoedge.hxx
index f2b707f7fbe2..16127d914ec8 100644
--- a/include/svx/svdoedge.hxx
+++ b/include/svx/svdoedge.hxx
@@ -168,8 +168,6 @@ public:
 void SetSuppressDefaultConnect(bool bNew) { mbSuppressDefaultConnect = 
bNew; }
 bool GetSuppressDefaultConnect() const { return mbSuppressDefaultConnect; }
 
-virtual bool IsSdrEdgeObj() const override { return true; }
-
 protected:
 virtual void Notify(SfxBroadcaster& rBC, const SfxHint& rHint) override;
 
diff --git a/svx/source/svdraw/svdpage.cxx b/svx/source/svdraw/svdpage.cxx
index 0d38249b2d04..ae0a0c3cc1e3 100644
--- a/svx/source/svdraw/svdpage.cxx
+++ b/svx/source/svdraw/svdpage.cxx
@@ -613,7 +613,7 @@ void SdrObjList::ReformatAllEdgeObjects()
 while(aIter.IsMore())
 {
 SdrObject* pObj = aIter.Next();
-if (!pObj->IsSdrEdgeObj())
+if (pObj->GetObjIdentifier() != OBJ_EDGE)
 continue;
 
 SdrEdgeObj* pSdrEdgeObj = static_cast< SdrEdgeObj* >(pObj);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 119388] Calc freezes in Linux and very slow in Windows after trying to delete column or line in much compressed ods with lot of draw:custom-shape

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119388

--- Comment #20 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/61c97e941b1d73bf94293f05fdd26636b55a4bce%5E%21

no need to add a new virtual method (tdf#119388 related)

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: fpicker/source

[Stephan Bergmann (via logerrit)]

 fpicker/source/office/iodlg.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 83c004d9b85b920f9de21c429ef4495db45f12e0
Author: Stephan Bergmann 
AuthorDate: Tue Aug 27 16:41:39 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Tue Aug 27 21:18:44 2019 +0200

Fix ASan heap-use-after-free

...when opening a document via "File - Open..." with "Tools - Options... -
LibreOffice - General - Open/Save Dialogs - Use LibreOffice dialogs" 
enabled:

> ==7004==ERROR: AddressSanitizer: heap-use-after-free on address 
0x61700023a370 at pc 0x7f88c788db4a bp 0x7ffd8c7d0020 sp 0x7ffd8c7d0018
> READ of size 8 at 0x61700023a370 thread T0
>  #0 in rtl::Reference::get() const at 
include/rtl/ref.hxx:171:16
>  #1 in VclPtr::operator bool() const at 
include/vcl/vclptr.hxx:187:28
>  #2 in CustomContainer::GetFocus() at 
fpicker/source/office/iodlg.cxx:433:39
>  #3 in vcl::Window::CompatGetFocus() at 
vcl/source/window/window.cxx:3731:5
>  #4 in vcl::Window::ImplGrabFocus(GetFocusFlags) at 
vcl/source/window/mouse.cxx:380:17
>  #5 in vcl::Window::GrabFocus() at vcl/source/window/window.cxx:2991:5
>  #6 in vcl::Window::dispose() at vcl/source/window/window.cxx:448:26
>  #7 in Control::dispose() at vcl/source/control/ctrl.cxx:62:13
>  #8 in SvtFileView::dispose() at svtools/source/contnr/fileview.cxx:879:14
[...]
> 0x61700023a370 is located 496 bytes inside of 648-byte region 
[0x61700023a180,0x61700023a408)
> freed by thread T0 here:
>  #0 in operator delete(void*, unsigned long) at 
llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:172:3
>  #1 in 
std::default_delete::operator()(SvtExpFileDlg_Impl*) const 
at 
gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/10.0.0/../../../../include/c++/10.0.0/bits/unique_ptr.h:81:2
>  #2 in std::__uniq_ptr_impl >::reset(SvtExpFileDlg_Impl*) at 
gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/10.0.0/../../../../include/c++/10.0.0/bits/unique_ptr.h:178:4
>  #3 in std::unique_ptr >::reset(SvtExpFileDlg_Impl*) at 
gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/10.0.0/../../../../include/c++/10.0.0/bits/unique_ptr.h:444:7
>  #4 in SvtFileDialog::dispose() at fpicker/source/office/iodlg.cxx:523:11
[...]

Change-Id: I022eac69123d87f75bda5067a672496030e1a8ec
Reviewed-on: https://gerrit.libreoffice.org/78199
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/fpicker/source/office/iodlg.cxx b/fpicker/source/office/iodlg.cxx
index f307abadbcdb..b8f587ca2a6a 100644
--- a/fpicker/source/office/iodlg.cxx
+++ b/fpicker/source/office/iodlg.cxx
@@ -520,8 +520,8 @@ void SvtFileDialog::dispose()
 batch->commit();
 }
 
-pImpl.reset();
 _pFileView.disposeAndClear();
+pImpl.reset();
 _pSplitter.disposeAndClear();
 _pContainer.disposeAndClear();
 _pPrevBmp.disposeAndClear();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/unx

[Stephan Bergmann (via logerrit)]

 vcl/unx/gtk/fpicker/SalGtkPicker.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 084a263049ecc916bbf7300e45e613a687eb67f2
Author: Stephan Bergmann 
AuthorDate: Tue Aug 27 17:37:50 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Tue Aug 27 21:03:38 2019 +0200

Fix typo (translateToExternal vs. translateToInternal)

...introduced with e4f37435a0fdd66b2d58633c991c6df720790f39 "fdo#46808, Use
service constructor for uri::ExternalUriReferenceTranslator":

> @@ -82,7 +82,7 @@ OString SalGtkPicker::unicodetouri(const OUString )
>  INetURLObject aURL(rURL);
>  if (INET_PROT_FILE == aURL.GetProtocol())
>  {
> -OUString aNewURL = 
uno::Reference(uno::Reference(comphelper::getProcessServiceFactory(),
 
UNO_QUERY_THROW)->createInstanceWithContext(OUString("com.sun.star.uri.ExternalUriReferenceTranslator"),
 m_xContext ), UNO_QUERY_THROW)->translateToExternal( rURL );
> +OUString aNewURL = uri::ExternalUriReferenceTranslator::create( 
m_xContext )->translateToInternal(rURL);
>
>  if( !aNewURL.isEmpty() )
>  {

Change-Id: Ib709df9ef600f2b6b61878cbb8f99d3ff7ab5c2f
Reviewed-on: https://gerrit.libreoffice.org/78203
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/vcl/unx/gtk/fpicker/SalGtkPicker.cxx 
b/vcl/unx/gtk/fpicker/SalGtkPicker.cxx
index b89a9cd9b8a7..01671fb1afc6 100644
--- a/vcl/unx/gtk/fpicker/SalGtkPicker.cxx
+++ b/vcl/unx/gtk/fpicker/SalGtkPicker.cxx
@@ -84,7 +84,7 @@ OString SalGtkPicker::unicodetouri(const OUString )
 INetURLObject aURL(rURL);
 if (INetProtocol::File == aURL.GetProtocol())
 {
-OUString aNewURL = uri::ExternalUriReferenceTranslator::create( 
m_xContext )->translateToInternal(rURL);
+OUString aNewURL = uri::ExternalUriReferenceTranslator::create( 
m_xContext )->translateToExternal(rURL);
 
 if( !aNewURL.isEmpty() )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Kohei Yoshida (via logerrit)]

 sc/source/filter/inc/orcusfiltersimpl.hxx   |2 --
 sc/source/filter/orcus/orcusfiltersimpl.cxx |   12 
 sc/source/filter/orcus/xmlcontext.cxx   |   11 +--
 3 files changed, 9 insertions(+), 16 deletions(-)

New commits:
commit d9f5a8f6cf771017a52252341b75a5d9c1c389e1
Author: Kohei Yoshida 
AuthorDate: Tue Aug 27 13:55:56 2019 -0400
Commit: Kohei Yoshida 
CommitDate: Tue Aug 27 20:55:54 2019 +0200

Use getSystemPathFromFileURL() which is exactly what we need.

Change-Id: I09b77435d1dcd1c5e717fe4f976620bcdcecfb54
Reviewed-on: https://gerrit.libreoffice.org/78206
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida 

diff --git a/sc/source/filter/inc/orcusfiltersimpl.hxx 
b/sc/source/filter/inc/orcusfiltersimpl.hxx
index ac8603c6cfaf..220e32f32608 100644
--- a/sc/source/filter/inc/orcusfiltersimpl.hxx
+++ b/sc/source/filter/inc/orcusfiltersimpl.hxx
@@ -17,8 +17,6 @@
 class ScOrcusFiltersImpl : public ScOrcusFilters
 {
 public:
-static OString toSystemPath(const OUString& rPath);
-
 virtual bool importCSV(ScDocument& rDoc, SfxMedium& rMedium) const 
override;
 virtual bool importGnumeric(ScDocument& rDoc, SfxMedium& rMedium) const 
override;
 virtual bool importExcel2003XML(ScDocument& rDoc, SfxMedium& rMedium) 
const override;
diff --git a/sc/source/filter/orcus/orcusfiltersimpl.cxx 
b/sc/source/filter/orcus/orcusfiltersimpl.cxx
index 0f3b03dbbd15..72e2f3612aaa 100644
--- a/sc/source/filter/orcus/orcusfiltersimpl.cxx
+++ b/sc/source/filter/orcus/orcusfiltersimpl.cxx
@@ -28,12 +28,6 @@
 #include 
 #include 
 
-#ifdef _WIN32
-#define SYSTEM_PATH FSysStyle::Dos
-#else
-#define SYSTEM_PATH FSysStyle::Unix
-#endif
-
 using namespace com::sun::star;
 
 namespace {
@@ -81,12 +75,6 @@ bool loadFileContent(SfxMedium& rMedium, 
orcus::iface::import_filter& filter)
 
 }
 
-OString ScOrcusFiltersImpl::toSystemPath(const OUString& rPath)
-{
-INetURLObject aURL(rPath);
-return OUStringToOString(aURL.getFSysPath(SYSTEM_PATH), 
RTL_TEXTENCODING_UTF8);
-}
-
 bool ScOrcusFiltersImpl::importCSV(ScDocument& rDoc, SfxMedium& rMedium) const
 {
 ScOrcusFactory aFactory(rDoc);
diff --git a/sc/source/filter/orcus/xmlcontext.cxx 
b/sc/source/filter/orcus/xmlcontext.cxx
index 71c44bc35823..18574b0c2a1f 100644
--- a/sc/source/filter/orcus/xmlcontext.cxx
+++ b/sc/source/filter/orcus/xmlcontext.cxx
@@ -16,6 +16,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -238,8 +239,14 @@ public:
 void ScOrcusXMLContextImpl::importXML(const ScOrcusImportXMLParam& rParam)
 {
 ScOrcusFactory aFactory(mrDoc, true);
-OString aSysPath = ScOrcusFiltersImpl::toSystemPath(maPath);
-const char* path = aSysPath.getStr();
+
+OUString aSysPath;
+if (osl::FileBase::getSystemPathFromFileURL(maPath, aSysPath) != 
osl::FileBase::E_None)
+return;
+
+OString aOSysPath = OUStringToOString(aSysPath, RTL_TEXTENCODING_UTF8);
+const char* path = aOSysPath.getStr();
+
 try
 {
 orcus::orcus_xml filter(maNsRepo, , nullptr);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/inc vcl/qt5 vcl/quartz vcl/source vcl/unx vcl/win

[Khaled Hosny (via logerrit)]

 vcl/inc/impfontmetricdata.hxx  |5 +---
 vcl/inc/sft.hxx|4 +--
 vcl/qt5/Qt5Graphics_Text.cxx   |8 --
 vcl/quartz/ctfonts.cxx |   18 ---
 vcl/source/font/fontmetric.cxx |   22 ++
 vcl/source/fontsubset/sft.cxx  |   30 -
 vcl/unx/generic/glyphs/freetype_glyphcache.cxx |   10 
 vcl/win/gdi/salfont.cxx|   10 
 8 files changed, 40 insertions(+), 67 deletions(-)

New commits:
commit 60d4be99383b6fe13ca55572c43fd022bdc73ce8
Author: Khaled Hosny 
AuthorDate: Sun Aug 25 14:12:15 2019 +0200
Commit: Khaled Hosny 
CommitDate: Tue Aug 27 20:38:19 2019 +0200

Consolidate ImplCalcLineSpacing()

Move getting UPEM and font tables to the functions and use HarfBuzz API
to get them. In the future we might stop reading the tables ourselves
and use HarfBuzz metrics API instead.

Change-Id: I3f4511628fd33200bae94cdcd96479ba3e6d2fba
Reviewed-on: https://gerrit.libreoffice.org/78081
Tested-by: Jenkins
Reviewed-by: Khaled Hosny 

diff --git a/vcl/inc/impfontmetricdata.hxx b/vcl/inc/impfontmetricdata.hxx
index 73beb59722db..6250c9155436 100644
--- a/vcl/inc/impfontmetricdata.hxx
+++ b/vcl/inc/impfontmetricdata.hxx
@@ -32,6 +32,7 @@ typedef tools::SvRef 
ImplFontMetricDataRef;
 
 class OutputDevice;
 class FontSelectPattern;
+class LogicalFontInstance;
 
 class VCL_DLLPUBLIC ImplFontMetricData : public FontAttributes, public 
SvRefBase
 {
@@ -92,9 +93,7 @@ public:
 voidImplInitTextLineSize( const OutputDevice* pDev );
 voidImplInitAboveTextLineSize();
 voidImplInitFlags( const OutputDevice* pDev );
-voidImplCalcLineSpacing(const std::vector& rHhea,
-const std::vector& rOS_2,
-int nUPEM);
+voidImplCalcLineSpacing(LogicalFontInstance *pFontInstance);
 
 private:
 boolShouldUseWinMetrics(const vcl::TTGlobalFontInfo& rInfo);
diff --git a/vcl/inc/sft.hxx b/vcl/inc/sft.hxx
index fbf570b27adb..aa81dcd151cb 100644
--- a/vcl/inc/sft.hxx
+++ b/vcl/inc/sft.hxx
@@ -419,8 +419,8 @@ namespace vcl
  * @ingroup sft
  *
  */
- void GetTTFontMetrics(const std::vector& hhea,
-   const std::vector& os2,
+ void GetTTFontMetrics(const uint8_t *pHhea, size_t nHhea,
+   const uint8_t *pOs2, size_t nOs2,
TTGlobalFontInfo *info);
 
 /**
diff --git a/vcl/qt5/Qt5Graphics_Text.cxx b/vcl/qt5/Qt5Graphics_Text.cxx
index 38723f3dd623..85b51b82b1eb 100644
--- a/vcl/qt5/Qt5Graphics_Text.cxx
+++ b/vcl/qt5/Qt5Graphics_Text.cxx
@@ -59,13 +59,7 @@ void Qt5Graphics::GetFontMetric(ImplFontMetricDataRef& rFMD, 
int nFallbackLevel)
 QRawFont aRawFont(QRawFont::fromFont(*m_pTextStyle[nFallbackLevel]));
 Qt5FontFace::fillAttributesFromQFont(*m_pTextStyle[nFallbackLevel], *rFMD);
 
-QByteArray aHheaTable = aRawFont.fontTable("hhea");
-std::vector rHhea(aHheaTable.data(), aHheaTable.data() + 
aHheaTable.size());
-
-QByteArray aOs2Table = aRawFont.fontTable("OS/2");
-std::vector rOS2(aOs2Table.data(), aOs2Table.data() + 
aOs2Table.size());
-
-rFMD->ImplCalcLineSpacing(rHhea, rOS2, aRawFont.unitsPerEm());
+rFMD->ImplCalcLineSpacing(m_pTextStyle[nFallbackLevel].get());
 
 rFMD->SetSlant(0);
 rFMD->SetWidth(aRawFont.averageCharWidth());
diff --git a/vcl/quartz/ctfonts.cxx b/vcl/quartz/ctfonts.cxx
index 06a25965653f..252720a0aa4e 100644
--- a/vcl/quartz/ctfonts.cxx
+++ b/vcl/quartz/ctfonts.cxx
@@ -110,24 +110,8 @@ void CoreTextStyle::GetFontMetric( ImplFontMetricDataRef 
const & rxFontMetric )
 // get the matching CoreText font handle
 // TODO: is it worth it to cache the CTFontRef in SetFont() and reuse it 
here?
 CTFontRef aCTFontRef = static_cast(CFDictionaryGetValue( 
mpStyleDict, kCTFontAttributeName ));
-const CoreTextFontFace* mpFontData = static_cast(GetFontFace());
 
-int nBufSize = 0;
-
-nBufSize = mpFontData->GetFontTable("hhea", nullptr);
-uint8_t* pHheaBuf = new uint8_t[nBufSize];
-nBufSize = mpFontData->GetFontTable("hhea", pHheaBuf);
-std::vector rHhea(pHheaBuf, pHheaBuf + nBufSize);
-
-nBufSize = mpFontData->GetFontTable("OS/2", nullptr);
-uint8_t* pOS2Buf = new uint8_t[nBufSize];
-nBufSize = mpFontData->GetFontTable("OS/2", pOS2Buf);
-std::vector rOS2(pOS2Buf, pOS2Buf + nBufSize);
-
-rxFontMetric->ImplCalcLineSpacing(rHhea, rOS2, 
CTFontGetUnitsPerEm(aCTFontRef));
-
-delete[] pHheaBuf;
-delete[] pOS2Buf;
+rxFontMetric->ImplCalcLineSpacing(this);
 
 // since ImplFontMetricData::mnWidth is only used for stretching/squeezing 
fonts
 // setting this width to the pixel height of the fontsize is good enough
diff --git a/vcl/source/font/fontmetric.cxx 

[Libreoffice-bugs] [Bug 70379] Cannot resize columns with protected cells / Calc does not respect users' permissions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=70379

--- Comment #10 from Roman Polach  ---
The problem is still present in newest release of
LibreOffice - Calc 6.3.0.4 (x64) under Windows 10.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source

[Miklos Vajna (via logerrit)]

 vcl/source/window/paint.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit a5cafe5d7e87c0f5ecdcffbbe58c66abcb97ac8e
Author: Miklos Vajna 
AuthorDate: Tue Aug 27 17:54:34 2019 +0200
Commit: Miklos Vajna 
CommitDate: Tue Aug 27 20:16:07 2019 +0200

tdf#91843 sd sidebar: fix unexpected borders around the slide layout 
previews

Regression from commit e5bb5c52aeaeb60c8592b004efd88c30242e03a1 (add
RenderContext to Window::PushPaintHelper, use Erase correctly,
2015-05-18), the problem was similar to tdf#92079, except here the
missing background was a solid color, not a bitmap.

Change-Id: I2221b3eabed84cf039cb8c3881442c9e23c6ec13
Reviewed-on: https://gerrit.libreoffice.org/78205
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/vcl/source/window/paint.cxx b/vcl/source/window/paint.cxx
index 8bdbc5a3b79f..2d83e3074b63 100644
--- a/vcl/source/window/paint.cxx
+++ b/vcl/source/window/paint.cxx
@@ -298,7 +298,8 @@ void PaintHelper::DoPaint(const vcl::Region* pRegion)
 // direct painting
 Wallpaper aBackground = m_pWindow->GetBackground();
 m_pWindow->ApplySettings(*m_pWindow);
-if (aBackground.IsBitmap())
+// Restore lost bitmap or solid color background.
+if (aBackground.IsBitmap() || aBackground.GetColor() != 
COL_TRANSPARENT)
 m_pWindow->SetBackground(aBackground);
 m_pWindow->PushPaintHelper(this, *m_pWindow);
 m_pWindow->Paint(*m_pWindow, m_aPaintRect);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/inc

[Khaled Hosny (via logerrit)]

 vcl/inc/fontinstance.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c997a32dbfddf791a309f179adca961336423293
Author: Khaled Hosny 
AuthorDate: Tue Aug 27 11:07:53 2019 +0200
Commit: Khaled Hosny 
CommitDate: Tue Aug 27 19:43:54 2019 +0200

Return empty HarfBuzz font instead of nullptr

hb_font_get_empty() returns an empty, singleton font object that can be
safely passed to HarfBuzz API that would otherwise crash if given a
nullptr. Keep the assert to catch calls to this code in debug builds,
since it is really a bug for LogicalFontInstance implementations without
a backed HarfBuzz font to call code that requires it.

Change-Id: I93e2b3204eb08b0c4c54587bc0f60cbf3c18c7d7
Reviewed-on: https://gerrit.libreoffice.org/78178
Tested-by: Jenkins
Reviewed-by: Khaled Hosny 

diff --git a/vcl/inc/fontinstance.hxx b/vcl/inc/fontinstance.hxx
index b22d76e3b070..b57955f82a9e 100644
--- a/vcl/inc/fontinstance.hxx
+++ b/vcl/inc/fontinstance.hxx
@@ -86,7 +86,7 @@ protected:
 
 // Takes ownership of pHbFace.
 static hb_font_t* InitHbFont(hb_face_t* pHbFace);
-virtual hb_font_t* ImplInitHbFont() { assert(false); return nullptr; }
+virtual hb_font_t* ImplInitHbFont() { assert(false); return 
hb_font_get_empty(); }
 inline void ReleaseHbFont();
 
 private:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 127108] print double-sided and in reverse order

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127108

--- Comment #5 from Simonon Olivier  ---

I will try to make myself understood, again. I am not English speaking.

The print option in reverse order prints from the last page to the first page.
I agree. 3| + 2| + 1|

The double sided option prints page 1 on the front, page 2 on the back, page 3
on the front of the second sheet. 1|2 + 3|


If I combine the two options, the printer must print first page 3 on the front
of the first sheet, then page 2 on the back of another sheet, and finally, it
prints page 1 on the front of this second sheet. 3| + 2|1

Unfortunately, when I print a 3-page text by activating both options
(double-sided and reverse order), I get page 1 of the printed text alone on one
sheet, and pages 2 and 3 on another sheet, in double sided. 3|2 + 1|

It's not normal to have page 1 alone on a sheet in this case!

Is that clear? I can not be more understandable with Google translation ...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 118909] Writer Options are not Available with XML Form Document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118909

--- Comment #3 from Harald Koester  ---
Bug still exists in version 6.3.0 (64 bit, Win10).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127026] VIEWING: SVG import to Writer: Line Thickness displayed incorrect

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127026

Christoph Bartz  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120130] No proper language choice possible in context menu neither on bottom (status ?) bar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120130

--- Comment #14 from Buovjaga  ---
(In reply to prcwnl from comment #9)
> On the bottom bar there is Polish language marked but right-click mouse menu
> allows to choose ... only Polish or reset to defoult. Why not provide also
> English there to choose?

You can choose any language by clicking "More". Then in the Font - Language
dropdown you can choose the language.

In Tools - Options - Language settings - Languages you can choose a default
language for documents. You can set it for the current document only or
globally.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122530] FILESAVE: Auto save timing logic problem: can save too frequently

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122530

--- Comment #9 from Buovjaga  ---
I tried it again, following your directions in comment 8 closely. I am not able
to observe the auto recovery info saving process no matter what I do.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127188] New: FORMATTING adding decimal places changes format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127188

Bug ID: 127188
   Summary: FORMATTING adding decimal places changes format
   Product: LibreOffice
   Version: 6.2.5.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: br...@kaskubar.org

Created attachment 153687
  --> https://bugs.documentfoundation.org/attachment.cgi?id=153687=edit
5-second video of the problem

Adding decimal places to a group of non-contiguous integer cells changes the
format (to that of an excluded cell?). Attached video shows the scenario.

To reproduce:
1. create a row or column of several integer cells
2. change one of the cells in the middle of the range to currency format
3. select the entire range of cells
4. Ctrl-click the currency cell (to exclude it from the selection)
5. poke the Add Decimal Place toolbar button
6. the selected integers have an added decimal place and are now currency

Expected behavior is a decimal place added to selected cells with retained
integer format.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc vcl/unx

[Stephan Bergmann (via logerrit)]

 vcl/inc/unx/fontmanager.hxx |2 +-
 vcl/unx/generic/fontmanager/fontmanager.cxx |4 ++--
 vcl/unx/generic/print/genpspgraphics.cxx|6 +-
 3 files changed, 4 insertions(+), 8 deletions(-)

New commits:
commit 654a1e6b3345d098e24dcdd0d81bb49add996d0b
Author: Stephan Bergmann 
AuthorDate: Tue Aug 27 16:54:51 2019 +0200
Commit: Stephan Bergmann 
CommitDate: Tue Aug 27 18:50:26 2019 +0200

Let PrintFontManager::addFontFile directly take a file URL

...instead of converting from a file URL to a filesystem pathname at the 
(sole)
call site and then back to a file URL in addFontFile

Change-Id: I468dbfc183b062668209c6bd84fcfed122ceff37
Reviewed-on: https://gerrit.libreoffice.org/78202
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/vcl/inc/unx/fontmanager.hxx b/vcl/inc/unx/fontmanager.hxx
index 88187efeb384..3c67adc70d8f 100644
--- a/vcl/inc/unx/fontmanager.hxx
+++ b/vcl/inc/unx/fontmanager.hxx
@@ -199,7 +199,7 @@ public:
 static PrintFontManager& get(); // one instance only
 
 // There may be multiple font ids for font collections
-std::vector addFontFile( const OString& rFileName );
+std::vector addFontFile( const OUString& rFileUrl );
 
 void initialize();
 
diff --git a/vcl/unx/generic/fontmanager/fontmanager.cxx 
b/vcl/unx/generic/fontmanager/fontmanager.cxx
index 8389ba279ba1..a4d07ec3bdbe 100644
--- a/vcl/unx/generic/fontmanager/fontmanager.cxx
+++ b/vcl/unx/generic/fontmanager/fontmanager.cxx
@@ -163,10 +163,10 @@ int PrintFontManager::getDirectoryAtom( const OString& 
rDirectory )
 return nAtom;
 }
 
-std::vector PrintFontManager::addFontFile( const OString& rFileName )
+std::vector PrintFontManager::addFontFile( const OUString& rFileUrl )
 {
 rtl_TextEncoding aEncoding = osl_getThreadTextEncoding();
-INetURLObject aPath( OStringToOUString( rFileName, aEncoding ), 
FSysStyle::Detect );
+INetURLObject aPath( rFileUrl );
 OString 
aName(OUStringToOString(aPath.GetLastName(INetURLObject::DecodeMechanism::WithCharset,
 aEncoding), aEncoding));
 OString aDir( OUStringToOString(
 INetURLObject::decode( aPath.GetPath(), 
INetURLObject::DecodeMechanism::WithCharset, aEncoding ), aEncoding ) );
diff --git a/vcl/unx/generic/print/genpspgraphics.cxx 
b/vcl/unx/generic/print/genpspgraphics.cxx
index 1eb73401d4ef..38a39e729fc3 100644
--- a/vcl/unx/generic/print/genpspgraphics.cxx
+++ b/vcl/unx/generic/print/genpspgraphics.cxx
@@ -671,12 +671,8 @@ bool GenPspGraphics::AddTempDevFontHelper( 
PhysicalFontCollection* pFontCollecti
GlyphCache  )
 {
 // inform PSP font manager
-OUString aUSystemPath;
-OSL_VERIFY( !osl::FileBase::getSystemPathFromFileURL( rFileURL, 
aUSystemPath ) );
-rtl_TextEncoding aEncoding = osl_getThreadTextEncoding();
-OString aOFileName( OUStringToOString( aUSystemPath, aEncoding ) );
 psp::PrintFontManager& rMgr = psp::PrintFontManager::get();
-std::vector aFontIds = rMgr.addFontFile( aOFileName );
+std::vector aFontIds = rMgr.addFontFile( rFileURL );
 if( aFontIds.empty() )
 return false;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 127187] New: Auto Strikethrough Gets in the Way

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127187

Bug ID: 127187
   Summary: Auto Strikethrough Gets in the Way
   Product: LibreOffice
   Version: 6.1.5.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kit...@tutanota.com

Description:
If a person starts with the dash symbol, everything connected to that will
become strikethrough.

To show this, try typing in the following text:
-$22-$82,000
and see what happens.

To fix it one must select all of that text and then select to Clear formatting.

I am using Debian 10.

Steps to Reproduce:
1.See above
2.
3.

Actual Results:
See above

Expected Results:
No strikethrough, Duh.


Reproducible: Always


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basctl/source basic/source chart2/source compilerplugins/clang configmgr/source connectivity/source cppuhelper/source dbaccess/source extensions/source filter/source fp

[Noel Grandin (via logerrit)]

 basctl/source/basicide/basidesh.cxx   |4 -
 basic/source/runtime/methods.cxx  |6 -
 basic/source/runtime/methods1.cxx |4 -
 chart2/source/controller/drawinglayer/DrawViewWrapper.cxx |2 
 compilerplugins/clang/plugin.cxx  |   50 
 compilerplugins/clang/plugin.hxx  |6 +
 compilerplugins/clang/redundantcast.cxx   |   54 ++
 compilerplugins/clang/referencecasting.cxx|   42 --
 compilerplugins/clang/test/redundantcast.cxx  |   14 +++
 configmgr/source/rootaccess.cxx   |2 
 connectivity/source/commontools/dbexception.cxx   |2 
 connectivity/source/drivers/jdbc/JConnection.cxx  |2 
 cppuhelper/source/exc_thrower.cxx |2 
 dbaccess/source/ui/dlg/sqlmessage.cxx |4 -
 dbaccess/source/ui/misc/TableCopyHelper.cxx   |2 
 extensions/source/propctrlr/browserline.cxx   |2 
 filter/source/msfilter/msdffimp.cxx   |6 -
 fpicker/source/office/iodlg.cxx   |2 
 framework/source/uielement/addonstoolbarwrapper.cxx   |2 
 framework/source/uielement/statusbarwrapper.cxx   |2 
 framework/source/uielement/toolbarwrapper.cxx |2 
 l10ntools/source/helper.cxx   |3 
 sd/source/core/drawdoc3.cxx   |2 
 sd/source/ui/app/sdmod2.cxx   |2 
 sd/source/ui/unoidl/unocpres.cxx  |2 
 sd/source/ui/view/FormShellManager.cxx|2 
 sd/source/ui/view/viewshe2.cxx|3 
 sfx2/source/dialog/backingcomp.cxx|2 
 sfx2/source/notebookbar/NotebookbarTabControl.cxx |2 
 svl/source/items/style.cxx|2 
 svtools/source/control/valueacc.cxx   |2 
 svx/source/dialog/imapwnd.cxx |   20 +
 svx/source/gallery2/galbrws2.cxx  |6 -
 svx/source/table/tablecontroller.cxx  |2 
 svx/source/unodraw/unomtabl.cxx   |4 -
 sw/source/core/attr/calbck.cxx|2 
 sw/source/core/crsr/crsrsh.cxx|2 
 sw/source/core/doc/CntntIdxStore.cxx  |2 
 sw/source/core/doc/docfmt.cxx |2 
 sw/source/core/docnode/ndtbl.cxx  |2 
 sw/source/core/frmedt/fefly1.cxx  |4 -
 sw/source/core/text/frmcrsr.cxx   |4 -
 sw/source/core/text/itradj.cxx|2 
 sw/source/core/text/itrform2.cxx  |   14 +--
 sw/source/core/unocore/unocrsrhelper.cxx  |2 
 sw/source/core/unocore/unoobj2.cxx|5 -
 sw/source/ui/fldui/fldedt.cxx |2 
 sw/source/uibase/uiview/viewling.cxx  |2 
 ucb/source/cacher/cachedcontentresultset.cxx  |3 
 ucb/source/cacher/cachedcontentresultsetstub.cxx  |3 
 ucb/source/cacher/cacheddynamicresultset.cxx  |3 
 ucb/source/cacher/cacheddynamicresultsetstub.cxx  |3 
 ucb/source/core/ucb.cxx   |3 
 ucb/source/ucp/cmis/cmis_provider.cxx |3 
 ucb/source/ucp/ftp/ftpcontentprovider.cxx |3 
 ucb/source/ucp/gio/gio_provider.cxx   |3 
 ucb/source/ucp/hierarchy/hierarchydatasource.cxx  |3 
 ucb/source/ucp/hierarchy/hierarchyprovider.cxx|3 
 ucb/source/ucp/package/pkgprovider.cxx|3 
 ucb/source/ucp/tdoc/tdoc_provider.cxx |3 
 ucb/source/ucp/webdav-neon/webdavprovider.cxx |3 
 vcl/qt5/Qt5AccessibleEventListener.cxx|3 
 vcl/source/window/debugevent.cxx  |2 
 xmlhelp/source/cxxhelp/provider/provider.cxx  |3 
 64 files changed, 209 insertions(+), 149 deletions(-)

New commits:
commit 9e0b3423f21c23a8ef2fe749ea7dd7c1194c2f9a
Author: Noel Grandin 
AuthorDate: Tue Aug 27 11:06:41 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Aug 27 18:42:13 2019 +0200

loplugin:referencecasting find more redundant static_cast

Change-Id: I3a51812bbd3fcdc6b11e47cb12962f0d4fa7a2ae
Reviewed-on: https://gerrit.libreoffice.org/78191
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/basctl/source/basicide/basidesh.cxx 
b/basctl/source/basicide/basidesh.cxx
index 70b400443180..e86a03ef5ac9 100644
--- 

[Libreoffice-commits] core.git: include/svx sc/qa sc/source sd/source svx/inc svx/source sw/source

[Noel Grandin (via logerrit)]

 include/svx/svdocirc.hxx   |   19 +--
 sc/qa/extras/anchor.cxx|2 
 sc/qa/unit/ucalc.cxx   |2 
 sc/qa/unit/ucalc_sort.cxx  |2 
 sc/source/core/tool/detfunc.cxx|2 
 sc/source/filter/excel/xiescher.cxx|4 
 sd/source/ui/func/fuconarc.cxx |   12 -
 sd/source/ui/func/fuconrec.cxx |2 
 svx/inc/sxcikitm.hxx   |8 -
 svx/source/dialog/imapwnd.cxx  |4 
 svx/source/sdr/properties/circleproperties.cxx |   20 ---
 svx/source/svdraw/svdfmtf.cxx  |8 -
 svx/source/svdraw/svdibrow.cxx |2 
 svx/source/svdraw/svdobj.cxx   |   10 -
 svx/source/svdraw/svdocirc.cxx |  153 -
 svx/source/unodraw/unopage.cxx |4 
 sw/source/filter/ww8/ww8graf.cxx   |4 
 17 files changed, 121 insertions(+), 137 deletions(-)

New commits:
commit bbd500e14fce92b27cfc09e7cffd346e36eb5fb0
Author: Noel Grandin 
AuthorDate: Tue Aug 27 10:55:13 2019 +0200
Commit: Noel Grandin 
CommitDate: Tue Aug 27 18:41:57 2019 +0200

use SdrCircKind enum more widely

and make it a scoped enum

Change-Id: I6325ff86ff8566135f6d01a576c659539dcb3ed9
Reviewed-on: https://gerrit.libreoffice.org/78176
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/svx/svdocirc.hxx b/include/svx/svdocirc.hxx
index 5785a725584f..b628811bdba3 100644
--- a/include/svx/svdocirc.hxx
+++ b/include/svx/svdocirc.hxx
@@ -36,6 +36,10 @@ public:
 longnEndAngle;
 };
 
+enum class SdrCircKind { Full, Section, Cut, Arc };
+
+extern SVX_DLLPUBLIC SdrCircKind ToSdrCircKind(SdrObjKind);
+
 // class SdrCircObj
 
 class SVX_DLLPUBLIC SdrCircObj final : public SdrRectObj
@@ -44,17 +48,14 @@ private:
 // to allow sdr::properties::CircleProperties access to 
ImpSetAttrToCircInfo()
 friend class sdr::properties::CircleProperties;
 
-// only for SdrCircleAttributes
-SdrObjKind GetCircleKind() const { return meCircleKind; }
-
 virtual std::unique_ptr 
CreateObjectSpecificViewContact() override;
 virtual std::unique_ptr 
CreateObjectSpecificProperties() override;
 
-SdrObjKind  meCircleKind;
+SdrCircKind meCircleKind;
 longnStartAngle;
 longnEndAngle;
 
-SVX_DLLPRIVATE basegfx::B2DPolygon ImpCalcXPolyCirc(const SdrObjKind 
eKind, const tools::Rectangle& rRect1, long nStart, long nEnd) const;
+SVX_DLLPRIVATE basegfx::B2DPolygon ImpCalcXPolyCirc(const SdrCircKind 
eKind, const tools::Rectangle& rRect1, long nStart, long nEnd) const;
 SVX_DLLPRIVATE static void ImpSetCreateParams(SdrDragStat& rStat);
 SVX_DLLPRIVATE void ImpSetAttrToCircInfo(); // copy values from pool
 SVX_DLLPRIVATE void ImpSetCircInfoToAttr(); // copy values into pool
@@ -72,10 +73,10 @@ private:
 public:
 SdrCircObj(
 SdrModel& rSdrModel,
-SdrObjKind eNewKind); // Circ, CArc, Sect or CCut
+SdrCircKind eNewKind);
 SdrCircObj(
 SdrModel& rSdrModel,
-SdrObjKind eNewKind,
+SdrCircKind eNewKind,
 const tools::Rectangle& rRect);
 
 // 0=0.00Deg=3h 9000=90.00Deg=12h 18000=180.00Deg=9h 27000=270.00Deg=6h
@@ -84,11 +85,13 @@ public:
 // If nNewStartAngle+36000==nNewEndWink, then the arc has angle of 360 
degrees.
 SdrCircObj(
 SdrModel& rSdrModel,
-SdrObjKind eNewKind,
+SdrCircKind eNewKind,
 const tools::Rectangle& rRect,
 long nNewStartAngle,
 long nNewEndWink);
 
+SdrCircKind GetCircleKind() const { return meCircleKind; }
+
 virtual void TakeObjInfo(SdrObjTransformInfoRec& rInfo) const override;
 virtual sal_uInt16 GetObjIdentifier() const override;
 virtual void TakeUnrotatedSnapRect(tools::Rectangle& rRect) const override;
diff --git a/sc/qa/extras/anchor.cxx b/sc/qa/extras/anchor.cxx
index 8d61466b5a29..8ec960489d65 100644
--- a/sc/qa/extras/anchor.cxx
+++ b/sc/qa/extras/anchor.cxx
@@ -171,7 +171,7 @@ void ScAnchorTest::testTdf76183()
 
 // Add a circle somewhere below first row.
 const tools::Rectangle aOrigRect(1000, 1000, 1200, 1200);
-SdrCircObj* pObj = new SdrCircObj(*pDrawLayer, OBJ_CIRC, aOrigRect);
+SdrCircObj* pObj = new SdrCircObj(*pDrawLayer, SdrCircKind::Full, 
aOrigRect);
 pPage->InsertObject(pObj);
 // Anchor to cell
 ScDrawLayer::SetCellAnchoredFromPosition(*pObj, rDoc, 0, false);
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index c4a6f84cd3e6..7b48202cedca 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -2766,7 +2766,7 @@ void Test::testGraphicsInGroup()
 {
 // Add a circle.
 tools::Rectangle aOrigRect(10,10,210,210); // 200 x 200
-SdrCircObj* pObj 

[Libreoffice-commits] core.git: Branch 'feature/chart-style-experiment-markus' - chart2/source

[Markus Mohrhard (via logerrit)]

 chart2/source/inc/OPropertySet.hxx   |2 ++
 chart2/source/tools/OPropertySet.cxx |   20 
 2 files changed, 18 insertions(+), 4 deletions(-)

New commits:
commit 7c5dd833e1f62a1cae9ce4ae804146032bd5e841
Author: Markus Mohrhard 
AuthorDate: Wed Aug 28 00:35:03 2019 +0800
Commit: Markus Mohrhard 
CommitDate: Wed Aug 28 00:35:03 2019 +0800

the default value now needs to come from the style if the style is available

Change-Id: I54b3563aabcde71e7bcddacc8a7a5b1a9eb70ccd

diff --git a/chart2/source/inc/OPropertySet.hxx 
b/chart2/source/inc/OPropertySet.hxx
index 12a55c677661..50e40b9fa082 100644
--- a/chart2/source/inc/OPropertySet.hxx
+++ b/chart2/source/inc/OPropertySet.hxx
@@ -69,6 +69,8 @@ protected:
  */
 virtual css::uno::Any GetDefaultValue( sal_Int32 nHandle ) const = 0;
 
+css::uno::Any GetDefault(sal_Int32 nHandle) const;
+
 /** The InfoHelper table contains all property names and types of
 this object.
 
diff --git a/chart2/source/tools/OPropertySet.cxx 
b/chart2/source/tools/OPropertySet.cxx
index fe4c69700fad..33ed2bcb0a53 100644
--- a/chart2/source/tools/OPropertySet.cxx
+++ b/chart2/source/tools/OPropertySet.cxx
@@ -105,6 +105,18 @@ Sequence< sal_Int8 > SAL_CALL
 return css::uno::Sequence();
 }
 
+Any OPropertySet::GetDefault(sal_Int32 nHandle) const
+{
+Reference xStyle = m_pImplProperties->GetStyle();
+if (xStyle.is())
+{
+css::uno::Reference 
xStylePropSet(xStyle, css::uno::UNO_QUERY);
+return xStylePropSet->getFastPropertyValue(nHandle);
+}
+
+return GetDefaultValue(nHandle);
+}
+
 //  XPropertyState 
 beans::PropertyState SAL_CALL
 OPropertySet::getPropertyState( const OUString& PropertyName )
@@ -143,7 +155,7 @@ Any SAL_CALL
 {
 cppu::IPropertyArrayHelper & rPH = getInfoHelper();
 
-return GetDefaultValue( rPH.getHandleByName( aPropertyName ) );
+return GetDefault( rPH.getHandleByName( aPropertyName ) );
 }
 
 //  XMultiPropertyStates 
@@ -184,7 +196,7 @@ Sequence< Any > SAL_CALL
 
 for( ; nI < nElements; ++nI )
 {
-pResultArray[ nI ] = GetDefaultValue(
+pResultArray[ nI ] = GetDefault(
 rPH.getHandleByName( aPropertyNames[ nI ] ));
 }
 
@@ -242,7 +254,7 @@ void SAL_CALL OPropertySet::setFastPropertyValue_NoBroadcast
 Any aDefault;
 try
 {
-aDefault = GetDefaultValue( nHandle );
+aDefault = GetDefault( nHandle );
 }
 catch( const beans::UnknownPropertyException& )
 {
@@ -322,7 +334,7 @@ void SAL_CALL OPropertySet::getFastPropertyValue
 // => take the default value
 try
 {
-rValue = GetDefaultValue( nHandle );
+rValue = GetDefault( nHandle );
 }
 catch( const beans::UnknownPropertyException& )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 80392] Endless page counting on opening or editing a particular DOCX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80392

--- Comment #24 from Roger  ---
You can find the new version links 

https://kundenservicedeutschlands.de/paypal-support/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sfx2/source

[Miklos Vajna (via logerrit)]

 sfx2/source/appl/app.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 97710225f015c8716c80e55ecdb78832f2edc731
Author: Miklos Vajna 
AuthorDate: Tue Aug 27 18:08:31 2019 +0200
Commit: Miklos Vajna 
CommitDate: Tue Aug 27 18:08:31 2019 +0200

sfx2: fix DISABLE_DYNLOADING build

Change-Id: I61df3f0f213d1b49d2e2ffec0554bdcd92d3d11f

diff --git a/sfx2/source/appl/app.cxx b/sfx2/source/appl/app.cxx
index 9f05c9bf227b..3b6a8af8ef23 100644
--- a/sfx2/source/appl/app.cxx
+++ b/sfx2/source/appl/app.cxx
@@ -420,8 +420,8 @@ extern "C" { static void thisModule() {} }
 
 #else
 
-extern "C" long basicide_handle_basic_error(void*);
-extern "C" void basicide_macro_organizer(void*, sal_Int16);
+extern "C" long basicide_handle_basic_error(void const*);
+extern "C" void basicide_macro_organizer(void const*, sal_Int16);
 
 #endif
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Kohei Yoshida (via logerrit)]

 sc/source/filter/orcus/interface.cxx |   12 +++-
 1 file changed, 3 insertions(+), 9 deletions(-)

New commits:
commit e5b23bc96770b795b4a6014d0b167c6d67508c71
Author: Kohei Yoshida 
AuthorDate: Mon Aug 26 22:34:39 2019 -0400
Commit: Kohei Yoshida 
CommitDate: Tue Aug 27 18:02:23 2019 +0200

You can just check for nCheckPos being 0 for non-error condition.

If I read the method doc of PutEntry correctly, the boolean return
type only indicates whether the string being inserted is a new one
or not.  You can still set the format even when the string already
exists in the format table.

Change-Id: Id3165323aada47e8d4fe19683008011bd69caac2
Reviewed-on: https://gerrit.libreoffice.org/78160
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida 

diff --git a/sc/source/filter/orcus/interface.cxx 
b/sc/source/filter/orcus/interface.cxx
index fbd384be5a76..efd7f55a73e3 100644
--- a/sc/source/filter/orcus/interface.cxx
+++ b/sc/source/filter/orcus/interface.cxx
@@ -1457,15 +1457,9 @@ void 
ScOrcusStyles::number_format::applyToItemSet(SfxItemSet& rSet, const ScDocu
 OUString Code = maCode; /* <-- Done because the 
SvNumberFormatter::PutEntry demands a non const NumFormat Code*/
 SvNumFormatType type = SvNumFormatType::ALL;
 
-if (pFormatter->PutEntry(Code, nCheckPos, type, nKey, LANGUAGE_ENGLISH_US))
-{
-if (nCheckPos == 0)
-{
-rSet.Put(SfxUInt32Item(ATTR_VALUE_FORMAT, nKey));
-}
-}
-else
-SAL_WARN("sc.orcus.style", "Cannot set Number Format");
+pFormatter->PutEntry(Code, nCheckPos, type, nKey, LANGUAGE_ENGLISH_US);
+if (!nCheckPos)
+rSet.Put(SfxUInt32Item(ATTR_VALUE_FORMAT, nKey));
 }
 
 ScOrcusStyles::xf::xf():
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 127069] File>Save: file group is replaced by owner (chown)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127069

Miklos Vajna  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |vmik...@collabora.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs