[Libreoffice-bugs] [Bug 127249] New: RFE: please add + and - when dragging data
https://bugs.documentfoundation.org/show_bug.cgi?id=127249 Bug ID: 127249 Summary: RFE: please add + and - when dragging data Product: LibreOffice Version: 6.3.0.4 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: toddandma...@zoho.com LibreOffice-6.3.0-Linux_x86-64_rpm.tar.gz Request for Enhancement: In calc, when dragging data with the mouse from one cell to another, please include "+" (ctrl key pressed) for copy and "-" (shift key pressed) for move on the dragged icon. Many thanks, -T -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/README |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 268010d0db7b880394006b063406c0783a10f18c Author: Samuel Mehrbrodt AuthorDate: Fri Aug 30 17:52:34 2019 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Sat Aug 31 06:04:32 2019 +0200 Remove .. from README Change-Id: I6f4a93fbcd48bac7246929ab8afcbc1c0f8e5d83 Reviewed-on: https://gerrit.libreoffice.org/78312 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/sw/qa/extras/README b/sw/qa/extras/README index 7ffc2152c6bb..bb6a0ae31a64 100644 --- a/sw/qa/extras/README +++ b/sw/qa/extras/README @@ -19,7 +19,7 @@ See below for more details on writing the UNO code see below. In most cases you want to assert the document model, but sometimes asserting the layout is easier. If you want to do so, the `parseDump()` method can be -used to.. parse the layout dump of the currently loaded document. If you want +used to parse the layout dump of the currently loaded document. If you want to have a look at the XML document that can be asserted, start soffice with the `SW_DEBUG=1` environment variable, load a document, press F12, and have a look at the `layout.xml` file in the current directory. Once you find the needed ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/firebird/DatabaseMetaData.cxx |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) New commits: commit 50785ac52579153ed78a4fba268a54fd4d0e710e Author: Julien Nabet AuthorDate: Fri Aug 30 16:59:58 2019 +0200 Commit: Julien Nabet CommitDate: Sat Aug 31 05:37:08 2019 +0200 tdf#118809: Fill DatabaseProductName and DatabaseProductVersion for Firebird Thank you to Drew Jensen for the suggestion here: https://bugs.documentfoundation.org/show_bug.cgi?id=118809#c3 Change-Id: Ie9b5a2c744b158100b2306b27b1d56a30afc5182 Reviewed-on: https://gerrit.libreoffice.org/78302 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/connectivity/source/drivers/firebird/DatabaseMetaData.cxx b/connectivity/source/drivers/firebird/DatabaseMetaData.cxx index f73cc5e62a8d..57af351924e3 100644 --- a/connectivity/source/drivers/firebird/DatabaseMetaData.cxx +++ b/connectivity/source/drivers/firebird/DatabaseMetaData.cxx @@ -598,12 +598,17 @@ OUString SAL_CALL ODatabaseMetaData::getDriverVersion() OUString SAL_CALL ODatabaseMetaData::getDatabaseProductVersion( ) { -return OUString(); +uno::Reference< XStatement > xSelect = m_pConnection->createStatement(); + +uno::Reference< XResultSet > xRs = xSelect->executeQuery("SELECT rdb$get_context('SYSTEM', 'ENGINE_VERSION') as version from rdb$database"); +xRs->next(); // first and only row +uno::Reference< XRow > xRow( xRs, UNO_QUERY_THROW ); +return xRow->getString(1); } OUString SAL_CALL ODatabaseMetaData::getDatabaseProductName( ) { -return OUString(); +return "Firebird (engine12)"; } OUString SAL_CALL ODatabaseMetaData::getProcedureTerm( ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127246] In LibO Calc: tabbing in a protected sheet jumps far beyond last unprotected cell
https://bugs.documentfoundation.org/show_bug.cgi?id=127246 raal changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 OS|Windows (All) |All Keywords||bibisected, bisected CC||noelgran...@gmail.com --- Comment #3 from raal --- This seems to have begun at the below commit. Adding Cc: to Noel Grandin ; Could you possibly take a look at this one? Thanks c5a668eb55cfe9b5ac32b4bf250325e12a67 is the first bad commit commit c5a668eb55cfe9b5ac32b4bf250325e12a67 Author: Jenkins Build User Date: Fri Apr 5 17:05:02 2019 +0200 source sha:7282014e362a1529a36c88eb308df8ed359c2cfa author Noel Grandin 2019-02-01 15:15:16 +0100 committer Mike Kaganski 2019-04-05 13:43:52 +0200 commit 7282014e362a1529a36c88eb308df8ed359c2cfa (patch) tree2776ad9601f494330076ac58c08554e719c6ab3a parent df30a4515b1303b0891baa53754fa9b3e47e0c02 (diff) tdf#50916 Makes numbers of columns dynamic. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127240] installer text not fully visible
https://bugs.documentfoundation.org/show_bug.cgi?id=127240 Adolfo Jayme changed: What|Removed |Added Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127176] 'Noto Nastaliq Urdu' font does not render correctly when justified.
https://bugs.documentfoundation.org/show_bug.cgi?id=127176 Nasir changed: What|Removed |Added Version|Master old -3.6|Inherited From OOo -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127041] Line break inputed by Shift+Enter doesn't properly export to TXT format
https://bugs.documentfoundation.org/show_bug.cgi?id=127041 --- Comment #5 from Ming Hua --- Created attachment 153773 --> https://bugs.documentfoundation.org/attachment.cgi?id=153773=edit Screenshot of the TXT file opened in gVim (In reply to V Stuart Foote from comment #4) > Hmm, not sure how OP has configured the MS notepad.exe, but its default > settings with or without 'word wrap' enabled does distinguish and show the > and My MS Notepad is definitely in the default setting. AFAIK there is no setting in notepad for different kind of line breaks, and the "word wrap" setting will never make two or more lines displayed in one line. The MS notepad behavior of not recognize LF-only line break has a long history and is well documented. > As does gvim.exe While gVim indeed displays the file with line breaks, it does highlight the fact that there are both CR+LF and LF-only line breaks in the file, by showing the character as "^M", see attached screenshot. > While > doing anythiing different with the distinction would in fact cause problems. What kind of problems do you forsee? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - Repository.mk scp2/AutoInstall.mk scp2/InstallModule_spsupp.mk scp2/InstallScript_setup_osl.mk scp2/Module_scp2.mk scp2/source
Repository.mk| 14 +- scp2/AutoInstall.mk |1 + scp2/InstallModule_spsupp.mk | 20 scp2/InstallScript_setup_osl.mk |1 + scp2/Module_scp2.mk |1 + scp2/source/spsupp/module_spsupp.scp | 26 ++ 6 files changed, 54 insertions(+), 9 deletions(-) New commits: commit 48e7a4eda8fd136f7d9b5a86e0d928e18ad0ad94 Author: Mike Kaganski AuthorDate: Thu Aug 29 16:56:23 2019 +0300 Commit: Mike Kaganski CommitDate: Sat Aug 31 03:32:41 2019 +0200 Move spsupp components to a separate installer feature Change-Id: Ic95b9f887da83d0931ed54b76d23465660786a79 Reviewed-on: https://gerrit.libreoffice.org/78273 Tested-by: Jenkins Reviewed-by: Mike Kaganski (cherry picked from commit 99dd418c94e2b85fca1a13a0c15aa117582da574) Reviewed-on: https://gerrit.libreoffice.org/78295 Tested-by: Mike Kaganski diff --git a/Repository.mk b/Repository.mk index 949605a8a29e..0de098bd6b1f 100644 --- a/Repository.mk +++ b/Repository.mk @@ -206,7 +206,6 @@ $(eval $(call gb_Helper_register_executables_for_install,OOO,ooo, \ ) \ $(if $(filter WNT,$(OS)), \ senddoc \ - spsupp_helper \ ) \ )) @@ -674,17 +673,14 @@ $(eval $(call gb_Helper_register_libraries_for_install,PLAINLIBS_OOO,activexwin6 )) endif -ifneq ($(CXX_X64_BINARY),) -$(eval $(call gb_Helper_register_libraries_for_install,PLAINLIBS_OOO,ooo, \ - spsupp_x64 \ +$(eval $(call gb_Helper_register_executables_for_install,OOO,spsuppfiles, \ + spsupp_helper \ )) -endif -ifneq ($(CXX_X86_BINARY),) -$(eval $(call gb_Helper_register_libraries_for_install,PLAINLIBS_OOO,ooo, \ - spsupp_x86 \ +$(eval $(call gb_Helper_register_libraries_for_install,PLAINLIBS_OOO,spsuppfiles, \ + $(if $(CXX_X64_BINARY),spsupp_x64) \ + $(if $(CXX_X86_BINARY),spsupp_x86) \ )) -endif $(eval $(call gb_Helper_register_libraries_for_install,PLAINLIBS_OOO,ooobinarytable, \ $(if $(WINDOWS_SDK_HOME),\ diff --git a/scp2/AutoInstall.mk b/scp2/AutoInstall.mk index 7c9d6c4538bd..9b18c1ecce08 100644 --- a/scp2/AutoInstall.mk +++ b/scp2/AutoInstall.mk @@ -45,6 +45,7 @@ $(eval $(call gb_AutoInstall_add_module,pdfimport,LIBO_LIB_FILE,LIBO_EXECUTABLE, $(eval $(call gb_AutoInstall_add_module,quickstart,,LIBO_EXECUTABLE)) $(eval $(call gb_AutoInstall_add_module,reportbuilder,LIBO_LIB_FILE,,LIBO_JAR_FILE,PACKAGE_FILELIST)) $(eval $(call gb_AutoInstall_add_module,sdk,,SDK_EXECUTABLE,,SDK_PACKAGE_FILELIST)) +$(eval $(call gb_AutoInstall_add_module,spsuppfiles,LIBO_LIB_FILE,LIBO_EXECUTABLE)) $(eval $(call gb_AutoInstall_add_module,ure,URE_PRIVATE_LIB,URE_EXECUTABLE,URE_JAR_FILE,PACKAGE_FILELIST)) $(eval $(call gb_AutoInstall_add_module,winexplorerextbinarytable,LIBO_LIB_FILE_BINARYTABLE)) $(eval $(call gb_AutoInstall_add_module,winexplorerext,SHLXTHDL_LIB_FILE)) diff --git a/scp2/InstallModule_spsupp.mk b/scp2/InstallModule_spsupp.mk new file mode 100644 index ..7d01a7b020ed --- /dev/null +++ b/scp2/InstallModule_spsupp.mk @@ -0,0 +1,20 @@ +# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- +# +# This file is part of the LibreOffice project. +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# + +$(eval $(call gb_InstallModule_InstallModule,scp2/spsupp)) + +$(eval $(call gb_InstallModule_use_auto_install_libs,scp2/spsupp,\ +spsuppfiles \ +)) + +$(eval $(call gb_InstallModule_add_scpfiles,scp2/spsupp,\ +scp2/source/spsupp/module_spsupp \ +)) + +# vim: set shiftwidth=4 tabstop=4 noexpandtab: diff --git a/scp2/InstallScript_setup_osl.mk b/scp2/InstallScript_setup_osl.mk index a37a4552c139..f6522cbcdc97 100644 --- a/scp2/InstallScript_setup_osl.mk +++ b/scp2/InstallScript_setup_osl.mk @@ -24,6 +24,7 @@ $(eval $(call gb_InstallScript_use_modules,setup_osl,\ $(if $(filter WNT,$(OS)),\ scp2/activex \ scp2/quickstart \ + scp2/spsupp \ scp2/windows \ $(if $(filter MSC,$(COM)),\ scp2/winexplorerext \ diff --git a/scp2/Module_scp2.mk b/scp2/Module_scp2.mk index c414e09045cb..c65e462a7bb2 100644 --- a/scp2/Module_scp2.mk +++ b/scp2/Module_scp2.mk @@ -22,6 +22,7 @@ $(eval $(call gb_Module_add_targets,scp2,\ InstallModule_onlineupdate \ InstallModule_ooo \ InstallModule_python \ + InstallModule_spsupp \ InstallModule_ure \ InstallModule_writer \ InstallModule_xsltfilter \ diff --git a/scp2/source/spsupp/module_spsupp.scp b/scp2/source/spsupp/module_spsupp.scp new file mode 100644 index ..39c547a5fa5c --- /dev/null +++ b/scp2/source/spsupp/module_spsupp.scp @@ -0,0 +1,26 @@ +/* + * This
[Libreoffice-commits] core.git: desktop/source
desktop/source/app/sofficemain.cxx |4 1 file changed, 4 insertions(+) New commits: commit 4e527f55d74e3220873075a8ec2799e2206fdb2d Author: Mike Kaganski AuthorDate: Sat Aug 31 02:23:38 2019 +0200 Commit: Mike Kaganski CommitDate: Sat Aug 31 03:17:40 2019 +0200 Fix MSVC2019 build after 629dfff3c7289f185268c7088e67931f6bbd9ce0 ... failing like this: [CXX] desktop/source/app/sofficemain.cxx C:\PROGRA~2\WI3CF2~1\10\Include\10.0.18362.0\um\winnt.h(656): error C4005: 'DECLARE_HANDLE': macro redefinition C:\lo\src\core\include\sal/main.h(91): note: see previous definition of 'DECLARE_HANDLE' C:\PROGRA~2\WI3CF2~1\10\Include\10.0.18362.0\shared\minwindef.h(250): error C2371: 'HINSTANCE': redefinition; different basic types C:\lo\src\core\include\sal/main.h(93): note: see declaration of 'HINSTANCE' make[1]: *** [C:/lo/src/core/solenv/gbuild/LinkTarget.mk:293: C:/lo/src/core/workdir/CxxObject/desktop/source/app/sofficemain.o] Error 2 Apparently MSVC2017 isn't affected, since the problematic commit passed CI happliy (didn't test myself if MSVC version is actually the problem, or maybe specific Windows SDK version). Change-Id: Ibcaa3a8d09bae54e436366623fe103e8c5f58f40 Reviewed-on: https://gerrit.libreoffice.org/78334 Reviewed-by: Mike Kaganski Tested-by: Mike Kaganski diff --git a/desktop/source/app/sofficemain.cxx b/desktop/source/app/sofficemain.cxx index 2a692fdae8d4..917361ebf0d3 100644 --- a/desktop/source/app/sofficemain.cxx +++ b/desktop/source/app/sofficemain.cxx @@ -28,6 +28,9 @@ #include "cmdlineargs.hxx" #include "cmdlinehelp.hxx" +// needed before sal/main.h to avoid redefinition of macros +#include + #include #include #include @@ -62,6 +65,7 @@ #endif +#include #ifdef ANDROID # include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127161] Graphite font rendering is not happening in LibreOffice-6 versions
https://bugs.documentfoundation.org/show_bug.cgi?id=127161 Jayakumar changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #3 from Jayakumar --- (In reply to Dieter Praas from comment #1) > Jayakumar, thank you for reporting the bug. Please add an attachment, that > shows problems with rendering. > > I have set the bug's status to 'NEEDINFO'. Please change it back to > 'UNCONFIRMED' once the requested document is provided. > (Please note that the attachment will be public, remove any sensitive > information before attaching it) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127161] Graphite font rendering is not happening in LibreOffice-6 versions
https://bugs.documentfoundation.org/show_bug.cgi?id=127161 --- Comment #2 from Jayakumar --- Created attachment 153772 --> https://bugs.documentfoundation.org/attachment.cgi?id=153772=edit It has graphite font characters in combination to get it clear rendering -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/Executable_sbase.mk desktop/Executable_scalc.mk desktop/Executable_sdraw.mk desktop/Executable_simpress.mk desktop/Executable_smath.mk desktop/Executable_soffic
desktop/Executable_sbase.mk |2 + desktop/Executable_scalc.mk |2 + desktop/Executable_sdraw.mk |2 + desktop/Executable_simpress.mk |2 + desktop/Executable_smath.mk |2 + desktop/Executable_soffice_bin.mk|2 + desktop/Executable_soffice_com.mk|2 + desktop/Executable_soffice_exe.mk|2 + desktop/Executable_sweb.mk |2 + desktop/Executable_swriter.mk|2 + desktop/WinResTarget_sbase.mk|4 -- desktop/WinResTarget_scalc.mk|4 -- desktop/WinResTarget_sdraw.mk|4 -- desktop/WinResTarget_simpress.mk |4 -- desktop/WinResTarget_smath.mk|4 -- desktop/WinResTarget_soffice.mk |4 -- desktop/WinResTarget_sofficebin.mk |4 -- desktop/WinResTarget_sweb.mk |4 -- desktop/WinResTarget_swriter.mk |4 -- desktop/util/officeloader.rc | 41 --- desktop/win32/source/applauncher/launcher.rc | 41 --- solenv/gbuild/platform/com_MSC_class.mk |2 - 22 files changed, 21 insertions(+), 119 deletions(-) New commits: commit cb204a382da220f8b282d6da507716c918716272 Author: Mike Kaganski AuthorDate: Sat Aug 31 01:17:31 2019 +0300 Commit: Mike Kaganski CommitDate: Sat Aug 31 02:48:18 2019 +0200 Unify executables to take version resource from default.rc Pass file description in optional second argument to gb_Executable_add_default_nativeres. Remove duplicating version resources from officeloader.rc and launcher.rc. Change-Id: I55c4fc85c470c3dd6f03d909a39459839e70b9cd Reviewed-on: https://gerrit.libreoffice.org/78333 Reviewed-by: Mike Kaganski Tested-by: Mike Kaganski diff --git a/desktop/Executable_sbase.mk b/desktop/Executable_sbase.mk index d3a4fafea810..9c36165b8b3d 100644 --- a/desktop/Executable_sbase.mk +++ b/desktop/Executable_sbase.mk @@ -25,4 +25,6 @@ $(eval $(call gb_Executable_add_exception_objects,sbase,\ $(eval $(call gb_Executable_add_nativeres,sbase,sbase/launcher)) +$(eval $(call gb_Executable_add_default_nativeres,sbase,$(PRODUCTNAME) Base)) + # vim: set ts=4 sw=4 et: diff --git a/desktop/Executable_scalc.mk b/desktop/Executable_scalc.mk index 1a21840a3306..b6845690dfdb 100644 --- a/desktop/Executable_scalc.mk +++ b/desktop/Executable_scalc.mk @@ -25,4 +25,6 @@ $(eval $(call gb_Executable_add_exception_objects,scalc,\ $(eval $(call gb_Executable_add_nativeres,scalc,scalc/launcher)) +$(eval $(call gb_Executable_add_default_nativeres,scalc,$(PRODUCTNAME) Calc)) + # vim: set ts=4 sw=4 et: diff --git a/desktop/Executable_sdraw.mk b/desktop/Executable_sdraw.mk index c6fd96373de1..164b65876568 100644 --- a/desktop/Executable_sdraw.mk +++ b/desktop/Executable_sdraw.mk @@ -25,4 +25,6 @@ $(eval $(call gb_Executable_add_exception_objects,sdraw,\ $(eval $(call gb_Executable_add_nativeres,sdraw,sdraw/launcher)) +$(eval $(call gb_Executable_add_default_nativeres,sdraw,$(PRODUCTNAME) Draw)) + # vim: set ts=4 sw=4 et: diff --git a/desktop/Executable_simpress.mk b/desktop/Executable_simpress.mk index d06205486020..8d3bdd0543ee 100644 --- a/desktop/Executable_simpress.mk +++ b/desktop/Executable_simpress.mk @@ -25,4 +25,6 @@ $(eval $(call gb_Executable_add_exception_objects,simpress,\ $(eval $(call gb_Executable_add_nativeres,simpress,simpress/launcher)) +$(eval $(call gb_Executable_add_default_nativeres,simpress,$(PRODUCTNAME) Impress)) + # vim: set ts=4 sw=4 et: diff --git a/desktop/Executable_smath.mk b/desktop/Executable_smath.mk index 94aa8b915f30..797354d47461 100644 --- a/desktop/Executable_smath.mk +++ b/desktop/Executable_smath.mk @@ -25,4 +25,6 @@ $(eval $(call gb_Executable_add_exception_objects,smath,\ $(eval $(call gb_Executable_add_nativeres,smath,smath/launcher)) +$(eval $(call gb_Executable_add_default_nativeres,smath,$(PRODUCTNAME) Math)) + # vim: set ts=4 sw=4 et: diff --git a/desktop/Executable_soffice_bin.mk b/desktop/Executable_soffice_bin.mk index d8084cddeb1f..cabd31af29f2 100644 --- a/desktop/Executable_soffice_bin.mk +++ b/desktop/Executable_soffice_bin.mk @@ -37,6 +37,8 @@ $(eval $(call gb_Executable_set_targettype_gui,soffice_bin,NO)) $(eval $(call gb_Executable_add_nativeres,soffice_bin,sofficebin/officeloader)) +$(eval $(call gb_Executable_add_default_nativeres,soffice_bin,$(PRODUCTNAME))) + ifeq ($(COM),MSC) $(eval $(call gb_Executable_add_ldflags,soffice_bin,\ diff --git a/desktop/Executable_soffice_com.mk b/desktop/Executable_soffice_com.mk index 8b4da6b9d94b..bc1460634421 100644 --- a/desktop/Executable_soffice_com.mk +++ b/desktop/Executable_soffice_com.mk @@ -26,4 +26,6 @@ $(eval $(call gb_Executable_add_exception_objects,soffice_com,\ $(eval $(call
[Libreoffice-bugs] [Bug 127248] Not displaying zero after calculation
https://bugs.documentfoundation.org/show_bug.cgi?id=127248 --- Comment #3 from teddy...@yahoo.com --- Thank You. I used the General Number format to display the zero. I apologize for any inconvenience. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127248] Not displaying zero after calculation
https://bugs.documentfoundation.org/show_bug.cgi?id=127248 Mike Kaganski changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG --- Comment #2 from Mike Kaganski --- Your cells G2 and D3 are formatted using "#" format code, i.e. "print this position if it's non-zero". Naturally, this code gives empty result when its data *is* exactly zero. See more at help page [1]. Closing NOTABUG. [1] https://help.libreoffice.org/latest/en-US/text/shared/01/05020301.html -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source sw/source
sd/source/ui/func/fuinsert.cxx |6 +- sw/source/uibase/table/tablemgr.cxx |7 +-- 2 files changed, 10 insertions(+), 3 deletions(-) New commits: commit 758a4998c56c73d2420c1ee2e3f41bedd153559d Author: Jan Holesovsky AuthorDate: Wed May 29 15:42:20 2019 +0200 Commit: Miklos Vajna CommitDate: Sat Aug 31 01:00:32 2019 +0200 sw sd lok: Don't enter the OLE editing mode right after inserting a chart. Turns out that it is confusing for the users that they can edit the properties of the chart rather than its position just after inserting it in the browser. Let's change it accordingly. When the user wants to edit the chart itself, they have to double-click. Calc is not handled in this patch. Change-Id: If5661b843a06ebaeb8d4cd1b2c469aeedda4257e Reviewed-on: https://gerrit.libreoffice.org/78318 Reviewed-by: Miklos Vajna Tested-by: Jenkins diff --git a/sd/source/ui/func/fuinsert.cxx b/sd/source/ui/func/fuinsert.cxx index 0ed716ec7246..64b4b1507a9b 100644 --- a/sd/source/ui/func/fuinsert.cxx +++ b/sd/source/ui/func/fuinsert.cxx @@ -76,6 +76,8 @@ #include #include +#include + using namespace com::sun::star; namespace sd { @@ -390,8 +392,10 @@ void FuInsertOLE::DoExecute( SfxRequest& rReq ) else bRet = mpView->InsertObjectAtView(pOleObj, *pPV, SdrInsertFlags::SETDEFLAYER); -if( bRet ) +if (bRet && !comphelper::LibreOfficeKit::isActive()) { +// Let the chart be activated after the inserting (unless +// via LibreOfficeKit) if (nSlotId == SID_INSERT_DIAGRAM) { pOleObj->SetProgName( "StarChart"); diff --git a/sw/source/uibase/table/tablemgr.cxx b/sw/source/uibase/table/tablemgr.cxx index 882f4f99329d..313cec6df5de 100644 --- a/sw/source/uibase/table/tablemgr.cxx +++ b/sw/source/uibase/table/tablemgr.cxx @@ -48,6 +48,8 @@ #include #include +#include + using namespace ::com::sun::star; // Adjust line height (dialogue) @@ -248,9 +250,10 @@ uno::Reference< frame::XModel > SwTableFUNC::InsertChart( } pSh->EndAllAction(); -if ( xObj.is() ) +if (xObj.is() && !comphelper::LibreOfficeKit::isActive()) { -// Let the chart be activated after the inserting +// Let the chart be activated after the inserting (unless +// via LibreOfficeKit) SfxInPlaceClient* pClient = pSh->GetView().FindIPClient( xObj, >GetView().GetEditWin() ); if ( !pClient ) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127248] Not displaying zero after calculation
https://bugs.documentfoundation.org/show_bug.cgi?id=127248 --- Comment #1 from teddy...@yahoo.com --- Created attachment 153771 --> https://bugs.documentfoundation.org/attachment.cgi?id=153771=edit A 3 line spreadsheet showing the behavior -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127248] New: Not displaying zero after calculation
https://bugs.documentfoundation.org/show_bug.cgi?id=127248 Bug ID: 127248 Summary: Not displaying zero after calculation Product: LibreOffice Version: 6.3.0.4 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: teddy...@yahoo.com Description: When I subtract 2 values, the value should be displayed as zero. Instead, a blank space appears in G2 and D3. Steps to Reproduce: 1.Enter =D2-E2 in cell G2 2.Enter =G2 in cell D3 3. Actual Results: Blank space appears instead of 0 Expected Results: 0 should appear in cells G2 and D3 Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107882] Basic editor cracking Cyrillic symbols in BASIC script when edited (xls)
https://bugs.documentfoundation.org/show_bug.cgi?id=107882 --- Comment #14 from himajin100...@gmail.com --- possible source code pointer: https://opengrok.libreoffice.org/xref/core/basctl/source/basicide/baside2b.cxx?r=8bf1542f#118 --- https://opengrok.libreoffice.org/xref/core/basctl/source/basicide/baside2.cxx?r=6e9d8739#784 or https://opengrok.libreoffice.org/xref/core/basctl/source/basicide/baside2b.cxx?r=8bf1542f#998 I don't know the difference --- https://opengrok.libreoffice.org/xref/core/basic/source/classes/sbxmod.cxx?r=889dc7bf#1587 https://opengrok.libreoffice.org/xref/core/basic/source/classes/image.cxx?r=49c88d8b#142 or https://opengrok.libreoffice.org/xref/core/basic/source/classes/image.cxx?r=49c88d8b#145 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127118] FILEOPEN DOCX Rotation formatting of change tracked text in cell lost
https://bugs.documentfoundation.org/show_bug.cgi?id=127118 --- Comment #5 from Miklos Vajna --- (In reply to Gabor Kelemen from comment #1) > Also the paragraphs in the cells get a larger spacing than in Word but that > will be another bug :). A few observations: 1) As you write, the row height in the DOCX import result is wrong; DOC import result has the correct row height, which means that the btlr cell won't be split, so you don't see the problem. 2) It seems the bug is specific to split cells, not tracked changes. 3) It seems this is problematic with rotation in either direction, tbrl (rotate in the other direction) has the very same problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cpputools/Executable_uno.mk dbaccess/Executable_odbcconfig.mk desktop/Executable_minidump_upload.mk desktop/Executable_quickstart.mk desktop/Executable_unoinfo.mk deskt
cpputools/Executable_uno.mk |2 ++ dbaccess/Executable_odbcconfig.mk |2 ++ desktop/Executable_minidump_upload.mk |2 ++ desktop/Executable_quickstart.mk |2 ++ desktop/Executable_unoinfo.mk |2 ++ desktop/Executable_unopkg.mk |2 ++ desktop/Executable_unopkg_bin.mk |2 ++ desktop/Executable_unopkg_com.mk |2 ++ extensions/Executable_twain32shim.mk |2 ++ opencl/Executable_opencltest.mk |2 ++ pyuno/Executable_python.mk|2 ++ registry/Executable_regmerge.mk |2 ++ registry/Executable_regview.mk|2 ++ sdext/Executable_xpdfimport.mk|2 ++ shell/Executable_senddoc.mk |2 ++ svx/Executable_gengal.mk |2 ++ vcl/Executable_ui-previewer.mk|2 ++ 17 files changed, 34 insertions(+) New commits: commit c598ea1427250b50c1f3a4b0eacb34a11b2751fb Author: Mike Kaganski AuthorDate: Fri Aug 30 23:01:07 2019 +0300 Commit: Mike Kaganski CommitDate: Sat Aug 31 00:22:28 2019 +0200 Add version resource to executables where it was missing Change-Id: Iee965c3f720827b20347f6228e891562c8295d22 Reviewed-on: https://gerrit.libreoffice.org/78327 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/cpputools/Executable_uno.mk b/cpputools/Executable_uno.mk index 4a766c57d5cf..ba3b22fb6337 100644 --- a/cpputools/Executable_uno.mk +++ b/cpputools/Executable_uno.mk @@ -28,4 +28,6 @@ $(eval $(call gb_Executable_add_exception_objects,uno,\ cpputools/source/unoexe/unoexe \ )) +$(eval $(call gb_Executable_add_default_nativeres,uno)) + # vim:set noet sw=4 ts=4: diff --git a/dbaccess/Executable_odbcconfig.mk b/dbaccess/Executable_odbcconfig.mk index de40bdd2a6da..862c77b3b5af 100644 --- a/dbaccess/Executable_odbcconfig.mk +++ b/dbaccess/Executable_odbcconfig.mk @@ -26,4 +26,6 @@ $(eval $(call gb_Executable_add_exception_objects,odbcconfig,\ dbaccess/win32/source/odbcconfig/odbcconfig \ )) +$(eval $(call gb_Executable_add_default_nativeres,odbcconfig)) + # vim: set noet sw=4 ts=4: diff --git a/desktop/Executable_minidump_upload.mk b/desktop/Executable_minidump_upload.mk index ccdcc97e743d..600c171e2646 100644 --- a/desktop/Executable_minidump_upload.mk +++ b/desktop/Executable_minidump_upload.mk @@ -20,4 +20,6 @@ $(eval $(call gb_Executable_add_exception_objects,minidump_upload,\ desktop/source/minidump/minidump_upload \ )) +$(eval $(call gb_Executable_add_default_nativeres,minidump_upload)) + # vim: set noet sw=4 ts=4: diff --git a/desktop/Executable_quickstart.mk b/desktop/Executable_quickstart.mk index 02b31fef736c..f0df0bbe7abb 100644 --- a/desktop/Executable_quickstart.mk +++ b/desktop/Executable_quickstart.mk @@ -39,4 +39,6 @@ $(eval $(call gb_Executable_add_exception_objects,quickstart,\ $(eval $(call gb_Executable_add_nativeres,quickstart,quickstart/QuickStart)) +$(eval $(call gb_Executable_add_default_nativeres,quickstart)) + # vim: set ts=4 sw=4 et: diff --git a/desktop/Executable_unoinfo.mk b/desktop/Executable_unoinfo.mk index 032b1a74cf21..77d1778e0242 100644 --- a/desktop/Executable_unoinfo.mk +++ b/desktop/Executable_unoinfo.mk @@ -17,4 +17,6 @@ $(eval $(call gb_Executable_add_exception_objects,unoinfo,\ desktop/win32/source/unoinfo \ )) +$(eval $(call gb_Executable_add_default_nativeres,unoinfo)) + # vim: set ts=4 sw=4 et: diff --git a/desktop/Executable_unopkg.mk b/desktop/Executable_unopkg.mk index c5b341521b9f..f1b6d6be6db9 100644 --- a/desktop/Executable_unopkg.mk +++ b/desktop/Executable_unopkg.mk @@ -24,4 +24,6 @@ $(eval $(call gb_Executable_add_exception_objects,unopkg,\ desktop/win32/source/guiloader/genericloader \ )) +$(eval $(call gb_Executable_add_default_nativeres,unopkg)) + # vim: set ts=4 sw=4 et: diff --git a/desktop/Executable_unopkg_bin.mk b/desktop/Executable_unopkg_bin.mk index 27ebc5db1eca..d2e1175be236 100644 --- a/desktop/Executable_unopkg_bin.mk +++ b/desktop/Executable_unopkg_bin.mk @@ -27,4 +27,6 @@ $(eval $(call gb_Executable_add_cobjects,unopkg_bin,\ desktop/source/pkgchk/unopkg/unopkg_main \ )) +$(eval $(call gb_Executable_add_default_nativeres,unopkg_bin)) + # vim: set ts=4 sw=4 et: diff --git a/desktop/Executable_unopkg_com.mk b/desktop/Executable_unopkg_com.mk index 4db7d96c4f94..616a757a7fa8 100644 --- a/desktop/Executable_unopkg_com.mk +++ b/desktop/Executable_unopkg_com.mk @@ -15,4 +15,6 @@ $(eval $(call gb_Executable_add_exception_objects,unopkg_com,\ desktop/win32/source/guistdio/unopkgio \ )) +$(eval $(call gb_Executable_add_default_nativeres,unopkg_com)) + # vim: set ts=4 sw=4 et: diff --git a/extensions/Executable_twain32shim.mk b/extensions/Executable_twain32shim.mk index 29a6e6427198..6f53ca3924ab 100644 --- a/extensions/Executable_twain32shim.mk +++ b/extensions/Executable_twain32shim.mk @@ -30,4 +30,6 @@ $(eval $(call gb_Executable_use_system_win32_libs,twain32shim,\ shell32 \ ))
[Libreoffice-bugs] [Bug 125902] [META] Impress Bullets New Dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=125902 Bug 125902 depends on bug 126656, which changed state. Bug 126656 Summary: Modifying one outline level with slide scope selected changes layout for all the outline levels https://bugs.documentfoundation.org/show_bug.cgi?id=126656 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/ui/func/fuolbull.cxx | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) New commits: commit 438430904064e667b688275525b317fd7989af2e Author: Gülşah Köse AuthorDate: Sat Aug 31 00:24:40 2019 +0300 Commit: Gülşah Köse CommitDate: Sat Aug 31 00:21:52 2019 +0200 tdf#126656 Remove unnecessary items from itemset. Change-Id: I62fc660ea061fe9665e0166a08871ba0a592fc41 Reviewed-on: https://gerrit.libreoffice.org/78332 Tested-by: Jenkins Reviewed-by: Gülşah Köse diff --git a/sd/source/ui/func/fuolbull.cxx b/sd/source/ui/func/fuolbull.cxx index 7c9b8657f0f2..cdd8fd33ece9 100644 --- a/sd/source/ui/func/fuolbull.cxx +++ b/sd/source/ui/func/fuolbull.cxx @@ -81,8 +81,14 @@ void FuBulletAndPosition::DoExecute( SfxRequest& rReq ) SfxItemSet aEditAttr( mpDoc->GetPool() ); mpView->GetAttributes( aEditAttr ); -SfxItemSet aNewAttr( mpViewShell->GetPool(), - svl::Items{} ); +static const sal_uInt16 aAttrMap[] = +{ +EE_PARA_NUMBULLET, +EE_PARA_BULLET, +0 +}; + +SfxItemSet aNewAttr( mpViewShell->GetPool(), aAttrMap ); aNewAttr.Put( aEditAttr, false ); auto pView = mpView; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127241] date format not saved properly
https://bugs.documentfoundation.org/show_bug.cgi?id=127241 --- Comment #6 from Mike Kaganski --- Please note that comment 1 mentioned version 6.3.1.1 - newer than that mentioned in the bug data - 6.3.0.2 (by the way, you forgot to mention that in the description, which is unfortunate, because metadata may change later, and the original version would be lost). That means that *possibly* it's fixed in a later version - so that's a hint that it would be good to test that version and check if the bug is reproducible there for you. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127241] date format not saved properly
https://bugs.documentfoundation.org/show_bug.cgi?id=127241 --- Comment #5 from tor...@yahoo.com --- Created attachment 153770 --> https://bugs.documentfoundation.org/attachment.cgi?id=153770=edit screenshot showing old format mm/dd/ after re-loading -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127241] date format not saved properly
https://bugs.documentfoundation.org/show_bug.cgi?id=127241 --- Comment #4 from tor...@yahoo.com --- Created attachment 153769 --> https://bugs.documentfoundation.org/attachment.cgi?id=153769=edit screenshot showing new format -mm-dd, before saving -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127241] date format not saved properly
https://bugs.documentfoundation.org/show_bug.cgi?id=127241 --- Comment #3 from tor...@yahoo.com --- Created attachment 153768 --> https://bugs.documentfoundation.org/attachment.cgi?id=153768=edit screenshot showing mm/dd/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127241] date format not saved properly
https://bugs.documentfoundation.org/show_bug.cgi?id=127241 --- Comment #2 from tor...@yahoo.com --- Created attachment 153767 --> https://bugs.documentfoundation.org/attachment.cgi?id=153767=edit file with date -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127246] In LibO Calc: tabbing in a protected sheet jumps far beyond last unprotected cell
https://bugs.documentfoundation.org/show_bug.cgi?id=127246 Euler German changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/cib_contract136' - 108 commits - bin/distro-install-file-lists canvas/source config_host.mk.in configure.ac desktop/unx download.lst extensions/Library_
Rebased ref, commits from common ancestor: commit 0bf354356e942c2e9b337536ecde9dd0643ae155 Author: Thorsten Behrens AuthorDate: Fri Aug 30 10:26:50 2019 +0200 Commit: Thorsten Behrens CommitDate: Fri Aug 30 23:32:40 2019 +0200 Release 5.2.7.9 Change-Id: I70e035962c22bce0b1efc49bc23d8718ab73701a diff --git a/configure.ac b/configure.ac index 7312237d67d1..8c4f17d02fc4 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[5.2.7.8],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[5.2.7.9],[],[],[http://documentfoundation.org/]) AC_PREREQ([2.59]) commit 7d430d5c576add1e4d3524bcdc6036b9a093ed04 Author: Caolán McNamara AuthorDate: Mon Aug 12 20:32:54 2019 +0100 Commit: Thorsten Behrens CommitDate: Fri Aug 30 23:32:39 2019 +0200 construct final url from parsed output Change-Id: Ifd733625a439685ad307603eb2b00bf463eb9ca9 Reviewed-on: https://gerrit.libreoffice.org/77373 Tested-by: Jenkins Reviewed-by: Stephan Bergmann (cherry picked from commit 87959e5deea6d33cd35dbb3b8423056f9566710e) Reviewed-on: https://gerrit.libreoffice.org/77377 (cherry picked from commit c03acb9b8a97254cfcf7c45ef920b93b7f1dd344) diff --git a/scripting/source/pyprov/pythonscript.py b/scripting/source/pyprov/pythonscript.py index adc15cc150eb..38bac5da1671 100644 --- a/scripting/source/pyprov/pythonscript.py +++ b/scripting/source/pyprov/pythonscript.py @@ -223,7 +223,13 @@ class MyUriHelper: sStorageUri = sStorageUri.replace( "|", "/" ) # path to the .py file, relative to the base -sFileUri = sStorageUri[0:sStorageUri.find("$")] +funcNameStart = sStorageUri.find("$") +if funcNameStart != -1: +sFileUri = sStorageUri[0:funcNameStart] +sFuncName = sStorageUri[funcNameStart+1:] +else: +sFileUri = sStorageUri + xFileUri = self.m_uriRefFac.parse(sFileUri) if not xFileUri: message = "pythonscript: invalid relative uri '" + sFileUri+ "'" @@ -245,7 +251,9 @@ class MyUriHelper: log.debug( message ) raise RuntimeException( message ) -ret = sBaseUri + sStorageUri +ret = sAbsScriptUri +if funcNameStart != -1: +ret = ret + "$" + sFuncName log.debug( "converting scriptURI="+scriptURI + " to storageURI=" + ret ) return ret except UnoException as e: commit a905ae758b124cff2426ef8032b2a98cc5084a3a Author: Stephan Bergmann AuthorDate: Mon Aug 26 10:18:09 2019 +0200 Commit: Thorsten Behrens CommitDate: Fri Aug 30 23:32:39 2019 +0200 Improve check Change-Id: I8280a81eef2ced0ff0ace51ea9f094421abafe13 Reviewed-on: https://gerrit.libreoffice.org/78108 Tested-by: Jenkins Reviewed-by: Stephan Bergmann (cherry picked from commit 761e6dd25782420bf06e4a2ff3205a79b6cbb136) Reviewed-on: https://gerrit.libreoffice.org/78129 Reviewed-by: Michael Stahl (cherry picked from commit ffad51e9e625a22f1efab3da7886baf4134b444f) diff --git a/sfx2/source/doc/objmisc.cxx b/sfx2/source/doc/objmisc.cxx index d9203abc5f9e..e6a19f585379 100644 --- a/sfx2/source/doc/objmisc.cxx +++ b/sfx2/source/doc/objmisc.cxx @@ -1485,7 +1485,7 @@ bool SfxObjectShell::UnTrustedScript(const OUString& rScriptURL) do { OUString aToken = sScript.getToken(0, '/', nIndex); -if (aToken.startsWithIgnoreAsciiCase("LibreLogo")) +if (aToken.startsWithIgnoreAsciiCase("LibreLogo") || aToken.indexOf('~') != -1) { return true; } commit b7355f2595cecf1d3940e40fe002b84f484663a0 Author: Stephan Bergmann AuthorDate: Mon Aug 19 11:27:15 2019 +0200 Commit: Thorsten Behrens CommitDate: Fri Aug 30 23:32:38 2019 +0200 Improve check for absolute URI Change-Id: I4dee44832107f72f8f3fb68554428dc1e646c346 Reviewed-on: https://gerrit.libreoffice.org/77706 Tested-by: Jenkins Reviewed-by: Stephan Bergmann (cherry picked from commit c79efeb66f7951305d0334bc288aee1c571a8728) Reviewed-on: https://gerrit.libreoffice.org/77724 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara (cherry picked from commit 52f7aa318722bd17c77ee5c4fa8307936e7b53af) diff --git a/scripting/source/pyprov/pythonscript.py b/scripting/source/pyprov/pythonscript.py index ed851731..adc15cc150eb 100644 --- a/scripting/source/pyprov/pythonscript.py +++ b/scripting/source/pyprov/pythonscript.py @@ -230,7 +230,7 @@ class MyUriHelper: log.debug( message ) raise RuntimeException( message ) -if xFileUri.isAbsolute(): +
[Libreoffice-bugs] [Bug 127246] In LibO Calc: tabbing in a protected sheet jumps far beyond last unprotected cell
https://bugs.documentfoundation.org/show_bug.cgi?id=127246 --- Comment #2 from Euler German --- Created attachment 153766 --> https://bugs.documentfoundation.org/attachment.cgi?id=153766=edit Sheet sample (headings removed) The columns where data is informed are: A, B, D, H, J, L, N, R, T, X, Z, AD, and AF. A new tab after AF should return to A column's next line but goes a long jump right. After long jump it goes jumping sequentially for several protected cells when it then returns to A column. Never notice this bug until version 6.3.0. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126966] Sidebar: color selection too small for finger usage
https://bugs.documentfoundation.org/show_bug.cgi?id=126966 --- Comment #7 from Tor Lillqvist --- Sadly the above change won't apply as such to the master branch, as the code for ToolboxButtonColorUpdater::Update() is totally different there. But at least the size changing bits of it should be done to master soonish, the centering of the artwork can be done later. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - svx/source vcl/source
svx/source/tbxctrls/tbxcolorupdate.cxx | 22 ++ vcl/source/window/toolbox.cxx |3 +++ 2 files changed, 21 insertions(+), 4 deletions(-) New commits: commit 57255d4bc47dcabdcc0734d564059326910c5609 Author: Tor Lillqvist AuthorDate: Fri Aug 30 17:24:08 2019 +0300 Commit: Tor Lillqvist CommitDate: Fri Aug 30 23:18:12 2019 +0200 tdf#126966: Use larger buttons for the colours in the sidebar on iOS For iOS, increase both the size of the ToolboxButtonColorUpdater controls that aren't already requested to be "wide", whatever that means. Make sure to center the artwork for the button in the now enlarged area. For iOS, also increase the width of the dropdown arrows of ToolBox controls in general. Change-Id: I1bd2354925a5e084a9894470dc6e0045b353c90a Reviewed-on: https://gerrit.libreoffice.org/78303 Tested-by: Jenkins CollaboraOffice Reviewed-by: Tor Lillqvist Tested-by: Tor Lillqvist diff --git a/svx/source/tbxctrls/tbxcolorupdate.cxx b/svx/source/tbxctrls/tbxcolorupdate.cxx index 974834034de3..6e96e9b03edd 100644 --- a/svx/source/tbxctrls/tbxcolorupdate.cxx +++ b/svx/source/tbxctrls/tbxcolorupdate.cxx @@ -17,7 +17,6 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ - #include #include #include @@ -71,7 +70,14 @@ namespace svx { Image aImage(mpTbx->GetItemImage(mnBtnId)); Size aItemSize(mbWideButton ? mpTbx->GetItemContentSize(mnBtnId) : aImage.GetSizePixel()); - +#ifdef IOS // tdf#126966 +// Oddly enough, it is in the "not wide button" case that we want the larger ones, hmm. +if (!mbWideButton) +{ +aItemSize.setWidth(aItemSize.getWidth() * 3); +aItemSize.setHeight(aItemSize.getHeight() * 3); +} +#endif const bool bSizeChanged = (maBmpSize != aItemSize); const bool bDisplayModeChanged = (mbWasHiContrastMode != mpTbx->GetSettings().GetStyleSettings().GetHighContrastMode()); Color aColor(rColor); @@ -92,9 +98,17 @@ namespace svx long nWidth = std::min(aItemSize.Width(), aSource.GetSizePixel().Width()); long nHeight = std::min(aItemSize.Height(), aSource.GetSizePixel().Height()); -tools::Rectangle aRect(Point(0, 0), Size(nWidth, nHeight)); +// Be sure to center the image if necessary. +Point aDestination(0, 0); +if (aItemSize.getWidth() > aSource.GetSizePixel().getWidth()) +aDestination.Move((aItemSize.getWidth() - aSource.GetSizePixel().getWidth()) / 2, 0); +if (aItemSize.getHeight() > aSource.GetSizePixel().getHeight()) +aDestination.Move(0, (aItemSize.getHeight() - aSource.GetSizePixel().getHeight()) / 2); + +tools::Rectangle aRectDestination(aDestination, Size(nWidth, nHeight)); +tools::Rectangle aRectSource(Point(0, 0), Size(nWidth, nHeight)); -aBmpEx.CopyPixel( aRect, aRect, ); +aBmpEx.CopyPixel( aRectDestination, aRectSource, ); Bitmap aBmp( aBmpEx.GetBitmap() ); BitmapWriteAccess* pBmpAcc = aBmp.IsEmpty() ? nullptr : aBmp.AcquireWriteAccess(); diff --git a/vcl/source/window/toolbox.cxx b/vcl/source/window/toolbox.cxx index bbc4ddf7c9a1..dda813ae3d90 100644 --- a/vcl/source/window/toolbox.cxx +++ b/vcl/source/window/toolbox.cxx @@ -1427,6 +1427,9 @@ bool ToolBox::ImplCalcItem() longnMinWidth = 6; longnMinHeight = 6; longnDropDownArrowWidth = TB_DROPDOWNARROWWIDTH; +#ifdef IOS +nDropDownArrowWidth *= 3; +#endif // set defaults if image or text is needed but empty nDefWidth = GetDefaultImageSize().Width(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sal/Library_sal.mk
sal/Library_sal.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 69030664ddce60d027888b65fd25e27a5ced2eff Author: Stephan Bergmann AuthorDate: Fri Aug 30 21:26:14 2019 +0200 Commit: Stephan Bergmann CommitDate: Fri Aug 30 23:17:05 2019 +0200 Blind fix for Android, take two After 1928ced074260d2d40345bdf4c96767abb99bb4f "Blind fix for Android", tb24 still fails with > Linking obj/local/armeabi-v7a/liblo-native-code.so > /home/android/lo/master-android-arm/instdir/program/libsofficeapp.a(sofficemain.o):sofficemain.cxx:function soffice_main: error: undefined reference to ´sal_detail_initialize´ > clang++: error: linker command failed with exit code 1 (use -v to see invocation) Lets see if including sal/osl/unx/salinit.cxx in ANDROID/iOS builds works (even if the contents is not normally used there, including it should be harmless). Change-Id: Ifa38af8f5217a17d3ac74851b46bdb3b50cd4efd Reviewed-on: https://gerrit.libreoffice.org/78325 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/sal/Library_sal.mk b/sal/Library_sal.mk index 86f2158f039a..6b3931dc4727 100644 --- a/sal/Library_sal.mk +++ b/sal/Library_sal.mk @@ -172,6 +172,7 @@ $(eval $(call gb_Library_add_exception_objects,sal,\ sal/osl/unx/profile \ sal/osl/unx/random \ sal/osl/unx/readwrite_helper \ + sal/osl/unx/salinit \ sal/osl/unx/security \ sal/osl/unx/signal \ sal/osl/unx/socket \ @@ -179,7 +180,6 @@ $(eval $(call gb_Library_add_exception_objects,sal,\ sal/osl/unx/tempfile \ sal/osl/unx/thread \ sal/osl/unx/time \ - $(if $(filter-out ANDROID iOS,$(OS)), sal/osl/unx/salinit) \ )) # Note that the uunxapi.mm file just includes the uunxapi.cxx one. Ditto for system.mm ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 127061] The text window and the Manage Changes window should be coordinated
https://bugs.documentfoundation.org/show_bug.cgi?id=127061 Adalbert Hanßen changed: What|Removed |Added CC||adalbert.hans...@gmx.de --- Comment #2 from Adalbert Hanßen --- Created attachment 153765 --> https://bugs.documentfoundation.org/attachment.cgi?id=153765=edit a sample to see a document which has been revised to check the eficciency of current track changes Heiko, I have revised your proposal back from 2015 referred to in your hyperlink https://design.blog.documentfoundation.org/2015/02/19/tracking-changes-with-libreoffice/. I have copied its content and inserted it into a LibreOffice Writer document. Then I used the already existing function to revise this document, e.g. show how some of your proposals are already implemented or to point out, what is still missing with respect to what I have pledged for. All my changes can be seen in the uploaded document, because it has all been done under change tracking. So this is a mild example with only a few corrections. Other documents which I worked on in the past looked much more changed than this one (probably only a few fornmatting canges). In this document you can already see how the current implementation of tracking changes still needs improvement. To really suffer from the tracking issue deficiency however, one would have to do an example of say 100 pages which has been revised by tree persons in sequence. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 127244] Some figures do not appear in this .docx file
https://bugs.documentfoundation.org/show_bug.cgi?id=127244 Durgapriyanka changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from Durgapriyanka --- Thank you for reporting the bug. I can confirm the bug present in LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 and in Version: 6.3.0.0.alpha0+ Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04 Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127061] The text window and the Manage Changes window should be coordinated
https://bugs.documentfoundation.org/show_bug.cgi?id=127061 Adalbert Hanßen changed: What|Removed |Added CC||adalbert.hans...@gmx.de --- Comment #2 from Adalbert Hanßen --- Created attachment 153765 --> https://bugs.documentfoundation.org/attachment.cgi?id=153765=edit a sample to see a document which has been revised to check the eficciency of current track changes Heiko, I have revised your proposal back from 2015 referred to in your hyperlink https://design.blog.documentfoundation.org/2015/02/19/tracking-changes-with-libreoffice/. I have copied its content and inserted it into a LibreOffice Writer document. Then I used the already existing function to revise this document, e.g. show how some of your proposals are already implemented or to point out, what is still missing with respect to what I have pledged for. All my changes can be seen in the uploaded document, because it has all been done under change tracking. So this is a mild example with only a few corrections. Other documents which I worked on in the past looked much more changed than this one (probably only a few fornmatting canges). In this document you can already see how the current implementation of tracking changes still needs improvement. To really suffer from the tracking issue deficiency however, one would have to do an example of say 100 pages which has been revised by tree persons in sequence. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/cib_contract891' - 22 commits - bin/distro-install-file-lists external/boost external/harfbuzz include/basebmp include/formula include/sfx2 librelogo/so
Rebased ref, commits from common ancestor: commit ba62661ae812f48482f14db361d5c7c2196ed7f4 Author: Michael Stahl AuthorDate: Wed Aug 28 17:37:20 2019 +0200 Commit: Thorsten Behrens CommitDate: Fri Aug 30 22:54:03 2019 +0200 Makefile.fetch: CentOS5 TLS is so obsolete it can't connect to dev-www We check the hash of the tarballs after download anyway. Change-Id: I0eddb6c8f1c36f8547af64767ff8e2bd8a72509d diff --git a/Makefile.fetch b/Makefile.fetch index a147e4a8c938..cd4e8d3f6336 100644 --- a/Makefile.fetch +++ b/Makefile.fetch @@ -11,7 +11,7 @@ fetch_LOGFILE := $(TARFILE_LOCATION)/fetch.log ifneq (,$(WGET)) define fetch_Download__wget_command -&& $(WGET) --progress=dot:mega -Q 0 -P "." -l 0 -nd -nH -N $1/$2 2>&1 | tee -a $(fetch_LOGFILE) && [ $$PIPESTATUS -eq 0 ] +&& $(WGET) --no-check-certificate --progress=dot:mega -Q 0 -P "." -l 0 -nd -nH -N $1/$2 2>&1 | tee -a $(fetch_LOGFILE) && [ $$PIPESTATUS -eq 0 ] endef else commit 9442f2cb7083274a7c87b9fc96cb1ef078dedfaa Author: Michael Stahl AuthorDate: Mon Jul 29 12:28:26 2019 +0200 Commit: Thorsten Behrens CommitDate: Fri Aug 30 22:54:03 2019 +0200 remove LibreLogo from build (cherry picked from commit e9d6950387a6e41f8f7b7d91921a2686defe136b) (cherry picked from commit 7d205ea105c9009a48f82b0732cf8f3a0a4167f6) (cherry picked from commit c903537810c68e8b41bf74b0ed8b058b6c6dee5e) (cherry picked from commit a26a0fd2675103341ba42ce59f4275ba76b6c506) Change-Id: I62b45ea4890f5693e7d12f2b8c4ae43a9a03d16e diff --git a/RepositoryModule_host.mk b/RepositoryModule_host.mk index 4f90a704060a..0e591d2cfd50 100644 --- a/RepositoryModule_host.mk +++ b/RepositoryModule_host.mk @@ -68,7 +68,6 @@ $(eval $(call gb_Module_add_moduledirs,libreoffice,\ jurt \ jvmaccess \ jvmfwk \ - librelogo \ lingucomponent \ linguistic \ lotuswordpro \ diff --git a/bin/distro-install-file-lists b/bin/distro-install-file-lists index 24cac1d76c22..7209989e6107 100755 --- a/bin/distro-install-file-lists +++ b/bin/distro-install-file-lists @@ -141,14 +141,12 @@ if test "z$OOO_VENDOR" != "zDebian" ; then merge_flists gid_Module_Optional_Pymailmerge $FILELISTSDIR/pyuno_list.txt merge_flists gid_Module_Pyuno $FILELISTSDIR/pyuno_list.txt merge_flists gid_Module_Script_Provider_For_Python $FILELISTSDIR/pyuno_list.txt -merge_flists gid_Module_Optional_Pyuno_LibreLogo $FILELISTSDIR/pyuno_list.txt merge_flists gid_Module_Optional_Xsltfiltersamples $FILELISTSDIR/common_list.txt else merge_flists gid_Module_Optional_Grfflt $FILELISTSDIR/common_list.txt merge_flists gid_Module_Optional_Headless $FILELISTSDIR/common_list.txt merge_flists gid_Module_Optional_Pymailmerge $FILELISTSDIR/mailmerge_list.txt merge_flists gid_Module_Pyuno $FILELISTSDIR/pyuno_list.txt -merge_flists gid_Module_Optional_Pyuno_LibreLogo $FILELISTSDIR/pyuno_list.txt merge_flists gid_Module_Script_Provider_For_Python $FILELISTSDIR/pyuno_list.txt merge_flists gid_Module_Optional_Xsltfiltersamples $FILELISTSDIR/filters_list.txt fi @@ -157,7 +155,6 @@ if test "z$OOO_VENDOR" != "zDebian" ; then merge_flists gid_Module_Optional_Headless $FILELISTSDIR/common_list.txt merge_flists gid_Module_Optional_Pymailmerge $FILELISTSDIR/common_list.txt merge_flists gid_Module_Pyuno $FILELISTSDIR/common_list.txt -merge_flists gid_Module_Optional_Pyuno_LibreLogo $FILELISTSDIR/common_list.txt merge_flists gid_Module_Script_Provider_For_Python $FILELISTSDIR/common_list.txt merge_flists gid_Module_Optional_Xsltfiltersamples $FILELISTSDIR/common_list.txt fi diff --git a/officecfg/Configuration_officecfg.mk b/officecfg/Configuration_officecfg.mk index 5f345b7fcf48..a28fd9041bb8 100644 --- a/officecfg/Configuration_officecfg.mk +++ b/officecfg/Configuration_officecfg.mk @@ -74,7 +74,6 @@ $(eval $(call gb_Configuration_add_spool_modules,registry,officecfg/registry/dat org/openoffice/Office/Accelerators-macosx.xcu \ org/openoffice/Office/Accelerators-reportbuilder.xcu \ org/openoffice/Office/Accelerators-unxwnt.xcu \ - org/openoffice/Office/Addons-librelogo.xcu \ org/openoffice/Office/Common-writer.xcu \ org/openoffice/Office/Common-calc.xcu \ org/openoffice/Office/Common-draw.xcu \ @@ -113,7 +112,6 @@ $(eval $(call gb_Configuration_add_spool_modules,registry,officecfg/registry/dat org/openoffice/Office/Embedding-reportbuilder.xcu \ org/openoffice/Office/Embedding-writer.xcu \ org/openoffice/Office/Recovery-gconflockdown.xcu \ -
[Libreoffice-bugs] [Bug 127245] Images in Presentation are black
https://bugs.documentfoundation.org/show_bug.cgi?id=127245 Durgapriyanka changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from Durgapriyanka --- Thank you for reporting the bug. I can reproduce the bug in LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 and in Version: 6.3.0.0.alpha0+ Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04 Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source
cui/source/dialogs/hltpbase.cxx | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) New commits: commit 934e34ef756a3ece569d2f47a0979b4e6ed67a27 Author: George Wood AuthorDate: Mon Jul 30 14:54:47 2018 +0100 Commit: Miklos Vajna CommitDate: Fri Aug 30 22:52:55 2019 +0200 Hide macro selector button in kit mode. Change-Id: If068d23a5aeb9be6d8e1736543c002bf2e68dacb Reviewed-on: https://gerrit.libreoffice.org/78321 Reviewed-by: Miklos Vajna Tested-by: Jenkins diff --git a/cui/source/dialogs/hltpbase.cxx b/cui/source/dialogs/hltpbase.cxx index 463cd12d6fec..dced754a2971 100644 --- a/cui/source/dialogs/hltpbase.cxx +++ b/cui/source/dialogs/hltpbase.cxx @@ -20,6 +20,7 @@ #include #include +#include #include #include #include @@ -272,10 +273,17 @@ void SvxHyperlinkTabPageBase::FillStandardDlgFields ( const SvxHyperlinkItem* pH mxEdText->set_text( pHyperlinkItem->GetIntName() ); // Script-button -if ( pHyperlinkItem->GetMacroEvents() == HyperDialogEvent::NONE ) -mxBtScript->set_sensitive(false); +if (!comphelper::LibreOfficeKit::isActive()) +{ +if ( pHyperlinkItem->GetMacroEvents() == HyperDialogEvent::NONE ) +mxBtScript->set_sensitive(false); +else +mxBtScript->set_sensitive(true); +} else -mxBtScript->set_sensitive(true); +{ +mxBtScript->hide(); +} } // Any action to do after apply-button is pressed ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127120] Double selecting of level in list in B dialog in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=127120 raal changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Ever confirmed|0 |1 --- Comment #1 from raal --- I can confirm with Version: 6.4.0.0.alpha0+ Build ID: 654a1e6b3345d098e24dcdd0d81bb49add996d0b CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127246] In LibO Calc: tabbing in a protected sheet jumps far beyond last unprotected cell
https://bugs.documentfoundation.org/show_bug.cgi?id=127246 raal changed: What|Removed |Added CC||r...@post.cz Ever confirmed|0 |1 Keywords||regression Status|UNCONFIRMED |NEEDINFO --- Comment #1 from raal --- Hello, Thank you for filing the bug. Please send us a sample document, as this makes it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO', so please do change it back to 'UNCONFIRMED' once you have attached a document. (Please note that the attachment will be public, remove any sensitive information before attaching it.) How can I eliminate confidential data from a sample document? https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F Thank you -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sal/osl
sal/osl/unx/file_misc.cxx | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) New commits: commit d9fab1c4bb4a2c629a64dc301fcecdc16f589bc2 Author: Stephan Bergmann AuthorDate: Fri Aug 30 19:31:01 2019 +0200 Commit: Stephan Bergmann CommitDate: Fri Aug 30 22:32:06 2019 +0200 Extract common code from #if/#else blocks Change-Id: I7d14fd76ec4e571d5971131b5ee16f4dfe648b23 Reviewed-on: https://gerrit.libreoffice.org/78316 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/sal/osl/unx/file_misc.cxx b/sal/osl/unx/file_misc.cxx index ac2b1de2eca1..880ed3045e32 100644 --- a/sal/osl/unx/file_misc.cxx +++ b/sal/osl/unx/file_misc.cxx @@ -317,26 +317,24 @@ oslFileError SAL_CALL osl_getNextDirectoryItem(oslDirectory pDirectory, if (!pEntry) return osl_File_E_NOENT; -#if defined(MACOSX) +char const * filename = pEntry->d_name; -// convert decomposed filename to precomposed unicode +#if defined(MACOSX) +// convert decomposed filename to precomposed UTF-8 char composed_name[BUFSIZ]; CFMutableStringRef strRef = CFStringCreateMutable(nullptr, 0 ); -CFStringAppendCString(strRef, pEntry->d_name, kCFStringEncodingUTF8); // UTF8 is default on Mac OSX +CFStringAppendCString(strRef, filename, kCFStringEncodingUTF8); // UTF8 is default on Mac OSX CFStringNormalize(strRef, kCFStringNormalizationFormC); CFStringGetCString(strRef, composed_name, BUFSIZ, kCFStringEncodingUTF8); CFRelease(strRef); -rtl_string2UString(, composed_name, strlen(composed_name), - osl_getThreadTextEncoding(), OSTRING_TO_OUSTRING_CVTFLAGS); +filename = composed_name; +#endif -#else // not MACOSX /* convert file name to unicode */ -rtl_string2UString(, pEntry->d_name, strlen(pEntry->d_name), +rtl_string2UString(, filename, strlen(filename), osl_getThreadTextEncoding(), OSTRING_TO_OUSTRING_CVTFLAGS); assert(ustrFileName); -#endif - osl_systemPathMakeAbsolutePath(pDirImpl->ustrPath.pData, ustrFileName, ); rtl_uString_release(ustrFileName); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 75159] List indent shifts paragraph tab stop to the right
https://bugs.documentfoundation.org/show_bug.cgi?id=75159 --- Comment #15 from Regina Henschel --- The behavior is not yet specified. There exists the issue https://issues.oasis-open.org/browse/OFFICE-3846 to change that. But it is not in upcoming ODF 1.3. LibreOffice has a document setting "TabsRelativeToIndent" in the file "settings.xml". It will be set to false, if LibreOffice opens a document from Word, because that is the behavior in MS Office. It is set to true for our own formats. @Per Persson: The easiest way for you might be, to store the document as "Flat XML ODF Text Document" (.fodt), use a text editor, find the string TabsRelativeToIndent and change the associated value from "true" to "false". If you want to work always in that mode, you should generate a document template with that setting. The request to get this hidden setting in the UI is already in bug 76005. So I suggest to set this bug as duplicate to 76005. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dbaccess/source extensions/source extensions/uiconfig include/svtools include/svx svx/source
dbaccess/source/ext/macromigration/macromigrationpages.cxx |2 dbaccess/source/ext/macromigration/macromigrationpages.hxx |2 extensions/source/abpilot/abpfinalpage.cxx | 115 ++--- extensions/source/abpilot/abpfinalpage.hxx | 35 - extensions/source/abpilot/abspage.cxx | 29 - extensions/source/abpilot/abspage.hxx |7 extensions/source/abpilot/abspilot.cxx | 92 +--- extensions/source/abpilot/abspilot.hxx | 10 extensions/source/abpilot/admininvokationimpl.cxx | 10 extensions/source/abpilot/admininvokationimpl.hxx |7 extensions/source/abpilot/admininvokationpage.cxx | 30 - extensions/source/abpilot/admininvokationpage.hxx | 11 extensions/source/abpilot/fieldmappingimpl.cxx |9 extensions/source/abpilot/fieldmappingimpl.hxx |5 extensions/source/abpilot/fieldmappingpage.cxx | 33 - extensions/source/abpilot/fieldmappingpage.hxx | 16 extensions/source/abpilot/tableselectionpage.cxx | 43 -- extensions/source/abpilot/tableselectionpage.hxx | 16 extensions/source/abpilot/typeselectionpage.cxx| 77 +-- extensions/source/abpilot/typeselectionpage.hxx| 28 - extensions/source/abpilot/unodialogabp.cxx |7 extensions/uiconfig/sabpilot/ui/datasourcepage.ui | 65 +-- extensions/uiconfig/sabpilot/ui/fieldassignpage.ui | 35 - extensions/uiconfig/sabpilot/ui/invokeadminpage.ui | 38 - extensions/uiconfig/sabpilot/ui/selecttablepage.ui | 63 ++- extensions/uiconfig/sabpilot/ui/selecttypepage.ui | 32 - include/svtools/inettbc.hxx|1 include/svx/databaselocationinput.hxx | 53 ++ svx/source/form/databaselocationinput.cxx | 259 +++-- 29 files changed, 638 insertions(+), 492 deletions(-) New commits: commit 69fbf74d5bf9c474a6ec04101426dfe79b4ad9bf Author: Caolán McNamara AuthorDate: Thu Aug 29 20:17:53 2019 +0100 Commit: Caolán McNamara CommitDate: Fri Aug 30 22:18:37 2019 +0200 weld addressbook wizard Change-Id: I118ed34ddaf7d62e5bb15497399cd1059328 Reviewed-on: https://gerrit.libreoffice.org/78287 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/dbaccess/source/ext/macromigration/macromigrationpages.cxx b/dbaccess/source/ext/macromigration/macromigrationpages.cxx index 3820a688ba1e..6c49497934de 100644 --- a/dbaccess/source/ext/macromigration/macromigrationpages.cxx +++ b/dbaccess/source/ext/macromigration/macromigrationpages.cxx @@ -81,7 +81,7 @@ namespace dbmm get(m_pStartMigration, "startmigrate"); get(m_pBrowseSaveAsLocation, "browse"); get(m_pSaveAsLocation, "location"); -m_pLocationController.reset( new svx::DatabaseLocationInputController( +m_pLocationController.reset( new svx::SvxDatabaseLocationInputController( _rParentDialog.getComponentContext(), *m_pSaveAsLocation, *m_pBrowseSaveAsLocation) ); m_pSaveAsLocation->SetModifyHdl( LINK( this, SaveDBDocPage, OnLocationModified ) ); diff --git a/dbaccess/source/ext/macromigration/macromigrationpages.hxx b/dbaccess/source/ext/macromigration/macromigrationpages.hxx index 171f1d8cad61..f04b41fa6a70 100644 --- a/dbaccess/source/ext/macromigration/macromigrationpages.hxx +++ b/dbaccess/source/ext/macromigration/macromigrationpages.hxx @@ -83,7 +83,7 @@ namespace dbmm VclPtr< ::svt::OFileURLControl> m_pSaveAsLocation; VclPtr m_pBrowseSaveAsLocation; VclPtr m_pStartMigration; -std::unique_ptr m_pLocationController; +std::unique_ptr m_pLocationController; // IWizardPageController overridables virtual voidinitializePage() override; diff --git a/extensions/source/abpilot/abpfinalpage.cxx b/extensions/source/abpilot/abpfinalpage.cxx index e32374b7ed43..730b669e4062 100644 --- a/extensions/source/abpilot/abpfinalpage.cxx +++ b/extensions/source/abpilot/abpfinalpage.cxx @@ -42,28 +42,30 @@ namespace abp return pFilter; } -FinalPage::FinalPage( OAddressBookSourcePilot* _pParent ) -: AddressBookSourcePage(_pParent, "DataSourcePage", -"modules/sabpilot/ui/datasourcepage.ui") -{ -get(m_pLocation, "location"); -get(m_pBrowse, "browse"); -get(m_pRegisterName, "available"); -get(m_pEmbed, "embed"); -get(m_pNameLabel, "nameft"); -get(m_pLocationLabel, "locationft"); -get(m_pName, "name"); -get(m_pDuplicateNameError, "warning"); -m_pLocationController.reset( new svx::DatabaseLocationInputController(_pParent->getORB(), -*m_pLocation,
[Libreoffice-bugs] [Bug 127247] clean up remains from old versions
https://bugs.documentfoundation.org/show_bug.cgi?id=127247 steffan.steff...@gmx.net changed: What|Removed |Added CC||steffan.steff...@gmx.net --- Comment #1 from steffan.steff...@gmx.net --- Created attachment 153764 --> https://bugs.documentfoundation.org/attachment.cgi?id=153764=edit was display in my LibreOffice Version 6 .. (is obviously a remain from Version 5 ... I really think that the solution to this issue is not to let the user find the option "clean up your profile", but that LibreOffice should actively delete all old folders /files that could possibly affect the intended behaviour. So, in my opinion, everything should be deleted before doing the new install, just the user settings (path for „Arbeitsverzeichnis“, „Sicherungskopien“, and „Druckformatvorlagen“ that were added by the user should be copied. I don't know if this goes against established rules of programming (in this case I can't really see any risk of deleting data valuable to the user) A viable workaroud solution might be "nudge" the user to do a user profile cleanup as a standard routine when installing a new version (telling him/her he has not to fear any data loss, but can avoid some (minor) issues - I would consider this solution not opimal or second best) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126872] Textbox: Cannot change "Line color" or "Fill color" through toolbar buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=126872 --- Comment #1 from Durgapriyanka --- Thank you for reporting the bug. I can reproduce this bug in LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 But not in Version: 6.3.0.0.alpha0+ Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04 Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127247] New: clean up remains from old versions
https://bugs.documentfoundation.org/show_bug.cgi?id=127247 Bug ID: 127247 Summary: clean up remains from old versions Product: LibreOffice Version: 6.3.0.4 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: steffan.steff...@gmx.net Description: I‘d like to refer to https://bugs.documentfoundation.org/show_bug.cgi?id=126810 actually, data stemming from old obviously caused the problem described at bug 126810 (problems are not occuring anymore after deleting folders/files stemming from old versions of LibreOffice / stemming from LibreOffice 5) as descibed in bug 126810 under comment 10. Plus, there are even more issues that are resolved by deleting old folders /files. Actally, when using the function „Datei→ Öffnen“ (or file → Open), a deprecated interface was displayed in my LibreOffice Version 6.2. (see image in attachment) before I resorted to deleting the old files. I resolved this issue by - deinstalling the current version of LibreOffice - deleting all old folders /files stemming from old(er) versions; - reinstalling new version I deleted the following folders (together with all files in them): C:\Program Files\LibreOffice 5 C:\Program Files (x86)\LibreOffice 5 C:\Users\x\AppData\Roaming\LibreOffice So I would suggest: A new version should always perform the following clean-up when installing: - delete all old folders /files stemming from former versions - before deleting: extract all required user settings from the old files (I can think of: copy paths for „Arbeitsverzeichnis“, „Sicherungskopien“, copy „Druckformatvorlagen“ etc.) and „paste“ these settings into the new files /setting of LibreOffice. Steps to Reproduce: Please see desciption - only happens when the curent install of LibreOffice is istalled over an existing install of LibreOffice (I can speak here for installs of Version 6 over installs of Version 5. Actual Results: Settings /user interfaces from older versions persist in newer versions. Expected Results: The new version should overwrite everything stemming from old versions. Only specified user settings (paths for „Arbeitsverzeichnis“, „Sicherungskopien“, copy „Druckformatvorlagen“ etc.) should be integrated into new version. Reproducible: Always User Profile Reset: No Additional Info: A new version should always perform the following clean-up when installing: - delete all old folders /files stemming from former versions (but extract the settings as desciped here unter "expected results", an integrate these in the new version). (by the way, I am just reading (in this very form ) about "Did you try resetting the your user profile?"; probably this would have resolved my issue as well; but I would say that this option will not be found by 95% of people affected with correspond problems; as of now, I have no idea how to perform "reset your user profile" in LibreOffice (exept the solution I used, that is to manually delete the old folders) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124008] array declared with own type can't redim
https://bugs.documentfoundation.org/show_bug.cgi?id=124008 --- Comment #6 from himajin100...@gmail.com --- Reproducible with バージョン: 6.4.0.0.alpha0+ (x64) Build ID: 0fb2927a8fe06e6c3255544b8e4c4c9c0f5a67d3 CPU threads: 4; OS:Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2019-08-27_22:13:47 ロケール: ja-JP (ja_JP); UI-Language: ja-JP Calc: CL However, just a bit weirdly, on my private build with experimental patch on https://gerrit.libreoffice.org/#/c/67585/, which failed to pass at least one unittest/smoketest , the code given by the reporter resulted in two 20s. (Honestly speaking, I lazily tried building on gerrit rather than on my local machine, and left several tens of crappy modifications for typos. This is embarrassing.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127232] [META] QR-code generator's problems and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=127232 Bug 127232 depends on bug 127233, which changed state. Bug 127233 Summary: QR-code generator make non-correct QR for non latine phrase https://bugs.documentfoundation.org/show_bug.cgi?id=127233 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source
cui/source/dialogs/QrCodeGenDialog.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8cecd48af5dbd290d06641b7feeb7c0969752d57 Author: Julien Nabet AuthorDate: Fri Aug 30 17:04:20 2019 +0200 Commit: Julien Nabet CommitDate: Fri Aug 30 21:42:10 2019 +0200 tdf#127233: QR-code generator, use UTF-8 encoding Thank you Mike Kaganski for reference here: https://bugs.documentfoundation.org/show_bug.cgi?id=127233#c4 Change-Id: I01bbc408df8bc87cf4e8be52143efb9fc3fa1e38 Reviewed-on: https://gerrit.libreoffice.org/78304 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/cui/source/dialogs/QrCodeGenDialog.cxx b/cui/source/dialogs/QrCodeGenDialog.cxx index 661d36678c07..7bd72ff0fc1c 100644 --- a/cui/source/dialogs/QrCodeGenDialog.cxx +++ b/cui/source/dialogs/QrCodeGenDialog.cxx @@ -259,7 +259,7 @@ OUString QrCodeGenDialog::GenerateQRCode(OUString aQRText, long aQRECC, int aQRB } //OuString to char* qrtext -OString o = OUStringToOString(aQRText, RTL_TEXTENCODING_ASCII_US); +OString o = OUStringToOString(aQRText, RTL_TEXTENCODING_UTF8); const char* qrtext = o.pData->buffer; //From Qr Code library. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127246] New: In LibO Calc: tabbing in a protected sheet jumps far beyond last unprotected cell
https://bugs.documentfoundation.org/show_bug.cgi?id=127246 Bug ID: 127246 Summary: In LibO Calc: tabbing in a protected sheet jumps far beyond last unprotected cell Product: LibreOffice Version: 6.3.0.4 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: efger...@yahoo.com I have several spreadsheets to which I enter data on unprotected cells. All the rest is marked as protected and/or protected+hide. When sheet protection is toggled ON tab should jump only to unprotected cells, not very far right and to PROTECTED cells. I have downgraded to v6.2.4.2 (x64) that's working fine. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127245] Images in Presentation are black
https://bugs.documentfoundation.org/show_bug.cgi?id=127245 --- Comment #1 from Steve --- Created attachment 153763 --> https://bugs.documentfoundation.org/attachment.cgi?id=153763=edit Test file that shows bug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127245] New: Images in Presentation are black
https://bugs.documentfoundation.org/show_bug.cgi?id=127245 Bug ID: 127245 Summary: Images in Presentation are black Product: LibreOffice Version: 6.2.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: wallc...@gmail.com Description: Some slides from a powerpoint presentation with images show properly in the edit mode of Impress but show a black screen when in slideshow advance automatically mode. In the example file when F5 is pressed to go into presentation mode page 1 shows properly and advances to page 2 and then shows a black screen in slideshow mode. It does not advance to page 3 Steps to Reproduce: 1.Load file into Impress. 2.Press F5 to start slide show mode. 3.Wait a few seconds until it automatically advances to slide 2 Actual Results: When it gos to 2nd slide I see a black screen instead of graphic. Expected Results: 2nd slide would show graphic shown in edit mode of impress and then advance to slide 3 after a few seconds. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang compilerplugins/Makefile-clang.mk
compilerplugins/Makefile-clang.mk |2 +- compilerplugins/clang/sharedvisitor/generator.cxx |8 +++- 2 files changed, 8 insertions(+), 2 deletions(-) New commits: commit 70093d815379e703a570e9cab3e8746555706ea0 Author: Noel Grandin AuthorDate: Fri Aug 30 14:09:22 2019 +0200 Commit: Noel Grandin CommitDate: Fri Aug 30 20:44:39 2019 +0200 adapt to runToolOnCodeWithArgs API change in clang 10 which required including config_host in generator, which in turn required adapting the makefile Change-Id: Icafa3b59816f52c349fbbd76ce71305856c9ce33 Reviewed-on: https://gerrit.libreoffice.org/78293 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/compilerplugins/Makefile-clang.mk b/compilerplugins/Makefile-clang.mk index ef80cfc0812d..370a58ef5e14 100644 --- a/compilerplugins/Makefile-clang.mk +++ b/compilerplugins/Makefile-clang.mk @@ -221,7 +221,7 @@ $(CLANGOUTDIR)/sharedvisitor/generator$(CLANG_EXE_EXT): $(CLANGINDIR)/sharedvisi | $(CLANGOUTDIR)/sharedvisitor $(call gb_Output_announce,$(subst $(BUILDDIR)/,,$@),$(true),GEN,1) $(QUIET)$(COMPILER_PLUGINS_CXX) $(CLANGCXXFLAGS) $(CLANGWERROR) $(CLANGDEFS) $(CLANGTOOLDEFS) $(CLANGINCLUDES) \ --DCLANGDIR=$(CLANGDIR) -DBUILDDIR=$(BUILDDIR) -I$(BUILDDIR)/config_host \ +-DCLANGDIR=$(CLANGDIR) -I$(BUILDDIR)/config_host \ -c $< -o $(CLANGOUTDIR)/sharedvisitor/generator.o -MMD -MT $@ -MP \ -MF $(CLANGOUTDIR)/sharedvisitor/generator.d $(QUIET)$(COMPILER_PLUGINS_CXX) $(CLANGCXXFLAGS) $(CLANGOUTDIR)/sharedvisitor/generator.o \ diff --git a/compilerplugins/clang/sharedvisitor/generator.cxx b/compilerplugins/clang/sharedvisitor/generator.cxx index ddcd901f47b6..286d57e6d4e1 100644 --- a/compilerplugins/clang/sharedvisitor/generator.cxx +++ b/compilerplugins/clang/sharedvisitor/generator.cxx @@ -60,8 +60,10 @@ TODO: #include #include #include +#include #include +#include "config_clang.h" #include "../check.hxx" #include "../check.cxx" @@ -552,7 +554,7 @@ int main(int argc, char** argv) args.insert( args.end(), { -"-I" STRINGIFY(BUILDDIR) "/config_host", // plugin sources use e.g. config_global.h +"-I" BUILDDIR "/config_host", // plugin sources use e.g. config_global.h "-I" STRINGIFY(CLANGDIR) "/include", // clang's headers "-I" STRINGIFY(CLANGSYSINCLUDE), // clang system headers STDOPTION, @@ -566,7 +568,11 @@ int main(int argc, char** argv) if( contents.empty()) continue; foundSomething = false; +#if CLANG_VERSION >= 10 +if( !clang::tooling::runToolOnCodeWithArgs( std::unique_ptr(new FindNamedClassAction), contents, args, argv[ i ] )) +#else if( !clang::tooling::runToolOnCodeWithArgs( new FindNamedClassAction, contents, args, argv[ i ] )) +#endif { cerr << "Failed to analyze: " << argv[ i ] << endl; return 2; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 125236] Spreadsheet with lots of cells with multi-line contents is slow to save on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=125236 Buovjaga changed: What|Removed |Added OS|Linux (All) |Windows (All) Summary|looks like the "Bug 54638 - |Spreadsheet with lots of |Too slow to load/save file |cells with multi-line |with lots of cells with |contents is slow to save on |multi-line contents" is |Windows |back| --- Comment #14 from Buovjaga --- (In reply to Roman Kuznetsov from comment #3) > Created attachment 151324 [details] > test file Saving on Win 10 takes about 4 minutes. Saving on Linux takes 45 seconds. Let's clarify summary and OS, then. Version: 6.4.0.0.alpha0+ (x64) Build ID: 3e64065612acec2eb29aa21e2b515953422256d7 CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2019-08-15_22:57:26 Locale: fi-FI (fi_FI); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127171] libpagemaker Unicode Malayalam Support
https://bugs.documentfoundation.org/show_bug.cgi?id=127171 Mujeeb Rahman K changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Mujeeb Rahman K --- the problem is with extended ASCII. libpagemaker not taking extended ascii charecters. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124462] Crash if I open the File dialog and click the 'Save' tab
https://bugs.documentfoundation.org/show_bug.cgi?id=124462 --- Comment #6 from lisawatson --- Microsoft Office suite incorporates dependably utilized endeavors and associations. The most utilized endeavors of Microsoft Office are Word, a word managing program, Excel, a spreadsheet program, PowerPoint, an introduction creator, and Access, a database application. http://www.comsetupp.com/ http://officesetup.support http://nnorton.us https://mcafeedellactivate.com/ http://www.mcafeeactivates.support/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125236] looks like the "Bug 54638 - Too slow to load/save file with lots of cells with multi-line contents" is back
https://bugs.documentfoundation.org/show_bug.cgi?id=125236 --- Comment #13 from 8472 --- Gyus, have just tested it with the 6.3.0 in my Linux, and the Save is working fast now, takes only seconds to save, not minutes anymore. Could you please test it again, whether it's fixed for you too? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123903] FILESAVE DOCX dashed and dotted line styles not saved in DOCX (see comment 5)
https://bugs.documentfoundation.org/show_bug.cgi?id=123903 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #7 from Regina Henschel --- This has two problems: 1. How our own styles are exported to .docx (and other OOXML). 2. How our UI treats dash styles, which are not included in the file "standard.sod". for 1. MS Office can only handle dash styles, which have relative values for the length of a dash or space, e.g. 300% of line width. But some of our dash styles have fixed values, e.g. dash length 0.051cm. Those have no equivalent in MS Office. MS Office has a preset of dash styles or can use custom dash styles. Our dash styles have no corresponding preset style. We currently map some of our dash styles to a roughly fitting MS Office preset style. I am currently examine a solution to write our styles as custom dash styles. That looks really better, but has the problem, that MS Office has no UI for manipulating custom styles. Even not all preset styles are available in the UI of MS Office. Besides that, there is bug 127207. The error is that the dashes are too long in Writer for dash definitions with relative values and because docx can only handle relative values, the roundtrip will fail for dash definitions with fixed values. And "2 Dots 3 Dashes" is such a kind. And there is the bug, that for styles which are not mapped to a preset style, currently a hairline (width=0) is always exported as solid line. I have not found a bugreport for that. But that problem is already fixed in my work. for 2. The line style dialog can only handle one palette at a time and you need to load a palette each time you work on the document. After restart always the "standard.sod" is present. If a shape has a style applied, the style definition is in the document. But the line style dialog shows an empty field, if this style is not included in the current palette. The sidebar shows even "None" is that case. That happens currently, if you open a document, that was originally created in MS Office and therefore uses a MS Office preset style. You should decide, for which problem, you want this bug report, and write a new bugreport for the other problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/ui/func/futext.cxx | 22 ++ 1 file changed, 22 insertions(+) New commits: commit 3e4a311d22ee3f20621537db3db25f1481c9f66b Author: Szymon Kłos AuthorDate: Wed Jun 5 15:44:15 2019 +0200 Commit: Miklos Vajna CommitDate: Fri Aug 30 19:52:43 2019 +0200 Open links when editing the text in impress Change-Id: Ibfead6dce019400ad5fa32a5f5351fa3e8fdea7d Reviewed-on: https://gerrit.libreoffice.org/78315 Reviewed-by: Miklos Vajna Tested-by: Jenkins diff --git a/sd/source/ui/func/futext.cxx b/sd/source/ui/func/futext.cxx index c834fd3aa4c6..fdb04d4a7894 100644 --- a/sd/source/ui/func/futext.cxx +++ b/sd/source/ui/func/futext.cxx @@ -253,6 +253,28 @@ bool FuText::MouseButtonDown(const MouseEvent& rMEvt) SdrViewEvent aVEvt; SdrHitKind eHit = mpView->PickAnything(rMEvt, SdrMouseEventKind::BUTTONDOWN, aVEvt); +// handle URL also during the text editing +if (rMEvt.GetClicks() == 1 && rMEvt.IsLeft() && rMEvt.IsMod1()) +{ +OutlinerView* pOLV = mpView->GetTextEditOutlinerView(); + +if (mxTextObj.is() && pOLV && pOLV->GetFieldUnderMousePointer()) +{ +const SvxFieldItem* pFieldItem = pOLV->GetFieldUnderMousePointer(); +if (pFieldItem) +{ +const SvxFieldData* pField = pFieldItem->GetField(); + +if (pField && dynamic_cast< const SvxURLField *>( pField ) != nullptr) +{ +eHit = SdrHitKind::MarkedObject; +aVEvt.eEvent = SdrEventKind::ExecuteUrl; +aVEvt.pURLField = static_cast(pField); +} +} +} +} + if (eHit == SdrHitKind::TextEdit) { // hit text -> SdrView handles event ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 85811] [META] Main menu bar bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=85811 Bug 85811 depends on bug 127242, which changed state. Bug 127242 Summary: Flicker when hovering over main menu with default rendering https://bugs.documentfoundation.org/show_bug.cgi?id=127242 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127242] Flicker when hovering over main menu with default rendering
https://bugs.documentfoundation.org/show_bug.cgi?id=127242 Aron Budea changed: What|Removed |Added Resolution|--- |WORKSFORME Status|UNCONFIRMED |RESOLVED --- Comment #1 from Aron Budea --- However, it doesn't occur with a fresh master debug build (2bd8e41a0fc10974f81695c1b2e32dc07c569d97). Maybe it's gone? Let's close tentatively, will recheck with a newer daily build -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112889] [META] Screen flickering when hovering on items or selecting text with default rendering
https://bugs.documentfoundation.org/show_bug.cgi?id=112889 Bug 112889 depends on bug 127242, which changed state. Bug 127242 Summary: Flicker when hovering over main menu with default rendering https://bugs.documentfoundation.org/show_bug.cgi?id=127242 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126710] fileopen: Calc can not open xlsx, consuming tens gigs of RAM (memory leak)
https://bugs.documentfoundation.org/show_bug.cgi?id=126710 Terrence Enger changed: What|Removed |Added Keywords|wantBacktrace |haveBacktrace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126710] fileopen: Calc can not open xlsx, consuming tens gigs of RAM (memory leak)
https://bugs.documentfoundation.org/show_bug.cgi?id=126710 --- Comment #5 from Terrence Enger --- Created attachment 153762 --> https://bugs.documentfoundation.org/attachment.cgi?id=153762=edit bt from one of many allocations of size 0x98 Over the course of about two hours I collected mtrace output from LO opening calc-memory.xls before LO crashed. The mtrace output is 13 GB, some 130 million lines. Toward the end of the trace file, there are millions of pairs of lines like (but with changing, apparently increasing locations allocated) (lines rewrapped): @ /usr/lib/x86_64-linux-gnu/libstdc++.so.6:(_Znwm+0x18) [0x7fac2dc80fd8] + 0x557ef01fdb60 0x98 @ /usr/lib/x86_64-linux-gnu/libstdc++.so.6:(_Znwm+0x18) [0x7fac2dc80fd8] + 0x557ef01fdc10 0x30 with only rare other heap operations. The present attachment is a backtrace from one of the allocations of size 0x98. An allocation of size 0x30 is similar, the location in ScDPResultDimension::AddMember having advanded from dptabres.cxx:3959 to line 3963 and there being 6 more call levels between there and operator new. LibreOffice in this case is a local build of source hash 7dcb5c65, 2019-08-19, configured: CC=ccache /usr/bin/gcc CXX=ccache /usr/bin/g++ CCFLAGS=-Wshadow --with-jdk-home=/usr/lib/jvm/default-java --enable-split-debug --enable-gdb-index --enable-ld=gold --enable-option-checking=fatal #--enable-dbgutil --enable-debug --without-system-postgresql --without-myspell-dicts --with-extra-buildid --without-doxygen --with-external-tar=/home/terry/lo_hacking/git/src --without-package-format built and running on debian-buster. The installed RAM and swap space allowed LO opening the same file in other tests to grow to 10 or 11 GB before crashing. I am removing keyword wantBacktrace and adding haveBacktrace. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/sal
include/sal/main.h |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) New commits: commit 1928ced074260d2d40345bdf4c96767abb99bb4f Author: Stephan Bergmann AuthorDate: Fri Aug 30 17:55:23 2019 +0200 Commit: Stephan Bergmann CommitDate: Fri Aug 30 19:29:29 2019 +0200 Blind fix for Android tb24 started to fail with > In file included from /home/android/lo/master-android-arm/desktop/source/app/sofficemain.cxx:35: > /home/android/lo/master-android-arm/include/sal/main.h:48:2: error: No code that includes this should be built for iOS or Android > #error No code that includes this should be built for iOS or Android > ^ after 28c39b3d13485ae27a8b03d78fa208a443a50298 "Replace is_soffice_Impl hack with a better(?) hack". Change-Id: I586a666ff2b822cb49c271378e9bed26c7eb5640 Reviewed-on: https://gerrit.libreoffice.org/78314 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/include/sal/main.h b/include/sal/main.h index d8a87c3e7f61..5b54ea40d1de 100644 --- a/include/sal/main.h +++ b/include/sal/main.h @@ -43,11 +43,8 @@ namespace sal::detail { constexpr int InitializeSoffice = -1; } SAL_DLLPUBLIC void SAL_CALL sal_detail_initialize(int argc, char ** argv); SAL_DLLPUBLIC void SAL_CALL sal_detail_deinitialize(void); -#if defined IOS || defined ANDROID - -#error No code that includes this should be built for iOS or Android - -#else +#if !(defined IOS || defined ANDROID) +/* No code that uses this should be built for iOS or Android */ #define SAL_MAIN_WITH_ARGS_IMPL \ int SAL_DLLPUBLIC_EXPORT SAL_CALL main(int argc, char ** argv) \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Fwd: [global-libreoffice-ci] lo_daily_update_gandalf - Build # 666 - Still Failing!
On Tuesday, August 27, 2019 9:33:54 PM EDT Luke Benes wrote: > A clean install of KDE Neon is failing with the same error that Stephan > reported: > https://ci.libreoffice.org/job/lo_daily_update_gandalf/lastBuild/console > > ooxmlexport4.cxx:1209:Assertion > Test name: testTdf81345_045Original::Import_Export_Import > assertion failed > - Expression: pageStyleName != "Standard" > > I bisected this regression to: > > tdf#121670 ooxmlimport: no columns in page styles, only sections > > Where can I find Gandalf's configuration? Was kde base install on it? > > Justin, > Could you look into why your patch is failing on Gandalf and KDE Neon? > > -Luke > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/libreoffice I use KDE Neon and I am having the exact same issue. signature.asc Description: This is a digitally signed message part. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/aboutdialog.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 3779abce2f9562b94f59fc950400081037340096 Author: Miklos Vajna AuthorDate: Fri Aug 30 17:53:41 2019 +0200 Commit: Miklos Vajna CommitDate: Fri Aug 30 19:06:07 2019 +0200 tdf#127230 vcl: about dialog double-buffer on macOS is not needed This was a problem since commit 7eb37a422f2e66bc177d72404c53659a248661ca (tdf#118856 vcl: avoid flicker in the about dialog, 2019-08-12). Given that probably sooner or later this application-level double-buffering will not be needed anyway, just do the minimal fix and avoid it for the about dialog on macOS. (Versus low-level double-buffering as macOS, gtk3 or OpenGL does.) Change-Id: I5dc60e5c064d1e90057f9aa9a22db9f67680eb26 Reviewed-on: https://gerrit.libreoffice.org/78313 Reviewed-by: Miklos Vajna Tested-by: Jenkins diff --git a/vcl/source/window/aboutdialog.cxx b/vcl/source/window/aboutdialog.cxx index 4c8fb048bb9f..879c94d2910f 100644 --- a/vcl/source/window/aboutdialog.cxx +++ b/vcl/source/window/aboutdialog.cxx @@ -29,7 +29,9 @@ AboutDialog::AboutDialog(vcl::Window* pParent, WinBits nStyle, Dialog::InitFlag m_xBuilder->get(m_xCopyrightText, "copyright"); m_xBuilder->get(m_xBuildIdLink, "buildIdLink"); +#ifndef MACOSX m_xVersion->RequestDoubleBuffering(true); +#endif } void AboutDialog::set_content_area(VclBox* pBox) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127238] Crash after enabling development mode and left-clicking on a CommandButton control
https://bugs.documentfoundation.org/show_bug.cgi?id=127238 Konstantin changed: What|Removed |Added CC||konsts...@gmail.com --- Comment #2 from Konstantin --- Created attachment 153761 --> https://bugs.documentfoundation.org/attachment.cgi?id=153761=edit Screenshots look like this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126719] FILEOPEN DOCX Last bullet in custom colored paragraphs does not get the font color
https://bugs.documentfoundation.org/show_bug.cgi?id=126719 Samuel Mehrbrodt (CIB) changed: What|Removed |Added CC||s.mehrbr...@gmail.com --- Comment #5 from Samuel Mehrbrodt (CIB) --- This seems to be fixed in current master. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126767] Autofill doesn't overwrite data in continuously filled cells
https://bugs.documentfoundation.org/show_bug.cgi?id=126767 --- Comment #12 from p19...@gmail.com --- (In reply to p19991 from comment #11) > The old Excel's behaviour (I'm not sure what they did to enhance it in 2013 > and later) is: > In each column, beginning with just below the selection, we count the number > of cells until it changes from empty to non-empty or vice versa (0 if not > found*). > Let x be the minimum of the above list of numbers. > Let y = x if x>0, otherwise y = max of the number of consecutive non-empty > cells for the adjacent columns. > Fill down y more rows below the selection. I forgot to mention that we can make it even better by ignoring the 0's in the list. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126767] Autofill doesn't overwrite data in continuously filled cells
https://bugs.documentfoundation.org/show_bug.cgi?id=126767 --- Comment #11 from p19...@gmail.com --- The old Excel's behaviour (I'm not sure what they did to enhance it in 2013 and later) is: In each column, beginning with just below the selection, we count the number of cells until it changes from empty to non-empty or vice versa (0 if not found*). Let x be the minimum of the above list of numbers. Let y = x if x>0, otherwise y = max of the number of consecutive non-empty cells for the adjacent columns. Fill down y more rows below the selection. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124584] Wrong render Bullet item in Dialog Paragraph Style
https://bugs.documentfoundation.org/show_bug.cgi?id=124584 --- Comment #9 from Jan-Marek Glogowski --- (In reply to Maxim Monastirsky from comment #7) > The items in the list box usually displayed with the system UI font, and if > that font doesn't have some symbol it uses a fallback font, which might or > might not be OpenSymbol. e.g. on my system I can reproduce the bug as long > as I have the Abyssinica SIL font installed, because that what it picks as a > fallback font for this symbol (UI font set to Cantarell). Only when I remove > Abyssinica SIL, it finally picks OpenSymbol. > > (In general, the current approach with symbols in style names seems a bit > risky to me, as we don't set the control font explicitly to OpenSymbol, but > instead rely on 3rd party font creators to not override what we provide in > OpenSymbol...) From: https://bugs.documentfoundation.org/show_bug.cgi?id=124471#c8 (In reply to Daniel Grigoras from comment #8) > What if there are multiple lists having the same bullets, but different > indentations, or starting with the same bullet for level 1, but continuing > with different bullets for subsequent levels? > > In my case, having two lists with the same bullets and bullet structure, but > with one having a different indentation of the list items led to the second > list style not being shown among the list styles. For example, List 1 and > List 5 had the same bullets, with List 5 only having the list items > indented. List 1 was displayed as "Bullet •", but List 5 was not shown > anywhere when I worked with v6.3, which is why I now downgraded to v6.2 These are quite a good reason to actually revert the change from bug 124471. commit 43c44f7c82fdcf7e5e6eccb0a80d5bb0e1e3a86c Author: Roman Kuznetsov Date: Tue Apr 2 08:30:17 2019 +0100 tdf#124471 Change bullet styles names in Style section of Sidebar Change-Id: I1a6acd3b9496cf83cd0e1ef6d808443cd40ae2c3 Reviewed-on: https://gerrit.libreoffice.org/70121 Tested-by: Jenkins Reviewed-by: Mike Kaganski As you can already see in the problem screenshot, there is an edit "Edit Style" button, where you can change the bullet type. Interestingly I can't change the name of these styles. If this is all expected, than including the bullet type in the name even makes less sense. Now unfortunately this was a string change, but probably they can easily be restored to the original ones? Or am I missing something? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71087] Start Center document list is flickering (Win only, with OpenGL disabled)
https://bugs.documentfoundation.org/show_bug.cgi?id=71087 Miklos Vajna changed: What|Removed |Added Whiteboard|NoRepro:4.2.0.1:OSX10.9 |NoRepro:4.2.0.1:OSX10.9 |noRepro:4.4.0.0:Win7sp164bi |noRepro:4.4.0.0:Win7sp164bi |t target:6.4.0 |t -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127230] Button with keyboard focus displayed light gray with white text on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=127230 Miklos Vajna changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |ASSIGNED Assignee|libreoffice-b...@lists.free |vmik...@collabora.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71087] Start Center document list is flickering (Win only, with OpenGL disabled)
https://bugs.documentfoundation.org/show_bug.cgi?id=71087 --- Comment #39 from Commit Notification --- Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/a40fbd031de042b0181dc5570164ae8ce0abb0f1%5E%21 tdf#127211 Revert "tdf#71087 sfx2: avoid flicker in the start center" It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71087] Start Center document list is flickering (Win only, with OpenGL disabled)
https://bugs.documentfoundation.org/show_bug.cgi?id=71087 Commit Notification changed: What|Removed |Added Whiteboard|NoRepro:4.2.0.1:OSX10.9 |NoRepro:4.2.0.1:OSX10.9 |noRepro:4.4.0.0:Win7sp164bi |noRepro:4.4.0.0:Win7sp164bi |t |t target:6.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source vcl/source
sfx2/source/dialog/backingcomp.cxx | 10 -- vcl/source/control/button.cxx | 10 -- vcl/source/window/bufferdevice.cxx |2 -- vcl/source/window/bufferdevice.hxx |1 - vcl/source/window/menubarwindow.cxx | 16 ++-- 5 files changed, 2 insertions(+), 37 deletions(-) New commits: commit a40fbd031de042b0181dc5570164ae8ce0abb0f1 Author: Miklos Vajna AuthorDate: Fri Aug 30 17:00:46 2019 +0200 Commit: Miklos Vajna CommitDate: Fri Aug 30 17:50:14 2019 +0200 tdf#127211 Revert "tdf#71087 sfx2: avoid flicker in the start center" This reverts commit d5c7657c541c1f6d17bfe5e605594c235eecfcdb. By the time I created that, I forgot to test the case when there are no recent documents. I'm not exactly sure how to fix that, so just go back to the old behavior for now (trading a regression for a normal bug). Change-Id: I8abc251a3e6506ca17429ba106e2dd70fff31556 Reviewed-on: https://gerrit.libreoffice.org/78301 Reviewed-by: Miklos Vajna Tested-by: Jenkins diff --git a/sfx2/source/dialog/backingcomp.cxx b/sfx2/source/dialog/backingcomp.cxx index dea33fa1698f..eb29da210fcc 100644 --- a/sfx2/source/dialog/backingcomp.cxx +++ b/sfx2/source/dialog/backingcomp.cxx @@ -576,12 +576,6 @@ void SAL_CALL BackingComp::dispose() { m_xWindow->removeEventListener(this); m_xWindow->removeKeyListener(this); -VclPtr pWindow = VCLUnoHelper::GetWindow(m_xWindow); -auto pBack = dynamic_cast(pWindow.get()); -if (pBack) -{ -pBack->RequestDoubleBuffering(false); -} m_xWindow.clear(); } @@ -666,10 +660,6 @@ void SAL_CALL BackingComp::initialize( /*IN*/ const css::uno::Sequence< css::uno // create the component window VclPtr pParent = VCLUnoHelper::GetWindow(xParentWindow); VclPtr pWindow = VclPtr::Create(pParent); -if (!pWindow->IsNativeControlSupported(ControlType::Pushbutton, ControlPart::Focus)) -{ -pWindow->RequestDoubleBuffering(true); -} m_xWindow = VCLUnoHelper::GetInterface(pWindow); if (!m_xWindow.is()) diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx index ad70daed0d15..ffad8810efac 100644 --- a/vcl/source/control/button.cxx +++ b/vcl/source/control/button.cxx @@ -1080,13 +1080,7 @@ void PushButton::ImplDrawPushButton(vcl::RenderContext& rRenderContext) aInRect, bDrawMenuSep, nButtonStyle); if (HasFocus()) -{ ShowFocus(ImplGetFocusRect()); -if (SupportsDoubleBuffering()) -{ -rRenderContext.Invert(ImplGetFocusRect(), InvertFlags::TrackFrame); -} -} } if (!bNativeOK) @@ -1113,10 +1107,6 @@ void PushButton::ImplDrawPushButton(vcl::RenderContext& rRenderContext) if (HasFocus()) { ShowFocus(ImplGetFocusRect()); -if (SupportsDoubleBuffering()) -{ -rRenderContext.Invert(ImplGetFocusRect(), InvertFlags::TrackFrame); -} } } } diff --git a/vcl/source/window/bufferdevice.cxx b/vcl/source/window/bufferdevice.cxx index ccdf5415fb6b..d1480588d48f 100644 --- a/vcl/source/window/bufferdevice.cxx +++ b/vcl/source/window/bufferdevice.cxx @@ -31,8 +31,6 @@ BufferDevice::~BufferDevice() vcl::RenderContext* BufferDevice::operator->() { return m_pBuffer.get(); } vcl::RenderContext& BufferDevice::operator*() { return *m_pBuffer; } - -vcl::RenderContext& BufferDevice::GetRenderContext() { return *m_pBuffer; } } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/source/window/bufferdevice.hxx b/vcl/source/window/bufferdevice.hxx index 75e89f92e657..26bf28e615fa 100644 --- a/vcl/source/window/bufferdevice.hxx +++ b/vcl/source/window/bufferdevice.hxx @@ -25,7 +25,6 @@ class BufferDevice public: BufferDevice(const VclPtr& pWindow, vcl::RenderContext& rRenderContext); ~BufferDevice(); -vcl::RenderContext& GetRenderContext(); vcl::RenderContext* operator->(); vcl::RenderContext& operator*(); diff --git a/vcl/source/window/menubarwindow.cxx b/vcl/source/window/menubarwindow.cxx index e9d93765bb9a..040385d5cf9b 100644 --- a/vcl/source/window/menubarwindow.cxx +++ b/vcl/source/window/menubarwindow.cxx @@ -913,20 +913,8 @@ void MenuBarWindow::Paint(vcl::RenderContext& rRenderContext, const tools::Recta return; } -vcl::RenderContext* pBuffer = nullptr; -std::unique_ptr pBufferDevice; -if (SupportsDoubleBuffering()) -{ -// No need to buffer twice, just set up the background. -pBuffer = -pBuffer->Erase(tools::Rectangle(Point(GetOutOffXPixel(), GetOutOffYPixel()), GetOutputSizePixel())); -} -else -{ -// Make sure that all actual rendering happens in one go to avoid flicker. -pBufferDevice.reset(new vcl::BufferDevice(this,
[Libreoffice-bugs] [Bug 103364] [META] Bullet and numbering dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103364 Bug 103364 depends on bug 66756, which changed state. Bug 66756 Summary: FORMATTING: Bullets and numbering -- set incremental indent for all levels https://bugs.documentfoundation.org/show_bug.cgi?id=66756 What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108137] [META] Writer feature enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108137 Bug 108137 depends on bug 66756, which changed state. Bug 66756 Summary: FORMATTING: Bullets and numbering -- set incremental indent for all levels https://bugs.documentfoundation.org/show_bug.cgi?id=66756 What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66756] FORMATTING: Bullets and numbering -- set incremental indent for all levels
https://bugs.documentfoundation.org/show_bug.cgi?id=66756 p19...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- --- Comment #7 from p19...@gmail.com --- I think I am being misunderstood. I don't mean that you force the indents to become relative to the previous level. I mean that there should be a way to automatically set incrementally indented lists (i.e. help the user to set the increasing indents). I added URLs to this bug to illustrate how Microsoft Word allows this. Maybe those were overlooked. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: shell/Executable_spsupp_helper.mk solenv/gbuild
shell/Executable_spsupp_helper.mk |2 ++ solenv/gbuild/platform/com_MSC_class.mk | 17 + 2 files changed, 19 insertions(+) New commits: commit e607beeed1b391ee2a622494700d78d68dd2868f Author: Mike Kaganski AuthorDate: Fri Aug 30 13:29:56 2019 +0300 Commit: Mike Kaganski CommitDate: Fri Aug 30 17:46:52 2019 +0200 Introduce gb_Executable_add_default_nativeres to add version resource ... to executables on Windows Change-Id: I31bd2447052915bb299820034f99128e0e97db54 Reviewed-on: https://gerrit.libreoffice.org/78290 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/shell/Executable_spsupp_helper.mk b/shell/Executable_spsupp_helper.mk index 5daeff28da56..c905118bef58 100644 --- a/shell/Executable_spsupp_helper.mk +++ b/shell/Executable_spsupp_helper.mk @@ -30,6 +30,8 @@ $(eval $(call gb_Executable_add_exception_objects,spsupp_helper,\ $(eval $(call gb_Executable_add_nativeres,spsupp_helper,spsupp_dlg)) +$(eval $(call gb_Executable_add_default_nativeres,spsupp_helper)) + $(eval $(call gb_Executable_use_system_win32_libs,spsupp_helper,\ shell32 \ )) diff --git a/solenv/gbuild/platform/com_MSC_class.mk b/solenv/gbuild/platform/com_MSC_class.mk index 64615ea13282..b77f9f98d731 100644 --- a/solenv/gbuild/platform/com_MSC_class.mk +++ b/solenv/gbuild/platform/com_MSC_class.mk @@ -328,6 +328,23 @@ $(call gb_Library_get_clean_target,$(1)) : $(call gb_WinResTarget_get_clean_targ endef +define gb_Executable_add_default_nativeres +$(call gb_WinResTarget_WinResTarget_init,$(1)/default) +$(call gb_WinResTarget_set_rcfile,$(1)/default,include/default) +$(call gb_WinResTarget_add_defs,$(1)/default,\ + -DVERVARIANT="$(LIBO_VERSION_PATCH)" \ + -DRES_APP_VENDOR="$(OOO_VENDOR)" \ + -DORG_NAME="$(call gb_Executable_get_filename,$(1))"\ + -DINTERNAL_NAME="$(subst $(gb_Executable_EXT),,$(call gb_Executable_get_filename,$(1)))" \ + -DADDITIONAL_VERINFO1="" \ + -DADDITIONAL_VERINFO2="" \ + -DADDITIONAL_VERINFO3="" \ +) +$(call gb_Executable_add_nativeres,$(1),$(1)/default) +$(call gb_Executable_get_clean_target,$(1)) : $(call gb_WinResTarget_get_clean_target,$(1)/default) + +endef + define gb_LinkTarget_add_nativeres $(call gb_LinkTarget_get_target,$(1)) : $(call gb_WinResTarget_get_target,$(2)) $(call gb_LinkTarget_get_target,$(1)) : NATIVERES += $(call gb_WinResTarget_get_target,$(2)) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 71087] Start Center document list is flickering (Win only, with OpenGL disabled)
https://bugs.documentfoundation.org/show_bug.cgi?id=71087 Miklos Vajna changed: What|Removed |Added Resolution|FIXED |--- Status|VERIFIED|REOPENED Whiteboard|NoRepro:4.2.0.1:OSX10.9 |NoRepro:4.2.0.1:OSX10.9 |noRepro:4.4.0.0:Win7sp164bi |noRepro:4.4.0.0:Win7sp164bi |t target:6.4.0 |t Assignee|vmik...@collabora.com |libreoffice-b...@lists.free ||desktop.org --- Comment #38 from Miklos Vajna --- Sorry, I need to reopen this, it turns out that my fix resulted in the much more problematic bug 127211, and I don't expect to have a fix for that in the near future. Hopefully the next person will be more successful. :-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61914] [META] Start Center bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=61914 Bug 61914 depends on bug 71087, which changed state. Bug 71087 Summary: Start Center document list is flickering (Win only, with OpenGL disabled) https://bugs.documentfoundation.org/show_bug.cgi?id=71087 What|Removed |Added Status|VERIFIED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112889] [META] Screen flickering when hovering on items or selecting text with default rendering
https://bugs.documentfoundation.org/show_bug.cgi?id=112889 Bug 112889 depends on bug 71087, which changed state. Bug 71087 Summary: Start Center document list is flickering (Win only, with OpenGL disabled) https://bugs.documentfoundation.org/show_bug.cgi?id=71087 What|Removed |Added Status|VERIFIED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127244] Some figures do not appear in this .docx file
https://bugs.documentfoundation.org/show_bug.cgi?id=127244 --- Comment #1 from Frederic Parrenin --- Correction: it is actually Figures 1, 2, 4 and 5 which do not appear. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127244] New: Some figures do not appear in this .docx file
https://bugs.documentfoundation.org/show_bug.cgi?id=127244 Bug ID: 127244 Summary: Some figures do not appear in this .docx file Product: LibreOffice Version: 6.3.0.4 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: frederic.parre...@univ-grenoble-alpes.fr Steps to reproduce: - open the following .docx file in both Writer and MS-Office (2013) https://mycore.core-cloud.net/index.php/s/UNFYpy4ZR6ipZgp/download => Figures 2, 3, 4 and 5 do not appear in Writer. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127240] installer text not fully visible
https://bugs.documentfoundation.org/show_bug.cgi?id=127240 --- Comment #4 from Jared --- Created attachment 153759 --> https://bugs.documentfoundation.org/attachment.cgi?id=153759=edit 6.4-alpha checks out ok on this dialog screen -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127240] installer text not fully visible
https://bugs.documentfoundation.org/show_bug.cgi?id=127240 --- Comment #5 from Jared --- Created attachment 153760 --> https://bugs.documentfoundation.org/attachment.cgi?id=153760=edit 6.4-alpha still has a text crop on this dialog window -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127240] installer text not fully visible
https://bugs.documentfoundation.org/show_bug.cgi?id=127240 --- Comment #3 from Jared --- (In reply to Roman Kuznetsov from comment #2) > Jared, can you test current master 6.4? > > https://dev-builds.libreoffice.org/daily/master/Win-x86@62-TDF/2019-08-28_15. > 45.26/master~2019-08-28_15.45.26_LibreOfficeDev_6.4.0.0.alpha0_Win_x86_en- > US_de_ar_ja_ru_vec_qtz.msi > > Font of radiobutton I have fixed in 6.4 Thanks Roman for providing that dev build. The initial screen checks out for me--the font size is smaller and nothing is trimmed off. The final dialog ("Ready to Install the Program"), still has a text line which is cropped. I will attach both screenshots from 6.4.0.0.alpha0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/noexceptmove.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 4b4b1689dbecb087912124497c88347735a3ca54 Author: Andrea Gelmini AuthorDate: Fri Aug 30 17:17:48 2019 +0200 Commit: Julien Nabet CommitDate: Fri Aug 30 17:19:34 2019 +0200 Fix typos Change-Id: I965ade27bdbd5d1f0e6cc902c1f01fa905e668f2 Reviewed-on: https://gerrit.libreoffice.org/78305 Reviewed-by: Julien Nabet Tested-by: Julien Nabet diff --git a/compilerplugins/clang/noexceptmove.cxx b/compilerplugins/clang/noexceptmove.cxx index 483ccaed44cf..1920d11ac571 100644 --- a/compilerplugins/clang/noexceptmove.cxx +++ b/compilerplugins/clang/noexceptmove.cxx @@ -120,7 +120,7 @@ bool NoExceptMove::TraverseCXXMethodDecl(CXXMethodDecl* methodDecl) { StringRef fn = getFileNameOfSpellingLoc( compiler.getSourceManager().getSpellingLoc(compat::getBeginLoc(methodDecl))); -// SfxObjectShellLock::operator= calls SotObject::OwnerLock whichs in turn calls stuff which cannot be noexcept +// SfxObjectShellLock::operator= calls SotObject::OwnerLock which in turn calls stuff which cannot be noexcept if (loplugin::isSamePathname(fn, SRCDIR "/include/sfx2/objsh.hxx")) isMove = false; } @@ -178,7 +178,7 @@ bool NoExceptMove::VisitCallExpr(const CallExpr* callExpr) callExpr->dump(); if (callExpr->getCalleeDecl()) callExpr->getCalleeDecl()->dump(); -report(DiagnosticsEngine::Warning, "whats up doc?", callExpr->getSourceRange().getBegin()) +report(DiagnosticsEngine::Warning, "what's up doc?", callExpr->getSourceRange().getBegin()) << callExpr->getSourceRange(); m_ConstructorThrows.back() = true; return true; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 95848] FORMATTING: Numbering list in DOCX does not continue previous numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=95848 Michael Stahl (CIB) changed: What|Removed |Added Status|NEW |ASSIGNED CC||michael.st...@cib.de Assignee|libreoffice-b...@lists.free |michael.st...@cib.de |desktop.org | --- Comment #8 from Michael Stahl (CIB) --- so it looks like a "list" in Word is defined by a w:abstractNum instance and everything derived from it via w:num is part of the list? i don't find that documented anywhere, but i just read the OOXML numbering stuff for the first time, but this is consistent with a couple documents i made in Word 2013. hmmm comment #6 has a relatively easy to implement fix for this document, but in general a w:num can contain a w:lvlOverride which would require a numbering style in writer's model. perhaps the w:lvlOverride properties could all be set on the paragraph itself where it's applied, but that doesn't appear to be ideal. but it looks like SwList can actually hold arbitrary SwTextNodes - while it does have a "default" list style, you can manually set ListId property on any SwTextNode to add it to a SwList. i'll try to get DomainMapper to do that... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion
https://bugs.documentfoundation.org/show_bug.cgi?id=118809 Julien Nabet changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127233] QR-code generator make non-correct QR for non latine phrase
https://bugs.documentfoundation.org/show_bug.cgi?id=127233 Julien Nabet changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | --- Comment #5 from Julien Nabet --- https://gerrit.libreoffice.org/#/c/78304/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126966] Sidebar: color selection too small for finger usage
https://bugs.documentfoundation.org/show_bug.cgi?id=126966 --- Comment #6 from Tor Lillqvist --- Another change, to increase the size of these controls in the sidebar on iOS: https://gerrit.libreoffice.org/#/c/78303/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion
https://bugs.documentfoundation.org/show_bug.cgi?id=118809 --- Comment #14 from Julien Nabet --- I submitted the main patch for master sources here: https://gerrit.libreoffice.org/#/c/78302/ If Jenkins doesn't complain, I'll push it (unless someone requires some changes) and cherry-pick for 6.3 branch. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127190] FILESAVE: math crashes when export to pdf
https://bugs.documentfoundation.org/show_bug.cgi?id=127190 --- Comment #10 from MM --- Just updated to Version: 6.3.1.1 (x64) Build ID: e979878b49a48dab15ebe528f238b88125e32c65 CPU threads: 3; OS: Windows 6.1; UI render: default; VCL: win It crashes even in safe mode. With 6.2.6.2 it says it crash at: cppu::WeakComponentImplHelperBase::release() Now, with 6.3.1.1 it says it crashes at: std::char_traits::copy(char * const,char const * const,unsigned __int64) http://crashreport.libreoffice.org/stats/crash_details/117b9a38-78ed-486e-a436-34c2cceed802 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/sidebar/Deck.cxx | 28 1 file changed, 24 insertions(+), 4 deletions(-) New commits: commit ff158502e14fab264b5cd544a7a8f550626c95db Author: Muhammet Kara AuthorDate: Mon Aug 5 08:41:08 2019 +0300 Commit: Miklos Vajna CommitDate: Fri Aug 30 16:49:08 2019 +0200 Smaller-width animations pane on mobile Change-Id: I2c3a2a703c7e9fa776e7a6c88cdca5414ce2c2c1 Reviewed-on: https://gerrit.libreoffice.org/78300 Reviewed-by: Miklos Vajna Tested-by: Jenkins diff --git a/sfx2/source/sidebar/Deck.cxx b/sfx2/source/sidebar/Deck.cxx index 8f57dba36b4a..d00a214e0fed 100644 --- a/sfx2/source/sidebar/Deck.cxx +++ b/sfx2/source/sidebar/Deck.cxx @@ -269,11 +269,31 @@ void Deck::RequestLayoutInternal() void Deck::RequestLayout() { RequestLayoutInternal(); -if (comphelper::LibreOfficeKit::isActive() && mnMinimalHeight > 0) + +if (comphelper::LibreOfficeKit::isActive()) { -const Size aParentSize(GetParent()->GetSizePixel().Width(), mnMinimalHeight); -GetParent()->SetSizePixel(aParentSize); -setPosSizePixel(0, 0, aParentSize.Width(), aParentSize.Height()); +bool bChangeNeeded = false; +Size aParentSize = GetParent()->GetSizePixel(); + +if (mnMinimalHeight > 0 && (mnMinimalHeight != aParentSize.Height() || GetSizePixel().Height() != mnMinimalHeight)) +{ +aParentSize.setHeight(mnMinimalHeight); +bChangeNeeded = true; +} +if (mnMinimalWidth > 0 && (mnMinimalWidth != aParentSize.Width() || GetSizePixel().Width() != mnMinimalWidth) +&& comphelper::LibreOfficeKit::isMobile(SfxLokHelper::getView())) +{ +aParentSize.setWidth(mnMinimalWidth); +bChangeNeeded = true; +} + +if (bChangeNeeded) +{ +GetParent()->SetSizePixel(aParentSize); +setPosSizePixel(0, 0, aParentSize.Width(), aParentSize.Height()); +} +else if (aParentSize != GetSizePixel()) //Sync parent & child sizes +setPosSizePixel(0, 0, aParentSize.Width(), aParentSize.Height()); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 127243] Wunsch: zusätzliche Ansichtsauswahl Formatvorlagen "benuzterdefiniert"
https://bugs.documentfoundation.org/show_bug.cgi?id=127243 vistama...@web.de changed: What|Removed |Added Status|REOPENED|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127243] Wunsch: zusätzliche Ansichtsauswahl Formatvorlagen "benuzterdefiniert"
https://bugs.documentfoundation.org/show_bug.cgi?id=127243 vistama...@web.de changed: What|Removed |Added Resolution|WORKSFORME |--- Ever confirmed|0 |1 Status|RESOLVED|REOPENED --- Comment #2 from vistama...@web.de --- thank you for your check. You misunderstood! I do not want to show "userdefined formats", but to "userdefine the formats to show". in other word: What works fine already is, that I can display the formats I defined by myself. Contrary what I want is: I want to define the view of formats (e.g. H1, standard, myH1). Yes, I know, there are workarounds. But Microsoft had this feature since version 2003 without workaround. Libre Office can do this as well, can't we? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs