[Libreoffice-bugs] [Bug 128445] Reflected images: what I see in the slides list and in the work area does not correspond to what I see in the display mode.
https://bugs.documentfoundation.org/show_bug.cgi?id=128445 --- Comment #1 from Anna Baroni --- Created attachment 155382 --> https://bugs.documentfoundation.org/attachment.cgi?id=155382=edit The last slide shows the problem I have already explained. Even if the file is exported to pdf the problem remains -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128445] New: Reflected images: what I see in the slides list and in the work area does not correspond to what I see in the display mode.
https://bugs.documentfoundation.org/show_bug.cgi?id=128445 Bug ID: 128445 Summary: Reflected images: what I see in the slides list and in the work area does not correspond to what I see in the display mode. Product: LibreOffice Version: 6.2.5.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: anna-bar...@libero.it Description: I was preparing an exercise on symmetries for my students. I cut a photo along the horizontal and vertical axis of symmetry to get a module. Then I copied the form and reflected it (Reflect sidebar command) both horizontally and vertically, to "reconstruct" the starting image. Everything works perfectly in the work mode, but in presentation mode the reflected images are no longer visible. So what I see in the slides list and in the work area does not match what I see in the display mode (in the Presentation mode). Steps to Reproduce: 1.Crop a photo with many pixels. 2.Copy the cut image and use the reflect command to flip the image. 3.Repeat several times. Actual Results: In the work mode everything works but in Presentation mode some images disappear. Expected Results: Show in presentation mode the same things I see in work mode Reproducible: Sometimes User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser (error message: "Basic Syntax error. Expected: ).")
https://bugs.documentfoundation.org/show_bug.cgi?id=106529 --- Comment #59 from Mike Kaganski --- (In reply to Pierre C from comment #58) > Shouldn't this commit be activated in the master branch and reversed in all > the sub branches. Why? Which problems do you expect to prevent by that? Have you read and understood the part with "installed extensions and document with macros with the error would continue to work until edited in the IDE"? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113331] [META] PPT (binary) format bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=113331 Bug 113331 depends on bug 125191, which changed state. Bug 125191 Summary: If the presentation contains the same file names, the impress jumps between the slides https://bugs.documentfoundation.org/show_bug.cgi?id=125191 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128434] Memory leak when converting many documents
https://bugs.documentfoundation.org/show_bug.cgi?id=128434 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113453] Applying font replacement to a Word DOC document causes incorrect import and display of document, especially images are deleted
https://bugs.documentfoundation.org/show_bug.cgi?id=113453 --- Comment #6 from QA Administrators --- Dear Francisco, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124425] Crash in: ne_addr_resolve while tryed to copy in some text and a image from a confluence page
https://bugs.documentfoundation.org/show_bug.cgi?id=124425 --- Comment #2 from QA Administrators --- Dear lhpitn, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125004] Multiple Sheet Windows Open ABENDS
https://bugs.documentfoundation.org/show_bug.cgi?id=125004 --- Comment #3 from QA Administrators --- Dear Joe, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127834] LibreOffice Calc do not render interface on a display that is connected to secondary graphics card
https://bugs.documentfoundation.org/show_bug.cgi?id=127834 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116689] Crash in: _GSHandlerCheck_SEH
https://bugs.documentfoundation.org/show_bug.cgi?id=116689 --- Comment #16 from QA Administrators --- Dear Clemens Prill, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82396] Sidebar: Incorrect behavior regarding real-time update of spinbox values
https://bugs.documentfoundation.org/show_bug.cgi?id=82396 --- Comment #18 from QA Administrators --- Dear freddi34, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127834] LibreOffice Calc do not render interface on a display that is connected to secondary graphics card
https://bugs.documentfoundation.org/show_bug.cgi?id=127834 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128128] Can not set "none" (Transparent) to shape area fill on Background objects style
https://bugs.documentfoundation.org/show_bug.cgi?id=128128 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84427] FILESAVE: Video files not saved in DOC or DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=84427 --- Comment #4 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103615] Macro with ShareDocument dispatch command -> no functionnality
https://bugs.documentfoundation.org/show_bug.cgi?id=103615 --- Comment #4 from QA Administrators --- Dear ThierryT, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82226] FORMATTING: Row Height Optimization Should Not Adjust with Deleting Content + Auto Row Height Does not Readjust with Undo
https://bugs.documentfoundation.org/show_bug.cgi?id=82226 --- Comment #23 from QA Administrators --- Dear Adam Niedling, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81636] Not possible to view two formulas at the same time in different Calc instances
https://bugs.documentfoundation.org/show_bug.cgi?id=81636 --- Comment #16 from QA Administrators --- Dear werru, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116815] Remove "Master Elements" from Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=116815 --- Comment #5 from QA Administrators --- Dear Regina Henschel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112587] Slideshow Animation Timings Ignored on Slower PC
https://bugs.documentfoundation.org/show_bug.cgi?id=112587 --- Comment #14 from QA Administrators --- Dear Luke, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100632] SIDEBAR, FILEOPEN: Certain Position & Size fields in Sidebar are not filled for this SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=100632 --- Comment #9 from QA Administrators --- Dear Aron Budea, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120979] File statistics: wrong number of lines
https://bugs.documentfoundation.org/show_bug.cgi?id=120979 --- Comment #2 from QA Administrators --- Dear Dieter Praas, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 34355] Option to show track changes in margin is missing
https://bugs.documentfoundation.org/show_bug.cgi?id=34355 --- Comment #84 from mohit08 --- Mohit Lyrics | Latest Songs Lyrics,Top Songs Lyrics, mohit lyrics, Find songs by lyrics, mohitlyrics is a searchable lyrics database featuring many song lyrics from very much artists. Use mohitlyrics to find your favorite song lyrics. Latest Hindi Songs Lyrics https://www.mohitlyrics.com/;>Mohit Lyrics | Latest Song Lyrics thanks -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 120076] Running "soffice .uno:Open" causes a crash, if CollectUsageInformation is set to true
https://bugs.documentfoundation.org/show_bug.cgi?id=120076 --- Comment #6 from Matt Perry --- Still present. Version: 6.3.2.2 (x64) Build ID: 98b30e735bda24bc04ab42594c85f7fd8be07b9c CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; Locale: en-US (en_US); UI-Language: en-US -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] help.git: Package_html_media.mk source/media source/text
Package_html_media.mk |4 source/media/screenshots/cui/ui/hyperlinknewdocpage/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/af/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/am/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/ar/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/as/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/ast/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/be/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/bg/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/bn-IN/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/bn/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/bo/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/br/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/brx/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/bs/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/ca-valencia/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/ca/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/cs/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/cy/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/da/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/de/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/dgo/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/dsb/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/dz/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/el/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/en-GB/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/en-ZA/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/eo/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/es/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/et/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/eu/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/fa/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/fi/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/fr/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/fy/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/ga/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/gd/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/gl/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/gu/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/gug/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/he/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/hi/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/hr/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/hsb/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/hu/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/id/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/is/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/it/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/ja/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/ka/HyperlinkNewDocPage.png |binary source/media/screenshots/cui/ui/hyperlinknewdocpage/kab/HyperlinkNewDocPage.png
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 857c9193615574539e21e4b58069e4f4a905ac02 Author: Olivier Hallot AuthorDate: Mon Oct 28 23:19:56 2019 -0300 Commit: Gerrit Code Review CommitDate: Tue Oct 29 03:21:53 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' - Add screenshot for New Doc hyperlink help page Use kde5 breeze theme Change-Id: Ida64f6ea49f5f381ae61aa52195a592138d7636e Reviewed-on: https://gerrit.libreoffice.org/81633 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 2342e79f1a7f..ae2945ec0d27 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 2342e79f1a7f468098da0a32912a7bbf1d556a01 +Subproject commit ae2945ec0d27a1ba10672f8dc89c86687fbbeb9c ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
LibreOffice build dependencies souce URI for Ubuntu (latest) ?
Hi, Following this https://wiki.documentfoundation.org/Development/Linux_Build_Dependencies with #2, adding deb-src http://archive.ubuntu.com/ubuntu/ distroname main to /apt/etc/sources.list then apt-get update gives an error Err:7 http://archive.ubuntu.com/ubuntu distroname Release 404 Not Found [IP: 2001:67c:1360:8001::21 80] And without that line (obviously) sudo apt-get build-dep libreoffice reports the missing source URI.. Asking here since obviously I can't find how the " .. should look something like these:" from our wiki should be precisely. Thanks! Cor -- Cor Nouws GPD key ID: 0xB13480A6 - 591A 30A7 36A0 CE3C 3D28 A038 E49D 7365 B134 80A6 - vrijwilliger https://nl.libreoffice.org - volunteer https://www.libreoffice.org - Member Board The Document Foundation - http://www.nouenoff.nl / https://www.mijncloudoffice.nl ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 128444] New: Crash in: sal3.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=128444 Bug ID: 128444 Summary: Crash in: sal3.dll Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: judylaws...@gmail.com This bug was filed from the crash reporting server and is br-7f5a672a-1239-418a-9391-afebe7a4446c. = I think just 6.3 do not know the alpha or beta. It happened while I was attemoting to number the forepapers. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122902] Impress hangs for a while when opening or saving a document. FILEOPEN FILESAVE
https://bugs.documentfoundation.org/show_bug.cgi?id=122902 Clay Spence changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #18 from Clay Spence --- Yes, it still happens. Additional detail: I downloaded and unpacked https://dev-builds.libreoffice.org/daily/master/Linux-archive-x86_64@80-updater/2019-10-28_01.24.31/LibreOfficeDev_6.4.0.0.alpha1_Linux_x86-64_archive.tar.gz. I cd'd to the program subdirectory, set PATH to that and usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin, and ran ./soffice. It has the same pauses of about 50 seconds on opening, clicking in a text field, saving, and quitting. The pause doesn't happen if I run "SAL_USE_VCLPLUGIN=gen ./soffice" instead. If anything, the problem may be worse. *Sometimes* it seems to just hang the whole computer. When this happens, I can't Ctrl-Alt-F to a terminal. Clicking outside the window does nothing. The mouse cursor moves with the mouse, but it doesn't change appearance when passing over different things. This has happened twice, and lasted at least 5 minutes, when I did a hard reboot. BTW, since my last comment I wiped my hard drive and installed Lubuntu from scratch. (I apologize for not responding earlier.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/layer/tile/TileLayer.js |1 +
loleaflet/src/map/Map.js |1 +
2 files changed, 2 insertions(+)
New commits:
commit 1cf79e639f8aad8e9916e9c0dc680624c459e3f1
Author: Ashod Nakashian
AuthorDate: Mon Nov 12 23:04:57 2018 -0500
Commit: Ashod Nakashian
CommitDate: Tue Oct 29 02:40:55 2019 +0100
leaflet: initialize before use
(cherry picked from commit 1fe1d765dfe8a7ff3fb89ecf437afccbea684d71)
Change-Id: Ib8eee6e50092950016ebb889f7dbe10674e9cbc7
Reviewed-on: https://gerrit.libreoffice.org/81580
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/loleaflet/src/layer/tile/TileLayer.js
b/loleaflet/src/layer/tile/TileLayer.js
index fc4c8d581..d7bdd4e75 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -199,6 +199,7 @@ L.TileLayer = L.GridLayer.extend({
this._getToolbarCommandsValues();
this._selections = new L.LayerGroup();
this._references = new L.LayerGroup();
+ this._referencesAll = [];
if (this.options.permission !== 'readonly') {
map.addLayer(this._selections);
map.addLayer(this._references);
diff --git a/loleaflet/src/map/Map.js b/loleaflet/src/map/Map.js
index b4fc79082..9e4163cea 100644
--- a/loleaflet/src/map/Map.js
+++ b/loleaflet/src/map/Map.js
@@ -109,6 +109,7 @@ L.Map = L.Evented.extend({
this._helpTarget = null; // help page that fits best the
current context
this._disableDefaultAction = {}; // The events for which the
default handler is disabled and only issues postMessage.
this._winId = 0;
+ this._activeDialog = null;
vex.dialogID = -1;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: test/TileCacheTests.cpp
test/TileCacheTests.cpp | 37 +++--
1 file changed, 23 insertions(+), 14 deletions(-)
New commits:
commit 0106ab24f646ff28e463679bf2c540c6bcfacebf
Author: Ashod Nakashian
AuthorDate: Sat Oct 26 10:11:35 2019 -0400
Commit: Ashod Nakashian
CommitDate: Tue Oct 29 02:40:34 2019 +0100
test: improve TileCacheTests::testUnresponsiveClient
Change-Id: Ib08c4675c9477cb925b5d42545cdc2cdae780fbe
Reviewed-on: https://gerrit.libreoffice.org/81579
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/test/TileCacheTests.cpp b/test/TileCacheTests.cpp
index 913d777fc..f9d94c6e1 100644
--- a/test/TileCacheTests.cpp
+++ b/test/TileCacheTests.cpp
@@ -430,20 +430,22 @@ void TileCacheTests::testDisconnectMultiView()
void TileCacheTests::testUnresponsiveClient()
{
-const char* testname = "testUnresponsiveClient";
+const std::string testname = "unresponsiveClient-";
+
std::string documentPath, documentURL;
-getDocumentPathAndURL("hello.odt", documentPath, documentURL,
"unresponsiveClient ");
+getDocumentPathAndURL("hello.odt", documentPath, documentURL, testname);
TST_LOG("Connecting first client.");
-std::shared_ptr socket1 = loadDocAndGetSocket(_uri,
documentURL, "unresponsiveClient-1 ");
+std::shared_ptr socket1
+= loadDocAndGetSocket(_uri, documentURL, testname + "1 ");
TST_LOG("Connecting second client.");
-std::shared_ptr socket2 = loadDocAndGetSocket(_uri,
documentURL, "unresponsiveClient-2 ");
+std::shared_ptr socket2
+= loadDocAndGetSocket(_uri, documentURL, testname + "2 ");
// Pathologically request tiles and fail to read (say slow connection).
// Meanwhile, verify that others can get all tiles fine.
// TODO: Track memory consumption to verify we don't buffer too much.
-
std::ostringstream oss;
for (int i = 0; i < 1000; ++i)
{
@@ -454,24 +456,31 @@ void TileCacheTests::testUnresponsiveClient()
for (int x = 0; x < 8; ++x)
{
// Invalidate to force re-rendering.
-sendTextFrame(socket2, "uno .uno:SelectAll");
-sendTextFrame(socket2, "uno .uno:Delete");
-assertResponseString(socket2, "invalidatetiles:", "client2 ");
-sendTextFrame(socket2, "paste mimetype=text/html\n" +
documentContents);
-assertResponseString(socket2, "invalidatetiles:", "client2 ");
+deleteAll(socket2, testname);
+assertResponseString(socket2, "invalidatetiles:", testname + "2 ");
+sendTextFrame(socket2, "paste mimetype=text/html\n" +
documentContents, testname + "2 ");
+assertResponseString(socket2, "invalidatetiles:", testname + "2 ");
// Ask for tiles and don't read!
-sendTextFrame(socket1, "tilecombine nviewid=0 part=0 width=256
height=256 tileposx=0,3840,7680,11520,0,3840,7680,11520
tileposy=0,0,0,0,3840,3840,3840,3840 tilewidth=3840 tileheight=3840");
+sendTextFrame(socket1, "tilecombine nviewid=0 part=0 width=256
height=256 "
+ "tileposx=0,3840,7680,11520,0,3840,7680,11520 "
+ "tileposy=0,0,0,0,3840,3840,3840,3840
tilewidth=3840 "
+ "tileheight=3840",
+ testname + "1 ");
// Verify that we get all 8 tiles.
-sendTextFrame(socket2, "tilecombine nviewid=0 part=0 width=256
height=256 tileposx=0,3840,7680,11520,0,3840,7680,11520
tileposy=0,0,0,0,3840,3840,3840,3840 tilewidth=3840 tileheight=3840");
+sendTextFrame(socket2, "tilecombine nviewid=0 part=0 width=256
height=256 "
+ "tileposx=0,3840,7680,11520,0,3840,7680,11520 "
+ "tileposy=0,0,0,0,3840,3840,3840,3840
tilewidth=3840 "
+ "tileheight=3840",
+ testname + "2 ");
for (int i = 0; i < 8; ++i)
{
-std::vector tile = getResponseMessage(socket2, "tile:",
"client2 ");
+std::vector tile = getResponseMessage(socket2, "tile:",
testname + "2 ");
CPPUNIT_ASSERT_MESSAGE("Did not receive tile #" +
std::to_string(i+1) + " of 8: message as expected", !tile.empty());
}
/// Send canceltiles message to clear tiles-on-fly list, otherwise wsd
waits for tileprocessed messages
-sendTextFrame(socket2, "canceltiles");
+sendTextFrame(socket2, "canceltiles", testname + "2 ");
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: common/Util.cpp common/Util.hpp test/WhiteBoxTests.cpp
common/Util.cpp| 44 +--
common/Util.hpp|3 ++
test/WhiteBoxTests.cpp | 50 ++---
3 files changed, 72 insertions(+), 25 deletions(-)
New commits:
commit d038ceb118bc56f8390dd959cb94c860ef25
Author: Ashod Nakashian
AuthorDate: Fri Oct 25 20:48:05 2019 -0400
Commit: Ashod Nakashian
CommitDate: Tue Oct 29 02:39:34 2019 +0100
test: Improve iso8601ToTimestamp and tests
Using double caused all sorts of rounding issues,
especially with random unit-test failures.
Luckily, we don't need doubles and can do everything
with integers.
Also added a new function to print time_point as
iso8601 string, for logging and convenience.
Change-Id: I1c2040c02d1143282dbde0dadef32613b77c330d
Reviewed-on: https://gerrit.libreoffice.org/81578
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/common/Util.cpp b/common/Util.cpp
index 3ceb2378a..49d465035 100644
--- a/common/Util.cpp
+++ b/common/Util.cpp
@@ -25,7 +25,6 @@
#include
#include
#include
-#include
#include
#include
@@ -33,6 +32,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -836,31 +836,55 @@ namespace Util
return oss.str();
}
-std::chrono::system_clock::time_point iso8601ToTimestamp(const
std::string& iso8601Time, const std::string& logName)
+std::string time_point_to_iso8601(std::chrono::system_clock::time_point tp)
+{
+const std::time_t tt = std::chrono::system_clock::to_time_t(tp);
+std::tm tm;
+gmtime_r(, );
+
+std::ostringstream oss;
+oss << tm.tm_year + 1900 << '-' << std::setfill('0') << std::setw(2)
<< tm.tm_mon + 1 << '-'
+<< std::setfill('0') << std::setw(2) << tm.tm_mday << 'T';
+oss << std::setfill('0') << std::setw(2) << tm.tm_hour << ':';
+oss << std::setfill('0') << std::setw(2) << tm.tm_min << ':';
+const std::chrono::duration sec
+= tp - std::chrono::system_clock::from_time_t(tt) +
std::chrono::seconds(tm.tm_sec);
+if (sec.count() < 10)
+oss << '0';
+oss << std::fixed << sec.count() << 'Z';
+
+return oss.str();
+}
+
+std::chrono::system_clock::time_point iso8601ToTimestamp(const
std::string& iso8601Time,
+ const
std::string& logName)
{
std::chrono::system_clock::time_point timestamp;
std::tm tm;
-const char *cstr = iso8601Time.c_str();
-const char *trailing;
+const char* cstr = iso8601Time.c_str();
+const char* trailing;
if (!(trailing = strptime(cstr, "%Y-%m-%dT%H:%M:%S", )))
{
LOG_WRN(logName << " [" << iso8601Time << "] is in invalid format."
-<< "Returning " << timestamp.time_since_epoch().count());
+<< "Returning " <<
timestamp.time_since_epoch().count());
return timestamp;
}
+
timestamp += std::chrono::seconds(timegm());
if (trailing[0] == '\0')
return timestamp;
-double us;
+
if (trailing[0] != '.')
{
LOG_WRN(logName << " [" << iso8601Time << "] is in invalid format."
-<< ". Returning " << timestamp.time_since_epoch().count());
+<< ". Returning " <<
timestamp.time_since_epoch().count());
return timestamp;
}
-char *end = nullptr;
-us = strtod(trailing, );
-std::size_t seconds_us = us * std::chrono::system_clock::period::den /
std::chrono::system_clock::period::num;
+
+char* end = nullptr;
+const size_t us = strtoul(trailing + 1, , 10); // Skip the '.' and
read as integer.
+const std::size_t seconds_us = us *
std::chrono::system_clock::period::den
+ /
std::chrono::system_clock::period::num / 100;
timestamp += std::chrono::system_clock::duration(seconds_us);
diff --git a/common/Util.hpp b/common/Util.hpp
index d345950ba..82389c1ab 100644
--- a/common/Util.hpp
+++ b/common/Util.hpp
@@ -935,6 +935,9 @@ int main(int argc, char**argv)
Return time in ISO8061 fraction format
std::string getIso8601FracformatTime(std::chrono::system_clock::time_point
time);
+/// Convert a time_point to iso8601 formatted string.
+std::string time_point_to_iso8601(std::chrono::system_clock::time_point
tp);
+
Convert time from ISO8061 fraction format
std::chrono::system_clock::time_point iso8601ToTimestamp(const
std::string& iso8601Time, const std::string& logName);
diff --git a/test/WhiteBoxTests.cpp b/test/WhiteBoxTests.cpp
index 597adb500..219c3ccf2 100644
--- a/test/WhiteBoxTests.cpp
+++ b/test/WhiteBoxTests.cpp
@@ -738,37 +738,57 @@ void WhiteBoxTests::testTime()
{
[Libreoffice-commits] online.git: common/Log.cpp
common/Log.cpp |1 +
1 file changed, 1 insertion(+)
New commits:
commit 56b49b50004cd3577b99ab7a65f7e8c834cd421f
Author: Ashod Nakashian
AuthorDate: Tue Oct 22 10:30:48 2019 -0400
Commit: Ashod Nakashian
CommitDate: Tue Oct 29 02:36:08 2019 +0100
wsd: warning logging on the console is now magenta for visibility
Change-Id: I8756a0c38d529495826131a3d2dcd1ab70d8c289
Reviewed-on: https://gerrit.libreoffice.org/81337
Reviewed-by: Andras Timar
Tested-by: Andras Timar
(cherry picked from commit 7c325c0fb32951dfc8786df98d72e72c92443088)
Reviewed-on: https://gerrit.libreoffice.org/81577
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/common/Log.cpp b/common/Log.cpp
index 00d047e86..cdb72a903 100644
--- a/common/Log.cpp
+++ b/common/Log.cpp
@@ -177,6 +177,7 @@ namespace Log
{
channel = static_cast(new
Poco::ColorConsoleChannel());
channel->setProperty("traceColor", "green");
+channel->setProperty("warningColor", "magenta");
}
else
channel = static_cast(new Poco::ConsoleChannel());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: test/httpwstest.cpp test/TileCacheTests.cpp
test/TileCacheTests.cpp | 47 +--
test/httpwstest.cpp | 18 +-
2 files changed, 42 insertions(+), 23 deletions(-)
New commits:
commit c82760f1037c6019a0b03463405ec12669ad4f6a
Author: Ashod Nakashian
AuthorDate: Mon Oct 21 11:42:03 2019 -0400
Commit: Ashod Nakashian
CommitDate: Tue Oct 29 02:32:54 2019 +0100
test: improve TileCache tests
This fixes up some minor issues, improves stability
and logging of tests.
Reviewed-on: https://gerrit.libreoffice.org/81259
Reviewed-by: Andras Timar
Tested-by: Andras Timar
(cherry picked from commit a6e2dff35a4f1234066c66cb64f7e3bcd034ed58)
Change-Id: I906922c1c74427a53f9017f7be73c1f85ecf4cd7
Reviewed-on: https://gerrit.libreoffice.org/81575
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/test/TileCacheTests.cpp b/test/TileCacheTests.cpp
index 396b0e031..913d777fc 100644
--- a/test/TileCacheTests.cpp
+++ b/test/TileCacheTests.cpp
@@ -128,6 +128,7 @@ class TileCacheTests : public CPPUNIT_NS::TestFixture
const std::string& name = "checkTiles ");
void requestTiles(std::shared_ptr& socket,
+ const std::string& docType,
const int part,
const int docWidth,
const int docHeight,
@@ -1079,10 +1080,18 @@ void
TileCacheTests::checkTiles(std::shared_ptr& socket, const st
Poco::StringTokenizer tokens(line, " ",
Poco::StringTokenizer::TOK_IGNORE_EMPTY | Poco::StringTokenizer::TOK_TRIM);
#if defined CPPUNIT_ASSERT_GREATEREQUAL
-CPPUNIT_ASSERT_GREATEREQUAL(static_cast(6), tokens.count());
+if (docType == "presentation")
+CPPUNIT_ASSERT_GREATEREQUAL(static_cast(7),
tokens.count()); // We have an extra field.
+else
+CPPUNIT_ASSERT_GREATEREQUAL(static_cast(6),
tokens.count());
+#else
+if (docType == "presentation")
+CPPUNIT_ASSERT_EQUAL(static_cast(7), tokens.count()); //
We have an extra field.
+else
+CPPUNIT_ASSERT_EQUAL(static_cast(6), tokens.count());
#endif
-// Expected format is something like 'type= parts= current= width=
height= [hiddenparts=]'.
+// Expected format is something like 'type= parts= current= width=
height='.
const std::string text = tokens[0].substr(type.size());
totalParts = std::stoi(tokens[1].substr(parts.size()));
currentPart = std::stoi(tokens[2].substr(current.size()));
@@ -1099,7 +1108,7 @@ void
TileCacheTests::checkTiles(std::shared_ptr& socket, const st
{
// request tiles
TST_LOG("Requesting Impress tiles.");
-requestTiles(socket, currentPart, docWidth, docHeight, name);
+requestTiles(socket, docType, currentPart, docWidth, docHeight, name);
}
// random setclientpart
@@ -1119,7 +1128,7 @@ void
TileCacheTests::checkTiles(std::shared_ptr& socket, const st
// issue a new tile request as a response, which a real client
would do).
assertResponseString(socket, "setpart:", name);
-requestTiles(socket, it, docWidth, docHeight, name);
+requestTiles(socket, docType, it, docWidth, docHeight, name);
if (++requests >= 3)
{
@@ -1132,7 +1141,9 @@ void
TileCacheTests::checkTiles(std::shared_ptr& socket, const st
}
}
-void TileCacheTests::requestTiles(std::shared_ptr& socket,
const int part, const int docWidth, const int docHeight, const std::string&
name)
+void TileCacheTests::requestTiles(std::shared_ptr& socket,
+ const std::string& , const int part, const
int docWidth,
+ const int docHeight, const std::string& name)
{
// twips
const int tileSize = 3840;
@@ -1176,7 +1187,7 @@ void
TileCacheTests::requestTiles(std::shared_ptr& socket, const
sendTextFrame(socket, text, name);
tile = assertResponseString(socket, "tile:", name);
-// expected tile: nviewid= part= width= height= tileposx=
tileposy= tilewidth= tileheight=
+// expected tile: part= width= height= tileposx= tileposy=
tilewidth= tileheight=
Poco::StringTokenizer tokens(tile, " ",
Poco::StringTokenizer::TOK_IGNORE_EMPTY | Poco::StringTokenizer::TOK_TRIM);
CPPUNIT_ASSERT_EQUAL(std::string("tile:"), tokens[0]);
CPPUNIT_ASSERT_EQUAL(0,
std::stoi(tokens[1].substr(std::string("nviewid=").size(;
@@ -1273,9 +1284,9 @@ void TileCacheTests::testTileWireIDHandling()
CPPUNIT_ASSERT_MESSAGE("Expected at least two tiles.",
countMessages(socket, "tile:", testname, 500) > 1);
// Let WSD know we got these so it wouldn't stop sending us modified tiles
automatically.
-sendTextFrame(socket, "tileprocessed tile=0:0:0:3840:3840:0");
-sendTextFrame(socket, "tileprocessed
[Libreoffice-commits] online.git: 2 commits - net/Socket.cpp test/httpwstest.cpp test/integration-http-server.cpp wsd/LOOLWSD.cpp
net/Socket.cpp |2 +-
test/httpwstest.cpp | 14 +++---
test/integration-http-server.cpp | 36 ++--
wsd/LOOLWSD.cpp | 26 ++
4 files changed, 52 insertions(+), 26 deletions(-)
New commits:
commit c3632491a47f0fe7d0cac435caad213eff6218c1
Author: Ashod Nakashian
AuthorDate: Mon Oct 21 00:48:51 2019 -0400
Commit: Ashod Nakashian
CommitDate: Tue Oct 29 02:32:35 2019 +0100
test: improve HTTPServerTest::testConvertToWithForwardedClientIP
Extend the timeout, as often DNS lookup takes several seconds
and that delays the response from WSD.
Reviewed-on: https://gerrit.libreoffice.org/81198
Reviewed-by: Andras Timar
Tested-by: Andras Timar
(cherry picked from commit ae085428dfb11b7965b73df0f40ac4fd1ec98a75)
Change-Id: Ie51bff31782fa33eb5559d28af1477e1947382a3
Reviewed-on: https://gerrit.libreoffice.org/81574
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/net/Socket.cpp b/net/Socket.cpp
index cf7087170..cbe5a0a52 100644
--- a/net/Socket.cpp
+++ b/net/Socket.cpp
@@ -785,7 +785,7 @@ bool StreamSocket::parseHeader(const char *clientName,
}
catch (const std::exception& exc)
{
-LOG_DBG("parseHeader exception caught.");
+LOG_DBG("parseHeader exception caught: " << exc.what());
// Probably don't have enough data just yet.
// TODO: timeout if we never get enough.
return false;
diff --git a/test/integration-http-server.cpp b/test/integration-http-server.cpp
index 8f36c8205..cf4efcdb4 100644
--- a/test/integration-http-server.cpp
+++ b/test/integration-http-server.cpp
@@ -370,11 +370,17 @@ void HTTPServerTest::testConvertTo()
void HTTPServerTest::testConvertToWithForwardedClientIP()
{
+const std::string testname = "convertToWithForwardedClientIP-";
+constexpr int TimeoutSeconds = 10; // Sometimes dns resolving is slow.
+
// Test a forwarded IP which is not allowed to use convert-to feature
+try
{
-const std::string srcPath = FileUtil::getTempFilePath(TDOC,
"hello.odt", "testConvertToWithForwardedClientIP_");
+TST_LOG("Converting from a disallowed IP.");
+
+const std::string srcPath = FileUtil::getTempFilePath(TDOC,
"hello.odt", testname + "disallowed");
std::unique_ptr
session(helpers::createSession(_uri));
-session->setTimeout(Poco::Timespan(2, 0)); // 2 seconds.
+session->setTimeout(Poco::Timespan(TimeoutSeconds, 0));
Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_POST,
"/lool/convert-to");
CPPUNIT_ASSERT(!request.has("X-Forwarded-For"));
@@ -406,12 +412,19 @@ void HTTPServerTest::testConvertToWithForwardedClientIP()
std::string actualString = actualStream.str();
CPPUNIT_ASSERT(actualString.empty()); // <- we did not get the
converted file
}
+catch(const Poco::Exception& exc)
+{
+CPPUNIT_FAIL(exc.displayText() + ": " + (exc.nested() ?
exc.nested()->displayText() : ""));
+}
// Test a forwarded IP which is allowed to use convert-to feature
+try
{
-const std::string srcPath = FileUtil::getTempFilePath(TDOC,
"hello.odt", "testConvertToWithForwardedClientIP_");
+TST_LOG("Converting from an allowed IP.");
+
+const std::string srcPath = FileUtil::getTempFilePath(TDOC,
"hello.odt", testname + "allowed");
std::unique_ptr
session(helpers::createSession(_uri));
-session->setTimeout(Poco::Timespan(2, 0)); // 2 seconds.
+session->setTimeout(Poco::Timespan(TimeoutSeconds, 0));
Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_POST,
"/lool/convert-to");
CPPUNIT_ASSERT(!request.has("X-Forwarded-For"));
@@ -442,12 +455,19 @@ void HTTPServerTest::testConvertToWithForwardedClientIP()
actualString = actualString.substr(3);
CPPUNIT_ASSERT_EQUAL(expectedStream.str(), actualString); // <- we got
the converted file
}
+catch(const Poco::Exception& exc)
+{
+CPPUNIT_FAIL(exc.displayText() + ": " + (exc.nested() ?
exc.nested()->displayText() : ""));
+}
// Test a forwarded header with three IPs, one is not allowed -> request
is denied.
+try
{
-const std::string srcPath = FileUtil::getTempFilePath(TDOC,
"hello.odt", "testConvertToWithForwardedClientIP_");
+TST_LOG("Converting from multiple IPs, on disallowed.");
+
+const std::string srcPath = FileUtil::getTempFilePath(TDOC,
"hello.odt", testname + "disallowed-multi");
std::unique_ptr
session(helpers::createSession(_uri));
-session->setTimeout(Poco::Timespan(2, 0)); // 2 seconds.
+session->setTimeout(Poco::Timespan(TimeoutSeconds, 0));
Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_POST,
"/lool/convert-to");
[Libreoffice-commits] online.git: common/Png.hpp kit/Kit.cpp test/helpers.hpp test/TileCacheTests.cpp
common/Png.hpp |2
kit/Kit.cpp |5 +
test/TileCacheTests.cpp | 129
test/helpers.hpp| 20 +++
4 files changed, 78 insertions(+), 78 deletions(-)
New commits:
commit d110f4cc589c0c655d29215e3e5362d60ae6712e
Author: Ashod Nakashian
AuthorDate: Sat Oct 19 12:33:22 2019 -0400
Commit: Ashod Nakashian
CommitDate: Tue Oct 29 02:32:05 2019 +0100
test: improve TileCacheTests
Sometimes core renderes with sub-pixel differences
(the crosshair at the corners of the Writer pages
show line anti-aliasing differences). This causes
failure of the tests that count the tile deduplication.
We now tolerate when we get an unchanged tile twice,
assuming it was due to such a rendering difference,
but we re-trigger another change and this time we
don't expect any extra tiles, no more than two
variations of the anti-aliased crosshair was
observed.
We also move some duplicate code into utility
functions to improve readability and reuse.
Reviewed-on: https://gerrit.libreoffice.org/81196
Reviewed-by: Andras Timar
Tested-by: Andras Timar
(cherry picked from commit 9603597fd1aaecb27893792cfd2d243e450b58b8)
Change-Id: I1a66732dd3443bfbd770d8dc65721571dfa08615
Reviewed-on: https://gerrit.libreoffice.org/81572
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/common/Png.hpp b/common/Png.hpp
index d629158c2..c0a99c74e 100644
--- a/common/Png.hpp
+++ b/common/Png.hpp
@@ -212,7 +212,7 @@ inline bool encodeSubBufferToPNG(unsigned char* pixmap,
size_t startX, size_t st
++nCalls;
LOG_TRC("PNG compression took "
<< duration << " ms (" << output.size() << " bytes). Average
after " << nCalls
-<< " calls: " << (totalDuration /
static_cast(nCalls)));
+<< " calls: " << (totalDuration / static_cast(nCalls))
<< " ms.");
}
return res;
diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index d6d255bf1..9eac5dc7e 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -500,8 +500,8 @@ public:
}
}
-LOG_DBG("PNG cache has " << _cache.size() << " items, total size "
<<
-_cacheSize << " after balance.");
+LOG_DBG("PNG cache has " << _cache.size() << " items with total
size of " <<
+_cacheSize << " bytes after balance.");
}
if (_hashToWireId.size() > CacheWidHardLimit)
@@ -541,6 +541,7 @@ public:
}
}
+LOG_DBG("PNG cache with hash " << hash << " missed.");
return false;
}
diff --git a/test/TileCacheTests.cpp b/test/TileCacheTests.cpp
index 174f3d5bb..396b0e031 100644
--- a/test/TileCacheTests.cpp
+++ b/test/TileCacheTests.cpp
@@ -1270,34 +1270,31 @@ void TileCacheTests::testTileWireIDHandling()
assertResponseString(socket, "invalidatetiles:", testname);
// For the first input wsd will send all invalidated tiles
-int arrivedTiles = 0;
-bool gotTile = false;
-do
-{
-// If we wait for too long, the cached tiles will get evicted.
-std::vector tile = getResponseMessage(socket, "tile:", testname,
500);
-gotTile = !tile.empty();
-if(gotTile)
-++arrivedTiles;
-} while(gotTile);
+CPPUNIT_ASSERT_MESSAGE("Expected at least two tiles.",
countMessages(socket, "tile:", testname, 500) > 1);
-CPPUNIT_ASSERT_MESSAGE("We expect two tiles at least!", arrivedTiles > 1);
+// Let WSD know we got these so it wouldn't stop sending us modified tiles
automatically.
+sendTextFrame(socket, "tileprocessed tile=0:0:0:3840:3840:0");
+sendTextFrame(socket, "tileprocessed tile=0:3840:0:3840:3840:0");
+sendTextFrame(socket, "tileprocessed tile=0:7680:0:3840:3840:0");
// Type an other character
-sendChar(socket, 'x', skNone, testname);
+sendChar(socket, 'y', skNone, testname);
assertResponseString(socket, "invalidatetiles:", testname);
-// For the second input wsd will send one tile, since some of them are
identical
-arrivedTiles = 0;
-do
-{
-std::vector tile = getResponseMessage(socket, "tile:", testname);
-gotTile = !tile.empty();
-if(gotTile)
-++arrivedTiles;
-} while(gotTile);
+// For the second input wsd will send one tile, since some of them are
identical.
+const int arrivedTiles = countMessages(socket, "tile:", testname, 500);
+if (arrivedTiles == 1)
+return;
-CPPUNIT_ASSERT_EQUAL(1, arrivedTiles);
+// Or, at most 2. The reason is that sometimes we get line antialiasing
differences that
+// are sub-pixel different, and that results in a different hash.
+CPPUNIT_ASSERT_EQUAL(2, arrivedTiles);
+
+// The third time, however, we shouldn't see anything but the tile we
change.
+sendChar(socket, 'z', skNone,
[Libreoffice-commits] online.git: test/helpers.hpp test/httpwstest.cpp
test/helpers.hpp| 16 +++-
test/httpwstest.cpp |7 ---
2 files changed, 15 insertions(+), 8 deletions(-)
New commits:
commit d6306c5388b3d4bf964463020fd2c68898b54b0a
Author: Ashod Nakashian
AuthorDate: Sat Oct 19 12:32:43 2019 -0400
Commit: Ashod Nakashian
CommitDate: Tue Oct 29 02:31:01 2019 +0100
test: improve getAllText to match an expected payload
Change-Id: I4159f1e21f581ccdf90bcacf489580c8887931e5
Reviewed-on: https://gerrit.libreoffice.org/81195
Reviewed-by: Andras Timar
Tested-by: Andras Timar
(cherry picked from commit 9903229918d07eee2f6c1ad22ee5a287f4fd0884)
Reviewed-on: https://gerrit.libreoffice.org/81571
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/test/helpers.hpp b/test/helpers.hpp
index 30d20d3d8..6084e3337 100644
--- a/test/helpers.hpp
+++ b/test/helpers.hpp
@@ -729,20 +729,26 @@ inline void deleteAll(const
std::shared_ptr& socket, const std::s
}
inline std::string getAllText(const std::shared_ptr& socket,
- const std::string& testname, int retry =
COMMAND_RETRY_COUNT)
+ const std::string& testname,
+ const std::string expected = std::string(),
+ int retry = COMMAND_RETRY_COUNT)
{
-std::string text;
+static const std::string prefix = "textselectioncontent: ";
+
for (int i = 0; i < retry; ++i)
{
selectAll(socket, testname);
sendTextFrame(socket, "gettextselection
mimetype=text/plain;charset=utf-8", testname);
-text = assertResponseString(socket, "textselectioncontent:", testname);
+const std::string text = getResponseString(socket, prefix, testname);
if (!text.empty())
-break;
+{
+if (expected.empty() || (prefix + expected) == text)
+return text;
+}
}
-return text;
+return std::string();
}
}
diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index d9a4727cf..a6e2c2f59 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -515,8 +515,9 @@ void HTTPWSTest::testGetTextSelection()
std::shared_ptr socket = loadDocAndGetSocket(_uri,
documentURL, testname);
std::shared_ptr socket2 = loadDocAndGetSocket(_uri,
documentURL, testname);
-const std::string selection = getAllText(socket, testname);
-CPPUNIT_ASSERT_EQUAL(std::string("textselectioncontent: Hello world"),
selection);
+static const std::string expected = "Hello world";
+const std::string selection = getAllText(socket, testname, expected);
+CPPUNIT_ASSERT_EQUAL("textselectioncontent: " + expected, selection);
}
catch (const Poco::Exception& exc)
{
@@ -580,7 +581,7 @@ void HTTPWSTest::testSaveOnDisconnect()
CPPUNIT_ASSERT_EQUAL(kitcount, countLoolKitProcesses(kitcount));
// Check if the document contains the pasted text.
-const std::string selection = getAllText(socket, testname);
+const std::string selection = getAllText(socket, testname, text);
CPPUNIT_ASSERT_EQUAL("textselectioncontent: " + text, selection);
}
catch (const Poco::Exception& exc)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: common/Common.hpp wsd/DocumentBroker.cpp wsd/LOOLWSD.cpp
common/Common.hpp |2 +-
wsd/DocumentBroker.cpp |8 +++-
wsd/LOOLWSD.cpp| 16
3 files changed, 20 insertions(+), 6 deletions(-)
New commits:
commit 0b9bc008178659470d063a42ec93a943a3e6b08f
Author: Ashod Nakashian
AuthorDate: Fri Oct 18 08:10:12 2019 -0400
Commit: Ashod Nakashian
CommitDate: Tue Oct 29 02:30:07 2019 +0100
wsd: dynamic child timeout
The initial child spawning takes significantly longer
than subsequent ones (for obvious reasons) and this
lead to unit-tests being sensitive to the timeout
we use for child spawning. Too short, and we
spawn more than we want on startup, too long
and crash-recovery tests fail (we don't
recover fast enough, as we wait too long before
spawning new children).
Dynamically setting the timeout allows us to give
longer timeout at startup, and reduce it afterwards.
Reviewed-on: https://gerrit.libreoffice.org/81194
Reviewed-by: Andras Timar
Tested-by: Andras Timar
(cherry picked from commit 32fa1d95fc2ec65866d0cb47d619885182db7040)
Change-Id: I8423f5c6619e57030ab43d519aaa41d8712c36d3
Reviewed-on: https://gerrit.libreoffice.org/81570
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/common/Common.hpp b/common/Common.hpp
index f35ca08f8..7a02dfaae 100644
--- a/common/Common.hpp
+++ b/common/Common.hpp
@@ -16,7 +16,7 @@
constexpr int DEFAULT_CLIENT_PORT_NUMBER = 9980;
constexpr int COMMAND_TIMEOUT_MS = 5000;
-constexpr int CHILD_TIMEOUT_MS = COMMAND_TIMEOUT_MS * 2;
+constexpr int CHILD_TIMEOUT_MS = COMMAND_TIMEOUT_MS;
constexpr int CHILD_REBALANCE_INTERVAL_MS = CHILD_TIMEOUT_MS / 10;
constexpr int POLL_TIMEOUT_MS = COMMAND_TIMEOUT_MS / 5;
constexpr int WS_SEND_TIMEOUT_MS = 1000;
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 18568b53b..d3b0c654f 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -407,7 +407,13 @@ void DocumentBroker::pollThread()
}
// Flush socket data first.
-const int flushTimeoutMs = POLL_TIMEOUT_MS * 2; // ~1000ms
+constexpr int flushTimeoutMs = POLL_TIMEOUT_MS * 2; // ~1000ms
+LOG_INF("Flushing socket for doc ["
+<< _docKey << "] for " << flushTimeoutMs << " ms. stop: " << _stop
+<< ", continuePolling: " << _poll->continuePolling()
+<< ", ShutdownRequestFlag: " << SigUtil::getShutdownRequestFlag()
+<< ", TerminationFlag: " << SigUtil::getTerminationFlag()
+<< ". Terminating child with reason: [" << _closeReason << "].");
const auto flushStartTime = std::chrono::steady_clock::now();
while (_poll->getSocketCount())
{
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index d7ebcbb26..e43b827ec 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -211,6 +211,8 @@ extern "C" { void dump_state(void); /* easy for gdb */ }
static int careerSpanMs = 0;
#endif
+/// The timeout for a child to spawn, initially high, then reset to the
default.
+int ChildSpawnTimeoutMs = CHILD_TIMEOUT_MS * 4;
bool LOOLWSD::NoCapsForKit = false;
std::atomic LOOLWSD::NumConnections;
std::set LOOLWSD::EditFileExtensions;
@@ -425,7 +427,7 @@ static int rebalanceChildren(int balance)
const auto duration = (std::chrono::steady_clock::now() -
LastForkRequestTime);
const std::chrono::milliseconds::rep durationMs =
std::chrono::duration_cast(duration).count();
-if (OutstandingForks != 0 && durationMs >= CHILD_TIMEOUT_MS)
+if (OutstandingForks != 0 && durationMs >= ChildSpawnTimeoutMs)
{
// Children taking too long to spawn.
// Forget we had requested any, and request anew.
@@ -507,7 +509,7 @@ std::shared_ptr getNewChild_Blocks(
}
// With valgrind we need extended time to spawn kits.
-const size_t timeoutMs = CHILD_TIMEOUT_MS / 2;
+const size_t timeoutMs = ChildSpawnTimeoutMs / 2;
LOG_TRC("Waiting for a new child for a max of " << timeoutMs << " ms.");
const auto timeout = std::chrono::milliseconds(timeoutMs);
#else
@@ -1676,7 +1678,10 @@ bool LOOLWSD::createForKit()
Admin::instance().setForKitPid(ForKitProcId);
Admin::instance().setForKitWritePipe(ForKitWritePipe);
-rebalanceChildren(LOOLWSD::NumPreSpawnedChildren - 1);
+const int balance = LOOLWSD::NumPreSpawnedChildren - OutstandingForks;
+if (balance > 0)
+rebalanceChildren(balance);
+
return ForKitProcId != -1;
#endif
}
@@ -3415,7 +3420,7 @@ int LOOLWSD::innerMain()
}
else
{
-const int timeoutMs = CHILD_TIMEOUT_MS * (LOOLWSD::NoCapsForKit ?
150 : 50);
+const int timeoutMs = ChildSpawnTimeoutMs * (LOOLWSD::NoCapsForKit
? 150 : 50);
const auto timeout = std::chrono::milliseconds(timeoutMs);
LOG_TRC("Waiting for a new child for a max of " << timeoutMs << "
ms.");
if (!NewChildrenCV.wait_for(lock, timeout, []() {
[Libreoffice-bugs] [Bug 128443] when using master document, images in inserted documents do not appear and aren't exported
https://bugs.documentfoundation.org/show_bug.cgi?id=128443 --- Comment #1 from erikmjac...@gmail.com --- Created attachment 155381 --> https://bugs.documentfoundation.org/attachment.cgi?id=155381=edit a zipfile containing a master and a file with an image I included a reproducer of a master file and another ODT that has just an image in it. If you open the master and make sure to appropriately link the ODT into it, I'm assuming you'll see what I see. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128443] New: when using master document, images in inserted documents do not appear and aren't exported
https://bugs.documentfoundation.org/show_bug.cgi?id=128443 Bug ID: 128443 Summary: when using master document, images in inserted documents do not appear and aren't exported Product: LibreOffice Version: 6.3.2.2 release Hardware: x86 (IA32) OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: erikmjac...@gmail.com Description: If you create a master document and then create and insert a document that has an image embedded in it, the master does not show the images. Steps to Reproduce: 1. Create a master document 2. Click "insert" -> "new document" 3. Insert an image into the subsequent document 4. Save the created document 5. Update the master Actual Results: Image is not shown in the master, and when exporting the image isn't shown either (eg: File -> Export As -> Export direct to PDF) Expected Results: Images should be shown Reproducible: Always User Profile Reset: No Additional Info: Version: 6.3.2.2 (x64) Build ID: 98b30e735bda24bc04ab42594c85f7fd8be07b9c CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89063] importing pub files containing formatted tables not resolving border formatting correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=89063 --- Comment #2 from gjr...@xtra.co.nz --- come on guys, 2019 and still this formatting of tables in draw is not resolved -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128113] file Open type menu has about 176 items, please organize
https://bugs.documentfoundation.org/show_bug.cgi?id=128113 Nick Levinson changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #22 from Nick Levinson --- The menu is virtually the same in the master build as it was when I originally reported this problem. Test: My installation (Fedora) is RPM-based. The RPM link in comment 14 yields a 404 error, so I went back to the original URL for the master and dug again, this time skipping helppack, langpack, and sdk files, leaving master~2019-10-25_20.30.28_LibreOfficeDev_6.4.0.0.alpha1_Linux_x86-64_rpm.tar.gz and I installed from that; installation was simple, per the readmes (the Dev readme erroneously refers the reader to the stable-version readme so we have to use both). I opened LibreOfficeDev Writer and, as a first-time user, I saw nothing relevant in the release notes (https://wiki.documentfoundation.org/ReleaseNotes/6.4#Writer). The About box says "LibreOfficeDev"/"Version: 6.4.0.0.alpha1+ Build ID: 706afd3e765e98489a2b43934a259626f9f0be01"/"CPU threads: 2; OS: Linux 5.3; UI render: default; VCL: gtk3;"/"TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-10-25_20:30:28"/"Locale: en-US (en_US.UTF-8); UI-Language: en-US"/"Calc: threaded". File > Open > file types menu now operates nonconventionally, in that it has a downward-pointing arrowhead on the right but clicking it does not directly open the menu. Once I opened it, I found it a bit hard to control, either rapidly overscrolling or underscrolling, which makes it easy to miss a needed filter. Combined with the look of disorganization, the menu becomes more annoying than useful. Nongeeks will not be able to find most of the filters with reasonable speed and will mainly be frustrated. Apart from the test of the master build, my distro recently provided a new LO version and the menu in that appears to be essentially the same. It's now "Version: 6.2.8.2"/"Build ID: 6.2.8.2-2.fc30"/"CPU threads: 2; OS: Linux 5.3; UI render: default; VCL: gtk3;"/"Locale: en-US (en_US.UTF-8); UI-Language: en-US"/"Calc: threaded". Solutions: Nonselectable menu items are unusual, but having around 176 items in one menu is also unusual. Adding nonclickable items need not add much to overall menu length. For example, you could add these group labels after the first few menu items: --- LibreOffice and OpenDocument --- --- Microsoft including Office --- --- Macintosh and Apple --- --- WordPerfect --- --- IBM and Lotus --- --- OpenOffice.org and StarOffice --- --- Claris --- --- Adobe --- --- Databases, Generic --- --- HTML --- --- Text, Generic --- --- Graphics, Generic --- --- Other --- It occurs to me that I'm using brands and you're using major types. You may be right to do so, but many people use spreadsheets to hold databases even where they have a DBMS. Nonclickable major-types labels would take even less room. I regret that omitting MS's name from items was already decided on. I despise Windows and when I get another computer that has it preinstalled I am so thorough in deleting it that deletion takes me about 1 1/2 days around the clock (I sic DBAN on it, set for thoroughness). But users may not recognize Word Pro unless you say IBM Lotus in front of it. Ditto MS. That it's advertising is less important than that it's informative to users who just want to get their work done and need the right filter and don't care about whether MS should be tarred and feathered when they want to open documents. I wouldn't even use abbreviations like MS or MSO (I didn't even recognize "MSO"); most ordinary users don't recognize "MS" but they know the full name. It's okay to say "ODT" but not as a substitute for "LibreOffice"; perhaps say "LibreOffice" before "ODT". Instead of killing the enhancement request as not a bug, maybe its importance should be downranked in comparison to other enhancements, and gotten to eventually. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: kit/ChildSession.cpp test/httpwstest.cpp wsd/ClientSession.cpp
kit/ChildSession.cpp |1 +
test/httpwstest.cpp |5 +++--
wsd/ClientSession.cpp |8 +---
3 files changed, 9 insertions(+), 5 deletions(-)
New commits:
commit 10ffdc1e4a64c0ee2f15d781fdd13e18d2779565
Author: Ashod Nakashian
AuthorDate: Wed Oct 16 09:12:02 2019 -0400
Commit: Ashod Nakashian
CommitDate: Tue Oct 29 01:43:17 2019 +0100
testSaveOnDisconnect: sync after pasting and better logging
Reviewed-on: https://gerrit.libreoffice.org/80898
Reviewed-by: Andras Timar
Tested-by: Andras Timar
(cherry picked from commit 230fcd2f07192f30fb6d6671d905800fde71495e)
Change-Id: Iaacbe0bdc6a7ba88d2f09c343d9579315033acbb
Reviewed-on: https://gerrit.libreoffice.org/81569
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index 05c9ba772..f67e3a1c1 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -213,6 +213,7 @@ bool ChildSession::_handleInput(const char *buffer, int
length)
sendTextFrame("error: cmd=load kind=faileddocloading");
}
+LOG_TRC("isDocLoaded state after loadDocument: " << _isDocLoaded <<
'.');
return _isDocLoaded;
}
else if (!_isDocLoaded)
diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index f13e21582..d9a4727cf 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -591,7 +591,7 @@ void HTTPWSTest::testSaveOnDisconnect()
void HTTPWSTest::testSavePassiveOnDisconnect()
{
-const char* testname = "saveOnPassiveDisconnect ";
+const char* testname = "savePassiveOnDisconnect ";
const std::string text = helpers::genRandomString(40);
TST_LOG("Test string: [" << text << "].");
@@ -785,7 +785,8 @@ void HTTPWSTest::testLargePaste()
const std::string documentContents = oss.str();
TST_LOG("Pasting " << documentContents.size() << " characters into
document.");
-sendTextFrame(socket, "paste mimetype=text/html\n" + documentContents,
testname);
+sendTextFrame(socket, "paste mimetype=text/plain;charset=utf-8\n" +
documentContents, testname);
+getResponseString(socket, "textselection:", testname, 1000);
// Check if the server is still alive.
// This resulted first in a hang, as respose for the message never
arrived, then a bit later in a Poco::TimeoutException.
diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index 8ddc0e91d..c2ca93237 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -452,7 +452,7 @@ bool ClientSession::_handleInput(const char *buffer, int
length)
{
// If this session is the owner of the file & 'EnableOwnerTermination'
feature
// is turned on by WOPI, let it close all sessions
-if (_isDocumentOwner && _wopiFileInfo &&
_wopiFileInfo->getEnableOwnerTermination())
+if (isDocumentOwner() && _wopiFileInfo &&
_wopiFileInfo->getEnableOwnerTermination())
{
LOG_DBG("Session [" << getId() << "] requested owner termination");
docBroker->closeDocument("ownertermination");
@@ -1567,7 +1567,9 @@ void ClientSession::removeOutdatedTilesOnFly()
double elapsedTimeMs =
std::chrono::duration_cast(std::chrono::steady_clock::now()
- tileIter->second).count();
if(elapsedTimeMs > TILE_ROUNDTRIP_TIMEOUT_MS)
{
-LOG_WRN("Tracker tileID was dropped because of time out.
Tileprocessed message did not arrive");
+LOG_WRN("Tracker tileID " << tileIter->first << " was dropped
because of time out ("
+ << elapsedTimeMs
+ << " ms). Tileprocessed message did not
arrive in time.");
_tilesOnFly.erase(tileIter);
}
else
@@ -1659,7 +1661,7 @@ void ClientSession::dumpState(std::ostream& os)
Session::dumpState(os);
os << "\t\tisReadOnly: " << isReadOnly()
- << "\n\t\tisDocumentOwner: " << _isDocumentOwner
+ << "\n\t\tisDocumentOwner: " << isDocumentOwner()
<< "\n\t\tstate: " << stateToString(_state)
<< "\n\t\tkeyEvents: " << _keyEvents
// << "\n\t\tvisibleArea: " << _clientVisibleArea
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128113] file Open type menu has about 176 items, please organize
https://bugs.documentfoundation.org/show_bug.cgi?id=128113 --- Comment #21 from Nick Levinson --- Created attachment 155380 --> https://bugs.documentfoundation.org/attachment.cgi?id=155380=edit full menu in LODev v6.4.0.0-alpha1+ from OP -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp
wsd/DocumentBroker.cpp | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
New commits:
commit 8a06ad83e473e3f0b34e83a7ba4e45bebd0bdaeb
Author: Ashod Nakashian
AuthorDate: Wed Oct 16 09:05:04 2019 -0400
Commit: Ashod Nakashian
CommitDate: Tue Oct 29 01:42:05 2019 +0100
wsd: save using a fully-loaded view
Using a view that hasn't finished loading
for saving the document will fail, and there
is no recovery from that (by using a loaded
view as fallback, for example).
This can happen when a new view is being loaded
while the last one is closing. We might in this
case end up using the new view to save the document
before closing it, however this will fail if
the new view hasn't loaded yet, potentially
losing some late modifications.
We avoid this by always picking a loaded view
for saving, or the first.
Reviewed-on: https://gerrit.libreoffice.org/80896
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Andras Timar
(cherry picked from commit 77cbe4e376649dee87dbe37f95a48e9bb6403a0b)
Change-Id: I03ee9c48a9d43487dd90672060870972b98fdc99
Reviewed-on: https://gerrit.libreoffice.org/81567
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 081a07c55..18568b53b 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -1054,8 +1054,9 @@ bool DocumentBroker::autoSave(const bool force, const
bool dontSaveIfUnmodified)
for (auto& sessionIt : _sessions)
{
// Save the document using an editable session, or first ...
-if (savingSessionId.empty() ||
-(!sessionIt.second->isReadOnly() &&
!sessionIt.second->inWaitDisconnected()))
+if (savingSessionId.empty()
+|| (!sessionIt.second->isReadOnly() &&
sessionIt.second->isViewLoaded()
+&& !sessionIt.second->inWaitDisconnected()))
{
savingSessionId = sessionIt.second->getId();
}
@@ -1271,9 +1272,12 @@ size_t DocumentBroker::removeSession(const std::string&
id)
const bool lastEditableSession = !it->second->isReadOnly() &&
!haveAnotherEditableSession(id);
-LOG_INF("Removing session [" << id << "] on docKey [" << _docKey <<
-"]. Have " << _sessions.size() << " sessions. markToDestroy: "
<< _markToDestroy <<
-", LastEditableSession: " << lastEditableSession);
+LOG_INF("Removing session ["
+<< id << "] on docKey [" << _docKey << "]. Have " <<
_sessions.size()
+<< " sessions. IsReadOnly: " << it->second->isReadOnly()
+<< ", IsViewLoaded: " << it->second->isViewLoaded() << ",
IsWaitDisconnected: "
+<< it->second->inWaitDisconnected() << ", MarkToDestroy: " <<
_markToDestroy
+<< ", LastEditableSession: " << lastEditableSession);
const auto dontSaveIfUnmodified =
!LOOLWSD::getConfigValue("per_document.always_save_on_exit", false);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: test/helpers.hpp test/httpwstest.cpp
test/helpers.hpp| 48 +-
test/httpwstest.cpp | 173
2 files changed, 140 insertions(+), 81 deletions(-)
New commits:
commit 194db8ed45e1bd47a94c5b7a23a9add0a4c0eb39
Author: Ashod Nakashian
AuthorDate: Sat Oct 12 13:47:38 2019 -0400
Commit: Ashod Nakashian
CommitDate: Tue Oct 29 01:41:00 2019 +0100
test: improve stability of a number of tests
There are numerous race conditions between issuing
action and getting the events. This causes a
mismatch, such that the events from SelectAll
is received when waiting for the events for a
subsequent action (say, Delete).
To make matters worse, sometimes Core issues
an invalidation whilst sending the events for
an action, and this completely messes our
accounting of what events we expect.
This latter could also be an issue with real
clients, however it's less likely to be
disruptive. Still, it is possible that
the client doesn't get key events
because Core had a hiccup, which breaks
the tests.
For the tests at least, the solution is to
re-issue the last action, such that we make
sure that we move forward only when the correct
event is received, or we timeout waiting.
The end results is that tests now don't fail
nearly as often as they used to.
Reviewed-on: https://gerrit.libreoffice.org/80894
Reviewed-by: Andras Timar
Tested-by: Andras Timar
(cherry picked from commit 050403daf04d6b36ef850006ba4a15eab6be9afc)
Change-Id: Ib1a658846061990649987ca083915a49c1fb092a
Reviewed-on: https://gerrit.libreoffice.org/81565
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/test/helpers.hpp b/test/helpers.hpp
index 5b484baa7..30d20d3d8 100644
--- a/test/helpers.hpp
+++ b/test/helpers.hpp
@@ -59,6 +59,9 @@
#define TST_LOG_NAME(NAME, X) TST_LOG_NAME_BEGIN(NAME, X); TST_LOG_END
#define TST_LOG(X) TST_LOG_NAME(testname, X)
+// Sometimes we need to retry some commands as they can (due to timing or
load) soft-fail.
+constexpr int COMMAND_RETRY_COUNT = 5;
+
/// Common helper testing functions.
/// Avoid the temptation to reuse from LOOL code!
/// These are supposed to be testing the latter.
@@ -675,8 +678,6 @@ inline void
getServerVersion(std::shared_ptr& socket,
getServerVersion(*socket, major, minor, testname);
}
-}
-
inline bool svgMatch(const char *testname, const std::vector ,
const char *templateFile)
{
const std::vector expectedSVG =
helpers::readDataFromFile(templateFile);
@@ -702,6 +703,49 @@ inline bool svgMatch(const char *testname, const
std::vector , co
return true;
}
+/// Select all and wait for the text selection update.
+inline void selectAll(const std::shared_ptr& socket, const
std::string& testname, int repeat = COMMAND_RETRY_COUNT)
+{
+for (int i = 0; i < repeat; ++i)
+{
+sendTextFrame(socket, "uno .uno:SelectAll", testname);
+if (!getResponseString(socket, "textselection:", testname).empty())
+break;
+}
+}
+
+
+/// Delete all and wait for the text selection update.
+inline void deleteAll(const std::shared_ptr& socket, const
std::string& testname, int repeat = COMMAND_RETRY_COUNT)
+{
+selectAll(socket, testname);
+
+for (int i = 0; i < repeat; ++i)
+{
+sendTextFrame(socket, "uno .uno:Delete", testname);
+if (!getResponseString(socket, "textselection:", testname).empty())
+break;
+}
+}
+
+inline std::string getAllText(const std::shared_ptr& socket,
+ const std::string& testname, int retry =
COMMAND_RETRY_COUNT)
+{
+std::string text;
+for (int i = 0; i < retry; ++i)
+{
+selectAll(socket, testname);
+
+sendTextFrame(socket, "gettextselection
mimetype=text/plain;charset=utf-8", testname);
+text = assertResponseString(socket, "textselectioncontent:", testname);
+if (!text.empty())
+break;
+}
+
+return text;
+}
+
+}
#endif
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index a2c4eaf2a..f13e21582 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -118,6 +118,7 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
CPPUNIT_TEST(testSavePassiveOnDisconnect);
CPPUNIT_TEST(testReloadWhileDisconnecting);
CPPUNIT_TEST(testExcelLoad);
+CPPUNIT_TEST(testPaste);
CPPUNIT_TEST(testPasteBlank);
CPPUNIT_TEST(testInsertDelete);
CPPUNIT_TEST(testSlideShow);
@@ -165,6 +166,7 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
void testSavePassiveOnDisconnect();
void testReloadWhileDisconnecting();
void testExcelLoad();
+void testPaste();
void testPasteBlank();
void testInsertDelete();
void testSlideShow();
@@ -513,9 +515,7 @@ void HTTPWSTest::testGetTextSelection()
[Libreoffice-bugs] [Bug 128113] file Open type menu has about 176 items, please organize
https://bugs.documentfoundation.org/show_bug.cgi?id=128113 Nick Levinson changed: What|Removed |Added Summary|file Open type menu has |file Open type menu has |about 155 items, please |about 176 items, please |organize|organize -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107280] [META] Issues related to the shared code between Impress and Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=107280 Bug 107280 depends on bug 108202, which changed state. Bug 108202 Summary: Text in 'Insert Slides/Objects' dialog should say pages and not slides https://bugs.documentfoundation.org/show_bug.cgi?id=108202 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111948] [META] Insert file content issues
https://bugs.documentfoundation.org/show_bug.cgi?id=111948 Bug 111948 depends on bug 108202, which changed state. Bug 108202 Summary: Text in 'Insert Slides/Objects' dialog should say pages and not slides https://bugs.documentfoundation.org/show_bug.cgi?id=108202 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102019] [META] Dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102019 Bug 102019 depends on bug 108202, which changed state. Bug 108202 Summary: Text in 'Insert Slides/Objects' dialog should say pages and not slides https://bugs.documentfoundation.org/show_bug.cgi?id=108202 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/inc sd/source
sd/inc/strings.hrc |2 ++
sd/source/ui/dlg/inspagob.cxx |2 ++
sd/source/ui/docshell/docshel2.cxx |7 ++-
3 files changed, 10 insertions(+), 1 deletion(-)
New commits:
commit 25506d15222e583ce5d62b016cf598a9aef65d09
Author: Muhammet Kara
AuthorDate: Tue Oct 29 01:16:03 2019 +0300
Commit: Muhammet Kara
CommitDate: Tue Oct 29 01:14:22 2019 +0100
tdf#108202: Correct Draw page naming in insert pages, and page naming
dialogs
Change-Id: I2485bc29d6286cc30436fa9ecfb29e724578db41
Reviewed-on: https://gerrit.libreoffice.org/81631
Tested-by: Jenkins
Reviewed-by: Muhammet Kara
diff --git a/sd/inc/strings.hrc b/sd/inc/strings.hrc
index 26956a1fb751..10717e37f12c 100644
--- a/sd/inc/strings.hrc
+++ b/sd/inc/strings.hrc
@@ -74,6 +74,7 @@
#define STR_TITLE_NAMEGROUP
NC_("STR_TITLE_NAMEGROUP", "Name Object")
#define STR_DESC_NAMEGROUP
NC_("STR_DESC_NAMEGROUP", "Name")
#define STR_WARN_PAGE_EXISTS
NC_("STR_WARN_PAGE_EXISTS", "The slide name already exists or is invalid.
Please enter another name.")
+#define STR_WARN_PAGE_EXISTS_DRAW
NC_("STR_WARN_PAGE_EXISTS_DRAW", "The page name already exists or is invalid.
Please enter another name.")
#define STR_SNAPDLG_SETLINE
NC_("STR_SNAPDLG_SETLINE", "Edit Snap Line")
#define STR_SNAPDLG_SETPOINT
NC_("STR_SNAPDLG_SETPOINT", "Edit Snap Point")
#define STR_POPUP_EDIT_SNAPLINE
NC_("STR_POPUP_EDIT_SNAPLINE", "Edit Snap Line...")
@@ -311,6 +312,7 @@
#define STR_LAYOUT_DEFAULT_TITLE_NAME
NC_("STR_LAYOUT_DEFAULT_TITLE_NAME", "Title" )
#define STR_STANDARD_STYLESHEET_NAME
NC_("STR_STANDARD_STYLESHEET_NAME", "Default" )
#define STR_UNDO_MOVEPAGES
NC_("STR_UNDO_MOVEPAGES", "Move slides" )
+#define STR_INSERT_PAGES
NC_("STR_INSERT_PAGES", "Insert Pages" )
#define STR_POOLSHEET_OBJWITHOUTFILL
NC_("STR_POOLSHEET_OBJWITHOUTFILL", "Object without fill" )
#define STR_POOLSHEET_OBJNOLINENOFILL
NC_("STR_POOLSHEET_OBJNOLINENOFILL", "Object with no fill and no line" )
diff --git a/sd/source/ui/dlg/inspagob.cxx b/sd/source/ui/dlg/inspagob.cxx
index bab9494acb3e..37fa11ece19c 100644
--- a/sd/source/ui/dlg/inspagob.cxx
+++ b/sd/source/ui/dlg/inspagob.cxx
@@ -49,6 +49,8 @@ SdInsertPagesObjsDlg::SdInsertPagesObjsDlg(
// insert text
if (!m_pMedium)
m_xDialog->set_title(SdResId(STR_INSERT_TEXT));
+else if (m_pDoc && m_pDoc->GetDocumentType() == DocumentType::Draw)
+m_xDialog->set_title(SdResId(STR_INSERT_PAGES));
Reset();
}
diff --git a/sd/source/ui/docshell/docshel2.cxx
b/sd/source/ui/docshell/docshel2.cxx
index 92e1024158fd..084c0d313359 100644
--- a/sd/source/ui/docshell/docshel2.cxx
+++ b/sd/source/ui/docshell/docshel2.cxx
@@ -279,9 +279,14 @@ bool DrawDocShell::CheckPageName(weld::Window* pWin,
OUString& rName)
if( ! bIsNameValid )
{
-OUString aDesc( SdResId( STR_WARN_PAGE_EXISTS ) );
+OUString aDesc;
SvxAbstractDialogFactory* pFact = SvxAbstractDialogFactory::Create();
+if (GetDocumentType() == DocumentType::Draw)
+aDesc = SdResId( STR_WARN_PAGE_EXISTS_DRAW );
+else
+aDesc = SdResId( STR_WARN_PAGE_EXISTS );
+
ScopedVclPtr
aNameDlg(pFact->CreateSvxNameDialog(pWin, aStrForDlg, aDesc));
aNameDlg->SetEditHelpId( HID_SD_NAMEDIALOG_PAGE );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 126409] LibreOffice does not launch normally on macOS 10.15 Catalina
https://bugs.documentfoundation.org/show_bug.cgi?id=126409 m.a.riosv changed: What|Removed |Added CC||bitban...@earthlink.net --- Comment #33 from m.a.riosv --- *** Bug 128440 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128440] Cannot install product on Catalina release
https://bugs.documentfoundation.org/show_bug.cgi?id=128440 m.a.riosv changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Please take a look on https://blog.documentfoundation.org/blog/2019/10/22/libreoffice-and-macos-catalina/ *** This bug has been marked as a duplicate of bug 126409 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122218] After Update to 6.1.4 on macOS fonts are blurred on retina display (xcode 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=122218 --- Comment #80 from exprez135 --- Has anyone been able to test building with xcode 11? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125925] Qt5 VCL UI Fonts are small
https://bugs.documentfoundation.org/show_bug.cgi?id=125925 --- Comment #13 from Ongun Kanat --- (In reply to Michael Weghorn from comment #12) > > * UI is non-native and it shows here and there like bug 125926. The UI > > controls like combo boxes are obviously non native. Clicking on them > > launches a sub dialog like menu rendered in GTK. They behave really > > differently than other Qt/KDE apps. My touchpad has horizontal scroll and > > unintentionally triggering it causes non-native combobox dialogs scroll > > right and hide the labels inside which is extremely annoying. > > This might be bug 125201 which was solved recently and will no longer be > present in 6.3. No that's a completely different bug. The problem is LO doesn't use Qt-native components and try to invent its own. It will always be non-native looking for us KDE users as this approach continued to be used but there's not much to do without redesigning LO from scratch as far as I understand from VCL related wiki pages and bug reports etc. This bug persists on the latest build of LO and the screenshots are the same: Version: 6.4.0.0.alpha1+ Build ID: e6109939b448f070848bfcf11ac013e05f71767a CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: kf5; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-10-27_22:29:11 Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125926] KDE5 VCL uses unnecessarily bold fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=125926 --- Comment #12 from Ongun Kanat --- Created attachment 155379 --> https://bugs.documentfoundation.org/attachment.cgi?id=155379=edit My fontconfig configuration -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125926] KDE5 VCL uses unnecessarily bold fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=125926
--- Comment #11 from Ongun Kanat ---
Created attachment 155378
--> https://bugs.documentfoundation.org/attachment.cgi?id=155378=edit
Screenshots for 6.4 alpha1
I downloaded the latest build (2019-10-27_22.29.11) in [1] and extracted it as
instructed in [2].
The soffice binary created a separate configuration directory in ~/.config
called libreofficedev but I moved out my libreoffice folder in order to
eliminate the possibility of any corruption and deleted libreofficedev folder
after each trial.
The bug was still there in each run without any exceptions. I also took
screenshots of the menus in order to show the difference between Qt rendered
main menu and LibreOffice rendered context menu and I include an overexposed
version of two menus. Again the bug can be observed in welcome screen as well.
I include 4 screenshots as the attachment.
I will also upload my fontconfig config files. Maybe they can shed some light.
However, I don't think my font configuration is terribly wrong (it's a bit
hacky for emoji though) since the LibreOffice and KDE VCL is the only UI with
unusual bold fonts I get in my computer. All the other GTK{2,3} and Qt 5 apps
render perfectly normal fonts.
Furthermore I will try Manjaro live CD and put a report.
The version info is below:
Version: 6.4.0.0.alpha1+
Build ID: e6109939b448f070848bfcf11ac013e05f71767a
CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: kf5;
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2019-10-27_22:29:11
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded
[1]
https://dev-builds.libreoffice.org/daily/master/Linux-rpm_deb-x86_64@86-TDF/
[2]
https://wiki.documentfoundation.org/Installing_in_parallel/Linux#Step_3:_Tweaking_the_Install_Destination
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125926] KDE5 VCL uses unnecessarily bold fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=125926 Ongun Kanat changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116336] HYPERLINK() used in a cell with 'Wrap text automatically' links only for the first line.
https://bugs.documentfoundation.org/show_bug.cgi?id=116336 --- Comment #5 from Wolfgang Jäger --- Tested with V 6.3.3.2 Behaviour unchanged. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128442] New: Newly opened document/presentation does not get focus
https://bugs.documentfoundation.org/show_bug.cgi?id=128442 Bug ID: 128442 Summary: Newly opened document/presentation does not get focus Product: LibreOffice Version: 5.4 all versions Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: je...@bundsgaard.net Description: When opening a text document or a presentation from my mail program or Files, the newly opened document or presentation doesn't get focus. This has two drawbacks: 1. When I start writing, nothing happens 2. Worse: When I close the document/presentation using Alt+F4, I don't close the document/presentation, I close the program that opened the document. This is annoying. I am using Ubuntu (now 19.10) and LibreOffice (now 6.3), but it has been the case for a long time. Steps to Reproduce: 1. Click on document in another program (Files, Evolution etc.) 2. Close using Alt+F4 Actual Results: Closes program that opened this document Expected Results: Close the document. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: wsd/TileCache.cpp
wsd/TileCache.cpp |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 7cb650afa855223e9c1de66310818b1189818f86
Author: Michael Meeks
AuthorDate: Mon Oct 28 22:11:21 2019 +
Commit: Michael Meeks
CommitDate: Mon Oct 28 22:11:21 2019 +
Avoid potentially uninitialized warning.
Change-Id: I5282139079df14d07d97dd0cf0878670f2d4b6a5
diff --git a/wsd/TileCache.cpp b/wsd/TileCache.cpp
index 4c34577d2..651182078 100644
--- a/wsd/TileCache.cpp
+++ b/wsd/TileCache.cpp
@@ -595,7 +595,9 @@ void TileCache::ensureCacheSize()
std::sort(wids.begin(), wids.end(),
[](const WidSize , const WidSize ) { return a._wid < b._wid;
});
-TileWireId maxToRemove;
+// FIXME: should we just take a wid 25% into the list ?
+TileWireId maxToRemove = wids.front()._wid;
+
// do we have (the very rare) WID wrap-around
if (wids.back()._wid - wids.front()._wid > 256*256*256)
maxToRemove = wids.back()._wid;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128433] applying writing mode tb-rl to a legacy rectangle puts text box outside the shape
https://bugs.documentfoundation.org/show_bug.cgi?id=128433 V Stuart Foote changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||vstuart.fo...@utsa.edu Ever confirmed|0 |1 --- Comment #1 from V Stuart Foote --- Confirmed on Windows 10 Ent 64-bit en-US with Version: 6.3.2.2 (x64) Build ID: 98b30e735bda24bc04ab42594c85f7fd8be07b9c CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded And to confirm it is not the 'vert' handling of the CJK--changed the text runs to western by removing the CJK glyphs, changing Western text font in the Character dialog to Arial. Even with no CJK the change to tb-rl shifts text out of the Draw text box. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128441] New: Crash in: mergedlo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=128441 Bug ID: 128441 Summary: Crash in: mergedlo.dll Product: LibreOffice Version: 6.3.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: john...@live.co.uk Created attachment 155376 --> https://bugs.documentfoundation.org/attachment.cgi?id=155376=edit This document does not display correctly in LibOffice Writer. Selecting OpenGL and retrying crashed LibOffice. This bug was filed from the crash reporting server and is br-1ba178fc-43ce-44a5-9c3c-dbb3c918bb0b. = -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sw/source
sw/source/core/unocore/unobkm.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit 6edbc6c9922f960a8b7d606474b9411ca9b69450
Author: Michael Stahl
AuthorDate: Fri Oct 18 14:03:03 2019 +0200
Commit: Thorsten Behrens
CommitDate: Mon Oct 28 22:35:58 2019 +0100
sw: fix crash after SwXFieldmark::SetFieldType()
It deletes the existing IFieldmark and creates a new one; meanwhile the
SwXFieldmark is disposed and its m_pImpl->m_pDoc is cleared but then
it's not initialised again by registerInMark().
(regression from f66a83c95c21b4311918a64bb85016857b49f4d4)
Change-Id: I8c4d9b829f68b9e5bd714bcad2061d0ff95bfb82
Reviewed-on: https://gerrit.libreoffice.org/81081
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 26599f049df7c52eca001ba52a0684888201e1ba)
Reviewed-on: https://gerrit.libreoffice.org/81457
Reviewed-by: Thorsten Behrens
diff --git a/sw/source/core/unocore/unobkm.cxx
b/sw/source/core/unocore/unobkm.cxx
index 0a53c27c4516..556a2555987f 100644
--- a/sw/source/core/unocore/unobkm.cxx
+++ b/sw/source/core/unocore/unobkm.cxx
@@ -104,6 +104,8 @@ void SwXBookmark::Impl::registerInMark(SwXBookmark& rThis,
{
pMarkBase->SetXBookmark(xBookmark);
}
+assert(m_pDoc == nullptr || m_pDoc == pBkmk->GetMarkPos().GetDoc());
+m_pDoc = pBkmk->GetMarkPos().GetDoc();
}
else if (m_pRegisteredBookmark)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128285] Navigator heading selection jumps when context menu is open
https://bugs.documentfoundation.org/show_bug.cgi?id=128285 Jim Raykowski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||0281 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120281] Navigator loses multi-selection one second after right-clicking on it (Win-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=120281 Jim Raykowski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||8285 --- Comment #4 from Jim Raykowski --- Hi Thomas and Buovjaga, Bug 128285 is a duplicate of this bug report with a recently merged patch. I would have filed it under this one but didn't know it existed until just now while searching through recent list of untouched bugs. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128440] New: Cannot install product on Catalina release
https://bugs.documentfoundation.org/show_bug.cgi?id=128440 Bug ID: 128440 Summary: Cannot install product on Catalina release Product: LibreOffice Version: unspecified Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bitban...@earthlink.net I tried to download and install 6.3.2 on my macbook pro. Failed their malware detection protocol. Went back to 6.2.8, same problem. They insist that they cannot verify the source/ownership of the software. This has me dead in the water since I prefer your office suite to their offering. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser (error message: "Basic Syntax error. Expected: ).")
https://bugs.documentfoundation.org/show_bug.cgi?id=106529 --- Comment #58 from Pierre C --- Shouldn't this commit be activated in the master branch and reversed in all the sub branches. In this way devs will updated their extensions, and maybe find errors It could also be activated in all x.x.0 versions with a proper announcement and reverted for the next versions -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106529] LibO 5.3.1.x breaks extensions for changes in BASIC parser (error message: "Basic Syntax error. Expected: ).")
https://bugs.documentfoundation.org/show_bug.cgi?id=106529 --- Comment #57 from Mike Kaganski --- https://gerrit.libreoffice.org/81616 aims to reinstate the fix reverted here in comment 50, so that the error would only be thrown when using IDE (so that installed extensions and document with macros with the error would continue to work until edited in the IDE, which supposedly must mean that a developer is ready to finally fix this missing parenthesis error). Please review. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - vcl/headless
vcl/headless/svpgdi.cxx | 20 ++--
1 file changed, 6 insertions(+), 14 deletions(-)
New commits:
commit 7ab849142d163f9405ec12a1af55e32eaf662de0
Author: Michael Meeks
AuthorDate: Mon Oct 28 16:37:57 2019 +
Commit: Michael Meeks
CommitDate: Mon Oct 28 20:41:38 2019 +
headless: optimize DrawWaveLine / drawPixel.
ImplDrawWaveLine - used to render colored lines under mis-spelled
and/or grammatically interesting sections uses (for better or worse)
'drawPixel' to draw the line.
Implementing drawPixel with a tiny B2DPolyPolygon is easy reading
but triggers the unbelievably expensive SystemDependentDataHolder
paths as well as some big chunks of logic for very large numbers
of pixels (if you have lots of mis-spelling this can make typing
visibly slower.).
Change-Id: Ie6ad513e27f820bcad5030579428374c8d22fb3d
diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index b0f6f530e8bd..9c8a4bb97900 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -709,22 +709,14 @@ void SvpSalGraphics::drawPixel( long nX, long nY )
}
}
-void SvpSalGraphics::drawPixel( long nX, long nY, Color nColor )
+void SvpSalGraphics::drawPixel( long nX, long nY, Color aColor )
{
-Color aOrigFillColor = m_aFillColor;
-Color aOrigLineColor = m_aLineColor;
-
-basegfx::B2DPolygon aRect =
basegfx::utils::createPolygonFromRect(basegfx::B2DRectangle(nX, nY, nX+1,
nY+1));
-m_aLineColor = SALCOLOR_NONE;
-m_aFillColor = nColor;
-
-drawPolyPolygon(
-basegfx::B2DHomMatrix(),
-basegfx::B2DPolyPolygon(aRect),
-0.0);
+cairo_t* cr = getCairoContext(true);
+clipRegion(cr);
-m_aFillColor = aOrigFillColor;
-m_aLineColor = aOrigLineColor;
+cairo_rectangle(cr, nX, nY, 1, 1);
+applyColor(cr, aColor, 0.0);
+cairo_fill(cr);
}
void SvpSalGraphics::drawRect( long nX, long nY, long nWidth, long nHeight )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: README.md
README.md |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7ab68018b3b6410a3896642d3c6945bddf397911 Author: Miklos Vajna AuthorDate: Mon Oct 28 17:40:51 2019 +0100 Commit: Miklos Vajna CommitDate: Mon Oct 28 21:54:54 2019 +0100 Android: document one SDK version that works configure.ac doesn't check for any version as far as I see, add what works for me at the moment. Change-Id: If8b28e2a5d4bf4aea4325038ddf416a43f904db4 Reviewed-on: https://gerrit.libreoffice.org/81621 Tested-by: Jenkins Reviewed-by: Miklos Vajna diff --git a/README.md b/README.md index 2424359d2000..513bb159e3db 100644 --- a/README.md +++ b/README.md @@ -45,7 +45,7 @@ run and compile LibreOffice, also used by the TDF builds: * Runtime: 11.4 (only support for newer i devices == 64 bit) * Build: Xcode 9.3 and iPhone SDK 11.4 * Android: -* Build: NDK r19c +* Build: NDK r19c and SDK 22.6.2 If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 5.0.2. Since Xcode doesn't provide the compiler plugin ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128438] Writer: Cannot remove tab marks in paragraph using the Paragraph dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=128438 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED --- Comment #1 from V Stuart Foote --- Tab marks are formatting characters in the paragraph text runs. They are inserted into the text, you do not control them from style dialog or the ruler GUI. Those configurations control the text layout when tabs are present. Simply remove the tab marks. Done with the Find & Replace dialog, +H, and set 'Regular expressions' checkbox--then search for "\t" and replace with a (or another string of your choice). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: test/TileCacheTests.cpp wsd/DocumentBroker.cpp wsd/DocumentBroker.hpp wsd/TileCache.cpp wsd/TileCache.hpp
test/TileCacheTests.cpp | 31
wsd/DocumentBroker.cpp | 12
wsd/DocumentBroker.hpp |3 +
wsd/TileCache.cpp | 116 ++--
wsd/TileCache.hpp | 18 +++
5 files changed, 165 insertions(+), 15 deletions(-)
New commits:
commit 7890533419f2fda99e5d0a4f6c54e10b0516787d
Author: Michael Meeks
AuthorDate: Mon Oct 28 13:26:15 2019 +
Commit: Michael Meeks
CommitDate: Mon Oct 28 20:29:01 2019 +
TileCache: track and limit size to control memory usage.
Implement a basic WSD-side memory sizing approach and tell the
Admin console about it.
Change-Id: I1f0b5cf9fe29cb23ea574371e81e981b7af7a954
diff --git a/test/TileCacheTests.cpp b/test/TileCacheTests.cpp
index ad0f46823..174f3d5bb 100644
--- a/test/TileCacheTests.cpp
+++ b/test/TileCacheTests.cpp
@@ -60,6 +60,7 @@ class TileCacheTests : public CPPUNIT_NS::TestFixture
CPPUNIT_TEST(testDesc);
CPPUNIT_TEST(testSimple);
CPPUNIT_TEST(testSimpleCombine);
+CPPUNIT_TEST(testSize);
CPPUNIT_TEST(testCancelTiles);
// unstable
// CPPUNIT_TEST(testCancelTilesMultiView);
@@ -95,6 +96,7 @@ class TileCacheTests : public CPPUNIT_NS::TestFixture
void testDesc();
void testSimple();
void testSimpleCombine();
+void testSize();
void testCancelTiles();
void testCancelTilesMultiView();
void testDisconnectMultiView();
@@ -262,6 +264,35 @@ void TileCacheTests::testSimpleCombine()
CPPUNIT_ASSERT_MESSAGE("did not receive a tile: message as expected",
!tile2b.empty());
}
+void TileCacheTests::testSize()
+{
+// Create TileCache and pretend the file was modified as recently as
+// now, so it discards the cached data.
+TileCache tc("doc.ods", std::chrono::system_clock::time_point());
+
+int nviewid = 0;
+int part = 0;
+int width = 256;
+int height = 256;
+int tilePosX = 0;
+int tileWidth = 3840;
+int tileHeight = 3840;
+TileWireId id = 0;
+const std::vector data = genRandomData(4096);
+
+// Churn the cache somewhat
+size_t maxSize = (data.size() + sizeof (TileDesc)) * 10;
+tc.setMaxCacheSize(maxSize);
+for (int tilePosY = 0; tilePosY < 20; tilePosY++)
+{
+TileDesc tile(nviewid, part, width, height, tilePosX, tilePosY *
tileHeight,
+ tileWidth, tileHeight, -1, 0, -1, false);
+tile.setWireId(id++);
+tc.saveTileAndNotify(tile, data.data(), data.size());
+}
+CPPUNIT_ASSERT_MESSAGE("tile cache too big", tc.getMemorySize() < maxSize);
+}
+
void TileCacheTests::testCancelTiles()
{
const char* testname = "cancelTiles ";
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index c3f0dd04c..081a07c55 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -290,6 +290,9 @@ void DocumentBroker::pollThread()
const auto now = std::chrono::steady_clock::now();
#if !MOBILEAPP
+// a tile's data is ~8k, a 4k screen is ~128 256x256 tiles
+_tileCache->setMaxCacheSize(8 * 1024 * 128 * _sessions.size());
+
if (!_isLoaded && (limit_load_secs > 0) && (now > loadDeadline))
{
LOG_WRN("Doc [" << _docKey << "] is taking too long to load. Will
kill process ["
@@ -1444,7 +1447,8 @@ bool DocumentBroker::handleInput(const std::vector&
payload)
int dirty;
if (message->getTokenInteger("dirty", dirty))
{
-Admin::instance().updateMemoryDirty(_docKey, dirty);
+Admin::instance().updateMemoryDirty(
+_docKey, dirty + getMemorySize()/1024);
}
}
#endif
@@ -1458,6 +1462,12 @@ bool DocumentBroker::handleInput(const
std::vector& payload)
return true;
}
+size_t DocumentBroker::getMemorySize() const
+{
+return sizeof(DocumentBroker) + _tileCache->getMemorySize() +
+_sessions.size() * sizeof(ClientSession);
+}
+
void DocumentBroker::invalidateTiles(const std::string& tiles, int
normalizedViewId)
{
// Remove from cache.
diff --git a/wsd/DocumentBroker.hpp b/wsd/DocumentBroker.hpp
index 4d66ffae3..b64c7c28c 100644
--- a/wsd/DocumentBroker.hpp
+++ b/wsd/DocumentBroker.hpp
@@ -362,6 +362,9 @@ public:
/// For testing only [!]
std::vector> getSessionsTestOnlyUnsafe();
+/// Estimate memory usage / bytes
+size_t getMemorySize() const;
+
private:
/// Loads a document from the public URI into the jail.
diff --git a/wsd/TileCache.cpp b/wsd/TileCache.cpp
index df4141dfa..4c34577d2 100644
--- a/wsd/TileCache.cpp
+++ b/wsd/TileCache.cpp
@@ -35,7 +35,9 @@ TileCache::TileCache(const std::string& docURL,
const std::chrono::system_clock::time_point& modifiedTime,
bool dontCache) :
_docURL(docURL),
-_dontCache(dontCache)
+_dontCache(dontCache),
+_cacheSize(0),
+_maxCacheSize(512*1024)
{
#ifndef BUILDING_TESTS
[Libreoffice-bugs] [Bug 128431] Synchronize padding in header borders it is not working
https://bugs.documentfoundation.org/show_bug.cgi?id=128431 BogdanB changed: What|Removed |Added Keywords|bibisectRequest |bibisected --- Comment #4 from BogdanB --- I bibisected this bug: this is what I found: bogdan@bogdan-H110M-S2H:~/Libre Office bibisect/bibisect-linux-64-6.3$ git bisect bad && instdir/program/soffice b2fe7fe3d00290afceed2e8e49493792dce7b0a5 is the first bad commit commit b2fe7fe3d00290afceed2e8e49493792dce7b0a5 Author: Jenkins Build User Date: Fri Mar 1 00:14:50 2019 +0100 source sha:55042cb54fea5f7ad777c03af9bf8197127b6736 source sha:55042cb54fea5f7ad777c03af9bf8197127b6736 :04 04 949777573484af027ed76de518c022bde488835a de8c351d3352ebc589863392af8e2fe591ecfb01 M instdir -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128316] turn off autocapitalisation for date and whatever locale
https://bugs.documentfoundation.org/show_bug.cgi?id=128316 --- Comment #10 from Xavier Van Wijmeersch --- EN_US and EN_UK will have first letter in uppercase but this can be changed. I know its a workaround but still. steps to do file => properties => custom properties => add property give some name => text = text => value enter the date close with ok then in footer or header insert => field => more fields => tab DocInformation => select custom click given name and insert close And yes its a bit off work but it can be done. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128430] Field size is too long when inserting in the header
https://bugs.documentfoundation.org/show_bug.cgi?id=128430 BogdanB changed: What|Removed |Added Resolution|INVALID |NOTABUG --- Comment #5 from BogdanB --- Ok. I checked now. It's ok. It's not a bug. Sorry. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128410] Dialog "Conditional formatting for" is too small, shows only title
https://bugs.documentfoundation.org/show_bug.cgi?id=128410 Caolán McNamara changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | --- Comment #5 from Caolán McNamara --- wrong field with 0s in it -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/avmedia include/basegfx include/basic
include/avmedia/mediaitem.hxx |2 +-
include/avmedia/mediaplayer.hxx |4 ++--
include/avmedia/mediatoolbox.hxx |2 +-
include/basegfx/color/bcolormodifier.hxx | 16
include/basegfx/utils/systemdependentdata.hxx |2 +-
include/basic/modsizeexceeded.hxx |2 +-
include/basic/sbx.hxx |6 +++---
include/basic/sbxvar.hxx |2 +-
8 files changed, 18 insertions(+), 18 deletions(-)
New commits:
commit 7a059baa880a3c8e479b62644ad05fb56726c4b2
Author: Noel Grandin
AuthorDate: Mon Oct 28 18:21:56 2019 +0200
Commit: Noel Grandin
CommitDate: Mon Oct 28 20:17:20 2019 +0100
loplugin:finalclasses in avmedia..basic
Change-Id: Ia54364237149fac38e6ebcc5fcf9933d0ccf5984
Reviewed-on: https://gerrit.libreoffice.org/81619
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/avmedia/mediaitem.hxx b/include/avmedia/mediaitem.hxx
index 575d8f7be239..e309b0b29ce2 100644
--- a/include/avmedia/mediaitem.hxx
+++ b/include/avmedia/mediaitem.hxx
@@ -61,7 +61,7 @@ enum class MediaState
};
-class AVMEDIA_DLLPUBLIC MediaItem : public SfxPoolItem
+class AVMEDIA_DLLPUBLIC MediaItem final : public SfxPoolItem
{
public:
static SfxPoolItem* CreateDefault();
diff --git a/include/avmedia/mediaplayer.hxx b/include/avmedia/mediaplayer.hxx
index 396b94f7a660..52ecd942e49a 100644
--- a/include/avmedia/mediaplayer.hxx
+++ b/include/avmedia/mediaplayer.hxx
@@ -28,7 +28,7 @@
namespace avmedia
{
-class AVMEDIA_DLLPUBLIC MediaPlayer : public SfxChildWindow
+class AVMEDIA_DLLPUBLIC MediaPlayer final : public SfxChildWindow
{
public:
MediaPlayer( vcl::Window*, sal_uInt16, SfxBindings*,
SfxChildWinInfo* );
@@ -39,7 +39,7 @@ public:
class MediaWindow;
-class AVMEDIA_DLLPUBLIC MediaFloater : public SfxDockingWindow
+class AVMEDIA_DLLPUBLIC MediaFloater final : public SfxDockingWindow
{
public:
diff --git a/include/avmedia/mediatoolbox.hxx b/include/avmedia/mediatoolbox.hxx
index 5f39eab95ac1..08f63b1cf035 100644
--- a/include/avmedia/mediatoolbox.hxx
+++ b/include/avmedia/mediatoolbox.hxx
@@ -28,7 +28,7 @@ namespace avmedia
class MediaItem;
-class AVMEDIA_DLLPUBLIC MediaToolBoxControl : public SfxToolBoxControl
+class AVMEDIA_DLLPUBLIC MediaToolBoxControl final : public SfxToolBoxControl
{
friend class MediaToolBoxControl_Impl;
diff --git a/include/basegfx/color/bcolormodifier.hxx
b/include/basegfx/color/bcolormodifier.hxx
index 0f03f1080d9c..80cecf253962 100644
--- a/include/basegfx/color/bcolormodifier.hxx
+++ b/include/basegfx/color/bcolormodifier.hxx
@@ -88,7 +88,7 @@ namespace basegfx
{
/** convert color to gray
*/
-class SAL_WARN_UNUSED BASEGFX_DLLPUBLIC BColorModifier_gray : public
BColorModifier
+class SAL_WARN_UNUSED BASEGFX_DLLPUBLIC BColorModifier_gray final : public
BColorModifier
{
private:
protected:
@@ -115,7 +115,7 @@ namespace basegfx
returns a color where red green and blue are inverted using 1.0 - n
*/
-class SAL_WARN_UNUSED BASEGFX_DLLPUBLIC BColorModifier_invert : public
BColorModifier
+class SAL_WARN_UNUSED BASEGFX_DLLPUBLIC BColorModifier_invert final :
public BColorModifier
{
private:
protected:
@@ -146,7 +146,7 @@ namespace basegfx
This derivation is used for the svg importer and does exactly what SVG
defines for this needed case.
*/
-class SAL_WARN_UNUSED BASEGFX_DLLPUBLIC BColorModifier_luminance_to_alpha
: public BColorModifier
+class SAL_WARN_UNUSED BASEGFX_DLLPUBLIC BColorModifier_luminance_to_alpha
final : public BColorModifier
{
private:
protected:
@@ -175,7 +175,7 @@ namespace basegfx
given color, replacing everything. Useful e.g. for unified shadow
creation
*/
-class SAL_WARN_UNUSED BASEGFX_DLLPUBLIC BColorModifier_replace : public
BColorModifier
+class SAL_WARN_UNUSED BASEGFX_DLLPUBLIC BColorModifier_replace final :
public BColorModifier
{
private:
::basegfx::BColor maBColor;
@@ -211,7 +211,7 @@ namespace basegfx
col * (1 - f) + aSourceColor * f
*/
-class SAL_WARN_UNUSED BASEGFX_DLLPUBLIC BColorModifier_interpolate :
public BColorModifier
+class SAL_WARN_UNUSED BASEGFX_DLLPUBLIC BColorModifier_interpolate final :
public BColorModifier
{
private:
::basegfx::BColor maBColor;
@@ -248,7 +248,7 @@ namespace basegfx
returns black when the luminance of the given color is less than
the given threshold value in the range [0.0 .. 1.0], else white
*/
-class SAL_WARN_UNUSED BASEGFX_DLLPUBLIC BColorModifier_black_and_white :
public BColorModifier
+class SAL_WARN_UNUSED BASEGFX_DLLPUBLIC BColorModifier_black_and_white
final : public BColorModifier
{
private:
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/finalclasses.cxx | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
New commits:
commit 4b91b7dfa75d710d6845fd98b491889ec80d9da8
Author: Noel Grandin
AuthorDate: Mon Oct 28 18:21:37 2019 +0200
Commit: Noel Grandin
CommitDate: Mon Oct 28 20:17:02 2019 +0100
loplugin:finalclasses look for classes with virtual members
where making them final gives the compiler freedom to de-virtualise some
calls
Change-Id: I5755a41c42d9f23af58b873efae37a1d240fbd89
Reviewed-on: https://gerrit.libreoffice.org/81618
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/compilerplugins/clang/finalclasses.cxx
b/compilerplugins/clang/finalclasses.cxx
index 24bc814602fe..e7704ca8fc0c 100644
--- a/compilerplugins/clang/finalclasses.cxx
+++ b/compilerplugins/clang/finalclasses.cxx
@@ -15,9 +15,14 @@
#include
/**
-Look for classes that are final i.e. nothing extends them, and have protected
fields or members.
+Look for classes that are final i.e. nothing extends them, and have either
+(a) protected fields or members.
+or
+(b) virtual members
-These can be made private.
+In the case of (a), those members/fields can be made private.
+In the case of (b), making the class final means the compiler can devirtualise
+some method class.
The process goes something like this:
$ make check
@@ -88,6 +93,8 @@ bool FinalClasses::VisitCXXRecordDecl(const CXXRecordDecl*
decl)
decl = decl->getCanonicalDecl();
if (!decl->hasDefinition())
return true;
+if (decl->hasAttr())
+return true;
for (auto it = decl->bases_begin(); it != decl->bases_end(); ++it)
{
@@ -100,15 +107,16 @@ bool FinalClasses::VisitCXXRecordDecl(const
CXXRecordDecl* decl)
checkBase(spec.getType());
}
+bool bFoundVirtual = false;
bool bFoundProtected = false;
for (auto it = decl->method_begin(); it != decl->method_end(); ++it) {
auto i = *it;
// ignore methods that are overriding base-class methods, making them
private
// isn't useful
-if ( !i->hasAttr() && i->getAccess() == AS_protected ) {
+if ( !i->hasAttr() && i->getAccess() == AS_protected )
bFoundProtected = true;
-break;
-}
+if ( i->isVirtual() )
+bFoundVirtual = true;
}
if (!bFoundProtected)
{
@@ -120,7 +128,7 @@ bool FinalClasses::VisitCXXRecordDecl(const CXXRecordDecl*
decl)
}
}
}
-if (!bFoundProtected)
+if (!bFoundProtected && !bFoundVirtual)
return true;
std::string s = decl->getQualifiedNameAsString();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128439] New: Fileopen ODT: Long post-processing of a file containing a large table
https://bugs.documentfoundation.org/show_bug.cgi?id=128439 Bug ID: 128439 Summary: Fileopen ODT: Long post-processing of a file containing a large table Product: LibreOffice Version: 6.4.0.0.alpha1+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Fileopen ODT: Long post-processing of a file containing a large table Steps to Reproduce: Steps to Reproduce: 1. Open attachment 149343 [details] (bug 123517) 2. Notice the CPU usage after the file shows up and lines of the table being redrawn Actual Results: Long post processing after file opens. Some lines in the table get redrawn Expected Results: CPU hammering should stop after opening in +/-9 seconds with GDI (and +/-18 seconds with OpenGL) Reproducible: Always User Profile Reset: No Additional Info: Found in Versie: 6.4.0.0.alpha1 (x86) Build ID: cc57df8f942f239d29cb575ea5a7cb01405db787 CPU-threads: 4; Besturingssysteem: Windows 6.3 Build 9600; UI-render: GL; VCL: win; Locale : nl-NL (nl_NL); UI-taal: nl-NL Calc: CL but not in Version: 6.3.0.0.beta1+ (x86) Build ID: 5cfac16dbd4af456a7fb6d52c8953c69a72ba2ba CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/control/Control.AlertDialog.js | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
New commits:
commit 2420c8bdbea699f6401fd66ae09dea3032e1711e
Author: Szymon Kłos
AuthorDate: Wed Jun 5 21:08:36 2019 +0200
Commit: Szymon Kłos
CommitDate: Mon Oct 28 20:01:24 2019 +0100
Don't show edit link button in Impress
In impress it is needed to select full content of a
link to be able to edit it using hyperlink dialog.
Hide edit button for now to not show empty dialog.
Change-Id: If782bef66cbdaedc414dcf65df7c484be4343a5e
diff --git a/loleaflet/src/control/Control.AlertDialog.js
b/loleaflet/src/control/Control.AlertDialog.js
index d0f72e988..a1665eb08 100644
--- a/loleaflet/src/control/Control.AlertDialog.js
+++ b/loleaflet/src/control/Control.AlertDialog.js
@@ -49,15 +49,17 @@ L.Control.AlertDialog = L.Control.extend({
});
}
- buttonsList.push({
- text: _('Edit'),
- type: 'button',
- className: 'vex-dialog-button-secondary',
- click: function editClick () {
- vex.closeAll();
- e.map.showHyperlinkDialog();
- }
- });
+ if (this._map.getDocType() != 'presentation') {
+ buttonsList.push({
+ text: _('Edit'),
+ type: 'button',
+ className:
'vex-dialog-button-secondary',
+ click: function editClick () {
+ vex.closeAll();
+ e.map.showHyperlinkDialog();
+ }
+ });
+ }
vex.dialog.open({
message: messageText,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/headless
vcl/headless/svpgdi.cxx | 20 ++--
1 file changed, 6 insertions(+), 14 deletions(-)
New commits:
commit 036d2653d1005b1c5a0b4ca323513557b1cc7d52
Author: Michael Meeks
AuthorDate: Mon Oct 28 16:37:57 2019 +
Commit: Caolán McNamara
CommitDate: Mon Oct 28 19:59:46 2019 +0100
headless: optimize DrawWaveLine / drawPixel.
ImplDrawWaveLine - used to render colored lines under mis-spelled
and/or grammatically interesting sections uses (for better or worse)
'drawPixel' to draw the line.
Implementing drawPixel with a tiny B2DPolyPolygon is easy reading
but triggers the unbelievably expensive SystemDependentDataHolder
paths as well as some big chunks of logic for very large numbers
of pixels (if you have lots of mis-spelling this can make typing
visibly slower.).
Change-Id: Ie6ad513e27f820bcad5030579428374c8d22fb3d
Reviewed-on: https://gerrit.libreoffice.org/81622
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 7488a77b635d..5c1f0daab194 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -714,22 +714,14 @@ void SvpSalGraphics::drawPixel( long nX, long nY )
}
}
-void SvpSalGraphics::drawPixel( long nX, long nY, Color nColor )
+void SvpSalGraphics::drawPixel( long nX, long nY, Color aColor )
{
-Color aOrigFillColor = m_aFillColor;
-Color aOrigLineColor = m_aLineColor;
-
-basegfx::B2DPolygon aRect =
basegfx::utils::createPolygonFromRect(basegfx::B2DRectangle(nX, nY, nX+1,
nY+1));
-m_aLineColor = SALCOLOR_NONE;
-m_aFillColor = nColor;
-
-drawPolyPolygon(
-basegfx::B2DHomMatrix(),
-basegfx::B2DPolyPolygon(aRect),
-0.0);
+cairo_t* cr = getCairoContext(true);
+clipRegion(cr);
-m_aFillColor = aOrigFillColor;
-m_aLineColor = aOrigLineColor;
+cairo_rectangle(cr, nX, nY, 1, 1);
+applyColor(cr, aColor, 0.0);
+cairo_fill(cr);
}
void SvpSalGraphics::drawRect( long nX, long nY, long nWidth, long nHeight )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/control/Control.Toolbar.js |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit a5116600b30450f48b4f5f75e5c72861e2d2e00e
Author: Szymon Kłos
AuthorDate: Mon May 27 18:20:44 2019 +0200
Commit: Szymon Kłos
CommitDate: Mon Oct 28 19:56:14 2019 +0100
Enable hamburger-menu button by default
Change-Id: If73c7fd11de6fc40bc2065af958292ef51a17482
diff --git a/loleaflet/src/control/Control.Toolbar.js
b/loleaflet/src/control/Control.Toolbar.js
index cd2dd2da6..7eb1d3ea4 100644
--- a/loleaflet/src/control/Control.Toolbar.js
+++ b/loleaflet/src/control/Control.Toolbar.js
@@ -2051,7 +2051,7 @@ function onUpdatePermission(e) {
var toolbar = w2ui['editbar'];
if (toolbar) {
// always enabled items
- var enabledButtons = ['closemobile', 'undo', 'redo'];
+ var enabledButtons = ['closemobile', 'undo', 'redo',
'hamburger-tablet'];
// copy the first array
var items = toolbar.items.slice();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - chart2/source
chart2/source/controller/dialogs/res_BarGeometry.cxx |2
chart2/source/controller/dialogs/tp_ChartType.cxx| 568 -
chart2/source/inc/ChartResourceGroups.hxx| 600 +++
chart2/source/inc/res_BarGeometry.hxx|7
4 files changed, 606 insertions(+), 571 deletions(-)
New commits:
commit 15487a6451ae854963d7770ef412c6ffb4c51e71
Author: Muhammet Kara
AuthorDate: Mon Oct 28 10:02:23 2019 +0300
Commit: Muhammet Kara
CommitDate: Mon Oct 28 19:56:21 2019 +0100
chart2: Separate ChartResourceGroups to reuse
Change-Id: I0ca2ea9cd520013250faaba0e17e713da1e6fca3
Reviewed-on: https://gerrit.libreoffice.org/81581
Reviewed-by: Muhammet Kara
Tested-by: Muhammet Kara
diff --git a/chart2/source/controller/dialogs/res_BarGeometry.cxx
b/chart2/source/controller/dialogs/res_BarGeometry.cxx
index d067ae711978..c5f358d0d33b 100644
--- a/chart2/source/controller/dialogs/res_BarGeometry.cxx
+++ b/chart2/source/controller/dialogs/res_BarGeometry.cxx
@@ -17,7 +17,7 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
-#include "res_BarGeometry.hxx"
+#include
#include
#include
#include
diff --git a/chart2/source/controller/dialogs/tp_ChartType.cxx
b/chart2/source/controller/dialogs/tp_ChartType.cxx
index bec21d752cf1..74b3c610d5b0 100644
--- a/chart2/source/controller/dialogs/tp_ChartType.cxx
+++ b/chart2/source/controller/dialogs/tp_ChartType.cxx
@@ -18,11 +18,12 @@
*/
#include "tp_ChartType.hxx"
+#include
#include
#include
#include
#include
-#include "res_BarGeometry.hxx"
+#include
#include
#include
#include
@@ -38,571 +39,6 @@
namespace chart
{
-using namespace ::com::sun::star;
-using namespace ::com::sun::star::chart2;
-
-enum {
-POS_3DSCHEME_SIMPLE= 0,
-POS_3DSCHEME_REALISTIC = 1
-};
-
-class Dim3DLookResourceGroup : public ChangingResource
-{
-public:
-explicit Dim3DLookResourceGroup(weld::Builder* pBuilder);
-
-void showControls( bool bShow );
-
-void fillControls( const ChartTypeParameter& rParameter );
-void fillParameter( ChartTypeParameter& rParameter );
-
-private:
-DECL_LINK( Dim3DLookCheckHdl, weld::ToggleButton&, void );
-DECL_LINK( SelectSchemeHdl, weld::ComboBox&, void );
-
-private:
-std::unique_ptr m_xCB_3DLook;
-std::unique_ptr m_xLB_Scheme;
-};
-
-Dim3DLookResourceGroup::Dim3DLookResourceGroup(weld::Builder* pBuilder)
-: ChangingResource()
-, m_xCB_3DLook(pBuilder->weld_check_button("3dlook"))
-, m_xLB_Scheme(pBuilder->weld_combo_box("3dscheme"))
-{
-m_xCB_3DLook->connect_toggled( LINK( this, Dim3DLookResourceGroup,
Dim3DLookCheckHdl ) );
-m_xLB_Scheme->connect_changed( LINK( this, Dim3DLookResourceGroup,
SelectSchemeHdl ) );
-}
-
-void Dim3DLookResourceGroup::showControls( bool bShow )
-{
-m_xCB_3DLook->show(bShow);
-m_xLB_Scheme->show(bShow);
-}
-
-void Dim3DLookResourceGroup::fillControls( const ChartTypeParameter&
rParameter )
-{
-m_xCB_3DLook->set_active(rParameter.b3DLook);
-m_xLB_Scheme->set_sensitive(rParameter.b3DLook);
-
-if( rParameter.eThreeDLookScheme == ThreeDLookScheme_Simple )
-m_xLB_Scheme->set_active(POS_3DSCHEME_SIMPLE);
-else if( rParameter.eThreeDLookScheme == ThreeDLookScheme_Realistic )
-m_xLB_Scheme->set_active(POS_3DSCHEME_REALISTIC);
-else
-m_xLB_Scheme->set_active(-1);
-}
-
-void Dim3DLookResourceGroup::fillParameter( ChartTypeParameter& rParameter )
-{
-rParameter.b3DLook = m_xCB_3DLook->get_active();
-const int nPos = m_xLB_Scheme->get_active();
-if( nPos == POS_3DSCHEME_SIMPLE )
-rParameter.eThreeDLookScheme = ThreeDLookScheme_Simple;
-else if( nPos == POS_3DSCHEME_REALISTIC )
-rParameter.eThreeDLookScheme = ThreeDLookScheme_Realistic;
-else
-rParameter.eThreeDLookScheme = ThreeDLookScheme_Unknown;
-}
-
-IMPL_LINK_NOARG(Dim3DLookResourceGroup, Dim3DLookCheckHdl,
weld::ToggleButton&, void)
-{
-if(m_pChangeListener)
-m_pChangeListener->stateChanged(this);
-}
-
-IMPL_LINK_NOARG(Dim3DLookResourceGroup, SelectSchemeHdl, weld::ComboBox&, void)
-{
-if(m_pChangeListener)
-m_pChangeListener->stateChanged(this);
-}
-
-class SortByXValuesResourceGroup : public ChangingResource
-{
-public:
-explicit SortByXValuesResourceGroup(weld::Builder* pBuilder);
-
-void showControls( bool bShow );
-
-void fillControls( const ChartTypeParameter& rParameter );
-void fillParameter( ChartTypeParameter& rParameter );
-
-private:
-DECL_LINK(SortByXValuesCheckHdl, weld::ToggleButton&, void);
-
-private:
-std::unique_ptr m_xCB_XValueSorting;
-};
-
-SortByXValuesResourceGroup::SortByXValuesResourceGroup(weld::Builder* pBuilder)
-: ChangingResource()
-, m_xCB_XValueSorting(pBuilder->weld_check_button("sort"))
-{
-m_xCB_XValueSorting->connect_toggled(LINK(this,
SortByXValuesResourceGroup, SortByXValuesCheckHdl));
-}
-
-void
[Libreoffice-commits] core.git: sc/source
sc/source/filter/lotus/op.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit b04109027abc76b56a33f471f4cc0a9420ee4f29
Author: Caolán McNamara
AuthorDate: Mon Oct 28 14:00:02 2019 +
Commit: Caolán McNamara
CommitDate: Mon Oct 28 19:53:45 2019 +0100
cid#1448338 silence Untrusted value as argument
Change-Id: I8adc878b3ddb11940f5aadd6cf3d1738eaebbce2
Reviewed-on: https://gerrit.libreoffice.org/81609
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/source/filter/lotus/op.cxx b/sc/source/filter/lotus/op.cxx
index b59550f80338..5ec588ff7d84 100644
--- a/sc/source/filter/lotus/op.cxx
+++ b/sc/source/filter/lotus/op.cxx
@@ -591,7 +591,7 @@ void OP_SheetName123(LotusContext& rContext, SvStream&
rStream, sal_uInt16 nLeng
if (!ValidTab(nSheetNum))
return;
-
+// coverity[tainted_data] - ValidTab has sanitized nSheetNum
rContext.pDoc->MakeTable(nSheetNum);
if (!sSheetName.empty())
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: What's the status of using Glade .ui files in extensions?
I recently wrote an extension which allows you to use the XDG dialog system (with the associated GUI design tools in LibreOffice) in panels (and theoretically other areas of the LO UI. It at least addresses the issue of GUI design and internationalisation pretty well. Take a look at the following and see if they help you:- https://gitlab.com/muishkin/mwnci---deep-spreadsheets- https://gitlab.com/muishkin/mwnci---deep-spreadsheets/blob/master/docs/OfficeInterface.md#repurposing-the-xdg-dialog-system Of course this is all in Java but it could be repurposed using any supported LO extension language. Let me know if you have any questions. On Mon, 2019-10-28 at 17:12 +0100, Thorsten Behrens wrote: > LRN wrote: > > I see. Okay then, i'll try to make do without this feature. > The feature per se would be very useful though; not sure if there's away > around the compatibility > issue. > @Bubli: was there some feature branch somewhere still, for people > tolook/continue with? > Cheers, > -- Thorsten___LibreOffice mailing > listlibreoff...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/libreoffice -- Thanks, Rob ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 622465526cb0832145f2d0c1a2669f941b060273 Author: Olivier Hallot AuthorDate: Mon Oct 28 13:08:41 2019 -0300 Commit: Gerrit Code Review CommitDate: Mon Oct 28 19:44:24 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' - Add screenhshot for Hyperink Mail help page Use kde5 breeze theme Change-Id: I9976779b3a6455c42a4a70c68060982ad35de3e2 Reviewed-on: https://gerrit.libreoffice.org/81617 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 66427db0dc12..2342e79f1a7f 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 66427db0dc12b97bd60385b57887aa37f829a122 +Subproject commit 2342e79f1a7f468098da0a32912a7bbf1d556a01 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Package_html_media.mk source/media source/text
Package_html_media.mk |4 +++ source/media/screenshots/cui/ui/hyperlinkmailpage/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/af/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/am/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/ar/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/as/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/ast/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/be/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/bg/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/bn-IN/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/bn/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/bo/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/br/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/brx/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/bs/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/ca-valencia/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/ca/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/cs/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/cy/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/da/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/de/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/dgo/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/dsb/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/dz/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/el/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/en-GB/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/en-ZA/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/eo/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/es/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/et/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/eu/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/fa/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/fi/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/fr/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/fy/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/ga/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/gd/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/gl/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/gu/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/gug/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/he/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/hi/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/hr/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/hsb/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/hu/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/id/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/is/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/it/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/ja/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/ka/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/kab/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/kk/HyperlinkMailPage.png |binary source/media/screenshots/cui/ui/hyperlinkmailpage/km/HyperlinkMailPage.png |binary
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit eafea7214776d2e38b242a1363f66365e8444f57 Author: Olivier Hallot AuthorDate: Mon Oct 28 12:49:07 2019 -0300 Commit: Gerrit Code Review CommitDate: Mon Oct 28 19:29:41 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' - Add screenshot for hyperlink internet help page Use kde5 breeze theme Change-Id: I138474c651c198754871cac87fec399f8ff9e368 Reviewed-on: https://gerrit.libreoffice.org/81614 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index f42a9a7b437f..66427db0dc12 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit f42a9a7b437fa3b7edda4499358ad2cf4fd4bb46 +Subproject commit 66427db0dc12b97bd60385b57887aa37f829a122 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit dca24709d146abd9d6aa60d850989dd8d3f6bcbf Author: Olivier Hallot AuthorDate: Mon Oct 28 08:36:38 2019 -0300 Commit: Gerrit Code Review CommitDate: Mon Oct 28 19:29:08 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' - Add screeshot for Hyperlink Doc page Use kde5 breeze theme Change-Id: I96b8e60f0ab5459c0c57ac0c187bb6f5e0840cd6 Reviewed-on: https://gerrit.libreoffice.org/81601 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 4f5938e7cbe1..f42a9a7b437f 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 4f5938e7cbe1511be74820d4c55a9a9a9640b89d +Subproject commit f42a9a7b437fa3b7edda4499358ad2cf4fd4bb46 commit 57a9a9eb6f6780f8ab16b0bb1f6a148da65f4d50 Author: Olivier Hallot AuthorDate: Mon Oct 28 07:22:19 2019 -0300 Commit: Gerrit Code Review CommitDate: Mon Oct 28 19:28:35 2019 +0100 Update git submodules * Update helpcontent2 from branch 'master' - Add screenhot in Font effects Help page Use kde5 breeze theme Change-Id: I3e8d7cc5358f4811c74af9675382a7acca9aa808 Reviewed-on: https://gerrit.libreoffice.org/81595 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 3f8a68dca7c0..4f5938e7cbe1 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 3f8a68dca7c0f54616b104e033a681a3468aea3a +Subproject commit 4f5938e7cbe1511be74820d4c55a9a9a9640b89d ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: AllLangHelp_shared.mk Package_html_media.mk source/media source/text
AllLangHelp_shared.mk |1 Package_html_media.mk |4 source/media/screenshots/cui/ui/effectspage/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/af/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/am/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/ar/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/as/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/ast/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/be/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/bg/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/bn-IN/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/bn/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/bo/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/br/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/brx/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/bs/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/ca-valencia/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/ca/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/cs/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/cy/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/da/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/de/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/dgo/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/dsb/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/dz/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/el/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/en-GB/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/en-ZA/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/eo/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/es/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/et/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/eu/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/fa/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/fi/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/fr/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/fy/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/ga/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/gd/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/gl/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/gu/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/gug/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/he/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/hi/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/hr/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/hsb/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/hu/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/id/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/is/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/it/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/ja/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/ka/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/kab/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/kk/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/km/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/kmr-Latn/EffectsPage.png|binary source/media/screenshots/cui/ui/effectspage/kn/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/ko/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/kok/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/ks/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/lb/EffectsPage.png |binary source/media/screenshots/cui/ui/effectspage/lo/EffectsPage.png |binary
[Libreoffice-bugs] [Bug 128436] Range for Name forced to lowercase
https://bugs.documentfoundation.org/show_bug.cgi?id=128436 --- Comment #2 from Oliver Brinzing --- Created attachment 155375 --> https://bugs.documentfoundation.org/attachment.cgi?id=155375=edit screenshot -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128430] Field size is too long when inserting in the header
https://bugs.documentfoundation.org/show_bug.cgi?id=128430 Buovjaga changed: What|Removed |Added CC||todven...@suomi24.fi Resolution|WORKSFORME |INVALID -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48546] PRINTING: Frames text isn't aligned right
https://bugs.documentfoundation.org/show_bug.cgi?id=48546 --- Comment #13 from Michael Velten --- I reported this bug 2012-04-11 and it is still alive, that was the Reason I moved back to Microsoft Word/Office as my primary Text Editor. I reported many other Bugs which are all not fixed, til today. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108383] [META] Borders dialog tab bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108383 Buovjaga changed: What|Removed |Added Depends on||128431 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=128431 [Bug 128431] Synchronize padding in header borders it is not working -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128431] Synchronize padding in header borders it is not working
https://bugs.documentfoundation.org/show_bug.cgi?id=128431 Buovjaga changed: What|Removed |Added Blocks||108383 CC||durgapriyanka.a...@gmail.co ||m, todven...@suomi24.fi Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Keywords||bibisectRequest, regression --- Comment #3 from Buovjaga --- Repro on Win and Linux Version: 6.4.0.0.alpha1+ (x64) Build ID: 7c6226bee72805db7f0e567ca9f06c786a7d0da2 CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; Locale: fi-FI (fi_FI); UI-Language: en-US Calc: threaded Arch Linux 64-bit Version: 6.4.0.0.alpha1+ Build ID: e70ccc06094bec12d1947328b98ea040b46d08fc CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: kf5; Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US Calc: threaded Built on 28 October 2019 (In reply to Durgapriyanka from comment #2) > Thank you for reporting the bug. I cannot reproduce the bug in > > Version: 6.3.0.0.alpha0+ > Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87 > CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; > TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04 > Locale: en-US (en_US); UI-Language: en-US > Calc: threaded Please install a fresh version. The version from January 2019 is quite old and it is not good to use it for testing. You can use a build produced by this box: https://dev-builds.libreoffice.org/daily/master/Win-x86_64@tb77-TDF/ Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108383 [Bug 108383] [META] Borders dialog tab bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128436] Range for Name forced to lowercase
https://bugs.documentfoundation.org/show_bug.cgi?id=128436 Oliver Brinzing changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||oliver.brinz...@gmx.de --- Comment #1 from Oliver Brinzing --- (In reply to Jonny Grant from comment #0) > If if Insert->Chart by selecting B2:B5 you need to manually enter the > chart's "Range for Name" needs to be manually typed, and when it is - Calc > changes it to lowercase, and removes any spaces. confirming, but IMHO you need to enter an absolute cell address for "Range for Name" and not string title -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48546] PRINTING: Frames text isn't aligned right
https://bugs.documentfoundation.org/show_bug.cgi?id=48546 --- Comment #12 from Xavier Van Wijmeersch --- Can reproduce with. Text cutoff still happening. Version: 6.4.0.0.alpha1+ Build ID: 2d8efd1afe03a4009600e914910144b70982e98d CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: nl-BE (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128438] New: Writer: Cannot remove tab marks in paragraph using the Paragraph dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=128438 Bug ID: 128438 Summary: Writer: Cannot remove tab marks in paragraph using the Paragraph dialog Product: LibreOffice Version: 6.3.2.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sombrag...@sombragris.org System info from "About" box: Version: 6.3.2.2 Build ID: SlackBuild for 6.3.2 by Eric Hameleers CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: kde5; Locale: es-PY (es_PY.UTF-8); UI-Language: en-US Calc: threaded When opening a document where one or more paragraphs have tab marks, selecting those paragraphs, and then opening the menu Format > Paragraph and clicking on the "Tabs" tab, either selecting the particular tab mark and then clicking on the "Delete" button, or even clicking "Delete All" does not work. The tab mark is still there. The only way to remove the tab mark is to reapply the paragraph style, when such tab mark is not part of the style definition. A fix would be greatly appreciated. Thanks for making Libreoffice available! Eduardo Sanchez Asunción Paraguay South America -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128434] Memory leak when converting many documents
https://bugs.documentfoundation.org/show_bug.cgi?id=128434 Oliver Brinzing changed: What|Removed |Added Component|sdk |framework Keywords||regression Status|UNCONFIRMED |NEW Version|6.3.2.2 release |6.2.8.2 release Ever confirmed|0 |1 Blocks||122652 CC||oliver.brinz...@gmx.de --- Comment #2 from Oliver Brinzing --- i can confirm a growing memory consumption with: Version: 6.2.8.2 (x64) Build-ID: f82ddfca21ebc1e222a662a32b25c0c9d20169ee CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: after ~100 conversion: ~400 mb (growing) with: Version: 6.1.6.3 (x64) Build-ID: 5896ab1714085361c45cf540f76f60673dd96a72 CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; Gebietsschema: de-DE (de_DE); Calc: after after ~100 conversion: ~190 mb (constant) Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=122652 [Bug 122652] [META] Memory problems in LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122652] [META] Memory problems in LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=122652 Oliver Brinzing changed: What|Removed |Added Depends on||128434 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=128434 [Bug 128434] Memory leak when converting many documents -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
