[Libreoffice-bugs] [Bug 128837] Export as PDF: Index headings are not shown as elements in navigation area / document structure of PDF viewer
https://bugs.documentfoundation.org/show_bug.cgi?id=128837 --- Comment #4 from Jens Radloff --- Thanks for your revised odt file. Yes, that's how I would like to have my PDF files if I export your revised odt file. Although the "Table of Contents" entry should also be displayed in the navigation area / document structure of the PDF file, too, it is still missing. But let me first focus on this here: > Modified the Style for Table of Figures and Bibliography > -- changing the Outline Level from Text Body to Level 1. I compared the TOC settings, the Table of Figures settings and the Bibliography settings in my original odt file with your revised odt file, I cannot see any differences. According to me, it is only possible to change the Outline Level from Text Body to Level 1 in the TOC settings, on the "Type" tab => "Assign styles" button, but I already changed there the level settings for "Bibliography Index Heading" and "Figure Index Heading" to Level 1 in my original file. The Table of Figures settings seem to be identical in both your revised and my original odt file. The Bibliography settings seem to be identical in both your revised and my original odt file. So I do not know which changes you made in your revised odt file. I am using Linux Debian 10.2, if this is of any importance. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=10 Bug 10 depends on bug 102520, which changed state. Bug 102520 Summary: Bad docx table row color conversion https://bugs.documentfoundation.org/show_bug.cgi?id=102520 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102520] Bad docx table row color conversion
https://bugs.documentfoundation.org/show_bug.cgi?id=102520 Gabor Kelemen changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #6 from Gabor Kelemen --- *** This bug has been marked as a duplicate of bug 123189 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102520] Bad docx table row color conversion
https://bugs.documentfoundation.org/show_bug.cgi?id=102520 --- Comment #5 from Gabor Kelemen --- Created attachment 155881 --> https://bugs.documentfoundation.org/attachment.cgi?id=155881=edit Screenshot of the example file in Word and Writer 6.3 This got solved in 6.3. Bibisected with bibisect-win32-6.3 to: author László Németh2019-02-05 23:13:23 +0100 committer László Németh2019-02-06 00:38:21 +0100 commit 82fb7f9f90a3ba9d53b3412124e513aa78ddca10 (patch) tdf#123189 DOCX import: skip table bkground color https://cgit.freedesktop.org/libreoffice/core/commit/?id=82fb7f9f90a3ba9d53b3412124e513aa78ddca10 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128837] Export as PDF: Index headings are not shown as elements in navigation area / document structure of PDF viewer
https://bugs.documentfoundation.org/show_bug.cgi?id=128837 sdc.bla...@youmail.dk changed: What|Removed |Added CC||sdc.bla...@youmail.dk --- Comment #3 from sdc.bla...@youmail.dk --- Created attachment 155879 --> https://bugs.documentfoundation.org/attachment.cgi?id=155879=edit revised version of .odt file Version: 6.4.0.0.alpha1 (x64) Build ID: cc57df8f942f239d29cb575ea5a7cb01405db787 CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; Locale: en-US (en_DK); UI-Language: en-US 1. With the attachment 155876: Only Heading 1 was shown the PDF viewer. (which also seems to be the case with the initial report. 2. Modified the Style for Table of Figures and Bibliography -- changing the Outline Level from Text Body to Level 1. Now all three headers are shown with the PDF export. Will attached the revised .odt file If that was what was desired, then maybe this is notabug? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Changes to 'feature/spellig_popup_SID'
New branch 'feature/spellig_popup_SID' available with the following commits: commit 84ac3db7eb56f978f4485d9582b5bb273b8e20d0 Author: Tamás Zolnai Date: Sat Nov 16 15:30:41 2019 +0100 SpellingPopup: Convert "IgnoreAll" menu item to use a slot ID. When the popup is in spelling mode. "IgnoreAll_Spelling" rule triggers this method. Change-Id: Ia1e1877f8501beff29f09bc33621c8f03008b7e8 commit 62d8dd32dad5010876e325346ea3268410ff530c Author: Tamás Zolnai Date: Sat Nov 16 15:17:57 2019 +0100 SpellingPopup: Convert "IgnoreAll" menu item to use a slot ID. When the popup is in grammar mode. "IgnoreAll_Grammar" rule triggers this method. When openning the spelling popup we have the suspicious text selected, so we don't need the mouse position to apply the changes. I updated GetGrammarCorrection() method accordingly. Change-Id: Iaf86544ea5f7dbc4afa2889772a5a38c5fd5707e commit e1d05ea65a0b3af4cb4291338e2ed452bb948be3 Author: Tamás Zolnai Date: Sat Nov 16 15:14:20 2019 +0100 SpellingPopup: Convert "Ignore" menu item to use a slot ID. Introduced a new slot id SID_APPLY_SPELLING, which can be used to apply any spelling / grammar related changes (e.g. ignore, ignore all, replace with suggestion, add to dictionary). In this commit, only the simple ignore is implemented. Change-Id: I06ab84efeb955cc02ce3ff531bd8b5c20ddced9e commit ddb2fcba27bf6408d754113de5683afc7f056df6 Author: Tamás Zolnai Date: Sat Nov 16 13:30:30 2019 +0100 SpellingPopup: Move setting UPN_IS_GRAMMAR_INTERACTIVE to the constructor. Change-Id: Ief5470e0a61f0ca40549ab6d3768c795c3f04510 commit 07cfd38f6710dfd0fb24f84efb5de706637d2cde Author: Tamás Zolnai Date: Sat Nov 16 11:13:01 2019 +0100 SpellingPopup: lok: Also hide the add menu Change-Id: Ic6b10d579fe1fb0afe5e80244e84ed456dc6cc87 commit 562d14e0955fa3bf4304c18bb90238ec8a7176e0 Author: Tamás Zolnai Date: Sat Nov 16 10:46:28 2019 +0100 SpellingPopup: Remove unused variables Change-Id: I3cb3b128ec54f82381bf6f0c17401a5d5fb58a96 commit ad20d25635293ec076bc31e3c34ba216c0254382 Author: Tamás Zolnai Date: Fri Nov 15 20:47:57 2019 +0100 SpellingPopup: Convert selection language items to use slot id Change-Id: I10a89d7efa957e6b94e793158983c5acf623e511 commit 19a1f3e83af6d42b20ea971d5c7a3ebb34b6beff Author: Tamás Zolnai Date: Fri Nov 15 20:42:53 2019 +0100 SpellingPopup: Convert paragraph language items to use slot id Change-Id: I36df4777b408f9defd883d49413847152f6b496f commit 55301dc23decbc0b19173ecdbca838cdaf69336c Author: Tamás Zolnai Date: Fri Nov 15 18:11:40 2019 +0100 SpellingPopup: Convert char dialog related items to use slot id After this change we can make sw_CharDialog() a local function. Change-Id: I34b15fccaed07b5d89f63a69da8c870fff0e9b14 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128820] SAXException: [word/document.xml line 20] when you try to open a document from Word 2007-365 (*.docx) format created with LO with a image copy from Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=128820 Mike Kaganski changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | --- Comment #3 from Mike Kaganski --- This is not a regression after that commit (if regression at all). As expected, that commit started to warn on some corrupted files that were silently processed before (throwing part of the stream away without warning). Accepting the warning would produce exactly the same (partial) result as before. https://gerrit.libreoffice.org/82980 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128838] New: Auto-redact: uneditable target
https://bugs.documentfoundation.org/show_bug.cgi?id=128838 Bug ID: 128838 Summary: Auto-redact: uneditable target Product: LibreOffice Version: 6.4.0.0.beta1+ Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ml.nishibori.kiyot...@gmail.com Description: Predefined-type target for auto-redact cannot be edited correctly: it can be changed to text-type one. Steps to Reproduce: 1. add a new target with following settings: Type: Predefined Content: Credit card number 2. Select the target and click "Edit Taget" button. 3. Change Type: from Predefind to Text. Actual Results: The Content field is not switched to text box, but still the dropdown-list and no text can be entered. Moreover, "All fields are required" is shown as the warning if OK is clicked. Expected Results: The Content field is switched from the dropdown-list to text box and some text can be entered. Reproducible: Always User Profile Reset: No Additional Info: Version: 6.4.0.0.beta1+ Build ID: 876303943113bb7fa09c3b344a832f714ac2d8e3 CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: gtk3; Locale: ja-JP (ja_JP.UTF-8); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128837] Export as PDF: Index headings are not shown as elements in navigation area / document structure of PDF viewer
https://bugs.documentfoundation.org/show_bug.cgi?id=128837 --- Comment #2 from Jens Radloff --- Created attachment 155878 --> https://bugs.documentfoundation.org/attachment.cgi?id=155878=edit Screenshot of PDF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128837] Export as PDF: Index headings are not shown as elements in navigation area / document structure of PDF viewer
https://bugs.documentfoundation.org/show_bug.cgi?id=128837 --- Comment #1 from Jens Radloff --- Created attachment 155877 --> https://bugs.documentfoundation.org/attachment.cgi?id=155877=edit Generated PDF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128836] Cannot toggle edit mode
https://bugs.documentfoundation.org/show_bug.cgi?id=128836 --- Comment #1 from sdc.bla...@youmail.dk --- Additional information. 1. Open a document with a Section that has a Link (to another file) 2. A popup window asks if the link to the external data should be updated. (Answer either yes or no, does not matter). 3. The document is now opened with the possibility to toggle edit mode. 4. Open a New Document. It still does not offer toggle on edit mode. Tested only with: Version: 6.4.0.0.alpha1 (x64) Build ID: cc57df8f942f239d29cb575ea5a7cb01405db787 CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; Locale: en-US (en_DK); UI-Language: en-US -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101830] Empty input fields completely invisible
https://bugs.documentfoundation.org/show_bug.cgi?id=101830 --- Comment #12 from Jan-Marek Glogowski --- Still happens with current master as of today (6.5 to be). Version: 6.5.0.0.alpha0+ Build-ID: 9f51d0bfd4cf0ad1a019254ecbc04912f702ee6e CPU-Threads: 8; BS: Linux 4.19; UI-Render: Standard; VCL: kf5; Gebietsschema: de-DE (de_DE.UTF-8); UI-Sprache: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128837] New: Export as PDF: Index headings are not shown as elements in navigation area / document structure of PDF viewer
https://bugs.documentfoundation.org/show_bug.cgi?id=128837 Bug ID: 128837 Summary: Export as PDF: Index headings are not shown as elements in navigation area / document structure of PDF viewer Product: LibreOffice Version: 6.2.8.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: plixp...@yahoo.de Created attachment 155876 --> https://bugs.documentfoundation.org/attachment.cgi?id=155876=edit Index headings in document structure of PDF If an odt. document contains - a Table of Contents - a Table of Figures and - a Bibliography, and you export this file as a PDF, with the options "Tagged PDF (add document structure)" and "Export bookmarks", the navigation area / document structure in the generated PDF file does not contain the elements with the names - "Table of Contents" - "Table of Figures" and - "Bibliography". My PDF viewer is Okular. The same behaviour occurs if the PDF file is viewed in Firefox. This behaviour probably affects all other indexes. For a demonstration refer to the three attached files. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/sidebar/ChartTypePanel.hxx |6 -- 1 file changed, 6 deletions(-) New commits: commit d0ee28168077099ac892acf84996af4af9e6 Author: Muhammet Kara AuthorDate: Fri Nov 15 19:39:47 2019 +0300 Commit: Muhammet Kara CommitDate: Sat Nov 16 15:02:21 2019 +0100 ChartTypePanel: Remove unused vars Change-Id: I6a19fa269efaf008345b48341d1c501e1c7e7d17 Reviewed-on: https://gerrit.libreoffice.org/82244 Tested-by: Jenkins CollaboraOffice Reviewed-by: Muhammet Kara Reviewed-on: https://gerrit.libreoffice.org/82812 Tested-by: Jenkins diff --git a/chart2/source/controller/sidebar/ChartTypePanel.hxx b/chart2/source/controller/sidebar/ChartTypePanel.hxx index 91d4d71220a9..a37df639e356 100644 --- a/chart2/source/controller/sidebar/ChartTypePanel.hxx +++ b/chart2/source/controller/sidebar/ChartTypePanel.hxx @@ -109,12 +109,6 @@ private: DECL_LINK(SelectMainTypeHdl, weld::ComboBox&, void); DECL_LINK(SelectSubTypeHdl, SvtValueSet*, void); -//ui controls -//std::unique_ptr mpChartTypeLabel; -//std::unique_ptr m_pMainTypeList; -//VclPtr m_pMainTypeList; -//VclPtr m_pSubTypeList; - vcl::EnumContext maContext; css::uno::Reference mxModel; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128836] New: Cannot toggle edit mode
https://bugs.documentfoundation.org/show_bug.cgi?id=128836 Bug ID: 128836 Summary: Cannot toggle edit mode Product: LibreOffice Version: 6.3.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk 1. Open New Document 2 Add 'Edit Mode' and 'Read Only Mode' to Toolbar 3. Edit menu Result: 'Edit mode' and 'Read Only Mode" are grayed out in Toolbar. 'Edit mode' is grayed out in Edit menu Expect: Possible to toggle edit mode. Version: 6.3.3.2 (x64) Build ID: a64200df03143b798afd1ec74a12ab50359878ed CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; Locale: da-DK (en_DK); UI-Language: en-US Calc: threaded and Version: 6.4.0.0.alpha1 (x64) Build ID: cc57df8f942f239d29cb575ea5a7cb01405db787 CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; Locale: en-US (en_DK); UI-Language: en-US Calc: CL (also tried in safe mode, reset to factory setting, same result) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/unocore/unodraw.cxx |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) New commits: commit 84322944980f6e2f9d4a531de7a6803797156968 Author: Mike Kaganski AuthorDate: Sat Nov 16 11:19:38 2019 +0200 Commit: Mike Kaganski CommitDate: Sat Nov 16 14:51:32 2019 +0100 Simplify sequence initialization Change-Id: I332cf55883bab679c395b9643d54e558ce0c1c64 Reviewed-on: https://gerrit.libreoffice.org/82974 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/sw/source/core/unocore/unodraw.cxx b/sw/source/core/unocore/unodraw.cxx index 35d35b635ee0..c73614a61bc7 100644 --- a/sw/source/core/unocore/unodraw.cxx +++ b/sw/source/core/unocore/unodraw.cxx @@ -63,6 +63,8 @@ #include #include #include +#include +#include #include #include #include @@ -2146,9 +2148,8 @@ uno::Sequence< OUString > SwXShape::getSupportedServiceNames() uno::Sequence< OUString > aSeq; if (SvxShape* pSvxShape = GetSvxShape()) aSeq = pSvxShape->getSupportedServiceNames(); -aSeq.realloc(aSeq.getLength() + 1); -aSeq.getArray()[aSeq.getLength() - 1] = "com.sun.star.drawing.Shape"; -return aSeq; +return comphelper::concatSequences( +aSeq, comphelper::OUStringLiteralList({ "com.sun.star.drawing.Shape" })); } SvxShape* SwXShape::GetSvxShape() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/sidebar/ChartTypePanel.cxx | 10 +- chart2/source/controller/sidebar/ChartTypePanel.hxx |2 +- 2 files changed, 6 insertions(+), 6 deletions(-) New commits: commit 6de6c21de8278dec88b15a2482a4a034c782d5f4 Author: Muhammet Kara AuthorDate: Fri Nov 15 19:31:58 2019 +0300 Commit: Muhammet Kara CommitDate: Sat Nov 16 14:20:38 2019 +0100 Rename getCurrentParamter() as getCurrentParameter() Change-Id: I0116b4526fea377130b1d1e101d30b3107af3c81 Reviewed-on: https://gerrit.libreoffice.org/82243 Tested-by: Jenkins CollaboraOffice Reviewed-by: Muhammet Kara Reviewed-on: https://gerrit.libreoffice.org/82811 Tested-by: Jenkins diff --git a/chart2/source/controller/sidebar/ChartTypePanel.cxx b/chart2/source/controller/sidebar/ChartTypePanel.cxx index f58bdfd53264..6de33352b051 100644 --- a/chart2/source/controller/sidebar/ChartTypePanel.cxx +++ b/chart2/source/controller/sidebar/ChartTypePanel.cxx @@ -172,7 +172,7 @@ IMPL_LINK_NOARG(ChartTypePanel, SelectSubTypeHdl, SvtValueSet*, void) { if (m_pCurrentMainType) { -ChartTypeParameter aParameter(getCurrentParamter()); +ChartTypeParameter aParameter(getCurrentParameter()); m_pCurrentMainType->adjustParameterToSubType(aParameter); fillAllControls(aParameter, false); commitToModel(aParameter); @@ -317,7 +317,7 @@ uno::Reference ChartTypePanel::getCurrentTempla { if (m_pCurrentMainType && m_xChartModel.is()) { -ChartTypeParameter aParameter(getCurrentParamter()); +ChartTypeParameter aParameter(getCurrentParameter()); m_pCurrentMainType->adjustParameterToSubType(aParameter); uno::Reference xTemplateManager( m_xChartModel->getChartTypeManager(), uno::UNO_QUERY); @@ -371,7 +371,7 @@ void ChartTypePanel::fillAllControls(const ChartTypeParameter& rParameter, m_nChangingCalls--; } -ChartTypeParameter ChartTypePanel::getCurrentParamter() const +ChartTypeParameter ChartTypePanel::getCurrentParameter() const { ChartTypeParameter aParameter; aParameter.nSubTypeIndex = static_cast(m_xSubTypeList->GetSelectedItemId()); @@ -389,7 +389,7 @@ void ChartTypePanel::stateChanged() return; m_nChangingCalls++; -ChartTypeParameter aParameter(getCurrentParamter()); +ChartTypeParameter aParameter(getCurrentParameter()); if (m_pCurrentMainType) { m_pCurrentMainType->adjustParameterToSubType(aParameter); @@ -426,7 +426,7 @@ void ChartTypePanel::commitToModel(const ChartTypeParameter& rParameter) void ChartTypePanel::selectMainType() { -ChartTypeParameter aParameter(getCurrentParamter()); +ChartTypeParameter aParameter(getCurrentParameter()); if (m_pCurrentMainType) { diff --git a/chart2/source/controller/sidebar/ChartTypePanel.hxx b/chart2/source/controller/sidebar/ChartTypePanel.hxx index 394983e62f2a..91d4d71220a9 100644 --- a/chart2/source/controller/sidebar/ChartTypePanel.hxx +++ b/chart2/source/controller/sidebar/ChartTypePanel.hxx @@ -99,7 +99,7 @@ private: ChartTypeDialogController* getSelectedMainType(); void showAllControls(ChartTypeDialogController& rTypeController); void fillAllControls(const ChartTypeParameter& rParameter, bool bAlsoResetSubTypeList = true); -ChartTypeParameter getCurrentParamter() const; +ChartTypeParameter getCurrentParameter() const; virtual void stateChanged() override; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: comphelper/Library_comphelper.mk comphelper/source editeng/source include/comphelper sd/source svx/source
comphelper/Library_comphelper.mk |1 comphelper/source/misc/serviceinfohelper.cxx | 42 --- editeng/source/uno/unotext.cxx |9 ++-- editeng/source/uno/unotext2.cxx | 29 --- include/comphelper/OUStringLiteralList.hxx | 31 + include/comphelper/serviceinfohelper.hxx | 48 -- sd/source/ui/unoidl/unoobj.cxx | 14 +++ sd/source/ui/unoidl/unopage.cxx | 27 +++--- svx/source/unodraw/unoshap3.cxx | 49 +-- 9 files changed, 95 insertions(+), 155 deletions(-) New commits: commit 51eb969cb77f8b54681033f4959b15ce32116b56 Author: Mike Kaganski AuthorDate: Sat Nov 16 11:35:58 2019 +0200 Commit: Mike Kaganski CommitDate: Sat Nov 16 14:07:45 2019 +0100 Replace comphelper::ServiceInfoHelper::addToSequence Change-Id: I325e16fdf9bbbc6f2ba2d06c417da5eeb0d48023 Reviewed-on: https://gerrit.libreoffice.org/82975 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/comphelper/Library_comphelper.mk b/comphelper/Library_comphelper.mk index 6539844d3cf2..e0bf1a8574f5 100644 --- a/comphelper/Library_comphelper.mk +++ b/comphelper/Library_comphelper.mk @@ -128,7 +128,6 @@ $(eval $(call gb_Library_add_exception_objects,comphelper,\ comphelper/source/misc/SelectionMultiplex \ comphelper/source/misc/sequenceashashmap \ comphelper/source/misc/servicedecl \ -comphelper/source/misc/serviceinfohelper \ comphelper/source/misc/sharedmutex \ comphelper/source/misc/simplefileaccessinteraction \ comphelper/source/misc/solarmutex \ diff --git a/comphelper/source/misc/serviceinfohelper.cxx b/comphelper/source/misc/serviceinfohelper.cxx deleted file mode 100644 index 59cb0ea60b2d.. --- a/comphelper/source/misc/serviceinfohelper.cxx +++ /dev/null @@ -1,42 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the "License"); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ - - -#include -#include - -namespace comphelper -{ - -/** this method adds a variable number of OUString to a given Sequence - */ -void ServiceInfoHelper::addToSequence( css::uno::Sequence< OUString >& rSeq, std::initializer_list services ) throw() -{ -sal_uInt32 nCount = rSeq.getLength(); - -rSeq.realloc( nCount + services.size() ); -OUString* pStrings = rSeq.getArray(); - -for( auto const & s: services ) -pStrings[nCount++] = s; -} - -} - -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/editeng/source/uno/unotext.cxx b/editeng/source/uno/unotext.cxx index 4796732b2c74..3abed7b474a5 100644 --- a/editeng/source/uno/unotext.cxx +++ b/editeng/source/uno/unotext.cxx @@ -45,8 +45,9 @@ #include #include #include +#include +#include #include -#include #include #include @@ -2163,9 +2164,9 @@ uno::Sequence< OUString > SAL_CALL SvxUnoTextBase::getSupportedServiceNames( ) uno::Sequence< OUString > SAL_CALL SvxUnoTextBase::getSupportedServiceNames_Static( ) { -uno::Sequence< OUString > aSeq( SvxUnoTextRangeBase::getSupportedServiceNames_Static() ); -comphelper::ServiceInfoHelper::addToSequence( aSeq, {"com.sun.star.text.Text"} ); -return aSeq; +return comphelper::concatSequences( +SvxUnoTextRangeBase::getSupportedServiceNames_Static(), +comphelper::OUStringLiteralList({ "com.sun.star.text.Text" })); } namespace diff --git a/editeng/source/uno/unotext2.cxx b/editeng/source/uno/unotext2.cxx index ba9c66f3c37f..1dbf6cfafc42 100644 --- a/editeng/source/uno/unotext2.cxx +++ b/editeng/source/uno/unotext2.cxx @@ -24,7 +24,8 @@ #include #include #include -#include +#include +#include #include using namespace ::cppu; @@ -362,13 +363,13 @@ OUString SAL_CALL SvxUnoTextContent::getImplementationName() uno::Sequence< OUString > SAL_CALL SvxUnoTextContent::getSupportedServiceNames() { -uno::Sequence< OUString > aSeq( SvxUnoTextRangeBase::getSupportedServiceNames() ); -comphelper::ServiceInfoHelper::addToSequence( aSeq, {"com.sun.star.style.ParagraphProperties", -
[Libreoffice-bugs] [Bug 128835] New: Changing Font embedding option on Font tab of Properties window that accessed from File - Properties menu does not change save and document modification status/ico
https://bugs.documentfoundation.org/show_bug.cgi?id=128835 Bug ID: 128835 Summary: Changing Font embedding option on Font tab of Properties window that accessed from File - Properties menu does not change save and document modification status/icons, when document already saved. Product: LibreOffice Version: 6.3.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: wast...@gmail.com Description: I create, edit, and save document. Then I check/select option for embedding font on Font tab of Properties of "doc name" window. I accessed it from File - Properties menu. After I change the options, I click OK. But the save icon is not change. LibreOffice Writer does not save the changes. Steps to Reproduce: 1. Edit ODT file, then save the file. 2. Click File - Properties menu. 3. Click Font tab. 4. Change the options for Font embedding. Toggle the check of all options for Font embedding. 5. Click OK. Actual Results: Save icon does not change. Document modification status icon on status bar does not change. then when the application closed, the file size is not changed. Expected Results: Save icon and document modification status icon should change into 'need to be saved' icons. So user knows that document needs to be saved. Then when saved, font that needed to be embedded is really already embedded; or font that needed to be removed is really removed from file (based on check or uncheck of options). So the file size changed. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128780] Hungarian translation error!
https://bugs.documentfoundation.org/show_bug.cgi?id=128780 Dieter Praas changed: What|Removed |Added Component|Writer |Localization CC||dgp-m...@gmx.de -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128684] FILEOPEN: Wrong rotation of text in custom shape
https://bugs.documentfoundation.org/show_bug.cgi?id=128684 Commit Notification changed: What|Removed |Added Whiteboard||target:6.5.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128684] FILEOPEN: Wrong rotation of text in custom shape
https://bugs.documentfoundation.org/show_bug.cgi?id=128684 --- Comment #3 from Commit Notification --- Tamas Bunth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/742f59eaa38a3f13b6110573b1428de45c55b035 tdf128684: Rotate text in not preset custom shape It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: oox/source sd/qa
oox/source/drawingml/customshapeproperties.cxx |2 + sd/qa/unit/data/pptx/tdf128684.pptx|binary sd/qa/unit/import-tests.cxx| 29 + 3 files changed, 31 insertions(+) New commits: commit 742f59eaa38a3f13b6110573b1428de45c55b035 Author: Tamas Bunth AuthorDate: Thu Nov 14 00:56:08 2019 +0100 Commit: Tamás Bunth CommitDate: Sat Nov 16 13:41:20 2019 +0100 tdf128684: Rotate text in not preset custom shape The TextPreRotateAngle property should be set in case of a not preset custom shape as well during ooxml import. Also add unit test for testing the TextPreRotateAngle property. Change-Id: Ib5b822286f8a78fe8398bf7e2014a36d7e0a24d5 Reviewed-on: https://gerrit.libreoffice.org/82643 Tested-by: Jenkins Reviewed-by: Tamás Bunth diff --git a/oox/source/drawingml/customshapeproperties.cxx b/oox/source/drawingml/customshapeproperties.cxx index df878d39eec3..2f4848088cc4 100644 --- a/oox/source/drawingml/customshapeproperties.cxx +++ b/oox/source/drawingml/customshapeproperties.cxx @@ -230,6 +230,8 @@ void CustomShapeProperties::pushToPropSet( aPropertyMap.setProperty( PROP_Type, OUString( "ooxml-non-primitive" )); aPropertyMap.setProperty( PROP_MirroredX, mbMirroredX ); aPropertyMap.setProperty( PROP_MirroredY, mbMirroredY ); +if( mnTextRotateAngle ) +aPropertyMap.setProperty( PROP_TextPreRotateAngle, mnTextRotateAngle ); // Note 1: If Equations are defined - they are processed using internal div by 360 coordinates // while if they are not, standard ooxml coordinates are used. // This size specifically affects scaling. diff --git a/sd/qa/unit/data/pptx/tdf128684.pptx b/sd/qa/unit/data/pptx/tdf128684.pptx new file mode 100755 index ..80a5f30568d3 Binary files /dev/null and b/sd/qa/unit/data/pptx/tdf128684.pptx differ diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx index 191592bbc592..3b50bce311ad 100644 --- a/sd/qa/unit/import-tests.cxx +++ b/sd/qa/unit/import-tests.cxx @@ -196,6 +196,7 @@ public: void testTdf77747(); void testTdf116266(); void testTdf126324(); +void testTdf128684(); bool checkPattern(sd::DrawDocShellRef const & rDocRef, int nShapeNumber, std::vector& rExpected); void testPatternImport(); @@ -311,6 +312,7 @@ public: CPPUNIT_TEST(testCropToShape); CPPUNIT_TEST(testTdf127964); CPPUNIT_TEST(testTdf106638); +CPPUNIT_TEST(testTdf128684); CPPUNIT_TEST_SUITE_END(); }; @@ -3006,6 +3008,33 @@ void SdImportTest::testTdf106638() CPPUNIT_ASSERT(aCharFontName != "Wingdings"); } + +void SdImportTest::testTdf128684() +{ +sd::DrawDocShellRef xDocShRef += loadURL(m_directories.getURLFromSrc("/sd/qa/unit/data/pptx/tdf128684.pptx"), PPTX); +uno::Reference xDoc(xDocShRef->GetDoc()->getUnoModel(), + uno::UNO_QUERY); +CPPUNIT_ASSERT(xDoc.is()); +uno::Reference xPage(xDoc->getDrawPages()->getByIndex(0), uno::UNO_QUERY); +CPPUNIT_ASSERT(xPage.is()); +uno::Reference xShape(getShape(0, xPage)); +CPPUNIT_ASSERT(xShape.is()); +uno::Any aAny = xShape->getPropertyValue("CustomShapeGeometry"); +CPPUNIT_ASSERT(aAny.hasValue()); +uno::Sequence aProps; +CPPUNIT_ASSERT(aAny >>= aProps); +sal_Int32 nRotateAngle = 0; +for( const auto& rProp : std::as_const(aProps) ) +{ +if( rProp.Name == "TextPreRotateAngle") +{ +rProp.Value >>= nRotateAngle; +} +} +CPPUNIT_ASSERT_EQUAL(static_cast(-90), nRotateAngle); +} + CPPUNIT_TEST_SUITE_REGISTRATION(SdImportTest); CPPUNIT_PLUGIN_IMPLEMENT(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/sidebar/ChartTypePanel.cxx |1 - chart2/source/controller/sidebar/ChartTypePanel.hxx |1 - 2 files changed, 2 deletions(-) New commits: commit b07db7a1694165113c8c8fb12eb632de7937c26f Author: Muhammet Kara AuthorDate: Fri Nov 15 19:22:28 2019 +0300 Commit: Muhammet Kara CommitDate: Sat Nov 16 13:11:59 2019 +0100 Remove unused var m_xChartTypeLabel Change-Id: I3de7eb4e438021f9522e581c60a84fb7fcc168c7 Reviewed-on: https://gerrit.libreoffice.org/82242 Tested-by: Jenkins CollaboraOffice Reviewed-by: Muhammet Kara Reviewed-on: https://gerrit.libreoffice.org/82810 Tested-by: Jenkins diff --git a/chart2/source/controller/sidebar/ChartTypePanel.cxx b/chart2/source/controller/sidebar/ChartTypePanel.cxx index d70a21bacad7..f58bdfd53264 100644 --- a/chart2/source/controller/sidebar/ChartTypePanel.cxx +++ b/chart2/source/controller/sidebar/ChartTypePanel.cxx @@ -80,7 +80,6 @@ ChartTypePanel::ChartTypePanel(vcl::Window* pParent, , m_pCurrentMainType(nullptr) , m_nChangingCalls(0) , m_aTimerTriggeredControllerLock(m_xChartModel) -, m_xChartTypeLabel(m_xBuilder->weld_label("lbl_chartType")) , m_xMainTypeList(m_xBuilder->weld_combo_box("cmb_chartType")) , m_xSubTypeList(new SvtValueSet(m_xBuilder->weld_scrolled_window("subtypewin"))) , m_xSubTypeListWin(new weld::CustomWeld(*m_xBuilder, "subtype", *m_xSubTypeList)) diff --git a/chart2/source/controller/sidebar/ChartTypePanel.hxx b/chart2/source/controller/sidebar/ChartTypePanel.hxx index c419a8f0b41e..394983e62f2a 100644 --- a/chart2/source/controller/sidebar/ChartTypePanel.hxx +++ b/chart2/source/controller/sidebar/ChartTypePanel.hxx @@ -139,7 +139,6 @@ private: TimerTriggeredControllerLock m_aTimerTriggeredControllerLock; -std::unique_ptr m_xChartTypeLabel; std::unique_ptr m_xMainTypeList; std::unique_ptr m_xSubTypeList; std::unique_ptr m_xSubTypeListWin; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/sidebar/ChartTypePanel.cxx | 18 ++ chart2/source/controller/sidebar/ChartTypePanel.hxx |2 +- 2 files changed, 11 insertions(+), 9 deletions(-) New commits: commit dbfa1f2fea43771d00f656ce6c2aff438889f2c5 Author: Muhammet Kara AuthorDate: Fri Nov 15 18:59:26 2019 +0300 Commit: Muhammet Kara CommitDate: Sat Nov 16 13:11:11 2019 +0100 Add SplineResourceGroup to ChartTypePanel Change-Id: I229eb1cc4963c04968ed9ac32b65847dbfd602c3 Reviewed-on: https://gerrit.libreoffice.org/82807 Tested-by: Jenkins Reviewed-by: Muhammet Kara diff --git a/chart2/source/controller/sidebar/ChartTypePanel.cxx b/chart2/source/controller/sidebar/ChartTypePanel.cxx index 1e2a2c903269..d70a21bacad7 100644 --- a/chart2/source/controller/sidebar/ChartTypePanel.cxx +++ b/chart2/source/controller/sidebar/ChartTypePanel.cxx @@ -23,6 +23,7 @@ #include #include #include +#include #include #include #include @@ -70,7 +71,8 @@ ChartTypePanel::ChartTypePanel(vcl::Window* pParent, , mbModelValid(true) , m_pDim3DLookResourceGroup(new Dim3DLookResourceGroup(m_xBuilder.get())) , m_pStackingResourceGroup(new StackingResourceGroup(m_xBuilder.get())) -//, m_pSplineResourceGroup( new SplineResourceGroup(m_xBuilder.get(), pController->getDialog()) ) +, m_pSplineResourceGroup( + new SplineResourceGroup(m_xBuilder.get(), pController->GetChartFrame())) , m_pGeometryResourceGroup(new GeometryResourceGroup(m_xBuilder.get())) , m_pSortByXValuesResourceGroup(new SortByXValuesResourceGroup(m_xBuilder.get())) , m_xChartModel(mxModel, css::uno::UNO_QUERY_THROW) @@ -135,7 +137,7 @@ ChartTypePanel::ChartTypePanel(vcl::Window* pParent, m_pDim3DLookResourceGroup->setChangeListener(this); m_pStackingResourceGroup->setChangeListener(this); -//m_pSplineResourceGroup->setChangeListener( this ); +m_pSplineResourceGroup->setChangeListener(this); m_pGeometryResourceGroup->setChangeListener(this); m_pSortByXValuesResourceGroup->setChangeListener(this); @@ -156,7 +158,7 @@ void ChartTypePanel::dispose() //delete all resource helpers m_pDim3DLookResourceGroup.reset(); m_pStackingResourceGroup.reset(); -//m_pSplineResourceGroup.reset(); +m_pSplineResourceGroup.reset(); m_pGeometryResourceGroup.reset(); m_pSortByXValuesResourceGroup.reset(); m_xSubTypeListWin.reset(); @@ -234,7 +236,7 @@ void ChartTypePanel::Initialize() m_xSubTypeList->Hide(); m_pDim3DLookResourceGroup->showControls(false); m_pStackingResourceGroup->showControls(false, false); -//m_pSplineResourceGroup->showControls( false ); +m_pSplineResourceGroup->showControls(false); m_pGeometryResourceGroup->showControls(false); m_pSortByXValuesResourceGroup->showControls(false); } @@ -344,8 +346,8 @@ void ChartTypePanel::showAllControls(ChartTypeDialogController& rTypeController) m_pDim3DLookResourceGroup->showControls(bShow); bShow = rTypeController.shouldShow_StackingControl(); m_pStackingResourceGroup->showControls(bShow, false); -/*bShow = rTypeController.shouldShow_SplineControl(); -m_pSplineResourceGroup->showControls( bShow );*/ +bShow = rTypeController.shouldShow_SplineControl(); +m_pSplineResourceGroup->showControls(bShow); bShow = rTypeController.shouldShow_GeometryControl(); m_pGeometryResourceGroup->showControls(bShow); bShow = rTypeController.shouldShow_SortByXValuesResourceGroup(); @@ -364,7 +366,7 @@ void ChartTypePanel::fillAllControls(const ChartTypeParameter& rParameter, m_xSubTypeList->SelectItem(static_cast(rParameter.nSubTypeIndex)); m_pDim3DLookResourceGroup->fillControls(rParameter); m_pStackingResourceGroup->fillControls(rParameter); -//m_pSplineResourceGroup->fillControls( rParameter ); +m_pSplineResourceGroup->fillControls(rParameter); m_pGeometryResourceGroup->fillControls(rParameter); m_pSortByXValuesResourceGroup->fillControls(rParameter); m_nChangingCalls--; @@ -376,7 +378,7 @@ ChartTypeParameter ChartTypePanel::getCurrentParamter() const aParameter.nSubTypeIndex = static_cast(m_xSubTypeList->GetSelectedItemId()); m_pDim3DLookResourceGroup->fillParameter(aParameter); m_pStackingResourceGroup->fillParameter(aParameter); -//m_pSplineResourceGroup->fillParameter( aParameter ); +m_pSplineResourceGroup->fillParameter(aParameter); m_pGeometryResourceGroup->fillParameter(aParameter); m_pSortByXValuesResourceGroup->fillParameter(aParameter); return aParameter; diff --git a/chart2/source/controller/sidebar/ChartTypePanel.hxx b/chart2/source/controller/sidebar/ChartTypePanel.hxx index 075ac094838b..c419a8f0b41e 100644 --- a/chart2/source/controller/sidebar/ChartTypePanel.hxx +++ b/chart2/source/controller/sidebar/ChartTypePanel.hxx @@ -126,7 +126,7 @@ private: std::unique_ptr
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/sidebar/ChartTypePanel.cxx | 57 ++-- chart2/source/controller/sidebar/ChartTypePanel.hxx |8 +- 2 files changed, 35 insertions(+), 30 deletions(-) New commits: commit 86244873ffcb65fe38b7c65838181397a8d390f6 Author: Muhammet Kara AuthorDate: Fri Nov 15 18:05:20 2019 +0300 Commit: Muhammet Kara CommitDate: Sat Nov 16 13:10:49 2019 +0100 Add more resource groups to ChartTypePanel Change-Id: I64c1d8b418f9abb537b4f23c3b31aa0e48bd3faa Reviewed-on: https://gerrit.libreoffice.org/82119 Tested-by: Jenkins CollaboraOffice Reviewed-by: Muhammet Kara Reviewed-on: https://gerrit.libreoffice.org/82801 Tested-by: Jenkins diff --git a/chart2/source/controller/sidebar/ChartTypePanel.cxx b/chart2/source/controller/sidebar/ChartTypePanel.cxx index 1774d6a9961b..1e2a2c903269 100644 --- a/chart2/source/controller/sidebar/ChartTypePanel.cxx +++ b/chart2/source/controller/sidebar/ChartTypePanel.cxx @@ -69,6 +69,10 @@ ChartTypePanel::ChartTypePanel(vcl::Window* pParent, , mxListener(new ChartSidebarModifyListener(this)) , mbModelValid(true) , m_pDim3DLookResourceGroup(new Dim3DLookResourceGroup(m_xBuilder.get())) +, m_pStackingResourceGroup(new StackingResourceGroup(m_xBuilder.get())) +//, m_pSplineResourceGroup( new SplineResourceGroup(m_xBuilder.get(), pController->getDialog()) ) +, m_pGeometryResourceGroup(new GeometryResourceGroup(m_xBuilder.get())) +, m_pSortByXValuesResourceGroup(new SortByXValuesResourceGroup(m_xBuilder.get())) , m_xChartModel(mxModel, css::uno::UNO_QUERY_THROW) , m_aChartTypeDialogControllerList(0) , m_pCurrentMainType(nullptr) @@ -130,6 +134,10 @@ ChartTypePanel::ChartTypePanel(vcl::Window* pParent, } m_pDim3DLookResourceGroup->setChangeListener(this); +m_pStackingResourceGroup->setChangeListener(this); +//m_pSplineResourceGroup->setChangeListener( this ); +m_pGeometryResourceGroup->setChangeListener(this); +m_pSortByXValuesResourceGroup->setChangeListener(this); Initialize(); } @@ -142,18 +150,15 @@ void ChartTypePanel::dispose() css::uno::UNO_QUERY_THROW); xBroadcaster->removeModifyListener(mxListener); -/*mpChartTypeLabel.clear(); -m_pMainTypeList.clear(); -m_pSubTypeList.clear();*/ - -//delete all resource helpers -//m_pDim3DLookResourceGroup.reset(); - //delete all dialog controller m_aChartTypeDialogControllerList.clear(); -//delete all resource helper +//delete all resource helpers m_pDim3DLookResourceGroup.reset(); +m_pStackingResourceGroup.reset(); +//m_pSplineResourceGroup.reset(); +m_pGeometryResourceGroup.reset(); +m_pSortByXValuesResourceGroup.reset(); m_xSubTypeListWin.reset(); m_xSubTypeList.reset(); @@ -228,10 +233,10 @@ void ChartTypePanel::Initialize() { m_xSubTypeList->Hide(); m_pDim3DLookResourceGroup->showControls(false); -/*m_pStackingResourceGroup->showControls( false, false ); -m_pSplineResourceGroup->showControls( false ); -m_pGeometryResourceGroup->showControls( false ); -m_pSortByXValuesResourceGroup->showControls( false );*/ +m_pStackingResourceGroup->showControls(false, false); +//m_pSplineResourceGroup->showControls( false ); +m_pGeometryResourceGroup->showControls(false); +m_pSortByXValuesResourceGroup->showControls(false); } } @@ -337,14 +342,14 @@ void ChartTypePanel::showAllControls(ChartTypeDialogController& rTypeController) bool bShow = rTypeController.shouldShow_3DLookControl(); m_pDim3DLookResourceGroup->showControls(bShow); -/*bShow = rTypeController.shouldShow_StackingControl(); -m_pStackingResourceGroup->showControls( bShow, false ); -bShow = rTypeController.shouldShow_SplineControl(); -m_pSplineResourceGroup->showControls( bShow ); +bShow = rTypeController.shouldShow_StackingControl(); +m_pStackingResourceGroup->showControls(bShow, false); +/*bShow = rTypeController.shouldShow_SplineControl(); +m_pSplineResourceGroup->showControls( bShow );*/ bShow = rTypeController.shouldShow_GeometryControl(); -m_pGeometryResourceGroup->showControls( bShow ); +m_pGeometryResourceGroup->showControls(bShow); bShow = rTypeController.shouldShow_SortByXValuesResourceGroup(); -m_pSortByXValuesResourceGroup->showControls( bShow );*/ +m_pSortByXValuesResourceGroup->showControls(bShow); rTypeController.showExtraControls(m_xBuilder.get()); } @@ -358,10 +363,10 @@ void ChartTypePanel::fillAllControls(const ChartTypeParameter& rParameter, } m_xSubTypeList->SelectItem(static_cast(rParameter.nSubTypeIndex)); m_pDim3DLookResourceGroup->fillControls(rParameter); -/*m_pStackingResourceGroup->fillControls( rParameter ); -m_pSplineResourceGroup->fillControls( rParameter );
[Libreoffice-ux-advise] [Bug 128257] Impress bullets dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128257 --- Comment #5 from Commit Notification --- andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/559fa1016928bf2bc1259f026a9a3d101a0131f0 tdf#128257 Bullet and Numbering Dialog It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 128257] Impress bullets dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128257 Commit Notification changed: What|Removed |Added Whiteboard|target:6.4.0|target:6.4.0 target:6.5.0 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 128257] Impress bullets dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128257 --- Comment #5 from Commit Notification --- andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/559fa1016928bf2bc1259f026a9a3d101a0131f0 tdf#128257 Bullet and Numbering Dialog It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128257] Impress bullets dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128257 Commit Notification changed: What|Removed |Added Whiteboard|target:6.4.0|target:6.4.0 target:6.5.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128495] Print dialog box in Writer is too tall for screen so the button is off the bottom
https://bugs.documentfoundation.org/show_bug.cgi?id=128495 --- Comment #8 from Steve --- Created attachment 155875 --> https://bugs.documentfoundation.org/attachment.cgi?id=155875=edit Screenshot showing title bar above top of screen Thanks to all for working on this. The size of the window is now appropriate for the screen - and looks a lot tidier, but if I have the taskbar fixed to the bottom of the screen, the window positions itself so that only the very bottom of the tabs is accessible (see screenshot) - and it is not possible to "grab" the window to move it. I tried auto-hiding the taskbar and moving it to the right (rather than botton) of the screen and then re-starting LibreOffice, but the title bar of then window stubbornly remained above the top of the screen.The size of the window is now appropriate for the screen - and looks a lot tidier, but if I have the taskbar fixed to the bottom of the screen, the window positions itself so that only the very bottom of the tabs is accessible (see screenshot) - and it is not possible to "grab" the window to move it. I tried auto-hiding the taskbar and moving it to the right (rather than botton) of the screen and then re-starting LibreOffice, but the title bar of then window stubbornly remained above the top of the screen. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/uiconfig
cui/uiconfig/ui/bulletandposition.ui | 137 --- 1 file changed, 63 insertions(+), 74 deletions(-) New commits: commit 559fa1016928bf2bc1259f026a9a3d101a0131f0 Author: andreas kainz AuthorDate: Sat Nov 16 10:16:55 2019 +0100 Commit: andreas_kainz CommitDate: Sat Nov 16 13:08:09 2019 +0100 tdf#128257 Bullet and Numbering Dialog Change-Id: I0931f7207e1533d6cb552cecbcf2872024f2bafe Reviewed-on: https://gerrit.libreoffice.org/82973 Tested-by: Jenkins Reviewed-by: andreas_kainz diff --git a/cui/uiconfig/ui/bulletandposition.ui b/cui/uiconfig/ui/bulletandposition.ui index d0e057271d6e..e84b6a8abf07 100644 --- a/cui/uiconfig/ui/bulletandposition.ui +++ b/cui/uiconfig/ui/bulletandposition.ui @@ -66,7 +66,7 @@ False vertical -6 +12 False @@ -142,7 +142,6 @@ 490 True False -6 12 @@ -231,13 +230,12 @@ True False vertical -6 True False -6 -12 +3 +6 True @@ -256,7 +254,6 @@ True False -True 1 @@ -274,7 +271,7 @@ 0 -2 +4 @@ -288,7 +285,7 @@ 1 -2 +4 @@ -311,7 +308,6 @@ True True True -start 1 @@ -324,7 +320,6 @@ True True True -start True bitmapmenu @@ -333,7 +328,7 @@ 1 -4 +3 @@ -347,7 +342,7 @@ 0 -3 +2 @@ -355,8 +350,6 @@ True True False -start -0 True @@ -365,7 +358,7 @@ 1 -3 +2 @@ -415,8 +408,8 @@ True False -6 -12 +3 +6 True @@ -504,20 +497,19 @@ True False -6 -12 +3 +6
[Libreoffice-bugs] [Bug 44462] Provide a proper 'File Association Manager' for the windows version of Libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=44462 Commit Notification changed: What|Removed |Added Whiteboard||target:6.5.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/Library_cui.mk cui/source cui/uiconfig
cui/Library_cui.mk|1 cui/source/options/optgdlg.cxx| 39 + cui/source/options/optgdlg.hxx|7 + cui/uiconfig/ui/optgeneralpage.ui | 51 ++ 4 files changed, 98 insertions(+) New commits: commit ae71570ee7db0a4a9d237424ed2cc3204e86f136 Author: Mike Kaganski AuthorDate: Fri Nov 15 12:14:31 2019 +0300 Commit: Mike Kaganski CommitDate: Sat Nov 16 13:00:51 2019 +0100 tdf#44462: add a link to Windows Default apps settings applet Add "Windows Default apps" button to Options->General to run system applet to control file associations, in accordance to recommendation from MS [1]. On Windows 10, though, the call to LaunchAdvancedAssociationUI would only bring a system-modal infobanner suggesting the user to go to Settings > Apps > Default apps, as documented at [2]. Since this is what MS considers the correct way to manage application associations, the infobanner should be enough. [1] https://docs.microsoft.com/en-us/windows/win32/shell/default-programs [2] https://docs.microsoft.com/en-us/windows/win32/api/shobjidl/nf-shobjidl-iapplicationassociationregistrationui-launchadvancedassociationui Change-Id: I79cccdd00afac998c028b8e151db66bbd75be985 Reviewed-on: https://gerrit.libreoffice.org/82777 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/cui/Library_cui.mk b/cui/Library_cui.mk index e45e35a8f0e3..27d89ec1c3b6 100644 --- a/cui/Library_cui.mk +++ b/cui/Library_cui.mk @@ -87,6 +87,7 @@ ifeq ($(OS),WNT) $(eval $(call gb_Library_use_system_win32_libs,cui,\ advapi32 \ shlwapi \ +ole32 \ )) endif diff --git a/cui/source/options/optgdlg.cxx b/cui/source/options/optgdlg.cxx index 3079b2c92c2c..597d75358d1c 100644 --- a/cui/source/options/optgdlg.cxx +++ b/cui/source/options/optgdlg.cxx @@ -81,6 +81,12 @@ #include #include +#if defined(_WIN32) +#include +#include +#include +#include +#endif using namespace ::com::sun::star::uno; using namespace ::com::sun::star::lang; using namespace ::com::sun::star::beans; @@ -248,6 +254,10 @@ OfaMiscTabPage::OfaMiscTabPage(weld::Container* pPage, weld::DialogController* p #else , m_xQuickLaunchCB(m_xBuilder->weld_check_button("quicklaunch")) #endif +#if defined(_WIN32) +, m_xFileAssocFrame(m_xBuilder->weld_widget("fileassoc")) +, m_xFileAssocBtn(m_xBuilder->weld_button("assocfiles")) +#endif { if (!lcl_HasSystemFilePicker()) m_xFileDlgFrame->hide(); @@ -273,6 +283,11 @@ OfaMiscTabPage::OfaMiscTabPage(weld::Container* pPage, weld::DialogController* p m_xQuickStarterFrame->hide(); #endif +#if defined(_WIN32) +m_xFileAssocFrame->show(); +m_xFileAssocBtn->connect_clicked(LINK(this, OfaMiscTabPage, FileAssocClick)); +#endif + m_aStrDateInfo = m_xToYearFT->get_label(); m_xYearValueField->connect_value_changed( LINK( this, OfaMiscTabPage, TwoFigureHdl ) ); @@ -427,6 +442,30 @@ IMPL_LINK_NOARG( OfaMiscTabPage, TwoFigureHdl, weld::SpinButton&, void ) m_xToYearFT->set_label( aOutput ); } +#if defined(_WIN32) +IMPL_LINK_NOARG(OfaMiscTabPage, FileAssocClick, weld::Button&, void) +{ +const bool bUninit = SUCCEEDED(CoInitialize(nullptr)); +IApplicationAssociationRegistrationUI* pIf = nullptr; +HRESULT res = CoCreateInstance(CLSID_ApplicationAssociationRegistrationUI, 0, + CLSCTX_INPROC_SERVER, IID_IApplicationAssociationRegistrationUI, + reinterpret_cast()); + +if (SUCCEEDED(res) && pIf) +{ +// LaunchAdvancedAssociationUI only works for applications registered under +// Software\RegisteredApplications. See scp2/source/ooo/registryitem_ooo.scp +const OUString expanded = Translate::ExpandVariables("%PRODUCTNAME %PRODUCTVERSION"); +// This will only show "To change your default apps, go to Settings > Apps > Default apps" +// on Win10; this is expected. At least this will self-document it to users. +pIf->LaunchAdvancedAssociationUI(o3tl::toW(expanded.getStr())); +pIf->Release(); +} +if (bUninit) +CoUninitialize(); +} +#endif + class CanvasSettings { public: diff --git a/cui/source/options/optgdlg.hxx b/cui/source/options/optgdlg.hxx index 5c591e7c876f..392554f6e8dd 100644 --- a/cui/source/options/optgdlg.hxx +++ b/cui/source/options/optgdlg.hxx @@ -54,8 +54,15 @@ private: std::unique_ptr m_xCrashReport; std::unique_ptr m_xQuickStarterFrame; std::unique_ptr m_xQuickLaunchCB; +#if defined(_WIN32) +std::unique_ptr m_xFileAssocFrame; +std::unique_ptr m_xFileAssocBtn; +#endif DECL_LINK(TwoFigureHdl, weld::SpinButton&, void); +#if defined(_WIN32) +DECL_LINK(FileAssocClick, weld::Button&, void); +#endif protected: virtual DeactivateRC DeactivatePage( SfxItemSet* pSet ) override; diff --git
[Libreoffice-bugs] [Bug 44462] Provide a proper 'File Association Manager' for the windows version of Libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=44462 --- Comment #22 from Commit Notification --- Mike Kaganski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ae71570ee7db0a4a9d237424ed2cc3204e86f136 tdf#44462: add a link to Windows Default apps settings applet It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44462] Provide a proper 'File Association Manager' for the windows version of Libreoffice
https://bugs.documentfoundation.org/show_bug.cgi?id=44462 Mike Kaganski changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #21 from Mike Kaganski --- Fixed as described in comment 20. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41884] [META] Windows Installer Most Annoying Bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=41884 Bug 41884 depends on bug 44462, which changed state. Bug 44462 Summary: Provide a proper 'File Association Manager' for the windows version of Libreoffice https://bugs.documentfoundation.org/show_bug.cgi?id=44462 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=10 Bug 10 depends on bug 90879, which changed state. Bug 90879 Summary: TABLE: FILESAVE: merged header & body cells split when saved as DOCX https://bugs.documentfoundation.org/show_bug.cgi?id=90879 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90879] TABLE: FILESAVE: merged header & body cells split when saved as DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=90879 Gabor Kelemen changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #9 from Gabor Kelemen --- Bibisected using bibisect-linux-64-6.4 to: $ git bisect bad a88007c79d2c318ec801a77ea42c45dbf24510c1 is the first bad commit commit a88007c79d2c318ec801a77ea42c45dbf24510c1 Author: Jenkins Build User Date: Mon Nov 4 10:02:45 2019 +0100 source sha:44e44239de35c1548809c96e13bfa9d64c7ca441 source sha:44e44239de35c1548809c96e13bfa9d64c7ca441 https://gerrit.libreoffice.org/plugins/gitiles/core/+/44e44239de35c1548809c96e13bfa9d64c7ca441%5E%21 tdf#120315 DOCX import: fix cells merged vertically *** This bug has been marked as a duplicate of bug 120315 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128544] MASTER DOCUMENT: Crash in fps_officelo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=128544 --- Comment #10 from Dieter Praas --- (In reply to fjf.vanleeuwen from comment #9) > I just added a new crashreport, id bb92449f-5c7d-4e44-a29c-be84388f37f2. But this crash report (https://crashreport.libreoffice.org/stats/crash_details/bb92449f-5c7d-4e44-a29c-be84388f37f2) has a different signature https://crashreport.libreoffice.org/stats/signature/SvtFileDialog::LinkStubDblClickHdl_Impl(void%20*,SvTreeListBox%20*). So it can't be the same bug than from the initial bug report. So for me it looks like the bug reported here has been solved in LO 6.3.3.2. and this is a new one. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang include/svtools sc/inc sc/qa sc/source sfx2/source svtools/source
compilerplugins/clang/unusedfields.only-used-in-constructor.results | 102 +++--- compilerplugins/clang/unusedfields.py |2 compilerplugins/clang/unusedfields.readonly.results | 164 +- compilerplugins/clang/unusedfields.untouched.results| 46 +- compilerplugins/clang/unusedfields.writeonly.results| 56 +-- include/svtools/inettbc.hxx |4 sc/inc/markmulti.hxx|3 sc/qa/unit/mark_test.cxx|2 sc/source/core/data/markdata.cxx|4 sc/source/core/data/markmulti.cxx |7 sfx2/source/inet/inettbc.cxx|3 svtools/source/control/inettbc.cxx | 29 - 12 files changed, 200 insertions(+), 222 deletions(-) New commits: commit 03feda2465c7a18d6bac5781510ace2eabc40379 Author: Noel Grandin AuthorDate: Sat Nov 16 11:06:21 2019 +0200 Commit: Noel Grandin CommitDate: Sat Nov 16 12:27:59 2019 +0100 loplugin:unusedfields Change-Id: I021cd75685a091c1afd3ff3c144def6f9a784bee Reviewed-on: https://gerrit.libreoffice.org/82972 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/compilerplugins/clang/unusedfields.only-used-in-constructor.results b/compilerplugins/clang/unusedfields.only-used-in-constructor.results index 1d828b56cedf..3e98bea722c3 100644 --- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results +++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results @@ -9,9 +9,9 @@ avmedia/source/vlc/wrapper/Types.hxx:44 avmedia/source/vlc/wrapper/Types.hxx:45 libvlc_event_t::(anonymous union)::(anonymous) dummy2 const char * avmedia/source/vlc/wrapper/Types.hxx:46 -libvlc_event_t::(anonymous) padding struct (anonymous struct at /media/disk2/libo7/avmedia/source/vlc/wrapper/Types.hxx:43:7) +libvlc_event_t::(anonymous) padding struct (anonymous struct at /media/disk2/libo4/avmedia/source/vlc/wrapper/Types.hxx:43:7) avmedia/source/vlc/wrapper/Types.hxx:47 -libvlc_event_t u union (anonymous union at /media/disk2/libo7/avmedia/source/vlc/wrapper/Types.hxx:41:5) +libvlc_event_t u union (anonymous union at /media/disk2/libo4/avmedia/source/vlc/wrapper/Types.hxx:41:5) avmedia/source/vlc/wrapper/Types.hxx:53 libvlc_track_description_t psz_name char * basegfx/source/polygon/b2dtrapezoid.cxx:202 @@ -293,9 +293,9 @@ include/sfx2/msg.hxx:141 include/sfx2/msg.hxx:141 SfxType11 pType const std::type_info * include/sfx2/msg.hxx:141 -SfxType11 aAttrib struct SfxTypeAttrib [11] -include/sfx2/msg.hxx:141 SfxType11 nAttribs sal_uInt16 +include/sfx2/msg.hxx:141 +SfxType11 aAttrib struct SfxTypeAttrib [11] include/sfx2/msg.hxx:143 SfxType13 pType const std::type_info * include/sfx2/msg.hxx:143 @@ -331,11 +331,11 @@ include/sfx2/msg.hxx:146 include/sfx2/msg.hxx:147 SfxType23 nAttribs sal_uInt16 include/sfx2/msg.hxx:147 +SfxType23 createSfxPoolItemFunc std::function +include/sfx2/msg.hxx:147 SfxType23 aAttrib struct SfxTypeAttrib [23] include/sfx2/msg.hxx:147 SfxType23 pType const std::type_info * -include/sfx2/msg.hxx:147 -SfxType23 createSfxPoolItemFunc std::function include/svl/ondemand.hxx:55 OnDemandLocaleDataWrapper aSysLocale class SvtSysLocale include/svx/ClassificationDialog.hxx:31 @@ -508,6 +508,8 @@ sc/inc/compiler.hxx:259 ScCompiler::AddInMap pEnglish const char * sc/inc/compiler.hxx:261 ScCompiler::AddInMap pUpper const char * +sc/inc/markmulti.hxx:38 +ScMultiSel mnMaxCol SCCOL sc/inc/token.hxx:400 SingleDoubleRefModifier aDub struct ScComplexRefData sc/qa/unit/ucalc_column.cxx:104 @@ -540,7 +542,7 @@ sc/source/filter/oox/worksheethelper.cxx:384 oox::xls::WorksheetGlobals mxProgressBar oox::ISegmentProgressBarRef sc/source/filter/xml/xmldrani.hxx:72 ScXMLDatabaseRangeContext bIsSelection _Bool -sc/source/filter/xml/xmlexternaltabi.hxx:113 +sc/source/filter/xml/xmlexternaltabi.hxx:111 ScXMLExternalRefCellContext mnCellType sal_Int16 sc/source/filter/xml/xmltransformationi.hxx:155 ScXMLDateTimeContext aType class rtl::OUString @@ -602,46 +604,46 @@ sd/source/ui/view/viewshel.cxx:1161 sd::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock sd::slidesorter::controller::class PageSelector::UpdateLock sd/source/ui/view/viewshel.cxx:1162 sd::KeepSlideSorterInSyncWithPageChanges m_aContext sd::slidesorter::controller::class SelectionObserver::Context -sdext/source/pdfimport/pdfparse/pdfparse.cxx:262 +sdext/source/pdfimport/pdfparse/pdfparse.cxx:261 +PDFGrammar::definition stringtype rule +sdext/source/pdfimport/pdfparse/pdfparse.cxx:261 +PDFGrammar::definition name rule +sdext/source/pdfimport/pdfparse/pdfparse.cxx:261
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/meta/xmlversion.cxx |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) New commits: commit 1b0a9a99709522cb4a7d189824ec5359ea430ff5 Author: Noel Grandin AuthorDate: Fri Nov 15 14:53:46 2019 +0200 Commit: Noel Grandin CommitDate: Sat Nov 16 12:27:35 2019 +0100 use FasterParser for XMLVersionListPersistence the SvXMLImport superclass of XMLVersionListImport already constructs a parser, so we can just use that one Change-Id: If35ae7c1670497c4833711eb5351a99aaa087044 Reviewed-on: https://gerrit.libreoffice.org/82786 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/xmloff/source/meta/xmlversion.cxx b/xmloff/source/meta/xmlversion.cxx index 2aa38a9d5292..fc7bbe824f95 100644 --- a/xmloff/source/meta/xmlversion.cxx +++ b/xmloff/source/meta/xmlversion.cxx @@ -31,7 +31,6 @@ #include #include #include -#include #include #include #include @@ -381,16 +380,12 @@ uno::Sequence< util::RevisionTag > SAL_CALL XMLVersionListPersistence::load( con throw uno::RuntimeException(); // get filter -Reference< XFastDocumentHandler > xFilter = new XMLVersionListImport( xContext, aVersions ); - -// connect parser and filter -Reference< XFastParser > xParser = xml::sax::FastParser::create(xContext); -xParser->setFastDocumentHandler( xFilter ); +rtl::Reference< XMLVersionListImport > xImport = new XMLVersionListImport( xContext, aVersions ); // parse try { -xParser->parseStream( aParserInput ); +xImport->parseStream( aParserInput ); } catch( SAXParseException& ) {} catch( SAXException& ) {} ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120615] Ctrl+LShift, Ctrl+RShift not setting direction in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=120615 --- Comment #7 from Eyal Rozenberg --- Bug still manifests with: Version: 6.3.2.2 Build ID: 1:6.3.2-1 CPU threads: 4; OS: Linux 5.2; UI render: default; VCL: gtk3; Locale: he-IL (en_IL); UI-Language: en-US -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116608] The bold part of Times of New Roman font bold & italic is disappearing at smaller zoom levels (depending on font size) without OpenGL enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=116608 Dieter Praas changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #21 from Dieter Praas --- Telesto, can you still reproduce it with LO 6.4.0.0.beta1? If this is the case, do you have any possibility to test it with Windwos 10? => NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95175] Impress: can't change text alignment in text frame of specific ODP via Paragraph (can via Text Anchor or Clear Formatting)
https://bugs.documentfoundation.org/show_bug.cgi?id=95175 Timur changed: What|Removed |Added Summary|FORMATTING can't change |Impress: can't change text |text alignment |alignment in text frame of ||specific ODP via Paragraph ||(can via Text Anchor or ||Clear Formatting) Priority|medium |lowest Hardware|x86 (IA32) |All URL||https://help.libreoffice.or ||g/6.4/en-US/text/shared/01/ ||0522.html?DbPAR=SHARED# ||bm_id3146856 --- Comment #9 from Timur --- Same with Lo 6.5+ but.. We don't have a cause here nor steps to reproduce and create the problem ODP. Master slide is not relevant, same is if copied to Normal slide. We have a workaround in Comment 7 or another: clear direct formatting on that frame. After that, align will work. This is Text Frame (as shown in status bar if selected). And I don't know how to add text frame at all in Impress. I'm inclined to close this bug. I'd just want to clarify on text frame. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128834] UI Pop-up menu for fast access
https://bugs.documentfoundation.org/show_bug.cgi?id=128834 --- Comment #1 from sebick --- Created attachment 155874 --> https://bugs.documentfoundation.org/attachment.cgi?id=155874=edit Highlight -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128834] New: UI Pop-up menu for fast access
https://bugs.documentfoundation.org/show_bug.cgi?id=128834 Bug ID: 128834 Summary: UI Pop-up menu for fast access Product: LibreOffice Version: 6.5.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: d941...@urhen.com Created attachment 155873 --> https://bugs.documentfoundation.org/attachment.cgi?id=155873=edit FILECOPY Hi all, would be awesome to add a context sensitive pop-up menu when marking cells, similar to the attached screen. Enables fast access, improves productivity immensely and saves hours in the day to day working life. Guess it would also improve writer & impress, was such a feature ever analyzed or verified here? Greetz -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128798] Crash if generating plot out of table in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=128798 --- Comment #5 from Julien Nabet --- Created attachment 155872 --> https://bugs.documentfoundation.org/attachment.cgi?id=155872=edit bt from throw IllegalArgumentException -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/source sw/source
desktop/source/app/app.cxx| 18 ++ sw/source/filter/ww8/wrtw8num.cxx | 15 ++- 2 files changed, 12 insertions(+), 21 deletions(-) New commits: commit 130c1ae09451c268fcd4f2d55f65ac7dc9581342 Author: Mike Kaganski AuthorDate: Sat Nov 16 10:36:24 2019 +0200 Commit: Mike Kaganski CommitDate: Sat Nov 16 11:45:21 2019 +0100 Replace some std::once with static initializers Change-Id: I6234bc252dac5b1c29e3f1ef844cf51f56aaa7ac Reviewed-on: https://gerrit.libreoffice.org/82970 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx index ef94b0d96da3..31f7abbf9b4e 100644 --- a/desktop/source/app/app.cxx +++ b/desktop/source/app/app.cxx @@ -394,18 +394,12 @@ namespace OUString ReplaceStringHookProc( const OUString& rStr ) { -const static OUString sBuildId(utl::Bootstrap::getBuildIdData("development")); -static OUString sBrandName, sVersion, sAboutBoxVersion, sAboutBoxVersionSuffix, sExtension; - -static std::once_flag aInitOnce; -std::call_once(aInitOnce, [] -{ -sBrandName = utl::ConfigManager::getProductName(); -sVersion = utl::ConfigManager::getProductVersion(); -sAboutBoxVersion = utl::ConfigManager::getAboutBoxProductVersion(); -sAboutBoxVersionSuffix = utl::ConfigManager::getAboutBoxProductVersionSuffix(); -sExtension = utl::ConfigManager::getProductExtension(); -} ); +const static OUString sBuildId(utl::Bootstrap::getBuildIdData("development")), +sBrandName(utl::ConfigManager::getProductName()), +sVersion(utl::ConfigManager::getProductVersion()), +sAboutBoxVersion(utl::ConfigManager::getAboutBoxProductVersion()), + sAboutBoxVersionSuffix(utl::ConfigManager::getAboutBoxProductVersionSuffix()), +sExtension(utl::ConfigManager::getProductExtension()); OUString sRet(rStr); if (sRet.indexOf("%PRODUCT") != -1 || sRet.indexOf("%ABOUTBOX") != -1) diff --git a/sw/source/filter/ww8/wrtw8num.cxx b/sw/source/filter/ww8/wrtw8num.cxx index d9f284c3380b..35b8c60a89b7 100644 --- a/sw/source/filter/ww8/wrtw8num.cxx +++ b/sw/source/filter/ww8/wrtw8num.cxx @@ -40,6 +40,7 @@ #include "ww8par.hxx" #include +#include using namespace ::com::sun::star; using namespace sw::types; @@ -444,15 +445,11 @@ void MSWordExportBase::NumberingLevel( SwNumRule const& rRule, sal_uInt8 const nLvl) { // prepare the NodeNum to generate the NumString -static SwNumberTree::tNumberVector aNumVector; -static std::once_flag aInitOnce; -std::call_once(aInitOnce, [] -{ -for (int n = 0; n < WW8ListManager::nMaxLevel; ++n) -{ -aNumVector.push_back( n ); -} -}); +static const SwNumberTree::tNumberVector aNumVector = [] { +SwNumberTree::tNumberVector vec(WW8ListManager::nMaxLevel); +std::iota(vec.begin(), vec.end(), 0); +return vec; +}(); // write the static data of the SwNumFormat of this level sal_uInt8 aNumLvlPos[WW8ListManager::nMaxLevel] = { 0,0,0,0,0,0,0,0,0 }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128798] Crash if generating plot out of table in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=128798 --- Comment #4 from Julien Nabet --- Created attachment 155871 --> https://bugs.documentfoundation.org/attachment.cgi?id=155871=edit console logs + bt On pc Debian x86-64 with master sources updated today, I could reproduce this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svx/source
svx/source/unodraw/unoshape.cxx | 254 +--- 1 file changed, 60 insertions(+), 194 deletions(-) New commits: commit 16fbe76fd05e96f0aa1a39498a0d7fd56a5b9c5f Author: Mike Kaganski AuthorDate: Sat Nov 16 10:49:32 2019 +0200 Commit: Mike Kaganski CommitDate: Sat Nov 16 11:34:28 2019 +0100 Simplify sequences initialization Change-Id: Ib8ca198762317b49d35e51d2d31e1cac7ca53921 Reviewed-on: https://gerrit.libreoffice.org/82971 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/svx/source/unodraw/unoshape.cxx b/svx/source/unodraw/unoshape.cxx index 3f07f5ab9a82..6ebb7a090f36 100644 --- a/svx/source/unodraw/unoshape.cxx +++ b/svx/source/unodraw/unoshape.cxx @@ -35,7 +35,6 @@ #include #include #include -#include #include #include #include @@ -3142,25 +3141,15 @@ uno::Sequence< OUString > SvxShape::_getSupportedServiceNames() { case OBJ_GRUP: { -static uno::Sequence< OUString > aSvxShape_GroupServices = [&]() -{ -uno::Sequence< OUString > tmp; -comphelper::ServiceInfoHelper::addToSequence( tmp, -{sUNO_service_drawing_GroupShape, - sUNO_service_drawing_Shape} ); -return tmp; -}(); - +static const uno::Sequence aSvxShape_GroupServices += { sUNO_service_drawing_GroupShape, +sUNO_service_drawing_Shape }; return aSvxShape_GroupServices; } case OBJ_CUSTOMSHAPE: { -static uno::Sequence< OUString > aSvxShape_CustomShapeServices = [&]() -{ -uno::Sequence< OUString > tmp; - -comphelper::ServiceInfoHelper::addToSequence( tmp, - {sUNO_service_drawing_CustomShape, +static const uno::Sequence aSvxShape_CustomShapeServices += { sUNO_service_drawing_CustomShape, sUNO_service_drawing_Shape, sUNO_service_drawing_CustomShapeProperties, sUNO_service_drawing_FillProperties, @@ -3174,19 +3163,13 @@ uno::Sequence< OUString > SvxShape::_getSupportedServiceNames() sUNO_service_style_CharacterPropertiesComplex, sUNO_service_style_CharacterPropertiesAsian, sUNO_service_drawing_ShadowProperties, -sUNO_service_drawing_RotationDescriptor}); -return tmp; -}(); +sUNO_service_drawing_RotationDescriptor }; return aSvxShape_CustomShapeServices; } case OBJ_LINE: { -static uno::Sequence< OUString > aSvxShape_LineServices = [&]() -{ -uno::Sequence< OUString > tmp; - -comphelper::ServiceInfoHelper::addToSequence( tmp, -{sUNO_service_drawing_LineShape, +static const uno::Sequence aSvxShape_LineServices += { sUNO_service_drawing_LineShape, sUNO_service_drawing_Shape, sUNO_service_drawing_LineProperties, @@ -3202,20 +3185,14 @@ uno::Sequence< OUString > SvxShape::_getSupportedServiceNames() sUNO_service_drawing_PolyPolygonDescriptor, sUNO_service_drawing_ShadowProperties, -sUNO_service_drawing_RotationDescriptor}); -return tmp; -}(); +sUNO_service_drawing_RotationDescriptor }; return aSvxShape_LineServices; } case OBJ_RECT: { -static uno::Sequence< OUString > aSvxShape_RectServices = [&]() -{ -uno::Sequence< OUString > tmp; - -comphelper::ServiceInfoHelper::addToSequence( tmp, -{sUNO_service_drawing_RectangleShape, +static const uno::Sequence aSvxShape_RectServices += { sUNO_service_drawing_RectangleShape, sUNO_service_drawing_Shape, sUNO_service_drawing_FillProperties, @@ -3230,9 +3207,7 @@ uno::Sequence< OUString > SvxShape::_getSupportedServiceNames() sUNO_service_style_CharacterPropertiesAsian, sUNO_service_drawing_ShadowProperties, -sUNO_service_drawing_RotationDescriptor}); -return tmp; -}(); +sUNO_service_drawing_RotationDescriptor };
[Libreoffice-bugs] [Bug 128833] New: Font Family dropdown list has no vertical scrollbar
https://bugs.documentfoundation.org/show_bug.cgi?id=128833 Bug ID: 128833 Summary: Font Family dropdown list has no vertical scrollbar Product: LibreOffice Version: 6.2.4.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: suokunl...@126.com There is no vertical scrollbar in the font family dropdown list. (In writer: Format -> Character -> Font; In Calc: Format -> Cells -> Font) This makes it difficult to find a font needed. This may be a regression, it worked some years ago. Version: 6.2.8.1 Build ID: 815fe723fb0e60e4a39ff860f907cc63980a0232 CPU threads: 4; OS: Linux 5.3; UI render: default; VCL: gtk3; Locale: zh-CN (zh_CN.UTF-8); UI-Language: en-US Calc: threaded Fedora 30/31. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128557] List Styles can't be deleted in Custom Styles view
https://bugs.documentfoundation.org/show_bug.cgi?id=128557 --- Comment #10 from Jim Raykowski --- Created attachment 155870 --> https://bugs.documentfoundation.org/attachment.cgi?id=155870=edit style list tooltips and delete menu item Instead of including style used by information in the delete dialog, as done in my previous post, this information can be conveyed in a tooltip as suggested by Heiko. The attached video demonstrates a tool tip showing the style name and if the style is used as a numbering style for other styles these styles follow the name. Estilo 2 is used in Title and SubTitle numbering style. This may provide hint enough to explain why delete doesn't show in the context menu for the style even when all text in the document is removed. For Estilo 1 delete appears in the context menu when all document text is removed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128832] make cell RTL is not effective on render text
https://bugs.documentfoundation.org/show_bug.cgi?id=128832 Sadeq N Yazdi changed: What|Removed |Added CC||sad...@gmail.com Keywords||text:ctl, text:rtl -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128832] New: make cell RTL is not effective on render text
https://bugs.documentfoundation.org/show_bug.cgi?id=128832 Bug ID: 128832 Summary: make cell RTL is not effective on render text Product: LibreOffice Version: 6.3.3.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sad...@gmail.com A cell in sheet that contains mixed Latin and Persian characters render just LTR and changing the cell to RTL does not effect on rendering. If I add Right-to-Left mark at the beginning of cell value, it renders text correctly. Note that there is no problem with Calc 6.2.8.2 on the same machine/os. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128544] MASTER DOCUMENT: Crash in fps_officelo.dll
https://bugs.documentfoundation.org/show_bug.cgi?id=128544 fjf.vanleeu...@quicknet.nl changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #9 from fjf.vanleeu...@quicknet.nl --- I just added a new crashreport, id bb92449f-5c7d-4e44-a29c-be84388f37f2. It took several days, I was ill. This report was made atfer I opened the master document in the browser (so not in an alraedy started LibreOffice) and then said yes to the question of updating the links. Without saving the updated document, I added a file that I made days ago. Prompt the master document crashed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128503] Document the "numeric first" behaviour of Criteria in COUNTIF() and the like (see comment 14 ff.)
https://bugs.documentfoundation.org/show_bug.cgi?id=128503 Olivier Hallot changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/filter/xml/swxml.cxx |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) New commits: commit 11e37911a5a796cbcc2b191ab017ebad85c57901 Author: Noel Grandin AuthorDate: Fri Nov 15 16:35:06 2019 +0200 Commit: Noel Grandin CommitDate: Sat Nov 16 10:47:43 2019 +0100 no need to construct a parser in SwXMLSectionList the SvXMLImport superclass already constructs a parser Change-Id: I6ff53caf4329da439b590e4b581d2ece92d8f96d Reviewed-on: https://gerrit.libreoffice.org/82796 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sw/source/filter/xml/swxml.cxx b/sw/source/filter/xml/swxml.cxx index 1b671c834d32..ee3f75373dae 100644 --- a/sw/source/filter/xml/swxml.cxx +++ b/sw/source/filter/xml/swxml.cxx @@ -35,7 +35,6 @@ #include #include #include -#include #include #include #include @@ -1003,14 +1002,10 @@ size_t XMLReader::GetSectionList( SfxMedium& rMedium, aParserInput.aInputStream = xStm->getInputStream(); // get filter -uno::Reference< xml::sax::XFastDocumentHandler > xFilter = new SwXMLSectionList( xContext, rStrings ); - -// connect parser and filter -uno::Reference< xml::sax::XFastParser > xParser = xml::sax::FastParser::create(xContext); -xParser->setFastDocumentHandler( xFilter ); +rtl::Reference< SwXMLSectionList > xImport = new SwXMLSectionList( xContext, rStrings ); // parse -xParser->parseStream( aParserInput ); +xImport->parseStream( aParserInput ); } catch( xml::sax::SAXParseException& ) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - include/oox oox/qa oox/source sc/source
include/oox/drawingml/shapegroupcontext.hxx |6 +++--- include/oox/ppt/pptshapegroupcontext.hxx|2 +- oox/qa/unit/data/import-mce.pptx|binary oox/qa/unit/mathml.cxx | 18 +- oox/source/core/fragmenthandler2.cxx| 15 ++- oox/source/drawingml/shapegroupcontext.cxx |4 ++-- oox/source/ppt/pptshapegroupcontext.cxx |3 ++- oox/source/ppt/slidefragmenthandler.cxx |1 - oox/source/shape/LockedCanvasContext.cxx|4 ++-- oox/source/shape/LockedCanvasContext.hxx|6 +++--- oox/source/shape/ShapeContextHandler.cxx|4 ++-- oox/source/shape/WpgContext.cxx |4 ++-- oox/source/shape/WpgContext.hxx |6 +++--- sc/source/filter/inc/drawingfragment.hxx|4 ++-- sc/source/filter/oox/drawingfragment.cxx|4 ++-- 15 files changed, 55 insertions(+), 26 deletions(-) New commits: commit c9efa80d4d71aacb57a81c4fd1da163aee9f3966 Author: Miklos Vajna AuthorDate: Wed Nov 13 17:41:45 2019 +0100 Commit: Tamás Zolnai CommitDate: Sat Nov 16 10:35:24 2019 +0100 tdf#117658 PPTX import: fix duplicated math object handling We used to recurse into both arms of : while the intention is that an importer either reads or . Fix this by converting PPTShapeGroupContext to be a FragmentHandler2, this way FragmentHandler2::prepareMceContext() is invoked, which knows how to do this correctly. This requires declaring "a14" as a supported namespace, e.g. SdOOXMLExportTest2::testMathObject() would fail without it. This also requires keeping "a14" unsupported in the Calc case, e.g. ScFiltersTest::testControlImport() would fail without it. Finally the "Convert this to FragmentHandler2" TODO in SlideFragmentHandler::onCreateContext() from 2011 can be removed with this. (cherry picked from commit 4038d6c393c3cf6330671124ba69cdba98b24960) Change-Id: I883237902c71cb515e810a8e34443c9eeaca48b0 Reviewed-on: https://gerrit.libreoffice.org/82766 Tested-by: Jenkins Reviewed-by: Tamás Zolnai diff --git a/include/oox/drawingml/shapegroupcontext.hxx b/include/oox/drawingml/shapegroupcontext.hxx index 1f9c860dc940..4fa313493d3e 100644 --- a/include/oox/drawingml/shapegroupcontext.hxx +++ b/include/oox/drawingml/shapegroupcontext.hxx @@ -21,7 +21,7 @@ #define INCLUDED_OOX_DRAWINGML_SHAPEGROUPCONTEXT_HXX #include -#include +#include #include #include #include @@ -30,10 +30,10 @@ namespace oox { class AttributeList; } namespace oox { namespace drawingml { -class OOX_DLLPUBLIC ShapeGroupContext : public ::oox::core::ContextHandler2 +class OOX_DLLPUBLIC ShapeGroupContext : public ::oox::core::FragmentHandler2 { public: -ShapeGroupContext( ::oox::core::ContextHandler2Helper const & rParent, ShapePtr const & pMasterShapePtr, ShapePtr const & pGroupShapePtr ); +ShapeGroupContext( ::oox::core::FragmentHandler2 const & rParent, ShapePtr const & pMasterShapePtr, ShapePtr const & pGroupShapePtr ); virtual ~ShapeGroupContext() override; virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override; diff --git a/include/oox/ppt/pptshapegroupcontext.hxx b/include/oox/ppt/pptshapegroupcontext.hxx index 1043b3fa8177..c4b7b4a10191 100644 --- a/include/oox/ppt/pptshapegroupcontext.hxx +++ b/include/oox/ppt/pptshapegroupcontext.hxx @@ -44,7 +44,7 @@ class PPTShapeGroupContext : public ::oox::drawingml::ShapeGroupContext public: PPTShapeGroupContext( -::oox::core::ContextHandler2Helper const & rParent, +::oox::core::FragmentHandler2 const & rParent, const oox::ppt::SlidePersistPtr& rSlidePersistPtr, const oox::ppt::ShapeLocation eShapeLocation, const oox::drawingml::ShapePtr& pMasterShapePtr, diff --git a/oox/qa/unit/data/import-mce.pptx b/oox/qa/unit/data/import-mce.pptx new file mode 100644 index ..65cf1cbabfe7 Binary files /dev/null and b/oox/qa/unit/data/import-mce.pptx differ diff --git a/oox/qa/unit/mathml.cxx b/oox/qa/unit/mathml.cxx index 632fc566ddb7..0352c7a84ec4 100644 --- a/oox/qa/unit/mathml.cxx +++ b/oox/qa/unit/mathml.cxx @@ -10,8 +10,9 @@ #include #include -#include +#include #include +#include #include #include @@ -60,6 +61,21 @@ CPPUNIT_TEST_FIXTURE(OoxMathmlTest, testImportCharacters) CPPUNIT_ASSERT(getComponent().is()); } +CPPUNIT_TEST_FIXTURE(OoxMathmlTest, testImportMce) +{ +OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) + "import-mce.pptx"; +getComponent() = loadFromDesktop(aURL); +uno::Reference xDrawPagesSupplier(getComponent(), uno::UNO_QUERY); +uno::Reference xDrawPage(xDrawPagesSupplier->getDrawPages()->getByIndex(0), + uno::UNO_QUERY); + +// Without the accompanying fix in place, this failed with: +
[Libreoffice-bugs] [Bug 124462] Crash if I open the File dialog and click the 'Save' tab
https://bugs.documentfoundation.org/show_bug.cgi?id=124462 Kristy changed: What|Removed |Added Keywords|easyHack| --- Comment #26 from Kristy --- We are for resolving software related issue regarding camps intuit, magellan roadmate update, Bitdefender central if you have any query visit the below http://bitdefendercentralhub.com/ http://campsintuitcom.com/ http://magellan-roadmate-update.com/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85630] Will enter master view if searching keyword "outli"
https://bugs.documentfoundation.org/show_bug.cgi?id=85630 Timur changed: What|Removed |Added Hardware|x86-64 (AMD64) |All Status|NEW |RESOLVED OS|Linux (All) |All Resolution|--- |WORKSFORME --- Comment #9 from Timur --- Repro 5.0 Windows, but not 6.2. I close as WFM. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128723] Options Print Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128723 andreas_k changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 128723] Options Print Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128723 andreas_k changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128721] Options View Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128721 andreas_k changed: What|Removed |Added Whiteboard|target:6.5.0| Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128303] PDF Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128303 andreas_k changed: What|Removed |Added Whiteboard|target:6.5.0| Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128721] Options View Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128721 andreas_k changed: What|Removed |Added Whiteboard|target:6.5.0| Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 128303] PDF Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128303 --- Comment #4 from Commit Notification --- andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cfde42da3c5e02790bb90ab9b195b716be9d1182 tdf#128303 PDF Dialog update It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128303] PDF Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128303 --- Comment #4 from Commit Notification --- andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cfde42da3c5e02790bb90ab9b195b716be9d1182 tdf#128303 PDF Dialog update It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 128303] PDF Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128303 Commit Notification changed: What|Removed |Added Whiteboard||target:6.5.0 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 128303] PDF Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128303 Commit Notification changed: What|Removed |Added Whiteboard||target:6.5.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128721] Options View Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128721 Commit Notification changed: What|Removed |Added Whiteboard||target:6.5.0 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 128303] PDF Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128303 andreas_k changed: What|Removed |Added Whiteboard|target:6.5.0| Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 128721] Options View Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128721 --- Comment #3 from Commit Notification --- andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/342a759dae8c58f2256e5aa92e1d27fd4a3601c7 tdf#128721 Options -> View Dialog update It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128723] Options Print Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128723 Commit Notification changed: What|Removed |Added Whiteboard||target:6.5.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128721] Options View Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128721 --- Comment #3 from Commit Notification --- andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/342a759dae8c58f2256e5aa92e1d27fd4a3601c7 tdf#128721 Options -> View Dialog update It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 108383] [META] Borders dialog tab bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108383 Bug 108383 depends on bug 127807, which changed state. Bug 127807 Summary: Make Border in Writer dialog Table Properties HIG conform https://bugs.documentfoundation.org/show_bug.cgi?id=127807 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128721] Options View Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128721 Commit Notification changed: What|Removed |Added Whiteboard||target:6.5.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128723] Options Print Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128723 --- Comment #3 from Commit Notification --- andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bf88b78ee61936bb5e4b79d4ea1ab3ee049993e0 tdf#128723 Options Print Dialog update It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127807] Make Border in Writer dialog Table Properties HIG conform
https://bugs.documentfoundation.org/show_bug.cgi?id=127807 andreas_k changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128723] Options Print Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128723 Commit Notification changed: What|Removed |Added Whiteboard||target:6.5.0 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 128723] Options Print Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128723 --- Comment #3 from Commit Notification --- andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bf88b78ee61936bb5e4b79d4ea1ab3ee049993e0 tdf#128723 Options Print Dialog update It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: filter/uiconfig
filter/uiconfig/ui/pdfgeneralpage.ui | 939 ++- 1 file changed, 490 insertions(+), 449 deletions(-) New commits: commit cfde42da3c5e02790bb90ab9b195b716be9d1182 Author: andreas kainz AuthorDate: Sun Nov 10 01:05:18 2019 +0100 Commit: andreas_kainz CommitDate: Sat Nov 16 09:13:03 2019 +0100 tdf#128303 PDF Dialog update Change-Id: I3c572154569a3b4e782ad67bafeb00cd22c945ab Reviewed-on: https://gerrit.libreoffice.org/82369 Tested-by: Jenkins Reviewed-by: andreas_kainz diff --git a/filter/uiconfig/ui/pdfgeneralpage.ui b/filter/uiconfig/ui/pdfgeneralpage.ui index 8082b42f5070..3d59a633b027 100644 --- a/filter/uiconfig/ui/pdfgeneralpage.ui +++ b/filter/uiconfig/ui/pdfgeneralpage.ui @@ -12,15 +12,14 @@ True False -True -True 6 -12 +24 - + True False -12 +vertical +12 True @@ -37,16 +36,16 @@ True False -6 -12 +3 +6 _All True True False +start True -0 True True @@ -62,8 +61,9 @@ True True False +start +center True -0 True all @@ -81,8 +81,8 @@ True True False +start True -0 True all @@ -96,6 +96,7 @@ True True +start True 5 @@ -111,8 +112,8 @@ False True +start Slides: -0 0 @@ -120,11 +121,27 @@ + +_View PDF after export +True +True +False +start +True +True + + +0 +4 +2 + + + False True +start _Selection/Selected sheet(s) -0 1 @@ -147,8 +164,9 @@ -0 -0 +False +True +0 @@ -167,136 +185,23 @@ True False -6 - - -True -False -6 -12 - - -True -False -12 - - -True -True -True -adjustment1 - - -1 -0 - - - - -True -False -12 - - -True -False -_Quality: -True -quality -0 - - -
[Libreoffice-bugs] [Bug 128725] Options Update Dialog change
https://bugs.documentfoundation.org/show_bug.cgi?id=128725 andreas_k changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127807] Make Border in Writer dialog Table Properties HIG conform
https://bugs.documentfoundation.org/show_bug.cgi?id=127807 Commit Notification changed: What|Removed |Added Whiteboard||target:6.5.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128725] Options Update Dialog change
https://bugs.documentfoundation.org/show_bug.cgi?id=128725 --- Comment #2 from Commit Notification --- andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cb1de02b1223ebe0f0e2b90c3ca5f5da630d5296 tdf#128725 Options Update Dialog change It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128725] Options Update Dialog change
https://bugs.documentfoundation.org/show_bug.cgi?id=128725 Commit Notification changed: What|Removed |Added Whiteboard||target:6.5.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 3 commits - cui/uiconfig sfx2/uiconfig
cui/uiconfig/ui/optonlineupdatepage.ui | 550 +++- cui/uiconfig/ui/optviewpage.ui | 703 --- sfx2/uiconfig/ui/optprintpage.ui | 743 ++--- 3 files changed, 1141 insertions(+), 855 deletions(-) New commits: commit 342a759dae8c58f2256e5aa92e1d27fd4a3601c7 Author: andreas kainz AuthorDate: Mon Nov 11 22:52:37 2019 +0100 Commit: andreas_kainz CommitDate: Sat Nov 16 09:12:52 2019 +0100 tdf#128721 Options -> View Dialog update Change-Id: I3e769846c1dd5d57e62276a624fb209ca6bd7673 Reviewed-on: https://gerrit.libreoffice.org/82473 Tested-by: Jenkins Reviewed-by: andreas_kainz diff --git a/cui/uiconfig/ui/optviewpage.ui b/cui/uiconfig/ui/optviewpage.ui index c72eaab3eb09..188a3f9e2d09 100644 --- a/cui/uiconfig/ui/optviewpage.ui +++ b/cui/uiconfig/ui/optviewpage.ui @@ -15,39 +15,42 @@ start start 6 -12 +24 - + True False -18 +True +12 - + True False +True 0 none - + True False +True 6 12 - + True False -Requires restart -6 +True +3 +6 - -Use hard_ware acceleration + True -True -False +False +_Positioning: True +mousepos 0 -True 0 @@ -55,14 +58,13 @@ - -Use anti-a_liasing + True -True -False +False +Middle _button: True +mousemiddle 0 -True 0 @@ -70,59 +72,37 @@ - -Use OpenGL for all rendering -True -True -False -True -0 -True - - -0 -2 - - - - -Ignore OpenGL blacklist + True -True -False -Requires restart. Enabling this may expose driver bugs -12 -True -0 -True - - -0 -3 - - - - False -12 -GL is currently enabled. -0 +start +True + + Default button + Dialog center + No automatic positioning + -0 -4 +1 +0 - + +True False -12 -GL is currently disabled. -0 +start +True + + No function + Automatic scrolling + Paste clipboard + -0 -5 +1 +1 @@ -130,10 +110,10 @@
[Libreoffice-ux-advise] [Bug 128725] Options Update Dialog change
https://bugs.documentfoundation.org/show_bug.cgi?id=128725 Commit Notification changed: What|Removed |Added Whiteboard||target:6.5.0 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 128725] Options Update Dialog change
https://bugs.documentfoundation.org/show_bug.cgi?id=128725 andreas_k changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: cui/uiconfig
cui/uiconfig/ui/borderpage.ui | 999 -- 1 file changed, 492 insertions(+), 507 deletions(-) New commits: commit 6c4e6fc1d3a74c2840bf5a41ce1cde1debb07f24 Author: andreas kainz AuthorDate: Sat Oct 19 00:20:14 2019 +0200 Commit: andreas_kainz CommitDate: Sat Nov 16 09:12:05 2019 +0100 tdf#127807 Border Dialog update Change-Id: I35219c6c59d1bb6614ad1fa64cc0689f2019c986 Reviewed-on: https://gerrit.libreoffice.org/81115 Tested-by: Jenkins Reviewed-by: andreas_kainz diff --git a/cui/uiconfig/ui/borderpage.ui b/cui/uiconfig/ui/borderpage.ui index d81f70ae2fd8..0f7c6f625985 100644 --- a/cui/uiconfig/ui/borderpage.ui +++ b/cui/uiconfig/ui/borderpage.ui @@ -3,478 +3,473 @@ -0.050003 +0.05 9 -0.050003 +0.05 0.25 1 50 -0.10001 +0.1 1 0.5 50 -0.10001 +0.1 1 50 -0.10001 +0.1 1 50 -0.10001 +0.1 1 50 -0.10001 +0.1 1 True False -True 6 12 -6 +24 - + True False -True -12 +0 +none - + True False -True -0 -none +6 +12 - + True False -True -6 -12 +3 +6 - + True -False -6 +True +never +never +in - + True -True -never -never -in +False - + True -False - - -True -True -GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK | GDK_STRUCTURE_MASK - - +True +GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK | GDK_STRUCTURE_MASK - -0 -3 - - - - -True -False -_User-defined: -True -framesel -0 - - -0 -2 - - - - -True -False -Pr_esets: -True -presets -0 - - -0 -0 - - - - -True -True -GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK | GDK_STRUCTURE_MASK - - -0 -1 - - - - -True -False -_Adjacent Cells: -True -rmadjcellborders -0 - - -0 -4 - - - - -Remove border -True -True -False -True -0 -True - - -0 -5 -
[Libreoffice-bugs] [Bug 127807] Make Border in Writer dialog Table Properties HIG conform
https://bugs.documentfoundation.org/show_bug.cgi?id=127807 --- Comment #14 from Commit Notification --- andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6c4e6fc1d3a74c2840bf5a41ce1cde1debb07f24 tdf#127807 Border Dialog update It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128725] Options Update Dialog change
https://bugs.documentfoundation.org/show_bug.cgi?id=128725 --- Comment #2 from Commit Notification --- andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cb1de02b1223ebe0f0e2b90c3ca5f5da630d5296 tdf#128725 Options Update Dialog change It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise