[Libreoffice-bugs] [Bug 125611] [META] DOCX (OOXML) Hyperlink-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=125611 Bug 125611 depends on bug 128775, which changed state. Bug 128775 Summary: EDITING Hyperlink on accented filename has bad character encoding https://bugs.documentfoundation.org/show_bug.cgi?id=128775 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128499] FILESAVE: DOC: Formatting in TOC is lost after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=128499 László Németh changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |nem...@numbertext.org |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35986] Parts of EMF file not visible/stretched to an enormous extent
https://bugs.documentfoundation.org/show_bug.cgi?id=35986 Timur changed: What|Removed |Added Attachment #156022|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125611] [META] DOCX (OOXML) Hyperlink-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=125611 Bug 125611 depends on bug 127579, which changed state. Bug 127579 Summary: FILEOPEN DOCX: Hyperlink color and underlining gets lost when saving to DOCX https://bugs.documentfoundation.org/show_bug.cgi?id=127579 What|Removed |Added Status|VERIFIED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128946] Libre Office Calc crashed with search in selected column
https://bugs.documentfoundation.org/show_bug.cgi?id=128946 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128946] Libre Office Calc crashed with search in selected column
https://bugs.documentfoundation.org/show_bug.cgi?id=128946 Mike Kaganski changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Mike Kaganski --- I can reproduce this: 1. In a new Calc spreadsheet, put 1 into B1 2. Click on B header to select B:B 3. Ctrl+H; put 1 into "Find:" box; "[x] Current selection only" is autoselected; search in: formulas (default) 4. Press "Find Next" (shows "Reached the end of the sheet") 5. Press "Find Next" Calc hands - for some long time (~50 s in my testing); I couldn't reproduce a crash (a sample file might be needed?). But trying to close Calc afterwards seemed to hang Calc forever. Tested with Version: 6.3.3.2 (x64) Build ID: a64200df03143b798afd1ec74a12ab50359878ed CPU threads: 12; OS: Windows 10.0; UI render: GL; VCL: win; Locale: ru-RU (ru_RU); UI-Language: en-US Calc: threaded But can't reproduce a hang with Version: 6.5.0.0.alpha0+ (x64) Build ID: e371baccb4da0d97794f6614c6362bd8e32ee32b CPU threads: 12; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; Locale: ru-RU (ru_RU); UI-Language: en-US Calc: CL So possibly fixed in master -> reverse bibisect needed? As a crash is mentioned in the report, please attach a sample CSV which gives the crash. Setting to NEEDINFO; please put back to UNCONFIRMED after attaching the file. Thanks! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Support for the Apache Parquet file format
Hello! Is there any work being done to support the Apache Parquet file format? The two data processing tools that I use locally with parquet are: * python pandas [1] [2] for programmatic access * visidata [3] (CLI that uses pandas under the hood) for more "interactive" access I'm wondering why Parquet is not yet a supported format in LibreOffice Calc (and most desktop worksheet processing tools for that matter). On an unrelated note, I was also surprised to find out that Tableau only supports Parquet through a database server like Apache Drill [4][5]. I feel that parquet files are under-rated, and that perhaps pushing for native desktop application support would encourage its usage over the standard (and less efficient) CSV file format. I may be completely wrong and would welcome feedback. * [1] https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.read_parquet.html * [2] https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.to_parquet.html * [3] https://visidata.org/formats/ * [4] https://drill.apache.org/docs/tableau-examples/ * [5] https://drill.apache.org/docs/parquet-format/ -- Shadi Akiki Founder & CEO, AutofitCloud https://autofitcloud.com/ +1 813 579 4935 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - include/vcl vcl/source
include/vcl/edit.hxx|2 +- vcl/source/control/edit.cxx | 15 ++- 2 files changed, 3 insertions(+), 14 deletions(-) New commits: commit 3847be385acff98d370e7b3498a371cbc620f724 Author: Ashod Nakashian AuthorDate: Mon Jan 7 07:29:03 2019 -0500 Commit: Tomaž Vajngerl CommitDate: Fri Nov 22 08:33:45 2019 +0100 Revert "lok: custom widgets: render editbox borders" Looks like this is no longer needed to correctly render editbox borders. Not clear what fixed the issue. This reverts commit 7484f1691cbe9513dabf084effe8a0366b737a80. Change-Id: Ieb3b8d6f60ab762d0baccb341ed6a39ae2771e79 Reviewed-on: https://gerrit.libreoffice.org/66774 Tested-by: Jenkins Reviewed-by: Jan Holesovsky (cherry picked from commit 4305d9a4b97a660fec54d2796f7e5cb502d4fba0) Reviewed-on: https://gerrit.libreoffice.org/83438 Tested-by: Jenkins CollaboraOffice Reviewed-by: Tomaž Vajngerl diff --git a/include/vcl/edit.hxx b/include/vcl/edit.hxx index a44a43062b0f..caf759789bef 100644 --- a/include/vcl/edit.hxx +++ b/include/vcl/edit.hxx @@ -117,7 +117,7 @@ private: SAL_DLLPRIVATE voidImplInsertText( const OUString& rStr, const Selection* pNewSelection = nullptr, bool bIsUserInput = false ); SAL_DLLPRIVATE static OUString ImplGetValidString( const OUString& rString ); SAL_DLLPRIVATE voidImplClearBackground(vcl::RenderContext& rRenderContext, const tools::Rectangle& rRectangle, long nXStart, long nXEnd); -SAL_DLLPRIVATE voidImplPaintBorder(vcl::RenderContext& rRenderContext); +SAL_DLLPRIVATE voidImplPaintBorder(vcl::RenderContext const & rRenderContext); SAL_DLLPRIVATE voidImplShowCursor( bool bOnlyIfVisible = true ); SAL_DLLPRIVATE voidImplAlign(); SAL_DLLPRIVATE voidImplAlignAndPaint(); diff --git a/vcl/source/control/edit.cxx b/vcl/source/control/edit.cxx index 6e4e49018bff..c38490de2280 100644 --- a/vcl/source/control/edit.cxx +++ b/vcl/source/control/edit.cxx @@ -55,7 +55,6 @@ #include #include -#include #include #include @@ -997,7 +996,7 @@ void Edit::ImplClearBackground(vcl::RenderContext& rRenderContext, const tools:: } } -void Edit::ImplPaintBorder(vcl::RenderContext& rRenderContext) +void Edit::ImplPaintBorder(vcl::RenderContext const & rRenderContext) { // this is not needed when double-buffering if (SupportsDoubleBuffering()) @@ -1054,17 +1053,7 @@ void Edit::ImplPaintBorder(vcl::RenderContext& rRenderContext) } else { -// For some mysterious reason, in headless/svp rendering, -// pBorder has bad clipping region (shows as 1x1@0,0), -// and therefore doesn't render anything at all. -// In the case that we know we're in headless/svp, we -// render directly on the current context (the edit control). -// But if we (the editbox) are part of a more complex control -// (e.g. spinbox), we render not (i.e. we let pBorder pretend). -if (!mbIsSubEdit && comphelper::LibreOfficeKit::isActive()) -pBorder->Paint(rRenderContext, tools::Rectangle()); -else -pBorder->Paint(*pBorder, tools::Rectangle()); +pBorder->Paint(*pBorder, tools::Rectangle()); } } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128947] AutoCorrect (Replace) is not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=128947 antarx...@gmail.com changed: What|Removed |Added Hardware|All |x86-64 (AMD64) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128947] AutoCorrect (Replace) is not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=128947 --- Comment #1 from antarx...@gmail.com --- I have tested this in Ubuntu 18.04 and Windows 10 and the issue is the same. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128947] New: AutoCorrect (Replace) is not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=128947 Bug ID: 128947 Summary: AutoCorrect (Replace) is not saved Product: LibreOffice Version: 6.3.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: antarx...@gmail.com 1. Select Tools->AutoCorrect Options... 2. Add e.g. degC in the "Replace" field and °C in the "With" field The strings choosen are irrelevant. 3. Select New and OK. Result: The file acor_en-US.dat seems to be updated but the replacement is never stored. If you enter Tools->AutoCorrect Options... again the strings you have entered are gone. The problem is the same in Calc and Writer. I think this worked in LibreOffice 6.2. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128946] New: Libre Office Calc crashed with search in selected column
https://bugs.documentfoundation.org/show_bug.cgi?id=128946 Bug ID: 128946 Summary: Libre Office Calc crashed with search in selected column Product: LibreOffice Version: 6.3.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: duke...@gmail.com Description: Opened csv-file, selected column by press on column`s header, pressed Ctrl+H. Calc goes crashing from second press "Find Next". Using LibreOffice 6.3.3.2(x64) on Win 10 Steps to Reproduce: 1.Open csv-file 2.Select whole column 3.Press Ctrl+H 4.Fill "Find" 5.Press "Find Next" twice Actual Results: LibreOffice total crash Expected Results: Normal work) Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - chart2/qa chart2/source oox/source
chart2/qa/extras/chart2export.cxx | 14 ++ chart2/qa/extras/data/ods/tdf123774.ods|binary chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx |1 chart2/source/controller/itemsetwrapper/TextLabelItemConverter.cxx |1 oox/source/export/chartexport.cxx | 14 -- 5 files changed, 28 insertions(+), 2 deletions(-) New commits: commit c0cd2d4e0fa70d6eaf3cd3929bc0ad4786e9f4ed Author: Balazs Varga AuthorDate: Thu Nov 14 15:02:35 2019 +0100 Commit: László Németh CommitDate: Fri Nov 22 08:03:55 2019 +0100 tdf#123774 OOXML chart export: keep digits of percentages of data points by exporting PercentageNumberFormat, checking the "Label" format directly and taking the respective number format based on that. Note: also fix the "LinkNumberFormatToSource" property. If we create a pie chart with data labels and set the "Show value as number" or "Show value as percentage" and check on/off "Source format", this move is not set the property in the XPropertySet. Because of this, it fixes also the export of correct value of "link-data-style-to-source" property into ODS files. But this patch doesn't fix the export of old ODS files to OOXML, because they contain wrong (always true) "link-data-style-to-source" value. Change-Id: I4098a245dec5bf35cde20c9ccb79aca726230118 Reviewed-on: https://gerrit.libreoffice.org/82703 Reviewed-by: László Németh Tested-by: László Németh (cherry picked from commit a59eb39c6ec01ae2a9d8ddbb61a9c27f527c9caa) Reviewed-on: https://gerrit.libreoffice.org/83410 diff --git a/chart2/qa/extras/chart2export.cxx b/chart2/qa/extras/chart2export.cxx index 694e814250bd..8d42c8ac93ac 100644 --- a/chart2/qa/extras/chart2export.cxx +++ b/chart2/qa/extras/chart2export.cxx @@ -99,6 +99,7 @@ public: void testMarkerColorXLSX(); void testRoundedCornersXLSX(); void testAxisNumberFormatXLSX(); +void testDataPointLabelNumberFormatXLSX(); void testDataLabelDefaultValuesXLSX(); void testTitleOverlayXLSX(); void testInvertIfNegativeXLSX(); @@ -210,6 +211,7 @@ public: CPPUNIT_TEST(testMarkerColorXLSX); CPPUNIT_TEST(testRoundedCornersXLSX); CPPUNIT_TEST(testAxisNumberFormatXLSX); +CPPUNIT_TEST(testDataPointLabelNumberFormatXLSX); CPPUNIT_TEST(testDataLabelDefaultValuesXLSX); CPPUNIT_TEST(testTitleOverlayXLSX); CPPUNIT_TEST(testInvertIfNegativeXLSX); @@ -1584,6 +1586,18 @@ void Chart2ExportTest::testAxisNumberFormatXLSX() assertXPath(pXmlDoc, "/c:chartSpace/c:chart/c:plotArea/c:valAx[2]/c:numFmt", "sourceLinked", "1"); } +void Chart2ExportTest::testDataPointLabelNumberFormatXLSX() +{ +load("/chart2/qa/extras/data/ods/", "tdf123774.ods"); +xmlDocPtr pXmlDoc = parseExport("xl/charts/chart", "Calc Office Open XML"); +CPPUNIT_ASSERT(pXmlDoc); +assertXPath(pXmlDoc, "/c:chartSpace/c:chart/c:plotArea/c:pieChart/c:ser/c:dLbls/c:numFmt", "formatCode", "[$-40E]0.00%"); +assertXPath(pXmlDoc, "/c:chartSpace/c:chart/c:plotArea/c:pieChart/c:ser/c:dLbls/c:numFmt", "sourceLinked", "0"); + +assertXPath(pXmlDoc, "/c:chartSpace/c:chart/c:plotArea/c:pieChart/c:ser/c:dLbls/c:dLbl[1]/c:numFmt", "formatCode", "[$-40E]0.00%"); +assertXPath(pXmlDoc, "/c:chartSpace/c:chart/c:plotArea/c:pieChart/c:ser/c:dLbls/c:dLbl[1]/c:numFmt", "sourceLinked", "0"); +} + void Chart2ExportTest::testDataLabelDefaultValuesXLSX() { load("/chart2/qa/extras/data/xlsx/", "data_label.xlsx"); diff --git a/chart2/qa/extras/data/ods/tdf123774.ods b/chart2/qa/extras/data/ods/tdf123774.ods new file mode 100644 index ..5c422b58c357 Binary files /dev/null and b/chart2/qa/extras/data/ods/tdf123774.ods differ diff --git a/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx b/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx index 2856ff78b697..cdc70149a91f 100644 --- a/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx +++ b/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx @@ -154,6 +154,7 @@ bool lcl_UseSourceFormatFromItemToPropertySet( sal_uInt16 nWhichId, const SfxIte uno::Any aNewValue; bool bUseSourceFormat = static_cast< const SfxBoolItem & >( rItemSet.Get( nWhichId )).GetValue(); +xPropertySet->setPropertyValue(CHART_UNONAME_LINK_TO_SRC_NUMFMT, uno::Any(bUseSourceFormat)); if( !bUseSourceFormat ) { SfxItemState aState = rItemSet.GetItemState( nFormatWhich ); diff --git a/chart2/source/controller/itemsetwrapper/TextLabelItemConverter.cxx b/chart2/source/controller/itemsetwrapper/TextLabelItemConverter.cxx index ffbab285998e..346b4d5e6aa7 100644 --- a/chart2/source/controller/itemsetwrapper/TextLabelItemConverter.cxx +++ b/chart2/source/controller/itemsetwrapper/TextLabelItemConverter.cxx
[Libreoffice-bugs] [Bug 128898] import text from file with text-decode failed
https://bugs.documentfoundation.org/show_bug.cgi?id=128898 --- Comment #11 from Sean Carlos --- See also: https://ask.libreoffice.org/en/question/216342/problem-inserting-text-from-file-in-writer/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128898] import text from file with text-decode failed
https://bugs.documentfoundation.org/show_bug.cgi?id=128898 --- Comment #10 from Sean Carlos --- "Insert Text from file" also fails inserting a plain text or a html file. Inserting a plain text file I get a "Read Error. Error reading file." popup. Importing an html file I don't even see an error popup. This is a regression, it worked on Fedora Linux 30; upgrading to 31 (which included Libreoffice upgrade), it broke. Version: 6.3.3.2.0+ Build ID: 6.3.3.2-3.fc31 CPU threads: 4; OS: Linux 5.3; UI render: default; VCL: gtk3; Locale: it-IT (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sw/qa sw/source
sw/qa/extras/layout/data/tdf125300.docx |binary sw/qa/extras/layout/layout.cxx | 20 ++-- sw/source/core/inc/frmtool.hxx | 14 +- sw/source/core/layout/calcmove.cxx |4 ++-- sw/source/core/layout/flowfrm.cxx |2 +- sw/source/core/layout/frmtool.cxx | 17 + 6 files changed, 51 insertions(+), 6 deletions(-) New commits: commit 3cccdabf19a99fd3f657985c1822436d7679df2b Author: László Németh AuthorDate: Tue Nov 19 21:12:28 2019 +0100 Commit: László Németh CommitDate: Fri Nov 22 08:00:45 2019 +0100 tdf#125300 extend AddParaSpacingToTableCells with line spacing Now default compatibility mode AddParaSpacingToTableCells uses not only paragraph bottom margin, but also proportional line spacing before bottom cell border, as in MSO. Note: disable testForcepoint76, because it fails again with its fixed layout. Change-Id: I52f6204a5efc63aac4aa332a1563ada0cbeb9618 Reviewed-on: https://gerrit.libreoffice.org/83236 Tested-by: Jenkins Reviewed-by: László Németh (cherry picked from commit 2c918aa51e5528b090e52fa31b10fa17cf2593ae) Reviewed-on: https://gerrit.libreoffice.org/83430 diff --git a/sw/qa/extras/layout/data/tdf125300.docx b/sw/qa/extras/layout/data/tdf125300.docx new file mode 100644 index ..757a329d514b Binary files /dev/null and b/sw/qa/extras/layout/data/tdf125300.docx differ diff --git a/sw/qa/extras/layout/layout.cxx b/sw/qa/extras/layout/layout.cxx index 15a1e5f867e2..89df9aa18d90 100644 --- a/sw/qa/extras/layout/layout.cxx +++ b/sw/qa/extras/layout/layout.cxx @@ -2184,6 +2184,22 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testRedlineNumberInNumbering) assertXPath(pXmlDoc, "/metafile/push/push/push/textcolor[not(@color='#00')]", 6); } +CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testTdf125300) +{ +SwDoc* pDoc = createDoc("tdf125300.docx"); +SwDocShell* pShell = pDoc->GetDocShell(); + +// Dump the rendering of the first page as an XML file. +std::shared_ptr xMetaFile = pShell->GetPreviewMetaFile(); +MetafileXmlDump dumper; + +xmlDocPtr pXmlDoc = dumpAndParse(dumper, *xMetaFile); +CPPUNIT_ASSERT(pXmlDoc); + +// Keep line spacing before bottom cell border (it was 1892) +assertXPath(pXmlDoc, "/metafile/push[1]/push[1]/push[1]/push[5]/polyline/point[@y='2092']", 2); +} + CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testTdf116830) { SwDoc* pDoc = createDoc("tdf116830.odt"); @@ -2633,8 +2649,8 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testForcepointFootnoteFrame) createDoc("forcepoint-swfootnoteframe-1.rtf"); } -//just care it doesn't crash/assert -CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testForcepoint76) { createDoc("forcepoint76-1.rtf"); } +//FIXME: disabled after failing again with fixed layout +//CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testForcepoint76) { createDoc("forcepoint76-1.rtf"); } CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testTdf118058) { diff --git a/sw/source/core/inc/frmtool.hxx b/sw/source/core/inc/frmtool.hxx index 3edf774c9828..a32a5a0b9c62 100644 --- a/sw/source/core/inc/frmtool.hxx +++ b/sw/source/core/inc/frmtool.hxx @@ -297,6 +297,7 @@ class SwBorderAttrs : public SwCacheObj bool m_bTop : 1; bool m_bBottom : 1; bool m_bLine: 1; +bool m_bLineSpacing : 1; bool m_bIsLine : 1; // border on at least one side? @@ -320,7 +321,8 @@ class SwBorderAttrs : public SwCacheObj m_nTop, m_nBottom, m_nGetTopLine, - m_nGetBottomLine; + m_nGetBottomLine, + m_nLineSpacing; // only calculate lines and shadow void CalcTopLine_(); @@ -356,6 +358,9 @@ class SwBorderAttrs : public SwCacheObj const SwFrame *pCaller, const SwFrame *pCmp ) const; +// tdf#125300 line spacing before cell border +void CalcLineSpacing_(); + public: SwBorderAttrs( const SwModify *pOwner, const SwFrame *pConstructor ); virtual ~SwBorderAttrs() override; @@ -371,6 +376,7 @@ public: inline sal_uInt16 CalcRightLine() const; inline sal_uInt16 CalcTop() const; inline sal_uInt16 CalcBottom() const; +inline sal_uInt16 CalcLineSpacing() const; long CalcLeft( const SwFrame *pCaller ) const; long CalcRight( const SwFrame *pCaller ) const; @@ -511,6 +517,12 @@ inline sal_uInt16 SwBorderAttrs::CalcBottom() const const_cast(this)->CalcBottom_(); return m_nBottom; } +inline sal_uInt16 SwBorderAttrs::CalcLineSpacing() const +{ +if ( m_bLineSpacing ) +const_cast(this)->CalcLineSpacing_(); +return m_nLineSpacing; +} inline bool SwBorderAttrs::IsLine() const { if ( m_bLine ) diff --git a/sw/source/core/layout/calcmove.cxx b/sw/source/core/layout/calcmove.cxx index a8f4da4e79a4..caa81ecbd182 100644 --- a/sw/source/core/layout/calcmove.cxx +++
[Libreoffice-bugs] [Bug 36791] Text and images are not displayed from a docx document
https://bugs.documentfoundation.org/show_bug.cgi?id=36791 Chris Sherlock changed: What|Removed |Added CC||chris.sherloc...@gmail.com --- Comment #22 from Chris Sherlock --- Created attachment 156023 --> https://bugs.documentfoundation.org/attachment.cgi?id=156023=edit Office 365 on MacOS So interestingly, on Office 365 for MacOS, the wrong font is used also. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35986] Parts of EMF file not visible/stretched to an enormous extent
https://bugs.documentfoundation.org/show_bug.cgi?id=35986 --- Comment #20 from Chris Sherlock --- Sorry, wrong bug report got updated. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35986] Parts of EMF file not visible/stretched to an enormous extent
https://bugs.documentfoundation.org/show_bug.cgi?id=35986 Chris Sherlock changed: What|Removed |Added CC||chris.sherloc...@gmail.com --- Comment #19 from Chris Sherlock --- Created attachment 156022 --> https://bugs.documentfoundation.org/attachment.cgi?id=156022=edit Office 365 on MacOS So it is interesting that the wrong font is used for Office 365 on MacOS. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128907] Support for Hancom Office File Format (HWP)
https://bugs.documentfoundation.org/show_bug.cgi?id=128907 Mike Kaganski changed: What|Removed |Added Attachment #155962|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128907] Support for Hancom Office File Format (HWP)
https://bugs.documentfoundation.org/show_bug.cgi?id=128907 Mike Kaganski changed: What|Removed |Added Attachment #155963|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128907] Support for Hancom Office File Format (HWP)
https://bugs.documentfoundation.org/show_bug.cgi?id=128907 Mike Kaganski changed: What|Removed |Added Attachment #155958|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128907] Support for Hancom Office File Format (HWP)
https://bugs.documentfoundation.org/show_bug.cgi?id=128907 Mike Kaganski changed: What|Removed |Added Attachment #155959|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128907] Support for Hancom Office File Format (HWP)
https://bugs.documentfoundation.org/show_bug.cgi?id=128907 Mike Kaganski changed: What|Removed |Added Attachment #155957|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128907] Support for Hancom Office File Format (HWP)
https://bugs.documentfoundation.org/show_bug.cgi?id=128907 Mike Kaganski changed: What|Removed |Added Attachment #155956|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128907] Support for Hancom Office File Format (HWP)
https://bugs.documentfoundation.org/show_bug.cgi?id=128907 --- Comment #13 from Mike Kaganski --- Please don't confirm your own bug reports. That should be done independently by other people. However, I confirm this is a valid request, different from tdf#108848 (which was specific for Android viewer, as mentioned in comment 11). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: editeng/source sw/source
editeng/source/misc/svxacorr.cxx|1 + sw/source/core/swg/SwXMLTextBlocks1.cxx | 28 2 files changed, 9 insertions(+), 20 deletions(-) New commits: commit f61f00862380fed99a09a11d67fef5d8efbce368 Author: Noel Grandin AuthorDate: Wed Nov 20 11:32:54 2019 +0200 Commit: Noel Grandin CommitDate: Fri Nov 22 06:46:43 2019 +0100 log exceptions when parsing to make debugging easier Change-Id: Ia19384a925a2bb437fa5d961e6c3d44eebe0c6b6 Reviewed-on: https://gerrit.libreoffice.org/83345 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx index 24ff88d8e725..48d6676b26f2 100644 --- a/editeng/source/misc/svxacorr.cxx +++ b/editeng/source/misc/svxacorr.cxx @@ -2181,6 +2181,7 @@ SvxAutocorrWordList* SvxAutoCorrectLanguageLists::LoadAutocorrWordList() } catch ( const uno::Exception& ) { +TOOLS_WARN_EXCEPTION("editeng", "when loading " << sShareAutoCorrFile); } // Set time stamp diff --git a/sw/source/core/swg/SwXMLTextBlocks1.cxx b/sw/source/core/swg/SwXMLTextBlocks1.cxx index 843e545a39a0..f4880417e929 100644 --- a/sw/source/core/swg/SwXMLTextBlocks1.cxx +++ b/sw/source/core/swg/SwXMLTextBlocks1.cxx @@ -23,6 +23,7 @@ #include #include #include +#include #include #include #include @@ -400,11 +401,12 @@ ErrCode SwXMLTextBlocks::PutBlockText( const OUString& rShort, void SwXMLTextBlocks::ReadInfo() { -try -{ const OUString sDocName( XMLN_BLOCKLIST ); -if ( xBlkRoot.is() && xBlkRoot->hasByName( sDocName ) && xBlkRoot->isStreamElement( sDocName ) ) +try { +if ( !xBlkRoot.is() || !xBlkRoot->hasByName( sDocName ) || !xBlkRoot->isStreamElement( sDocName ) ) +return; + uno::Reference< uno::XComponentContext > xContext = comphelper::getProcessComponentContext(); @@ -425,26 +427,12 @@ void SwXMLTextBlocks::ReadInfo() xParser->setTokenHandler( xTokenHandler ); // parse -try -{ -xParser->parseStream( aParserInput ); -} -catch( xml::sax::SAXParseException& ) -{ -// re throw ? -} -catch( xml::sax::SAXException& ) -{ -// re throw ? -} -catch( io::IOException& ) -{ -// re throw ? -} -} +xParser->parseStream( aParserInput ); } catch ( uno::Exception& ) { +TOOLS_WARN_EXCEPTION("sw", "when loading " << sDocName); +// re throw ? } } void SwXMLTextBlocks::WriteInfo() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128779] Add some API for QR Code Generator in LibreOffice BASIC
https://bugs.documentfoundation.org/show_bug.cgi?id=128779 --- Comment #3 from elmau --- it's easy add more options... in the last version (0.6.0) you can call by code Sub Main() Dim args(2) As New com.sun.star.beans.NamedValue zaz = createUnoService("net.elmau.zaz.BarCode") args(0).Name = "Type" args(0).Value = "qrcode" args(1).Name = "Data" args(1).Value = "libreoffice.org" path = zaz.execute(args) MsgBox path args(0).Name = "Type" args(0).Value = "qrcode" args(1).Name = "Data" args(1).Value = "libreoffice.org" args(2).Name = "Path" args(2).Value = "/home/mau/tmp.svg" zaz.execute(args) End Sub -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124123] Character spacing problems with Dymo LabelWriter in Best print quality
https://bugs.documentfoundation.org/show_bug.cgi?id=124123 QA Administrators changed: What|Removed |Added Whiteboard|QA:needsComment | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126607] undocked find doesn't get focus on KDE
https://bugs.documentfoundation.org/show_bug.cgi?id=126607 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127626] LibreOfficeDraw - Suggestion of improvement : autosizing text in entry fields
https://bugs.documentfoundation.org/show_bug.cgi?id=127626 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124185] #EDITING #TABLE (Paste on Table Bug)
https://bugs.documentfoundation.org/show_bug.cgi?id=124185 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128655] Basic For statement supports "For Each item In array" second syntax that's not documented
https://bugs.documentfoundation.org/show_bug.cgi?id=128655 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 Bug 103100 depends on bug 124185, which changed state. Bug 124185 Summary: #EDITING #TABLE (Paste on Table Bug) https://bugs.documentfoundation.org/show_bug.cgi?id=124185 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127626] LibreOfficeDraw - Suggestion of improvement : autosizing text in entry fields
https://bugs.documentfoundation.org/show_bug.cgi?id=127626 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 Bug 102593 depends on bug 124185, which changed state. Bug 124185 Summary: #EDITING #TABLE (Paste on Table Bug) https://bugs.documentfoundation.org/show_bug.cgi?id=124185 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124185] #EDITING #TABLE (Paste on Table Bug)
https://bugs.documentfoundation.org/show_bug.cgi?id=124185 --- Comment #3 from QA Administrators --- Dear nory, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93348] Base crashes when entering login information for jdbc connection to MariaDB database (Windows 64bit)
https://bugs.documentfoundation.org/show_bug.cgi?id=93348 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124897] Conditional format is changing format templates
https://bugs.documentfoundation.org/show_bug.cgi?id=124897 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104790] [META] Database connectivity interfaces (ODBC, JDBC..) and external databases
https://bugs.documentfoundation.org/show_bug.cgi?id=104790 Bug 104790 depends on bug 93348, which changed state. Bug 93348 Summary: Base crashes when entering login information for jdbc connection to MariaDB database (Windows 64bit) https://bugs.documentfoundation.org/show_bug.cgi?id=93348 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93348] Base crashes when entering login information for jdbc connection to MariaDB database (Windows 64bit)
https://bugs.documentfoundation.org/show_bug.cgi?id=93348 --- Comment #13 from QA Administrators --- Dear Andreas Gottardi, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87351] [META] Conditional formatting bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=87351 Bug 87351 depends on bug 124897, which changed state. Bug 124897 Summary: Conditional format is changing format templates https://bugs.documentfoundation.org/show_bug.cgi?id=124897 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51345] FILEOPEN: x:num attribute is not handled while importing HTML files created by Excel 2003
https://bugs.documentfoundation.org/show_bug.cgi?id=51345 --- Comment #14 from QA Administrators --- Dear Marek Ozana, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82091] Spelling dialog correction of Calc cells does not remove red wavy underline, but context menu spelling correction does
https://bugs.documentfoundation.org/show_bug.cgi?id=82091 --- Comment #20 from QA Administrators --- Dear penttila, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124897] Conditional format is changing format templates
https://bugs.documentfoundation.org/show_bug.cgi?id=124897 --- Comment #4 from QA Administrators --- Dear Joachim Wetzig, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128945] New: Tip content does not wrap properly in "Tip of the day" window
https://bugs.documentfoundation.org/show_bug.cgi?id=128945 Bug ID: 128945 Summary: Tip content does not wrap properly in "Tip of the day" window Product: LibreOffice Version: 6.3.3.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: trivial Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: z...@stellardrift.ca Description: The LibreOffice Tip of the day window shows the tip content as one single line, potentially spilling off the right edge of the window when the tip text is long enough. Steps to Reproduce: 1. Open LibreOffice on a new profile to show tip of the day window Actual Results: If tip is longer than can fit in one line in the window, tip text continues to the right (only becoming visible if the dialog is resized) Expected Results: Tip text longer than one line should continue onto the next line. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128945] Tip content does not wrap properly in "Tip of the day" window
https://bugs.documentfoundation.org/show_bug.cgi?id=128945 --- Comment #1 from z...@stellardrift.ca --- Created attachment 156021 --> https://bugs.documentfoundation.org/attachment.cgi?id=156021=edit image of the tip window displaying incorrect behaviour -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128101] manual page breaks crashes Android Viewer - Cannot View ODT Document at LibreOffice Viewer, Collabora Office/iOS
https://bugs.documentfoundation.org/show_bug.cgi?id=128101 --- Comment #10 from baffclan --- Reproduce with Newest LibreOffice Viewer. LibreOffice Viewer / Android Version: 6.5.0.0 alpha0+ BuildID: 1c58b2a437a7 Android-ARM@24-Bytemark-Hosting/2019-11-22_01.28.26 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 124536] Crash while opening Chinese documents
https://bugs.documentfoundation.org/show_bug.cgi?id=124536 --- Comment #11 from baffclan --- Reproduce with Newest LibreOffice Viewer. LibreOffice Viewer / Android Version: 6.5.0.0 alpha0+ BuildID: 1c58b2a437a7 Android-ARM@24-Bytemark-Hosting/2019-11-22_01.28.26 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128944] LibreOffice Crash using LXQT 0.14.1
https://bugs.documentfoundation.org/show_bug.cgi?id=128944 --- Comment #1 from Hector Colina --- Created attachment 156020 --> https://bugs.documentfoundation.org/attachment.cgi?id=156020=edit output running libreoffice --backtrace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128944] New: LibreOffice Crash using LXQT 0.14.1
https://bugs.documentfoundation.org/show_bug.cgi?id=128944 Bug ID: 128944 Summary: LibreOffice Crash using LXQT 0.14.1 Product: LibreOffice Version: 6.2.8.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hcol...@gmail.com Description: Triying to run LibreOfice 6.2 and 6.3 over LxQT crash every time. Just I opening a new session using mate and them LibreOffice works perfectly but if I return to LxQT crash again. I send a report crash available on https://crashreport.libreoffice.org/stats/crash_details/7944c09f-b27c-4eb2-8abb-7d1a73993bce Steps to Reproduce: 1. Install LXqt version 0.14.1 2. Open LibreOffice Actual Results: LIbreOffice never start and I give : [ 3455.447347] soffice.bin[8198]: segfault at 1110 ip 1110 sp 7ffd032d8998 error 14 in soffice.bin[40+1000] [ 3455.447355] Code: Bad RIP value. [ 3667.268064] soffice.bin[8323]: segfault at 1110 ip 1110 sp 7ffd72a7aae8 error 14 in soffice.bin[40+1000] [ 3667.268072] Code: Bad RIP value. Expected Results: LibreOffice dont start Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Crash test update
Am 21.11.19 um 16:58 schrieb Caolán McNamara: >>1 SwIndexReg::~SwIndexReg >>5 SwSubFont::GetTextSize_ >> this one is my fault ^ >> 14 writerfilter::dmapper::DomainMapper_Impl::PushFootOrEndnote > I believe ^this^ one is since > > commit a991ad93dcd6807d0eacd11a50c2ae43a2cfb882 > Author: Jan-Marek Glogowski > Date: Tue Oct 22 12:24:43 2019 +0200 > > tdf#121441 improve DOCX footnote import > > caolanm->jmux: Import of e.g. tdf103063-1.docx is an example of these > 14, any ideas on that assert ? I think we already talked about this on IRC and I said I'm Ok with removing it. Technically the code can't handle nested footnotes (never could, as it's just using a "global" boolean in DomainMapper_Impl). As I understood the specs, it's also not allowed, but I might be wrong here. So you can remove that assert, and if the rest of the code eventually survives, it'll just produce some interesting variant of a "correct" document ;-) Or replace it with a SAL_WARN, but that probably won't help it get fixed either, as my debug build spills warns every time I open a document, or even just start LO. Jan-Marek ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 125480] Crash in: SbiRuntime::Step()
https://bugs.documentfoundation.org/show_bug.cgi?id=125480 Andrew Richardson changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED CC||spu...@yahoo.com Assignee|libreoffice-b...@lists.free |spu...@yahoo.com |desktop.org | --- Comment #3 from Andrew Richardson --- Created attachment 156019 --> https://bugs.documentfoundation.org/attachment.cgi?id=156019=edit Archive with "Demo" application & database Bug replicated using Windows10 & LO Version: 6.3.3.2 (x64) Instructions: 1. Extract archive files into new folder 2. Double-click the "Demo.odb" file 3. On initial form, - select any name from first listbox field - click "Waterfront" or "Camping" Reservation button 4. Wait for new form to initialize, and "Customer" fields to populate 5. Use "Next Record" control to advance through record-set. Note the subforms will update based on the customer record. 6. Repeat step 5 until crash. Note: Crash seems to take more operations to occur using latest LO version. Tester may need to close Reservation form, reopen, and advance records to trigger crash. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: external/libwps
external/libwps/UnpackedTarball_libwps.mk |2 external/libwps/libwps-lotus-version-tdf127887-upstream.patch | 111 ++ external/libwps/libwps-lotus-version-tdf127887.patch.1| 44 --- 3 files changed, 112 insertions(+), 45 deletions(-) New commits: commit 1c58b2a437a7083c40c93a1c2e12a6fe6b6fd637 Author: Eike Rathke AuthorDate: Thu Nov 21 20:25:51 2019 +0100 Commit: Eike Rathke CommitDate: Fri Nov 22 02:26:31 2019 +0100 Replace hotfix with upstream patch, tdf#127887 follow-up This attempt tries to avoid affecting other .wk1 files as well. The old fix was even applied to the wrong patch section, not done for MacOSX or Windows. Geez.. Change-Id: Ia79383f33ff760cba9bfb44f166e27f3ef212c57 Reviewed-on: https://gerrit.libreoffice.org/83431 Reviewed-by: Eike Rathke Tested-by: Jenkins diff --git a/external/libwps/UnpackedTarball_libwps.mk b/external/libwps/UnpackedTarball_libwps.mk index b0d5dff309bd..4fd566755170 100644 --- a/external/libwps/UnpackedTarball_libwps.mk +++ b/external/libwps/UnpackedTarball_libwps.mk @@ -21,13 +21,13 @@ $(eval $(call gb_UnpackedTarball_add_patches,libwps,\ $(if $(SYSTEM_REVENGE),,external/libwps/rpath.patch.0) \ external/libwps/libtool.patch.0 \ external/libwps/0001-Make-comparison-operator-member-functions-const.patch \ + external/libwps/libwps-lotus-version-tdf127887-upstream.patch \ )) ifneq ($(OS),MACOSX) ifneq ($(OS),WNT) $(eval $(call gb_UnpackedTarball_add_patches,libwps,\ external/libwps/libwps-bundled-soname.patch.0 \ - external/libwps/libwps-lotus-version-tdf127887.patch.1 \ )) endif endif diff --git a/external/libwps/libwps-lotus-version-tdf127887-upstream.patch b/external/libwps/libwps-lotus-version-tdf127887-upstream.patch new file mode 100644 index ..012a8a00e991 --- /dev/null +++ b/external/libwps/libwps-lotus-version-tdf127887-upstream.patch @@ -0,0 +1,111 @@ +This is a combination of upstream patches. + +commit d74790b4bd55a3a11b56dbbd670c3baa1331e6dd +CommitDate: Thu Oct 31 11:26:08 2019 +0100 + +lotus[wb1]: try to correct the retrieving of row references in formula... + + +commit 39be60f9045a758178d90526ae66b0e3d24f348e +CommitDate: Thu Oct 31 13:28:54 2019 +0100 + +wks,wk1,...: try to read correctly the row cell's references... + + +commit 188933f0d66c77a19ccb0b5f5151a4c9f7203fbc +CommitDate: Thu Oct 31 14:30:26 2019 +0100 + +wks,wk1: do not change the maximum number of columns... + + +commit c1ba33b7505cff91f57d5aa7e8c6ff8706b63a21 +CommitDate: Thu Oct 31 15:09:19 2019 +0100 + +WKS4Spreadsheet.cpp: simplify the code... + + +diff --git a/src/lib/WKS4.cpp b/src/lib/WKS4.cpp +index 2f222d3..a92eace 100644 +--- a/src/lib/WKS4.cpp b/src/lib/WKS4.cpp +@@ -836,7 +836,7 @@ bool WKS4Parser::readZone() + val=int(libwps::readU8(input)); + f << "Entries(ItCount):dos"; + if (val!=1) f << "=" << val << ","; +- if (m_state->m_version==2) ++ else if (m_state->m_version==2) + m_state->m_version=1; + isParsed = needWriteInAscii = true; + break; +diff --git a/src/lib/WKS4Spreadsheet.cpp b/src/lib/WKS4Spreadsheet.cpp +index caaf4e1..582f377 100644 +--- a/src/lib/WKS4Spreadsheet.cpp b/src/lib/WKS4Spreadsheet.cpp +@@ -1798,10 +1798,14 @@ bool WKS4Spreadsheet::readCell + for (int dim = 0; dim < 2; dim++) + { + auto val = int(libwps::readU16(m_input)); +- if ((val & 0xF000) == 0); // absolue value ? +- else if ((val & 0xc000) == 0x8000) // relative ? ++ if ((val & 0x8000) == 0); // absolue value ? ++ else + { +- if (version()==1) ++ // relative ++ // wb1: maximum row=0x2000, maximum col=0x100 ++ // wks dos (v3) maximum row=0x4000, maximum col=0x100 ++ // wdb maximum number of data ? ++ if (version()==1 && dim==0) + { + val &= 0xFF; + if ((val & 0x80) && val+actPos[dim] >= 0x100) +@@ -1810,27 +1814,17 @@ bool WKS4Spreadsheet::readCell + } + else + { +- val &= 0x3FFF; +- if (val & 0x2000) val = val - 0x4000; ++ // 0x400 for old file(unsure), ie. find many problematic files on ++ // the web, so maybe 0x4000 is ok and these files are ++ // problematic ++ int const maxVal= (dim==1 || m_mainParser.creator()==libwps::WPS_LOTUS) ? 0x2000 : version()==1 ? 0x400 : 0x4000; ++
[Libreoffice-commits] online.git: test/UnitWOPI.cpp
test/UnitWOPI.cpp | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) New commits: commit ddb697bfa5c1257dbfc4b9c3ab89dc7673ad1e9d Author: Ashod Nakashian AuthorDate: Sun Nov 17 08:46:05 2019 -0500 Commit: Ashod Nakashian CommitDate: Fri Nov 22 01:51:34 2019 +0100 test: validate ExtendedData sent to WOPI Change-Id: Ib5da41e7f1ca7547ea6ac43daefa4b0259ba4c41 Reviewed-on: https://gerrit.libreoffice.org/83045 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/test/UnitWOPI.cpp b/test/UnitWOPI.cpp index 863dc4c13..b7c57a6ac 100644 --- a/test/UnitWOPI.cpp +++ b/test/UnitWOPI.cpp @@ -70,6 +70,10 @@ public: // and this test fakes that it's an autosave CPPUNIT_ASSERT_EQUAL(std::string("true"), request.get("X-LOOL-WOPI-IsAutosave")); +// Check that we get the extended data. +CPPUNIT_ASSERT_EQUAL(std::string("CustomFlag=Custom Value;AnotherFlag=AnotherValue"), + request.get("X-LOOL-WOPI-ExtendedData")); + _finishedSaveModified = true; } @@ -105,7 +109,11 @@ public: } case Phase::SaveModified: { -helpers::sendTextFrame(*getWs()->getLOOLWebSocket(), "save dontTerminateEdit=0 dontSaveIfUnmodified=0", testName); +helpers::sendTextFrame(*getWs()->getLOOLWebSocket(), + "save dontTerminateEdit=0 dontSaveIfUnmodified=0 " + "extendedData=CustomFlag%3DCustom%20Value%3BAnotherFlag%" + "3DAnotherValue", + testName); _phase = Phase::Polling; _savingPhase = SavingPhase::Modified; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loleaflet/html loleaflet/src wsd/ClientSession.cpp wsd/FileServer.cpp
loleaflet/html/framed.doc.html|5 +++-- loleaflet/src/map/handler/Map.WOPI.js |5 - wsd/ClientSession.cpp |5 + wsd/FileServer.cpp|5 +++-- 4 files changed, 15 insertions(+), 5 deletions(-) New commits: commit 7c4ba459ff70bf4050ad4a936796845f04f6b127 Author: Ashod Nakashian AuthorDate: Sat Nov 16 11:59:39 2019 -0500 Commit: Ashod Nakashian CommitDate: Fri Nov 22 01:51:11 2019 +0100 Encode the ExtendedData to make it safer while embedding in messages Change-Id: I1d4bdb2775d89e9a52a96d833228ca8577ee3561 Reviewed-on: https://gerrit.libreoffice.org/83044 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loleaflet/html/framed.doc.html b/loleaflet/html/framed.doc.html index 80f842c40..df0207c84 100644 --- a/loleaflet/html/framed.doc.html +++ b/loleaflet/html/framed.doc.html @@ -48,7 +48,7 @@ function save() { post({'MessageId': 'Action_Save', - 'Values': { 'Notify': true, 'ExtendedData': 'CustomFlag=CustomValue;AnotherFlag=AnotherValue' } + 'Values': { 'Notify': true, 'ExtendedData': 'CustomFlag=Custom Value;AnotherFlag=AnotherValue' } }); } @@ -126,9 +126,10 @@ +Note: Set net/frame_ancestors in loolwsd.xml to contain 'file:' (without the quotes, but with the colon), otherwise you will get CSP violation. And force reload, or clear caches, otherwise you might get served from the browser cache.. Click here to insert the following text into the document: - + diff --git a/loleaflet/src/map/handler/Map.WOPI.js b/loleaflet/src/map/handler/Map.WOPI.js index 9c3201554..dcd401407 100644 --- a/loleaflet/src/map/handler/Map.WOPI.js +++ b/loleaflet/src/map/handler/Map.WOPI.js @@ -142,7 +142,9 @@ L.Map.WOPI = L.Handler.extend({ }, _postMessageListener: function(e) { - if (e.origin !== window.parent.origin) { + + // e.origin === 'null' when sandboxed (i.e. when the parent is a file on local filesystem). + if (e.origin !== 'null' && e.origin !== window.parent.origin) { return; } @@ -321,6 +323,7 @@ L.Map.WOPI = L.Handler.extend({ var dontTerminateEdit = msg.Values && msg.Values['DontTerminateEdit']; var dontSaveIfUnmodified = msg.Values && msg.Values['DontSaveIfUnmodified']; var extendedData = msg.Values && msg.Values['ExtendedData']; + extendedData = encodeURIComponent(extendedData); this._notifySave = msg.Values && msg.Values['Notify']; this._map.save(dontTerminateEdit, dontSaveIfUnmodified, extendedData); diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp index e0ba29bb2..c55985a9f 100644 --- a/wsd/ClientSession.cpp +++ b/wsd/ClientSession.cpp @@ -524,7 +524,12 @@ bool ClientSession::_handleInput(const char *buffer, int length) std::string extendedData; if (tokens.size() > 3) +{ getTokenString(tokens[3], "extendedData", extendedData); +std::string decoded; +Poco::URI::decode(extendedData, decoded); +extendedData = decoded; +} constexpr bool isAutosave = false; constexpr bool isExitSave = false; diff --git a/wsd/FileServer.cpp b/wsd/FileServer.cpp index 5f49450c1..3cf3fbc51 100644 --- a/wsd/FileServer.cpp +++ b/wsd/FileServer.cpp @@ -276,7 +276,7 @@ void FileServerRequestHandler::handleRequest(const HTTPRequest& request, Poco::M std::string path(requestUri.getPath()); if (path.find("loleaflet/" LOOLWSD_VERSION_HASH "/") == std::string::npos) { -LOG_WRN("client - server version mismatch, disabling browser cache."); +LOG_WRN("client - server version mismatch, disabling browser cache. Expected: " LOOLWSD_VERSION_HASH); noCache = true; } @@ -845,7 +845,8 @@ void FileServerRequestHandler::preprocessFile(const HTTPRequest& request, Poco:: oss.str(preprocess); } -socket->send(oss.str()); +preprocess = oss.str(); +socket->send(preprocess); LOG_DBG("Sent file: " << relPath << ": " << preprocess); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128939] Libo does not start
https://bugs.documentfoundation.org/show_bug.cgi?id=128939 --- Comment #1 from Luis Guzman --- Whats distribution are you using, version, package manager. That information will help test and reproduce your issue, otherwise it will be almost impossible. Trisquel Etiona (9), amd64 Id. de compilación: 1:6.3.3-0ubuntu0.18.04.1~lo1+9.0trisquel1 Working fine ;) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128943] Remove frames around rotation wheel and reference edge widget within Format / Cells / Alignment dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=128943 --- Comment #1 from Thorsten Wagner --- Created attachment 156017 --> https://bugs.documentfoundation.org/attachment.cgi?id=156017=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128943] New: Remove frames around rotation wheel and reference edge widget within Format / Cells / Alignment dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=128943 Bug ID: 128943 Summary: Remove frames around rotation wheel and reference edge widget within Format / Cells / Alignment dialog Product: LibreOffice Version: 6.5.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thorsten.wagne...@gmail.com Description: Issue is a follow up from tdf#125508: Black frame lines around rotation wheel and reference edge widget within Format / Cells / Alignment dialog may not be intended (see screenshot attached) Steps to Reproduce: 1. Open LO Calc 2. Open Format / Cells / Alignment dialog Actual Results: Black frame lines are drawn around rotation wheel as well as around reference edge widget. Expected Results: Rotation wheel and reference edge widget are drawn without frames. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128942] New: Remove frame around rotation wheel within Position and Size / Ratation dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=128942 Bug ID: 128942 Summary: Remove frame around rotation wheel within Position and Size / Ratation dialog Product: LibreOffice Version: 6.5.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thorsten.wagne...@gmail.com Description: Issue is a follow up from tdf#125508: Black frame lines around rotation wheel within Position and Size / Ratation dialog may not be intended (see screenshot attached) Steps to Reproduce: 1. Open LO Impress 2. Draw an arbitrary object 2. Open Position and Size / Rotation dialog Actual Results: Black frame lines are drawn around rotation wheel. Expected Results: Rotation wheel is drawn without frame. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128942] Remove frame around rotation wheel within Position and Size / Ratation dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=128942 --- Comment #1 from Thorsten Wagner --- Created attachment 156016 --> https://bugs.documentfoundation.org/attachment.cgi?id=156016=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128941] Remove frame around color palette within Paragraph / Area / Color dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=128941 --- Comment #1 from Thorsten Wagner --- Created attachment 156015 --> https://bugs.documentfoundation.org/attachment.cgi?id=156015=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128941] New: Remove frame around color palette within Paragraph / Area / Color dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=128941 Bug ID: 128941 Summary: Remove frame around color palette within Paragraph / Area / Color dialog Product: LibreOffice Version: 6.5.0.0.alpha0+ Master Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thorsten.wagne...@gmail.com Description: Issue is a follow up from tdf#125508: Black frame lines around color palette within Paragraph / Area / Color dialog may not be intended (see screenshot attached) Steps to Reproduce: 1. Open LO Writer 2. Open Paragraph / Area / Color dialog Actual Results: Black frame lines are drawn around color palette. Expected Results: Color palette is drawn without frame. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100632] SIDEBAR, FILEOPEN: Certain Position & Size fields in Sidebar are not filled for this SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=100632 NISZ LibreOffice Team changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||1922 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111922] Draw/Impress Sidebar with point measurement units set, incorrect Size measurements shown on Position and Size content panel--but shows correctly on properties dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=111922 NISZ LibreOffice Team changed: What|Removed |Added CC||kelem...@ubuntu.com, ||libreoff...@nisz.hu See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||0632 --- Comment #6 from NISZ LibreOffice Team --- This is the same issue as: https://bugs.documentfoundation.org/show_bug.cgi?id=100632#c6 but let's keep this open since that bug is about multiple issues. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128940] Bad layout of Remote Files / Add Service button on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=128940 --- Comment #3 from Thorsten Wagner --- Screenshot 1 was taken from current revision of master Version: 6.5.0.0.alpha0+ Build ID: d312d02cf43928361be34207a0cdd2d95b3ec5fd CPU threads: 12; OS: Mac OS X 10.14.6; UI render: GL; VCL: osx; Locale: de-DE (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128940] Bad layout of Remote Files / Add Service button on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=128940 --- Comment #2 from Thorsten Wagner --- Created attachment 156014 --> https://bugs.documentfoundation.org/attachment.cgi?id=156014=edit Screenshot 2 from LO 5.4 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128940] Bad layout of Remote Files / Add Service button on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=128940 --- Comment #1 from Thorsten Wagner --- Created attachment 156013 --> https://bugs.documentfoundation.org/attachment.cgi?id=156013=edit Screenshot 1 from current master -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128940] New: Bad layout of Remote Files / Add Service button on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=128940 Bug ID: 128940 Summary: Bad layout of Remote Files / Add Service button on macOS Product: LibreOffice Version: 6.5.0.0.alpha0+ Master Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thorsten.wagne...@gmail.com Description: Layout of Remote Files / Add Service button has changed. Old layout was more compliant to macOS UI design. New Layout has only very tiny drop down arrow. Another button layout is rendered within while moving mouse over. Steps to Reproduce: 1. Open LO Startcenter 2. Select Remote Files 3. Move mouse over Add Service button Actual Results: Actual layout has only very tiny drop down arrow. Another button layout is rendered within while moving mouse over (see Screenshot 1 from current master attached). Expected Results: Restore previous layout (see Screenshut 2 form LO 5.4 attached). Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [ABANDONED] Remove some excessive log formatting
> On 21 Nov 2019, at 10:47 pm, Luboš Luňák wrote: > > On Thursday 21 of November 2019, Stephan Bergmann wrote: >> On 21/11/2019 11:25, Chris Sherlock wrote: >>> Just a quick query to the ML - when I’m attempting to troubleshoot >>> issues with EMF files, I use SAL_INFO to see what records it is reading. >>> It’s already helped me work out some issues, in particular the last one >>> was around custom line caps. >>> >>> How else should we be doing this? >> >> I guess there's no ideal answer. > > While I agree that there's no ideal answer, the way I see it is that there > should be a preferred answer, and that's how I see SAL_INFO. > Hm, sounds rather like a misuse of the SAL log facility to me. (Each use of it comes at a cost, so it shouldn't be used too lightly for anything but logging unusual events.) > > E.g. currently while writing the Skia VCL backend I've added SAL_INFO to > pretty much to each of the drawing functions. And of course normally nobody > wants to see that, but it can be useful if needed, all it takes is setting > SAL_LOG, and it fits nicely with the code (no #ifdefs or anything). So I > disagree with it being just for the unusual stuff (that's SAL_WARN). Hi Lubos, I’m really interested in this work - are you working on a particular branch? Chris > -- > Luboš Luňák > l.lu...@collabora.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 125535] Inconsistent coloring of selected items within lists on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=125535 Thorsten Wagner changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #5 from Thorsten Wagner --- Seems to be resolved with current revision from master Version: 6.5.0.0.alpha0+ Build ID: d312d02cf43928361be34207a0cdd2d95b3ec5fd CPU threads: 12; OS: Mac OS X 10.14.6; UI render: GL; VCL: osx; Locale: de-DE (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125537] Object's width / height is shown different on Impress' / Calc's sidebar and statusbar
https://bugs.documentfoundation.org/show_bug.cgi?id=125537 Thorsten Wagner changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125537] Object's width / height is shown different on Impress' / Calc's sidebar and statusbar
https://bugs.documentfoundation.org/show_bug.cgi?id=125537 --- Comment #5 from Thorsten Wagner --- Created attachment 156012 --> https://bugs.documentfoundation.org/attachment.cgi?id=156012=edit Screenshot 3 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125537] Object's width / height is shown different on Impress' / Calc's sidebar and statusbar
https://bugs.documentfoundation.org/show_bug.cgi?id=125537 --- Comment #4 from Thorsten Wagner --- Created attachment 156011 --> https://bugs.documentfoundation.org/attachment.cgi?id=156011=edit Screenshot 2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125537] Object's width / height is shown different on Impress' / Calc's sidebar and statusbar
https://bugs.documentfoundation.org/show_bug.cgi?id=125537 --- Comment #3 from Thorsten Wagner --- Something seems to have changed in the meantime. Now behaviour is as follows: (1) Open Impress (2) Draw a rectangle (3) Horizontal as well as vertical position is shown equally in statusbar and sidebar (4) Width and hight is shown different in statusbar and sidebar (results in sidebar are wrong), see Screenshot 2 attached (5) Resize rectangle (6) Width and hight are now shown equally in statusbar and sidebar (both results are correct), see Screenshot 3 attached Version: 6.5.0.0.alpha0+ Build ID: d312d02cf43928361be34207a0cdd2d95b3ec5fd CPU threads: 12; OS: Mac OS X 10.14.6; UI render: GL; VCL: osx; Locale: de-DE (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80786] Feature request: Function to remove field codes, turning all fields into plain text
https://bugs.documentfoundation.org/show_bug.cgi?id=80786 Troy Rollo changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |libreoff...@troy.rollo.name |desktop.org | --- Comment #7 from Troy Rollo --- This is an important feature for professional uses of LibreOffice, and one that is fairly easily implemented. Taking it on with a target to complete by end January. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128939] New: Libo does not start
https://bugs.documentfoundation.org/show_bug.cgi?id=128939 Bug ID: 128939 Summary: Libo does not start Product: LibreOffice Version: 6.3.3.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: zika...@yahoo.com Starting at version 6.3.3.xx LO version X86_64 does not strat any more. In a terminal, the error returned is: /opt/libreoffice6.3/program/libvclplug_gtk3lo.so: undefined symbol: _ZN19SvpSalVirtualDeviceC1E12DeviceFormatP14_cairo_surface -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128898] import text from file with text-decode failed
https://bugs.documentfoundation.org/show_bug.cgi?id=128898 --- Comment #9 from mhonline --- oops - sorry - seems not to be related to "text/encoded" only I can reproduce this issue for import-text-from-file with "Text(normal)" and ".doc" with same error-message while import from .odt does not import anything - without error-message. So the problems seems to be somewhere else in LO. m. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-6.3.4.1'
Tag 'libreoffice-6.3.4.1' created by Christian Lohmaier at 2019-11-21 21:23 + Tag libreoffice-6.3.4.1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAl3XAD0ACgkQ9DSh76/u rqMzsw/9HV/yGsrSUFXmOkVaZqkueoN4Wum4CIUafJKUTpFTiJJKEjR1zzKVsi1r /iEWDlEPrNbp0MPiTfINvu4pg56rnLnigCgVTtvk+FIJtCyMY+7vfPhpueUvibS2 kiDyQfuVnT/UrFTm3kOhsBY5S4SzK10YJ7ZXpi/xc2mQ4HvzStyYw/O86ZB+twdj krOzrKASG6NTg8IENF6yXIct/pSN8kIwVfD2QHfqu0jOAKH0x5AhlMrohYvNpxen F1/K5rl6LI9VnmhWf+jKthPS778DfK5ZiZwq3B65hQ1cTXMHtqLMGQ+b//aKeXQv eRzCANsCFYjNL+ZwhiQIj5vE6AO8LxgQ6DLovTp70jEyhYpPej6WIsMUoZmlDaVz 9saWAhend+yNvd6sweSoQv7Ihr4EZJ80RlJduKyRY/YfJXGNKF6+yw76Bg4oI+ap lRPX7K8/Ii+N7fApP1BJPGFqnSykmtT2xbqmaQO4oh7nhA9l+VPgUZ0rvLtySnIZ DQ3JQnGJaifDYsln0AWArSgBzgoa3+hk25N28Xt4NNVZqFnv1Rs3t7HK+JvndEGw em2pzRCOOnyz45uV8rsIya8/kjO9VL4DCBSv+fchVM4l1E++Cw9BX6yUTzJI7mVu RD7JPy8D/iVrdjAfMvTBfuryQub782jzhMGbx3jS7pt0bJzi0vE= =BAqR -END PGP SIGNATURE- Changes since libreoffice-6-3-branch-point-928: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-6.3.4.1'
Tag 'libreoffice-6.3.4.1' created by Christian Lohmaier at 2019-11-21 21:23 + Tag libreoffice-6.3.4.1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAl3XAD0ACgkQ9DSh76/u rqPnyhAAxABL++VWQd0cHUBJkl6UuogZP3s9JoQAZzRnD1o1RdFLk3HAbX2p6LWB H0RoCMcSPguKpBJHf8BNxrkSkdep9IC0H98Z97/1ejg+GVIjY+NPrHW13E0yLCv3 xvd45W3942K1uzCfnsDkxs9Ak2vBrrfKKNHQBG0gTrC5ZrRh5cnGZvUywV0P0hQ4 eJm4JsoK+yM6DglkSHNPgUlqRXsZZ5FHTfp0loKjTzY8qpjtUfJ5Tq5dYN7gcC10 Ip3SxDeMoP0qCXvD2OnJCzH6Kd0SN+PZmZA/Y+rRsOD54Vf+7oGfJS0Dqszme2aC tG0TXi39UmrnjY5nyt0L7y2Fu0Tmn5GkaD8jjsx/6F/m3UZn7xHmenn9fQXZb8LV yOp/vjKmnR6+5/+QFR+mWwPGLckXcvaLe+8UNjkD31PTngDzUxxWfOXgk0kt6CAS E+rkKv3Kext+nw3yWGzfxx/ph1Vcr0rHORpwwj3YBP4F0Qd01v5pbJnHPmvKiazz sgLX7ikYIps7pzfQzEOwgXc6u1JhFWWOZwh/jyckoh9g68qrYnxT7IbZjBgI8s5/ N6MwNwk5vJr+gaMiCbe1NQcaAtUijA0xPYwuMKm7mc1fjxu4bjJss3USL73e8Jqw SiVnlyGKdvz9dRUaEIXDTr8VNrS/1QeaKTh41ksLxrBT43JfcYA= =yqE/ -END PGP SIGNATURE- Changes since libreoffice-6-3-branch-point-22: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-6.3.4.1'
Tag 'libreoffice-6.3.4.1' created by Christian Lohmaier at 2019-11-21 21:23 + Tag libreoffice-6.3.4.1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAl3XADkACgkQ9DSh76/u rqPAQw//bs9JxFQn64Qgrwk99SVtPqnou1X7F7KQxih7zIkIBpzu8uu+YPSrJg51 J1SYfVhaLiD03c9gw2ebBe9rSI4mMDtU9MUBYxJ9Jn00hOGc4ucXxqI4nwVXtyXN zETjz4eNa6apIarsWrKQrYxSmPvkJZloBNVRHubtzxmjRJ13cI+TExbUqqSbY1XO YtUOD4u0rwAq2OzIi8HPFtd/AMXYuvqCdeBKqXuIgAdK1+5FTC7do2gpw54PC9KO FOoxAmdW0Hr1Ntmu8VubHIridZvJsetcsASS9clM0KRpcm4GgOktbnL3koUEZlOR q5lxw3Gy5F2d31OluT1NPuCpYsyXFX/Rygyan2Yj/Nrt+w4YjxBwsIC8/f7E8PtS omS7bsiv46XKEtSz7/FHeYZsxrev0lh4+11M3rE7202pjoFd/Tmwp+Y9uu0K0DvR evQw3a78hQxFm1lDvdhsJqzFRM+Jssn3bpdTM7FcPocTPi63D3jRmtJwnrAElyHP ALpMWqFbhKFlWsVH7mQm1RkVHyNVzg+uM9bzhApwfjkl36mTbTfbH4TPGuUNhUKz UWdpIv0CKoZnFyc3pjzGf6ummYogDJjOWMWrVDZKfzoUmuiYDsZJbn/ltRtCXxW4 nzKhWB48sC8JGXroFV71X4s2JJojLR/9jbeRZI8PuHQ92CNgc7g= =cBLY -END PGP SIGNATURE- Changes since libreoffice-6-3-branch-point-6: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-6.3.4.1'
Tag 'libreoffice-6.3.4.1' created by Christian Lohmaier at 2019-11-21 21:23 + Tag libreoffice-6.3.4.1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAl3XAD0ACgkQ9DSh76/u rqPHcxAAg6kPx/p6g2iCmR6ULAWTf0U1yzhTvabxdqBwWWT4oP43fvKGh5f8r+ED gxPtL4o9EaZrxKx4L9pOkRabPHfmSUFD6BFVMBz/LQ6sjKeC1ChiMC70cLPdQIXN FwTaA68/8VyvK1rRKxUvHSR8Rnr/yyvbug/N0v++7bHsbKUktudXQ3loDZyh2G1d qMhLqXFXOQwoOCLL01v3ovgFiqq4K6+/VnQ7eNFrENFu2ON2XhGLiQCReN03PTAZ 0XrRowIlubbVRF7vPcysGldl+2nscSAoUkQx0VO876t5lxOsNajFUtfz4TlcDRV0 8sAFo4CnLe9dzjDW+VL+QwTPmCTElCpqc2MZiUBW996doFOmXzA0+izURaBz1Z/3 etcQ2VhDOTI63up1+gC9XKFVIxSsRd105zDbJfbIQk9t1K/e+lK01LyJZ1FofEeK RsUP7vJ2tmOuS5jBHOW1OYno0z2Bueg3hbqdJQk2fU2BVwcLOzjYHwssJbTXfZjl 3os1cAVLDA5QCIEx0dgqjUmAWBwX/P0mycF2g2TvXIjkOVegEM9rMKRBdCmtCg3U 0Vm/am7efsEG2fWFM+4MvgoVgnAwoIoosZc0YWh1d4zyBKAxxQgK/a/hPcsfTgQI f+XvygBxMhWR7MZtCspr9mzN+5dS/0F2FmdA0aRC97wKwPxpCGI= =ALIW -END PGP SIGNATURE- Changes since libreoffice-6-3-branch-point-11: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3-4' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c819120c44f0e35ba59fc6f2d474aeb944d18309 Author: Christian Lohmaier AuthorDate: Thu Nov 21 22:23:31 2019 +0100 Commit: Christian Lohmaier CommitDate: Thu Nov 21 22:23:31 2019 +0100 bump product version to 6.3.4.1.0+ Change-Id: Ic9c972191298a0c148701a87bada97d50f21779a diff --git a/configure.ac b/configure.ac index d6791c541d2a..cf192e7e2556 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[6.3.4.0.0+],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[6.3.4.1.0+],[],[],[http://documentfoundation.org/]) dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just fine if it is installed dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails hard ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: fpicker/Library_fps.mk fpicker/Module_fpicker.mk fpicker/source fpicker/WinResTarget_fps.mk
fpicker/Library_fps.mk |2 fpicker/Module_fpicker.mk |1 fpicker/WinResTarget_fps.mk | 14 -- fpicker/source/win32/Fps.rc | 275 fpicker/source/win32/afxres.h |8 - fpicker/source/win32/resource.h | 38 - 6 files changed, 338 deletions(-) New commits: commit d312d02cf43928361be34207a0cdd2d95b3ec5fd Author: Julien Nabet AuthorDate: Wed Nov 20 20:37:43 2019 +0100 Commit: Julien Nabet CommitDate: Thu Nov 21 22:21:30 2019 +0100 Remove some obsolete fpicker/win part Change-Id: I7c602068e34b904559c0cbe3f869618c9149705a Reviewed-on: https://gerrit.libreoffice.org/83352 Tested-by: Jenkins Reviewed-by: Mike Kaganski Reviewed-by: Julien Nabet diff --git a/fpicker/Library_fps.mk b/fpicker/Library_fps.mk index 208540db17a3..31dd47e88b30 100644 --- a/fpicker/Library_fps.mk +++ b/fpicker/Library_fps.mk @@ -14,8 +14,6 @@ $(eval $(call gb_Library_use_custom_headers,fps,\ officecfg/registry \ )) -$(eval $(call gb_Library_add_nativeres,fps,fps/Fps)) - $(eval $(call gb_Library_set_componentfile,fps,fpicker/source/win32/fps)) $(eval $(call gb_Library_set_include,fps,\ diff --git a/fpicker/Module_fpicker.mk b/fpicker/Module_fpicker.mk index 5f4ee86c9c6c..d05b4b20da10 100644 --- a/fpicker/Module_fpicker.mk +++ b/fpicker/Module_fpicker.mk @@ -28,7 +28,6 @@ endif ifeq ($(OS),WNT) $(eval $(call gb_Module_add_targets,fpicker,\ Library_fps \ - WinResTarget_fps \ )) endif diff --git a/fpicker/WinResTarget_fps.mk b/fpicker/WinResTarget_fps.mk deleted file mode 100644 index 07fe66bcca35.. --- a/fpicker/WinResTarget_fps.mk +++ /dev/null @@ -1,14 +0,0 @@ -# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- -# -# This file is part of the LibreOffice project. -# -# This Source Code Form is subject to the terms of the Mozilla Public -# License, v. 2.0. If a copy of the MPL was not distributed with this -# file, You can obtain one at http://mozilla.org/MPL/2.0/. -# - -$(eval $(call gb_WinResTarget_WinResTarget,fps/Fps)) - -$(eval $(call gb_WinResTarget_set_rcfile,fps/Fps,fpicker/source/win32/Fps)) - -# vim: set ts=4 sw=4 et: diff --git a/fpicker/source/win32/Fps.rc b/fpicker/source/win32/Fps.rc deleted file mode 100644 index 6cab1a5f426c.. --- a/fpicker/source/win32/Fps.rc +++ /dev/null @@ -1,275 +0,0 @@ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the "License"); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ - -//Microsoft Developer Studio generated resource script. - -#include "resource.h" - -#define APSTUDIO_READONLY_SYMBOLS - - -// Generated from the TEXTINCLUDE 2 resource. - -#include "afxres.h" - - -#undef APSTUDIO_READONLY_SYMBOLS - - -// German (Germany) resources - -#if !defined(AFX_RESOURCE_DLL) || defined(AFX_TARG_DEU) -#ifdef _WIN32 -LANGUAGE LANG_GERMAN, SUBLANG_GERMAN -#pragma code_page(1252) -#endif //_WIN32 - -#ifdef APSTUDIO_INVOKED - - -// TEXTINCLUDE - - -1 TEXTINCLUDE DISCARDABLE -BEGIN -"resource.h\0" -END - -2 TEXTINCLUDE DISCARDABLE -BEGIN -"#include ""afxres.h""\r\n" -"\0" -END - -3 TEXTINCLUDE DISCARDABLE -BEGIN -"\r\n" -"\0" -END - -#endif// APSTUDIO_INVOKED - - - - -// Dialog - - -1001 DIALOG DISCARDABLE 0, 0, 338, 67 -STYLE DS_3DLOOK | DS_CONTROL | WS_CHILD | WS_CLIPSIBLINGS -FONT 8, "MS Shell Dlg" -BEGIN -CONTROL "Mit Schreibschutz \366ffnen",103,"Button",BS_AUTOCHECKBOX | WS_TABSTOP, -130,51,161,14 -COMBOBOX107,130,35,164,52,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP -LTEXT "Version:",207,68,37,56,11 -LTEXT "",1119,0,0,336,35 -END - -2001 DIALOG DISCARDABLE 0, 0, 280, 72 -STYLE DS_CONTROL | WS_CHILD | WS_CLIPSIBLINGS -FONT 8, "MS Shell Dlg" -BEGIN -CONTROL "Vorschau",105,"Button",BS_AUTOCHECKBOX | WS_TABSTOP, -130,58,144,16 -CONTROL "Als Link einf\374gen",104,"Button",BS_AUTOCHECKBOX | WS_TABSTOP, -130,45,144,14 -COMBOBOX109,130,28,164,62,CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP -LTEXT "Bildvorlage:",209,67,30,47,11 -LTEXT "",1119,0,0,281,28 -END - -3001 DIALOG DISCARDABLE 0, 0, 296, 72 -STYLE DS_3DLOOK | DS_CONTROL | WS_CHILD
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b659939fc3badd44e234c6bd5e12873619fd403a Author: Christian Lohmaier AuthorDate: Thu Nov 21 22:20:50 2019 +0100 Commit: Christian Lohmaier CommitDate: Thu Nov 21 22:20:50 2019 +0100 bump product version to 6.3.5.0.0+ Change-Id: I774d87ec633c0e2fee4ae0e0ceafca1b3dc0bf8a diff --git a/configure.ac b/configure.ac index d6791c541d2a..ed0aa7df8cd5 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[6.3.4.0.0+],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[6.3.5.0.0+],[],[],[http://documentfoundation.org/]) dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just fine if it is installed dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails hard ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'libreoffice-6-3-4'
New branch 'libreoffice-6-3-4' available with the following commits: commit 4cd84eb4e3138cbb1685d19927f84d09c249e3cd Author: Christian Lohmaier Date: Thu Nov 21 22:18:19 2019 +0100 Branch libreoffice-6-3-4 This is 'libreoffice-6-3-4' - the stable branch for the 6.3.4 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 6.3.x release, please use the 'libreoffice-6-3' branch. If you want to build something cool, unstable, and risky, use master. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128698] MySQL/MariaDB direct Connection: time-values not written to table
https://bugs.documentfoundation.org/show_bug.cgi?id=128698 --- Comment #15 from Julien Nabet --- I don't even know where I can see the request which will be executed: 161 int nFail = mysql_stmt_execute(m_pStmt); (gdb) p m_pStmt $27 = (MYSQL_STMT *) 0x58d06190 (gdb) p *m_pStmt $28 = {mem_root = {free = 0x58d01c90, used = 0x0, pre_alloc = 0x0, min_malloc = 32, block_size = 2008, block_num = 0, first_block_usage = 0, error_handler = 0x0}, mysql = 0x57ac7100, stmt_id = 34, flags = 0, state = MYSQL_STMT_PREPARED, fields = 0x0, field_count = 0, param_count = 2, send_types_to_server = 1 '\001', params = 0x58d01ca8, bind = 0x0, result = {rows = 0, fields = 0, data = 0x0, alloc = {free = 0x0, used = 0x0, pre_alloc = 0x0, min_malloc = 32, block_size = 4056, block_num = 0, first_block_usage = 0, error_handler = 0x0}}, result_cursor = 0x0, bind_result_done = 0 '\000', bind_param_done = 1 '\001', upsert_status = {warning_count = 0, server_status = 0, affected_rows = 18446744073709551615, last_insert_id = 0}, last_errno = 0, last_error = '\000' , sqlstate = "0", update_max_length = 0 '\000', prefetch_rows = 1, list = {prev = 0x0, next = 0x58a63920, data = 0x58d06190}, cursor_exists = 0 '\000', extension = 0x586f2410, fetch_row_func = 0x0, execute_count = 0, default_rset_handler = 0x0, m = 0x0} I'm stuck. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] translations.git: Changes to 'libreoffice-6-3-4'
New branch 'libreoffice-6-3-4' available with the following commits: commit e77238c10958f480a8a4e7379b321ffc4e4df808 Author: Christian Lohmaier Date: Thu Nov 21 22:17:47 2019 +0100 Branch libreoffice-6-3-4 This is 'libreoffice-6-3-4' - the stable branch for the 6.3.4 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 6.3.x release, please use the 'libreoffice-6-3' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: Id058bb7c2ca4b02c4d40030bb148e2041024c8aa ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Changes to 'libreoffice-6-3-4'
New branch 'libreoffice-6-3-4' available with the following commits: commit ce5e6e8a97d4fac18ae553f2357112ed9653b458 Author: Christian Lohmaier Date: Thu Nov 21 22:17:46 2019 +0100 Branch libreoffice-6-3-4 This is 'libreoffice-6-3-4' - the stable branch for the 6.3.4 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 6.3.x release, please use the 'libreoffice-6-3' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: Ibf24a14546457fb0cb559226d9dd4bbb309ca89b ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Changes to 'libreoffice-6-3-4'
New branch 'libreoffice-6-3-4' available with the following commits: commit 61d9a52f2940f0cd73a005685aa6a47fea3ed861 Author: Christian Lohmaier Date: Thu Nov 21 22:17:46 2019 +0100 Branch libreoffice-6-3-4 This is 'libreoffice-6-3-4' - the stable branch for the 6.3.4 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 6.3.x release, please use the 'libreoffice-6-3' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: I4fc021b615a3dc1dd0d04b83936b91951d9aa792 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128862] CRASH: Unable to open tables in HSQLDB odb-files with apostrophe " ' " character in table name
https://bugs.documentfoundation.org/show_bug.cgi?id=128862 --- Comment #21 from Commit Notification --- Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c5f0e89ee5b1d13416987ddceaccc4d8a0816986 tdf#128862: fix HSQLDB odb-files with apostrophe crash It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128862] CRASH: Unable to open tables in HSQLDB odb-files with apostrophe " ' " character in table name
https://bugs.documentfoundation.org/show_bug.cgi?id=128862 Commit Notification changed: What|Removed |Added Whiteboard||target:6.5.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: tools/source
tools/source/debug/debug.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit c5f0e89ee5b1d13416987ddceaccc4d8a0816986 Author: Julien Nabet AuthorDate: Tue Nov 19 23:02:20 2019 +0100 Commit: Julien Nabet CommitDate: Thu Nov 21 22:16:21 2019 +0100 tdf#128862: fix HSQLDB odb-files with apostrophe crash see bt: 0 0x7209866a in std::type_info::name() const (this=0x0) at /usr/include/c++/9/typeinfo:100 1 0x720966e1 in exceptionToStringImpl(rtl::OStringBuffer&, com::sun::star::uno::Any const&) (sMessage="DBG_UNHANDLED_EXCEPTION in bool connectivity::hsqldb::OHsqlConnection::impl_isTextTable_nothrow(const rtl::OUString&) exception: com.sun.star.sdbc.SQLException message: Unexpected token: S in statemen"..., caught= uno::Any("com.sun.star.sdbc.SQLException": { = {Message = "Unexpected token: S in statement [s]", Context = uno::Reference to (com::sun::star::uno::XInterface *) 0x59269238}, SQLState = "37000", ErrorCode = -11, NextException = uno::Any(void)})) at /home/julien/lo/libreoffice/tools/source/debug/debug.cxx:113 2 0x7209855d in DbgUnhandledException(com::sun::star::uno::Any const&, char const*, char const*, char const*, char const*) (caught= uno::Any("com.sun.star.sdbc.SQLException": { = {Message = "Unexpected token: S in statement [s]", Context = uno::Reference to (com::sun::star::uno::XInterface *) 0x59269238}, SQLState = "37000", ErrorCode = -11, NextException = uno::Any(void)}), currentFunction=0x7fffdb5ca340 "bool connectivity::hsqldb::OHsqlConnection::impl_isTextTable_nothrow(const rtl::OUString&)", fileAndLineNo=0x7fffdb5ca2e8 "/home/julien/lo/libreoffice/connectivity/source/drivers/hsqldb/HConnection.cxx:301: ", area=0x7fffdb5c9f49 "connectivity.hsqldb", explanatory=0x0) at /home/julien/lo/libreoffice/tools/source/debug/debug.cxx:418 3 0x7fffdb58a16a in connectivity::hsqldb::OHsqlConnection::impl_isTextTable_nothrow(rtl::OUString const&) (this=0x58a43de0, _rTableName="William Kidwell's Address Book") at /home/julien/lo/libreoffice/connectivity/source/drivers/hsqldb/HConnection.cxx:301 https://bugs.documentfoundation.org/attachment.cgi?id=155952 Change-Id: I2bc744164b1470d8f09bcb126b02e48af180e886 Reviewed-on: https://gerrit.libreoffice.org/83245 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/tools/source/debug/debug.cxx b/tools/source/debug/debug.cxx index 6bfb9a42612f..de4a14015044 100644 --- a/tools/source/debug/debug.cxx +++ b/tools/source/debug/debug.cxx @@ -108,6 +108,7 @@ static void exceptionToStringImpl(OStringBuffer& sMessage, const css::uno::Any & sMessage.append(" message: "); sMessage.append(toOString(exception.Message)); } +/* TODO FIXME (see https://gerrit.libreoffice.org/#/c/83245/) if ( exception.Context.is() ) { const char* pContext = typeid( *exception.Context ).name(); @@ -122,6 +123,7 @@ static void exceptionToStringImpl(OStringBuffer& sMessage, const css::uno::Any & std::free(const_cast(pContext)); #endif } +*/ { css::configuration::CorruptedConfigurationException specialized; if ( caught >>= specialized ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128698] MySQL/MariaDB direct Connection: time-values not written to table
https://bugs.documentfoundation.org/show_bug.cgi?id=128698 --- Comment #14 from Julien Nabet --- I gave a new try and this time have 00:00:00 each time. Trying to debug this, I only can tell that everything seems ok in "OPreparedStatement::setTime" (see https://opengrok.libreoffice.org/xref/core/connectivity/source/drivers/mysqlc/mysqlc_preparedstatement.cxx?r=913d34ec#264) I tried to compare the mechanism with setDate which works, I don't find the root cause. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: oox/CppunitTest_oox_drawingml.mk oox/Module_oox.mk oox/qa oox/source
oox/CppunitTest_oox_drawingml.mk | 45 ++ oox/Module_oox.mk|1 oox/qa/unit/data/transparent-text.pptx |binary oox/qa/unit/drawingml.cxx| 100 +++ oox/source/drawingml/textcharacterproperties.cxx | 10 ++ oox/source/export/drawingml.cxx | 12 ++ oox/source/token/properties.txt |1 7 files changed, 167 insertions(+), 2 deletions(-) New commits: commit 1e64d9ebaa231caef5fb062009b8f76465e415f4 Author: Miklos Vajna AuthorDate: Thu Nov 21 17:53:35 2019 +0100 Commit: Miklos Vajna CommitDate: Thu Nov 21 22:03:04 2019 +0100 oox: add PPTX import/export for semi-transparent shape text And start a drawingml test suite in oox, so the test and the tested code is close to each other (just like how it's done in chart2/ already). Change-Id: I9a2810691f12604d240e4394e6a5ff4e7f52f1c1 Reviewed-on: https://gerrit.libreoffice.org/83412 Reviewed-by: Miklos Vajna Tested-by: Jenkins diff --git a/oox/CppunitTest_oox_drawingml.mk b/oox/CppunitTest_oox_drawingml.mk new file mode 100644 index ..dd0288074e32 --- /dev/null +++ b/oox/CppunitTest_oox_drawingml.mk @@ -0,0 +1,45 @@ +# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- +#* +# +# This file is part of the LibreOffice project. +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# +#* + +$(eval $(call gb_CppunitTest_CppunitTest,oox_drawingml)) + +$(eval $(call gb_CppunitTest_use_externals,oox_drawingml,\ + boost_headers \ +)) + +$(eval $(call gb_CppunitTest_add_exception_objects,oox_drawingml, \ +oox/qa/unit/drawingml \ +)) + +$(eval $(call gb_CppunitTest_use_libraries,oox_drawingml, \ +comphelper \ +cppu \ +oox \ +sal \ +test \ +unotest \ +utl \ +)) + +$(eval $(call gb_CppunitTest_use_sdk_api,oox_drawingml)) + +$(eval $(call gb_CppunitTest_use_ure,oox_drawingml)) +$(eval $(call gb_CppunitTest_use_vcl,oox_drawingml)) + +$(eval $(call gb_CppunitTest_use_rdb,oox_drawingml,services)) + +$(eval $(call gb_CppunitTest_use_custom_headers,oox_drawingml,\ + officecfg/registry \ +)) + +$(eval $(call gb_CppunitTest_use_configuration,oox_drawingml)) + +# vim: set noet sw=4 ts=4: diff --git a/oox/Module_oox.mk b/oox/Module_oox.mk index 636f9f6ece99..6078a7e24c0c 100644 --- a/oox/Module_oox.mk +++ b/oox/Module_oox.mk @@ -26,6 +26,7 @@ $(eval $(call gb_Module_add_check_targets,oox,\ CppunitTest_oox_vba_encryption \ CppunitTest_oox_crypto \ CppunitTest_oox_mathml \ + CppunitTest_oox_drawingml \ )) # vim: set noet sw=4 ts=4: diff --git a/oox/qa/unit/data/transparent-text.pptx b/oox/qa/unit/data/transparent-text.pptx new file mode 100644 index ..b7b3ede4dc3d Binary files /dev/null and b/oox/qa/unit/data/transparent-text.pptx differ diff --git a/oox/qa/unit/drawingml.cxx b/oox/qa/unit/drawingml.cxx new file mode 100644 index ..e3c455c04867 --- /dev/null +++ b/oox/qa/unit/drawingml.cxx @@ -0,0 +1,100 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include +#include + +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include + +using namespace ::com::sun::star; + +/// oox drawingml tests. +class OoxDrawingmlTest : public test::BootstrapFixture, public unotest::MacrosTest +{ +private: +uno::Reference mxComponentContext; +uno::Reference mxComponent; + +public: +void setUp() override; +void tearDown() override; +uno::Reference& getComponent() { return mxComponent; } +void loadAndReload(const OUString& rURL, const OUString& rFilterName); +}; + +void OoxDrawingmlTest::setUp() +{ +test::BootstrapFixture::setUp(); + + mxComponentContext.set(comphelper::getComponentContext(getMultiServiceFactory())); +mxDesktop.set(frame::Desktop::create(mxComponentContext)); +} + +void OoxDrawingmlTest::tearDown() +{ +if (mxComponent.is()) +mxComponent->dispose(); + +test::BootstrapFixture::tearDown(); +} + +void OoxDrawingmlTest::loadAndReload(const OUString& rURL, const OUString& rFilterName) +{ +mxComponent = loadFromDesktop(rURL); +uno::Reference xStorable(mxComponent, uno::UNO_QUERY); +utl::MediaDescriptor aMediaDescriptor; +
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sw/source
sw/source/core/doc/DocumentDeviceManager.cxx |9 + 1 file changed, 9 insertions(+) New commits: commit 5042375a67a7c7171529abd9724576a269a0c32e Author: Michael Weghorn AuthorDate: Thu Nov 21 14:03:05 2019 +0100 Commit: Michael Weghorn CommitDate: Thu Nov 21 22:01:16 2019 +0100 tdf#118263 Take over doc print options for new printer Take over the current document-specific print settings for a newly created printer in 'sw::DocumentDeviceManager::Create_Printer_'. This makes sure that the options of an 'SfxPrinter*' retrieved by calling 'DocumentDeviceManager::getPrinter(true)' are in line with the 'SwPrintData' currently set. This among other fixes the issue described in tdf#118263, comment 7, i.e. the options shown in "File" -> "Printer Settings" -> "Options" were not properly initialized when the config option for loading user-specific settings with the document was disabled. (All checkboxes were unchecked in the UI in this case instead of showing the default values.) What happens is that when importing the document, 'bPrinterIndependentLayout' in 'SwXMLImport::SetConfigurationSettings' is 'false', so that this block is entered there: if( ! bPrinterIndependentLayout ) { xProps->setPropertyValue( "PrinterIndependentLayout", Any(sal_Int16(document::PrinterIndependentLayout::DISABLED)) ); } resulting in the following call stack where the printer is created and set: #0 sw::DocumentDeviceManager::setPrinter(SfxPrinter*, bool, bool) #1 sw::DocumentDeviceManager::CreatePrinter_() const #2 sw::DocumentDeviceManager::getPrinter(bool) const #3 sw::DocumentDeviceManager::setReferenceDeviceType(bool, bool) #4 SwXDocumentSettings::_setSingleValue(comphelper::PropertyInfo const&, com::sun::star::uno::Any const&) #5 comphelper::MasterPropertySet::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&) #6 SwXMLImport::SetConfigurationSettings(com::sun::star::uno::Sequence const&) [...] Writer's default settings were not applied in this case. For the case where loading user-specific settings is enabled, no printer is set at this stage, but it's later set in the call to 'SwView::GetPrinter', in which case there is already an explicit call to 'SetAppPrintOptions' after the printer is created via 'DocumentDeviceManager::getPrinter(true)', so all was fine there earlier as well. (Apparently, the same issue could be reproduced with the config option for loading user-specific options enabled, but an ODT document that has "PrinterIndependentLayout" set to "disabled" in it's settings.xml.) Change-Id: I39fd300fb56b767e7103b65537b0eac1365e5fd7 Reviewed-on: https://gerrit.libreoffice.org/83394 Tested-by: Jenkins Reviewed-by: Michael Weghorn (cherry picked from commit 46f8f48ebfe25e26b4d1c0718c772abbee70b889) Reviewed-on: https://gerrit.libreoffice.org/83428 diff --git a/sw/source/core/doc/DocumentDeviceManager.cxx b/sw/source/core/doc/DocumentDeviceManager.cxx index e0c0b7d09be8..18da1249341c 100644 --- a/sw/source/core/doc/DocumentDeviceManager.cxx +++ b/sw/source/core/doc/DocumentDeviceManager.cxx @@ -34,6 +34,7 @@ #include #include #include +#include #include #include #include @@ -297,6 +298,14 @@ SfxPrinter& DocumentDeviceManager::CreatePrinter_() const FN_PARAM_ADDPRINTER, FN_PARAM_ADDPRINTER>{}); VclPtr pNewPrt = VclPtr::Create( std::move(pSet) ); + +// assign PrintData to newly created printer +const SwPrintData& rPrtData = getPrintData(); +SwAddPrinterItem aAddPrinterItem(rPrtData); +SfxItemSet aOptions(pNewPrt->GetOptions()); +aOptions.Put(aAddPrinterItem); +pNewPrt->SetOptions(aOptions); + const_cast(this)->setPrinter( pNewPrt, true, true ); return *mpPrt; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 103216] Navigator: Missing context menu entry to rename Drawing Objects
https://bugs.documentfoundation.org/show_bug.cgi?id=103216 --- Comment #8 from Olivier Hallot --- (In reply to Alex Thurgood from comment #6) > I have just come across this bug when experimenting with the Navigator as a > means of identifying my shapes. > > What is the point of having an object navigator in which only some of the > objects allow their name to edited, either directly by double-click, or via > a context menu ? > > Surely, not having such a systematic feature defeats the purpose of the > object navigator ? > > Confirmed that bug is still present in > > Version: 6.3.0.0.alpha0+ > Build ID: 94de7c0be2739de7fdaf11e9e55a1cc7083992f0 > CPU threads: 4; OS: Mac OS X 10.14.2; UI render: default; VCL: osx; > Locale: fr-FR (fr_FR.UTF-8); UI-Language: en-US > Calc: threaded Actually QRCodes and Signature Lines are drawing objects that don't show in Navigator (bug#128938). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128938] New: [NAVIGATOR] Some drawing objects don't show in Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=128938 Bug ID: 128938 Summary: [NAVIGATOR] Some drawing objects don't show in Navigator Product: LibreOffice Version: 6.5.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: olivier.hal...@libreoffice.org Some objects don't show in the Navigator list of objects. For example: QR Code Signature line They are actually drawing objects Perhaps related to comment#6 of https://bugs.documentfoundation.org/show_bug.cgi?id=103216#c6 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128937] New: LibreOffice does not work in Mac OS version 10.15.1
https://bugs.documentfoundation.org/show_bug.cgi?id=128937 Bug ID: 128937 Summary: LibreOffice does not work in Mac OS version 10.15.1 Product: LibreOffice Version: 6.2.8.1 rc Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: b...@weldingengineer.com Description: “LibreOffice” can’t be opened because Apple cannot check it for malicious software. "This software needs to be updated. Contact the developer for more information. Opera downloaded this file today at 11:54 AM from www.libreoffice.org. I down loaded "LibreOffice_6.2.8_MacOS_x86-64" Actual Results: down load libreoffice open the LibreOffice_6.2.8_MacOS_x86-64.dmg file, drag to applications as shown in pop up window. double click on app and get error “LibreOffice” can’t be opened because Apple cannot check it for malicious software. This software needs to be updated. Contact the developer for more information. Opera downloaded this file today at 11:54 AM from www.libreoffice.org. Expected Results: app should open Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Makefile.am
Makefile.am |1 + 1 file changed, 1 insertion(+) New commits: commit bbaf010f4f26e1505e3d133128480d590b57af6a Author: Andras Timar AuthorDate: Thu Nov 21 21:39:01 2019 +0100 Commit: Andras Timar CommitDate: Thu Nov 21 21:39:01 2019 +0100 add wsd/ProofKey.hpp to dist tarball Change-Id: I99a018ad2194f124df9e7a373f9268ba33b0a5e1 diff --git a/Makefile.am b/Makefile.am index 1035a22e2..c2912f279 100644 --- a/Makefile.am +++ b/Makefile.am @@ -179,6 +179,7 @@ wsd_headers = wsd/Admin.hpp \ wsd/Exceptions.hpp \ wsd/FileServer.hpp \ wsd/LOOLWSD.hpp \ + wsd/ProofKey.hpp \ wsd/QueueHandler.hpp \ wsd/SenderQueue.hpp \ wsd/Storage.hpp \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits