[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/markdata.hxx | 18 +-
sc/source/core/data/markdata.cxx | 10 +-
2 files changed, 14 insertions(+), 14 deletions(-)
New commits:
commit ae63347262401cbb7010fd2939afdae90ee7b102
Author: Caolán McNamara
AuthorDate: Mon Dec 2 09:01:04 2019 +
Commit: Caolán McNamara
CommitDate: Mon Dec 2 11:31:27 2019 +0100
use initializer list
Change-Id: Ida6d710ceb4722029c9d0e07df47e621dd4a4053
Reviewed-on: https://gerrit.libreoffice.org/84192
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/inc/markdata.hxx b/sc/inc/markdata.hxx
index 5929586036d4..52fed46bb07a 100644
--- a/sc/inc/markdata.hxx
+++ b/sc/inc/markdata.hxx
@@ -50,17 +50,17 @@ private:
ScRange aMarkRange; // area
ScRange aMultiRange;// maximum area altogether
ScMultiSel aMultiSel; // multi selection
-boolbMarked:1;// rectangle marked
-boolbMultiMarked:1;
-
-boolbMarking:1; // area is being marked -> no
MarkToMulti
-boolbMarkIsNeg:1; // cancel if multi selection
-ScRangeList aTopEnvelope; // list of ranges in the top
envelope of the multi selection
-ScRangeList aBottomEnvelope; // list of ranges in the bottom
envelope of the multi selection
-ScRangeList aLeftEnvelope;// list of ranges in the left
envelope of the multi selection
-ScRangeList aRightEnvelope; // list of ranges in the right
envelope of the multi selection
+ScRangeList aTopEnvelope; // list of ranges in the top
envelope of the multi selection
+ScRangeList aBottomEnvelope;// list of ranges in the bottom
envelope of the multi selection
+ScRangeList aLeftEnvelope; // list of ranges in the left
envelope of the multi selection
+ScRangeList aRightEnvelope; // list of ranges in the right
envelope of the multi selection
SCROW mnMaxRow;
SCCOL mnMaxCol;
+boolbMarked:1; // rectangle marked
+boolbMultiMarked:1;
+
+boolbMarking:1; // area is being marked -> no
MarkToMulti
+boolbMarkIsNeg:1; // cancel if multi selection
public:
ScMarkData(SCROW nMaxRow, SCCOL nMaxCol);
diff --git a/sc/source/core/data/markdata.cxx b/sc/source/core/data/markdata.cxx
index 469e169a9c03..047fe7002ff2 100644
--- a/sc/source/core/data/markdata.cxx
+++ b/sc/source/core/data/markdata.cxx
@@ -51,12 +51,12 @@ ScMarkData::ScMarkData(const ScMarkData& rData) :
aLeftEnvelope( rData.aLeftEnvelope ),
aRightEnvelope( rData.aRightEnvelope ),
mnMaxRow( rData.mnMaxRow ),
-mnMaxCol( rData.mnMaxCol )
+mnMaxCol( rData.mnMaxCol ),
+bMarked( rData.bMarked ),
+bMultiMarked( rData.bMultiMarked ),
+bMarking( rData.bMarking ),
+bMarkIsNeg( rData.bMarkIsNeg )
{
-bMarked = rData.bMarked;
-bMultiMarked = rData.bMultiMarked;
-bMarking = rData.bMarking;
-bMarkIsNeg = rData.bMarkIsNeg;
}
ScMarkData& ScMarkData::operator=(const ScMarkData& rData)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129127] Crash when sort by column of Excel 97-2003 file with specific data
https://bugs.documentfoundation.org/show_bug.cgi?id=129127 Xisco Faulí changed: What|Removed |Added CC||dennisfrancis...@gmail.com --- Comment #8 from Xisco Faulí --- @Dennis, I thought you might be interested in this issue -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68752] Error while "Save as"/Export as XML using "LibreOffice Calc" if there are 3 empty rows
https://bugs.documentfoundation.org/show_bug.cgi?id=68752 --- Comment #14 from Timur --- Repro 6.5+. It's not Save anymore, now it's Export, but error remains. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129127] Crash when sort by column of Excel 97-2003 file with specific data
https://bugs.documentfoundation.org/show_bug.cgi?id=129127 Xisco Faulí changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected CC||ko...@libreoffice.org See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=81 ||309 --- Comment #7 from Xisco Faulí --- Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=5c6ee09126631342939ae8766fe36083d8c011e3 author Kohei Yoshida 2014-06-02 18:29:27 -0400 committer Kohei Yoshida 2014-07-13 18:07:14 -0400 commit 5c6ee09126631342939ae8766fe36083d8c011e3 (patch) tree48081d36ae5000542adb49cc037267992f59ec66 parent b5bb15013617c6b9f1cdd089acae0bfb7104fa3a (diff) fdo#81309: Adjust references during sort. Bisected with: bibisect-44max Adding Cc: to Kohei Yoshida -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128818] white boxes appear after saving an xlsx file with special comments
https://bugs.documentfoundation.org/show_bug.cgi?id=128818 Timur changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED --- Comment #8 from Timur --- I don't see mail going to reported, maybe he turned it off. I'll close as Insufficient Data. But s/he us welcome to set New again if tested as required. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Cannot start LO with --disable-gui build
On 29.11.19 17:35, Alex Kom wrote: then |make| it, but when I'm trying to run |./soffice.bin --convert-to pdf test.doc| or use |lok::lok_cpp_init| from LibreOfficeKit, an error occures: /LibreOffice - dialog 'LibreOfficeDev 6.1 - Fatal Error': 'The application cannot be started./ Little debugging through code gave me a clue, that it's might be unability to initialize UNO or just setting wrong PATH\LD_LIBRARY_PATH\etc. So, what am I doing wrong? (except using --disable-gui, I've seen, it's experimental) "soffice.bin" is not a supported way to start LO; you have to run "soffice" instead (or soffice.exe on windows). ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 128818] white boxes appear after saving an xlsx file with special comments
https://bugs.documentfoundation.org/show_bug.cgi?id=128818 --- Comment #7 from Timur --- @gtb11...@eveav.com : please do as required, to test Excel-only modified file and attach original here. I see that attachment 155840 was last saved in MSO, and it still shows problem, but you didn't say if it was previously saved also in LO. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123412] Base: Unwanted disonnection from Firebird data source error message "connection shutdown caused by isc_service_attach"
https://bugs.documentfoundation.org/show_bug.cgi?id=123412 --- Comment #21 from Tim --- Yes, I have my files synchronized on a NAS -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119111] Shapes losing position and z-index
https://bugs.documentfoundation.org/show_bug.cgi?id=119111 --- Comment #18 from DM --- Example added 'Move-Undo example of unrelated item jumping' -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - desktop/source sal/android
desktop/source/lib/init.cxx | 21 ++---
sal/android/libreofficekit-jni.c |8 +++-
2 files changed, 9 insertions(+), 20 deletions(-)
New commits:
commit 668b03284c4b0df56d5a000cc38dd1144ec33bbe
Author: Jan Holesovsky
AuthorDate: Wed Nov 20 17:55:43 2019 +0100
Commit: Jan Holesovsky
CommitDate: Mon Dec 2 11:13:54 2019 +0100
android: Get rid of the 'old' vs. Online-based runtime distinction.
No need for this when we have a compile-time distinction now anyway.
Change-Id: Ic86c8cce38a86635ea3efb4229c08f63059c9ee6
Reviewed-on: https://gerrit.libreoffice.org/83719
Reviewed-by: Jan Holesovsky
Tested-by: Jenkins
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 8f05cc487672..7fb08f0bec15 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -7,6 +7,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
+#include
#include
#include
@@ -2712,13 +2713,6 @@ static void doc_setPartMode(LibreOfficeKitDocument*
pThis,
}
}
-#if defined(ANDROID)
-/// For the distinction if the LOK is used for the 'old' (JNI-based) or the
-/// 'new' (loolwsd-based) app. Default to the 'new', ie. not used from JNI as
-/// implemented in sal/android/libreofficekit-jni.c.
-bool android_lok_from_jni = false;
-#endif
-
static void doc_paintTile(LibreOfficeKitDocument* pThis,
unsigned char* pBuffer,
const int nCanvasWidth, const int nCanvasHeight,
@@ -2756,15 +2750,12 @@ static void doc_paintTile(LibreOfficeKitDocument* pThis,
#else
ScopedVclPtrInstance< VirtualDevice > pDevice(DeviceFormat::DEFAULT);
-#if defined(ANDROID)
-if (!android_lok_from_jni)
+#if HAVE_FEATURE_ANDROID_LOK
+// Set background to transparent by default.
+// [Unless it is the 'old' (JNI-based) Android app - no idea why it
+// needs avoiding this.]
+pDevice->SetBackground(Wallpaper(COL_TRANSPARENT));
#endif
-{
-// Set background to transparent by default.
-// [Unless it is the 'old' (JNI-based) Android app - no idea why it
-// needs avoiding this.]
-pDevice->SetBackground(Wallpaper(COL_TRANSPARENT));
-}
pDevice->SetOutputSizePixelScaleOffsetAndBuffer(
Size(nCanvasWidth, nCanvasHeight), Fraction(1.0), Point(),
diff --git a/sal/android/libreofficekit-jni.c b/sal/android/libreofficekit-jni.c
index e4d7f4828a54..08827df54f07 100644
--- a/sal/android/libreofficekit-jni.c
+++ b/sal/android/libreofficekit-jni.c
@@ -37,7 +37,6 @@ extern const char* data_dir;
extern const char* cache_dir;
extern void* apk_file;
extern int apk_file_size;
-extern bool android_lok_from_jni; ///< for the distinction if the LOK is used
for the 'old' (JNI-based) or the 'new' (loolwsd-based) app
AAssetManager* native_asset_manager;
extern void Java_org_libreoffice_android_Bootstrap_putenv(JNIEnv* env, jobject
clazz, jstring string);
@@ -164,10 +163,6 @@ jboolean
Java_org_libreoffice_kit_LibreOfficeKit_initializeNative
(void) clazz;
-// the 'old' app needs to avoid setting the virtual device to transparent
-// in paintTile(), so indicate we are using the 'old' app
-android_lok_from_jni = true;
-
libreofficekit_initialize(env, dataDir, cacheDir, apkFile, assetManager);
// LibreOfficeKit expects a path to the program/ directory
commit b648e36c775e8707e7f6a49b264951916cf4092d
Author: Jan Holesovsky
AuthorDate: Wed Nov 27 15:28:59 2019 +0100
Commit: Jan Holesovsky
CommitDate: Mon Dec 2 11:13:38 2019 +0100
android: Hint how to enable fontconfig logging.
Change-Id: I8901780fa29c6d27bb53e44b07d95259b5bd02df
Reviewed-on: https://gerrit.libreoffice.org/83920
Reviewed-by: Jan Holesovsky
Tested-by: Jan Holesovsky
(cherry picked from commit f3af7708e3535d3171832aa2308d1e7f6193def4)
Reviewed-on: https://gerrit.libreoffice.org/84189
Tested-by: Jenkins
diff --git a/sal/android/libreofficekit-jni.c b/sal/android/libreofficekit-jni.c
index 1307ab6a5fbb..e4d7f4828a54 100644
--- a/sal/android/libreofficekit-jni.c
+++ b/sal/android/libreofficekit-jni.c
@@ -104,6 +104,9 @@ jboolean libreofficekit_initialize(JNIEnv* env,
close(fd);
LOGI("Setting FONTCONFIG_FILE to %s", fontsConfPath);
setenv("FONTCONFIG_FILE", fontsConfPath, 1);
+// DEBUG:
+//setenv("FC_DEBUG", "8191", 1); // log everything
+//Java_org_libreoffice_android_Bootstrap_redirect_1stdio(NULL, NULL,
JNI_TRUE);
}
free(fontsConfPath);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 119111] Shapes losing position and z-index
https://bugs.documentfoundation.org/show_bug.cgi?id=119111 DM changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129127] Crash when sort by column of Excel 97-2003 file with specific data
https://bugs.documentfoundation.org/show_bug.cgi?id=129127 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org Crash report or|crashreport.libreoffice.org |["ScDocumentPool::PutImpl(S crash signature|/stats/crash_details/bc3cf2 |fxPoolItem const &,unsigned |59-3859-4aa3-96ca-b313a14b3 |short,bool)"] |b3f | See Also||https://crashreport.libreof ||fice.org/stats/signature/Sc ||DocumentPool::PutImpl(SfxPo ||olItem%20const%20&,unsigned ||%20short,bool) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119111] Shapes losing position and z-index
https://bugs.documentfoundation.org/show_bug.cgi?id=119111 --- Comment #17 from DM --- Created attachment 156239 --> https://bugs.documentfoundation.org/attachment.cgi?id=156239=edit Move-Undo example of unrelated item jumping Here is another example of the sort of problem on my doc I am updating, and several related examples have been posted in the past in the comments (so I've changed it to Unconfirmed). On p3, move the arrow under "Long Awns" to be over the picture on its left (i.e. move it to be under "Flowerhead reaches upper leaf base" then click Ctrl-Z to undo the act. You'll see not only does it move back, but a completely random item from elsewhere in the document jumps there too. This is quite a common occurrence. Version: 6.3.2.2 (x64) Build ID: 98b30e735bda24bc04ab42594c85f7fd8be07b9c CPU threads: 2; OS: Windows 10.0; UI render: default; VCL: win; Locale: en-GB (en_GB); UI-Language: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93669] Problem with printing multi-sided documents via Fax-Printer
https://bugs.documentfoundation.org/show_bug.cgi?id=93669 Gisbert Juch changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #31 from Gisbert Juch --- Now I've tested in Windows 10 and LibreOffice 6.3.3.2 (x64). The full fax containing of 4 pages is sent. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/inc
cui/inc/tipoftheday.hrc |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit a3d353e0b645fe177e24c6c93d29191cd7162633
Author: Ilmari Lauhakangas
AuthorDate: Fri Nov 29 12:37:12 2019 +0200
Commit: Heiko Tietze
CommitDate: Mon Dec 2 11:07:36 2019 +0100
Fix regex in tip of the day
Change-Id: Ib4e3cd80c0103fe3cf63cf7849805725a8a5ec63
Reviewed-on: https://gerrit.libreoffice.org/84053
Tested-by: Jenkins
Reviewed-by: Heiko Tietze
diff --git a/cui/inc/tipoftheday.hrc b/cui/inc/tipoftheday.hrc
index eb25bf339906..602e1755ef01 100644
--- a/cui/inc/tipoftheday.hrc
+++ b/cui/inc/tipoftheday.hrc
@@ -148,7 +148,7 @@ const std::tuple
TIPOFTHEDAY_STRINGARRAY[] =
{ NC_("RID_CUI_TIPOFTHEDAY", "Play music throughout a slideshow by
assigning the sound to the first slide transition without clicking the ‘Apply
to All Slides’ button."), "", "tipoftheday_i.png"},
{ NC_("RID_CUI_TIPOFTHEDAY", "%PRODUCTNAME doesn't calculate from left to
right but respects the order Parentheses > Exponents > Multiplication >
Division > Addition > Subtraction."), "", "tipoftheday_c.png"},
{ NC_("RID_CUI_TIPOFTHEDAY", "Get %PRODUCTNAME documentation and free
user guide books at:"), "http://www.libreoffice.org/get-help/documentation;,
""},
- { NC_("RID_CUI_TIPOFTHEDAY", "Want to remove all <> at once and keep the
text inside? Edit > Find & Replace: Search = [<|>], Replace = blank and check
‘Regular expressions’ under Other options."),
"https://help.libreoffice.org/%PRODUCTVERSION/%LANGUAGENAME/text/shared/01/0211.html;,
""}, //local help missing
+ { NC_("RID_CUI_TIPOFTHEDAY", "Want to remove all <> at once and keep the
text inside? Edit > Find & Replace: Search = [<>], Replace = blank and check
‘Regular expressions’ under Other options."),
"https://help.libreoffice.org/%PRODUCTVERSION/%LANGUAGENAME/text/shared/01/0211.html;,
""}, //local help missing
{ NC_("RID_CUI_TIPOFTHEDAY", "Need to present a report written with
Writer? File > Send > Outline to Presentation automatically creates a slideshow
from the outline."), "", "tipoftheday_w.png"},
{ NC_("RID_CUI_TIPOFTHEDAY", "Want to manage the presentation of
hyperlinks in a spreadsheet? Insert them with the HYPERLINK function."),
"https://help.libreoffice.org/%PRODUCTVERSION/%LANGUAGENAME/text/scalc/01/04060109.html;,
"tipoftheday_c.png"}, //local help missing
{ NC_("RID_CUI_TIPOFTHEDAY", "Uncheck Tools > Options > %PRODUCTNAME Calc
> View > Zoom: 'Synchronize sheets' so that each sheet in Calc has its own zoom
factor."), "", "tipoftheday_c.png"},
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129123] CRASH: editing matrix formula with enabled context change listener
https://bugs.documentfoundation.org/show_bug.cgi?id=129123 Xisco Faulí changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #3 from Xisco Faulí --- I can't reproduce it in Version: 6.5.0.0.alpha0+ Build ID: ea97f0926e138712c3800f5274012f0f04fc1c47 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded To be certain the reported issue is not related to corruption in the user profile, could you please reset your Libreoffice profile ( https://wiki.documentfoundation.org/UserProfile ) and re-test? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the issue is still present -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119111] Shapes losing position and z-index
https://bugs.documentfoundation.org/show_bug.cgi?id=119111 --- Comment #16 from DM --- That is an extremely enlightening comment, and I apologise for just noticing it now. Surely if name is critical to operations, then it's a bug in itself for two objects to have the same name (like two people having the same national identity number) or so easily to do so? how could it happen? I copy items to duplicate them all the time, would you be suggesting that copying them retains the same name (just tried it and it seems so!) and that I need to rename every item I copy? that sounds an extraordinary deficiency to me, since copying drawing objects like arrows and text boxes to reuse is something you do all the time to maintain a common style throughout a document. What sort of complications occur through having objects the same name in terms of everyday document-making? Are there occasions when two items having the same name are useful? if not, shouldn't copies just generate new names? I would be very keen to hear your reply here, since the whole situation of Libreoffice constantly mangling everything up drives me crazy... thanks! David (In reply to Regina Henschel from comment #15) > You need to take care, that all objects have unique names. In your attached > document several objects have the same name. Please test, whether you see > the problem too, if you have corrected the names. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - sw/inc sw/source writerfilter/source
sw/inc/ftnidx.hxx|6
sw/inc/txatritr.hxx |6
sw/source/core/doc/ftnidx.cxx|8 -
sw/source/core/inc/UndoInsert.hxx| 18 +-
sw/source/core/txtnode/txatritr.cxx | 30 +--
sw/source/core/undo/unins.cxx| 116 +++
writerfilter/source/dmapper/DomainMapperTableHandler.cxx | 38
writerfilter/source/dmapper/DomainMapperTableHandler.hxx |2
writerfilter/source/dmapper/DomainMapper_Impl.cxx|8 -
writerfilter/source/dmapper/DomainMapper_Impl.hxx| 10 -
10 files changed, 92 insertions(+), 150 deletions(-)
New commits:
commit 749fd6508504cf3b2e3822eca52a67fa36d75fb8
Author: Justin Luth
AuthorDate: Sat Nov 30 12:07:11 2019 +0300
Commit: László Németh
CommitDate: Mon Dec 2 11:00:25 2019 +0100
revert obsolete writerfilter hacks for tdf#119054 and tdf#128752
These are obsoleted in LibreOffice 6.5 by tdf#118947's
commit 6bced3c6a1bf8d4652dd6ba75e41b128ce1bfc5c
Both of these hacks were backported to 6.4, but
I have no intention of backporting my patch.
Change-Id: Ie639b9d55d90d25b58e140fba443fce98f2d7ba1
Reviewed-on: https://gerrit.libreoffice.org/84125
Tested-by: Jenkins
Reviewed-by: Justin Luth
Reviewed-by: László Németh
diff --git a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
index 9fa23720ba00..fb596a983204 100644
--- a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
+++ b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
@@ -809,9 +809,6 @@ CellPropertyValuesSeq_t
DomainMapperTableHandler::endTableGetCellProperties(Tabl
// Remove properties from style/row that aren't allowed in
cells
pAllCellProps->Erase( PROP_HEADER_ROW_COUNT );
pAllCellProps->Erase( PROP_TBL_HEADER );
-// Remove paragraph properties from style/row that paragraph
style can overwrite
-pAllCellProps->Erase( PROP_PARA_BOTTOM_MARGIN );
-pAllCellProps->Erase( PROP_PARA_LINE_SPACING );
// Then add the cell properties
pAllCellProps->InsertProps(*aCellIterator);
@@ -984,36 +981,6 @@ css::uno::Sequence
DomainMapperTableHandler::endTabl
return aRowProperties;
}
-// table style has got bigger precedence than docDefault style,
-// but lower precedence than the paragraph styles and direct paragraph
formatting
-void DomainMapperTableHandler::ApplyParaProperty(css::beans::PropertyValues
aTableProperties, PropertyIds eId)
-{
-OUString sPropertyName = getPropertyName(eId);
-auto pTableProp = std::find_if(aTableProperties.begin(),
aTableProperties.end(),
-[&](const beans::PropertyValue& rProp) { return rProp.Name ==
sPropertyName; });
-if (pTableProp != aTableProperties.end())
-{
-uno::Any aValue = pTableProp->Value;
-for (const auto& rParaProp : m_rDMapper_Impl.m_aParagraphsToEndTable)
-{
-// there is no direct paragraph formatting
-if (!rParaProp.m_pPropertyMap->isSet(eId))
-{
-OUString sParaStyleName;
-rParaProp.m_rPropertySet->getPropertyValue("ParaStyleName")
>>= sParaStyleName;
-StyleSheetEntryPtr pEntry =
m_rDMapper_Impl.GetStyleSheetTable()->FindStyleSheetByConvertedStyleName(sParaStyleName);
-uno::Any aMargin =
m_rDMapper_Impl.GetPropertyFromStyleSheet(eId, pEntry, true, true);
-uno::Any aMarginDocDefault =
m_rDMapper_Impl.GetPropertyFromStyleSheet(eId, nullptr, true, true);
-// use table style only when 1) both values are empty (no
docDefault and paragraph style definitions) or
-// 2) both non-empty values are equal (docDefault paragraph
properties are copied to the base paragraph style during import)
-// TODO check the case, when two parent styles modify the
docDefault and the last one set back the docDefault value
-if (aMargin == aMarginDocDefault)
-rParaProp.m_rPropertySet->setPropertyValue(sPropertyName,
aValue);
-}
-}
-}
-}
-
void DomainMapperTableHandler::endTable(unsigned int nestedTableLevel, bool
bTableStartsAtCellStart)
{
#ifdef DBG_UTIL
@@ -,10 +1078,6 @@ void DomainMapperTableHandler::endTable(unsigned int
nestedTableLevel, bool bTab
}
}
}
-
-// OOXML table style may container paragraph properties, apply
these now.
-ApplyParaProperty(aTableInfo.aTableProperties,
PROP_PARA_BOTTOM_MARGIN);
-ApplyParaProperty(aTableInfo.aTableProperties,
PROP_PARA_LINE_SPACING);
}
}
catch ( const
[Libreoffice-bugs] [Bug 119054] FILEOPEN DOCX Paragraph style in a table appears without the set spacing below
https://bugs.documentfoundation.org/show_bug.cgi?id=119054 --- Comment #8 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/749fd6508504cf3b2e3822eca52a67fa36d75fb8 revert obsolete writerfilter hacks for tdf#119054 and tdf#128752 It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=64 ||753 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129053] FILESAVE XLSX: protected sheet looses cell-comment
https://bugs.documentfoundation.org/show_bug.cgi?id=129053 Timur changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Timur --- Thank you, but please first search. This seems like a duplicate and I mark. If you think it's not correct, please explain. *** This bug has been marked as a duplicate of bug 119190 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 Timur changed: What|Removed |Added Severity|normal |major Priority|medium |high -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119190] Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'
https://bugs.documentfoundation.org/show_bug.cgi?id=119190 Timur changed: What|Removed |Added CC||theo.ra...@orange.fr --- Comment #7 from Timur --- *** Bug 129053 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129139] LO Draw Editing > Copy object(Ctrl C) > Paste (Ctrl V) Results: Computer becomes unstable!
https://bugs.documentfoundation.org/show_bug.cgi?id=129139 Xisco Faulí changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #2 from Xisco Faulí --- Thank you for reporting the bug. To be certain the reported issue is not related to corruption in the user profile, could you please reset your Libreoffice profile ( https://wiki.documentfoundation.org/UserProfile ) and re-test? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the issue is still present -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129139] LO Draw Editing > Copy object(Ctrl C) > Paste (Ctrl V) Results: Computer becomes unstable!
https://bugs.documentfoundation.org/show_bug.cgi?id=129139 --- Comment #1 from IM --- Thank you for reporting a bug, I can't reproduct it in: Version: 6.3.3.2 (x64) Build ID: a64200df03143b798afd1ec74a12ab50359878ed CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; Locale: pl-PL (pl_PL); UI-Language: en-US Calc: threaded Version: 6.5.0.0.alpha0+ (x64) Build ID: 05734503ed36cff64cfaac8afb7c6df5eced8873 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win; Locale: pl-PL (pl_PL); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129135] Multilingual Basic programming needs to be documented
https://bugs.documentfoundation.org/show_bug.cgi?id=129135 LibreOfficiant changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |libreoffici...@sfr.fr |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129136] crash in basic function CurDir
https://bugs.documentfoundation.org/show_bug.cgi?id=129136 Xisco Faulí changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from Xisco Faulí --- Reproduced in Versión: 6.3.3.2 (x86) Id. de compilación: a64200df03143b798afd1ec74a12ab50359878ed Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; VCL: win; Configuración regional: es-ES (es_ES); Idioma de IU: es-ES Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 71501] EDITING: “Enter“ in first Cell of Table Creates a Paragraph above Table
https://bugs.documentfoundation.org/show_bug.cgi?id=71501 Heiko Tietze changed: What|Removed |Added CC||c...@nouenoff.nl, ||mikekagan...@hotmail.com, ||nem...@numbertext.org --- Comment #15 from Heiko Tietze --- Ctrl+enter is placed before the table but becomes not active until a first character is inserted via at+enter. The documentation part should have been solved with bug 112804. Bug 105333 and 84806 discuss the same/similar topic, and was solve recently by Lazlo. Harald created also the duplicate bug 71503, one is the generic issue and the other his expectation (enter at the very first item at the table behaves special). And this is actually a question to me. Once enter at position 0 of the table adds a paragraph above, the workaround to insert a break at position 0 could be to insert a space first. Sounds reasonable simple to me, rather to point users to the documentation and to learn alt+enter. And it sounds much better than the proposed solution in bug 51689. We should investigate how alt+enter is implemented (likely hard-coded) and free this shortcut for customization. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 71501] EDITING: “Enter“ in first Cell of Table Creates a Paragraph above Table
https://bugs.documentfoundation.org/show_bug.cgi?id=71501 Heiko Tietze changed: What|Removed |Added CC||c...@nouenoff.nl, ||mikekagan...@hotmail.com, ||nem...@numbertext.org --- Comment #15 from Heiko Tietze --- Ctrl+enter is placed before the table but becomes not active until a first character is inserted via at+enter. The documentation part should have been solved with bug 112804. Bug 105333 and 84806 discuss the same/similar topic, and was solve recently by Lazlo. Harald created also the duplicate bug 71503, one is the generic issue and the other his expectation (enter at the very first item at the table behaves special). And this is actually a question to me. Once enter at position 0 of the table adds a paragraph above, the workaround to insert a break at position 0 could be to insert a space first. Sounds reasonable simple to me, rather to point users to the documentation and to learn alt+enter. And it sounds much better than the proposed solution in bug 51689. We should investigate how alt+enter is implemented (likely hard-coded) and free this shortcut for customization. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108252] [META] Cell-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108252 Bug 108252 depends on bug 36968, which changed state. Bug 36968 Summary: FORMATTING cells: background color not displayed on VDU on protected sheet https://bugs.documentfoundation.org/show_bug.cgi?id=36968 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36968] FORMATTING cells: background color not displayed on VDU on protected sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=36968 Timur changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #23 from Timur --- This bug started as one issue and in Comment 11 was hijacked as another, similar to bug 129024. I will close this one as WFM for the original issue. As for another issue, from Comment 17, that's NotABug per Help: https://help.libreoffice.org/6.5/en-US/text/scalc/01/0308.html -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129136] crash in basic function CurDir
https://bugs.documentfoundation.org/show_bug.cgi?id=129136 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org Crash report or|http://crashreport.libreoff |["SbRtl_CurDir(StarBASIC crash signature|ice.org/stats/crash_details |*,SbxArray &,bool)"] |/cd648772-47ea-4f2b-af5a-a4 | |557fce6484 | See Also||https://crashreport.libreof ||fice.org/stats/signature/Sb ||Rtl_CurDir(StarBASIC%20*,Sb ||xArray%20&,bool) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - desktop/source sal/android
desktop/source/lib/init.cxx | 21 ++---
sal/android/libreofficekit-jni.c |5 -
2 files changed, 6 insertions(+), 20 deletions(-)
New commits:
commit fa6979f1f5e781aa8d141a7a6691e2de55937c39
Author: Jan Holesovsky
AuthorDate: Wed Nov 20 17:55:43 2019 +0100
Commit: Jan Holesovsky
CommitDate: Mon Dec 2 10:23:25 2019 +0100
android: Get rid of the 'old' vs. Online-based runtime distinction.
No need for this when we have a compile-time distinction now anyway.
Change-Id: Ic86c8cce38a86635ea3efb4229c08f63059c9ee6
Reviewed-on: https://gerrit.libreoffice.org/83343
Reviewed-by: Jan Holesovsky
Tested-by: Jenkins CollaboraOffice
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index afbd4d283b35..ec13f24fae3b 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -7,6 +7,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
+#include
#include
#include
@@ -2711,13 +2712,6 @@ static void doc_setPartMode(LibreOfficeKitDocument*
pThis,
}
}
-#if defined(ANDROID)
-/// For the distinction if the LOK is used for the 'old' (JNI-based) or the
-/// 'new' (loolwsd-based) app. Default to the 'new', ie. not used from JNI as
-/// implemented in sal/android/libreofficekit-jni.c.
-bool android_lok_from_jni = false;
-#endif
-
static void doc_paintTile(LibreOfficeKitDocument* pThis,
unsigned char* pBuffer,
const int nCanvasWidth, const int nCanvasHeight,
@@ -2755,15 +2749,12 @@ static void doc_paintTile(LibreOfficeKitDocument* pThis,
#else
ScopedVclPtrInstance< VirtualDevice > pDevice(nullptr, Size(1, 1),
DeviceFormat::DEFAULT) ;
-#if defined(ANDROID)
-if (!android_lok_from_jni)
+#if HAVE_FEATURE_ANDROID_LOK
+// Set background to transparent by default.
+// [Unless it is the 'old' (JNI-based) Android app - no idea why it
+// needs avoiding this.]
+pDevice->SetBackground(Wallpaper(COL_TRANSPARENT));
#endif
-{
-// Set background to transparent by default.
-// [Unless it is the 'old' (JNI-based) Android app - no idea why it
-// needs avoiding this.]
-pDevice->SetBackground(Wallpaper(COL_TRANSPARENT));
-}
pDevice->SetOutputSizePixelScaleOffsetAndBuffer(
Size(nCanvasWidth, nCanvasHeight), Fraction(1.0), Point(),
diff --git a/sal/android/libreofficekit-jni.c b/sal/android/libreofficekit-jni.c
index 93742833168b..b853d8e75380 100644
--- a/sal/android/libreofficekit-jni.c
+++ b/sal/android/libreofficekit-jni.c
@@ -37,7 +37,6 @@ extern const char* data_dir;
extern const char* cache_dir;
extern void* apk_file;
extern int apk_file_size;
-extern bool android_lok_from_jni; ///< for the distinction if the LOK is used
for the 'old' (JNI-based) or the 'new' (loolwsd-based) app
AAssetManager* native_asset_manager;
extern void Java_org_libreoffice_android_Bootstrap_putenv(JNIEnv* env, jobject
clazz, jstring string);
@@ -163,10 +162,6 @@ jboolean
Java_org_libreoffice_kit_LibreOfficeKit_initializeNative
(void) clazz;
-// the 'old' app needs to avoid setting the virtual device to transparent
-// in paintTile(), so indicate we are using the 'old' app
-android_lok_from_jni = true;
-
libreofficekit_initialize(env, dataDir, cacheDir, apkFile, assetManager);
// LibreOfficeKit expects a path to the program/ directory
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - bridges/source
bridges/source/cpp_uno/gcc3_aix_powerpc/share.hxx |2 +- bridges/source/cpp_uno/gcc3_linux_aarch64/abi.hxx |2 +- bridges/source/cpp_uno/gcc3_linux_alpha/share.hxx |2 +- bridges/source/cpp_uno/gcc3_linux_hppa/share.hxx |2 +- bridges/source/cpp_uno/gcc3_linux_ia64/share.hxx |2 +- bridges/source/cpp_uno/gcc3_linux_m68k/share.hxx |2 +- bridges/source/cpp_uno/gcc3_linux_mips/share.hxx |2 +- bridges/source/cpp_uno/gcc3_linux_mips64/share.hxx|2 +- bridges/source/cpp_uno/gcc3_linux_powerpc/share.hxx |2 +- bridges/source/cpp_uno/gcc3_linux_powerpc64/share.hxx |2 +- bridges/source/cpp_uno/gcc3_linux_s390/share.hxx |2 +- bridges/source/cpp_uno/gcc3_linux_s390x/share.hxx |2 +- bridges/source/cpp_uno/gcc3_linux_sparc/share.hxx |2 +- bridges/source/cpp_uno/gcc3_linux_sparc64/share.hxx |2 +- bridges/source/cpp_uno/gcc3_solaris_intel/share.hxx |2 +- bridges/source/cpp_uno/gcc3_solaris_sparc/share.hxx |2 +- 16 files changed, 16 insertions(+), 16 deletions(-) New commits: commit cfbf9a41d3e3c6237d37c162bffeb941ea1e4918 Author: Caolán McNamara AuthorDate: Mon Dec 3 11:20:32 2018 + Commit: Jan Holesovsky CommitDate: Mon Dec 2 10:22:28 2019 +0100 sync std::unexpected_handler across bridges Change-Id: I2c2b1159ee697acc1d22740f7a2167b30a7fec41 Reviewed-on: https://gerrit.libreoffice.org/64446 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara Reviewed-on: https://gerrit.libreoffice.org/81887 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/bridges/source/cpp_uno/gcc3_aix_powerpc/share.hxx b/bridges/source/cpp_uno/gcc3_aix_powerpc/share.hxx index c34033a53e72..1d1a757ff857 100644 --- a/bridges/source/cpp_uno/gcc3_aix_powerpc/share.hxx +++ b/bridges/source/cpp_uno/gcc3_aix_powerpc/share.hxx @@ -46,7 +46,7 @@ struct __cxa_exception std::type_info *exceptionType; void (*exceptionDestructor)(void *); -std::unexpected_handler unexpectedHandler; +void (*unexpectedHandler)(); // std::unexpected_handler dropped from C++17 std::terminate_handler terminateHandler; __cxa_exception *nextException; diff --git a/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.hxx b/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.hxx index d910b454b04f..50c5f1f21a37 100644 --- a/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.hxx +++ b/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.hxx @@ -47,7 +47,7 @@ struct __cxa_exception std::type_info *exceptionType; void (*exceptionDestructor)(void *); -std::unexpected_handler unexpectedHandler; +void (*unexpectedHandler)(); // std::unexpected_handler dropped from C++17 std::terminate_handler terminateHandler; __cxa_exception *nextException; diff --git a/bridges/source/cpp_uno/gcc3_linux_alpha/share.hxx b/bridges/source/cpp_uno/gcc3_linux_alpha/share.hxx index 944b4fd18859..b66e6377c46e 100644 --- a/bridges/source/cpp_uno/gcc3_linux_alpha/share.hxx +++ b/bridges/source/cpp_uno/gcc3_linux_alpha/share.hxx @@ -46,7 +46,7 @@ struct __cxa_exception std::type_info *exceptionType; void (*exceptionDestructor)(void *); -std::unexpected_handler unexpectedHandler; +void (*unexpectedHandler)(); // std::unexpected_handler dropped from C++17 std::terminate_handler terminateHandler; __cxa_exception *nextException; diff --git a/bridges/source/cpp_uno/gcc3_linux_hppa/share.hxx b/bridges/source/cpp_uno/gcc3_linux_hppa/share.hxx index 5a65f275..c2a64c61a11a 100644 --- a/bridges/source/cpp_uno/gcc3_linux_hppa/share.hxx +++ b/bridges/source/cpp_uno/gcc3_linux_hppa/share.hxx @@ -46,7 +46,7 @@ struct __cxa_exception std::type_info *exceptionType; void (*exceptionDestructor)(void *); -std::unexpected_handler unexpectedHandler; +void (*unexpectedHandler)(); // std::unexpected_handler dropped from C++17 std::terminate_handler terminateHandler; __cxa_exception *nextException; diff --git a/bridges/source/cpp_uno/gcc3_linux_ia64/share.hxx b/bridges/source/cpp_uno/gcc3_linux_ia64/share.hxx index 30111698ec6b..684223f7bf20 100644 --- a/bridges/source/cpp_uno/gcc3_linux_ia64/share.hxx +++ b/bridges/source/cpp_uno/gcc3_linux_ia64/share.hxx @@ -47,7 +47,7 @@ struct __cxa_exception std::type_info *exceptionType; void (*exceptionDestructor)(void *); -std::unexpected_handler unexpectedHandler; +void (*unexpectedHandler)(); // std::unexpected_handler dropped from C++17 std::terminate_handler terminateHandler; __cxa_exception *nextException; diff --git a/bridges/source/cpp_uno/gcc3_linux_m68k/share.hxx b/bridges/source/cpp_uno/gcc3_linux_m68k/share.hxx index e97a018855d5..122a750fa86b 100644 --- a/bridges/source/cpp_uno/gcc3_linux_m68k/share.hxx +++ b/bridges/source/cpp_uno/gcc3_linux_m68k/share.hxx @@ -46,7 +46,7 @@ struct __cxa_exception std::type_info
[Libreoffice-bugs] [Bug 129024] FORMATTING - Preset protected cell background color not displayed in spreadsheet (documentation per Comment 6)
https://bugs.documentfoundation.org/show_bug.cgi?id=129024 Timur changed: What|Removed |Added CC||olivier.hallot@libreoffice. ||org Severity|normal |minor Priority|medium |low Summary|FORMATTING - Preset |FORMATTING - Preset |protected cell background |protected cell background |color not displayed in |color not displayed in |spreadsheet |spreadsheet (documentation ||per Comment 6) OS|Mac OS X (All) |All Component|Calc|Documentation --- Comment #6 from Timur --- Thanks ghaecker for finding the explaination. That's per Help https://help.libreoffice.org/6.5/en-US/text/scalc/01/0308.html. So that's as expected and bug is literally NotABug. But looking at this, I noticed that Help doesn't work for Tools - Options - LibreOffice - Application Colors. And I'll convert the bug as documentation for that. That can also go to the existing above-mentioned page. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109425] Libreoffice Notebookbar is not exposing accessible events needed for screen reader users.
https://bugs.documentfoundation.org/show_bug.cgi?id=109425 --- Comment #34 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/9d55361562602a420103e28dfacac8f4d80ab1db tdf#109425 Make paraspacing windows grab focus It will be available in 6.4.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109425] Libreoffice Notebookbar is not exposing accessible events needed for screen reader users.
https://bugs.documentfoundation.org/show_bug.cgi?id=109425 --- Comment #32 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/83b4c4373e1d68f79fcf841799db21320297fc88 tdf#109425 Fixes for notebookbar single It will be available in 6.4.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - 3 commits - svx/source svx/uiconfig sw/uiconfig
svx/source/sidebar/paragraph/ParaSpacingWindow.cxx | 25 +
svx/source/sidebar/paragraph/ParaSpacingWindow.hxx |5
svx/uiconfig/ui/paralrspacing.ui |6 ++---
svx/uiconfig/ui/paraulspacing.ui |4 +--
sw/uiconfig/swriter/ui/notebookbar_compact.ui |2 -
sw/uiconfig/swriter/ui/notebookbar_single.ui |3 ++
6 files changed, 39 insertions(+), 6 deletions(-)
New commits:
commit 9d55361562602a420103e28dfacac8f4d80ab1db
Author: Jim Raykowski
AuthorDate: Fri Nov 29 21:29:47 2019 -0900
Commit: andreas_kainz
CommitDate: Mon Dec 2 10:21:03 2019 +0100
tdf#109425 Make paraspacing windows grab focus
to their shown SvxRelativeField when focus is gained using keyboard
navigation. The patch also corrects images used for before, after, and
above controls.
Change-Id: Ic1411ac0eddf3b281590ac5821171b5e8aaac976
Reviewed-on: https://gerrit.libreoffice.org/84103
Tested-by: Jenkins
Reviewed-by: andreas_kainz
(cherry picked from commit 65d3285536e3342c2b1b669d0dc8c134bc7254c6)
Reviewed-on: https://gerrit.libreoffice.org/84152
diff --git a/svx/source/sidebar/paragraph/ParaSpacingWindow.cxx
b/svx/source/sidebar/paragraph/ParaSpacingWindow.cxx
index d945b32ed5bf..d6800db15b8c 100644
--- a/svx/source/sidebar/paragraph/ParaSpacingWindow.cxx
+++ b/svx/source/sidebar/paragraph/ParaSpacingWindow.cxx
@@ -116,6 +116,11 @@
ParaAboveSpacingWindow::ParaAboveSpacingWindow(vcl::Window* pParent, css::uno::R
m_pBelowContainer->Hide();
}
+void ParaAboveSpacingWindow::GetFocus()
+{
+m_pAboveSpacing->GrabFocus();
+}
+
// ParaBelowSpacingWindow
ParaBelowSpacingWindow::ParaBelowSpacingWindow(vcl::Window* pParent,
css::uno::Reference const & xFrame)
@@ -125,6 +130,11 @@
ParaBelowSpacingWindow::ParaBelowSpacingWindow(vcl::Window* pParent, css::uno::R
m_pBelowContainer->Show();
}
+void ParaBelowSpacingWindow::GetFocus()
+{
+m_pBelowSpacing->GrabFocus();
+}
+
// ParaLRSpacingWindow
ParaLRSpacingWindow::ParaLRSpacingWindow(vcl::Window* pParent,
css::uno::Reference const & xFrame)
@@ -304,6 +314,11 @@ ParaLeftSpacingWindow::ParaLeftSpacingWindow(vcl::Window*
pParent, css::uno::Ref
m_pFirstLineContainer->Hide();
}
+void ParaLeftSpacingWindow::GetFocus()
+{
+m_pBeforeSpacing->GrabFocus();
+}
+
// ParaRightSpacingWindow
ParaRightSpacingWindow::ParaRightSpacingWindow(vcl::Window* pParent,
css::uno::Reference const & xFrame)
@@ -314,6 +329,11 @@
ParaRightSpacingWindow::ParaRightSpacingWindow(vcl::Window* pParent, css::uno::R
m_pFirstLineContainer->Hide();
}
+void ParaRightSpacingWindow::GetFocus()
+{
+m_pAfterSpacing->GrabFocus();
+}
+
// ParaFirstLineSpacingWindow
ParaFirstLineSpacingWindow::ParaFirstLineSpacingWindow(vcl::Window* pParent,
css::uno::Reference const & xFrame)
@@ -324,4 +344,9 @@
ParaFirstLineSpacingWindow::ParaFirstLineSpacingWindow(vcl::Window* pParent, css
m_pFirstLineContainer->Show();
}
+void ParaFirstLineSpacingWindow::GetFocus()
+{
+m_pFLSpacing->GrabFocus();
+}
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/svx/source/sidebar/paragraph/ParaSpacingWindow.hxx
b/svx/source/sidebar/paragraph/ParaSpacingWindow.hxx
index 5d0496414bd2..6d7ad8232102 100644
--- a/svx/source/sidebar/paragraph/ParaSpacingWindow.hxx
+++ b/svx/source/sidebar/paragraph/ParaSpacingWindow.hxx
@@ -60,12 +60,14 @@ class ParaAboveSpacingWindow : public ParaULSpacingWindow
{
public:
explicit ParaAboveSpacingWindow(vcl::Window* pParent,
css::uno::Reference const & xFrame);
+virtual void GetFocus() override;
};
class ParaBelowSpacingWindow : public ParaULSpacingWindow
{
public:
explicit ParaBelowSpacingWindow(vcl::Window* pParent,
css::uno::Reference const & xFrame);
+virtual void GetFocus() override;
};
class ParaLRSpacingWindow : public VclVBox,
@@ -100,18 +102,21 @@ class ParaLeftSpacingWindow : public ParaLRSpacingWindow
{
public:
explicit ParaLeftSpacingWindow(vcl::Window* pParent,
css::uno::Reference const & xFrame);
+virtual void GetFocus() override;
};
class ParaRightSpacingWindow : public ParaLRSpacingWindow
{
public:
explicit ParaRightSpacingWindow(vcl::Window* pParent,
css::uno::Reference const & xFrame);
+virtual void GetFocus() override;
};
class ParaFirstLineSpacingWindow : public ParaLRSpacingWindow
{
public:
explicit ParaFirstLineSpacingWindow(vcl::Window* pParent,
css::uno::Reference const & xFrame);
+virtual void GetFocus() override;
};
}
diff --git a/svx/uiconfig/ui/paralrspacing.ui b/svx/uiconfig/ui/paralrspacing.ui
index d38ff54dd161..6093e4a1eee9 100644
--- a/svx/uiconfig/ui/paralrspacing.ui
+++ b/svx/uiconfig/ui/paralrspacing.ui
@@ -1,5 +1,5 @@
-
+
@@ -22,7 +22,7 @@
False
center
center
-svx/res/symphony/Indent2.png
+
[Libreoffice-bugs] [Bug 109425] Libreoffice Notebookbar is not exposing accessible events needed for screen reader users.
https://bugs.documentfoundation.org/show_bug.cgi?id=109425 --- Comment #33 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/6e1f57551935250c45eb0c1c868f5d24842a5389 tdf#109425 NB bar compact: Make send mail button kb accessible It will be available in 6.4.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129142] problem with my ms office
https://bugs.documentfoundation.org/show_bug.cgi?id=129142 Buovjaga changed: What|Removed |Added Resolution|--- |INVALID Status|UNCONFIRMED |RESOLVED Component|Installation|deletionRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - bridges/source
bridges/source/cpp_uno/gcc3_linux_aarch64/abi.cxx |2 +-
bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx |8
bridges/source/cpp_uno/gcc3_linux_aarch64/uno2cpp.cxx |8
3 files changed, 9 insertions(+), 9 deletions(-)
New commits:
commit 3c714bf27289463a6e6802d4cdf1ff2431e8c494
Author: Jan Holesovsky
AuthorDate: Fri Nov 1 15:18:49 2019 +0100
Commit: Jan Holesovsky
CommitDate: Mon Dec 2 10:15:31 2019 +0100
bridges arm64: Use [[falltrough]].
Change-Id: I28d3cabab74bea6ea9f2712c240110a44643c54d
Reviewed-on: https://gerrit.libreoffice.org/84194
Reviewed-by: Jan Holesovsky
Tested-by: Jan Holesovsky
diff --git a/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.cxx
b/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.cxx
index 477879f2f2a0..6335d0c5c8a2 100644
--- a/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.cxx
@@ -262,7 +262,7 @@ ReturnKind getReturnKind(typelib_TypeDescription const *
type) {
switch (type->eTypeClass) {
default:
assert(false);
-// fall through to avoid warnings
+[[fallthrough]];
case typelib_TypeClass_VOID:
case typelib_TypeClass_BOOLEAN:
case typelib_TypeClass_BYTE:
diff --git a/bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx
b/bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx
index 4865f49a0421..d11a11b0c965 100644
--- a/bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx
@@ -187,13 +187,13 @@ void call(
switch (rtd->nSize) {
case 16:
std::memcpy(fpr + 3, static_cast(retin) + 12, 4);
-// fall through
+[[fallthrough]];
case 12:
std::memcpy(fpr + 2, static_cast(retin) + 8, 4);
-// fall through
+[[fallthrough]];
case 8:
std::memcpy(fpr + 1, static_cast(retin) + 4, 4);
-// fall through
+[[fallthrough]];
case 4:
std::memcpy(fpr, retin, 4);
break;
@@ -286,7 +286,7 @@ extern "C" void vtableCall(
TYPELIB_DANGER_RELEASE(td);
}
}
-// fall through
+[[fallthrough]];
default:
call(
proxy, desc,
diff --git a/bridges/source/cpp_uno/gcc3_linux_aarch64/uno2cpp.cxx
b/bridges/source/cpp_uno/gcc3_linux_aarch64/uno2cpp.cxx
index 32a19de020b1..f03d848521cc 100644
--- a/bridges/source/cpp_uno/gcc3_linux_aarch64/uno2cpp.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_aarch64/uno2cpp.cxx
@@ -252,13 +252,13 @@ void call(
switch (rtd->nSize) {
case 16:
std::memcpy(static_cast(ret) + 12, fpr + 3, 4);
-// fall through
+[[fallthrough]];
case 12:
std::memcpy(static_cast(ret) + 8, fpr + 2, 4);
-// fall through
+[[fallthrough]];
case 8:
std::memcpy(static_cast(ret) + 4, fpr + 1, 4);
-// fall through
+[[fallthrough]];
case 4:
std::memcpy(ret, fpr, 4);
break;
@@ -356,7 +356,7 @@ void unoInterfaceProxyDispatch(
TYPELIB_DANGER_RELEASE(td);
}
}
-// fall through
+[[fallthrough]];
default:
call(
proxy, slot, mtd->pReturnTypeRef, mtd->nParams,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 129040] [UX] In Donut charts we can not assign the same color to all the pieces
https://bugs.documentfoundation.org/show_bug.cgi?id=129040 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Heiko Tietze --- The pie chart (whether Donut or not) intends to show the split of a few related values over their total. Like how many votes parties have received during an election. You want to see the relative percentage and clearly know who got it. Meaning it has to be different colored by default. Charts always allow to select just one piece. Go to edit mode, select the ring, and click (not double) on one pie - it will be selected individually and you can apply a color to this particular item. What you actually want is some kind of chart style or just a color palette applied to the bars, pies, dots etc. You can do it now via tools > options > charts > default colors, which is admittedly not handy. Regarding this ticket I would resolve as WF. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 129040] [UX] In Donut charts we can not assign the same color to all the pieces
https://bugs.documentfoundation.org/show_bug.cgi?id=129040 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Heiko Tietze --- The pie chart (whether Donut or not) intends to show the split of a few related values over their total. Like how many votes parties have received during an election. You want to see the relative percentage and clearly know who got it. Meaning it has to be different colored by default. Charts always allow to select just one piece. Go to edit mode, select the ring, and click (not double) on one pie - it will be selected individually and you can apply a color to this particular item. What you actually want is some kind of chart style or just a color palette applied to the bars, pies, dots etc. You can do it now via tools > options > charts > default colors, which is admittedly not handy. Regarding this ticket I would resolve as WF. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129143] FILESAVE: PPTX: bullets have a black border after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=129143 Xisco Faulí changed: What|Removed |Added Status|UNCONFIRMED |NEW Keywords||bibisected, bisected, ||regression Ever confirmed|0 |1 Version|6.5.0.0.alpha0+ Master |6.4.0.0.alpha0+ CC||noelgran...@gmail.com, ||xiscofa...@libreoffice.org --- Comment #1 from Xisco Faulí --- Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=126818d293982e578dfb4d977ee0ea64a1cff0de author Noel Grandin 2019-07-08 14:41:34 +0200 committer Noel Grandin 2019-07-08 21:29:19 +0200 commit 126818d293982e578dfb4d977ee0ea64a1cff0de (patch) tree2602b0b176cf6d3e321b8fddbc18d840184454c6 parent 31bd8c4a4a4752dcff12ee35636193f79a6d6137 (diff) no need to use AlphaMask in DrawingML::WriteParagraphNumbering since we're just setting it to fully opaque Bisected with: bibisect-linux64-6.4 Adding Cc: to Noel Grandin -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129143] New: FILESAVE: PPTX: bullets have a black border after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=129143 Bug ID: 129143 Summary: FILESAVE: PPTX: bullets have a black border after RT Product: LibreOffice Version: 6.5.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: xiscofa...@libreoffice.org Created attachment 156238 --> https://bugs.documentfoundation.org/attachment.cgi?id=156238=edit sample file Steps to reproduce: 1. Open the attached document 2. Save it as PPTX 3. Open the new document -> Both bullets have a black border around them Reproduced in Version: 6.5.0.0.alpha0+ Build ID: 47dd2c63f649828a833543e21d4eca5866ec9ebe CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128926] PPS files will not play with OpenGL in Impress 6.2.8 (on some systems)
https://bugs.documentfoundation.org/show_bug.cgi?id=128926 Timur changed: What|Removed |Added Summary|PPS files will not play |PPS files will not play |with Libre Office Impress |with OpenGL in Impress |6.2.8 |6.2.8 (on some systems) CC||xv3...@gmail.com Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #10 from Timur --- I don't reproduce crash in Windows 8.1 with or without OpenGL. But I see flickering on slide change. Test with manual slide advance. Edward, please confirm you don't see crash with your current systems (so we cannot count on you to reproduce). Xavier, you say you reproduced, please set New then. And confirm crash is only with OpenGL. And please write and update your video drivers. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129117] Base 6.3.2.2 - Queries - Create Query in Design View and goes to Document Recovery window.
https://bugs.documentfoundation.org/show_bug.cgi?id=129117 Alex Thurgood changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #2 from Alex Thurgood --- @Ron : - which database engine are you using ? - which connector and driver version (if any) ? - it might help if you could provide us with a sample database where the problem occurs (bearing in mind that everything you post here or as an attachment is public) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129142] problem with my ms office
https://bugs.documentfoundation.org/show_bug.cgi?id=129142 seema bhogal changed: What|Removed |Added URL||https://i-nortonsetup.info/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129142] New: problem with my ms office
https://bugs.documentfoundation.org/show_bug.cgi?id=129142 Bug ID: 129142 Summary: problem with my ms office Product: LibreOffice Version: 3.3.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: seema.bhogal...@gmail.com Description: I think due to some virus my ms office is corrupted. What should I do? I have also used Norton antivirus but it is of no use. Please suggest me some solution. You can see my problem here https://i-nortonsetup.info/ Actual Results: Please see the above link Expected Results: help me out Reproducible: Sometimes User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=120469 Heiko Tietze changed: What|Removed |Added Keywords||difficultyInteresting, ||easyHack, skillCpp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129061] FILEOPEN PPTX: equation not displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=129061 --- Comment #7 from Miklos Vajna --- This bug has an example of a PPTX shape which has both text and math markup, Impress can't handle this. E.g. bug 117658 has an example PPTX shape which has only math markup, so we can map that to Impress math objects. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122562] Allow to convert between measurement units in input fields (percentage to point etc.)
https://bugs.documentfoundation.org/show_bug.cgi?id=122562 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: forms/source
forms/source/runtime/formoperations.cxx | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
New commits:
commit 48a676a1639f9c8aef734c47b457108d1712b79d
Author: Caolán McNamara
AuthorDate: Sun Dec 1 20:11:44 2019 +
Commit: Caolán McNamara
CommitDate: Mon Dec 2 09:53:01 2019 +0100
use weld::WaitObject with an explicit target
Change-Id: I5ef322e4c17a1d643fa39968c92a39cf614ce23f
Reviewed-on: https://gerrit.libreoffice.org/84168
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/forms/source/runtime/formoperations.cxx
b/forms/source/runtime/formoperations.cxx
index 01107afd7e2c..7112a46b118f 100644
--- a/forms/source/runtime/formoperations.cxx
+++ b/forms/source/runtime/formoperations.cxx
@@ -53,7 +53,6 @@
#include
#include
#include
-#include
#include
#include
#include
@@ -607,7 +606,7 @@ namespace frm
case FormFeature::ReloadForm:
if ( m_xLoadableForm.is() )
{
-WaitObject aWO( nullptr );
+weld::WaitObject
aWO(Application::GetFrameWeld(GetDialogParent()));
m_xLoadableForm->reload();
// refresh all controls in the form (and sub forms) which
can be refreshed
@@ -734,7 +733,7 @@ namespace frm
aValues[1] <<= OUString();
aValues[2] <<= OUString();
-WaitObject aWO( nullptr );
+weld::WaitObject
aWO(Application::GetFrameWeld(GetDialogParent()));
xProperties->setPropertyValues( aNames, aValues );
if ( m_xLoadableForm.is() )
@@ -752,7 +751,7 @@ namespace frm
m_xCursorProperties->setPropertyValue(
PROPERTY_APPLYFILTER, makeAny( !bApplied ) );
// and reload
-WaitObject aWO( nullptr );
+weld::WaitObject
aWO(Application::GetFrameWeld(GetDialogParent()));
m_xLoadableForm->reload();
}
break;
@@ -1557,7 +1556,7 @@ namespace frm
impl_appendOrderByColumn_throw aAction(this, xBoundField, _bUp);
impl_doActionInSQLContext_throw(aAction,
RID_STR_COULD_NOT_SET_ORDER );
-WaitObject aWO( nullptr );
+weld::WaitObject aWO(Application::GetFrameWeld(GetDialogParent()));
try
{
m_xCursorProperties->setPropertyValue( PROPERTY_SORT, makeAny(
m_xParser->getOrder() ) );
@@ -1628,7 +1627,7 @@ namespace frm
impl_appendFilterByColumn_throw aAction(this, m_xParser,
xBoundField);
impl_doActionInSQLContext_throw( aAction,
RID_STR_COULD_NOT_SET_FILTER );
-WaitObject aWO( nullptr );
+weld::WaitObject aWO(Application::GetFrameWeld(GetDialogParent()));
try
{
m_xCursorProperties->setPropertyValue( PROPERTY_FILTER,
makeAny( m_xParser->getFilter() ) );
@@ -1715,7 +1714,7 @@ namespace frm
if ( RET_OK == xDialog->execute() )
{
-WaitObject aWO( nullptr );
+weld::WaitObject aWO(Application::GetFrameWeld(xDialogParent));
if ( _bFilter )
{
m_xCursorProperties->setPropertyValue( PROPERTY_FILTER,
makeAny( m_xParser->getFilter() ) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=120469 --- Comment #7 from Mike Kaganski --- (In reply to Heiko Tietze from comment #6) > Thanks for the code pointer. Is it an easyhack? Likely. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - dbaccess/inc dbaccess/source extensions/source forms/source reportdesign/source sc/source sd/inc sd/source sfx2/source svx/source
dbaccess/inc/pch/precompiled_dbu.hxx |8 +--
dbaccess/source/ui/app/AppControllerDnD.cxx |5 --
dbaccess/source/ui/app/AppControllerGen.cxx |5 --
dbaccess/source/ui/app/AppDetailPageHelper.cxx |7 +--
dbaccess/source/ui/app/AppView.cxx |3 -
dbaccess/source/ui/browser/brwctrlr.cxx |3 -
dbaccess/source/ui/browser/genericcontroller.cxx |5 --
dbaccess/source/ui/browser/sbagrid.cxx |1
dbaccess/source/ui/browser/unodatbr.cxx |5 --
dbaccess/source/ui/inc/RelationController.hxx|8 ++-
dbaccess/source/ui/inc/linkeddocuments.hxx |7 +--
dbaccess/source/ui/misc/TableCopyHelper.cxx |1
dbaccess/source/ui/misc/linkeddocuments.cxx | 15 +++
dbaccess/source/ui/querydesign/JoinController.cxx|1
dbaccess/source/ui/relationdesign/RelationController.cxx |5 --
extensions/source/propctrlr/formcomponenthandler.hxx |1
forms/source/runtime/formoperations.cxx | 30 --
forms/source/runtime/formoperations.hxx |3 +
reportdesign/source/ui/dlg/AddField.cxx |1
reportdesign/source/ui/inspection/GeometryHandler.cxx|5 --
reportdesign/source/ui/report/ReportController.cxx |5 --
sc/source/ui/docshell/dbdocfun.cxx |1
sc/source/ui/docshell/docfunc.cxx|1
sc/source/ui/docshell/docsh.cxx |1
sc/source/ui/docshell/docsh4.cxx |1
sc/source/ui/docshell/docsh5.cxx |1
sc/source/ui/undo/undoblk.cxx|1
sc/source/ui/view/preview.cxx|3 -
sd/inc/pch/precompiled_sd.hxx|9 +---
sd/source/ui/dlg/tpaction.cxx|1
sd/source/ui/docshell/docshel4.cxx |5 --
sd/source/ui/func/fucon3d.cxx|5 +-
sd/source/ui/func/fudraw.cxx |3 -
sd/source/ui/view/drviews2.cxx | 31 +++
sd/source/ui/view/drviewse.cxx | 11 ++---
sfx2/source/appl/newhelp.cxx |3 -
sfx2/source/doc/new.cxx |1
svx/source/form/fmshell.cxx |1
svx/source/form/fmshimp.cxx |1
39 files changed, 91 insertions(+), 113 deletions(-)
New commits:
commit 16758bd6533f76e9e72775405ecfc9f38a659155
Author: Caolán McNamara
AuthorDate: Sun Dec 1 20:05:17 2019 +
Commit: Caolán McNamara
CommitDate: Mon Dec 2 09:52:47 2019 +0100
extract to a GetDialogParent method
Change-Id: Ibf7141fa916797d661f12bd60657df47903014f5
Reviewed-on: https://gerrit.libreoffice.org/84167
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/forms/source/runtime/formoperations.cxx
b/forms/source/runtime/formoperations.cxx
index c26a758a2068..01107afd7e2c 100644
--- a/forms/source/runtime/formoperations.cxx
+++ b/forms/source/runtime/formoperations.cxx
@@ -1669,6 +1669,23 @@ namespace frm
}
}
+css::uno::Reference FormOperations::GetDialogParent()
const
+{
+css::uno::Reference xDialogParent;
+
+//tdf#122152 extract parent for dialog
+if (m_xController.is())
+{
+css::uno::Reference
xContainerControl(m_xController->getContainer(), css::uno::UNO_QUERY);
+if (xContainerControl.is())
+{
+css::uno::Reference xContainerPeer =
xContainerControl->getPeer();
+xDialogParent =
css::uno::Reference(xContainerPeer, css::uno::UNO_QUERY);
+}
+}
+
+return xDialogParent;
+}
void FormOperations::impl_executeFilterOrSort_throw( bool _bFilter ) const
{
@@ -1682,18 +1699,7 @@ namespace frm
return;
try
{
-css::uno::Reference xDialogParent;
-
-//tdf#122152 extract parent for dialog
-if (m_xController.is())
-{
-css::uno::Reference
xContainerControl(m_xController->getContainer(), css::uno::UNO_QUERY);
-if (xContainerControl.is())
-{
-css::uno::Reference xContainerPeer
= xContainerControl->getPeer();
-xDialogParent =
css::uno::Reference(xContainerPeer, css::uno::UNO_QUERY);
-}
-}
+css::uno::Reference
xDialogParent(GetDialogParent());
Reference< XExecutableDialog> xDialog;
if ( _bFilter )
diff --git a/forms/source/runtime/formoperations.hxx
[Libreoffice-commits] core.git: 2 commits - solenv/sanitizers svx/inc svx/source
solenv/sanitizers/ui/modules/swriter.suppr |2 -- svx/inc/pch/precompiled_svx.hxx| 10 +++--- svx/inc/pch/precompiled_svxcore.hxx|6 -- svx/source/form/tabwin.cxx |3 --- svx/source/inc/tabwin.hxx |3 --- svx/source/tbxctrls/extrusioncontrols.hxx |1 - 6 files changed, 7 insertions(+), 18 deletions(-) New commits: commit 1d8a32f15b0895dcdd1768fda50dd69cf8fc Author: Caolán McNamara AuthorDate: Sun Dec 1 20:01:16 2019 + Commit: Caolán McNamara CommitDate: Mon Dec 2 09:52:10 2019 +0100 unused suppression Change-Id: Ic4cbdb27c4426475b2a4fc768f12e64e6436b9b6 Reviewed-on: https://gerrit.libreoffice.org/84165 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/solenv/sanitizers/ui/modules/swriter.suppr b/solenv/sanitizers/ui/modules/swriter.suppr index 43134e801be7..d68564e0ccac 100644 --- a/solenv/sanitizers/ui/modules/swriter.suppr +++ b/solenv/sanitizers/ui/modules/swriter.suppr @@ -92,7 +92,6 @@ sw/uiconfig/swriter/ui/indexentry.ui://GtkButton[@id='previous'] button-no-label sw/uiconfig/swriter/ui/indexentry.ui://GtkButton[@id='next'] button-no-label sw/uiconfig/swriter/ui/indexentry.ui://GtkButton[@id='first'] button-no-label sw/uiconfig/swriter/ui/indexentry.ui://GtkButton[@id='last'] button-no-label -sw/uiconfig/swriter/ui/insertbookmark.ui://GtkEntry[@id='name'] no-labelled-by sw/uiconfig/swriter/ui/insertbookmark.ui://GtkLabel[@id='lbForbiddenChars'] orphan-label sw/uiconfig/swriter/ui/insertbreak.ui://GtkSpinButton[@id='pagenumsb'] missing-label-for sw/uiconfig/swriter/ui/insertcaption.ui://GtkEntry[@id='caption_edit'] no-labelled-by @@ -134,7 +133,6 @@ sw/uiconfig/swriter/ui/opttablepage.ui://GtkLabel[@id='label12'] orphan-label sw/uiconfig/swriter/ui/opttablepage.ui://GtkLabel[@id='label13'] orphan-label sw/uiconfig/swriter/ui/opttablepage.ui://GtkLabel[@id='label4'] orphan-label sw/uiconfig/swriter/ui/opttablepage.ui://GtkLabel[@id='label14'] orphan-label -sw/uiconfig/swriter/ui/outlinenumberingpage.ui://GtkLabel[@id='label7'] orphan-label sw/uiconfig/swriter/ui/outlinenumberingpage.ui://GtkDrawingArea[@id='preview'] no-labelled-by sw/uiconfig/swriter/ui/mailmerge.ui://GtkSpinButton[@id='from'] no-labelled-by sw/uiconfig/swriter/ui/mailmerge.ui://GtkLabel[@id='fieldlabel'] orphan-label commit 8b59866c5b6af2e807a5984feccc4bb46e013c2a Author: Caolán McNamara AuthorDate: Sun Dec 1 19:17:23 2019 + Commit: Caolán McNamara CommitDate: Mon Dec 2 09:51:55 2019 +0100 remove some unneeded includes Change-Id: I57e3159b99eadd072dde4871d0ccc37d570cfc05 Reviewed-on: https://gerrit.libreoffice.org/84164 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/svx/inc/pch/precompiled_svx.hxx b/svx/inc/pch/precompiled_svx.hxx index 3a99ad7ed9b3..1655a026af1a 100644 --- a/svx/inc/pch/precompiled_svx.hxx +++ b/svx/inc/pch/precompiled_svx.hxx @@ -13,7 +13,7 @@ manual changes will be rewritten by the next run of update_pch.sh (which presumably also fixes all possible problems, so it's usually better to use it). - Generated on 2019-10-29 12:13:17 using: + Generated on 2019-12-01 19:16:47 using: ./bin/update_pch svx svx --cutoff=3 --exclude:system --exclude:module --include:local If after updating build fails, use the following command to locate conflicting headers: @@ -41,7 +41,7 @@ #include #include #include -#include +#include #include #endif // PCH_LEVEL >= 1 #if PCH_LEVEL >= 2 @@ -60,11 +60,8 @@ #include #include #include -#include #include #include -#include -#include #include #include #include @@ -116,7 +113,6 @@ #include #include #include -#include #include #include #include @@ -238,6 +234,7 @@ #include #include #include +#include #include #include #include @@ -404,7 +401,6 @@ #include #include #include -#include #include #include #include diff --git a/svx/inc/pch/precompiled_svxcore.hxx b/svx/inc/pch/precompiled_svxcore.hxx index a03b6f300169..61a8b1d117ea 100644 --- a/svx/inc/pch/precompiled_svxcore.hxx +++ b/svx/inc/pch/precompiled_svxcore.hxx @@ -13,7 +13,7 @@ manual changes will be rewritten by the next run of update_pch.sh (which presumably also fixes all possible problems, so it's usually better to use it). - Generated on 2019-10-17 16:11:39 using: + Generated on 2019-12-01 19:16:07 using: ./bin/update_pch svx svxcore --cutoff=7 --exclude:system --include:module --exclude:local If after updating build fails, use the following command to locate conflicting headers: @@ -49,7 +49,8 @@ #include #include #include -#include +#include +#include #endif // PCH_LEVEL >= 1 #if PCH_LEVEL >= 2 #include @@ -153,6 +154,7 @@ #include #include #include +#include #endif // PCH_LEVEL >= 2 #if PCH_LEVEL >= 3 #include diff --git
Re: Cannot start LO with --disable-gui build
Hi Alex, On Fri, Nov 29, 2019 at 07:35:36PM +0300, Alex Kom wrote: > I'm trying to build LO 6.1.6 (gcc 4.9 armv7hl) with no GUI. I need LO 6.1 is really old; master is now towards 6.5. Can you try master first? > ./autogen.sh --without-help --without-myspell-dicts --disable-gtk3 > --disable-gtk --disable-gui --disable-kde4 --disable-dbus > --without-doxygen --disable-report-builder --disable-coinmp > --disable-odk --disable-cups --disable-lotuswordpro --without-java > --without-krb5 --disable-scripting-beanshell > --disable-scripting-javascript --disable-sdremote > --disable-postgresql-sdbc --without-fonts --with-parallelism=4 > --with-system-boost --with-system-nss --disable-firebird-sdbc > --with-system-hunspell --with-system-libatomic_ops > --with-system-librevenge --with-system-epoxy --with-system-libmwaw > --with-system-icu --with-system-graphite --with-system-harfbuzz > --with-system-libpng --with-system-cairo --with-galleries=no > --enable-cairo-canvas --with-system-zlib --without-junit This is a lot of options: the more options you use, the more like you hit a problem that nobody else saw before. If you want to use a build for Online purposes, perhaps use --with-distro=LibreOfficeOnline, which includes --disable-gui, and that is an option more people use (and probably works). Regards, Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 129130] Start center: Black border around previews of Base-files
https://bugs.documentfoundation.org/show_bug.cgi?id=129130 Alex Thurgood changed: What|Removed |Added OS|Linux (All) |All -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129130] Start center: Black border around previews of Base-files
https://bugs.documentfoundation.org/show_bug.cgi?id=129130 Alex Thurgood changed: What|Removed |Added Keywords||bibisectRequest, regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129130] Start center: Black border around previews of Base-files
https://bugs.documentfoundation.org/show_bug.cgi?id=129130 Alex Thurgood changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Alex Thurgood --- I can reproduce this with my current master builds too. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129133] Save As does not work in 6.3.3_MacOS_x86-64
https://bugs.documentfoundation.org/show_bug.cgi?id=129133 Alex Thurgood changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||6638 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126638] Save-As behavior on MacOS Catalina
https://bugs.documentfoundation.org/show_bug.cgi?id=126638 Alex Thurgood changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||9133 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128233] Function call to any Finder dialog fails on macOS 10.15 Catalina with parallel LO installations
https://bugs.documentfoundation.org/show_bug.cgi?id=128233 Alex Thurgood changed: What|Removed |Added CC||davist...@gmail.com --- Comment #8 from Alex Thurgood --- *** Bug 129133 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129133] Save As does not work in 6.3.3_MacOS_x86-64
https://bugs.documentfoundation.org/show_bug.cgi?id=129133 Alex Thurgood changed: What|Removed |Added Resolution|WORKSFORME |DUPLICATE --- Comment #7 from Alex Thurgood --- Actually a DUP of bug 128233 The point being that you shouldn't have to separately give LibreOffice full disk access via such trickery. See comment 6 in bug 128233 *** This bug has been marked as a duplicate of bug 128233 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129032] Missing warning when renaming page with same name
https://bugs.documentfoundation.org/show_bug.cgi?id=129032 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #6 from Heiko Tietze --- Disabling the action when requirements are not fulfilled (see bug 62851) is the correct way to go. While this behavior is common (and IMHO easy to grasp), we could show a warning like "Name has been assigned to another slide" (or page). I would rather change Calc to not interrupt the workflow (as done in bug 128521). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 129032] Missing warning when renaming page with same name
https://bugs.documentfoundation.org/show_bug.cgi?id=129032 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #6 from Heiko Tietze --- Disabling the action when requirements are not fulfilled (see bug 62851) is the correct way to go. While this behavior is common (and IMHO easy to grasp), we could show a warning like "Name has been assigned to another slide" (or page). I would rather change Calc to not interrupt the workflow (as done in bug 128521). -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 129136] crash in basic function CurDir
https://bugs.documentfoundation.org/show_bug.cgi?id=129136 --- Comment #3 from Stephan Bergmann --- (In reply to raal from comment #1) > 13567e29b667a3ec5576c3ae367748d8b77e8c3b is the first bad commit > commit 13567e29b667a3ec5576c3ae367748d8b77e8c3b > Author: Norbert Thiebaud > Date: Fri Jun 17 19:49:51 2016 -0700 > > source sha:e30f3bcd25762236eb739584dc71691123527c9f (when reporting a bibisect finding, please always specify the used git repo) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=120469 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org --- Comment #6 from Heiko Tietze --- (In reply to Mike Kaganski from comment #4) > 1. Make only the very first position in the document special... > 2. Make any paragraph's start special... > 3. Introduce an "Insert paragraph above this" special function... Hard to imagine that users can follow the arguments of position 0 vs 1, which is your point here. So #2 sounds good to me. Thanks for the code pointer. Is it an easyhack? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 120469] Object anchored to paragraph doesn't move if an enter is inserted at the beginning of the paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=120469 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda |.freedesktop.org|tion.org --- Comment #6 from Heiko Tietze --- (In reply to Mike Kaganski from comment #4) > 1. Make only the very first position in the document special... > 2. Make any paragraph's start special... > 3. Introduce an "Insert paragraph above this" special function... Hard to imagine that users can follow the arguments of position 0 vs 1, which is your point here. So #2 sounds good to me. Thanks for the code pointer. Is it an easyhack? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127576] Writer (Linux Mint 19 & Win 7/32 in a VM) - NO copy format with paintbrush-symbol for a paragraph (formatting of characters works)
https://bugs.documentfoundation.org/show_bug.cgi?id=127576 Timur changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|UNCONFIRMED |RESOLVED --- Comment #9 from Timur --- Insufficient data for simple test and confirmation. Wolfgang, this is your first bug report and you didn't follow our rules from Comment 5. We are volunteers who triage thousands of bugs and we cannot guess. Should you write exact steps for a single issue - and only then - you may set Unconfirmed. For example, just "format of paragraphs", not clear whether you hold down Ctrl when you click. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129085] From version 6.1.x, some JPG images in Writer not printed
https://bugs.documentfoundation.org/show_bug.cgi?id=129085 --- Comment #9 from Martin Schoenmakers --- (In reply to Dieter Praas from comment #7) > Martin, which printer do you use? Have you checked, that the printer driver > is actual? I use a HP Officejet Pro 276. (I just went from Win7 to Win10, so it has a brand new driver.) But 99% sure this is not relevant: when printing to PDF via "Microsoft print to PDF", then there is the same problem, same as Timur sees in Comment 8. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - external/nss
external/nss/ExternalProject_nss.mk |4 ++-- external/nss/nss-android.patch.1| 19 ++- 2 files changed, 20 insertions(+), 3 deletions(-) New commits: commit 0eb512a8db23347733c97f8f2f8914d8a254b2c2 Author: Jan Holesovsky AuthorDate: Fri Nov 1 10:57:21 2019 +0100 Commit: Jan Holesovsky CommitDate: Mon Dec 2 09:21:56 2019 +0100 android: Fix nss build on aarch64. Change-Id: I51c03e13fba4619a881ade27d149722698859815 Reviewed-on: https://gerrit.libreoffice.org/81886 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/external/nss/ExternalProject_nss.mk b/external/nss/ExternalProject_nss.mk index 2e93d7000c3a..4d175e184da5 100644 --- a/external/nss/ExternalProject_nss.mk +++ b/external/nss/ExternalProject_nss.mk @@ -34,8 +34,8 @@ else # OS!=WNT $(call gb_ExternalProject_get_state_target,nss,build): $(call gb_ExternalExecutable_get_dependencies,python) $(call gb_ExternalProject_run,build,\ $(if $(filter ANDROID FREEBSD LINUX MACOSX,$(OS)),$(if $(filter X86_64,$(CPUNAME)),USE_64=1)) \ - $(if $(filter iOS,$(OS)),\ - $(if $(filter arm64,$(CC)),USE_64=1)) \ + $(if $(filter ANDROID,$(OS)),$(if $(filter AARCH64,$(CPUNAME)),USE_64=1)) \ + $(if $(filter iOS,$(OS)),$(if $(filter ARM64,$(CPUNAME)),USE_64=1)) \ $(if $(filter MACOSX,$(OS)),\ $(if $(filter-out POWERPC,$(CPUNAME)),MACOS_SDK_DIR=$(MACOSX_SDK_PATH)) \ NSS_USE_SYSTEM_SQLITE=1) \ diff --git a/external/nss/nss-android.patch.1 b/external/nss/nss-android.patch.1 index f8b4cdaf3753..4c03dce226f0 100644 --- a/external/nss/nss-android.patch.1 +++ b/external/nss/nss-android.patch.1 @@ -1,11 +1,12 @@ diff -ur nss.org/nspr/build/autoconf/config.sub nss/nspr/build/autoconf/config.sub --- nss.org/nspr/build/autoconf/config.sub 2017-09-07 15:29:45.031246453 +0200 +++ nss/nspr/build/autoconf/config.sub 2017-09-07 15:32:13.087235423 +0200 -@@ -111,6 +111,10 @@ +@@ -111,6 +111,11 @@ exit 1;; esac +if test $1 = "arm-unknown-linux-androideabi"; then echo $1; exit; fi ++if test $1 = "aarch64-unknown-linux-android"; then echo $1; exit; fi +if test $1 = "i686-pc-linux-android"; then echo $1; exit; fi +if test $1 = "x86_64-pc-linux-android"; then echo $1; exit; fi + @@ -48,3 +49,19 @@ diff -ur nss.org/nss/Makefile nss/nss/Makefile --with-android-version=$(OS_TARGET_RELEASE) \ --with-android-toolchain=$(ANDROID_TOOLCHAIN) \ --with-android-platform=$(ANDROID_SYSROOT) +diff -ur nss/nss/coreconf/arch.mk nss/nss/coreconf/arch.mk +--- nss/nss/coreconf/arch.mk 2019-11-01 10:29:44.933245745 +0100 nss/nss/coreconf/arch.mk 2019-11-01 10:32:04.347181076 +0100 +@@ -234,7 +234,11 @@ + # + # this should be configurable from the user + # +- OS_TEST := arm ++ ifeq ($(USE_64),1) ++ OS_TEST := aarch64 ++ else ++ OS_TEST := arm ++ endif +OS_ARCH = Android +ifndef OS_TARGET_RELEASE + OS_TARGET_RELEASE := 8 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 45636] Add support for PDF/UA (PDF/Universal Accessibility) - ISO 14289
https://bugs.documentfoundation.org/show_bug.cgi?id=45636 Miklos Vajna changed: What|Removed |Added CC||qui...@gmail.com --- Comment #11 from Miklos Vajna --- Tomaz (Collabora) recently started some work in this area. I would like to mention that government legislation does not magically create money to write open source code (sadly). We really welcome people who contribute to fixing / improving things, are happy to mentor those who want to get involved; but our resources are limited & there are plenty of important things to improve. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129141] UI: CALC: formula bar showing wrong formula
https://bugs.documentfoundation.org/show_bug.cgi?id=129141 Mike Kaganski changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #4 from Mike Kaganski --- Repro withVersion: 6.5.0.0.alpha0+ (x64) Build ID: b1410efe6d3e7ca217181b18b18407886ffca91e CPU threads: 12; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; Locale: ru-RU (ru_RU); UI-Language: en-US Calc: CL and LibreOffice 3.5.0rc3 Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735 (the release where the multi-line formula bar first appeared). Only reproducible when the difference is on the following lines of the formula box: expanding Calc to full screen on a 1920x1080 display (so the whole formula fits the first line) makes it update correctly. Also interesting that it refreshes itself e.g. when an "update available" notification balloon appears - open an outdated version of LO with the file in the windowed (not expanded) view; expand formula bar; reproduce the problem and let selection stay on a cell with wrong formula displayed; wait for "Update available" notification appears in the top right application corner; see the formula updated. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123206] FILEOPEN DOCX Custom chart labels disappear
https://bugs.documentfoundation.org/show_bug.cgi?id=123206 --- Comment #7 from Commit Notification --- Tamas Bunth committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/60464cb113f558d174e5adaa3c012f3df10519c5 tdf#123206 Import/Export chart custom label text It will be available in 6.4.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123206] FILEOPEN DOCX Custom chart labels disappear
https://bugs.documentfoundation.org/show_bug.cgi?id=123206 Commit Notification changed: What|Removed |Added Whiteboard|target:6.5.0|target:6.5.0 target:6.4.0.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - chart2/qa include/xmloff schema/libreoffice xmloff/source
chart2/qa/extras/chart2export.cxx | 16 +++
chart2/qa/extras/data/docx/tdf123206.docx |binary
include/xmloff/xmltoken.hxx |1
schema/libreoffice/OpenDocument-schema-v1.3+libreoffice.rng |9 +
xmloff/source/chart/SchXMLExport.cxx| 63 ++--
xmloff/source/chart/SchXMLPlotAreaContext.cxx |9 +
xmloff/source/chart/SchXMLSeries2Context.cxx| 15 ++
xmloff/source/chart/transporttypes.hxx |1
xmloff/source/core/xmltoken.cxx |1
xmloff/source/token/tokens.txt |1
10 files changed, 107 insertions(+), 9 deletions(-)
New commits:
commit 60464cb113f558d174e5adaa3c012f3df10519c5
Author: Tamas Bunth
AuthorDate: Thu Oct 3 19:49:57 2019 +0200
Commit: Xisco Faulí
CommitDate: Mon Dec 2 09:15:44 2019 +0100
tdf#123206 Import/Export chart custom label text
OOX import supports custom label texts in chart diagrams (produced by
e.g. double clicking on a data label, and write custom text), but -
since embedded objects are exported and imported to odf right after
migration -
it is not displayed in case of a Writer document.
In order to make it work, we have to support custom label text in the
odf structure. This commit only allows the import/export of pure text,
it should be improved to store and load formatted string.
A new XML token is added, which currently refers to an attribute of the
chart:data-point tag. If we want to store formatted string, something
more clever has to be done.
Change-Id: I80c4a3a0dbcf59f1dc732d795fb716da318411cb
Reviewed-on: https://gerrit.libreoffice.org/80156
Tested-by: Jenkins
Reviewed-by: Tamás Bunth
Signed-off-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/84076
diff --git a/chart2/qa/extras/chart2export.cxx
b/chart2/qa/extras/chart2export.cxx
index 8d42c8ac93ac..1645c1c1d1ae 100644
--- a/chart2/qa/extras/chart2export.cxx
+++ b/chart2/qa/extras/chart2export.cxx
@@ -149,6 +149,7 @@ public:
void testTdf121744();
void testTdf122031();
void testTdf115012();
+void testTdf123206_customLabelText();
CPPUNIT_TEST_SUITE(Chart2ExportTest);
CPPUNIT_TEST(testErrorBarXLSX);
@@ -261,6 +262,8 @@ public:
CPPUNIT_TEST(testTdf121744);
CPPUNIT_TEST(testTdf122031);
CPPUNIT_TEST(testTdf115012);
+CPPUNIT_TEST(testTdf123206_customLabelText);
+
CPPUNIT_TEST_SUITE_END();
protected:
@@ -2386,6 +2389,19 @@ void Chart2ExportTest::testTdf115012()
assertXPath(pXmlDoc, "/c:chartSpace/c:chart/c:dispBlanksAs", "val",
"zero");
}
+void Chart2ExportTest::testTdf123206_customLabelText()
+{
+load("/chart2/qa/extras/data/docx/", "tdf123206.docx");
+
+Reference xChartDoc(getChartDocFromWriter(0),
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xChartDoc.is());
+
+xmlDocPtr pXmlDoc = parseExport("word/charts/chart","Office Open XML
Text");
+CPPUNIT_ASSERT(pXmlDoc);
+
+assertXPathContent(pXmlDoc,
"/c:chartSpace/c:chart/c:plotArea/c:pieChart/c:ser/c:dLbls/c:dLbl[2]/c:tx/c:rich/a:p/a:r/a:t",
"kiscica");
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(Chart2ExportTest);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/chart2/qa/extras/data/docx/tdf123206.docx
b/chart2/qa/extras/data/docx/tdf123206.docx
new file mode 100755
index ..f47089fe3b1b
Binary files /dev/null and b/chart2/qa/extras/data/docx/tdf123206.docx differ
diff --git a/include/xmloff/xmltoken.hxx b/include/xmloff/xmltoken.hxx
index 751cd423556d..4418f9ba54a0 100644
--- a/include/xmloff/xmltoken.hxx
+++ b/include/xmloff/xmltoken.hxx
@@ -536,6 +536,7 @@ namespace xmloff { namespace token {
XML_CUSTOM_ICONSET,
XML_CUSTOM_ICONSET_INDEX,
XML_CUSTOM_ICONSET_NAME,
+XML_CUSTOM_LABEL_FIELD,
XML_CUT,
XML_CUT_OFFS,
XML_CX,
diff --git a/schema/libreoffice/OpenDocument-schema-v1.3+libreoffice.rng
b/schema/libreoffice/OpenDocument-schema-v1.3+libreoffice.rng
index 47c1ef790dbd..85cbe5debacb 100644
--- a/schema/libreoffice/OpenDocument-schema-v1.3+libreoffice.rng
+++ b/schema/libreoffice/OpenDocument-schema-v1.3+libreoffice.rng
@@ -2394,4 +2394,13 @@
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.
+
+
+
+
+
+
+
+
+
diff --git a/xmloff/source/chart/SchXMLExport.cxx
b/xmloff/source/chart/SchXMLExport.cxx
index d94732c7e4b0..4dd2bc43b6c8 100644
--- a/xmloff/source/chart/SchXMLExport.cxx
+++ b/xmloff/source/chart/SchXMLExport.cxx
@@ -81,6 +81,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -109,6 +110,19 @@ using ::com::sun::star::uno::Reference;
using ::com::sun::star::uno::Any;
using ::std::vector;
+
+namespace
+{
+struct SchXMLDataPointStruct
+{
+OUString
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - connectivity/source
connectivity/source/drivers/mysqlc/mysqlc_preparedstatement.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit c7832ada6cf7264602064da9a957c03f89732f34
Author: Julien Nabet
AuthorDate: Tue Nov 26 23:37:23 2019 +0100
Commit: Xisco Faulí
CommitDate: Mon Dec 2 09:14:43 2019 +0100
In the same way as 97ad402d58b52a1f2636905137c21298531c2935
OPreparedStatement::setDate works but let's use good habits.
Change-Id: Ic410910ea138cc23d7f33bccd96812efd041732c
Reviewed-on: https://gerrit.libreoffice.org/83842
Tested-by: Jenkins
Reviewed-by: Julien Nabet
(cherry picked from commit 4895e01dee323d97d5573a6a2ff4696c3e7bcd25)
Reviewed-on: https://gerrit.libreoffice.org/84134
Reviewed-by: Xisco Faulí
diff --git a/connectivity/source/drivers/mysqlc/mysqlc_preparedstatement.cxx
b/connectivity/source/drivers/mysqlc/mysqlc_preparedstatement.cxx
index 7cdd19667f30..68911564e1ec 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_preparedstatement.cxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_preparedstatement.cxx
@@ -249,7 +249,7 @@ void SAL_CALL OPreparedStatement::setDate(sal_Int32
parameter, const Date& aData
checkDisposed(OPreparedStatement::rBHelper.bDisposed);
checkParameterIndex(parameter);
-MYSQL_TIME my_time;
+MYSQL_TIME my_time = {};
my_time.year = aData.Year;
my_time.month = aData.Month;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: android/Bootstrap
android/Bootstrap/Makefile.shared |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit c6dadf5035c8e1c31dbd3fccec167bd4a906bf54 Author: Jan Holesovsky AuthorDate: Fri Nov 1 17:57:17 2019 +0100 Commit: Jan Holesovsky CommitDate: Mon Dec 2 09:14:37 2019 +0100 android: Fix linking of liblo-native-code.so on aarch64. Forces gold as the linker; but according to the switches that were used, I suppose gold was used previously anyway, so hopefully not really a problem. Change-Id: I7bc54abf0d3b4b3d86d53e4ea6f01146cf196216 Reviewed-on: https://gerrit.libreoffice.org/81905 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky (cherry picked from commit fa145a035fbab652ec8f3ee870e44e43dd1d770a) Reviewed-on: https://gerrit.libreoffice.org/81915 diff --git a/android/Bootstrap/Makefile.shared b/android/Bootstrap/Makefile.shared index 7126e9a2f506..00ad02285cf1 100644 --- a/android/Bootstrap/Makefile.shared +++ b/android/Bootstrap/Makefile.shared @@ -51,7 +51,7 @@ NSSLIBS = freebl3 \ WHOLELIBS = \ -Wl,--whole-archive \ $(addprefix -l,$(strip \ - juh \ + $(if $(ENABLE_JAVA),juh) \ )) \ -Wl,--no-whole-archive @@ -59,7 +59,7 @@ WHOLELIBS = \ $(OBJLOCAL)/liblo-native-code.so : native-code.cxx $(ALL_STATIC_LIBS) @echo "Linking $@" mkdir -p $(OBJLOCAL) - $(CXX) -Wl,--build-id=sha1 -Wl,--gc-sections -Wl,--version-script=../Bootstrap/version.map -Wl,--no-keep-files-mapped -Wl,--no-undefined -DANDROID -DDISABLE_DYNLOADING -shared -Wl,-soname,liblo-native-code.so -o $(OBJLOCAL)/liblo-native-code.so -I$(BUILDDIR)/config_host -I$(SRCDIR)/include native-code.cxx -L$(INSTDIR)/$(LIBO_LIB_FOLDER) $(WHOLELIBS) $(LIBS) -lc++_static -lc++abi -landroid_support $(if $(filter armeabi-v7a,$(ANDROID_APP_ABI)),-lunwind) $(addprefix -l,$(NSSLIBS)) -lGLESv2 -landroid -ljnigraphics -llog -lz + $(CXX) -fuse-ld=gold -Wl,--build-id=sha1 -Wl,--gc-sections -Wl,--version-script=../Bootstrap/version.map -Wl,--no-keep-files-mapped -Wl,--no-undefined -DANDROID -DDISABLE_DYNLOADING -shared -Wl,-soname,liblo-native-code.so -o $(OBJLOCAL)/liblo-native-code.so -I$(BUILDDIR)/config_host -I$(SRCDIR)/include native-code.cxx -L$(INSTDIR)/$(LIBO_LIB_FOLDER) $(WHOLELIBS) $(LIBS) -lc++_static -lc++abi $(if $(filter-out arm64-v8a,$(ANDROID_APP_ABI)),-landroid_support) $(if $(filter armeabi-v7a,$(ANDROID_APP_ABI)),-lunwind) $(addprefix -l,$(NSSLIBS)) -lGLESv2 -landroid -ljnigraphics -llog -lz $(SODEST)/liblo-native-code.so : $(OBJLOCAL)/liblo-native-code.so mkdir -p $(SODEST) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - android/Bootstrap
android/Bootstrap/Makefile.shared |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit fa145a035fbab652ec8f3ee870e44e43dd1d770a Author: Jan Holesovsky AuthorDate: Fri Nov 1 17:57:17 2019 +0100 Commit: Jan Holesovsky CommitDate: Mon Dec 2 09:13:17 2019 +0100 android: Fix linking of liblo-native-code.so on aarch64. Forces gold as the linker; but according to the switches that were used, I suppose gold was used previously anyway, so hopefully not really a problem. Change-Id: I7bc54abf0d3b4b3d86d53e4ea6f01146cf196216 Reviewed-on: https://gerrit.libreoffice.org/81905 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/android/Bootstrap/Makefile.shared b/android/Bootstrap/Makefile.shared index 942f5f8179ee..8c6270226fe9 100644 --- a/android/Bootstrap/Makefile.shared +++ b/android/Bootstrap/Makefile.shared @@ -51,7 +51,7 @@ NSSLIBS = freebl3 \ WHOLELIBS = \ -Wl,--whole-archive \ $(addprefix -l,$(strip \ - juh \ + $(if $(ENABLE_JAVA),juh) \ )) \ -Wl,--no-whole-archive @@ -59,7 +59,7 @@ WHOLELIBS = \ $(OBJLOCAL)/liblo-native-code.so : native-code.cxx $(ALL_STATIC_LIBS) @echo "Linking $@" mkdir -p $(OBJLOCAL) - $(CXX) -Wl,--build-id=sha1 -Wl,--gc-sections -Wl,--version-script=../Bootstrap/version.map -Wl,--no-keep-files-mapped -Wl,--no-undefined -DANDROID -DDISABLE_DYNLOADING -shared -Wl,-soname,liblo-native-code.so -o $(OBJLOCAL)/liblo-native-code.so -I$(BUILDDIR)/config_host -I$(SRCDIR)/include native-code.cxx -L$(INSTDIR)/$(LIBO_LIB_FOLDER) $(WHOLELIBS) $(LIBS) -lc++_static -lc++abi -landroid_support $(if $(filter armeabi-v7a,$(ANDROID_APP_ABI)),-lunwind) $(addprefix -l,$(NSSLIBS)) -lGLESv2 -landroid -ljnigraphics -llog -lz + $(CXX) -fuse-ld=gold -Wl,--build-id=sha1 -Wl,--gc-sections -Wl,--version-script=../Bootstrap/version.map -Wl,--no-keep-files-mapped -Wl,--no-undefined -DANDROID -DDISABLE_DYNLOADING -shared -Wl,-soname,liblo-native-code.so -o $(OBJLOCAL)/liblo-native-code.so -I$(BUILDDIR)/config_host -I$(SRCDIR)/include native-code.cxx -L$(INSTDIR)/$(LIBO_LIB_FOLDER) $(WHOLELIBS) $(LIBS) -lc++_static -lc++abi $(if $(filter-out arm64-v8a,$(ANDROID_APP_ABI)),-landroid_support) $(if $(filter armeabi-v7a,$(ANDROID_APP_ABI)),-lunwind) $(addprefix -l,$(NSSLIBS)) -lGLESv2 -landroid -ljnigraphics -llog -lz $(SODEST)/liblo-native-code.so : $(OBJLOCAL)/liblo-native-code.so mkdir -p $(SODEST) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128785] UI: Wrong message text when deleting used style
https://bugs.documentfoundation.org/show_bug.cgi?id=128785 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Heiko Tietze --- STR_DELETE_STYLE_USED is used across all modules. We could a) parametrize the call (haven't seen this in the sources yet) or b) rephrase like "If you delete these styles, text/formatting will revert to the parent style...". And c) just accept the minor awkwardness. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 128785] UI: Wrong message text when deleting used style
https://bugs.documentfoundation.org/show_bug.cgi?id=128785 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Heiko Tietze --- STR_DELETE_STYLE_USED is used across all modules. We could a) parametrize the call (haven't seen this in the sources yet) or b) rephrase like "If you delete these styles, text/formatting will revert to the parent style...". And c) just accept the minor awkwardness. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] online.git: test/httpwstest.cpp test/Makefile.am test/UnitCursor.cpp
test/Makefile.am|4
test/UnitCursor.cpp | 410
test/httpwstest.cpp | 326 -
3 files changed, 414 insertions(+), 326 deletions(-)
New commits:
commit fe04d685dbed3048c74a7ffdc0cb84d6e6824162
Author: Miklos Vajna
AuthorDate: Mon Dec 2 09:11:32 2019 +0100
Commit: Miklos Vajna
CommitDate: Mon Dec 2 09:11:39 2019 +0100
Convert cursor tests to a new-style one
So that they are in-process, which means it's easier to debug when they
fail.
Change-Id: I0fb1e798875c479e0aeb5f709ef630def5349126
diff --git a/test/Makefile.am b/test/Makefile.am
index 48da1f182..61fd8a142 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -32,6 +32,7 @@ noinst_LTLIBRARIES = \
unit-session.la \
unit-uno-command.la \
unit-load.la \
+ unit-cursor.la \
unit-wopi-loadencoded.la unit-wopi-temp.la
MAGIC_TO_FORCE_SHLIB_CREATION = -rpath /dummy
@@ -155,6 +156,8 @@ unit_uno_command_la_SOURCES = UnitUNOCommand.cpp
unit_uno_command_la_LIBADD = $(CPPUNIT_LIBS)
unit_load_la_SOURCES = UnitLoad.cpp
unit_load_la_LIBADD = $(CPPUNIT_LIBS)
+unit_cursor_la_SOURCES = UnitCursor.cpp
+unit_cursor_la_LIBADD = $(CPPUNIT_LIBS)
if HAVE_LO_PATH
SYSTEM_STAMP = @SYSTEMPLATE_PATH@/system_stamp
@@ -185,6 +188,7 @@ TESTS = unit-copy-paste.la unit-typing.la unit-convert.la
unit-prefork.la unit-t
unit-session.la \
unit-uno-command.la \
unit-load.la \
+ unit-cursor.la \
unit-wopi-loadencoded.la unit-wopi-temp.la
# TESTS = unit-client.la
# TESTS += unit-admin.la
diff --git a/test/UnitCursor.cpp b/test/UnitCursor.cpp
new file mode 100644
index 0..a70ef749e
--- /dev/null
+++ b/test/UnitCursor.cpp
@@ -0,0 +1,410 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4;
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+#include
+#include
+#include
+
+#include
+#include
+#include
+#include
+
+#include
+#include
+
+class LOOLWebSocket;
+
+namespace
+{
+void getCursor(const std::string& message, int& cursorX, int& cursorY, int&
cursorWidth,
+ int& cursorHeight)
+{
+Poco::JSON::Parser parser;
+const Poco::Dynamic::Var result = parser.parse(message);
+const auto& command = result.extract();
+std::string text = command->get("commandName").toString();
+CPPUNIT_ASSERT_EQUAL(std::string(".uno:CellCursor"), text);
+text = command->get("commandValues").toString();
+CPPUNIT_ASSERT(!text.empty());
+std::vector position(LOOLProtocol::tokenize(text, ','));
+cursorX = std::stoi(position[0]);
+cursorY = std::stoi(position[1]);
+cursorWidth = std::stoi(position[2]);
+cursorHeight = std::stoi(position[3]);
+CPPUNIT_ASSERT(cursorX >= 0);
+CPPUNIT_ASSERT(cursorY >= 0);
+CPPUNIT_ASSERT(cursorWidth >= 0);
+CPPUNIT_ASSERT(cursorHeight >= 0);
+}
+
+void limitCursor(const std::function& socket, int cursorX,
+ int cursorY, int cursorWidth, int
cursorHeight,
+ int docWidth, int docHeight)>&
keyhandler,
+ const std::function& checkhandler,
+ const std::string& testname)
+{
+int docSheet = -1;
+int docSheets = 0;
+int docHeight = 0;
+int docWidth = 0;
+int docViewId = -1;
+int newSheet = -1;
+int newSheets = 0;
+int newHeight = 0;
+int newWidth = 0;
+int cursorX = 0;
+int cursorY = 0;
+int cursorWidth = 0;
+int cursorHeight = 0;
+
+std::string response;
+
+Poco::URI uri(helpers::getTestServerURI());
+std::shared_ptr socket
+= helpers::loadDocAndGetSocket("empty.ods", uri, testname);
+
+// check document size
+helpers::sendTextFrame(socket, "status", testname);
+response = helpers::assertResponseString(socket, "status:", testname);
+helpers::parseDocSize(response.substr(7), "spreadsheet", docSheet,
docSheets, docWidth,
+ docHeight, docViewId);
+
+// Send an arrow key to initialize the CellCursor, otherwise we get
"EMPTY".
+helpers::sendTextFrame(socket, "key type=input char=0 key=1027", testname);
+
+std::string text;
+Poco::format(text,
+ "commandvalues "
+
"command=.uno:CellCursor?outputHeight=%d=%d=%d=%"
+ "d",
+ 256, 256, 3840, 3840);
+helpers::sendTextFrame(socket, text, testname);
+const auto cursor = helpers::getResponseString(socket, "commandvalues:",
testname);
+getCursor(cursor.substr(14), cursorX, cursorY, cursorWidth, cursorHeight);
+
+// move cursor
+keyhandler(socket,
[Libreoffice-commits] core.git: external/libpng
external/libpng/StaticLibrary_libpng.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9feea0f5816a2f8a6a6cd484a83645d854e7477e Author: Jan Holesovsky AuthorDate: Fri Nov 1 17:56:01 2019 +0100 Commit: Jan Holesovsky CommitDate: Mon Dec 2 09:09:38 2019 +0100 android: Add also aarch64 to avoid linking errors. Change-Id: Ifdd696dc37de541bc722807054cd4ba7b862c175 Reviewed-on: https://gerrit.libreoffice.org/81904 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky (cherry picked from commit 620f39b816e3f10a4e047bb4f5ed5f4fdad2b364) Reviewed-on: https://gerrit.libreoffice.org/81914 diff --git a/external/libpng/StaticLibrary_libpng.mk b/external/libpng/StaticLibrary_libpng.mk index cb8428ec4dae..fe2364141b3b 100644 --- a/external/libpng/StaticLibrary_libpng.mk +++ b/external/libpng/StaticLibrary_libpng.mk @@ -33,7 +33,7 @@ $(eval $(call gb_StaticLibrary_add_generated_cobjects,libpng,\ UnpackedTarball/libpng/pngwrite \ UnpackedTarball/libpng/pngwtran \ UnpackedTarball/libpng/pngwutil \ - $(if $(filter ARM ARM64,$(CPUNAME)),\ + $(if $(filter ARM AARCH64 ARM64,$(CPUNAME)),\ UnpackedTarball/libpng/arm/arm_init \ UnpackedTarball/libpng/arm/filter_neon_intrinsics \ UnpackedTarball/libpng/arm/palette_neon_intrinsics \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129081] TABBED TOOLBAR: Wrong German Translation of "Review" tab
https://bugs.documentfoundation.org/show_bug.cgi?id=129081 --- Comment #5 from andreas_k --- I'm for Überprüfen -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - external/libpng
external/libpng/StaticLibrary_libpng.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 620f39b816e3f10a4e047bb4f5ed5f4fdad2b364 Author: Jan Holesovsky AuthorDate: Fri Nov 1 17:56:01 2019 +0100 Commit: Jan Holesovsky CommitDate: Mon Dec 2 09:08:30 2019 +0100 android: Add also aarch64 to avoid linking errors. Change-Id: Ifdd696dc37de541bc722807054cd4ba7b862c175 Reviewed-on: https://gerrit.libreoffice.org/81904 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/external/libpng/StaticLibrary_libpng.mk b/external/libpng/StaticLibrary_libpng.mk index f43a462c7935..0fb2a6b2a7df 100644 --- a/external/libpng/StaticLibrary_libpng.mk +++ b/external/libpng/StaticLibrary_libpng.mk @@ -33,7 +33,7 @@ $(eval $(call gb_StaticLibrary_add_generated_cobjects,libpng,\ UnpackedTarball/libpng/pngwrite \ UnpackedTarball/libpng/pngwtran \ UnpackedTarball/libpng/pngwutil \ - $(if $(filter ARM ARM64,$(CPUNAME)),\ + $(if $(filter ARM AARCH64 ARM64,$(CPUNAME)),\ UnpackedTarball/libpng/arm/arm_init \ UnpackedTarball/libpng/arm/filter_neon_intrinsics \ UnpackedTarball/libpng/arm/palette_neon_intrinsics \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129085] From version 6.1.x, some JPG images in Writer not printed
https://bugs.documentfoundation.org/show_bug.cgi?id=129085 Timur changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Summary|From version 6.2.8, images |From version 6.1.x, some |in Writer not printed |JPG images in Writer not ||printed Keywords||bibisectRequest, regression Version|6.2.8.2 release |6.1.6.3 release --- Comment #8 from Timur --- Reproduced in Windows, LO 6.1.6, 6.2.8 and 6.5+ with Print to PDF. No repro for me in 6.0 and for reporter in 6.1.1 so regression. Looks like some backport to 6.1 went awry. Print Preview and preview in Print are fine in 6.5+ (but preview in Print is wrong in 6.1.6). Export to PDF is also fine. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sal/android
sal/android/libreofficekit-jni.c |1 +
1 file changed, 1 insertion(+)
New commits:
commit e713b0fdd93d818d91cc89110d9905aceb50097f
Author: Jan Holesovsky
AuthorDate: Wed Nov 27 15:29:31 2019 +0100
Commit: Jan Holesovsky
CommitDate: Mon Dec 2 09:05:55 2019 +0100
android: Fix a missing return value.
Change-Id: I19199ebcda243783b750f40fa947894132e497d0
Reviewed-on: https://gerrit.libreoffice.org/83921
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Jan Holesovsky
diff --git a/sal/android/libreofficekit-jni.c b/sal/android/libreofficekit-jni.c
index 8eb106e69710..93742833168b 100644
--- a/sal/android/libreofficekit-jni.c
+++ b/sal/android/libreofficekit-jni.c
@@ -149,6 +149,7 @@ jboolean libreofficekit_initialize(JNIEnv* env,
}
LOGI("LibreOfficeKit: libreofficekit_initialize finished");
+return JNI_TRUE;
}
/// Initialize the LibreOfficeKit.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - configure.ac
configure.ac |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
New commits:
commit 94eb59078731b2e4093d983bc618d051f4e31740
Author: Jan Holesovsky
AuthorDate: Wed Nov 27 15:29:50 2019 +0100
Commit: Jan Holesovsky
CommitDate: Mon Dec 2 09:04:47 2019 +0100
android: Fix location of the built freetype library.
Otherwise it is not found when the the fontconfig's ./configure is
running, which leads to linking failure during the fontconfig's
./configure time, which leads to an undefined HAVE_FT_GET_NEXT_CHAR
which leads to not using the actual FT_Get_Next_Char, but instead some
dummy code that leads to an infinite loop on the app startup; huh.
Change-Id: I40b7a403fbe75582bb98f15f1afe7a4050fd13aa
Reviewed-on: https://gerrit.libreoffice.org/83922
Reviewed-by: Jan Holesovsky
Tested-by: Jan Holesovsky
diff --git a/configure.ac b/configure.ac
index 1d848685cfef..7f86fa5b321a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -8108,7 +8108,11 @@ if test "$test_freetype" = "yes"; then
SYSTEM_FREETYPE=TRUE
else
FREETYPE_CFLAGS="${ISYSTEM}${WORKDIR}/UnpackedTarball/freetype/include"
-FREETYPE_LIBS="-L${WORKDIR}/UnpackedTarball/freetype/instdir/lib
-lfreetype"
+if test "x$ac_config_site_64bit_host" = xYES; then
+FREETYPE_LIBS="-L${WORKDIR}/UnpackedTarball/freetype/instdir/lib64
-lfreetype"
+else
+FREETYPE_LIBS="-L${WORKDIR}/UnpackedTarball/freetype/instdir/lib
-lfreetype"
+fi
fi
AC_SUBST(FREETYPE_CFLAGS)
AC_SUBST(FREETYPE_LIBS)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129081] TABBED TOOLBAR: Wrong German Translation of "Review" tab
https://bugs.documentfoundation.org/show_bug.cgi?id=129081 Heiko Tietze changed: What|Removed |Added CC||kain...@gmail.com Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from Heiko Tietze --- MSO calls the ribbon tab "Überprüfen". Adding also Andreas to the crowd. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sal/android
sal/android/libreofficekit-jni.c |3 +++
1 file changed, 3 insertions(+)
New commits:
commit f3af7708e3535d3171832aa2308d1e7f6193def4
Author: Jan Holesovsky
AuthorDate: Wed Nov 27 15:28:59 2019 +0100
Commit: Jan Holesovsky
CommitDate: Mon Dec 2 09:02:32 2019 +0100
android: Hint how to enable fontconfig logging.
Change-Id: I8901780fa29c6d27bb53e44b07d95259b5bd02df
Reviewed-on: https://gerrit.libreoffice.org/83920
Reviewed-by: Jan Holesovsky
Tested-by: Jan Holesovsky
diff --git a/sal/android/libreofficekit-jni.c b/sal/android/libreofficekit-jni.c
index 9f96d30d7ae0..8eb106e69710 100644
--- a/sal/android/libreofficekit-jni.c
+++ b/sal/android/libreofficekit-jni.c
@@ -104,6 +104,9 @@ jboolean libreofficekit_initialize(JNIEnv* env,
close(fd);
LOGI("Setting FONTCONFIG_FILE to %s", fontsConfPath);
setenv("FONTCONFIG_FILE", fontsConfPath, 1);
+// DEBUG:
+//setenv("FC_DEBUG", "8191", 1); // log everything
+//Java_org_libreoffice_android_Bootstrap_redirect_1stdio(NULL, NULL,
JNI_TRUE);
}
free(fontsConfPath);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129031] distorted lines
https://bugs.documentfoundation.org/show_bug.cgi?id=129031 --- Comment #6 from Jochen --- Even with version 6.3 and 6.4 Alpha of LibreOffice (safe mode, resetting the user profile), the problem arises with the distorted lines. Only if I start Windwos in safe mode, everything is okay. However, I'm handicapped in this mode (no internet, no printing possible). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128960] Editing: Add a more direct way to clear character styles
https://bugs.documentfoundation.org/show_bug.cgi?id=128960 --- Comment #22 from Heiko Tietze --- (In reply to Mike Kaganski from comment #21) > (In reply to Heiko Tietze from comment #20) > > (Shift|Ctrl)+Click - as usual for multi-selection in list? (But no, that's > bad, since simple click on the list then would reset all currently selected > styles => bad) Yes, it's a common interaction, eg. in file browsers. > Checkboxes to emphasize multiselection idea? That's one option. The other (simple) solution is to only accept click on item. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
