[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/finalclasses.cxx |2 +-
compilerplugins/clang/mergeclasses.cxx |2 +-
compilerplugins/clang/methodcycles.cxx |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit c99107f6700287fda2be3c7321613cd68b7c404c
Author: Stephan Bergmann
AuthorDate: Wed Jan 15 23:12:25 2020 +0100
Commit: Stephan Bergmann
CommitDate: Thu Jan 16 08:54:07 2020 +0100
-Werror,-Wrange-loop-analysis
> compilerplugins/clang/finalclasses.cxx:56:57: error: loop variable 's'
has type 'const std::pair &' (aka 'const
pair, basic_string > &') but is initialized with type
'std::pair,
std::__cxx11::basic_string >' resulting in a copy
[-Werror,-Wrange-loop-analysis]
> for (const std::pair & s : definitionMap)
> ^
> compilerplugins/clang/finalclasses.cxx:56:14: note: use non-reference
type 'std::pair' (aka 'pair,
basic_string >') to keep the copy or type 'const std::pair, std::__cxx11::basic_string > &' to
prevent copying
> for (const std::pair & s : definitionMap)
> ^~
etc.
Change-Id: If3f0599ef79d49e4bb4bbd245ca7456c09d13975
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86893
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/compilerplugins/clang/finalclasses.cxx
b/compilerplugins/clang/finalclasses.cxx
index 10948790697f..d906c586d1a0 100644
--- a/compilerplugins/clang/finalclasses.cxx
+++ b/compilerplugins/clang/finalclasses.cxx
@@ -53,7 +53,7 @@ public:
std::string output;
for (const std::string & s : inheritedFromSet)
output += "inherited-from:\t" + s + "\n";
-for (const std::pair & s : definitionMap)
+for (const auto & s : definitionMap)
output += "definition:\t" + s.first + "\t" + s.second + "\n";
std::ofstream myfile;
myfile.open( WORKDIR "/loplugin.finalclasses.log", std::ios::app |
std::ios::out);
diff --git a/compilerplugins/clang/mergeclasses.cxx
b/compilerplugins/clang/mergeclasses.cxx
index b3a167ff143e..c7f9a6094a14 100644
--- a/compilerplugins/clang/mergeclasses.cxx
+++ b/compilerplugins/clang/mergeclasses.cxx
@@ -64,7 +64,7 @@ public:
output += "instantiated:\t" + s + "\n";
for (const std::pair & s :
childToParentClassSet)
output += "has-subclass:\t" + s.first + "\t" + s.second + "\n";
-for (const std::pair & s : definitionMap)
+for (const auto & s : definitionMap)
output += "definition:\t" + s.first + "\t" + s.second + "\n";
std::ofstream myfile;
myfile.open( WORKDIR "/loplugin.mergeclasses.log", std::ios::app |
std::ios::out);
diff --git a/compilerplugins/clang/methodcycles.cxx
b/compilerplugins/clang/methodcycles.cxx
index 42e15c91024a..7fd74b10d9ea 100644
--- a/compilerplugins/clang/methodcycles.cxx
+++ b/compilerplugins/clang/methodcycles.cxx
@@ -80,7 +80,7 @@ public:
for (const MyFuncInfo& s : definitionSet)
output += "definition:\t" + s.returnType + "\t" + s.nameAndParams
+ "\t"
+ s.sourceLocation + "\n";
-for (const std::pair& pair :
callMap)
+for (const auto& pair : callMap)
{
if (!isLocationMine(pair.first->getLocation())
|| !isLocationMine(pair.second->getLocation()))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 130021] "File-Edit-View-Insert etc" toolbar crash
https://bugs.documentfoundation.org/show_bug.cgi?id=130021 --- Comment #1 from otsia...@gmail.com --- Update: I reproduced the crash by directly moving the cursor from another programme (Document Viewer) to the toolbar without first clicking on LibreOffice interface. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129031] distorted lines
https://bugs.documentfoundation.org/show_bug.cgi?id=129031 Jochen changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #14 from Jochen --- I still miss feedback from you about the bug "distorted lines" (sea the message from 2019-12-17) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/swg/SwXMLBlockImport.cxx | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
New commits:
commit 6b0d5a2aa98f6e201820080eed88f329f6b40cef
Author: Noel Grandin
AuthorDate: Thu Jan 16 08:16:34 2020 +0200
Commit: Noel Grandin
CommitDate: Thu Jan 16 08:25:04 2020 +0100
fix use of FastParser in SwXMLTextBlockImport
need to override startFastElement or SvXMLImport will fall back to
trying the non-fastparser stuff
Change-Id: Ia38e62d529391e490807d77dd265c69beb2d8476
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86901
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/core/swg/SwXMLBlockImport.cxx
b/sw/source/core/swg/SwXMLBlockImport.cxx
index ceda8003a152..ab5519e27bf4 100644
--- a/sw/source/core/swg/SwXMLBlockImport.cxx
+++ b/sw/source/core/swg/SwXMLBlockImport.cxx
@@ -54,6 +54,9 @@ public:
SwXMLBlockListContext( SwXMLBlockListImport& rImport,
const css::uno::Reference< css::xml::sax::XFastAttributeList > &
xAttrList );
+virtual void SAL_CALL startFastElement( sal_Int32 /*nElement*/,
+const css::uno::Reference< css::xml::sax::XFastAttributeList
>& ) override {}
+
virtual css::uno::Reference< css::xml::sax::XFastContextHandler > SAL_CALL
createFastChildContext(
sal_Int32 Element, const css::uno::Reference<
css::xml::sax::XFastAttributeList > & xAttrList ) override;
};
@@ -63,6 +66,8 @@ class SwXMLBlockContext : public SvXMLImportContext
public:
SwXMLBlockContext( SwXMLBlockListImport& rImport,
const css::uno::Reference< css::xml::sax::XFastAttributeList > &
xAttrList );
+virtual void SAL_CALL startFastElement( sal_Int32 /*nElement*/,
+const css::uno::Reference< css::xml::sax::XFastAttributeList
>& ) override {}
};
class SwXMLTextBlockDocumentContext : public SvXMLImportContext
@@ -73,6 +78,9 @@ private:
public:
SwXMLTextBlockDocumentContext( SwXMLTextBlockImport& rImport );
+virtual void SAL_CALL startFastElement( sal_Int32 /*nElement*/,
+const css::uno::Reference< css::xml::sax::XFastAttributeList
>& ) override {}
+
virtual css::uno::Reference< css::xml::sax::XFastContextHandler > SAL_CALL
createFastChildContext(
sal_Int32 Element, const css::uno::Reference<
css::xml::sax::XFastAttributeList > & xAttrList ) override;
};
@@ -85,6 +93,9 @@ private:
public:
SwXMLTextBlockBodyContext( SwXMLTextBlockImport& rImport );
+virtual void SAL_CALL startFastElement( sal_Int32 /*nElement*/,
+const css::uno::Reference< css::xml::sax::XFastAttributeList
>& ) override {}
+
virtual css::uno::Reference< css::xml::sax::XFastContextHandler > SAL_CALL
createFastChildContext(
sal_Int32, const css::uno::Reference<
css::xml::sax::XFastAttributeList > & xAttrList ) override;
};
@@ -97,6 +108,9 @@ private:
public:
SwXMLTextBlockTextContext( SwXMLTextBlockImport& rImport );
+virtual void SAL_CALL startFastElement( sal_Int32 /*nElement*/,
+const css::uno::Reference< css::xml::sax::XFastAttributeList
>& ) override {}
+
virtual css::uno::Reference< css::xml::sax::XFastContextHandler > SAL_CALL
createFastChildContext(
sal_Int32 Element,
const css::uno::Reference< css::xml::sax::XFastAttributeList > &
xAttrList ) override;
@@ -110,6 +124,9 @@ private:
public:
SwXMLTextBlockParContext( SwXMLTextBlockImport & rImport );
+virtual void SAL_CALL startFastElement( sal_Int32 /*nElement*/,
+const css::uno::Reference< css::xml::sax::XFastAttributeList
>& ) override {}
+
virtual void SAL_CALL characters( const OUString & aChars ) override;
virtual ~SwXMLTextBlockParContext() override;
@@ -308,8 +325,7 @@ SvXMLImportContext*
SwXMLBlockListImport::CreateFastContext( sal_Int32 Element,
{
if( Element == SwXMLBlockListToken::BLOCK_LIST )
return new SwXMLBlockListContext( *this, xAttrList );
-else
-return SvXMLImport::CreateFastContext( Element, xAttrList );
+return nullptr;
}
SwXMLTextBlockImport::SwXMLTextBlockImport(
@@ -328,13 +344,12 @@ SwXMLTextBlockImport::~SwXMLTextBlockImport()
}
SvXMLImportContext* SwXMLTextBlockImport::CreateFastContext( sal_Int32 Element,
-const uno::Reference< xml::sax::XFastAttributeList > & xAttrList )
+const uno::Reference< xml::sax::XFastAttributeList > & /*xAttrList*/ )
{
if( Element == SwXMLTextBlockToken::OFFICE_DOCUMENT ||
Element == SwXMLTextBlockToken::OFFICE_DOCUMENT_CONTENT )
return new SwXMLTextBlockDocumentContext( *this );
-else
-return SvXMLImport::CreateFastContext( Element, xAttrList );
+return nullptr;
}
void SAL_CALL SwXMLTextBlockImport::endDocument()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
[Libreoffice-commits] core.git: dbaccess/source desktop/source
dbaccess/source/core/misc/sdbcoretools.cxx
|4 ++--
desktop/source/app/langselect.cxx
|4 ++--
desktop/source/app/userinstall.cxx
|4 ++--
desktop/source/deployment/gui/dp_gui_updatedialog.cxx
|4 ++--
desktop/source/deployment/manager/dp_managerfac.cxx
|6 ++
desktop/source/deployment/misc/dp_dependencies.cxx
|6 +-
desktop/source/deployment/registry/component/dp_compbackenddb.cxx
|8 ++--
desktop/source/deployment/registry/component/dp_component.cxx
|8 ++--
desktop/source/deployment/registry/configuration/dp_configuration.cxx
|8 ++--
desktop/source/deployment/registry/configuration/dp_configurationbackenddb.cxx
|8 ++--
desktop/source/deployment/registry/dp_backend.cxx
|4 +---
desktop/source/deployment/registry/dp_backenddb.cxx
|6 ++
desktop/source/deployment/registry/executable/dp_executable.cxx
|8 ++--
desktop/source/deployment/registry/executable/dp_executablebackenddb.cxx
|8 ++--
desktop/source/deployment/registry/help/dp_help.cxx
|8 ++--
desktop/source/deployment/registry/help/dp_helpbackenddb.cxx
|8 ++--
desktop/source/deployment/registry/package/dp_extbackenddb.cxx
|8 ++--
desktop/source/deployment/registry/package/dp_package.cxx
|8 ++--
desktop/source/deployment/registry/script/dp_lib_container.cxx
|6 +-
desktop/source/deployment/registry/script/dp_script.cxx
|8 ++--
desktop/source/deployment/registry/script/dp_scriptbackenddb.cxx
|8 ++--
desktop/source/deployment/registry/sfwk/dp_parceldesc.cxx
|8 +---
desktop/source/deployment/registry/sfwk/dp_sfwk.cxx
| 10 ++
23 files changed, 42 insertions(+), 116 deletions(-)
New commits:
commit 0f0ae0e9fbe5b13c268486d46f545cb514134a65
Author: Noel Grandin
AuthorDate: Wed Jan 15 15:31:48 2020 +0200
Commit: Noel Grandin
CommitDate: Thu Jan 16 08:22:45 2020 +0100
clang-tidy modernize-concat-nested-namespace in dbaccess..desktop
Change-Id: I35a3d422fe020a08f6c2678097252334a3951f7c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86848
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/dbaccess/source/core/misc/sdbcoretools.cxx
b/dbaccess/source/core/misc/sdbcoretools.cxx
index 093fbd63befe..cc28d21b4f15 100644
--- a/dbaccess/source/core/misc/sdbcoretools.cxx
+++ b/dbaccess/source/core/misc/sdbcoretools.cxx
@@ -109,7 +109,7 @@ namespace dbaccess
return sDisplayMessage;
}
-namespace tools { namespace stor {
+namespace tools::stor {
bool storageIsWritable_nothrow( const Reference< XStorage >& _rxStorage )
{
@@ -142,7 +142,7 @@ namespace dbaccess
return bSuccess;
}
-} } // tools::stor
+}
} // namespace dbaccess
diff --git a/desktop/source/app/langselect.cxx
b/desktop/source/app/langselect.cxx
index 57f7d3831ff9..0b321f9285f4 100644
--- a/desktop/source/app/langselect.cxx
+++ b/desktop/source/app/langselect.cxx
@@ -45,7 +45,7 @@
#include "cmdlineargs.hxx"
#include "langselect.hxx"
-namespace desktop { namespace langselect {
+namespace desktop::langselect {
namespace {
@@ -146,6 +146,6 @@ bool prepareLocale() {
return true;
}
-} }
+}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/desktop/source/app/userinstall.cxx
b/desktop/source/app/userinstall.cxx
index 55c5a6fa01b0..f42b975c17d9 100644
--- a/desktop/source/app/userinstall.cxx
+++ b/desktop/source/app/userinstall.cxx
@@ -35,7 +35,7 @@
#include "userinstall.hxx"
-namespace desktop { namespace userinstall {
+namespace desktop::userinstall {
namespace {
@@ -170,6 +170,6 @@ Status finalize() {
}
}
-} }
+}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/desktop/source/deployment/gui/dp_gui_updatedialog.cxx
b/desktop/source/deployment/gui/dp_gui_updatedialog.cxx
index 0dcbf641f3c0..28ff3563cc54 100644
--- a/desktop/source/deployment/gui/dp_gui_updatedialog.cxx
+++ b/desktop/source/deployment/gui/dp_gui_updatedialog.cxx
@@ -106,9 +106,9 @@
class KeyEvent;
class MouseEvent;
-namespace com { namespace sun { namespace star { namespace uno {
+namespace com::sun::star::uno {
class XComponentContext;
-} } } }
+}
using namespace ::com::sun::star;
using dp_gui::UpdateDialog;
diff --git a/desktop/source/deployment/manager/dp_managerfac.cxx
b/desktop/source/deployment/manager/dp_managerfac.cxx
index f284c7e3cceb..7960b3ce6497
[Libreoffice-ux-advise] [Bug 130023] No proper spacing between pages in "Hide Whitespace mode"
https://bugs.documentfoundation.org/show_bug.cgi?id=130023 Dieter Praas changed: What|Removed |Added Keywords||needsUXEval Version|3.3.0 release |6.3.4.2 release CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org Summary|No proper spacing between |No proper spacing between |pages in "Continuous mode" |pages in "Hide Whitespace ||mode" --- Comment #1 from Dieter Praas --- The "continuous mode" is "Hide whitespace" (same as View => Hide Whitespace) I confirm it with Version: 6.3.4.2 (x64) Build-ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: threaded But I'm not sure, if this is a bug, because I think it depends on the definition of "Whitespace" cc: Desing-Team for further input (It also would be nice, if there would be a tooltip, if you use whitespace option by clicking between pages. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 130023] No proper spacing between pages in "Hide Whitespace mode"
https://bugs.documentfoundation.org/show_bug.cgi?id=130023 Dieter Praas changed: What|Removed |Added Keywords||needsUXEval Version|3.3.0 release |6.3.4.2 release CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org Summary|No proper spacing between |No proper spacing between |pages in "Continuous mode" |pages in "Hide Whitespace ||mode" --- Comment #1 from Dieter Praas --- The "continuous mode" is "Hide whitespace" (same as View => Hide Whitespace) I confirm it with Version: 6.3.4.2 (x64) Build-ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: threaded But I'm not sure, if this is a bug, because I think it depends on the definition of "Whitespace" cc: Desing-Team for further input (It also would be nice, if there would be a tooltip, if you use whitespace option by clicking between pages. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129481] Undoing "increase indent" undoes only one line at a time
https://bugs.documentfoundation.org/show_bug.cgi?id=129481 Jim Raykowski changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |rayk...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129481] Undoing "increase indent" undoes only one line at a time
https://bugs.documentfoundation.org/show_bug.cgi?id=129481 --- Comment #3 from Jim Raykowski --- Here is a patch that combines undos for indent and spacing changes: https://gerrit.libreoffice.org/c/core/+/86903 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130025] Will not print PDF snap shots using .odt document.
https://bugs.documentfoundation.org/show_bug.cgi?id=130025 Dieter Praas changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||dgp-m...@gmx.de --- Comment #1 from Dieter Praas --- Thank you for reporting the bug. Please 1. Try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ 2. Attach an odt-file with snap shot from PDF I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version. Change to RESOLVED WORKSFORME, if the problem went away. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: xmloff/inc xmloff/source
xmloff/inc/xmlversion.hxx |6 ++
xmloff/source/meta/xmlversion.cxx |6 +++---
2 files changed, 9 insertions(+), 3 deletions(-)
New commits:
commit d26fb4b6a03976063f788703f5a32b868cc49f1d
Author: Noel Grandin
AuthorDate: Thu Jan 16 08:17:24 2020 +0200
Commit: Noel Grandin
CommitDate: Thu Jan 16 08:03:48 2020 +0100
fix XMLVersionListImport fast-parser
AddAtIndex does not seem to play nice with the fast-parser stuff
Change-Id: Iea64566b595e952b8bdf767f51c0c1813f0abb6f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86902
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/xmloff/inc/xmlversion.hxx b/xmloff/inc/xmlversion.hxx
index 6faaa0cd240f..8f0c1c08440f 100644
--- a/xmloff/inc/xmlversion.hxx
+++ b/xmloff/inc/xmlversion.hxx
@@ -77,6 +77,9 @@ public:
virtual ~XMLVersionListContext() override;
+virtual void SAL_CALL startFastElement( sal_Int32 /*nElement*/,
+const css::uno::Reference< css::xml::sax::XFastAttributeList
>& ) override {}
+
virtual css::uno::Reference< css::xml::sax::XFastContextHandler > SAL_CALL
createFastChildContext(sal_Int32 nElement,
const css::uno::Reference< css::xml::sax::XFastAttributeList > &
xAttribs) override;
@@ -94,6 +97,9 @@ public:
XMLVersionContext( XMLVersionListImport& rImport,
const css::uno::Reference<
css::xml::sax::XFastAttributeList > & xAttrList );
+virtual void SAL_CALL startFastElement( sal_Int32 /*nElement*/,
+const css::uno::Reference< css::xml::sax::XFastAttributeList
>& ) override {}
+
virtual ~XMLVersionContext() override;
};
diff --git a/xmloff/source/meta/xmlversion.cxx
b/xmloff/source/meta/xmlversion.cxx
index dba5e8d4f4cd..ff53368af587 100644
--- a/xmloff/source/meta/xmlversion.cxx
+++ b/xmloff/source/meta/xmlversion.cxx
@@ -105,8 +105,8 @@ XMLVersionListImport::XMLVersionListImport(
: SvXMLImport(rContext, ""),
maVersions( rVersions )
{
-GetNamespaceMap().AddAtIndex(
xmloff::token::GetXMLToken(xmloff::token::XML_NP_VERSIONS_LIST),
-
xmloff::token::GetXMLToken(xmloff::token::XML_N_VERSIONS_LIST),
XML_NAMESPACE_FRAMEWORK );
+GetNamespaceMap().Add(
xmloff::token::GetXMLToken(xmloff::token::XML_NP_VERSIONS_LIST),
+
xmloff::token::GetXMLToken(xmloff::token::XML_N_VERSIONS_LIST),
XML_NAMESPACE_VERSIONS_LIST );
}
XMLVersionListImport::~XMLVersionListImport() throw()
@@ -117,7 +117,7 @@ SvXMLImportContext
*XMLVersionListImport::CreateFastContext( sal_Int32 nElement,
{
SvXMLImportContext *pContext = nullptr;
-if ( nElement == XML_ELEMENT(FRAMEWORK, xmloff::token::XML_VERSION_LIST) )
+if ( nElement == XML_ELEMENT(VERSIONS_LIST,
xmloff::token::XML_VERSION_LIST) )
{
pContext = new XMLVersionListContext( *this );
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129680] Spacing and Indent controls make cursor disappear
https://bugs.documentfoundation.org/show_bug.cgi?id=129680 Commit Notification changed: What|Removed |Added Whiteboard||target:6.5.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/ui/view/drtxtob1.cxx | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
New commits:
commit 1840ed1ede481d28c1a75e2767357866f6f1c55a
Author: Jim Raykowski
AuthorDate: Sat Dec 28 21:20:05 2019 -0900
Commit: Jim Raykowski
CommitDate: Thu Jan 16 08:01:46 2020 +0100
tdf#129680 Make text edit outliner view show cursor
Better placement of tdf#50530 fix
80f18e7e028e9ca431aef281ab98bea99ad19fa3
Change-Id: If6a83d94ebd52ada34d800f8270fa82b4260fdbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86099
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sd/source/ui/view/drtxtob1.cxx b/sd/source/ui/view/drtxtob1.cxx
index 65a357e33563..efb60baf216a 100644
--- a/sd/source/ui/view/drtxtob1.cxx
+++ b/sd/source/ui/view/drtxtob1.cxx
@@ -815,16 +815,16 @@ void TextObjectBar::Execute( SfxRequest )
// to refresh preview (in outline mode), slot has to be
invalidated:
mpViewShell->GetViewFrame()->GetBindings().Invalidate(
SID_PREVIEW_STATE, true );
-
-if ( pOLV )
-{
-pOLV->ShowCursor();
-pOLV->GetWindow()->GrabFocus();
-}
}
break;
}
+if ( pOLV )
+{
+pOLV->ShowCursor();
+pOLV->GetWindow()->GrabFocus();
+}
+
Invalidate( SID_OUTLINE_LEFT );
Invalidate( SID_OUTLINE_RIGHT );
Invalidate( SID_OUTLINE_UP );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129680] Spacing and Indent controls make cursor disappear
https://bugs.documentfoundation.org/show_bug.cgi?id=129680 --- Comment #2 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1840ed1ede481d28c1a75e2767357866f6f1c55a tdf#129680 Make text edit outliner view show cursor It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129987] It is no longer possible to copy from another program into LibreOffice under Windows 10.
https://bugs.documentfoundation.org/show_bug.cgi?id=129987 Dieter Praas changed: What|Removed |Added OS|All |Windows (All) Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #5 from Dieter Praas --- (In reply to Nicholas F. Peters from comment #3) > (In reply to Dieter Praas from comment #1) > > Nicholas, which version of Windows 10 and which version of LO do you use? > > > > => NEEDINFO > > The latest version of Windows 10 is being used. This would bei Version 1909. I can't reproduce it with Windows 10 1903. To be certain the reported issue is not related to corruption in the user profile, could you please reset your Libreoffice profile (https://wiki.documentfoundation.org/UserProfile) and re-test? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the issue is still present. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: android/app android/lib loleaflet/po
android/app/src/main/res/values-it/strings.xml | 102 ++- android/lib/src/main/res/values-it/strings.xml |9 + loleaflet/po/help-eu.po|4 loleaflet/po/help-fr.po| 14 +- loleaflet/po/ui-ca.po |4 loleaflet/po/ui-cs.po |4 loleaflet/po/ui-cy.po |4 loleaflet/po/ui-dsb.po |4 loleaflet/po/ui-es.po |4 loleaflet/po/ui-eu.po |4 loleaflet/po/ui-fr.po | 134 +++-- loleaflet/po/ui-hsb.po |4 loleaflet/po/ui-hu.po |4 loleaflet/po/ui-it.po |4 loleaflet/po/ui-pt_BR.po |4 loleaflet/po/ui-sl.po |4 16 files changed, 201 insertions(+), 106 deletions(-) New commits: commit a68a687f6eb1a26a2f04f092c5029a3d09be4052 Author: Weblate AuthorDate: Wed Jan 15 18:29:03 2020 +0100 Commit: Andras Timar CommitDate: Thu Jan 16 07:43:45 2020 +0100 update translations LibreOffice Online/loleaflet-help (French) Currently translated at 57.7% (240 of 416 strings) Change-Id: I67fa7619e84662e0ac6f7fbbd7b48290fff308d5 update translations LibreOffice Online/loleaflet-ui (Slovenian) Currently translated at 100.0% (283 of 283 strings) Change-Id: I6e1be426eb75e5b87f10e2338659a9a6a7e7d93d update translations LibreOffice Online/loleaflet-ui (French) Currently translated at 100.0% (283 of 283 strings) Change-Id: I8be0537b31c251b739e0444db9389ed73abd473c update translations LibreOffice Online/loleaflet-help (French) Currently translated at 56.5% (235 of 416 strings) Change-Id: Ice1a07804f9d8af9852fb518e6e5de3eb23284bb update translations LibreOffice Online/loleaflet-ui (French) Currently translated at 100.0% (283 of 283 strings) Change-Id: I2d33f2166683cec9ed3d81847703c75b77673d9b update translations LibreOffice Online/loleaflet-help (Basque) Currently translated at 82.7% (344 of 416 strings) Change-Id: Ib5bf668509f2ba46ea14ccfd068002c75398ae79 update translations LibreOffice Online/loleaflet-ui (Basque) Currently translated at 100.0% (283 of 283 strings) Change-Id: I9a1777fe5aa396461b66947477cfb9961e2a8624 update translations LibreOffice Online/loleaflet-ui (Italian) Currently translated at 100.0% (283 of 283 strings) Change-Id: Ie6276d1dcfb3fa85788fd51a92ed45d8bcb1aedc update translations LibreOffice Online/android-app (Italian) Currently translated at 100.0% (99 of 99 strings) Change-Id: Ib2b30bd6c239c20c4a863a0b396936cf5c86f750 update translations LibreOffice Online/android-lib (Italian) Currently translated at 100.0% (6 of 6 strings) Change-Id: I2a57065004f3c38c63b1523be845455e9d57f974 update translations LibreOffice Online/loleaflet-ui (Portuguese (Brazil)) Currently translated at 100.0% (283 of 283 strings) Change-Id: I8576418e089bfce6568d2c1a654f66e049810156 update translations LibreOffice Online/loleaflet-ui (Spanish) Currently translated at 100.0% (283 of 283 strings) Change-Id: I2cd272bccb87d1c34df38e2eb126efe1dbd0104c update translations LibreOffice Online/loleaflet-ui (Welsh) Currently translated at 100.0% (283 of 283 strings) Change-Id: Ia047bad0abb6d7d87d690f90cf81f03403ee41ee update translations LibreOffice Online/loleaflet-ui (Catalan) Currently translated at 97.5% (276 of 283 strings) Change-Id: I6750f027e5fb01dc09182b9a9a4fdf855d554d3a update translations LibreOffice Online/loleaflet-ui (Hungarian) Currently translated at 100.0% (283 of 283 strings) Change-Id: I67c4efa59f061c150e7901b164bb408c29142b2d update translations LibreOffice Online/loleaflet-ui (Upper Sorbian) Currently translated at 100.0% (283 of 283 strings) Change-Id: I3da4481bdeed28e9d714ef42f3428629672d4b6b update translations LibreOffice Online/loleaflet-ui (Lower Sorbian) Currently translated at 100.0% (283 of 283 strings) Change-Id: Ifdf40e74cedcc1c1e56c4eadfc83a9e50d38b91f Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86764 Tested-by: Jenkins CollaboraOffice Reviewed-by: Andras Timar diff --git a/android/app/src/main/res/values-it/strings.xml b/android/app/src/main/res/values-it/strings.xml index a6b3daec9..3811229ff 100644 --- a/android/app/src/main/res/values-it/strings.xml +++ b/android/app/src/main/res/values-it/strings.xml @@ -1,2 +1,102 @@ - \ No newline at end
[Libreoffice-commits] core.git: sd/source
sd/source/core/CustomAnimationPreset.cxx | 37 +--
1 file changed, 7 insertions(+), 30 deletions(-)
New commits:
commit 1fc10944c9964e24361ea8ef87064a21446db571
Author: Noel Grandin
AuthorDate: Mon Jan 13 20:06:19 2020 +0200
Commit: Noel Grandin
CommitDate: Thu Jan 16 07:09:11 2020 +0100
use FastParser in CustomAnimationPreset
Change-Id: I587491e60543e2d0b7cb49571ba146e12bd5610a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86711
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sd/source/core/CustomAnimationPreset.cxx
b/sd/source/core/CustomAnimationPreset.cxx
index 1f16b3724fc4..f2358fe18bf5 100644
--- a/sd/source/core/CustomAnimationPreset.cxx
+++ b/sd/source/core/CustomAnimationPreset.cxx
@@ -26,7 +26,7 @@
#include
#include
#include
-#include
+#include
#include
#include
#include
@@ -39,6 +39,7 @@
#include
#include
#include
+#include
#include
#include
@@ -231,41 +232,17 @@ Reference< XAnimationNode > implImportEffects( const
Reference< XMultiServiceFac
aParserInput.sSystemId = rPath;
aParserInput.aInputStream = xInputStream;
-// get parser
-Reference< xml::sax::XParser > xParser = xml::sax::Parser::create(
comphelper::getComponentContext(xServiceFactory) );
-
// get filter
-Reference< xml::sax::XDocumentHandler > xFilter(
xServiceFactory->createInstance("com.sun.star.comp.Xmloff.AnimationsImport" ),
UNO_QUERY );
-
-DBG_ASSERT( xFilter.is(), "Can't instantiate filter component." );
-if( !xFilter.is() )
-return xRootNode;
-
-// connect parser and filter
-xParser->setDocumentHandler( xFilter );
+Reference< xml::sax::XFastParser > xFilter(
xServiceFactory->createInstance("com.sun.star.comp.Xmloff.AnimationsImport" ),
UNO_QUERY_THROW );
-// finally, parser the stream
-xParser->parseStream( aParserInput );
+xFilter->parseStream( aParserInput );
-Reference< XAnimationNodeSupplier > xAnimationNodeSupplier( xFilter,
UNO_QUERY );
-if( xAnimationNodeSupplier.is() )
-xRootNode = xAnimationNodeSupplier->getAnimationNode();
-}
-catch (const xml::sax::SAXParseException&)
-{
-OSL_FAIL( "sd::implImportEffects(), SAXParseException caught!" );
-}
-catch (const xml::sax::SAXException&)
-{
-OSL_FAIL( "sd::implImportEffects(), SAXException caught!" );
-}
-catch (const io::IOException&)
-{
-OSL_FAIL( "sd::implImportEffects(), IOException caught!" );
+Reference< XAnimationNodeSupplier > xAnimationNodeSupplier( xFilter,
UNO_QUERY_THROW );
+xRootNode = xAnimationNodeSupplier->getAnimationNode();
}
catch (const Exception&)
{
-OSL_FAIL( "sd::importEffects(), Exception caught!" );
+TOOLS_WARN_EXCEPTION("sd", "");
}
return xRootNode;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 38093] Add an Outline View layout and editing mode to Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=38093 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=47 ||746 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47746] "Code folding" for Writer / Collapse or expand parts of a document
https://bugs.documentfoundation.org/show_bug.cgi?id=47746 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=38 ||093 --- Comment #25 from Mike Kaganski --- This definitely looks like a dupe of tdf#38093 - outline mode for Writer. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 38093] Add an Outline View layout and editing mode to Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=38093 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=47 ||746 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 130018] Space in the word York as Y ork in Calc, using Arial font
https://bugs.documentfoundation.org/show_bug.cgi?id=130018 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||3322 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL
https://bugs.documentfoundation.org/show_bug.cgi?id=103322 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||0018 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130018] Space in the word York as Y ork in Calc, using Arial font
https://bugs.documentfoundation.org/show_bug.cgi?id=130018 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=88 ||991 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88991] VIEWING: Kerning issues with certain fonts like Arial
https://bugs.documentfoundation.org/show_bug.cgi?id=88991 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||0018 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130004] Navigator mode can no longer be set from its Navigation dialog, entangled with Findbar 'navigate by' droplist--affected by position of the dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=130004 --- Comment #12 from V Stuart Foote --- (In reply to sdc.blanco from comment #11) > Created attachment 157174 [details] > screenshot of Navigation popup and Navigator deck @Seth, Note in this clip that the Navigation toolbox dialog has been moved off of the Navigator deck. Issue seems to occur when the dialog overlays the sidebar Navigator deck (either instance) and has not be dragged to new position. For sure when in its default profile launch location--not clear how far it has to move before it regains function. But when repositioned actions do seem correct. Stuart -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129710] Possible memory leak and/or struggle when saving Impress document after updating it
https://bugs.documentfoundation.org/show_bug.cgi?id=129710 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129987] It is no longer possible to copy from another program into LibreOffice under Windows 10.
https://bugs.documentfoundation.org/show_bug.cgi?id=129987 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129987] It is no longer possible to copy from another program into LibreOffice under Windows 10.
https://bugs.documentfoundation.org/show_bug.cgi?id=129987 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129988] Crash in: s_stub_releaseInterface
https://bugs.documentfoundation.org/show_bug.cgi?id=129988 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130000] Accessing LibreOffice Online via the WOPI protocol results in client - server version mismatch when running in Docker
https://bugs.documentfoundation.org/show_bug.cgi?id=13 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129725] Dark theme for the welcome window.
https://bugs.documentfoundation.org/show_bug.cgi?id=129725 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129988] Crash in: s_stub_releaseInterface
https://bugs.documentfoundation.org/show_bug.cgi?id=129988 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116792] Crash loadComponentFromURL close
https://bugs.documentfoundation.org/show_bug.cgi?id=116792 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130000] Accessing LibreOffice Online via the WOPI protocol results in client - server version mismatch when running in Docker
https://bugs.documentfoundation.org/show_bug.cgi?id=13 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116792] Crash loadComponentFromURL close
https://bugs.documentfoundation.org/show_bug.cgi?id=116792 --- Comment #9 from QA Administrators --- Dear matti.jaatinen, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123577] Web view: Lag and CPU spikes when inserting, deleting, or reordering bulleted lists, numbered lists, and paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=123577 --- Comment #5 from QA Administrators --- Dear Ahiijny, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85168] EDITING: pictures with transparent background pasted from web into LibO lose transparency
https://bugs.documentfoundation.org/show_bug.cgi?id=85168 --- Comment #8 from QA Administrators --- Dear E Moen, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - unoxml/source
unoxml/source/dom/documentbuilder.cxx | 23 +++
1 file changed, 19 insertions(+), 4 deletions(-)
New commits:
commit 9a224357cba5dfe5376cab9791ffccb6c089d8a6
Author: Michael Meeks
AuthorDate: Thu Jan 16 02:04:53 2020 +
Commit: Ashod Nakashian
CommitDate: Thu Jan 16 04:43:59 2020 +0100
unoxml: CDocumentBuilder::parseURI should handle non-file:/// URIs.
The proximate symptom of this is of only some of the slide layouts
applying in impress on Android. This is caused by not parsing the
file:///assets/.../layoutlist.xml - which needs to use UCB and its
cleverer osl/ file APIs.
Change-Id: I22ed77170891c0ec136caaa29da69987a0e51a73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86899
Reviewed-by: Ashod Nakashian
Tested-by: Ashod Nakashian
diff --git a/unoxml/source/dom/documentbuilder.cxx
b/unoxml/source/dom/documentbuilder.cxx
index 8d244ab6d6e9..9bf3154ce9aa 100644
--- a/unoxml/source/dom/documentbuilder.cxx
+++ b/unoxml/source/dom/documentbuilder.cxx
@@ -40,6 +40,7 @@
#include
#include
#include
+#include
#include
#include
@@ -401,11 +402,25 @@ namespace DOM
OString oUri = OUStringToOString(sUri, RTL_TEXTENCODING_UTF8);
char *uri = const_cast(oUri.getStr());
xmlDocPtr pDoc = xmlCtxtReadFile(pContext.get(), uri, nullptr, 0);
+
+Reference< XDocument > xRet;
+
+// if we failed to parse the URI as a simple file, lets try via a ucb
stream.
+// For Android file:///assets/ URLs which must go via the osl/ file
API.
if (pDoc == nullptr) {
-throwEx(pContext.get());
-}
-Reference< XDocument > const xRet(
-CDocument::CreateCDocument(pDoc).get());
+Reference < XSimpleFileAccess3 > xStreamAccess(
+SimpleFileAccess::create(
comphelper::getProcessComponentContext() ) );
+Reference< XInputStream > xInStream(xStreamAccess->openFileRead(
sUri ), UNO_QUERY_THROW);
+
+// loop over every layout entry in current file
+xRet = parse( xInStream );
+
+xInStream->closeInput();
+xInStream.clear();
+
+} else
+xRet = CDocument::CreateCDocument(pDoc).get();
+
return xRet;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 32418] Add an "insert symbol" to Math
https://bugs.documentfoundation.org/show_bug.cgi?id=32418 Y Cao <1783250...@qq.com> changed: What|Removed |Added Assignee|1783250...@qq.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92924] Export to PDF loses transparency
https://bugs.documentfoundation.org/show_bug.cgi?id=92924 --- Comment #19 from kem --- Bug still present; version info: Version: 6.3.4.2 Build ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; VCL: osx; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 32418] Add an "insert symbol" to Math
https://bugs.documentfoundation.org/show_bug.cgi?id=32418 Y Cao <1783250...@qq.com> changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |1783250...@qq.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] dev-tools.git: help3/xhpeditor
help3/xhpeditor/favicon.ico |binary
help3/xhpeditor/index.php | 13 -
help3/xhpeditor/menu.php |2 -
help3/xhpeditor/xhp2html.js | 51 ++--
help3/xhpeditor/xhpeditor.css | 59 --
5 files changed, 68 insertions(+), 57 deletions(-)
New commits:
commit 3daeb789ecd347e128b6c11682f1d6d174651534
Author: Olivier Hallot
AuthorDate: Wed Jan 15 22:59:58 2020 -0300
Commit: Olivier Hallot
CommitDate: Thu Jan 16 03:06:40 2020 +0100
xhpeditor: clear CSS and refactor
Change-Id: I45da5bda3bd2e51367cb0cd7f61610174ba0317b
Reviewed-on: https://gerrit.libreoffice.org/c/dev-tools/+/86898
Reviewed-by: Olivier Hallot
Tested-by: Olivier Hallot
diff --git a/help3/xhpeditor/favicon.ico b/help3/xhpeditor/favicon.ico
new file mode 100644
index 000..ee6560b
Binary files /dev/null and b/help3/xhpeditor/favicon.ico differ
diff --git a/help3/xhpeditor/index.php b/help3/xhpeditor/index.php
index 7e063e5..a174c6b 100644
--- a/help3/xhpeditor/index.php
+++ b/help3/xhpeditor/index.php
@@ -15,6 +15,7 @@ $xhp = $_POST["xhpdoc"];
LibreOffice Documentation XHP Editor
+
@@ -22,26 +23,26 @@ $xhp = $_POST["xhpdoc"];
+
-
-
+
-
-
-
+
+
+
LibreOffice Documentation XHP Editor
-
+
diff --git a/help3/xhpeditor/buttons.php b/help3/xhpeditor/menu.php
similarity index 98%
rename from help3/xhpeditor/buttons.php
rename to help3/xhpeditor/menu.php
index cd90f4e..ed6d4ac 100644
--- a/help3/xhpeditor/buttons.php
+++ b/help3/xhpeditor/menu.php
@@ -3,7 +3,7 @@
File
-Save
+Save
diff --git a/help3/xhpeditor/xhp2html.js b/help3/xhpeditor/xhp2html.js
index 170b846..667ea06 100644
--- a/help3/xhpeditor/xhp2html.js
+++ b/help3/xhpeditor/xhp2html.js
@@ -9,6 +9,36 @@
/* change these parameters to fit your installation */
+// Codemirror configuration
+var editor = CodeMirror.fromTextArea(document.getElementById("xhpeditor"), {
+lineNumbers: true,
+theme: "default",
+mode: "xml",
+extraKeys: {
+"'<'": completeAfter,
+"'/'": completeIfAfterLt,
+"' '": completeIfInTag,
+"'='": completeIfInTag,
+"Ctrl-Space": "autocomplete"
+}
+});
+/*
+indentUnit: 4,
+indentWithTabs: false,
+
+matchBrackets: true,
+
+lineWrapping: true,
+viewportMargin: Infinity,
+extraKeys: {
+"'<'": completeAfter,
+"'/'": completeIfAfterLt,
+"' '": completeIfInTag,
+"'='": completeIfInTag,
+"Ctrl-Space": "autocomplete"
+}
+*/
+
function readSingleFile(e) {
var file = e.target.files[0];
@@ -36,7 +66,7 @@ function getFileNameFromXML(){
// Function to download data to a file
// source:
https://stackoverflow.com/questions/13405129/javascript-create-and-save-file
-function download(data, filename, type) {
+function downloadFile(data, filename, type) {
var file = new Blob([data], {type: type});
if (window.navigator.msSaveOrOpenBlob) // IE10+
window.navigator.msSaveOrOpenBlob(file, filename);
@@ -53,22 +83,3 @@ function download(data, filename, type) {
}, 0);
}
}
-
-// Codemirror configuration
-var editor = CodeMirror.fromTextArea(document.getElementById("xhpeditor"), {
-lineNumbers: true,
-viewportMargin: Infinity,
-indentUnit: 4,
-indentWithTabs: false,
-mode: "xml",
-matchBrackets: true,
-theme: "default",
-lineWrapping: true,
-extraKeys: {
-"'<'": completeAfter,
-"'/'": completeIfAfterLt,
-"' '": completeIfInTag,
-"'='": completeIfInTag,
-"Ctrl-Space": "autocomplete"
-}
-});
diff --git a/help3/xhpeditor/xhpeditor.css b/help3/xhpeditor/xhpeditor.css
index 251672e..273eaa9 100644
--- a/help3/xhpeditor/xhpeditor.css
+++ b/help3/xhpeditor/xhpeditor.css
@@ -90,40 +90,39 @@
}
#leftside{
-top: 0%;
-bottom:0%;
-left:0%;
+top: 0px;
+bottom:0px;
+left:0px;
right:50%;
position: absolute;
background: Beige;
-display:block;
border:1px solid grey;
-overflow: auto;
}
#editorpageheader{
-top: 0%;
-left: 0%;
+top: 0px;
+left: 0px;
+right: 0px;
position:absolute;
-margin: 0px 10px 10px 10px;
+margin: 0px 5px 5px 5px;
z-index:100;
}
#editortextarea{
-margin: 170px 10px 10px 10px;
-left:0%;
-right: 50%;
-line-height: normal;
-clear:right;
-overflow: auto;
+margin: 5px 5px 5px 5px;
+left:0px;
+right: 0px;
+bottom:0px;
+top:170px;
+position:absolute;
}
#rightside{
-top: 0%;
-bottom:0%;
-right:0%;
+top: 0px;
+bottom:0px;
+right:0px;
left: 50%;
position:absolute;
background: AliceBlue;
border:1px solid
[Libreoffice-bugs] [Bug 130028] New: TRACK CHANGES: Changes are not shown when the case of a single word is changed to uppercase
https://bugs.documentfoundation.org/show_bug.cgi?id=130028
Bug ID: 130028
Summary: TRACK CHANGES: Changes are not shown when the case of
a single word is changed to uppercase
Product: LibreOffice
Version: 6.3.1.2 release
Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: LibreOffice
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: ha...@aol.com
1. Create a two-word file ("test1 test2")
2. Save it and close.
3. Open this file.
4. Track changes "ON".
5. Select the first word.
6. Format -> test -> change case -> uppercase.
7. The case is changed, but the changes are not visible.
8. Select the second word.
9. Manually replace it with "TEST2".
10. The case is changed, and the changes are visible.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130004] Navigator mode can no longer be set from its Navigation dialog, entangled with Findbar 'navigate by' droplist--affected by position of the dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=130004 --- Comment #11 from sdc.bla...@youmail.dk --- Created attachment 157174 --> https://bugs.documentfoundation.org/attachment.cgi?id=157174=edit screenshot of Navigation popup and Navigator deck (In reply to Jim Raykowski from comment #10) > Navigation popup window Thanks Jim. I can open the popup Navigation toolbox, and can click on any/all of the icons, without Navigation popup closing. (In reply to V Stuart Foote from comment #8) > New STR: Cannot reproduce. > 5. In dialog, select/click a mode other than Page, dialog should close Does not close. > Back on Navigator: what label shows on the back/previous, > foward/next arrow buttons? See attachment. The example is for "reminder". The navigation arrows on the Navigation popup shows "Previous Reminder" / "Next Reminder" and the attachment shows the results of the tooltips for the arrows in the Navigator deck. > Is it the selection you just made from the Navigation dialog? Yes With Findbar open, can click on different modes in the popup Navigation toolbox, with the clicked mode name appearing at the bottom of the Navigation popup and in the "Navigate by" window in the Find toolbar. (Repeated several times, tried all the modes in the Navigation toolbox) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129908] Crash at Data > Group and outlone > AutoOutline
https://bugs.documentfoundation.org/show_bug.cgi?id=129908 Adolfo Jayme changed: What|Removed |Added Whiteboard|target:6.5.0 target:6.3.5 |target:6.5.0 target:6.3.5 |target:6.4.1 target:6.4.0 |target:6.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1c8acf41a0fe7ec4e32bca119961601eb52676a6 Author: Olivier Hallot AuthorDate: Wed Jan 15 21:53:08 2020 -0300 Commit: Gerrit Code Review CommitDate: Thu Jan 16 01:53:08 2020 +0100 Update git submodules * Update helpcontent2 from branch 'libreoffice-6-4' to 191058eba782a34dad89959d5a20d6f2edd4bc3a - tdf#129604 Place localized images in right makefile Change-Id: Ia0b9328d218b4a59a6483f3468c163ec82329d99 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/86793 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/helpcontent2 b/helpcontent2 index 927b9f89df55..191058eba782 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 927b9f89df5519d053e3c0d12198776ed07f6f32 +Subproject commit 191058eba782a34dad89959d5a20d6f2edd4bc3a ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Branch 'libreoffice-6-4' - AllLangPackage_html_media_lang.mk Package_html_media.mk
AllLangPackage_html_media_lang.mk | 23 Package_html_media.mk | 69 -- 2 files changed, 23 insertions(+), 69 deletions(-) New commits: commit 191058eba782a34dad89959d5a20d6f2edd4bc3a Author: Olivier Hallot AuthorDate: Tue Jan 14 13:58:31 2020 -0300 Commit: Adolfo Jayme Barrientos CommitDate: Thu Jan 16 01:53:08 2020 +0100 tdf#129604 Place localized images in right makefile Change-Id: Ia0b9328d218b4a59a6483f3468c163ec82329d99 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/86793 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/AllLangPackage_html_media_lang.mk b/AllLangPackage_html_media_lang.mk index e59ecffdb..c1987dc02 100644 --- a/AllLangPackage_html_media_lang.mk +++ b/AllLangPackage_html_media_lang.mk @@ -241,6 +241,29 @@ $(foreach lang,$(filter-out en-US,$(gb_HELP_LANGS)),$(eval $(call gb_AllLangPack screenshots/modules/smath/ui/fonttypedialog/$(lang)/FontsDialog.png \ screenshots/modules/smath/ui/savedefaultsdialog/$(lang)/SaveDefaultsDialog.png \ screenshots/modules/smath/ui/spacingdialog/$(lang)/SpacingDialog.png \ + screenshots/modules/simpress/ui/optimpressgeneralpage/$(lang)/OptSavePage.png \ +screenshots/cui/ui/optviewpage/$(lang)/OptViewPage.png \ +screenshots/cui/ui/optfltrpage/$(lang)/OptFltrPage.png \ +screenshots/cui/ui/opthtmlpage/$(lang)/OptHtmlPage.png \ +screenshots/cui/ui/optaccessibilitypage/$(lang)/OptAccessibilityPage.png \ +screenshots/cui/ui/optsavepage/$(lang)/OptSavePage.png \ +screenshots/cui/ui/optadvancedpage/$(lang)/OptAdvancedPage.png \ +screenshots/cui/ui/optasianpage/$(lang)/OptAsianPage.png \ +screenshots/cui/ui/optctlpage/$(lang)/OptCTLPage.png \ +screenshots/cui/ui/optsecuritypage/$(lang)/OptSecurityPage.png \ +screenshots/cui/ui/effectspage/$(lang)/EffectsPage.png \ +screenshots/cui/ui/hyperlinkdocpage/$(lang)/HyperlinkDocPage.png \ +screenshots/cui/ui/hyperlinkinternetpage/$(lang)/HyperlinkInternetPage.png \ +screenshots/cui/ui/hyperlinkmailpage/$(lang)/HyperlinkMailPage.png \ +screenshots/cui/ui/hyperlinknewdocpage/$(lang)/HyperlinkNewDocPage.png \ +screenshots/cui/ui/optlanguagespage/$(lang)/OptLanguagesPage.png \ +screenshots/cui/ui/optgeneralpage/$(lang)/OptGeneralPage.png \ +screenshots/filter/ui/pdfgeneralpage/$(lang)/PdfGeneralPage.png \ +screenshots/filter/ui/pdflinkspage/$(lang)/PdfLinksPage.png \ +screenshots/filter/ui/pdfviewpage/$(lang)/PdfViewPage.png \ + screenshots/filter/ui/pdfuserinterfacepage/$(lang)/PdfUserInterfacePage.png \ +screenshots/filter/ui/pdfsignpage/$(lang)/PdfSignPage.png \ +screenshots/filter/ui/pdfsecuritypage/$(lang)/PdfSecurityPage.png \ screenshots/svx/ui/compressgraphicdialog/$(lang)/CompressGraphicDialog.png \ ))) #TODO: Find a clever way to pick en-US files (default) when localized files are missing diff --git a/Package_html_media.mk b/Package_html_media.mk index 7d71cd12a..b828c10dd 100644 --- a/Package_html_media.mk +++ b/Package_html_media.mk @@ -332,96 +332,27 @@ $(eval $(call gb_Package_add_files_with_dir,helpcontent2_html_media,$(LIBO_SHARE screenshots/modules/swriter/ui/watermarkdialog/WatermarkDialog.png \ screenshots/svx/ui/compressgraphicdialog/CompressGraphicDialog.png \ screenshots/modules/simpress/ui/optimpressgeneralpage/OptSavePage.png \ -$(foreach lang, $(filter-out en-US,$(gb_HELP_LANGS)),\ - screenshots/modules/simpress/ui/optimpressgeneralpage/$(lang)/OptSavePage.png \ - ) \ screenshots/cui/ui/optviewpage/OptViewPage.png \ -$(foreach lang, $(filter-out en-US,$(gb_HELP_LANGS)),\ - screenshots/cui/ui/optviewpage/$(lang)/OptViewPage.png \ - ) \ screenshots/cui/ui/optfltrpage/OptFltrPage.png \ -$(foreach lang, $(filter-out en-US,$(gb_HELP_LANGS)),\ - screenshots/cui/ui/optfltrpage/$(lang)/OptFltrPage.png \ - ) \ screenshots/cui/ui/opthtmlpage/OptHtmlPage.png \ -$(foreach lang, $(filter-out en-US,$(gb_HELP_LANGS)),\ - screenshots/cui/ui/opthtmlpage/$(lang)/OptHtmlPage.png \ - ) \ screenshots/cui/ui/optaccessibilitypage/OptAccessibilityPage.png \ -$(foreach lang, $(filter-out en-US,$(gb_HELP_LANGS)),\ - screenshots/cui/ui/optaccessibilitypage/$(lang)/OptAccessibilityPage.png \ - ) \ screenshots/cui/ui/optsavepage/OptSavePage.png \ -$(foreach lang, $(filter-out en-US,$(gb_HELP_LANGS)),\ - screenshots/cui/ui/optsavepage/$(lang)/OptSavePage.png \ - ) \ screenshots/cui/ui/optadvancedpage/OptAdvancedPage.png \ -$(foreach lang, $(filter-out en-US,$(gb_HELP_LANGS)),\ - screenshots/cui/ui/optadvancedpage/$(lang)/OptAdvancedPage.png \ - ) \ screenshots/cui/ui/optasianpage/OptAsianPage.png \ -$(foreach lang, $(filter-out en-US,$(gb_HELP_LANGS)),\ -
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - include/svx sc/source svx/source
include/svx/ctredlin.hxx |5 -
sc/source/ui/miscdlgs/acredlin.cxx |6 ++
svx/source/dialog/ctredlin.cxx | 13 -
3 files changed, 18 insertions(+), 6 deletions(-)
New commits:
commit 4e72c46536fac18f3b22102b5815651bb6938de7
Author: Caolán McNamara
AuthorDate: Sat Jan 11 17:09:10 2020 +
Commit: Adolfo Jayme Barrientos
CommitDate: Thu Jan 16 01:51:22 2020 +0100
Resolves: tdf#129763 resize to request happening on every activate
even though the state remains the same, so only do the resize
if the EnableClearFormatButton[All] state changes.
also change the default to off, which is what writer typically
set it to, and make calc the one that enables it explicitly. Its
easier to grow a dialog than shrink a dialog.
Change-Id: I449df7b7dcf0204b5143b8ad88e528668b84d0a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86615
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/include/svx/ctredlin.hxx b/include/svx/ctredlin.hxx
index cc63771d2af6..b8d57718a8f4 100644
--- a/include/svx/ctredlin.hxx
+++ b/include/svx/ctredlin.hxx
@@ -286,6 +286,9 @@ private:
bool bEnableRejectAll;
bool bEnableUndo;
+bool bEnableClearFormat;
+bool bEnableClearFormatAll;
+
weld::Window* m_pDialog;
std::unique_ptr m_xAccept;
std::unique_ptr m_xReject;
@@ -296,6 +299,7 @@ private:
DECL_LINK( PbClickHdl, weld::Button&, void );
+voidEnableClearFormatButton(weld::Button&, bool bFlag);
public:
SvxTPView(weld::Container* pParent, weld::Window* pDialog, weld::Builder*
pTopLevel);
virtual ~SvxTPView() override;
@@ -306,7 +310,6 @@ public:
voidEnableAcceptAll(bool bFlag);
voidEnableReject(bool bFlag);
voidEnableRejectAll(bool bFlag);
-voidEnableClearFormatButton(weld::Button&, bool bFlag);
voidEnableClearFormat(bool bFlag);
voidEnableClearFormatAll(bool bFlag);
voidEnableUndo(bool bFlag=true);
diff --git a/sc/source/ui/miscdlgs/acredlin.cxx
b/sc/source/ui/miscdlgs/acredlin.cxx
index d94d3ce662c6..cc253a1efccc 100644
--- a/sc/source/ui/miscdlgs/acredlin.cxx
+++ b/sc/source/ui/miscdlgs/acredlin.cxx
@@ -108,6 +108,12 @@ ScAcceptChgDlg::ScAcceptChgDlg(SfxBindings* pB,
SfxChildWindow* pCW, weld::Windo
pTPFilter = m_xAcceptChgCtr->GetFilterPage();
pTPView = m_xAcceptChgCtr->GetViewPage();
+
+// set wider window for the optional extending button labels
+// eg. "Reject/Clear formatting" instead of "Reject"
+pTPView->EnableClearFormat(true);
+pTPView->EnableClearFormatAll(true);
+
pTheView = pTPView->GetTableControl();
pTheView->SetCalcView();
aSelectionIdle.SetInvokeHandler(LINK( this, ScAcceptChgDlg,
UpdateSelectionHdl ));
diff --git a/svx/source/dialog/ctredlin.cxx b/svx/source/dialog/ctredlin.cxx
index f2d119b0005c..3058a602ecc2 100644
--- a/svx/source/dialog/ctredlin.cxx
+++ b/svx/source/dialog/ctredlin.cxx
@@ -335,6 +335,8 @@ SvxTPView::SvxTPView(weld::Container* pParent,
weld::Window* pDialog, weld::Buil
, bEnableReject(true)
, bEnableRejectAll(true)
, bEnableUndo(true)
+, bEnableClearFormat(false)
+, bEnableClearFormatAll(false)
, m_pDialog(pDialog)
, m_xAccept(pTopLevel->weld_button("accept"))
, m_xReject(pTopLevel->weld_button("reject"))
@@ -344,11 +346,6 @@ SvxTPView::SvxTPView(weld::Container* pParent,
weld::Window* pDialog, weld::Buil
, m_xViewData(new
SvxRedlinTable(m_xBuilder->weld_tree_view("writerchanges"),
m_xBuilder->weld_tree_view("calcchanges")))
{
-// set wider window for the optional extending button labels
-// eg. "Reject/Clear formatting" instead of "Reject"
-EnableClearFormat(true);
-EnableClearFormatAll(true);
-
Size aControlSize(80, 65);
m_xViewData->set_size_request(aControlSize.Width(), aControlSize.Height());
@@ -471,12 +468,18 @@ void SvxTPView::EnableClearFormatButton(weld::Button&
rButton, bool bFlag)
void SvxTPView::EnableClearFormat(bool bFlag)
{
+if (bEnableClearFormat == bFlag)
+return;
EnableClearFormatButton(*m_xReject, bFlag);
+bEnableClearFormat = bFlag;
}
void SvxTPView::EnableClearFormatAll(bool bFlag)
{
+if (bEnableClearFormatAll == bFlag)
+return;
EnableClearFormatButton(*m_xRejectAll, bFlag);
+bEnableClearFormatAll = bFlag;
}
void SvxTPView::ShowUndo()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sc/source
sc/source/core/data/documen6.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4c3bde3b4bddb6bcfe0ae5b269d3b0f50c23236f Author: Luboš Luňák AuthorDate: Tue Jan 14 12:26:52 2020 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Thu Jan 16 01:47:24 2020 +0100 do not ignore return value of a (confusing) function (tdf#126248) The two ScCellFormat::GetString() overloads are lame API, one returns the value normally and the other one returns void and uses a reference parameter. I got confused by this in 6f810e3d7dafcd7d0101173a501 and didn't use the return value in one case. Change-Id: I0b6c839f9d0299e14ea022813481802275df5ea6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86750 Tested-by: Jenkins Reviewed-by: 锁琨珑 Reviewed-by: Luboš Luňák (cherry picked from commit 5a211ba9f5f465c8c898ebce4cc37fa30581acac) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86838 Reviewed-by: Adolfo Jayme Barrientos diff --git a/sc/source/core/data/documen6.cxx b/sc/source/core/data/documen6.cxx index 9dd1f8b523a3..bc0f7aa11afa 100644 --- a/sc/source/core/data/documen6.cxx +++ b/sc/source/core/data/documen6.cxx @@ -120,7 +120,7 @@ SvtScriptType ScDocument::GetCellScriptType( const ScAddress& rPos, sal_uInt32 n if( pCell ) ScCellFormat::GetString(*pCell, nNumberFormat, aStr, , *mxPoolHelper->GetFormTable(), this); else -ScCellFormat::GetString(*this, rPos, nNumberFormat, , *mxPoolHelper->GetFormTable()); +aStr = ScCellFormat::GetString(*this, rPos, nNumberFormat, , *mxPoolHelper->GetFormTable()); SvtScriptType nRet = GetStringScriptType( aStr ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sc/source
sc/source/core/data/documen6.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit deeb6f645d4eeb686afd5646b9d64480e54dabea Author: Luboš Luňák AuthorDate: Tue Jan 14 12:26:52 2020 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Thu Jan 16 01:46:46 2020 +0100 do not ignore return value of a (confusing) function (tdf#126248) The two ScCellFormat::GetString() overloads are lame API, one returns the value normally and the other one returns void and uses a reference parameter. I got confused by this in 6f810e3d7dafcd7d0101173a501 and didn't use the return value in one case. Change-Id: I0b6c839f9d0299e14ea022813481802275df5ea6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86750 Tested-by: Jenkins Reviewed-by: 锁琨珑 Reviewed-by: Luboš Luňák (cherry picked from commit 5a211ba9f5f465c8c898ebce4cc37fa30581acac) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86835 Reviewed-by: Adolfo Jayme Barrientos diff --git a/sc/source/core/data/documen6.cxx b/sc/source/core/data/documen6.cxx index 789f26c2c009..e6d7a315f7bf 100644 --- a/sc/source/core/data/documen6.cxx +++ b/sc/source/core/data/documen6.cxx @@ -120,7 +120,7 @@ SvtScriptType ScDocument::GetCellScriptType( const ScAddress& rPos, sal_uInt32 n if( pCell ) ScCellFormat::GetString(*pCell, nNumberFormat, aStr, , *mxPoolHelper->GetFormTable(), this); else -ScCellFormat::GetString(*this, rPos, nNumberFormat, , *mxPoolHelper->GetFormTable()); +aStr = ScCellFormat::GetString(*this, rPos, nNumberFormat, , *mxPoolHelper->GetFormTable()); SvtScriptType nRet = GetStringScriptType( aStr ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 47746] "Code folding" for Writer / Collapse or expand parts of a document
https://bugs.documentfoundation.org/show_bug.cgi?id=47746 --- Comment #24 from Francewhoa --- +1 for this new feature. I'm happy to contribute testing and documentation if needed. MB Squared contributed a proposal, mockups, and examples at https://ask.libreoffice.org/en/question/2596/text-folding-pretty-please/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: logerrit
logerrit |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit d144fe04e7689b0298239b78ee6a6638e136fd55 Author: Guilhem Moulin AuthorDate: Wed Jan 15 05:22:20 2020 +0100 Commit: Guilhem Moulin CommitDate: Thu Jan 16 01:01:58 2020 +0100 logerrit: Upgrade URIs to https:// Change-Id: I0dc259178e5df6334a13ab04850ec662499fe7d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86821 Reviewed-by: Guilhem Moulin Tested-by: Jenkins diff --git a/logerrit b/logerrit index 618686e012bd..ac33c4bf38f4 100755 --- a/logerrit +++ b/logerrit @@ -63,7 +63,7 @@ case "$1" in echo " " echo echo "advanced users should consider using git review instead:" -echo "http://wiki.documentfoundation.org/Development/GitReview; +echo "https://wiki.documentfoundation.org/Development/GitReview; exit ;; setup) @@ -236,7 +236,7 @@ case "$1" in echo >> ../commitmsg echo "branch is at:" >> ../commitmsg git log -1|sed -e "s/Change-Id:/XX:/" >> ../commitmsg -git fetch git://gerrit.libreoffice.org/core.git feature/$BRANCH && \ +git fetch https://git.libreoffice.org/core feature/$BRANCH && \ git checkout -b featuretst FETCH_HEAD && \ cp -a .git-hooks/* .git/hooks git commit --allow-empty -F ../commitmsg && \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 130027] New: 'Check for Updates...' does not work via proxy
https://bugs.documentfoundation.org/show_bug.cgi?id=130027 Bug ID: 130027 Summary: 'Check for Updates...' does not work via proxy Product: LibreOffice Version: 6.3.4.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: s...@dexlab.nl 'Check for Updates...' does not work via proxy. System output: Status: 'Checking for an update failed.'. Description: 'Error reading data from the Internet. Server error message: Could not create SSL connection through proxy server: 200 Connection established.' HTTP 200 Connection established sounds good but functionality is not working. Expected behavior: use system proxy and update. Proxy is basic install of Squid, nothing fancy, not auth required. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: android/lib
android/lib/src/main/cpp/androidapp.cpp
| 179 --
android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
| 103 -
android/lib/src/main/java/org/libreoffice/androidlib/lok/LokClipboardData.java
| 85
android/lib/src/main/java/org/libreoffice/androidlib/lok/LokClipboardEntry.java
|6
4 files changed, 321 insertions(+), 52 deletions(-)
New commits:
commit d6ed93a6451796f5fa558dc363b921aa2c10af93
Author: Tomaž Vajngerl
AuthorDate: Wed Jan 15 10:32:42 2020 +0100
Commit: Michael Meeks
CommitDate: Thu Jan 16 00:58:57 2020 +0100
android: improve clipboard, inter-document copy/paste possible
In andorid app, we just supported html or text to be copied between
applications (inside the document the copy/paste is handeled by
the core). The biggest problem with this is that copying between
documents doesn't work or works just as good as our HTML support
is. With this change, we get all the clipboard content after copy
and serialize it to a file into the cache and if we then paste in
another document, we read the content of the file and paste
without any loss of fidelity.
Change-Id: I3501045ff2e815a7e2f8c6ecce5255511c256ca6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86833
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Michael Meeks
Tested-by: Michael Meeks
diff --git a/android/lib/src/main/cpp/androidapp.cpp
b/android/lib/src/main/cpp/androidapp.cpp
index 1e5a80686..59079d935 100644
--- a/android/lib/src/main/cpp/androidapp.cpp
+++ b/android/lib/src/main/cpp/androidapp.cpp
@@ -338,7 +338,7 @@
Java_org_libreoffice_androidlib_LOActivity_createLOOLWSD(JNIEnv *env, jobject, j
extern "C"
JNIEXPORT void JNICALL
Java_org_libreoffice_androidlib_LOActivity_saveAs(JNIEnv *env, jobject
instance,
-jstring fileUri_, jstring
format_) {
+ jstring fileUri_, jstring
format_) {
const char *fileUri = env->GetStringUTFChars(fileUri_, 0);
const char *format = env->GetStringUTFChars(format_, 0);
@@ -348,6 +348,23 @@ Java_org_libreoffice_androidlib_LOActivity_saveAs(JNIEnv
*env, jobject instance,
env->ReleaseStringUTFChars(format_, format);
}
+extern "C"
+JNIEXPORT void JNICALL
+Java_org_libreoffice_androidlib_LOActivity_postUnoCommand(JNIEnv* pEnv,
jobject instance,
+ jstring command,
jstring arguments, jboolean bNotifyWhenFinished)
+{
+const char* pCommand = pEnv->GetStringUTFChars(command, nullptr);
+const char* pArguments = nullptr;
+if (arguments != nullptr)
+pArguments = pEnv->GetStringUTFChars(arguments, nullptr);
+
+getLOKDocument()->postUnoCommand(pCommand, pArguments,
bNotifyWhenFinished);
+
+pEnv->ReleaseStringUTFChars(command, pCommand);
+if (arguments != nullptr)
+pEnv->ReleaseStringUTFChars(arguments, pArguments);
+}
+
static jstring tojstringAndFree(JNIEnv *env, char *str)
{
if (!str)
@@ -357,51 +374,167 @@ static jstring tojstringAndFree(JNIEnv *env, char *str)
return ret;
}
+const char* copyJavaString(JNIEnv* pEnv, jstring aJavaString)
+{
+const char* pTemp = pEnv->GetStringUTFChars(aJavaString, nullptr);
+const char* pClone = strdup(pTemp);
+pEnv->ReleaseStringUTFChars(aJavaString, pTemp);
+return pClone;
+}
+
extern "C"
-JNIEXPORT jobjectArray JNICALL
-Java_org_libreoffice_androidlib_LOActivity_getClipboardContent(JNIEnv *env,
jobject instance)
+JNIEXPORT jboolean JNICALL
+Java_org_libreoffice_androidlib_LOActivity_getClipboardContent(JNIEnv *env,
jobject instance, jobject lokClipboardData)
{
-const char *mimeTypes[] = { "text/plain;charset=utf-8", "text/html",
nullptr };
+const char** mimeTypes = nullptr;
size_t outCount = 0;
char **outMimeTypes = nullptr;
size_t *outSizes = nullptr;
char **outStreams = nullptr;
+bool bResult = false;
-jobjectArray values =
(jobjectArray)env->NewObjectArray(2,env->FindClass("java/lang/String"),env->NewStringUTF(""));
+jclass jclazz = env->FindClass("java/util/ArrayList");
+jmethodID methodId_ArrayList_Add = env->GetMethodID(jclazz, "add",
"(Ljava/lang/Object;)Z");
+
+jclass class_LokClipboardEntry =
env->FindClass("org/libreoffice/androidlib/lok/LokClipboardEntry");
+jmethodID methodId_LokClipboardEntry_Constructor =
env->GetMethodID(class_LokClipboardEntry, "", "()V");
+jfieldID fieldId_LokClipboardEntry_Mime =
env->GetFieldID(class_LokClipboardEntry , "mime", "Ljava/lang/String;");
+jfieldID fieldId_LokClipboardEntry_Data =
env->GetFieldID(class_LokClipboardEntry, "data", "[B");
+
+jclass class_LokClipboardData = env->GetObjectClass(lokClipboardData);
+jfieldID fieldId_LokClipboardData_clipboardEntries =
env->GetFieldID(class_LokClipboardData ,
[Libreoffice-commits] online.git: android/lib
android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java | 153
--
1 file changed, 74 insertions(+), 79 deletions(-)
New commits:
commit 89a75eee710208f4997d052c272c12c22405496b
Author: Tomaž Vajngerl
AuthorDate: Wed Jan 15 21:08:26 2020 +0100
Commit: Michael Meeks
CommitDate: Thu Jan 16 00:59:15 2020 +0100
android: clipboard is sync. so exec. in the thread is not needed
As we changed the clipboard to be synchronous now, it's not needed
to execute copy/cut/paste actions in a separate thread anymore.
Also change WebView message interception, so we can execute
actions after a we send WebView a message. This is needed when
we copy/cut something and need to push the content to the android
clipboard and clipboard file.
Change-Id: I08b6ee55ca8bd7b958d348e257c19395ea39ac80
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86882
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Michael Meeks
Tested-by: Michael Meeks
diff --git
a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
index 7698c9368..9c7729ef9 100644
--- a/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
+++ b/android/lib/src/main/java/org/libreoffice/androidlib/LOActivity.java
@@ -520,8 +520,11 @@ public class LOActivity extends AppCompatActivity {
public void postMobileMessage(String message) {
Log.d(TAG, "postMobileMessage: " + message);
-if (interceptMsgFromWebView(message)) {
+String[] messageAndParameterArray= message.split(" ", 2); // the
command and the rest (that can potentially contain spaces too)
+
+if (beforeMessageFromWebView(messageAndParameterArray)) {
postMobileMessageNative(message);
+afterMessageFromWebView(messageAndParameterArray);
}
// Going back to document browser on BYE (called when pressing the top
left exit button)
@@ -568,8 +571,7 @@ public class LOActivity extends AppCompatActivity {
/**
* return true to pass the message to the native part or false to block
the message
*/
-boolean interceptMsgFromWebView(String message) {
-String[] messageAndParam = message.split(" ", 2); // the command and
the rest (that can potentially contain spaces too)
+private boolean beforeMessageFromWebView(String[] messageAndParam) {
switch (messageAndParam[0]) {
case "PRINT":
mainHandler.post(new Runnable() {
@@ -589,10 +591,6 @@ public class LOActivity extends AppCompatActivity {
switch (messageAndParam[1]) {
case ".uno:Paste":
return performPaste();
-case ".uno:Copy":
-case ".uno:Cut":
-populateClipboard();
-break;
default:
break;
}
@@ -630,6 +628,23 @@ public class LOActivity extends AppCompatActivity {
return true;
}
+private void afterMessageFromWebView(String[] messageAndParameterArray) {
+switch (messageAndParameterArray[0]) {
+case "uno":
+switch (messageAndParameterArray[1]) {
+case ".uno:Copy":
+case ".uno:Cut":
+populateClipboard();
+break;
+default:
+break;
+}
+break;
+default:
+break;
+}
+}
+
private void initiatePrint() {
PrintManager printManager = (PrintManager)
getSystemService(PRINT_SERVICE);
PrintDocumentAdapter printAdapter = new PrintAdapter(LOActivity.this);
@@ -689,45 +704,39 @@ public class LOActivity extends AppCompatActivity {
/// Needs to be executed after the .uno:Copy / Paste has executed
public final void populateClipboard()
{
-/// FIXME: in theory we can do better with URIs to temporary files and
so on...
-nativeHandler.post(new Runnable() {
-@Override
-public void run() {
-File clipboardFile = new
File(getApplicationContext().getCacheDir(), CLIPBOARD_FILE_PATH);
-if (clipboardFile.exists())
-clipboardFile.delete();
-
-LokClipboardData clipboardData = new LokClipboardData();
-if (!LOActivity.this.getClipboardContent(clipboardData))
-Log.e(TAG, "no clipboard to copy");
-else
-{
-clipboardData.writeToFile(clipboardFile);
-
-String text = clipboardData.getText();
-String html = clipboardData.getHtml();
-
-if (html != null) {
-
[Libreoffice-bugs] [Bug 76644] extended tips missing for menu items
https://bugs.documentfoundation.org/show_bug.cgi?id=76644 Mihkel Tõnnov changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||8148 Keywords|bibisectRequest |bibisected, bisected --- Comment #10 from Mihkel Tõnnov --- (In reply to Mihkel Tõnnov from comment #9) > (In reply to Jan Holesovsky from comment #4) > > Is it possible to bibisect this issue, please? > > Apparently not. The bibisect repos don't seem to include the offline help... I take that back. Using HELP_DEBUG=1 environment variable, I could at least see the placeholders, and see when they disappeared for the menus: 3e850c3ca58c147ee5913f9226fc383257fde14e is the first bad commit source-hash-d7fe5ab30ca9df722eec33d428baedd258075eac commit d7fe5ab30ca9df722eec33d428baedd258075eac Author: Noel Grandin AuthorDate: Thu Aug 1 11:23:58 2013 +0200 Commit: Noel Grandin CommitDate: Mon Aug 12 11:56:36 2013 +0200 convert vcl/menu.hxx from XubString to OUString (second attempt) Change-Id: I579525326be702ffbb57d49970da5804fd2fe12d https://gerrit.libreoffice.org/plugins/gitiles/core/+/d7fe5ab30ca9df722eec33d428baedd258075eac^!/ Not sure if that helps particularly much, though, considering how extended tips currently aren't shown for anything at all and some bigger changes are needed to fix that (bug 120538 / 118148). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118148] [NEWHELP] Handle tags in the UI
https://bugs.documentfoundation.org/show_bug.cgi?id=118148 Mihkel Tõnnov changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=76 ||644 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120538] Extended help and "What's This" does not work anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=120538 Mihkel Tõnnov changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=76 ||644 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76644] extended tips missing for menu items
https://bugs.documentfoundation.org/show_bug.cgi?id=76644 Mihkel Tõnnov changed: What|Removed |Added CC||mihh...@gmail.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||0538 --- Comment #9 from Mihkel Tõnnov --- (In reply to Jan Holesovsky from comment #4) > Is it possible to bibisect this issue, please? Apparently not. The bibisect repos don't seem to include the offline help... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: logerrit
logerrit | 61 +
1 file changed, 33 insertions(+), 28 deletions(-)
New commits:
commit 1e6428deed42a1ede1d5adbef5676438e6e9e898
Author: Guilhem Moulin
AuthorDate: Wed Jan 15 06:00:36 2020 +0100
Commit: Guilhem Moulin
CommitDate: Thu Jan 16 00:01:03 2020 +0100
logerrit setup: refactor key-based SSH handling
* Don't select existing ~/.ssh/id_dsa.pub. Since 7.0 (released
2015-08-11) OpenSSH servers won't accept DSA user keys anyway, so
users have likely rotated their legacy key material by now.
* The pubkey to copy into gerrit is derived from the first existing file
among ~/.ssh/id_ecdsa, ~/.ssh/id_ed25519, and ~/.ssh/id_rsa. These
algorithms are ordered as found in PubkeyAcceptedKeyTypes' default
value as of OpenSSH 8.1. (EC keys are only supported since Gerrit
1.14.) Generate an RSA key when ~/.ssh doesn't exist, as before,
since it's still the default in ssh-keygen(1) from OpenSSH 8.1.
* In the ssh_config(5) stanza, only include the IdentityFile when a
the private key file exists. The private key material might reside
somewhere else, for instance in a smartcard or in an external agent's
key store; in both cases the ssh client can authenticate the user
without direct access to the key material. While it's possible to
set IdentityFile to a pubkey (with IdentitiesOnly={yes,no}) it's not
documented and thus shouldn't be used.
Change-Id: Id73a2798747ce5c394b0cf2d0dc40107a1f2c599
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86858
Reviewed-by: Guilhem Moulin
Tested-by: Guilhem Moulin
diff --git a/logerrit b/logerrit
index 04ce54414904..618686e012bd 100755
--- a/logerrit
+++ b/logerrit
@@ -27,7 +27,9 @@ submit() {
logerrit() {
echo "Host logerrit gerrit.libreoffice.org"
-echo "IdentityFile ~/.ssh/id_rsa"
+if test -n "${2-}" && test -f "$HOME/.ssh/id_$2"; then
+echo "IdentityFile ~/.ssh/id_$2"
+fi
echo "User $1"
echo "Port 29418"
echo "HostName gerrit.libreoffice.org"
@@ -82,25 +84,28 @@ case "$1" in
echo "Hit enter to generate an ssh key - you will need to enter a
pass-phrase"
echo
read
- ssh-keygen -t rsa -f "$ssh_home/id_rsa"
- fi
- if test -d $ssh_home; then
- if test -f "$ssh_home/id_rsa.pub"; then
- ssh_key=$(cat $ssh_home/id_rsa.pub);
- elif test -f "$ssh_home/id_dsa.pub"; then
- ssh_key=$(cat $ssh_home/id_dsa.pub);
- fi
+ ssh-keygen -t rsa -f "$ssh_home/id_rsa" # default type as of
OpenSSH 8.1
fi
-echo "Please go to https://gerrit.libreoffice.org/ and:"
-echo "- press the 'register' button in the top right corner"
-echo "- after login set yourself a username (it is recommended to use
your IRC-nick)"
- if test "z$ssh_key" = "z"; then
-echo "- add your public ssh-key into the ssh keys settings."
- else
- echo "- paste the key below into the 'Add SSH Public Key' box."
- echo
- echo "$ssh_key"
- echo
+if test -d "$ssh_home"; then
+# order algos based on the PubkeyAcceptedKeyTypes option from OpenSSH
8.1
+for ssh_key_type in ecdsa ed25519 rsa; do
+pk="$ssh_home/id_${ssh_key_type}.pub"
+ssh_key=""
+if test -f "$pk" && ssh_key="$(< "$pk")" && test -n "$ssh_key";
then
+break
+fi
+done
+fi
+echo "Please go to https://gerrit.libreoffice.org/ and:"
+echo " - press the 'register' button in the top right corner"
+echo " - after login set yourself a username (it is recommended to use
your IRC-nick)"
+ if test -z "$ssh_key"; then
+echo " - add your public ssh-key into the ssh keys settings."
+else
+ echo " - paste the key below into the 'Add SSH Public Key' box."
+echo
+printf '%s\n' "$ssh_key"
+echo
fi
echo
echo "Note that you need to register additional email addresses, if
you want to"
@@ -108,15 +113,15 @@ case "$1" in
echo "invitation mail it sends you."
echo
read -p 'Which user name did you choose? ' GERRITUSER
- if test "z$created_ssh" = "z"; then
-echo
-echo "Please now add the following to your ~/.ssh/config, creating
the file if needed:"
-echo
- logerrit $GERRITUSER
-echo
-else
- echo "Automatically creating your ssh config"
- (logerrit $GERRITUSER) > "$ssh_home/config"
+ if test -z "$created_ssh"; then
+echo
+echo "Please now add the following to your ~/.ssh/config, creating the
file if needed:"
+echo
+logerrit
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sw/source
sw/source/core/frmedt/feshview.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 2a676d8dcf5404a0b82e9d99c66579170b1a8690 Author: Vasily Melenchuk AuthorDate: Fri Jan 3 10:55:05 2020 +0100 Commit: Thorsten Behrens CommitDate: Wed Jan 15 23:56:20 2020 +0100 tdf#128782: sw: set name for draw frame style for text box Since new undo/redo code operates style names instead of pointers, it is important to have all formats with name. Change-Id: Ib91cd13b8a324ae674e9ace9bb5f17e679bd2dab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86162 Reviewed-by: Thorsten Behrens Tested-by: Thorsten Behrens (cherry picked from commit c79dcf98d662e76b1290f8d43c927d1031e94729) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86400 Tested-by: Jenkins diff --git a/sw/source/core/frmedt/feshview.cxx b/sw/source/core/frmedt/feshview.cxx index dca686eae993..598ed442b727 100644 --- a/sw/source/core/frmedt/feshview.cxx +++ b/sw/source/core/frmedt/feshview.cxx @@ -2089,6 +2089,7 @@ bool SwFEShell::ImpEndCreate() text::PositionLayoutDir::PositionInLayoutDirOfAnchor ); // #i44344#, #i44681# - positioning attributes already set pFormat->PosAttrSet(); +pFormat->SetName(GetUniqueShapeName()); SwDrawContact *pContact = new SwDrawContact( pFormat, ); // #i35635# ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - chart2/source
chart2/source/controller/main/ControllerCommandDispatch.cxx | 14
1 file changed, 5 insertions(+), 9 deletions(-)
New commits:
commit 6b9fefa671bb53d4555c8cf68071fc1d78e9246d
Author: Vasily Melenchuk
AuthorDate: Fri Dec 27 14:55:11 2019 +0100
Commit: Thorsten Behrens
CommitDate: Wed Jan 15 23:55:29 2020 +0100
tdf#121458: chart: change "Data Ranges" button enabled condition.
"Data Ranges" button right now enabled if chart has no own table
(as it was before 0074951704022d173a5fdb9df933f47be1dcbb91)
or own table exists and it is possible to create data provider
(LibreOffice will warn later about destroying data table).
Change-Id: If92b0aad8a6099250effdb68022addb277ef4371
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86391
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
(cherry picked from commit 985b76d237b26b428771bfc03d1ef74cdb5d77f0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86402
(cherry picked from commit 46ac8dd2305cea9c618a5a37940a616df265a53f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86540
diff --git a/chart2/source/controller/main/ControllerCommandDispatch.cxx
b/chart2/source/controller/main/ControllerCommandDispatch.cxx
index 031c4e4cf1cf..d60cf7dc4977 100644
--- a/chart2/source/controller/main/ControllerCommandDispatch.cxx
+++ b/chart2/source/controller/main/ControllerCommandDispatch.cxx
@@ -552,13 +552,8 @@ void ControllerCommandDispatch::updateCommandAvailability()
if ( xChartDoc.is() )
{
ChartModel& rModel = dynamic_cast(*xChartDoc);
-Reference< lang::XServiceInfo >
xParentServiceInfo(rModel.getParent(), uno::UNO_QUERY);
-OSL_ENSURE(xParentServiceInfo.is(), "Invalid XServiceInfo");
-if ( xParentServiceInfo.is() )
-{
-css::uno::Reference<
com::sun::star::chart2::XDataProviderAccess > xCreatorDoc(rModel.getParent(),
uno::UNO_QUERY);
-bCanCreateDataProvider = xCreatorDoc.is();
-}
+css::uno::Reference< com::sun::star::chart2::XDataProviderAccess >
xCreatorDoc(rModel.getParent(), uno::UNO_QUERY);
+bCanCreateDataProvider = xCreatorDoc.is();
}
}
@@ -631,8 +626,9 @@ void ControllerCommandDispatch::updateCommandAvailability()
m_aCommandAvailability[ ".uno:FormatChartArea" ] = m_aCommandAvailability[
".uno:DiagramArea" ];
m_aCommandAvailability[ ".uno:FormatLegend" ] = m_aCommandAvailability[
".uno:Legend" ];
-// depending on own data
-m_aCommandAvailability[".uno:DataRanges"] = bIsWritable &&
bModelStateIsValid && !m_apModelState->bHasDataFromPivotTable &&
bCanCreateDataProvider;
+// depending on own data and ability to create new data provider
+m_aCommandAvailability[".uno:DataRanges"] = bIsWritable &&
bModelStateIsValid && !m_apModelState->bHasDataFromPivotTable
+&& ((m_apModelState->bHasOwnData && bCanCreateDataProvider) ||
!m_apModelState->bHasOwnData);
m_aCommandAvailability[ ".uno:DiagramData" ] = bIsWritable &&
bModelStateIsValid && m_apModelState->bHasOwnData && bEnableDataTableDialog;
// titles
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sw/qa sw/source
sw/qa/extras/rtfexport/data/mw00_table_of_contents_templates.doc |binary
sw/qa/extras/rtfexport/rtfexport4.cxx| 14
++
sw/source/filter/ww8/ww8atr.cxx |8 +
3 files changed, 22 insertions(+)
New commits:
commit 23ae7824ccd2df8fad6ee42ba66d2bc9a50843ff
Author: Michael Stahl
AuthorDate: Wed Jan 15 16:17:57 2020 +0100
Commit: Thorsten Behrens
CommitDate: Wed Jan 15 23:51:51 2020 +0100
tdf#129574 sw: fix RTF export of table of contents
The problem is that the hyperlink that starts at the start of the first
paragraph of the ToX content is written to RTF before the TOC field
itself, so the hyperlink contains the entire ToX:
{{\field{\*\fldinst HYPERLINK "#__RefHeading___Toc250984071" }{\fldrslt
{\rtlch\langfe1024 \ltrch\lang1024\loch
{\field{\*\fldinst { TOC \\o "1-3" \\h \\z }}{\fldrslt {1.India\tab 1
This is because the HYPERLINK is written into m_aRun but the TOC into
m_aRunText.
Interestingly StartRun() asserts that m_aRunText should be empty, so we
don't try to change StartURL() to write the HYPERLINK into m_aRunText.
The only function that moves text from m_aRunText to m_aRun is
EndRun(), so wrap the TOC field in StartRun()/EndRun().
This breaks the export of the ToX to DOCX because a mysterious SDT is
no longer written around the field but only the field result, so only do
this for RTF.
Change-Id: I22e45c4a9c9ce6edb2b9114b4a29b2a373ec3284
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86860
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 05d833a26208404e5f2b3d61298a57c9bcc7c1fe)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86872
Reviewed-by: Thorsten Behrens
diff --git a/sw/qa/extras/rtfexport/data/mw00_table_of_contents_templates.doc
b/sw/qa/extras/rtfexport/data/mw00_table_of_contents_templates.doc
new file mode 100644
index ..f0f80543bf4b
Binary files /dev/null and
b/sw/qa/extras/rtfexport/data/mw00_table_of_contents_templates.doc differ
diff --git a/sw/qa/extras/rtfexport/rtfexport4.cxx
b/sw/qa/extras/rtfexport/rtfexport4.cxx
index 4590b7fa0b4e..92b672c88504 100644
--- a/sw/qa/extras/rtfexport/rtfexport4.cxx
+++ b/sw/qa/extras/rtfexport/rtfexport4.cxx
@@ -10,6 +10,7 @@
#include
#include
+#include
#include
#include
@@ -165,6 +166,19 @@ DECLARE_RTFEXPORT_TEST(testParaAdjustDistribute,
"para-adjust-distribute.rtf")
getProperty(getParagraph(2),
"ParaLastLineAdjust")));
}
+DECLARE_RTFEXPORT_TEST(testTdf129574, "mw00_table_of_contents_templates.doc")
+{
+uno::Reference xIndexSupplier(mxComponent,
uno::UNO_QUERY);
+uno::Reference
xIndexes(xIndexSupplier->getDocumentIndexes());
+uno::Reference xTOC(xIndexes->getByIndex(0),
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xTOC.is());
+uno::Reference xTextRange(xTOC->getAnchor());
+// table of contents contains 4 paragraphs
+CPPUNIT_ASSERT_EQUAL(OUString("1.Koffice 1" SAL_NEWLINE_STRING "2.Kword 1"
SAL_NEWLINE_STRING
+ "3.Kspread 1" SAL_NEWLINE_STRING
"4.Kpresenter 1"),
+ xTextRange->getString());
+}
+
DECLARE_RTFEXPORT_TEST(testCjklist34, "cjklist34.rtf")
{
sal_Int16 numFormat = getNumberingTypeOfParagraph(1);
diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index dd9bcf6d02ef..9719ba6ae2ff 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -2498,8 +2498,16 @@ void AttributeOutputBase::StartTOX( const SwSection&
rSect )
if (!sStr.isEmpty())
{
GetExport( ).m_bInWriteTOX = true;
+if (GetExport().GetExportFormat() ==
MSWordExportBase::ExportFormat::RTF)
+{ // tdf#129574: required for RTF; doesn't work with DOCX
+StartRun(nullptr, -42, true);
+}
GetExport( ).OutputField( nullptr, eCode, sStr, FieldFlags::Start
| FieldFlags::CmdStart |
FieldFlags::CmdEnd );
+if (GetExport().GetExportFormat() ==
MSWordExportBase::ExportFormat::RTF)
+{
+EndRun(nullptr, -42, true);
+}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: logerrit
logerrit |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 9276b117355c098bdfbe3cfa207aca869bf4bd01 Author: Guilhem Moulin AuthorDate: Wed Jan 15 05:22:20 2020 +0100 Commit: Guilhem Moulin CommitDate: Wed Jan 15 23:51:17 2020 +0100 logerrit: atomically create ~/.ssh with restrictive mode AFAICT `mkdir [-m mode]` is already defined in POSIX.1-1990. Change-Id: I159578eac16398f16d55578fbd818906b77cf373 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86852 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas Reviewed-by: Michael Stahl diff --git a/logerrit b/logerrit index 33f45dc44c73..04ce54414904 100755 --- a/logerrit +++ b/logerrit @@ -76,8 +76,7 @@ case "$1" in created_ssh= if ! test -d $ssh_home; then echo "It appears that you have no ssh setup, running ssh-keygen to create that:" - mkdir $ssh_home - chmod 0700 $ssh_home + mkdir -m0700 "$ssh_home" created_ssh=TRUE echo echo "Hit enter to generate an ssh key - you will need to enter a pass-phrase" ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129924] Writer: DOCX: font color is not white
https://bugs.documentfoundation.org/show_bug.cgi?id=129924 Commit Notification changed: What|Removed |Added Whiteboard||target:6.5.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129924] Writer: DOCX: font color is not white
https://bugs.documentfoundation.org/show_bug.cgi?id=129924 --- Comment #4 from Commit Notification --- Serge Krot committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9476dfe7d1b86b367966e7dedf67e11936c8d9d7 tdf#129924 docx import: set background color It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/ww8atr.cxx | 16
1 file changed, 16 insertions(+)
New commits:
commit 9476dfe7d1b86b367966e7dedf67e11936c8d9d7
Author: Serge Krot
AuthorDate: Fri Jan 10 14:44:25 2020 +0100
Commit: Thorsten Behrens
CommitDate: Wed Jan 15 23:48:28 2020 +0100
tdf#129924 docx import: set background color
Change-Id: If586a7a11e375c1592253630af87772bca40b52e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86542
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index 9e8d815d7de2..813ace50c4fc 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -256,6 +256,22 @@ void MSWordExportBase::ExportPoolItemsToCHP(
ww8::PoolItems , sal_uInt16
AttrOutput().OutputItem( fontHeight );
}
+ else if (nWhich == RES_CHRATR_COLOR)
+ {
+const SvxBrushItem& rBrushColor = static_cast(*pItem);
+const SfxPoolItem* pBackgroundItem = SearchPoolItems(rItems,
RES_CHRATR_BACKGROUND);
+if (rBrushColor.GetColor() == COL_AUTO && pBackgroundItem)
+{
+const SvxBrushItem& rBrushBackground = static_cast(*pBackgroundItem);
+SvxBrushItem
aForeground(rBrushBackground.GetColor().IsDark() ? COL_WHITE : COL_BLACK,
RES_CHRATR_COLOR);
+AttrOutput().OutputItem(aForeground);
+}
+else
+{
+// default
+AttrOutput().OutputItem( *pItem );
+}
+ }
else
{
AttrOutput().OutputItem( *pItem );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 129987] It is no longer possible to copy from another program into LibreOffice under Windows 10.
https://bugs.documentfoundation.org/show_bug.cgi?id=129987 --- Comment #3 from Nicholas F. Peters --- (In reply to Dieter Praas from comment #1) > Nicholas, which version of Windows 10 and which version of LO do you use? > > => NEEDINFO The latest version of Windows 10 is being used. The version of LO is 6.3. I provided detailed testing information with the bug report. This is happening due to changes in Windows 10. The wrong functions are being used to access the clip board. Microsoft warned programmers that older functions would not continue to work. The other comments that have been made reference a different problem. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130026] MS Office PPTX file open does not display properly
https://bugs.documentfoundation.org/show_bug.cgi?id=130026 Imre Mester changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |mesterimr...@gmail.com |desktop.org | CC||mesterimr...@gmail.com --- Comment #1 from Imre Mester --- Created attachment 157170 --> https://bugs.documentfoundation.org/attachment.cgi?id=157170=edit slip into each other -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130026] New: MS Office PPTX file open does not display properly
https://bugs.documentfoundation.org/show_bug.cgi?id=130026 Bug ID: 130026 Summary: MS Office PPTX file open does not display properly Product: LibreOffice Version: 6.1.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mesterimr...@gmail.com Description: Some „TextShape” and „Bitmap” problem. Slip into each other. Steps to Reproduce: 1. Open Microsoft OOXML(PPTX) file 2. 3. Actual Results: Nothing. Expected Results: Nothing. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: The current Development version same as. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105988] Improve help for "Eliminate Points" in section "Edit Points Bar"
https://bugs.documentfoundation.org/show_bug.cgi?id=105988 Gerhard Weydt changed: What|Removed |Added CC||gerhard.we...@t-online.de --- Comment #3 from Gerhard Weydt --- Bug #130024 deals with similar issues. To relieve possible problems because of the german text I offer a new help text based on the german statement by Armin LeGrand. My proposition for a new help text: This seems to applicable only to polygon shapes. If you switch on this mode, then you can eliminate points by dragging them near to the imaginary straight line between its two neighbouring points. Phantom lines from the point you drag to its neighbours are shown while the point is dragged, and these snap into one straight line if the point is dragged sufficiently near to this line. If you then release the mouse button, then the point will be deleted. The mode will be still active, hence you can eliminate other points, if you wish to. Leave this mode by again clicking on the symbol. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130025] New: Will not print PDF snap shots using .odt document.
https://bugs.documentfoundation.org/show_bug.cgi?id=130025 Bug ID: 130025 Summary: Will not print PDF snap shots using .odt document. Product: LibreOffice Version: 6.2.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pic1...@yahoo.com Description: When I take a "Snap shot" from a Adobe reader PDF document, and paste it in a writer document, it shows up fine. When I go to print this document, either to a printer, or a Foxit reader PDF printer driver, those portions that were inserted from the adobe snapshot window,show up blank. I know it's a bug, I found a work around it. Save the document as .DOC and then everything works as it should. Steps to Reproduce: 1.Please see disc above. 2. 3. Actual Results: I can send you the document in .odt and you won't be able to print it. Expected Results: Unless you do a save as " .doc" type and then you can print it. Reproducible: Always User Profile Reset: No Additional Info: Version: 6.2.5.2 (x64) Build ID: 1ec314fa52f458adc18c4f025c545a4e8b22c159 CPU threads: 8; OS: Windows 6.1; UI render: GL; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105988] Improve help for "Eliminate Points" in section "Edit Points Bar"
https://bugs.documentfoundation.org/show_bug.cgi?id=105988 Gerhard Weydt changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||0024 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130024] Many wrong statements in help page for toolbar "Edit Points"
https://bugs.documentfoundation.org/show_bug.cgi?id=130024 Gerhard Weydt changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||5988 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130024] New: Many wrong statements in help page for toolbar "Edit Points"
https://bugs.documentfoundation.org/show_bug.cgi?id=130024 Bug ID: 130024 Summary: Many wrong statements in help page for toolbar "Edit Points" Product: LibreOffice Version: 6.3.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gerhard.we...@t-online.de CC: olivier.hal...@libreoffice.org Created attachment 157169 --> https://bugs.documentfoundation.org/attachment.cgi?id=157169=edit document to facitate testing This will be a lengthy description, because there are many wrong statements. The help page is found in file:///C:/Program%20Files/LibreOffice/help/en-GB/text/shared/main0227.html?DbPAR=SHARED#bm_id3149987 on my WWindoe´ws system or in https://help.libreoffice.org/6.2/en-US/text/shared/main0227.html?DbPAR=SHARED via Internet search, for example. Main problem is the section "Convert To Curve". I have to pick individual sentences and comment them. The attached test document makes it easy to reproduce the described results, it contains a Bézier curve with some straight elements, and a polygon, if you wish to have another test case. Activate the point mode by clicking on "Points" in the Standard toolbar or using F8 for all the subsequent tests. And set the option to show all control points via Tools -> Options -> LibreOffice Draw -> View -> All control points in Bézier editor, because then you can see directly where the change to a curve has happened, without having to click at each curve point. I first diecuss the problematic sentences, then offer a new text: "If you select a single point, the curve before the point will be converted." This should read: "...curve _after_ the point...". To check: Select e.g. the point numbered 3, its colour will change to a light red ( I hope this is independent from the operation system), then click on the symbol "Convert to Curve". Use "Undo" afterwards to revert to the previous situation, that makes the following tests easier. Next sentence: "If two points are selected, the curve between both points will be converted." Wrong: Select points 3 and 4 and use again "Convert to Curve": the two sections after these points will be converted. And use Undo afterwards. Next sentence: "If you select more than two points, each time that you click this icon, a different portion of the curve will be converted." In all my tests, with one exemption I cannot reproduce, _all_ portions or segments were converted. Test it by selecting points 3, 5 and 6, e.g. Next sentence: "If necessary, round points are converted into corner points and corner points are converted into round points." "round points" is a term not used in the tool bar; if it means smooth an d syyymetruic, then the first part is correct, the second part isn't: when converting straight line into curves the angle at the points is kept. Next sentences: "If a certain section of the curve is straight, the end points of the line have a maximum of one control point each. They cannot be modified to round points unless the straight line is converted back to a curve." The second sentence is definitively wrong, you can convert these points to corner points, smooth transition and symmetric transition. Without the second sentence the first has no relevance, too. So here is my proposal: Converts a curve (as part of a polygon or Bézier shape) into a straight line or converts a straight line into a curve. If you select a single point, the curve after the point will be converted. If you select more than one point, the curves after each of these curves will be converted. When converting to straight lines, the points will normally be converted to corner points. There is another bug #105988 dealing with similar problems which should be tackled in conjunction with this one. And a minor issue is that in the first sentence of the named page "...select a polygon object ..." there should be added "or Bézier shape". -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130004] Navigator mode can no longer be set from its Navigation dialog, entangled with Findbar 'navigate by' droplist--affected by position of the dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=130004 --- Comment #10 from Jim Raykowski --- Created attachment 157168 --> https://bugs.documentfoundation.org/attachment.cgi?id=157168=edit Navigation popup window (In reply to sdc.blanco from comment #5) > (In reply to Jim Raykowski from comment #4) > > I noticed buggy behavior of the Navigation toolbox popup for all vcl > > backends a short time ago. > You mean "Navigator" (F5)? > I've attached a picture of the Navigation popup window that contains a toolbox control . code for this is here: https://opengrok.libreoffice.org/xref/core/sw/source/uibase/inc/workctrl.hxx?r=d5d99478#88 HTH -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf94801.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport11.cxx |7 +++
sw/qa/extras/ooxmlexport/ooxmlexport14.cxx |5 +
sw/qa/extras/ooxmlexport/ooxmlexport8.cxx|6 +++---
sw/qa/extras/rtfimport/rtfimport.cxx |2 +-
writerfilter/source/dmapper/ConversionHelper.cxx |9 +
writerfilter/source/dmapper/ConversionHelper.hxx |1 +
writerfilter/source/dmapper/DomainMapperTableManager.cxx |8 ++--
8 files changed, 32 insertions(+), 6 deletions(-)
New commits:
commit 62d084d50c0e6c90918f687251ffbb15264d7317
Author: László Németh
AuthorDate: Tue Jan 14 12:56:54 2020 +0100
Commit: László Németh
CommitDate: Wed Jan 15 22:26:32 2020 +0100
tdf#94801 DOCX import: fix table width loss by rounding
up the converted sum of table grid values. Small table
width loss (< 1/100 mm) could result big layout differences,
based on different line breaking etc.
When table width is calculated by sum of table grid widths,
now there is only a single conversion to 1/100 mm at the end,
with rounding up the width instead of rounding down.
Preventing regressions, both grid and cell width values are
stored in the original twip now, instead of converting them to
1/100 mm one by one.
Change-Id: I6f0755b6604f4976b8ecb25255c76fe6afd5e35b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86718
Reviewed-by: László Németh
Tested-by: László Németh
diff --git a/sw/qa/extras/ooxmlexport/data/tdf94801.docx
b/sw/qa/extras/ooxmlexport/data/tdf94801.docx
new file mode 100644
index ..bdbd3f5e5400
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf94801.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
index a20612f1f2a6..36b4a8331466 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
@@ -327,6 +327,13 @@ DECLARE_OOXMLEXPORT_TEST(testTdf117988, "tdf117988.docx")
CPPUNIT_ASSERT_EQUAL(1, getPages());
}
+DECLARE_OOXMLEXPORT_TEST(testTdf94801, "tdf94801.docx")
+{
+// This was a 2-page document with unwanted line breaking in table cells,
because
+// the table was narrower, than defined (< 1/100 mm loss during twip to
1/100 mm conversion)
+CPPUNIT_ASSERT_EQUAL(1, getPages());
+}
+
DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testParagraphSplitOnSectionBorder,
"parasplit-on-section-border.odt")
{
xmlDocPtr pXmlDoc = parseExport("word/document.xml");
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
index 46e06d7fb85b..61f3a2ab60a7 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
@@ -197,6 +197,11 @@ DECLARE_OOXMLEXPORT_TEST(testTdf124367, "tdf124367.docx")
uno::UNO_QUERY);
uno::Reference xTextTable(xTables->getByIndex(0),
uno::UNO_QUERY);
uno::Reference xTableRows = xTextTable->getRows();
+
+// import is still good, FIXME the export
+if (mbExported)
+ return;
+
// it was 2761 at the first import, and 2760 at the second import, due to
incorrect rounding
CPPUNIT_ASSERT_EQUAL(static_cast(2762),
getProperty>(
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport8.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport8.cxx
index 11893cd4d6b4..8972bb3fddd0 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport8.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport8.cxx
@@ -890,7 +890,7 @@ DECLARE_OOXMLEXPORT_TEST(testFdo59273, "fdo59273.docx")
uno::Reference
xTables(xTablesSupplier->getTextTables( ), uno::UNO_QUERY);
uno::Reference xTextTable(xTables->getByIndex(0),
uno::UNO_QUERY);
// Was 115596 (i.e. 10 times wider than necessary), as w:tblW was missing
and the importer didn't set it.
-CPPUNIT_ASSERT_EQUAL(sal_Int32(12961), getProperty(xTextTable,
"Width"));
+CPPUNIT_ASSERT_EQUAL(sal_Int32(12963), getProperty(xTextTable,
"Width"));
uno::Reference xTableRows = xTextTable->getRows();
// Was 9997, so the 4th column had ~zero width
@@ -1022,7 +1022,7 @@ DECLARE_OOXMLEXPORT_TEST(testTableAutoColumnFixedSize2,
"table-auto-column-fixed
uno::Reference
xTables(xTablesSupplier->getTextTables(), uno::UNO_QUERY);
uno::Reference xTextTable(xTables->getByIndex(0),
uno::UNO_QUERY);
// This was 17907, i.e. the sum of the width of the 3 cells (10152 twips
each), which is too wide.
-CPPUNIT_ASSERT_EQUAL(sal_Int32(16891), getProperty(xTextTable,
"Width"));
+CPPUNIT_ASSERT_EQUAL(sal_Int32(16893), getProperty(xTextTable,
"Width"));
}
DECLARE_OOXMLEXPORT_TEST(testFdo46361, "fdo46361.docx")
@@ -1068,7 +1068,7 @@ DECLARE_OOXMLEXPORT_TEST(testFdo66474, "fdo66474.docx")
// The table width was too
[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=10 Bug 10 depends on bug 94801, which changed state. Bug 94801 Summary: Fileopen: Text different width in Writer (multiple lines) and Word (single line) for Microsoft fonts - 0,1cm difference https://bugs.documentfoundation.org/show_bug.cgi?id=94801 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129979] LibreOffice Online feature request: send postMessage when user clicks cancel on password protected files
https://bugs.documentfoundation.org/show_bug.cgi?id=129979 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Product|LibreOffice |LibreOffice Online Component|LibreOffice |LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130006] Docker images are not tagged with a version number for LibreOffice Online
https://bugs.documentfoundation.org/show_bug.cgi?id=130006 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru, ||cl...@documentfoundation.or ||g --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- cloph, what will you say abot it? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129999] Version Number did not change after upgrade
https://bugs.documentfoundation.org/show_bug.cgi?id=12 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- (In reply to masu from comment #0) > first i changed the OS to Catalina (64bit) > second i installed LO Version 6.3.4.2 over 5.2.7 > So, what can i do? > > Greetings MaSu Please attach a screenshot from Finder here where we'll see installed LibreOffice You can just delete all LibreOffice from Program in Finder and then try install LibreOffice again -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130018] Space in the word York as Y ork in Calc, using Arial font
https://bugs.documentfoundation.org/show_bug.cgi?id=130018 --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- Created attachment 157167 --> https://bugs.documentfoundation.org/attachment.cgi?id=157167=edit Comparise Excel vs Calc (no difference for me) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang include/sfx2 sfx2/source
compilerplugins/clang/constantparam.numbers.results |4
include/sfx2/tbxctrl.hxx| 57 -
sfx2/source/appl/module.cxx |1
sfx2/source/control/bindings.cxx|2
sfx2/source/toolbox/tbxitem.cxx | 228
5 files changed, 3 insertions(+), 289 deletions(-)
New commits:
commit 32c8e953662fa2cdbcf2a43f7c217f75b5a808c8
Author: Caolán McNamara
AuthorDate: Wed Jan 15 19:36:29 2020 +
Commit: Caolán McNamara
CommitDate: Wed Jan 15 22:12:17 2020 +0100
SfxPopupWindow is now unused
Change-Id: Idd4f2854eb0746a0648df30a5815bfaf8ef6a9ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86879
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/compilerplugins/clang/constantparam.numbers.results
b/compilerplugins/clang/constantparam.numbers.results
index ef6f9ae21d47..876f8da673f5 100644
--- a/compilerplugins/clang/constantparam.numbers.results
+++ b/compilerplugins/clang/constantparam.numbers.results
@@ -822,10 +822,6 @@ include/sfx2/tabdlg.hxx:46
void SfxTabDialogItem::SfxTabDialogItem(unsigned short,const class
SfxItemSet &)
unsigned short nId
11022
-include/sfx2/tbxctrl.hxx:88
-void SfxPopupWindow::SfxPopupWindow(unsigned short,class vcl::Window
*,const class com::sun::star::uno::Reference &,long)
-long nBits
-1610612810
include/sfx2/templatelocalview.hxx:228
class BitmapEx SfxTemplateLocalView::fetchThumbnail(const class
rtl::OUString &,long,long)
long height
diff --git a/include/sfx2/tbxctrl.hxx b/include/sfx2/tbxctrl.hxx
index 5503aaae997d..f12878564e87 100644
--- a/include/sfx2/tbxctrl.hxx
+++ b/include/sfx2/tbxctrl.hxx
@@ -24,9 +24,9 @@
#include
#include
#include
-#include
#include
#include
+#include
namespace com::sun::star::frame { class XDispatchProvider; }
namespace com::sun::star::frame { class XFrame; }
@@ -53,54 +53,6 @@ struct SfxTbxCtrlFactory
};
-/* Floating windows that can be torn from tool boxes should be derived from
- this class. Since it is also derived from SfxControllerItem, its instances
- will also receive the StateChanged calls.
-*/
-class SfxFrameStatusListener;
-class SFX2_DLLPUBLIC SfxPopupWindow: public FloatingWindow
-{
-friend class SfxFrameStatusListener;
-bool m_bFloating;
-Link m_aDeleteLink;
-sal_uInt16 const m_nId;
-css::uno::Reference< css::frame::XFrame > constm_xFrame;
-rtl::Reference m_xStatusListener;
-
-private:
-SfxPopupWindow(SfxPopupWindow const &) = delete;
-SfxPopupWindow& operator =(SfxPopupWindow const &) = delete;
-void Delete();
-
-protected:
-virtual voidPopupModeEnd() override;
-virtual boolClose() override;
-
-sal_uInt16 GetId() const { return m_nId; }
-const css::uno::Reference< css::frame::XFrame >& GetFrame() const { return
m_xFrame; }
-
-voidAddStatusListener( const OUString& rCommandURL );
-
-virtual voidstatusChanged( const
css::frame::FeatureStateEvent& rEvent );
-
-public:
-SfxPopupWindow(sal_uInt16 nId, vcl::Window
*pParent,
-const css::uno::Reference<
css::frame::XFrame >& rFrame,
-WinBits nBits );
-SfxPopupWindow(sal_uInt16 nId, vcl::Window
*pParent,
- const OString& rID, const OUString&
rUIXMLDescription,
- const
css::uno::Reference =
-
css::uno::Reference());
-virtual ~SfxPopupWindow() override;
-virtual voiddispose() override;
-
-SAL_DLLPRIVATE void SetDeleteLink_Impl( const Link&
rLink )
-{
-m_aDeleteLink = rLink;
-}
-};
-
-
#define SFX_DECL_TOOLBOX_CONTROL() \
static SfxToolBoxControl* CreateImpl( sal_uInt16 nSlotId, sal_uInt16
nId, ToolBox ); \
static void RegisterControl(sal_uInt16 nSlotId = 0, SfxModule
*pMod=nullptr)
@@ -117,15 +69,11 @@ public:
struct SfxToolBoxControl_Impl;
class SFX2_DLLPUBLIC SfxToolBoxControl: public svt::ToolboxController
{
-friend class SfxPopupWindow;
friend struct SfxTbxCtrlFactory;
std::unique_ptr< SfxToolBoxControl_Impl>pImpl;
protected:
-DECL_LINK( PopupModeEndHdl, FloatingWindow*, void );
-DECL_LINK( ClosePopupWindow, SfxPopupWindow *, void );
-
// old SfxToolBoxControl methods
virtual void StateChanged( sal_uInt16 nSID, SfxItemState
eState, const SfxPoolItem* pState );
virtual void Select( sal_uInt16
[Libreoffice-bugs] [Bug 130018] Space in the word York as Y ork in Calc, using Arial font
https://bugs.documentfoundation.org/show_bug.cgi?id=130018 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||79045_79...@mail.ru Ever confirmed|0 |1 --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Can you attach a screenshot with that problem. ANd please write info from Help->About dialog here -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130004] Navigator mode can no longer be set from its Navigation dialog, entangled with Findbar 'navigate by' droplist--affected by position of the dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=130004 V Stuart Foote changed: What|Removed |Added Summary|Navigator mode can no |Navigator mode can no |longer be set from its |longer be set from its |Navigation dialog, |Navigation dialog, |entangled with Findbar |entangled with Findbar |'navigate by' droplist |'navigate by' ||droplist--affected by ||position of the dialog -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130004] Navigator mode can no longer be set from its Navigation dialog, entangled with Findbar 'navigate by' droplist
https://bugs.documentfoundation.org/show_bug.cgi?id=130004 V Stuart Foote changed: What|Removed |Added CC||caol...@redhat.com, ||qui...@gmail.com, ||t...@libreoffice.org --- Comment #9 from V Stuart Foote --- Hmm, this is weird! If the Navigator's pop-up dialog 'Navigation' is positioned over the docked Navigator's deck (Sidebar or the instance) the mode changes will not take--though they can be set from the Findbar 'Navigate by' droplist. But if the 'Navigation' dialog pop-up toolbox is dragged off of the docked Sidebar, its controls and ability to select Navigator's mode will enable. Also occurs if either of the Navigator decks are undocked. The default location where the 'Navigation' toolbox opens is non-functional. Dragging it to a new position restores function of the dialog. I don't think this is desirable. But I guess there is some sense to the Findbar and the Natigator modes being bound. This has been a recent regression in the UI, unfortunately with backport to 6.4.0, as set out in the cgit ranges above. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source sw/uiconfig
sw/source/uibase/inc/navipi.hxx | 13 -
sw/source/uibase/inc/workctrl.hxx| 37 +-
sw/source/uibase/ribbar/workctrl.cxx | 245 +--
sw/source/uibase/utlui/navipi.cxx| 74 +
sw/uiconfig/swriter/ui/floatingnavigation.ui | 341 +--
5 files changed, 521 insertions(+), 189 deletions(-)
New commits:
commit 33baa14a1130aed90c232231a1b5fd9120737b96
Author: Caolán McNamara
AuthorDate: Wed Jan 15 14:26:24 2020 +
Commit: Caolán McNamara
CommitDate: Wed Jan 15 20:43:10 2020 +0100
rework SwScrollNaviPopup to be a simple popdown
this has never worked right for me, it appears and disappears immediately
under gtk3,
automatically turns into a floating window under gen
rework it to be a simpler non-floating popdown
Change-Id: I3d13ddf81c22e0fb9616defd7d0435e9116c0ac7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86874
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/uibase/inc/navipi.hxx b/sw/source/uibase/inc/navipi.hxx
index 967bdc805161..7bee0d2e0197 100644
--- a/sw/source/uibase/inc/navipi.hxx
+++ b/sw/source/uibase/inc/navipi.hxx
@@ -38,8 +38,9 @@ class SwNavigationPI;
class SwNavigationChild;
class SfxBindings;
class NumEditAction;
-class SwView;
class SwNavigationConfig;
+class SwScrollNaviPopup;
+class SwView;
class SfxObjectShellLock;
class SfxChildWindowContext;
enum class RegionMode;
@@ -48,7 +49,6 @@ class SpinField;
class SwNavHelpToolBox : public ToolBox
{
VclPtr m_xDialog;
-virtual voidMouseButtonDown(const MouseEvent ) override;
virtual voidRequestHelp( const HelpEvent& rHEvt ) override;
virtual voiddispose() override;
public:
@@ -86,8 +86,7 @@ class SwNavigationPI : public PanelLayout,
SwWrtShell *m_pContentWrtShell;
SwView *m_pActContView;
SwView *m_pCreateView;
-VclPtr m_pPopupWindow;
-VclPtr m_pFloatingWindow;
+VclPtr m_xPopupWindow;
SwNavigationConfig *m_pConfig;
SfxBindings _rBindings;
@@ -114,11 +113,9 @@ class SwNavigationPI : public PanelLayout,
DECL_LINK( MenuSelectHdl, Menu *, bool );
DECL_LINK( ChangePageHdl, Timer*, void );
DECL_LINK( PageEditModifyHdl, SpinField&, void );
-DECL_LINK( PopupModeEndHdl, FloatingWindow*, void );
-DECL_LINK( ClosePopupWindow, SfxPopupWindow *, void );
void UsePage();
-void SetPopupWindow( SfxPopupWindow* );
+void SetPopupWindow( SwScrollNaviPopup* );
protected:
@@ -156,7 +153,7 @@ public:
boolIsGlobalMode() const {returnm_bGlobalMode;}
SwView* GetCreateView() const;
-voidCreateNavigationTool(const tools::Rectangle& rRect, bool
bSetFocus, vcl::Window *pParent);
+voidCreateNavigationTool();
FactoryFunction GetUITestFactory() const override;
};
diff --git a/sw/source/uibase/inc/workctrl.hxx
b/sw/source/uibase/inc/workctrl.hxx
index 6aa03352bd94..80c9fa157592 100644
--- a/sw/source/uibase/inc/workctrl.hxx
+++ b/sw/source/uibase/inc/workctrl.hxx
@@ -50,6 +50,8 @@ class SwView;
#define NID_TABLE_FORMULA_ERROR 20019
#define NID_COUNT 20
+#define NID_LINE_COUNT 10
+
class SwTbxAutoTextCtrl : public SfxToolBoxControl
{
public:
@@ -66,29 +68,16 @@ public:
DECL_STATIC_LINK(SwTbxAutoTextCtrl, PopupHdl, Menu*, bool);
};
-class SwScrollNaviPopup;
-
-class SwScrollNaviToolBox : public ToolBox
+class SwScrollNaviPopup : public DockingWindow
{
-VclPtr m_pNaviPopup;
-
-virtual voidMouseButtonUp( const MouseEvent& rMEvt ) override;
-virtual voidRequestHelp( const HelpEvent& rHEvt ) override;
-
-public:
-SwScrollNaviToolBox(vcl::Window* pParent, SwScrollNaviPopup* pNaviPopup,
WinBits nWinStyle)
-: ToolBox(pParent, nWinStyle)
-, m_pNaviPopup(pNaviPopup)
-{
-}
-virtual ~SwScrollNaviToolBox() override;
-virtual void dispose() override;
-};
+VclPtr m_xToolBox1;
+VclPtr m_xToolBox2;
+VclPtr m_xInfoField;
-class SwScrollNaviPopup : public SfxPopupWindow
-{
-VclPtr m_pToolBox;
-VclPtr m_pInfoField;
+sal_uInt16 GetCurItemId() const;
+OUString GetItemText(sal_uInt16 nItemId) const;
+void SetItemText(sal_uInt16 nItemId, const OUString& rText);
+void CheckItem(sal_uInt16 nItemId, bool bOn);
OUStringsQuickHelp[2 * NID_COUNT];
@@ -96,15 +85,15 @@ protected:
DECL_LINK(SelectHdl, ToolBox*, void);
public:
-SwScrollNaviPopup( sal_uInt16 nId, const css::uno::Reference<
css::frame::XFrame >& rFrame, vcl::Window *pParent );
+SwScrollNaviPopup(vcl::Window *pParent);
virtual ~SwScrollNaviPopup() override;
virtual void dispose() override;
static OUString GetToolTip(bool bNext);
-voidGrabFocus() { m_pToolBox->GrabFocus(); }
+voidGrabFocus() {
[Libreoffice-commits] core.git: include/sfx2 include/svx sfx2/source svx/source sw/source
include/sfx2/tbxctrl.hxx |2 +-
include/svx/clipboardctl.hxx |2 +-
sfx2/source/toolbox/tbxitem.cxx | 11 +++
svx/source/mnuctrls/clipboardctl.cxx |5 +
sw/source/uibase/inc/workctrl.hxx|2 +-
sw/source/uibase/ribbar/workctrl.cxx |3 +--
6 files changed, 8 insertions(+), 17 deletions(-)
New commits:
commit 160cde8ec0473b4a0c8e15ee13520d83171aea8d
Author: Caolán McNamara
AuthorDate: Wed Jan 15 13:24:50 2020 +
Commit: Caolán McNamara
CommitDate: Wed Jan 15 20:29:35 2020 +0100
no remaining CreatePopupWindow returns non-null
Change-Id: Ie342bd24222f622997d8dc2cda51ecb908fdb047
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86843
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/include/sfx2/tbxctrl.hxx b/include/sfx2/tbxctrl.hxx
index cb94907ffae9..5503aaae997d 100644
--- a/include/sfx2/tbxctrl.hxx
+++ b/include/sfx2/tbxctrl.hxx
@@ -132,7 +132,7 @@ protected:
virtual void DoubleClick();
virtual void Click();
-virtual VclPtr CreatePopupWindow();
+virtual void CreatePopupWindow();
virtual VclPtr CreateItemWindow( vcl::Window *pParent );
// Must be called by subclass to set a new popup window instance
diff --git a/include/svx/clipboardctl.hxx b/include/svx/clipboardctl.hxx
index 76182554f19a..ec805c95896f 100644
--- a/include/svx/clipboardctl.hxx
+++ b/include/svx/clipboardctl.hxx
@@ -46,7 +46,7 @@ public:
SvxClipBoardControl( sal_uInt16 nSlotId, sal_uInt16 nId, ToolBox& rTbx );
virtual ~SvxClipBoardControl() override;
-virtual VclPtr CreatePopupWindow() override;
+void CreatePopupWindow() override;
virtual voidStateChanged( sal_uInt16 nSID,
SfxItemState eState,
const SfxPoolItem* pState )
override;
diff --git a/sfx2/source/toolbox/tbxitem.cxx b/sfx2/source/toolbox/tbxitem.cxx
index 0e9aba25830f..04cc9dee983c 100644
--- a/sfx2/source/toolbox/tbxitem.cxx
+++ b/sfx2/source/toolbox/tbxitem.cxx
@@ -547,11 +547,8 @@ void SAL_CALL SfxToolBoxControl::doubleClick()
Reference< css::awt::XWindow > SAL_CALL SfxToolBoxControl::createPopupWindow()
{
SolarMutexGuard aGuard;
-VclPtr pWindow = CreatePopupWindow();
-if ( pWindow )
-return VCLUnoHelper::GetInterface( pWindow );
-else
-return Reference< css::awt::XWindow >();
+CreatePopupWindow();
+return nullptr;
}
Reference< css::awt::XWindow > SAL_CALL SfxToolBoxControl::createItemWindow(
const Reference< css::awt::XWindow >& rParent )
@@ -669,10 +666,8 @@ void SfxToolBoxControl::Click()
{
}
-
-VclPtr SfxToolBoxControl::CreatePopupWindow()
+void SfxToolBoxControl::CreatePopupWindow()
{
-return nullptr;
}
VclPtr SfxToolBoxControl::CreateItemWindow( vcl::Window * )
diff --git a/svx/source/mnuctrls/clipboardctl.cxx
b/svx/source/mnuctrls/clipboardctl.cxx
index f24401e134aa..693b465208e8 100644
--- a/svx/source/mnuctrls/clipboardctl.cxx
+++ b/svx/source/mnuctrls/clipboardctl.cxx
@@ -58,8 +58,7 @@ SvxClipBoardControl::~SvxClipBoardControl()
DelPopup();
}
-
-VclPtr SvxClipBoardControl::CreatePopupWindow()
+void SvxClipBoardControl::CreatePopupWindow()
{
const SvxClipboardFormatItem* pFmtItem =
dynamic_cast( pClipboardFmtItem.get() );
if ( pFmtItem )
@@ -102,10 +101,8 @@ VclPtr
SvxClipBoardControl::CreatePopupWindow()
GetToolBox().EndSelection();
DelPopup();
-return nullptr;
}
-
void SvxClipBoardControl::StateChanged( sal_uInt16 nSID, SfxItemState eState,
const SfxPoolItem* pState )
{
if ( SID_CLIPBOARD_FORMAT_ITEMS == nSID )
diff --git a/sw/source/uibase/inc/workctrl.hxx
b/sw/source/uibase/inc/workctrl.hxx
index b276d9c1ac5c..6aa03352bd94 100644
--- a/sw/source/uibase/inc/workctrl.hxx
+++ b/sw/source/uibase/inc/workctrl.hxx
@@ -58,7 +58,7 @@ public:
SwTbxAutoTextCtrl( sal_uInt16 nSlotId, sal_uInt16 nId, ToolBox& rTbx );
virtual ~SwTbxAutoTextCtrl() override;
-virtual VclPtr CreatePopupWindow() override;
+virtual void CreatePopupWindow() override;
virtual voidStateChanged( sal_uInt16 nSID,
SfxItemState eState,
const SfxPoolItem* pState )
override;
diff --git a/sw/source/uibase/ribbar/workctrl.cxx
b/sw/source/uibase/ribbar/workctrl.cxx
index a7f76cf9aff0..077e987398fc 100644
--- a/sw/source/uibase/ribbar/workctrl.cxx
+++ b/sw/source/uibase/ribbar/workctrl.cxx
@@ -78,7 +78,7 @@ SwTbxAutoTextCtrl::~SwTbxAutoTextCtrl()
{
}
-VclPtr SwTbxAutoTextCtrl::CreatePopupWindow()
+void SwTbxAutoTextCtrl::CreatePopupWindow()
{
SwView* pView = ::GetActiveView();
if(pView && !pView->GetDocShell()->IsReadOnly() &&
@@ -123,7 +123,6 @@ VclPtr
SwTbxAutoTextCtrl::CreatePopupWindow()
[Libreoffice-commits] core.git: framework/source svtools/source
framework/source/uielement/popuptoolbarcontroller.cxx |1 +
svtools/source/uno/popupwindowcontroller.cxx |1 +
2 files changed, 2 insertions(+)
New commits:
commit 7d514150ef7c9a82aa72213ee2973cc8b9b2dbfa
Author: Caolán McNamara
AuthorDate: Wed Jan 15 14:37:10 2020 +
Commit: Caolán McNamara
CommitDate: Wed Jan 15 20:28:34 2020 +0100
hold SolarMutex on calling vcl toolbox enable item
Change-Id: I35bbe90fbda6c46c1ad173746171b3ede1b2105c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86850
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/framework/source/uielement/popuptoolbarcontroller.cxx
b/framework/source/uielement/popuptoolbarcontroller.cxx
index f232abfcb30c..f5b6d5f31695 100644
--- a/framework/source/uielement/popuptoolbarcontroller.cxx
+++ b/framework/source/uielement/popuptoolbarcontroller.cxx
@@ -162,6 +162,7 @@ void SAL_CALL PopupMenuToolbarController::statusChanged(
const css::frame::Featu
sal_uInt16 nItemId = 0;
if ( getToolboxId( nItemId, ) )
{
+SolarMutexGuard aSolarLock;
pToolBox->EnableItem( nItemId, rEvent.IsEnabled );
bool bValue;
if ( rEvent.State >>= bValue )
diff --git a/svtools/source/uno/popupwindowcontroller.cxx
b/svtools/source/uno/popupwindowcontroller.cxx
index a2eb9efc7cfb..a60f06daf5ee 100644
--- a/svtools/source/uno/popupwindowcontroller.cxx
+++ b/svtools/source/uno/popupwindowcontroller.cxx
@@ -202,6 +202,7 @@ void SAL_CALL PopupWindowController::statusChanged( const
frame::FeatureStateEve
sal_uInt16 nItemId = 0;
if ( getToolboxId( nItemId, ) )
{
+SolarMutexGuard aSolarLock;
pToolBox->CheckItem( nItemId, bValue );
pToolBox->EnableItem( nItemId, rEvent.IsEnabled );
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/svx officecfg/registry sc/source sd/source starmath/source svx/source svx/util sw/source
include/svx/lboxctrl.hxx| 30 -
officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu | 22
sc/source/ui/app/scdll.cxx |2
sd/source/ui/app/sddll.cxx |4
starmath/source/smdll.cxx |2
svx/source/tbxctrls/lboxctrl.cxx| 234
--
svx/util/svx.component |4
sw/source/uibase/app/swmodule.cxx |2
8 files changed, 149 insertions(+), 151 deletions(-)
New commits:
commit c34edadf5bd3d1d9f3c9c056af28b8964d8f1ca0
Author: Caolán McNamara
AuthorDate: Wed Jan 15 11:46:00 2020 +
Commit: Caolán McNamara
CommitDate: Wed Jan 15 20:28:50 2020 +0100
rework SvxUndoRedoControl to be a PopupWindowController
Change-Id: I78b4e03c76bc3aa8479013ae157a9e1316dcfecd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86841
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/include/svx/lboxctrl.hxx b/include/svx/lboxctrl.hxx
index 928b81080feb..5aeaf54ee4b3 100644
--- a/include/svx/lboxctrl.hxx
+++ b/include/svx/lboxctrl.hxx
@@ -20,38 +20,36 @@
#ifndef INCLUDED_SVX_LBOXCTRL_HXX
#define INCLUDED_SVX_LBOXCTRL_HXX
-#include
#include
#include
+#include
#include
class ToolBox;
class SvxPopupWindowListBox;
-
-class SVX_DLLPUBLIC SvxUndoRedoControl final : public SfxToolBoxControl
+class SVX_DLLPUBLIC SvxUndoRedoControl final : public
svt::PopupWindowController
{
-OUStringaActionStr;
-VclPtr pPopupWin;
std::vector< OUString > aUndoRedoList;
OUStringaDefaultTooltip;
-voidImpl_SetInfo( sal_Int32 nCount );
+public:
+SvxUndoRedoControl(const css::uno::Reference&
rContext);
+virtual ~SvxUndoRedoControl() override;
-DECL_LINK( PopupModeEndHdl, FloatingWindow*, void );
-DECL_LINK( SelectHdl, ListBox&, void );
+using svt::ToolboxController::createPopupWindow;
+virtual VclPtr createPopupWindow( vcl::Window* pParent )
override;
-public:
-SFX_DECL_TOOLBOX_CONTROL();
+// XServiceInfo
+virtual OUString SAL_CALL getImplementationName() override;
+virtual css::uno::Sequence SAL_CALL getSupportedServiceNames()
override;
-SvxUndoRedoControl( sal_uInt16 nSlotId, sal_uInt16 nId, ToolBox& rTbx );
-virtual ~SvxUndoRedoControl() override;
+// XInitialization
+virtual void SAL_CALL initialize( const css::uno::Sequence< css::uno::Any
>& rArguments ) override;
-virtual void StateChanged( sal_uInt16 nSID,
- SfxItemState eState,
- const SfxPoolItem* pState ) override;
+virtual void SAL_CALL statusChanged(const css::frame::FeatureStateEvent&
rEvent) override;
-virtual VclPtr CreatePopupWindow() override;
+void Do(sal_Int16 nCount);
};
#endif
diff --git a/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu
b/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu
index ec3474f0594c..bad60fb6b38f 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu
@@ -1536,6 +1536,28 @@
com.sun.star.comp.svx.UnderlineToolBoxControl
+
+
+ .uno:Undo
+
+
+
+
+
+ com.sun.star.comp.svx.UndoRedoToolBoxControl
+
+
+
+
+ .uno:Redo
+
+
+
+
+
+ com.sun.star.comp.svx.UndoRedoToolBoxControl
+
+
.uno:XLineColor
diff --git a/sc/source/ui/app/scdll.cxx b/sc/source/ui/app/scdll.cxx
index d3a1bbdc1035..dfcb7d5edc11 100644
--- a/sc/source/ui/app/scdll.cxx
+++ b/sc/source/ui/app/scdll.cxx
@@ -151,8 +151,6 @@ void ScDLL::Init()
SvxStyleToolBoxControl ::RegisterControl(SID_STYLE_APPLY,
pMod);
SvxClipBoardControl ::RegisterControl(SID_PASTE,
pMod );
SvxClipBoardControl ::RegisterControl(SID_PASTE_UNFORMATTED,
pMod );
-SvxUndoRedoControl ::RegisterControl(SID_UNDO,
pMod );
-SvxUndoRedoControl ::RegisterControl(SID_REDO,
pMod );
svx::FormatPaintBrushToolBoxControl::RegisterControl(SID_FORMATPAINTBRUSH,
pMod );
sc::ScNumberFormatControl ::RegisterControl(SID_NUMBER_TYPE_FORMAT,
pMod );
diff --git a/sd/source/ui/app/sddll.cxx b/sd/source/ui/app/sddll.cxx
index e990d56053c9..a4805671b59e 100644
--- a/sd/source/ui/app/sddll.cxx
+++ b/sd/source/ui/app/sddll.cxx
@@ -206,10 +206,6 @@ void SdDLL::RegisterControllers(SdModule* pMod)
SvxModifyControl::RegisterControl( SID_DOC_MODIFIED, pMod );
[Libreoffice-bugs] [Bug 130023] New: No proper spacing between pages in "Continuous mode"
https://bugs.documentfoundation.org/show_bug.cgi?id=130023 Bug ID: 130023 Summary: No proper spacing between pages in "Continuous mode" Product: LibreOffice Version: 3.3.0 release Hardware: All OS: All Status: UNCONFIRMED Severity: trivial Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: peid...@gmail.com Description: By switching to the "Continuous mode" (not sure if it's the official name) - clicking on the space between pages, the LibreOffice Writer displays the pages continuously for easy reading/editing. However, there is absolutely no spacing between the two pages. This becomes a problem when you have some large line spacing set in the paragraphs. Everything will follow the line spacing except when it approaches the page end. I think it makes more sense for this to follow the line spacing as well. Steps to Reproduce: Open a multi-page file formatted with 1.5 lines spacing and switch to continous mode by clicking on the space between pages. There should be some space between the last line on page1 and first line on page2. Actual Results: There is no space. Expected Results: Follows 1.5 lines spacing. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82716] Ability to create histograms directly from data, not using FREQUENCY()
https://bugs.documentfoundation.org/show_bug.cgi?id=82716 Thomas Lendo changed: What|Removed |Added URL|https://help-eset.com | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129715] LibreOffice crash after viewing signed with OpenPGP *.odt file properties
https://bugs.documentfoundation.org/show_bug.cgi?id=129715 --- Comment #6 from lach...@gmail.com --- Created attachment 157166 --> https://bugs.documentfoundation.org/attachment.cgi?id=157166=edit Crash file. Revealed ) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Cannot compile libreoffice online
In order to obtain the correct version of npm, I installed the snap package for
node. I use the channel for version 8.
On January 15, 2020 10:25:11 AM EST, nikkilocke wrote:
>I am trying to compile LibreOffice online on Ubuntu 18.
>I have installed all the packages needed by the configure script
>(including
>having to compile poco from source, as the poco provided by apt-get is
>incompatible with the npm provided by apt-get), and including using npm
>to
>update itself to a more recent version.
>
>Make gives me a __long__ list of error messages when compiling
>kit/ChildSession.cpp. Here are the first few, full log available on
>request:
>
>In file included from kit/ChildSession.cpp:39:0:
>kit/KitHelper.hpp: In function ‘std::__cxx11::string
>LOKitHelper::documentStatus(LibreOfficeKitDocument*)’:
>kit/KitHelper.hpp:71:51: error: ‘LibreOfficeKitDocumentClass {aka
>struct
>_LibreOfficeKitDocumentClass}’ has no member named ‘getPartInfo’; did
>you
>mean ‘getParts’?
> ptrValue =
>loKitDocument->pClass->getPartInfo(loKitDocument, i);
> ^~~
> getParts
>In file included from ./common/Session.hpp:27:0,
> from kit/ChildSession.hpp:24,
> from kit/ChildSession.cpp:12:
>kit/ChildSession.cpp: In member function ‘virtual bool
>ChildSession::_handleInput(const char*, int)’:
>kit/ChildSession.cpp:160:60: error: ‘lokCallbackTypeToString’ was not
>declared in this scope
> <<
>lokCallbackTypeToString(event.getType())
>^
>./common/Log.hpp:285:31: note: in definition of macro ‘LOG_BODY_’
>oss_ << std::boolalpha << X;
>
>\
> ^
>kit/ChildSession.cpp:159:17: note: in expansion of macro ‘LOG_TRC’
> LOG_TRC("Replaying missed view event: " << viewPair.first
><< ' '
> ^~~
>kit/ChildSession.cpp:169:51: error: ‘lokCallbackTypeToString’ was not
>declared in this scope
> LOG_TRC("Replaying missed event: " <<
>lokCallbackTypeToString(event.getType()) << ": "
> ^
>./common/Log.hpp:285:31: note: in definition of macro ‘LOG_BODY_’
>oss_ << std::boolalpha << X;
>
>\
> ^
>kit/ChildSession.cpp:169:13: note: in expansion of macro ‘LOG_TRC’
> LOG_TRC("Replaying missed event: " <<
>lokCallbackTypeToString(event.getType()) << ": "
> ^~~
>kit/ChildSession.cpp:183:21: error: ‘lokCallbackTypeToString’ was not
>declared in this scope
>lokCallbackTypeToString(event.getType()) << ": " <<
>event.getPayload());
> ^
>./common/Log.hpp:285:31: note: in definition of macro ‘LOG_BODY_’
>oss_ << std::boolalpha << X;
>
>\
> ^
>kit/ChildSession.cpp:182:13: note: in expansion of macro ‘LOG_TRC’
> LOG_TRC("Replaying missed event (part of sequence): " <<
> ^~~
>kit/ChildSession.cpp: In member function ‘bool
>ChildSession::outlineState(const char*, int, const
>std::vector >&)’:
>kit/ChildSession.cpp:884:25: error: ‘using element_type = class
>lok::Document {aka class lok::Document}’ has no member named
>‘setOutlineState’
> getLOKitDocument()->setOutlineState(column, level, index, hidden);
> ^~~
>
>Any clues as to what is wrong?
>
>
>
>
>--
>Sent from:
>http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
>___
>LibreOffice mailing list
>LibreOffice@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/libreoffice
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/cont-sect-break-header-footer.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport14.cxx | 26
++
writerfilter/source/dmapper/PropertyMap.cxx | 25
+
3 files changed, 50 insertions(+), 1 deletion(-)
New commits:
commit 9a50e8f2bcde95233e4b38707c521ada90fcd6af
Author: Miklos Vajna
AuthorDate: Wed Jan 15 17:54:52 2020 +0100
Commit: Miklos Vajna
CommitDate: Wed Jan 15 19:55:20 2020 +0100
DOCX import: improve support for headers/footers from cont sect break
A continuous section break in a DOCX file can set new headers/footers
which start appearing from the next page. In general, this is not
something Writer supports, but commit
08f13ab85b5c65b5dc8adfa15918fb3e426fcc3c (tdf#112202 writerfilter,sw:
fix loss of headers, 2019-12-16) improved the situation significantly
here.
Build on top of that and add support for a few more cases:
1) When checking for the last paragraph of the previous section, detect
when that last paragraph is so small so in practice that's not the last
one.
2) Handle when the text node in question has no explicit break type set,
only a SwFormatPageDesc (which implicitly causes a page break).
3) When setting the page style to show the correct header/footer, don't
set the page style on the previous paragraph directly, rather update the
"next style" of the already set page style. (This is safe, as we never
reuse the same Writer page style for multiple Word sections.)
Change-Id: Iede196b864af5123c5637f82432ed6e0f7e7241a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86870
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/qa/extras/ooxmlexport/data/cont-sect-break-header-footer.docx
b/sw/qa/extras/ooxmlexport/data/cont-sect-break-header-footer.docx
new file mode 100644
index ..61c18298d083
Binary files /dev/null and
b/sw/qa/extras/ooxmlexport/data/cont-sect-break-header-footer.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
index bab071d92a54..46e06d7fb85b 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
@@ -279,6 +279,32 @@ DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf77796,
"tdf77796.docx")
assertXPath(pXml, "/w:document/w:body/w:tbl/w:tblPr/w:tblCellMar/w:end",
"w", "108");
}
+DECLARE_OOXMLIMPORT_TEST(testContSectBreakHeaderFooter,
"cont-sect-break-header-footer.docx")
+{
+// Load a document with a continuous section break on page 2.
+CPPUNIT_ASSERT_EQUAL(OUString("First page header, section 1"),
+ parseDump("/root/page[1]/header/txt/text()"));
+CPPUNIT_ASSERT_EQUAL(OUString("First page footer, section 1"),
+ parseDump("/root/page[1]/footer/txt/text()"));
+// Make sure the header stays like this; if we naively just update the
page style name of the
+// first para on page 2, then this would be 'Header, section 2', which is
incorrect.
+CPPUNIT_ASSERT_EQUAL(OUString("First page header, section 2"),
+ parseDump("/root/page[2]/header/txt/text()"));
+CPPUNIT_ASSERT_EQUAL(OUString("First page footer, section 2"),
+ parseDump("/root/page[2]/footer/txt/text()"));
+// This is inherited from page 2.
+CPPUNIT_ASSERT_EQUAL(OUString("Header, section 2"),
+ parseDump("/root/page[3]/header/txt/text()"));
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 1
+// - Actual : 0
+// - xpath should match exactly 1 node
+// i.e. the footer had no text (inherited from page 2), while the correct
behavior is to provide
+// the own footer text.
+CPPUNIT_ASSERT_EQUAL(OUString("Footer, section 3"),
+ parseDump("/root/page[3]/footer/txt/text()"));
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/dmapper/PropertyMap.cxx
b/writerfilter/source/dmapper/PropertyMap.cxx
index c971f229d95e..fd8ad553a18f 100644
--- a/writerfilter/source/dmapper/PropertyMap.cxx
+++ b/writerfilter/source/dmapper/PropertyMap.cxx
@@ -1425,9 +1425,11 @@ void SectionPropertyMap::CloseSectionGroup(
DomainMapper_Impl& rDM_Impl )
}
}
}
+uno::Reference const xPCursor(xCursor,
+
uno::UNO_QUERY_THROW);
+float fCharHeight = 0;
if (!isFound)
{ // HACK: try the last paragraph of the previous section
-uno::Reference const
xPCursor(xCursor, uno::UNO_QUERY_THROW);
xPCursor->gotoPreviousParagraph(false);
[Libreoffice-commits] core.git: sw/source
sw/source/filter/xml/xmlimp.cxx | 65
sw/source/filter/xml/xmlimp.hxx |4 --
2 files changed, 21 insertions(+), 48 deletions(-)
New commits:
commit fd14abf1346128826dcb30dda2cc674cc4d998ce
Author: Noel Grandin
AuthorDate: Wed Jan 15 12:47:06 2020 +0200
Commit: Noel Grandin
CommitDate: Wed Jan 15 19:49:25 2020 +0100
use more FastParser in SwXMLImport
Change-Id: I27207e1ac00d783296deb9b0309b7b62cb5a15eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86837
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/filter/xml/xmlimp.cxx b/sw/source/filter/xml/xmlimp.cxx
index a15cc9f9efb1..9f56a8f2fb06 100644
--- a/sw/source/filter/xml/xmlimp.cxx
+++ b/sw/source/filter/xml/xmlimp.cxx
@@ -190,10 +190,6 @@ protected: // #i69629#
SwXMLImport& GetSwImport() { return
static_cast(GetImport()); }
public:
-
-SwXMLDocContext_Impl( SwXMLImport& rImport, sal_uInt16 nPrfx,
-const OUString& rLName );
-
SwXMLDocContext_Impl( SwXMLImport& rImport );
virtual SvXMLImportContextRef CreateChildContext( sal_uInt16 nPrefix,
@@ -202,16 +198,13 @@ public:
virtual css::uno::Reference< css::xml::sax::XFastContextHandler > SAL_CALL
createFastChildContext(
sal_Int32 nElement, const css::uno::Reference<
css::xml::sax::XFastAttributeList >& xAttrList ) override;
+
+virtual void SAL_CALL startFastElement( sal_Int32 /*nElement*/,
+const css::uno::Reference< css::xml::sax::XFastAttributeList
>& ) override {}
};
}
-SwXMLDocContext_Impl::SwXMLDocContext_Impl( SwXMLImport& rImport,
-sal_uInt16 nPrfx, const OUString& rLName ) :
-SvXMLImportContext( rImport, nPrfx, rLName )
-{
-}
-
SwXMLDocContext_Impl::SwXMLDocContext_Impl( SwXMLImport& rImport ) :
SvXMLImportContext( rImport )
{
@@ -288,6 +281,10 @@ public:
SwXMLOfficeDocContext_Impl( SwXMLImport& rImport,
const Reference< document::XDocumentProperties >& xDocProps);
+virtual void SAL_CALL startFastElement( sal_Int32 nElement,
+const css::uno::Reference< css::xml::sax::XFastAttributeList
>& xAttrList ) override
+{ SvXMLMetaDocumentContext::startFastElement(nElement, xAttrList); }
+
virtual css::uno::Reference< css::xml::sax::XFastContextHandler > SAL_CALL
createFastChildContext(
sal_Int32 nElement, const css::uno::Reference<
css::xml::sax::XFastAttributeList >& Attribs ) override;
};
@@ -333,25 +330,20 @@ class SwXMLDocStylesContext_Impl : public
SwXMLDocContext_Impl
{
public:
-SwXMLDocStylesContext_Impl( SwXMLImport& rImport,
-sal_uInt16 nPrfx,
-const OUString& rLName );
+SwXMLDocStylesContext_Impl( SwXMLImport& rImport );
-virtual void EndElement() override;
+virtual void SAL_CALL endFastElement(sal_Int32 nElement) override;
};
}
-SwXMLDocStylesContext_Impl::SwXMLDocStylesContext_Impl(
-SwXMLImport& rImport,
-sal_uInt16 nPrfx,
-const OUString& rLName ) :
-SvXMLImportContext( rImport, nPrfx, rLName ),
-SwXMLDocContext_Impl( rImport, nPrfx, rLName )
+SwXMLDocStylesContext_Impl::SwXMLDocStylesContext_Impl( SwXMLImport& rImport )
:
+SvXMLImportContext( rImport ),
+SwXMLDocContext_Impl( rImport )
{
}
-void SwXMLDocStylesContext_Impl::EndElement()
+void SwXMLDocStylesContext_Impl::endFastElement(sal_Int32 )
{
// assign paragraph styles to list levels of outline style after all styles
// are imported and finished.
@@ -368,29 +360,6 @@ const SvXMLTokenMap& SwXMLImport::GetDocElemTokenMap()
return *m_pDocElemTokenMap;
}
-SvXMLImportContext *SwXMLImport::CreateDocumentContext(
-sal_uInt16 nPrefix,
-const OUString& rLocalName,
-const Reference< xml::sax::XAttributeList > & xAttrList )
-{
-SvXMLImportContext *pContext = nullptr;
-
-// #i69629# - own subclasses for and
-if( XML_NAMESPACE_OFFICE==nPrefix &&
-( IsXMLToken( rLocalName, XML_DOCUMENT_SETTINGS ) ||
- IsXMLToken( rLocalName, XML_DOCUMENT_CONTENT ) ))
-pContext = new SwXMLDocContext_Impl( *this, nPrefix, rLocalName );
-else if ( XML_NAMESPACE_OFFICE==nPrefix &&
- IsXMLToken( rLocalName, XML_DOCUMENT_STYLES ) )
-{
-pContext = new SwXMLDocStylesContext_Impl( *this, nPrefix, rLocalName
);
-}
-else
-pContext = SvXMLImport::CreateDocumentContext(nPrefix, rLocalName,
xAttrList);
-
-return pContext;
-}
-
SvXMLImportContext *SwXMLImport::CreateFastContext( sal_Int32 nElement,
const uno::Reference< xml::sax::XFastAttributeList >& /*xAttrList*/ )
{
@@ -409,6 +378,14 @@ SvXMLImportContext *SwXMLImport::CreateFastContext(
sal_Int32 nElement,
pContext = new SwXMLOfficeDocContext_Impl( *this, xDocProps );
}
break;
+// #i69629# -
[Libreoffice-bugs] [Bug 130022] New: Tableeditor: Field Properties aren't shown except "Format example".
https://bugs.documentfoundation.org/show_bug.cgi?id=130022 Bug ID: 130022 Summary: Tableeditor: Field Properties aren't shown except "Format example". Product: LibreOffice Version: 6.4.0.1 rc Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rob...@familiegrosskopf.de Created attachment 157165 --> https://bugs.documentfoundation.org/attachment.cgi?id=157165=edit Screenshot "Field properties lost" (except Format example) Following bug appears with Version: 6.4.0.2 Build ID: 08d19fecdc7a2298d051e19cfdb7c35544855fc3 CPU threads: 6; OS: Linux 4.12; UI render: default; VCL: kf5; Locale: de-DE (de_DE.UTF-8); UI-Language: en-US Calc: threaded Open a database, for example an internal Firebird. Open a table and try to edit a field with Field Type VARCHAR. Field properties at the bottom of the editor will show only "Format example" (see attached screenshot). Resize the window a little bit. The other properties will also appear. Detected with OpenSUSE 15.1 64bit rpm Linux. It's a regression, because it doesn't appear in LO 6.3.4.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130020] No warning displayed even if error/warning code was set when spreadsheet data fails to save to dBASE format.
https://bugs.documentfoundation.org/show_bug.cgi?id=130020 Eike Rathke changed: What|Removed |Added CC||er...@redhat.com Summary|CALC spreadsheet failed to |No warning displayed even |save to dBASE format. |if error/warning code was ||set when spreadsheet data ||fails to save to dBASE ||format. --- Comment #4 from Eike Rathke --- ScDocShell::DBaseExport() for this case even sets SCWARN_EXPORT_DATALOST error code, but for some yet unknown reason a message is not displayed or the error not propagated later. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: LOOL master make check fail
Hi Miklos, all, Thanks for the reply. I am sorry but I am unable to find "assertionF" under online/test/. Can you please be more specific? In the sense which particular file might be having the string. (Heres the link of log from my previous mail, if it helps https://pastebin.com/xJZaFMAc) There are two kind of tests for the server part: the newer shared > libraries, which are injected into the wsd or kit processes and the > older ones which only do blackbox testing. > From what I understand, there are multiple types of test in LOOL, but mainly(based on their run time) there are two tests: Test Suite and the tests run by run_unit.sh. Are these the test you are talking about? It would be great if you could give me a brief about the different tests that are there in LOOL. Thank You Sincerely, Shivansh Handa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: shell/source
shell/source/win32/SysShExec.cxx |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
New commits:
commit 14b36a16b225bf7c988f118d499a7287c47cd83e
Author: Stephan Bergmann
AuthorDate: Wed Jan 15 17:16:02 2020 +0100
Commit: Stephan Bergmann
CommitDate: Wed Jan 15 19:16:27 2020 +0100
Remove a fragment from a file URL early on
...as ShellExecuteExW would ignore it anyway
Change-Id: I969db094bb7d2ea230ac8c36eb23d71a90fbe466
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86868
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/shell/source/win32/SysShExec.cxx b/shell/source/win32/SysShExec.cxx
index ccf932e71d03..74b4ee584f9f 100644
--- a/shell/source/win32/SysShExec.cxx
+++ b/shell/source/win32/SysShExec.cxx
@@ -302,6 +302,7 @@ void SAL_CALL CSysShExec::execute( const OUString&
aCommand, const OUString& aPa
static_cast< XSystemShellExecute* >( this ),
3 );
+OUString preprocessed_command(aCommand);
if ((nFlags & URIS_ONLY) != 0)
{
css::uno::Reference< css::uri::XUriReference > uri(
@@ -315,8 +316,10 @@ void SAL_CALL CSysShExec::execute( const OUString&
aCommand, const OUString& aPa
static_cast< cppu::OWeakObject * >(this), 0);
}
if (uri->getScheme().equalsIgnoreAsciiCase("file")) {
+// ShellExecuteExW appears to ignore the fragment of a file URL
anyway, so remove it:
+uri->clearFragment();
+preprocessed_command = uri->getUriReference();
OUString pathname;
-uri->clearFragment(); // getSystemPathFromFileURL fails for URLs
with fragment
auto const e1
=
osl::FileBase::getSystemPathFromFileURL(uri->getUriReference(), pathname);
if (e1 != osl::FileBase::E_None) {
@@ -420,7 +423,6 @@ void SAL_CALL CSysShExec::execute( const OUString&
aCommand, const OUString& aPa
and names no existing file (remember the jump mark
sign '#' is a valid file name character we remove
the jump mark, else ShellExecuteEx fails */
-OUString preprocessed_command(aCommand);
if (is_system_path(preprocessed_command))
{
if (has_jump_mark(preprocessed_command) &&
!is_existing_file(preprocessed_command))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
