date:20200225

[Libreoffice-bugs] [Bug 130946] New: Hyperlnks in Calc cannot created over more than one cell. (like in ms excel via cells selection)

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130946

Bug ID: 130946
   Summary: Hyperlnks in Calc  cannot created over more than one
cell. (like in ms excel via cells selection)
   Product: LibreOffice
   Version: 6.4.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: fischer...@gmx.de

Description:
Hyperlnks in Calc  cannot created over more than one cell. (like in ms excel
via cells selection)

Steps to Reproduce:
1. Select more than 1 cell horizontally 
2. Right Click and "create Hyperlink"
3. Hyperlink-Text shoud contain Cell-Content of the selected cells

Actual Results:
Doesn't work

Expected Results:
same


Reproducible: Always


User Profile Reset: No



Additional Info:
It works in MS Excel

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/skia

2020-02-25 Thread Stephan Bergmann (via logerrit)

 vcl/skia/win/gdiimpl.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b629d98e6f9fc71ee0f43a973cf9cbb85148f073
Author: Stephan Bergmann 
AuthorDate: Tue Feb 25 17:24:08 2020 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Feb 26 08:41:36 2020 +0100

loplugin:nullptr (clang-cl)

Change-Id: I0d40f6ee515430f2d32fb7d3bcc193273d36c016
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89469
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/vcl/skia/win/gdiimpl.cxx b/vcl/skia/win/gdiimpl.cxx
index 4d726ec2d215..3c034856e7aa 100644
--- a/vcl/skia/win/gdiimpl.cxx
+++ b/vcl/skia/win/gdiimpl.cxx
@@ -297,7 +297,7 @@ std::unique_ptr 
createVulkanWindowContext()
 {
 SkiaZone zone;
 sk_app::DisplayParams displayParams;
-return sk_app::window_context_factory::MakeVulkanForWin(0, displayParams);
+return sk_app::window_context_factory::MakeVulkanForWin(nullptr, 
displayParams);
 }
 
 struct SetFunction
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/skia

2020-02-25 Thread Stephan Bergmann (via logerrit)

 vcl/skia/win/gdiimpl.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 6fc261fa1a33fb62e97a8e5beeba7fbb44e8774c
Author: Stephan Bergmann 
AuthorDate: Tue Feb 25 17:23:21 2020 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Feb 26 08:41:17 2020 +0100

loplugin:external (clang-cl)

Change-Id: I2ea8eaeb9cc2e98d807678ec4716cf58b36f92c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89468
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/vcl/skia/win/gdiimpl.cxx b/vcl/skia/win/gdiimpl.cxx
index b90239fdedc2..4d726ec2d215 100644
--- a/vcl/skia/win/gdiimpl.cxx
+++ b/vcl/skia/win/gdiimpl.cxx
@@ -291,6 +291,8 @@ SkiaControlCacheType& SkiaControlsCache::get()
 return data->m_pSkiaControlsCache->cache;
 }
 
+namespace
+{
 std::unique_ptr createVulkanWindowContext()
 {
 SkiaZone zone;
@@ -298,8 +300,6 @@ std::unique_ptr 
createVulkanWindowContext()
 return sk_app::window_context_factory::MakeVulkanForWin(0, displayParams);
 }
 
-namespace
-{
 struct SetFunction
 {
 SetFunction() { 
SkiaHelper::setCreateVulkanWindowContext(createVulkanWindowContext); }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 130945] Writer: Preview of linked doc is not updated when edited

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130945

Serge Krot (CIB)  changed:

   What|Removed |Added

Summary|Writer: Preview of linked   |Writer: Preview of linked
   |doc is not updated when |doc is not updated when
   |dited   |edited

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: configure.ac

2020-02-25 Thread Stephan Bergmann (via logerrit)

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 92df944f54696012963415111a706fca438e703b
Author: Stephan Bergmann 
AuthorDate: Tue Feb 25 16:25:24 2020 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Feb 26 08:40:54 2020 +0100

Detect -std=c++20

at least Clang trunk accepts it now since 
 "Add -std=c++20 flag, 
replace
C++2a with C++20 throughout the Clang"

Change-Id: I389bb2e79acbbdf2622dc7c839a3164836c40415
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89464
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/configure.ac b/configure.ac
index 973866050a4e..c9d75b19ecf2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -6563,7 +6563,7 @@ CXXFLAGS_CXX11=
 if test "$COM" = MSC -a "$COM_IS_CLANG" != TRUE; then
 CXXFLAGS_CXX11='-std:c++17 -Zc:__cplusplus'
 elif test "$GCC" = "yes" -o "$COM_IS_CLANG" = TRUE; then
-my_flags='-std=c++2a -std=c++17 -std=c++1z'
+my_flags='-std=c++20 -std=c++2a -std=c++17 -std=c++1z'
 for flag in $my_flags; do
 if test "$COM" = MSC; then
 flag="-Xclang $flag"
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 130945] New: Writer: Preview of linked doc is not updated when dited

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130945

Bug ID: 130945
   Summary: Writer: Preview of linked doc is not updated when
dited
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: serge.k...@cib.de

How to reproduce:
1.create new calc file and enter some Numbers and save and close this file
2.create new writer file and insert -> object -> OLE-object
3.select create from file and select calc sheet of step one
4.select "link to file"
5.press ok
6.edit the table in the writer document (change value of A1 cell)
7.select a new cell (A2)
8.click outside the table in the writer document
9.in writer old preview image is used

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130926] Mono-spaced font display properties not preserved, when a pattern it is applied to, is copied/pasted from terminal emulator into Writer document

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130926

--- Comment #4 from ricky.t...@gmail.com ---
Within rulers (Shift + Ctrl + R) then right-click, Char as unit is selected,
Tab stops, those one present at default, cannot be dragged nor removed, as
probably they are not intended to be. What could be this tab stop to be dragged
you referred to?.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: icon-themes/sifr icon-themes/sifr_dark icon-themes/sifr_dark_svg icon-themes/sifr_svg

2020-02-25 Thread rizmut (via logerrit)

 dev/null   
|binary
 icon-themes/sifr/chart2/res/typenet_16.png 
|binary
 icon-themes/sifr/cmd/32/slidechangewindow.png  
|binary
 icon-themes/sifr/cmd/32/tabledeselectall.png   
|binary
 icon-themes/sifr/cmd/lc_showgraphics.png   
|binary
 icon-themes/sifr/cmd/lc_slidechangewindow.png  
|binary
 icon-themes/sifr/cmd/lc_tabledeselectall.png   
|binary
 icon-themes/sifr/cmd/sc_slidechangewindow.png  
|binary
 icon-themes/sifr/cmd/sc_tabledeselectall.png   
|binary
 icon-themes/sifr/dbaccess/res/lc039.png
|binary
 icon-themes/sifr/dbaccess/res/lc040.png
|binary
 icon-themes/sifr/dbaccess/res/linked_text_table.png
|binary
 icon-themes/sifr/dbaccess/res/sc039.png
|binary
 icon-themes/sifr/dbaccess/res/sc040.png
|binary
 icon-themes/sifr/links.txt 
|  427 +++---
 icon-themes/sifr/sd/res/effectole_16.png   
|binary
 icon-themes/sifr/sw/res/sidebar/pageproppanel/column_L_copy_24x24.png  
|binary
 icon-themes/sifr/sw/res/sidebar/pageproppanel/format_L_copy_24x24.png  
|binary
 icon-themes/sifr/sw/res/sidebar/pageproppanel/formatcopy_24x24.png 
|binary
 icon-themes/sifr/sw/res/sidebar/pageproppanel/portraitcopy_24x24.png   
|binary
 icon-themes/sifr_dark/chart2/res/areas3d_52x60.png 
|binary
 icon-themes/sifr_dark/chart2/res/areas_52x60.png   
|binary
 icon-themes/sifr_dark/chart2/res/areasfull3d_52x60.png 
|binary
 icon-themes/sifr_dark/chart2/res/areasfull_52x60.png   
|binary
 icon-themes/sifr_dark/chart2/res/areaspiled3d_52x60.png
|binary
 icon-themes/sifr_dark/chart2/res/areaspiled_52x60.png  
|binary
 icon-themes/sifr_dark/chart2/res/bar3d_52x60.png   
|binary
 icon-themes/sifr_dark/chart2/res/bar3ddeep_52x60.png   
|binary
 icon-themes/sifr_dark/chart2/res/bar_52x60.png 
|binary
 icon-themes/sifr_dark/chart2/res/barpercent3d_52x60.png
|binary
 icon-themes/sifr_dark/chart2/res/barpercent_52x60.png  
|binary
 icon-themes/sifr_dark/chart2/res/barstack3d_52x60.png  
|binary
 icon-themes/sifr_dark/chart2/res/barstack_52x60.png
|binary
 icon-themes/sifr_dark/chart2/res/bubble_52x60.png  
|binary
 icon-themes/sifr_dark/chart2/res/columnline_52x60.png  
|binary
 icon-themes/sifr_dark/chart2/res/columnpercent3d_52x60.png 
|binary
 icon-themes/sifr_dark/chart2/res/columnpercent_52x60.png   
|binary
 icon-themes/sifr_dark/chart2/res/columns3d_52x60.png   
|binary
 icon-themes/sifr_dark/chart2/res/columns3ddeep_52x60.png   
|binary
 icon-themes/sifr_dark/chart2/res/columns_52x60.png 
|binary
 icon-themes/sifr_dark/chart2/res/columnstack3d_52x60.png   
|binary
 icon-themes/sifr_dark/chart2/res/columnstack_52x60.png 
|binary
 icon-themes/sifr_dark/chart2/res/columnstackline_52x60.png 
|binary
 icon-themes/sifr_dark/chart2/res/cone_52x60.png
|binary
 icon-themes/sifr_dark/chart2/res/conedeep_52x60.png
|binary
 icon-themes/sifr_dark/chart2/res/conehori_52x60.png
|binary
 icon-themes/sifr_dark/chart2/res/conehorideep_52x60.png
|binary
 icon-themes/sifr_dark/chart2/res/conehoripercent_52x60.png 
|binary
 icon-themes/sifr_dark/chart2/res/conehoristack_52x60.png   
|binary
 icon-themes/sifr_dark/chart2/res/conepercent_52x60.png 
|binary
 icon-themes/sifr_dark/chart2/res/conestack_52x60.png   
|binary
 icon-themes/sifr_dark/chart2/res/cylinder_52x60.png
|binary
 icon-themes/sifr_dark/chart2/res/cylinderdeep_52x60.png
|binary
 icon-themes/sifr_dark/chart2/res/cylinderhori_52x60.png
|binary
 icon-themes/sifr_dark/chart2/res/cylinderhorideep_52x60.png
|binary
 icon-themes/sifr_dark/chart2/res/cylinderhoriprocent_52x60.png 
|binary

[Libreoffice-bugs] [Bug 130944] Very Small Bug

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130944

Jeffrey Thomas  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Jeffrey Thomas  ---
Dynamics 365 Business Central is a cloud ERP solution designed to manage a
business’s financial and operational needs for small and medium-sized
businesses. Business Central combines a range of functionalities across
operations, finance, project management and sales. There are two Dynamics
Business Central Pricing, Essentials and Premium.

https://www.nevastech.com/solutions/dynamics-365-business-central-pricing-licensing

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130944] New: Very Small Bug

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130944

Bug ID: 130944
   Summary: Very Small Bug
   Product: cppunit
   Version: 1.13
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: charlesjeffreytho...@aol.com
CC: markus.mohrh...@googlemail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130943] New: Very Small Bug

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130943

Bug ID: 130943
   Summary: Very Small Bug
   Product: cppunit
   Version: 1.13
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: charlesjeffreytho...@aol.com
CC: markus.mohrh...@googlemail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2020-02-25 Thread Jim Raykowski (via logerrit)

 sw/source/uibase/utlui/content.cxx |   53 +
 1 file changed, 25 insertions(+), 28 deletions(-)

New commits:
commit 387e0b4f4c33dfaa48b26098819726824f23f9d2
Author: Jim Raykowski 
AuthorDate: Mon Feb 24 22:58:45 2020 -0900
Commit: Noel Grandin 
CommitDate: Wed Feb 26 07:12:40 2020 +0100

tdf#108766 followup: outline tracking fixes for floating navigator

Fixes tracking not working and selection misbehaviour on document open
when navigator is floating.

Change-Id: Ic8e3fe7222cba354d6f2ad864ef8083861b8d324
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89409
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index f70f72815075..d55c38febdf9 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -1888,28 +1888,28 @@ void SwContentTree::Display( bool bActive )
 Expand(pParent);
 
 // reselect the entry
-SvTreeListEntry* pChild = pParent;
-SvTreeListEntry* pTemp = nullptr;
-sal_uLong nPos = 1;
-while(nullptr != (pChild = Next(pChild)))
-{
-// The old text will be slightly favored
-if(sEntryName == GetEntryText(pChild) ||
-nPos == nEntryRelPos )
+if (nEntryRelPos)
+{
+SvTreeListEntry* pChild = pParent;
+sal_uLong nPos = 1;
+while(nullptr != (pChild = Next(pChild)))
 {
-pSelEntry = pChild;
-break;
+// The old text will be slightly favored
+if(sEntryName == GetEntryText(pChild) ||
+nPos == nEntryRelPos)
+{
+pSelEntry = pChild;
+break;
+}
+nPos++;
+}
+if(pSelEntry)
+{
+SetCurEntry(pSelEntry); // unselect all entries, make 
pSelEntry visible, and select
 }
-pTemp = pChild;
-nPos++;
-}
-if(!pSelEntry)
-pSelEntry = pTemp;
-if(pSelEntry)
-{
-MakeVisible(pSelEntry);
-Select(pSelEntry);
 }
+else
+SetCurEntry(pParent);
 }
 }
 SetUpdateMode( true );
@@ -2754,10 +2754,9 @@ IMPL_LINK_NOARG(SwContentTree, TimerUpdate, Timer *, 
void)
 // No update while drag and drop.
 // Query view because the Navigator is cleared too late.
 SwView* pView = GetParentWindow()->GetCreateView();
-
-if(pView && pView->GetWrtShellPtr() &&
-((pView->GetWrtShellPtr()->GetWin() == GetFocusedWindow()) || 
m_bViewHasChanged) &&
-!bIsInDrag && !m_bIsInternalDrag && 
!pView->GetWrtShellPtr()->ActionPend())
+if(pView && pView->GetWrtShellPtr() && pView->GetWrtShellPtr()->GetWin() &&
+(pView->GetWrtShellPtr()->GetWin()->HasFocus() || m_bViewHasChanged) &&
+!bIsInDrag && !m_bIsInternalDrag && 
!pView->GetWrtShellPtr()->ActionPend())
 {
 m_bViewHasChanged = false;
 m_bIsIdleClear = false;
@@ -2797,11 +2796,11 @@ IMPL_LINK_NOARG(SwContentTree, TimerUpdate, Timer *, 
void)
 if (lcl_IsContent(pEntry) &&
 
static_cast(pEntry->GetUserData())->GetParent()->GetType() == 
ContentTypeId::OUTLINE)
 {
-// only select if not already selected
 // might have been scrolled out of view by the user so 
leave it that way
 if 
(static_cast(pEntry->GetUserData())->GetOutlinePos() == 
nActPos)
 {
-if (pEntry != pFirstSelected)
+// only select if not already selected or tree has 
multiple entries selected
+if (pEntry != pFirstSelected || GetSelectionCount() > 
1)
 {
 if (m_nOutlineTracking == 2) // focused outline 
tracking
 {
@@ -2814,9 +2813,7 @@ IMPL_LINK_NOARG(SwContentTree, TimerUpdate, Timer *, void)
 break;
 }
 }
-SelectAll(false);
-Select(pEntry);
-MakeVisible(pEntry);
+SetCurEntry(pEntry); // unselect all entries, make 
pEntry visible, and select
 }
 break;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #333 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/20747665a60b5c8782ab77962380ea34a30c20fa

tdf#45904 Move XNameReplace Java test to C++

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: qadevOOo/objdsc sc/qa

2020-02-25 Thread Jens Carl (via logerrit)

 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetsObj.csv |1 -
 sc/qa/extras/sctablesheetsobj.cxx|   10 
++
 sc/qa/unoapi/knownissues.xcl |3 ---
 3 files changed, 10 insertions(+), 4 deletions(-)

New commits:
commit 20747665a60b5c8782ab77962380ea34a30c20fa
Author: Jens Carl 
AuthorDate: Tue Feb 25 20:27:40 2020 -0800
Commit: Jens Carl 
CommitDate: Wed Feb 26 07:11:50 2020 +0100

tdf#45904 Move XNameReplace Java test to C++

Move XNameReplace Java test to C++ for ScTableSheetsObj.
Fixes i#23594 by creating a new "com.sun.star.sheet.Spreadsheet" rather
then using an existing one.

Change-Id: If7058647cc5d79d11e5542a82017d5bd02f7049e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89493
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetsObj.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetsObj.csv
index 83fbb64ec41d..e348d3613059 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetsObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetsObj.csv
@@ -1,4 +1,3 @@
-"ScTableSheetsObj";"com::sun::star::container::XNameReplace";"replaceByName()"
 "ScTableSheetsObj";"com::sun::star::container::XNameContainer";"insertByName()"
 "ScTableSheetsObj";"com::sun::star::container::XNameContainer";"removeByName()"
 "ScTableSheetsObj";"com::sun::star::container::XIndexAccess";"getCount()"
diff --git a/sc/qa/extras/sctablesheetsobj.cxx 
b/sc/qa/extras/sctablesheetsobj.cxx
index 82c74e832c7d..34b1e03cfa90 100644
--- a/sc/qa/extras/sctablesheetsobj.cxx
+++ b/sc/qa/extras/sctablesheetsobj.cxx
@@ -11,6 +11,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -24,6 +25,7 @@ class ScTableSheetsObj : public CalcUnoApiTest,
  public ::apitest::XEnumerationAccess,
  public ::apitest::XNameAccess,
  public ::apitest::XNameContainer,
+ public ::apitest::XNameReplace,
  public ::apitest::XSpreadsheets,
  public ::apitest::XSpreadsheets2
 {
@@ -43,6 +45,9 @@ public:
 CPPUNIT_TEST(testGetElementNames);
 CPPUNIT_TEST(testHasByName);
 
+// XNameReplace
+CPPUNIT_TEST(testReplaceByName);
+
 // XSpreadsheets
 CPPUNIT_TEST(testInsertNewByName);
 CPPUNIT_TEST(testInsertNewByNameBadName);
@@ -80,6 +85,7 @@ ScTableSheetsObj::ScTableSheetsObj()
 : CalcUnoApiTest("/sc/qa/extras/testdocuments")
 , ::apitest::XNameAccess("Sheet1")
 , ::apitest::XNameContainer("Sheet2")
+, ::apitest::XNameReplace("Sheet2")
 {
 }
 
@@ -103,6 +109,10 @@ uno::Reference< uno::XInterface > ScTableSheetsObj::init()
 xDocument.set(mxComponent, UNO_QUERY_THROW);
 uno::Reference< uno::XInterface > xReturn( xDocument->getSheets(), 
UNO_QUERY_THROW);
 
+uno::Reference xMSF(mxComponent, 
uno::UNO_QUERY_THROW);
+// XNameReplace
+
setReplacementElement(uno::makeAny(xMSF->createInstance("com.sun.star.sheet.Spreadsheet")));
+
 return xReturn;
 }
 
diff --git a/sc/qa/unoapi/knownissues.xcl b/sc/qa/unoapi/knownissues.xcl
index 7da16e74cf43..999c7681d327 100644
--- a/sc/qa/unoapi/knownissues.xcl
+++ b/sc/qa/unoapi/knownissues.xcl
@@ -38,9 +38,6 @@ sc.ScTableSheetObj::com::sun::star::sheet::XCellRangeData
 ### i84669 ###
 sc.ScTabViewObj::com::sun::star::sheet::XRangeSelection
 
-### i23594 ###
-sc.ScTableSheetsObj::com::sun::star::container::XNameReplace
-
 ### i31378 ###
 sc.ScDocumentConfiguration::com::sun::star::document::Settings
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: compilerplugins/clang dbaccess/source editeng/source include/xmloff linguistic/source reportdesign/source solenv/CompilerTest_compilerplugins_clang.mk sw/source xmloff/

2020-02-25 Thread Noel Grandin (via logerrit)

 compilerplugins/clang/test/xmlimport.cxx   |   54 ++
 compilerplugins/clang/xmlimport.cxx|  139 +
 dbaccess/source/filter/xml/xmlfilter.cxx   |4 
 editeng/source/misc/SvXMLAutoCorrectImport.hxx |6 
 include/xmloff/XMLCharContext.hxx  |3 
 linguistic/source/convdicxml.cxx   |3 
 reportdesign/source/filter/xml/xmlColumn.hxx   |3 
 reportdesign/source/filter/xml/xmlCondPrtExpr.hxx  |3 
 reportdesign/source/filter/xml/xmlControlProperty.hxx  |4 
 reportdesign/source/filter/xml/xmlFormatCondition.hxx  |3 
 reportdesign/source/filter/xml/xmlFunction.hxx |3 
 reportdesign/source/filter/xml/xmlGroup.hxx|3 
 reportdesign/source/filter/xml/xmlMasterFields.hxx |3 
 reportdesign/source/filter/xml/xmlReportElement.hxx|3 
 reportdesign/source/filter/xml/xmlSection.hxx  |3 
 reportdesign/source/filter/xml/xmlTable.hxx|2 
 solenv/CompilerTest_compilerplugins_clang.mk   |1 
 sw/source/filter/xml/xmlimp.cxx|4 
 sw/source/uibase/config/StoredChapterNumbering.cxx |4 
 xmloff/source/text/XMLAutoTextContainerEventImport.hxx |3 
 20 files changed, 251 insertions(+)

New commits:
commit 9b18f4b2b064c823ac1500a0c297d113587a9bd4
Author: Noel Grandin 
AuthorDate: Tue Feb 25 19:05:10 2020 +0200
Commit: Noel Grandin 
CommitDate: Wed Feb 26 07:06:32 2020 +0100

new loplugin:xmlimport

to help me maintain the invariants when updating code to use the
FastParser APIs. One weird invariant is that you need to override
startFastElement or the createFastChildContext will not get called.

Not all of these changes are probably necessary - some of the classes
are never constructured themselves, only their subclasses are
constructed, and their subclasses maintain the invariants, but it is
just easier to scatter a few more startFastElement around

Change-Id: I3f70fb5a1e44c311cf4926fa7b0fcda605709eac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89473
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/test/xmlimport.cxx 
b/compilerplugins/clang/test/xmlimport.cxx
new file mode 100644
index ..965d4936e41c
--- /dev/null
+++ b/compilerplugins/clang/test/xmlimport.cxx
@@ -0,0 +1,54 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include "sal/config.h"
+
+// Cannot include this, makes clang crash
+//#include "xmloff/xmlimp.hxx"
+
+class SvXMLImportContext
+{
+public:
+virtual ~SvXMLImportContext() {}
+
+virtual void createFastChildContext() {}
+virtual void startFastElement() {}
+virtual void endFastElement() {}
+};
+
+class Test1 : public SvXMLImportContext
+{
+public:
+// expected-error@+1 {{must override startFastElement too 
[loplugin:xmlimport]}}
+virtual void createFastChildContext() override;
+};
+
+class Test2 : public SvXMLImportContext
+{
+public:
+// no warning expected
+virtual void createFastChildContext() override;
+virtual void startFastElement() override {}
+};
+
+class Test3 : public Test2
+{
+public:
+// no warning expected
+virtual void createFastChildContext() override;
+};
+
+class Test4 : public SvXMLImportContext
+{
+public:
+// expected-error@+1 {{must override startFastElement too 
[loplugin:xmlimport]}}
+virtual void endFastElement() override;
+};
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/compilerplugins/clang/xmlimport.cxx 
b/compilerplugins/clang/xmlimport.cxx
new file mode 100644
index ..bdb41f616859
--- /dev/null
+++ b/compilerplugins/clang/xmlimport.cxx
@@ -0,0 +1,139 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * Based on LLVM/Clang.
+ *
+ * This file is distributed under the University of Illinois Open Source
+ * License. See LICENSE.TXT for details.
+ *
+ */
+#ifndef LO_CLANG_SHARED_PLUGINS
+
+#include "compat.hxx"
+#include "plugin.hxx"
+#include "check.hxx"
+#include 
+#include "clang/AST/CXXInheritance.h"
+
+/*
+ * This is a compile-time checker.
+ *
+ * Check that when we override SvXmlImportContext, and we override 
createFastChildContext,
+ * we have also overridden startFastElement, or the fast-parser stuff will not 
work
+ * correctly.
+*/
+
+namespace
+{
+class XmlImport : public loplugin::FilteringPlugin
+{
+public:
+explicit XmlImport(loplugin::InstantiationData const&

[Libreoffice-commits] core.git: solenv/gbuild

2020-02-25 Thread Noel Grandin (via logerrit)

 solenv/gbuild/extensions/pre_MergedLibsList.mk |   11 +++
 1 file changed, 11 insertions(+)

New commits:
commit 4ec76bdeeb000881cf46c78166dc02badb4f44db
Author: Noel Grandin 
AuthorDate: Fri Feb 21 08:46:02 2020 +0200
Commit: Noel Grandin 
CommitDate: Wed Feb 26 07:07:04 2020 +0100

add some libs to libmerged

another small chunk of libs shared by calc/write/impress,
doing this in stages in case anything goes wrong.

Change-Id: Ica162828565e825b8eaeb223eb3ab132880a6279
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89166
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/solenv/gbuild/extensions/pre_MergedLibsList.mk 
b/solenv/gbuild/extensions/pre_MergedLibsList.mk
index 9cb91a5d4a15..976de14e8967 100644
--- a/solenv/gbuild/extensions/pre_MergedLibsList.mk
+++ b/solenv/gbuild/extensions/pre_MergedLibsList.mk
@@ -83,13 +83,24 @@ MERGE_LIBRARY_LIST := \
svx \
svxcore \
syssh \
+   textfd \
tk \
tl \
ucb1 \
ucbhelper \
ucpexpand1 \
+   ucpext \
+   ucphier1 \
+   ucpimage \
ucpfile1 \
+   ucptdoc1 \
+   unordf \
unoxml \
+   $(if $(ENABLE_ONLINE_UPDATE), \
+   updatecheckui \
+updchk \
+   ) \
+   updatefeed \
utl \
uui \
vcl \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

2020-02-25 Thread Tomaž Vajngerl (via logerrit)

 vcl/source/filter/graphicfilter.cxx |   56 +++-
 1 file changed, 5 insertions(+), 51 deletions(-)

New commits:
commit b90eaab5c51c2b0f2aba66da35a5b494c3211f1d
Author: Tomaž Vajngerl 
AuthorDate: Tue Feb 25 14:51:22 2020 +0100
Commit: Tomaž Vajngerl 
CommitDate: Wed Feb 26 07:04:59 2020 +0100

vcl: use UCBContentHelper in instead of implement own functions

Change-Id: Iea617c8b5d3aa5f755b70ff2b6e00e8372057df0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89478
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/source/filter/graphicfilter.cxx 
b/vcl/source/filter/graphicfilter.cxx
index c32015e7d222..9ae7e393c8b7 100644
--- a/vcl/source/filter/graphicfilter.cxx
+++ b/vcl/source/filter/graphicfilter.cxx
@@ -64,6 +64,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -103,54 +104,6 @@ public:
 
 }
 
-static bool DirEntryExists( const INetURLObject& rObj )
-{
-bool bExists = false;
-
-try
-{
-::ucbhelper::Content aCnt( rObj.GetMainURL( 
INetURLObject::DecodeMechanism::NONE ),
- css::uno::Reference< 
css::ucb::XCommandEnvironment >(),
- comphelper::getProcessComponentContext() );
-
-bExists = aCnt.isDocument();
-}
-catch(const css::ucb::CommandAbortedException&)
-{
-SAL_WARN( "vcl.filter", "CommandAbortedException" );
-}
-catch(const css::ucb::ContentCreationException&)
-{
-SAL_WARN( "vcl.filter", "ContentCreationException" );
-}
-catch( ... )
-{
-SAL_WARN( "vcl.filter", "Any other exception" );
-}
-return bExists;
-}
-
-static void KillDirEntry( const OUString& rMainUrl )
-{
-try
-{
-::ucbhelper::Content aCnt( rMainUrl,
- css::uno::Reference< 
css::ucb::XCommandEnvironment >(),
- comphelper::getProcessComponentContext() );
-
-aCnt.executeCommand( "delete",
- css::uno::makeAny( true ) );
-}
-catch(const css::ucb::CommandAbortedException&)
-{
-SAL_WARN( "vcl.filter", "CommandAbortedException" );
-}
-catch( ... )
-{
-SAL_WARN( "vcl.filter", "Any other exception" );
-}
-}
-
 // Helper functions
 
 sal_uInt8* ImplSearchEntry( sal_uInt8* pSource, sal_uInt8 const * pDest, 
sal_uLong nComp, sal_uLong nSize )
@@ -1881,9 +1834,10 @@ ErrCode GraphicFilter::ExportGraphic( const Graphic& 
rGraphic, const INetURLObje
 SAL_INFO( "vcl.filter", "GraphicFilter::ExportGraphic() (thb)" );
 ErrCode  nRetValue = ERRCODE_GRFILTER_FORMATERROR;
 SAL_WARN_IF( rPath.GetProtocol() == INetProtocol::NotValid, "vcl.filter", 
"GraphicFilter::ExportGraphic() : ProtType == INetProtocol::NotValid" );
-bool bAlreadyExists = DirEntryExists( rPath );
 
-OUStringaMainUrl( rPath.GetMainURL( 
INetURLObject::DecodeMechanism::NONE ) );
+OUString aMainUrl(rPath.GetMainURL(INetURLObject::DecodeMechanism::NONE));
+bool bAlreadyExists = utl::UCBContentHelper::IsDocument(aMainUrl);
+
 std::unique_ptr xStream(::utl::UcbStreamHelper::CreateStream( 
aMainUrl, StreamMode::WRITE | StreamMode::TRUNC ));
 if (xStream)
 {
@@ -1891,7 +1845,7 @@ ErrCode GraphicFilter::ExportGraphic( const Graphic& 
rGraphic, const INetURLObje
 xStream.reset();
 
 if( ( ERRCODE_NONE != nRetValue ) && !bAlreadyExists )
-KillDirEntry( aMainUrl );
+utl::UCBContentHelper::Kill(aMainUrl);
 }
 return nRetValue;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: xmlscript/source

2020-02-25 Thread Samuel Mehrbrodt (via logerrit)

 xmlscript/source/xmldlg_imexp/xmldlg_export.cxx |4 +++-
 xmlscript/source/xmldlg_imexp/xmldlg_import.cxx |   11 +++
 2 files changed, 14 insertions(+), 1 deletion(-)

New commits:
commit 6d9cf22b2239611a6612a7855f8a701ed723cbd4
Author: Samuel Mehrbrodt 
AuthorDate: Mon Feb 24 23:38:40 2020 +0100
Commit: Samuel Mehrbrodt 
CommitDate: Wed Feb 26 06:40:23 2020 +0100

tdf#130793 Fix import/export of image URLs

Change-Id: I329af3b0d5a81d9f31def9c2ad861d0e83e3714c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89388
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 

diff --git a/xmlscript/source/xmldlg_imexp/xmldlg_export.cxx 
b/xmlscript/source/xmldlg_imexp/xmldlg_export.cxx
index 1e192e3c387d..413facd87652 100644
--- a/xmlscript/source/xmldlg_imexp/xmldlg_export.cxx
+++ b/xmlscript/source/xmldlg_imexp/xmldlg_export.cxx
@@ -738,7 +738,9 @@ void ElementDescriptor::readImageOrGraphicAttr(OUString 
const & rAttrName)
 }
 }
 }
-else if (beans::PropertyState_DEFAULT_VALUE != 
_xPropState->getPropertyState("ImageURL"))
+// tdf#130793 Above fails if the dialog is not part of a document. Export 
the ImageURL then.
+if (sURL.isEmpty()
+&& beans::PropertyState_DEFAULT_VALUE != 
_xPropState->getPropertyState("ImageURL"))
 {
 _xProps->getPropertyValue("ImageURL") >>= sURL;
 }
diff --git a/xmlscript/source/xmldlg_imexp/xmldlg_import.cxx 
b/xmlscript/source/xmldlg_imexp/xmldlg_import.cxx
index 791976b55c5e..5aa953cd6562 100644
--- a/xmlscript/source/xmldlg_imexp/xmldlg_import.cxx
+++ b/xmlscript/source/xmldlg_imexp/xmldlg_import.cxx
@@ -880,6 +880,17 @@ bool ImportContext::importGraphicOrImageProperty(
 return true;
 }
 }
+else if (!sURL.isEmpty())
+{
+// tdf#130793 Above fails if the dialog is not part of a document.
+// In this case we need to set the ImageURL.
+Reference xProps = getControlModel();
+if (xProps.is())
+{
+xProps->setPropertyValue("ImageURL", makeAny(sURL));
+return true;
+}
+}
 }
 return false;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116280] [META] Regressions introduced by the image handling refactoring

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=116280
Bug 116280 depends on bug 130793, which changed state.

Bug 130793 Summary: Basic Dialog does not import/export images
https://bugs.documentfoundation.org/show_bug.cgi?id=130793

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130942] tiny bug

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130942

Vimal Raj  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Vimal Raj  ---
Nevas Technologies has been providing Dynamics GP (Great Plains) services for
over a decade to end clients, ISVs and Dynamics GP partners. We offer full
service, one-stop-shop consulting services expertise of implementing and
customizing Dynamics GP from version 7.0 has enabled us to build a highly
competent team of GP consultants and developers with sound knowledge on the
functional and technical capabilities of the solution. We are a leading
provider of Dynamics GP (Great Plains) managed services / support.

https://www.nevastech.com/solutions/microsoft-dynamics-erp/microsoft-dynamics-gp/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130942] New: tiny bug

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130942

Bug ID: 130942
   Summary: tiny bug
   Product: cppunit
   Version: 1.13
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vimalraj211...@gmail.com
CC: markus.mohrh...@googlemail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130941] New: Graphical issue with vectors in LibreOffice Math

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130941

Bug ID: 130941
   Summary: Graphical issue with vectors in LibreOffice Math
   Product: LibreOffice
   Version: 6.3.4.2 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: trivial
  Priority: medium
 Component: Formula Editor
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kyle.vivi...@gmail.com

Description:
When I input the correct command 'vec{x}' I get a strange dotted circle over
the x. The vector arrow shows up, but is displaced by the circle so it is up
and to the right of where it should be. It almost looks like the arrow is
superscript to the circle above the letter.

Steps to Reproduce:
1. Insert Formula object on Writer, Calc, or Impress
2. Type 'vec{x}'

Actual Results:
An 'x' was printed with a dotted circle above it with an arrow apparently
superscript to that circle

Expected Results:
An 'x' should have been printed with an arrow above it.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.3.4.2 (x64)
Build ID: 60da17e045e08f1793c57c00ba83cdfce946d0aa
CPU threads: 8; OS: Windows 6.2; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126499] Chart in a form: setmodified(true) won't be executed

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=126499

--- Comment #8 from Stang  ---
Created attachment 158193
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158193=edit
Modified version using doVerb()

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 126499] Chart in a form: setmodified(true) won't be executed

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=126499

--- Comment #7 from Stang  ---
Have an alternative using doVerb().

In ActivateDiagram replaced:

oXCOEO.changeState(4)   ' UI_ACTIVE = 4
oXCOEO.changeState(0)   ' LOADED = 0

with:

oXCOEO.doVerb(-2)
oXCOEO.doVerb(-3)

Then added:

oXCOEO = oDiag.ExtendedControlOverEmbeddedObject
oXCOEO.doVerb(-2)
oXCOEO.doVerb(-3)

to the end of Change Data.

Works well on Ubuntu 18.04 Mate with LO:

Version: 6.4.0.3
Build ID: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8
CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

Will attach original sample with noted modifications.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=45904

--- Comment #332 from Commit Notification 
 ---
Jens Carl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/49eb4906de8f499ae14b789e90df9ba654895af5

tdf#45904 Move XNameAccess Java tests to C++

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: qadevOOo/objdsc sc/qa

2020-02-25 Thread Jens Carl (via logerrit)

 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetsObj.csv |3 -
 sc/qa/extras/sctablesheetsobj.cxx|   24 
++
 2 files changed, 16 insertions(+), 11 deletions(-)

New commits:
commit 49eb4906de8f499ae14b789e90df9ba654895af5
Author: Jens Carl 
AuthorDate: Mon Feb 24 22:56:27 2020 -0800
Commit: Jens Carl 
CommitDate: Wed Feb 26 05:05:24 2020 +0100

tdf#45904 Move XNameAccess Java tests to C++

Move XNameAccess Java tests to C++ for ScTableSheetsObj.

Change-Id: I5fdaafe35852ea3c6e260d490200ce99e990c3b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89408
Tested-by: Jenkins
Reviewed-by: Jens Carl 

diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetsObj.csv 
b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetsObj.csv
index 8eca36532a14..83fbb64ec41d 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetsObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableSheetsObj.csv
@@ -1,6 +1,3 @@
-"ScTableSheetsObj";"com::sun::star::container::XNameAccess";"getByName()"
-"ScTableSheetsObj";"com::sun::star::container::XNameAccess";"getElementNames()"
-"ScTableSheetsObj";"com::sun::star::container::XNameAccess";"hasByName()"
 "ScTableSheetsObj";"com::sun::star::container::XNameReplace";"replaceByName()"
 "ScTableSheetsObj";"com::sun::star::container::XNameContainer";"insertByName()"
 "ScTableSheetsObj";"com::sun::star::container::XNameContainer";"removeByName()"
diff --git a/sc/qa/extras/sctablesheetsobj.cxx 
b/sc/qa/extras/sctablesheetsobj.cxx
index 99d55ea75a16..82c74e832c7d 100644
--- a/sc/qa/extras/sctablesheetsobj.cxx
+++ b/sc/qa/extras/sctablesheetsobj.cxx
@@ -9,6 +9,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -19,11 +20,12 @@ using namespace css;
 using namespace css::uno;
 
 namespace sc_apitest {
-
-class ScTableSheetsObj : public CalcUnoApiTest, public 
apitest::XEnumerationAccess,
-public 
::apitest::XSpreadsheets,
-public 
::apitest::XSpreadsheets2,
-public apitest::XNameContainer
+class ScTableSheetsObj : public CalcUnoApiTest,
+ public ::apitest::XEnumerationAccess,
+ public ::apitest::XNameAccess,
+ public ::apitest::XNameContainer,
+ public ::apitest::XSpreadsheets,
+ public ::apitest::XSpreadsheets2
 {
 public:
 ScTableSheetsObj();
@@ -36,6 +38,11 @@ public:
 // XEnumerationAccess
 CPPUNIT_TEST(testCreateEnumeration);
 
+// XNameAccess
+CPPUNIT_TEST(testGetByName);
+CPPUNIT_TEST(testGetElementNames);
+CPPUNIT_TEST(testHasByName);
+
 // XSpreadsheets
 CPPUNIT_TEST(testInsertNewByName);
 CPPUNIT_TEST(testInsertNewByNameBadName);
@@ -69,9 +76,10 @@ protected:
 uno::Reference< lang::XComponent > mxComponent;
 };
 
-ScTableSheetsObj::ScTableSheetsObj():
-CalcUnoApiTest("/sc/qa/extras/testdocuments"),
-apitest::XNameContainer("Sheet2")
+ScTableSheetsObj::ScTableSheetsObj()
+: CalcUnoApiTest("/sc/qa/extras/testdocuments")
+, ::apitest::XNameAccess("Sheet1")
+, ::apitest::XNameContainer("Sheet2")
 {
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 45904] move java based api tests to c++

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=45904

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.2.0 target:6.0.0   |target:5.2.0 target:6.0.0
   |target:6.1.0 target:6.2.0   |target:6.1.0 target:6.2.0
   |target:6.3.0 target:6.4.0   |target:6.3.0 target:6.4.0
   ||target:7.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=10
Bug 10 depends on bug 129619, which changed state.

Bug 129619 Summary: Layout: Table breaks in unexpected places when all 
paragraphs marked keep-with-next (see comment 14)
https://bugs.documentfoundation.org/show_bug.cgi?id=129619

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129619] Layout: Table breaks in unexpected places when all paragraphs marked keep-with-next (see comment 14)

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=129619

mkass...@internode.net changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113088] [META] Writer table properties dialog bugs and enhancements

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113088
Bug 113088 depends on bug 129619, which changed state.

Bug 129619 Summary: Layout: Table breaks in unexpected places when all 
paragraphs marked keep-with-next (see comment 14)
https://bugs.documentfoundation.org/show_bug.cgi?id=129619

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86914] Sharepoint connection is opened as WebDav

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=86914

--- Comment #9 from QA Administrators  ---
Dear Luc,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130935] Crash when selecting txt file after insert sheet from file

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130935

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122681] LineStyle can't be read and set using VBA

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=122681

--- Comment #3 from QA Administrators  ---
Dear Gunnar,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116688] Crash in: BigPtrArray::Index2Block(unsigned __int64) when disabling Mendeley extension

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=116688

--- Comment #17 from QA Administrators  ---
Dear Clemens Prill,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116688] Crash in: BigPtrArray::Index2Block(unsigned __int64) when disabling Mendeley extension

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=116688

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130935] Crash when selecting txt file after insert sheet from file

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130935

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/src

2020-02-25 Thread Ashod Nakashian (via logerrit)

 loleaflet/src/layer/tile/TileLayer.js |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 23f484813116a9e130e697708dbb4621da163712
Author: Ashod Nakashian 
AuthorDate: Tue Feb 25 20:51:58 2020 -0500
Commit: Ashod Nakashian 
CommitDate: Wed Feb 26 02:57:33 2020 +0100

leaflet: don't hide the keyboard when changing selection

We now don't change the keyboard state when the user
drags the selection markers.

Change-Id: Ic3dec8011808df8d1028e1925190854a50588e1c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89492
Tested-by: Ashod Nakashian 
Reviewed-by: Ashod Nakashian 

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 6f7c924eb..c38e132d0 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -2623,7 +2623,6 @@ L.TileLayer = L.GridLayer.extend({
}
if (e.type === 'dragend') {
e.target.isDragged = false;
-   this._map.focus();
this._map.fire('scrollvelocity', {vx: 0, vy: 0});
}
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4-0' - loleaflet/po

2020-02-25 Thread Andras Timar (via logerrit)

 loleaflet/po/ui-ru.po |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit c40d1d6e276e7d137b3a0ab8d339af35442af435
Author: Andras Timar 
AuthorDate: Thu Feb 20 16:18:27 2020 +0100
Commit: Ashod Nakashian 
CommitDate: Wed Feb 26 02:36:28 2020 +0100

Updated ru translation

Change-Id: I297eb7b2eac78de76601b13f2bcb075119b0f7db
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89120
Tested-by: Jenkins CollaboraOffice 
Tested-by: Ashod Nakashian 
Reviewed-by: Ashod Nakashian 

diff --git a/loleaflet/po/ui-ru.po b/loleaflet/po/ui-ru.po
index d86975d1b..906aad9da 100644
--- a/loleaflet/po/ui-ru.po
+++ b/loleaflet/po/ui-ru.po
@@ -439,19 +439,19 @@ msgstr "Сервер столкнулся с ошибкой %0 при анали
 
 #: src/control/Control.ContextMenu.js:131
 msgid "Internal Cut"
-msgstr ""
+msgstr "Вырезать (внутр.)"
 
 #: src/control/Control.ContextMenu.js:134
 msgid "Internal Copy"
-msgstr ""
+msgstr "Копировать (внутр.)"
 
 #: src/control/Control.ContextMenu.js:137
 msgid "Internal Paste"
-msgstr ""
+msgstr "Вставить (внутр.)"
 
 #: src/control/Control.ContextMenu.js:159
 msgid "Internal Paste Special"
-msgstr ""
+msgstr "Специальная вставка (внутр.)"
 
 #: src/control/Control.DocumentRepair.js:33
 msgid "Repair Document"
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4-0' - loleaflet/po loleaflet/src

2020-02-25 Thread Andras Timar (via logerrit)

 loleaflet/po/templates/loleaflet-ui.pot |   58 ++--
 loleaflet/src/map/Map.js|4 +-
 2 files changed, 36 insertions(+), 26 deletions(-)

New commits:
commit 223aaf242df148b3fd7713a10c1b8e4268050256
Author: Andras Timar 
AuthorDate: Sat Mar 30 23:14:45 2019 +0100
Commit: Ashod Nakashian 
CommitDate: Wed Feb 26 02:13:24 2020 +0100

make these strings better localizable: minutes ago/seconds ago

Change-Id: Idf46c11bc4fccb14e4a3955e9ac88901ed94586b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89113
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Ashod Nakashian 

diff --git a/loleaflet/po/templates/loleaflet-ui.pot 
b/loleaflet/po/templates/loleaflet-ui.pot
index 0c2520c14..add48dd1d 100644
--- a/loleaflet/po/templates/loleaflet-ui.pot
+++ b/loleaflet/po/templates/loleaflet-ui.pot
@@ -8,7 +8,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2020-02-18 23:51+0100\n"
+"POT-Creation-Date: 2020-02-20 15:23+0100\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME \n"
 "Language-Team: LANGUAGE \n"
@@ -183,14 +183,14 @@ msgstr ""
 
 #: admin/src/AdminSocketOverview.js:104 admin/src/AdminSocketSettings.js:36
 #: js/toolbar.js:200 src/control/Control.Menubar.js:769
-#: src/control/Control.Tabs.js:74
+#: src/control/Control.Tabs.js:74 src/control/Control.Tabs.js:91
 msgid "OK"
 msgstr ""
 
 #: admin/src/AdminSocketOverview.js:105 admin/src/AdminSocketSettings.js:37
 #: js/toolbar.js:201 js/toolbar.js:894 js/toolbar.js:1076
 #: src/control/Control.Menubar.js:770 src/control/Control.Tabs.js:75
-#: src/layer/marker/Annotation.js:181
+#: src/control/Control.Tabs.js:92 src/layer/marker/Annotation.js:181
 msgid "Cancel"
 msgstr ""
 
@@ -756,7 +756,7 @@ msgstr ""
 msgid "Downloading..."
 msgstr ""
 
-#: src/control/Toolbar.js:103 src/map/Map.js:1193
+#: src/control/Toolbar.js:103 src/map/Map.js:1206
 msgid "Saving..."
 msgstr ""
 
@@ -780,81 +780,81 @@ msgstr ""
 msgid "Oops, there is a problem connecting to LibreOffice Online : "
 msgstr ""
 
-#: src/core/Socket.js:278
+#: src/core/Socket.js:280
 msgid "Unsupported server version."
 msgstr ""
 
-#: src/core/Socket.js:334
+#: src/core/Socket.js:336
 msgid "Session terminated by document owner"
 msgstr ""
 
-#: src/core/Socket.js:338
+#: src/core/Socket.js:340
 msgid "Idle document - please click to reload and resume editing"
 msgstr ""
 
-#: src/core/Socket.js:345
+#: src/core/Socket.js:347
 msgid "Server is shutting down for maintenance (auto-saving)"
 msgstr ""
 
-#: src/core/Socket.js:349
+#: src/core/Socket.js:351
 msgid "Oops, there is a problem connecting the document"
 msgstr ""
 
-#: src/core/Socket.js:353
+#: src/core/Socket.js:355
 msgid "Server is recycling and will be available shortly"
 msgstr ""
 
-#: src/core/Socket.js:385
+#: src/core/Socket.js:387
 msgid ""
 "Document has changed in storage. Loading the new document. Your version is "
 "available as revision."
 msgstr ""
 
-#: src/core/Socket.js:391
+#: src/core/Socket.js:393
 msgid ""
 "Restoring older revision. Any unsaved changes will be available in version "
 "history"
 msgstr ""
 
-#: src/core/Socket.js:513
+#: src/core/Socket.js:515
 msgid ""
 "Document has been changed in storage. What would you like to do with your "
 "unsaved changes?"
 msgstr ""
 
-#: src/core/Socket.js:518
+#: src/core/Socket.js:520
 msgid "Discard"
 msgstr ""
 
-#: src/core/Socket.js:523
+#: src/core/Socket.js:525
 msgid "Overwrite"
 msgstr ""
 
-#: src/core/Socket.js:528
+#: src/core/Socket.js:530
 msgid "Save to new file"
 msgstr ""
 
-#: src/core/Socket.js:599
+#: src/core/Socket.js:601
 msgid "Document requires password to view."
 msgstr ""
 
-#: src/core/Socket.js:602
+#: src/core/Socket.js:604
 msgid "Document requires password to modify."
 msgstr ""
 
-#: src/core/Socket.js:604
+#: src/core/Socket.js:606
 msgid "Hit Cancel to open in view-only mode."
 msgstr ""
 
-#: src/core/Socket.js:608
+#: src/core/Socket.js:610
 msgid "Wrong password provided. Please try again."
 msgstr ""
 
-#: src/core/Socket.js:724
+#: src/core/Socket.js:726
 msgid "Connecting..."
 msgstr ""
 
-#: src/core/Socket.js:884
+#: src/core/Socket.js:886
 msgid ""
 "Well, this is embarrassing, we cannot connect to your document. Please try "
 "again."
@@ -989,11 +989,21 @@ msgstr ""
 msgid "Initializing..."
 msgstr ""
 
-#: src/map/Map.js:1052
+#: src/map/Map.js:344
+#, javascript-format
+msgid "%d seconds ago"
+msgstr ""
+
+#: src/map/Map.js:347
+#, javascript-format
+msgid "%d minutes ago"
+msgstr ""
+
+#: src/map/Map.js:1065
 msgid "Inactive document - please click to resume editing"
 msgstr ""
 
-#: src/map/Map.js:1196
+#: src/map/Map.js:1209
 msgid "Loading..."
 msgstr ""
 
diff --git a/loleaflet/src/map/Map.js b/loleaflet/src/map/Map.js
index dabf7023e..b91a3d779 100644
--- a/loleaflet/src/map/Map.js
+++ b/loleaflet/src/map/Map.js
@@ -341,10 +341,10 @@ L.Map =

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4-0' - loleaflet/Makefile.am loleaflet/src

2020-02-25 Thread Henry Castro (via logerrit)

 loleaflet/Makefile.am|2 --
 loleaflet/src/core/Socket.js |2 +-
 loleaflet/src/map/Map.js |   39 ++-
 3 files changed, 27 insertions(+), 16 deletions(-)

New commits:
commit 68d55526267a4cda3185aefc677fdae6afb220f4
Author: Henry Castro 
AuthorDate: Sat Feb 16 18:09:52 2019 -0400
Commit: Ashod Nakashian 
CommitDate: Wed Feb 26 02:11:36 2020 +0100

loleaflet: remove timeago.min.js

simplify using Date.toLocaleDateString

Change-Id: Ib264cd90edd7ddacb3b944ee7f252648a629ab3f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89112
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Ashod Nakashian 

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index d32257ab1..98225ec67 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -102,8 +102,6 @@ NODE_MODULES_JS =\
node_modules/jquery-contextmenu/dist/jquery.contextMenu.js \
node_modules/jquery-ui/jquery-ui.js \
node_modules/smartmenus/dist/jquery.smartmenus.js \
-   node_modules/timeago.js/dist/timeago.min.js \
-   node_modules/timeago.js/dist/timeago.locales.min.js \
node_modules/autolinker/dist/Autolinker.js \
node_modules/json-js/json2.js \
node_modules/select2/dist/js/select2.js \
diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js
index e5cead41f..ec55e72b1 100644
--- a/loleaflet/src/core/Socket.js
+++ b/loleaflet/src/core/Socket.js
@@ -310,7 +310,7 @@ L.Socket = L.Class.extend({
return;
}
else if (textMsg.startsWith('lastmodtime: ')) {
-   var time = textMsg.substring(textMsg.indexOf(' '));
+   var time = textMsg.substring(textMsg.indexOf(' ') + 1);
this._map.updateModificationIndicator(time);
return;
}
diff --git a/loleaflet/src/map/Map.js b/loleaflet/src/map/Map.js
index 0e7642925..dabf7023e 100644
--- a/loleaflet/src/map/Map.js
+++ b/loleaflet/src/map/Map.js
@@ -16,7 +16,7 @@ function moveObjectVertically(obj, diff) {
}
 }
 
-/* global timeago closebutton vex revHistoryEnabled $ _ */
+/* global closebutton vex revHistoryEnabled $ _ */
 L.Map = L.Evented.extend({
 
options: {
@@ -326,20 +326,33 @@ L.Map = L.Evented.extend({
},
 
updateModificationIndicator: function(newModificationTime) {
-   this._lastmodtime = newModificationTime;
+   var timeout;
+
+   if (typeof newModificationTime === 'string') {
+   this._lastmodtime = newModificationTime;
+   }
+
+   clearTimeout(this._modTimeout);
+
if (this.lastModIndicator !== null && this.lastModIndicator !== 
undefined) {
-   // Get locale
-   var special = [ 'bn_IN', 'hi_IN', 'id_ID', 'nb_NO', 
'nn_NO', 'pt_BR', 'zh_CN', 'zh_TW'];
-   var locale = String.locale;
-   locale = locale.replace('-', '_');
-   if ($.inArray(locale, special) < 0) {
-   if (locale.indexOf('_') > 0) {
-   locale = locale.substring(0, 
locale.indexOf('_'));
-   }
+   var dateTime = new 
Date(this._lastmodtime.replace(/,.*/, 'Z'));
+   var dateValue = 
dateTime.toLocaleDateString(String.locale,
+   { year: 'numeric', month: 'short', day: 
'numeric', hour: '2-digit', minute: '2-digit' });
+
+   var elapsed = Date.now() - dateTime;
+   if (elapsed < 6) {
+   dateValue = Math.round(elapsed / 1000) + ' ' + 
_('seconds ago');
+   timeout = 6000;
+   } else if (elapsed < 360) {
+   dateValue = Math.round(elapsed / 6) + ' ' + 
_('minutes ago');
+   timeout = 6;
+   }
+
+   this.lastModIndicator.innerHTML = dateValue;
+
+   if (timeout) {
+   this._modTimeout = 
setTimeout(L.bind(this.updateModificationIndicator, this, -1), timeout);
}
-   // Real-time auto update
-   this.lastModIndicator.setAttribute('datetime', 
newModificationTime);
-   timeago().render(this.lastModIndicator, locale);
}
},
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-4-0' - loleaflet/Makefile.am loleaflet/src

2020-02-25 Thread Henry Castro (via logerrit)

 loleaflet/Makefile.am|3 +--
 loleaflet/src/core/Socket.js |4 +++-
 2 files changed, 4 insertions(+), 3 deletions(-)

New commits:
commit d622386116376360d679b7c5e4db39598469c4d3
Author: Henry Castro 
AuthorDate: Wed Feb 13 11:04:44 2019 -0400
Commit: Ashod Nakashian 
CommitDate: Wed Feb 26 02:08:29 2020 +0100

loleaflet: remove jquery.time ago

use Date.toLocaleDateString that returns a string with a language sensitive
representation of the date portion of this date

Change-Id: Id2e207e5b4d0dbc8d82498567c97105052d70b90
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89111
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Ashod Nakashian 

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index 258801b0e..d32257ab1 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -102,7 +102,6 @@ NODE_MODULES_JS =\
node_modules/jquery-contextmenu/dist/jquery.contextMenu.js \
node_modules/jquery-ui/jquery-ui.js \
node_modules/smartmenus/dist/jquery.smartmenus.js \
-   node_modules/timeago/jquery.timeago.js \
node_modules/timeago.js/dist/timeago.min.js \
node_modules/timeago.js/dist/timeago.locales.min.js \
node_modules/autolinker/dist/Autolinker.js \
@@ -235,7 +234,7 @@ $(builddir)/dist/bundle.js: $(NODE_MODULES_JS_SRC) \
$(builddir)/build/dist/loleaflet-src.js \
$(srcdir)/js/toolbar.js \
$(srcdir)/js/main.js \
-   --source-map --output $@
+   --output $@
 endif
 
 $(builddir)/dist/loleaflet.html: $(srcdir)/html/loleaflet.html.m4 
$(LOLEAFLET_HTML_DST) \
diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js
index c4468543b..e5cead41f 100644
--- a/loleaflet/src/core/Socket.js
+++ b/loleaflet/src/core/Socket.js
@@ -113,7 +113,9 @@ L.Socket = L.Class.extend({
if (parseInt(this._map.options.docParams.access_token_ttl) - 
Date.now() <= 0) {
expirymsg = errorMessages.sessionexpired;
}
-   var timerepr = 
$.timeago(parseInt(this._map.options.docParams.access_token_ttl)).replace(' 
ago', '');
+   var dateTime = new 
Date(parseInt(this._map.options.docParams.access_token_ttl));
+   var dateOptions = { year: 'numeric', month: 'short', day: 
'numeric', hour: '2-digit', minute: '2-digit' };
+   var timerepr = dateTime.toLocaleDateString(String.locale, 
dateOptions);
this._map.fire('warn', {msg: expirymsg.replace('%time', 
timerepr)});
 
// If user still doesn't refresh the session, warn again 
periodically
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2020-02-25 Thread Ashod Nakashian (via logerrit)

 loleaflet/src/control/Control.LokDialog.js |7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

New commits:
commit 16f1c624ea7070748d1ef05acd8f448b9af14419
Author: Ashod Nakashian 
AuthorDate: Tue Feb 25 19:27:14 2020 -0500
Commit: Ashod Nakashian 
CommitDate: Wed Feb 26 01:35:30 2020 +0100

leaflet: don't lose focus when the dialog cursor is hiden

The cursor visibility can change rapidly, and the formula-bar
seems to do this when typing into it. The result is that
because of losing the input focus we lose some of the input.

Instead, we only use the dialog cursor update to show the keyboard
rather than to hide it. For hiding, other messages will do it.

Change-Id: I0e8674170aa9d05b6ddc15de8d35792377b6725b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89490
Tested-by: Ashod Nakashian 
Reviewed-by: Ashod Nakashian 

diff --git a/loleaflet/src/control/Control.LokDialog.js 
b/loleaflet/src/control/Control.LokDialog.js
index 2a8d5688a..d106b1504 100644
--- a/loleaflet/src/control/Control.LokDialog.js
+++ b/loleaflet/src/control/Control.LokDialog.js
@@ -414,8 +414,11 @@ L.Control.LokDialog = L.Control.extend({
L.DomUtil.setStyle(this._dialogs[dlgId].cursor, 'left', x + 
'px');
L.DomUtil.setStyle(this._dialogs[dlgId].cursor, 'top', y + 
'px');
 
-   // Make sure the keyboard is visible if the user can type.
-   this._map.focus(cursorVisible);
+   // Make sure the keyboard is visible if there is a cursor.
+   // But don't hide the keyboard otherwise.
+   // At least the formula-input hides the cursor after each key 
input.
+   if (cursorVisible)
+   this._map.focus(true);
},
 
_createDialogCursor: function(dialogId) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2020-02-25 Thread Ashod Nakashian (via logerrit)

 loleaflet/src/control/Control.Toolbar.js |5 +++--
 loleaflet/src/layer/tile/TileLayer.js|1 +
 loleaflet/src/map/Map.js |   13 +
 3 files changed, 17 insertions(+), 2 deletions(-)

New commits:
commit 8ad7c4790c4a34d3e6a5ebfe5810b6cb00354acc
Author: Ashod Nakashian 
AuthorDate: Tue Feb 11 08:34:04 2020 -0500
Commit: Ashod Nakashian 
CommitDate: Wed Feb 26 01:33:30 2020 +0100

leaflet: fix searching in document functionality

This makes searching work again, but typing 'r'
still triggers F3, which simply matches the next
hit (on desktop, on mobile it works fine).

So (on desktop) typing 'your' will match the first 'you'
and the 'r' will move the search results to the
second 'you' (assuming there are at least two 'you'
entries in the document and one 'your').

Change-Id: Iab425afdfb3848ecff97f5599ceb7cae160b097d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89357
Tested-by: Ashod Nakashian 
Reviewed-by: Ashod Nakashian 

diff --git a/loleaflet/src/control/Control.Toolbar.js 
b/loleaflet/src/control/Control.Toolbar.js
index 6c47153f2..95c36dedd 100644
--- a/loleaflet/src/control/Control.Toolbar.js
+++ b/loleaflet/src/control/Control.Toolbar.js
@@ -1372,8 +1372,9 @@ function onSearchKeyPress(e) {
 }
 
 function onSearchFocus() {
-   // hide the caret in the main document
-   map._onLostFocus();
+   // Start searching.
+   map.fire('searchstart');
+
updateSearchButtons();
 }
 
diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 3ff3e8a58..6f7c924eb 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -2159,6 +2159,7 @@ L.TileLayer = L.GridLayer.extend({
if (this._map._permission === 'edit'
&& this._map._isCursorVisible   // only when LOK has told us it 
is ok
&& this._map.editorHasFocus()   // not when document is not 
focused
+   && !this._map.isSearching() // not when searching within 
the doc
&& !this._isZooming // not when zooming
 // && !this.isGraphicVisible() // not when sizing / 
positioning graphics
&& !this._isEmptyRectangle(this._visibleCursor)) {
diff --git a/loleaflet/src/map/Map.js b/loleaflet/src/map/Map.js
index cd2c8aad1..4aa7fd7c7 100644
--- a/loleaflet/src/map/Map.js
+++ b/loleaflet/src/map/Map.js
@@ -120,6 +120,8 @@ L.Map = L.Evented.extend({
this._winId = 0;
// The object of the dialog, if any (must have .focus callable).
this._activeDialog = null;
+   // True only when searching within the doc, as we need to use 
winId==0.
+   this._isSearching = false;
 
 
vex.dialogID = -1;
@@ -248,6 +250,8 @@ L.Map = L.Evented.extend({
// Fired to signal that the input focus is being changed.
this.on('changefocuswidget', this._onChangeFocusWidget, this);
 
+   this.on('searchstart', this._onSearchStart, this);
+
// View info (user names and view ids)
this._viewInfo = {};
this._viewInfoByUserName = {};
@@ -947,6 +951,10 @@ L.Map = L.Evented.extend({
this.fire('hyperlinkclicked', {url: helpURL});
},
 
+   isSearching: function() {
+   return this._isSearching;
+   },
+
_fireInitComplete: function (condition) {
if (this.initComplete) {
return;
@@ -1358,6 +1366,7 @@ L.Map = L.Evented.extend({
 
this._winId = winId;
this._activeDialog = dialog;
+   this._isSearching = false;
 
var doclayer = this._docLayer;
if (doclayer)
@@ -1402,6 +1411,10 @@ L.Map = L.Evented.extend({
}
},
 
+   _onSearchStart: function () {
+   this._isSearching = true;
+   },
+
_onUpdateProgress: function (e) {
if (e.statusType === 'start') {
if (this._socket.socket.readyState === 1) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2020-02-25 Thread Ashod Nakashian (via logerrit)

 loleaflet/src/layer/tile/TileLayer.js |5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit af58e1975028d1f35171b94b1a1393814607d023
Author: Ashod Nakashian 
AuthorDate: Wed Feb 19 09:47:56 2020 -0500
Commit: Ashod Nakashian 
CommitDate: Wed Feb 26 01:32:38 2020 +0100

leaflet: remove redundant check

Map.editorHasFocus() implies map.getWinId === 0.

Change-Id: I522a377df095683453d2499a87485465437f9abb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89356
Tested-by: Ashod Nakashian 
Reviewed-by: Ashod Nakashian 

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index a0fff8280..3ff3e8a58 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -1135,7 +1135,7 @@ L.TileLayer = L.GridLayer.extend({
.openOn(this._map);
}
 
-   if (!this._map.editorHasFocus() && (modifierViewId === 
this._viewId) && (this._map.getWinId === 0) && (this._map._permission === 
'edit')) {
+   if (!this._map.editorHasFocus() && (modifierViewId === 
this._viewId) && (this._map._permission === 'edit')) {
// Regain cursor if we had been out of focus and now 
have input.
// (only if it is our own cursor and the input is 
actually not
// going into a dialog)
@@ -2108,8 +2108,7 @@ L.TileLayer = L.GridLayer.extend({
var updated = true;
if (!this._cursorMarker) {
this._cursorMarker = L.cursor(cursorPos, 
pixBounds.getSize().multiplyBy(this._map.getZoomScale(this._map.getZoom())), 
{blink: true});
-   }
-   else {
+   } else {
var oldLatLng = this._cursorMarker.getLatLng();
this._cursorMarker.setLatLng(cursorPos, 
pixBounds.getSize().multiplyBy(this._map.getZoomScale(this._map.getZoom(;
var newLatLng = this._cursorMarker.getLatLng();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 130940] New: Defaulter Printer Settings Do Not Save

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130940

Bug ID: 130940
   Summary: Defaulter Printer Settings Do Not Save
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: oldironsides1...@hotmail.com


Description: Changing the default printer does not save. 

In LibreCalc it is possible to select a default printer. 
This feature is helpful because it eliminates the need to 
select the desired printer every time the spreadsheet is printed.

When the default printer is changed, the Save Icon on 
the top menu bar should change appearance
and should become active so the user can save the change. 

However, changing the default printer only affects 
the current session and does not prompt the user 
to save the change. Instead the Save Icon does not 
change appearance and does not allow the user to save changes. 


REPRODUCING THE PROBLEM:

1. Open a new LibreOffice Calc document on a machine having several 
printers.  
2. Enter "asdf" in Cell A1.
3. Save the file as "Test01.0ds"

4. Go to "File>Printer Settings..." in the Menu.
5. Make note of the Selected Printer.  
(In my case it is "Brother HL-L2390DW".)
6. In the drop down select another printer.  
(In my case I selected "OneNote")
8. After making the new selection, click the "OK" button.
NOTE: The floppy disk save icon in the menu bar
does not change to indicate a save is necessary 
and does not allow the user to save the 
printer setting change. 
9. Before closing the document. Go to "File>Print..." in the Menu. 
NOTE: The newly selected printer shows as the default 
in the dialogue box. 
10. Click the "Cancel" button. 
11. Close the document by clicking the "X" in the upper right of the window.

12. Re-open the document "Test01.ods". 
13. Go the "File>Printer Settings..."
NOTE: The original default printer is shown and 
changes were not saved. 
14. Click the "Cancel" button.
15. Go to "File>Print..." 
NOTE: The same default printer is shown in the "Print..." menu. 
The changes are not shown here either. 


WORK AROUND: 

To work around this problem and save a different printer as 
default for Calc document, first make a different change 
to the document which activates the Save Icon. 

For example, one could add a character in a cell and 
then delete that character from the cell.  
This trivial change activates the save icon in the menu and 
allows the user to save the change to the cell.  
Doing so also saves any changes made to the default printer
settings since the document was opened. 

+++
Environment and Software Versions:
+++

LibreOffice Version: 6.0.7.3 (x64)
Build ID: dc98aa7a9eabfd848af146d5086077aeed2ae4a5
CPU Threads: 4; OS; Windows 10.0; UI render:default;
Locale: en-US (en_US); Calc: CL


+++
Related Comments:
+++

I have not verified that this is exclusive to LibreCalc.  
It may also effect other programs in the LibreOffice Suite.


+++
Other Bugs that may be related:
+++
104698 printer settings not saved in DOCX files

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130937] Mouse-hold preview differs from result when changing a connector via dragging

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130937

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||rb.hensc...@t-online.de
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=93
   ||485

--- Comment #1 from Regina Henschel  ---
Confirm with Version: 6.3.2.2 (x64)
Build-ID: 98b30e735bda24bc04ab42594c85f7fd8be07b9c
CPU-Threads: 8; BS: Windows 10.0; UI-Render: GL; VCL: win; 
Gebietsschema: de-DE (en_US); UI-Sprache: de-DE
Calc: CL

I have seen in bug 93485 already, that the default route it shown in the
preview. But I will not set this as duplicate, because 93485 has a lot of
additional problems.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93485] Middle-of-curved-connector anchor moves away from the curve if edited

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=93485

Regina Henschel  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||0937

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107139] [META] Breeze icons

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107139

Rizal Muttaqin  changed:

   What|Removed |Added

 Depends on||130939


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130939
[Bug 130939] Breeze & Sifr: Missing Merge Cells dialog icons
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 125965] [META] Sifr icons

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=125965

Rizal Muttaqin  changed:

   What|Removed |Added

 Depends on||130939


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130939
[Bug 130939] Breeze & Sifr: Missing Merge Cells dialog icons
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130939] Breeze & Sifr: Missing Merge Cells dialog icons

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130939

Rizal Muttaqin  changed:

   What|Removed |Added

 Blocks||107139, 125965


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107139
[Bug 107139] [META] Breeze icons
https://bugs.documentfoundation.org/show_bug.cgi?id=125965
[Bug 125965] [META] Sifr icons
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130939] New: Breeze & Sifr: Missing Merge Cells dialog icons

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130939

Bug ID: 130939
   Summary: Breeze & Sifr: Missing Merge Cells dialog icons
   Product: LibreOffice
   Version: 6.4.0.0.alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: riz_17_...@yahoo.co.id

Created attachment 158191
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158191=edit
Missing Breeze icons in Merge Cells dialog

Description:
Breeze & Sifr icon theme have no images for Merge Cells dialog in Calc, they
are fallbacked to Colibre

I suggest to provide the icons

Steps to Reproduce:
1. Set Breeze or Sifr icon theme
2. Open Calc
3. Merge two cells
4. Look at these icons in Merge Cells dialog

Actual Results:
Icons are fallbacked Colibre

Expected Results:
Breeze and Sifr have their owns icons


Reproducible: Always


User Profile Reset: No

Version: 7.0.0.0.alpha0+
Build ID: a545e25314d464c190d9d504d78ec6cb67ead4fd
CPU threads: 4; OS: Linux 4.20; UI render: default; VCL: kf5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2020-02-20_15:31:00
Locale: id-ID (id_ID.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130939] Breeze & Sifr: Missing Merge Cells dialog icons

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130939

--- Comment #1 from Rizal Muttaqin  ---
Created attachment 158192
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158192=edit
Missing Sifr icons in Merge Cells dialog

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130113] PDF export of formulas in

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130113

raal  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130113] PDF export of formulas in

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130113

--- Comment #10 from niyum...@riseup.net ---
(In reply to raal from comment #9)
> I can not confirm with Version: 7.0.0.0.alpha0+
> Build ID: f32a59a52e3ee2a0a8df9bb76bc1ff0ada7c7f1d
> CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
> 
> Version 6.0 is old, please test with new version
> http://www.libreoffice.org/download/libreoffice-fresh/
> Thank you

Tried with 
Version: 6.3.5.2
Build ID: 1:6.3.5~rc2-0ubuntu0.18.04.1~lo1
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

It's solved.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130113] PDF export of formulas in

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130113

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||r...@post.cz

--- Comment #9 from raal  ---
I can not confirm with Version: 7.0.0.0.alpha0+
Build ID: f32a59a52e3ee2a0a8df9bb76bc1ff0ada7c7f1d
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 

Version 6.0 is old, please test with new version
http://www.libreoffice.org/download/libreoffice-fresh/
Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130788] Adding a New Column to a Table in Libreoffice Impress Formats the Column with Bulletted Text

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130788

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #1 from raal  ---
no repro Version: 7.0.0.0.alpha0+
Build ID: f32a59a52e3ee2a0a8df9bb76bc1ff0ada7c7f1d
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3;

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130877] Resize image - SHIFT does not keep aspect ratio when using corner handles

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130877

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG
 CC||r...@post.cz

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130906] [RFE] Copy a slide with source document proportions

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130906

raal  changed:

   What|Removed |Added

 CC||r...@post.cz
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: docker/README

2020-02-25 Thread Marco Marinello (via logerrit)

 docker/README |   10 ++
 1 file changed, 10 insertions(+)

New commits:
commit 0326037cbfcea000daaa52dcf2da1b571144cdd0
Author: Marco Marinello 
AuthorDate: Tue Feb 25 21:40:30 2020 +0100
Commit: Michael Meeks 
CommitDate: Tue Feb 25 22:45:43 2020 +0100

Add a README for docker directory

Signed-off-by: Marco Marinello 
Change-Id: I0cc9da9945763c48afd01ea231d9dfb5bb384d71
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89482
Tested-by: Michael Meeks 
Reviewed-by: Michael Meeks 

diff --git a/docker/README b/docker/README
new file mode 100644
index 0..36dbb7180
--- /dev/null
+++ b/docker/README
@@ -0,0 +1,10 @@
+LibreOffice Online docker
+
+This directory contains everything needed to compile a
+working docker container with LOOL.
+
+The provided l10n-docker-nightly.sh provides an automatic
+way to compile it with nightly translations.
+
+Further docs:
+https://wiki.documentfoundation.org/Development/BuildingOnline
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114027] [META] Libreoffice Vanilla (Mac Appstore version) bugs and enhancements

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114027

eisa01  changed:

   What|Removed |Added

 Depends on||130921
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=13 |
   |0921|


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=130921
[Bug 130921] LibreOffice Vanilla in Mac AppStore is out of date
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130921] LibreOffice Vanilla in Mac AppStore is out of date

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130921

eisa01  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Blocks||114027
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=11 |
   |4027|
 Status|UNCONFIRMED |NEW

--- Comment #1 from eisa01  ---
I can confirm that this is the case on my copy of LO Vanilla, no updates
recently

Version: 6.2.6.2
Build ID: 684e730861356e74889dfe6dbddd3562aae2e6ad
CPU threads: 4; OS: Mac OS X 10.14.6; UI render: default; VCL: osx; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114027
[Bug 114027] [META] Libreoffice Vanilla (Mac Appstore version) bugs and
enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130900] Enter Key broke animations in a textbox

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130900

raal  changed:

   What|Removed |Added

Version|unspecified |4.2.0.4 release
 CC||r...@post.cz

--- Comment #3 from raal  ---
confirm with Version 4.1.0.0.alpha0+ (Build ID:
efca6f15609322f62a35619619a6d5fe5c9bd5a)
and
Version: 7.0.0.0.alpha0+
Build ID: f32a59a52e3ee2a0a8df9bb76bc1ff0ada7c7f1d
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 

Not sure if it's a bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130933] wrap tools are jumping back and forward

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130933

raal  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: configure.ac

2020-02-25 Thread Miklos Vajna (via logerrit)

 configure.ac |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 047f66240c6b09a556a2aa3685507c05625ddd26
Author: Miklos Vajna 
AuthorDate: Tue Feb 25 15:44:24 2020 +0100
Commit: Miklos Vajna 
CommitDate: Tue Feb 25 22:28:20 2020 +0100

configure: fix outdated doc on --with-tls default

This was changed in commit 133d59adf744b2279a7d59071ca834ac766b9719
(configure: build oox with NSS backend by default, 2013-11-01), but the
documentation was not updated.

Change-Id: I468cb9a0274779318a7e1a86600fdef32756fa24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89460
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/configure.ac b/configure.ac
index c2c528b750c6..973866050a4e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1652,8 +1652,8 @@ AC_ARG_WITH(tls,
 AS_HELP_STRING([--with-tls],
 [Decides which TLS/SSL and cryptographic implementations to use for
  LibreOffice's code. Notice that this doesn't apply for depending
- libraries like "neon", for example. Default is to use OpenSSL
- although NSS is also possible. Notice that selecting NSS restricts
+ libraries like "neon", for example. Default is to use NSS
+ although OpenSSL is also possible. Notice that selecting NSS restricts
  the usage of OpenSSL in LO's code but selecting OpenSSL doesn't
  restrict by now the usage of NSS in LO's code. Possible values:
  openssl, nss. Example: --with-tls="nss"]),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 130938] FILESAVE number of columns can't exceed 256.

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130938

m.a.riosv  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|UNCONFIRMED |RESOLVED
 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
That it's a file format limitation, using the native format (ods) for
LibreOffice the limit is 1024 columns.

Please don't expose your email in the comments, this is a public site.

In any case it is not a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130933] wrap tools are jumping back and forward

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130933

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||r...@post.cz

--- Comment #2 from raal  ---
confirm with Version: 7.0.0.0.alpha0+
Build ID: f32a59a52e3ee2a0a8df9bb76bc1ff0ada7c7f1d
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3;

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130938] New: FILESAVE number of columns can't exceed 256.

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130938

Bug ID: 130938
   Summary: FILESAVE number of columns can't exceed 256.
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: agabi...@yahoo.com

FILESAVE:  My spreadsheet extends to column IV. I have entries in every column
that precedes this one (that is, from A to Z, AA to AZ, etc.) When I enter
values into column IW and IX, everything appears okay. But after closing the
file and opening it again, the new entries have disappeared!!! It's like the
Calc program can't handle a spreadsheet greater than IV columns wide (ie., 256
columns). Or, when it saves a spreadsheet of this size, it destroys the entries
at the far "right end".

Note, I always save in Excel '97-2003  ".xls" format.

all the best
Al Gabis
Fairfield, Iowa
agabi...@yahoo.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95274] Wrong editing languages offered

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95274

--- Comment #20 from Michael Bauer  ---
Created attachment 158190
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158190=edit
Screenshot of LO still offerent anything but what I expect

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130920] Running Basic code; error when viewing field value

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130920

raal  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||r...@post.cz
 Status|UNCONFIRMED |NEEDINFO

--- Comment #3 from raal  ---
work for me in Version: 7.0.0.0.alpha0+
Build ID: f32a59a52e3ee2a0a8df9bb76bc1ff0ada7c7f1d
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 

Please test it
http://dev-builds.libreoffice.org/daily/master/
Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95274] Wrong editing languages offered

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95274

--- Comment #19 from Michael Bauer  ---
Just to confirm this is still a problem in 6.3.4.2 (x64) (attaching
screenshot), today I've been offered en-US, Rumantsch and Irish (the last two I
have neither as a proofing language in LO or Office or as a keyboard layout,
goodness knows where LO is pulling them from) - but still not en-GB.

This is one of the reasons why I'm still not using LO as my main office suite,
I just can't work with software that takes such a haphazard approach to setting
the language of text and prefers to second guess the user on a word by word
basis (yes, type another word, get offered a new language).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basctl/source

2020-02-25 Thread Caolán McNamara (via logerrit)

 basctl/source/basicide/moduldlg.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit f1f9917a1bc9d11f6d76469a455a5337a89384ea
Author: Caolán McNamara 
AuthorDate: Tue Feb 25 14:02:48 2020 +
Commit: Caolán McNamara 
CommitDate: Tue Feb 25 22:11:26 2020 +0100

check if edit can be enabled after setting cursor into tree

Change-Id: I264dc4db7e3ddc64faf0edec18d96d2c46ce00f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89459
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/basctl/source/basicide/moduldlg.cxx 
b/basctl/source/basicide/moduldlg.cxx
index bf675de02fce..2e7191ee8abe 100644
--- a/basctl/source/basicide/moduldlg.cxx
+++ b/basctl/source/basicide/moduldlg.cxx
@@ -577,6 +577,7 @@ ObjectPage::~ObjectPage()
 void ObjectPage::ActivatePage()
 {
 m_xBasicBox->UpdateEntries();
+CheckButtons();
 }
 
 void ObjectPage::CheckButtons()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - cui/source svx/source

2020-02-25 Thread Henry Castro (via logerrit)

 cui/source/tabpages/tpline.cxx|8 ++--
 svx/source/sidebar/line/LinePropertyPanelBase.cxx |5 -
 svx/source/tbxctrls/linectrl.cxx  |6 +-
 svx/source/tbxctrls/tbcontrl.cxx  |8 ++--
 svx/source/xoutdev/xattr2.cxx |4 +++-
 svx/source/xoutdev/xtabdash.cxx   |5 -
 6 files changed, 28 insertions(+), 8 deletions(-)

New commits:
commit b214ef1f016f7470c363987e28dafea0b0a4
Author: Henry Castro 
AuthorDate: Mon Feb 24 13:34:03 2020 -0400
Commit: Andras Timar 
CommitDate: Tue Feb 25 21:47:58 2020 +0100

lok: use "None" string item in the ListBox control

The string item "- none -" confuse mobile users,
it is preferable to use the "None" string

Change-Id: Ib9b5716aa796624255fed7fac5413db69e028bb6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89368
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/cui/source/tabpages/tpline.cxx b/cui/source/tabpages/tpline.cxx
index b4498348c8ed..790c6dd3e082 100644
--- a/cui/source/tabpages/tpline.cxx
+++ b/cui/source/tabpages/tpline.cxx
@@ -53,6 +53,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #define MAX_BMP_WIDTH   16
 #define MAX_BMP_HEIGHT  16
@@ -227,7 +228,8 @@ void SvxLineTabPage::FillListboxes()
 m_xLbLineStyle->set_active( nOldSelect );
 
 // Line end style
-OUString sNone( SvxResId( RID_SVXSTR_NONE ) );
+OUString sNone( comphelper::LibreOfficeKit::isActive() ? SvxResId( 
RID_SVXSTR_INVISIBLE )
+: SvxResId( RID_SVXSTR_NONE ) );
 nOldSelect = m_xLbStartStyle->get_active();
 m_xLbStartStyle->clear();
 m_xLbStartStyle->append_text(sNone);
@@ -289,7 +291,9 @@ void SvxLineTabPage::ActivatePage( const SfxItemSet& rSet )
 *m_pnLineEndListState = ChangeType::NONE;
 
 nPos = m_xLbLineStyle->get_active();
-OUString sNone(SvxResId(RID_SVXSTR_NONE));
+OUString sNone( comphelper::LibreOfficeKit::isActive() ? SvxResId( 
RID_SVXSTR_INVISIBLE )
+: SvxResId( RID_SVXSTR_NONE ) );
+
 m_xLbStartStyle->clear();
 m_xLbStartStyle->append_text(sNone);
 
diff --git a/svx/source/sidebar/line/LinePropertyPanelBase.cxx 
b/svx/source/sidebar/line/LinePropertyPanelBase.cxx
index 50da4a9d6b14..824ee8126095 100644
--- a/svx/source/sidebar/line/LinePropertyPanelBase.cxx
+++ b/svx/source/sidebar/line/LinePropertyPanelBase.cxx
@@ -47,6 +47,8 @@
 #include 
 #include 
 
+#include 
+
 using namespace css;
 using namespace css::uno;
 
@@ -58,7 +60,8 @@ namespace
 void FillLineEndListBox(ListBox& rListBoxStart, ListBox& rListBoxEnd, const 
XLineEndList& rList, const BitmapEx& rBitmapZero)
 {
 const sal_uInt32 nCount(rList.Count());
-const OUString sNone(SvxResId(RID_SVXSTR_NONE));
+const OUString sNone(comphelper::LibreOfficeKit::isActive() ? 
SvxResId(RID_SVXSTR_INVISIBLE)
+: SvxResId(RID_SVXSTR_NONE));
 
 rListBoxStart.SetUpdateMode(false);
 rListBoxEnd.SetUpdateMode(false);
diff --git a/svx/source/tbxctrls/linectrl.cxx b/svx/source/tbxctrls/linectrl.cxx
index 1f158dab2855..fa67f56f7fb5 100644
--- a/svx/source/tbxctrls/linectrl.cxx
+++ b/svx/source/tbxctrls/linectrl.cxx
@@ -41,6 +41,8 @@
 #include 
 #include 
 
+#include 
+
 using namespace ::com::sun::star::uno;
 using namespace ::com::sun::star::beans;
 using namespace ::com::sun::star::util;
@@ -370,7 +372,9 @@ void SvxLineEndWindow::FillValueSet()
 // First entry: no line end.
 // An entry is temporarily added to get the UI bitmap
 basegfx::B2DPolyPolygon aNothing;
-mpLineEndList->Insert(o3tl::make_unique(aNothing, 
SvxResId(RID_SVXSTR_NONE)));
+mpLineEndList->Insert(o3tl::make_unique(aNothing,
+comphelper::LibreOfficeKit::isActive() ? SvxResId(RID_SVXSTR_INVISIBLE)
+: SvxResId(RID_SVXSTR_NONE)));
 const XLineEndEntry* pEntry = mpLineEndList->GetLineEnd(nCount);
 BitmapEx aBmp = mpLineEndList->GetUiBitmap( nCount );
 OSL_ENSURE( !aBmp.IsEmpty(), "UI bitmap was not created" );
diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index 6aa577dbf859..7c4bf4ad20e0 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -109,6 +109,8 @@
 #include 
 #include 
 
+#include 
+
 #define MAX_MRU_FONTNAME_ENTRIES5
 
 // don't make more than 15 entries visible at once
@@ -1640,7 +1642,8 @@ namespace
 
 NamedColor GetNoneColor()
 {
-return std::make_pair(COL_NONE_COLOR, SvxResId(RID_SVXSTR_NONE));
+return std::make_pair(COL_NONE_COLOR, 
comphelper::LibreOfficeKit::isActive() ? SvxResId(RID_SVXSTR_INVISIBLE)
+: SvxResId(RID_SVXSTR_NONE));
 }
 }
 
@@ -2376,7 +2379,8 @@ SvxLineWindow_Impl::SvxLineWindow_Impl( 
svt::ToolboxController& rController, vcl
 SetOutputSizePixel( Size( 114, 144 ) );
 
 m_aLineStyleLb->SetSourceUnit( FieldUnit::TWIP );
-

[Libreoffice-commits] online.git: configure.ac ios/Mobile.xcodeproj

2020-02-25 Thread Tor Lillqvist (via logerrit)

 configure.ac |1 +
 ios/Mobile.xcodeproj/project.pbxproj |2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 3de577d2c20d83be0079be4066196b476c46fa8d
Author: Tor Lillqvist 
AuthorDate: Tue Feb 25 17:29:09 2020 +0200
Commit: Tor Lillqvist 
CommitDate: Tue Feb 25 21:40:03 2020 +0100

Use the loolkitconfig-mobile.xcu on iOS, too

We can't rename a file in the Xcode project, so copy it to
ios/Mobile/loolkitconfig.xcu in the configure script, and use from
there.

Change-Id: I1e50235c06f528dd24d0d968aaccc994418b57d8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89466
Tested-by: Tor Lillqvist 
Reviewed-by: Tor Lillqvist 

diff --git a/configure.ac b/configure.ac
index 398d303e3..1a038efaf 100644
--- a/configure.ac
+++ b/configure.ac
@@ -983,6 +983,7 @@ AS_IF([test "$ENABLE_IOSAPP" = "true"],
   # iOS app.
   touch ios/Mobile/Branding/branding.css
   fi
+  cp loolkitconfig-mobile.xcu ios/Mobile/loolkitconfig.xcu
fi
   ])
 AC_SUBST(IOSAPP_FONTS)
diff --git a/ios/Mobile.xcodeproj/project.pbxproj 
b/ios/Mobile.xcodeproj/project.pbxproj
index 9fab320d2..e20f49084 100644
--- a/ios/Mobile.xcodeproj/project.pbxproj
+++ b/ios/Mobile.xcodeproj/project.pbxproj
@@ -598,7 +598,7 @@
BE7D6A6523FA9C2700C2E605 /* defaultprovider.hxx */ = {isa = 
PBXFileReference; lastKnownFileType = sourcecode.cpp.h; name = 
defaultprovider.hxx; path = 
"../../ios-device/configmgr/source/defaultprovider.hxx"; sourceTree = 
""; };
BE7D6A6623FA9C2700C2E605 /* parser.hxx */ = {isa = 
PBXFileReference; lastKnownFileType = sourcecode.cpp.h; name = parser.hxx; path 
= "../../ios-device/configmgr/source/parser.hxx"; sourceTree = ""; };
BE7D6A6723FA9C2700C2E605 /* rootnode.cxx */ = {isa = 
PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name = rootnode.cxx; 
path = "../../ios-device/configmgr/source/rootnode.cxx"; sourceTree = 
""; };
-   BE7D6A6A23FAA8B500C2E605 /* loolkitconfig.xcu */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xml; name = 
loolkitconfig.xcu; path = ../../../loolkitconfig.xcu; sourceTree = ""; };
+   BE7D6A6A23FAA8B500C2E605 /* loolkitconfig.xcu */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xml; name = 
loolkitconfig.xcu; path = ../loolkitconfig.xcu; sourceTree = ""; };
BE7E5B7623AD07BE00F9462A /* SvxPresetListBox.cxx */ = {isa = 
PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name = 
SvxPresetListBox.cxx; path = 
"../../ios-device/svx/source/tbxctrls/SvxPresetListBox.cxx"; sourceTree = 
""; };
BE7E5B7723AD07BE00F9462A /* tbxcolor.cxx */ = {isa = 
PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name = tbxcolor.cxx; 
path = "../../ios-device/svx/source/tbxctrls/tbxcolor.cxx"; sourceTree = 
""; };
BE7E5B7823AD07BE00F9462A /* tbxdrctl.cxx */ = {isa = 
PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name = tbxdrctl.cxx; 
path = "../../ios-device/svx/source/tbxctrls/tbxdrctl.cxx"; sourceTree = 
""; };
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sw/source

2020-02-25 Thread Michael Stahl (via logerrit)

 sw/source/filter/ww8/docxexport.cxx |9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

New commits:
commit 09775c1806e9dd32eee8aeff96609186368cb0e7
Author: Michael Stahl 
AuthorDate: Mon Feb 24 15:20:20 2020 +0100
Commit: Caolán McNamara 
CommitDate: Tue Feb 25 21:25:12 2020 +0100

sw: DOCX export: limit FORMDROPDOWN listEntry to Word's abilities

In theory wml.xsd says:

 

In practice Word 2013 refuses to load a file with 26 listEntry in one
FORMDROPDOWN field.

Interestingly w:result w:val larger than the number of entries does not
cause Word to complain. Go figure.

Change-Id: I3a61533f9ee4ba3917a9c3bc55a483fd587f0471
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89358
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit d9634e3c9bfaf826b3d4d39e9a57d6c2d8d9a3dc)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89432
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/filter/ww8/docxexport.cxx 
b/sw/source/filter/ww8/docxexport.cxx
index 312500a4502c..d025d6b712ec 100644
--- a/sw/source/filter/ww8/docxexport.cxx
+++ b/sw/source/filter/ww8/docxexport.cxx
@@ -358,12 +358,13 @@ void DocxExport::DoComboBox(const OUString& rName,
 
 m_pDocumentFS->singleElementNS(XML_w, XML_result, FSNS(XML_w, XML_val), 
OString::number(nId));
 
-// Loop over the entries
-
-for (const auto& rItem : rListItems)
+// unfortunately Word 2013 refuses to load DOCX with more than 25 listEntry
+SAL_WARN_IF(25 < rListItems.getLength(), "sw.ww8", "DocxExport::DoComboBox 
data loss with more than 25 entries");
+auto const nSize(std::min(sal_Int32(25), rListItems.getLength()));
+for (auto i = 0; i < nSize; ++i)
 {
 m_pDocumentFS->singleElementNS( XML_w, XML_listEntry,
-FSNS( XML_w, XML_val ), rItem.toUtf8() );
+FSNS(XML_w, XML_val), rListItems[i].toUtf8() );
 }
 
 m_pDocumentFS->endElementNS( XML_w, XML_ddList );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2020-02-25 Thread Jan Holesovsky (via logerrit)

 loleaflet/src/map/handler/Map.SlideShow.js |   12 
 1 file changed, 4 insertions(+), 8 deletions(-)

New commits:
commit 6f3f52304f122036e1bc405a8882d9a6ef1a90d1
Author: Jan Holesovsky 
AuthorDate: Mon Feb 24 21:49:27 2020 +0100
Commit: Andras Timar 
CommitDate: Tue Feb 25 21:03:37 2020 +0100

Don't bind the slideshow downloading to the richdocuments...

... decide based on the DownloadAsPostMessage wopi value instead.

The idea is that the Nextcloud app actually sets the DownloadAsPostMessage
wopi value to true, which means that all the downloading (including
slideshow) is passed as Download_As postMessage anyway.

So deciding here based on the existence of the Nextcloud app is
not necessary, because there might be others who set the
DownloadAsPostMessage and rely on the Download_As postMessage,
but would get a non-functional iframe over the top of the editing
window.

Change-Id: I4a5c1d9ef6276908a1b3910a4269091955cdc490
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89382
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/loleaflet/src/map/handler/Map.SlideShow.js 
b/loleaflet/src/map/handler/Map.SlideShow.js
index 4f268df24..0a1987707 100644
--- a/loleaflet/src/map/handler/Map.SlideShow.js
+++ b/loleaflet/src/map/handler/Map.SlideShow.js
@@ -29,7 +29,7 @@ L.Map.SlideShow = L.Handler.extend({
return;
}
 
-   if (!window.RichDocumentsMobileInterface) {
+   if (!this._map['wopi'].DownloadAsPostMessage) {
this._slideShow = L.DomUtil.create('iframe', 
'leaflet-slideshow', this._map._container);
if (this._slideShow.requestFullscreen) {
this._slideShow.requestFullscreen();
@@ -53,7 +53,7 @@ L.Map.SlideShow = L.Handler.extend({
},
 
_onFullScreenChange: function () {
-   if (window.RichDocumentsMobileInterface) {
+   if (this._map['wopi'].DownloadAsPostMessage) {
return;
}
 
@@ -67,12 +67,8 @@ L.Map.SlideShow = L.Handler.extend({
},
 
_onSlideDownloadReady: function (e) {
-   if (window.RichDocumentsMobileInterface) {
-   window.RichDocumentsMobileInterface.slideShow(e.url);
-   } else {
-   this._slideShow.src = e.url;
-   this._slideShow.contentWindow.focus();
-   }
+   this._slideShow.src = e.url;
+   this._slideShow.contentWindow.focus();
}
 });
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 130930] Ability to remove one specific direct formatting

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130930

--- Comment #7 from Frederic Parrenin 
 ---
Thank you for your understanding.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 130930] Ability to remove one specific direct formatting

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130930

--- Comment #7 from Frederic Parrenin 
 ---
Thank you for your understanding.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: dbaccess/source

2020-02-25 Thread Caolán McNamara (via logerrit)

 dbaccess/source/ui/dlg/dlgsize.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 72a5c8a6f5d5515aed47ff803bc277353aa54061
Author: Caolán McNamara 
AuthorDate: Tue Feb 25 12:30:38 2020 +
Commit: Caolán McNamara 
CommitDate: Tue Feb 25 20:50:25 2020 +0100

Resolves: tdf130874 reversed logic

Change-Id: I2ccac01f271ec803547ab36359f2273312df87e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89451
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/dbaccess/source/ui/dlg/dlgsize.cxx 
b/dbaccess/source/ui/dlg/dlgsize.cxx
index 2c10d235cdcc..45c624518f1a 100644
--- a/dbaccess/source/ui/dlg/dlgsize.cxx
+++ b/dbaccess/source/ui/dlg/dlgsize.cxx
@@ -66,8 +66,8 @@ sal_Int32 DlgSize::GetValue() const
 
 IMPL_LINK_NOARG(DlgSize, CbClickHdl, weld::ToggleButton&, void)
 {
-m_xMF_VALUE->set_sensitive(m_xCB_STANDARD->get_active());
-if (!m_xCB_STANDARD->get_active())
+m_xMF_VALUE->set_sensitive(!m_xCB_STANDARD->get_active());
+if (m_xCB_STANDARD->get_active())
 {
 // don't use getValue as this will use m_xCB_STANDARD->to determine if 
we're standard
 m_nPrevValue = 
static_cast(m_xMF_VALUE->get_value(FieldUnit::CM));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2-0' - loleaflet/src

2020-02-25 Thread Tamás Zolnai (via logerrit)

 loleaflet/src/control/Control.Menubar.js |2 +-
 loleaflet/src/core/LOUtil.js |1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 445e847e0c720c6bdb756ce3512218778ce8dd8d
Author: Tamás Zolnai 
AuthorDate: Tue Feb 25 12:10:53 2020 +0100
Commit: Andras Timar 
CommitDate: Tue Feb 25 20:44:26 2020 +0100

mobile: fix-up non-breaking space insertion.

Make it to have the icon, but also trigger the right
uno command.

Change-Id: Ic762fee0eee0f1a6bc793edc98ed2217075364f7
(cherry picked from commit 4ca5089d56369d335a39c13e428d2e932c0ac8a3)
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89452
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/loleaflet/src/control/Control.Menubar.js 
b/loleaflet/src/control/Control.Menubar.js
index 8517f8c0d..a4b876536 100644
--- a/loleaflet/src/control/Control.Menubar.js
+++ b/loleaflet/src/control/Control.Menubar.js
@@ -648,7 +648,7 @@ L.Control.Menubar = L.Control.extend({
{name: _UNO('.uno:HyperlinkDialog'), 
id: 'inserthyperlink', type: 'action'},
{name: _UNO('.uno:ShapesMenu'), id: 
'insertshape', type: 'action'},
{name: _UNO('.uno:FormattingMarkMenu', 
'text'), id: 'formattingmark', type: 'menu', menu: [
-   {name: 
_UNO('.uno:InsertNonBreakingSpace'), id: 'insertnonbreakingspace'},
+   {uno: 
'.uno:InsertNonBreakingSpace'},
{uno: '.uno:InsertHardHyphen'},
{uno: '.uno:InsertSoftHyphen'},
{uno: '.uno:InsertZWSP'},
diff --git a/loleaflet/src/core/LOUtil.js b/loleaflet/src/core/LOUtil.js
index f540e6da2..7ff1a5272 100644
--- a/loleaflet/src/core/LOUtil.js
+++ b/loleaflet/src/core/LOUtil.js
@@ -92,7 +92,6 @@ L.LOUtil = {
commandWithoutIcon: [
'InsertPageHeader',
'InsertPageFooter',
-   'InsertNonBreakingSpace',
'InsertHardHyphen',
'InsertSoftHyphen',
'InsertZWSP',
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 130935] Crash when selecting txt file after insert sheet from file

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130935

--- Comment #2 from Nemo_bis  ---
Created attachment 158189
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158189=edit
Example text file

It's a very simple text file that I'm importing. It has unix file ending and
just ASCII codes, I've tried other files and the same happens.

Actually I see the crash happens even if, after selecting the file, I cancel
the import from the window where I'm asked in what format the CSV file is etc.

I'm in Fedora 30 with KDE (plasmashell 5.15.5, dolphin 19.08.3). As a first
step I've tried updating to 6.3.4.2-2.fc31 and the same happened:

Fatal exception: Signal 11
Stack:
/usr/lib64/libreoffice/program/libuno_sal.so.3(+0x3d373)[0x7f034d67d373]
/usr/lib64/libreoffice/program/libuno_sal.so.3(+0x3d4ea)[0x7f034d67d4ea]
/lib64/libc.so.6(+0x37ec0)[0x7f034d377ec0]
/usr/lib64/libreoffice/program/../program/libfps_officelo.so(+0x52c94)[0x7f0320b0ac94]
/usr/lib64/libreoffice/program/libsvtlo.so(+0x1d083d)[0x7f034ac3083d]
/usr/lib64/libreoffice/program/libvcllo.so(_ZN9SvImpLBox15MouseButtonDownERK10MouseEvent+0x1e8)[0x7f0349f2a1b8]
/usr/lib64/libreoffice/program/libvcllo.so(+0x421255)[0x7f0349e21255]
/usr/lib64/libreoffice/program/libvcllo.so(+0x42171e)[0x7f0349e2171e]
/usr/lib64/libreoffice/program/libvcllo.so(+0x422273)[0x7f0349e22273]
/usr/lib64/libreoffice/program/libvclplug_gtk3lo.so(+0x14b089)[0x7f033df33089]
/usr/lib64/libreoffice/program/libvclplug_gtk3lo.so(+0x14c75d)[0x7f033df3475d]
/lib64/libgtk-3.so.0(+0x3e65cb)[0x7f033da665cb]
/lib64/libgobject-2.0.so.0(g_closure_invoke+0x1b2)[0x7f0346573742]
/lib64/libgobject-2.0.so.0(+0x274f4)[0x7f03465874f4]
/lib64/libgobject-2.0.so.0(g_signal_emit_valist+0x571)[0x7f034658f9c1]
/lib64/libgobject-2.0.so.0(g_signal_emit+0x93)[0x7f0346590973]
/lib64/libgtk-3.so.0(+0x391153)[0x7f033da11153]
/lib64/libgtk-3.so.0(+0x24cd08)[0x7f033d8ccd08]
/lib64/libgtk-3.so.0(gtk_main_do_event+0x85b)[0x7f033d8cef1b]
/lib64/libgdk-3.so.0(+0x3cf79)[0x7f033d5b4f79]
/lib64/libgdk-3.so.0(+0x70086)[0x7f033d5e8086]
/lib64/libglib-2.0.so.0(g_main_context_dispatch+0x15d)[0x7f0346487ecd]
/lib64/libglib-2.0.so.0(+0x50260)[0x7f0346488260]
/lib64/libglib-2.0.so.0(g_main_loop_run+0xc3)[0x7f0346488593]
/usr/lib64/libreoffice/program/libvclplug_gtk3lo.so(+0xde699)[0x7f033dec6699]
/usr/lib64/libreoffice/program/libscuilo.so(+0xc13d2)[0x7f03211613d2]
/usr/lib64/libreoffice/program/../program/libsclo.so(_ZN14ScTabViewShell12ExecuteTableER10SfxRequest+0x1882)[0x7f0323336742]
/usr/lib64/libreoffice/program/libsfxlo.so(+0x2b07f6)[0x7f034c1187f6]
/usr/lib64/libreoffice/program/libsfxlo.so(_ZN13SfxDispatcher8Execute_ER8SfxShellRK7SfxSlotR10SfxRequest11SfxCallMode+0x11d)[0x7f034c118dad]
/usr/lib64/libreoffice/program/libsfxlo.so(+0x2ad73e)[0x7f034c11573e]
/usr/lib64/libreoffice/program/libsfxlo.so(+0x304e74)[0x7f034c16ce74]
/usr/lib64/libreoffice/program/libsfxlo.so(+0x305433)[0x7f034c16d433]
/usr/lib64/libreoffice/program/../program/libfwklo.so(+0x1e4384)[0x7f0337efc384]
/usr/lib64/libreoffice/program/libvcllo.so(_ZN4Menu6SelectEv+0x74)[0x7f0349dac194]
/usr/lib64/libreoffice/program/libvcllo.so(+0x3aede0)[0x7f0349daede0]
/usr/lib64/libreoffice/program/libvcllo.so(_ZN9PopupMenu7ExecuteEPN3vcl6WindowERKN5tools9RectangleE14PopupMenuFlags+0x73)[0x7f0349daf4b3]
/usr/lib64/libreoffice/program/libvcllo.so(_ZN9PopupMenu7ExecuteEPN3vcl6WindowERK5Point+0x3f)[0x7f0349daf57f]
/usr/lib64/libreoffice/program/libsfxlo.so(_ZN13SfxDispatcher12ExecutePopupERKN3rtl8OUStringEPN3vcl6WindowEPK5Point+0xec6)[0x7f034c11f366]
/usr/lib64/libreoffice/program/../program/libsclo.so(+0xcb3b4b)[0x7f0323303b4b]
/usr/lib64/libreoffice/program/libvcllo.so(+0x41e940)[0x7f0349e1e940]
/usr/lib64/libreoffice/program/libvcllo.so(+0x4214d1)[0x7f0349e214d1]
/usr/lib64/libreoffice/program/libvcllo.so(+0x42171e)[0x7f0349e2171e]
/usr/lib64/libreoffice/program/libvcllo.so(+0x422273)[0x7f0349e22273]
/usr/lib64/libreoffice/program/libvclplug_gtk3lo.so(+0x14b089)[0x7f033df33089]
/usr/lib64/libreoffice/program/libvclplug_gtk3lo.so(+0x14c75d)[0x7f033df3475d]
/lib64/libgtk-3.so.0(+0x3e65cb)[0x7f033da665cb]
/lib64/libgobject-2.0.so.0(g_closure_invoke+0x1b2)[0x7f0346573742]
/lib64/libgobject-2.0.so.0(+0x274f4)[0x7f03465874f4]
/lib64/libgobject-2.0.so.0(g_signal_emit_valist+0x571)[0x7f034658f9c1]
/lib64/libgobject-2.0.so.0(g_signal_emit+0x93)[0x7f0346590973]
/lib64/libgtk-3.so.0(+0x391153)[0x7f033da11153]
/lib64/libgtk-3.so.0(+0x24cd08)[0x7f033d8ccd08]
/lib64/libgtk-3.so.0(gtk_main_do_event+0x85b)[0x7f033d8cef1b]
/lib64/libgdk-3.so.0(+0x3cf79)[0x7f033d5b4f79]
/lib64/libgdk-3.so.0(+0x70086)[0x7f033d5e8086]
/lib64/libglib-2.0.so.0(g_main_context_dispatch+0x15d)[0x7f0346487ecd]
/lib64/libglib-2.0.so.0(+0x50260)[0x7f0346488260]
/lib64/libglib-2.0.so.0(g_main_context_iteration+0x33)[0x7f0346488303]
/usr/lib64/libreoffice/program/libvclplug_gtk3lo.so(+0xd530c)[0x7f033debd30c]
/usr/lib64/libreoffice/program/libvcllo.so(+0x6c4592)[0x7f034a0c4592]

[Libreoffice-bugs] [Bug 130936] Provide Proper Icon for Thumbnail MIME type Icon in Start Center

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130936

--- Comment #2 from Rizal Muttaqin  ---
(In reply to Rizal Muttaqin from comment #1)
> The MIME type overlay icons are taken from icon-themes/*/res/*128.png or
> icon-themes/*/res/*128.svg

Another thing that those icons are not MIME type actually, but the module of
the software. It's not appropiate IMHO.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130936] Provide Proper Icon Size for Thumbnail MIME type Icon in Start Center

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130936

Rizal Muttaqin  changed:

   What|Removed |Added

Summary|Provide Proper Icon for |Provide Proper Icon Size
   |Thumbnail MIME type Icon in |for Thumbnail MIME type
   |Start Center|Icon in Start Center

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 130930] Ability to remove one specific direct formatting

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130930

V Stuart Foote  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|WORKSFORME  |---

--- Comment #6 from V Stuart Foote  ---
To unconfirmed. For UX-advise

I have not issue directly editing the XML (content.xml, styles.xml) from an ODF
archive (easier in Flat ODF .fodt).

As noted, the Find/Replace dialog 'Format' will do a replacement 1-1 of
font/effect/size-- but there is no replacement Format to revert the found
selection's span to a non-DF span.

Would need a 'Format' replace action to actually clear the DF applied to the
found span, merging it into the current Paragraph's run. And if the
style:name/style:family 'T' direct formatting becomes unused, to clear it from
the content XML.

So, guess there is potential to implement.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 130930] Ability to remove one specific direct formatting

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130930

V Stuart Foote  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|WORKSFORME  |---

--- Comment #6 from V Stuart Foote  ---
To unconfirmed. For UX-advise

I have not issue directly editing the XML (content.xml, styles.xml) from an ODF
archive (easier in Flat ODF .fodt).

As noted, the Find/Replace dialog 'Format' will do a replacement 1-1 of
font/effect/size-- but there is no replacement Format to revert the found
selection's span to a non-DF span.

Would need a 'Format' replace action to actually clear the DF applied to the
found span, merging it into the current Paragraph's run. And if the
style:name/style:family 'T' direct formatting becomes unused, to clear it from
the content XML.

So, guess there is potential to implement.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130934] Free Internet Security solution for all types of viruses.

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130934

Telesto  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
Version|1.12|unspecified
Product|cppunit |LibreOffice
 Resolution|--- |INVALID
  Component|General |deletionRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130937] New: Mouse-hold preview differs from result when changing a connector via dragging

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130937

Bug ID: 130937
   Summary: Mouse-hold preview differs from result when changing a
connector via dragging
   Product: LibreOffice
   Version: 6.2.3.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sam...@web.de

Description:
 When editing a connector, the on-mouse-hold preview does not coincide with the
result. Sometimes the preview is completely off (this is a minor problem, as
this is clearly an error) and sometimes the preview is off by a shifting term
(this is a major problem, because the preview is misleading).

Steps to Reproduce:
1. Create two boxes below each other (move the lower a bit to the right)
2. Create a connector between the right middle handle of the upper box and the
right middle handle of the lower box.
3. Drag the middle handle of the connector.
(4.) Move the boxes closer together.
(5.) Try again.

Actual Results:
While dragging, an opaque connector appears to show the end result of dragging
the handle. However, this preview is not correct / does not coincde with the
end result. Sometimes the preview connector has a totally different path than
the actual new one; sometimes it is like the correct results but shifted.

Expected Results:
The preview should coincide with the end result.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
The exact behaviour changes somwhat unpredictably with shifting around the
connected objects.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130936] Provide Proper Icon for Thumbnail MIME type Icon in Start Center

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130936

Rizal Muttaqin  changed:

   What|Removed |Added

Summary|Shrink Thumbnail MIME type  |Provide Proper Icon for
   |Icon Size in Start Center   |Thumbnail MIME type Icon in
   ||Start Center

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130936] Shrink Thumbnail MIME type Icon Size in Start Center

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130936

--- Comment #1 from Rizal Muttaqin  ---
The MIME type overlay icons are taken from icon-themes/*/res/*128.png or
icon-themes/*/res/*128.svg

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130935] Crash when selecting txt file after insert sheet from file

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130935

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
On pc Debian testing x86-64 with LO 6.4.1.1 + gtk3, I don't reproduce this.

Could you give a try at:
https://wiki.documentfoundation.org/QA/FirstSteps
?

If you still reproduce this, could you attach the example file of words? Does
it contains plain ascii or special/accentuated characters?

Finally, oi, which Linux distrib are you, could you give a try to a more recent
LO version since 6.2 branch is EOL? (if Ubuntu, you can try LO ppa).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130936] New: Shrink Thumbnail MIME type Icon Size in Start Center

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130936

Bug ID: 130936
   Summary: Shrink Thumbnail MIME type Icon Size in Start Center
   Product: LibreOffice
   Version: 6.4.0.0.alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: riz_17_...@yahoo.co.id

Created attachment 158188
  --> https://bugs.documentfoundation.org/attachment.cgi?id=158188=edit
Mimetype colibre icon overlay are not that crisp

In 6.4 release, we got Mime type icon overlay over recent file (tdf#125756).
This so helpful to determine what filetype a file in the star center is.

Somehow this icons are taken from 128px*128px size while seeing the source code
(sfx2/source/control/recentdocsview.cxx) the overlay size is 50px*50px (or
40px*40pc ? I’m not sure). This leads to not pixel perfect appearance.

So my suggestion is to provide a mechanisme to show proper icon size whether we
should provide another icon files under sfx2 directory (or define them in
links.txt) or use already available icon (we have 32px*32px icons under res
directory).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104444] [META] DOCX (OOXML) table-related issues

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=10
Bug 10 depends on bug 123757, which changed state.

Bug 123757 Summary: DOCX import: don't join different style tables (originally: 
Bad interpretation of table background color for .docx documents)
https://bugs.documentfoundation.org/show_bug.cgi?id=123757

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123757] DOCX import: don't join different style tables (originally: Bad interpretation of table background color for .docx documents)

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=123757

László Németh  changed:

   What|Removed |Added

Summary|Bad interpretation of table |DOCX import: don't join
   |background color for .docx  |different style tables
   |documents   |(originally: Bad
   ||interpretation of table
   ||background color for .docx
   ||documents)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123757] DOCX import: don't join different style tables (originally: Bad interpretation of table background color for .docx documents)

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=123757

László Németh  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 123757] Bad interpretation of table background color for .docx documents

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=123757

--- Comment #9 from Commit Notification 
 ---
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d5aeb48c7035c5518c4978760e93a49351a9e57a

tdf#123757 DOCX import: separate different style tables

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa writerfilter/source

2020-02-25 Thread László Németh (via logerrit)

 sw/qa/extras/ooxmlexport/data/tdf123757.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlexport14.cxx   |7 
 writerfilter/source/dmapper/DomainMapperTableManager.cxx |   24 +++
 writerfilter/source/dmapper/DomainMapperTableManager.hxx |2 -
 4 files changed, 27 insertions(+), 6 deletions(-)

New commits:
commit d5aeb48c7035c5518c4978760e93a49351a9e57a
Author: László Németh 
AuthorDate: Tue Feb 25 09:46:15 2020 +0100
Commit: László Németh 
CommitDate: Tue Feb 25 19:54:19 2020 +0100

tdf#123757 DOCX import: separate different style tables

to avoid of losing table layout, color etc. during
their prohibited combination into one table: table
style of the second table overwrote the table style
of the first table, or without table style, the
second table was overwritten by the table style of
the first table.

Change-Id: I0a2663d41f7d019e7b329198944a300260025b65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89416
Tested-by: Jenkins
Tested-by: László Németh 
Reviewed-by: László Németh 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf123757.docx 
b/sw/qa/extras/ooxmlexport/data/tdf123757.docx
new file mode 100644
index ..6cfc8210c011
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf123757.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
index 9a35092981ba..ae8c0a86be45 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
@@ -544,6 +544,13 @@ DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf128290, 
"tdf128290.odt")
 assertXPath(pXml, "/w:document/w:body/w:tbl/w:tblPr/w:tblLayout", "type", 
"fixed");
 }
 
+DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf123757, "tdf123757.docx")
+{
+xmlDocPtr pXml = parseExport("word/document.xml");
+CPPUNIT_ASSERT(pXml);
+assertXPath(pXml, "/w:document/w:body/w:tbl", 2);
+}
+
 DECLARE_OOXMLEXPORT_TEST(testContSectBreakHeaderFooter, 
"cont-sect-break-header-footer.docx")
 {
 // Load a document with a continuous section break on page 2.
diff --git a/writerfilter/source/dmapper/DomainMapperTableManager.cxx 
b/writerfilter/source/dmapper/DomainMapperTableManager.cxx
index 0701dc1610e1..18ddcd902b35 100644
--- a/writerfilter/source/dmapper/DomainMapperTableManager.cxx
+++ b/writerfilter/source/dmapper/DomainMapperTableManager.cxx
@@ -238,9 +238,8 @@ bool DomainMapperTableManager::sprm(Sprm & rSprm)
 break;
 case NS_ooxml::LN_CT_TblPrBase_tblStyle: //table style name
 {
-m_sTableStyleName = pValue->getString();
 TablePropertyMapPtr pPropMap( new TablePropertyMap );
-pPropMap->Insert( META_PROP_TABLE_STYLE_NAME, uno::makeAny( 
m_sTableStyleName ));
+pPropMap->Insert( META_PROP_TABLE_STYLE_NAME, uno::makeAny( 
pValue->getString() ));
 insertTableProps(pPropMap);
 }
 break;
@@ -444,6 +443,8 @@ void DomainMapperTableManager::startLevel( )
 m_aGridSpans.push_back( pNewSpans );
 m_aCellWidths.push_back( pNewCellWidths );
 m_aTablePositions.push_back( pNewPositionHandler );
+// empty name will be replaced by the table style name, if it exists
+m_aTableStyleNames.push_back( OUString() );
 
 TablePositionHandlerPtr pTmpPosition;
 TablePropertyMapPtr pTmpProperties( new TablePropertyMap( ) );
@@ -500,6 +501,7 @@ void DomainMapperTableManager::endLevel( )
 // Pop back the table position after endLevel as it's used
 // in the endTable method called in endLevel.
 m_aTablePositions.pop_back();
+m_aTableStyleNames.pop_back();
 }
 
 void DomainMapperTableManager::endOfCellAction()
@@ -521,7 +523,7 @@ void DomainMapperTableManager::endOfRowAction()
 TagLogger::getInstance().startElement("endOfRowAction");
 #endif
 
-// Compare the table position with the previous ones. We may need to split
+// Compare the table position and style with the previous ones. We may 
need to split
 // into two tables if those are different. We surely don't want to do 
anything
 // if we don't have any row yet.
 TablePositionHandlerPtr pTmpPosition = m_aTmpPosition.back();
@@ -529,7 +531,13 @@ void DomainMapperTableManager::endOfRowAction()
 TablePositionHandlerPtr pCurrentPosition = m_aTablePositions.back();
 bool bSamePosition = ( pTmpPosition == pCurrentPosition ) ||
  ( pTmpPosition && pCurrentPosition && *pTmpPosition 
== *pCurrentPosition );
-if ( !bSamePosition && m_nRow > 0 )
+bool bIsSetTableStyle = pTablePropMap->isSet(META_PROP_TABLE_STYLE_NAME);
+OUString sTableStyleName;
+bool bSameTableStyle = ( !bIsSetTableStyle && 
m_aTableStyleNames.back().isEmpty()) ||
+( bIsSetTableStyle &&
+  (pTablePropMap->getProperty(META_PROP_TABLE_STYLE_NAME)->second 
>>= sTableStyleName) &&
+

[Libreoffice-bugs] [Bug 123757] Bad interpretation of table background color for .docx documents

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=123757

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130935] New: Crash when selecting txt file after insert sheet from file

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=130935

Bug ID: 130935
   Summary: Crash when selecting txt file after insert sheet from
file
   Product: LibreOffice
   Version: 6.2.8.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: federicol...@tiscali.it

Description:
If I right click the sheet list, select insert new sheet, from file, select and
confirm a txt file (e.g. a list of words), I get a crash.



Actual Results:
Fatal exception: Signal 11
Stack:
/usr/lib64/libreoffice/program/libuno_sal.so.3(+0x3cdf3)[0x7fbc28864df3]
/usr/lib64/libreoffice/program/libuno_sal.so.3(+0x3cf6a)[0x7fbc28864f6a]
/lib64/libc.so.6(+0x37ec0)[0x7fbc2856fec0]
/usr/lib64/libreoffice/program/../program/libfps_officelo.so(+0x51d24)[0x7fbbfc2e9d24]
/usr/lib64/libreoffice/program/libsvtlo.so(+0x1ddabd)[0x7fbc25cf5abd]
/usr/lib64/libreoffice/program/libvcllo.so(_ZN9SvImpLBox15MouseButtonDownERK10MouseEvent+0x1e8)[0x7fbc250257c8]
/usr/lib64/libreoffice/program/libvcllo.so(+0x3d8ca6)[0x7fbc24f20ca6]
/usr/lib64/libreoffice/program/libvcllo.so(+0x3d922e)[0x7fbc24f2122e]
/usr/lib64/libreoffice/program/libvcllo.so(+0x3d9c6d)[0x7fbc24f21c6d]
/usr/lib64/libreoffice/program/libvclplug_gtk3lo.so(+0x10a4e9)[0x7fbc190924e9]
/usr/lib64/libreoffice/program/libvclplug_gtk3lo.so(+0x10bb2d)[0x7fbc19093b2d]
/lib64/libgtk-3.so.0(+0x3e65cb)[0x7fbc18c065cb]
/lib64/libgobject-2.0.so.0(g_closure_invoke+0x1b2)[0x7fbc21703742]
/lib64/libgobject-2.0.so.0(+0x274f4)[0x7fbc217174f4]
/lib64/libgobject-2.0.so.0(g_signal_emit_valist+0x571)[0x7fbc2171f9c1]
/lib64/libgobject-2.0.so.0(g_signal_emit+0x93)[0x7fbc21720973]
/lib64/libgtk-3.so.0(+0x391153)[0x7fbc18bb1153]
/lib64/libgtk-3.so.0(+0x24cd08)[0x7fbc18a6cd08]
/lib64/libgtk-3.so.0(gtk_main_do_event+0x85b)[0x7fbc18a6ef1b]
/lib64/libgdk-3.so.0(+0x3cf79)[0x7fbc18754f79]
/lib64/libgdk-3.so.0(+0x70086)[0x7fbc18788086]
/lib64/libglib-2.0.so.0(g_main_context_dispatch+0x15d)[0x7fbc21617ecd]
/lib64/libglib-2.0.so.0(+0x50260)[0x7fbc21618260]
/lib64/libglib-2.0.so.0(g_main_loop_run+0xc3)[0x7fbc21618593]
/usr/lib64/libreoffice/program/libvclplug_gtk3lo.so(+0xe1b2e)[0x7fbc19069b2e]
/usr/lib64/libreoffice/program/libscuilo.so(+0x146c12)[0x7fbbfe14ec12]
/usr/lib64/libreoffice/program/../program/libsclo.so(_ZN14ScTabViewShell12ExecuteTableER10SfxRequest+0x1752)[0x7fbbff36eb62]
/usr/lib64/libreoffice/program/libsfxlo.so(+0x2e1602)[0x7fbc27301602]
/usr/lib64/libreoffice/program/libsfxlo.so(_ZN13SfxDispatcher8Execute_ER8SfxShellRK7SfxSlotR10SfxRequest11SfxCallMode+0x11d)[0x7fbc27301bdd]
/usr/lib64/libreoffice/program/libsfxlo.so(+0x2de47e)[0x7fbc272fe47e]
/usr/lib64/libreoffice/program/libsfxlo.so(+0x32e86e)[0x7fbc2734e86e]
/usr/lib64/libreoffice/program/libsfxlo.so(+0x32ef43)[0x7fbc2734ef43]
/usr/lib64/libreoffice/program/../program/libfwklo.so(+0x1e0204)[0x7fbc170e8204]
/usr/lib64/libreoffice/program/libvcllo.so(_ZN4Menu6SelectEv+0x74)[0x7fbc24eacaf4]
/usr/lib64/libreoffice/program/libvcllo.so(+0x3677f0)[0x7fbc24eaf7f0]
/usr/lib64/libreoffice/program/libvcllo.so(_ZN9PopupMenu7ExecuteEPN3vcl6WindowERKN5tools9RectangleE14PopupMenuFlags+0x73)[0x7fbc24eafe93]
/usr/lib64/libreoffice/program/libvcllo.so(_ZN9PopupMenu7ExecuteEPN3vcl6WindowERK5Point+0x3f)[0x7fbc24eaff5f]
/usr/lib64/libreoffice/program/libsfxlo.so(_ZN13SfxDispatcher12ExecutePopupERKN3rtl8OUStringEPN3vcl6WindowEPK5Point+0xec6)[0x7fbc27308176]
/usr/lib64/libreoffice/program/../program/libsclo.so(+0xe6cd6b)[0x7fbbff33cd6b]
/usr/lib64/libreoffice/program/libvcllo.so(+0x3d6520)[0x7fbc24f1e520]
/usr/lib64/libreoffice/program/libvcllo.so(+0x3d8fd8)[0x7fbc24f20fd8]
/usr/lib64/libreoffice/program/libvcllo.so(+0x3d922e)[0x7fbc24f2122e]
/usr/lib64/libreoffice/program/libvcllo.so(+0x3d9c6d)[0x7fbc24f21c6d]
/usr/lib64/libreoffice/program/libvclplug_gtk3lo.so(+0x10a4e9)[0x7fbc190924e9]
/usr/lib64/libreoffice/program/libvclplug_gtk3lo.so(+0x10bb2d)[0x7fbc19093b2d]
/lib64/libgtk-3.so.0(+0x3e65cb)[0x7fbc18c065cb]
/lib64/libgobject-2.0.so.0(g_closure_invoke+0x1b2)[0x7fbc21703742]
/lib64/libgobject-2.0.so.0(+0x274f4)[0x7fbc217174f4]
/lib64/libgobject-2.0.so.0(g_signal_emit_valist+0x571)[0x7fbc2171f9c1]
/lib64/libgobject-2.0.so.0(g_signal_emit+0x93)[0x7fbc21720973]
/lib64/libgtk-3.so.0(+0x391153)[0x7fbc18bb1153]
/lib64/libgtk-3.so.0(+0x24cd08)[0x7fbc18a6cd08]
/lib64/libgtk-3.so.0(gtk_main_do_event+0x85b)[0x7fbc18a6ef1b]
/lib64/libgdk-3.so.0(+0x3cf79)[0x7fbc18754f79]
/lib64/libgdk-3.so.0(+0x70086)[0x7fbc18788086]
/lib64/libglib-2.0.so.0(g_main_context_dispatch+0x15d)[0x7fbc21617ecd]
/lib64/libglib-2.0.so.0(+0x50260)[0x7fbc21618260]
/lib64/libglib-2.0.so.0(g_main_context_iteration+0x33)[0x7fbc21618303]
/usr/lib64/libreoffice/program/libvclplug_gtk3lo.so(+0xa92bc)[0x7fbc190312bc]

[Libreoffice-commits] core.git: vcl/inc vcl/Library_vcl.mk vcl/source

2020-02-25 Thread Tomaž Vajngerl (via logerrit)

 vcl/Library_vcl.mk   |1 
 vcl/inc/graphic/GraphicID.hxx|   47 
 vcl/inc/impgraph.hxx |   21 ---
 vcl/source/gdi/impgraph.cxx  |   83 
 vcl/source/graphic/GraphicID.cxx |  112 +++
 5 files changed, 161 insertions(+), 103 deletions(-)

New commits:
commit b6bc43f354bcbe6a98db9fb372fd47bc5b23f4d8
Author: Tomaž Vajngerl 
AuthorDate: Mon Feb 24 23:02:20 2020 +0100
Commit: Tomaž Vajngerl 
CommitDate: Tue Feb 25 19:30:53 2020 +0100

vcl: move GraphicID out of impgraph.{cxx,hxx}

Change-Id: I0b3b17736a76be290f6e5b77ee547b7e650d4489
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89449
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index a38c84874ff9..79f2002c8c9d 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -318,6 +318,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
 vcl/source/gdi/TypeSerializer \
 vcl/source/pdf/ResourceDict \
 vcl/source/pdf/Matrix3 \
+vcl/source/graphic/GraphicID \
 vcl/source/graphic/GraphicLoader \
 vcl/source/graphic/GraphicObject \
 vcl/source/graphic/GraphicObject2 \
diff --git a/vcl/inc/graphic/GraphicID.hxx b/vcl/inc/graphic/GraphicID.hxx
new file mode 100644
index ..87ac6a50f37a
--- /dev/null
+++ b/vcl/inc/graphic/GraphicID.hxx
@@ -0,0 +1,47 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ *   Licensed to the Apache Software Foundation (ASF) under one or more
+ *   contributor license agreements. See the NOTICE file distributed
+ *   with this work for additional information regarding copyright
+ *   ownership. The ASF licenses this file to you under the Apache
+ *   License, Version 2.0 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#pragma once
+
+#include 
+#include 
+#include 
+
+class ImpGraphic;
+
+class GraphicID
+{
+private:
+sal_uInt32 mnID1;
+sal_uInt32 mnID2;
+sal_uInt32 mnID3;
+BitmapChecksum mnID4;
+
+public:
+GraphicID(ImpGraphic const& rGraphic);
+
+bool operator==(const GraphicID& rID) const
+{
+return rID.mnID1 == mnID1 && rID.mnID2 == mnID2 && rID.mnID3 == mnID3 
&& rID.mnID4 == mnID4;
+}
+
+OString getIDString() const;
+};
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/inc/impgraph.hxx b/vcl/inc/impgraph.hxx
index 90e658c67308..56c663d2d687 100644
--- a/vcl/inc/impgraph.hxx
+++ b/vcl/inc/impgraph.hxx
@@ -24,6 +24,7 @@
 #include 
 #include 
 #include "graphic/Manager.hxx"
+#include "graphic/GraphicID.hxx"
 
 struct ImpSwapInfo
 {
@@ -45,26 +46,6 @@ struct ImpSwapFile;
 class GraphicConversionParameters;
 class ImpGraphic;
 
-class GraphicID
-{
-private:
-sal_uInt32  mnID1;
-sal_uInt32  mnID2;
-sal_uInt32  mnID3;
-BitmapChecksum  mnID4;
-
-public:
-GraphicID(ImpGraphic const & rGraphic);
-
-bool operator==(const GraphicID& rID) const
-{
-return rID.mnID1 == mnID1 && rID.mnID2 == mnID2 &&
-   rID.mnID3 == mnID3 && rID.mnID4 == mnID4;
-}
-
-OString getIDString() const;
-};
-
 class ImpGraphic final
 {
 friend class Graphic;
diff --git a/vcl/source/gdi/impgraph.cxx b/vcl/source/gdi/impgraph.cxx
index 7e9c96feddf2..df736a274d87 100644
--- a/vcl/source/gdi/impgraph.cxx
+++ b/vcl/source/gdi/impgraph.cxx
@@ -69,89 +69,6 @@ struct ImpSwapFile
 ~ImpSwapFile();
 };
 
-GraphicID::GraphicID(ImpGraphic const & rGraphic)
-{
-rGraphic.ensureAvailable();
-
-mnID1 = static_cast(rGraphic.ImplGetType()) << 28;
-mnID2 = mnID3 = mnID4 = 0;
-
-if (rGraphic.ImplGetType() == GraphicType::Bitmap)
-{
-if (rGraphic.getVectorGraphicData().get())
-{
-const VectorGraphicDataPtr& rVectorGraphicDataPtr = 
rGraphic.getVectorGraphicData();
-const basegfx::B2DRange& rRange = 
rVectorGraphicDataPtr->getRange();
-
-mnID1 |= rVectorGraphicDataPtr->getVectorGraphicDataArrayLength();
-mnID2 = basegfx::fround(rRange.getWidth());
-mnID3 = basegfx::fround(rRange.getHeight());
-mnID4 = vcl_get_checksum(0, 
rVectorGraphicDataPtr->getVectorGraphicDataArray().getConstArray(), 
rVectorGraphicDataPtr->getVectorGraphicDataArrayLength());
-}
-else if (rGraphic.hasPdfData())
-{
-std::shared_ptr> pPdfData = 
rGraphic.getPdfData();
-const BitmapEx&

[Libreoffice-commits] core.git: sw/source

2020-02-25 Thread Jim Raykowski (via logerrit)

 sw/source/uibase/utlui/content.cxx |9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

New commits:
commit 6d23f2667edc9f8b867066a432dff152f8427ce0
Author: Jim Raykowski 
AuthorDate: Mon Feb 24 23:43:52 2020 -0900
Commit: Jim Raykowski 
CommitDate: Tue Feb 25 19:12:06 2020 +0100

tdf#128814 follow up: check for nullptr and dispose unused sub pop menu

Prevent nullptr crash in lcl_IsContent and dispose and clear sub pop
outline tracking menu if unused.

Change-Id: I6d3e1a48776426ae18156cc70b799f74f349bf5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89410
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index d0b1934aa1d8..f70f72815075 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -1287,15 +1287,15 @@ VclPtr SwContentTree::CreateContextMenu()
 else if (State::HIDDEN == m_eState)
 pSubPop3->CheckItem( nId );
 
-SvTreeListEntry* pEntry = nullptr;
-if (lcl_IsContent(FirstSelected()))
+SvTreeListEntry* pEntry = FirstSelected();
+if (pEntry && lcl_IsContent(pEntry))
 {
 pPop->InsertItem(900, SwResId(STR_GOTO));
 pPop->SetAccelKey(900, vcl::KeyCode(KEY_RETURN, false, false, false, 
false));
 }
 // Edit only if the shown content is coming from the current view.
 if ((State::ACTIVE == m_eState || m_pActiveShell == 
pActiveView->GetWrtShellPtr())
-&& nullptr != (pEntry = FirstSelected()) && lcl_IsContent(pEntry))
+&& pEntry && lcl_IsContent(pEntry))
 {
 
assert(dynamic_cast(static_cast(pEntry->GetUserData(;
 const SwContentType* pContType = 
static_cast(pEntry->GetUserData())->GetParent();
@@ -1425,7 +1425,10 @@ VclPtr SwContentTree::CreateContextMenu()
 pPop->SetPopupMenu(1, pSubPop1);
 }
 else
+{
+pSubPopOutlineTracking.disposeAndClear();
 pSubPop1.disposeAndClear();
+}
 pPop->InsertItem(2, m_aContextStrings[IDX_STR_DRAGMODE]);
 pPop->SetPopupMenu(2, pSubPop2);
 pPop->InsertItem(3, m_aContextStrings[IDX_STR_DISPLAY]);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 128814] Navigator: right-clicking on any item should bring context menu as right-clicking the item in document, not custom navigator menu

2020-02-25 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128814

--- Comment #26 from Commit Notification 
 ---
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6d23f2667edc9f8b867066a432dff152f8427ce0

tdf#128814 follow up: check for nullptr and dispose unused sub pop menu

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

1 2 3 4 >

1 - 100 of 333 matches

Mail list logo