date:20200812

[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore' - 838 commits - accessibility/inc accessibility/source avmedia/source basctl/inc basctl/sdi basctl/source basegfx/source basic/inc bas

2020-08-12 Thread Tomaž Vajngerl (via logerrit)

Rebased ref, commits from common ancestor:
commit 026dbac8d7ff24d3b6c396a48f1c05536392dffc
Author: Tomaž Vajngerl 
AuthorDate: Thu Aug 13 08:49:30 2020 +0200
Commit: Tomaž Vajngerl 
CommitDate: Thu Aug 13 08:55:53 2020 +0200

remove constructor with plain Bitmap from Graphic, use BitmapEx

Change-Id: Ie429a10a8f54c6779d437ee4bc75a5ea0c427848

diff --git a/basic/source/runtime/methods.cxx b/basic/source/runtime/methods.cxx
index 89ba081348c2..cc60076b58a6 100644
--- a/basic/source/runtime/methods.cxx
+++ b/basic/source/runtime/methods.cxx
@@ -4309,7 +4309,8 @@ void SbRtl_LoadPicture(StarBASIC *, SbxArray & rPar, bool)
 {
 Bitmap aBmp;
 ReadDIB(aBmp, *pStream, true);
-Graphic aGraphic(aBmp);
+BitmapEx aBitmapEx(aBmp);
+Graphic aGraphic(aBitmapEx);
 
 SbxObjectRef xRef = new SbStdPicture;
 static_cast(xRef.get())->SetGraphic( aGraphic );
diff --git a/emfio/source/reader/mtftools.cxx b/emfio/source/reader/mtftools.cxx
index 535c49184dae..a903bf99aa99 100644
--- a/emfio/source/reader/mtftools.cxx
+++ b/emfio/source/reader/mtftools.cxx
@@ -1310,7 +1310,7 @@ namespace emfio
   Color(),
   Color(),
   0,
-  Graphic (maLatestFillStyle.aBmp) 
);
+  Graphic 
(BitmapEx(maLatestFillStyle.aBmp)));
 
 SvMemoryStream  aMemStm;
 
diff --git a/filter/source/msfilter/msdffimp.cxx 
b/filter/source/msfilter/msdffimp.cxx
index 57f034e38870..ea37cbe45b47 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -6555,7 +6555,7 @@ bool SvxMSDffManager::GetBLIPDirect( SvStream& 
rBLIPStream, Graphic& rData, tool
 Bitmap aNew;
 if( ReadDIB(aNew, *pGrStream, false) )
 {
-rData = Graphic( aNew );
+rData = Graphic(BitmapEx(aNew));
 nRes = ERRCODE_NONE;
 }
 }
diff --git a/include/vcl/graph.hxx b/include/vcl/graph.hxx
index f6a47e43b8ec..1880041b4ba5 100644
--- a/include/vcl/graph.hxx
+++ b/include/vcl/graph.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_VCL_GRAPH_HXX
-#define INCLUDED_VCL_GRAPH_HXX
+#pragma once
 
 #include 
 #include 
@@ -93,7 +92,6 @@ public:
 Graphic( const GraphicExternalLink& rGraphicLink );
 Graphic( const Graphic& rGraphic );
 Graphic( Graphic&& rGraphic ) noexcept;
-Graphic( const Bitmap& rBmp );
 Graphic( const Image& rImage );
 Graphic( const BitmapEx& rBmpEx );
 Graphic( const std::shared_ptr& 
rVectorGraphicDataPtr );
@@ -213,6 +211,4 @@ struct hash
 
 } // end namespace std
 
-#endif // INCLUDED_VCL_GRAPH_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/filter/excel/xiescher.cxx 
b/sc/source/filter/excel/xiescher.cxx
index 70f30c693bb3..70252f6e6699 100644
--- a/sc/source/filter/excel/xiescher.cxx
+++ b/sc/source/filter/excel/xiescher.cxx
@@ -752,7 +752,7 @@ void XclImpDrawObjBase::ConvertFillStyle( SdrObject& 
rSdrObj, const XclObjFillDa
 aBitmap = aXOBitmap.GetBitmap().GetBitmap();
 
 rSdrObj.SetMergedItem(XFillStyleItem(drawing::FillStyle_BITMAP));
-rSdrObj.SetMergedItem(XFillBitmapItem(EMPTY_OUSTRING, 
Graphic(aBitmap)));
+rSdrObj.SetMergedItem(XFillBitmapItem(EMPTY_OUSTRING, 
Graphic(BitmapEx(aBitmap;
 }
 }
 }
@@ -4137,7 +4137,7 @@ void XclImpDrawing::ReadBmp( Graphic& rGraphic, const 
XclImpRoot& rRoot, XclImpS
 aMemStrm.Seek( STREAM_SEEK_TO_BEGIN );
 Bitmap aBitmap;
 if( ReadDIB(aBitmap, aMemStrm, false) )   // read DIB without file header
-rGraphic = aBitmap;
+rGraphic = BitmapEx(aBitmap);
 }
 
 void XclImpDrawing::ReadDffRecord( XclImpStream& rStrm )
diff --git a/sd/source/core/drawdoc4.cxx b/sd/source/core/drawdoc4.cxx
index 59687f189450..2f028a15644e 100644
--- a/sd/source/core/drawdoc4.cxx
+++ b/sd/source/core/drawdoc4.cxx
@@ -167,7 +167,7 @@ void SdDrawDocument::CreateLayoutTemplates()
 SizeaNullSize( 32, 32 );
 Bitmap  aNullBmp( aNullSize, 8 );
 aNullBmp.Erase( COL_WHITE );
-rISet.Put(XFillBitmapItem(Graphic(aNullBmp)));
+rISet.Put(XFillBitmapItem(Graphic(BitmapEx(aNullBmp;
 
 // Shadow attributes (Drawing Engine)
 rISet.Put(makeSdrShadowItem(false));
diff --git a/sd/source/ui/dlg/vectdlg.cxx b/sd/source/ui/dlg/vectdlg.cxx
index 843d593f5e28..dce0e837ac38 100644
--- a/sd/source/ui/dlg/vectdlg.cxx
+++ b/sd/source/ui/dlg/vectdlg.cxx
@@ -103,7 +103,7 @@ void SdVectorizeDlg::InitPreviewBmp()
 
 aPreviewBmp = aBmp;
 aPreviewBmp.Scale( aRect.GetSize() );
-

[Libreoffice-commits] core.git: chart2/source editeng/source extensions/source forms/source include/editeng include/svl include/svx linguistic/source sc/source sd/source sfx2/source svl/source svx/sou

2020-08-12 Thread Noel Grandin (via logerrit)

 chart2/source/tools/ErrorBar.cxx|   32 
 editeng/source/accessibility/AccessibleEditableTextPara.cxx |6 
 editeng/source/uno/unofield.cxx |   62 
 editeng/source/uno/unotext.cxx  |   16 
 editeng/source/xml/xmltxtexp.cxx|8 
 editeng/source/xml/xmltxtimp.cxx|8 
 extensions/source/bibliography/bibload.cxx  |4 
 forms/source/richtext/richtextunowrapper.cxx|6 
 include/editeng/unotext.hxx |  144 -
 include/svl/itemprop.hxx|4 
 include/svx/unoshprp.hxx|  532 ++--
 linguistic/source/lngopt.cxx|   42 
 sc/source/core/data/dptabsrc.cxx|   78 
 sc/source/ui/unoobj/PivotTableDataProvider.cxx  |6 
 sc/source/ui/unoobj/PivotTableDataSequence.cxx  |8 
 sc/source/ui/unoobj/addruno.cxx |   28 
 sc/source/ui/unoobj/afmtuno.cxx |  110 
 sc/source/ui/unoobj/appluno.cxx |   38 
 sc/source/ui/unoobj/cellsuno.cxx| 1256 +--
 sc/source/ui/unoobj/chart2uno.cxx   |   14 
 sc/source/ui/unoobj/condformatuno.cxx   |   58 
 sc/source/ui/unoobj/confuno.cxx |   76 
 sc/source/ui/unoobj/dapiuno.cxx |   70 
 sc/source/ui/unoobj/datauno.cxx |   76 
 sc/source/ui/unoobj/defltuno.cxx|   42 
 sc/source/ui/unoobj/docuno.cxx  |  120 -
 sc/source/ui/unoobj/fielduno.cxx|   44 
 sc/source/ui/unoobj/fmtuno.cxx  |   22 
 sc/source/ui/unoobj/linkuno.cxx |   12 
 sc/source/ui/unoobj/nameuno.cxx |   14 
 sc/source/ui/unoobj/notesuno.cxx|2 
 sc/source/ui/unoobj/optuno.cxx  |   28 
 sc/source/ui/unoobj/shapeuno.cxx|   18 
 sc/source/ui/unoobj/srchuno.cxx |   28 
 sc/source/ui/unoobj/styleuno.cxx|  518 ++--
 sc/source/ui/unoobj/targuno.cxx |6 
 sc/source/ui/unoobj/textuno.cxx |4 
 sc/source/ui/unoobj/tokenuno.cxx|   12 
 sc/source/ui/unoobj/viewuno.cxx |   58 
 sd/source/core/stlsheet.cxx |   18 
 sd/source/core/text/textapi.cxx |   10 
 sd/source/ui/slideshow/slideshow.cxx|   32 
 sd/source/ui/unoidl/unolayer.cxx|   14 
 sd/source/ui/unoidl/unomodel.cxx|   30 
 sd/source/ui/unoidl/unoobj.cxx  |   66 
 sd/source/ui/unoidl/unopage.cxx |  244 +-
 sd/source/ui/unoidl/unopback.cxx|2 
 sd/source/ui/unoidl/unosrch.cxx |8 
 sfx2/source/doc/iframe.cxx  |   18 
 svl/source/items/itemprop.cxx   |2 
 svl/source/numbers/numfmuno.cxx |   38 
 svx/source/table/cell.cxx   |   34 
 svx/source/unodraw/unoprov.cxx  |  502 ++--
 sw/source/core/access/accpara.cxx   |2 
 sw/source/core/fields/textapi.cxx   |   10 
 sw/source/core/unocore/unomap.cxx   | 1350 ++--
 sw/source/core/unocore/unomap1.cxx  | 1144 +-
 sw/source/core/unocore/unomapproperties.hxx |  860 +++
 sw/source/core/unocore/unoobj.cxx   |6 
 sw/source/core/unocore/unosett.cxx  |   82 
 60 files changed, 4041 insertions(+), 4041 deletions(-)

New commits:
commit 3101fa6862e4f849cbbea3fd817914a89eab403b
Author: Noel Grandin 
AuthorDate: Sun Aug 9 19:07:12 2020 +0200
Commit: Noel Grandin 
CommitDate: Thu Aug 13 08:18:40 2020 +0200

use OUStringLiteral in SfxItemPropertyMapEntry

Change-Id: I4f05b6a35010e661ea77f3e4b83302d2ec74d227
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100405
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/source/tools/ErrorBar.cxx b/chart2/source/tools/ErrorBar.cxx
index 77dd69705211..32fa6c39ec52 100644
--- a/chart2/source/tools/ErrorBar.cxx
+++ b/chart2/source/tools/ErrorBar.cxx
@@ -53,22 +53,22 @@ const SfxItemPropertySet* GetErrorBarPropertySet()
 {
 static const SfxItemPropertyMapEntry

[Libreoffice-commits] core.git: sfx2/source

2020-08-12 Thread Noel Grandin (via logerrit)

 sfx2/source/doc/objstor.cxx  |8 +---
 sfx2/source/doc/objxtor.cxx  |3 ++-
 sfx2/source/explorer/nochaos.cxx |6 --
 sfx2/source/view/frame.cxx   |5 -
 sfx2/source/view/ipclient.cxx|3 ++-
 5 files changed, 17 insertions(+), 8 deletions(-)

New commits:
commit 8143a2023fc28e3694dd884ddd64d297eb1ce71c
Author: Noel Grandin 
AuthorDate: Wed Aug 12 12:05:58 2020 +0200
Commit: Noel Grandin 
CommitDate: Thu Aug 13 08:18:20 2020 +0200

expand out DELETEZ in sfx2

Change-Id: Iced9299be454f5260582b0b639aad8e5d362d730
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100620
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index b22029107d59..3f3ac5d25279 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -2932,7 +2932,8 @@ bool SfxObjectShell::PreDoSaveAs_Impl(const OUString& 
rFileName, const OUString&
 // TODO/LATER: disconnect the new file from the storage for the 
case when pure saving is done
 //   if storing has corrupted the file, probably it must be 
restored either here or
 //   by the storage
-DELETEZ( pNewFile );
+delete pNewFile;
+pNewFile = nullptr;
 }
 }
 else
@@ -2942,11 +2943,12 @@ bool SfxObjectShell::PreDoSaveAs_Impl(const OUString& 
rFileName, const OUString&
 // reconnect to the old storage
 DoSaveCompleted();
 
-DELETEZ( pNewFile );
+delete pNewFile;
+pNewFile = nullptr;
 }
 
 if ( bCopyTo )
-DELETEZ( pNewFile );
+delete pNewFile;
 else if( !bOk )
 SetModified();
 
diff --git a/sfx2/source/doc/objxtor.cxx b/sfx2/source/doc/objxtor.cxx
index fb5a1677d6d2..7dd8276eb20c 100644
--- a/sfx2/source/doc/objxtor.cxx
+++ b/sfx2/source/doc/objxtor.cxx
@@ -324,7 +324,8 @@ SfxObjectShell::~SfxObjectShell()
 if (IsDocShared())
 FreeSharedFile( pMedium->GetURLObject().GetMainURL( 
INetURLObject::DecodeMechanism::NONE ) );
 #endif
-DELETEZ( pMedium );
+delete pMedium;
+pMedium = nullptr;
 }
 
 // The removing of the temporary file must be done as the latest step in 
the document destruction
diff --git a/sfx2/source/explorer/nochaos.cxx b/sfx2/source/explorer/nochaos.cxx
index 10e4c30bd0b4..33f219e3247e 100644
--- a/sfx2/source/explorer/nochaos.cxx
+++ b/sfx2/source/explorer/nochaos.cxx
@@ -145,8 +145,10 @@ sal_uInt16 CntItemPool::Release()
 
 if ( !nRefs )
 {
-DELETEZ( _pThePool );
-DELETEZ( pPoolDefs_Impl );
+delete _pThePool;
+_pThePool = nullptr;
+delete pPoolDefs_Impl;
+pPoolDefs_Impl = nullptr;
 return 0;
 }
 
diff --git a/sfx2/source/view/frame.cxx b/sfx2/source/view/frame.cxx
index d96120fc6791..c7aa11f97b08 100644
--- a/sfx2/source/view/frame.cxx
+++ b/sfx2/source/view/frame.cxx
@@ -143,7 +143,10 @@ void SfxFrame::DoClose_Impl()
 pImpl->pCurrentViewFrame->Close();
 
 if ( pImpl->bOwnsBindings )
-DELETEZ( pBindings );
+{
+delete pBindings;
+pBindings = nullptr;
+}
 
 delete this;
 }
diff --git a/sfx2/source/view/ipclient.cxx b/sfx2/source/view/ipclient.cxx
index 5dc6267e5c94..ad718537b76c 100644
--- a/sfx2/source/view/ipclient.cxx
+++ b/sfx2/source/view/ipclient.cxx
@@ -203,7 +203,8 @@ void SAL_CALL SfxInPlaceClient_Impl::notifyEvent( const 
document::EventObject& a
 
 void SAL_CALL SfxInPlaceClient_Impl::disposing( const css::lang::EventObject& 
/*aEvent*/ )
 {
-DELETEZ( m_pClient );
+delete m_pClient;
+m_pClient = nullptr;
 }
 
 // XEmbeddedClient
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sfx2/source

2020-08-12 Thread Noel Grandin (via logerrit)

 sfx2/source/doc/objembed.cxx |8 
 sfx2/source/doc/objmisc.cxx  |2 +-
 sfx2/source/doc/objstor.cxx  |   24 
 sfx2/source/doc/objxtor.cxx  |9 -
 sfx2/source/inc/objshimp.hxx |2 +-
 5 files changed, 22 insertions(+), 23 deletions(-)

New commits:
commit 8ce3647224c9aae6425dcb199d2b83de2359665c
Author: Noel Grandin 
AuthorDate: Wed Aug 12 12:46:35 2020 +0200
Commit: Noel Grandin 
CommitDate: Thu Aug 13 08:17:22 2020 +0200

use unique_ptr in SfxObjectShell_Impl

Change-Id: I90fda5d15168027bb92d9c6265b0065e3fa0472d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100621
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sfx2/source/doc/objembed.cxx b/sfx2/source/doc/objembed.cxx
index 0436530b7d3b..f6b4f5345055 100644
--- a/sfx2/source/doc/objembed.cxx
+++ b/sfx2/source/doc/objembed.cxx
@@ -231,15 +231,15 @@ void SfxObjectShell::DoDraw_Impl( OutputDevice* pDev,
 
 comphelper::EmbeddedObjectContainer& 
SfxObjectShell::GetEmbeddedObjectContainer() const
 {
-if ( !pImpl->mpObjectContainer )
-pImpl->mpObjectContainer = new comphelper::EmbeddedObjectContainer( 
const_cast(this)->GetStorage(), GetModel() );
-return *pImpl->mpObjectContainer;
+if ( !pImpl->mxObjectContainer )
+pImpl->mxObjectContainer.reset(new 
comphelper::EmbeddedObjectContainer( 
const_cast(this)->GetStorage(), GetModel() ));
+return *pImpl->mxObjectContainer;
 }
 
 void SfxObjectShell::ClearEmbeddedObjects()
 {
 // frees all space taken by embedded objects
-DELETEZ( pImpl->mpObjectContainer );
+pImpl->mxObjectContainer.reset();
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sfx2/source/doc/objmisc.cxx b/sfx2/source/doc/objmisc.cxx
index 1961a7282ef5..1a5cde068054 100644
--- a/sfx2/source/doc/objmisc.cxx
+++ b/sfx2/source/doc/objmisc.cxx
@@ -263,7 +263,7 @@ bool SfxObjectShell::IsModified() const
 return false;
 }
 
-if (pImpl->mpObjectContainer)
+if (pImpl->mxObjectContainer)
 {
 const uno::Sequence < OUString > aNames = 
GetEmbeddedObjectContainer().GetObjectNames();
 for ( const auto& rName : aNames )
diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index 76c929e1ee76..b22029107d59 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -3160,7 +3160,7 @@ uno::Reference< embed::XStorage > const & 
SfxObjectShell::GetStorage()
 
 void SfxObjectShell::SaveChildren( bool bObjectsOnly )
 {
-if ( pImpl->mpObjectContainer )
+if ( pImpl->mxObjectContainer )
 {
 bool bOasis = ( SotStorage::GetVersion( GetStorage() ) > 
SOFFICE_FILEFORMAT_60 );
 GetEmbeddedObjectContainer().StoreChildren(bOasis,bObjectsOnly);
@@ -3179,7 +3179,7 @@ bool SfxObjectShell::SaveAsChildren( SfxMedium& rMedium )
 return true;
 }
 
-if ( pImpl->mpObjectContainer )
+if ( pImpl->mxObjectContainer )
 {
 bool bOasis = ( SotStorage::GetVersion( xStorage ) > 
SOFFICE_FILEFORMAT_60 );
 
GetEmbeddedObjectContainer().StoreAsChildren(bOasis,SfxObjectCreateMode::EMBEDDED
 == eCreateMode,xStorage);
@@ -3201,7 +3201,7 @@ bool SfxObjectShell::SaveCompletedChildren()
 {
 bool bResult = true;
 
-if ( pImpl->mpObjectContainer )
+if ( pImpl->mxObjectContainer )
 {
 const uno::Sequence < OUString > aNames = 
GetEmbeddedObjectContainer().GetObjectNames();
 for ( const auto& rName : aNames )
@@ -3240,8 +3240,8 @@ bool SfxObjectShell::SwitchChildrenPersistance( const 
uno::Reference< embed::XSt
 return false;
 }
 
-if ( pImpl->mpObjectContainer )
-
pImpl->mpObjectContainer->SetPersistentEntries(xStorage,bForceNonModified);
+if ( pImpl->mxObjectContainer )
+
pImpl->mxObjectContainer->SetPersistentEntries(xStorage,bForceNonModified);
 
 return true;
 }
@@ -3254,7 +3254,7 @@ bool SfxObjectShell::SaveCompleted( const uno::Reference< 
embed::XStorage >& xSt
 uno::Reference< embed::XStorage > xOldStorageHolder;
 
 // check for wrong creation of object container
-bool bHasContainer = ( pImpl->mpObjectContainer != nullptr );
+bool bHasContainer( pImpl->mxObjectContainer );
 
 if ( !xStorage.is() || xStorage == GetStorage() )
 {
@@ -3263,7 +3263,7 @@ bool SfxObjectShell::SaveCompleted( const uno::Reference< 
embed::XStorage >& xSt
 }
 else
 {
-if ( pImpl->mpObjectContainer )
+if ( pImpl->mxObjectContainer )
 GetEmbeddedObjectContainer().SwitchPersistence( xStorage );
 
 bResult = SwitchChildrenPersistance( xStorage, true );
@@ -3275,7 +3275,7 @@ bool SfxObjectShell::SaveCompleted( const uno::Reference< 
embed::XStorage >& xSt
 {
 // make sure that until the storage is assigned the object
 // container is not created by accident!
-DBG_ASSERT( bHasContainer == (pImpl->mpObjectContainer != 
nullptr), "Wrong storag

[Libreoffice-commits] core.git: include/sfx2 sfx2/source

2020-08-12 Thread Noel Grandin (via logerrit)

 include/sfx2/bindings.hxx|2 +-
 sfx2/source/appl/workwin.cxx |2 +-
 sfx2/source/control/bindings.cxx |   15 +++
 3 files changed, 9 insertions(+), 10 deletions(-)

New commits:
commit 8436c023383e46d50c3d31736ea02896f7282781
Author: Noel Grandin 
AuthorDate: Wed Aug 12 14:20:50 2020 +0200
Commit: Noel Grandin 
CommitDate: Thu Aug 13 08:16:50 2020 +0200

use unique_ptr in SfxBindings_Impl

Change-Id: I8377fc5e8d79456aaa5d827f62e3d9c74ca8e52a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100623
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/sfx2/bindings.hxx b/include/sfx2/bindings.hxx
index 28b4d5248517..3eb756ebb18d 100644
--- a/include/sfx2/bindings.hxx
+++ b/include/sfx2/bindings.hxx
@@ -170,7 +170,7 @@ public:
 SAL_DLLPRIVATE void RegisterInternal_Impl( SfxControllerItem& rBinding );
 SAL_DLLPRIVATE void Register_Impl( SfxControllerItem& rBinding, bool );
 SAL_DLLPRIVATE SfxWorkWindow* GetWorkWindow_Impl() const;
-SAL_DLLPRIVATE void SetWorkWindow_Impl( SfxWorkWindow* );
+SAL_DLLPRIVATE void SetWorkWindow_Impl( std::unique_ptr );
 SAL_DLLPRIVATE SfxBindings* GetSubBindings_Impl() const;
 SAL_DLLPRIVATE void SetRecorder_Impl( css::uno::Reference< 
css::frame::XDispatchRecorder > const & );
 SAL_DLLPRIVATE void InvalidateSlotsInMap_Impl();
diff --git a/sfx2/source/appl/workwin.cxx b/sfx2/source/appl/workwin.cxx
index ce08cdf3875e..e82c0a49d98a 100644
--- a/sfx2/source/appl/workwin.cxx
+++ b/sfx2/source/appl/workwin.cxx
@@ -476,7 +476,7 @@ SfxWorkWindow::SfxWorkWindow( vcl::Window *pWin, SfxFrame 
*pFrm, SfxFrame* pMast
 {
 DBG_ASSERT (pBindings, "No Bindings!");
 
-pBindings->SetWorkWindow_Impl( this );
+pBindings->SetWorkWindow_Impl( std::unique_ptr(this) );
 
 // For the ObjectBars an integral place in the Childlist is reserved,
 // so that they always come in a defined order.
diff --git a/sfx2/source/control/bindings.cxx b/sfx2/source/control/bindings.cxx
index ce4d3a4230d4..d648fdf87537 100644
--- a/sfx2/source/control/bindings.cxx
+++ b/sfx2/source/control/bindings.cxx
@@ -103,7 +103,7 @@ class SfxBindings_Impl
 public:
 css::uno::Reference< css::frame::XDispatchRecorder > xRecorder;
 css::uno::Reference< css::frame::XDispatchProvider >  xProv;
-SfxWorkWindow*  pWorkWin;
+std::unique_ptr mxWorkWin;
 SfxBindings*pSubBindings;
 std::vector> pCaches; // One cache for each 
binding
 std::size_t nCachedFunc1;   // index for the last one called
@@ -141,7 +141,6 @@ SfxBindings::SfxBindings()
 pImpl->bInNextJob = false;
 pImpl->bInUpdate = false;
 pImpl->pSubBindings = nullptr;
-pImpl->pWorkWin = nullptr;
 pImpl->nOwnRegLevel = nRegLevel;
 
 // all caches are valid (no pending invalidate-job)
@@ -177,7 +176,7 @@ SfxBindings::~SfxBindings()
 // Delete Caches
 pImpl->pCaches.clear();
 
-DELETEZ( pImpl->pWorkWin );
+pImpl->mxWorkWin.reset();
 }
 
 
@@ -232,8 +231,8 @@ void SfxBindings::HidePopups( bool bHide )
 {
 // Hide SfxChildWindows
 DBG_ASSERT( pDispatcher, "HidePopups not allowed without dispatcher" );
-if ( pImpl->pWorkWin )
-pImpl->pWorkWin->HidePopups_Impl( bHide );
+if ( pImpl->mxWorkWin )
+pImpl->mxWorkWin->HidePopups_Impl( bHide );
 }
 
 void SfxBindings::Update_Impl(SfxStateCache& rCache /*The up to date 
SfxStatusCache*/)
@@ -1666,14 +1665,14 @@ SfxBindings* SfxBindings::GetSubBindings_Impl() const
 return pImpl->pSubBindings;
 }
 
-void SfxBindings::SetWorkWindow_Impl( SfxWorkWindow* pWork )
+void SfxBindings::SetWorkWindow_Impl( std::unique_ptr xWork )
 {
-pImpl->pWorkWin = pWork;
+pImpl->mxWorkWin = std::move(xWork);
 }
 
 SfxWorkWindow* SfxBindings::GetWorkWindow_Impl() const
 {
-return pImpl->pWorkWin;
+return pImpl->mxWorkWin.get();
 }
 
 bool SfxBindings::IsInUpdate() const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/inc sw/source

2020-08-12 Thread Noel Grandin (via logerrit)

 sw/inc/view.hxx  |4 +--
 sw/source/uibase/uiview/view.cxx |4 +--
 sw/source/uibase/uiview/viewsrch.cxx |   44 +--
 3 files changed, 26 insertions(+), 26 deletions(-)

New commits:
commit bbd598e62fe66352fc366c3e78c0aad753ea2ad7
Author: Noel Grandin 
AuthorDate: Wed Aug 12 11:11:21 2020 +0200
Commit: Noel Grandin 
CommitDate: Thu Aug 13 08:16:22 2020 +0200

use unique_ptr in SwView

Change-Id: I0aee92369627b18f8c6eabb756e0f409863e2a58
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100617
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/inc/view.hxx b/sw/inc/view.hxx
index 2a7bc89ab7e3..85ab3f1c930f 100644
--- a/sw/inc/view.hxx
+++ b/sw/inc/view.hxx
@@ -158,8 +158,8 @@ class SW_DLLPUBLIC SwView: public SfxViewShell
 static bool s_bFound;
 static bool s_bJustOpened;
 
-static SearchAttrItemList* s_pSearchList;
-static SearchAttrItemList* s_pReplaceList;
+static std::unique_ptr s_xSearchList;
+static std::unique_ptr s_xReplaceList;
 
 Timer   m_aTimer; // for delayed ChgLnks during an 
action
 OUStringm_sSwViewData,
diff --git a/sw/source/uibase/uiview/view.cxx b/sw/source/uibase/uiview/view.cxx
index 94b400346895..5ee6f15b65a9 100644
--- a/sw/source/uibase/uiview/view.cxx
+++ b/sw/source/uibase/uiview/view.cxx
@@ -118,8 +118,8 @@ boolSwView::s_bExtra  = false;
 boolSwView::s_bFound  = false;
 boolSwView::s_bJustOpened = false;
 
-SearchAttrItemList* SwView::s_pSearchList   = nullptr;
-SearchAttrItemList* SwView::s_pReplaceList   = nullptr;
+std::unique_ptr  SwView::s_xSearchList;
+std::unique_ptr  SwView::s_xReplaceList;
 
 SfxDispatcher &SwView::GetDispatcher()
 {
diff --git a/sw/source/uibase/uiview/viewsrch.cxx 
b/sw/source/uibase/uiview/viewsrch.cxx
index c037f5394a5d..bc4ac9b353ff 100644
--- a/sw/source/uibase/uiview/viewsrch.cxx
+++ b/sw/source/uibase/uiview/viewsrch.cxx
@@ -164,8 +164,8 @@ void SwView::ExecSearch(SfxRequest& rReq)
 delete s_pSrchItem;
 s_pSrchItem = pArgs->Get(SID_SEARCH_ITEM).Clone();
 
-DELETEZ( s_pSearchList );
-DELETEZ( s_pReplaceList );
+s_xSearchList.reset();
+s_xReplaceList.reset();
 
 SvxSearchDialog *const pSrchDlg(GetSearchDialog());
 if (pSrchDlg)
@@ -173,11 +173,11 @@ void SwView::ExecSearch(SfxRequest& rReq)
 // We will remember the search-/replace items.
 const SearchAttrItemList* pList = 
pSrchDlg->GetSearchItemList();
 if( nullptr != pList && pList->Count() )
-s_pSearchList = new SearchAttrItemList( *pList );
+s_xSearchList.reset(new SearchAttrItemList( *pList ));
 
 pList = pSrchDlg->GetReplaceItemList();
 if (nullptr != pList && pList->Count())
-s_pReplaceList = new SearchAttrItemList( *pList );
+s_xReplaceList.reset(new SearchAttrItemList( *pList ));
 }
 }
 break;
@@ -194,16 +194,16 @@ void SwView::ExecSearch(SfxRequest& rReq)
 SvxSearchDialog * pSrchDlg(GetSearchDialog());
 if (pSrchDlg)
 {
-DELETEZ( s_pSearchList );
-DELETEZ( s_pReplaceList );
+s_xSearchList.reset();
+s_xReplaceList.reset();
 
 const SearchAttrItemList* pList = 
pSrchDlg->GetSearchItemList();
 if( nullptr != pList && pList->Count() )
-s_pSearchList = new SearchAttrItemList( *pList );
+s_xSearchList.reset(new SearchAttrItemList( *pList ));
 
 pList = pSrchDlg->GetReplaceItemList();
 if (nullptr != pList && pList->Count())
-s_pReplaceList = new SearchAttrItemList( *pList );
+s_xReplaceList.reset(new SearchAttrItemList( *pList ));
 }
 
 if (nSlot == FN_REPEAT_SEARCH)
@@ -269,7 +269,7 @@ void SwView::ExecSearch(SfxRequest& rReq)
 
 SvxSearchCmd nCmd = SvxSearchCmd::FIND;
 if( !s_pSrchItem->GetReplaceString().isEmpty() ||
-!s_pReplaceList )
+!s_xReplaceList )
 {
 // Prevent, that the replaced string will be found 
again
 // if the replacement string is containing the search 
string.
@@ -293,7 +293,7 @@ void SwView::ExecSearch(SfxRequest& rReq)
 m_pWrtShell->SwapPam();
 }
 }
-else if( s_pReplaceList )
+else if( s_xReplaceList )
 nCmd = SvxSearchCmd::REPLACE;
 
 // 2) Search further (without replacing!)
@@

[Libreoffice-commits] core.git: avmedia/source basctl/source basic/source chart2/source comphelper/source compilerplugins/clang cui/source dbaccess/source desktop/qa desktop/source extensions/source f

2020-08-12 Thread Noel Grandin (via logerrit)

 avmedia/source/vlc/vlcframegrabber.cxx|4 
 avmedia/source/vlc/vlcplayer.cxx  |4 
 avmedia/source/vlc/vlcwindow.cxx  |4 
 basctl/source/basicide/basidectrlr.cxx|2 
 basctl/source/basicide/localizationmgr.cxx|6 
 basic/source/sbx/sbxvar.cxx   |2 
 chart2/source/controller/dialogs/DialogModel.cxx  |4 
 chart2/source/controller/dialogs/tp_DataSource.cxx|4 
 chart2/source/model/main/ChartModel.cxx   |4 
 chart2/source/view/main/ChartView.cxx |4 
 comphelper/source/officeinstdir/officeinstallationdirectories.cxx |4 
 comphelper/source/xml/ofopxmlhelper.cxx   |   36 ++--
 compilerplugins/clang/stringstatic.cxx|   60 
+---
 compilerplugins/clang/test/stringstatic.cxx   |   24 +++
 cui/source/options/treeopt.cxx|2 
 dbaccess/source/ui/dlg/dbfindex.cxx   |2 
 desktop/qa/desktop_lib/test_desktop_lib.cxx   |6 
 desktop/source/lib/init.cxx   |   22 +-
 extensions/source/bibliography/bibmod.cxx |   21 +-
 extensions/source/bibliography/bibprop.hxx|   20 +-
 extensions/source/bibliography/datman.cxx |6 
 extensions/source/logging/csvformatter.cxx|2 
 filter/source/msfilter/msocximex.cxx  |2 
 filter/source/msfilter/msvbahelper.cxx|4 
 framework/inc/jobs/jobconst.hxx   |6 
 framework/source/fwi/jobs/jobconst.cxx|6 
 idlc/source/astdeclaration.cxx|2 
 include/rtl/string.hxx|   75 
+++---
 include/xmloff/xmlimp.hxx |4 
 oox/source/core/xmlfilterbase.cxx |4 
 oox/source/crypto/Standard2007Engine.cxx  |2 
 oox/source/vml/vmlinputstream.cxx |4 
 oox/source/vml/vmlshapecontext.cxx|2 
 package/source/zippackage/ZipPackage.cxx  |   10 -
 sal/qa/osl/pipe/osl_Pipe.cxx  |9 -
 sal/qa/rtl/digest/rtl_digest.cxx  |   20 +-
 sax/qa/cppunit/xmlimport.cxx  |   29 ++-
 sax/source/fastparser/legacyfastparser.cxx|8 -
 sc/source/core/tool/compiler.cxx  |6 
 sc/source/filter/excel/xiescher.cxx   |4 
 sc/source/ui/StatisticsDialogs/FourierAnalysisDialog.cxx  |2 
 sc/source/ui/dbgui/scuiasciiopt.cxx   |6 
 sc/source/ui/unoobj/PivotTableDataProvider.cxx|6 
 sc/source/ui/vba/excelvbahelper.cxx   |2 
 sc/source/ui/vba/vbaaxis.cxx  |8 -
 sc/source/ui/vba/vbachart.cxx |   32 ++--
 sc/source/ui/vba/vbachartobject.cxx   |2 
 sc/source/ui/view/formatsh.cxx|2 
 sd/inc/strmname.h |8 -
 sd/source/ui/dlg/sdabstdlg.cxx|2 
 sd/source/ui/framework/tools/FrameworkHelper.cxx  |   26 +--
 sd/source/ui/inc/ToolBarManager.hxx   |   30 ++--
 sd/source/ui/inc/framework/FrameworkHelper.hxx|   26 +--
 sd/source/ui/remotecontrol/ImagePreparer.cxx  |4 
 sd/source/ui/view/ToolBarManager.cxx  |   30 ++--
 sdext/source/presenter/PresenterConfigurationAccess.cxx   |2 
 sdext/source/presenter/PresenterConfigurationAccess.hxx   |2 
 sdext/source/presenter/PresenterHelper.cxx|   12 -
 sdext/source/presenter/PresenterHelper.hxx|   12 -
 sdext/source/presenter/PresenterNotesView.cxx |4 
 sdext/source/presenter/PresenterPaneFactory.cxx   |   14 -
 sdext/source/presenter/PresenterPaneFactory.hxx   |   14 -
 sdext/source/presenter/PresenterViewFactory.cxx   |   12 -
 sdext/source/presenter/PresenterViewFactory.hxx   |   12 -
 sfx2/source/appl/sfxhelp.cxx  |2 
 sfx2/source/dialog/filedlghelper.cxx

GSoC "Extending the UITest framework" Week (10) Report

2020-08-12 Thread ahmed El-Shreif

Hello all,

here is my Week (10) report:
https://ahmedelshreifgsoc20.blogspot.com/2020/08/week-10-report.html

waiting for all your feedback.

Thanks,
Ahmed ElShreif
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'private/quwex/gsoc-box2d-experimental' - 2 commits - slideshow/source

2020-08-12 Thread Sarper Akdemir (via logerrit)

Rebased ref, commits from common ancestor:
commit ca8bc047298e59e598c631d4c93d374793054067
Author: Sarper Akdemir 
AuthorDate: Thu Aug 13 03:40:25 2020 +0300
Commit: Sarper Akdemir 
CommitDate: Thu Aug 13 06:40:50 2020 +0300

make physics animations handle sequential animations correctly

Change-Id: Ie8bb8b32588f4c7bf16317b5229adc5b0334d192

diff --git a/slideshow/source/engine/animationfactory.cxx 
b/slideshow/source/engine/animationfactory.cxx
index bc1848f68435..d6198439b327 100644
--- a/slideshow/source/engine/animationfactory.cxx
+++ b/slideshow/source/engine/animationfactory.cxx
@@ -323,7 +323,9 @@ namespace slideshow::internal
 {
 mpShapeManager->notifyShapeUpdate( mpShape );
 if ( mpBox2DWorld->isInitialized() )
-mpBox2DWorld->queuePositionUpdate( 
mpShape->getXShape(), rOutPos );
+{
+mpBox2DWorld->queueShapePathAnimationUpdate( 
mpShape->getXShape(), mpAttrLayer );
+}
 }
 
 return true;
diff --git a/slideshow/source/engine/box2dtools.cxx 
b/slideshow/source/engine/box2dtools.cxx
index 68ab37fb6868..0dbc7be63f2a 100644
--- a/slideshow/source/engine/box2dtools.cxx
+++ b/slideshow/source/engine/box2dtools.cxx
@@ -203,7 +203,8 @@ box2DWorld::box2DWorld(const ::basegfx::B2DVector& 
rSlideSize)
 , mbShapesInitialized(false)
 , mbHasWorldStepper(false)
 , mpXShapeToBodyMap()
-, maShapeUpdateQueue()
+, maShapeParallelUpdateQueue()
+, maShapeSequentialUpdate()
 {
 }
 
@@ -253,6 +254,13 @@ void box2DWorld::createStaticFrameAroundSlide(const 
::basegfx::B2DVector& rSlide
 pStaticBody->CreateFixture(&aFixtureDef);
 }
 
+void box2DWorld::setShapePosition(const 
css::uno::Reference xShape,
+  const basegfx::B2DPoint& rOutPos)
+{
+Box2DBodySharedPtr pBox2DBody = mpXShapeToBodyMap.find(xShape)->second;
+pBox2DBody->setPosition(rOutPos);
+}
+
 void box2DWorld::setShapePositionByLinearVelocity(
 const css::uno::Reference xShape,
 const basegfx::B2DPoint& rOutPos, const double fPassedTime)
@@ -274,6 +282,13 @@ void box2DWorld::setShapeLinearVelocity(
 pBox2DBody->setLinearVelocity(rVelocity);
 }
 
+void box2DWorld::setShapeAngle(const 
css::uno::Reference xShape,
+   const double fAngle)
+{
+Box2DBodySharedPtr pBox2DBody = mpXShapeToBodyMap.find(xShape)->second;
+pBox2DBody->setAngle(fAngle);
+}
+
 void box2DWorld::setShapeAngleByAngularVelocity(
 const css::uno::Reference xShape, const 
double fAngle,
 const double fPassedTime)
@@ -305,41 +320,75 @@ void box2DWorld::setShapeCollision(
 
 void box2DWorld::processUpdateQueue(const double fPassedTime)
 {
-while (!maShapeUpdateQueue.empty())
+if (maShapeSequentialUpdate.empty())
 {
-Box2DShapeUpdateInformation& aQueueElement = 
maShapeUpdateQueue.front();
-
-if (aQueueElement.mnDelayForSteps > 0)
+while (!maShapeParallelUpdateQueue.empty())
 {
-// it was queued as a delayed action, skip it, don't pop
-aQueueElement.mnDelayForSteps--;
+Box2DDynamicUpdateInformation& aQueueElement = 
maShapeParallelUpdateQueue.front();
+
+if (aQueueElement.mnDelayForSteps > 0)
+{
+// it was queued as a delayed action, skip it, don't pop
+aQueueElement.mnDelayForSteps--;
+}
+else
+{
+switch (aQueueElement.meUpdateType)
+{
+default:
+case BOX2D_UPDATE_POSITION:
+setShapePositionByLinearVelocity(aQueueElement.mxShape,
+ 
aQueueElement.maPosition, fPassedTime);
+break;
+case BOX2D_UPDATE_ANGLE:
+setShapeAngleByAngularVelocity(aQueueElement.mxShape, 
aQueueElement.mfAngle,
+   fPassedTime);
+break;
+case BOX2D_UPDATE_SIZE:
+break;
+case BOX2D_UPDATE_VISIBILITY:
+setShapeCollision(aQueueElement.mxShape, 
aQueueElement.mbVisibility);
+break;
+case BOX2D_UPDATE_LINEAR_VELOCITY:
+setShapeLinearVelocity(aQueueElement.mxShape, 
aQueueElement.maVelocity);
+break;
+case BOX2D_UPDATE_ANGULAR_VELOCITY:
+setShapeAngularVelocity(aQueueElement.mxShape,
+
aQueueElement.mfAngularVelocity);
+}
+maShapeParallelUpdateQueue.pop();
+}
 }
-else
+}
+else
+{
+//

[Libreoffice-commits] core.git: Branch 'private/quwex/gsoc-box2d-experimental' - slideshow/source

2020-08-12 Thread Sarper Akdemir (via logerrit)

Rebased ref, commits from common ancestor:
commit 31f1b66be2f0bfedf17fa4e1b83268c42c808430
Author: Sarper Akdemir 
AuthorDate: Thu Aug 13 03:40:25 2020 +0300
Commit: Sarper Akdemir 
CommitDate: Thu Aug 13 06:17:12 2020 +0300

make physics animations handle sequential animations correctly

Change-Id: Ie8bb8b32588f4c7bf16317b5229adc5b0334d192

diff --git a/slideshow/source/engine/animationfactory.cxx 
b/slideshow/source/engine/animationfactory.cxx
index bc1848f68435..d6198439b327 100644
--- a/slideshow/source/engine/animationfactory.cxx
+++ b/slideshow/source/engine/animationfactory.cxx
@@ -323,7 +323,9 @@ namespace slideshow::internal
 {
 mpShapeManager->notifyShapeUpdate( mpShape );
 if ( mpBox2DWorld->isInitialized() )
-mpBox2DWorld->queuePositionUpdate( 
mpShape->getXShape(), rOutPos );
+{
+mpBox2DWorld->queueShapePathAnimationUpdate( 
mpShape->getXShape(), mpAttrLayer );
+}
 }
 
 return true;
diff --git a/slideshow/source/engine/box2dtools.cxx 
b/slideshow/source/engine/box2dtools.cxx
index 68ab37fb6868..0dbc7be63f2a 100644
--- a/slideshow/source/engine/box2dtools.cxx
+++ b/slideshow/source/engine/box2dtools.cxx
@@ -203,7 +203,8 @@ box2DWorld::box2DWorld(const ::basegfx::B2DVector& 
rSlideSize)
 , mbShapesInitialized(false)
 , mbHasWorldStepper(false)
 , mpXShapeToBodyMap()
-, maShapeUpdateQueue()
+, maShapeParallelUpdateQueue()
+, maShapeSequentialUpdate()
 {
 }
 
@@ -253,6 +254,13 @@ void box2DWorld::createStaticFrameAroundSlide(const 
::basegfx::B2DVector& rSlide
 pStaticBody->CreateFixture(&aFixtureDef);
 }
 
+void box2DWorld::setShapePosition(const 
css::uno::Reference xShape,
+  const basegfx::B2DPoint& rOutPos)
+{
+Box2DBodySharedPtr pBox2DBody = mpXShapeToBodyMap.find(xShape)->second;
+pBox2DBody->setPosition(rOutPos);
+}
+
 void box2DWorld::setShapePositionByLinearVelocity(
 const css::uno::Reference xShape,
 const basegfx::B2DPoint& rOutPos, const double fPassedTime)
@@ -274,6 +282,13 @@ void box2DWorld::setShapeLinearVelocity(
 pBox2DBody->setLinearVelocity(rVelocity);
 }
 
+void box2DWorld::setShapeAngle(const 
css::uno::Reference xShape,
+   const double fAngle)
+{
+Box2DBodySharedPtr pBox2DBody = mpXShapeToBodyMap.find(xShape)->second;
+pBox2DBody->setAngle(fAngle);
+}
+
 void box2DWorld::setShapeAngleByAngularVelocity(
 const css::uno::Reference xShape, const 
double fAngle,
 const double fPassedTime)
@@ -305,41 +320,75 @@ void box2DWorld::setShapeCollision(
 
 void box2DWorld::processUpdateQueue(const double fPassedTime)
 {
-while (!maShapeUpdateQueue.empty())
+if (maShapeSequentialUpdate.empty())
 {
-Box2DShapeUpdateInformation& aQueueElement = 
maShapeUpdateQueue.front();
-
-if (aQueueElement.mnDelayForSteps > 0)
+while (!maShapeParallelUpdateQueue.empty())
 {
-// it was queued as a delayed action, skip it, don't pop
-aQueueElement.mnDelayForSteps--;
+Box2DDynamicUpdateInformation& aQueueElement = 
maShapeParallelUpdateQueue.front();
+
+if (aQueueElement.mnDelayForSteps > 0)
+{
+// it was queued as a delayed action, skip it, don't pop
+aQueueElement.mnDelayForSteps--;
+}
+else
+{
+switch (aQueueElement.meUpdateType)
+{
+default:
+case BOX2D_UPDATE_POSITION:
+setShapePositionByLinearVelocity(aQueueElement.mxShape,
+ 
aQueueElement.maPosition, fPassedTime);
+break;
+case BOX2D_UPDATE_ANGLE:
+setShapeAngleByAngularVelocity(aQueueElement.mxShape, 
aQueueElement.mfAngle,
+   fPassedTime);
+break;
+case BOX2D_UPDATE_SIZE:
+break;
+case BOX2D_UPDATE_VISIBILITY:
+setShapeCollision(aQueueElement.mxShape, 
aQueueElement.mbVisibility);
+break;
+case BOX2D_UPDATE_LINEAR_VELOCITY:
+setShapeLinearVelocity(aQueueElement.mxShape, 
aQueueElement.maVelocity);
+break;
+case BOX2D_UPDATE_ANGULAR_VELOCITY:
+setShapeAngularVelocity(aQueueElement.mxShape,
+
aQueueElement.mfAngularVelocity);
+}
+maShapeParallelUpdateQueue.pop();
+}
 }
-else
+}
+else
+{
+//

[Libreoffice-commits] core.git: icon-themes/sukapura icon-themes/sukapura_svg

2020-08-12 Thread Rizal Muttaqin (via logerrit)

 icon-themes/sukapura/res/draw128.png |binary
 icon-themes/sukapura/res/odg_16_8.png|binary
 icon-themes/sukapura/res/odg_24_8.png|binary
 icon-themes/sukapura/res/odg_32_8.png|binary
 icon-themes/sukapura/res/odg_48_8.png|binary
 icon-themes/sukapura/res/odg_96_8.png|binary
 icon-themes/sukapura/res/otg_16_8.png|binary
 icon-themes/sukapura/res/otg_32_8.png|binary
 icon-themes/sukapura/res/otg_48_8.png|binary
 icon-themes/sukapura/res/otg_96_8.png|binary
 icon-themes/sukapura/sfx2/res/128x128_draw_doc-p.png |binary
 icon-themes/sukapura_svg/fpicker/res/fp015.svg   |   87 ++-
 icon-themes/sukapura_svg/res/draw128.svg |2 
 icon-themes/sukapura_svg/res/odg_16_8.svg|2 
 icon-themes/sukapura_svg/res/odg_24_8.svg|2 
 icon-themes/sukapura_svg/res/odg_32_8.svg|2 
 icon-themes/sukapura_svg/res/odg_48_8.svg|2 
 icon-themes/sukapura_svg/res/odg_96_8.svg|2 
 icon-themes/sukapura_svg/res/otg_16_8.svg|2 
 icon-themes/sukapura_svg/res/otg_32_8.svg|2 
 icon-themes/sukapura_svg/res/otg_48_8.svg|2 
 icon-themes/sukapura_svg/res/otg_96_8.svg|2 
 icon-themes/sukapura_svg/sfx2/res/128x128_draw_doc-p.svg |2 
 23 files changed, 97 insertions(+), 12 deletions(-)

New commits:
commit 47196637a41ddfc9a8707771b1b9f482fd72c3b6
Author: Rizal Muttaqin 
AuthorDate: Thu Aug 13 06:12:26 2020 +0700
Commit: Rizal Muttaqin 
CommitDate: Thu Aug 13 02:47:53 2020 +0200

Sukapura: Update MIME types and document folder icons

Change-Id: If55b75c4af523e2cd1440d0546e7ae38d578af93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100634
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin 

diff --git a/icon-themes/sukapura/res/draw128.png 
b/icon-themes/sukapura/res/draw128.png
index 1b1a3211cca1..2cdc88b385b1 100644
Binary files a/icon-themes/sukapura/res/draw128.png and 
b/icon-themes/sukapura/res/draw128.png differ
diff --git a/icon-themes/sukapura/res/odg_16_8.png 
b/icon-themes/sukapura/res/odg_16_8.png
index 209f12f122a4..deba8f3bcc3e 100644
Binary files a/icon-themes/sukapura/res/odg_16_8.png and 
b/icon-themes/sukapura/res/odg_16_8.png differ
diff --git a/icon-themes/sukapura/res/odg_24_8.png 
b/icon-themes/sukapura/res/odg_24_8.png
index daec62e8568c..3d964c5ec90a 100644
Binary files a/icon-themes/sukapura/res/odg_24_8.png and 
b/icon-themes/sukapura/res/odg_24_8.png differ
diff --git a/icon-themes/sukapura/res/odg_32_8.png 
b/icon-themes/sukapura/res/odg_32_8.png
index 105d16185306..e091ddbb7269 100644
Binary files a/icon-themes/sukapura/res/odg_32_8.png and 
b/icon-themes/sukapura/res/odg_32_8.png differ
diff --git a/icon-themes/sukapura/res/odg_48_8.png 
b/icon-themes/sukapura/res/odg_48_8.png
index 2ae6fa1c2d23..65b371d8ad27 100644
Binary files a/icon-themes/sukapura/res/odg_48_8.png and 
b/icon-themes/sukapura/res/odg_48_8.png differ
diff --git a/icon-themes/sukapura/res/odg_96_8.png 
b/icon-themes/sukapura/res/odg_96_8.png
index d0328f4a9e9f..f6a8198e463f 100644
Binary files a/icon-themes/sukapura/res/odg_96_8.png and 
b/icon-themes/sukapura/res/odg_96_8.png differ
diff --git a/icon-themes/sukapura/res/otg_16_8.png 
b/icon-themes/sukapura/res/otg_16_8.png
index 6e6769539935..35edc42f7872 100644
Binary files a/icon-themes/sukapura/res/otg_16_8.png and 
b/icon-themes/sukapura/res/otg_16_8.png differ
diff --git a/icon-themes/sukapura/res/otg_32_8.png 
b/icon-themes/sukapura/res/otg_32_8.png
index c30cec08b4fc..809b8aad509e 100644
Binary files a/icon-themes/sukapura/res/otg_32_8.png and 
b/icon-themes/sukapura/res/otg_32_8.png differ
diff --git a/icon-themes/sukapura/res/otg_48_8.png 
b/icon-themes/sukapura/res/otg_48_8.png
index 39e86131a02b..51117ea28a8d 100644
Binary files a/icon-themes/sukapura/res/otg_48_8.png and 
b/icon-themes/sukapura/res/otg_48_8.png differ
diff --git a/icon-themes/sukapura/res/otg_96_8.png 
b/icon-themes/sukapura/res/otg_96_8.png
index aa59a0b7266f..1592ca169e50 100644
Binary files a/icon-themes/sukapura/res/otg_96_8.png and 
b/icon-themes/sukapura/res/otg_96_8.png differ
diff --git a/icon-themes/sukapura/sfx2/res/128x128_draw_doc-p.png 
b/icon-themes/sukapura/sfx2/res/128x128_draw_doc-p.png
index a02ed8f466b5..06a9be2c973b 100644
Binary files a/icon-themes/sukapura/sfx2/res/128x128_draw_doc-p.png and 
b/icon-themes/sukapura/sfx2/res/128x128_draw_doc-p.png differ
diff --git a/icon-themes/sukapura_svg/fpicker/res/fp015.svg 
b/icon-themes/sukapura_svg/fpicker/res/fp015.svg
index 3b9fde399a9c..c55fa3de4c21 100644
--- a/icon-themes/sukapura_svg/fpicker/res/fp015.svg
+++ b/icon-themes/sukapura_svg/fpicker/res/fp015.svg
@@ -1 +1,86 @@
-http://www.w3.org/2000/svg";>
\

[Libreoffice-commits] core.git: Branch 'private/quwex/gsoc-box2d-experimental' - slideshow/source

2020-08-12 Thread Sarper Akdemir (via logerrit)

 slideshow/source/engine/animationfactory.cxx |4 
 slideshow/source/engine/box2dtools.cxx   |  189 ++-
 slideshow/source/inc/box2dtools.hxx  |   44 +-
 3 files changed, 168 insertions(+), 69 deletions(-)

New commits:
commit 1fb53ef7b889b8cc3e6941c64df7c129575c1c5c
Author: Sarper Akdemir 
AuthorDate: Thu Aug 13 03:40:25 2020 +0300
Commit: Sarper Akdemir 
CommitDate: Thu Aug 13 03:40:25 2020 +0300

make physics animations handle sequential animations correctly

Change-Id: Ie8bb8b32588f4c7bf16317b5229adc5b0334d192

diff --git a/slideshow/source/engine/animationfactory.cxx 
b/slideshow/source/engine/animationfactory.cxx
index bc1848f68435..d6198439b327 100644
--- a/slideshow/source/engine/animationfactory.cxx
+++ b/slideshow/source/engine/animationfactory.cxx
@@ -323,7 +323,9 @@ namespace slideshow::internal
 {
 mpShapeManager->notifyShapeUpdate( mpShape );
 if ( mpBox2DWorld->isInitialized() )
-mpBox2DWorld->queuePositionUpdate( 
mpShape->getXShape(), rOutPos );
+{
+mpBox2DWorld->queueShapePathAnimationUpdate( 
mpShape->getXShape(), mpAttrLayer );
+}
 }
 
 return true;
diff --git a/slideshow/source/engine/box2dtools.cxx 
b/slideshow/source/engine/box2dtools.cxx
index 68ab37fb6868..383836b7dca2 100644
--- a/slideshow/source/engine/box2dtools.cxx
+++ b/slideshow/source/engine/box2dtools.cxx
@@ -203,7 +203,7 @@ box2DWorld::box2DWorld(const ::basegfx::B2DVector& 
rSlideSize)
 , mbShapesInitialized(false)
 , mbHasWorldStepper(false)
 , mpXShapeToBodyMap()
-, maShapeUpdateQueue()
+, maShapeParallelUpdateQueue()
 {
 }
 
@@ -253,6 +253,13 @@ void box2DWorld::createStaticFrameAroundSlide(const 
::basegfx::B2DVector& rSlide
 pStaticBody->CreateFixture(&aFixtureDef);
 }
 
+void box2DWorld::setShapePosition(const 
css::uno::Reference xShape,
+  const basegfx::B2DPoint& rOutPos)
+{
+Box2DBodySharedPtr pBox2DBody = mpXShapeToBodyMap.find(xShape)->second;
+pBox2DBody->setPosition(rOutPos);
+}
+
 void box2DWorld::setShapePositionByLinearVelocity(
 const css::uno::Reference xShape,
 const basegfx::B2DPoint& rOutPos, const double fPassedTime)
@@ -274,6 +281,13 @@ void box2DWorld::setShapeLinearVelocity(
 pBox2DBody->setLinearVelocity(rVelocity);
 }
 
+void box2DWorld::setShapeAngle(const 
css::uno::Reference xShape,
+   const double fAngle)
+{
+Box2DBodySharedPtr pBox2DBody = mpXShapeToBodyMap.find(xShape)->second;
+pBox2DBody->setAngle(fAngle);
+}
+
 void box2DWorld::setShapeAngleByAngularVelocity(
 const css::uno::Reference xShape, const 
double fAngle,
 const double fPassedTime)
@@ -305,42 +319,65 @@ void box2DWorld::setShapeCollision(
 
 void box2DWorld::processUpdateQueue(const double fPassedTime)
 {
-while (!maShapeUpdateQueue.empty())
+if (maShapeSequentialUpdate.empty())
 {
-Box2DShapeUpdateInformation& aQueueElement = 
maShapeUpdateQueue.front();
-
-if (aQueueElement.mnDelayForSteps > 0)
-{
-// it was queued as a delayed action, skip it, don't pop
-aQueueElement.mnDelayForSteps--;
-}
-else
+while (!maShapeParallelUpdateQueue.empty())
 {
-switch (aQueueElement.meUpdateType)
+Box2DDynamicUpdateInformation& aQueueElement = 
maShapeParallelUpdateQueue.front();
+
+if (aQueueElement.mnDelayForSteps > 0)
+{
+// it was queued as a delayed action, skip it, don't pop
+aQueueElement.mnDelayForSteps--;
+}
+else
 {
-default:
-case BOX2D_UPDATE_POSITION:
-setShapePositionByLinearVelocity(aQueueElement.mxShape,
- aQueueElement.maPosition, 
fPassedTime);
-break;
-case BOX2D_UPDATE_ANGLE:
-setShapeAngleByAngularVelocity(aQueueElement.mxShape, 
aQueueElement.mfAngle,
-   fPassedTime);
-break;
-case BOX2D_UPDATE_SIZE:
-break;
-case BOX2D_UPDATE_VISIBILITY:
-setShapeCollision(aQueueElement.mxShape, 
aQueueElement.mbVisibility);
-break;
-case BOX2D_UPDATE_LINEAR_VELOCITY:
-setShapeLinearVelocity(aQueueElement.mxShape, 
aQueueElement.maVelocity);
-break;
-case BOX2D_UPDATE_ANGULAR_VELOCITY:
-setShapeAngularVelocity(aQueueElement.mxShape, 
aQueueElement.mfAngularVelocity);
+switch (aQueueElement.meUpdateType)
+{

[Libreoffice-commits] core.git: icon-themes/breeze icon-themes/breeze_dark icon-themes/breeze_dark_svg icon-themes/breeze_svg icon-themes/elementary icon-themes/elementary_svg icon-themes/karasa_jaga

2020-08-12 Thread Rizal Muttaqin (via logerrit)

 icon-themes/breeze/sw/res/redline_fmtcollset.png  |binary
 icon-themes/breeze/sw/res/redline_formatted.png   |binary
 icon-themes/breeze/sw/res/redline_tablechg.png|binary
 icon-themes/breeze_dark/sw/res/redline_fmtcollset.png |binary
 icon-themes/breeze_dark/sw/res/redline_formatted.png  |binary
 icon-themes/breeze_dark/sw/res/redline_tablechg.png   |binary
 icon-themes/breeze_dark_svg/sw/res/redline_fmtcollset.svg |1 +
 icon-themes/breeze_dark_svg/sw/res/redline_formatted.svg  |1 +
 icon-themes/breeze_dark_svg/sw/res/redline_tablechg.svg   |1 +
 icon-themes/breeze_svg/sw/res/redline_fmtcollset.svg  |1 +
 icon-themes/breeze_svg/sw/res/redline_formatted.svg   |1 +
 icon-themes/breeze_svg/sw/res/redline_tablechg.svg|1 +
 icon-themes/elementary/sw/res/redline_fmtcollset.png  |binary
 icon-themes/elementary/sw/res/redline_formatted.png   |binary
 icon-themes/elementary/sw/res/redline_tablechg.png|binary
 icon-themes/elementary_svg/sw/res/redline_fmtcollset.svg  |1 +
 icon-themes/elementary_svg/sw/res/redline_formatted.svg   |1 +
 icon-themes/elementary_svg/sw/res/redline_tablechg.svg|1 +
 icon-themes/karasa_jaga/sw/res/redline_fmtcollset.png |binary
 icon-themes/karasa_jaga/sw/res/redline_formatted.png  |binary
 icon-themes/karasa_jaga/sw/res/redline_tablechg.png   |binary
 icon-themes/karasa_jaga_svg/sw/res/redline_fmtcollset.svg |1 +
 icon-themes/karasa_jaga_svg/sw/res/redline_formatted.svg  |1 +
 icon-themes/karasa_jaga_svg/sw/res/redline_tablechg.svg   |1 +
 icon-themes/sifr/sw/res/redline_fmtcollset.png|binary
 icon-themes/sifr/sw/res/redline_formatted.png |binary
 icon-themes/sifr/sw/res/redline_tablechg.png  |binary
 icon-themes/sifr_dark/sw/res/redline_fmtcollset.png   |binary
 icon-themes/sifr_dark/sw/res/redline_formatted.png|binary
 icon-themes/sifr_dark/sw/res/redline_tablechg.png |binary
 icon-themes/sifr_dark_svg/sw/res/redline_fmtcollset.svg   |1 +
 icon-themes/sifr_dark_svg/sw/res/redline_formatted.svg|1 +
 icon-themes/sifr_dark_svg/sw/res/redline_tablechg.svg |1 +
 icon-themes/sifr_svg/sw/res/redline_fmtcollset.svg|1 +
 icon-themes/sifr_svg/sw/res/redline_formatted.svg |1 +
 icon-themes/sifr_svg/sw/res/redline_tablechg.svg  |1 +
 icon-themes/sukapura/sw/res/redline_fmtcollset.png|binary
 icon-themes/sukapura/sw/res/redline_formatted.png |binary
 icon-themes/sukapura/sw/res/redline_tablechg.png  |binary
 icon-themes/sukapura_svg/sw/res/redline_fmtcollset.svg|1 +
 icon-themes/sukapura_svg/sw/res/redline_formatted.svg |1 +
 icon-themes/sukapura_svg/sw/res/redline_tablechg.svg  |1 +
 42 files changed, 21 insertions(+)

New commits:
commit 72268f475d9c5f85c1c2195218cc41cf273f7dc6
Author: Rizal Muttaqin 
AuthorDate: Thu Aug 13 06:04:06 2020 +0700
Commit: Rizal Muttaqin 
CommitDate: Thu Aug 13 02:15:50 2020 +0200

tdf#135265 Add icon variants in Manage Changes dialog

Change-Id: Ifcffc928040fc5e3f82f005d977bf3f6df8bd786
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100633
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin 

diff --git a/icon-themes/breeze/sw/res/redline_fmtcollset.png 
b/icon-themes/breeze/sw/res/redline_fmtcollset.png
new file mode 100644
index ..56873c89963f
Binary files /dev/null and b/icon-themes/breeze/sw/res/redline_fmtcollset.png 
differ
diff --git a/icon-themes/breeze/sw/res/redline_formatted.png 
b/icon-themes/breeze/sw/res/redline_formatted.png
new file mode 100644
index ..49992c58a7aa
Binary files /dev/null and b/icon-themes/breeze/sw/res/redline_formatted.png 
differ
diff --git a/icon-themes/breeze/sw/res/redline_tablechg.png 
b/icon-themes/breeze/sw/res/redline_tablechg.png
new file mode 100644
index ..1076488ea1fa
Binary files /dev/null and b/icon-themes/breeze/sw/res/redline_tablechg.png 
differ
diff --git a/icon-themes/breeze_dark/sw/res/redline_fmtcollset.png 
b/icon-themes/breeze_dark/sw/res/redline_fmtcollset.png
new file mode 100644
index ..a4366a2e3195
Binary files /dev/null and 
b/icon-themes/breeze_dark/sw/res/redline_fmtcollset.png differ
diff --git a/icon-themes/breeze_dark/sw/res/redline_formatted.png 
b/icon-themes/breeze_dark/sw/res/redline_formatted.png
new file mode 100644
index ..fdce5107c98b
Binary files /dev/null and 
b/icon-themes/breeze_dark/sw/res/redline_formatted.png differ
diff --git a/icon-themes/breeze_dark/sw/res/redline_tablechg.png 
b/icon-themes/breeze_dark/sw/res/redline_tablechg.png
new file mode 100644
index ..13619e903bb5
Binary files /dev/null and 
b/icon-themes/breeze_dark/sw/res/redline_tablechg.png differ
diff --git a/icon-themes/breeze_dark_svg/sw/res/redline_fmtcollset.svg 
b/icon-themes/breeze_dark_svg/sw/res/redline_fmtcollset.svg

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - icon-themes/colibre icon-themes/colibre_svg

2020-08-12 Thread Rizal Muttaqin (via logerrit)

 icon-themes/colibre/cmd/lc_wrapthrough.png|binary
 icon-themes/colibre/cmd/sc_symbolshapes.diamond-bevel.png |binary
 icon-themes/colibre/cmd/sc_symbolshapes.octagon-bevel.png |binary
 icon-themes/colibre/cmd/sc_symbolshapes.quad-bevel.png|binary
 icon-themes/colibre_svg/cmd/lc_wrapthrough.svg|2 +-
 icon-themes/colibre_svg/cmd/sc_symbolshapes.diamond-bevel.svg |2 +-
 icon-themes/colibre_svg/cmd/sc_symbolshapes.octagon-bevel.svg |2 +-
 icon-themes/colibre_svg/cmd/sc_symbolshapes.quad-bevel.svg|2 +-
 8 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 7cef0327736e84ac544b32567e9408e580b9e969
Author: Rizal Muttaqin 
AuthorDate: Wed Aug 12 21:39:30 2020 +0700
Commit: Rizal Muttaqin 
CommitDate: Thu Aug 13 02:16:12 2020 +0200

Colibre tdf#135670 Square Bevel and Octagon Bevel icons

Change-Id: I99fd0a65899d3322896fe5f9fdab93e6521d41c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100604
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin 
(cherry picked from commit d9f944ce9447ec86b3536c9fc8f6f8c6dd450a73)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100520

diff --git a/icon-themes/colibre/cmd/lc_wrapthrough.png 
b/icon-themes/colibre/cmd/lc_wrapthrough.png
index 95a2b4be9966..b4d957bf700b 100644
Binary files a/icon-themes/colibre/cmd/lc_wrapthrough.png and 
b/icon-themes/colibre/cmd/lc_wrapthrough.png differ
diff --git a/icon-themes/colibre/cmd/sc_symbolshapes.diamond-bevel.png 
b/icon-themes/colibre/cmd/sc_symbolshapes.diamond-bevel.png
index 4570ea148ac1..1c8507a46a93 100644
Binary files a/icon-themes/colibre/cmd/sc_symbolshapes.diamond-bevel.png and 
b/icon-themes/colibre/cmd/sc_symbolshapes.diamond-bevel.png differ
diff --git a/icon-themes/colibre/cmd/sc_symbolshapes.octagon-bevel.png 
b/icon-themes/colibre/cmd/sc_symbolshapes.octagon-bevel.png
index a3072ff655a2..17b7fed0cdf6 100644
Binary files a/icon-themes/colibre/cmd/sc_symbolshapes.octagon-bevel.png and 
b/icon-themes/colibre/cmd/sc_symbolshapes.octagon-bevel.png differ
diff --git a/icon-themes/colibre/cmd/sc_symbolshapes.quad-bevel.png 
b/icon-themes/colibre/cmd/sc_symbolshapes.quad-bevel.png
index 82101e957584..258bbe1b2fdf 100644
Binary files a/icon-themes/colibre/cmd/sc_symbolshapes.quad-bevel.png and 
b/icon-themes/colibre/cmd/sc_symbolshapes.quad-bevel.png differ
diff --git a/icon-themes/colibre_svg/cmd/lc_wrapthrough.svg 
b/icon-themes/colibre_svg/cmd/lc_wrapthrough.svg
index 3503ad9b030b..3791093e250d 100644
--- a/icon-themes/colibre_svg/cmd/lc_wrapthrough.svg
+++ b/icon-themes/colibre_svg/cmd/lc_wrapthrough.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg";>
\ No newline at end of file
+http://www.w3.org/2000/svg";>
\ No newline at end of file
diff --git a/icon-themes/colibre_svg/cmd/sc_symbolshapes.diamond-bevel.svg 
b/icon-themes/colibre_svg/cmd/sc_symbolshapes.diamond-bevel.svg
index 5bb44ef2c8a1..fa3fcd763cd5 100644
--- a/icon-themes/colibre_svg/cmd/sc_symbolshapes.diamond-bevel.svg
+++ b/icon-themes/colibre_svg/cmd/sc_symbolshapes.diamond-bevel.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg";>
\ No newline at end of file
+http://www.w3.org/2000/svg";>
\ No newline at end of file
diff --git a/icon-themes/colibre_svg/cmd/sc_symbolshapes.octagon-bevel.svg 
b/icon-themes/colibre_svg/cmd/sc_symbolshapes.octagon-bevel.svg
index 21b6ab8f1628..de3cd9daf070 100644
--- a/icon-themes/colibre_svg/cmd/sc_symbolshapes.octagon-bevel.svg
+++ b/icon-themes/colibre_svg/cmd/sc_symbolshapes.octagon-bevel.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg";>
\ No newline at end of file
+http://www.w3.org/2000/svg";>
\ No newline at end of file
diff --git a/icon-themes/colibre_svg/cmd/sc_symbolshapes.quad-bevel.svg 
b/icon-themes/colibre_svg/cmd/sc_symbolshapes.quad-bevel.svg
index 466967cd08ab..3e33b9e44b9f 100644
--- a/icon-themes/colibre_svg/cmd/sc_symbolshapes.quad-bevel.svg
+++ b/icon-themes/colibre_svg/cmd/sc_symbolshapes.quad-bevel.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg";>
\ No newline at end of file
+http://www.w3.org/2000/svg";>
\ No newline at end of file
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: feature request for development, funding, and lessons

2020-08-12 Thread Jan-Marek Glogowski

Hi Thomas,

Am 13.08.20 um 01:23 schrieb Thomas Gertin:
> I am really interested in headless LibreOffice, and would like the
> functionality to be able to both convert docs to pdfs, and pdfs to docs
> via the command line. I am not sure if this functionality will be added
> in the next release of LibreOffice. I would like to engage in a
> conversation if this is a feature that can be funded somehow.

There is already: https://github.com/unoconv/unoconv

Converting a PDF to a "doc" will AFAIK generally just work as an ODG
document, if you want to edit the result and not just embed the PDF.

> Also, I do not know C++, but I would like to learn C++ and how to do
> LibreOffice development. I would be willing to pay $15 an hour for
> online lessons. Please let me know if you are interested.

I think you should look for some C++ courses from some local education
providers. Or maybe book some online university courses. These are
normally free, but for a small fee you normally get additional help from
instructors and eventually a certificate.

To start with LO development, you can have a look at
https://wiki.documentfoundation.org/Development/GetInvolved

HTH

Jan-Marek
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - include/vcl vcl/unx

2020-08-12 Thread Caolán McNamara (via logerrit)

 include/vcl/weld.hxx |6 +-
 vcl/unx/gtk3/gtk3gtkinst.cxx |2 ++
 2 files changed, 7 insertions(+), 1 deletion(-)

New commits:
commit 1138c3d51a2e5caea7832597c00c62918299a3d7
Author: Caolán McNamara 
AuthorDate: Wed Aug 12 15:59:40 2020 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Aug 13 01:26:17 2020 +0200

tdf#135640 ensure parent rows are expanded on scolling to make a row visible

Change-Id: I37e55ed8d0d3d5916950228ba78982b90356fbc2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100516
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index cae26c1ffccf..33138aae57c2 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -935,7 +935,9 @@ public:
 virtual void swap(int pos1, int pos2) = 0;
 virtual std::vector get_selected_rows() const = 0;
 virtual void set_font_color(int pos, const Color& rColor) = 0;
-virtual void scroll_to_row(int pos) = 0;
+// scroll to make 'row' visible, this will also expand all parent rows of 
'row' as necessary to
+// make 'row' visible
+virtual void scroll_to_row(int row) = 0;
 virtual bool is_selected(int pos) const = 0;
 virtual int get_cursor_index() const = 0;
 virtual void set_cursor(int pos) = 0;
@@ -1031,6 +1033,8 @@ public:
const css::uno::Reference& 
rImage, int col = -1)
 = 0;
 virtual void set_font_color(const TreeIter& rIter, const Color& rColor) = 
0;
+// scroll to make rIter visible, this will also expand all parent rows of 
rIter as necessary to
+// make rIter visible
 virtual void scroll_to_row(const TreeIter& rIter) = 0;
 virtual bool is_selected(const TreeIter& rIter) const = 0;
 
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index c399eaf1a356..5ac1ec88fc10 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -10196,6 +10196,7 @@ public:
 assert(gtk_tree_view_get_model(m_pTreeView) && "don't select when 
frozen, select after thaw. Note selection doesn't survive a freeze");
 disable_notify_events();
 GtkTreePath* path = gtk_tree_path_new_from_indices(pos, -1);
+gtk_tree_view_expand_to_path(m_pTreeView, path);
 gtk_tree_view_scroll_to_cell(m_pTreeView, path, nullptr, false, 0, 0);
 gtk_tree_path_free(path);
 enable_notify_events();
@@ -10865,6 +10866,7 @@ public:
 const GtkInstanceTreeIter& rGtkIter = static_cast(rIter);
 GtkTreeModel *pModel = GTK_TREE_MODEL(m_pTreeStore);
 GtkTreePath* path = gtk_tree_model_get_path(pModel, 
const_cast(&rGtkIter.iter));
+gtk_tree_view_expand_to_path(m_pTreeView, path);
 gtk_tree_view_scroll_to_cell(m_pTreeView, path, nullptr, false, 0, 0);
 gtk_tree_path_free(path);
 enable_notify_events();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

feature request for development, funding, and lessons

2020-08-12 Thread Thomas Gertin

To Whom This May Concern,

I am really interested in headless LibreOffice, and would like the
functionality to be able to both convert docs to pdfs, and pdfs to docs via
the command line. I am not sure if this functionality will be added in the
next release of LibreOffice. I would like to engage in a conversation if
this is a feature that can be funded somehow.

Also, I do not know C++, but I would like to learn C++ and how to do
LibreOffice development. I would be willing to pay $15 an hour for online
lessons. Please let me know if you are interested.

Thanks,

Tom G.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: include/svtools sd/source svtools/source svx/source

2020-08-12 Thread Maxim Monastirsky (via logerrit)

 include/svtools/toolbarmenu.hxx   |   53 ++--
 sd/source/ui/controller/slidelayoutcontroller.cxx |8 -
 svtools/source/control/toolbarmenu.cxx|   97 ++
 svx/source/tbxctrls/tbcontrl.cxx  |2 
 4 files changed, 45 insertions(+), 115 deletions(-)

New commits:
commit 839b27f249197c83ce0260396a67a2f15bdf4e9a
Author: Maxim Monastirsky 
AuthorDate: Wed Aug 12 15:42:50 2020 +0300
Commit: Maxim Monastirsky 
CommitDate: Thu Aug 13 00:40:05 2020 +0200

Merge toolbar popup classes

Now that all popups are welded.

Change-Id: I5ad8a4eb6b9512ea9dd075b56d0ae6ee201fff19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100597
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky 

diff --git a/include/svtools/toolbarmenu.hxx b/include/svtools/toolbarmenu.hxx
index c08da7e9c899..6e8aa5588de2 100644
--- a/include/svtools/toolbarmenu.hxx
+++ b/include/svtools/toolbarmenu.hxx
@@ -33,45 +33,7 @@ namespace com :: sun :: star :: frame { class XFrame; }
 namespace com :: sun :: star :: frame { struct FeatureStateEvent; }
 namespace svt { class FrameStatusListener; }
 
-namespace svtools {
-
-class SVT_DLLPUBLIC ToolbarPopupBase
-{
-friend class ToolbarPopupStatusListener;
-public:
-ToolbarPopupBase(const css::uno::Reference& rFrame);
-virtual ~ToolbarPopupBase();
-
-protected:
-void AddStatusListener( const OUString& rCommandURL );
-
-// Forwarded from XStatusListener (subclasses must override this one to 
get the status updates):
-/// @throws css::uno::RuntimeException
-virtual void statusChanged(const css::frame::FeatureStateEvent& Event );
-
-css::uno::Reference  mxFrame;
-rtl::Reference mxStatusListener;
-};
-
-class UNLESS_MERGELIBS(SVT_DLLPUBLIC) ToolbarPopup : public DockingWindow, 
public ToolbarPopupBase
-{
-public:
-ToolbarPopup(const css::uno::Reference& rFrame,
- vcl::Window* pParentWindow,
- const OString& rID, const OUString& rUIXMLDescription );
-virtual ~ToolbarPopup() override;
-virtual void dispose() override;
-
-protected:
-void EndPopupMode();
-
-private:
-void init();
-};
-
-} // namespace svtools
-
-class SVT_DLLPUBLIC WeldToolbarPopup : public svtools::ToolbarPopupBase
+class SVT_DLLPUBLIC WeldToolbarPopup
 {
 private:
 DECL_LINK(FocusHdl, weld::Widget&, void);
@@ -80,14 +42,20 @@ protected:
 std::unique_ptr m_xBuilder;
 std::unique_ptr m_xTopLevel;
 std::unique_ptr m_xContainer;
+css::uno::Reference m_xFrame;
+rtl::Reference m_xStatusListener;
 
 public:
 WeldToolbarPopup(const css::uno::Reference& rFrame,
  weld::Widget* pParent, const OUString& rUIFile, const 
OString& rId);
-virtual ~WeldToolbarPopup() override;
+virtual ~WeldToolbarPopup();
 weld::Container* getTopLevel() { return m_xTopLevel.get(); }
 weld::Container* getContainer() { return m_xContainer.get(); }
+void AddStatusListener(const OUString& rCommandURL);
 
+// Forwarded from XStatusListener (subclasses must override this one to 
get the status updates):
+/// @throws css::uno::RuntimeException
+virtual void statusChanged(const css::frame::FeatureStateEvent& Event);
 virtual void GrabFocus() = 0;
 };
 
@@ -116,10 +84,11 @@ public:
 void unsetPopover();
 };
 
-class SVT_DLLPUBLIC InterimToolbarPopup final : public svtools::ToolbarPopup
+class SVT_DLLPUBLIC InterimToolbarPopup final : public DockingWindow
 {
 private:
 VclPtr m_xBox;
+css::uno::Reference m_xFrame;
 std::unique_ptr m_xBuilder;
 std::unique_ptr m_xContainer;
 std::unique_ptr m_xPopup;
@@ -132,7 +101,7 @@ public:
 
 virtual void GetFocus() override;
 
-using ToolbarPopup::EndPopupMode;
+void EndPopupMode();
 };
 
 #endif
diff --git a/sd/source/ui/controller/slidelayoutcontroller.cxx 
b/sd/source/ui/controller/slidelayoutcontroller.cxx
index 41071def8409..284df02be296 100644
--- a/sd/source/ui/controller/slidelayoutcontroller.cxx
+++ b/sd/source/ui/controller/slidelayoutcontroller.cxx
@@ -170,9 +170,9 @@ LayoutToolbarMenu::LayoutToolbarMenu(SlideLayoutController* 
pControl, weld::Widg
 DrawViewMode eMode = DrawViewMode_DRAW;
 
 // find out which view is running
-if( mxFrame.is() ) try
+if( m_xFrame.is() ) try
 {
-Reference< XPropertySet > xControllerSet( mxFrame->getController(), 
UNO_QUERY_THROW );
+Reference< XPropertySet > xControllerSet( m_xFrame->getController(), 
UNO_QUERY_THROW );
 xControllerSet->getPropertyValue( "DrawViewMode" ) >>= eMode;
 }
 catch( Exception& )
@@ -220,7 +220,7 @@ LayoutToolbarMenu::LayoutToolbarMenu(SlideLayoutController* 
pControl, weld::Widg
 if( eMode != DrawViewMode_DRAW )
 return;
 
-if( !mxFrame.is() )
+if( !m_xFrame.is() )
 return;
 
 OUString sSlotStr;
@@ -230,7 +230,7 @@ LayoutToolbarMenu::LayoutToolbarMenu(SlideLayoutController* 
pContro

[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_svg

2020-08-12 Thread Rizal Muttaqin (via logerrit)

 icon-themes/colibre/cmd/lc_wrapthrough.png|binary
 icon-themes/colibre/cmd/sc_symbolshapes.diamond-bevel.png |binary
 icon-themes/colibre/cmd/sc_symbolshapes.octagon-bevel.png |binary
 icon-themes/colibre/cmd/sc_symbolshapes.quad-bevel.png|binary
 icon-themes/colibre_svg/cmd/lc_wrapthrough.svg|2 +-
 icon-themes/colibre_svg/cmd/sc_symbolshapes.diamond-bevel.svg |2 +-
 icon-themes/colibre_svg/cmd/sc_symbolshapes.octagon-bevel.svg |2 +-
 icon-themes/colibre_svg/cmd/sc_symbolshapes.quad-bevel.svg|2 +-
 8 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit d9f944ce9447ec86b3536c9fc8f6f8c6dd450a73
Author: Rizal Muttaqin 
AuthorDate: Wed Aug 12 21:39:30 2020 +0700
Commit: Rizal Muttaqin 
CommitDate: Wed Aug 12 23:54:22 2020 +0200

Colibre tdf#135670 Square Bevel and Octagon Bevel icons

Change-Id: I99fd0a65899d3322896fe5f9fdab93e6521d41c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100604
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin 

diff --git a/icon-themes/colibre/cmd/lc_wrapthrough.png 
b/icon-themes/colibre/cmd/lc_wrapthrough.png
index 95a2b4be9966..b4d957bf700b 100644
Binary files a/icon-themes/colibre/cmd/lc_wrapthrough.png and 
b/icon-themes/colibre/cmd/lc_wrapthrough.png differ
diff --git a/icon-themes/colibre/cmd/sc_symbolshapes.diamond-bevel.png 
b/icon-themes/colibre/cmd/sc_symbolshapes.diamond-bevel.png
index 4570ea148ac1..1c8507a46a93 100644
Binary files a/icon-themes/colibre/cmd/sc_symbolshapes.diamond-bevel.png and 
b/icon-themes/colibre/cmd/sc_symbolshapes.diamond-bevel.png differ
diff --git a/icon-themes/colibre/cmd/sc_symbolshapes.octagon-bevel.png 
b/icon-themes/colibre/cmd/sc_symbolshapes.octagon-bevel.png
index a3072ff655a2..17b7fed0cdf6 100644
Binary files a/icon-themes/colibre/cmd/sc_symbolshapes.octagon-bevel.png and 
b/icon-themes/colibre/cmd/sc_symbolshapes.octagon-bevel.png differ
diff --git a/icon-themes/colibre/cmd/sc_symbolshapes.quad-bevel.png 
b/icon-themes/colibre/cmd/sc_symbolshapes.quad-bevel.png
index 82101e957584..258bbe1b2fdf 100644
Binary files a/icon-themes/colibre/cmd/sc_symbolshapes.quad-bevel.png and 
b/icon-themes/colibre/cmd/sc_symbolshapes.quad-bevel.png differ
diff --git a/icon-themes/colibre_svg/cmd/lc_wrapthrough.svg 
b/icon-themes/colibre_svg/cmd/lc_wrapthrough.svg
index 3503ad9b030b..3791093e250d 100644
--- a/icon-themes/colibre_svg/cmd/lc_wrapthrough.svg
+++ b/icon-themes/colibre_svg/cmd/lc_wrapthrough.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg";>
\ No newline at end of file
+http://www.w3.org/2000/svg";>
\ No newline at end of file
diff --git a/icon-themes/colibre_svg/cmd/sc_symbolshapes.diamond-bevel.svg 
b/icon-themes/colibre_svg/cmd/sc_symbolshapes.diamond-bevel.svg
index 5bb44ef2c8a1..fa3fcd763cd5 100644
--- a/icon-themes/colibre_svg/cmd/sc_symbolshapes.diamond-bevel.svg
+++ b/icon-themes/colibre_svg/cmd/sc_symbolshapes.diamond-bevel.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg";>
\ No newline at end of file
+http://www.w3.org/2000/svg";>
\ No newline at end of file
diff --git a/icon-themes/colibre_svg/cmd/sc_symbolshapes.octagon-bevel.svg 
b/icon-themes/colibre_svg/cmd/sc_symbolshapes.octagon-bevel.svg
index 21b6ab8f1628..de3cd9daf070 100644
--- a/icon-themes/colibre_svg/cmd/sc_symbolshapes.octagon-bevel.svg
+++ b/icon-themes/colibre_svg/cmd/sc_symbolshapes.octagon-bevel.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg";>
\ No newline at end of file
+http://www.w3.org/2000/svg";>
\ No newline at end of file
diff --git a/icon-themes/colibre_svg/cmd/sc_symbolshapes.quad-bevel.svg 
b/icon-themes/colibre_svg/cmd/sc_symbolshapes.quad-bevel.svg
index 466967cd08ab..3e33b9e44b9f 100644
--- a/icon-themes/colibre_svg/cmd/sc_symbolshapes.quad-bevel.svg
+++ b/icon-themes/colibre_svg/cmd/sc_symbolshapes.quad-bevel.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg";>
\ No newline at end of file
+http://www.w3.org/2000/svg";>
\ No newline at end of file
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/inc sw/source

2020-08-12 Thread Miklos Vajna (via logerrit)

 sw/inc/numrule.hxx |8 +++
 sw/inc/tblafmt.hxx |2 -
 sw/inc/unodraw.hxx |2 -
 sw/source/core/bastyp/init.cxx |2 -
 sw/source/core/doc/number.cxx  |   34 
 sw/source/core/doc/tblafmt.cxx |   39 ++---
 sw/source/core/unocore/unodraw.cxx |   12 +--
 7 files changed, 49 insertions(+), 50 deletions(-)

New commits:
commit 29eaf5c012ea52fe148ee7af7a56efeb6e3338a6
Author: Miklos Vajna 
AuthorDate: Wed Aug 12 17:43:59 2020 +0200
Commit: Miklos Vajna 
CommitDate: Wed Aug 12 22:37:42 2020 +0200

sw: prefix members of SwFmDrawPage, SwNumRule, SwTableAutoFormat and ...

... WriterSpecificAutoFormatBlock

See tdf#94879 for motivation.

Change-Id: Ie740f07e1c65a6def6ba673529144d0e111b056e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100610
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sw/inc/numrule.hxx b/sw/inc/numrule.hxx
index 6152e6bee99f..dba69c701671 100644
--- a/sw/inc/numrule.hxx
+++ b/sw/inc/numrule.hxx
@@ -105,11 +105,11 @@ public:
 private:
 friend void FinitCore();
 
-static SwNumFormat* maBaseFormats [ RULE_END ][ MAXLEVEL ];
-static const sal_uInt16 maDefNumIndents[ MAXLEVEL ];
+static SwNumFormat* saBaseFormats [ RULE_END ][ MAXLEVEL ];
+static const sal_uInt16 saDefNumIndents[ MAXLEVEL ];
 /// default list level properties for position-and-space mode 
LABEL_ALIGNMENT
-static SwNumFormat* maLabelAlignmentBaseFormats [ RULE_END ][ MAXLEVEL ];
-static sal_uInt16 mnRefCount;
+static SwNumFormat* saLabelAlignmentBaseFormats [ RULE_END ][ MAXLEVEL ];
+static sal_uInt16 snRefCount;
 
 std::unique_ptr maFormats[ MAXLEVEL ];
 
diff --git a/sw/inc/tblafmt.hxx b/sw/inc/tblafmt.hxx
index f9073edff8c5..0a6866c3cb2a 100644
--- a/sw/inc/tblafmt.hxx
+++ b/sw/inc/tblafmt.hxx
@@ -153,7 +153,7 @@ class SW_DLLPUBLIC SwTableAutoFormat
 {
 friend class SwDocTest;
 friend void FinitCore();   // To destroy default pointer.
-static SwBoxAutoFormat* pDfltBoxAutoFormat;
+static SwBoxAutoFormat* s_pDefaultBoxAutoFormat;
 
 css::uno::WeakReference m_wXObject;
 
diff --git a/sw/inc/unodraw.hxx b/sw/inc/unodraw.hxx
index 599a3308e252..ecead00bf183 100644
--- a/sw/inc/unodraw.hxx
+++ b/sw/inc/unodraw.hxx
@@ -43,7 +43,7 @@ class SwXShape;
 
 class SwFmDrawPage final : public SvxFmDrawPage
 {
-SdrPageView*pPageView;
+SdrPageView*m_pPageView;
 std::vector m_vShapes;
 public:
 SwFmDrawPage( SdrPage* pPage );
diff --git a/sw/source/core/bastyp/init.cxx b/sw/source/core/bastyp/init.cxx
index 79cea41a8cc0..1c5c1da46120 100644
--- a/sw/source/core/bastyp/init.cxx
+++ b/sw/source/core/bastyp/init.cxx
@@ -681,7 +681,7 @@ void FinitCore()
 delete pCaseCollator;
 
 // destroy default TableAutoFormat
-delete SwTableAutoFormat::pDfltBoxAutoFormat;
+delete SwTableAutoFormat::s_pDefaultBoxAutoFormat;
 
 delete SwSelPaintRects::s_pMapMode;
 delete SwFntObj::pPixMap;
diff --git a/sw/source/core/doc/number.cxx b/sw/source/core/doc/number.cxx
index 2dd071433192..43cbad07cb61 100644
--- a/sw/source/core/doc/number.cxx
+++ b/sw/source/core/doc/number.cxx
@@ -57,14 +57,14 @@
 
 using namespace ::com::sun::star;
 
-sal_uInt16 SwNumRule::mnRefCount = 0;
-SwNumFormat* SwNumRule::maBaseFormats[ RULE_END ][ MAXLEVEL ] = {
+sal_uInt16 SwNumRule::snRefCount = 0;
+SwNumFormat* SwNumRule::saBaseFormats[ RULE_END ][ MAXLEVEL ] = {
 {nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, 
nullptr, nullptr } };
 
-SwNumFormat* SwNumRule::maLabelAlignmentBaseFormats[ RULE_END ][ MAXLEVEL ] = {
+SwNumFormat* SwNumRule::saLabelAlignmentBaseFormats[ RULE_END ][ MAXLEVEL ] = {
 {nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, nullptr, 
nullptr, nullptr } };
 
-const sal_uInt16 SwNumRule::maDefNumIndents[ MAXLEVEL ] = {
+const sal_uInt16 SwNumRule::saDefNumIndents[ MAXLEVEL ] = {
 //inch:   0,5  1,0  1,5  2,0   2,5   3,0   3,5   4,0   4,5   5,0
 1440/4, 1440/2, 1440*3/4, 1440, 1440*5/4, 1440*3/2, 1440*7/4, 1440*2,
 1440*9/4, 1440*5/2
@@ -81,8 +81,8 @@ const SwNumFormat& SwNumRule::Get( sal_uInt16 i ) const
 return maFormats[ i ]
? *maFormats[ i ]
: ( meDefaultNumberFormatPositionAndSpaceMode == 
SvxNumberFormat::LABEL_WIDTH_AND_POSITION
-   ? *maBaseFormats[ meRuleType ][ i ]
-   : *maLabelAlignmentBaseFormats[ meRuleType ][ i ] );
+   ? *saBaseFormats[ meRuleType ][ i ]
+   : *saLabelAlignmentBaseFormats[ meRuleType ][ i ] );
 }
 
 const SwNumFormat* SwNumRule::GetNumFormat( sal_uInt16 i ) const
@@ -160,13 +160,13 @@ void 
SwNumRule::SetNumRuleMap(std::unordered_map *
 sal_uInt16 SwNumRule::GetNumIndent( sal_uInt8 nLvl )
 {
 OSL_ENSURE( MAXLEVEL > nLvl, "NumLevel is out of range" );
-return maDefNu

[Libreoffice-commits] core.git: helpcontent2

2020-08-12 Thread Olivier Hallot (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 50c6fba059c6f31eb359d258fab2172ffeee0cc4
Author: Olivier Hallot 
AuthorDate: Wed Aug 12 17:32:57 2020 -0300
Commit: Gerrit Code Review 
CommitDate: Wed Aug 12 22:32:57 2020 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 6b7711c79345eb2171679b634d23e1be1722dc81
  - Fix "zurueck" in many files

Change-Id: I6c8203f5a3ace90e58453792b5356d51dc12e59e
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/100630
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 49af25239f65..6b7711c79345 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 49af25239f655a8d87dbe28bf5ed75040ca6bc11
+Subproject commit 6b7711c79345eb2171679b634d23e1be1722dc81
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

2020-08-12 Thread Olivier Hallot (via logerrit)

 source/text/shared/00/0001.xhp   |2 +-
 source/text/shared/01/01010200.xhp   |2 +-
 source/text/shared/01/01010300.xhp   |2 +-
 source/text/shared/01/0110.xhp   |2 +-
 source/text/shared/01/0502.xhp   |2 +-
 source/text/shared/01/05020100.xhp   |2 +-
 source/text/shared/01/05020200.xhp   |2 +-
 source/text/shared/01/05020500.xhp   |2 +-
 source/text/shared/01/0503.xhp   |2 +-
 source/text/shared/01/05030100.xhp   |2 +-
 source/text/shared/01/05030300.xhp   |2 +-
 source/text/shared/01/05030500.xhp   |2 +-
 source/text/shared/01/05030700.xhp   |2 +-
 source/text/shared/01/05040100.xhp   |2 +-
 source/text/shared/01/0520.xhp   |2 +-
 source/text/shared/01/0521.xhp   |2 +-
 source/text/shared/01/05210100.xhp   |2 +-
 source/text/shared/01/05210700.xhp   |2 +-
 source/text/shared/01/0523.xhp   |2 +-
 source/text/shared/01/0599.xhp   |2 +-
 source/text/shared/01/06050600.xhp   |2 +-
 source/text/shared/optionen/0101.xhp |2 +-
 source/text/shared/optionen/0102.xhp |2 +-
 source/text/shared/optionen/0103.xhp |2 +-
 source/text/shared/optionen/0105.xhp |2 +-
 source/text/shared/optionen/0106.xhp |2 +-
 source/text/shared/optionen/0107.xhp |2 +-
 source/text/shared/optionen/0108.xhp |2 +-
 source/text/shared/optionen/0109.xhp |2 +-
 source/text/shared/optionen/0111.xhp |2 +-
 source/text/shared/optionen/0115.xhp |2 +-
 source/text/shared/optionen/0116.xhp |2 +-
 32 files changed, 32 insertions(+), 32 deletions(-)

New commits:
commit 6b7711c79345eb2171679b634d23e1be1722dc81
Author: Olivier Hallot 
AuthorDate: Wed Aug 12 17:30:06 2020 -0300
Commit: Olivier Hallot 
CommitDate: Wed Aug 12 22:32:57 2020 +0200

Fix "zurueck" in many files

Change-Id: I6c8203f5a3ace90e58453792b5356d51dc12e59e
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/100630
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/shared/00/0001.xhp 
b/source/text/shared/00/0001.xhp
index b87f68d1f..22a53eefe 100644
--- a/source/text/shared/00/0001.xhp
+++ b/source/text/shared/00/0001.xhp
@@ -263,7 +263,7 @@
   Save 
the changes in the page and close the Options dialog.
 Cancel
   Close the Options dialog and discard all changes 
done.
-
+
 
 Some options cannot be reset once edited. 
Either edit back the changes manually or click Cancel and reopen 
the Options dialog.
 
diff --git a/source/text/shared/01/01010200.xhp 
b/source/text/shared/01/01010200.xhp
index d9bcecac6..4a79fb48c 100644
--- a/source/text/shared/01/01010200.xhp
+++ b/source/text/shared/01/01010200.xhp
@@ -43,7 +43,7 @@
 
 New 
Document
   Creates a new document for 
editing.
-
+
 
   Creating 
labels
 
diff --git a/source/text/shared/01/01010300.xhp 
b/source/text/shared/01/01010300.xhp
index d22b42d4d..0528bc211 100644
--- a/source/text/shared/01/01010300.xhp
+++ b/source/text/shared/01/01010300.xhp
@@ -42,7 +42,7 @@
 
 
 
-
+
 
 
 
diff --git a/source/text/shared/01/0110.xhp 
b/source/text/shared/01/0110.xhp
index 9950605f6..323957087 100644
--- a/source/text/shared/01/0110.xhp
+++ b/source/text/shared/01/0110.xhp
@@ -48,7 +48,7 @@
 
 
 
-
+
 Depending on your 
access rights to the file, you might not see all of the tabs in the 
Properties dialog.
 
 
diff --git a/source/text/shared/01/0502.xhp 
b/source/text/shared/01/0502.xhp
index c8e068c6d..6d0aec10b 100644
--- a/source/text/shared/01/0502.xhp
+++ b/source/text/shared/01/0502.xhp
@@ -56,6 +56,6 @@
 
 
 
-
+
 
 
diff --git a/source/text/shared/01/05020100.xhp 
b/source/text/shared/01/05020100.xhp
index 7f521922b..de7bf4c08 100644
--- a/source/text/shared/01/05020100.xhp
+++ b/source/text/shared/01/05020100.xhp
@@ -108,7 +108,7 @@
 
 
 
-
+
 
 
 Asian 
languages support
diff --git a/source/text/shared/01/05020200.xhp 
b/source/text/shared/01/05020200.xhp
index 8c214ef99..aa2c6d1a0 100644
--- a/source/text/shared/01/05020200.xhp
+++ b/source/text/shared/01/05020200.xhp
@@ -182,7 +182,7 @@
 Position
   Specify where to display the emphasis 
marks.
   
-  
+  
 Only Writer has Apply button
 
   
diff --git a/source/text/shared/01/05020500.xhp 
b/source/text/shared/01/05020500.xhp
index ea08a9342..b35392e0d 100644
--- a/source/text/shared/01/05020500.xhp
+++ b/source/text/shared/01/05020500.xhp
@@ -110,7 +110,7 @@
 Automatically adjust the character 
spacing for specific letter combinations.
 Kerning is 
only available for certain font types and requires that your printer support 
this option.
 
-
+
 
 
 
diff --git a/source/text/shared/01/0503.xhp 
b/source/text/shared/01/0503.xhp
index 72301a378..2bef61a97 100644
--- a/source/text/shared/01/0503.xhp
+++ b/source/text/shared/01/0503.xhp
@@ -5

[Libreoffice-commits] core.git: helpcontent2

2020-08-12 Thread Olivier Hallot (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cd3675f05080ec0ba697482be62289b767ab04c9
Author: Olivier Hallot 
AuthorDate: Wed Aug 12 17:32:17 2020 -0300
Commit: Gerrit Code Review 
CommitDate: Wed Aug 12 22:32:17 2020 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 49af25239f655a8d87dbe28bf5ed75040ca6bc11
  - Reposition query design help page

Change-Id: I5bf19c20cbac1b764aec972fa756586438279cc0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/100629
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 297a0c90cb07..49af25239f65 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 297a0c90cb07b299bf89bc031b770c3c49ee96a6
+Subproject commit 49af25239f655a8d87dbe28bf5ed75040ca6bc11
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: AllLangHelp_sdatabase.mk AllLangHelp_shared.mk source/text

2020-08-12 Thread Olivier Hallot (via logerrit)

 AllLangHelp_sdatabase.mk  |1 
 AllLangHelp_shared.mk |1 
 source/text/sdatabase/0200.xhp|8 -
 source/text/sdatabase/0202.xhp|4 
 source/text/sdatabase/02010100.xhp|  100 +++---
 source/text/shared/02/01170203.xhp|2 
 source/text/shared/02/1403.xhp|2 
 source/text/shared/02/1404.xhp|2 
 source/text/shared/02/1405.xhp|2 
 source/text/shared/02/1406.xhp|2 
 source/text/shared/02/1407.xhp|2 
 source/text/shared/02/limit.xhp   |2 
 source/text/shared/explorer/database/0502.xhp |2 
 source/text/shared/explorer/database/1108.xhp |2 
 source/text/shared/guide/data_enter_sql.xhp   |2 
 source/text/shared/guide/data_queries.xhp |2 
 source/text/shared/guide/data_search2.xhp |2 
 source/text/shared/guide/data_tables.xhp  |2 
 18 files changed, 70 insertions(+), 70 deletions(-)

New commits:
commit 49af25239f655a8d87dbe28bf5ed75040ca6bc11
Author: Olivier Hallot 
AuthorDate: Wed Aug 12 17:15:17 2020 -0300
Commit: Olivier Hallot 
CommitDate: Wed Aug 12 22:32:17 2020 +0200

Reposition query design help page

Change-Id: I5bf19c20cbac1b764aec972fa756586438279cc0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/100629
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/AllLangHelp_sdatabase.mk b/AllLangHelp_sdatabase.mk
index 4065e5c30..bca681984 100644
--- a/AllLangHelp_sdatabase.mk
+++ b/AllLangHelp_sdatabase.mk
@@ -19,6 +19,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,sdatabase,\
 helpcontent2/source/text/sdatabase/main \
 helpcontent2/source/text/sdatabase/0200 \
 helpcontent2/source/text/sdatabase/0202 \
+helpcontent2/source/text/sdatabase/02010100 \
 helpcontent2/source/text/sdatabase/toolbars \
 ))
 
diff --git a/AllLangHelp_shared.mk b/AllLangHelp_shared.mk
index b3e7f75f8..92c720da5 100644
--- a/AllLangHelp_shared.mk
+++ b/AllLangHelp_shared.mk
@@ -856,7 +856,6 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,shared,\
 ))
 
 $(eval $(call gb_AllLangHelp_add_helpfiles,shared,\
-helpcontent2/source/text/shared/explorer/database/02010100 \
 helpcontent2/source/text/shared/explorer/database/02010101 \
 helpcontent2/source/text/shared/explorer/database/0400 \
 helpcontent2/source/text/shared/explorer/database/0403 \
diff --git a/source/text/sdatabase/0200.xhp 
b/source/text/sdatabase/0200.xhp
index e3fa83b2e..265121e3b 100644
--- a/source/text/sdatabase/0200.xhp
+++ b/source/text/sdatabase/0200.xhp
@@ -59,14 +59,14 @@
 You can also open the data source view 
(Ctrl+Shift+F4), select the entire database table in the data source view 
(click on the top left corner of the table), and then drag the selection to a 
text document or spreadsheet.
 Sorting and Filtering Data
 Allows you to 
sort and filter the data in a query table.
-Query Design
+Query Design
 With the 
Query Design, you can create and edit a query or view.
 
-Query Through Several Tables
+Query Through Several Tables
 The query 
result can contain data from several tables if these are linked to each other 
by suitable data fields.
-Formulating Query Criteria
+Formulating Query Criteria
 You can find 
out which operators and commands can be used to formulate the filter conditions 
for a query.
-Executing Functions
+Executing Functions
 You can 
perform calculations with the data of a table and store the results as a query 
result.
 
 
diff --git a/source/text/sdatabase/0202.xhp 
b/source/text/sdatabase/0202.xhp
index 5181290fb..99024ab9a 100644
--- a/source/text/sdatabase/0202.xhp
+++ b/source/text/sdatabase/0202.xhp
@@ -33,10 +33,10 @@
 How to continue?
 There are 
three options available for answering this question:
 Do you really want to open the query in the graphic 
view?
-Allows you to open the query in the Design 
View in spite of missing elements. This option also allows you 
to specify if other errors need to be ignored.
+Allows you to open the query in the Design View in 
spite of missing elements. This option also allows you to specify if 
other errors need to be ignored.
 The query is 
opened in the Design View (the graphical interface). Missing tables appear 
blank and invalid fields appear with their (invalid) names in the list of 
fields. This lets you work with exactly those fields that caused the 
error.
 Open the query in the SQL View
-Allows you to open the query design in the SQL 
Mode and to interpret the query as a Native SQL. 
You can only quit the native SQL mode when the $[officename] statement is 
completely interpreted (only possible if the used tables or fields in the query 
really exist).
+Allows you to open the query design in the SQL Mode and to 
in

[Libreoffice-commits] core.git: sfx2/source

2020-08-12 Thread Noel Grandin (via logerrit)

 sfx2/source/control/bindings.cxx |5 -
 sfx2/source/control/statcach.cxx |5 -
 2 files changed, 8 insertions(+), 2 deletions(-)

New commits:
commit 0a8ce55f715156d72d38b4416ada33cd0d9b237f
Author: Noel Grandin 
AuthorDate: Wed Aug 12 13:24:36 2020 +0200
Commit: Noel Grandin 
CommitDate: Wed Aug 12 22:27:16 2020 +0200

expand out DELETEZ

Change-Id: I5460de0f54a0d7c1a18ce8f1fa33ef3405d8183c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100622
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sfx2/source/control/bindings.cxx b/sfx2/source/control/bindings.cxx
index 94b9fea11e4b..ce4d3a4230d4 100644
--- a/sfx2/source/control/bindings.cxx
+++ b/sfx2/source/control/bindings.cxx
@@ -1591,7 +1591,10 @@ SfxItemState SfxBindings::QueryState( sal_uInt16 nSlot, 
std::unique_ptrRelease();
 xBind.clear();
 if ( bDeleteCache )
-DELETEZ( pCache );
+{
+delete pCache;
+pCache = nullptr;
+}
 return eState;
 }
 }
diff --git a/sfx2/source/control/statcach.cxx b/sfx2/source/control/statcach.cxx
index dfdc10f83687..b71b96a62579 100644
--- a/sfx2/source/control/statcach.cxx
+++ b/sfx2/source/control/statcach.cxx
@@ -428,7 +428,10 @@ void SfxStateCache::SetState_Impl
 
 // Remember new value
 if ( !IsInvalidItem(pLastItem) )
-DELETEZ(pLastItem);
+{
+delete pLastItem;
+pLastItem = nullptr;
+}
 if ( pState && !IsInvalidItem(pState) )
 pLastItem = pState->Clone();
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: editeng/source reportdesign/source sot/source svl/source svtools/source

2020-08-12 Thread Noel Grandin (via logerrit)

 editeng/source/items/numitem.cxx   |6 --
 reportdesign/source/ui/report/StartMarker.cxx  |6 --
 sot/source/sdstor/storage.cxx  |8 ++--
 svl/source/items/itempool.cxx  |6 --
 svtools/source/brwbox/ebbcontrols.cxx  |2 +-
 svtools/source/config/accessibilityoptions.cxx |3 ++-
 6 files changed, 21 insertions(+), 10 deletions(-)

New commits:
commit d4df251320ba266ff3fe3da9e3b991c18ea50f5c
Author: Noel Grandin 
AuthorDate: Wed Aug 12 11:15:51 2020 +0200
Commit: Noel Grandin 
CommitDate: Wed Aug 12 22:04:55 2020 +0200

expand out DELETEZ

Change-Id: Ia69fb105c6cc661ac94a360d47655b3faa9d6bb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100618
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/editeng/source/items/numitem.cxx b/editeng/source/items/numitem.cxx
index 91a6cee1f7a2..bc10590f460f 100644
--- a/editeng/source/items/numitem.cxx
+++ b/editeng/source/items/numitem.cxx
@@ -726,8 +726,10 @@ SvxNumRule::~SvxNumRule()
 {
 if(!--nRefCount)
 {
-DELETEZ(pStdNumFmt);
-DELETEZ(pStdOutlineNumFmt);
+delete pStdNumFmt;
+pStdNumFmt = nullptr;
+delete pStdOutlineNumFmt;
+pStdOutlineNumFmt = nullptr;
 }
 }
 
diff --git a/reportdesign/source/ui/report/StartMarker.cxx 
b/reportdesign/source/ui/report/StartMarker.cxx
index 2d9eda114000..09a118f41a97 100644
--- a/reportdesign/source/ui/report/StartMarker.cxx
+++ b/reportdesign/source/ui/report/StartMarker.cxx
@@ -85,8 +85,10 @@ void OStartMarker::dispose()
 {
 if ( osl_atomic_decrement(&s_nImageRefCount) == 0 )
 {
-DELETEZ(s_pDefCollapsed);
-DELETEZ(s_pDefExpanded);
+delete s_pDefCollapsed;
+s_pDefCollapsed = nullptr;
+delete s_pDefExpanded;
+s_pDefExpanded = nullptr;
 }
 m_aVRuler.disposeAndClear();
 m_aText.disposeAndClear();
diff --git a/sot/source/sdstor/storage.cxx b/sot/source/sdstor/storage.cxx
index f15fb22dd9f1..56ffb92dc108 100644
--- a/sot/source/sdstor/storage.cxx
+++ b/sot/source/sdstor/storage.cxx
@@ -306,7 +306,10 @@ void SotStorage::CreateStorage( bool bForceUCBStorage, 
StreamMode nMode )
 // check the stream
 m_pStorStm = ::utl::UcbStreamHelper::CreateStream( m_aName, nMode 
).release();
 if ( m_pStorStm && m_pStorStm->GetError() )
-DELETEZ( m_pStorStm );
+{
+delete m_pStorStm;
+m_pStorStm = nullptr;
+}
 
 if ( m_pStorStm )
 {
@@ -319,7 +322,8 @@ void SotStorage::CreateStorage( bool bForceUCBStorage, 
StreamMode nMode )
 if ( bIsUCBStorage )
 {
 // UCBStorage always works directly on the UCB content, so 
discard the stream first
-DELETEZ( m_pStorStm );
+delete m_pStorStm;
+m_pStorStm = nullptr;
 m_pOwnStg = new UCBStorage( m_aName, nMode, true, 
true/*bIsRoot*/ );
 }
 else
diff --git a/svl/source/items/itempool.cxx b/svl/source/items/itempool.cxx
index 82668c909a35..6deec84947c0 100644
--- a/svl/source/items/itempool.cxx
+++ b/svl/source/items/itempool.cxx
@@ -542,7 +542,8 @@ void SfxItemPool::SetPoolDefaultItem(const SfxPoolItem 
&rItem)
 if (rOldDefault)
 {
 rOldDefault->SetRefCount(0);
-DELETEZ(rOldDefault);
+delete rOldDefault;
+rOldDefault = nullptr;
 }
 rOldDefault = pNewDefault;
 }
@@ -567,7 +568,8 @@ void SfxItemPool::ResetPoolDefaultItem( sal_uInt16 nWhichId 
)
 if (rOldDefault)
 {
 rOldDefault->SetRefCount(0);
-DELETEZ(rOldDefault);
+delete rOldDefault;
+rOldDefault = nullptr;
 }
 }
 else if ( pImpl->mpSecondary )
diff --git a/svtools/source/brwbox/ebbcontrols.cxx 
b/svtools/source/brwbox/ebbcontrols.cxx
index b15927af9e58..1ac4605a3096 100644
--- a/svtools/source/brwbox/ebbcontrols.cxx
+++ b/svtools/source/brwbox/ebbcontrols.cxx
@@ -525,7 +525,7 @@ namespace svt
 EditCellController::~EditCellController( )
 {
 if ( m_bOwnImplementation )
-DELETEZ( m_pEditImplementation );
+delete m_pEditImplementation;
 }
 
 void EditCellController::SaveValue()
diff --git a/svtools/source/config/accessibilityoptions.cxx 
b/svtools/source/config/accessibilityoptions.cxx
index 43fa4287f9e0..2790296c424d 100644
--- a/svtools/source/config/accessibilityoptions.cxx
+++ b/svtools/source/config/accessibilityoptions.cxx
@@ -379,7 +379,8 @@ SvtAccessibilityOptions::~SvtAccessibilityOptions()
 {
 //if( sm_pSingleImplConfig->IsModified() )
 //  sm_pSingleImplConfig->Commit();
-DELETEZ( sm_pSingleImplConfig );
+delete sm_pSingleImplConfig;
+sm_pSingleImplConfig = nullptr;
 }
 }
 
___
Libreoffice-c

[Libreoffice-commits] core.git: bridges/Library_cpp_uno.mk

2020-08-12 Thread Stephan Bergmann (via logerrit)

 bridges/Library_cpp_uno.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 2cb40c77cd05c1cb5a85468ff9801051829871e4
Author: Stephan Bergmann 
AuthorDate: Wed Aug 12 18:42:48 2020 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Aug 12 21:11:26 2020 +0200

Let exceptions pass through aarch64 callVirtualFunction built with Clang

At least with Clang 12 trunk on Linux, CustomTarget_testtools/uno_test 
aborted
with

libc++abi: terminating with uncaught exception of type 
com::sun::star::uno::RuntimeException

at

> #0  0xad97e598 in raise () from /lib64/libc.so.6
> #1  0xad96ada0 in abort () from /lib64/libc.so.6
> #2  0xadbf704c in abort_message 
(format=format@entry=0xadbfa398 "terminating with %s exception of type %s") 
at /llvm/llvm-project/libcxxabi/src/abort_message.cpp:78
> #3  0xadbe50ec in demangling_terminate_handler () at 
/llvm/llvm-project/libcxxabi/src/cxa_default_handlers.cpp:67
> #4  0xadbf633c in std::__terminate (func=) at 
/llvm/llvm-project/libcxxabi/src/cxa_handlers.cpp:59
> #5  0xadbf92ac in __cxxabiv1::failed_throw 
(exception_header=0x361b5970) at 
/llvm/llvm-project/libcxxabi/src/cxa_exception.cpp:152
> #6  __cxxabiv1::__cxa_throw (thrown_object=0x361b59f0, tinfo=0x43f5a0 
, dest=0xa0575b84 
) at 
/llvm/llvm-project/libcxxabi/src/cxa_exception.cpp:283
> #7  0xa056944c in bridge_object::(anonymous 
namespace)::Test_Impl::getRaiseAttr1 (this=0x361810c0) at 
testtools/source/bridgetest/cppobj.cxx:296
> #8  0xa0644b70 in callVirtualFunction (function=281473371790408, 
gpr=0xcc4c1b68, fpr=0xcc4c1b28, stack=0xcc4c18d0, sp=0, 
ret=0xcc4c1cf0) at 
bridges/source/cpp_uno/gcc3_linux_aarch64/callvirtualfunction.cxx:38
> #9  0xa064c5b4 in (anonymous namespace)::call (proxy=0x36193710, 
slot=..., returnType=0x3615b380, count=0, parameters=0x0, 
returnValue=0xcc4c1cf0, arguments=0xcc4c1cf0, exception=0xcc4c1e78) 
at bridges/source/cpp_uno/gcc3_linux_aarch64/uno2cpp.cxx:176
> #10 0xa064bd58 in 
bridges::cpp_uno::shared::unoInterfaceProxyDispatch (pUnoI=0x36193710, 
pMemberDescr=0x361a5b70, pReturn=0xcc4c1cf0, pArgs=0xcc4c1cf0, 
ppException=0xcc4c1e78) at 
bridges/source/cpp_uno/gcc3_linux_aarch64/uno2cpp.cxx:328
> #11 0xa064b174 in (anonymous namespace)::call (proxy=0x361a9280, 
description=..., returnType=0x3615b380, count=0, parameters=0x0, 
gpr=0xcc4c2070, fpr=0xcc4c20b0, stack=0xcc4c20f0, 
indirectRet=0x361a92a8) at 
bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx:120
> #12 0xa064a900 in vtableCall (functionIndex=37, vtableOffset=0, 
gpr=0xcc4c2070, fpr=0xcc4c20b0, stack=0xcc4c20f0, 
indirectRet=0x361a92a8) at 
bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx:240
> #13 0xa065c1cc in vtableSlotCall () from 
instdir/program/libgcc3_uno.so
> #14 0xa05f9ce0 in bridge_test::performTest 
(xContext=uno::Reference to (cppu::(anonymous namespace)::ComponentContext *) 
0x3616eac0, xLBT=uno::Reference to (com::sun::star::uno::XInterface *) 
0x361a92a8, noCurrentContext=false) at 
testtools/source/bridgetest/bridgetest.cxx:527
> #15 0xa05f7400 in bridge_test::(anonymous 
namespace)::TestBridgeImpl::run (this=0x361806e0, rArgs=uno::Sequence of length 
1 = {...}) at testtools/source/bridgetest/bridgetest.cxx:1168
> #16 0x004050c0 in sal_main () at 
cpputools/source/unoexe/unoexe.cxx:517
> #17 0x004040cc in main (argc=8, argv=0xcc4c4458) at 
cpputools/source/unoexe/unoexe.cxx:357

The reason is that _Unwind_RaiseException (in libgcc_s.so.1) called from
__cxa_throw (in libc++abi.so.1) for some reason does not find unwind 
information
for the callVirtualFunction frame #8, so returns _URC_FATAL_PHASE2_ERROR.  
This
looks similar to the issue discussed in the comment at the top of
bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx introduced 
with
0fdbb5b0eabbaa571f3747fda12a56c938cba474 "Make cpp_uno/gcc3_linux_x86-64 
bridge
work with GCC 4.7".  Though what happens to fix it here appears to be
-fasynchronous-unwind-tables.  (The -fnon-call-exceptions mentioned in that
comment appears to be ignored by Clang.)

The actual difference that -fasynchronous-unwind-tables makes in the 
generated
callvirtualfunction.s is that it drops a single line

>  .Lfunc_begin0:
>   .file   7 "" 
"bridges/source/cpp_uno/gcc3_linux_aarch64/callvirtualfunction.cxx"
>   .loc7 32 0  // 
bridges/source/cpp_uno/gcc3_linux_aarch64/callvirtualfunction.cxx:32:0
> - .cfi_sections .debug_frame
>   .cfi_startproc
>  // %bb.0:
>   stp d15, d14, [sp, #-128]!  // 16-byte Folded Spill

Change-Id: Ib60e9f4958c6041b10ca959a0953e998ac6f141a

[Libreoffice-commits] core.git: vcl/workben

2020-08-12 Thread Caolán McNamara (via logerrit)

 vcl/workben/cgmfuzzer.cxx |   14 --
 vcl/workben/pptfuzzer.cxx |   14 --
 vcl/workben/ww2fuzzer.cxx |   14 --
 vcl/workben/ww6fuzzer.cxx |   14 --
 vcl/workben/ww8fuzzer.cxx |   14 --
 5 files changed, 60 insertions(+), 10 deletions(-)

New commits:
commit bb098efaded60118aa25ccd23083955041ba9cea
Author: Caolán McNamara 
AuthorDate: Wed Aug 12 19:52:51 2020 +0100
Commit: Caolán McNamara 
CommitDate: Wed Aug 12 20:53:43 2020 +0200

ucb_component_getFactory no longer exists

Change-Id: I9c937d5fa0e235de114d8f3962eba0ba3bcb33ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100626
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/vcl/workben/cgmfuzzer.cxx b/vcl/workben/cgmfuzzer.cxx
index 0984b70c2233..7d36f2acc7a0 100644
--- a/vcl/workben/cgmfuzzer.cxx
+++ b/vcl/workben/cgmfuzzer.cxx
@@ -16,7 +16,6 @@
 
 extern "C" {
 void * i18npool_component_getFactory( const char* , void* , void* );
-void * ucb_component_getFactory( const char* , void* , void* );
 
 void * com_sun_star_i18n_LocaleDataImpl_get_implementation( void *, void * );
 void * com_sun_star_i18n_BreakIterator_Unicode_get_implementation( void *, 
void * );
@@ -69,6 +68,12 @@ void * 
com_sun_star_comp_draw_SdHtmlOptionsDialog_get_implementation( void *, vo
 void * com_sun_star_comp_sd_InsertSlideController_get_implementation( void *, 
void * );
 void * com_sun_star_comp_sd_SlideLayoutController_get_implementation( void *, 
void * );
 void * com_sun_star_comp_sd_DisplayModeController_get_implementation( void *, 
void * );
+void * ucb_UcbCommandEnvironment_get_implementation( void *, void * );
+void * ucb_UcbContentProviderProxyFactory_get_implementation( void *, void * );
+void * ucb_UcbPropertiesManager_get_implementation( void *, void * );
+void * ucb_UcbStore_get_implementation( void *, void * );
+void * ucb_UniversalContentBroker_get_implementation( void *, void * );
+void * ucb_OFileAccess_get_implementation( void *, void * );
 }
 
 const lib_to_factory_mapping *
@@ -76,7 +81,6 @@ lo_get_factory_map(void)
 {
 static lib_to_factory_mapping map[] = {
 { "libi18npoollo.a", i18npool_component_getFactory },
-{ "libucb1.a", ucb_component_getFactory },
 { 0, 0 }
 };
 
@@ -138,6 +142,12 @@ lo_get_constructor_map(void)
 { "com_sun_star_comp_sd_InsertSlideController_get_implementation", 
com_sun_star_comp_sd_InsertSlideController_get_implementation },
 { "com_sun_star_comp_sd_SlideLayoutController_get_implementation", 
com_sun_star_comp_sd_SlideLayoutController_get_implementation },
 { "com_sun_star_comp_sd_DisplayModeController_get_implementation", 
com_sun_star_comp_sd_DisplayModeController_get_implementation },
+{ "ucb_UcbCommandEnvironment_get_implementation", 
ucb_UcbCommandEnvironment_get_implementation, },
+{ "ucb_UcbContentProviderProxyFactory_get_implementation", 
ucb_UcbContentProviderProxyFactory_get_implementation },
+{ "ucb_UcbPropertiesManager_get_implementation", 
ucb_UcbPropertiesManager_get_implementation },
+{ "ucb_UcbStore_get_implementation", ucb_UcbStore_get_implementation },
+{ "ucb_UniversalContentBroker_get_implementation", 
ucb_UniversalContentBroker_get_implementation },
+{ "ucb_OFileAccess_get_implementation", 
ucb_OFileAccess_get_implementation },
 { 0, 0 }
 };
 
diff --git a/vcl/workben/pptfuzzer.cxx b/vcl/workben/pptfuzzer.cxx
index 2911475c1c15..77fe063cb18a 100644
--- a/vcl/workben/pptfuzzer.cxx
+++ b/vcl/workben/pptfuzzer.cxx
@@ -16,7 +16,6 @@
 
 extern "C" {
 void * i18npool_component_getFactory( const char* , void* , void* );
-void * ucb_component_getFactory( const char* , void* , void* );
 
 void * com_sun_star_i18n_LocaleDataImpl_get_implementation( void *, void * );
 void * com_sun_star_i18n_BreakIterator_Unicode_get_implementation( void *, 
void * );
@@ -49,6 +48,12 @@ void * i18npool_Calendar_gregorian_get_implementation( void 
*, void * );
 void * unoxml_CXPathAPI_get_implementation( void *, void * );
 void * unoxml_CDocumentBuilder_get_implementation( void *, void * );
 void * sd_PresentationDocument_get_implementation( void *, void * );
+void * ucb_UcbCommandEnvironment_get_implementation( void *, void * );
+void * ucb_UcbContentProviderProxyFactory_get_implementation( void *, void * );
+void * ucb_UcbPropertiesManager_get_implementation( void *, void * );
+void * ucb_UcbStore_get_implementation( void *, void * );
+void * ucb_UniversalContentBroker_get_implementation( void *, void * );
+void * ucb_OFileAccess_get_implementation( void *, void * );
 }
 
 const lib_to_factory_mapping *
@@ -56,7 +61,6 @@ lo_get_factory_map(void)
 {
 static lib_to_factory_mapping map[] = {
 { "libi18npoollo.a", i18npool_component_getFactory },
-{ "libucb1.a", ucb_component_getFactory },
 { 0, 0 }
 };
 
@@ -98,6 +102,12 @@ lo_get_constructor_map(void)
 { "unoxml_CXP

[Libreoffice-commits] core.git: wizards/com

2020-08-12 Thread Mike Kaganski (via logerrit)

 wizards/com/sun/star/wizards/agenda/AgendaWizardDialogResources.py |   12 
--
 wizards/com/sun/star/wizards/common/NoValidPathException.py|   12 
--
 wizards/com/sun/star/wizards/fax/FaxWizardDialogResources.py   |   12 
--
 wizards/com/sun/star/wizards/letter/LetterWizardDialogResources.py |   12 
--
 wizards/com/sun/star/wizards/ui/WizardDialog.py|   12 
--
 5 files changed, 50 insertions(+), 10 deletions(-)

New commits:
commit 4cdd446b090e3b04cd36d9bd992ca020381c039e
Author: Mike Kaganski 
AuthorDate: Wed Aug 12 17:52:35 2020 +0200
Commit: Mike Kaganski 
CommitDate: Wed Aug 12 20:45:09 2020 +0200

imp is deprecated since Python v.3.4

This avoid Python warnings about this during checks

Change-Id: I6647d9c93f3c2fbc1af475f8bc45e03300ee8b79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100518
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/wizards/com/sun/star/wizards/agenda/AgendaWizardDialogResources.py 
b/wizards/com/sun/star/wizards/agenda/AgendaWizardDialogResources.py
index b1d53de6b4f6..15631123fbcb 100644
--- a/wizards/com/sun/star/wizards/agenda/AgendaWizardDialogResources.py
+++ b/wizards/com/sun/star/wizards/agenda/AgendaWizardDialogResources.py
@@ -24,8 +24,16 @@ class AgendaWizardDialogResources(object):
 SECTION_MINUTES = "MINUTES"
 
 def __init__(self):
-import imp, os
-imp.load_source('strings', os.path.join(os.path.dirname(__file__), 
'../common/strings.hrc'))
+import sys, os
+
+# imp is deprecated since Python v.3.4
+if sys.version_info >= (3,3):
+from importlib.machinery import SourceFileLoader
+SourceFileLoader('strings', 
os.path.join(os.path.dirname(__file__), '../common/strings.hrc')).load_module()
+else:
+import imp
+imp.load_source('strings', os.path.join(os.path.dirname(__file__), 
'../common/strings.hrc'))
+
 import strings
 
 self.resAgendaWizardDialog_title = 
strings.RID_AGENDAWIZARDDIALOG_START_1
diff --git a/wizards/com/sun/star/wizards/common/NoValidPathException.py 
b/wizards/com/sun/star/wizards/common/NoValidPathException.py
index 07794852710f..54fb58613c09 100644
--- a/wizards/com/sun/star/wizards/common/NoValidPathException.py
+++ b/wizards/com/sun/star/wizards/common/NoValidPathException.py
@@ -22,8 +22,16 @@ class NoValidPathException(Exception):
 # TODO: NEVER open a dialog in an exception
 from .SystemDialog import SystemDialog
 if xMSF:
-import imp, os
-imp.load_source('strings', os.path.join(os.path.dirname(__file__), 
'../common/strings.hrc'))
+import sys, os
+
+# imp is deprecated since Python v.3.4
+if sys.version_info >= (3,3):
+from importlib.machinery import SourceFileLoader
+SourceFileLoader('strings', 
os.path.join(os.path.dirname(__file__), '../common/strings.hrc')).load_module()
+else:
+import imp
+imp.load_source('strings', 
os.path.join(os.path.dirname(__file__), '../common/strings.hrc'))
+
 import strings
 SystemDialog.showErrorBox(xMSF, strings.RID_COMMON_START_21) 
#OfficePathnotavailable
 
diff --git a/wizards/com/sun/star/wizards/fax/FaxWizardDialogResources.py 
b/wizards/com/sun/star/wizards/fax/FaxWizardDialogResources.py
index 6ee89bf9b680..a5bd469df80f 100644
--- a/wizards/com/sun/star/wizards/fax/FaxWizardDialogResources.py
+++ b/wizards/com/sun/star/wizards/fax/FaxWizardDialogResources.py
@@ -19,8 +19,16 @@
 class FaxWizardDialogResources(object):
 
 def __init__(self):
-import imp, os
-imp.load_source('strings', os.path.join(os.path.dirname(__file__), 
'../common/strings.hrc'))
+import sys, os
+
+# imp is deprecated since Python v.3.4
+if sys.version_info >= (3,3):
+from importlib.machinery import SourceFileLoader
+SourceFileLoader('strings', 
os.path.join(os.path.dirname(__file__), '../common/strings.hrc')).load_module()
+else:
+import imp
+imp.load_source('strings', os.path.join(os.path.dirname(__file__), 
'../common/strings.hrc'))
+
 import strings
 
 self.resFaxWizardDialog_title = strings.RID_FAXWIZARDDIALOG_START_1
diff --git a/wizards/com/sun/star/wizards/letter/LetterWizardDialogResources.py 
b/wizards/com/sun/star/wizards/letter/LetterWizardDialogResources.py
index 34a82cfd552b..19ef40c4a576 100644
--- a/wizards/com/sun/star/wizards/letter/LetterWizardDialogResources.py
+++ b/wizards/com/sun/star/wizards/letter/LetterWizardDialogResources.py
@@ -19,8 +19,16 @@
 class LetterWizardDialogResources(object):
 
 def __init__(self):
-import imp, os
-imp.load_source('strings', os.path.join(os.path.dirname(__file__), 
'../common/strings.hrc'))
+import sys, os
+
+

[Libreoffice-commits] core.git: dbaccess/Library_dbu.mk dbaccess/source solenv/clang-format

2020-08-12 Thread Caolán McNamara (via logerrit)

 dbaccess/Library_dbu.mk   |1 
 dbaccess/source/ui/browser/brwview.cxx|7 -
 dbaccess/source/ui/browser/dbtreeview.cxx |   79 
 dbaccess/source/ui/browser/dbtreeview.hxx |   62 -
 dbaccess/source/ui/browser/dsEntriesNoExp.cxx |   13 +-
 dbaccess/source/ui/browser/dsbrowserDnD.cxx   |   15 +--
 dbaccess/source/ui/browser/unodatbr.cxx   |  123 +-
 dbaccess/source/ui/inc/brwview.hxx|8 -
 dbaccess/source/ui/inc/unodatbr.hxx   |2 
 solenv/clang-format/excludelist   |2 
 10 files changed, 83 insertions(+), 229 deletions(-)

New commits:
commit 3c0193c43bd6ff88032c7b39c4393b9384fa88bf
Author: Caolán McNamara 
AuthorDate: Wed Aug 12 16:14:17 2020 +0100
Commit: Caolán McNamara 
CommitDate: Wed Aug 12 20:24:37 2020 +0200

remove DBTreeView class which doesn't do anything useful

Change-Id: I9270f8f87149a395f47a5b4599d6eac4b07103c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100607
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/dbaccess/Library_dbu.mk b/dbaccess/Library_dbu.mk
index 1a3630727860..07da91b74f4f 100644
--- a/dbaccess/Library_dbu.mk
+++ b/dbaccess/Library_dbu.mk
@@ -86,7 +86,6 @@ $(eval $(call gb_Library_add_exception_objects,dbu,\
 dbaccess/source/ui/browser/dbexchange \
 dbaccess/source/ui/browser/dbloader \
 dbaccess/source/ui/browser/dbtreemodel \
-dbaccess/source/ui/browser/dbtreeview \
 dbaccess/source/ui/browser/dsbrowserDnD \
 dbaccess/source/ui/browser/dsEntriesNoExp \
 dbaccess/source/ui/browser/exsrcbrw \
diff --git a/dbaccess/source/ui/browser/brwview.cxx 
b/dbaccess/source/ui/browser/brwview.cxx
index 01b17fd7c544..de1f9220100f 100644
--- a/dbaccess/source/ui/browser/brwview.cxx
+++ b/dbaccess/source/ui/browser/brwview.cxx
@@ -23,7 +23,6 @@
 #include 
 #include 
 #include 
-#include "dbtreeview.hxx"
 #include 
 #include 
 #include 
@@ -153,12 +152,12 @@ void UnoDataBrowserView::setSplitter(Splitter* _pSplitter)
 LINK( this, UnoDataBrowserView, SplitHdl ).Call(m_pSplitter);
 }
 
-void UnoDataBrowserView::setTreeView(DBTreeView* _pTreeView)
+void UnoDataBrowserView::setTreeView(InterimDBTreeListBox* pTreeView)
 {
-if (m_pTreeView.get() != _pTreeView)
+if (m_pTreeView.get() != pTreeView)
 {
 m_pTreeView.disposeAndClear();
-m_pTreeView = _pTreeView;
+m_pTreeView = pTreeView;
 }
 }
 
diff --git a/dbaccess/source/ui/browser/dbtreeview.cxx 
b/dbaccess/source/ui/browser/dbtreeview.cxx
deleted file mode 100644
index 38e6846cc811..
--- a/dbaccess/source/ui/browser/dbtreeview.cxx
+++ /dev/null
@@ -1,79 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#include "dbtreeview.hxx"
-#include 
-#include 
-
-namespace dbaui
-{
-
-using namespace ::com::sun::star::uno;
-using namespace ::com::sun::star::lang;
-
-DBTreeView::DBTreeView( vcl::Window* pParent, WinBits nBits)
-: Window(pParent, nBits)
-, m_pTreeListBox(VclPtr::Create(this))
-{
-m_pTreeListBox->SetHelpId(HID_TLB_TREELISTBOX);
-m_pTreeListBox->Show();
-}
-
-DBTreeView::~DBTreeView()
-{
-disposeOnce();
-}
-
-void DBTreeView::dispose()
-{
-m_pTreeListBox.disposeAndClear();
-vcl::Window::dispose();
-}
-
-void DBTreeView::SetPreExpandHandler(const Link& 
rHdl)
-{
-m_pTreeListBox->GetWidget().connect_expanding(rHdl);
-}
-
-voidDBTreeView::setCopyHandler(const Link& _rHdl)
-{
-m_pTreeListBox->setCopyHandler(_rHdl);
-}
-
-void DBTreeView::Resize()
-{
-Window::Resize();
-m_pTreeListBox->SetPosSizePixel(Point(0,0),GetOutputSizePixel());
-}
-
-void DBTreeView::setSelChangeHdl( const Link& _rHdl )
-{
-m_pTreeListBox->SetSelChangeHdl( _rHdl );
-}
-
-void DBTreeView::GetFocus()
-{
-Window::GetFocus();
-if ( m_pTreeListBox )//&& !m_pTreeListBox->HasChildPathFocus())
-m_pTreeListBox->GrabFocus();
-}
-
-}   // namespace dbaui
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/dbaccess/source/ui/browser/dbtreeview.hxx 
b/dbaccess/source/ui/brows

[Libreoffice-commits] core.git: include/vcl vcl/unx

2020-08-12 Thread Caolán McNamara (via logerrit)

 include/vcl/weld.hxx |6 +-
 vcl/unx/gtk3/gtk3gtkinst.cxx |2 ++
 2 files changed, 7 insertions(+), 1 deletion(-)

New commits:
commit 7956d0593cec116d05ca205dab8c7ae1646b6db0
Author: Caolán McNamara 
AuthorDate: Wed Aug 12 15:59:40 2020 +0100
Commit: Caolán McNamara 
CommitDate: Wed Aug 12 20:24:10 2020 +0200

tdf#135640 ensure parent rows are expanded on scolling to make a row visible

Change-Id: I37e55ed8d0d3d5916950228ba78982b90356fbc2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100606
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index 4707d3905176..b2080c671874 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -939,7 +939,9 @@ public:
 virtual void swap(int pos1, int pos2) = 0;
 virtual std::vector get_selected_rows() const = 0;
 virtual void set_font_color(int pos, const Color& rColor) = 0;
-virtual void scroll_to_row(int pos) = 0;
+// scroll to make 'row' visible, this will also expand all parent rows of 
'row' as necessary to
+// make 'row' visible
+virtual void scroll_to_row(int row) = 0;
 virtual bool is_selected(int pos) const = 0;
 virtual int get_cursor_index() const = 0;
 virtual void set_cursor(int pos) = 0;
@@ -1043,6 +1045,8 @@ public:
const css::uno::Reference& 
rImage, int col = -1)
 = 0;
 virtual void set_font_color(const TreeIter& rIter, const Color& rColor) = 
0;
+// scroll to make rIter visible, this will also expand all parent rows of 
rIter as necessary to
+// make rIter visible
 virtual void scroll_to_row(const TreeIter& rIter) = 0;
 virtual bool is_selected(const TreeIter& rIter) const = 0;
 
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 5b7ee9c17fb3..ade418e30d01 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -10452,6 +10452,7 @@ public:
 assert(gtk_tree_view_get_model(m_pTreeView) && "don't select when 
frozen, select after thaw. Note selection doesn't survive a freeze");
 disable_notify_events();
 GtkTreePath* path = gtk_tree_path_new_from_indices(pos, -1);
+gtk_tree_view_expand_to_path(m_pTreeView, path);
 gtk_tree_view_scroll_to_cell(m_pTreeView, path, nullptr, false, 0, 0);
 gtk_tree_path_free(path);
 enable_notify_events();
@@ -11158,6 +11159,7 @@ public:
 const GtkInstanceTreeIter& rGtkIter = static_cast(rIter);
 GtkTreeModel *pModel = GTK_TREE_MODEL(m_pTreeStore);
 GtkTreePath* path = gtk_tree_model_get_path(pModel, 
const_cast(&rGtkIter.iter));
+gtk_tree_view_expand_to_path(m_pTreeView, path);
 gtk_tree_view_scroll_to_cell(m_pTreeView, path, nullptr, false, 0, 0);
 gtk_tree_path_free(path);
 enable_notify_events();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: cui/source dbaccess/source sd/source sw/source

2020-08-12 Thread Caolán McNamara (via logerrit)

 cui/source/inc/optlingu.hxx |1 
 dbaccess/source/ui/app/AppController.cxx|   29 
 dbaccess/source/ui/app/AppController.hxx|4 ---
 dbaccess/source/ui/app/AppDetailView.hxx|7 --
 dbaccess/source/ui/app/AppView.hxx  |1 
 dbaccess/source/ui/browser/dsbrowserDnD.cxx |5 
 dbaccess/source/ui/browser/unodatbr.cxx |5 
 dbaccess/source/ui/inc/TableCopyHelper.hxx  |1 
 dbaccess/source/ui/inc/TableWindow.hxx  |2 -
 dbaccess/source/ui/inc/callbacks.hxx|3 --
 dbaccess/source/ui/inc/unodatbr.hxx |5 
 sd/source/ui/inc/sdtreelb.hxx   |1 
 sw/source/uibase/inc/optload.hxx|1 
 13 files changed, 65 deletions(-)

New commits:
commit 866855dcf8ee3c2afbdf081ad3161df3cce0be6c
Author: Caolán McNamara 
AuthorDate: Wed Aug 12 15:30:13 2020 +0100
Commit: Caolán McNamara 
CommitDate: Wed Aug 12 20:23:40 2020 +0200

cleanup some unused leftovers

Change-Id: I5971ec431471c528c33b2f3a3f2353a3a825f286
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100603
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/cui/source/inc/optlingu.hxx b/cui/source/inc/optlingu.hxx
index 5f64e47c2017..7b9ac01cd6d9 100644
--- a/cui/source/inc/optlingu.hxx
+++ b/cui/source/inc/optlingu.hxx
@@ -35,7 +35,6 @@ namespace com::sun::star{
 }
 }
 
-class SvTreeListEntry;
 class SvxLinguData_Impl;
 
 // define 
diff --git a/dbaccess/source/ui/app/AppController.cxx 
b/dbaccess/source/ui/app/AppController.cxx
index 8c097c6a2fb0..739f7a43be9d 100644
--- a/dbaccess/source/ui/app/AppController.cxx
+++ b/dbaccess/source/ui/app/AppController.cxx
@@ -2268,40 +2268,11 @@ Any OApplicationController::getCurrentSelection( 
Control& _rControl ) const
 return makeAny( aSelection );
 }
 
-bool OApplicationController::requestQuickHelp( const SvTreeListEntry* 
/*_pEntry*/, OUString& /*_rText*/ ) const
-{
-return false;
-}
-
 bool OApplicationController::requestQuickHelp(const void* /*pUserData*/, 
OUString& /*rText*/) const
 {
 return false;
 }
 
-bool OApplicationController::requestDrag(  const Point& /*_rPosPixel*/ )
-{
-rtl::Reference pTransfer;
-if ( getContainer() && getContainer()->getSelectionCount() )
-{
-try
-{
-pTransfer = copyObject( );
-
-if ( pTransfer && getContainer()->getDetailView() )
-{
-ElementType eType = getContainer()->getElementType();
-pTransfer->StartDrag( 
getContainer()->getDetailView()->getTreeWindow(), ((eType == E_FORM || eType == 
E_REPORT) ? DND_ACTION_COPYMOVE : DND_ACTION_COPY) );
-}
-}
-catch(const Exception& )
-{
-DBG_UNHANDLED_EXCEPTION("dbaccess");
-}
-}
-
-return pTransfer.is();
-}
-
 bool OApplicationController::requestDrag(const weld::TreeIter& /*rEntry*/)
 {
 rtl::Reference pTransfer;
diff --git a/dbaccess/source/ui/app/AppController.hxx 
b/dbaccess/source/ui/app/AppController.hxx
index 1abf501328fb..afd496068650 100644
--- a/dbaccess/source/ui/app/AppController.hxx
+++ b/dbaccess/source/ui/app/AppController.hxx
@@ -42,8 +42,6 @@
 
 #include 
 
-class SvTreeListEntry;
-class SvTreeListBox;
 class TransferableHelper;
 class TransferableClipboardListener;
 
@@ -486,9 +484,7 @@ namespace dbaui
 virtual boolisDataSourceReadOnly() const override;
 
 // IControlActionListener overridables
-virtual boolrequestQuickHelp( const SvTreeListEntry* _pEntry, 
OUString& _rText ) const override;
 virtual boolrequestQuickHelp(const void* pUserData, OUString& 
rText) const override;
-virtual boolrequestDrag( const Point& _rPosPixel ) override;
 virtual boolrequestDrag(const weld::TreeIter& rEntry) override;
 virtual sal_Int8queryDrop( const AcceptDropEvent& _rEvt, const 
DataFlavorExVector& _rFlavors ) override;
 virtual sal_Int8executeDrop( const ExecuteDropEvent& _rEvt ) 
override;
diff --git a/dbaccess/source/ui/app/AppDetailView.hxx 
b/dbaccess/source/ui/app/AppDetailView.hxx
index c551db1a3adc..5e4612b48abf 100644
--- a/dbaccess/source/ui/app/AppDetailView.hxx
+++ b/dbaccess/source/ui/app/AppDetailView.hxx
@@ -33,8 +33,6 @@
 
 #include 
 
-class SvTreeListEntry;
-
 namespace dbaui
 {
 class OAppBorderWindow;
@@ -79,11 +77,6 @@ namespace dbaui
 DECL_LINK(FocusInHdl, weld::Widget&, void);
 DECL_LINK(FocusOutHdl, weld::Widget&, void);
 
-/** sets a new current entry, and invalidates the old and the new one, 
if necessary
-@return  if and only if the "current entry" changed
-*/
-boolsetCurrentEntryInvalidate( SvTreeListEntry* _pEntry );
-
 void updateHelpText();
 
 virtual void DataChanged(const DataChangedEvent& r

[Libreoffice-commits] core.git: 2 commits - accessibility/source dbaccess/source include/vcl solenv/clang-format toolkit/source vcl/inc vcl/source

2020-08-12 Thread Caolán McNamara (via logerrit)

 accessibility/source/extended/accessiblelistboxentry.cxx |2 
 dbaccess/source/ui/app/AppController.cxx |1 
 dbaccess/source/ui/app/AppDetailPageHelper.hxx   |1 
 dbaccess/source/ui/browser/dbtreeview.cxx|5 
 dbaccess/source/ui/browser/dsEntriesNoExp.cxx|1 
 dbaccess/source/ui/browser/dsbrowserDnD.cxx  |1 
 dbaccess/source/ui/browser/unodatbr.cxx  |2 
 dbaccess/source/ui/control/dbtreelistbox.cxx |  475 ---
 dbaccess/source/ui/inc/dbtreelistbox.hxx |   87 --
 dbaccess/source/ui/inc/tabletree.hxx |   29 
 include/vcl/toolkit/svlbitm.hxx  |8 
 solenv/clang-format/excludelist  |2 
 toolkit/source/controls/tree/treecontrolpeer.cxx |2 
 vcl/inc/pch/precompiled_vcl.hxx  |5 
 vcl/source/app/salvtables.cxx|2 
 vcl/source/treelist/svimpbox.cxx |2 
 vcl/source/treelist/svlbitm.cxx  |2 
 vcl/source/treelist/svtabbx.cxx  |2 
 vcl/source/treelist/treelistbox.cxx  |2 
 vcl/source/treelist/uiobject.cxx |2 
 20 files changed, 15 insertions(+), 618 deletions(-)

New commits:
commit 4ddafa14d70567a4e4581310a7cc83eafc1b776f
Author: Caolán McNamara 
AuthorDate: Mon Aug 10 21:11:30 2020 +0100
Commit: Caolán McNamara 
CommitDate: Wed Aug 12 20:22:57 2020 +0200

svlbitm.hxx can be toolkit only now

Change-Id: Ie5ad0febca0747fa66c2caede619d14e468da032
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100498
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/accessibility/source/extended/accessiblelistboxentry.cxx 
b/accessibility/source/extended/accessiblelistboxentry.cxx
index c742e454b16f..40729de1bcb8 100644
--- a/accessibility/source/extended/accessiblelistboxentry.cxx
+++ b/accessibility/source/extended/accessiblelistboxentry.cxx
@@ -21,7 +21,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/include/vcl/svlbitm.hxx b/include/vcl/toolkit/svlbitm.hxx
similarity index 98%
rename from include/vcl/svlbitm.hxx
rename to include/vcl/toolkit/svlbitm.hxx
index abe2446ade11..e4e6fbc57a7d 100644
--- a/include/vcl/svlbitm.hxx
+++ b/include/vcl/toolkit/svlbitm.hxx
@@ -17,9 +17,11 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
+#pragma once
 
-#ifndef INCLUDED_VCL_SVLBITM_HXX
-#define INCLUDED_VCL_SVLBITM_HXX
+#if !defined(VCL_DLLIMPLEMENTATION) && !defined(TOOLKIT_DLLIMPLEMENTATION) && 
!defined(VCL_INTERNALS)
+#error "don't use this in new code"
+#endif
 
 #include 
 #include 
@@ -283,6 +285,4 @@ inline const Image& SvLBoxContextBmp::GetBitmap2() const
 return rImage;
 }
 
-#endif
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/solenv/clang-format/excludelist b/solenv/clang-format/excludelist
index 3d1ab760..e8fb15c70220 100644
--- a/solenv/clang-format/excludelist
+++ b/solenv/clang-format/excludelist
@@ -7410,7 +7410,6 @@ include/vcl/splitwin.hxx
 include/vcl/status.hxx
 include/vcl/stdtext.hxx
 include/vcl/svapp.hxx
-include/vcl/svlbitm.hxx
 include/vcl/svtaccessiblefactory.hxx
 include/vcl/syschild.hxx
 include/vcl/sysdata.hxx
@@ -7444,6 +7443,7 @@ include/vcl/toolkit/prgsbar.hxx
 include/vcl/toolkit/roadmap.hxx
 include/vcl/toolkit/spin.hxx
 include/vcl/toolkit/spinfld.hxx
+include/vcl/toolkit/svlbitm.hxx
 include/vcl/toolkit/svtabbx.hxx
 include/vcl/toolkit/tabdlg.hxx
 include/vcl/toolkit/throbber.hxx
diff --git a/toolkit/source/controls/tree/treecontrolpeer.cxx 
b/toolkit/source/controls/tree/treecontrolpeer.cxx
index cefb7d4762ea..00423e7a2a2f 100644
--- a/toolkit/source/controls/tree/treecontrolpeer.cxx
+++ b/toolkit/source/controls/tree/treecontrolpeer.cxx
@@ -38,7 +38,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 
 #include 
 
diff --git a/vcl/inc/pch/precompiled_vcl.hxx b/vcl/inc/pch/precompiled_vcl.hxx
index b8c52378da0e..966e842b43bc 100644
--- a/vcl/inc/pch/precompiled_vcl.hxx
+++ b/vcl/inc/pch/precompiled_vcl.hxx
@@ -13,7 +13,7 @@
  manual changes will be rewritten by the next run of update_pch.sh (which 
presumably
  also fixes all possible problems, so it's usually better to use it).
 
- Generated on 2020-07-23 15:08:45 using:
+ Generated on 2020-08-10 21:11:12 using:
  ./bin/update_pch vcl vcl --cutoff=6 --exclude:system --include:module 
--include:local
 
  If after updating build fails, use the following command to locate 
conflicting headers:
@@ -205,7 +205,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -309,7 +308,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -322,6 +320,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #

[Libreoffice-commits] core.git: accessibility/inc accessibility/source basctl/inc chart2/inc comphelper/inc connectivity/inc cppcanvas/inc cppuhelper/inc cui/inc dbaccess/inc desktop/inc drawinglayer/

2020-08-12 Thread Caolán McNamara (via logerrit)

 accessibility/inc/extended/accessiblelistboxentry.hxx|2 -
 accessibility/inc/pch/precompiled_acc.hxx|   23 ++-
 accessibility/source/extended/accessiblelistbox.cxx  |4 +-
 accessibility/source/extended/accessiblelistboxentry.cxx |2 -
 basctl/inc/pch/precompiled_basctl.hxx|   15 +++--
 chart2/inc/pch/precompiled_chartcontroller.hxx   |5 ---
 chart2/inc/pch/precompiled_chartcore.hxx |3 +
 comphelper/inc/pch/precompiled_comphelper.hxx|4 --
 connectivity/inc/pch/precompiled_ado.hxx |5 ---
 connectivity/inc/pch/precompiled_calc.hxx|3 -
 connectivity/inc/pch/precompiled_dbase.hxx   |3 -
 connectivity/inc/pch/precompiled_dbpool2.hxx |3 -
 connectivity/inc/pch/precompiled_dbtools.hxx |3 +
 connectivity/inc/pch/precompiled_firebird_sdbc.hxx   |9 -
 connectivity/inc/pch/precompiled_flat.hxx|4 --
 connectivity/inc/pch/precompiled_mysql_jdbc.hxx  |5 ---
 connectivity/inc/pch/precompiled_odbc.hxx|3 -
 cppcanvas/inc/pch/precompiled_cppcanvas.hxx  |4 --
 cppuhelper/inc/pch/precompiled_cppuhelper.hxx|3 +
 cui/inc/pch/precompiled_cui.hxx  |   15 +
 dbaccess/inc/pch/precompiled_dba.hxx |3 +
 dbaccess/inc/pch/precompiled_dbu.hxx |5 +--
 desktop/inc/pch/precompiled_deployment.hxx   |5 +--
 desktop/inc/pch/precompiled_deploymentgui.hxx|3 +
 desktop/inc/pch/precompiled_sofficeapp.hxx   |5 +--
 drawinglayer/inc/pch/precompiled_drawinglayer.hxx|4 +-
 emfio/inc/pch/precompiled_emfio.hxx  |3 -
 external/skia/inc/pch/precompiled_skia.hxx   |3 +
 framework/inc/pch/precompiled_fwk.hxx|5 ---
 include/vcl/toolkit/svlbitm.hxx  |2 -
 include/vcl/toolkit/svtabbx.hxx  |2 -
 include/vcl/toolkit/treelist.hxx |   11 +++
 include/vcl/toolkit/treelistbox.hxx  |   11 +++
 include/vcl/toolkit/treelistentries.hxx  |   10 +++---
 include/vcl/toolkit/treelistentry.hxx|   13 
 include/vcl/toolkit/viewdataentry.hxx|9 +++--
 include/vcl/uitest/uiobject.hxx  |1 
 lotuswordpro/inc/pch/precompiled_lwpft.hxx   |4 --
 oox/inc/pch/precompiled_oox.hxx  |3 -
 package/inc/pch/precompiled_package2.hxx |   10 +-
 package/inc/pch/precompiled_xstor.hxx|4 --
 reportdesign/inc/pch/precompiled_rpt.hxx |7 
 reportdesign/inc/pch/precompiled_rptui.hxx   |   12 ---
 reportdesign/inc/pch/precompiled_rptxml.hxx  |8 -
 sc/inc/pch/precompiled_sc.hxx|5 ---
 sc/inc/pch/precompiled_scfilt.hxx|4 +-
 sc/inc/pch/precompiled_vbaobj.hxx|3 -
 sd/inc/pch/precompiled_sd.hxx|7 ++--
 sd/inc/pch/precompiled_sdui.hxx  |7 +---
 sdext/inc/pch/precompiled_PresentationMinimizer.hxx  |8 -
 sdext/inc/pch/precompiled_PresenterScreen.hxx|8 +
 sfx2/inc/pch/precompiled_sfx.hxx |6 +--
 slideshow/inc/pch/precompiled_slideshow.hxx  |4 --
 solenv/clang-format/excludelist  |8 ++---
 starmath/inc/pch/precompiled_sm.hxx  |4 --
 svl/inc/pch/precompiled_svl.hxx  |4 +-
 svtools/inc/pch/precompiled_svt.hxx  |3 -
 svx/inc/pch/precompiled_svx.hxx  |5 +--
 svx/inc/pch/precompiled_svxcore.hxx  |7 ++--
 sw/inc/pch/precompiled_msword.hxx|9 -
 sw/inc/pch/precompiled_sw.hxx|   11 +++
 sw/inc/pch/precompiled_swui.hxx  |5 ---
 sw/inc/pch/precompiled_vbaswobj.hxx  |4 +-
 toolkit/source/controls/tree/treecontrolpeer.cxx |6 +--
 unotools/inc/pch/precompiled_utl.hxx |6 ++-
 uui/inc/pch/precompiled_uui.hxx  |3 -
 vbahelper/inc/pch/precompiled_msforms.hxx|6 ---
 vcl/inc/iconview.hxx |2 -
 vcl/inc/pch/precompiled_vcl.hxx  |   10 +++---
 vcl/inc/svimpbox.hxx |2 -
 vcl/source/app/salvtables.cxx|4 +-
 vcl/source/treelist/iconview.cxx |4 +-
 vcl/source/treeli

[Libreoffice-commits] core.git: dbaccess/Library_dbu.mk dbaccess/source dbaccess/uiconfig include/dbaccess include/svx solenv/clang-format svx/source

2020-08-12 Thread Caolán McNamara (via logerrit)

 dbaccess/Library_dbu.mk  |1 
 dbaccess/source/ui/browser/dataview.cxx  |   19 
 dbaccess/source/ui/browser/dbexchange.cxx|   41 
 dbaccess/source/ui/browser/dbtreeview.cxx|   18 
 dbaccess/source/ui/browser/dbtreeview.hxx|   20 
 dbaccess/source/ui/browser/dsEntriesNoExp.cxx|  171 +--
 dbaccess/source/ui/browser/dsbrowserDnD.cxx  |  153 +--
 dbaccess/source/ui/browser/genericcontroller.cxx |4 
 dbaccess/source/ui/browser/unodatbr.cxx  | 1002 ---
 dbaccess/source/ui/control/dbtreelistbox.cxx |   16 
 dbaccess/source/ui/control/listviewitems.cxx |   68 -
 dbaccess/source/ui/control/tabletree.cxx |1 
 dbaccess/source/ui/inc/TableCopyHelper.hxx   |4 
 dbaccess/source/ui/inc/dbexchange.hxx|   19 
 dbaccess/source/ui/inc/dbtreelistbox.hxx |8 
 dbaccess/source/ui/inc/imageprovider.hxx |2 
 dbaccess/source/ui/inc/listviewitems.hxx |   54 -
 dbaccess/source/ui/inc/unodatbr.hxx  |  115 +-
 dbaccess/source/ui/misc/imageprovider.cxx|4 
 dbaccess/uiconfig/ui/dbtreelist.ui   |5 
 include/dbaccess/IController.hxx |6 
 include/dbaccess/dataview.hxx|2 
 include/dbaccess/genericcontroller.hxx   |1 
 include/svx/dbaexchange.hxx  |   17 
 solenv/clang-format/excludelist  |2 
 svx/source/fmcomp/dbaexchange.cxx|   20 
 26 files changed, 881 insertions(+), 892 deletions(-)

New commits:
commit 5f7cf9ccba25a94c275ec67936dc29f0adb4129a
Author: Caolán McNamara 
AuthorDate: Mon Aug 10 19:49:25 2020 +0100
Commit: Caolán McNamara 
CommitDate: Wed Aug 12 20:22:23 2020 +0200

use InterimDBTreeListBox

Change-Id: I2f345f1a4fd6c7a4dc7be831f85a9f728ee477ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100496
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/dbaccess/Library_dbu.mk b/dbaccess/Library_dbu.mk
index 67e852518bae..1a3630727860 100644
--- a/dbaccess/Library_dbu.mk
+++ b/dbaccess/Library_dbu.mk
@@ -101,7 +101,6 @@ $(eval $(call gb_Library_add_exception_objects,dbu,\
 dbaccess/source/ui/control/dbtreelistbox \
 dbaccess/source/ui/control/FieldControls \
 dbaccess/source/ui/control/FieldDescControl \
-dbaccess/source/ui/control/listviewitems \
 dbaccess/source/ui/control/opendoccontrols \
 dbaccess/source/ui/control/RelationControl \
 dbaccess/source/ui/control/ScrollHelper \
diff --git a/dbaccess/source/ui/browser/dataview.cxx 
b/dbaccess/source/ui/browser/dataview.cxx
index 099199bc2ae4..b293fadd3cc4 100644
--- a/dbaccess/source/ui/browser/dataview.cxx
+++ b/dbaccess/source/ui/browser/dataview.cxx
@@ -131,12 +131,6 @@ namespace dbaui
 {
 Window::StateChanged( nType );
 
-if ( nType == StateChangedType::ControlBackground )
-{
-// Check if we need to get new images for normal/high contrast mode
-m_xController->notifyHiContrastChanged();
-}
-
 if ( nType != StateChangedType::InitShow )
 return;
 
@@ -158,20 +152,7 @@ namespace dbaui
 DBG_UNHANDLED_EXCEPTION("dbaccess");
 }
 }
-void ODataView::DataChanged( const DataChangedEvent& rDCEvt )
-{
-Window::DataChanged( rDCEvt );
 
-if ( (rDCEvt.GetType() == DataChangedEventType::FONTS) ||
-(rDCEvt.GetType() == DataChangedEventType::DISPLAY) ||
-(rDCEvt.GetType() == DataChangedEventType::FONTSUBSTITUTION) ||
-((rDCEvt.GetType() == DataChangedEventType::SETTINGS) &&
-(rDCEvt.GetFlags() & AllSettingsFlags::STYLE)) )
-{
-// Check if we need to get new images for normal/high contrast mode
-m_xController->notifyHiContrastChanged();
-}
-}
 void ODataView::attachFrame(const Reference< XFrame >& _xFrame)
 {
 m_pAccel->init(m_xContext, _xFrame);
diff --git a/dbaccess/source/ui/browser/dbexchange.cxx 
b/dbaccess/source/ui/browser/dbexchange.cxx
index 2fe0a3b21ed5..a6d649674f07 100644
--- a/dbaccess/source/ui/browser/dbexchange.cxx
+++ b/dbaccess/source/ui/browser/dbexchange.cxx
@@ -58,6 +58,10 @@ namespace dbaui
 }
 }
 
+ODataClipboard::ODataClipboard()
+{
+}
+
 ODataClipboard::ODataClipboard(
 const OUString&  _rDatasource,
 const sal_Int32 _nCommandType,
@@ -88,6 +92,43 @@ namespace dbaui
 m_pRtf.set( new ORTFImportExport( getDescriptor(),_rxORB, _rxFormatter 
) );
 }
 
+void ODataClipboard::Update(
+const OUString&  rDatasource,
+const sal_Int32  nCommandType,
+const OUString&  rCommand,
+const Reference< XConnection >& rxConnection,
+const Reference< XNumberFormatter >&

[Libreoffice-commits] core.git: dbaccess/source

2020-08-12 Thread Caolán McNamara (via logerrit)

 dbaccess/source/ui/control/dbtreelistbox.cxx |2 --
 1 file changed, 2 deletions(-)

New commits:
commit f88c85b09b0e4557c2ce9216941244cce0750169
Author: Caolán McNamara 
AuthorDate: Mon Aug 10 17:26:06 2020 +0100
Commit: Caolán McNamara 
CommitDate: Wed Aug 12 20:21:46 2020 +0200

don't need to enforce sort in the baseclass

Change-Id: Ib8f208952bdda686c9ec9881f4da66e8c1c3a83e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100495
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/dbaccess/source/ui/control/dbtreelistbox.cxx 
b/dbaccess/source/ui/control/dbtreelistbox.cxx
index 8be8061628cc..1b7afcc7198d 100644
--- a/dbaccess/source/ui/control/dbtreelistbox.cxx
+++ b/dbaccess/source/ui/control/dbtreelistbox.cxx
@@ -117,8 +117,6 @@ TreeListBox::TreeListBox(std::unique_ptr 
xTreeView)
 , m_pActionListener(nullptr)
 , m_pContextMenuProvider(nullptr)
 {
-m_xTreeView->make_sorted();
-
 m_xTreeView->connect_key_press(LINK(this, TreeListBox, KeyInputHdl));
 m_xTreeView->connect_changed(LINK(this, TreeListBox, SelectHdl));
 m_xTreeView->connect_query_tooltip(LINK(this, TreeListBox, 
QueryTooltipHdl));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: dbaccess/source dbaccess/uiconfig dbaccess/UIConfig_dbaccess.mk

2020-08-12 Thread Caolán McNamara (via logerrit)

 dbaccess/UIConfig_dbaccess.mk |1 
 dbaccess/source/ui/app/AppController.cxx  |   61 +-
 dbaccess/source/ui/app/AppController.hxx  |   19 
 dbaccess/source/ui/app/AppDetailPageHelper.cxx|  516 +-
 dbaccess/source/ui/app/AppDetailPageHelper.hxx|   46 -
 dbaccess/source/ui/app/AppDetailView.cxx  |   14 
 dbaccess/source/ui/app/AppDetailView.hxx  |   16 
 dbaccess/source/ui/app/AppView.cxx|   12 
 dbaccess/source/ui/app/AppView.hxx|   21 
 dbaccess/source/ui/browser/dsbrowserDnD.cxx   |6 
 dbaccess/source/ui/browser/unodatbr.cxx   |   16 
 dbaccess/source/ui/control/dbtreelistbox.cxx  |  372 
 dbaccess/source/ui/control/tabletree.cxx  |  516 +++---
 dbaccess/source/ui/dlg/adtabdlg.cxx   |4 
 dbaccess/source/ui/dlg/tablespage.cxx |2 
 dbaccess/source/ui/inc/callbacks.hxx  |   11 
 dbaccess/source/ui/inc/dbtreelistbox.hxx  |   84 ++
 dbaccess/source/ui/inc/tabletree.hxx  |  110 +--
 dbaccess/source/ui/inc/unodatbr.hxx   |4 
 dbaccess/source/ui/querydesign/QTableWindow.cxx   |1 
 dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx |1 
 dbaccess/source/ui/querydesign/TableWindow.cxx|2 
 dbaccess/uiconfig/ui/dbtreelist.ui|   94 +++
 23 files changed, 1254 insertions(+), 675 deletions(-)

New commits:
commit 46c34d5abcc3fb709de4c3a6a62649f1fe41ec9c
Author: Caolán McNamara 
AuthorDate: Fri Aug 7 14:33:07 2020 +0100
Commit: Caolán McNamara 
CommitDate: Wed Aug 12 20:21:10 2020 +0200

weld DBTreeListBox

Change-Id: I4b7369a496339b9bbab0c885c7360a5d7818a62e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100329
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/dbaccess/UIConfig_dbaccess.mk b/dbaccess/UIConfig_dbaccess.mk
index feaa35c10708..8a4229e02f38 100644
--- a/dbaccess/UIConfig_dbaccess.mk
+++ b/dbaccess/UIConfig_dbaccess.mk
@@ -23,6 +23,7 @@ $(eval $(call gb_UIConfig_add_uifiles,dbaccess, \
 dbaccess/uiconfig/ui/copytablepage \
 dbaccess/uiconfig/ui/dbaseindexdialog \
 dbaccess/uiconfig/ui/dbasepage \
+dbaccess/uiconfig/ui/dbtreelist \
 dbaccess/uiconfig/ui/dbwizconnectionpage \
 dbaccess/uiconfig/ui/dbwizmysqlintropage \
 dbaccess/uiconfig/ui/dbwizmysqlnativepage \
diff --git a/dbaccess/source/ui/app/AppController.cxx 
b/dbaccess/source/ui/app/AppController.cxx
index 958d5d9c7b4f..67bd857b60d4 100644
--- a/dbaccess/source/ui/app/AppController.cxx
+++ b/dbaccess/source/ui/app/AppController.cxx
@@ -97,6 +97,7 @@
 #include 
 #include 
 #include 
+#include 
 #include "AppDetailView.hxx"
 #include 
 #include 
@@ -1683,15 +1684,23 @@ bool 
OApplicationController::onContainerSelect(ElementType _eType)
 return true;
 }
 
-bool OApplicationController::onEntryDoubleClick( SvTreeListBox const & _rTree )
+bool OApplicationController::onEntryDoubleClick(const weld::TreeView& 
rTreeView)
 {
-if ( getContainer() && getContainer()->isLeaf( _rTree.GetHdlEntry() ) )
+OApplicationView* pContainer = getContainer();
+if (!pContainer)
+return false;   // not handled
+
+std::unique_ptr xHdlEntry = rTreeView.make_iterator();
+if (!rTreeView.get_cursor(xHdlEntry.get()))
+return false;
+
+if (pContainer->isLeaf(rTreeView, *xHdlEntry))
 {
 try
 {
 // opens a new frame with either the table or the query or report 
or form or view
 openElementWithArguments(
-getContainer()->getQualifiedName( _rTree.GetHdlEntry() ),
+getContainer()->getQualifiedName(xHdlEntry.get()),
 getContainer()->getElementType(),
 E_OPEN_NORMAL,
 0,
@@ -1703,6 +1712,7 @@ bool OApplicationController::onEntryDoubleClick( 
SvTreeListBox const & _rTree )
 DBG_UNHANDLED_EXCEPTION("dbaccess");
 }
 }
+
 return false;   // not handled
 }
 
@@ -2237,7 +2247,7 @@ void OApplicationController::onDeleteEntry()
 executeChecked(nId,Sequence());
 }
 
-OUString OApplicationController::getContextMenuResourceName( Control& 
/*_rControl*/ ) const
+OUString OApplicationController::getContextMenuResourceName() const
 {
 return "edit";
 }
@@ -2264,6 +2274,11 @@ bool OApplicationController::requestQuickHelp( const 
SvTreeListEntry* /*_pEntry*
 return false;
 }
 
+bool OApplicationController::requestQuickHelp(const void* /*pUserData*/, 
OUString& /*rText*/) const
+{
+return false;
+}
+
 bool OApplicationController::requestDrag(  const Point& /*_rPosPixel*/ )
 {
 rtl::Reference pTransfer;
@@ -2288,6 +2303,32 @@ bool OApplicationController::requestDrag(  const Point& 
/*_rPosPixel*/ )
 return pTransfer.is();
 }
 
+bool OApplicationController::r

[Libreoffice-commits] core.git: dbaccess/source

2020-08-12 Thread Caolán McNamara (via logerrit)

 dbaccess/source/ui/control/tabletree.cxx |   99 ++-
 dbaccess/source/ui/inc/tabletree.hxx |   57 +
 2 files changed, 128 insertions(+), 28 deletions(-)

New commits:
commit c299e1255974c5564333480a5f8f0877c1011bc4
Author: Caolán McNamara 
AuthorDate: Sun Aug 9 17:59:48 2020 +0100
Commit: Caolán McNamara 
CommitDate: Wed Aug 12 20:20:52 2020 +0200

sync OTableTreeListBox and TableTreeListBox

Change-Id: I52c26e055c599e266221d6092957a0e764744e20
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100409
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/dbaccess/source/ui/control/tabletree.cxx 
b/dbaccess/source/ui/control/tabletree.cxx
index 414cacbc8afe..b565b62cbbf6 100644
--- a/dbaccess/source/ui/control/tabletree.cxx
+++ b/dbaccess/source/ui/control/tabletree.cxx
@@ -62,6 +62,8 @@ namespace DatabaseObjectContainer = 
::com::sun::star::sdb::application::Database
 OTableTreeListBox::OTableTreeListBox(vcl::Window* pParent, WinBits nWinStyle)
 : DBTreeListBox(pParent, nWinStyle)
 , m_xImageProvider( new ImageProvider )
+, m_bVirtualRoot(false)
+, m_bNoEmptyFolders( false )
 {
 InitButtonData();
 
@@ -326,6 +328,20 @@ void OTableTreeListBox::UpdateTableList( const Reference< 
XConnection >& _rxConn
 
 try
 {
+if (haveVirtualRoot())
+{
+OUString sRootEntryText;
+if ( std::none_of(_rTables.begin(),_rTables.end(),
+[] (const TNames::value_type& name) { return 
!name.second; }) )
+sRootEntryText  = DBA_RES(STR_ALL_TABLES);
+else if ( std::none_of(_rTables.begin(),_rTables.end(),
+ [] (const TNames::value_type& name) { 
return name.second; }) )
+sRootEntryText  = DBA_RES(STR_ALL_VIEWS);
+else
+sRootEntryText  = DBA_RES(STR_ALL_TABLES_AND_VIEWS);
+InsertEntry( sRootEntryText, nullptr, false, TREELIST_APPEND, 
reinterpret_cast< void* >( DatabaseObjectContainer::TABLES ) );
+}
+
 if ( _rTables.empty() )
 // nothing to do (besides inserting the root entry)
 return;
@@ -335,14 +351,10 @@ void OTableTreeListBox::UpdateTableList( const Reference< 
XConnection >& _rxConn
 for (auto const& table : _rTables)
 {
 // add the entry
-implAddEntry(
-xMeta,
-table.first,
-false
-);
+implAddEntry(xMeta, table.first, false);
 }
 
-if ( lcl_shouldDisplayEmptySchemasAndCatalogs( _rxConnection ) )
+if ( !m_bNoEmptyFolders && lcl_shouldDisplayEmptySchemasAndCatalogs( 
_rxConnection ) )
 {
 bool bSupportsCatalogs = 
xMeta->supportsCatalogsInDataManipulation();
 bool bSupportsSchemas = xMeta->supportsSchemasInDataManipulation();
@@ -358,11 +370,12 @@ void OTableTreeListBox::UpdateTableList( const Reference< 
XConnection >& _rxConn
 bCatalogs ? xMeta->getCatalogs() : xMeta->getSchemas(), 1 
) );
 sal_Int32 nFolderType = bCatalogs ? 
DatabaseObjectContainer::CATALOG : DatabaseObjectContainer::SCHEMA;
 
+SvTreeListEntry* pRootEntry = getAllObjectsEntry();
 for (auto const& folderName : aFolderNames)
 {
-SvTreeListEntry* pFolder = GetEntryPosByName( folderName, 
nullptr );
+SvTreeListEntry* pFolder = GetEntryPosByName( folderName, 
pRootEntry );
 if ( !pFolder )
-InsertEntry( folderName, nullptr, false, 
TREELIST_APPEND, reinterpret_cast< void* >( nFolderType ) );
+InsertEntry( folderName, pRootEntry, false, 
TREELIST_APPEND, reinterpret_cast< void* >( nFolderType ) );
 }
 }
 }
@@ -419,7 +432,7 @@ void TableTreeListBox::UpdateTableList( const Reference< 
XConnection >& _rxConne
 for (auto const& table : _rTables)
 {
 // add the entry
-implAddEntry(xMeta, table.first);
+implAddEntry(xMeta, table.first, false);
 }
 
 if ( !m_bNoEmptyFolders && lcl_shouldDisplayEmptySchemasAndCatalogs( 
_rxConnection ) )
@@ -467,11 +480,28 @@ void TableTreeListBox::UpdateTableList( const Reference< 
XConnection >& _rxConne
 m_xTreeView->make_sorted();
 }
 
+bool OTableTreeListBox::isWildcardChecked(SvTreeListEntry* _pEntry)
+{
+if (_pEntry)
+{
+OBoldListboxString* pTextItem = 
static_cast(_pEntry->GetFirstItem(SvLBoxItemType::String));
+if (pTextItem)
+return pTextItem->isEmphasized();
+}
+return false;
+}
+
 bool TableTreeListBox::isWildcardChecked(const weld::TreeIter& rEntry)
 {
 return m_xTreeView->get_text_emphasis(rEntry, 0);
 }
 
+void OTableTreeListBox::checkWildcard(SvTreeListEntry* _pEntry)
+{
+

[Libreoffice-commits] online.git: cypress_test/integration_tests

2020-08-12 Thread Tamás Zolnai (via logerrit)

 cypress_test/integration_tests/common/helper.js |9 +
 1 file changed, 9 insertions(+)

New commits:
commit 815802e6e0fbf5eeff17a48d3d84b4b6fe687058
Author: Tamás Zolnai 
AuthorDate: Wed Aug 12 16:59:12 2020 +0200
Commit: Tamás Zolnai 
CommitDate: Wed Aug 12 19:59:35 2020 +0200

cypress: improve typeIntoDocument() helper method.

First grab the focus to the textarea, otherwise
the force: true flag leads to unexpected behavior.

Change-Id: Ic99bb1b22734733d7bb40b895173e5382c2ba5f4
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100605
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tamás Zolnai 

diff --git a/cypress_test/integration_tests/common/helper.js 
b/cypress_test/integration_tests/common/helper.js
index 9853b7174..e9e3450ab 100644
--- a/cypress_test/integration_tests/common/helper.js
+++ b/cypress_test/integration_tests/common/helper.js
@@ -480,6 +480,15 @@ function moveCursor(direction) {
 }
 
 function typeIntoDocument(text) {
+   cy.get('textarea.clipboard')
+   .focus();
+
+   cy.document().its('activeElement.tagName')
+   .should('be.eq', 'TEXTAREA');
+
+   cy.document().its('activeElement.className')
+   .should('be.eq', 'clipboard');
+
cy.get('textarea.clipboard')
.type(text, {force: true});
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: icon-themes/breeze icon-themes/breeze_dark icon-themes/colibre icon-themes/elementary icon-themes/karasa_jaga icon-themes/sifr icon-themes/sifr_dark icon-themes/sukapur

2020-08-12 Thread Rizal Muttaqin (via logerrit)

 icon-themes/breeze/links.txt  |4 
 icon-themes/breeze_dark/links.txt |4 
 icon-themes/colibre/links.txt |2 
 icon-themes/elementary/links.txt  |4 
 icon-themes/karasa_jaga/links.txt | 4130 ++--
 icon-themes/sifr/links.txt|2 
 icon-themes/sifr_dark/links.txt   |2 
 icon-themes/sukapura/links.txt| 5424 +++---
 8 files changed, 4786 insertions(+), 4786 deletions(-)

New commits:
commit a2219391f3018c285a792c34f56a85d1af7076e9
Author: Rizal Muttaqin 
AuthorDate: Tue Aug 11 07:11:50 2020 +0700
Commit: Adolfo Jayme Barrientos 
CommitDate: Wed Aug 12 19:33:39 2020 +0200

tdf#135625 icons for Drawing Object in Calc's Navigator

Change-Id: I47b0975763182275bc4dbda200105de51ab77bbc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100454
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/icon-themes/breeze/links.txt b/icon-themes/breeze/links.txt
index cfbcd976b391..bf8cd86768bb 100644
--- a/icon-themes/breeze/links.txt
+++ b/icon-themes/breeze/links.txt
@@ -1940,7 +1940,7 @@ cmd/sc_browseforward.png cmd/sc_nextrecord.png
 cmd/32/donation.png cmd/32/currencyfield.png
 cmd/lc_donation.png cmd/lc_currencyfield.png
 cmd/sc_donation.png cmd/sc_currencyfield.png
- 
+
 # Math
 cmd/32/symbolcatalogue.png cmd/32/insertsymbol.png
 cmd/lc_symbolcatalogue.png cmd/lc_insertsymbol.png
@@ -2377,7 +2377,7 @@ sc/res/nc04.png cmd/sc_insertgraphic.png
 sc/res/nc05.png cmd/sc_insertobject.png
 sc/res/nc06.png cmd/sc_shownote.png
 sc/res/nc07.png cmd/sc_insertbookmark.png
-sc/res/nc08.png cmd/sc_insertgraphic.png
+sc/res/nc08.png cmd/sc_insertdraw.png
 sc/res/page.png cmd/sc_insertpagenumberfield.png
 sc/res/pages.png cmd/sc_insertpagecountfield.png
 sc/res/paste_transpose.png cmd/lc_datadatapilotrun.png
diff --git a/icon-themes/breeze_dark/links.txt 
b/icon-themes/breeze_dark/links.txt
index cfbcd976b391..bf8cd86768bb 100644
--- a/icon-themes/breeze_dark/links.txt
+++ b/icon-themes/breeze_dark/links.txt
@@ -1940,7 +1940,7 @@ cmd/sc_browseforward.png cmd/sc_nextrecord.png
 cmd/32/donation.png cmd/32/currencyfield.png
 cmd/lc_donation.png cmd/lc_currencyfield.png
 cmd/sc_donation.png cmd/sc_currencyfield.png
- 
+
 # Math
 cmd/32/symbolcatalogue.png cmd/32/insertsymbol.png
 cmd/lc_symbolcatalogue.png cmd/lc_insertsymbol.png
@@ -2377,7 +2377,7 @@ sc/res/nc04.png cmd/sc_insertgraphic.png
 sc/res/nc05.png cmd/sc_insertobject.png
 sc/res/nc06.png cmd/sc_shownote.png
 sc/res/nc07.png cmd/sc_insertbookmark.png
-sc/res/nc08.png cmd/sc_insertgraphic.png
+sc/res/nc08.png cmd/sc_insertdraw.png
 sc/res/page.png cmd/sc_insertpagenumberfield.png
 sc/res/pages.png cmd/sc_insertpagecountfield.png
 sc/res/paste_transpose.png cmd/lc_datadatapilotrun.png
diff --git a/icon-themes/colibre/links.txt b/icon-themes/colibre/links.txt
index b117f396bfd8..f7f97d55fb37 100644
--- a/icon-themes/colibre/links.txt
+++ b/icon-themes/colibre/links.txt
@@ -2260,7 +2260,7 @@ sc/res/nc04.png cmd/sc_insertgraphic.png
 sc/res/nc05.png cmd/sc_insertobject.png
 sc/res/nc06.png cmd/sc_shownote.png
 sc/res/nc07.png cmd/sc_insertbookmark.png
-sc/res/nc08.png cmd/sc_insertgraphic.png
+sc/res/nc08.png cmd/sc_insertdraw.png
 sc/res/page.png cmd/sc_insertpagenumberfield.png
 sc/res/pages.png cmd/sc_insertpagecountfield.png
 sc/res/sc26047.png cmd/sc_dbviewfunctions.png
diff --git a/icon-themes/elementary/links.txt b/icon-themes/elementary/links.txt
index 0753a6c4b0ae..672caf5cb22b 100644
--- a/icon-themes/elementary/links.txt
+++ b/icon-themes/elementary/links.txt
@@ -2143,7 +2143,7 @@ sc/res/nc03.png cmd/sc_viewdatasourcebrowser.png
 sc/res/nc04.png cmd/sc_gallery.png
 sc/res/nc06.png cmd/sc_shownote.png
 sc/res/nc07.png sc/res/droplink.png
-sc/res/nc08.png cmd/sc_gallery.png
+sc/res/nc08.png cmd/sc_insertdraw.png
 sc/res/page.png cmd/sc_insertpagenumberfield.png
 sc/res/pages.png cmd/sc_insertpagecountfield.png
 sc/res/paste_values_formats.png cmd/lc_formatpaintbrush.png
@@ -2468,7 +2468,7 @@ cmd/32/addtextbox.png cmd/32/insertfixedtext.png
 cmd/lc_addtextbox.png cmd/lc_insertfixedtext.png
 cmd/sc_addtextbox.png cmd/sc_insertfixedtext.png
 
-# Edit menu 
+# Edit menu
 # ===
 cmd/32/authoritiesentrydialog.png cmd/32/dbviewaliases.png
 cmd/32/changesmenu.png cmd/32/accepttrackedchange.png
diff --git a/icon-themes/karasa_jaga/links.txt 
b/icon-themes/karasa_jaga/links.txt
index d68e8e19ab8c..5853cacb6754 100644
--- a/icon-themes/karasa_jaga/links.txt
+++ b/icon-themes/karasa_jaga/links.txt
@@ -1,2065 +1,2065 @@
-avmedia/res/av02048.png cmd/sc_open.png
-avmedia/res/av02049.png cmd/sc_datastreamsplay.png
-avmedia/res/av02050.png cmd/sc_mediapause.png
-avmedia/res/av02051.png cmd/sc_datastreamsstop.png
-avmedia/res/av02052.png cmd/sc_mediarepeat.png
-avmedia/res/av02053.png cmd/sc_ok.png
-avmedia/res/av02054.png cmd/sc_mediamute.png
-avmedia/res/avl02048.png cmd/lc_open.png
-avmedia/res/avl

[Libreoffice-commits] online.git: loleaflet/src

2020-08-12 Thread Tamás Zolnai (via logerrit)

 loleaflet/src/control/Control.MobileWizard.js |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 936ad9720819ff9072957347ab248828650cadbc
Author: Tamás Zolnai 
AuthorDate: Wed Aug 12 18:10:00 2020 +0200
Commit: Tamás Zolnai 
CommitDate: Wed Aug 12 18:51:48 2020 +0200

Fix wrong internal state of mobile wizard.

When mobile wizard is opened and then we open the
hamburger menu without closing the mobile wizard the
showSidebar flag is not set to false. So when a
sidebar update comes from core then the hamburger
menu is replaced with the sidebar content.

Change-Id: I38601b3bf09309a62b2c3404f9ad27323c61cba1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100612
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tamás Zolnai 

diff --git a/loleaflet/src/control/Control.MobileWizard.js 
b/loleaflet/src/control/Control.MobileWizard.js
index 61f1017fb..8f399f69c 100644
--- a/loleaflet/src/control/Control.MobileWizard.js
+++ b/loleaflet/src/control/Control.MobileWizard.js
@@ -85,6 +85,8 @@ L.Control.MobileWizard = L.Control.extend({
$('#toolbar-down').hide();
if (window.ThisIsTheAndroidApp)
window.postMobileMessage('MOBILEWIZARD show');
+   if (window.mobileMenuWizard)
+   this.map.showSidebar = false;
},
 
_showWizardSidebar: function() {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - i18npool/util include/svtools solenv/bin svtools/inc svtools/Library_svt.mk svtools/source

2020-08-12 Thread Ahmed ElShreif (via logerrit)

 i18npool/util/i18npool.component|8 ++---
 include/svtools/valueset.hxx|2 +
 solenv/bin/native-code.py   |   44 +++
 svtools/Library_svt.mk  |1 
 svtools/inc/uiobject.hxx|   38 
 svtools/source/control/valueset.cxx |7 
 svtools/source/uitest/uiobject.cxx  |   57 
 7 files changed, 153 insertions(+), 4 deletions(-)

New commits:
commit edd916b47e01ea53f0989bdbb6a703e081e25aea
Author: Ahmed ElShreif 
AuthorDate: Sat Aug 8 01:04:28 2020 +0200
Commit: Ahmed ElShreif 
CommitDate: Wed Aug 12 18:48:32 2020 +0200

uitest : Add support for Normal ValueSet

This patch will add support for all the normal valuesets inside any dialog .

for example it will help in "Select Presets and Shadow Styles in borders 
tab ( format table or format cell )" to test tdf#133641 .

You can use the support by this line:
>> obj_name.executeAction("SELECT", mkPropertyValues({"POS": "4"}))

Change-Id: I35d0608318f1bca4f4e702ebcc258957835ce0db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100373
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard 

diff --git a/include/svtools/valueset.hxx b/include/svtools/valueset.hxx
index 410003e97d72..128ffcb8daf6 100644
--- a/include/svtools/valueset.hxx
+++ b/include/svtools/valueset.hxx
@@ -407,6 +407,8 @@ public:
 int nItemId = IsNoSelection() ? -1 : GetSelectedItemId();
 return mnSavedItemId != nItemId;
 }
+
+virtual FactoryFunction GetUITestFactory() const override;
 };
 
 
diff --git a/svtools/Library_svt.mk b/svtools/Library_svt.mk
index 456a7ae568a0..b7ed7657d691 100644
--- a/svtools/Library_svt.mk
+++ b/svtools/Library_svt.mk
@@ -182,6 +182,7 @@ $(eval $(call gb_Library_add_exception_objects,svt,\
 svtools/source/uno/wizard/unowizard \
 svtools/source/uno/wizard/wizardpagecontroller \
 svtools/source/uno/wizard/wizardshell \
+svtools/source/uitest/uiobject \
 ))
 
 ifeq ($(OS),WNT)
diff --git a/svtools/inc/uiobject.hxx b/svtools/inc/uiobject.hxx
new file mode 100644
index ..a27b6d68fdad
--- /dev/null
+++ b/svtools/inc/uiobject.hxx
@@ -0,0 +1,38 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#ifndef INCLUDED_SVTOOLS_INC_UIOBJECT_HXX
+#define INCLUDED_SVTOOLS_INC_UIOBJECT_HXX
+
+#include 
+#include 
+#include 
+
+class ValueSet;
+
+class ValueSetUIObject final : public WindowUIObject
+{
+ValueSet* mpSet;
+
+public:
+ValueSetUIObject(const VclPtr& xSetWin, ValueSet* pSet);
+
+virtual void execute(const OUString& rAction, const StringMap& 
rParameters) override;
+
+static std::unique_ptr create(vcl::Window* pWindow);
+
+virtual StringMap get_state() override;
+
+private:
+OUString get_name() const override;
+};
+
+#endif // INCLUDED_SVX_INC_UIOBJECT_HXX
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
\ No newline at end of file
diff --git a/svtools/source/control/valueset.cxx 
b/svtools/source/control/valueset.cxx
index 74a09e613d26..e56f3e7e2d43 100644
--- a/svtools/source/control/valueset.cxx
+++ b/svtools/source/control/valueset.cxx
@@ -43,6 +43,8 @@
 #include 
 #include 
 
+#include 
+
 using namespace css::uno;
 using namespace css::lang;
 using namespace css::accessibility;
@@ -1909,4 +1911,9 @@ void ValueSet::Hide()
 mxScrolledWindow->hide();
 }
 
+FactoryFunction ValueSet::GetUITestFactory() const
+{
+return ValueSetUIObject::create;
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/svtools/source/uitest/uiobject.cxx 
b/svtools/source/uitest/uiobject.cxx
new file mode 100644
index ..904a81be1bb6
--- /dev/null
+++ b/svtools/source/uitest/uiobject.cxx
@@ -0,0 +1,57 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+#include 
+#include 
+#include 
+
+ValueSetUIObject::ValueSetUIObject(const VclPtr& xSetWin, 
ValueSet* pSet)
+: WindowUIObject(xSetWin)
+, mpSet(pSet)
+{
+}
+
+void ValueSetUIObject::execute(const OUString& rAction, const StringMap& 
rParameters)
+{
+if (rAction == "SELECT")
+{
+if (rParameters.find("POS") != rParameters.end())
+{
+OUString aIndexStr = rParameters.find("POS")->second;
+
+sal_Int32 nIndex = aIndexStr.toInt32();
+mpSet->SelectItem(nIndex);
+

[Libreoffice-commits] core.git: dbaccess/uiconfig

2020-08-12 Thread Caolán McNamara (via logerrit)

 dbaccess/uiconfig/ui/tablesfilterpage.ui |5 -
 1 file changed, 5 deletions(-)

New commits:
commit 4061fa2e5f057b144dad82b6ee6fb8161f1b7403
Author: Caolán McNamara 
AuthorDate: Wed Aug 12 11:46:42 2020 +0100
Commit: Caolán McNamara 
CommitDate: Wed Aug 12 18:09:33 2020 +0200

put all the renderers into the same column

so text entries are left aligned to their expander, not
all aligned to eachother

Change-Id: Ibf35e204bb83a93fa6dcb2391cf04398d51952d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100602
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/dbaccess/uiconfig/ui/tablesfilterpage.ui 
b/dbaccess/uiconfig/ui/tablesfilterpage.ui
index 85f1b908434e..1141a341422f 100644
--- a/dbaccess/uiconfig/ui/tablesfilterpage.ui
+++ b/dbaccess/uiconfig/ui/tablesfilterpage.ui
@@ -97,11 +97,6 @@
 5
   
 
-  
-
-
-  
-6
 
   
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: bridges/source

2020-08-12 Thread Stephan Bergmann (via logerrit)

 bridges/source/cpp_uno/gcc3_linux_aarch64/abi.cxx|2 +-
 bridges/source/cpp_uno/gcc3_linux_x86-64/except.cxx  |4 ++--
 bridges/source/cpp_uno/gcc3_linux_x86-64/share.hxx   |4 ++--
 bridges/source/cpp_uno/gcc3_macosx_x86-64/except.cxx |   10 +-
 bridges/source/cpp_uno/gcc3_macosx_x86-64/share.hxx  |4 ++--
 5 files changed, 12 insertions(+), 12 deletions(-)

New commits:
commit 91c8a3f3e7d3c178952d7e78e24cd0d6ba2b165a
Author: Stephan Bergmann 
AuthorDate: Wed Aug 12 13:37:19 2020 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Aug 12 17:37:06 2020 +0200

The __cxa_exception::reserve member has been backported to LLVM 10 libcxxabi

...so record that fact in our comments, to avoid confusion

Change-Id: I83a9c576a92d74c207c8c778df0d020daf5bf33d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100593
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.cxx 
b/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.cxx
index b0a35996784e..7164b4ecb51c 100644
--- a/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_aarch64/abi.cxx
@@ -182,7 +182,7 @@ extern "C" void _GLIBCXX_CDTOR_CALLABI deleteException(void 
* exception) {
 // Later, libcxxabi, as used at least on macOS on arm64, added a
 // void *reserve at the start of the __cxa_exception in front of
 // the referenceCount. See
-// 
https://github.com/llvm/llvm-project/commit/f2a436058fcbc11291e73badb44e243f61046183#diff-ba9cda1ceca630ba040b154fe198adbd
+// 
https://github.com/llvm/llvm-project/commit/674ec1eb16678b8addc02a4b0534ab383d22fa77
 
 if (header->exceptionDestructor != &deleteException) {
 header = reinterpret_cast<__cxxabiv1::__cxa_exception *>(
diff --git a/bridges/source/cpp_uno/gcc3_linux_x86-64/except.cxx 
b/bridges/source/cpp_uno/gcc3_linux_x86-64/except.cxx
index 25931671f7dc..981ddfe676f7 100644
--- a/bridges/source/cpp_uno/gcc3_linux_x86-64/except.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_x86-64/except.cxx
@@ -152,8 +152,8 @@ void fillUnoException(uno_Any * pUnoExc, uno_Mapping * 
pCpp2Uno)
 
 #if defined _LIBCPPABI_VERSION // detect libc++abi
 // Very bad HACK to find out whether we run against a libcxxabi that has a 
new
-// __cxa_exception::reserved member at the start, introduced with LLVM 11
-// 

+// __cxa_exception::reserved member at the start, introduced with LLVM 10
+// 

 // "[libcxxabi] Insert padding in __cxa_exception struct for 
compatibility".  The layout of the
 // start of __cxa_exception is
 //
diff --git a/bridges/source/cpp_uno/gcc3_linux_x86-64/share.hxx 
b/bridges/source/cpp_uno/gcc3_linux_x86-64/share.hxx
index 53c8841fbbcb..edcb46d0da2a 100644
--- a/bridges/source/cpp_uno/gcc3_linux_x86-64/share.hxx
+++ b/bridges/source/cpp_uno/gcc3_linux_x86-64/share.hxx
@@ -109,8 +109,8 @@ struct __cxa_exception {
 #if defined _LIBCPPABI_VERSION // detect libc++abi
 #if defined __LP64__ || LIBCXXABI_ARM_EHABI
 #if 0
-// This is a new field added with LLVM 11
-// 

+// This is a new field added with LLVM 10
+// 

 // "[libcxxabi] Insert padding in __cxa_exception struct for 
compatibility".  The HACK in
 // fillUnoException (bridges/source/cpp_uno/gcc3_linux_x86-64/except.cxx) 
tries to find out at
 // runtime whether a __cxa_exception has this member.  Once we can be sure 
that we only run
diff --git a/bridges/source/cpp_uno/gcc3_macosx_x86-64/except.cxx 
b/bridges/source/cpp_uno/gcc3_macosx_x86-64/except.cxx
index 36eeda41bca7..e0216ddf3824 100644
--- a/bridges/source/cpp_uno/gcc3_macosx_x86-64/except.cxx
+++ b/bridges/source/cpp_uno/gcc3_macosx_x86-64/except.cxx
@@ -275,10 +275,10 @@ static void deleteException( void * pExc )
 // point to this function (the use of __cxa_exception in fillUnoException 
is
 // unaffected, as it only accesses members towards the start of the struct,
 // through a pointer known to actually point at the start).  The libcxxabi 
commit
-// 

-// "[libcxxabi] Insert padding in __cxa_exception struct for 
compatibility" towards LLVM 11
+// 

+// "[libcxxabi] Insert padding in __cxa_exception struct for 
compatibility" in LLVM 10
 // removes the need for this hack, so it can be removed again once we can 
be sure that we only
-// run against libcxxabi from LLVM >= 11:
+// run against libcxxabi from LLVM >= 10:

RFC: Make Python warnings fatal in --enable-werror mode

2020-08-12 Thread Mike Kaganski

Hi!

Recently I started to see new warnings from Python when building core:

> zipfile.py:1517: UserWarning: Duplicate name: 
> 'cmd/ar/sc_bulletsandnumberingdialog.png'

They have been introduced by commit
a8c3addfce4df0fa8278d83764148d4aec40b36e.

IMO, it looks natural (?) to treat Python warnings as errors when we use
--enable-werror. Having that would prevent introduction of new warnings
like that. So I have prepared
https://gerrit.libreoffice.org/c/core/+/100268 to do that.

The change allows overriding it in a particular build, e.g. calling
`PYTHONWARNINGS=default make`.

Please comment if this is OK, or is a bad idea. Thanks!

-- 
Best regards,
Mike Kaganski


pEpkey.asc
Description: application/pgp-keys
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: cypress_test/integration_tests

2020-08-12 Thread Tamás Zolnai (via logerrit)

 cypress_test/integration_tests/mobile/calc/calc_mobile_helper.js |8 

 1 file changed, 8 deletions(-)

New commits:
commit 8b35a4618f89f5c45efd2b04bc1e228ee263309d
Author: Tamás Zolnai 
AuthorDate: Wed Aug 12 15:12:02 2020 +0200
Commit: Tamás Zolnai 
CommitDate: Wed Aug 12 16:51:31 2020 +0200

cypress: improve calc column selection methods.

Searching '-8px,' is not stable, because sometimes it's
'-9px,'.

Change-Id: I6226a1ec3086b84540d74cb1c7691cf355752337
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100600
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tamás Zolnai 

diff --git a/cypress_test/integration_tests/mobile/calc/calc_mobile_helper.js 
b/cypress_test/integration_tests/mobile/calc/calc_mobile_helper.js
index dde072665..fb1c8ef5c 100644
--- a/cypress_test/integration_tests/mobile/calc/calc_mobile_helper.js
+++ b/cypress_test/integration_tests/mobile/calc/calc_mobile_helper.js
@@ -6,10 +6,6 @@ function removeTextSelection() {
cy.get('.spreadsheet-header-columns')
.click();
 
-   cy.get('.spreadsheet-cell-resize-marker')
-   .invoke('attr', 'style')
-   .should('contain', '-8px,');
-
var regex = /[A-Z]1:[A-Z]1048576/;
cy.get('input#addressInput')
.should('have.prop', 'value')
@@ -72,10 +68,6 @@ function selectFirstColumn() {
.click(XPos, YPos);
});
 
-   cy.get('.spreadsheet-cell-resize-marker')
-   .invoke('attr', 'style')
-   .should('contain', '-8px,');
-
cy.get('input#addressInput')
.should('have.prop', 'value', 'A1:A1048576');
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: .git-hooks/pre-commit

2020-08-12 Thread Xisco Fauli (via logerrit)

 .git-hooks/pre-commit |4 
 1 file changed, 4 insertions(+)

New commits:
commit 77128b8396e973606bb87b9795d28252f7892fc5
Author: Xisco Fauli 
AuthorDate: Wed Aug 12 11:14:30 2020 +0200
Commit: Miklos Vajna 
CommitDate: Wed Aug 12 16:38:13 2020 +0200

git pre-commit hook: check min gtk3 version

See tdf#135442 for motivation

Change-Id: I6db67b7a39edeb6dd9d9d82fbaa9cb93362e09e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100588
Reviewed-by: Heiko Tietze 
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/.git-hooks/pre-commit b/.git-hooks/pre-commit
index c7d51a1bcb2e..cddc8d330b77 100755
--- a/.git-hooks/pre-commit
+++ b/.git-hooks/pre-commit
@@ -97,6 +97,10 @@ sub check_whitespaces($)
 {
 bad_line("translatable .ui file line without context", $_, 
"ui");
 }
+if ((/requires/) and (/lib="gtk+/) and not (/version="3.18/))
+{
+bad_line("min supported version of gtk3 is 3.18", $_, "ui");
+}
 if ((/https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: cui/source

2020-08-12 Thread Jim Raykowski (via logerrit)

 cui/source/customize/cfgutil.cxx |   12 +++-
 1 file changed, 11 insertions(+), 1 deletion(-)

New commits:
commit ebdc0f1aada999e8b3bc8a32849a62b38819fead
Author: Jim Raykowski 
AuthorDate: Tue Aug 11 10:33:52 2020 -0800
Commit: Noel Grandin 
CommitDate: Wed Aug 12 15:37:43 2020 +0200

fix memory leaks in CuiConfigGroupListBox

Change-Id: I47dab54764de24bccc42513373b65657c241a8e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100570
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/cui/source/customize/cfgutil.cxx b/cui/source/customize/cfgutil.cxx
index 1d863889610c..13203e0926a9 100644
--- a/cui/source/customize/cfgutil.cxx
+++ b/cui/source/customize/cfgutil.cxx
@@ -435,7 +435,17 @@ void CuiConfigGroupListBox::ClearAll()
 for ( sal_uInt16 i=0; inKind == SfxCfgKind::GROUP_SCRIPTCONTAINER)
+if (pData->nKind == SfxCfgKind::GROUP_STYLES && pData->pObject)
+{
+SfxStyleInfo_Impl* pStyle = 
static_cast(pData->pObject);
+delete pStyle;
+}
+else if (pData->nKind == SfxCfgKind::FUNCTION_SCRIPT && pData->pObject 
)
+{
+OUString* pScriptURI = static_cast(pData->pObject);
+delete pScriptURI;
+}
+else if (pData->nKind == SfxCfgKind::GROUP_SCRIPTCONTAINER)
 {
 XInterface* xi = static_cast(pData->pObject);
 if (xi != nullptr)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

2020-08-12 Thread Noel Grandin (via logerrit)

 sc/source/ui/Accessibility/AccessibleDocumentPagePreview.cxx |   33 +--
 1 file changed, 16 insertions(+), 17 deletions(-)

New commits:
commit ca5e875958882ed54b376535144e3fa0345f
Author: Noel Grandin 
AuthorDate: Wed Aug 12 10:35:01 2020 +0200
Commit: Noel Grandin 
CommitDate: Wed Aug 12 15:33:03 2020 +0200

expand out DELETEZ

Change-Id: I8691d7cedc340997284b1e8e9adae5f867c2d707
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100586
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/source/ui/Accessibility/AccessibleDocumentPagePreview.cxx 
b/sc/source/ui/Accessibility/AccessibleDocumentPagePreview.cxx
index ddbc8ecb5ab1..d7a9ebb5845a 100644
--- a/sc/source/ui/Accessibility/AccessibleDocumentPagePreview.cxx
+++ b/sc/source/ui/Accessibility/AccessibleDocumentPagePreview.cxx
@@ -125,23 +125,20 @@ ScNotesChildren::ScNotesChildren(ScPreviewShell* 
pViewShell, ScAccessibleDocumen
 {
 }
 
-namespace {
-
-struct DeleteAccNote
-{
-void operator()(ScAccNote& rNote)
-{
-if (rNote.mpTextHelper)
-DELETEZ( rNote.mpTextHelper);
-}
-};
-
-}
-
 ScNotesChildren::~ScNotesChildren()
 {
-std::for_each(maNotes.begin(), maNotes.end(), DeleteAccNote());
-std::for_each(maMarks.begin(), maMarks.end(), DeleteAccNote());
+for (auto & i : maNotes)
+if (i.mpTextHelper)
+{
+delete i.mpTextHelper;
+i.mpTextHelper = nullptr;
+}
+for (auto & i : maMarks)
+if (i.mpTextHelper)
+{
+delete i.mpTextHelper;
+i.mpTextHelper = nullptr;
+}
 }
 
 ::accessibility::AccessibleTextHelper* ScNotesChildren::CreateTextHelper(const 
OUString& rString, const tools::Rectangle& rVisRect, const ScAddress& aCellPos, 
bool bMarkNote, sal_Int32 nChildOffset) const
@@ -386,7 +383,8 @@ sal_Int32 ScNotesChildren::CheckChanges(const 
ScPreviewLocationData& rData,
 aNote.mnParaCount = 
aNote.mpTextHelper->GetChildCount();
 // collect removed children
 CollectChildren(*aItr, rOldParas);
-DELETEZ(aItr->mpTextHelper);
+delete aItr->mpTextHelper;
+aItr->mpTextHelper = nullptr;;
 // collect new children
 CollectChildren(aNote, rNewParas);
 }
@@ -408,7 +406,8 @@ sal_Int32 ScNotesChildren::CheckChanges(const 
ScPreviewLocationData& rData,
 {
 // collect removed children
 CollectChildren(*aItr, rOldParas);
-DELETEZ(aItr->mpTextHelper);
+delete aItr->mpTextHelper;
+aItr->mpTextHelper = nullptr;
 
 // no note to add
 // not necessary, because this branch should not be 
reached if it is the end
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-7.0.1.1'

2020-08-12 Thread Xisco Fauli (via logerrit)

Tag 'libreoffice-7.0.1.1' created by Xisco Fauli  
at 2020-08-12 13:22 +

Tag libreoffice-7.0.1.1
-BEGIN PGP SIGNATURE-

iQIzBAABCgAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAl8z7RMACgkQ9DSh76/u
rqMoJA//Zes6nkPr0kubcKTRaq7Hqo5LDAgnt0/jeivAMZ+9nze6UOirMitttQtA
GZQ640y3f6KfI4EALz7PKMYv4QtAYmhYr9RTXcfqBw/rBSjnEpsYcxjQeUt9/mZE
cMjhgyYX9NN5juI7kTHkblanT3yeMZGzRwyn2qGip69L7I3fn9JKA9Hf5DA/Ej2I
rkF25pRMe5wR1iO+GMQ4AHFQlGdv7JY5AAI2HoTMTnfo9K1nlvShc9ss8JpHi5Sv
Xv92woEiFbywYSCCZWcgGaP1InJZ5ko5j2p06foLtZE804+5lTBcI93X1iQA2/8S
MTebBcXeAY1kRmOhYp2xaGP66nHs/ZWmpQRUQverslSzCqAy8WK79YuHfcINbVWJ
30JfzXuCkPTkfgr53XWrIcmmbEEMGsBEZ+44Z7Uj+F722foxecALeD6DjiaKdqYA
bHIGhDZx29J9WGGN+oy3iN8jiJK+Ax2MU1n9LqHI1fQuYGl8+7sL5fpaitMkCbyI
vlPpHUTv8Sh1C/ZsTwzAp60TO2lqeyal8c/7/pGEiqxru/TErhYzwNb8ZmpNXvuU
Mf2wPORciW2zLfckDY7hdzCOWpyimjbt8GDug07GukNDkPKlTrhx6kBN/s/25M6b
Maz3kPANWPTjk6sGl/24CpUGaD/JZoAfu7HXOagG4F89WxJb1Ok=
=ocPE
-END PGP SIGNATURE-

Changes since libreoffice-7-0-branch-point-14:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-7.0.1.1'

2020-08-12 Thread Xisco Fauli (via logerrit)

Tag 'libreoffice-7.0.1.1' created by Xisco Fauli  
at 2020-08-12 13:22 +

Tag libreoffice-7.0.1.1
-BEGIN PGP SIGNATURE-

iQIzBAABCgAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAl8z7Q4ACgkQ9DSh76/u
rqNMyA//fw/a+4aEn9Lku7PZBf4hlgHwOhgm9b2FBI0egD82ysw97A6lZfPoUL1h
m7D4ggB1b7msRR+82FOMEGUxazTvRRomI/eZ7S7dAe0LivNO0NlaKDWATv6++jkV
CdG1Ff2fPf4YXRyKSx7hoDAeF9yv4BwReG1ng9svIKYtVRmAP82ArwQm9GR0F0AJ
FHYOkfdwMitoHVrNovbWiWb0y2hzrgmXO9l3TOpTcsxGpBsJa4Nyy+pkzTE2j3vO
ITZjJCnMDEfH8uulB6Ra8/szd5qwCXBSzDfDPU/ExCvdcmVivDNmxaFifVQtmJoi
AlzXW+3UIxkbynbgD6fOgUCyx1hGSgqH40sFuQ1Nt4XCRiNVcb/pnV6HPD/pHPBN
wWKi4YM6AnxcTf9koUED0bOhOYcLehap471aMkZIOXp+p/bbEIwVJvS03pZODJCD
tn25O5mUjkQ6tKCw+dPTYIaljbH/zpdDLo7apRY3bp8TbLkNKWVkDdKdJOgCJUkk
TOh4BenEd98mk6fox//KIO0m7KtmuYhIM0rS5DZP74ntz7hG2Ed7CatyfTOwzpZr
NPGGY9o6NMW/e/0XzKE71GMwcQSv0l+jPAdPQhFpgZouZvVglkRBHLijq3JhUaMk
zYqPjqTfaMMTIkkLiBZumfIEENdY12mWOjR6rGJlPOlTeLPFQxk=
=ZSSG
-END PGP SIGNATURE-

Changes since libreoffice-7-0-branch-point-7:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-7.0.1.1'

2020-08-12 Thread Xisco Fauli (via logerrit)

Tag 'libreoffice-7.0.1.1' created by Xisco Fauli  
at 2020-08-12 13:22 +

Tag libreoffice-7.0.1.1
-BEGIN PGP SIGNATURE-

iQIzBAABCgAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAl8z7RMACgkQ9DSh76/u
rqMaOBAAid+CRuQjHRkwgr3Oh2tbWUPr06/I13AjyrSTthfEO8l1AkJ723ri2ruu
1XGpAsftEQ0RiSCy+n3iTTQWGSubXnjjJOd8wNCInDYYbqsxawGliPDMlGFLY9CO
JxDhAMu+b39pFIkY20TTku2RCVoxErCbwjQrDrCfNf/7Uapd0zYiQk9vxSmZZEGp
MKQhzXVoMY9oX9mPJW27q8gz0zncqiGIHJE3wmJ+d211vpti5Y7KEkpNt4HXFDF2
L2CVcGu8kuUoEvbH8rtJucxXJVbCJuqPaU07yv+wWTNiNDEv6eYMoT9BqBg5NCWJ
T09hLCO7CARe88Q2L2Yb9FXHphgiMJlGMR+oBfrJsJtoGtfRzDvrg6FvTc4ZjOk2
aSPVVF3ZFhg2AdcHniCjr9sYB5f/dCR6ZRbHIPZSV0vbw4tn52NFCS198WVrVV0T
uW+I2LveyAasILZgwtMIZQy3iayOhx9nwD1+pL4U+uq/Ge41PUriOT/tkRxUuPLD
mYJ8FhQEYVCWgH0SJwokP3pMf01Xqp76JbXaj6boa2rqOv3B5sJhGo+skQgFHenA
ovZ374cM7X9S1bk7g4eKRaX2YC4gEs6ty0Xtws7r+cT5vc0Txkk/tAIdg57MzysS
PquNwZD9llRxTLyPZEy7mBRf2iA9R0G+ygOVLX8RqtQYKfGFDUE=
=4Nq3
-END PGP SIGNATURE-

Changes since libreoffice-7-0-branch-point-643:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0-1' - configure.ac

2020-08-12 Thread Xisco Fauli (via logerrit)

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2137516b5c877b09dd7e8cd1e9312b1efae66b87
Author: Xisco Fauli 
AuthorDate: Wed Aug 12 15:23:59 2020 +0200
Commit: Xisco Fauli 
CommitDate: Wed Aug 12 15:23:59 2020 +0200

bump product version to 7.0.1.1.0+

Change-Id: I7db012f5c380e28422f8c5930e06c8b5824f56c2

diff --git a/configure.ac b/configure.ac
index a233c332ee85..ce524142a1a6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[7.0.1.0.0+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[7.0.1.1.0+],[],[],[http://documentfoundation.org/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-7.0.1.1'

2020-08-12 Thread Xisco Fauli (via logerrit)

Tag 'libreoffice-7.0.1.1' created by Xisco Fauli  
at 2020-08-12 13:22 +

Tag libreoffice-7.0.1.1
-BEGIN PGP SIGNATURE-

iQIzBAABCgAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAl8z7RIACgkQ9DSh76/u
rqNLvBAAyah+KkpfAJaTthFiEuiYbS9AGyFHfAn5pxgkFaHkM4dr5fc4t0QVQGXc
v1QIRG+6sGvZkEk3ByDWHAgWvLxoY3q7T75XQecSWWItH9wHSKqlQQPxMHPgLXEg
XZp+qcMGC8AFfVOs7avCL4bIFP6QgSIZQFIPvAqqyVRKRchJqcU7hELfxtBK514e
t/PFpwbXKbzsI14TacR5NTDakCvlNZmVYvn1rvVC95d/8MbRY41aqcWfyDaugTbB
5fu5LCczvj/xiepTVZOV/UoqYubP5qvpLa86l/0f+43h7K7IaKyRfmOjLHmIgo6L
LIg5hCPovCSxjvz/anJM7//lKMmmxyH5Ky/ru6PN6KhM4O55Unv4P3v0pNWBRwOP
3dIgJFTOEvYeCrNYTiFaKwHTvQXR/Bt2EyS8bz1xDFeyht++dQOPtTl+DvFifM4F
vW2/cRBdZ/O475eKKslgbWSWBigYd6s/h7frZXkkbSUD1TrUls5dy1NqSNSYdQHa
lbKYYdP3Ftd0ciEYHibLcUabrKoFRHvWtoOV7CuAuki16bvRl2p+vNjfj+y5KEXg
YSB9np9Mhi8xad6xPRy0L9j4SYa6/tNjLhk+KqqGLau9XEkBIi1qzaXEycLkbUU/
XACuAjvVCQz37pS2L0XdPBeiFl3IAfz9/fJn/JawlvLUflAxh+E=
=F7zW
-END PGP SIGNATURE-

Changes since libreoffice-7-0-branch-point-72:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - configure.ac

2020-08-12 Thread Xisco Fauli (via logerrit)

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7f2984ddcc94fad6d54b763c90550399005aa871
Author: Xisco Fauli 
AuthorDate: Wed Aug 12 15:13:02 2020 +0200
Commit: Xisco Fauli 
CommitDate: Wed Aug 12 15:13:02 2020 +0200

bump product version to 7.0.2.0.0+

Change-Id: I06aa979751a6e8d17e48f863cfeb0c96d85bb013

diff --git a/configure.ac b/configure.ac
index a233c332ee85..0ffa7979dc39 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[7.0.1.0.0+],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[7.0.2.0.0+],[],[],[http://documentfoundation.org/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: contributing to LibreOffice

2020-08-12 Thread Ilmari Lauhakangas


On 11.8.2020 4.23, Sarfaraz Alam wrote:

Hello,
I am Sarfaraz Alam,a student of B.Tech 3rd year in computer science and 
engineering department.I looking forward to contribute in open source 
projects.How can I do it? Please guide me.


To get into development, start here:
https://wiki.documentfoundation.org/Development/GetInvolved

Build it, branch it, patch it, push it (sing to your favourite dance tune).

Ilmari
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Changes to 'libreoffice-7-0-1'

2020-08-12 Thread Xisco Fauli (via logerrit)

New branch 'libreoffice-7-0-1' available with the following commits:
commit d94e7be17a07d1b2fe73934bdd2865e68e343aa1
Author: Xisco Fauli 
Date:   Wed Aug 12 15:07:05 2020 +0200

Branch libreoffice-7-0-1

This is 'libreoffice-7-0-1' - the stable branch for the 7.0.1 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 7.0.x release,
please use the 'libreoffice-7-0' branch.

If you want to build something cool, unstable, and risky, use master.

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Changes to 'libreoffice-7-0-1'

2020-08-12 Thread Xisco Fauli (via logerrit)

New branch 'libreoffice-7-0-1' available with the following commits:
commit 7befdc52d146b8e80522e3ff5afa773cee5ed1a8
Author: Xisco Fauli 
Date:   Wed Aug 12 15:06:31 2020 +0200

Branch libreoffice-7-0-1

This is 'libreoffice-7-0-1' - the stable branch for the 7.0.1 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 7.0.x release,
please use the 'libreoffice-7-0' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: Icc7f8d7d83db5efb93d7dda7f17f90a5d38310a2

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: cypress_test/integration_tests

2020-08-12 Thread Tamás Zolnai (via logerrit)

 cypress_test/integration_tests/common/helper.js   |   20 
++--
 cypress_test/integration_tests/common/impress_helper.js   |3 
 cypress_test/integration_tests/desktop/calc/focus_spec.js |   14 
+--
 cypress_test/integration_tests/desktop/writer/form_field_spec.js  |   42 
-
 cypress_test/integration_tests/mobile/calc/alignment_options_spec.js  |3 
 cypress_test/integration_tests/mobile/calc/bottom_toolbar_spec.js |3 
 cypress_test/integration_tests/mobile/calc/calc_mobile_helper.js  |   36 
++--
 cypress_test/integration_tests/mobile/calc/focus_spec.js  |   20 
++--
 cypress_test/integration_tests/mobile/calc/spellchecking_spec.js  |3 
 cypress_test/integration_tests/mobile/impress/hamburger_menu_spec.js  |9 --
 cypress_test/integration_tests/mobile/impress/impress_focus_spec.js   |9 --
 cypress_test/integration_tests/mobile/impress/spellchecking_spec.js   |3 
 cypress_test/integration_tests/mobile/writer/focus_spec.js|9 --
 cypress_test/integration_tests/mobile/writer/hamburger_menu_spec.js   |   30 
++
 cypress_test/integration_tests/mobile/writer/insert_object_spec.js|   17 
+--
 cypress_test/integration_tests/mobile/writer/shape_properties_spec.js |9 +-
 cypress_test/integration_tests/mobile/writer/spellchecking_spec.js|3 
 cypress_test/integration_tests/mobile/writer/table_properties_spec.js |   45 
+-
 cypress_test/integration_tests/mobile/writer/toolbar_spec.js  |4 
 cypress_test/integration_tests/mobile/writer/writer_mobile_helper.js  |6 -
 20 files changed, 107 insertions(+), 181 deletions(-)

New commits:
commit dbe8502a5815e16198ac1de3f66eedb071fcbaa4
Author: Tamás Zolnai 
AuthorDate: Wed Aug 12 05:23:25 2020 +0200
Commit: Tamás Zolnai 
CommitDate: Wed Aug 12 14:59:30 2020 +0200

cypress: introduce typeIntoDocument helper method.

It was not consistent what we used to type into the
document (e.g. 'body', 'textarea.clipboard' or
'#document-container'). Also we need to use force
parameter because 'textarea.clipboard' has no actual area
which makes cypress fail with: '`cy.type()` failed because
the center of this element is hidden from view'.

Change-Id: I04e0a82ed8450d583e407715fde1855197cae109
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100574
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tamás Zolnai 

diff --git a/cypress_test/integration_tests/common/helper.js 
b/cypress_test/integration_tests/common/helper.js
index 7cfce8f9f..9853b7174 100644
--- a/cypress_test/integration_tests/common/helper.js
+++ b/cypress_test/integration_tests/common/helper.js
@@ -114,8 +114,7 @@ function selectAllText(assertFocus = true) {
cy.log('Select all text');
 
// Trigger select all
-   cy.get('textarea.clipboard')
-   .type('{ctrl}a');
+   typeIntoDocument('{ctrl}a');
 
cy.get('.leaflet-marker-icon')
.should('exist');
@@ -128,15 +127,13 @@ function clearAllText() {
cy.log('Clear all text');
 
// Trigger select all
-   cy.get('textarea.clipboard')
-   .type('{ctrl}a');
+   typeIntoDocument('{ctrl}a');
 
cy.get('.leaflet-marker-icon')
.should('exist');
 
// Then remove
-   cy.get('textarea.clipboard')
-   .type('{del}');
+   typeIntoDocument('{del}');
 
cy.get('.leaflet-marker-icon')
.should('not.exist');
@@ -427,10 +424,9 @@ function doIfOnDesktop(callback) {
});
 }
 
-function moveCursor(direction, forceType = false) {
+function moveCursor(direction) {
cy.log('Moving text cursor - start.');
cy.log('Param - direction: ' + direction);
-   cy.log('Param - forceType: ' + forceType);
 
initAliasToNegative('origCursorPos');
 
@@ -462,8 +458,7 @@ function moveCursor(direction, forceType = false) {
} else if (direction === 'right') {
key = '{rightarrow}';
}
-   cy.get('textarea.clipboard')
-   .type(key, {force : forceType});
+   typeIntoDocument(key);
 
cy.get('@origCursorPos')
.then(function(origCursorPos) {
@@ -484,6 +479,10 @@ function moveCursor(direction, forceType = false) {
cy.log('Moving text cursor - end.');
 }
 
+function typeIntoDocument(text) {
+   cy.get('textarea.clipboard')
+   .type(text, {force: true});
+}
 
 module.exports.loadTestDoc = loadTestDoc;
 module.exports.assertCursorAndFocus = assertCursorAndFocus;
@@ -509,3 +508,4 @@ module.exports.waitUntilIdle = waitUntilIdle;
 module.exports.doIfOnMobile = doIfOnMobile;
 module.exports.doIfOnDesktop = doIfOnDesktop;
 module.exports.moveCursor = moveCursor;
+module.exports.typeIntoDocument = typeIntoDocument;
diff --git a/cypress_test/integration_tests/common/impress_helper.js 
b/

[Libreoffice-commits] online.git: android/lib

2020-08-12 Thread Henry Castro (via logerrit)

 android/lib/build.gradle |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 8f394bdd548f27972fd264b793487e9cc9605542
Author: Henry Castro 
AuthorDate: Tue Aug 11 17:37:34 2020 -0400
Commit: Henry Castro 
CommitDate: Wed Aug 12 14:49:44 2020 +0200

android: fix build loleaflet assets

By default it is generated by automake,
but if someone wants to change manually,
do not forget to adjust this directory too.

Change-Id: I17e36364ac467d889e876be2995ef08e3c06da9e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100569
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Henry Castro 

diff --git a/android/lib/build.gradle b/android/lib/build.gradle
index 90fb964f5..bffb8d0db 100644
--- a/android/lib/build.gradle
+++ b/android/lib/build.gradle
@@ -296,11 +296,11 @@ preBuild.dependsOn 'createRCfiles',
 'copyBrandTheme'
 
 task generateLoleafletDebugAssets(type: Exec) {
-   commandLine 'make', '-C', '../../', 
"DIST_FOLDER=${project.getProjectDir()}/src/debug/assets/dist", 'BUNDLE=DEBUG'
+   commandLine 'make', '-C', 
"${rootProject.getBuildDir()}/../../loleaflet", 
"DIST_FOLDER=${project.getProjectDir()}/src/debug/assets/dist", 'BUNDLE=DEBUG'
 }
 
 task generateLoleafletReleaseAssets(type: Exec) {
-   commandLine 'make', '-C', '../../', 
"DIST_FOLDER=${project.getProjectDir()}/src/release/assets/dist", 
'BUNDLE=RELEASE'
+   commandLine 'make', '-C', 
"${rootProject.getBuildDir()}/../../loleaflet", 
"DIST_FOLDER=${project.getProjectDir()}/src/release/assets/dist", 
'BUNDLE=RELEASE'
 }
 
 afterEvaluate {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

2020-08-12 Thread Noel Grandin (via logerrit)

 sc/source/ui/Accessibility/AccessiblePreviewHeaderCell.cxx |   25 ++---
 sc/source/ui/inc/AccessiblePreviewHeaderCell.hxx   |2 -
 2 files changed, 13 insertions(+), 14 deletions(-)

New commits:
commit 05bf4b0a3af2e55501f8ce73cc97ca5e2caa54c2
Author: Noel Grandin 
AuthorDate: Wed Aug 12 10:29:35 2020 +0200
Commit: Noel Grandin 
CommitDate: Wed Aug 12 14:25:16 2020 +0200

fix leak in ScAccessiblePreviewHeaderCell

Change-Id: I0bafbe6d60980146006825229c0476fc22d1510f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100585
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/source/ui/Accessibility/AccessiblePreviewHeaderCell.cxx 
b/sc/source/ui/Accessibility/AccessiblePreviewHeaderCell.cxx
index 380b173d9845..ea6997331638 100644
--- a/sc/source/ui/Accessibility/AccessiblePreviewHeaderCell.cxx
+++ b/sc/source/ui/Accessibility/AccessiblePreviewHeaderCell.cxx
@@ -57,7 +57,6 @@ ScAccessiblePreviewHeaderCell::ScAccessiblePreviewHeaderCell( 
const css::uno::Re
 sal_Int32 nIndex ) :
 ScAccessibleContextBase( rxParent, AccessibleRole::TABLE_CELL ),
 mpViewShell( pViewShell ),
-mpTextHelper( nullptr ),
 mnIndex( nIndex ),
 maCellPos( rCellPos ),
 mbColumnHeader( bIsColHdr ),
@@ -94,8 +93,8 @@ void ScAccessiblePreviewHeaderCell::Notify( SfxBroadcaster& 
rBC, const SfxHint&
 const SfxHintId nId = rHint.GetId();
 if (nId == SfxHintId::ScAccVisAreaChanged)
 {
-if (mpTextHelper)
-mpTextHelper->UpdateChildren();
+if (mxTextHelper)
+mxTextHelper->UpdateChildren();
 }
 else if ( nId == SfxHintId::DataChanged )
 {
@@ -178,10 +177,10 @@ uno::Reference< XAccessible > SAL_CALL 
ScAccessiblePreviewHeaderCell::getAccessi
 SolarMutexGuard aGuard;
 IsObjectValid();
 
-if(!mpTextHelper)
+if(!mxTextHelper)
 CreateTextHelper();
 
-xRet = mpTextHelper->GetAt(rPoint);
+xRet = mxTextHelper->GetAt(rPoint);
 }
 
 return xRet;
@@ -205,18 +204,18 @@ sal_Int32 SAL_CALL 
ScAccessiblePreviewHeaderCell::getAccessibleChildCount()
 {
 SolarMutexGuard aGuard;
 IsObjectValid();
-if (!mpTextHelper)
+if (!mxTextHelper)
 CreateTextHelper();
-return mpTextHelper->GetChildCount();
+return mxTextHelper->GetChildCount();
 }
 
 uno::Reference< XAccessible > SAL_CALL 
ScAccessiblePreviewHeaderCell::getAccessibleChild(sal_Int32 nIndex)
 {
 SolarMutexGuard aGuard;
 IsObjectValid();
-if (!mpTextHelper)
+if (!mxTextHelper)
 CreateTextHelper();
-return mpTextHelper->GetChild(nIndex);
+return mxTextHelper->GetChild(nIndex);
 }
 
 sal_Int32 SAL_CALL ScAccessiblePreviewHeaderCell::getAccessibleIndexInParent()
@@ -377,14 +376,14 @@ bool ScAccessiblePreviewHeaderCell::IsDefunc( const 
uno::Reference(
 std::make_unique(
 mpViewShell, getAccessibleName(), maCellPos,
-mbColumnHeader, mbRowHeader)));
-mpTextHelper->SetEventSource(this);
+mbColumnHeader, mbRowHeader))) );
+mxTextHelper->SetEventSource(this);
 }
 }
 
diff --git a/sc/source/ui/inc/AccessiblePreviewHeaderCell.hxx 
b/sc/source/ui/inc/AccessiblePreviewHeaderCell.hxx
index 7af796fb6563..e18c7eb54a6b 100644
--- a/sc/source/ui/inc/AccessiblePreviewHeaderCell.hxx
+++ b/sc/source/ui/inc/AccessiblePreviewHeaderCell.hxx
@@ -113,7 +113,7 @@ protected:
 
 private:
 ScPreviewShell* mpViewShell;
-accessibility::AccessibleTextHelper* mpTextHelper;
+std::unique_ptr mxTextHelper;
 sal_Int32   mnIndex;
 ScAddress   maCellPos;
 boolmbColumnHeader;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2020-08-12 Thread Henry Castro (via logerrit)

 loleaflet/src/control/Control.PartsPreview.js |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 9c2bb127611b8653c963816c2f76794455bef682
Author: Henry Castro 
AuthorDate: Tue Aug 11 15:47:36 2020 -0400
Commit: Henry Castro 
CommitDate: Wed Aug 12 14:01:24 2020 +0200

Revert "Keep slide sorter in line on mobile devices"

This is no longer need it because the orientation is manual
changed, adding or removing class styles and the patches
below were added to adapt the new changes

This reverts commit 69c21d5bb4d084cb8abc38b4176c8b40f12c8490.
Change-Id: I70aee6b569f78795487cbff736130e0e74165432
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100564
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Henry Castro 
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100592
Tested-by: Jenkins

diff --git a/loleaflet/src/control/Control.PartsPreview.js 
b/loleaflet/src/control/Control.PartsPreview.js
index da01e151d..7d4648f7d 100644
--- a/loleaflet/src/control/Control.PartsPreview.js
+++ b/loleaflet/src/control/Control.PartsPreview.js
@@ -111,7 +111,6 @@ L.Control.PartsPreview = L.Control.extend({
}, this);
 
this._scrollContainer = 
$(this._partsPreviewCont).find('.mCSB_container').get(0);
-   $(this._scrollContainer).css('display', 
'inline-table');
 
// Add a special frame just as a drop-site for 
reordering.
var frameClass = 'preview-frame ' + 
this.options.frameClass;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

2020-08-12 Thread Noel Grandin (via logerrit)

 sc/source/ui/dbgui/dbnamdlg.cxx |   22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)

New commits:
commit 537693e57281f1129ae837a569d88ceff44425b0
Author: Noel Grandin 
AuthorDate: Wed Aug 12 10:19:44 2020 +0200
Commit: Noel Grandin 
CommitDate: Wed Aug 12 13:39:23 2020 +0200

use unique_ptr in ScDbNameDlg

Change-Id: Id6e6b452ef1e3254a4a995eea0a2ca89f54019bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100584
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/source/ui/dbgui/dbnamdlg.cxx b/sc/source/ui/dbgui/dbnamdlg.cxx
index 07515d0914d0..915dbe1adda0 100644
--- a/sc/source/ui/dbgui/dbnamdlg.cxx
+++ b/sc/source/ui/dbgui/dbnamdlg.cxx
@@ -42,7 +42,7 @@ class DBSaveData;
 
 }
 
-static DBSaveData* pSaveObj = nullptr;
+static std::unique_ptr xSaveObj;
 
 namespace
 {
@@ -167,14 +167,14 @@ ScDbNameDlg::ScDbNameDlg(SfxBindings* pB, SfxChildWindow* 
pCW, weld::Window* pPa
 aStrSource  = m_xFTSource->get_label();
 aStrOperations  = m_xFTOperations->get_label();
 
-pSaveObj = new DBSaveData( *m_xEdAssign, *m_xBtnHeader, *m_xBtnTotals,
-*m_xBtnDoSize, *m_xBtnKeepFmt, *m_xBtnStripData, 
theCurArea );
+xSaveObj.reset(new DBSaveData( *m_xEdAssign, *m_xBtnHeader, *m_xBtnTotals,
+*m_xBtnDoSize, *m_xBtnKeepFmt, *m_xBtnStripData, 
theCurArea ));
 Init();
 }
 
 ScDbNameDlg::~ScDbNameDlg()
 {
-DELETEZ( pSaveObj );
+xSaveObj.reset();
 }
 
 void ScDbNameDlg::Init()
@@ -251,7 +251,7 @@ void ScDbNameDlg::Init()
 m_xEdAssign->SetText( theAreaStr );
 m_xEdName->grab_focus();
 bSaved = true;
-pSaveObj->Save();
+xSaveObj->Save();
 NameModifyHdl( *m_xEdName );
 }
 
@@ -293,7 +293,7 @@ void ScDbNameDlg::SetReference( const ScRange& rRef, 
ScDocument& rDocP )
 m_xOptions->set_sensitive(true);
 m_xBtnAdd->set_sensitive(true);
 bSaved = true;
-pSaveObj->Save();
+xSaveObj->Save();
 }
 
 void ScDbNameDlg::Close()
@@ -465,7 +465,7 @@ IMPL_LINK_NOARG(ScDbNameDlg, AddBtnHdl, weld::Button&, void)
 SetInfoStrings( nullptr ); // empty
 theCurArea = ScRange();
 bSaved = true;
-pSaveObj->Save();
+xSaveObj->Save();
 NameModifyHdl( *m_xEdName );
 }
 else
@@ -542,7 +542,7 @@ IMPL_LINK_NOARG(ScDbNameDlg, RemoveBtnHdl, weld::Button&, 
void)
 m_xBtnStripData->set_active( false );
 SetInfoStrings( nullptr ); // empty
 bSaved=false;
-pSaveObj->Restore();
+xSaveObj->Restore();
 NameModifyHdl( *m_xEdName );
 }
 
@@ -560,7 +560,7 @@ IMPL_LINK_NOARG(ScDbNameDlg, NameModifyHdl, 
weld::ComboBox&, void)
 m_xAssignFrame->set_sensitive(false);
 m_xOptions->set_sensitive(false);
 //bSaved=sal_False;
-//pSaveObj->Restore();
+//xSaveObj->Restore();
 //@BugID 54702 enable/disable in the base class only
 //SFX_APPWINDOW->Disable(sal_False);//! general method in 
ScAnyRefDlg
 bRefInputMode = false;
@@ -575,7 +575,7 @@ IMPL_LINK_NOARG(ScDbNameDlg, NameModifyHdl, 
weld::ComboBox&, void)
 if(!bSaved)
 {
 bSaved = true;
-pSaveObj->Save();
+xSaveObj->Save();
 }
 UpdateDBData( theName );
 }
@@ -585,7 +585,7 @@ IMPL_LINK_NOARG(ScDbNameDlg, NameModifyHdl, 
weld::ComboBox&, void)
 m_xBtnAdd->set_label( aStrAdd );
 
 bSaved=false;
-pSaveObj->Restore();
+xSaveObj->Restore();
 
 if ( !m_xEdAssign->GetText().isEmpty() )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: android/lib

2020-08-12 Thread Henry Castro (via logerrit)

 android/lib/src/main/cpp/CMakeLists.txt.in |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit b6520bdaeb23f66a951a9458594f1c8bfc900093
Author: Henry Castro 
AuthorDate: Tue Aug 11 17:35:05 2020 -0400
Commit: Henry Castro 
CommitDate: Wed Aug 12 13:38:30 2020 +0200

android: fix the include directories when builddir != srcdir

Change-Id: I81e823354129c510c43d606f0e56f0cbf92c5eef
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100568
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Henry Castro 

diff --git a/android/lib/src/main/cpp/CMakeLists.txt.in 
b/android/lib/src/main/cpp/CMakeLists.txt.in
index 4c4e1344a..2a9fc36b0 100644
--- a/android/lib/src/main/cpp/CMakeLists.txt.in
+++ b/android/lib/src/main/cpp/CMakeLists.txt.in
@@ -52,7 +52,8 @@ set(LIBLO_NATIVE_CODE 
${LOBUILDDIR_ABI}/android/jniLibs/${ANDROID_ABI}/liblo-nat
 
 target_include_directories(androidapp PRIVATE
. # path to androidapp.h
-   ../../../../..# path to config.h
+  @abs_top_builddir@# path to config.h
+  @abs_top_srcdir@
../../../../../common # the needed loolwsd includes
../../../../../kit
../../../../../net
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/co-4-2' - loleaflet/src

2020-08-12 Thread Szymon Kłos (via logerrit)

 loleaflet/src/layer/tile/CalcTileLayer.js |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit ad13235f446368a3150efdedb42659429116e07b
Author: Szymon Kłos 
AuthorDate: Wed Aug 12 10:16:54 2020 +0200
Commit: Jan Holesovsky 
CommitDate: Wed Aug 12 13:23:25 2020 +0200

Show avatar for newly inserted comments in calc

Change-Id: If602901982e8084856ca5361ab256a93e1045e45
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100581
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Jan Holesovsky 

diff --git a/loleaflet/src/layer/tile/CalcTileLayer.js 
b/loleaflet/src/layer/tile/CalcTileLayer.js
index c636d04ca..4bf197b85 100644
--- a/loleaflet/src/layer/tile/CalcTileLayer.js
+++ b/loleaflet/src/layer/tile/CalcTileLayer.js
@@ -237,6 +237,9 @@ L.CalcTileLayer = L.TileLayer.extend({
var obj = 
JSON.parse(textMsg.substring('comment:'.length + 1));
obj.comment.tab = parseInt(obj.comment.tab);
if (obj.comment.action === 'Add') {
+   if (obj.comment.author in 
this._map._viewInfoByUserName) {
+   obj.comment.avatar = 
this._map._viewInfoByUserName[obj.comment.author].userextrainfo.avatar;
+   }
obj.comment.cellPos = 
L.LOUtil.stringToBounds(obj.comment.cellPos);
obj.comment.cellPos = 
L.latLngBounds(this._twipsToLatLng(obj.comment.cellPos.getBottomLeft()),

this._twipsToLatLng(obj.comment.cellPos.getTopRight()));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: xmloff/CppunitTest_xmloff_draw.mk xmloff/Module_xmloff.mk xmloff/qa xmloff/source

2020-08-12 Thread Miklos Vajna (via logerrit)

 xmloff/CppunitTest_xmloff_draw.mk |   45 +++
 xmloff/Module_xmloff.mk   |1 
 xmloff/qa/unit/data/textbox-loss.docx |binary
 xmloff/qa/unit/draw.cxx   |   79 ++
 xmloff/source/draw/shapeexport.cxx|   14 --
 5 files changed, 127 insertions(+), 12 deletions(-)

New commits:
commit 347d05edd8910907ae185c61c1e56eee139b3c09
Author: Miklos Vajna 
AuthorDate: Wed Aug 12 09:06:14 2020 +0200
Commit: Miklos Vajna 
CommitDate: Wed Aug 12 13:18:55 2020 +0200

tdf#135144 xmloff textbox: fix export style name to be consitent with import

Regression from commit 28d67b792724a23015dec32fb0278b729f676736
(tdf#107776 sw ODF shape import: make is-textbox check more strict,
2019-08-26), the problem was that in case the import side in
SdXMLCustomShapeContext expects a fixed "Frame" parent style name, then
the export side should go with that name as well.

Fix the problem by simplifying XMLShapeExport::collectShapeAutoStyles(),
which initially assumed that the string may be localized, so try to look
it up: instead just use the fixed string that the import side will look
for.

This solves all problem which may stem from a parent style name which is
non-empty, but other than Frame.

Change-Id: I8146440c591d3dd5a904d243d85741d704711e9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100577
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/xmloff/CppunitTest_xmloff_draw.mk 
b/xmloff/CppunitTest_xmloff_draw.mk
new file mode 100644
index ..4ebac5c27a3b
--- /dev/null
+++ b/xmloff/CppunitTest_xmloff_draw.mk
@@ -0,0 +1,45 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#*
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+#*
+
+$(eval $(call gb_CppunitTest_CppunitTest,xmloff_draw))
+
+$(eval $(call gb_CppunitTest_use_externals,xmloff_draw,\
+   boost_headers \
+))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,xmloff_draw, \
+xmloff/qa/unit/draw \
+))
+
+$(eval $(call gb_CppunitTest_use_libraries,xmloff_draw, \
+comphelper \
+cppu \
+embobj \
+sal \
+test \
+unotest \
+utl \
+))
+
+$(eval $(call gb_CppunitTest_use_sdk_api,xmloff_draw))
+
+$(eval $(call gb_CppunitTest_use_ure,xmloff_draw))
+$(eval $(call gb_CppunitTest_use_vcl,xmloff_draw))
+
+$(eval $(call gb_CppunitTest_use_rdb,xmloff_draw,services))
+
+$(eval $(call gb_CppunitTest_use_custom_headers,xmloff_draw,\
+   officecfg/registry \
+))
+
+$(eval $(call gb_CppunitTest_use_configuration,xmloff_draw))
+
+# vim: set noet sw=4 ts=4:
diff --git a/xmloff/Module_xmloff.mk b/xmloff/Module_xmloff.mk
index fe69b86b09f6..8f5853c9da41 100644
--- a/xmloff/Module_xmloff.mk
+++ b/xmloff/Module_xmloff.mk
@@ -31,6 +31,7 @@ $(eval $(call gb_Module_add_check_targets,xmloff,\
CppunitTest_xmloff_uxmloff) \
CppunitTest_xmloff_style \
CppunitTest_xmloff_text \
+   CppunitTest_xmloff_draw \
 ))
 
 $(eval $(call gb_Module_add_subsequentcheck_targets,xmloff,\
diff --git a/xmloff/qa/unit/data/textbox-loss.docx 
b/xmloff/qa/unit/data/textbox-loss.docx
new file mode 100644
index ..9190e662f851
Binary files /dev/null and b/xmloff/qa/unit/data/textbox-loss.docx differ
diff --git a/xmloff/qa/unit/draw.cxx b/xmloff/qa/unit/draw.cxx
new file mode 100644
index ..afffa65354e0
--- /dev/null
+++ b/xmloff/qa/unit/draw.cxx
@@ -0,0 +1,79 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+
+using namespace ::com::sun::star;
+
+char const DATA_DIRECTORY[] = "/xmloff/qa/unit/data/";
+
+/// Covers xmloff/source/draw/ fixes.
+class XmloffDrawTest : public test::BootstrapFixture, public 
unotest::MacrosTest
+{
+private:
+uno::Reference mxComponent;
+
+public:
+void setUp() override;
+void tearDown() override;
+uno::Reference& getComponent() { return mxComponent; }
+};
+
+void XmloffDrawTest::setUp()
+{
+test::BootstrapFixture::setUp();
+
+mxDesktop.set(frame::Desktop::create(mxComponentContext));
+}
+
+void XmloffDrawTest::tearDown()
+{
+if (mxComponent.is())
+mxComponent->dispose();
+
+test::BootstrapFixture::tearDown();
+}

[Libreoffice-commits] core.git: vcl/source

2020-08-12 Thread Noel Grandin (via logerrit)

 vcl/source/app/scheduler.cxx |3 ++-
 vcl/source/treelist/svimpbox.cxx |6 --
 2 files changed, 6 insertions(+), 3 deletions(-)

New commits:
commit d837fb6ce95a598627c4863bb7d99e827d5309f7
Author: Noel Grandin 
AuthorDate: Wed Aug 12 10:41:58 2020 +0200
Commit: Noel Grandin 
CommitDate: Wed Aug 12 13:11:47 2020 +0200

expand out DELETEZ in vcl

Change-Id: Ibcaef8c5dd057cb9b1711440e5f9da43817078f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100587
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/vcl/source/app/scheduler.cxx b/vcl/source/app/scheduler.cxx
index fa18087e9fd8..e8ad527ec949 100644
--- a/vcl/source/app/scheduler.cxx
+++ b/vcl/source/app/scheduler.cxx
@@ -132,7 +132,8 @@ void Scheduler::ImplDeInitScheduler()
 assert( 1 == rSchedCtx.maMutex.lockDepth() );
 
 if (rSchedCtx.mpSalTimer) rSchedCtx.mpSalTimer->Stop();
-DELETEZ( rSchedCtx.mpSalTimer );
+delete rSchedCtx.mpSalTimer;
+rSchedCtx.mpSalTimer = nullptr;
 
 #if OSL_DEBUG_LEVEL > 0
 sal_uInt32 nActiveTasks = 0, nIgnoredTasks = 0;
diff --git a/vcl/source/treelist/svimpbox.cxx b/vcl/source/treelist/svimpbox.cxx
index 22a03342e153..2b4ed138305c 100644
--- a/vcl/source/treelist/svimpbox.cxx
+++ b/vcl/source/treelist/svimpbox.cxx
@@ -116,8 +116,10 @@ SvImpLBox::~SvImpLBox()
 
 if ( osl_atomic_decrement(&s_nImageRefCount) == 0 )
 {
-DELETEZ(s_pDefCollapsed);
-DELETEZ(s_pDefExpanded);
+delete s_pDefCollapsed;
+s_pDefCollapsed = nullptr;
+delete s_pDefExpanded;
+s_pDefExpanded = nullptr;
 }
 m_aVerSBar.disposeAndClear();
 m_aHorSBar.disposeAndClear();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: android/build.gradle.in

2020-08-12 Thread Henry Castro (via logerrit)

 android/build.gradle.in |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0a096fb4ad39a1bb0c633f8b18bbb6d9414e4de7
Author: Henry Castro 
AuthorDate: Tue Aug 11 17:30:26 2020 -0400
Commit: Henry Castro 
CommitDate: Wed Aug 12 13:10:02 2020 +0200

android: fix build when changing the build output directory

It happens when redirecting all the build output
to a specific directory

Change-Id: I084d35be1c72bd319515d642ddf5b4607f42cf6b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100567
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Henry Castro 

diff --git a/android/build.gradle.in b/android/build.gradle.in
index fd2b2fc5e..4552f6897 100644
--- a/android/build.gradle.in
+++ b/android/build.gradle.in
@@ -1,5 +1,5 @@
 // Top-level build file where you can add configuration options common to all 
sub-projects/modules.
-buildDir = "@builddir@/build"
+buildDir = "@abs_top_builddir@/android/build"
 
 buildscript {
 repositories {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Unclear string to translate in inspectorproperties.hrc

2020-08-12 Thread Milos Sramek

Thank you, Mike & Shivam, for explanation.
We should probably translate the strings in a similar cryptic way.

The inspector pane is not displayed (I have the most recent build), so
I'll wait for a fix.

thanks
Milos


On 8/12/20 12:04 PM, Mike Kaganski wrote:
> Hi,
>
> On 12.08.2020 12:52, Milos Sramek wrote:
>> we got for translation 200+ new strings, which are located in file
>> inspectorproperties.hrc and seem to be related to the Style Inspector
>> sidebar deck.
>>
>> These strings are not full sentences and seem to have a certain logic
>> structure, for example
>>
>> Fill Bitmap Rectangle Point
>> Char Interoperability Grab Bag
>> Char Weight Complex
>>
>> So, we do not know, how to translate them. Should they be translated at all?
>>
> Basically answered in i10n mailing list; citing here:
>
>
>> Some background.
>>
>> These strings are related to the Styles Inspector - a GSoC project,
>> being implemented by Shivam Kumar Singh
>> (https://bugs.documentfoundation.org/show_bug.cgi?id=134554). The
>> inspector is already available in Experimental mode (see comment 2 in
>> the meta issue).
>>
>> The Inspector presents a detailed low-level view of properties applied
>> at the cursor. As such, it shows the multitude of attributes applied to
>> text (or other object in the future); most these attributes have their
>> names in multiple dialogs throughout the UI, but this is the first time
>> when all of them need to be named in a single place. And translation in
>> dialogs can not be used directly, e.g. because the translation there in
>> dialogs may use context absent in the Inspector.
>>
>> One possible improvement could be to provide a hint somehow near the IDs
>> in inspectorproperties.hrc, where known/possible, to the related strings
>> in the dialogs/other UI parts, to help translators understand what this
>> item is about. But that's a separate task/TODO: the current work on
>> Inspector does not consider dialogs; the Inspector is created based on
>> the properties available using UNO API, and thus Shivam does not know
>> where the items are located in existing UI. (This is to clarify that
>> there's no information already used by developers, potentially useful to
>> translation, that was somehow lost during development.)
>>
>> The names that Shivam has put there are possibly somewhat "cryptic"
>> exactly because of the mentioned specifics: the names are mostly the API
>> names, which were split by CamelCase to produce strings like "Char
>> Weight Complex", intended to be used in context of table like
>>
>> Char Interoperability Grab Bag"some string"
>>
>> Char Weight Complex10
>>
>> So the mentioned TODO would also allow to gradually find the existing
>> names of the attributes, and make them consistent in the Inspector.
>
>
> Milos Sramek wrote:
>> Currently, I can see only two items in Style Inspector sidebar deck in
>> Writer
>> Font name
>> Font size
>>
>> In the file inspectorproperties.hrc there is
>> "Char Font Name"
>> but no
>> "Char Font Size"
>>
>> Are the strings, which i can see in the Inspector, derived somehow from
>> the strings in  inspectorproperties.hrc?
>>
> You obviously look somewhere else. The Inspector looks like this:
> https://imgur.com/xu2Wvh2
> You might need to move cursor/type something for the initially empty
> deck to initialize (a bug).
>
> Note that there are exactly "Char Font Name" and "Char Font Height", but
> no "Font name" or "Font size" currently.
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice


-- 
Milos Sramek, msrame...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Styles Inspector Week 10 Report

2020-08-12 Thread Shivam Kumar Singh

Hi,

Sorry for sending the report a bit late, I was waiting for an under review
patch to get merged.
Work Done :-
* The Inspector panel's predefined sizing led to a vertical scroll bar
inside the sidebar's vertical sidebar. Resolved at tdf#135344
* Set Ellipsize for proper viewing of properties in Inspector
* All the "Border" related properties are stored in STRUCT in UNO API,
Added support to view them properly in the Inspector
* Fixed LO crash when using a macro with Inspector enabled. tdf#135528
tdf#135491. MERGED

To Do -
* Make a uno command to launch Inspector
* Start writing documentation of SI on a new page in LibreOffice's Wiki.

The Styles Inspector is in a very good shape for testing. I request
everyone to use the panel and list any bugs found or feature requests on
Meta tdf#134554.
The Inspector can be accessed from the sidebar.
Thank you!

sincerely,
Shivam Kumar Singh
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] help.git: Changes to 'libreoffice-7-0-1'

2020-08-12 Thread Xisco Fauli (via logerrit)

New branch 'libreoffice-7-0-1' available with the following commits:
commit 9ca3d511f79f654cbcf761041c1a799d402e1052
Author: Xisco Fauli 
Date:   Wed Aug 12 12:14:34 2020 +0200

Branch libreoffice-7-0-1

This is 'libreoffice-7-0-1' - the stable branch for the 7.0.1 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 7.0.x release,
please use the 'libreoffice-7-0' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: Id1af535a19381584438ecdc5e4c1f0b9a662ce6e

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'libreoffice-7-0-1'

2020-08-12 Thread Xisco Fauli (via logerrit)

New branch 'libreoffice-7-0-1' available with the following commits:
commit 50eac7f2d73b58035a9a420d13d03b2ae789405f
Author: Xisco Fauli 
Date:   Wed Aug 12 12:14:34 2020 +0200

Branch libreoffice-7-0-1

This is 'libreoffice-7-0-1' - the stable branch for the 7.0.1 release.
Only very safe changes, reviewed by three people are allowed.

If you want to commit more complicated fix for the next 7.0.x release,
please use the 'libreoffice-7-0' branch.

If you want to build something cool, unstable, and risky, use master.

Change-Id: Id1af535a19381584438ecdc5e4c1f0b9a662ce6e

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Unclear string to translate in inspectorproperties.hrc

2020-08-12 Thread Shivam Kumar Singh

On Wed, 12 Aug 2020 at 15:22, Milos Sramek  wrote:

> Hi,
> Currently, I can see only two items in Style Inspector sidebar deck in
> Writer
> Font name
> Font size
>
Are you sure your local codebase is updated ?


>
In the file inspectorproperties.hrc there is
> "Char Font Name"
> but no
> "Char Font Size"
>
You can find "Char Font Name" and "Char Height" in inspectorproperties.hrc .


> Are the strings, which i can see in the Inspector, derived somehow from
> the strings in  inspectorproperties.hrc?
>
> Thanks
> Milos
>
>
> On 8/4/20 7:59 AM, Shivam Kumar Singh wrote:
>
> Hi,
>
> Work Done this week :-
> * tdf#135178 tdf#135179 tdf#134820 SetChgLink was not correctly called and
> used which led to crash on moving the cursor to different images or charts.
> This issue was fixed, MERGED
> * tdf#134831 The SI would expand only to 2/3rd of the sidebar though its
> expected to expand to the whole length. This change was fixed and merged.
> * tdf#134560 tdf#135107 Previously the API names for the properties were
> shown in the SI, which was not very easy to understand. These properties
> are now human-readable and translatable wrt UI language. MERGED
>
> To Do for this week :-
> * Add color boxes to "Color" properties tdf#134561
> * Some ui issues still exist relating to the scroll bars. This should be
> fixed within this week tdf#135344
> * Add a way to also display properties which are stored in structs in the
> UNO API tdf#135406
>
> All the bugs are being listed at META tdf#134554, It would be great help
> if more number of people use the SI and report any bugs experienced or
> confirm the already listed unconfirmed ones.
>
> Thank you Mike, Heiko and Tomaz for their continuous guidance :)
>
> sincerely,
> Shivam Kumar Singh
>
> ___
> LibreOffice mailing 
> listLibreOffice@lists.freedesktop.orghttps://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>
> --
> Milos Sramek, msrame...@gmail.com
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Beware dated Gerrit changes

2020-08-12 Thread Guilhem Moulin

On Fri, 07 Aug 2020 at 14:39:29 +, Stephan Bergmann:
> As a corollary, when creating a Gerrit change, make sure the change's 
> parent is sufficiently recent to begin with.  Pull early, pull often.

A nice side-effect of doing that is that it'll update refs/remotes/logerrit/…
references (like `git fetch` or `git remote update`) which appears to
significantly reduce the amount of data to upload when running `git push`.
https://listarchives.libreoffice.org/global/website/msg15794.html

-- 
Guilhem.

PS. Sorry for breaking the thread, I don't have the Message-Id at hand.


signature.asc
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/source

2020-08-12 Thread Shivam Kumar Singh (via logerrit)

 sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a2f226d63e88f2c6ba6771b37a7039c82e3d0001
Author: Shivam Kumar Singh 
AuthorDate: Tue Aug 11 18:25:39 2020 +0530
Commit: Mike Kaganski 
CommitDate: Wed Aug 12 12:07:43 2020 +0200

tdf#135528 tdf#135491 Fix LO crash when using macro with SI enabled

WriterInspectorTextPanel.cxx tries to work on the current shell
which might change everytime. This patch uses the original shell
stored in m_pWrtShell to get the current DocShell.

Change-Id: I243e7346b748ca81041016f526b6d4da7861f7bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100493
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx 
b/sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx
index 7c10f757edbc..bbb018bfcc72 100644
--- a/sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx
+++ b/sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx
@@ -501,7 +501,7 @@ IMPL_LINK(WriterInspectorTextPanel, AttrChangedNotify, 
LinkParamNone*, pLink, vo
 if (m_oldLink.IsSet())
 m_oldLink.Call(pLink);
 
-SwDocShell* pDocSh = static_cast(SfxObjectShell::Current());
+SwDocShell* pDocSh = m_pShell->GetDoc()->GetDocShell();
 std::vector aStore;
 
 if (pDocSh && 
pDocSh->GetDoc()->GetEditShell()->GetCursor()->GetNode().GetTextNode())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Unclear string to translate in inspectorproperties.hrc

2020-08-12 Thread Mike Kaganski

Hi,

On 12.08.2020 12:52, Milos Sramek wrote:
> we got for translation 200+ new strings, which are located in file
> inspectorproperties.hrc and seem to be related to the Style Inspector
> sidebar deck.
> 
> These strings are not full sentences and seem to have a certain logic
> structure, for example
> 
> Fill Bitmap Rectangle Point
> Char Interoperability Grab Bag
> Char Weight Complex
> 
> So, we do not know, how to translate them. Should they be translated at all?
> 

Basically answered in i10n mailing list; citing here:


> Some background.
> 
> These strings are related to the Styles Inspector - a GSoC project,
> being implemented by Shivam Kumar Singh
> (https://bugs.documentfoundation.org/show_bug.cgi?id=134554). The
> inspector is already available in Experimental mode (see comment 2 in
> the meta issue).
> 
> The Inspector presents a detailed low-level view of properties applied
> at the cursor. As such, it shows the multitude of attributes applied to
> text (or other object in the future); most these attributes have their
> names in multiple dialogs throughout the UI, but this is the first time
> when all of them need to be named in a single place. And translation in
> dialogs can not be used directly, e.g. because the translation there in
> dialogs may use context absent in the Inspector.
> 
> One possible improvement could be to provide a hint somehow near the IDs
> in inspectorproperties.hrc, where known/possible, to the related strings
> in the dialogs/other UI parts, to help translators understand what this
> item is about. But that's a separate task/TODO: the current work on
> Inspector does not consider dialogs; the Inspector is created based on
> the properties available using UNO API, and thus Shivam does not know
> where the items are located in existing UI. (This is to clarify that
> there's no information already used by developers, potentially useful to
> translation, that was somehow lost during development.)
> 
> The names that Shivam has put there are possibly somewhat "cryptic"
> exactly because of the mentioned specifics: the names are mostly the API
> names, which were split by CamelCase to produce strings like "Char
> Weight Complex", intended to be used in context of table like
> 
> Char Interoperability Grab Bag"some string"
> 
> Char Weight Complex10
> 
> So the mentioned TODO would also allow to gradually find the existing
> names of the attributes, and make them consistent in the Inspector.



Milos Sramek wrote:
> Currently, I can see only two items in Style Inspector sidebar deck in
> Writer
> Font name
> Font size
> 
> In the file inspectorproperties.hrc there is
> "Char Font Name"
> but no
> "Char Font Size"
> 
> Are the strings, which i can see in the Inspector, derived somehow from
> the strings in  inspectorproperties.hrc?
> 

You obviously look somewhere else. The Inspector looks like this:
https://imgur.com/xu2Wvh2
You might need to move cursor/type something for the initially empty
deck to initialize (a bug).

Note that there are exactly "Char Font Name" and "Char Font Height", but
no "Font name" or "Font size" currently.

-- 
Best regards,
Mike Kaganski


pEpkey.asc
Description: application/pgp-keys
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - vcl/unx

2020-08-12 Thread Caolán McNamara (via logerrit)

 vcl/unx/gtk3/gtk3gtkinst.cxx |   35 +--
 1 file changed, 29 insertions(+), 6 deletions(-)

New commits:
commit cc36d48b0e8f1aec3f8120db5d249e74587e92fd
Author: Caolán McNamara 
AuthorDate: Tue Aug 11 15:12:59 2020 +0100
Commit: Xisco Fauli 
CommitDate: Wed Aug 12 12:03:25 2020 +0200

unset CustomCellRenderer instances in dtor

Change-Id: I60a5f91df65d1d511ba863ba9a0286c1483314d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100513
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index b8f1b66c4b49..c399eaf1a356 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -5296,6 +5296,7 @@ GType crippled_viewport_get_type()
 
 #define CUSTOM_TYPE_CELL_RENDERER_SURFACE 
(custom_cell_renderer_surface_get_type())
 #define CUSTOM_CELL_RENDERER_SURFACE(obj) 
(G_TYPE_CHECK_INSTANCE_CAST((obj),  CUSTOM_TYPE_CELL_RENDERER_SURFACE, 
CustomCellRendererSurface))
+#define CUSTOM_IS_CELL_RENDERER_SURFACE(obj)  
(G_TYPE_CHECK_INSTANCE_TYPE ((obj), CUSTOM_TYPE_CELL_RENDERER_SURFACE))
 
 namespace {
 
@@ -11403,11 +11404,26 @@ public:
 g_signal_handler_disconnect(m_pTreeView, m_nRowActivatedSignalId);
 g_signal_handler_disconnect(gtk_tree_view_get_selection(m_pTreeView), 
m_nChangedSignalId);
 
+GValue value = G_VALUE_INIT;
+g_value_init(&value, G_TYPE_POINTER);
+g_value_set_pointer(&value, static_cast(nullptr));
+
 for (GList* pEntry = g_list_last(m_pColumns); pEntry; pEntry = 
g_list_previous(pEntry))
 {
 GtkTreeViewColumn* pColumn = GTK_TREE_VIEW_COLUMN(pEntry->data);
 g_signal_handler_disconnect(pColumn, m_aColumnSignalIds.back());
 m_aColumnSignalIds.pop_back();
+
+// unset "instance" to avoid dangling "instance" points in any 
CustomCellRenderers
+GList *pRenderers = 
gtk_cell_layout_get_cells(GTK_CELL_LAYOUT(pColumn));
+for (GList* pRenderer = g_list_first(pRenderers); pRenderer; 
pRenderer = g_list_next(pRenderer))
+{
+GtkCellRenderer* pCellRenderer = 
GTK_CELL_RENDERER(pRenderer->data);
+if (!CUSTOM_IS_CELL_RENDERER_SURFACE(pCellRenderer))
+continue;
+g_object_set_property(G_OBJECT(pCellRenderer), "instance", 
&value);
+}
+g_list_free(pRenderers);
 }
 g_list_free(m_pColumns);
 }
@@ -14496,13 +14512,16 @@ bool 
custom_cell_renderer_surface_get_preferred_size(GtkCellRenderer *cell,
 
 GtkInstanceWidget* pWidget = 
static_cast(g_value_get_pointer(&value));
 
-ensure_device(cellsurface, pWidget);
-
 Size aSize;
-if (GtkInstanceTreeView* pTreeView = 
dynamic_cast(pWidget))
-aSize = pTreeView->call_signal_custom_get_size(*cellsurface->device, 
sId);
-else if (GtkInstanceComboBox* pComboBox = 
dynamic_cast(pWidget))
-aSize = pComboBox->call_signal_custom_get_size(*cellsurface->device);
+
+if (pWidget)
+{
+ensure_device(cellsurface, pWidget);
+if (GtkInstanceTreeView* pTreeView = 
dynamic_cast(pWidget))
+aSize = 
pTreeView->call_signal_custom_get_size(*cellsurface->device, sId);
+else if (GtkInstanceComboBox* pComboBox = 
dynamic_cast(pWidget))
+aSize = 
pComboBox->call_signal_custom_get_size(*cellsurface->device);
+}
 
 if (orientation == GTK_ORIENTATION_HORIZONTAL)
 {
@@ -14545,6 +14564,10 @@ void 
custom_cell_renderer_surface_render(GtkCellRenderer* cell,
 CustomCellRendererSurface *cellsurface = 
CUSTOM_CELL_RENDERER_SURFACE(cell);
 
 GtkInstanceWidget* pWidget = 
static_cast(g_value_get_pointer(&value));
+
+if (!pWidget)
+return;
+
 ensure_device(cellsurface, pWidget);
 
 Size aSize(cell_area->width, cell_area->height);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - download.lst external/nss

2020-08-12 Thread Michael Stahl (via logerrit)

 download.lst |4 -
 external/nss/UnpackedTarball_nss.mk  |1 
 external/nss/macos-dlopen.patch.0|   18 
 external/nss/nss.nspr-parallel-win-debug_build.patch |   40 ---
 4 files changed, 11 insertions(+), 52 deletions(-)

New commits:
commit 227d30a3a17f2fffb1a166cdc3e2a796bb335214
Author: Michael Stahl 
AuthorDate: Fri Aug 7 18:57:00 2020 +0200
Commit: Xisco Fauli 
CommitDate: Wed Aug 12 12:02:38 2020 +0200

nss: upgrade to release 3.55.0

Fixes CVE-2020-6829, CVE-2020-12400 CVE-2020-12401 CVE-2020-12403.
(also CVE-2020-12402 CVE-2020-12399 in older releases since 3.47)

* external/nss/nss.nspr-parallel-win-debug_build.patch:
  remove, merged upstream

Change-Id: I8b48e25ce68a2327cde1420abdaea8f9e51a7888
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100345
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 495a5944a3d442cfe748a3bb0dcef76f6a961d30)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100420
Reviewed-by: Xisco Fauli 

diff --git a/download.lst b/download.lst
index eb3bbdc117aa..6398a09ec61f 100644
--- a/download.lst
+++ b/download.lst
@@ -191,8 +191,8 @@ export MYTHES_SHA256SUM := 
1e81f395d8c851c3e4e75b568e20fa2fa549354e75ab397f9de4b
 export MYTHES_TARBALL := a8c2c5b8f09e7ede322d5c602ff6a4b6-mythes-1.2.4.tar.gz
 export NEON_SHA256SUM := 
db0bd8cdec329b48f53a6f00199c92d5ba40b0f015b153718d1b15d3d967fbca
 export NEON_TARBALL := neon-0.30.2.tar.gz
-export NSS_SHA256SUM := 
861a4510b7c21516f49a4cfa5b871aa796e4e1ef2dfe949091970e56f9d60cdf
-export NSS_TARBALL := nss-3.53-with-nspr-4.25.tar.gz
+export NSS_SHA256SUM := 
ec6032d78663c6ef90b4b83eb552dedf721d2bce208cec3bf527b8f637db7e45
+export NSS_TARBALL := nss-3.55-with-nspr-4.27.tar.gz
 export ODFGEN_SHA256SUM := 
2c7b21892f84a4c67546f84611eccdad6259875c971e98ddb027da66ea0ac9c2
 export ODFGEN_VERSION_MICRO := 6
 export ODFGEN_TARBALL := libodfgen-0.1.$(ODFGEN_VERSION_MICRO).tar.bz2
diff --git a/external/nss/UnpackedTarball_nss.mk 
b/external/nss/UnpackedTarball_nss.mk
index 8801c7cdad63..1cad5852fa89 100644
--- a/external/nss/UnpackedTarball_nss.mk
+++ b/external/nss/UnpackedTarball_nss.mk
@@ -23,7 +23,6 @@ $(eval $(call gb_UnpackedTarball_add_patches,nss,\
 external/nss/nss.vs2015.pdb.patch \
 external/nss/nss.bzmozilla1238154.patch \
 external/nss/macos-dlopen.patch.0 \
-external/nss/nss.nspr-parallel-win-debug_build.patch \
 $(if $(filter iOS,$(OS)), \
 external/nss/nss-ios.patch) \
 $(if $(filter ANDROID,$(OS)), \
diff --git a/external/nss/macos-dlopen.patch.0 
b/external/nss/macos-dlopen.patch.0
index 8c484e4c6841..1889b8df7cd3 100644
--- a/external/nss/macos-dlopen.patch.0
+++ b/external/nss/macos-dlopen.patch.0
@@ -1,14 +1,14 @@
 --- nspr/pr/src/linking/prlink.c
 +++ nspr/pr/src/linking/prlink.c
-@@ -793,7 +793,7 @@
- /* ensure the file exists if it contains a slash character i.e. path 
*/
- /* DARWIN's dlopen ignores the provided path and checks for the */
- /* plain filename in DYLD_LIBRARY_PATH */
--if (strchr(name, PR_DIRECTORY_SEPARATOR) == NULL ||
-+if (strchr(name, PR_DIRECTORY_SEPARATOR) == NULL || strncmp(name, 
"@loader_path/", 13) == 0 ||
- PR_Access(name, PR_ACCESS_EXISTS) == PR_SUCCESS) {
- h = dlopen(name, dl_flags);
- }
+@@ -799,7 +799,7 @@
+  * The reason is that DARWIN's dlopen ignores the provided path
+  * and checks for the plain filename in DYLD_LIBRARY_PATH,
+  * which could load an unexpected version of a library. */
+-if (strchr(name, PR_DIRECTORY_SEPARATOR) == NULL) {
++if (strchr(name, PR_DIRECTORY_SEPARATOR) == NULL || strncmp(name, 
"@loader_path/", 13) == 0) {
+   /* no slash, allow to load from any location */
+   okToLoad = PR_TRUE;
+ } else {
 --- nss/lib/libpkix/pkix_pl_nss/module/pkix_pl_httpcertstore.c
 +++ nss/lib/libpkix/pkix_pl_nss/module/pkix_pl_httpcertstore.c
 @@ -224,7 +224,11 @@
diff --git a/external/nss/nss.nspr-parallel-win-debug_build.patch 
b/external/nss/nss.nspr-parallel-win-debug_build.patch
deleted file mode 100644
index 86b55e1ccf7f..
--- a/external/nss/nss.nspr-parallel-win-debug_build.patch
+++ /dev/null
@@ -1,40 +0,0 @@
-Änderung:4866:23940b78e965
-Nutzer:  Jan-Marek Glogowski 
-Datum:   Fri May 01 22:50:55 2020 +
-Dateien: pr/tests/Makefile.in
-Beschreibung:
-Bug 290526 Write separate PDBs for test OBJs r=glandium
-
-Quite often when running a parallel NSS build, I get the following
-compiler error message, resulting in a build failure, despite
-compiling with the -FS flag:
-
-.../nss/nspr/pr/tests/zerolen.c: fatal error C1041:
-Programmdatenbank "...\nss\nspr\out\pr\tests\vc140.pdb" kann nicht
-ge<94>ffnet werden; verwenden Sie /FS, wenn mehrere CL.EXE in
-dieselbe .PDB-D

Unclear string to translate in inspectorproperties.hrc

2020-08-12 Thread Milos Sramek

Hi,

we got for translation 200+ new strings, which are located in file
inspectorproperties.hrc and seem to be related to the Style Inspector
sidebar deck.

These strings are not full sentences and seem to have a certain logic
structure, for example

Fill Bitmap Rectangle Point
Char Interoperability Grab Bag
Char Weight Complex

So, we do not know, how to translate them. Should they be translated at all?

Currently, I can see only two items in Style Inspector sidebar deck in
Writer
Font name
Font size

In the file inspectorproperties.hrc there is
"Char Font Name"
but no
"Char Font Size"

Are the strings, which i can see in the Inspector, derived somehow from
the strings in  inspectorproperties.hrc?

Thanks
Milos


On 8/4/20 7:59 AM, Shivam Kumar Singh wrote:
> Hi,
>
> Work Done this week :-
> * tdf#135178 tdf#135179 tdf#134820 SetChgLink was not correctly called
> and used which led to crash on moving the cursor to different images
> or charts. This issue was fixed, MERGED
> * tdf#134831 The SI would expand only to 2/3rd of the sidebar though
> its expected to expand to the whole length. This change was fixed and
> merged.
> * tdf#134560 tdf#135107 Previously the API names for the properties
> were shown in the SI, which was not very easy to understand. These
> properties are now human-readable and translatable wrt UI language.
> MERGED
>
> To Do for this week :-
> * Add color boxes to "Color" properties tdf#134561
> * Some ui issues still exist relating to the scroll bars. This should
> be fixed within this week tdf#135344
> * Add a way to also display properties which are stored in structs in
> the UNO API tdf#135406
>
> All the bugs are being listed at META tdf#134554, It would be great
> help if more number of people use the SI and report any bugs
> experienced or confirm the already listed unconfirmed ones.
>
> Thank you Mike, Heiko and Tomaz for their continuous guidance :)
>
> sincerely,
> Shivam Kumar Singh
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice


-- 
Milos Sramek, msrame...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[no subject]

2020-08-12 Thread Sarfaraz Alam

Hello,
I am Sarfaraz Alam,a student of B.Tech 3rd year in computer science and
engineering department.I looking forward to contribute in open source
projects.How can I do it? Please guide me.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

GSoC Report Week 9 and Week 10 (Yusuf Keten)

2020-08-12 Thread Yusuf Keten

Hello,

I'm really sorry for the latency. But Week 9 was very painful due to
crashes. I was waiting to do something except bug fix.

Week 9 ->
https://yusufketen.com/post/2020-08-03-libreoffice-gsoc-week-9-report/
Week 10 ->
https://yusufketen.com/post/2020-08-10-libreoffice-gsoc-week-10-report/

I'm waiting for all your feedback.

Best regards,
Yusuf Keten
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

GSoC Report Week 9 and Week 10 (Yusuf Keten)

2020-08-12 Thread yusuf


Hello,

I'm really sorry for the latency. But Week 9 was very painful due to 
crashes. I was waiting to do something except bug fix.


Week 9 -> 
https://yusufketen.com/post/2020-08-03-libreoffice-gsoc-week-9-report/
Week 10 -> 
https://yusufketen.com/post/2020-08-10-libreoffice-gsoc-week-10-report/


I'm waiting for all your feedback.

Best regards,
Yusuf Keten
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - sd/uiconfig vcl/uiconfig

2020-08-12 Thread Caolán McNamara (via logerrit)

 sd/uiconfig/simpress/ui/clientboxfragment.ui |2 +-
 vcl/uiconfig/ui/wizard.ui|2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f27fd86d2dc424cee2d28fe77d881eacc4795eaf
Author: Caolán McNamara 
AuthorDate: Tue Aug 11 15:29:38 2020 +0100
Commit: Xisco Fauli 
CommitDate: Wed Aug 12 11:36:23 2020 +0200

tdf#135442 min supported version of gtk3 is 3.18 not 3.20

Change-Id: Iaa2eefbe08fad3a7dd6eff98bf5fb513053a263d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100541
Tested-by: Xisco Fauli 
Reviewed-by: Xisco Fauli 

diff --git a/sd/uiconfig/simpress/ui/clientboxfragment.ui 
b/sd/uiconfig/simpress/ui/clientboxfragment.ui
index 361caeeb4823..e5811360878d 100644
--- a/sd/uiconfig/simpress/ui/clientboxfragment.ui
+++ b/sd/uiconfig/simpress/ui/clientboxfragment.ui
@@ -1,7 +1,7 @@
 
 
 
-  
+  
   
 True
 False
diff --git a/vcl/uiconfig/ui/wizard.ui b/vcl/uiconfig/ui/wizard.ui
index e1f68da9e66a..76f92607f1ce 100644
--- a/vcl/uiconfig/ui/wizard.ui
+++ b/vcl/uiconfig/ui/wizard.ui
@@ -1,7 +1,7 @@
 
 
 
-  
+  
   
 True
 6
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2020-08-12 Thread Dennis Francis (via logerrit)

 loleaflet/src/layer/tile/CanvasTileLayer.js |   31 
 1 file changed, 23 insertions(+), 8 deletions(-)

New commits:
commit 797f8fc775bcaba8c8b1e6909dd4da0ae0b06d64
Author: Dennis Francis 
AuthorDate: Tue Aug 11 13:58:42 2020 +0530
Commit: Dennis Francis 
CommitDate: Wed Aug 12 11:33:37 2020 +0200

loleaflet: avoid flicker due to map-size changes...

by resizing the canvas only when the width/height of the map increases.
A canvas resize causes horrible flickering especially when the dpiScale
is not 1. This problem is more prevalent in mobile due to the on-screen
keyboard.

Change-Id: I10135d91f122eb751f16791476e09a45dbe09752
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100490
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Dennis Francis 

diff --git a/loleaflet/src/layer/tile/CanvasTileLayer.js 
b/loleaflet/src/layer/tile/CanvasTileLayer.js
index 93131252e..06911991c 100644
--- a/loleaflet/src/layer/tile/CanvasTileLayer.js
+++ b/loleaflet/src/layer/tile/CanvasTileLayer.js
@@ -107,6 +107,7 @@ L.CanvasTilePainter = L.Class.extend({
this.setImageSmoothing(enableImageSmoothing);
var mapSize = this._map.getPixelBounds().getSize();
this._lastSize = mapSize;
+   this._lastMapSize = mapSize;
this._setCanvasSize(mapSize.x, mapSize.y);
},
 
@@ -216,7 +217,7 @@ L.CanvasTilePainter = L.Class.extend({
var splitPanesContext = this._layer.getSplitPanesContext();
var zoom = Math.round(this._map.getZoom());
var pixelBounds = this._map.getPixelBounds();
-   var newSize = pixelBounds.getSize();
+   var newMapSize = pixelBounds.getSize();
var newTopLeft = pixelBounds.getTopLeft();
var part = this._layer._selectedPart;
var newSplitPos = splitPanesContext ?
@@ -224,25 +225,39 @@ L.CanvasTilePainter = L.Class.extend({
 
var zoomChanged = (zoom !== this._lastZoom);
var partChanged = (part !== this._lastPart);
-   var sizeChanged = !newSize.equals(this._lastSize);
+
+   var mapSizeChanged = !newMapSize.equals(this._lastMapSize);
+   // To avoid flicker, only resize the canvas element if width or 
height of the map increases.
+   var newSize = new L.Point(Math.max(newMapSize.x, 
this._lastSize.x),
+   Math.max(newMapSize.y, this._lastSize.y));
+   var resizeCanvas = !newSize.equals(this._lastSize);
+
+   var topLeftChanged = this._topLeft === undefined || 
!newTopLeft.equals(this._topLeft);
+
var splitPosChanged = !newSplitPos.equals(this._splitPos);
 
var skipUpdate = (
-   this._topLeft !== undefined &&
+   !topLeftChanged &&
!zoomChanged &&
!partChanged &&
-   !sizeChanged &&
-   !splitPosChanged &&
-   newTopLeft.equals(this._topLeft));
+   !resizeCanvas &&
+   !splitPosChanged);
 
if (skipUpdate) {
return;
}
 
-   if (sizeChanged) {
+   if (resizeCanvas) {
this._setCanvasSize(newSize.x, newSize.y);
this._lastSize = newSize;
}
+   else if (mapSizeChanged && topLeftChanged) {
+   this.clear();
+   }
+
+   if (mapSizeChanged) {
+   this._lastMapSize = newMapSize;
+   }
 
if (splitPosChanged) {
this._splitPos = newSplitPos;
@@ -250,7 +265,7 @@ L.CanvasTilePainter = L.Class.extend({
 
// TODO: fix _shiftAndPaint for high DPI.
var shiftPaintDisabled = true;
-   var fullRepaintNeeded = zoomChanged || partChanged || 
sizeChanged || shiftPaintDisabled;
+   var fullRepaintNeeded = zoomChanged || partChanged || 
resizeCanvas || shiftPaintDisabled;
 
this._lastZoom = zoom;
this._lastPart = part;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sw/qa sw/source

2020-08-12 Thread Michael Stahl (via logerrit)

 sw/qa/extras/layout/data/tdf128198-1.docx |binary
 sw/qa/extras/layout/layout.cxx|   21 +
 sw/qa/extras/ooxmlimport/ooxmlimport2.cxx |6 --
 sw/source/core/text/itrform2.cxx  |3 ++-
 4 files changed, 23 insertions(+), 7 deletions(-)

New commits:
commit ad5fbe94fd42867f77aa68776079242afbdafda7
Author: Michael Stahl 
AuthorDate: Mon Aug 10 19:14:54 2020 +0200
Commit: Miklos Vajna 
CommitDate: Wed Aug 12 11:28:47 2020 +0200

tdf#128198 sw: text formatting: only consider upper margin for first line

The non-first lines start below the first one so the margin is already
included in the previous line's Y position.

Also move the testTdf116486 to layout.cxx.

(regression from d07fc485d46f431405a3f6a002f951a08c559677)

(cherry picked from commit a99de4981f2e0a652d964c8c688f73485494102e)

Change-Id: I574516ea5f9600e2d861e43162b1a69488c68819
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100583
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/extras/ooxmlimport/data/tdf116486.docx 
b/sw/qa/extras/layout/data/tdf116486.docx
similarity index 100%
rename from sw/qa/extras/ooxmlimport/data/tdf116486.docx
rename to sw/qa/extras/layout/data/tdf116486.docx
diff --git a/sw/qa/extras/layout/data/tdf128198-1.docx 
b/sw/qa/extras/layout/data/tdf128198-1.docx
new file mode 100644
index ..7c9974d562b9
Binary files /dev/null and b/sw/qa/extras/layout/data/tdf128198-1.docx differ
diff --git a/sw/qa/extras/layout/layout.cxx b/sw/qa/extras/layout/layout.cxx
index 22451046cb3d..28ee6095792d 100644
--- a/sw/qa/extras/layout/layout.cxx
+++ b/sw/qa/extras/layout/layout.cxx
@@ -1139,6 +1139,27 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter, 
testRedlineFlysInFootnote)
 }
 }
 
+CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testTdf116486)
+{
+SwDoc* pDoc = createDoc("tdf116486.docx");
+CPPUNIT_ASSERT(pDoc);
+OUString aTop = parseDump("/root/page/body/txt/Special", "nHeight");
+CPPUNIT_ASSERT_EQUAL(OUString("4006"), aTop);
+}
+
+CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testTdf128198)
+{
+SwDoc* pDoc = createDoc("tdf128198-1.docx");
+CPPUNIT_ASSERT(pDoc);
+xmlDocPtr pLayout = parseLayoutDump();
+// the problem was that line 5 was truncated at "this  "
+// due to the fly anchored in previous paragraph
+assertXPath(pLayout, "/root/page/body/txt[2]/LineBreak[5]", "Line",
+"to access any service, any time, anywhere. From this  
perspective, satellite "
+"boasts some ");
+assertXPath(pLayout, "/root/page/body/txt[2]/LineBreak[6]", "Line", 
"significant advantages. ");
+}
+
 CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testNoLineBreakAtSlash)
 {
 load(DATA_DIRECTORY, "no-line-break-at-slash.fodt");
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
index a14b97aec66a..4b69a62859c6 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport2.cxx
@@ -411,12 +411,6 @@ DECLARE_OOXMLIMPORT_TEST(testTdf114217, "tdf114217.docx")
 CPPUNIT_ASSERT_EQUAL(static_cast(0), xDrawPage->getCount());
 }
 
-DECLARE_OOXMLIMPORT_TEST(testTdf116486, "tdf116486.docx")
-{
-OUString aTop = parseDump("/root/page/body/txt/Special", "nHeight");
-CPPUNIT_ASSERT_EQUAL(OUString("4006"), aTop);
-}
-
 DECLARE_OOXMLIMPORT_TEST(testTdf119200, "tdf119200.docx")
 {
 auto xPara = getParagraph(1);
diff --git a/sw/source/core/text/itrform2.cxx b/sw/source/core/text/itrform2.cxx
index 043f522687de..89c7641df414 100644
--- a/sw/source/core/text/itrform2.cxx
+++ b/sw/source/core/text/itrform2.cxx
@@ -2296,7 +2296,8 @@ void SwTextFormatter::CalcFlyWidth( SwTextFormatInfo 
&rInf )
 // tdf#116486: consider also the upper margin from getFramePrintArea 
because intersections
 // with this additional space should lead to repositioning of 
paragraphs
 // For compatibility we grab a related compat flag:
-if 
(GetTextFrame()->GetDoc().getIDocumentSettingAccess().get(DocumentSettingId::ADD_VERTICAL_FLY_OFFSETS))
+if 
(GetTextFrame()->GetDoc().getIDocumentSettingAccess().get(DocumentSettingId::ADD_VERTICAL_FLY_OFFSETS)
+&& IsFirstTextLine())
 {
 const long nUpper = m_pFrame->getFramePrintArea().Top();
 // Increase the rectangle
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa

2020-08-12 Thread Stephan Bergmann (via logerrit)

 sw/qa/uitest/writer_tests3/insertSignatureLine.py |   30 +++---
 1 file changed, 16 insertions(+), 14 deletions(-)

New commits:
commit 26298f29e9d36313be527b785a9bb96089582037
Author: Stephan Bergmann 
AuthorDate: Wed Aug 12 08:19:28 2020 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Aug 12 11:15:57 2020 +0200

Avoid repeated calls to document.DrawPage.getByIndex(0)

I have seen various failures with (slow) ASan+UBSan builds where some other
than the first one of those self.assertEqual failed.  I would assume that 
they
rather either all succeed or all fail (in which case consistently the first 
one
in each of those self.assertEqual blocks should fail).  To rule out the
possibility that, for some timing/race reason, the identity of the element
provided by document.DrawPage.getByIndex(0) changes midway through those 
blocks,
only obtain that element once per block.

Examples of such failures during UITest_writer_tests3 are


> FAIL: test_insert_signature_line (insertSignatureLine.insertSignatureLine)
> --
> Traceback (most recent call last):
>   File 
"/home/tdf/lode/jenkins/workspace/lo_ubsan/sw/qa/uitest/writer_tests3/insertSignatureLine.py",
 line 53, in test_insert_signature_line
> 
self.assertEqual(document.DrawPage.getByIndex(0).SignatureLineSuggestedSignerEmail,
 "Email")
> AssertionError: None != 'Email'

and my local build

> FAIL: test_insert_signature_line2 
(insertSignatureLine.insertSignatureLine)
> --
> Traceback (most recent call last):
>   File 
"/home/sbergman/lo/core/sw/qa/uitest/writer_tests3/insertSignatureLine.py", 
line 91, in test_insert_signature_line2
> 
self.assertEqual(document.DrawPage.getByIndex(0).SignatureLineShowSignDate, 
False)
> AssertionError: None != False

Change-Id: I2739edb12ed39892f5b2b9e3d632e166c1c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100572
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sw/qa/uitest/writer_tests3/insertSignatureLine.py 
b/sw/qa/uitest/writer_tests3/insertSignatureLine.py
index 8bbbdd65b93d..eb75b6cc89b2 100644
--- a/sw/qa/uitest/writer_tests3/insertSignatureLine.py
+++ b/sw/qa/uitest/writer_tests3/insertSignatureLine.py
@@ -48,13 +48,14 @@ class insertSignatureLine(UITestCase):
 xOKBtn.executeAction("CLICK", tuple())
 
 #check the signature Line in the document
-
self.assertEqual(document.DrawPage.getByIndex(0).SignatureLineSuggestedSignerName,
 "Name")
-
self.assertEqual(document.DrawPage.getByIndex(0).SignatureLineSuggestedSignerTitle,
 "Title")
-
self.assertEqual(document.DrawPage.getByIndex(0).SignatureLineSuggestedSignerEmail,
 "Email")
-
self.assertEqual(document.DrawPage.getByIndex(0).SignatureLineSuggestedSignerTitle,
 "Title")
-
self.assertEqual(document.DrawPage.getByIndex(0).SignatureLineCanAddComment, 
False)
-
self.assertEqual(document.DrawPage.getByIndex(0).SignatureLineShowSignDate, 
True)
-
self.assertEqual(document.DrawPage.getByIndex(0).SignatureLineSigningInstructions,
 "Instructions")
+element = document.DrawPage.getByIndex(0)
+self.assertEqual(element.SignatureLineSuggestedSignerName, "Name")
+self.assertEqual(element.SignatureLineSuggestedSignerTitle, "Title")
+self.assertEqual(element.SignatureLineSuggestedSignerEmail, "Email")
+self.assertEqual(element.SignatureLineSuggestedSignerTitle, "Title")
+self.assertEqual(element.SignatureLineCanAddComment, False)
+self.assertEqual(element.SignatureLineShowSignDate, True)
+self.assertEqual(element.SignatureLineSigningInstructions, 
"Instructions")
 
 self.ui_test.close_doc()
 
@@ -83,13 +84,14 @@ class insertSignatureLine(UITestCase):
 xOKBtn.executeAction("CLICK", tuple())
 
 #check the signature Line in the document
-
self.assertEqual(document.DrawPage.getByIndex(0).SignatureLineSuggestedSignerName,
 "Name")
-
self.assertEqual(document.DrawPage.getByIndex(0).SignatureLineSuggestedSignerTitle,
 "Title")
-
self.assertEqual(document.DrawPage.getByIndex(0).SignatureLineSuggestedSignerEmail,
 "Email")
-
self.assertEqual(document.DrawPage.getByIndex(0).SignatureLineSuggestedSignerTitle,
 "Title")
-
self.assertEqual(document.DrawPage.getByIndex(0).SignatureLineCanAddComment, 
False)
-
self.assertEqual(document.DrawPage.getByIndex(0).SignatureLineShowSignDate, 
False)
-
self.assertEqual(document.DrawPage.getByIndex(0).SignatureLineSigningInstructions,
 "Instructions")
+element = document.DrawPage.getByIndex(0)
+self.assertEqual(element.SignatureLineSuggestedSignerName, "Name")
+

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - download.lst external/nss

2020-08-12 Thread Jan-Marek Glogowski (via logerrit)

 download.lst |4 -
 external/nss/ExternalProject_nss.mk  |6 +-
 external/nss/UnpackedTarball_nss.mk  |   38 +-
 external/nss/nsinstall.py|7 ++-
 external/nss/nss-3.13.5-zlib-werror.patch|7 +--
 external/nss/nss-win32-make.patch.1  |2 
 external/nss/nss.nspr-parallel-win-debug_build.patch |   40 +++
 external/nss/nss.windows.patch   |4 -
 8 files changed, 77 insertions(+), 31 deletions(-)

New commits:
commit c1bce55faebd9ad8751d7b6b9a7f77dff7b3d507
Author: Jan-Marek Glogowski 
AuthorDate: Wed Jun 26 18:09:19 2019 +0200
Commit: Michael Stahl 
CommitDate: Wed Aug 12 11:10:52 2020 +0200

NSS: enable parallel build

Since NSS 3.53, the Makefile based build should be fixed (upstream
bug 290526). The only missing patch is a minimal NSPR fix for the
"NSPR, configure + make, parallel, Windows, MS VS, debug" build.
That patch isn't incuded in the NSPR 4.25 release (but it's already
in the mercurial repo for NSPR 4.26).

Change-Id: I8eaa3792a12bdff734e56ac3f552991478957e23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95218
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 
(cherry picked from commit b56e8d6def26a0430853835e997f1be841840a61)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100419
Reviewed-by: Michael Stahl 

diff --git a/download.lst b/download.lst
index cd65931a231c..eb3bbdc117aa 100644
--- a/download.lst
+++ b/download.lst
@@ -191,8 +191,8 @@ export MYTHES_SHA256SUM := 
1e81f395d8c851c3e4e75b568e20fa2fa549354e75ab397f9de4b
 export MYTHES_TARBALL := a8c2c5b8f09e7ede322d5c602ff6a4b6-mythes-1.2.4.tar.gz
 export NEON_SHA256SUM := 
db0bd8cdec329b48f53a6f00199c92d5ba40b0f015b153718d1b15d3d967fbca
 export NEON_TARBALL := neon-0.30.2.tar.gz
-export NSS_SHA256SUM := 
07d4276168f59bb3038c7826dabb5fbfbab8336ddf65e4e6e43bce89ada78c64
-export NSS_TARBALL := nss-3.47.1-with-nspr-4.23.tar.gz
+export NSS_SHA256SUM := 
861a4510b7c21516f49a4cfa5b871aa796e4e1ef2dfe949091970e56f9d60cdf
+export NSS_TARBALL := nss-3.53-with-nspr-4.25.tar.gz
 export ODFGEN_SHA256SUM := 
2c7b21892f84a4c67546f84611eccdad6259875c971e98ddb027da66ea0ac9c2
 export ODFGEN_VERSION_MICRO := 6
 export ODFGEN_TARBALL := libodfgen-0.1.$(ODFGEN_VERSION_MICRO).tar.bz2
diff --git a/external/nss/ExternalProject_nss.mk 
b/external/nss/ExternalProject_nss.mk
index 796d8151c168..b4c4f37cf07c 100644
--- a/external/nss/ExternalProject_nss.mk
+++ b/external/nss/ExternalProject_nss.mk
@@ -24,11 +24,11 @@ $(call gb_ExternalProject_get_state_target,nss,build): 
$(call gb_ExternalExecuta
MOZ_DEBUG_SYMBOLS=1 \
MOZ_DEBUG_FLAGS=" " \
OPT_CODE_SIZE=0) \
-   MOZ_MSVCVERSION=9 OS_TARGET=WIN95 \
+   OS_TARGET=WIN95 \
$(if $(filter X86_64,$(CPUNAME)),USE_64=1) \
LIB="$(ILIB)" \
XCFLAGS="$(SOLARINC)" \
-   $(MAKE) -j1 nss_build_all RC="rc.exe $(SOLARINC)" \
+   $(MAKE) nss_build_all RC="rc.exe $(SOLARINC)" \
NSINSTALL='$(call 
gb_ExternalExecutable_get_command,python) $(SRCDIR)/external/nss/nsinstall.py' \
NSS_DISABLE_GTESTS=1 \
,nss)
@@ -53,7 +53,7 @@ $(call gb_ExternalProject_get_state_target,nss,build): $(call 
gb_ExternalExecuta
$(if $(filter iOS-ARM,$(OS)-$(CPUNAME)),CPU_ARCH=arm) \
NSPR_CONFIGURE_OPTS="--build=$(BUILD_PLATFORM) 
--host=$(HOST_PLATFORM)") \
NSDISTMODE=copy \
-   $(MAKE) -j1 AR="$(AR)" \
+   $(MAKE) AR="$(AR)" \
RANLIB="$(RANLIB)" \
NMEDIT="$(NM)edit" \
COMMA=$(COMMA) \
diff --git a/external/nss/UnpackedTarball_nss.mk 
b/external/nss/UnpackedTarball_nss.mk
index 0e174879a702..8801c7cdad63 100644
--- a/external/nss/UnpackedTarball_nss.mk
+++ b/external/nss/UnpackedTarball_nss.mk
@@ -12,34 +12,34 @@ $(eval $(call gb_UnpackedTarball_UnpackedTarball,nss))
 $(eval $(call gb_UnpackedTarball_set_tarball,nss,$(NSS_TARBALL)))
 
 $(eval $(call gb_UnpackedTarball_add_patches,nss,\
-   external/nss/nss.patch \
-   external/nss/nss.aix.patch \
-   external/nss/nss-3.13.5-zlib-werror.patch \
-   external/nss/nss_macosx.patch \
-   external/nss/nss-win32-make.patch.1 \
-   $(if $(filter WNT,$(OS)),external/nss/nss.windows.patch \
-external/nss/nss.nowerror.patch \
-   external/nss/nss.vs2015.patch) \
+external/nss/nss.patch \
+external/nss/nss.aix.patch \
+external/nss/nss-3.13.5-zlib-werror.patch \
+external/nss/nss_macosx.patch \
+external/nss/nss-win32-make.patch.1 \
 external/nss/ubsan.patch.0 \
 external/nss/clang-cl.patch.0 \
+e

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - vcl/unx

2020-08-12 Thread Caolán McNamara (via logerrit)

 vcl/unx/gtk3/gtk3gtkinst.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit cb3a18269745fb8cee12885a5064c862f54f8f11
Author: Caolán McNamara 
AuthorDate: Tue Aug 11 14:23:14 2020 +0100
Commit: Xisco Fauli 
CommitDate: Wed Aug 12 10:51:03 2020 +0200

tdf#135567 for async case need an alternative check for dialog in execution

Change-Id: I326b891b61f8a9848b56b2f26a80af80ab045dec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100511
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 7537300b3536..b8f1b66c4b49 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -4574,7 +4574,10 @@ public:
 
b) the validity dialog in calc
 */
-if (m_aDialogRun.loop_is_running())
+// tdf#135567 we know we are running in the sync case if 
loop_is_running is true
+// but for the async case we instead check for m_xDialogController 
which is set in
+// runAsync and cleared in asyncresponse
+if (m_aDialogRun.loop_is_running() || m_xDialogController)
 {
 if (bModal)
 m_aDialogRun.inc_modal_count();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - basctl/source

2020-08-12 Thread Mike Kaganski (via logerrit)

 basctl/source/basicide/baside2b.cxx |   63 ++--
 1 file changed, 33 insertions(+), 30 deletions(-)

New commits:
commit bde75c036f34ce970a90991acde80f0d16007af6
Author: Mike Kaganski 
AuthorDate: Tue Aug 11 18:11:10 2020 +0300
Commit: Xisco Fauli 
CommitDate: Wed Aug 12 10:43:21 2020 +0200

tdf#135639: check the return value of GetDim32

... to avoid crash accessing non-existing element of pChildItem->vIndices

Change-Id: I248a9301abd69883f940051d9d9671298dcc8453
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100540
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100565
Reviewed-by: Xisco Fauli 

diff --git a/basctl/source/basicide/baside2b.cxx 
b/basctl/source/basicide/baside2b.cxx
index a1efc0bcd93c..d5cf4efe259e 100644
--- a/basctl/source/basicide/baside2b.cxx
+++ b/basctl/source/basicide/baside2b.cxx
@@ -2128,43 +2128,46 @@ IMPL_LINK(WatchWindow, RequestingChildrenHdl, const 
weld::TreeIter&, rParent, bo
 int nParentLevel = bArrayIsRootArray ? pItem->nDimLevel : 0;
 int nThisLevel = nParentLevel + 1;
 sal_Int32 nMin, nMax;
-pArray->GetDim32( nThisLevel, nMin, nMax );
-for( sal_Int32 i = nMin ; i <= nMax ; i++ )
+if (pArray->GetDim32(nThisLevel, nMin, nMax))
 {
-WatchItem* pChildItem = new WatchItem(pItem->maName);
+for (sal_Int32 i = nMin; i <= nMax; i++)
+{
+WatchItem* pChildItem = new WatchItem(pItem->maName);
 
-// Copy data and create name
+// Copy data and create name
 
-OUStringBuffer aIndexStr = "(";
-pChildItem->mpArrayParentItem = pItem;
-pChildItem->nDimLevel = nThisLevel;
-pChildItem->nDimCount = pItem->nDimCount;
-pChildItem->vIndices.resize(pChildItem->nDimCount);
-sal_Int32 j;
-for( j = 0 ; j < nParentLevel ; j++ )
-{
-sal_Int32 n = pChildItem->vIndices[j] = pItem->vIndices[j];
-aIndexStr.append(OUString::number( n )).append(",");
-}
-pChildItem->vIndices[nParentLevel] = i;
-aIndexStr.append(OUString::number( i )).append(")");
+OUStringBuffer aIndexStr = "(";
+pChildItem->mpArrayParentItem = pItem;
+pChildItem->nDimLevel = nThisLevel;
+pChildItem->nDimCount = pItem->nDimCount;
+pChildItem->vIndices.resize(pChildItem->nDimCount);
+sal_Int32 j;
+for (j = 0; j < nParentLevel; j++)
+{
+sal_Int32 n = pChildItem->vIndices[j] = pItem->vIndices[j];
+aIndexStr.append(OUString::number(n)).append(",");
+}
+pChildItem->vIndices[nParentLevel] = i;
+aIndexStr.append(OUString::number(i)).append(")");
 
-OUString aDisplayName;
-WatchItem* pArrayRootItem = pChildItem->GetRootItem();
-if( pArrayRootItem && pArrayRootItem->mpArrayParentItem )
-aDisplayName = pItem->maDisplayName;
-else
-aDisplayName = pItem->maName;
-aDisplayName += aIndexStr;
-pChildItem->maDisplayName = aDisplayName;
+OUString aDisplayName;
+WatchItem* pArrayRootItem = pChildItem->GetRootItem();
+if (pArrayRootItem && pArrayRootItem->mpArrayParentItem)
+aDisplayName = pItem->maDisplayName;
+else
+aDisplayName = pItem->maName;
+aDisplayName += aIndexStr;
+pChildItem->maDisplayName = aDisplayName;
 
-OUString 
sId(OUString::number(reinterpret_cast(pChildItem)));
+OUString 
sId(OUString::number(reinterpret_cast(pChildItem)));
 
-m_xTreeListBox->insert(&rParent, -1, &aDisplayName, &sId, nullptr, 
nullptr, nullptr, false, xRet.get());
-m_xTreeListBox->set_text(*xRet, "", 1);
-m_xTreeListBox->set_text(*xRet, "", 2);
+m_xTreeListBox->insert(&rParent, -1, &aDisplayName, &sId, 
nullptr, nullptr, nullptr,
+   false, xRet.get());
+m_xTreeListBox->set_text(*xRet, "", 1);
+m_xTreeListBox->set_text(*xRet, "", 2);
 
-nElementCount++;
+nElementCount++;
+}
 }
 if (nElementCount > 0 && !m_nUpdateWatchesId)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2020-08-12 Thread Tor Lillqvist (via logerrit)

 loleaflet/src/map/Map.js |6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)

New commits:
commit 097f4008fa080620bd5e720178cb6866767e772e
Author: Tor Lillqvist 
AuthorDate: Wed Aug 12 09:59:02 2020 +0300
Commit: Tor Lillqvist 
CommitDate: Wed Aug 12 10:41:39 2020 +0200

Nothing sets _wasSingleTap and there is no Map.Tap.js any more

This should have been cleaned away when Map.Tap.js was removed in
a89d122479fd5aaae723ab8e646b705472b50591 "remove obsolete Map.Tap
handler".

Change-Id: Ic3946da8097089af1fb51e7b7a5f1c2e1b82c98b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100576
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tor Lillqvist 

diff --git a/loleaflet/src/map/Map.js b/loleaflet/src/map/Map.js
index 283b6bbfd..6f5677a26 100644
--- a/loleaflet/src/map/Map.js
+++ b/loleaflet/src/map/Map.js
@@ -1541,11 +1541,7 @@ L.Map = L.Evented.extend({
// .focus() method on hidden input within actual 'click' event 
here
// Calling from some other place with no real 'click' event 
doesn't work.
 
-   // (tml: For me, for this to work with a mobile device, we need 
to
-   // accept 'mouseup', too, and check the _wasSingleTap flag set 
over in Map.Tap.js.)
-   if (type === 'click' || type === 'dblclick' || (type === 
'mouseup' &&
-typeof this._container._wasSingleTap 
!== 'undefined' &&
-this._container._wasSingleTap)) {
+   if (type === 'click' || type === 'dblclick') {
if (this.isPermissionEdit()) {
this.fire('editorgotfocus');
this.focus();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2020-08-12 Thread Dennis Francis (via logerrit)

 loleaflet/src/layer/tile/CalcTileLayer.js |7 +++
 loleaflet/src/layer/tile/TileLayer.js |5 +
 2 files changed, 12 insertions(+)

New commits:
commit 9305d75362e56a76e9d95735b626a32157ea88a4
Author: Dennis Francis 
AuthorDate: Tue Aug 11 11:54:48 2020 +0530
Commit: Dennis Francis 
CommitDate: Wed Aug 12 10:37:14 2020 +0200

loleaflet: adjust the map position on resize...

... if there is an active/visible cursor *and* it is out of the visible
map-area. The map position is so adjusted that the cursor will in the
center of the visible map area. This is needed for mobile(at least
android) because of the on-screen keyboard.

Note: We already do this for every 'invalidatecursor' message.
Change-Id: I3342a165ad47fe1b32715f3a6bf35486ba2f287c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100489
Tested-by: Jenkins CollaboraOffice 
Tested-by: Jenkins
Reviewed-by: Dennis Francis 

diff --git a/loleaflet/src/layer/tile/CalcTileLayer.js 
b/loleaflet/src/layer/tile/CalcTileLayer.js
index 0c25bd78a..337ba0f68 100644
--- a/loleaflet/src/layer/tile/CalcTileLayer.js
+++ b/loleaflet/src/layer/tile/CalcTileLayer.js
@@ -80,6 +80,13 @@ L.CalcTileLayer = (L.Browser.mobile ? L.TileLayer : 
L.CanvasTileLayer).extend({
map.addControl(L.control.columnHeader());
map.addControl(L.control.rowHeader());
L.TileLayer.prototype.onAdd.call(this, map);
+
+   map.on('resize', function () {
+   if (this.isCursorVisible()) {
+   this._onUpdateCursor(true /* scroll */);
+   }
+   }.bind(this));
+
this._annotations = {};
},
 
diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index e0f1b8d37..71340ad89 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -2263,6 +2263,11 @@ L.TileLayer = L.GridLayer.extend({
 
// Update cursor layer (blinking cursor).
_onUpdateCursor: function (scroll, zoom) {
+
+   if (!this._visibleCursor) {
+   return;
+   }
+
var cursorPos = this._visibleCursor.getNorthWest();
var docLayer = this._map._docLayer;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2020-08-12 Thread Dennis Francis (via logerrit)

 loleaflet/src/layer/marker/Marker.js |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 13ba88f73951cd7525a86d99525b5405c1ff35f8
Author: Dennis Francis 
AuthorDate: Fri Aug 7 21:48:37 2020 +0530
Commit: Dennis Francis 
CommitDate: Wed Aug 12 10:35:46 2020 +0200

split-panes: update marker position on swipe/pan

Change-Id: Idbb4b30be3c0d6f7def4c8baed5a45388de8bb63
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100488
Tested-by: Jenkins CollaboraOffice 
Tested-by: Jenkins
Reviewed-by: Dennis Francis 

diff --git a/loleaflet/src/layer/marker/Marker.js 
b/loleaflet/src/layer/marker/Marker.js
index 2fe48b10b..a73c1826d 100644
--- a/loleaflet/src/layer/marker/Marker.js
+++ b/loleaflet/src/layer/marker/Marker.js
@@ -67,6 +67,7 @@ L.Marker = L.Layer.extend({
var splitPanesPossible = 
this._map._docLayer.hasSplitPanesSupport();
if (splitPanesPossible) {
events.moveend = this.update;
+   events.drag = this.update;
events.splitposchanged = this.update;
}
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2020-08-12 Thread Dennis Francis (via logerrit)

 loleaflet/src/layer/vector/SplitPanesSVG.js |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit c03c8c75318b2ab5a401fdb0f494cc90f8b503e6
Author: Dennis Francis 
AuthorDate: Fri Aug 7 21:24:00 2020 +0530
Commit: Dennis Francis 
CommitDate: Wed Aug 12 10:34:25 2020 +0200

split-panes: update svg container position and viewbox on 'drag'...

so that they do not get out of sync with the canvas on mobile/tablet
swipe/pan.

Note: This does not update the contents(path nodes) of the svg's.  Note:
In the long term we can get rid of the map-pane scrolling and avoid all
this but right now only Calc is using canvas based tile layer.

Change-Id: Iaf6894b0fc39a2a32ac19d0e9acd6abb14336785
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100487
Tested-by: Jenkins CollaboraOffice 
Tested-by: Jenkins
Reviewed-by: Dennis Francis 

diff --git a/loleaflet/src/layer/vector/SplitPanesSVG.js 
b/loleaflet/src/layer/vector/SplitPanesSVG.js
index d114c5cb2..20f350b7a 100644
--- a/loleaflet/src/layer/vector/SplitPanesSVG.js
+++ b/loleaflet/src/layer/vector/SplitPanesSVG.js
@@ -140,7 +140,8 @@ L.SplitPanesSVG = L.SplitPanesRenderer.extend({
 
getEvents: function () {
var events = {
-   splitposchanged: this._update
+   splitposchanged: this._update,
+   drag: this._update,
};
 
return events;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2020-08-12 Thread Dennis Francis (via logerrit)

 loleaflet/src/layer/tile/CanvasTileLayer.js |7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

New commits:
commit 76644df98020a69014e1fc943c9558e74ddb4480
Author: Dennis Francis 
AuthorDate: Fri Aug 7 19:53:19 2020 +0530
Commit: Dennis Francis 
CommitDate: Wed Aug 12 10:32:40 2020 +0200

loleaflet: mobile/tablet: enable tile update check/requests for move

with updateInterval throttle like we do for desktop. This is necessary
for the inertia based scrolling on swipe especially when doing it
rapidly.

Change-Id: I870740c9b6cacfe56fce283f092cc68243fed1a6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100486
Tested-by: Jenkins CollaboraOffice 
Tested-by: Jenkins
Reviewed-by: Dennis Francis 

diff --git a/loleaflet/src/layer/tile/CanvasTileLayer.js 
b/loleaflet/src/layer/tile/CanvasTileLayer.js
index 4d7d5dc1f..93131252e 100644
--- a/loleaflet/src/layer/tile/CanvasTileLayer.js
+++ b/loleaflet/src/layer/tile/CanvasTileLayer.js
@@ -482,14 +482,11 @@ L.CanvasTileLayer = L.TileLayer.extend({
viewreset: this._viewReset,
movestart: this._moveStart,
moveend: this._move,
+   // update tiles on move, but not more often than once 
per given interval
+   move: L.Util.throttle(this._move, 
this.options.updateInterval, this),
splitposchanged: this._move,
};
 
-   if (!this.options.updateWhenIdle) {
-   // update tiles on move, but not more often than once 
per given interval
-   events.move = L.Util.throttle(this._move, 
this.options.updateInterval, this);
-   }
-
if (this._zoomAnimated) {
events.zoomanim = this._animateZoom;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2020-08-12 Thread Dennis Francis (via logerrit)

 loleaflet/src/geometry/Bounds.js  |   39 ++
 loleaflet/src/layer/SplitPanesContext.js  |   37 ++
 loleaflet/src/layer/tile/CanvasTileLayer.js   |  458 ++
 loleaflet/src/layer/tile/GridLayer.js |   23 +
 loleaflet/src/map/handler/Map.TouchGesture.js |7 
 5 files changed, 427 insertions(+), 137 deletions(-)

New commits:
commit 06e4722cc93a4acdbf47700de97ea1a8e98ad6fa
Author: Dennis Francis 
AuthorDate: Fri Aug 7 18:37:11 2020 +0530
Commit: Dennis Francis 
CommitDate: Wed Aug 12 10:31:19 2020 +0200

loleaflet: rewrite tile-prefetcher for L.CanvasTileLayer...

with full support and optimizations for split-panes. This includes some
refactors, for instance the prefetcher implementation is taken out of
the doc-layer methods as a L.TilesPrefetcher class.

Note: This only affects Calc as Writer/Impress are still using
L.TileLayer.

Change-Id: I0e43b58bad0a97d44cbffd1ee0d90d94a9426e29
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100485
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Dennis Francis 

diff --git a/loleaflet/src/geometry/Bounds.js b/loleaflet/src/geometry/Bounds.js
index cadc8e225..8dacdc832 100644
--- a/loleaflet/src/geometry/Bounds.js
+++ b/loleaflet/src/geometry/Bounds.js
@@ -175,7 +175,44 @@ L.Bounds.prototype = {
}
 
return false;
-   }
+   },
+
+   clampX: function (x) {
+   return Math.max(this.min.x, Math.min(this.max.x, x));
+   },
+
+   clampY: function (y) {
+   return Math.max(this.min.y, Math.min(this.max.y, y));
+   },
+
+   clamp: function (obj) {  // (Point) -> Point or (Bounds) -> Bounds
+   if (obj instanceof L.Point) {
+   return new L.Point(
+   this.clampX(obj.x),
+   this.clampY(obj.y)
+   );
+   }
+
+   if (obj instanceof L.Bounds) {
+   return new L.Bounds(
+   new L.Point(
+   this.clampX(obj.min.x),
+   this.clampY(obj.min.y)
+   ),
+
+   new L.Point(
+   this.clampX(obj.max.x),
+   this.clampY(obj.max.y)
+   )
+   );
+   }
+
+   console.error('invalid argument type');
+   },
+
+   equals: function (bounds) { // (Bounds) -> Boolean
+   return this.min.equals(bounds.min) && 
this.max.equals(bounds.max);
+   },
 };
 
 L.bounds = function (a, b) { // (Bounds) or (Point, Point) or (Point[])
diff --git a/loleaflet/src/layer/SplitPanesContext.js 
b/loleaflet/src/layer/SplitPanesContext.js
index 01920ec8e..b75272221 100644
--- a/loleaflet/src/layer/SplitPanesContext.js
+++ b/loleaflet/src/layer/SplitPanesContext.js
@@ -158,6 +158,41 @@ L.SplitPanesContext = L.Class.extend({
this._docLayer.updateVertPaneSplitter();
},
 
+   getPanesProperties: function () {
+   var paneStatusList = [];
+   if (this._splitPos.x && this._splitPos.y) {
+   // top-left pane
+   paneStatusList.push({
+   xFixed: true,
+   yFixed: true,
+   });
+   }
+
+   if (this._splitPos.y) {
+   // top-right pane or top half pane
+   paneStatusList.push({
+   xFixed: false,
+   yFixed: true,
+   });
+   }
+
+   if (this._splitPos.x) {
+   // bottom-left pane or left half pane
+   paneStatusList.push({
+   xFixed: true,
+   yFixed: false,
+   });
+   }
+
+   // bottom-right/bottom-half/right-half pane or the full pane 
(when there are no split-panes active)
+   paneStatusList.push({
+   xFixed: false,
+   yFixed: false,
+   });
+
+   return paneStatusList;
+   },
+
// returns all the pane rectangles for the provided full-map area (all 
in CSS pixels).
getPxBoundList: function (pxBounds) {
if (!pxBounds) {
@@ -191,7 +226,7 @@ L.SplitPanesContext = L.Class.extend({
));
}
 
-   // bottom-right pane or the full pane (when there are no 
split-panes active)
+   // bottom-right/bottom-half/right-half pane or the full pane 
(when there are no split-panes active)
boundList.push(new L

[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - configure.ac

2020-08-12 Thread Tor Lillqvist (via logerrit)

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 44c91ccf95246948752b626c97d6c4940dfe0d39
Author: Tor Lillqvist 
AuthorDate: Mon Aug 10 16:54:36 2020 +0300
Commit: Tor Lillqvist 
CommitDate: Wed Aug 12 10:27:33 2020 +0200

Sukapura is MPL, says icon-themes/sukapura/LICENSE

Change-Id: Ib4e6c5aa423f531c3826c66fb68dbe8149dce0c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100578
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 

diff --git a/configure.ac b/configure.ac
index 2a3fc498a458..a233c332ee85 100644
--- a/configure.ac
+++ b/configure.ac
@@ -13156,7 +13156,7 @@ if test "$enable_mpl_subset" = "yes"; then
 fi
 for theme in $WITH_THEMES; do
 case $theme in
-
breeze|breeze_dark|breeze_dark_svg|breeze_svg|elementary|elementary_svg|karasa_jaga|karasa_jaga_svg|sukapura|sukapura_svg)
 #blacklist of icon themes under GPL or LGPL
+
breeze|breeze_dark|breeze_dark_svg|breeze_svg|elementary|elementary_svg|karasa_jaga|karasa_jaga_svg)
 #blacklist of icon themes under GPL or LGPL
 AC_MSG_ERROR([need to disable icon themes from '$WITH_THEMES': 
$theme present, use --with-theme=colibre]) ;;
 *) : ;;
 esac
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2020-08-12 Thread Dennis Francis (via logerrit)

 loleaflet/src/layer/tile/CanvasTileLayer.js |   16 ++--
 1 file changed, 10 insertions(+), 6 deletions(-)

New commits:
commit b21f0c37cae85c696fc8f4172bd758b504dc7dd0
Author: Dennis Francis 
AuthorDate: Fri Aug 7 17:48:50 2020 +0530
Commit: Dennis Francis 
CommitDate: Wed Aug 12 10:23:40 2020 +0200

loleaflet: decrement _emptyTilesCount when tile is ready...

... and also move the 'statusindicator' event generation code.

Change-Id: Ifdd9eb26d58986ce5fea8ea19f7dc7576d12743e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100484
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Dennis Francis 

diff --git a/loleaflet/src/layer/tile/CanvasTileLayer.js 
b/loleaflet/src/layer/tile/CanvasTileLayer.js
index 57ebab698..3e86d3f0f 100644
--- a/loleaflet/src/layer/tile/CanvasTileLayer.js
+++ b/loleaflet/src/layer/tile/CanvasTileLayer.js
@@ -868,6 +868,16 @@ L.CanvasTileLayer = L.TileLayer.extend({
tile = this._tiles[key];
if (!tile) { return; }
 
+   var emptyTilesCountChanged = false;
+   if (this._emptyTilesCount > 0) {
+   this._emptyTilesCount -= 1;
+   emptyTilesCountChanged = true;
+   }
+
+   if (emptyTilesCountChanged && this._emptyTilesCount === 0) {
+   this._map.fire('statusindicator', { statusType: 
'alltilesloaded' });
+   }
+
tile.loaded = +new Date();
tile.active = true;
 
@@ -1342,12 +1352,6 @@ L.CanvasTileLayer = L.TileLayer.extend({
if (this._tiles[key]._invalidCount > 0) {
this._tiles[key]._invalidCount -= 1;
}
-   if (!tile.loaded) {
-   this._emptyTilesCount -= 1;
-   if (this._emptyTilesCount === 0) {
-   this._map.fire('statusindicator', { 
statusType: 'alltilesloaded' });
-   }
-   }
tile.el.src = img;
}
L.Log.log(textMsg, 'INCOMING', key);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2020-08-12 Thread Dennis Francis (via logerrit)

 loleaflet/src/layer/tile/CanvasTileLayer.js |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c0e59fb50e3be59fac9753ebda6f905728688f8b
Author: Dennis Francis 
AuthorDate: Fri Aug 7 17:25:06 2020 +0530
Commit: Dennis Francis 
CommitDate: Wed Aug 12 10:22:13 2020 +0200

loleaflet: canvas should resize/repaint on map-resize

Fixes canvas update issues when browser window is resized (esp. when
making it larger) and also during sidebar switching.

Change-Id: I4870e5294b355c1bd0c4ca74b22383207ed9d060
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100483
Tested-by: Jenkins CollaboraOffice 
Tested-by: Jenkins
Reviewed-by: Dennis Francis 

diff --git a/loleaflet/src/layer/tile/CanvasTileLayer.js 
b/loleaflet/src/layer/tile/CanvasTileLayer.js
index 3da9ea82e..57ebab698 100644
--- a/loleaflet/src/layer/tile/CanvasTileLayer.js
+++ b/loleaflet/src/layer/tile/CanvasTileLayer.js
@@ -443,7 +443,7 @@ L.CanvasTileLayer = L.TileLayer.extend({
this._map.on('movestart', this._painter.startUpdates, 
this._painter);
this._map.on('moveend', this._painter.stopUpdates, 
this._painter);
}
-   this._map.on('zoomend', this._painter.update, this._painter);
+   this._map.on('resize zoomend', this._painter.update, 
this._painter);
this._map.on('splitposchanged', this._painter.update, 
this._painter);
this._map.on('move', this._syncTilePanePos, this);
},
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2020-08-12 Thread Dennis Francis (via logerrit)

 loleaflet/src/layer/tile/CanvasTileLayer.js |   14 --
 1 file changed, 12 insertions(+), 2 deletions(-)

New commits:
commit 6da69a2584402eed292067a7205eb01a04df8b6e
Author: Dennis Francis 
AuthorDate: Fri Aug 7 17:14:56 2020 +0530
Commit: Dennis Francis 
CommitDate: Wed Aug 12 10:21:25 2020 +0200

loleaflet: mobile/tablet: do not use L.CanvasTilePainter's RAF-loop...

... because the hammerjs swipe handler already uses a
requestAnimationFrame loop to fire move/drag events. Using
L.CanvasTilePainter's own requestAnimationFrame loop to do the updates
in that case results in poor UX/performance.

Change-Id: I2e31fb190b62f57bcb0bd00bec8b7ff4b7119aa1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100482
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Dennis Francis 

diff --git a/loleaflet/src/layer/tile/CanvasTileLayer.js 
b/loleaflet/src/layer/tile/CanvasTileLayer.js
index 51941a73a..3da9ea82e 100644
--- a/loleaflet/src/layer/tile/CanvasTileLayer.js
+++ b/loleaflet/src/layer/tile/CanvasTileLayer.js
@@ -431,8 +431,18 @@ L.CanvasTileLayer = L.TileLayer.extend({
this._cypressHelperDiv = L.DomUtil.create('div', '', 
this._container);
}
 
-   this._map.on('movestart', this._painter.startUpdates, 
this._painter);
-   this._map.on('moveend', this._painter.stopUpdates, 
this._painter);
+   // For mobile/tablet the hammerjs swipe handler already uses a 
requestAnimationFrame to fire move/drag events
+   // Using L.CanvasTilePainter's own requestAnimationFrame loop 
to do the updates in that case does not perform well.
+   if (window.mode.isMobile() || window.mode.isTablet()) {
+   this._map.on('move', this._painter.update, 
this._painter);
+   this._map.on('moveend', function () {
+   setTimeout(this.update.bind(this), 200);
+   }, this._painter);
+   }
+   else {
+   this._map.on('movestart', this._painter.startUpdates, 
this._painter);
+   this._map.on('moveend', this._painter.stopUpdates, 
this._painter);
+   }
this._map.on('zoomend', this._painter.update, this._painter);
this._map.on('splitposchanged', this._painter.update, 
this._painter);
this._map.on('move', this._syncTilePanePos, this);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2020-08-12 Thread Dennis Francis (via logerrit)

 loleaflet/src/map/Map.js |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 9ee08676cc69f7f381f3c9b66bd33903998dfba8
Author: Dennis Francis 
AuthorDate: Fri Aug 7 16:42:30 2020 +0530
Commit: Dennis Francis 
CommitDate: Wed Aug 12 10:19:43 2020 +0200

loleaflet: do not modify the input L.Point...

in containerPointToLayerPoint() and layerPointToContainerPoint() and
hence avoid its side-effects.

Note: L.point() does not copy-construct if the argument is already a
L.Point, so we need to call .clone()

This fixes unwanted scrolling of the map when drag-selecting cells.

Change-Id: If59852fa448c662b11a96d8b5681c59b673403b7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100481
Tested-by: Jenkins CollaboraOffice 
Tested-by: Jenkins
Reviewed-by: Dennis Francis 

diff --git a/loleaflet/src/map/Map.js b/loleaflet/src/map/Map.js
index 13d62dcdd..283b6bbfd 100644
--- a/loleaflet/src/map/Map.js
+++ b/loleaflet/src/map/Map.js
@@ -913,7 +913,7 @@ L.Map = L.Evented.extend({
var splitPos = splitPanesContext.getSplitPos();
var pixelOrigin = this.getPixelOrigin();
var mapPanePos = this._getMapPanePos();
-   var result = L.point(point);
+   var result = L.point(point).clone();
if (point.x <= splitPos.x) {
result.x -= pixelOrigin.x;
}
@@ -944,7 +944,7 @@ L.Map = L.Evented.extend({
var splitPos = splitPanesContext.getSplitPos();
var pixelOrigin = this.getPixelOrigin();
var mapPanePos = this._getMapPanePos();
-   var result = L.point(point)._add(pixelOrigin);
+   var result = L.point(point).add(pixelOrigin);
 
if (result.x > splitPos.x) {
result.x -= (pixelOrigin.x - mapPanePos.x);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

1 2 >

1 - 100 of 113 matches

Mail list logo