[Libreoffice-commits] core.git: sw/sdi sw/source
sw/sdi/_viewsh.sdi | 10 ++
sw/source/uibase/uiview/view2.cxx| 13 +
sw/source/uibase/uiview/viewmdi.cxx |3 +++
sw/source/uibase/uiview/viewstat.cxx | 11 +++
4 files changed, 37 insertions(+)
New commits:
commit 2cddaa6e199ed8bb6185b7825791199f9da4a670
Author: Jim Raykowski
AuthorDate: Tue Sep 15 21:41:25 2020 -0800
Commit: Jim Raykowski
CommitDate: Sun Sep 27 06:34:51 2020 +0200
tdf#45705 Integrate zoom UI commands into Writer text edit view
Change-Id: I71481e018175086a1a1711db22cea03b13eda490
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102830
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sw/sdi/_viewsh.sdi b/sw/sdi/_viewsh.sdi
index e087a07a6126..8231265d4e21 100644
--- a/sw/sdi/_viewsh.sdi
+++ b/sw/sdi/_viewsh.sdi
@@ -18,6 +18,16 @@
interface BaseTextEditView
{
+SID_ZOOM_IN
+[
+ExecMethod = Execute ;
+StateMethod = GetState ;
+]
+SID_ZOOM_OUT
+[
+ExecMethod = Execute ;
+StateMethod = GetState ;
+]
FN_TOGGLE_OUTLINE_CONTENT_VISIBILITY
[
ExecMethod = Execute ;
diff --git a/sw/source/uibase/uiview/view2.cxx
b/sw/source/uibase/uiview/view2.cxx
index b4ae522a2cf9..6866c8b4788a 100644
--- a/sw/source/uibase/uiview/view2.cxx
+++ b/sw/source/uibase/uiview/view2.cxx
@@ -141,6 +141,8 @@
#include
#include
+#include
+
const char sStatusDelim[] = " : ";
using namespace sfx2;
@@ -581,6 +583,17 @@ void SwView::Execute(SfxRequest &rReq)
rTmpWin.SetUseInputLanguage( false );
}
break;
+case SID_ZOOM_IN:
+case SID_ZOOM_OUT:
+{
+long nFact = m_pWrtShell->GetViewOptions()->GetZoom();
+if (SID_ZOOM_OUT == nSlot)
+nFact = basegfx::zoomtools::zoomIn(nFact);
+else
+nFact = basegfx::zoomtools::zoomOut(nFact);
+SetZoom(SvxZoomType::PERCENT, nFact);
+}
+break;
case FN_TO_PREV_PAGE:
case FN_TO_NEXT_PAGE:
{
diff --git a/sw/source/uibase/uiview/viewmdi.cxx
b/sw/source/uibase/uiview/viewmdi.cxx
index 12606618f8e2..3b18942f150d 100644
--- a/sw/source/uibase/uiview/viewmdi.cxx
+++ b/sw/source/uibase/uiview/viewmdi.cxx
@@ -77,6 +77,9 @@ void SwView::SetZoom( SvxZoomType eZoomType, short nFactor,
bool bViewOnly )
if (bCursorIsVisible)
m_pWrtShell->ShowCursor();
+Invalidate(SID_ZOOM_IN);
+Invalidate(SID_ZOOM_OUT);
+
collectUIInformation(OUString::number(nFactor));
}
diff --git a/sw/source/uibase/uiview/viewstat.cxx
b/sw/source/uibase/uiview/viewstat.cxx
index c9ace0d854a0..8c267d180350 100644
--- a/sw/source/uibase/uiview/viewstat.cxx
+++ b/sw/source/uibase/uiview/viewstat.cxx
@@ -69,6 +69,17 @@ void SwView::GetState(SfxItemSet &rSet)
{
switch(nWhich)
{
+case SID_ZOOM_IN:
+case SID_ZOOM_OUT:
+{
+long nFact = m_pWrtShell->GetViewOptions()->GetZoom();
+if ((SID_ZOOM_OUT == nWhich && nFact >= long(600)) ||
+(SID_ZOOM_IN == nWhich && nFact <= long(20)))
+{
+rSet.DisableItem(nWhich);
+}
+}
+break;
case FN_TOGGLE_OUTLINE_CONTENT_VISIBILITY:
{
bool bDisable(true);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx|4 -
sc/source/ui/StatisticsDialogs/ChiSquareTestDialog.cxx |4 -
sc/source/ui/StatisticsDialogs/CorrelationDialog.cxx |4 -
sc/source/ui/StatisticsDialogs/CovarianceDialog.cxx|4 -
sc/source/ui/StatisticsDialogs/DescriptiveStatisticsDialog.cxx |4 -
sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx |4 -
sc/source/ui/StatisticsDialogs/FTestDialog.cxx |4 -
sc/source/ui/StatisticsDialogs/FourierAnalysisDialog.cxx |4 -
sc/source/ui/StatisticsDialogs/MatrixComparisonGenerator.cxx |4 -
sc/source/ui/StatisticsDialogs/MovingAverageDialog.cxx |4 -
sc/source/ui/StatisticsDialogs/RegressionDialog.cxx|4 -
sc/source/ui/StatisticsDialogs/SamplingDialog.cxx | 14 ++---
sc/source/ui/StatisticsDialogs/StatisticsInputOutputDialog.cxx | 14 ++---
sc/source/ui/StatisticsDialogs/StatisticsTwoVariableDialog.cxx | 14 ++---
sc/source/ui/StatisticsDialogs/TTestDialog.cxx |4 -
sc/source/ui/StatisticsDialogs/ZTestDialog.cxx |4 -
sc/source/ui/inc/AnalysisOfVarianceDialog.hxx |2
sc/source/ui/inc/ChiSquareTestDialog.hxx |2
sc/source/ui/inc/CorrelationDialog.hxx |2
sc/source/ui/inc/CovarianceDialog.hxx |2
sc/source/ui/inc/DescriptiveStatisticsDialog.hxx |2
sc/source/ui/inc/ExponentialSmoothingDialog.hxx|2
sc/source/ui/inc/FTestDialog.hxx |2
sc/source/ui/inc/FourierAnalysisDialog.hxx |2
sc/source/ui/inc/MatrixComparisonGenerator.hxx |2
sc/source/ui/inc/MovingAverageDialog.hxx |2
sc/source/ui/inc/RegressionDialog.hxx |2
sc/source/ui/inc/SamplingDialog.hxx|4 -
sc/source/ui/inc/StatisticsInputOutputDialog.hxx |4 -
sc/source/ui/inc/StatisticsTwoVariableDialog.hxx |4 -
sc/source/ui/inc/TTestDialog.hxx |2
sc/source/ui/inc/ZTestDialog.hxx |2
sc/source/ui/view/tabvwshc.cxx | 26
+-
33 files changed, 79 insertions(+), 79 deletions(-)
New commits:
commit 7a4d8f3a6e74e1119e4b1276b0c8599b74a18216
Author: Caolán McNamara
AuthorDate: Sat Sep 26 09:43:41 2020 +0100
Commit: Caolán McNamara
CommitDate: Sat Sep 26 22:21:10 2020 +0200
never null ScViewData*
Change-Id: Ie2c870ef1291b951a68ed4bb9344238d81c23762
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103472
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx
b/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx
index 2ea07a95cbb1..37e580bfa403 100644
--- a/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/AnalysisOfVarianceDialog.cxx
@@ -86,9 +86,9 @@ void lclMakeSubRangesList(ScRangeList& rRangeList, const
ScRange& rInputRange, S
ScAnalysisOfVarianceDialog::ScAnalysisOfVarianceDialog(
SfxBindings* pSfxBindings, SfxChildWindow* pChildWindow,
-weld::Window* pParent, ScViewData* pViewData )
+weld::Window* pParent, ScViewData& rViewData )
: ScStatisticsInputOutputDialog(
-pSfxBindings, pChildWindow, pParent, pViewData,
+pSfxBindings, pChildWindow, pParent, rViewData,
"modules/scalc/ui/analysisofvariancedialog.ui",
"AnalysisOfVarianceDialog")
, meFactor(SINGLE_FACTOR)
diff --git a/sc/source/ui/StatisticsDialogs/ChiSquareTestDialog.cxx
b/sc/source/ui/StatisticsDialogs/ChiSquareTestDialog.cxx
index da12b328d5fb..7fb2d50d7dee 100644
--- a/sc/source/ui/StatisticsDialogs/ChiSquareTestDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/ChiSquareTestDialog.cxx
@@ -16,9 +16,9 @@
ScChiSquareTestDialog::ScChiSquareTestDialog(
SfxBindings* pSfxBindings, SfxChildWindow* pChildWindow,
-weld::Window* pParent, ScViewData* pViewData ) :
+weld::Window* pParent, ScViewData& rViewData ) :
ScStatisticsInputOutputDialog(
-pSfxBindings, pChildWindow, pParent, pViewData,
+pSfxBindings, pChildWindow, pParent, rViewData,
"modules/scalc/ui/chisquaretestdialog.ui", "ChiSquareTestDialog")
{
m_xDialog->set_title(ScResId(STR_CHI_SQUARE_TEST));
diff --git a/sc/source/ui/StatisticsDialogs/CorrelationDialog.cxx
b/sc/source/ui/StatisticsDialogs/CorrelationDialog.cxx
index 5ecd359ab682..7e9a23372635 100644
--- a/sc/source/ui/StatisticsDialogs/CorrelationDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/Correlat
[Libreoffice-commits] core.git: svl/source
svl/source/items/slstitm.cxx |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
New commits:
commit a352e8fe658143c30c9e6093c71cab9c06b42e6a
Author: Caolán McNamara
AuthorDate: Fri Sep 25 15:08:51 2020 +0100
Commit: Caolán McNamara
CommitDate: Sat Sep 26 22:20:50 2020 +0200
Related: tdf#136985 SfxStringListItem::GetString() crash in empty case
probably since...
commit a573b8b21688d9681f4fa129ec37cf89954e9d1c
Date: Sat May 21 16:14:56 2011 -0430
Replace List for std::vector in SfxStringListItem.
Change-Id: I7060b5693ba08fa5f70cc5cb3ae1b7a4722a31a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103408
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/svl/source/items/slstitm.cxx b/svl/source/items/slstitm.cxx
index 05e5401db18e..54af346254d6 100644
--- a/svl/source/items/slstitm.cxx
+++ b/svl/source/items/slstitm.cxx
@@ -125,13 +125,12 @@ OUString SfxStringListItem::GetString()
OUStringBuffer aStr;
if ( mpList )
{
-std::vector::const_iterator iter = mpList->begin();
-for (;;)
+for (auto iter = mpList->begin(), end = mpList->end(); iter != end;)
{
aStr.append(*iter);
++iter;
-if (iter == mpList->end())
+if (iter == end)
break;
aStr.append("\r");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Interested in open source for libre office
Hi Nikhil, Am 26.09.20 um 13:24 schrieb Nikhil varghese: > My name is Nikhil Varghese and I am a 2nd student who is interested in > contributing to open source and I thought it would be good to > contribute to libre office.I am a beginner in open source but I know > the basics of c, c++,java .I just want to know what are the first steps > to be taken and how could I contribute to libre office Please follow the instructions at https://wiki.documentfoundation.org/Development/GetInvolved ATB Jan-Marek ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/FilterFloatingWindow.hxx | 37 +
sc/source/ui/inc/FilterListBox.hxx| 65 ++
sc/source/ui/inc/gridwin.hxx |3 -
sc/source/ui/view/gridwin.cxx | 63 +
4 files changed, 107 insertions(+), 61 deletions(-)
New commits:
commit 7f849f8cbc2ac6618e8b9cf61570942734318295
Author: Tomaž Vajngerl
AuthorDate: Tue Sep 1 16:29:15 2020 +0200
Commit: Tomaž Vajngerl
CommitDate: Sat Sep 26 21:43:00 2020 +0200
sc: move FilterFloatingWindow and FilterListBox out of gridwin.cxx
Change-Id: Ic6e4bb2be86f8c89ac1e5386eb78fe17036b4cc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103404
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/sc/source/ui/inc/FilterFloatingWindow.hxx
b/sc/source/ui/inc/FilterFloatingWindow.hxx
new file mode 100644
index ..71c13c62c864
--- /dev/null
+++ b/sc/source/ui/inc/FilterFloatingWindow.hxx
@@ -0,0 +1,37 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed
+ * with this work for additional information regarding copyright
+ * ownership. The ASF licenses this file to you under the Apache
+ * License, Version 2.0 (the "License"); you may not use this file
+ * except in compliance with the License. You may obtain a copy of
+ * the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#pragma once
+
+#include
+
+class ScFilterFloatingWindow : public FloatingWindow
+{
+private:
+bool m_bGridHadMouseCaptured;
+
+public:
+ScFilterFloatingWindow(vcl::Window* pParent);
+virtual ~ScFilterFloatingWindow() override;
+virtual void dispose() override;
+
+bool MouseWasCaptured() const { return m_bGridHadMouseCaptured; }
+};
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/inc/FilterListBox.hxx
b/sc/source/ui/inc/FilterListBox.hxx
new file mode 100644
index ..1a4685ff5656
--- /dev/null
+++ b/sc/source/ui/inc/FilterListBox.hxx
@@ -0,0 +1,65 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed
+ * with this work for additional information regarding copyright
+ * ownership. The ASF licenses this file to you under the Apache
+ * License, Version 2.0 (the "License"); you may not use this file
+ * except in compliance with the License. You may obtain a copy of
+ * the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#pragma once
+
+#include
+
+class ScGridWindow;
+
+enum class ScFilterBoxMode
+{
+DataSelect,
+Scenario
+};
+
+class ScFilterListBox final : public InterimItemWindow
+{
+private:
+std::unique_ptr xTreeView;
+VclPtr pGridWin;
+SCCOL nCol;
+SCROW nRow;
+bool bInit;
+bool bCancelled;
+sal_uLong nSel;
+ScFilterBoxMode eMode;
+ImplSVEvent* nAsyncSelectHdl;
+
+DECL_LINK(SelectHdl, weld::TreeView&, bool);
+DECL_LINK(KeyInputHdl, const KeyEvent&, bool);
+DECL_LINK(AsyncSelectHdl, void*, void);
+
+public:
+ScFilterListBox(vcl::Window* pParent, ScGridWindow* pGrid, SCCOL nNewCol,
SCROW nNewRow,
+ScFilterBoxMode eNewMode);
+virtual ~ScFilterListBox() override;
+virtual void dispose() override;
+
+weld::TreeView& get_widget() { return *xTreeView; }
+
+SCCOL GetCol() const { return nCol; }
+SCROW GetRow() const { return nRow; }
+ScFilterBoxMode GetMode() const { return eMode; }
+void EndInit();
+bool IsInInit() const { return bInit; }
+void SetCancelled() { bCancelled = true; }
+};
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/inc/gridwin.hxx b/sc/source/ui/inc/gridwin.hxx
index 1af32863045c..8a5a0a751f2f 100644
--- a/sc/source/ui/inc/gridwin.hxx
+++ b/sc/source/ui/inc/gridwin.hxx
@@ -31,6 +31,7 @@
#include
#include
+
namespace editeng {
struct MisspellRanges;
}
@@ -46,7 +47,6 @@ struct ScTableInfo;
class ScDPObject;
class ScDPFieldButton
Re: Interested in open source for libre office
Hello Nikhil, You can start with this link: https://wiki.documentfoundation.org/Development/GetInvolved Julien -- Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 798d9538959cb1c0621ec114afa12e6ce247135d Author: Olivier Hallot AuthorDate: Sat Sep 26 16:16:04 2020 -0300 Commit: Gerrit Code Review CommitDate: Sat Sep 26 21:16:04 2020 +0200 Update git submodules * Update helpcontent2 from branch 'master' to c3a22ded0e03d1629ccfa0b3e025d1bf01c2e452 - Refactor Navigation Help page Change-Id: I9e5f141400468aa3ef02b8a0d75129f944243145 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103486 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 8b0a2c4d66e1..c3a22ded0e03 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 8b0a2c4d66e11ec6f186b5eaf2166adb67cb2bc1 +Subproject commit c3a22ded0e03d1629ccfa0b3e025d1bf01c2e452 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/swriter/01/0211.xhp | 82 ++-- 1 file changed, 41 insertions(+), 41 deletions(-) New commits: commit c3a22ded0e03d1629ccfa0b3e025d1bf01c2e452 Author: Olivier Hallot AuthorDate: Sat Sep 26 10:10:07 2020 -0300 Commit: Olivier Hallot CommitDate: Sat Sep 26 21:16:04 2020 +0200 Refactor Navigation Help page Change-Id: I9e5f141400468aa3ef02b8a0d75129f944243145 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103486 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/swriter/01/0211.xhp b/source/text/swriter/01/0211.xhp index 855b91c05..0bb8c960f 100644 --- a/source/text/swriter/01/0211.xhp +++ b/source/text/swriter/01/0211.xhp @@ -33,7 +33,7 @@ -Navigator +Navigator Shows or hides the Navigator window, where you can quickly jump to different parts of your document. Navigator is also available as a deck of the Sidebar. You can also use the Navigator to insert elements from the current document or other open documents, and to organize master documents. To edit an item in the Navigator, right-click the item, and then choose a command from the context menu. If you want, you can dock the Navigator at the edge of your workspace. @@ -47,13 +47,13 @@ -Toggle Master View +Toggle Master View Switches between master view and normal view if a master document is open. Switches between master view and normal view if a master document is open. - Icon + Icon Toggle Master View Toggle Master View @@ -63,14 +63,14 @@ -Navigation +Navigation Opens the Navigation toolbar, where you can quickly jump to the next or the previous item in the category that you select. Select the category, and then click the "Previous" and "Next" arrows. Opens the Navigation toolbar, where you can quickly jump to the next or the previous item in the category that you select. Select the category, and then click the "Previous" and "Next" arrows. To continue the search, click the Repeat Search icon on the Navigation toolbar. - Icon + Icon Navigation Navigation @@ -80,13 +80,13 @@ -Previous +Previous Jumps to the previous item in the document. To specify the type of item to jump to, click the Navigation icon, and then click an item category - for example, "Images". Jumps to the previous item in the document. To specify the type of item to jump to, click the Navigation icon, and then click an item category - for example, "Images". - Icon + Icon Previous Object Previous Object @@ -96,13 +96,13 @@ -Next +Next Jumps to the next item in the document. To specify the type of item to jump to, click the Navigation icon, and then click an item category - for example, "Images". Jumps to the next item in the document. To specify the type of item to jump to, click the Navigation icon, and then click an item category - for example, "Images". - Icon + Icon Next Object Next Object @@ -112,19 +112,19 @@ -Page number +Page number Type the number of the page that you want to jump to, and then press Enter. -To quickly move the cursor to another page while you are in a document, press Shift+Command -Ctrl+F5, type the number of the page that you want to jump to, and then wait a few moments. +To quickly move the cursor to another page while you are in a document, press Shift+Command +Ctrl+F5, type the number of the page that you want to jump to, and then wait a few moments. -List Box +List Box Shows or hides the Navigator list. - Icon + Icon List box on/off List box on/off @@ -134,13 +134,13 @@ -Content View +Content View Switches between the display of all categories in the Navigator and the selected category. - Icon + Icon Switch Content View Switch Content View @@ -151,13 +151,13 @@ To quickly reorder headings and their associated text in your document, select the "Headings" category in the list, and then click the Content View icon. Now you can use drag-and-drop to reorder contents. -Set Reminder +Set Reminder Click here to set a reminder at the current cursor position. You can define up to five reminders. To jump to a reminder, click the Navigation icon, in the Navigation window click the Reminder icon, and then click the Previous or Next button. Click here to set a reminder at the current cursor position. You can define up to five reminders. To jump to a reminder, click the Navigation icon, in the Navigation window click the Reminder icon, and then click the Previous or Next button. - Icon + Icon Set Reminder Set Reminder @@ -168,13 +168,13 @@ -Header +Header Moves the cursor to the header, or from the header
Re: LTO on Windows now working
Hi, Am 26.09.20 um 19:22 schrieb Michael Meeks: >> With the expense of overhauling the whole package, merging all those >> libs into > Yep, would suck. Of course if it is 2x as fast perhaps worth looking > at but we need numbers. Yeah, and then it works only on amd64 and has problems on other archs, making it completely inconsistent. (I could live with that with libmerged, not for public interface stuff actually links against.) Regards, Rene ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: LTO on Windows now working
On 26/09/2020 08:24, Rene Engelhard wrote: > Am 25.09.20 um 12:54 schrieb Michael Meeks: >> I wonder if, ABI-wise, we could static link sal with libmerged for the >> purpose of LTO and get away with it =) > > I disagree. =) >> Since there is no real C++ ABI, and no exported symbols, particuarly >> exceptions there - that could work across platforms and give a big win. Its possible the easy wins come from static linking the C / sal library and LTO'ing it. >> Ideally we could get down the chain from the grey (cf. attached >> picture) to the bottom there: cppuhelper, xmlreader, cppu, salhelper, sal. > > Nope :) Yep - bit of a packaging nightmare; then again ... I -think- if those libraries are used by C++ plugins only - and these are always loaded after the versions included in the core (easy to guarentee if it's all loaded there). We could continue to install copies of these, but have all the symbols static linked / merged into a big libmerged without real problems. > With the expense of overhauling the whole package, merging all those > libs into Yep, would suck. Of course if it is 2x as fast perhaps worth looking at but we need numbers. Thanks for the feedback, Michael. -- michael.me...@collabora.com <><, GM Collabora Productivity Hangout: mejme...@gmail.com, Skype: mmeeks (M) +44 7795 666 147 - timezone usually UK / Europe ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Questions about ScDrawLayer::RecalcPos
Hi all, I want to fix tdf#137020 "FILEOPEN Vertical flipped, cell anchored shapes have wrong position on opening". The error happens in ScDrawLayer::RecalcPos in sc\source\core\data\drwlayer.cxx. Vertical flipped custom shapes have an additional 180deg rotation, which is not considered when calculating the rectangles. But before I can start, I need to be sure, that I understand the context correctly. Therefore some questions. (A) There is (#947) a condition "if (rData.getShapeRect().IsEmpty())". That condition is met, if the file is opened. Is it always met on opening? Are there other situations in which the condition is met? (B) After ScDrawLayer::RecalcPos is finished, the UserDataList in PlusData of the shape will have two items of ScDrawObjData of kind SC_UD_OBJDATA. The first one corresponds to rData, the second one to rNoRotatedAnchor in method RecalcPos. Correct? The member maShapeRect in the first item will be the same as maSnapRect of the shape, and maShapeRect in the second item will be the same as maRect of the shape. In both cases hidden row/col are treated as zero for maShapeRect. Correct? But maStart, maEnd and their offsets in the first item will be taken from the snap rectangle of the shape, whereby hidden row/col are not treated as zero, whereas the second item has them taken from the logic rectangle of the shape and hidden row/col are treated as zero. Correct? (C) In case XML has an attribute table:end-cell-address, the ScAnchorType is SCA_CELL_RESIZE. In that case XML-import has not produced valid values for maRect (logic rectangle) of the shape, because row/col size and hidden state are not known at that place. And more, ODF has the rule to ignore svg:width and svg:height in that case, and these size attributes need not exist at all. So I would expect as first action in RecalcPos in that case, that maRect gets current, valid values considering maStart, maEnd and their offsets in rData. That does not happen. Why? (D) In case SCA_CELL, the XML-import has produced valid values for maRect and maSnapRect of the shape. They are overwritten with values generated from the anchor. Reason? I would expect, that at least rNoRotatedAnchor uses the values from the XML-import directly in this case. Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Regarding the contribution for libre office
Bharanidharan Sundar kirjoitti 26.9.2020 klo 19.00: Hi, I’m Bharani, a 2nd year computer science engineering student from India. I’m new to open source projects but I’m very much interested in contributing and I’m planning to kick start my open source journey with Libre office. But I have some doubts about how to start my contribution and I would like to know it. Kindly let me know If there’s any project available and I’m sure I’ll give my best in the future. I have invited you to an interview. To anyone else reading this, this is how you start: https://wiki.documentfoundation.org/Development/GetInvolved Ilmari ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
Regarding the contribution for libre office
Hi, I’m Bharani, a 2nd year computer science engineering student from India. I’m new to open source projects but I’m very much interested in contributing and I’m planning to kick start my open source journey with Libre office. But I have some doubts about how to start my contribution and I would like to know it. Kindly let me know If there’s any project available and I’m sure I’ll give my best in the future. Regards, Bharani. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: canvas/source filter/source include/basegfx include/tools include/vcl vcl/source
canvas/source/vcl/canvashelper.cxx | 14 -
canvas/source/vcl/canvashelper_texturefill.cxx | 18 -
canvas/source/vcl/impltools.cxx | 14 -
canvas/source/vcl/impltools.hxx |4
canvas/source/vcl/spritehelper.cxx |2
filter/source/graphicfilter/idxf/dxf2mtf.cxx| 11 -
filter/source/graphicfilter/ios2met/ios2met.cxx | 243 +++-
include/basegfx/polygon/b2dpolygon.hxx |1
include/basegfx/polygon/b2dpolypolygon.hxx |1
include/tools/gen.hxx | 16 -
include/vcl/outdev.hxx |2
vcl/source/outdev/polyline.cxx | 30 --
12 files changed, 148 insertions(+), 208 deletions(-)
New commits:
commit 5cb62b13ca8fec43fffe3f2000f61c1be7c5616c
Author: Noel Grandin
AuthorDate: Sat Sep 26 14:41:02 2020 +0200
Commit: Noel Grandin
CommitDate: Sat Sep 26 17:39:33 2020 +0200
revert recent Polygon commits
This reverts
commit 0cabffc05f3b40f5ee897df73475e09a3c05fc7
tools::PolyPolygon -> basegfx in canvas
and
commit 2c5d5a6d55a1ebd153f05523972a2c625484bde2
tools::PolyPolygon -> basegfx in filter
Comment from quikee:
The interpretation of integer polygons and floating point polygons
(or any other float vs. int drawing primitives) are different,
so you have to be really careful when changing, that the result
after the change is still the same. A big problem is that we still
have the metafile in OutputDevice, which is completely integer based
- so there will be conversions that go from int representation to
float representation to int again and to float (because backend is
in floating point) and I really fear that because of this there will
be regressions and even if not, it could make changing later more
painful. This is the reason I wouldn't change these things without
having tests that would show when there is a difference in rendering.
Change-Id: I54addca4e5a72196b5f77f6c7689eb716451c1dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103483
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/canvas/source/vcl/canvashelper.cxx
b/canvas/source/vcl/canvashelper.cxx
index a62057ce4a30..5cc5f3c42b73 100644
--- a/canvas/source/vcl/canvashelper.cxx
+++ b/canvas/source/vcl/canvashelper.cxx
@@ -266,7 +266,7 @@ namespace vclcanvas
const ::basegfx::B2DPolyPolygon& rPolyPoly(
::basegfx::unotools::b2DPolyPolygonFromXPolyPolygon2D(xPolyPolygon) );
-const ::basegfx::B2DPolyPolygon aPolyPoly( tools::mapPolyPolygon(
rPolyPoly, viewState, renderState ) );
+const ::tools::PolyPolygon aPolyPoly( tools::mapPolyPolygon(
rPolyPoly, viewState, renderState ) );
if( rPolyPoly.isClosed() )
{
@@ -284,9 +284,9 @@ namespace vclcanvas
// DrawPolygon(), and open ones via DrawPolyLine():
// closed polygons will simply already contain the
// closing segment.
-sal_uInt32 nSize( aPolyPoly.count() );
+sal_uInt16 nSize( aPolyPoly.Count() );
-for( sal_uInt32 i=0; igetOutDev().DrawPolyLine( aPolyPoly[i] );
@@ -476,7 +476,7 @@ namespace vclcanvas
::basegfx::B2DPolyPolygon aB2DPolyPoly(
::basegfx::unotools::b2DPolyPolygonFromXPolyPolygon2D(xPolyPolygon));
aB2DPolyPoly.setClosed(true); // ensure closed poly, otherwise VCL
does not fill
-const ::basegfx::B2DPolyPolygon aPolyPoly( tools::mapPolyPolygon(
+const ::tools::PolyPolygon aPolyPoly( tools::mapPolyPolygon(
aB2DPolyPoly,
viewState, renderState ) );
const bool bSourceAlpha( renderState.CompositeOperation ==
rendering::CompositeOperation::SOURCE );
@@ -486,10 +486,8 @@ namespace vclcanvas
}
else
{
-const double dTransparency( (nTransparency + 128) / 255.0 );
-basegfx::B2DHomMatrix aIdentityMatrix;
-aIdentityMatrix.identity();
-mpOutDevProvider->getOutDev().DrawTransparent(
aIdentityMatrix, aPolyPoly, dTransparency );
+const int nTransPercent( (nTransparency * 100 + 128) / 255 );
// normal rounding, no truncation here
+mpOutDevProvider->getOutDev().DrawTransparent( aPolyPoly,
static_cast(nTransPercent) );
}
if( mp2ndOutDevProvider )
diff --git a/canvas/source/vcl/canvashelper_texturefill.cxx
b/canvas/source/vcl/canvashelper_texturefill.cxx
index b0b0ef3770d5..9cb8dd8abd99 100644
--- a/canvas/source/vcl/canvashelper_texturefill.cxx
+++ b/canvas/source/vcl/canvashelper_texturefill.cxx
@@ -437,7 +437,7 @@ namespace vclcanvas
OutputDev
[Libreoffice-commits] core.git: sc/inc
sc/inc/globstr.hrc |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 949d648594f441dbb7e9c600d7925fba7e882ff9
Author: Roman Kuznetsov
AuthorDate: Thu Sep 17 22:08:58 2020 +0200
Commit: Roman Kuznetsov
CommitDate: Sat Sep 26 17:26:52 2020 +0200
tdf#112279 Change the error message to more clear
Change-Id: Ib166e66b9a9cbf5cd29811dc1d0715a45ee920b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102934
Tested-by: Jenkins
Reviewed-by: Roman Kuznetsov
diff --git a/sc/inc/globstr.hrc b/sc/inc/globstr.hrc
index 063d51a3d2ec..a325e4087555 100644
--- a/sc/inc/globstr.hrc
+++ b/sc/inc/globstr.hrc
@@ -430,7 +430,7 @@
#define STR_MULTI_SELECTNC_("STR_MULTI_SELECT",
"(multiple)")
#define STR_GLOBAL_SCOPENC_("STR_GLOBAL_SCOPE",
"Document (Global)")
#define STR_ERR_NAME_EXISTS NC_("STR_ERR_NAME_EXISTS",
"Invalid name. Already in use for the selected scope.")
-#define STR_ERR_NAME_INVALIDNC_("STR_ERR_NAME_INVALID",
"Invalid name. Only use letters, numbers and underscore.")
+#define STR_ERR_NAME_INVALIDNC_("STR_ERR_NAME_INVALID",
"Invalid name. Start with a letter, use only letters, numbers and underscore.")
#define STR_UNSAVED_EXT_REF NC_("STR_UNSAVED_EXT_REF",
"This Document contains external references to unsaved documents.\n\nDo you
want to continue?")
#define STR_CLOSE_WITH_UNSAVED_REFS
NC_("STR_CLOSE_WITH_UNSAVED_REFS", "This Document is referenced by another
document and not yet saved. Closing it without saving will result in data
loss.")
#define STR_COND_CONDITION NC_("STR_COND_CONDITION",
"Cell value")
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Interested in open source for libre office
My name is Nikhil Varghese and I am a 2nd student who is interested in contributing to open source and I thought it would be good to contribute to libre office.I am a beginner in open source but I know the basics of c, c++,java .I just want to know what are the first steps to be taken and how could I contribute to libre office ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: vcl/qt5
vcl/qt5/Qt5Widget.cxx |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
New commits:
commit 07d6371f1dc5deef461581ad73c4af5c9f5b9821
Author: Stephan Bergmann
AuthorDate: Sat Sep 26 11:56:03 2020 +0200
Commit: Stephan Bergmann
CommitDate: Sat Sep 26 15:53:20 2020 +0200
Avoid -Werror=deprecated-declarations
...with qt5-qtbase-devel-5.15.1-1.fc33.x86_64 on Fedora 33:
> ~/lo/core/vcl/qt5/Qt5Widget.cxx: In member function ‘virtual void
Qt5Widget::wheelEvent(QWheelEvent*)’:
> ~/lo/core/vcl/qt5/Qt5Widget.cxx:144:59: error: ‘QPoint QWheelEvent::pos()
const’ is deprecated: Use position() [-Werror=deprecated-declarations]
> 144 | fillSalAbstractMouseEvent(rFrame, pEvent, pEvent->pos(),
pEvent->buttons(), nWidth, aEvent)
> | ^
> ~/lo/core/vcl/qt5/Qt5Widget.cxx:196:5: note: in expansion of macro
‘FILL_SAME’
> 196 | FILL_SAME(m_rFrame, width());
> | ^
> In file included from /usr/include/qt5/QtGui/QFocusEvent:1,
> from ~/lo/core/vcl/qt5/Qt5Widget.cxx:32:
> /usr/include/qt5/QtGui/qevent.h:225:19: note: declared here
> 225 | inline QPoint pos() const { return p.toPoint(); }
> | ^~~
But for one the types used by the other calls of the FILL_SAME macro do not
have
a position member function, so stop using the macro and spell it out
explicitly
here. And for another, QWheelEvent::position returns a QPointF instead of a
QPoint, so need to convert that with toPoint. And for a third,
QWheelEvent::position is only available since Qt 5.14 according to
.
Change-Id: I6e64fc9717a9f5a85303f070c6a1b66ed21ec458
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103475
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/vcl/qt5/Qt5Widget.cxx b/vcl/qt5/Qt5Widget.cxx
index 2d3951ad8203..40500585e1fe 100644
--- a/vcl/qt5/Qt5Widget.cxx
+++ b/vcl/qt5/Qt5Widget.cxx
@@ -193,7 +193,12 @@ void Qt5Widget::mouseMoveEvent(QMouseEvent* pEvent)
void Qt5Widget::wheelEvent(QWheelEvent* pEvent)
{
SalWheelMouseEvent aEvent;
-FILL_SAME(m_rFrame, width());
+#if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)
+fillSalAbstractMouseEvent(m_rFrame, pEvent, pEvent->position().toPoint(),
pEvent->buttons(),
+ width(), aEvent);
+#else
+fillSalAbstractMouseEvent(m_rFrame, pEvent, pEvent->pos(),
pEvent->buttons(), width(), aEvent);
+#endif
// mouse wheel ticks are 120, which we map to 3 lines.
// we have to accumulate for touch scroll to keep track of the absolute
delta.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/qt5
vcl/qt5/Qt5AccessibleWidget.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit ed424cf629b2ab33089b1be0dccfce60be85d726
Author: Stephan Bergmann
AuthorDate: Sat Sep 26 11:51:56 2020 +0200
Commit: Stephan Bergmann
CommitDate: Sat Sep 26 14:51:44 2020 +0200
Avoid -Werror=deprecated-declarations
...with qt5-qtbase-devel-5.15.1-1.fc33.x86_64 on Fedora 33:
> ~/lo/core/vcl/qt5/Qt5AccessibleWidget.cxx: In function
‘QAccessible::Relation {anonymous}::lcl_matchUnoRelation(short int)’:
> ~/lo/core/vcl/qt5/Qt5AccessibleWidget.cxx:138:20: error: ‘constexpr
QFlags::QFlags(QFlags::Zero) [with Enum = QAccessible::RelationFlag;
QFlags::Zero = int QFlags::Private::*]’ is
deprecated: Use default constructor instead [-Werror=deprecated-declarations]
> 138 | return nullptr;
> |^~~
> In file included from /usr/include/qt5/QtCore/qglobal.h:1304,
> from /usr/include/qt5/QtCore/qnamespace.h:43,
> from /usr/include/qt5/QtCore/qobjectdefs.h:48,
> from /usr/include/qt5/QtCore/qobject.h:46,
> from /usr/include/qt5/QtCore/QObject:1,
> from ~/lo/core/vcl/inc/qt5/Qt5AccessibleWidget.hxx:14,
> from ~/lo/core/vcl/qt5/Qt5AccessibleWidget.cxx:20:
> /usr/include/qt5/QtCore/qflags.h:123:80: note: declared here
> 123 | QT_DEPRECATED_X("Use default constructor instead")
Q_DECL_CONSTEXPR inline QFlags(Zero) noexcept : i(0) {}
> |
^~
Change-Id: Ic0c113fe208764e8bc0b9c3fbf7358d6af4000ce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103474
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/vcl/qt5/Qt5AccessibleWidget.cxx b/vcl/qt5/Qt5AccessibleWidget.cxx
index 9933444d9092..1f33cec86e3c 100644
--- a/vcl/qt5/Qt5AccessibleWidget.cxx
+++ b/vcl/qt5/Qt5AccessibleWidget.cxx
@@ -135,7 +135,7 @@ QAccessible::Relation lcl_matchUnoRelation(short
relationType)
case AccessibleRelationType::DESCRIBED_BY:
default:
SAL_WARN("vcl.qt5", "Unmatched relation: " << relationType);
-return nullptr;
+return {};
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/generic/app/i18n_cb.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 782d160458d319c6c77fffa4c003c519afffaa17
Author: Stephan Bergmann
AuthorDate: Sat Sep 26 11:38:51 2020 +0200
Commit: Stephan Bergmann
CommitDate: Sat Sep 26 14:43:18 2020 +0200
Avoid -Werror=nonnull with glibc-headers-x86-2.32-1.fc33.noarch
...on Fedora 33:
> ~/lo/core/vcl/unx/generic/app/i18n_cb.cxx: In function ‘void
Preedit_InsertText(preedit_text_t*, XIMText*, int)’:
> ~/lo/core/vcl/unx/generic/app/i18n_cb.cxx:149:34: error: argument 1 is
null but the corresponding size argument 3 value is 1024 [-Werror=nonnull]
> 149 | size_t nBytes = wcstombs ( nullptr, pWCString, 1024 /*
don't care */);
> |
~^~~~
> In file included from ~/gcc/trunk/inst/include/c++/11.0.0/cstdlib:75,
> from ~/lo/core/include/sal/log.hxx:15,
> from ~/lo/core/vcl/unx/generic/app/i18n_cb.cxx:25:
> /usr/include/stdlib.h:937:15: note: in a call to function ‘size_t
wcstombs(char*, const wchar_t*, size_t)’ declared with attribute ‘access
(write_only, 1, 3)’
> 937 | extern size_t wcstombs (char *__restrict __s,
> | ^~~~
(Allowing the first argument to wcstombs to be null, and in which case the
third
argument is ignored, is a POSIX extension.)
Change-Id: Ic078623643010b7539bc5bc1b498f18977ae77ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103473
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/vcl/unx/generic/app/i18n_cb.cxx b/vcl/unx/generic/app/i18n_cb.cxx
index 4e5f9952c20f..c17c01a4d225 100644
--- a/vcl/unx/generic/app/i18n_cb.cxx
+++ b/vcl/unx/generic/app/i18n_cb.cxx
@@ -146,7 +146,7 @@ Preedit_InsertText(preedit_text_t *pText, XIMText
*pInsertText, int where)
if (pInsertText->encoding_is_wchar)
{
wchar_t *pWCString = pInsertText->string.wide_char;
-size_t nBytes = wcstombs ( nullptr, pWCString, 1024 /* don't care */);
+size_t nBytes = wcstombs ( nullptr, pWCString, 0 /* don't care */);
pMBString = static_cast(alloca( nBytes + 1 ));
nMBLength = wcstombs ( pMBString, pWCString, nBytes + 1);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source sc/util
sc/source/ui/unoobj/funcuno.cxx |2 +-
sc/util/sc.component|2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit efca4cfd16936ecd0b795967e3f0e95c812f36e3
Author: Andrea Gelmini
AuthorDate: Fri Sep 25 13:23:45 2020 +0200
Commit: Stephan Bergmann
CommitDate: Sat Sep 26 14:38:10 2020 +0200
Fix typo in code
It passed "make check" on Linux
Change-Id: I16853a42b0f80fd09dce42971f6d165edbf2a5be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103461
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/sc/source/ui/unoobj/funcuno.cxx b/sc/source/ui/unoobj/funcuno.cxx
index 89ea794a3583..6f26b0b04c85 100644
--- a/sc/source/ui/unoobj/funcuno.cxx
+++ b/sc/source/ui/unoobj/funcuno.cxx
@@ -198,7 +198,7 @@ void ScFunctionAccess::Notify( SfxBroadcaster&, const
SfxHint& rHint )
}
extern "C" SAL_DLLPUBLIC_EXPORT css::uno::XInterface*
-ScFunctionAcceess_get_implementation(css::uno::XComponentContext*,
css::uno::Sequence const &)
+ScFunctionAccess_get_implementation(css::uno::XComponentContext*,
css::uno::Sequence const &)
{
SolarMutexGuard aGuard;
ScDLL::Init();
diff --git a/sc/util/sc.component b/sc/util/sc.component
index 7f40cc642113..d813ff25cd9e 100644
--- a/sc/util/sc.component
+++ b/sc/util/sc.component
@@ -92,7 +92,7 @@
+ constructor="ScFunctionAccess_get_implementation">
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2eca3d2b0ab3fcd6a3bce15f3b68235d14921feb Author: Johnny_M AuthorDate: Sat Sep 26 14:32:57 2020 +0200 Commit: Gerrit Code Review CommitDate: Sat Sep 26 14:32:57 2020 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 8b0a2c4d66e11ec6f186b5eaf2166adb67cb2bc1 - tdf#132643 Translate German section IDs Change-Id: Iaec59772e78095a10c4c28e246e77c0469723cbc Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103480 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index a46f935b2d00..8b0a2c4d66e1 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit a46f935b2d00c823e30c21b4cb02967fff86bc89 +Subproject commit 8b0a2c4d66e11ec6f186b5eaf2166adb67cb2bc1 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/scalc/01/0214.xhp |2 +- source/text/scalc/01/02140200.xhp |2 +- source/text/scalc/main0202.xhp |2 +- source/text/scalc/main0205.xhp |2 +- source/text/shared/00/00040501.xhp |4 ++-- source/text/shared/00/00040502.xhp |4 ++-- source/text/shared/01/05030700.xhp |2 +- source/text/shared/01/0507.xhp |2 +- source/text/shared/01/05070300.xhp |4 ++-- source/text/shared/01/0508.xhp |2 +- source/text/shared/01/05080200.xhp |4 ++-- source/text/shared/01/05340300.xhp |2 +- source/text/shared/02/0511.xhp |2 +- source/text/simpress/main0203.xhp |4 ++-- source/text/swriter/main0202.xhp |4 ++-- source/text/swriter/main0215.xhp |4 ++-- source/text/swriter/main0216.xhp |4 ++-- source/text/swriter/main0220.xhp |4 ++-- 18 files changed, 27 insertions(+), 27 deletions(-) New commits: commit 8b0a2c4d66e11ec6f186b5eaf2166adb67cb2bc1 Author: Johnny_M AuthorDate: Sat Sep 26 12:05:34 2020 +0200 Commit: Olivier Hallot CommitDate: Sat Sep 26 14:32:57 2020 +0200 tdf#132643 Translate German section IDs Change-Id: Iaec59772e78095a10c4c28e246e77c0469723cbc Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103480 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/scalc/01/0214.xhp b/source/text/scalc/01/0214.xhp index 475e68ba7..61fa1a4dd 100644 --- a/source/text/scalc/01/0214.xhp +++ b/source/text/scalc/01/0214.xhp @@ -42,7 +42,7 @@ The $[officename] Calc context menus have additional options for filling the cells. - + Sheet diff --git a/source/text/scalc/01/02140200.xhp b/source/text/scalc/01/02140200.xhp index 5b24a5708..a05a478d3 100644 --- a/source/text/scalc/01/02140200.xhp +++ b/source/text/scalc/01/02140200.xhp @@ -32,7 +32,7 @@ - + Right Fills a selected range of at least two columns with the contents of the left most cell. diff --git a/source/text/scalc/main0202.xhp b/source/text/scalc/main0202.xhp index 2b8ab8b83..1b974d6d9 100644 --- a/source/text/scalc/main0202.xhp +++ b/source/text/scalc/main0202.xhp @@ -55,7 +55,7 @@ Align Right - + Justify diff --git a/source/text/scalc/main0205.xhp b/source/text/scalc/main0205.xhp index 4ecda2864..d0b6b025f 100644 --- a/source/text/scalc/main0205.xhp +++ b/source/text/scalc/main0205.xhp @@ -65,7 +65,7 @@ Align Right - + Justify diff --git a/source/text/shared/00/00040501.xhp b/source/text/shared/00/00040501.xhp index 875296ff8..938401fb1 100644 --- a/source/text/shared/00/00040501.xhp +++ b/source/text/shared/00/00040501.xhp @@ -350,11 +350,11 @@ - + Choose Format - Align - Right. Choose Shape - Align - Right (objects selected) ($[officename] Draw). On Align bar ($[officename] Impress, $[officename] Draw), click - + diff --git a/source/text/shared/00/00040502.xhp b/source/text/shared/00/00040502.xhp index 1f8fb0002..427041ccd 100644 --- a/source/text/shared/00/00040502.xhp +++ b/source/text/shared/00/00040502.xhp @@ -333,10 +333,10 @@ - + Choose Format - Align - Right (drawing functions). Open context menu - choose Align - Right. - + diff --git a/source/text/shared/01/05030700.xhp b/source/text/shared/01/05030700.xhp index 6ed154874..9e4e5b7ef 100644 --- a/source/text/shared/01/05030700.xhp +++ b/source/text/shared/01/05030700.xhp @@ -57,7 +57,7 @@ Aligns the paragraph to the right page margin. If Asian language support is enabled, this option is named Right/Bottom. - + Centered Centers the contents of the paragraph on the page. diff --git a/source/text/shared/01/0507.xhp b/source/text/shared/01/0507.xhp index 00bc38da4..83c838744 100644 --- a/source/text/shared/01/0507.xhp +++ b/source/text/shared/01/0507.xhp @@ -43,7 +43,7 @@ Not all types of objects can be selected together. Not all modules (Writer, Calc, Impress, Draw) support all types of alignment. - + diff --git a/source/text/shared/01/05070300.xhp b/source/text/shared/01/05070300.xhp index 836d58879..67ee6afd0 100644 --- a/source/text/shared/01/05070300.xhp +++ b/source/text/shared/01/05070300.xhp @@ -27,14 +27,14 @@ - + Align Right Aligns the right edges of the selected objects. If only one object is selected in Impress or Draw, the right edge of the object is aligned to the right page margin. - + Objects are aligned to the right edge of the rightmost object in the selection. diff --git a/source/text/shared/01/0508.xhp b/source/text/shared/01/0508.xhp index e185245ce..5c71f6681 100644 --- a/source/text/shared/01/0508.xhp +++ b/source/text/shared/01/0508.xhp @@ -41,7 +
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 690549c7f849859e8023ec7c4ed879c282fb274f Author: Johnny_M AuthorDate: Sat Sep 26 14:31:28 2020 +0200 Commit: Gerrit Code Review CommitDate: Sat Sep 26 14:31:28 2020 +0200 Update git submodules * Update helpcontent2 from branch 'master' to a46f935b2d00c823e30c21b4cb02967fff86bc89 - tdf#132643 Translate German section IDs Change-Id: Ie8e1f394075477c73c70e5e7c01b0142f13888b7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103479 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 07b4bae30ce7..a46f935b2d00 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 07b4bae30ce73c71223a270e3cb6facb84cfeaf1 +Subproject commit a46f935b2d00c823e30c21b4cb02967fff86bc89 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/shared/01/0525.xhp |2 +- source/text/shared/01/05250300.xhp |2 +- source/text/simpress/01/0525.xhp |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) New commits: commit a46f935b2d00c823e30c21b4cb02967fff86bc89 Author: Johnny_M AuthorDate: Sat Sep 26 11:39:58 2020 +0200 Commit: Olivier Hallot CommitDate: Sat Sep 26 14:31:28 2020 +0200 tdf#132643 Translate German section IDs Change-Id: Ie8e1f394075477c73c70e5e7c01b0142f13888b7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103479 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/01/0525.xhp b/source/text/shared/01/0525.xhp index 3cba601aa..c236962a4 100644 --- a/source/text/shared/01/0525.xhp +++ b/source/text/shared/01/0525.xhp @@ -53,7 +53,7 @@ Each object that you place in your document is successively stacked on the preceding object. Use the arrange commands to change the stacking order of objects in your document. You cannot change the stacking order of text. - + diff --git a/source/text/shared/01/05250300.xhp b/source/text/shared/01/05250300.xhp index 353dd4bd9..95db4ebef 100644 --- a/source/text/shared/01/05250300.xhp +++ b/source/text/shared/01/05250300.xhp @@ -27,7 +27,7 @@ - + Send Backward diff --git a/source/text/simpress/01/0525.xhp b/source/text/simpress/01/0525.xhp index 988aea717..d49e45122 100644 --- a/source/text/simpress/01/0525.xhp +++ b/source/text/simpress/01/0525.xhp @@ -38,7 +38,7 @@ - + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/shared/01/0223.xhp |2 +- source/text/shared/01/02230100.xhp |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 07b4bae30ce73c71223a270e3cb6facb84cfeaf1 Author: Johnny_M AuthorDate: Sat Sep 26 11:36:15 2020 +0200 Commit: Olivier Hallot CommitDate: Sat Sep 26 14:30:46 2020 +0200 tdf#132643 Translate German section IDs Change-Id: I32e37d573903af82bd14e353df9611b2e2125489 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103478 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/01/0223.xhp b/source/text/shared/01/0223.xhp index e6a4dd43e..d15c8296c 100644 --- a/source/text/shared/01/0223.xhp +++ b/source/text/shared/01/0223.xhp @@ -41,7 +41,7 @@ - + diff --git a/source/text/shared/01/02230100.xhp b/source/text/shared/01/02230100.xhp index ac84e321b..2db299b0f 100644 --- a/source/text/shared/01/02230100.xhp +++ b/source/text/shared/01/02230100.xhp @@ -28,7 +28,7 @@ - + Record Changes ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 23f3298460fb3e58459df0d0181348d2ba595459 Author: Johnny_M AuthorDate: Sat Sep 26 14:30:10 2020 +0200 Commit: Gerrit Code Review CommitDate: Sat Sep 26 14:30:10 2020 +0200 Update git submodules * Update helpcontent2 from branch 'master' to be7f9b6a251b2cbcd24aa1f2b97b8e095593b2bf - tdf#132643 Translate German section IDs Change-Id: Ifb561c069a27e71c66652289ffa4099ba4ec7e68 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103477 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 21d65441845c..be7f9b6a251b 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 21d65441845c1265e3efb8fe9dade212fee70240 +Subproject commit be7f9b6a251b2cbcd24aa1f2b97b8e095593b2bf ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e207033c671330c218db52e18e649b998c58658d Author: Johnny_M AuthorDate: Sat Sep 26 14:30:46 2020 +0200 Commit: Gerrit Code Review CommitDate: Sat Sep 26 14:30:46 2020 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 07b4bae30ce73c71223a270e3cb6facb84cfeaf1 - tdf#132643 Translate German section IDs Change-Id: I32e37d573903af82bd14e353df9611b2e2125489 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103478 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index be7f9b6a251b..07b4bae30ce7 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit be7f9b6a251b2cbcd24aa1f2b97b8e095593b2bf +Subproject commit 07b4bae30ce73c71223a270e3cb6facb84cfeaf1 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/scalc/main0106.xhp |2 +- source/text/sdraw/main_tools.xhp|2 +- source/text/shared/00/0406.xhp |4 ++-- source/text/shared/01/0601.xhp |4 ++-- source/text/shared/01/0699.xhp |2 +- source/text/shared/main0201.xhp |2 +- source/text/simpress/main_tools.xhp |2 +- source/text/swriter/main0106.xhp|2 +- 8 files changed, 10 insertions(+), 10 deletions(-) New commits: commit be7f9b6a251b2cbcd24aa1f2b97b8e095593b2bf Author: Johnny_M AuthorDate: Sat Sep 26 11:27:53 2020 +0200 Commit: Olivier Hallot CommitDate: Sat Sep 26 14:30:10 2020 +0200 tdf#132643 Translate German section IDs Change-Id: Ifb561c069a27e71c66652289ffa4099ba4ec7e68 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103477 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/scalc/main0106.xhp b/source/text/scalc/main0106.xhp index 1e2f2f408..8547a7bd8 100644 --- a/source/text/scalc/main0106.xhp +++ b/source/text/scalc/main0106.xhp @@ -31,7 +31,7 @@ The Tools menu contains commands to check spelling, to trace sheet references, to find mistakes and to define scenarios. You can also create and assign macros and configure the look and feel of toolbars, menus, keyboard, and set the default options for $[officename] applications. - + AutoCorrect Options diff --git a/source/text/sdraw/main_tools.xhp b/source/text/sdraw/main_tools.xhp index 43002a69c..597b2901b 100644 --- a/source/text/sdraw/main_tools.xhp +++ b/source/text/sdraw/main_tools.xhp @@ -31,7 +31,7 @@ Tools This menu provides tools for $[officename] Draw as well as access to language and system settings. - + ImageMap diff --git a/source/text/shared/00/0406.xhp b/source/text/shared/00/0406.xhp index 6b10c6e7d..b20820ffe 100644 --- a/source/text/shared/00/0406.xhp +++ b/source/text/shared/00/0406.xhp @@ -44,11 +44,11 @@ Choose Tools - Gallery or click the Gallery icon on the Standard bar -New Theme button - Files tab. - + Choose Tools - Spelling. F7 key On the Standard bar, click - + diff --git a/source/text/shared/01/0601.xhp b/source/text/shared/01/0601.xhp index cd69a5e69..9f7c0c72e 100644 --- a/source/text/shared/01/0601.xhp +++ b/source/text/shared/01/0601.xhp @@ -27,7 +27,7 @@ - + dictionaries; spellcheck spellcheck; dialog dictionaries; spelling @@ -44,7 +44,7 @@ - + The spellcheck starts at the current cursor position and advances to the end of the document or selection. You can then choose to continue the spellcheck from the beginning of the document. diff --git a/source/text/shared/01/0699.xhp b/source/text/shared/01/0699.xhp index a291dc7b3..cc608eafa 100644 --- a/source/text/shared/01/0699.xhp +++ b/source/text/shared/01/0699.xhp @@ -30,7 +30,7 @@ - + Spelling Checks spelling manually. diff --git a/source/text/shared/main0201.xhp b/source/text/shared/main0201.xhp index 2e43c77d1..b4090fc95 100644 --- a/source/text/shared/main0201.xhp +++ b/source/text/shared/main0201.xhp @@ -58,7 +58,7 @@ Spelling - + diff --git a/source/text/simpress/main_tools.xhp b/source/text/simpress/main_tools.xhp index da26e7d5d..2090fc4dd 100644 --- a/source/text/simpress/main_tools.xhp +++ b/source/text/simpress/main_tools.xhp @@ -34,7 +34,7 @@ Tools Contains spelling tools, a gallery of object art that you can add to your document, as well as tools for configuring menus, and setting program preferences. - + ImageMap diff --git a/source/text/swriter/main0106.xhp b/source/text/swriter/main0106.xhp index 3e4896a0e..5fec00285 100644 --- a/source/text/swriter/main0106.xhp +++ b/source/text/swriter/main0106.xhp @@ -34,7 +34,7 @@ Tools Contains spelling tools, a gallery of object art that you can add to your document, as well as tools for configuring menus, and setting program preferences. - + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/scalc/main0105.xhp |2 +- source/text/schart/00/0004.xhp |2 +- source/text/schart/01/0512.xhp |4 ++-- source/text/sdraw/main0210.xhp |4 ++-- source/text/shared/00/00040501.xhp |2 +- source/text/shared/01/0525.xhp |4 ++-- source/text/simpress/00/0004.xhp |2 +- source/text/simpress/01/0525.xhp |4 ++-- source/text/simpress/main0113.xhp|2 +- source/text/simpress/main0210.xhp|4 ++-- source/text/swriter/main0105.xhp |2 +- 11 files changed, 16 insertions(+), 16 deletions(-) New commits: commit 21d65441845c1265e3efb8fe9dade212fee70240 Author: Johnny_M AuthorDate: Sat Sep 26 11:24:10 2020 +0200 Commit: Olivier Hallot CommitDate: Sat Sep 26 14:28:31 2020 +0200 tdf#132643 Translate German section IDs Change-Id: Ic553ccd8293161d20554df24884ca164fd59b76d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103476 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/scalc/main0105.xhp b/source/text/scalc/main0105.xhp index eb6f4ec8a..f9f4bc35a 100644 --- a/source/text/scalc/main0105.xhp +++ b/source/text/scalc/main0105.xhp @@ -62,7 +62,7 @@ - + diff --git a/source/text/schart/00/0004.xhp b/source/text/schart/00/0004.xhp index 01d205577..8021f9edc 100644 --- a/source/text/schart/00/0004.xhp +++ b/source/text/schart/00/0004.xhp @@ -154,7 +154,7 @@ removed frtaft autoformat section Choose Format - 3D View (Charts) - + Choose Format - Arrangement (Charts) Open context menu - choose Arrangement (Charts) diff --git a/source/text/schart/01/0512.xhp b/source/text/schart/01/0512.xhp index cad327f24..cd8f277ec 100644 --- a/source/text/schart/01/0512.xhp +++ b/source/text/schart/01/0512.xhp @@ -30,13 +30,13 @@ - + Arrangement Allows you to modify the order of the data series already set in the chart. The position of the data in the data table remains unchanged. You can only choose the commands after inserting a chart in $[officename] Calc. - + This function is only available if you have data displayed in columns. It is not possible to switch to data display in rows. Bring Forward diff --git a/source/text/sdraw/main0210.xhp b/source/text/sdraw/main0210.xhp index 24fc6ceab..cd65a0bf2 100644 --- a/source/text/sdraw/main0210.xhp +++ b/source/text/sdraw/main0210.xhp @@ -68,8 +68,8 @@ - - + + From File diff --git a/source/text/shared/00/00040501.xhp b/source/text/shared/00/00040501.xhp index e578c4aa1..875296ff8 100644 --- a/source/text/shared/00/00040501.xhp +++ b/source/text/shared/00/00040501.xhp @@ -197,7 +197,7 @@ - + Choose Format - Arrange ($[officename] Writer, $[officename] Calc). Open context menu - choose Arrange ($[officename] Impress, $[officename] Draw). Choose Shape - Arrange ($[officename] Draw). diff --git a/source/text/shared/01/0525.xhp b/source/text/shared/01/0525.xhp index 0c7983b38..3cba601aa 100644 --- a/source/text/shared/01/0525.xhp +++ b/source/text/shared/01/0525.xhp @@ -27,7 +27,7 @@ - + objects; arranging within stacks arranging; objects borders; arranging @@ -47,7 +47,7 @@ Changes the stacking order of the selected object(s). - + Layer for text and graphics Each object that you place in your document is successively stacked on the preceding object. Use the arrange commands to change the stacking order of objects in your document. You cannot change the stacking order of text. diff --git a/source/text/simpress/00/0004.xhp b/source/text/simpress/00/0004.xhp index 0ede1f9f3..7dc70aa99 100644 --- a/source/text/simpress/00/0004.xhp +++ b/source/text/simpress/00/0004.xhp @@ -97,7 +97,7 @@ - + diff --git a/source/text/simpress/01/0525.xhp b/source/text/simpress/01/0525.xhp index dc3fac3cd..988aea717 100644 --- a/source/text/simpress/01/0525.xhp +++ b/source/text/simpress/01/0525.xhp @@ -29,11 +29,11 @@ -mw deleted one index entryArrange +mw deleted one index entryArrange Changes the stacking order of a selected object. - + diff --git a/source/text/simpress/main0113.xhp b/source/text/simpress/main0113.xhp index 965e514b5..0da9d61dc 100644 --- a/source/text/simpress/main0113.xhp +++ b/source/text/simpress/main0113.xhp @@ -37,7 +37,7 @@ Rotates the selected object(s). - + Distribution diff --git a/source/text/simpress/main0210.xhp b/source/text/simpress/main0210.xhp index 56626f488..f55166ccf 100644 --- a/source/text/simpress/main0210.xhp +++ b/source/text/simpress/main0210.xhp @@ -86,8 +86,8 @@ - - + + Extrusion On/Off Switches the 3D effects on and off for the selected objects. diff --git a/source/text/swriter/main0105.xhp b/source/text/swriter/main0105.xhp index ee517bb5a..64e34427d 100644 --- a/source/text/swriter/main0105.xhp +++ b/source/text/swr
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b02739cfd4eae4581c4104342baea3c0bb853cc0 Author: Johnny_M AuthorDate: Sat Sep 26 14:28:31 2020 +0200 Commit: Gerrit Code Review CommitDate: Sat Sep 26 14:28:31 2020 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 21d65441845c1265e3efb8fe9dade212fee70240 - tdf#132643 Translate German section IDs Change-Id: Ic553ccd8293161d20554df24884ca164fd59b76d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103476 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index ad7239eb6689..21d65441845c 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit ad7239eb6689164dace222b321bc12f97c0d60b5 +Subproject commit 21d65441845c1265e3efb8fe9dade212fee70240 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/viewfun2.cxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 5ff00ae591979db0653d9d0b5956f9a520ad24ff
Author: Andrea Gelmini
AuthorDate: Fri Sep 25 12:30:15 2020 +0200
Commit: Julien Nabet
CommitDate: Sat Sep 26 14:14:55 2020 +0200
Fix typo in code
It passed "make check" on Linux
Change-Id: I9906dc44e8398abfad83c947659d82a8fac66bd0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103457
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/sc/source/ui/view/viewfun2.cxx b/sc/source/ui/view/viewfun2.cxx
index 8260ef688030..f3dbeece26b7 100644
--- a/sc/source/ui/view/viewfun2.cxx
+++ b/sc/source/ui/view/viewfun2.cxx
@@ -1128,10 +1128,10 @@ bool ScViewFunc::TestMergeCells() // pre-test
(for menu)
if ( rMark.IsMarked() || rMark.IsMultiMarked() )
{
ScRange aRange;
-bool bMergable = ( GetViewData().GetSimpleArea( aRange ) ==
SC_MARK_SIMPLE );
-bMergable = bMergable && ( aRange.aStart.Col() != aRange.aEnd.Col() ||
+bool bMergeable = ( GetViewData().GetSimpleArea( aRange ) ==
SC_MARK_SIMPLE );
+bMergeable = bMergeable && ( aRange.aStart.Col() != aRange.aEnd.Col()
||
aRange.aStart.Row() != aRange.aEnd.Row() );
-return bMergable;
+return bMergeable;
}
else
return false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: bin/benchmark-document-loading
bin/benchmark-document-loading |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 4008401c9ba4e1df6a4a4f6dbb8ca134ed3f218a
Author: Andrea Gelmini
AuthorDate: Fri Sep 25 11:56:25 2020 +0200
Commit: Julien Nabet
CommitDate: Sat Sep 26 13:29:31 2020 +0200
Fix typo in code
It passed "make check" on Linux
Change-Id: I3fb2bb8cfe22fd905a3badd2a90a9aef497bfcf7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103448
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/bin/benchmark-document-loading b/bin/benchmark-document-loading
index 11611a2b29da..9ecf43baffb3 100644
--- a/bin/benchmark-document-loading
+++ b/bin/benchmark-document-loading
@@ -69,12 +69,12 @@ validCalcFileExtensions = [ ".xlsx", ".xls", ".ods",
".fods" ]
validWriterFileExtensions = [ ".docx" , ".rtf", ".odt", ".fodt", ".doc" ]
validImpressFileExtensions = [ ".ppt", ".pptx", ".odp", ".fodp" ]
validDrawFileExtensions = [ ".odg", ".fodg" ]
-validRevereseFileExtensions = [ ".vsd", ".vdx", ".cdr", ".pub", ".wpd" ]
+validReverseFileExtensions = [ ".vsd", ".vdx", ".cdr", ".pub", ".wpd" ]
validFileExtensions = {"calc": validCalcFileExtensions,
"writer": validWriterFileExtensions,
"impress": validImpressFileExtensions,
"draw": validDrawFileExtensions,
- "reverse": validRevereseFileExtensions}
+ "reverse": validReverseFileExtensions}
flatODFTypes = {"calc": (".fods", "OpenDocument Spreadsheet Flat XML"),
"writer": (".fodt", "OpenDocument Text Flat XML"),
"impress": (".fodp", "OpenDocument Presentation Flat XML"),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: canvas/source include/tools
canvas/source/vcl/canvashelper.cxx | 14 --
canvas/source/vcl/canvashelper_texturefill.cxx | 18 ++
canvas/source/vcl/impltools.cxx| 14 +++---
canvas/source/vcl/impltools.hxx|4 ++--
canvas/source/vcl/spritehelper.cxx |2 +-
include/tools/gen.hxx |9 +
6 files changed, 37 insertions(+), 24 deletions(-)
New commits:
commit 0cabffc05f3b40f5ee897df73475e09a3c05fc70
Author: Noel Grandin
AuthorDate: Fri Sep 25 20:26:52 2020 +0200
Commit: Noel Grandin
CommitDate: Sat Sep 26 13:00:23 2020 +0200
tools::PolyPolygon -> basegfx in canvas
Change-Id: I7b5ac7b434932515895bf60acfa0109e6a2ebd18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103417
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/canvas/source/vcl/canvashelper.cxx
b/canvas/source/vcl/canvashelper.cxx
index 5cc5f3c42b73..a62057ce4a30 100644
--- a/canvas/source/vcl/canvashelper.cxx
+++ b/canvas/source/vcl/canvashelper.cxx
@@ -266,7 +266,7 @@ namespace vclcanvas
const ::basegfx::B2DPolyPolygon& rPolyPoly(
::basegfx::unotools::b2DPolyPolygonFromXPolyPolygon2D(xPolyPolygon) );
-const ::tools::PolyPolygon aPolyPoly( tools::mapPolyPolygon(
rPolyPoly, viewState, renderState ) );
+const ::basegfx::B2DPolyPolygon aPolyPoly( tools::mapPolyPolygon(
rPolyPoly, viewState, renderState ) );
if( rPolyPoly.isClosed() )
{
@@ -284,9 +284,9 @@ namespace vclcanvas
// DrawPolygon(), and open ones via DrawPolyLine():
// closed polygons will simply already contain the
// closing segment.
-sal_uInt16 nSize( aPolyPoly.Count() );
+sal_uInt32 nSize( aPolyPoly.count() );
-for( sal_uInt16 i=0; igetOutDev().DrawPolyLine( aPolyPoly[i] );
@@ -476,7 +476,7 @@ namespace vclcanvas
::basegfx::B2DPolyPolygon aB2DPolyPoly(
::basegfx::unotools::b2DPolyPolygonFromXPolyPolygon2D(xPolyPolygon));
aB2DPolyPoly.setClosed(true); // ensure closed poly, otherwise VCL
does not fill
-const ::tools::PolyPolygon aPolyPoly( tools::mapPolyPolygon(
+const ::basegfx::B2DPolyPolygon aPolyPoly( tools::mapPolyPolygon(
aB2DPolyPoly,
viewState, renderState ) );
const bool bSourceAlpha( renderState.CompositeOperation ==
rendering::CompositeOperation::SOURCE );
@@ -486,8 +486,10 @@ namespace vclcanvas
}
else
{
-const int nTransPercent( (nTransparency * 100 + 128) / 255 );
// normal rounding, no truncation here
-mpOutDevProvider->getOutDev().DrawTransparent( aPolyPoly,
static_cast(nTransPercent) );
+const double dTransparency( (nTransparency + 128) / 255.0 );
+basegfx::B2DHomMatrix aIdentityMatrix;
+aIdentityMatrix.identity();
+mpOutDevProvider->getOutDev().DrawTransparent(
aIdentityMatrix, aPolyPoly, dTransparency );
}
if( mp2ndOutDevProvider )
diff --git a/canvas/source/vcl/canvashelper_texturefill.cxx
b/canvas/source/vcl/canvashelper_texturefill.cxx
index 9cb8dd8abd99..b0b0ef3770d5 100644
--- a/canvas/source/vcl/canvashelper_texturefill.cxx
+++ b/canvas/source/vcl/canvashelper_texturefill.cxx
@@ -437,7 +437,7 @@ namespace vclcanvas
OutputDevice*
p2ndOutDev,
const ::canvas::ParametricPolyPolygon::Values&
rValues,
const std::vector< ::Color >&
rColors,
- const ::tools::PolyPolygon&
rPoly,
+ const ::basegfx::B2DPolyPolygon&
rPoly,
const rendering::ViewState&
viewState,
const rendering::RenderState&
renderState,
const rendering::Texture&
texture,
@@ -466,8 +466,8 @@ namespace vclcanvas
// determine maximal bound rect of texture-filled
// polygon
-const ::tools::Rectangle aPolygonDeviceRectOrig(
-rPoly.GetBoundRect() );
+const ::basegfx::B2DRectangle aPolygonDeviceRectOrig(
+rPoly.getB2DRange() );
if( tools::isRectangle( rPoly ) )
{
@@ -482,7 +482,7 @@ namespace vclcanvas
// twice for XOR
rOutDev.Push( PushFlags::CLIPREGION );
-rOutDev.IntersectClipRegion( aPolygonDeviceRectOrig );
+rOutDev.IntersectClipRegion(
::tools::Rectangle(aPolygonDeviceRectOrig) );
[Libreoffice-commits] core.git: qadevOOo/tests
qadevOOo/tests/java/mod/_dbaccess/OQueryDesign.java |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit e8059e707012c8352f7349c4ebf46b56e01c4b4f
Author: Andrea Gelmini
AuthorDate: Fri Sep 25 13:21:31 2020 +0200
Commit: Julien Nabet
CommitDate: Sat Sep 26 12:50:19 2020 +0200
Fix typo in code
It passed "make check" on Linux
Change-Id: I8945fc73085afb6e4cdfe5083f3732191341a1d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103459
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/qadevOOo/tests/java/mod/_dbaccess/OQueryDesign.java
b/qadevOOo/tests/java/mod/_dbaccess/OQueryDesign.java
index 4ca3a43aa8dd..1124d12f96d7 100644
--- a/qadevOOo/tests/java/mod/_dbaccess/OQueryDesign.java
+++ b/qadevOOo/tests/java/mod/_dbaccess/OQueryDesign.java
@@ -161,7 +161,7 @@ public class OQueryDesign extends TestCase {
tEnv.addObjRelation("Frame", xFrame);
-tEnv.addObjRelation("XInitialization.xIni",
getUnititializedObj(Param));
+tEnv.addObjRelation("XInitialization.xIni",
getUninitializedObj(Param));
log.println("ImplementationName: "+util.utils.getImplName(oObj));
@@ -169,7 +169,7 @@ public class OQueryDesign extends TestCase {
} // finish method getTestEnvironment
-private XInitialization getUnititializedObj(TestParameters Param) throws
Exception {
+private XInitialization getUninitializedObj(TestParameters Param) throws
Exception {
// creating an object which ist not initialized
// get a model of a DataSource
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/control/field2.cxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 25e7a5923edc507a2511dc17e3c238cd0f37e642
Author: Andrea Gelmini
AuthorDate: Fri Sep 25 12:28:04 2020 +0200
Commit: Julien Nabet
CommitDate: Sat Sep 26 12:50:49 2020 +0200
Fix typo in code
It passed "make check" on Linux
Change-Id: I5bc56a0dea4a157b276a59bd1050b08120b948ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103455
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/vcl/source/control/field2.cxx b/vcl/source/control/field2.cxx
index fc81066ef0f6..8df442fff60b 100644
--- a/vcl/source/control/field2.cxx
+++ b/vcl/source/control/field2.cxx
@@ -2796,8 +2796,8 @@ tools::Time TimeFormatter::GetTime() const
if ( GetField() )
{
-bool bAllowMailformed = ImplAllowMalformedInput();
-if ( TextToTime( GetField()->GetText(), aTime, GetFormat(),
IsDuration(), ImplGetLocaleDataWrapper(), !bAllowMailformed ) )
+bool bAllowMalformed = ImplAllowMalformedInput();
+if ( TextToTime( GetField()->GetText(), aTime, GetFormat(),
IsDuration(), ImplGetLocaleDataWrapper(), !bAllowMalformed ) )
{
if ( aTime > GetMax() )
aTime = GetMax();
@@ -2806,7 +2806,7 @@ tools::Time TimeFormatter::GetTime() const
}
else
{
-if ( bAllowMailformed )
+if ( bAllowMalformed )
aTime = tools::Time( 99, 99, 99 ); // set invalid time
else
aTime = maLastTime;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: forms/source
forms/source/component/Button.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 9da6180d4d593b16838fe035261d6c1e568b24c0 Author: Andrea Gelmini AuthorDate: Fri Sep 25 13:26:04 2020 +0200 Commit: Julien Nabet CommitDate: Sat Sep 26 12:49:42 2020 +0200 Fix typo in code It passed "make check" on Linux Change-Id: I823a0ae998addb620b490b649e1369106f8f4e8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103462 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/forms/source/component/Button.cxx b/forms/source/component/Button.cxx index 0044068c13b3..70f80a6c8c38 100644 --- a/forms/source/component/Button.cxx +++ b/forms/source/component/Button.cxx @@ -200,9 +200,9 @@ void OButtonModel::read(const Reference& _rxInStream) readHelpTextCompatibly(_rxInStream); // DispatchInternal -bool bDispath; -_rxInStream >> bDispath; -setDispatchUrlInternal(bDispath); +bool bDispatch; +_rxInStream >> bDispatch; +setDispatchUrlInternal(bDispatch); } break; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: offapi/com
offapi/com/sun/star/embed/XEmbeddedObject.idl |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 5f2403148e9159e49e6fea9ad348cbfb5b24ba2a Author: Andrea Gelmini AuthorDate: Fri Sep 25 12:31:37 2020 +0200 Commit: Stephan Bergmann CommitDate: Sat Sep 26 12:44:13 2020 +0200 Fix typo Change-Id: I2c5ea93645161eb4acb7bbfba21fdf30462c2635 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103465 Reviewed-by: Julien Nabet Reviewed-by: Stephan Bergmann Tested-by: Jenkins diff --git a/offapi/com/sun/star/embed/XEmbeddedObject.idl b/offapi/com/sun/star/embed/XEmbeddedObject.idl index 9e9de8b6486d..7c9f3c220033 100644 --- a/offapi/com/sun/star/embed/XEmbeddedObject.idl +++ b/offapi/com/sun/star/embed/XEmbeddedObject.idl @@ -94,7 +94,7 @@ published interface XEmbeddedObject @returns the sequence of states the object can be set to -@throws com::sun::star::embed::NeedsRunnignStateException +@throws com::sun::star::embed::NeedsRunningStateException means that the object is in loaded state now and can be switched to running state, other possible states can be detected only when the object is not in loaded state any more @@ -146,7 +146,7 @@ published interface XEmbeddedObject @returns the sequence of verbs the object supports -@throws com::sun::star::embed::NeedsRunnignStateException +@throws com::sun::star::embed::NeedsRunningStateException means that the object is in loaded state now and can be switched to running state, acceptable verbs can be detected only when the object is not in loaded state any more ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: package/qa
package/qa/ofopxmlstorages/TestHelper.java |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 1558b9ee696b021fd2d6431179413dc9ef58fe69
Author: Andrea Gelmini
AuthorDate: Fri Sep 25 12:39:59 2020 +0200
Commit: Julien Nabet
CommitDate: Sat Sep 26 11:36:05 2020 +0200
Fix typo in code
It passed "make check" on Linux
Change-Id: Ib1b92b38f3eeb37d659b79572cafc1e3b79fcf29
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103458
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/package/qa/ofopxmlstorages/TestHelper.java
b/package/qa/ofopxmlstorages/TestHelper.java
index abc92885de6e..b7f42ea7fd3f 100644
--- a/package/qa/ofopxmlstorages/TestHelper.java
+++ b/package/qa/ofopxmlstorages/TestHelper.java
@@ -897,7 +897,7 @@ public class TestHelper {
try
{
Object oDummyStream = xStorage.openStreamElement( sName, nMode );
-Error( "The trying to open substoream '" + sName + "' must fail!"
);
+Error( "The trying to open substream '" + sName + "' must fail!" );
}
catch( Exception e )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/quartz
vcl/quartz/salgdi.cxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 7ed86a2d4244e7417b8a3c944bad32865aaa3a25
Author: Andrea Gelmini
AuthorDate: Fri Sep 25 12:28:52 2020 +0200
Commit: Julien Nabet
CommitDate: Sat Sep 26 11:35:34 2020 +0200
Fix typo in code
It passed "make check" on Linux
Change-Id: I5e2b4f37296b521b5e942a8e9f9caf2137e39172
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103456
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/vcl/quartz/salgdi.cxx b/vcl/quartz/salgdi.cxx
index 1501043924b6..a0bb509dc2b6 100644
--- a/vcl/quartz/salgdi.cxx
+++ b/vcl/quartz/salgdi.cxx
@@ -272,9 +272,9 @@ void AquaSalGraphics::GetFontMetric(ImplFontMetricDataRef&
rxFontMetric, int nFa
static bool AddTempDevFont(const OUString& rFontFileURL)
{
-OUString aUSytemPath;
-OSL_VERIFY( !osl::FileBase::getSystemPathFromFileURL( rFontFileURL,
aUSytemPath ) );
-OString aCFileName = OUStringToOString( aUSytemPath, RTL_TEXTENCODING_UTF8
);
+OUString aUSystemPath;
+OSL_VERIFY( !osl::FileBase::getSystemPathFromFileURL( rFontFileURL,
aUSystemPath ) );
+OString aCFileName = OUStringToOString( aUSystemPath,
RTL_TEXTENCODING_UTF8 );
CFStringRef rFontPath = CFStringCreateWithCString(nullptr,
aCFileName.getStr(), kCFStringEncodingUTF8);
CFURLRef rFontURL = CFURLCreateWithFileSystemPath(nullptr, rFontPath,
kCFURLPOSIXPathStyle, true);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/validat.hxx | 10
sc/source/core/data/validat.cxx | 81 ++--
2 files changed, 64 insertions(+), 27 deletions(-)
New commits:
commit ebe4bbb25a9bcb4263b079a50d932384c7c7fb3e
Author: Eike Rathke
AuthorDate: Fri Sep 25 23:26:19 2020 +0200
Commit: Eike Rathke
CommitDate: Sat Sep 26 11:30:21 2020 +0200
Consolidate, factor out common duplicated code, tdf#128797 follow-up
Change-Id: I939c9f88a6cf09e1caa87131562ad67e389c2710
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103470
Reviewed-by: Eike Rathke
Tested-by: Jenkins
diff --git a/sc/inc/validat.hxx b/sc/inc/validat.hxx
index 19f88ddce34a..7ab014f0f92f 100644
--- a/sc/inc/validat.hxx
+++ b/sc/inc/validat.hxx
@@ -34,6 +34,7 @@ struct RefUpdateContext;
class ScPatternAttr;
class ScTokenArray;
class ScTypedStrData;
+struct ScValidationDataIsNumeric;
enum ScValidationMode
{
@@ -183,6 +184,15 @@ private:
/** Tests, if contents of pCell occur in cell range referenced by own
formula, or in a string list. */
bool IsListValid( ScRefCellValue& rCell, const ScAddress& rPos ) const;
+
+/** Tests, if string or numeric data has valid text length.
+@param pDataNumeric
+nullptr if string data to be tested, else for numeric data a
+properly initialized ScValidationDataIsNumeric struct, see
+implementation.
+ */
+bool IsDataValidTextLen( const OUString& rTest, const ScAddress& rPos,
+ScValidationDataIsNumeric* pDataNumeric ) const;
};
// list of conditions:
diff --git a/sc/source/core/data/validat.cxx b/sc/source/core/data/validat.cxx
index 2cb6a6aad909..7ed29dd577bc 100644
--- a/sc/source/core/data/validat.cxx
+++ b/sc/source/core/data/validat.cxx
@@ -476,6 +476,53 @@ bool ScValidationData::IsDataValidCustom(
return bRet;
}
+/** To test numeric data text length in IsDataValidTextLen().
+
+If mpFormatter is not set, it is obtained from the document and the format
+key is determined from the cell position's attribute pattern.
+ */
+struct ScValidationDataIsNumeric
+{
+SvNumberFormatter* mpFormatter;
+double mfVal;
+sal_uInt32 mnFormat;
+
+ScValidationDataIsNumeric( double fVal, SvNumberFormatter* pFormatter =
nullptr, sal_uInt32 nFormat = 0 )
+: mpFormatter(pFormatter), mfVal(fVal), mnFormat(nFormat)
+{
+}
+
+void init( const ScDocument& rDoc, const ScAddress& rPos )
+{
+const ScPatternAttr* pPattern = rDoc.GetPattern( rPos.Col(),
rPos.Row(), rPos.Tab());
+mpFormatter = rDoc.GetFormatTable();
+mnFormat = pPattern->GetNumberFormat( mpFormatter);
+}
+};
+
+bool ScValidationData::IsDataValidTextLen( const OUString& rTest, const
ScAddress& rPos,
+ScValidationDataIsNumeric* pDataNumeric ) const
+{
+sal_Int32 nLen;
+if (!pDataNumeric)
+nLen = rTest.getLength();
+else
+{
+if (!pDataNumeric->mpFormatter)
+pDataNumeric->init( *GetDocument(), rPos);
+
+// For numeric values use the resulting input line string to
+// determine length, otherwise an once accepted value maybe could
+// not be edited again, for example abbreviated dates or leading
+// zeros or trailing zeros after decimal separator change length.
+OUString aStr;
+pDataNumeric->mpFormatter->GetInputLineString( pDataNumeric->mfVal,
pDataNumeric->mnFormat, aStr);
+nLen = aStr.getLength();
+}
+ScRefCellValue aTmpCell( static_cast(nLen));
+return IsCellValid( aTmpCell, rPos);
+}
+
bool ScValidationData::IsDataValid(
const OUString& rTest, const ScPatternAttr& rPattern, const ScAddress&
rPos ) const
{
@@ -498,21 +545,13 @@ bool ScValidationData::IsDataValid(
bool bRet;
if (SC_VALID_TEXTLEN == eDataMode)
{
-double nLenVal;
if (!bIsVal)
-nLenVal = static_cast(rTest.getLength());
+bRet = IsDataValidTextLen( rTest, rPos, nullptr);
else
{
-// For numeric values use the resulting input line string to
-// determine length, otherwise an once accepted value maybe could
-// not be edited again, for example abbreviated dates or leading
-// zeros or trailing zeros after decimal separator change length.
-OUString aStr;
-pFormatter->GetInputLineString( nVal, nFormat, aStr);
-nLenVal = static_cast( aStr.getLength() );
+ScValidationDataIsNumeric aDataNumeric( nVal, pFormatter, nFormat);
+bRet = IsDataValidTextLen( rTest, rPos, &aDataNumeric);
}
-ScRefCellValue aTmpCell(nLenVal);
-bRet = IsCellValid(aTmpCell, rPos);
}
else
{
@@ -589,25 +628,13 @@ bool ScValidationData::IsDataValid( ScRefCellValue&
rCell, const ScAddress& rPos
break;
case SC_VALID_TEXTLEN:
-
[Libreoffice-commits] core.git: sw/source
sw/source/core/layout/flowfrm.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit f898dcebaa8076b4cb46f0b08f551c30e1130f17
Author: Andrea Gelmini
AuthorDate: Fri Sep 25 11:17:43 2020 +0200
Commit: Julien Nabet
CommitDate: Sat Sep 26 10:44:31 2020 +0200
Fix typo in code
It passed "make check" on Linux
Change-Id: I6a2f61934673756d45a83f49f0e7d9391995cda5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103422
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/sw/source/core/layout/flowfrm.cxx
b/sw/source/core/layout/flowfrm.cxx
index 58f0eff76928..225a88847a8d 100644
--- a/sw/source/core/layout/flowfrm.cxx
+++ b/sw/source/core/layout/flowfrm.cxx
@@ -1448,10 +1448,10 @@ SwTwips SwFlowFrame::CalcUpperSpace( const
SwBorderAttrs *pAttrs,
SwTwips nPrevLowerSpace = 0;
SwTwips nPrevLineSpacing = 0;
// i#102458
-bool bPrevLineSpacingPorportional = false;
+bool bPrevLineSpacingProportional = false;
GetSpacingValuesOfFrame( (*pPrevFrame),
nPrevLowerSpace, nPrevLineSpacing,
- bPrevLineSpacingPorportional,
+ bPrevLineSpacingProportional,
bIdenticalStyles);
if( rIDSA.get(DocumentSettingId::PARA_SPACE_MAX) )
{
@@ -1485,7 +1485,7 @@ SwTwips SwFlowFrame::CalcUpperSpace( const SwBorderAttrs
*pAttrs,
// Otherwise, the maximum of the leading line spacing
// of the previous text frame and the own leading line
// spacing is built.
-if ( bPrevLineSpacingPorportional )
+if ( bPrevLineSpacingProportional )
{
nAdd +=
static_cast(pOwn)->GetLineSpace( true );
}
@@ -1533,7 +1533,7 @@ SwTwips SwFlowFrame::CalcUpperSpace( const SwBorderAttrs
*pAttrs,
// Otherwise, the maximum of the leading line spacing
// of the previous text frame and the own leading line
// spacing is built.
-if ( bPrevLineSpacingPorportional )
+if ( bPrevLineSpacingProportional )
{
nAdd +=
static_cast(pOwn)->GetLineSpace( true );
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/treelist/transfer2.cxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 4f963b6502674b73ecbc0ced201d15456724e977
Author: Andrea Gelmini
AuthorDate: Fri Sep 25 11:57:50 2020 +0200
Commit: Julien Nabet
CommitDate: Sat Sep 26 10:44:57 2020 +0200
Fix typo in code
It passed "make check" on Linux
Change-Id: I183c7fb15b37cfe6f691c6c75196958e6148ffac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103450
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/vcl/source/treelist/transfer2.cxx
b/vcl/source/treelist/transfer2.cxx
index cb1cd18cd114..73d9b30624e7 100644
--- a/vcl/source/treelist/transfer2.cxx
+++ b/vcl/source/treelist/transfer2.cxx
@@ -317,7 +317,7 @@ struct TDataCntnrEntry_Impl
struct TransferDataContainer_Impl
{
std::vector< TDataCntnrEntry_Impl > aFmtList;
-Link aFinshedLnk;
+Link aFinishedLnk;
std::unique_ptr pBookmk;
TransferDataContainer_Impl()
@@ -449,14 +449,14 @@ void TransferDataContainer::StartDrag(
vcl::Window* pWindow, sal_Int8 nDragSourceActions,
const Link& rLnk )
{
-pImpl->aFinshedLnk = rLnk;
+pImpl->aFinishedLnk = rLnk;
TransferableHelper::StartDrag( pWindow, nDragSourceActions );
}
void TransferDataContainer::DragFinished( sal_Int8 nDropAction )
{
-pImpl->aFinshedLnk.Call( nDropAction );
+pImpl->aFinishedLnk.Call( nDropAction );
}
Reference GetSystemClipboard()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx | 12 ++--
sc/source/ui/app/drwtrans.cxx |2
sc/source/ui/app/transobj.cxx |2
sc/source/ui/docshell/docsh6.cxx | 10 +--
sc/source/ui/inc/RandomNumberGeneratorDialog.hxx |4 -
sc/source/ui/inc/docsh.hxx |2
sc/source/ui/view/gridwin.cxx | 10 +--
sc/source/ui/view/tabview4.cxx |2
sc/source/ui/view/tabvwsh4.cxx |2
sc/source/ui/view/tabvwsh8.cxx | 10 +--
sc/source/ui/view/tabvwshc.cxx |2
sc/source/ui/view/viewfun2.cxx | 16 +++---
sc/source/ui/view/viewfun3.cxx |8 +--
sc/source/ui/view/viewfun4.cxx |4 -
sc/source/ui/view/viewfun7.cxx |6 +-
sc/source/ui/view/viewfunc.cxx | 26
+-
16 files changed, 58 insertions(+), 60 deletions(-)
New commits:
commit 67ba951aa53190feabcea8c6cd9fdcb1e48931b2
Author: Caolán McNamara
AuthorDate: Fri Sep 25 21:12:00 2020 +0100
Commit: Caolán McNamara
CommitDate: Sat Sep 26 10:25:54 2020 +0200
UpdateOle never called with a null ScViewData*
Change-Id: I5b2bdc633207ae0686e3bf30794b141c474f3f19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103420
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx
b/sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx
index ebb1d8b06390..68f04630de29 100644
--- a/sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx
@@ -44,12 +44,12 @@ const sal_Int64 DIGITS = 4;
ScRandomNumberGeneratorDialog::ScRandomNumberGeneratorDialog(
SfxBindings* pSfxBindings, SfxChildWindow* pChildWindow,
-weld::Window* pParent, ScViewData* pViewData)
+weld::Window* pParent, ScViewData& rViewData)
: ScAnyRefDlgController(pSfxBindings, pChildWindow, pParent,
"modules/scalc/ui/randomnumbergenerator.ui",
"RandomNumberGeneratorDialog")
-, mpViewData(pViewData)
-, mrDoc(pViewData->GetDocument())
+, mrViewData(rViewData)
+, mrDoc(rViewData.GetDocument())
, mbDialogLostFocus(false)
, mxInputRangeText(m_xBuilder->weld_label("cell-range-label"))
, mxInputRangeEdit(new
formula::RefEdit(m_xBuilder->weld_entry("cell-range-edit")))
@@ -105,7 +105,7 @@ void ScRandomNumberGeneratorDialog::Init()
void ScRandomNumberGeneratorDialog::GetRangeFromSelection()
{
-mpViewData->GetSimpleArea(maInputRange);
+mrViewData.GetSimpleArea(maInputRange);
OUString aCurrentString(maInputRange.Format(mrDoc,
ScRefFlags::RANGE_ABS_3D, mrDoc.GetAddressConvention()));
mxInputRangeEdit->SetText( aCurrentString );
}
@@ -256,9 +256,9 @@ void ScRandomNumberGeneratorDialog::GenerateNumbers(RNG&
randomGenerator, const
OUString aDistributionName = ScResId(pDistributionStringId);
aUndo = aUndo.replaceAll("$(DISTRIBUTION)", aDistributionName);
-ScDocShell* pDocShell = mpViewData->GetDocShell();
+ScDocShell* pDocShell = mrViewData.GetDocShell();
SfxUndoManager* pUndoManager = pDocShell->GetUndoManager();
-pUndoManager->EnterListAction( aUndo, aUndo, 0,
mpViewData->GetViewShell()->GetViewShellId() );
+pUndoManager->EnterListAction( aUndo, aUndo, 0,
mrViewData.GetViewShell()->GetViewShellId() );
SCROW nRowStart = maInputRange.aStart.Row();
SCROW nRowEnd = maInputRange.aEnd.Row();
diff --git a/sc/source/ui/app/drwtrans.cxx b/sc/source/ui/app/drwtrans.cxx
index 246c549c6105..3149fd1251cc 100644
--- a/sc/source/ui/app/drwtrans.cxx
+++ b/sc/source/ui/app/drwtrans.cxx
@@ -735,7 +735,7 @@ void ScDrawTransferObj::InitDocShell()
aViewData.SetScreen( aDestArea );
aViewData.SetCurX( 0 );
aViewData.SetCurY( 0 );
-pDocSh->UpdateOle(&aViewData, true);
+pDocSh->UpdateOle(aViewData, true);
}
namespace
diff --git a/sc/source/ui/app/transobj.cxx b/sc/source/ui/app/transobj.cxx
index f478c23448f7..ff50f6fc4247 100644
--- a/sc/source/ui/app/transobj.cxx
+++ b/sc/source/ui/app/transobj.cxx
@@ -801,7 +801,7 @@ void ScTransferObj::InitDocShell(bool bLimitToPageSize)
//pDocSh->SvInPlaceObject::SetVisArea( aNewArea );
pDocSh->SetVisArea( aNewArea );
-pDocSh->UpdateOle(&aViewData, true);
+pDocSh->UpdateOle(aViewData, true);
//! SetDocumentModified?
if ( rDestDoc.IsChartListenerCollectionNeedsUpdate() )
diff --git a/sc/source/ui/docshell/docsh6.cxx b/sc/source/ui/do
[Libreoffice-commits] core.git: sd/source sw/qa sw/source
sd/source/ui/inc/slideshow.hxx|2 +-
sw/qa/extras/ooxmlexport/ooxmlexport3.cxx |2 +-
sw/source/filter/xml/xmlimpit.cxx |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 200a46c0a30c0ff6b1e9df1dc4bd086dbff75c8b
Author: Andrea Gelmini
AuthorDate: Fri Sep 25 12:24:00 2020 +0200
Commit: Julien Nabet
CommitDate: Sat Sep 26 10:02:28 2020 +0200
Fix typo
Change-Id: I508a3ce14e8f02bd51055cc22ff29f44c522b7ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103467
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/sd/source/ui/inc/slideshow.hxx b/sd/source/ui/inc/slideshow.hxx
index 9b6087a5d311..15af88f8d10b 100644
--- a/sd/source/ui/inc/slideshow.hxx
+++ b/sd/source/ui/inc/slideshow.hxx
@@ -157,7 +157,7 @@ public:
// events
void resize( const Size &rSize );
-// return false if the activate failed. callers should call end in
response to failre
+// return false if the activate failed. callers should call end in
response to failure
bool activate(ViewShellBase& rBase);
void deactivate();
void paint();
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
index 0085734450c0..200d34033ede 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
@@ -324,7 +324,7 @@ DECLARE_OOXMLEXPORT_TEST(testCalendar3, "calendar3.docx")
CPPUNIT_ASSERT_EQUAL(20.f, getProperty(getRun(getParagraphOfText(1,
xCell2->getText()),1), "CharHeight"));
// tdf#132149 Despite specifying portrait, the page size's specified width
is greater than its height.
-// Both Word and LO display it as landscape, so ensure that it round-trips
with landscape dimentions.
+// Both Word and LO display it as landscape, so ensure that it round-trips
with landscape dimensions.
uno::Reference
xPageStyle(getStyles("PageStyles")->getByName("Standard"), uno::UNO_QUERY);
CPPUNIT_ASSERT_EQUAL_MESSAGE("Page Width (mm) ", sal_Int32(148),
getProperty(xPageStyle, "Width") / 100);
CPPUNIT_ASSERT_EQUAL_MESSAGE("Page Height (mm)", sal_Int32(105),
getProperty(xPageStyle, "Height") / 100);
diff --git a/sw/source/filter/xml/xmlimpit.cxx
b/sw/source/filter/xml/xmlimpit.cxx
index 2d70ac8013fb..aab0a0069273 100644
--- a/sw/source/filter/xml/xmlimpit.cxx
+++ b/sw/source/filter/xml/xmlimpit.cxx
@@ -94,7 +94,7 @@ void SvXMLImportItemMapper::importXML( SfxItemSet& rSet,
// find a map entry for this attribute
sal_Int32 nLookupToken = nToken;
-// compatiblity namespaces need to be tranformed into current
namespace before looking up
+// compatibility namespaces need to be transformed into current
namespace before looking up
if (IsTokenInNamespace(nLookupToken, XML_NAMESPACE_FO_COMPAT))
nLookupToken = XML_ELEMENT(FO, (nLookupToken & TOKEN_MASK));
SvXMLItemMapEntry const * pEntry = mrMapEntries->getByName(
nLookupToken );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: qadevOOo/tests
qadevOOo/tests/java/ifc/awt/tree/_XTreeNode.java |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit e913cbadb291c25a0199ad8db3f529309e41f5d6
Author: Andrea Gelmini
AuthorDate: Fri Sep 25 13:22:12 2020 +0200
Commit: Julien Nabet
CommitDate: Sat Sep 26 09:58:16 2020 +0200
Fix typo
It passed "make check"
Change-Id: Ifdea79506b69c316869fff4b78e496a090f77c5d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103466
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/qadevOOo/tests/java/ifc/awt/tree/_XTreeNode.java
b/qadevOOo/tests/java/ifc/awt/tree/_XTreeNode.java
index 53f8f8c03038..f0ca8ae9f654 100644
--- a/qadevOOo/tests/java/ifc/awt/tree/_XTreeNode.java
+++ b/qadevOOo/tests/java/ifc/awt/tree/_XTreeNode.java
@@ -194,7 +194,7 @@ public class _XTreeNode extends MultiMethodTest {
try {
DisplayValue = AnyConverter.toString(dispVal);
} catch (com.sun.star.lang.IllegalArgumentException ex) {
-log.println("ERROR: could not convert the returned object of
'getDisplyValue()' " +
+log.println("ERROR: could not convert the returned object of
'getDisplayValue()' " +
"to String with AnyConverter: " + ex.toString());
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/qa
chart2/qa/extras/chart2export.cxx | 16
1 file changed, 8 insertions(+), 8 deletions(-)
New commits:
commit 8630468b07942cb6ee9bb234a5f8c5d955480422
Author: Andrea Gelmini
AuthorDate: Fri Sep 25 17:30:47 2020 +0200
Commit: Julien Nabet
CommitDate: Sat Sep 26 09:56:32 2020 +0200
Fix typo in code
It passed "make check" on Linux
Change-Id: I76287ff3309c78283947886882456a01cdc01725
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103463
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/chart2/qa/extras/chart2export.cxx
b/chart2/qa/extras/chart2export.cxx
index 49edb53991fe..e9d154d4ade1 100644
--- a/chart2/qa/extras/chart2export.cxx
+++ b/chart2/qa/extras/chart2export.cxx
@@ -94,8 +94,8 @@ public:
void testChartTitlePropertiesColorFillDOCX();
void testChartTitlePropertiesGradientFillDOCX();
void testChartTitlePropertiesBitmapFillDOCX();
-void testColorGradientWithTransparancyDOCX();
-void testColorGradientWithTransparancyODS();
+void testColorGradientWithTransparencyDOCX();
+void testColorGradientWithTransparencyODS();
void testColorGradientStopXLSX();
void testRadialColorGradientDOCX();
void testBarChartDataPointPropDOCX();
@@ -236,8 +236,8 @@ public:
CPPUNIT_TEST(testChartTitlePropertiesColorFillDOCX);
CPPUNIT_TEST(testChartTitlePropertiesGradientFillDOCX);
CPPUNIT_TEST(testChartTitlePropertiesBitmapFillDOCX);
-CPPUNIT_TEST(testColorGradientWithTransparancyDOCX);
-CPPUNIT_TEST(testColorGradientWithTransparancyODS);
+CPPUNIT_TEST(testColorGradientWithTransparencyDOCX);
+CPPUNIT_TEST(testColorGradientWithTransparencyODS);
CPPUNIT_TEST(testColorGradientStopXLSX);
CPPUNIT_TEST(testRadialColorGradientDOCX);
CPPUNIT_TEST(testBarChartDataPointPropDOCX);
@@ -1335,10 +1335,10 @@ void
Chart2ExportTest::testChartTitlePropertiesBitmapFillDOCX()
assertXPath(pXmlDoc, "/c:chartSpace/c:chart/c:title/c:spPr/a:ln/a:noFill",
1);
}
-void Chart2ExportTest::testColorGradientWithTransparancyDOCX()
+void Chart2ExportTest::testColorGradientWithTransparencyDOCX()
{
// Test color gradient (two color) with gradient transparency
-load("/chart2/qa/extras/data/docx/",
"testColorGradientWithTransparancy.docx");
+load("/chart2/qa/extras/data/docx/",
"testColorGradientWithTransparency.docx");
xmlDocUniquePtr pXmlDoc = parseExport("word/charts/chart", "Office Open
XML Text");
CPPUNIT_ASSERT(pXmlDoc);
// Test the transparency of the first color
@@ -1347,10 +1347,10 @@ void
Chart2ExportTest::testColorGradientWithTransparancyDOCX()
assertXPath(pXmlDoc,
"/c:chartSpace/c:chart/c:plotArea/c:barChart/c:ser/c:spPr/a:gradFill/a:gsLst/a:gs[2]/a:srgbClr/a:alpha",
"val", "90196");
}
-void Chart2ExportTest::testColorGradientWithTransparancyODS()
+void Chart2ExportTest::testColorGradientWithTransparencyODS()
{
// Test color gradient (two color) with simple transparency
-load("/chart2/qa/extras/data/ods/",
"testColorGradientWithTransparancy.ods");
+load("/chart2/qa/extras/data/ods/",
"testColorGradientWithTransparency.ods");
xmlDocUniquePtr pXmlDoc = parseExport("xl/charts/chart", "Calc Office Open
XML");
CPPUNIT_ASSERT(pXmlDoc);
// Test the transparency of the first color
diff --git a/chart2/qa/extras/data/docx/testColorGradientWithTransparancy.docx
b/chart2/qa/extras/data/docx/testColorGradientWithTransparency.docx
similarity index 100%
rename from chart2/qa/extras/data/docx/testColorGradientWithTransparancy.docx
rename to chart2/qa/extras/data/docx/testColorGradientWithTransparency.docx
diff --git a/chart2/qa/extras/data/ods/testColorGradientWithTransparancy.ods
b/chart2/qa/extras/data/ods/testColorGradientWithTransparency.ods
similarity index 100%
rename from chart2/qa/extras/data/ods/testColorGradientWithTransparancy.ods
rename to chart2/qa/extras/data/ods/testColorGradientWithTransparency.ods
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: reportdesign/source
reportdesign/source/ui/inc/dlgedfunc.hxx|2 +-
reportdesign/source/ui/report/dlgedfunc.cxx |6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
New commits:
commit dd4863e82b63aa43b607edd5918737718c4c6d5a
Author: Andrea Gelmini
AuthorDate: Fri Sep 25 11:25:47 2020 +0200
Commit: Julien Nabet
CommitDate: Sat Sep 26 09:54:20 2020 +0200
Fix typo in code
It passed "make check" on Linux
Change-Id: If5061bcbbeeed134fae784187598ce7ea04280c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103445
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/reportdesign/source/ui/inc/dlgedfunc.hxx
b/reportdesign/source/ui/inc/dlgedfunc.hxx
index 804b814ee6dc..403f548e0080 100644
--- a/reportdesign/source/ui/inc/dlgedfunc.hxx
+++ b/reportdesign/source/ui/inc/dlgedfunc.hxx
@@ -82,7 +82,7 @@ protected:
*/
voidactivateOle(SdrObject* _pObj);
-void checkTwoCklicks(const MouseEvent& rMEvt);
+void checkTwoClicks(const MouseEvent& rMEvt);
public:
DlgEdFunc( OReportSection* pParent );
diff --git a/reportdesign/source/ui/report/dlgedfunc.cxx
b/reportdesign/source/ui/report/dlgedfunc.cxx
index 1753205cdb29..799d9e611155 100644
--- a/reportdesign/source/ui/report/dlgedfunc.cxx
+++ b/reportdesign/source/ui/report/dlgedfunc.cxx
@@ -217,7 +217,7 @@ bool DlgEdFunc::MouseButtonUp( const MouseEvent& /*rMEvt*/ )
return false;
}
-void DlgEdFunc::checkTwoCklicks(const MouseEvent& rMEvt)
+void DlgEdFunc::checkTwoClicks(const MouseEvent& rMEvt)
{
deactivateOle();
@@ -723,7 +723,7 @@ bool DlgEdFuncInsert::MouseButtonUp( const MouseEvent&
rMEvt )
m_rView.PickAnything(rMEvt, SdrMouseEventKind::BUTTONDOWN, aVEvt);
m_rView.MarkObj(aVEvt.pRootObj, pPV);
}
-checkTwoCklicks(rMEvt);
+checkTwoClicks(rMEvt);
m_pParent->getSectionWindow()->getViewsWindow()->getView()->getReportView()->UpdatePropertyBrowserDelayed(m_rView);
return bReturn;
}
@@ -832,7 +832,7 @@ bool DlgEdFuncSelect::MouseButtonUp( const MouseEvent&
rMEvt )
checkMovementAllowed(rMEvt);
m_pParent->getSectionWindow()->getViewsWindow()->EndAction();
-checkTwoCklicks(rMEvt);
+checkTwoClicks(rMEvt);
m_pParent->SetPointer( m_rView.GetPreferredPointer( aPnt, m_pParent) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/inc
sc/inc/externalrefmgr.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 746576f9124b9ed5a376a2d69063d3579588cec5 Author: Andrea Gelmini AuthorDate: Fri Sep 25 13:22:55 2020 +0200 Commit: Julien Nabet CommitDate: Sat Sep 26 09:53:39 2020 +0200 Fix typo in code It passed "make check" on Linux Change-Id: Ib55618ef7187f46143a0f4a514c608f8c499957e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103460 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/sc/inc/externalrefmgr.hxx b/sc/inc/externalrefmgr.hxx index 645b19558dc1..db81502b3ef6 100644 --- a/sc/inc/externalrefmgr.hxx +++ b/sc/inc/externalrefmgr.hxx @@ -89,7 +89,7 @@ public: OUString maUpperName; OUString maRealName; -explicit TableName(const OUString& rUppper, const OUString& rReal); +explicit TableName(const OUString& rUpper, const OUString& rReal); }; struct CellFormat ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/shells/txtnum.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 7f8ef5abc9ca8bfb41ac2d5aea25b78aed3d5566
Author: Andrea Gelmini
AuthorDate: Fri Sep 25 12:24:33 2020 +0200
Commit: Julien Nabet
CommitDate: Sat Sep 26 09:51:02 2020 +0200
Fix typo in code
It passed "make check" on Linux
Change-Id: I0d3bb7281b8b863d7a5eade7a4e37c6df106cfd2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103452
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/sw/source/uibase/shells/txtnum.cxx
b/sw/source/uibase/shells/txtnum.cxx
index aadc698ac024..3feff416724b 100644
--- a/sw/source/uibase/shells/txtnum.cxx
+++ b/sw/source/uibase/shells/txtnum.cxx
@@ -252,7 +252,7 @@ void SwTextShell::ExecSetNumber(SfxRequest const &rReq)
const SfxUInt16Item* pItem = rReq.GetArg(nSlot);
if ( pItem != nullptr )
{
-const sal_uInt16 nChoosenItemIdx = pItem->GetValue();
+const sal_uInt16 nChosenItemIdx = pItem->GetValue();
svx::sidebar::NBOType nNBOType =
svx::sidebar::NBOType::Bullets;
if ( nSlot == FN_SVX_SET_NUMBER )
nNBOType = svx::sidebar::NBOType::Numbering;
@@ -290,7 +290,7 @@ void SwTextShell::ExecSetNumber(SfxRequest const &rReq)
aSet.Put( SvxNumBulletItem( aNewSvxNumRule,
SID_ATTR_NUMBERING_RULE ) );
pNBOTypeMgr->SetItems( &aSet );
-pNBOTypeMgr->ApplyNumRule( aNewSvxNumRule, nChoosenItemIdx
- 1, nActNumLvl );
+pNBOTypeMgr->ApplyNumRule( aNewSvxNumRule, nChosenItemIdx
- 1, nActNumLvl );
aNewNumRule.SetSvxRule( aNewSvxNumRule,
GetShell().GetDoc() );
aNewNumRule.SetAutoRule( true );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: reportdesign/source
reportdesign/source/filter/xml/xmlStyleImport.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit de8163cfd10716cba3714cfdc0fa139a52aee669
Author: Andrea Gelmini
AuthorDate: Fri Sep 25 11:24:28 2020 +0200
Commit: Julien Nabet
CommitDate: Sat Sep 26 09:49:12 2020 +0200
Fix typo in code
It passed "make check" on Linux
Change-Id: Ic348406fd8b4dfff77687328dfd6824262af9f8a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103424
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/reportdesign/source/filter/xml/xmlStyleImport.cxx
b/reportdesign/source/filter/xml/xmlStyleImport.cxx
index a6cb71fa3d7a..07c2336349c2 100644
--- a/reportdesign/source/filter/xml/xmlStyleImport.cxx
+++ b/reportdesign/source/filter/xml/xmlStyleImport.cxx
@@ -45,10 +45,10 @@ using namespace xmloff::token;
namespace {
-class OSpecialHanldeXMLImportPropertyMapper : public SvXMLImportPropertyMapper
+class OSpecialHandleXMLImportPropertyMapper : public SvXMLImportPropertyMapper
{
public:
-OSpecialHanldeXMLImportPropertyMapper(const rtl::Reference<
XMLPropertySetMapper >& rMapper,SvXMLImport& _rImport) :
SvXMLImportPropertyMapper(rMapper ,_rImport)
+OSpecialHandleXMLImportPropertyMapper(const rtl::Reference<
XMLPropertySetMapper >& rMapper,SvXMLImport& _rImport) :
SvXMLImportPropertyMapper(rMapper ,_rImport)
{
}
/** this method is called for every item that has the
MID_FLAG_SPECIAL_ITEM_IMPORT flag set */
@@ -189,7 +189,7 @@ rtl::Reference < SvXMLImportPropertyMapper >
if( !m_xCellImpPropMapper.is() )
{
m_xCellImpPropMapper =
-new
XMLTextImportPropertyMapper/*OSpecialHanldeXMLImportPropertyMapper*/(
rImport.GetCellStylesPropertySetMapper(), m_rImport );
+new
XMLTextImportPropertyMapper/*OSpecialHandleXMLImportPropertyMapper*/(
rImport.GetCellStylesPropertySetMapper(), m_rImport );
m_xCellImpPropMapper->ChainImportMapper(XMLTextImportHelper::CreateParaExtPropMapper(m_rImport));
}
@@ -208,7 +208,7 @@ rtl::Reference < SvXMLImportPropertyMapper >
case XmlStyleFamily::TABLE_ROW:
{
if( !m_xRowImpPropMapper.is() )
-m_xRowImpPropMapper =new
OSpecialHanldeXMLImportPropertyMapper( rImport.GetRowStylesPropertySetMapper(),
m_rImport );
+m_xRowImpPropMapper =new
OSpecialHandleXMLImportPropertyMapper( rImport.GetRowStylesPropertySetMapper(),
m_rImport );
xMapper = m_xRowImpPropMapper;
}
break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/pagedlg/scuitphfedit.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 10db96edd94d224abff36ac3381294e0f139c0a7 Author: Andrea Gelmini AuthorDate: Fri Sep 25 11:19:16 2020 +0200 Commit: Julien Nabet CommitDate: Sat Sep 26 09:46:11 2020 +0200 Fix typo in code It passed "make check" on Linux Change-Id: Ic594ef08dbb389c5718202e1ec3408e18bf49b94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103423 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/sc/source/ui/pagedlg/scuitphfedit.cxx b/sc/source/ui/pagedlg/scuitphfedit.cxx index 06e3b0406f9e..6567f06b239c 100644 --- a/sc/source/ui/pagedlg/scuitphfedit.cxx +++ b/sc/source/ui/pagedlg/scuitphfedit.cxx @@ -715,8 +715,8 @@ IMPL_LINK_NOARG(ScHFEditPage, ListHdl_Impl, weld::ComboBox&, void) sal_Int64 nNow = sal_Int64(aNow.Seconds) * 10L + aNow.Nanosec; // order of dropdown vs select not guaranteed -bool bDiscrepency = m_xLbDefined->get_popup_shown() != m_bDropDownActive; -if (bDiscrepency) +bool bDiscrepancy = m_xLbDefined->get_popup_shown() != m_bDropDownActive; +if (bDiscrepancy) ListToggleHdl_Impl(*m_xLbDefined); bool bFocusToTarget = !m_xLbDefined->get_popup_shown() && m_nTimeToggled != -1 && (nNow - m_nTimeToggled < 8L); @@ -726,7 +726,7 @@ IMPL_LINK_NOARG(ScHFEditPage, ListHdl_Impl, weld::ComboBox&, void) RemoveFromDefinedList(); // keep balanced -if (bDiscrepency) +if (bDiscrepancy) ListToggleHdl_Impl(*m_xLbDefined); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: toolkit/qa
toolkit/qa/complex/toolkit/GridControl.java |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 02caeb507cb9e0d7ea6f6f789498d7a438ced4a2
Author: Andrea Gelmini
AuthorDate: Fri Sep 25 12:26:30 2020 +0200
Commit: Julien Nabet
CommitDate: Sat Sep 26 09:44:26 2020 +0200
Fix typo in code
It passed "make check" on Linux
Change-Id: I9114b844b014d561464317ad6f54b54fe5a81d72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103454
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/toolkit/qa/complex/toolkit/GridControl.java
b/toolkit/qa/complex/toolkit/GridControl.java
index 8b1bcea411b2..b2338ee68f93 100644
--- a/toolkit/qa/complex/toolkit/GridControl.java
+++ b/toolkit/qa/complex/toolkit/GridControl.java
@@ -643,9 +643,9 @@ public class GridControl
}
-public T createInstance( Class i_interfaceClass, final String
i_serviceIndentifer ) throws Exception
+public T createInstance( Class i_interfaceClass, final String
i_serviceIndentifier ) throws Exception
{
-return UnoRuntime.queryInterface( i_interfaceClass, createInstance(
i_serviceIndentifer ) );
+return UnoRuntime.queryInterface( i_interfaceClass, createInstance(
i_serviceIndentifier ) );
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/vba/vbarange.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2078dbdbf265b77b7e09b84527258b1a5fb9af93 Author: Andrea Gelmini AuthorDate: Fri Sep 25 11:55:07 2020 +0200 Commit: Julien Nabet CommitDate: Sat Sep 26 09:42:06 2020 +0200 Fix typo in code It passed "make check" on Linux Change-Id: I01fc9d96c9850c67d8eac65ed2cb2a76fed7706c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103447 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/sc/source/ui/vba/vbarange.hxx b/sc/source/ui/vba/vbarange.hxx index 76cccdb5e1bb..f2ecc43a8e2d 100644 --- a/sc/source/ui/vba/vbarange.hxx +++ b/sc/source/ui/vba/vbarange.hxx @@ -83,7 +83,7 @@ class ScVbaRange : public ScVbaRange_BASE double getCalcColWidth(const css::table::CellRangeAddress&); /// @throws css::uno::RuntimeException double getCalcRowHeight(const css::table::CellRangeAddress&); -void visitArray( ArrayVisitor& vistor ); +void visitArray( ArrayVisitor& visitor ); /// @throws css::uno::RuntimeException css::uno::Reference< ov::excel::XRange > getEntireColumnOrRow( bool bColumn ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sal/osl
sal/osl/w32/pipe.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 7d5499c5e1bae536fe54434ff95e1fbbd2e3361d
Author: Andrea Gelmini
AuthorDate: Fri Sep 25 11:54:14 2020 +0200
Commit: Julien Nabet
CommitDate: Sat Sep 26 09:41:23 2020 +0200
Fix typo in code
It passed "make check" on Linux
Change-Id: I61781bccc365630f15a9baef5224012b0775edbe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103446
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/sal/osl/w32/pipe.cxx b/sal/osl/w32/pipe.cxx
index 06a6bf82d98d..3e71ef1d44d2 100644
--- a/sal/osl/w32/pipe.cxx
+++ b/sal/osl/w32/pipe.cxx
@@ -285,7 +285,7 @@ oslPipe SAL_CALL osl_acceptPipe(oslPipe pPipe)
OVERLAPPED os = {};
-DWORD nBytesTransfered;
+DWORD nBytesTransferred;
rtl_uString* path = nullptr;
rtl_uString* temp = nullptr;
@@ -311,7 +311,7 @@ oslPipe SAL_CALL osl_acceptPipe(oslPipe pPipe)
case ERROR_IO_PENDING: // This is normal if not client is
connected yet
case ERROR_MORE_DATA: // Should not happen
// blocking call to accept
-if( !GetOverlappedResult(pPipe->m_File, &os,
&nBytesTransfered, TRUE))
+if( !GetOverlappedResult(pPipe->m_File, &os,
&nBytesTransferred, TRUE))
{
// Possible error could be that between ConnectNamedPipe
and
// GetOverlappedResult a connect took place.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: test/source
test/source/sheet/xcellrangereferrer.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 5ddfa8cecbdf70c23b30f74d8220fae0c5fb22fa Author: Andrea Gelmini AuthorDate: Fri Sep 25 12:25:14 2020 +0200 Commit: Julien Nabet CommitDate: Sat Sep 26 09:40:34 2020 +0200 Fix typo in code It passed "make check" on Linux Change-Id: Ia508a9968a21fc8e316a3ec5bb1aa204c4dfc2c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103453 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/test/source/sheet/xcellrangereferrer.cxx b/test/source/sheet/xcellrangereferrer.cxx index 3d286d558945..e232c565d2b6 100644 --- a/test/source/sheet/xcellrangereferrer.cxx +++ b/test/source/sheet/xcellrangereferrer.cxx @@ -26,8 +26,8 @@ void XCellRangeReferrer::testGetReferredCells() uno::Reference< sheet::XCellRangeReferrer > xReferrer(init(), UNO_QUERY_THROW); uno::Reference< table::XCellRange > xReferredRange = xReferrer->getReferredCells(); -uno::Reference< sheet::XCellRangeAddressable > xAdressable( xReferredRange, UNO_QUERY_THROW ); -table::CellRangeAddress aCellRange = xAdressable->getRangeAddress(); +uno::Reference< sheet::XCellRangeAddressable > xAddressable( xReferredRange, UNO_QUERY_THROW ); +table::CellRangeAddress aCellRange = xAddressable->getRangeAddress(); CPPUNIT_ASSERT_EQUAL(aCellRange, getCellRange()); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: wizards/source
wizards/source/template/Samples.xba |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit ecf3857ce5b098db78ddd12c7f532b7e726e78e6
Author: Andrea Gelmini
AuthorDate: Fri Sep 25 12:16:14 2020 +0200
Commit: Julien Nabet
CommitDate: Sat Sep 26 09:38:54 2020 +0200
Fix typo in code
It passed "make check" on Linux
Change-Id: I66b0ea493386cb93780d52b76d5f035ecf7c6541
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103451
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/wizards/source/template/Samples.xba
b/wizards/source/template/Samples.xba
index 3009f4cba705..25ff81bcf14d 100644
--- a/wizards/source/template/Samples.xba
+++ b/wizards/source/template/Samples.xba
@@ -110,7 +110,7 @@ End Sub
Sub SaveCurrentStyles(oDocument as Object)
'This sub stores the current document in the directory to hold temporary
files.
- On Error Goto ErrorOcurred
+ On Error Goto ErrorOccurred
aTempURL = GetPathSettings("Temp", False)
Dim aRightMost as String
aRightMost = Right(aTempURL, 1)
@@ -126,7 +126,7 @@ Sub SaveCurrentStyles(oDocument as Object)
oDocument.storeToURL(aTempURL, NoArgs())
Exit Sub
-ErrorOcurred:
+ErrorOccurred:
MsgBox(GetResText("STYLES_1"), 16,
GetResText("STYLES_0"))
On Local Error Goto 0
End Sub
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/layout/pagechg.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 37976a6eac90e0fdac01ea2ca997bb9c02b51c57
Author: Andrea Gelmini
AuthorDate: Fri Sep 25 11:16:59 2020 +0200
Commit: Julien Nabet
CommitDate: Sat Sep 26 09:38:16 2020 +0200
Fix typo in code
It passed "make check" on Linux
Change-Id: I9d95e990c77a7b40046990433b95fccdf0013fc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103421
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/sw/source/core/layout/pagechg.cxx
b/sw/source/core/layout/pagechg.cxx
index d9d672afaee9..eee3bfb9ade5 100644
--- a/sw/source/core/layout/pagechg.cxx
+++ b/sw/source/core/layout/pagechg.cxx
@@ -1449,9 +1449,9 @@ void SwRootFrame::RemoveSuperfluous()
// attached to generic content it is also superfluous (checking
DocBody should be enough)
// OD 19.06.2003 #108784# - consider that drawing objects in
// header/footer are supported now.
-bool bOnlySuperfluosObjs = true;
+bool bOnlySuperfluousObjs = true;
SwSortedObjs &rObjs = *pPage->GetSortedObjs();
-for ( size_t i = 0; bOnlySuperfluosObjs && i < rObjs.size(); ++i )
+for ( size_t i = 0; bOnlySuperfluousObjs && i < rObjs.size(); ++i )
{
// #i28701#
SwAnchoredObject* pAnchoredObj = rObjs[i];
@@ -1460,10 +1460,10 @@ void SwRootFrame::RemoveSuperfluous()
pAnchoredObj->GetDrawObj()->GetLayer() ) &&
!pAnchoredObj->GetAnchorFrame()->FindFooterOrHeader() )
{
-bOnlySuperfluosObjs = false;
+bOnlySuperfluousObjs = false;
}
}
-bExistEssentialObjs = !bOnlySuperfluosObjs;
+bExistEssentialObjs = !bOnlySuperfluousObjs;
}
// OD 19.06.2003 #108784# - optimization: check first, if essential
objects
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/source
sd/source/ui/unoidl/UnoDocumentSettings.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit eaf4d66dc7a1d1d0a48b5c434db7c9588f5fa568
Author: Julien Nabet
AuthorDate: Fri Sep 25 22:28:33 2020 +0200
Commit: Julien Nabet
CommitDate: Sat Sep 26 09:34:01 2020 +0200
Typo HANDLE_PRINTHIDENPAGES -> HANDLE_PRINTHIDDENPAGES
(sd/UnoDocumentSettings)
Change-Id: I62a7a92b478df42282ebf49410119cb6a408ffe9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103468
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/sd/source/ui/unoidl/UnoDocumentSettings.cxx
b/sd/source/ui/unoidl/UnoDocumentSettings.cxx
index 8e67f3ff5792..f7265afc3844 100644
--- a/sd/source/ui/unoidl/UnoDocumentSettings.cxx
+++ b/sd/source/ui/unoidl/UnoDocumentSettings.cxx
@@ -138,7 +138,7 @@ enum SdDocumentSettingsPropertyHandles
{
HANDLE_PRINTDRAWING, HANDLE_PRINTNOTES, HANDLE_PRINTHANDOUT,
HANDLE_PRINTOUTLINE, HANDLE_MEASUREUNIT, HANDLE_SCALE_NUM,
HANDLE_SCALE_DOM, HANDLE_TABSTOP, HANDLE_PRINTPAGENAME, HANDLE_PRINTDATE,
HANDLE_PRINTTIME,
-HANDLE_PRINTHIDENPAGES, HANDLE_PRINTFITPAGE, HANDLE_PRINTTILEPAGE,
HANDLE_PRINTBOOKLET, HANDLE_PRINTBOOKLETFRONT,
+HANDLE_PRINTHIDDENPAGES, HANDLE_PRINTFITPAGE, HANDLE_PRINTTILEPAGE,
HANDLE_PRINTBOOKLET, HANDLE_PRINTBOOKLETFRONT,
HANDLE_PRINTBOOKLETBACK, HANDLE_PRINTQUALITY, HANDLE_COLORTABLEURL,
HANDLE_DASHTABLEURL, HANDLE_LINEENDTABLEURL, HANDLE_HATCHTABLEURL,
HANDLE_GRADIENTTABLEURL, HANDLE_BITMAPTABLEURL, HANDLE_FORBIDDENCHARS,
HANDLE_APPLYUSERDATA, HANDLE_SAVETHUMBNAIL, HANDLE_PAGENUMFMT,
HANDLE_PRINTERNAME, HANDLE_PRINTERJOB, HANDLE_PRINTERPAPERSIZE,
HANDLE_PARAGRAPHSUMMATION, HANDLE_CHARCOMPRESS, HANDLE_ASIANPUNCT,
@@ -185,7 +185,7 @@ enum SdDocumentSettingsPropertyHandles
{ OUString("IsPrintPageName"), HANDLE_PRINTPAGENAME,
cppu::UnoType::get(),0, MID_PRINTER },
{ OUString("IsPrintDate"), HANDLE_PRINTDATE,
cppu::UnoType::get(),0, MID_PRINTER },
{ OUString("IsPrintTime"), HANDLE_PRINTTIME,
cppu::UnoType::get(),0, MID_PRINTER },
-{ OUString("IsPrintHiddenPages"),HANDLE_PRINTHIDENPAGES,
cppu::UnoType::get(),0, MID_PRINTER },
+{ OUString("IsPrintHiddenPages"),HANDLE_PRINTHIDDENPAGES,
cppu::UnoType::get(),0, MID_PRINTER },
{ OUString("IsPrintFitPage"),HANDLE_PRINTFITPAGE,
cppu::UnoType::get(),0, MID_PRINTER },
{ OUString("IsPrintTilePage"), HANDLE_PRINTTILEPAGE,
cppu::UnoType::get(),0, MID_PRINTER },
{ OUString("IsPrintBooklet"),HANDLE_PRINTBOOKLET,
cppu::UnoType::get(),0, MID_PRINTER },
@@ -594,7 +594,7 @@ DocumentSettings::_setPropertyValues(const
PropertyMapEntry** ppEntries,
bOk = true;
}
break;
-case HANDLE_PRINTHIDENPAGES:
+case HANDLE_PRINTHIDDENPAGES:
if( *pValues >>= bValue )
{
if( aPrintOpts.IsHiddenPages() != bValue)
@@ -1148,7 +1148,7 @@ DocumentSettings::_getPropertyValues(
case HANDLE_PRINTTIME:
*pValue <<= aPrintOpts.IsTime();
break;
-case HANDLE_PRINTHIDENPAGES:
+case HANDLE_PRINTHIDDENPAGES:
*pValue <<= aPrintOpts.IsHiddenPages();
break;
case HANDLE_PRINTFITPAGE:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: LTO on Windows now working
Am 25.09.20 um 12:54 schrieb Michael Meeks: > I wonder if, ABI-wise, we could static link sal with libmerged for the > purpose of LTO and get away with it =) I disagree. > Since there is no real C++ ABI, and no exported symbols, particuarly > exceptions there - that could work across platforms and give a big win. > > Ideally we could get down the chain from the grey (cf. attached > picture) to the bottom there: cppuhelper, xmlreader, cppu, salhelper, sal. Nope :) https://packages.debian.org/search?keywords=libuno-sal3 https://packages.debian.org/search?keywords=libuno-cppu3 https://packages.debian.org/search?keywords=libuno-cppuhelpergcc3-3 https://packages.debian.org/search?keywords=libuno-salhelpergcc3-3 Given it's a public library it has to be in /usr/lib. :) And there is https://packages.debian.org/search?keywords=uno-libs-private as a hack given public libraries need said xmlreader ... ... > I imagine on Linux that would cause severe grief around exceptions - > but I think Windows can handle that with string comparisons at some cost (?) > > I wonder if (assuming we still believe that C++ UNO plugins exists as a > 'thing' ;-) We could try on Linux increasing libmerged to include all of > the lower base code - too - and (perhaps) - symlink it to all of the old > library names. I -think- (worth checking) that the library loader will > resolve those through the symlink to the same library loaded once - > arguably giving back-compatibility at the expense of some packaging > changes (I guess). With the expense of overhauling the whole package, merging all those libs into "ure" and/or make simple "ure" depend on the whole lot of libreoffice-core? https://packages.debian.org/search?keywords=ure One can use LTO (if one makes it work on Linux, but then as I know LO it will only be kept working for x86-64 anyway...) but please don't merge those public libraries :-) Regards. Rene ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
