[Libreoffice-commits] help.git: source/text

[Johnny_M (via logerrit)]

 source/text/shared/01/01010300.xhp |2 +-
 source/text/shared/01/01010302.xhp |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit efac120187d863d4598b507eda8cceb5870e0f2e
Author: Johnny_M 
AuthorDate: Tue Oct 27 11:40:13 2020 +0100
Commit: Olivier Hallot 
CommitDate: Wed Oct 28 20:01:50 2020 +0100

tdf#132643 Translate German section IDs

Change-Id: I455e562ddb4a157beb2e985675189db87678ee95
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104872
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/shared/01/01010300.xhp 
b/source/text/shared/01/01010300.xhp
index c32b209b1..02870cd04 100644
--- a/source/text/shared/01/01010300.xhp
+++ b/source/text/shared/01/01010300.xhp
@@ -37,7 +37,7 @@
   
 
 
-
+
 
 
 
diff --git a/source/text/shared/01/01010302.xhp 
b/source/text/shared/01/01010302.xhp
index 722f8a905..5bce06dcf 100644
--- a/source/text/shared/01/01010302.xhp
+++ b/source/text/shared/01/01010302.xhp
@@ -28,7 +28,7 @@
   
 
 
-
+
 
 Business 
Cards
   Define the appearance of your business 
cards.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 132643] [LOCALHELP] Translate section id to English mnemonics

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132643

--- Comment #170 from Commit Notification 
 ---
Johnny_M committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/a7381ac50a77e80b08f77c1ee2527fbc28ba720e

tdf#132643 Translate German section IDs

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: source/text

[Johnny_M (via logerrit)]

 source/text/scalc/01/0502.xhp|2 +-
 source/text/scalc/01/0507.xhp|2 +-
 source/text/scalc/01/cell_styles.xhp |2 +-
 source/text/scalc/01/format_graphic.xhp  |2 +-
 source/text/scalc/main0203.xhp   |4 ++--
 source/text/schart/01/05010100.xhp   |2 +-
 source/text/schart/01/05010200.xhp   |2 +-
 source/text/schart/01/05020100.xhp   |2 +-
 source/text/schart/01/05020200.xhp   |2 +-
 source/text/schart/01/0503.xhp   |2 +-
 source/text/schart/01/0506.xhp   |2 +-
 source/text/schart/01/0507.xhp   |2 +-
 source/text/schart/01/0508.xhp   |2 +-
 source/text/sdraw/main0202.xhp   |4 ++--
 source/text/shared/00/00040502.xhp   |6 +++---
 source/text/shared/01/02100300.xhp   |2 +-
 source/text/shared/01/0503.xhp   |2 +-
 source/text/shared/01/0521.xhp   |6 +++---
 source/text/shared/01/05210100.xhp   |4 ++--
 source/text/shared/01/05210200.xhp   |2 +-
 source/text/simpress/01/0509m.xhp|2 +-
 source/text/simpress/main0202.xhp|4 ++--
 source/text/swriter/01/0402.xhp  |2 +-
 source/text/swriter/01/04120200.xhp  |2 +-
 source/text/swriter/01/0413.xhp  |2 +-
 source/text/swriter/01/0504.xhp  |2 +-
 source/text/swriter/01/05040501.xhp  |2 +-
 source/text/swriter/01/0506.xhp  |2 +-
 source/text/swriter/01/0508.xhp  |2 +-
 source/text/swriter/01/0509.xhp  |2 +-
 source/text/swriter/01/format_object.xhp |2 +-
 source/text/swriter/main0205.xhp |4 ++--
 32 files changed, 41 insertions(+), 41 deletions(-)

New commits:
commit a7381ac50a77e80b08f77c1ee2527fbc28ba720e
Author: Johnny_M 
AuthorDate: Sat Oct 24 16:49:44 2020 +0200
Commit: Olivier Hallot 
CommitDate: Wed Oct 28 20:01:07 2020 +0100

tdf#132643 Translate German section IDs

Change-Id: Ibe35e3fe95f1e9a62c2bf364eeb9350d62c7c81a
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104755
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/scalc/01/0502.xhp 
b/source/text/scalc/01/0502.xhp
index 5abb23bef..914bdf834 100644
--- a/source/text/scalc/01/0502.xhp
+++ b/source/text/scalc/01/0502.xhp
@@ -50,7 +50,7 @@
 
 
 
-
+
 
 
 
diff --git a/source/text/scalc/01/0507.xhp 
b/source/text/scalc/01/0507.xhp
index 945b0ff83..ba45acc41 100644
--- a/source/text/scalc/01/0507.xhp
+++ b/source/text/scalc/01/0507.xhp
@@ -44,7 +44,7 @@
   
   
   
-  
+  
   
   
   
diff --git a/source/text/scalc/01/cell_styles.xhp 
b/source/text/scalc/01/cell_styles.xhp
index 8b5620e0f..cf8471849 100644
--- a/source/text/scalc/01/cell_styles.xhp
+++ b/source/text/scalc/01/cell_styles.xhp
@@ -30,7 +30,7 @@
 
 
 
-
+
 
 
 
diff --git a/source/text/scalc/01/format_graphic.xhp 
b/source/text/scalc/01/format_graphic.xhp
index 291ca395d..c0d0118e5 100644
--- a/source/text/scalc/01/format_graphic.xhp
+++ b/source/text/scalc/01/format_graphic.xhp
@@ -37,7 +37,7 @@
 
 
 
-
+
 Define Text Attributes
 Sets the layout 
and anchoring properties for text in the selected drawing or text 
object.
 Points
diff --git a/source/text/scalc/main0203.xhp b/source/text/scalc/main0203.xhp
index 9d53c4118..113a02a78 100644
--- a/source/text/scalc/main0203.xhp
+++ b/source/text/scalc/main0203.xhp
@@ -48,8 +48,8 @@
 Line 
Color
 
 
-
-
+
+
 Background 
Color
 
 
diff --git a/source/text/schart/01/05010100.xhp 
b/source/text/schart/01/05010100.xhp
index c67c535cf..69747a9dd 100644
--- a/source/text/schart/01/05010100.xhp
+++ b/source/text/schart/01/05010100.xhp
@@ -38,7 +38,7 @@
   
 
   
-  
+  
   
   
   
diff --git a/source/text/schart/01/05010200.xhp 
b/source/text/schart/01/05010200.xhp
index f6bebfdc1..ad26df74d 100644
--- a/source/text/schart/01/05010200.xhp
+++ b/source/text/schart/01/05010200.xhp
@@ -33,7 +33,7 @@
   
 
 
-
+
 
 
 
diff --git a/source/text/schart/01/05020100.xhp 
b/source/text/schart/01/05020100.xhp
index a18228ff5..ee62bf183 100644
--- a/source/text/schart/01/05020100.xhp
+++ b/source/text/schart/01/05020100.xhp
@@ -42,7 +42,7 @@
  
   
   
-  
+  
   
   
   
diff --git a/source/text/schart/01/05020200.xhp 
b/source/text/schart/01/05020200.xhp
index e4ac4b86e..dc58ebc2e 100644
--- a/source/text/schart/01/05020200.xhp
+++ b/source/text/schart/01/05020200.xhp
@@ -36,7 +36,7 @@
   
 
 
-
+
 
 
 
diff --git a/source/text/schart/01/0503.xhp 
b/source/text/schart/01/0503.xhp
index 4683a943b..1416708e6 100644
--- a/source/text/schart/01/0503.xhp
+++ b/source/text/schart/01/0503.xhp
@@ -31,7 +31,7 @@
   
 
 
-
+
 
 
 Display
diff --git a/source/text/schart/01/0506.xhp 
b/source/text/schart/01/0506.xhp
index a8feea474..a6be31e3b 100644
--- a/source/text/schart/01/0506.xhp
+++ b/source/text/schart/01/0506.xhp
@@ -38,7 +38,7 @@
   
 
   

[Libreoffice-commits] core.git: helpcontent2

[Johnny_M (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit aa96113f89ded1ff8ee877abc3ab0d48619327b3
Author: Johnny_M 
AuthorDate: Wed Oct 28 21:01:07 2020 +0200
Commit: Gerrit Code Review 
CommitDate: Wed Oct 28 20:01:07 2020 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to a7381ac50a77e80b08f77c1ee2527fbc28ba720e
  - tdf#132643 Translate German section IDs

Change-Id: Ibe35e3fe95f1e9a62c2bf364eeb9350d62c7c81a
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104755
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index c8a9ac72bc5e..a7381ac50a77 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit c8a9ac72bc5e68f8a69490e3c157fe26b935f524
+Subproject commit a7381ac50a77e80b08f77c1ee2527fbc28ba720e
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 137835] New: UI: Add right click context menu for rename slide/page & delete slide

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137835

Bug ID: 137835
   Summary: UI: Add right click context menu for rename slide/page
& delete slide
   Product: LibreOffice
   Version: 7.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
UI: Add right click context menu for rename slide/page & delete slide

Steps to Reproduce:
1. Open Draw
2. Open navigator deck
3. Right click they Page 

Actual Results:
No context menu

Expected Results:
Something similar to Writer


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 94e6e140491de31c0788c91af855a75a3bb12709
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137834] UI: Navigator content not refreshed after renaming a page/slide in Draw/Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137834

Telesto  changed:

   What|Removed |Added

 CC||rayk...@gmail.com

--- Comment #2 from Telesto  ---
@Jim
This is something you might be interested in or an easy hack, I guess

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137834] UI: Navigator content not refreshed after renaming a page/slide in Draw/Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137834

--- Comment #1 from Telesto  ---
Also found in
6.0

Changing deck triggers and update with 4.4.7.2 (so this partly a regression)

Adding a new slide, and the deck is updated

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135608] When having a dialog open in multiple documents you can't freely switch between documents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135608

Milston B.  changed:

   What|Removed |Added

 CC||mils...@live.de
 Resolution|--- |NOTABUG
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Milston B.  ---
This behaviour has nothing to do with LibreOffice. This behaviour comes from
the OS, in your case Windows. Therefore it's not a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137834] New: UI: Navigator content not refreshed after renaming a page/slide in Draw/Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137834

Bug ID: 137834
   Summary: UI: Navigator content not refreshed after renaming a
page/slide in Draw/Impress
   Product: LibreOffice
   Version: 7.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
UI: Navigator content not refreshed after renaming a page/slide in Draw/Impress

Steps to Reproduce:
1. Open Draw
2. Set sidebar to Navigator
3. Right Click they slide/page panel & select rename
4. Type something and apply
5. Notice the name not being updating in navigator
6. Switch deck.. still not updating

Actual Results:
Navigator isn't refreshed after page name change

Expected Results:
Should be so


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 94e6e140491de31c0788c91af855a75a3bb12709
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137442] Postgresql schema missing in Table Filter

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137442

Robert Großkopf  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||rob...@familiegrosskopf.de

--- Comment #1 from Robert Großkopf  ---
Which connection to PostgreSQL do you use? Direct, JDBC or ODBC?

Do I have only to run
CREATE SCHEMA IF NOT EXISTS reports 
to see the behavior?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Attila Bakos (NISZ) (via logerrit)]

 sw/source/core/doc/textboxhelper.cxx |   54 +++
 1 file changed, 54 insertions(+)

New commits:
commit 0b5801fc2c768d1774957c2c122c9061d3a74756
Author: Attila Bakos (NISZ) 
AuthorDate: Wed Oct 21 15:50:25 2020 +0200
Commit: László Németh 
CommitDate: Wed Oct 28 19:41:13 2020 +0100

tdf#137798 sw: apply textbox Text alignment

set in "Text" dialog window using "Text Anchor"
in Format -> Text Box and Shape -> Text
attributes... on the selected text box.

Follow up of commit 726c911b90b9a3170fa6b3a34bb952a8d2dbe148
(tdf#137025 sw: apply textbox padding set in Text).

Change-Id: I8c575ceb1d0b0772c1f7d99dc746531b0cd7ceb4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104632
Tested-by: Jenkins
Tested-by: László Németh 
Reviewed-by: László Németh 

diff --git a/sw/source/core/doc/textboxhelper.cxx 
b/sw/source/core/doc/textboxhelper.cxx
index e5b7f82dc94b..e982174e51ac 100644
--- a/sw/source/core/doc/textboxhelper.cxx
+++ b/sw/source/core/doc/textboxhelper.cxx
@@ -46,6 +46,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 
 using namespace com::sun::star;
 
@@ -148,6 +150,8 @@ void SwTextBoxHelper::create(SwFrameFormat* pShape)
 if (xShapePropertySet->getPropertyValue(UNO_NAME_TEXT_WRITINGMODE) >>= 
eMode)
 syncProperty(pShape, RES_FRAMEDIR, 0, uno::makeAny(sal_Int16(eMode)));
 
+// TODO: Text dialog attr setting to frame
+
 const SwFormatAnchor& rAnch = pShape->GetAnchor();
 if (!((rAnch.GetAnchorId() == RndStdIds::FLY_AT_PAGE && rAnch.GetPageNum() 
!= 0)
   || ((rAnch.GetAnchorId() == RndStdIds::FLY_AT_PARA
@@ -395,6 +399,45 @@ tools::Rectangle 
SwTextBoxHelper::getTextRectangle(SwFrameFormat* pShape, bool b
 void SwTextBoxHelper::syncProperty(SwFrameFormat* pShape, const OUString& 
rPropertyName,
const css::uno::Any& rValue)
 {
+// Textframes does not have valid horizontal adjust property, so map it to 
paragraph adjust property
+if (rPropertyName == UNO_NAME_TEXT_HORZADJUST)
+{
+SwFrameFormat* pFormat = getOtherTextBoxFormat(pShape, RES_DRAWFRMFMT);
+if (!pFormat)
+return;
+
+auto xTextFrame = SwXTextFrame::CreateXTextFrame(*pFormat->GetDoc(), 
pFormat);
+uno::Reference xCursor = 
xTextFrame->getText()->createTextCursor();
+
+// Select all paragraps in the textframe
+xCursor->gotoStart(false);
+xCursor->gotoEnd(true);
+uno::Reference xFrameParaProps(xCursor, 
uno::UNO_QUERY);
+
+// And simply map the property
+switch (rValue.get())
+{
+case drawing::TextHorizontalAdjust::TextHorizontalAdjust_CENTER:
+xFrameParaProps->setPropertyValue(
+UNO_NAME_PARA_ADJUST,
+
uno::makeAny(style::ParagraphAdjust::ParagraphAdjust_CENTER)); //3
+break;
+case drawing::TextHorizontalAdjust::TextHorizontalAdjust_LEFT:
+xFrameParaProps->setPropertyValue(
+UNO_NAME_PARA_ADJUST,
+
uno::makeAny(style::ParagraphAdjust::ParagraphAdjust_LEFT)); //0
+break;
+case drawing::TextHorizontalAdjust::TextHorizontalAdjust_RIGHT:
+xFrameParaProps->setPropertyValue(
+UNO_NAME_PARA_ADJUST,
+
uno::makeAny(style::ParagraphAdjust::ParagraphAdjust_RIGHT)); //1
+break;
+default:
+break;
+}
+return;
+}
+
 if (rPropertyName == "CustomShapeGeometry")
 {
 // CustomShapeGeometry changes the textbox position offset and size, 
so adjust both.
@@ -838,6 +881,7 @@ void SwTextBoxHelper::updateTextBoxMargin(SdrObject* pObj)
 if (!pParentFormat)
 return;
 
+// Sync the padding
 syncProperty(pParentFormat, UNO_NAME_TEXT_LEFTDIST,
  xPropertySet->getPropertyValue(UNO_NAME_TEXT_LEFTDIST));
 syncProperty(pParentFormat, UNO_NAME_TEXT_RIGHTDIST,
@@ -846,6 +890,16 @@ void SwTextBoxHelper::updateTextBoxMargin(SdrObject* pObj)
  xPropertySet->getPropertyValue(UNO_NAME_TEXT_UPPERDIST));
 syncProperty(pParentFormat, UNO_NAME_TEXT_LOWERDIST,
  xPropertySet->getPropertyValue(UNO_NAME_TEXT_LOWERDIST));
+
+// Sync the text aligning
+syncProperty(pParentFormat, UNO_NAME_TEXT_VERTADJUST,
+ xPropertySet->getPropertyValue(UNO_NAME_TEXT_VERTADJUST));
+syncProperty(pParentFormat, UNO_NAME_TEXT_HORZADJUST,
+ xPropertySet->getPropertyValue(UNO_NAME_TEXT_HORZADJUST));
+
+//FIXME: Sync autogrow: needs repositioning after sync
+//syncProperty(pParentFormat, RES_FRM_SIZE, MID_FRMSIZE_IS_AUTO_HEIGHT,
+// 
xPropertySet->getPropertyValue(UNO_NAME_TEXT_AUTOGROWHEIGHT));
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

[Libreoffice-commits] core.git: filter/CppunitTest_filter_textfilterdetect.mk filter/Library_textfd.mk filter/qa filter/source include/tools sfx2/source tools/source

[Miklos Vajna (via logerrit)]

 filter/CppunitTest_filter_textfilterdetect.mk   |7 ---
 filter/Library_textfd.mk|1 
 filter/qa/unit/textfilterdetect.cxx |   46 ++--
 filter/source/textfilterdetect/filterdetect.cxx |   32 
 include/tools/stream.hxx|6 +++
 sfx2/source/doc/objstor.cxx |6 ++-
 tools/source/stream/stream.cxx  |   20 ++
 7 files changed, 108 insertions(+), 10 deletions(-)

New commits:
commit ada07f303e7cd1e39c73abe0741aefe7d9d73a57
Author: Miklos Vajna 
AuthorDate: Wed Oct 28 14:54:52 2020 +0100
Commit: Miklos Vajna 
CommitDate: Wed Oct 28 19:34:45 2020 +0100

tdf#123476 filter: try to detect 0-byte files based on extension

A 0-byte ("empty") pptx file is obviously junk input, so it's not
surprising if the catch-all generic_Text filter is chosen to open it in
Writer at the end.

But we can do better: if we really get an empty file URL with an
extension we can recognize, that we can fake the filter type / filter
name, so the empty "presentation" opens in Impress, and also a re-save
works as expected.

This builds on top of commit 8a201be240b6d408d15166be7ffc576b9e123634
(fdo#68903 Import .tsv and .xls plain text files in Calc by default,
2013-10-27), just the new way works for all supported file extensions
and also with filters which would not handle empty input (e.g. pptx
refuses the import if the ZIP storage is broken).

Change-Id: Ie01650a5eb6ca42c35e090133965467b621bb526
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104939
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/filter/CppunitTest_filter_textfilterdetect.mk 
b/filter/CppunitTest_filter_textfilterdetect.mk
index a5a6263abdb8..4066c26591a3 100644
--- a/filter/CppunitTest_filter_textfilterdetect.mk
+++ b/filter/CppunitTest_filter_textfilterdetect.mk
@@ -36,12 +36,7 @@ $(eval $(call 
gb_CppunitTest_use_ure,filter_textfilterdetect))
 
 $(eval $(call gb_CppunitTest_use_vcl,filter_textfilterdetect))
 
-$(eval $(call gb_CppunitTest_use_components,filter_textfilterdetect,\
-configmgr/source/configmgr \
-filter/source/textfilterdetect/textfd \
-ucb/source/core/ucb1 \
-ucb/source/ucp/file/ucpfile1 \
-))
+$(eval $(call gb_CppunitTest_use_rdb,filter_textfilterdetect,services))
 
 $(eval $(call gb_CppunitTest_use_configuration,filter_textfilterdetect))
 
diff --git a/filter/Library_textfd.mk b/filter/Library_textfd.mk
index e6d3889410af..c6155f1e9876 100644
--- a/filter/Library_textfd.mk
+++ b/filter/Library_textfd.mk
@@ -23,6 +23,7 @@ $(eval $(call gb_Library_use_libraries,textfd,\
cppuhelper \
cppu \
sal \
+   sfx \
tl \
utl \
svt \
diff --git a/filter/qa/unit/data/empty.pptx b/filter/qa/unit/data/empty.pptx
new file mode 100644
index ..e69de29bb2d1
diff --git a/filter/qa/unit/textfilterdetect.cxx 
b/filter/qa/unit/textfilterdetect.cxx
index 0995147c3b78..fb1ff1d2ac7e 100644
--- a/filter/qa/unit/textfilterdetect.cxx
+++ b/filter/qa/unit/textfilterdetect.cxx
@@ -7,10 +7,14 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+#include 
+#include 
+
 #include 
+#include 
+#include 
 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -25,10 +29,31 @@ using namespace com::sun::star;
 namespace
 {
 /// Test class for PlainTextFilterDetect.
-class TextFilterDetectTest : public test::BootstrapFixture
+class TextFilterDetectTest : public test::BootstrapFixture, public 
unotest::MacrosTest
 {
+uno::Reference mxComponent;
+
+public:
+void setUp() override;
+void tearDown() override;
+uno::Reference& getComponent() { return mxComponent; }
 };
 
+void TextFilterDetectTest::setUp()
+{
+test::BootstrapFixture::setUp();
+
+mxDesktop.set(frame::Desktop::create(mxComponentContext));
+}
+
+void TextFilterDetectTest::tearDown()
+{
+if (mxComponent.is())
+mxComponent->dispose();
+
+test::BootstrapFixture::tearDown();
+}
+
 char const DATA_DIRECTORY[] = "/filter/qa/unit/data/";
 
 CPPUNIT_TEST_FIXTURE(TextFilterDetectTest, testTdf114428)
@@ -50,6 +75,23 @@ CPPUNIT_TEST_FIXTURE(TextFilterDetectTest, testTdf114428)
 // This was empty, XML declaration caused HTML detect to not handle XHTML.
 CPPUNIT_ASSERT_EQUAL(OUString("HTML (StarWriter)"), aFilterName);
 }
+
+CPPUNIT_TEST_FIXTURE(TextFilterDetectTest, testEmptyFile)
+{
+// Given an empty file, with a pptx extension
+OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) + "empty.pptx";
+
+// When loading the file
+getComponent() = loadFromDesktop(aURL);
+
+// Then make sure it is opened in Impress.
+uno::Reference xServiceInfo(getComponent(), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xServiceInfo.is());
+
+// Without the accompanying fix in place, this test would have failed, as 
it was opened in
+

[Libreoffice-bugs] [Bug 112521] [META] Message box dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112521
Bug 112521 depends on bug 125379, which changed state.

Bug 125379 Summary: Add a link to FAQ to "JRE missing" message box
https://bugs.documentfoundation.org/show_bug.cgi?id=125379

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/Library_cui.mk cui/source include/unotools unotools/source vcl/source

[Stephan Bergmann (via logerrit)]

 cui/Library_cui.mk|2 
 cui/source/dialogs/AdditionsDialog.cxx|  130 --
 cui/source/inc/AdditionsDialog.hxx|4 
 include/unotools/ucbstreamhelper.hxx  |2 
 unotools/source/ucbhelper/ucbstreamhelper.cxx |5 +
 vcl/source/graphic/GraphicLoader.cxx  |1 
 6 files changed, 53 insertions(+), 91 deletions(-)

New commits:
commit db6c7a486395304f38e9ea52951f576f34749cbc
Author: Stephan Bergmann 
AuthorDate: Wed Oct 28 13:25:25 2020 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Oct 28 19:15:28 2020 +0100

Use UCB instead of cURL to download https files

Since 7dc6fc32eb618da6defb8a9f330978fa019677b8 "uitest: Check the more icons
dialog opens" started to test the AdditionsDialog code, some ASan builds 
started
to report use-after-poison from within SearchAndParseThread::execute ->
curlGet -> curl_easy_perform -> ... -> https_connecting -> ... ->
secmod_ModuleInit -> pemC_Initialize -> ..., see the comments starting at
 "tdf#133026: Tight
integration of extensions - Adding thread structure".

The exact cause for that ASan use-after-poison is not quite clear to me.  
First,
I thought it was due to liberal use of curl_easy_init (without a central
curl_global_init) in a multi-threaded process; see
 for this being 
considered
"lethal".  But then, another issue could be that most of the nss libraries 
like
instdir/program/libnss3.so (implementing the "... -> secmod_ModuleInit" 
part)
come from LO's bundled --without-system-nss while /lib64/libnsspem.so
(implementing the "pemC_Initialize -> ..." part) comes from the system, and
there could be some mismatch when mixing these (esp. if the former are built
with ASan).

So whatever the actual cause, the right fix should be to use LO's UCB 
instead of
directly calling into cURL anyway.

That required a version of utl::UcbStreamHelper::CreateStream that uses a 
given
XInteractionHandler (which may be null to indicate no interaction handling,
instead reporting all interaction requests as exceptions) instead of 
internally
creating an XInteractionHandler using the GUI, and which would cause 
deadlock
in 7dc6fc32eb618da6defb8a9f330978fa019677b8's UITest_sw_options.  (And
introducing that additional utl::UcbStreamHelper::CreateStream overload 
required
css::awt::XWindow to be a complete type now in
vcl/source/graphic/GraphicLoader.cxx, for

> include/com/sun/star/uno/Reference.h:277:18: note: in instantiation of 
variable template specialization 
'std::is_base_of_v' requested here
> std::is_base_of_v
>  ^

)

(The removed code in cui/source/dialogs/AdditionsDialog.cxx should have 
been the
last remaining use of curl in Library_cui.  Apparently,
e1e9e2aa16f08a8fd9e38db706d63e8eceeda8d1 "Kill Mozilla personas" had 
forgotten
to remove it from cui/Library_cui.mk the last time Library_cui had become
curl-free, before the introduction of the AdditionsDialog code.)

(I did not remove the #undef ABSOLUTE FIXME from
cui/source/dialogs/AdditionsDialog.cxx.
c4bee547b02fbe3d07b1e9ee203c73e48f86e6bf "tdf#133026: Additions: Better 
Search
Function" does not tell whether it had been added to mitigate a macro 
definition
from the (now removed) #include .)

Change-Id: I1fec7488d36df81c3543d12d97da1291f77712fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104938
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/cui/Library_cui.mk b/cui/Library_cui.mk
index 1d1f0feb9ea8..ff221a9cc55a 100644
--- a/cui/Library_cui.mk
+++ b/cui/Library_cui.mk
@@ -68,8 +68,6 @@ $(eval $(call gb_Library_use_externals,cui,\
boost_headers \
$(call gb_Helper_optional,OPENCL,\
clew) \
-$(call gb_Helper_optional,DESKTOP,\
-   curl) \
 icuuc \
 icu_headers \
 libxml2 \
diff --git a/cui/source/dialogs/AdditionsDialog.cxx 
b/cui/source/dialogs/AdditionsDialog.cxx
index dd994839681a..39f841d03996 100644
--- a/cui/source/dialogs/AdditionsDialog.cxx
+++ b/cui/source/dialogs/AdditionsDialog.cxx
@@ -15,6 +15,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -30,7 +31,7 @@
 #include 
 #include 
 #include 
-
+#include 
 #include 
 
 #include 
@@ -40,8 +41,6 @@
 
 #include 
 
-//cURL
-#include 
 #include 
 #include 
 #include 
@@ -70,97 +69,54 @@ using namespace ::com::sun::star::uno;
 using namespace ::com::sun::star::ucb;
 using namespace ::com::sun::star::beans;
 
-#ifdef UNX
-const char kUserAgent[] = "LibreOffice AdditionsDownloader/1.0 (Linux)";
-#else
-const char kUserAgent[] = "LibreOffice AdditionsDownloader/1.0 

[Libreoffice-bugs] [Bug 105967] Tracked edits to line/paragraph breaks not formatted according to inserted/deleted status

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105967

László Németh  changed:

   What|Removed |Added

   Assignee|nem...@numbertext.org   |libreoffice-b...@lists.free
   ||desktop.org
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137833] Image appears rotated when loaded in latest LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137833

--- Comment #1 from Rhys Young  ---
Created attachment 166816
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166816=edit
Image appearing rotated

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83946] [META] Tracking changes issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83946
Bug 83946 depends on bug 105967, which changed state.

Bug 105967 Summary: Tracked edits to line/paragraph breaks not formatted 
according to inserted/deleted status
https://bugs.documentfoundation.org/show_bug.cgi?id=105967

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137833] New: Image appears rotated when loaded in latest LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137833

Bug ID: 137833
   Summary: Image appears rotated when loaded in latest LO
   Product: LibreOffice
   Version: 7.0.3.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rhys.yo...@d2l.com

Description:
Image appears rotated when loaded in latest LO. It appears rotated by 90
degrees instead of being upright

Steps to Reproduce:
1. Download attached image
2. Open file in latest libre office
3. View rotated images

Actual Results:
Should have image appear upright.

Expected Results:
Image appears rotated to the left.


Reproducible: Always


User Profile Reset: No



Additional Info:
N/A

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[László Németh (via logerrit)]

 sw/source/core/text/itrpaint.cxx |3 ++-
 sw/source/core/text/porlay.cxx   |   12 +++-
 sw/source/core/text/porlay.hxx   |6 ++
 sw/source/core/text/porrst.cxx   |6 +-
 sw/source/core/text/porrst.hxx   |5 -
 sw/source/core/text/redlnitr.cxx |   10 +++---
 sw/source/core/text/redlnitr.hxx |2 +-
 7 files changed, 36 insertions(+), 8 deletions(-)

New commits:
commit 350dbba44ee7703b1da11cc4732a5090ce5efe3d
Author: László Németh 
AuthorDate: Wed Oct 28 12:35:51 2020 +0100
Commit: László Németh 
CommitDate: Wed Oct 28 19:13:05 2020 +0100

tdf#105967 sw change tracking: fix pilcrow symbol

formatting according to the tracked insertion or
deletion of the paragraph break. There was no
formatting at all or only (often bad) inheritance
of the character style (strike out or underline)
of the previous character, confusing the user.

Note: because the pilcrow symbol is painted by
the temporary text portion SwTmpEndPortion, see
sw/qa/extras/layout/data/tdf42748.fodt for testing.

Change-Id: I8afef01c515b8abd368cae12d3a02cabf6d897f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104933
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/sw/source/core/text/itrpaint.cxx b/sw/source/core/text/itrpaint.cxx
index 6c3e7a2e4eeb..b00507c907c8 100644
--- a/sw/source/core/text/itrpaint.cxx
+++ b/sw/source/core/text/itrpaint.cxx
@@ -427,7 +427,8 @@ void SwTextPainter::DrawTextLine( const SwRect , 
SwSaveClip ,
 GetInfo().GetOpt().IsParagraph() && !GetTextFrame()->GetFollow() &&
 GetInfo().GetIdx() >= 
TextFrameIndex(GetInfo().GetText().getLength()))
 {
-const SwTmpEndPortion aEnd( *pEndTempl );
+const SwTmpEndPortion aEnd( *pEndTempl, m_pCurr->HasRedlineEnd(),
+   m_pCurr->HasRedlineEndDel() );
 GetFnt()->ChgPhysFnt( GetInfo().GetVsh(), *pOut );
 
 if ( bAdjustBaseLine )
diff --git a/sw/source/core/text/porlay.cxx b/sw/source/core/text/porlay.cxx
index bb3fb103260f..69a7c39b5dc2 100644
--- a/sw/source/core/text/porlay.cxx
+++ b/sw/source/core/text/porlay.cxx
@@ -605,10 +605,19 @@ void SwLineLayout::CalcLine( SwTextFormatter , 
SwTextFormatInfo  )
 if( bHasRedline )
 {
 OUString sRedlineText;
+bool bHasRedlineEnd, bHasRedlineEndDel;
 bHasRedline = rLine.GetRedln()->CheckLine(start.first->GetIndex(), 
start.second,
-end.first->GetIndex(), end.second, sRedlineText );
+end.first->GetIndex(), end.second, sRedlineText, bHasRedlineEnd, 
bHasRedlineEndDel );
 if( bHasRedline )
+{
 SetRedlineText( sRedlineText );
+if( bHasRedlineEnd )
+{
+SetRedlineEnd( bHasRedlineEnd );
+if( bHasRedlineEndDel )
+SetRedlineEndDel( bHasRedlineEndDel );
+}
+}
 }
 SetRedline( bHasRedline );
 }
@@ -670,6 +679,7 @@ void SwLineLayout::ResetFlags()
 {
 m_bFormatAdj = m_bDummy = m_bEndHyph = m_bMidHyph = m_bFly
 = m_bRest = m_bBlinking = m_bClipping = m_bContent = m_bRedline
+= m_bRedlineEnd = m_bRedlineEndDel
 = m_bForcedLeftMargin = m_bHanging = false;
 }
 
diff --git a/sw/source/core/text/porlay.hxx b/sw/source/core/text/porlay.hxx
index 255337d583c1..39e50d28ba94 100644
--- a/sw/source/core/text/porlay.hxx
+++ b/sw/source/core/text/porlay.hxx
@@ -93,6 +93,8 @@ private:
 bool m_bClipping  : 1; // Clipping needed for exact line height
 bool m_bContent   : 1; // Text for line numbering
 bool m_bRedline   : 1; // The Redlining
+bool m_bRedlineEnd: 1; // Redlining for paragraph mark: tracked change at 
the end
+bool m_bRedlineEndDel : 1; // Redlining for paragraph mark: tracked 
deletion at the end
 bool m_bForcedLeftMargin : 1; // Left adjustment moved by the Fly
 bool m_bHanging : 1; // Contains a hanging portion in the margin
 bool m_bUnderscore : 1;
@@ -130,6 +132,10 @@ public:
 bool HasContent() const { return m_bContent; }
 void SetRedline( const bool bNew ) { m_bRedline = bNew; }
 bool HasRedline() const { return m_bRedline; }
+void SetRedlineEnd( const bool bNew ) { m_bRedlineEnd = bNew; }
+bool HasRedlineEnd() const { return m_bRedlineEnd; }
+void SetRedlineEndDel( const bool bNew ) { m_bRedlineEndDel = bNew; }
+bool HasRedlineEndDel() const { return m_bRedlineEndDel; }
 void SetRedlineText ( const OUString& sText ) { m_sRedlineText = sText; }
 const OUString* GetRedlineText() const { return _sRedlineText; }
 void SetForcedLeftMargin() { m_bForcedLeftMargin = true; }
diff --git a/sw/source/core/text/porrst.cxx b/sw/source/core/text/porrst.cxx
index a304958613a7..58cf0cf3f3e3 100644
--- a/sw/source/core/text/porrst.cxx
+++ b/sw/source/core/text/porrst.cxx
@@ -46,7 +46,9 @@
 
 #include 
 
-SwTmpEndPortion::SwTmpEndPortion( const SwLinePortion  )

[Libreoffice-commits] core.git: sw/qa sw/source

[Attila Bakos (NISZ) (via logerrit)]

 sw/qa/extras/uiwriter/data3/txbx_crash.odt |binary
 sw/qa/extras/uiwriter/uiwriter3.cxx|   31 +
 sw/source/core/doc/textboxhelper.cxx   |7 +-
 3 files changed, 37 insertions(+), 1 deletion(-)

New commits:
commit 056933bc55608d0ca061539ae124d7b9386cdb62
Author: Attila Bakos (NISZ) 
AuthorDate: Thu Oct 15 16:45:15 2020 +0200
Commit: László Németh 
CommitDate: Wed Oct 28 19:09:50 2020 +0100

tdf#137802 sw: fix crash on deleting last paragraph

if the last paragraph of document had a text box
anchored to.

Change-Id: Ibe29a0f37d06223c31f3add0c194e4414f65d5ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104379
Tested-by: László Németh 
Reviewed-by: László Németh 

diff --git a/sw/qa/extras/uiwriter/data3/txbx_crash.odt 
b/sw/qa/extras/uiwriter/data3/txbx_crash.odt
new file mode 100755
index ..0a029da88289
Binary files /dev/null and b/sw/qa/extras/uiwriter/data3/txbx_crash.odt differ
diff --git a/sw/qa/extras/uiwriter/uiwriter3.cxx 
b/sw/qa/extras/uiwriter/uiwriter3.cxx
index a19ceff4c6b2..477652a6369e 100644
--- a/sw/qa/extras/uiwriter/uiwriter3.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter3.cxx
@@ -1391,6 +1391,37 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf121031)
 assertXPath(pXmlDoc, "/root/page[1]/body/tab", 1);
 }
 
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, TestTextBoxCrashAfterLineDel)
+{
+// Open the desired file
+load(DATA_DIRECTORY, "txbx_crash.odt");
+SwXTextDocument* pTextDoc = 
dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+
+// Get the Writer shell
+SwWrtShell* pWrtSh = pTextDoc->GetDocShell()->GetWrtShell();
+CPPUNIT_ASSERT(pWrtSh);
+
+// Get the format of the shape
+const SwFrameFormats& rFrmFormats = 
*pWrtSh->GetDoc()->GetSpzFrameFormats();
+CPPUNIT_ASSERT(rFrmFormats.size() >= size_t(o3tl::make_unsigned(1)));
+SwFrameFormat* pShape = rFrmFormats.front();
+CPPUNIT_ASSERT(pShape);
+
+// Add a textbox
+SwTextBoxHelper::create(pShape);
+SwFrameFormat* pTxBxFrm = 
SwTextBoxHelper::getOtherTextBoxFormat(getShape(1));
+CPPUNIT_ASSERT(pTxBxFrm);
+
+// remove the last paragraph
+auto xCursor = getParagraph(1)->getText()->createTextCursor();
+xCursor->gotoEnd(false);
+xCursor->goLeft(3, true);
+
+// This caused crash before, now it should pass with the patch.
+xCursor->setString(OUString());
+}
+
 CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, testTdf96067)
 {
 mxComponent = loadFromDesktop("private:factory/swriter", 
"com.sun.star.text.TextDocument");
diff --git a/sw/source/core/doc/textboxhelper.cxx 
b/sw/source/core/doc/textboxhelper.cxx
index 94f43c61af02..e5b7f82dc94b 100644
--- a/sw/source/core/doc/textboxhelper.cxx
+++ b/sw/source/core/doc/textboxhelper.cxx
@@ -73,7 +73,12 @@ void SwTextBoxHelper::create(SwFrameFormat* pShape)
 }
 catch (uno::Exception&)
 {
-xTextContentAppend->appendTextContent(xTextFrame, 
uno::Sequence());
+// Before the textframe was appended now it is inserted to the begin 
of the doc in order
+// to prevent crash when someone removes the para where the textframe 
anchored:
+uno::Reference xCursor = 
xTextDocument->getText()->createTextCursor();
+xCursor->gotoStart(false);
+xTextContentAppend->insertTextContentWithProperties(
+xTextFrame, uno::Sequence(), 
xCursor->getStart());
 }
 // Link FLY and DRAW formats, so it becomes a text box (needed for 
syncProperty calls).
 uno::Reference xRealTextFrame(xTextFrame, 
uno::UNO_QUERY);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 137802] CRASH When deleting shape+textframe anchored to page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137802

--- Comment #1 from Commit Notification 
 ---
Attila Bakos (NISZ) committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/056933bc55608d0ca061539ae124d7b9386cdb62

tdf#137802 sw: fix crash on deleting last paragraph

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137802] CRASH When deleting shape+textframe anchored to page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137802

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svtools officecfg/registry svtools/source

[Bryan Gazali (via logerrit)]

 include/svtools/strings.hrc|6 +-
 officecfg/registry/data/org/openoffice/Office/Common.xcu   |3 +
 officecfg/registry/schema/org/openoffice/Office/Common.xcs |5 ++
 svtools/source/java/javainteractionhandler.cxx |   28 +++--
 4 files changed, 27 insertions(+), 15 deletions(-)

New commits:
commit 2048a5afc9b1c6340cea594c4ead75914b358e74
Author: Bryan Gazali 
AuthorDate: Sat Oct 3 01:46:48 2020 -0400
Commit: Mike Kaganski 
CommitDate: Wed Oct 28 19:08:05 2020 +0100

tdf#125379 updated javainteractionhandler.cxx to add a link for the JRE 
missing warning

Change-Id: Iac940b24a9fbe914af46fe928b758ad962d3d3e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103881
Reviewed-by: Mike Kaganski 
Tested-by: Mike Kaganski 

diff --git a/include/svtools/strings.hrc b/include/svtools/strings.hrc
index c8b84f0e53a4..e07a94f6aa2b 100644
--- a/include/svtools/strings.hrc
+++ b/include/svtools/strings.hrc
@@ -261,9 +261,9 @@
 
 #define STR_SVT_DEFAULT_SERVICE_LABEL   
NC_("STR_SVT_DEFAULT_SERVICE_LABEL", "$user$'s $service$")
 
-#define STR_WARNING_JAVANOTFOUND
NC_("STR_WARNING_JAVANOTFOUND", "%PRODUCTNAME requires a Java runtime 
environment (JRE) to perform this task. Please install a JRE and restart 
%PRODUCTNAME.")
-#define STR_WARNING_JAVANOTFOUND_WIN
NC_("STR_WARNING_JAVANOTFOUND_WIN", "%PRODUCTNAME requires a %BITNESS-bit Java 
runtime environment (JRE) to perform this task. Please install a JRE and 
restart %PRODUCTNAME.")
-#define STR_WARNING_JAVANOTFOUND_MAC
NC_("STR_WARNING_JAVANOTFOUND_MAC", "%PRODUCTNAME requires Oracle's Java 
Development Kit (JDK) on macOS 10.10 or greater to perform this task. Please 
install them and restart %PRODUCTNAME.")
+#define STR_WARNING_JAVANOTFOUND
NC_("STR_WARNING_JAVANOTFOUND", "%PRODUCTNAME requires a Java runtime 
environment (JRE) to perform this task. Please install a JRE and restart 
%PRODUCTNAME. %FAQLINK")
+#define STR_WARNING_JAVANOTFOUND_WIN
NC_("STR_WARNING_JAVANOTFOUND_WIN", "%PRODUCTNAME requires a %BITNESS-bit Java 
runtime environment (JRE) to perform this task. Please install a JRE and 
restart %PRODUCTNAME. %FAQLINK")
+#define STR_WARNING_JAVANOTFOUND_MAC
NC_("STR_WARNING_JAVANOTFOUND_MAC", "%PRODUCTNAME requires Oracle's Java 
Development Kit (JDK) on macOS 10.10 or greater to perform this task. Please 
install them and restart %PRODUCTNAME. %FAQLINK")
 #define STR_WARNING_INVALIDJAVASETTINGS_MAC 
NC_("STR_WARNING_INVALIDJAVASETTINGS_MAC", "The %PRODUCTNAME configuration has 
been changed. Under %PRODUCTNAME - Preferences - %PRODUCTNAME - Advanced, 
select the Java runtime environment you want to have used by %PRODUCTNAME.")
 #define STR_WARNING_INVALIDJAVASETTINGS 
NC_("STR_WARNING_INVALIDJAVASETTINGS", "The %PRODUCTNAME configuration has been 
changed. Under Tools - Options - %PRODUCTNAME - Advanced, select the Java 
runtime environment you want to have used by %PRODUCTNAME.")
 #define STR_ERROR_JVMCREATIONFAILED_MAC 
NC_("STR_ERROR_JVMCREATIONFAILED_MAC", "%PRODUCTNAME requires a Java runtime 
environment (JRE) to perform this task. The selected JRE is defective. Please 
select another version or install a new JRE and select it under %PRODUCTNAME - 
Preferences - %PRODUCTNAME - Advanced.")
diff --git a/officecfg/registry/data/org/openoffice/Office/Common.xcu 
b/officecfg/registry/data/org/openoffice/Office/Common.xcu
index 2ae05c749fc6..e4c3fca51f7e 100644
--- a/officecfg/registry/data/org/openoffice/Office/Common.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Common.xcu
@@ -376,6 +376,9 @@
 
   https://hub.libreoffice.org/ReleaseNotes/
 
+
+  https://hub.libreoffice.org/InstallJava/
+
   
   
 
diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
index f0420ec158cd..02e62d950ed2 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
@@ -2131,6 +2131,11 @@
   Specifies the URL used with the UNO command WhatsNew 
(SID_WHATSNEW).
 
   
+  
+
+  Specifies the URL used for Install Java message box.
+
+  
 
 
   
diff --git a/svtools/source/java/javainteractionhandler.cxx 
b/svtools/source/java/javainteractionhandler.cxx
index e484eb56a0ac..ce360463b6dc 100644
--- a/svtools/source/java/javainteractionhandler.cxx
+++ b/svtools/source/java/javainteractionhandler.cxx
@@ -34,6 +34,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 
 using namespace com::sun::star::uno;
 using namespace com::sun::star::task;
@@ -126,23 +128,25 @@ void SAL_CALL JavaInteractionHandler::handle( const 
Reference< XInteractionReque
 if( !g_JavaEvents.bNotFoundHandled )
 {
// No suitable 

[Libreoffice-bugs] [Bug 137831] 7.1 apparently deprecated the ability to tint pictures in LO Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137831

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Jan-Marek Glogowski  ---
The duplicate bug claims there is some toolbar for it.

*** This bug has been marked as a duplicate of bug 137014 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137014] Sidebar: Image section remove red/green/blue/gamma widget

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137014

Jan-Marek Glogowski  changed:

   What|Removed |Added

 CC||mwtjunkm...@gmail.com

--- Comment #3 from Jan-Marek Glogowski  ---
*** Bug 137831 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137832] New: LibreOffice Calc Macro - Fail to record

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137832

Bug ID: 137832
   Summary: LibreOffice Calc Macro - Fail to record
   Product: LibreOffice
   Version: 6.4.6.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jamiec1...@yahoo.com

Description:
Using Libreoffice > Calc and then I choose Tools > Macros > Organize Macros >
Basic and then press the NEW button I get and Error dialog box with the words
"Basic syntax error. Expected: Sub" and an OK button

The macro failed to record


Steps to Reproduce:
1. Start Calc
2. Choose Tools > Macros > Organize Macros > Basic
3. Press New
4. Receive error dialog box "Basic syntax error. Expected: Sub"

Actual Results:
Macro editor appears

Expected Results:
The ability to record a macro


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.6.2 (x64) CPU threads: 4; OS: Windows 10.0 Build 18363; UI render:
default; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - 43 commits - sw/inc sw/qa sw/source

[Xisco Fauli (via logerrit)]

 sw/inc/node.hxx |2 
 sw/inc/undobj.hxx   |6 
 sw/qa/extras/uiwriter/data/tdf132160.odt|binary
 sw/qa/extras/uiwriter/data/tdf132911.odt|binary
 sw/qa/extras/uiwriter/data/tdf133967.odt|binary
 sw/qa/extras/uiwriter/data/tdf133982.docx   |binary
 sw/qa/extras/uiwriter/data/tdf133990.odt|binary
 sw/qa/extras/uiwriter/data/tdf134021.docx   |binary
 sw/qa/extras/uiwriter/data/tdf134250.fodt   |   86 ++
 sw/qa/extras/uiwriter/data/tdf134252.fodt   |   95 ++
 sw/qa/extras/uiwriter/data/tdf134436.fodt   |   83 ++
 sw/qa/extras/uiwriter/data/tdf134931.odt|binary
 sw/qa/extras/uiwriter/data/tdf135056.odt|binary
 sw/qa/extras/uiwriter/data/tdf136453.fodt   |   66 +
 sw/qa/extras/uiwriter/data2/try2.fodt   |   66 +
 sw/qa/extras/uiwriter/uiwriter.cxx  |  655 
 sw/qa/extras/uiwriter/uiwriter2.cxx |   97 ++
 sw/qa/uitest/writer_tests/data/tdf135018.odt|binary
 sw/qa/uitest/writer_tests/trackedChanges.py |   36 
 sw/source/core/doc/DocumentContentOperationsManager.cxx |   43 -
 sw/source/core/doc/DocumentRedlineManager.cxx   |  268 --
 sw/source/core/docnode/ndsect.cxx   |8 
 sw/source/core/docnode/nodes.cxx|   13 
 sw/source/core/edit/eddel.cxx   |   12 
 sw/source/core/edit/edglss.cxx  |7 
 sw/source/core/layout/colfrm.cxx|3 
 sw/source/core/layout/frmtool.cxx   |9 
 sw/source/core/layout/tabfrm.cxx|1 
 sw/source/core/layout/trvlfrm.cxx   |   61 -
 sw/source/core/text/redlnitr.cxx|2 
 sw/source/core/text/txtfrm.cxx  |6 
 sw/source/core/txtnode/ndtxt.cxx|   31 
 sw/source/core/undo/unattr.cxx  |5 
 sw/source/core/undo/undel.cxx   |   38 
 sw/source/core/undo/untblk.cxx  |   38 
 sw/source/uibase/wrtsh/wrtsh1.cxx   |4 
 36 files changed, 1551 insertions(+), 190 deletions(-)

New commits:
commit 3270dbc15af87f9b8bdc62bba832ec2a5420d431
Author: Xisco Fauli 
AuthorDate: Tue Sep 1 17:30:44 2020 +0200
Commit: Michael Stahl 
CommitDate: Wed Oct 28 16:45:03 2020 +0100

tdf#135018: sw: Add UItest

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101883
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 
(cherry picked from commit b6ab2330d97672936edc56de8d6f5b6f772908ff)

Change-Id: Ia88e28b1569ea69df81d905cb76a6791a887ef3f

diff --git a/sw/qa/uitest/writer_tests/data/tdf135018.odt 
b/sw/qa/uitest/writer_tests/data/tdf135018.odt
new file mode 100644
index ..2dc9e2a4da0d
Binary files /dev/null and b/sw/qa/uitest/writer_tests/data/tdf135018.odt differ
diff --git a/sw/qa/uitest/writer_tests/trackedChanges.py 
b/sw/qa/uitest/writer_tests/trackedChanges.py
index 5bc8fecf7b03..274d65d99294 100644
--- a/sw/qa/uitest/writer_tests/trackedChanges.py
+++ b/sw/qa/uitest/writer_tests/trackedChanges.py
@@ -7,9 +7,13 @@
 
 from uitest.framework import UITestCase
 from uitest.debug import sleep
+from uitest.path import get_srcdir_url
 import time
 from uitest.uihelper.common import get_state_as_dict, type_text
 
+def get_url_for_data_file(file_name):
+   return get_srcdir_url() + "/sw/qa/uitest/writer_tests/data/" + file_name
+
 class trackedchanges(UITestCase):
 
 def test_tdf91270(self):
@@ -151,4 +155,36 @@ class trackedchanges(UITestCase):
 self.assertEqual(document.Text.String[0:30], "Test LibreOffice Test2 
Test4")
 
 self.ui_test.close_doc()
+
+def test_tdf135018(self):
+self.ui_test.load_file(get_url_for_data_file("tdf135018.odt"))
+xWriterDoc = self.xUITest.getTopFocusWindow()
+xWriterEdit = xWriterDoc.getChild("writer_edit")
+document = self.ui_test.get_component()
+
+#self.assertEqual(5, document.CurrentController.PageCount)
+
+
self.ui_test.execute_modeless_dialog_through_command(".uno:AcceptTrackedChanges")
+xTrackDlg = self.xUITest.getTopFocusWindow()
+changesList = xTrackDlg.getChild("changes")
+self.assertEqual(147, len(changesList.getChildren()))
+
+# Without the fix in place, it would have crashed here
+xAccBtn = xTrackDlg.getChild("acceptall")
+xAccBtn.executeAction("CLICK", tuple())
+
+self.assertEqual(0, len(changesList.getChildren()))
+
+xUndoBtn = xTrackDlg.getChild("undo")
+xUndoBtn.executeAction("CLICK", tuple())
+
+self.assertEqual(147, len(changesList.getChildren()))
+
+xcloseBtn = 

[Libreoffice-bugs] [Bug 137724] Can't find Tools -> Options -> LibreOffice Basic

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137724

sdc.bla...@youmail.dk changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |sdc.bla...@youmail.dk
   |desktop.org |

--- Comment #3 from sdc.bla...@youmail.dk ---
Just in case you have not already solved the problem:
Try:  Tools > Macros > Edit Macros.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137831] 7.1 apparently deprecated the ability to tint pictures in LO Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137831

--- Comment #2 from mwtjunkm...@gmail.com ---
Created attachment 166815
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166815=edit
7.1 with no RGB filters, cannot tint photo

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137831] 7.1 apparently deprecated the ability to tint pictures in LO Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137831

mwtjunkm...@gmail.com changed:

   What|Removed |Added

 CC||mwtjunkm...@gmail.com

--- Comment #1 from mwtjunkm...@gmail.com ---
Created attachment 166814
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166814=edit
7.0.3 with RGB sliders to tint a photo

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc vcl/unx

[Thorsten Behrens (via logerrit)]

 vcl/inc/unx/gtk/gtkframe.hxx  |2 +-
 vcl/unx/gtk3/gtk3gtkframe.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 9350b162c3432ca3f160ce6b86cc50a00eb7de0a
Author: Thorsten Behrens 
AuthorDate: Wed Oct 28 14:19:59 2020 +0100
Commit: Thorsten Behrens 
CommitDate: Wed Oct 28 18:44:54 2020 +0100

Fix build for UNX x86

Change-Id: I971aa787a33fa3a6bd9913abb94c90ddf53109cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104937
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx
index ad67070f2b0c..d8d2d0d2e834 100644
--- a/vcl/inc/unx/gtk/gtkframe.hxx
+++ b/vcl/inc/unx/gtk/gtkframe.hxx
@@ -528,7 +528,7 @@ public:
 static gboolean NativeWidgetHelpPressed(GtkAccelGroup*, 
GObject*, guint,
 GdkModifierType, gpointer pFrame);
 static OUString GetPreeditDetails(GtkIMContext* pIMContext, 
std::vector& rInputFlags, sal_Int32& rCursorPos, sal_uInt8& 
rCursorFlags);
-static SelectionCalcDeleteSurroundingSelection(const OUString& 
rSurroundingText, int nCursorIndex, int nOffset, int nChars);
+static SelectionCalcDeleteSurroundingSelection(const OUString& 
rSurroundingText, sal_Int32 nCursorIndex, int nOffset, int nChars);
 
 void DisallowCycleFocusOut();
 bool IsCycleFocusOutDisallowed() const;
diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx
index 8c62814bc183..c540105d03f0 100644
--- a/vcl/unx/gtk3/gtk3gtkframe.cxx
+++ b/vcl/unx/gtk3/gtk3gtkframe.cxx
@@ -4377,7 +4377,7 @@ gboolean 
GtkSalFrame::IMHandler::signalIMRetrieveSurrounding( GtkIMContext* pCon
 return true;
 }
 
-Selection GtkSalFrame::CalcDeleteSurroundingSelection(const OUString& 
rSurroundingText, int nCursorIndex, int nOffset, int nChars)
+Selection GtkSalFrame::CalcDeleteSurroundingSelection(const OUString& 
rSurroundingText, sal_Int32 nCursorIndex, int nOffset, int nChars)
 {
 Selection aInvalid(SAL_MAX_UINT32, SAL_MAX_UINT32);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 137831] New: 7.1 apparently deprecated the ability to tint pictures in LO Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137831

Bug ID: 137831
   Summary: 7.1 apparently deprecated the ability to tint pictures
in LO Draw
   Product: LibreOffice
   Version: 7.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mwtjunkm...@gmail.com

Description:
Prior to 7.1, I could set the color mode to gray scale on a photo and then
alter the RGB values to produce a tinted photo. I see no such feature in 7.1
for that.

Steps to Reproduce:
1. Launch LO Draw
2. Drag a picture onto a page
3. Change the picture's Color Mode to grayscale
4.  no RGB values to tint it with

Actual Results:
cannot tint photo

Expected Results:
tint photo


Reproducible: Always


User Profile Reset: No



Additional Info:
Worked previously using: 

Version: 7.0.3.1 (x64)
Build ID: d7547858d014d4cf69878db179d326fc3483e082
CPU threads: 8; OS: Windows 10.0 Build 20241; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Does not work using:

Version: 7.1.0.0.alpha1+ (x64)
Build ID: a4d4ed86991e2901ac86189e95966d4e99be4944
CPU threads: 8; OS: Windows 10.0 Build 20241; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Information regarding Contribution

[Jan-Marek Glogowski]

Hi,

Am 28.10.20 um 06:37 schrieb Raghav Khanna:
I am a computer enthusiast who is highly interested in Contributing to 
LibreOffice.
Please Guide me how I can start doing so. I have learnt C++ in my School 
and have been learning some python lately. I have made some websites in 
the past too( just for fun ), so I know some Javascript too.I am open to 
learn anything and everything and that too quickly as I'm highly 
interested in Computers.

Please Guide me so that I can Contribute to the Community.


Please have a look at 
https://wiki.documentfoundation.org/Development/GetInvolved


HTH

Jan-Marek
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 137824] LO allows to insert objects from the kde5 shared buffer only before the first copy from LO.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137824

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #3 from Jan-Marek Glogowski  ---
Please keep the NEEDINFO state, until you have provided the requested
information from comment 2 or can set some RESOLVED state.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137820] Consistent crash when expanding Effect Properties on a photo

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137820

mwtjunkm...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME
 CC||mwtjunkm...@gmail.com

--- Comment #1 from mwtjunkm...@gmail.com ---
Does not occur in the most recent daily build: 2020.10.28

Version: 7.1.0.0.alpha1+ (x64)
Build ID: a4d4ed86991e2901ac86189e95966d4e99be4944
CPU threads: 8; OS: Windows 10.0 Build 20241; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78916] Custom page size missing from print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78916

geronto...@byom.de changed:

   What|Removed |Added

 OS|All |Linux (All)
   Hardware|All |x86-64 (AMD64)

--- Comment #36 from geronto...@byom.de ---
Build ID: 1:6.4.6-0ubuntu0.20.04.1

1. I can use "File" > "New" > "Labels" to create a new label.
2. In "Format" > "Page Style" the values under "Paper Format" change properly
to fit my label type.
3. But afterwards, I *cannot* print the labels, because "File" > "Print..."
does not let me specify custom paper size values anywhere in the dialogue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-6.4-10'

[Andras Timar (via logerrit)]

Tag 'cp-6.4-10' created by Andras Timar  at 
2020-10-28 17:28 +

cp-6.4-10

Changes since cp-6.4-branch-point-11:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-6.4-10'

[Andras Timar (via logerrit)]

Tag 'cp-6.4-10' created by Andras Timar  at 
2020-10-28 17:28 +

cp-6.4-10

Changes since cp-6.4-7:
Andras Timar (1):
  more/better suggestions for Spanish

---
 es/es_ANY.aff |3 +++
 es/es_ANY.dic |   20 ++--
 2 files changed, 13 insertions(+), 10 deletions(-)
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-6.4-10'

[Andras Timar (via logerrit)]

Tag 'cp-6.4-10' created by Andras Timar  at 
2020-10-28 17:28 +

cp-6.4-10

Changes since cp-6.4-9-1:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-6.4-10'

[Andras Timar (via logerrit)]

Tag 'cp-6.4-10' created by Andras Timar  at 
2020-10-28 17:28 +

cp-6.4-10

Changes since cp-6.4-9-12:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - configure.ac

[Andras Timar (via logerrit)]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8d2f2e313e62993baadf899c0a9771292e32dc72
Author: Andras Timar 
AuthorDate: Wed Oct 28 18:27:43 2020 +0100
Commit: Andras Timar 
CommitDate: Wed Oct 28 18:27:43 2020 +0100

Bump version to 6.4-10

Change-Id: I21f9d974380b0fabe1deb8444cd3a28ec8a7b2ba

diff --git a/configure.ac b/configure.ac
index df979d553f87..2beb573652c7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([Collabora Office],[6.4.10.9],[],[],[https://collaboraoffice.com/])
+AC_INIT([Collabora Office],[6.4.10.10],[],[],[https://collaboraoffice.com/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 137830] Implement export/import of Calc sheets into/from text tables

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137830

smntov  changed:

   What|Removed |Added

 CC||smn...@gmail.com

--- Comment #1 from smntov  ---
Created attachment 166813
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166813=edit
A screenshot with a text table...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137830] New: Implement export/import of Calc sheets into/from text tables

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137830

Bug ID: 137830
   Summary: Implement export/import of Calc sheets into/from text
tables
   Product: LibreOffice
   Version: 3.3.0 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: smn...@gmail.com

Description:
Please implement export/import of Calc sheets into/from text tables in plain
text files.

See an example of such tables here:
https://ask.libreoffice.org/en/question/273783/how-to-save-a-sheet-as-a-text-table/

As far as I know only Emacs can create such text tables. It would be nice if LO
would be able to do it as well.

Pandoc's grid_tables extension might be used as a reference:
https://pandoc.org/MANUAL.html


Steps to Reproduce:
1. In Calc: File -> Export as...
2. In Calc: File -> Import as...
3.

Actual Results:
No option "Text table"

Expected Results:
There should be a "Text table" for both - export and import


Reproducible: Always


User Profile Reset: No



Additional Info:
Pandoc's grid_tables extension might be used as a reference:
https://pandoc.org/MANUAL.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - vcl/inc vcl/Library_vcl.mk vcl/qa vcl/source

[Tomaž Vajngerl (via logerrit)]

 vcl/Library_vcl.mk |1 
 vcl/inc/pdf/ExternalPDFStreams.hxx |   65 +
 vcl/inc/pdf/objectcopier.hxx   |3 +
 vcl/qa/cppunit/pdfexport/pdfexport.cxx |2 -
 vcl/source/gdi/pdfobjectcopier.cxx |7 +++
 vcl/source/gdi/pdfwriter_impl.cxx  |   33 
 vcl/source/gdi/pdfwriter_impl.hxx  |   21 --
 vcl/source/pdf/ExternalPDFStreams.cxx  |   43 +
 8 files changed, 151 insertions(+), 24 deletions(-)

New commits:
commit e528293bc17ecce92124e8dd8841bcea2bda562e
Author: Tomaž Vajngerl 
AuthorDate: Wed Oct 28 13:55:23 2020 +0100
Commit: Miklos Vajna 
CommitDate: Wed Oct 28 18:24:24 2020 +0100

pdf: deduplicate resources when copying from external PDF stream

When using external PDF stream/data (from PDF graphic objects),
make sure to copy the content of external PDF resources (fonts,
bitmaps, forms) only one time (by sharing the map between calls)
and every other use, just use the reference to the objects.

Change-Id: Ibaa632c8f74806eb195e69404551db6fd077a986
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104935
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index e9d820806870..9afdac80ef86 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -319,6 +319,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
 vcl/source/gdi/CommonSalLayout \
 vcl/source/gdi/TypeSerializer \
 vcl/source/pdf/PDFiumLibrary \
+vcl/source/pdf/ExternalPDFStreams \
 vcl/source/graphic/GraphicID \
 vcl/source/graphic/GraphicLoader \
 vcl/source/graphic/GraphicObject \
diff --git a/vcl/inc/pdf/ExternalPDFStreams.hxx 
b/vcl/inc/pdf/ExternalPDFStreams.hxx
new file mode 100644
index ..3bd59478c212
--- /dev/null
+++ b/vcl/inc/pdf/ExternalPDFStreams.hxx
@@ -0,0 +1,65 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#pragma once
+
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+
+#include 
+
+namespace vcl
+{
+struct VCL_DLLPUBLIC ExternalPDFStream
+{
+std::vector maData;
+std::shared_ptr mpPDFDocument;
+std::map maCopiedResources;
+
+std::map& getCopiedResources() { return 
maCopiedResources; }
+
+filter::PDFDocument& getPDFDocument()
+{
+if (!mpPDFDocument)
+{
+SvMemoryStream aPDFStream;
+aPDFStream.WriteBytes(maData.data(), maData.size());
+aPDFStream.Seek(0);
+mpPDFDocument = std::make_unique();
+if (!mpPDFDocument->Read(aPDFStream))
+{
+SAL_WARN("vcl.pdfwriter",
+ "PDFWriterImpl::writeReferenceXObject: reading the 
PDF document failed");
+}
+}
+return *mpPDFDocument;
+}
+};
+
+class VCL_DLLPUBLIC ExternalPDFStreams
+{
+private:
+std::map, sal_Int32> maStreamIndexMap;
+std::vector maStreamList;
+
+public:
+ExternalPDFStreams() {}
+
+sal_Int32 store(const sal_uInt8* pData, sal_uInt32 nLength);
+
+ExternalPDFStream& get(sal_uInt32 nIndex);
+};
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/inc/pdf/objectcopier.hxx b/vcl/inc/pdf/objectcopier.hxx
index a6ff12d116af..487d03186682 100644
--- a/vcl/inc/pdf/objectcopier.hxx
+++ b/vcl/inc/pdf/objectcopier.hxx
@@ -48,6 +48,9 @@ public:
 /// Copies resources of pPage into rLine.
 void copyPageResources(filter::PDFObjectElement* pPage, OStringBuffer& 
rLine);
 
+void copyPageResources(filter::PDFObjectElement* pPage, OStringBuffer& 
rLine,
+   std::map& rCopiedResources);
+
 /// Copies page one or more page streams from rContentStreams into rStream.
 static sal_Int32 copyPageStreams(std::vector& 
rContentStreams,
  SvMemoryStream& rStream, bool& 
rCompressed);
diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx 
b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index 190e26cce19b..5f50661b013e 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -2131,7 +2131,7 @@ void PdfExportTest::testMultiPagePDF()
 {   // embedded PDF page 2
 vcl::filter::PDFObjectElement* pXObject2 = 
pXObjects->LookupObject(rIDs[1]);
 CPPUNIT_ASSERT(pXObject2);
-CPPUNIT_ASSERT_EQUAL(OString("Im34"), rIDs[1]);
+CPPUNIT_ASSERT_EQUAL(OString("Im24"), rIDs[1]);
 
 auto pSubtype2 = 
dynamic_cast(pXObject2->Lookup("Subtype"));
 CPPUNIT_ASSERT(pSubtype2);
diff --git a/vcl/source/gdi/pdfobjectcopier.cxx 

[Libreoffice-commits] core.git: sw/source

[Caolán McNamara (via logerrit)]

 sw/source/uibase/docvw/edtwin.cxx |   28 
 sw/source/uibase/inc/edtwin.hxx   |1 +
 2 files changed, 29 insertions(+)

New commits:
commit 1b40a48bdfd1e73dc41394bd914e9ec417458a2d
Author: Caolán McNamara 
AuthorDate: Wed Oct 28 11:50:48 2020 +
Commit: Caolán McNamara 
CommitDate: Wed Oct 28 18:19:59 2020 +0100

tdf#95096 add a DeleteSurroundingText to SwEditWin

Change-Id: I6995a4e0e3a08a9cca26580585cdfe151389321f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104931
Tested-by: Jenkins
Reviewed-by: Justin Luth 
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/uibase/docvw/edtwin.cxx 
b/sw/source/uibase/docvw/edtwin.cxx
index f28599ccf030..f28f7088d798 100644
--- a/sw/source/uibase/docvw/edtwin.cxx
+++ b/sw/source/uibase/docvw/edtwin.cxx
@@ -6481,6 +6481,34 @@ Selection SwEditWin::GetSurroundingTextSelection() const
 }
 }
 
+bool SwEditWin::DeleteSurroundingText(const Selection& rSelection)
+{
+SwWrtShell& rSh = m_rView.GetWrtShell();
+
+if (rSh.HasSelection())
+return false;
+
+// rSelection is relative to the start of the sentence, so find that and
+// adjust the range by it
+SwPosition *pPos = rSh.GetCursor()->GetPoint();
+const sal_Int32 nPos = pPos->nContent.GetIndex();
+
+rSh.HideCursor();
+rSh.GoStartSentence();
+const sal_Int32 nStartPos = 
rSh.GetCursor()->GetPoint()->nContent.GetIndex();
+pPos->nContent = nPos;
+rSh.ClearMark();
+rSh.ShowCursor();
+
+if (rSh.SelectText(nStartPos + rSelection.Min(), nStartPos + 
rSelection.Max()))
+{
+rSh.Delete();
+return true;
+}
+
+return false;
+}
+
 void SwEditWin::LogicInvalidate(const tools::Rectangle* pRectangle)
 {
 OString sRectangle;
diff --git a/sw/source/uibase/inc/edtwin.hxx b/sw/source/uibase/inc/edtwin.hxx
index ec8994cf791e..a74afc85d085 100644
--- a/sw/source/uibase/inc/edtwin.hxx
+++ b/sw/source/uibase/inc/edtwin.hxx
@@ -190,6 +190,7 @@ class SW_DLLPUBLIC SwEditWin final : public vcl::Window,
 
 virtual OUString GetSurroundingText() const override;
 virtual Selection GetSurroundingTextSelection() const override;
+virtual bool DeleteSurroundingText(const Selection& rSelection) override;
 
 void ShowAutoCorrectQuickHelp(const OUString& rWord, SvxAutoCorrect& 
rACorr);
 bool ShowAutoText(const std::vector& rChunkCandidates);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 95096] ibus keyboarding solution - kmfl characters are not "swallowed" for cell in row with "table in table"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95096

--- Comment #19 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1b40a48bdfd1e73dc41394bd914e9ec417458a2d

tdf#95096 add a DeleteSurroundingText to SwEditWin

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95096] ibus keyboarding solution - kmfl characters are not "swallowed" for cell in row with "table in table"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95096

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.1.0 target:5.0.4   |target:5.1.0 target:5.0.4
   ||target:7.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137824] LO allows to insert objects from the kde5 shared buffer only before the first copy from LO.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137824

eric.p.wills  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
Bug 102495 depends on bug 137824, which changed state.

Bug 137824 Summary: LO allows to insert objects from the kde5 shared buffer 
only before the first copy from LO.
https://bugs.documentfoundation.org/show_bug.cgi?id=137824

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137824] LO allows to insert objects from the kde5 shared buffer only before the first copy from LO.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137824

eric.p.wills  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
Bug 102495 depends on bug 137824, which changed state.

Bug 137824 Summary: LO allows to insert objects from the kde5 shared buffer 
only before the first copy from LO.
https://bugs.documentfoundation.org/show_bug.cgi?id=137824

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135533] LibreOffice 7.0.0.3 - Stops Accepting Keystrokes after a few minutes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135533

Milston B.  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME
 CC||mils...@live.de

--- Comment #1 from Milston B.  ---
Can't confirm this behaviour on Windows or Linux.


Windows
 Version: 7.0.1.2 (x86)
 Build ID: 7cbcfc562f6eb6708b5ff7d7397325de9e764452
 CPU threads: 4; OS: Windows 10.0 Build 17763; UI render: Skia/Raster; VCL:
win
 Locale: de-DE (de_DE); UI: de-DE

Linux
 Version: 7.0.1.2 (x86)
 Build ID: 7cbcfc562f6eb6708b5ff7d7397325de9e764452
 CPU threads: 4; OS: Windows 10.0 Build 17763; UI render: Skia/Raster; VCL:
win
 Locale: de-DE (de_DE); UI: de-DE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137824] LO allows to insert objects from the kde5 shared buffer only before the first copy from LO.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137824

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Blocks||102495
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #2 from Jan-Marek Glogowski  ---
There was a major rewrite of the QClipboard and Drag'n'Drop handling in
LibreOffice 6.3 (see bug 122239), which fixed many problems.

I can't reproduce your problem with current master build.

And LO < 7.0 is out of bugfix support (there might be a security release for
6.4, but no more bugfix releases; see
https://wiki.documentfoundation.org/ReleasePlan/6.4).

So unless you can reproduce this bug with LibreOffice 7.0+, please close it as
RESOLVED with something like WORKSFORME. Otherwise please specify a list of
steps to reproduce it. And copy the content of the "About LibreOffice" dialog.

LO 6.2 with kf5 VCL is definitely known to be "clipboard broken" and "drag and
drop broken" (same code).


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102495
[Bug 102495] [META] KDE VCL backend bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102495

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Depends on||137824


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=137824
[Bug 137824] LO allows to insert objects from the kde5 shared buffer only
before the first copy from LO.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127591] [META] User Interface (UI) related Macro bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127591
Bug 127591 depends on bug 127603, which changed state.

Bug 127603 Summary: "Tools - Macros - Run macro.." help rendering with F1 is 
inconsistent
https://bugs.documentfoundation.org/show_bug.cgi?id=127603

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120201] [META] Update or add link to help page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120201
Bug 120201 depends on bug 127603, which changed state.

Bug 127603 Summary: "Tools - Macros - Run macro.." help rendering with F1 is 
inconsistent
https://bugs.documentfoundation.org/show_bug.cgi?id=127603

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127603] "Tools - Macros - Run macro.." help rendering with F1 is inconsistent

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127603

Alain Romedenne  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113002] LibreOfficeCalc: Pivot Table recurring data field name will added a simple quotation marks before number

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113002

Milston B.  changed:

   What|Removed |Added

 CC||mils...@live.de

--- Comment #13 from Milston B.  ---
Same behaviour in Windows 10



 Version: 7.0.1.2 (x86)
 Build ID: 7cbcfc562f6eb6708b5ff7d7397325de9e764452
 CPU threads: 4; OS: Windows 10.0 Build 17763; UI render: Skia/Raster; VCL:
win
 Locale: de-DE (de_DE); UI: de-DE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130013] XHP Editor rendering (or checking) modifies .xhp source files - are replaced by '&'

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130013

Alain Romedenne  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Alain Romedenne  ---
tested ok

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106040] [META] Help bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106040

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Depends on||137829


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=137829
[Bug 137829] [LOCALHELP] "Outline Level" should be defined in General Glossary
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137829] [LOCALHELP] "Outline Level" should be defined in General Glossary

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137829

sdc.bla...@youmail.dk changed:

   What|Removed |Added

Summary|"Outline Level" should be   |[LOCALHELP] "Outline Level"
   |defined in General Glossary |should be defined in
   ||General Glossary
 Blocks||106040


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106040
[Bug 106040] [META] Help bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137695] GTK3 - Comboboxes and Listboxes are too big for one row in a Tablecontrol

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137695

--- Comment #3 from Milston B.  ---
Today, i was able to test this on the workplace PC:

Same behaviour as in comment #2
Exept: Under Windows you have to set the height of the line to 0.65 cm. It
seems that the height from the combo box differs from OS to OS…



Informations to the PC-Version
 Windows
  Edition  Windows 10 Enterprise
  Version 1809
  Build 17763.1518

 LibreOffice
  Version: 7.0.1.2 (x86)
  Build ID: 7cbcfc562f6eb6708b5ff7d7397325de9e764452
  CPU threads: 4; OS: Windows 10.0 Build 17763; UI render: Skia/Raster;
VCL: win
  Locale: de-DE (de_DE); UI: de-DE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137829] New: "Outline Level" should be defined in General Glossary

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137829

Bug ID: 137829
   Summary: "Outline Level" should be defined in General Glossary
   Product: LibreOffice
   Version: 7.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sdc.bla...@youmail.dk
CC: olivier.hal...@libreoffice.org

Search on the word "outline" in:

https://help.libreoffice.org/7.1/en-US/text/shared/00/0005.html

It would be useful to have a clear explanation about "outline level" in
Libreoffice added to the General Glossary, because many common formatting
operations depend critically on understanding this concept.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Miklos Vajna (via logerrit)]

 sw/source/core/inc/UndoDraw.hxx |1 +
 sw/source/core/undo/undraw.cxx  |   23 +++
 2 files changed, 24 insertions(+)

New commits:
commit 15f2bf415bb25324eaf26ea87ef8b724a090b942
Author: Miklos Vajna 
AuthorDate: Wed Oct 28 12:16:15 2020 +0100
Commit: Miklos Vajna 
CommitDate: Wed Oct 28 17:45:01 2020 +0100

sw: add an xml dumper for SwUndoDrawDelete

Change-Id: I1b06cce99ae0a45b1765d2259d3d14fbb89e6676
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104929
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sw/source/core/inc/UndoDraw.hxx b/sw/source/core/inc/UndoDraw.hxx
index f4117a6fd61e..468db932a476 100644
--- a/sw/source/core/inc/UndoDraw.hxx
+++ b/sw/source/core/inc/UndoDraw.hxx
@@ -127,6 +127,7 @@ public:
 virtual void RedoImpl( ::sw::UndoRedoContext & ) override;
 
 void AddObj( SwDrawFrameFormat*, const SdrMark& );
+void dumpAsXml(xmlTextWriterPtr pWriter) const override;
 };
 
 #endif // INCLUDED_SW_SOURCE_CORE_INC_UNDODRAW_HXX
diff --git a/sw/source/core/undo/undraw.cxx b/sw/source/core/undo/undraw.cxx
index f355d8263df3..9ed78bd680a3 100644
--- a/sw/source/core/undo/undraw.cxx
+++ b/sw/source/core/undo/undraw.cxx
@@ -556,4 +556,27 @@ void SwUndoDrawDelete::AddObj( SwDrawFrameFormat* pFormat,
 m_pMarkList->InsertEntry( rMark );
 }
 
+void SwUndoDrawDelete::dumpAsXml(xmlTextWriterPtr pWriter) const
+{
+xmlTextWriterStartElement(pWriter, BAD_CAST("SwUndoDrawDelete"));
+
+for (size_t i = 0; i < m_pMarkList->GetMarkCount(); ++i)
+{
+SwUndoGroupObjImpl& rObj = m_pObjArray[i];
+xmlTextWriterStartElement(pWriter, BAD_CAST("SwUndoGroupObjImpl"));
+xmlTextWriterWriteAttribute(pWriter, BAD_CAST("index"),
+BAD_CAST(OString::number(i).getStr()));
+
+if (rObj.pFormat)
+{
+xmlTextWriterStartElement(pWriter, BAD_CAST("pFormat"));
+rObj.pFormat->dumpAsXml(pWriter);
+xmlTextWriterEndElement(pWriter);
+}
+xmlTextWriterEndElement(pWriter);
+}
+
+xmlTextWriterEndElement(pWriter);
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108636] [META] Extensive file accesses

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108636
Bug 108636 depends on bug 111338, which changed state.

Bug 111338 Summary: LibO will update the registrymodifications.xcu for every 
color chosen in the color picker (since LibO 5.3)
https://bugs.documentfoundation.org/show_bug.cgi?id=111338

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|WONTFIX |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85184] [META] Color picker toolbar, dialog and sidebar drop-down widget bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85184
Bug 85184 depends on bug 111338, which changed state.

Bug 111338 Summary: LibO will update the registrymodifications.xcu for every 
color chosen in the color picker (since LibO 5.3)
https://bugs.documentfoundation.org/show_bug.cgi?id=111338

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|WONTFIX |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111338] LibO will update the registrymodifications.xcu for every color chosen in the color picker (since LibO 5.3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111338

Buovjaga  changed:

   What|Removed |Added

   Priority|medium  |lowest
 Status|RESOLVED|NEW
 Resolution|WONTFIX |---
 Ever confirmed|0   |1

--- Comment #19 from Buovjaga  ---
Ok then

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 133568] After Changing Default Load/Save File Type while Running Calc Reset or Change to Another File Type Failed to Update in Setting Properly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=133568

Buovjaga  changed:

   What|Removed |Added

 OS|Windows (All)   |All
   Severity|normal  |minor
 Blocks||112724
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from Buovjaga  ---
(In reply to distantlightning from comment #0)
> Steps to Reproduce:
> 1.Import .WK4 file
> 2. Change Options - Always Save As to .HTML (Maybe try several others and
> test first)
> 3. Save or Save As *.HTML
> 4. Change Options Always Save as to any other value and apply.
> 5. Save or Save As default will remain .HTML for files loaded as .WK4 only.
> Note - problem occurs across program reloads, system restart and reinstall.
> Only resetting the user profile fixes it. 

I reproduce with the file.

Step 2 should be Tools - Options - Load/Save - General - Document type:
Spreadsheet

Arch Linux 64-bit
Version: 7.1.0.0.alpha1+
Build ID: 496771a6466d6a48f0bcbd8976df24308e052f38
CPU threads: 8; OS: Linux 5.9; UI render: default; VCL: kf5
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 28 October 2020


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112724
[Bug 112724] [META] Options dialog's Load/Save settings bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112724] [META] Options dialog's Load/Save settings bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112724

Buovjaga  changed:

   What|Removed |Added

 Depends on||133568


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=133568
[Bug 133568] After Changing Default Load/Save File Type while Running Calc
Reset or Change to Another File Type Failed to Update in Setting Properly
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66472] A suggestion for better ergonomics for column, row, and cell actions in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66472

--- Comment #11 from Laurent Lyaudet  ---
(In reply to Heiko Tietze from comment #10)
> (In reply to Laurent Lyaudet from comment #0)
> > Suppose you want to unhide all hidden columns and all hidden rows.
> > You have to click 5 times
> 
> > I propose the X zone to be replaced by the following visual element,
> > split the X zone in 3 parts like this...
> > and make all three zones clickable and right clickable:
> 
> To un/hide all col/rows you select all and right click either row or column
> (two clicks +1). While the separation sounds like a fancy addition it has
> not so much benefit as it just provides the right click on a part of this
> cell (1+1 clicks). And we have to select all anyway to give proper feedback.
> So I'm not objecting the idea but doubt its benefit.

Hello Heiko,

I don't see why your reply censored my explanation.
Here is the missing part :
>You have to click 5 times
>- X zone
>- right click column, click unhide
>- right click row, click unhide
What you propose is 3 clicks for unhiding only rows or only columns.
My proposition enables to unhide both rows and columns at the same time in 2
clicks instead of 5.

Please, consider that ideas of other people may be interesting too.

Best regards,
   Laurent Lyaudet

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Information regarding Contribution

[Raghav Khanna]

Respected Sir/Madam,

I am a computer enthusiast who is highly interested in Contributing to
LibreOffice.
Please Guide me how I can start doing so. I have learnt C++ in my School
and have been learning some python lately. I have made some websites in the
past too( just for fun ), so I know some Javascript too.I am open to learn
anything and everything and that too quickly as I'm highly interested in
Computers.
Please Guide me so that I can Contribute to the Community.

*How I came to know about LibreOffice*?
I have got a chance to use Ubuntu.in my class 11th once. When I used it I
found LibreOffice as an alternative for MS Office.
I've just finished my drop year and I'm ready to go to some good college
this year. After some research I came to know about GSOC and on their
website I saw LibreOffice. I immediately wanted to contribute to such a
great community that has been providing such a great product for free!

Thanks for reading.
Regards,
Raghav Khanna,
A Computer Enthusiast.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 137002] LibreOffice Writer: Spell Checker edits adjacent words even when all corrections

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137002

--- Comment #7 from Buovjaga  ---
(In reply to John from comment #4)
> Created attachment 166672 [details]
> Source file
> 
> I am still having the problem.  I have attached a further (less edited) file
> which shows the problem.  There are separate attachments of PDF file
> produced from the attached file and after spell checker.

No problem for me

Arch Linux 64-bit
Version: 7.0.2.2
Build ID: 00(Build:2)
CPU threads: 8; OS: Linux 5.9; UI render: default; VCL: kf5
Locale: fi-FI (fi_FI.UTF-8); Käyttöliittymä: fi-FI
7.0.2-2
Calc: threaded

Version: 7.1.0.0.alpha1+ (x64)
Build ID: b61bf7c7cfcf97a5ade6d130873af146670bc2ee
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: default; VCL: win
Locale: fi-FI (fi_FI); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137002] LibreOffice Writer: Spell Checker edits adjacent words even when all corrections

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137002

Buovjaga  changed:

   What|Removed |Added

 Attachment #166672|application/xml |application/vnd.openxmlform
  mime type||ats-officedocument.wordproc
   ||essingml.document

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137828] New: Cannot change the font size of strings that contain Japanese.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137828

Bug ID: 137828
   Summary: Cannot change the font size of strings that contain
Japanese.
   Product: LibreOffice
   Version: 6.4.6.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ubi...@gmail.com

Description:
If the character string in the figure or textbox is a mixture of single-byte
characters and multi-byte characters(Japanese), even if you select a figure and
change the font size, only single-byte characters will change the font size.

Steps to Reproduce:
1.Create a shape or textbox.
2.Enter a character string that is a mixture of single-byte characters and
multi-byte characters(Japanese).
3.Select shape/textbox.
4.Change the font size from the sidebar.

Actual Results:
Only single-byte characters font size changed.

Expected Results:
Expected to change the font size of all characters.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
バージョン: 6.4.6.2
Build ID: 1:6.4.6-0ubuntu0.20.04.1
CPU threads: 4; OS:Linux 5.4; UI render: default; VCL: gtk3; 
ロケール: ja-JP (ja_JP.UTF-8); UIの言語: ja-JP
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98868] FILESAVE: crash if try save ODT file with track changes compared

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98868

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98868] FILESAVE: crash if try save ODT file with track changes compared

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98868

--- Comment #27 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/496771a6466d6a48f0bcbd8976df24308e052f38

Related: tdf#98868 split out reusable hunk as function

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137825] Images from docx are moved and jumbled when opened with LibreOffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137825

--- Comment #5 from Telesto  ---
@Jake Weilhammer
Which version of Word did you use.. Document is a mess in many cases (Microsoft
Word Online doesn't render it properly. Used a DOCX to PDF render (also wrong).
DOCX conversion pack made a mess too.

So there must be something with the file in question

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137813] Status bar shows 'SVG selected' while the actual image based on PDF (so PDF selected)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137813

--- Comment #2 from Tomaz Vajngerl  ---
Yeah, SVG is default in the switch, as PDF isn't handled.

I would remove the default and handle all cases. If there is no default in the
switch and we add a new entry into VectorGraphicDataType, then the compiler
will complain with a warning and that's what we want in this case.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Caolán McNamara (via logerrit)]

 sw/source/core/inc/rolbck.hxx  |1 +
 sw/source/core/undo/rolbck.cxx |   27 +--
 2 files changed, 18 insertions(+), 10 deletions(-)

New commits:
commit 496771a6466d6a48f0bcbd8976df24308e052f38
Author: Caolán McNamara 
AuthorDate: Wed Oct 28 10:22:58 2020 +
Commit: Caolán McNamara 
CommitDate: Wed Oct 28 16:54:19 2020 +0100

Related: tdf#98868 split out reusable hunk as function

Change-Id: I7e410ba55f94e87c007acbe1887a022948ef354f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104925
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/core/inc/rolbck.hxx b/sw/source/core/inc/rolbck.hxx
index 295279fd9396..c0506fdf91e6 100644
--- a/sw/source/core/inc/rolbck.hxx
+++ b/sw/source/core/inc/rolbck.hxx
@@ -177,6 +177,7 @@ public:
 virtual void SetInDoc( SwDoc* pDoc, bool bTmpSet ) override;
 bool IsEqual( const SwTOXMark& rCmp ) const;
 
+static SwTOXType* GetSwTOXType(SwDoc& rDoc, TOXTypes eTOXTypes, const 
OUString& rTOXName);
 };
 
 class SwHistoryResetText : public SwHistoryHint
diff --git a/sw/source/core/undo/rolbck.cxx b/sw/source/core/undo/rolbck.cxx
index 54fcd33b6815..dd04451c0d84 100644
--- a/sw/source/core/undo/rolbck.cxx
+++ b/sw/source/core/undo/rolbck.cxx
@@ -376,20 +376,15 @@ SwHistorySetTOXMark::SwHistorySetTOXMark( const 
SwTextTOXMark* pTextHt, sal_uLon
 static_cast(_TOXMark)->EndListeningAll();
 }
 
-void SwHistorySetTOXMark::SetInDoc( SwDoc* pDoc, bool )
+SwTOXType* SwHistorySetTOXMark::GetSwTOXType(SwDoc& rDoc, TOXTypes eTOXTypes, 
const OUString& rTOXName)
 {
-SwTextNode * pTextNd = pDoc->GetNodes()[ m_nNodeIndex ]->GetTextNode();
-OSL_ENSURE( pTextNd, "SwHistorySetTOXMark: no TextNode" );
-if ( !pTextNd )
-return;
-
 // search for respective TOX type
-const sal_uInt16 nCnt = pDoc->GetTOXTypeCount( m_eTOXTypes );
+const sal_uInt16 nCnt = rDoc.GetTOXTypeCount(eTOXTypes);
 SwTOXType* pToxType = nullptr;
 for ( sal_uInt16 n = 0; n < nCnt; ++n )
 {
-pToxType = const_cast(pDoc->GetTOXType( m_eTOXTypes, n ));
-if ( pToxType->GetTypeName() == m_TOXName )
+pToxType = const_cast(rDoc.GetTOXType(eTOXTypes, n));
+if (pToxType->GetTypeName() == rTOXName)
 break;
 pToxType = nullptr;
 }
@@ -397,9 +392,21 @@ void SwHistorySetTOXMark::SetInDoc( SwDoc* pDoc, bool )
 if ( !pToxType )  // TOX type not found, create new
 {
 pToxType = const_cast(
-pDoc->InsertTOXType( SwTOXType( m_eTOXTypes, m_TOXName )));
+rDoc.InsertTOXType(SwTOXType(eTOXTypes, rTOXName)));
 }
 
+return pToxType;
+}
+
+void SwHistorySetTOXMark::SetInDoc( SwDoc* pDoc, bool )
+{
+SwTextNode * pTextNd = pDoc->GetNodes()[ m_nNodeIndex ]->GetTextNode();
+OSL_ENSURE( pTextNd, "SwHistorySetTOXMark: no TextNode" );
+if ( !pTextNd )
+return;
+
+SwTOXType* pToxType = GetSwTOXType(*pDoc, m_eTOXTypes, m_TOXName);
+
 SwTOXMark aNew( m_TOXMark );
 aNew.RegisterToTOXType( *pToxType );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - sw/qa

[Xisco Fauli (via logerrit)]

 sw/qa/uitest/writer_tests/data/tdf135018.odt |binary
 sw/qa/uitest/writer_tests/trackedChanges.py  |   36 +++
 2 files changed, 36 insertions(+)

New commits:
commit b87fa88ee93601703394dd97be9b101370ecf1a5
Author: Xisco Fauli 
AuthorDate: Tue Sep 1 17:30:44 2020 +0200
Commit: Michael Stahl 
CommitDate: Wed Oct 28 16:51:06 2020 +0100

tdf#135018: sw: Add UItest

Change-Id: Ia88e28b1569ea69df81d905cb76a6791a887ef3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101883
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 
(cherry picked from commit b6ab2330d97672936edc56de8d6f5b6f772908ff)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104941
Tested-by: Michael Stahl 
Reviewed-by: Michael Stahl 

diff --git a/sw/qa/uitest/writer_tests/data/tdf135018.odt 
b/sw/qa/uitest/writer_tests/data/tdf135018.odt
new file mode 100644
index ..2dc9e2a4da0d
Binary files /dev/null and b/sw/qa/uitest/writer_tests/data/tdf135018.odt differ
diff --git a/sw/qa/uitest/writer_tests/trackedChanges.py 
b/sw/qa/uitest/writer_tests/trackedChanges.py
index 5bc8fecf7b03..bf98162cdda5 100644
--- a/sw/qa/uitest/writer_tests/trackedChanges.py
+++ b/sw/qa/uitest/writer_tests/trackedChanges.py
@@ -7,9 +7,13 @@
 
 from uitest.framework import UITestCase
 from uitest.debug import sleep
+from uitest.path import get_srcdir_url
 import time
 from uitest.uihelper.common import get_state_as_dict, type_text
 
+def get_url_for_data_file(file_name):
+   return get_srcdir_url() + "/sw/qa/uitest/writer_tests/data/" + file_name
+
 class trackedchanges(UITestCase):
 
 def test_tdf91270(self):
@@ -151,4 +155,36 @@ class trackedchanges(UITestCase):
 self.assertEqual(document.Text.String[0:30], "Test LibreOffice Test2 
Test4")
 
 self.ui_test.close_doc()
+
+def test_tdf135018(self):
+self.ui_test.load_file(get_url_for_data_file("tdf135018.odt"))
+xWriterDoc = self.xUITest.getTopFocusWindow()
+xWriterEdit = xWriterDoc.getChild("writer_edit")
+document = self.ui_test.get_component()
+
+self.assertEqual(5, document.CurrentController.PageCount)
+
+
self.ui_test.execute_modeless_dialog_through_command(".uno:AcceptTrackedChanges")
+xTrackDlg = self.xUITest.getTopFocusWindow()
+changesList = xTrackDlg.getChild("writerchanges")
+self.assertEqual(147, len(changesList.getChildren()))
+
+# Without the fix in place, it would have crashed here
+xAccBtn = xTrackDlg.getChild("acceptall")
+xAccBtn.executeAction("CLICK", tuple())
+
+self.assertEqual(0, len(changesList.getChildren()))
+
+xUndoBtn = xTrackDlg.getChild("undo")
+xUndoBtn.executeAction("CLICK", tuple())
+
+self.assertEqual(147, len(changesList.getChildren()))
+
+xcloseBtn = xTrackDlg.getChild("close")
+xcloseBtn.executeAction("CLICK", tuple())
+
+#self.assertEqual(18, document.CurrentController.PageCount)
+
+self.ui_test.close_doc()
+
 # vim: set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 134509] FILEOPEN DOCX: Text behind image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=134509

Attila Bakos (NISZ)  changed:

   What|Removed |Added

   Assignee|bakos.attilakar...@nisz.hu  |libreoffice-b...@lists.free
   ||desktop.org
 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137815] Draw right click context menu has Page and Properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137815

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #11 from Heiko Tietze  ---
So far three times -1, no need to bring this up in the meeting.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 137815] Draw right click context menu has Page and Properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137815

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #11 from Heiko Tietze  ---
So far three times -1, no need to bring this up in the meeting.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 131540] FILESAVE DOCX OLE object anchored to page moves on saving

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131540

Attila Bakos (NISZ)  changed:

   What|Removed |Added

   Assignee|bakos.attilakar...@nisz.hu  |libreoffice-b...@lists.free
   ||desktop.org
 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122717] FILEOPEN Horizontal line in DOCX has wrong size/position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122717

Attila Bakos (NISZ)  changed:

   What|Removed |Added

   Assignee|bakos.attilakar...@nisz.hu  |libreoffice-b...@lists.free
   ||desktop.org
 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137825] Images from docx are moved and jumbled when opened with LibreOffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137825

Telesto  changed:

   What|Removed |Added

Version|7.0.1.2 release |4.0.0.3 release
 CC||libreoff...@nisz.hu,
   ||tele...@surfxs.nl
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #4 from Telesto  ---
Repro with
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 94e6e140491de31c0788c91af855a75a3bb12709
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

Version: 5.4.0.0.alpha1+
Build ID: 9feb7f7039a3b59974cbf266922177e961a52dd1
CPU threads: 4; OS: Windows 6.29; UI render: GL; 
Locale: nl-NL (nl_NL); Calc: CL

Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL

Versie 4.0.0.3 (Bouw-id: 7545bee9c2a0782548772a21bc84a9dcc583b89)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137827] New: French version: shortcut ‘Re_père de texte’ does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137827

Bug ID: 137827
   Summary: French version: shortcut ‘Re_père de texte’ does not
work
   Product: LibreOffice
   Version: 7.0.1.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tor...@yahoo.com

French version. Insertion menu. ‘Re_père de texte’ (bookmark) is supposed to
respond to ‘p’; it does not.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: helpcontent2

[Seth Chaiklin (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9699516d3e979f776b1ecb04390719b538f440d5
Author: Seth Chaiklin 
AuthorDate: Wed Oct 28 17:40:37 2020 +0200
Commit: Gerrit Code Review 
CommitDate: Wed Oct 28 16:40:37 2020 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to c8a9ac72bc5e68f8a69490e3c157fe26b935f524
  - tdf#131206  update "Select" section in Insert Document field tab help

The focus is the  with id "auswahl".  This section
is embedded from swriter/01/04090001.xhp to swriter/01/04090004.xhp
(no other pages found that embed section "auswahl" from 
04090001.xhp)

( swriter/01/04090001.xhp )
  - change section id from "auswahl" to "select"
  - delete one paragraph (about formatting) because
already mentioned in both help pages.
  - move paragraph about "offset" down to the "Offset"
section.  "Offset" does not appear in the
tab for 04090004.xhp, so no need to embed it.

( swriter/01/04090004.xhp )
   change select id from "auswahl" to "select"

Change-Id: Id238a7187595eca0d1ecc0d38fd3c27917f7e984
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104949
Reviewed-by: Seth Chaiklin 
Tested-by: Jenkins

diff --git a/helpcontent2 b/helpcontent2
index 13b33e0bff78..c8a9ac72bc5e 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 13b33e0bff785539fc858e1523cf68186531fd96
+Subproject commit c8a9ac72bc5e68f8a69490e3c157fe26b935f524
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Seth Chaiklin (via logerrit)]

 source/text/swriter/01/04090001.xhp |7 ++-
 source/text/swriter/01/04090004.xhp |2 +-
 2 files changed, 3 insertions(+), 6 deletions(-)

New commits:
commit c8a9ac72bc5e68f8a69490e3c157fe26b935f524
Author: Seth Chaiklin 
AuthorDate: Wed Oct 28 16:43:10 2020 +0200
Commit: Seth Chaiklin 
CommitDate: Wed Oct 28 16:40:37 2020 +0100

tdf#131206  update "Select" section in Insert Document field tab help

The focus is the  with id "auswahl".  This section
is embedded from swriter/01/04090001.xhp to swriter/01/04090004.xhp
(no other pages found that embed section "auswahl" from 04090001.xhp)

( swriter/01/04090001.xhp )
  - change section id from "auswahl" to "select"
  - delete one paragraph (about formatting) because
already mentioned in both help pages.
  - move paragraph about "offset" down to the "Offset"
section.  "Offset" does not appear in the
tab for 04090004.xhp, so no need to embed it.

( swriter/01/04090004.xhp )
   change select id from "auswahl" to "select"

Change-Id: Id238a7187595eca0d1ecc0d38fd3c27917f7e984
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104949
Reviewed-by: Seth Chaiklin 
Tested-by: Jenkins

diff --git a/source/text/swriter/01/04090001.xhp 
b/source/text/swriter/01/04090001.xhp
index de9b2ea05..45cb67033 100644
--- a/source/text/swriter/01/04090001.xhp
+++ b/source/text/swriter/01/04090001.xhp
@@ -145,15 +145,11 @@
 The following fields can only be 
inserted if the corresponding field type is selected in the Type 
list.
 
 
-
+
 
-
 Selecton "Document" and 
"DocInformation" tab page this is called "Select", on the other tab pages 
"Selection"
 Lists the available fields for 
the field type selected in the Type list. To insert a field, click 
the field, and then click Insert.
 To quickly insert a field from the 
Select list, double-click the field.
-
-In the 
Format, click the numbering format that you want to 
use.
-If you want, 
you can enter an Offset for the displayed page number. With an 
Offset value of 1, the field will display a number that is 1 more 
than the current page number, but only if a page with that number exists. On 
the last page of the document, this same field will be empty.
 
 
 
@@ -182,6 +178,7 @@
 Offset
 Enter the offset value that you 
want to apply to a page number field, for example "+1".
 
+If you want, 
you can enter an Offset for the displayed page number. With an 
Offset value of 1, the field will display a number that is 1 more 
than the current page number, but only if a page with that number exists. On 
the last page of the document, this same field will be empty.
 If you want to change the actual page 
number and not the displayed number, do not use the Offset value. 
To change page numbers, read the Page 
Numbers guide.
 
 Offset in days/minutes
diff --git a/source/text/swriter/01/04090004.xhp 
b/source/text/swriter/01/04090004.xhp
index 714101a63..6ac16a257 100644
--- a/source/text/swriter/01/04090004.xhp
+++ b/source/text/swriter/01/04090004.xhp
@@ -131,7 +131,7 @@
 
 
 Lists the available fields 
for the field type selected in the Type list. To insert a field, 
click the field, and then click Insert.
-
+
 For the "Created", "Modified", and 
"Last printed" field types, you can include the author, date, and time of the 
corresponding operation.
 
 Click the format that you 
want to apply to the selected field, or click "Additional formats" to define a 
custom format.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 137815] Draw right click context menu has Page and Properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137815

--- Comment #10 from andreas_k  ---
My opinion is Wantfix.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 137815] Draw right click context menu has Page and Properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137815

--- Comment #10 from andreas_k  ---
My opinion is Wantfix.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 137815] Draw right click context menu has Page and Properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137815

Telesto  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|WONTFIX |---

--- Comment #9 from Telesto  ---
Setting to UNCONFIRMED..like this on they regular UX meeting. Even if i'm
(likely) not attending

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 137815] Draw right click context menu has Page and Properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137815

Telesto  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|WONTFIX |---

--- Comment #9 from Telesto  ---
Setting to UNCONFIRMED..like this on they regular UX meeting. Even if i'm
(likely) not attending

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137643] Can't select font, no font dropdown list, if open MSO .doc in GTK3 only (gen and Skia OK)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137643

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137826] weird Heading 4

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137826

--- Comment #2 from tor...@yahoo.com ---
Created attachment 166812
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166812=edit
screenshot of result

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51510] FILESAVE: Exporting documents with embedded SVG to doc or docx converts the image to low-resolution pixel graphics

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=51510

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||9973

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119973] OOXML: Signed Signature Line EMF has black background in Windows GDI and Linux GTK3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119973

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=51
   ||510

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 137815] Draw right click context menu has Page and Properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137815

--- Comment #8 from Telesto  ---
(In reply to V Stuart Foote from comment #7)
> Properties dialog always belongs on the context menu.
> 
> The new Page sub menu adds convenience of the Rename, and New Page (from the
> Pages pane and menu) are nice to have. And while the 'Set background
> image...' dialog workflow can be done from the Properties dialog ->
> Background 'Bitmap' tab it requires a lot of user understanding that the new
> command simplifies. 
> 
> Presence of these controls on the context menu rather than on the Properties
> dialog is fine, and it not be helpful to reexpand the Properties dialog.

They Page Properties I'm able to get. They Page sub menu not so.

1. Dislike sub menu's in context menu in principle [are there guidelines?]. So
needs to avoided as far as possible. In context of costs/benefits. 
2) With the page sub menu present I'm inclined to move properties to the sub
menu (except simply less accessible). So not really an option..

--Renaming sub menu item
I prefer to see what I'm doing; noticing names of other pages and such. And
certain page needs to be selected
* Available in Page Panel being obvious choice
* And ideally in the right context menu of the sidebar/navigator [currently not
the case somehow, why not?)
* Selecting page & Pressing F2 (ouch, F2 using for insert text; this key
normally used for rename on Windows.. but there probably is shortcut)

--Background item sub menu
Can be set in 
* Menu Page -> background 
* Sidebar -> Page
* Right Click Context Menu -> Properties (will be page properties in the
future)
And maybe even right click -> Slide/Page panel (currently not the case).

But in the context menu. Not seeing the point (as a default)

--New page/delete page sub menu item
Prefer this doing a point where you can see slides. So page/slide panel. And
maybe navigator context menu (currently not present)
And Page menu -> New page

And I personally select a page in panel & press Delete key. Surely not taking
the de-tour in a context menu. New page has (can have?) a short cut to.. 

They context menu is really superfluous. If people find it useful for some
reason, fine. But they should add it themselves. There enough ways of reaching
the goal. And the Context Menu entry surely most logical thing. 
---

I qualify this as an (superfluous) customization, IMHO. LibreOffice should
deliver some workflow. Not making every workflow possible in advance.

And if there is a need for such commands, combine those in different template
configurations. Or let people share their dialog customization (similar to the
Personas thing)

That's possible to have different workflows, doesn't every workflow should by
present in they UI by default (bloating stuff).

You put commands at positions where it's "obvious" to look. And right click
context menu on page have certain page settings doesn't that criteria, IMHO

I can't explain more clearly, it simply feels off/wrong.

And with more specific design principles, this might be 'obvious'. While my
argument maybe not followed here, this same argument will be brought up in
other case.. To archive they opposite. We can't add a new command in a sub
menu.. because  ...

And cherry picking argument or selective weighting arguments being something I
really dislike. There is simply not not a consistent pattern. Which kind of
infuriating  

Design principles/guidelines are still guidelines. So still a possibility to do
it differently. However there must be good arguments for doing so. But there a
kind of barrier.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 137815] Draw right click context menu has Page and Properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137815

--- Comment #8 from Telesto  ---
(In reply to V Stuart Foote from comment #7)
> Properties dialog always belongs on the context menu.
> 
> The new Page sub menu adds convenience of the Rename, and New Page (from the
> Pages pane and menu) are nice to have. And while the 'Set background
> image...' dialog workflow can be done from the Properties dialog ->
> Background 'Bitmap' tab it requires a lot of user understanding that the new
> command simplifies. 
> 
> Presence of these controls on the context menu rather than on the Properties
> dialog is fine, and it not be helpful to reexpand the Properties dialog.

They Page Properties I'm able to get. They Page sub menu not so.

1. Dislike sub menu's in context menu in principle [are there guidelines?]. So
needs to avoided as far as possible. In context of costs/benefits. 
2) With the page sub menu present I'm inclined to move properties to the sub
menu (except simply less accessible). So not really an option..

--Renaming sub menu item
I prefer to see what I'm doing; noticing names of other pages and such. And
certain page needs to be selected
* Available in Page Panel being obvious choice
* And ideally in the right context menu of the sidebar/navigator [currently not
the case somehow, why not?)
* Selecting page & Pressing F2 (ouch, F2 using for insert text; this key
normally used for rename on Windows.. but there probably is shortcut)

--Background item sub menu
Can be set in 
* Menu Page -> background 
* Sidebar -> Page
* Right Click Context Menu -> Properties (will be page properties in the
future)
And maybe even right click -> Slide/Page panel (currently not the case).

But in the context menu. Not seeing the point (as a default)

--New page/delete page sub menu item
Prefer this doing a point where you can see slides. So page/slide panel. And
maybe navigator context menu (currently not present)
And Page menu -> New page

And I personally select a page in panel & press Delete key. Surely not taking
the de-tour in a context menu. New page has (can have?) a short cut to.. 

They context menu is really superfluous. If people find it useful for some
reason, fine. But they should add it themselves. There enough ways of reaching
the goal. And the Context Menu entry surely most logical thing. 
---

I qualify this as an (superfluous) customization, IMHO. LibreOffice should
deliver some workflow. Not making every workflow possible in advance.

And if there is a need for such commands, combine those in different template
configurations. Or let people share their dialog customization (similar to the
Personas thing)

That's possible to have different workflows, doesn't every workflow should by
present in they UI by default (bloating stuff).

You put commands at positions where it's "obvious" to look. And right click
context menu on page have certain page settings doesn't that criteria, IMHO

I can't explain more clearly, it simply feels off/wrong.

And with more specific design principles, this might be 'obvious'. While my
argument maybe not followed here, this same argument will be brought up in
other case.. To archive they opposite. We can't add a new command in a sub
menu.. because  ...

And cherry picking argument or selective weighting arguments being something I
really dislike. There is simply not not a consistent pattern. Which kind of
infuriating  

Design principles/guidelines are still guidelines. So still a possibility to do
it differently. However there must be good arguments for doing so. But there a
kind of barrier.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 137826] weird Heading 4

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137826

--- Comment #1 from tor...@yahoo.com ---
Created attachment 166811
  --> https://bugs.documentfoundation.org/attachment.cgi?id=166811=edit
file with textbody to change

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs